TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0+004](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3482&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2998 Build time: 0:0:0


TeamCity ChameleonForms :: Continuous Integration [Build 214](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3483&buildTypeId=bt20) is now running


maybe add a comment here.  This wasn't obvious on the first read


Если после `case` не стоит `break`, то свитч проваливается в следующее правило, поэтому, можно переписать вот так:
```java
switch (traceOutput.type()) {
case SEARCH_BEGIN:
	createWindow(traceOutput);
	break;
case SEARCH_OPEN:
case SEARCH_SPAWN_NEW:
case SEARCH_SPAWN_WORSE:
case SEARCH_SPAWN_BETTER:
case SEARCH_DECISION:
case SEARCH_END_SUCCESS:
	traceOutput = upToSearchBegin(traceList, traceOutput);
	createWindow(traceOutput);
	break;
default:
	break;
```
Фигурные скобки тоже не обязательно.


`An array of files paths` would be simplier


Create a method that returns early


This seems to break another workaround, specifically for the script named "float" in the vanilla game files. Launch the game and then enter

startscript "float"

which results in

error line 2, column 1 (<newline>)
    Unexpected special token

Curiously, when using the --script-all switch, the script appears to compile just fine. Maybe there are differences in how the --script-all compiler is set up?

Would it make sense to set up a wiki page documenting all script workarounds, the affected content, location in the code, etc?


Throw if the type is not handled


It's fine to move ahead with description.yaml when we know we'll be going to yaml eventually, as long as that transition is not too distant.
It's less fine to create logging.yaml when we know we'll be going to log4cxx.properties (or .xml), although given that it is a "quick and dirty" solution (with an emphasis on quick), it's not unacceptable.
It's much less fine to have this discussion in a code review instead of up front when the implementation choice was being made.


Немного более грамотным решением мне кажется передача в метод `upToSearchBegin` не `traceOutput`, а индекса. Тогда, если `SEARCH_BEGIN` не был найден можно честно вернуть `null`, что приведет к какому-нибудь эксепшену и мы сразу заметим, что где-то в либе есть внутренняя ошибка.


Declare as `List`


@mtwebster I'll try to test this with my sticky notes applet when I get the chance. Right now my desktop is having hardware issues, and I'm currently borrowing a windows laptop from my fiancee, so I can't do it right now though.


r=huonw p=100000


the idea under linux is not to depend on apothecary since there's already a good package manager and it's the natural way to install libraries. we've been removing packages since years ago and it would be good to create native packages for the missing ones for at least debian. if it was something bigger i would say it's better to compile the library but being only 3 ifdefs i think it's better to keep it as it is. it also makes the codebase compatible with older systems given that GL 4.5 is so new


This seems to make reflection work, although part of me likes the old commit on its own more. It seems nice to be respectful of the default parameters, but the readability cost is pretty high and this is pretty fragile in the face of more changes to `compile`'s method signature.


80757414-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0+005](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3483&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2343 Build time: 0:0:0


c'est la signature de la fonction dans l'interface


Yeah I was a bit hesitant to add the `setImmediate`.  But in my tests if you try to test with concurrency of about ~2500 on a c3.large, it failed without the `setImmediate`

Even though `http.handleRequest` executes asynchronously, an app can make so many requests to `loadCredentials` in the same execution of the event loop that it take over 1 second before the I/O from the http request is processed, resulting in a timeout / credential error. On a c3.large it takes ~2500 concurrent requests to hit that error, which seems like a lot, but its easy to hit when relying on `http.GlobalAgent.maxSockets` to be the limit of concurrent sockets.

What made me hesitant is that I dont know of any side effects that might have. I think it should be fine, and has been in every test. Do you have any specific concerns?


Static import the types


TIL Debian Potato is a thing :D


In *num2words.h* there is no **','** i line 5, after  *CA    = 0x0*


I am a nice comment


Add a helper `assertSorted(inputPages, expectedPages)`


Why not use the methods from `SyntheticAddress`?


delete one outer


Why not Laravel 5?


Extra newline


@serprex Good catch!


Or let me take that back: there is a mutual dependence on an upcoming change in Rcpp requiring a change in dplyr, which is what I am waiting for dplyr to get to CRAN. Generally speaking, I know less about dplyr.

So my comment was mostly about BH: it shouldn't break anything, or else nobody told me. AFAIK they use Boost components which have long been in BH so no need for bleeding edge (and I generally have very little drift between GH and CRAN here so may as well use CRAN).

And that said I like having things like htmlwidgets up there.  Nice stuff -- so thumbs up.


Will this be in 3.4?


Just FYI, tools.reader will return nil rather than -1 in this case
tools.reader.reader-types/read also returns chars rather than ints.


"This interface is not stable and will not be supported in future releases."


TeamCity ChameleonForms :: Continuous Integration [Build 215](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3484&buildTypeId=bt20) is now running


this looks like a duplicate?


Right, but 2.5.55 seems to be the current repo release?  Meanwhile, primewire are appending '-online-free'...


I don't think this comment is accurate. It is actually the page index and the position index.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9765/testReport/) for this commit**


I was also able to fix the case API to work with custom data - but I couldn't make the test work due to enotices in the subscriber framework - one which CRM-15785 should fix but I gave up on this one. I'll try to make a record of the patch code somewhere as I don't really want to fix the bug if I can't get the test to work

1) api_v3_SyntaxConformanceTest::testCustomDataGet with data set #6 ('Case')
Failure in api call for Case create:  Failed to parse CaseType XML: Line=1 Column=1 Code=4: Start tag expected, '<' not found
#0 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Case/XMLProcessor.php(69): CRM_Case_XMLRepository->retrieve('name_21')
#1 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Case/XMLProcessor/Process.php(626): CRM_Case_XMLProcessor->retrieve('name_21')
#2 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/CCase/Events.php(92): CRM_Case_XMLProcessor_Process->getListeners('name_21')
#3 [internal function]: Civi\CCase\Events::delegateToXmlListeners(Object(Civi\CCase\Event\CaseChangeEvent))
#4 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatch
er.php(164): call_user_func(Array, Object(Civi\CCase\Event\CaseChangeEvent))
#5 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatch
er.php(53): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'hook_civicrm_ca...', Object(Civi\CCase\Event\CaseChangeEvent))
#6 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Utils/Hook.php(1699): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('h
ook_civicrm_ca...', Object(Civi\CCase\Event\CaseChangeEvent))
#7 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/CCase/Events.php(79): CRM_Utils_Hook::caseChange(Object(Civi\CCase\Analyzer))
#8 [internal function]: Civi\CCase\Events::fireCaseChangeForRealz(1)
#9 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/Core/Transaction/Frame.php(185): call_user_func_array(Array, Array)
#10 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/Core/Transaction/Frame.php(138): Civi\Core\Transaction\Frame->invokeCallbacks(2)
#11 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/Core/Transaction/Manager.php(115): Civi\Core\Transaction\Frame->finish()
#12 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Core/Transaction.php(140): Civi\Core\Transaction\Manager->dec()
#13 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/CRM/Core/Transaction.php(127): CRM_Core_Transaction->commit()
#14 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/API/Subscriber/TransactionSubscriber.php(157): CRM_Core_Transaction->__destruct()
#15 [internal function]: Civi\API\Subscriber\TransactionSubscriber->onApiRespond(Object(Civi\API\Event\RespondEvent))
#16 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatc
her.php(164): call_user_func(Array, Object(Civi\API\Event\RespondEvent))
#17 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatc
her.php(53): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'api.respond', Object(Civi\API\Event\RespondEvent))
#18 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/API/Kernel.php(221): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('
api.respond', Object(Civi\API\Event\RespondEvent))
#19 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/Civi/API/Kernel.php(98): Civi\API\Kernel->respond(Object(Civi\API\Provider\MagicFunctio
nProvider), Array, Array)
#20 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/api/api.php(25): Civi\API\Kernel->run('Case', 'create', Array, NULL)
#21 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php(850): civicrm_api('Case', 'create', Array)
#22 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php(882): CiviUnitTestCase->civicrm_api('Case',
 'create', Array)
#23 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/tests/phpunit/api/v3/SyntaxConformanceTest.php(596): CiviUnitTestCase->callAPISuccess('
Case', 'create', Array)
#24 [internal function]: api_v3_SyntaxConformanceTest->testCustomDataGet('Case')
#25 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestCase.php(942): ReflectionMethod->invokeArgs(Object(api_v
3_SyntaxConformanceTest), Array)
#26 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php(182): PHPUnit_Framework_TestCase->runTest()
#27 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestCase.php(804): CiviUnitTestCase->runTest()
#28 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestResult.php(649): PHPUnit_Framework_TestCase->runBare()
#29 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestCase.php(751): PHPUnit_Framework_TestResult->run(Object(
api_v3_SyntaxConformanceTest))
#30 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestSuite.php(772): PHPUnit_Framework_TestCase->run(Object(P
HPUnit_Framework_TestResult))
#31 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestSuite.php(745): PHPUnit_Framework_TestSuite->runTest(Obj
ect(api_v3_SyntaxConformanceTest), Object(PHPUnit_Framework_TestResult))
#32 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/Framework/TestSuite.php(705): PHPUnit_Framework_TestSuite->run(Object(
PHPUnit_Framework_TestResult), '/ustom/', Array, Array, false)
#33 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/TextUI/TestRunner.php(325): PHPUnit_Framework_TestSuite->run(Object(PH
PUnit_Framework_TestResult), '/ustom/', Array, Array, false)
#34 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/TextUI/Command.php(232): PHPUnit_TextUI_TestRunner->doRun(Object(PHPUn
it_Framework_TestSuite), Array)
#35 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/packages/PHPUnit/TextUI/Command.php(139): PHPUnit_TextUI_Command->run(Array, true)
#36 /home/vagrant/civicrm-buildkit/build/drupal-demo/sites/all/modules/civicrm/tools/scripts/phpunit(80): PHPUnit_TextUI_Command::main()
#37 {main}
Failed asserting that 1 matches expected 0.


I think the comment in `SyntheticAddress` is outdated too.


Is rfxdata.h missing from this commit?


@jglick From what you wrote this seems to be the plan already ("*with a page from which you can look at the instructions*").


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0-PullRequest112+007](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3484&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2998 Build time: 0:0:0


Defensive copy


This is still definitely a long way from working... perhaps a Fragment isn't the correct approach. Some issues:

* getDialog().setCanceledOnTouchOutside(true) runs into a NullPointerException for some reason.
* The dialogs always appear in the top left. It's possible that another view is needed from within TicTacGoGame.java, which we can put in the correct location. As is, I'm not sure which view to attach which parameters to.
* I cannot specify which code in TicTacGoGame to return to. Perhaps it's onResume, but that will execute at other times as well.


Hi Dean,

Thanks for this. I agree this is an important fix for the default login template.

This commit doesn't work as-is on my demo site though; the `csrf_token` twig extension isn't defined. Do we need to add a dependency to the silex-simpleuser/composer.json? (Maybe `symfony/security-csrf`? I'd prefer not to require the symfony form component if we don't absolutely have to).

Thanks,
Jason


Static import `nCopies`


Good idea


@dziner Try using the "Developer Command Prompt for VS2013" from the "Visual Studio Tools" folder. Apparently the cross tools command prompt sets some variables that confuse the build.


API required infos


r+ rollup thanks!


Yes, that's correct. I haven't released a fix yet for the online-free isuse yet. IT's currently in the beta release.


What's the thinking behind this removal?

It makes a lot of sense to check for both formatting types of camel & snake-case - it's a nice feature to have.


It's a security concern as someone could bypass validation.

On Monday, January 5, 2015, James Healey <notifications@github.com> wrote:

> What's the thinking behind this removal?
>
> It makes a lot of sense to check for both formatting types of camel &
> snake-case - it's a nice feature to have.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/framework/commit/9cf377444a3b84ee3984d4324704f9e7b27426fd#commitcomment-9162585>
> .
>


import json required libs


Put the whitespace on the left side so the `AND` is right aligned


r+


Add restart action in one function to be callable from everywhere


saw approval from glennw
at https://github.com/mbrubeck/servo/commit/f534ce2ab0a809682a2fa3a31007789529129e7b


merging mbrubeck/servo/scroll-cleanup = f534ce2a into auto


mbrubeck/servo/scroll-cleanup = f534ce2a merged ok, testing candidate = cf616b90


Bytes to nice size!


This is available in 1.14, which will be released on CurseForge shortly.


Add pretime converter in one function to be callable from everywhere (now also required by API)


.get <search>


I was working a few days during holidays and I met a blocking bug in Qserv which requires having clear log messages (previous ones were not very nice).
I've made these implementation choices because they minimize a lot the code I had to write:
- yaml logging configuration is straightforward and all our admin modules where already using standard python logging so it was a not intrusive way to integrate log configuration accross admin/third-party module,
- yaml integration tests configuration removes previous ugly hard-coded parameters and so allows to remove some ugly code for a very low cost (around one or two line to parse a yaml file in python).
I'm ok to implement nice and official solutions to these side problems (from an integration tests point of view) in future tickets.


reasons for this approach:
- don't want to re-use code for labels (we could just have inputRadio, inputText, inputTextarea, ... components, but each would need the exact same code/styling for labels and positioning)
- label is parent of inputs (otherwise wouldn't have inputLabel take a component as a param)

usage:

```coffee

InputLabel = require '../input_label'
InputText = require '../input_text'
InputRadio = require '../input_radio'

styles = require './index.styl'

module.exports = class Something
  constructor: ->
    styles.use()

    @state = z.state
      someTextField: new InputLabel {
        label: 'Some Text Field'
        input: new InputText value: ''
      }
      someRadio: new InputLabel {
        label: 'Some Radio'
        input: new InputRadio()
      }

      grabSomeData().then (data) =>
        @state().someTextField.input.setValue data.value
```


I don't like space in files names, like linux does!


Tonight I'm going to start work on adding the sandbox to nix proper, so we don't needs a global set of exceptions!


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/6282/testReport/) for this commit**


Making the `duplicate()` method public makes sense, since it is public in the base class.


The concern is mostly around browser compatibility. Using `setImmediate` would break anyone trying to use this from a browser (an edge case, but still possible today). Even my Chrome browser does not yet have setImmediate support, so it's a fairly unreliable operation in terms of portability. Also relying on `.bind` would break a handful of older (but supported) browsers too.


Missing the 'bundle install' step?


> You added this option, but it is not used.

Right.  In which context are you interested in it?  From ttx command-line?

> Why did you do that optimization (merge consecutive PUSH and remove distinction between PUSHB and PUSHW) on import. This should, if at all, be done on export with a optional setting.

The reason was to make TTX roundtripping less noisy.  That is, if you go from TTX file to TTF and back to TTX, I want to get the exact same TTX file.  Hiding this optimization was the easiest way to do that.  After all, to the user, there is no difference between PUSHB and PUSHW.


Bikeshedding: `next` vs. `page`?


Nope. This method has the same name and signature


Le fel si tie ;-)


Thanks again. I cherry-picked the commits into my branch now. Unfortunately it does not show your name as the author, but I have a reference to the commit in my comment.

I compiled the code with in this state: https://github.com/gitMarky/openclonk/commit/36e745bb4b52db12781d30f1cf596905a173b31b and reloading works, except for the known warning debug log.
The "central skeleton loader" commit is not really helpful as a single commit, so I would create a squashed commit from that branch and push it to master. Just give it a quick look.


What is the reason for adding underscore to local variable name?


Know bug: API return wrong pretime, so the bot too (i will resolve this with the API's coder tomorrow)


`format` needs to be renamed to `_format` here as well?


Good catch! Thank you, Paul.

However, I think a better fix is simply to change line 347 like this:

    $affected->{$ref}{ids} = [$git->get_commits(@range)];

The get_commits method already knows about the null commits edge cases and implements the fix for them.

What do you think?


I also meet the same problem, however I think this fix may break things in some edge cases.
I think when compareing date, we need to cast the ISO date string to Date object only when model type is `date` or `datetime`


current python suggest classes to derive from object, i'm rewriting this as class EventLogger(object):


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/6283/testReport/) for this commit**


I think `paging` is a very confusing name for something that's specifying the page size. Perhaps `pageSize` ?


It's an error, but please note that this code should be removed when we will have a common configuration file for all python module. This step should be done in the config file and not in the code.


with @mmaker we decided to not write defaults for languages but to make them be always passed. we are currently never using the defaults


Me gusta bastante como quedó.


Is 'rt' a valid open mode or did you mean 'rU'?


83442720-ERVZoneMult-Issue4338 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1581 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93678887484198%25-yellow.svg)


commands module is only available in python2, must be replaced by subprocess getoutput for full compatibility


Can you fix this in current branch?


I think that this may still need to account for plugins themselves, anything with `#[phase(plugin)]` doesn't need to be linked, right? (may have caused the error you were seeing on the android bot).


Right back at you!!


Per Robert's suggestion in previous comments.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/465
success: http://build.servo.org/builders/linux2/builds/464
success: http://build.servo.org/builders/android/builds/500
success: http://build.servo.org/builders/mac1/builds/681
success: http://build.servo.org/builders/mac2/builds/682


geeze, enough [package] hierarchy at Goldman Sachs? Why am I not surprised...


> Right. In which context are you interested in it? From ttx command-line?

I like to use it for debugging instructions.
And that is the reason I would like to see what is in the font, not some optimized version of it.

The goal should be to roundtrip ttf > ttx > ttf and get the same ttf, not the other way as you suggested. Now the font is loosing 4.5% of its GPOS table (that was written by makeOTF; ~46 kB to 44 kB) and on a few other places. On the one hand, this can be a great improvement but can be a bit frightening, too.


I think I'm catching up here.  `clone` used to call the private `duplicate` function, which was kind of silly.  So you got rid of `clone` and just made `duplicate` do the right thing.  Good signature reduction.  But I might have left the `clone` name and gotten rid of `duplicate`.  `clone` has a widely understood meaning amongst programmers (e.g., http://www.cplusplus.com/forum/articles/18757).  There are a couple of different ways to read the name `duplicate`.


I have never seen s_ or t_ used in C# before. It seems like unnecessary hungarian notation and I would recommend not using it. The use of _ for private fields is pretty common however, your choice.

Also the addition of the "private" keyword on struct fields is unnecessary, I would recommend not adding those either.


La oración correcta sería «Els meus fitxers». Si quieres yo lo corrijo, estoy por enviar otro *commit*.


fast-forwarding master to auto = cf616b90


/receiver/notification(s); we noticed with @hellais that not all the api are aligned to what we designed initially;
a collection should use a plural, an instance should use a singular.

i will take care of the alignment of all the API in a later stage but i will fix this new one now.

\cc @vecna @mmaker


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9767/testReport/) for this commit**


this handler are missing unit test. i will implement them before mergin them tomorrow morning.


I think the problem is that I use ffmpeg, not avconv. I ran this command instead:
ffmpeg -i /path/to/video.mp4 2>&1 | grep 'Duration' | sed s#,##

The output was:
Duration: 00:03:02.05 start: 0.024188, bitrate: 12590 kb/s

I'm using lrsjng's 0.26.1+133~c7adecd version with your class-thumb.php file.


a # does not need a data-translate


This code looks bad in the before case too. It really shouldn't be a single-line if. :(


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9768/testReport/) for this commit**


Salut, ça fait plaisir de voir que quelqu'un reprend le projet. Je n'est plus la motivation depuis le temps ;)

Ravis que mes travaux servent ! (Et surtout il y as eux d'énormes changements entre temps, bon nombre de traductions ne sont plus valable)


commit this dream


what should i put here?


83442720-ERVZoneMult-Issue4338 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1581 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93678887484198%25-yellow.svg)


What do you see as the issues with cmake that need to be addressed by
switching to scons?
On Mon, 5 Jan 2015 at 20:48 James Crosby <notifications@github.com> wrote:

> I'm coming round to the idea of scons.
>
> We need to be careful not to push too much logic into the target
> descriptions though. What's nice about cmake is it gives individual modules
> a way to do arbitrarily complex things internally, as long as they conform
> to what is expected of modules externally. Can we make something similar
> possible with scons?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ARMmbed/yotta/commit/f0578ff47b321053fc848fe4b225a02556d97138#commitcomment-9159596>
> .
>


Also, I just wanted to add that using a static Random object in your tests may prevent you from parallelizing your unit tests deterministically (SetRandomSeed mutates shared state). You may want to consider changing your Util class to accept a random object in its methods instead of referring to a static field:

e.g.

    public static int[] GenerateRandomInts(this Random random, int numValues)
    {
        // ...
    }


Forgot to remove Gemfile.plugins from gitignore file which caused this, fixed in 1652d9c0076279c84526cdfbe3b95f6e23c28bd3


The fact is haxelib doesn't run properly in the haxe source folder by default. The reason is unclear. Related discussion: https://github.com/HaxeFoundation/haxelib/issues/49


Good :)

The main (only?) use case for ubam is when piping the output to another tool expecting BAM, this effectively removes the GZIP compression/decompression overhead which would otherwise be imposed. That is currently not something we can exploit in Galaxy (although there might be a Trello card for this it would be a major change), so I see no use for the ubam option within the Galaxy wrapper.


idは遠藤の端末でしか機能しないかもです


Oops, sorry about that! I'm not sure why I didn't use os.sep here.

Did you want me to make a fix?


I didnt consider using the metadata service from in a browser. If it's worth keeping that possibility around, I can avoid `.bind` and do a very simple `setImmediate` polyfill.  Something like:

```
request: function request(path, callback) {
    path = path || '/';

    var data = '';
    var http = AWS.HttpClient.getInstance();
    var httpRequest = new AWS.HttpRequest('http://' + this.host + path);
    httpRequest.method = 'GET';

    // polyfill for browsers
    if (!setImmediate) {
      var setImmediate = function(func) {
        setTimeout(func, 0);
      };
    }

    setImmediate(function() {
      http.handleRequest(httpRequest, this.httpOptions, function(httpResponse) {
        httpResponse.on('data', function(chunk) { data += chunk.toString(); });
        httpResponse.on('end', function() { callback(null, data); });
      }, callback);
    });
  },
```

I'm open to more elegant solutions


I makes the code harder to read because it depends on multiple sources of enums (PlanDistribution, OutputPartitioning). I'll add an import for PlanDistribution so that at least we can get rid of the PlanFragment prefix.


:smile:


I think this works.


I'm trying to download the 1.0.5 dmg file but the link is not valid.  Can you take a look at this issue?


host-model works on my current up2date rhel7 host.  I'm not sure how to see whether host or host-model is available as options to --cpu, however.


This file isn't even compiled.


Huh.  Just wondering, does anyone construct a plain-old `STBase`?  At first blush it seems like folks should always be creating something more derived. But `STBase` is not pure virtual.  My knee-jerk reaction is that the `duplicate` (or `clone`) method should be pure virtual.  But I certainly don't know the whole story here.


gné?


I totally agree. I think this was the reason I removed it at first place. I forgot to grep for it in the other wrappers. Thanks to @nsoranzo every occurrence is now removed.


the change here looks fantastic, it reads nicely as an if-then-else.


I can't think of a reason a user would do this TBH. We may as well take the one from the user registry if it's there though.


Actually I would suggest using `process.nextTick()`, as I believe that would be polyfilled through browserify. I know there is a technical distinction between the two calls, but this might be the best compromise.


nit: `case ... if ... =>`


Yep, snuck in when I was pulling commits from my other repo..


Fixes #35


I am lovin' all the `override`s.  Only two questions: Might the `duplicate` method be better with the name `clone`?  Should `STBase` be pure virtual?  I don't feel strongly about those.  Mostly lofting them for consideration.  Looks good.


:beers:


Isn't 'right' a dataset too? Or something that responds to "to_a"


oh yeah
@NicolasPetton @herby thanks for the confidence
send!
you have my email, yes @NicolasPetton ?


Ahh alright, just confused me.


> Right. In which context are you interested in it? From ttx command-line?
>
> I like to use it for debugging instructions.
> And that is the reason I would like to see what is in the font, not some optimized version of it.

That's a valid usecase, and I'll try to add a commandline for that.

> The goal should be to roundtrip ttf > ttx > ttf and get the same ttf

That's impossible and not really useful.  Many things in a font file can be represented in different (equivalent) ways.  The fonttools / ttx representation is supposed to a bit higher level than the wire format, and represent data in a logical way, not what's on the disk.

We do guarantee that for a ttf produced by fonttools then ttf > ttx > ttf you get the same ttf.

> not the other way as you suggested. Now the font is loosing 4.5% of its GPOS table (that was written by makeOTF; ~46 kB to 44 kB) and on a few other places. On the one hand, this can be a great improvement but can be a bit frightening, too.

If the original font creator did a very bad job of putting the GSUB/GPOS/GDEF table together, that's not going to survive fonttools.  I routinely implement better algorithms to put the font together in a more compact way.  GSUB/GPOS/GDEF can reuse the same object.  How you order the objects makes a difference in how much reuse can happen, etc.  In short, there's no one way to put together the table.  Some algorithms will produce a more compact table than others.

Same about which subformat you use for Coverage or ClassDef tables.  Or for many of the CFF CharMap structure.  Or even how much padding you add to glyphs.  I switched to adding no unnecessary padding byte.  The spec "recommends" padding but that is not required and all software works fine without padding.

Same about how you do flag compression when packing glyphs in a glyf table.  There is no one algorithm.  That one is very similar to the PUSHB/PUSHW change in fact.

The list goes on and on.


That's perfect! Thanks.


Ok. Updated


why the trimming


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9770/testReport/) for this commit**


@jeffmccune
The bouncy castle exclusion and associated setting of `JARS_NO_REQUIRE=true` on the scripting containers is not yet in stable.


I'd actually be `placement.equals(Optional.of(new PlacementProperties(PlacementProperties.Type.COORDINATOR_ONLY)));`

I'm not sure that's more readable


I would call it _cleanupWritesNoLaterThan_inlock(). or "CommittedKeys".


I know that you do this optimizations and I very much appreciate it. Mostly it is a good idea to do that but sometimes it would be good to be able to preserve as much as possible.


Should *_activeSnapshots.begin() be included? In another word, should "EqualTo" included?


Advantages of scons are: fewer non-python dependencies (no CMake+make/ninja, scons is a python module), more control over the build (we can build .o files instead of libraries without severe hacking), which is necessary for weak symbols to work, and basically make things work exactly how we choose to.

For CMake: having a well-defined, well-documented configuration language for the build of a module allows complete control of how the module builds, and makes it easy to conform to the expected interface of the module (produce a library with the same name as your module – using whatever custom CMake magic you like – and your module will play nicely with others).

CMake also comes with a well-defined way of describing compilation targets and compilation toolchains.

i.e. scons has more flexibility, with more corresponding ability to screw up if we make the wrong choices. CMake has constraints on how the build has to work which many embedded software modules do not currently play well with.

It's the fewer external dependencies that's attractive for scons, to me.


still has the issue


If a transaction has a sequenceId then all keys committed at that sequenceId (EqualTo) can be removed because they don't impact the result of the function _isKeyCommittedAfterSnapshot_inlock()


Use native python call to get the listing.  i.e. `os.listdir()`


Can be 100% auto resolved


You are right.


Right.  I like to add an option to preserve "as much as possible".  The emphasis is on the last part.  Thanks :)


Cool, switched to `process.nextTick()` and confirmed that still works for concurrency of 10k on my c3.large. Force pushed to this branch, so the PR (https://github.com/aws/aws-sdk-js/pull/448) is up to date


I'm using foreman-bootstrap.bash on rhel7 - I had to change vftool.bash from "host-model" to "host" to make it work.  On rhel7, using "man virt-install" does not show a "host-model" option, only "host".   virt-install --help doesn't show anything.


r=sfackler, p=1


Yep, thanks.  I pushed 15acf46 to fix this failing test in stable.


You shouldn't need to make a partial. In general, mocking in this way is actually an antipattern and generally is a sign of a code smell. However, ocnsidering you're just making a view call - you can actually use the View facade and do a shouldReceive as a static method call.


I'm fine with whatever @whosawhatsis says. But I would like a way to disable the M200 prepend, if adding a ; M200 is the way to do it then I am fine with that.

FYI Firmware retract is always enabled  on Smoothie, if you don't use G10/11 then it won't be used.


Thank you very much for your answer, could you tell me how to just can completely solve the problem?


Please squash all changes related to "-p processing" (i.e. last two diff hunks) into commit e09782fddf3745750046c35db6370c0882a9c356.


开启伪静态了不会配置规则，除首页外都404了，论坛能出一篇详细教程指导小白开启伪静态就好了。感谢你这么及时的修复这个bug。


Turning all allocs to callocs might be a good try


Please squash this change into commit 5307ad3bfa4dbc500d1235411fccb407206483cd.


Here it only writes a pointer address like `9894544` :-1:


Safer to use `Article::chunk` here.


Please fix the authorship of this commit.


Ahh yes. Looks like that has lagged behind for some time now.


r=sfackler p=1


This change
   CountBitsInByte() -> CountBitsInByte[]
will cause a compile error in my side. Can you pass the compile?


I'm a little worried that asking for a new sync token as a separate step allows the possibility of missing certain events. It seems like it would be safer for findResources() to return the new sync-token so you could guarantee that the data returned by findResources and the next sync token were in sync.


I like replacing the `sort` method with `begin` and `end`.  Since we're doing C++11, is it worth also adding `cbegin` and `cend`?


Removing ", z=1" from line 244 (old)/247(new) causes Minetest to crash with a segmentaion fault/core dump. When I added that little bit back in, Minetest loaded the test world and got along just fine with Watershed.


r+ p=1


Note that it only works on DynCom with this PR.


这个应该是需要的:
http://wenda.wecenter.com/question/1895

我是使 .htaccess 在 apache2 下, 服务器和客户端都在国外, google fb twitter 很好.

-Never

2015-01-06 9:25 GMT+08:00 dipwater <notifications@github.com>:

> 开启伪静态了不会配置规则，除首页外都404了，论坛能出一篇详细教程指导小白开启伪静态就好了。感谢你这么及时的修复这个bug。
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wecenter/wecenter/commit/6514e8f7cc29af918a3095ebc47c16b230614e19#commitcomment-9163128>
> .
>


The only reason to not include M200 (or to comment it out with a semicolon) is if you're printing in extrude-by-millimeters mode. If you want to use the machine's stored diameter value, the firmware should not do that until it has received an M200 without a D value. Volumetric mode has to be off by default in the firmware to avoid breaking compatibility with everything else. Leaving the diameter in the filament profile set to 0 sounds like a good way to signal that M200 should be sent without a D value so that a stored diameter can be used (consistent with a bunch of other Slic3r settings that you can leave set to zero to say "figure it out for me").


No, in general these methods are "write once" to catch programming errors (they should only be set in one place, except for cases we're we "upgrade" the value, such as SINGLE->COORDINATOR_ONLY)


I just tried to build today on OSX and 60000 was not enough to avoid the error on my machine. FYI.


rax retry tests


omit self-evident comments


Now only RocksTransaction holds _lock. RocksTransactionEngine never holds it. I suggest moving this locking to RocksTransaction::recordSnapshotId() so that RocksTransactionEngine never holds it. It would make it harder to cause a dead lock by relocking it.


and,

URL 链接显示样式 系统提供的第一种, 点获取规则就可以了!

2015-01-06 9:31 GMT+08:00 Never Min <never.min@gmail.com>:

> 这个应该是需要的:
> http://wenda.wecenter.com/question/1895
>
> 我是使 .htaccess 在 apache2 下, 服务器和客户端都在国外, google fb twitter 很好.
>
>
> -Never
>
> 2015-01-06 9:25 GMT+08:00 dipwater <notifications@github.com>:
>
>> 开启伪静态了不会配置规则，除首页外都404了，论坛能出一篇详细教程指导小白开启伪静态就好了。感谢你这么及时的修复这个bug。
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/wecenter/wecenter/commit/6514e8f7cc29af918a3095ebc47c16b230614e19#commitcomment-9163128>
>> .
>>
>
>


`numMemoryReferences == 0`, i.e. `!hasMemoryReferences`?


not sure what is up with this but I will fix it afterward


ups! maybe I press 'return' as error :-1:


Instead of "insert", I would call it something like "track", "record" or something like that. "Insert" can be confused as inserting the data itself instead of tracking it's commit time.


Insufficient width for `zfs_vdev_async_write_active_max_dirty_percent`.

Also let's write this as a multi-line `if-else` to improve readability.


How to Repair the Hex On steroids which is the massage box error (Hex on Steroids encountered a critical error and will be terminated). Please reply !


Or use the existing word "register".


Wouldn't it be safer to just keep all tests against the firm backend?


Yes. Perhaps change SyncCollectionResource.findResourcesBySyncToken(..) to return resources and the current sync token..

ChildrenAndState findResourcesBySyncToken(..)
class ChildrenAndState {
    URI currentSyncToken;
    Map<String, Resource> children;
}

.. and then change line 163 in SyncCollectionReport so that findResources returns the current sync token..

private URI findResources(..)


“4，	在URL 自定义路由每行一条规则,中间使用===隔开”这一步是可有可无的吧，我目前是IIS，开启伪静态后未配置自定义路由。我的伪静态规则是下载的这个： http://wenda.wecenter.com/question/17035
现在结果是除首页外都404，bbs.xssrw.com


Good job! It looks pretty good to me, except some naming can be more clear for better readable.


I was doing this initially too, but its a best practice to use chaining instead of declaring an app level variable. That way your app object can't be mutated without you knowing, and you don't have to have that pesky global hanging around in your project. For me too, it makes the app feel more module driven. You can get the app conveniently elsewhere with angular's getter syntax, `angular.module('flapperNews')`, and then chain your methods from there on.


Personal site as well as my first repo.


*...if he/she owes < $0.01

Damn you bash parameter expansion!! \*shakes fist\*


Please word this as "The argument to -p must be between ..."


Huh.  I would have expected that `getFieldV256` would return an `STVector256`.  But I'm not seeing an `erase` method in `STVector256` in the previous commit.  Clearly this compiles, but I'm puzzled.  And this reinforces my less-than-fondness of `auto` locals when reading code.


Defensive copy


looks like the "-a" and "-d" descriptions are reversed.


entries->swap(op_ret.entries)

should probably do the same elsewhere in cls_rgw_client.cc?


#if defined(GENERIC_DESKTOP)
#include "system_info/system_info_network_desktop.h"
····#elif defined(TIZEN_MOBILE)
#include "system_info/system_info_network_mobile.h"
#else
#include "system_info/system_info_network_ivi.h"····
I did here ````src/system_info/system_info_instance.cc````


字符串相加效率在次数多得时候非常低，改成：
```python
content = []
if isinstance(cxt_data_content, list):
    for txt in cxt_data_content:
        content.append(str(txt.get('content'))
....

return ''.join(content)
```

会好很多。另外，直接用 str 会导致兼容 Python 3 比较困难。


It depends on SyncCollectionResource implementation.
In my product implementation, I am caching sync-token on `findResourcesBySyncToken` and just return it on subsequent `getSyncToken` call.

There is no need to retrieve actual resources on  `PROPFIND` request, so I separated methods into `findResourcesBySyncToken` and `getSyncToken`.


@Skaronator Didn't mess with setOwner until Arma 3, so I never knew.
If that's true, it sounds like they should have fixed it by now.


I know. But, this place is also needed.


The javadoc still says that 'a provider can be marked as replaceable'.

What happens now when you try to replace a core service? Or any other services?

https://forums.spongepowered.org/t/how-to-mark-a-service-provider-as-replaceable/5481


This call to `mir_connection_release` causes a segfault on my machine if Mir isn't running.


\bld\setupgui\c\guistat.c fails to build due to const title at line 146 and line 472

============== 12:09:33 D:\abr_apps\OW2_64D\bld\setupgui\dos386 ===============
bwcc386 -zq -w8 -we -oaxt -d1 -x -xx -zam -fo=guistat.obj -j -fpi -ms -zc -bt=dos  -s    -DNDEBUG  -D__WATCOM_LFN__ -D_UI     -I"../h" -I"D:\abr_apps\OW2_64D\bld/ui/h" -I"D:\abr_apps\OW2_64D\bld/gui/ui/dos386" -I"D:\abr_apps\OW2_64D\bld/gui/h" -I"D:\abr_apps\OW2_64D\bld/gui" -I"D:\abr_apps\OW2_64D\bld/trmem" -I"D:\abr_apps\OW2_64D/contrib/libzip/lib"  -I"D:\abr_apps\OW2_64D\bld/hdr/dos"  -I"D:\abr_apps\OW2_64D\bld/watcom/h" ..\c\guistat.c
..\c\guistat.c(146): Warning! W1179: Parameter 1, type qualifier mismatch
..\c\guistat.c(146): Note! N2003: source conversion type is 'char const *'
..\c\guistat.c(146): Note! N2004: target conversion type is 'void *'
..\c\guistat.c(146): Note! N2002: 'GUIMemFree' defined in: D:\abr_apps\OW2_64D\bld\gui\h\guimem.h(41)
..\c\guistat.c(472): Warning! W1179: Parameter 2, type qualifier mismatch
..\c\guistat.c(472): Note! N2003: source conversion type is 'char const **'
..\c\guistat.c(472): Note! N2004: target conversion type is 'char **'
..\c\guistat.c(472): Note! N2002: 'GUIStrDup' defined in: D:\abr_apps\OW2_64D\bld\gui\h\guiutil.h(36)
Error(E42): Last command making (guistat.obj) returned a bad status
Error(E02): Make execution terminated
<pmake -d build         -h> => non-zero return: 2
Build failed


This was an interesting bug to correct - as the Canonical package of docker.io appears to demand it must create the group, and it has to be a system group. I'm filing a bug against the universe package docker.io to have this looked at / corrected - it doesn't seem right that the package should be so militant with a group that it fails an install.

We have user-submitted evidence of this being the case: https://gist.github.com/slatunje/89e17809bf3c0d317d94


@pomu0325, yes thats what i would do as an implementor. ie retrieve resources and token in an atomic operation and hold them on the Resource instance for use within that request. Using return objects like my ChildrenAndState above does make the API a bit messy


I wouldn't hold it up but don't we use Allman?


Nice.


Thanks Siying. I addressed your comments with this commit (forced push)


is it on purpose that this repository is referring to version 4.9.0 and not 4.9.1?


must add comment for `hubot help`


学习啊


I totally disagree. This is not the use case nearly everyone I know uses. We use Volumetric slicing to have a filament independent gcode file. Having an M200 Dxxx in the gcode file makes that use case not work.

You can choose to save the M200 D3.0, or whatever, in smoothie or not you can leave the default as D0 and enter M200 everytime you go to print, but that is not the common use case for smoothie. We save it and change it when we switch rolls of filament and usually save it again. It is saved with M500 in Smoothie.

Having M200 Dxxx in the gcode file needs to be an option. and if the option is a hack to  put ; M200 in the gcode startup file then that is fine by me.

Having to remember to enter M200 D3.0 everytime I go to print is not an option I can accept :)


rax retry tests


Please specify absolute path to `/sbin/modinfo` so it works for non-root users.  Also there should be error handling here--I get a `KeyError` exception because `modinfo` isn't in my `$PATH`.


@xiongchiamiov thank you!!


Rak 3ajebni ;)


For reference, the package bug can be tracked here: https://bugs.launchpad.net/ubuntu/+source/docker.io/+bug/1407841


I know it's in the FreeNAS version, but the backslash in `\#' looks like a typo.  I'd omit it.


This is heavy-handed. Would it be better to apply a transform?


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.90012642225032%25-red.svg)


84202472-TurnOffInputEchoByDefault (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1582 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Since all `process.env` variables are strings, you'll need to cast to an int before you can use it. Otherwise node will throw an error.

You could do so with:
```javascript
 var port = +process.env.PORT || 8080;
```
or:
```javascript
 var port = Number(process.env.PORT) || 8080;
```


Can be consistent with the function above, calling it _unregisterCommittedKeyBeforeSnapshot_inlock()?


Thanks @igorcanadi ! LGTM.


Heh, I'm the maintainer :-) The distribution mechanism just changed 2 times - SourceForge for `0.12.0` and distro-specific binaries in `0.12.1`. The reason for this is clearly stated in the [download FAQ](http://wkhtmltopdf.org/downloads.html#faq)


Is there any guarantee that `tracker[funcName]` will be set here? I see the test for `tracker` below, but no test that `func` is set before calling `func.apply()`.


The exclamation point is lonely so far from its variable.


I'm not 100% convinced that the explicit conversion operator is an improvement in readability.  Yes, it's nice that it's explicit.  My general feeling so far is that explicit bool conversion operators are a good thing.  Other conversion operations are often better served with a named method.  I could be convinced otherwise.  I still have lots to learn.


FYI I think I found a bug in this. If you pass something like so:

    {
        "@name": "dbl-test",
        "description": "dbl-test",
        "recurring": {
            "hourly": {
                "at": "00"
            }
        },
        "type": "ip",
        "url": "http://192.168.1.6:8080/pa-dbl.txt"
    }

It's not able to turn that into an "XML snippet" even when you have `full_document=False`.


blank line above, okiplx


exclamation point>-<variable name


try getting the path from $PATH, then checking path. regardless you shouldn't need to duplicate this code per path prefix


I am surprised that the lines are disappearing. What do you guys think
is the best course of action? @Quintus @datahead8888 ?

On 01/05/2015 05:07 AM, Marvin Gülker wrote:
>
>     Would it be a good issue to open a tracker issue on the
>     disappearing lines, or is it intended (so as to speak)?
>
> Now, they shouldn’t disappear probably. I think they’re a bit too
> thin. We’d need @sydneyjd <https://github.com/sydneyjd>’s comment on
> that, though.
>
> Vale,
> Quintus
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Secretchronicles/TSC/commit/1600e22dd15bd2a8b20fca6bcc27e483058b21e3#commitcomment-9151017>.
>


Space between function and arguments list.


ale porobil :) :+1:


A comment explaining why these three are special wouldn't go amiss.


@dipwater
感觉你的 IIS 设置没有生效, 但是 wec 的设置已经生效, 所以找不到页面才 404.

另外, 我是纯 Linux 使用者, 对 windows 不了解, IIS 还是 10 年前的知识. 如果你愿意改 Linux 我将非常乐意协助你.

-Never

2015-01-06 9:40 GMT+08:00 dipwater <notifications@github.com>:

> “4， 在URL
> 自定义路由每行一条规则,中间使用===隔开”这一步是可有可无的吧，我目前是IIS，开启伪静态后未配置自定义路由。我的伪静态规则是下载的这个：
> http://wenda.wecenter.com/question/17035
> 现在结果是除首页外都404，bbs.xssrw.com
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wecenter/wecenter/commit/6514e8f7cc29af918a3095ebc47c16b230614e19#commitcomment-9163274>
> .
>


I spI with mI little I an errant apostrophe. (If you care.)


TeamCity ChameleonForms :: Continuous Integration [Build 216](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3485&buildTypeId=bt20) is now running


多得多


`!==` instead of `!=`, please.


The additions work as follows:

###### Hue
```
var hue = C4Hue()
hue.angle = 2.0
var img = C4Image("logo")
img.apply(hue)
view.add(img)
```
###### ColorBurn
```
var burn = C4ColorBurn()
burn.background = C4Image("CA_11011010_0")
img.apply(cb)
view.add(img)
```
###### Twirl Distortion
```
var twirl = C4Twirl()
twirl.center = img.center
twirl.radius = 30
var img = C4Image("logo")
img.apply(twirl)
view.add(img)
```
###### Checkerboard Generator
```
var checkerboard = C4Checkerboard()
var img = C4Image(frame: C4Rect(0,0,100,100))
img.generate(checkerboard)
view.add(img)
```
###### Crop
```
var img = C4Image("logo")
var bg = C4Image("logo")
bg.opacity = 0.33
var crop = C4Crop()
crop.frame = C4Rect(10,10,img.width-10,10)
img.apply(crop)
view.add(bg)
view.add(img)
```
###### Linear Gradient Generator
```
var gradient = C4LinearGradient()
gradient.points = [C4Point(),C4Point(100,100)]
var img = C4Image(frame: C4Rect(0,0,100,100))
img.generate(gradient)
view.add(img)
```
###### Dot Screen Generator
```
var img = C4Image("logo")
var dot = C4DotScreen()
dot.width = 3.0
img.apply(dot)
view.add(img)
```
###### Sharpen
```
var img = C4Image("logo")
var sharpen = C4Sharpen()
sharpen.sharpness = 10.0
img.apply(sharpen)
view.add(img)
```
###### Bloom
```
var img = C4Image("logo")
var bloom = C4Bloom()
img.apply(bloom)
view.add(img)
```


!== instead of !=, please.


don't do this


番号付きリストの番号がおかしい。
1 ⇒ 2 ⇒ 1 ⇒ 1 ⇒ 2 になっている。


Could you put a small comment here, explaining why -2 is used? What is the meaning of -2? Why not use -1 (what is it reserved for)?


"tekst bestanden" should be a single word and "ondersteund" is with a "t".


Too simple??


i haven't really needed to use that feature on smaller projects like this before. If the maintainer requests it, then, i will do so though.


"Map namen" should be a single word.


What's the point of changing this to `6767` isn't it better to run all our test servers on the same port?


Model-mæssigt, så forstiller jeg mig noget, som man kan konfigurere sådan her:

```
var profiler = new FancyViewProfilerino();
var profilerForSlowIntegrationViews = new FancyViewProfilerino();

var processor = CommandProcessor.With()
   .(...) bla bla
   .EventDispatcher(x => {
      x.UseViewManagerEventDispatcher(...).WithProfiler(profiler);
      x.UseViewManagerEventDispatcher(...).WithProfiler(profiler);
      x.UseViewManagerEventDispatcher(...).WithProfiler(profilerForSlowIntegrationViews);
   })
   .Create();
```

dvs. at man for hver `ViewManagerEventDispatcher` kan registrere en profiler og dermed kan "pulje" profileringen i nogle grupper, hvor det giver mening. Jeg synes f.eks. det ville være træls hvis applikations-view-profileringen blev forstyrret af alle de langsomme SQL integrations-views, som man f.eks. har kørende på en langsom SQL Azure til BI.

....og hvis jeg lige skal drømme et par spørgsmål frem, som jeg synes kunne være interessante at få besvaret:

1. er der et bestemt event, der er langsomt at få processeret
1. er der en bestemt `IViewManager`, der er langsom
1. hvor lang tid tager det typisk fra en command er processeret til alle views har catchet up

dvs. at det nok kunne give mening at opsamle


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/3222/console
Build was first broken at http://ci.cgeo.org/job/c-geo/3129/


Hello Rasika,

I only suggest it because some references does not mean trailing slash

Like this
https://www.parse.com/docs/rest
http://blog.miguelgrinberg.com/post/designing-a-restful-api-with-python-and-flask
https://www.safaribooksonline.com/library/view/rest-api-design/9781449317904/ch02s02.html

It is only a suggestion :)

Best regards,

Carlos

2015-01-06 2:19 GMT-02:00 Rasika Amaratissa <notifications@github.com>:

> I would like to keep the trailing slash for all URL routes to maintain
> consistency. Any reason as to why the trailing slash needs to be removed?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ccesario/raspberrypi-gpio-api/commit/c5ed77530b9c6788ad1356cfab1dcc70e911e723#commitcomment-9164275>
> .
>


:+1: Great!


@adamedx
Fixed review comments.


Reviewed! Looks good, please make sure Deepak tests it thoroughly. The initial commit had changes to the template.pot file, does that require to be reverted now that table header changes have been removed ?


    Process p;
    try {
       // Preform su to get root privledges
       p = Runtime.getRuntime().exec("su");

       // Attempt to write a file to a root-only
       DataOutputStream os = new DataOutputStream(p.getOutputStream());
       os.writeBytes("echo \"Do I have root?\" >/system/sd/temporary.txt\n");

       // Close the terminal
       os.writeBytes("exit\n");
       os.flush();
       try {
          p.waitFor();
               if (p.exitValue() != 255) {
                  // TODO Code to run on success
                  toastMessage("root");
               }
               else {
                   // TODO Code to run on unsuccessful
                   toastMessage("not root");
               }
       } catch (InterruptedException e) {
          // TODO Code to run in interrupted exception
           toastMessage("not root");
       }
    } catch (IOException e) {
       // TODO Code to run in input/output exception
        toastMessage("not root");
    }


Donc tu fais la piscine C++ haha :]


> with this settings removed, we don't get a baseline alignment of the text inside the widget, but a bottom alignement of the root node of the widget

As @dmandrioli has found (thanks!), this is a side-effect of the overflow-hidden used on the outer node of deliteful/Select. Strange that overflow:hidden can have this effect, isn't it? Anyway, overflow: hidden is there for a reason: avoiding that the corners of the inner node cover the rounding of the outer node. This can be avoided by moving the rounding to the inner select. Here's an updated jsfiddle: http://jsfiddle.net/adrian_vasiliu/zsjfc7ge/ . I'll test that in various browsers, because the styling capabilities for the native select vary depending on browsers...

Supposing that the bad impact of the removal of vertical-align: middle on deliteful/Select can be avoided, it remains that testing would be needed for each of the numerous widgets having this settings.


`<parantes>`
Jeg har brugt en fiktiv `ViewManagerEventDispatcherConfigurationBuilder` ovenfor, for at kunne lave den her frækkert
```
x.UseViewManagerEventDispatcher(...).WithProfiler(profiler);
```
hvilket naturligvis kræver en udvidelse af konfigurations-API'et. I samme ombæring kunne jeg godt tænke mig at reducere antallet af overloads af `UseViewManagerEventDispatcher`, sådan at man kan konfigurere optionelle ting sådan her:

```
x.UseViewManagerEventDispatcher(viewManagers)
    .WithProfiler(someProfiler)
    .WithWaitHandle(someWaitHandle)
    .WithMaxDomainEventsPerBatch(200);
```


TeamCity OsmSharp :: GitHub - OsmSharp [Build 925](http://build.osmsharp.com:8080/viewLog.html?buildId=4086&buildTypeId=bt16) is now running


It looks like there's a word missing between "map" and "als" and "word" should be with "dt".


Ya it was being retarded and kept defaulting to 48. I have it working now
with both on my "new-blobs" branch
On Jan 6, 2015 1:48 AM, "Dorian Snyder" <notifications@github.com> wrote:

> Actually source has been updated to allow usage of both sampling rates
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Team-Hydra/android_device_samsung_klte-common/commit/00972a833a99b7acbfafa0aa1217df9b41ae3a5b#commitcomment-9166306>
> .
>


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=eb04e93aef654efab798c8c1fcec2329
 plone-4.3-python-2.6 [FAILURE]
plone-4.3-python-2.7 [FAILURE]


Toujours :)


This commit relies on https://github.com/camptocamp/ngeo/pull/132


I'd use "bevat" instead of "is", same for the line below. And "word" is with "dt".


Hey !

Thanks for the help. I will port the download tool to OSX soon. I'll let you know when I am ready.

Cheers !


Pendant deux semaines :smile:  :lollipop:


30 out of 173 as of Jan. 6th, 2015


change links


This should address all of the comments above.


Better to create two separate methods get and getAll, I think.


I'm not sure how the comment above relates to this line. I don't see how setting an item style 'unsets" a breakpoint.


The Dutch word for "shortcuts" is "snelkoppelingen". Is there a specific reason you kept the English term?


* ```setting → SSH kyes → Add SSH key で公開鍵``` ⇒ ``` [setting] → [SSH kyes] → [Add SSH key] で公開鍵 ```
* ``` ＊4と5はコマンドプロンプト ```  ⇒ ``` ※4と5はコマンドプロンプト ```
* ```メニュー → Conversuins → Export OpenSSH をクリック ``` ⇒ ``` [メニュー] → [Conversuins] → [Export OpenSSH] をクリック  ```
* ```＊4と5はコマンドプロンプトや Git Bashから操作する時に必要になるものなのでやらなくても良いです``` ⇒
```コマンドプロンプトや Git Bashから操作する場合は、以下4と5の設定も行います。```


Why a block here?


Typo: "nier" should be "hier".


同じく、``` Save praivate key ``` ⇒ ``` [Save praivate key] ```


It would be better to use the layer id since the name is given by the administrator of the application. We have no control over it. We cannot prevent the same name to be given to 2 different layers.


## This is a markdown file


Fixed and test added!


Ah thanks for the link.


Type: "meerder" should be "meerdere". And is there a specific reason the English word "bindings" was not translated?


IDFXT (Unknown) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-78.41772151898734%25-red.svg)


Delete should return deleted element.


```setting → SSH kyes → Add SSH key で公開鍵を登録する。``` ⇒ ```[setting] → [SSH kyes] → [Add SSH key] で公開鍵を登録する。```


This is not something a user should ever have to mess with.  These values do not need to be adjustable by users, they are mostly just minor precautions so it's not polling the list of windows on the system every frame.  Two seconds is more than enough for the default polling, and four seconds feels comfortable to me for the injection retry on failure.  These intervals are mostly for the purpose of reducing log spam more than anything.  It's not something a user needs to worry/care about.


да не, вроде норм
это конечно [-inf, -inf, -inf...]
но, ничего страшного, потому что np.exp(-np.inf) = 0.
если np.zeros брать, там 1 же получается


I would use "bevat" instead of "is" here as well. The "Hedtc" looks like a typo and should be "Het". "word" is with "dt". And I'd suggest changing "zodat" to "voordat".


Always put a space between /* and comment body.


build now fails with clang:
$ make CC=clang obj/sdl64/osd/modules/sync/work_osd.o
[...]
src/osd/modules/sync/work_osd.c:85:13: error: unused function 'osd_yield_processor' [-Werror,-Wunused-function]


@ccesario Cool, for now I will keep the trailing slashes. Maybe later I will remove it, after reading a bit more about it. Please update your pull request with the documentation changes, so I can merge it. Thanks. :)


Normally authorship stays correct when cherry-picking, so I don't know what went wrong. Don't worry about it, though.

Do you understand where the warning debug log comes from? To me it sounds like it might be an indication that something is not working as it should yet.

I don't have a strong opinion whether the "central skeleton loader" should be a separate commit or not. One might argue that it is a self-contained change in the sense that things work well both before and after that change, so it would be worth having it as a separate commit. It is often beneficial if large changes are broken down into multiple self-contained commits, especially when you notice later that there was a regression somewhere and try to identify the commit which introduced it.


It only clears up the Julia.app in the /deps/ folder, if it exists, so that it can immediately re-download (it's provided by atom-shell-*.zip)


Set usually updates instance not creates one. You need two separate methods for this.


I think the code below is very clear :) Unless you want to add extra comment for some references?


why not using the new Symfony DebugBundle as you are using 2.6 ?


The first "bestand" seems incorrect to me in this context.


Since len is int, do you want to check <= 0 ?


Capital "a"?


why do you use the [] operator here. You know that it inserts a default constructed key if it is not found. While this is harmless, it takes more memory. Just use find() instead (two lines, but more proper).


Factory name is not descriptive enough. Elements are products in your task, so maybe Product?


http://hasteb.in/erifisebaq
With it boots i mean it doesn't XD


Typo: "Overschriif" should be "Overschrijf"


Thank you for your reviews, suggestions and guidance.


This is a windows plugin.  If I recall from your mantis submission, you are on mac, so you wouldn't see this.  That being said, the activate button was removed in 4f2c48a9374effbed1c6812e9741b5ef8c6c4273 for other unrelated reasons to this post.


From your implementation of arrElems factory, you don't edit element, but create new and instert it after the element you need to change.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.3.0.925](http://build.osmsharp.com:8080/viewLog.html?buildId=4086&buildTypeId=bt16) outcome was **SUCCESS**
Summary: Tests passed: 486 Build time: 0:0:0


no no no quittance!


adding ladybug was kind of a reflex ;)
Will have a look at the DebugBundle.


Thanks. It's fixed now.


Should be "Reguliere expressie".


## This is a markdown file


a


I do think we need layer ids. @sbrunner, could we add that to the web service?


Ajuste de tamanho dos ícones do twitter e Fb


Typo: Should be "Vervang"


Why is "Match" no longer translated?


>  I'll test that in various browsers, because the styling capabilities for the native select vary depending on browsers...

Unfortunately, already on FF and IE11 / Win7 there are side-effects of moving the rounding to the inner native select:

FF 34/Win7:

![image](https://cloud.githubusercontent.com/assets/1583981/5627176/42046764-9595-11e4-938d-b335fc754d30.png)

instead of

![image](https://cloud.githubusercontent.com/assets/1583981/5627192/560cb31a-9595-11e4-9fec-4c64b11185c8.png)

IE11/Win7:
![image](https://cloud.githubusercontent.com/assets/1583981/5627151/0482f40a-9595-11e4-83dc-9241a3e6260c.png)
 instead of
![image](https://cloud.githubusercontent.com/assets/1583981/5627160/1a5f5f16-9595-11e4-9aab-1a13bccfc781.png)

This makes me remind that the limited styling capabilities of some supported browsers with native select are precisely the reason for which deliteful/Select uses a wrapper node around the native select - that is, to avoid styling the native select itself. So I still lack a usable solution for avoiding the overflow:hidden on the root node of deliteful/Select, which in turn forbids the removal of vertical-align: middle...


Why was this changed? "dab" is not a Dutch word.


The best version would be 2 commits, but that also means that I have to create one version that contains the loader and your standalone fix.

I'll debug it later. The test goes something like this, with debug logs enabled:
>ReloadDef(Clonk)
Erasing animation "Sleep" from [filepath of Clonk skeleton]
Appending animation "Sleep" to Clonk

and the other test:
>ReloadDef(Bed)
Erasing animation "Sleep" from [filepath of Clonk skeleton]
Appending animation "Sleep" to Clonk
WARNING: the animation already exists in Clonk

So, in the second version either the animation is not deleted, or someone tries appending the animation two times in a row. Or something crazy happens.


given that you are only getting scalars, using an ORM query is overkill (and slower): you run all the hydration just to turn scalars into themselves (you don't even make Doctrine cast them to integers for you). Just run the query with DBAL directly


Thank you! This commit fixed the build. It was broken since http://ci.cgeo.org/job/c-geo/3129/


thx reddit for free vote system!


I think you should add a MTK MMC driver instead of flash.

In other words, put your implementation in src/drivers/storage/mtk_mmc.{c,h}


1. If you want to document code use JsDoc.
2. The comments have logical errors (e.g. this is not global objects, they're in scope already; what's "ng-reply"). Comments should be helpful instead of complicated.
3. JsDoc comments used mostly for IDE support. If you feel a need to comment something, it usually speaks to the complexity of code. Better to simplify the code (or change variable name to more appropriate) so that no comments will be needed.


does not match its path. Something looks weird


Do you mean "errors" instead of "erros"? That should be translated to "fouten" and depending on the context be merged with "Vervang" into a single word.


OK I will add it :-)


Double "niet" should be a single one.


Picky! :-)


bor bor


@ritesh-pandey How about:
The `dataSource` attribute(which can be set using the `dataSource` method or passed in as a hash in the `chart constructor`) can....

What do you think?


"cursor locatie" should be a single word.


The code's fine. If we're going for backwards compatibility with the old `external_add_item.pl` though, then we're missing two things, which I think are actively used by the apps that submit to it:

* the ability to specify the milestone for the item to go into instead of just defaulting to the upcoming milestone
* taking a `redirect_url` parameter to specify where to send the user to afterwards. This is because a lot of the pages using this API are not dynamic; they're just an HTML page somewhere. A user hitting it should be taken to some kind of "thanks for reporting an error" page that the client app specifies.


@nnarhinen - is `//` a valid CSS comment in .styl files, to be transformed or omitted?


Да, фигню я написал.


@robdmoore found out that TC fails build on this:
`Component\FieldTests.cs(150, 25): error CS0122: 'ChameleonForms.Component.Section<ChameleonForms.Tests.Component.TestFieldViewModel>' is inaccessible due to its protection level`
I've added InternalsVisibleTo, but it still failes. Local test build runs OK.


Need to add/replace test files.


Мб полезно, ага.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 926](http://build.osmsharp.com:8080/viewLog.html?buildId=4088&buildTypeId=bt16) is now running


I'll check this out tomorrow, but I don't think we are ever going care about running this on Windows, there are other parts where I have made things Linux specific already.


You can modify this to be a validator directive (that sets validity depending on expression it recieves).
The you will have something like <input x-validate="isOrigin(product, $index)"> in html, where isOrigin would be part of controller. Then, if you will need another validation, you won't have to change your directive, only pass it another function.


lowercase "split". Same goes for the line below.


"het zzelfde" should be "hetzelfde"


"selections" should be "selecties".


Please make these (static if you need) inline functions.


Also then we won't need that "pyreadline" dependency in the requirements, as it's only there for Windows.. I don't really want to introduce a dependency just for the sake of Windows :)


Please make these enums.


you could make it an option of the command rather than having to edit the code :)


Why not use http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_compile.c#3934 instead? I really don't want to have an extra token just for two tests.


"wissellen" has one "l" too many.


Please make complete prototype (don't ignore parameter names).


writing to /dev/kmsg is a bad practice. Try using syslog or stdout instead


You're again using object from scope of controller in directive, this will make reusability of your directive more complicated.


Consider using uint8_t instead of unsigned char *.


"openen" instead of "opennen". And "report panel" should be "rapportagepaneel" in my opinion.


I think what happens is that the animation is appended twice. And the reason for this is that old skeletons are not deleted from the maps in StdMeshSkeletonLoader (see comment 2) [here](https://github.com/gitMarky/openclonk/commit/9836ca441d7873b87a65a1027fb0fba9b3a3b50f#commitcomment-9153664)). Since the reloaded skeletons are new objects, they have a unique memory address, and therefore will be inserted *again* into `AppendtoSkeletons` and `IncludeSkeletons`. But I didn't test this yet, it's just a hypothesis.


If index is undefined then it should stay undefined, why are you setting it to the length of list?


Already fixed.

> build now fails with clang:
> $ make CC=clang obj/sdl64/osd/modules/sync/work_osd.o
> [...]
> src/osd/modules/sync/work_osd.c:85:13: error: unused function 'osd_yield_processor' [-Werror,-Wunused-function]
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mamedev/mame/commit/7ddd65cbc1e8d1769202b4dbbde439f74fecf263#commitcomment-9166552


Please always keep a space between // and comment body.


Do we still need this (CFG_FPGA_PLATFORM)?


move to /tmp/configList


I'm missing a word here after "timed"? And I think "verstreken" would be a better translation anyway.


Like :+1: ! Very well done & explained. This is getting easier and more comfortable by the day.

What I'd love to have is a fabric script on top of that so that I can

`fab installserver:serverip=<IP>,pdx=<url>,gtfs=<url>`

And it does all the steps as described in the readme, downloads the files, builds the graph and gets the containers including nginx running then reports back like:

`OK, browser here: http://....`

If you think that's a new issue/job let me know.

btw.  fabric is pretty simple. all it takes is a `fabfile.py` that looks something [like this](http://docs.fabfile.org/en/latest/tutorial.html#conclusion)


以下の設定を追記。（以下「リポジトリをクローンする」の設定は削除する。）
6. タスクトレイに表示されている「Pageant（PuTTY authentication agent）」をダブルクリックし、Pageantのキーリストを開く。
7. 「Add Key」ボタンをクリックし、先ほど保存したPuTTY形式の秘密鍵（id_rsa.ppk など）を選択する。


Will search and replace the dupe in the .java files


Move it before the scheduleTimes variable definition to be in sync with the if condition above. Also what does the `last` part stand for?


I would change this to "Inspringen"


remove this useless comments


i had kernel problems relating to the took chain when building lt03wifi. once you reverted the use of linaro i was able to build fine. I do however have the low storage issue on this device now on v4.5


I would use the plural "Inspringen"


"regel" instead of "lijn".


You probably want to name this MT8135_FIFO_SIZE, and as enum.


@JCCR indeed I see how the renaming could be very useful during debugging (because of file/class name collision), but shouldn't this change either be (1) temporary, or (2) applied to all other homonyms consistently?


Are the comments referring to offset value? Please make it clear.


"regel" instead of "line" and make it one word with "commentaar"


Would it be better to link to the IMS guide? http://www.imsglobal.org/LTI/v1p1p1/ltiIMGv1p1p1.html#_Toc330273026 (wtf is up with those url anchor fragments?)


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.3.0.926](http://build.osmsharp.com:8080/viewLog.html?buildId=4088&buildTypeId=bt16) outcome was **SUCCESS**
Summary: Tests passed: 486 Build time: 0:0:0


"blok commentaar" should be a single word


That would work, but we eventually have the same problem as before: We're relying on some unrelated compile error.


The "S" should be removed. Looks like a typo.


errr.. Safari 8 partially support Map, but creating a new Map with Arguments is actually not supported :
http://kangax.github.io/compat-table/es6/#Map

running the master branch now gives :
````javascript
[Error] TypeError: Map constructor does not accept arguments
	Map (melonJS-2.1.0.js, line 15963)
	(anonymous function) (melonJS-2.1.0.js, line 15963)
	global code (melonJS-2.1.0.js, line 16486)
````


clrsetbits_le32(&regs->SPI_CMD_REG, SPI_CMD_RST_MASK, 1 << SPI_CMD_RST_OFFSET);
clrbits_le32(&regs->SPI_CMD_REG, SPI_CMD_RST_MASK,);


__API Blueprint syntax error on line 14__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


「リポジトリをクローンする」の手順は削除する。


@prudhomm That does not compile anymore


Please try to rewrite all the readl+writel by clrbits_le32, setbits_le32, and clrsetbits_le32.


You were right, seems like I was kinda tired when I added the formats yesterday. Fixed them all in 921f3be565341ae1e7c366127fa50d9195d7d8a1. Thanks again.


Code_Cleanups (DeadParrot) - x86_64-MacOS-10.9-clang-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.99618805590852%25-red.svg)


(this is from me.Color, when creating the `cssToRGB` map)


Ah, I missed this commit:
https://github.com/readium/readium-sdk/commit/5d099ded268b155a8d7d119687ca6bc2ababc905
...which reduces the number of parameters from 13 to 10 (damn, I'm confused now!)


Always do (type *var) instead of (type * var).
Please change all functions below as well.


For me, fewer external dependencies is not the main benefit, the fact that scons is Python is the most attractive part. CMake comes with a well-defined way of describing compilation targets, yes, but that also means that some yotta users will also need to learn CMake's way of describing targets, which is not particularly elegant or intuitive IMO. cmake also makes some things particulary hard (we had a really hard time figuring out weak symbol issues, for example, since cmake insists on building libraries). Granted, one could fall into the trap of implementing too much logic into the build system with something like scons, but that can be avoided. What I had in mind for the targets was to define an interface (abstract base class) with specific functions for a target description file, which would then be implemented by each target in turn. I didn't try to define this yet, so I don't know how good/bad it will end up looking.


This key is obsolete and has been removed from the API console


4: I102 copyright year is outdated, expected 2015 but got 2014


3: I102 copyright year is outdated, expected 2015 but got 2014


Please remove the dead code.


Good to see the Dutch language section get some love, but I have some issues with the commit as is.

There's a lot of typo's in there.

Also a lot of the segments where moved around in the source file, but that also got their contents retranslated in this commit, and not always for the better.


TeamCity Zero-K :: PullRequest test build [Build 13](http://zero-k.info:8080/viewLog.html?buildId=2683&buildTypeId=ZeroK_PullRequestTestBuild&guest=1) is now running


TeamCity Zero-K :: PullRequest test build [Build 13](http://zero-k.info:8080/viewLog.html?buildId=2683&buildTypeId=ZeroK_PullRequestTestBuild&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:12


Fixed this one (inherit => 100% for the height) via 91e97671170bdbb198d6f1ee7423556c51905d45.


/*
* @ author: tahereh koohi
*/


Please use your FIFO definition -  MT8135_FIFO_SIZE


Please also print size as well so we can debug more easily :)


Don't forget the changelog!


lol


found this one :
https://github.com/eriwen/es6-map-shim/blob/master/es6-map-shim.js


Pourquoi v et pas v+1 aussi ligne 98 ? (sur le modèle de la ligne 96)


I need to confirm with Marco if that is ok!


How would I otherwise justify my involvement? :)


damn ... you are absolutely right ... sorry copy/paste error on my side :|
thx Wenyou Yang for fixing!!


I guess everyone needs to be extra careful from now on not to add extra whitespace? For those using Xcode, you will want to ensure that under Preferences -> Text Editing you have ticked "Automatically trim trailing whitespace" and most especially "Including whitespace-only lines".


Sorry @JCCR there is obviously something I am missing, I hope you can educate me about this last ZL string parameter, and the mismatched number of parameters

10 string parameters:
https://github.com/readium/readium-sdk/blob/develop/Platform/Android/jni/epub3.cpp#L315
11 string parameters:
https://github.com/readium/readium-sdk/blob/develop/Platform/Android/jni/packagejni.cpp#L636


Why did you remove this test ?


What is it testing? That the scala compiler works? You know you're getting a boolean back by virtue of the type system.


Wow, what a nice addition. Thanks a lot:) Did you use some plugin in IDEA to get this formatting right, or it's just a result of code review and bulk replace ?:)


+++       http://+.+.++..++..+++...job...plus.++.ins.ins+++....toverscripter+++ner....plusdot/   ingrfnaltinrunsys32opinin


Relying on an unrelated error is imho much much better than introducing a token just for testing purposes.


Well, it adds test coverage to the class :)


Can you update the syntax style to match nodemon's (spaces, bracket alignment, etc).


Add a proper test then :) Perhaps generate 100 booleans and assert you get at least one of each, so its generating both values.


please add space between `rules` and `(best practices)`


Sorry, missed this. Commit amended now -  9f5308d!


Good point :) Will do that


Add them to a set and assert the size is 2.


Hello! Unfortunately, the FilecryptCc Script is not available , it does not solve a captcha and loads only htm files. I ask you to fix that .

http://filecrypt.cc/Container/82A6D30C01.html

regards

Hallo! Leider ist das FilecryptCc Script nicht nutzbar, es löst keine Captcha und lädt nur htm dateien. Ich bitte euch das zu fixen.

http://filecrypt.cc/Container/82A6D30C01.html

Grüße


TeamCity Zero-K :: PullRequest test build [Build 14](http://zero-k.info:8080/viewLog.html?buildId=2688&buildTypeId=ZeroK_PullRequestTestBuild&guest=1) is now running


TeamCity Zero-K :: PullRequest test build [Build 14](http://zero-k.info:8080/viewLog.html?buildId=2688&buildTypeId=ZeroK_PullRequestTestBuild&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:08


I don't think we need to support this any more


waiting for updated WART


@mattstyles: can you add the github release too?


Unused


eh


;) I think we do as it was still produced by our own scripts (see above).
Suggest we give it a little time, at least - otherwise feel free to remove.


I wrote:
> More exactly, bootstrap used to set it [vertical-align: middle] unconditionally in v. 3.0.0. I see now that the more recent versions still set it, but for "inline forms" using a media query depending on screen size, see https://github.com/twbs/bootstrap/blob/v3.3.1/less/forms.less#L423.

In practice, this means that, in a typical form styled by the current version of bootstrap, the vertical-align: middle is still set on inline-block form elements, except for screens smaller than 768px wide where bootstrap goes with width: 100% (in deliteful we didn't take this choice for small screens). See http://getbootstrap.com/css/?#forms.

An example from bootstrap doc:

![image](https://cloud.githubusercontent.com/assets/1583981/5627592/95ba3122-959a-11e4-98cd-897bce1cbc15.png)


Please make those items as translatable string.


All of my auto-generated 000_config.py have still deployment_settings.auth.hmac_key ;) that's how I stumbled over it.


Those also.


Registering functions seems to be changed.
Old method now try exception when using 'usesgeometry' directive:
return register_function(func, args, group, usesgeometry, **kwargs)
TypeError: register_function() got multiple values for keyword argument 'usesgeometry'

What is now the new registering method?


Yeah - just wanted to be friendly here, I think this is still a wide-spread phenomenon. But if you think it shouldn't be supported anymore, then fine - remove it. I know where it's coming from if it crashes.


Related to issue #369.


You are right. This is non-critical and for using the twitter api we need an app, an access key, secret (to which I don't have access) and from them a token (and a place to store this token and renew periodically). For all these constraints, this is the best I could come up with :) This is up for another take on another day.


Awesome!


I was thinking on similar lines. However, I don't quite understand the dependency properties yet. In any case, I have a few suggestions.
1. Name is not really descriptive of purpose. Something like `AuthBitmapImage` would make more sense.
2. Without `DecodePixelWidth` and `DecodePixelHeight` we are bound to get out of memory exception at some point. Can that be made?
3. Common seems like a better namespace for this class.


Shouldn't this result in wmode - undefined identifier or something?


Hey. This is awesome, that you've got all the slicing and multiplication working such that we can write things like this. Great work.


Ahh ignore ... i overlooked the magic wmode instantiation - thats why we should use one line of code for one statement ;)


NewVSHPWH (shenb) - i386-Windows-7-VisualStudio-12: OK (1586 of 1586 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I know, the previous version should be recovered. I will finish this in the next releases


only me.Color actually calls the Map constructor with arguments, so instead of going through the hassle of adding another polyfill I would rather revert the following commit, but keeping the regpex part :
https://github.com/melonjs/melonJS/commit/63764c15cf14582484dc2695b037f9fcf51777a9


I like that. Changing.


Ah! Congrats. I know you have other to think about.....


I modified my event.rb in my logstash(version: 1.4.2),but that is not become effective。
These are the index:
drwxr-xr-x 8 root root 4096 12-31 11:57 logstash-2014.12.31
drwxr-xr-x 8 root root 4096 12-31 23:59 logstash-2015.01.01
drwxr-xr-x 8 root root 4096 01-04 15:14 logstash-2015.01.02
drwxr-xr-x 8 root root 4096 01-04 22:01 logstash-2015.01.03
drwxr-xr-x 8 root root 4096 01-05 04:42 logstash-2015.01.04
drwxr-xr-x 8 root root 4096 01-05 20:01 logstash-2015.01.05
drwxr-xr-x 8 root root 4096 01-06 03:50 logstash-2015.01.06

I'm in beijing of china~
So,what can i do?

Thank you~~~


will add in next commit


will update all comments in next commit.


ok


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 108](http://192.168.30.225:8111/viewLog.html?buildId=505&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 108](http://192.168.30.225:8111/viewLog.html?buildId=505&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 127 Build time: 00:00:01


TeamCity Ylab :: zmactep/ylab [Build 143](http://192.168.30.225:8111/viewLog.html?buildId=506&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


ok will update


Hehe yeah I tried to keep the diffs as small as possible.


why does removing this cause it to carp?

'''UndefinedError: u'short_description._key' is undefined'''


Wouldn't it be better to link this option to CMAKE_BUILD_TYPE=Debug
or use it in test instead of core
or enable it in .travis.yml?


so I'll wait and merge your change for this one :)


Modifié le 06-01-15 par Valentin Gourdon


r=michaelwoerister rollup


VarRef is a variable name, so in case of BooleanLiteral you are expecting a variable named true and a variable named false to exist. Which is incorrect.

This is how i made literals later on:
ast.Literal(new model.ECAValue(1))

Please see model/ECAValue for further explanation, but this snippet may be helpful:
object ECAValue {
  import scala.language.implicitConversions

  val Zero = new ECAValue(0)
  val One  = new ECAValue(1)

  private val True  = One
  private val False = Zero

..

implicit def booleanToValue(v: Boolean): ECAValue = if (v) True else False


Fair point, I'll change it.


will update


Hum parce qu'on substitue un terme dans un terme, et que dept ça veut dire
"abstratraction de type" du coup on décalle pas les indices de De Bruinj

On Tue, Jan 6, 2015 at 11:45 AM, Théo Zimmermann <notifications@github.com>
wrote:

> Pourquoi v et pas v+1 aussi ligne 98 ? (sur le modèle de la ligne 96)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stratSystemF/lambda/commit/f86b39e65fa43aa66333944aab191dc86fdf6ea2#commitcomment-9166899>
> .
>


I'll restore libancillary code back to a separate file and update CMakeList instead.

For the control sock related code, do you feel if it's OK to keep them just in tuntap.c?


I've failed the grammar test :-1:


It's TUN only. Will update this one.


TeamCity Ylab :: zmactep/ylab [Build 143](http://192.168.30.225:8111/viewLog.html?buildId=506&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:10:29


"its" is not grammatically correct :)


Haha, good gravy!


Shouldn't the contact email be a variable? No matter what I set in `contact email` it just stays as `name@example.com`.

I'm also seeing the same on https://meta.discourse.org/about. Happy to put in a PR if wanted!


better to move this to src/customwidgets/CMakeLists.txt


better to move this to the provider that depends on it


I think the control socket stuff should be moved to the libancillary file as well.

Even in an own file, the imported libancillary code should follow the fastd coding style if distributed with the fastd code.


NewVSHPWH (shenb) - Win64-Windows-7-VisualStudio-12: OK (1586 of 1586 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is that ok with Qt4 builds?


This is done now.


Looks good in general!
One more part that works with Qt5 :-)


Might be worth updating LKG, especially now that release 1.4 is merged in the mix?


gg = good grammar


@kumpera This breaks the Mono.Debugger.Soft test suite:

```
Runtime Environment -
   OS Version: Unix 3.2.0.4
  CLR Version: 4.0.30319.17020 ( 3.99.0 ((detached/3a74470 Tue Jan  6 04:39:13 EST 2015) )

Excluded categories: NotWorking,ValueAdd,CAS,InetAccess
***** MonoTests.DebuggerTests.Arguments
debugger-agent: Unable to connect to 127.0.0.1:52597

Build timed out (after 15 minutes). Marking the build as failed.
```


datetime 형식인데 컬럼 이름이 timestamp 라 좀 혼란스럽네요. timestamp라는 형식도 있고 보통 timestamp라 함은 유닉스 타임(에포크)를 많이 의미하는지라...


Reviewed and looks good


This and the instance above can use OverloadedStrings


Must be `_logger.warning("Error while parsing %s", path, exc_info=True)`


lines 183-190 are duplicate of lines 193-200
Please refactor to avoid this


Remove commented code


Yes, I tried that at one point but everything became ambiguous. But it looks like it might work now. I'll try it out.


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3034
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3028
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3029
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3020
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3020
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3023
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3016
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3011
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2688
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2686
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1524
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1516


fast-forwarding master to auto = 340ac040


Not sure in which case it happen and if this code is needed.


And the citizens rejoiced.


TeamCity Zero-K :: PullRequest test build [Build 15](http://zero-k.info:8080/viewLog.html?buildId=2694&buildTypeId=ZeroK_PullRequestTestBuild&guest=1) is now running


useless commit


TeamCity Zero-K :: PullRequest test build [Build 15](http://zero-k.info:8080/viewLog.html?buildId=2694&buildTypeId=ZeroK_PullRequestTestBuild&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:25


But then in the end we need extensions for MTI-3000, FOG-KVH and so on...
Same helds for Servos, Actuators...

A while ago afaik we decided to make them abstract and live (as long
there are no special requirements) with some gaussian noise...

On 06.01.2015 10:40, Jakob Schwendner wrote:
>
> This turns into a general discussion. Every sensor has its own noise
> characteristics. You could generalize it, but to me it seems more
> suitable to model each sensor individually.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rock-simulation/simulation-orogen-mars/commit/603b4e239d7e692f2ebd1ca42ae9a317814fd824#commitcomment-9166210>.
>

--
  Dipl.-Inf. Matthias Goldhoorn
  Space and Underwater Robotic

  Universität Bremen
  FB 3 - Mathematik und Informatik
  AG Robotik
  Robert-Hooke-Straße 1
  28359 Bremen, Germany

  Zentrale: +49 421 178 45-6611

  Besuchsadresse der Nebengeschäftstelle:
  Robert-Hooke-Straße 5
  28359 Bremen, Germany

  Tel.:    +49 421 178 45-4193
  Empfang: +49 421 178 45-6600
  Fax:     +49 421 178 45-4150
  E-Mail:  matthias.goldhoorn@informatik.uni-bremen.de

  Weitere Informationen: http://www.informatik.uni-bremen.de/robotik


for 0.3.6 presumably, not 0.3.5?


zOK this is a bit tricky. The only thing really needed is adding "-fPIE" to CFLAGS and "-fPIE -pie" to LINK_FLAGS.

Other changes are just for the static linking hack. Because cmake doesn't support static linking, I patched pkgconfig files like this:
`Libs: -L${libdir} -luecc` => `Libs: ${libdir}/libuecc.a`

and cmake will output `UECC_LDFLAGS_OTHER`=/full/path/to/libuecc.a and `UECC_LIBRARIES`='' (empty)

Without these changes, linking with .so just works fine.
The reason for static linking is that:
* Custom binaries must be extracted and saved to app's internal storage folder by the app itself
* Running binary with shared libraries requires setting LD_LIBRARY_PATH
Therefore a static linked binary will make life easier for Android Java code to deploy and run it.

That said, if you feel these cmake hacks are not so necessary, I can always keep them in a branch :)


Deleted the comments as well, and now, when the user clicks on 'Next' while previewing the last message, the thing rolls up, and the first message is displayed again.


saw approval from alexcrichton
at https://github.com/retep998/rust/commit/351e6b7255bbe43687c9275d63b99da3e8f5fe62


Hi I have a small question...
get_backup_driver(context) will create a new object of configured backup driver (e.g.: SwiftBackupDriver or CephBackupDriver, etc..) and return to backup_service.

For every backup related operation (like create_backup, restore_backup, delete_backup, export_record, import_record) we are creating new object. (Have a look at lines 247 and 299).

Because of this for every operatoin new object is creating, so that for every operation, constructor of BackupDriver is calling (BackupDriver is initializing for every operation.)
Why can't we create an object in the constructor (def __init__) and use it for every operation?

Is there any specific reason behind this?


merging retep998/rust/winsize = 351e6b72 into auto


status: {"merge_sha": "9c4f9e72f67cb9992a912d4f5502d09833da2da1"}


retep998/rust/winsize = 351e6b72 merged ok, testing candidate = 9c4f9e72


Do not hardcode record id. Use xmlid


Handle the case of deleted record.


Maybe set these a default values of the wizard.


Hi @hanneshal,
this and related changes break the functionality to download all attachments of a ticket, which was possible in the previous version. Please reactivate this feature.

Greetings,
  Thorsten


This I guess amends #1472, yet it is not correct since it lacks `@Test`. I will fix this, since I need it to merge with #1513 anyway.


I think another possibility would be to delete the .so files instead of patching the pkg-config definitions, so the linker will just use the .a. Linking worked fine a while back when libuecc was a static-only library.


lol'd


아 제가 `timestamp`로 해서 그대로 반영된것 같습니다. `datetime`도 좋고 적절한 이름 추천해주시면 변경했으면 좋겠습니다.


Looks like it wasn't merged to develop until 12/10 which was a couple days after we branched for 1.2.0 (current version in Master), so it won't be merged to master until the next update.  Can you temporarily create your own location get method for now that doesn't do a verify?


r=huonw rollup


This recompute the `attachments` variable for each attachment
I would simply skip non binary attachments.

```python
attachment_ids = [a.id for a in mail.attachment_ids if a.type == 'binary']
```


My point is that templates should be simple, if we add too many options
then we will not be able to maintain them in the near future.
In this particular case, `java_bean` template should generate *simple* java
beans without any additional magic.
If we want objects to be immutable after deserialization, then we need
different template for that specific case.

2015-01-06 9:58 GMT+02:00 David Yu <notifications@github.com>:

> We can make it disable by default and enabled via an option.
> So instead of removing the code with unmodifiable lists, you can simply
> add a nested if via:
>
> <if(options.("java_unmodifiable_list"))>
>
> Sames goes for the finally block below.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kshchepanovskyi/protostuff/commit/362a125df25eb3411abf25367568a8977a0028fa#commitcomment-9165375>
> .
>

--
Regards,

Konstantin


Nice work


`|` should be `||` and you forgot to add parenthesis.


you're overwritting #L2481 method


How about this?


Não teria que alterar também o /src/main/resources/requisicao-transacao-template.xml para funcionar?


Yes, that was the problem.


You might lose 'back' button in actionbar if LockClock is added like that


1: M111 unrecognized component name: WebBasket


Да, выглядят странно.


В общем, в хроме стек при вызове со скрипта и со страницы одинаков.


Nice catch! Thanks
But it's strange that this did not worked on your machine.


Argh, you are right.


pour que ce commentaire soit une doctype, écrit le entre 3 guillemets .
par ex: """affiche, ...."""
ça permet d'afficher ça quand tu tape: help(affiche_addresse)


gg


Haven't tried yet but https://github.com/FernetMenta/xbmc/blob/a99f4ef04d1f5e5bd343a0b5cd47307fb87bbb00/xbmc/guilib/GUIVideoControl.cpp#L73 needs IsVideoLayer() as well, doesn't it?


Wcięcia powinny być robione spacjami, nie tabami - jeden poziom wcięcia to powinny być 4 spacje. Można ustawić sobie edytor żeby sam tak robił. Jako że to jest Python to wcięcia mają znaczenie i mieszanie spacji i tabów mogą nawet całkiem rozwalić wykonanie kodu.


gg Check that a default <<them>> has been set


"A custom theme..."


Sure, check hells repo


Wszystkie komentarze w kodzie robiliśmy do tej pory po angielsku.


The first 'size_t need' declaration is useless and produces a compiler warning.  The variable need is declared in the else block again.


Il faudrait retenir le point renvoyé dans une variable, afin de pouvoir le supprimer lors d'une saisie différente.
(genre une variable self.point_utilisateur )


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Great job.


Those constants should be used to report the version number in the console application. It might make more sense to pull them into a version file like [this](https://github.com/peridot-php/peridot/blob/master/src/Console/Version.php). We use Robo to do releases and that handles incrementing and releasing for us.