1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2013
24:1: I100 Imports statements are in the wrong order. import os should be before import time
26:1: I100 Imports statements are in the wrong order. import ConfigParser should be before import sys
31:1: I100 Imports statements are in the wrong order. from invenio.dbquery should be before from invenio.intbitset
32:1: I100 Imports statements are in the wrong order. from invenio.bibindex_tokenizers.BibIndexJournalTokenizer should be before from invenio.dbquery
36:1: I101 Imported names are in the wrong order. Should be get_collection_reclist, search_pattern, search_unit
37:35: E126 continuation line over-indented for hanging indent
40:1: I100 Imports statements are in the wrong order. from invenio.bibformat_utils should be before from invenio.search_engine_utils
42:1: I101 Imported names are in the wrong order. Should be task_get_option, task_get_task_param, task_sleep_now_if_required, task_update_progress, write_message
43:22: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.bibindex_engine_utils should be before from invenio.bibtask
47:1: I100 Imports statements are in the wrong order. from invenio.dbquery should be before from invenio.docextract_record
48:1: I101 Imported names are in the wrong order. Should be CFG_INSPIRE_SITE, CFG_SITE_URL
48:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.dbquery
52:20: E126 continuation line over-indented for hanging indent
55: D103 Docstring missing
63: D103 Docstring missing
71: D103 Docstring missing
100: D400 First line should end with '.', not 'g'
100: D205 Blank line missing between one-line summary and description
147:55: E127 continuation line over-indented for visual indent
157: D209 Put multi-line docstring closing quotes on separate line
157: D202 No blank lines allowed *after* function docstring, found 1
157: D400 First line should end with '.', not 's'
212: D401 First line should be imperative: 'Report', not 'Reports'
212: D200 One-line docstring should not occupy 3 lines
249: D103 Docstring missing
287: D400 First line should end with '.', not 'e'
293: D103 Docstring missing
310: D400 First line should end with '.', not 'd'
310: D200 One-line docstring should not occupy 2 lines
324: D400 First line should end with '.', not 's'
324: D200 One-line docstring should not occupy 2 lines
341: D400 First line should end with '.', not 'g'
356: D202 No blank lines allowed *after* function docstring, found 1
356: D400 First line should end with '.', not 't'
365: D400 First line should end with '.', not 'e'
470: D400 First line should end with '.', not 'd'
538: D400 First line should end with '.', not 'm'
547:46: E227 missing whitespace around bitwise or shift operator
549:48: E227 missing whitespace around bitwise or shift operator
554: D401 First line should be imperative: 'Scan', not 'Scans'
554: D400 First line should end with '.', not 'd'
554: D205 Blank line missing between one-line summary and description
554: D208 Docstring is over-indented
623:30: E128 continuation line under-indented for visual indent
625:25: E127 continuation line over-indented for visual indent
642:31: E127 continuation line over-indented for visual indent
647:40: E127 continuation line over-indented for visual indent
667:34: E128 continuation line under-indented for visual indent
669:36: E127 continuation line over-indented for visual indent
673:39: E128 continuation line under-indented for visual indent
675:36: E127 continuation line over-indented for visual indent
687:29: E128 continuation line under-indented for visual indent
691:29: E128 continuation line under-indented for visual indent
694:25: E127 continuation line over-indented for visual indent
710:39: E127 continuation line over-indented for visual indent
713:39: E127 continuation line over-indented for visual indent
723:39: E127 continuation line over-indented for visual indent
731:34: E127 continuation line over-indented for visual indent
752:19: E128 continuation line under-indented for visual indent
753:19: E128 continuation line under-indented for visual indent
754:19: E128 continuation line under-indented for visual indent
758: D400 First line should end with '.', not 't'
758: D205 Blank line missing between one-line summary and description
758: D208 Docstring is over-indented
816:41: E127 continuation line over-indented for visual indent
827:36: E127 continuation line over-indented for visual indent
856:47: E127 continuation line over-indented for visual indent
875:34: E127 continuation line over-indented for visual indent
914:34: E127 continuation line over-indented for visual indent
953:34: E127 continuation line over-indented for visual indent
987:34: E127 continuation line over-indented for visual indent
1013:34: E127 continuation line over-indented for visual indent
1041:44: E127 continuation line over-indented for visual indent
1067:50: E127 continuation line over-indented for visual indent
1078:21: E128 continuation line under-indented for visual indent
1099:29: E127 continuation line over-indented for visual indent
1120:29: E127 continuation line over-indented for visual indent
1141:29: E127 continuation line over-indented for visual indent
1158:29: E127 continuation line over-indented for visual indent
1197: D400 First line should end with '.', not 'e'
1197: D205 Blank line missing between one-line summary and description
1211: D401 First line should be imperative: 'Thi', not 'This'
1211: D200 One-line docstring should not occupy 3 lines
1223: D400 First line should end with '.', not 'w'
1223: D205 Blank line missing between one-line summary and description
1236: D400 First line should end with '.', not 'w'
1236: D205 Blank line missing between one-line summary and description
1247: D400 First line should end with '.', not 'e'
1254: D400 First line should end with '.', not 'd'
1254: D205 Blank line missing between one-line summary and description
1284: D400 First line should end with '.', not 'd'
1284: D205 Blank line missing between one-line summary and description
1316: D208 Docstring is over-indented
1333:27: E127 continuation line over-indented for visual indent
1339: D209 Put multi-line docstring closing quotes on separate line
1339: D400 First line should end with '.', not 'e'
1339: D208 Docstring is over-indented
1347: D400 First line should end with '.', not 'l'
1347: D205 Blank line missing between one-line summary and description
1370: D400 First line should end with '.', not ']'
1380: D400 First line should end with '.', not 'e'


1: M100 needs more reviewers
1: M101 signature is missing


4: L102 copyright year is outdated, expected 2015 but got 2012
53:1: I100 Imports statements are in the wrong order. import datetime should be before import time
54:1: F401 'traceback' imported but unused
55:1: I100 Imports statements are in the wrong order. import logging should be before import traceback
61:1: I101 Imported names are in the wrong order. Should be _db_login, run_sql
62:1: I100 Imports statements are in the wrong order. from invenio.access_control_engine should be before from invenio.dbquery
63:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_FLUSH_LOGS, CFG_BIBSCHED_PROCESS_USER, CFG_BINDIR, CFG_PREFIX, CFG_SITE_NAME, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_TMPDIR, CFG_VERSION
76:1: I101 Imported names are in the wrong order. Should be CFG_EXTERNAL_AUTHENTICATION, CFG_EXTERNAL_AUTH_USING_SSO
76:1: I100 Imports statements are in the wrong order. from invenio.access_control_config should be before from invenio.errorlib
77:43: E126 continuation line over-indented for hanging indent
78:1: I101 Imported names are in the wrong order. Should be get_email, get_email_from_username, get_user_preferences
79:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_LOGDIR, CFG_BIBTASK_DEFAULT_GLOBAL_TASK_SETTINGS, CFG_BIBTASK_DEFAULT_TASK_SETTINGS, CFG_BIBTASK_FIXEDTIMETASKS, CFG_BIBTASK_LOG_FORMAT, CFG_BIBTASK_VALID_TASKS
79:1: I100 Imports statements are in the wrong order. from invenio.bibtask_config should be before from invenio.webuser
87:1: I100 Imports statements are in the wrong order. from invenio.mailutils should be before from invenio.shellutils
88:1: I101 Imported names are in the wrong order. Should be bibsched_get_host, bibsched_set_host
88:1: I100 Imports statements are in the wrong order. from invenio.bibsched should be before from invenio.mailutils
89:30: E126 continuation line over-indented for hanging indent
104: D101 Docstring missing
107:1: E302 expected 2 blank lines, found 1
107: D101 Docstring missing
108: D102 Docstring missing
112:1: E302 expected 2 blank lines, found 1
112: D400 First line should end with '.', not 't'
112: D205 Blank line missing between one-line summary and description
151: D205 Blank line missing between one-line summary and description
284:12: E713 test for membership should be 'not in'
304:86: F812 list comprehension redefines 'arg' from line 290
310:13: E128 continuation line under-indented for visual indent
321: D401 First line should be imperative: 'Return', not 'Returns'
347: D401 First line should be imperative: 'Return', not 'Returns'
347: D400 First line should end with '.', not 'k'
360: D401 First line should be imperative: 'Return', not 'Returns'
360: D400 First line should end with '.', not 'k'
379: D400 First line should end with '.', not 's'
404: D400 First line should end with '.', not 'r'
424: D401 First line should be imperative: 'Set', not 'Sets'
452: D290 White spaces around docstring should be trimmed.
452: D205 Blank line missing between one-line summary and description
482:18: E203 whitespace before ':'
483:31: E203 whitespace before ':'
484:20: E203 whitespace before ':'
485:29: E203 whitespace before ':'
486:15: E203 whitespace before ':'
487:18: E203 whitespace before ':'
488:20: E203 whitespace before ':'
489:18: E203 whitespace before ':'
490:19: E203 whitespace before ':'
491:24: E203 whitespace before ':'
492:18: E203 whitespace before ':'
528:33: E128 continuation line under-indented for visual indent
529:33: E128 continuation line under-indented for visual indent
530:33: E128 continuation line under-indented for visual indent
561:5: E303 too many blank lines (2)
648:1: E302 expected 2 blank lines, found 1
648: D290 White spaces around docstring should be trimmed.
648: D205 Blank line missing between one-line summary and description
670:13: E128 continuation line under-indented for visual indent
706:41: E261 at least two spaces before inline comment
749:1: E302 expected 2 blank lines, found 1
749: D400 First line should end with '.', not 'k'
755:24: E203 whitespace before ':'
757:1: E302 expected 2 blank lines, found 1
757: D401 First line should be imperative: 'Return', not 'Returns'
757: D400 First line should end with '.', not 'k'
764:1: E302 expected 2 blank lines, found 1
764: D400 First line should end with '.', not 'S'
771:1: E302 expected 2 blank lines, found 1
771: D401 First line should be imperative: 'Return', not 'Returns'
771: D400 First line should end with '.', not 'm'
778:1: E302 expected 2 blank lines, found 1
778: D400 First line should end with '.', not 'm'
784:28: E203 whitespace before ':'
786:1: E302 expected 2 blank lines, found 1
786: D401 First line should be imperative: 'Update', not 'Updates'
791:13: E128 continuation line under-indented for visual indent
793:1: E302 expected 2 blank lines, found 1
793: D401 First line should be imperative: 'Update', not 'Updates'
798:13: E128 continuation line under-indented for visual indent
800:1: E302 expected 2 blank lines, found 1
803:9: E128 continuation line under-indented for visual indent
810:1: E302 expected 2 blank lines, found 1
810: D400 First line should end with '.', not 'e'
817:1: E302 expected 2 blank lines, found 1
817: D205 Blank line missing between one-line summary and description
843:1: E302 expected 2 blank lines, found 0
843: D401 First line should be imperative: 'Return', not 'Returns'
843: D209 Put multi-line docstring closing quotes on separate line
843: D205 Blank line missing between one-line summary and description
843: D208 Docstring is over-indented
865: D401 First line should be imperative: 'Thi', not 'This'
865: D400 First line should end with '.', not ','
865: D205 Blank line missing between one-line summary and description
903:1: E302 expected 2 blank lines, found 1
903: D400 First line should end with '.', not 'n'
903: D205 Blank line missing between one-line summary and description
914:1: E302 expected 2 blank lines, found 1
914: D205 Blank line missing between one-line summary and description
953:21: E128 continuation line under-indented for visual indent
954:13: E128 continuation line under-indented for visual indent
968:25: E128 continuation line under-indented for visual indent
969:17: E128 continuation line under-indented for visual indent
986:1: E302 expected 2 blank lines, found 1
986: D401 First line should be imperative: 'Submit', not 'Submits'
986: D209 Put multi-line docstring closing quotes on separate line
986: D202 No blank lines allowed *after* function docstring, found 1
986: D400 First line should end with '.', not 'l'
986: D205 Blank line missing between one-line summary and description
986: D208 Docstring is over-indented
1008:9: E128 continuation line under-indented for visual indent
1018: D401 First line should be imperative: 'Return', not 'Returns'
1018: D209 Put multi-line docstring closing quotes on separate line
1018: D400 First line should end with '.', not 'k'
1018: D205 Blank line missing between one-line summary and description
1023:9: E128 continuation line under-indented for visual indent
1028:13: E128 continuation line under-indented for visual indent
1082: D400 First line should end with '.', not 'n'
1088:25: E127 continuation line over-indented for visual indent
1096: D400 First line should end with '.', not 'n'
1102: D401 First line should be imperative: 'Run', not 'Runs'
1102: D209 Put multi-line docstring closing quotes on separate line
1102: D202 No blank lines allowed *after* function docstring, found 1
1102: D205 Blank line missing between one-line summary and description
1116:13: E128 continuation line under-indented for visual indent
1129:13: E128 continuation line under-indented for visual indent
1153:205: E261 at least two spaces before inline comment
1154:193: E261 at least two spaces before inline comment
1164:13: E128 continuation line under-indented for visual indent
1230:41: E261 at least two spaces before inline comment
1232:25: E127 continuation line over-indented for visual indent
1238:1: E302 expected 2 blank lines, found 1
1238: D401 First line should be imperative: 'Print', not 'Prints'
1248:9: E128 continuation line under-indented for visual indent
1250:9: E128 continuation line under-indented for visual indent
1252:9: E128 continuation line under-indented for visual indent
1253:9: E128 continuation line under-indented for visual indent
1257:9: E128 continuation line under-indented for visual indent
1258:9: E128 continuation line under-indented for visual indent
1259:9: E128 continuation line under-indented for visual indent
1266:9: E128 continuation line under-indented for visual indent
1279:1: E302 expected 2 blank lines, found 1
1283:13: E128 continuation line under-indented for visual indent
1288:1: E302 expected 2 blank lines, found 1
1291:13: E128 continuation line under-indented for visual indent
1293:25: E261 at least two spaces before inline comment
1296:1: E302 expected 2 blank lines, found 1
1299:13: E128 continuation line under-indented for visual indent
1307:1: E302 expected 2 blank lines, found 1
1307: D209 Put multi-line docstring closing quotes on separate line
1313:13: E128 continuation line under-indented for visual indent
1317:1: E302 expected 2 blank lines, found 1
1322:1: E302 expected 2 blank lines, found 0
1339:1: E302 expected 2 blank lines, found 1
1339: D205 Blank line missing between one-line summary and description
1354:1: E302 expected 2 blank lines, found 1
1354: D400 First line should end with '.', not 'r'
1354: D205 Blank line missing between one-line summary and description
1372:13: E122 continuation line missing indentation or outdented
1374:57: E261 at least two spaces before inline comment
1382:9: E122 continuation line missing indentation or outdented


Damned ifdef's ...
I'll fix it.


这里没必要多创建一个临时对象，tx和ty的访问也是不必要的开销。直接 var 两个变量即可


1: M100 needs more reviewers
1: M101 signature is missing
1: M190 line is too long (53 > 50)


Isn't this redundant? Line 3 has `*.log`


1: M100 needs more reviewers
1: M101 signature is missing
1: M190 line is too long (58 > 50)


1: D400 First line should end with '.', not ','
1: D205 Blank line missing between one-line summary and description
4: L102 copyright year is outdated, expected 2015 but got 2011
41:9: E126 continuation line over-indented for hanging indent
42:18: E203 whitespace before ':'
43:18: E203 whitespace before ':'
44:18: E203 whitespace before ':'
45:18: E203 whitespace before ':'
46:18: E203 whitespace before ':'
47:18: E203 whitespace before ':'
48:18: E203 whitespace before ':'
49:18: E203 whitespace before ':'
50:18: E203 whitespace before ':'
51:18: E203 whitespace before ':'
52:18: E203 whitespace before ':'
53:18: E203 whitespace before ':'
54:18: E203 whitespace before ':'
55:18: E203 whitespace before ':'
56:18: E203 whitespace before ':'
57:18: E203 whitespace before ':'
58:18: E203 whitespace before ':'
59:18: E203 whitespace before ':'
61:18: E203 whitespace before ':'
63:22: E203 whitespace before ':'
64:22: E203 whitespace before ':'
65:22: E203 whitespace before ':'
66:22: E203 whitespace before ':'
67:22: E203 whitespace before ':'
68:22: E203 whitespace before ':'
69:22: E203 whitespace before ':'
70:22: E203 whitespace before ':'
71:22: E203 whitespace before ':'
72:22: E203 whitespace before ':'
73:22: E203 whitespace before ':'
74:22: E203 whitespace before ':'
75:22: E203 whitespace before ':'
76:22: E203 whitespace before ':'
77:22: E203 whitespace before ':'
78:22: E203 whitespace before ':'
79:22: E203 whitespace before ':'
80:22: E203 whitespace before ':'
81:22: E203 whitespace before ':'
82:22: E203 whitespace before ':'
83:22: E203 whitespace before ':'
84:22: E203 whitespace before ':'
85:22: E203 whitespace before ':'
86:22: E203 whitespace before ':'
87:22: E203 whitespace before ':'
88:22: E203 whitespace before ':'
89:22: E203 whitespace before ':'
90:22: E203 whitespace before ':'
91:22: E203 whitespace before ':'
92:22: E203 whitespace before ':'
93:22: E203 whitespace before ':'
94:22: E203 whitespace before ':'
95:22: E203 whitespace before ':'
96:22: E203 whitespace before ':'
97:22: E203 whitespace before ':'
98:22: E203 whitespace before ':'
99:22: E203 whitespace before ':'
100:22: E203 whitespace before ':'
101:22: E203 whitespace before ':'
102:22: E203 whitespace before ':'
103:22: E203 whitespace before ':'
104:22: E203 whitespace before ':'
105:22: E203 whitespace before ':'
106:22: E203 whitespace before ':'
107:22: E203 whitespace before ':'
108:22: E203 whitespace before ':'
109:22: E203 whitespace before ':'
110:22: E203 whitespace before ':'
111:22: E203 whitespace before ':'
112:22: E203 whitespace before ':'
113:22: E203 whitespace before ':'
114:22: E203 whitespace before ':'
115:22: E203 whitespace before ':'
116:22: E203 whitespace before ':'
117:22: E203 whitespace before ':'
118:22: E203 whitespace before ':'
119:22: E203 whitespace before ':'
120:22: E203 whitespace before ':'
121:22: E203 whitespace before ':'
122:22: E203 whitespace before ':'
123:22: E203 whitespace before ':'
124:22: E203 whitespace before ':'
125:22: E203 whitespace before ':'
126:22: E203 whitespace before ':'
127:22: E203 whitespace before ':'
128:22: E203 whitespace before ':'
129:22: E203 whitespace before ':'
130:22: E203 whitespace before ':'
131:22: E203 whitespace before ':'
132:22: E203 whitespace before ':'
133:22: E203 whitespace before ':'
134:22: E203 whitespace before ':'
135:22: E203 whitespace before ':'
136:22: E203 whitespace before ':'
137:22: E203 whitespace before ':'
138:22: E203 whitespace before ':'
139:22: E203 whitespace before ':'
140:22: E203 whitespace before ':'
141:22: E203 whitespace before ':'
142:22: E203 whitespace before ':'
143:22: E203 whitespace before ':'
144:22: E203 whitespace before ':'
145:22: E203 whitespace before ':'
146:22: E203 whitespace before ':'
147:22: E203 whitespace before ':'
148:22: E203 whitespace before ':'
149:22: E203 whitespace before ':'
150:22: E203 whitespace before ':'
151:22: E203 whitespace before ':'
152:22: E203 whitespace before ':'
153:22: E203 whitespace before ':'
154:22: E203 whitespace before ':'
155:22: E203 whitespace before ':'
156:22: E203 whitespace before ':'
157:22: E203 whitespace before ':'
158:22: E203 whitespace before ':'
159:22: E203 whitespace before ':'
160:22: E203 whitespace before ':'
161:22: E203 whitespace before ':'
162:22: E203 whitespace before ':'
163:22: E203 whitespace before ':'
164:22: E203 whitespace before ':'
165:22: E203 whitespace before ':'
166:22: E203 whitespace before ':'
167:22: E203 whitespace before ':'
168:22: E203 whitespace before ':'
169:22: E203 whitespace before ':'
170:22: E203 whitespace before ':'
171:22: E203 whitespace before ':'
172:22: E203 whitespace before ':'
173:22: E203 whitespace before ':'
174:22: E203 whitespace before ':'
175:22: E203 whitespace before ':'
176:22: E203 whitespace before ':'
177:22: E203 whitespace before ':'
178:22: E203 whitespace before ':'
179:22: E203 whitespace before ':'
180:22: E203 whitespace before ':'
181:22: E203 whitespace before ':'
182:22: E203 whitespace before ':'
183:22: E203 whitespace before ':'
184:22: E203 whitespace before ':'
185:22: E203 whitespace before ':'
186:22: E203 whitespace before ':'
187:22: E203 whitespace before ':'
188:22: E203 whitespace before ':'
189:22: E203 whitespace before ':'
190:22: E203 whitespace before ':'
192:22: E203 whitespace before ':'
193:22: E203 whitespace before ':'
194:22: E203 whitespace before ':'
195:22: E203 whitespace before ':'
196:22: E203 whitespace before ':'
197:22: E203 whitespace before ':'
198:22: E203 whitespace before ':'
199:22: E203 whitespace before ':'
200:18: E203 whitespace before ':'
201:18: E203 whitespace before ':'
203:18: E203 whitespace before ':'
204:18: E203 whitespace before ':'
205:18: E203 whitespace before ':'
207:18: E203 whitespace before ':'
208:18: E203 whitespace before ':'
209:18: E203 whitespace before ':'
210:18: E203 whitespace before ':'
212:18: E203 whitespace before ':'
213:18: E203 whitespace before ':'
215:18: E203 whitespace before ':'
216:18: E203 whitespace before ':'
217:18: E203 whitespace before ':'
218:18: E203 whitespace before ':'
219:18: E203 whitespace before ':'
220:18: E203 whitespace before ':'
221:18: E203 whitespace before ':'
222:18: E203 whitespace before ':'
223:18: E203 whitespace before ':'
224:18: E203 whitespace before ':'
225:18: E203 whitespace before ':'
226:18: E203 whitespace before ':'
227:18: E203 whitespace before ':'
228:18: E203 whitespace before ':'
229:18: E203 whitespace before ':'
230:18: E203 whitespace before ':'
232:14: E203 whitespace before ':'
234:18: E203 whitespace before ':'
235:18: E203 whitespace before ':'
237:26: E203 whitespace before ':'
238:18: E203 whitespace before ':'
240:18: E203 whitespace before ':'
242:18: E203 whitespace before ':'
243:18: E203 whitespace before ':'
244:18: E203 whitespace before ':'
245:18: E203 whitespace before ':'
246:18: E203 whitespace before ':'
248:18: E203 whitespace before ':'
249:18: E203 whitespace before ':'
252:18: E203 whitespace before ':'
253:18: E203 whitespace before ':'
258:20: E203 whitespace before ':'
259:20: E203 whitespace before ':'
260:20: E203 whitespace before ':'
261:20: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:20: E203 whitespace before ':'
264:20: E203 whitespace before ':'
265:20: E203 whitespace before ':'
266:20: E203 whitespace before ':'
267:20: E203 whitespace before ':'
268:20: E203 whitespace before ':'
269:20: E203 whitespace before ':'
270:17: E203 whitespace before ':'
271:17: E203 whitespace before ':'
272:17: E203 whitespace before ':'
273:17: E203 whitespace before ':'
274:17: E203 whitespace before ':'
275:17: E203 whitespace before ':'
276:17: E203 whitespace before ':'
277:17: E203 whitespace before ':'
278:17: E203 whitespace before ':'
279:17: E203 whitespace before ':'
280:17: E203 whitespace before ':'
281:17: E203 whitespace before ':'
283:17: E203 whitespace before ':'
284:17: E203 whitespace before ':'
285:17: E203 whitespace before ':'
286:17: E203 whitespace before ':'
287:17: E203 whitespace before ':'
288:17: E203 whitespace before ':'
289:17: E203 whitespace before ':'
290:17: E203 whitespace before ':'
291:17: E203 whitespace before ':'
292:17: E203 whitespace before ':'
293:17: E203 whitespace before ':'
294:17: E203 whitespace before ':'
295:18: E203 whitespace before ':'
296:18: E203 whitespace before ':'
297:18: E203 whitespace before ':'
298:18: E203 whitespace before ':'
299:18: E203 whitespace before ':'
300:18: E203 whitespace before ':'
301:18: E203 whitespace before ':'
302:18: E203 whitespace before ':'
303:18: E203 whitespace before ':'
304:18: E203 whitespace before ':'
305:18: E203 whitespace before ':'
306:18: E203 whitespace before ':'
308:17: E203 whitespace before ':'
309:17: E203 whitespace before ':'
310:17: E203 whitespace before ':'
311:17: E203 whitespace before ':'
312:17: E203 whitespace before ':'
313:17: E203 whitespace before ':'
314:17: E203 whitespace before ':'
315:17: E203 whitespace before ':'
316:17: E203 whitespace before ':'
317:18: E203 whitespace before ':'
318:17: E203 whitespace before ':'
319:17: E203 whitespace before ':'
320:17: E203 whitespace before ':'
321:18: E203 whitespace before ':'
322:18: E203 whitespace before ':'
323:18: E203 whitespace before ':'
324:18: E203 whitespace before ':'
325:18: E203 whitespace before ':'
326:18: E203 whitespace before ':'
327:18: E203 whitespace before ':'
328:18: E203 whitespace before ':'
329:18: E203 whitespace before ':'
330:19: E203 whitespace before ':'
331:18: E203 whitespace before ':'
332:18: E203 whitespace before ':'
333:18: E203 whitespace before ':'
334:20: E203 whitespace before ':'
335:20: E203 whitespace before ':'
336:20: E203 whitespace before ':'
337:20: E203 whitespace before ':'
338:20: E203 whitespace before ':'
339:20: E203 whitespace before ':'
340:20: E203 whitespace before ':'
341:20: E203 whitespace before ':'
342:20: E203 whitespace before ':'
343:21: E203 whitespace before ':'
344:20: E203 whitespace before ':'
345:20: E203 whitespace before ':'
346:20: E203 whitespace before ':'
347:19: E203 whitespace before ':'
348:19: E203 whitespace before ':'
349:19: E203 whitespace before ':'
350:19: E203 whitespace before ':'
351:19: E203 whitespace before ':'
352:19: E203 whitespace before ':'
353:19: E203 whitespace before ':'
354:19: E203 whitespace before ':'
355:19: E203 whitespace before ':'
356:20: E203 whitespace before ':'
357:19: E203 whitespace before ':'
358:19: E203 whitespace before ':'
359:19: E203 whitespace before ':'
361:20: E203 whitespace before ':'
362:20: E203 whitespace before ':'
363:20: E203 whitespace before ':'
364:20: E203 whitespace before ':'
365:20: E203 whitespace before ':'
366:20: E203 whitespace before ':'
367:20: E203 whitespace before ':'
368:20: E203 whitespace before ':'
369:20: E203 whitespace before ':'
370:20: E203 whitespace before ':'
371:19: E203 whitespace before ':'
372:19: E203 whitespace before ':'
373:19: E203 whitespace before ':'
374:19: E203 whitespace before ':'
375:19: E203 whitespace before ':'
376:19: E203 whitespace before ':'
377:19: E203 whitespace before ':'
378:19: E203 whitespace before ':'
379:19: E203 whitespace before ':'
380:19: E203 whitespace before ':'
387:19: E203 whitespace before ':'
388:19: E203 whitespace before ':'
389:19: E203 whitespace before ':'
390:19: E203 whitespace before ':'
391:19: E203 whitespace before ':'
392:19: E203 whitespace before ':'
394:19: E203 whitespace before ':'
395:19: E203 whitespace before ':'
397:19: E203 whitespace before ':'
398:19: E203 whitespace before ':'
401:19: E203 whitespace before ':'
402:19: E203 whitespace before ':'
403:19: E203 whitespace before ':'
404:19: E203 whitespace before ':'
405:19: E203 whitespace before ':'
406:19: E203 whitespace before ':'
407:19: E203 whitespace before ':'
426: D205 Blank line missing between one-line summary and description
444: D401 First line should be imperative: 'Sometime', not 'Sometimes'
444: D400 First line should end with '.', not 'y'
444: D205 Blank line missing between one-line summary and description
444: D208 Docstring is over-indented
470: D290 White spaces around docstring should be trimmed.
470: D400 First line should end with '.', not 't'
495:23: E127 continuation line over-indented for visual indent
515:56: E502 the backslash is redundant between brackets
516:22: E127 continuation line over-indented for visual indent


1: M100 needs more reviewers


What is this `pwd` for? I am getting this in the build output:

.../webrtc-build-scripts/ios/build.sh: line 186: .../webrtc-build-scripts/ios/webrtc: is a directory


Hmm, that's a better idea.
I just converted my old code and didn't rethink this.


Well looking back i'm not really sure what I did here


Hey Robert! Hope all is well!

On Fri, Jan 23, 2015 at 8:38 AM, Robert Gu <notifications@github.com> wrote:

> Hey @schlende <https://github.com/schlende>! This was my first time
> setting up AWS and it was not the intended purpose to expose my key_id and
> secret_key. I now know better to use figaro gem or something simlar to hide
> my keys from the public. Thanks for your concern :)
>
> Hi Tim!!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BobGu/dinner_dash/commit/cc38d1d8daa8d5958bb173df0454a0f55eab7b9a#commitcomment-9417961>
> .
>


4: L102 copyright year is outdated, expected 2015 but got 2013
24:1: I100 Imports statements are in the wrong order. import os should be before from invenio.testutils
24:1: I201 Missing newline before sections or imports.
29:1: I101 Imported names are in the wrong order. Should be VirtualIndexTable, WordTable, beautify_range_list, create_range_list, find_affected_records_for_index, get_last_updated_all_indexes, get_recIDs_by_date_authority, get_recIDs_by_date_bibliographic, re_prefix
38:1: I101 Imported names are in the wrong order. Should be get_all_indexes, get_all_indexes, get_index_id_from_index_name, get_index_tags, get_marc_tag_indexes, get_nonmarc_tag_indexes, make_prefix
38:1: F999 redefinition of unused 'get_all_indexes' from line 38
45:1: I100 Imports statements are in the wrong order. from invenio.bibindex_engine_config should be before from invenio.bibindex_engine_utils
50:1: F401 'CFG_LOGDIR' imported but unused
51:1: I101 Imported names are in the wrong order. Should be make_test_suite, nottest, run_test_suite
52:1: I101 Imported names are in the wrong order. Should be deserialize_via_marshal, run_sql
52:1: I100 Imports statements are in the wrong order. from invenio.dbquery should be before from invenio.testutils
56:1: I101 Imported names are in the wrong order. Should be get_control_nos_from_recID, get_index_strings_by_control_no
56:1: I100 Imports statements are in the wrong order. from invenio.bibauthority_engine should be before from invenio.search_engine_utils
62:1: I100 Imports statements are in the wrong order. from invenio.bibrecord should be before from invenio.bibupload_regression_tests
66:1: F401 'get_table_update_time' imported but unused
67:1: F401 'gis' imported but unused
69:1: E302 expected 2 blank lines, found 1
69: D401 First line should be imperative: 'Run', not 'Runs'
69: D205 Blank line missing between one-line summary and description
69: D208 Docstring is over-indented
86: D401 First line should be imperative: 'Prepare', not 'Prepares'
86: D290 White spaces around docstring should be trimmed.
86: D205 Blank line missing between one-line summary and description
86: D208 Docstring is over-indented
116:59: E251 unexpected spaces around keyword / parameter equals
116:61: E251 unexpected spaces around keyword / parameter equals
116:74: E251 unexpected spaces around keyword / parameter equals
116:76: E251 unexpected spaces around keyword / parameter equals
116: D400 First line should end with '.', not 'a'
116: D205 Blank line missing between one-line summary and description
116: D208 Docstring is over-indented
161:37: E251 unexpected spaces around keyword / parameter equals
161:39: E251 unexpected spaces around keyword / parameter equals
169:50: E128 continuation line under-indented for visual indent
170:68: E126 continuation line over-indented for hanging indent
181:56: E251 unexpected spaces around keyword / parameter equals
181:58: E251 unexpected spaces around keyword / parameter equals
181: D401 First line should be imperative: 'Remove', not 'Removes'
181: D205 Blank line missing between one-line summary and description
181: D208 Docstring is over-indented
195: D401 First line should be imperative: 'check', not 'checks'
195: D400 First line should end with '.', not 'r'
202: D203 Expected 1 blank line *before* class docstring, found 0
202: D400 First line should end with '.', not 'e'
202: D205 Blank line missing between one-line summary and description
202: D208 Docstring is over-indented
212: D400 First line should end with '.', not 'e'
217:49: E231 missing whitespace after ':'
217:27: E251 unexpected spaces around keyword / parameter equals
217:29: E251 unexpected spaces around keyword / parameter equals
218:45: E231 missing whitespace after ':'
222: D400 First line should end with '.', not 'p'
229:49: E231 missing whitespace after ':'
229:27: E251 unexpected spaces around keyword / parameter equals
229:29: E251 unexpected spaces around keyword / parameter equals
230:45: E231 missing whitespace after ':'
233: D401 First line should be imperative: 'Test', not 'Tests'
233: D202 No blank lines allowed *after* method docstring, found 1
233: D400 First line should end with '.', not 'e'
240: D401 First line should be imperative: 'Test', not 'Tests'
240: D202 No blank lines allowed *after* method docstring, found 1
240: D400 First line should end with '.', not 'e'
247: D401 First line should be imperative: 'Check', not 'Checks'
247: D290 White spaces around docstring should be trimmed.
247: D202 No blank lines allowed *after* method docstring, found 1
247: D400 First line should end with '.', not "'"
250:24: E261 at least two spaces before inline comment
250:25: E262 inline comment should start with '# '
263: D401 First line should be imperative: 'Check', not 'Checks'
263: D290 White spaces around docstring should be trimmed.
263: D202 No blank lines allowed *after* method docstring, found 1
263: D400 First line should end with '.', not "'"
280: D203 Expected 1 blank line *before* class docstring, found 0
280: D400 First line should end with '.', not 'e'
280: D205 Blank line missing between one-line summary and description
280: D208 Docstring is over-indented
290: D400 First line should end with '.', not 'e'
295:52: E231 missing whitespace after ':'
295:27: E251 unexpected spaces around keyword / parameter equals
295:29: E251 unexpected spaces around keyword / parameter equals
296:45: E231 missing whitespace after ':'
300: D400 First line should end with '.', not 'p'
307:52: E231 missing whitespace after ':'
307:27: E251 unexpected spaces around keyword / parameter equals
307:29: E251 unexpected spaces around keyword / parameter equals
308:45: E231 missing whitespace after ':'
312:5: E303 too many blank lines (2)
312: D401 First line should be imperative: 'Test', not 'Tests'
312: D202 No blank lines allowed *after* method docstring, found 1
312: D400 First line should end with '.', not 's'
323: D401 First line should be imperative: 'Test', not 'Tests'
323: D202 No blank lines allowed *after* method docstring, found 1
323: D400 First line should end with '.', not 's'
335: D401 First line should be imperative: 'Check', not 'Checks'
335: D290 White spaces around docstring should be trimmed.
335: D202 No blank lines allowed *after* method docstring, found 1
335: D400 First line should end with '.', not "'"
354: D401 First line should be imperative: 'Test', not 'Tests'
354: D202 No blank lines allowed *after* method docstring, found 1
354: D400 First line should end with '.', not '0'
367: D203 Expected 1 blank line *before* class docstring, found 0
367: D400 First line should end with '.', not 'e'
367: D205 Blank line missing between one-line summary and description
367: D208 Docstring is over-indented
377: D400 First line should end with '.', not 'e'
382:51: E231 missing whitespace after ':'
382:27: E251 unexpected spaces around keyword / parameter equals
382:29: E251 unexpected spaces around keyword / parameter equals
383:45: E231 missing whitespace after ':'
387: D400 First line should end with '.', not 'p'
394:51: E231 missing whitespace after ':'
394:27: E251 unexpected spaces around keyword / parameter equals
394:29: E251 unexpected spaces around keyword / parameter equals
395:45: E231 missing whitespace after ':'
399:5: E303 too many blank lines (2)
399: D401 First line should be imperative: 'Test', not 'Tests'
399: D202 No blank lines allowed *after* method docstring, found 1
399: D400 First line should end with '.', not 'l'
412:5: E303 too many blank lines (2)
412: D401 First line should be imperative: 'Test', not 'Tests'
412: D290 White spaces around docstring should be trimmed.
412: D202 No blank lines allowed *after* method docstring, found 1
412: D400 First line should end with '.', not "'"
431: D203 Expected 1 blank line *before* class docstring, found 0
431: D400 First line should end with '.', not 'e'
431: D205 Blank line missing between one-line summary and description
431: D208 Docstring is over-indented
441: D400 First line should end with '.', not 'e'
446:45: E231 missing whitespace after ':'
446:27: E251 unexpected spaces around keyword / parameter equals
446:29: E251 unexpected spaces around keyword / parameter equals
450:5: E303 too many blank lines (2)
451: D400 First line should end with '.', not 'p'
458:45: E231 missing whitespace after ':'
458:27: E251 unexpected spaces around keyword / parameter equals
458:29: E251 unexpected spaces around keyword / parameter equals
462:5: E303 too many blank lines (2)
462: D401 First line should be imperative: 'check', not 'checks'
462: D400 First line should end with '.', not '3'
474:5: E303 too many blank lines (2)
474: D401 First line should be imperative: 'check', not 'checks'
474: D400 First line should end with '.', not '1'
486:5: E303 too many blank lines (2)
486: D401 First line should be imperative: 'check', not 'checks'
486: D400 First line should end with '.', not 'x'
502:1: E303 too many blank lines (3)
502: D203 Expected 1 blank line *before* class docstring, found 0
502: D400 First line should end with '.', not 'e'
502: D205 Blank line missing between one-line summary and description
502: D208 Docstring is over-indented
512: D400 First line should end with '.', not 'e'
517:45: E231 missing whitespace after ':'
517:27: E251 unexpected spaces around keyword / parameter equals
517:29: E251 unexpected spaces around keyword / parameter equals
521: D400 First line should end with '.', not 'p'
528:45: E231 missing whitespace after ':'
528:27: E251 unexpected spaces around keyword / parameter equals
528:29: E251 unexpected spaces around keyword / parameter equals
532:5: E303 too many blank lines (2)
532: D401 First line should be imperative: 'check', not 'checks'
532: D400 First line should end with '.', not 's'
544:5: E303 too many blank lines (2)
544: D401 First line should be imperative: 'check', not 'checks'
544: D400 First line should end with '.', not 'x'
559: D203 Expected 1 blank line *before* class docstring, found 0
559: D400 First line should end with '.', not 's'
559: D205 Blank line missing between one-line summary and description
559: D208 Docstring is over-indented
565: D401 First line should be imperative: 'check', not 'checks'
565: D400 First line should end with '.', not 'k'
576: D401 First line should be imperative: 'check', not 'checks'
576: D400 First line should end with '.', not '1'
579:18: E127 continuation line over-indented for visual indent
581:60: E231 missing whitespace after ','
583: D401 First line should be imperative: 'check', not 'checks'
583: D400 First line should end with '.', not '0'
586:18: E127 continuation line over-indented for visual indent
588:60: E231 missing whitespace after ','
590: D401 First line should be imperative: 'check', not 'checks'
590: D400 First line should end with '.', not '2'
593:18: E127 continuation line over-indented for visual indent
595:60: E231 missing whitespace after ','
598: D203 Expected 1 blank line *before* class docstring, found 0
598: D400 First line should end with '.', not 'e'
598: D205 Blank line missing between one-line summary and description
598: D208 Docstring is over-indented
604: D401 First line should be imperative: 'test', not 'tests'
604: D400 First line should end with '.', not 'n'
615: D401 First line should be imperative: 'test', not 'tests'
615: D400 First line should end with '.', not '7'
629: D203 Expected 1 blank line *before* class docstring, found 0
629: D208 Docstring is over-indented
629: D200 One-line docstring should not occupy 3 lines
634: D400 First line should end with '.', not 'x'
641: D400 First line should end with '.', not 'd'
648: D400 First line should end with '.', not 'd'
655: D400 First line should end with '.', not 'e'
662: D400 First line should end with '.', not 'd'
667:55: E231 missing whitespace after ','
670: D203 Expected 1 blank line *before* class docstring, found 0
670: D204 Expected 1 blank line *after* class docstring, found 0
670: D400 First line should end with '.', not 'e'
670: D205 Blank line missing between one-line summary and description
670: D208 Docstring is over-indented
679: D400 First line should end with '.', not 'e'
684:45: E231 missing whitespace after ':'
684:27: E251 unexpected spaces around keyword / parameter equals
684:29: E251 unexpected spaces around keyword / parameter equals
688: D400 First line should end with '.', not 'p'
695:45: E231 missing whitespace after ':'
695:27: E251 unexpected spaces around keyword / parameter equals
695:29: E251 unexpected spaces around keyword / parameter equals
699:5: E303 too many blank lines (2)
699: D401 First line should be imperative: 'check', not 'checks'
699: D290 White spaces around docstring should be trimmed.
699: D400 First line should end with '.', not "'"
711:5: E303 too many blank lines (2)
711: D401 First line should be imperative: 'check', not 'checks'
711: D400 First line should end with '.', not 'x'
726: D203 Expected 1 blank line *before* class docstring, found 0
726: D204 Expected 1 blank line *after* class docstring, found 0
726: D208 Docstring is over-indented
726: D200 One-line docstring should not occupy 3 lines
734: D400 First line should end with '.', not 'e'
739:42: E231 missing whitespace after ':'
739:27: E251 unexpected spaces around keyword / parameter equals
739:29: E251 unexpected spaces around keyword / parameter equals
740:45: E231 missing whitespace after ':'
744: D400 First line should end with '.', not 'p'
751:42: E231 missing whitespace after ':'
751:27: E251 unexpected spaces around keyword / parameter equals
751:29: E251 unexpected spaces around keyword / parameter equals
752:45: E231 missing whitespace after ':'
756:5: E303 too many blank lines (2)
756: D400 First line should end with '.', not 'e'
766: D400 First line should end with '.', not 'e'
776: D209 Put multi-line docstring closing quotes on separate line
776: D203 Expected 1 blank line *before* class docstring, found 0
776: D400 First line should end with '.', not 'a'
776: D205 Blank line missing between one-line summary and description
781: D202 No blank lines allowed *after* method docstring, found 1
781: D400 First line should end with '.', not 'd'
793:28: E261 at least two spaces before inline comment
799: D209 Put multi-line docstring closing quotes on separate line
799: D400 First line should end with '.', not 'd'
799: D205 Blank line missing between one-line summary and description
814: D400 First line should end with '.', not 'd'
826: D400 First line should end with '.', not 'd'
828:20: E261 at least two spaces before inline comment
833: D400 First line should end with '.', not 'D'
847: D401 First line should be imperative: 'Insert', not 'Inserts'
847: D202 No blank lines allowed *after* function docstring, found 1
847: D400 First line should end with '.', not 'd'
861:81: E231 missing whitespace after ','
862:94: E231 missing whitespace after ','
877:41: E251 unexpected spaces around keyword / parameter equals
877:43: E251 unexpected spaces around keyword / parameter equals
890: D401 First line should be imperative: 'Insert', not 'Inserts'
890: D202 No blank lines allowed *after* function docstring, found 1
890: D400 First line should end with '.', not 'd'
904:81: E231 missing whitespace after ','
905:94: E231 missing whitespace after ','
919:41: E251 unexpected spaces around keyword / parameter equals
919:43: E251 unexpected spaces around keyword / parameter equals
932: D103 Docstring missing
965: D103 Docstring missing
972: D401 First line should be imperative: 'create', not 'creates'
972: D400 First line should end with '.', not 's'
984: D401 First line should be imperative: 'remove', not 'removes'
984: D400 First line should end with '.', not 'x'
993: D203 Expected 1 blank line *before* class docstring, found 0
993: D400 First line should end with '.', not "'"
993: D205 Blank line missing between one-line summary and description
1003: D102 Docstring missing
1014: D102 Docstring missing
1021: D400 First line should end with '.', not 'y'
1024:66: E231 missing whitespace after ','
1028: D400 First line should end with '.', not 'x'
1031:66: E231 missing whitespace after ','
1032:67: E231 missing whitespace after ','
1034: D400 First line should end with '.', not 'x'
1037:66: E231 missing whitespace after ','
1038:58: E231 missing whitespace after ','
1040: D400 First line should end with '.', not 'x'
1043:66: E231 missing whitespace after ','
1044:61: E231 missing whitespace after ','
1046: D400 First line should end with '.', not 'x'
1049:66: E231 missing whitespace after ','
1052: D400 First line should end with '.', not 't'
1057: D400 First line should end with '.', not 's'
1063: D400 First line should end with '.', not '0'
1066:43: E203 whitespace before ':'
1066:44: E231 missing whitespace after ':'
1071:1: E303 too many blank lines (4)
1071: D101 Docstring missing
1078: D102 Docstring missing
1087:49: E251 unexpected spaces around keyword / parameter equals
1087:51: E251 unexpected spaces around keyword / parameter equals
1096: D102 Docstring missing
1103:49: E251 unexpected spaces around keyword / parameter equals
1103:51: E251 unexpected spaces around keyword / parameter equals
1111:5: E303 too many blank lines (2)
1123:5: E303 too many blank lines (2)
1135:5: E303 too many blank lines (2)
1152: D290 White spaces around docstring should be trimmed.
1152: D203 Expected 1 blank line *before* class docstring, found 0
1152: D400 First line should end with '.', not "'"
1155: D400 First line should end with '.', not 'x'
1159: D400 First line should end with '.', not 'x'
1163: D400 First line should end with '.', not ')'
1167: D400 First line should end with '.', not "'"
1174: D400 First line should end with '.', not "'"
1181: D400 First line should end with '.', not "'"
1185: D400 First line should end with '.', not '%'
1190: D400 First line should end with '.', not 'y'
1194: D400 First line should end with '.', not "'"
1196:96: E231 missing whitespace after ','
1198: D400 First line should end with '.', not "'"
1203: D400 First line should end with '.', not "'"
1206:25: E128 continuation line under-indented for visual indent
1208: D400 First line should end with '.', not "'"
1210:51: E202 whitespace before ')'
1211:25: E128 continuation line under-indented for visual indent
1213: D400 First line should end with '.', not 'g'
1219: D290 White spaces around docstring should be trimmed.
1219: D203 Expected 1 blank line *before* class docstring, found 0
1219: D204 Expected 1 blank line *after* class docstring, found 2
1219: D400 First line should end with '.', not "'"
1223:5: E303 too many blank lines (2)
1223: D290 White spaces around docstring should be trimmed.
1223: D400 First line should end with '.', not 'x'
1227: D290 White spaces around docstring should be trimmed.
1227: D400 First line should end with '.', not 'x'
1229:65: E231 missing whitespace after ','
1231: D290 White spaces around docstring should be trimmed.
1231: D400 First line should end with '.', not 'x'
1238: D400 First line should end with '.', not 'r'
1243: D400 First line should end with '.', not 'x'
1246:30: E203 whitespace before ','
1248: D400 First line should end with '.', not 'x'
1253: D400 First line should end with '.', not 'x'
1258: D400 First line should end with '.', not 'x'
1263: D400 First line should end with '.', not 'x'
1269: D400 First line should end with '.', not 'x'
1276: D290 White spaces around docstring should be trimmed.
1276: D203 Expected 1 blank line *before* class docstring, found 0
1276: D400 First line should end with '.', not 'd'
1279: D400 First line should end with '.', not 'e'
1294: D400 First line should end with '.', not 'e'
1309: D400 First line should end with '.', not 'e'
1324: D400 First line should end with '.', not 'e'
1334: D400 First line should end with '.', not 'e'
1344: D400 First line should end with '.', not 'e'
1355: D290 White spaces around docstring should be trimmed.
1355: D203 Expected 1 blank line *before* class docstring, found 0
1355: D400 First line should end with '.', not 'x'
1364: D401 First line should be imperative: 'create', not 'creates'
1364: D400 First line should end with '.', not 'x'
1380: D401 First line should be imperative: 'reindexe', not 'reindexes'
1380: D400 First line should end with '.', not 'r'
1389:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
1400:5: E303 too many blank lines (2)
1401: D102 Docstring missing
1409: D102 Docstring missing
1415: D400 First line should end with '.', not 'x'
1420: D400 First line should end with '.', not '1'
1426: D400 First line should end with '.', not '3'
1433: D400 First line should end with '.', not 'l'
1443: D101 Docstring missing
1450: D102 Docstring missing
1464: D102 Docstring missing
1467: D400 First line should end with '.', not 's'
1473: D400 First line should end with '.', not 's'
1479: D400 First line should end with '.', not 'x'
1485: D400 First line should end with '.', not 'm'
1491: D400 First line should end with '.', not 'm'
1497: D400 First line should end with '.', not '6'
1505: D400 First line should end with '.', not '0'
1514: D101 Docstring missing
1521: D102 Docstring missing
1536: D102 Docstring missing
1539: D400 First line should end with '.', not 's'
1545: D400 First line should end with '.', not '8'
1553:26: E128 continuation line under-indented for visual indent
1554:26: E128 continuation line under-indented for visual indent
1555:26: E128 continuation line under-indented for visual indent
1559: D203 Expected 1 blank line *before* class docstring, found 0
1559: D400 First line should end with '.', not 'y'
1562: D400 First line should end with '.', not 's'
1568:25: E261 at least two spaces before inline comment
1572: D400 First line should end with '.', not 's'
1578:25: E261 at least two spaces before inline comment
1583: D203 Expected 1 blank line *before* class docstring, found 0
1583: D204 Expected 1 blank line *after* class docstring, found 0
1583: D400 First line should end with '.', not 'n'
1583: D205 Blank line missing between one-line summary and description
1583: D208 Docstring is over-indented
1593: D102 Docstring missing
1596:13: F841 local variable 'index_id' is assigned to but never used
1617: D102 Docstring missing
1619:13: F841 local variable 'index_id' is assigned to but never used
1640: D400 First line should end with '.', not 't'
1651: D400 First line should end with '.', not 'y'
1662: D400 First line should end with '.', not 'x'
1670: D400 First line should end with '.', not 'e'
1677: D400 First line should end with '.', not '3'
1688: D400 First line should end with '.', not '9'
1695: D400 First line should end with '.', not 'e'
1701: D400 First line should end with '.', not 'x'
1713: D209 Put multi-line docstring closing quotes on separate line
1713: D203 Expected 1 blank line *before* class docstring, found 0
1713: D204 Expected 1 blank line *after* class docstring, found 2
1713: D400 First line should end with '.', not 'd'
1713: D205 Blank line missing between one-line summary and description
1713: D208 Docstring is over-indented
1718:5: E303 too many blank lines (2)
1719: D401 First line should be imperative: 'indexe', not 'indexes'
1719: D400 First line should end with '.', not 'e'
1721:9: F841 local variable 'index_id' is assigned to but never used
1728: D401 First line should be imperative: 'trigger', not 'triggers'
1728: D400 First line should end with '.', not 'x'
1733: D400 First line should end with '.', not 's'
1735:49: E231 missing whitespace after ','
1741: D400 First line should end with '.', not 's'
1743:53: E231 missing whitespace after ','
1743:56: E231 missing whitespace after ','
1743:60: E231 missing whitespace after ','
1751: D400 First line should end with '.', not 's'
1753:51: E231 missing whitespace after ','
1760: D400 First line should end with '.', not 'e'
1767: D400 First line should end with '.', not 'd'
1771:52: E231 missing whitespace after ','
1772:52: E231 missing whitespace after ','
1773:52: E231 missing whitespace after ','
1785: D101 Docstring missing
1787: D400 First line should end with '.', not 'e'
1796: D400 First line should end with '.', not 't'
1803:29: E127 continuation line over-indented for visual indent
1806: D101 Docstring missing
1809:5: E303 too many blank lines (2)
1809: D400 First line should end with '.', not 'e'
1819: D400 First line should end with '.', not 'd'
1827: D400 First line should end with '.', not 'd'
1835: D400 First line should end with '.', not 'e'
1871:1: W391 blank line at end of file


I think `tol` and `abs_tol` are needlessly brief.  I don't see someone in a glance appreciating the meaning of the names without having to looking up the documentation. Neither are programmers today limited to 6 or less character variable names! A function who's arguments can be immediately understood is better than one for whom they cannot. I would suggest `rel_tolerance` and `abs_tolerance` instead. I think then most people should be able to easily discern what `rel` and `abs` mean given the context of the whole function signature they are reading.


The file is empty if everything succeeded i.e coverity server doesn't return any message. But if upload fails it contains server response. I could redirect output to NUL, but we lose message in this case.


Objexx_Tuning (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.23%25-red.svg)


No, it's OK. Just add it in .gitignore.


I think in the past MSBuild was directly called. No we use build.bat which take care about everything.


We're likely going to have to specialcase for those units. Let's spin off this discussion in slack


Our observations were this:
* Without the patch the hudson-jdepend files were created on the master's io.tmpdir. In our case we have 20 masters running on one beefy host, each master is running as a different user and uses sth. like /opt/foo/MASTER_USERNAME/tmp as temp directory.
* After some time, the tmp directory was full of files, network was sluggish (one job created 2GB temp files which had to be shoved from slave to master), so we were quite happy with the fix (tmp file stays on the slave).
* What kind of regression did you see?


Yeah, that might be the reason. https://github.com/kasper93/mpc-hc/commit/b11dff22bcf57eb3163717b8bcac5c1b14835faa


Added to release notes at http://biojava.org/wiki/BioJava:Download_4.0.0#New_Features


It feels like there should be a way to prevent trying further matchers… something like `e.preventDefault()` in JavaScript.

```php
    public function getMatches($line, $input, $index, array $info)
    {
        if (preg_match('#\bnew\s+(\\\\\w*)*$#', substr($line, 0, $index))) {
            $matches = array_map($parenthesize, array_filter(get_declared_classes(), function ($class) use ($input) {
                return preg_match(sprintf('#^%s#', $input), $class);
            }));

            // This is a `new` call, so we'll prevent anyone else from matching
            return array($matches, true);
        }

        return array(array(), false);
    }
```

Then the whole body of this method could be something like:

```php
$matches    = array();
$newMatches = array();
foreach ($this->matchers as $matcher) {
    list($newMatches, $done) = $matcher->getMatches($line, $input, $index, $info);
    $matches = array_merge($matches, $newMatches);
    if ($done === true) {
        break;
    }
}

return $matches;
```

I'm not 100% sold on this particular implementation, but something like this seems like it could work :)


Awesome!

Once I've updated my stuff to 1.8 I'll give this a test @drtshock.


Yes I was aware of this regression when I merged.

It's part of the texture hunt


`return RESULT_SUCCESS.raw`


This will result in a badmatch, you aren't returning the Tombstone.


写成 for (len = childrens.length; i < len; i++) {


UPGRAYEDD


请写成 for (i = 0, len = childrens.length; i < len; i++) {


Удалил лишний код, который вычислял где встречаются схожие элементы и выдает индексы первой и последней элементов в последовательности.


final ?


`.post(null)` is a shortcut for `.method("POST", null)`


Ok:) Already renamed.


Objexx_Tuning (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


эх, вот бы избавиться от флеша и сделать всё на HTML5


+1111111111111 this is the best commit of the year so far.


Also, if it would be simpler I don't see any reason not to use a function clause guard here instead of the if statement.


I guess this should be a <d-store>


Looks good.


Also split Wrapper interfaces into push/get variants - will be useful shortly.
Also improved Widget labeling and error displays.


nwfhhiruif<joe<


rename `arbiter` to `handle` to be consistent


`*handle = handle_res.MoveFrom();` ?


Ok ;)


TESTS PASSED
 Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=8dd7fdc49fdc4051a051285ae55e0c4a
 plone-5.0-python-2.7 [SUCCESS]


`auto handle_res = Kernel::g_handle_table.Create(arbiter_res.MoveFrom());` ?


Hi - slightly confused did performance refactor make it into beta14?
This suggests the attribute 'active-slide' has become 'selected' but the source for beta14 still have 'active-slide'.
Thanks


MoveFrom?


Rename `semaphore` to `handle` to be consistent


What is `config.remote` for? I don't see it being used anywhere.


final ?


Yes this needs to be removed. Artifact of my laziness


@javierguerragiraldez I initially just wanted to add parameter type specifications but then decided to reword a bit (I thought inside/outside a rule was a bit confusing). Are you OK with these changes?


Another option is to write a test client in ZMQ that talks to the IJulia kernel and exercises various message types.


No worries. I am testing this now. If all goes well, I will merge this into my branch that includes the support to build the "framework" which has the open PR.


Missing docstring


This line was missing a comma at the end of it, and as thus broke the entire staff page. I was able to patch it via commit 6cb588e3b0dffb16d2624b302edddbc29bf2d309, but in the future validate your JSON via: http://jsonlint.com/


I would assume it would do nothing in current implementations but allow future implementations to have a 3D array of chunks.

(Actually all that is incorrect since technically a *Chunk* is a 16³ area and what gets commonly referred to as a *Chunk* is actually a *ChunkColumn* (a vertical stack of 16 actual chunks) but one would assume that the API here is actually referring to chunk storage units essentially, which may or may not be addressable in 3 dimensions.)


fixed. thanks.


These should be registering the interfaces rather than the class surely? Even after changing them to interfaces the dependency service still can't find them. Does this need to be done at an assembly level?


Ships it.


Nice method, but which `BlockLoc` would be returned for:
* `ORDINAL`  `Direction`s like `NORTHEAST`
* `SECONDARY_ORDINAL` `Direction`s like `NORTH_NORTHEAST`

And which `BlockLoc` would be returned if the current block is the highest block in the world and you are requesting `Direction,UP`?

Maybe this should return an `Optional`.

Another similar method for this would be cool as well:
`BlockLoc getRelative(Axis axis, AxisDirection direction)`


Developing old annotation purging.


very good.


This should do it:  hakanensari/jeff@7908d15


It seems Gradle doesn't like to package /public, only /src/main/resources.  But Spring wants /public.  Solution: put static content in /src/main/resources/public so static content will be included in the packaged .jar file.


Thanks @sergey-tihon !


Looks good.


Hmm... I kind of liked the explicit Clear() here. The reason is because we're not actually sure if it makes sense to create these events in the Initialize() service function (rather than some internal initialize function that happens when the APT service is first created on system bootup). If that's the case, and we move the Create() calls, we'd probably forget to Clear notification_event_handle on APT::Initialize().

Oh, and probably makes sense to put a TODO or something about that to verify if notification_event_handle/pause_event_handle are explicitly Cleared/Signaled every time APT::Initialize is called, and to check if they are created every time APT::Initialize is called.


You are welcome, I did it for all fsprojects repos


Why do we need this block {} here?


looks good.


Scanner may be reused for multiple parse passes, so no need to delete it.

If Clay called as a standalone program, memory will be deallocated on exit anyway.


1: M111 unrecognized component name: oauthclient


Yep, that looks better and allow to launch ANY future test plan as well. The only drawback that it will scan the only one catalog for files - I've found that <testFilesIncluded> require exact catalog in <testFilesDirectory>, not simply /src/test/resources. But it doeesn't matter for the current configuration.
ОК, I'll test it and than change the request.


Sort of random thought, but should we be using RESULT_SUCCESS for these?


Please use BitEasy url here. It doesn't affect anything, but it'd be nice to keep specs consistent. Since this is a BitEasy adapter, it should only contain BitEasy api urls.


Dövme İle ilgilenen arkadaşlar için geliştirdiğimiz application yakında yayına girecektir tüm hızlıyla çalışmalara devam edilmektedir dövme malzemesi ile dövmelerin incelendiği yükleyebilidğiniz ve malzeme siparişi verebildiğiniz bir app yakında yayına girecektir


Can you move the other comments? The inconsistency is killing my OCD more than the line width was :)


Maven could have just been kept while you still locally build with jars and eclipse :(
It's just nice to be able to fork a repo and import a project into an IDE using maven rather than having to add dependency jars manually in the program.

One of us...one of us.. one of us..


nullptr for these?


Compile:

lessc --verbose weather-icons/weather-icons.less css/weather-icons.css


Same comment as with APT


@chopmann das databinding? - http://grails.github.io/grails-doc/2.3.x/guide/theWebLayer.html


> And which BlockLoc would be returned if the current block is the highest block in the world and you are requesting Direction.UP?

The block is just an air block. Just because blocks outside the world extents may not be backed by storage or otherwise mutable in the underlying doesn't mean they don't exist as blocks.


1/23/2015更新：
之前一直有更新但是没介绍，这次加上。
截止目前为止已经实现了如下功能：
1、显示全中国地区所有省市县。
2、能够查阅到县的天气并返回显示到设备上。


When this method is called the LHN isn't there yet, which means the jQuery selectors don't return anything and I can't set whether to have the menu open or closed.

What would be the best way to wait for that here?


Didn't find a way to contact someone without a google account anywhere. So here a bug report:

In gitblit: If you rename a repo through the edit page to a name that is already used. You get a warning at the following page that is an edit page too. If you there click the delete button you remove the one you were trying to overwrite instead of the one you wanted to rename.


Je oualid :+1:


Also got rid of some CPU warnings that were pretty pointless. But this commit makes Metroid Fusion and Zero Mission work! Metroid!


indentation.


I've just seen this commit: https://github.com/driftyco/ionic/commit/2910f508a9c3a877efede5923a84f36ef22f7bba
What happened :| is it likely that we'll see this refactor in the future?


Well, that's confusing. In the cndoom source code you list HR2.WAD among the supported PWADs and on the Compet-N database site Scythe is listed. Have I missed an announcement?


Autant de temps pour si peu de travail, je suis déception :-1:


IIUC this is in line with a change made from gatling 2.0 -> 2.1


Where do you see that py34 is not officially supported? It's in both the setup.py and in the travis build configuration.


Not sure if this would be better formatted over multiple lines. Would make it easier for humans to read?

Use best judgement


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 67](http://192.168.44.2:8111/viewLog.html?buildId=168&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) is now running


@cowl I hope you can help me here.

You said I would need to make instances. However, `substitute`, `unwrap` and `asSubstitution` are all covered by type classes with instances, and yet I still get the following ghci output:

```

LG/Subnet.hs:32:21:
    No instance for (ValidSubstitution b0)
      arising from a use of ‘substitute’
    The type variable ‘b0’ is ambiguous
    Note: there are several potential instances:
      instance ValidSubstitution ContextTerm
        -- Defined at LG/Term.hs:69:10
      instance ValidSubstitution ValueTerm -- Defined at LG/Term.hs:66:10
    In the expression:
      substitute (unwrap term1) (asSubstitution v) term2
    In an equation for ‘mergeTerm’:
        mergeTerm = substitute (unwrap term1) (asSubstitution v) term2
    In an equation for ‘merge’:
        merge net1 net2 v
          = Subnet allNodes mergeTerm mergeCommand mergeCotensor mergeMu
          where
              (Subnet nodes1 term1 command1 cotensor1 mu1) = net1
              (Subnet nodes2 term2 command2 cotensor2 mu2) = net2
              allNodes = Set.union nodes1 nodes2
              mergeTerm = substitute (unwrap term1) (asSubstitution v) term2
              ....

LG/Subnet.hs:32:33:
    No instance for (Wrappable b0) arising from a use of ‘unwrap’
    The type variable ‘b0’ is ambiguous
    Note: there are several potential instances:
      instance Wrappable CommandTerm -- Defined at LG/Term.hs:50:10
      instance Wrappable ContextTerm -- Defined at LG/Term.hs:46:10
      instance Wrappable ValueTerm -- Defined at LG/Term.hs:42:10
    In the first argument of ‘substitute’, namely ‘(unwrap term1)’
    In the expression:
      substitute (unwrap term1) (asSubstitution v) term2
    In an equation for ‘mergeTerm’:
        mergeTerm = substitute (unwrap term1) (asSubstitution v) term2
```

I hope you have a brilliant idea!


minor formatting then :shipit:


In fact it was #87


Much better :smile_cat:


@brendo Since when does passing a js array in php works ? This totally crashed my setup... Maybe because I still run php 5.3 ?


I'm OK with the rewording, but the description is not entirely correct. The "global" usage (what I called "outside any rule") is not " the only key on a rule " `...,{state_track="name"},...` it's like `..., state_track="name",...`


Well, if we de-activate the color it will be very hard to spot which maps
you have, and just moved to the deactivated folder. And if we introduce a
new color, we will have a zoo of colors any will not create much more
clarity either (likely the cause for more support questions.)

I just notice another few minor issues here:
- After you deactivate a map, it is shown on the "Local" tab as deactivated
only after you left then re-enter the Manage maps screen
- on the All Downloads tab it seems shown as deactivated only after an
app-restart (pressing the refresh button does not seem to help. same issue
for after you delete maps, they will still be shown there.)

So we have more small issues here, may have to debug the whole behavior a
bit after the recent changes. Regarding the color for outdated de-activated
maps, likely leaving them at green for now is the solution causing least
harm (Updating them will automatically also move them to "active", where
the color code is correct.)

On Fri, Jan 23, 2015 at 12:23 AM, vshcherb <notifications@github.com> wrote:

> Exactly, I had discussion with Areg and I don't feel good idea to update
> deactivated maps. Concerns about traffic and reports how many deactivated
> maps users can have. May be we could disable color, so people will be less
> confused?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/osmandapp/Osmand/commit/261b12a651ac297c0e129ccf7ed3e96a7c2584ba#commitcomment-9407263>
> .
>


I (thought I) saw it not being passed during stdenv bootstrap. I'll re-check.


My apologies, I misread the protocol yesterday when reviewing it.  Example 5 doesn't relate at all.

Additionally, I had forgotten that I already check for errors in the code above the `childCount == 0` validation, so you're correct that it's useless.

I submitted a [new pull request](https://github.com/robbiehanson/XMPPFramework/pull/488) with these changes.  Good catch on the `NSLog`.


@waqasshabbir but it is a generic problem, It could appear on every date, not only french.


<base> history api behavior seems pretty odd to me, but I see the problem.

Try something like this:
window.history.pushState(null, null, window.location.href.split('#')[0] + '#' + $targetPanel.attr('id'));


Uhhh.... wtf?


I can't really remember, since it is so long ago :-), but I would guess that this was some kind of of deliberate decision in the form, that I somehow needed a default value and didn't want to set this to 'C' or 'S' to not confuse people using it to think, SchedulerRuntime is normally always of Scraper runtime type or something and enforce people, to make a conscious choice.

Does this actually has any problematic behaviour? I actually never noticed anything and so I would prefer to leave it as is, if it is just for cosmetics.


ack


@yuandong1222 you should be using the appropriate utime_t calls rather than calling localtime. Something like:
utime_t ut(mtime, 0);
formatter->dump_stream("mtime") << ut;


Nop, this should register the implementation of each service..

This seems to be working on the samples..


awesome. I'm going to remove the pwd


Is this just a missing definition in function_wrappers.h? Shouldn't we add it and use CASCADE_RESULT here?


Jeez.


@ChrisLane +1

Why disable all of us? Your method of building would still work with Maven. All you've done is hurt any chance of outside contributions and make it very difficult to compile (I use the command line to compile, usually with Maven).

This just wasn't thought out very well.


> As of PHP 5.4 you can also use the short array syntax, which replaces array() with [].
> —http://php.net/manual/en/language.types.array.php


It would not appear for dates in japanese or russian. Those languages don't even have 'h' letter.


Do you have a reference to the changelog?


array('symphony-page', 'mode') seems to be working...


Objexx_Tuning (DeadParrot) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.17%25-red.svg)


Because I didn't think of it? ;-) DONE in 21616725382d2899f5b9318cb4a5a3bbb8076a1a


@tumashu 此处会造成 `master` merge `devel` 时会有一个冲突！？


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 67](http://192.168.44.2:8111/viewLog.html?buildId=168&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) outcome was **SUCCESS**
Summary: Tests passed: 13 Build time: 00:07:56


@longjon Hi, I think it is better to set some default values to has_ignore_label_ and normalize. I have tested it and it will crash if you do not set ignore_label.


I think the trailing "/edit" can go.


I changed the last commit in the pull request to fix the bugs
you pointed out.  Please take another peek at it.  Thanks!

Bob

On Wed, Jan 21, 2015 at 2:49 PM, Robert Brown <robert.brown@gmail.com>
wrote:

> Yes, maybe that's the case ... forgot that Allegro does not have
> unboxed 32-bit integers on 32-bit hardware.
>
> Bob
>
>
> On Wed, Jan 21, 2015 at 2:44 PM, Nathan Froyd <notifications@github.com>
> wrote:
>
>> I'm not familiar with what Allegro can do here. My assumption is that
>> ub32ref/le would return a (potentially boxed) integer, and then
>> extracting the halves out of them would be expensive (since the compiler
>> wouldn't inline ldb on not-known-to-be-fixnum things), versus just
>> grabbing the (fixnum-sized) 16-bit quantities.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/brown/nibbles/commit/a1f4129d6e0609cb6a32a49f5f5810c7b83a0c53#commitcomment-9382927>
>> .
>>
>
>


Can you document what is the parameter T?


This fixes #7.


See above. If you have the time, please send a PR to fix this. (Requirement for Symphony still is PHP 5.3 and up.)


- Added scrolling instructions in game
- Added instructions file that reads in the instructions from a file rather than just printing them
- Added some of the code for the enemies, not yet implemented though
- Cleaned up comments and removed code that was not in use
- Aesthetic fixes


The method order is reversed here im comparison to the rest of the `GameRegistry`.

Everywhere else there is first the `Stuff getStuff(By param)` and then the `List getStuff()` method.


Current the other pair method is still called "get", do you want to call them "setNestedValuesInMap" and "getNestedValuesInMap"? Keep them in pair seems a good idea.


I think you can tackle this with a plain 'sort'


Could you add a test so that regressions will be caught in the future by Travis?


:+1: drop support in savon 3


Easy fix.  ;)


It sounds like this is a bug fix.

Would you be interested in making this into a Pull Request, so the fix goes into the main program? :smile:


Is this module not needed any more? Looks like you're bypassing it now to choose between directly using localStorage and sessionStorage.


What if one of the parts is not active but already has a table which was loaded before?
Also this code makes unnecessary lines:
https://github.com/dereksantos/angular-translate/commit/bb1686514bd8491ea6a999cac747a27b3fd7f408#diff-607f7e783d326a61fcc59253b7ed447fR283
https://github.com/dereksantos/angular-translate/commit/bb1686514bd8491ea6a999cac747a27b3fd7f408#diff-607f7e783d326a61fcc59253b7ed447fR286 - https://github.com/dereksantos/angular-translate/commit/bb1686514bd8491ea6a999cac747a27b3fd7f408#diff-607f7e783d326a61fcc59253b7ed447fR288
https://github.com/dereksantos/angular-translate/commit/bb1686514bd8491ea6a999cac747a27b3fd7f408#diff-607f7e783d326a61fcc59253b7ed447fR298


Two comments
- The 1st variable name is protoValue. Does this mean this only works for protobuf based Streamy?
- Process needs to be a function? Can you document what's the expected behavior or process?


Do you happen to know why this happens? I'm curious, because when the check fails it returns `nil`, so it's like saying `@banner = nil`.

By the way, I think it's safe to delete line 54 entirely (it's simply redundant) :)


r+wc

Might nice to add some testing to this. Even if retrospectively.


Objexx_Tuning (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (597 of 597 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.36%25-green.svg)


testing


Do you have examples of these crashes?


I think this was depending on `marketplace-core-module`'s `storage` module which this doesn't actually depend on. Essentially if you used `dismiss="remember"` outside of fireplace or some other context that provided the `storage` module this would blow up.


@thoughtpolice, now I am confused. I marked the package "broken" in https://github.com/NixOS/nixpkgs/commit/e823c123a8e85d07d319152b8cd3f69fe53d759a a long time ago. When was the last time that you built it successfully?


Hello,
seems that today Whatsapp did some (major) change (the only existing client for my phone os is down) and wart is affected by it


yes, you are totally right, I am changing it to french simplification.


what's usually involved in deliverChanges? in what conditions will it be expensive to be called twice?


I think that (beyond testing purposes) it makes sense to not try caching the styleguide. We actually plan on moving it our of the repository and just including the CSS and JS files required for the kit. Caching all other assets appears to make sense though.


I'm having a hard time visualizing when line would not be null and m_returningToPromptAfterError would be true.  line is only null after a bad "file" command, right?  Like if the file did not exist.

m_returningToPromptAfterError is only set to true in stopOrContinue, and I can't see it getting called from readScriptFile for anything except for a bad file command.  What's the practical effect of this change?


Oh of course. I'm not trying to be rude. I just wanted you to be aware of it in case that AWS keypair is still active. Anyone could get access to your AWS buckets and upload and delete files. It could cost you money and be annoying :/

I assume you probably deploy to Heroku? If so then the recommended way to do this is to have rails look into the environment for the keys.

We use this gem at work --> https://github.com/bkeepers/dotenv for our local dev environments and on Heroku we can set environment variables which our rails app reads from.

Anyway keep on coding.


shouldn't be here
```javascript
`ten_minutes`: 1000 * 60 * 10
```


the if statement is empty? maybe leave a todo about what's needed to be done here?


Thanks for your submission. Two quick questions before I merge:

* Won't `exports` always be undefined here? I looked at code from a different source and I noticed they used this  comparison:

    ```js
    } else if (typeof module === 'object' && typeof module.exports === 'object') {
    ```
* Was it just a personal preference to convert all the tabs to spaces or it is a requirement? I'm just curious, it's not that big a deal to me.


The rest of the changes in this commit (changes to Statement.java and TestAdHocQueries.java) look fine.


New library? What is the difference between old and new?


It's been stuck in my local cache I suppose. But either way, this package still should not be broken - but it is for a proprietary application most people will not have access to. I'd be surprised if literally anyone else could use the 1.8.x cryptol expression, but I sure am.


I feel like I am so close to getting this to work, but something in the resulting URL is getting a "Are you sure you want to do this?" page from WordPress.


It really shouldn't ever wrap.

The TL is generally 3-4 characters long so it will only ever wrap at stupidly high zooms... At the zoom it takes to wrap on decent screens the interface is completely unusable anyways (i.e. the info-float is taller than the height of the screen).


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1961](http://teamcity.monogame.net/viewLog.html?buildId=5060&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


These methods are visible outside the library, don't need to use optional param?


Epic change


Certainly more usable on actual mobiles now.

![](http://i.imgur.com/hUxC6PX.png)


合并到master只能手动来完成了，Chinese基本功能已经完成。 master应该不需要经常合并。。。。


Who uses the DMOJ on mobile, anyways? On mobile you have the option of how you want the page to display; whenever I load the site on my phone it's always in a desktop-like mode with massive scrollbars, and you can easily zoom in on what matters.

But not bad.


I only had it in there to make the code a bit more readable at the time and not to share variables possibly.  I can remove it later though


@ldacosta why is the reader not an implicit?

also, use your discretion wrt doing it now or later (coz i know you have a todo for it), but one possible place where you could put the ``defaultValue`` from is in the reader trait (and the implicit object implementing it). which also takes care of tying it to the type of default value. should be a simple fix


1: M100 needs more reviewers
1: M101 signature is missing


// Removed - redundant


we will show them how to set their working directing in R studio. don't your own path in the script because it won't be generalziable


22:1: I101 Imported names are in the wrong order. Should be current_app, has_request_context, request, session
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures
63: D203 Expected 1 blank line *before* class docstring, found 0
181:9: B901 blind except: statement
228:9: B901 blind except: statement