Just to be clear, I have no doubt that the installer binary works on my system, but that I can't use the script to generate a new installer binary. So if we are going to use the script to build a new installer which builds against the master branch, we need to modify the path or use a relative path.


:eyes:


Will do later.


DivideByZeroProtection (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (332 of 332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


This commit causes failures when users attempt to build against linux 3.17.6:
```
make ARCH=x86_64 CROSS_COMPILE= -C /lib/modules/3.17.6-1-ARCH/build M=/build/rtl8192du-git/src/rtl8192du  modules
make[1]: Entering directory '/usr/lib/modules/3.17.6-1-ARCH/build'
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_cmd.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_security.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_debug.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_io.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_ioctl_set.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_mlme.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_ieee80211.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_mlme_ext.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_wlan_util.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_pwrctrl.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_rf.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_recv.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_sta_mgt.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_ap.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_p2p.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_xmit.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_sreset.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/core/rtw_efuse.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/hal_intf.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/hal_com.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_hal_init.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_phycfg.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_rf6052.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_dm.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_rxdesc.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_cmd.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/usb_halinit.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192du_led.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192du_xmit.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192du_recv.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/hal8192duhwimg.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/usb_ops_linux.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/hal/rtl8192d_xmit.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/osdep_service.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/os_intfs.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/usb_intf.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/usb_ops_linux.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_linux.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/xmit_linux.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/mlme_linux.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/recv_linux.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.o
  CC [M]  /build/rtl8192du-git/src/rtl8192du/os_dep/rtw_android.o
In file included from /build/rtl8192du-git/src/rtl8192du/include/drv_types.h:65:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:20:
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_indicate_sta_assoc':
/build/rtl8192du-git/src/rtl8192du/include/ioctl_cfg80211.h:107:69: error: too few arguments to function 'cfg80211_rx_mgmt'
 #define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, gfp)
                                                                     ^
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:2429:2: note: in expansion of macro 'rtw_cfg80211_rx_mgmt'
  rtw_cfg80211_rx_mgmt(padapter, freq, 0, pmgmt_frame, frame_len, flags);
  ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/osdep_service.h:62:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:19:
include/net/cfg80211.h:4425:6: note: declared here
 bool cfg80211_rx_mgmt(struct wireless_dev *wdev, int freq, int sig_dbm,
      ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/drv_types.h:65:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:20:
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_indicate_sta_disassoc':
/build/rtl8192du-git/src/rtl8192du/include/ioctl_cfg80211.h:107:69: error: too few arguments to function 'cfg80211_rx_mgmt'
 #define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, gfp)
                                                                     ^
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:2478:2: note: in expansion of macro 'rtw_cfg80211_rx_mgmt'
  rtw_cfg80211_rx_mgmt(padapter, freq, 0, mgmt_buf, frame_len, flags);
  ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/osdep_service.h:62:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:19:
include/net/cfg80211.h:4425:6: note: declared here
 bool cfg80211_rx_mgmt(struct wireless_dev *wdev, int freq, int sig_dbm,
      ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/drv_types.h:65:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:20:
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_rx_action_p2p':
/build/rtl8192du-git/src/rtl8192du/include/ioctl_cfg80211.h:107:69: error: too few arguments to function 'cfg80211_rx_mgmt'
 #define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, gfp)
                                                                     ^
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:3134:2: note: in expansion of macro 'rtw_cfg80211_rx_mgmt'
  rtw_cfg80211_rx_mgmt(padapter, freq, 0, pmgmt_frame, frame_len, flags);
  ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/osdep_service.h:62:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:19:
include/net/cfg80211.h:4425:6: note: declared here
 bool cfg80211_rx_mgmt(struct wireless_dev *wdev, int freq, int sig_dbm,
      ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/drv_types.h:65:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:20:
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_rx_p2p_action_public':
/build/rtl8192du-git/src/rtl8192du/include/ioctl_cfg80211.h:107:69: error: too few arguments to function 'cfg80211_rx_mgmt'
 #define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, gfp)
                                                                     ^
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:3158:2: note: in expansion of macro 'rtw_cfg80211_rx_mgmt'
  rtw_cfg80211_rx_mgmt(padapter, freq, 0, frame, frame_len, flags);
  ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/osdep_service.h:62:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:19:
include/net/cfg80211.h:4425:6: note: declared here
 bool cfg80211_rx_mgmt(struct wireless_dev *wdev, int freq, int sig_dbm,
      ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/drv_types.h:65:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:20:
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_rx_action':
/build/rtl8192du-git/src/rtl8192du/include/ioctl_cfg80211.h:107:69: error: too few arguments to function 'cfg80211_rx_mgmt'
 #define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, gfp)
                                                                     ^
/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:3185:2: note: in expansion of macro 'rtw_cfg80211_rx_mgmt'
  rtw_cfg80211_rx_mgmt(adapter, freq, 0, frame, frame_len, flags);
  ^
In file included from /build/rtl8192du-git/src/rtl8192du/include/osdep_service.h:62:0,
                 from /build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.c:19:
include/net/cfg80211.h:4425:6: note: declared here
 bool cfg80211_rx_mgmt(struct wireless_dev *wdev, int freq, int sig_dbm,
      ^
scripts/Makefile.build:257: recipe for target '/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.o' failed
make[2]: *** [/build/rtl8192du-git/src/rtl8192du/os_dep/ioctl_cfg80211.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Makefile:1373: recipe for target '_module_/build/rtl8192du-git/src/rtl8192du' failed
make[1]: *** [_module_/build/rtl8192du-git/src/rtl8192du] Error 2
make[1]: Leaving directory '/usr/lib/modules/3.17.6-1-ARCH/build'
Makefile:149: recipe for target 'modules' failed
make: *** [modules] Error 2
```


thanks for fix.but plase Change “ to "  line 313.


String.concat in a loop is a little sad and the isEmpty stuff is exactly why Joiner seemed like a better/clearer choice to me.


note to self: `labels_` -> `n_iter_`


Does this need to be here?


old stuff no longer in use


You're right. It took a while but I finally got my head round this on the train home. I'll revert this tomorrow morning.


We can't we just use a lexical scalar here?  `opendir my $dir, ...`


On 12.01.2015 21:16, Mario Mulansky wrote:
> sure the renaming is no problem.
> However what about adding another overload with the same parameter
> structure and an extra unnamed parameter like
>
> |do_step(... , dxdt_version)
> |
>
> This would not need to be disabled and could also be called explicitly
> from within the initialize function and would not break the naming
> conventions?

Ahh, but this not consistent among all the other do_step overloads. I
would prefer something with _impl, because it makes clear that it
something internal. But its up to you :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/headmyshoulder/odeint-v2/commit/4cadbe51640466f1d295f7a4c7d2375e063f0350#commitcomment-9248281>.
>


Hello!

Are you going to create Pull Request with these changes?


It should be.

stmt->setUInt8(index++, uint8(GetDungeonDifficultyID()));
stmt->setUInt8(index++, uint8(GetRaidDifficultyID()));
stmt->setUInt8(index++, uint8(GetLegacyRaidDifficultyID()))


Everything below here is moving aggregateWhatever functions into property accessors... the diff is just messy.


It looks like pTempFileTemplate can be declared as const


Automation editor doesn't work now. Shows only a blank window. Can you fix this?


Did somebody forget to add/commit/push the PSRealtimeCustomerInsights.java ?


Use:  Object.getPrototypeOf() instead of __proto__.
__proto__ does not work browsers that do not support ECMAScript 6.


Well, Node won't compile without it. Other than that we just have to be
good about checking past deps patches. And since V8 changes so quickly it's
likely it'll have to be rewritten anyway.


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3119
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3112
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3113
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3104
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3104
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3107
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3100
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3095
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2772
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2770
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1608
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1601


fast-forwarding master to auto = 3a44a19a


Relative path is OK in most time and you can run the script in cmd by ``ISCC mlpack.iss`` if you have inno setup in `PATH`.


Sorry, I missed the 2nd argument to calloc.


This kind of looks wrong; usage of actions is specifically meant to make the different usages of the same action look similar and behave the same. Having two actions that essentially do the same, act practically the same sounds therefor wrong.

Why not reuse the same action?


This is bad reasoning. We are not developing HHVM. When nobody will commit to the repository, nobody will find possible BC break. And when somebody will commit, he will not be interested in error in nightly HHVM.


This line becomes unneeded. Please remove it.


I just want to contact you for ordering not free support I want to order you about writing this setting

Sent from my iPod

> On Jan 12, 2015, at 15:25, patrickmeiring <notifications@github.com> wrote:
>
> Hi @kiamoz,
> Sorry, but extending the code to do what you need it to do is beyond the support I'm willing to give. If you needed help writing a function that does the image transformations like you describe, you'd be better-off asking a question like that on a forum like StackOverflow. Or searching for a library that already does this for you...
>
> —
> Reply to this email directly or view it on GitHub.
>


saw approval from alexcrichton
at https://github.com/oli-obk/rust/commit/b262ab5c4510fe251c50aebb6035b0b2c894830d


TeamCity CI Experiment :: Combine project PHP+Go [Build 7](http://localhost:8111/viewLog.html?buildId=35&buildTypeId=CiExperiment_PhpProject) is now running


merging oli-obk/rust/json_non_string_key_maps = b262ab5c into auto


status: {"merge_sha": "2eed297dfbf90343883b33ebbd2ffcf6fa3d1772"}


oli-obk/rust/json_non_string_key_maps = b262ab5c merged ok, testing candidate = 2eed297d


Actually, that's issue #4.


Implementation of kexec_hardboot based on https://github.com/WedyDQ10/AndroPlusKernel_leo/commit/ba4340a31174021bdc7ef0486f145d4f64e3da9e#diff-2437c39a4eb3a42ec5ad59ccda722f08R216


TeamCity CI Experiment :: Combine project PHP+Go [Build 7](http://localhost:8111/viewLog.html?buildId=35&buildTypeId=CiExperiment_PhpProject) outcome was **SUCCESS**
Summary: Tests passed: 3 Build time: 00:01:07


It works fine up until now. So I think we can leave it as is.


What's your concern (that was the general idea)? It's my Environment, can't I bind to it if I want to?


This should be set in interface builder, not in code. We should try to only set UI settings in one place.


I could force the delimiter to be non-empty and throw otherwise. Should I rewrite?


What does this do differently than line `117`?


Should return 400 (client error), not 500 (server error).


Alright, will fix in next version.


consider appendf


Can we add a generic handler to errorHandler.getErrMessage() and keep all the error message strings handled there?


thx


develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2177 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.4518044769301%25-yellow.svg)


Not possible as far as I can tell. QAction doesn't support returning a different icon per context, and users in #qt said there's no way to clone QAction objects.


dont talk about piracy


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9951/testReport/) for this commit**


Do you really think this comment is worth adding? Among other issues I see with it is that whether an asset is visible or not depends on the type of content (for example in web content it might depend on the publication). So it's weird to ask the user to make sure the assets are visible. I think that this behaviour is normal and what users expect, so the comment will confuse people


Indeed, I overlooked that.


Nice job!


Oh, I didn't read completely your comment. I understand now why the link was static.

Thanks.


:-1: I think that you don't want change it.


Should it be "A theme /may define..."?


This isn't used


I thought about it, and looked there, but that error handler isn't generic and it's dealing with mongoose related errors, and expects a related object (one that has an err.code etc). I think it's beyond the scope of this PR to refactor that error handler so I'll skip it.


I think login() might be a better name for the method, since `do` is kind of implied just by the fact it is a method.


Instead of "However" which has negative connotations, I would turn the sentence more possitive by saying "But not only that, " or "But what if you want an specific field to have a unique appearance? you can do that too..."


From ~4MB to ~330KB for ~2000 torrents, but we pay the price in CPU. For large datasets it'll still be done restoring from localStorage long before rtorrent responds by an order of magnitude, though. Good enough for now.


I don't experience this, what are your exact steps?


Typo fixed.


Visually i see the size change; but the actual pngs are the same size, now just with more blank pixels around them.

Qt is perfectly capably of centering the images so you don't need to ship transparant pixels in your image. Which would help with the file-size.
I just did that in Gimp and the add.png went from 15Kb to 594 bytes.


I'd assert the specific DirectConnect error code, too


@Lukas-W this happens:

Object::connect: No such slot AutomationPattern::openInAutomationEditor()


If you think it's confusing, I'm fine. I added it because several times I thought something was wrong, but finally it was just an asset with visible value set to false


I was a bit worried that it would cause the entire environment to be copied to the map, and also that it would only happen once so if the environment changed the relaxed binding might fail.


“Yes” to your first comment.

And you’re right – I’ll change SelectorPhase to use Selector.Literal.


Exact steps: compile latest master, start a new project, try to create a new automation pattern and open it in automation editor, results in blank window. See also above error message. Maybe you've renamed a slot and forgot to change a connect() call?


Are you using the context menu for opening the pattern or are you double clicking?


Yeah I removed the `openInAutomationEditor()` function, and seemed to miss the call in the context menu.


And why was that the case? How did you create the asset?

On Mon, Jan 12, 2015 at 10:35 PM, Jose Manuel Navarro <
notifications@github.com> wrote:

> If you think it's confusing, I'm fine. I added it because several times I
> thought something was wrong, but finally it was just an asset with visible
> value set to false
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/liferay/liferay-screens/commit/18a0e40a794748f8cd185e8ee787c4709c699323#commitcomment-9249496>
> .
>

--
Jorge Ferrer
Vice President, Engineering
@jorgeferrer <https://twitter.com/jorgeferrer>

Web <http://www.liferay.com> | Facebook <http://facebook.com/liferay> |
Twitter <http://twitter.com/liferay>

*Aviso de Confidencialidad: *Este mensaje de correo electrónico, incluidos
los archivos adjuntos, enviados en nombre de Liferay SL es para el uso
exclusivo del destinatario (s) previsto y puede contener información
confidencial y privilegiada. Se prohíbe cualquier revisión no autorizada,
uso, copia, divulgación o distribución. Si usted no es el destinatario, por
favor póngase en contacto con el remitente por correo electrónico de
respuesta y destruir todas las copias del mensaje original. Gracias.

*Confidentiality Notice: *This e-mail message, including any attachments,
sent on behalf of Liferay SL is for the sole use of the intended
recipient(s) and may contain confidential and privileged information. Any
unauthorized review, use, copying, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message. Thank
you.


Sure, let's allow @ngaskill to make the review


I am not clear on this conditional. Are you ensured that at some point nCharacter will be -1, thus ending the loop? Also what is 37 ?


does it need any of these, or is it just to stop Direct Connect from complaining about missing 'required' params? I think we should make a method to set every 'required' thing to `nil`, call it as the first thing in all these methods, and then set them explicitly. Probably a different one per Service URL - `add_required_values_as_nil_for_credit_card` or something less wordy if possible


Good Idea. Ill separate them into their respective blocks.


The comma should be removed. You can use a [json-validator](http://jsonformatter.curiousconcept.com/) to see if the file works out. Do it myself too. :)


:cat:


*sigh*.  Infinite recursion here.  Fixed in #6.


It's mandatory to define a cell view for each kind of field type, so I shouldn't say "custom cell view"


JavaScript sees no difference between single and double quotes (it has no "char" type, only "string"). So this is only my own taste backed by some coding experience. I prefer to use single quotes everywhere because they are easier to type, no Shift required. In a couple of cases the double quotes look nicer to me: 1) strings with escape sequences like "\n" because I got used to PHP where they are recognized only in double-quoted strings; 2) quoted object keys to mimic JSON.


We are developing code that should run on HHVM.


I think the point I was making is that looks wrong that you want the same action to have different color icons. That defeats the purpose of recognition and reuse.

I would consider it a bug that the systray icon doesn't have colors. Which OS are you on that you think thats a good idea?


As noted above, I believe pTempFileTemplate can be a static const string that takes up no more room than the string and NULL terminator. Then this can be a simple strcpy to a dynamic buffer


The Brands array is only really needed in the redis key, otherwise, you can use the API Key or specified brandID like we have been doing for all the other queries like so:

```
Join ApiKeyToBrand as akb on akb.brandID = bc.brandID
Join ApiKey as ak on akb.keyID = ak.id
where (ak.api_key = ? && (bc.brandID = ? OR 0=?))
```
This will make the sql statements cleaner, and more precise.


I think it depends on the use case. Using "should" indicates that some specific action needs to be taken (in this case, defining a custom cell view for each field type). Using "may" indicates that the action is optional.


I PROTEST


Don't mix these changes with the sound feature


@niksedk Can you provide the text you tested it with?!


Good point. It appears to be only used to discover keys, so in not sure the whole Map is needed in any case. I guess I did it to provide a cache of keys, but this isn't the best way to achieve that.


Creative formatting


saw approval from Ms2ger
at https://github.com/brunoabinader/servo/commit/9da761fc64a31b7a45fa21fad0fd43669366dcc2


merging brunoabinader/servo/getElementsByClassName-quirksMode = 9da761fc into auto


brunoabinader/servo/getElementsByClassName-quirksMode = 9da761fc merged ok, testing candidate = 151343cf


> When this succeeds it could be a segment anywhere in the availability window.

Fair point - I'll remove the HEAD stuff tomorrow.

However, I do feel that failing is the correct behaviour if the sync is invalid - one of the main reasons for moving to synchronised operation is to move away from the binary search or similar strategies.


On 01/12/2015 11:37 PM, Lukas W wrote:
>
> Yeah I removed the |openInAutomationEditor()| function, and seemed to
> miss the call in the context menu.
>

Cool, then it should be an easy fix. Can you whip up a commit so I can
get back to composing? ;)


I just pushed one new commit removing the "custom" word. In this case it's mandatory to add a cell view, the problem is I wrote "custom"


r+


this should be `typeof addon.isEnabled === 'function'`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9952/testReport/) for this commit**


more like initial vommit.


Adding line to contemplate both DatePickers that had the error (DateTimeInline and DateInline).


You probably don't wanna do that. The Scala.js Jasmine test framework is discontinued in 0.6.x.


Wrong. The $x is supposed to be interpolated into 'x' or 'X' so the format should be in double quotes.


Sorry, just for clarification: for what reason is it `npm link cordova-js` instead of `npm link`?


@ivandrofly: Can you run the unit tests from your visual studio?
The test that failed is called 'FixSingleLineDash1Font'


That makes sense, but we will have to fix this error for the generator, too. I think having a generic error handler ASAP will allow for good error logging, cleaner code, and better error output in the end.


Marking this commit as relating to https://github.com/iojs/iojs.github.io/issues/20


Already done ;) 30bc86e2e71bf84b2cae84a863053c108ba1bdb2


develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2063 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.24394700776611%25-yellow.svg)


Any idea, why you needed that? This folder should be automatically created by MSBuild during the build process itself :)


yes you are right, it's my mistake, thanks


No newline at end of file


https://issues.liferay.com/browse/LPS-50083
It's just fixed


seems QGL::SingleBuffer is not set on my machine (win x64 64bit, qt 5.4, mingw 4.9 32bit)
doubleBufffer() on the QGLWidget returns true
there WAS a mac os bug in qt 5 but it seems fixed: https://bugreports.qt.io/browse/QTBUG-28804
haven't found anything win related so far but to me it looks like a qt bug.
Workaround: Switch to double buffer format? Why did you choose SingleBuffer in the first place, doesn't that potentially cause flickering?


moot point, my main classes don't seem to work under scalajs because of their maths use :cry:


@kiamoz Sorry, I'm not interested. Best of luck with your endeavours.


I need them for readability, they show me that an expression follows. I use the outer parens when I return or assign a result of an expression, too. Moreover, this helps with automatic semicolon insertion when splitting the expression onto multiple lines. I also prefer to put them around the `? :` operator to ensure precedence in a nested `? :` and to emphasize there's an expression.


@fredericmora good catch


Hehe damn I fixed this on the feature/site I just forgot to cherry pick it. Now I wont have to :-)


del


sure, is there a way to generate the CV without using Jekyll? I'm having so many issues getting it installed properly on my system due to all the dependencies.


Close is still not using Dispose(bool) and will not let overrides dispose managed resources when the handle is closed. Ms.Net will call void virtual Dispose (bool)


Love you too, big guy ;)


Escribiste algo mal


Samo za informacijo: če želiš odgovoriti na komentar na vrstico, pod komentarjem klikni na _Add a line note_ - tako bo pogovor ostal na enem mestu. Če želiš komentirati spremenjeno vrstico, lahko klikneš na **+**, ki se ti pojavi, ko greš z miško čez. Tukaj spodaj pa so komentarji na celoten commit.


develop (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


En la línea marcada hay un error de coherencia.


Nope... still getting blank window. The title of the window is correct, indicating the correct pattern gets opened, but there's nothing in the window - no automation graph, just the blue-grey background.


Why not a UR class?


Hey @thehabes. It seems you copied the entire build file into the source folder.

What you need to do is edit the smaller files that were already in the `/src` folder and let the build process handle concatenating and zipping them. I'd be happy to walk you through the process today if you like.

Join us on the google hangout: https://plus.google.com/hangouts/_/event/c60h6chj2rc35v97925cjlhatn0?authuser=0&hl=en


basterd hinhin


I wrote these tests for stepping through the translate method.  They may be overkill/not too useful, also may create more maintenance when changing to netty DNS.   Have no problem having these backed out if you don't think they are useful.


Reviewing it.


Huh. Again, how are you opening the pattern exactly? This may have something to do with #1495.


Your right, the more closely I look at jclouds code I see AWS provider has its own property of securityGroupIds.


Should this be versioned?


IDFXT (Unknown) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.99618805590852%25-red.svg)


On 01/12/2015 11:55 PM, Lukas W wrote:
>
> Huh. Again, how are you opening the pattern exactly? This may have
> something to do with #1495 <https://github.com/LMMS/lmms/pull/1495>.
>

Happens both ways. From context menu and from double-click. Are you
unable to reproduce this?


I (also) meant that once the promise is fulfilled you should set _timer to null.


Jij en Rutger gaan vandaag echt **hard**!!! :open_mouth:

![](http://38.media.tumblr.com/1079064d86f08b9417a0a4999f2e4912/tumblr_mq0pdzkxGw1suydjqo1_400.gif)


Setting ref count to -1 is causing mutiples thread to die when calling DangerousRelease () while under Ms.Net, even if the object is invalid it will allow threads to release without throwing.


And GitHub uses 8 spaces per tab, I use 4 (sorry I won't switch to spaces instead of tabs for indentation). Actually I should chop at 80-90 characters to fit GitHub with my tab size.


Yes, that seems to be the pattern.  Good catch.  Does that help us create an algorithm that does the work for us?


Da se bo lepo prikazal naslov, pobriši presledek pred `#`.


Missing a call to GC.SuppressFinalize (this);


Uh... so if I used the violationSuppressXPath it would not work, because you have javaLangAsFQN set to skip in the pom, but I'm not sure why in dce33a02055d8722f02536601d2ba3ff4e481ff7 you added this format preference. I know this is old, but could you comment?


Yes I am. Could you try doing a clean build? (First try re-running `cmake` so you don't have to do the full 10-minute build if that does it)


Sedaj, ko smo v 3. fazi, tole odkomentiraj. Ne pozabi še narisati zemljevida v ustrezno datoteko PDF.


I cannot find one example of using Schema in conjunction with CSS.  How do I go about indicating styling elements for div's and span's that need to be named for styling elements in addition to schema?  Can you give me a few examples, please?


Thanks @kirkbushell for the reminder. I think we're on the same page when it comes to that kind of thing - we definitely should avoid putting Tectonic and/or client specific code or config in any of our public/OSS repos like the plague. In this case, I've put this Dockerfile and supporting config here for our testing purposes initially, but also for the purpose of building community and documentation around Shift 2, it's emerging good practice to provide a Dockerfile as a means for people to get up and running quicker. All of that said, if you feel that this is too specific to how we are using Shift 2, I'm happy to scrap the feature branch entirely and set up a different repo for Shift 2 Docker development.


Found a life-hack for GitHub: `You can append ?ts=2 or ?ts=4 to the URL to change the tab-size.`
http://stackoverflow.com/a/23522945/1346510
It works!


Oh,btw: this doesn't seem to happen in a new project. Only when I open an existing project or start a new one from a template.

I see AutomationEditor wasn't touched in #1495, maybe it needs the same fix as the other windows?


/* quest.cc - Command line search tool using Xapian::QueryParser.
    2  *
    3  * Copyright (C) 2004,2005,2006,2007,2008,2009,2010,2012,2013,2014 Olly Betts
    4  *
    5  * This program is free software; you can redistribute it and/or
    6  * modify it under the terms of the GNU General Public License as
    7  * published by the Free Software Foundation; either version 2 of the
    8  * License, or (at your option) any later version.
    9  *
   10  * This program is distributed in the hope that it will be useful,
   11  * but WITHOUT ANY WARRANTY; without even the implied warranty of
   12  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   13  * GNU General Public License for more details.
   14  *
   15  * You should have received a copy of the GNU General Public License
   16  * along with this program; if not, write to the Free Software
   17  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301
   18  * USA
   19  */
   20
   21 #include <config.h>
   22
   23 #include <xapian.h>
   24
   25 #include <cstdlib>
   26 #include <cstring>
   27
   28 #include <algorithm>
   29 #include <iostream>
   30
   31 #include "gnu_getopt.h"
   32
   33 using namespace std;
   34
   35 #define PROG_NAME "quest"
   36 #define PROG_DESC "Xapian command line search tool"
   37
   38 // Stopwords:
   39 static const char * sw[] = {
   40     "a", "about", "an", "and", "are", "as", "at",
   41     "be", "by",
   42     "en",
   43     "for", "from",
   44     "how",
   45     "i", "in", "is", "it",
   46     "of", "on", "or",
   47     "that", "the", "this", "to",
   48     "was", "what", "when", "where", "which", "who", "why", "will", "with"
   49 };
   50
   51 struct qp_flag { const char * s; unsigned f; };
   52 static qp_flag flag_tab[] = {
   53     { "auto_multiword_synonyms", Xapian::QueryParser::FLAG_AUTO_MULTIWORD_SYNONYMS },
   54     { "auto_synonyms", Xapian::QueryParser::FLAG_AUTO_SYNONYMS },
   55     { "boolean", Xapian::QueryParser::FLAG_BOOLEAN },
   56     { "boolean_any_case", Xapian::QueryParser::FLAG_BOOLEAN_ANY_CASE },
   57     { "default", Xapian::QueryParser::FLAG_DEFAULT },
   58     { "lovehate", Xapian::QueryParser::FLAG_LOVEHATE },
   59     { "partial", Xapian::QueryParser::FLAG_PARTIAL },
   60     { "phrase", Xapian::QueryParser::FLAG_PHRASE },
   61     { "pure_not", Xapian::QueryParser::FLAG_PURE_NOT },
   62     { "spelling_correction", Xapian::QueryParser::FLAG_SPELLING_CORRECTION },
   63     { "synonym", Xapian::QueryParser::FLAG_SYNONYM },
   64     { "wildcard", Xapian::QueryParser::FLAG_WILDCARD }
   65 };
   66 const int n_flag_tab = sizeof(flag_tab) / sizeof(flag_tab[0]);
   67
   68 inline bool operator<(const qp_flag & f1, const qp_flag & f2) {
   69     return strcmp(f1.s, f2.s) < 0;
   70 }
   71
   72 struct qp_op { const char * s; unsigned f; };
   73 static qp_op op_tab[] = {
   74     { "and", Xapian::Query::OP_AND },
   75     { "elite_set", Xapian::Query::OP_ELITE_SET },
   76     { "near", Xapian::Query::OP_NEAR },
   77     { "or", Xapian::Query::OP_OR },
   78     { "phrase", Xapian::Query::OP_PHRASE },
   79     { "synonym", Xapian::Query::OP_SYNONYM }
   80 };
   81 const int n_op_tab = sizeof(op_tab) / sizeof(op_tab[0]);
   82
   83 inline bool operator<(const qp_op & f1, const qp_op & f2) {
   84     return strcmp(f1.s, f2.s) < 0;
   85 }
   86
   87 enum {
   88     WEIGHT_BM25,
   89     WEIGHT_BOOL,
   90     WEIGHT_TRAD
   91 };
   92
   93 struct wt { const char * s; int f; };
   94 static wt wt_tab[] = {
   95     { "bm25",   WEIGHT_BM25 },
   96     { "bool",   WEIGHT_BOOL },
   97     { "trad",   WEIGHT_TRAD }
   98 };
   99 const int n_wt_tab = sizeof(wt_tab) / sizeof(wt_tab[0]);
  100
  101 inline bool operator<(const wt & f1, const wt & f2) {
  102     return strcmp(f1.s, f2.s) < 0;
  103 }
  104
  105 static void show_usage() {
  106     cout << "Usage: "PROG_NAME" [OPTIONS] 'QUERY'\n"
  107 "NB: QUERY should be quoted to protect it from the shell.\n\n"
  108 "Options:\n"
  109 "  -d, --db=DIRECTORY                database to search (multiple databases may\n"
  110 "                                    be specified)\n"
  111 "  -m, --msize=MSIZE                 maximum number of matches to return\n"
  112 "  -c, --check-at-least=HOWMANY      minimum number of matches to check\n"
  113 "  -s, --stemmer=LANG                set the stemming language, the default is\n"
  114 "                                    'english' (pass 'none' to disable stemming)\n"
  115 "  -p, --prefix=PFX:TERMPFX          add a prefix\n"
  116 "  -b, --boolean-prefix=PFX:TERMPFX  add a boolean prefix\n"
  117 "  -f, --flags=FLAG1[,FLAG2]...      specify QueryParser flags.  Valid flags:";
  118 #define INDENT \
  119 "                                    "
  120     int pos = 256;
  121     for (const qp_flag * i = flag_tab; i - flag_tab < n_flag_tab; ++i) {
  122         size_t len = strlen(i->s);
  123         if (pos < 256) cout << ',';
  124         if (pos + len >= 78) {
  125             cout << "\n"INDENT;
  126             pos = sizeof(INDENT) - 2;
  127         } else {
  128             cout << ' ';
  129         }
  130         cout << i->s;
  131         pos += len + 2;
  132     }
  133     cout << "\n"
  134 "  -o, --default-op=OP               specify QueryParser default operator\n"
  135 "                                    (default: or).  Valid operators:";
  136     pos = 256;
  137     for (const qp_op * i = op_tab; i - op_tab < n_op_tab; ++i) {
  138         size_t len = strlen(i->s);
  139         if (pos < 256) cout << ',';
  140         if (pos + len >= 78) {
  141             cout << "\n"INDENT;
  142             pos = sizeof(INDENT) - 2;
  143         } else {
  144             cout << ' ';
  145         }
  146         cout << i->s;
  147         pos += len + 2;
  148     }
  149     cout << "\n"
  150 "  -w, --weight=SCHEME               specify weighting scheme to use\n"
  151 "                                    (default: bm25).  Valid schemes:";
  152     pos = 256;
  153     for (const wt * i = wt_tab; i - wt_tab < n_wt_tab; ++i) {
  154         size_t len = strlen(i->s);
  155         if (pos < 256) cout << ',';
  156         if (pos + len >= 78) {
  157             cout << "\n"INDENT;
  158             pos = sizeof(INDENT) - 2;
  159         } else {
  160             cout << ' ';
  161         }
  162         cout << i->s;
  163         pos += len + 2;
  164     }
  165     cout << "\n"
  166 "  -h, --help                        display this help and exit\n"
  167 "  -v, --version                     output version information and exit\n";
  168 }
  169
  170 static unsigned
  171 decode_qp_flag(const char * s)
  172 {
  173     qp_flag f;
  174     f.s = s;
  175     const qp_flag * p = lower_bound(flag_tab, flag_tab + n_flag_tab, f);
  176     if (p == flag_tab + n_flag_tab || f < *p)
  177         return 0;
  178     return p->f;
  179 }
  180
  181 static int
  182 decode_qp_op(const char * s)
  183 {
  184     qp_op f;
  185     f.s = s;
  186     const qp_op * p = lower_bound(op_tab, op_tab + n_op_tab, f);
  187     if (p == op_tab + n_op_tab || f < *p)
  188         return -1;
  189     return p->f;
  190 }
  191
  192 static int
  193 decode_wt(const char * s)
  194 {
  195     wt f;
  196     f.s = s;
  197     const wt * p = lower_bound(wt_tab, wt_tab + n_wt_tab, f);
  198     if (p == wt_tab + n_wt_tab || f < *p)
  199         return -1;
  200     return p->f;
  201 }
  202
  203 int
  204 main(int argc, char **argv)
  205 try {
  206     const char * opts = "d:m:c:s:p:b:f:o:w:hv";
  207     static const struct option long_opts[] = {
  208         { "db",         required_argument, 0, 'd' },
  209         { "msize",      required_argument, 0, 'm' },
  210         { "check-at-least",     required_argument, 0, 'c' },
  211         { "stemmer",    required_argument, 0, 's' },
  212         { "prefix",     required_argument, 0, 'p' },
  213         { "boolean-prefix",     required_argument, 0, 'b' },
  214         { "flags",      required_argument, 0, 'f' },
  215         { "default-op", required_argument, 0, 'o' },
  216         { "weight",     required_argument, 0, 'w' },
  217         { "help",       no_argument, 0, 'h' },
  218         { "version",    no_argument, 0, 'v' },
  219         { NULL,         0, 0, 0}
  220     };
  221
  222     Xapian::SimpleStopper mystopper(sw, sw + sizeof(sw) / sizeof(sw[0]));
  223     Xapian::Stem stemmer("english");
  224     Xapian::doccount msize = 10;
  225     Xapian::doccount check_at_least = 0;
  226
  227     bool have_database = false;
  228
  229     Xapian::Database db;
  230     Xapian::QueryParser parser;
  231     unsigned flags = parser.FLAG_DEFAULT|parser.FLAG_SPELLING_CORRECTION;
  232     int weight = -1;
  233
  234     int c;
  235     while ((c = gnu_getopt_long(argc, argv, opts, long_opts, 0)) != -1) {
  236         switch (c) {
  237             case 'm': {
  238                 char * p;
  239                 unsigned long v = strtoul(optarg, &p, 10);
  240                 msize = static_cast<Xapian::doccount>(v);
  241                 if (*p || v != msize) {
  242                     cerr << PROG_NAME": Bad value '" << optarg
  243                          << "' passed for msize" << endl;
  244                     exit(1);
  245                 }
  246                 break;
  247             }
  248             case 'c': {
  249                 char * p;
  250                 unsigned long v = strtoul(optarg, &p, 10);
  251                 check_at_least = static_cast<Xapian::doccount>(v);
  252                 if (*p || v != check_at_least) {
  253                     cerr << PROG_NAME": Bad value '" << optarg
  254                          << "' passed for check_at_least " << endl;
  255                     exit(1);
  256                 }
  257                 break;
  258             }
  259             case 'd':
  260                 db.add_database(Xapian::Database(optarg));
  261                 have_database = true;
  262                 break;
  263             case 's':
  264                 try {
  265                     stemmer = Xapian::Stem(optarg);
  266                 } catch (const Xapian::InvalidArgumentError &) {
  267                     cerr << "Unknown stemming language '" << optarg << "'.\n"
  268                             "Available language names are: "
  269                          << Xapian::Stem::get_available_languages() << endl;
  270                     exit(1);
  271                 }
  272                 break;
  273             case 'b': case 'p': {
  274                 const char * colon = strchr(optarg, ':');
  275                 if (colon == NULL) {
  276                     cerr << argv[0] << ": need ':' when setting prefix" << endl;
  277                     exit(1);
  278                 }
  279                 string prefix(optarg, colon - optarg);
  280                 string termprefix(colon + 1);
  281                 if (c == 'b') {
  282                     parser.add_boolean_prefix(prefix, termprefix);
  283                 } else {
  284                     parser.add_prefix(prefix, termprefix);
  285                 }
  286                 break;
  287             }
  288             case 'f':
  289                 flags = 0;
  290                 do {
  291                     char * comma = strchr(optarg, ',');
  292                     if (comma)
  293                         *comma++ = '\0';
  294                     unsigned flag = decode_qp_flag(optarg);
  295                     if (flag == 0) {
  296                         cerr << "Unknown flag '" << optarg << "'" << endl;
  297                         exit(1);
  298                     }
  299                     flags |= flag;
  300                     optarg = comma;
  301                 } while (optarg);
  302                 break;
  303             case 'o': {
  304                 int op = decode_qp_op(optarg);
  305                 if (op < 0) {
  306                     cerr << "Unknown op '" << optarg << "'" << endl;
  307                     exit(1);
  308                 }
  309                 parser.set_default_op(static_cast<Xapian::Query::op>(op));
  310                 break;
  311             }
  312             case 'w': {
  313                 weight = decode_wt(optarg);
  314                 if (weight < 0) {
  315                     cerr << "Unknown weighting scheme '" << optarg << "'" << endl;
  316                     exit(1);
  317                 }
  318                 break;
  319             }
  320             case 'v':
  321                 cout << PROG_NAME" - "PACKAGE_STRING << endl;
  322                 exit(0);
  323             case 'h':
  324                 cout << PROG_NAME" - "PROG_DESC"\n\n";
  325                 show_usage();
  326                 exit(0);
  327             case ':': // missing parameter
  328             case '?': // unknown option
  329                 show_usage();
  330                 exit(1);
  331         }
  332     }
  333
  334     if (argc - optind != 1) {
  335         show_usage();
  336         exit(1);
  337     }
  338
  339     parser.set_database(db);
  340     parser.set_stemmer(stemmer);
  341     parser.set_stemming_strategy(Xapian::QueryParser::STEM_SOME);
  342     parser.set_stopper(&mystopper);
  343
  344     Xapian::Query query = parser.parse_query(argv[optind], flags);
  345     const string & correction = parser.get_corrected_query_string();
  346     if (!correction.empty())
  347         cout << "Did you mean: " << correction << "\n\n";
  348
  349     cout << "Parsed Query: " << query.get_description() << endl;
  350
  351     if (!have_database) {
  352         cout << "No database specified so not running the query." << endl;
  353         exit(0);
  354     }
  355
  356     Xapian::Enquire enquire(db);
  357     enquire.set_query(query);
  358
  359     switch (weight) {
  360         case WEIGHT_BOOL:
  361             enquire.set_weighting_scheme(Xapian::BoolWeight());
  362             break;
  363         case WEIGHT_BM25:
  364             enquire.set_weighting_scheme(Xapian::BM25Weight());
  365             break;
  366         case WEIGHT_TRAD:
  367             enquire.set_weighting_scheme(Xapian::TradWeight());
  368             break;
  369     }
  370
  371     Xapian::MSet mset = enquire.get_mset(0, msize, check_at_least);
  372
  373     cout << "MSet:" << endl;
  374     for (Xapian::MSetIterator i = mset.begin(); i != mset.end(); i++) {
  375         Xapian::Document doc = i.get_document();
  376         string data = doc.get_data();
  377         cout << *i << " [" << i.get_percent() << "%]\n" << data << "\n";
  378     }
  379     cout << flush;
  380 } catch (const Xapian::QueryParserError & e) {
  381     cout << "Couldn't parse query: " << e.get_msg() << endl;
  382     exit(1);
  383 } catch (const Xapian::Error & err) {
  384     cout << err.get_description() << endl;
  385     exit(1);
  386 }


like


If you still can't reproduce, try different project files, it may have to do with whether the window is open/closed in the project file...


Hi @dumolibr

I believe ENTRYPOINT is still the best option to use as it is used for initializing and bootstrapping the new container.  At this point no arguments are needed.  It can be looked into after if such a use case arises.  Thanks,

Jordan


should this be:

```
redirect_to post_path(@post)
```

???


Agreed this is *now* correct.


[test]


should this be:

```
redirect_to posts_path
```

???


@skj3gg no problem. looks like it's fixed, thanks!


Yeah I'd rather not - it makes the assumption that users are using docker (even if they don't actually use the file). Not a big fan of that approach.

That said, I don't mind if this is just for testing purposes but let's just flag it to be removed for when the AF4 package/repo is ready.


@cgaebel This is (a rebased version of) the branch which I used to test different calling conventions. I believe that this commit might be ready for review. The other ones can be interesting, but I guess they might need some discussion before even being considered for review.


Dont try to cash the GC thread........


I think that ```--disable-web-security``` is required until the app is hosted by a server. (the change that I am working on)
I also expect that removing ```--user-data-dir``` will generate some comments.

At least for chrome on each platform - I think that these args should continue to be provided in this change.


or a bit shorter (does not require the length check) and slighly easier to grasp:
```ruby
container_name.reverse[0..63].reverse
```


Indeed, don't know why I placed it inside the loop at all. Will fix it.


Python3 tests started failing on dict size changing during iteration. Isn't that the point of ``.keys()``?


Python3 tests failed here as well with dict size changing during iteration.


Hi @dumolibr

Can you let me know why you switched from Debian to Ubuntu?  I originally started with Ubuntu but found that it was not adding any value over a base Debian install.  Using a base Debian image also kept my image down.  Thanks,

Jordan


Dont assert a fail here. It should not. Returning an ObjectDisposedException by Close is wrong...


This method should not use user parameter from save callback as a response body because it contains hashed password string. Also this respects all other select options and is better than
`delete user.hashedPassword`


TTI is disbanded, Toontown Next is the new game


No need to set any special headers - we can delete this middleware.


Dont assert a fail here. It should not. Returning an ObjectDisposedException by Dispose is wrong...


It turns out subprocess.check_output was introduced in python 2.7 and doesn't exist in previous versions, creating a problem for systems running python 2.6.*. For now, I'll rewrite the script to handle exceptions thrown by Popen. Let me know if you suggest a more appropriate work around.
I can't seem to find  a reason for it, but if shell=False when invoking Popen, the script crashes.


i got notified.

On Mon, Jan 12, 2015 at 2:55 PM, Sean <notifications@github.com> wrote:

> Hi Brendan! This is mostly a test comment to see what happens when I try
> to comment on a particular line of a commit. Let me know if/how you get
> notified about it. (And if anyone else gets notified, y'all should let me
> know too). But in other news, this is great. And you even figured out the
> somewhat bizarre ruby-ese of methods that have a ? in them.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BlakeCS-Spring2015/blakecs-spring2015.github.io/commit/024ed54d733b71885d54fde4e885f193a477a775#commitcomment-9248859>
> .
>


@kenmazaika oops, I deleted your other comment by accident, but I have those commented out, they're just for updating and deleting which I haven't worried much about yet. I'm trying to get the new posts auto linked to user_id right now


os.path.join(ressourcePath,ressourceID) to be multiplatform


So are you saying we should throw an IllegalArgumentException here..?


remove this return


The TODO at the end of line 850/852 needs to be removed.


Good catch, thanks!


I see you still set the filename in the pipeline  at the moment of play the sound. Please change the code to set the filename in a separated method select_sound() when the user change the tool. The reason to do it separatedly is performance in slow devices.
Now we have more properties to define the sound behavior. I would prefer use a single property self._tool_sound (dictionary) with properties: 'filename', 'loop', 'full_play' 'play_after_click' (I assume full_play means the sound should not be stopped, is that?). This dictionary will have the values of SOUNDS for the selected tool.
Probably PLAYAFTERCLICK could be moved to the SOUNDS structure too. I don't have clear the meaning of PLAYAFTERCLICK, because if I don't understand wrong, means play when the tool finish. In some tools is after click, but in other, like in the shapes is after the user release the mouse. Maybe we can find a better name.


You should generate a random password. As is, all new users will have the same identical password. Even when the password is not really necessary because we log in through oAuth


A resource was identify with it's uniqueId, and the request require to get the uniqueId of the file.
It was to prevent the fact to get file with special caracters.


Can we also install sbt and scala?


Was there some reason for this ? aml hw only accepts 3 or 4 byte NALs and you better be less HDR_BUF_SIZE as pkt->hdr->data is only as large as that.


To do that would cost execution cycles, strlen() of constant strings is done at compile time. It doesn't need to be precise.


Why should `addKnown`return a pointer? It can get away with returning nothing, or maybe `bool` for success/failure. Also, please prefer having the return type on a line by itself.


Let's be consistent regarding res.json or res.send. Considering that we always send valid json I prefer to use send because its name tells me what operation it performs.


Got it. So you run into a bug and that's what confused you. That reinforces
my idea that the comment won't be helpful (since the bug is now fixed) but
might be confusing.

On Mon, Jan 12, 2015 at 10:47 PM, Jose Manuel Navarro <
notifications@github.com> wrote:

> https://issues.liferay.com/browse/LPS-50083
> It's just fixed
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/liferay/liferay-screens/commit/18a0e40a794748f8cd185e8ee787c4709c699323#commitcomment-9249686>
> .
>

--
Jorge Ferrer
Vice President, Engineering
@jorgeferrer <https://twitter.com/jorgeferrer>

Web <http://www.liferay.com> | Facebook <http://facebook.com/liferay> |
Twitter <http://twitter.com/liferay>

*Aviso de Confidencialidad: *Este mensaje de correo electrónico, incluidos
los archivos adjuntos, enviados en nombre de Liferay SL es para el uso
exclusivo del destinatario (s) previsto y puede contener información
confidencial y privilegiada. Se prohíbe cualquier revisión no autorizada,
uso, copia, divulgación o distribución. Si usted no es el destinatario, por
favor póngase en contacto con el remitente por correo electrónico de
respuesta y destruir todas las copias del mensaje original. Gracias.

*Confidentiality Notice: *This e-mail message, including any attachments,
sent on behalf of Liferay SL is for the sole use of the intended
recipient(s) and may contain confidential and privileged information. Any
unauthorized review, use, copying, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message. Thank
you.


is that right?


```-n``` is no longer passed to open?
```-n  Open a new instance of the application(s) even if one is already running.```
I think it should still be used.


wouldn't the ui.port and cores.max props have been set already from the sparkConfigs when it was iterated above? (maybe we should set the default values for the SparkConf directly before doing that iteration, so they would be overridden if provided explicitly)


I would make Configuration singular or maybe just make this getSparkProperties or even getSparkConfigProperties


hi, I tried to modernize the example above (not sure if I have done it correctly):
```
Router.onAfterAction(function() {
    var self = this;
    // always start by resetting scroll to top of the page
    $(window).scrollTop(0);
    // if there is a hash in the URL, handle it
    if (this.params.hash) {
        // now this is important : Deps.afterFlush ensures that iron-router rendering
        // process has finished inserting the current route template into DOM so we
        // can manipulate it via jQuery, if you skip this part the HTML element you
        // want to scroll to might not yet be present in the DOM (this is probably
        // why your code fails in the first place)
        Tracker.afterFlush(function() {
            var scrollTop = $("#" + self.params.hash).offset().top;
            console.log("scrollTop",scrollTop);
            $("html,body").animate({
                scrollTop: scrollTop
            });
        });
    }
});
```
I am seeing the follow exception:
```
TypeError: Cannot read property 'top' of undefined
    at http://localhost:3000/lib/router.js?7ae64839a62ddbe3a6cbe152dbabcf2e7aed2fa9:483:63
    at Tracker.flush (http://localhost:3000/packages/tracker.js?7f0c5481709a504dd2254ba2a71c1cee78adc280:448:11)
```
Any hints? :-)


does this work? or did you mean
```
static NSMutableDictionary *_kindModelMap = nil;
```


if i remove QGL::SampleBuffers, it is accepting QGL::SingleBuffer ...


I think even if it works we might as well put `nil`. Probably not worth the confusion / second guessing for people who may not have seen it before.


using perror() here doesn't seem to be right.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/519
success: http://build.servo.org/builders/linux2/builds/517
success: http://build.servo.org/builders/android/builds/555
success: http://build.servo.org/builders/mac1/builds/736
success: http://build.servo.org/builders/mac2/builds/736


ah, thanks, got sloppy and put that in the main demo... I have ES6 syntax turned on for my Chrome console, but it's not on by default :)


Prefix("watch").  You can't specify watch twice.


Resource("buildConfigs").Name(name)


Think this is > 80 chars. Also line 138 indentation looks off.

(Don't want to uphold your PR, but noticed while reading :))


Hm. I think I should check it. Can you provide a build?


Ember is sending data in json format only so we don't need  the urlencoded middleware from body-parser.


While you're here can you please remove the need for `boost::str` and `boost::format`?


Here's an interesting piece of reading about prim number [http://rjlipton.wordpress.com/2015/01/08/there-are-many-primes/].


also an aggregator


https://www.youtube.com/watch?v=tFelfYq3zpQ :P


Also I think in this case they should be the same: a 500 with a customized error message will still return that message to user.


fast-forwarding master to auto = 151343cf


Ops, it's not. Some paths are not absolute, like on line 190. But CMake resolves them. But in that case, it's added as a definition for #ifdefs on code. I'll fix it.


if we're still supporting 5.6.0 and 5.6.1, is this safe?


Not sure if friend is needed here.


Is the full class path intended here?


@luis-pereira
Luis I´m sorry if I offended you in any way. It wasn´t my intention. Please accept my sincere apologies.


Why do you need the multer middleware? Are we dealing with multipart/form-data?


@Lukas-W are you working on this or should I look into it?


What's the story with the double underscore here? I don't see it being used anywhere later in the file...


saw approval from Ms2ger
at https://github.com/mbrubeck/servo/commit/97a8b617fbb95cb835d7dd429cd71ff60579a492


merging mbrubeck/servo/dead-top-margin = 97a8b617 into auto


mbrubeck/servo/dead-top-margin = 97a8b617 merged ok, testing candidate = b8923926


Tabbing here could be fixed to be more consistent with the rest of this file.


TESTS PASSED
 Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=4b63d04712f54aff8b9135d6151641ac
 plone-5.0-python-2.7 [SUCCESS]


Thanks


If you don't want to repeat the var keyword you can choose this pattern of defining multiple variables.

https://github.com/tj/commander.js/blob/master/index.js#L344


Did you intentionally not make a constructor or was that a mistake? Also, I can't seem to find where you set the value for test_name or test_description


@cmather should I move this to a proper "issue"?


I'm working on it and I think I got it.


Looks great! Checking out the change on the rpc->http change now


there were a bad behavior that inserted the date for  published_at  to drafts that weren't empty.


There is a second use of `cacheWriterDeleteAllCall` that might need some tweaking to operate correctly (line 666/670).  Flow following that call depends on `failure` holding failed items and the use of `unknowns` in `cacheWriterDeleteAllCall` changes the semantics of the response somewhat.


this line needs to stay (see travis failure)... the client version might be (also during renegotiation) higher than the one supported by the server, thus we need to find the upper bound of client and server (by agreed_version)


Please test if a94ccb851592e12f3f8f9cc355159388bb5e3c0b fixes this for you.


Why did you change json to jsonp?

http://json-jsonp-tutorial.craic.com/index.html


:+1: love it that you haven't forgot about supporting Windows.


Will do


@eguneys Try to build a repro, I don't think this is this code. Also https://github.com/dblock/grape-with-roar/blob/master/api/presenters/spline_presenter.rb uses this version just file and gets env.


Commit para crear rama gh-pages


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9955/testReport/) for this commit**


@jeremyschlatter addressed code review comments


I think we've discussed this. I'd like us to resolve how Watir.always_locate should work first, before rolling out this change.


you mean me? sure: http://83.133.105.176/qtox_custom.zip


Wrong comment.  I think this is right - given that we're validating input, more information seems more useful.


Will do.


Thanks @capaj  :)


Don't forget strings 3 and 4 in common.mk ;)


I know this is a minor style point, not a deal breaker, but would it be possible to add a space after the comment hash on line 93 and 100?


I took the idea from @asdofindia :smile:


On 01/13/2015 12:22 AM, Lukas W wrote:
>
> Please test if a94ccb8
> <https://github.com/LMMS/lmms/commit/a94ccb851592e12f3f8f9cc355159388bb5e3c0b>
> fixes this for you.
>
>

Yep, works now. Thanks :)


Agreed. I'm running some performance tests with the BST now to see what they look like.


check_get_cacheで判定してます
この関数はadminかfriendのとき(あとロボットでないとき)にTrueを返すので、
これがFalse(権限がない)のときはレス数が0のスレを出力しないようにしています
210行目あたりです


Derp.  That would explain the inexplicable crashes. :)


r+ rollup.


I believe it is needed because the override of << is not treated as an instance method. So there's no way to reference private members without it.


おっと失礼しました。


Not very beautiful. It did not fit into the free space next to Location though.


This broke brush preset saving and/or loading, and therefore brushes reset everytime you swap.


Yes I've tried to set the lefthand indent/inset to 0 every way that I can in interface builder: https://www.dropbox.com/s/y3pzfdss58d1ypg/Screenshot%202015-01-12%2014.25.37.png?dl=0.

When the tableView loads initially, the inset is 0: https://www.dropbox.com/s/u21fby2spzh7ape/Screenshot%202015-01-12%2014.27.32.png?dl=0
...but then reverts to 10-15 pixels to the left anyways: https://www.dropbox.com/s/a9e4az8cezvq8x2/Screenshot%202015-01-12%2014.27.57.png?dl=0

Thus, I've tried to get it to work here programmatically, per the documentation: https://developer.apple.com/library/ios/documentation/UIKit/Reference/UITableViewCell_Class/#//apple_ref/occ/instp/UITableViewCell/separatorInset


I intentionally made it so that the default constructor just does default things. Then I Created an init method that inheriting classes need to override to set those things. Not sure if that's the best way to do it, but I wanted to keep all the actual test code as clean as possible. So in test_main.cpp, all we see is the creating of an instance of the test, and we don't need to do anything else.

refer to test_dfa_impl.h to see the init override, and then test_main.cpp to see what I mean


Yes we did.  Sorry about that.  We just published 1.5.3 that includes that file.


This has a lot of duplication.  You should at least make only one null object.


@bcamper

I think this is a little closer to what we talked about on Friday. However, its broken. Maybe you could give me a hand  tomorrow?

Thanks


> I'm not sure it is best way though.

As far as I know it should be even simpler than that: https://github.com/Underground78/mpc-hc/commit/7225df9aca581a91d956f6e9d3cca1b93a1855ba. Note that this isn't well tested, I just quickly tried to see if it behaved as I expected.


The problem is in this method: RemoveSpacesBeginLine ;).


@mikedotcpp @palange This is simple logging to check when the search path changes and whether, when file loading fails, the file actually exists or not. Can you do a quick review of this to let me know if it looks OK?


Someone should remove the "final" modifiers on the method variables.
May cause problems in the future, because the variable will never change since it has a "final" modifier. Hence why the modifier is called "final".


Don't use tabs for alignment, they only work if everyone's using the same tab width.  Use spaces or don't align at all.


Feel free to send a PR :P I'm too lazy to right now.


this code change breaks the `description` property on the JSON schema across the board


いえいえー


Hi dave,

I found this method through the docs link you sent me:

On Sun, Jan 11, 2015 at 5:51 PM, Dave Foley <notifications@github.com>
wrote:

> Here x is an array of values
> http://ruby-doc.org/stdlib-1.9.2/libdoc/csv/rdoc/CSV.html#method-c-parse
>
> #create wants a hash-like object.
>
> So you need to do something to convert from array to something like ruby
> {
> id: <whatever>,
> otherField: <whatever>,
> ...
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/piinthecloud/mapmaker/commit/f13a6cc57a0e1c01f61d555fffd8b43fb90ef97f#commitcomment-9235680>
> .
>

--
Best,

Stephanie Pi


Why it commented?


@relaw Przerobiłem trochę formularze. Jutro może zrobię mailera i spróbuję ogarnąć nawigację.


Hi dave,

I found this method through the docs link you sent me:

CSV.foreach("public/shooting_data.csv", :headers => true,  encoding:
'ISO8859-1').each do |shooting|

     Policeshootings.create( shooting.to_h )

end

It looks like foreach returns a csv row object that you can just call .to_h
on to create the new db row.

I also had an issue with the csv encoding, so thats the last argument on
the foreach method.

Thanks for the leads!!

On Sun, Jan 11, 2015 at 5:56 PM, Dave Foley <notifications@github.com>
wrote:

> This logic could go in one of at least three places:
>
>    1. in a method on Policeshootings
>    2. in a function in seeds.rb
>    3. in its own class
>
> I would lean toward #2 for now, then move to its own class later if needed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/piinthecloud/mapmaker/commit/f13a6cc57a0e1c01f61d555fffd8b43fb90ef97f#commitcomment-9235721>
> .
>

--
Best,

Stephanie Pi


test test


I'm assuming that you've tracked it down to the call of doGetFileData() returning null. Might want to add a little logging in line 128 of file CCFileUtilsAndroid.cpp as a precaution. I'm sure it's probably not the case, but logging wouldn't hurt and it would catch all return code paths from this method.


Hey @jonsterling, can you look this over? I need a patch release pushed to hackage with at least the intent of these changes so I can push a new `vinyl-gl`.

A couple notes:

* The tuple kinds are a bit awkward as you need to prime the list and tuple syntax, so you have to put a space in. For example, `'[ '("Foo", Foo) ]`. This isn't a deal breaker, but just to note a drawback to using the tuple kind for these purposes.

* The length-1 `Rec` creation operator `(=:)` is used at a custom type in the tutorial, so I took `(=::)` for `ElField`. This seems a bit of tail wagging the dog to me, but I know you're not really a fan of `ElField`, so perhaps it is consistent with your aims. I don't feel too strongly, so it's your call.

* I made the `Field` constructor strict in its argument.


:clap:


I also removed the "contact" page in this commit


added HelloWorld.md


Paul is the Walrus?


That wasn't my decision, and I haven't thought of a reasonable alternative.


I think downloading a tar would be better here.


Ben or Bret really helped me get a shell of this going.  I had trouble starting from scratch.


Misc rambling


T'es fou! Le PAQ stipulait une rétention des documents pour 10ans.

:-D

Comment vous allez les grandes canailles?!

Etienne.

On Mon Jan 12 2015 at 12:57:54 PM YoannBuch <notifications@github.com>
wrote:

> Pas si vite. Je comptais monter ma boite de consulting SAP dans le milieu
> du BTP. Je te fais signe une fois le depot clone.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/h4314/GSTP/commit/a76d66621682ea1b7cfaafd300eaa7f1805e2f20#commitcomment-9239885>
> .
>


Fixed in 64b7048bc06eb17fae3f331bc7298ede9177be5a.


In my testing Opera had trouble with the '-n' switch. It would not launch the URL correctly. I ended up removing it.


confirmed that the sr_t (encoded snaprealm struct) doesn't enumerate children.  this will lead to lots of in-memory SnapRealms but I don't think that will cause problems.


85606174-ImproveIGValidation (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2071 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.6094106898127%25-yellow.svg)


Using `(slice-views m 1)` to get columns from a `SparseRowMatrix` is inefficient. It ends up calling getColumn for each column which requires scanning all the row `Index` instances. I added a more efficient `getColumns` method to the `SparseRowMatrix` to avoid this, but apparently I shouldn't be using it when modifying a matrix.

Should we add a `get-slice-view-seq` method to `PSliceViewSeq` in core.matrix which takes a dimension argument? Then we could have a corresponding method in Vectorz to allow classes to optimize for this case based on the slice dimension.

Related to this, there's a class in matrix-toolkits-java ([LinkedSparseMatrix](https://github.com/fommil/matrix-toolkits-java/blob/master/src/main/java/no/uib/cipr/matrix/sparse/LinkedSparseMatrix.java)) which I'm considering porting to Vectorz in case the tradeoff between increased overhead for faster transpose is worth it in some scenarios.


References to drolbr/Overpass-API#178
Remaining question in map_ql_parser.cc, see TODOs.


[Try to add closure to Presenter's view() method](http://fuelphp.com/docs/general/presenters.html#/functions):

```php
$this->echo_upper = function($string) {
	echo strtoupper($string);
};
```

and you will get this exception:

```
Fuel\Core\PhpErrorException [ Warning ]:
Missing argument 1 for Presenter_Welcome_Hello::{closure}(), called in fuel\core\classes\view.php on line 277 and defined
```


1. I am fine with this PR
2. feel free to make any changes to the tutorial that you need in order to get your desired syntax
3. Perhaps a different kind than the tuple could be used to avoid syntactic weirdness? I don't have much of an opinion on it either way since this corner of vinyl doesn't come up in my use cases, so feel free to do whatever you want :)


Why use e.getCause() here and e above


Thanks @johnclause for taking time to push this!


WOW! Good to know :)


They could have brought the whole project tumbling down


`giturl` not `git url`


Oh, just realized this is not a PR. That's fine too :)

Let me know when you are ready for me to cut a new version.


Sure, but that will prevent the version of SX built from being able to execute C++ calls against Obelisk. It does simplify the build but I just wanted to make sure we understand the impact in terms of down-level maintenance. I haven't reviewed the book for the existence of such examples.


LGTM


One thing I'd like to keep on a single line is the `@param` docs if you don't mind. I'm not yet sure that JsDoc supports multi-line parameter descriptions but I'm too lazy to check this right now.


Good point. We definitely saw the old log statement appear, but adding a little more won't hurt.


84202472-TurnOffInputEchoByDefault (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.90012642225032%25-red.svg)


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3120
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3114
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3105
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3105
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3108
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3101
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3096
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2773
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2771
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1609
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1602


Just checked, we [don't already use the class](https://github.com/search?q=user%3Anib-styles+uppercase&type=Code&utf8=%E2%9C%93) and the [`u-` prefix only is used for "spacing classes"](https://github.com/search?q=user%3Anib-styles+u-&ref=searchresults&type=Code&utf8=%E2%9C%93) (whatever they are). We do have `text-uppercase` and `title--caps` in the old `common` and `typography` components (which I don't have in new projects).

So it should work fine in legacy projects without the `v2` prefix cause we don't have a v1 but I'm happy to add them for consistency if you guys think its a good idea?

ping @michaeltroy


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/518


you missed the github account


I already explained it in the first mail I sent you. Anyway I documented it in the ticket: https://issues.jenkins-ci.org/browse/JENKINS-26175

Appart from that the patch also fixes following tickets:
https://issues.jenkins-ci.org/browse/JENKINS-26351 (Spanish translation, not a fix per se)
https://issues.jenkins-ci.org/browse/JENKINS-24854 (If job is aborted in pre-build phase Jenkins does not leave shutdown mode)


Oki :)
Próbowałem zrobic datepickera ale to jakaś masakra z tym simple formem...

VL

W dniu poniedziałek, 12 stycznia 2015 MrMybach <notifications@github.com>
napisał(a):

> @relaw <https://github.com/relaw> Przerobiłem trochę formularze. Jutro
> może zrobię mailera i spróbuję ogarnąć nawigację.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MrMybach/rent_a_car/commit/99bf900c1ec50eab1ea8a94d989f382c3e8eb9f4#commitcomment-9250414>
> .
>

--
Pozdrawiam,
Valeriy Litvinov


DivideByZeroProtection (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (332 of 332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Not really, I gave up on this repo a while ago but left it on GitHub in case anyone was looking for it.


Side-effect: a player with this permission can be shown with `/spec hide` (because it acts as a toggle) for a session (expires when the player leaves).


85606174-ImproveIGValidation (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


args is already defined here. it's better to declare args in first line and reference it later.


Can you give this class a different name since we already have a QueueControl (i.e. org.apache.activemq.api.core.management.QueueControl)?


Thanks @sidthekidder! This looks great. We don't need the log of the error at the moment, so this is fine. Also, yes please replace line 247 with an `unresolved()`call :)


I've amended the commit. Quite a bit of red, but the client seems to run fine.


Ok I have added the entire build folder to be ignored in commits and am now just actively editing files under the src/ directory.  Building now handles them.


browser is already defined


oh sweet - that totally makes sense.


hmm, i think this means that a bunch of stuff in Locker.cc would/should change.  right now if you have an open file that is cowed we set the lock state on the cloned inode so that we will gather the cap value before it is readable.  we use a multiversion inode there is still a single lock that governs the inode, which means that stating a snap on the inode requires that the head inode get locked, right?  that sort of sucks.  or, we need a structure that indicates which of the old_inodes has been flushed (or needs recovery), and getattr needs to use that to tell when to block.. that is probably the best client behavior, but I think it means a bunch of new code to track that?  Having an explicit field to indicate which snaps need size/mtime recovery seems good, though.

It seems like a big change, though.  Are you sure this is the direction we should go?  What is the alternative?  Adding a snapid_t created in addition to first and last?


you MUST create accounts at all of those websites if you don't already have one


Sure

> On Jan 12, 2015, at 2:20 PM, adamgins <notifications@github.com> wrote:
>
> @cmather should I move this to a proper "issue"?
>
> —
> Reply to this email directly or view it on GitHub.
>


the interaction of file recovery with the multiversion inode makes me nervous...


I personally do not use WSTC. I use Szimat Szatyor, which is open source, and I manually add the new hooks for each new client. It often pays to control what appears in the console if you know what I mean. I do use TrinityCore's packet parser for interpreting the data, though. Again, a modified version (thanks to TrinityCore making it Open Source) to satisfy my experiments.

I understand now what you mean by connection index, Intel. Thanks for the information.


84202670-DuplicateNodeInZoneConnCausesCrash (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


remove it instead of commenting it out?


Nice, perfect. Feel free to ignore my comment in the other thread, which just covers it for those following the issue there. Looking forward to pulling it and testing it out.


These aren't circular arguments.  It's how required keyword arguments are specified.


This is not pushing anything yet right? I think github has an api for publishing a release, may want to look into that.


saw approval from alexcrichton
at https://github.com/sfackler/rust/commit/8b6cda3ce681d4d95c3097d12ed754975b4a07f6


merging sfackler/rust/atomic-rename = 8b6cda3c into auto


status: {"merge_sha": "3d0d9bb6fbdf6ead9396f0874cf38f3ef7c9be5c"}


sfackler/rust/atomic-rename = 8b6cda3c merged ok, testing candidate = 3d0d9bb6


If you can get the tar and publish through github's api then you may not need to install git at all.


Since 'cordova run browser', just launches the URL without support for any arguments, I thought I would keep cordova run browser --target=xxx consistent and that was the reason I removed use of both arguments. I understand that it will spark some discussion and I will be upfront in my pull request about them.

'disable-web-security' does not sound like a good option to specify if we consider browser as a deployment target and not just a testing platform.
'user-data-dir' allows for a separate profile for testing. It's unclear why it might be very important.

Do you know of this history behind these args?


Why not call this method just fail() ?


Sorry, but this still isn't correct.  You've added `-`s in front of every line of `examplestudent`.


New approach on sync up. Getting all the ids (looping through pages if needed) then doing retrieve and save to server in a loop one record at a time. (unrelated to the story)


It seems like we still need something though that will go clean these dentries out of the CDir, right?  Maybe instead we should explicitly generate an op from  _omap_fecthed() that removes them?


What exactly do you want to achieve by this?

You can't pass closures to a view at the moment, only values. So if you define a closure, it will be converted at runtime by this commit, which obviously fails with your example, since that is not designed to return a value, but to act as a modifier.


No.


ruby method returns the value by default, you may want to remove that line


Actually, looks like there's a new syntax for that.
```ruby
def method(required1:, required2:, optional: nil)
end
```


I don't understand this sentence (the one beginning on line 328).


You removed the GLES codepath here and it breaks the build for GLES.  GLES does not have glDepthRange.  Only glDepthRangef.


Common.mk  strings 3-4 : 206-207 need to be deleted too


r+ rollup


Sorry, it should have been a PR. It started out as just a couple instances so I did it on master and forgot I wasn't on a branch.


fast-forwarding develop to borshop-integration-39-jrd/cuttlefish-errors = 3dabe015


what exactly are you asserting here with NotNull?


Zrobilem go ręcznie... i działa :D
Zaciągnij zmiany to zobaczysz.


Actually I was just going to ask why we need all those exceptions ...

The exceptions already include about everything and a lot of potentially risky paths.
Keep in mind that /hdd also includes autobackups for example ...

IMHO we should rather remove those exceptions instead of even extending them.


10/10 would commit again


I'm saying that, in the previous paragraph, we did some case-based reasoning that doesn't if we have, say, the clause

   x = x

in the result of param-elim. If we had such a clause (which we can't), then that discussion would have been wrong.

Is that wrong?


I think you mean:
```java
assertTrue(group == expected);
```


We need a description of what the invariants for the result of param-elim are, in other words. and possibly a fuller explanation of that in the previous paragraph to set up param-elim better.


Ah awesome. I'll get it changed to that and check it in the Gemfile.lock. I was getting circular argument deprecation warnings previously.

On January 12, 2015 4:58:43 PM CST, Michael Parrish <notifications@github.com> wrote:
>Actually, looks like there's a new syntax for that.
>```ruby
>def method(required1:, required2:, optional: nil)
>end
>```
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/edpaget/Cellect/commit/9fd74bb0afa02cd3c085f7a7d88716a9026f61d6#commitcomment-9250695

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


I think that the problem is with the query in line 45


nice note :laughing:


r+


user-data-dir is used by tools afaik. By default, Chrome places their user-data-dir in %USERPROFILE%\AppData\Local\Google\Chrome\User Data, but this location gets deleted on every logout on network shared systems. This is annoying because all the settings and open tabs are deleted. The solution is to launch Chrome with --user-data-dir matching their roaming profile path, so files are stored.


this test must be failing.  I don't understand it :-)


Sure this will also work, I've also had similar solution at first. But there are also other cases when image doesn't need to be resized. For instance when you make window wider and black bars are added, it this case only top left point is changed but size remains the same. My solution with cached image will reuse it. But I don't mind having your solution if you think mine is too much.

You are also missing one case, when the rect is not changed. You need to have "HideWindowedControls" enabled and make window as small as possible. When controls are hidden area is not redrawn where image should be.

It might be just tricky when we exclude area from draw completely.


```--disable-web-security``` disables cross-site scripting control using CORS headers. Since the project url is a file url right now, any reference to an http[s] url will be blocked unless this switch is set.

I do not know the intent behind --user-data-dir, but I am sure that it will be explained in the PR if it is removed :)


Hey you, Blargboard isn't yours.


Where should be this modifier used? If I read [the docs](http://fuelphp.com/docs/general/presenters.html#/functions) right I can use it in View. This commit broke my code which relied on this.


Can you use these because atom-shell is running ES6?


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2176 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.40612151667429%25-yellow.svg)


Looks pretty good @Nikerabbit. A couple suggestions:

1. The key `observer_short` is a label in front of the name of someone who made an observation in a small amount of space, so it should be short, ~8 characters or less. Набљудувач overflows the space: ![screen shot 2015-01-12 at 3 02 25 pm](https://cloud.githubusercontent.com/assets/22691/5713011/07821894-9a6c-11e4-8ccc-c27efba8251a.png). Can you think of something shorter?
1. When making a new locale file, make sure to translate the corresponding 2-letter code in locales, e.g. `locales.mk`. We use this when displaying locale choices to the user. I'm going to add this in a sec for `mk`, but just something to keep in mind for the future.


Best to create keys is to use the slim3 Datastore with the class you are creating them with...
```java
Key id = Datastore.allocateId(Group.class); //generates a new, unexistent key
```


Yes, but `osal_opengl.h` define `glDepthRange` as `glDepthRangef` for OpenGL ES 2 code path. And as `glDepthRange` is called few lines after it should work no?


I guess I don't know what your problem/error message is.  Why don't you bring your question to office hours and we can talk about it them.

See you Wednesday! :)


This problem corrected by this fix can be reproduced by using Chrome (without Encrypted Media Extensions enable in chrome://flags) and the content I have posted [here](https://www.dropbox.com/sh/ulocka7ndfhfn1j/AACx7fNuLzuSN1LYmrF6zg93a?dl=0).  The bug is in the 01b EME API implementation in dash.js which is why you must use Chrome as described above to see it in action.  Also to successfully play the content I have provided, you must set the "test" Widevine DRM proxy URL.  For example, in app/main.js, right after the creation of MediaPlayer:

```javascript
    var laURL = "http://wv-ref-eme-player.appspot.com/proxy";
    player.attachProtectionData({
        "com.widevine.alpha": new MediaPlayer.vo.protection.ProtectionData(laURL)
    });
```

There is no great way to handle the underlying issue (not knowing whether or not sessionIDs are supported until after you get a key message), so I've done the best I can think of right now by just logging a message.  I don't know of any platforms that current support this API version and do not support sessionID, so I don't think it will be a big problem.


Changes GLES codepath


This raises a whole set of issues which I don't think we need to go into here. I'll only comment that the idea of giving an error on `BinOp("=", ...)` suggests that we probably also need a sealed trait for the operators, turing that into a compile-time error.

I would like to understand the need for assignment and so, since I don't see it happening in this diff, but perhaps that's also a separate discussion.


thank you


@bors: retry


saw approval from Ms2ger
at https://github.com/mbrubeck/servo/commit/97a8b617fbb95cb835d7dd429cd71ff60579a492


merging mbrubeck/servo/dead-top-margin = 97a8b617 into auto


mbrubeck/servo/dead-top-margin = 97a8b617 merged ok, testing candidate = 8103bba1


Format:
```c
[out:csv( fieldname_1 [,fieldname_n ...] [; csv-headerline [; csv-separator-character [; csv-quote-all [; csv-quote-sign ] ] ] ] )]
```

csv-quote-all is a boolean, default is false. When true, everything is quoted with the csv-quote-sign. Containing quote signs are duplicated. Every data field is quoted, even csv-quote-all is false, if it contains a line break, a csv-separator-char or the csv-quote-sign itself.

csv-quote-sign is a single character and default "


Well, that's still a bit odd, but it's better and appears to behave correctly. If we can't have `x != null && x.foo != null` then I can live with this.


JENKINS-26149 is what I meant to reference, not JENKINS-26051.


Good :+1:


Looks like this is blocked by https://github.com/substack/node-browserify/issues/809


I see what you are doing here.  But I would have tested this via the service.  In the lines of (pseudo code);
```
Capture<Group> capture = EasyMock.createCapture(Group.class);
expect(service.updateGroup(capture)).andAnswer(new Answer(){  assertEquals(key, capture.getId()); return capture}
```


Updated to this revision and..
* `nix-env -i nix -j8` **fails** on Python (I think...currently in the process of verifying)
* `nix-env -i nix -j1` succeeds.

Of course, the `-j1` option is the default setting; I just put it here for clarity's sake.

I have `build-cores = 8` in my `/etc/nix/nix.conf`, which is equivalent to the `--cores 8` option.


ExecutionException is thrown if something cause unhandled exception in doInBackground(). Inside ExecutionException is original Exception which we want to see instead of ExecutionException.

If there is no done() with get() surrounded with proper try-catch block uncatched exceptions in SwingRunners are silently ignored.


Hum?


Sorry, what is the problem here?


I've just tested it and now it works! Thanks again! The next version of small3d will be referencing the original miguel/vorbis block, once again.

Cheers,

Dimitri


No apparent reason, could probably be uncommented.


NICE


이거 생각해봤는데 수정이 될듯해~
js 주석처리해놓은 부분  서브메뉴를 클론했는데 저게 리사이즈 하면서 pc로 갔다가 모바일로 다시오면 한번 더 복사되었거든 ..
pc 로 갈때 모바일 부분을 삭제 처리하면 태그가 없어질테고 그럼 다시 모바일로 돌아와도 한번만 클론될듯 ㅋㅋㅋ


What's the problem here?


I just put a check in for undefined, so now working with:

```
Router.onAfterAction(function() {
    var self = this;
    // always start by resetting scroll to top of the page
    $(window).scrollTop(0);
    // if there is a hash in the URL, handle it
    if (this.params.hash) {
        // now this is important : Deps.afterFlush ensures that iron-router rendering
        // process has finished inserting the current route template into DOM so we
        // can manipulate it via jQuery, if you skip this part the HTML element you
        // want to scroll to might not yet be present in the DOM (this is probably
        // why your code fails in the first place)
        Tracker.afterFlush(function() {

            if (typeof $("#" + self.params.hash).offset() != "undefined"){
                var scrollTop = $("#" + self.params.hash).offset().top;

                $("html,body").animate({
                    scrollTop: scrollTop
                });

            }

        });
    }
});
```


Ah ok


Not wrong, but I think that wording is confusing.

We've explained how we're essentially negating that unification and how taking the disjunction of the negated equations in the resulting unifier gets us that, but to put them back under the universal quantifier we have to do param-elim first or the result might not be true.

The previous paragraph is talking about the transformation from the unifier to the disequations, but param-elim is specific to the universal quantification.


No problem at all!


Hi Dario!

It's very nice to see that you've started playing around with Go :) Are you going to FOSDEM this year? If so I'd be very happy to meet up again!

Take care and I hope to see you and catch up sometime soon!

Cheers /Robin


Merged a bunch of new styling into master. Matches the mockup more closely now. Beware the styling breaks down when the width < 640 px. Also beware, it doesn't work in firefox. So I'll need to run that down as well.


Okay, but I think that it should be kept for Chrome. I think that the solution should allow browser specific and platform specific args so that each combo can be maintained independently as the needs and issues change.


Looks good.


84202670-DuplicateNodeInZoneConnCausesCrash (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.90012642225032%25-red.svg)


I see you test the not found with null.  that's cheating :-)
```
expect(service.removeGroup(id)).andThrow(EntityNotFoundException);
```


It's in the right direction, but needs a little fine tuning.
One of the important things to test that is not covered here is NotAuthorized an Forbidden...


I guess that this could be the fix:
```
if (interval.getDocument().getDocumentType() != type) {
				collectedIntervals.remove(interval);
			}
```
If you want, I can apply it in the opened PR.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes, except that that osal_opengl.h doesn't have that rename defined in this particular commit.  (Maybe it does in a later commit)


We can't use this builtin without guarding against compilers that don't support it (MSVC, in particular).  In `sgen-descriptor.h` we use `__GNUC__`.  I hope that will include Clang, too.


Do you agree that the previous paragraph is also making assumptions about the shape of the result of param-elim? That is, if we knew only that it returned something according to the grammar, then it would be wrong?


Who still uses Safari 4? It isn't officially supported since 2010. I'd rather not use these.


this argument seems useless here.


is it worth use such code here? it add more load to event loop, but in real life connection closing should work normally without this extra sleep.


-		6C7BEA8716B46C5400D8958A /* libusb-1.0.0.dylib in CopyFiles */ = {isa = PBXBuildFile; fileRef = 6CD1B3BE162C29E3006D9939 /* libusb-1.0.0.dylib */; };


r+


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


this arg seems useless here


You seem to have done some sort of weird rebase, and then merged a bunch of rebased branches together. Look at the history in gitk or gitg and you'll see what I mean.


If the shorthand notation didn't work, then this commit wouldn't fix the problem.


Also, doesn't this depend on the size of `guint`?


I didn't test it yet, but it is simply a change to GLES codepath.  It would be good to keep them isolated.  Either change it in the GLES codepath before -- or after -- this commit.


Param-elim removes equations from the unifier that, as disequations, could be true without the universal quantifier, but are made false (in a syntactically checkable way) by the quantifier.


Dear Andre

I install this and after I open excel, I see a message about missing some objects on my machine.
How can I solve this?

Cheers
Ansar


@jonsterling I guess this can now go to hackage. I have 57 uses of `(:::)` syntax elsewhere, but it was never exactly pretty, so I'm not sure it's worth keeping around. In many cases, it's actually longer than the primed tuple kind syntax, so... I just can't work up any passion for this :P


`SwapBuffers` is actually a function of `Gdi32.dll`, and the one you’re supposed to use on windows ([MSDN](http://msdn.microsoft.com/en-us/library/dd369060%28v=vs.85%29)), at least when statically linking.
The wgl functions are used when dynamically linking.

See [OpenGL Windows FAQ ](https://www.opengl.org/archives/resources/faq/technical/mswindows.htm)
* 5.190 What do I need to know about mixing WGL and GDI calls?
* 5.210 How do I properly use WGL functions?

> So since GDI and the ICD share function names like SwapBuffers, a wglSwapBuffers is needed to avoid ambiguity when loading the proc dynamically.
https://www.opengl.org/discussion_boards/showthread.php/141384-SwapBuffers-or-wglSwapBuffers

`wglSwapLayerBuffers` is the swap function for layer planes
[Overlay, Underlay, and Main Planes](http://msdn.microsoft.com/en-us/library/dd368815%28v=vs.85%29).

So using `wglSwapBuffers` is always enough.
We could draw on other layers, but if hooking into `wglSwapLayerBuffers` would have to know which layer to draw on, and either call it from `wglSwapBuffers` or not, depending on the original program rendering that layer - so that’s not feasible.
We could probably hook into the GDI method SwapBuffers I guess!?

In ET:L, for every logged GDI `SwapBuffers` call, a `wglSwapBuffers` call follows.

I would remove both injections, or alternatively only do them in debug builds. If we really want to debug a game to see why no overlay is showing or how we could make it work, we’re on the development side of things already anyway.


Also, `nix-env -i nix -j8` worked on 7ccaeef


Why was this done as two commits? The whole point of code review is that you only end up with the good version :smile:


After looking at the code again, I realized that I mistakenly used Get() when I should have used GetRate(), since I wanted to compensate for the difference in rates between the motors. I also realized that this code does not actually correct the difference in position, only the difference in rates, so this code has to be changed again.


Please don't do it like this; I think it would be much better to factor out useful functions from GameData.run_command_line() so that you can call them. I might have a go at this myself at some point.

Three reasons:

1) You've had to hard-code how to invoke g-d-p (in this case ./game-data-packager)
2) You have a shell injection/lack-of-quoting bug: it's always better to use subprocess.call([program, arg, arg]) or similar
3) If the 'install' option is selected, the user will have to enter the password for su once per game, rather than once for the whole batch


that was because I had a fork, uh


Bizarre commit message.


What the previous paragraph says would be correct on its own if everything was existentially quantified.

But yes, in this context it would be wrong aside from assumptions about what param-elim does.


We really can't do this.

Try:
http://box/file?file=/media/../etc/passwd