Making `$status` public would give control over valid values out of hand.
Why not let `status()` be the setter and `isNew`, `isModified` be the getters?


Yeah ok - i saw the "-f" and thought it was "foreground" - bad name of an option if you ask me ;) - will change ...


Why is this assignment in the loop?


saw approval from Gankro
at https://github.com/sfackler/rust/commit/89f1848b556971a4278f2b2385137ca6c9e07094


merging sfackler/rust/bufferedreader-undef = 89f1848b into auto


status: {"merge_sha": "d52398ef8cd93c6089ceacb176ae0dbe213d301e"}


sfackler/rust/bufferedreader-undef = 89f1848b merged ok, testing candidate = d52398ef


Thanks for adding this Narayanan. I totally forgot about that :+1:


Éclater dict en variables, ex KEYSTONE_URL, KEYSTONE_USERNAME


I had to partially revert this patch because of certain asm.js syntax rules.
asm.js is very strict and it does not compile if we do not follow these rules exactly.


Ok greate work...!!!!


Remplacer par répertoire template


Sure. That what I did first.


Don't need these bits of css


Remplacer par dict avec paramètres par défaut (DEFAULT_STACK_PARAMS)


Ем.. та не дуже лишнє. Просто була спроба реалізувати пошук івентів по юзеру (для цього потрібний обєкт класу профайлКонтроллер і виклик методу getCurrebtUser()), але наразі я зупинився на реалізації виводу всіх івентів. Пізніше буде реалізовний і контролер для пошуку по юзеру  і там буде використаний цей обєкт


From past experience, creating a new file just for a single function will get rejected.  You can just place function DPVOICE_GetCompressionTypes in server.c,  and Later, if/when more compression types are supported the new file might be warranted.

Should you check the return value of?
GetCompressionTypes(iface, NULL, &data_size, &num_elements, 0);


Moved feedback to the bottom of the page.


Removed the class so that it floats left.


Remove the data-spy and affix calls.


I'm not sure if this does what you think it should do. echo doesn't do any splitting and the caller will just get the string with commas.


it should be "width:100%; height:200px"


type of? :)


I left those old methods, although they are now not used at all.


I will reimplement the feature.

https://github.com/Shougo/unite.vim/issues/820


IGNORE


when it's certain that we no longer need them, I will remove them at the appropriate code review.


Oleg,

Thanks for this typo correction. I usually rewrite the code form test to the dev in order to see improvements.
Now there is no memory leaks if the grid is unloaded.
Maybe it is good to loop over the p  (gvrid parameters) and null all the properties. I will try to investigate if this have sense.  In this case _index and data will be destroyed too.

Thanks
Tony


I read this through in some detail. I don't know enough to evaluate some of the changes (esp in I/O, intrinsics.cpp), but most looked really good.

However, I'd strongly urge you to split potentially-important "grab bag" commits like this one into something like 5 separate commits, each of which is targeted at a single issue. `git bisect` is too powerful of a tool to throw under the rug this way.


Ups :smile:


resolves #39


This fix causes more serious issues. I found lots of errors while editing my erb files.

tokenize: reg-beg(757) reg-end(798) regexp("\"\\|'\\|#\\|<<[-]?['\"]?\\([[:alnum:]_]+\\)['\"]?")

Please fix this ASAP. Thanks!


But, of course, thanks for doing this!


hehe yeah. if is "fork" but it did not work :)


everything is ok with newline. the matter is that there was a new line, but with one space. because of this space github thought that it is not a new line and showed that icon and hint. to fix this i deleted space in new line at the end of file (the name of my commit) and added new line. so now there are now hints (https://github.com/alexandrzhulev/symproject/pull/9/files)


That's old version


Big thanks to @mathiasbynens who pointed me to https://github.com/mathiasbynens/he/blob/master/.travis.yml#L17.


resolves #38


definition of target_stat looks correct to me though


test


`cb` is not called inside `it()`, it's called inside `beforeEach()` as a `cordova.whitelist.test()` callback. So `done` object is valid and relates to `beforeEach()`. In `it()` we only check if this spy was called.


Wouldn't it be better to user ruby function to get present month number of days?
<code> Date.new(Time.now.year, Time.now.month, -1).day </code> would do the thing


remove unnecessary setters


I really think there should be standard formatting rules shared by all committers. Changesets like this one, where basically each line in the whole file has changed, are not very useful for reviewing. I know that I could probably get a more meaningful diff using `diff -b`, but if GitHub offers this view, I think one should strive to exploit this potential.


Did you forget to push this new predicate?


I think I commented on this in the last run, but: it's not clear what update/insert/delete mean for tables that are backed by a join. I think you might want to have `Table` and `ConcreteTable` or something like that; the former would only be queryable.


:heart: the commit msg


in that way it's easier to shoot several arrows.


It's absolutely fine to have some kind of workaround to avoid breaking the installer. That's no problem. I just believe that such workarounds should be documented (e.g. by adding a comment that explains it), because otherwise those contributors who did not implement the workaround might get confused (as I did) and possibly try to "fix" it, which could in turn break something in the installer. And I want to avoid that.

Therefore, I added a comment about that in commit 6210829717f11548e25bdb093d610598575d9318. Feel free to remove it, once the workaround is no longer necessary (but that might still take a while).


Thanks. I fixed it in a slightly different way.

I decided to define it the equivalence other way around. That way, dropping support for old GHC's is just a matter of dropping the `#ifdefs`. The rest of the code doesn't need to be changed.


Sometimes it's "err" sometimes it's "error".  I'd be happy either way, but can you make it consistent?


In my round about way I was trying to say you did not set the light level for darkstone.
Also the name comes up as tile. something instead of just "darkstone".


Or even `Table` (name, create, update), `Queryable` and `Writeable`?


J'ai trop supprimer :-1: , remettre la condition sans le else #9


How do we do failures here?


@Sheeo Isn't the proper solution here to suck "self" into the closure of that function?

Isn't this sort of checking sort of strange?


Oh. Yeah. I'll fix that


Lowercase `Rows`? Or is this some new style guide thing?


Was supposed to remove it, had this as an int before and forgot to change it


I was concerned over the potential misuse of a mutable struct, but I can change it back to how it was (keeping just the struct change).


For style I'd probably break those args out to the previous line:

```
let args = [site.title, site.guid, site.url]
if let error = db.executeChange("…", withArgs: args) {
```


"Count" on the end or not, either way I'd be happy, but can you make is consistent?

I think I'd prefer to remove it.


Urgh, that's an unpleasant pattern :/ Humph.


Nit: `Cursor: SequenceType`.


+= 1


y do u make me cry


Can we contribute any of this back? If we can avoid maintaining a fork, I'd like to.


s/occurr/occur


Thanks. Yes the truncation is aggressive

On Wednesday, January 14, 2015, Bob Grudem <notifications@github.com> wrote:

> The results now of copying a truncated cell to a text file and running wc
> give 32359, with a limit of 32768. Getting it closer is a matter of
> nitpicking. I have pushed the fix to the staging server and will give it to
> the customer tonight.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/danchoi/jsonxlsx/commit/05a19a4a8326aca35f2231810b677700cb553a0b#commitcomment-9289364>
> .
>


On Wed, Jan 14, 2015 at 03:41:20PM -0800, Kyle Blatter wrote:
> BOOM! I still need to implement it, but I have it figured out. Stupid 'shell='
> parameter. Thanks for the help!

Yay! Nice work.


fixes #1316

I think.  :)


Woo!


Worth /** */ documenting this.


Actually, don't, leave it as you have it.  I thought range list was an array, but it's a list.  You've done the right thing :)


Yeah sure! I just kinda forgot to comment it ;)
Thanks for adding it!


You'll still run into that issue if you use etl module with ET.exe regardless.


Looks like this should be inside SQLiteDB, too!


room.roomSrvUrl?  Why not just "room.url"?


Would "url" be better than "rs"?


`--savepointsOpen`?

What if the savepoint doesn't exist (and we're at savepoint 0)?


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3145
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3138
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3130
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3130
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3133
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3126
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2798
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2796
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1634
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1627


Same here with url names


To do:
-Fix bug with roads visually disappearing when a settlement is built to the left of a horizontal road by a different player
-Rework AI road building logic


@ranjitjhala I proved the "relatively complete" example.
If you want to take a look, the specification is quite interesting.


I think you only need to change `D.S.PreProcess`.


Newline at end of file.


My vague recollection is the recommendation is to not use undefined in JavaScript code. Perhaps use null here instead?


Reverted this commit since it accidentally contained sandbox code for the test architecture.


Open brace should be on the end of the previous line.


Looks like excellent progress. I'd prefer to see the SwiftData stuff split out, ideally contributed upstream (which will mean teasing out your improvements to create pull requests). I'm happy to help with that if it sounds repellent to you.


Crap, i think I had that in because ESLint was bitching about "crypto" being a read-only variable (per https://developer.mozilla.org/en-US/docs/Web/API/Window.crypto).

We can revert that out in your PR. sorry.


Open brace should be on the end of the previous line (actually it should be "} else {" on one line).


This causes problems for derivations that take regular files that are not setup hooks, and crash when sourced by bash.


Minor nit: space before opening brace.


it's a temp work. i order to clean up the way that the blitting is done. i will change that. Thanks


84695188_CoverageFinalImplementation (lefticus) - i386-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think one of these MOVs is redundant.


84695188_CoverageFinalImplementation (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.32%25-red.svg)


84695188_CoverageFinalImplementation (lefticus) - x86_64-MacOS-10.9-clang: OK (1584 of 1584 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


next time name the post_image

if its two words like that you always want to use an underscore


1) Описать класс «Cat» (в качестве образца можно взять домашнего
питомца). Наделить его свойствами и методами. Создать несколько
экземпляров объектов этого класса. Использовать эти объекты.
2) Описать класс «triangle». В качестве свойств возьмите длинны
сторон треугольника. Реализуйте метод который будет возвращать
площадь этого треугольника. Создайте несколько объектов этого
класса и протестируйте их.


remove this random space


looks good!


Will this offset tracker feature be released with V1.1 or 2.0?


в класі Cat потрібно було створити метод для порівняння двох обєктів цього класу


Whoops I lied about adding an event loop for editing the song. I need to do that, it will be in the next commit.


#35 updated travis build image


Excellent image


r=acrichto


You submitted the test at 60+0.05 with bounds [-1.5, 4.5] which is not correct. Please resubmit the test with correct bounds.


I think the more idomatic way of doing this would be to not use reflection, and do it something like this:

actual := db.getReport(rt)
expected := Report{OpenWs: 0, TotalWs: 0}
if (actual != expected) {
  t.FailF("%#v != %#v", actual, expected);
}

And maybe have a failIfUnequal(db.getReport(rt), Report{OpenWs: 0, TotalWs: 0}) to wrap that.
(I'm not sure if the last part is idiomatic, but it's better than using reflection).


what are ya doing here? hah

why not render partial: not sure where u got render :file


lol


Are you experimenting now, or is this intended to be production code?


Why doesn't r.ErrLog[maxErrLogLen-1] work?


і поясниш про гетери і сетери, а то я їх наліпив, але толком в них ще не розбираюсь)


Not needed for product search, this line can be removed.


As with the line above, this can be removed


> For example, X_MIN = 0, but X_MIN_ENDSTOP_POSITION = -1mm.

It took me some time to see what you mean. X_MIN is not only used here, but also in gcode_(something).c to limit movements, so having a name different than X_MIN does make a difference. Sorry for my ignorance earlier.

I'm entirely with you that min endstop positions should be allowed to be != 0.

Regarding endstops outside of working area ... so far I can't see much reason to do so. Purpose of a (software or hardware) endstop is to avoid crashes, nothing else. Each time you touch a firmware defined endstop during printing you basically ruin this print, so you want to avoid this as much as possible without damaging the printer.

If you want to limit your printing area, G-code preparation (slicer) is a much better place to do this. Slicer will happily generate G-code which never moves to the outer areas.


Thanks, Tim! I have updated the change with fixes you mentioned! I ran through jshint and it found other spacing issues and fixes those as well.


haha ok :)

On Wed, Jan 14, 2015 at 4:13 PM, Niki Vazou <notifications@github.com>
wrote:

> @ranjitjhala <https://github.com/ranjitjhala> I proved the "relatively
> complete" example.
> If you want to take a look, the specification is quite interesting.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/ucsd-progsys/liquidhaskell/commit/0450a6b54a07649cfc135bcef969e358f8ae3f87#commitcomment-9289553>
> .
>

--
Ranjit.


You still need the error handling for non-zero return codes.


saw approval from Gankro
at https://github.com/pczarn/rust/commit/fe6cca32954baeacb2542e5a55914c876b66d23e


merging pczarn/rust/btree-bounded-iter = fe6cca32 into auto


status: {"merge_sha": "9e52afb8f0af5d8531c7707926cd60a8111e5150"}


pczarn/rust/btree-bounded-iter = fe6cca32 merged ok, testing candidate = 9e52afb8


ahhh.. very clever mr american boy.


trying to speed this up by avoiding as many comparisons and the try-except. Still half as fast as repeat dijkstra.


What does install mean here exactly? Make it available anywhere on the system? Can we still run highfive from its directory without installing?


Just un-check the boxes for log files so they don't count as changes when you commit in the future please


I will accept this pull request, but please can you change the name of this vatiable to something different? range is a reserved word. thanks!!


Thank you & Best wishes!


I've cherry-picked this and moved it to a new test in package: org.hibernate.jpa.test.orphan.onetoone.

Thanks!
Gail


Tested... All good with both old and new versions of the Database :+1:


response should have blank body?


Type in response.


This only works on iOS 8, I believe you have to check -enabledRemoteNotificationTypes for iOS 7 and below.


response should have body equal to all drivers json?


It would be nice if there was some granularity here w.r.t. the types of user notification types (badge, sound, alert), rather than asking for it all.


Hey hey hey, folks
In my system $SHORT_HOST doesn't exist at all(Arch Linux)
And echo don't care about it
So, may be you must checkout existing this var before use it?(Else it's just empty)


Check out https://vagrantcloud.com/chef These are the "stable" binary output project at Chef and many of the same boxes are available in this release stream.

> On Jan 14, 2015, at 14:34, David Colebatch <notifications@github.com> wrote:
>
> Any suggestions on what a box-cutter user should do? Those downloads were critical to my day-to-day so sad to see them go...
>
> —
> Reply to this email directly or view it on GitHub.
>


@blueyed yep


Let's actually just remove the whole "Why should I use the Chrome Web Store?" section. I'm currently re-working this page. Complete rewrite coming soon!


You are not freeing this memory.


Or should you rather free `img_pyr[i]` ?


I see, I will do this later. Thanks for review.


Ne passt, kein Problem, wollte es nur anmerken...


Builds (with warnings) and passes all non-python tests for me.


Well, i think we began to use them ages ago, a lot before the comment introduction :)


:shipit:


firing the push notification completion handler here is premature.

On iOS 7 & 8 you have to wait for:
`-application:didRegisterForRemoteNotificationsWithDeviceToken:`
`-application:didFailToRegisterForRemoteNotificationsWithError:`

And even then if the user has disallowed push notifications, you *never* get called back with a response (so you'd have to implement your own timing mechanism to check, here)

On iOS 8 you can listen for:
`application:didRegisterUserNotificationSettings:`

Since these methods are only called on a `UIApplicationDelegate` it would be hard for `ClusterPrePermissions` to incorporate push notifications, as much as I'd like to see it!


Yes, you can still run highfive from this directory without installing. To run it without installing it, you need to call the script:

`python highfive/newpr.py`

I think this should change but I'll do it in follow-up PRs


Joel Rivas
Carnet: 11-10866
Razon: Aprender.


Shouldn't this be : `specified at creation of the *container*`


![Uploading base.py . . .]()


hey there sir @Bitti09! umm, why is it that I can't view your af? af needs me to login first and I did already yet I can't view your folder. have you uploaded your new version of cm12? I would like to test it right away!  And please include a little changelog of what's new. thanks!


yahoo.com!


oh nevermind, not yahoo-inc.com.


I think the `Authorize` function should return true if `u.Admin`


r+


@FelipeCaue tanx for your contribution,  i will merge this PR, but don`t forget to write tests for validation okay.

```ruby
Resize::Validation::validate(negative: -1)
```

See some examples on:

https://github.com/Resize/Validation/blob/master/spec/validation_spec.rb


The context: https://github.com/rails/rails/commit/6cd3bda32f6183f2e31a3b62e35c01655e8debc4

Only goes to show few things are more permanent than a "temporary fix" :D


Doesn't this warrant discussion in an issue to itself, @Sheeo ? (Or do we not care too much what constitutes "ranked options"?)


Thanks! Both are fixed. By the way, if you'd like to let me know what
features you want to see improved in BEM++ just send me a mail. It would be
great to hear your experience.

Best wishes

Timo

On 14 January 2015 at 19:07, Thomas Hisch <notifications@github.com> wrote:

> Here as well
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bempp/bempp/commit/b3dcfbf054d04a1e40aaeee2190bfe6b255d93d5#commitcomment-9284396>
> .
>

--
Dr. Timo Betcke
Reader in Mathematics
University College London
Department of Mathematics
E-Mail: t.betcke@ucl.ac.uk
Tel.: +44 (0) 20-3108-4068
Fax.: +44 (0) 20-7383-5519


fixed in 138ad91


You may want to check out [Benchmark.js](http://benchmarkjs.com/), or at the very least use a built-for-purpose benchmarking tool such as Siege or Apache Bench. Curl isn't made to benchmark - you're incurring quite a bit of unnecessary overhead and deviation in results by using it.


Instead of always checking if a GUI element exists, why not just ensure that your function is never called earlier than CreateUI? If you do that, you can omit these checks (I've been doing this all over the place).


das ja eine kaka, werde die Tage mal drüber schauen!


Why AioWrite process copy on read logic? May be i missde something.
In your code,  read_from_parent_cb send exec op : cls_rbd_copyup to osd to
write object content, not using AioWrite request to do that.  they are different I/O path


some leftover cruft here?


Instead of duplicating this code to update the label everywhere, why not factor out the checking logic into a "IsGameRanked()" function?
Then you could replace it all with something like:

if isGameRanked() then
    GUI.RankedLabel:SetText("Game is Ranked")
    GUI.RankedLabel:SetColor("77ff77")
else
    GUI.RankedLabel:SetText("Game is not Ranked")
    GUI.RankedLabel:SetColor("ff7777")
end

One would hope that isGameRanked would implement some sort of caching, too...


Also it would be much more meaningful to test individual key parts functionality, or at least test against cached images. Network operations to the texture servers are (or, should be!) the operation that takes the majority of time when requesting resources, and those times can vary tremendously and are dependent on any number of factors.


Sorry, didn't notice this one before - you can declare *deployTarget* just before you use it (within the *then()* call, below).


Looks good, apart from one minor thing mentioned above.


you're right! good catch!


Oh, and also update the comment, since you removed the build options.


try keep char_id as uint32 to avoid nightmare of type conversion please


This particular script was for testing our new hosting solution vs our current solution. The original benchmarks are based on a similar script, but will be invalid eventually. With this script, we tested each service twice, once for non-cached images, once for cached images. We can/will definitely look into alternatives for benchmarking, such as the ones you suggested. Thanks!


Ah I see how much code it is. Yeah, this should probably be included by default; I think it's reasonable.


It'd be really nice to see the ranked options declared somewhere so you can replace this pretty gnarly check with a simple loop.
The idea would be that somewhere you'd have a constant table:
```Lua
local RANKED_OPTIONS = {
    Victory = 'demoralization',
    Timeouts = 3,
    ... etc...
}
```

You can now check if default options are set using set difference, or slightly more verbosely (and probably marginally faster) by just checking keys, something like:

```Lua
function areRankedOptionsSet() do
  for k, v in RANKED_OPTIONS do
      if gameInfo[k] != v then
          return false
      end
  end
end

return true
```

This routine would return false whenever an option is set on gameInfo that isn't equally-set in the defaults, and it avoids the need to repeat this really gnarly check you've got everywhere.


Oops. Just noticed the Slow button which automatically change the bounds to [0,6]


헤이!헤이! 일주일이나 지났다구요!


Shouldn't we insist that this is always set to {} when no restrictions are set?


Implementing any of those options will be very easy, so we can defer the final decision for a while and focus on implementing the various parallel methods. So I say forge ahead the way it is now!


It'd be nice if this fix had its own commit...


Oops, I thought it was under cmd/util

I guess we could pass around client.Config objects, and just serialize them into env vars to cross process boundaries as needed. Having the config actually store cert data rather than just file paths enables that.


I'm not sure if this change caused some problems with kernel scheduler, I saw following messages in kmsg

[  234.341339] SysRq : Show Blocked State
[  234.341369]   task                PC stack   pid father
[  234.341430] jrcud           D c056dea4     0   515      2 0x00000000
[  234.341583] [<c056dea4>] (__schedule+0x268/0x78c) from [<c056f848>] (schedule_hrtimeout_range_clock+0xb4/0x140)
[  234.341674] [<c056f848>] (schedule_hrtimeout_range_clock+0xb4/0x140) from [<c00f1ef8>] (usleep_range+0x5c/0x64)
[  234.341766] [<c00f1ef8>] (usleep_range+0x5c/0x64) from [<c0126898>] (jrcud_func+0x7c/0x10c)
[  234.341827] [<c0126898>] (jrcud_func+0x7c/0x10c) from [<c0100e74>] (kthread+0x84/0x88)
[  234.341888] [<c0100e74>] (kthread+0x84/0x88) from [<c00b9228>] (kernel_thread_exit+0x0/0x8)
[  234.342437] Sched Debug Version: v0.10, 3.0.101-Chrono-r2.14-g0fc6cff-dirty #48
[  234.342498] ktime                                   : 234346.403102
[  234.342529] sched_clk                               : 234342.437743
[  234.342559] cpu_clk                                 : 234342.437743
[  234.342590] jiffies                                 : 4294960729
[  234.342620]
[  234.342620] sysctl_sched
[  234.342651]   .sysctl_sched_latency                    : 10.000000
[  234.342681]   .sysctl_sched_min_granularity            : 1.500000
[  234.342742]   .sysctl_sched_wakeup_granularity         : 2.000000
[  234.342773]   .sysctl_sched_child_runs_first           : 0
[  234.342803]   .sysctl_sched_features                   : 15598
[  234.342834]   .sysctl_sched_tunable_scaling            : 1 (logaritmic)
[  234.342864]
[  234.342864] cpu#0
[  234.342895]   .nr_running                    : 0
[  234.342926]   .load                          : 0
[  234.342956]   .nr_switches                   : 697997
[  234.342987]   .nr_load_updates               : 12171
[  234.343017]   .nr_uninterruptible            : 4294966416
[  234.343048]   .next_balance                  : 4294.960689
[  234.343078]   .curr->pid                     : 0
[  234.343109]   .clock                         : 234296.936034
[  234.343139]   .cpu_load[0]                   : 0
[  234.343170]   .cpu_load[1]                   : 0
[  234.343170]   .cpu_load[2]                   : 0
[  234.343200]   .cpu_load[3]                   : 0
[  234.343231]   .cpu_load[4]                   : 0
[  234.343261]
[  234.343261] cfs_rq[0]:
[  234.343292]   .exec_clock                    : 0.000000
[  234.343353]   .MIN_vruntime                  : 0.000001
[  234.343383]   .min_vruntime                  : 142273.219187
[  234.343414]   .max_vruntime                  : 0.000001
[  234.343444]   .spread                        : 0.000000
[  234.343475]   .spread0                       : 0.000000
[  234.343505]   .nr_spread_over                : 0
[  234.343536]   .nr_running                    : 0
[  234.343536]   .load                          : 0
[  234.343566]
[  234.343597] rt_rq[0]:
[  234.343597]   .rt_nr_running                 : 0
[  234.343627]   .rt_throttled                  : 0
[  234.343658]   .rt_time                       : 0.000000
[  234.343688]   .rt_runtime                    : 950.000000
[  234.343719]
[  234.343749] runnable tasks:
[  234.343749]             task   PID         tree-key  switches  prio     exec-runtime         sum-exec        sum-sleep
[  234.343780] ----------------------------------------------------------------------------------------------------------
[  234.344268]
[  234.344268] cpu#1
[  234.344299]   .nr_running                    : 1
[  234.344329]   .load                          : 1586
[  234.344360]   .nr_switches                   : 325952
[  234.344390]   .nr_load_updates               : 10920
[  234.344421]   .nr_uninterruptible            : 881
[  234.344451]   .next_balance                  : 4294.960719
[  234.344482]   .curr->pid                     : 2433
[  234.344512]   .clock                         : 234330.841063
[  234.344543]   .cpu_load[0]                   : 0
[  234.344573]   .cpu_load[1]                   : 0
[  234.344573]   .cpu_load[2]                   : 0
[  234.344604]   .cpu_load[3]                   : 36
[  234.344635]   .cpu_load[4]                   : 304
[  234.344665]
[  234.344665] cfs_rq[1]:
[  234.344696]   .exec_clock                    : 0.000000
[  234.344726]   .MIN_vruntime                  : 0.000001
[  234.344787]   .min_vruntime                  : 192027.013054
[  234.344818]   .max_vruntime                  : 0.000001
[  234.344848]   .spread                        : 0.000000
[  234.344879]   .spread0                       : 49753.793867
[  234.344909]   .nr_spread_over                : 0
[  234.344909]   .nr_running                    : 1
[  234.344940]   .load                          : 1586
[  234.344970]
[  234.345001] rt_rq[1]:
[  234.345001]   .rt_nr_running                 : 0
[  234.345031]   .rt_throttled                  : 0
[  234.345062]   .rt_time                       : 0.000000
[  234.345092]   .rt_runtime                    : 950.000000
[  234.345123]
[  234.345123] runnable tasks:
[  234.345153]             task   PID         tree-key  switches  prio     exec-runtime         sum-exec        sum-sleep
[  234.345184] ----------------------------------------------------------------------------------------------------------
[  234.345336] R       watchdog  2433    192017.013054       241   118               0               0               0.000000               0.000000               0.000000

Might it be caused by memory block ?
For now I reverted this change to see if it helps.


Isn't it sufficient to call this from SetGameOption, instead of calling it absolutely everywhere?


Since you call this from UpdateGame, and you call UpdateGame from CreateUI, you *definitely* don't need to do this.


Why do you have an empty <p> element in line 19?


If you want text to be part of a paragraph, you would use:
```html
<p>Use this tool to calculate risk, or something along those lines.</p>
````


want me to rebase the change?


Empty p element at the end of line


.aafs.


Try these methods without the (). They aren't required.


Let's put the ending brackets of the if/else on their own separate lines.


You definitely don't want to delete this: doesn't this break line 2669 that tries to reference this variable?

Did you actually run this code?


did that pull request seriously break something >_>

Also you committed wolfbot.bat


goodness how do i go about fixing this? @negativetwelve


Not a big deal, but the other `FromConfig` initializers actually use a Config object, whereas yours just uses values directly.   Might as well follow the same design pattern, so changes in the configs are all concentrated in one place.


God damn it I should really stop doing that.


uhh this happened when merging in the other stuff?


r=acrichto


### Ryan Servos

* My Online HQ is tentatively located [here](https://github.com/RWServos/HistoryHQ).
* My Research Notebook is located [here](https://github.com/RWServos/RWSResearchNotebook).


Can we get this merged upstream?  I need this fix for our deployments.


아 업데이트 해야지 ㅋㅋ
2015. 1. 15. 오전 10:08에 "ilshik" <notifications@github.com>님이 작성:

> 헤이!헤이! 일주일이나 지났다구요!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/odradeck/ex2015/commit/466b75bc8b0d0428dd053b9bf4d013a5f2032bd3#commitcomment-9290069>
> .
>


As per [autolobby](https://github.com/FAForever/fa/blob/develop/lua/ui/lobby/autolobby.lua#L41) this is the right key to use.

There may be need for a spinoff discussion about whether 'ranked' or 'default' are necessarily related at all, since we also 'rank' games with a unit cap of 250 or 750.


LGTM !


Spelling.


yea


Thanks!


Plus, this version seems less useful to the user.

I think we probably want to keep the old message, or something like it. While the additional technical details are useful for fixing the broken map, this message is being displayed to the user. The user, in general, is not a developer, and will have absolutely no idea what this message means.
What the *user* needs to do is contact the map author (or perhaps post on the FAF forum so someone else can do it for them).

The message should reflect that.


... Please learn to use `git push -f` before I go completely insane.


mb() makes sure that register is written.


cry :/

I don't really have any idea. If you based this branch off the other one, it shouldn't have happened this badly...


I think you may need to include your Role model in your tests unless this is added to your rolify gem


oh well QQ. i guess this will forever be stuck in our commit history


Why?

Again with `push -f` and `rebase -i` and friends. This sort of spam should be kept out of PRs.


Fixed https://github.com/Kdyby/Redis/commit/dce1be8cdfc9c1c718a6036240b586aadf750807


What you were trying to do with this commit in the first place seems like a good idea: that block has been bugging me for a while.
Maybe you can make it even neater by independently building the two halves of it?


nice commit!


r+ Thanks!


Using string keys in the options table is probably good for readability, if not performance.


Thanks for pointing out the check for numericAttrsColumnIndices Aaron, I guess it escaped my attention. And thanks for the edits to the docs and testcases as well. Before you merge this, I just wanted to get an opinion on whether the modifications to the API interface are okay from a usability perspective.


Well what I mean is to add the empty line under the `})(this);`, not above.


Again, doesn't this warrant some sort of public comment period?


`makeAndCompare(..values)` or `makeAndCompare.apply(this, values)`


I mean, which *effects/conditions* have resulted from the attack (not *traits*)


어 왜 푸쉬가 안되어있지? 여튼.. 하고 있었음.. commit 만하고 푸쉬안했나?


It doesn't matter, but: I recommend `mkdir -p /tmp/debexpo/incoming` rather than always doing the mkdir.

`mkdir -p`  is defined e.g. here: https://superuser.com/questions/165157/what-does-mkdir-p-flag-do


Yippee! Although I could have dealt with this change being in a separate pull request. It's also fine here.


"smurth" isn't a word.


In my opinion, changes like this should be their own pull request, with corresponding tests, but I can live with hackery in the commit log as we do this initial work to fight the app and convince it to have its tests pass.


This revision is clean.


Same note as above about this deserving its own commit but being able to live with it.


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3139
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3146
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3140
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3131
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3131
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3134
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3127
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3121
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2799
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2797
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1635
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1628


You definitely don't need to write this yourself.


Exciting. I love ` if ! grep -q`. (Seriously.)


Nice, I 'll start working on this.


포인터 선언 후에 null로 초기화 하는게 좋겠음


errors won't be `null`. Might be being too protective here.

Also:

`!errorSink.Errors.Any()`


Whoa, what does `<<<` do?

Does it treat that string as stdin? If so, amazing.

_googles_

http://www.commandlinefu.com/commands/view/2435/using-bash-inline-here-document-with-three-less-than-symbols-on-command-line -- yes. Amazing. TIL.


I am having the same problem. Does anybody know why `echo -e` is printing the `-e` to the `.bashrc`?


yep - and fixed now in bfdedaa6421dd4e2d16283959d3e6449c85f797d


I prefer to use 'null' instead of 'undefined' if you want to write down all members here. In that way we can distinguish the members don't exist (may be typo or others) and the registered but not used yet members. And the precise way to determinate it would be `if (null === this.someDataMember)`


Since you're apparently still writing the disk format for this feature, perhaps it should be moved to a feature branch for a couple of cycles until it's finished?
Otherwise you're going to have a hell of a time trying to support every half-finished disk format that ever got published.


Hilarious. OK.


Why are you creating a VideoMode object that is instantly destroyed?


Is this debugging code?


Presumably you could use some more complicated/sane invocation of mock here, but I can live with this kind of hackery as we race toward a sanity goalpost of having the tests pass.


Yippee!


Are there any unpleasant implications resulting from creating such an extremely large number of preferences in the way that the preset system does? Might it make the preferences menu take a long time to open? Something else?
It'd be nice if you could find a better place to store these data. A separate file on disk, perhaps, with the name a hash of profile name so you still get per-game-profile association?

@Sheeo, Can we do that sort of IO? Is there a nicer place we can put this stuff?


np :)


my bad, I didn't realize the dev version was pointing to my repo and not
the upstream

On Wed, Jan 14, 2015 at 7:19 PM, Shane Canon <notifications@github.com>
wrote:

> Can we get this merged upstream? I need this fix for our deployments.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/teharrison/narrative_job_service/commit/01803df15386e84ef4c503e63424417f46a47211#commitcomment-9290155>
> .
>


A comment explaining the need for the blank might be in order...


For future reference

- https://travis-ci.org/Kdyby/Redis/jobs/47066244
- https://travis-ci.org/Kdyby/Redis/jobs/47066264


Pretty sure this boils down to table.filter?


Questionable variable name: "tyype".


I wonder if the generators are generally useful, I think @shane was doing something similar


init() function은 처음 한번만 불리면 되므로, 지금 이 코드 상으로 100번째 줄 정도에 들어가는게 적당함(즉, 루프에 들어가기 전에 호출을 해주는게 적당함)


You wouldn't expect to see ScalaCheck and ITC used in the same sentence :+1:


proud of u joe :sparkling_heart:


saw approval from nikomatsakis
at https://github.com/jroesch/rust/commit/6a66b3227087d3336d8a0e2583dfd35ae93f950b


merging jroesch/rust/generalize-impl-bounds = 6a66b322 into auto


status: {"merge_sha": "451e134c180e88b06e3b747ed750e4901ca93721"}


jroesch/rust/generalize-impl-bounds = 6a66b322 merged ok, testing candidate = 451e134c


Well you could probably still credit them lol.


84695188_CoverageFinalImplementation (lefticus) - Win64-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


While not exhaustive, I tried changing some of these to have incorrect values and then ran the tests. I did this individually for the following:

Value | Test Result
-------- | ---------------
s_notSpace | Test Failure
s_notWord | Test Failure
SpaceClass | Test Failure
"Cc" | Test Failure
"Cf" | Test Failure
"C" | Test Failure
"Ll" | Test Failure
"Sc" | All Tests Pass

In some cases there were a couple test failures, in other cases there was just one test failure. Looks like there's some missing code coverage for "Sc". There may be missing coverage from others because I only tried changing the above to incorrect values.


Your indentation seems off. You might be using tabs instead of spaces or vice versa? Could you please fix this?


Also: thanks for the pull request! :)


There used to be a ```masterProxy``` in AppMasterContext and now you rename it to ```master```, which is a conflict  with line 45. So here will throw NPE


rax retry tests


I know I wrote this, but I'm also pretty suspicious if it actually needs to exist, either.

You also probably want to merge this file with the existing `system/utils.lua` which has things of the same flavour in it.


만약 이 함수를 쓸 거라면 발생하는 문제
 - N개의 임의의 원소들과 임의의 순서로 구성된 linked list L이 있다고 할 때, 이 리스트에 3번째에 어떤 원소를 넣고 싶다. 어떻게 하지?
 - 이 linked list로 stack이나 queue를 구현한다고 하자. 어떻게 push하고 어떻게 pop 할 것인가?

오늘 수업 시간에 얘기를 해드리겠음.


It's a little unclear from the commit message what the goal is here, since it refers to both "default" and "ranked".
Is ranked the same as default? Surely ranked should be a range of acceptable options, not just a very specific configuration?


delete debugging line


Thank you for fix


이 함수는 Memory leak을 발생시키지 않는 것을 보장할 수 있음?
내 의견은 원소가 세 개 이상일 경우에는 현재 구현에서 leak이 발생함.


With these changes do you deploy your app with these commands? clean heroku:deploy-war


I'm curious: where does deep_merge come from? it is not a ruby method, is it?


LOL ... stuff happens :p


Thanks for pointing that out about !help. I must have missed those two.

I'm not sure if I will do the repeat one, as the way the song queue works at the moment is that each song item is "consumed" whenever it ends, meaning that it is no longer in the song queue. Adding a !repeat command would require me to re-think how that works which would be quite a bit of work. Plus, just re-adding the playlist would give you the same effect.

I have thought about introducing a way to randomize the songs within a playlist. This would most likely be done at the point the playlist is added to the queue (maybe an extra argument could be given to the add command?).


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1866](http://teamcity.monogame.net/viewLog.html?buildId=4367&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


how come the "if @options[:log_stats]" has disappeared? won't this always log and ignore the :log_stats configuration when true?


In that case, I'm fully in support of deprecation. Thanks for the clarification.


Hey Sami!

This is a cool commit, and I would love to use your DragContentView. However, the if IOS10 is throwing an exception on my iOS 7 device.

Any idea what's going on?

Thanks,

Michael


Should this method be exposed to all the AR:Base methods visible to end users? Unlike _before_type_cast which is sometimes useful for application developers, _came_from_user? seems a low-level technical framework requirement.


@raz0rsdge: I added the two commands that were missing to the !help command string. Let me know if you find anything else!


This took me forever to google, fwiw. If I find the original article I might comment it above the code.


No, which is why it isn't exposed.


I'm open to making this less hacky. Also, I give my testament here that I tried to _manually_ resolve the dependency tree through downloading and installing .deps in the .travis.yml before trying this approach.


That's reasonable, will change.


Agree with your suggestion for a smaller PR containing non-breaking changes - see the bottom of this PR for the list.

Regarding the adoption of this library in a framework: Raygun is a subscription-based (paid) SaaS, of which this library is the PHP integration for it. While we certainly would love it if the PHP OSS community were to sign up for Raygun en masse, the fact that this is a specialized client library for a service makes it somewhat inappropriate to bundle with other frameworks. Similar to if the New Relic PHP library were to be integrated WordPress and available to report metrics by default, for instance.

Regardless, we are all for matching the PSR-2 standard, however as you note this will need to ensure it does not break sites downstream. The commits without comments in general look good however.


Sorry, I thought attribute_suffix would generate these methods for all attributes, like:

`@user.name_came_from_user?`

etc

Just like we have `@user.name_before_type_cast1


There are a few upsides to using a requirements.txt.
1) Dependencies are easier to look at casually, especially with more complicated setup.py scripts.
2) You can use "pip freeze" to easily generate and update a requirements.txt.


When issuing a AioWrite, a CopyupRequest may being conducted. Thus AioWrite will check copyup_list to see whether it is possible to get entire object without duplicating read_from_parent for the same object.

“read_from_parent_cb” will differentiate CopyupReuqest: 1). A CopyupRequest created by AioRead will be copied up asynchronously thus “read_from_parent_cb” will send copyup operation; 2). A CopyupRequest created by AioWrite won’t send copyup operation, as AioWrite will send copyup itself.

> On Jan 14, 2015, at 8:02 PM, cmgitdream <notifications@github.com> wrote:
>
> Why AioWrite process copy on read logic? May be i missde something.
> In your code, read_from_parent_cb send exec op : cls_rbd_copyup to osd to
> write object content, not using AioWrite request to do that. they are different I/O path
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ceph/ceph/commit/7148d9ade56166319848a529b0ef7c4b5f1bf6ba#commitcomment-9290018>.
>


These have been renamed from `contains` to `includes`.


In general for the README.md,
* search for "android" and replace with "Android"
* search for "optee" and replace with "OP-TEE"
* search for "linux" and replace with "Linux"


If I remember correctly, it's not useless because if one test causes JVM to hang/crash (e.g. native code misbehavior), test runner just stops, which is inconvenient


Since David pushed this before my earlier commit of the same change,
here's my explanatory commit comment for posterity.

SMURF: Increment version number for TIMESORT SPECBND change.

ORAC-DR needs to test the version before it can use the new SPECBND
parameter in TIMESORT (46f46b8bee826) in case an earlier Starlink version
is mixed with a current ORAC-DR.  This should be a later version, around
1.6.7 by my reckoning.


Then why did you create this repo...


Sort could be the same, I used the trick change the varchar to int by adding the ZERO value.
"1"+0 = 1


I know, this was not suggested by rubocop, but my own change as I recognize, that initial setup is `newcommand` empty. Loop is not auto-corrected, so all changes are my own. I think it can be visible from comment in rubocop which is removed.


Should the condition be `ariaCoreBrowser.isDevice()` ?
I don't know if other mobile browsers behave as iPhone/iPad or Android browsers, but it is probably the case... have you checked it?


結果還是同時操作兩個元素了一w一...


"3で割り切れる場合"、"5で割り切れる場合"、"15で割り切れる場合"にも
expect( model ).not_toがあったほうがよいと思います。
数値をそのまま返すメソッドを追加して、spec側でそれを利用するとよいと思います。


This is a BC break, Kdyby / Doctrine doesn't work after this commit. the problem is with these two services: https://github.com/Kdyby/Doctrine/blob/d81a7b7f1b016f5510fff4a3f4e02f6b3debe2de/src/Kdyby/Doctrine/DI/OrmExtension.php#L169-L182


Those 2 variable assignments should be in the `else` block.


I like it better and it also allows to use CLion for development.


Then you were exactly right to change those. :-)


I think we don't want to remove the other fields just yet...


Awesome :) I'll get rid of `Makefile` then


Looks fine on the paper. :D
I do hope the std::find() in the for loop won't be bothering on a larger scale.

Btw, for the record, once we've tested and used the code enough, we may have to check whether the following code is used elsewhere and should or shouldn't be removed if it isn't:
TileCoordinateMap::getCentralTheta()
TileCoordinateMap::getRadiusSquared()
TileCoordinateMap::getCoordinate()
RadialVector2 class


When you are logged in as a global administrator, there is no appId in the `gh.core.data.me` object, which is required if you want to request the `orgunits`. So this cannot be tested properly since we are on the global admin router.


perfect!
Lesson learned: if you use the github web interface editor, don't forget to add the file extension if you create a new file. ;)


no psr-2 :(


are the tests disabled here because of the ci instability, or because this commit changes the results?


Is there any way you can make this dependant on the system's location?
eg. If location set in the Americas, set to 480...everywhere else set to 576.


I had some severe problem with that setting, but do not remember what it was. (Un)fortunately it is not reproducible anymore, so let's restore it.


Also fixed https://bugzilla.xamarin.com/show_bug.cgi?id=12669 as well as the bug listed in the commit message (https://bugzilla.xamarin.com/show_bug.cgi?id=10468)


I wasn't able to look into this yet but I think there is a in regression here. I don't get any search results with the latest code (Basic/Advanced and QuickSearch). I worked fine yesterday so it has to be this commit.


A topic per battery doesn't seem a correct solution. Instead, I suggest to extend the existing topic with multiple batteries support. Also it would probably make sense to change `discharged_mah` to energy units (Joules or Wh), since the quantity of interest is the amount of energy spent or remaining in the battery, not its electrical properties.


Could you change the `cerr` for some LOG with INFO or DEBUG level?


I think this is accidentally left out, it should be commented back in.


Создать отдельную для этого репку и туда закинуть пока пользуемся, а потом вообще убрать.


Also you should probably use `isset($refClass)` instead of `$refClass`. In case the exception is thrown from the toReflection call above, this variable will not exist.


Hello,

Je suis au PSE toute la journée, mais pas demain par contre.

@+

M

> On 15 Jan 2015, at 10:56, pryv-tech <notifications@github.com> wrote:
>
> Hello Manuel,
>
> Merci,
>
> Regarde la branche "mat-optimization" on a fait pas mal de tests..
> Je vais voir ce qui a été validé et je le ramène dans la branche master
>
> Quand est-ce que tu es au PSE?
>
> Tout de bon,
> Perki
>
> > Le 15 janv. 2015 à 10:20, Manuel Spuhler <notifications@github.com> a écrit :
> >
> > Rien de modifié sur le fonctionnement actuel, juste un clean-up.
> >
> > Après m'être renseigné plus avant et avoir testé le code, NSURLConnection fonctionne sur le MainThread, sinon, effectivement le thread s'arrête faute de RunLoop associé. La façon de l'appeler est donc correcte actuellement. (Il y aurait une façon de lancer NSURLConnection sur un bg thread, mais il faudrait lui créer son propre RunLoop)
> >
> > Ce qui fait que ça ne va pas bloquer l'UI est l'attribution du mode NSRunLoopCommonModes.
> > cf. http://stackoverflow.com/questions/7222449/nsdefaultrunloopmode-vs-nsrunloopcommonmodes <http://stackoverflow.com/questions/7222449/nsdefaultrunloopmode-vs-nsrunloopcommonmodes>
> > Si tu es OK avec ce code, je peux continuer.
> >
> > D'après ce que j'ai vu, les images bloquent encore l'UI, mais pour le reste, il me semble que c'est assez fluide. Je peux jeter un oeil aux images si tu veux, ou alors j'attaque le crash des zeroed.
> >
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/pryv/sdk-objectivec-apple/commit/a0ed8f4aa371c46064abaf1cb4b7d015a54e51cc#commitcomment-9293469>.
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/pryv/sdk-objectivec-apple/commit/a0ed8f4aa371c46064abaf1cb4b7d015a54e51cc#commitcomment-9293973>.
>


Typowe dziecko Minecrafta ;)


HAHAHHA ZLODZIEJ XDDDD


helo -> hello


#cebula


We Will Make A Seprate File Which Will Download All The Device's Repos!!


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@Majkl578 now I see, parentheses are missing


Side-note: I do think we could also earn a few cycles by using vectors for paths. Unless I'm mistaken, I've seen nothing forcing us to use a list.


We are not sure at this point that this is actually a filename. It could be an unsupported log type.


Do you have a suggestion for a better message? I agree that it could be improved and that the log_type value should be included.


Yep, I was lazy, but since you started doing it already in the `boolean` branch , here it is now :-)


CORRECTION: Commit message should be Fixes #29


This needs a `baseurl` to point to the localised version


This looks right

@LWisteria
I need your full name for the ChangeLog

Thank you,
Ola


Ugh, this is a pain to review, as I want to check for naming conflicts. I wonder whether it could be made more mechanical, maybe replacing `_Foo` with `var_Foo`.


@there are still some issues with sockets in #159 that i do not understand


作者不更新了吗？百度地图最新的有19级，这个只能到18，咋办呢


Question: Is it working ok if deltax == deltay?


Oh okay.

But what indication can there be for values which never change in the C function? Should I just include it in the documentation?


> I've already seen a cannon fire from behind a wall and hit ^^

Too bad, I won't be able to cheat anymore, eh eh.


Weird in deed… I have no clue why it's happening. I will have a look at it.


when I touch it I want to improve it, so I check conflicts manually and sometimes there is conflicts, but harmless ( like last usage of parameter ). It was a lot of work even on my side :)


Thanks! Done in 9d5cc2540c5441f22cea2464ddfc0c017b131899


Presumably this and the instances that follow should be `page.baseurl` not `site.baseurl`


Unfortunately e.reason doesn't work when it is an HTTPError, for all version of Python, e.g. 2.6
https://docs.python.org/2.6/library/urllib2.html?highlight=urllib2#urllib2.URLError

Maybe its easiest to just use: str(e)


True! Shall I open an issue so we don't forget about it?


Nope it should not as the User object should not see system credentials


`CVehicleSyncData` and `CPassengerSyncData` are very different - does this really work?

Also, does this crasher work for `ID_UNOCCUPIED_SYNC`?


Then I would leave out "the file name may be incorrect or this is a bug"
and just say "Choosen logging type: ###" or similar.


Ah, yep


wtf


For instance, if you do this:

```scala
val train = data.toSeq.slice(1000,2000)
trees.fit(train)

val test1 = data.toSeq.slice(0,1000)
var accuracy = trees.predictEval(test1)
info("Accuracy = " + accuracy._2)

val test2 = data.toSeq.slice(1000,2000)
var accuracy2 = trees.predictEval(test2)
info("Accuracy = " + accuracy2._2)

// TODO: what is going on with the accuracy?
```

you get:

```
[info] - Standalone dla Random Forest
[info]   + Accuracy = 0.998
[info]   + Accuracy = 0.004
```

which does not make sense as the model should be almost perfect as the training set is the same as the second test set...


You could report the context's display name to help the user understand. Since they have view permissions on the starting context, it should be safe to assume they have view on the entire ancestors in path, so providing the full display name should not be a security issue


In this case `else` branch is not needed. No matter what the IF resolves to, you always return CACHE[key]['data']


One small issue :)


You may have fixed an action queue spamming root cause, btw. :D


I know that I have to change status_mask using. This is on my list.
The main question was and is for me the multi_topic .


And with this:

```scala
val train = data.toSeq.slice(1000,2000)
// ...
val test2 = data.toSeq.slice(1000,2000)
var accuracy2 = trees.predictEval(train)
info("Accuracy = " + accuracy2._2)
```

we get:

```
[info] - Standalone dla Random Forest
[info]   + Accuracy = 0.998
[info]   + Accuracy = 0.997
```


do we want to include this file given that it references scala samples right now?


Are the asserts correct?
Shouldnt you test for NullPrinter, ConsolePrinter and then again NullPrinter?


poskusil sem ga napisati navpično ampak je tudi v tem primeru zapis potlačen v državo zato sem da raje vrgel v morje


Misspelled Canola!


OO FTW. :)


is it 2.3.7?


nice catch


you are right, this is not completed, I will fix that in my next PR


hola principal


Kannst du bitte die Klasse `layered-flat` nennen? ;) Ist bei allen anderen auch so.


I just want to use Lock_File plugin with daemon named \QueueRunner\Daemon and without this str_replace is impossible because plugin make filename like "/some/path/QueueRunner\Daemon.daemon_lock" and this is not valid filesystem path.


Right, I can make it work this way. That's consistent with the "event status" dropdown.


That's great. I'll push that to Frank in Today's pull request ;-)


ok


Looks good :+1: !


lol


"nuevo" should be "new" here.


is "thisp" suppose to be "this"?
could that be the undefined js is complaining about?


already publishing the version including the fix... let's see how it goes!


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1876](http://teamcity.monogame.net/viewLog.html?buildId=4389&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


fixed


URL here needs localising.


yep ^^
But I've already seen in the logs that there are still creatures that do not move because they get out of the action queue due to spam. But I've not investigated yet so I can't tell more.


Old hostname, and also needs localising.


対応しました。

40b544204b1e5826b8bc54dd3e203534bcd776df : 数値をそのまま返すメソッドを追加 / テスト修正


Das Hochkomma, am Ende vor der Klammer, wurde versehentlich mit gelöscht.


r+


Thank you Abhinav.


Based on how it's used, "json_1" should be called "xvalues_json"  or something like that?

Same for json_2.   And perhaps for "currentSettings.value_1" and "value_2".


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/6484/testReport/) for this commit**


This should be localised in anticipation of existing :)


Missing checks before settings, this can be exploit


@prudhomm I find the problem, you have remove  this->generateDofPoints( M ); in buildDofMap().
For build the extended mpi doftable, there are 2 pass :
 - one for build dof only on interprocess (nothing todo with Pdh<0>(), and so dofPoint are never call )
 - one for build other dofs in extended elt
In this second step, I call explicitly generateDofPointsExtendedGhostMap which build dof points in extended element.
So when we call after dofPoint(),  hasDofPoints() is true and the automatically call to generateDofPoints is not done.

you have remove generateDofPoints because it take a lot of time? in // it's crucial!


In addition to the comments made in #156, I have also removed the ability for the user to input a CSR from the CLI.  Although I really wanted to support this feature as it makes sense for power users to be able to input their own CSR, it is impossible to guarantee correctness of all the components.  As @kuba and I discovered, there is no easy way within Python to read SANs in the CSR.  This makes reading the CSR from the client's view worthless.  I decided that dealing with them and all the possible error conditions was more trouble than it was worth.  The CSR is now generated immediately before the certificate request within the client.

This allowed me to remove the CSR parameter from obtain_certificates and replace it with domains.


Why `.fatalError` and not just `.error`?


what do you mean? The value is invalid so we fallback to ConsolePrinter here, that is the right behaviour.


I'll look at it. I'll point you at a fixup commit since there are 30 commits between this one and my HEAD I wont do this via rebase.


@Tourorist я просто добавил этот скрипт, т.к. без него миссия не запускается). Я ее запускал чтобы посмотреть работу side mission. Там тоже самое - any... хз из-за чего это.


Good work.


@stevenjack erm? `0.99.5` couldn't this be like `~> 0.9.9`? or just `< 1`


Can you propose a branch where first you revert the previous commit (you can simply do: git revert SHA) so that then it's clear what this commit adds?


> I do hope the std::find() in the for loop won't be bothering on a larger scale.

Yes, with many creatures, I don't know if it can become a problem. Most creatures have 15 tiles vision so the vector should be a little bit less than 15*15=225 tiles which doesn't seem a lot. And within the for loops, the tiles are erased as they are processed. But it is within a for{for loop...
For the record, the easy way to optimize would be to use a std::vector<std::vector<Tile*>> with the index of the vector being the X value of the tile (to not have useless values, instead of having gameMap::getMapSizeX, it could be from creaturePositionTile - sightRadius/2 to creaturePositionTile + sightRadius/2).
This way, we can access easily the vectors containing only Y value (which will not be big).

If you want, I can do that. WDYT ?


Probably we should keep the variables here in English, as accents in variable names not allowed.


> if this code doesn't affect widgets then I should put it only here
He is wrong because we get conflicts. The code should be exactly the same on both sides.
@PrzemekSzyszka please put the changes in widgets code, then generate file by going to /assets/backbone/application.js on widgets application, then replace contents of old input dependencies.


Same comment as https://github.com/mysociety/alaveteli/commit/44c57d25f2da01060753117d7f2df2ca8bbc6209#commitcomment-9294570


Danke für den Hinweis.


Where you set ScriptValue to 0 after setting it to 1 ?


Put one space between the method name and the first argument.<br>Prefer `skip_before_action` over `skip_before_filter`.


Space found before comma.


Unused block argument - `key`. If it's necessary, use `_` or `_key` as an argument name to indicate that it won't be used.<br>Space missing after comma.


Redundant curly braces around a hash parameter.
`Hash#has_key?` is deprecated in favor of `Hash#key?`.
Line is too long. [110/100]
Space inside { missing.
Space inside } missing.


Use nested module/class definitions instead of compact style.


Space inside { missing.<br>Space inside } missing.


Redundant curly braces around a hash parameter.
Space inside { missing.
Space inside } missing.


Regarding the cost calculation: I think the definition of connectivity on slide 38 contains a mistake. To me, it would make more sense to have Vj (or anything else than i) instead of Vi. For your example, this yields λ0 = 1, λ1 = 1, λ2 = 2 and λ3 = 1 and a total communication cost of 1 for the fanout.


this should most likely bee a volatile


Added support for 'hideable' elements such as iframes which need to be removed from screen readers access on popup + popdown, otherwise you can still tab to them.

Also added the css from jquery.a11y, which i forgot to include in the original pr. All up to day now. Merge a'go!


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1876](http://teamcity.monogame.net/viewLog.html?buildId=4389&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 359, ignored: 6 Build time: 00:16:23


muss ersetzt werden


see d71a146


Under what circumstances/configurations will this warning be printed and is there anything the user can do to eliminate the warning? (if they can't eliminate the warning then I'm wondering if it should be printed in the first place). Apologize if I should have been able to sort all of this out on my own from the original thread (re-read it and still am not sure).


Please use spaces instead of tabs. Your editor probably has a plugin for `.editorconfig`, that will apply the setting pr project ;)


@vincentchabannes could you make it optional ?
 -> in // must be done
 -> in seq on demand


После глобальных перемещений\переименований, у нас ломаются ссылки. Надо бы сделать один раз и оставить)


This actually breaks my layout. Interesting.


If I don't overlook something this change doesn't make much sense. The very same check is performed twice.


r+


DO:
===
* Basic backend setup
* Basic frontend setup
* Implementation of a very basic chat application between several browsers windows

TO DO:
======
* Add login system and user entity


The thing is that if std::abs(deltax) > std::abs(deltay), we have some kind of "horizontal" line (>-45° and < 45°). That means that to have all the tiles the lines passes on, we should increase x and check y value.

On the opposite, if std::abs(deltax) < std::abs(deltay), we have some kind of "vertical" line (>45° and < 135°). That means that to have all the tiles the lines passes on, we should increase y and check x value.

And if std::abs(deltax) > std::abs(deltay), we have a +-45° line (excluding x1=x2 and y1=y2 since we would be in the first "if" case) and the 2 ways are equivalent (we would have all tiles by increasing x or y).

So, yes, it is working ;)


Needs localisation.


PDF?


Oh yes they are! https://eval.in/242605 :bomb:

…but no, +1!


I can also confirm that this fix only works with a 1oz bottle of water only...
I guess the issue souldn't be considered as fixed.


За исключением «пользователей», это игровые правила а не правила форума, везде где мог от подобных пояснений уже ранее отказался.


Reverting this breaks --help.


Needs localising


We had to make some changes to `.multi-step` for Smart Answers, as it used it too, iirc so does licence finder.


Ok, I will do it


Subject line content probably should be translated.


This also prevents name conflicts. Bam!


Chez moi les blocs de code c'est des draw:frame suivi de draw:rect :'(


This change was for licence-finder. I already made the matching change on smart answers.


ThreadLocal DateFormat


Let's leave it for the further PRs as it is to be decided on how to implement this (via XHR or maybe File plugin).


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1877](http://teamcity.monogame.net/viewLog.html?buildId=4391&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Можно сделать отдельную категорию, как вот RW2, RW0.


Needed?


thank you


We came to the same conclusion (we've sent an e-mail to the assistant) and we have updated this in the latest version. How do you come at λ2 = 2? Can you check with the current version?


:+1: (Multi-step was a bit of a headache for me when i first encountered it.)


tests in coala are meant to define the behaviour. They are meant to cover most special cases and at least all statements if not all branches. This is also a way to ensure that everything is valid python code ;)


Ah okay I see, but not only for this sub-test-case but also for the ones above.
The second one instantiates a console printer but asserts a null printer.


Is there an official version with this change in?  I'm using Visual Studio with DevExpress' Devextreme for development and to use a 3rd party plugin it needs to be an official version.


r+ rollup


It does seem to work, but I'll level with you Kaelig, didn't try on Amazon Fire. I'll take a look today and report back


Ok, sounded like but just wanted to be sure adn have your ack. I usually add something like to show the matter has been seen:
```c++
 }
 else // if(std::abs(deltax) <= std::abs(deltay))
 {
```
Great, then. I'll test all that asap. :D


why java7?


Needs localisation


looks good!


This is by design. The retrieve_log_printer() function shall replace the current log_printer. In order to test the behaviour thoroughly I instantiated it with another log printer to assure it gets replaced even if its set to something else at initialization specifically.


Please create an example to show the difference. Pretty and normal mode should not differ in the result.


> Side-note: I do think we could also earn a few cycles by using vectors for paths. Unless I'm mistaken, I've seen nothing forcing us to use a list.

I usually prefer std::vector to std::list so if I used it, there must be a reason (that I don't remember). I would guess that either the list returned is somehow sent to some function that uses a list (less probable) or I needed to use front tiles (IIRC, that's not what vector is best at).

> Too bad, I won't be able to cheat anymore, eh eh.

If you've understood how to exploit this bug, you have my kudos ^^


I didn’t create tests for simple prefix cases :)


Maybe it'd be useful to add a LogHelper line to say that the file wasn't found and was ignored?


lol


As much as we can ^^


ok, I will add that


Ha Ha, you are right ! I did not visualize the Rf6 Kg7 Rh8 case. The Rh8 can potentially give 2 safe contact checks)
But in practice, this will not make a difference (the attackunits had already sryrocketed to max, so the end result is the same) or search will easily find a winning move).


Done in #439


To understand ...
The DLR libraries have their own repository? If so we (most probably only me) could create IR repository that will use the DLR repository?


I see, but this is a breaking change with big consequences. There are literally hundreds of places which use it in each service and shared libraries like Betfair's com.betfair.site.core.common. It will make the transation more difficult. I'll see what I can do, especially regarding the old shared libraries (some of them not updated since 2012).


Should there be a "style" type?


Should be updated to match faaa0e483c23bbdaaebf8e46f043448a59e288d7


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1877](http://teamcity.monogame.net/viewLog.html?buildId=4391&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 359, ignored: 6 Build time: 00:15:40


I am not sure it is correct to return from Root search without updating RootMoves. For instance that's the reason why we don't early return for a draw or similar:

    if (!RootNode)
    {
        // Step 2. Check for aborted search and immediate draw
        if (Signals.stop || pos.is_draw() || ss->ply >= MAX_PLY)
            return ss->ply >= MAX_PLY && !inCheck ? evaluate(pos) : DrawValue[pos.side_to_move()];

        // Step 3. Mate distance pruning. Even if we mate at the next move our score
        // would be at best mate_in(ss->ply+1), but if alpha is already bigger because
        // a shorter mate was found upward in the tree then there is no need to search
        // because we will never beat the current alpha. Same logic but with reversed
        // signs applies also in the opposite condition of being mated instead of giving
        // mate. In this case return a fail-high score.
        alpha = std::max(mated_in(ss->ply), alpha);
        beta = std::min(mate_in(ss->ply+1), beta);
        if (alpha >= beta)
            return alpha;
    }


I forsee some complexity around circular references is possible here (but perhaps not, I haven't thought deeply about it). A couple of ways around this:

1. Sometimes if I am absolutely certain that a referenced object will always have an owner in scope I'll use a naked pointer.

2. Alternatively to (1) You can use a `boost::weak_ptr`


Maybe put it under   [#outputhelp section](https://github.com/tj/commander.js#outputhelp) is better


Fixes Loop mode with fractional slidesPerView Parameter.


As it stands, this is including "es" in the breadcrumb trail, which I don't think we want.


Ok.


Also the breadcrumb trail is in English, which isn't ideal.


Yes, I missed it.


@bgrins,
Brian, you will see I have updated the typo and removed the commented-out optimisation. I can't find a way to reply directly to your third comment, about should this just go with WCAG 2.0 and abandon 1.0

As far as I am concerned, I will only be using 2.0. Whether you want to continue to support 1.0 is up to you. I left the capability there (and left it a the default) so as not to break things for any existing users who might actually want 1.0.


Because I didn't consider it. I will now.


This in combination with `if (typeof args !== 'object') { args = {}; }` below feels like a performance issue. There might be a faster way to determine of a parseable JSON string is an object than parsing every `args`


Sure


Should it not be #{layout}.map.yaml,
map variable is undefined, hence getting this error now
/opt/vagrant/embedded/lib/ruby/2.0.0/psych.rb:299:in `initialize': No such file or directory - environment/.map.yaml (Errno::ENOENT)


I did a crash test locally, to make sure we never return an illegal move. both at `depth=1` and using `tc=2+0.02`, no issue there. The point is that, even when we predict a fail low/high at root without searching anything (eg. Futility pruning child node or Razoring), the aspiration will loop until that does not happen and the score is within window, and bestmove will be updated.


Job pr-scala failed for 170232f8 Took 258 min. (ping @retronym) [(results)](https://scala-webapps.epfl.ch/jenkins/job/pr-scala/9477/):

To retry exactly this commit, comment `PLS REBUILD/pr-scala@170232f86a1ba01c745f963059d83153a180a7f3` on PR 4250.
NOTE: New commits are rebuilt automatically as they appear. A forced rebuild is only necessary for transient failures.


I think you can use $this->t() in Formatter classes. Some formatters in core are using $this->t() and some others just t().
Minor


On Wed, Jan 14, 2015 at 07:26:26PM -0800, David Vossel wrote:
> i think i'd feel better about this if we still undefined if the tmp file couldn't be created.

Well spotted. Updated now.


3yr ago when i come from cakephp to li3 auth i spent 3d to figure out why users.login wont work ;/


You also could add information about the Unit selected.
Minor


You should either set map  or env variable. Layout is differenthing, which is used to set system layout.


Ok but Q.getComponent already checks if the entity is null, Model.removeListener also checks if the target is null.


Its done! https://github.com/crossroads/app.goodcity/commit/b51e3ee496d405ff09f9056a923ef67ecd01ab4f
Thanks @mcm-ham


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1878](http://teamcity.monogame.net/viewLog.html?buildId=4394&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/6485/testReport/) for this commit**


char is signed. But our UA_Byte is unsigned.
Go figure.


In last GeoPHP and Geofiled implementations, you can use here \Drupal::service('geophp.geophp')->load($item->value). Probably your fork was created before this implementation were included.


Its done! https://github.com/crossroads/app.goodcity/commit/476eed1923599e4463ed7a21b44bc59fba2cc600


test


This test is supposed to test whether bumpversion works if invoked as a program (because the rest of the tests invoke `main` directly), because otherwise the tests all work and the software can't be used :) Learned that the hard way, hence, this test.


Why not `<p />`? It looks weird with those `<div>`s for each line separated by `<br />`.


missing volatile


in std::vector<Tile*> tilesWithinSightRadiusWork I guess. This means you could easily lower the tile find to the X coordinate. Yes, looks good. :)


asd


Because we start with infinite window until depth 5 and this code kicks in for depth < 7, it means only for depth 5 and 6 can be a chance to early return.


It would be good to have it in platform_flags.mk.
Can be done later on so that we merge this set of commits


SYGT GODT TÆNKT!


ÅHHH DAMN!!!!


Actually bench number is the same: are you sure the code kicks in sometime?


> If you've understood how to exploit this bug, you have my kudos ^^

I must say I've made a game or two where I placed creature to 45° angles on purpose near enemy walls where the walls would be crossed-diagonal to get some info on their inner rooms and halls. ;)

And placing the cannon not next to the wall diagonally but one diagonal tile farther usually worked when creatures were idling on the other side, like a traininghall or a dormitory. :>

I wanted to use that a bit on our next lan, eh eh.


This should fix (among other problems) issue #506. Thank you :+1:


> or I needed to use front tiles (IIRC, that's not what vector is best at).

Must be that but I'll check anyway.


The is actually only exposed for our own tests, but we'll make the change.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Thu, Jan 15, 2015 at 12:45 PM, Itamar Syn-Hershko <
notifications@github.com> wrote:

> this should most likely bee a volatile
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ravendb/ravendb/commit/c4318d069fb6491d010663f911a6fa24dc156c00#commitcomment-9294643>
> .
>


Ja, buildingcapacity.
capacity=-1 Gebäude geht nur bei vollausbau (Gebüudegröße >= maxsize)
In dem Fall ist die genau größe egal, und es dürfen maxcapacity Leute in das Gebäude.
capacity=0 Es passen keine Leute in das Gebäude.
capacity>0 Es passen capcity*size Leute in das Gbäude, aber höhstens maxcapacity Leute.
maxcapacity darf negativ sein, dann gibt es kein Limit.

Sinvoll als Default wäre also tatsächlich capacity=1 und maxcapacity=-1 für die Tests.

Bei den meisten Gebäuden wie der Akademie oder dem Magierturm die nur ausgebaut gehen ist in der XML config aber kein capacity angegeben. Das würde bedeuten das ein Magierturm der Größe 2 2 Personen aufnehmen könnte und auch einen Effekt hat, genau wie eine Akademie der größe 10.
Man könnte bei der Initialisierung des Konstruktors "Burgen" Defaults setzen, aber die Defaults im XMLRerader darf man nicht anfassen.


it doesn't has to be www, this one is working aswell:
http://es-es.twitch.tv/


this looks good


Learn how to spell you mountie twat


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3152
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3145
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3147
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3137
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3137
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3140
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3133
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3127
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2805
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2803
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1641
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1634


fast-forwarding master to auto = 1c78ad93


Anchor links like this one need to be updated with the localised heading text


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1878](http://teamcity.monogame.net/viewLog.html?buildId=4394&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 359, ignored: 6 Build time: 00:16:02


Ah okay sorry I missed the line in retrieve_log_printer () that takes the given setting and so not keeping the given instantion during construction^^
so never mind ;P


when Many to many thorough association is being used, `collectionAttributes.attributes[attribute.on].via` does not work, however `this.findAssociationKey(collectionAttributes)` does.
How about:
```javascript
  var associationKey = collectionAttributes.attributes[attribute.on].via;
  associationKey = associationKey || this.findAssociationKey(collectionAttributes);
```
as a temporary solution before proper associations are released.


http://jsperf.com/typeof-json-parse-str-object-vs-strpos

Proof of concept. There might be a faster way than to `JSON.parse()` every args.


See https://github.com/mysociety/alaveteli/commit/bd97b9600101580f772f8b159619d8cd5d4f2a91#commitcomment-9295165


Separate 3rd party module imports from presence_analyzer's imports by one blank line.


Если ты имеешь в виду поломанные ссылки на 77-ую в задачах, то да, это мой косяк (поправил все что нашел). Там в одном только случае сохранилась ссылка, так как указывала не на мастер копию, а на [конкретную ветку](https://github.com/TEHGAM/RW2/tree/f11a0b1b69f72fd6e050444c4c9494332577fb81/co40_Invade_Annex_2_77.Altis/scripts/DOM_squad ). Всё «master» ссылки, я к сожалению таким образом поломал.

Если бы я не переименовал эту папку в ручную. а использовал правильный набор git команд, то мы бы могли автоматически сохранить не только все внутренние ссылки но и историю отдельных файлов.


+1 for nice test method names.


I didn't have any problems with it although every device is different so what works for me may not work for you unfortunately.


Maybe it checks for an empty array.


Right, I forgot.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/6486/testReport/) for this commit**


OK. There's a downside that debugging does not work in IDEA for forked tests, but still I believe should be fork by default, unfork locally if needed


```
# They also accept many clauses and guards.
# Guards let you fine tune pattern matching,
# they are indicated by the `when` keyword:
f = fn
  x, y when x > 0 -> x + y
  x, y -> x * y
end
```
According to this, I guess you can do
```
deal_rule = fn
  card, {name, cards} when Enum.count(cards) >= 2 -> {{name, cards}, card}
  card, {name, cards}  -> {{name, [card] ++ cards}, :nil}
end


@sgrodzicki If you have a better translation, please send a PR rather than commenting on a 6 months old commit (such commits will be lost very easily)


corrected now in https://github.com/openpsa/grid.js/commit/217f75b75c52c236110c7029ed1d943f02738c57


saw approval from nikomatsakis
at https://github.com/eddyb/rust/commit/2c562999ddb99a3f819298afc303cf611381e293


merging 45 batched pull requests into batch


I created a model for images. User's profile_photo will be set to _id of this model, so user can query the db to retrieve image. We also need to setup different storage for images later.


Nevermind. To my surprise JSON.parse() is pretty fast!


it should kick in, but very rarely. if the first iteration where the wiindow is finite is such that eval-margin>=beta then it will prune and trigger the next aspiration window immediately, instead of searching anyway.

if it never kicks in as you suspect, isn't it all the more reason to remove the !RootNode condition ?


Euh je comprends pas, il n'y a qu'un seul p non? enfin kind e tp c'est un
algorithme, qui renvoit un p.

Par contre tu as raison, c'est pas la bonne propriété je crois. C'est
duuuur.

2015-01-15 9:06 GMT+01:00 Théo Zimmermann <notifications@github.com>:

> Tu te trompes. Si aucun p n'existe qui satisfasse kind e tp = Some p, tu
> peux choisir n'importe quel p et la propriété sera juste. Le vrai
> problème c'est que même si un tel p existe, on pourrait aussi choisir
> parfois une valeur qui ne convient pas, de sorte que la propriété ne dit
> rien d'intéressant en fait.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stratSystemF/lambda/commit/60fdf71c40ae425c27463ef527cca50933f7d714#commitcomment-9292594>
> .
>


Debian Whezy (7.7) is ignoring both options. _locale-gen_ command reads from file _"/etc/locale.gen"_ the locales to generate and it calls _localedef_


Sort imports alphabetically.


OK


actually this was safe the “repo: github/fetch” will prevent it from deploying :)


Sure


Done


Fixed.


Debian Whezy (7.7) is ignoring both options. _locale-gen_ command reads from file "_/etc/locale.gen_" the locales to generate and then it calls _localedef_


Sorry it is fix for issue #3387 .


This does not really fix it: The code should be sth like:

Runnable r = <...>
if(isEDT)
   r.run();
else
 invokeLater(r);


No, it wasnt. Just fixed it.


@plopesc Thanks for the review!


@scunz Unless you didn't see it: The "columnCount() - 1" is the important change here.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/6487/testReport/) for this commit**


Well, first if never kicks in then we _should_ add !RootNode for performance reason and because is unreachable code.

But more i think on it and more I find difficult to understand. Namely in root TT is saved as BOUND_EXACT so eval is set at ttValue:

        // Can ttValue be used as a better position evaluation?
        if (ttValue != VALUE_NONE)
            if (tte->bound() & (ttValue > eval ? BOUND_LOWER : BOUND_UPPER))
                eval = ttValue;

But in this case, becuse ttValue is also root move score and becuase aspiration is build upon last root move score, we should always have alpha < eval < beta and the code never kicks. Isn't it?


Side note: Qt does the assertion for us.


The output of _psql --version_ has two lines (at least in my PostgreSQL version), the _pgversion_ var is created wrong and _pg_createcluster_ fails


Hi! The first part of this commit is good, but i cannot see the advantage of the second part. This script already receives an output path as an argument for the re-signed IPA.


You already know here, that date.weekday() is not in dict. You can just set the key like: result[date.weekday()] = {'weekday': ...}


readme


TeamCity Hyrise :: Unit Tests [Build 63](http://ares.epic.hpi.uni-potsdam.de/hyrise-build/viewLog.html?buildId=71&buildTypeId=Hyrise_UnitTests) is now running


Does this have any effect? I don't think it should.


what if that TT entry gets overwritten?


You can also write this as `if date.weekday() not in result:`.


np

2015-01-15 12:34 GMT+01:00 Makman2 <notifications@github.com>:

> Ah okay sorry I missed the line in retrieve_log_printer () that takes the
> given setting and so not keeping the given instantion during construction^^
> so never mind ;P
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/sils1297/coala/commit/426ca19c91f24dfaf24f51ef14bfcf583567b85a#commitcomment-9295167>
> .
>


r+ rollup


there is rcepmd stop.. does it not work?


Oui, il n'y a qu'un seul p. Ce qui veut dire que pour toute autre valeur de
p, la prémisse n'est pas satisfaite et donc la propriété est trivialement
vraie.


You can initialize those two variables on one line:

`
start, end = items[date]['start'], items[date]['end']
`

I'm curious if pyCharm would pick up the annotations then.


I have some more name space clean-ups so will push and merge with this commit later.


hey i will look into it later


anchor needs localising.


Wow, what a big update :) I wanted to test it just to see what you have done, but the common.a65 is missing :(


If there are a lot of imports from one module, you can write them as an expression on multiple lines:

from x.y import (
  1
  2
  3
  4
)


Not. :-(

How do we fix this?


It might have been easier to overload the createNewOrganizationalUnit method; with parameters: String organizationalUnitName, String organizationalUnitOwner, String defaultGroupId and have the implementation of the 2 parameter version simply call the 3 parameter version with null as the defaultGroupId.. that way you wouldn't have had to change every AppSetup, only the OrganizationalUnitManagement screens (and we wouldn't need a magic "null" value in the method calls)... my 2c :)


TeamCity Hyrise :: Unit Tests [Build 63](http://ares.epic.hpi.uni-potsdam.de/hyrise-build/viewLog.html?buildId=71&buildTypeId=Hyrise_UnitTests) outcome was **SUCCESS**
Summary: Running Build time: 00:03:49


These anchor links need localising.


What is `.grouped-2` class used for? Its purpose is not very clear ^^'


Yep, there is -> flexibility. I did not analyse the updating algorithm yet. As you know, the "firstRow, lastRow" parameters make it possible to update a range of model indexes in one go - which can be faster. The current algorithm is likely to miss "item populations" in certain situations. To see it, just take a bigger repo, like libgit2 e.g. and scroll down using the keyboard. The detail/diff view is sometimes empty for the bottom most selected item. :warning: *This may hang your computer!!*


super, sollten wir in Zukunft bei allen sachen machen, oder?


These anchor links need localising


Did you just forget valueText and formNamespaceAndPath?


anchor needs localising


Thanks @psquickitjayant I will soon commit and push an alternative approach.


denke schon.  aber ich bin da kein experte


Fixes #47


I downloaded the official patches w6patc11.zip and w6patc12.zip, which update 1.0 to 1.1 and {1.0,1.1} to 1.2. They both contain GAMEMAPS.WL6 and MAPHEAD.WL6, with different contents:

```
05ee51e9bc7d60f01a05334b1cfab1a5  w6patc11/GAMEMAPS.WL6
accc0231d871a4350da4374d87b57d88  w6patc11/MAPHEAD.WL6
a15b04941937b7e136419a1e74e57e2f  w6patc12/GAMEMAPS.WL6
42c7b607a33be82143e6525d481b8beb  w6patc12/MAPHEAD.WL6

4125294541 150746 w6patc11/GAMEMAPS.WL6
996628160 402 w6patc11/MAPHEAD.WL6
1031424741 150758 w6patc12/GAMEMAPS.WL6
2597251681 402 w6patc12/MAPHEAD.WL6
``

So yes I'm sure I labelled MAPHEAD.WL6_1.2 and MAPHEAD_WL6_1.1 (and the corresponding GAMEMAPS) correctly.

From the contents of those patch zip files, I infer that your vswap.wl6 etc. are actually unchanged from 1.0, but are not modified by upgrading to 1.1 or 1.2.


wer oder was ist schon ein experte? :)


新建项目


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10048/testReport/) for this commit**


Actually, we can leave it this way now. It goes from 0.4 to 0.4.1, which should make it build on arm. Doesn't include any of the recent patches from Ed.


Did you intentionally drop description?


Thanks @LiamKarlMitchell


sorry about these three commits, I don't know what happened but git wasn't having any of it


for performance, what matters is to not pollute non-root search with root stuff, not the other way around. there's only one root node and millions of non root nodes.


这个依赖怎么去了


Anchor needs localising


Doh. Will check.


We are just starting the search at that point....overwitten when?

On Thu, Jan 15, 2015 at 12:49 PM, lucasart <notifications@github.com> wrote:

> what if that TT entry gets overwritten?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lucasart/Stockfish/commit/e1bd41f972513a8bc562277a5eb817891850c844#commitcomment-9295383>
> .
>


memoState will never be 9 here, since the previous if catches it.


@petrjasek @amagdas is it good description?


这个文件是做什么的


Anchor needs to be localised


Anchor needs to be localised.


Done


This case looks a bit weird, not even a cond or item check here?


Yes, that's clear, let say for code documenting (and it really deserves
documentation because, as we see now, is very tricky and difficult).

On Thu, Jan 15, 2015 at 12:56 PM, lucasart <notifications@github.com> wrote:

> for performance, what matters is to not pollute non-root search with root
> stuff, not the other way around. there's only one root node and millions of
> non root nodes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lucasart/Stockfish/commit/e1bd41f972513a8bc562277a5eb817891850c844#commitcomment-9295481>
> .
>


Diagram 클래스를 상속받은 클래스가 인자값의 순서에 상관없이
들어가 있어도 작동한다는 것을 증명하기 위한 코드 조각.

HitBox 또한 Rectangle 로의 형변환을 통해 완벽하게 동작함을 증명함


double (( ))


anchor needs localisation


Duplication removed


:+1: Thanks, I should have searched the project for user:


looks ok, but this needs at least manual testing


OK


so my remaining old files `v*.wl6` and `a*.wl6` are v1.0 actually


Thats my point.  Why guess at who is doing it.  Just look and decide which formatting style to go with.  I can tell you that Diego sends a SourceID for everything, not just App and Health.  While not useful for developers, its definitely useful for Admins to be told that my App on Cell/4 failed rather than trying to figure out where it is.

I did something like

if sourceID == "" {
  logHeader = fmt.Sprintf("%s [%s]", timeString, sourceName)
} else {
  logHeader = fmt.Sprintf("%s [%s/%s]", timeString, sourceName, sourceID)
}


ok，我们会完善好现在已有的各类分享。

另外可以按照 https://github.com/aosp-exchange-group/fuck-2014-flirt-2015/blob/master/1/common.md 改下你的格式


`<멍청한 함수>` 개선이 필요한 소스 조각


Please check my fork (dev branch).
This code is over complicated, store is a python dict so why not using its methods like copy?


cc @eventualbuddha


any reason not to submit this as a PR upstream?


saw approval from nikomatsakis
at https://github.com/eddyb/rust/commit/2c562999ddb99a3f819298afc303cf611381e293


merging 45 batched pull requests into batch


@bors: retry


status: {"merge_sha": "05d69d9dd30c678912573b282a90b0c74ff2282f", "rollup_pulls": [[21077, "2c562999ddb99a3f819298afc303cf611381e293"], [20463, "9f5fc563d3d592d5e44ab71759ffa26d326b3daa"], [20632, "4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d"], [20892, "9302dc5d9e13f716a21a5d9ebdcddc149a864b19"], [20929, "eabf2082856668c75ed6f7c229b24fb7755440bc"], [20964, "78b7e13bf02e59ad05a9d15725e3c36e9dcf7187"], [20976, "415fc5f0f10b6180193ecd309b21ae80a1efa6a9"], [20985, "11737a3e1d5080c10f1ca366a12cf8fed7941d49"], [20986, "a3d87fa448de23d9d2faaf6f68803e5925653244"], [20988, "8eba032f52a0b16b39a94267b4884f361e022c36"], [21001, "e1ff480e433697ae546e2cedebf659dc1b19572f"], [21005, "933303413e4fe97dbfd7e7f0a6f26dfb077696e8"], [21011, "ba9e223c57de82fbdb4da1446de570e028477aec"], [21013, "c403794310814d2d83e80f2f10308195505b48be"], [21014, "285277dd804e8e380dde764a00c97a721b4ef976"], [21015, "be407180d726f0121ccce9a7439f14de1731435c"], [21020, "e485d297ea6e882725c3d5b510183a3f8d816530"], [21023, "95f9e309f7307ace9218307f943f29662e21a1e5"], [21028, "425f449fdacb72f98a3e7c4326997b09b9b9a127"], [21029, "b704983ee925dff219ecc5b8e7dd2ba9fec64c1f"], [21031, "db7de969cfb50587475185e25bd09b7e73cafe83"], [21036, "d6e67e938bfce049432b3084787c055911b76f5c"], [21038, "2297b0cb0028965a2ef1d6a5de3d4c2dbe172825"], [21040, "16a8c4d2382d72aa414d89192422187acd290270"], [21041, "d7999d4041875ad4e9d16f400342301ee2eab081"], [21046, "599232503a7959faafa21bc8b38ca98f4b28e536"], [21054, "71884601f955c67b055fad8351074eae4f849769"], [21059, "6a7f0a99d8005187736c3c26c5cc2d538a42590f"], [21066, "323abc0eb0e99d445a38aa4fc0da93f5791ff492"], [21071, "9af8a646a964985fe42a91ea34672266c91ae295"], [21075, "31ac1fb93df9b9a2db332f055052dbfb779bdf91"], [21103, "1217007c8335ec2b3097583ff3e0ad15a35af26e"], [21105, "07f723f19bdf1054d140fc713f72f04a2f1b4258"], [21109, "ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1"], [21110, "806c13589a319292849443d4b8ad44d2edc78cbf"], [21120, "6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1"], [21124, "40219249cf87585023e0d1b44de261dd56752142"], [21126, "fb556288737ececbc12b177b45a0717ff4dd5b66"], [21133, "5a16ceb291fd1b021efc342e3058c0f1ce534778"], [21141, "428da78de10310744a33b5e5b7d85e1a11e8e7ed"], [21148, "bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc"], [21172, "e5ad89d176004931d7ffbf87e7c23bc71fc7418a"], [21190, "f99d43ecc0d043350d38e44b86f33900a8391491"], [21191, "2c71adaaa21e5d9e4fe80625e41982ac83303df8"]]}