Inside of `PraxisMapperPlugin::Statistics.log(identity_map)`, it also checks this value in a `case` and does nothing for 'skip', so I think we're good.


Minor, but a bit more elegant:

```Java
int highScore = gameInfo.getHighScore();
initializeState();
gameInfo.setHighScore(highScore);
```


Yes, it will become an undocumented method which happens to have public visibility, just like many other internal methods inside of Rails.


ddd


Thanks, @justinvp.  Seems like we should open an issue to improve the test coverage a bit, but otherwise your change looks good.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1867](http://teamcity.monogame.net/viewLog.html?buildId=4369&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


We need specific messages for each validation, so the user can know what is wrong!


deep_merge is aparently in activesupport. We could probably get away with just merge here, but side-effect would be that repositories passed in from the app would completely override whatever was specified in the config/praxis_mapper.yml file. Probably okay, though?


`digestNums`


Doh! Thanks...


Why did this work?


These single test lines seem to be essentially the same, and if I'm not mistaken varies a lot based on setup. I'm not sure how useful they are as is. Is there somewhere that goes over installing both versions on the same system?


You had the previous one in the head of the page, before the DOM was loaded.


84695188_CoverageFinalImplementation (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.89%25-green.svg)


Well if you don't need it you can omit it.


The same.


Que paso compa si le viste !!


This would be easier to follow if you put in an "assert" so:

`check i j = liquidAssert (i <= j) ()`


Hmm. This would be easier to follow if:

    check i j = liquidAssert (i <= j) ()


Thanks. Fixed in v0.2.12 (c4ebb79d03565959592ea9f95f1596bdc7c627e3).


> Just to verify, you've confirmed that these fields on RegexCode don't change after the RegexCode is passed to the RegexInterpret ctor, right?

Yes, I've verified: these fields don't change in `RegexCode`.


Made widths equal. The visual artifact was due to the padding of the input pushing against the container.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1867](http://teamcity.monogame.net/viewLog.html?buildId=4369&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 359, ignored: 6 Build time: 00:15:21


I think this is correct but it's very confusing to look at.


Something like "Version of Realm file on disk is higher than current schema version".


If the user doesn't set a schema version it's 0, so I don't think this is hittable other than explicitly setting the version to RLMNotVersioned.


On Wed, Jan 14, 2015 at 08:40:10AM -0800, daurnimator wrote:
> Did you mean/want to tag this as a release? Or is this just a way of tracking daily updates?
>

I'll try to tag a release soon. But I need to fire up my VMs to make sure it
compiles and runs everywhere, check the code with the clang static analyzer,
and execute my example and regression scripts inside Valgrind.


After all thanks for great tool :100:  so this is my first comment in Git !
i have same problem before and i found in Google  using this address 127.0.0.2 solve the problem  ;)
http://i.imgur.com/qEM5uMU.png


The self should already be in the inner function closure, otherwise we would get a lua undefined variable error. The `"Game object has been destroyed"` error comes from `moho` when it realises that no C-object exists for the lua value anymore.


Ola people


Is this equivalent to `dokku deploy` in this case? Should we keep a stub method where `dokku deploy:all` points to this, similar to how `dokku url` works?


This has no effect so the next line fails with `./configure: No such file or directory`


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Nice work.


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I am not sure that this refactoring preserves the behavior I intended, though I concede my tests were not comprehensive enough to demonstrate that behavior.

My intention was that you could specify an ordinal without needing to start from the front or back. For example, if you marked a single test as "third" without specifying a "second" or "first", it would still be the third test to run (assuming there were that many tests to run).

Could you back out this one part of the refactor? I will create a ticket for testing the behavior I intended.


\o/


ok


Thanks Chris, you rock!


fixed!


Prepending the command with `cd bindfs-1.12.6 && ` fixes the issue cited in my comment above.


Header does not exist.


XML comment for the member variable does not exist.


Indentation is different.


Those two should be swaped


Please unify the processing method.
Please Use SetSqlByFile2 method.


I'd say no to most of those being in randbats.

Pikachu, Porygon2, Chansey, and Scyther, yes.

The others, no.


You either need to double escape or use raw strings for the periods


practice of push.


@lebauce i just noticed that this is calling C.rbd_get_features rather than C.rbd_get_overlap. The same is true for GetStripeCount and GetStripeUnit. Do you happen to have a fix for these?


Many DLL has been added.
But, please do not add the DLL.

There is other files that should not be added.
If gitignore file exists on local, these files can not be added.


Just curious, does the Altar of Corruption have a light level?

Also, the language files need to updated for darkstone.


I did update the Lang. No the altar doesn't have a light level


Once again /cc @Krinkle


Great catch!


Isn't this the same as the if condition?


@sontek, how come did you found about my changes?
Anyway, pyramid-celery==2.0.0-rc4 looks good and finally works nicely under Python 3.
No more `pcelery*` but `celery` commands so that's something to check for in my scripts.
Thanks for the update and cool heads up!


@pepol "for a long time"


I try not to be late :) I mostly work 2/8


This isn't quite right.

FetchAll is sent whenever a new connection is getting marked as 'established'. That is later than initial handshake completion. It also applies to not just new peers but any connection establishment.

Furthermore FetchAll is also sent periodically.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10064/testReport/) for this commit**


can this be replaced by an interface here? ```IApiResponseMetadataProvider``` ?


thanks for the fast review. i'm going to merge then.


trailing ws was not even cool in the 70's.


This patch only works with bash. With other shells (zsh, ksh) `command -v ${U}` will fail and print the error.

But it shows another bug, which is that `${U}` should be quoted in both places, not just in the for statement. That would totally defeat your purpose. But trying to shoe-horn a compound statement where the code expects a single command name or path was never going to work well.

Why couldn't MACOSX_DEPLOYMENT_TARGET be set before or during the invocation of make, rather than trying to smuggle it in via the backdoor of CC? You should be able to just do `make MACOSX_DEPLOYMENT_TARGET=10.5 all`, and make will export the variable so that it's visible from the environment when the target rules are executed.


The custom code templates/renderers? :)


removing starved packet from the queue as openudp it is not taking care of it after delivering to the app. thanks to Alex Kostopoulos for catching this.


"checke" i think "überprüfe" fits better


Update item-data.xml for Minecraft 1.2


@hanula I like to watch the forks of my projects to see if there are features I'm missing that others would like.

I've just upgraded all my projects to 2.0.0 and its working well so I just want a few more people adopting it to verify and then I'm going to push the stable release


Ha-ha!


would this work? wouldn't contains do reference match?


So why aren't you enclosing this as part of the cgroup interfaces instead?

Adding these individual calls cause fragmentation of the policy.


Maybe change the name of the method since it's not just for tokens something like publicAdapters(String apiPublicKey)?, once ccvs support is added HINT HINT


Sorry,

My mistake.
I will add the proper authority.

Thank you.


Yup, left a stray lda in menu.a65 L505. Poor little thing. :( The assembler should just omit the code and be fine. Fix is upcoming ;)


Great, keep up the good work.


What, how did I miss that?!


@gvas how did I not know that before!!!!!!!!!!!! Thanks so much for this!


The current /static directory disabled all CSS on the /admin site. I have temporarily fixed this by removing the /static directory and all corresponding CSS to resolve the issue.
A new /static directory will be added and modified accordingly, once I learn the ARC way


:beer: :beers:


I'm still a bit confused why this needs special-casing though. You use the fact that it's either `date` or `date-time` element to determine the property type. This is true for all date properties, and not just `DTSTART`.


Links are always nice :smile:


Just arbitrary unique-ish strings, so that if a test fails it's easy to locate (the `test` function will print out the string).


This was mainly a reminder when I was learning how to use virtual environments


I'm not sure what was the meaning of "polymorphism" here, but since it's never mentioned or showed again in the chapter I figured we could drop that in order to avoid confusion and dangling things. :)


I see, thanks!


COOL. caps is definitely easier to read!


love it.

 -sb

Scott Brackett
Short-Term Programs, System Support Specialist
Texas School for the Blind and Visually Impaired
1100 West 45th Street
Austin, Texas 78756
512.206.9460

On Thu, Jan 15, 2015 at 2:01 PM, Nathan Livni <notifications@github.com>
wrote:

> thanks for the fast review. i'm going to merge then.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Unpaid-Intern/choices_choices/commit/e829e513bbd5222f510873c13a320c04e7adc10f#commitcomment-9303961>
> .
>


but once you want to return two objects you would need to change the interface anyway to return a different kind of object... wouldn't that be the time to rename it?


thought about new cards the user might want to specify without control of the library, but sure that could work too.


Since macros are still unknown at this point in the guide, I think it's better to just let the users know that they have to use `defstruct` only to reveal that `defstruct/1` is just a macro that you **call** in later chapters.


Will this impact openfl?


This is the error I get with Elixir 1.0.2.


p.s. I'll be setting fire to my local git repository tonight and cloning
from the remote afresh.

 -sb

Scott Brackett
Short-Term Programs, System Support Specialist
Texas School for the Blind and Visually Impaired
1100 West 45th Street
Austin, Texas 78756
512.206.9460

On Thu, Jan 15, 2015 at 2:08 PM, Scott Brackett <bracketts@tsbvi.edu> wrote:

> love it.
>
>  -sb
>
> Scott Brackett
> Short-Term Programs, System Support Specialist
> Texas School for the Blind and Visually Impaired
> 1100 West 45th Street
> Austin, Texas 78756
> 512.206.9460
>
> On Thu, Jan 15, 2015 at 2:01 PM, Nathan Livni <notifications@github.com>
> wrote:
>
>> thanks for the fast review. i'm going to merge then.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/Unpaid-Intern/choices_choices/commit/e829e513bbd5222f510873c13a320c04e7adc10f#commitcomment-9303961>
>> .
>>
>
>


Oh boy, am I glad to see these go!


Changelog updated, thanks!


while trying integrate the json config to sunset and lighton I discoverd a design flaw:
The `config.json` contains the `irsend` or `powerpi`(`Net:Http.get()` call) command as a string. `jane.rb` and `lighton.rb` run a `system [command as string]`, but since the `Net:Http.get()` commands are ruby not shell the shell has no idea on how to process the command.

IMHO: Issue #39 needs to be implemented before issue #38 can be implemented, without a dirty quick fix.

@Lyr3x Please comment on #39 asap :)


My thought was the other way around... if you are building an interface, you would want to list them out


It can be done with some more tricky macros.  Basically you detect and remove the parentheses first, then do the stringising:

https://github.com/Y-Less/YSI-Includes/blob/e1a06e2c57caa64e0832d87d9bf7096af80e094c/YSI_Core/y_testing.inc#L120-L129


¯\_(ツ)_/¯ either way!


Dude... you can set these in `~/.tugboat`.


Just wondering - why is it important that "then" is only accessed once and not several times? (I understand it should be executed once that's not what's asked)


you compare them as lowercase, but you don't lowercase the configured ones. should be:
.....asScala.toList.map(_.toLowerCase)


Also you should change label to "San Francisco" for the region (3).


There is no bounds checking here. When minetest is compiled with ```-fsanitize=bounds``` then I get a runtime error:
```
src/mapblock_mesh.cpp:343:7: runtime error: index 34 out of bounds for type 'const u8 [32]'
Illegal instruction
```


Does anyone see a reason why this shouldn't be merged? @akitchen


Hey there. Maybe `dry_run` is set to true? If that isn't it and you're still having problems can you open  new issue? Thanks.


The commit message should indicate why this is desirable or necessary.


Removing this breaks redirects from the loginAction as in this use case
http://stackoverflow.com/questions/25001558/zfcuser-redirect-dynamic-url-after-login
Now the redirect parameter passed to the loginAction is totally ignored.
How is supposed to work now?


This entire if can be re written in a more efficient manner.
```c#
var produces = context.Filters.FirstOrDefault(f => f is IApiResponseMetadataProvider);
if (produces !=null && produces.ContentTypes.Any(producesContentType => producesContentType .IsSubSet(contentType)))
{
}
```


nit:remove extra line.


I disagree with this one, despite the name readPtr and writePtr aren't pointers !


nit: remove extra line


Yeah I know. But tugboat's defaults no longer work, looks like digital ocean changes their default image ids every now and then. Also, in their GUI they indicate that New York 1 is overloaded, so New York 3 is set as the default. The new default region should actually be 8.


@brycedrennan https://github.com/cenobites/flask-jsonrpc/commit/723db17b1ef11d15d4180fd0e372b9a51723f4e4


No, I think we're all in agreement here, I simply haven't had the time to give it the attention it deserves. Thanks for taking care of it.

On Thu, Jan 15, 2015 at 12:17 PM, Wiley Kestner <notifications@github.com>
wrote:

> Does anyone see a reason why this shouldn't be merged? @akitchen
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/joemasilotti/PivotalCoreKit/commit/abd4306052db98ac34416db3075b43f7dcccf8c1#commitcomment-9304198


I think blue would be better


Damn.

should I remove this commit? or is it still 'correct' (yet useless)?


No need to define pointer. Strings are allocated only once, so using "%c = %d %d %d" in multiple places won't create any overhead (and is easier to read)


this can be `experience ||= 0`


Issue Nummer6 exestiert nicht


$lang['welcome.hello'] = 'Witaj!';


[![](![](![]()))]()[[[]()]()]()hi. Hehe


should run the same set of tests again to make sure that the stuff from the first registry was not removed when adding a second registry


Right...I'm building up to that incrementally. The plan is to show:

1. Eureka-only as a remote load balancer
2. Access Ribbon directly for local load balancing
3. Use Ribbon-enabled RestTemplate
4. Use Ribbon-enabled Feign


Nice one.


rax retry tests


Why?


This is not related to the battery charge prefix but another bug I encountered.

If, for some reason, ```'/sys/class/power_supply/' .. adapter .. '/online'``` path didn't exist, the widget wouldn't render at all, leaving just an empty space in its place. With the fix on ```acpi_is_on_ac_power``` and the added ```acpi_battery_is_present``` function, an widget empty widget is rendered correctly even without the presence of a battery or an AC adapter. In this case the widget renders like this ![assault](https://cloud.githubusercontent.com/assets/142770/5765822/45af4d8a-9d05-11e4-837c-819c22cd0e05.png).

As a side-effect, this allows me to share my configuration between laptop and desktop without changes.


sweet, carry on


Hi Sarah...ignore this comment. We're just testing. :)


reserved words or restricted words when they are allowed.


you are right... I forgot to put it back to 0. I had originally changed all of them to NULL until I realized they were actually not pointers, and then changed them back to zero but forgot that one. sorry


Ahh, sorry, did not even see this. Would probably need to add pause, tryPause, on the Download as well...


With this change, `console` will always be set to the dummy object. Simple test:
```
class Test
{
	public static function main(){
		trace("ok");
	}
}
```

Compile and run it in node:
```
-main Test
-js Test.js
-cmd node Test.js
```
nothing will be outputted.

The reason is again var hoisting: `var console = ...` will declare `console` as `undefined` before the statement itself.


To je hrozný názov :D Možno `process` (príp. `process_logfiles` alebo čo for disambiguation)?


my first solution was to add the error handler, but both error and close are called, which causes google-chrome to launch twice if chrome fails.
I have removed the close handler and it appears to work for me.


Sorry, no initializer lists in 2012. :(


Finally, this version could produce the same results comparing with Zixiang's results. But one more thing is about the background interaction mentioned in Zixiang's email. I don't know what's that. In this code, we don't include other "background" interaction except for Coulomb interaction or Hard core interaction which is an artificial interaction.


Looks cool, good work


all over the PR


Why not just wget the file?


docs


+$lang['mailer_disabled'] = 'Usługa E-mail nie została aktywowana.';
+$lang['mailer_disabled_error'] = 'Przepraszamy, usługa e-mail nie jest aktywna. Wiadomość nie została wysłana.';
+$lang['mailer_error'] = 'Przepraszamy, twoja wiadomość nie została wysłana z powodu przyczyn technicznych.';
+$lang['mailer_a_message_has_been_received'] = 'Wiadomość została odebrana.';
+$lang['mailer_a_message_has_been_received_from'] = 'Wiadomość od';
+$lang['mailer_your_message_has_been_sent'] = "Dziękujemy! Twoja wiadomość została wysłana.";
+$lang['mailer_confirmation_for_a_received_message'] = 'Potwierdzenie o odebranej wiadomości';
+$lang['mailer_confirmation_for_a_received_message_from'] = 'Potwierdzenie o odebranej wiadomości od';


precisa usar como referência? qual a necessidade?


use TryGet everywhere.


The commit message should indicate what the benefit is. We're taking on a new license, and I do not think that it is to fix a bug.


Done, thanks :)


It would print on a new line in log, but it would be immediately be followed by another log message on the same line.

Example:
Tty:
Error error balbla![somethread]Error: _stat failed!


na pierwszy rzut oka wygląda dużo lepiej


Have a look at targets/linux486/host_linux or targets/linux486/host_macosx about an alternate way of adding O3 support by platform. You need a LOT of memory to compile everything O3, which is why we didn't enable it by default.


Just useless (probably a shell typo which have created the file) - To be removed :)


remove.


Well, it focuses on improvements only when the formatting operation ends up making a single call to `write_str()` on the `fmt::Writer`. Though it does have the potential for better edge case behavior, e.g. when the final format piece causes the `fmt::Writer` to reallocate, my approach allows it to allocate the exact size.

Ultimately, the idea is that, if the format destination is going to `shrink_to_fit()`, then we want to avoid overallocating in the first place if we can do that without requiring advance knowledge of the sizes of subsequent format pieces.


4558_hpwh_coil_removing_heat_from_tank (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.33%25-red.svg)


Nice!


Yes, I like that idea better, no need to comment.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Thu, Jan 15, 2015 at 7:40 PM, Federico Andres Lois <
notifications@github.com> wrote:

> Mhhh thinking out loud... What if we add in MemoryUtils a BulkCopy and
> that calls StdLib.memcpy ... with AggressiveInlining we wont see any
> performance issue and we can use that one when we are mostly sure that our
> memory is going to be big. There we can actually afford the switch.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Corvalius/ravendb/commit/3ac88165509fb10f2b645629c41d0c0ca9c9db6d#commitcomment-9301572>
> .
>


+$lang['contact_send_us_a_message'] = 'Wyślij do nas wiadomość';
+$lang['contact_subject'] = 'Temat';
+$lang['contact_message'] = 'Wiadomość';
+$lang['contact_send_message'] = 'Wyślij wiadomość';
+$lang['contact_our_location'] = 'Nasz adres';
+$lang['contact'] = 'Informacje kontaktowe';
+$lang['contact_name'] = 'Nazwa';
+$lang['contact_first_name'] = 'Imię';
+$lang['contact_last_name'] = 'Nazwisko';
+$lang['contact_person'] = 'Osoba kontaktowa';
+$lang['contact_organization'] = 'Organizacja';
+$lang['contact_address'] = 'Adres';
+$lang['contact_map'] = 'Mapa';
+$lang['contact_location'] = 'Lokalizacja';
+$lang['contact_email'] = 'E-mail';
+$lang['contact_phone'] = 'Telefon';
+$lang['contact_fax'] = 'Fax';
+$lang['contact_web_site'] = 'Strona WWW';
+$lang['contact_facebook'] = 'Facebook';
+$lang['contact_twitter'] = 'Twitter';
+$lang['contact_google_plus'] = 'Google+';
+$lang['contact_linkedin'] = 'LinkedIn';
+$lang['contact_github'] = 'GitHub';


Why do you create a new Uint8Array from Array? You also ignore `offset` and `length` arguments to the function, which are supposed to indicate the start and the length of input we need to hash.


This shouldn't occur. Could be another bug.
Even if it's so, why not "\n%s\n"?


The current de facto standard is to use UTF8 encoding for strings feed into hash functions. Since you use `charCodeAt`, it will only correctly work with ASCII, producing incorrect results for multibyte string (e.g. "строка"). The correct way to do this, is decode string from UTF8. You can see an example of such decoding in the `demo` directory: https://github.com/dchest/blake2s-js/blob/master/demo/index.html#L35.


`isMod = isAdmin || checkMod(to, from.userName)` ?


parenthesis?


ipak nije popravljeno :D


durr.


Ok, so if I understand, you need max(date_time) as the endtime for the charts? If so (and you still need it), I can probably write a more efficient query.


Ugh, you're right. Is there a strict mode compliant way to do this without using eval? I'd like to avoid eval if possible, as it causes performance degredation for the entire function scope (in this case the entire JS output).


+$lang['captcha.label'] = '%sWprowadź tekst z obrazka';
+$lang['captcha.tip'] = 'Kliknij w obrazek jeżeli nie jesteś w stanie odczytać tekstu.';
+$lang['captcha.validation_error'] = 'Proszę wprowadź poprawnie tekst z obrazka.';


I think that is covered by the test above this


what about `break` ing here?


helkdsklrpe


:o


cdsc


Oops.


Tu ostane `TAG_PREFIX`, ktorý si nestripol, ak ho tam niekto napíše. (Ak správne vidím, tak `TAG_PREFIX` je optional? Lebo hentam vyššie (L157) ho len urveš ak je a v podstate na neho veselo kašleš. Ale tu ho neurveš a veselo kašleš :D)


I think this could be a helper function (remove some clutter)


not a bad idea


It would be nice to check that 32bits of cache is enough ...

```
#define STATIC_ASSERT( condition, name )\
    typedef char assert_failed_ ## name [ (condition) ? 1 : -1 ];

STATIC_ASSERT(sizeof(blackboxConditionCache) * 8) >= FLIGHT_LOG_FIELD_CONDITION_NEVER, too_many_flight_log_conditions);
```


This seems wrong. Should this condition be ```ContentTypes.Any()``` instead of ```objectResult.ContentTypes.Count == 0```


![Preview](http://i.imgur.com/wrbzlAh.png) @geecu check out this branch (dev) before accepting the pull requests.


r+ rollup


the second part makes the first part useless (because `'true' == true`)


@ens4dz
Very good idea!
I will implement it in the RDP Checker as soon as possible.


my style :)


No idea what happened to the language thing


@Myoldmopar Did I mess something up here?


@amaltaro, Alan I am getting some error due to the VARCHAR size. (in MySQL db)? I haven't run against MariaDB though.  Do you have any problem creating the table? I was running WMCore_t/ACDC_t/DataCollection_t.py
I think it is INNODB constraint. If there is problem we can reduce to 767, I am not sure that is enough though

Message: Problem creating database table

ALTER TABLE wmbs_job ADD
               (CONSTRAINT wmbs_job_unique UNIQUE (name, cache_dir, fwjr_path))

(OperationalError) (1071, 'Specified key was too long; max key length is 767 bytes') 'ALTER TABLE wmbs_job ADD\n               (CONSTRAINT wmbs_job_unique UNIQUE (name, cache_dir, fwjr_path))' ()


It's probably easier to pass _openshiftDirectory_ as an absolute path to GitClient. deploy() is called from DeployApplication.doGitDeploy() and there we have a reference to the build object.


close #26


same as above


I guess this whole parsing stuff can be moved into its own helper as well, it doesn't have anything that requires a "twitch message"


removing `end` from the interface but still using it in a untyped fashion looks odd


Is it certain that you need < when you have __cmp__ already? If you do, why not define < in terms of __cmp__, just to be consistent by construction?


did you miss src/server/game/Server/Protocol/Opcodes.h ??


Damn, it's TTY, I would just change it to HLE.


Do we need to verify the layout? The layout is an agreement between the application and the cartridges, we could just copy it and leave it to the user to create the correct dir structure. With git we do pretty much the same, the user is responsible to create a meaningful layout based on the cartridges, git just transports that layout.


This seems to work...

```js
var console = console;
if (typeof console == "undefined") console = {log: function(){}}
```


Good idea, I'll put that into the next commit!


No need to change, but typically documenting errors thrown by methods called within becomes a slippery slope.


True. I will make that change tomorrow


potentially getting `undefined` from `lastOrUndefined` will lead to an error here


I think this will be added in next release, @taylorotwell is just trying to remove what needs to be worked more, to make current release a stable one


The thing about the double saves was that:
* the first single click/save: copies the text that the (QTextEditor) that is the display widget for the "script" data holds into the old/current item on display;
* the double click/change view: clears the display widget and/or puts in the new/next items into the display widget;
* the second click/save: repeats the steps of the first save but this time writes the empty string or the new item's script data into the original data item.

The thing is: we have a lot of signals from different places connected up here and we are being caught out by _each_ of them trying to do _all_ the steps themselves that should be done only _once_ overall - and catching _all_ the combinations is not easy to do.  I still think we need to have an isDirty flag set by modification to the currently displayed data and atomically link that to the saving operation so the latter only happens if the flag is set and saving the data resets the flag... At the moment several different methods call the save_* methods including the selection changed signal from the treewidget but there is no overall tracking of whether a save has already happened.


And check on the userid.


Hey, how do we update the Dolphin VR share.oculus.com page? A lot of packages that don't update that page simply have the 'download' go to an offsite page that has updated links (possibly the oculus forums)


There's a NY3?

Regions:
San Francisco 1 (id: 3)
New York 2 (id: 4)
Amsterdam 2 (id: 5)
Singapore 1 (id: 6)
London 1 (id: 7)
New York 3 (id: 8)
Amsterdam 3 (id: 9)


Well I thought of it as to be able to give the user some sort of logging output. Like ... You told us to use that as an openshift directory, but this will actually not work, because of xyz. That way a user will find errors easier. It puts more burden on our side, but IMHO I think its beneficial to the user experience. But in the end, it is your call.


"var console = console; ..." does not work. if you check it in node, there is nothing outputted.

Any reference to the performance degradation?
If that is true, we can do the polyfill outside and pass it as an argument.
So the JS output would become something like:
```
(function (console) { "use strict";
var Test = function() { };
Test.main = function() {
    console.log("ok");
};
Test.main();
})(typeof console != "undefined" ? console : {log:function(){}});
```


IC ...  maybe define the enum with Pin_n = GPIO_Pin_n? At least in long-term ..


NVM my bad .. was thinking something else. BTW this brings me to an interesting scenario .. we should add a functional test ( if its not there ) which has a produces and which returns an objectResult where a content type is set in that case as well the content type explicitly set on object result would override the content types specified on the produces.
Please also add overloading actions to test this.


This change appears to be the root cause of issue #254, bringing the documentation and user expectations out of sync with the code.


Whoops indeed ;p shame on me.


no, it's still needed.

See the methods that call this one.


formatting.


Where's the Paragraph tag's README?


TryGet


be careful with symbols in text. sometimes they come out messed up. & should be & for example. also does base.htmp in the templates folder what we should be using? i haven't been and some old pages arent like it.


Great goal!


How about a description of what the `p` tag is used for instead of when it's not used?


Aktualizovali ste výpočet pre riadok 1(pribudli 2 riadky) a 4(pribudol 1 riadok)?


LGTM, but can you change this from $seluser to $selinux_glusterd_seluser so the namespacing is sane?
The default probably also be 'unconfined_u' to remain compatibility with the previous setting, but I won't fight for this change.


Should the redefinition also guard against gettext annoying behavior on empty string?


How about some longer test? Something that would give users an idea of what a long form paragraph looks like?


``` private var _map


It's not a header, so the variable should probably not be `header`


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=0e714a16dfce47acbc572840c0a8bdaa
 plone-5.0-python-2.7 [FAILURE]


Just like you said: "New York 3 (id: 8)"


Do you need to import this? You should only import it if it's required.


I don't think so. Nothing new is planned for Laravel 5. The next 2 weeks will be spent improving the docs and squashing bugs,


:OOOOOOOOOOOOOOOOOOOO
CONCIEGGS SKAL HA' SIN HALE SMURT!


formatting


In what way? We use pylint and six in blivet and they seem to get along.


should be getProfiles()


Same here


Could you please describe in the PR text why you changed this? What problem did you run into?


typo?


:cake: :bowtie: :cocktail:


The point here is to be clearer in the code.  if you have "1", then the question is "why 1?"  Whereas ```",".length``` is clear as to why we're subtracting that.


well, we have no 'last' function.  Note that we check ```array.length > 0``` before calling that.


:heart:


Oh ew.  This is fixed up in a later checkin.  This was just to keep tests passing.  If you look later, this will be gone.


Yes, it was set to True and I changed to to False. But, it still doesn't work.

I tried to print and see if the code gets to the point where issues are being looped, but it doesn't print my message.

def process_issues()
  issues = @doc.xpath("//Issue[@project='#{@@jira_project}']")  => This line doesn't seem to work for me.

  issues.each do |issue|
    puts "Got here !"

Thanks and much appreciated.


@frapell Your commit broke the build. Please revert or fix the failing tests.

http://jenkins.plone.org/job/plone-5.0-python-2.7/3944


Can't get 'undefined' here.  Because array.length is not zero.


Its not as DRY though.  In this case there's not much in it since the string is close to where its used. But I dislike having multiple definitions of the same thing since they can get out of sync when they shouldn't.  Its also easier to review the code and PRs too.


video js?


Let me know if this is unclear


Look at the title. Metamodels/core #709


You would get the same error in MySQL.


r=jdm


video?


it's not clear to me how to enable `apt_security_updates`. could someone please clarify?


@GrahamCampbell I mean the same as you said, for `next release` I meant laravel 5.1 maybe


It's a part of interop that implementations behave the same in the face of getters.


http://dict.leo.org/ende/index_de.html#/search=remainder&searchLoc=0&resultOrder=basic&multiwordShowSingle=on
remainder = rest beim ganzzahligen dividieren


rax retry tests


saw approval from jdm
at https://github.com/mrobinson/servo/commit/c3d23a063080ff7446af904e32ac6b661a4cd653


merging mrobinson/servo/surface-refactor = c3d23a06 into auto


mrobinson/servo/surface-refactor = c3d23a06 merged ok, testing candidate = aa870fe3


Thanks

On Thu, Jan 15, 2015 at 11:00 PM, Domenic Denicola <notifications@github.com
> wrote:

> It's a part of interop that implementations behave the same in the face of
> getters.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/promises-aplus/promises-tests/commit/1c8db75d872bb80a096f54321c57bee47b86c850#commitcomment-9304879>
> .
>


@shonlo Just seen this one now.  You're editing the wrong file, you need to edit either of these two files, depending on the platform you're building for:
debian/arch/amd64/config.amd64-vyos
or
 debian/arch/i386/config.586-vyos

Quick question, do you really want to be running VMs on the router?  The modules above are for running VMs on the host (so the router in this case), not for running the system as a VM on another host.


Sure. I haven't discussed this with Taylor yet.


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2809
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3158
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3151
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3153
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3143
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3143
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3146
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3139
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3133
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2811
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1647
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1640


1. This should be squashed in with the other commit.
2. Can we simply do this in a css file?


-to (:


Good catch!


Thats the wrong Arrays class -_-


Warning makes sense. But I'd rather we don't enforce it so that arbitrary folders can be used in custom cartridges. For example EAP cartridge uses .openshift/config but a custom cartridge might use something else such as .openshift/configuration


:neckbeard: :beers: :bowtie:


```TypeScript
const enum {
    CommaLength = 1; // ","
}

That said, I don't at all care.


Can we split up the unique constraint to be separate constraints ? Would that be functionally identical ?


Another option is to have the unique constrain on subsets of the strings, although that also needs some care to get the result we want...


\o/


Thanks, fixed in: https://github.com/purpleidea/puppet-gluster/commit/8f046435d2357ec2cd149a3e4bec56fc172bcc33

I'll gladly accept patches for the !~ change as long as they are compatible with about puppet 2.6 or 2.7 too, because I know i've got a bunch of users that are still 2.x users.


Yep. Ok to write a more efficient query. I have the impression that the query time is neglect-able compared to the API call time, but everything we can cut off is welcome.


Added my name. Also added some TSwift power hour.


Hmmm, sorry about that! I had no idea there was this limit of 767 bytes. The only thing we can do then is setting it to... 765 bytes (?) Should I make a new PR for that? (The same for the other file)


please don't reformat whole files this way. it makes the diff harder to review and introduces inconsistent style between our various css files.


Turned out that `literal_eval` doesn't support expressions:

```python
>>> from ast import literal_eval
>>> literal_eval('1 + 2')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/ast.py", line 80, in literal_eval
    return _convert(node_or_string)
  File "/usr/lib/python2.7/ast.py", line 79, in _convert
    raise ValueError('malformed string')
ValueError: malformed string
```

Supporting arithmetic is the reason we use `eval` in this case in the first place. If there's anything else that handles arithmetic like that it could be considered, though.


Can you add users to the reviews?

Maybe put a min:0 on the input so that you can't added negative quantity.

The reviews of one product are showed on every product page.

Contraband is broken.

Value should be defined in the input quantity field for the product page.


It's probably a similar problem to what I have in the static analyzer: As soon as there's a piece of code that you cannot analyze (e.g. `__js__(bla)`) you have to make conservative assumptions and forego several potential optimizations.


Dynamically loading plugins can be tricky. I suggest explicitly including each plugin with something like `--plugin ./my-plugin.js` instead of traversing a directory. You may want to look [here][] to see how Browserify handles the dynamic require() calls.

[here]: https://github.com/substack/module-deps/blob/ac903c1c88458159d571a66bc839c379bccf8096/index.js#L242-L272


Do you have a style guide documented or should we just try to go by what nearby code looks like?


saw approval from nikomatsakis
at https://github.com/FlaPer87/rust/commit/8544522eef77446fcb71716bf462e7248eb53e10


merging FlaPer87/rust/oibit-send-and-friends = 8544522e into auto


status: {"merge_sha": "7956748562157bd9191e27d478222d7df11d3bb0"}


FlaPer87/rust/oibit-send-and-friends = 8544522e merged ok, testing candidate = 79567485


Habit. Our Android VC here shows header rows for "Today", "Yesterday", etc. But we don't yet here, so I yanked it.


`msg->getU8(); // can change pvp framing option`
Was added in either 10.54 or 10.55.
`msg->getU8(); // expert mode enabled`
Was added in either 10.58 or 10.59.

If need be, I can look and find out for sure.


@LeoCavaille reverting it as it's breaking the build
```
15:24:01 The path `/home/vagrant/debian/https:/github.com/DataDog/omnibus-software.git`
15:24:01 does not exist.
```


It'd be great if this web interface could be an external module that uses the api provided by castnow (or even chromecast-player directly).


I got my 1.2 files to work with wolf4sdl build this way:
```
$(call set_defines,-SPEAR -SPEARDEMO -UPLOAD -GOODTIMES +CARMACIZED +APOGEE_1_1)
dh_auto_build -O--parallel -- BINARY=wolf4sdl-wl6a1
```


this should be readded.


`/^X-Request-URL:/m.test(xhr.getAllResponseHeaders())` might be a little more efficient.


the error code is only used in our key value store now.


Good catch, thanks.


大神求助，每次播放就报错跳出，而且错误报告和ｕｉ还重叠在一起，很是蛋疼。看上去是python 包里面thread 的问题。
      ♫  ♪ ♫  ♪    就是现在   -   王力宏  < 就是现在 >Exception in thread Thread-1:
                                                                                Traceback (most recent call last):
                                                                                File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
                                                                   self.run()
                                                                               File "/usr/lib/python2.7/threading.py", line 763, in run
             self.__target(*self.__args, **self.__kwargs)hades of Grey'')   -   Ellie Goulding  < Love Me Like You Do (From "F
ifty Shades of G-> 1. 就是现在   -   王力宏  < 就是现在 >  File "player.py", line 41, in runInThread
                   2. 裂心   -   王力宏  < 裂心 >                                                       self.popen_handler = subprocess.Popen(['mpg123', popenArgs], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
                   4. My Sunshine   -   张杰  < 何以笙箫默 电视原声带 >                                        File "/usr/lib/python2.7/subprocess.py", line 710, in __init__字碑 >
                   6. 在爱里等你   -   梁静茹      errread, errwrite)原声带 >
                   7. 手心的蔷薇   -   林俊杰, G.E.M.邓紫棋  < 新地球  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child     8. NEXT TO YOU   -   Ken Arai  < 寄生獣 セイの格率 オリジナル・サウンドトラック >
                  raise child_exception杨子姗  < 重返20岁 电影原声带 >
                                       OSError: [Errno 2] No such file or directory


I like the idea but there's a testing bug.  Since you are calling POST(), it isn't using the right UA object.  $request actually points to a request from a previous test (which may be a bug in itself.)

Tweak that and I'll pull?


Are there any next steps that you'd like help with? The transcoding stuff?


I'm not familar with LWP::ConnCache.  Do you know how it responds when a connection is broken?  Will it just return a broken UA object?  If that is the case, then I would prefer if this was optional as the firewall in our env regularly breaks connections that extend past a threshold.


please remove this commented out line


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


SC/20 isn't in a state that I wanted people to build it.  Lots of things still
to do like PDFs for PostScript.  These commits had intended to be on a
branch... and I had a non-SC/20 commit to push.


Adding hooks involving `mygroup_t` currently breaks the Perl interface as it doesn't know about groups; as a result, this broke the Perl API.


Test


js files should all include our standard license header used throughout the repo


Are you using `#send` because `#define_method` is private? You can also use `Rubinius.privately` which is a bit more explicit about what you're doing and why.


@dlangston we should pull the css out


@tisto this is so weird, the mail I got from Mr. Roboto said that the test was successful, so I assumed everything went fine.

Will fix it ASAP


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/542


Beleza. Então o $totpag morre no parametro e referencio ele como propriedade, certo?
Quanto ao PR, é que eu tava fazendo uns testes aqui e acabei mandando errado.


Ok, but my patches don't do any damage (and I can't guess that the push of SC/20 was a mistake). They had to be done at some point but they aren't linked to make world. I know that sc20 doesn't build.


Yeah, I understand it could be possible. But it is also possible that JS engines are smart enough to know that the argument to that `eval` is a const string, thus optimized it.
But anyway the idea of the code snippet of my previous comment is arguably better and should work fine.
I'm about to sleep now, so if any of you tested the code everywhere, I'm happy to see it changed.
Or else you can revert the change first and let me test a bit more tmr.


Sorry,  missed that on mobile client. Will have a look at this.


4558_hpwh_coil_removing_heat_from_tank (nmerket) - Win64-Windows-7-VisualStudio-12: OK (1593 of 1594 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


1.  You have Twitter in here twice.
2.  Maybe use a switch instead?


Nit: The commit comment / PR says "GCE validate-cluster" but this is the global path, isn't it?

Have you tested with the GKE provider? I'm worried we've never run with the minion checks there and the env variables might be wrong.

Otherwise LGTM.


Demo here :
http://jsfiddle.net/frangin2003/yy8uxmjh/


actually I will revert your fix because it crashes the standard case, for me and other people. See #72.

Can you better detail your case, with the exact output OCLint command, so as to do a fix that works in both cases?

thanks,


@m-kuhn shouldn't be - it was an exact copy of the base class' implementation.


Did things work work with cache_dir and fwjr_path both at 700 ? Surprised it would because the unique constraint put the key on a combination of the three. But maybe the database is smart enough to split this up.

How about 750 ? Nice round number... Also, we have more or less continuously raised this over the years. We have run against a hard limit now, maybe we should push back on this and tell Physics they can't encode all their metadata into dataset names etc (which is why this is happening).


@cphrmky I think this would make impossible to people that are installing `fog` now to use the latest version of `fog-core` and thats not desired. Maybe we could take care of the issues you were having?


Let us continue this here: #1


fix #301


This SQLite statement actually crashes Gmod !!!!!


We should not take such actions in the future or the maintainability of fog will become a hell. Please open a issue at `fog-core` and force the desired version in your project.


Damn it! Just realized, I broke my streak (half a day) of commenting on PRs instead of commits.


Probably better to represent as a hex value, according to the spec `0x7FE0`


cc/ @geemus @tokengeek Do you guys have an idea of how we will work with this kind of problem?
I think this is not the first time this kind of stuff happens.


I need this pattern because this sentence is valid on ruby:
```Ruby
block do

end.method.another_method
```


True, but we should refactor the benchmarks anyway


do you have any perf numbers related to this change. Since we don;t just return a property but do sightly more I'd like to verify that we don't degrade the performance


Great!
but the code is not formatted


Jesse, can this by any chance be the cause for [this bug](https://issues.jenkins-ci.org/browse/JENKINS-18297)?


tranquilo, qualquer dúvida mandaê


It looks like this test will inconsistently pass/fail (maybe environment dependent?).   I've noticed that when I run it init() gets called with both hosts in a state of ADDED.  It looks it the code only attempts to connect to hosts up until the first successful.  The test would work if 127.0.1.2 is tried first while establishing the control connection, which is dependent on the ordering of the iterator for metadata.hosts which is a ConcurrentHashMap


Sorry Andy, I've been testing with the node repl which does mysterious things to the console object after each line. I'll revert for now. I'm not sweating too much about it since users have js-es5 to avoid the shim.


This outputCollector needs to be transient as this TupleToMessage instance is passed via constructor to the bolt which in turn requires it to be kept as a non-transient field in the bolt.


Tu peux pas indenter putain !!!
x)


They're fine for now, benchmarking the access times between the first and the last relevant tag is all we're after right now.


Okay so this means that SSL will be used and all traffic is encrypted.


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:226](../blob/f95ca75acaaeceaa505ddb48bba0f1ccec9feaac/include/chaiscript/dispatchkit/type_conversions.hpp#L226) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:570](../blob/f95ca75acaaeceaa505ddb48bba0f1ccec9feaac/include/chaiscript/dispatchkit/boxed_number.hpp#L570) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/f95ca75acaaeceaa505ddb48bba0f1ccec9feaac/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/f95ca75acaaeceaa505ddb48bba0f1ccec9feaac/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/f95ca75acaaeceaa505ddb48bba0f1ccec9feaac/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/f95ca75acaaeceaa505ddb48bba0f1ccec9feaac/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


As a note: last stable build of node does not fold length of a string literal (though this can be added in a future versions)


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


oh, can you explain why we we want to do that?


This commit in particular is just cleanup of unused code. Some other recent commits, such as d1153cc864abe5ceef9d2b96fdd1a4c5e52b63d2, have minor positive performance implications. Simplifying the current isosurface extraction code, however, seems desirable.


minor, a simple before would be also working here

i like moving the before into the describe block


Correct! So after this is applied if someone navigates to the HTTP port they will get a 403 error (and won't be prompted for credentials.  If they goto the HTTPS URL/Port, then they will get the normal experience (prompted for credentials).

I verified that the install and all that stuff still works as expected.

Down the road an automatic redirect from HTTP to HTTPS would provide a better user experience.


C'est indenté !
Juste que y'a une seule boucle ^^


I copied it from the Rubinius source.  I'm just doing what they're doing.


why this one, too?


let's avoid global test state if possible and instead create a local instance and pass it to `converge`


Since `pos` was renamed to `start` maybe we should also rename relevant API:
```
nodePosToString -> nodeStartToString
getStartPosOfNode -> getStartOfNode
etc...
```


I believe you can also validate this by checking that UBound(listOfPoints) < 0


Another annoyance, that I should either document or find a workaround for is that zest.releaser now creates a tag called "stable". But we prefer to use a branch called "stable" (although it's not such a bad thing, so maybe we should just get rid of the stable branch and use the tag instead).


Ah ui, c'est ton premier commit qu'est pas indenté


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/3293/console
Build was first broken at http://ci.cgeo.org/job/c-geo/3288/


This one is for PrimeAcademe


I suspect you need to put some more logic in the Gemfile, to switch on `path` vs `git`.


I completely agree! The first place to put this limit - on the users/PPD side - would be in the Task names in TaskChain requests. Some are quite big (>50 chars).


Ah sorry, so you are. I just looked at the end of the file path and though it was our code.


Not very clear what you want to achieve. I opened an issue https://github.com/pdincau/gcm-erlang/issues/14 so that we can talk there in a better way.


@plribeiro3000 I will indeed open an issue, that's my plan, just haven't done it yet.

> We should not take such actions in the future or the maintainability of fog will become a hell.

You're right, it'll cause problems in the long run, just doing it as a stopgap as other project which requires fog-softlayer, knife-softlayer, was completely broken by a bug introduced somewhere >1.25 in fog-core.


This is all going through `Logger`, so this isn't necessary.  Do you want it specifically?


I got this.


Considering what it took to add :abort I needed; I think what would be awesome if there was a way to access Transfer directly. It's a common approach when creating clojure wrappers to make them extensible by providing access to underlying java classes whenever possible. Just my $0.001


This still has the commas in the number.


It came from a user.


Sorry, which NULLs?


Why don't use use single quotes to get rid of escaping?


Fixed in 678fa4272811ff3ddcab41ae5ff96c68fc950b27


I already merged this in but just noticed that you are not emitting anything here but the output fields are declared below. I think if the scheme returns `{}`, then nothing should be declared below and otherwise something should be emitted here. Can you fix that and submit a new request?


Maybe it would be easier to put the HTML of the error directly into the page and just use show()/hide() JQuery functions to manage their visibility?


But it's so pretty.


The observations here are specific to ITC for now (simple parameter container object). And I think this is going to stay like this.


AddMoreWarningFlags (lefticus) - i386-Windows-8.1-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.6%25-red.svg)


I'm not understanding this one. It looks like the page title gives a page title if it's set or the site title if one isn't set. The pull request just shows adding 'startbootstrap-clean-blog-jekyll' to the title, not a page number.


not happy with the description if the textarea


voilà merci


Sorry, I had this starred to come back and am just now getting back to it.

Yes, if you're building from within the plugin itself, I think you're right. I've never had that use case, but it makes sense for unit testing without the WP installation, I suppose. Thanks for the clarification.

Also, I know this is off topic, and I sent a separate email, but we're in need of your pro version of this product. Wondering how far off we are, and if there's anything I can do to help get it to that level.


Do you use this class to amend UI or this is simply an indicator for JS? If it's only for JS, I'd write the info in a separate attribute like `author="$post.UserCreated.id"` or `own="true/false"`


try adding this under the <textarea>

`<div class="pull-right"><span class="glyphicon-info-sign glyphicon"></span>Markdown supported</div>`

give the span with the icon a `padding-right: 8px;`

![bildschirmfoto 2015-01-15 um 22 41 12](https://cloud.githubusercontent.com/assets/298166/5767281/2314ebc4-9d08-11e4-9dad-d9f2afa7a6c9.png)


This line was accidentally added before. The created OM file isn't actually used anywhere.


This is nitpicking but watch the spacing here; we like our code to be pretty =P


Why?


i think clear-require is also a regular dep, could that be? (unrelated to my issue)


Oh wow, per this page (http://msdn.microsoft.com/en-us/library/aa445048%28v=vs.60%29.aspx) I've been doing it wrong for years, using IsMissing on ParamArrays.

I'll get this fixed throughout the project; many thanks!


@cmelchior : Why moving the validations? Are they not already checked in JNI code? If not, then they should be.


`getLeadingCommentSpans` ?


This commit breaks file handling, I think?
```
Command line error: unable to open input file 'Example.c'
```


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (328 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.09%25-yellow.svg)


`getTrailingCommentSpans`


Okay, I'll do it now


yes it is a regular dep. Published that as `rc3`. Thanks!


Should you truncate the buffer to len returned from runtime.Stack() ?   So that you don't endup with extra data and no way of knowing where the buffer ends.


would be nice to at least have credits for my work


Yeah, I think we should make an effort to update it.  That release is so old by now...  Not sure where we should have it point to.  My signature is always updated with the latest version, but that's a pretty odd thing to link to!


oh, sorry :) to soon.


I'm not language specialist but IMO name which suggest `NSDate` should sound similar to:
`crv_defaultImageRepresentedByDate`. Anyway your suggested method name is better than mine. Will change it.


Happy to see this improvement - though it would be clearer if it said "Don not export physical locations or draft child descriptions". :P


check regex, rare behavior


I thought  I deleted it. Sorry about that.


seems this is required, running it:

 ./src/bin/test -v -p id3 /tmp/lms.db -S ~/Music
ERROR: could not dlopen() /home/gustavo/usr/lib/lightmediascanner/plugins/id3.so: undefined symbol: _container_mp3


Maybe it doesn't matter though since you only write to each byte[] array once, and any extra would be \0 right...  Anyway.   Not a blocker.

```
+				p := &PanicError{r, make([]byte, 1024)}
+				l := runtime.Stack(p.Stack, false)
                                p.Stack = p.Stack[0:l]
+				t.setError(p)

```


Minor comment:
!==

for consistency with the rest of the code


===

for consistency with the rest of the code


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10066/testReport/) for this commit**


On Thu, Jan 15, 2015 at 12:23:57PM -0800, daurnimator wrote:
> Damn.
>
> should I remove this commit? or is it still 'correct' (yet useless)?

the patch itself is still technically correct.

i need to update lua.path to the newer version, anyhow. i version it in
another repo because i use it in multiple projects.

	http://www.25thandclement.com/~william/projects/luapath.html

i've already committed the same quotation fix, plus similar quotation fixes.
i just need to copy it over to the cqueues repo.


:+1: Good to go from my side


@hcstephencheung There is no need to pass in this.$pinny because it should already have reference to it


What did you use that screwed up the entire file formatting ?


look a method to know if is youtube video show plugin if link only show link


void pointer casts are implicit in C. We don't usually add them, unless they are required for C++ compatibility in headers.


there is a missing righthand brace


Instead of $(document.activeElement), use this._activeElement() like the example in _hideSpacer


@AndrewMeadows hows that?


r+


AddMoreWarningFlags (lefticus) - Win64-Windows-8.1-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.6%25-red.svg)


Can you make your commits more verbose so other developers know what you are doing?

Examples of a bigger commit message:
https://github.com/pilight/pilight/commit/9e7f15cabb0f96f17debf9ec6d59f6ac3a8d45e7

Or a small one:
https://github.com/pilight/pilight/commit/c2278e023c747e2b2e05fe311f83fbd02a172d25


holy abuse of <style> tag!


@alanclayton I found the issue. There is already a post with the same title in this folder. File name is 2014-10-01-html-widget.md. By the way, I've found another issue. There are multiple posts wirh order: 9. Cheers!


There's no need for src/com/android/settings/DeviceInfoSettings.java additions?


At @nsidc, we have an internal project with a dependency on fog ~> 1.25.
This change made it impossible to install that project, so we've pegged the version of fog-softlayer to 0.3.28.

@cphrmky I'd appreciate it if you could ping me in the issue you're opening for this so that we can update to the newest version of fog-softlayer once a fix is in place.


Если про сферического коня, то таким
```java
for (int index = 0; index < 10; index++)
```

Если не вмещается в одну строчку, то можно разбить на несколько разных.


Это плохая практика - хранить селекторы в коде. Со временем их станет чудовищно много и будет вообще непонятно что от чего и как. Стоит сразу использовать например https://github.com/yandex-qatools/htmlelements
Но опять же. Призываю узнать как писать тесты для angularjs и писать тесты для него. Узнать как писать  тесты для джерси и писать их. Их гораздо проще написать чем вебдрайверные тесты


AddMoreWarningFlags (lefticus) - i386-Windows-8.1-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.3%25-red.svg)


TEST


Whatever's easiest. I'm currently working over with Jherico to make his
fork of the SDK output similar paths to the official SDK, so that we don't
have to link against something differently named. Then I'm going to have
Dolphin's CMake explicitly pull in the static version of the library, and
look see if I can't make Jherico's SDK pull in as a git submodule (like we
did with JRift). That would let you build Dolphin VR with zero setup by
running git clone --recursive http://path/to/dolphin.git.

Speaking of which, I've been using Jherico's fork this whole time, where it
turns out Cmake was forcing the use of -O3 instead of -O2 (less stable and
usually much slower) as 'release' flags (also it didn't appear to enable
SSE2 optimizations). Should have that fixed soon too!


Oh, I didn't realize you had to handle expressions here. I'm not aware of any other alternatives to consider.


17 for sure aint treshold here.... its actually value from LootError enum... LootErrorOk = 17


made 3x version for all buttons


@michaeljb

Ah yikes, my bad, I didn't fully reason my way through this.  Will push another bump that eliminates this lock right now.  I can workaround it on the knife-softlayer deps in the short term.

/cc @plribeiro3000 @tokengeek @geemus


replace _.str.trim (js trim) by python split()   for both google analytics code ?


This shouldn't be removed.


Nice solution, but use normal names for variables


@Montellese Is it safe conversion? :smile:
https://github.com/Karlson2k/xbmc/commit/273e557c15162a9b3eab2363a2e1d5fdfc77fd92


AddMoreWarningFlags (lefticus) - Win64-Windows-8.1-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.3%25-red.svg)


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@rcruse made 3x buttons for all buttons.


@seh Create an issue or better a pull request if you know how to fix it. I still don't know all the quirks of emacs' module loading system.


if you use multiply if, use construction
if(){
}
else if () {
}
it will save runtime


Oh, you're right. No.


>Правда, чем дальше, тем хуже их поддержка.

Поддержка должна быть обязательна.


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


where is check that res>4_000_000
for this should use check
while(res < 4_000_000){
}


Fixed as of b89074e.

/cc @michaeljb @plribeiro3000 @tokengeek @geemus


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


And then if you have multiple tasks they add up in the cache dir names etc. Design wise we always will have problems with very deep tasks though...


r+ rollup


Hmm, cih_remove_checked also calls cache_inode_lru_unref, maybe it should do so outside the latch. Probably not as big an issue, but still...


А что мешает вывести через стандартный текстовый контрол ?


Hmm, this function doesn't use latch...

But it is always passed latch, which has cp...

Maybe some discussion of what the interface here should actually be...

if this wasn't conceptually a separate layer from LRU, I'd actually advocate for just having this code inside the LRU function that calls it to make things more obvious...


No, you're right! I didn't know log.Fatalln() called os.Exit(). I figured it just labeled it with FATAL as the level because I'm used to PEP 282 style logging, which never exits.

I also never read the docs because I am a keyboard cowboy.

![image](https://cloud.githubusercontent.com/assets/271933/5767708/53d32634-9cbf-11e4-82ff-21020121ba56.png)


Done.


r+


As far as I can tell (and correct me if I'm wrong), [wordpress.com](http://wordpress.com)—the blogging service, not the blogging software—does not yet support FIDO U2F.

Independent blogs which use the Wordpress software can use [this FIDO U2F Wordpress Plugin](https://github.com/Yubico/wordpress-u2f), but this doesn't appear to have been integrated into [wordpress.com](http://wordpress.com).


Added `, 1` to all `make(chan error)`s


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Nit, but I would rename this to updateWithFile, to make clear that the actual REST update is happening in this function. I would also put the `else` block above that updates with patch to an updateWithPatch function for clarity and consistency. That might then open up additional opportunities to factor out code from those two functions.


You must remove the pluginManagement section ignoring wr04j-maven-plugin, similar to https://issues.jboss.org/browse/JBIDE-16849


Done


This syntax isn't quite right.
[The syntax is supposed to be automatic, so no **property="..."**, it is only if you specify arguments on the command line and want it to have a specific prefix, read more here](http://maven.apache.org/guides/mini/guide-configuring-plugins.html#Generic_Configuration).
Moreover, the property configuration (readonly, required) is supposed to be a new javadoc tag, [read more here](http://maven.apache.org/plugin-tools/maven-plugin-tools-java/index.html).


emscripten (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-31.09%25-red.svg)


@phated the test above only deals with one registry not two, right?


ddc is now CloudEnabled™


saw approval from larsbergstrom
at https://github.com/glennw/servo/commit/02b91994b3cced74b2055037a13aaf09e58d93c7


merging glennw/servo/update-hb = 02b91994 into auto


glennw/servo/update-hb = 02b91994 merged ok, testing candidate = 31627bdc


This is very funny!!. :sweat_smile:

Gihub no allow public releases with tar.bz2 files but can add it as an entire commit!. hahahaha


I don't like having two import statements in a file. I recommend instead:

import (
    "fmt"
    "sort"
    "strings"

    "github.com/GoogleCloudPlatform/gcloud/gcloud_apis/commands"
)


Почему же странно ? Как я понял, они могут называться:
```java
final static int BUFFER_OPERATION_BEGIN_HEADER_SIZE = 3;
final static int BUFFER_OPERATION_END_HEADER_SIZE = 4;
```


Ya fue corregido


How are you going ??


My thinking was that raft.createGroup is the last thing we do when adding the group, so raft.removeGroup should be the first thing we do when removing it. I think that the hypothesized side effects would belong in whatever calls RemoveGroup instead of on RemoveGroup itself, but we can reconsider when/if that occurs.


why are these   two under ASPNET50?


Why are you adding all these extra spaces?


@cphrmky

Thanks, good luck finding the proper fixes you need!


be consistent with the way you split your parameters, this one has the first one on the first line the next test has it on a new line.
I would prefer this to be on a new line.


No progress. Cannot figure this one out


@Sc00bz In JtR, I had to use `while (outs_per_main_loop)` here, to fix division by zero segfaults when resuming (which obviously means a "skip"). The problem is I have yet to reproduce that problem with princeprocessor, even though they run the exact same code, same wordlist and same (implied) skip. I do not get why.


this can be more concise with
```
if node.midas.newrelic.enabled
    nodejs_npm 'newrelic'
end
```


nit: better name? FormatLocation or FormatSource?


2 DAYS AGO?!


I think you still need to duplicate this line (the one that runs `node import.js`)


this was due a mess with dlna.h, I'll fix both and push this -- no need to fix yourself.


Added a test that verifies the rangeAlreadyExists error. The comment was imprecise; by "preexisting" it meant an ID that had been used before but belonged to a range that is now removed.


Although the error messages on unique constraint, but it seem it not combined constraint, it seems it is each value constraint. So each part of key has to be less than equal to 767. I am even fine with the max value 767 instead of 750. So we know the upper limit.


instead of this we should probably write this as
```var objectResult = Assert.IsOfType<ObjectResult>(context.Result)```


getNativePlayer should only return a native player or null.


technically 2 because it is initialized with a custom registry.


![screenshot000](https://cloud.githubusercontent.com/assets/6500800/5767947/98b9da5c-9d0c-11e4-8e8e-137b080d30e7.jpg)
![screenshot001](https://cloud.githubusercontent.com/assets/6500800/5767948/98bea190-9d0c-11e4-96bb-6a414375ea0f.jpg)
![screenshot002](https://cloud.githubusercontent.com/assets/6500800/5767946/98b9db24-9d0c-11e4-97d9-98c4dc08639e.jpg)
![screenshot003](https://cloud.githubusercontent.com/assets/6500800/5767945/98b9b5fe-9d0c-11e4-8c8f-d93d6d5fbe68.jpg)
![screenshot004](https://cloud.githubusercontent.com/assets/6500800/5767949/98c0e4d2-9d0c-11e4-8192-0e5123c01ac2.jpg)

I had to do them all by hand, as my version is too far from original for the git to merge.


Why you need the PDO ?? Any arguments ?


fixing that now


not clear, we would be executing this even if ``` place == FormatPlace.RouteAndQueryData``` in which case shouldn't query contain format as well??


wow, not bad :+1:


This is redundant, we already have `zend_isnan` for this purpose.


what is this?
why you decrement i ???


@HybridDog It broke shaders.  Should be fixed soon.


TESTS PASSED
 Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=97b50202eb82452dbc24eb6d17acaf8c
 plone-5.0-python-2.7 [SUCCESS]


Стиль надо фиксировать. Мне это напоминает историю к трассировщиком, который стал бинарным сериализатором. Обсуждали несколько раз, но пока в реале не проговорили - ничего понятно не было. Еще одна попытка с моей стороны про стиль: только встроенный эклипсовый форматтер. Он мне не всем нравится, и переносы из примера получаются фиговые, но остальные решения *в команде* не работают. Готов убеждать голосом. Можем встретится в следующий вторник в универе часов в 11:00. Но надо договориться о встрече заранее.


you should try using ```DefaultHttpContext``` instead of using Mock here. .  look at Chri's strong type commit for examples.


when would this be the case?


disableHAMforQSS (tsnouidui) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.81%25-red.svg)


var


Pdo supports multiple database types, and also I'm going to use this
project to learn pdo


Code explanation (documentation maybe?). All those pragmas and comments in tricky (maybe not clear) places.


As reported here: http://s15.zetaboards.com/iCheckMovies/topic/7452358/18/#post-8499698


I would rather figure out why this is happening and then revert the patch.


we are setting up here as well as the in CreateActionContext suggest keeping the logic in one place so that it is more understandable.


break the line so that it is less than 120 chars


@phated yeah, a test that two (or three or one hundred) `.registry` calls in succession won't mess up wouldn't be a bad idea just to be really sure. this is a pretty important feature to test, people will be going crazy with custom registries


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:226](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/include/chaiscript/dispatchkit/type_conversions.hpp#L226) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:570](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/include/chaiscript/dispatchkit/boxed_number.hpp#L570) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/759d6fc42f2e51a3804df949f6bd24359616f391/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


This subdirectory needs a .gitignore file to ignore the built binary named version


>In your head, in your head
Zombie, zombie, zombie

:microphone:


4558_hpwh_coil_removing_heat_from_tank (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.91%25-red.svg)


@msoky Updated in https://github.com/TrinityCore/TrinityCore/commit/a4afd80479a3cdb7938dd7dc091205118518b390#diff-bee5fa9de5ef9691e9821c837c7072afR1091


Hm, they do all seem to build with the make 3.82 in stdenv, so for now I'll leave alone.


@HybridDog @ShadowNinja  it's fixed in the PR, it was missing semicolons, which works on Intel GPU, then i missed the problem.


1st commit


Ugh, 'of_string' side effect... :-/
Still, no worse than the current code...


So I could keep track of the template logic nesting. It was getting hard for me to match {{if}}s with {{end}}s.


emscripten (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-31.21%25-red.svg)


for this one should we test the overriding behavior? route value overrides the one provided in query?


My guess: systemd mounts tmpfs on /sys/fs/cgroup for some reason, then it creates directories in /sys/fs/cgroup and mounts cgroupfs on those directories, then it creates softlinks fo some of those directories, and finally it resets the context of /sys/fs/cgroup dir (but not the softlinks or directories in there)

My question is why does it need to mount tmpfs on /sys/fs/cgroup. Can it not just create /sys/fs/cgroup(/.*)? directories and mount cgroupfs on the various sub directories.


There is a solution here, I just have to keep looking.


see http://groovy.329449.n5.nabble.com/NoClassDefFoundError-java-util-HashMap-Entry-with-Java-8-td5720093.html


What are we testing here? I can't figure out reading the test case. what is default format here?
nit: Since this class is all about testing ```FormatFilter``` in general drop the ```Format_Filter``` prefix from the test cases.


bloop


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3140
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3159
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3152
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3144
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3144
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3147
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3134
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2812
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2810
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1648
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1641


@Karlson2k: It was as a "please comment" in my PR but it was decided to merge and see if anything breaks. So feel free to push/PR an appropriate fix.


sure ...


I've been waiting for this change a very long time.


in the future could allow a provider to preload video data (HLS fast start)


emscripten (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


OrdinalIgnoreCase on key


This is a comment


SGTM


This is a comment with a changelog

==CHANGELOG==
Hello World.


[NotNull] on both params


great thanks!


Hmmm this doesn't seem to be having the desired effect, if you curl -I https://www.python.org/static/js/libs/modernizr.js no Expires or Cache-Control headers are included.  I wonder if there isn't something we need to be setting in Fastly itself perhaps?


This was a really great addon.now it just flags script errors although it stills shows updated thumbnails.


AddMoreWarningFlags (lefticus) - i386-Windows-8.1-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.6%25-red.svg)


Have a look:
http://www.phpeveryday.com/articles/PDO-Insert-and-Update-Statement-Use-Prepared-Statement-P552.html

Do not know if it makes any differnace but for INSERT they use ':field's but for UPDATE '?'


Thanks for the link! If I get it right we basicly need https://github.com/substack/node-resolve so that the plugins are able to require modules within the node_modules directory?
I agree that `--plugin` is nicer than directory traversing. Will change that goal.


I'm not so comfortable with this one. The reason check if this instance's container is the element we want to remove is because that tells us that the video tag is still managed by this instance. What if the tag was moved elsewhere in an external DOM change? We would then have no business removing it from it's parent here.


Awesome thanks :D


I know file this is generated by Sublime, but it's generally a good idea to not commit editor-related files into source control (unless you're using XCode). They just tend to clutter up commits, and let's say two people are on a project and are using Sublime. Every time one person pulled in changes from the other, they would also be pulling in the state of that other person's editor, which is usually not appreciated.

Let me know if you need help getting the Sublime files out of git.


And this is exactly what I did not what to happen. Using dedicated modifier for arrays (e.g. `?name*`, `?name[]`, `?nameL`) is much better. Also I still think that using `?table` and `?column` (or `?col`) would be a lot better.


dont see why this case should exist as a separate test case its basically the same thing is the previous one and is only testing MediaTypeHeaderValue parsing.


Does the version in `bower.json` also need to be updated?


Theory with only one dataset?


oh lol, didn't notice, haha. I still don't get why you forked this...


Not a safe change. Is it necessary under any circumstances?


WHAT?!?!?!? THIS ISN'T SCARY, IT'S RIDICULOUS.


do you need this parameter ?


thought about it and then I thought that is exactly what the commit message is for. I can add a comment anyway if you prefer it


BTW that was before f25740eb and I'm not sure I can reproduce it anymore.


probably you should add few with null and empty formats


No guarantee fragment is map[string]interface{} here - you should probably type check it first.  Could be number, null, string, or array.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/543
success: http://build.servo.org/builders/linux2/builds/541
success: http://build.servo.org/builders/android/builds/579
success: http://build.servo.org/builders/mac1/builds/760
success: http://build.servo.org/builders/mac2/builds/760


Just for test purpose


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (328 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.09%25-yellow.svg)


As requested: here is the build.sh as a separate pull request.


Most of this is based on #13 from @JoachimL. I had to do a manual merge. See the #13 Pull Request for more details about the changes.


This is a really bad place for those methods. There should be a static utility class or a non-static FaviconBuilder class.


Technically you need to ask for a mapper in order to do this - in the long run we may not have a single codec for every possible object.  You probably need to know the resource type and ask the mapper for a mapping from that kind but your version.


Hi there.
Can you please re-open this pull request?
I see that you first did it on version 1.3.2.
However this bug still exists in version 1.3.4:
https://github.com/phalcon/cphalcon/blob/master/ext/mvc/micro.c#L1064-L1078
:disappointed:


@jasonmayes FYI for some reason the author of this commit (and some other recent commits) is jasonmayes@users.noreply.github.com; your previous commits seem to have the "correct" address--you might want to check your configuration. (Doesn't seem to be visible in github's interface, but `git show 3750696f` should do it.)


saw approval from sfackler
at https://github.com/nick29581/rust/commit/98d471120a09607ad429bebf56c97b512bdf9847


merging nick29581/rust/methods-ext = 98d47112 into auto


why not change this task to: "make-pages" and append the action 'git checkout master'.

for the "save-pages" task, insert the action at the start: 'git checkout gh-pages', and add the action to the end of the list: 'git checkout master'


nick29581/rust/methods-ext = 98d47112 merged ok, testing candidate = 8903c21d


status: {"merge_sha": "8903c21d618fd25dca61d9bb668c5299d21feac9"}


fast-forwarding master to auto = 31627bdc


"Inline json" might be confusing - you might want to say "A JSON document to override the resource."  My first thought with "inline JSON specification" was that there was some cool spec format like what jq uses at play.


They don't make a difference, see here http://www.phpeveryday.com/articles/PDO-Positional-and-Named-Placeholders-P551.html


My English is terrible ... especially when I hurry up..BTW


ok ..


(LGTM?)

On Thu Jan 15 2015 at 5:34:37 PM Stephen Weinberg <notifications@github.com>
wrote:

> SGTM
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GoogleCloudPlatform/gcloud/commit/ba48c15db242f41fc2ea1a37255d2495c03d3b2a#commitcomment-9306266>
> .
>


copy&past?


>Можем встретится в следующий вторник в универе часов в 11:00. Но надо договориться о встрече заранее.

Я приду в любом случае проставить экзамен. Плюс, еще хотел обсудить курсач на следующий семестр.


I don't have a style guide. It's totally fine if it "somehow" looks like the same style. I'm not too obsessed about :-)


> the code worked fine across OS X and Linux nodes

Of course, because these systems happen to use the same (POSIX) path conventions. The problem could arise with a Windows master and POSIX slave or vice-versa.

Again, without knowing what your plugin is really doing, I cannot predict whether the problem would really be manifested, and what it would look like. I can only say by local code inspection that

> new File(build.getWorkspace().getRemote())

is inherently wrong, in the sense of a type error.


delete this


Should be:
```
".*\\.accountId" : "r",
```
You only want it it apply to <resource>.accountId, nothing else. Having that extra ```.*``` in there would allow it to apply to <resource>.fooBaraccountId, which is not what we want.


I understand what you are saying, and there is no hurry here


I'm in hurry all the day ...


Takie zmienne tak samo jak metoda dostępu powinny być zenkapsulowane przez np. router
(google "php router object", można użyć np symfonowego httpkernel)


zmienne z małej litery


No, our release script will update the bower version automatically.


To może być trochę trudne na tym etapie, ale taką walidację lepiej przeprowadzić przez kolekcje obiektów walidujących.


Same as admin-auth.json comment


Spróbuj zapoznać się z ideą inversion of control - dependency injection container (np. pimple)


Got it. Fixed !


Fixed !


AddMoreWarningFlags (lefticus) - Win64-Windows-8.1-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.6%25-red.svg)


Bei 17. würd ich auch sagen NEIN, weil unbewusst. Steht auch so in ihren Folien


Good spot :+1:


resolves #302


this is not in par with the Java implementation, please see https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java#L93

What made you make this change?


Probably better to leave out the `v1` and just call it `json_to_xml_libxml_292`, since the original point of the `vX` suffix was to denote version numbers.


metoda matka i dziedzicząca musi mieć taką samą strukturę


Please feel free to remove old code.


Ok, will look closer .. as I'm interested to run it on SQLite :)


to jest dużo lepsze niż if elsy które widziałem w poprzednich komitach


Assertion messages should suggests a way to fix the problem, and at last a way to hide it.


Same deal -- might as well leave off the `v1` suffixes if we're suffixing with libxml versions instead.


```sh
if [ "xXx$STEAMROOT" = "xXx"]; then
```
What is this? Batch?

this should definitely be:
```sh
if [ -n "$STEAMROOT" ]; then
```

This does the exact same job but does it with the tools provided instead of making up your own tools. Still doesn't solve the possibility of $STEAMROOT being whitespace. But at least then it should fail anyway, silently.


AddMoreWarningFlags (lefticus) - i386-Windows-8.1-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.3%25-red.svg)


That was one my my own personal goals, to use sqlite.


nie chcę widzieć takiego pliku jak functions.php :-)
helpery to antypattern, a funkcje globalne to już poziom podstawówki, c'mon!! :-)


Instead, please set VERBOSE to false in your environment. This is a NOCOMMIT...


lgtm


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


My goal is to have perfectly running solution for my vocation house as I am short on relays using current rather closed solution .. So need it fast and perfectly stable


Why did you do this?

User should be a subclass of GameProfile. Both are player data objects, and the GameProfile associated with a User never changes! A user has a name and UUID, inherited from GameProfile.

I know that it is hard to find class names that represent this, but that's not a reason to separate these classes.


My attempt to reconcile this.  This may not be ideal and I can understand not wanting to change the behavior of Metadata.hosts though [JAVA-618](https://datastax-oss.atlassian.net/browse/JAVA-618) is another relevant conversation which may affect this.

Another idea is to retry the scenario if it fails and shutdown the other node, but that would add runtime.


since this is not handled in the original Java code, if we get `ctx == null` this is basically an error scenario that we need to handle. If we remove this null check, is the test still failing?


> I'm curious why poor performance prevents you from releasing, even as an alpha? I for one could handle poorer performance in exchange for a native graph database. Releasing it might bring it more attention and garner the help needed to boost its performance. But, perhaps releasing it is enough work in itself.

Hmm.. I didn't get a chance to even consider the "alpha" release. That's how swamped I am. ) Probably it is a good idea. I'll try to find some time to review the project again in the coming weeks and possibly release it.

> What kind of support for querying does this database have currently? I know graph querying is a deep subject (Sparql, Prolog, and many other variants).

There doesn't seem to be any standard (like SQL) in this area. Every graph database seems to be inventing its own (e.g., Gremlin, Cypher). I think it's fine, since graph databases tend to vary way more vastly compared to relational ones. This project is no exception, especially with the node-local indexes feature, which to my knowledge no other DB has.

This project doesn't approach this at all. It presents a native API with just a few simple functions in a special monad. Since monad is such a powerful abstraction, the few functions provided by the API and the standard monadic combinators seem to be enough to cover all use cases. I believe it's a feature of its own, since it is so straightforward for a person acquainted with monads, which every Haskeller should be. Here's [an example of a query](https://github.com/nikita-volkov/graph-db/blob/master/executables/Demo.hs#L76-L79) from the demo.

However since this API allows to do pretty much anything I expect that the people interested could implement adapters for arbitrary query languages as side projects. This would allow for integration with other languages.


oh-my-zsh loads everything automagically? WUT.


AddMoreWarningFlags (lefticus) - Win64-Windows-8.1-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.3%25-red.svg)


Aurechnung funktioniert schon!
Bug wurde gefunden


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this was already fixed this week by https://github.com/apache/lucenenet/commit/7970bb64e609e6feb63030fcfcfe2718291706c0


done.

On Thu, Jan 15, 2015 at 2:43 PM, Clayton Coleman <notifications@github.com>
wrote:

> "Inline json" might be confusing - you might want to say "A JSON document
> to override the resource." My first thought with "inline JSON
> specification" was that there was some cool spec format like what jq uses
> at play.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/brendandburns/kubernetes/commit/1485c92dec38a576eec2ecc28af68addafb388fa#commitcomment-9306390>
> .
>


Made a PR. Seems people have done this in the past and hasn't been updated in a while.


`?table` and `?col; is unnecessary complication. They both do the same, but user must think whether it is column or table. And what about `?schema`, `?database` etc. And what about combined `table.column` identifiers?

`?name` as array is not very useful, it can be removed.


True, it would prove that the API works correctly :)
Not quite sure yet if I'm gonna use chromecast-player in v0.5. Maybe gonna extract the api.js and the timelineHelper.js into a separate module and use them directly. The main problem is that I currently have no elegant solution howto switch between chromecast applications within chromecast-player (e.g. from YouTube to DefaultMediaReceiver).


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


`kilobytes_requested` needs to be passed into `reallocate()` as a parameter to have an effect.  Otherwise this will always resize it to its current on-disk size.


DivideByZeroProtection (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


OptionalTypedArgs (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Are we talking about infinite sprint that's in 1.8.3?

:-1: You can outrun Zed if Turbo can be spammed.
:-1: Doesn't stay true to the realism of maintaining a living human in Arma 2

Are we talking about one time sprint that exhausts you within 30-90 seconds?

:+1:  Ignore me


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


For the record, this was https://github.com/iojs/io.js/pull/411, LGTM'd and landed by @piscisaureus (I think - it wasn't me, at least.)


master (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (lufinkey) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Hrm - we're still listening on bindPort+1 in start.go.


should you call the parent constructor from here?


emscripten (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-31.09%25-red.svg)


Which is quite the problem :)

We need to match Java Lucene's tests exactly, for most things we don't want to "fix" our tests. Please see https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene/util/TestFieldCacheSanityChecker.java#L158-L163


This completely breaks the library.  The deadline is absolute, so any attempt to send after `TlsTimeout` seconds has elapsed will fail.  i.e. Open the connection, wait 5 seconds, try to send --> fail.


Please regard this as a NOCOMMIT, we do want the tests to run randomized. You may leave this locally to help you fix the tests but the codebase should not have this in place.


No idea when this changed. Really weird really, the docs kind of imply the old way is correct, but the code is definitely checking strict equality.


r+ p=1000


r+ rollup, thanks!


Related to thymeleaf/thymeleaf-extras-springsecurity#21


It does exist in the original core - https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/util/IndexableBinaryStringTools.java

I will try to dig into this later, it could be that some other sub-projects are using it and we actually do want to keep it around


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:226](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/include/chaiscript/dispatchkit/type_conversions.hpp#L226) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:570](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/include/chaiscript/dispatchkit/boxed_number.hpp#L570) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/9449fca22f52e78fd2b9e18cb75ff200ae4bd66f/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


`this.get('currentUser.is§min')` :open_mouth:!


oh boy, i wish there was a space between the ) and {


lijiajin.github.com


nit: I have updated other readme.md for other sites, just follow the same  wording :)


Dang, I though I committed its removal at least 3 times...
Anyway, I was planning on making a few changes before the next release.


I'd suggest to add brackets here and 2 lines below.


you are correct sir.

:frog: