@bors: retry


That's a really nice thought. Thanks.


rename CleanCacheWorker


We used to get 500 rows a request. Does this change mean we now make 5x as many HTTP requests? Not sure what to do if some servers can't handle bigger requests, but ouch.


I added my email address and a forum for all HVision issues, the information are in the bottom of the readme.md file. Please post there.


x


rename to addMessage


Bah, and there is no amending commits from here from what I can see...

Removed the commented out code.


is this also an issue on release-0.3? @juliabackports


probably best is to just use a proper file embedder such as https://github.com/jteeuwen/go-bindata
it supports a debug/dev mode where it just pulls the latest file from disk as they are requested, and compiles it in for prod builds.  that way it's always fast, and always up to date in dev mode.


Also, can you provide the full command that you have used?


@toadkicker i'll just do major releases over bootstrap changes, so latest gem release August 11, 2014. Minor PR's just not needed to be as gem release, using Git branch (dev branch) as more better. (I'll got lots of messages to decide to keep in development branch).  So if you think regular minor PR releases are better I can do it.


I think this should be `getErrorStream()`?


Yea, we could potentially make up to 5x as many requests, but in practice we're more efficient because every request is going to fetch 100 rows (except the last one). Previously iterations of this would return 500 rows only if the object IDs were well-packed, which wasn't always the case.


error: 'CODE_res_p_q' undeclared (first use in this function)


rax retry tests


esc is a proper file embedder. go-bindata doesn't have the features I want: http://mattjibson.com/blog/2014/11/19/esc-embedding-static-assets/


Looks ready to go.


add class CacheEntry


oh nice. thanks for the explanation!


saw approval from alexcrichton
at https://github.com/retep998/rust/commit/ee1ca88213133a58f0a9d234f03babbebeb7c5d8


merging retep998/rust/master = ee1ca882 into auto


status: {"merge_sha": "4fd1e6235dd241939475f79c8f58a455f5996690"}


retep998/rust/master = ee1ca882 merged ok, testing candidate = 4fd1e623


Thanks for the update.


Their JSON structure isn't very good.


Yes, good catch.


Correct. Will remove under same tag.


Thanks dude!


No problem! :+1:


I don't like the use of , in the for() as it is difficult to read, and rare enough to surprise most readers.
I'd rather have the counting before the for.

If I knew better, I would replace for by foreach() in this example anyway.


r=nikomatsakis rollup


4: I102 copyright year is outdated, expected 2015 but got 2014


4: I102 copyright year is outdated, expected 2015 but got 2014
155: D400 First line should end with '.', not 'n'
155: D205 Blank line missing between one-line summary and description
212: D401 First line should be imperative: 'Fetche', not 'Fetches'
212: D400 First line should end with '.', not 'd'
212: D205 Blank line missing between one-line summary and description
222: D401 First line should be imperative: 'Update', not 'Updates'
222: D400 First line should end with '.', not 'l'
222: D205 Blank line missing between one-line summary and description
234: D205 Blank line missing between one-line summary and description
253: D205 Blank line missing between one-line summary and description
262: D400 First line should end with '.', not 'e'
262: D205 Blank line missing between one-line summary and description
271: D400 First line should end with '.', not 'e'
271: D205 Blank line missing between one-line summary and description
278: D400 First line should end with '.', not 'd'
278: D205 Blank line missing between one-line summary and description
290: D400 First line should end with '.', not 'o'
290: D205 Blank line missing between one-line summary and description
400: D401 First line should be imperative: 'Find', not 'Finds'
400: D400 First line should end with '.', not 'y'
403: D400 First line should end with '.', not 's'
438: D401 First line should be imperative: 'Find', not 'Finds'
479: D400 First line should end with '.', not 'e'
479: D205 Blank line missing between one-line summary and description


In fact also : The 2(or 3) ```return failed_output``` bit me..

is it really valid/acceptable to have such macro with invalid timestamp or "missing" timeperiod ?


should fix #14


@victorlin the original balanced/vault supports this.


It does.  It is a peculiarity with ecm.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9990/testReport/) for this commit**


Why would you want in any way to use glibc's namespace for symbols?


4660-GLHE_Vertical_Input_Fixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Quibble: you could use the "variable in if" idiom:

    if (auto il = getApp().getInboundLedgers().findCreate (
            ledgerHash, 0, InboundLedger::fcGENERIC))
          return il;
    return RPC::make_error ( ...


As usual naming convention, the package name start with lowercase


@konstmsu? I'm trying to merge your changes, but I don't really understand this spec.


Nice. I like how much code it results in deleting. I guess you've tried it out in a Rails 4 app?
I'll want to get this merged in but I've been thinking about the approach of what to do with this next.

Here's my unclear points:

* Not sure what kind of versioning/branching to do. Jumping up by a whole number maybe makes sense, but version 1.x also implies stable or complete, and I don't feel like it's there yet. Not your pull request, but the project as a whole.
* I am still likely to be doing a bit of work against the older stuff. Anecdotal, but older projects seem less likely to have tests and hence factories in place. This would mean forward/backporting changes between the versions/branches.
* Perhaps it makes sense to have some tests against an embedded Rails app?
* I'm wondering if we stay with the new FactoryGirl syntax and but still test against different versions of ActiveRecord. I.e. relax the AR version constraint for this PR. That might at least result in fewer/simpler porting of changes from old to new stuff.
* I've asked on a mailing list for pointers just on the off-chance that some others have done something similar or have any insight into obvious approaches.

What do you think? I think my main concern will be the forward-porting changes and if that becomes burdensome. The rest are just things to think about/decide upon.

I'd like to have a little time to get some changes in. Say a week or so at most. If I don't do anything in that time, then we'll merge it in, if I do then we can get the changes ported into this version before maintaining two branches.


That quibble you can probably ignore.  Aside from that, I think this is ready to go?

:+1:


@Keruspe :+1:


155: D400 First line should end with '.', not 'n'
155: D205 Blank line missing between one-line summary and description
212: D401 First line should be imperative: 'Fetche', not 'Fetches'
212: D400 First line should end with '.', not 'd'
212: D205 Blank line missing between one-line summary and description
222: D401 First line should be imperative: 'Update', not 'Updates'
222: D400 First line should end with '.', not 'l'
222: D205 Blank line missing between one-line summary and description
234: D205 Blank line missing between one-line summary and description
253: D205 Blank line missing between one-line summary and description
262: D400 First line should end with '.', not 'e'
262: D205 Blank line missing between one-line summary and description
271: D400 First line should end with '.', not 'e'
271: D205 Blank line missing between one-line summary and description
278: D400 First line should end with '.', not 'd'
278: D205 Blank line missing between one-line summary and description
290: D400 First line should end with '.', not 'o'
290: D205 Blank line missing between one-line summary and description
400: D401 First line should be imperative: 'Find', not 'Finds'
400: D400 First line should end with '.', not 'y'
403: D400 First line should end with '.', not 's'
438: D401 First line should be imperative: 'Find', not 'Finds'
479: D400 First line should end with '.', not 'e'
479: D205 Blank line missing between one-line summary and description


True but in order to find the 'kb_session_id', the key from the table is {kb_username, kb_tenant_id}, so how can we not store it?


sorry, my wording was not choosen carefully.

anyway, too bad about the feature mismatch, i really think a dev mode where it pulls files as-is is perfect, because now i have to worry about running go generate myself whenever i change a file, and I don't see another solution?


reference #2


Thanks, father.


@SergioEstevao https://github.com/wordpress-mobile/WordPress-iOS/commit/e073d1b20dcde5dde3a1b646d66085e8fe98c77a#diff-bfe92dd8d5ba1050984a45f51fb9ca53R896 introduced a warning:

![image](https://cloud.githubusercontent.com/assets/437043/5727209/25d94a74-9b16-11e4-8e8e-51266640a65d.png)


import junit.framework.Assert;
import org.junit.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.firefox.FirefoxDriver;

public class NFLSCORE

	{
	@Test
	public void TestTitle()

	{
	WebDriver dr= new FirefoxDriver();
	dr.get("http://espn.go.com/");

        //Clicking on NFL link
	dr.findElement(By.name("&lpos=sitenavdefault&lid=sitenav_nfl")).click();

        //Clicking on Score link
	dr.findElement(By.name("&lpos=subnav&lid=subnav_NFL_Scoreboard")).click();

        //Validating the page title
	String ptitle=dr.getTitle();
	Assert.assertTrue("Title not found!", ptitle.contains("NFL Scoreboard"));

	}
	}


Methods have been renamed, see 82e2a70aa21e8958a3a4bf7b97af264a316e1c49


Ah! Ok, I see now. I didn't realize the two values were different. To my knowledge about Battlegrounds, isn't the max 10 per side which would be 20 players anyways? Is there a reason we default it to 30?


Why these changes? Perhaps merge failure?


Also here?


Noice


Yes that's correct. It will show up in the table.


wot

—
Sent from Mailbox

On Tue, Jan 13, 2015 at 8:23 PM, Zyluss <notifications@github.com> wrote:

> Noice
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Creeper32605/ctdbungee/commit/c03d135db6770af6ab7c364de8e864fd82b726ff#commitcomment-9265916


I don't understand what is going on here. `nat -> nat` should not be decidable.
Perhaps there is an hypothesis hiding somewhere that I fail to  locate in this github interface.
In any case, I think more documentation would help.


Can you use the standard [`detectEquilibration()`](https://github.com/choderalab/pymbar/blob/master/pymbar/timeseries.py#L710) method?  You can control the resolution of equilibration endpoints it searches with the `nskip` argument.


just changed it.


Renamed 'Ticker' component to 'Thing', because ticker is already used to represent the time ticking every 1 second. Just a naming issue.


r+


@sendhil Strange, I did not see that in my XCode env originally. However, I just did a fresh clone and there she be. :-/


Don't confuse `Decidable` with `DecidablePaths`.  `nat -> nat` is decidable because it's inhabited.


int main(int argv, char* args[])


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9991/testReport/) for this commit**


4single peptides:

1.
Protein Name:	 	HLA class I histocompatibility antigen, A-2 alpha chain
Gene:	 	HLA-A
Organism Scientific:	 	Homo sapiens
Organism Common	:  	        Human

signal peptide   	   	   	1     -  	24
transmembrane region   	    	309  - 	332

2.
Protein Name	 	Apical endosomal glycoprotein
Gene	 	Mamdc4
Organism Scientific	 	Mus musculus
Organism Common	 	Mouse

signal peptide   	   	1-   	21
transmembrane region   	     	1160 -   	1180

3.
Protein Name	 	Arylsulfatase I
Gene	 	ARSI
Organism Scientific	 	Canis familiaris
Organism Common	 	Dog

signal peptide   	 	1-   	23

4.
Protein Name	 	Kappa-casein
Gene	 	CSN3
Organism Scientific	 	Cavia porcellus
Organism Common	 	Guinea pig

signal peptide   	  	1 -  	21


saw approval from pcwalton
at https://github.com/glennw/servo/commit/f7b83d9a76fa17a565fec2a30c5b1199971e3a25


merging glennw/servo/cef-tabs = f7b83d9a into auto


glennw/servo/cef-tabs = f7b83d9a merged ok, testing candidate = 9b6d979f


@gorandev I've started working on testing the AlterSortedManyToManyField, but it's a bit ugly, with prepared models and migrations being copied around. I have run into a problem when the migrations are run, see below. I'm not sure if this is an error on my part or is something else (e.g. when I tested the operation on a real application of mine, the sort_value got the *string* value "sort_value"). Do you have any ideas?

```python
Traceback (most recent call last):
  File "/home/ogre/www/django-sortedm2m/sortedm2m_tests/test_migrations.py", line 103, in test_data_migration
    call_command('migrate')
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 115, in call_command
    return klass.execute(*args, **defaults)
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/core/management/commands/migrate.py", line 161, in handle
    executor.migrate(targets, plan, fake=options.get("fake", False))
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/db/migrations/executor.py", line 68, in migrate
    self.apply_migration(migration, fake=fake)
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/db/migrations/executor.py", line 102, in apply_migration
    migration.apply(project_state, schema_editor)
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/db/migrations/migration.py", line 108, in apply
    operation.database_forwards(self.app_label, schema_editor, project_state, new_state)
  File "/home/ogre/www/django-sortedm2m/sortedm2m/operations.py", line 24, in database_forwards
    schema_editor.add_field(m2m_model, self.make_sort_by_field(m2m_model))
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/db/backends/sqlite3/schema.py", line 177, in add_field
    self._remake_table(model, create_fields=[field])
  File "/home/ogre/www/venv-sortedm2m/local/lib/python2.7/site-packages/django/db/backends/sqlite3/schema.py", line 75, in _remake_table
    self.effective_default(field)
AttributeError: 'IntegerField' object has no attribute 'column'
```


Notice that I removed `out$` from the ThingModel. It was not being used by ThingView anyway. Looks like you wanted to use ThingDataFlowNode as a function. The important distinction to be made here is that ThingDataFlowNode should ONLY be concerned about the internal state of the Thing widget that it implements. `out$` seems to be some business logic related data, so it should not live here.
In Cycle, Model is not always business logic/data. Model is just "information". Information in the context of a Thing widget is "what is its content, what is its id, and is it selected".
On the other hand, in the context of game behavior, Model (in line 69) is indeed business logic/data.


rax retry tests


add getMessage method


![Noice] (http://31.media.tumblr.com/38b37807f8a09ea418ef2c749b214682/tumblr_n0l51qyjAJ1sgktl7o3_400.gif)


Ah, of course! Would InhDecidable be clearer ?

LGTM.

On Tue, Jan 13, 2015 at 8:25 PM, Mike Shulman <notifications@github.com>
wrote:

> Don't confuse Decidable with DecidablePaths. nat -> nat is decidable
> because it's inhabited.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mikeshulman/HoTT/commit/de9ba6d5273dca034346f6a2eabba654a9a634e3#commitcomment-9265947>
> .
>


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:222](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/include/chaiscript/dispatchkit/type_conversions.hpp#L222) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:557](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/include/chaiscript/dispatchkit/boxed_number.hpp#L557) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __warning__: [include/chaiscript/dispatchkit/proxy_functions.hpp:269](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/include/chaiscript/dispatchkit/proxy_functions.hpp#L269) The class 'Dynamic_Proxy_Function' defines member variable with name 'm_arity' also defined in its parent class 'Proxy_Function_Base'. (duplInheritedMember)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:170](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/src/main.cpp#L170) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:137](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/src/main.cpp#L137) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:217](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/src/main.cpp#L217) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:159](../blob/3f23e57a3dd116420ad06517ce7fdaf891a29d23/src/main.cpp#L159) The function 'throws_exception' is never used. (unusedFunction)


Seems like the `animation` only works for the first time in Firefox, after that the tooltip appears instantly.


Done.


@curlymorphic Maybe you meant `(i > 0 && i < 7)` here? I find it weird that the second control uses resonance.


gods sake

—
Sent from Mailbox

On Tue, Jan 13, 2015 at 8:29 PM, Zyluss <notifications@github.com> wrote:

> ![Noice] (http://31.media.tumblr.com/38b37807f8a09ea418ef2c749b214682/tumblr_n0l51qyjAJ1sgktl7o3_400.gif)
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Creeper32605/ctdbungee/commit/c03d135db6770af6ab7c364de8e864fd82b726ff#commitcomment-9266016


Don't use `attributes.get('num$')` if the View isn't created with `Cycle.createView(function (attributes, model) {` (which also requires us to inject the attributes into the View). A natural place for this whole ThingDataFlowNode to handle attributes is in the ThingModel, so that's where these attributes are.


Its category is Physical. If you mean if it's changed to Fairy, then, yes, it is.


1: M111 unrecognized component name: oauthclient


1: D290 White spaces around docstring should be trimmed.
42: D290 White spaces around docstring should be trimmed.
47: D290 White spaces around docstring should be trimmed.
64: D290 White spaces around docstring should be trimmed.
75: D290 White spaces around docstring should be trimmed.
86: D290 White spaces around docstring should be trimmed.
109: D290 White spaces around docstring should be trimmed.
137: D290 White spaces around docstring should be trimmed.
146: D290 White spaces around docstring should be trimmed.
170: D290 White spaces around docstring should be trimmed.
180: D290 White spaces around docstring should be trimmed.
243: D290 White spaces around docstring should be trimmed.
263: D290 White spaces around docstring should be trimmed.
329: D290 White spaces around docstring should be trimmed.
338: D290 White spaces around docstring should be trimmed.
355: D290 White spaces around docstring should be trimmed.


1: D290 White spaces around docstring should be trimmed.
58: D290 White spaces around docstring should be trimmed.
72: D290 White spaces around docstring should be trimmed.


155: D400 First line should end with '.', not 'n'
155: D205 Blank line missing between one-line summary and description
212: D401 First line should be imperative: 'Fetche', not 'Fetches'
212: D400 First line should end with '.', not 'd'
212: D205 Blank line missing between one-line summary and description
222: D401 First line should be imperative: 'Update', not 'Updates'
222: D400 First line should end with '.', not 'l'
222: D205 Blank line missing between one-line summary and description
234: D205 Blank line missing between one-line summary and description
253: D205 Blank line missing between one-line summary and description
262: D400 First line should end with '.', not 'e'
262: D205 Blank line missing between one-line summary and description
271: D400 First line should end with '.', not 'e'
271: D205 Blank line missing between one-line summary and description
278: D400 First line should end with '.', not 'd'
278: D205 Blank line missing between one-line summary and description
290: D400 First line should end with '.', not 'o'
290: D205 Blank line missing between one-line summary and description
400: D401 First line should be imperative: 'Find', not 'Finds'
400: D400 First line should end with '.', not 'y'
403: D400 First line should end with '.', not 's'
438: D401 First line should be imperative: 'Find', not 'Finds'
479: D400 First line should end with '.', not 'e'
479: D205 Blank line missing between one-line summary and description


Notice that `total` is not necessary to specify in the Initial, since it's a computed property and it will be initially computed as zero at startup anyways.


You mean you want to rename the class `Decidable`?  This is the terminology used in the book, at least...


BTW, uncomment the ```shutil.move``` in test_migrations if you want to test this, otherwise the changed models file will be left around


@mahmoudimus yeah, I saw that, I will bring it in


Repo for the Data Scientist's Toolbox course on Coursera.


if the whole macro thing here (and the other return failed_output too) is bad, why return some *failed_output* instead of raising an exception ?
'cause returning the failed_output just silent the error.. which is bad.


Should we really class it like LORD_JARAXXUS? Hearthhead and the JSON file both says that the class i WARLOCK.


En liten heads up, denna rad kommer skriva ut innehåll utanför din HTML-markup.


Because the users of those symbols are glibc apps. Using android_dlsym() kinda works, but when using functions with float arguments, such as glClearColor, they are off.


maybe you like this ;)

" Highlight characters in lines longer than 80 chars
highlight OverLength ctermbg=red ctermfg=white guibg=#592929
match OverLength /\%81v.\+/


Do not need to do this own detriment


Should be fixed in the upcoming 2.1.0 version


I agree, requiring config for a plugin you're not using is rude.

I think #4 covers this case - if you don't specify a url, #4 will force it to be disabled.


Hello There,
I am not used to with github.com. It took me a little while to understand it. Sorry for the confusion.


@bors: retry
* #3595


1: D100 Docstring missing
4: I102 copyright year is outdated, expected 2015 but got 2014
45:6: E126 continuation line over-indented for hanging indent
69:31: E126 continuation line over-indented for hanging indent
104:1: F999 redefinition of unused 'search_pattern' from line 87
107:48: E126 continuation line over-indented for hanging indent
126:1: E302 expected 2 blank lines, found 0
126: D200 One-line docstring should not occupy 3 lines
130:30: E261 at least two spaces before inline comment
146:1: E302 expected 2 blank lines, found 1
146: D400 First line should end with '.', not 'd'
154:1: E302 expected 2 blank lines, found 1
154: D401 First line should be imperative: 'Resolve', not 'Resolves'
154: D209 Put multi-line docstring closing quotes on separate line
154: D202 No blank lines allowed *after* function docstring, found 1
154: D400 First line should end with '.', not 's'
154: D205 Blank line missing between one-line summary and description
161:12: E713 test for membership should be 'not in'
171:1: E302 expected 2 blank lines, found 0
171: D401 First line should be imperative: 'Thi', not 'This'
171: D400 First line should end with '.', not 't'
171: D205 Blank line missing between one-line summary and description
202:1: E302 expected 2 blank lines, found 1
202: D400 First line should end with '.', not 's'
202: D205 Blank line missing between one-line summary and description
203:9: E128 continuation line under-indented for visual indent
228:5: E303 too many blank lines (2)
232:25: E261 at least two spaces before inline comment
264:92: E203 whitespace before ','
268:5: E122 continuation line missing indentation or outdented
383:13: E125 continuation line with same indent as next logical line
390:25: E128 continuation line under-indented for visual indent
424:98: E228 missing whitespace around modulo operator
443:18: E225 missing whitespace around operator
469:21: E128 continuation line under-indented for visual indent
474:41: E128 continuation line under-indented for visual indent
475:41: E128 continuation line under-indented for visual indent
497:38: E261 at least two spaces before inline comment
617:21: E128 continuation line under-indented for visual indent
622:13: E128 continuation line under-indented for visual indent
622:13: E125 continuation line with same indent as next logical line
639:25: E128 continuation line under-indented for visual indent
644:21: E128 continuation line under-indented for visual indent
669:1: E302 expected 2 blank lines, found 1
669: D400 First line should end with '.', not 'd'
669: D205 Blank line missing between one-line summary and description
685:1: E302 expected 2 blank lines, found 1
685: D400 First line should end with '.', not 'r'
685: D205 Blank line missing between one-line summary and description
698:39: E251 unexpected spaces around keyword / parameter equals
698:41: E251 unexpected spaces around keyword / parameter equals
699:37: E128 continuation line under-indented for visual indent
699:38: E251 unexpected spaces around keyword / parameter equals
699:40: E251 unexpected spaces around keyword / parameter equals
700:37: E128 continuation line under-indented for visual indent
700:44: E202 whitespace before ')'
700:38: E251 unexpected spaces around keyword / parameter equals
700:40: E251 unexpected spaces around keyword / parameter equals
705:35: E251 unexpected spaces around keyword / parameter equals
705:37: E251 unexpected spaces around keyword / parameter equals
706:33: E128 continuation line under-indented for visual indent
706:34: E251 unexpected spaces around keyword / parameter equals
706:36: E251 unexpected spaces around keyword / parameter equals
707:33: E128 continuation line under-indented for visual indent
707:40: E202 whitespace before ')'
707:34: E251 unexpected spaces around keyword / parameter equals
707:36: E251 unexpected spaces around keyword / parameter equals
719:1: E302 expected 2 blank lines, found 1
719: D103 Docstring missing
729:40: E261 at least two spaces before inline comment
741:76: E251 unexpected spaces around keyword / parameter equals
741:78: E251 unexpected spaces around keyword / parameter equals
742:54: E128 continuation line under-indented for visual indent
742:58: E251 unexpected spaces around keyword / parameter equals
742:60: E251 unexpected spaces around keyword / parameter equals
743:54: E128 continuation line under-indented for visual indent
743:61: E251 unexpected spaces around keyword / parameter equals
743:63: E251 unexpected spaces around keyword / parameter equals
744:54: E128 continuation line under-indented for visual indent
744:61: E251 unexpected spaces around keyword / parameter equals
744:63: E251 unexpected spaces around keyword / parameter equals
745:54: E128 continuation line under-indented for visual indent
745:62: E251 unexpected spaces around keyword / parameter equals
745:64: E251 unexpected spaces around keyword / parameter equals
748:5: E303 too many blank lines (2)
748:76: E251 unexpected spaces around keyword / parameter equals
748:78: E251 unexpected spaces around keyword / parameter equals
749:54: E128 continuation line under-indented for visual indent
749:58: E251 unexpected spaces around keyword / parameter equals
749:60: E251 unexpected spaces around keyword / parameter equals
750:54: E128 continuation line under-indented for visual indent
750:61: E251 unexpected spaces around keyword / parameter equals
750:63: E251 unexpected spaces around keyword / parameter equals
751:54: E128 continuation line under-indented for visual indent
751:61: E251 unexpected spaces around keyword / parameter equals
751:63: E251 unexpected spaces around keyword / parameter equals
752:54: E128 continuation line under-indented for visual indent
752:62: E251 unexpected spaces around keyword / parameter equals
752:64: E251 unexpected spaces around keyword / parameter equals
754:1: E302 expected 2 blank lines, found 1
754: D400 First line should end with '.', not 't'
754: D205 Blank line missing between one-line summary and description
796:1: E302 expected 2 blank lines, found 1
796: D103 Docstring missing
816:1: E302 expected 2 blank lines, found 1
816: D400 First line should end with '.', not 's'
820:40: E502 the backslash is redundant between brackets
826:68: E202 whitespace before '}'
829:1: E302 expected 2 blank lines, found 1
829: D400 First line should end with '.', not 'a'
847:1: E302 expected 2 blank lines, found 1
847: D400 First line should end with '.', not 's'
860:29: E231 missing whitespace after ':'
863:1: E302 expected 2 blank lines, found 1
863: D400 First line should end with '.', not ','
863: D205 Blank line missing between one-line summary and description
863: D208 Docstring is over-indented
878:1: E302 expected 2 blank lines, found 1
878: D205 Blank line missing between one-line summary and description
884:21: E127 continuation line over-indented for visual indent
890:1: E302 expected 2 blank lines, found 1
890: D205 Blank line missing between one-line summary and description
900:21: E127 continuation line over-indented for visual indent
901:21: E128 continuation line under-indented for visual indent
907:44: E261 at least two spaces before inline comment
907:45: E262 inline comment should start with '# '
911:1: E302 expected 2 blank lines, found 1
911: D205 Blank line missing between one-line summary and description
924:21: E128 continuation line under-indented for visual indent
925:21: E128 continuation line under-indented for visual indent
958:1: E302 expected 2 blank lines, found 1
958: D205 Blank line missing between one-line summary and description
968:21: E127 continuation line over-indented for visual indent
969:21: E128 continuation line under-indented for visual indent
975:44: E261 at least two spaces before inline comment
975:45: E262 inline comment should start with '# '
979:1: E302 expected 2 blank lines, found 1
979: D205 Blank line missing between one-line summary and description
990:21: E127 continuation line over-indented for visual indent
991:21: E128 continuation line under-indented for visual indent
1006:21: E128 continuation line under-indented for visual indent
1007:21: E128 continuation line under-indented for visual indent
1014:1: E302 expected 2 blank lines, found 1
1014: D290 White spaces around docstring should be trimmed.
1021:1: E302 expected 2 blank lines, found 1
1021:64: E251 unexpected spaces around keyword / parameter equals
1021:66: E251 unexpected spaces around keyword / parameter equals
1021: D202 No blank lines allowed *after* function docstring, found 1
1021: D400 First line should end with '.', not 'I'
1021: D205 Blank line missing between one-line summary and description
1071:35: E122 continuation line missing indentation or outdented
1085:13: E128 continuation line under-indented for visual indent
1086:13: E128 continuation line under-indented for visual indent
1086:62: E502 the backslash is redundant between brackets
1087:13: E128 continuation line under-indented for visual indent
1088:13: E128 continuation line under-indented for visual indent
1088:62: E502 the backslash is redundant between brackets
1089:13: E128 continuation line under-indented for visual indent
1090:13: E128 continuation line under-indented for visual indent
1092:30: E261 at least two spaces before inline comment
1093:62: E502 the backslash is redundant between brackets
1108:17: E128 continuation line under-indented for visual indent
1113:13: E128 continuation line under-indented for visual indent
1114:62: E502 the backslash is redundant between brackets
1116:62: E502 the backslash is redundant between brackets
1139:37: E128 continuation line under-indented for visual indent
1147:13: E128 continuation line under-indented for visual indent
1148:46: E502 the backslash is redundant between brackets
1150:46: E502 the backslash is redundant between brackets
1154:35: E261 at least two spaces before inline comment
1155:66: E502 the backslash is redundant between brackets
1169:17: E128 continuation line under-indented for visual indent
1184:74: E502 the backslash is redundant between brackets
1185:81: E502 the backslash is redundant between brackets
1192:93: E502 the backslash is redundant between brackets
1193:84: E502 the backslash is redundant between brackets
1194:79: E502 the backslash is redundant between brackets
1200:35: E127 continuation line over-indented for visual indent
1204:17: E128 continuation line under-indented for visual indent
1210:70: E502 the backslash is redundant between brackets
1211:65: E502 the backslash is redundant between brackets
1212:71: E502 the backslash is redundant between brackets
1219:73: E502 the backslash is redundant between brackets
1220:72: E502 the backslash is redundant between brackets
1226:1: E302 expected 2 blank lines, found 1
1226: D400 First line should end with '.', not 'r'
1226: D205 Blank line missing between one-line summary and description
1244:23: E126 continuation line over-indented for hanging indent
1259:1: E302 expected 2 blank lines, found 1
1259: D400 First line should end with '.', not 'e'
1275:9: E128 continuation line under-indented for visual indent
1290:1: E302 expected 2 blank lines, found 1
1290: D400 First line should end with '.', not 't'
1293:19: E222 multiple spaces after operator
1302:15: E221 multiple spaces before operator
1307:1: E302 expected 2 blank lines, found 1
1307: D400 First line should end with '.', not 'x'
1346:1: E302 expected 2 blank lines, found 1
1346: D400 First line should end with '.', not 'x'
1347:9: E128 continuation line under-indented for visual indent
1350:32: E225 missing whitespace around operator
1362:1: E302 expected 2 blank lines, found 1
1375: D400 First line should end with '.', not 't'
1375: D205 Blank line missing between one-line summary and description
1401: D400 First line should end with '.', not 'y'
1401: D205 Blank line missing between one-line summary and description
1412:36: E261 at least two spaces before inline comment
1412:37: E262 inline comment should start with '# '
1419:21: E128 continuation line under-indented for visual indent
1433:17: E128 continuation line under-indented for visual indent
1440:17: E128 continuation line under-indented for visual indent
1442: D400 First line should end with '.', not 'f'
1442: D205 Blank line missing between one-line summary and description
1514:1: E302 expected 2 blank lines, found 1
1516:26: E711 comparison to None should be 'if cond is not None:'
1522:53: E251 unexpected spaces around keyword / parameter equals
1522:55: E251 unexpected spaces around keyword / parameter equals
1522:70: E251 unexpected spaces around keyword / parameter equals
1522:72: E251 unexpected spaces around keyword / parameter equals
1522: D400 First line should end with '.', not 's'
1522: D200 One-line docstring should not occupy 3 lines
1523:32: E251 unexpected spaces around keyword / parameter equals
1523:34: E251 unexpected spaces around keyword / parameter equals
1549:26: E711 comparison to None should be 'if cond is None:'
1550:32: E711 comparison to None should be 'if cond is None:'
1560:32: E711 comparison to None should be 'if cond is not None:'
1564:41: E203 whitespace before ','
1564:51: E251 unexpected spaces around keyword / parameter equals
1564:53: E251 unexpected spaces around keyword / parameter equals
1565:35: E251 unexpected spaces around keyword / parameter equals
1565:37: E251 unexpected spaces around keyword / parameter equals
1565:58: E251 unexpected spaces around keyword / parameter equals
1565:60: E251 unexpected spaces around keyword / parameter equals
1567:17: E714 test for object identity should be 'is not'
1570:56: E251 unexpected spaces around keyword / parameter equals
1570:58: E251 unexpected spaces around keyword / parameter equals
1571:58: E251 unexpected spaces around keyword / parameter equals
1571:60: E251 unexpected spaces around keyword / parameter equals
1572:57: E251 unexpected spaces around keyword / parameter equals
1572:59: E251 unexpected spaces around keyword / parameter equals
1575:1: E302 expected 2 blank lines, found 1
1575:68: E251 unexpected spaces around keyword / parameter equals
1575:70: E251 unexpected spaces around keyword / parameter equals
1575:83: E251 unexpected spaces around keyword / parameter equals
1575:85: E251 unexpected spaces around keyword / parameter equals
1575: D400 First line should end with '.', not 's'
1575: D200 One-line docstring should not occupy 3 lines
1584:36: E261 at least two spaces before inline comment
1584:37: E262 inline comment should start with '# '
1605:17: E303 too many blank lines (2)
1605:31: E711 comparison to None should be 'if cond is None:'
1606:37: E711 comparison to None should be 'if cond is None:'
1614:104: E502 the backslash is redundant between brackets
1615:53: E127 continuation line over-indented for visual indent
1619:37: E711 comparison to None should be 'if cond is not None:'
1630:31: E711 comparison to None should be 'if cond is None:'
1631:37: E711 comparison to None should be 'if cond is None:'
1642:37: E711 comparison to None should be 'if cond is not None:'
1647:17: E303 too many blank lines (3)
1664:58: E251 unexpected spaces around keyword / parameter equals
1664:60: E251 unexpected spaces around keyword / parameter equals
1665:60: E251 unexpected spaces around keyword / parameter equals
1665:62: E251 unexpected spaces around keyword / parameter equals
1666:60: E251 unexpected spaces around keyword / parameter equals
1666:62: E251 unexpected spaces around keyword / parameter equals
1667:61: E251 unexpected spaces around keyword / parameter equals
1667:63: E251 unexpected spaces around keyword / parameter equals
1668:61: E251 unexpected spaces around keyword / parameter equals
1668:63: E251 unexpected spaces around keyword / parameter equals
1669:61: E251 unexpected spaces around keyword / parameter equals
1669:63: E251 unexpected spaces around keyword / parameter equals
1670:61: E251 unexpected spaces around keyword / parameter equals
1670:63: E251 unexpected spaces around keyword / parameter equals
1678:34: E128 continuation line under-indented for visual indent
1679:34: E128 continuation line under-indented for visual indent
1680:34: E128 continuation line under-indented for visual indent
1690:28: E711 comparison to None should be 'if cond is None:'
1691:60: E251 unexpected spaces around keyword / parameter equals
1691:62: E251 unexpected spaces around keyword / parameter equals
1692:53: E127 continuation line over-indented for visual indent
1692:64: E251 unexpected spaces around keyword / parameter equals
1692:66: E251 unexpected spaces around keyword / parameter equals
1693:53: E127 continuation line over-indented for visual indent
1693:64: E251 unexpected spaces around keyword / parameter equals
1693:66: E251 unexpected spaces around keyword / parameter equals
1694:53: E127 continuation line over-indented for visual indent
1694:63: E251 unexpected spaces around keyword / parameter equals
1694:65: E251 unexpected spaces around keyword / parameter equals
1695:53: E127 continuation line over-indented for visual indent
1695:64: E251 unexpected spaces around keyword / parameter equals
1695:66: E251 unexpected spaces around keyword / parameter equals
1696:53: E127 continuation line over-indented for visual indent
1696:64: E251 unexpected spaces around keyword / parameter equals
1696:66: E251 unexpected spaces around keyword / parameter equals
1697:53: E127 continuation line over-indented for visual indent
1697:61: E251 unexpected spaces around keyword / parameter equals
1697:63: E251 unexpected spaces around keyword / parameter equals
1705:72: E251 unexpected spaces around keyword / parameter equals
1705:74: E251 unexpected spaces around keyword / parameter equals
1713:1: E302 expected 2 blank lines, found 1
1713: D202 No blank lines allowed *after* function docstring, found 1
1713: D400 First line should end with '.', not 's'
1713: D205 Blank line missing between one-line summary and description
1714:31: E251 unexpected spaces around keyword / parameter equals
1714:33: E251 unexpected spaces around keyword / parameter equals
1714:46: E251 unexpected spaces around keyword / parameter equals
1714:48: E251 unexpected spaces around keyword / parameter equals
1730: D401 First line should be imperative: 'Add', not 'Adds'
1734:24: E261 at least two spaces before inline comment
1747: D401 First line should be imperative: 'Add', not 'Adds'
1782:12: E713 test for membership should be 'not in'
1799:31: E261 at least two spaces before inline comment
1799:32: E262 inline comment should start with '# '
1800:31: E251 unexpected spaces around keyword / parameter equals
1800:33: E251 unexpected spaces around keyword / parameter equals
1802:34: E261 at least two spaces before inline comment
1802:35: E262 inline comment should start with '# '
1803:31: E251 unexpected spaces around keyword / parameter equals
1803:33: E251 unexpected spaces around keyword / parameter equals
1803:50: E251 unexpected spaces around keyword / parameter equals
1803:52: E251 unexpected spaces around keyword / parameter equals
1805:12: E714 test for object identity should be 'is not'
1806:52: E251 unexpected spaces around keyword / parameter equals
1806:54: E251 unexpected spaces around keyword / parameter equals
1806:76: E251 unexpected spaces around keyword / parameter equals
1806:78: E251 unexpected spaces around keyword / parameter equals
1808:12: E714 test for object identity should be 'is not'
1809:52: E251 unexpected spaces around keyword / parameter equals
1809:54: E251 unexpected spaces around keyword / parameter equals
1810:50: E251 unexpected spaces around keyword / parameter equals
1810:52: E251 unexpected spaces around keyword / parameter equals
1810:67: E251 unexpected spaces around keyword / parameter equals
1810:69: E251 unexpected spaces around keyword / parameter equals
1811:12: E714 test for object identity should be 'is not'
1812:52: E251 unexpected spaces around keyword / parameter equals
1812:54: E251 unexpected spaces around keyword / parameter equals
1813:50: E251 unexpected spaces around keyword / parameter equals
1813:52: E251 unexpected spaces around keyword / parameter equals
1813:67: E251 unexpected spaces around keyword / parameter equals
1813:69: E251 unexpected spaces around keyword / parameter equals
1814:54: E251 unexpected spaces around keyword / parameter equals
1814:56: E251 unexpected spaces around keyword / parameter equals
1815:12: E714 test for object identity should be 'is not'
1816:52: E251 unexpected spaces around keyword / parameter equals
1816:54: E251 unexpected spaces around keyword / parameter equals
1817:50: E251 unexpected spaces around keyword / parameter equals
1817:52: E251 unexpected spaces around keyword / parameter equals
1817:69: E251 unexpected spaces around keyword / parameter equals
1817:71: E251 unexpected spaces around keyword / parameter equals
1825:5: E303 too many blank lines (2)
1825:19: E261 at least two spaces before inline comment
1827:18: E261 at least two spaces before inline comment
1840:28: E261 at least two spaces before inline comment
1840:29: E262 inline comment should start with '# '
1853:13: E303 too many blank lines (2)
1868:13: E303 too many blank lines (2)
1871:60: E261 at least two spaces before inline comment
1871:61: E262 inline comment should start with '# '
1880:40: W602 deprecated form of raising exception
1888:13: E303 too many blank lines (2)
1892:26: E222 multiple spaces after operator
1900:21: E113 unexpected indentation
1901:21: E113 unexpected indentation
1902:21: E113 unexpected indentation
1916:40: W602 deprecated form of raising exception
1945:44: W602 deprecated form of raising exception
1972:13: E303 too many blank lines (2)
1978:13: E303 too many blank lines (2)
1993:40: W602 deprecated form of raising exception
1995:29: E261 at least two spaces before inline comment
1996:131: E202 whitespace before ')'
1998:40: W602 deprecated form of raising exception
2000:40: W602 deprecated form of raising exception
2002:40: W602 deprecated form of raising exception
2004:40: W602 deprecated form of raising exception
2007:44: W602 deprecated form of raising exception
2031:9: E303 too many blank lines (2)
2031:108: E202 whitespace before ')'
2083:30: E261 at least two spaces before inline comment
2091:46: E261 at least two spaces before inline comment
2106:46: E261 at least two spaces before inline comment
2286:32: E711 comparison to None should be 'if cond is None:'
2298: D290 White spaces around docstring should be trimmed.
2298: D400 First line should end with '.', not 'e'
2308:71: E203 whitespace before ','
2310:1: E302 expected 2 blank lines, found 1
2310: D400 First line should end with '.', not 't'
2325:31: E222 multiple spaces after operator
2330:19: E221 multiple spaces before operator
2335:83: E203 whitespace before ','
2348:83: E203 whitespace before ','
2351:1: E302 expected 2 blank lines, found 1
2351: D200 One-line docstring should not occupy 3 lines
2360: D400 First line should end with '.', not 'e'
2360: D205 Blank line missing between one-line summary and description
2368:21: E127 continuation line over-indented for visual indent
2374:32: E261 at least two spaces before inline comment
2374:33: E262 inline comment should start with '# '
2378:21: E261 at least two spaces before inline comment
2378:22: E262 inline comment should start with '# '
2387:17: E128 continuation line under-indented for visual indent
2390:1: E302 expected 2 blank lines, found 1
2390: D202 No blank lines allowed *after* function docstring, found 1
2390: D400 First line should end with '.', not 'r'
2485:1: E302 expected 2 blank lines, found 1
2485: D202 No blank lines allowed *after* function docstring, found 1
2485: D400 First line should end with '.', not 'd'
2498:25: E128 continuation line under-indented for visual indent
2517:21: E128 continuation line under-indented for visual indent
2526:1: E302 expected 2 blank lines, found 1
2526: D400 First line should end with '.', not 'e'
2526: D205 Blank line missing between one-line summary and description
2542:1: E302 expected 2 blank lines, found 1
2542: D401 First line should be imperative: 'Return', not 'Returns'
2542: D400 First line should end with '.', not 'e'
2542: D205 Blank line missing between one-line summary and description
2566:1: E302 expected 2 blank lines, found 1
2566: D400 First line should end with '.', not 'n'
2566: D205 Blank line missing between one-line summary and description
2578:94: E261 at least two spaces before inline comment
2578:95: E262 inline comment should start with '# '
2591:101: E261 at least two spaces before inline comment
2591:102: E262 inline comment should start with '# '
2623:1: E302 expected 2 blank lines, found 1
2623: D202 No blank lines allowed *after* function docstring, found 1
2623: D400 First line should end with '.', not 's'
2632:47: E228 missing whitespace around modulo operator
2658:41: E228 missing whitespace around modulo operator
2660:1: E302 expected 2 blank lines, found 1
2663:13: E128 continuation line under-indented for visual indent
2664:13: E128 continuation line under-indented for visual indent
2669:13: E128 continuation line under-indented for visual indent
2688:13: E128 continuation line under-indented for visual indent
2689:13: E128 continuation line under-indented for visual indent
2690:18: E128 continuation line under-indented for visual indent
2691:20: E121 continuation line under-indented for hanging indent
2706:13: E128 continuation line under-indented for visual indent
2707:13: E128 continuation line under-indented for visual indent
2708:13: E128 continuation line under-indented for visual indent
2710:1: E302 expected 2 blank lines, found 1
2710:70: E261 at least two spaces before inline comment
2710: D290 White spaces around docstring should be trimmed.
2710: D301 Use r""" if any backslashes in a docstring
2710: D202 No blank lines allowed *after* function docstring, found 1
2710: D400 First line should end with '.', not 'e'
2710: D205 Blank line missing between one-line summary and description
2802: D290 White spaces around docstring should be trimmed.
2802: D400 First line should end with '.', not 's'
2802: D205 Blank line missing between one-line summary and description
2830:1: E302 expected 2 blank lines, found 1
2830: D209 Put multi-line docstring closing quotes on separate line
2830: D400 First line should end with '.', not 'e'
2830: D205 Blank line missing between one-line summary and description
2850:1: E302 expected 2 blank lines, found 1
2850: D103 Docstring missing
2884:1: E302 expected 2 blank lines, found 1
2884: D400 First line should end with '.', not 's'
2884: D205 Blank line missing between one-line summary and description
2914:25: E251 unexpected spaces around keyword / parameter equals
2914:27: E251 unexpected spaces around keyword / parameter equals
2915:33: E251 unexpected spaces around keyword / parameter equals
2915:35: E251 unexpected spaces around keyword / parameter equals
2916:27: E251 unexpected spaces around keyword / parameter equals
2916:29: E251 unexpected spaces around keyword / parameter equals
2917:24: E251 unexpected spaces around keyword / parameter equals
2917:26: E251 unexpected spaces around keyword / parameter equals
2918:24: E251 unexpected spaces around keyword / parameter equals
2918:26: E251 unexpected spaces around keyword / parameter equals
2919:25: E251 unexpected spaces around keyword / parameter equals
2919:27: E251 unexpected spaces around keyword / parameter equals
2948:57: E502 the backslash is redundant between brackets
2949:38: E127 continuation line over-indented for visual indent
2949:69: E502 the backslash is redundant between brackets
2950:43: E127 continuation line over-indented for visual indent
2959:86: E251 unexpected spaces around keyword / parameter equals
2959:88: E251 unexpected spaces around keyword / parameter equals
2961:40: E251 unexpected spaces around keyword / parameter equals
2961:42: E251 unexpected spaces around keyword / parameter equals
2962:38: E251 unexpected spaces around keyword / parameter equals
2962:40: E251 unexpected spaces around keyword / parameter equals
2963:41: E251 unexpected spaces around keyword / parameter equals
2963:43: E251 unexpected spaces around keyword / parameter equals
2964:41: E251 unexpected spaces around keyword / parameter equals
2964:43: E251 unexpected spaces around keyword / parameter equals
2965:42: E251 unexpected spaces around keyword / parameter equals
2965:44: E251 unexpected spaces around keyword / parameter equals
2968:5: E303 too many blank lines (2)
2970:1: E302 expected 2 blank lines, found 1
2970: D290 White spaces around docstring should be trimmed.
2973:13: E128 continuation line under-indented for visual indent
2996:25: E128 continuation line under-indented for visual indent
3011:1: E302 expected 2 blank lines, found 1
3011: D103 Docstring missing
3012:40: E711 comparison to None should be 'if cond is not None:'


@schmir have you checked that this change indeed breaks standalone (#61)?


It is cucumber-jvm bug (I was created [PR](https://github.com/cucumber/cucumber-jvm/pull/825)), so adaptor is stable. Will increase version back.


Sorry, got carried away a bit. If Clojure allows ```:reload-all``` in the ns I guess I have no issues with that then.

Nonetheless, what bothers me is that all of this (ie. ```(require 'macro)```, ```analyze-deps```, ```check-uses```) happens in the **parse** function. It makes that function really complicated and hard to use.

There are plenty of other places all of this could (should) happen.

https://github.com/clojure/clojurescript/blob/e408305344ef7b3658118377e530c78c2eb93cf3/src/clj/cljs/analyzer.clj#L1872
https://github.com/clojure/clojurescript/blob/e408305344ef7b3658118377e530c78c2eb93cf3/src/clj/cljs/analyzer.clj#L1781


config_file option will always exist (since it's in the initializer)


Ah ha! Found it! Thanks! And I got a related script working again in 1fa679a . But! I don't think the docs for that endpoint are quite right if you compare my commit to what's documented.


Denna justering ska inte vara nödvändig egentligen. Enligt [PSR-2](http://www.php-fig.org/psr/psr-2/) och punkt 2.2 vore en blank rad att föredra istället:

> All PHP files MUST end with a single blank line.
>
> The closing ?> tag MUST be omitted from files containing only PHP.


I think you've introduced an extra `9`.


The code is currently correct. the HP and LP use Resonance, the remaining bands use bandwidth


Thank you for updating the doc string.

Nit: Doc strings should be complete sentences (capitalize the first word in the sentence, use a period at the end of the sentence).


Oops. My fault.


Should we put target/device_tree.cpp in .gitignore? This file should be generated by our generator.


@JDutil I'm currently trying to access the `promotion_with_order_adjustment` on a 2.4 project. Is this commit OK to be cherry picked into 2-4-stable?


underscore.js


You are right. I think that assignment is just me being cute. It should definitely match the JSON file.


I think there should be a separate pull request to move all of the information in run.md to be less then 80 chars.


1: D100 Docstring missing
45:6: E126 continuation line over-indented for hanging indent
69:31: E126 continuation line over-indented for hanging indent
104:1: F999 redefinition of unused 'search_pattern' from line 87
107:48: E126 continuation line over-indented for hanging indent
126:1: E302 expected 2 blank lines, found 0
126: D200 One-line docstring should not occupy 3 lines
130:30: E261 at least two spaces before inline comment
146:1: E302 expected 2 blank lines, found 1
146: D400 First line should end with '.', not 'd'
154:1: E302 expected 2 blank lines, found 1
154: D401 First line should be imperative: 'Resolve', not 'Resolves'
154: D209 Put multi-line docstring closing quotes on separate line
154: D202 No blank lines allowed *after* function docstring, found 1
154: D400 First line should end with '.', not 's'
154: D205 Blank line missing between one-line summary and description
161:12: E713 test for membership should be 'not in'
171:1: E302 expected 2 blank lines, found 0
171: D401 First line should be imperative: 'Thi', not 'This'
171: D400 First line should end with '.', not 't'
171: D205 Blank line missing between one-line summary and description
202:1: E302 expected 2 blank lines, found 1
202: D400 First line should end with '.', not 's'
202: D205 Blank line missing between one-line summary and description
203:9: E128 continuation line under-indented for visual indent
228:5: E303 too many blank lines (2)
232:25: E261 at least two spaces before inline comment
264:92: E203 whitespace before ','
268:5: E122 continuation line missing indentation or outdented
383:13: E125 continuation line with same indent as next logical line
390:25: E128 continuation line under-indented for visual indent
424:98: E228 missing whitespace around modulo operator
443:18: E225 missing whitespace around operator
469:21: E128 continuation line under-indented for visual indent
474:41: E128 continuation line under-indented for visual indent
475:41: E128 continuation line under-indented for visual indent
497:38: E261 at least two spaces before inline comment
617:21: E128 continuation line under-indented for visual indent
622:13: E128 continuation line under-indented for visual indent
622:13: E125 continuation line with same indent as next logical line
639:25: E128 continuation line under-indented for visual indent
644:21: E128 continuation line under-indented for visual indent
669:1: E302 expected 2 blank lines, found 1
669: D400 First line should end with '.', not 'd'
669: D205 Blank line missing between one-line summary and description
685:1: E302 expected 2 blank lines, found 1
685: D400 First line should end with '.', not 'r'
685: D205 Blank line missing between one-line summary and description
698:39: E251 unexpected spaces around keyword / parameter equals
698:41: E251 unexpected spaces around keyword / parameter equals
699:37: E128 continuation line under-indented for visual indent
699:38: E251 unexpected spaces around keyword / parameter equals
699:40: E251 unexpected spaces around keyword / parameter equals
700:37: E128 continuation line under-indented for visual indent
700:44: E202 whitespace before ')'
700:38: E251 unexpected spaces around keyword / parameter equals
700:40: E251 unexpected spaces around keyword / parameter equals
705:35: E251 unexpected spaces around keyword / parameter equals
705:37: E251 unexpected spaces around keyword / parameter equals
706:33: E128 continuation line under-indented for visual indent
706:34: E251 unexpected spaces around keyword / parameter equals
706:36: E251 unexpected spaces around keyword / parameter equals
707:33: E128 continuation line under-indented for visual indent
707:40: E202 whitespace before ')'
707:34: E251 unexpected spaces around keyword / parameter equals
707:36: E251 unexpected spaces around keyword / parameter equals
719:1: E302 expected 2 blank lines, found 1
719: D103 Docstring missing
729:40: E261 at least two spaces before inline comment
741:76: E251 unexpected spaces around keyword / parameter equals
741:78: E251 unexpected spaces around keyword / parameter equals
742:54: E128 continuation line under-indented for visual indent
742:58: E251 unexpected spaces around keyword / parameter equals
742:60: E251 unexpected spaces around keyword / parameter equals
743:54: E128 continuation line under-indented for visual indent
743:61: E251 unexpected spaces around keyword / parameter equals
743:63: E251 unexpected spaces around keyword / parameter equals
744:54: E128 continuation line under-indented for visual indent
744:61: E251 unexpected spaces around keyword / parameter equals
744:63: E251 unexpected spaces around keyword / parameter equals
745:54: E128 continuation line under-indented for visual indent
745:62: E251 unexpected spaces around keyword / parameter equals
745:64: E251 unexpected spaces around keyword / parameter equals
748:5: E303 too many blank lines (2)
748:76: E251 unexpected spaces around keyword / parameter equals
748:78: E251 unexpected spaces around keyword / parameter equals
749:54: E128 continuation line under-indented for visual indent
749:58: E251 unexpected spaces around keyword / parameter equals
749:60: E251 unexpected spaces around keyword / parameter equals
750:54: E128 continuation line under-indented for visual indent
750:61: E251 unexpected spaces around keyword / parameter equals
750:63: E251 unexpected spaces around keyword / parameter equals
751:54: E128 continuation line under-indented for visual indent
751:61: E251 unexpected spaces around keyword / parameter equals
751:63: E251 unexpected spaces around keyword / parameter equals
752:54: E128 continuation line under-indented for visual indent
752:62: E251 unexpected spaces around keyword / parameter equals
752:64: E251 unexpected spaces around keyword / parameter equals
754:1: E302 expected 2 blank lines, found 1
754: D400 First line should end with '.', not 't'
754: D205 Blank line missing between one-line summary and description
796:1: E302 expected 2 blank lines, found 1
796: D103 Docstring missing
816:1: E302 expected 2 blank lines, found 1
816: D400 First line should end with '.', not 's'
820:40: E502 the backslash is redundant between brackets
826:68: E202 whitespace before '}'
829:1: E302 expected 2 blank lines, found 1
829: D400 First line should end with '.', not 'a'
847:1: E302 expected 2 blank lines, found 1
847: D400 First line should end with '.', not 's'
860:29: E231 missing whitespace after ':'
863:1: E302 expected 2 blank lines, found 1
863: D400 First line should end with '.', not ','
863: D205 Blank line missing between one-line summary and description
863: D208 Docstring is over-indented
878:1: E302 expected 2 blank lines, found 1
878: D205 Blank line missing between one-line summary and description
884:21: E127 continuation line over-indented for visual indent
890:1: E302 expected 2 blank lines, found 1
890: D205 Blank line missing between one-line summary and description
900:21: E127 continuation line over-indented for visual indent
901:21: E128 continuation line under-indented for visual indent
907:44: E261 at least two spaces before inline comment
907:45: E262 inline comment should start with '# '
911:1: E302 expected 2 blank lines, found 1
911: D205 Blank line missing between one-line summary and description
924:21: E128 continuation line under-indented for visual indent
925:21: E128 continuation line under-indented for visual indent
958:1: E302 expected 2 blank lines, found 1
958: D205 Blank line missing between one-line summary and description
968:21: E127 continuation line over-indented for visual indent
969:21: E128 continuation line under-indented for visual indent
975:44: E261 at least two spaces before inline comment
975:45: E262 inline comment should start with '# '
979:1: E302 expected 2 blank lines, found 1
979: D205 Blank line missing between one-line summary and description
990:21: E127 continuation line over-indented for visual indent
991:21: E128 continuation line under-indented for visual indent
1006:21: E128 continuation line under-indented for visual indent
1007:21: E128 continuation line under-indented for visual indent
1014:1: E302 expected 2 blank lines, found 1
1014: D290 White spaces around docstring should be trimmed.
1021:1: E302 expected 2 blank lines, found 1
1021:64: E251 unexpected spaces around keyword / parameter equals
1021:66: E251 unexpected spaces around keyword / parameter equals
1021: D202 No blank lines allowed *after* function docstring, found 1
1021: D400 First line should end with '.', not 'I'
1021: D205 Blank line missing between one-line summary and description
1071:35: E122 continuation line missing indentation or outdented
1085:13: E128 continuation line under-indented for visual indent
1086:13: E128 continuation line under-indented for visual indent
1086:62: E502 the backslash is redundant between brackets
1087:13: E128 continuation line under-indented for visual indent
1088:13: E128 continuation line under-indented for visual indent
1088:62: E502 the backslash is redundant between brackets
1089:13: E128 continuation line under-indented for visual indent
1090:13: E128 continuation line under-indented for visual indent
1092:30: E261 at least two spaces before inline comment
1093:62: E502 the backslash is redundant between brackets
1108:17: E128 continuation line under-indented for visual indent
1113:13: E128 continuation line under-indented for visual indent
1114:62: E502 the backslash is redundant between brackets
1116:62: E502 the backslash is redundant between brackets
1139:37: E128 continuation line under-indented for visual indent
1147:13: E128 continuation line under-indented for visual indent
1148:46: E502 the backslash is redundant between brackets
1150:46: E502 the backslash is redundant between brackets
1154:35: E261 at least two spaces before inline comment
1155:66: E502 the backslash is redundant between brackets
1169:17: E128 continuation line under-indented for visual indent
1184:74: E502 the backslash is redundant between brackets
1185:81: E502 the backslash is redundant between brackets
1192:93: E502 the backslash is redundant between brackets
1193:84: E502 the backslash is redundant between brackets
1194:79: E502 the backslash is redundant between brackets
1200:35: E127 continuation line over-indented for visual indent
1204:17: E128 continuation line under-indented for visual indent
1210:70: E502 the backslash is redundant between brackets
1211:65: E502 the backslash is redundant between brackets
1212:71: E502 the backslash is redundant between brackets
1219:73: E502 the backslash is redundant between brackets
1220:72: E502 the backslash is redundant between brackets
1226:1: E302 expected 2 blank lines, found 1
1226: D400 First line should end with '.', not 'r'
1226: D205 Blank line missing between one-line summary and description
1244:23: E126 continuation line over-indented for hanging indent
1259:1: E302 expected 2 blank lines, found 1
1259: D400 First line should end with '.', not 'e'
1275:9: E128 continuation line under-indented for visual indent
1290:1: E302 expected 2 blank lines, found 1
1290: D400 First line should end with '.', not 't'
1293:19: E222 multiple spaces after operator
1302:15: E221 multiple spaces before operator
1307:1: E302 expected 2 blank lines, found 1
1307: D400 First line should end with '.', not 'x'
1346:1: E302 expected 2 blank lines, found 1
1346: D400 First line should end with '.', not 'x'
1347:9: E128 continuation line under-indented for visual indent
1350:32: E225 missing whitespace around operator
1362:1: E302 expected 2 blank lines, found 1
1375: D400 First line should end with '.', not 't'
1375: D205 Blank line missing between one-line summary and description
1401: D400 First line should end with '.', not 'y'
1401: D205 Blank line missing between one-line summary and description
1412:36: E261 at least two spaces before inline comment
1412:37: E262 inline comment should start with '# '
1419:21: E128 continuation line under-indented for visual indent
1433:17: E128 continuation line under-indented for visual indent
1440:17: E128 continuation line under-indented for visual indent
1442: D400 First line should end with '.', not 'f'
1442: D205 Blank line missing between one-line summary and description
1514:1: E302 expected 2 blank lines, found 1
1516:26: E711 comparison to None should be 'if cond is not None:'
1522:53: E251 unexpected spaces around keyword / parameter equals
1522:55: E251 unexpected spaces around keyword / parameter equals
1522:70: E251 unexpected spaces around keyword / parameter equals
1522:72: E251 unexpected spaces around keyword / parameter equals
1522: D400 First line should end with '.', not 's'
1522: D200 One-line docstring should not occupy 3 lines
1523:32: E251 unexpected spaces around keyword / parameter equals
1523:34: E251 unexpected spaces around keyword / parameter equals
1549:26: E711 comparison to None should be 'if cond is None:'
1550:32: E711 comparison to None should be 'if cond is None:'
1560:32: E711 comparison to None should be 'if cond is not None:'
1564:41: E203 whitespace before ','
1564:51: E251 unexpected spaces around keyword / parameter equals
1564:53: E251 unexpected spaces around keyword / parameter equals
1565:35: E251 unexpected spaces around keyword / parameter equals
1565:37: E251 unexpected spaces around keyword / parameter equals
1565:58: E251 unexpected spaces around keyword / parameter equals
1565:60: E251 unexpected spaces around keyword / parameter equals
1567:17: E714 test for object identity should be 'is not'
1570:56: E251 unexpected spaces around keyword / parameter equals
1570:58: E251 unexpected spaces around keyword / parameter equals
1571:58: E251 unexpected spaces around keyword / parameter equals
1571:60: E251 unexpected spaces around keyword / parameter equals
1572:57: E251 unexpected spaces around keyword / parameter equals
1572:59: E251 unexpected spaces around keyword / parameter equals
1575:1: E302 expected 2 blank lines, found 1
1575:68: E251 unexpected spaces around keyword / parameter equals
1575:70: E251 unexpected spaces around keyword / parameter equals
1575:83: E251 unexpected spaces around keyword / parameter equals
1575:85: E251 unexpected spaces around keyword / parameter equals
1575: D400 First line should end with '.', not 's'
1575: D200 One-line docstring should not occupy 3 lines
1584:36: E261 at least two spaces before inline comment
1584:37: E262 inline comment should start with '# '
1605:17: E303 too many blank lines (2)
1605:31: E711 comparison to None should be 'if cond is None:'
1606:37: E711 comparison to None should be 'if cond is None:'
1614:104: E502 the backslash is redundant between brackets
1615:53: E127 continuation line over-indented for visual indent
1619:37: E711 comparison to None should be 'if cond is not None:'
1630:31: E711 comparison to None should be 'if cond is None:'
1631:37: E711 comparison to None should be 'if cond is None:'
1642:37: E711 comparison to None should be 'if cond is not None:'
1647:17: E303 too many blank lines (3)
1664:58: E251 unexpected spaces around keyword / parameter equals
1664:60: E251 unexpected spaces around keyword / parameter equals
1665:60: E251 unexpected spaces around keyword / parameter equals
1665:62: E251 unexpected spaces around keyword / parameter equals
1666:60: E251 unexpected spaces around keyword / parameter equals
1666:62: E251 unexpected spaces around keyword / parameter equals
1667:61: E251 unexpected spaces around keyword / parameter equals
1667:63: E251 unexpected spaces around keyword / parameter equals
1668:61: E251 unexpected spaces around keyword / parameter equals
1668:63: E251 unexpected spaces around keyword / parameter equals
1669:61: E251 unexpected spaces around keyword / parameter equals
1669:63: E251 unexpected spaces around keyword / parameter equals
1670:61: E251 unexpected spaces around keyword / parameter equals
1670:63: E251 unexpected spaces around keyword / parameter equals
1678:34: E128 continuation line under-indented for visual indent
1679:34: E128 continuation line under-indented for visual indent
1680:34: E128 continuation line under-indented for visual indent
1690:28: E711 comparison to None should be 'if cond is None:'
1691:60: E251 unexpected spaces around keyword / parameter equals
1691:62: E251 unexpected spaces around keyword / parameter equals
1692:53: E127 continuation line over-indented for visual indent
1692:64: E251 unexpected spaces around keyword / parameter equals
1692:66: E251 unexpected spaces around keyword / parameter equals
1693:53: E127 continuation line over-indented for visual indent
1693:64: E251 unexpected spaces around keyword / parameter equals
1693:66: E251 unexpected spaces around keyword / parameter equals
1694:53: E127 continuation line over-indented for visual indent
1694:63: E251 unexpected spaces around keyword / parameter equals
1694:65: E251 unexpected spaces around keyword / parameter equals
1695:53: E127 continuation line over-indented for visual indent
1695:64: E251 unexpected spaces around keyword / parameter equals
1695:66: E251 unexpected spaces around keyword / parameter equals
1696:53: E127 continuation line over-indented for visual indent
1696:64: E251 unexpected spaces around keyword / parameter equals
1696:66: E251 unexpected spaces around keyword / parameter equals
1697:53: E127 continuation line over-indented for visual indent
1697:61: E251 unexpected spaces around keyword / parameter equals
1697:63: E251 unexpected spaces around keyword / parameter equals
1705:72: E251 unexpected spaces around keyword / parameter equals
1705:74: E251 unexpected spaces around keyword / parameter equals
1713:1: E302 expected 2 blank lines, found 1
1713: D202 No blank lines allowed *after* function docstring, found 1
1713: D400 First line should end with '.', not 's'
1713: D205 Blank line missing between one-line summary and description
1714:31: E251 unexpected spaces around keyword / parameter equals
1714:33: E251 unexpected spaces around keyword / parameter equals
1714:46: E251 unexpected spaces around keyword / parameter equals
1714:48: E251 unexpected spaces around keyword / parameter equals
1730: D401 First line should be imperative: 'Add', not 'Adds'
1734:24: E261 at least two spaces before inline comment
1747: D401 First line should be imperative: 'Add', not 'Adds'
1782:12: E713 test for membership should be 'not in'
1799:31: E261 at least two spaces before inline comment
1799:32: E262 inline comment should start with '# '
1800:31: E251 unexpected spaces around keyword / parameter equals
1800:33: E251 unexpected spaces around keyword / parameter equals
1802:34: E261 at least two spaces before inline comment
1802:35: E262 inline comment should start with '# '
1803:31: E251 unexpected spaces around keyword / parameter equals
1803:33: E251 unexpected spaces around keyword / parameter equals
1803:50: E251 unexpected spaces around keyword / parameter equals
1803:52: E251 unexpected spaces around keyword / parameter equals
1805:12: E714 test for object identity should be 'is not'
1806:52: E251 unexpected spaces around keyword / parameter equals
1806:54: E251 unexpected spaces around keyword / parameter equals
1806:76: E251 unexpected spaces around keyword / parameter equals
1806:78: E251 unexpected spaces around keyword / parameter equals
1808:12: E714 test for object identity should be 'is not'
1809:52: E251 unexpected spaces around keyword / parameter equals
1809:54: E251 unexpected spaces around keyword / parameter equals
1810:50: E251 unexpected spaces around keyword / parameter equals
1810:52: E251 unexpected spaces around keyword / parameter equals
1810:67: E251 unexpected spaces around keyword / parameter equals
1810:69: E251 unexpected spaces around keyword / parameter equals
1811:12: E714 test for object identity should be 'is not'
1812:52: E251 unexpected spaces around keyword / parameter equals
1812:54: E251 unexpected spaces around keyword / parameter equals
1813:50: E251 unexpected spaces around keyword / parameter equals
1813:52: E251 unexpected spaces around keyword / parameter equals
1813:67: E251 unexpected spaces around keyword / parameter equals
1813:69: E251 unexpected spaces around keyword / parameter equals
1814:54: E251 unexpected spaces around keyword / parameter equals
1814:56: E251 unexpected spaces around keyword / parameter equals
1815:12: E714 test for object identity should be 'is not'
1816:52: E251 unexpected spaces around keyword / parameter equals
1816:54: E251 unexpected spaces around keyword / parameter equals
1817:50: E251 unexpected spaces around keyword / parameter equals
1817:52: E251 unexpected spaces around keyword / parameter equals
1817:69: E251 unexpected spaces around keyword / parameter equals
1817:71: E251 unexpected spaces around keyword / parameter equals
1825:5: E303 too many blank lines (2)
1825:19: E261 at least two spaces before inline comment
1827:18: E261 at least two spaces before inline comment
1840:28: E261 at least two spaces before inline comment
1840:29: E262 inline comment should start with '# '
1853:13: E303 too many blank lines (2)
1868:13: E303 too many blank lines (2)
1871:60: E261 at least two spaces before inline comment
1871:61: E262 inline comment should start with '# '
1880:40: W602 deprecated form of raising exception
1888:13: E303 too many blank lines (2)
1892:26: E222 multiple spaces after operator
1900:21: E113 unexpected indentation
1901:21: E113 unexpected indentation
1902:21: E113 unexpected indentation
1916:40: W602 deprecated form of raising exception
1945:44: W602 deprecated form of raising exception
1972:13: E303 too many blank lines (2)
1978:13: E303 too many blank lines (2)
1993:40: W602 deprecated form of raising exception
1995:29: E261 at least two spaces before inline comment
1996:131: E202 whitespace before ')'
1998:40: W602 deprecated form of raising exception
2000:40: W602 deprecated form of raising exception
2002:40: W602 deprecated form of raising exception
2004:40: W602 deprecated form of raising exception
2007:44: W602 deprecated form of raising exception
2031:9: E303 too many blank lines (2)
2031:108: E202 whitespace before ')'
2083:30: E261 at least two spaces before inline comment
2091:46: E261 at least two spaces before inline comment
2106:46: E261 at least two spaces before inline comment
2286:32: E711 comparison to None should be 'if cond is None:'
2298: D290 White spaces around docstring should be trimmed.
2298: D400 First line should end with '.', not 'e'
2308:71: E203 whitespace before ','
2310:1: E302 expected 2 blank lines, found 1
2310: D400 First line should end with '.', not 't'
2325:31: E222 multiple spaces after operator
2330:19: E221 multiple spaces before operator
2335:83: E203 whitespace before ','
2348:83: E203 whitespace before ','
2351:1: E302 expected 2 blank lines, found 1
2351: D200 One-line docstring should not occupy 3 lines
2360: D400 First line should end with '.', not 'e'
2360: D205 Blank line missing between one-line summary and description
2368:21: E127 continuation line over-indented for visual indent
2374:32: E261 at least two spaces before inline comment
2374:33: E262 inline comment should start with '# '
2378:21: E261 at least two spaces before inline comment
2378:22: E262 inline comment should start with '# '
2387:17: E128 continuation line under-indented for visual indent
2390:1: E302 expected 2 blank lines, found 1
2390: D202 No blank lines allowed *after* function docstring, found 1
2390: D400 First line should end with '.', not 'r'
2485:1: E302 expected 2 blank lines, found 1
2485: D202 No blank lines allowed *after* function docstring, found 1
2485: D400 First line should end with '.', not 'd'
2498:25: E128 continuation line under-indented for visual indent
2517:21: E128 continuation line under-indented for visual indent
2526:1: E302 expected 2 blank lines, found 1
2526: D400 First line should end with '.', not 'e'
2526: D205 Blank line missing between one-line summary and description
2542:1: E302 expected 2 blank lines, found 1
2542: D401 First line should be imperative: 'Return', not 'Returns'
2542: D400 First line should end with '.', not 'e'
2542: D205 Blank line missing between one-line summary and description
2566:1: E302 expected 2 blank lines, found 1
2566: D400 First line should end with '.', not 'n'
2566: D205 Blank line missing between one-line summary and description
2578:94: E261 at least two spaces before inline comment
2578:95: E262 inline comment should start with '# '
2591:101: E261 at least two spaces before inline comment
2591:102: E262 inline comment should start with '# '
2623:1: E302 expected 2 blank lines, found 1
2623: D202 No blank lines allowed *after* function docstring, found 1
2623: D400 First line should end with '.', not 's'
2632:47: E228 missing whitespace around modulo operator
2658:41: E228 missing whitespace around modulo operator
2660:1: E302 expected 2 blank lines, found 1
2663:13: E128 continuation line under-indented for visual indent
2664:13: E128 continuation line under-indented for visual indent
2669:13: E128 continuation line under-indented for visual indent
2688:13: E128 continuation line under-indented for visual indent
2689:13: E128 continuation line under-indented for visual indent
2690:18: E128 continuation line under-indented for visual indent
2691:20: E121 continuation line under-indented for hanging indent
2706:13: E128 continuation line under-indented for visual indent
2707:13: E128 continuation line under-indented for visual indent
2708:13: E128 continuation line under-indented for visual indent
2710:1: E302 expected 2 blank lines, found 1
2710:70: E261 at least two spaces before inline comment
2710: D290 White spaces around docstring should be trimmed.
2710: D301 Use r""" if any backslashes in a docstring
2710: D202 No blank lines allowed *after* function docstring, found 1
2710: D400 First line should end with '.', not 'e'
2710: D205 Blank line missing between one-line summary and description
2802: D290 White spaces around docstring should be trimmed.
2802: D400 First line should end with '.', not 's'
2802: D205 Blank line missing between one-line summary and description
2830:1: E302 expected 2 blank lines, found 1
2830: D209 Put multi-line docstring closing quotes on separate line
2830: D400 First line should end with '.', not 'e'
2830: D205 Blank line missing between one-line summary and description
2850:1: E302 expected 2 blank lines, found 1
2850: D103 Docstring missing
2884:1: E302 expected 2 blank lines, found 1
2884: D400 First line should end with '.', not 's'
2884: D205 Blank line missing between one-line summary and description
2914:25: E251 unexpected spaces around keyword / parameter equals
2914:27: E251 unexpected spaces around keyword / parameter equals
2915:33: E251 unexpected spaces around keyword / parameter equals
2915:35: E251 unexpected spaces around keyword / parameter equals
2916:27: E251 unexpected spaces around keyword / parameter equals
2916:29: E251 unexpected spaces around keyword / parameter equals
2917:24: E251 unexpected spaces around keyword / parameter equals
2917:26: E251 unexpected spaces around keyword / parameter equals
2918:24: E251 unexpected spaces around keyword / parameter equals
2918:26: E251 unexpected spaces around keyword / parameter equals
2919:25: E251 unexpected spaces around keyword / parameter equals
2919:27: E251 unexpected spaces around keyword / parameter equals
2948:57: E502 the backslash is redundant between brackets
2949:38: E127 continuation line over-indented for visual indent
2949:69: E502 the backslash is redundant between brackets
2950:43: E127 continuation line over-indented for visual indent
2959:86: E251 unexpected spaces around keyword / parameter equals
2959:88: E251 unexpected spaces around keyword / parameter equals
2961:40: E251 unexpected spaces around keyword / parameter equals
2961:42: E251 unexpected spaces around keyword / parameter equals
2962:38: E251 unexpected spaces around keyword / parameter equals
2962:40: E251 unexpected spaces around keyword / parameter equals
2963:41: E251 unexpected spaces around keyword / parameter equals
2963:43: E251 unexpected spaces around keyword / parameter equals
2964:41: E251 unexpected spaces around keyword / parameter equals
2964:43: E251 unexpected spaces around keyword / parameter equals
2965:42: E251 unexpected spaces around keyword / parameter equals
2965:44: E251 unexpected spaces around keyword / parameter equals
2968:5: E303 too many blank lines (2)
2970:1: E302 expected 2 blank lines, found 1
2970: D290 White spaces around docstring should be trimmed.
2973:13: E128 continuation line under-indented for visual indent
2996:25: E128 continuation line under-indented for visual indent
3011:1: E302 expected 2 blank lines, found 1
3011: D103 Docstring missing
3012:40: E711 comparison to None should be 'if cond is not None:'


Clang supports all GNU features and uses `__GNUC__`. I will add a slow-path version.

This depends on `slot` being a `guint`, not on the size of `guint`. That is, if changing the type of `slot`, you would need to change this to `clzl` or `clzll`.


I wouldn't return if there is no config file. let's use the "{}" ... and merge the possible args to it in the line below.


This variable needs to be initialized. I will make this change when I merge.


the only problem is I have no idea what VPS is


I'd probably change the assignment a little so that learners are *forced* to use a template: say that it's going to be called twice, once as `/?name=Hapi` and once as `/?name=Handling`, and the output should be
```
<html>
    <head><title>Hello Hapi</title></head>
    <body>
        Hello Hapi
    </body>
</html>
```
for the first call, but
```
<html>
    <head><title>Hello Handling</title></head>
    <body>
        Hello Handling
    </body>
</html>
```
for the second call, and then in the hints point out how to inject data into the template with a `{{value}}`. That way it's impossible to craft plain HTML, and the learner can see "which parts are dynamic" so that they can intuit where the templating variable goes.


Can I simply spin until the pointer is non-null or should I sleep?


Yes, it should.


As per jshint, prefer dot notation over bracket notation when possible. Will change when I merge.


4660-GLHE_Vertical_Input_Fixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-31.07%25-red.svg)


Oh lol that was really easy. Seems like I somehow oversaw the libpng12 version in the AUR. I will update my AUR package soon so it will use your solution!


db_config should really be "repositories"


It is always called with the world stopped (in weak-link processing and in bridge processing). I will comment that assumption.


LGTM


It's Python 3 not 2


Can I help prepare some test data that's loosely-packed like you’re describing?


I would allow 2 top level keys:
config_file (like now)
config_data, which can contain: "repositories", "scope" and "log_stats" (which will be merged into the read contents of the config_file, if any)


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/6470/testReport/) for this commit**


detailling tpyo


What is this?


Looks good too, I have another patch coming up which turns the if's into AS_IF.


I can see why this may be desired, but is this what we want? This increases the chance of collision with names. We should also document this somewhere.


Have you tried this?


4660-GLHE_Vertical_Input_Fixes (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.81%25-red.svg)


Looks good to me!


A lot of modifications to Model, so I'll do the comment only here.
The big obstacle for everything here was `state$`, it was also causing the CPU-consuming infinite loop on combineLatest. I replaced state$ with a separate stream for each entity: `total$` and `selected$`. We can do that because the whole Model is actually your state$ (conceptually, in any Cycle app). It really is. You can even make `var state$ = Rx.Observable.combineLatest(Model.total$, Model.selected$, function (total, selected) { return {total: total, selected: selected}; });` It is just more clear to separate them inside Model, instead of always returning `state$` that you will need to anyways unbundle later. Doing that separation also simplified the implementation of total calculation and selected computation from intent. Also notice that inside Model is `things$`. We do this to separate information (Model) from display (View). In View you had `[0,1,2,3,4].map(...` and that is actually information "we have 5 things being and they have some content". Doing this also removed two other leaks: no need to toss `out$` around, since all that information is inside this view, and no need to represent `ticker$` outside this Model. It makes sense too, because `ticker$` is pure information, there is no display (View) of it, and no interaction (Intent) with it.

Simply separating responsibilities by doing these changes untangled the problem and it worked without having to think hard how to solve the problem.


lgtm


4660-GLHE_Vertical_Input_Fixes (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.12%25-red.svg)


LGTM, although setNotifed looks like dead code to me?


I'm not sure about this change. With this change bundler will be searching for *.css across entire site, right?


why did you need to comment this out? it doesn't seem related to the changes


Perhaps you're right (only saw the lines added in this PR). Still, would be nice if *new* additions were right to begin with. Perhaps I'm a OCD :smile_cat:


Detta avslut ska inte vara nödvändigt egentligen. Enligt [PSR-2](http://www.php-fig.org/psr/psr-2/) och punkt 2.2 vore en blank rad att föredra istället:

> All PHP files MUST end with a single blank line.
>
> The closing ?> tag MUST be omitted from files containing only PHP.


same here... why?


Better to add a configure check, we should do the same for IP_PKTINFO btw


Why do we need a build-time dependency on grub? The ebuilds just dump a bunch of files in /usr/share/grub/themes. Even a run-time dependency is questionable.


If we document this somewhere, I'm mostly OK with this. I don't like that we have to compromise to get this to work. We do have the C++11 Regex library that we can use, but only real modern compilers (VS 2013 and GCC 4.9 and modern LLVM) support it. This regex library is part of the standard.


this file should be moved to inside a new directory : spec/plugins


fixes #150


I'm getting 'Uncaught ReferenceError: CookieJar is not defined'. It appears CookieJar is a dependency, but it is not listed in dist/lib.


It isn't used as far as I can tell. Check the GetPath function; the
parameter isn't used anywhere which seemed weird to me too...
On Jan 13, 2015 9:43 PM, "Feodor Fitsner" <notifications@github.com> wrote:

> I'm not sure about this change. With this change bundler will be searching
> for *.css across entire site, right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/XhmikosR/website/commit/68d3556018b57ca0c50040920a167f07697da0da#commitcomment-9266273>
> .
>


Bra jobbat, gillar att du även utforskade `get_browser()`.


use String for file arg


I would rather have the generated files all end up in one location, and then have the Makefiles copy or do whatever it is they need to do to compile properly.


Does the "scope/s" attribute ever get used in the identityMap as documented above?
Do we really need that as a global option? I don't think we do...


Since we're just iterating over a list of objectids now the compaction of IDs doesn't matter and we don't really need to test it.

The more I think about it the more I think that the ESRI endpoints simply have a maximum return size and we would have hit it regardless of the kind of query if we had returned all 500 rows. Or maybe that particular dataset had some bug that was causing unspecified errors in the ESRI server.


This option doesn't seem to be merged in ...


OK, I see. My fault. It should be like before, but with function contents changed to:

    return HttpContext.Current.Server.MapPath(virtualPath);

Could you please fix that so I can merge PR?


This option (log_stats) doesn't seem to be merged in either...


So, now you're not using *any* bootstrap layout elements whatsoever? No grid classes, nothing?

Hmm...why use bootstrap then at all?


Did you verify that the try/except code (with SlashSeparatedCourseKey) is not necessary? I wasn't sure.


Error


Spinning should be fine.


@remicollet :+1:


Nit: Don't think you need the hasattr check since pre_requisistes_courses is a field on all courses.


Done.


This was to fix the problem where there were identical CSS ID selectors on the page? Apologies for not addressing that - our system attempts to fill in all found selectors so it wasn't an issue for me.


refactor duplicates


agree, but i didn't find a way reliable way of testing this on Python 2.6


Yeah, that's great! I did not know that even the Paypal string is problematic in german law... As Paypal definitly will provide a clear statement that you will buy this I you click, etc. (At least that is what I remember from my most recent transfers via Paypal. Will look out again next time. :-) )

Anyway, THANKS for the workaround. Will you release a new version on Wordpress.com? I like auto-updates :-D


So, the problem is that *besides* HP and LP, the first and last band are also using Resonance.


Bad idea.


r+


If the user is anonymous, and the course has pre-requisite courses, should this method return False? Or does something else prevent an anonymous user from accessing the course?


use Scanner for input


This makes it impossible to install the 4.0.x branch via cordova-cli's `cordova platform add android@4.0.x`
:(

```
Downloading cordova library for android...
Download complete
Creating android project...
Error: ENOENT, no such file or directory '/Users/dpogue/.cordova/lib/android/cordova/4.0.x/VERSION'
    at Object.fs.openSync (fs.js:427:18)
    at Object.fs.readFileSync (fs.js:284:15)
    at call_into_create (workspace/node_modules/cordova-lib/src/cordova/platform.js:451:30)
    at workspace/node_modules/cordova-lib/src/cordova/platform.js:124:24
    at _fulfilled (workspace/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (workspace/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (workspace/node_modules/q/q.js:749:13)
    at workspace/node_modules/q/q.js:557:44
    at flush (workspace/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:415:13)
```


But this fixes the problem
http://sunflower.sahanafoundation.org/eden/project/task/348


Every heard of DRY?  I guess I have not :)!!  Thanks, practice makes perfect.


I've definitely seen other random failures from ESRI sources, hopeful that hurts.

+1 on test data. Mocking up HTTP responses is a PITA but test suites pay off the work.


такой способ работает только в случае однобайтовых кодировок, для двухбайтовых например может один байт попасть в массив-буфер, один нет, тогда последний символ в строке будет не валиден
нужно преобразовывать байтовый буффер в символьный методом asCharBuffer() и работать с символами


And damage? Is this implementation mechanics-compliant?


Informationen från ditt formulär hämtar du från superglobalen [`$_POST`](http://php.net/manual/en/reserved.variables.post.php), exempelvis:

```php
//Contact subject
$subject = $_POST["subject"];
```

Annars ser du ut att hittat rätt med [`mail()`](http://php.net/manual/en/function.mail.php), kalas!


@seyhunak I think the community wants to keep the version numbers matching with Bootstrap so it is clear what is included in the gem for Bootstrap support. The gem needed a rewrite, mostly due to the way it is handling the static install option and the constant copying of files into the project from bootstrap and fontawesome. I started to fix these problems with [this PR](https://github.com/seyhunak/twitter-bootstrap-rails/pull/802) that sat there for weeks without your response. Most other PR's from then on I was tagging you to get your attention on them as well. I forked the project and kept releases going, and added a bunch of other features. I've been saying for a while that we needed a new release.

Let's make it clear in the readme what you want to do with the project. I can't release the gem, making it very frustrating to keep doing merges and tagging you to have them shipped. All of PR's since #802 are already fixed in railsstrap with test coverage. This project should require updated tests with every PR.

Bootstrap 3.3.0 was released Oct 29th, and 3.3.1 on Nov 12th. If you can review PR's within 2 days of upstream dependencies releasing then keep the project going. Otherwise let me suggest people use railsstrap, as I'm able to release updates within 24 hours.


Yep, right, we get errors when there's more than one


From my research most REST api's downcase and then use dashes for spaces. Since we are using dashes for the group separators, I used underscores. I feel we would need to do something like this instead of having to match casing and spaces.


FileWriter.newLine()


Looks reasonable


Ya I agree that would make more sense.


Why should I? I think the better way is to use casts on your side for your desired type if you use this function^^
Especially when boost updates something in time system (which is highly unlikely I know), we stay smart.


Done


rename to encoder


TeamCity CI Experiment :: Combine project PHP+Go [Build 8](http://localhost:8111/viewLog.html?buildId=37&buildTypeId=CiExperiment_PhpProject) is now running


If I understood properly @Marty-D 's explanation on type change order, it should be.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/524
success: http://build.servo.org/builders/linux2/builds/522
success: http://build.servo.org/builders/android/builds/560
success: http://build.servo.org/builders/mac1/builds/741
success: http://build.servo.org/builders/mac2/builds/741


yup, sounds like merge failure.


We've had this code in production with our customers for several months now yes.

This was the original pull request:
https://github.com/nanomsg/nanomsg/pull/303/files

I think it was closed by mistake while I was doing some cleanup in my own repo, and should still be considered for merge (along with several other pull requests I have anyway). I re-opened it.


TeamCity CI Experiment :: Combine project PHP+Go [Build 8](http://localhost:8111/viewLog.html?buildId=37&buildTypeId=CiExperiment_PhpProject) outcome was **SUCCESS**
Summary: Tests passed: 3 Build time: 00:01:28


TeamCity CI Experiment :: Combine project PHP+Go [Build 9](http://localhost:8111/viewLog.html?buildId=39&buildTypeId=CiExperiment_PhpProject) is now running


OK. I'm not against this decision, but it would be nice to present it to Nate to make sure he's fine with this.


introduce var for br.readline()


Performance bug looks like maybe due to System.Arte.Decode.Histogram again (from heap profile)


I guess a workaround for now is `cordova platform add android@4382234676246107d2b832129723b501b857a1b4 --usegit`, but that's kinda ugly and means any future merges won't be installable :(

@agrieve Is there a way to get the cordova-cli to pick it up if installed locally as an npm package? IIRC it always tries to install the platforms from the npm registry directly.


TeamCity CI Experiment :: Combine project PHP+Go [Build 9](http://localhost:8111/viewLog.html?buildId=39&buildTypeId=CiExperiment_PhpProject) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 2 Build time: 00:00:57
### Failed tests
```
Project Test Suite: AppBundle\Tests\Controller\DefaultControllerTest: testIndex: <no details avaliable>

```


TeamCity CI Experiment :: Combine project PHP+Go [Build 10](http://localhost:8111/viewLog.html?buildId=41&buildTypeId=CiExperiment_PhpProject) is now running


Is this the only thing preventing this from working all the way? If so, I can patch one of the Makefiles to have it copy the file when it needs it.


no, but I'm sure it will.


@J-east Good job on this, looks like you found all the instances. However, once you import settings there is no need for the additional assignment in some of these files, i.e.

```
WEATHER_ROOT = settings.WEATHER_ROOT
```

A better solution is to replace references in the file to ```WEATHER_ROOT``` with ```settings.WEATHER_ROOT```. The benefit is one less (meaningless) assignment and a clearer idea in the code where WEATHER_ROOT came from.


Esto es una mala practica. Nunca crees un objeto miembro de una clase padre. Si te ves obligado a hacerlo revisa tu diseño.


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/1b9847bae9c26ca10dbb3cb369a0b7a560f28bdf


merging basho/riak_cs/bugfix/rewriting-path-inaccurately = 1b9847ba into borshop-integration-1040-bugfix/rewriting-path-inaccurately


basho/riak_cs/bugfix/rewriting-path-inaccurately = 1b9847ba merged ok, testing candidate = cc73f8c3


Mismo comentario que antes