4: I102 copyright year is outdated, expected 2015 but got 2014
150: D102 Docstring missing
154: D102 Docstring missing
158: D102 Docstring missing
204: D102 Docstring missing
218: D102 Docstring missing
222: D102 Docstring missing
237: D102 Docstring missing
245: D102 Docstring missing
254: D102 Docstring missing
259: D102 Docstring missing
344: D200 One-line docstring should not occupy 3 lines
358: D102 Docstring missing
499: D204 Expected 1 blank line *after* class docstring, found 0
513: D102 Docstring missing
517: D102 Docstring missing
551: D204 Expected 1 blank line *after* class docstring, found 0
564: D204 Expected 1 blank line *after* class docstring, found 0
585: D204 Expected 1 blank line *after* class docstring, found 0
595: D204 Expected 1 blank line *after* class docstring, found 0
610: D204 Expected 1 blank line *after* class docstring, found 0
620: D401 First line should be imperative: 'Return', not 'Returns'
620: D202 No blank lines allowed *after* function docstring, found 1
620: D400 First line should end with '.', not 'x'
633: D204 Expected 1 blank line *after* class docstring, found 0
654: D204 Expected 1 blank line *after* class docstring, found 0
664: D102 Docstring missing
672: D204 Expected 1 blank line *after* class docstring, found 0
704: D204 Expected 1 blank line *after* class docstring, found 0
724: D102 Docstring missing
735: D102 Docstring missing
766: D102 Docstring missing
776: D204 Expected 1 blank line *after* class docstring, found 0
788: D204 Expected 1 blank line *after* class docstring, found 0
797: D102 Docstring missing
808: D401 First line should be imperative: 'Return', not 'Returns'
813: D204 Expected 1 blank line *after* class docstring, found 0
828: D102 Docstring missing
836: D401 First line should be imperative: 'Return', not 'Returns'
836: D290 White spaces around docstring should be trimmed.
841: D204 Expected 1 blank line *after* class docstring, found 0
870: D102 Docstring missing
925: D102 Docstring missing


1: M100 needs more reviewers
1: M101 signature is missing


4: I102 copyright year is outdated, expected 2015 but got 2014
135: D102 Docstring missing
164: D101 Docstring missing
165: D102 Docstring missing
194: D103 Docstring missing
233: D203 Expected 1 blank line *before* class docstring, found 0
233: D204 Expected 1 blank line *after* class docstring, found 0
233: D400 First line should end with '.', not 'e'
233: D205 Blank line missing between one-line summary and description
238: D102 Docstring missing
296: D102 Docstring missing
318: D400 First line should end with '.', not 'r'
318: D205 Blank line missing between one-line summary and description


4: I102 copyright year is outdated, expected 2015 but got 2014
148: D102 Docstring missing
152: D102 Docstring missing
156: D102 Docstring missing
202: D102 Docstring missing
216: D102 Docstring missing
220: D102 Docstring missing
235: D102 Docstring missing
243: D102 Docstring missing
252: D102 Docstring missing
257: D102 Docstring missing
342: D200 One-line docstring should not occupy 3 lines
356: D102 Docstring missing
497: D204 Expected 1 blank line *after* class docstring, found 0
511: D102 Docstring missing
515: D102 Docstring missing
549: D204 Expected 1 blank line *after* class docstring, found 0
562: D204 Expected 1 blank line *after* class docstring, found 0
583: D204 Expected 1 blank line *after* class docstring, found 0
593: D204 Expected 1 blank line *after* class docstring, found 0
608: D204 Expected 1 blank line *after* class docstring, found 0
618: D401 First line should be imperative: 'Return', not 'Returns'
618: D202 No blank lines allowed *after* function docstring, found 1
618: D400 First line should end with '.', not 'x'
631: D204 Expected 1 blank line *after* class docstring, found 0
652: D204 Expected 1 blank line *after* class docstring, found 0
662: D102 Docstring missing
670: D204 Expected 1 blank line *after* class docstring, found 0
702: D204 Expected 1 blank line *after* class docstring, found 0
722: D102 Docstring missing
733: D102 Docstring missing
765: D102 Docstring missing
775: D204 Expected 1 blank line *after* class docstring, found 0
787: D204 Expected 1 blank line *after* class docstring, found 0
796: D102 Docstring missing
807: D401 First line should be imperative: 'Return', not 'Returns'
812: D204 Expected 1 blank line *after* class docstring, found 0
827: D102 Docstring missing
835: D401 First line should be imperative: 'Return', not 'Returns'
835: D290 White spaces around docstring should be trimmed.
840: D204 Expected 1 blank line *after* class docstring, found 0
869: D102 Docstring missing
924: D102 Docstring missing


😂 ja schon klar, wollte nur mal sehen ob da wer reagiert ;)
Am 05.01.2015 13:28 schrieb "Clemens Pollak" <notifications@github.com>:

> ja, änder das nächstes mal einfach ;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ClePol/DaAlg-Weihnachtsuebung/commit/95838f460d2b23fb7dedfd0999169eadaf0b3f31#commitcomment-9152620>
> .
>


Thanks @wimvanleuven

Fixed in https://github.com/elasticsearch/elasticsearch/commit/0d9fad79e09aa9c090300e0bb43bd44188c46b5f


1: D100 Docstring missing
21: I102 copyright year is outdated, expected 2015 but got 2014
40:6: E126 continuation line over-indented for hanging indent
50:6: E126 continuation line over-indented for hanging indent
51:1: F401 'get_index_strings_by_control_no' imported but unused
52:6: E126 continuation line over-indented for hanging indent
54:6: E126 continuation line over-indented for hanging indent
57:6: E126 continuation line over-indented for hanging indent
64:1: F401 'get_def_name' imported but unused
66:1: F401 'CFG_JOURNAL_PUBINFO_STANDARD_FORM_REGEXP_CHECK' imported but unused
66:1: F401 'CFG_JOURNAL_PUBINFO_STANDARD_FORM' imported but unused
66:1: F401 'CFG_JOURNAL_TAG' imported but unused
71:1: F401 'get_field_tags' imported but unused
71:1: F401 'get_all_index_names_and_column_values' imported but unused
93:1: F401 'get_record' imported but unused
95:1: F999 redefinition of unused 'TermCollector' from line 70
114:17: E261 at least two spaces before inline comment
115:25: E261 at least two spaces before inline comment
122: D401 First line should be imperative: 'Return', not 'Returns'
131: D400 First line should end with '.', not 'n'
131: D205 Blank line missing between one-line summary and description
131: D208 Docstring is over-indented
146:66: E502 the backslash is redundant between brackets
151: D400 First line should end with '.', not 'd'
151: D205 Blank line missing between one-line summary and description
180: D400 First line should end with '.', not 'e'
180: D205 Blank line missing between one-line summary and description
200: D209 Put multi-line docstring closing quotes on separate line
200: D205 Blank line missing between one-line summary and description
203:53: E502 the backslash is redundant between brackets
226:67: E225 missing whitespace around operator
227:30: E124 closing bracket does not match visual indentation
227:31: E261 at least two spaces before inline comment
236:33: E261 at least two spaces before inline comment
248:33: E261 at least two spaces before inline comment
259:33: E261 at least two spaces before inline comment
271:33: E261 at least two spaces before inline comment
282:33: E261 at least two spaces before inline comment
294:33: E261 at least two spaces before inline comment
304: D401 First line should be imperative: 'Remove', not 'Removes'
304: D300 Expected """-quotes, got '-quotes
309: D401 First line should be imperative: 'Return', not 'Returns'
309: D400 First line should end with '.', not 'd'
321: D401 First line should be imperative: 'Return', not 'Returns'
321: D400 First line should end with '.', not 'e'
321: D205 Blank line missing between one-line summary and description
321: D208 Docstring is over-indented
332:68: E502 the backslash is redundant between brackets
340: D401 First line should be imperative: 'Check', not 'Checks'
340: D205 Blank line missing between one-line summary and description
340: D208 Docstring is over-indented
361: D401 First line should be imperative: 'Return', not 'Returns'
361: D400 First line should end with '.', not 's'
363:10: E225 missing whitespace around operator
378:56: E261 at least two spaces before inline comment
386: D290 White spaces around docstring should be trimmed.
386: D400 First line should end with '.', not 's'
386: D205 Blank line missing between one-line summary and description
397:70: E502 the backslash is redundant between brackets
398:32: E127 continuation line over-indented for visual indent
402: D401 First line should be imperative: 'Return', not 'Returns'
402: D400 First line should end with '.', not 'e'
402: D300 Expected """-quotes, got '-quotes
415: D401 First line should be imperative: 'Create', not 'Creates'
415: D209 Put multi-line docstring closing quotes on separate line
415: D400 First line should end with '.', not 'd'
415: D205 Blank line missing between one-line summary and description
434: D401 First line should be imperative: 'Return', not 'Returns'
434: D400 First line should end with '.', not 't'
456:74: E502 the backslash is redundant between brackets
460:52: E261 at least two spaces before inline comment
461:52: E261 at least two spaces before inline comment
462:54: E261 at least two spaces before inline comment
463:54: E261 at least two spaces before inline comment
466: D205 Blank line missing between one-line summary and description
466: D208 Docstring is over-indented
476:70: E502 the backslash is redundant between brackets
482: D290 White spaces around docstring should be trimmed.
482: D400 First line should end with '.', not 'd'
492: D401 First line should be imperative: 'find_affected_record', not 'find_affected_records'
492: D205 Blank line missing between one-line summary and description
492: D208 Docstring is over-indented
503: D202 No blank lines allowed *after* function docstring, found 1
503: D400 First line should end with '.', not 'd'
503: D205 Blank line missing between one-line summary and description
503: D208 Docstring is over-indented
519:37: E127 continuation line over-indented for visual indent
545:24: E127 continuation line over-indented for visual indent
552:20: E126 continuation line over-indented for hanging indent
578: D401 First line should be imperative: 'Split', not 'Splits'
578: D400 First line should end with '.', not 's'
578: D205 Blank line missing between one-line summary and description
578: D208 Docstring is over-indented
588:15: E711 comparison to None should be 'if cond is None:'
599: D203 Expected 1 blank line *before* class docstring, found 0
599: D205 Blank line missing between one-line summary and description
599: D208 Docstring is over-indented
618: D102 Docstring missing
623:65: E502 the backslash is redundant between brackets
624:49: E128 continuation line under-indented for visual indent
624:57: E502 the backslash is redundant between brackets
625:49: E128 continuation line under-indented for visual indent
625:62: E502 the backslash is redundant between brackets
626:49: E128 continuation line under-indented for visual indent
629:24: E261 at least two spaces before inline comment
632: D401 First line should be imperative: 'Update', not 'Updates'
632: D400 First line should end with '.', not 'B'
632: D205 Blank line missing between one-line summary and description
632: D208 Docstring is over-indented
637:57: E502 the backslash is redundant between brackets
639:64: E502 the backslash is redundant between brackets
641:62: E502 the backslash is redundant between brackets
642:23: E128 continuation line under-indented for visual indent
661:63: E502 the backslash is redundant between brackets
664:73: E502 the backslash is redundant between brackets
669:62: E502 the backslash is redundant between brackets
683:65: E502 the backslash is redundant between brackets
695:75: E502 the backslash is redundant between brackets
701:55: E502 the backslash is redundant between brackets
703:54: E502 the backslash is redundant between brackets
704:23: E128 continuation line under-indented for visual indent
706: D400 First line should end with '.', not 'y'
709:28: E261 at least two spaces before inline comment
713:74: E502 the backslash is redundant between brackets
717:74: E502 the backslash is redundant between brackets
719:134: E261 at least two spaces before inline comment
721:14: E261 at least two spaces before inline comment
722:70: E502 the backslash is redundant between brackets
726:142: E261 at least two spaces before inline comment
732:20: E261 at least two spaces before inline comment
733:104: E261 at least two spaces before inline comment
735: D401 First line should be imperative: 'Keep', not 'Keeps'
735: D400 First line should end with '.', not 'g'
735: D205 Blank line missing between one-line summary and description
735: D208 Docstring is over-indented
755:29: F841 local variable 'e' is assigned to but never used
756:84: E502 the backslash is redundant between brackets
768: D400 First line should end with '.', not 'y'
768: D205 Blank line missing between one-line summary and description
782: D401 First line should be imperative: 'Clean', not 'Cleans'
782: D300 Expected """-quotes, got '-quotes
787: D203 Expected 1 blank line *before* class docstring, found 0
787: D205 Blank line missing between one-line summary and description
787: D208 Docstring is over-indented
803: D401 First line should be imperative: 'Create', not 'Creates'
803: D205 Blank line missing between one-line summary and description
803: D208 Docstring is over-indented
812:43: E127 continuation line over-indented for visual indent
813:43: E127 continuation line over-indented for visual indent
814:43: E127 continuation line over-indented for visual indent
818: D401 First line should be imperative: 'Set', not 'Sets'
818: D400 First line should end with '.', not 'l'
818: D205 Blank line missing between one-line summary and description
818: D208 Docstring is over-indented
826: D205 Blank line missing between one-line summary and description
826: D208 Docstring is over-indented
845:85: E502 the backslash is redundant between brackets
867:28: E126 continuation line over-indented for hanging indent
870:87: E502 the backslash is redundant between brackets
900: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
900: D202 No blank lines allowed *after* method docstring, found 1
900: D400 First line should end with '.', not 'x'
900: D205 Blank line missing between one-line summary and description
900: D208 Docstring is over-indented
920: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
920: D202 No blank lines allowed *after* method docstring, found 1
920: D400 First line should end with '.', not 'x'
920: D205 Blank line missing between one-line summary and description
920: D208 Docstring is over-indented
940: D401 First line should be imperative: 'Update', not 'Updates'
940: D400 First line should end with '.', not ':'
940: D205 Blank line missing between one-line summary and description
940: D208 Docstring is over-indented
970:55: E502 the backslash is redundant between brackets
971:24: E127 continuation line over-indented for visual indent
972:24: E127 continuation line over-indented for visual indent
972:69: E261 at least two spaces before inline comment
974:174: E261 at least two spaces before inline comment
978: D401 First line should be imperative: 'Insert', not 'Inserts'
978: D400 First line should end with '.', not 'e'
978: D205 Blank line missing between one-line summary and description
978: D208 Docstring is over-indented
1006:179: E261 at least two spaces before inline comment
1008:174: E261 at least two spaces before inline comment
1012: D401 First line should be imperative: 'Remove', not 'Removes'
1012: D400 First line should end with '.', not 'd'
1012: D205 Blank line missing between one-line summary and description
1012: D208 Docstring is over-indented
1037:179: E261 at least two spaces before inline comment
1039:174: E261 at least two spaces before inline comment
1043: D401 First line should be imperative: 'Update', not 'Updates'
1043: D400 First line should end with '.', not 'o'
1043: D205 Blank line missing between one-line summary and description
1043: D208 Docstring is over-indented
1082: D401 First line should be imperative: 'Update', not 'Updates'
1082: D205 Blank line missing between one-line summary and description
1082: D208 Docstring is over-indented
1097: D401 First line should be imperative: 'Update', not 'Updates'
1097: D400 First line should end with '.', not 'd'
1097: D205 Blank line missing between one-line summary and description
1097: D208 Docstring is over-indented
1125: D401 First line should be imperative: 'Remove', not 'Removes'
1125: D400 First line should end with '.', not 'e'
1132: D401 First line should be imperative: 'Clean', not 'Cleans'
1132: D400 First line should end with '.', not ')'
1132: D205 Blank line missing between one-line summary and description
1132: D208 Docstring is over-indented
1139:18: E127 continuation line over-indented for visual indent
1143: D401 First line should be imperative: 'Remove', not 'Removes'
1143: D400 First line should end with '.', not ')'
1143: D205 Blank line missing between one-line summary and description
1143: D208 Docstring is over-indented
1160:5: E303 too many blank lines (2)
1160: D401 First line should be imperative: 'Remove', not 'Removes'
1160: D205 Blank line missing between one-line summary and description
1160: D208 Docstring is over-indented
1198: D203 Expected 1 blank line *before* class docstring, found 0
1198: D400 First line should end with '.', not 'x'
1198: D205 Blank line missing between one-line summary and description
1198: D208 Docstring is over-indented
1209: D401 First line should be imperative: 'Create', not 'Creates'
1209: D205 Blank line missing between one-line summary and description
1250: D401 First line should be imperative: 'Fill', not 'Fills'
1250: D400 First line should end with '.', not 'h'
1250: D205 Blank line missing between one-line summary and description
1250: D208 Docstring is over-indented
1273: D401 First line should be imperative: 'Prevent', not 'Prevents'
1273: D208 Docstring is over-indented
1273: D200 One-line docstring should not occupy 3 lines
1279: D401 First line should be imperative: 'Turn', not 'Turns'
1279: D208 Docstring is over-indented
1279: D200 One-line docstring should not occupy 3 lines
1285: D401 First line should be imperative: 'Return', not 'Returns'
1285: D209 Put multi-line docstring closing quotes on separate line
1285: D202 No blank lines allowed *after* method docstring, found 1
1285: D400 First line should end with '.', not 'e'
1285: D205 Blank line missing between one-line summary and description
1285: D208 Docstring is over-indented
1300: D401 First line should be imperative: 'Inform', not 'Informs'
1300: D205 Blank line missing between one-line summary and description
1300: D208 Docstring is over-indented
1320: D401 First line should be imperative: 'Display', not 'Displays'
1320: D300 Expected """-quotes, got '-quotes
1327: D401 First line should be imperative: 'Return', not 'Returns'
1327: D300 Expected """-quotes, got '-quotes
1331: D401 First line should be imperative: 'Print', not 'Prints'
1331: D300 Expected """-quotes, got '-quotes
1335: D202 No blank lines allowed *after* method docstring, found 1
1335: D300 Expected """-quotes, got '-quotes
1348:62: E502 the backslash is redundant between brackets
1349:17: E128 continuation line under-indented for visual indent
1351:75: E502 the backslash is redundant between brackets
1352:31: E127 continuation line over-indented for visual indent
1354: D401 First line should be imperative: 'Fetche', not 'Fetches'
1354: D400 First line should end with '.', not 's'
1354: D205 Blank line missing between one-line summary and description
1367:35: E261 at least two spaces before inline comment
1384:73: E502 the backslash is redundant between brackets
1385:25: E128 continuation line under-indented for visual indent
1395:73: E502 the backslash is redundant between brackets
1396:25: E128 continuation line under-indented for visual indent
1451:31: E701 multiple statements on one line (colon)
1472:27: E701 multiple statements on one line (colon)
1475:184: E261 at least two spaces before inline comment
1478:179: E261 at least two spaces before inline comment
1490: D401 First line should be imperative: 'Divide', not 'Divides'
1490: D209 Put multi-line docstring closing quotes on separate line
1490: D400 First line should end with '.', not ','
1490: D205 Blank line missing between one-line summary and description
1490: D208 Docstring is over-indented
1512: D209 Put multi-line docstring closing quotes on separate line
1512: D205 Blank line missing between one-line summary and description
1523:81: E502 the backslash is redundant between brackets
1524:17: E128 continuation line under-indented for visual indent
1527:63: E502 the backslash is redundant between brackets
1528:21: E128 continuation line under-indented for visual indent
1530: D401 First line should be imperative: 'Keep', not 'Keeps'
1530: D400 First line should end with '.', not 'g'
1530: D205 Blank line missing between one-line summary and description
1530: D208 Docstring is over-indented
1554:5: E303 too many blank lines (2)
1554: D401 First line should be imperative: 'Fetche', not 'Fetches'
1554: D400 First line should end with '.', not 's'
1554: D205 Blank line missing between one-line summary and description
1570: D401 First line should be imperative: 'Delete', not 'Deletes'
1570: D209 Put multi-line docstring closing quotes on separate line
1570: D400 First line should end with '.', not 'w'
1570: D205 Blank line missing between one-line summary and description
1570: D208 Docstring is over-indented
1573:82: E502 the backslash is redundant between brackets
1574:17: E128 continuation line under-indented for visual indent
1584:80: E502 the backslash is redundant between brackets
1585:17: E128 continuation line under-indented for visual indent
1587: D401 First line should be imperative: 'Find', not 'Finds'
1587: D200 One-line docstring should not occupy 3 lines
1596: D400 First line should end with '.', not 'r'
1596: D205 Blank line missing between one-line summary and description
1620: D400 First line should end with '.', not 'e'
1638:35: E261 at least two spaces before inline comment
1669: D400 First line should end with '.', not 'e'
1677:19: E261 at least two spaces before inline comment
1682:17: E127 continuation line over-indented for visual indent
1687: D202 No blank lines allowed *after* method docstring, found 1
1687: D400 First line should end with '.', not 'y'
1687: D205 Blank line missing between one-line summary and description
1711:15: E261 at least two spaces before inline comment
1713:16: E713 test for membership should be 'not in'
1726:49: E713 test for membership should be 'not in'
1746:29: E128 continuation line under-indented for visual indent
1747:33: E128 continuation line under-indented for visual indent
1752:21: E126 continuation line over-indented for hanging indent
1763:13: E128 continuation line under-indented for visual indent
1764:13: E128 continuation line under-indented for visual indent
1787:13: E128 continuation line under-indented for visual indent
1788:13: E128 continuation line under-indented for visual indent
1804:13: E126 continuation line over-indented for hanging indent
1809:1: E302 expected 2 blank lines, found 1
1817:1: E302 expected 2 blank lines, found 1
1817: D290 White spaces around docstring should be trimmed.
1817: D400 First line should end with '.', not 'e'
1817: D205 Blank line missing between one-line summary and description
1851:78: E502 the backslash is redundant between brackets
1852:17: E128 continuation line under-indented for visual indent
1865:1: E302 expected 2 blank lines, found 1
1865: D290 White spaces around docstring should be trimmed.
1872: D401 First line should be imperative: 'Find', not 'Finds'
1872: D290 White spaces around docstring should be trimmed.
1872: D400 First line should end with '.', not ']'
1872: D205 Blank line missing between one-line summary and description
1872: D208 Docstring is over-indented
1891:36: E127 continuation line over-indented for visual indent
1897:41: E127 continuation line over-indented for visual indent
1900:36: E127 continuation line over-indented for visual indent
1906:41: E127 continuation line over-indented for visual indent
1911:36: E127 continuation line over-indented for visual indent
1918:41: E127 continuation line over-indented for visual indent
1945: D401 First line should be imperative: 'Find', not 'Finds'
1945: D290 White spaces around docstring should be trimmed.
1945: D400 First line should end with '.', not ']'
1945: D205 Blank line missing between one-line summary and description
1945: D208 Docstring is over-indented
1985:48: E261 at least two spaces before inline comment
1991: D401 First line should be imperative: 'Find', not 'Finds'
1991: D205 Blank line missing between one-line summary and description
1991: D208 Docstring is over-indented
2007: D401 First line should be imperative: 'Get', not 'Gets'
2007: D400 First line should end with '.', not 'n'
2007: D205 Blank line missing between one-line summary and description
2007: D208 Docstring is over-indented
2042: D401 First line should be imperative: 'Get', not 'Gets'
2042: D400 First line should end with '.', not 'e'
2042: D205 Blank line missing between one-line summary and description
2042: D208 Docstring is over-indented
2060: D401 First line should be imperative: 'Remove', not 'Removes'
2060: D205 Blank line missing between one-line summary and description
2060: D208 Docstring is over-indented
2084: D401 First line should be imperative: 'Decide', not 'Decides'
2084: D205 Blank line missing between one-line summary and description
2084: D208 Docstring is over-indented
2093: D205 Blank line missing between one-line summary and description
2093: D208 Docstring is over-indented
2126: D401 First line should be imperative: 'Run', not 'Runs'
2126: D205 Blank line missing between one-line summary and description
2126: D208 Docstring is over-indented
2182:85: E502 the backslash is redundant between brackets
2183:56: E128 continuation line under-indented for visual indent
2183:86: E502 the backslash is redundant between brackets
2184:56: E128 continuation line under-indented for visual indent
2190:5: E303 too many blank lines (2)
2211:29: E126 continuation line over-indented for hanging indent
2250:29: E126 continuation line over-indented for hanging indent
2262:25: E126 continuation line over-indented for hanging indent
2289:29: E126 continuation line over-indented for hanging indent
2303:25: E126 continuation line over-indented for hanging indent
2328:5: E303 too many blank lines (2)


4: I102 copyright year is outdated, expected 2015 but got 2014
35: D102 Docstring missing


4: I102 copyright year is outdated, expected 2015 but got 2014


1: D100 Docstring missing
4: I102 copyright year is outdated, expected 2015 but got 2014
34:1: F999 redefinition of unused 'intbitset' from line 31
41:35: E126 continuation line over-indented for hanging indent
46:22: E126 continuation line over-indented for hanging indent
53:20: E126 continuation line over-indented for hanging indent
56: D103 Docstring missing
64: D103 Docstring missing
72: D103 Docstring missing
102: D400 First line should end with '.', not 'g'
102: D205 Blank line missing between one-line summary and description
149:55: E127 continuation line over-indented for visual indent
159: D103 Docstring missing
204: D400 First line should end with '.', not 'e'
210: D103 Docstring missing
227: D400 First line should end with '.', not 'd'
227: D200 One-line docstring should not occupy 2 lines
241: D400 First line should end with '.', not 's'
241: D200 One-line docstring should not occupy 2 lines
258: D400 First line should end with '.', not 'g'
273: D202 No blank lines allowed *after* function docstring, found 1
273: D400 First line should end with '.', not 't'
282: D400 First line should end with '.', not 'e'
387: D400 First line should end with '.', not 'd'
455: D400 First line should end with '.', not 'm'
464:46: E227 missing whitespace around bitwise or shift operator
466:48: E227 missing whitespace around bitwise or shift operator
471: D401 First line should be imperative: 'Scan', not 'Scans'
471: D400 First line should end with '.', not 'd'
471: D205 Blank line missing between one-line summary and description
471: D208 Docstring is over-indented
537:30: E128 continuation line under-indented for visual indent
539:25: E127 continuation line over-indented for visual indent
556:31: E127 continuation line over-indented for visual indent
560:40: E127 continuation line over-indented for visual indent
579:9: E303 too many blank lines (2)
581:34: E128 continuation line under-indented for visual indent
583:36: E127 continuation line over-indented for visual indent
587:39: E128 continuation line under-indented for visual indent
589:36: E127 continuation line over-indented for visual indent
601:29: E128 continuation line under-indented for visual indent
605:29: E128 continuation line under-indented for visual indent
608:25: E127 continuation line over-indented for visual indent
624:39: E127 continuation line over-indented for visual indent
627:39: E127 continuation line over-indented for visual indent
637:39: E127 continuation line over-indented for visual indent
645:34: E127 continuation line over-indented for visual indent
666:19: E128 continuation line under-indented for visual indent
667:19: E128 continuation line under-indented for visual indent
668:19: E128 continuation line under-indented for visual indent
672: D400 First line should end with '.', not 't'
672: D205 Blank line missing between one-line summary and description
672: D208 Docstring is over-indented
726:41: E127 continuation line over-indented for visual indent
737:36: E127 continuation line over-indented for visual indent
766:47: E127 continuation line over-indented for visual indent
785:34: E127 continuation line over-indented for visual indent
824:34: E127 continuation line over-indented for visual indent
863:34: E127 continuation line over-indented for visual indent
897:34: E127 continuation line over-indented for visual indent
923:34: E127 continuation line over-indented for visual indent
951:44: E127 continuation line over-indented for visual indent
958:49: E127 continuation line over-indented for visual indent
980:50: E127 continuation line over-indented for visual indent
991:21: E128 continuation line under-indented for visual indent
1012:29: E127 continuation line over-indented for visual indent
1033:29: E127 continuation line over-indented for visual indent
1054:29: E127 continuation line over-indented for visual indent
1071:29: E127 continuation line over-indented for visual indent
1110: D400 First line should end with '.', not 'e'
1110: D205 Blank line missing between one-line summary and description
1124: D401 First line should be imperative: 'Thi', not 'This'
1124: D200 One-line docstring should not occupy 3 lines
1136: D400 First line should end with '.', not 'w'
1136: D205 Blank line missing between one-line summary and description
1149: D400 First line should end with '.', not 'e'
1156: D400 First line should end with '.', not 'd'
1156: D205 Blank line missing between one-line summary and description
1186: D400 First line should end with '.', not 'd'
1186: D205 Blank line missing between one-line summary and description
1218: D208 Docstring is over-indented
1235:27: E127 continuation line over-indented for visual indent
1241: D209 Put multi-line docstring closing quotes on separate line
1241: D400 First line should end with '.', not 'e'
1241: D208 Docstring is over-indented
1249: D400 First line should end with '.', not 'l'
1249: D205 Blank line missing between one-line summary and description
1272: D400 First line should end with '.', not ']'
1282: D400 First line should end with '.', not 'e'


1: D400 First line should end with '.', not 'e'
4: I102 copyright year is outdated, expected 2015 but got 2012
26:1: E122 continuation line missing indentation or outdented
30:1: E122 continuation line missing indentation or outdented
33:1: E122 continuation line missing indentation or outdented
42:44: E251 unexpected spaces around keyword / parameter equals
42:46: E251 unexpected spaces around keyword / parameter equals
42: D401 First line should be imperative: 'Return', not 'Returns'
42: D209 Put multi-line docstring closing quotes on separate line
42: D205 Blank line missing between one-line summary and description
53:75: E502 the backslash is redundant between brackets
54:65: E502 the backslash is redundant between brackets
55:28: E225 missing whitespace around operator
66:78: E502 the backslash is redundant between brackets
67:83: E502 the backslash is redundant between brackets
68:32: E225 missing whitespace around operator
81:44: E261 at least two spaces before inline comment
81:44: E262 inline comment should start with '# '
81: D401 First line should be imperative: 'Return', not 'Returns'
81: D400 First line should end with '.', not 'm'
87:30: E261 at least two spaces before inline comment
96: D401 First line should be imperative: 'Return', not 'Returns'
96: D209 Put multi-line docstring closing quotes on separate line
96: D400 First line should end with '.', not 'n'
96: D205 Blank line missing between one-line summary and description
105: D401 First line should be imperative: 'Find', not 'Finds'
105: D400 First line should end with '.', not 'g'
105: D300 Expected """-quotes, got '''-quotes
114:66: E502 the backslash is redundant between brackets
115:46: E225 missing whitespace around operator
133:8: E111 indentation is not a multiple of four
147: D209 Put multi-line docstring closing quotes on separate line
147: D400 First line should end with '.', not 'y'
147: D205 Blank line missing between one-line summary and description
147: D300 Expected """-quotes, got '''-quotes
158:68: E502 the backslash is redundant between brackets
159:24: E225 missing whitespace around operator
170: D401 First line should be imperative: 'Return', not 'Returns'
170: D400 First line should end with '.', not 'd'
170: D300 Expected """-quotes, got '''-quotes
178:91: E502 the backslash is redundant between brackets
179:28: E225 missing whitespace around operator
182:72: E502 the backslash is redundant between brackets
183:60: E502 the backslash is redundant between brackets
184:24: E225 missing whitespace around operator
188: D209 Put multi-line docstring closing quotes on separate line
188: D400 First line should end with '.', not 'y'
188: D205 Blank line missing between one-line summary and description
188: D300 Expected """-quotes, got '''-quotes
193:73: E225 missing whitespace around operator
194:96: E502 the backslash is redundant between brackets
194:56: E231 missing whitespace after ','
194:76: E231 missing whitespace after ','
195:56: E231 missing whitespace after ','
200: D401 First line should be imperative: 'Return', not 'Returns'
200: D205 Blank line missing between one-line summary and description
210:63: E502 the backslash is redundant between brackets
211:28: E225 missing whitespace around operator
213:76: E502 the backslash is redundant between brackets
213:70: E225 missing whitespace around operator
220:58: E502 the backslash is redundant between brackets
221:28: E225 missing whitespace around operator
223:65: E225 missing whitespace around operator
234:80: E502 the backslash is redundant between brackets
235:24: E225 missing whitespace around operator
239: D400 First line should end with '.', not 'n'
239: D300 Expected """-quotes, got '''-quotes
245:34: E261 at least two spaces before inline comment
245:34: E262 inline comment should start with '# '
248:50: E225 missing whitespace around operator
254:60: E502 the backslash is redundant between brackets
255:24: E225 missing whitespace around operator
257:1: E302 expected 2 blank lines, found 1
257: D401 First line should be imperative: 'Identifie', not 'Identifies'
257: D400 First line should end with '.', not 't'
264:1: E302 expected 2 blank lines, found 1
264: D401 First line should be imperative: 'Doe', not 'Does'
264: D209 Put multi-line docstring closing quotes on separate line
264: D400 First line should end with '.', not 'e'
264: D205 Blank line missing between one-line summary and description
272:80: E502 the backslash is redundant between brackets
273:24: E225 missing whitespace around operator
279:17: E127 continuation line over-indented for visual indent
280:76: E502 the backslash is redundant between brackets
288:81: E502 the backslash is redundant between brackets
293:86: E502 the backslash is redundant between brackets
300: D400 First line should end with '.', not 'A'
312:17: E261 at least two spaces before inline comment
313:65: E502 the backslash is redundant between brackets
314:60: E225 missing whitespace around operator
321:43: E502 the backslash is redundant between brackets
322:13: E128 continuation line under-indented for visual indent
322:77: E502 the backslash is redundant between brackets
325:80: E502 the backslash is redundant between brackets
326:50: E225 missing whitespace around operator
328:75: E502 the backslash is redundant between brackets
333: D400 First line should end with '.', not 'S'
335:64: E502 the backslash is redundant between brackets
336:50: E502 the backslash is redundant between brackets
337:20: E225 missing whitespace around operator
338:60: E225 missing whitespace around operator
343:119: E502 the backslash is redundant between brackets
346:17: E261 at least two spaces before inline comment
350:62: E502 the backslash is redundant between brackets
355:43: E502 the backslash is redundant between brackets
356:13: E128 continuation line under-indented for visual indent
358:81: E502 the backslash is redundant between brackets
359:58: E225 missing whitespace around operator
361:57: E502 the backslash is redundant between brackets
362:50: E225 missing whitespace around operator
366: D209 Put multi-line docstring closing quotes on separate line
366: D205 Blank line missing between one-line summary and description
370:66: E502 the backslash is redundant between brackets
371:20: E225 missing whitespace around operator
379:42: E225 missing whitespace around operator
383:38: E225 missing whitespace around operator
388: D209 Put multi-line docstring closing quotes on separate line
388: D400 First line should end with '.', not 's'
388: D205 Blank line missing between one-line summary and description
393:54: E502 the backslash is redundant between brackets
429: D401 First line should be imperative: 'Return', not 'Returns'
429: D209 Put multi-line docstring closing quotes on separate line
429: D202 No blank lines allowed *after* function docstring, found 1
429: D400 First line should end with '.', not 'r'
429: D205 Blank line missing between one-line summary and description
435:24: E261 at least two spaces before inline comment
435:25: E262 inline comment should start with '# '
444:73: E502 the backslash is redundant between brackets
445:51: E225 missing whitespace around operator
454:63: E502 the backslash is redundant between brackets
455:49: E225 missing whitespace around operator
460: D401 First line should be imperative: 'Return', not 'Returns'
460: D400 First line should end with '.', not 's'
462:53: E502 the backslash is redundant between brackets
466: D401 First line should be imperative: 'Return', not 'Returns'
466: D209 Put multi-line docstring closing quotes on separate line
466: D400 First line should end with '.', not ':'
466: D205 Blank line missing between one-line summary and description
475:13: F841 local variable 'dummy' is assigned to but never used
480:27: E261 at least two spaces before inline comment
480:28: E262 inline comment should start with '# '
485: D401 First line should be imperative: 'Return', not 'Returns'
485: D209 Put multi-line docstring closing quotes on separate line
485: D400 First line should end with '.', not ','
485: D205 Blank line missing between one-line summary and description
497:75: E502 the backslash is redundant between brackets
498:23: E128 continuation line under-indented for visual indent
498:24: E225 missing whitespace around operator
512:72: E502 the backslash is redundant between brackets
513:69: E225 missing whitespace around operator
515:83: E502 the backslash is redundant between brackets
516:23: E128 continuation line under-indented for visual indent
516:24: E225 missing whitespace around operator
523: D401 First line should be imperative: 'Thi', not 'This'
523: D209 Put multi-line docstring closing quotes on separate line
523: D400 First line should end with '.', not 'd'
523: D205 Blank line missing between one-line summary and description
534:1: E302 expected 2 blank lines, found 1
534: D401 First line should be imperative: 'Thi', not 'This'
534: D209 Put multi-line docstring closing quotes on separate line
534: D400 First line should end with '.', not 'd'
534: D205 Blank line missing between one-line summary and description
549:20: E261 at least two spaces before inline comment
553:1: E302 expected 2 blank lines, found 1
553: D401 First line should be imperative: 'Thi', not 'This'
553: D209 Put multi-line docstring closing quotes on separate line
553: D400 First line should end with '.', not 'e'
553: D205 Blank line missing between one-line summary and description
563:1: E302 expected 2 blank lines, found 1
563:59: E251 unexpected spaces around keyword / parameter equals
563:61: E251 unexpected spaces around keyword / parameter equals
563: D401 First line should be imperative: 'Update', not 'Updates'
563: D209 Put multi-line docstring closing quotes on separate line
563: D202 No blank lines allowed *after* function docstring, found 1
563: D400 First line should end with '.', not 'd'
563: D205 Blank line missing between one-line summary and description
574:69: E502 the backslash is redundant between brackets
575:46: E225 missing whitespace around operator
584:75: E502 the backslash is redundant between brackets
585:24: E225 missing whitespace around operator
586:21: E261 at least two spaces before inline comment
586:22: E262 inline comment should start with '# '
590:83: E502 the backslash is redundant between brackets
591:24: E225 missing whitespace around operator
605:14: E261 at least two spaces before inline comment
619:60: E502 the backslash is redundant between brackets
620:28: E225 missing whitespace around operator
623:69: E502 the backslash is redundant between brackets
624:33: E128 continuation line under-indented for visual indent
626:60: E502 the backslash is redundant between brackets
627:28: E225 missing whitespace around operator
629:69: E502 the backslash is redundant between brackets
630:33: E128 continuation line under-indented for visual indent
632:59: E502 the backslash is redundant between brackets
633:28: E225 missing whitespace around operator
643:68: E502 the backslash is redundant between brackets
644:42: E128 continuation line under-indented for visual indent
652:85: E502 the backslash is redundant between brackets
653:28: E225 missing whitespace around operator
658:117: E251 unexpected spaces around keyword / parameter equals
658:119: E251 unexpected spaces around keyword / parameter equals
658: D401 First line should be imperative: 'Update', not 'Updates'
658: D400 First line should end with '.', not 's'
662:62: E225 missing whitespace around operator
667:64: E502 the backslash is redundant between brackets
668:24: E225 missing whitespace around operator
689:17: E125 continuation line with same indent as next logical line
705:72: E502 the backslash is redundant between brackets
717:66: E502 the backslash is redundant between brackets
718:21: E128 continuation line under-indented for visual indent
722:66: E502 the backslash is redundant between brackets
723:21: E128 continuation line under-indented for visual indent
724:64: E225 missing whitespace around operator
727: D401 First line should be imperative: 'Modifie', not 'Modifies'
727: D209 Put multi-line docstring closing quotes on separate line
727: D400 First line should end with '.', not 'n'
727: D205 Blank line missing between one-line summary and description
736: D401 First line should be imperative: 'Insert', not 'Inserts'
736: D400 First line should end with '.', not 's'
745:50: E261 at least two spaces before inline comment
745:50: E262 inline comment should start with '# '
751:34: E261 at least two spaces before inline comment
751:35: E262 inline comment should start with '# '
758:23: E261 at least two spaces before inline comment
758:24: E262 inline comment should start with '# '
765:38: E225 missing whitespace around operator
769: D400 First line should end with '.', not 's'
777:38: E225 missing whitespace around operator
781: D209 Put multi-line docstring closing quotes on separate line
781: D400 First line should end with '.', not 'w'
781: D205 Blank line missing between one-line summary and description
791: D400 First line should end with '.', not ')'
808: D401 First line should be imperative: 'Update', not 'Updates'
808: D209 Put multi-line docstring closing quotes on separate line
808: D202 No blank lines allowed *after* function docstring, found 1
808: D400 First line should end with '.', not 't'
808: D205 Blank line missing between one-line summary and description
818:66: E502 the backslash is redundant between brackets
819:59: E502 the backslash is redundant between brackets
820:20: E225 missing whitespace around operator
846:27: E261 at least two spaces before inline comment
853:61: E225 missing whitespace around operator
854:71: E225 missing whitespace around operator
857:82: E502 the backslash is redundant between brackets
858:28: E225 missing whitespace around operator
863:32: E261 at least two spaces before inline comment
867:28: E261 at least two spaces before inline comment
867:29: E262 inline comment should start with '# '
870:82: E502 the backslash is redundant between brackets
871:27: E128 continuation line under-indented for visual indent
873:84: E502 the backslash is redundant between brackets
874:19: E128 continuation line under-indented for visual indent
874:20: E225 missing whitespace around operator
879:56: E225 missing whitespace around operator
880:58: E225 missing whitespace around operator
883:87: E502 the backslash is redundant between brackets
884:27: E128 continuation line under-indented for visual indent
884:28: E225 missing whitespace around operator
889:38: E251 unexpected spaces around keyword / parameter equals
889:40: E251 unexpected spaces around keyword / parameter equals
889: D401 First line should be imperative: 'Rebalance', not 'Rebalances'
889: D400 First line should end with '.', not 't'
901:58: E225 missing whitespace around operator
903:23: E261 at least two spaces before inline comment
905:62: E502 the backslash is redundant between brackets
906:24: E225 missing whitespace around operator
912:56: E225 missing whitespace around operator
913:70: E502 the backslash is redundant between brackets
914:27: E127 continuation line over-indented for visual indent
914:28: E225 missing whitespace around operator
916:33: E128 continuation line under-indented for visual indent
917:33: E128 continuation line under-indented for visual indent
918:33: E128 continuation line under-indented for visual indent
920:72: E502 the backslash is redundant between brackets
921:28: E225 missing whitespace around operator
929: D401 First line should be imperative: 'test', not 'tests'
929: D400 First line should end with '.', not 's'


Because we got less than the requested batchSize which means the publisher has finished - added #3 for tailable cursor support.


I take it back... was using an old brew cask... Nothing to see here.


よい


`do..end` should be used for multi line block.


Testowy komentarz do commita


I can't reproduce the life gain problem. Any idea what was different in your game?
![samanicrevelation](https://cloud.githubusercontent.com/assets/2066790/5613114/71f95aee-94df-11e4-8834-51ef951c3a91.jpg)


1. Could do will review and spike it.  Might stop a lot of duplication issues because even with operations some methods still have a lot of logic.

2. Have polled it and there seems to be two approaches:
  a) Promise (ratpack.io)
  b) Automatically call `request(1)` on subscribe (RxJava)


Not $outputFileName but $outputFilename


When calculating the max and min for the data sets in each test you can use fc.utilities.extent which is a valid test of the extent function.

also when adding and removing a day to pad the data left and right, you can test the padEnds property in the fc.scale.dateTime component test.


Right!


Hey mum i'm on code!


Bootlooped art segfault


Thanks @senny! Will do.


It's not clear for me why do you want a special treatment for external static files (comparative with static files). An external static file is like a static file, the difference lies only in location (outside of java web container - somewhere on the file system).
Just try to understand the value of this feature.


Oh crap. I tought that we can finaly compile ROM with 4.9 :(


    I vaguely remember that Charles had some issues right at the start
    when overlapping the probes. Are the probes a single base?  Are they
    stored in teh db in 0-based coordinates?

    On 18/12/2014 17:32, Javier Herrero
      wrote:

      Hmm, I guess it depends on how the information is coded in the
        DB. We had to change this for eFORGE to pull out the probes by
        position.
      —
        Reply to this email directly or view
          it on GitHub.


C'est nul


Parent pom `droolsjbpm-integration` does list the `kie-identity-session-provider` as one its modules, so it is not being build (and deployed to JBoss Nexus). This seems just like an overlook, or is there a reason for that?


拼错了～～


very bad idea now all images are broken with coding utf8 :(


It would be good to put this into master as well.


I think it is linked to Bug 1103331


sdfsdfsdf


I think we can do the same simplification here and return ``None`` if ``self._notification_mapping`` is empty?


arter97 is looking into it. He was actually successful but didn't commit into github. Later he commited another and it was different and the result is bootloop. He almost wanna hit the wall for that! :)


@tiansh Fixed in 3cb215caa4c669b7d68eebbe9f7806fcd33e6e55


 Implementing the event to remove all the registered event handlers might give us hard to find bugs in the future. People will not expect their event handlers to vanish after they are invoked once.

Is there any reason we cannot/should not make this a normal event and properly register/unregister event handlers as appropriate?


本当は「非負だ」という条件も内生的に出てくるはずだから事前にはいらないはずなんだけどね．

まずは解が必ずあるはずの SL < SH < BL < BH となるパラメタ値でやってごらん．


Thanks ornicar, please do!


Today, I am finally understand your solution. KEY is at here. `try_to_solve` is `DFS`. I try to simplify it.


Why not use Environment.StackTrace instead of 'new System.Diagnostics.StackTrace ()'


It seems the easier part to fix XXE part of the report would be to set parser features controling handling of external entities:

~~~
parser.setFeature(xml.sax.handler.feature_external_ges,0)
parser.setFeature(xml.sax.handler.feature_external_pes,0)
~~~


Yes, it seems to be working for me.


Ah, great, I will wait for it.
BTW. I even with this patch or not I'm getting SM 4.9 error: http://pastebin.com/7f9DwaD1


Please check the specific version of IE that is needed and if IE11 works as expected. Also put this information as part of the comment


What's the benefit in pulling this if check to the top? Are you just trying to bypass the  'string path = GetFolderPath (dataObject);' call? If so, why not just move that inside the body of the original if?


These defaults leave client vulnerable to billion laughs attacks - see issue #17.


you really should be using the `G_DEFINE_TYPE` macro, here.


is this just for performance reasons or something else? and how is this possible?


most of this function, except the call to `g_object_new()` could go into the instance initialization function.


the


Thanks, fixed.


Мне кажется над этим стоит подумать. Сложная строка больно. Можно разбить на две как минимум.


this should be `G_TYPE_CHECK_CLASS_CAST()`; the `GTK_*` macros are old and formally deprecated by GObject.


Cheers =)


`states` ты почему-то не заполняешь в цикле ниже.


Сообщения по умолчанию имеет смысл вытащить в переменную как регулярку.


same as above, this should be `G_TYPE_CHECK_CLASS_TYPE()`.


please reword the comment to make it easier to understand


You shouldn't use this in a release; you should use `command -v`.


`pi` сложно оценить хорошо, поэтому я бы его не проверял в тестах.


Well if developers - when developing an open source projects - take the time (let's say 10 seconds) to type two extra sentences explaining the justification for removing functionality that already exists, and is, by the way, used in various online tutorials, then perhaps people would not need to comment.  Make sense, doesn't it?


the call to `set_size_request()` is not necessary.


Hm?
In how far broken?
I got the new satellites.xml on my boxes and I can't see any problem.


it feels weird to remove the unknown option when reading a value...


А не хочешь сюда и в остальные модификаторы, где используется регулярки притащить validation_pattern?


great job.


Incorrect javadoc


Does it still make sense to set `EmptyEntityResolver` here?  Given the `defusedxml` use and the `forbid_external` defaulting to `True`, it seems redundant.  Having it set unconditionally actually makes it impossible to enable resolution of external entities, even when both `ignore_ext` and `forbid_external` are set to `False`.


Good ideas, I'll add them in, thanks :-)


This actually breaks Heroku deployment:

```
-----> Fetching custom git buildpack... done
-----> PHP (composer.json) app detected
-----> Bundling NGINX 1.6.2
-----> Bundling PHP 5.6.4
-----> Bundling extensions
       apcu
       phpredis
       mongo
cp: cannot stat ‘/tmp/buildpack_b77366cda8d9f360e220d10c82307a87/bin/../conf/nginx/base.conf.erb’: No such file or directory

 !     Push rejected, failed to compile PHP (composer.json) app
```


The problem is that at the moment when a definition is reloaded, only StdMeshInstances with the same mesh than the reloaded definition are updated. This does not work anymore, because when the Clonk is updated, also other mesh instances whose skeletons include the Clonk skeleton need to be (partly) updated.


You need to separate logical blocks like:
```php
        $migrateString = "";

        $stub = $this->files->get(__DIR__ . '/stubs/' . $stub);

        foreach ($this->getColumns($this->table) as $column) {
            $migrateString .= "    " . $this->replaceTypes($column);
        }

        $stub = str_replace("{{columns}}", $migrateString, $stub);

        return str_replace("{{table}}", $this->table, $stub);
```


Fixes #10


Здесь нужно еще складывать сооющения об ошибках в `this.errors` например


Will do - this was basically copied over from the previous code but I admit I didn't check if it was needed...


utf coding have broke sat tuner please revert this


Я вот думаю, что в отрыве от поля required не имеет смысла, правильнее будет empty, наверное.


Их, имхо, в i18n надо вытащить. Пока нет нормального i18n ;-(


I'll put the file back now.


Reference #15


Thanks @itchyny


Fuck..I've totally forgot this..but seems it's a dfs..


where are `$parse` and `$compile` used?


The problem is not the utf encoding, because the file isn't utf-8 encoded.
The problem is that it is SAYING it was utf-8 when it isn't.


Does this really apply to both NPCs or just Ayanthe?


А чего не `validate`? Полное предложение же огонь)


toen ik eenmaal 0 justify klaar had was de rest zo weinig werk dat ik het er maar meteen in deed. 0x ervoor zetten is niet veel werk.


Done. Can you try deploying again please @willdurand


Я думал об этом. Может быть лучше сделать некий `collect`?

Как асинхронно проверять? Я думал по наличию второго параметра-функции определять, т.к. первый (значение) обязателен.


sollte mit in den "phs" namespace


ex = memoStateEx, there are methods for that.


Again, this was copied over.

I believe that when we remove the `<select>`, the child `<option>` elements can will call `SelectController.removeOption` when they are destroyed; if they were selected at the time then the `SelectController` calls `SelectController.renderUnknownOption`, which is pointless as the select is being removed anyway.

I guess this means it is an optimization.


Thanks a lot!


gotcha!


Надо да. С переменной потом договорится проще будет:) И строка заодно симпатичнее станет.


I would call it `server_middleware` to keep the consistency with `Shoryuken.server_middleware` and as now Shoryuken supports `perform_in` and `perform_at`, I will probably implement `client_middleware` in the near future.


`validation_empty`? Дык это же некорректно ;)


Assume only 1 exit point from function.
*Except the "check" return like:*
```php
 if(!isset($param)){
    return false; // return error , throw Exception
 }
```
So you need to generate command in some variable and then return it. **Such code easier to understand and debug**


I will reword...


I now got it:
The file was replaced afterwards and not yet rolled out.

The problem of the new file was not that it was utf-8 encoded (because it wasn't), but that i CLAIMED to be utf-8 encoded while being iso-8859-1 encoded.
So actually just the XML header info was replaced.

@Huevos:
Can you show me the script you are using in order to generate this file?


Я даже numbers передумал тащить в _money ;-)

В JS же есть RegExp, `pattern` нужен только для проброса регулярки строкой из bemjson.


Starting with 4.3.5, this is no longer true.


/cc @izuzak @jlord It's snooowing here! **:snowflake: + :octocat: = The OctoSnowCat** :smile:

https://twitter.com/IonicaBizau/status/552085318648987650


playSound(killer, QuestSound.ITEMSOUND_QUEST_ITEMGET)
These QuestState methods are planned to be removed.


Выношу message везде. `!val` есть смысл разделять?


`validate_presence` еще вариант) Пусть required будет пока)


There is actually a test that checks that this is done.

If you think about it, the unknown option is only there if the `viewValue` does not match a valid option. If you are reading from the select element then we must have clicked on a valid option, which means that the unknown option should go away.


Maybe just a util type class?


why optional?


The code is working with eurostat. I still have to update Insee and
Worldbank.

I have now also fixed the doctests

eurostat.py line 192: attributes belong to an observation not a
series. If there is no attribute the variables is empty, if there is
sometimes an attribute, the list with the same size as values is filled
with empty string except when there is an attribute for a given
observation.

Michaël Malter writes:

> Have you tried it? I would be happy to fix it. I think you wanted to get rid of what I did for optional values (my approach was admittedly a kludge).
>
> The tests are not passing now, I don't know how to use this.
>
> You can try the doctests by simply running:
> python3 _skeleton.py
> I provided other tests. You can of course provide your own. Could you please send me a minimal example of instantiation that works?
>
> ---
>
> More specifically, how is the index important in eurostat.py l. 192? I am not sure I fully understand that part.
> Are you building an empty list the size of the time series with each attributes relating to a point in the list of values?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Widukind/dlstats/commit/8136c4816693e036d94c511e18001733435fbdda#commitcomment-9151250

--
Michel Juillard


The idea is fine. For better resource usage your test (which i see is started now) should be done with 11 threads, so the 23 core machines can play 2 games in parallel. With 12 threads the remaining 11 cores does nothing.


I think i'm a bit late but the same goes for psywave, dragon rage and super fang (just make their base power = 1 I guess)


You are right, they are only needed for `ngOptions`


Maybe as `@entries` is empty the `.dup` could be faster or even removing it from the `initialize`

```ruby
class Chain
  attr_writer :entries

  def dup
    new_chain = new
    new_chain.entries = entries.dup
    new_chain
  end
end
```


Зачем, тут будет простая логика. Если ошибка, то складывать в стек. Мы же будем запускать этот метод на событие какое-нить. Каждый раз все функции валидации.


I think that the code can be simplified
* do not use `compile`
* make use of the fact that `$interpolate` will stop watching constants and do not have two different code paths


Because `<option>` can appear below a `<datalist>` element too.


Well, I find that it rubs my OCD up the wrong way if there are some dsl methods prefixed with ```shoryuken``` (```shoryuken_options```) and some not (```server_middleware```). For consistency, shouldn't it be the same for both? And since you wouldn't define client middleware in the worker like this, the ```server``` in ```server_middleware``` would be redundant too.

What do you think?


Thanks for catching this, @Quintus.  This is something I definitely need to keep a better eye out for.

I noticed that the red pipes and yellow pipes do not have author/license information for the ver.settings and up.settings files.  I'd assume files like right.settings and left.settings don't need this information because they do not have the exact same name as a png file in the directory.

If I know what the goal is for the settings files, I could try to reconcile this alongside the spacing issue I introduced in the level loader C++ file.


It would be good to replace this if then else construct with an array lookup or something similar.


Both !


sure!


What's the equivalent ?


when is this possible?


Пока нет, я думаю.


Another option:

```ruby
def server_middleware
  if block_given?
    @server_middleware ||= begin
      Shoryuken.server_middleware.dup.tap do |chain|
        yield chain
      end
    end
  else
    @server_middleware || Shoryuken.server_middleware
  end
end
```

Doing that, it will only `dup` when the worker tries to define specific middleware.


In object types it is not currently possible. I decided not to address that in this patch (stop the bleeding before anything else..). I imagine we want some syntax for that (`Trait::Name=Foo`?).


Use bsdtar. I've packaged it for centos6 here: https://repo.thehyve.nl/service/local/repositories/releases/content/org/libarchive/bsdtar/3.1.2/bsdtar-3.1.2-rpm.rpm


Looks good, thanks!


Actually the answer may fall out of generalizing object types (`Box<Car+Vehicle<Color=....>+Box<Color=...>`).


THis seems to point to a `webclient_export_xls` module, which doesn't really make sense.


Yes, it is..I thought I had a test for that, but I guess not. Gotta run now, I'll add it later.


I agree, comments deleted. Thank you @csoliss @ajspadial


Hi @chneukirchen, any idea why `dup` is called here? Thanks :smile:


This is a little bit convoluted and could be improved, by using the fact that this is true when `match[2]` is not null. I didn't want to start changing it in this PR as there are some corner case that it deals with - which may or may not be ignored... Basically `as` is treated as a reserved word, if it appears anywhere in the `ngOptions` expression then it is assumed that we want to use the `select value as label` syntax.


@HackFisher , would you pls checkin the v8 lib?otherwise it is unable to build the v8 branch


var getTrackByValue = trackBy ? [...] : hashKey;


Cool.
For the first issue I think I'd be seeing a strangely-colored movie
during test, so I think that must be fine (not sure why - I agree it
seems like an issue).

For the second, I'm traveling right now but I'll try and test on my
linux box when I get home.

For the subImage2D thing I have no idea, but it sounds plausible.

best wishes
Jon

On 04/01/2015 20:32, Sol Simpson wrote:
>
> Seems like a good direction, even if it ends up just for some
> significant code simplification.
>
> Two things to check:
>
> 1) The color format of the numpy images returned by opencv is suppose
> to be BGR, but the glTexImage2D is saying it is RGB. So this may need
> to be updated.
> 2) the reason for the numpy.copy that is now removed was because on
> Linux a tester of the code reported that without this line the image
> was not being drawn. On Windows it was OK without it though. Need to
> retest to see if this /oddity/ still exits, or if the new code fixes
> it somehow.
>
> Also, another speed up maybe achieved by using glTexImage2D for the
> first frame draw, but then use the glTexSubImage2D call in all other
> frame draws. At least on Windows I think this is faster because the
> video card reuses the video memory allocated by the glTexImage2D call,
> instead of freeing and recreating it every time a frame is transferred.
>
> Thanks for helping on this Jon.
>
> Sol
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/peircej/psychopy/commit/8af4931fe58d1618af652d9648bd0a89f60c7f3a#commitcomment-9148282>.
>


File should be a template. Values of domain, name, and urlCellPM should be taken from the params.


It´s finally done! This looks like the solution i´ve been waiting for! It´s the same way i fixed the bug for myself.


Typo in dependencies


Though I'm not sure if it is a good idea to already start widening with >10 threads.
Since Joona already approved, I'll let it run ...


Well, we'd end up pinning commands on the EventHandler which should only be called once. Same with IdeApp.Initialized event. It's a one shot or wait.


with https://github.com/petebacondarwin/angular.js/commit/0d9a246b385be2874eaf95e0983bd950b12e53cc#commitcomment-9153127 this can be simplified


I am not sure what you mean here...


Removed mention of "first" (40c3bec)


Comment on the commit


I think that you didn't issue the DMCA notification "in good faith" AND I really think that he did that in personal purposes,on three statements:
1)This commit is committed 3 years ago.The whole project is updated(the last)2 years ago(2013-2015).I can't agree on you that you are issuing this on good faith.
2)Are you sure that you are posting the "correct" copyrights?You should use this one:
http://creativecommons.org/licenses/by-nc-nd/4.0/
(Read about licensing at:http://choosealicense.com/licenses/)
3)Last thing to mention:If you can raise a case on Bukkit on it's license(GPL),the previous two can also raise a case on you if they want!
-> means forked in the follows:
Wolvereness/Bukkit-Bleeding->Bukkit/Bukkit-Bleeding->Bukkit/Bukkit
So,I posted it on good faith,that you issued the DMCA notice on personal purposes,that we don't know and ever not know.


删除掉之后,jinjia就可以正常渲染模板了


@jbrooksuk ok, it works now. Thank you <3


This section was rephrased as part of an other fix (40c3bec)


Oh! I see


Ну, изначально чтобы не конфликтовать с твоим дом блоком ;-)


is this possible?


hm

The `client_middleware` when implemented should follow the `server_middleware` behaviour, so it could be global or specific.  The middleware for client are different than the ones for server.

I understand the prefix `shoryuken_` concern, but I don't see a problem to have `server_middleware` and `client_` as the class includes `include Shoryuken::Worker`, it's not a PORO anymore.


Ok ;(


Yes if there is no matching option but the value is not `null` and we didn't provide an empty option.


Т.е. ты предлагает всегда все ошибки проверять, а не до первой невалидной?

А run что должен возвращать?


why is this no longer working?


It seems that IE9 doesn't break without this so we are probably fine to remove it. Travis will then check for us.


Shouldn't this check the length of $1 to see if it's a short (12 char) id rather than checking non-zero?


nice!
could you add a two layer deep directory in the test?

Basically if I add a directory `/static` and I try to get ressource `/static/css/main.css` that should work.

Also, I would prefer to have a proper example in the readme instead of `path_to_static_resources_directory`


Better than its current home.

I don't think we need it on the public API.


Can change.


Incomplete :) Add the "screenrecord" string here as item as well. When it does read the array if is not there is a mismatch and will never be added.

This controls which are added or not https://github.com/SimpleAOSP-Lollipop/platform_frameworks_base/blob/L/core/res/res/values/config.xml#L1731

Cheers


`hasOption` is not part of the public API (even when it does not start with `$$`), but some people might depend on this. Please put this as part of the breaking changes


Actually, when you install NodeJS on step 1, the right npm version is installed with it automatically, so this step wouldn't be necessary.


It's clearer this way, imo. But I can also move it. I did it this way for consistency.


This has moved into the ngOptions section. It was in the wrong place.


`hasOption` is still there in `SelectController` so there is no breaking change.

These tests are removed because the only test `hasOption` in the case of `ngOptions` but the refactored `ngOptions` does not use `hasOption` any more.

I guess the safest approach is to refactor these tests no to use `ngOptions`...


ok


should we add a check here to make sure options are indeed options?
e.g this will break on `socketplane agent logs abc12345efde`


First line of my comment...


always quote paths, especially if they're the argument to rm -rf...


God, sorry, I was sure I used that one lol


das $link wird in einem include verwendet, daher musst nicht mysql escape nutzen sondern was eigenes bauen dafür. am besten ein preg_replace, dass alle zeichen außer a-Z löscht. `$link = preg_replace('/[^a-zA-Z]*/', '', $link);`


:D


NB, commented out code is bad. Just delete it. That's what git is for.


Added reference (074b7cf)


Yeah, that makes it so much better...


@vincentchabannes almost of the tests from the testsuite are running  in feature/faster. We don't check the `Pdh<0>` in the testsuite ?
I mainly changed the data structures and it improved `FunctionSpace` dof table generation essentially.
I had to change in a minor way things in `doftablempi.hpp`


1: M101 signature is missing
1: M191 must not end with a dot '.'


We could add a comment to step 1 specifying the version of npm that is installed though, just so people know what version they should have in case it needs updating (which was the case of our test servers, right?). It doesn't need to be greater than 2.1.12 though, I use version 2.0.0 and it works fine, so just specifying greater than that would be enough.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1777](http://teamcity.monogame.net/viewLog.html?buildId=4171&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I should have used another var name I guess, didn't even knew :|


1: M101 signature is missing


I'd simplify this to `-[\w]*d[\w]*\s` just because I'm not a fan of verbose regexps unless really necessary....
This shouldn't block this being merged though


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3018
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3012
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3013
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3004
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3004
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3007
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3000
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2995
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2671
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2669
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1508
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1499


fast-forwarding master to auto = 8e83af6e


TeamCity Yandex QATools :: Html Elements :: pull-request-build [Build 52 [???]](http://teamcity.qatools.ru/viewLog.html?buildId=1919&buildTypeId=htmlelements_pull_request_build) is now running


@dhacker29 I'm not sure where those blobs were from, but libqmimotoext.so is not in any of the self-extractors. I'm building a test build with these fresh blobs from a stock 5.0.1 image to see if verizon roaming issues persist.


TeamCity Yandex QATools :: Html Elements :: pull-request-build [Build 52 [1.14-SNAPSHOT]](http://teamcity.qatools.ru/viewLog.html?buildId=1919&buildTypeId=htmlelements_pull_request_build) outcome was **SUCCESS**
Summary: Tests passed: 103 Build time: 0:0:0


Move it to GalleryDao


Doesn't matter, l2off uses memoStateEx for these things.


The line spacing is fixed with commit id 0f4c362ca34578a5ca46e7cf79a137c7b8a9a508


Why would file extraction require apache...


This is supposed to be the command for installing gulp, but it'll error if people cut and paste it like this, since npm doesn't understand ">= [v3.8.10]". Npm will automatically install the latest version of gulp though, which is the one we're using.

This is similar to the problem with specifying the version for npm earlier in this commit. For the first setup these versions will be correct automatically if people follow the steps we've already provided. I understand that you want to specify the global dependency versions somewhere to avoid problems with updating them, like the ones we had with the test server. Maybe what we should add here is a global dependencies section, separate from Setup, that just lists what we depend on and what version they should be. It's useful information, but maybe it doesn't belong inside Setup.


Use a vhost instead.


This belongs in GalleryDao


Fix #7


Same here, can you move the version number to line 63? The npm command will already install the latest version of yeti.


Looks like this should be `\d+` instead of `\d`. Otherwise version 11.4 would become version 1.4.


Here we have a fundamental disagreement.  ``addBagItem()`` cannot be executed on the caller thread.  ``getConnection()``, and therefore ``ConcurrentBag.borrow()``, provides strict time guarantees.  Either you will get a connection within ``connectionTimeout`` or you will get can exception.  ``addConnection()`` does not (and cannot) provide strict time guarantees and therefore cannot be executed on the caller thread.

Moreover, the user does not care where the ``Connection`` returned by ``getConnection()`` comes from (nor should they).  If it happens to be a new Connection generated by ``addBagItem()`` that is fine, but it is *equally* valid (and more likely in an active pool) for the Connection to be one returned to the pool by another thread.  If a caller to ``getConnection()`` were ultimately blocked in ``addConnection()``, even for a few hundred milliseconds, it wouldn't matter if 10 Connections became free in the pool because that thread would remain blocked waiting for the underlying DataSource.  The overhead of an asynchronous handoff is 20ms at the *outside*, but cost of blocking a thread on connection establishment (and missing opportunities for returned connections) is almost always higher.

The current design was not accidental -- asynchronicity is there for a reason, and it is quite deliberate.

If you have "spikey" loads, as our documentation suggests, do not set ``minimumIdle`` and allow HikariCP to operate at its default -- a fixed size pool.  In 90% of the codebases I've encountered in 25 years of coding, there was never a solid justification for dynamic pool allocation.  But that is getting into a much deeper debate.


Consider renaming it to e.g. ```navigation``` or ```galleryNavigation```


Extract this class to its own file


File is not refreshable.


saw approval from cmr
at https://github.com/steveklabnik/rust/commit/3e0a905a3b97576dddcf94a72183283c55eb2581


merging steveklabnik/rust/five_eye = 3e0a905a into auto


merging steveklabnik/rust/five_eye = 3e0a905a into auto failed


Method needs re-factoring as it's too complex


this hides video osd control >>| why?


Hard-coded strings to be made customisable in the class constructor


after update some sounds and music are not working
Failed to load sound "saxton_hale\saxton_hale_responce_win1.wav", file probably missing from disk/repository
Failed to load sound "saxton_hale\saxton_hale_responce_lastman5.wav", file probably missing from disk/repository
Failed to load sound "saxton_hale\hhh_theme.mp3", file probably missing from disk/repository
Failed to load sound "saxton_hale\saxton_hale_responce_lastman3.wav", file probably missing from disk/repository

and others.
intro and end of HHH round works


*REF1: Never use the parent class name - there should always be an inner class to use. For this example you should use '.company-logo'.


Some research needed here to work out if there's a better way of populating dynamically loaded templates


Job pr-scala failed for 3bbf6f01 Took 63 min. (ping @lrytz) [(results)](https://scala-webapps.epfl.ch/jenkins/job/pr-scala/9438/):

To retry exactly this commit, comment `PLS REBUILD/pr-scala@3bbf6f01d3acb59894f0ef29e89ca54cf29200dd` on PR 4210.
NOTE: New commits are rebuilt automatically as they appear. A forced rebuild is only necessary for transient failures.


Because it is not needed, I added IntegerGreaterThan(Playlist.Length(video),1) as a vis condition for that.


*REF1: Should use '.company-link' instead.


Don't forget to rid this and other ```console.log``` statements


Very Nice this!


No need for a hash map, a simple array will do


The bower registry must be updated with a new tag. If you install with bower this package the bower.json file is not created.


@lyrixx @jeremy-derusse why collection all the directories instead of passing the iterator `$files` Iterator directly into the `Filesystem`?


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/6278/testReport/) for this commit**


*REF1: Should use '.company-name' instead.


saw approval from cmr
at https://github.com/amaranth/rust/commit/5b0bebf6b492332ccb56de4308992174d43731b6


This is a db query helper so should probably be placed in the DAO class


merging amaranth/rust/black_box_output = 5b0bebf6 into auto


status: {"merge_sha": "9159e8839d098722b8e5e275c5b1d0dd88e956e9"}


amaranth/rust/black_box_output = 5b0bebf6 merged ok, testing candidate = 9159e883


84202472-TurnOffInputEchoByDefault (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1576 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It is a tiny issue.... but it might help when we 'steal' from here.... ;)


Не не. До первой невалидной. Все верно. Но в самом плохом случае будут запускаться все. Вернее это будет случай, когда значение валидно:)


*REF1: Should use '.logo-link' instead.


Rid all ```console.log``` statements in this file


Thanks.


Do you mean to include the voided ones?


Good catch. :)


Class- instead of global node- approach needed here.  And, consequently, introducing Sass instead of pure CSS.


Вероятно мой правильнее будет назвать watch :) Это потом


What the heck?


I'm not using 'stapler-class' in one of my static analysis plug-ins but also get that warning for my publishers. Is this inherited somehow from core?


With this change aren't we losing the pointer cursor style?


You added this option, but it is not used.
Why did you do that optimization (merge consecutive PUSH and remove distinction between PUSHB and PUSHW) on import. This should, if at all, be done on export with a optional setting.


I renamed the class but forgot to change the module name there. You want me to use wget from the the hyve fileserver anyway, right?


i have only merge from vix  , atv have no problem to use the real name i have  add a big thx pli !


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1777](http://teamcity.monogame.net/viewLog.html?buildId=4171&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 295, ignored: 6 Build time: 00:16:46


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1778](http://teamcity.monogame.net/viewLog.html?buildId=4173&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Thank you for your contribution! this widget was on my todo list


А зачем пробрасывать из bemjson? Надо просто чтобы параметром можно было регулировать. Через js моду.


XZXZX


Do you mean changing allergyType = "DRUG"; to allergyType = "OTHER";?


Hi torstenfeld the code looks great! I have a couple of comments, first I would do the attributes  `angleArc`, `fgColor`, `angleOffset`, `displayInpu`, `displayPrevious`, `step` and `readOnly` optionals, placing data-* in the template might be enough, and the second in the Readme you should specify  the `lastUpdate` method and the `home` variable that is calling the event `knob/render`


500px is too large for tablet - can you decrease it a little.


This is frustrating. You can always define the `FeatureSelection` symbol as a global at the top of the file.

```javascript
/*globals FeatureSelection: true */
```

This directive effects only this module and means we don't to have to program to JSHint's broken notion of ES6.


asdd


@unorthodoxgeek `unless column_exists? :audits, :request_uuid`


Currently, when we run the tests locally on browsers, we just run `yeti` directly, with no params, and without running `yeti --server` on another terminal before. We also have a gulp task that serves as a shortcut for this, which is `gulp test-browser`. Is there an advantage to running the tests like this instead? It seems so big to be on the main README for the project, so if this is important it could be best to have this on the wiki instead, which explains the use case for running the tests like this.


This is nested to deep. Try not to nest more than 2 levels deep.


Fixed


https://github.com/jshint/jshint/issues/2019

I think this is the correct issue.


Because we don't want to leave empties directory.


Done


@briantigerchow:

```
ok  	github.com/jbenet/go-ipfs/exchange/bitswap	0.540s
```

:smile:


I'm working on to make the CMakefile for V8, before that you may checkout the github repository and try to build v8 using nodejs Makefile, https://github.com/v8/v8-git-mirror


@yorkie Nah. No PR necessary for quick fixes like this. Thanks for asking!


Yeah, I was thinking about removing it, or not. Testing randomness is "tricky" :p

The theory here is that it is extremely unlikely not to see all possible 256 values in a corpus of 1M random data points that are supposed to be uniformly distributed. Of course, this assumption might still fail if the extremely unlikely case is indeed hit in the wild.
I left it in because I figured it is better to false-negatively fail a test once in a (very long) while than false-positively accepting broken distributions because there is no test for that at all.


Again, nested too deep. The 'Toggle Button Closed State' CSS can live on it's own.


There is a small bug here so, if you get here before me, I will update the request with a fix.


Good catch, I didn't mean to remove the virtual.


Ok, will go back to original which works fine. And by the way the file is UTF-8 encoded in this version. After all what is the point using the that encoding flag if not encoded in that format.

BTW, @atvcaptain, I did test this file before committing, without any problems.


It probably shouldn't, but I'm planning a refactoring around a lot of this that will obsolete the multiple calls.  I had to make the change I did to satisfy a spec that checked invocation count on a mock object.


Inserindo


Так оно так и работает сейчас. В каждом поле мы создаем этот объект, загоняем туда все валидаторы, и `onChange`/`onBlur` делаем `.run`, на что получаем в ответ первую ошибку из валидаторов или `null`.


Sorry dont agree https://github.com/phil65/xbmc/blob/d43d8f053987c9bfdd9d20e0c14a5afa9a1f202b/addons/skin.confluence/720p/VideoOSD.xml#L105-L114 should be visible

Makes no sense it hidden even when its should be visible.


answered [here](https://github.com/CartoDB/cartodb/pull/1655/files#r22461133)


It could, we are planning on refactoring this tasklet and reuse code from the recent SqoopTasklet where we limit the log output captured.


std::stoi converts string to int not to int64_t


I can't quite remember as I made this change quite awhile ago (and only submitted it recently).  I will try and reproduce the issue again and get back to you.


@laruence `php -r '$a = [1, 2]; foreach ($a as &$b); $z = array_values($a);'` made the zend_reference before this commit. (also some other array_* functions which use zval_add_ref)

@smalyshev I ran it through `make test` … but I thought they were broken before already. Especially as I'm just freeing some memory and these two tests are leaking other, unrelated memory. So, I don't get how that is related to this commit?


Is this an official release?
NEWS still says "Changes in 1.0.0 (not yet released)"
Should Debian update to this version?


I agree. The user interaction task source seems wrong all together here. The state changes either by an API call or something that initiated by the platform. I changed the task source in the former case to the DOM manipulation task source. Change: d52bb8a


chance of a moai.lua line that maps keyboard:setCallback to keyboard:setKeyCallback for backwards compat?


Can you try replacing the condition with `(version< org-version "8.3beta")` (as I wrote above)? I do not use org-caldav but I use ox-icalendar in one of my own projects, so I had to introduce a similar work-around.


yes. if this migration runs as a new migration (i.e. on an update) it would add the column. if it runs in the CI, it will only add the index (see line 15 in the add audits table in this commit)


1: M100 needs more reviewers
1: M101 signature is missing


1: D100 Docstring missing
4: I102 copyright year is outdated, expected 2015 but got 2014
49: D103 Docstring missing
59: D103 Docstring missing
202:5: F841 local variable 'dummy' is assigned to but never used
264: D103 Docstring missing
440:18: E127 continuation line over-indented for visual indent


oh, cool :)


Hello guys,

 @gRoussac @rGaillard

Could you share somewhere your method to create index.php in every folder with good "../../" in header.location?


Вынести эту функцию из метода класса, хотя бы на один уровень вверх.


Multithreaded Rack servers?


It's just local problems, thanks.

On Mon, Jan 5, 2015 at 1:35 AM, Michael Mifsud <notifications@github.com>
wrote:

> Can you please supply more information about the error your receiving and
> how you're compiling Libsass?
> On 5 Jan 2015 19:34, "Michael Mifsud" <xzyfer@gmail.com> wrote:
>> Did you also pull the latest sassc?
>> On 3 Jan 2015 07:48, "Sam Mikes" <notifications@github.com> wrote:
>>
>>> After pulling master onto OSX, I get a failure here.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/sass/libsass/commit/31521ef3ece636892f395a80392448ceae449b90#commitcomment-9139421>
>>> .
>>>
>>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sass/libsass/commit/31521ef3ece636892f395a80392448ceae449b90#commitcomment-9150018


Переписать в PDO


Actually, I've just talked to Zeno about this, and he said that any version numbers should be in the project's `package.json` file. Some dependency versions are already there, like gulp's and node's. We're currently missing the version for npm though, and he said that should be added on the "engines" entry. Can you add it there instead of on README?

Sorry for all the comments, I've been trying to find the best place to fit the information you need :)


То же самое


Why is this a public method?  Doesn't seem like something that should be exposed.


Trying to use the library now. I think this line should stay here (without it I get errors when trying to communicate by serial port). Am I right or wrong?


Перенаправлять на какую-нибудь другую страницу, например на главную


This are not required and really should not be part of this PR.


I'm still thinking of what the best way to solve this is. Effectively all animations that are included or appended are reset after reloading, and so all animation state of all mesh instances needs to be updated.

But this might actually be only part of the problem, because I think skeletons are not updated when a definition is reloaded at the moment. Consider the following:

1) What does StdMeshSkeletonLoader::StoreSkeleton actually do if a skeleton with the same path exists already? I think it keeps the skeleton that exists already, and throws away the new one.
2) Before reloading a definition, we should throw away all skeletons in the StdMeshSkeletonLoader that were loaded from that group. Otherwise we might keep old skeletons around that have been deleted from the definition. I think a similar thing is done for mesh materials at the moment.
3) When the skeleton has been correctly reloaded, are we sure that all StdMesh objects use the newly loaded skeletons? It might work, because the StdMesh object gets reloaded just as well, but what about included and appended skeletons? Say we reload a skeleton that is appended to the Clonk mesh, then we need to update the skeleton in the clonk mesh, which is not done automatically, since the Clonk definition itself is not reloaded. If we don't do this, the Clonk will still have the old animations from before the reload.


84202472-TurnOffInputEchoByDefault (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.90012642225032%25-red.svg)


Right now HifSource isn't introspected.  It looks like it'd be pretty easy to do, but let's make it a separate patchset?


This PR should not contain unrelated formatting changes.


Не возвращать, а устанавливать переменную ошибки, чтобы затем отобразить ее на View.


It was probably simply the latest version at this time, or the new version was too new.
Or maybe 0.12.1 is distributed differently and I could not get it to work at the moment; they change their distribution mechanism too often.


should keep the message in session before to redirect to login...


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1778](http://teamcity.monogame.net/viewLog.html?buildId=4173&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 293, ignored: 6 Build time: 00:15:57


This method will be difficult to use in PHP 5.3 compatible libraries like Nette/DI. Maybe we should add a condition for that.


Can you put each argument on a line? I think it looks better like that.


Just curious about that binding line. We used to write that kind of lines like:

```this.model.bind('change:liked change:likes error', this.render, this);```

Are we using that syntax now?


Ok, got it. this is fine now.


I am pretty sure it prevents keypress from being called but not keyup. Code is fine, just the comment might be confusing


It's already backwards compatible. I did it directly in `MOAIKeyboardSensor` rather than in `moai.lua`.


Rude, you need to explain that SkypeNet is always watching over you, making sure you are no threat.

'Restarted' does not capture this.


I'm experiencing the same (building for RHEL/CentOS). When builders are under heavy CPU strain, they just don't succeed to run tests in time. If there is no reliable way to check the correctness of this behaviour, I too suggest to remove this test.

The problem can be reproduced e.g. by running stress [1] simultaneously with tests.

[1] http://people.seas.harvard.edu/~apw/stress/


This change will remove trailing spaces of the next line when a "whole line" is selected: e.g. use Select Current Line(s)* (`<Shift><Alt>L`) and then trigger *Strip Trailing Spaces*, and you get spaces removed from the next line too.  I am not sure how important it is, but it probably is inconsistent.
Maybe you should use `editor_select_lines()` to do something like this:

```diff
diff --git a/src/editor.c b/src/editor.c
index 3c30506..e9fb505 100644
--- a/src/editor.c
+++ b/src/editor.c
@@ -4458,8 +4458,9 @@ void editor_strip_trailing_spaces(GeanyEditor *editor, gboolean ignore_selection

     if (sci_has_selection(editor->sci) && !ignore_selection)
     {
+        editor_select_lines(editor, FALSE);
         start_line = sci_get_line_from_position(editor->sci, sci_get_selection_start(editor->sci));
-        end_line = sci_get_line_from_position(editor->sci, sci_get_selection_end(editor->sci)) + 1;
+        end_line = sci_get_line_from_position(editor->sci, sci_get_selection_end(editor->sci));
     }
     else
     {
```


You'll want to patch for the POODLE vulnerability before this gets merged upstream: http://nginx.com/blog/nginx-poodle-ssl/


Why this wasn't done before is beyond me. :)


I think this could be an `ArgumentNullException` instead:
``` csharp
            if (points == null)
            {
                throw new ArgumentNullException("points");
            }
```


84202472-TurnOffInputEchoByDefault (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes, probably the reloaded skeleton is not even transferred to the skeleton. How does the script engine handle this? I mean there are includes and appendtos, too, so they have to have some kind of solution for this.


Давай еще метод в `try` переименуем.


Then solve the issue with a null test where the method is used (`PathAnnotation`, right?)


Not sure, you default to default(ScreenPoint). I think returning a default is better than throwing an exception. I have the same issue with VerifyAxes() where it throws exceptions where it should just cancel rendering the series (much faster).


But why is hit testing called before the annotation is rendered? Could this really be some other issue?


Я про то что надо полу инстанcу `validate`, из которого можно получить ошибку. Хай будет validate.error ?


I think our general consensus is that if statements should always have brackets. Makes things clearer to always have a single style.


;-) А js моду ты не в bemjson будешь указывать?


Considering the current numbering scheme of gettext, this should probably happen in... 2158 :-) But you're right, of course.


I hadn't noticed `suspendStatusChangeTarget` is a weak reference (despite a clear comment to that effect in the declaration). I think the object is being cleaned up during the method call. The advice seems to be to hold a strong reference for the lifetime of the code block making the call: http://stackoverflow.com/questions/11899134/how-to-properly-address-weak-receiver-may-be-unpredictably-null-in-arc-mode

I'm not sure why `objc_msgSend` avoided this problem.

Are you personally able to reproduce the crash? If so, could you try this fix for lines 154-161 of the file?

    id localSuspendStatusChangeTarget = suspendStatusChangeTarget;
    if(nil != localSuspendStatusChangeTarget)
    {
         if([localSuspendStatusChangeTarget respondsToSelector:suspendStatusChangeSelector])
         {
             id (*method)(id, SEL, bool)  = (id (*)(id, SEL, bool))[localSuspendStatusChangeTarget methodForSelector:suspendStatusChangeSelector];
             method(localSuspendStatusChangeTarget, suspendStatusChangeSelector, manualSuspendLock);
         }
    }


Я нет:) Я буду выставлять параметры при инициализации другого блока. А ты вот да, наверное ;-)


I am doing some special things.

1) Create view (but not show it)
2) Load a project (create the plots)
3) The visibility fix (for performance) kicks in, don't draw invisible plots
4) Move your mouse => boom

I have fixed it by forcing a redraw the first time the app is loaded (where it can load a project via command line arguments), but I thought let's fix this anyway.


Looks good to me; tidies up my mess in any case.


r+


This is the same challenge we face in enterprise LOB application development where different teams follow different standards. The best way is to have consistent conventions (now, acceptable by Roslyn analyzers) and feed the source code into systems like SonarQube or InspectCode (read: ReSharper) to find out inconsistencies if any.


Какой такой `try`? ;-) `run` в `try`? Можно, конечно... Думаешь `try` лучше?


Думаю да)


あちゃー、直します


heads up... force-pushed revisions


ありがとうございます！


I'm still not sure why this didn't work.


The problem with the original file was that it got (properly) converted to utf-8 when being edited online while the xml info still said iso-8859-1, creating a mismatch.


Jep, that's a typo. I'll fix it.
I have a feeling you're just reading the entire pull request. :-) Given that you're likely to find more stuff, can you mention in a comment when you're through? I'll then do a single push rather than multiple small ones.
And, by the way, thanks for being so thorough! I'm a huge fan of peer review!


The selection shrinks after triggering the commands on partial lines.  In practice if you select 2 tabs (`[\t\t]`) and trigger *tabs → spaces*, the operation is correct but then only 1 tab worth is selected (`[\s\s]\s\s`).  If you don't touch anything and then trigger *spaces → tabs* you of course only get 1 tab worth converted back, and no selection at all (`[]\t\s\s`).


why do we need this 2 cases here (with helper and without)?


BTW: It would be the best to even get rid of those accents and umlauts entirely.


Why `array_merge` when `$sources` is always `[]` at this point? What about

~~~php
$sources = isset($data->bin) ? (array) $data->bin : [];
~~~


Right, let us fix this. But I would prefer to do the null check in the hit test method, and throw an exception if `points` is `null` in the `ScreenPointHelper`


Looks good, thanks.


合并


This does not handle the cases where the number of followers is something like "2.1K" or "5.1M" etc. Case in point is https://twitter.com/BarackObama

So this line should be ``re.search("(?P<number>[\w\.,]+)", content)```


I'm guessing this string allocation and conversion is really slowing things down, how about adding `stringnames = map(string, cnames)` or similar at the beginning of the function?


Removed


I see now why this method is public but it assails my sensibilities. If possible, please find a solution that doesn't expose methods that should not be part of the public api.


shouldn't this be ``type === 'err' instead ?


r+


These two changes do more than what is described by the commit message. Is it an additional fix discovered by the new test, or is it a leftover debugging change that should be reverted?


Sven meinte du musst nach der Minimierung nochmal maximieren.


perfect!


that dastardly status list gotcha again eh?


Same here.