Yeah, incorrect assertions are arguably worse than no assertions.  Would be better if the test were written in such a way that fixing #1740 would not break this test.  (ie. check for the existence of these invocations, rather than asserting that these are the only invocations that occur).  That way, a pure-fix doesn't force a unit test change, and unit test changes therefore indicate a change in api/expectations as oppose to a change in implementations.


Comment Test


An observable change in implementation IS an API change. Fixing #1740 is a breaking change and therefore needs the same rigorous follow up as any API change.


Yeah this should be `$year < $dt->year || $year == $dt->year && ($week< $dt->week || $day < $dt->day)` I think


I believe hasCredentials is automatically set from the Adapter and it should not be set here


same


No it is not possible as the `pMemStruc->pKernelAddr` points to the start of the memory where the PCP binary is loaded. If such a scenario occurs it should be handled as an error.


Why? npm supports user/repo style. npm/npm#3783 normalize-package-data#31


dd


Could you change this variable name for something clearer? like ``arrayStruct```or something?


Thanks! I fixed it by https://github.com/danmar/cppcheck/commit/3aa4f5de47f96947c2d7220f45713f988fe0e375


That's one way of looking at it.  Another would be: The binding API is what's published in the docs.  Anything else is implementation detail.


I was lazy and I use this poor script to automate github release https://github.com/MoOx/setup/blob/master/bin/npmrelease
I should probably update my script.
That being said, I think even if GitHub is amazing, it's not the only place where open source projects are. So it's better to get a full url instead of that. Like for your license field ;)


I just did this too. Rolling back to yours on local, but we've got to get some sort of project management going to stop this from happening so often.


CMAKE_PREFIX_PATH = <value>. a path where cmake looks for files such as includes in <value>/include and libs in <value>/lib
CMAKE_INSTALL_PREFIX = <value2>. path where cmake will install files t such as includes in <value2>/include.
CMAKE_BUILD_TYPE=Debug|Release|RelWithSymbols. Set optimizing and symbol generating flags according to given value.

As you see these all serve different purposes. You need the prefix path to pick up the kodi config, the install prefix to install kodi-platform into the same directories and you set the build type you want.


@MasseGuillaume i'm not sure what you mean. do you mean to use the ackermann function to test whether or not we get a stack overflow? if so, yes. a tail-recursive or trampolined fixpoint combinator should succeed


Does this fix your issue? If yes, it also should go to 5.0 branch.


What is, if the item was dropped by a mob or block?


> So it's better to get a full url instead of that

Yeah, that is also correct.
OK, I'll use full URL in this repo and org :)


This is a no-op, as `null` is falsy.


The labels were already defined manually for these instances in SUN/209; given its not that likely to come up often I was just going to use the nolabel version for those instances and use the manual label instead. Didn't you say the ast docs also use manually defined labels in your commit? The sstroutinenolabel could also be used there to avoid having to re-write.


Good work :)


I test it tonight.


288
289


By the way, curious fact:  after I upgraded to node 0.11, I saw a dramatic change in the relative performance of commonmark.js vs markdown-it.  With 0.10, I was seeing commonmark.js around 850 ops/sec, with markdown-it consistently over 1,000.  With 0.11:
```
commonmark.js markdown->html x 904 ops/sec ±1.75% (93 runs sampled)
showdown.js markdown->html x 245 ops/sec ±1.88% (86 runs sampled)
marked.js markdown->html x 772 ops/sec ±1.08% (96 runs sampled)
markdown-it markdown->html x 863 ops/sec ±1.24% (95 runs sampled)
```
So commonmark.js is faster and markdown-it significantly slower under 0.11.  Have you noticed this?


Why did you say thanks then? false alarm?


Whatever: Here is a build for you to test: http://saraev.ca/oe/OpenELEC-Generic.x86_64-5.0.1.tar


No.


@bigtan 是因为go 1.4 引用的特性"权威路径"
就等我最新的PR 里,等作者merge了


Yes, at first I actually used DEF_WORDLEN_DIST[] (though updated to full Rockyou and up to length 32) but it the end I made this separate table. We shouldn't optimize too much for Rockyou...

For length 1 we can't really ever get any more than 8 :-)  and likewise we could set length 2 to have 16, it really depends on what input we'll get.


That puts a lot of pressure on the docs since every detail that you may rely on needs to be documented, and understood.

In practice, people accidentally rely on implementation details, or intentionally because there's no other way to solve it. To be good citizens we need to document breaking changes even if they're undocumented. `context` isn't documented yet we go to extreme lengths just to even add a warning instead of just breaking it.

Anyway, I'm adding a comment so that if someone stumbles across this, they'll hopefully notice comment.


1 abf033


the install prefix should actually be taken from kodi-config.cmake if you do not explicitly pass it.


Wow I must be tired. "Looking Mom", xD


Well, thanks for the fix.
Thank him for his efforts.

I will test it tonight.


ref. https://github.com/itamae-kitchen/itamae/issues/68


```
% /usr/local/Cellar/node/0.10.35/bin/node bench/bench.js bench/samples/README.md
commonmark.js markdown->html x 866 ops/sec ±0.97% (97 runs sampled)
showdown.js markdown->html x 262 ops/sec ±1.91% (87 runs sampled)
marked.js markdown->html x 792 ops/sec ±1.21% (95 runs sampled)
markdown-it markdown->html x 1,073 ops/sec ±1.21% (96 runs sampled)
% /usr/local/Cellar/node/0.11.15_2/bin/node bench/bench.js bench/samples/README.md
commonmark.js markdown->html x 918 ops/sec ±1.54% (94 runs sampled)
showdown.js markdown->html x 245 ops/sec ±1.74% (86 runs sampled)
marked.js markdown->html x 783 ops/sec ±1.07% (97 runs sampled)
markdown-it markdown->html x 880 ops/sec ±1.76% (92 runs sampled)
```


@mintsoft This doesn't seem to work either, I spent a good 15mins trying to figure this out :laughing:

**Query:** what is the 6th week of 2015
**Current:** Week: 5 | Day: 27 | 2015

**Conditional:**
if 2015 less then 2015
OR
if 2015 equals 2015
AND
(if 6 less then 5 OR if 2 less then 27)

**Result:** The 6th week of 2015 began on February 2nd.


1. `phenoTipsDataSpace` is a bad name, there's no **data** in that space, just code.
2. There's [`Constants.CODE_SPACE_REFERENCE`](https://github.com/phenotips/phenotips/blob/master/components/constants/src/main/java/org/phenotips/Constants.java#L37) for this, use it.


set to `false` in the else branch ?


`Pointer` is a very technical name.


BTW another minor optimization we could do is this
```
-       const u32 hash_alloc = ALLOC_NEW_DUPES;
+       const u32 hash_alloc = MIN(hash_size, ALLOC_NEW_DUPES);
```
There's no point in allocating 0x100000 for length 1 and 2 that can't use more than 0x100 and 0x10000.


You should work more with references, return a `DocumentReference` instead.


Fair enough.  You make the lives of other developers too easy :).

+1, I like comment idea.


I disagree. Firstly, there is no way to see if user changed the name, so this is all just guess game, but at least I want to be sure that “ellipse 1” wouldn’t pass. We can lower case it later if we want.


Why does this method exist here?


I do not seem to see the value of this method. Why doesn't one just directly call canWrite()?


@bbroerman30 ups, i meant you actually, was too early in the morning ) Please create a PR, so one can test and merge.

In case you need answers to you questions now, for the winsock error codes https://msdn.microsoft.com/en-us/library/windows/desktop/ms740668%28v=vs.85%29.aspx (but not sure it's what you're loking for. For th eprocess id it's GetProcessId(). But generally MSDN documentation rocks.

Thanks.


please check: http://www.opena.tv/mk-digital-maxdigital/13592-bluescreens-und-staendige-reboots-nach-gestrigem-update-ueber-feed.html#post119874


Why don't you just directly call canWrite()?


@baev should I again release v1.1?


In your reset, it's always good practice to remove the selectors that you aren't actually using. Like, ```abbr```, ```acronym```, ```applet```, etc...


Does this actually work? What exception is getting thrown and caught here? Regardless, exceptions shouldn't be used for logic flow.


is `type` part of the spec or just something that you've added? it's such an overloaded word - i'm just wondering if there is a better candidate we could use...


Thank you anyway. Out of curiosity, what exactly does your agency do?

On Mon, Jan 26, 2015 at 11:02 PM, Christian Varga <notifications@github.com>
wrote:

> No worries! Was just interested, I like your work and my agency is looking
> for an in-house front-end developer so I thought it couldn't hurt to ask
> where you're from. If you're ever in Melbourne hit me up!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BFard/Sudoku-Solver/commit/06f8cf696e3a85e9d58069142833a39379c3f77c#commitcomment-9453764>
> .
>


How is it a default name? Why it has “svg” in it?


@matthiaskrgr Thanks a lot.


Should this be method.isAnnotationPresent ?


Consider a ```ul``` instead of just ```divs``` here and make every ingredient an ```li```. It's much more semantic.


I do not think invalid fits very well for un writable. I would replace invalid with unwritable.
I would also remove invalid from the error message.


Remove the extra white space below


if you were feeling ambitious you could add a test that had multiple blocks in the same path


missing test: re-run when args change -> missing `false` in jit CD not detected


Really, `Node` was the most descriptive name available?


You don't need lines 124-136 unless you're actually using them.


Move the footer into the body.


I see what you're doing here, but should definitely find a different way to do it that doesn't involve an exception being thrown and caught. Even if you really had to use exceptions as logic flow, you should catch the specific exception you want to catch, not all exceptions as is being done here...


I think this whole code could be simplified by splitting it into the backwards-compatible case, and the new case that you are adding. Thanks.


In the above constant, i would replace invalid with unwritable.


This div could be better as an article and all divs in it could be sections of that article.


I don't think this should be in this pull request? Not a huge deal, it's a one-liner and it is fixing a very annoying problem for everyone so I'd probably just take it along with the rest....


I'm testing branches


Plugin 'kien/rainbow_parentheses.vim'


I don't think it matters, but was there any significant value in changing the doc type?


`PatientChangedEvent` is also sent for new patients, you should only list that.


fgf


Overall, not bad! Could be a little more semantic, but you've got a handle on it.


I guess this is really an edge case, in case you have a sqlite connection string with a port... shouldn't normally happen, but the message is not quite accurate then.


Wouldn't you rather want to return [] (empty array) than an empty string here?


how much of this is copy/pasted from the other implementation?


This class is not used at all, if you don't plan on using it, then remove it completely.


Note to self: the sanity checks weren't working because ---- p string_to_characters([remember]) == ...

There's a difference between `["remember"]` and `"remember"`
----- "remember" is a `String` that contains a single `String`
----- ["remember"]` is an `Array` that contains a single `String


Whoa, bro.


Adjusted jump speed of main character.


For me,i required both node-less as well as installing less via npm to get rid of the errors when running the server in the browser.


Why create a new Zotero object here? The Zotero object is globally accessible, I don't know what the ramifications are of re-initializing this global.


dfdf


dd


1. Don't use `api` in the package name, by default everything is an API.
2. Is Family really supposed to be a subfeature of Studies?


I think it'd be better to use a url param than a toggle. That way the same user can easily do side-by-side comparisons.


@addyosmani: can you add a new AppVeyor project so that we use it here?


can you clarify why this was necessary?


da haette ich jetzt geschreiben
for my $key (qw(example default error_msg ...)){
    $checkKey->($elem, $key, 1);
}


Why `getCause` and not `ex` directly?


Returning a text/plain response with a string of text is not very good from an API standpoint -- it's impossible for the remote side to parse in any form and assumes the consumer is a human.


Can you convert all the tabs to spaces?


If you need the patient, then cast `event` as `PatientEvent`, which has a [`getPatient` method](https://github.com/phenotips/phenotips/blob/master/components/patient-data/api/src/main/java/org/phenotips/data/events/PatientEvent.java#L50).


Just out of curiosity, why make this a web endpoint rather than a json-rpc method like Zotero.BetterBibTeX.schomd.item?


These should probably be lager calls so they write to the log.


There doesn't seem to be a header file named CCDeprecated.h anywhere


Usually, we'd call the method something like `to_json` here, since each content type can have it's own content producing function.


Agreed. Even I don't have a silver bullet now. I just thought it might be intuitive to have a static text rather than the subdomain, which might not make sense all the time. Reverting back for now.


Oops! Fixing it.


These specs should use the type specification from webmachine instead of the record itself.


mhh what are you working on?


@MrChrisW I noticed the mistake after I added it and ninja edited, should work now that
(6 < 5 && 2 < 27)


Maybe use the `last-modified` and `etag` features of webmachine here so browsers also cache the response as long as it's still valid?


1277852-CommandLineInterface (nealkruis) - i386-Windows-7-VisualStudio-12: OK (1586 of 1592 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.62%25-yellow.svg)


That's not a good idea.


I'm confused by what this function actually does or will eventually do?


How about in CSS, something like
```
#doony-title:after {
  content: " - Continuous Integration System"
}
```


ok


I think your enum and helper functions really help simplify the code, so thanks for doing that. :) Test it locally and let me know if it works okay for several different kinds of queries.


In general, it would also be nice to have `@doc` strings on these functions to assist in understanding what the code does.


Actually that might be an issue, since initially `F` was used as a prefix for patients as well, and we still have a few `F_` patients on PhenomeCentral, from an early Care4Rare instance.


might fail - when we are under memory pressure? videoBuffer might be null


@mintsoft Can confirm that works! You're such a ninja ![image](http://i.imgur.com/RZNX1vt.gif)


Ah, I see -- you call Zotero.BetterBibTeX.schomd.item as a helper method below. If it's all the same to you, I'd prefer these two web endpoints to be json-rpc methods, as implemented by the schomd web-endpoint. From the client-side, calls are not harder to construct than using these endpoints (see http://json-rpc.org/wiki/specification); on the server side, the grunt work is handled by the schomd endpoint, and all methods that are whitelisted in web-endpoints line 199 (`when 'citation', 'bibliography'`) are proxied automatically. Just implementing Zotero.BetterBibTeX.schomd.item and whitelisting it makes it available over json-rpc.


헤헷 감사합니당! 시작하기 전까지 카드가 바뀌는 속도 부분에 좀 더 다양한 알고리즘 적용해보려고 하고 있어요 ㅋㅋ 서현님도 혹시 좋은 아이디어 있으면 알려주세요 ㅋㅋ!


Also, I think `N` should be a path segment instead of a query parameter.


Agreed. If nothing else, make a note in the issue if you start working on it.


Finally, I don't understand what `N` will be: maximum `N`?  Confused, given clusters can operate with many values of `N` simultaneously.


Merce dir :)


I took into account all you comments.
I agree that some deleted files may remain and led to some weird results.
I might try to do some more reliable stuff using new dpgh file.


hello world


I don't know, ask the guy who made the commit


Nice one :)

I like it when you fix tests too :)


//fix issue#200 右键文件树失效


DFDFDFD


This is broken for some reason, I can't build gradle due to this erroring.


Thanks, fixed


so staying to OpenSSL 1.0.1k ? I am going to make  new build systems


Great. Thanks :-).


This commit is way too large and contains all kinds of vendor/log crap. These should have been ignored from the start. The overall repository size is 134 megabytes. For comparison, one of your competitors repository is 2.3 megabytes, which we also consider too larger.


大神 ！留一个联系方式。


厉害


Happy new year ;-)


Adding author=you would not hurt.


Reverted back to domain itself, as we discussed.


Added check for logo file existence.


Could you add a link to the source, and copy the license of the text in the comments?


Assignment in condition - you probably meant to use `==`.


`end` at 6, 11 is not aligned with `variable = lambda do |i|` at 4, 0


`end` at 2, 16 is not aligned with `if` at 1, 11


Literal `true` appeared in a condition.
Useless assignment to variable - `variable`.
Trailing whitespace detected.


Useless assignment to variable - `variable`.


Use 2 (not -9) spaces for indentation.


`END` found in method definition. Use `at_exit` instead.<br>Avoid the use of `END` blocks. Use `Kernel#at_exit` instead.


The use of `eval` is a serious security risk.


Literal `true` appeared in a condition.<br>Don't use parentheses around the condition of an `if`.


Use `Kernel#loop` with `break` rather than `begin/end/until`(or `while`).


Avoid rescuing the `Exception` class.


Shadowing outer local variable - `x`.


Useless assignment to variable - `x`.


Unreachable code detected.


Useless assignment to variable - `b`.


Operator `*` used in void context.


Literal `'aaaa'` used in void context.


Variable `SOME_VAR` used in void context.


Is this merge at official cm sources?


all good for me - http://www.opena.tv/mk-digital-maxdigital/13592-bluescreens-und-staendige-reboots-nach-gestrigem-update-ueber-feed-post119886.html#post119886


Remaining args after getopt & co (& options if '--' is used) at argv+optind


Backup files should not be in repository


Do you mind throwing some light on why change from the getValue() method call to direct property access?


Why I can not see my own commit ? with my name as a commiter ? something wronf during the commit ?
https://github.com/got5/tapestry5-jquery/commit/8cee7b9c4ae9bdaca682c2d7c6f765d0ffc831c3


De mit, ugye?


Thanks :)

Am Dienstag, 27. Januar 2015 schrieb Eliseo Martínez :

> the clearest, always performant and most correct would be a const pointer
> to a string literal
>
> Ok, I'll do that.
>
> Didn't know about write-strings warning. Thanks for explanation.
>
> Everything clear now ;-)
>
> Will correct that and repush.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elmart/neovim/commit/115a24dde3fc5f5c097ab7a3d624e26fc6de950e#commitcomment-9450747>
> .
>


Adding upper bound for keepalive would be nice. Could be implemented as regular glib timer that stops the keepalive (but not the child process)? And some command line arg for the tool to specify it.


Don't think this was intended!


Your changes on this file and index.html overwrote mine. Please fix and resubmit.


One space here.


Il vaut mieux utiliser un visiteur du type http://docs.oracle.com/javase/7/docs/api/javax/lang/model/util/ElementKindVisitor7.html

On les a peu utilisé jusqu'ici.


yes, otherwise i wouldn't have picked it


Why do you fetch cart instead of customer?


Completes #1.


@bsaiken

Ok, I'm fine with what we have. I have my own skype notes doc too. I just needed the detail about the agenda doc. Thank you.


Intended comment?


Analyzed and merged multiple large data sets to build knn and rpart models, and predicted presidential election results with fancy plots generated from these predictors


nickel sinon.
va quand même falloir trouver un moyen de dégraisser LinkerAnnotationProcessor :/


We should create a TS interface for this external definition.


Thanks.  I've been meaning to go through and tag them.  I think we're past the fixture issues.  If I can't get to it this week, I'll do it next week.


Ok, thx for clarification!


Okay fine, maybe next time add comment for me, so that I know that :)


Ok


Ok, maybe add a comment here for clarification!


CFY-1993
Added keypair & filesystem icons to topology font


I'd say: use getopt & co, properly handle at least  '-h', '--help' & '--usage'


It's just to check that when the customer gets deleted there are no carts associated to it.


Yes, you should handle that error since it is a public function of the memmap module! Is it sufficient to return NULL in such case?


Perfect !!!


Agreed.


I have a question, need to be discussed.


I think this should be:

    if (!msg) {
      msg = {};
    }
    if (!msg._messageUuid) {

to handle the cases where msg or property is undefined and not defined but null. Otherwise you get ```Cannot read property '_messageUuid' of undefined``` errors.


The spec you link is from 2011. The last time I checked, there were still browsers, clients and proxies that could attach multiple cookies in a request. Maybe we could change this in the long term but that requires being optimistic that everyone is following the spec (which doesn't happen a lot in practice).


Agreed. Trying to address it.


Minor: I think you could also call `xhr.isComplete()` or maybe `xhr.isSuccess()`.


Does this comment add any value?


Gotcha


Bounding Box, doesnt make sense for point features ? For what are bbox needed in results ?


merge master with updated error reporting and new gulpfile


FWIW I also prefer double quotes because you can use them consistently as opposed to single ones


This is set by default and usually unneeded


One functional thing that pops up to me is that I would start the keepalive before spawning the child process, just to be bit safer on not getting suspended.

In  general looks good to me, see comment about comment in-line.


Shouldn't this go under "/stops/{stopId}/"? e.g. "/stops/{stopId}/transfers"


Requires should be at the top of the file most of the time

The spec_helper comments should be deleted


What do the commit version numbers represent? They dont make much sense in this context


[minor] Could you please align this comment line on the lines above and below?


This inline comment confused me. `false - is synchronous` - is it synchronous or not? :)

I agree with you that is is worth to highlight in a comment that a synchronous request is made. Maybe you could change it to something like:

    // request the linked KML with a synchronous request
    xhr.open('GET', object.href, false);


While it is cool that you created unit/integration tests, the task really was about acceptance tests.


I don't think it makes sense to support the !msg case since msg is only set to {} in the local scope not the caller scope?


oops, sorry...
import after forking does not work very well in go


що це?


Its a good idea to leave spaces between it blocks, so they dont look so crowded and are easier to disthinguish


однозначно щось не так, якщо в тебе метод складається з такої кількості If-ів. ахахахахах


Добавил email


A better description for this commit message would be
"Refactor feedback spec a little"
since this commit doesnt really contain any logic


org.opentripplanner.graph_builder.impl.NearbyStopFinder.StopAtDistance is a quite similar class, wouldn't it make sense to merge these two classes into something that's usable also elsewhere?


Bad indentation


These links though appear disabled are still clickable.

One way to fix this is to use buttons with `btn-link` class and appropriate disabled property.


Yes, it should be. I'll fix it in the next version. Thank you.


Better do through `$terminfo`, because actuall key codes can change (and will actually change across different TERMs).


TeamCity Azmq :: Build (Windows) [Build 98](https://78.46.71.115/viewLog.html?buildId=409&buildTypeId=Azmq_Build&guest=1) is now running


No need to create a new rspec configure block, you already have one


When only one hit is selected, we would want this to remain singular i.e., `1 selected hit.`


When you update gitignore, dont forget to delete the crap thats already commited as well


That's a generated file. The old migrations doesn't wirking. With the new one, you can run the project. Names with underscores are a convention for python.


It makes sense that chromedriver didnt work, if you didnt include the gem :P


TeamCity Ppconsul :: Build (Linux) [Build 66](https://78.46.71.115/viewLog.html?buildId=410&buildTypeId=Ppconsul_BuildLinux&guest=1) is now running


Merci, je regarde !


TeamCity Azmq :: Build (Windows) [Build 98](https://78.46.71.115/viewLog.html?buildId=409&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 17 Build time: 00:02:34


I like new release notes :+1:


nice move! ;)


Why do we modify the Limit in the request? The Limit attribute just limits how many objects dynamodb will evaluate, not necessarily how many results dynamo will return.


Its better to not put large logic blocks inside the expect

This would be better

```
expect{click_button "Create Feedback"}.to change(Feedback, :count).by(1)
```

Futhermore, if the request is not fast enough, then this test might fail, because the database might not have saved the changes before the check.

So even better solution would be to click the button and then use wait_until to check the database repeatedly for a few seconds.


Bad indentation for page.should

Also, if the block contains only a single short line, then its better to put it inside brackets


TeamCity Ppconsul :: Build (Linux) [Build 66](https://78.46.71.115/viewLog.html?buildId=410&buildTypeId=Ppconsul_BuildLinux&guest=1) outcome was **FAILURE**
Summary: Exit code 1; number of tests is too small: 0 Build time: 00:03:16


`s/http/HTTP/`


I'd say no as well, saves having to manage 2 types of HTML.


Are you sure ? :D


14 Looks good, except for the Build history, which goes multi line even for simpler one's without build description.
![buildhistory](https://cloud.githubusercontent.com/assets/496507/5915724/f0e44316-a5bd-11e4-9898-dd58bb50df75.png)

I am expecting something compact like this -
![buildhistory_compact](https://cloud.githubusercontent.com/assets/496507/5915726/f964ea22-a5bd-11e4-91fd-f2165ccb079d.png)


TeamCity Ppconsul :: Build (OSX) [Build 47](https://78.46.71.115/viewLog.html?buildId=412&buildTypeId=Ppconsul_BuildOsx&guest=1) is now running


One more empty line :-p?


Database cleaner should not be manually inside tests. It should automatically be run before every test


There could be no carts associated but customer could still exist, right?


API documentation is incomplete.


Database objection creation should be in ```before``` or ```let``` block. It block is for testing


always use named parameters when you pass null, true/false or numbers (see the coding guidelines :smile: )


Since we assume a random run order, then this test might fail, because the database is not cleaned before the test


14px sounds reasonable, and looks decent too. I don't want to waste much space in this, when you have 100s of Jobs configured and 100 of slaves attached. Thank you.


Bad indentation


See Homebrew/homebrew#35595 for a use case. Yeti only works with 1.7, yet specifying `depends_on :java => "1.7"` doesn’t work because of this +.


this seems to have broken the link from /usr/bin/perl to /usr/pbi/squid-xxx/bin/perl... which in tern seems to have broken lightsquid's cron job.


Lines 109-113 were still useful.


There is no reason to tag this test js: true


This breaks unlocking developers options...


Useless comments in code are very bad


yes better


Thank you!


TeamCity Ppconsul :: Build (OSX) [Build 47](https://78.46.71.115/viewLog.html?buildId=412&buildTypeId=Ppconsul_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 97 Build time: 00:03:06


[2.2-RELEASE][root@firebug.fragfest.net.au]/root: which perl
perl: Command not found.
[2.2-RELEASE][root@firebug.fragfest.net.au]/root: ls -l /usr/bin/perl
lrwxr-xr-x  1 root  wheel  19 Jun  5  2014 /usr/bin/perl -> /usr/local/bin/perl
[2.2-RELEASE][root@firebug.fragfest.net.au]/root: ls -l /usr/local/bin/perl
lrwxr-xr-x  1 root  wheel  29 Oct 29 22:42 /usr/local/bin/perl -> /usr/pbi/squid-amd64/bin/perl
[2.2-RELEASE][root@firebug.fragfest.net.au]/root: ls -l /usr/pbi/squid-amd64/bin/perl
ls: /usr/pbi/squid-amd64/bin/perl: No such file or directory
[2.2-RELEASE][root@firebug.fragfest.net.au]/root:


Absolutely not :)


The removal of the "build" script is part of the patch applied to randward, so this should not be necessary!?


This seems like a bug - the changing of feedback count by 0 means that no changes are made after delete


Ask @joschiwald, it is his code: https://github.com/TrinityCore/TrinityCore/issues/11538#issuecomment-33806157
I am not a real programmer, I just try to help out here. If you have a better suggestion, I am all for it, but please document what you talk about. it is not that much fun to close yet another PR, delete my repo, create a new repo and create a new PR. Please tell me you have got good news for me.


@Tux: hi! Even if tcsh is actively maintained, I would not recommend newcomers to get used to it, due to the problems and limitations of its scripting syntax. I've written a little about it here - http://www.shlomifish.org/open-source/anti/csh/ .


Thanks :)

I suppose similar issue could occur if the point is at `bobp`?  Maybe we should also test for that? (just guessing, but it sounds reasonable to expect that to happen with backward parsing)


Not sure why you set the download path


useless comments


Running `phpunit -c app/phpunit.xml.dist src/AppBundle/Tests` will fail.


What do you think about ```wgCookieDomain``` js variable?
Didn't dig yet but should work for us.


Should that be "Instead, it dictates that ..."?


I believe that every project can be organized with one structure. [Want to talk about?](https://github.com/Grawl/guidelines/blob/master/jade/architecture.md)


changing the link ends with the perl binary not being able to locate libperl... which is now in local/lib also


Bad indentation. Also, There is no reason to have different strategies for js:true at this point. Also, you dont need multiple blocks for each configuration for before(:each), you can use a single block ```before(:each)``` block and put all the configuration to there


:+1:  from my side too


These database cleaners seem unnecessary here and should be configured elsewhere


I can't live without urxvt and never change him.


https://github.com/Wikia/guidelines/blob/master/JavaScript/CodingConventions.md#style-rules

Keep it <= 120


Thanks for mentioning! :)


I think the problem comes from here.
The environment is cleared by: ``let env = local_env env in`` just after. We cannot lookup for those approximations in the environment after that point.


commited updated Gemfile.lock after bundle update.


can we make the `"/ipns/"` and `"/ipfs/"` paths types so we have some type safety? and then use `len(IpnsPath)` instead of `6`.


My understanding of pagination was that as for all DB you have to specify position(ExclusiveStartKey) and offset(Limit). But maybe I misunderstand DDB doc.


I thought those were not really wanted. Ok, I reverted the PNG changes back (with the 3 buttons colors)


ok. thanks. fixed.


I'm using msgpack hpp headers from msgpack repository (as git submodule). It doesn't require building and linking anything, only `git submodule update —init` (would be nice to explain it in README, of course).


On Tue, 27 Jan 2015 00:50:46 -0800, Shlomi Fish
<notifications@github.com> wrote:

> @Tux: hi! Even if tcsh is actively maintained, I would not recommend
> newcomers to get used to it,  due to the problems and limitations of
> its scripting syntax. I've written a little about it here -
> http://www.shlomifish.org/open-source/anti/csh/ .

csh != tcsh

I do NOT use tcsh for scripting.  Neither tcsh nor csh are suited
for scripting. At all. Period. For scripting I use either perl or
sh (restricting to strict POSIX syntax - not bash).

The tcsh is however still the best interactive shell for me.

--
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.21   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/


@romanzolotarev glad to promote you! If you will find other Jade-related guidelines please let me know.


Sometime projects are so different in scale by their nature, you know:
- https://github.com/plentiful/clock/tree/master/app/client
- https://github.com/TelescopeJS/Telescope/tree/master/client/views


Final comment:

The good:
Candidate showed interest in the task and went beyond the scope of the tasks
Candidate didnt just copy-paste stuff from the internet and tried to dive into the language and problems

The bad:
Random order is not set for tests
Not all tests are cleaned before the tests. (sm_test_app_interns/spec/features/feedbacks_spec.rb:6
The repository is not cleaned of crap, and in fact, contains over 100mb of crap - thats more than the entire application and tests together
Code quality is sloppy and not clean.
Unnecessary features have been developed(unit and integration tests)

All in all, while candidate showed lots of interest and went out of scope, he did not complete all the actual given tasks and the code quality is low.


I'm a huge fan! Feel free to add me on skype: stp1stp2
I'd love to see more.


The main issue why I removed it is that it was in the section where
perlfaq3 suggests shells for people to use if they're ON WINDOWS:

"In addition to an editor/IDE you might be interested in a more powerful
shell environment for Win32. Your options include..."
http://perldoc.perl.org/perlfaq3.html#Is-there-an-IDE-or-Windows-Perl-Editor
?

I was no longer able to find an actively maintained tcsh version **for
windows** so I removed the section. I guess you might not be using tcsh on
Windows, but rather on openSUSE? Otherwise, if you can share a link, I'll
update the documentation to reflect this.
--
Michiel

On Tue, Jan 27, 2015 at 9:50 AM, Shlomi Fish <notifications@github.com>
wrote:

> @Tux <https://github.com/Tux>: hi! Even if tcsh is actively maintained, I
> would not recommend newcomers to get used to it, due to the problems and
> limitations of its scripting syntax. I've written a little about it here -
> http://www.shlomifish.org/open-source/anti/csh/ .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/perl-doc-cats/perlfaq/commit/7b69c2a571e47fe4126abbe33715ee30a6cde561#commitcomment-9454846>
> .
>


With this commit, we get unittest code coverage stats on [coveralls.io](https://coveralls.io/r/jonge-democraten/website?branch=master). I also added a link/batch to the readme, [![Coverage Status](https://coveralls.io/repos/jonge-democraten/website/badge.svg?branch=master)](https://coveralls.io/r/jonge-democraten/website?branch=master).

This is supposed to encourage unittesting.


How will the use of `.btn-link` help?


Quick question - do you do this by hand or do you have a script to do the version bumping?

Thanks
Michael


When I try this with a comment at bob it just returns `nil`


It's ok for me to split it into small pull requests.

Are you thinking about defining different size-types for the different cases? That is something like
```
typedef uint32_t list_size_t;
```
(this sounds too pedantic, in my opinion)?


did u found a higher value then 189?


nice


I know, I know. I want to find the cornerstone for all of them. Recently I created WordPress theme on Jade+Sass+Grunt and see I can use one architecture for both WP theme and static site.


It's on by default


Is there any reason not to change it so that it can be run periodically from cron? (I'd assume you'd check the bill isn't already present before trying to add it, and throw an exception if a sponsor can't be matched or a date can't be parsed.) I'm not sure how frequently the KenyaLaw pages are updated, so maybe that's not worth it?


'sea_surface_height_above_geoid' appears to be all zeros for the WW3 url


TeamCity xBIM :: Xbim BCF :: Xbim BCF [Build 8](http://ncl-xbim:8080/viewLog.html?buildId=754&buildTypeId=XBIM_XbimBcf_XbimBcf) is now running


 if (cat && spellInfo->CategoryRecoveryTime)

uint32 catRec = spellInfo->CategoryRecoveryTime;

u can replace if (cat && spellInfo->CategoryRecoveryTime) by if (cat &&  catRec)


TeamCity xBIM :: Xbim BCF :: Xbim BCF [Build 8](http://ncl-xbim:8080/viewLog.html?buildId=754&buildTypeId=XBIM_XbimBcf_XbimBcf) outcome was **SUCCESS**
Summary: Tests passed: 8 Build time: 00:00:40


Question: Isn't that quite an inconvenient name for a widget? We usually have things like `Widget::Table` so shouldn't this be something like `Widget::Filters` (not sure if that's the best name but you certainly get the direction).


Yep. Make sense for some cases. While experimenting with new apps I'd prefer to have that kind of flexibility.


Yes.........


note to self: measurement: for sensor value 7309 the optimal brightness seem to be 56%


It looks like recording stopped working because of this.


On Tue, 27 Jan 2015 01:00:33 -0800, Michiel Beijen
<notifications@github.com> wrote:

> The main issue why I removed it is that it was in the section where
> perlfaq3 suggests shells for people to use if they're ON WINDOWS:

You've got a point there, though I know that Corinna Vinschen is
actively maintaining tcsh on Cygwin (if that counts).

--
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.21   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/


Is it correct to use status 23 here? I thought that the final same-pdg-ID daughter of the status-23 particle has the correct kinematics, not the status-23 particle itself.


On Tue, 27 Jan 2015 01:00:33 -0800, Michiel Beijen
<notifications@github.com> wrote:

> I was no longer able to find an actively maintained tcsh version **for
> windows** so I removed the section. I guess you might not be using tcsh on
> Windows, but rather on openSUSE? Otherwise, if you can share a link, I'll
> update the documentation to reflect this.

OpenSUSE, HP-UX and AIX

--
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.21   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/


Golang does this and it's super annoying. Sometimes you need to comment out lines where a variable is used and in testing. I think you'll find that this is too strict and potentially turn off users.


Also, I thought this module was just about style. Now you're turning it in to much more. Leave this stuff up to jshint, which most users already use.


Mood tiers. Nice way to simplify config. :)


Are ServerConnectedEvent  and ServerDisconnectedEvent  not the right events? (2 methods up)


Clap along if you feel... ;)


plz add OMPI copyright


@yellowled Do we have an established method to generate the button here in the template but show it only when Javascript is activated?


Thanks for letting us know! I have fixed that - https://github.com/boxbilling/boxbilling/commit/5789d1b214cbe5bf6ef161d1087b6d7507ddd5f4


The setup application method is called from each platform class which ultimately presents the startScene at the end of the configuration. This pull request goes hand in hand with another branch on SpriteBuilder which modifies the project template to use this funcitonality.

I liked the approach that's done in CCAppDelegate for iOS, where there's a `configureCocosWithOptions:` method, and made that consistent across platforms.

The main change is separating platform stuff from cocos configuration - the AppDelegate deals with UIApplication lifecycle stuff and forwards events to cocos, whilst the controller here applies the configuration, sets the content scale factor etc (non platform specific operations)


Generally, `elements` should be deleted in destructor to avoid memory leak. The memory leak issue only happens when the redis reply is array of arrays.


I guess this will be the link to becoming rogue, right?


TeamCity Ylab :: synteny/ylab [Build 42](http://192.168.30.225:8111/viewLog.html?buildId=673&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


Nice doc! I started a draft but I was quite far from the reality. Thank you.


already fixed in this commit,
https://github.com/odoo/odoo/commit/25b1df2eb331275ab6bb5e572665492bbff15bdc
This should be closed.


The timer id is not stored/canceled on keepalive_free() -> in theory we can leave behind a timer callback with
stale keepalive pointer.

In practice the app will exit before that can cause problems, so feel free to ignore.


I would wait until cocos2d#1174 is merged - you guys have worked on that for a long time, and I think it'd be less effort to change this patch to reflect new api changes than to complicate the existing refactor efforts.


Not really sure if there should be space of both side of `,` even if it is a binary operator, but I am pretty sure there should be space after `class:`. Also, why indenting by two additional tabs, isn't one enough?


could you please have a macro or function to represent die(rc,format,args) and have:

- rc code, pritf like format with error, all finalize calls in it?


Should be https://github.com/fusor?


getHash and the linear probing portion of findNextEmpty seemed a little too short and easy...maybe it's just late.  Mind double-checking it for me?


Nice, sorting feels a lot cleaner now.

"signOf" feels a bit weird to me though.  As it has three outcomes, rather than two I would anticipate.

Perhaps just a name change, it feels like a compareToZero?

```Java
private static int compareToZero(int value) {
	return Integer.valueOf(value).compareTo(0)
}
```


here, too, I would put space after `demotext:`


What are these two files about?


extract into method getClientId()?


I think this is a sticking issue, I know viktor accepted a pull request changing several "cc" files to "CC" - I'm going to create an issue to address this.


"COMMAND [ARGUMENTS...]" looks like an template/example. Should it be "keepalive-tool [ARGUMENTS...]" ?


We cannot afford having that much responsibility on one line.


@onli Assuming that “don't show it if JS is **not** activated” suffices as well, add a new line `.no-js #updateAll,` after https://github.com/s9y/Serendipity/blob/master/templates/2k11/admin/style.css#L2336


small typo `hanlde`


Or leave the dungeon?


It is working fine for me, please test it. there are some things missing:

 1. I'd like to add an activity indicator to that progress bar, maybe even something less plain than the standard, something like one of http://padolsey.net/p/Sonic/repo/demo/demo.html
 1. If someone (@yellowled?) knows a nice looking alternative to the stadnard progress bar, we could use that instead
 1. While the update is running, we should print out which plugin he just updated/is currently updating
 1. After the update, it would be possible to go to the plugin page and show an success message there, if that is preferred. I think so.
 1.  An error message is missing in case of a failure - note that we probably need to modify the core to send a fitting status header when an update fails, so the ajax call can notice the error.
 1. i18n


You're right, but filename is file identifier. So, actually when we pass filename to FileCyclist - it's quite logical to try finding file by this identifier. For example of similar logic, Ruby class File receives filename in ::new method.

Hey, why Cyclist is abstraction? It handles all logic, except of getting enumerator. :) Actually, initially we had two implementations for those, but later it turned out that it can be refactored this way.


Yes, sure I meant that ;) Thanks


And? Is it that bad if two users have the same recovery code? IMHO more secure codes are better. Even when we agree that we need to avoid duplicated codes it would be better to simply check the generated ones against the existing ones instead of rely on something like the uid which never changes.
@Stefan-St @Destroy666x


In fact,  I can't. These method doesn't exist for  `goog.net.XmlHttp` and I can't made a synchronous request with ` goog.net.XhrIo `


abe pagal


@endJunction  Updated.


f.close() is not required here. Context manager will call close() automatically.
That's the whole beauty of 'with ... as ...'.


https://github.com/TrinityCore/TrinityCore/blob/6.x/src/server/game/Entities/Object/Updates/UpdateFields.h#L248

```PLAYER_EXPLORED_ZONES_1 = UNIT_END + 0x81C, // Size: 200, Flags: PRIVATE```


Pay attention, there're further changes to apply...
Did you test it?


this is not necessary


Ahem, there are other browsers than UCSC, and other applications that browsing...


Could you explain how it all works? From my point of view, you replaced magic numbers with more magic numbers, and this function seems to have lost its genericity.


@nilshoerrmann good point, I kept the name which was in the original function, didn't give it too much thought but you are right. I'm also not sure about the variable name`$inputArray` maybe there is already something similar which I can use for consistency.


ngfhgh,hk kjhjh


I'm not too fond of programs that do not provide any usage info (to *stdout*) with "-h"... so pretty please add "help"/'h' handler. Or perhaps using g_option_context_set_help_enabled() in main() would give the same end result?


xD


Sorry for the stdio import left behind.


You may want to use a `set()` (maybe even a `frozenset()`) here.


updated german translation - added *columns*


We should set the default value of rule's matcher to configured matcher rather than do null check here.


I think there is no way to do it with Mockito. You should try PowerMock in this case.


TeamCity Ylab :: synteny/ylab [Build 42](http://192.168.30.225:8111/viewLog.html?buildId=673&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 131 Build time: 00:14:42


Para la correcta ejecución del servidor, es necesario añadir al .bashrc las líneas incluidas en .../src/txt/bashrc (solo para GNU/Linux, próximamente publicaré las líneas necesarias para MS Windows)


I removed an "override" keyword and it's messed up the alignment


@martint Thanks for your help. I got some misunderstanding. An updated version is at:
https://github.com/facebook/presto/pull/2085


I nice, I had added my own spinner in my fork but I did it in a lame way.


yep. I've tried to set up things so that we are ready when how to become rogue will be decided


Since the help is bound to be rather short, it does not really matter - so feel free to ignore etc, but ...

IMO "<describe error> (use --help for usage info)" would be preferable over "<full length help><describe error>".


+1 Thanks. Working for debian 7.8, Ruby 1.9.3p194


or `lynx -nolist -dump '%url%' | uniq` ;)


lol. I've just seen it is a copy/pasted typo in every handleXXX ^^


Medium: add javadoc (ctrl+shift+J in eclipse i think)


@singingwolfboy, we are removing:

1) Non-breaking space characters because they're added to the content by html editor, when a user editing the content in studio adds multiple spaces in a row. We do not wish for it to be searchable as a content.

2) CDATA because it's used in Zooming Image html editor to protect JavaScript code that provides the zooming functionality. Once the html tags are removed, CDATA is left as a content of the <script> tag, but since it's not the viewable content to LMS users, it should be removed as well.

3) HTML comments because an advanced user can edit the raw HTML of the module in the studio view and therefore will be able to write the comments which we don't wish to be indexed as well, since they aren't the part of the viewable content to LMS users.


This will be inserted for the the arguments after the tool name and the options:

```
[nemo@Jolla ~]$ ./keepalive-tool
Usage:
  keepalive-tool [OPTION...] COMMAND [ARGUMENTS...]

Enable CPU keepalive during runtime of child process

Help Options:
  -h, --help                Show help options

Application Options:
  -t, --timeout=SECONDS     Maximum time to keep the CPU alive

https://github.com/nemomobile/nemo-keepalive
```


Right, makes sense. I *think* most ppl who will use ldap will also use it to store groups/profiles (and thus will want to import them from it), but i might be wrong. Now that i know it, i'll remember to turn it on when deploying my configs :)


Medium: mark items as final because is mandatory for object construction.


Do we need the local variables instead of directly using the parameter object?


That's done automatically, `-h` / `--help` works already, `g_option_context_set_help_enabled()` can be used to disable this, but by default it's enabled.


When it is furious, it starts to leave the dungeon from the beginning. It will become rogue if it fails to leave the dungeon


Low: I prefer to throw an exception.


so this package is no more Plone4 compatible? I thought Plone 4.3.4 is jQuery 1.9+ compatible ...


this line leads to

"Whateverdirectory/lol.exe/lol.eversion"


\cc @borisdiakur


Fixed, now only shows the error message: `Error: No command specified. Use -h/--help for help.`


isset return true/false, which is always different from '' (empty string)


The above change seems to throw a NPE in Xcode 5.1.1 (iOS 7). The line object returned by page.objectForKey("WIRTypeKey") is null in Xcode 5.1.1.


Nice!


Medium: mark this as final.


TeamCity xBIM :: Xbim Geometry :: Release [Build 20](http://ncl-xbim:8080/viewLog.html?buildId=759&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:18:43


This is ok, just a comment: I would use a Like entity with PhotoId, UserId and Timestamp.


Medium: add javadoc instead comments.


Medium: mark it as private.


Actually it's not I flashed clean today and it's not there...

On Tue Jan 27 2015 at 2:07:45 AM Sean Hoyt <notifications@github.com> wrote:

> It's on by default
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LiquidSmooth/android_packages_apps_Settings/commit/c5884a537e75bba01d12e11b4c8d3a38e03f2d43#commitcomment-9455102>
> .
>


All this just in an effort to make fireShotAt a method of the ship module...


Low: remove this method.


@hannes14
encapsulate manipulations above in a function?


TeamCity xBIM :: Xbim Geometry :: Release [Build 21](http://ncl-xbim:8080/viewLog.html?buildId=761&buildTypeId=XBIM_XbimGeometry_Release) is now running


It would be useful to explain why.


Note: this is ok because you are testing the UserServiceImpl itself, but you are not testing the proxy.


```
<td>
<form name="form" method="post" action="/remove.php?id=<?php echo $margin[0]; ?>">
<input type="hidden" name="_method" value="DELETE">
<button type="submit" id="form_submit" name="form[submit]" class="btn btn-danger">Delete</button></form>
</td>
```


Low: remove this.


merge


I'm sure it's fine


You can also set in the @Test annotation that you expect an exception to be thrown by doing:

@Test(expected=ElasticsearchIllegalArgumentException.class)

Not a big deal but it can make the code look a bit cleaner


Definitely your  implementation is nicer :D
About the name I think we could call it signum. It should behave likke Math.signum (but this for int, not for double):

http://docs.oracle.com/javase/7/docs/api/java/lang/Math.html#signum(double)

It is also called sign function:

http://en.wikipedia.org/wiki/Sign_function

Maybe I could rename it signumFunction and definitely add a Javadoc for this one. Would that work?


Low: remove it.


oh lol and i was runnin on retail evry zone and sniffed to get the highest updatefield number lol....


LGTM


Will this work in databases other than MySQL?


simple changes - look good to me!


Hi, why did you change this? despite that it is different for you ;)
best place would be /opt/t-bone/?!

honestly this prevents for me merging your useful pull request …


1: M111 unrecognized component name: authorids


Shouldn't such feature be commited on a dedicated JIRA issue for a cleaner history and easier maintenance?


So sollte es funktionieren. Kannst du auf deinem Arch kompilieren?


Isn't it better to explicitly check if node != self->first and only then do lines 205 and 206?


what's that ?


Ah, the for the new 120 turns value I suppose. I guess we won't see that happen often for now.
Btw, I would almost double the payday turn value, taken from a few games experience.
And once the rogue behaviour is implemented, I would divide the become rogue value by 5, to make this more likely to happen when you're not immediately taking care of creatures that are far away from their home. (This can be discussed afterward, but at least you know my preliminary point of view about it. ;])

Something like:
```
TimePayDay 300
NbTurnsFuriousMax 25
```


For the record, it would be nice if you could split cleanup changes (e.g., removing the propagate flag) and functional changes (e.g., the simplify_scc usage) into separate commits.


Indeed!


That happened at least once to every people doing code I know. ;)


Do these sensu monitoring thresholds align with Varnish's thresholds ?


maybe related:

Fixed in 7.35.0 - January 29 2014

   - conncache: fix possible dereference of null pointer
   - multi.c: fix possible dereference of null pointer

2015-01-28 2:48 GMT+08:00 Memphiz <notifications@github.com>:

> arnova i think it has to do with the libcurl bump in depends - at leat
> that is what @mkortstiege <https://github.com/mkortstiege> suggests in
> that forum thread
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xbmc/xbmc/commit/a626b9e8cc4bb9fa780f5928fc14955ae98d6af0#commitcomment-9465142>
> .
>


Ack


@jczhang @drayson92 @kaiminchang @summyfeb12 let me know if you guys are good with this license. I heard it was the hippest.


This clashes with @Sayantan2048's [GPU mask topic branch](https://github.com/magnumripper/JohnTheRipper/tree/gpu_mask2k15). Please refrain from committing things like this to core right now.


No worries mate.  It's a common thing for people to blame the toolchains.
But how do you know your "fix" is not the cause of no boot unless you try
reverting it?

On Tue, Jan 27, 2015, 4:59 PM Ícaro Hoff <notifications@github.com> wrote:

> @pbeeler <https://github.com/pbeeler> Sorry, I didnt want to say it was a
> problem with SM, and of cource it is not. Ill jump into 4.8 if I this last
> fails again. Thanks pbeeler, appreciate your help. I had already pushed the
> commit that fix the warnings.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SaberSunset/kernel_lge_msm8974/commit/4dc90dc5eed7ba02b23e5fb32405ec426afd2f4d#commitcomment-9470158>
> .
>


Sure. But we'd have to add that dependency to the package (which doesn't matter anyway since Meteor requires it for now).


Soon : https://github.com/atom-community/autocomplete-plus/issues/205


So where should I put more DI tests now?


Appears to have caused #899.


The problem with this is that it's then hard to test by comparing with PROJ.4.  The general idea behind Proj4J is to track PROJ.4 as closely as possible.


In any case, this needs unit tests...


Your can have multiple @Test methods in one class...


`const` qualifiers on parameters passed by value do not contribute to the function signature and do not affect callers, therefore they should be omitted in declarations.


Why are all these parameters passed by value marked `const`?


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1984](http://teamcity.monogame.net/viewLog.html?buildId=5113&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Commited, no boot, reverted it, builg again... Now I cloned all CM repos that I modified to make it "stock" CM and use the trick that points eabi-4.9 as 4.8 folder for now.


I can't seem to find a way to test to see if the socket has been
disconnected except via a read of the stream.  So for now, the test for
null after the read is best.
I'll push the code soon.

On Tue, Jan 27, 2015 at 2:22 PM, Paul Norman <pinorman412@gmail.com> wrote:

> OK.
> Ran into a problem last night that I have yet to solve.  Knowing when the
> net drops, is not that easy. At least from the server when the client is
> done. At the moment the read fails with a EOF error and I see the stack
> trace every time, and the read method returns null. So if I test the read
> for null I can make it work. Not the best.
>
> I looked at a  bunch of methods on serversocket and socket and haven't
> found one that I can use to know if the socket has been disconnected , so I
> can then wait on another accept. I'm not at home; over getting a hair cut.
> On Jan 27, 2015 12:49 PM, "Brian Norman" <notifications@github.com> wrote:
>
>> e.printStackTree(); should change to log.warn("", e);.
>>
>> All the printStackTree does is print it to stderr with println's. It's
>> almost the same as System.err.println(ex.toString());. You want all of
>> that to go through Logback so you have it in whatever it logs it to.
>> Whether that be the console, log file, or both. Just think of the
>> difference between stdout and stderr as the difference in levels.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/pinorman/wx-mon/commit/2a93438bdc6676646fa17130fbac792b8326edcb#commitcomment-9465157>
>> .
>>
>


It's baked into the interface.  See the setup() function.  I agree that it should not be.


But when you have multiple aspects of tests dividing them into classes is important too, @Before is class global and also test class should be coherent itself.


Isn't delegating stream in the `Mvc.Core` project? Tests should be in the same spot relative to the product code.


You mean, the 'min'?  Yes, it is intended.


Can probably use InsertOrUpdate or one of the other macros from `misc/map-util.h` here. They generally offer a nicer API than working with the pairs that STL structure require.


Do we really want this panel displayed for all users?


Looks fine to me!


Yeah planning on sending it upstream but I'm mainly just hoping to start a conversation to gauge whether they will actually considering doing it.


This causes exception, you need to append direction, not Move(direction)


this should be called `--env`, it makes more sense.


Python:  Check Current Battery Cycles on Mac Computers


Same


No---convergence is geometric.


No code be in `Microsoft.AspNet.Mvc.Core` - the only thing that's in that namespace now is the resources, and that's not on purpose :laughing:


Overkill in this case, because finish() is a destructor and delete_it is only used there.


follow the product code


I would think that if you needed more than one test class per class, you should refactor the original class.

TBH, I don't think that this will become a major issue, and almost every other major project does it this way. If they don't have problems, I don't forsee we will.


your version of the name?


The vector itself.  finish() is the destructor for setup().


ship it


How does defining `var TIMEOUT = ANIMATION_DURATION / 2;` sound?


run can be removed, there's nothing to run here.


All of these should be `Test` according to our guidelines. https://github.com/aspnet/Home/wiki/Engineering-guidelines#unit-test-class-naming


I wonder if it's easier to instead represent this using a `TaskDescriptor` (as used in the rest of Firmament) and then call `GenerateTaskID()` to get the `uint64_t` Task ID (see https://github.com/ms705/firmament/blob/master/src/misc/utils.cc#L94; maybe add another override for `GenerateTaskID()`). Seems like this is implementing things in a very similar way.


We avoid adding auto-generated files to the repo due to the full-file-diffs-on-every-commit problem they often cause. I think I have this specific file under .gitignore.


`plugin.defaultEnv = '*'`?


why? it is there work i've just ported it from my kitkat rom and made the necessary code adjustments for lp!


If you're adding a project, it should go in `Mvc.sln` and `Mvc.nofun.sln` - the latter is the one that doesn't have the functional tests included.


It's the same method name (which can be changed also) so I rely on the existing unit tests.  But I did write more extensive unit tests in my Elasticsearch enhancement that I can migrate to Proj4J for further review.

I also don't have a problem proposing the C++ version to Proj4. I originally wrote it in C++ so it would just be a matter of integrating in the Proj4 code base.

// sent from my mobile device, please excuse the brevity and typos

> On Jan 27, 2015, at 6:04 PM, Martin Davis <notifications@github.com> wrote:
>
> In any case, this needs unit tests...
>
> —
> Reply to this email directly or view it on GitHub.
>


r+


`testing`, `testing_utils`, `testing_tools`, `testlib`, `utilitest`?

r+


Nice work:

it looks like most of the issues was from laravel/app/controllers/AdminController.php
And the now super sexy laravel/public/scripts/notify.js
Abstracting the site details to sitesettings is a great idea

Lol we need to add that gitignore file for the logs but thats okay.


A couple of trials before the successful one shows great persistence! That will be handy when you start debugging later in the course.


Hey I don't have any compile errors?  I was originally building this kernel standalone but am not building it along with my rom.


Copyright is present and means it is made by slimrom team


@rdlowrey, I just copied your `CONTRIBUTING.md`. :-P


BSD or MIT or CC BY works for me.


Granted.  I will endeavor to replace my naming conventions


saw approval from mbrubeck
at https://github.com/servo/servo/commit/95fc29fa0db21959df99d81cdbb9561226321d2f


merging servo/servo/rustup_20150109 = 95fc29fa into auto


servo/servo/rustup_20150109 = 95fc29fa merged ok, testing candidate = 50f433fe


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1984](http://teamcity.monogame.net/viewLog.html?buildId=5113&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 366, ignored: 6 Build time: 00:16:04


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1985](http://teamcity.monogame.net/viewLog.html?buildId=5115&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Like i said a few years ago i asked you about if i could use this. cant help it if you dont remember.
But repo removed.. hope your happy


"The const qualified should be used to enforce the principle of least privilege, telling the compiler that the function does not modify variable side". I think its a good practice but I can remove it.


I got an error that this.options.ttl is undefined..


Ref: #1


TeamCity Ppconsul :: Build (Linux) [Build 67](https://78.46.71.115/viewLog.html?buildId=413&buildTypeId=Ppconsul_BuildLinux&guest=1) is now running


This shouldn't be back yet, bawk bawk.


We don't have such method.


Lets postpone the decision on whether to include them in definitions and address whether they should be included in declarations - what is the rationale for putting the `const` qualifier in declarations for parameters passed by value?


TeamCity Ppconsul :: Build (Linux) [Build 67](https://78.46.71.115/viewLog.html?buildId=413&buildTypeId=Ppconsul_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 97 Build time: 00:01:15


TeamCity xBIM :: XbimExchange :: Build [Build 59](http://ncl-xbim:8080/viewLog.html?buildId=775&buildTypeId=XBIM_XbimExchange_Build) is now running


(thanks god)


Hi,

After composer update without minimum-stability dev, the Predis\Client will be removed which is required in Illuminate/Redis/Database.php.

Just for information on everyone who use Redis.

Thanks.


TeamCity xBIM :: XbimExchange :: Build [Build 59](http://ncl-xbim:8080/viewLog.html?buildId=775&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:24


Should be fixed. You'll get these if the socket times out, but it was set to 10 seconds (now 120secs).


@cristianomatos @crdroid .............

Please @FusionSP can you maintain the original authorship http://review.cyanogenmod.org/#/c/86325/


@miguelportilla See http://i.imgur.com/DW9aPaP.png


So that's a plugin author saying their optimizer should run by default. Might be confusing to users trying to control it with `config.optimize`. Should we allow it?


Eventually we will be able to change the structs to allow for extra game features. Then we will need to be able to convert TD4 and TD6 to the new structure, so probably a function for TD4 and another for TD6. Any shared reading logic can be separated into functions that is shared between TD4 and TD6 reading.


@ulion @arnova its more complicated - see https://github.com/xbmc/xbmc/pull/6287


Ref #1


멀티 플레이 image 보임
PHP 관리 폴더 만들어 놓음


Awesome!


On mako you have to change CONFIG_SLAB= y and # CONFIG_SLUB is not set to get boot.

https://github.com/SaberSunset/kernel_lge_msm8974/blob/bb982e1ad7a3630519412e1d6e6d8f0722cb34aa/arch/arm/configs/veneno_d802_defconfig#L162

I don't know if that would work with this kernel or not.


Yes i know, i also use git gui and sometimes after cherrypick when pick goes bad it does not maintain the correct authorship after correcting the cherry-pick fails. change-id and and commit info are always
present. next time i will credit the original author.


I think your missing the point @FusionSP. If you asked or didn't ask to use something is not in question. Did you retain proper authorship?? This is open source, technically you don't have to ask, but you do have to keep the original author.


Thanks! Worked like a charm. The include works just like ruby. Dont know why I thought that would work before...


OK but this isn't hard just cherry pick it either you are signing it with a proper change-id


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1985](http://teamcity.monogame.net/viewLog.html?buildId=5115&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 368, ignored: 6 Build time: 00:17:03


Good question re: `return` vs. `break`. In this case it would work either way, and there's not much of a reason that I can see for preferring one over the other. `return` is just a bit more explicit about "this method ends here."


You're also right that this loop could be written with the "guessing" conditional written in the loop definition, like this:

```ruby
while guess != num_to_guess
# ...
end
```

Or, even more idiomatically, you could use `until`:

```ruby
until guess == num_to_guess
# ...
end
```


Looks good!


Hmmm, without Router.configure, how to support like 'Page not found'

 notFoundTemplate: 'appNotFound',


Do the existing tests cover this function?  (Quite possibly not... but then it would be good to have some tests added)

You'd have to check with PROJ4 to see about getting a patch accepted there.

Failing this, what about just adding this as an alternative method?


I think in this case `downto` is the preferable option since the song is all about counting down. Make use of semantic Ruby whenever possible.


HVACSizingSim_CoincidentPlant (EnergyArchmage) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.84%25-red.svg)


Sorry if I keep forgetting underscores aren't all the rage.


Remove the current beta apk from the google store and the next commit had best be the removal of all images that you are not authorized to use.


A good way to identify how to remove repetition is to think of the two units (in this case, strings) as two sides of a "spot the differences between these two pictures" game. Then, you take the things that are different and *parameterize* them - make them variables.

In this case, the differences are the number and the word "bottle(s)". If you moved these pieces of the string into their own variables, or even into helper methods, you could avoid the repetition.

For example, here's one way you could implement a `pluralize()` method:

```ruby
def pluralize(word, number)
  if number != 1
    return word + 's'
  end
  word
end
```


Is there a specific reason for not using the most up-to-date version of the file?


LOL


Good additional tests, although I think what the comment is suggesting is that if a _specific_ even number appears N times, it should also appear N times in the result, i.e.

```ruby
p find_even([2, 2, 4, 7, 4, 9]) == [2, 2, 4, 4]
```


This comment can go away?


Looks great! In the case of `find_even()`, you can take advantage of Ruby's [`Enumerable#select`](http://www.ruby-doc.org/core-2.2.0/Enumerable.html#method-i-select) method. The `Enumerable` module is included in the `Array` class, which means that all arrays have access to these methods.


understood, repo removed. but i think there are many sources then that need to be looked at
not mentioning which. find out for yourselves. feel like under attack now. there are also other devs that
change my authorship to. (Like MazDa)
ive stopped compainig about it years ago and just enjoy programming now. instead of bitching about
this kind of things.

Dont mean that you do Mr. TheBroken.


thx @mehulkar  :smile_cat:


yeah, the concept you need to keep in mind is that this is all compiling to a static file. this can be confusing when you feel like you're using a server-side language like node.

the `include` function that jade gives you and jade's layout engine is great for code organization but you need to wrap your client-side JS in a `<script>` or through `<link>` for once your jade is compiled into to an .html file.


GasHumidifier (kbenne) - x86_64-MacOS-10.9-clang: OK (1577 of 1584 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.56%25-yellow.svg)


OK, I got the answer from one example of iron:router

Router.plugin('dataNotFound', {notFoundTemplate: 'DataNotFound'});

Is that right?


What kind of function?


Humans have name, address, contact info etc


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/599


*submod


My rewrite of FW is now functional and I think complete as far as Kerkerkruip is concerned! Do let me know if you find any problems. As usually you'll need the updated extensions from the i7/extensions repo.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2067 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.38%25-yellow.svg)


What you do isn't programming, is copy and paste @FusionSP

AND you removed the repos to hide and keep the bullshit going JUST like you did the last time I called you on it! BUT let me guess........you don't understand english very good or what excuse are you going to use this time to keep luring donations on XDA?

Oh and the reason you feel like you're under attack is because you are! You're stealing the work of many and passing it off on XDA as yours then asking for donations.

You best believe I will keep on pressing until something is done about you. You're a piece of shit.........nothing more, nothing less


Nice! Looking good, Ric. I like the improvements. A couple of suggestions:

Identify patterns in your code where you can apply **naming conventions**. For example, you have a method called `write_file`, which writes a file, and a method called `template_string`, which reads a file. Even though these two methods are closely related in their functionality, you can indicate that relation by assigning them similar names.

Also, it looks like you have some stranded code on line 24.


I think the Wiki button should be named as "Learn" instead of "Wiki". All the navbar buttons of Scratch's Website are named after verbs, it makes sense to follow it's pattern.


Fixed


Ok, I will add it to `libsquash`


Same here - I will comment on the pr when both pieces of functionality have been added


Uh oh


You can remove this as we havent enabled anything new


you can add this list:

https://github.com/01org/ozone-wayland/issues?q=milestone%3ACarnival+is%3Aclosed


You are searching for name while your properties are called "text" and "title".


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg)


Drag & Drop is not supported.


Yes, alias method on initialize is ugly... a better way might require getting a patch accepted into Resque proper.  But barring that, I'm gonna use yours.  :)


looks good - must have just been lurking "accumulated" differences not detected previously.


Appears to be a 4.2 perf regression: https://github.com/rails/rails/pull/15187


@SolarLune Could you change the name to ```Random.vector``` too? I don't know if you read my [edit](https://github.com/GoranM/bdx/issues/105#issuecomment-71747677).


Thanks, this is definitely a glaring hole. python-fedex predates the pip  era by quite a bit, so these instructions are all around a bit dated.

If you wouldn't mind changing the pip install call to point at PyPi, I'd be glad to merge:

```python
pip install fedex
```


The tests do cover this function but probably not to the extent that they should. I have some randomized tests that help. I'll work on merging them.

Adding this as an alternative while a Proj4 patch is evaluated is a good idea.


we might want to add some level of cache in the images task as this will [re]process all files when there are any changes


Is this diff log supposed to be here?


https://www.npmjs.com/package/gulp-cached

but I think there might be a gulp core or gulp-util solution to this now


Thanks for the pointer to the usage of "extra".

Maybe we should call it "secret key", as in the original Ed25519 paper (section "EdDSA keys and signatures", page 6 of http://ed25519.cr.yp.to/ed25519-20110926.pdf). expandPrivateKey can be renamed to expandSecretKey or, if we want to be clearer, getSigningKeyMaterialFromSecretKey. The first part of the signing key material is the private scalar, and the second part is the key used to generate the deterministic nonce.


Im hiding the repos from your bullshit messages.. how old are you dude really, get a life..
also maybe learn to communicate like an adult.

Cheers mate
and happy hunting


agreed, lets add it to enhancements


I used this format file to make a few pull requests. Sometimes, I noticed that you had to tidy up the code after merging the requests, which could be caused by the missmatched code format in this file and in Scalad that you are using.

It could be worth taking a look at that.


Why not `"laravel/framework": "~5.0"` with `"prefer-stable": true,` instead.


Hey, [click this link](http://www.google.co.id/)


I added an example in https://github.com/chapel-lang/sphinxcontrib-chapeldomain/pull/6


Yep. I added a note about that in #6. Thanks!


Yeah, I have a couple of additional visual test failures on my 2.3.x OSX build, but Travis seems fine with them.

If this commit doesn't fix it I'll ask you nicely to run it on your reference system and check :)


r+


Yeah, that's not happy either. https://travis-ci.org/mapnik/mapnik/jobs/48568441


Damn git


Well, one was fixed, the other one got worse.


I got the first one to work - the second question comes up NaN, and I think it may have something to do with my math algorithms...

I think I tried, if (item == average ) and that was unsuccessful...

The third one I feel like I'm leaving something out -  I did "type" is the var and then "earthquake" so I figured it would have struck that from the list....like the names we did in class?


saw approval from jdm
at https://github.com/servo/servo/commit/7fec73a432bcc2148b8866051ecb11be8d311fe3


merging servo/servo/rustup_20150109 = 7fec73a4 into auto


servo/servo/rustup_20150109 = 7fec73a4 merged ok, testing candidate = 3f901286


LGTM


we can use from the icons in this package which we're already using http://fortawesome.github.io/Font-Awesome/icons/


Are you going to be changing more of the `.joins` internals? (I've got a PR #15461 touching some the related code)


Cambié el senderId porque sino con mi API KEY, obtenía el error: "Mismatch..."


Esto no funca, tengo que verlo.


Cambié por mi IP.


Wasn't sure if you were on pypi, np


DateNot Found is not "Not Found" , they are two different concepts.

The Template is found, but the data is not found, then it is "DataNotFound'


We're going to have to revert this because calls to super outside the constructor have been dropped from ES6.


did this work?


Your're right, but how to handle that 'Page not found' case?


I send another pull request to you. I changed in your code and fix that issue


EMR/hadoop defaults to 2.6


9.6? About time. XD


shouldn't it be DYLD_LIBRARY_PATH for OS X? also it's .bash_profile on my machine


I am curious @guidotag what was the issue with this method that it was changed?


oh! added !


hahaha you mean the "bullshit messages" that show that you're indeed a kanging piece of shit that uses other people's work to lure donations on XDA? If so, yeah........they're "bullshit messages".

BUT please, keep on denying it because at this point you're fooling anyone. I already said what I have to say and people saw the kangs. Whether or not you restore the repos doesn't really matter because sooner or later, you will kang again because is in your nature.......is who you are! You guys are all the same. Whether is a paypal scam or stealing people's work, you can't help yourself


just reutrn this.


I just went with what worked for me on my Linux and OS X machines. Please
correct for more widespread compatibility.
On Tue, Jan 27, 2015 at 8:22 PM Sergey Zagoruyko <notifications@github.com>
wrote:

> shouldn't it be DYLD_LIBRARY_PATH for OS X? also it's .bash_profile on my
> machine
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/torch/distro/commit/427e121fad6dc708e2c1425e8515a07ffc67b65e#commitcomment-9470991>
> .
>


Did you get caught kanging or something? Why would you remove it? hahaha


i think it would be simpler to just parse out an identifier (since both branches start with that).  Then just check if you have 'as' or not as the next token.  If not, then you have the first branch, if so, you have the second.  No lookahead required.


because the `predicate` might be null, so we can't pass `predicate` directly to `AndAlso` method. I don't think it would be intuitive like this:

```
selectExpression.Predicate
    = selectExpression.Predicate == null
        ? predicate
        : (predicate == null
            ? selectExpression.Predicate
            :  Expression.AndAlso(selectExpression.Predicate, predicate));
```


Out of context, google translate does not know what "Complimentary" means, so I think it should be fed with "Click to select your complimentary item" and get "Cliquez pour sélectionner votre article gratuit". In French (most of time) the adjective goes AFTER the noun it modifies so you will need to indicate complimentary something (such as an item (article))


"Is my translations"?  Ouch!  How about: claimCredit, takeCredit, assignCreditToUploader, assignTranslationCredit or similar?


Hi, Duanwei .
really I don't know, I realized that my link was different when evaluating other students. I just copy the URL that appeared in the window github, after making commit and push and a big number appeared instad the word "Master" . But you also have similar URL, look: https://github.com/sirius27/datasciencecoursera/blob/692189895165ca8161569c55c76178115d8d458d/HelloWorld.md.  This is yours, :).


@shdwjk It was your typo. =P


What is it mean???


happy to run after the fact, just let me know


I went back and forth on this and I can't quite remember if I really had a reason for going the way I did, but in retrospect I definitely agree with you -- I'll add `(D)CHECK`s for out-of-range indices and only return the correct dim for in-range axis indices.


close #36


close #37


hpwh_residential (nmerket) - x86_64-MacOS-10.9-clang: OK (1586 of 1589 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.81%25-yellow.svg)


Does this "stay loaded", or does this re-require every time its executed?  If the latter then it's best to have the load at start rather than every time SourceTree is invoked, no?


Cool. thanks a lot. I will try in my pikpak.


Yeah, no idea what I was thinking... should always return 0.  Thanks for the catch.


Also FYI I've just changed this code to use `spawn` rather than `exec` to bypass shell escaping and allow paths with spaces and such.  I've already committed, pushed and published.


Vann- og lavabøtter er lov på HW: http://www.minecraft.no/forum/index.php?/topic/23273-vann-og-lava-pa-hardwork/


Agreed, will comment and add bound `(D)CHECK`ing as below.


Try it first, I have not got a chance to try, but it should work.


Good call on listing the command as well as the bindings!


Comment should be `// Let's` with leading space and capitalization for a sentence or fragments.


How is this aosp copyright?  Trolling?


I'm pretty sure about DYLD_LIBRARY_PATH, but not confident about bash profile.
also on OS X neither nvcc nor nvidia-smi might be in PATH, it will not however stop cmake in finding CUDA and installing cutorch, cunn, etc.


Same with these comments.


Stacktrace for dette re pga. pistons. Spigot kjører PistonExtendEvent for hver blokk en sticky piston retracter: https://hub.spigotmc.org/jira/browse/SPIGOT-117


spaces after the parens here


SolarShading_TooManyFigures_fix (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1095 of 1095 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.89%25-green.svg)


Spaces around args on this line and the next. Understandable since the file currently has a mix of styles, but let's be consistent within new code and definitely within a single test!


```
# タイムテーブル {#timetable}
```

と、するとmorkdownで見出しにIDが張れるらしいよ。


On second thought i'd just start with `// Try` .


Why `== null` here? Seems like it should be `=== undefined`.


This function definition (not the execution) 8ms with apply in Firefox with call, but only 0.03ms with call.  Uncompiled is 0.03ms both ways, compilation creates a 200x slowdown.  Replacing the uncompiled code with the compiled code does not change the speed.  Makes no sense.


Professor Wills,

Hello, I was just wondering if it is just me but I do not see lesson 3 or discussion 3 for this week.

-Mario


It mean that checkpoint is used to sync data between fault severs

Regards
Minh Giang
On Jan 28, 2015 8:32 AM, "Hoang Le" <notifications@github.com> wrote:

> What is it mean???
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenClovis/SAFplus-Availability-Scalability-Platform/commit/b12917519db9c7db32b4cd6fe41a9cb307099de2#commitcomment-9471083>
> .
>


I think the comparison is the other way around, shouldn't it be this way?:
 if region.Address+uintptr(region.Size) < startAddress


You will need a closing parentheses.


I haven't tested the things I wanted to. This is just something I discovered along the way.


If you can run the visual tests on your 2.3.x branch and get the same results as travis, (and then update the reference images) that would be good. :) Those two failures pass on mine, but I could easily have different cairo/libs/whatever.


You can not have this alone.


(Normally next to this readme) ?


YOLO


You cannot use switch for strings.


I assume this must be web accessible or can it be `/../somewhere/else`


ddd


all tests pass:
success: http://build.servo.org/builders/linux1/builds/601
success: http://build.servo.org/builders/linux2/builds/600
success: http://build.servo.org/builders/android/builds/636
success: http://build.servo.org/builders/mac1/builds/817
success: http://build.servo.org/builders/mac2/builds/817


Yay this is awesome :)


testtesttest


here has an extra parenthesis ? : )


When git merges with `master`, it just adds a line after `Pathset: Pathset`. Unfortunately, since this is within an object literal, there needs to be a comma after `Pathset: Pathset`, otherwise it'll be a suntax error. I commit a fix for this, but just FYI.


fast-forwarding master to auto = 3f901286


I'm curious to know the reason for this API change. Especially on a minor version bump. We were relying on this endpoint for https://github.com/dockyard/qunit-notifications


okay Sir.... I will revise it... today I am working on prototype of scheduler..


Commit comment should include why it's being reverted?


Good point. I will cache the results though to prevent the constant polling, as with the auto hammer


We can't add CSS directly to the styles.css file. All CSS comes from compiling LESS files, so adding changes directly to the CSS will make them out of sync.


Okay Sir....


Visually this looks great. So excited!

But, architecturally this is funky in that we're kinda relying on the fact that some objects dont have this property so this branch doesn't fire. I rather think thats not so good for performance...

Fundamentally, isTopLevel is not a property on all slices, or async slices. Its just a property on async slices, and even then, its not an official property --- that is, the track adds that property in, but the class itself doesn't define that its there.

The simplest fix is to do this branch only do this when the async variable passed into this function is true, and make AsyncSlice constructor actually have a this.isTopLevel = false line in it.

The better fix might be to have both slices and async slices have an isTopLevel property set in their constructors. And, teaching the regular slice group track to set toplevel too. Might look pretty if all the tracks have this.

Idk, wdyt?

Btw this is a fun read, for some limited definition of fun: http://mrale.ph/blog/2015/01/11/whats-up-with-monomorphism.html


This is so cool! Also, you're coding whilst snowed in?!


yes it is DYLD_LIBRARY_PATH. will fix it in trunk.


```json
{
  "version": "0.6.10",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1422439199993
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


yep :) thank you btw :)


We've got ARList now. This class is porbably not required anymore.


![sailfish-browser-15-5](https://cloud.githubusercontent.com/assets/10739157/5935530/a2ff2fd0-a6e4-11e4-866b-c0a4f084f0cd.jpg)

1st proposal for private browsing indication


Stfu St3eT, you don't know what's good for this project.


Nice And  clean code


Could you bench `is_readable` and `stat` ?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/605
success: http://build.servo.org/builders/linux2/builds/604
success: http://build.servo.org/builders/android/builds/640
success: http://build.servo.org/builders/mac1/builds/821
success: http://build.servo.org/builders/mac2/builds/821


I am sorry but I cannot accept this naming convention as its is in violation with Ray Wenderlich code styling rules, which says:
```
Variables should be named as descriptively as possible
```


Sure, I'll accept a pull request :)


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=a591c749d4be464aaf46e10de71cf92a
 plone-5.0-python-2.7 [FAILURE]


Gregory,
the new configuration (using property file) seems a great feature !

However, I implemented my own solution using servlet config (xml) that allows me to also use a database connection pool (apache commons dbcp-2) ie I have custom classes implementing ServiceConnection, AbstractTAPFactory, and HttpServlet.

I will look how to merge both solutions => create also a generic TAP Servlet based on external configuration (xml or properties)

Laurent


fast-forwarding master to auto = d373f8dc


val ontoFile = new File("../ontology.xml") should work here


`is_file` handles links:
```
$ ls -la
totale 40
drwxrwxr-x   2 ale ale  4096 gen 28 11:04 .
drwxr-xr-x 343 ale ale 36864 gen 28 11:04 ..
lrwxrwxrwx   1 ale ale     4 gen 28 11:04 linktest -> test
-rw-rw-r--   1 ale ale     0 gen 28 11:04 test
$ php -r "var_dump(is_file('linktest'));"
bool(true)

$ ls -la
totale 44
drwxrwxr-x   3 ale ale  4096 gen 28 11:05 .
drwxr-xr-x 343 ale ale 36864 gen 28 11:04 ..
drwxrwxr-x   2 ale ale  4096 gen 28 11:05 test
lrwxrwxrwx   1 ale ale     9 gen 28 11:05 testlink -> test/test
$ php -r "var_dump(is_file('testlink'));"
bool(true)

```


@brendo understood will move them to a separate class.

I think it should be flexible enough to be used elsewhere. In regards to datasource filtering I would presume you would want the new UI to replace the existing? if so I can try it out to make sure it works & eventually submit a separate pr.


From Ray Wenderlich Objective-C style guide
```
Constants should be declared as static constants and not #defines unless explicitly being used as a macro
```


@nick29581 yeah, I should certainly have made a test. Not sure why I didn't, I guess because it was blocking bootstrapping. Let me see if I can gin one up now after the fact.


## looks good


### merging


You don't explain why it could "interfere with proper synchronization" in the commit message.


Денис, это селект будет? ты же сам говорил что ```margin-left``` в хроме не работает.


You should not leave commented out code.


prevLaserCol misuse?
Gauss filter implementation?
mpfit library use


the same here


That'd be the most flexible option. Another is to have a list with IDs and their mappings, or just a list of the quests for which the NPC string ID is different. If a quest is not on the list, its ID is the same as NPC string ID.


Does this solve the embedded " problem?


And his call to make it easier for new devlopper ...


Ty :D


Great stuff!

Regarding to `is None` or not - yeah I understand the wider context. I guess it's a matter of taste and requirements (are you really checking for `None` or just for Falsey). Like I said, please apply a liberal pinch of salt with that suggestion. :-)

Having tried the code again, I get (unsurprisingly):

```
>>> import pyscrypt
>>> with pyscrypt.ScryptFile('foo.scrypt', b'pass123', salt = b'seasalt', N = 1024, p = 1, r = 1) as f:
...     f.write(b'hello99')
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ntoll/src/pyscrypt/pyscrypt/file.py", line 149, in __init__
    raise ValueError('The salt must be 32 bytes in length')
ValueError: The salt must be 32 bytes in length
```

:-)

I guess there needs to be some sort of constraint on or further processing of the salt to ensure 32bytes. I don't know enough about scrypt to know what to suggest (if anything). Given that the default is to generate a random salt, I'm trying to imagine a situation where I'd want to specify one.

Anyway... great to see the code moving forward. Just wondering if/when a Py3 compatible version will make its way onto PyPI..? ;-)

Thanks!


Grammar error in `it's`.

I don't understand why "Prevents setting the TDReplicator error when the error is for a local database being deleted." is part of this commit -- can you explain further in the commit message why these things are related?


Yes.


Не, это не селект и им не будет, это список категорий на странице блогов.


Судя по коду ниже, данные передаются в компонент nav, а не select


A little comment in this catch statement would be nice.


man ;) If you made this work, you did a hell of a job ;) If we had a
working kernel based off android tree it's soo awesome ;) Now goind up with
the version should be much easier (==possible at all...)

I hope I'll have some time in a few days and will carefully look at your
work :)
On Jan 28, 2015 11:06 AM, "Shilin Victor" <notifications@github.com> wrote:

> yep :) thank you btw :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChronoMonochrome/kernel_common/commit/a309008bbd80cb1b93259858e475e739123daa40#commitcomment-9475672>
> .
>


Make `_asyncTaskCount > 0` part of the condition for setting `_stopRunLoop`. It's rather confusing that `_stopRunLoop` can be `true` but the runloop stays alive. Refactor things where necessary to preserve sense.


опоздал


1: M111 unrecognized component name: mailutils


hpwh_residential (nmerket) - Win64-Windows-7-VisualStudio-12: OK (1592 of 1595 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.81%25-yellow.svg)


this would probably be better as: `unless res && res.code == 200`


and `fail_with` again.


what I meant is that you have a typo.
it's not "Intallation" it's "Installation".
you're missing the "s" :)


Woops, I never implemented this since I couldnøt get it to work, gotta remove it.


perhaps only 200 write error ..
param: r2, best: 201.26, start: 203.00, min: 0.00, max: 300.00, c 25.929128, a 71.670247


Вы одновременно написали, Максим на 2 секунды опоздал о_О


Pipefail?

http://bclary.com/blog/2006/07/20/pipefail-testing-pipeline-exit-codes/


ouai ça roule


Maybe just "Abstract" instead of "The abstract"


Yes, the Bananapi has no NAND. But i'm not sure if u-boot can know that before reading the script.bin. I inspected the *gd* struct and I saw nothing about NAND.

dram is the same as cb2 so I can't test on dram.


Laurent,

There is no problem using your current solution, particularly if your are already using a database connection pool. For the moment, there is no connection pool in the library, although the TAPFactory has now been modified in order to interact with one.

Otherwise, yes, I will provide a generic TAP servlet which will create the TAP service while loading the TAP configuration file thanks to a path specified in parameter in web.xml. This servlet will be a very quick development and I will do it at the end when the TAP configuration parsing will be complete (which is not yet the case...no way to get metadata for the moment...that's what I am working on right now).

Grégory


Yes.

I looked at some alternative plugins but they mostly didn't like allowing a
comma inside a tag. I found a way to pull out the tags with our existing
plugin without breaking if there's a ". Let me know if it doesn't seem to
be working.
On Jan 28, 2015 2:11 AM, "Lev Eliezer Israel" <notifications@github.com>
wrote:

> Does this solve the embedded " problem?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blockspeiser/Sefaria-Project/commit/3e0920c8b46f8b654b777a0325f6eaa9d9a5d6fd#commitcomment-9475814>
> .
>


That's an extremely hard to read line. Yes. Want to break it up @erikbern ?


wrong @since :)


bad copy paste :)


Hello Xu Xing,

Thank you for contacting me, don't worry to offend me. I have also been
contacted by the Intel Crosswalk team about this feature, so they also sent
me the code about disabling the animation. I will update my slides and add
this note.

Have a nice day and thank you again for contacting me.
--
Maxime

On Wed, Jan 28, 2015 at 7:10 AM, Xu Xing <notifications@github.com> wrote:

> To @mysegfault <https://github.com/mysegfault>
> Hi, Maxime Alexandre, I am from crosswalk project. From your foil(
> http://retour-experience-crosswalk-cordova.gopagoda.com/index_en.html), I
> heard that you had pain with white screen on Android devices.
>
> If you have no necessity to animate the XWalkView, you can add the
> following line at Activity::onCreate:
> *************************Code Start*************************
> XWalkPreferences.setValue(XWalkPreferences.ANIMATABLE_XWALK_VIEW, false);
> *************************Code End*************************
> This may fix the white screen issue.
>
> If you need to animate the XWalkView, we do have a white screen or black
> screen at arm based devices and we are working on this issue.
>
> BTW, If any questions, you can contacts to me or my colleagues directly.
>
> Hoping this letter not offending you.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Phonegap-Cordova-Paris/meetups/commit/ac859295578007688e77d902bea73b77cba000d8#commitcomment-9473113>
> .
>


oh my bad FollowSymLinks was not set.

Regards


All this reflection need a few comments.


and another `fail_with` opportunity.


This code is clearly making the view setup so I would place it inside loadView method.
I would also delete unnecessary empty lines.


return type was changed, but javadoc was leaved.
We have wrong javadoc in master now


Ok, so you ignore broadcasting here?

Something like this:
```Python
>>> numpy.arange(10)[:,None] * numpy.arange(10)
array([[ 0,  0,  0,  0,  0,  0,  0,  0,  0,  0],
       [ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9],
       [ 0,  2,  4,  6,  8, 10, 12, 14, 16, 18],
       [ 0,  3,  6,  9, 12, 15, 18, 21, 24, 27],
       [ 0,  4,  8, 12, 16, 20, 24, 28, 32, 36],
       [ 0,  5, 10, 15, 20, 25, 30, 35, 40, 45],
       [ 0,  6, 12, 18, 24, 30, 36, 42, 48, 54],
       [ 0,  7, 14, 21, 28, 35, 42, 49, 56, 63],
       [ 0,  8, 16, 24, 32, 40, 48, 56, 64, 72],
       [ 0,  9, 18, 27, 36, 45, 54, 63, 72, 81]])
```


Is this after you pulled? I disabled the timeouts, so if it's still happening there's some other issue.


Please delete those empty lines


cool to have those 2 methods, I like it.


In the Gemfile you should use 'byebug' instead of 'debugger' if you run Ruby 2.


Obfuscation /could/ change meaning thiw would be rendered useless in future updates.
Maybe we should just make a PR for spigot.


spelling error, should be 'enumeration'


We need to update http://extensions.xwiki.org/xwiki/bin/view/Extension/Component+Module#HAccessfromScripts too


`Dir` supports multiple arguments, maybe:
```ruby
s.files = Dir[
  '[A-Z]*',
  'doc/yardoc_{templates,handlers}/**/*',
  '{bin,lib,tasks,test}/**/*',
  'nanoc.gemspec',
]
```
CC @nanoc/contributors what do you think?


ой, а я на это вообще раньше не смотрел, это что, в итоговом ксс все классы будут вот такие, без родительские?
а если плагины будут использовать такой же класс?


why was this needed?