state_machines-activerecord tests now fail with many more errors:
```
  test_should_not_run_further_callbacks                          ERROR (0.01s)
NoMethodError:         NoMethodError: undefined method `state' for #<#<Class:0x007ff7fea9a1e8> not initialized>
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activemodel-4.2.0/lib/active_model/attribute_methods.rb:433:in `method_missing'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine.rb:1053:in `read'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine.rb:1904:in `initialize_state?'
            /Users/JD/state_machines-activerecord/lib/state_machines/integrations/active_record.rb:573:in `initialize_state'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine_collection.rb:29:in `block in initialize_states'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine_collection.rb:28:in `each_value'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine_collection.rb:28:in `initialize_states'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine.rb:1925:in `initialize'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activerecord-4.2.0/lib/active_record/inheritance.rb:61:in `new'
            /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activerecord-4.2.0/lib/active_record/inheritance.rb:61:in `new'
            /Users/JD/state_machines-activerecord/test/machine_with_failed_before_callbacks_test.rb:16:in `setup'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activemodel-4.2.0/lib/active_model/attribute_methods.rb:433:in `method_missing'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine.rb:1053:in `read'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine.rb:1904:in `initialize_state?'
        /Users/JD/state_machines-activerecord/lib/state_machines/integrations/active_record.rb:573:in `initialize_state'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine_collection.rb:29:in `block in initialize_states'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine_collection.rb:28:in `each_value'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine_collection.rb:28:in `initialize_states'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/state_machines-0.1.1/lib/state_machines/machine.rb:1925:in `initialize'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activerecord-4.2.0/lib/active_record/inheritance.rb:61:in `new'
        /Users/JD/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/activerecord-4.2.0/lib/active_record/inheritance.rb:61:in `new'
        /Users/JD/state_machines-activerecord/test/machine_with_failed_before_callbacks_test.rb:16:in `setup'

Finished in 6.83116s
204 tests, 44 assertions, 13 failures, 161 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -I"lib"  "/Users/JD/.rbenv/versions/2.2.0/lib/ruby/2.2.0/rake/rake_test_loader.rb" "test/*_test.rb" ]

Tasks: TOP => default => test

```


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1095 of 1095 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This all looks good to me :+1:


@PeterPablo: I agree, there is no need for commented code.

But on the other hand, I agree that this needs to be documented properly, why we test this. And the reason is because of the `spectrogram` function.

```matlab
%
% The code below emulates the |spectrogram| function of the Signal Processing toolbox (MATLAB), e.g.
%
%      T = 0:0.005:2;
%      X = chirp(T, 100, 1, 200, 'q')
%      spectrogram(X, 128, 120, 128, 1e3)
%
```

But in that case, it would be best to make sure the snippet in the comments and the actual code do exactly the same thing.
I do have some ideas to get rid of the `chirp` function as it is quite easy to build a similar signal by hand. The spectrogram is a bit more involved, but not really hard either (just a few `for` loops and some `fft`s, maybe with a window here or there).

Also, we need to beware of such emulations: MATLAB is not wary of using very special plot functions (e.g. bode plots) that change over different versions and that produce complicated internal data structures that produce a normally looking figure.


OK


why not crypto.PrivateKey type?
we can use crypto.PrivateKey, it's more readable.
http://play.golang.org/p/u_gL1OBVQ3


You can't assume lexical-binding for haskell-mode, unfortunately, because we still support Emacs 23 (at least for now).


Woah, that number shot up then (maybe because of the move from googlecode to github?).

I don't have svn installed; I *could* install it but just asking for sience/completeness: is there any chance I can get that number from somewhere else?


ipmi_msghandler might be required as well (goes before ipmi*)


ok


[Low] Add proper comments


What do you think about putting this in a `configure` method, kinda like Rails does. It won't be a singleton, so it's a bit different, but yielding from `initialize` with an object that isn't from that class seems dangerous. Seems like `initialize` should take a config, maybe? Thoughts?


so much ":="


![screenshot 2015-01-19 22 29 10](https://cloud.githubusercontent.com/assets/9048837/5818100/ac3eb346-a0b2-11e4-9b7d-c3f541d0d705.png)


yes, feel free to provide a refactoring.


[High] You're missing the step to set the new state to your object. Please review State pattern.


Yes, thank you for publishing this.


asdasdasdasdasdasdasdsadas


It will be gently, when we use one format style (go fmt is preferred)


self.env.ref('account.view_move_line_tree', raise_if_not_found=True).id


just leaving a comment on my own check in to be social


I'm a friendly dude


It's due to Lon removing the accents from the province files, I guess he's looking into a fix?

If not we have to add them back and have no religion for now, at least the provinces work in that case


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 129](http://192.168.30.225:8111/viewLog.html?buildId=579&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 6; exit code 1 Build time: 00:10:32


An interesting future feature would be to inspect installation media and guess distro names, versions, archs and whatnot. It might be tricky to do, although we could count on libosinfo (https://libosinfo.org/) to help with that.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Is the last script always Brython?
It seems that in some cases it isn't, according to https://github.com/yairchu/vote_tool/issues/1#issuecomment-70644706


GG !


Sorry, I am at a loss. I had a look in the innards of `spectrogram` and posted the relevant lines. We don't care about the actual data that is to be plotted. You are certainly right that there are othercases (e.g., bode plots) where we can not mimic the behavior of MATLAB as easily.
In short: Please don't try to duplicate the spectrogram calculation. It's out of `m2t`'s scope.


self.env.ref('account.view_move_line_tree').id :)


There are newer releases, but I didn't dare to make a larger update, as I know nothing about the package.


Oh, I assumed the prints were still there, If they have been removed I'd worry about it.


I'm working on this.
```
state_machines
state_machines-activemodel
state_machines-activerecord


Sure this will work? Would be cool

As far as I know github only searches through the description line of projects. See eg http://stackoverflow.com/questions/8074906/is-it-possible-to-tag-projects-on-github  Unless of course things have changed meanwhile

I also doubt this will improve search engines results as most of the keywords are already mentioned in the text above.


If the JSON.parse works, i think it should still be there.

--Nicklas
59D8 27AD 2632 F349 9B20  F5CB D363 3177 0A12 1B95

On Tue, Jan 20, 2015 at 2:24 PM, Percila <notifications@github.com> wrote:

> So first the JSON.parse is not supposed to be there.. @niligulmohar
> <https://github.com/niligulmohar> in your script we then push the
> graphValue to graphValues..?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MyTemp/freeboard/commit/35ef8d35eb3a7dfbf28f5d263122395a2470801d#commitcomment-9355698>
> .
>


Ok


canola?


This breaks the tests because you didn't import `<<`.


OK


Remove the comment and the HOST below


Same here.


You mean that initialize should take an instance of `SkoogleDocs::Config` instead of creating one itself? From the point of view of the gem consumer, I was thinking they would do something like this to use the gem:

```ruby
client = SkoogleDocs::Client.new do |config|
  config.client_id = "ID"
  config.client_secret = "secret"
  ...
end

docs = client.documents # get a list of accesible documents
```

They would only need to know about `SkoogleDocs::Client` and eventually `SkoogleDocs::Document`. I wasn't sure how to get to that point if we pass in the config. Lets grab some :coffee: and talk it out :smiley:


Blasphemie!


du kannst mir gerne sagen wie ich das rückgängig mache :D


I don't know what is the reason for changing it in the first place but it prevents a very nasty issue I encountered on iOS 8. I describe it on the following repo and created a simple project that makes it easy to reproduce:
https://github.com/Bluezen/ECSlidingViewController-issue
Any help on that topic would be appreciated!


Alright, that certainly makes sense, then. Now I only have to change its format so that it'll look good.


I'd probably transform the ComputationStep[] to a Map<? extends ComputationStep.class, ComputationStep> which would prevent the double for loops


chỗ breadcrumb chữ cũng bị xuống dòng


I would rename the function in the public namespace: to osha_sort_language_list.
Also $lang_order = array('bg', 'cs' ...). Why are they keys??


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10198/testReport/) for this commit**


I am missing where the unknown component gets added to the DB in this test.


git yolo \o/

![giphy](https://cloud.githubusercontent.com/assets/2625584/5818249/60b015d0-a0b4-11e4-9c7f-fdc77cacc6b2.gif)


Yes, your suggested change makes more sense. This method will be called
with an empty set if it is not handling anything - this is so that handlers
which care that they haven't won in the logic to decide which handler to
use when there is more than one can complain. This base class is not one of
those.

On 20 January 2015 at 13:05, André Pinto <notifications@github.com> wrote:

> I have committed these changes on my own zipkin branch in order to keep
> testing. If you find the right solution is different I can later changed
> them before merging.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/betfair/cougar/commit/57b74db99dbeeba3348f6fc46b9f25cf36bb893e#commitcomment-9355436>
> .
>


OK, there you go. I found where the component is added.


hab ich nicht, richte ich mir bei gelegenheit mal ein


add empty line in the end of all files


Oh, I actually missed that. Any reason for doing so? It's not that I care either way, I'm just wondering.


Thanks @kashifmin  btw .... I just wanted to ask will the subsequent build boot without bootclass path ? :/


(a,b) => (a, b)


OK


It's in the fixture file: `avocadoserver/fixtures/initial_data.json`. It was merged as part of the database model commits.


Hi,
try one of the following:
- https://github.com/Christopher83/arm-cortex-linux-gnueabi-linaro_4.9
- https://github.com/Christopher83/arm-cortex_a7-linux-gnueabihf-linaro_4.9


tmp[-2] = ""
but I think there are must be some method like tmp.delete(-2) - check it


Yeah, but might be useful in the future to help debug issues that people report.


if you work with range don't user space: string[0..start-1]


Hmm, OK, so I made a mistake. `softwarecomponent` and `softwarecomponentarch` are easy to mess up.


```
git reset --hard 24df71a634d406b195de952f2d3d8a10f639d1ea
git push --force
```

sollte theoretisch? vielleicht? mit glück? who knows ¯\_(ツ)_/¯ :D


I think I have a problem here.
Assume the `doInBackground()` is unsuccessful and returns `false`, so `updateView(false)` is called.
`updateView(false)` could still determine an incomplete `file.exists()`, and proceed to call `showRobot()`. The error message from `showDisconnected()` is never displayed, and we are forever stuck with a potentially malformed robot.


 remove that: && index > 0
do tmp[0].capittalize! before cycle


change is good


This is the only way I'm aware of. Don't know what you're using it for, maybe the git commit id (38ce887239cd78838e7c838b78c1c6c6fa6b827e) is really what you want?


index.zero?


Hi Sven,

There are several way seeing this:
1/ the code, as-is, provide an iso feature to what was previously.
2/ it is under responsibility of the user to either return `true` or `#isEnabled`.
3/ it could be seen as the best compromise for now, knowing wicket cut-off is very close.

I agree with `#checkParentEnabled()` but - yes - it should be done at the `Component` level and taken into account in `#isEnabledInHierarchy`, which would probably become:

```java
public final boolean isEnabledInHierarchy()
{
	return checkParentEnabled() && isEnabled();
}
```

But I don't know if it can be done right know. Anyhow, I don't see the impact with `#isLinkEnabled`, your remark will remain valid. Am I missing something in your thought?


Yeah, only `softwarecomponentarch` and `softwarecomponentkind` are previously added. The `softwarecomponent` itself, say `bash` with arch `x86_64` and kind `rpm`, is left (on purpose) to the user.


why you use scopes () - delete it


Name of this commit should be "Add find_team()"


Is this class used?


We don't have to add the probe dependency if the development mode is disabled.


Profiled that test, it's true that rmlint is awfully slow here (it's even slower than fdupes here - wow!).
Problem lies in this line here: https://github.com/sahib/rmlint/blob/develop/lib/shredder.c#L1055

`g_queue_find_custom` goes linear over the list and is called for every file at least once. This results in heavy (quadratic at least...) performance degradation when the number of child shred groups is very high (1024 * 128 in the above test). While this is very seldom in normal data, this could be fixed by using a better data structure for children like a `GHashTable` or a `art_tree` likes `treemerge.c` does.

As far as I understand the children queue is not needed to have a certain order?


I find that it's helpful to put the version you bumped to in the commit message.  That makes it easy to find a specific version in the commit logs.


The JsMath button renders just above the settings button when you have bottom header activated.

![jsmath](https://cloud.githubusercontent.com/assets/5222254/5818378/94382298-a0b5-11e4-8e58-55a55c6c6d81.jpg)


Warning: DiscountPolicy


Will do. I spent most of Thursday last week at company, taking care of my
paperwork to move out of the barracks, and I have some more stuff going on
this morning that I'm trying to get resolved.

SFC Jimenez is tracking, I just thought I'd let you know as well you
wouldn't think I was ignoring your emails. I'll touch base again when I get
into 9828 and start working on some stuff.

On Thu, Jan 15, 2015 at 8:02 PM, walterschell <notifications@github.com>
wrote:

> Add me to the commit list for this repo
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Explicitname/Subnet-Calc-and-RegEx/commit/70b31c425db6cefe8599ac7cbb609ccfd317fbe8#commitcomment-9307819>
> .
>


@matthewford I think the task is `bundle exec rake bundler:audit`, isn't it?


yes, we need new code to remove stale snap dentries.


ㅋㅋㅋㅋㅋ :laughing:


comment


Check... I think it can be like self.empty?


This line is ok?


will hasNext() fail if it's called several times ? The class behavior and contract should be explicited. WDYTH ?


if tens != 1 && tens != 0      =>  if tens > 1


ㅇ


Is this correct? If we dcbz outside of physical memory, shouldn't we be ignoring it, not wrapping around? I thought dcbz takes effective addresses, not physical.


LegionPE alone is keeping me busy enough.


Consider taking a look at AlignEquals and AlignDoubleArrow additional passes... they could be called from within this file, providing thus code reuse.


That's what the latest template (v2.6) uses, so I switched it for uniformity.


How does this work from the plugins point of view? Will there be a config reload event, or some method call?


There is a better way for this, can use LIBPATHS (just below this)
I missed it while working on this, but spotted it while working on something else, will change this one too.


How about adding another parameter to the validate-function `na` that, when set to `TRUE`, skips this check? The function could then be used to validate input that allows NA, such as `x` in `printnumber()`.


I think bills will come in monthly, not yearly


Warning: Refactor so something like applyDiscount


hmm, 1 month if at all


Warning: Always start the name of the class with uppercase.


thx


@stulees I actually don't feel too strongly about this either way, but if you do I can just change it. Thx.


Bugger. Yes, meant to do master => kingman, will fix tonight when I get the chance >_<


I like the idea of explicitly passing names of to-be-validated parameters as strings to the functions. This should give us a little more flexibility when, e.g., these arguments are modified and passed to other functions.

So far, I have ended my error messages with a full stop. As I see it, we could do it either way. It just feels to that a full sentence deserves a full stop. ;) What are your thoughts on this?


This is the Super Entity - no need for any labels or Widget modifications here as not accessed directly
(we use the s3field for validation)
Less is More here as we don't want any unneceessary overheads for SEs


Maybe mention http://minecraft.gamepedia.com/Server.properties op-permission-level ?


StopState


Woohoo! Thanks!

Any idea why empty tycontext doesn't work?


Aggregates are never entered manually, so 'less is more' here


TrackContainer


Should we provide links to documentation on glowstone/granite/forge commands available?


if the offset is e.g. 6000, would it be faster to just add twice?

Also, is there an efficient way to add large single-bit offsets, like 0x8000, on ARM?


PlayList


PlayState


MarketManager


This happens a lot; maybe a helper function would be useful here?


Done


You can't do PPCSTATE_OFF(cr_val[crf])?


reaaaalllly thinking we need a helper for add/sub offset


The `README.md` containes markup. Do you think it is okay to have this in the description?


Is `post` really the best variable name for this?


slot instanceof Array would do just fine :-)


Oh, easy fix: git revert -m 1 90485041d946614b892a6c83693f45eecd6bf8f7

See: 7d78dd0d4d82be8648e8816b8146d71e8346c2d6


Is there any platform-agnostic way of setting the current logging levels / configuration?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (597 of 597 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.36%25-green.svg)


Chyba kolejne pary powinny się łączyć na różnych portach, nie?


Hi @bjornerik, there is a 12MB `tpl/tpl.test` Go executable included in your commit?


Hey! You mind if i merge your changes into master?


r+


you also could make it simpler:
if label.lower().startswith('fixes #'):


@PeterPablo All right, if that's the only thing that happens (plotting-related) in `spectrogram`, then everything is fine. I just don't trust what MATLAB does in all those special functions (e.g. I know that in `hist` and `bode`  there are a lot of unexpected things happening behind the scenes, so the same could have been the case in `spectrogram`, was my logic).

Anyways, the point still stands that it should be documented why we test this like that (i.e. because `spectrogram` does this as well, but we don't want to rely on the Signal Processing Toolbox).


You should free the memory if fatal_error.header is not NULL.


testing testing comment


"Veuillez confirmer la suppression de ce cours :"

(espace avant ':')


merge


I would say there are two positions in this case:
- closest replication: we should reduce the amount of data to the bare minimum and then hardcode a `surf()` call as it happens inside `spectrogram()`. However, I cannot do it :sweat_smile: for obvious reasons (no TB).
- graphic issue testing as produced by some specific plotting function. This is what I did since I think the spectrogram is nothing more than a 2D surf. However, we might get differences in how NaNs are treated or other values, something that the emulating test would not pick up. Or newer versions might introduce the spectrogram class, but then it's a feature request.

It's basically a trade-off in any case but we should keep record of what's the benchmark.


Added empty worksers


It was used as a 'quick reference' in some internal versioning like x.y.z.q where x.y.z is the actual version of the project and z was the 'build number' for libphonenumber that the component was built against. For example 5.9.13.927 where 5.9.13 would be the components version and 927 would be the build number the component was built against. This way I could have multiple 5.9.13 versions of our component where the only difference was the internally used libphonenumber.

Nothing really very interesting, and only a proof-of-concept project anyways so no problems whatsoever. The git commit id is not very suitable for x.y.z.q versioning. I'll either install svn or else switch to a different (and probably better) versioning for the component alltogether.


I'd sooner see this as a standalone js file, personally.

I very much like the idea behind this.  I'd also like to see something that changes the image `src` in there based on in-editor resizing.  So if they add a 'medium' image and resize it in-browser to larger than 'medium' dimensions, we silently swap in the next image size up -- that matches the same aspect ratio.  (so thumbnail wouldn't upscale unless the image was natively square)


Does this also include the length of the optional comments line?
```
>chromosome1
; this is the optional comment
ACTAGTAGGGCTAGC...


why fall back on non-fastmem? I thought you were calling common quantize/dequantize functions that had fastmem off anyways


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/cf0652812c3b5e7a8f57289d1257dc71b3bed3f2


merging Ms2ger/servo/doc-clone = cf065281 into auto


Ms2ger/servo/doc-clone = cf065281 merged ok, testing candidate = 89645391


AAAAAAAAAAAAAAAAAAAAAAH !!!!!!!!!


*.psd1 diff=astextplain


Traduction à valider.


would (u64)&asm_routines.pairedLoadQuantized[inst.W*8] be more clear than hardcoding sizes?


msgid "for you**r** search pattern"


damn you ARM and your lovely bit extract instructions


How do we hake this div invisible before the modal shows up?


sucj yuj muddaj


what does 0x70 mean @_@ is that a float 1.0?


I like where this is going @mac-nw, good work. I'm not particularly fond of the top positioning though.

> if both menus can be keep in script

I'm against supporting unnecessary stuff, with time things get complex so I'd go for having either one design or the other.


Error: When creating a singleton the constructor must always be declared as private, otherwise, the children or siblings of this class could create new instances, therefore more than one instance would be created.


nitpick: maybe make this cleaner/less duplicatey by pulling it out of the if since it's the same in both paths?


I haven't hit this in a couple weeks. Probably nothing to worry about - will open an issue if it rears its head again.


*shakes little fists, says something about implementing indexed versions too at some point*


sorry for the unhelpful report


why?  why not just call write32, write64, write16?


This allows python to recognize separate provider/task pluggable modules from third parties via setup.py and stevedore namespace definitions.

Looks like there might be a "newer" way to load these (https://www.python.org/dev/peps/pep-0402/) but this has not been tested with stevedore.


true.


had a thought about this, probably

position:absolute; visibility: hidden;

after modal shows, restore values to inital


This is not actually for the deployer controller... it's for the actual deployer spawned in a pod by the deployercontroller. As we want distinct clients for controllers or components we launch in pods from master, we'll add client configs for them, have BuildClients() instantiate clients from them, and add helper methods to access the config or client as appropriate.


why are we doing this? can't we just call safewritetoreg like in the x86 code?


What circumstances can cause `t_data` to be NULL?


Yeah I didn't see an existing testing js file where it seemed to make sense to put it. When we need to use this somewhere else i guess we can create one.


But is this version actually the minimum version it will run on? If not, then this change is wrong.


Allows for modular import of settings from separate plugin libraries.


I don't get your point. hasNext() can be called several times consecutively. See CloseableIteratorTest#iterate()


@garonsky Looks good


Nit: can I get a comment on it?  The others are very obvious, this one less so (at least to me).


@Demwunz wondering if we should also add the link to old form on 503 or any 5xx page. That was my original thinking but I'm happy to be persuaded otherwise. Thoughts?


Hmmmm je suis pas fan. Ca veut dire qu'on ne peut plus tester le backoffice sans connexion internet ? Et Sylvain qui doit travailler dans le train ?


agree


Bof. Tu ne veux pas mettre des règles plus spécifiques dans le css ?


<form action="{% url 'backoffice-course-certificate' course.id %}" method="post">


I believe that TokenList::createAst() should not be const. Even though it can "technically" be const - there is no compiler error. Because the TokenList object is modified when this method is called.

So Cppcheck doesn't write a FP. We just need to suppress the warning somehow.


In this example we introduce the <<- operator which can be used to assign a value to an object in an environment that is different from the current environment. Below are two functions that are used to create a special object that stores a numeric vector and cache's its mean.

The first function, makeVector creates a special "vector", which is really a list containing a function to
set the value of the vector
get the value of the vector
set the value of the mean
get the value of the mean


Connect param is n/a in all use cases? If so it should be removed from the other examples as well


Must depend on CKEDITOR.env.needsBrFiller:

```
replace( /@/g, CKEDITOR.env.needsBrFiller ? '<br />' : '' );
```


makeCacheMatrix creates a special matrix object, and then what the cacheSolve does is it
calculates the inverse of the matrix.
If the matrix inverse has already been calculated, it will instead
find it in the cache and return it, and not calculate it again. This the quality of this assignment.


On indente à seulement deux espaces en html ? Pas plutôt quatre, comme en python ?


I thought that maybe hasNext() could not be called once it's closed but I was wrong as the close() can be called several times without failing


added


'Course information'


It's possibly better to point to `dist/waves.min.js`? It's a good idea though. I'll look into this later today.


You can use `l.d.new/package-to-path` here.


Done.

----- Original Message -----
> You should remove this from this commit (probably altogether)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabianofranz/origin/commit/6b41f19313d2f0a6c866664bec542f91fda960e3#commitcomment-9349774


Done.

----- Original Message -----
> `(config.Version == "v1beta1")`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabianofranz/origin/commit/6b41f19313d2f0a6c866664bec542f91fda960e3#commitcomment-9349779


Done.

----- Original Message -----
> `Resource("templateConfigs")`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabianofranz/origin/commit/6b41f19313d2f0a6c866664bec542f91fda960e3#commitcomment-9349795


This could probably become:

```
tags = self.audio.get_current_tags().get()
if not tags:
    return
...
```


Agreed, removed from the config.

----- Original Message -----
> Were you planning on using these, or just adding them?  If they're not used,
> not much point to exposing them now.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabianofranz/origin/commit/6b41f19313d2f0a6c866664bec542f91fda960e3#commitcomment-9349802


We should probably just give core access to audio in https://github.com/mopidy/mopidy/blob/develop/mopidy/commands.py#L282


此行代码会导致ws对象永远没有机会初始化


'Students enrolled in this course'


We should probably double check how MPD notifies clients about this type of change, or at least add a TODO to remind us to check.


One thing, I think that because the methods in the TupleToMessage classes aren't marked protected I can't override them in a subclass that is in a different package.  Can I submit a pull request to fix this?


this is a website just for testing！


Another question but not critical. Since this is a major change (from delayed_job to sidekiq) - shouldn't it reflect a change from 0.2.x to 0.3.x where 0.2.x may continue as a delayed_job if someone wants to fork it?


We probably shouldn't be reaching into tracks like this. I suspect this handling is wrong as it doesn't handle the keys that start with `_`. We can however add features to models to make it possible for you to achieve what you are trying to do.

Say we add a `model.merge(other)` or something like that on the `ImutableObject`


![Uploading Maid with the Flaxen Hair.mp3 . . .]()


pinaillage : On peut retirer quelques lignes vides.


Weird I didn't push it in utf


The SWC-lib is outdated. Any plugins compiled against it will crash when loaded in the player.
https://github.com/jwplayer/jwplayer-sdks/blob/master/jw6-plugin-sdk/libs/jwplayer-6-lib.swc

For example, `getButton()` does not exist anymore in https://github.com/jwplayer/jwplayer/blob/master/src/flash/com/longtailvideo/jwplayer/view/interfaces/IControlbarComponent.as


[pinaillage]Lignes vides inutiles


#isLinkEnabled() was flawed:
- it didn't work without additonal tweaks, e.g. overriding #canCallListenerInterface()
- it duplicated/conflicted with functionality of #setEnabled()/#isEnabled()/#isEnableAllowed()
- it worked for non-ajax links only
- it targeted links only

With WICKET-4551 AjaxEventBehavior calls #canCallListenerInterface() now, so AjaxLinks can be enabled inside a disabled hierarchy too. IMHO this is very confusing and difficult to explain to users.
Since this was applied to Wicket 7.x only, we can easily revert it.

Instead of overriding two methods, it would be much simpler to have one new setter, to explicitely configure a component to ignore its ancestors' disabled state.


While I understand that boolean flags are the primary target for thing thing, singling out booleans seems little confusing. Can you please check for longs and doubles too?


Ok, i removed the const by https://github.com/danmar/cppcheck/commit/5a8574cc0566fc7f0ab0338357ef55c2d75b89a1.


Why not do that in XYPath?


s/mtdata/metadata/?


IMHO, it's better to keep example in the code base.
For example, in the train, one may not have wifi access, and so the doc is not available, where the vendor are.


I didn't moved the `/build/insecure_key` to `/build/services/sshd` because it's used outside the build process in places like `install_tools.sh` and `Makefile`.

Maybe there are better solutions to this.


I think you can use slashes on windows, it might have subtly different behaviour though. I think lein-new's path would be better off using something like this rather than building up a string.


> Is yo actually using anything of mine?

No idea, probably somewhere in the dependency chain, but I was looking into replacing our usage of `findup` with `look-up` if it really is a lot faster.

> that's why I mentioned it ;). you said "I wanted something fast" => https://github.com/jonschlinkert/repeat-string#benchmarks. It would have been great to get a pr for the cli stuff etc.

Oh, nice. I thought it was max optimized with mine. Sure.

> You say that too much. You love open source and contributing, I do too. No need to pacify.

Was only pacifying about the discussion about duplication. We can go back and forward endlessly, but I'd rather spend my time moving fast and trying out things.


I would change that to `.configure` from `new`, but that's just me. It's not horrible, but yielding a config object from `Client.new` is surprising.


add javadoc to interfaces


md? No need to abbreviate. Is this actually different from `current_track` though?


{% blocktrans count counter=courses|length %}course{% plural %}courses{% endblocktrans %}


Hmm, I wonder why we aren't returning this as an int, since we always convert it should probably just be one properly. Though don't worry about that for this PR :-)


What about a link to the sesame workbench instead?


It's funny that there's no error in this file.


Low: Use interface to define variables.


Htslib does not support such comments; nor did samtools before it.  Do you know of any other modern software that does support `;` comments in FASTA or specifications that suggest that it should be supported nowadays?


I remember Zach Oakes had problems with slashes on Windows, but it was not `lein new` related. Perhaps lein new handles slashes incompatibility internally.


These assets are text now, but I guess Git can't handle that


Why an empty flex?


Low: mark this as final param


why have you removed everything related to osco?


Sorry to ask a question at this commit

some pictures ( ex > icon_installing_overlay01.png ) disappeard when normal mod (after boot)
but at recovery mod , these unseen pictures had appeared
 what is secret method of this situation?


I had to remove the double quotes so that commands like:
```bash
$ ./production test.smoke.com
```

are not treated as a single filename, which seemed to be happening


This looks too specific to chords to happen here.


I think this might be some bad c/p


Sorry about that... the puts were gone, but the ```cli.init_reporter``` call is still out, so it's still the last commit.

The only reason this popped up... I'm putting a presentation on executables in gems, and Spinach was one of my examples (love the simple code).  I was looking at a screenshot, and I noticed the "temp" call from two years ago, and I jumped to a conclusion.

No big deal. :smile:  Sorry to bother, thanks...


It's 2.4.2


What's this little guy?


please remove them, not comment them


$index%4 ?


I'm thinking something like:

```clojure
(defn- type-name [val]
  (let [t (type val)]
    (case t
      Boolean "boolean"
      Long "long"
      Double "double"
      (.getName t))))


Why have you downgraded the wildfly version?


Why would we prevent creating tracers at any time ?


Hello @Jalle19,

cross the fingers, if everything goes fine the WINDOW_DIALOG_PVR_OSD_CUTTER come back :-)

If nothing become wrong I do in the next time work on it to add recordings cutter.


No I certainly do not. I only asked because I have a python library that reconstitutes htslib `faidx` functionality (mdshw5/pyfaidx) and was wondering if I should support such a use case.


Please help xPythonic
On Jan 20, 2015 12:46 AM, "Kevin" <notifications@github.com> wrote:

> Then lend your wonderful advice @xPythonic <https://github.com/xPythonic>
> <3
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ToontownInfinite/src/commit/c8c4b3f58e30ff5f82538b4b23309129f57dc384#commitcomment-9351872>
> .
>


You seem to be having some space issues.


Should be fixed as of: https://github.com/sahib/rmlint/commit/6b3b80b6ef226673a93e03645c727e397577c0af


don't add "~" files


this is a comment


The Observer/Observable pattern is correctly identified and coded, but they are not connected, What I'm trying to say is that the MarketManager is never added as an Observer in the code. It shouldn't be done on this class, but somewhere in the code this instance should be declared as an Observer.


don't add log files


I don't think you should have to copy the dur attribute to each note. Instead, when processing a chord Note, check if the note has a dur (note->HasDur()) and use the chord one if none.


low: mark this as final


I need this change in my project...why you didn't pull request this change?

Thanks!


The more I think about it, the more I think this should be restricted to a definite list of Boolean, Long, String and then throw an AssertionError if you try to put anything else, because chances are it won't be representable trivially in java, and you are probably at that stage abusing it for something you shouldn't be doing anyway!


MetricType should probably be the first parameter here, since it will probably be changed more often than the MatType parameter.


Are buildings stored in the database? We could write an API route.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/584
success: http://build.servo.org/builders/linux2/builds/583
success: http://build.servo.org/builders/android/builds/620
success: http://build.servo.org/builders/mac1/builds/801
success: http://build.servo.org/builders/mac2/builds/801


Need to remove credentials


Done


That's true. Even clojure.lang.Keyword, while tempting, would be not good as loading the class would trigger whole Clojure initialization which we would likely to put off.


Yes, read the discussion on the PR :)


Specifying the template parameters here is unnecessary since they're the defaults.  Minor issue... :)


Low: use Map instead HashMap.
High: Make sure that item is inmutable object.


ohh..ok :+1:


```
rake db:migrate
subl ~/.zshrc
source ~/.zshrc
export APP_ID=12345
export APP_SECRET=12345abcdef
```
https://developers.facebook.com/


Low: Use Map


fast-forwarding master to auto = 89645391


@ophian You need to also commit this to master please.


Ok, I better understand now. I also understand what you meant with `#checkParentEnabled()`, it is supposed to be *the* flag...
So the question is now: what's next? Should I open a feature request? Can it be handled as part as WICKET-4551? (it would definitely make sense, but it is "revolved" now)


[WIP] #129.


Does Keyword trigger clojure init? I didn't think it would. But yes, probably out of scope for this change. Can always add it if the need arises.


I'm having some trouble with the Traversable trait and the current DataDNA trait.

The way we define the types (`data_type`, `TX` and `TY`) is not appropriate.

Does one of you guys (@echarles @Supermanu) have an idea of how we should do?


saw approval from jdm
at https://github.com/servo/servo/commit/01ed338746ae71493984259335197e6b66daec45


merging servo/servo/to_owned = 01ed3387 into auto


servo/servo/to_owned = 01ed3387 merged ok, testing candidate = 94ebc7c3


Yeah, I think that might be a good thing to do.


here is comments for Line4


Guys, I've reviewed the <assets > concept in more details and looks like the logic added is valid and works consistently across the platforms (project_dir  is `android\assets\www` on android for example). As per docs [http://cordova.apache.org/docs/en/edge/plugin_ref_spec.md.html#Plugin%20Specification_asset_element]  this is `www` folder specific feature and should not be used to place anything outside (or we should refine this concept).
Looks like the plugin I found issue in didn't work properly anyway since just copying image to Images folder does not include it to the project so this makes no sense (in comparison to the files in `www` which  are automatically included to the project). As a conclusion  - I propose to leave destination check as-is, otherwise we should improve this logic by also including added assets to the project when it is necessary.


Visual changes


comment at Line 1


Resolves Issue #38


Yes/no - left right counterbalancing


# overall

asdff

# Section 1

fff

## Case 1

aaa

## Case 2

bbb


Shouldn't this change also implicate removing the condition `key != 'font-family'` [here][1]?

[1]: https://github.com/NYTimes/svg-crowbar/blob/3a8e8e6115eed150f932817d4493c2ea7196689e/svg-crowbar-2.js#L220


@louis49 Why get rid of these?


Dead code.


@michbarsinai this broke my script at https://github.com/IQSS/dataverse/blob/master/scripts/search/tests/grant-authusers-add-on-root

Should be working as of a4171d5

@ekraffmiller and I have been talking about putting more tests in https://github.com/IQSS/dataverse-apitester


On veut vraiment logger un warning ? C'est pas juste une info ?


High: this Observer can't be reused. Use a standard one (just a notify method).


This should be a call to DEBUGLOG() instead, Right?


Low: use Map


The article describes step-by-step implementation of a static page... или вообще shows you step-by-step how to create a static page using BEM
В ссылках на английскую версию сайта мы не пишем en


Well, no, Keyword.intern() won't trigger initialization, I was too hasty. Regardless, that's too much to add dependencies to something as simple as BuildConfig. So, booleans/strings/longs/doubles is a solid list.


Low: Use List


Un jour on corrigera cette faute d'orthographe...


Thanks!


@pdurbin sorry. Anything I need to do?

Re: tests, good idea.

Sent from my iPhone

> On 20 בינו׳ 2015, at 16:57, Philip Durbin <notifications@github.com> wrote:
>
> @michbarsinai this broke my script at https://github.com/IQSS/dataverse/blob/master/scripts/search/tests/grant-authusers-add-on-root
>
> Should be working as of a4171d5
>
> @ekraffmiller and I have been talking about putting more tests in https://github.com/IQSS/dataverse-apitester
>
> —
> Reply to this email directly or view it on GitHub.
>


fait un ticket avec la bonne ortho, j'arrive pas à écrire ce mot


By rebuilding the position you are preventing people using your API from subclassing Position to contain extra data / use .equals methods to compare the result.


Why bother switching around the double quotes with single quotes?


TeamCity Ylab :: synteny/ylab [Build 25](http://192.168.30.225:8111/viewLog.html?buildId=580&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


Well yes ... I know and would certainly do this if I could. But as I wrote to you by mail I have a bugged version since I did a checkout master.


needed to clear run = 0; here in order not to skip to the next trial immediately


Great stuff, been thinking of this change myself.
Maybe it's a good idea to move things like these to top level "constants" variables or a settings.py module?  Also, inserting a random if False:... in the code is also very non descriptive.

Currently my custom settings version of lp95 only has the change LINK_SESSION = True.. So maybe the LINK_... vars are also good candidates for a settings.py if that route is chosen..


Yes/no - left right counterbalancing


add ".woff" ".ff" to ignore list


I guess my suggestion would be **no**, then! :smile:  I for one had never heard of such a thing until your question just now.  I see [wikipedia discusses it](http://en.wikipedia.org/wiki/FASTA_format) as a historical thing, but I've not seen one in the wild or implemented in any other software.

One gotcha that I have seen in the wild is

```
> chr1 comment about this chromosome
ATGCATGC
```

Whatever descriptions of FASTA exist are wishy-washy about whether whitespace may appear immediately after the `>` character, and whether the next word (`chr1`) should be considered to be the chromosome name rather than comment.  I thought samtools unhelpfully treated this as a chromosome with an empty name, but it seems it even less helpfully just crashes...

See also [faidx.5](https://github.com/samtools/htslib/blob/develop/faidx.5) btw.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/php-gettext/gettext.inc


Great


minor: why not ``filesearch``, as this is the name of the package?


Standard of documentation for Scala:
```javascript
/**
 * Description of function
 * @param dir What is this
**/
```


In what case is it ``Nil``? Shouldn't if be something like ```if (ls.isEmpty) accumdirList else ...```


Needed? Because of how you wrote ```getallSubDirs```, it seems to me that this ``if`` is redundant. Can you comment?


Why not have used the ``java.io.File.mkdir`` function?


Comment: ``java.io.File``?


see above


added yes/no counterbalancing


See comment on other commit regarding standard syntax


comment: could we have use Collections' ``find``?


Commit's description is not... descriptive ;-)


Test failing:
```javascript
[info] getResult function
[info] - should correctly work for valid directory input *** FAILED ***
[info]   List("Foo\foo2.txt", "Foo\Bar\Bar2\bar2.txt") was not equal to List("Foo/foo2.txt", "Foo/Bar/Bar2/bar2.txt") (SimpleFindTest.scala:113)
```


Maybe you should first mention that "op" is short for "operator" before referring to it repeatedly by the abbreviation? Eg.

    Minecraft comes with a simple way to give permissions: by setting users as operator (or "op" for short)


nice


Yes!


Commit description: saying "``calls all other helpers functions that we have developed so far``" implies that I have to read all commits that came beofre to get a sense of this one - which makes this commit not self-contained.


I'm open to suggestions. I chose 'post' based on it being an instance of the post data returned from the wp.media.model. Maybe postData or postImage would be better?


Thanks, do not take account of this request, I ended up making my own library :
https://github.com/louis49/SocketIO-Objc


Thanks, I will give that a try


请问：，merge了什么内容?


TeamCity Ylab :: synteny/ylab [Build 26](http://192.168.30.225:8111/viewLog.html?buildId=581&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


Thanks. Good suggestions - and yes, I found your troff file very useful. Thanks for that.


Ok cool, will have a think!


Do you have uncommitted stuff in your local copy? If not, you can just clone the repository again. (If I understand your issue correctly.)


Please don't use "my" prefix for fields in Kotlin project.


[High] Still you have some issues with this code. Please read this link: http://en.wikipedia.org/wiki/State_pattern.

You should have something like following:

**PlayListState**
```java
/**
 * Possible actions for our playlist
 *
 */
public interface PlayListState {

	/**
	 * Start playing the playlist. The user can listen music after this action.
	 *
	 * @param currentState
	 *            {@link Context} Current playlist state
	 */
	public void play(Context currentState);

	/**
	 * Pause the playlist. The user stop listing the music, but he can restart
	 * it if he wants from same instant he pause it.
	 *
	 * @param currentState
	 *            {@link Context} Current playlist state
	 */
	public void pause(Context currentState);

	/**
	 * Stop the playlist. The user stop listing the music. The user will start
	 * listening the same song from the beginning if he plays the playlist
	 * again.
	 *
	 * @param currentState
	 *            {@link Context} Current playlist state
	 */
	public void stop(Context currentState);
}
```

**PlayState**
```java
public class PlayState implements PlayListState {

	@Override
	public void play(Context context) {
		System.out.println("nothing to do...");
	}

	@Override
	public void pause(Context context) {
		// you could create an exception (IlegalStatusChangeException for
		// example) and throw that exception here.
		System.out.println("error");
	}

	@Override
	public void stop(Context context) {
		System.out.println("stoping...");
		context.setState(new StopState());
	}

}
```

**PauseState**
```java
public class PauseState implements PlayListState {

	@Override
	public void play(Context context) {
		System.out.println("starting from the place the user paused it...");
		context.setState(new PlayState());
	}

	@Override
	public void pause(Context context) {
		System.out.println("pausing..");
		context.setState(new PauseState());
	}

	@Override
	public void stop(Context context) {
		System.out.println("stoping...");
		context.setState(new StopState());
	}

}
```

**StopState**
```java
public class StopState implements PlayListState {

	@Override
	public void play(Context context) {
		System.out.println("start playing from beginning..");
		context.setState(new PlayState());
	}

	@Override
	public void pause(Context context) {
		// you could create an exception (IlegalStatusChangeException for
		// example) and throw that exception here.
		System.out.println("error");
	}

	@Override
	public void stop(Context context) {
		System.out.println("nothing to do..");
	}
}
```

**Context**
```java
public class Context {
	private PlayListState state;

	public Context(PlayListState initialState) {
		this.state = initialState;
	}

	public void setState(PlayListState playListState) {
		this.state = playListState;
	}

	public PlayListState getState() {
		return state;
	}
}
```

**PlayList**
```java
public class PlayList {

	/*
	 * Current playlist state
	 */
	private Context currentState;

	public PlayList() {
		PlayListState initialState = new StopState();
		this.currentState = new Context(initialState);
	}

	public void play() {
		this.currentState.getState().play(this.currentState);
	}

	public void pause() {
		this.currentState.getState().pause(this.currentState);
	}

	public void stop() {
		this.currentState.getState().stop(this.currentState);
	}
}
```

**DemoPlayList**
```java
public static void main(String[] args) {

		 PlayList playlist = new PlayList();

	    	 playlist.play();
	    	 playlist.play();
	    	 playlist.stop();
	    	 playlist.play();
	    	 playlist.pause();
	    	 playlist.play();
	}
```

**OUTPUT FOR THIS DEMO**

  start playing..
  nothing to do...
  stoping...
  start playing..
  pausing..
  starting from the place the user paused it...


If you cannot commit to 2.0 and master currently, please hold back on committing this to 2.0 unless this is solved. Else we get a state of commits that are not in sync, and will get lost once we release 2.0 and move on to 2.1.


please stop vibrating my crotch people


This has basically the same problem - applying it indiscriminately for every use-case that looks like it *could* be applied to is risky, since these selectors do not easily work in inline-forms or other non-standard forms.

I think it should be considered on a case-by-case basis - if/when there really is a problem.


TeamCity Ylab :: synteny/ylab [Build 25](http://192.168.30.225:8111/viewLog.html?buildId=580&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 125 Build time: 00:12:05
### Failed tests
```
ru.biocad.run.yinfusion.InFusionJobTest.InFusionJob should work with data: class org.scalatest.exceptions.TestFailedException: "...      }
    }
  }
]
[]" did not equal "...      }
    }
  }
]
[    ]"
org.scalatest.exceptions.TestFailedException: "...      }
    }
  }

```


TeamCity Ylab :: zmactep/ylab [Build 162](http://192.168.30.225:8111/viewLog.html?buildId=582&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


Overall though, I like this a lot.  I'm probably going to extend my topology today to make use of the dynamic routing key.

What do you think of using only a single bolt to publish any messages to rabbitmq?  I'll probably do so based upon the stream the incoming tuple is on.


My bad. Confused ``Nil`` with ``Null`` ;-) SOrry about that


This would be a `Number`


Build team reviewed and will make sure fog is updated at build time.


Do we need to validate the properties on these series? Maybe there's something in the series test util that we can use.


We need unavailable blocks so that we can show the reason why it is unavailable, and allow a person to make an individual mapper request. I was trying to stick to a simple boolean for state, but there is a distinction between "unavailable because it it reserved/complete" and "unavailable because of permissions." I think we can style it with two colors, but we need a third state.


I think psiClass should be NotNull here as there're no other usages.


TeamCity Ylab :: synteny/ylab [Build 26](http://192.168.30.225:8111/viewLog.html?buildId=581&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 125 Build time: 00:12:25
### Failed tests
```
ru.biocad.run.yinfusion.InFusionJobTest.InFusionJob should work with data: class org.scalatest.exceptions.TestFailedException: "...      }
    }
  }
]
[]" did not equal "...      }
    }
  }
]
[    ]"
org.scalatest.exceptions.TestFailedException: "...      }
    }
  }

```


Yes, please.

> On Jan 20, 2015, at 9:37 AM, Ben Gould <notifications@github.com> wrote:
>
> One thing, I think that because the methods in the TupleToMessage classes aren't marked protected I can't override them in a subclass that is in a different package. Can I submit a pull request to fix this?
>
> —
> Reply to this email directly or view it on GitHub.
>


```OK MPD 0.18.0
add  http://uwstream1.somafm.com
OK
play
OK
currentsong
file: http://uwstream1.somafm.com
Title: Leggo Beast - Skanked
Name: Groove Salad: a nicely chilled plate of ambient beats and grooves. [SomaFM]
Pos: 0
Id: 16
OK
idle
changed: playlist
changed: player
OK
currentsong
file: http://uwstream1.somafm.com
Title: Leggo Beast - Skanked
Name: Groove Salad: a nicely chilled plate of ambient beats and grooves. [SomaFM]
Pos: 0
Id: 16
OK
idle
changed: player
OK
currentsong
file: http://uwstream1.somafm.com
Title: Omnimotion - Stay Here
Name: Groove Salad: a nicely chilled plate of ambient beats and grooves. [SomaFM]
Pos: 0
Id: 16
OK
```


You are right that we can drop the reference to ``survey``, thanks to the non-normalized  ``is_available`` column.


Maybe we can verify here that the series property is present as well


[High] Is this code compiling?
You should implement *doAction()* and *getDescription()* according with your *PlayListState* interface.
Also you should not @override play, pause and stop methods because they don't belong to your interface.


test this please.


So it seems that metadata changes are considered `player` events. Additionally it seems MPD handles having a station name and a current track title, which we don't :(


Or just 'AeroGear Android 2.0.0 supports Android 4.1 and higher'


Build team has reviewed for release.


This might be better in the CMS app.


This change is backwards incompatible, though no one is probably using it


capital F?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/585
success: http://build.servo.org/builders/linux2/builds/584
success: http://build.servo.org/builders/android/builds/621
success: http://build.servo.org/builders/mac1/builds/802
success: http://build.servo.org/builders/mac2/builds/802


@xfurry
Basic use to load waypoints if from SD2:
[CODE]
diff --git a/ScriptMgr.cpp b/ScriptMgr.cpp
index 8394822..3f64aa7 100644
--- a/ScriptMgr.cpp
+++ b/ScriptMgr.cpp
@@ -37,6 +37,16 @@ void LoadDatabase()
         outstring_log("SD2: ScriptDev2 database initialized.");
         outstring_log("");

+        // Extract DB-Name
+        std::string::size_type n = strSD2DBinfo.rfind(';');
+        std::string dbname;
+        if (n != std::string::npos && n + 1 != std::string::npos)
+            dbname = strSD2DBinfo.substr(n + 1);
+        else
+            dbname = "SD2_Database";
+        dbname.append(".script_waypoint");
+        SetExternalWaypointTable(dbname.c_str());
+
         pSystemMgr.LoadVersion();
         pSystemMgr.LoadScriptTexts();
         pSystemMgr.LoadScriptTextsCustom();
diff --git a/base/escort_ai.cpp b/base/escort_ai.cpp
index cbd8360..03bbc73 100644
--- a/base/escort_ai.cpp
+++ b/base/escort_ai.cpp
@@ -426,6 +426,8 @@ void npc_escortAI::FillPointMovementListForCreature()
     {
         Escort_Waypoint pPoint(itr->uiPointId, itr->fX, itr->fY, itr->fZ, itr->uiWaitTime);
         WaypointList.push_back(pPoint);
+
+        AddWaypointFromExternal(m_creature->GetEntry(), 1, itr->uiPointId, itr->fX, itr->fY, itr->fZ,  100, itr->uiWaitTime);
     }
 }

@@ -497,7 +499,12 @@ void npc_escortAI::Start(bool bRun, const Player* pPlayer, const Quest* pQuest,
         WaypointList.clear();

     FillPointMovementListForCreature();
+    m_creature->GetMotionMaster()->Clear(false, true);
+    m_creature->GetMotionMaster()->MoveWaypoint(1, 3);
+    JustStartedEscort();
+    return;

+/*
     if (WaypointList.empty())
     {
         error_db_log("SD2: EscortAI Start with 0 waypoints (possible missing entry in script_waypoint).");
@@ -535,7 +542,7 @@ void npc_escortAI::Start(bool bRun, const Player* pPlayer, const Quest* pQuest,

     AddEscortState(STATE_ESCORT_ESCORTING);

-    JustStartedEscort();
+    JustStartedEscort();*/
 }

 void npc_escortAI::SetEscortPaused(bool bPaused)

[/CODE]

obviously much of this needs to be rewritten in many details, but in middle-terms sd2 code must become much easier and simpler (ie no need to store the points - they can be directly added to WP-Mgr)


TeamCity Ylab :: zmactep/ylab [Build 162](http://192.168.30.225:8111/viewLog.html?buildId=582&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 125 Build time: 00:12:05
### Failed tests
```
ru.biocad.run.yinfusion.InFusionJobTest.InFusionJob should work with data: class org.scalatest.exceptions.TestFailedException: "...      }
    }
  }
]
[]" did not equal "...      }
    }
  }
]
[    ]"
org.scalatest.exceptions.TestFailedException: "...      }
    }
  }

```


BTW, using this patch I'm able to load somewhat between 700 - 900 million random words from my wordlists before my 16gb ram system without swap errors out :)


@BeingTomGreen, @mackiecarr Same here. Find it more cleaner as well.


Laravel 5 , an infinite add remove commits .


refs #138


Ah, you are right. I see the issue now: since overlays are stored with the common ancestor instead of the node itself, overlays do not affect the SHA1. We could include the overlays in getStringHash, but it gets complicated when you consider inheritance.

I've reverted the commit for now.


You can use StringUtils.isEmpty() here (and other similar places).


Any reason to do this? This puts the example binaries into `build/examples/bin/examples`...


test this please.


I wouldn't object to a configuration options for gzipping.

Since our .js is not minified, gzipping provides much better performance over the Internet.


The plugin is an extension of a basic Sonarqube plugin and they license their code under LGPL. To be honest I'm not sure what to do here.


fast-forwarding master to auto = 94ebc7c3


Space inside parentheses detected.


Line is too long. [112/100]


aprówek


@Alefas not sure about EAP build, but it's definitely in nightly build


But you are the author of these lines, correct?


> I'd sooner see this as a standalone js file, personally.

No disagreement here.

I also like the idea of swapping src images based on manual resizing. Do you think we handle that issue as a separate ticket?


Hi @somayajipraveen
This is the comment thread for a specific commit to our example repository.

Why don't you check out the Appium Bootcamp tutorials posted to the Sauce Labs blog, [sauceio.com](sauceio.com).


No, they have remained largely unchanged from the original plugin: https://github.com/SonarSource/sonar-examples/tree/master/plugins/java-custom-rules


@caesarfeta this change did the opposite of what the original code did ....
(if settings uri_prefix is defined we should use it)


We could do better - on 64-bit arch we now have 8 bytes worth of pointer for each word but using some pointer-fu we could do with just 4 bytes. It might be tricky to do it without a performance loss though.


Why a cast? vrvChord->GetDur() is possible, isn't it?


This is wrong, the 'requirements:' can be removed. Could you fix that? :)


Yes. That is why I suggested to check out the diff branch. There we create a diff-tree which collects all the changed nodes so the event generation is kind of straightforward (and we do not calculate anything on node basis). For the inheritance part we simply notifies all the loaded descendant that they probably been updated because of their ancestor.


Should probably also do the same for the other info files


@chrismullins something in this form might be a bit more efficient and compact.  Though you should double check that it actually works :grin:

    name: Install build essentials
    sudo: yes
    apt: name={{ item }} state=present update_cache=yes
    with_items:
      -git
      -gcc
      -g++
      -make
      -vim

also, why do you need vim to build?


dorobić delay joba do wysylania maili!


Also modify the ./emscripten/build.sh and the ./python/setup.py files


> To be honest I'm not sure what to do here.

There is an e-mail address in that header: contact@sonarsource.com. They should be able to tell you how to use their example code.


Hey, It's unreachable code.

P.S.
Is yamux something You would recommend to use for development now ? Or is there some successor to it in Go?


Are you using the DrawingListInterface?


nit: trailing whitespace


And if I can change the licence to my will, then I should put it under Apache 2?


Indeed, thanks.


On diu "i quimeres impossibles . La il•luminació (...)" hi ha un espai en blanc abans del punt que sobra. I diria que el càracter de la ela geminada (·) no és el correcte.


Missing (not required but I put them):
DurationInterface(), AttStemmed(),


No problem. What's the schedule for a pull request to go into the `master`?


Je vais plutôt ouvrir un ticket auprès de l'académie française.


This section looks wrong.  If == jemalloc than without else  with?  Shouldn't it be the other way around (as the deleted line was)?


That was probably a copy and paste mistake. I'm on vacation this week will but will take a look when I get back. Thanks for reporting this issue. :smile:


Missing (required):
DurationInterface::Reset();
ResetStemmed();


LGTM


Nevermind, I just realized all of them are backwards, not just this one, so the logic is reversed.


You're right.  I was careless. I'll fix this.  One thing you should know though is that the settings object in Sinatra turns the configuration items into methods and not strings.  Why methods? I have no idea. Using a ternary was throwing critical errors.


WOW! that was quick ;)


Szzzz


So gahts besser:
```{rust}
fn is_leap_year(year: u16) -> bool {
 let divisible = (year % 4 == 0, year % 100 == 0, year % 400 == 0);
 match divisible {
 (true, true, true) => true,
 (true, false, _) => true,
 (_, _, _) => false,
 }
}
```
http://play.rust-lang.org/?code=fn%20is_leap_year%28year%3A%20u16%29%20-%3E%20bool%20{%0A%20let%20divisible%20%3D%20%28year%20%25%204%20%3D%3D%200%2C%20year%20%25%20100%20%3D%3D%200%2C%20year%20%25%20400%20%3D%3D%200%29%3B%0A%20match%20divisible%20{%0A%20%28false%2C%20_%2C%20_%29%20%3D%3E%20false%2C%0A%20%28true%2C%20false%2C%20_%29%20%3D%3E%20false%2C%0A%20%28true%2C%20true%2C%20false%29%20%3D%3E%20false%2C%0A%20%28true%2C%20true%2C%20true%29%20%3D%3E%20true%0A%20}%0A}%0A%0A%2F%2F%20This%20code%20is%20editable%20and%20runnable!%0Afn%20main%28%29%20{%0A%20%20%20%0A%20%20%20%20for%20year%20in%201800..2400%20{%0A%20%20%20%20if%20is_leap_year%28year%29%20{%0A%20%20%20%20%20println!%28%22Year%20\%22{}\%22%20is%20leap%22%2C%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20year%29%3B%0A%20%20%20%20}%0A%20%20%20%20}%0A}%0A&run=1


@alexanderdean I've made these strings because of this comment: https://github.com/snowplow/snowplow/blob/ab4c78a3f549826856f56bf625e3e8ec39b5e3dc/3-enrich/scala-common-enrich/src/main/scala/com.snowplowanalytics.snowplow.enrich/common/outputs/EnrichedEvent.scala#L125

Is that right?


I love easy tickets :)


Woops! Those binaries should be in .gitignore. Thanks for the heads up.


done


Shouldn't this be `addFile()` ?


sass-loader is loading from git-repository by purpose till 0.4.x will be stable


@AlwinEsch This would be really cool stuff. Most appreciated.


Why do we need this additional lookAheadCount increase?


Can we have `npm publish`? Thanks in advance! :)


I think I understand what you are saying. Are you talking about an internal sdcard location? If so, recovery /sdcard is set by default to /data/media for internal sdcards, which can be changed... and in regular OS it is located at /data/media/0 so check /data/media or /data/media/Pictures if that is the folder they were in, and then move to /data/media/0/Pictures where the rest are probably located. Then in recovery change sdcard location, in recovery settings, from /data/media to /data/media/0 so this doesn't happen again.

@PhilZ-cwm6 I don't know why but I get a notification everytime someone comments on one of your commits. I don't mind, I'll always help and answer what I can, it is just odd. Plus you may remember, my last time answering one, that I said want to port to build with Lollipop ROM eventually since you are too busy. This is the only recovery I've ever used for my G2 LS980 and I love it. I just recently built 6.59.0 flashable zips for every G2 variant that I build ROMs for, to share with all XDA users using my ROM, from my thread.

If you know anyone who wants one the link is here: https://www.androidfilehost.com/?w=files&flid=24412 and thread for ROM is here: http://forum.xda-developers.com/lg-g2/development/5-0-2-lg-g2-vaniraosp-l5-branch-exodus-t2997402

@ApinkLove I hope that answered your question.


同时删除多余百度统计代码


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1095 of 1095 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I tried using built ins. ``object`` is an alias to ``zipObject`` which takes arrays of keys and values and makes a pairwise object out of them. In the this pipeline we do not have all the keys and values at the same time until the final reduce. I am going to try splitting it into two shorter pipelines.


It doesn't ultimately matter, but this should be `0x0000FC00`.

-[Unknown]


Looking at https://github.com/D-Programming-Language/phobos/tree/v2.066.1/std/container, we should list all container modules here.


This method is badly placed in the classes zone - I'll fix it (it leads to a merge conflict)


Great, thanks!


bcond_with/bcond_without semantic is a trap...
Bcond_without basically means you do have the feature (I try, but I can't get accustomed to this ;-)  )


This commit breaks input handling in all browsers.
See emscripten's `fillMouseEventData`. Pay attention to this line.

    var rect = (target === window) ? { left: 0, top: 0 } : target.getBoundingClientRect();

Now it's executed with `target == document`, with `getBoundingClientRect` undefined.


Ack


I just figured out that I'm watching this repo, which is why I am getting notifications... LOL


LGTM


Thanks Dinesh and sorry for that.


It was added more recently by @ranjith-r (https://github.com/projectkudu/kudu/commit/38ba727b9063497909fdb3a16696d9469fbaa63d). I think the idea is to make non-formatted xml files more readable. But in this particular case with comments, it behaves poorly and makes it less readable. Conceivably the beautify logic could be tweaked to not add a new line in this case.


Это ты скопировал или сам написал?


TeamCity Ylab :: Feodorov/ylab [Build 59](http://192.168.30.225:8111/viewLog.html?buildId=583&buildTypeId=Ylab_FeodorovYlab&guest=1) is now running


I'm sorry, but I think this shouldn't be in the default ranger. This feature is kind of a dirty hack in the first place, so I kept the pattern matching as strict as possible, to at least avoid false positives.

I would instead recommend you to use a plugin for this, where you override the hook_command_preprocessing method of the fm.rifle object or the Rifle class.

You need to pull the latest git version though - previously you needed to override the function *after* ranger overrides it, making it a little complicated. Like, you had to hook ranger.api.hook_ready first, then add some code there that overrides rifle.hook_command_preprocessing with your customized function. Now you can hook rifle.hook_command_preprocessing directly.


Yep correct!


TeamCity Ylab :: zmactep/ylab [Build 163](http://192.168.30.225:8111/viewLog.html?buildId=584&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


defrgrh


@tjora. Thanks for this refactor. I would ask in future that these two changes, the possible leak and the re factor be two different commits. Makes it easier to see what is going on.

Thanks

Stu


Cool


Try running composer self-update to get latest composer. Then try again


Oops, I published it to my private registry 😁 it's live now. Have fun!

On Tue, Jan 20, 2015 at 4:45 PM, Sijawusz Pur Rahnama
<notifications@github.com> wrote:

> Can we have `npm publish`? Thanks in advance! :)
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lwille/node-gphoto2/commit/ba9a9b91a0401ac3711c8e41505c0b2c487b42c7#commitcomment-9358303


When you say single bolt, I assume you mean parallelism hint of 1? We have topologies which make use of RabbitMQProducer in bolts with parallelism hint as high as 64 or 128. Just make sure you RabbitMQ cluster has enough resources to handle it.

> On Jan 20, 2015, at 10:13 AM, Ben Gould <notifications@github.com> wrote:
>
> Overall though, I like this a lot. I'm probably going to extend my topology today to make use of the dynamic routing key.
>
> What do you think of using only a single bolt to publish any messages to rabbitmq? I'll probably do so based upon the stream the incoming tuple is on.
>
> —
> Reply to this email directly or view it on GitHub.
>


You can check up on the current queue here: http://buildbot.rust-lang.org/homu/queue/rust


We should quote `t*` as it would be subject to glob expansion, right?  If this script is run from `/` wouldn't it expand to `/tmp`?


Also quote `$VG`?


This results in an error using clang on OS X:
```
path/to/RIOT/sys/vtimer/vtimer.c:44:58: error: only weak aliases are supported on darwin
void _gettimeofday(void)           __attribute__ ((weak, alias("vtimer_gettimeofday")));
```


This is effectively removed in a later commit. Was this the intention? Or just due to the change on master accomplishing the same thing.


LEADING_ASTERISK is optionally followed by TEXT(" ") and then followed by TAG_NAME


Hi,你去看一下控制台CTRL+SHFIT+J。有一条error：ReferenceError: can't access let declaration `lastTab' before initialization。


Right now, you call_user_func will always be called when send is called. Previously that was only once.


Hi,

you need to set "is modified" to false before the foreach loop. If you modify at least one value, "is modified" should be true. And only in that case you need to write the expiry.php. $this->IsModified doesn't have the right value for that check.

Best wishes,
Georg.


it silences warnings about unused variables.


Given the way that getValue is implemented the if is superfluous as the same condition gets checked in getValue


I tried out what I suggested in a Node.js REPL, and I'm pretty sure it will work.

`_.object` replicates your `objAddKVArray` reduce function, and then *aftewards* you can map *just* the values with with `contentToFunction`, which works because `transformKVValue` only changes the values of your pairs.


Just tried to link Alfred and noticed this has been taken out. Just wondering what the reason for this is?


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1938](http://teamcity.monogame.net/viewLog.html?buildId=5007&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


No it shouldnt.


@brunofarache with this change we're breaking the API. Liferay Screens Beta2 is not compiling with this version of SDK!


    // Apply timestamps that have been added or modified in this process
        $isModified = false;
        foreach ( $modifiedTimestamps as $name => $value )
        {
            if ( $value > self::getTimestamp( $name, 0 ) )
            {
                $this->setTimestamp( $name, $value );
                $isModified = true;
            }
        }

         if ( $isModified )


I suggest to meld this commit with previous one.


r+


Thank you sir!


@sambeckham Alfred will now work with homebrew-cask [out of the box](https://github.com/caskroom/homebrew-cask/issues/8052#issuecomment-69560606). You may still need to add `/opt/homebrew-cask/Caskroom` manually, though, depending on what your version is, and when you installed it.


milliseconds


We can change this to make it use oo_bind_ip so we would not stick to ec2


Isn't it too late for a rebase?


We can change this to make it use oo_bind_ip instead of factor_ec2_public_ipv4 so we would not stick to ec2


__apiary.manifest contains reference to non-existent file in repository.__ (Autogenerated message from apiary.io)
+ writer_follows.apib


It's a constant.


nie ma juz tego parametru


nl.getValue only checks if o is the null sentinel and if not, it returns o as is. However, o can be a completed sentinel or an error sentinel. I didn't use hasValue to avoid two volatile reads which might get two completely different kind of a value.


this is an attempt to add new file to repo that been fork from others


Thanks as usual, useful :-)


Haha! Thanks. Hope to make many more commits so we can reach our desired goal :+1:


Why 8 instead of 16?


## This is a markdown file


gem 'rails-erd', github: 'ready4god2513/rails-erd', branch: 'rails-4.2-support-fix'


TeamCity Ylab :: Feodorov/ylab [Build 59](http://192.168.30.225:8111/viewLog.html?buildId=583&buildTypeId=Ylab_FeodorovYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 122 Build time: 00:12:04


TeamCity Ylab :: zmactep/ylab [Build 163](http://192.168.30.225:8111/viewLog.html?buildId=584&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 122 Build time: 00:12:00


Ideally this should be split into two commits: one for the managed document refactoring and one for the whitespace changes. Try to keep commits small and focused on a single feature/fix.


favicon değil de icon olmalıymış :(
http://www.w3.org/2005/10/howto-favicon


@Hywan We have a problem here with phpenv when it's running below 5.4. Since `Core.php` and `Central.php` are included every time from composer's autoloader, this is failing with the invasive call to `exit()`. Can you think of another implementation to avoid this? Like checking `PHP_VERSION_ID` in Core's `__construct()`?


maybe try this way?
require 'rails_erd'
require 'rails_erd/domain/attribute'

module RailsERD
  class Domain
    class Attribute
      def primary_key?
        @model.primary_key == column.name
      end
    end
  end
end


I see two advantages of wrapping the Iterator in a method:
* *Semantics:* I wouldn't expect a rectangle to be iterable per se or see the Iterable interface in the class hierarchy. A dedicated method also clearly indicates what it's about.
* *Flexibility:* Wrapping it in a method allows us to provide alternative implementations (e.g. one that supports collections) and parametrization (e.g. alternative iteration directions).

About compatibility:
* Currently only 2 methods use the Iterable interface in engine/Core. I found 2 more in the modules. This should be easy to adjust.
* A few other interfaces/classes such as `Region3i` also implement Iterable directly. I'd also wrap the functionality in a method for same reasons. This takes some effort but would make the API consistent again.

Why would be the advantages of `Rect2i` implementing `Iterable` directly?


Fix for compilation error


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1095 of 1095 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.89%25-green.svg)


Can we create partials for pieces of this? The date has nice calendar styling elsewhere, and we show title/group name elsewhere with this same styling.


Makes sense. Thanks.


Isn't this link going to be dead in a couple of weeks?


I think this should be `mapModule` since it's not a constructor.


This is a markdown file.


invokeActions() call added to enable triggering of action widgets.  For some reason, action widgets placed immediately inside a select widget are not immediate children, so this requires progagation of the trigger event to at least the next level in order to work.


## This is a markdown file


@btat See https://github.com/dzone/osqa/issues/81#issuecomment-70673249 for a possible fix to use latest markdown.


this looks like a reasonable commit, but please don't put -1 in the class codes array like that, add a macro, like IRQ_SUBCLASS and define it as -1, so we can easily understand what its doing.


I would prefer `boolean KeywordOption.isKeywordCharacter(char c)` as the test function of characters, so no option listeners and cached values were required.


某人的qq邮箱地址，read the fucking Manual


Hmm, that's true, nice catch. In my use case I'm willing to accept that compromise because 99% of requests to my application will not send an email. So for 99% of requests I will never need to autoload many of the Swift_Mailer classes. Then for the 1% that do send email I'm willing to accept the small perf hit to recreate the object on each call.

I'll profile at some different levels of usage and see what the perf hit is.


Stimmt, da war ein Logikfehler :) Das letzte kannst du zu `_ => false` vereinfachen. https://github.com/dbrgn/projecteuler/blob/master/rust/19.rs


r+


rax retry tests


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1938](http://teamcity.monogame.net/viewLog.html?buildId=5007&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 366, ignored: 6 Build time: 00:15:50


Like I said earlier, due to https://bugs.gentoo.org/show_bug.cgi?id=492372, please use
`use fortran && export MAKEOPTS="${MAKEOPTS} -j1"` instead.


I guess it's fine for us to rely on the order of the json-ized keys.


You could always implement this handler manually in your application, instead of the other one. That would solve your problem for now.


We can assume ascending order as a default and not require a +, just leave it optional.


No problem with any of these changes.


IdeaVim operates on Unicode characters, not ASCII ones. It would be better to switch from ASCII to Unicode in all the names and comments.

It's fine to treat all `'\u0100'`+ characters as keyword characters for compatibility with Vim. Special Unicode ranges that require their own word splitting rules like Japanese Katakana are handled separately.


This file shouldn't be added to GH repository


Oops, yeah.


Haha. Sorry I didn't know about that re-factoring issue with file names but it won't happen again :)


事实上很多函数的写法都不规范……编译不过的原因是因为我没更新vcxproj


:)
> On 20 Jan 2015, at 17:14, Tom <notifications@github.com> wrote:
>
> Haha. Sorry I didn't know about that re-factoring issue with file names but it won't happen again :)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/CCI-MIT/XCoLab/commit/d80bb7e13047ce7d14b721de9985650dff9a7940#commitcomment-9358904>.
>


Why is `java-pkg-opt-2` needed? Is there are a `use && java-pkg-opt-2_src_prepare` missing?


No need for spaces before import


nice job


should be on English


Thanks mate, keep it up :)


Je vous en prie.


some other people trying to solve this problem:

https://github.com/segmentio/go-env
https://github.com/kelseyhightower/envconfig

also @dfuentes took an interesting approach in moredis: https://github.com/Clever/moredis/blob/master/cmd/moredis/main.go#L72-L83

I see two recurring problems at play that I have yet to see good solutions to:

1. Which parameters of a program should be environment variables and which should be flags?
2. How do you validate the parameters a user passes to a program (coerce into types, check certain values are non-empty, fallback on defaults, print useful feedback to the user, etc.)?

If the answer to (1) was "all parameters should be flags," then the answer to (2) is obvious: use the `flag` package. That is certainly not the answer to (1), so my sense is that the true answer to (2) lies in some `flag`-like package that has consideration for environment variables.


This test fails on master, succeeds here


Kannst du mir bitte die Berechtigung zum Ändern von Tags (+4) geben.

Die Meldungen (`$msg_ok` und `$msg_err`) mache ich extra, weil ich das über den `RISBaseController` erledigen will, damit man das nicht jedes mal wieder hinschreiben muss.


What do you mean "too late"? You expect too many merge conflicts?


usually space between ',' Map<String, String>


I think the problem seems to be that we're not checking whether `MCS_read_socket()` has succeeded.  I think that `MCS_read_socket()` is supposed to return some message if it fails.  Can you see if the problem is if `MCS_read_socket()` should be setting a message but isn't?


Name of the class as usual


should be consistent with previous line: order of keywords should be the same


[High] This shouldn't be part of this class. This is part of *Offer* but not for *AbstractProduct*


Is this complex pattern really required? You parse the string more thoroughly later anyway.


Pull out a local `LogEntry* log_entry(mutable_contents()->mutable_entry())` to reduce lines a bit further?


space `adAdapter = null` .
What does "adAdapter" mean? The name is not descriptive enough.


@ccreimondo  public.js is valid, main-dynamic.js has been deleted

@liuxiaohao  刘总没有屯，一次性改的。。。。


I didn't think ecdsa.PrivateKey implemented crypto.PrivateKey though I
could be wrong.

On Tue, Jan 20, 2015, 5:41 AM kalloc <notifications@github.com> wrote:

> why not crypto.PrivateKey type?
> we can use crypto.PrivateKey, it's more readable.
> http://play.golang.org/p/u_gL1OBVQ3
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pki-io/pki.io/commit/3ddf80fc28dd56a348bef36ad76a98ff7c23c03a#commitcomment-9356000>
> .
>


attributes names in SQL tables are usually lower cased


same as before. why not just `id`?


Thank you :)


Why do you use `Enumeration` instead of more conventional `Iterable` and `Iterator` here?


fixes #228


better to move it to initialization a few lines above


It's actually `toUnicode()`.


docString instead of docstring?


Are we against using :=? If so i can change it.

On Tue, Jan 20, 2015, 5:43 AM kalloc <notifications@github.com> wrote:

> so much ":="
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pki-io/pki.io/commit/3e4bee2a7d9f8ecf7c073b7cfef2ded53bad235c#commitcomment-9356022>
> .
>


In my playbook, I need to start and enable service rpcbind and nfs-common first. Why don't you need this here?


Even after doing this my build wqa ruined with no audio functionality, even random reboots due to WiFi


:+1: Hadn't realised this. I knew there'd be a reason though. Thanks for clearing that up.


I think when a header file use URHO3D_API macro, it is better includes urho3d.h.


Why?


Why change this?


eeew:
```sh
% ls ~/.go-ipfs/
000059.ldb  000062.ldb  000065.ldb  000072.log  LOCK     MANIFEST-000067  datastore/
000060.ldb  000063.ldb  000069.ldb  000073.ldb  LOG      config*          logs/
000061.ldb  000064.ldb  000071.ldb  CURRENT     LOG.old  daemon.lock
```


good catch! :+1:


Wasn't this removed in another commit?


This closes the dictionary opened at line 106 (containing 'memory_slice').


Do we want allow setting status to anything?


I'm not sure that this is the default value in Vim. It would have made Vim to treat extended Latin characters as punctuation / word separators.


space


This closes the list opened at line 98.


This closes the dict opened at line 92 (containing 'timestamp').


I've removed this commit since it's of little use.


Start date is an optional parameter while creating a relationship.So if start date is empty It's not necessary to validate whether it is date in future or not  :-)

am I correct ?


In Debian services are automatically started after installation. What OS did you use? Also, I don't know, it just works. :-)


This closes the list opened at line 82.


It's not a button element anymore


should be moved to the constant of receiving activity: EXTRA_NOTE_NAME


This closes the dict opened at line 72 (containing 'time_slice_usecs').


NN not descriptive


Won't the removal of the above ```if (result.empty())``` lead to a crash on this line when an empty Ref<Result> is dereferenced?


No, thank YOU. I really have no idea what I’d do without your help.


you didn't put the `&& st->declaration != DECL_CLASS` check back here, did it only apply to D?


Yes, It's possible — http://play.golang.org/p/05Wk1InW6q


Perhaps `ttl` should be a configured in `settings`?


I would prefer to shorten the directory name just to "player", so it is "model/player/" instead of "model/playermodel/


why do you need writable database for reading?


O_o 我什么都没看见


Why not `uid_t`?


Unexpected code for commit with message "fix tests" :)


* 0.14.2-SNAPSHOT does not seem to exist in central. use 0.14.1
* rc1 is outdated now, use "1.0.0"


tab missed


Fucking mess


Ah okay then yes that will make things much cleaner. I will try to make the
changes asap.

On Tue, Jan 20, 2015, 8:24 AM kalloc <notifications@github.com> wrote:

> Yes, It's possible — http://play.golang.org/p/05Wk1InW6q
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pki-io/pki.io/commit/3ddf80fc28dd56a348bef36ad76a98ff7c23c03a#commitcomment-9359149>
> .
>


yes this line is not at all required :) i will remove it in my next PR :)


This is not equivalent. Consider OpenDict/CloseDict and OpenList/CloseList as paris, and they must be balanced. The JSONFileWriter is smart enough to take care of doing this on its own (it will pop off the structure types from the stack and emit appropriate close tokens when the file is closed), but explicit code is better than automagic code.


For safety, better not to give this a default.


Fix the links in gh-pages branch also.


capitalized with the underscore should be only constants


@rdlowrey this has already been fixed in https://github.com/kelunik/artax/commit/d5f2454bdeb0511eaf94bc8c505131ed476866c0.


Should be moved to EXTRA constant


回到顶部图标路径为source/img/scrollup.png


مبروووك :D


Zemljevida ni pobarvalo, ker so se pri uvozu iz XML pojavili odvečni presledki pred imeni zveznih držav. Da rešiš ta problem, bo najbolje, če prirediš funkcijo `stripByPath` tako, da v uvoženih podatkih pusti samo zaželene znake:
```R
stripByPath <- function(x, path) {
  unlist(xpathApply(x, path,
                    function(y) gsub("[^[:alnum:], ]", "",
                                gsub("^\\s*(.*?)\\s*$", "\\1",
                                gsub("^(.*?)\\[.*$", "\\1",
                                     xmlValue(y))))))
}
```


shouldn't be added to GH


Why is adapt written so strangely? :1234:


True what @Phr33d0m says, but keeping old stuff helps sometimes, like old way select assets showed what was missing from new way (what is really better)... and anyway script goes way what serve best, ;).


All these comments are now made obsolete by another commit.

Sent from my iPhone

> On 21 Jan 2015, at 12:21 am, aster2013 <notifications@github.com> wrote:
>
> I think when a header file use URHO3D_API macro, it is better includes urho3d.h.
>
> —
> Reply to this email directly or view it on GitHub.
>


refs #138


Message: Some of these messages were made to be human-readable and are vague. While, some messages passed in are directly err.Error().

MessageDetails: This was added so that we have a human-readable message and also whatever err.Error() said.


proba


Yes, it makes code more readable than without type.

In go1.4/src:
y@y src $ ag --go -R ' := ' ./ | grep -v github | grep -v test |wc -l ->  18272
y@y src $ ag --go -R ' = ' ./ | grep -v github | grep -v test |wc -l ->  59072

also you can use := for next statements:
smth_size := len(smth)
or
smths := make(Smth, ...)

We can understand variable's type.


增加首页文章显示字数


This breaks layout for me in Firefox, I've added a ticket to re-implement this #31


I like this refactor.  The `files` module is especially nifty.


Update: this line has been removed in some later commit.


    width=(int) viewBox[2];
    height=(int) viewBox[3];

Should be apply only if the width and height are 0 (if not provide).


fixed thx


Oh good call, thanks!


thisImagePost maybe?  Unsure.  I'm fine with any of them, just think something a bit more descriptive would be good.


solrResponse 需要用到在 audio_file 里定义的　Music, 因为 solr 会返回　score 字段，用来判断匹配是否有效


@jmnavarro Why do you want to access the commands property, can you point me to the code?


Yes, I moved the static method from JetQuickDocumentationProvider here and updated it according to new PSI structure.


Go ahead and restore these (and make them consistent)


Yes, @dzuelke is correct. However, in the java buildpacks I'm going to increase to 5120mb. I'll submit a PR here.


we should have nginx send nerdy headers haha


Good point; we need to track leader status so we don't interfere with followers' candidate timers. I'm not as concerned about the cost of sending heartbeats when we're not the leader, but we should avoid fanning-out heartbeat responses when we're not the leader.

I think we should still send explicit heartbeats instead of relying on gossip because the gossip network doesn't give us reliable propagation time and it can't detect network problems that only affect certain links in the system.


As the name of this method suggests, the method used to "maybe" return a result. Either returning an empty Ref<Result>, or a Ref<Result> pointing to a Result object.

Changing this method to throw an exception seems to fundamentally alter the intent of the method such that a result is always returned (or an exception is thrown). However, exceptions are for exceptional circumstances and not really the same as "maybe" returning a Result.

I think a better solution would be to simply change ```MultiFormatUPCEANReader::decodeRow()``` to check if ```result.empty()``` is true (and ```continue;```) before trying to dereference the pointer (i.e. use the Result object).


Yes for now it is. Small objects will likely have a stable order, otherwise the unit tests will have to be changed like `[o.fall,o.one]`, I did that in some other places.


No, there should be always a result or a exception.
UPCEANReader::decodeRow line 159


@thejameskyle In looking to make some REPL enhancements/fixes, I refactored the code to make it easier to understand and better separate concerns.  While this was for me initially, I think this could be a valid refactor for master.  Thoughts?


https://github.com/liferay/liferay-screens/blob/master/ios/Library/Source/Base/BaseListScreenlet/ServerOperations/LiferayPaginationOperation.swift#L54

Maybe it's not the best idea (I agree that array should be private) but if it was in the interface and then it's removed, some users could be using it also.

What about adding "commandsCount" readonly property? It makes sense for me to query the number of commands inside the batch


为什么不直接　`infos <- result` ，而还要在中间加个　`results` ?


BAM! =D


What version(s) of Ember are you targeting and testing with?  I wrote this as I did to account for an internal change with metal-views in how args were passed to the helper.  We might need to be a little more fancy in finding the correct options hash to be able to support all versions of Ember.


I suggest a pmmgr-based alternative for this (untested sketch follows).  A single .service, running

ExecStart=/usr/libexec/pcp/bin/pmmgr -c CONFIGDIR
Restart=always

and under CONFIGDIR, plop:

CONFIGDIR/pmlogger:                    -T 30min -c CONFIGDIR/pmlogger.conf
CONFIGDIR/log-directory:               /var/log/cockpit/archives
CONFIGDIR/pmlogger.conf:            log mandatory .... { } ...
CONFIGDIR/pmlogmerge-granular: (empty)
CONFIGDIR/pmlogmerge-retain:     2hours

then you'll start getting rotated/aged archives under
/var/log/cockpit/archives/HOSTNAME/archive-YYYYMMDD-HHMMSS.*

(Coming in the future, temporally-downscaling on older archives.)


I would prefer to go over pull-requests on core packages. In this particular case e.g. I would have argued that the change should be in the logger, since I see no reason to have the semicolon there in the first place.


Why change to public ?


@jk you must use tagged versions (~0.*) or (~1.*) on finalized library.

Theses versions still supports php 5.3 but on dev-master and future versions, hoa will supports php >= 5.4


Opozorilo za `NA` se zgodi zaradi črk na koncu časov v tej datoteki (4 pojavitve). Drugod ni teh problemov. Lahko bi sicer poskrbela, da ti iz časov pobriše vse črke, a bo lažje, če jih enostavno pobrišeš v podatkih.


这一行是不是要放在　`for _, infos := range infosc ` 上面，如果放在内部的话，会多次调用。


sine rehashidx is signed int, it means that the hash table in redis is not currently allowed to grow over 2^31 entries.
so i can safely make my index signed and fix the signed/unsigned comparison problems.

on the other hand, i wonder why rehashidx is an int (32bit) while dictht->size is long (64bit).
i suppose both should be changed to signed (signed) long?


why is this needed ?


Given that the ```bytes``` array is thrown away, it would seem to me that an array is not required at all. Instead the assignment to ```bytes[i]``` could be replaced with a local variable declaration/definition. I'd prefer to remove the unnecessary array altogether instead of just fixing the memory leak.


removed in the last commit


Line 1072 is still required, as we pushd into two locations and need to popd back out of both of them.

First we pushd into the MBAM directory within Tron (line 1072), then we later pushd into one of the two program files directories to execute MBAM. Then we popd out of the program files dir (line 1083/1072), then finally we popd out of the MBAM directory back to Tron's root (1087/1076)


why?


If a seperate ticket, we'd have to wait for this one to merge in first.  I'd be fine handling them both in one, but it's not my call.


Why is this needed ?


I've left it in case somebody wants to use it on a button but… that's an edge case so I'll remove it.


You could try to get the 'default' for the body parameter. That would be the closest thing to a request example in swagger I could think of.
Example:
```yaml
parameters:
        - name: body
          in: body
          required: true
          schema:
            default: "{id: 'okman'}"
            properties:
              id:
                type: string
```


I don't really like the interface of this function. It saves a buffer allocation and couple of copy operations but will probably confuse the next person who'll read it:)

Also, making it something like `dump_fd_info(const char *dest_filename, const char *source_dir)` would allow you to fix the *TODO: BUG:* by using `opendir`+`readdir` on the `source_dir`.


m <- NULL
  set <- function(y) {
    x <<- y
    m <<- NULL
  }
  get <- function() x
  setsolve <- function(solve) m <<- solve
  getsolve <- function() m
  list(set = set, get = get,
       setsolve = setsolve,
       getsolve = getsolve)


`fingerprint.go` 这个文件不需要了，其功能由 `audio_file.go` 和 `querySolr.go` 取代。

`getFingerPrint` 应当改为 `AudioFile.getFingerPrint`


That's not necessary -- I changed build-go.sh to create the symlinks.  Everything should be good on travis now; the last build timed out.  Going to kick it.


What editor are you using @Atemo ?


Yes. I will added since I have a moment. The 'only' keyword is only for javascript files. Maybe I need to improve the keywords to see for file extension.


> I think we should still send explicit heartbeats instead of relying on gossip because the gossip network doesn't give us reliable propagation time

`reliable propagation time`: you might get a high confidence about the converging time, but it would depend on the gossip implementation.

> and it can't detect network problems that only affect certain links in the system.

This is a good point. If you are not concerned about the extra cost, heartbeat definitely provides a more clear and simple failure model.

So it is reasonable to just use heartbeat.


Maybe mention here, that it automatic register itself as rspec extension. Also example usage was nice, just remove registration and it will be fine


So much wasted space...


Here too


This line is super long


s/Maurico/Mauricio/


I was about to write a bugzilla on this crash that I am also seeing, but noticed here that it had already been fixed. However, the fix is not in the 3.6.2beta2, or anything else! This bug was fixed just before 3.6.1 was released! Is the fix ever going to show up an any of the release branches? Thanks.


Contrary to the behavior of httpBackend with numeric timeout, the actual $http DOES trigger the error callback.
Keeping the unit test as listExtractionFactoryHTTP.js


Aquí se lee mejor en dos niveles:
```
if 'value' in result:
   if 'bom_id' ...
       ....
   if 'routing_id'...
```


creo que se leería mejor si cambiamos ", puede" por " puedes" (sin la coma)


Por otro lado, seguro que interesa eliminarlos siempre?


He ido añadiendo código y he hecho copy-paste sin pensar


hmm, more FALSE that needs to be false

I can't seem to keep these darned things down...