You can ignore everything that has to do with "virtual" channels, they're destined for removal any day now.


nerd


What's the point? Do expect allow_url_fopen to be disabled on localhost?


LGTM


Some strange typos here, I don't even know what these variables are supposed to represent?


Hi Alexander,

I'm AMO, not GitHub reviewer and make review add-ons uploaded to AMO. See
instal.rdf file from add-on uploaded to AMO. Where you see <em:type>?

Also I forgot write that <em:unpack>true</em:unpack> is redundant. This is
use for bootstraped and .jar packaged add-ons.

Regards
Leszek Życzkowski
AMO Reviewer

2015-01-27 8:10 GMT+01:00 Alexander Salas <notifications@github.com>:

> Addon Type 2 missing, review by @teo951
>
> Adde Multiprocess Compatible
> Don't have binary files.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/alexsalas/instantbird-protocol-p18x/commit/2492a88e63d646b39865d035b5a22c60a1815a71
>


You can simplify the code by writing
```objc
return ext;
```


Yes...fixed in cb3fd4cb1d7046fef1316f9c7e019e2593a21e86. Thanks.


If you make a `FieldCache` class as described above, you can probably make these private helper methods into instance methods of the `FieldCache` instead.


Same as fields: make a `MethodCache` class.


Why not `Map<Method, Class<? extends SciJavaEvent>>`? And why not make that an `EventCache` class?


Most probably you don't want to do this.

If for some reason you want to commit your settings.coffee to git repository, you can always use "git add -f settings.coffee". But not ignoring it by default means you or someone else will accidentally add and push it to public git repository.


комменты не надо коммитить. всегда можно посмотреть через git diff


Why add a deprecated method? :D


Awesome, any chance on updating the gem as well?


Seeing these `return null; // reason why` comments makes me uncomfortable, since that information cannot be harvested. Makes me want to write an annotation processor for `@EventHandler` that actually fails the build if an `@EventHandler` is attached to an unsuitable method. Maybe some day!


Indentation.


Well, the codes are generated only once and the adminoptions table is surely not big on any forum, the only problem is that they're inserted serialized to the database.

But do we even need 10 recovery codes? I mean, who saves them all and what for? I never understood why the sites provide 10 short instead of one or two longer. Doesn't it make it less secure since you need to enter only one code anyways?


Ah oui il ne faut pas mettre le -g si tu veux qu.elle se rajoute dans le package.json


What's the problem?


4.9.3 툴체인을 이용하지 않으시는 이유가 있으신가요?


Note: We want to move our spi code for the radio(#2329) to kinetis_common and also continue to use hardware-CS (I want to enhance it with dma soon). It would be nice, if we could share the code of RIOT-spi and there would be a possibility for use the hardware CS.


@fernandog
lets have that talk here https://github.com/Razzeee/script.trakt/issues/24


Fixed in f03ab7c6


@Quintus We only think that the space is a German thing because it was a very popular mistake on the German subforum. :P

Also, I forgot the `-x` option when I cherry-picked the man page changes. :(


https requires `extension=php_openssl.dll` which is not enabled by default


Travis complains about the wrong alph. order, though.


I've simply used 10 as it's what other sites use too. Changing the number or the length isn't difficult, we only need to remember to change the size of the database column. Also the query wouldn't be that difficult: `where recovery_codes LIKE '%"{code}"%` should work.


Is the empty line necessary?
What if extension would be nil? Do you want to have null in file name?


TeamCity OsmSharp :: GitHub - OsmSharp [Build 938](http://build.osmsharp.com:8080/viewLog.html?buildId=4187&buildTypeId=bt16) is now running


should probably be LUA_NUMBER_INTEGER not INTEGRAL


TeamCity Toolbox :: Pull requests [Build 17](http://10.48.34.86:8111/viewLog.html?buildId=2187&buildTypeId=Toolbox_PullRequests) is now running


TeamCity Toolbox :: Pull requests [Build 17](http://10.48.34.86:8111/viewLog.html?buildId=2187&buildTypeId=Toolbox_PullRequests) outcome was **SUCCESS**
Summary: Tests passed: 102 Build time: 00:00:16


It comes from the spec.


kk


I have made a RCT1 ride type enum for you. You can place it in rct1, will be helpful when we come to converting RCT1 parks too.

https://gist.github.com/IntelOrca/2916cb22f9dd21dd1bdb


Duplicate :)


TODO : valeur par défaut (toolbar = null) pour pas avoir besoin de le spécifier


あれ、ここって、バージョンが0と1で2回取得してきてるけど、
ansに1回入れるだけで大丈夫？


Just to warn you about the commit comment : this fix has nothing to do with casting.


It for this input:

![](http://cl.ly/image/280k1i2a280E/Image%202015-01-27%20at%202.14.45%20PM.png)


Take a look about application.js added commented line:
https://trello.com/c/YHyKKFhk/11-fix-date-format-for-calendar


we might need to add here the "-v, --volumes=false    Remove the volumes associated with the container" option as an input param...


fix indention


great fix


Does not matter, security is more important than comfort. Application source-codes are very sensitive information. You can fallback to HTTP and print warning if openssl is not enabled.


this macro name is from elua core, have many LUA_NUMBER_INTEGRAL in the code, so we just inherit it.


あ、ここで追加してくれてたね、ありがとう。

でもこの書き方だと、長いし、versionsの値をもし変えたら動かなくなるので、
for文で囲ってくれると嬉しいです。


「はい」のボタンがwarningと同じ色だとポジティブな印象がしないので、デフォルトの色で良いと思います。


Why this empty line ?


My preference is less indentation. So:
```
if (eventHandlers.isEmpty()) return subscribers;
// additional logic here; no need for an else
```


Right, I should indeed do that.


Right. I'll restore it


Published to http://vui-docs-internal.s3-website-us-east-1.amazonaws.com/30_bad637d0201f37ff9e26884c7a6accb0227a3c83


True dat. It was copy-paset. @warps? :trollface:


It would suffice to write
```objc
if(!_fileName) return _fileName;
```


Delete this empty line


Done at 1bc30b1


I think it was fixed in next commits, because I talked about it with @warps. Please check if it is currently fixed and then I can accept this commit:)


code looks great - lets remember to chat about best practices and formatting. thanks!


I don't think this works on Python 2.6. Views were introduced in Python 2.7 I believe. A simple shallow copy might also do the trick?


I don't want to pay attention to this branch now, it is closed by https://github.com/nette/sandbox/commit/3fbb10671ec24e236dc3a5300e49e6f364657bf5.


Yeah, that looks better!


Actually, this entire patch would be ~2 lines or so if you do it my way. :wink:


just quick fyi, typo above:

<+3. Make shure you have six and requests installed.


instead of commenting all of this out - lets just delete it - git will have all of this if we ever needed to revert it.


please use modern syntax like
```objc
fileAttributes[NSFileSize]
```


In the line above, did you want to say "its child"?


Because we're deleting things like the attachments when moving to the db, I'd consider this not a full `XFormInstance`... It really should be it's own doctype to make things absolutely clear.


漂亮的更新


Thanks for that, good catch. I'll have to add actual tests for the different cache guys to hopefully avoid small mistakes like that.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.3.0.938](http://build.osmsharp.com:8080/viewLog.html?buildId=4187&buildTypeId=bt16) outcome was **SUCCESS**
Summary: Tests passed: 505 Build time: 0:0:0


Can you also localize this?


Can you also localize the exception message?


makes sense, thanks.

On Tue, Jan 27, 2015 at 3:25 PM, Biyeun <notifications@github.com> wrote:

> Because we're deleting things like the attachments when moving to the db,
> I'd consider this not a full XFormInstance... It really should be it's
> own doctype to make things absolutely clear.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dimagi/commcare-hq/commit/000f2209490a2e6f17ae63494c611f2a70684608#commitcomment-9458793>
> .
>


ちなみに僕は、スワップファイルを作らずに、.vim/backupとかに保存するたびにバックアップを保存する設定にしています。
簡単なバージョン管理的な用途にも使えるのでおすすめです


Commit message has minor typos.


the maintainers have been quite busy :S


a fair bit of it is, but I want to eventually remove the other pillows from the indicator app, as it's really not an hq but mvp specific thing


Good Job!


just quick fyi, typo above:

< +3. Make shure you have six and requests installed.´


hmm, yes I like that idea. I will implement as a url param now...


Fixed here: 6df9749f


Hi there, It seems that apache commons is adding break lines (CLRF) on strings exceeding org.apache.commons.codec.binary.BaseNCodec#MIME_CHUNK_SIZE (76).
Maybe the guava implementation is better here ?


when running the pillows `IndicatorDocument`s were saving to the wrong db


Hey @dstendardi - sure thing, we are including Guava anyway so can use that if you think it's better...


just delete all these commented lines same for the ones down below as well


This is much less DRY than before. couldn't this be consolidate with lines 349-355 above, into a common helper method? Or am I missing something?


Again, why is this code repeated from lines 430-436 above?


i see - but you didn't get to the bottom of why that was the case?


Can this query map be a class, too? Easier to read...


This is ok but you should initialize data to NULL and then make sure to handle the NULL data case in the destructor and assignment operator, otherwise we're at risk of dereferencing uninitialized memory.


ここのスペースって無いと動かなかったです？


That was an accident fixed in a later commit, which introduced another bug which I fixed in yet another commit


What if you cast the `oldOpacity` value?
```javascript
newOpacity = goog.isDef(oldOpacity) ? /** @type {number} */ (oldOpacity) : 1;
```


is there reason to keep it internally in such format? I think it is more convenient to prepare it during initialization instead of during each read. Then maybe journalctl_options and journalctl_matches will be just attr_readers


Hey Dmytro!

I'm not assuming any ownership on your work :)

The idea is that we are using php-mongo (since over a year now) but for some reason you keep omitting updating the dependencies in the composer file related to symfony version; at this point we are using symfony 2.6.* and we are getting into issues  because the composer file still requires symfony 2.5.*
We ran into the same issue regarding the php-mongo-bundle, which was worse because the dependency was to php-mongo and at certain times the requirement was to an inexistent version of php-mongo.
So I was forced to fork your work and ONLY modify the composer files so that we can keep updating symfony and don't get into problems with php-mongo.

If you have any suggestions how to avoid this situation I would be very very happy, it's very frustrating when I need to fork your package on github then put it on packagist,  when all it's needed is the update of the freakin composer file.

In any case I appreciate your work and effort!

Cheers!


Instead of `AccessibleObject`, this data structure should use `AnnotatedElement`.


/ping @ever on this one (just to be sure) :-).


(後で参照した時のために書いておきます) @c18692902725ce67af56dad423282e4706ecafad


Tag with multiple words should be following camel case (i.e. @ExpTopDestination)


I'm seeing a different error now. Here are the relevant snippets:

```elixir
defmodule Guild do
  has_many :members, through: [:memberships, :employee]

  ...

  def members(guild) do
    assoc(guild, :members) |> Employee.active
  end
end

defmodule Employee do
  def active(query) do
    query |> where([e], e.archived == false)
  end
end
```

Calling `Guild.members` causes this error:

```bash
* (Postgrex.Error) ERROR (42P10): SELECT DISTINCT ON expressions must match initial ORDER BY expressions
tacktrace:
 lib/ecto/adapters/sql/worker.ex:18: Ecto.Adapters.SQL.Worker.query!/4
 lib/ecto/adapters/sql.ex:186: Ecto.Adapters.SQL.use_worker/3
 (ensemble) lib/ensemble/repo.ex:2: Ensemble.Repo.log/2
 lib/ecto/adapters/sql.ex:315: Ecto.Adapters.SQL.all/5
 lib/ecto/repo/queryable.ex:20: Ecto.Repo.Queryable.all/4
```

An `IO.inspect` on the constructed query shows this:

```elixir
#Ecto.Query<from e in Ensemble.Employee, join: g in Ensemble.GuildMembership,
 on: e.id == g.employee_id, where: g.guild_id in ^'A',
 where: e.archived == false, distinct: [e.id], select: e>
```

Hope that helps.


you meant @evert  I am pretty sure ;)


これは無意識に入れてました、すみません。
あってもなくても変わらないので、後でついでに戻しておきます。


We should remove this hack; now that you cache everything, scanning Object once is fine.


Edited. Sorry @ever!


@staabm Thanks ;-).


@s7eele
thanks!


Fixed 896d26b093a4455378c85138ecaf22e3ff79c1b6


`hoge(fuga)`と`hoge (fuga)`は同じ動作をすると思いますが、
`hoge(fuga).then`と`hoge (fuga).then`は、恐らく後者は正しく動かないので注意したいですね。

hogeの引数に、().thenを入れてるように捉えられてしまうと思う。


Shouldn't we add here something like @deprecated replaced by ....


@gwensmu this is invalid JavaScript. Try running `jshint` and you'll find the syntax errors.


Can you try commit dbd3cd8a5b31bb514781d79cb0e0c3635ce3e5e6 and tell me if it works? Just add `ref: "dbd3cd8a5b31bb514781d79cb0e0c3635ce3e5e6"` to your ecto dep.


This function should be moved to a more standard place for helpers which are not clearly associated to a namespace, such as include/.

Moreover, it's quite easier to read if written like:
```PHP
    $full_url = (
        $url_parts['scheme'] . '://'
        // We ignore 'user' and 'pass'
        . $url_parts['host']
        . (isset($url_parts['port']) ? ':' . $url_parts['port'] : '')
        . $url_parts['path']
        . '?' . $query  // Replace the old query
        // Ignore the fragment
    );
```

You may also add a reference to https://tools.ietf.org/html/rfc3986#section-3 for example, to define the vocabulary (no need of quotes around "fragment" in the function comment).


なるほど。次は事故らないようにスワップ無効化しておきます！


it is wrong


@gwensmu take a look at the moment.js library for dealing with Date objects and formatting.


that does not work


thanks!

ちなみに、こういう、ループ内で`i`が直接関係しない時は、
_を使うことが多い気がするけど、JSの場合lodashがあって紛らわしいし、多分使わない方がいいですよね。


盲点でした。ありがとうございます。


Ce serait pour `linux::audio` en fait. Mais il faudrait mettre une grosse note que c'est un hack temporaire!


If you want the string it needs to be a string, yeah.  Storing as a byte array is just going to json that as bytes like you already found.


@guwirth: Im in process of implementing the 'forcezerocoverage' feature for python. I wonder why dont we do the same for integration and overall coverage? It is suffering the same problem, after all.


Adding the latest json2.js from https://github.com/douglascrockford/JSON-js


I think that makes sense


Thanks


Need more coffee over here. :)


Thanks - I've made those changes. Now working on some unit tests to make sure I actually figured them out - I think this code is going to be bit tricky because string indexing in R is [inclusive, inclusive], so there's another potential off-by-one error :/


@ft How should I do this?


TeamCity Toolbox :: Pull requests [Build 18](http://10.48.34.86:8111/viewLog.html?buildId=2190&buildTypeId=Toolbox_PullRequests) is now running


Will the non technical user understand what null oldPassword means?
Can you also separate the two words between old and password.
Can you also use the exact make of the required privilege? Edit User Passwords


TeamCity Toolbox :: Pull requests [Build 18](http://10.48.34.86:8111/viewLog.html?buildId=2190&buildTypeId=Toolbox_PullRequests) outcome was **SUCCESS**
Summary: Tests passed: 145 Build time: 00:00:18


名前の重複は極力避けたいですが、`for _ in ~~~` って書いてあったら流石にlodashと間違えたりはしないですよね。
こういう用途なら使用しても問題ない気はします。(実行環境が誤動作しなければ…！)


Oops. This probably got removed by accident. It was there a few months ago or so.


Misspelled canola oil.


This commit has broken this view - it should close the `</td>` before the `<% end %>`...


ugh, this is convoluted. Isn't there an easier way with preferably fewer checks?


Why do you need an array of nine elements when you specify only eight?


In my branch I have test that compares base64 output. It appears that It does not solves utf8 issue (neither guava or apache commons).


It works on this ref. Awesome stuff!

On Tue, Jan 27, 2015 at 7:40 AM, José Valim <notifications@github.com>
wrote:

> Can you try commit dbd3cd8
> <https://github.com/elixir-lang/ecto/commit/dbd3cd8a5b31bb514781d79cb0e0c3635ce3e5e6>
> and tell me if it works? Just add ref:
> "dbd3cd8a5b31bb514781d79cb0e0c3635ce3e5e6" to your ecto dep.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elixir-lang/ecto/commit/8ee5183f3f62b74d4a9e1e93e31a311c21ad5d1e#commitcomment-9458960>
> .
>


Hmm, with `SOUND:data:audio/basic;base64,MIICajCCAdOgAwIBAgI…` we don't escape the comma after `base64`… Ok, I am lost :smiley:!


Great!


看来最新版已经有类似丢弃a记录功能了  但这个方法已经没有任何效果
正则功能能实现不?


> We only think that the space is a German thing because it was a very popular mistake on the German subforum. :P

I saw ! I think , there was some large discussion . :-P

> Also, I forgot the `-x` option when I cherry-picked the man page changes. :(

No problem. It’s just a minor thing.

Vale,
Quintus


I would keep it shorter:
 * Improved error reporting in case of missing accessors in model classes


Or maybe I didn't :P


@dstendardi - I agree. I did some tests for both 0.6.0 and 0.7.0 and neither seemed to have any problem with unicode. I think the issue is further down the pipeline (in the collector). I will look there next. How is your branch with performance-optimizations coming along? What strategy did you use (thread pools, RxJava, Akka, something else)? Looking forward to seeing it...


Adding my info


我看到 upstream 里 Glen Huang 已经提了这个 patch 了，所以旧方法就算是废弃了。我最近打算把 ChinaDNS 的方法 port 过来。不过你说的正则功能意思是？


Yeah, that's a delimited block title (notice the period at the start).  I'll show as a bold title above above the block, next to the little "Note" icon.

Asciidoc is a little funky sometimes :)


Marianne ...


It would be better to pass this to the partial as a local variable:

```erb
<%= render :partial => 'public_body/body_listing_single',
           :locals => { :public_body => result[:model],
                        :include_request_link => true } %>
```

…and set a default of `false` in the partial. Something like:

```erb
# public_body/_body_listing_single.html.erb

<%
  include_request_link = false unless defined?(:include_request_link)
%>
```


Yeah, it should.  Will make the addition


Are we intentionally dropping this fallback?


PEP8? `I = ImaginaryUnit()`


Muhahahahahahaha!


PEP8 for the `*` signs as well.


LINE 9: The readability of the code you write becomes very important when working on long-term projects, maintaining a large code-base, inheriting a pre-existing project or handing a project off to someone new. If you are going to remove the whitespace from multiple words then use camel case syntax. (i.e. UsaTodayTravel)


Don't you want to assume these are reals?


Ah, cool.  This is much cleaner :)


remove qingge.mp3


s/windoe/window/


@michaelcahill, just for clarity, this isn't a change I put in in #1596, I believe this one dates back to 5417140 -- if it just failed, I'm curious why we've never seen it before?


Update


I think from an advocacy point of view having an 'About' page will be useful to help explain to others what this project is about.  I think we'd only want that on our demo domain (districthousing.org) though and not on what Bread for the City uses internally.


On Mon, Jan 26, 2015 at 06:51:54PM GMT, Joey Hess wrote:

> I'll make it use ${PAGER:more}

Ooops, sorry! I didn't spot it the fist time around and only found the
hard way - ${parameter:word} is obviously not valid and the above should
be something like:

${PAGER:-more}

which I have now, obviously, tested and it works just fine :^)

Regards,

Raf


wowwwwwwwwww =D


This just made my day. Thank you :D


Vsaj polovica ekipe ga.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 939](http://build.osmsharp.com:8080/viewLog.html?buildId=4190&buildTypeId=bt16) is now running


The problem is indeed related to the use of the generic `get` function. So I'd use:

```js
    var oldOpacity = /** @type {number|undefined} */ (layer.get('oldOpacity'));
    newOpacity = goog.isDef(oldOpacity) ? oldOpacity : 1;
```


Use  the 1.x branch for plone 4
On Jan 27, 2015 3:42 AM, "Peter Mathis" <notifications@github.com> wrote:

> so this package is no more Plone4 compatible? I thought Plone 4.3.4 is
> jQuery 1.9+ compatible ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/plone/plone.app.widgets/commit/d7f67be0381d3d98485f67c4bcd18625dc1c7bc2#commitcomment-9455570>
> .
>


No, setting a default env to production is wrong. It needs to be based upon only the `config.optimize` bit, or else it breaks the ability to `overrides: production: optimize: false`


Ouch, git version 1.8.1.4
```
Unknown option: -C
usage: git............
```


canolas -> canola


i have a WARN when i launch with jetty:run

    2015-01-27 14:58:17,082 WARN  [jeeves.engine] -    Stack     : java.lang.ClassCastException:     org.fao.geonet.services.user.Remove cannot be cast to jeeves.interfaces.Service
	at jeeves.server.dispatchers.ServiceManager.buildService(ServiceManager.java:235)
	at jeeves.server.dispatchers.ServiceManager.addService(ServiceManager.java:196)


You get `undefined method World` if both Cucumber and RSpec are used in parallel!


You may want to consider changing 'Antwerp' to 'Antwerpen', which is the proper Dutch name.


@ImBobby I added you here :+1: Welcome :metal:


Unnecessary colon at the end of this sentence? Or missing code block directly below?


1: M100 needs more reviewers
1: M101 signature is missing


This would be easier to understand if it was:

```erb
<% if public_body.requestable? %>
  <div class="make-request-quick-button">
    <%= link_to _("Make a request"), new_request_to_body_path(:url_name => public_body.url_name), :class => "link_button_green" %>
  </div>
<% end %>
```


Why not use NotImplementedException from Apache commons? http://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/NotImplementedException.html


Another trailing colon


22:1: I101 Imported names are in the wrong order. Should be current_app, has_request_context, request, session
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures
63: D203 Expected 1 blank line *before* class docstring, found 0
181:9: B901 blind except: statement
228:9: B901 blind except: statement


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
31:1: I100 Imports statements are in the wrong order. import cgi should be before import time
32:1: I201 Missing newline before sections or imports.
33:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_WEBSESSION_DIFFERENTIATE_BETWEEN_GUESTS
33:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
33:1: I201 Missing newline before sections or imports.
34:28: E126 continuation line over-indented for hanging indent
40:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, page_not_authorized
41:29: E126 continuation line over-indented for hanging indent
42:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
43:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.legacy.webpage
44:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, get_fieldvalues, guess_primary_collection_of_a_record, record_exists
45:6: E126 continuation line over-indented for hanging indent
48:1: I101 Imported names are in the wrong order. Should be make_canonical_urlargd, redirect_to_url
49:30: E126 continuation line over-indented for hanging indent
50:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
51:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
55:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.access.mailcookie
57:1: I100 Imports statements are in the wrong order. import invenio.legacy.bibcirculation.db_layer should be before import invenio.legacy.template
59:1: I101 Imported names are in the wrong order. Should be ill_register_request, ill_register_request_with_recid, ill_request_with_recid, perform_book_proposal_send, perform_borrower_loans, perform_get_holdings_information, perform_loanshistoricaloverview, perform_new_request, perform_new_request_send
59:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.api should be before from invenio.legacy.bibcirculation.utils
60:36: E126 continuation line over-indented for hanging indent
68:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.adminlib should be before from invenio.legacy.bibcirculation.api
69:44: E126 continuation line over-indented for hanging indent
70:1: I101 Imported names are in the wrong order. Should be AMZ_ACQUISITION_IDENTIFIER_TAG, CFG_BIBCIRCULATION_ACQ_STATUS_NEW, CFG_BIBCIRCULATION_ILLS_EMAIL, CFG_BIBCIRCULATION_ILL_STATUS_NEW
71:43: E126 continuation line over-indented for hanging indent
83:1: E302 expected 2 blank lines, found 1
83: D203 Expected 1 blank line *before* class docstring, found 0
88: D102 Docstring missing
91: D400 First line should end with '.', not 't'
91: D208 Docstring is over-indented
91: D200 One-line docstring should not occupy 3 lines
98: D401 First line should be imperative: 'Display', not 'Displays'
98: D202 No blank lines allowed *after* method docstring, found 1
98: D400 First line should end with '.', not 'r'
98: D205 Blank line missing between one-line summary and description
113:70: E502 the backslash is redundant between brackets
120:30: E203 whitespace before ':'
122:25: E203 whitespace before ':'
123:21: E126 continuation line over-indented for hanging indent
129:52: E502 the backslash is redundant between brackets
130:44: E251 unexpected spaces around keyword / parameter equals
130:46: E251 unexpected spaces around keyword / parameter equals
139:26: E251 unexpected spaces around keyword / parameter equals
139:34: E251 unexpected spaces around keyword / parameter equals
139:26: E221 multiple spaces before operator
140:25: E251 unexpected spaces around keyword / parameter equals
140:34: E251 unexpected spaces around keyword / parameter equals
140:25: E221 multiple spaces before operator
141:24: E251 unexpected spaces around keyword / parameter equals
141:34: E251 unexpected spaces around keyword / parameter equals
141:24: E221 multiple spaces before operator
142:32: E251 unexpected spaces around keyword / parameter equals
142:34: E251 unexpected spaces around keyword / parameter equals
143:24: E251 unexpected spaces around keyword / parameter equals
143:34: E251 unexpected spaces around keyword / parameter equals
143:24: E221 multiple spaces before operator
144:29: E251 unexpected spaces around keyword / parameter equals
144:34: E251 unexpected spaces around keyword / parameter equals
144:29: E221 multiple spaces before operator
145:30: E251 unexpected spaces around keyword / parameter equals
145:34: E251 unexpected spaces around keyword / parameter equals
145:30: E221 multiple spaces before operator
148: D202 No blank lines allowed *after* method docstring, found 1
148: D200 One-line docstring should not occupy 3 lines
158:86: E502 the backslash is redundant between brackets
165:30: E203 whitespace before ':'
168:25: E203 whitespace before ':'
174:52: E502 the backslash is redundant between brackets
175:29: E128 continuation line under-indented for visual indent
175:33: E251 unexpected spaces around keyword / parameter equals
175:35: E251 unexpected spaces around keyword / parameter equals
180:26: E251 unexpected spaces around keyword / parameter equals
180:34: E251 unexpected spaces around keyword / parameter equals
180:26: E221 multiple spaces before operator
181:25: E251 unexpected spaces around keyword / parameter equals
181:34: E251 unexpected spaces around keyword / parameter equals
181:25: E221 multiple spaces before operator
182:24: E251 unexpected spaces around keyword / parameter equals
182:34: E251 unexpected spaces around keyword / parameter equals
182:24: E221 multiple spaces before operator
183:32: E251 unexpected spaces around keyword / parameter equals
183:34: E251 unexpected spaces around keyword / parameter equals
184:24: E251 unexpected spaces around keyword / parameter equals
184:34: E251 unexpected spaces around keyword / parameter equals
184:24: E221 multiple spaces before operator
185:29: E251 unexpected spaces around keyword / parameter equals
185:34: E251 unexpected spaces around keyword / parameter equals
185:29: E221 multiple spaces before operator
186:30: E251 unexpected spaces around keyword / parameter equals
186:34: E251 unexpected spaces around keyword / parameter equals
186:30: E221 multiple spaces before operator
190: D203 Expected 1 blank line *before* class docstring, found 0
190: D204 Expected 1 blank line *after* class docstring, found 2
194:5: E303 too many blank lines (2)
195:37: E231 missing whitespace after ','
200: D290 White spaces around docstring should be trimmed.
200: D400 First line should end with '.', not 't'
200: D200 One-line docstring should not occupy 2 lines
204:59: E128 continuation line under-indented for visual indent
206: D401 First line should be imperative: 'Display', not 'Displays'
206: D202 No blank lines allowed *after* method docstring, found 1
206: D400 First line should end with '.', not 'r'
206: D205 Blank line missing between one-line summary and description
231:73: E502 the backslash is redundant between brackets
238:30: E203 whitespace before ':'
241:25: E203 whitespace before ':'
247:52: E502 the backslash is redundant between brackets
248:33: E128 continuation line under-indented for visual indent
248:37: E251 unexpected spaces around keyword / parameter equals
248:39: E251 unexpected spaces around keyword / parameter equals
251:25: E128 continuation line under-indented for visual indent
252:25: E126 continuation line over-indented for hanging indent
266:26: E251 unexpected spaces around keyword / parameter equals
266:34: E251 unexpected spaces around keyword / parameter equals
266:26: E221 multiple spaces before operator
267:25: E251 unexpected spaces around keyword / parameter equals
267:34: E251 unexpected spaces around keyword / parameter equals
267:25: E221 multiple spaces before operator
268:24: E251 unexpected spaces around keyword / parameter equals
268:34: E251 unexpected spaces around keyword / parameter equals
268:24: E221 multiple spaces before operator
269:32: E251 unexpected spaces around keyword / parameter equals
269:34: E251 unexpected spaces around keyword / parameter equals
270:24: E251 unexpected spaces around keyword / parameter equals
270:34: E251 unexpected spaces around keyword / parameter equals
270:24: E221 multiple spaces before operator
271:29: E251 unexpected spaces around keyword / parameter equals
271:34: E251 unexpected spaces around keyword / parameter equals
271:29: E221 multiple spaces before operator
272:30: E251 unexpected spaces around keyword / parameter equals
272:34: E251 unexpected spaces around keyword / parameter equals
272:30: E221 multiple spaces before operator
274: D401 First line should be imperative: 'Display', not 'Displays'
274: D202 No blank lines allowed *after* method docstring, found 1
274: D400 First line should end with '.', not 'r'
274: D205 Blank line missing between one-line summary and description
286:75: E502 the backslash is redundant between brackets
293:30: E203 whitespace before ':'
296:25: E203 whitespace before ':'
302:52: E502 the backslash is redundant between brackets
303:44: E251 unexpected spaces around keyword / parameter equals
303:46: E251 unexpected spaces around keyword / parameter equals
312:26: E251 unexpected spaces around keyword / parameter equals
312:34: E251 unexpected spaces around keyword / parameter equals
312:26: E221 multiple spaces before operator
313:25: E251 unexpected spaces around keyword / parameter equals
313:34: E251 unexpected spaces around keyword / parameter equals
313:25: E221 multiple spaces before operator
314:24: E251 unexpected spaces around keyword / parameter equals
314:34: E251 unexpected spaces around keyword / parameter equals
314:24: E221 multiple spaces before operator
315:32: E251 unexpected spaces around keyword / parameter equals
315:34: E251 unexpected spaces around keyword / parameter equals
316:24: E251 unexpected spaces around keyword / parameter equals
316:34: E251 unexpected spaces around keyword / parameter equals
316:24: E221 multiple spaces before operator
317:29: E251 unexpected spaces around keyword / parameter equals
317:34: E251 unexpected spaces around keyword / parameter equals
317:29: E221 multiple spaces before operator
318:30: E251 unexpected spaces around keyword / parameter equals
318:34: E251 unexpected spaces around keyword / parameter equals
318:30: E221 multiple spaces before operator
320: D401 First line should be imperative: 'Display', not 'Displays'
320: D202 No blank lines allowed *after* method docstring, found 1
320: D400 First line should end with '.', not 'r'
320: D205 Blank line missing between one-line summary and description
328:13: E128 continuation line under-indented for visual indent
331:76: E231 missing whitespace after ','
358:22: E222 multiple spaces after operator
371:75: E502 the backslash is redundant between brackets
378:30: E203 whitespace before ':'
381:25: E203 whitespace before ':'
387:52: E502 the backslash is redundant between brackets
388:44: E251 unexpected spaces around keyword / parameter equals
388:46: E251 unexpected spaces around keyword / parameter equals
406:41: E126 continuation line over-indented for hanging indent
411:26: E251 unexpected spaces around keyword / parameter equals
411:34: E251 unexpected spaces around keyword / parameter equals
411:26: E221 multiple spaces before operator
412:25: E251 unexpected spaces around keyword / parameter equals
412:34: E251 unexpected spaces around keyword / parameter equals
412:25: E221 multiple spaces before operator
413:24: E251 unexpected spaces around keyword / parameter equals
413:34: E251 unexpected spaces around keyword / parameter equals
413:24: E221 multiple spaces before operator
414:32: E251 unexpected spaces around keyword / parameter equals
414:34: E251 unexpected spaces around keyword / parameter equals
415:24: E251 unexpected spaces around keyword / parameter equals
415:34: E251 unexpected spaces around keyword / parameter equals
415:24: E221 multiple spaces before operator
416:29: E251 unexpected spaces around keyword / parameter equals
416:34: E251 unexpected spaces around keyword / parameter equals
416:29: E221 multiple spaces before operator
417:30: E251 unexpected spaces around keyword / parameter equals
417:34: E251 unexpected spaces around keyword / parameter equals
417:30: E221 multiple spaces before operator
419: D401 First line should be imperative: 'Display', not 'Displays'
419: D202 No blank lines allowed *after* method docstring, found 1
419: D400 First line should end with '.', not 'r'
419: D205 Blank line missing between one-line summary and description
427:13: E128 continuation line under-indented for visual indent
455:75: E502 the backslash is redundant between brackets
462:30: E203 whitespace before ':'
465:25: E203 whitespace before ':'
471:52: E502 the backslash is redundant between brackets
472:44: E251 unexpected spaces around keyword / parameter equals
472:46: E251 unexpected spaces around keyword / parameter equals
475:52: E203 whitespace before ':'
476:48: E203 whitespace before ':'
494:26: E251 unexpected spaces around keyword / parameter equals
494:34: E251 unexpected spaces around keyword / parameter equals
494:26: E221 multiple spaces before operator
495:25: E251 unexpected spaces around keyword / parameter equals
495:34: E251 unexpected spaces around keyword / parameter equals
495:25: E221 multiple spaces before operator
496:24: E251 unexpected spaces around keyword / parameter equals
496:34: E251 unexpected spaces around keyword / parameter equals
496:24: E221 multiple spaces before operator
497:32: E251 unexpected spaces around keyword / parameter equals
497:34: E251 unexpected spaces around keyword / parameter equals
498:24: E251 unexpected spaces around keyword / parameter equals
498:34: E251 unexpected spaces around keyword / parameter equals
498:24: E221 multiple spaces before operator
499:29: E251 unexpected spaces around keyword / parameter equals
499:34: E251 unexpected spaces around keyword / parameter equals
499:29: E221 multiple spaces before operator
500:30: E251 unexpected spaces around keyword / parameter equals
500:34: E251 unexpected spaces around keyword / parameter equals
500:30: E221 multiple spaces before operator
502: D401 First line should be imperative: 'Display', not 'Displays'
502: D202 No blank lines allowed *after* method docstring, found 1
502: D400 First line should end with '.', not 'r'
502: D205 Blank line missing between one-line summary and description
514:78: E502 the backslash is redundant between brackets
521:30: E203 whitespace before ':'
524:25: E203 whitespace before ':'
530:52: E502 the backslash is redundant between brackets
531:44: E251 unexpected spaces around keyword / parameter equals
531:46: E251 unexpected spaces around keyword / parameter equals
540:26: E251 unexpected spaces around keyword / parameter equals
540:34: E251 unexpected spaces around keyword / parameter equals
540:26: E221 multiple spaces before operator
541:25: E251 unexpected spaces around keyword / parameter equals
541:34: E251 unexpected spaces around keyword / parameter equals
541:25: E221 multiple spaces before operator
542:24: E251 unexpected spaces around keyword / parameter equals
542:34: E251 unexpected spaces around keyword / parameter equals
542:24: E221 multiple spaces before operator
543:32: E251 unexpected spaces around keyword / parameter equals
543:34: E251 unexpected spaces around keyword / parameter equals
544:24: E251 unexpected spaces around keyword / parameter equals
544:34: E251 unexpected spaces around keyword / parameter equals
544:24: E221 multiple spaces before operator
545:29: E251 unexpected spaces around keyword / parameter equals
545:34: E251 unexpected spaces around keyword / parameter equals
545:29: E221 multiple spaces before operator
546:30: E251 unexpected spaces around keyword / parameter equals
546:34: E251 unexpected spaces around keyword / parameter equals
546:30: E221 multiple spaces before operator
548: D401 First line should be imperative: 'Display', not 'Displays'
548: D202 No blank lines allowed *after* method docstring, found 1
548: D400 First line should end with '.', not 'r'
548: D205 Blank line missing between one-line summary and description
556:13: E128 continuation line under-indented for visual indent
566:78: E502 the backslash is redundant between brackets
573:30: E203 whitespace before ':'
576:25: E203 whitespace before ':'
582:52: E502 the backslash is redundant between brackets
583:33: E128 continuation line under-indented for visual indent
583:37: E251 unexpected spaces around keyword / parameter equals
583:39: E251 unexpected spaces around keyword / parameter equals
594:17: E128 continuation line under-indented for visual indent
595:17: E128 continuation line under-indented for visual indent
595:53: E203 whitespace before ':'
596:17: E128 continuation line under-indented for visual indent
596:38: E203 whitespace before ':'
597:17: E128 continuation line under-indented for visual indent
597:61: E202 whitespace before '}'
601:37: E128 continuation line under-indented for visual indent
602:37: E126 continuation line over-indented for hanging indent
614:26: E251 unexpected spaces around keyword / parameter equals
614:34: E251 unexpected spaces around keyword / parameter equals
614:26: E221 multiple spaces before operator
615:25: E251 unexpected spaces around keyword / parameter equals
615:34: E251 unexpected spaces around keyword / parameter equals
615:25: E221 multiple spaces before operator
616:24: E251 unexpected spaces around keyword / parameter equals
616:34: E251 unexpected spaces around keyword / parameter equals
616:24: E221 multiple spaces before operator
617:32: E251 unexpected spaces around keyword / parameter equals
617:34: E251 unexpected spaces around keyword / parameter equals
618:24: E251 unexpected spaces around keyword / parameter equals
618:34: E251 unexpected spaces around keyword / parameter equals
618:24: E221 multiple spaces before operator
619:29: E251 unexpected spaces around keyword / parameter equals
619:34: E251 unexpected spaces around keyword / parameter equals
619:29: E221 multiple spaces before operator
620:30: E251 unexpected spaces around keyword / parameter equals
620:34: E251 unexpected spaces around keyword / parameter equals
620:30: E221 multiple spaces before operator
622: D102 Docstring missing
625:17: E128 continuation line under-indented for visual indent
665:79: E502 the backslash is redundant between brackets
672:30: E203 whitespace before ':'
675:25: E203 whitespace before ':'
681:52: E502 the backslash is redundant between brackets
682:33: E128 continuation line under-indented for visual indent
682:37: E251 unexpected spaces around keyword / parameter equals
682:39: E251 unexpected spaces around keyword / parameter equals
691:55: E128 continuation line under-indented for visual indent
693:26: E251 unexpected spaces around keyword / parameter equals
693:34: E251 unexpected spaces around keyword / parameter equals
693:26: E221 multiple spaces before operator
694:25: E251 unexpected spaces around keyword / parameter equals
694:34: E251 unexpected spaces around keyword / parameter equals
694:25: E221 multiple spaces before operator
695:24: E251 unexpected spaces around keyword / parameter equals
695:34: E251 unexpected spaces around keyword / parameter equals
695:24: E221 multiple spaces before operator
696:32: E251 unexpected spaces around keyword / parameter equals
696:34: E251 unexpected spaces around keyword / parameter equals
697:24: E251 unexpected spaces around keyword / parameter equals
697:34: E251 unexpected spaces around keyword / parameter equals
697:24: E221 multiple spaces before operator
698:29: E251 unexpected spaces around keyword / parameter equals
698:34: E251 unexpected spaces around keyword / parameter equals
698:29: E221 multiple spaces before operator
699:30: E251 unexpected spaces around keyword / parameter equals
699:34: E251 unexpected spaces around keyword / parameter equals
699:30: E221 multiple spaces before operator
701: D102 Docstring missing
704:17: E128 continuation line under-indented for visual indent
744:79: E502 the backslash is redundant between brackets
751:30: E203 whitespace before ':'
754:25: E203 whitespace before ':'
760:52: E502 the backslash is redundant between brackets
761:33: E128 continuation line under-indented for visual indent
761:37: E251 unexpected spaces around keyword / parameter equals
761:39: E251 unexpected spaces around keyword / parameter equals
770:66: E128 continuation line under-indented for visual indent
777:60: E203 whitespace before ':'
778:56: E203 whitespace before ':'
782:13: E303 too many blank lines (2)
785:55: E126 continuation line over-indented for hanging indent
801:32: E251 unexpected spaces around keyword / parameter equals
801:34: E251 unexpected spaces around keyword / parameter equals
802:30: E251 unexpected spaces around keyword / parameter equals
802:34: E251 unexpected spaces around keyword / parameter equals
802:30: E221 multiple spaces before operator
803:31: E251 unexpected spaces around keyword / parameter equals
803:34: E251 unexpected spaces around keyword / parameter equals
803:31: E221 multiple spaces before operator
804:30: E251 unexpected spaces around keyword / parameter equals
804:32: E251 unexpected spaces around keyword / parameter equals
804:43: E251 unexpected spaces around keyword / parameter equals
804:45: E251 unexpected spaces around keyword / parameter equals
805:31: E251 unexpected spaces around keyword / parameter equals
805:34: E251 unexpected spaces around keyword / parameter equals
805:31: E221 multiple spaces before operator
808:23: E124 closing bracket does not match visual indentation
817:61: E502 the backslash is redundant between brackets
818:41: E127 continuation line over-indented for visual indent
818:105: E502 the backslash is redundant between brackets
823: D203 Expected 1 blank line *before* class docstring, found 0
830: D102 Docstring missing
834:5: E303 too many blank lines (2)
834: D401 First line should be imperative: 'Redirect', not 'Redirects'
834: D202 No blank lines allowed *after* method docstring, found 1
834: D400 First line should end with '.', not 'n'
834: D200 One-line docstring should not occupy 3 lines
841: D202 No blank lines allowed *after* method docstring, found 1
841: D200 One-line docstring should not occupy 3 lines
849:39: E203 whitespace before ':'
867:30: E251 unexpected spaces around keyword / parameter equals
867:32: E251 unexpected spaces around keyword / parameter equals
868:37: E251 unexpected spaces around keyword / parameter equals
868:39: E251 unexpected spaces around keyword / parameter equals
869:29: E251 unexpected spaces around keyword / parameter equals
869:31: E251 unexpected spaces around keyword / parameter equals
870:36: E251 unexpected spaces around keyword / parameter equals
870:38: E251 unexpected spaces around keyword / parameter equals
871:33: E251 unexpected spaces around keyword / parameter equals
871:35: E251 unexpected spaces around keyword / parameter equals
872:28: E251 unexpected spaces around keyword / parameter equals
872:30: E251 unexpected spaces around keyword / parameter equals
873:33: E251 unexpected spaces around keyword / parameter equals
873:35: E251 unexpected spaces around keyword / parameter equals
874:28: E251 unexpected spaces around keyword / parameter equals
874:30: E251 unexpected spaces around keyword / parameter equals
880:99: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
891:33: E128 continuation line under-indented for visual indent
893:21: E127 continuation line over-indented for visual indent
894:33: E128 continuation line under-indented for visual indent
900:9: E303 too many blank lines (2)
900:59: E502 the backslash is redundant between brackets
901:21: E126 continuation line over-indented for hanging indent
902:21: E126 continuation line over-indented for hanging indent
908:51: E502 the backslash is redundant between brackets
909:105: E502 the backslash is redundant between brackets
911:53: E502 the backslash is redundant between brackets
913:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
923:71: E225 missing whitespace around operator
932:44: E251 unexpected spaces around keyword / parameter equals
932:46: E251 unexpected spaces around keyword / parameter equals
936:31: E127 continuation line over-indented for visual indent
937:31: E127 continuation line over-indented for visual indent
938:31: E127 continuation line over-indented for visual indent
939:31: E127 continuation line over-indented for visual indent
945:5: E303 too many blank lines (2)
945: D200 One-line docstring should not occupy 3 lines
951:9: F841 local variable '_' is assigned to but never used
956:49: E251 unexpected spaces around keyword / parameter equals
956:51: E251 unexpected spaces around keyword / parameter equals
962:25: E131 continuation line unaligned for hanging indent
963:21: E122 continuation line missing indentation or outdented
963:30: E203 whitespace before ':'
968:21: E122 continuation line missing indentation or outdented
968:25: E203 whitespace before ':'
973:86: E203 whitespace before ':'
975:22: E127 continuation line over-indented for visual indent
975:68: E203 whitespace before ':'
977:45: E124 closing bracket does not match visual indentation
980:52: E502 the backslash is redundant between brackets
981:17: E128 continuation line under-indented for visual indent
981:21: E251 unexpected spaces around keyword / parameter equals
981:23: E251 unexpected spaces around keyword / parameter equals
999:51: E502 the backslash is redundant between brackets
1000:105: E502 the backslash is redundant between brackets
1002:53: E502 the backslash is redundant between brackets
1004:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
1014:71: E225 missing whitespace around operator
1023:44: E251 unexpected spaces around keyword / parameter equals
1023:46: E251 unexpected spaces around keyword / parameter equals
1027:31: E127 continuation line over-indented for visual indent
1028:31: E127 continuation line over-indented for visual indent
1029:31: E127 continuation line over-indented for visual indent
1030:31: E127 continuation line over-indented for visual indent
1032: D400 First line should end with '.', not ','
1032: D205 Blank line missing between one-line summary and description
1045:9: F841 local variable '_' is assigned to but never used
1050:49: E251 unexpected spaces around keyword / parameter equals
1050:51: E251 unexpected spaces around keyword / parameter equals
1056:25: E131 continuation line unaligned for hanging indent
1057:21: E122 continuation line missing indentation or outdented
1057:30: E203 whitespace before ':'
1062:21: E122 continuation line missing indentation or outdented
1062:25: E203 whitespace before ':'
1067:86: E203 whitespace before ':'
1069:22: E127 continuation line over-indented for visual indent
1069:95: E502 the backslash is redundant between brackets
1069:68: E203 whitespace before ':'
1069:92: E203 whitespace before ':'
1070:17: E128 continuation line under-indented for visual indent
1073:52: E502 the backslash is redundant between brackets
1074:17: E128 continuation line under-indented for visual indent
1074:21: E251 unexpected spaces around keyword / parameter equals
1074:23: E251 unexpected spaces around keyword / parameter equals
1101:51: E502 the backslash is redundant between brackets
1102:105: E502 the backslash is redundant between brackets
1104:53: E502 the backslash is redundant between brackets
1106:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
1116:71: E225 missing whitespace around operator
1128:31: E127 continuation line over-indented for visual indent
1129:31: E127 continuation line over-indented for visual indent
1130:31: E127 continuation line over-indented for visual indent
1131:31: E127 continuation line over-indented for visual indent
1132:31: E128 continuation line under-indented for visual indent
1135:5: E303 too many blank lines (2)
1135: D202 No blank lines allowed *after* method docstring, found 1
1135: D200 One-line docstring should not occupy 3 lines
1142:9: F841 local variable '_' is assigned to but never used
1150:49: E251 unexpected spaces around keyword / parameter equals
1150:51: E251 unexpected spaces around keyword / parameter equals
1156:25: E131 continuation line unaligned for hanging indent
1157:21: E122 continuation line missing indentation or outdented
1157:30: E203 whitespace before ':'
1162:21: E122 continuation line missing indentation or outdented
1162:25: E203 whitespace before ':'
1165:9: E303 too many blank lines (2)
1168:86: E203 whitespace before ':'
1170:22: E127 continuation line over-indented for visual indent
1170:95: E502 the backslash is redundant between brackets
1170:68: E203 whitespace before ':'
1170:92: E203 whitespace before ':'
1171:17: E128 continuation line under-indented for visual indent
1174:52: E502 the backslash is redundant between brackets
1175:17: E128 continuation line under-indented for visual indent
1175:21: E251 unexpected spaces around keyword / parameter equals
1175:23: E251 unexpected spaces around keyword / parameter equals
1179:9: E303 too many blank lines (3)
1180:53: E127 continuation line over-indented for visual indent
1181:53: E127 continuation line over-indented for visual indent
1187:51: E502 the backslash is redundant between brackets
1188:105: E502 the backslash is redundant between brackets
1190:53: E502 the backslash is redundant between brackets
1192:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
1202:71: E225 missing whitespace around operator
1211:44: E251 unexpected spaces around keyword / parameter equals
1211:46: E251 unexpected spaces around keyword / parameter equals
1215:31: E127 continuation line over-indented for visual indent
1216:31: E127 continuation line over-indented for visual indent
1217:31: E127 continuation line over-indented for visual indent
1218:31: E127 continuation line over-indented for visual indent
1220: D202 No blank lines allowed *after* method docstring, found 1
1220: D200 One-line docstring should not occupy 3 lines
1233:9: F841 local variable '_' is assigned to but never used
1238:71: E251 unexpected spaces around keyword / parameter equals
1238:73: E251 unexpected spaces around keyword / parameter equals
1238:73: E222 multiple spaces after operator
1239:69: E251 unexpected spaces around keyword / parameter equals
1239:71: E251 unexpected spaces around keyword / parameter equals
1239:71: E222 multiple spaces after operator
1240:67: E251 unexpected spaces around keyword / parameter equals
1240:69: E251 unexpected spaces around keyword / parameter equals
1240:69: E222 multiple spaces after operator
1241:58: E251 unexpected spaces around keyword / parameter equals
1241:60: E251 unexpected spaces around keyword / parameter equals
1242:60: E251 unexpected spaces around keyword / parameter equals
1242:62: E251 unexpected spaces around keyword / parameter equals
1248:49: E251 unexpected spaces around keyword / parameter equals
1248:51: E251 unexpected spaces around keyword / parameter equals
1254:25: E131 continuation line unaligned for hanging indent
1255:21: E122 continuation line missing indentation or outdented
1255:30: E203 whitespace before ':'
1260:21: E122 continuation line missing indentation or outdented
1260:25: E203 whitespace before ':'
1263:9: E303 too many blank lines (2)
1266:86: E203 whitespace before ':'
1268:22: E127 continuation line over-indented for visual indent
1268:95: E502 the backslash is redundant between brackets
1268:68: E203 whitespace before ':'
1268:92: E203 whitespace before ':'
1269:17: E128 continuation line under-indented for visual indent
1272:52: E502 the backslash is redundant between brackets
1273:17: E128 continuation line under-indented for visual indent
1273:21: E251 unexpected spaces around keyword / parameter equals
1273:23: E251 unexpected spaces around keyword / parameter equals
1277:9: E303 too many blank lines (3)
1278:53: E127 continuation line over-indented for visual indent
1279:53: E127 continuation line over-indented for visual indent
1285:51: E502 the backslash is redundant between brackets
1286:105: E502 the backslash is redundant between brackets
1288:53: E502 the backslash is redundant between brackets
1290:54: E712 comparison to True should be 'if cond is True:' or 'if cond:'
1300:71: E225 missing whitespace around operator
1312:31: E127 continuation line over-indented for visual indent
1313:31: E127 continuation line over-indented for visual indent
1314:31: E127 continuation line over-indented for visual indent
1315:31: E127 continuation line over-indented for visual indent


1: D100 Docstring missing
2: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils
41:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.records.api
45:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly, warning_page, write_warning
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.webjournal should be before from invenio.legacy.webuser
50:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
50:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webjournal
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
53:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, guess_primary_collection_of_a_record, is_user_owner_of_record, record_exists
54:6: E126 continuation line over-indented for hanging indent
57:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
57:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.search_engine
60:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
63:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.search.models
69:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
69:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
70:6: E126 continuation line over-indented for hanging indent
76: D101 Docstring missing
78: D102 Docstring missing
118:94: E203 whitespace before ':'
120:30: E127 continuation line over-indented for visual indent
120:95: E502 the backslash is redundant between brackets
120:76: E203 whitespace before ':'
120:92: E203 whitespace before ':'
128:60: E502 the backslash is redundant between brackets
129:52: E251 unexpected spaces around keyword / parameter equals
129:54: E251 unexpected spaces around keyword / parameter equals
205:45: E128 continuation line under-indented for visual indent
212:107: E203 whitespace before ':'
214:37: E122 continuation line missing indentation or outdented
214:102: E502 the backslash is redundant between brackets
214:83: E203 whitespace before ':'
214:99: E203 whitespace before ':'
215:41: E128 continuation line under-indented for visual indent
276:25: E128 continuation line under-indented for visual indent
276:79: E502 the backslash is redundant between brackets
277:41: E127 continuation line over-indented for visual indent
278:54: E502 the backslash is redundant between brackets
279:25: E128 continuation line under-indented for visual indent
281:25: E126 continuation line over-indented for hanging indent
288:25: E127 continuation line over-indented for visual indent
289:25: E127 continuation line over-indented for visual indent
290:25: E127 continuation line over-indented for visual indent
291:25: E127 continuation line over-indented for visual indent
294: D400 First line should end with '.', not 't'
294: D205 Blank line missing between one-line summary and description
294: D208 Docstring is over-indented
306:1: E302 expected 2 blank lines, found 1
306: D290 White spaces around docstring should be trimmed.
306: D202 No blank lines allowed *after* function docstring, found 1
306: D400 First line should end with '.', not 's'
315:13: E203 whitespace before ':'
349: D101 Docstring missing
353: D400 First line should end with '.', not 'd'
353: D200 One-line docstring should not occupy 3 lines
374:22: E126 continuation line over-indented for hanging indent
374:50: E203 whitespace before ':'
375:55: E203 whitespace before ':'
385:9: E122 continuation line missing indentation or outdented
438:96: E128 continuation line under-indented for visual indent
449:50: E502 the backslash is redundant between brackets
469:5: E128 continuation line under-indented for visual indent
479:26: E251 unexpected spaces around keyword / parameter equals
479:28: E251 unexpected spaces around keyword / parameter equals
482:111: E502 the backslash is redundant between brackets
482:34: E251 unexpected spaces around keyword / parameter equals
482:36: E251 unexpected spaces around keyword / parameter equals
483:37: E127 continuation line over-indented for visual indent
484:25: E251 unexpected spaces around keyword / parameter equals
484:27: E251 unexpected spaces around keyword / parameter equals
485:24: E251 unexpected spaces around keyword / parameter equals
485:26: E251 unexpected spaces around keyword / parameter equals
490: D202 No blank lines allowed *after* method docstring, found 1
490: D400 First line should end with '.', not 'e'
490: D300 Expected """-quotes, got '-quotes
505:16: E127 continuation line over-indented for visual indent
509:35: E128 continuation line under-indented for visual indent
510:35: E128 continuation line under-indented for visual indent
520:13: B901 blind except: statement
526:13: B901 blind except: statement
531:17: E128 continuation line under-indented for visual indent
532:17: E128 continuation line under-indented for visual indent
533:17: E128 continuation line under-indented for visual indent


2: L102 copyright year is outdated, expected 2015 but got 2013
36:1: I100 Imports statements are in the wrong order. import tempfile should be before import zlib
37:1: I100 Imports statements are in the wrong order. import sys should be before import tempfile
38:1: F401 'traceback' imported but unused
40:1: I201 Missing newline before sections or imports.
47:1: I101 Imported names are in the wrong order. Should be cache_exists, delete_cache, delete_hp_change, get_cache, get_cache_post_date, get_record_last_modification_date, get_record_revision_author, uids_with_active_caches, update_cache, update_cache_post_date
48:5: E128 continuation line under-indented for visual indent
49:5: E128 continuation line under-indented for visual indent
50:5: E128 continuation line under-indented for visual indent
51:1: I101 Imported names are in the wrong order. Should be create_record, create_records, field_add_subfield, field_get_subfield_codes, field_get_subfield_values, print_rec, record_add_field, record_add_fields, record_delete_fields, record_get_field_instances, record_get_field_value, record_get_field_values, record_has_field, record_make_all_subfields_volatile, record_modify_controlfield, record_modify_subfield, record_order_subfields, record_strip_empty_fields, record_strip_empty_volatile_subfields, record_xml_output
60:1: I101 Imported names are in the wrong order. Should be CFG_BIBEDIT_EXTEND_RECORD_WITH_COLLECTION_TEMPLATE, CFG_BIBEDIT_LOCKLEVEL, CFG_BIBEDIT_QUEUE_CHECK_METHOD, CFG_BIBEDIT_TIMEOUT, CFG_BIBUPLOAD_EXTERNAL_OAIID_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_PYLIBDIR
60:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibsched.bibtask
60:1: F401 'CFG_PYLIBDIR' imported but unused
68:1: I101 Imported names are in the wrong order. Should be get_bibupload_task_opts, get_info_of_record_revision, get_marcxml_of_record_revision, get_record_revisions
68:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibedit.db_layer should be before from invenio.utils.text
71:1: I101 Imported names are in the wrong order. Should be get_all_collections_of_a_record, get_record, guess_primary_collection_of_a_record, record_exists
72:6: E126 continuation line over-indented for hanging indent
74:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
75:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email, get_user_info, get_user_preferences, list_registered_users
76:6: E126 continuation line over-indented for hanging indent
77:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.legacy.webuser
80:1: I100 Imports statements are in the wrong order. from invenio.legacy.refextract.api should be before from invenio.modules.access.engine
81:36: E126 continuation line over-indented for hanging indent
83:1: I101 Imported names are in the wrong order. Should be ParseError, transform_file
83:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord.textmarc2xmlmarc should be before from invenio.legacy.refextract.api
84:1: I101 Imported names are in the wrong order. Should be create_normalized_name, split_name_parts
84:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibauthorid.name_utils should be before from invenio.legacy.bibrecord.textmarc2xmlmarc
85:41: E126 continuation line over-indented for hanging indent
87:1: I100 Imports statements are in the wrong order. from invenio.modules.editor.registry should be before from invenio.modules.knowledge.api
90:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.modules.editor.registry
92:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcatalog.api should be before from invenio.legacy.webauthorprofile.config
110: D101 Docstring missing
113:1: E302 expected 2 blank lines, found 1
113: D203 Expected 1 blank line *before* class docstring, found 0
113: D204 Expected 1 blank line *after* class docstring, found 0
113: D400 First line should end with '.', not 's'
119:1: E302 expected 2 blank lines, found 1
119: D290 White spaces around docstring should be trimmed.
119: D400 First line should end with '.', not 'n'
119: D205 Blank line missing between one-line summary and description
123: D290 White spaces around docstring should be trimmed.
123: D400 First line should end with '.', not 'e'
166:1: E302 expected 2 blank lines, found 1
166: D103 Docstring missing
172:1: E302 expected 2 blank lines, found 1
172: D401 First line should be imperative: 'Thi', not 'This'
172: D400 First line should end with '.', not 'l'
172: D205 Blank line missing between one-line summary and description
223:1: E302 expected 2 blank lines, found 1
223: D400 First line should end with '.', not 'e'
223: D205 Blank line missing between one-line summary and description
238:1: E302 expected 2 blank lines, found 1
238: D401 First line should be imperative: 'Ha', not 'Has'
238: D400 First line should end with '.', not 'y'
238: D205 Blank line missing between one-line summary and description
246:1: E302 expected 2 blank lines, found 1
246: D400 First line should end with '.', not 'l'
246: D205 Blank line missing between one-line summary and description
272:1: E302 expected 2 blank lines, found 1
272: D400 First line should end with '.', not 'e'
272: D205 Blank line missing between one-line summary and description
279:1: E302 expected 2 blank lines, found 1
288:1: E302 expected 2 blank lines, found 1
299:1: E302 expected 2 blank lines, found 1
299: D400 First line should end with '.', not 'n'
299: D205 Blank line missing between one-line summary and description
310:1: E302 expected 2 blank lines, found 1
314:1: E302 expected 2 blank lines, found 1
314: D205 Blank line missing between one-line summary and description
325:1: E302 expected 2 blank lines, found 1
325: D103 Docstring missing
329:1: E302 expected 2 blank lines, found 1
329: D400 First line should end with '.', not 'm'
329: D205 Blank line missing between one-line summary and description
397: D400 First line should end with '.', not 'd'
397: D205 Blank line missing between one-line summary and description
410: D290 White spaces around docstring should be trimmed.
410: D400 First line should end with '.', not 'd'
410: D200 One-line docstring should not occupy 2 lines
422: D290 White spaces around docstring should be trimmed.
422: D400 First line should end with '.', not 'e'
422: D205 Blank line missing between one-line summary and description
445: D400 First line should end with '.', not 'e'
445: D205 Blank line missing between one-line summary and description
475:24: E713 test for membership should be 'not in'
484:1: E302 expected 2 blank lines, found 1
484: D401 First line should be imperative: 'Convert', not 'Converts'
484: D400 First line should end with '.', not 'p'
484: D200 One-line docstring should not occupy 3 lines
491:1: E302 expected 2 blank lines, found 1
491: D401 First line should be imperative: 'Convert', not 'Converts'
491: D400 First line should end with '.', not 'e'
491: D200 One-line docstring should not occupy 3 lines
503:1: E302 expected 2 blank lines, found 1
503: D400 First line should end with '.', not 'd'
511:1: E302 expected 2 blank lines, found 1
511: D209 Put multi-line docstring closing quotes on separate line
511: D400 First line should end with '.', not 's'
511: D205 Blank line missing between one-line summary and description
511: D208 Docstring is over-indented
524:1: E302 expected 2 blank lines, found 1
524: D205 Blank line missing between one-line summary and description
534:1: E302 expected 2 blank lines, found 1
534: D205 Blank line missing between one-line summary and description
545:1: E302 expected 2 blank lines, found 1
545: D205 Blank line missing between one-line summary and description
552:1: E302 expected 2 blank lines, found 1
552: D205 Blank line missing between one-line summary and description
572:1: E302 expected 2 blank lines, found 1
578:1: E302 expected 2 blank lines, found 1
578: D103 Docstring missing
585:1: E302 expected 2 blank lines, found 1
585: D205 Blank line missing between one-line summary and description
601: D290 White spaces around docstring should be trimmed.
601: D205 Blank line missing between one-line summary and description
622:9: E128 continuation line under-indented for visual indent
625:1: E302 expected 2 blank lines, found 1
625: D209 Put multi-line docstring closing quotes on separate line
625: D400 First line should end with '.', not ']'
625: D205 Blank line missing between one-line summary and description
625: D208 Docstring is over-indented
664:1: E302 expected 2 blank lines, found 1
664: D401 First line should be imperative: 'Return', not 'Returns'
664: D400 First line should end with '.', not ']'
669:1: E302 expected 2 blank lines, found 1
687: D205 Blank line missing between one-line summary and description
695:1: E302 expected 2 blank lines, found 1
708:1: E302 expected 2 blank lines, found 1
748:1: E302 expected 2 blank lines, found 1
766: D400 First line should end with '.', not 's'
766: D205 Blank line missing between one-line summary and description
787: D401 First line should be imperative: 'Return', not 'Returns'
787: D290 White spaces around docstring should be trimmed.
787: D400 First line should end with '.', not '0'
787: D205 Blank line missing between one-line summary and description
798:61: E128 continuation line under-indented for visual indent
799:61: E128 continuation line under-indented for visual indent
800:61: E128 continuation line under-indented for visual indent
801:61: E128 continuation line under-indented for visual indent
804: D290 White spaces around docstring should be trimmed.
804: D400 First line should end with '.', not 't'
804: D205 Blank line missing between one-line summary and description
819: D290 White spaces around docstring should be trimmed.
819: D400 First line should end with '.', not 't'
842:48: E128 continuation line under-indented for visual indent
848:1: E302 expected 2 blank lines, found 1
848: D400 First line should end with '.', not 'd'
892:1: E302 expected 2 blank lines, found 1
892: D400 First line should end with '.', not 't'
892: D205 Blank line missing between one-line summary and description
910: D400 First line should end with '.', not 'e'
910: D205 Blank line missing between one-line summary and description
928:5: E122 continuation line missing indentation or outdented
944:36: E127 continuation line over-indented for visual indent
945:36: E127 continuation line over-indented for visual indent
946:36: E127 continuation line over-indented for visual indent
947:36: E127 continuation line over-indented for visual indent
951: D400 First line should end with '.', not 'n'
1009: D401 First line should be imperative: 'Create', not 'Creates'
1009: D400 First line should end with '.', not 'e'
1009: D205 Blank line missing between one-line summary and description
1024: D400 First line should end with '.', not 'n'
1024: D205 Blank line missing between one-line summary and description
1044: D401 First line should be imperative: 'Change', not 'Changes'
1044: D400 First line should end with '.', not ','
1044: D205 Blank line missing between one-line summary and description
1062:9: E128 continuation line under-indented for visual indent
1072:13: E128 continuation line under-indented for visual indent
1075: D401 First line should be imperative: 'Return', not 'Returns'
1075: D290 White spaces around docstring should be trimmed.
1075: D400 First line should end with '.', not 'e'
1103: D103 Docstring missing
1117:25: E128 continuation line under-indented for visual indent
1156: D401 First line should be imperative: 'Load', not 'Loads'
1156: D205 Blank line missing between one-line summary and description
1172:52: E201 whitespace after '{'
1172:62: E203 whitespace before ':'
1172:89: E203 whitespace before ':'
1172:105: E202 whitespace before '}'


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2014
28:1: I201 Missing newline before sections or imports.
29:1: I100 Imports statements are in the wrong order. from datetime should be before from intbitset
29:1: I201 Missing newline before sections or imports.
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before from invenio.legacy.search_engine
35:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_indexer should be before from invenio.legacy.bibrank.citation_searcher
36:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibformat.dblayer should be before from invenio.legacy.bibrank.citation_indexer
38:1: I100 Imports statements are in the wrong order. from invenio.modules.records.api should be before from invenio.utils.shell
39:1: I101 Imported names are in the wrong order. Should be task_get_option, task_has_option, task_init, task_set_option, task_sleep_now_if_required, task_update_progress, write_message
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.modules.records.api
49: D103 Docstring missing
59: D103 Docstring missing
202:5: F841 local variable 'dummy' is assigned to but never used
264: D103 Docstring missing
440:18: E127 continuation line over-indented for visual indent