1: D100 Docstring missing
2: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I101 Imported names are in the wrong order. Should be cPickle, calendar, cgi, commands, datetime, os, random, time
23:16: E401 multiple imports on one line
25:1: I101 Imported names are in the wrong order. Should be CFG_BIBCIRCULATION_ILL_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CLAIMED, CFG_BIBCIRCULATION_ITEM_STATUS_IN_PROCESS, CFG_BIBCIRCULATION_ITEM_STATUS_NOT_ARRIVED, CFG_BIBCIRCULATION_ITEM_STATUS_ON_LOAN, CFG_BIBCIRCULATION_ITEM_STATUS_ON_ORDER, CFG_BIBCIRCULATION_ITEM_STATUS_ON_SHELF, CFG_BIBCIRCULATION_ITEM_STATUS_OPTIONAL, CFG_BIBCIRCULATION_REQUEST_STATUS_DONE, CFG_BINDIR, CFG_CERN_SITE, CFG_SITE_NAME, CFG_SITE_URL, CFG_TMPDIR
25:1: I201 Missing newline before sections or imports.
42:1: I101 Imported names are in the wrong order. Should be get_collection_reclist, get_most_popular_field_values, perform_request_search, search_pattern
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.utils.url
46:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
50:1: I101 Imported names are in the wrong order. Should be book_information_from_MARC, book_title_from_MARC
50:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.utils should be before from invenio.legacy.websubmit.admin_dblayer
52:1: I101 Imported names are in the wrong order. Should be get_borrower_data, get_id_bibrec
52:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.db_layer should be before from invenio.legacy.bibcirculation.utils
55:1: I101 Imported names are in the wrong order. Should be convert_datestruct_to_dategui, convert_datetext_to_datestruct
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.date
59:38: E261 at least two spaces before inline comment
64:1: E302 expected 2 blank lines, found 1
64: D401 First line should be imperative: 'Return', not 'Returns'
64: D400 First line should end with '.', not 'r'
64: D205 Blank line missing between one-line summary and description
88:25: E128 continuation line under-indented for visual indent
92:29: E128 continuation line under-indented for visual indent
92:61: E251 unexpected spaces around keyword / parameter equals
93:29: E128 continuation line under-indented for visual indent
94:29: E128 continuation line under-indented for visual indent
105:27: E128 continuation line under-indented for visual indent
108: D401 First line should be imperative: 'Return', not 'Returns'
108: D202 No blank lines allowed *after* function docstring, found 1
130:29: E128 continuation line under-indented for visual indent
131:29: E128 continuation line under-indented for visual indent
145: D290 White spaces around docstring should be trimmed.
145: D209 Put multi-line docstring closing quotes on separate line
145: D400 First line should end with '.', not 's'
145: D205 Blank line missing between one-line summary and description
154:29: E128 continuation line under-indented for visual indent
155:29: E126 continuation line over-indented for hanging indent
161:27: E128 continuation line under-indented for visual indent
164: D401 First line should be imperative: 'Return', not 'Returns'
164: D202 No blank lines allowed *after* function docstring, found 1
164: D400 First line should end with '.', not 't'
164: D205 Blank line missing between one-line summary and description
183:17: E128 continuation line under-indented for visual indent
184:29: E128 continuation line under-indented for visual indent
187: D401 First line should be imperative: 'Return', not 'Returns'
187: D400 First line should end with '.', not 't'
187: D205 Blank line missing between one-line summary and description
209:13: E128 continuation line under-indented for visual indent
212:13: E128 continuation line under-indented for visual indent
212:44: E251 unexpected spaces around keyword / parameter equals
213:13: E128 continuation line under-indented for visual indent
217: D401 First line should be imperative: 'Return', not 'Returns'
217: D400 First line should end with '.', not 'n'
217: D205 Blank line missing between one-line summary and description
237:21: E128 continuation line under-indented for visual indent
238:21: E128 continuation line under-indented for visual indent
242:21: E128 continuation line under-indented for visual indent
243:21: E128 continuation line under-indented for visual indent
247:25: E128 continuation line under-indented for visual indent
249:25: E128 continuation line under-indented for visual indent
258: D401 First line should be imperative: 'Return', not 'Returns'
258: D400 First line should end with '.', not 't'
258: D205 Blank line missing between one-line summary and description
281:17: E128 continuation line under-indented for visual indent
301:27: E128 continuation line under-indented for visual indent
304: D401 First line should be imperative: 'Return', not 'Returns'
304: D400 First line should end with '.', not 't'
304: D205 Blank line missing between one-line summary and description
322:13: E128 continuation line under-indented for visual indent
325: D401 First line should be imperative: 'Return', not 'Returns'
325: D400 First line should end with '.', not 'r'
325: D205 Blank line missing between one-line summary and description
347:17: E128 continuation line under-indented for visual indent
351:17: E128 continuation line under-indented for visual indent
358: D400 First line should end with '.', not ':'
358: D205 Blank line missing between one-line summary and description
429:37: E126 continuation line over-indented for hanging indent
430:10: E261 at least two spaces before inline comment
467: D400 First line should end with '.', not ':'
467: D205 Blank line missing between one-line summary and description
576:62: E502 the backslash is redundant between brackets
577:23: E128 continuation line under-indented for visual indent
588:13: E128 continuation line under-indented for visual indent
589:13: E128 continuation line under-indented for visual indent
590:13: E128 continuation line under-indented for visual indent
591:13: E128 continuation line under-indented for visual indent
597:13: E128 continuation line under-indented for visual indent
598:13: E128 continuation line under-indented for visual indent
599:13: E128 continuation line under-indented for visual indent
600:13: E128 continuation line under-indented for visual indent
601:13: E128 continuation line under-indented for visual indent
606: D400 First line should end with '.', not ':'
606: D205 Blank line missing between one-line summary and description
674: D400 First line should end with '.', not ':'
674: D205 Blank line missing between one-line summary and description
700: D401 First line should be imperative: 'Return', not 'Returns'
700: D400 First line should end with '.', not 's'
718:17: E128 continuation line under-indented for visual indent
720:17: E128 continuation line under-indented for visual indent
724:17: E128 continuation line under-indented for visual indent
725:17: E128 continuation line under-indented for visual indent
729:25: E128 continuation line under-indented for visual indent
731:25: E128 continuation line under-indented for visual indent
740: D400 First line should end with '.', not ':'
740: D205 Blank line missing between one-line summary and description
838: D400 First line should end with '.', not ':'
838: D205 Blank line missing between one-line summary and description
867:21: E127 continuation line over-indented for visual indent
898: D401 First line should be imperative: 'Return', not 'Returns'
898: D400 First line should end with '.', not 't'
898: D205 Blank line missing between one-line summary and description
944:19: E128 continuation line under-indented for visual indent
949:19: E128 continuation line under-indented for visual indent
949:66: E225 missing whitespace around operator
953:25: E128 continuation line under-indented for visual indent
955:25: E128 continuation line under-indented for visual indent
964: D400 First line should end with '.', not ':'
964: D205 Blank line missing between one-line summary and description
1015: D202 No blank lines allowed *after* function docstring, found 1
1015: D400 First line should end with '.', not ':'
1015: D205 Blank line missing between one-line summary and description
1080: D400 First line should end with '.', not ':'
1080: D205 Blank line missing between one-line summary and description
1123:57: E128 continuation line under-indented for visual indent
1138:9: E128 continuation line under-indented for visual indent
1141: D400 First line should end with '.', not ':'
1141: D205 Blank line missing between one-line summary and description
1200: D400 First line should end with '.', not ':'
1200: D205 Blank line missing between one-line summary and description
1236: D400 First line should end with '.', not ':'
1236: D205 Blank line missing between one-line summary and description
1282:1: E302 expected 2 blank lines, found 1
1343: D400 First line should end with '.', not 'n'
1343: D205 Blank line missing between one-line summary and description
1355:10: E261 at least two spaces before inline comment
1355:11: E262 inline comment should start with '# '
1377:83: E502 the backslash is redundant between brackets
1377:82: E211 whitespace before '('
1378:21: E128 continuation line under-indented for visual indent
1380:82: E502 the backslash is redundant between brackets
1380:81: E211 whitespace before '('
1381:21: E128 continuation line under-indented for visual indent
1383:82: E502 the backslash is redundant between brackets
1383:81: E211 whitespace before '('
1384:21: E128 continuation line under-indented for visual indent
1387:82: E502 the backslash is redundant between brackets
1387:81: E211 whitespace before '('
1388:21: E128 continuation line under-indented for visual indent
1395:1: E302 expected 2 blank lines, found 1
1395: D401 First line should be imperative: 'Build', not 'Builds'
1395: D400 First line should end with '.', not 'r'
1395: D205 Blank line missing between one-line summary and description
1447:1: E302 expected 2 blank lines, found 1
1447: D205 Blank line missing between one-line summary and description
1457:13: E127 continuation line over-indented for visual indent
1460:1: E302 expected 2 blank lines, found 1
1460: D401 First line should be imperative: 'Fetche', not 'Fetches'
1460: D400 First line should end with '.', not 't'
1460: D205 Blank line missing between one-line summary and description
1472:15: E711 comparison to None should be 'if cond is None:'
1472:15: E225 missing whitespace around operator
1472:32: E225 missing whitespace around operator
1476:5: B901 blind except: statement
1494:1: E302 expected 2 blank lines, found 1
1494: D401 First line should be imperative: 'Return', not 'Returns'
1494: D205 Blank line missing between one-line summary and description
1511:73: E502 the backslash is redundant between brackets
1512:25: E127 continuation line over-indented for visual indent
1516:77: E502 the backslash is redundant between brackets
1517:25: E127 continuation line over-indented for visual indent
1527:1: E302 expected 2 blank lines, found 1
1527: D401 First line should be imperative: 'Return', not 'Returns'
1527: D400 First line should end with '.', not 'n'
1527: D205 Blank line missing between one-line summary and description
1561:33: E128 continuation line under-indented for visual indent
1562:28: E211 whitespace before '('
1568:33: E128 continuation line under-indented for visual indent
1569:28: E211 whitespace before '('
1577:28: E211 whitespace before '('
1586:33: E128 continuation line under-indented for visual indent
1591:77: E502 the backslash is redundant between brackets
1591:76: E211 whitespace before '('
1592:21: E128 continuation line under-indented for visual indent
1594:1: E302 expected 2 blank lines, found 1
1594: D400 First line should end with '.', not 't'
1594: D205 Blank line missing between one-line summary and description
1607:13: E127 continuation line over-indented for visual indent
1609:1: E302 expected 2 blank lines, found 1
1609:33: E211 whitespace before '('
1609: D401 First line should be imperative: 'Return', not 'Returns'
1609: D205 Blank line missing between one-line summary and description
1618:73: E502 the backslash is redundant between brackets
1618:72: E211 whitespace before '('
1619:21: E128 continuation line under-indented for visual indent
1622:1: E302 expected 2 blank lines, found 1
1622: D401 First line should be imperative: 'Return', not 'Returns'
1622: D400 First line should end with '.', not 'r'
1622: D205 Blank line missing between one-line summary and description
1636:1: E303 too many blank lines (3)
1638:1: E302 expected 2 blank lines, found 3
1638: D401 First line should be imperative: 'Create', not 'Creates'
1638: D400 First line should end with '.', not 's'
1643: D401 First line should be imperative: 'Return', not 'Returns'
1643: D290 White spaces around docstring should be trimmed.
1643: D400 First line should end with '.', not 'g'
1648: D401 First line should be imperative: 'Return', not 'Returns'
1648: D400 First line should end with '.', not ')'
1653: D401 First line should be imperative: 'Return', not 'Returns'
1659: D401 First line should be imperative: 'Return', not 'Returns'
1659: D290 White spaces around docstring should be trimmed.
1659: D400 First line should end with '.', not 'g'
1665:1: E302 expected 2 blank lines, found 1
1665: D401 First line should be imperative: 'Return', not 'Returns'
1665: D400 First line should end with '.', not 'n'
1665: D205 Blank line missing between one-line summary and description
1698:12: E713 test for membership should be 'not in'
1705:34: E127 continuation line over-indented for visual indent
1708:34: E127 continuation line over-indented for visual indent
1711:34: E127 continuation line over-indented for visual indent
1724: D400 First line should end with '.', not 'y'
1724: D205 Blank line missing between one-line summary and description
1757:26: E127 continuation line over-indented for visual indent
1762:114: E261 at least two spaces before inline comment
1766:16: E713 test for membership should be 'not in'
1770:49: E502 the backslash is redundant between brackets
1771:42: E127 continuation line over-indented for visual indent
1773:48: E502 the backslash is redundant between brackets
1774:42: E127 continuation line over-indented for visual indent
1776:53: E502 the backslash is redundant between brackets
1777:42: E127 continuation line over-indented for visual indent
1791:21: E126 continuation line over-indented for hanging indent
1810: D400 First line should end with '.', not 'g'
1810: D205 Blank line missing between one-line summary and description
1824: D400 First line should end with '.', not 'g'
1824: D205 Blank line missing between one-line summary and description
1841:1: E302 expected 2 blank lines, found 1
1841: D401 First line should be imperative: 'Return', not 'Returns'
1841: D202 No blank lines allowed *after* function docstring, found 1
1841: D400 First line should end with '.', not 'r'
1884: D401 First line should be imperative: 'Create', not 'Creates'
1884: D400 First line should end with '.', not 'd'
1884: D205 Blank line missing between one-line summary and description
1948:1: E302 expected 2 blank lines, found 1
1948: D401 First line should be imperative: 'Create', not 'Creates'
1976: D401 First line should be imperative: 'Create', not 'Creates'
1976: D400 First line should end with '.', not 't'
1987:21: E128 continuation line under-indented for visual indent
1995:21: E126 continuation line over-indented for hanging indent
2034:37: E128 continuation line under-indented for visual indent
2043: D401 First line should be imperative: 'Create', not 'Creates'
2043: D400 First line should end with '.', not 'y'
2091:35: E127 continuation line over-indented for visual indent
2115: D401 First line should be imperative: 'Create', not 'Creates'
2115: D400 First line should end with '.', not 'y'
2141:25: E128 continuation line under-indented for visual indent
2166:21: E128 continuation line under-indented for visual indent
2166:60: E225 missing whitespace around operator
2167:21: E126 continuation line over-indented for hanging indent
2205:18: E222 multiple spaces after operator
2223:9: E113 unexpected indentation
2241:9: E113 unexpected indentation
2305:62: E203 whitespace before ':'
2309: D401 First line should be imperative: 'Return', not 'Returns'
2309: D290 White spaces around docstring should be trimmed.
2309: D400 First line should end with '.', not 'a'
2324: D401 First line should be imperative: 'Create', not 'Creates'
2361: D401 First line should be imperative: 'Create', not 'Creates'
2384:46: E502 the backslash is redundant between brackets
2385:21: E128 continuation line under-indented for visual indent
2411:1: E302 expected 2 blank lines, found 1
2411: D401 First line should be imperative: 'Return', not 'Returns'
2411: D400 First line should end with '.', not 'y'
2417: D401 First line should be imperative: 'Return', not 'Returns'
2417: D400 First line should end with '.', not 'y'
2429: D401 First line should be imperative: 'Return', not 'Returns'
2429: D400 First line should end with '.', not 'y'
2437:14: E128 continuation line under-indented for visual indent
2442: D401 First line should be imperative: 'Return', not 'Returns'
2442: D400 First line should end with '.', not 'y'
2447: D401 First line should be imperative: 'Return', not 'Returns'
2447: D400 First line should end with '.', not 'y'
2452: D401 First line should be imperative: 'Return', not 'Returns'
2452: D400 First line should end with '.', not 'y'
2457: D401 First line should be imperative: 'Return', not 'Returns'
2457: D400 First line should end with '.', not 'y'
2464: D401 First line should be imperative: 'Return', not 'Returns'
2464: D400 First line should end with '.', not 'y'
2472: D401 First line should be imperative: 'Return', not 'Returns'
2472: D400 First line should end with '.', not 'y'
2480: D401 First line should be imperative: 'Return', not 'Returns'
2480: D400 First line should end with '.', not 'y'
2488: D401 First line should be imperative: 'Return', not 'Returns'
2488: D400 First line should end with '.', not 's'
2492:10: E128 continuation line under-indented for visual indent
2496:1: E302 expected 2 blank lines, found 1
2496: D401 First line should be imperative: 'Export', not 'Exports'
2509: D401 First line should be imperative: 'Export', not 'Exports'
2519:66: E502 the backslash is redundant between brackets
2520:18: E128 continuation line under-indented for visual indent
2524: D401 First line should be imperative: 'Export', not 'Exports'
2544:68: E502 the backslash is redundant between brackets
2554:1: E302 expected 2 blank lines, found 1
2554: D400 First line should end with '.', not 'a'
2554: D205 Blank line missing between one-line summary and description
2563:64: E502 the backslash is redundant between brackets
2564:25: E127 continuation line over-indented for visual indent
2567: D400 First line should end with '.', not ','
2567: D205 Blank line missing between one-line summary and description
2622:13: E128 continuation line under-indented for visual indent
2623:13: E128 continuation line under-indented for visual indent
2624:13: E128 continuation line under-indented for visual indent
2625:13: E128 continuation line under-indented for visual indent
2626:13: E128 continuation line under-indented for visual indent
2627:13: E124 closing bracket does not match visual indentation
2627:13: E125 continuation line with same indent as next logical line
2643:13: E125 continuation line with same indent as next logical line
2649: D401 First line should be imperative: 'Return', not 'Returns'
2675:27: E128 continuation line under-indented for visual indent
2678: D401 First line should be imperative: 'Return', not 'Returns'
2678: D400 First line should end with '.', not ','
2678: D205 Blank line missing between one-line summary and description
2722:1: E302 expected 2 blank lines, found 1
2722: D401 First line should be imperative: 'Transform', not 'Transforms'
2722: D400 First line should end with '.', not 'e'
2722: D200 One-line docstring should not occupy 3 lines
2729: D401 First line should be imperative: 'Run', not 'Runs'
2729: D400 First line should end with '.', not 's'
2729: D205 Blank line missing between one-line summary and description
2743: D401 First line should be imperative: 'Return', not 'Returns'
2743: D400 First line should end with '.', not 'n'
2751: D401 First line should be imperative: 'Return', not 'Returns'
2751: D400 First line should end with '.', not 'm'
2760:13: E127 continuation line over-indented for visual indent
2763: D401 First line should be imperative: 'Return', not 'Returns'
2763: D400 First line should end with '.', not 'm'
2767:9: E125 continuation line with same indent as next logical line
2772: D401 First line should be imperative: 'Return', not 'Returns'
2772: D400 First line should end with '.', not 't'
2780: D401 First line should be imperative: 'Return', not 'Returns'
2780: D400 First line should end with '.', not 's'
2784:33: E713 test for membership should be 'not in'
2784:54: E261 at least two spaces before inline comment
2789: D401 First line should be imperative: 'Return', not 'Returns'
2789: D400 First line should end with '.', not 'm'
2797: D400 First line should end with '.', not 'e'
2797: D200 One-line docstring should not occupy 3 lines
2809:1: E302 expected 2 blank lines, found 1
2815:1: E302 expected 2 blank lines, found 1
2820:1: E302 expected 2 blank lines, found 1
2827:1: E302 expected 2 blank lines, found 1
2833:1: E302 expected 2 blank lines, found 1
2846:1: E302 expected 2 blank lines, found 1
2851:37: E128 continuation line under-indented for visual indent
2853:10: E128 continuation line under-indented for visual indent
2854:10: E128 continuation line under-indented for visual indent
2855:10: E128 continuation line under-indented for visual indent
2856:10: E128 continuation line under-indented for visual indent
2857:10: E128 continuation line under-indented for visual indent
2858:10: E128 continuation line under-indented for visual indent


1: D100 Docstring missing
2: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I101 Imported names are in the wrong order. Should be cgi, datetime, os, urllib
21:16: E401 multiple imports on one line
23:1: I101 Imported names are in the wrong order. Should be CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_URL, CFG_WEBDIR
23:1: I201 Missing newline before sections or imports.
24:6: E126 continuation line over-indented for hanging indent
30:1: E302 expected 2 blank lines, found 1
30: D101 Docstring missing
32: D401 First line should be imperative: 'Generate', not 'Generates'
32: D200 One-line docstring should not occupy 3 lines
41: D401 First line should be imperative: 'Generate', not 'Generates'
41: D400 First line should end with '.', not 'r'
41: D205 Blank line missing between one-line summary and description
58:21: E126 continuation line over-indented for hanging indent
66:21: E126 continuation line over-indented for hanging indent
66:74: E502 the backslash is redundant between brackets
67:21: E128 continuation line under-indented for visual indent
76: D401 First line should be imperative: 'Generate', not 'Generates'
76: D200 One-line docstring should not occupy 3 lines
92:33: E126 continuation line over-indented for hanging indent
92:64: E502 the backslash is redundant between brackets
93:33: E128 continuation line under-indented for visual indent
97:33: E126 continuation line over-indented for hanging indent
97:64: E502 the backslash is redundant between brackets
98:33: E128 continuation line under-indented for visual indent
103:21: E128 continuation line under-indented for visual indent
107:5: E303 too many blank lines (2)
107: D401 First line should be imperative: 'Generate', not 'Generates'
107: D200 One-line docstring should not occupy 3 lines
139: D401 First line should be imperative: 'Generate', not 'Generates'
139: D200 One-line docstring should not occupy 3 lines
151:9: E303 too many blank lines (2)
162: D401 First line should be imperative: 'Generate', not 'Generates'
162: D400 First line should end with '.', not 's'
162: D200 One-line docstring should not occupy 3 lines
169: D400 First line should end with '.', not 'r'
169: D200 One-line docstring should not occupy 3 lines
178: D401 First line should be imperative: 'Generate', not 'Generates'
178: D400 First line should end with '.', not 's'
178: D200 One-line docstring should not occupy 3 lines
202:8: E122 continuation line missing indentation or outdented
203:8: E122 continuation line missing indentation or outdented
209: D200 One-line docstring should not occupy 3 lines
217: D400 First line should end with '.', not 't'
217: D200 One-line docstring should not occupy 3 lines
227: D200 One-line docstring should not occupy 3 lines
239:25: E126 continuation line over-indented for hanging indent
239:57: E502 the backslash is redundant between brackets
240:25: E128 continuation line under-indented for visual indent
243: D400 First line should end with '.', not 't'
243: D205 Blank line missing between one-line summary and description
267:26: E711 comparison to None should be 'if cond is None:'
275:17: E711 comparison to None should be 'if cond is None:'
275:17: E225 missing whitespace around operator
280:19: E271 multiple spaces after keyword
282: D401 First line should be imperative: 'Generate', not 'Generates'
282: D200 One-line docstring should not occupy 3 lines
298:33: E126 continuation line over-indented for hanging indent
298:64: E502 the backslash is redundant between brackets
299:33: E128 continuation line under-indented for visual indent
303:33: E126 continuation line over-indented for hanging indent
303:64: E502 the backslash is redundant between brackets
304:33: E128 continuation line under-indented for visual indent
309: D401 First line should be imperative: 'Generate', not 'Generates'
309: D200 One-line docstring should not occupy 3 lines
320:25: E127 continuation line over-indented for visual indent
323:17: E127 continuation line over-indented for visual indent
326: D102 Docstring missing
336: D200 One-line docstring should not occupy 3 lines
376: D401 First line should be imperative: 'Provide', not 'Provides'
376: D200 One-line docstring should not occupy 3 lines
382: D401 First line should be imperative: 'Generate', not 'Generates'
407:72: E261 at least two spaces before inline comment
408:21: E128 continuation line under-indented for visual indent
408:54: E261 at least two spaces before inline comment
409:27: E261 at least two spaces before inline comment
410:60: E261 at least two spaces before inline comment
411:26: E261 at least two spaces before inline comment
414:72: E261 at least two spaces before inline comment
415:21: E128 continuation line under-indented for visual indent
415:54: E261 at least two spaces before inline comment
416:27: E261 at least two spaces before inline comment
417:36: E261 at least two spaces before inline comment
418:50: E261 at least two spaces before inline comment
421:58: E261 at least two spaces before inline comment
422:21: E128 continuation line under-indented for visual indent
422:36: E261 at least two spaces before inline comment
439: D401 First line should be imperative: 'Generate', not 'Generates'
474:72: E261 at least two spaces before inline comment
475:21: E128 continuation line under-indented for visual indent
475:54: E261 at least two spaces before inline comment
476:27: E261 at least two spaces before inline comment
477:60: E261 at least two spaces before inline comment
478:26: E261 at least two spaces before inline comment
481:72: E261 at least two spaces before inline comment
482:21: E128 continuation line under-indented for visual indent
482:54: E261 at least two spaces before inline comment
483:27: E261 at least two spaces before inline comment
484:36: E261 at least two spaces before inline comment
485:50: E261 at least two spaces before inline comment
490:17: E128 continuation line under-indented for visual indent
508:53: E128 continuation line under-indented for visual indent
509:53: E128 continuation line under-indented for visual indent
510:53: E128 continuation line under-indented for visual indent
511:53: E128 continuation line under-indented for visual indent
514:53: E128 continuation line under-indented for visual indent
515:53: E128 continuation line under-indented for visual indent
516:53: E128 continuation line under-indented for visual indent
517:53: E128 continuation line under-indented for visual indent
522:95: E502 the backslash is redundant between brackets
534:13: E128 continuation line under-indented for visual indent
541:45: E128 continuation line under-indented for visual indent
544:21: E128 continuation line under-indented for visual indent
586:25: E128 continuation line under-indented for visual indent
587:25: E128 continuation line under-indented for visual indent
588:25: E128 continuation line under-indented for visual indent
589:25: E128 continuation line under-indented for visual indent
590:25: E128 continuation line under-indented for visual indent
591:25: E128 continuation line under-indented for visual indent
592:25: E128 continuation line under-indented for visual indent
592:77: E502 the backslash is redundant between brackets
593:33: E127 continuation line over-indented for visual indent
703: D401 First line should be imperative: 'Display', not 'Displays'
703: D400 First line should end with '.', not 'd'
711: D401 First line should be imperative: 'Display', not 'Displays'
711: D400 First line should end with '.', not 'd'
715:37: E128 continuation line under-indented for visual indent
719: D401 First line should be imperative: 'Display', not 'Displays'
719: D400 First line should end with '.', not 'd'
727: D400 First line should end with '.', not 's'
736:53: E128 continuation line under-indented for visual indent
743: D400 First line should end with '.', not ')'
763:9: E303 too many blank lines (2)
804: D401 First line should be imperative: 'Generate', not 'Generates'
804: D400 First line should end with '.', not ')'
804: D205 Blank line missing between one-line summary and description
814: D401 First line should be imperative: 'Aggregate', not 'Aggregates'
814: D400 First line should end with '.', not 'e'
814: D205 Blank line missing between one-line summary and description
882: D401 First line should be imperative: 'Generate', not 'Generates'
882: D202 No blank lines allowed *after* method docstring, found 2
908:9: E303 too many blank lines (2)
936:21: E128 continuation line under-indented for visual indent
937:33: E128 continuation line under-indented for visual indent
980: D401 First line should be imperative: 'Generate', not 'Generates'


1: D400 First line should end with '.', not 'o'
1: D200 One-line docstring should not occupy 3 lines
2: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. import cgi should be before import time
27:1: I100 Imports statements are in the wrong order. import sys should be before import urllib
28:1: I100 Imports statements are in the wrong order. import string should be before import sys
31:1: I201 Missing newline before sections or imports.
32:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_VERSION, CFG_WEBLINKBACK_TRACKBACK_ENABLED, CFG_WEBSTYLE_TEMPLATE_SKIN
32:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.ext.template
32:1: F401 'CFG_SITE_SECURE_URL' imported but unused
32:1: F401 'CFG_SITE_RECORD' imported but unused
32:1: F401 'CFG_WEBLINKBACK_TRACKBACK_ENABLED' imported but unused
32:1: F401 'CFG_VERSION' imported but unused
32:1: F401 'CFG_WEBSTYLE_TEMPLATE_SKIN' imported but unused
33:6: E126 continuation line over-indented for hanging indent
46:1: I101 Imported names are in the wrong order. Should be gettext_set_language, is_language_rtl, language_list_long
46:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
46:1: F401 'is_language_rtl' imported but unused
47:1: I101 Imported names are in the wrong order. Should be create_html_link, get_canonical_and_alternates_urls, make_canonical_urlargd
47:1: F401 'get_canonical_and_alternates_urls' imported but unused
48:30: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.utils.date should be before from invenio.utils.url
49:1: F401 'convert_datestruct_to_dategui' imported but unused
50:31: E126 continuation line over-indented for hanging indent
51:1: I100 Imports statements are in the wrong order. from invenio.modules.formatter should be before from invenio.utils.date
53:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.utils.html
57: D101 Docstring missing
59: D202 No blank lines allowed *after* method docstring, found 1
59: D400 First line should end with '.', not 'y'
59: D208 Docstring is over-indented
111: D401 First line should be imperative: 'Create', not 'Creates'
111: D400 First line should end with '.', not 'e'
111: D208 Docstring is over-indented
200: D401 First line should be imperative: 'Create', not 'Creates'
200: D202 No blank lines allowed *after* method docstring, found 1
200: D400 First line should end with '.', not 'r'
200: D208 Docstring is over-indented
261: D401 First line should be imperative: 'Create', not 'Creates'
261: D400 First line should end with '.', not 'r'
261: D208 Docstring is over-indented
290: D202 No blank lines allowed *after* method docstring, found 1
290: D400 First line should end with '.', not 'e'
290: D205 Blank line missing between one-line summary and description
290: D208 Docstring is over-indented
327:18: E126 continuation line over-indented for hanging indent
333: D401 First line should be imperative: 'Produce', not 'Produces'
333: D202 No blank lines allowed *after* method docstring, found 1
333: D208 Docstring is over-indented
369:13: B901 blind except: statement
369:20: E261 at least two spaces before inline comment
389:21: B901 blind except: statement
391:34: E261 at least two spaces before inline comment
441:17: E126 continuation line over-indented for hanging indent
441:28: E203 whitespace before ':'
444:37: E502 the backslash is redundant between brackets
445:24: E131 continuation line unaligned for hanging indent
447:24: E203 whitespace before ':'
448:24: E203 whitespace before ':'
449:31: E502 the backslash is redundant between brackets
449:28: E203 whitespace before ':'
450:21: E131 continuation line unaligned for hanging indent
451:90: E225 missing whitespace around operator
452:28: E203 whitespace before ':'
453:28: E203 whitespace before ':'
454:28: E203 whitespace before ':'
455:28: E203 whitespace before ':'
456:28: E203 whitespace before ':'
457:28: E203 whitespace before ':'
458:28: E203 whitespace before ':'
459:28: E203 whitespace before ':'
460:29: E203 whitespace before ':'
461:62: E502 the backslash is redundant between brackets
461:28: E203 whitespace before ':'
461:37: E225 missing whitespace around operator
462:34: E131 continuation line unaligned for hanging indent
462:67: E502 the backslash is redundant between brackets
463:34: E131 continuation line unaligned for hanging indent
464:15: E126 continuation line over-indented for hanging indent
467: D401 First line should be imperative: 'Print', not 'Prints'
472:53: E251 unexpected spaces around keyword / parameter equals
472:55: E251 unexpected spaces around keyword / parameter equals
472:78: E251 unexpected spaces around keyword / parameter equals
472:80: E251 unexpected spaces around keyword / parameter equals
532:41: E231 missing whitespace after ':'
533:41: E231 missing whitespace after ':'
534:42: E231 missing whitespace after ':'
537:41: E231 missing whitespace after ':'
538:39: E231 missing whitespace after ':'
539:41: E231 missing whitespace after ':'
540:42: E231 missing whitespace after ':'
549:9: E303 too many blank lines (2)
571:9: E303 too many blank lines (2)
583:30: E231 missing whitespace after ':'
584:38: E231 missing whitespace after ':'
589: D401 First line should be imperative: 'Print', not 'Prints'
619:69: E502 the backslash is redundant between brackets
623:41: E231 missing whitespace after ','
633:21: E203 whitespace before ':'
634:19: E203 whitespace before ':'
635:17: E126 continuation line over-indented for hanging indent
644:5: E303 too many blank lines (2)
644: D401 First line should be imperative: 'Display', not 'Displays'
644: D400 First line should end with '.', not 'd'
644: D205 Blank line missing between one-line summary and description
644: D208 Docstring is over-indented
662:9: F841 local variable '_' is assigned to but never used
685:9: E122 continuation line missing indentation or outdented
686:9: E122 continuation line missing indentation or outdented
686:13: E231 missing whitespace after ':'
687:9: E122 continuation line missing indentation or outdented
687:16: E231 missing whitespace after ':'
688:9: E122 continuation line missing indentation or outdented
689:9: E122 continuation line missing indentation or outdented
689:18: E231 missing whitespace after ':'
690:9: E122 continuation line missing indentation or outdented
705:21: E203 whitespace before ':'
706:22: E203 whitespace before ':'
707:22: E203 whitespace before ':'
708:21: E203 whitespace before ':'
709:93: E203 whitespace before ':'
713: D401 First line should be imperative: 'Produce', not 'Produces'
713: D202 No blank lines allowed *after* method docstring, found 1
713: D400 First line should end with '.', not 't'
725:9: F841 local variable '_' is assigned to but never used
729: D401 First line should be imperative: 'Return', not 'Returns'
729: D202 No blank lines allowed *after* method docstring, found 1


1: D100 Docstring missing
2: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. import errno should be before import os
25:1: I100 Imports statements are in the wrong order. import cgi should be before import time
27:1: I100 Imports statements are in the wrong order. import shutil should be before import sys
30:1: I100 Imports statements are in the wrong order. from collections should be before from urllib
33:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_CERN_SITE, CFG_PREFIX, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_WEBSUBMIT_STORAGEDIR
33:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibrecord
34:6: E126 continuation line over-indented for hanging indent
42:1: I101 Imported names are in the wrong order. Should be CrossrefError, get_marcxml_for_doi
43:1: I100 Imports statements are in the wrong order. from invenio.utils should be before from invenio.utils.crossref
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.utils
46:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
47:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.modules.access.control
48:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, page_not_authorized
49:29: E126 continuation line over-indented for hanging indent
51:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
51:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.modules.records.access
53:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
54:1: I101 Imported names are in the wrong order. Should be decompose_file, propose_next_docname, stream_file
56:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
58:1: I101 Imported names are in the wrong order. Should be InvenioWebSubmitIconCreatorError, create_icon
58:1: I100 Imports statements are in the wrong order. from invenio.legacy.websubmit.icon_creator should be before from invenio.utils.html
59:1: I100 Imports statements are in the wrong order. from invenio.legacy.ckeditor.connector should be before from invenio.legacy.websubmit.icon_creator
62:1: F401 'get_detailed_page_tabs' imported but unused
63:1: I101 Imported names are in the wrong order. Should be CFG_JSON_AVAILABLE, json
64:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.utils.json
65:1: I100 Imports statements are in the wrong order. from flask should be before import invenio.legacy.template
65:1: I201 Missing newline before sections or imports.
70:1: I101 Imported names are in the wrong order. Should be action, endaction, home, interface, makeCataloguesTable
72:1: E302 expected 2 blank lines, found 1
72: D101 Docstring missing
74:77: E502 the backslash is redundant between brackets
75:79: E502 the backslash is redundant between brackets
78: D400 First line should end with '.', not 'r'
78: D205 Blank line missing between one-line summary and description
105:16: E127 continuation line over-indented for visual indent
127:13: B901 blind except: statement
134:9: B901 blind except: statement
141:61: E225 missing whitespace around operator
192:25: F841 local variable 'n' is assigned to but never used
211:34: E201 whitespace after '{'
211:57: E203 whitespace before ':'
212:57: E203 whitespace before ':'
212:69: E261 at least two spaces before inline comment
213:57: E203 whitespace before ':'
214:57: E203 whitespace before ':'
215:57: E203 whitespace before ':'
216:57: E203 whitespace before ':'
216:67: E261 at least two spaces before inline comment
217:57: E203 whitespace before ':'
251:5: E303 too many blank lines (2)
251: D202 No blank lines allowed *after* method docstring, found 1
251: D205 Blank line missing between one-line summary and description
258: D290 White spaces around docstring should be trimmed.
258: D400 First line should end with '.', not 'm'
281:16: E127 continuation line over-indented for visual indent
303:13: B901 blind except: statement
304:17: F841 local variable 'act' is assigned to but never used
373:63: E127 continuation line over-indented for visual indent
416:41: E128 continuation line under-indented for visual indent
417:41: E128 continuation line under-indented for visual indent
418:41: E128 continuation line under-indented for visual indent
422:25: B901 blind except: statement
456:26: E703 statement ends with a semicolon
535: D205 Blank line missing between one-line summary and description
547:16: E127 continuation line over-indented for visual indent
548:16: E127 continuation line over-indented for visual indent
556:9: E303 too many blank lines (2)
569:9: B901 blind except: statement
586:19: E126 continuation line over-indented for hanging indent
590:35: E231 missing whitespace after ','
593:30: E201 whitespace after '{'
593:53: E203 whitespace before ':'
594:53: E203 whitespace before ':'
595:53: E203 whitespace before ':'
596:53: E203 whitespace before ':'
597:53: E203 whitespace before ':'
598:53: E203 whitespace before ':'
598:63: E261 at least two spaces before inline comment
599:53: E203 whitespace before ':'
612:64: F841 local variable 'e' is assigned to but never used
625: D401 First line should be imperative: 'Thi', not 'This'
625: D290 White spaces around docstring should be trimmed.
625: D400 First line should end with '.', not 'g'
625: D205 Blank line missing between one-line summary and description
633:26: E261 at least two spaces before inline comment
634:32: E261 at least two spaces before inline comment
635:33: E113 unexpected indentation
638:47: E261 at least two spaces before inline comment
652: D401 First line should be imperative: 'Return', not 'Returns'
652: D400 First line should end with '.', not 'e'
652: D205 Blank line missing between one-line summary and description
663:9: F841 local variable 'uid' is assigned to but never used
664:9: F841 local variable 'user_info' is assigned to but never used
669:74: E502 the backslash is redundant between brackets
670:62: E502 the backslash is redundant between brackets
670:39: E221 multiple spaces before operator
681: D200 One-line docstring should not occupy 3 lines
709:44: E203 whitespace before ':'
724:9: F841 local variable 'myQuery' is assigned to but never used
755:36: E126 continuation line over-indented for hanging indent
765:22: E211 whitespace before '('
781: D400 First line should end with '.', not ')'
789:37: W602 deprecated form of raising exception
807:32: E203 whitespace before ':'
815: D102 Docstring missing
828:9: F841 local variable 't' is assigned to but never used
829:15: E221 multiple spaces before operator
840:9: F841 local variable 'nbFields' is assigned to but never used
846:24: E126 continuation line over-indented for hanging indent
846:35: E203 whitespace before ':'
847:31: E203 whitespace before ':'
848:30: E203 whitespace before ':'
849:30: E203 whitespace before ':'
850:23: E126 continuation line over-indented for hanging indent
852:59: E231 missing whitespace after ','
855:47: E231 missing whitespace after ','
856:52: E231 missing whitespace after ','
863:18: E126 continuation line over-indented for hanging indent
863:20: E251 unexpected spaces around keyword / parameter equals
863:22: E251 unexpected spaces around keyword / parameter equals
864:24: E251 unexpected spaces around keyword / parameter equals
864:26: E251 unexpected spaces around keyword / parameter equals
865:16: E126 continuation line over-indented for hanging indent
867: D401 First line should be imperative: 'Return', not 'Returns'
867: D200 One-line docstring should not occupy 3 lines
899: D102 Docstring missing
932:45: E127 continuation line over-indented for visual indent
941:62: E203 whitespace before ':'
941:109: E203 whitespace before ':'
941:129: E203 whitespace before ','
942:48: E126 continuation line over-indented for hanging indent
945:41: E128 continuation line under-indented for visual indent
950:62: E203 whitespace before ':'
950:109: E203 whitespace before ':'
950:129: E203 whitespace before ','
951:48: E126 continuation line over-indented for hanging indent
954:41: E128 continuation line under-indented for visual indent
964:62: E203 whitespace before ':'
964:109: E203 whitespace before ':'
964:129: E203 whitespace before ','
965:45: E126 continuation line over-indented for hanging indent
974:27: E225 missing whitespace around operator


ok


I just removed it. It was left behind from the last time I was working on the module.


@ldacosta totally works


@Hywan problem with this is that GEO is a 'FlatText' in vCard 3

vCard 3 is still a lot more common... I'm not sure if it's a good idea to default to URI for that one. I also don't have a great solution yet for cases where the default property type changed between versions... so idk at the moment what to do with this.


Minifying all assets is just optimization 101. Sure, it won't have huge benefits in this case but it generally helps.

Anyway, I simply wanted to add a solution with the current toolset, but I can't make it work right. I'm pretty sure it's a simple thing but since I'm not familiar with streams and stuff, I cannot solve.


@HuffMoody - the `-w` option doesn't work that way. You should be able to get your setup working if you properly set up these 3:
1. your working directory (where you run guard)
2. the Guardfile directory
3. the watched directory

See this for details: https://github.com/guard/guard/wiki/Correctly-using-the---watchdir-option

(It's about the watchdir option, but it should help you get the setup working with a VM - feel free to add an example in the wiki)

If you can't get things working, open an issue and we'll sort it out.


Published to http://vui-docs-internal.s3-website-us-east-1.amazonaws.com/33_cc51318f88016579813af4580fe6c0c1f247ec34


You shouldn't and **cannot** evaluate the dereferenced field. A reference holds a *value* in the form of an `expval`, which is an invalid argument to `value-of` which only takes an `expression`.


some tests failed:
failure: http://buildbot.bos1/builders/test-clique/builds/36


This can be update based on the comments above


I attempted to make this a function but it becamse a little unwieldy, since it needs access to the `instance` and `user` as well.  I'm leaving this as-is


Why is source_instance a string here? Is this not integer? 0-(N-1) where N is the number on application instances?


Is this going to regenerate the thumbnail URL every time for submissions that have already been processed?


You don't need the bracket if there is only one statement following the condition. I'll look into it though.


Same here. We can delete the old submission, as long as the engagement index points for students that have liked/disliked/commented remain


No, the media-, generic- and attachment processor should only be called for new or updated submissions. The logic that checks whether it's a new or update submissions is in the submission processor


If you disable release mode (in utilities.ts), a `checkReturnValue` function in the interpreter can check for invalid return values. It doesn't test for integer return values, but it can easily be extended.


I'd vote for suboptimal. It's pretty corner case, and we already gave a good enough reason to always use sharp-quote for functions.

This would be more of a case for `cl-labels` documentation.


DONE in 87d531ad9ac9668b2766a5b2329462d8720201b5


DONE in 36d323735d8142db6beb2c7c7d11ee75f505c570


   Варианты появления Лизы:
1. Она приедет вместе с Сергеем.
2. Она будет в лагере до Сергея.
3. Странноватый. Через некоторое время после приезда Сергея, в лес рядом с "Совёнком" упадёт Союз с Лизай на борту. Скорее всего у неё будет амнезия.

    Набросок сцены в автобусе (вариант появления Лизы 2 или 3)
Сергей открывает глаза и не доумевает, что произошло. Ведь он только что заснул ( Зависит от принятого начала истории). Через некоторое время он понимает, что автобус ему кажеться знакомым. Встав и пройдясь немного по салону он замечает в окне ворота лагеря "Совёнок". Резко хватается за спинку кресла, чтобы не упасть от удивления. " Какого чёрта"- говорит Серёга не отрывая руки от кресла. Затем подходит к бардочку водителя и дастоёт от туда пачку сигарет с фразай "Кто знает, что может пригодиться в этом странном мире!?"  Потом он выходит из автобуса, обходит несколько раз вокруг него и направляется в сторону ворот.


@Docker-J 현재 기존에 있는 툴체인으로 테스트 중이구요, 다음 정식 버전에서 해볼 예정입니다. 그동안은 실험 버전으로 쭉 릴리즈 될거구요.


This is overkill logging. You are already doing this logging on the service side in Server.java - what is the point to log the same on every call stack level?


If the glyph happens to have no ink (a space character), xMin == xMax, and in that case we use advance width.  The new code uses advance width always so it's a non-issue.


I know, but I mention if we "should" add a way to track other drop types "e.g. from mob, item" ...
But it is k, if we only support the user.


In the terminal returns me this message, perhaps the standard port on harp.js.

[BS] Proxying: http://localhost:9000
[BS] Now you can access your site through the following addresses:
[BS] Local URL: http://localhost:3000


Don’t understand how `:eid` gets into the frame. From what I see at this point there should be only `:eids` key


OSF returns metadata without the leading `/` so it is expected at times to not have a leading `/` where as `OsfstorageFolderMetadata` is generated by waterbutler and should always have a leading `/`. If it doesn't I'd prefer it to raise errors so we find out that the behavior changed.


That is actually bigger than image-type though :p

https://github.com/sindresorhus/image-type/blob/master/index.js

In your module, just depend on `file-type` directly and do the same filtering, but with less extensions as `image-type`.


This function could be used by two different providers or auth methods and the `ttl` could be different in each.


Emacs doesn't require a semicolon in the `-*- language -*-`case.  Not sure about `mode:`.


This call to navigate causes problems. The really odd thing is that if I slip a `browser()`before navigate, I can manually navigate to <http://localhost:4848/htmltest> in firefox and then get the page source with remDr$getPageSource(). So, remDr must exist in this context, but for some reason the navigate method doesn't work.


This revision appears to break onewire support in WebIOPi.
Not sure if the issue is with WebIOPi or the firmware.


I get a NPE here, I believe it is because I have @RequestMapping(value = "/foo") at the class level, and then @RequestMapping(value = "", method = RequestMethod.POST) at the method level (providing a POST method at /foo).  I propose checking for empty here:
```java
if(StringUtils.isNotEmpty(path) && path.charAt(0)=='/'){
```


TeamCity Hyrise :: Unit Tests [Build 72](http://ares.epic.hpi.uni-potsdam.de/hyrise-build/viewLog.html?buildId=80&buildTypeId=Hyrise_UnitTests) is now running


Probably in the end it would be a good idea to have a way to easily turn this off, and replace it with own styles.
For now I solved my issue of the required messages no more appearing with this line (leveraging foundation's mixins):

    .required.message {
        @include form-error-message;
    }

All good here thanks - I've been using Foundation for my last few projects, and am getting really happy with the grunt+libsass+foundation bundle.


saw approval from macintux
at https://github.com/basho/riak_kv/commit/7a6acbef535d25255d5c72c5a7b4fb46a69ae657


merging basho/riak_kv/bug/rdb/gh-riak-667 = 7a6acbef into borshop-integration-1076-bug/rdb/gh-riak-667


basho/riak_kv/bug/rdb/gh-riak-667 = 7a6acbef merged ok, testing candidate = fe1098b2


This variable is set but never used...


I found why, will commit a fix


For delete_all...it is possible to do it with AF::Relation:

MediaObject.where(documents.collect {|id| "id:#{RSolr.escape(id)}" }.join(" ")).delete_all

But that returns a number and not an array so it kind of breaks the pattern we were setting up.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


why not move the special cased prototypes in `v7_get` so that C users can have the illusion those objects have those properties?


Waarom `select top 1`? Volgens mij kun je hier `con.Select(p => p.Name == playlistName)` gebruiken.


good catch


TeamCity Hyrise :: Unit Tests [Build 72](http://ares.epic.hpi.uni-potsdam.de/hyrise-build/viewLog.html?buildId=80&buildTypeId=Hyrise_UnitTests) outcome was **SUCCESS**
Summary: Running Build time: 00:03:34


No need to import from java.lang


Probably. I considered rewriting a larger part of the procedure to make it simpler, but I went for the most straight-forward solution first.


Remove unused imports


This doesn't actually appear to have done anything because it's still the same list for December as before


That line 13 is causing problems for me because my `io.stderr` doesn't have a `print`. Should it be `write` instead of `print`?


FYI: I used to identify meal type by appending (breakfast) (lunch) (dinner)... it is now not so needed because the meal would belong to breakfast/lunch/dinner category... (but doesn't hurt to leave this code although not necesary)


This is about Initialize The GitHub


Components should also include `:db/id` (at least they do in Datomic)


Merged ...

@bbroerman30 Thanks for working that out. Any chance of seeing 5.6/5.5 backports soon? I don't believe the affected code has changed too much across those versions. I believe it's just an addition of a line for protocol renegotiation rate-limiting in 5.6 from 5.5 and the internal ABI differences from 5.6 to master.

@weltling Windows build worked fine for me locally with https://github.com/php/php-src/pull/1033 so we should be good now.


You've got a debug statement here!


As I work on getting this module in shape I'll add an option to load the extra css. I have a local branch I'm working on that is using the YAML config.


doh!


:x:


Hoe dan?


What about global preferences? I am attempting to migrate from a Windows Jenkins server to linux server, but still using existing Windows slaves. I need to set global Workspace for the linux server so it does not interfere with existing slave jobs triggered from Windows server.


This deals with the issue we were discussing yesterday, right? Is there anything else you wanted to do for that? If not, I can close that JIRA ticket.


@IDragonfire So something like this:
````java
DropCause getDropCause();
````
````java
public interface DropCause {
    [...]
}
````

````java
public final class DropCauses {
    public static final DropCause PLAYER = null;
    public static final DropCause DROPPER = null;
    public static final DropCause DISPENSER = null;
    public static final DropCause ENTITY = null;
    public static final DropCause DEATH_LOOT = null;
    public static final DropCause UNKNOWN = null;
}
````


I use relative paths for my document base, so at this point domain is still "" for me.  This causes a problem because my basePath starts out as "/foo-docs" and then ends up here with "/foo-docs/".  This causes a problem in swagger because it adds "/foo-resource" to the base path, which I end up with "/foo-docs//foo-resource".  I think you should also check to make sure that domain is not empty here before adding the trailing slash to bPath:
```java
if(bPath.lastIndexOf('/')!=(bPath.length()-1) && StringUtils.isNotEmpty(domain)){
```
or move the path separator down to the return statement at line 172:
```java
return StringUtils.isNotEmpty(domain) ? bPath+'/'+domain : bPath;
```


debug statment!


Comentario de código: bla,bla


otro comentario


Looks like James is broken in two ways.

1. What you initially wrote there should have worked I think. `read().write()` pair appends but `read().transform().write()` doesn't. That isn't logical.
2. To work around that I tried using `james.wait`. The problem is that `james.list().map()` returns `undefined` instead of a promise like in their docs. `james.wait` expects a promise to work. That means there is no way to detect that the map has finished.

They are thinking of deprecating the tool in favor of Gulp btw, https://github.com/leonidas/james.js/issues/21 .


There's something in the new healthd charger code that prevents display from completely turning off. It seems fine on amoled screens, but a lot of devices with lcd screens have this problem. We still might need this change once the problem is fixed.


@mkaluza, hi and sorry for asking. Could you upload tools which you've used to make those patches for each folder? After a lot of failures, I finally got working LK 3.1 https://github.com/ChronoMonochrome/kernel_common - only recovery mode, when rebooting to system this causing reboot for some reason. I think some crappy samsung changes caused it and I want to try merge ours old TC's kernel base onto LK3.1.


Wouldn't this always reprocess items without a thumbnail, even when the submission is older than 2 minutes?


Sorry, we **do** delete the sample file on each usage of the function ``writeToFile``


I tend to find this sort of code more readable with one method call per line, but YMMV.


The path and its usage aren't really aligned, I think I'd read this to pass in gaia-l10n/de instead of gaia-l10n.

Might be good to check for the existence of gaia-l10n/ab-CD at least to catch that common snafu.


I'll talk to Ops and see if we can make this HTTPS right off the bat.


Same thing, I'd use one method call per line.


hellow dude, Im just testing this comment feature!


Is it worth adding an inline comment explaining why a second search parameter of null?


**YIHHHAA**


1277852-CommandLineInterface (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (598 of 599 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.36%25-green.svg)


ajdbakds


dads


We should also create TS interfaces for these classes. Right now they are all piled up in `runtime.ts`, perhaps we could move them over to `bindings.ts`.


Temporary workaround for #6


comment


I don't know if OpenMRS uses @Nullable annotations, but for this sort of class they are really useful. If you don't use the annotation, then I'd have detailed comments for the set method saying whether null is allowed, and if it is what effect it has.


students write their stuff on computers and then they "write" them again in their practical files...


We agreed to scale the smallest side of the image down to 210px to ensure the thumbnail always fits in the square without losing too much quality


Yes. `<progress>` works, but is not necessarily good looking or adaptable.


Explicit javadoc for the difference between set(null) and set(empty list)


duplication of line 157?


The main reason why my module is bigger is [the comment](https://github.com/shinnn/is-cwebp-readable/blob/master/index.js#L1-L4), isn't it? It's OK to remove it for smaller file size.


This should be:

if (setup_.advisoryDelete)
    canDelete_ = state_db_.getCanDelete();
else
    canDelete_ = std::numeric_limits <LedgerIndex>::max();

OR

canDelete_ = setup_.advisoryDelete ? state_db_.getCanDelete() : std::numeric_limits <LedgerIndex>::max();


OK, so I guess after the Gulp change we can look into this again :)


In general looks pretty good, I've made a few comments inline


While I think that this works as-is (I think [[]] inhibits word splitting,which would cause problems here), quoting ```$exclude``` would work as well.


duplicate key


nice - this has turned out being a useful module for me!


Yeah thank you, but the Lua XML Parser is very bad, so that was the best way.
But thank you!


@ST-DDT
Yes, otherwise each plugin must track each possible drop event ;)


Perhaps "Render Operations" or "Draw Calls"?


The version parameter needs to be wrapped in double quotes instead of a single.  With single quotes ST3 throws a parsing error.


How often do you find yourself adjusting this? It makes more sense to me to have it as a setting in the tool rather than an environment variable.


J'ai corrigé le bug #1. Je ne sais pas trop comment GitHub fonctionne...
Peux-tu récupérer mon commit, mettre à jour ton dépôt et faire une Pull Request ? ou il faut procéder différemment ?


Maybe we also need a test like this (from http://docs.datomic.com/pull.html)

    (d/pull @conn {:friend [:foo]} 1) => {:friend []}


Why are we using "swaggerApiReader" mojo parameter instead of creating a new parameter, maybe "swaggerDocumentSource"?  I also recommend using reflection here instead of hard coding.  This way any additional ones down the road can be added without adding it to the if statement here, or custom DocumentSources can be added without a codechange here:
```java
                if( apiSource.getSwaggerDocumentSource() != null ) {
                    try {
                        Class<? extends AbstractDocumentSource> clazz =
                              (Class<? extends AbstractDocumentSource>) Class.forName(apiSource.getSwaggerDocumentSource())
                              .asSubclass(AbstractDocumentSource.class);
                        if( clazz != null ) {
                            Constructor<? extends AbstractDocumentSource> constructor =
                                clazz.getConstructor(ApiSource.class, Log.class);
                            documentSource = constructor.newInstance(apiSource, getLog());
                        }
                    } catch (ClassNotFoundException e) {
                        getLog().error("DocumentSource not found: " + apiSource.getSwaggerDocumentSource(), e);
                        throw e;
                    } catch (ClassCastException e) {
                        getLog().error(apiSource.getSwaggerDocumentSource() + " is not of type com.github.kongchen.swagger.docgen.AbstractDocumentSource", e);
                        throw e;
                    }
                }
                if( documentSource == null ) { // Default to MavenDocumentSource
                    documentSource = new MavenDocumentSource(apiSource, getLog());
                }
```


OK for both. There was a reason I had to specify the libraries myself for Lite builds back then, but I don't remember the details now. So as long as Lite builds compile we should be OK.


`conn` can be replaced with a once-created immutable DB value. Connection/transact machinery is irrelevant to these tests


It's cool you made it work :)

yes, sure I can upload them, but you must give me some time - those were
mostly scripts written "as I went"... "tools" is a big word for them... I'm
not even sure I all of them made sense ;P

what do you want to do with them? maybe I can help
On Jan 27, 2015 7:36 PM, "Shilin Victor" <notifications@github.com> wrote:

> @mkaluza <https://github.com/mkaluza>, hi and sorry for asking. Could you
> upload tools which you've used to make those patches for each folder? After
> a lot of failures, I finally got working LK 3.1
> https://github.com/ChronoMonochrome/kernel_common - only recovery mode,
> when rebooting to system this causing reboot for some reason. I think some
> crappy samsung changes caused it and I want to try merge ours old TC's
> kernel base onto LK3.1.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChronoMonochrome/kernel_common/commit/cb0b2af4f5cabd075cb9d2c027c1df1649e18eb6#commitcomment-9464921>
> .
>


looooool http://wingolog.org/archives/2014/10/17/ffs-ssl


Unnecessary mutable copy.


I think it would actually be easier (and probably more secure) to have our own public-key encryption in the app...


There's a bit of funny indenting going on here, line 151 is not indented the same.


@Memphiz : No idea (yet). Is this happening with master only or also 14-branch ? Haven't seen it on Linux so I suspect it's MacOSX only.


I'll have some time Thursday and Friday evenings and this weekend... I'll get on them asap.


Yes, it's probably better to use `avocado.loader.TestLoader` and then use `test_parameters['path']`. Thanks for the idea.


Modification des noms sur les réseaux sociaux suite au changement de nom de la Wild Code School ;)


Not sure if we will be able to do that soon enough. Feel free to do it yourself though. Drop a line on the mailing list if you are unsure about the exact semantics.


Me neither (I still haven't read the fabric documentation properly, it's still on my todolist). But I hoped something like `rsync` would be supported and luckily google provided the answer.


arnova i think it has to do with the libcurl bump in depends - at leat that is what @mkortstiege suggests in that forum thread


![Nope](http://i.imgur.com/TAt1M6N.gif)
fixed in 579fe6b256d77f066b04234b64e5e77658329f60


@joelhoward thanks. Fixed at https://github.com/dericofilho/sublime-phpfmt/commit/58c8c911c8df4734c837f5451bb754f5077e6d2e


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/1826


`e.printStackTree();` should change to `log.warn("", e);`.

All the printStackTree does is print it to stderr with println's.  It's almost the same as `System.err.println(ex.toString());`.  You want all of that to go through Logback so you have it in whatever it logs it to.  Whether that be the console, log file, or both.  Just think of the difference between stdout and stderr as the difference in levels.


This should have said fixes #3 not fixes #2.  I am still not sure how this numbering system works.


> what do you want to do with them? maybe I can help

I starting to think that in XXLQL samsung made some changes which causing semi-bootloop, when rebooting to system. Maybe ours TC base will work properly - just wanted to try...


True, the parsing here is done in a monolithic way; I am sure there are smarter ways of doing it, specifically by using the (now available) XSD for this file (located here: https://yp.box.com/canpipeXSD) and use it in a smart way.


I added comment instead, writing same condition in convoluted way seemed not adding the value at least to my eye.


Good question. It needs to be tested. Anyway in case it's note set user is asked interactively, which hangs avocado for infinity. So for now it's mandatory, we need to think of a better solution. Brief google search found only this way to specify password for fabric. (additionally we might use custom `rsync` command, but that's probably even worse idea).


No, in the sense that yours uses more dependencies. I inlined everything in the `file-type` module. Look at it.


I use a combination of JustDecompile and dotpeek.  I find the former is easier to browse / compare code quickly, while the other is better in decompiling the former can not.  (For example their steamsdk wrapper)


I can not accept this PR as such. The  __attribute__((no_thread_safety_analysis)) must be subject to clang conditional compilation. Could you update it?


Have you read the sticky thread about the 3.18 kernel on the Troubleshooting forum?


Read here: http://www.raspberrypi.org/forums/viewtopic.php?f=29&t=97216


Also, license comments in code is stupid. It's already in your license file and package.json.


Garrett,

Sorry for not answering sooner - yes, I did have issues.  I emailed you
about them - couldn't get the green "compare and request" button to show.
I had to go back and make sure all the other steps were done correctly.  It
was mainly just navigating around GitBash for the first time.

Thanks,

Edison Williams

On Mon, Jan 26, 2015 at 12:54 PM, Garrett Wills <notifications@github.com>
wrote:

> Looks good, have any issues along the way?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Edison81/e-williams-site/commit/7714d7de6bc70eedee346f4ae83428c4addcb1b7#commitcomment-9444733>
> .
>


Nice! Could we make the package name org.mesos.chronos? I'd rather reference mesos than github.


Why initialize canDelete_  to zero in the ctor and then initialize it to a max int value here on every iteration?

state_db_.getCanDelete() is being called in an infinite while loop. state_db_.getCanDelete() is expensive as it locks and performs am SQL DB lookup every time. A solution is to call SHAMapStoreImp::setCanDelete when the RPC command can_delete wants to change the ledger index. Might want to take into account if setup_.advisoryDelete is true.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


please


Well in case `remote` plugin is missing, `vm` plugin's initialization fails. User can look why and see that he's missing some `plugins.remote` module and solve it by providing it.

Duplication of the code is IMO very dangerous as people tend to forget updating all locations and it leads to hidden failures.


Probably a test with recursive components is also needed.


OK, I'll fix it.


This is really dumb too:

```js
/**
 * blah blah
*
* @param {asdlas} asdasd
* @api public
*/
```

I gotta stop liking it.


I believe the last line should be 1 to 61, not 60.


@marghoob we should be careful about using double-underscore more so that this does not happen in future.... python is so annoying


Fixed in 332139d23dc79cdc846e8e51f0eeee7ddbc9d568. Thanks!


Well I thought something like this might be useful and created this generic function. Anyway I guess there will be more complicated dependency so we might keep it local for now and when it's settled we can put it there. What do you think?


thanks


source?


done.


Please specify proper gem version


Nope, I checked the code and it was identical. So no issues should pop-up.


It might be beneficial to add 'LIMIT 1' to the SavedStateDB::getCanDelete() select query unless 'key' is unique or primary of course.


`permit!` ??


That was just as a starter for next set of changes.. where in you could come here with Open brace token as well


== lol ==

Loloel


It feels a little weird relying on an instance here. Maybe something like `URI::Generic.instance_methods.include?(:hostname)` would be better? That seems pretty bad in it's own right though...


This was done in spirit of learning the nitty gritty of stripe API..:smile:


:+1: to truncating.


fixes #31


Ditto.


No it is just to be able to get the PID of the server, if you do that you just get the PID of the make.


Yes, it works - great!
Please, go to 5.0 branch! :+1:


Because for this specific command we don't want people to configure this value.


This will be highly slow. First `store` then `purchase`. Also, No proper logging found.


LOL, @geemus... that's what I had originally but then you have to worry about instance_methods returning string/symbols on 1.8.7/1.9+


If you are expecting sensitive information from the user, please filter them from Rails log.


Changed this to name - which is the name of the binding (would like to keep this as name so I can change this to declaration and bind it using existing logic)
identiferName to referenceName


Just with my eyes :)


`if (URI::Generic.instance_methods & [:hostname, "hostname"]).empty?`

OR:
`URI::Generic.instance_method(:hostname)` also works but I’d have to rescue NameError

I thought the one I have is the least repulsive option but I'm not really biased... they all get the job done until we get off of unsupported 1.8.7/1.9.2 rubies.


Published to http://vui-docs-internal.s3-website-us-east-1.amazonaws.com/1_ae133fa41e594ce12f28648e1f06e1e2e3f26804


Set on an interface is going to be confusing.  Can you just keep an list. Is there a guarantee that these methods implement the getHashCode ?


What's the usecase?


```clj
(->> result
    (walk/postwalk #(if (keyword? %) (str %) %)))
    clj->js)
```


What are these going to be called, out of curiosity? It seems strange to have two UIs that look and feel the same and are interacting with the same underlying model, but have their columns labelled differently. I'm sure once you explain I'll be like, "huh yeah that does make sense" though.


"Tooltip not showing because of it being long." - it won't accept long messages?


Great eyes :).  Thanks for reviewing the code.


@iElectric Yes.


Just whitespace?


Question is how and what quests have different Q id then NpcStringId. :(


I've not looked at the rest of the change yet, but my gut feeling was to just mix this into ImportDeclaration and not create a separate kind for it


OH BOY. Fair enough, nice to see we are on the same page. This seems good-enough.


I've noticed the Consul UI isn't updating the consul-alerts/leader KV when new leaders take over. Consul API is returning this:

[{"CreateIndex":649020,"ID":"b9c41e7f-c887-f00a-05f7-23d4e6ce07cb","Name":"consul-alerts/leader","Node":"consul2...,"Checks":["serfHealth"],"LockDelay":15000000000}]

http://www.consul.io/docs/internals/sessions.html

"The final nuance is that sessions may provide a lock-delay. This is a time duration, between 0 and 60 second. When a session invalidation takes place, Consul prevents any of the previously held locks from being re-acquired for the lock-delay interval; this is a safe guard inspired by Google's Chubby."

Should 15000000000 be 15?  Any ideas?


I'm curious, given the create method, how is it possible that dlg is null?


@martinb3 What I've seen so far is that if we do HWRP we use => `libraries` as we don't need Chef to look for LWRP in `resources/`


My intent here is to show that my parser (which parses only stuff stored in HDFS) actually works, _eg_, that it returns empty structures with it parses empty files or that it contains the right fields otherwise.
But you are right, if I were to continue working on this I would extend the Parser to do its work independently of where the file is stored, and then have parallel tests for HDFS and _local_ storages.

Does that answer your question...?


NamespaceImport


I am not really a fan of "ES6Style" naming.. this is going to be all over the compiler. i think it should be just an import, and we support multiple variations. if we need to name them, the names need to be more expressive.


Hooks failure are ignored with warning to the logs. Do we want to fail here?


Please make change here "Usage: network_wordcount.py <zk> <topic>" to "Usage: kafka_wordcount.py <zk> <topic>"


chrome.usb.requestAccess has been deprecated since 40.0.2213.0 so please update the manifest before publishing a new version to the app store.


Can you put a one line comment next to each of these with the example syntax it refers to?


Ow haha, niet gezien nee...


This description needs some love I think :)


What's the difference between an ImportClause and ImportDeclaration?


This should be at the buttom of the file. **CodeEditor_Load** I want to be first.


Run runs the thread in the same context. I believe you want to call Start here.


forgot to comment out this line


<scope>test</scope>


@asiekierka I did it to remove the duplicate code between `saveToStore` and `loadFromStore`, is that a valid enough usecase?


About your last question, single-line `if` statements are generally sloppy. Linux C style officially says that if you do a single-line `if`, then you must be hiding something.

Keep things on separate lines for readability.


forgot to comment out this line too


We already have BindingPattern and BindingElement. Consider using those for imports (I would decide based on what ES6 does). If it does indeed need to be a different syntax node, rename this to ImportBindingPattern.


do you have a logcat from this semi bootloop?

I can't really imagine how you want to merge this... none of my scripts is
suitable for this really.
On Jan 27, 2015 7:49 PM, "Shilin Victor" <notifications@github.com> wrote:

> what do you want to do with them? maybe I can help
>
> I starting to think that in XXLQL samsung made some changes which causing
> semi-bootloop, when rebooting to system. Maybe ours TC base will work
> properly - just wanted to try...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChronoMonochrome/kernel_common/commit/cb0b2af4f5cabd075cb9d2c027c1df1649e18eb6#commitcomment-9465163>
> .
>


это бы в utils унесть


@arfl thanks for info, could you create a github issue with some info on that, so we can discuss and come up with a proper fix?


Actually I was wrong.
It wasn't working because I forgot to add a title.

It should work without one, though.


AFAIK, a Set does not depend on hashCode(), it only depends on equals(). If no equals is explicitly defined, the default implementation will be based on identity, which merely prevents someone from adding the same instance of a Hook twice in the set. This does not seem unreasonable to me.

Do you see a problem?


is it necessary? I thought item.scope should be a child scope of the $scope and would be $destroyed as the parent is


This change has broken the tutorial/left it in a confusing state.


yup


We need a better way to handle this. Can we just return the analog read as an integer and then do the string conversion somewhere else?


You are always teleported to the nearest graveyard (because the effect kills you), but that is only if your hearthstone is recharging.


For edges, they're black [...]
[...] if a node returns [...]
[...] if it returns a destroyed [...] (changing subject for consistence)


This seems wrong, not a new one you introduced, but if there is an error in build, we are silently swallowing those partitions and still pushing which will cause data loss. Isn't this bad ?


This should be before **checkInitialContent**.


I assume the motivation is to make the test more reliable in some way?


L'agenda de la présentation


Hmm... I am not sure.

I explicitly defined the interface's contract as NOT allowing a hook to fail a job. In other words, hooks are always best effort. That being said, initialization failures MIGHT be worth treating differently. Since the main use case for hooks is monitoring, not business logic, it seems a bit silly to fail the job just because a hook fails to initialize....

I am not sure...


For some reason I thought the `as <identifier>` was optional, but looking at the grammar, I guess you always have to name it something.


No problem!  Great plugin, keep up th excellent work.  By far the best formatting plugin for PHP that myself and @dowilcox have found.


Will try to provide this soon... from what I've already saw in log - seems that it's crash of usr/u8500_initramfs/init  - at first I'll try to revert some my changes from that(but what's strange - same script is working on my other kernels).

> I can't really imagine how you want to merge this... none of my scripts is
suitable for this really.

I thought to do it same way, as you provided patches from XXLQL base - did you this by some scripts or by maybe there's some manual method?


oooo, I didn't remove it...
It was just for testing purpose... I was going to remove it :P


should be gone


И примеры фильтров бы еще добавить


+1, if we really need to disambiguate something, I prefer calling it "ES" and not "ES6"


You are correct, I fixed that in the second commit, after this one.


@joelhoward I appreciate that.


Thanks @rotty3000, sorry for the mistake. I was warned by Collab team, that realized the build-service was broken. Just in case, I've seen that @brianchandotcom already fixed it


I don't have time either... can you enable issues on https://github.com/emcho/colibri so this at least is filed somewhere?


```
ShR2/ESP8266/ESP8266_SDK/seads_wifi_PROJECT$ sudo make
CC user/send_rcv_port.c
user/send_recv_port.c:13:25: fatal error: driver/uart.h: No such file or directory
    #include "driver/uart.h"
                                       ^
compilation terminated.
Makefile:169: recipe for target 'build/user/send_)recv_port.o' failed
make: *** [build/user/send_recv_port.o] Error 1
```


This is not merge on master, right?


Please place styling in styles.css /data/css/devmenu/styles.css
Also, we don't need '<' to the left of 'Refresh'


I'll rebase them for you.


shit, thanks. Yea it sat at the building zip for about 7 hours LOL and I had no idea what was going on until I woke up. I knew something wasn't right. Thanks again


Looks good


yeah. i find it wierd that there are two import declaration nodes, that look at lot alike.


"Keyword" is part of the name of the function you pass in. To clarify, if you see `import <keyword>`, when is that legal? Is the keyword following the import actually not a keyword?


This commit may not perform as you'd expect. This only covers one case. Here's something from my bootstrap that does all the things required.

```
buildbox-run "git clean -fdqx"
buildbox-run "git submodule foreach --recursive git clean -fdqx"
buildbox-run "git fetch -q"

# Only reset to the branch if we're not on a tag
if [ "$BUILDBOX_TAG" == "" ]
then
buildbox-run "git reset --hard origin/$BUILDBOX_BRANCH"
fi

buildbox-run "git checkout -qf \"$BUILDBOX_COMMIT\""
buildbox-run "git submodule foreach --recursive git reset --hard HEAD"
buildbox-run "git submodule foreach --recursive git clean -fdqx"

buildbox-run "git submodule update --init"
```

This covers all the bases.


I believe the failure is deferred until the end of the job, by inspecting the exceptions collection.

We might want to fail fast instead, if there is no way to recover... I believe this is something we can investigate and improve as part of a separate effort, since this change proposal maintains the old/current behavior.


Das ist eine gute Idee.
Abgemacht.


Yeah, fix confirmed!

@bbroerman30 thanks for the amazing work :)
@rdlowrey thanks for checking and merging :)


hey, where is implementation of product? :P


We also need to update the timestamp every time a user clicks 'Refresh' similar to how we do it here but using the current time:
https://github.com/mozilla/interest-dashboard/blob/master/data/charts/InterestDashboard.js#L766


Sounds like a good plan.


what is this?


I know it doesn't compile Bryan,  I have to copy over a few more files and translate it to the project. You can use your old project to test and work on :)

Sent on a Virgin Mobile Samsung Galaxy S® 5

-------- Original message --------
From: Bryan Smith <notifications@github.com>
Date:01/27/2015  11:17 AM  (GMT-08:00)
To: FrauBluher/ShR2 <ShR2@noreply.github.com>
Cc: Henry Crute <henrycrute@gmail.com>
Subject: Re: [ShR2] Added base code for the sead wifi firmware project
  (d8c21e3)

ShR2/ESP8266/ESP8266_SDK/seads_wifi_PROJECT$ sudo make
CC user/send_rcv_port.c
user/send_recv_port.c:13:25: fatal error: driver/uart.h: No such file or directory
    #include "driver/uart.h"
                                       ^
compilation terminated.
Makefile:169: recipe for target 'build/user/send_)recv_port.o' failed
make: *** [build/user/send_recv_port.o] Error 1
—
Reply to this email directly or view it on GitHub.


This is terrible. Silently eating the failed data builds.


layout for search page


This is an early version of the command. It's gonna be used in future commits.


@tacaswell had asked why only one value is shifted.  `delta.x` is a 26.6 fixed point value, and we want to return it to Python as such (I'm not sure that's the greatest idea, but it's what the API has done forever).  `hinting_factor` is just a regular old integer.  So divide one by the other, we first convert both to 26.6.


I concur. Will edit in a future commit.


Why take `info1` as a parameter? You could just have `def compareAlias = tp2.info ...`


This commit was just a basic shell of the PrintArgumentLengths.java program


this is wrong


Here, `pen.x` is a 16.16, `delta.x` is a 26.6, and `hinting_factor` is an integer (i.e. `32`).  We convert everything to `16.16` before doing the calculation.


I didn't tried myself, but if you are interested, you can play with iojs https://github.com/iojs/io.js

It's node fork, done by node developpers not satisfied by conservative Joyent policy. It has the most fresh v8 engine.


It can be simplified as `this[attr] == null`.


as pointed by @halter73 this should be internal (and actually it is). I will turn this into an assert.


Nnngh but that doesn't solve security for retrieval.


1: M111 unrecognized component name: collections


I think, again, the failure of the job is deferred until the end where exceptions.size() is inspected. It would have gotten a new item added to it in the same catch block you flagged above. The code is definitely convoluted and not very nice, but I don't think the failure will truly be silent...

Again, I would advise not cleaning this up as part of this change. It can be tackled later if need be.


Лучше бы в домашнем каталоге пользователя, под которым подключаемся, делать временную директорию (.bakapy-filters, например), а не в общественном. И что-то не углядел где удаляются эти временные файлы.


I believe there’s a step missing between parser and puller. It’s a step where we convert pull spec into somewhat canonical form, e.g.

```clj
{:wildcard? true
 :attrs {
   :name {}
   :parent {:limit 2, :subpattern {:attrs {:name {}, :db/id {}}}}
   :friend {:limit 10
            :recursion 5}
   :age {:default 3}}}
```
Not necessarily based on maps, may be records as well, just an example.

It will separate stages of process more clearly, and probably offload some complexity from main recur loop. I believe it should be part of parser’s responsibility, to output in the normalized format instead of specification format. Right now parser outputs close to how pattern is specified, but it’s just syntax, we shouldn’t tie our pull logic based on specification rules.

It would also help if we would have this format described explicitly in a comment somewhere.


The reason to make them configurable is to make possible compare two files created from same data set, but in different time. Currently they are not equal, because only this timestamp is different.


4: L102 copyright year is outdated, expected 2015 but got 2014
26:1: I100 Imports statements are in the wrong order. import shutil should be before import sys
27:1: I100 Imports statements are in the wrong order. import datetime should be before import shutil
30:1: I201 Missing newline before sections or imports.
31:1: I201 Missing newline before sections or imports.
32:1: I100 Imports statements are in the wrong order. from invenio.ext.script should be before from six
32:1: I201 Missing newline before sections or imports.
130:5: B901 blind except: statement
166:13: B901 blind except: statement
231:13: B901 blind except: statement
286: D290 White spaces around docstring should be trimmed.
291:5: B901 blind except: statement
299: D290 White spaces around docstring should be trimmed.
305:5: B901 blind except: statement


4: L102 copyright year is outdated, expected 2015 but got 2014
30:1: I100 Imports statements are in the wrong order. import os should be before import warnings
31:1: I201 Missing newline before sections or imports.
32:1: I100 Imports statements are in the wrong order. import sys should be before import pkg_resources
32:1: I201 Missing newline before sections or imports.


3: L102 copyright year is outdated, expected 2015 but got 2014


31:3: B901 blind except: statement
36:1: I101 Imported names are in the wrong order. Should be abort, current_app, g, render_template, request, send_from_directory, url_for
36:1: I100 Imports statements are in the wrong order. from flask should be before from werkzeug.wrappers
36:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
37:1: I201 Missing newline before sections or imports.
38:1: I100 Imports statements are in the wrong order. import sys should be before import sqlalchemy
38:1: I201 Missing newline before sections or imports.
41:1: I201 Missing newline before sections or imports.
44:1: F401 'attribute_mapped_collection' imported but unused
103:13: B901 blind except: statement
130:14: B901 blind except: statement
176:9: B901 blind except: statement
282:9: B901 blind except: statement
298: D102 Docstring missing
306: D102 Docstring missing
324: D102 Docstring missing


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I101 Imported names are in the wrong order. Should be current_app, g, has_app_context, request
24:1: I100 Imports statements are in the wrong order. from flask should be before import six
25:1: I201 Missing newline before sections or imports.