Hi @mdo ,

Please, could you care to explain the rationale behind this change?

If the idea was to darken the brand-primary color for links, shouldn't the darkening be applied when setting the `@link-color`?

It seems to me that darkening a hard-coded color (`#428bca`) to get another color (`#337ab7`) doesn't bring any benefit (over directly setting the variable to the dark color value).
Also, my understanding is that the "semantic" for the `@brand-primary` variable is to set it to, well, the brand's primary color, and not to a darkened variation of it.

Of course, if I'm customizing/overriding Bootstrap defaults, I can just remove the `darken` function and set the desired value and call it a day. Nothing stops me from doing so, and that would make this little, soft rant something to be discarded without further consideration :) (Maybe that's the answer/rationale I'm looking for? You tell me! ) :)

In other words, why doing:
```
@brand-primary: darken(#428bca, 6.5%); // #337ab7
...
@link-color: @brand-primary;
...
```
instead of doing:
```
@brand-primary: #428bca;
...
@link-color: darken(@brand-primary, 6.5%); // #337ab7 ;
...
```

Of course, if this darker version of the `@brand-primary` color should be used in other variables (like it's currently used in, for example, `@btn-primary-bg` or `@panel-primary-border`, just to mention two variables that are set to the value of `@brand-primary`), then applying the `darken()` on each variable definition could look like a violation of DRY principle.
But as your commit message reads: _"darken primary blue for accessibility contrast on link colors"_, then I'd say * that this color darkening should only affect the `@link-color` variable (instead of also applying to every other variable that is set to `@brand-primary`).

BTW, as an alternative explanation for this change, I can also understand if you say that it's mostly related to improve accessibility for Bootstrap (the project's theme/branding, not the framework), than as a general improvement on the Bootstrap framework.


I might have been thinking of End as an iterator. Should I change this to > ?


looking at the logs on travis, it's the same minErr warnings as the previous commits, so without seeing exactly what you're seeing I don't think this added any new ones


Hmm has $cid gone from optional to required then?


issue-4700-idd-file-directory (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1595 of 1595 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why add etypeid here (and other places?)


...but I guess the `new` isn't needed anyways, followup commit to remove that =)


issue-4700-idd-file-directory (nealkruis) - x86_64-MacOS-10.9-clang: OK (1589 of 1589 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


saw approval from Ms2ger
at https://github.com/xojoc/servo/commit/7b116e9d9ff3826af433599ce1591c79d83352e8


merging xojoc/servo/unused = 7b116e9d into auto


xojoc/servo/unused = 7b116e9d merged ok, testing candidate = 0d7c5fc0


issue-4700-idd-file-directory (nealkruis) - i386-Windows-7-VisualStudio-12: OK (1595 of 1595 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Should mention somewhere that this option is the default for bundling (maybe a "help my sourcemaps aren't right" note). Same goes for documenting it in cli once this builder lands in jspm.


Why don't we?


Hi Reinier :smiley:  Good to hear from you!
This makes sense. Could we use an array (like the on in ```/language/locales.php``` ) to populate a list to choose from instead of having to put them in by hand. Plus I think it would be good if this setting defaults to English if the locale that was chosen is invalid or none was chosen.


It's only the default in jspm I think? jspm docs need lots of love...


Ahh, runtime dispatch, that'd be the significant misunderstanding. It would definitely be preferable to compile-time dispatch though, to save most GNU-Linux users a bunch of useless dependencies. (I still bet the runtime dispatch could be cleaner though... not that I have the time to clean it up currently...)


And properties?


oops, I meant, it fixes #364


The property must be slugify_service


issue-4700-idd-file-directory (nealkruis) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This change breaks an Ubuntu 14.04 installation unless the user links /usr/include/jsoncpp/json ---> /usr/include/json


But doesn't access to `fieldMap` need to be synchronized? Or you do a gob-style type registration?


I had a type. It must read: Conditional RBMs package


You need additional back tick before `DT[, .(uN = uniqueN(.SD)), by=x]`


`btScalar` was wrong here, fixing to `float`


You're right, I'm too tired. Got confused by the link to jspm diff in your "review builder" mail :tongue:


Something is broken, the sessions are not appearing correctly...


Gah, I'm struggling to get my first code commit worked out. This is obviously an error.


We don't need the title - mind removing that?


All good points... thanks for taking the time out this evening.


s/active/peered/


just create overview page


:8ball: :santa:


I think for the load state we need to read the file in the same format as we are storing it .
We need to check the number of players in the beginning while loading the game state , to do it in the constructor of the BoardGame  that creates the player object and checks it with the one stored in the saved file, on success it triggers the load action in the BoardGame class.


Not bad!


:hamburger: :runner:


Well spotted. I added a mutex. It's barely slower and still saves all the allocations.

Gob style registration would be a nice other way to do it, maybe make a version with that later to see how that works out.


RNN = Recurrent Neural Networks

May I ask what happened, that suddenly all my unregistered package are included somewhere?

Cheers,
Keyan

> On 29 Jan 2015, at 15:27, SVAKSHA ॥ स्वक्ष ॥ <notifications@github.com> wrote:
>
> @kzahedi :: RNN.jl and RBM.jl
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/svaksha/Julia.jl/commit/953b4cbc143c39cb6629430e74d8354a3af30a3b


This repository contains unconventional oil and gas data from Pennsylvania from 1-1-2000 through 1-29-2015.  Data source:  Pennsylvania Department of Environmental Protection.  Mapping and generalized layers by the FracTracker Alliance.  There are 18,776 permit actions for 15,799 wells, 8,892 of which have been drilled.  There are 6,035 items on the compliance report, including 5,137 unique violation IDs for 1,809 different wells.


I don't know why, but with this build combo all process eats much more my system resources. I'm not able to fully build yet.


>It looks like you've done some heavy changes for the handling of commands. I'll try and wrap my head around what you've switched around.

I refactored commands.py to be object oriented. (Moved it to a class, so it should resolve the potential scoping issues.) It came about mostly because of adding commands on the fly and needing to save the configuration so it persists between restarts.

You can think of the command_class in bot.py as the container for functions related to bot commands. (Building lists of available commands, determining user level, adding/removing commands, saving/loading commands, etc.)

>I've been trying to figure out how to grab the +o from the bot's output and do something meaningful with it. I'm also having issues executing and reading the typical /NAMES IRC command over time intervals.

I've noticed a bunch of lag between when the IRC command is sent (like /whois /list /names) and when it is received. (The bot is FIFO, so it might be a timing related thing.) I can run it through the debugger tonight and see if I can see what's going on.


Why separate class? Actually, I don't see any "integration" functionality.


So the problem here is that the assertions are not helpful. Assertions should explain the goal of writing the test. Some tests may quite simply be: "Make sure it doesn't raise an exception" in which case, assertions aren't necessary. I think this is the best reason for not adding these automatic linters to the project. If people want to run them on their own, that's fine. I'm not quite convinced they've provided much value in these two files (both of which are tests).


hmm why are you changing canola back to vegetable?


re: scrubbing while peered... I thought we have to be is_clean() for scrubbing, which implies active?


Copy-paste is your foe ;) It's not about feed, actually.

btw, i'm not sure we should test ordering for tags. It's like index - ordering is about "view" and not mandatory. Tags just shouldn't show pages and static.


Thank you.


I hope it's a mistake, please move it to "Networking", the "n" pointer, not "ms"...


The build team reviewed for the next release.


Yes. This has been removed in later change. This was before Ander's work to have default target in compiler


That's fair


Let's hope it still works ;-)


Looks like you meant canola oil


the session.html file didn't get merge into master


Method name should be `exists` (there's an 's' missing).


Method name should be `notExists` (there's an 's' missing).


I think it's better to have this logic inside each module that needs it.
```js
var debug = process.env.NODE_DEBUG && /\brequest\b/.test(process.env.NODE_DEBUG)

function debug () {
  if (debug) {
    console.error('REQUEST %s', util.format.apply(util, arguments))
  }
}
```
There is really not that much related to Request, nor to the Request's instance. `Request.debug` is a static var, so `Request.prototype.debug` is not per instance either.

So if that was the only reason to pass the entire request instance here, I would suggest not to do that.


Did you mean `Tuples`? :)
What kind of tuples should that be? What does the `Long` mean actually?


I kind of like it better with the numbers auto computed


Sorry, typo indeed, fixed.


oops. good catch. I will submit a fix.


LGTM.
Review for updating the man page here: https://reviews.freebsd.org/D1721


Thanks :)


k


86605678-CustomMeterCrash (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1094 of 1098 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.64%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.01%25-green.svg)


+1 :)


Sweet: all rendering great for me now! Nice one @timothyf1.


seems like we would guard the pg->info les update, not syncing the history up with the info?  or is this part of the recent change that make history.les distinct from local-les?


Minor thing - it looks like the license got deleted here accidentally.


Some comparisons might not have a next, even when they are fully computed. But these comparisons are so shallow (they have depth 1), so it shouldn't be too bad to recompute them.


I just did that but it doesn't look good :D right now _make_selector has on if statement and _Selector.__init__(), too. Nesting them in _make_selector does look messier and _TerminatingSelector isn't a real Selector anyways...


Yeah, that looks smarter; I'll just calculate it from CosAoA


I think it's about time you got rid of Makefile IMO. The shelljs solution works everywhere equally so it doesn't make a lot of sense to keep both for more time.


LGTM


87220608_arrowsBackwards (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2071 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.57%25-yellow.svg)


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/630
failure: http://build.servo.org/builders/mac1/builds/846


I really don't think a lot about new lines tbh


I'm working on the demo for the force layout and I'm having second thoughts about this change. It turned out that I've misunderstood the ```D3Eff``` type alias. It restricts the effects to ```D3``` and you can't for example trace (which is very inconvenient during development and I can imagine scenarios where I actually want to do other stuff in the callback e.g. saving to localstorage). So I think this commit should be reverted(I can make a PR for it). Sorry for the hassle.


I feel like mustRecompute and elaborateErrors should have the same name.


sweet, thanks!


Closes #2


CANOLA


Кажется, ты зря добавил эти две строчки. В режиме моделирования без анимации, табличка не должна скроллиться вслед за выводом. Я уберу в ближайших коммитах.

Или у тебя были какие-то еще причины их добавить?


This relies on the assumption that you never put anything into the cache from a Ternary.Maybe. That should be correct, but just pointing it out.


This is not consistent with Query and DBQuery.  Consistent sig would be `in(String, Collection<?>)`.

(And the same goes for `notInList`).


You are dumb


Ahh, yeah, I remembered that I had done that on purpose at some point, but I couldn't remember why. :)

Yeah, go ahead and make another PR if you wouldn't mind.


This new code may have turned up a problem with wowsrp. I think the .pot files are written wrong.


#1 erledigt


Sweet commit +1


> Hilarious.

:disappointed: This has been a hard discussion to read, and the snark doesn't help.

> implies that `-1i64` as i8 panics

I don't think that that was the intention. My reading is that this was written with only unsigned integers in mind, and discussion of casts to/from signed integers was omitted by accident. (Note for instance that there's no explanation of what happens for casting between `isize` and `usize`, or from `i32` to `u64`, either.)

I do agree that it would make more sense to just say that the value should be representable in the new type. I still don't really understand the reasoning behind keeping wrapping semantics if the overflow checks are turned off. The compiler should be free to produce such values if it's convenient, but why make a promise for users to rely on if we're asserting that overflow is a program error?


fixes #1


Whoops, you are right.  I was thinking Go gave you an automatic dereference there, but it does not.  The error message (line 275 below) is wrong then, and does need to be *scanMeta.OldestIntentNanos too.


87220608_arrowsBackwards (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg)


looks great!


Oh got it, Succeeded can mean True or Maybe depending on what cache it goes into.


gradle home 文件里
<option name="gradleHome" value="D:\androidStudio\gradle\gradle-2.2.1" />
这行改成绝对路径的话其他人路径不一样会出问题吧？@@


I don't think we should repeat the logic, but if someone enables/disables debugging for `request` then that choice should carry through to all helper libraries that want to send debug info.

This change isn't urgent, I'm fine with closing this PR if we can't agree on something.  But, I'm going to quote you from https://github.com/request/request/pull/1360#issuecomment-70455757

> About debug that would do the job :+1:

:trollface: :speech_balloon:


That's cool refactoring! Nice job Dingwen :-)


Yes, please.


- The unregistration is made by PluginPackageHotDeployListener.doInvokeUndeploy(HotDeployEvent)
- For the deletion from the AS, I used the pattern from AppManagerPortlet.uninstallApp(ActionRequest, ActionResponse)


I'm not clear on when `maybeCache[key]` would be false? Do we ever put falses in there?


`JSON.stringify` is specified to throw if it cannot stringify the input, otherwise it will _only_ return a valid JSON value—which neither of these is. Since Typed Arrays don't correspond to the literal Array `[]` form, they will be stringified as an object would be.

```js
JSON.stringify(new Uint8Array(1)); // Produces the string: '{"0":0}'
JSON.stringify(new Uint8Array([0,1])); // Produces the string: '{"0":0,"1":1}'
```


Remove commented line


I have no idea, I was just trying to preserve the semantics.


The typical pattern here is either to return just next(err), so that result == undefined, or next(err, null). Returning next(err, {}) is still considered to have a result, even if empty, because it's an object.


Note that if we're caring about a microsecond here or there, the .values
should be cached as well. s.values isn't a simple attribute lookup and will
return you a new ndarray pointed at the same memory.

On Thu, Jan 29, 2015 at 4:42 PM, Eddie Hebert <notifications@github.com>
wrote:

> First pass at using dict to keep track of positions.
>
> Based on suggestion from @dalejung.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/quantopian/zipline/commit/d3667e0e40f2356b8fd1261ae349f4334eb5cbbc
>


Why not just put RelationComparisonResult in the maybeCache? Then you can just do copyMap regardless


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Good catch! Thanks! :-)


update_sqlite_coverage (mbadams5) - x86_64-MacOS-10.9-clang: OK (1567 of 1604 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.69%25-yellow.svg)


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


OK, fair enough.


Unfortunately I have no idea or recollection why I did that. I probably got a warning when casting (int) to (void*) and added the (long) without removing the (int).
This was the first piece of C code i've written in years... I should stick to python (:


CM kernel was crap, so I am using a kernel source I've been working on for a while now. I just pushed it the other day after testing it on all my builds, and it fixed about every problem. So just remember to fetch it, before doing any merge... which you did... so thanks. :+1:


should be vegetable instead of vegetables


OK.


Nice!!!


Zach, how did you end up creating folders in your repository?


I am aware. For this reason I created an Ubuntu-stable branch but I have not pointed it out on the README since I am trying to figure out some issues that are going with some people getting seg faults on Ubuntu.


See https://github.com/zurb/foundation-apps/issues/343#issuecomment-67598690

(I added our copy of `_settings.scss` when Foundation was still at 1.0.0)


Thanks, I feel better now for not understanding this :)


The commit is pretty much self explanatory. I was going ask for information on what led you to this, but, in the end, it's a self contained fix.


wlan: disagrees about version of symbol module_layout


Cool,

I am more than happy to not merge this kernel,.. just trying to keep things up-to-date.  Just let me know what works for you.


This righteous call may becometh reality if thou promiseth to no point thine symlinks at their ancestors.


this one is needed to register itself with a network IP


CLI tests pass on Windows.


> So the problem here is that the assertions are not helpful.

Certainly true.

> I'm not quite convinced they've provided much value in these two files (both of which are tests).

About testing code, we may not need to check with linters if it's not very useful. Or, there's a way to remove explanatory variables.

```diff
-            first = sock.recv(65535)
-            second = sock.recv(65535)
-            assert first and second
+            sock.recv(65535)
+            sock.recv(65535)
```


You may want this to go with #64 too.


issue-4700-idd-file-directory (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (599 of 599 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.49%25-green.svg)


class is set as Robor and not robot.
fixed it here and will also try to turn objects on canvas into OOP


Yeah, you should tell me how you find data around github so quick. Ok, I completely forgot about the fact that we modify `Request.debug` in `index.js` Actually that's part of the reason why I don't want to modify instances in places where you don't expect, and once you pass it around it's just a matter of time before someone start doing it.


This is out of question that this line does nothing.
The question is: Should it do something?
I can't find a setGlobalStrut() call. So removing this line should be save.


Instead just text comments use // TODO + text comment

Display the Tasks View: Window > Show View > Other > General > Tasks


87219700_ReplaceSimSettingLineEdits (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2177 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.41%25-yellow.svg)


The current plan is to redo the "type" field in the database configuration so that it simply looks for a section to determine the type.

In other words,
```
- type: database
  control: 1234
  backend:
    type: foo
    att1: val1
    att2: val2
```
will become
```
- type: database
  control: 1234
  foo:
    att1: val1
    att2: val2
```

Once that's done and merged into `develop`, we then merge `develop` down to `mongodb-backend`, make the appropriate changes on that side, and then :shipit:


## Productos de mi curso Programación de Fortran (2015-1)
Aquí subo todos los productos, programas fuente y resultados.
* notas.txt (comandos de bash)
* lo que sigue...
* y sigue...


изменить


[:lipstick: styleguide nit: ](https://github.com/reddit/styleguide/tree/master/javascript#conditional-expressions--equality) use `===`


Ist mir bewusst, habe ich ja auch im Code-Kommentar geschrieben. Aber solange es für die beiden Sprachen funktioniert, die wir unterstützen, habe ich keine Lust auf umständliche Änderungen. Das bringt an der Stelle keinen Mehrwert.


We can get away with one copy, at least for MooseObjects created by MooseObjectAction, if MooseObjectAction inserts its call to `getValidParams` directly into the warehouse and then `_moose_object_pars` is a reference to the warehouse values.

Then, Factory::create should take an InputParameters reference as an input parameter. It will then check if these parameters are already in the warehouse, if they are then don't add them again. If they are not, then the object must of been created outside of MooseObjectAction and the warehouse will need to copy them in.


Added check for null value and inverted if.


CLI tests pass on Linux.


Fair enough. I will submit a PR. Thanks


Did you get rid of these because they aren't used anywhere?


No link for Brandon?


Actually, that will NOT work! You need GameRegistry.addShapedRecipe(new ShapedOreRecipe(... (other stuff)

Note the ShapedOreRecipe thing.


Got it - It was even highlighted - LOL!  Thanks for your help.


Maybe we should remove this line, it would reduce the diffs significantly!


Nope. I asked him and he said he doesn't have anything he wants us to link to.


Good! Pretty obvious and self contained change!


Yup. It was all commented out.


It probably doesn't really have to be truthy, but it probably should be


Hmmm, that's true. Actually, it would be pretty useful if the footer and/or header included the rspec version so that it's on the page and not just in the URL.

Feel free to submit a PR improving this :).


I would just keep the old code (the one that had destinationCache)


I'm not sure why it needs to check anything it's an object instance, it shouldn't care who owns it as long as it has a reference.  Create it once in one place, put it in the warehouse and pass around references - done.


Is this for debug or to let the user know what is going on?


mbp is too!


Is this support of the backlight on the power button or the camera light?


Fair dinkum


Spacing Correction


@Omnione tested all those?


Line correction


Nice, I didn't know that was available.  Is it *always* 6 bytes long?


Many thanks for the Update. How can i update my existing NAS Installation?


The check is needed b/c Factory::create would now accept a reference to InputParameters. Depending how they were created (by the user in an action for example) the reference could be to a local parameters created by the user, so in this case we need to copy them into the warehouse for proper storage.


Looks good. One minor thing. Wouldn't it be better to simply pass 'context' to the XX_backend.lookup methods? That way an implementer of this method can simply pass it on as an opaque thing to parse_string and parse_answer. Here, the implementer must know what to put in the hash.


Used LINQ here


Simplification


Inverted ifs and using IEnumerable


That could be nice. I could only implement that if I role another argument into it, because of the check I mentioned on whether lookup accepts 4 arguments.


thanks KIloSwiss, this affects the new hotfix scripts.txt?


This is not simplified, this is weakened. Now tests for only one specific collLen and numPart value each. <shameless plug> You could use my package quickcheck, which runs tests on random values. That way when you're in a hurry you can test on few data points, before a major release you can go deeper and test it thoroughly </shameless plug>


I think I'd leave that as a separate problem to rework.


![lol cat](http://pbfb.ca/images/lolcats/lolcat_45_running.jpg)


HTML runner tests pass.


@peteflorence watch out this disables the commander


Thanks for catching this. Just wanted to note, though, that this isn't the latest version of this file.


nice catch! That will teach me to copy paste! Fixing right away


thx @GrahamCampbell you rock !


No everything else can stay as it is. Just pass the context instead of the recurse_guard. Leave the override parameter in there for backward compatibility. It's never used anyway.


Nuke this file from this commit


86956490-SPMMagic (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2174 of 2191 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.22%25-yellow.svg)


When using `openshift cli`, what happens?  Does it still have the same template?


Let's use ``channelForm`` instead of ``c``. :)


Yes, that slipped through by mistake. I think this is the third time I've fixed this in my own code base, but it always happens simultaneously with other changes in Signal, so I've never been able to get an isolated commit. (If there are any tools/commands to select only some lines of a diff for a commit, please let me know. It would make things a lot easier for me.)


Extra blank line.


Good point :)


> But uPy doesn't strictly conform to python3 with unicode disabled :)

But then this case should be conditional on MICROPY_PY_BUILTINS_STR_UNICODE?


We unfortunately need this - see how openshift is using the factory here: https://github.com/openshift/origin/blob/master/pkg/cmd/cli/cmd/factory.go

I need to add a test that demonstrates the usage of this.


was ist das denn


Great! Can I ask for a little favor? There's a 'can' missing in the previous sentece
`the custom Asciidoc property then` should be `the custom Asciidoc property can then`. It has been there for some time, but has nothing to do with your PR, but if you can add that, I'd appreciate it a lot :+1:

BTW, currently there's an issue with the AppVeyor maven installer, I'm looking into it and this won't block the merge.


ack


I'm just going to force push back again. You can just skip it from now on. I check CM every so often, so I'll merge if there are any useful commits.


you should release 0.10


Er..."XL Deploy"? ;-)


ende


Perhaps mention here that they should download the JAR from the releases link? And move what you describe here to a "Build From Source" section?


Is this correct?


@blandry that makes sense for saving bandwidth

how is fusion going?

On Thu, Jan 29, 2015 at 5:33 PM, Benoit Landry <notifications@github.com>
wrote:

> @peteflorence <https://github.com/peteflorence> watch out this disables
> the commander
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blandry/crazyflie-clients-python/commit/fc0fc095b7c7a48223296cdc39a8b3cda6701d5a#commitcomment-9508313>
> .
>


See comment above


Fixed in 1.0.6 and above. Thanks.


AWESOMESAUCE!!!! Thanks, @amitmohleji!


WOOT


Why no default provider?


We shouldn't ever need to do this when assigning the TX.  If we fail the asign and need to retry this won't hold up the TXG.  Can you provide a stack showing how this can be an issue?


I guess it's okay. The functionality is not obviously needed right now (from me that is) and can possibly be achieved through logging or a dedicated tool. the Printer can do without it I guess.


dunno what this does.


What arguments an event should have (if any) is an important discussion. I'd prefer a set up where either the Event inspects how many arguments a function takes (similar to traits), or where you say how many arguments you want supplied when subscribing (my preference, and similar to how pyqt does it). Having access to the sender of the ```data_changed``` event can hugely simplify functions that subscribe to that event from several signals, but that shouldn't prevent functions that take no such argument from subscribing to it (they can subscribe to the argument-free version instead). The traits-like approach will not be able to distinguish functions with an unrelated argument with a default value, and a function that would like the sender argument. The pyqt-like approach prevents wrapper functions/lambdas.


What do you think about using the repo code in the config file?  Something like:

     AppConfig[:yale_containers_barcode_length] = {
           :system_default => {:min => 5, :max => 10},
           'my great repo' => {:min => 8, :max => 12}
         }

Then get that in your model validation with:

     repo_key = Repository[self.class.active_repository].repo_code

Probably a minor thing, but it saves people figuring out the ID for their repo and might be easier to document :)


Looks good. Ready for merge.


Ok, I see that mp_obj_new_str_from_vstr() still explicitly terminates all str's and bytes with NUL, right?
That's needed for easy interfacing with native APIs, with most native APIs following C conventions of null-terminated strings.


Use the newest file, because this one here has some filters double, without the exception, resulkting in BE kicks.

It's the first time I work with GitHub and I messed it up :)


The reason for doing this was performance, not making strings or record type parameters const can cause a huge performance penalty.


And yes it's bad and old code (even older than me!). We've been through this. Feel free to improve if it bothers you that much :wink:


you have run out of disk space, not memory


Yeah something has to be done about these try/catch blocks without any code in the catch blocks, code would be faster if you just put the code outside the try/catch and remove it altogether


looks fine - unfortunately I have currently no test case


You should explain what repacking is.  Also, I don't think virtual memory has anything to do with this particular problem.


It is initialized to null anyways, so this is redundant


Maybe we want to improve on that and not only check the count, but that directories named like that (`pre`, `post` and `profile`) are present.


2 inverted ifs resulted in finding unreachable code


You should adjust your writing style to one sentence per line.  That makes it easier for people to look through the git history.


Untagged source map tests pass.


Another empty try/catch...


Here we go again


Do we really need a regex?
If yes, need a comment to explain why.


81605912-Multispeed-Heating-Defrost-Bug (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1595 of 1595 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@mckenzielong and @ThomasBurleson, just fixed it


Please, create issue with explanation of this usage. This changes are internal usage for you or are interesting for all?


I don't see the bSmart part in this


No need to create a new array when it does it automatically for you, also "this." is redundant, only decompiled code has this and is just bad for readability


Do we really need to ignore this plop.py file here ;)


Some stuff made readonly, used some LINQ to shorten stuff, a check for null on a variable (just to be safe), and some inverted ifs to reduce nesting


Hi @nite23 -- do you have any further thoughts? Now that 2.1 is in master, I was planning to put together a 1st-draft PR from this commit, with some of the changes we've discussed (Feel free to create the PR yourself!). Even while we're still deciding the interface, I'm hoping it will be enough to get started porting my WIP littleproxy implementation so I can your and others' eyes on it.


buttleofx/*.config
buttleofx/*.creator


client and firmware done. I kept it as simple as possible. Need to modify the state estimator.


Yes, that's how I originally added the functions.  Unfortunately it doesn't make a difference.  I think that the problem is caused by the amount of time the client takes to parse the form.

I think that the submit() only *triggers* the form submission and so isn't a true synchronous function. Consequently the button disabling is occurring before the submission has time to parse all the fields, which results in the error you outline above. That happens regardless of how you order those function calls.

Were it a different function call, I'd add the button disabling to a callback.  In this case that would be redundant though.

Hiding the button has almost the exact same effect on a user, so I didn't think this merited more investigation or dev work.


@bbroerman30 Awesome! I don't mind doing the windows testing myself if you'd prefer to PR sooner rather than later. I'll be sure to build it there before I merge anyway just to make sure there aren't any hiccups.


Made some methods static because no harm is done in doing so


81605912-Multispeed-Heating-Defrost-Bug (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Inverted ifs and made two strings readonly


r+


Define a class constant and use that instead of a string that people have to lookup.


Fantastic, so very sensible design!


This might break some ruby scripts using the plot widget. But I guess the risk is quite low.


Simplification


Explains itself


$filters is useless since d44b3773ed82f71bf13ed30f95711fac9a8d5b6a


saw approval from metajack
at https://github.com/glennw/servo/commit/dab954a25392a3358830b9c8a6f53d7667b0115d


merging glennw/servo/fix-x11-crash = dab954a2 into auto


glennw/servo/fix-x11-crash = dab954a2 merged ok, testing candidate = f58a1292


Hmm quite a lot actually! You can see all that red stuff is essentially reverting several entire commits.
This surely cannot be committed without some serious losses. Also I have no idea what you're doing in the `DebugLog` files when  you're supposed to be working on the `EventLog` stuff... This commit is very confusing...


Why did you do this change?


Sure, if you want to pull them from my repo...


Not all instances of Midas have an admin review every task, so we should remove "Someone from our team will review your description and may post it right away or recommend improvements."

We should add a link to the opportunity for their reference.  We could say something like:  "For your reference, here's a link the opportunity:  _link_   You will be notified when someone signs up."


IDE-specifics should really go in your global gitignore on your machine, but I'll leave it


ack


@sergiofontes descomenta estes links quando for adicionar o _coming soon_.


widze!! ;)


OK, I like the idea of failing faster. Can not see anything wrong here! :)


@sergey-devs let's leave the copyright at 2012


Makes sense, thanks!


It might only affect the Rear Left Motor.


REfreshing layout!!!

This is "Gadget Guys" UI!!!

TAB´s for Autovendor, etc. multiple menu item occurance

+ Vendor potions "Enabled"
 1. rank1
 2. rank
 3. rank

+ Vendor Echants&runes "Enabled"
 1. rank1
 2. rank
 3. rank

How priority & char.settings TAB affect script and are they loaded per char.?

If "Tasklist" contains only default, can "pop up" be disabled, it feels confusing.

LeadershipXP/AD, is now how it should be, no confusion "What tasklist is ACTIVE"!!!


I always have reservations with magic numbers. It might be possible to use an [AnimationSet](http://developer.android.com/reference/android/view/animation/AnimationSet.html) for this switch statement. Just a thought, have you looked into this already?

If it's not feasible we could at least replace 2, 3, 4, etc... with meaningful constants.


87220608_arrowsBackwards (evanweaver) - x86_64-MacOS-10.9-clang: OK (2166 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.9%25-yellow.svg)


It's hard to create instance of class with random name ;)


ah Ok thanks Kilo


:) el número de Gerardo según el FB


I don't understand the idea behind this class. Is it supposed to be an autoloader? Why not have an abstract Controller class with those other methods in it and then make the dispatcher check if it is an instance of AbstractController? Would make it a lot cleaner and make the flow easier to follow.


@creationix mac addresses are always 6 bytes


Making a weak var non-nillable is a really weird design pattern (i.e. this SHOULD be nil sometimes). I'm not really a fan of ! properties at all.


@profdave as you will see on the link of @tqchen I have started to write a vignette version of the demo related to variable importance. Please, if you can give your opinion I am more than open to critics. In one of the open issue I attached a html page already rendered of the vignette.


@sergey-devs can you remove the trailing whitespace on this line?


This seems really likely to collide with functions in web pages. Is our injectted code being namespaced?


If we were to do it earnestly, the following would be my criterion of whether it were a decent test: Let's say someone were to rewrite the function(s) being tested. Then the test's success or failure should be a fairly good indicator (albeit not always perfect) of whether the new implementation is functionally identical to the previous one.

The current test only considers a fraction of the implemented functionality. For example, it doesn't consider the case that two classifiers produce the same predictions, but different `decision_function`s (not that all combinations should be tested, but the idea that this is an `all` not an `any` test over predictive functions should be). It also doesn't test that the error message is helpful.

The test should also ensure that the person who rewrites it thinking your test is overdoing it has not under-thought cases we've considered, such as predictive models that store their models in attributes that cannot be tested for equality (easily), such as custom objects or lists of arrays.


I just cannot understand why our project is in PUBLIC repo on your account? Can you explain me please?


> (i.e. this SHOULD be nil sometimes)

When? That would mean the gesture recognizer is outliving the WKWebView it's attached to, which sounds like a bug to me.


great

On Thu, Jan 29, 2015 at 5:49 PM, Benoit Landry <notifications@github.com>
wrote:

> client and firmware done. I kept it as simple as possible. Need to modify
> the state estimator.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blandry/crazyflie-clients-python/commit/fc0fc095b7c7a48223296cdc39a8b3cda6701d5a#commitcomment-9508587>
> .
>


Y aquí el de Johannus: https://github.com/KakaoMedia/kakaomedia.github.io/blob/New_master/_data/contact.yml

:)


@sergey-devs can you remove the trailing whitespace on this line? or probably just remove this line altogether


There is a way to do async without changes to the LS API though (I use a variation of it in my project).

Upon a request for something that isn't available, you queue a request and return an empty file. When the results arrive, you re-issue the original request to LS and use these results.

It's not too hard to wrap the whole of LS /LSHost API that way, so all the bookkeeping is done by the wrapper, and neither LS nor the consumer have to worry about impedance mismatch. Similar approach as the marshalling 'shim' stuff.


Good point, I can fix this. Stefan prefixed the reader mode stuff with _firefox I think, and I can just do that for now, though I think i'd prefer a global moz namespace of some kind that everything can attach to.


For consistent style I'd place constant definitions above member definitions.


should link to this: https://esdiscuss.org/topic/classes-and-enumerability#content-61


I am currently using v0.12.0 and this code is NOT there? Was this not correctly tagged?


This comment is a bit misleading -- the old test would wait for the about:blank load above and the page load here *in addition* to idling for the `perTabPause` time -- the main purpose of these sleeps is to simulate real browsing wherein wall clock time is how the GC decides to run and so on.

Waiting for the onload events here would be ideal, but as long as we're not changing the timing too much it will probably be lost in the difference between different test harnesses memory usage either way.


Maybe some further stripping here, example from Joe Notsosmart User:

```
profiler_commands = 'foo:bar::baz: '
```

Current:

```
>>> [x for x in profiler_commands.split(':') if x != '']
['foo', 'bar', 'baz', ' ']
```

Proposed:

```
>>> [x.strip() for x in profiler_commands.split(':') if x.strip()]
['foo', 'bar', 'baz']
```


My method would work, however it wouldn't rely on the ore dictionary.

By the way, it would actually be "GameRegistry.addRecipe(new ShapedOreRecipe(...))", not whatever method you had.


Welcome.

Ah, I see. That probably explains (part of) your interest in the Dutch railroads.


Hi, I changed that line and having the same problem :(
http://pcaz.draweb.net/admin3913/


What does the 7 mean here?


For Spark architecture, defines Reader/Writer Semaphores as a spin lock if it is PREEMPT_RT_FULL


It worked before the refactor. It can be easily converted here to Uint8Array.


这个 commit message 是怎么回事..有什么梗？


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (rraustad) - x86_64-MacOS-10.9-clang: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


s/jsbridge/marionette/ in comment


r+


I find this use of `Try` to be a little confusing: why does the block throw an exception?  I think it would be cleaner to handle this without using exceptions for configuration handling, if possible.


@profdave just to understand the bug you experienced was during executing the demo or using the importance function in your own code?


@bradical Probably because it's loading the files sequentially, so `java/*` comes before `private/*`...


Gracias @paulomcnally , de hecho era información que antes estaba pública con consentimiento, asi que no hay mayor problema, pero concuerdo con vos que seria bueno ocultarla de los buscadores por los robot o posible SPAM.

Saludos


OK, It's obvious here that we only "run" a loggable if it's a `Daemon`. Question is: why then not doing the same on `end_job_hook()`?

If I got this right, it would make the empty `stop()` method on `LogFile` and `Command` unnecessary.


+            {Opcode.SMSG_BATTLEFIELD_MGR_QUEUE_INVITE, 0x098B},
             {Opcode.SMSG_BATTLEFIELD_MGR_QUEUE_INVITE, 0x0B32},
:cactus:


Maybe update the docstring here we do not deal with reboots whatsoever.


TESTS PASSED
 Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=deae59e52df042659f2276760c7819e6
 plone-5.0-python-2.7 [SUCCESS]


I think it makes sense to move this method to the new file as well, so we have all memcache access methods in one place.


@djowett you have a point on this; I forgot completely about that view but I think we should update it also.

@agnogueira @fredvd @polyester comments?


Naming nit: the "EnduranceTest" module is referring to running a "mozmill endurance test" which is the subtype of mozmill test our old test was. It might be worth just renaming this module MarionetteTest.py to avoid confusion.


Instead of special-casing the two, why not just have the "multiple options" case and use "merge" semantics.
Just send the options that are being changed (so a table with only one key in the single-option case), and use table.merged:
https://github.com/FAForever/fa/blob/develop/lua/system/utils.lua#L132

to apply the difference directly to gameInfo.PlayerOptions[data.Slot].

If you do this right, you can replace this entire block with something like:

```Lua
gameInfo.PlayerOptions[data.Slot] = table.merged(gameInfo.PlayerOptions[data.Slot], data.changedOptions)
```


(A similar trick can be used for game options in the other commit, of course)


clientRoom sounds strange. Maybe import room with an alias, like room_module, or use room_entry.


Come on, just do:

```Lua
SetPlayerOptions(slot, {key = val}, ignoreRefresh)
```


Docstrings for these?  I know we don't have them on other functions, but they sure are nice.


ditto clientRoom name.


Hmm... it appears this is an upstream bug in xray, too!


table.merged can eliminate this loop, too.


OK. Let me know if anything else needs to be changed


We clear the rooms in this list but we weren't immediately clearing it and it belongs to the class so anything else using it will get confused or have problems e.g. the map painter code - so fix that.


Good question. With this change I'm trying to only move out inline script into their own js files so I can take script-src unsafe-inline out of the CSP header. I don't want to change the script other than to move it into another js file. Those who know please let me know if you'd like to see this moved elsewhere.


maybe use "scale.range()" to avoid the numbers?


You can express this more concisely (and with better performance) as:

```Lua
local options = {
    MEAN = argv.playerMean,
    DEV = argv.playerDeviation,
    COUNTRY = argv.PrefLanguage,
    PL = playerRating,
    RC = argv.ratingColor,
    NG = argv.numGames
}
```


At first I wondered whether iterating though the list here was a cause for delay so created TRoomDB::removeRooms( QList<int> ) - that wasn't really the issue but another fact came to light that knowing all the rooms to be deleted meant we could skip some things that would otherwise be done to them as well as room NOT being deleted.


So you will have a generic *Template* class in global scope? Sounds like a bad idea.


81605912-Multispeed-Heating-Defrost-Bug (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (599 of 599 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.49%25-green.svg)


Ah, I see, I missed that at stupid-AM ;)


Agreed =). Trying not to modify any code with this change other than to move inline script into its own file. We can do a separate issue/change to remove UA checking if folks like.


acho que seria melhor trocar aplicativos por aplicações


Que fácil xD *:D


Well the automatic merge couldn't do it anymore. I guess to many changes - so i had to edit files where i was not working on (Debug Log). There shouldn't be any code missing now. I compared it with the development branch and merged the new code manually. Everything that is different now is the code and changes i made. If @SecUpwN can merge it with the development branch we can go on with development. It took the whole day to get this code where it is now. And 2 times all this mergenritis and push & pullovers messed up my local project. Well, it looks like Travis is happy right now - so i am happy too :)


Fail


I think you forgot to add the VRD3D.h/cpp and VROGL.h/cpp file in this commit.


It might be a good idea to replace these two cases with one. We always get a map from player names to benchmark results, and we just merge that with our existing benchmarks.
That way, you can iterate only the changed ones without having to do this evil copy here.


In that case, kill this comment.


Woops: lacking 'ic_shortcut_' in the picker_icons, and 'shortcuts_icon_' in the picker labels for the new elements.


I really like the core functionality and behavior! But, since it's my turn to be the bad guy, I mean, reviewer, here's what I'd do:

* `Daemon()`: put it in a separate (topmost) commit. It's like a new API that doesn't conflict with anything, but is self contained. `<joke>`That commit would be so simple, that even I would be able review it properly.`</joke>`
* `Logfile.stop()` and `Command.stop()`: as I commented before, I think we can get away with checking if something is a `Daemon()` and not add the `stop()` method on `Logfile` and `Command`.
* The creation of the `pre`/`post`/`profile` directories, as crazy as it sounds, could also be a separate commit, along with the functional test fixes that tackle just that.

Again, sorry for so much of so much, just trying to make good use of my eyeballs and sort of brain.


yeah that was a debugging thing, I need to take it out.


I realised that it would be simple to code for just the exits that are there rather than checking every possible one - it's a cost vs. benefit of 12 get{exitDirection}() calls verses a single call to get all of the actual ones as a set plus the effort to generate that set - in hindsight I may have traded coding simplicity for raw performance. :-1:


@kecinzer Just for future reference, more flags, for the most part, equals more resources used. Not all GCC flags do this, but most of the optimization ones do


Ну у нас этот апдейтер активируется только в конце и в начале, если я правильно понял. И пользователь все равно захочет знать, чем кончилось, даже если он включил быстрый режим. Хотя бы terminate condition ли там, или no events.


fixed?


Thanks!


all tests pass:
success: http://build.servo.org/builders/linux1/builds/631
success: http://build.servo.org/builders/linux2/builds/630
success: http://build.servo.org/builders/android/builds/666
success: http://build.servo.org/builders/mac1/builds/847
success: http://build.servo.org/builders/mac2/builds/847


@Majkl578 It has been fixed https://github.com/nette/latte/commit/cdf25b76f14dbe1238dd86d97549c56d17d16a00


Do you think it's better to put this functionality in it's own Check, rather than reusing `VIPParametersCheck`?

What if we want to set different error levels per action/filter? Different messages?


you're still missing a space here and in the next file


Troca: Isto é a triangularização de práticas ideias ao desenvolvimento de software

Por:
Isto é uma triangularização sobre as práticas ideais para desenvolvimento de software
ou
Isto é uma triangularização sobre as práticas ideais para desenvolvimento de aplicações


Yes setting to 0 may add extra instructions, but it is in the interpter not the recompiler so the speed lose should not matter that much.

if there is a case where some how it does not get used I would prefer it to be zeroed that way it behaves consitently


can we use `subject` here? This will be both descriptive enough and also commonly used (at least in rspec world).


I believe I've sent the standard IRC commands correctly, but you're saying you've at least seen feedback in the console showing /NAMES (and the resulting list) in the chat? I don't seem to get that in mine, even with debug on.

Also, not sure if you're interested, but I should have !songrequest sending to a Spotify playlist using subprocess call() by tomorrow (most of that code is excluded from the repo). I'll include everything once I have it functioning.


fast-forwarding master to auto = f58a1292


Good catch! Fixed.


You said you fixed a bug in the uncertainties of the area. Is this comment "SOMETHING IS WRONG WITH THESE UNCERTAINTIES" still true?


Alterar: Refatornado
Por: Refatorando


It would be nice if we could do some matching on the action/filter name, for example, to flag all uses of the `pre_option_*` filter.


@PatrykKaczmarek clang formatter does that and I don't think there is a rule to change that. That's the only flaw I've noticed while the rest is being extremely helpful.

I suggest going with `extern NSString const *CRVDefaultPath` or leaving it as it is. What do you think?


Let's go with \u0020 to match other cases of a space insert used in this file, if we need to have this item.


completed 25 koans


An iterator solution IS required here but the original may actually be faster as the pR->getOtherMap() ought to be an inline call directly returning a _private_ member whereas the pR->getSpecialExits() uses an iterator to generate the data to return - probably very similar to what the original code used - so 2 iterators vs 1 so this also may need to be revert on performance grounds. :-1:


This looks fine -- but, to be pedantic, Hg changesets are actually 40 characters, it's just that it's valid to abbreviate them as long as you pick a prefix long enough to contain a non-digit (so that it's not ambiguous with revision #s) and doesn't collide:
[4127ebc547fdf569b326ab0fdb0e7fca94086fc2](http://hg.mozilla.org/mozilla-central/rev/4127ebc547fdf569b326ab0fdb0e7fca94086fc2)
[4127ebc547fd](http://hg.mozilla.org/mozilla-central/rev/4127ebc547fd)
[4127e](http://hg.mozilla.org/mozilla-central/rev/4127e)

You could also kill two birds with one regex here if you wanted: `^[a-f0-9]{12}$`


saw approval from glennw
at https://github.com/zarazek/servo/commit/81f4bab26c675ca6d0c558f39df6c07724ecafa6


merging zarazek/servo/master = 81f4bab2 into auto


zarazek/servo/master = 81f4bab2 merged ok, testing candidate = 0d3e5f7a


at() gets a RValue and is faster  and read-only compared to the LValue that the '[]' operator provides.


Nightly passes. Weekly has again one occurrence of the neg tests about string interpolation failing, but I'll let it go.
Tagging.


Right now it's designed in such a way that every command (aside from help and exit) have to be in the form of two word structures... this probably isn't ideal and it would be better if commands formed a tree of sorts (with each level being one word in a command, so edit mailbox and edit folder would both come off the same 'edit' branch), but it's simple enough for now and I don't think we'll need anything more for some time.


comentando


Same comments about performance here as for  TArea::determineAreaExit(int) only multipled by ALL the area rooms. :-1:


issue-4700-idd-file-directory (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1095 of 1098 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.73%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.01%25-green.svg)


I cannot find any documentation about a "compiler-macro" declaration. What is the purpose of this exactly?


OK, thanks for the response. I was still thinking about trying to compile to the earliest compatible version for backward compatibility and was curious why you had to change this.


Tagged source map tests pass.
Publishing.


on my version of emacs (24.3.1):
cl-parsing-keywords --> cl--parsing-keywords
cl-check-test --> cl--check-test


In hindsight this is for a single room but applies to the whole area - should have made it "Room removal from TArea took" :neutral_face:

Also I'm sure we will have issues if we don't update the TArea max/min coordinate related data here if we rely on it...


This is the starting point to solve the issue #448


Moved the about dialog for issue #448


Holy cow you should consider writing a blog post with this stuff. :100:


Looking at the code in Event.pm, it looks like yes, it is no longer optional:

- the `subscriptions` method says it's optional, but further down it calls `raw_subscriptions` on each of the related classes
- the `raw_subscriptions` method says it's required, but if it's called from `subscriptions` without a cluster ID specified, it acts on all the members of  @LJ::CLUSTERS

So in practice there is no change in behavior, because `raw_subscriptions` is only ever called from inside `subscriptions` which will iterate over all clusters if none is specified.  We're not replacing the method, exactly, we're just changing which method we're overriding - but there are many similarities in the code which makes it more confusing!


Moved the whole quick connection box for issue #448


Seemed a more sensible place to put it - more visible at the top of the file.


In our case it _has_ to be 12 as that's how ftp.m.o stores them, I can probably change the wording though.


Well this sucks, looks like the second block is making a mess here. It aligns it once removed.
But actually this is the preferred way according to our style guide. You shouldn't align it when there are blocks in a method call.

I'm fine with that, you just need to indent the block content manually. We could also issue a bug report if that's possible.


Fixed.

----- Original Message -----
> Nuke this file from this commit
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabianofranz/origin/commit/a73a11c749c103b6e1b36e248ac9d8552742055a#commitcomment-9508340


Exactly.  It is.


81605912-Multispeed-Heating-Defrost-Bug (nmerket) - x86_64-MacOS-10.9-clang: OK (1589 of 1589 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This was the only place this variable got mentioned I think, so in removing it here, it was reasonable to delete it from the class.


Only one catch--there is no case where it somehow does not get used.  It always gets set and it always gets used when set.  That's what makes the code harder to read--by initializing `VECTOR Result = { 0 };` we leave the impression to readers that the RSP interpreter behavior has a possibility of never writing to `Result`, when the simple fact is that it must always, and it always will.

I have just made a discovery:  By changing this:
```c
void RSP_Vector_VMUDL (void) {
    VECTOR result;

    for (el = 0; el < 8; el ++ ) {
        ...
    }
    RSP_Vect[RSPOpC.sa] = result;
}
```
... into this ...
```c
void RSP_Vector_VMUDL (void) {
    VECTOR result;

    el = 0;
    do {
        ...
        ++el;
    } while (el < 8);
    RSP_Vect[RSPOpC.sa] = result;
}
```
The "potentially uninitialized variable" warnings are gone.  So an alternative solution you could have picked in theory (although I doubt you would find it favorable) was to use do..while loops and not for loops, which does have something of a compromise on readability--but it is easier parsed by the compiler to know that what you say is impossible:  the Result array WILL get initialized.

I will say this much in favor of your `Result = { 0 };` method however:  All of the RSP reverse-engineering notes I've seen from [krom]'s Git development show that reserved RSP opcodes write 0 to the destination vector if it is an invalid opcode.  So in a way your method makes more sense I guess, for if VMUDL was an invalid RSP opcode, your `Result = { 0 };` would indeed be the final result unconditionally.


Told u don't add this to your strings but u still add

<string name="temasek_version_default" translatable="false">Build V6.5</string>


Yes, we will keep this null termination for qstr, str and bytes objects.  Eg to open a file need to have an ASCIIZ filename, and no point in copying the whole string to a temp buffer just to add a null.


Hi ashraffarid,
Thank you for your interest in our project. Unfortunately our application is dedicated to Kinect for Xbox One sensor and supports Kinect SDK v1.8. In order to launch it on Kinect for Windows you would have to port some of the functionality, mostly in KinectService. If you have any further questions feel free to ask.
Kind regards


87220608_arrowsBackwards (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2177 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.41%25-yellow.svg)


Changing this to the following makes the update immediately visible. Anything speaking against it?
this.gui.updateGame();


I'm fine with this. It doesn't look very bad and actually this is what our style guide suggest to do in case of a long method calls (ie. do not put the closing bracket on a separate line).
See: https://github.com/raywenderlich/objective-c-style-guide#line-breaks


It would be ideal to just use the same HTML as what is used in the app, instead of a copy/paste here, as it is likely to go out of date over time. Although for this test, since it does not depend on this actual text, since the test is just checking what l10n ID is chosen for the container, I would just skip it.


Reverted to Original, For assingment04


Given that I chose to store the entrance data (including the direction) in the TRoom Class it seemed more sensible to do all the _new/extra_ stuff there - as can then keep the room entrance setter method mainly private.


I've just gone back to the BF and noticed the WAILA tooltip, great addition, although the heat seems to be for the first item in it, not the highest. You can have some stuff in it that's about to melt, but it can read Hot * if the first item in the stack has only just been dropped in. Make sense? I had the same problem with the tool tip I added to the UI!


Comment f1.txt


I saw that method before, but it wasnt working for me when i tried it. If
it works now then go ahead and use it.
El 30/01/2015 00:55, "philoliver" <notifications@github.com> escribió:

> Changing this to the following makes the update immediately visible.
> Anything speaking against it?
> this.gui.updateGame();
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dgl3/IMAS/commit/bc4179b85bb0106ea1ed6a9381d65c2bd1b17300#commitcomment-9509410>
> .
>


Hrm, good catch. `openshift cli` does, but anything else (start, etc) doesn't. I guess I need to move the templates to 'openshift' and make it used by everything, including the infra commands.

----- Original Message -----
> When using `openshift cli`, what happens?  Does it still have the same
> template?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fabianofranz/origin/commit/a73a11c749c103b6e1b36e248ac9d8552742055a#commitcomment-9508348


What is this Height you are trying to Get?  Is that elevation by X, Y or something?


Aha. Strange... I'll wait. We can check it tomorrow on the other machines too.


Another advantage of using the setExit() is that the use of determineAreaExitsOfRoom() has been limited to when it is _required_ based on where the old and new exit rooms are - if there are any.


I suspect you're renaming these variables in order to re-use code that we did in class. Not a great idea! Try to actually write your code from scratch, and use the variables that are given instead.


Thanks goes to @slaks for the `StrongBox<T>` tip!


Are we enforcing this elsewhere?  Amounts could also be serialised as json.


「於是你不停地收到"為什麼燈還是亮著"的 email。」這句後應照原文斷行處理，強調轉折。
另建議中文一律採用[教育部](http://www.edu.tw/files/site_content/M0001/hau/h6.htm)規定之[中式引號](http://zh.wikipedia.org/wiki/%E5%BC%95%E5%8F%B7)。


Sorry, by this I meant the `STAmount.max_native_value_on_network`


Try not to keep making `.js` files when you mean `.html`. It makes it harder to figure out which one I'm supposed to grade.


This Disable/Enable calls probably want to live: they're what makes the buttons for "save" and "delete" and so on disabled when there's no preset selected.
Not my most elegant work, however ;)


As is it didn't do much to improve benchmark time. Would need a lot more work to make this useful.


any particular reason you chose to go with decorators instead of yaml?


69208874-LBNL_CoilVsSpacePeak (Myoldmopar) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.53%25-red.svg)


Oops.  This was leftover from the fact that I originally tried putting the work in as suffixes of Vector instead of suffixes of Body.  The above line can be safely ignored and not merged if you like.


「你也知道只靠大家一起用 email 討論就能解決問題是不可能的」建議修正成「你也知道只靠大家一起用 email 討論是不可能解決問題的」。


`doctype`, not `document`!


建議刪除「趕快」二字。

1. 原文無此副詞
2. 快字重覆


Nice way to collapse this into a single loop. That's great for efficiency, although I'd recommend adding comments in a loop like this that does so much--it's not as self-explanatory as a nice single-purpose version.


update_sqlite_coverage (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (613 of 614 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.93%25-green.svg)


That commit was the first commit I made to binary.mk last year.  You can
check the rest of the history in that repo of you want it has graphite
flags and strict and all that.  Then you just happened to start modifying
binary.mk after I did?  Coincidence?  I think not.  I never said you didn't
have you own ideas.  Actually I see a huge mess of ideas in this commit.
As far as experience in android good for you.  I started with the G1 so I
suppose that was around 4 years ago as well.  As far the professionals I'm
not sure who your referring to.  Yourself?  Did I say I make anything
better than anyone else?  If you want to you can look at
https://github.com/SaberMod and see the work I've done over the "years"
that SaberMod has been around.  It's actually more than toolchain
development.  Get your facts first.

On Wed, Jan 28, 2015, 7:58 PM Dave Kessler <notifications@github.com> wrote:

> LOL oh my god dude... First of all, 0% of that code is similar to mine.
> Second, this is literally how binary.mk works. You know.. as per Google's
> use of it too? Jesus christ I cannot believe for one second you think
> you're that special. Or did they get that idea from you lol. As far as
> acting like I have a shitty attitude towards others i'm pretty sure you're
> the one treating someone with ~4 years of experience in Android like they
> can't have ideas without you or apparently even read source code released
> from google. You had an idea? Congratulations, I'm sure you're very proud
> of yourself, but there's a reason I (we actually) haven't looked at your
> source for cherry-picks in years.
>
> BTW, does kang mean putting your name on a toolchain and acting like a
> single amateur could put it together better than an entire team of
> legitimate professionals? If so i think i got the gist.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VanirAOSP/build/commit/40b58b227de5082cd65cd335137aceab126771d2#commitcomment-9491302>
> .
>


OKAY....


Easier shortcut, rather than using sort:

```js
var biggest = Math.max.apply(null, magnitude);
```

This uses the `apply` method of functions, which lets you pass arguments to them as an array instead of passing them in directly. In this case, `Math.max()` tells you which argument is biggest--by using apply, we feed it the whole array as arguments and it'll tell us the largest magnitude.


good point, I wish python had something like https://metacpan.org/pod/Hash::Merge .. ill keep thinking on this to see if I can come up with something


Found BROKEN by windows-vs2010.
interface.hpp(126): warning C4101: 'ex' : unreferenced local variable [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\../std_vector_tools.hpp(369): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\../std_vector_tools.hpp(499): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  ..\..\..\casadi\core\misc\integration_tools.cpp(334): warning C4101: 'e' : unreferenced local variable [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\misc/variable.hpp(71): warning C4099: 'casadi::Variable' : type name first seen using 'class' now seen using 'struct' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\misc\variable.hpp(71): warning C4099: 'casadi::Variable' : type name first seen using 'class' now seen using 'struct' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\matrix_impl.hpp(811): warning C4244: 'argument' : conversion from 'double' to 'const int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\misc\variable.hpp(71): warning C4099: 'casadi::Variable' : type name first seen using 'class' now seen using 'struct' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  ..\..\..\casadi\core\mx\constant_mx.cpp(119): warning C4244: 'initializing' : conversion from 'double' to 'int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\matrix_impl.hpp(811): warning C4244: 'argument' : conversion from 'double' to 'const int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\../std_vector_tools.hpp(735): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\../std_vector_tools.hpp(499): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\../std_vector_tools.hpp(488): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\binary_mx_impl.hpp(206): warning C4065: switch statement contains 'default' but no 'case' labels [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\binary_mx_impl.hpp(206): warning C4065: switch statement contains 'default' but no 'case' labels [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\binary_mx_impl.hpp(206): warning C4065: switch statement contains 'default' but no 'case' labels [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\matrix_impl.hpp(811): warning C4244: 'argument' : conversion from 'double' to 'const int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

"C:\Users\casadibot\windowsbot\windows-vs2010\source\build\swig\python\python.vcxproj" (default target) (1) ->

"C:\Users\casadibot\windowsbot\windows-vs2010\source\build\swig\python\_casadi.vcxproj" (default target) (3) ->

"C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj" (default target) (4) ->

(ClCompile target) ->

  ..\..\..\casadi\core\matrix\sparsity.cpp(41): error C2466: cannot allocate an array of constant size 0 [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  ..\..\..\casadi\core\matrix\sparsity.cpp(41): error C2466: cannot allocate an array of constant size 0 [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

    61 Warning(s)

    2 Error(s)

Time Elapsed 00:04:36.34

```


Well, that's one way to do it. A simpler way is probably to just count up from zero, as we did in class.


You actually already have the biggest quake index from the loop above. Why not use it instead?


Fixing issue #1 .


update_sqlite_coverage (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1570 of 1610 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.52%25-yellow.svg)


Changed the order, so that when the first trip goes through both Exists and !Exists If Statements are not both executed.


LGTM


So you're saying that he didn't know your commit or look at it? Then shut the fuck up. LOL


I don't know if DEFAULT_FS == 'gs' should be a discriminator. It seems that even if hdfs is default, if something references gs://, we could still hit this issue.


Please don't validate your HTML. W3 validation is bullshit--it's an unrealistic expectation that bears little relation to how browsers actually parse and instantiate HTML. This is just one more instance of rampant uselessness from the W3, to be honest.

More importantly, it looks super old-fashioned when you do this, and most industry people will give your pages the side-eye if they see it.


@mhegazy Sorry, one more question: should we also return undefined when the script doesn't exist for calls to getScriptIsOpen() and getScriptVersion()?


On 2015-01-28 9:50 PM, Chung-chieh Shan wrote:
>
> You're right of course... I hope you'll get to it before I do...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/3c3b307ff619eab0f1a67a5896f6b3ef01633181#commitcomment-9491262>.
>

Looking now.  But it is much, much worse than I thought.  There are
arbitrarily deeply nested if_ inside of which we want the 2nd operand of
a Pair.  This is not going to be easy to figure out.

One thing that comes to mind: why are you overloading 'pair' this
badly?  Would it not be possible to have a proper datatype for what a
Measure transforms to here?

Hmm, I wonder if it is the CPSing of if_ that might be part of the
problem [as opposed to part of the solution, in this case].  From the
looks of it, I would guess that it is related, as it "floats" an if_
from inside a dirac to outside of it.

Investigating some more...


I took out the comma after ```pipeline```.


I added an s on ```looks``` and an s on ```create```.


ok / working on my 3rd mint vm now :-)
told you about that conflict in first, 2nd got corrupt somehow not sure why , 3rd is the charm.

im catching up to where you are slowly

fyi in the depends of your toolchain build folder ....there is no makefile !!

I got one though & it is moving now slowly.

Finally Ahmed put us on here so you can merge your changes yourself.

This may take a while to build so I will be in touch :-)


Ok, thank you..


I took out the comma after ```included```.


「消息一來就是大家開始關心電燈沒有開關」建議改成較接近原文之「消息一來就是大家開始擔心電燈現在開不了也關不掉」。


I changed ```javastript``` to ```JavaScript```.


No wonder vanir is known for kanging.  Time to take this to legal.


I just added a d to ```release```.


If he didn't look at yours, and ours does the same thing, then nanananabooboo stick your head in doodoo.


Found BROKEN by full.


In MySQL the value other than 0 is evaluated to True by `IS TRUE` http://d.hatena.ne.jp/amari3/20120114/1326557682, though, in PostgreSQL https://www.postgresql.jp/document/8.0/html/datatype-boolean.html, in sqlite3 https://www.sqlite.org/datatype3.html.


「不過這是目前能想到的最好的辦法」建議改成「不過這是目前唯一的辦法」較接近原文。


hmm, have tested, working


So a string comparison is pretty simple, and it's even simpler because we don't need to know if the string IS ``"earthquake"`, we need to know if it isn't.

To give you a bit of an example, if we were trying to find items that are not `"explosion"` instead, we'd write this in our loop:

```js
if (types[i] != "explosion") {
  explosionCounter++;
}
```


Fucking chaos..


nit: 4 spaces


這個斷行斷得好！


On January 28, 2015 10:16:25 PM EST, Jacques Carette <notifications@github.com> wrote:
> Looking now.  But it is much, much worse than I thought.  There are
> arbitrarily deeply nested if_ inside of which we want the 2nd operand
> of
> a Pair.

Yes but that's why I like your plan of defining fst and snd to do nothing until Pair is seen.

> One thing that comes to mind: why are you overloading 'pair' this
> badly?  Would it not be possible to have a proper datatype for what a
> Measure transforms to here?

I think Yuriy is working on supporting that :)

> Hmm, I wonder if it is the CPSing of if_ that might be part of the
> problem [as opposed to part of the solution, in this case].  From the
> looks of it, I would guess that it is related, as it "floats" an if_
> from inside a dirac to outside of it.

But if_ can be outside dirac to start with - see the desired simplification result of t35.


「竟然看到牆上掛滿了一堆線」，建議刪除「一堆」，因為「滿」已經隱含「一堆」。


> vendor/eos/prebuilt/common/bootanimations/BOOTANIMATION-1080x1920.zip:system/media/bootanimation.zip

Is there a vendor/eos repo? Is there an EOS ROM? I thought this was just a kernel dealie, pardon my ignorance. :)


This isn't even on a built branch (or any for long) lol... It's in @AlmightyMegadeth00 's vanir derivative. https://github.com/VanirExodus/build
Bus
-------
Dave


@leyarotheconquerer Do you want to continue to use the MoveController? Would it be appropriate to give my BaseUnit class a MoveController property?


「所以想法是從這兒來的啊。」建議句號改成驚嘆號，增加口語感！


사이트는 뜨지만 문제는 2/4 까지 가고 strongloop 의 API 가 없다고 안되는 듯 싶네요?
```
==> default: ###### 2 Dependencies - nodejs modules ######
==> default: supervisor (7490) logging to 'supervisor.log'
==> default: INFO strong-agent API key not found, StrongOps dashboard reporting disabled.
==> default: Generate configuration with:
==> default:     npm install -g strongloop
==> default:     slc strongops
==> default: See http://docs.strongloop.com/strong-agent for more information.
==> default: supervisor 7490 detached process 7496, output logged to 'supervisor.log'
```


「你把線接好然後盡力把電線都貼上標籤」建議改成「你把線接好又盡力把它們標籤分類好」應較接近原文。


Naming is hard...


update_sqlite_coverage (mbadams5) - x86_64-MacOS-10.9-clang: OK (1567 of 1604 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.69%25-yellow.svg)


Ah, nothing like committing and then deleting .csproj files and other artifacts to inflate the activity numbers. :) Also: Best. Commit Message. Ever.


I think we need to start taking a different approach than the default tag. I am thinking we just save the FlightId in the Tag with a given Id - FLIGHT_ID. The action has a ViewTagDataSource that then triggers the action. Or FlightIdBundleGenerator if a Fragment or activity needs to be called.


이거는 스트롱루프가 회사거든요 걔네가 만든 서비스가 있어요. 그거 사용하려면 키를 넣고 하는건데 이 프로젝트와는 아무런 상관이 없고 개발하는데 아무런 지장이 없어요~ 사이트가 뜨면 된거네요! ㅋㅋㅋ


what about really adding a pair of `getLocalBounds()` and `getWorldBounds()`


@mozodev 그럼 3, 4단계는 진행이 안되도 되는 걸까요?


Good point. Based on the level of this article I'd say it wouldn't be a concern, but something good to keep in mind on topics that are more pointed at beginners. Think it'd be worth linking the "jQuery" part to http://jquery.com, or would that be overkill?


Hi Vardan,
Where can I find the plots, thanks.

Ahmed

>
> Hi Ahmed,
>
> so, I have compared H_cal_etot from hcana and hcal_et from Engine, see
> attached plots. They are in very good agrrement. Let me know if you have
> questions.
>
> Vardan.
>
>
> On Mon, 26 Jan 2015, Zafar Ahmed wrote:
>
>> Hi,
>> When I checked fEtot, to me it does not look like hcal_et. I did a
>> comparison with ENGINE. Then I came up with this new variable,
>> "fDEBlock".
>>
>> Ahmed
>>
>>
>>> I think the fEtot variable, as introduced and calculated by a previous
>>> pull request is equivalent to the hcal_et variable of Engine. I think
>>> it
>>> would be better to add a Get function for fEtot in THcShower, instead
>>> of
>>> modification in this pull request.
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/zahmed9/hcana/commit/07379e45b499779e615e1d1389f53e3ee325a2ff#commitcomment-9436847
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/zahmed9/hcana/commit/07379e45b499779e615e1d1389f53e3ee325a2ff#commitcomment-9438480
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zahmed9/hcana/commit/07379e45b499779e615e1d1389f53e3ee325a2ff#commitcomment-9473007


「老闆建議你再回去地下室確認那些電線」建議改成「確認一下電線」較接近中文語句。


엇 근데 PULL하고 하신거 맞아요 저 메시지는 예전껀데...

```
==> default: ###### 2 Dependencies - nodejs modules ######
```
4/4 이렇게 나와야할텐데 ????


the param is no longer message, it been change to user.

well, i guess it doesn't really matter since ch.py is dead.


@bryceadams reported in Transifex.
Someone need to do the hard job :p


Ha, inflating numbers wasn't the intent! Just having issues with getting Unity to play nice re: project directories.


You should submit this to the CyanogenMod gerrit. :) I submitted a fix for a minor missing " the other day, and felt like such a priss, but damnit these things matter.


엇... 진짜 -_-; (분명히 pull 했는데...)
제가 잠깐 수정했던 코드랑 겹쳐서 반영이 안되어 있었네요.
첨부터 다시 죄송.... =3=3=3=3


> I apologize if I was out of line here.

You're hilarious. That's a great catch! Underscore could definitely use a link here, too.


「沒錯」建議改成「當然啦」似較接近原文。


But yeah, @pbeeler... Unless you have a patent on optimizing flags in binary.mk, then find some sand, and pound it.

Unless you can identify some specific lines that you think you were the author of under a different copyright... Which you haven't.


Curious, why would this be separated from the sentence instead of inline?


r=mbrubeck


あ〜…たしかにそうですね。
htmlは疎いのですが、
の中身が何もない場合というのはどういった表示
になるか分かりますか？
ある場合とない場合で表示に差がないのであれば、continueを入れる際は必ず
で締める。
逆に表示に不具合が出てしまう場合は、はじめの
にもif文を入れる必要があるのかなと思いました。


In general we always squash the commits and tag the issue number to close it out.  I'll try to be more careful about leaving them logically separate in the future.


A simple `counter++` would have sufficed, of course. I asked how many quakes had a different type, not how many other types there were.


You're right. This is inconsistent. Both should be in quotes.


update_sqlite_coverage (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1570 of 1610 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.52%25-yellow.svg)


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/d7e13cffcf72e4f9d24a85a0e5e492e952da6875


merging pcwalton/servo/text-align-justify = d7e13cff into auto


pcwalton/servo/text-align-justify = d7e13cff merged ok, testing candidate = bca40afa


Although it seems like nitpicking, there is a good reason to use camel-case for variable names like this: later on, it's easier to guess whether it's `largestquake` or `largestQuake`.


We actually use this function for deciding whether to show a modal (see `modal.js`). Unfortunately our test driver doesn't use JS and that behaviour is untested, so it's not caught by the test suite.


「bug 只有說燈要關掉」建議改成「bug 只指說燈要關掉」


You might also want to add a small jsdoc comment explaining the function is, in fact, used. :)


Lines 5-7 are needed for the hosts' tea times to render properly, so we'll need to add those back in


moviHD bị lỗi rồi ,mong bạn sửa lại theo link phim chất lượng cao xem cho ổn định hơn link nhanh của google


Is this just left over from an earlier version?


MINIFY 필요


Thank you yea just one actually. Towards the end of the assignment where we were to finalize the commit, and part of what we were to enter involved the message along with the code syntax, when the left aligned arrows came up i could not figure out how to get out of that to move on to the next part. I ended up just putting in the code, then entering in the message part immediately after when the separate window popped up. Not a huge deal, I just couldn't get those arrows to go away so I could move on the the final part.

Garrett Wills <notifications@github.com> wrote:

Looks good, nice job. Any issues along the way?

-
Reply to this email directly or view it on GitHub<https://github.com/Jacob454/J-Breining-site/commit/fe5c40854e5faa3dfb1cc28498497beb604e7d25#commitcomment-9491223>.


You should probably do this outside the loop, otherwise your result may be off if the last item was an explosion (the loop will execute, but the values of `totalExplosion` and `numExpl` will be updated after `averExpl` is already set).


I used to agree that the readability outweighed the safety benefits until one night when I wasted hours trying to debug an instance of the issue, because I kept overlooking it while trying to track down the bug.

On a somewhat unrelated note, there's an interesting story about [an attempt to sabotage the security of Debian](https://freedom-to-tinker.com/blog/felten/the-linux-backdoor-attempt-of-2003/) using a bug of this nature.


「發了 email 問說 bug 有沒有包括窗簾」，原文包含 group email 一詞，似可翻成[發群組信](https://www.google.com.tw/search?lr=lang_zh-TW&safe=off&es_sm=119&qscrl=1&biw=1440&bih=782&tbs=lr%3Alang_1zh-TW&q=%22%E7%99%BC%E7%BE%A4%E7%B5%84%E4%BF%A1%22&oq=%22%E7%99%BC%E7%BE%A4%E7%B5%84%E4%BF%A1%22&gs_l=serp.3...2112.3074.0.3464.2.2.0.0.0.0.0.0..0.0.msedr...0...1c.1.61.serp..2.0.0.6INp2My_8vs)
本句可翻成「發了群組郵件問說...」


Will having the forceencrypt flag here affect the kernel? I believe the fstab in CM's device tree doesn't force encryption, so I was just curious.


Good question. The capitalization isn't 100% necessary and more of a creature of habit. When I first learned how to use "Future's," the variable was capitalized. I just had to look this one up. It looks like stylistically, when invoking a function _constructor_, a capital is used on the first letter. However, the first letter is generally lowercase on function expressions and statements. I did not know about this until two minutes ago :)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function

So, to answer your question: your edit makes sense. When I'm trying to offer context around _invoking_ a function (not just referring to it like above), I show it in code tags to suggest the invocation, e.g. `Future()`.


Why copy these arrays into the file? The variables should already be defined in the script above.


а, вот че ты имел в виду. понял


You should do this outside the loop, You're going to be a little off, because you're figuring your average on the last item before you actually add it to your subtotal.


:+1:

![](http://i.imgur.com/IW8simF.gif)


"View" to "page" is a nice catch.


SQLite3 has 'IF NOT EXIST' available to it, which will create the table if the table isn't present in the database. (That way you don't have deal with the exception.) [The SQLite3 docs on 'Create Table'](https://www.sqlite.org/lang_createtable.html)

**Section of interest**
> It is usually an error to attempt to create a new table in a database that already contains a table, index or view of the same name. However, if the "IF NOT EXISTS" clause is specified as part of the CREATE TABLE statement and a table or view of the same name already exists, the CREATE TABLE command simply has no effect (and no error message is returned). An error is still returned if the table cannot be created because of an existing index, even if the "IF NOT EXISTS" clause is specified.

This line would become
```python
CREATE TABLE IF NOT EXIST users(name TEXT PRIMARY KEY,
```


In this case, this is why your average is `NaN` -- you're using `lowest` before giving it a value, which makes it `undefined`, and `undefined` plus a number is `NaN`.


Cm and aid still use force encrypt currently


xe.js는 변경 안해도 되나요?


The pixmap is generating a bad value because it's expecting the file to be called the upper version of the lowercase; i.e. instead of trying to find `us.svg`, the correct item, it's trying to find `US.svg`, which doesn't exist.
![screenshot 2015-01-28 22 48 36](https://cloud.githubusercontent.com/assets/7460172/5952169/d106ea0c-a73f-11e4-9076-463fff0b3a03.png)


Remember, in this case, you're trying to use `item`, but you haven't updated it since the last loop--you should set it equal to `depth[i]` if you want to use it again.


I'm sure you've practiced that speech a lot.  We shall see what comes of it
:)

On Wed, Jan 28, 2015, 8:36 PM Eric McCann <notifications@github.com> wrote:

> But yeah, @pbeeler <https://github.com/pbeeler>... Unless you have a
> patent on optimizing flags in binary.mk, then find some sand, and pound
> it.
>
> Unless you can identify some specific lines that you think you were the
> author of under a different copyright... Which you haven't.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VanirAOSP/build/commit/40b58b227de5082cd65cd335137aceab126771d2#commitcomment-9491586>
> .
>


Definitely agree. I vaguely recall debating usage while I was writing this. I _prefer_ spelling out numbers. Is there a "correct" way to do it? And yes, this should definitely be a part of the guide :)


I know, it's all good, laughing with, not laughing at. It's been done before many, many, many times! And props to you guys using pull requests! Very nice. By the way, I couldn't resist: https://twitter.com/rtoal/status/560640521413328898


Merges done on 5.5 and 5.6 branches. Tested in Linux perfectly... Tomorrow I'll test in Windows. If all pass, I'll create the PRs.


Hi Kini, do you mean there is a way to autocomplete 'nohlsearch' by just typing couple characters in after 'SPC :'? Because if that's not the case, this change may make 'nohlsearch' command useless. I'm sure no one wants to type 10 characters to remove highlighting after each search operation.


asdfadsf


I think it probably makes sense to put this in the __init__.py file in main.views package or place it in its own file within the package. If this were a bigger project it works well to split the views out into their own file because many of them will have supporting methods that need to be organized. Here it doesn't matter.


@DadoCe #fbf5ca810284a71d2e8a05b7047c6dfbfc05e108


Hmm. Off-hand I'd say "no," but can't say 100%. Probably something that should be dictated as a single-use thing? What do you think?


I look forward to see what doesn't.


OK I'll do that


This commit was made because I merged the last commit incorrectly.


On 2015-01-28 10:25 PM, Chung-chieh Shan wrote:
> On January 28, 2015 10:16:25 PM  EST, Jacques Carette
 > <notifications@github.com> wrote:
 >> Looking now. But it is much, much worse than I thought. There are
 >> arbitrarily deeply nested if_ inside of which we want the 2nd
 >> operand of a Pair.
 >
 > Yes but that's why I like your plan of defining fst and snd to do
 > nothing until Pair is seen.

But I am not sure this would actually fix t35!

>
 >> One thing that comes to mind: why are you overloading 'pair' this
 >> badly? Would it not be possible to have a proper datatype for what
 >> a Measure transforms to here?
 >
 > I think Yuriy is working on supporting that :)

:) indeed!

>
 >> Hmm, I wonder if it is the CPSing of if_ that might be part of the
 >> problem [as opposed to part of the solution, in this case]. From
 >> the looks of it, I would guess that it is related, as it "floats"
 >> an if_ from inside a dirac to outside of it.
 >
 > But if_ can be outside dirac to start with - see the desired
 > simplification result of t35.

Yeah, that was indeed barking up the wrong tree.


Yes, and that should work for all evil ex commands. It didn't work in spacemacs for noh/nohl/nohlsearch though, until this commit fixed it. I speculated in the gitter chat as follows:

>maybe it's because ":nohlsearch" is built into evil and if you replace it, there's no problem, but if you define something new that happens to be a substring of an already existing ex command, then it breaks the subset stuff


Cool! A couple of questions:

1. Can you make sure this doesn't affect performance? To do that:

    ```sh
    $ git checkout master
    $ make
    $ cd benchmark
    $ ./run_bench --generate-baseline # Gather benchmark metrics on the current code.
    $ cd ..
    $ git checkout <your branch>
    $ make
    $ cd benchmark
    $ ./run_bench -wren # Compare them to the previous benchmarks.

2. Does this cause any conversion warnings? If you build the "wren-cpp" target, does it yell at you? C++ is a bit stricter about this.


r=mbrubeck


Nice. You wrote tests!!!!


coeerection


well, i'm laughing, you're laughing, we're all laughing.  and that's all
that matters.

besides, you know, a functional, cohesive project but eeeeeeeeh

On Wed, Jan 28, 2015 at 7:50 PM, Ray Toal <notifications@github.com> wrote:

> I know, it's all good, laughing with, not laughing at. It's been done
> before many, many, many times! And props to you guys using pull requests!
> Very nice. By the way, I couldn't resist:
> https://twitter.com/rtoal/status/560640521413328898
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AKingDebased/Nemesis/commit/ace9af88039f563c674d1438600dd6b5027e3657#commitcomment-9491690>
> .
>


I think these *should* stay `uint32_t`, that way code like `hash % map->capacity` stays fully within 32-bit unsigned behavior. What do you think?


Instead of repeating this check for item ID 4023 a few million times why aren't we checking it once and then doing the other checks after that - is anything preventing that? Is so let me know, I may be able to help keep you form needlessly giving yourself carpal tunnel.


Probably would be a good thing. Keeping it simple for now, need to get it working first :D


If lobbyComm is even remotely sane, it should be concatenating messages and sending them at regular intervals.

It's probably not remotely sane.


And now a completely different problem has arisen.  Introducing 'snd' does fix t35, which is good.

But now t27 is so HUGE that "toMaple" does not terminate in over a minute in ghci.  Other tests seem to suffer the same fate.  Haskell does seem to produce something, but Maple appears to choke on it.  It is all quite difficult to debug, because the main symptom is a hang.


We can probably lose this comment entirely. It says "CPUBenchmark" *right there*!


On January 28, 2015 10:57:56 PM EST, Jacques Carette <notifications@github.com> wrote:
> On 2015-01-28 10:25 PM, Chung-chieh Shan wrote:
>  > Yes but that's why I like your plan of defining fst and snd to do
>  > nothing until Pair is seen.
> But I am not sure this would actually fix t35!

I'm not sure either, but it's my guess based on looking at your code and experimenting with eval and op in Maple earlier.


Remind me to teach you the joys of tables and arrays for when you have a ton of elements to check like these jobs.


A fun quirk of GPG Lua seems to be that you can omit the "pairs" call here and it does the same thing. Probably just syntactic sugar, but can be nice for conciseness.


Interesting story, and the name, *Yoda comparison*, sounds fun as well.

Right, a line of code can waste our time too much. I might need to start to use *Yoda comparison*. :D


This is a duplicate of line 1780, causing build errors


Actually, if you require status.lua I think it already has jobs name to number and back conversion handled.


「沒事了，燈亮著。」建議改成「沒事了，燈亮了。」


Why do this, when you could've just updated CPU_Benchmarks at the start?

It seems that you can do away with the `benchmarks` local entirely. Just do something like

```Lua
if data.playerName then
    CPU_Benchmarks[data.playerName] = data.Result
else
    CPU_Benchmarks = data.Benchmarks
end

for name, result in CPU_Benchmarks do
   ...
end
```


good


indeed, wise thinking :package:


「那就是，」逗號應照原文使用冒號。


ok - this is getting ridiculous
we need to move the release script into a grunt task


Seems that this change in Expect produces insanely large output.  Whether it is the change itself, or a bad interaction with CPS, or something else, I don't know.  But what is currently there does not seem to be viable.  [Going offline now]