There's no reason to pull these things out into a separate class here. In fact, the i18n here is useless, because the user's language isn't available when the constants are computed.


Change to "gkZerk is written and maintained by..."

("Requests" is a different project)


you can require json files too :)

`var config = require('./config.json')`

http://nodejs.org/api/modules.html#modules_all_together


Please rename to: mui-is-checked, mui-is-disabled, mui-is-required


@stefanpenner Happy to test where I can for as long as I'm working with it.  I'm already looking at ie8 issues and researching/raising where I can't go any further.  The trouble is that most of the issues are fairly deep in dependencies, e.g. htmlbars, 6to5 etc., which is a time sink I can't justify and ie8 is not quick to debug with, especially as the vendor.js is 100k lines.  Recently, compatibility issues have comprised most of my development time which is concerning as I still have an app to develop, i18n to re-implement etc.


Be aware that `.bind` is slow and since this code gets called a lot I'd use a function wrapper instead.
To improve further pull the result of wrapping the function out of the `.some` call since otherwise the inner (wrapped) will be created new for each call to the outer function that `some` does under the hood.

You'd get optimal performance if you make `hasRequire` a prototype so I can set the `src` via the constructor and not have to pass anything via a closure. It could still take a `src` as an argument in order to allow using it either way (argument would override state).

A sample usage would look like this:

```js
var requrireChecker = new RequireChecker(src);
var hasMatchingRequires = keys.some(requireChecker.hasRequire);
```

Basically we make use of the state being stored in the instance and thus avoid creating a wrapped function.


we need to make sure to not to muddy up global scope.  These should be inside the link function


see above


The API reference needs to be updated: https://github.com/adsbypasser/adsbypasser/wiki#api-reference


should avoid wildcard imports


Because the slice doesn't depend on `b`, you can replace this line with either `np.repeat` or `np.tile`.


looks like extra indentation


Ah je crois que je vois un truc, l'abstraction sur l'environnement est
faite trop tôt je crois

2015-01-13 17:36 GMT+01:00 Thomas Bourgeat <thomas.07fr@gmail.com>:

> trop cool! oui j'ai vu ça c'st une bonne syntaxe. Je regarde là pour la
> suite d ela preuve
>
> On Tue, Jan 13, 2015 at 4:52 PM, Théo Zimmermann <notifications@github.com
> > wrote:
>
>> Tu regarderas ce commit. J'ai trouvé ce qui nous cassait la tête. On
>> avait besoin de la syntaxe apply ... with (n := ...) (m := ...) ...
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/stratSystemF/lambda/commit/60fdf71c40ae425c27463ef527cca50933f7d714#commitcomment-9262109>
>> .
>>
>
>


> The ```[ $TRANSPILER != '6to5' ] || ...``` seems a little funky and is confusing at times. Is there another way to do this?

I'm not sure. I use it because it works, but I'm no whiz at it.


Why have it here and not in the test?


whats the browser support for `.map`?


My concern was that after the first instantiation, pDestinationPath will be modifed (XXXXXXX replaced) so any subsequent call will fail or reuse the same destination path ?


we should use the angular wrapper for document: `$document`


Could someone take a look at the wiki and check i didn't wrote nonsense ?


Can you explain what this change is?  Secondly, Southwest recently changed (at least what is visible on their front end) the checkin process to include details about hazardous materials.  Are your scripts still working that after this change?  I ask because a scheduled check-in this morning did not happen.  The script attempted to, but from the nohup output, I see:
Traceback (most recent call last):
  File "sw_checkin_email.py", line 840, in <module>
    main()
  File "sw_checkin_email.py", line 837, in main
    sch.run()
  File "/usr/local/lib/python2.7/sched.py", line 117, in run
    action(*argument)
  File "sw_checkin_email.py", line 654, in TryCheckinFlight
    res = session.query(Reservation).filter_by(id=res_id).one()
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2215, in one
    raise orm_exc.NoResultFound("No row was found for one()")
sqlalchemy.orm.exc.NoResultFound: No row was found for one()


![brace yourselves](https://i.imgflip.com/gchf2.jpg)


In this case, I'd probably just make an index array:

   idx = np.repeat(np.arange(self.nBiz), self.nClouds)

Then do all the indexing in one go:

    dRevenue = self.p_bizes[idx]

You might need to reshape the result.


Actually my bad yes.

You have to have install bower AND django-bower (I forget to add it to the requirements).


Ok, thanks! lgtm


here and below simplify with:
   SparkModule.MODULE_EXECUTION_FRAMEWORK.equals(name) // no need to check for null


IsFinite instead of IsNan


"contining" -> "containing"


Please define color variables for these in custom-variables.less


"itle" -> "title"


So @Lukas-W, I'd like to you to take a look at this now...

I've switched it to a `functional` approach... Something more popular in PHP/JavaScript, but I think it works here...

```cpp
ProjectVersion pv = "1.0.3";

if (pv > "1.0.0") {
   // Release is greater
}

if (pv.compareType(Minor) > "1.0.0") {
   // Minor is greater
}
```


escape(label)


Not bad, but we should capitalize all words


Update do Commit anterior


David: I really don't like criticizing other people's code but I see a lot of "hacks" joining the code lately with regards to the REPL. I have not worked with the CLJS REPL code but hacking the **parse** function of the NS to make all sorts of side effects happen really bothers me because shadow-build needs to undo all of this. I know that is not of your concern but let me suggest another solution going forward.

It all begins here:
https://github.com/clojure/clojurescript/blob/8b5e8c6874c5a5110e718a70fcd499309d6f79e9/src/clj/cljs/repl.clj#L292

When a ```(require 'something)``` is entered in the repl you "fake" an ```ns``` form which then is analyzed, parsed an evaluated. Which introduced the hack to emit ```goog.require('something', true|false);```, a new function parameter that only ```goog.require``` (also hacked) of the node.js REPL knows how to handle.

Given that the only thing emitted of an ```ns``` form is ```goog.provide('something');``` and zero or more ```goog.require('something-else');``` we can totally skip over generating all of that.

Instead I would suggest to just ```cljs.analyzer/analyze``` the "fake" ```ns``` and **USE** the result instead of generating the "default" javascript. The analyze result contains all necessary information (```:require-macros```, ```:require```, ... ), there is absolutely no need to shuttle anything REPL related into the **parse** function  (ie. ```:merge``` or ```:require-all```). Also if the ```(require '[something] :reload-all)``` flag is set you can emit some Javascript back to the client (eg. like in ```'in-ns```), no need to hack into ```goog.require```.

This would make the **parse** function a whole lot easier to reason about and leave the REPL related stuff out of it. This is not a valid ns declaration if you ask me.

```clojure
(ns my-ns
  (:require [something] :reload-all))
```

Sorry for the rant, hope you consider it though.


this ones WIP


I added it for our manual testing. Once we no longer need this, we can also move the `examples` package into src/test/java.


This is complicated and tricky to vectorize, though it might be possible. I'd pull the various `Q_L` and `Q_S` computations into a helper function, because they're used all over the place.


There's a `np.isinf` function which you should use here.


Yeah, we could


Few things still left:
- [ ] updating when ng-model changes.
- [ ] simple example page.  Have a button that updates the data set


np.ones(self.nClouds, dtype=bool)


should avoid wildcard import, but can revert this class altogether (no actual change)


Although it doesn't make a difference and isNaN is probably clearer, we could


If that's true, why are we [recommending to use it](https://github.com/h5bp/html5please/blob/e4cf02fbdda88ea1fb5972e795f74d25582672f2/posts/classlist.md)? I will do some testing later, currently everything still works fine.


Yes since we don't have varlen offsets. But we should check overflow while
writing instead this is a quick hack
On 13 Jan 2015 17:34, "Sergey Lyubka" <notifications@github.com> wrote:

> By the way. Why checking for that? To guard against humongous functions?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cesanta/v7/commit/91920dba8d411465913af4356c44b5cee1927662#commitcomment-9262849>
> .
>


Eventually these will all be arrays of doubles, right? I'd initialize them to whatever data type they will eventually be holding.


zxombie wrote:
You should also have:

  .if !empty(DDB_ENABLED)
  CFLAGS+= -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
  .endif

in sys/conf/Makefile.arm64 to ensure future compilers include the frame pointer.
It may be the default, but we shouldn't rely on it.

semihalf-nowicki-tomasz:
Fixed.


great


Thanks!


Oh oh. Thanks. Fixed in 2b5f130be7efed6dd00fc9abc09f572c393c51b3


Oh wow, looks like the mError would just get nulled out no matter what.


Yep.(facepalm)


:shipit:


I think the interval should be 2000 as a default, to match both servers.yml and the Spark Streaming default itself


Will do!


Please use onTouchTap instead of onClick


Added appropriate comment.


Your albino butt looks like you aunts dogs cat


Yeah, sorry I forgot about this.


Seangchan,
I was actually thinking of removing the `if` statement, so that exception occurs inside PyCondor rather than BossAir, do you agree ?
An empty classad could be due to job exiting from the queue before we do the query or some corruption, failure in the query or communication between schedd and the job !
In a case of query failure, schedd should report why it failed, but from the error you sent, I don't see any... Need to understand why it is so ?
Question to you: what do we want to do in this case, move on to next job-ID or crash WMA ?


lots of indent oddities in this class, could probably revert those


Added another comment to revisit this place in the future


avoid the wildcard import


This is actually dealing from the bottom of the deck :o You really want `#shift` instead of `#pop`.


Я сам начинал с пробелом, но потом он начал раздражать. Вообще эклипс выделяет ключевые слова, поэтому изначальная фишка с пробелом, которая позволяла отличить ключевое слово от вызова функции, стала не сильно актуальна. Мне на самом деле все равно, лишь бы было одинаково. Да и вообще лишь бы все работало. Сейчас я просто увидел в `Database` одинокий `for` с пробелом, и решил, что не дело, после чего натравил на все файлы sed с регуляркой. В общем, вот файл с форматированием. В нем пробелы я трогать не стал, пусть будут пробелы. Остальное максимально похоже на то, что есть сейчас. Ну кроме переноса длинных строк, там форматтер бессилен, потому что это уже сродни искусству.

https://www.dropbox.com/s/v9s1lvoqt1vnq5o/RAO_syntax.xml?dl=0


>Using GitHub as a CDN
kek


Added barriers for self-modifying code.


还是在服务端截图了，用了pyvirtualdisaplay解决了xserver的问题；在服务器端截图以后可以做成异步的，在browser截图需要与post请求一起发到server，这样必须同步截图，截图是一个GET请求加上截图的处理，会很慢；当然，跨domain的访问还是没有试验成功


saw approval from alexcrichton
at https://github.com/retep998/rust/commit/ee1ca88213133a58f0a9d234f03babbebeb7c5d8


merging retep998/rust/master = ee1ca882 into auto


status: {"merge_sha": "cc685dfde765f7207226ce627ce8f597c2d84222"}


retep998/rust/master = ee1ca882 merged ok, testing candidate = cc685dfd


hey


@hajoeichler doesn't work (deployed it to ci and tried it)


ok


Order matters with the spread attribute. Move the spread attribute to the beginning so that your props don't get overwritten.
http://facebook.github.io/react/docs/jsx-spread.html#spread-attributes
```
<input
  {...other}
  ref="checkbox"
  type="checkbox"
  name={this.props.name}
  value={this.props.value}
  checked={this.state.checked} />
```


Please Provide the references for the calculations you used.


Hello,
In the use flag, it would be appropriate to add "vehicle-use" for the minecart.


I think we should get rid of this marker interface. See comments above about deciding based on a non-null execution framework. If that is not appropriate, then we could make it a method (shouldBind) that can be overridden by subclasses (with a default that returns true)


Let's just go with this.  It's the least disruptive by far.  Later I can take some time to understand why we need to include SDL_main.h

Replace
```
EXPORT
```
with
```
#ifndef WIN32
__attribute__((visibility("default")))
#endif
```


My gut is that this should work and perhaps better. My first question was whether draft and published would get mixed up, but I don't think so b/c I think location by this point must distinguish them. Then my next concern was what if the request had set a field on the block, but the answer is, then this will give the same block back with the transactionally consistent view of it whereas regenerating it from module data won't.


@NoumanSaleem Nice!. check the latest code :)


probably post 1.1, but we ideally would not have a direct awareness of SparkDriver or SparkModule here. Instead, we really need to refactor the ModuleFactory to have some type of contribution model (beans are added much like the plugins themselves)


Can you explain this please?


do not change all these API, instead provide a function to compute the mime-type based a path and call it from everywhere if dlna_profile is NULL. Also keep a single magic_t open as a global singleton, not one per user.

You can use an implementation such as:
```c
#ifdef HAVE_MAGIC
#include <magic.h>
static magic_t magic_handle;
static void magic_handle_clean(void) {
   magic_close(magic_handle);
}

static bool magic_handle_setup(void) {
    if (magic_handle)
      return true;

    magic_handle = magic_open(MAGIC_MIME_TYPE | MAGIC_PRESERVE_ATIME);
    if (!magic_handle) {
       fprintf(stderr, "ERROR: failed magic_open(): %s\n", strerror(errno));
       return false;
    }
   atexit(magic_handle_clean);
   return true;
}

#endif

bool lms_mime_type_get_from_path(const char *path, struct lms_string *mime) {
   if (!path || !mime) return false;
#ifdef HAVE_MAGIC
   const char *s;
   if (!magic_handle_setup()) return false;
   s = magic_file(magic_handle, path);
   if (!s) return false;
   mime->str = (char *)s;
   mime->len = strlen(s);
   return true;
#else
   return false;
#endif
}

/* version to use when we have the file opened already -- faster */
bool lms_mime_type_get_from_fd(int fd, struct lms_string *mime) {
   if (fd < 0 || !mime) return false;
#ifdef HAVE_MAGIC
   const char *s;
   if (!magic_handle_setup()) return false;
   s = magic_descriptor(magic_handle, fd);
   if (!s) return false;
   mime->str = (char *)s;
   mime->len = strlen(s);
   return true;
#else
   return false;
#endif
}
```


84694650_EnableCodeCoverage (lefticus) - x86_64-MacOS-10.9-clang: OK (1584 of 1584 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@robertjpayne That makes sense. It'd also make the pod lint fail eventually [see here]( https://github.com/CocoaPods/CocoaPods/issues/2963). But this is preventing Snap to work with cocoapods on private projects targeting iOS7. I think that should be fixed on the Podfile side tho. [More info here](https://github.com/CocoaPods/CocoaPods/issues/1241).

Anyway, thanks.


Hmm... maybe it's better to have a `payment_status` property in the Registrant class which always returns True/False/pending and keep getPayed as-is?

Also, `not foo == bar` is really ugly. Better use `foo != bar` instead.


f


This isn't a dot product. Were you compiling with `-DTUNED` to get the other version?


I'd call it `payment_status` now. "done" sounds like a boolean.


Why don't you keep "alt" instead of sama5d4?


Build error from this line


`sum` is undeclared, so this code must not be compiled.


`done` will work as long as you pass it both arguments, like you are to the `then` statement here, I think! Agreed on your second statement though.


FYI, nixpkgs already has a hard dependency on 1.8 (for mkOverridable on functions), so we can just use builtins.match


oh, a commit without a message is not good style. You can try to use git commit --amend in order to "amend" your empty commit message.


Found BROKEN by quick.
Here's the log file for step 'spell':
```
[ 11%] Spellchecking casadi_sdqpsolver_sdp
[ 11%] Built target spell_casadi_sdqpsolver_sdp
[ 11%] Spellchecking casadi_linearsolver_lapacklu
[ 11%] Built target spell_casadi_linearsolver_lapacklu
[ 11%] Spellchecking casadi_linearsolver_lapackqr
[ 11%] Built target spell_casadi_linearsolver_lapackqr
[ 11%] Spellchecking casadi
[ 11%] Built target spell_casadi
[ 11%] Spellchecking casadi_sundials_common
[ 11%] Built target spell_casadi_sundials_common
[ 11%] Spellchecking casadi_integrator_cvodes
[ 11%] Built target spell_casadi_integrator_cvodes
[ 11%] Spellchecking casadi_integrator_idas
[ 11%] Built target spell_casadi_integrator_idas
[ 11%] Spellchecking casadi_implicitfunction_kinsol
[ 11%] Built target spell_casadi_implicitfunction_kinsol
[ 11%] Spellchecking casadi_nlpsolver_ipopt
[ 11%] Built target spell_casadi_nlpsolver_ipopt
[ 11%] Spellchecking casadi_qpsolver_qpoases
[ 11%] Built target spell_casadi_qpsolver_qpoases
[ 11%] Spellchecking casadi_nlpsolver_knitro
[ 11%] Built target spell_casadi_nlpsolver_knitro
[ 11%] Spellchecking casadi_qpsolver_cplex
[ 11%] Built target spell_casadi_qpsolver_cplex
[ 11%] Spellchecking casadi_linearsolver_csparse
[ 11%] Built target spell_casadi_linearsolver_csparse
[ 11%] Spellchecking casadi_linearsolver_csparsecholesky
[ 11%] Built target spell_casadi_linearsolver_csparsecholesky
[ 11%] Spellchecking casadi_sdpsolver_dsdp
[ 11%] Built target spell_casadi_sdpsolver_dsdp
[ 11%] Spellchecking casadi_qpsolver_ooqp
[ 11%] Built target spell_casadi_qpsolver_ooqp
[ 11%] Spellchecking casadi_nlpsolver_worhp
[ 11%] Built target spell_casadi_nlpsolver_worhp
[ 11%] Spellchecking casadi_nlpsolver_snopt
[ 11%] Built target spell_casadi_nlpsolver_snopt
[ 22%] Spellchecking casadi_dplesolver_slicot
[ 22%] Built target spell_casadi_dplesolver_slicot
[ 22%] Spellchecking casadi_xmlfile_tinyxml
[ 22%] Built target spell_casadi_xmlfile_tinyxml
[ 33%] Spellchecking casadi_integrators
[ 33%] Built target spell_casadi_integrators
[ 33%] Spellchecking casadi_integrator_rk
[ 33%] Built target spell_casadi_integrator_rk
[ 44%] Spellchecking casadi_integrator_collocation
[ 44%] Built target spell_casadi_integrator_collocation
[ 44%] Spellchecking casadi_integrator_oldcollocation
[ 44%] Built target spell_casadi_integrator_oldcollocation
[ 44%] Spellchecking casadi_implicitfunction_newton
[ 44%] Built target spell_casadi_implicitfunction_newton
[ 44%] Spellchecking casadi_homotopynlpsolver_simple
[ 44%] Built target spell_casadi_homotopynlpsolver_simple
[ 55%] Spellchecking casadi_nlpsolver_sqpmethod
[ 55%] Built target spell_casadi_nlpsolver_sqpmethod
[ 55%] Spellchecking casadi_nlpsolver_scpgen
[ 55%] Built target spell_casadi_nlpsolver_scpgen
[ 55%] Spellchecking casadi_nlpsolver_stabilizedsqp
[ 55%] Built target spell_casadi_nlpsolver_stabilizedsqp
[ 55%] Spellchecking casadi_dplesolver_simple
[ 55%] Built target spell_casadi_dplesolver_simple
[ 55%] Spellchecking casadi_dplesolver_condensing
In file /home/casadibot/slaves/linuxbot/quick/source/casadi/solvers/condensing_indef_dple_internal.hpp

Adaptor

make[3]: *** [casadi/solvers/CMakeFiles/spell_casadi_dplesolver_condensing] Error 1
make[2]: *** [casadi/solvers/CMakeFiles/spell_casadi_dplesolver_condensing.dir/all] Error 2
make[1]: *** [casadi/CMakeFiles/spell.dir/rule] Error 2
make: *** [spell] Error 2

```


.ease-out and transform-origin is redundant here. You should be able to remove these extra styles.


I'll do that when I'm at my computer if it's not already there


haha your gay


you can leave the first part to fallback the dlna or remove it, but with the new code, to not make the ugly change to the API, you better fill the dlna before calling lms_db_audio_add(). Basically your plugins will have:

```c
if (info->dlna_mime.len == 0 && info->dlna_profile.len == 0) {
   dlna = lms_dlna_get_audio_profile(info);
   if (dlna) {
      info->dlna_mime = *dlna->mime;
      info->dlna_profile = *dlna->profile;
   }
}
if (info->dlna_mime.len == 0)
    lms_mime_type_get_from_path(finfo->path, &info->dlna_mime);
```


I think you're not using OpenMP here, but are you familiar with the [reduction clause](https://en.wikipedia.org/wiki/OpenMP#Reduction)?


Well it appears twice now...... why?


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (596 of 596 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.32%25-red.svg)


resolves #295


Use Ctrl+Shift+F for auto formatting your code


Should be canola, no?


As far as I know, there is no such target named "test". I think "units" is correct.


do we need to check this if we already go this far?


Where in wplib do you see this, I am having trouble finding it.


extra indentation here


I personally find this extremely unreadable. I was even tempted to use a `return` keyword.

But if this is upfront standard, I am more than willing to adapt. Shall I?


For sure on `bind`. Wasn't really thinking about how much it could get called for project with lots of exposed deps. Will update has-require to maintain the simple API but also expose a constructor API.


are you gay?


OK


nice :+1:


@jiffyclub Thanks a lot for your help!


Hey, This is Phebe
My website is [here.](https://github.com/pjvaldez)

 My open notebook is [Github.](https://github.com/pjvaldez/ResearchOpenNotebook)


@aloksteel try adding similar files and look around Git in general. Create a branch from this commit and indent this code.


you are right, i missed to remove the return....


This will need to be removed.


Do you think embedding this line in the `for` initilization part is good ? Something like:

```
for ($row = 0, $count = count($cat); $row < $count; $row++)
```

So that, it's clear that the `$count` is fully related to the for loop and used nowhere else.


How did u find this repo? I just put it online! haha


It would be easier if you added the zIndex property to the goog-slider-thumb-on-top class in CSS. Then you can use goog.dom.classlist.enable directly:

goog.dom.classlist.enable(this.valueThumb, THUMB_ON_TOP_CSS_CLASS_, moveTowardsEnd);
goog.dom.classlist.enable(this.extendThumb, THUMB_ON_TOP_CSS_CLASS_, !moveTowardsEnd);


Need to still change mount_all to match fstab name in common unless you have that locally already and just haven't pushed yet. :)

https://github.com/OpenDesireProject/android_device_htc_saga/blob/a8330c69f50c165eaff3542e5e1253d424fe9cdd/ramdisk/init.saga.rc#L20


need to drop handlebars back to ~0.5.11 @taylortom


The status values presented in the downloaded CSV need to match the status values in the Studio UI.


We should also countdown the latch here so we fail fast (rather than timing out below). That means we would also need to use an AtomicBoolean to store success/failure and then consult that after the countdown latch completes successfully (and throw an Exception there if the receiver error event occurred?)


zxombie:

How similar is this file to sys/arm/arm/busdma_machdep.c? Could we just use the same file on both?


Try to avoid calling models from helpers


maybe move this to an inner class at the bottom to avoid clutter here


Agreed.


![](http://41.media.tumblr.com/986a461575fa7de13325026b9137c946/tumblr_nefvrdL67v1qargfho1_500.jpg)

Violent :)


An alternative is to change lms_audio_info, lms_video_info and such to include lms_file_info instead of "int64_t id" and use path from there. It might be a better solution.


We have two kinds of sources now.
The original local/replicated (encapsulated now via OriginSource), and a channel identifier. I would separate the two concepts, and leave the original one with name 'Source', and use a new name for channel identifier.


If you can, please update this also -
`step` : Rating step when user can rate

`step` : Rating step when user can rate (0.1, 0.2, ... ,0.9)

Add comments to RateView.h that it can be 0.1 - 0.99
Put validation checks for this.

Did you make getters/setters for "step" ?

Please set them up parallel to other property setters.

Once again, your effort is appreciated, Thanks @maxep


odd indentation here


try to avoid performing such calculations in helpers


même ça je crois que ce n'est pas nécessaire


it is still .saga
if i remember right there was a problem with .msm7x30


Remove whitespace at the end of the line


Ah, I see... so we just delete that part after ``or``, right?


@thheller that is a perfectly valid ns form in Clojure. Criticism always welcome but there are no "hacks" here, this needs to work anyway. In Clojure that is a perfectly valid form that you often encounter in testing setups - `ns` in Clojure always macroexpands into `require` and `use` statements which all support `:reload` and `:reload-all`. This preserve the semantics without needing real `require` or `use`.

In the future please double check before ranting. Thanks.


We no longer use the register/unregister methods without source. We can remove them, and collapse EurekaRegistry with SourcedEurekaRegistry (I would keep the last name).


There is no need to explicitly declare the type when it can be infered by the compiler. So you can simply use `var i = 0`.


this looks like only whitespace and import changes (to wildcards which we don't want), so maybe revert this class to avoid extra noise


Ok, I had a problem in Android but it was an issue with downstream code.  So removing the SDL dependency seems to be the right path forward.  I'll submit a pull request to remove the SDL dependency. All you have to do is fix the MSVC2010 linkage to SDL.


No need fo the `to_s`, `print` does it for you.


Should we extract the qcolor here and below to a named constant?


try to keep controller thin


update for 6.3.1
gate.material.quartz=石英
item.Lens.name=鏡片
item.Filter.name=過濾片


This still has some issues. All of `yfov`, `xfov` and `aspect_ratio` are optional in COLLADA. From the spec:

```
The <perspective> element must contain one of:
• A single <xfov> element
• A single <yfov> element
• Both an <xfov> and a <yfov> element
• The <aspect_ratio> element and either <xfov> or <yfov>
```

You should first find out whether the first parameter of the `THREE.PerspectiveCamera` constructor is an X or Y field of view (if it is an Y field of view, you can't just pass the `xfov` value). Then, compute that parameter from the given data (considering all of the quoted cases from the spec). Finally, compute `aspect_ratio` if it is not explicitly given.


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@64FF00 개인적 체감으로 속도는 MySQL보단 YML이 더 빠르더군요
(MySQL은 인터넷DB 호환시에만 쓰려고 생각중이에요->이메일오스)


It would be nice if we could avoid this method in the interface since it's not always necessary (and by the way SparkWordCount above does not implement it!). Could we instead add some spark.* properties to the existing properties file or perhaps allow a new properties file to be added in a subdir or something?


As now each registry entry is an unbounded list, we need to collect some metrics about it. The simplest one would be max length or size thresholds (how many >1, >10, >100, etc). This way we will see that we do not have excessive growth of this data structure.


@dmatora That's a decent idea, but I've stopped actively using this little script in favor of things like [Sublime SFTP](http://wbond.net/sublime_packages/sftp), and thus can't justify the amount of work required to implement it (especialy considering all of the edge cases involving conflicting changes on both sides.) Pull requests are always welcome! :smile:


sigh


@Deathamns I realize I am assuming `channelData[0]` is of type `number` while really I have no idea if it's true. Trying to find reference material on Mozilla's site.


Wouldn't it make more sense to use the `resolve` function also for creating the initial value of the result signal?


The example needs a minor fix though:

```js
var hasMatchingRequires = keys.some(requireChecker.hasRequire, requireChecker);
```


we need to verify these parameterizations are the most logical here (e.g. is it always an InputDStream type?... and can we add support for parameterization of the expected type itself?)


usart3 is usually used as dbgu on sama5d4


Will this be accepted?


This change introduces a bug!

If the link helper is used without the parameter direct=true it triggers a PHP Notice: ``Notice: Key "model" does not exist in /home/mhaschke/Arbeit/Projekte/Commundo/StarPages/_dev/libraries/Zend/View/Abstract.php on line 262`` or ``Notice: Key "templateData" does not exist in /home/mhaschke/Arbeit/Projekte/Commundo/StarPages/_dev/libraries/Zend/View/Abstract.php on line 262``


Headers are supposed to be case insensitive, right?  A regex may do you better.

Also, it is worth noting that this applies to really any request that can submit POST data (this includes Put and Patch as well),


There's also {$ELSEIF ... } compiler directive (PtElseIfDirect) that might have a complex condition. Could you please take a look and adopt your new approach for this case too?


Thanks!


we should add javadoc here that explains which parts run on the driver side vs the executor tasks


Yeah, but I am not sure if the custom execution framework will always **not** use the MessageBusBinder plugin.


as with the MessageBusReceiver, this should not restrict to String payloads


Wouldn't it make more sense to use the resolve function also for creating the initial value of the result signal?


Не понимаю пока, как должен хелпер-класс решить проблему с лишними записями в трассировке. Для решения https://github.com/bogachev-pa/rdo-xtext/issues/14 придется переделать индексы, сделать разветвленные индексы-группировки листов. Типа графикам нужен каждый ресурс по отдельности, ну окей, пусть будет индекс для каждого ресурса. А вот трассировке нужно то-то и то-то вместе, ей будет свой индекс. Как тогда решить проблему проседания производительности, когда `Database` начнет копошиться в листах, выбирая, в какие индексы добавить ту или иную запись, я не знаю. Пока есть идеи, может быть на выходных придумаю что нибудь.


The block being passed to `sort!` is superfluous since the code in that block is the default behavior of `#sort!` and `#sort`. This could just be left as `@cards.sort!` and you would get the same result. I noticed this is a few other places as well, so you might want to clean those up too.


In case you wanted to avoid the lodash-template-stream dep, you could probably do something like this using `through2`:

```js
// ...
var through = require('through2');
var config = {
      handleFetch: params.handleFetch,
      importScripts: params.importScripts ? params.importScripts.map(JSON.stringify).join(',') : null,
      includeCachePolyfill: params.includeCachePolyfill,
      precacheConfig: JSON.stringify(precacheConfig)
    };

return through(function(chunk, enc, done) {
    if (chunk.isBuffer) {
      this.emit('error', new Error('Buffers not supported'));
    }
    this.push(_.template(chunk, config));
    done();
});

// ...
```

Probably easier to just use the module directly for now.


this one is no longer used (there is another SparkWordCount below)


1: M111 unrecognized component name: oauthclient


I also need to check-in my change to remove the filtering for the permissions.

:+1:


Ну якщо виконати команду sql:execute на persistence модулі то воно працює.

13 січня 2015 р. 18:26 apach55 <notifications@github.com> написав:

> я думаю, що тут можна вказати папку, яку слід сканувати на наявність sql
> скриптів.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Lv132Team/HostMe_2.0/commit/42fd659c96738322cb27a68f3617f3f1d793f47a#commitcomment-9262704>
> .
>


I use this option when working on text. This is actually one of the reason I only break the lines after a period. AFAICT  --color-words works better when you do not change the line breaks. The reason is that when you change the wording the lines does not break at different places and the diff algorithm can point out the lines that actually changed from those who didn't change. The option "--color-words" just help you identifying the words that actually changed *within* a given line.

For example suppose you have a very long paragraph and you don't break the lines after a period but only to let each line enter in the screen. Then if you add a few words of the beginning of the paragraph potentially *all* the lines of the long paragraph will change because line breaks happens at different places. Instead if you break the lines only after a period a diff will point out that only the first sentence did actually change.

I think that we can actually say that line breaks can add "noise" into the diffs and the rules of breaking the lines after a period minimizes ths noise.

But I don't want to annoy you with this details, this is not very important! :-) It was just a suggestion based on my experience with git and diff.


I don't know. This code is pretty strange :/
On Jan 13, 2015 6:02 PM, "Nir Bruderman" <notifications@github.com> wrote:

> Well it appears twice now...... why?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GearCM/android_hardware_samsung/commit/4ed18709031caa0f0536b7dc927b1208805a1de9#commitcomment-9263468>
> .
>


Has this been tested on Windows at all? I know that there are single     \    present in paths where people are using child folders for some dev projects and not sure the     \\    is sufficient a check to replace?


@bpolster I was thinking that the extension handler would have some mention about Locale directly in the contract. I guess that you can still get it if you need it by other means (e.g. threadlocal vs just using `desiredCurrency.getLocale()`)?


my sides


i've end with updating vagrant-unison plugin
https://github.com/dmatora/vagrant-unison


@maxrice This image deserves a tweet xD


@bpolster do you think we should go 1 step further and `@deprecated` this?


Так вони були там... але якимось "дивом" зникли..


@nicedexter thanks.. all merged into "graph" branch


Yes, it does! I had that in mind at some point but forgot again...


Nice refactoring.
Use arg.split("=", 1) so that cases (like password) can contain a second '=' that just gets included in the return value as normal text.


Thanks, I did not know about `Array.getLength`. The fact it is in `java.lang.reflect` is not a problem? Is it as efficient for us as calling `some_typed_array.length`?

So, `void assertExtractRangesArgs`? Or do you want to keep the return value here?


Will `api/link/ui.treetable_loadbranch.md` be correctly formatted?


> Has this been tested on Windows at all?

Yep, just tested on my windows machine.


Acho que alterar a config de associação para usar { async: true } pode resolver isso sendo compativel com o we.js 0.2.0
Link relacionado http://emberjs.com/api/data/classes/DS.html#method_belongsTo


The locale is still available via BroadleafRequestContext.    I didn't see a need for anything more here.


Ok cool :)


Do we really need to check the same condition twice? I mean:
```
if (Pos('DEFINED(', AParams) = 1) or (Pos('NOT DEFINED(', AParams) = 1) then
```
and
```
while (Pos('DEFINED(', LParams) = 1) or (Pos('NOT DEFINED(', LParams) = 1) do
```


Since you're calling `@cards.sort!`, which is changing the `@cards` array, you want to reflect that in the method name. So you should change `sort_cards` to `sort_cards!` to reflect the mutable nature of the method.

This is an idiomatic naming convention in ruby. Take the `#sort` method on an array. `#sort` sorts an array and always returns a new array, whereas `#sort!` changes the original array and returns it. It's handy to know if a method is going to be changing some underlying data, and the bang (!) does that in ruby.


Thank you! It is a good start!


@rich-iannone  want to check out this first iteration of `viz.js`.  I also included some examples in `inst/examples`.  For now went with a separate function for `graphvis`.  First thought is to have a `mermaid` and `grVis` function with `DiagrammeR(..., type= "mermaid" or "grVis")` as a wrapper with default `mermaid` so existing does not change.


please add regression testcase for your use case.


You've a typo in: "accellerator"


TeamCity Ylab :: zmactep/ylab [Build 150](http://192.168.30.225:8111/viewLog.html?buildId=518&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


ok


It seems to be working fine for me. Easiest place to check is [videojs.com](http://videojs.com), but I can't reproduce locally either. Did you update your CSS as well?


I know, working on it.

@Blaquedroid : you can also avoid to use my commits if every time an error
occurs you want help, you can always fix it by yourself before someone else
fixes it for you. I don't like this behaviour, you can't pretend something
in the open source world.
On Jan 13, 2015 5:59 PM, "Nir Bruderman" <notifications@github.com> wrote:

> Build error from this line
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GearCM/android_device_samsung_i9500/commit/f3f7850d7226a43a5af3370116569cfbc3d2d99e#commitcomment-9263394>
> .
>


Right. So, see my comment below on the NoOpMessageBusBinderModule interface itself.


TODO: check serializable j'ai fait ça vite


After discussing with boris yesterday, I'll rework that part to have a better way to identify the dbgu address


@vesper-mozilla, I assume Zulu (zu) should also have been added here?


>  I know that there are single \ (single backslash) present in paths where people are using child folders for some dev projects and not sure the \ (double backslash) is sufficient a check to replace?

Windows uses backslashes instead of normal slashes for paths, but can also handle normal slashes or paths with mixed slashes. But looks like XSLT can only handle forward slashes.


@tUrG0n haha on my github homepage events list


at91_alt_map_io is not needed anymore and is deleted by a following commit. The only thing that is different now is the additional mappings done for sama5d4 and I'll be removing them soon.


I dislike this line. Break it out, and check for nils and array size.


Is there not a more correct workaround for the resource warning?


Nice refactor and nice comments.


Yeah...I'm still not satisfied with how it's worded. But it's at least slightly better than it was, and I'm going to keep tweaking it until I'm satisfied.


It is a number. Set in line 1001, comes from frameModule.js. Its value can be any of [these](https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIContentPolicy#Constants).
Note that my comment in line 920 is incorrect, it should be // [type, tabId, .., because tabId and sourceTabId are strings.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/6469/testReport/) for this commit**


would be nice to make this a macro, so we can keep more as different iOS' come out.


We could add some interface methods to PdAudioUnit so you could derive your own and use it in libpd, no forking required.


Yes, they are for the OSD dialog for PVR (menus and such), I had neglected to check those when I did the normal PVR selection windows.


The first part of this tertiary operator, `RANK.index(rank) == RANK.index(other.rank)`, is the same code as what is in the `same_rank?` method, so you should be using that method in here so that functionality can be reused, and to reduce the chance of changing one but not the other.


you could do `cast(command, TriggerCommand).trigger = trigger` and save 3 lines


Do we need to update nhincdb_oracle.sql for sql script changes


Sim eu tinha visto isso, mas como você está montando os models do ember através de um módulo npm automatizado (sailsjs-emberjs-model-converter), eu achei que seria melhor essa solução pontual para o model do user, e depois que decidirmos o rumo do admin poderíamos fazer esse tipo de alteração no seu modulo para todos os models.

Mas posso adequar o módulo sailsjs-emberjs-model-converter, para todas as relações belongsTo e hasMany aplicar o { async: true } o que acha?!


The DialogPVRGuideOSD.xml, yes.   The PVR widget (commit this comment is in), no, they won't do anything, these widgets are only for the script.shorcuts menu system refactor.


yes it can be deleted


Yes but then you get an additional runtime check for type (which we've just done)


Inheritance rather than composition?


Ah, you only partially moved it. Sorry, didn't see that. I'll check as soon as I have time from hunting down bugs if even more unified naming works.

Btw, while I was browsing for fixes for current camera issue, I picked up this for saga: https://github.com/OpenDesireProject/android_device_htc_msm7x30-common/commit/d2df1f3dcd259c5c893318f8c760b6c01e8b86f6

Maybe it helps with the front cam crash? It just needs to be enabled from saga's makefiles.


Якщо вказати папку то я не знаю чи воно вибере правильний поряд виконання
цих скриптів. Вони мають бути в порядку оскільки один реферться до другого
З.І. Не зрозумів питання зразу..(

13 січня 2015 р. 19:18 Bohdan Myslyvchuk <myslyv4uk@gmail.com> написав:

> Ну якщо виконати команду sql:execute на persistence модулі то воно працює.
>
>
> 13 січня 2015 р. 18:26 apach55 <notifications@github.com> написав:
>
>> я думаю, що тут можна вказати папку, яку слід сканувати на наявність sql
>> скриптів.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/Lv132Team/HostMe_2.0/commit/42fd659c96738322cb27a68f3617f3f1d793f47a#commitcomment-9262704>
>> .
>>
>
>


I am not sure; it took me a 'while' to get that working, tried all kind of things, maybe in the end i don't need it anymore, i could try it and remove it if this is unnecessary


@vhuber actually it was not the right way to go

we have to transform the directory in a submodule and we want to keep the history


84694650_EnableCodeCoverage (lefticus) - i386-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


How do you know that _SC_NPROCESSORS_ONLN is defined in sys/sysctl.h?  I'm not exactly proficient in C/C++, so this is a beginner question.


Nice factoring & expanded test cases.


Ничего не понял. Что такое 'получаю -d в InputManager'?
"apply... можно реализовать" - где реализовать, зачем и куда использовать?
Причем тут присваивание в foreach?


output
![lenahist](https://cloud.githubusercontent.com/assets/7837699/5725379/66d617de-9b78-11e4-92b2-b55a47561c7a.png)


I think we should call [setMaxListeners](http://nodejs.org/docs/latest/api/events.html#events_emitter_setmaxlisteners_n) here to allow lots of components on one page to subscribe to the same value in a store.


84694650_EnableCodeCoverage (lefticus) - Win64-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


> Even with nested dev environment inside WAMP/XAMPP? i.e. http:\localhost\wamp\sym26/workspace/pages/page.xsl

Shouldn't really matter. Does it still not work for you?


HAHA I had to read that twice.. there was a lot of backslashin right there :)


TeamCity Ylab :: zmactep/ylab [Build 150](http://192.168.30.225:8111/viewLog.html?buildId=518&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 122 Build time: 00:10:33


Is there a reason for this second remove operation?


You are talking about the index: true which should be :index => 'true'. Or is there more?


You can do a ternary here... `{{ $hasIncidents ? "disabled" : null }}` - the same with everything else.


I merged your changes now.


@claudiosmweb #donedone
https://twitter.com/d_espi/status/555055432809447427


We could also add two-factor auth as a check on the user profile.


Whoops, meant to spell dialogue*


Any reason not to use `xmalloc`? Guarantees non-`NULL` return.


nice, can u remove the empty line xD


Whoops, right you are.


No, that's a typo that should be removed.


hello


Agree. We should bound and instrument all of these (so also inc the queues we use for invoker and for eviction). That can be a separate pull to add all these to the various different places.


Yeah, I thought about it but since the spark properties need to be module specific, I made it this way. The only other way is to introduce module options but that wouldn't be exhaustive and not manageable across different spark versions.


I like the idea. Will do that.


Que penses tu de la propriété forall e, wf_env -> forall tp (exists p, kind
e tp = Some p -> (forall k, p<=k -> kinding e tp k))

Je suis en cours, je vais essayer del a prouver ce soir, mais ça me semble
plus facile de pousser le forall plus loin.

2015-01-13 17:39 GMT+01:00 Thomas Bourgeat <thomas.07fr@gmail.com>:

> Ah je crois que je vois un truc, l'abstraction sur l'environnement est
> faite trop tôt je crois
>
> 2015-01-13 17:36 GMT+01:00 Thomas Bourgeat <thomas.07fr@gmail.com>:
>
>> trop cool! oui j'ai vu ça c'st une bonne syntaxe. Je regarde là pour la
>> suite d ela preuve
>>
>> On Tue, Jan 13, 2015 at 4:52 PM, Théo Zimmermann <
>> notifications@github.com> wrote:
>>
>>> Tu regarderas ce commit. J'ai trouvé ce qui nous cassait la tête. On
>>> avait besoin de la syntaxe apply ... with (n := ...) (m := ...) ...
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/stratSystemF/lambda/commit/60fdf71c40ae425c27463ef527cca50933f7d714#commitcomment-9262109>
>>> .
>>>
>>
>>
>


Dangling documentation?


Should this be in `event_init`?


On Tue, Jan 13, 2015 at 08:52:42AM -0800, Jeremy Carbaugh wrote:
> Merge pull request #1 from sunlightlabs/paultag/reflow/misc-fixes
>
> Misc refactoring. @paultag magic.

\o/

--
Paul Tagliamonte
Software Engineer


You could add a simple unit test for it (it would be good to have one regardless)?

In my experience, while Rails allows you to override these things, it eventually turns out to become a PITA triggering all sorts of bugs (these code paths are not always tested...).


Yup (that's the new hash syntax).


Is it good idea to update brief description about what the classes does in high level.


Hey Jay, i just noticed your photo isn't loading correctly. Would you mind taking a crack at fixing it up?


@jbrooksuk totally. I am still working out the last of the kinks, so its not quite ready (but almost there!). I was planning on making a PR from byxorna/Cachet to you guys once its all savvy. Hopefully ill get you a PR in the next day or 2.


@Alberto96 I do apologize I'm still learning to code with java I'm still relatively new to it but I'm getting there


Generally, `free` functions should be safe on `NULL` pointers.


Ça me parait bien comme propriété. Sans doute mieux de mettre le k plus loin effectivement. Si ça peut aider la preuve c'est tant mieux.


stray console.log


I think you are right. I don't have `aplay` on my machine right now to make sure it produces the correct sounds, however it does produce an output and if it works for you, then that should be it. I'll change the README


Awesome! I'm looking forward to this :)


To clarify: This fixes https://github.com/ansible/ansible-modules-core/issues/546


I think you are right. I don't have aplay on my machine right now to make sure it produces the correct sounds, however it does produce an output and if it works for you, then that should be it. I'll change the README.


I disagree actually. The Source that contains both origin and id is really the only "data" source that should be used for write operations. Whether these are from the channel or anywhere else it doesn't matter. The three OriginSource in this matcher class should only be used for read operations so that we can match either specific Sources, or sets of sources with the same origin. Having said that, the implementation here is somewhat confusing. Let me refactor it to so there can be no misuse.


Would it be better to use EPOCH here instead?


blz, se está funcionando com esse path podemos deixar para atualizar no proximo mês com calma
vamos indo ...


r+ rollup


Oh shoot, looks like the image isn't loading from google. Would you like to fix it? It's a nice picture! :]


I’ll add some java docs as part of the front end clean up.  This is just for the original functional part.

From: sailajaa [mailto:notifications@github.com]
Sent: Tuesday, January 13, 2015 12:43 PM
To: jsmith2/CONNECT
Cc: Smith, Jason A (CGI Federal)
Subject: Re: [CONNECT] PoC for Admin GUI Connection Manager (58e4b21)

Is it good idea to update brief description about what the classes does in high level.

—
Reply to this email directly or view it on GitHub<https://github.com/jsmith2/CONNECT/commit/58e4b21c175f93cc88beacc3bb90b1826520bc24#commitcomment-9264288>.


Since `_check_pipestatus` wants to throw exceptions I'm not sure this is a safe use of `finally`.  From the docs:

> Furthermore exceptions in finally blocks are not trappable and are unable to influence the execution of your program. This is due to limitation of DESTROY-based scope guards, which finally is implemented on top of. This may change in a future version of Try::Tiny.

I think `_check_pipestatus` can just be moved inside the `try` block?


@robinedman suggestions accepted and implemented


You could use `=` and `&&` to avoid the double negative.


Good point, gonna change that now. Thanks for the suggestion :)


s/not/no


It does not make sense to add JS for that, just add the needed prefixes into the CSS.


r=Manishearth


True, it does seem inconsistent. I'll remove "shaped".


I'm not sure about this. It causes artifacts when not in full screen mode. There's also a DOSBox aspect=true option which can be used instead. That makes me think the decision should be up to the user, and not set in dosbox.js. If set in dosbox.js, the file would have to be edited or recompiled to disable this.

It gives great results in full screen mode when real screen resolution is much higher than emulator screen resolution. The DOSBox aspect=true option fails to take advantage of the high full screen resolution, because DOSBox keeps outputting the same resolution and the browser scales that image to the full screen.


Виправляй назад! Пароль вказується набагато вище!


@TTimo Does ignoring these NN_PIPE_IN and NN_PIPE_OUT events work well for you in practice in production?

It seems that it might be OK to ignore these events during shutdown without risk of unclean shutdown or leaks; @sustrik, thoughts on whether it's OK to ignore? thanks!


And by designers I mean @khyang @Karalwy and @marcomfrag


They can be included as fields in the JSON.


No worries, I fixed it in 2d911db


Thank you for this. Just ran into the same issue.


I will take a look at that, thanks
On Jan 13, 2015 9:43 AM, "Brook Riggio" <notifications@github.com> wrote:

> Hey Jay, i just noticed your photo isn't loading correctly. Would you mind
> taking a crack at fixing it up?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/codefellows/sea-b28-foundations/commit/fde8a36e6aad8bb946fb787da3821815e7d52f52#commitcomment-9264289>
> .
>


saw approval from Manishearth
at https://github.com/Ms2ger/servo/commit/9f42ad4cd74f130dbb7db67fa3005304bedb2f76


merging Ms2ger/servo/update-wptrunner = 9f42ad4c into auto


Ms2ger/servo/update-wptrunner = 9f42ad4c merged ok, testing candidate = 6fdd04d9


This doc header is wrong - the method takes a SimpleFeature source, not a SimpleFeatureCollection


I suppose I can live with this to avoid code repetition


mine shows emergency calls only and after applying this patch it stays the same


delicious!


sounds tasty!


This looks great, but I get this error with it:

frameworks/av/media/libstagefright/codecs/amrwbenc/src/isp_az.c:69:14: error: array subscript is above array bounds [-Werror=array-bounds]
    f2[i] = f2[i] << 2;
              ^
frameworks/av/media/libstagefright/codecs/amrwbenc/src/isp_az.c:69:6: error: array subscript is above array bounds [-Werror=array-bounds]
    f2[i] = f2[i] << 2;

Do you have idea what I can do for ommit this?


Bit of a nitpick here, but wouldn't it be better for all the implementaitons of updateSchema, removeSchema, etc. were all in the same place (See lines 1180-1187 above)?


I'll fix these and do a proper PR. Thanks for the review.


> You could use = and && to avoid the double negative.

Though that involves adding `|| true` at the end and possibly more `(` `)`.


Hey there! Thanks for the investigation and the PR! The peoblem with this patch is that its depending on the order inside the container. It only selects the first occurrence and if the Chartist svg is the not the first SVG element it will not properly reuse the element.

However, after a refactoring some time ago, we put a property to the DOM node of the container called `__chartist__`. This property always points to the chart instance and the chart instance contains a property `svg` that points to the SVG node that was created by the chart. So I believe we could just check if the container contains `__chartist__` and if so we can just use `container.__chartist__.svg`. I havent tested this though.


typo: smoked.


Submitted PR: https://github.com/mupen64plus/mupen64plus-ui-console/pull/14
Should fix all build issues for you.


Sub half/half for heavy cream?


You never unbind the texture here, so the texture is used even without the call to texture.bind(0) in the main method.


Надо смотреть по тексту и по смыслу, 100% перевода быть не может, так как каждый трактует по своему, вычитку текста я еще не делал, по мере использования буду менять.

We must look at the text and meaning, 100% translation can not be, because everyone interprets its own way, proofreading the text, I have not done, as you use will change.

Musimy spojrzeć na tekst i rozumieniu, 100% tłumaczenie nie może być, bo każdy interpretuje na swój sposób, korekta tekstu, nie robiłem, jak używać zmieni.


you don't like yolks in your egg salad?


should be done only once as findViewById is considered a heavy action.


so, it's a plain omlet . . .


uint was replaced by usize in the bikeshed to end all bikesheds, but I see what you mean. I'll revert this to c_uint.


minced or diced? or precut?


looks good.


Por lo general el directorio .settings y otros que sean de tu entorno no se suben al repositorio. Fijate como funciona el .gitignore para que git lo ignore.


TEsting a commit comment


Thanks! I'll pull this branch and test it out... This is very cool.


commit latest files


These sound great.


minced


heavy cream.  It's a rich dish


Fixed, thanks.


hi, do you have a working example of this? as it is I couldn't get it to work and I think we need something like
"""
for k, t in enumerate(time_grid[:-1])
"""
at line 889 you are building a geometrical series such that if At.size = 10000 then time_grid = [   1   10  100 1000 9999]
and at line 895 you pass A_t[t:], so at the last iteration of this loop you are passing an array of size 1, which raise an exception in the fft. It also makes sense from the point of view of the binary search that we should exclude the last point, we are interested in the range 1000 to 9999. Then one would also have to change the size of g_t and Neff_t


Hey @mgeorgestevenson  here's my response


:+1: :heart:


r+


Good to know. I auto-generated the schema. I'll fix it. Thanks!


```panic!()``` should only be used when the system has absolutely no other option left. If a syscall is not implemented or recognized on one architecture, it shouldn't be a program-halting bug on every other architecture.


chocolate and peanuts with the salty sounds good


Chocolate and knishes are not quite compatible -- cuckoo for cocoa knishes!


On o


Probably- I haven't tried it.


I agree with cydh in that you could separate the two.


Is there a proper beer batter restaurant in Tribeca?


These two methods are really misleading - I think sticking to Name name and String typeName would be much clearer from a consistency perspective:

public SimpleFeatureSource getFeatureSource(Name name) throws IOException {
    if( this.name.equals( name )) {


These two methods are really misleading - I think sticking to Name name and String typeName would be much clearer from a consistency perspective:

public SimpleFeatureSource getFeatureSource(String typeName) throws IOException {
    if( this.typeName.equals( typeName )) {


Tip: tratá de usar MoreObjects.toStringHelper de guava


the constructor shoudl initialize this


Should be (vq,vi)? (this would invert the spectrum and flip the sense of 0/1 bits)


The inserted lines (12, 13, 14) and the directive !global at the end of the 17 line are breaking the Sass compilation.


Codemirror files added (codemirror.css and codemirror.js) are necessary to allow codemirror editor to be embedded into the html in place of a text area. The racket.js and scheme.js files contain the information needed by codemirror to enable syntax highlighting of racket and scheme, and the matchbrackets.js file adds paren matching to the syntax highlighter.

Changes made to home.html embed the codemirror editor into the top of the html page where the "console" text area used to be. This codemirror editor's id is "code". The console text area was moved to the bottom of the html and hidden, but is still there. This is because code in the tryrkt.js file used the "console" element for scripted actions, like button presses. For some reason I wasn't able to get the codemirror editor to interact nicely with the existing code in tryrkt.js, so instead I simply added a function that syncs the contents of the codemirror editor and the textarea whenever tryrkt.js code is called. This is a hack. There is almost certainly a better way to do this, but for now it works and we can have all of the functionality that we had with the original textarea without needing to rewrite any of the code in tryrkt.js.


OK I made a separate issue for this.  I'd consider the FFT code experimental for now, as we still need to do more benchmarking to see if it's even better than the original code.


Also a nitpick, but shouldn't typeName and name.getLocalPart() be the same? We might as well use typeName, since all the other IOExceptions in this section do (and saves a method call).


Because the number of times a new file is added is low. And it takes about a second to run, and I'd rather have that second during the debug cycle. It's so easy to run by hand when files are added that I'd rather do that.


@dmatora Cool, good to know.


Going by ConnectionManagerBean my understanding is, we are including part of service layer logic in this class. I feel it may be tightly coupled, is it good idea to move some of the service logic into service objects and make use of it in bean. Like for exp.  some of the logic from ping(), pingservice() can we move to service layer.


So your new strategy of avoiding reviews is to change the indentation level all the time? :-D


Those echos were just for testing ...


No hace falta inicializar los fields a null, Java lo hace solo.
También está bueno anotar los fields con final cuando sea posible, como en este caso (eso te dice que sólo se inicializa en el constructor).


it is header
это заголовок


Спасибо, не знал.


podrías hacer "hospital".equalsIgnoreCase(estilo)


Arbitrary whitespace/Unnecessary change here


ok thanks. I can play with this function a little bit and see if I can get is to work in a stable way


nope, changed my indent lately, so there's the source of entropy ;)


Perfect ;-)


hahaha, Resharper wanted me to do this but I thought I'd butchered your code enough! :)


some tests failed:
failure: http://build.servo.org/builders/mac1/builds/740


It is probably a lot less efficient (unless the JIT compiler has some clever special handling), but this is assertion code and can be therefore slow. No, make it boolean assertExtractRangesArgs and return true like now. It is important to return the value and test it via an assert to make sure the JIT compilers are not tempted to inline the method.


PS: if you're *just* looking to compare different ways to estimate autocorrelation times, our collaborator also has some experimental code here: https://github.com/rmcgibbo/pyhmc/tree/master/pyhmc


Sorry missed comments :)


This is really cool!
:+1: :+1:


Yes, the link will the formatted as `api__link__ui.treetable_loadbranch.html`
(http://docs.webix.com/api__link__ui.treetable_loadbranch.html)


WHY


you changed the string, not the template.  should read:
```
"database": <%=rdbms_servers_cfg.database%>,
```


This is actually patch04 - typo in the message.


Should the value be in quotes?


This is a commit comment.


Лучше закоммить его в исходники, а в ридми напиши инструкцию, как его использовать.
И, возможно, стоит все-таки создать таску с обсуждением формата.
>Ну кроме переноса длинных строк, там форматтер бессилен, потому что это уже сродни искусству.

Серьезно? Эклипс разве не переносит сам строки при автоматическом форматировании?


OK, I've tested, and further updated, the moviestim2 code. Only tested on
windows.

With latest changes the time to call draw() for each new video frame
dropped by about 50% on my pc; from 6 msec to 3 msec, with a 1280x720 60
fps video.

Also created (the start) of a testing script that can be used to save a
report of detailed computer system info as well as frame by frame timing
data for a video. This should really help in tracking down what the
bottlenecks and bugs in the current code are.

I'll post more on this on the psychopy-dev forum.

Thanks!

On Mon, Jan 5, 2015 at 8:15 AM, Jon Peirce <notifications@github.com> wrote:

> Cool.
> For the first issue I think I'd be seeing a strangely-colored movie
> during test, so I think that must be fine (not sure why - I agree it
> seems like an issue).
>
> For the second, I'm traveling right now but I'll try and test on my
> linux box when I get home.
>
> For the subImage2D thing I have no idea, but it sounds plausible.
>
> best wishes
> Jon
>
> On 04/01/2015 20:32, Sol Simpson wrote:
> >
> > Seems like a good direction, even if it ends up just for some
> > significant code simplification.
> >
> > Two things to check:
> >
> > 1) The color format of the numpy images returned by opencv is suppose
> > to be BGR, but the glTexImage2D is saying it is RGB. So this may need
> > to be updated.
> > 2) the reason for the numpy.copy that is now removed was because on
> > Linux a tester of the code reported that without this line the image
> > was not being drawn. On Windows it was OK without it though. Need to
> > retest to see if this /oddity/ still exits, or if the new code fixes
> > it somehow.
> >
> > Also, another speed up maybe achieved by using glTexImage2D for the
> > first frame draw, but then use the glTexSubImage2D call in all other
> > frame draws. At least on Windows I think this is faster because the
> > video card reuses the video memory allocated by the glTexImage2D call,
> > instead of freeing and recreating it every time a frame is transferred.
> >
> > Thanks for helping on this Jon.
> >
> > Sol
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/peircej/psychopy/commit/8af4931fe58d1618af652d9648bd0a89f60c7f3a#commitcomment-9148282
> >.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/peircej/psychopy/commit/8af4931fe58d1618af652d9648bd0a89f60c7f3a#commitcomment-9153128>
> .
>


Java doesn't have `#` comments. Please fix.


确实这样解决会更好，我将你的这个合并进来


Lo correcto es lanzar una excepción ya que el llamante no debe pasar un número negativo. En este caso sería una IllegalArgumentException. La forma en que yo lo haría es usando guava, al principio del método agregaría
Preconditions.checkArgument(numeropisos >= 0, "El numero de pisos no puede ser negativo");


Please remove indentation in these examples.


How am I supposed to set the option AccountsGuest to false if I wish so?
What's the canonical way of doing this?


В тексте Ticker Symbol нигде не используется, прошел Тоталл коммандером по всем файлам, не нашел.

The text Ticker Symbol never used, was Totall Commander on all files not found.

Tekst skrót nazwy nigdy nie używany, Dowódca był totall nie znajdując wszystkie pliki.


Thanks Igor ;)


where does session come from here?  This should raise a name error unless you have 'session' in your global namespace when you run the code, and then you're just lucky.


inquiry should not be required here.  You only want these methods to return one kind of thing, instances of the model class itself.


Nice find with the `onupdate` argument!


Por qué puede ser nulo? No debería.


rax retry tests


Funny :D
I'm an Arch user myself, and I made my fork of vba-sdl-h to make it build & run on arch. libpng12 is in the AUR, and it works just fine (at least here?). Anyway, I'll try to make it run with newer libpng versions (removing the functionality altogether isn't nice).


You'll want to remove all `.pyc` files from your repository and then add "*.pyc" to your .gitignore file.

You will also want to do the same with the `learning_journal.egg-info` directory and the `learning_journal.sqlite` database.  Neither of those should be under version control.


No es que puede ser nulo, sino que aviso que el buildingbuilder devuelve nulo al no ser correcta la entrada de parametros.


I think it would be more clear to use different names like:
`var rangeSetString = String(rangeSet);`
`assert.strictEqual(typeof rangeSetString, 'string', 'Ledger range malformed');`
`var rangeStrings = rangeSetString.split(',');`
`var range = rangeStrings[0].split('-').map(Number);`


Returning a SimpleFeatureCollection defeats the point of a method called "createDatastore". Either update the method name or use DataUtilites.store() and return a DataStore. Also, now that you return a SimpleFeatureColleciton rather than a DataStore, the docstring is wrong.


Good point.  I do think some of the connection management pieces are fairly tightly coupled and probably could/should be refactored.  I think this effort was a little larger after reviewing my POC than the time we have for release.  We can create a ticket for this if we like but this shouldn’t effect functionality as is.

From: sailajaa [mailto:notifications@github.com]
Sent: Tuesday, January 13, 2015 1:12 PM
To: jsmith2/CONNECT
Cc: Smith, Jason A (CGI Federal)
Subject: Re: [CONNECT] PoC for Admin GUI Connection Manager (58e4b21)

Going by ConnectionManagerBean my understanding is, we are including part of service layer logic in this class. I feel it may be tightly coupled, is it good idea to move some of the service logic into service objects and make use of it in bean. Like for exp. some of the logic from ping(), pingservice() can we move to service layer.

—
Reply to this email directly or view it on GitHub<https://github.com/jsmith2/CONNECT/commit/58e4b21c175f93cc88beacc3bb90b1826520bc24#commitcomment-9264729>.


:( damn keyboard of my old laptop is falling apart, thanks!


I thought about it. On second thought, I'll do that


I need a method to estimate the equilibration point, but thanks for the
link

On Tue, Jan 13, 2015 at 6:16 PM, Kyle Beauchamp <notifications@github.com>
wrote:

> PS: if you're *just* looking to compare different ways to estimate
> autocorrelation times, our collaborator also has some experimental code
> here: https://github.com/rmcgibbo/pyhmc/tree/master/pyhmc
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/choderalab/pymbar/commit/476f020c718b9a4aaf18673c6885660a50a5b5c6#commitcomment-9264801>
> .
>


That doesnt fix the problem that cd can only have MAX_CHAT_USERS(20) entrys and MAX_BG_MEMBERS is 30.


As above, you should probably change the name to something other than createDatastore if you are not actually creating a DataStore


If you wouldn't use Apple, it would work perfectly :P [or at least with Windows]. I don't know why the code depends on the operation system, because as far as I know the java sound libery :package: javax.sound.sampled should always work regardless on what OS you're using.


Yes, I am expecting a -1 on the end of file.  37 is the size of the xml tag the rrdtool prepends to all responses.  I need to remove that tag from all responses so the graph will display in HTML page.


Ah.. Looks like I pushed a wrong set of changes to the repo which is still in code review. I'm going to revert the last 3 commits.


any idea why it adds two lines for this comment? the comment doesn't really need to exist, but extra spacing makes it less obvious that it relates to the stuff below.


@mpc-hc: If you agree I will probably add this one to the stable. It should cause any issue. I'm not even sure it's worth triggering a nightly for it.


good call fixing all of these != that should be "is not" .. i turned off my linter when editing this thing and regret it :)


I have https://github.com/XhmikosR/mpc-hc/commit/36f304a3ee6941124e8471de829ee853dc97f69a I want to test too, so I say we gather a few patches and push them either today or tomorrow.


What are you using to compile? The newest versions of Ruby Sass and libsass will compile fine.


when we squash this i'm going to back out this commit - it doesn't have any useful impact, and there's a different change on cohorted-courseware that is better.


Well, it works now. Just moved the GraphicsEnvironment thingy before the call to the sounds.


The API dosn't depend on OS or soundcard: :information_source: http://de.wikibooks.org/wiki/Java_Standard:_Das_Paket_javax.sound.sampled


It is pep 8 spacing between the class declaration and anything above it.
The comment should go under the class definition I think.


Great :+1:


> But I don't mind having your solution if you think mine is too much.
I'm not sure. This solution also avoiding bliting completely but I'm not sure if matters at all.

> You are also missing one case, when the rect is not changed.
Yeah and indeed it might be too tricky to handle.


Shouldn't you use "SimpleFeatureCollection featureCollection = FunctionTestFixture.polygons();" here?


Yep, i believe this is implemented and working-- see https://github.com/killbill/killbill-admin-ui/blob/tenants/app/controllers/kaui/tenants_controller.rb


use interface


I think this could be changed to `hspec >= 1.3 && < 2.2` unless anyone objects?


Why? This will surely use more memory, put more stress on GC, etc.  Ideally we should be going through our codebase and finding opportunities to perform the opposite transformation.


@thatsmydoing I believe a `elif [[ $term_id == 'check_xdotool' ]]; then` would be better here.

The idea is that "terminal" specific code shouldn't run unless we are sure to be in the right "environment" (in this case, a linux box with xdotool installed).


you should use idea search to be sure you fixed all typos


Shouldn't the key for this be `"database"` and not `"rdbms_server_cfg.database"`?


Yes... because we only want to set Result to true (being optimistic) if the parameters stand any chance at all of being parsed.... otherwise, we need to return false.


(It is definitely the case that one of the biggest causes of rebuild performance issues is how much thrashing GC does when we read every single file vaguely associated with the build fully into memory over and over for every rebuild.)


it's an internal auto job, that mustn't run from outside


I'll implement the solution for ELSEIF as well. Forgot about that one!


spelling of Google is incorrect.


@Reflejo true it does prevent it from working on iOS 7 private targets, I suppose it's a majority stake here, I personally feel most people using Snap and Cocoapods will be targeting app store releases and sorts.

You can always create a fork and keep it up to date or just create a private Snap.podspec that points to our git repository that allows for iOS 7.0 targets I'm just not sold on allowing it right now as I've already been asked twice privately about the -Xlinker error before this change was committed.


**SideCI-STG / RailsSecurity - Security Warnings**
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting) Unescaped parameter value
app/views/projects/commits/show.html.haml:22
[Dynamic Render Path](http://brakemanscanner.org/docs/warning_types/dynamic_render_path/) Render path contains parameter value
app/views/projects/milestones/index.html.haml:15
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting/) Unescaped model attribute rendered inline
app/controllers/projects/merge_requests_controller.rb:31
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting) Unescaped model attribute
app/views/projects/merge_requests/_show.html.haml:67
[Dynamic Render Path](http://brakemanscanner.org/docs/warning_types/dynamic_render_path/) Render path contains parameter value
app/views/projects/merge_requests/index.html.haml:8
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/link_to_href) Unsafe parameter value in link_to href
app/views/profiles/keys/_key_details.html.haml:22
[Redirect](http://brakemanscanner.org/docs/warning_types/redirect/) Possible unprotected redirect
app/controllers/projects_controller.rb:131
[Mass Assignment](https://groups.google.com/d/msg/rubyonrails-security/M4chq5Sb540/CC1Fh0Y_NWwJ) create_with is vulnerable to strong params bypass. Upgrade to Rails 4.1.5 or patch
Gemfile.lock:386
[Redirect](http://brakemanscanner.org/docs/warning_types/redirect/) Possible unprotected redirect
app/controllers/projects_controller.rb:122
[Dynamic Render Path](http://brakemanscanner.org/docs/warning_types/dynamic_render_path/) Render path contains parameter value
app/views/projects/issues/_issues.html.haml:18
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting/) Unescaped model attribute rendered inline
app/controllers/projects/merge_requests_controller.rb:32
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting/) Unescaped model attribute rendered inline
app/views/projects/merge_requests/show/_mr_accept.html.haml:29
[SQL Injection](https://groups.google.com/d/msg/rubyonrails-security/wDxePLJGZdI/WP7EasCJTA4J) Rails 4.1.1 contains a SQL injection vulnerability (CVE-2014-3482). Upgrade to 4.1.3
Gemfile.lock:386
[SQL Injection](https://groups.google.com/d/msg/rubyonrails-security/wDxePLJGZdI/WP7EasCJTA4J) Rails 4.1.1 contains a SQL injection vulnerability (CVE-2014-3483). Upgrade to 4.1.3
Gemfile.lock:386

[Click here if you want to see all Security Warnings](http://www.codemagica.com/github_repositories/18295016/security)


EDIT: kernel does not boot don't know why


Ok :)


[CodeMagica/RailsSecurity] Render path contains parameter value
reference: http://brakemanscanner.org/docs/warning_types/dynamic_render_path/


[CodeMagica/RailsSecurity] Unsafe parameter value in link_to href
reference: http://brakemanscanner.org/docs/warning_types/link_to_href


[CodeMagica/RailsSecurity] Unescaped model attribute rendered inline
reference: http://brakemanscanner.org/docs/warning_types/cross_site_scripting/


magic number


Guessing this is your problem line? If so you're just missing a word and it will build 😉


Confused. I thought we had that discussion and you said you could not make it work without using an extra table:
* rails sets a browser cookie (session)
* rails uses that table to map the browser cookie with the entry in kaui_users which allow to extract the kb_session_id (JSESSIONID)


Why this is needed?


wrong collection chosen, think on how to optimize number of iterations


I was making the changes under an older commit and only rebased at a later time...
My bad, I'm sorry :(


@im-denisenko I already merged the pull request. Can you add this with a new one? Or @webdevsHub perhaps you can directly add it?


Maybe set a variable once instead of writing this 5 times (and not consistently at that)?


Yep that's in my list; I generate the schema when i am done with my DB changes.


Why?


I had some problems using ```spawn``` here. Sometimes the unit would be deleted before the save account was complete, so it would not work correctly.


Lodash looks nice here:

    var ledger = Number(ledger);
    var matchingRange = _.find(this._ranges, function(range) {
        return ledger >= range.start && ledger <= range.end;
    });
    return matchingRange ? true : false;


SVN history:
```
------------------------------------------------------------------------
r57128 | pwarren | 2012-04-20 15:03:47 -0500 (Fri, 20 Apr 2012) | 1 line

Upgrade to relstorage 1.5.1. Reviewed by jhanson.
------------------------------------------------------------------------
r55779 | bedwards | 2012-03-23 15:21:34 -0500 (Fri, 23 Mar 2012) | 1 line

Fixes ZEN-949. It is safe to log relstorage POSKeyError messages at debug level. Reviewed by Joseph.
------------------------------------------------------------------------
r50310 | ian | 2011-11-11 09:38:26 -0600 (Fri, 11 Nov 2011) | 1 line

Fixes #29366: Add a log message and whatnot when the connection is recreated. Reviewed by Joseph.
------------------------------------------------------------------------
r45747 | jplouis | 2011-07-21 14:22:51 -0500 (Thu, 21 Jul 2011) | 1 line

upgrade to relstorage 1.5.0. reviewed by pwarren
------------------------------------------------------------------------
r45745 | jplouis | 2011-07-21 13:50:10 -0500 (Thu, 21 Jul 2011) | 1 line

add connection patch back to relstorage
------------------------------------------------------------------------
```


What would happen if this constructor was not here?


conventions for constants' names?


@markburns, I removed support for old Factory Girl syntax and do some refactoring. What do you think ?


why have you remove that ?


@glasser it is a temporary solution for now, but the point is to convert os.EOL's to '\n' character.


The spacing in this section is inconsistent, even between your new code and the existing code. Either space the new lines to mach what is already there, or fix the whole section.


The unit itself is not passed to the spawn...


use formatting idea option before commit to not omit unformatted lines


s/with/without/


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9988/testReport/) for this commit**


pylint shows trailing whitespace on this line -- can you fix everywhere.


also make as a configurable property


pylint shows line too long, can you fix everywhere.


SVN history:
```
------------------------------------------------------------------------
r57128 | pwarren | 2012-04-20 15:03:47 -0500 (Fri, 20 Apr 2012) | 1 line

Upgrade to relstorage 1.5.1. Reviewed by jhanson.
------------------------------------------------------------------------
r49605 | dgarcia | 2011-10-25 13:56:37 -0500 (Tue, 25 Oct 2011) | 1 line

add relstorage patch to use pymysql
------------------------------------------------------------------------
```


OptionalTypedArgs (lefticus) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:222](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/include/chaiscript/dispatchkit/type_conversions.hpp#L222) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:557](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/include/chaiscript/dispatchkit/boxed_number.hpp#L557) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __warning__: [include/chaiscript/dispatchkit/proxy_functions.hpp:265](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/include/chaiscript/dispatchkit/proxy_functions.hpp#L265) The class 'Dynamic_Proxy_Function' defines member variable with name 'm_arity' also defined in its parent class 'Proxy_Function_Base'. (duplInheritedMember)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:170](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/src/main.cpp#L170) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:137](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/src/main.cpp#L137) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:217](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/src/main.cpp#L217) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:159](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/src/main.cpp#L159) The function 'throws_exception' is never used. (unusedFunction)
 - __information__: [:](../blob/c1f47cbc1650f59d41f1e928e1f8d5b10f92386e/#L) Cppcheck cannot find all the include files (use --check-config for details) (missingInclude)


Test


I prefer to avoid any memory management.


`panic!()` is used for logic errors, as in errors that don't *need* to be detected at runtime. An example of that is the array bounds check, since the caller can easily check in advance if they care. AFAIK, the point of the non-exact suffix functions is that the differences between architectures are abstracted over.


I see you call ```_unit call fn_getPlayerData``` to get the argument. Nice.


Good boy


@Tratcher signed off on this PR (https://github.com/aspnet/FileSystem/pull/31#issuecomment-69795621). So I'm not reverting this change now.


Yup, we need to store the `kb_session_id`.

I'm actually referring to the `kb_`__`tenant`__`_id`. That could live in the cookie, since we don't need to remember a mapping? It's kind of weird to store it in the table because each time you log-out and log back in, that value can change (if you switch tenant).


SVN History:
```
------------------------------------------------------------------------
r63593 | dgarcia | 2012-09-04 11:03:59 -0500 (Tue, 04 Sep 2012) | 1 line

* fixes ZEN-3305: object_state table should use compressed row_format; reviewed by jcausey & pwarren.
------------------------------------------------------------------------
```


"emtpy" should be "empty"


Yep, gather all the data first then pass it to the spawn, that way it can do async save even after the unit is gone.


why not directly link to the timeperiod function here ?
```
'ISVALIDTIME': ('', Timeperiod.is_time_valid )
# same for NEXTVALIDTIME
```
This will save a getattr() call (and simplify) in the added code below which makes use of this validtime_macros..
?


don't read all file in memory, process line by line


SVN history:
```
------------------------------------------------------------------------
r78092 | plu | 2013-11-26 13:04:50 -0600 (Tue, 26 Nov 2013) | 1 line

fixes ZEN-9150 - reviewed by jplouis, imccracken: release commit lock after filling object_refs table
------------------------------------------------------------------------
```


That was easier than expected: https://github.com/cosarara97/vba-sdl-h/commit/b27bc1bbfe0dd6e6e0befe3125fa82ce0e9bbc4f


OptionalTypedArgs (lefticus) - x86_64-MacOS-10.9-clang-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


false?


I meant to say "Matched RSP recompiler more closely to interpreter".


That support is now added :)


Never mind the DS_A to DS_W, I forgot to delete them. I'll do so in my next commit


wrappers


I am still supporting it, but I have gotten feedback from others that it is not as useful as it once was. It would be great if you or others could send me stories of use or links to projects using tailbone. That would be really helpful. Send me your use and stories at tailbone.stories@google.com, so I can get a sense of how it is being used by the community.


init with false?


init with 0?


As we've seen, there is demand for these features.

It would be good to run pylint and fix everything flagged for this change.

I also notice a lot of extraneous blank lines that should be removed but weren't picked up by pylint.

You should read https://google-styleguide.googlecode.com/svn/trunk/pyguide.html and ensure that everything conforms.

I'll take another look when the basic issues are resolved.


Can this be #eee please.


how to check boolean var is true?


```
+                    # Get the right function to call
+                    try:
+                        func = getattr(timeperiod, func_to_call)
+                    except AttributeError:
+                        return failed_output
+                    return str(int(func(timestamp)))
```
would, simply, become:
```
return str(int(func_to_call(timeperiod)))
```
and that's it.


not resolved conflicts


Since lodash is now included we'll probably start to look for excuses to use it everywhere, but I'll probably leave this for now. I think I'd prefer `_.findIndex(this._ranges, fn) !== -1` anyway https://github.com/lodash/lodash/blob/master/lodash.js#L5594-L5595


```
if macro_name in self.validtime_macros
```
simpler. more concise.


newline after the curly brace


Maybe a comment would be helpful, especially about the 37 (maybe tell us what the tag is?)


Please remove last sentence of commit message, as `_call_all()` no longer exists.


I assume this is so the new incident will still show up in the table. Great. Just want to be sure this will happen.


just added some more examples and made minor fix


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:222](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/include/chaiscript/dispatchkit/type_conversions.hpp#L222) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:557](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/include/chaiscript/dispatchkit/boxed_number.hpp#L557) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __warning__: [include/chaiscript/dispatchkit/proxy_functions.hpp:265](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/include/chaiscript/dispatchkit/proxy_functions.hpp#L265) The class 'Dynamic_Proxy_Function' defines member variable with name 'm_arity' also defined in its parent class 'Proxy_Function_Base'. (duplInheritedMember)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:170](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/src/main.cpp#L170) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:137](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/src/main.cpp#L137) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:217](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/src/main.cpp#L217) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:159](../blob/3d1edbf38fa7fa85802abca4a6998144a12dedb8/src/main.cpp#L159) The function 'throws_exception' is never used. (unusedFunction)


Traditionally, Loggly tags are configured on per-source basis at startup of an app or syslog daemon. Tags defined within the event itself are usually passed as JSON fields. @einnocent would it be possible for grok to append a JSON field instead?  If not, perhaps you could describe you use case for this?


or even better:
```
macro = self.validtime_macros.get(macro_name)
if macro:
    failed_output = macro[0]
    func_to_call = macro[1]
```
less to type and less attr getter (object.attribute[index]) is better ;)


I was hoping someone else would comment further... Since no one did:

If we accept that one could search in Google for the URL, then I we could also remove the original "Addresses:" line: anyone can search for "exuberant ctags" in Google and get that information, right? Personally, I would prefer not to remove the original URL because we are not forking the project. But I feel that providing the development URL to anyone who runs `ctags --version` is helpful and this is the shortest line I could remember that provides that information.


what is getter name for boolean? don't write with hands, generate getters/setters


Probably don't want console.log here?


No thanks. This is tied to the formulation of the sentence. Breaking out the `'a component'` part would be early reuse (DRY gone wild). That part of the sentence is coupled to the error message and the error message is likely to change on it's own. You would have to reintegrate the whole thing just to change the grammatical structure of the sentence.

It would only make sense to break out both the sentence creation and the name/`'a component'` so that when you update the error message, you're in control over both parts in the same place.

However, we only have two callers of each message. That would be early abstraction and makes it more difficult to read and more difficult to put extra examples in there. Such as `class Foo { state = ... }` and `class Foo { constructor() { ... } }` or links to examples.


Remove?


Hi Tesmai4,

Did you set HVISION_LOCAL? in your .bash_profile file? If not, then you will need a running Hadoop with the same version as the one in pom.xml file.

Thanks,
Emad


Great! It's very, very nice. Could you incorporate into a pull request?


cloneception


@zeke side-note, but I think you may find my changes to this interesting. :)


Hey just saw your reply on the PR.  Let's continue the thread there since it'll be easier to track there.


Hi @toadkicker, today I'll release latest changes to Rubygems, so this project not dead yet. can you please keep updated to this repository?


Does /mnt/whoosh_index is docker volume here?


Use Asset Management
http://symfony.com/doc/current/cookbook/assetic/asset_management.html


@marcotuts or @talbs Either of you have a second to review? I'm probably not the right person for PR reviews.


and then, finally, the first item of the 2-tuple ( '', Timeperiod.is_time_valid ) is useless and the validtime_macros definition can be shortened to :
```
validtime_macros = {
    'ISVALIDTIME':          Timeperiod.is_time_valid,
    'NEXTVALIDTIME' :   Timeperiod.get_next_valid_time_from_t,
}
```
is there anything against that ?


текст уже убрал.
Станить вроде как неважно в какую часть тела.
Немного косячно еще. позже допилю.
Да, проверял, работает


done


I forgot to add that this was required to make the autocompletion in search forms work (see issue #879). HTML5 also makes it valid (like in XHTML) to explicitly close self-closing elements (like `<br />`), if wanted.


better remove this functionality


>Are there some new parameters fitting into this schema, like csv-quote-all? Maybe we can keep the number of additional parameters with a fixed sequence as small as possible.

Good idea, I just followed the old design. Your csv option list a solution for it.

>I wonder why you removed std::ostream& result in various places and replaced it by std::cout. It will be very hard to call process_csv_linefor a different ostream later on, if needed.

I didn't saw any other callers. If concrete needed we can bring it back. In the other classes I saw only direct use of `std::cout`.


I thought ISO 8601 was a reasonable choice. Consumers of the data can convert if necessary. Why do you prefer epoch time?

On Tuesday, January 13, 2015 at 12:45 PM, Marco Ceppi wrote:

> Would it be better to use EPOCH here instead?
>
> —
> Reply to this email directly or view it on GitHub (https://github.com/juju-solutions/pts/commit/c3c42a1cc027a34c024ae9e717ee5ece5b1b5d55#commitcomment-9264316).
>
>
>
>
>


where are junits?


noop


you could also do `implode( ',', wp_list_pluck( $tags, 'name' ) )`


review code carefully


Yeah this is a temporary custom hack for one of our projects.


[CodeMagica/RailsBestPractices] remove unused methods (Oauth::ApplicationsController#set_application)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (Admin::KeysController#key_params)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (ApplicationHelper#page_filter_path)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (ApplicationHelper#outdated_browser?)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (ApplicationHelper#path_to_key)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (ApplicationHelper#redirect_from_root?)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (TreeHelper#edit_blob_link)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (SelectsHelper#groups_select_tag)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (DiffHelper#inline_diff_btn)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (DiffHelper#parallel_diff_btn)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (MilestonesHelper#milestones_filter_path)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (GroupsHelper#group_settings_page?)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (DashboardHelper#assigned_mrs_dashboard_path)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (DashboardHelper#assigned_issues_dashboard_path)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (TeamcityService#fields)
reference:


[CodeMagica/RailsBestPractices] remove unused methods (Note#editable?)
reference:


[CodeMagica/RailsBestPractices] restrict auto-generated routes projects/projects/branches (only: [:index, :create, :destroy])
reference: http://rails-bestpractices.com/posts/86-restrict-auto-generated-routes


[CodeMagica/RailsBestPractices] use query attribute (@project.name?)
reference: http://rails-bestpractices.com/posts/56-use-query-attribute


[CodeMagica/RailsBestPractices] use query attribute (@project.path?)
reference: http://rails-bestpractices.com/posts/56-use-query-attribute


[CodeMagica/RailsBestPractices] remove unused methods (ProjectsHelper#project_wiki_path_with_version)
reference:


With Infinite Odyssey update level cap will be gone and this will still be sent when you are 99 level. so using max level shouldnt be good idea.


Ah, thanks


Done.


I mean "a *collection* of..."


Nice!


You haven't responded to any PR's in several months, or messages I've sent you, or had regular releases. This gem needed a lot of cleanup. I couldn't get you to respond to those conversations. I figured you weren't paying attention to it anymore, so I forked it and did the rewrite.


wut


Whoops.


IT's a TREE! but that doesn't work in the branches.


agreed, done


Kyle, this doesn't work for me.  This isinstance is returning false.  I ned to switch this back.

![screen shot 2015-01-13 at 1 58 38 pm](https://cloud.githubusercontent.com/assets/3372403/5726805/4b25c1ac-9b2c-11e4-9cf1-953e140f05ff.png)


how do I checkout?


If your start/stop row contains "\" - slash, mapreduce key is beeing malformed. For example:
{code}
-Dhbase.mapreduce.scan.row.start=\x00\x01\x00\x00\x00\x00\x00\x00\x00 -Dhbase.mapreduce.scan.row.stop=\x00\x01\x00\x00\x00\x00\xD3\xD8\x9860000002
{code}
params have their slashes truncated:
{code}
2015-01-13 20:36:18,718 INFO org.apache.hadoop.mapred.MapTask: Processing split: T2LTWINBACK3.tele2.lan:x00x01x00x00x00x00x00x00x00,x00x01x00x00x00x00xD3xD8x9860000002
{code}
therefore no data is selected for a job.


pong


This seems to have broken loading species datapackages for everyone. For a change like this, please don't push to master and instead make a PR so there can be a discussion.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9989/testReport/) for this commit**


you can also do 'if current_user', but this works!


r+ rollup


some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2783


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:222](../blob/f66b4aafc175411b553363b151661c3d4306b745/include/chaiscript/dispatchkit/type_conversions.hpp#L222) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:557](../blob/f66b4aafc175411b553363b151661c3d4306b745/include/chaiscript/dispatchkit/boxed_number.hpp#L557) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __warning__: [include/chaiscript/dispatchkit/proxy_functions.hpp:269](../blob/f66b4aafc175411b553363b151661c3d4306b745/include/chaiscript/dispatchkit/proxy_functions.hpp#L269) The class 'Dynamic_Proxy_Function' defines member variable with name 'm_arity' also defined in its parent class 'Proxy_Function_Base'. (duplInheritedMember)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/f66b4aafc175411b553363b151661c3d4306b745/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:170](../blob/f66b4aafc175411b553363b151661c3d4306b745/src/main.cpp#L170) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:137](../blob/f66b4aafc175411b553363b151661c3d4306b745/src/main.cpp#L137) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:217](../blob/f66b4aafc175411b553363b151661c3d4306b745/src/main.cpp#L217) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:159](../blob/f66b4aafc175411b553363b151661c3d4306b745/src/main.cpp#L159) The function 'throws_exception' is never used. (unusedFunction)


Added a comment


Don't think so.  This is consistent with what is done elsewhere.


See mailing list.


Looks good.


What about Normal Natural Gift?


La sagesse ! :)


Please submit these things to the issue tracker: http://youtrack.sk89q.com/


Yep, the default is 0.5, the new code can handle other anchor values.


I switched to "==".  Work for you?
  if vartype == str