This is very interesting. As far as I can tell the test is checking for a problem with the cache and the current code does not have this problem. Should we hack the code to ensure we have this problem and the original unit test passes?


enable mysql.log to see queries >> /etc/???/mysql.cnf


Since this is going to be a mainline tool, it'd be nice to get some docs on usage going on. Compare with `p2-bootstrap`


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


While you might be able to fake the header (like you can fake any header originating in the browser), if you are behind a load-balancer, you could at least trust the right-most value (assuming you trust your own load balancer) since the load balancer is modifying the header to add the actual IP address that is connecting to it. How hard would it be for a new checkbox setting to be added that said "Use X-Forwarded-For header for IP"? People behind load balancers could check it and people that were not could leave it unchecked. I do worry that a bot could just use this header to mask its IP. Another option would be concatenate the X-Forwarded-For value with the real ip (which might be the load balancer) and then all the information would be logged.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10070/testReport/) for this commit**


I think because Forge also does this to allow [creation of fake players](https://github.com/MinecraftForge/MinecraftForge/blob/master/src/main/java/net/minecraftforge/common/util/FakePlayerFactory.java#L17).


The spelling improvements are hard to distinguish in the diff, so here they are:

continues integration -> continuous integration
on travis-ci.org are build -> on travis-ci.org are built
you can ommit the CI flag ->  you can omit the CI flag

Cheers.


Good call. I took a second look and just noticed my error was different from theirs. I think this goes back to the shaded WG methods in CH again. So the real fix might be my CH pull request.


> How do we fix this?

Alias `git checkout release-0.3` to `git checkout release-0.3 && git submodule update` ?

Looking at https://github.com/JuliaLang/openlibm/compare/0b9d67e54a5b07e32a27b68cf0a01c33b515fc9b...3ee2a6e6a9fc68cbf2ab00f830b9059215e40b06 this one should be pretty safe though.


999 times commit ?!


Guys, the bootstrap is not going to function normally, the Glyphicons are not working because of relative path as well.


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I use emacs mostly but sometimes use vi for quick edits.
You can find me on irc freenode as user KaKaRoTo in a few channels (/whois
me). I'm not on the pc right now though do we could talk tomorrow, just
write me and I'll reply when i become available.
 On Jan 15, 2015 7:18 PM, "Antonio Morillo" <notifications@github.com>
wrote:

> alright! there's another thing what editor are you using, vim? Is there a
> way to chat you? :P
>
> On Thu, Jan 15, 2015 at 7:42 PM, Youness Alaoui <notifications@github.com>
>
> wrote:
>
> > Humm... I thought i fixed the issue with extract.. If dump works then
> the
> > file is fine and extract is at fault. It's probably because if the paged
> > seek indeed. There could also be an issue with 64bits, I've fixed a
> 64bit
> > issue for windows but there might be other similar issues. If you figure
> > it
> > out let me know.
> > Thanks
> > On Jan 15, 2015 6:40 PM, "Antonio Morillo" <notifications@github.com>
> > wrote:
> >
> > > QT creator, i'll blow up this testing branch and gonna commit to the
> > > master, then i'll come up with the pull request... there's another
> > issue...
> > > Extract function is not extracting the data as it should. I guess is
> the
> > > paged_file_seek function, when i extract the file comes with a
> different
> > > md5sum, but when i dump(function) it works great(same md5sum), even
> tho
> > it
> > > recovers perfectly on the PS3.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307074>
>
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307370>
>
> > .
> >
>
>
>
> --
> =========================
> Antonio Morillo
> =========================
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307433>
> .
>


That's a much better approach, thanks! https://github.com/rstudio/rstudio/commit/dffab9664ff56d4bd4a248b8cf85f528869d8976.


Alright thanks :D

On Thu, Jan 15, 2015 at 8:00 PM, Youness Alaoui <notifications@github.com>
wrote:

> I use emacs mostly but sometimes use vi for quick edits.
> You can find me on irc freenode as user KaKaRoTo in a few channels (/whois
> me). I'm not on the pc right now though do we could talk tomorrow, just
> write me and I'll reply when i become available.
> On Jan 15, 2015 7:18 PM, "Antonio Morillo" <notifications@github.com>
> wrote:
>
> > alright! there's another thing what editor are you using, vim? Is there
> a
> > way to chat you? :P
> >
> > On Thu, Jan 15, 2015 at 7:42 PM, Youness Alaoui <
> notifications@github.com>
> >
> > wrote:
> >
> > > Humm... I thought i fixed the issue with extract.. If dump works then
> > the
> > > file is fine and extract is at fault. It's probably because if the
> paged
> > > seek indeed. There could also be an issue with 64bits, I've fixed a
> > 64bit
> > > issue for windows but there might be other similar issues. If you
> figure
> > > it
> > > out let me know.
> > > Thanks
> > > On Jan 15, 2015 6:40 PM, "Antonio Morillo" <notifications@github.com>
> > > wrote:
> > >
> > > > QT creator, i'll blow up this testing branch and gonna commit to the
> > > > master, then i'll come up with the pull request... there's another
> > > issue...
> > > > Extract function is not extracting the data as it should. I guess is
> > the
> > > > paged_file_seek function, when i extract the file comes with a
> > different
> > > > md5sum, but when i dump(function) it works great(same md5sum), even
> > tho
> > > it
> > > > recovers perfectly on the PS3.
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307074>
>
> >
> > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307370>
>
> >
> > > .
> > >
> >
> >
> >
> > --
> > =========================
> > Antonio Morillo
> > =========================
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307433>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DetrikSyS/ps3xport/commit/db3b64de0509f545bea56ebb32a7dc0f0ceb7b47#commitcomment-9307556>
> .
>

--
=========================
             Antonio Morillo
=========================


Yes, so the null check needs to be removed so we don't sweep that bug under the rug


fixed


* ```)```
* No quotes around href value


Please add this back to the `keydown` handler.


The card name doesn't change. Only the subtype does.


and comment out this one:
	//$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
for log


The `else` bracket does nothing here.


The NFE policy I feel should boil down to the following points:

- Is the Pokemon viable? (does it qualify for the RU tier or higher)
- Does the Pokemon have some stat, typing, item (not counting Eviolite), or ability that give it a noticeable advantage over its fully-evolved counterpart that could make it interesting to use in Random Battles?
- Alternatively, is the Pokemon OU? (In other words, is it Chansey?)

Under this policy, the Pokemon that would apply are (in my opinion):
- Chansey - It's OU, enough said. Eviolite allows it to completely outclass Blissey, to the point that Blissey dropped to UU.
- Doublade - Although Aegislash can effectively have 150/150/150/150, it needs King's Shield to gain its defenses back. Doublade's base 150 Defense boosted by Eviolite will always remain, even if an opponent attacks after it, and it still has a respectable base 110 Attack.
- Pikachu - Light Ball causes it to outdamage Raichu in exchange for lower defenses and speed.
- Porygon2 - It has higher defenses than Porygon-Z that are further boosted by Eviolite, giving it more of a supporter role than Porygon-Z's all-out attacker role.
- Scyther - Is faster than Scizor (base 105!) and still has a respectable 110 Attack.

Magneton could potentially qualify under this policy, but I don't think that the extra 10 base speed is going to pull much weight considering that 10 extra speed only puts it into base 70.


oops, wrong line ;)


AddMoreWarningFlags (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Please change description to _"The separator between tags. Defaults to `' '`. Must be a single character."_


I don't know, will need to look. From quickly reading the code it seems that buffer boundaries are used for reseting and flushing stuff. Since the Java code does have it, it'd imply one of two things (1) there's a Java <-> .NET behavior mismatch somewhere, or (2) there's a bug somewhere else. Either way, we should (at least at this phase) preserve the same behavior as Java Lucene's.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1880](http://teamcity.monogame.net/viewLog.html?buildId=4398&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 359, ignored: 6 Build time: 00:17:10


Does this work? Is KUBERNETES_PROVIDER defined in cmd/e2e/e2e when executed from hack/e2e-suite/goe2e.sh?


develop (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


More recent


Let's do `!== 1`


It's been working for me when I've been running the gke e2e tests.


Looks fine to merge.


Yeah, it works without it. I'm not sure why I added it.


Unfortunately this makes it even harder not to directly require on Sequelize...


cool. works great thanks.


I believe this test verifies that some abnormal use is getting refused to - pretty much likes AssertThrows. Probably something like mismatching readers being used to read the same cache key. Notice the SUBREADER insanity type. Will need to properly dive into this one, but it is probably actually checking for the right thing, and we currently have a faulty implementation.


Doesn't look like object dtype will be correctly handled, which IMO is fine.  Just make sure the comments say that explicitly.


Style nit: avoid for loops without { }


add `raise ArgumentError, "does not work with object dtype" if self.dtype == :object`?

I haven't checked through exactly where this will fail if you use object dtype, but if it gets to the actual solve part, I suspect it would do something really wacky and then segfault in the ruby interpreter later, which would be bad and hard to track down.  Better just to preempt any problems here with the explicit raise.


Maybe I'm paranoid, but can you add a test with a matrix that's not symmetric?


There's still the potential conflict mentioned in https://github.com/esseks/monicelli/issues/4#issuecomment-68611352 - if you use `con rinforzino` you have to add more complexity to the parser to be able to declare constant parameters to functions.


It's shitty, but it works when it matters. I really want a better way.

On Thu, Jan 15, 2015 at 4:39 PM, roberthbailey <notifications@github.com>
wrote:

> It's been working for me when I've been running the gke e2e tests.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GoogleCloudPlatform/kubernetes/commit/f30846ecd57cd51e6b8264b750d1d7f477c83be3#commitcomment-9307629>
> .
>


I just tested my fixed SKCompat with my broken CH (with the shaded classes) and the function works fine.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1881](http://teamcity.monogame.net/viewLog.html?buildId=4401&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:01


A simple app that paints inside the boxes to whichever color the user picks.


@ian29 You can install w/:
`pip install -e git+git@github.com:mapbox/make-surface.git@batch-print#egg=makesurface`
Usage example:
`makesurface fillfacets '/Users/dnomadb/Dropbox (MapBox)/datashare/gfs1.tif' -np -bp 10`
gives:
```
{"s0s2s1s2s3s3s2s2s3s2s1s": {"value": 2.9589981858603465}, "s0s2s1s2s2s2s2s2s2s3n1s": {"value": -19.511441610869397}, "s0s2s1s2s3s2s2s3s3s2n1n": {"value": 2.8972006439210416}, "s0s2s1s3s3s3s2s3s2s1s3n": {"value": -1.5731111904094501}, "s0s2s1s3s3s2s2s2s3n3n1s": {"value": -1.2172956426538186}, "s0s2s1s3s2s3s2s3n3n3n1n": {"value": 4.6896193812393996}, "s0s2s1s3s2s2s3s2s3s3s0s": {"value": 3.4082474175051987}, "s0s2s1s2s2s2s3s3s3s2n0n": {"value": -7.1320835621596927}, "s0s2s1s2s3n3n3n3n3n3n0n": {"value": 0.54191463116342831}, "s0s2s1s2s2s3s3s2s3s2n0s": {"value": -1.5227852446349239}}
{"s0s2s1s2s3s2s3s3s2s3s2s": {"value": 1.3903436072738038}, "s0s2s1s3s2s3s3s3s3s2s2s": {"value": 0.3014149373257286}, "s0s2s1s2s3s2s2s2s2s3s2n": {"value": -0.82905710163411861}, "s0s2s1s3s3s3s2n2n2n2n0n": {"value": -1.9170305674378623}, "s0s2s1s2s3s3s3s2s2s3n3n": {"value": 5.4759054389022257}, "s0s2s1s3s3s3s3s3s2n2n0s": {"value": -1.4805639661758399}, "s0s2s1s2s2s3s2s3s2s2s3s": {"value": -3.1246728467918303}, "s0s2s1s2s2s2s3s2s2s2s3n": {"value": -13.660923408067047}, "s0s2s1s3s2s3s2s2s3s2n2n": {"value": 10.4309007741433}, "s0s2s1s3s2s2s2s3s2s3s3s": {"value": 4.8831349701274824}}
...
{"s0s2s1s3s3s2s3s2s3s2s3n": {"value": -2.1069343026357341}, "s0s2s1s3s3s3s2s3s3s2s3s": {"value": -1.4873104336270151}}
```


En principe on se sert toujours du triple égal en JS, question de perf et de compréhension, vu qu'avec un simple double égal le test passera si `selectedQuestion` vaut 0, "", undefined ou null ;).

En soit, c'est absolument pas grave mais c'est un bon tips et une bonne habitude à prendre :surfer: !


Went back to List and it also works fine. What the heck is going on. What did I do to fix this? lol


A ok j'imaginais pas que ça se ferait comme ça, cool j'ai appris un truc


Not part of this commit, but lets at least keep all the rocket conf under a single /etc directory if there is going to be something in /etc (/etc/rkt/net.conf.d)


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3160
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3153
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3155
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3145
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3145
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3148
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3141
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3135
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2813
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2811
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1649
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1642


fast-forwarding master to auto = 8903c21d


oops, e8d756c1b651039f1d529a7173c764bab3dbdbec should fix it.


Most of the failing queries we've seen seem to work as expected now. Only my queries that use ```.back()``` inside of ```.union()``` still fail, but I guess you're aware of that issue.


Thanks.


別 amend


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1882](http://teamcity.monogame.net/viewLog.html?buildId=4403&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Verified fixed & working :)


Having either of these in the `keydown` handler prevents the `keypress` event and that's the only way we have access to the unicode (based on [this](http://stackoverflow.com/questions/1444477/keycode-and-charcode/1445228#1445228)). What was the use case for these? We may have to implement them some other way.


Make a note in the comments, please, that this only works for non-integer, non-object dtypes.


Style nit: avoid if without { }.

Using brackets would also mean you could put the rest on another line and probably avoid splitting that string.


Would love an explicit raise here on integer or object dtype.


filepath is more appropriate here, no?


No idea of the reason why the indent looks wrong, I'll make sure it is correct before check in./


My reading of https://source.android.com/source/build-numbers.html is that 4.1.2_r1 corresponds to API 16 not 15, and that this should be 4.0.4_r2.1 or something similar. Is this a cut-and-paste error, or is there a reason that it has been set this way?

Also, if there is a good reason why it is set to 4.1.2_r1, an explanatory comment in the build file might prevent someone "helpful" like me trying to fix it and running into problems. :smile:


on Debian, i believe the standard shell for "non-interactive" users is usually setup to /bin/false.
(postfix, messagebus, and others are setup that way).


`dependency_result` is only used at this point so it could have been scraped and the method call be used instead. Not sure if you intentionally did this or just miss it.


school pride


Add me to the commit list for this repo


WHAT DID I DO?


try


Ideally we would have an overlay system similar to systemd's and like we are doing for the keystore - https://github.com/coreos/rocket/blob/master/pkg/keystore/keystore.go#L56


Best writing app on AppStore.


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Seems reasonable. It's a subset of what npm does (which makes files readable too) but if we have to do that we'll find out later I guess...


r=Manishearth


I think I overwrote this change in my latest edit since I switched everything to `em` units. Doing 200% now makes everything look abnormally large to me. Feel free to update it again so that it looks good.


I did more testing and it turns out it's something in your last commit, even though there doesn't seem to be anything applicable in there.


ok


saw approval from Manishearth
at https://github.com/gilles-leblanc/servo/commit/9fe39951b07c2bcb0aebf7909719b150dcf5c973


merging gilles-leblanc/servo/issue-4556 = 9fe39951 into auto


gilles-leblanc/servo/issue-4556 = 9fe39951 merged ok, testing candidate = 9fd675c2


I approve!


This actually introduces an error if 'md' is not a boolean, which is the case when knit2html doesn't throw an error. I modified it back in c260ad74cd3b852895e081bcb924f163e486a71d.


this line *would* encode info.purged_snaps.  because we swap it into purged_snaps temporarily, we don't encode the big value there.  we want this key to be nice and small.


Wait, does that mean they are not even broken?


first


Be careful using braced initialization, it can make Visual Studio compiler bomb. Also, this might cause link errors in MSVC. Not sure though.


This commit changes:
- Remove duplicate auth for "file" child (Yes, the auth implemented there was either duplicate to the one already done by httpserver, contradicting auth = no in settings because it didn't honor that setting or doing nothing if the file met the criteria in file.py, but auth was still required by httpserver)

- Make auth yes or no independent settings for HTTP and HTTPS
I'm not actually encouraging to open OpenWebif to the outside, but now you can have authless http locally and https with auth for the outside.

TODO:
Obviously the INTENTION of all those exception handling in file.py was to allow download of some files without login even with auth enabled.
However this did not work at all and needs to be implemented differently if still required.


saw approval from alexcrichton
at https://github.com/alexcrichton/rust/commit/1841302976b91a69df60234744a263724bff92f1


merging alexcrichton/rust/rollup = 18413029 into auto


status: {"merge_sha": "b35ceb4fc78428925a149993bc9ca60b579c31e3"}


alexcrichton/rust/rollup = 18413029 merged ok, testing candidate = b35ceb4f


I'm stacked as well, have to give up !! And i own you a beer as it's hard issue.
Asked the question here:
http://stackoverflow.com/questions/27975828/pdo-adds-the-apostrophe-to-the-mysql-query
Good night ..


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1882](http://teamcity.monogame.net/viewLog.html?buildId=4403&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 359, ignored: 6 Build time: 00:15:41


 - __warning__: [include/chaiscript/dispatchkit/type_conversions.hpp:226](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/include/chaiscript/dispatchkit/type_conversions.hpp#L226) Member variable 'Type_Conversions::m_mutex' is not initialized in the constructor. (uninitMemberVar)
 - __style__: [include/chaiscript/dispatchkit/boxed_number.hpp:570](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/include/chaiscript/dispatchkit/boxed_number.hpp#L570) 'Boxed_Number::operator=' should return 'Boxed_Number &'. (operatorEq)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/8dc2c55acd7473124a66f38970ddd9591baa56a3/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


This should read
`BEAST_DEFINE_TESTSUITE (AmendmentTable, app, ripple);`

"ripple_app" is a legacy identifier from a few code reorganizations back.


Fixes #19.


`fail()` or `fail("didn't throw")`


`pass()`


Probably should have imported these lines from a universal file, cause it was a pain to remove
Anyways, this resolves #98


VERY cool stuff i might add


you gotta be careful with braced initialization this looks borderline ICE material


How can substr($var, 0, 4) ever == 'vip' (a 3-letter string)?


They're broken in your latest release.


Hello


But ya, you can close this PR. I'd add the two extension helpers in the POM, though.


oh, i see , thanks


No, when @ry4n1m3 and I did the initial cut of version specific shadows, we must have thought we supported API 15, when in fact, we didn't. We should remove that API target from the build files.


For some reason this test had "not" but the new code does not have "not". Maybe the "not" (!) was actually a bug? Or maybe the new code should be using a "!" test like:
if (!(substr($gre['if'], 0, 4) == '_vip') || (substr($gre['if'], 0, 5) == '_lloc')))


:+1:

heroku専用かと思ってたら想像以上に汎用的だったw


We have the anser !!!
I am going to bad you can reapir it now ...


Similar here - the "not" of the test is removed in the new code.


Quick google search for IP_OFFMASK gives some headers having 0x1ff and some have 0x3ff, so just defining it is probably not such a good idea?


r+ rollup

Thanks!


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why did you end up doing this? The loop never loops through anything this way... not sure why but the original `async.each(Object.keys(models), function(model, done) {}` worked for me


vfjvhk


you can do import SynchronizedDynamicNode.DELETED_MARKER to not have to write the whole thing again and again, e.g., see class GraphUtils has import GraphUtils._


I am not sure what the right incantation is, but if this method is copied from `ManyToManyField`, can't you do something like `__init__ = ManyToManyField.__init__` to avoid the repetition?


did you mean to use a non arrow function here?


and here?


Good idea.  I considered that, and worried it was somehow dangerous or bad style, but I agree it looks better with the import.


update_sqlite_coverage (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1588 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.87%25-yellow.svg)


and bugfix that prevents it from filtering cancer


all tests pass:
success: http://build.servo.org/builders/linux1/builds/544
success: http://build.servo.org/builders/linux2/builds/542
success: http://build.servo.org/builders/android/builds/580
success: http://build.servo.org/builders/mac1/builds/761
success: http://build.servo.org/builders/mac2/builds/761


Why is 232 too large, but 232 - 1 fine? (I suppose there's always going to be some relatively arbitrary upper limit.)


I agree, that's worse than what you have now, but that's not what I was suggesting.  Regardless,  I experimented some with Intern and ES6 promises now, and they seem to work fine.   This runs w/out an error:

```js
promise: function () {
	return new Promise(function (resolve, reject) {
		setTimeout(resolve, 300);
	});
},
```

and this throws an error which intern catches:

```js
promise: function () {
	return new Promise(function (resolve, reject) {
		setTimeout(function () {
			reject(new Error("hello world"));
		}, 300);
	});
},
```

I tried more complex testcases too, which work as they should:

```js
promiseAssertWorks: function () {
	return new Promise(function (resolve, reject) {
		setTimeout(resolve, 300);
	}).then(function () {
			assert.strictEqual(1, 1, "meant to [ass");
		});
},

promiseAssertFail: function () {
	return new Promise(function (resolve, reject) {
		setTimeout(resolve, 300);
	}).then(function () {
			assert.strictEqual(1, 2, "meant to fail");
		});
},
```

Can you try again, without calling when()?   Maybe the problem is just that you need to use Intern 2.2 instead of 2.1.  It's backwards compatible so all you need to do is change package.json.


@megawac What's this for?


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Does this help/fix #9572? Also been seeing OSX Travis time out on the parallel test.


Why do you still add the edge count when it hasn't changed?


Updated the list in customelements.io according to these comments and some other things.

https://github.com/webcomponents/customelements.io/commit/120c66ca0da46a90e187d2838cb80fdc5054a35e
https://github.com/webcomponents/customelements.io/commit/5d2cc9a2195cf8b04f221907a7bd8cfddc8b9e44


fast-forwarding master to auto = 9fd675c2


@thejameskyle, it gives users an example of how to pass options to these tools from the package.json. For instance, my colleague wanted to whitelist helpers for handlebars


I realize you didn't write this, but I think this is a nicer implementation:

```Lua
if value == nil then
	return nil
end

local p = {}
p.x, p.y, p.z = string.match(value, "^([%d.-]+)[, ] *([%d.-]+)[, ] *([%d.-]+)$")

if not p.x or not p.y or not p.z then
	p.x, p.y, p.z = string.match(value, "^%( *([%d.-]+)[, ] *([%d.-]+)[, ] *([%d.-]+) *%)$"))
end

if not p.x or not p.y or not p.z then
	return nil
end

p.x = tonumber(p.x)
p.y = tonumber(p.y)
p.z = tonumber(p.z)
return p
```
You might even be able to simplify the ifs to just `if not p.x then`.


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Because you can't do partial updates on a document. So even if only the visibility changes you still need to write the old edge counts.


You're right about monads making a superb "query" framework. I hadn't fully realized how powerful that is! With a combination of Applicative and Monad, you could even have automatic palatalization of queries (like [Haxl](https://github.com/facebook/Haxl); in fact, a Haxl front-end for this database might be something to look into).

I have seen *some* measure of standardization of graph database querying via SPARQL and such. I don't know much about graph databases, but RDF seems to crop up a lot. To make this database a swap-in replacement of other graph databases, my guess is that is the direction to go.

I can't wait for an alpha release! If you're interested in Haxl integration, I'd be willing to start looking into it. Regardless, I'll start doing some work with this library and contribute when things crop up.


update_sqlite_coverage (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.73%25-red.svg)


fix for #6


PPS: And it also simplifies _showView(), instead of:

```js
_showView: function (p, subEvent, deferred) {
	p.show(subEvent.dest, subEvent).then(function (value) {
		deferred.resolve(value);
		return value;
	});
}
```

it becomes just:

```js
_showView: function (p, subEvent, deferred) {
	return p.show(subEvent.dest, subEvent);
}
```

Now, it seems like that whole method is unnecessary as you can just inline the code.


disableHAMforQSS (tsnouidui) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.88%25-red.svg)


cool!


Could we technically do an update on the parent doc? I assume visibility and edge count are both stored values. Visibility is used in a filter and edge count is used for boosting. Are there other things we index on the parent doc that aren't stored?


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@jayvin What about `MCEmbedFormBody` or `MCEmbedFormAside`? Maybe just `MCEmbedForm`??


AddMoreWarningFlags (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.68: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The push was not a mistake.  Not doing a git checkout in the branch was
my error.


The comment is kinda of a lie now =)


It should be workable enough for what i need. Thanks for the help.


(forgot to add)

fixes #6


Hahaha I didn't think of that. Good point!


with this change new client don't receive focus

or smth should be changed in the rc.lua to avoid that?


This was the problem that made the app crash, wow


I like the new ingots but what about the gold and iron in the vanilla pack?


No tests.


This needs tests.


Hi @scwf

It seems there is some issues in ParallelizedBulkLoadIntoTableCommand.
When I only revert this patch, all connection refused warnings will disappear.
May you check it?


The issue here seems to be that while running rustdoc for the util module, which uses rust-layers, rustc tries to link using -lazure (in addition to using the libazure rlib directly). Since there is no system libazure library it fails. Oddly enough, this only happens during rustdoc and building Servo works perfectly. This problem has cropped up now, because rust-layers now uses azure.


I've actually applied these changes through another PR so I think we can close this bad boy.


QED.  I'd told people here that you'd say that.  I'd been holding back
these commits until I had time to deal with the graphics files to prevent
this remark!  It was a struggle trying locate graphics with inconsistent
names, find the missing ones or choosing the right one from a selection
that Holly left behind.  Be my guest if you want to join in the cookbook
fun.  There's still a fair bit to do.


If somebody could rebase this into the new MarkDown format I'd merge it =]
No idea why this PR was waiting around for so long


Removed all references to ProjectilesPerOnFire - This is a dead value remaining from BETA supcom and is not used or seen anywhere except as a remnant in the blueprints. MuzzleSalvoSize fulfils the role it was intended for.


@deoxxa if you don't want to skip callbacks, you should not use `UpdateColumn` but `Update`


this makes update whole technique whatever ui change we do, like lightspeed change.
(cause flickering here)


This change loses a bit from the existing text.  It may not be obvious what the practical result of not providing Mouse metaclasses is.


Does it solve some real case? Can I see it?


A suggestion: you should fix it like this - https://github.com/malsup/cycle2/issues/240#issuecomment-70231459 :)


@LongMan :+1:


Set this as arm64_getdev may not in all failure cases.


Oh OK then.
I do not use the module in a long running process, so never spotted that problem.
Will try to find a solution which avoids too much modifications in my existing scripts :)


- DLL of AsyncProcess is used from AsyncProcessService.
- However, AsyncProcessService do not refer to the DLL of AsyncProcess.
- This is because, AsyncProcessService calls the DLL of B/D layer of AsyncProcess by late bound using the communication control function.
- DLL of AsyncProcess of B · D layer, corresponding to the user program on the specifications of AsyncProcessService.
- This DLL is located in the "current directory" of AsyncProcessService after the build by build bat.


Comments from Ed in 9e9b1d8ef8060a4c64461a3d78fa7c00ce8e6ae6 on if this comment is needed


emaste:
```
FWIW GCC 5 uses 67 as FIRST_PSEUDO_REGISTER
```


Fixed


It makes the following plugin work again with git master: https://github.com/posteo/show_pgp_mime
pgp/mime messages only have one single part which doesn't have a mime_id assigned.


Why rotate speed is depend on pTemp pointer?
It is very bad. And it is conversion from pointer to int, so client does not compile on 64 bit systems.


I'd propose to move the "have mesa-dri as default after installing nvida and radeon drivers" bit to the "cleaner"-script.


Even simpler:
```javascript
module.exports = mixinN(2);
```
However, that would make mixinN.js an internal function, which would then make curryN an internal function. That'd mean I'd have to make a mixinN and a curryN facade, as well as updating the references in mixin.js and curry.js and anything else that uses curryN... I think? Ain't nobody got time for that!


Not working anymore shadow static (use the shadow, but don't compute them, keep last compute.) Was aimed at allowing high level control (as in a user app where it knows when no update needed because no anim/input)
there's two different enable:
- shadow on/off (done using the switch between a basic node and a shadowedNode)
- shadow update on/off  (was done using that flag)


There was further clarification on the history of the arm64 headers in 2de5c30b6d10dd234a22c0005e5bf25808c6fdbe


emaste:
```
I think we had ARM64TODO elsewhere.
```


@mbertheau, Like this huh:
![seedfure](https://cloud.githubusercontent.com/assets/958404/5774548/c740d4dc-9d77-11e4-9778-0ab27989d612.PNG)


Ok thanks for your feedback, I must have a script or something that is messing around then. I knew I should have tried with a clean install first..


I haven't had time to review the history of InputDeviceButtonControl::reset(), but the logic didn't look right: _isDown was only set to false when it already was false. Maybe a **!** has gone missing at some point.


@dkayiwa When i added to this class 'extends BaseContextSensitiveTest', then this test failed without this line.
upgradeTestUtil.upgrade(); throws that not found "order_entry_upgrade_settings.txt"


# **IT'S RIDICULOUS.**


@yellowled please check
![sync-heights patch](https://cloud.githubusercontent.com/assets/1105372/5774577/a67d03a4-9d6f-11e4-9f25-8067e373b3c7.png)


we can save 2 more characters by wrapping the function


For dirname


由於之前pull request發的有問題，現在重新發pull request，
依照羿介要求重新checklist


New test comment


So that the group ID of "system" files and directory becomes 0 in the app sandbox.


yes, that's what i said in the email. but it could be that is just a
generator problem that generates an useless null in the implements array.
so i put this to unblock the users pending the real investigation of the
root cause. throwing now an exception basically let them where they were
before :)

On Fri, Jan 16, 2015 at 10:52 AM, npiguet <notifications@github.com> wrote:

> This actually looks like a severe problem at runtime. It means that a
> class is attempting to extend an interface that isn't loaded. I think that
> instead of ignoring the error condition, we should instead throw an
> exception with a message that is as clear as possible.
>
> Maybe this should be
> if(!_implements[a]){
> throw "Unable to load class " + _constructor.name + ", missing
> implemented interface at index " + a;
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/st-js/st-js/commit/952c3821fba403a75b5f9f59a5206f3adeb57c58#commitcomment-9311687>
> .
>


Do you mind to release this code as 0.1.1? Because i actuall get a lot of deprecation warnings from rollbar.


I dont know


No, gobject-introspection always adds its own libdir to the search path.


Thanks for the thorough feedback about it. I'll remove the 's.


Is this a debugging artifact and can we remove this?


See  8c2c666


这里为什么要用table？


It would be great if you could also manage to statically compile the installer for all platforms.


Actually, the critic is Git itself.
Linux has an old rule "every texfile must end with newline" and Git is a proud linux citizen.


No, I don't use it for anything myself. I just noticed this problem on one of my production servers - wish I knew how to reproduce it! I'll let you know if I discover the root cause...


It's a `statement_key` introduced in https://github.com/rails/rails/commit/2ae9166d8fef242e3b0d52af0c8c79d86a80268e . I've just run into the same issue. @dplummer have you tried contacting with @RISCfuture and apply this patch?


@ddeboer @Baachi This looks funny… how could this line ever be reached ? `$item` is an array, an arrays do not have methods (I think). This must be a remain from a refactoring. The functionality behind would be interesting though. @flug was asking me how to set some field with an arbitrary value, I told him to use `getNewInstance()` for that, but I think this would have been another solution.


Tanks!


Using an array should be fine


This paragraph is no longer accurate.  namespace::autoclean can be used with Moo classes without issue.


当设置font-size:0px的时候，会造成inline-block元素和文字发生上下偏移
![image](https://cloud.githubusercontent.com/assets/2268669/5774664/38605eac-9dab-11e4-88ec-7debfbe84c71.png)


Abdullo nima gapla


Plugin doesn't work now if page has <base> tag... At least on webkit.


Right, that makes sense now. Thx for the explanation.


sorry i'm not so good in english, and i can not understand c++, only c

but where is your problem to look at the bitbang code from tim cpldcpu
https://github.com/cpldcpu/light_ws2812 it works perfekt with m328p and m1284p

with a
#if defined(__AVR_ATmega1284P__) only in the bitbang code to transfer ws2812b DATA like cpldcpu made it all my problems where done

now i think abbout leave fastLED and change to light_ws2812

but all my source code must be changed and there ist no way to use arm or other cpu


I think the idea here was to support both arrays and objects (with getters) as  values for `$item`. I think we switched to arrays only later. @Baachi Any thoughts?


I'm well aware of what this entails, but since [MRI 1.8.7 is EOL](https://www.ruby-lang.org/en/news/2014/07/01/eol-for-1-8-7-and-1-9-2/) I don't think it's appropriate to spend resources on it.

Instead I'll be creating a legacy release for anyone that makes fixes to the last 1.8.7 supported version. I'll be appending the mri187 metadata to the version releases.


Я за, вторник подходит.


Why not use bus_read_* and bus_write_* instead? They take in a struct resource and call bus_space_read and bus_space_write as appropriate.


Ah, ok :)


There is odd indentation here


And here


Yikes, I meant `NSData`. :stuck_out_tongue_closed_eyes:


I think a longer read timeout is probably appropriate: it'll be annoying if we can't make the service faster than this, but indexing is run from a queue so we can afford for it to take a while if necessary.  For a large document, we might be transferring quite a bit of data over HTTP for the request, too.


Should just be 'NavBar' (i.e. without the path)?


There should be a newline before the return


There is an extra new line here


Looks good, only minor style issues


Check *what*? Please provide more information than a screenshot that could be anything on any device in any browser on any OS. How do I reproduce this?


There might be a limit of ~10 objects, thanks to ariy.js. Need to investigate.


I suppose that would work as well. Can a statement be empty - as in no  usage within the month? In any case, both should do the trick


А может лучше переделать как-нибудь?


@LongMan делай пул реквест)


Problem is that 0.28.0 is slightly broken, so it is actually reported as broken and I need to do it, otherwise travis will fail. I do this changes manually and checked if it is OK to do it.


Might help (all SSL errors, error code and error string) : http://doc.qt.io/qt-5/qsslerror.html


This should be pcb_elr.


Maybe need to list the name and date of previous polls (e.g. there might be a lot of "Friday Lunch" polls)?


Looks good


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1890](http://teamcity.monogame.net/viewLog.html?buildId=4422&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Isn't it already set into __avcodec_alloc_context3__ ?


Probably makes sense. I usually include all system headers before the local ones. But from bluetoothd's perspective, fdio/loop.h is a system header.


just noticed this, thank to @raynra
the check here sounds ridiculous, if unit __cannot be knocked because of GVG/BG map__, so don't stop them. xD


Yes, it's in patch #3.


This should be a ```const char *```


shouldn't this be passed a CPData?


No wiem, jedna rzecz zmieniłem, ale zapomniałem o niej :p
16 sty 2015 10:48 "Lukasz Biedak" <notifications@github.com> napisał(a):

> Już wiesz:P
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mbiedak/BAZY/commit/c4dfc06e125635ef44c4d8fbe42b47cea8d173d5#commitcomment-9311630>
> .
>


a arduino working device based on m1284p?

ther are many in the internet and with use breadboard too

https://www.tindie.com/products/YT2095/atmel-atmega-1284p-board-128k-arduino-sanguino-rep-rap-robot-etc/
http://nathan.chantrell.net/20120811/using-the-atmega1284p-with-the-arduino-ide-wiz820io/
http://www.geeky-gadgets.com/mini-duino-open-source-ardunio-board-based-on-atmega-1284p-21-08-2014/
http://blog.bbp-online.com/sarduino-at1284p-bootloader/
http://forum.arduino.cc/index.php?topic=64612.30

i have buy 6 pcb from osh park an build it by my own
https://github.com/JChristensen/mini1284

![m1284p_m328p](https://cloud.githubusercontent.com/assets/10545958/5774811/6248ad20-9d72-11e4-8082-5c11faf5c32e.jpg)


two issues, the original file was designed to work in node or the browser where here we put the switch in the package.json, I then simplified the setup to export one of 2 functions instead of checking each time you called it, i l also removed  superfluous IEFE.


Promi juré, je ne touche plus à rien jusqu'à mardi prochain ;-)
Completeness, kinding, je te laisse faire ce que tu veux.

specialize je l'avais trouvé en TP de coq avec Werner puis oublié. Ça m'est
revenu soudainement.


ok, I guess we can tune this a bit. Note that I *think* this is not the time to read the whole data but rather the longest time the library will block when fetching bytes, ie. as long as data is flowing the overall transfer can take longer than 1 second. Would be interested to know if anyone can confirm/refute :-) I couldn't be sure from the docs http://ruby-doc.org/stdlib-2.2.0/libdoc/net/http/rdoc/Net/HTTP.html#read_timeout


pkill will exit with 1 if no process matched, which will fail the script (its -e). better add || : here


rm -f (just in case)


aser awer aw


sorry, thought that was obvious... upload an mage with 100x60 **or** set max width to 100 in image config and use the Resize before Upload set to true. Then look into ML and click info. (This was my my first ML image into this testblog)


Gar keinen.
RANGED_ATTACK_BONUS und CLOSE_COMBAT_ATTACK_BONUS sind neu, überall 0 und können aber in den building.xml's eingestellt werden, genau wie der Verteidigungsbonus. Damit sollte es genug Stellschrauben für ein gutes balancing der Burgen geben.
Bei meinen Tests ist mir aufgefallen, das es halt unlogisch ist das ein Kämpfter mit einer Kriegsaxt 20% besser von ein Pfeil getroffen wird als der Freund mit gleichem Talentwert und einer Hellebarde, sowie das Gebäude unter Umständen (im Moment bei E3+E4 sogar alle durch den Bug) einen Bonus für die angreifenden Fernkämpfer geben. So was ist für den Spieler praktisch nicht zu entdecken.


ok


Can you convert ceph_con_init() to ceph_con_init_with_options() for mon and mds clients as well?


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3159
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3166
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3161
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3151
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3151
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3154
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3147
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3141
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2818
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1656


Cool. Actually, thinking about it again, I think both formulations would be correct. "The game's replay" would really insist on the fact that it's the replay of this very game, while "the game replay" is more generic and simply tells that this "replay" is the replay of a game. But anyway, the current formulation is fine IMO :-)


That's a massive list of commits. You've been busy :wink:


Could you add two spaces to make this be consistent with the rest of the code?


Could you add one space before the `{` to make this be consistent with the rest of the code?


I personally find this not nice to read. I'd suggest to use a case / esac statement instead.


Thanks. Could you provide the information asked for in the [CONTRIBUTING](CONTRIBUTING.md) guide, as well as an exact code example, gist, or failing spec, so that we can reproduce your experience?


Could you add a space before the `{` to make this be consistent with the rest of the code?


Should this not be `tries[0]`?


You're right, thanks for noticing, I will fix it.


Dis was wrong in DefaultPoolingHttpClient:

ry {
  final HttpResponse response = execute(httpGet);
  if (response.getEntity() == null) {
    httpGet.releaseConnection();
    throw new IOException("No response for URI " + httpGet.getURI());
  }
  return readContent(response, charset);
} catch (IOException ioe) {
  httpGet.releaseConnection();
  throw ioe;
}

Reason:
If response entiy is null, then the http connection will be released and an IO error will be thrown,
which will then be recatched (4 lines below) and the connection will be released again which may caus an error. The usage of "relese connection in finaly case (after excepction has been catched)" will resulting in releasing http connection for every http get.
So I just dropped the first httpGet.releaseConnection() method call.

The rest ist just finalizing variables cause within APIs it makes sens to signal the API user, that the value will not be changed ... that's all


Hey! Do you mind commenting on what exactly you needed these commands for? They sound like useful additions to the original version.


Both work for me in Chrome.

Judging from your screen shot I would say that for some reason, the equal heights JS was not fired there. That's why the container (and thus, the inner container, which determines the height of the overlay) have not been resized.


recived 8 errors, mainly from simple missing of ';' or a couple of illegal expressions as shown nelow

frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:282: error: illegal start of expression
    public void pause() {
    ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:282: error: illegal start of expression
    public void pause() {
           ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:282: error: ';' expected
    public void pause() {
                     ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:286: error: illegal start of expression
    public void resume() {
    ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:286: error: illegal start of expression
    public void resume() {
           ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:286: error: ';' expected
    public void resume() {
                      ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:290: error: illegal start of expression
    private final class H extends Handler {
    ^
frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/CommandQueue.java:388: error: reached end of file while parsing
}
 ^
8 errors


Hi, could you explain how this suppose to fix anything? I am the fix which relay on commenting anything in the code does not sounds like a good approach. Please explain what is the problem and we will try to figure out better solution.

Thanks for contribution!


Thanks @ethanyoung. Could you provide the information mentioned in the [CONTRIBUTING](https://github.com/activerecord-hackery/ransack/blob/master/CONTRIBUTING.md) guide so that we can reproduce your experience?


Is not better use null or NaN?


same here


@Joshndroid

} missing after string 280 in CommandQueue.java


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1890](http://teamcity.monogame.net/viewLog.html?buildId=4422&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 367, ignored: 6 Build time: 00:15:23


Could you explain why did you removed `rake` from `gemspec` and added it in `Gemfile`?


@wilaw,
I think we should avoid using global variables. I propose the following:
* Move MANIFEST_TYPE const into Capabilities.js. E.g. like this:
```
MediaPlayer.utils.Capabilities.supportedManifestTypes = {
	dashXML: "application/dash+xml"
}
```

* `aPlayers` could be moved from the global context and made a local var in `createDashPlayer `
* Make `createDashPlayer/createDashPlayers` a 'static' method of MediaPlayer:

	```
	MediaPlayer.createDashPlayer = function(video) {
		//implementation
	}
	```


Looks good


Why not use ```bus_read_##len(sc->gic_its_res, reg);``` here.


And ```bus_write_##len`` here


Actually the issue was not the single quote, but the small width defined for the area.
I replaced ```{0,141}``` with ```{0,200}``` and now I see the whole text. Maybe you could center the replay checkbox too?


If we use bus_read an bus_write these can be removed


this logic doesn't belong to controller.


saw approval from alexcrichton
at https://github.com/sfackler/rust/commit/5639f78e816822dd82ec25c5bed72670e05538e6


merging sfackler/rust/wait_timeout = 5639f78e into auto


status: {"merge_sha": "167c5ee29b07fdc2b63624c51eb8785ac14270b9"}


sfackler/rust/wait_timeout = 5639f78e merged ok, testing candidate = 167c5ee2


True. I left it on the left on purpose as i thought it looked better but if you think it's better centered, I can easily change that :).


It feels like the people reading this who are most in need of explanation will be people who've never uploaded public body information before - usually these will be people with a new Alaveteli site. I wonder in that case, if it would be worthwhile making a few structural changes here to emphasise that case, rather than the case where you're updating existing public bodies. I guess what I would suggest is:
* Title from 'Editing and uploading public body email addresses' to 'Uploading and editing public body email addresses'
* First para change:

        You can edit the email address of a public body by navigating to it in the admin interface (go to
        Authorities, find the body you want to update, and click on edit). But it’s also possible to edit multiple
        public bodies at the same time by uploading a file containing the data in comma-separated values
        (CSV) format.

to something like

        You can create a new public authority by using the 'New Public Authority' button in the admin
        interface 'Authorities' section. One an authority is created, you can update its email address or other
        details by navigating to it in the admin interface (go to Authorities, find the body you
        want to update, and click on edit). However you can also create or edit multiple bodies at the same
        time by uploading a file containing the data in comma-separated values (CSV) format.

* Perhaps move the sentence

        To use the values in the the spreadsheet to update the bodies on your site, export (“save as”) the
        spreadsheet as a CSV file. This is the file you can upload.

to the end of the section, and flesh it out a bit:

        To use a spreadsheet to update the details of authorities that already existing in Alaveteli, first export
        a spreadsheet of the current details using the 'List of all authorities (CSV)' link in the 'View
        authorities' section of the main (not admin) interface. You can then make changes to this file and
        upload it as described above. Note that you will need to remove some columns that are not
        accepted by the import feature, and that the exported spreadsheet does not contain a
        'request_email' column by default. If you want to update email addresses, you should add a column
        with the heading 'request_email' and fill in a new email address for any authority you want to update.
        Authorities with blank values in any column will keep their existing value for that attribute.


Seems reasonable. Can you add unit tests please (P6) as discussed in [1]? An update to the release notes is also welcome (P7).

[1] https://github.com/qos-ch/logback/blob/master/CONTRIBUTING.md


I think `short_name-es` here should be `short_name.es` ?


Aclaración: reescribo el archivo entero de el mismo archivo de este repositorio porque tengo demasiadas modificaciones en el mio, y no pisar el trabajo de mis compañeros


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1891](http://teamcity.monogame.net/viewLog.html?buildId=4424&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


you will get notices if the entityName is invalid. You should render an error page instead


the status code should probably be a 404 here, not a 200


Could you sleep here? I would thing so allowing you to remove M_NOWAIT, and the NULL check below.


should not be a 200 status code either


Advanced Multi Purpose round (AMP). Basically a combination/programmable HEAT/HE-FRAG round.
Designed to replace the HEAT, MPAT, HE, and Canister rounds.


the handling of responses returned from initialize is missing


merge 囉
by 范耿誌


That breaks all hybrid applications which are relying on ORM + ODM (mongodb, etc ). It is not issue with ORM itself but leads to dependency hell with Composer


Yes I remember something like that, I'm going to remove it from the commit.


you should also validate against invalid sort directions to avoid issues


What code assumes this?


you should use ``$request->query->get()`` rather than ``$request->get()`` when the goal is to get it from the query string


![image](https://cloud.githubusercontent.com/assets/5309021/5775043/d35f9432-9daf-11e4-8530-477a767c4179.png)

add 4 line code is this error! thx!!


@cristianomatos

https://github.com/crdroidandroid/android_frameworks_base/commit/e40ebadb2baf4550d9c48f155ef64194ea02e2a9#diff-861aa855219bd25761dc6f44dfb97937R862


Could we sleep here? If so why do we need M_NOWAIT?


no need for ``else`` here. the ``if`` returns


Its the same in Chrome.
You wont get this, if you have any images in ML which have a height >= info box height, though.


missing array typehints


you need to validate


send data


These methods would be a bit more flexible if they could accept a context and a source as parameters:
```
createDashPlayer = function(video, context, source) {
    var player, sources = video.querySelectorAll("source");
    for (var j = 0; j < sources.length; j++) {
        source = source || sources[j];
        context = context || new Dash.di.DashContext();
        ...
```


These two lines could be written as ```npages = howmany(tmp, PAGE_SIZE);```


Also, is it possible for tmp to be zero?


Shouldn't be here!


Nice :)


makes sense, will merge this once all your changes are here


These changes are necessary since your project isn't laid out in the modern way. Then you can compile using `./gradlew buildNative` for example.


Ah, of course. Because the equal height script uses the height of the largest image container to set all image container heights.

There is not much we can do about this, though. Yes, we could set a min-height using CSS, but that would just be an arbitrary number …


Yup.


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3152
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3167
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3160
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3162
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3152
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3155
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3148
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3142
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2821
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2819
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1657
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1649


again, same question why here if we have it in gemspec?


This looks odd, the only value of page_size we can set is 4k. Are you planning on having the page size be run-time adjustable?


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 20](http://192.168.44.2:8111/viewLog.html?buildId=81&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) is now running


To avoid calling an hidden find() call again and again in a std::map here, I would use a reference, something like:
```c++
std::map<int, std::vector<Tile*>> tilesWithinSightRadiusWork;
std::vector<Tile*>& tilesOnXCoords = tilesWithinSightRadiusWork[tile->getX()];
for(Tile* tile : tilesWithinSightRadius)
{
    tilesOnXCoords.push_back(tile);
}
```


Will be great if you could add a note to README about that. To make sure that people will know about that feature.


How would first ever be false? It's local to this function.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1891](http://teamcity.monogame.net/viewLog.html?buildId=4424&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 366, ignored: 6 Build time: 00:11:14
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.Visual.SpriteBatchTest.Draw_with_source_and_dest_rect(30,30,30,50): Test(s) failed. Expected 1 frame comparison result(s), but found 0
   at MonoGame.Tests.Visual.VisualTestFixtureBase.AssertFrameComparisonPassed(IEnumerable`1 results, Single similarity, Int32 expectedCount)
   at MonoGame.Tests.Visual.VisualTestFixtureBase.AssertFrameComparisonPassed(Single similarity, Int32 expectedCount)

```


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1892](http://teamcity.monogame.net/viewLog.html?buildId=4426&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Check out core/FileSerializer for this (we have the readStringFromFile function there). Those functions handle some edge cases especially around Windows paths with non-ascii characters so we should always use them if we can.


Absolutely true. Changed


Also here


There is another M_NOWAIT here, is it needed?


Cool :) Looks faster even when reading it.


Remove linespace between docstring and function


Formatting is off, description is confusing.


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=6417c85ce47e4f238aac96b08fa3dab3
 plone-5.0-python-2.7 [FAILURE]


Since you have a test environment, can you check if 5fdb253448d18212577a834abe77c8151b2431c4 make the overlay no longer overflow the container?


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 20](http://192.168.44.2:8111/viewLog.html?buildId=81&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) outcome was **FAILURE**
Summary: Tests passed: 12; exit code 1 (new) Build time: 00:04:39


I suppose the plugin should modify 'parts' and 'mime_parts' not the 'body', but let's keep it for now.


Small request:
Could you explain the RoomAffinity section in this file header?


test


I think this it


Not sure where these are heading, but the FileSerializer function include the ability to get called back for each line read in the readCollectionFromFile functions (and it will take care of normalizing CR/LF issues) so you could create a custom line reader that would get the file and do the counting in one shot. Note however this still might not be as efficient as reading in a single blast then doing the count in memory.


why do we need trim_text here for email and not in the new uses of web/site-name.txt ?

Is this just to remove trailing newline?  In which case clearer to use chomp here?


Thanks for this. I had problems upgrading to Rails 4.2.0 and this commit fixes it. :+1:


According to PEP-8 :
- imports should be ordered by alphabetical order
- external libs imports (like this one) should come after system libs imports


- it's really a bad practice to catch every exception (when you don't raise them just after). You must specify here the exception we're attending to receive
- Redmine doesn't raise any exception at this point, but connection exceptions are raised by Redmine `auth()` function, so it's no use to surround this block with a try/catch


Good idea to use getpass, I didn't knew it


Hi Fernando, thanks for contributing.
The possibility of auth by password is a missing feature.
But I don't think it's a good idea to "wait" for a auth exception from Redmine for asking user for password. What happens if Redmine instance is not accessible ?
I'd prefer to add a key to config file, something like :

`auth-type: password   # valid values sare : 'passord', 'api_key'`

Do you feel confortable enougth with code to implement that ? If not, you can open a bug and I'll do it quickly.

Thanks again for contributing


the search query needs to escape chars which have a special meaning in a LIKE context (you can use ``$em->getConnection()->getDatabasePlatform()->getWildcards()`` to get the list of wildcard chars for the platform rather than hardcoding it)


do we really need both?


Christophe, thanks for reviewing this first import. I've created lots of issues based on your comments and I will create more soon. Thanks.


use explicit modifier here


use std::endl rather than \n


given that you don't fetch join a toMany collection in your query, you should pass ``false`` in the second argument to allow a faster pagination


Ryan, yes, that's right!


This failure appears unrelated to the change.


Should this be if index >= tokens_.size()   ?


saw approval from huonw
at https://github.com/apasel422/rust/commit/716effa34900781ddb201fbd50ee679a4964cb25


merging apasel422/rust/issue-16530 = 716effa3 into auto


status: {"merge_sha": "7bf85b9ced1b270db9130e86ffd64c91224af5bb"}


apasel422/rust/issue-16530 = 716effa3 merged ok, testing candidate = 7bf85b9c


do we really need cvs, golang doesn't support it.
https://github.com/golang/go/blob/master/src/cmd/go/vcs.go#L49


yes added that in and trying again ;)


yes it does hide now, but I think we should set a min-height using CSS. Imagine someone wants to stick with previous defaults 110px size...


Use explicit modifier here


Well if you prefer it left-aligned, I'm not against it. I don't have a strong opinion for this.
Anyway, the area is still a bit small, the text is now cropped in the middle of the "y" in "replay" (so it needs something like 20px more).


comments:should have a package comment, unless it's in another file for this package


comments:exported type Test should have comment or be unexported


you can omit both arguments as you pass the default values of args


Realised right after pushing this that I was using an older version of phpunit. _Current_ phpunit implements `method` on the mock class allowing the call to expects to be omitted. Will leave as is since it doesn't hurt.


all other files are root.chef in there (0640). not sure if it matters though, since the dir is 0750 root:chef..


I just rescheduled a test at LTC:
http://tests.stockfishchess.org/tests/view/54b8efe90ebc59763e075658


Does the caller need to get access to the boost::weak_ptr or would it be enough to just get a const reference (so as not to expose the storage / memory management internals and let them create additional references)


ok, thanks for checking.


Cool to see that patch done. :D
There will be quite some tests to do, but IMHO, the creature logic has earned a good step. :)


why using a DisconnectedMetadataFactory rather than the EntityManager metadata factory ?


Thx, I suggest to lift the dept < 7 limit in this case so to raise the
probability of an assert.

On Fri, Jan 16, 2015 at 10:42 AM, lucasart <notifications@github.com> wrote:

> @mcostalba <https://github.com/mcostalba>: easy. I will do a debug
> compile, and run tens of thousand of fast games. if assert fires, then sf
> will crash and cutechess-cli will stop.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lucasart/Stockfish/commit/e1bd41f972513a8bc562277a5eb817891850c844#commitcomment-9311572>
> .
>


This is wrong!


I definitely think we can use FileSerializer here (as described above)


A good cleanup. Looks straight-forward.


There is no way to determine a sensible value for that min-height that will work well for any user on any resolution. I will have to do some serious testing on that.


ok


Should this be !pParent rather than going the NULL comparison?


Ryan, I have changed 7" to 5" in the next commit (the 7" load area is too wide considering two supports), the 7" is just a typo. The current numbers hold.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1892](http://teamcity.monogame.net/viewLog.html?buildId=4426&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 367, ignored: 6 Build time: 00:15:24


you do not have to dupe the CMakeLists.txt - tinyxml2 ships this on its own and it will be used without hassle.


I changed foo_ERROR to ensure that tests was running correctly and was failing.

I remove this error to see now "real" errors


Do we need to call module_context::resolveAliasedPath here?


altering the Doctrine metadata object is a bad idea (it can break Doctrine, and it will be even worse for people using the metadata cache if the cache is saved again after you change as it would even break it for other requests). If you need a different kind of metadata, store it in your own structure (or at least clone the doctrine metadata object)


cool!


using a form and binding just to verify a CSRF token is totally overkill (and slower). You should use the CSRF layer only (Twig has a method to generate a token, and Symfony 2.6+ has a controller shortcut for the verification)


comments:should have a package comment, unless it's in another file for this package


comments:exported type Test should have comment or be unexported


It looks like a ```}``` was got dropped here.


Thx. Rusco is already working on this.


El proyecto se puede compilar con make o usando Eclipse.


Yeah, done. Sorry.


So presumably there will be some contract on this method to prevent creation of a `GameProfile` with a *real* player's UUID?


why not handling this in the Configuration class ?


AddMoreWarningFlags (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is that 'android_device_qcom_common' supposed to be 'android_device_lge_qcom-common' @ BlissDevices or is it coming from CyanogenMod repos @ 'cm-12.0'? As it is, that pig don't fly right.


Fixed #26


update node-sass to 2.0.0-beta due to install bug on linux in version 1.2.3


Also, we can not override the min-height set through JS by setting a min-height in CSS. That would only work as a non-JS fallback. Bah, this is complicated.


why disabling client-side validation ?


the ``asset()`` function already takes care of this, so you could just call it all the time


@mcostalba: I am pleased to report that the assert does indeed fire. In fact, it fired before the first game  was even completed (tc=4+0.04 concurrency=7 threads=1 hash=16). Same conditions with master, no assert in 100 games, so it can only be this one.


?
The goal is to add them in the vector corresponding to the getX value. If I do what you said, I would add all tiles in 1 vector. Maybe I didn't understand what you want to do ?


Can you add some where you mix named arguments and regular ones?


Just to clarify - this excludes them from measuring coverage, the tests are still run, right?


Regardless of that particular plugin, there might be cases where no mime_id is set but a body available. Using `get_part_body()` strictly requires a mime_id and would fail if that is empty.


This try should not be over the whole block, just the line which could die (uaParser.parse).


Damn, nice catch! And *that* is why I wanted more eyes on it lol


mixed named arguments is not possible as I think ?


(i am notspiff under cover (at work) btw)


Why doesn't win32 link to ssl and crypto?


Hopefully this solves @jonludlam's concerns for https://github.com/xapi-project/xen-api/pull/2087.


格式有问题


nice!


Должна быть пустая строка в конце файла


Not test for string type?


Fine


lol
FYI, I've made some test on calling 1000 times visibleTiles for the first creature on the 2v2 skirmish test small map and with the vector (first implementation) it took 7.87 seconds. With the map, it took 5.20 seconds. I've also tried the vector<vector> (by hardcoding the sight range for the test) and it took 5.25 seconds. So, it seems like the map implementation is the most effective.


Eh....


Just checked it work only when we preserve order of argument like:
```twig
{{- "foo"|transchoice(1, {}, domain = "custom") }}
```


ok, I will do that


last selected channel was off by a line


@alexanderdean Is this right?


> Sorry for making you change things incrementally btw :-/ I just checked and adding 20px would work fine (either 10 to the left and 10 to the right if we keep it centered, or 20 to the right if it's left-aligned, your call :-) ).

Np at all. That's the spirit in making good stuff IMHO. :) Btw, I've added a patch centering the checkbox and checking its length. Feel free to try.

> Isn't there a way to let the area size defined according to the text? We might run into problems when we implement localisation if such text areas need to be defined very accurately in pixels.

From what I saw about this already so far, people are used to make their widgets left-centered and add sufficient length to fit most language.
When they cannot, they usually obtain the sentence length in pixel and set their widget size accordingly, e.g.:
```c++
   // we create a window with a button and some translated text:
   CEGUI::window* mainWin = window_manager->createWindow(...);
   window_manager->setRoot(mainWin);
   CEGUI::utf8 buttonText = CEGUI:utf8("Translated sentence, now way too long...");
   CEGUI::PushButton* btn = window_manager->createWindow(...);
   btn->setText(buttonText);
   mainWin->addChild(btn);

   const CEGUI::Font* fnt = btn->getFont();

   float butWidth = 0.0f;

   butWidth = fnt->getTextExtent(buttonText);
   butWidth = mainWin->absoluteToRelativeX(butWidth);

   btn->setSize(CEGUI::Size( butWidth, 0.33f ));
```
Unfortunately, I have not seen yet a property to make the length auto-adapt according to the text while I'm quite sure they already thought about it. (Feel free to tell me if you see something.)
Once we start breaking our soul against l10n support, we'll have to add quite some code to reset certain widgets
length and maybe other small adaptations...


Updated, thanks!


TeamCity Ybackend :: Feodorov/ybackend [Build 58](http://192.168.30.225:8111/viewLog.html?buildId=529&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 113](http://192.168.30.225:8111/viewLog.html?buildId=530&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


Why do they all say the same thing? You should differentiate between the different position types.


much nicer!


Do you need to define a class in init.py?


Okay, so there's no case that there's a one-to-many relationship between a file and events. Trying to confirm that multiple files do not point to the same event.


Yes and it also allows to have an assert when accessing a non existing tile which will print a log before the segfault ^^


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=05f8b2e685994fb1929d7f15d0b456e4
 plone-5.0-python-2.7 [FAILURE]


TeamCity Ybackend :: Feodorov/ybackend [Build 58](http://192.168.30.225:8111/viewLog.html?buildId=529&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:01:44


I hate to cave in, but 0f2f437c8c4e7d99b2aa3b4fd20ec107b2c63d65 is probably the only solution that will work more or less.


Just out of curiosity, where/how did `lastIndexOf` fail you?


Ah, or maybe it is I who didn't read correctly. Nevermind, the code is quite correct then.


Actually my comment on the previous commit was after having testing this new patch, so this is still valid:

> Anyway, the area is still a bit small, the text is now cropped in the middle of the "y" in "replay" (so it needs something like 20px more).


2 seconds on 1000 calls sounds quite a difference already. Great to see it things being that improved. :)


@drekinov the actual issue is in the ODM, which forces using an outdated version of Doctrine Common


Yes. FYI, I've added room affinities so that most creatures will try to train. Some may try to go to the forge (troll) and some will prefer to go training but can work in the forge (human like creatures).
Now that I think about it, I've not tried to add an affinity where the creature won't go to the room even if it is the only one available (likeness=0) but it can work if dropped (efficiency > 0). But AFAIK, it should work.


Ok, I'll make the test.


gg


The use of `con rinforzino` is still open to discussion. Nevertheless it's important to reserve it ASAP.


Oh, I fixed real bugs and didn't care about "decorations", but I agree.
It's better to use the same casting rules at least in a single file.


Ah, and I've added an affinity for slime which makes it should try to go to the library (even if no active spot available) but it is too stupid to work there (likeness > 0 and efficiency = 0)


If  daemon_option("watchdog") is NULL, it'll trigger an error at cib_attrs.c: 180: update_attr_delegate():

CRM_CHECK(attr_value != NULL, return -EINVAL);

, and it'll add an nvpair without "value".

For  mcp, given: mcp/pacemaker.c: 1045: main():

    if(pcmk_locate_sbd() > 0) {
        setenv("PCMK_watchdog", "true", 1);
    } else {
        setenv("PCMK_watchdog", "false", 1);
    }

it'll always have the environment variable. But not for the legacy corosync plugin ;-)


There is no difference in position type, all the same will keep and it will show only the necessary type, on it... there is no sense to list position type :D


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 113](http://192.168.30.225:8111/viewLog.html?buildId=530&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:09:43


- About design of the error screen.
  - I'll leave the design of the error screen to you.
- About resource file of internationalization.
  - You should follow the convention.
  - You should create a "Resource" folder directly under the project file, and  place the resource file there.
default is "en" region, and add "ja-JP" region file there.


Yeah, I was going to ballpark in the DM11 for it, but that's a programmable HE round, not the same.


$field is not being sanitized, a reason I have not chosen this for a solution.


gotcha, you are right


backported in 4cf24fe565fa202ed414e9291e0aee224fa7d814


This doesn't appear to work in the common case where INTERNAL_IP4_DNS holds multiple DNS server addresses.  It generates a config file dnsmasq doesn't like which and that results in a crash loop that brings down DNS entirely.

```
Fri Jan 16 06:24:52 2015 daemon.crit dnsmasq[23250]: bad address at line 1 of /tmp/dnsmasq.d/openconnect.vpn-work
Fri Jan 16 06:24:52 2015 daemon.crit dnsmasq[23250]: FAILED to start up
Fri Jan 16 06:24:52 2015 user.emerg syslog: Instance dnsmasq::instance1 s in a crash loop 6 crashes, 0 seconds since last crash
```


Hello @notspiff (@akva2),

is removed.


You should lock the version, e.g. `'~> 3.6.0'`.


Removal on purpose?


If this check fails, result is nil and the force unwrapping of line 62 will cause a [runtime error](https://github.com/Mozharovsky/CVCalendar/issues/7)


Il me semble que ton indentation automatique a buggé à partir d'ici :P


Please see my comments on issue #121 (https://github.com/FastLED/FastLED/issues/121) that I keep asking you to use.  I will respond there.


Same goes for this one


???? Ça ne compile plus normalement si tu fais ça :P


nice


kinesis-s3-sink -> kinesis-lzo-s3-sink


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 21](http://192.168.44.2:8111/viewLog.html?buildId=83&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) is now running


TeamCity Ylab :: AleksandrFrolov/ylab [Build 69](http://192.168.30.225:8111/viewLog.html?buildId=531&buildTypeId=Ylab_AleksandrFrolovYlab&guest=1) is now running


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 21](http://192.168.44.2:8111/viewLog.html?buildId=83&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) outcome was **FAILURE**
Summary: Tests passed: 3; exit code 1 (new) Build time: 00:01:08


I dimly remember we have talked about this before. I only found this https://github.com/s9y/Serendipity/issues/73 for now, but I think there was also some other thread which was more detailed...


@mcostalba: crash testing at depth=8 (enough for aspiration windows to kick in) reveals no issue (crash or illegal move). this patch is ready for commiting IMHO.


i think that's quite unusual for proposals and I've also never seen this (I submit some at different conferences over the year)

I think we should not built features that **maybe could** be useful but nobody uses. Do you have a real use case?

If not I would remove that line and keep a stricter policy. We might also ask our users in the future if screenshots are a deal for them


This won't work when the engine is mounted. Use `skip_before_action` in the `TenantsController` instead (http://guides.rubyonrails.org/action_controller_overview.html).


Si, ça compile toujours chez moi. D'ailleurs cette ligne ne fait rien apparaître pas dans le pdf final (en tout cas chez moi). (C'est la première fois que je fais une synthèse à partir de ce git donc il est possible que je ne comprenne pas comment fonctionne le truc qui génère automatiquement l'introduction à la synthèse)


It sounds as if a comma is missing here: `Torch7 maintained by Ronan, Clément, Koray and Soumith` :)


fast-forwarding develop to borshop-integration-1006-feature/sibling-benchmark = afed87e1


The new uses do in general all trim in the templates with `-` – did I miss one?
It is mostly for trailing newline, yes, but it is important that all space is removed, not just a final one, or indeed any initial space if present, and it would be confusing if someone put two newlines in their template and then wondered why their emails broke, so I thought it best to make sure all whitespace was trimmed. The uses in the template need to remove suffix space due to punctuation, whereas prefix space is less important.


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 22](http://192.168.44.2:8111/viewLog.html?buildId=84&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) is now running


Nit: the "Rails way" is to never refer to models in views. Instead, you could wrap the form:

```
<% unless @tenants.empty? %>
  <%= form_for(@tenants) do |f| %>
  <% end %>
<% end %>
```


Pretty sure #73 is the one, but there might have been a forum or mail discussion. Dunno, don't care. :)

This is an incredibly sore topic. Rationally, square preview images with a fixed size (showing a clipped preview of the image) would be the best solution. Garvin is strongly opposed to that, which is perfectly fine because it's a valid request to want to see proper preview images, not extracts. However, if we stick with preview images that honor the aspect ratio, there is literally no way to combine this with equal heights across all resolutions, especially given the fact that these can be rotate.

This makes my head explode.


ça pose problème de mettre de l'indentation ? :dango:


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 22](http://192.168.44.2:8111/viewLog.html?buildId=84&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) outcome was **FAILURE**
Summary: Tests passed: 12; exit code 1 Build time: 00:03:03


You can remove the `AUTO_INCREMENT=4`, so it starts at zero.


isn't this exactly the same REST mapping as for createOrganizationalUnit? both are on /organizationalunits and @POST method. Or do I miss something?


TeamCity Ylab :: AleksandrFrolov/ylab [Build 69](http://192.168.30.225:8111/viewLog.html?buildId=531&buildTypeId=Ylab_AleksandrFrolovYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:10:33


ur right, went from bad to worse... using sha256 now...


![](http://i.imgur.com/UiF7KQQ.jpg)

I don't want them :(


Awesome @cphrmky !

We should avoid locking the version of `fog-core` in the providers.
If you still have a problem with the latest version of `fog-core` ask the users to lock the version of `fog-core` themselves.

I would appreciate if you can share the issues we the rest of the fog team so we can tackle them asap.

Thanks for the fast answer and fix bro! You rock!


I think that undercase looks better. The rest of the changes make sense to me.


mobile pixel ratio support


Personally I'd rather not create this local variable here ...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10080/testReport/) for this commit**


... and instead write "for ipv4 in (ipv4_intended - ipv4_existing)" here.

To me that makes the meaning of the code a bit more immediately understandable.  But I understand that YMMV.

Obviously, if you agree, the same for the 3 similar cases.


Note: 'ssh-agent' command does not seem to be working properly on OS X.

http://matt.simerson.net/news/2007/07/28/ssh-agent-and-mac-os-x


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 23](http://192.168.44.2:8111/viewLog.html?buildId=85&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) is now running


Just one minor comment.  I'll merge this anyway, and if you agree you can cover the comment in your further work later.


aww jack dont hurt evil bossy coach's feelings


The single entry switch below:
```
psz = GITS_BASER_PSZ_4K;
```


ref https://github.com/JuliaLang/julia/issues/9545#issuecomment-70244615 - backport not necessary, bug does not occur on 0.3


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Please use color variables from style guide


get_dup_buckets(self, doc) should also be taking an _id_ argument. This id is used on line 145 and line also when the method is called from line 157.


Please use color variables from style guide :)


Try this:
```
<group delimiter=": ">
  <text term="in" text-case="capitalize-first"/>
  <text variable="container-title" font-style="normal"/>
</group>
```
(For example in your version a webpage without a `container-title` would still be rendered with "in: "; in the new version with groups this will not appear.)


Same here:)


dito


we should use promise terminology so  "your promise will be **resolved**" instead of "accepted"


SELECT DISTINCT P1.IDMAR, M1.ADRMAR, M1.NOMMAR
FROM MARAIS M1,  PROPRIETAIRE PRO1, , PROPRIETE P1,
WHERE PRO1.PRENOMPRO = 'Jean'
AND PRO1.NOMPRO = 'Martin'
AND PRO1.IDPRO  = P1.IDPRO
AND P1.IDMAR = M1.IDMAR
AND M1.IDMAR IN ( SELECT M2.IDMAR
				  FROM MARAIS M2, PROPRIETE P2, PROPRIETAIRE PRO2
				  WHERE PRO2.PRENOMPRO = 'Pierre'
				  AND PRO2.NOMPRO = 'Dupont'
				  AND PRO2.IDPRO  = P2.IDPRO
				  AND P1.IDPRO = P2.IDPRO
				  AND M1.IDMAR = M2.IDMAR);


You can do that also with `border-width: 0 0 1px 0` (I assume you just want to leave the bottom border)


I've implemented Marisa-Chan's solution in commit 9f00880aa4. I've tested it with both ZNEM and ZGI, seems to be working well


I called it pcb_pc since it reflects current program position (before exception) and that is how we use that structure field. I would suggest to keep it as is.


The same as above: please use color variables:)


That would be good to know.


`<else-if>`


As written above in the comment, we assume that base page size is 4KB but this does not forbid to create 64KB base page in the future right? (For example someone would like to use 64-bit ARM to some storage solution and create custom 64KB page-based kernel. In that case ITS would also need to support different page size)


Frumoasa :*


TeamCity CI Experimen :: PHP Symfony2 project :: Symfony Project Test [Build 23](http://192.168.44.2:8111/viewLog.html?buildId=85&buildTypeId=CiExperimen_PhpSymfony2project_SymfonyProjectBuild) outcome was **FAILURE**
Summary: Tests passed: 12; exit code 1 Build time: 00:06:14


Should the try catch block be moved inside the doc.language if statement on line 744? That way we don't incur the cost of executing that code & allocating that memory unless we're certain it actually needs to be used.


`$("<span></span>")` is more idiomatic. Also, you have lots of spaces before the ;.


Can you please switch all those to single-line conditionals? Stylistic consistency is a nice plus.


Good spot, I'll fix the inconsistencies. Your command will be *accepted* and your promise will be *resolved*.


Yes.


It will be false in the second loop iteration and we will have GITS_BASER_NUM iterations .


The internal functions are either functions which are not part of the API or uncurried versions of functions which *are* part of the API. `mixinN` needn't be internal, so I like your shorter definition. :)


Careful, you're escaping text that then goes into a safe API — meaning it'll get escaped twice.


Use color variables, please :)


Seems legitimate.


Spaces around the + please.


OK


Same here. Thanks!:)


I'd prefer to explicitly chown() the file instead, rather than relying on what happens to be the gid of the executable.
But, overall, is this change really needed? Almost all the directories we create are merely placeholders in a tmpfs that will be bind-mounted over with read data, and those bind mounts are read-only, so there is no risk of allowing writes anywhere unexpected.


Indeed, we should be able to sleep here. Thanks.


Have you tested this? It probably does not insert the character.


The test was correct, it's the code that's buggy!


Hmm this is odd, what error are you getting, I use this every day without issue.

$client->send() isn't a real method of \Maknz\Slack\Client, but is caught by __call, which then calls createMessage() on $client and calls the send method so it should be doing the same thing


Should that be "1.1" instead?


I get this error in my firebug console
TypeError: s.beforeSend.call is not a function
Are you sure this is working ?
.....and there's already a bootstrap.min.js in static/scripts


отсюда текст убрали


space


I'll cherry pick this one, but use: g_value_dup_string()


A part without mime_id should be considered an error. Did you see that the plugin use body of part 2 for part "0"? This looks like a hack. Anyway, other fix for this issue is to add $mail->parts[0]->mime_id = '2'; to the plugin.


Ça compile toujours mais il manque le nom d'obo à la deuxième ligne de "Important information" :)


It should work. r=me.


Ruud, do u need this branch or can we delete it ?


Bah je vois pas pourquoi tu la mets


Can you make the one-exit change upstream to reduce the diff here?


OK thanks. I will add ```howmany()```.
Regarding the second question, then ```tmp``` will not be zero because both ```esize``` and ```tmp``` will be at least 1


Si on fait tous un indentation différente ça va pas bien se passer, les pull requests seront énormes pour quasi pas de changement utile :P


Thank you for doing this!


@eferro possible memory leak using the time.After


Bah parce que \section est sans indentation, puis t'indentes pour subsection, puis encore pour subsubsection... Logiquement c'est censé être comme ça qu'on fait. Je sais que c'était pas fait au départ et que maintenant ça fout le bordel, mais ça a toujours été comme ça. On va faire un checkout pour revenir à la version sans indentation et arrêter de foutre le bordel, mais ça sera quand même moins joli.


One file to many fs events

One mds event to one fs event


It looks like init would do the same thing during service_start.
See http://androidxref.com/5.0.0_r2/xref/system/core/init/init.c#291


need to remove this if clause


Qaurk is working on more than one buffer at a time. This is because the order of the hash algorithms are not the same for every run. (Case on the result in hash[0] (if i remember correctly)

The last Jh_512 is working on the d_branch2Nonces[thr_id] and not the final d_branch3Nonces[thr_id]

see the implementation in:
quark_compactTest_cpu_hash_64

It might be possible to rewrite quark_compactTest_cpu_hash_64 test test the jh512_final hash.


Should be reverted asap then, but the caps are great.


I think it should work properly. r=me


Also extrapolated animation to a separate function, to make future use easier.


The placeholder text is barely readable, it doesn't have any i18n and besides it's misleading, as language and TP announcements are not displayed yet. Let's remove this commit from the PR please.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 931](http://build.osmsharp.com:8080/viewLog.html?buildId=4112&buildTypeId=bt16) is now running


@lucas  I think we should understand what the patch does before to commit
it. Can you explain why it fires? Under what scenario it fires?

It is quite tricky to return from root search without updating rootmoves, I
think we should have more visibility on what actually happens.

On Fri, Jan 16, 2015 at 12:45 PM, lucasart <notifications@github.com> wrote:

> @mcostalba <https://github.com/mcostalba>: crash testing at depth=8
> (enough for aspiration windows to kick in) reveals no issue (crash or
> illegal move). this patch is ready for commiting IMHO.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lucasart/Stockfish/commit/e1bd41f972513a8bc562277a5eb817891850c844#commitcomment-9313150>
> .
>


Could you modify the gold and iron ingots so that they have the same size and positioning as the rest of the ingots? It's a minor thing, but they should ideally all fit in the Tinkers ingot mold which I just updated.


You reverted almost all of the fixes we have made since 4.2... 95% of this commit is useless changes and will break things


Hi Vineet, hs38_vdk branch can be removed, HS38 VDK buildroot points at arc-2014.12.

Ruud.

From: Vineet Gupta [mailto:notifications@github.com]
Sent: Friday, January 16, 2015 1:19 PM
To: foss-for-synopsys-dwc-arc-processors/linux
Subject: Re: [linux] Reverted to default axs101.c version, all registers have been modeled in the VDK now. (4cff936)

Ruud, do u need this branch or can we delete it ?

—
Reply to this email directly or view it on GitHub<https://github.com/foss-for-synopsys-dwc-arc-processors/linux/commit/4cff93633ff62ebd556a3fe3f890e7a2f41e1b34#commitcomment-9313564>.


My bad I didn't realize I was commenting a commit and not the PR^^. That's a proof I'm reading carefully every single line though :p


Perfect! We should start adding these to a design document or README.


TeamCity Ylab :: zmactep/ylab [Build 155](http://192.168.30.225:8111/viewLog.html?buildId=532&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


Please wrap lines at 80 columns.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10082/testReport/) for this commit**


Avoiding it makes the polyfill more robust. Consider e.g. `String.prototype.lastIndexOf = function() { return 42; };`.


This is COu


Hmm, we’re still using `charAt` though, but there’s no way around that.


regex should be a string. So we assert that an exception gets raised if we do NOT pass a string.


OK, handled in 69609b32e86ceddce35f33d16d1565872d7004ad for now.


I remember now: the use of `.call` made the code slower than it needed to be. The new code avoids it.


the purpose of code review is to track the issues before it starts creating issues


> The \_\_init\_\_.py files are required to make Python treat the directories as containing packages; this is done to prevent directories with a common name, such as string, from unintentionally hiding valid modules that occur later on the module search path. In the simplest case, \_\_init\_\_.py can just be an empty file, but it can also execute initialization code for the package or set the \_\_all\_\_ variable, described later.

From https://docs.python.org/2/tutorial/modules.html#packages