I think we are better off waiting for the 4.x release and then doing work
on that.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Mon, Jan 12, 2015 at 6:57 PM, Federico Andres Lois <
notifications@github.com> wrote:

> I was thinking more on the line of pushing the changes to 3.0.3 to release
> an optimized 3.0.4 (obviously the Lucene team must agree to it) and as I
> bet many of the things we are going to do are going to remain in one way or
> another in 4.0.x, they can even port the changes into the 4.0.x branch
> without too much trouble…
>
>
>
> We can even focus on things that are to be present in 4.0.x branch. Do you
> think that would be doable?
>
>
>
>
>
> From: Ayende Rahien [mailto:notifications@github.com]
> Sent: lunes, 12 de enero de 2015 01:45 p.m.
> To: Corvalius/ravendb
> Cc: Federico Andres Lois
> Subject: Re: [ravendb] Aggresively inlining methods and properties with
> millions of executions when bulk uploading 25000 freedb records. (19a94a4)
>
>
>
> We would lose the ability to update to the 4.x version, which is what the
> lucene.net community is working hard on.
>
> *Hibernating Rhinos Ltd *
>
> Oren Eini* l CEO l *Mobile: + 972-52-548-6969
>
> Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811
>
>
>
> On Mon, Jan 12, 2015 at 6:31 PM, Federico Andres Lois <
> <mailto:notifications@github.com> notifications@github.com> wrote:
>
> > Thinking out loud here. Why not fix Lucene a bit instead in the
> meanwhile?
> > Meanwhile, as in, have the proper time to invest in owning that part of
> the
> > stack too. Lucene in itself is a good solution, a bit underdeveloped
> lately
> > (last big update is 3.0.3 and almost 1 year old already), but serves the
> > purpose quite well. Armed with our knowledge on how it is used on
> RavenDB
> > there are many optimizations that would certainly impact us dearly.
> >
> >
> >
> > While rewriting and stabilizing the whole Lucene functionality may take
> 1
> > year or so. In 1 or 2 months of work we could be able to at least
> optimize
> > the common paths.
> >
> >
> >
> >
> >
> > From: Ayende Rahien [mailto:notifications@github.com]
> > Sent: lunes, 12 de enero de 2015 01:20 p.m.
> > To: Corvalius/ravendb
> > Cc: Federico Andres Lois
> > Subject: Re: [ravendb] Aggresively inlining methods and properties with
> > millions of executions when bulk uploading 25000 freedb records.
> (19a94a4)
> >
> >
> >
> > We have a lot of problems with Lucene, and we really want to switch from
> > it.
> >
> > The problem is that it is very much a non trivial task to do.
> > I spiked it using Voron, but we are currently stuck with how to handle
> > updates efficently.
> >
> >
> > *Hibernating Rhinos Ltd *
> >
> > Oren Eini* l CEO l *Mobile: + 972-52-548-6969
> >
> > Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811
> >
> >
> >
> > On Mon, Jan 12, 2015 at 6:13 PM, Federico Andres Lois <
> > < <mailto:notifications@github.com> mailto:notifications@github.com>
> <mailto:notifications@github.com> notifications@github.com> wrote:
> >
> > > Dont get me started on Lucene :P
> > >
> > > -
> > > Reply to this email directly or view it on GitHub
> > > <
> > <
> > <
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2>
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2
> > 949334088#commitcomment-9243883>
> >
> > <
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf29>
>
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf29
> > 49334088#commitcomment-9243883>
> > > .
> > >
> >
> > -
> > Reply to this email directly or
> > <
> > <
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2>
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2
> > 949334088#commitcomment-9243995> view it on GitHub.
> > <
> > <
> https://github.com/notifications/beacon/AA_zowHd8_Rqu-jSjS01Th8beWnpvAGwks5>
> https://github.com/notifications/beacon/AA_zowHd8_Rqu-jSjS01Th8beWnpvAGwks5
> > ng-uSgaJpZM4DRNQw.gif>
> >
> > —
> > Reply to this email directly or view it on GitHub
> > < <
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2949334088#commitcomment-9244261>
>
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2949334088#commitcomment-9244261>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub <
> https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2949334088#commitcomment-9244485>
> . <
> https://github.com/notifications/beacon/AA_zo4RQKUhveVJ7opKjUkhBIMaPGf_Lks5ng_GUgaJpZM4DRNQw.gif>
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2949334088#commitcomment-9244726>
> .
>


Yes, but I find my code easier to understand and to write. I agree it is not as concise.


Don't mark hw keys as Virtual, this can cause various issues
only the soft keys should be marked as virtual to enable haptic feedback (back and menu)


Good idea


I was thinking instead we should name all the other functions in the codebase to a single letter and then the word "hack". Oh well.


Was this removed?


Looks better :)


One of two main SDL maintainers works at Valve :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9946/testReport/) for this commit**


Cool, I get the idea and I like it.
Design-wise this is not as advanced as what I’ve seen last week so if you guys want more updated feedback, point me at newer designs.
And keep up the good work.

@chen1203 next time you have a conflict you might want to check ``git mergetool`` which is a tool to make conflict resolution easier. More about it here:
http://www.git-scm.com/docs/git-mergetool
&
http://stackoverflow.com/questions/161813/fix-merge-conflicts-in-git

hope you get a better experience next time it happens ;)


Just kidding after you commit's title


we'll need to use unicode.  `bool 體hack() {...}`


I forgot to note that spyro can still move when there is a dialog. I think I'll fix this too in the next commit.


Thanks you! I'll merge this in!


is that part supposed to be faster, too? In my tests (with luajit), for i=1,#array is about 50% faster than using ipairs.


What Alt-Enter is supposed to do? Switch between windowed\fullscreen modes?


I think this is wrong.  This is saying only let nil through, which will immediately blow up on the next line.


Yes


There may be userland changes needed with this (for the mcontext_t), I haven't checked, I've only done the kernel side so far.


Yes, you are right. I've overseen that `Nil` aligns well to express that now query string parameter are there. The same it true for fragments.


I'm not sure on the hashes nil thing...it completely hides the fact that nil is a valid input (for skipping), and it make it look like inventory is actually getting saved, then stored, neither of which happen.  Need to think about it.


Spelling derp.
Line 738 for cr_strings; omniSwitch -> OmniSwitch.


Thanks Michael!


I don't really like if-else all on one line. How about
```perl
$args .= "sfp=" . ( $doSfp ? $sfp : "!") . " ";
```
?


I haven't yet reformatted all the files a according to our 120-character
agreement.


Add note about permissions


Nope, I get you, it is why I put the array merge there in the first place. All I remember, is I saw a warning pop up in the console and I went through similar files and made the change. May just be this file had the merge and others didn't (which I saw the warning on). Feel free to tweak if you like, the code won't break :p


Great thanks that's what I wanted to know!


85907178-MinOASchedule (kbenne) - i386-Windows-7-VisualStudio-12: OK (2179 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54317039744176%25-yellow.svg)


might as well just pass the completion block in as a parameter and forget providing another block that just calls it


Could remove this line:

```JS
this.version = version || "latest";
if (!sources[this.version]) throw('Version not found');
```


Indeed why not. Changing all three...


Apart from the `en_US ISO-8859-1` locale, all this seems like nice improvements (I see no reason to add the non-UTF-8 en_US locale). How 'bout asking @alunduil to pull this back into https://github.com/gentoo/gentoo-docker-images?


@joepestro It's fixed now, sorry about the inconvenience! We still had the backslash escapes in the command (copied from Ruby)...


@baylee yeah, we'll need to figure out a Cloudfiles strategy in the next month for Feature and can revisit this.


yes Daniel Kayiwa The method you suggested is perfect Updated this in my next commit :)


why is the 'x' in "2x" capitalized


Yes, Alt-Enter switches between windowed\fullscreen modes.


You don't need preload anymore?


Sorry that i have hard coded the date i have solved this issue in my next commit to  same PR :)


Nothing special


It looks like you copied the `test_center_point` method without changing it to `random_point`.


I'd think this would be called `$month`.


I'd think this would be called `$dayOfWeek`.


I'd think this would be called `$year`.


Hi Adam,

good to hear that there is a place to share animations now! I'll polish the
circlepop animation and post it on the forums when I get a chance to play
with my raspi.

grtz

2015-01-12 15:10 GMT+01:00 adammhaile <notifications@github.com>:

> Hey @kasperfish <https://github.com/kasperfish> , I like the new
> animation and noticed your comment about sharing them. We do have a place
> now :) https://github.com/ManiacalLabs/BiblioPixelAnimations
> You can also submit/discuss user generated animations here:
> http://forum.maniacallabs.com/forumdisplay.php?fid=6
>
> We'd love to have yours as part of the animation repo!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kasperfish/BiblioPixel/commit/fd23845d5fe92d590c3583b9144726b08a760af8#commitcomment-9241697>
> .
>


Ok. I found some tidbits that would allow me to use specially crafted paths. Don't know how much we will win on those though. Keep you posted.


Since this will continue to grow it might be nice to keep it in a partial (`settings_js.html`?)


Oh! Nevermind. I see that you've included it already at the end.


84694650_EnableCodeCoverage (lefticus) - Win64-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


stg backend is missing from usage message ;)


Это компилируется в:

```js
for (_i = 0, _len = value.length; _i < _len; _i++) {
  item = value[_i];
  files = utils.anyToFile(item, settings);
}
```

Это никогда не работало. Никогда. https://ucarecdn.com/widget/0.8/uploadcare/uploadcare-0.8.js

Coffeescript — это очень плохо :(


because that's the name of the file anika send me


text_splitter is doing away with trailing whitespace if there is any, but, lo and behold, there is a ruby method that accomplishes just that! I can delete the text_splitter method and just call 'strip' on text in replace_header_tag.

thanks!


The rockspec can now have libbsd removed.


Why?


It surely is not but since the whole AMT/TFTP example is right above it, I felt like leaving the TFTP argument out should be fine. But I am fine with including it for completeness sake :)


sweet that works! I was also going to suggest setting the domain on `Graph.__init__`, but this is more straightforward.


it's in the bottom. I don't know where i have to put it :P


This defeats the whole idea of the macro in the first place. If JTR_MODE is not defined, the preprocessor must output 100% like the pristine pp.c from upstream. The real solution would be this:
```C
#ifndef JTR_MODE
  db_entry_t *db_entries   = (db_entry_t *) calloc (IN_LEN_MAX + 1, sizeof (db_entry_t));
  pw_order_t *pw_orders    = (pw_order_t *) calloc (IN_LEN_MAX + 1, sizeof (pw_order_t));
  u64        *wordlen_dist = (u64 *)        calloc (IN_LEN_MAX + 1, sizeof (u64));
#else
  db_entry_t *db_entries   = (db_entry_t *) mem_calloc (IN_LEN_MAX + 1 * sizeof (db_entry_t));
  pw_order_t *pw_orders    = (pw_order_t *) mem_calloc (IN_LEN_MAX + 1 * sizeof (pw_order_t));
  u64        *wordlen_dist = (u64 *)        mem_calloc (IN_LEN_MAX + 1 * sizeof (u64));
#endif
```


Nice catch!


Remove this block


LOL. That's fine.


I will fix this. I'm also merging upstream changes (which did not work due to this change)


LGTM, but could use a more descriptive title for the commit.


Sure, that's cleaner.  Should I revise this commit, or just submit an updated one?


...On second thought, I think we should actually keep injection for SwapBuffers and wglSwapLayerBuffers around.

I believe the reason they are there is to get insight into how the game's GL context is structured. So if we run into a bug, we can at least see the swapbuffers variant that is invoked.

Removal of unused runtime lookups LGTM.


Fixed in 9f51d0c86d9348349d921c393d6ffcbbfd521192.


That would be a great name.


I think rnewman has a PR for fixing this test, so you can remove this.


Probably none. Most of them were to avoid unnecessary operations in the common 1.0 case, but that one I may just have copied the structure from the others.


r+ rollup


This was brought over from the old version of the node, but I want to record for undo the modification of the min, max, and step as well, so I remove this return statement in both DoubleSlider and IntegerSliders DeserializeCore method.


I don't mind - some users will probably appreciate it, being able to accept pasted CSV text as well as files and handle them the same. Thanks!


What's the difference between those two formatters functionallity?


Why do they always have duplicates in the first place? Not decoding properly?


how can I help move this along :)?


oops, i should have deleted this file. Its not used, finally I did the comment lis on the same template as the post itself


i tried with several VPN always get no_routes


It does not and it will only take the first value it finds. That being said, the example should point out that these arguments are valid and used by both modules. May we should include the module name in the argument as well, e.g. --reset-amt-host, --output-amt-host and so.


Nit: Sqlite -> SQLite


When https://github.com/mer-packages/sensorfw/pull/52 gets accepted, this should go away


What is this wrapping? wrapper -> db ?


Remove this and just use nil directly below?


For now I've changed which implementation of bot service we want to be injected into SimpleSandbox but I am not sure if this is a good idea - comments are welcome.


Thanks for the tip. I pulled them out into their own methods.


Great job! @DavidMGross


I'm happy for you to commit the revision directly to the main repo and kill this pull request.


come on dude!


Yeah it's ugly. But I think your refactoring handles it pretty well considering.


I was able to update manually Transifex.


removed this.


test


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


I agree. I never intended for this test page to be so awesome! I really do like being able to see expected input/output/errors in the table format, though. Maybe we could look into a way to preserve that while using a proper test framework. (That'll be another issue. Stay tuned.)


Unable to locate the source $pid

Trouvez l'intrus


Ah, that's awesome. This line is kinda ugly anyway. I commented out these lines and all tests still pass, and the player is still functional in a variety of scenarios. I'll merge in your changes in a second and then nuke it myself. Thanks!


@Underground78 @alexmarsev: What do you think? It seems to resolve issue when resizing is not required. I'm not sure it is best way though.


Even though this isn't multi-threaded yet, it's good that you have a callback with that in mind. You could just call the callback directly here -- I'm guessing you're dispatching to the main thread just to avoid bugs where code might be relying on a synchronous result? If so, can you add some comments to that effect (or explain if there's another reason)?


Fix #875


Therefore the example is not accurate (the colors).
Actually, I came here for the "wrong" example, maybe leave "dark" section pages as a parameter?


Good catch. Fixed with 2c708426ccc7f286e2e8b470f906a0b27365e6e0.


Okay thanks, will do.


All review comments addressed


So why do all of these need to be made public now?


Ha, right. I've seen this before, thanks! One thing though: Can you change the comment to proper C-style?


I don't believe these 2 items need to be 1024 characters


**SideCI-STG / RailsSecurity - Security Warnings**
[Command Injection](http://brakemanscanner.org/docs/warning_types/command_injection/) Possible command injection
lib/plugin/instance.rb:198
[Command Injection](http://brakemanscanner.org/docs/warning_types/command_injection/) Possible command injection
lib/plugin/instance.rb:194
[Command Injection](http://brakemanscanner.org/docs/warning_types/command_injection/) Possible command injection
lib/plugin/instance.rb:229
[Command Injection](http://brakemanscanner.org/docs/warning_types/command_injection/) Possible command injection
lib/plugin/instance.rb:197

[Click here if you want to see all Security Warnings](http://www.codemagica.com/github_repositories/18295018/security)


Which images are we talking about?


doe maar 12px


I don't think this needs to be 1024 bytes.


Each of these `<img>` that have `width="640"` should be fixed to `width="100%"` so that the image is also responsive (specially for mobile).


Out of curiosity, if round only takes one or zero arguments, why are you using the splat prototype? (Splat means array of variable length.)


cover art. Some guy loaded 10MP and complaining that window is slow on dragging.


Sure. Short, conclusive titles are hard. :)


Should this be `packet_memory_barrier` instead?


Is it guaranteed that this will only be called once ?


I think you're right, I believe I was testing something there and ended up leaving the line in I'll remove it from the PR.


A few nits:
* var -> let, since you aren't modifying p
* Our style guide suggests using shadow naming "if let profile = profile" rather than trying to think of new arbitrary variable names (like "p").
* But you can just do if "profile != nil" here since you aren't even using p below anyway.


What happens if `round` is called on an NMatrix with a non-floating-point dtype?


The vector tiles contain the duplicates. I don't think it's a decoding error. Only some of the features have duplicates. We've always handled duplicate vertices https://github.com/mapbox/mapbox-gl-js/blob/17365dc7c49d87ca937ae910e725087d68ec214a/js/data/line_bucket.js#L84-L85, just never for closed paths which are a bit of a special case: https://github.com/mapbox/mapbox-gl-js/blob/17365dc7c49d87ca937ae910e725087d68ec214a/js/data/line_bucket.js#L73-L76


The speed of `ipairs` is so unbelievably irrelevant here.


Seems like a bit excessive to have to require "internal" on so many definitions - when anything over 255 must be internal anyway.

Why not, e.g. something like

    BEGIN-VENDOR BroadSoft attr_max=349

instead to save all the flags, or alternatively keep the code exception to not require "internal" on all the FreeRADIUS internal definitions as before?


SWAG!


IMHO, the best would be to have different color schemes utilizing existing colors. That would mean introducing "abstract" colors like "slide background", "section background" etc. But thinking further about that, I'd assume Beamer *somehow* already provides this but I don't how :-/


By keep around, do you mean not remove if we find them to be unnecessary?
Or not even comment them out like I did here?

You mean we should keep injecting the two functions, right?


I think there is a mistake here, probably remained from the old method. In the previous version, collectedIntervals was a fresh (empty) ArrayList, while here it gets intervals from getIntervals method and then duplicates intervals of the specified type in the same list, right?


Profile? -> Profile!


fixed


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Oh. *wink wink*


Rather than holding an optional Profile and switching to a mock profile here, can we have AppDelegate/ClientTests pass in the profile they want? It'd be nice if BVC wasn't concerned with profile instantiation.


I'm more on the side that you haven't done it excessively enough.

> On Jan 9, 2015, at 11:38 AM, Mark Reid <notifications@github.com> wrote:
>
> I have a gui program that does all the pyav stuff in a bg thread and the jank is really noticeable without. I might have done it a bit excessively...
>
> —
> Reply to this email directly or view it on GitHub.
>


@ansis looking at this screenshot https://github.com/mapbox/mapbox-gl-js/issues/776#issuecomment-60193599, it seems like a lot of features have those duplicate vertices. Perhaps it's something that should be fixed on the mapnik-vector-tile side. @springmeyer


Nit: no newline


Okay

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Mon, Jan 12, 2015 at 8:21 PM, Federico Andres Lois <
notifications@github.com> wrote:

> Ok. I found some tidbits that would allow me to use specially crafted
> paths. Don't know how much we will win on those though. Keep you posted.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Corvalius/ravendb/commit/19a94a4713a21198d410f8cb9af3cf2949334088#commitcomment-9246261>
> .
>


should probably be setBuildInfo?


setBuildInfo


How about a function like:

    // Ensure that all the symbols that the OpenGL overlay
    // have been looked up.  If any of the symbols are
    // unavailable, this function returns false.
    static bool lookupSymbols() {
        #define FNFIND(m, n) \
               if (o##name != NULL) { \
                   o##name = reinterpret_cast<t##name>(GetProcAddress(handle, #name)); \
                   if (o##name == NULL) { \
                       return false; \
                   } \
               }

              // Lookup OpenGL32.DLL symbols
              HMODULE hGL = GetModuleHandle("OpenGL32.DLL");
              if (hGL == NULL) {
                  return false;
              }
              FNFIND(hGL, wglCreateContext)
              [...]

             // Lookup GDI32.DLL symbols
            [...]

            return true;
    }

And then, in `checkOpenGLHook`, something like this?

	void checkOpenGLHook() {
	 	static bool bCheckHookActive = false;
	 	if (bCheckHookActive) {
	 		ods("OpenGL: Recursion in checkOpenGLHook");
	 		return;
	 	}

	 	bCheckHookActive = true;

		bool ok = lookupSymbols();
		if (ok && !bHooked) {
			// Add a ref to ourselves; we do NOT want to get unloaded directly from this process.
			HMODULE hTempSelf = NULL;
			GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS, reinterpret_cast<char *>(&checkOpenGLHook), &hTempSelf);

			char procname[1024];
			GetModuleFileName(NULL, procname, 1024);
			ods("OpenGL: Unhooked OpenGL App %s", procname);

			INJECT(wglSwapBuffers);
			bHooked = true;
		} else if (bHooked) {
			hhwglSwapBuffers.check();
		}

	 	bCheckHookActive = false;
	}


There is no release for this code yet. It can only be acquired by cloning!
Regards,
Phil


I bet 80% are "<>" to "<>" accordingly.


One more patch I found here https://github.com/sigma-1/raw-android-patches/blob/master/0056-mmc-core-host-only-use-wakelock-for-detect-work.patch

For some reason it was reverted in 3_0_72_2, but according to patch description better don't do it. Although it is reverted in STE kernel too.


Buenísimo!


Why do you need to override this? Isn't 1 the default?


Yeah, I think slicer added them for a reason (to debug edge cases).  I don't think they're just leftovers.


Just for the record: as discussed, "AU" seem to mean "affected unknown", which is what we want here. But to make sure we need to test communication with BOADICEA and check with users


The format is identical to what was output before.

```
ClassName::#creates
  test_0001_should create a new ClassName PASS (0.00s)
```

To be honest though, I do think this could be improved much further. Technically it should create a cascade that is organized similarly to the test file itself:

```
  ClassName
    #method_i_am_testing
       some other thing I am sub-describing here
          test_0001_should test this thing I want
```

I'm just not 100% certain how easy it is to do this with the output. I'll spend some more time on it in a separate PR


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


This looks like it may have a typo in it?


3_0_72 - yes, we can try to boot it and see what happens.

But I think I didn't understand what you just said... The changes need to
apply and work. Most of them won't apply cleanly (that is, with simple git
apply). Using 3-way merge helps alot. The whole point of this fun is to
know what to apply. And so far the only way I've found to find those things
is by finding what we don't need to apply because it's either not used or
present somewhere else in the "future".
Remember - all the time I mean dumb patching, that is without reading the
code. There is of course 'the right way' - analyze the changes and figure
out what's needed, but people don't live that long... and I don't think we
could do it in our lifetime...

So far we've got this
# git diff -M5 --diff-filter=M --stat bea3738..3_0_31 | tail -n 1
 771 files changed, 50995 insertions(+), 13185 deletions(-)

reduced to this (-74 files -4k changes)
# git diff -M5 --diff-filter=M --stat android-3.0..3_0_72 | tail -n 1
 697 files changed, 47991 insertions(+), 11959 deletions(-)

out of those 697 files that are left, 165 can be found somewhere in
android-3.4 branch in exactly the same version, so we can ignore them
that leave us with 532 files and 48882 lines of changes (-11k)

But those are _all_ changes. I'll try to cut away as much as possible from
3_0_72_2 branch, because some code is not used and I'll see what's left...

Then I'll compare that with 3.4 kernel from github and maybe that
'unofficial' as well. And no more ideas for now ;) we'll see how much is
left after this...


Sounds good :+1:


Is it worth considering using PATHSEPCHAR, or will it always be /


ok


Won't this consume the Option, meaning it can only work for a single request?


It seems like now `directory` is being copied into `target`, not its content. Maybe running `put()` for each entry in `listdir()` would work?


I really like this. We should do that everywhere, e.g. LXQtTaskButton to TaskButton. Anyway, I came here to warn that this commit introduces duplicate plugins in `/usr/local/lib/lxqt-panel`, because of the renaming.


looks good


Ej echt tof man, dit scheelt echt gigantisch veel werk :+1:

![](http://33.media.tumblr.com/tumblr_m4h8krLLUn1rwcc6bo1_400.gif)


r- this is misinformation


Does this work with the Windows fonts? I don't have a Windows computer available at the moment, but when I looked for them at work it looked like the italics version of Garamond was called garait.ttf, not garai.ttf, and I'm not sure I could find any bold+italics version. I also couldn't find any variants of censcbk.ttf, but I did find schlbkbi.ttf etc.

I don't know which of these are actually used in the games.


Quite the opposite: As I see it, the AMT module can be configured by `--amt-` parameters. The module itself provides `reset` and `log` steps. Do you agree? This somewhat limits the usage scenarios but only to reasonable cases.


Maybe let's be clear on what we mean by "ste kernel", because we have two
ste 3.4 kernels... maybe let's call the one from github ste kernel and the
other just "unofficial"? :) so which one did you mean?

2015-01-12 19:50 GMT+01:00 Shilin Victor <notifications@github.com>:

> One more patch I found here
> https://github.com/sigma-1/raw-android-patches/blob/master/0056-mmc-core-host-only-use-wakelock-for-detect-work.patch
>
> For some reason it was reverted in 3_0_72_2, but according to patch
> description better don't do it. Although it is reverted in STE kernel too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChronoMonochrome/kernel_common/commit/cb0b2af4f5cabd075cb9d2c027c1df1649e18eb6#commitcomment-9246777>
> .
>


imathis@blip.local?


Yes, `bower install` does not like that at all


What have I done??? I created a monster :(


We don’t have that reason though, and they don’t do anything. It could have been debugging, or initial development.

I guess we can keep them. Debug edge cases is ok enough reason.


rax retry tests


HelloWorld.md


Seemed like an unnecessary hit on performance to me.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


whoops


sorry, fixing


I used `nm_unary_log` as reference. Its the same over there, and that accepts 0 or 1 args (at least I think its supposed to).


Accidentally changed the bottom line as well, please don't merge this commit and use this one instead: https://github.com/mstevens83/PagerSlidingTabStrip/commit/64427c203f92c5d939111d9f0a83895e52c2cae1


We should get in the habit of making delegate weak vars.


I'm pretty sure this doesn't happen; [tests pass](https://travis-ci.org/remram44/tej/builds/43758990).

If you recreated the queue (cf [#10](https://github.com/remram44/tej/pull/10#issuecomment-66797707), `commands/new_job` was updated) you shouldn't run into this.


@impaktor's jokes are bad even in context :-)

Yeah, that's a proper commit log.


Pushed fix, let me know if its OK


from imports, within this group of imports, go first?


LGTM


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1091 of 1091 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


nit: newline for clarity


Consider collapsing this into a single call to appendf by using a ternary operator


simpler:

```
def sniff(*args, **kwargs):
  pass
```


Uh… how did that happen?


Looks good, thanks!


r+ rollup


DivideByZeroProtection (lefticus) - x86_64-MacOS-10.9-clang: OK (332 of 332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think I busted something…


:D


Maybe just do nothing or log an error here? If we click a site, it should have a URL, and that URL should be valid.


so is ansible_nodename just: the everything before the first '.'  e.g. dsXXXX  ?


Does it mean that these changes  https://github.com/mkaluza/kernel_common/wiki/TODO#check-and-merge should be re-applied to 3_0_72, without reading code?


I think it would affect ships, but called the "Cheap Starbase" on http://wiki.starsautohost.org/wiki/Known_Bugs#Cheap_Starbase as it is more significant game wise.

I added the updateQCosts skeleton function, I guess it should be for anything new in terms of progress has not been made on it yet, otherwise it could penalise someone adding something to the Q that won't be build for several years\encourage extra MM - you might want to go around every planet in your empire and Q 3-4 years of production to balance minerals, and then go around again to remove the extra years so you don't miss out on miniaturization.


Shouldn't this throw the exception?


No. Both functions are not supposed to be in the same module. The reset (or better power_on) is provided by run/power_on/amt whereas the log is provided by run/log/amt.

Personally, I would actually like module-specific parameter to be prefixed. I.e., having both --power-off-amt-password and --log-amt-password.


It shouldn't be because I used a cherry-pick to get it.


I've corrected this to lookup colony.planet, as it is only in one we might as well leave the prodQ aware of the colony only, rather than give it planet as well.


These can actually be omitted entirely, I just needed them to bootstrap awhile back.


Is this supposed to say test?


That name seems fine, I've corrected this


Corrected


Throw?


Your solution is much better. Thanks!


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


No, it's the whole thing as returned by platform.node.  ansible_hostname takes platform.node and splits it by '.' and takes the first chunk.


Double checked https://github.com/twitter/commons/blob/master/src/python/twitter/common/styleguide.md, but no mention, so moving it


Corrected Research.colonyResourcesAfterTax


- Removed players ability to move back to the left.
- Changed the way the controls are handled.
- More clean up of code.


Nice! This looks really good.


Where did 8 come from?


Good catch- thanks to the `dnet` work, we don't need this at all.


Why stop logging the errors? What does the user see now if something happens?


This should have been a nested list right? There's just an `o` right now.


removed.


setBuildInfo


@Ashalynd I would recommend to use the angular ui router for routing. Usually it should have the same effect, but especially for older browsers usually front-end routers to a lot of magic to have proper history & a working back button. Not sure if this is also true for the Angular router.

I changed it here: https://github.com/StarterSquad/Optima/commit/5b7d672d72d3bdfed8d8a81a4e1cdc3498df868b#diff-7065a884e0381182f902df855e780d67L55


Brilliant! Feel free to help me out with other exercises as well!


set BuildInfo x2


`'1.6'` probably should be a constant as well.


It totally is. It's a strange artifact of the various iterations I went through.

It's probably meant to be closer to https://github.com/TJ09/hhvm-packaging/blob/master/hhvm/deb/package#L40


Should you log the command being executed before you make the attempt?


DivideByZeroProtection (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (332 of 332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Would it not be better just to detect if the version is less than v1_7_R4 instead and default to getScore(String), otherwise this will require a change in the if statement for every server version update from now on.

This check could be moved to a class private variable too, to avoid performing the check every time getScore is called, as the minecraft version should never change once the process has started.


Note how CoD4 uses %s.%s instead of %s.bik...


This should just say "Calculate the covariance matrix"


It's not critical. I can fix it, and I will now, but it would be better to leave this as-is if it doesn't affect the ability of people to understand it.


Sounds pretty verbose to me...


Good work.


@InfinityRaider don't worry about stuff like it.
This is premature optimization and makes almost no sense as this is how Java would rewrite your String + String.
Remember until performance is not an issue there is no need to worry about it.
Java is doing great in terms on optimization and this change reduces readability of code bringing little to no benefits.

Instead of using yours LogHelper and FML logger you can use
```java
private static final Logger logger = LogManager.getLogger("AgriCraft");
```


Took me over a year to find this gem, 'Operation Hotty Hot'


FYI @hurrymaplelad. Awesome post!


Yes and no :)
In theory, branches 3_0_72 and 3_0_72_2 should be identical, because the
only thing that changed is the order of patches (linux,samsung vs
samsung,linux). But for some reason they aren't. Probably I just screwed up
when doing 3_0_72_2, :) but those differences also mean that there's been
much happening there and there might be something that is special for our
phones, so we need to keep this in mind if something won't work.
But if we only want to test it, we can just use 3_0_72 or apply the diff
almost blindly (without digging into the code, just so it 'looks fine' and
builds).

2015-01-12 20:01 GMT+01:00 Shilin Victor <notifications@github.com>:

> Does it mean that these changes
> https://github.com/mkaluza/kernel_common/wiki/TODO#check-and-merge should
> be re-applied to 3_0_72, without reading code?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChronoMonochrome/kernel_common/commit/cb0b2af4f5cabd075cb9d2c027c1df1649e18eb6#commitcomment-9246977>
> .
>


It's better to use `QNetworkRequest::setHeader(QNetworkRequest::UserAgentHeader, ...)`. Also no need in `QByteArray` for the value in that case.


this is a change to readmie


Found BROKEN by linux-clang.
Here's the log file for step 'testbot update':
```
From github.com:casadi/testbot
 * branch            master     -> FETCH_HEAD
There are no candidates for merging among the refs that you just fetched.
Generally this means that you provided a wildcard refspec which had no
matches on the remote end.

```


`QNetworkRequest request(url);` would save one line.


This will break if value === undefined and key is not an object. If you are going to rely on this, it might be better to check the what key is before overwriting the file contents. Additionally, this throws away any existing build info - if that is intended, it might be a good idea to make it clear. If not, merge the existing build info?


Yep, that's just a subcommand to quickly test holograms. I remembered that the return type of getHealth was changed from int to double some time as well, now just making sure to simply not use it as it's not really necessary here. There are a few subcommands for some testing/debug infos, if you're interested, check /mapi.


Ah, I haven't actually runtime tested the code.  So, they'are actually invoked on every frame?

My initial thinking was that they were alternative swapbuffers implementations that *might* be called in place of the wglSwapBuffers.

If they're called every frame, because of the way WGL is structured, then I'm fine with removing them completely (no need to comment them out, we can reacquire them via git).


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Just a nit, this could be done in a single line
char removedChars[64] = {0};


Fixes region names with underscores, not hyphens... those were fine.


newdata = DataFrame({'countries': Series(countries), 'gold' : Series(gold) ,'silver': Series(silver) ,'bronze' :Series (bronze)})

    medalcount = newdata[['gold','silver','bronze']]
    b = [4,2,1]

    points = numpy.dot(medalcount,b)

    olympic_points_df = DataFrame ({'Total Points' : Series(points),'countries' : Series(countries) })

    return olympic_points_df


I worry about this kind of io without better protection. In every build step there are now 4 things in a row that can throw errors and break the build - file read sync, json parse, json stringify, and file write sync. You may want to wrap those up in try/catch and handle permissions, files not found, files locked, invalid json, and unserializable content.


I would say that this is the responsibility of the caller, but it's scan so it might be better to be safe.


what i usually do is to replace "," with "&" and use url.ParseQuery.


I tried, but couldn't make it work. I want to integrate this into the Process component later on, but for now I needed something that works at all.

Are you interested in porting this?


We need to readd these lines. These lines are required in order to run the archetype.


same as previous line


By the way - is it doesn't work, try to use gcc 4.6 - this is the one that
is 'meant' for this kernel. For now we don't want it to be super optimal
and ultra fast, we need it to boot ;) and I managed to boot to recovery
from 3_0_72. Later I'll try normal boot.


Same as before


It works like `Fixnum#round`.

Since that returns a floating point number with a `0` to the right of the decimal point, its merely gets cast to a non-floating point type again, i.e `int8` will stay `int8`.


Review if we need to change this value to false.


look @138


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3112
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3118
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3103
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3103
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3106
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3094
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2771
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2769
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1607
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1600


I am not sure one way or the other, but is there any reason putting this on the stack is better or worse than the heap?


Its got the variance values in the diagonal.

Octave calls it that too.


This is what happens when I ask to not concatenate Strings with '+' inside **loops**.


Possible use of PATHSEPCHAR/PATHSEPSTR ?  ( and following lines)


good idea


agreed.


I will check on that (every frame? alternatives?) and change the code accordingly.

If they are alternatives we would actually want to draw on those methods as well, and the overlay would not display.
Could also be wrapping a call to the implemented function, in which case we wouldn't really need it.


Key 'n' is used for 'magit_section_forward'.


If you can provide a description of how this function differs from `GetStoredMessage`, that'd be helpful.  Also, this comment should refer to `GetStoredMessageRaw`.  Otherwise, LGTM.  I can merge pending godoc update.


unnecessary


Key 'c' is used for 'magit-commit-popup'.


Would it be helpful to log the value of m_strTempDirectory ?


Idem for 'magit-fetch-popup'


Good catch.


Let's move the fabric name check into fabric.c.  There's already a check there for fi_fabric().  We can also add a check to fi_getinfo(), to avoid duplicating it in every provider.


Unlike shared variables, Constants can have their types changed by optimizations.  So I'm not sure we really need that.


@Humerus :O Well... :wink: We're already helping with that xD


saw approval from pnkfelix
at https://github.com/swgillespie/rust/commit/f82c75b0a7e7fd56c6915187ce03f0d9f657563a


merging swgillespie/rust/emacs-issue-20422 = f82c75b0 into auto


status: {"merge_sha": "3a44a19af29585c02e81e22ea7665f829ae0590a"}


swgillespie/rust/emacs-issue-20422 = f82c75b0 merged ok, testing candidate = 3a44a19a


Injected javasctipt
also returned result as JSON with all tags
Handled links for Images and href


Done


Peut-être tu peux me dire ce que tu as compris de mes explications, et je pourrais alors axer les explications suivantes sur ce que tu n'as pas compris?


newdata = DataFrame({'countries': Series(countries), 'gold' : Series(gold) ,'silver': Series(silver) ,'bronze' :Series (bronze)})

    medalcount = newdata[['gold','silver','bronze']]
    b = [4,2,1]

    points = numpy.dot(medalcount,b)

    olympic_points_df = DataFrame ({'countries' : Series(countries),'Total Points' : Series(points), })

    return olympic_points_df


Done now showing host url


It is verbose but you won't type it very often because RUN_OPT will most likely be defined in your build.conf. But when reading and learning, i.e., I am thinking of examples presented on the mailing list or the documentation, it immediately becomes clear to the reader, which argument refers to which step and module. The list of run options becomes almost self-documenting. Personally, I deem this as more valuable as saving a few characters.


Removed


Not sure whether the "sounds good" refer to the change or if it should stay as it is :)


Found BROKEN by full.


I think we should not remove this as safari and chrome also show cancel. It is better for user experience as user is more familiar with this


Please make a pull request only with the 'magit-stgit-new' change. Still, I'm not much of a fan of adding new section actions unless they are "generic" (i.e., 'a' for 'magit-apply' and 'magit-stgit-goto'). Tarsius, what do you think?


I think even control is not that clear since we also have `ctrl` as a local variable. It took quite a bit of digging around to even find where there is a call that actually passes in this parameter - most of the time it isn't passed.  (It is called on L1294). This seems only to be called on the parent form - perhaps to inform it which child control is setting its validity?


Thank you for clarifying that, Intel. I will take a look at TrinityCore's packet parser to see what I can learn about this system.


If you mean logged-in-user-(only)-accessible, there's also `authentication_required!` which does dont_cache and instead of just saying not_authorized!, redirects to the dashboard sign in page:

https://github.com/code-dot-org/code-dot-org/search?utf8=%E2%9C%93&q=authentication_required&type=Code


power_on/log is the type of module and AMT the flavor, IMHO. Since in practice we mostly use one or both AMT flavored modules to configure the same target system and up to now not different systems, they share the same arguments. But to be accurate, it would be better to treat them differently.


We are handling the long press earlier than default long press handler of webview.


To changing it to `'user.sign_in'` :)


2015 maybe?  Not sure....


I don't think WPP has anything interesting there. It just shows which connection index packet comes from and that's all.


ah, ok, will do it


I've just build an image with this commented out and I'm not seeing anything  different - so this goes away


I don't like this b/c its hard coding each possible option.  It'll get unwieldy fast with multiple options for being less than a rounded number.
Ex:
100 - 'C'
99 - 'IC'
95 - 'VC'
90 - 'XC'

This gets even worse for larger values. There's got to be a better solution.


@bkw Thanks for this. In the future could you run the test suite for this Cookbook using Test Kitchen?


It doesn't appear that you use `path` in a query or a filter, so you can use `index='no'` to avoid putting this in the index. It will still be in the document source that is returned.


thanx z3bra!


That's progress!


Test


done


thanx @z3bratabs !


I just looked up a 1-100 number listing and that doesn't seem to be the case.  Maybe that isn't as much an issue as I thought.
http://www.roman-numerals.org/chart100.html


any need for case insensitive compare?


This is pretty cool stuff!


This is out of date with 3.7 so it will need to be changed once the learning vm is updated.


This is only required if we don't upload the artifacts to Maven Central. Ideally we will upload to maven central. In that case we can remove this comments


Despite we upload the artifact to maven central we need this in the config.


Thank you! Yeah, I'll get right on it :)


Too much angry salad for my taste, but I'm deferring this to Tarsius.


= { 0 } would suffice.


Should we mention that this is just as with `require`?


This should be intptr_t not int fwiw.


So this commit is basically just to put this on the list of "repositories I contribute to" for easier mobile access.


This whole hack seems unnecessary beyond making sure the args array is initialized properly.


obviously as you and I have both found working on the front end could be .... quite a bit easier :D


Ha!


It comes down to what we find more important. Convenience for people who know what they are doing or following a strict convention to foster the principle of least surprise.


LGTM


Yup :)


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


If we upload to maven central we can remove this code.


Apparently, the shorthand notation (using **M** as shorthand for megabytes) is not allowed with `ini_set()`, just inside `php.ini`, at least the [documentation](http://php.net/manual/en/faq.using.php#faq.using.shorthandbytes) says so. I don't have a 5.2 or 5.3 environment available, so I can't check if that's really the cause of the issue.


Hehe, I've been wanting this for a while, but I guess I jumped the gun :gun: :snowboarder:


Kind of giving up on JuliaBox slideshow generation...

Reveal.js works now, but MathJax does not. Only inline expressions like `$x = y$` work.


Only one question: why?


This can be removed if we upload the artifact to maven central


number of times i call incrementBuildInfoStep, doesnt seem like a nice way to programmatically determine that


Merge the following two lines + lines 522-523 a single function, maybe?


@brson These are actually quotes from 20th century American author HP Lovecraft and not fortune cookies. Either way I agree they have no right to bloat up the standard libraries


s/ids/Ids/


Won't merge. I did remove that interactive question because "--index" is already selectable from the popup menu. Then, you can customize "magit-stgit-refresh-arguments" (generated by "magit-define-popup") to enable "--index" by default.


Why did you only set some of the scalar parameters (e.g. `fatol`) and not some others (e.g. `sigma_eps`) with their default value in function signature?


You only removed Map/WeakMap/Set/WeakSet from the unofficial externs and never added them to the official externs. Is that intentional?


85907178-MinOASchedule (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2178 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.49748743718592%25-yellow.svg)


I am okay with adding a resizeSupported property. However, it is intentional that you must call updateSizeInfo before scheduling a resize action. It is necessary to have this information to ensure that shrink operations are safe/sensible, and I am not interested in bypassing this for grow operations.


Fixes #7 - update the application icon with more icon sizes


85580152-VACScheduleCrash (kbenne) - i386-Windows-7-VisualStudio-12: OK (2176 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.40612151667429%25-yellow.svg)


Oh dear. Can we auto lint in the build script?


This it not correct
it give you a mysqli result resource
you have to call mysqli_fetch_assoc on it


```
givenEdges.values.toSet.flatMap {x: Array[Int] => x}
```
is enough. No need toSet here.
Or even, more functional:
```
givenEdges.values.toSet.flatMap (identity[Array[Int]])
```


@quozl, what you think about this? do you agree in merged it?

@SAMdroid-apps
```
[gonzalo@localhost sugar-toolkit-gtk3]$ pyflakes src/sugar3/mime.py
src/sugar3/mime.py:30: 'Queue' imported but unused
src/sugar3/mime.py:35: 'GObject' imported but unused
```
Just to know, why the change from GObject.idle_add to the use of multiprocessing?


Permanent caching on cdn.rawgit.com? That sounds problematic. I also need to change the `https://` to just `//, but thanks for trying to improve this! (I always change it to https when testing the local file and forget to change it back)


Rebuilt an image without this and lipstick is working just fine - this also goes away then


Whoo! Please release this so that iOS 7 works once again.


are you happy with it?


Indeed, pcs params are passed as arrays. Only the ' lib/puppet/provider/cs_primitive/pcs.rb' part of this patch should be reverted.


Post unboxed closures we can have a `move ||` FnMut. In Servo's rustc there's no way of doing that now, hence the `fn()`


don't like the output of the tests from this line. And the problem is connected to the method name I think. verifyGraph is very imprecise. I would like to know from both what we are testing.


you can't duckface at my test because my test always wins.


But `map` doesn't consume the Option IIRC.


Sorry about the formatting. I was coding on my phone and it seems to have formatted it without my knowledge. :(


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


85580152-VACScheduleCrash (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2164 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.8579259936044%25-yellow.svg)


Looks better.

The entire escape function is a little weak.  IMO `PrepareValue` should be adding sql parameters for values.


Can you remind me what the problem of using schema_plus was? Something to do with the schema, or something else?


Since I **cannot** reproduce https://github.com/velnias75/NetMauMau-Qt-Client/issues/13 on my Windows 7, someone may want to check it by commenting out line 40 and commenting out line 42 and check if the code fixes that bug.


Sorry, I haven't been using this plugin for a while and I'm wondering what does this actually fix or add as a feature? Why would we want it to start building when there is still jobs running on Jenkins?


What does this do?  The docstring is a bit unclear to me and the comment here doesn't help.


Why does this import path differ from the one declared in main.go? Is this intentional or an oversight?


why did you make this white?


I was fully under the impression this had been released already. My bad :grimacing:


r+


We don't actually need this, because modules are loaded only once. Thats one reason, I placed of things in modules.


XXX I think it would be good to understand for sure what the default permissions are on the pipe before shipping this.


A better example of how these events should be used in this integration sample, would be to clear the hog dictionary when a workspace is opened. Currently the hog dictionary will just go on accruing hogs as new workspaces are opened and closed, because the id will just keep increasing.


well because it was the easiest color


schema plus does not play nice with octopus. On rake db:migrate, the views will be generated in schema.rb but not the rest of the tables. Related #6


It is an oversight, thanks for catching it. I will fix it.


fixed


This might not be the exact right place to put this trigger. I'll investigate further.


Nice, I was about to send PR to all repos, but I was too lazy. :) Now only add hhvm-nightly.


nit: s/Pod/Pods? or just only log with pod name without the index?


Miałem na myśli namiastkę architektury wielowarstwowej, czyli wydzielenie do różnych metod logiki odpowiedzialnej za np. wczytywanie, przetwarzanie i wypisanie wyniku. Tak, aby metoda main składała się później w zasadzie tylko z czegoś w rodzaju:
`... inputData = getInputData()`
`...`
`... = splitIntoCoins(...)`
`...`
`printResult(...)`

Zostawiam kupę trzykropków, bo przekazywanie danych pomiędzy tymi metodami możesz załatwić albo poprzez pola klasy albo przez zwracanie jakiegoś nowego typu danych. Pewnie to pierwsze będzie łatwiejsze do zrobienia i będzie wystarczające dobre, żeby wyglądało lepiej. Uprzedzam jednak, że będziesz musiał trochę pogłówkować w jaki sposób przekazywać dane tak, żeby nie tworzyć takich zmiennych:
`double z200, z100, z50, z10, z20, z5, z2, z1, gr50, gr20, gr10, gr5, gr2, gr1;`
`double ilosc1, ilosc2, ilosc3, ilosc4, ilosc5, ilosc6, ilosc7, ilosc8, ilosc9, ilosc10, ilosc11, ilosc12, ilosc13, ilosc14;`
Na szybko przychodzi mi do głowy mapa, a że ważna jest kolejność to może LinkedHashMap nadałaby się do trzymania kombinacji: nominał / ilość.


No problem! Each enough to temporarily hack.


To keep es6.js from getting too big/unwieldy, we (well, @concavelenz) put Map, Set, etc. in a new file called es6_collections.js -- it looks like we forgot to add that file to the MOE config so it didn't get pushed to Github. Should be an easy fix. Thanks!


I've seen that comment in a discussion - but only later. So we can simply discard this pull request.


AFAIK, it lets us run (package-initialize) manually, and only once


Or you can fix it. :)


good point. just saw how easy it is to create a git with the tools, may shed new light on the autocreation issue


all your base belong to us


U sure?


Change ID to Name here? We pretty deprecate ID for Pod now.


@myoldmopar  If there isn't one alreaday, yeah, we should post an issue
to get rid of all of the deprecated fields (about 15 of them).  If think
they've been lurking there for a while.  Of course, that will mean a lot
of changes plus transitions.  We might want to keep the chiller flow
mode on the chillerheater, though.  It should be implemented to work
rather than removed.


super zmiana!


done


gnu radio


Added #9


reverted


Many apologies for the confusion @GawainLynch! I just needed something quick and hackish before the real fix comes out.


fixed


Without `expect(2)` this test will not check that BOTH `sendEvent` and `trackPageView` methods are called.


Done, `pod update` should solve your issues


fixed (I had merely rewrapped this paragraph)


Split te olmaz...


resetting @counter explicitly before control leaves the function/method.


r=eddyb


I've instead pushed a change that uses the popup menu in case the user wants to provide a patch name (https://github.com/magit/magit-stgit/commit/0a393088ec9dba094afbd042dc1f8f29f273c5bf)


Can I get @mhegazy to comment on whether or not this is still necessary?


Doesn't this commit break all other providers such as AWS or am I missing something?


removed @repeat atom.   I'm not sure where and how "repeat" was typed in there


Good point, fixed.


That's because formController and ngModelController use the same addSetValidityMethod ... method. formController however needs the `option/control` argument for its `unset` etc. functions, whereas ngModelController does not need it. I agree that it's not very intuitive.


It works. Thanks.


Just FYI, I'm considering to have a separate patch (not necessarily mergeable) with complete type reflection - where each type had different name (including different types of function). This change surely complicates such feature.


@Optimusprimeums thanks a lot :D


hi.


hello.


失礼しました。
この部分はまるごと変更していて、このdo-while処理がなくなっています。
最新のコードは、$giveme_countも$uncheckedUserID_countも使ってないです。
確認お願いします。


What is this `host` property used for? It's actually triggering a bug with 4-letter domains. See https://github.com/TelescopeJS/Telescope/issues/692


It's there: https://github.com/Deathamns/uBlock/tree/ports/xpi/platform/firefox

But looking at it I don't see the popup-specific code in `vapi-common.js`, so I guess for Firefox it's also going to be an empty js file.

The popup resize code is [in the main vAPI file](https://github.com/Deathamns/uBlock/blob/ports/xpi/platform/firefox/vapi-background.js#L727).


Add Tutorial 1


![Token selector is a blank input element](https://cloud.githubusercontent.com/assets/665387/5698208/516d97c6-99bd-11e4-9bd8-61420354a811.png)
Token selector is a blank input element. :frowning:


Do you really want the definition of these constants in the header file?


There's a trailing comma here.


It is expected that obelisk is not installed anymore with this script or is it a merge mistake?


Indeed. obelisk is obsolete, libbitcoin-server replaces it.


Thanks for your response.

Adding "-cdst" is kind of a workaround to support copying one file
and executing another command.
For example, if a.py is to be executed, the file to be copied is a.py but
the command
has to be cmd /C a.py.

My intention of adding "-cdst" is not to change any present command line
behavior. You may have a better solution.

2015-01-10 6:10 GMT+08:00 PA <notifications@github.com>:

> I'm having a hard time understanding this one. -cdst is to let you specify
> a different destination file name than is being copied. Is that correct?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/autoandshare/PAExec/commit/82e945cea648f6b0d1b4f2fe442b0b3d568db7c4#commitcomment-9226105>
> .
>


before:

[  3] local 192.168.0.101 port 60814 connected with 192.168.0.100 port 5001
[ ID] Interval       Transfer     Bandwidth
[  3]  0.0- 1.0 sec  3.25 MBytes  27.3 Mbits/sec
[  3]  1.0- 2.0 sec  3.88 MBytes  32.5 Mbits/sec
[  3]  2.0- 3.0 sec  4.38 MBytes  36.7 Mbits/sec
[  3]  3.0- 4.0 sec  2.38 MBytes  19.9 Mbits/sec
[  3]  4.0- 5.0 sec  0.00 Bytes  0.00 bits/sec
[  3]  5.0- 6.0 sec  0.00 Bytes  0.00 bits/sec
[  3]  6.0- 7.0 sec  0.00 Bytes  0.00 bits/sec
[  3]  7.0- 8.0 sec  0.00 Bytes  0.00 bits/sec
[  3]  8.0- 9.0 sec  0.00 Bytes  0.00 bits/sec
[  3]  9.0-10.0 sec  0.00 Bytes  0.00 bits/sec
[  3] 10.0-11.0 sec   512 KBytes  4.19 Mbits/sec
[  3] 11.0-12.0 sec  3.88 MBytes  32.5 Mbits/sec
[  3] 12.0-13.0 sec  3.75 MBytes  31.5 Mbits/sec
[  3] 13.0-14.0 sec  4.38 MBytes  36.7 Mbits/sec
[  3] 14.0-15.0 sec  4.75 MBytes  39.8 Mbits/sec
[  3] 15.0-16.0 sec  3.25 MBytes  27.3 Mbits/sec
[  3] 16.0-17.0 sec  0.00 Bytes  0.00 bits/sec
[  3] 17.0-18.0 sec  0.00 Bytes  0.00 bits/sec
[  3] 18.0-19.0 sec  0.00 Bytes  0.00 bits/sec
[  3] 19.0-20.0 sec  0.00 Bytes  0.00 bits/sec
[  3] 20.0-21.0 sec  1.00 MBytes  8.39 Mbits/sec
[  3] 21.0-22.0 sec  0.00 Bytes  0.00 bits/sec
[  3] 22.0-23.0 sec  0.00 Bytes  0.00 bits/sec

after:
[  3] local 192.168.0.101 port 60813 connected with 192.168.0.100 port 5001
[ ID] Interval       Transfer     Bandwidth
[  3]  0.0- 1.0 sec  6.12 MBytes  51.4 Mbits/sec
[  3]  1.0- 2.0 sec  3.88 MBytes  32.5 Mbits/sec
[  3]  2.0- 3.0 sec  6.50 MBytes  54.5 Mbits/sec
[  3]  3.0- 4.0 sec  6.75 MBytes  56.6 Mbits/sec
[  3]  4.0- 5.0 sec  6.12 MBytes  51.4 Mbits/sec
[  3]  5.0- 6.0 sec  6.88 MBytes  57.7 Mbits/sec
[  3]  6.0- 7.0 sec  6.75 MBytes  56.6 Mbits/sec
[  3]  7.0- 8.0 sec  4.50 MBytes  37.7 Mbits/sec
[  3]  8.0- 9.0 sec  6.75 MBytes  56.6 Mbits/sec
[  3]  9.0-10.0 sec  6.88 MBytes  57.7 Mbits/sec
[  3] 10.0-11.0 sec  6.62 MBytes  55.6 Mbits/sec
[  3] 11.0-12.0 sec  5.75 MBytes  48.2 Mbits/sec
[  3] 12.0-13.0 sec  5.75 MBytes  48.2 Mbits/sec
[  3] 13.0-14.0 sec  6.25 MBytes  52.4 Mbits/sec
[  3] 14.0-15.0 sec  6.25 MBytes  52.4 Mbits/sec
[  3] 15.0-16.0 sec  5.75 MBytes  48.2 Mbits/sec
[  3] 16.0-17.0 sec  6.75 MBytes  56.6 Mbits/sec
[  3] 17.0-18.0 sec  5.12 MBytes  43.0 Mbits/sec
[  3] 18.0-19.0 sec  6.12 MBytes  51.4 Mbits/sec
[  3] 19.0-20.0 sec  6.25 MBytes  52.4 Mbits/sec
[  3] 20.0-21.0 sec  5.38 MBytes  45.1 Mbits/sec
[  3] 21.0-22.0 sec  6.50 MBytes  54.5 Mbits/sec
[  3] 22.0-23.0 sec  6.75 MBytes  56.6 Mbits/sec
[  3] 23.0-24.0 sec  5.88 MBytes  49.3 Mbits/sec
[  3] 24.0-25.0 sec  4.88 MBytes  40.9 Mbits/sec
[  3] 25.0-26.0 sec  5.88 MBytes  49.3 Mbits/sec
[  3] 26.0-27.0 sec  6.50 MBytes  54.5 Mbits/sec
[  3] 27.0-28.0 sec  6.12 MBytes  51.4 Mbits/sec
[  3] 28.0-29.0 sec  6.12 MBytes  51.4 Mbits/sec
[  3] 29.0-30.0 sec  6.62 MBytes  55.6 Mbits/sec
[  3] 30.0-31.0 sec  6.50 MBytes  54.5 Mbits/sec
[  3] 31.0-32.0 sec  6.75 MBytes  56.6 Mbits/sec
[  3] 32.0-33.0 sec  6.62 MBytes  55.6 Mbits/sec
[  3] 33.0-34.0 sec  6.88 MBytes  57.7 Mbits/sec
[  3] 34.0-35.0 sec  6.50 MBytes  54.5 Mbits/sec
[  3] 35.0-36.0 sec  6.38 MBytes  53.5 Mbits/sec
[  3] 36.0-37.0 sec  6.62 MBytes  55.6 Mbits/sec
[  3] 37.0-38.0 sec  6.38 MBytes  53.5 Mbits/sec


not open door and others


Hmm... We could use existing build systems (which IMO totally overblown for just concatenating files), or make a little script (in Node.js or Python, shell, something).


this changes makes 8192ee has some ability to detect TRX hang and reset DMA when user disable/enable wifi


this change makes ping better in some environment


this variable is better in pci.h than in rtl8192ee/def.h


Voici ce que donne l'exemple dans le main:
![ast](https://cloud.githubusercontent.com/assets/9721016/5698281/8fcdb27e-9a0a-11e4-8705-bd0ca347a096.png)


when it just breaks rather than alloc desc again, rx desc will be starving and it causes rx descriptor unavailable


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3111
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3104
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3105
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3096
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3096
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3099
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3092
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3087
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2764
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2762
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1600
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1592


fast-forwarding master to auto = 4bed1e8c


this function parses C2H packet, which is a packet reported by firmware, such as BT info


add new firmware


This change make it possible to let 8192ee parse C2H packet.


You will make a join whereas there is no need to and it looks ugly (use a variable). Do something like:

Paiement.objects.using('rezo').filter(utilisateur_id=self.id_rezo).selected_related('ventilations').


啊，你說得對。被引用的 tables 中的 YAML 部分都會被忽略掉。
之所以這樣處理是考慮到不同 dict.yaml 文件中的設定會有衝突，創建另一個詞典來引用已有詞典的真實意圖可能只是要利用文件的碼表定義，同時改寫某項設定的值。比如改改 sort: 排序的方法，只有最外層詞典中的定義起作用。於是爲了一致性 import_tables: 也只取最外層詞典中的設定。


Without hStop, the typical return code at the end is ERROR_BROKEN_PIPE(109).

With hStop, the thread may end before last part of data is read.

Thanks,

2015-01-10 6:37 GMT+08:00 PA <notifications@github.com>:

> I'm not sure about this one. The intent was for the ReadFile to be
> asynchronous so both new data AND hStop could be waited on. This thread
> needs to end when hStop is set because pLP is a pointer to a stack variable
> in the master thread, so the master waits for this thread to shutdown
> before it cleans up its stack.
>
> BUT, looking at the code a few years later, I'm not sure that is what it
> is doing. The pipe was not opened with FILE_FLAG_OVERLAPPED, the pipe is a
> wait pipe, which also means ReadFile will wait until data is available.
>
> So the concern is not getting stuck in ReadFile when the master thread is
> trying to shut down...
>
> What return code are you typically seeing when ReadFile returns at the end
> of the remote session?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/autoandshare/PAExec/commit/e95fc12e1a7f18345d27aa165da93641f6bdaa84#commitcomment-9226460>
> .
>


A lot of TRX code have been changed, some bugs may be still there but is it more stable than ever.


This method now returns the number of babies to create rather than creating all of them by itself.


already fixed


function 1 of 2 to avoid tx hang when adhoc


function 2 of 2 to avoid tx hang when adhoc


I added this method to simplify the logic for making multiple babies.


Notice that embedded nodes are restricted by dots.
`````json
{"post": {"comments": {}, "tags": {}, "likes":{}, "unlikes": {}}
``````


Yes, here it will hit the database too many times.
See my inline note.

Should have been better to create a new branch for this one. Anyway, there is still some work to do (renaming the models attributes with meaningful names utilisateur_id -> user).

Try also to be consistent when using binary operators (spaces).


reset = seed


確認しました。いまは複数くださいされてもtodoがひとつしか発生しないので、この処理でOKですね。


Use that one. It's ok.

发自我的 iPhone

> 在 2015年1月11日，下午9:23，Abiel Zulio M <notifications@github.com> 写道：
>
> Then? Which .smali should i edit?
>
> Tried this one /home/fantastical/workspace/patchrom-new/taoshan/out/telephony-common/smali/com/android/internal/telephony/gsm/GsmServiceStateTracker.smali
>
> and after do command make fullota the .smali resetted like default one. What should i do now?
>
> —
> Reply to this email directly or view it on GitHub.
>


i think i miss someting position y no populate or metadata not work... any idea ??


saw approval from nick29581
at https://github.com/barosl/rust/commit/a0155444cff7f4f479c568b474057e6efb73502c


merging barosl/rust/no-type-for-node-ice = a0155444 into auto


status: {"merge_sha": "15a41380c14e94052332360b104ec1651f97297b"}


barosl/rust/no-type-for-node-ice = a0155444 merged ok, testing candidate = 15a41380


need to check this


@kkoopa why did you remove v8 namespace and replace with those specific V8 classes? Is this is a perf optimization or was this just to be more explicit?


Super neat!


yes master is failing. @andrei200287 I tried pointing to your fork but i get dependency issues while running pod install.


This looks good. Go ahead a merge locally to ensure everything is OK.


Hi ,I want to ask a question .
 I do not know how to build it .I tried many times ,but I failed again and again ,so I hope you can give me a favor .


Instead of 'removing' and 'reinserting' - lets just have the production controller handle the automatic build orders. The auto-'stuff' is really a special case. I am a little foggy on how it worked because I rarely used anything but auto-build minerals and perhaps a few mines or factories. (or rarely, defenses.)

As I recall, it works like this:
Auto Build Mines  : 5
"means build up to 5 mines each turn, as long as the resources exist and the planet can support 5 additional mines. Remaining resources will be applied to the next item in the queue."
> if an item was partially finished, it would be inserted into the list and work resumed next year. (Where inserted? Above the Auto Build orders that generated it?)


:+1: thanks @rgbkrk


Is there any known violation of Twitter policy by using this, and is it something they police?

E.g. if a user un-favourited 10,000 Tweets in a day, would that account suspended?


fix #278


fix #276


I was saying to_equal is more readable.


fix #280


Because we can have more than one listener.


fix #275


<!-- test -->


rename: bastion_key_path perhaps?


For now this is just an extra indirection, the benefit of extracting this function is not big enough, it might be one day, but not today.


Should this now read `"The input .purs files"`?


Unless this function can transform method names is descriptions if one was not specified :)


r+


Surface Minerals are actually one layer deeper. ** self.colony.planet.surfaceIron **
This is admittedly somewhat awkward. One solution could be that when ProductionQ is generated it also has a "pointer" at the colony's planet. Then **self.planet.surfaceIron** would be available.


resolves #279


![plot1](https://cloud.githubusercontent.com/assets/2916291/5698470/6bbd81a4-9a49-11e4-9458-0b509a9fa1c7.png)
read.table("household_power_consumption.txt", header=TRUE, as.is = TRUE,
           na.string="?", sep=";") -> power
 power$Date <- as.Date(power$Date, "%d/%m/%Y")

ind <- with(power, (Date > as.Date("2007-1-31")) * (Date < as.Date("2007-2-3")))
subdata <- power[ind>0,]

#----------------------------------------------
# plot1
png(file = "plot1.png")
with(subdata, hist(Global_active_power, col="red", xlab="Global Active Power (kilowatts)",
                   main="Global Active Power"))
dev.off()


r=nikomatsakis


We need to find a better name, this function description says it runs the tests lol

Maybe something related to hooks or preparation


I'll provide fixes later, too


develop (Myoldmopar) - x86_64-MacOS-10.9-clang-Debug: OK (1091 of 1091 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


85580152-VACScheduleCrash (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


hey @jlachowski Why did you decide to remove setting `MEMCACHE_SERVERS` here? Is there any alternatives?


tttt


Good point


Seems that this addon does not support `ga.js`, only `analytics.js`:
https://developers.google.com/analytics/devguides/collection/gajs/
https://developers.google.com/analytics/devguides/collection/analyticsjs/


Também pode ser clonado assim:

```
git clone REPO_URL devinsanta
```

E o nome do diretório ficará como devinsanta.

Podes fazer essa alteraração?

abs


Hello Daedaleus. Thank you for contributing.

I have to admit this is quite curious, I haven't seen :autoclose used in this situation before. I thought using the block form ensured that the files were closed instantly.

Do you have a test example which demonstrates this memory leak?


in fact we can ignore the changes from gadget except for android.c - the
rest isn't used anyway...

2015-01-12 20:01 GMT+01:00 Shilin Victor <notifications@github.com>:

> Does it mean that these changes
> https://github.com/mkaluza/kernel_common/wiki/TODO#check-and-merge should
> be re-applied to 3_0_72, without reading code?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChronoMonochrome/kernel_common/commit/cb0b2af4f5cabd075cb9d2c027c1df1649e18eb6#commitcomment-9246977>
> .
>


Modifying this file or the config file is equally accessible. It is better to keep it here because the `Nightly` class supports many other parameters (like `day`, `minute`, etc.). This file is already a config file, and it is less flexible and more repetitive to factor out these values into the JSON config file.


Good luck!


I have only advocated using public members for user interface elements.  m_iddObjectTypes is not that, so I think it should be private.


PS: Thanks for your confidence


I'll take it, but in general we prefer to alpha=sort these options (there can be so many)


a entendido, valeu fernando


This option still live in the example above.


@kbenne it is, at this date :)


hauhauahua satisfazer o git é foda! Acostumou com TFS e esta trazendo esse conceito pro GIT! :ghost:


Make sure the upgrade bbcode option on the install wizzard is checked when you run the wizard.


@hitesh96db : just remove the list_fields = list_fields (since you changed the list in-place), and it will be alpha-sorted again ;)


Örnek: http://jsfiddle.net/eLLv09pr/


Faz essa alteração no README, dâ o commit para eu fazer o merge :+1:


Tabs are evil.


LGTM. :+1:


Thanks for looking into this, I appreciate this.


This error was found after filling some time with programming the cmpsc.txt within the test directory. As said in the title, this change implements the correct handling of an error (exception) situation. I guess that nobody will ever trigger this.


For the first option, I agree that keeping config in one place is better. This change aims to just get nightlies to run: I have a proper config refactor on a different branch: `config-streamline-dev`.

For the second option, the list may be only a subset of all the builders in the future, so auto-generating from all builders won't work. Also, if we keep all builders and schedulers in the config file, we will need to start differentiating by Python class, which will end up in code duplication.

In short, I will keep this as-is because it works and is a very small change, and I am addressing overall config cleanup on the other branch I mentioned.


Ah, yes :)


@smarquespt This PR is a translation one. I'm checking the concordance between the translation strings and the the localized strings. Just that.


We probably should.


My IDE caught this, and I think it's using jslint under the hood.  So we should add that to the build process.  Clean jslint is very important.


fixes #4


It's an import for changes I was going to make but didn't yet. For cleanliness' sake though, you're right: I removed it in the latest commit (de1d16aa). Will add it when it is actually needed.


r=alexcrichton rollup


@mzanetti Should we start the timer in this case, or should we do an immediate connect and let the connection fail (/socketError) restart the timer?


to be consistent, "frame" and "unwinder" should be capitalized.


Please remove: Síguenos en "twitter", "facebook", "redsocialrusaoloquesea"


Too much wrapping! You're a regular Wrap Artist!


I've got sound dialog working, but i had to duplicate most of the onevent handling from guiFormSpecMenu. Dont want to do that for hotkeys and password change dialogs also. I'd like to rework those 3 dialogs as formspecs and use normal event handling. It's ok to that (don't know if there is a good reason for those being handled as they are right now)?


Confirm merge


Okay @nfeske , you're right: All RUN_OPT config will be in my custom amt.mk as it is nowadays. But should we really keep  both options - with and without prefix - then? I apprehend the positive educational effect will be nullified by knowing people always posting the shortcut variant.


Just a suggestion: why not put this line (```target_collection.update_attributes```) in ```EOL::Solr::CollectionItemsCoreRebuilder.reindex_collection```?  ...Seems like we'd probably want to do that every time we reindex anyway.

...Honestly, I don't think it's _ideal_, but I do think it makes sense.


wrong comment


sure the renaming is no problem.
However what about adding another overload with the same parameter structure and an extra unnamed parameter like
```
do_step(... , dxdt_version)
```
This would not need to be disabled and could also be called explicitly from within the initialize function and would not break the naming conventions?


/me votes for the highlander principal.


Nice work!


r=eddyb


Why is this commented?


actually this changed the width of the printing command by taking the log of the number of elements to find out how many digits in base 10 there are maximum possible.


I swear you're a magician or something. You'll suggest to something of which I've done already, but when I do it again after you suggest, suddenly it works. lol. Thanks, I did the install upgrade again and immediately did an application restart and then it worked. :)


ya I'll try to get to it


Could this simply be `to_enum.to_a`?


Thanks for the fork @BlackArbsCEO! Let me know if you have any questions, I'm happy to help.


I proposed: https://github.com/puppetlabs/puppetlabs-corosync/pull/102


Point free style is one of the things I absolutely fucking LOVE about F#. Such a natural way to express things.


LGTM.

I expect we'll bring this to HEAD by:

1. getting the change reviewed/accepted upstream
2. committing to FreeBSD HEAD
3. reverting this change from the ARM64 branch prior to our merge

I sent a ping to the upstream issue to try to move it along.


why the if/else (setting the same thing)


I will merge this because it's technically correct, but I don't think that these changes are what fixed the issues that the l34c was seeing. Most likely one of these commits fixed the crashes:
https://github.com/omnirom/android_bootable_recovery/commit/f9f99bcb62e569128d7bcb859bb5eed89a0bdf5a
https://github.com/omnirom/android_bootable_recovery/commit/4bfabab005bac62373b80407136b75509b8b57db


No objections.


Maybe something like this:
`handler: group.handler || handlers.main.handler({trackTransitionsAs: Addon.settings.trackTransitionsAs})`
?


It would use URL query encoding though (also split on `;`, unescape % encoded values, etc). And I would need to first replace `&` with `%26`. This seems easier.


I assume this is printf format warning clean; LGTM


[Yes](https://github.com/rom-rb/rom/commit/7b4d52b375bdbaf680a81c49fa5f29300e780c7a) :)


This is four spaces again. Please check our style guides, we use real tabs, no spaces.


Looks OK to me.
:)


There seems to be a problem with Vim (code editor that I am using).


true


topkek


This seems like an extra check, given the `match` and `next` calls below.  Take a look at http://codemirror.net/mode/javascript/javascript.js, which deals with `/* ... */` comments...


I am best at spelling.


Replace list etc. with array_like.


@suhr could this have been the issue? Sure seems like it!


Sorry, I was in a hurry. Promise to do it next time ;-)


@krepa098 you must have had some thought pattern for explicitly disabling this?


Last time I checked, this was you @R4PaSs that prefered FlatBuffer to String concatenation?


Here also


you could use the 'font-lock-string-face too


r+ rollup


JFYI: It seems like RuboCop is OK with aligned assignments:

```Shell
$ ruby -v
ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-darwin14.0]
$ rubocop -v
0.28.0
$ cat alignment.rb
a  = 1
ab = 2

a + ab # To avoid "Useless assignment" offenses.
$ rubocop alignment.rb
Inspecting 1 file
.

1 file inspected, no offenses detected
```


No need for signature if it's a redef.


r+


Yeah, if compilation fails we should add this, but I remember leaving the comment "Complex numbers are not yet supported (they would require explicit instantiation of CodeTree classes to complex)
" in there for a reason... If only I remembered.

There was a lot of back and forth to get the explicit instantiation working (so that the CodeTree class was usable outside FPOptimizer). So I lost track of the complex number issue.


With a FIXME here, you'll have my +1.


Well... they aren't :P


@bors: retry


This, by the way, makes eager loading not work for polymorphic associations. As far as I know, this is also the case in ActiveRecord, and without assuming things about key names, I don't think it's solvable.


The FIXME should also explain how a String.length can be negative....


Maybe this could be done by overloading the delegated `target_model` method. I wasn't sure how the delegating/metadata stuff is set up, and this worked, so I went with it.


Hmm, this obviously needs some work.


Thanks for the report, however your fix is incorrect since you are using prev_pos uninitialized here.


Yup, but in this case, I'm reading a message 100 chars by 100 chars, this either returns the message as-is or it creates a Rope, therefore, it is less expensive than a FlatBuffer !


jak protected to zrob property


git ;)


r=eddyb


а при чем тут coffeescript?


here is if missing


@skj3gg PackageControl is reporting that it can't generate because the version number is not recognized (https://packagecontrol.io/packages/SublimeLinter) is that why you made this change, or is this the change that broke compat? if the latter, I think it needs to read "3.0.0" and not "3.0" according to the alt text on the "Missing" badge at that link I just pasted.


Thanks, I published master.


я когда это писал `files = utils.anyToFile(item, settings) for item in value` думал что оно эквивалентно `files = (utils.anyToFile(item, settings) for item in value)`, а нужно было меньше думать и ставить больше скобок. или еще лучше писать на js, да


Those were terrible comments; glad you fixed them.


I added nightly to application, http, reflection and utils. Other repositories are green.


@scuben how is it supposed to work? Imagine supports resizing animated gifs. have you ever tested it?


See the docstring for that var. If you leave it set to the default value, the package system is initialized via the `after-init-hook`, which is too late for the ensuing code, and is redundant when we're calling `package-initialize` explicitly ourselves. So we unset the var to prevent `package-initialize` from getting called again unnecessarily later.


I had a hunch that wouldn't play nice with strong interpolation. Like "jdj
jdjd $<tab> hhj hg", but haven't tried yet.

On Jan 12, 2015 2:31 PM, "Sam Halliday" <notifications@github.com> wrote:
>
> you could use the 'font-lock-string-face too
>
> —
> Reply to this email directly or view it on GitHub.


hmm. i don't recall : possibly it shouldn't be : have you tried uncommenting ?


@dg but they still can make BC breaks by accident, so it makes sense to add `hhvm-nightly` to all repos, at least as `allow_failures`.


Haven't uncommented, but I'm trying now using
```clj
(set-error-handler! twitter-stream twitter-stream-agent-error-handler)
```
:)


Description of this repo.


Would be great if this was TRACE level


I switched to multiprocessing so it could run in the background, as
discussed last patch.  I will flake8 fix and force push.

On Tue, 13 Jan 2015 6:48 am Gonzalo Odiard <notifications@github.com> wrote:

> @quozl <https://github.com/quozl>, what you think about this? do you
> agree in merged it?
>
> @SAMdroid-apps <https://github.com/SAMdroid-apps>
>
> [gonzalo@localhost sugar-toolkit-gtk3]$ pyflakes src/sugar3/mime.py
> src/sugar3/mime.py:30: 'Queue' imported but unused
> src/sugar3/mime.py:35: 'GObject' imported but unused
>
> Just to know, why the change from GObject.idle_add to the use of
> multiprocessing?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SAMdroid-apps/sugar-toolkit-gtk3/commit/80546bb48b29a6a1ca75821431e5fd5db58e8426#commitcomment-9247767>
> .
>


nit: for consistency with the rest of the README add the $ to imply shell commands:

```
$ pip install -r ./osx_requirements.txt
```


On 01/03/2015 09:44 PM, Goran Milovanovic wrote:
> That looks good (as far as I can tell), but it doesn't seem to work:
> http://share-elm.com/sprout/54a8b4a8e4b05f9c59b24c93
>
> If you can figure out why, and fix the code to make it work in Elm 0.13
> (or higher), I will happily merge it in.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tmmcguire/bluepill/commit/9de59ec8f1c1b5bde480e9567c6ea863ca507d96#commitcomment-9144565>.
>

I'm afraid I don't understand what the problem is. Those where the
changes I needed to get it to work on a locally-installed Elm 0.13.
Maybe there's a bug in share-elm.com?

--
Tommy M. McGuire
mcguire@crsr.net


from goes first in each group of imports


-f após rm para evitar erro ao usar o Makefile dentro do eclips com a opção clean


a PR is welcome ! ( otherwise it will have to wait a while :)


Have you used the dev-master branch? I just made a whole pile of changes that should mitigate this issue, most notably, no more custom templates.


did you mean to commit this?


nah i didn't


ta jedynke daj do jakiegos consta


I have updated it to UInt16 with the latest commit to the pull request until we know more details.


@evanweaver one more note, we really should avoid putting implementation code in headers, it makes it more painful to rebuild when we have to change implementations


nice!


Wat.


IDFXT (Unknown) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.92405063291139%25-red.svg)


On Mon, Jan 12, 2015 at 10:52 AM, Paulo Lieuthier <notifications@github.com>
wrote:

> I really like this. We should do that everywhere, e.g. LXQtTaskButton to
> TaskButton. Anyway, I came here to warn that this commit introduces
> duplicate plugins in /usr/local/lib/lxqt-panel, because of the renaming.
>
Before installing a new build the previous  has to uninstalled: sudo xargs
rm < install_manifest.txt
It applies to all the renaming commits.


Fixed


Done.


I can't test the installer script right now, either way I'm not sure if this works on my system. Is it possible to use relative paths?


Yes, I did something similar.


I think we should move the template off the props and into the children of the tab.


well that's nice and dandy, but if I try and develop for this and run into npm problems, npm is going to just write into this file, git is going to pick it up as changed. Then I will commit -A as always do. To really remove a file from a repo for good, use .gitignore. You even have one ready. Just add a file to it.


This should be onTouchTap


Thanks, done.


Thanks!!


I meant slower because it's going from a dict, to a list of tuples which get yielded one by one, then converted back to a dict.

the extra conversion, then back to a dict seems wasteful, because calling as_dict() directly already returns a dict.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I was referring to the way WPP detects the connection index. The output is not interesting in this case.


Thanks for the explanation @jordangarcia!


reverts 489ae998814a9aeb6e50e4afd9e11e5de1dd11de


Hi Brendan! This is mostly a test comment to see what happens when I try to comment on a particular line of a commit. Let me know if/how you get notified about it. (And if anyone else gets notified, y'all should let me know too). But in other news, this is great. And you even figured out the somewhat bizarre ruby-ese of methods that have a ? in them.


IDFXT (Unknown) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


enrolling in cs100


Hehe, while I guess I can understand how this is technically shadowing, I don't see the point of warning about it.


What's the reason for capitalizing these/making them public?  The callers are in the main package.


Oui j'avais vue ca , d'ou la raison de faire une options pour l'utilisateur par defaut de desactivé le Chat
j'était parti sur de l'Ajax mais j'ai un probléme au niveaux de la récupération du Json ^^'


TeamCity CI Experiment :: Combine project PHP+Go [Build 4](http://localhost:8111/viewLog.html?buildId=15&buildTypeId=CiExperiment_PhpProject) is now running


TeamCity CI Experiment :: Combine project PHP+Go [Build 4](http://localhost:8111/viewLog.html?buildId=15&buildTypeId=CiExperiment_PhpProject) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 2 Build time: 00:01:03
### Failed tests
```
Project Test Suite: AppBundle\Tests\Controller\DefaultControllerTest: testIndex: <no details avaliable>

```


except I added a file that wasn't supposed to be in this commit. derp.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


TeamCity CI Experiment :: Combine project PHP+Go [Build 5](http://localhost:8111/viewLog.html?buildId=16&buildTypeId=CiExperiment_PhpProject) is now running


Sure. I'll rebase #323 accordingly.


Hi,

first of all, thank you for your contribution.

Some notes:
 * some of the functions should  be definitely shorter (applying the principles of clean code is more than welcomed)
 * I'm not sure about the correctness of license/copyright info (we should talk about it on tomorrow IRL).
 * remove HPUX support with that `yada-yada` message (and other `yada-yada` messages, too)
 * `acquire_syslog_pe_info` is not neccessary (this is OSE :-) )

And last, thank you again for your work.

L.


@unchris Sadly this was a change that broke the build.  I'm extremely sorry. Should see the changes soon.


TeamCity CI Experiment :: Combine project PHP+Go [Build 5](http://localhost:8111/viewLog.html?buildId=16&buildTypeId=CiExperiment_PhpProject) outcome was **SUCCESS**
Summary: Tests passed: 3 Build time: 00:01:02


would be better:
``where("title ILIKE :query OR body ILIKE :query", query: search)


:) so that's why everyone was looking at the radial one.


@dsyer What does binding to a Map do here? Is it to provide relaxed access to the environment? Would a `RelaxedPropertyResolver` work instead?


TeamCity CI Experiment :: Combine project PHP+Go [Build 6](http://localhost:8111/viewLog.html?buildId=17&buildTypeId=CiExperiment_PhpProject) is now running


Looks good to me, do you want to PR for me to merge?


85907178-MinOASchedule (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2164 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.8579259936044%25-yellow.svg)


TeamCity CI Experiment :: Combine project PHP+Go [Build 6](http://localhost:8111/viewLog.html?buildId=17&buildTypeId=CiExperiment_PhpProject) outcome was **SUCCESS**
Summary: Tests passed: 3 Build time: 00:01:00


Also added skip functionality for Dialogue


OK, but isn't the schema kind of buggered by Octopus anyway?


@gebart
How about it:
static inline uint32_t lptmr_get_cnr (void)
{
#if LPTIMER_CNR_NEEDS_LATCHING
    LPTMR0->CNR = 42;
    return (uint32_t)LPTMR0->CNR;
#else
    /* handle Z-Device */
    .....
#endif
}


Relative paths is possible but not recommended. You can download the installer I generated and run some tests. https://dl.dropboxusercontent.com/u/81699687/mlpack-setup-x86_64-1_0_12.exe

After installing it, you should be able to run all commands in mlpack in cmd.

If it works well, I will contact @rcurtin to set up the building and packaging system on his server.


85907178-MinOASchedule (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


To maintain code readability it's better to use uppercase in variable names :+1:


Hey Christoffer,

I actually write a DICOM testdata database with a huge amount of DICOM files (up to 500mb per DICOM object). While getting all tags I noticed that my software uses about 16gb RAM.
With smaller tests I compared my version with the original gem version:
Max used ram original: 2,4gb
Max used ram my version: 1,3gb

I don’t exactly know how to reproduce this memory leak but I think a good approach is to read an array of DICOM objects (about 2000, with single size of 500mb).

If you need any other help feel free to contact me.

Am 12.01.2015 um 21:03 schrieb Christoffer Lervåg <notifications@github.com>:
>
> Hello Daedaleus. Thank you for contributing.
>
> I have to admit this is quite curious, I haven't seen :autoclose used in this situation before. I thought using the block form ensured that the files were closed instantly.
>
> Do you have a test example which demonstrates this memory leak?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Daedaleus/ruby-dicom/commit/21cd55eee1cac86aef8613f121b3765a01af0e65#commitcomment-9248073>.
>


Iterables.getLast()?


Oh, I also think this would be better if the all and by_paid_date were in their own describe blocks.


Can you recheck this? It doesn't look correct and I get this as result:

```
 _ cat test.php; php test.php
<?php
$testUrl = "http://testurl/";
$title = "This_is_our_title";
echo "<a href=\"" . $testUrl . "\" download=\"" . $title . "\".mp3\">" . $title . "</a>";
?>
<a href="http://testurl/" download="This_is_our_title".mp3">This_is_our_title</a>
```


this thingie is OpenStack specific option only


-1 on replacing Optional with null


and see the next commit on this branch where I fixed this premature edit....


Maybe it would be cleaner to return chars written from `blackboxPrintf` ...


Should this have the v2- prefix to be consistent with the other classes in the component?


absolutely, this line was for saving the old instance_mode_mask field that was removed


I'm missing something. Were we already generating `Literal` and somehow the test used to succeed because the Bson was the same? Because I don't see any change to to generate it instead of `Eq`.


Yes. We're using `QGL::SingleBuffer` so `setAutoBufferSwap(true)` should have no effect.

> If on is true and the widget is using a double-buffered format, the background and foreground GL buffers will automatically be swapped after each paintGL() call.

Maybe `glFlush()` at the end of the `paintGL` method would be more appropriated? I could be wrong though.


It doesn't detect, WSTC writes that data to .pkt


Originally I had a FileExistsError, which is py3 only, but I changed it. Thus, this TODO is irrelevant.


¿El tema de los commits es relativo, no @JJ ?
No es que por más commits que hagas trabajes más, sino que si yo puse 15 issues, me suma 15 commits :P
Hemos trabajado mucho todos, y que diga "participó algo" parece que no ha trabajado lo suficiente el compañero cuando, en nuestro equipo, no es así. Todos hemos participado mucho y quería recalcarlo personalmente =)


If you're going to do that, why not just canonicalName.hashCode?


These are the answers from after we went over the quiz in class


Hello,
It would be appropriate to add "vehicle-use" for the minecart.


Seems like an overzealous warning to me too; there's no way any confusion wouldn't be safely caught by strong typing.  But fixing the shadowing does get the compiler to shut up.  :-)


wtf?!?


What was the behavior in ios8 before this fix?


This particular change doesn't seem to correspond to any changes in DxHistory. I am changing this back to make the syntax of the DxHistory call correct.


The operator styling is broken in firefox. Need to fix later.


Name change OK


Shouldn’t this be `LIdentifier { text.text; usePrefix = true; }`? (Same for `UIdentifier`)


https://github.com/TrinityCore/TrinityCore/issues/13890 related.


85580152-VACScheduleCrash (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2170 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13202375513933%25-yellow.svg)


OK, now I see this the test data, not the expected result.

Now my objection is: we need to update the selector phase to use `Literal` instead of `Eq`, because `$eq` is undocumented and may not work in future versions of MongoDB (it didn't work in 2.4, but does in 2.6).


So it looks better and more consistent :)


unnecessary condition. If search is blank, "where" query will return all records automatically


たぶんだけど、friend権限のない人にも、手元にない掲示版のタイトルが出てきて、かえってストレスになりませんかね？


@fprochazka: :+1:


Right. I think you can only prefix one "order of magnitude", right?

 so given I=1, V=5, X=10, L=50, C=100, D=500, M=1000:

950 is CML, and not LM