@hughmcguire and @bdolor - After reading more about accessibility on the web, especially for visually-impaired users, I withdraw my request. Most web designers now agree that links should not automatically open in new tabs/windows, and that individual users should make this choice.


DO NOT USE SUDO


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/01444022b0e4d48fbbff6f078d76e382c4aa5a22


merging Ms2ger/servo/runnable-self-by-value = 01444022 into auto


Ms2ger/servo/runnable-self-by-value = 01444022 merged ok, testing candidate = 879af966


comma after database


What was changed in the map, could specify?


chop extra newline


can put this on the previous line and break after `get_template()`


break as above


... because the {% ssi %} tag is deprecated.


instantiate


TODO: now that _with_js is deprecated, most of the old ugly stuff in the runtime can be removed.
TODO: remove all the GLSL stuff from the runtime.


It seems like this would make a bit more sense in the "Usage" section that follows, rather than in "Configuration".


Hoppas att jag inte kommenterat för mycket :-)


It worked! :smiley:


Sweet, in that case you can just remove this commit and it should work fine. Good work reporting that bug and getting it changed!


Please help. The date is 1-10-15 and inquiry is 11660 17996


Apologies, I didn't realise this repo required PR's


wow, that was hard :-D thanks :)


r.error will not return - so the redirect is pointless.


In plot2, plot3, plot4 instead of initials of "Thursday, Friday and Saturday" there are initials of italian translations of them ("giovedì", "venerdì" and "sabato")


This has caused numerous CS errors, what should we do @waneck ?


501 not 500


Not a huge deal, but actually doing a `nix-build` on a `shell.nix` fails with this (currently due to `src` not being set). Maybe `buildCommand = "echo env should only be used by nix-shell >&2 && exit 1"`?


I disagree with pooling all language files in a common package, mainly due to two reasons:
1) it wastes a huge amount of space to have translations around for luci components which are never going to be installed, luci already is too big for many standard builds
2) it does not work for modules hosted outside of the luci repository


a context dict?


@autopulated, is the clang+GNU toolchain used to build objective c files?


At least the reset modules would. I think load is still needed. The poweron/poweroff cycle has to be executed before the loading step, e.g. when using JTAG to load the files. Moving Qemu from exec into poweron should be no problem. It stands to reason if the current implementation of `execute_run_script` is the final form, though.


Parents


`key.length` will suffice


404 not 501


comma after "it"


Also in a standard build (release, snapshot) no language is expliciately selected, therfore all luci-i18n-* language packs are built, but not installed the image.

Setting any language to <*> or <m> will cause luci packages to depend on those languages, this is mainly intended for convenience when making custom builds.

I'm going to rework the luci gui soon to allow installing additional languages easily, this will take care of figuring out the proper ipk files to download.


What's the point with this variable?


FYI on my install, I get `Cannot extend basic class`, so I changed it to `implements ArrayAccess<String>` (in haxe-js-kit)


Doesn't make sense to me - why load a table but not use it?


Didnt get you


Doesn't make sense to me either - why would it crash?


comma after select_template


You are right, it is better to have an accessor function for the cases where one may want to check a certain condition from within a run script.


The event listener doesn't work... The function doesn't run


If series_id == r.id, then series = r.record


There are already accessor functions but I think I get your pattern. You want to remove any “global” variables and always an accessor function, even in the same module. I will change it accordingly.


Great! Do you have plans for a rolling spider (mini drone) example as well? Thanks!


does "than" seem wrong to you? either one seems okay to me.


Nej. Ser väldigt informativt och bra ut :-)


develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2177 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.4518044769301%25-yellow.svg)


We spent much time over the past few days trying to add this flag from the target, but it seems to require the build to be run twice before it is correctly honoured. This has been the only way found to fix the issue (so far).


Got you!


fixed


@QueueClassic/maintainers we now have a passing build! :green_heart:


:+1: great :) will try to build it asap :)


501 this one too - it's "Not Implemented" rather than "Internal Server Error".


yes


done


Just doors related to marid faction.


Oh welp. How could I have made this mistake?
Thanks for checking it out!


r.error sets the error to be popped out and redirects to the page? Is it something with 501?


I never encountered that usage. I'm reverting the change.


this all seems kind of odd.
Nginx should run as www-data
www-data should have access to mediawiki stuff
mediawiki stuff should be owned by mediawiki
nginx stuff should be owned by www-data (such as error pages)

otherwise the nginx role should probably be part of the mediawiki role, right now they are coupled everywhere


Do you consider `current_app`, `use_l10n`, and `use_tz` private options?


lepiej 0.upto(n) do |k| ; end


I understand what you mean, but nginx runs as mediawiki because other services which need a webserver (such as nagios and mailman) run under Apache. Ping @JohnFLewis


I must say that I don't really like that test, as it really depends on the specific implementation of the rewrite handler. For example, if someone would have used a different name for the dummy variable, a different string would have been resulted.

However, I can't think of anything better at the moment.


I understand that you haven't made bigger efforts to fix up the old code - so I won't comment on /all/ the issues that I see with it, but just on /your/ changes and critical issues of course.

That does not mean that the code is ok, though - it will still need more work. But maybe not from you.


feel free to keep, found this: "Different from is the standard phrase. Most scholars obstinately avoid different than, especially in simple comparisons, such as You are different from me."


Why rely on SwingUtilities? Executors.newSingleThreadExecutor().schedule(Runnable) should do the same (maybe even better..


`engines` is pretty much the compiled version of `TEMPLATES`; that's why I wanted to document it in this area.

I can move it to the bottom of the `Usage` section.

    Finally, you can use configured engines directly:

    .. data:: engines
        ....


Didn't know this feature somehow, thanks!


This looks like good stuff :)


OK


@addshore the playbook is a mess really. The nginx and php roles are mediawiki specific and are required by the mediawiki role. The other role include in mediawikiservers is hhvm - although this is not mediawiki specific.


done


all tests pass:
success: http://build.servo.org/builders/linux1/builds/512
success: http://build.servo.org/builders/linux2/builds/510
success: http://build.servo.org/builders/android/builds/548
success: http://build.servo.org/builders/mac1/builds/729
success: http://build.servo.org/builders/mac2/builds/729


No, r.error does the complete handling of the error - which can be different depending on the request.

Normally, for interactive requests it will redirect to a default page and display the error message on it. For non-interactive requests, it will raise a proper HTTP status code and a machine-readable (=JSON) response message.

In either case, it will not return to the caller.


fixed


100% for ilo, but what about r600g? As I recall, it worked well. Is there any specific problem on r600 I'm not aware of?


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2166 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.94929191411603%25-yellow.svg)


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Well I learnt something :-)


Cool!


fast-forwarding master to auto = 879af966


Lots of reasons could make it not work. It could not find an element with id "container" I guess, or maybe it wasn't there when the script ran. try adding $(document).load and putting your code inside that. Also use camel case, myFunction() instead of myfunction() :smile:


What is this commit message? Re up your commit message game and make it descriptive!


Good stuff again.  I'll see if I can get these integrated over the weekend :)


Anyway great job :) which files are remained to merge ? Could you send me unmerged patch, when you'll decide that there's nothing anymore to do with automatic scripts?


# CLI FAIL


Everything looks to be working.

What's the reason you don't put Spoiler in figcaption? Just find it to be bloat?


this shows all projects and tasks on the system, data should be associated to the signed in user


The plugin does not as a folder. The plugin remains .phar


I will try to follow this style.

but just wonder, are comas required?


@addyosmani Why don't we default to `mobile`?


Even minor reports matter. :]


Is it a better idea to have GetString as:

char* GetString();
Then we search for the '\n' to replace it with EOF?


99% of the change is due to the 'formatter'. I added only the following line (line number 475) :
if (cnstNode != null)


how is this better than `Project.new` ?

did you mean `current_user.projects.build` ?


saving 2 times? :trollface:


did you mean `current_user.projects.build` ?


DRY, don't forget about `before_action` filters


Can you check if this should also be changed in **NxMapGuide.lua** on lines [1214] (https://github.com/Rythal/Carbonite/blob/master/Carbonite/NxMapGuide.lua#L1214), [1395] (https://github.com/Rythal/Carbonite/blob/master/Carbonite/NxMapGuide.lua#L1395), [1483] (https://github.com/Rythal/Carbonite/blob/master/Carbonite/NxMapGuide.lua#L1483) and [1555] (https://github.com/Rythal/Carbonite/blob/master/Carbonite/NxMapGuide.lua#L1555).


I'm pretty sure Side.SERVER means the dedicated server only, so it will fail in single player. See http://www.minecraftforge.net/forum/index.php/topic,22764.0.html


you can do `<li class="<%= 'active' if current_page?(some_path) %>">whatever</li>` as well

also you can create a helper method with that in mind


So no redirect for this. How do we know when is it non-interactive and when not?


r.error knows - you don't need to take care of it.


This code has been causing problems for me as well.  I was thinking about modifying it to use the vector catch instead of a breakpoint.  That way an extra breakpoint isn't used, the hardfault handler doesn't need to be read, and it never needs to interfere with the target.  I might have a patch for this later this weekend.


Misspelled "canola"?


do we really need `@projects` here?


what if `save` fails? (maybe a required field validation)


...i.e. you use r.error regardless.


So when redirect after r.error and when not. I know I am disturbing you too much but thanks...


You should replace it by `$(unpacker_src_uri_depends)` instead as `unpacker.eclass` does not automatically depend on `app-arch/unzip`.


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3096
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3089
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3090
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3081
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3081
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3084
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3077
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3072
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2749
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2747
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1585
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1577


fast-forwarding master to auto = 099b411e


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2174 of 2189 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.31475559616263%25-yellow.svg)


Let's try and use the `opt_` dirs if we can.


You never redirect after r.error - because r.error will not return to the caller. You just do r.error and nothing more.


Fixed typo


you can use f.collection_select instead, it already provides fields mapping


@modwizcode, ignore this line


So can we use session.error, if I dont redirect after r.error where will it show the alert msg


You do nothing else about errors than calling r.error(), no session.error, no redirect - r.error() will take care of everything as suitable for this request.


In the mockup, this reads "# Reported" (number reported). Probably not a big deal though.


refactor this on controller, you could load `project.tasks` (bonus if it uses `.includes() for this association`)


Just make sure you pick the right status codes - since many clients implement automatic handling (especially for 4xx codes, which indicate a client error).


:eyes:


Don't you need to escape the less-than symbol? `< 0.1%`


**SideCI-STG / RailsSecurity - Security Warnings**
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting/) Unescaped model attribute rendered inline
app/controllers/projects/merge_requests_controller.rb:31
[Cross Site Scripting](http://brakemanscanner.org/docs/warning_types/cross_site_scripting/) Unescaped model attribute rendered inline
app/controllers/projects/merge_requests_controller.rb:32

[Click here if you want to see all Security Warnings](http://www.codemagica.com/github_repositories/18295016/security)


:trollface:


Why is that a problem?


I see. Right, I've though of it too, may eventually help you with it.


Maybe print a deprecation warning here?


This looks like code that'll never be executed (probably the previous return statement)? Should probably be removed, no?


You mean semicolons? JS doesn't require them but I'd like to have them for consistent syntax.


Could you make a PR to MPB with any corrections? Let's first make sure the tests are correct and then we can fix the solver behavior.


NB requests can be generated at the back-end from inside another request. Thus, a method handler can never know where the request came from - and hence not decide whether to redirect on error, nor where to redirect, nor how to display the error message.

Therefore, method handlers shall *never* redirect - but always report the error to the framework (=r.error), and let the caller decide what to do.


W00t, W00t! :) :+1:


check it pls, lot of refactoring


Yes, semicolons, sorry.

In my opinion code looks little better without them. But I see you, I will use them for aurelia.


GetRealMapID is to return your mapID of the current displayed map, and changes if your browsing other area's or maps outside your current zone.

GetCurrentMapId is to return your current zone always as much as it can track and figure it out.

You can't always use one or the other as certain things need to adjust based on which map your looking at, and other's are dependent on which map your actually on.


I agree to keep luci small.

The current make creates a dependency inside the ready build package in the wrong way around.
If you decide to install luci-app-firewall all luci-i18n-firewall-xx files are pulled and installed.

It should be the other way around.
If you decided to install luci-i18n-firewall-de then luci-app-firewall needs to be pulled and installed.


Yes: they aren't documented and I don't have a particular reason to make them public.

Also `current_app` is deprecated.


Okay got you thanks :), will be getting to your suggested changes in some time, well for T.lazy thing I would need @flavour's help.


Will this be on a separate branch like the other FG versions?


@Walkman100 lol.


from this oen on.. the "current" will be the master branch


These lines broke compilation for me using the Intel compiler. I’m getting:
`error #8259: The type bound procedure definition statement must contains only one binding name.`
I’m using
```
/usr/bin/ifort -V
Intel(R) Fortran Intel(R) 64 Compiler XE for applications running on Intel(R) 64, Version 15.0.0.077 Build 20140716
Copyright (C) 1985-2014 Intel Corporation.  All rights reserved.
```


this shows projects from another users :scream:
it should be scoped to the signed in user


you can build this association by using `current_user.projects`


:+1: Cool


Why move out of the `Controller` and into the `Model` instance? This feels wrong (although it does work of course).


try to use better names, this makes code unnecessary complex


That only happens if you select all those languages. If you do not select them, then there is no dependency emitted.


I'd prefer this to be in and handled the `Controller` which is what the `View` interacts with.


@larrymjordan this is awesome! great catch, looking forward to merge this just let me know when it's ready


what if save fails? (maybe a model validation)


this should be restricted to signed in user data


@rromanchuk I am waiting to hear from @Jur4s.


this logic can be extracted to an instance method


I wasn't sure the proper way to do this


what if it fails? we should be displaying friendly messages to end users


Yes, the figcaption is wide enough already.


The T.lazy=False is bad because there are circumstances under which you don't reach the T.lazy=True. It it therefore better to use str(...) for cases where it shouldn't be lazy rather than modifying it globally in T.

However, it could very well be that recent versions of xlwt do that str(...) automatically - and thus I wonder whether that is at all necessary.

And in principle, the LazyT class should be 100% transparent to the str class - at least in more recent web2py versions. Maybe that was not always the case - but I think it is worth to investigate it.


project_id :trollface:


do this actually works?


there is a logical error, dbus-uuidgen fails because there is no dbus present on root-image.
It must be called after mkiso.


Interesantno, na eclipsi prikazuje sve da je poravnato, a ovdje na gitu je razbacano, ali su ctrl + F i novi commit riješili problem :)


again, try to use better names, it makes the code unnecessary complex


you can refactor the source query to avoid returning a hash, use joining+select instead, so you get an object collection here


Yeah on it, we also have option to just disable it for one translation --> T("some text", lazy = False) that indeed is same as str(T("some text")). I prefer previous one? but still checking the code such that it does not need one!!


:D


you need to add the package name: `PACKAGE=cohttp` as you are trying to install other packages using it.


Yes, that is a good idea, because then people who try this get a clear error message instead of something that looks like Nixpkgs is broken. Would you like to do the change?


This gets rid of the hacks previously used for THUMB instructions.


also OCAML_VERSION=4.01 (not trailing .0)


Thank you for the update!


I haven't thought about the relationship between `haskell2nix` and overrides / patches yet. Clearly, it's a good idea to get notifications when an update affects a manually added bit of the configuration. I'm just not sure how to implement that.


nice try


Normally I do not think all of the options would be stored in the serialized `Model` instance (?).
I can understand *why* you did this, however I don't really like it.

The `Controller` should handle this and interact with the `View` and the Model` should only ever know about it's own value(s).

---

To ensure that the `configuration` Options are available, I would have checked if the selected option for this `Model` exists in the currently available options in the `Controller`, and if not, merged it into that options array.

A feature we have discussed for in the future is `Sub-Systems`, such that we could have a `Sponge` file/`Model` embedded into another `Model`. In the same way I would *not* want to save the embedded document and instead *would want to* save the reference to that other required `Model`.

How I would have implemented this would be to provide a `requirements` array for resources that require loading and leave it up to the User to load those resources. Even without those resources loaded, this `Model` would still have enough information to render itself, and if the User wants to change it's options, they must load those options.
In the same way the User would load all of the Models such that they could be applied as `Sub-System/Model`s, I would not suggest pre-loading *all* of the potential `Sub-System/Model`s such that the User could load the `Model` file and select those options.

This workflow may be slightly inefficient, so from there I would suggest using `LocalStorage` to allow Users to remember what `requirements`/files they wish to load at init. For instance, you work at Mozilla, therefore always load `X,Y,Z,` options and `Model` at startup.


Hmm. Yes, use of '<nixpkgs>' is a a hack. The real solution is to expect the path to the Nixpkgs repository on the command line: https://github.com/NixOS/cabal2nix/issues/120.


Here for example: if you use:

    sheet = book.add_sheet(str(T("Responses")))

...then this would go into xlwt as str not T - hence no T.lazy = False needed.

But as I say - it is questionable whether that is needed. Modern T supports all standard string serializers, and unless xlwt uses a non-standard serializer, it should perhaps just work?


@akshay2000 looks like a copy/paste was missed here. The "see all movies" bloxk has the same Uid as the "see all shows" one, so the text under movies header says "see all shows."


Facepalm. I'll correct it.
On 11-Jan-2015 12:23 am, Christian Prescott <notifications@github.com> wrote:@akshay2000 looks like a copy/paste was missed here. The "see all movies" bloxk has the same Uid as the "see all shows" one, so the text under movies header says "see all shows."

—Reply to this email directly or view it on GitHub.


My concern is when editing files in other directories. For example if I open a file in `test/some.file.cpp` it seems the substitution fails entirely.


Added fix in https://github.com/niklasvh/html2canvas/commit/7a58ad019fda793ba7c4b573ac4dff25426d2129


did I get anything right? :)

> On 10 Jan 2015, at 18:51, Thomas Gazagnaire <notifications@github.com> wrote:
>
> also OCAML_VERSION=4.01 (not trailing .0)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/avsm/ocaml-cohttp/commit/7d2713b7700eda9c72dd54cb9d3fb4db3dddd5f3#commitcomment-9230579>.
>


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think this is a required feature. Although it may be inefficient, a user may be new to the company and not have the required configuration file. By including it in the save data the user doesn't have to worry about loading two separate files to view a model


I see no issue here with systemd:

Optional dependencies for plymouth
    ttf-dejavu [installed]
(403/404) installing plymouth-theme-manjaro-el...  [######################] 100%
(404/404) installing adobe-source-sans-pro-fonts   [######################] 100%
  -> Cleaning up what we can
warning: database file for 'core' does not exist
warning: database file for 'extra' does not exist
warning: database file for 'community' does not exist
warning: database file for 'multilib' does not exist
  -> Copying xfce-overlay ...
  -> Congiguring SystemD ....
  -> Setting cronie ...
  -> Setting cupsd ...
  -> Setting tlp ...
  -> Setting tlp-sleep ...
==> Done [xfce installation] (xfce-image)

Tested with manjaro-tools-git r512.6bf1736-1


Note to self: test before pushing next time


:heart:


If you would look at the code ...

<pre># $1: chroot
configure_machine_id(){
# set unique machine-id
    msg2 "Setting machine-id ..."
    if [[ -z "$(echo $1 | grep root-image)" ]];then
	chroot $1 dbus-uuidgen --ensure=/etc/machine-id
	chroot $1 ln -s /etc/machine-id /var/lib/dbus/machine-id
    else
	mkdir -p $1/etc
	mkdir -p $1/var/lib/dbus
	dbus-uuidgen --ensure=$1/etc/machine-id
	ln -s /etc/machine-id $1/var/lib/dbus/machine-id
    fi
}</pre>


Another way a Windows user can address this is to save the Rmd file "with encoding" before pressing the  "Knit HTML" button.

```
File -> Save with Encoding ... -> ISO-8859-1 (System Default)
```

And you may want to check this checkbox to make this the default:

```
[x] Set as default encoding for source files
```


Yay, green build! You kept the skip you added still right?

There is a PR regarding that test for # of connections.

On my phone but main reason not to remove it was because we.might be leaking connections. Thanks for your work!!!


The redis block should be in `cmake/Modules/FindRedis.cmake`.


loading projects from all users?


do we really need this controllers?


Суть такова: на тиниборде, если в треде единственным потомком является оп-пост, то разделитель <br class="clear"/> отсутствует. И происходит вот такая хрень:

```html
<div class="thread" data-board="7get" style="counter-reset: de-cnt 1;" de-thread="null"></div>
<div de-oppost="">
...
```

Оп-пост выносится за пределы треда.


what is attribute? I don't see any related on sign in view


Investigated it:

    # works fine with LazyT:
    sheet = book.add_sheet(T("Responses"))

    # Does not work:
    sheet.write(0, 1, T("Example"))

    # Does work:
    sheet.write(0, 1, s3_unicode(T("Example")))

So, it is basically just the sheet.write() call that needs the contents string converted. And whether you do the conversion by calling s3_unicode() or by setting T.lazy = False doesn't make a difference performance-wise (either triggers a translation lookup and conversion into unicode) - but calling s3_unicode() wouldn't manipulate the global T.


I don't see why do you need to extend all this controllers, any specific scenario I haven't see?


visibility:hidden;


revert change?

I still fils for me btw.
So there is something else wrong if it builds on systemd.


I do it ...


No worries, I know.

How I would have done it, from [my comment below](https://github.com/mozilla/seasponge/commit/edc8f86f8e0541d47a70b3e3e3539c17fc6bb916#commitcomment-9230585):
> To ensure that the configuration Options are available, I would have checked if the selected option for this Model exists in the currently available options in the Controller, and if not, merged it into that options array.

It accomplishes the same thing, however I'd prefer to keep the `Controller` handling this and also silently "fail" (or even notify User that they should load a `config` with those options) and keep the `Model` storing only data that is directly pertinent to the `Model`.


T("...", lazy=False) seems more adequate than str(T("...")) indeed.


...but you may not have the T() call inside the method handler (e.g. because the T is returned from a subfunction call) - and then you do need the str() - or actually better s3_unicode().


Yes, it works just fine with systemd: http://pastebin.com/gUEwzVW5 Seems to be an openrc issue after all.


I meant to do a pull request instead of pushing directly, so sorry if I messed you up. But, since this is an important fix (Thunderbird is currently mostly broken by 1.4.5 updates), I'll just leave it.


Can you use SVG here instead? Then we can just reference https://github.com/walterbender/turtleblocksjs/blob/master/icons/plugin-button.svg
(or is the problem that is it white?)


Also, if you were going to do it this way (`Model` has the options, instead of `Controller`) then be sure to store these on the [`Model`'s Class variables](https://github.com/mozilla/seasponge/blob/edc8f86f8e0541d47a70b3e3e3539c17fc6bb916/app/scripts/services/model.coffee#L15):

```coffeescript
# Class Variables
# Note the prefix `@` will make this available on the `Model.constructor` (a Class-like variable)
# `Model.constructor.dataClassificationOptions` = Class variable, available on the class of all instances and not this single instance that could be changed and not changed to other instances.
@dataClassificationOptions: [
# options...
]
@securityControlOptions: [
# options...
]
```


Could you please update this to fix the indentation issue? I also recommend placing the new fields just before the `created_at` field for consistency.


e.g. here there is no T()-call where you could set T("...", lazy=True), so in this case, it's indeed:

    s3_unicode(widgetObj.fullName())

(Note the non-pythonic variable names here - it should be "widget_obj" not "widgetObj" and "full_name" not "fullName" => PEP8).


You don't need this since the ol is empty anyway.


## This is a secondary heading


Similar here (naming convention) - "survey_getWidgetFromQuestion" is a function, so it should actually be "survey_get_widget_from_question" (underscore in Python, not camelCase).

This is a very widespread issue in this module.


### This is tretiary heading


Fixed.


Here's another PEP8 issue: should have a blank after comma:

    sheet.write(row, col, qstn["code"])


"qstn_list" not "qstnList"


complete_row not completeRow


But now I am commenting on legacy issues ;) not your code, I know.


Looks good! I'll merge and try to refactor the `checkIllegalArguments` so it accumulates errors.


Fixed


i would like to remove empty line


[CodeMagica/RailsBestPractices] remove unused methods (Spree::PromotionAction#accumulated_total)
reference:


thanks just seen all those tweaks. i will try to test and merge


Do you want to have a seperate file for each library or what?


"widget_obj.get_list" not "widgetObj.getList"...


Hmm, the changes are a little more invasive than I was expecting.

I think we might be better off having 8.1 versions of WindowsPhoneSystemInfo, WindowsPhoneAutoMeasurement and WindowsPhoneEnvironment rather than #if's

Also we'll want to make the Windows 8.1 background requester not return a task - that is too leaky into the base abstraction.   It's okay to block on it as the requester is already on a background thread.


[CodeMagica/RailsBestPractices] remove unused methods (Spree::PromotionAction#create_adjustment)
reference:


[CodeMagica/RailsBestPractices] remove trailing whitespace
reference: http://rails-bestpractices.com/posts/60-remove-trailing-whitespace


If we don't have any image we need to remove the thumb.

BTW, it's good to have an image to every blog post. Let's try to ping some of the designers to that. It not possible that's ok to go without an image.


I'm updating the thumbnails adding Lucas and Victoria. Will push that soon.


u"Original" not unicode("Original") - why first create a string then convert into unicode?


I think the connection to the front administration have to be the end of the day 1.


Yeah will run a pep8 script if possible, please give me some time but :).


...and yet - what's the difference between "Original" and u"Original" in view of sheet.write? Nothing I can see.


@sfan5 Yes, that's how we do it.  See the other files in that folder.  It reduces the length of the main file and you can use `find_package_handle_standard_args` for even more code reduction.


r+


Ha! I can't give you time nor take any time from you - you come back with something when you feel you have something ready - or you don't come back. Your decision - your pace. You're not working for me. I am only reviewing your PRs.

Whether you come in an hour, in a day, a week, a month, a year, or not at all - all the same for me.


One can use a CNAME'd Custom Origin (e.g. bucket.example.com), it doesn't have to be in s3-website.amazonaws.com.  This won't match those at all, I believe.


@mdomsch It doesn't seem like there is a reasonable way of detecting that, is there?


I'm not shure that the "easy install method" is the most appropriate for this tutorial. With a "manual installation" we can explain the role and describe some ymls like bootstrap.yml.


saw approval from nikomatsakis
at https://github.com/mahkoh/rust/commit/a03ae681d3f52ca6a6aaf7ebfd32a51af6d4e4da


merging mahkoh/rust/as_mut_vec = a03ae681 into auto


status: {"merge_sha": "9fe747937a57a8bdb5510016d96fdcb15b9077c0"}


mahkoh/rust/as_mut_vec = a03ae681 merged ok, testing candidate = 9fe74793


We can complete to with how to change the location of this folders.


unrelated changes?


Yeah true that but there's a lot of knowledge difference between us which makes me kind off working for you. ;)
But I will surely refactor survey module, it wood be good if I make a seperate PR after this gets done and everything starts working with S3Method.


this ist for issue #11


thanks guys. its been fun :) season is almost over. go cowboys ;)


this is for issue #24


Hilftfunktion für daemon_runner.daemon_context.files_preserve


Good teasing !


Creo que este end tiene que ir debajo


ye, plz add sql :)


Not anymore, because they are natively interactive `<a>` and `<button>` elements. If it was `<md-button role="button">`, the answer would be yes. ngAria usually adds `tabindex` to anything with `ngClick` but I think it would be removed with this change. Not a worry with native elements, though.


Wait ignore this for a minute. Changing the drill verb.


I think we have to keep that for the day 2 site conception.


Vjerovatno je problem u mješanju tab-ova i space-ova za poravnanje kôda i nekonzistenciji u tome koliko space-ova je tab dugačak. Problem star koliko i informatika http://c2.com/cgi/wiki?TabsVersusSpaces


jeśli jest nie potrzebne wyrzuć, nie komentuj.


Hm... this implementation in the async.db library does not seem very scala-ish. Maybe we could patch it nicely :smile:


jeśli jest nie potrzebne wyrzuć. nie komentuj.


This link is broken.


We can use the bucket name to do a CNAME lookup, right?

On Sat, Jan 10, 2015 at 1:23 PM, Jonathan Rudenberg <
notifications@github.com> wrote:

> @mdomsch <https://github.com/mdomsch> It doesn't seem like there is a
> reasonable way of detecting that, is there?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/titanous/s3cmd/commit/ae274d401d7a66a145fbc80c3433b1ce06397aca#commitcomment-9230715>
> .
>


They will be able to view a model by only loading only the Model file (see my other comments). It's changing to another option that is not default that they will not be able to do, until they have their options file.

—
Sent from Mailbox

On Sat, Jan 10, 2015 at 2:56 PM, Joel Kuntz <notifications@github.com>
wrote:

> I think this is a required feature. Although it may be inefficient, a user may be new to the company and not have the required configuration file. By including it in the save data the user doesn't have to worry about loading two separate files to view a model
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/seasponge/commit/edc8f86f8e0541d47a70b3e3e3539c17fc6bb916#commitcomment-9230608


Merged this and the previous commit.  Watch out, I changed some names to fit Resharper's naming conventions, without which I don't stand a chance of being consistent :)


Yes, could do a CNAME lookup of the `DNSName`. I'm not familiar enough with Python to attempt that.


Examples of dynamic programming


could you add a test for this?


I ~~almost~~ always have good ideas ;)


I think KINETIS_RNGA is the proper identifier, can I rename it?


@mcostalba
i think it is no longer always true that "eval = v + tempo" after this commit
https://github.com/official-stockfish/Stockfish/commit/9cae6e66ce00850086d1bfe1e24e34442c12b206


@jhersh what does this do?


So what if it is NOT an anchor and is `<md-button role="button">`, then we should inject `tabindex="0"` right ?


`@amp;`?


@evaleev Are you sure that complex tensors are serialized using bit-wise copy? I am outdated, but it used to be that boost does not do bit-wise copy for std::complex\<double\>*. I think I opened an issue and closed it but I do not remember much.


Is the  $(BINODIR)/%.bin: target in app/Makefile as well really necessary?
On my ubuntu esp-open-sdk environment it is enough to have it in the root Makefile.


What about making this function return a `Option<&'a str>` with the message?


im pretty sure i merged the 4 extra commits correctly, but the channelselection list is too small itemheight and text, its not obeying skin code.


Found the issue, this is related to reusing the same PHP file with different content. HHVM will compile it once and not check again if content changed.


this would become:

```rust
let message = match report_on_unimplemented(...) {
    Some(msg) => msg,
    None => format!(....).as_slice()
};
```

(or something along those lines)


What is this?


Why yellow folders? It seems odd to not use the blue that's in use on the Mac elsewhere.


Well, `String`, but yeah, sure :)


first change added miller


Isn't there a helper function that does all this somewhere? I mean, a function that gets a message out of an attribute item. I think I've seen it somewhere but I could be wrong. If not, I believe this is a common enough case to have it in its own function.


@segiddins obsessive-compulsive linting of headers :) Makes sure the file name in the comment matches the actual file name, counts number of lines in the header comment, etc


Not that I could find.

I plan to look for some more general use cases and if they exist make this more generic.

(In it's current form it's rather specific for traits, a lot of things will have to be moved around for other defs that have type params.)


What information should I provide you?

connection.log contains these data:

1/10 22:43:00.244  Login program=WoW platform=Win locale=enUS
1/10 22:43:00.338  Component WoW.Win.19342
1/10 22:43:00.375  Component WoW.base.19057
1/10 22:43:00.432  Battle.net is Component Bnet.Win.37165
1/10 22:43:00.475  LOGIN: state: LOGIN_STATE_CONNECTING result: LOGIN_OK
1/10 22:43:04.512  Failed to resolve arctium
1/10 22:43:04.875  LOGIN: state: LOGIN_STATE_FAILED result: DISCONNECTED
1/10 22:43:04.930  Login program=WoW platform=Win locale=enUS
1/10 22:43:04.958  Component WoW.Win.19342
1/10 22:43:04.986  Component WoW.base.19057
1/10 22:43:05.016  Battle.net is Component Bnet.Win.37165
1/10 22:43:05.127  Client Disconnect due to reason:8
1/10 22:43:18.334  LOGIN: state: LOGIN_STATE_CONNECTING result: LOGIN_OK
1/10 22:43:20.737  Failed to resolve arctium
1/10 22:43:20.763  LOGIN: state: LOGIN_STATE_FAILED result: DISCONNECTED
1/10 22:43:20.791  Login program=WoW platform=Win locale=enUS
1/10 22:43:20.818  Component WoW.Win.19342
1/10 22:43:20.874  Component WoW.base.19057
1/10 22:43:20.904  Battle.net is Component Bnet.Win.37165
1/10 22:43:20.982  Client Disconnect due to reason:8
1/10 22:44:27.788  LOGIN: state: LOGIN_STATE_CONNECTING result: LOGIN_OK
1/10 22:44:30.077  Failed to resolve arctium
1/10 22:44:30.116  LOGIN: state: LOGIN_STATE_FAILED result: DISCONNECTED
1/10 22:44:30.143  Login program=WoW platform=Win locale=enUS
1/10 22:44:30.170  Component WoW.Win.19342
1/10 22:44:30.198  Component WoW.base.19057
1/10 22:44:30.229  Battle.net is Component Bnet.Win.37165
1/10 22:44:30.282  Client Disconnect due to reason:8


It is recommended to set web_host to "localhost" and use a portwarding to prevent public access. You will also not have to worry about firewall settings.

But to make it easier to start with default web_host is changed to all IPs "0.0.0.0".


The bracket syntax is C99. Do all our platforms support this?


Should now work on Windows #3


Does this require an extra step then on Ubuntu—to install pip—since it's not there by default?


Just as a note it wasn't that the change actually broke the build itself. Instead it allowed the annotation processor to actually run fully. In which it was setup to crash the build to test if it was actually running.


Semi-related...  I've actually had this in my repo for a while and forgot about it.  I swapped the order because GCC 4.8 would compile `[[deprecated("foo")]]`, but would throw a warning about "unsupported attribute" every time HeadSpin.h was included.  Thus, I changed the order to prefer the version that GCC has always supported to the C++14 attribute.


@segiddins surely right up your alley? You might also enjoy the `fui` gem, another part of all my apps