status: {"merge_sha": "56ee93164890302d6ffad7c1be1c125f955a45d4", "rollup_pulls": [[21077, "b90028d77092e30fb89b416ac06c847e1fce359a"], [20463, "9f5fc563d3d592d5e44ab71759ffa26d326b3daa"], [20632, "4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d"], [20892, "9302dc5d9e13f716a21a5d9ebdcddc149a864b19"], [20929, "eabf2082856668c75ed6f7c229b24fb7755440bc"], [20964, "78b7e13bf02e59ad05a9d15725e3c36e9dcf7187"], [20976, "415fc5f0f10b6180193ecd309b21ae80a1efa6a9"], [20985, "11737a3e1d5080c10f1ca366a12cf8fed7941d49"], [20986, "a3d87fa448de23d9d2faaf6f68803e5925653244"], [20988, "8eba032f52a0b16b39a94267b4884f361e022c36"], [21001, "e1ff480e433697ae546e2cedebf659dc1b19572f"], [21005, "933303413e4fe97dbfd7e7f0a6f26dfb077696e8"], [21011, "ba9e223c57de82fbdb4da1446de570e028477aec"], [21013, "c403794310814d2d83e80f2f10308195505b48be"], [21014, "285277dd804e8e380dde764a00c97a721b4ef976"], [21015, "be407180d726f0121ccce9a7439f14de1731435c"], [21020, "e485d297ea6e882725c3d5b510183a3f8d816530"], [21023, "95f9e309f7307ace9218307f943f29662e21a1e5"], [21028, "425f449fdacb72f98a3e7c4326997b09b9b9a127"], [21029, "b704983ee925dff219ecc5b8e7dd2ba9fec64c1f"], [21031, "db7de969cfb50587475185e25bd09b7e73cafe83"], [21036, "d6e67e938bfce049432b3084787c055911b76f5c"], [21038, "2297b0cb0028965a2ef1d6a5de3d4c2dbe172825"], [21040, "16a8c4d2382d72aa414d89192422187acd290270"], [21041, "d7999d4041875ad4e9d16f400342301ee2eab081"], [21046, "599232503a7959faafa21bc8b38ca98f4b28e536"], [21054, "71884601f955c67b055fad8351074eae4f849769"], [21059, "6a7f0a99d8005187736c3c26c5cc2d538a42590f"], [21066, "323abc0eb0e99d445a38aa4fc0da93f5791ff492"], [21071, "9af8a646a964985fe42a91ea34672266c91ae295"], [21075, "31ac1fb93df9b9a2db332f055052dbfb779bdf91"], [21103, "1217007c8335ec2b3097583ff3e0ad15a35af26e"], [21105, "07f723f19bdf1054d140fc713f72f04a2f1b4258"], [21109, "ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1"], [21110, "806c13589a319292849443d4b8ad44d2edc78cbf"], [21120, "6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1"], [21124, "40219249cf87585023e0d1b44de261dd56752142"], [21126, "fb556288737ececbc12b177b45a0717ff4dd5b66"], [21133, "5a16ceb291fd1b021efc342e3058c0f1ce534778"], [21141, "428da78de10310744a33b5e5b7d85e1a11e8e7ed"], [21148, "bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc"], [21172, "e5ad89d176004931d7ffbf87e7c23bc71fc7418a"]]}


Testing rollup candidate = 56ee931

**Successful merges:**

- #21077 [r+] Implement fully qualified UFCS expressions. (eddyb/expr-qpath = b90028d77092e30fb89b416ac06c847e1fce359a)
- #20463 [r+] Return passed value from black_box (amaranth/black_box_output = 9f5fc563d3d592d5e44ab71759ffa26d326b3daa)
- #20632 Replace usage of deriving with derive in docs (gchp/reference = 4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d)
- #20892 Replace uint with u32 in trpl/guessing-game.md (CarVac/master = 9302dc5d9e13f716a21a5d9ebdcddc149a864b19)
- #20929 Ease parsing of an English sentence (laurilehmijoki/master = eabf2082856668c75ed6f7c229b24fb7755440bc)
- #20964 Fix attr syntax in recursion limit diagnostic (sfackler/recursion-syntax = 78b7e13bf02e59ad05a9d15725e3c36e9dcf7187)
- #20976 Remove unused import. (jbcrail/rm-unused-import = 415fc5f0f10b6180193ecd309b21ae80a1efa6a9)
- #20985 iOS: fixed install phase (vhbit/ios-install = 11737a3e1d5080c10f1ca366a12cf8fed7941d49)
- #20986 [r+] Doc fixes (alkor/doc-fixes = a3d87fa448de23d9d2faaf6f68803e5925653244)
- #20988 Purge references to Rust tasks from TRPL. (ciphergoth/task-to-thread = 8eba032f52a0b16b39a94267b4884f361e022c36)
- #21001 Remove usage and reference of feature(globs) from the book (camjackson/master = e1ff480e433697ae546e2cedebf659dc1b19572f)
- #21005 Update #[deriving] documentation. (huonw/deriving-docs = 933303413e4fe97dbfd7e7f0a6f26dfb077696e8)
- #21011 Small grammar fix in the book (steveklabnik/gh20993 = ba9e223c57de82fbdb4da1446de570e028477aec)
- #21013 Small fix in the book (steveklabnik/gh20914 = c403794310814d2d83e80f2f10308195505b48be)
- #21014 Clean up unary operators in the reference (steveklabnik/gh20876 = 285277dd804e8e380dde764a00c97a721b4ef976)
- #21015 Link to sections in the book's README.md (steveklabnik/gh20852 = be407180d726f0121ccce9a7439f14de1731435c)
- #21020 Improve example in the intro. (steveklabnik/gh20844 = e485d297ea6e882725c3d5b510183a3f8d816530)
- #21023 Clean up wording around uninitialized values. (steveklabnik/gh20840 = 95f9e309f7307ace9218307f943f29662e21a1e5)
- #21028 Remove PDF link on 404 page (steveklabnik/gh17368 = 425f449fdacb72f98a3e7c4326997b09b9b9a127)
- #21029 [r+] Improve the ownership guide a tad (steveklabnik/gh19924 = b704983ee925dff219ecc5b8e7dd2ba9fec64c1f)
- #21031 Improve clarity of paragraph in the pointer guide (steveklabnik/gh19067 = db7de969cfb50587475185e25bd09b7e73cafe83)
- #21036 Vec's IntoIter should be Send/Sync when Vec is (renato-zannon/into-iter-impls = d6e67e938bfce049432b3084787c055911b76f5c)
- #21038 Elaborate on destructuring let (steveklabnik/gh20471 = 2297b0cb0028965a2ef1d6a5de3d4c2dbe172825)
- #21040 Don't use 'synonym' with regards to newtypes (steveklabnik/gh20037 = 16a8c4d2382d72aa414d89192422187acd290270)
- #21041 Add explanation of main to rustdoc docs (steveklabnik/gh17554 = d7999d4041875ad4e9d16f400342301ee2eab081)
- #21046 [r+] Windows building fixes (steveklabnik/gh16654 = 599232503a7959faafa21bc8b38ca98f4b28e536)
- #21054 Remove dead link from make tips (steveklabnik/gh17950 = 71884601f955c67b055fad8351074eae4f849769)
- #21059 Add note about TLS lookups in random() (steveklabnik/gh16072 = 6a7f0a99d8005187736c3c26c5cc2d538a42590f)
- #21066 add test for issue #20575 (japaric/issue-20575 = 323abc0eb0e99d445a38aa4fc0da93f5791ff492)
- #21071 make the book more mobile friendly (sfaxon/mobile-friendly-book = 9af8a646a964985fe42a91ea34672266c91ae295)
- #21075 Various changes to Rust Introduction (iKevinY/intro-changes = 31ac1fb93df9b9a2db332f055052dbfb779bdf91)
- #21103 [r+] Fix a typo and use if-let instead of match in std::result docs (nagisa/result-typo = 1217007c8335ec2b3097583ff3e0ad15a35af26e)
- #21105 Remove unneeded box import in examples (csouth3/kill-box-import = 07f723f19bdf1054d140fc713f72f04a2f1b4258)
- #21109 Provide example of generic inverse() (steveklabnik/gh17224 = ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1)
- #21110 [r+] Updating email address for Rohit Joshi (rohitjoshi/patch-1 = 806c13589a319292849443d4b8ad44d2edc78cbf)
- #21120 [r+] Issue model lexer questionmark (fhahn/issue-model-lexer-questionmark = 6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1)
- #21124 [r+] Re-direct to the right place. (steveklabnik/fix_redirect = 40219249cf87585023e0d1b44de261dd56752142)
- #21126 Dlist examples (sleepynate/dlist-examples = fb556288737ececbc12b177b45a0717ff4dd5b66)
- #21133 Improve Rust Documentation & Reference on mobile (iKevinY/mobile-rustdoc = 5a16ceb291fd1b021efc342e3058c0f1ce534778)
- #21141 [r+] TRPL: Anti-example failing for the wrong reason. (tcard/master = 428da78de10310744a33b5e5b7d85e1a11e8e7ed)
- #21148 fix wrong link (bombless/patch-1 = bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc)
- #21172 Remove erroneous stability attribute. (brson/tuple = e5ad89d176004931d7ffbf87e7c23bc71fc7418a)

**Failed merges:**

- #20991 Redo Segmented stack support for DragonFly (mneumann/llvm-dragonfly-take2 = 7e8453566ed15434e7bc19f52ee78ee6d67a4167)
- #20998 s/deriving/derives in Comments/Docs (estsauver/20984 = 7e472ef163f414411f56b0258928c518253966b3)


saw approval from nikomatsakis
at https://github.com/eddyb/rust/commit/b90028d77092e30fb89b416ac06c847e1fce359a


merging 43 batched pull requests into batch


status: {"merge_sha": "5eb2f591b22cc9f7858ec8cdc7cefe715789d91a", "rollup_pulls": [[21077, "b90028d77092e30fb89b416ac06c847e1fce359a"], [20463, "9f5fc563d3d592d5e44ab71759ffa26d326b3daa"], [20632, "4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d"], [20892, "9302dc5d9e13f716a21a5d9ebdcddc149a864b19"], [20929, "eabf2082856668c75ed6f7c229b24fb7755440bc"], [20964, "78b7e13bf02e59ad05a9d15725e3c36e9dcf7187"], [20976, "415fc5f0f10b6180193ecd309b21ae80a1efa6a9"], [20985, "11737a3e1d5080c10f1ca366a12cf8fed7941d49"], [20986, "a3d87fa448de23d9d2faaf6f68803e5925653244"], [20988, "8eba032f52a0b16b39a94267b4884f361e022c36"], [21001, "e1ff480e433697ae546e2cedebf659dc1b19572f"], [21005, "933303413e4fe97dbfd7e7f0a6f26dfb077696e8"], [21011, "ba9e223c57de82fbdb4da1446de570e028477aec"], [21013, "c403794310814d2d83e80f2f10308195505b48be"], [21014, "285277dd804e8e380dde764a00c97a721b4ef976"], [21015, "be407180d726f0121ccce9a7439f14de1731435c"], [21020, "e485d297ea6e882725c3d5b510183a3f8d816530"], [21023, "95f9e309f7307ace9218307f943f29662e21a1e5"], [21028, "425f449fdacb72f98a3e7c4326997b09b9b9a127"], [21029, "b704983ee925dff219ecc5b8e7dd2ba9fec64c1f"], [21031, "db7de969cfb50587475185e25bd09b7e73cafe83"], [21036, "d6e67e938bfce049432b3084787c055911b76f5c"], [21038, "2297b0cb0028965a2ef1d6a5de3d4c2dbe172825"], [21040, "16a8c4d2382d72aa414d89192422187acd290270"], [21041, "d7999d4041875ad4e9d16f400342301ee2eab081"], [21046, "599232503a7959faafa21bc8b38ca98f4b28e536"], [21054, "71884601f955c67b055fad8351074eae4f849769"], [21059, "6a7f0a99d8005187736c3c26c5cc2d538a42590f"], [21066, "323abc0eb0e99d445a38aa4fc0da93f5791ff492"], [21071, "9af8a646a964985fe42a91ea34672266c91ae295"], [21075, "31ac1fb93df9b9a2db332f055052dbfb779bdf91"], [21103, "1217007c8335ec2b3097583ff3e0ad15a35af26e"], [21105, "07f723f19bdf1054d140fc713f72f04a2f1b4258"], [21109, "ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1"], [21110, "806c13589a319292849443d4b8ad44d2edc78cbf"], [21120, "6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1"], [21124, "40219249cf87585023e0d1b44de261dd56752142"], [21126, "fb556288737ececbc12b177b45a0717ff4dd5b66"], [21133, "5a16ceb291fd1b021efc342e3058c0f1ce534778"], [21141, "428da78de10310744a33b5e5b7d85e1a11e8e7ed"], [21148, "bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc"], [21172, "e5ad89d176004931d7ffbf87e7c23bc71fc7418a"]]}


Testing rollup candidate = 5eb2f59

**Successful merges:**

- #21077 [r+] Implement fully qualified UFCS expressions. (eddyb/expr-qpath = b90028d77092e30fb89b416ac06c847e1fce359a)
- #20463 [r+] Return passed value from black_box (amaranth/black_box_output = 9f5fc563d3d592d5e44ab71759ffa26d326b3daa)
- #20632 Replace usage of deriving with derive in docs (gchp/reference = 4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d)
- #20892 Replace uint with u32 in trpl/guessing-game.md (CarVac/master = 9302dc5d9e13f716a21a5d9ebdcddc149a864b19)
- #20929 Ease parsing of an English sentence (laurilehmijoki/master = eabf2082856668c75ed6f7c229b24fb7755440bc)
- #20964 Fix attr syntax in recursion limit diagnostic (sfackler/recursion-syntax = 78b7e13bf02e59ad05a9d15725e3c36e9dcf7187)
- #20976 Remove unused import. (jbcrail/rm-unused-import = 415fc5f0f10b6180193ecd309b21ae80a1efa6a9)
- #20985 iOS: fixed install phase (vhbit/ios-install = 11737a3e1d5080c10f1ca366a12cf8fed7941d49)
- #20986 [r+] Doc fixes (alkor/doc-fixes = a3d87fa448de23d9d2faaf6f68803e5925653244)
- #20988 Purge references to Rust tasks from TRPL. (ciphergoth/task-to-thread = 8eba032f52a0b16b39a94267b4884f361e022c36)
- #21001 Remove usage and reference of feature(globs) from the book (camjackson/master = e1ff480e433697ae546e2cedebf659dc1b19572f)
- #21005 Update #[deriving] documentation. (huonw/deriving-docs = 933303413e4fe97dbfd7e7f0a6f26dfb077696e8)
- #21011 Small grammar fix in the book (steveklabnik/gh20993 = ba9e223c57de82fbdb4da1446de570e028477aec)
- #21013 Small fix in the book (steveklabnik/gh20914 = c403794310814d2d83e80f2f10308195505b48be)
- #21014 Clean up unary operators in the reference (steveklabnik/gh20876 = 285277dd804e8e380dde764a00c97a721b4ef976)
- #21015 Link to sections in the book's README.md (steveklabnik/gh20852 = be407180d726f0121ccce9a7439f14de1731435c)
- #21020 Improve example in the intro. (steveklabnik/gh20844 = e485d297ea6e882725c3d5b510183a3f8d816530)
- #21023 Clean up wording around uninitialized values. (steveklabnik/gh20840 = 95f9e309f7307ace9218307f943f29662e21a1e5)
- #21028 Remove PDF link on 404 page (steveklabnik/gh17368 = 425f449fdacb72f98a3e7c4326997b09b9b9a127)
- #21029 [r+] Improve the ownership guide a tad (steveklabnik/gh19924 = b704983ee925dff219ecc5b8e7dd2ba9fec64c1f)
- #21031 Improve clarity of paragraph in the pointer guide (steveklabnik/gh19067 = db7de969cfb50587475185e25bd09b7e73cafe83)
- #21036 Vec's IntoIter should be Send/Sync when Vec is (renato-zannon/into-iter-impls = d6e67e938bfce049432b3084787c055911b76f5c)
- #21038 Elaborate on destructuring let (steveklabnik/gh20471 = 2297b0cb0028965a2ef1d6a5de3d4c2dbe172825)
- #21040 Don't use 'synonym' with regards to newtypes (steveklabnik/gh20037 = 16a8c4d2382d72aa414d89192422187acd290270)
- #21041 Add explanation of main to rustdoc docs (steveklabnik/gh17554 = d7999d4041875ad4e9d16f400342301ee2eab081)
- #21046 [r+] Windows building fixes (steveklabnik/gh16654 = 599232503a7959faafa21bc8b38ca98f4b28e536)
- #21054 Remove dead link from make tips (steveklabnik/gh17950 = 71884601f955c67b055fad8351074eae4f849769)
- #21059 Add note about TLS lookups in random() (steveklabnik/gh16072 = 6a7f0a99d8005187736c3c26c5cc2d538a42590f)
- #21066 add test for issue #20575 (japaric/issue-20575 = 323abc0eb0e99d445a38aa4fc0da93f5791ff492)
- #21071 make the book more mobile friendly (sfaxon/mobile-friendly-book = 9af8a646a964985fe42a91ea34672266c91ae295)
- #21075 Various changes to Rust Introduction (iKevinY/intro-changes = 31ac1fb93df9b9a2db332f055052dbfb779bdf91)
- #21103 [r+] Fix a typo and use if-let instead of match in std::result docs (nagisa/result-typo = 1217007c8335ec2b3097583ff3e0ad15a35af26e)
- #21105 Remove unneeded box import in examples (csouth3/kill-box-import = 07f723f19bdf1054d140fc713f72f04a2f1b4258)
- #21109 Provide example of generic inverse() (steveklabnik/gh17224 = ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1)
- #21110 [r+] Updating email address for Rohit Joshi (rohitjoshi/patch-1 = 806c13589a319292849443d4b8ad44d2edc78cbf)
- #21120 [r+] Issue model lexer questionmark (fhahn/issue-model-lexer-questionmark = 6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1)
- #21124 [r+] Re-direct to the right place. (steveklabnik/fix_redirect = 40219249cf87585023e0d1b44de261dd56752142)
- #21126 Dlist examples (sleepynate/dlist-examples = fb556288737ececbc12b177b45a0717ff4dd5b66)
- #21133 Improve Rust Documentation & Reference on mobile (iKevinY/mobile-rustdoc = 5a16ceb291fd1b021efc342e3058c0f1ce534778)
- #21141 [r+] TRPL: Anti-example failing for the wrong reason. (tcard/master = 428da78de10310744a33b5e5b7d85e1a11e8e7ed)
- #21148 fix wrong link (bombless/patch-1 = bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc)
- #21172 Remove erroneous stability attribute. (brson/tuple = e5ad89d176004931d7ffbf87e7c23bc71fc7418a)

**Failed merges:**

- #20998 s/deriving/derives in Comments/Docs (estsauver/20984 = 7e472ef163f414411f56b0258928c518253966b3)


Hi Alex,

It looks good.

Alistair.

From: Alex Henrie
Sent: Thursday, January 15, 2015 6:39 PM
To: alexhenrie/wine
Cc: Alistair Leslie-Hughes
Subject: Re: [wine] dpvoice: Turn GetCompressionTypes into a semi-stub. (b0ff5f2)

Also, I put DPVOICE_GetCompressionTypes at the top of server.c to avoid
having to include dvoice_private.h. Was that the right thing to do?
—
Reply to this email directly or view it on GitHub.


you missed the quantity of oil


Wow, you guys are fast. Also, I could be imagining this but it seems that each snapshot release the tracker analysis is getting faster than before. Thanks.


Tu te trompes. Si aucun ```p``` n'existe qui satisfasse ```kind e tp = Some p```, tu peux choisir n'importe quel ```p``` et la propriété sera juste. Le vrai problème c'est que même si un tel ```p``` existe, on pourrait aussi choisir parfois une valeur qui ne convient pas, de sorte que la propriété ne dit rien d'intéressant en fait.


@tgjones - This same unit test has failed randomly a few times now.  If I rebuild this PR it will probably pass without any further changes.  Not sure why this is not consistent.


I don't know if this determination of the path is correct. I think we need a reference to the build to get the correct relative path. @siamaksade What do you think?


How it can handle multiple uOrb Publishers for topic battery_status ?
Aren't there any conflicts, when topic is served by sensors, px4io and auvcan ? @LorenzMeier @pavel-kirienko @DrTon


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1873](http://teamcity.monogame.net/viewLog.html?buildId=4382&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Yes, or simply keep this change per session. If someone want to keep this property, the permission can be used.


Right, thanks for the typo


Cache timestamp/create time should not be updated on mere access. This would make the cache stay forever in some cases.


You are right, I will add a unit test for that. But indeed the goal is to register all given refspecs to the origin, to be consistent with what has been provided by the user.


You should identify cached data by `args`, `kwargs` and function name, not just args. More than that, storing dicts as keys of a dictionary (args) is not as memory efficient as just hashing them and storing the hash.


Directly comparing payload_mac and generated_mac should be sufficient, isn't it?


Let's keep the implementation for each standard object in respective file. Please move these into object.c, export `init_object(v7)` from object.c and call `init_object(v7) ` in `v7_create()`


Overall structure is alright but it needs some improvements. Please update the PR once done.


repo, not remo :)
Will fix after merge.


One more nit: please remove the join from source_files.


Missing semi


@Syrok thanks. changed its name


No braces around one-liners.


> sure, makes sense, you should add that to #34

I guess you mean #30. Okay, I'll add that to #30.


Yeas it does look cleaner. I was actually thinking of using ES6 and once its fully supported just drop Traceur.
How we can do it maybe put this part in orm-core repo which would not be packaged (it could be if we wanted tho). Then what we could do is compile it and commit compiled files into orm-node repository browserified code into orm.js and maybe appending AMD header and footer could go into orm-amd, same for CJS and maybe even for angular support.
Something like this: [di.js](https://github.com/angular/di.js) or [baby-engine](https://github.com/city41/baby-engine), what do you think?

To avoid doing this manually we could even create a bot that would do that for us, example would be Ionicframework as far as I can see they are using a bot [Ionitron](https://github.com/Ionitron)
or use a grunt|gulp git task.


If we don't need the above code anymore (because we implemented VariableDeclarator), remove the comment above it where you talk about traversing the tree -- it's all generic visiting now.


Another misbrace. I'll trust you to fix the rest of them, too.


I think it makes sense to *always* send stringified JSON with content type `application/json`. Right now the `webSend` *sometimes* sends a plain string, and only if `message` was an Object it stringifies it. That's a little unpredictable for the receiving end, it has no way to know what's being send (a text string or JSON).

I think life will be easier by *always* sending JSON, like you always expect to get back a valid JSON object too by unconditionally parsing `response = JSON.parse(http.responseText)`.


That's not actually an uORB issue - even on the conceptional level you obviously need one topic per battery. Note that I've sent you the required docs for that via Skype this week.


I wrote:
> I'll add that to #30.

Just saw you did it already, via 021ea3d2c9f1b41cb65bd802f7a52030db5dd548. Fine.


Was this ever tested in framework? Apologies if there is some easy way to find out..


Currently note. Yesterday I found out that delete of subscriptions lead to an error. I wrote it in Issues already....

I have few stuff to do, but currently I am not sure if they are already implemented or not have to look at the code and than I write :)

Thanks! :+1:


Stray extra line


a hybird app for vehicle management by the ionic framework


@juwlee The expected value should be true, no?


Inconsistent style for curly braces: either always put a space before them or never (convention is always I think)


Missing space before `+`


I'm not sure this actually fixes it; if the host is set in the config, it'll still use that instead of hostname_g. The line should, imo, be: `sstrncpy(vl->host, hostname_g, sizeof(vl->host);`


need the settings part for this to work.


https://github.com/cmke/android_packages_apps_Settings/commit/5e0b245f337a4ff320f821134d50955f7e835749 :)


IMHO the iv needs to be fed to the mac calculation as well, not only the ciphertext. Otherwise the authentication of the plaintext is not ensured.


Missing space after second semicolon


Extra space in between braces


More of them below


Actually, can you change the wording on this page to not say "only", too? I think it's the only place where it says "only", and it's not supposed to say "only". We've always released TBG under MPL 1.1 or later, but that's described by the license itself.


I think it is because it executes the `/bin/echo` binary instead of the shell (`bash`) builtin. If I do

```
/bin/echo -e
´´´

on my system I indeed get the extra `-e`.


Inconsistent style for function arguments: either always put a space after `function` or never (convention is never I think)


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1873](http://teamcity.monogame.net/viewLog.html?buildId=4382&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 367, ignored: 6 Build time: 00:15:41


It seems we should npm update it sometimes too. Seems all good now. Weirdly enough I'm getting more fails whereas the local npm test passes. Well, fixing them all.


А зачем так много меток? почему не юзать одну. например finalize. А при удачном стечении обстоятельств в err всё равно лежит NO_ERR = 0, так что в любом случаем мы можем сделать return err.


Add support for email entries without a name as [suggested by gemal](https://github.com/a2design-company/sendgrid-webapi-cakephp-plugin/issues/2).


Inconsistent style for function calls; either always put a space before the argument list or never (convention is never I think)


And that's why I needed to learn how to test this :)


TeamCity Bij12 Voorgangsrapportage Natuur - LCV :: CDS BIJ12 :: Build [Build 2.3-SNAPSHOT-80-fae4b59b76dbbe85518b924a2b6d2d8b9862044a](http://buildserver.geodan.nl/teamcity/viewLog.html?buildId=74050&buildTypeId=vrn_CdsBij12_Build) outcome was **SUCCESS**
Summary: Tests passed: 58 Build time: 00:02:23


I suggest adding an "else" clause here with a corresponding warning printed to the logs. Unfortunately we don't have the image path here to report, so we may think about throwing an exception instead so the user of this method can decide whether it's critical that dimensions are available or not. Another way might be to return the dimensions as an object or "null" if they can't be read.


Is required somewhere else as well?


I recently became grizzl's maintainer, so we might end up keeping this.


I think this won't work on OS X.


an explanation: according to http://en.wikipedia.org/wiki/Secure_Remote_Password_protocol#Protocol there are (at least two ways) to prove that the parties' keys match: the original version of this code implemented the simple version:

        Carol → Steve: M1 = H(A | B | S_Carol). Steve verifies M1.

however, there other version is also in common use:

        Carol → Steve: M1 = H[H(N) XOR H(g) | H(I) | s | A | B | K_Carol]. Steve verifies M1.

the SRP.Server's checkClientProof now supports both versions, simply fill-in the optional second parameter with the "I", the client's identifying username.


This is also useful for css-mode, scss-mode, etc


Mention in the commit message why we removed this (in case someone wonders).


Thanks for your consideration. For now we changed to use 1.0.0, we used err_fun to handle some invalid / Updated Token to update our user database record.


Так, коли зупинюсь на "упакованому" варіанті - заміню. Зараз при форматуванні розбивка імпорту так автоматично підтягує... А я й не чіпаю, поки що!


Pomogło ;)


On Wednesday, 14. January 2015 23:46:13 PKEuS wrote:
> Maybe throw an InternalError here?

in that case we could just use the vector.at() function that
throws out_of_range in case of an error.

OTOH we might give a false positive / false negative
instead of crashing completely. Not sure what's really better.


Hmm pretty good suggestion, thx.


Now it passes.


Yes, the kernel should contain everything that's needed. Another, portable option would be to emulate it via pipe and POSIX timer API. The timer would write to the pipe when it expires. The pipe's read end will wake up the I/O loop and the timeout function get's called.


lol was this automatic or are we going to work on this now?


abi komutu biliyor musun bilmiyorum da bu degisikligi merge edebilmen icin bu repo'yu kendine cekip (git fetch https://github.com/denizcetin/WriteTheTime.git) ordan git log --oneline ile bu commitin SSH ID'sine bakip git cherry-pick SSHID ile ekleyip devam edebilirsin.


This was the script


@eddelbuettel, I think this might need to be more properly scoped -- did you see that the same issue occurs on Linux with `clang` as well?


+1.  IMHO, It really is a shame we don't have access to SafeHandleZeroOrMinusOneIsInvalid.


I like your method names :)


Did you define TARGET_ARCH somewhere?  CM doesn't have product files in vendor, so you'll have to set it somewhere like device tree cm.mk


Yes, I suppose there could be. But that has never been a requirement in the past. We could end up with frequent version increments - not that that is a problem I suppose.


@bbatsov yes in `prelude-packages.el`


Where?


just saw you did lol


Yes, I'm defining it in BoardConfig.mk on device tree :).


return boolean directly, no need to write "return true" / "return false" if it's within an if-block. Instead write:
return memberDetails.has("member_status_id") && memberDetails.getString("member_status_id").equals("a");

Also, I'd suggest introducing a descriptive variable for what either of these subterms mean (e.g. what is member_status_id == a?)


1: M100 needs more reviewers
1: M101 signature is missing
14: M102 unrecognized bullet/signature
15: M102 unrecognized bullet/signature
16: M102 unrecognized bullet/signature
17: M102 unrecognized bullet/signature
18: M102 unrecognized bullet/signature
19: M102 unrecognized bullet/signature
20: M102 unrecognized bullet/signature
21: M102 unrecognized bullet/signature
22: M102 unrecognized bullet/signature
23: M102 unrecognized bullet/signature
24: M102 unrecognized bullet/signature
25: M102 unrecognized bullet/signature
26: M102 unrecognized bullet/signature
27: M102 unrecognized bullet/signature
28: M102 unrecognized bullet/signature
29: M102 unrecognized bullet/signature
30: M102 unrecognized bullet/signature
31: M102 unrecognized bullet/signature
32: M102 unrecognized bullet/signature
33: M102 unrecognized bullet/signature
34: M102 unrecognized bullet/signature
35: M102 unrecognized bullet/signature
36: M102 unrecognized bullet/signature
1: M110 missing component name


@Steell spoke with me briefly while I was there, where we agreed that `LoadNode/SaveNode` related things should be merged with `DeserializeCore/SerializeCore` methods ([as outlined in this internal task](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-2154)). So this method will no longer just serve undo-redo, but also operations like file saving, copy-paste.


2: I101 copyright is missing


1: D100 Docstring missing
2: I102 copyright year is outdated, expected 2015 but got 2013
24:9: E126 continuation line over-indented for hanging indent
24:17: E203 whitespace before ':'
24:26: E231 missing whitespace after ','
25:20: E203 whitespace before ':'
25:29: E231 missing whitespace after ','
26:18: E203 whitespace before ':'
27:18: E203 whitespace before ':'
84:27: E261 at least two spaces before inline comment
85:27: E261 at least two spaces before inline comment
112:16: E231 missing whitespace after ':'
118:14: E231 missing whitespace after ':'
123:14: E231 missing whitespace after ':'
135:18: E261 at least two spaces before inline comment
135:19: E262 inline comment should start with '# '
136:18: E261 at least two spaces before inline comment
136:19: E262 inline comment should start with '# '
137:18: E261 at least two spaces before inline comment
137:19: E262 inline comment should start with '# '
138:18: E261 at least two spaces before inline comment
138:19: E262 inline comment should start with '# '
139:18: E261 at least two spaces before inline comment
139:19: E262 inline comment should start with '# '
140:18: E261 at least two spaces before inline comment
140:19: E262 inline comment should start with '# '
143:18: E261 at least two spaces before inline comment
143:19: E262 inline comment should start with '# '
144:18: E261 at least two spaces before inline comment
144:19: E262 inline comment should start with '# '
147:18: E261 at least two spaces before inline comment
147:19: E262 inline comment should start with '# '
148:18: E261 at least two spaces before inline comment
148:19: E262 inline comment should start with '# '
149:18: E261 at least two spaces before inline comment
149:19: E262 inline comment should start with '# '
150:18: E261 at least two spaces before inline comment
150:19: E262 inline comment should start with '# '
153:18: E261 at least two spaces before inline comment
153:19: E262 inline comment should start with '# '
154:18: E261 at least two spaces before inline comment
154:19: E262 inline comment should start with '# '


1: D205 Blank line missing between one-line summary and description
4: I102 copyright year is outdated, expected 2015 but got 2014
28:1: E302 expected 2 blank lines, found 1
28: D290 White spaces around docstring should be trimmed.
28: D203 Expected 1 blank line *before* class docstring, found 0
33: D400 First line should end with '.', not 'r'
33: D205 Blank line missing between one-line summary and description
33: D208 Docstring is over-indented
42:90: E502 the backslash is redundant between brackets
42: D400 First line should end with '.', not 's'
42: D205 Blank line missing between one-line summary and description
42: D208 Docstring is over-indented
70:104: E231 missing whitespace after ','
70: D400 First line should end with '.', not 'e'
70: D205 Blank line missing between one-line summary and description
70: D208 Docstring is over-indented
92: D400 First line should end with '.', not 's'
92: D205 Blank line missing between one-line summary and description
92: D208 Docstring is over-indented
105: D205 Blank line missing between one-line summary and description
105: D208 Docstring is over-indented
116: D400 First line should end with '.', not 's'
116: D205 Blank line missing between one-line summary and description
116: D208 Docstring is over-indented
131: D400 First line should end with '.', not 'e'
131: D205 Blank line missing between one-line summary and description
131: D208 Docstring is over-indented
144:56: E251 unexpected spaces around keyword / parameter equals
144:58: E251 unexpected spaces around keyword / parameter equals
144: D205 Blank line missing between one-line summary and description
144: D208 Docstring is over-indented
157: D400 First line should end with '.', not 's'
157: D205 Blank line missing between one-line summary and description
157: D208 Docstring is over-indented
167: D205 Blank line missing between one-line summary and description
167: D208 Docstring is over-indented
181: D401 First line should be imperative: 'get', not 'gets'
181: D205 Blank line missing between one-line summary and description
181: D208 Docstring is over-indented
195:1: W391 blank line at end of file


1: D205 Blank line missing between one-line summary and description
34:28: E126 continuation line over-indented for hanging indent
41: D400 First line should end with '.', not 's'
55: D101 Docstring missing
57:30: E261 at least two spaces before inline comment
59: D400 First line should end with '.', not 's'
112: D401 First line should be imperative: 'return', not 'returns'
112: D209 Put multi-line docstring closing quotes on separate line
112: D202 No blank lines allowed *after* method docstring, found 1
112: D400 First line should end with '.', not 'y'
112: D205 Blank line missing between one-line summary and description
112: D208 Docstring is over-indented
118:26: E261 at least two spaces before inline comment
129:28: F821 undefined name 'invenio'
135:26: F821 undefined name 'invenio'
172:46: E261 at least two spaces before inline comment
190:46: E261 at least two spaces before inline comment
194: D102 Docstring missing
230:5: E303 too many blank lines (2)
230: D401 First line should be imperative: 'create', not 'creates'
230: D400 First line should end with '.', not 'e'
251:26: F821 undefined name 'invenio'
263:19: E127 continuation line over-indented for visual indent
277: D400 First line should end with '.', not 'e'
287: D400 First line should end with '.', not 'e'
291: D400 First line should end with '.', not 'e'
299: D400 First line should end with '.', not 'e'
321:26: F821 undefined name 'invenio'
336:13: F841 local variable 'dummy' is assigned to but never used
350: D400 First line should end with '.', not 't'
357:56: E251 unexpected spaces around keyword / parameter equals
357:58: E251 unexpected spaces around keyword / parameter equals
357: D209 Put multi-line docstring closing quotes on separate line
357: D205 Blank line missing between one-line summary and description
357: D208 Docstring is over-indented
426:37: E261 at least two spaces before inline comment
428:18: E261 at least two spaces before inline comment
437: D400 First line should end with '.', not 's'
455: D401 First line should be imperative: 'Thi', not 'This'
455: D400 First line should end with '.', not 'd'
455: D205 Blank line missing between one-line summary and description


1: D100 Docstring missing
4: I102 copyright year is outdated, expected 2015 but got 2014
88:1: F401 'random' imported but unused
92:1: F401 'string' imported but unused
97:1: F401 'exc' imported but unused
105: D290 White spaces around docstring should be trimmed.
105: D400 First line should end with '.', not 'o'
116: D202 No blank lines allowed *after* function docstring, found 1
116: D400 First line should end with '.', not 'g'
116: D205 Blank line missing between one-line summary and description
318: D103 Docstring missing
324: D400 First line should end with '.', not 's'
324: D205 Blank line missing between one-line summary and description
340: D205 Blank line missing between one-line summary and description
349:21: E127 continuation line over-indented for visual indent
354:50: E502 the backslash is redundant between brackets
355:25: E127 continuation line over-indented for visual indent
355:66: E502 the backslash is redundant between brackets
356:25: E127 continuation line over-indented for visual indent
367: D205 Blank line missing between one-line summary and description
376:21: E127 continuation line over-indented for visual indent
396: D400 First line should end with '.', not '6'
396: D205 Blank line missing between one-line summary and description
413: D400 First line should end with '.', not 'r'
413: D205 Blank line missing between one-line summary and description
423:14: E127 continuation line over-indented for visual indent
427:16: E126 continuation line over-indented for hanging indent
442:45: E128 continuation line under-indented for visual indent
443:45: E128 continuation line under-indented for visual indent
452: D400 First line should end with '.', not 'd'
452: D205 Blank line missing between one-line summary and description
480: D209 Put multi-line docstring closing quotes on separate line
480: D400 First line should end with '.', not 'n'
480: D205 Blank line missing between one-line summary and description
506:32: F841 local variable 'err' is assigned to but never used
526: D209 Put multi-line docstring closing quotes on separate line
526: D400 First line should end with '.', not 'n'
526: D205 Blank line missing between one-line summary and description
540: D200 One-line docstring should not occupy 3 lines
555: D400 First line should end with '.', not 'N'
555: D205 Blank line missing between one-line summary and description
595:49: E128 continuation line under-indented for visual indent
606:82: E231 missing whitespace after ','
621: D400 First line should end with '.', not 's'
621: D205 Blank line missing between one-line summary and description
640: D209 Put multi-line docstring closing quotes on separate line
640: D205 Blank line missing between one-line summary and description
665: D103 Docstring missing
675: D103 Docstring missing
710:72: E502 the backslash is redundant between brackets
711:20: E127 continuation line over-indented for visual indent
711:44: E231 missing whitespace after ','
715:35: E261 at least two spaces before inline comment
734:21: E128 continuation line under-indented for visual indent
734:93: E231 missing whitespace after ','
752:50: E231 missing whitespace after ','
772:48: E231 missing whitespace after ','
825: D400 First line should end with '.', not 'e'
825: D205 Blank line missing between one-line summary and description
842: D400 First line should end with '.', not 's'
842: D205 Blank line missing between one-line summary and description
857: D400 First line should end with '.', not 'r'
857: D205 Blank line missing between one-line summary and description
867:10: E122 continuation line missing indentation or outdented
880: D200 One-line docstring should not occupy 3 lines
895: D400 First line should end with '.', not 'y'
895: D205 Blank line missing between one-line summary and description
914: D400 First line should end with '.', not 'L'
914: D205 Blank line missing between one-line summary and description
929: D400 First line should end with '.', not 's'
929: D200 One-line docstring should not occupy 3 lines
943: D400 First line should end with '.', not 's'
943: D200 One-line docstring should not occupy 3 lines
957: D400 First line should end with '.', not 'd'
957: D200 One-line docstring should not occupy 3 lines
971: D200 One-line docstring should not occupy 3 lines
985: D202 No blank lines allowed *after* function docstring, found 1
988: D203 Expected 1 blank line *before* class docstring, found 0
988: D204 Expected 1 blank line *after* class docstring, found 0
988: D400 First line should end with '.', not 'l'
1104: D290 White spaces around docstring should be trimmed.
1104: D400 First line should end with '.', not 's'


1: D200 One-line docstring should not occupy 2 lines
21:1: F401 'CFG_SITE_URL' imported but unused
21:1: F401 'CFG_SITE_NAME' imported but unused
22:1: F401 'quote' imported but unused
27:1: E302 expected 2 blank lines, found 1
27: D401 First line should be imperative: 'Print', not 'Prints'
27: D290 White spaces around docstring should be trimmed.
27: D202 No blank lines allowed *after* function docstring, found 1
27: D400 First line should end with '.', not 's'
27: D205 Blank line missing between one-line summary and description
40:5: E301 expected 1 blank line, found 0
40: D290 White spaces around docstring should be trimmed.
40: D400 First line should end with '.', not 'd'
50:37: E225 missing whitespace around operator
54:29: E225 missing whitespace around operator
54:39: E225 missing whitespace around operator
54:57: E225 missing whitespace around operator
58:34: E261 at least two spaces before inline comment
59:31: E231 missing whitespace after ','
59:54: E261 at least two spaces before inline comment
63:44: E261 at least two spaces before inline comment
64:36: E231 missing whitespace after ','
64:64: E261 at least two spaces before inline comment
70:1: E302 expected 2 blank lines, found 1
70: D400 First line should end with '.', not 't'
70: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 2 lines
4: I102 copyright year is outdated, expected 2015 but got 2011
24:1: F401 'CFG_BIBAUTHORITY_RECORD_CONTROL_NUMBER_FIELD' imported but unused
28:1: F401 'get_low_level_recIDs_from_control_no' imported but unused
37:1: E302 expected 2 blank lines, found 1
37: D401 First line should be imperative: 'Print', not 'Prints'
37: D290 White spaces around docstring should be trimmed.
37: D202 No blank lines allowed *after* function docstring, found 1
37: D205 Blank line missing between one-line summary and description
49:5: E303 too many blank lines (2)
57:87: E231 missing whitespace after ','
60:9: F841 local variable 'count_string' is assigned to but never used
68:42: E225 missing whitespace around operator
69:54: E231 missing whitespace after ','
71:45: E225 missing whitespace around operator
82:9: E113 unexpected indentation
83:9: E113 unexpected indentation
85:5: E122 continuation line missing indentation or outdented
86:5: E122 continuation line missing indentation or outdented
87:5: E122 continuation line missing indentation or outdented
88:5: E122 continuation line missing indentation or outdented
89:5: E122 continuation line missing indentation or outdented
90:5: E122 continuation line missing indentation or outdented
96:1: E302 expected 2 blank lines, found 1
96: D400 First line should end with '.', not 't'
96: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 2 lines
35:1: E302 expected 2 blank lines, found 1
35: D401 First line should be imperative: 'Print', not 'Prints'
35: D290 White spaces around docstring should be trimmed.
35: D202 No blank lines allowed *after* function docstring, found 1
35: D205 Blank line missing between one-line summary and description
49:91: E225 missing whitespace around operator
53:43: E231 missing whitespace after ','
54:82: E231 missing whitespace after ','
72:78: E202 whitespace before ')'
98:21: E126 continuation line over-indented for hanging indent
121:1: E302 expected 2 blank lines, found 1
121: D400 First line should end with '.', not 't'
121: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 2 lines
36:1: E302 expected 2 blank lines, found 1
36: D401 First line should be imperative: 'Print', not 'Prints'
36: D290 White spaces around docstring should be trimmed.
36: D400 First line should end with '.', not 's'
36: D205 Blank line missing between one-line summary and description
50:37: E225 missing whitespace around operator
53:29: E225 missing whitespace around operator
53:39: E225 missing whitespace around operator
53:57: E225 missing whitespace around operator
57:34: E261 at least two spaces before inline comment
90:1: E302 expected 2 blank lines, found 1
90: D209 Put multi-line docstring closing quotes on separate line
90: D400 First line should end with '.', not 'd'
90: D205 Blank line missing between one-line summary and description
128:55: E127 continuation line over-indented for visual indent
129:55: E127 continuation line over-indented for visual indent
130:55: E127 continuation line over-indented for visual indent
145:1: E302 expected 2 blank lines, found 1
145: D209 Put multi-line docstring closing quotes on separate line
145: D400 First line should end with '.', not 'd'
145: D205 Blank line missing between one-line summary and description
162:29: E127 continuation line over-indented for visual indent
173:1: E302 expected 2 blank lines, found 1
173: D401 First line should be imperative: 'Test', not 'Tests'
173: D400 First line should end with '.', not "'"
173: D205 Blank line missing between one-line summary and description
201:1: E302 expected 2 blank lines, found 1
201: D400 First line should end with '.', not 't'
201: D205 Blank line missing between one-line summary and description


@bbatsov That't nice, but grizzl will used in core of prelude or as a module like ido? If it's gonna be in a module better to require it in there


1: D200 One-line docstring should not occupy 2 lines
26:1: E302 expected 2 blank lines, found 1
26: D401 First line should be imperative: 'Print', not 'Prints'
26: D290 White spaces around docstring should be trimmed.
26: D400 First line should end with '.', not 's'
26: D205 Blank line missing between one-line summary and description
38:5: E301 expected 1 blank line, found 0
38: D290 White spaces around docstring should be trimmed.
38: D400 First line should end with '.', not 'd'
50:29: E225 missing whitespace around operator
50:39: E225 missing whitespace around operator
50:57: E225 missing whitespace around operator
54:34: E261 at least two spaces before inline comment
55:31: E231 missing whitespace after ','
55:54: E261 at least two spaces before inline comment
59:44: E261 at least two spaces before inline comment
60:36: E231 missing whitespace after ','
60:64: E261 at least two spaces before inline comment
66:1: E302 expected 2 blank lines, found 1
66: D400 First line should end with '.', not 't'
66: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 2 lines
22:1: F401 'CFG_SITE_URL' imported but unused
22:1: F401 'CFG_SITE_NAME' imported but unused
24:1: F401 'CFG_BIBAUTHORITY_RECORD_AUTHOR_CONTROL_NUMBER_FIELDS' imported but unused
24:1: F401 'CFG_BIBAUTHORITY_RECORD_CONTROL_NUMBER_FIELD' imported but unused
24:1: F401 'CFG_BIBAUTHORITY_AUTHORITY_COLLECTION_NAME' imported but unused
28:1: F401 'get_dependent_records_for_control_no' imported but unused
28:1: F401 'get_low_level_recIDs_from_control_no' imported but unused
32:50: E231 missing whitespace after ','
36:1: E302 expected 2 blank lines, found 1
36: D401 First line should be imperative: 'Print', not 'Prints'
36: D290 White spaces around docstring should be trimmed.
36: D202 No blank lines allowed *after* function docstring, found 1
36: D205 Blank line missing between one-line summary and description
48:44: E261 at least two spaces before inline comment
50:5: F841 local variable 'style' is assigned to but never used
53:9: F401 'quote' imported but unused
63:50: E201 whitespace after '{'
67:21: E127 continuation line over-indented for visual indent
67:24: E201 whitespace after '{'
67:31: E203 whitespace before ':'
67:131: E202 whitespace before '}'
67:53: E231 missing whitespace after ','
71:63: E231 missing whitespace after ','
72:50: E225 missing whitespace around operator
73:46: E201 whitespace after '{'
73:137: E203 whitespace before ':'
73:152: E202 whitespace before '}'
80:5: E303 too many blank lines (5)
90:1: E302 expected 2 blank lines, found 0
90: D400 First line should end with '.', not 't'
90: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 2 lines
4: I102 copyright year is outdated, expected 2015 but got 2011
24:1: F401 'CFG_BIBAUTHORITY_RECORD_CONTROL_NUMBER_FIELD' imported but unused
29:1: F401 'get_low_level_recIDs_from_control_no' imported but unused
38:1: E302 expected 2 blank lines, found 1
38: D401 First line should be imperative: 'Print', not 'Prints'
38: D290 White spaces around docstring should be trimmed.
38: D202 No blank lines allowed *after* function docstring, found 1
38: D205 Blank line missing between one-line summary and description
50:5: E303 too many blank lines (2)
51:87: E225 missing whitespace around operator
56:5: E303 too many blank lines (2)
63:77: E231 missing whitespace after ','
64:82: E231 missing whitespace after ','
74:44: E225 missing whitespace around operator
78:50: E231 missing whitespace after ','
80:60: E231 missing whitespace after ','
83:22: E225 missing whitespace around operator
84:37: E225 missing whitespace around operator
96:9: E113 unexpected indentation
97:9: E113 unexpected indentation
99:5: E122 continuation line missing indentation or outdented
100:5: E122 continuation line missing indentation or outdented
101:5: E122 continuation line missing indentation or outdented
102:5: E122 continuation line missing indentation or outdented
103:5: E122 continuation line missing indentation or outdented
104:5: E122 continuation line missing indentation or outdented
113: D400 First line should end with '.', not 't'
113: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 2 lines
26:1: E302 expected 2 blank lines, found 1
26: D401 First line should be imperative: 'Print', not 'Prints'
26: D290 White spaces around docstring should be trimmed.
26: D400 First line should end with '.', not 's'
26: D205 Blank line missing between one-line summary and description
38:5: E301 expected 1 blank line, found 0
38: D290 White spaces around docstring should be trimmed.
38: D400 First line should end with '.', not 'd'
49:29: E225 missing whitespace around operator
49:39: E225 missing whitespace around operator
49:57: E225 missing whitespace around operator
54:34: E261 at least two spaces before inline comment
55:31: E231 missing whitespace after ','
55:54: E261 at least two spaces before inline comment
59:44: E261 at least two spaces before inline comment
60:36: E231 missing whitespace after ','
60:64: E261 at least two spaces before inline comment
66:1: E302 expected 2 blank lines, found 1
66: D400 First line should end with '.', not 't'
66: D205 Blank line missing between one-line summary and description


29:1: F401 'register_exception' imported but unused
140:25: E122 continuation line missing indentation or outdented
141:25: E122 continuation line missing indentation or outdented
142:25: E122 continuation line missing indentation or outdented
145:35: E126 continuation line over-indented for hanging indent
146:25: E122 continuation line missing indentation or outdented


1: D400 First line should end with '.', not 'r'
1: D200 One-line docstring should not occupy 2 lines
4: I102 copyright year is outdated, expected 2015 but got 2012
24:1: E302 expected 2 blank lines, found 1
24: D401 First line should be imperative: 'Print', not 'Prints'
32:82: E502 the backslash is redundant between brackets
35:1: E302 expected 2 blank lines, found 1
35: D400 First line should end with '.', not 't'
35: D205 Blank line missing between one-line summary and description


1: D100 Docstring missing
1: I101 copyright is missing
10:1: E302 expected 2 blank lines, found 1
10: D103 Docstring missing
12:51: E225 missing whitespace around operator
18:108: E231 missing whitespace after ','
18:126: E231 missing whitespace after ':'
25:1: E302 expected 2 blank lines, found 1
25: D103 Docstring missing
31:59: E231 missing whitespace after ','
34:59: E231 missing whitespace after ','
35:66: E231 missing whitespace after ','
42:65: E231 missing whitespace after ','
43:72: E231 missing whitespace after ','
46:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'k'
4: I102 copyright year is outdated, expected 2015 but got 2014
69:1: E302 expected 2 blank lines, found 1
69: D290 White spaces around docstring should be trimmed.
69: D203 Expected 1 blank line *before* class docstring, found 0
69: D204 Expected 1 blank line *after* class docstring, found 0
69: D400 First line should end with '.', not 'n'
71: D102 Docstring missing
73:13: E128 continuation line under-indented for visual indent
76: D290 White spaces around docstring should be trimmed.
76: D203 Expected 1 blank line *before* class docstring, found 0
76: D204 Expected 1 blank line *after* class docstring, found 0
76: D400 First line should end with '.', not 'n'
78: D102 Docstring missing
89: D401 First line should be imperative: 'Iterate', not 'Iterates'
150:55: E261 at least two spaces before inline comment
164: D290 White spaces around docstring should be trimmed.
164: D400 First line should end with '.', not 'n'
170:57: E261 at least two spaces before inline comment
176: D290 White spaces around docstring should be trimmed.
176: D400 First line should end with '.', not 'e'
183: D401 First line should be imperative: 'Change', not 'Changes'
183: D400 First line should end with '.', not 'e'
183: D205 Blank line missing between one-line summary and description
202:25: E128 continuation line under-indented for visual indent
205: D400 First line should end with '.', not 'd'
205: D200 One-line docstring should not occupy 3 lines
217: D290 White spaces around docstring should be trimmed.
217: D400 First line should end with '.', not 'd'
223: D290 White spaces around docstring should be trimmed.
223: D400 First line should end with '.', not 'd'
227:13: E128 continuation line under-indented for visual indent
229: D290 White spaces around docstring should be trimmed.
229: D400 First line should end with '.', not 'd'
232:17: E128 continuation line under-indented for visual indent
238: D290 White spaces around docstring should be trimmed.
238: D400 First line should end with '.', not 'd'
241:17: E128 continuation line under-indented for visual indent
245: D290 White spaces around docstring should be trimmed.
245: D400 First line should end with '.', not 'd'
249:17: E128 continuation line under-indented for visual indent
251: D290 White spaces around docstring should be trimmed.
251: D400 First line should end with '.', not 't'
255: D401 First line should be imperative: 'Yield', not 'Yields'
255: D400 First line should end with '.', not 'g'
266:5: E129 visually indented line with same indent as next logical line
272: D102 Docstring missing
277: D290 White spaces around docstring should be trimmed.
277: D202 No blank lines allowed *after* function docstring, found 1
277: D400 First line should end with '.', not 'k'
302:1: E302 expected 2 blank lines, found 1
342:25: E128 continuation line under-indented for visual indent
380:1: E302 expected 2 blank lines, found 1
380: D290 White spaces around docstring should be trimmed.
380: D202 No blank lines allowed *after* function docstring, found 1
380: D400 First line should end with '.', not 'g'
423: D290 White spaces around docstring should be trimmed.
423: D202 No blank lines allowed *after* function docstring, found 1
423: D400 First line should end with '.', not 'd'
449:1: E302 expected 2 blank lines, found 1
449: D400 First line should end with '.', not 'e'
449: D200 One-line docstring should not occupy 3 lines
459:1: E302 expected 2 blank lines, found 1
459: D400 First line should end with '.', not 'e'
459: D200 One-line docstring should not occupy 3 lines
469:1: E302 expected 2 blank lines, found 1
469: D400 First line should end with '.', not 'e'
469: D205 Blank line missing between one-line summary and description
482: D202 No blank lines allowed *after* function docstring, found 1
482: D400 First line should end with '.', not 'd'
482: D205 Blank line missing between one-line summary and description
494:20: E261 at least two spaces before inline comment
499: D400 First line should end with '.', not 'e'
499: D205 Blank line missing between one-line summary and description
506:1: E302 expected 2 blank lines, found 1
528:1: E302 expected 2 blank lines, found 1
528: D290 White spaces around docstring should be trimmed.
528: D400 First line should end with '.', not 'e'
537: D290 White spaces around docstring should be trimmed.
537: D400 First line should end with '.', not 's'
554:47: E127 continuation line over-indented for visual indent
587: D400 First line should end with '.', not 's'
587: D200 One-line docstring should not occupy 3 lines
611: D401 First line should be imperative: 'Generate', not 'Generates'
652:16: E713 test for membership should be 'not in'
662: D400 First line should end with '.', not 'e'
662: D205 Blank line missing between one-line summary and description
675:1: E302 expected 2 blank lines, found 1
675: D400 First line should end with '.', not 'a'
675: D205 Blank line missing between one-line summary and description
730: D401 First line should be imperative: 'Print', not 'Prints'
730: D400 First line should end with '.', not 't'
732:12: E221 multiple spaces before operator
748: D401 First line should be imperative: 'Print', not 'Prints'
748: D400 First line should end with '.', not 't'
762: D401 First line should be imperative: 'Construct', not 'Constructs'
801:36: E127 continuation line over-indented for visual indent
820:19: E128 continuation line under-indented for visual indent
821:19: E128 continuation line under-indented for visual indent
824:1: W391 blank line at end of file


1: D290 White spaces around docstring should be trimmed.
1: D400 First line should end with '.', not 's'
4: I102 copyright year is outdated, expected 2015 but got 2013
22:33: E126 continuation line over-indented for hanging indent
28:1: F401 'record_replace_field' imported but unused
28:47: E231 missing whitespace after ','
30:1: E302 expected 2 blank lines, found 1
30: D401 First line should be imperative: 'Calculate', not 'Calculates'
30: D290 White spaces around docstring should be trimmed.
30: D202 No blank lines allowed *after* function docstring, found 1
30: D400 First line should end with '.', not 'd'
39:5: E303 too many blank lines (2)
43:28: E231 missing whitespace after ','
44:58: E231 missing whitespace after ','
50:21: F841 local variable 'linkfield' is assigned to but never used
50:150: E203 whitespace before ','
50:69: E231 missing whitespace after ','
50:109: E231 missing whitespace after ','
50:143: E231 missing whitespace after ','
60:84: E502 the backslash is redundant between brackets
60:48: E231 missing whitespace after ','
61:33: E128 continuation line under-indented for visual indent
61:78: E231 missing whitespace after ','
61:118: E231 missing whitespace after ','
61:152: E231 missing whitespace after ','


1: D400 First line should end with '.', not 'y'
1: D205 Blank line missing between one-line summary and description
4: I102 copyright year is outdated, expected 2015 but got 2014
100:14: E128 continuation line under-indented for visual indent


Can we put that after we imported everything? (just before the API version)


The "app/node_modules" directory still needs to be there, as it contains dependencies for the express app. Maybe I explained node modules poorly. We should define some best practices for where and how to add new node modules/dependencies. Reverting this commit, since the app will not run now.


"indicates" should be "indicate"


Or you can send message  at https://gitter.im/Zckrs https://gitter.im/Swiip


we probably should also add a line to the table of deliverables; but I can take care of this once we agree on the description of the spec


Commit name is 'use brooklynAccessibleAddress', but this commit just changes imports


@bbatsov `css-mode` requires it by its own. I should require it in `scss-mode` too


url =  /page/livechat


Thank you for that suggestion.
If I understand that right, you use "value" as a reference-variable for "item".

I would like to keep the current solution, because variable reference isn't a beginner topic.


check the commit to know the fixes


So we'd wrap everything in envelopes?

> On 15 jan. 2015, at 09:15, Jos de Jong <notifications@github.com> wrote:
>
> I think it makes sense to always send stringified JSON with content type application/json. Right now the webSend sometimes sends a plain string, and only if message was an Object it stringifies it. That's a little unpredictable for the receiving end, it has no way to know what's being send (a text string or JSON).
>
> I think life will be easier by always sending JSON, like you always expect to get back a valid JSON object too by unconditionally parsing response = JSON.parse(http.responseText).
>
> —
> Reply to this email directly or view it on GitHub.
>


I added it here for the benefit of Projectile users (Projectile has built-in grizzl support). I don't think there will be a separate module for it (at least not soon), as it can't be used globally (yet).


This function must not be called with an invalid varid.


7R/6k1/5R1N/8/8/8/2BB4/1K6 w - - 0 1

Is this not a position with four contact checks with two rooks? Or have I misunderstood?


What about storing the registered ids to update in an ets table and poll it? This could be a feature on next milestone. Let me know


So this is the fixes for WiFi problem?


It is better to use ng-repeat to itereta through array


84695188_CoverageFinalImplementation (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.89%25-green.svg)


Hm? Are you asking why it's not in an integration test? Or are you saying you'd prefer this in the repo of some other gem? Which?


today we will talk about modules ;)


@JakubMatejka Diky za ty upravy, vypada to dobre.
Jenom jedna drobnost k tem testum exceptions ze SAPI, misto tohodle:
```php
$testPassed = false;
try {
  $this->_client->removeAliasTableFilter($aliasTableId, array('values' => array('VAN')));
} catch (\Keboola\StorageApi\ClientException $e) {
  if ($e->getCode() == 501) {
    $testPassed = true;
  }
}
$this->assertTrue($testPassed, 'Removing of alias filter for redshift backend should fail');
```

Je IMHO  jednodussi, citelnejsi a presnejsi (pokud vrati jiny kod primo napise jaky to vratilo a jaky to melo vratit) to psat takhle:
```php
try {
  $this->_client->removeAliasTableFilter($aliasTableId, array('values' => array('VAN')));
  $this->fail('Removing of alias filter for redshift backend should fail');
} catch (\Keboola\StorageApi\ClientException $e) {
  $this->assertEquals(501, $e->getCode());
}
```
Kdyztak to potom prosim podle tohodle uprav.
dik


Hows Java?


Isn't this testing code inside the sie gem?


I'm glad you register all your peripherals so late. Makes compatibility much easier to achieve :+1:


it is better to use controllerAs options to make your app more consistent with Angular 2.0


See https://github.com/tribut/weechat-otr/commit/29b441442572a42eafc300d9880d536e61061cc6


I'm practicing java collection api.


Oh, nvm :)


What exactly? `magit-filenotify` for version checking?
if filenotify doesn't work on OS X we can enable it on linux only


in existed source code it is not necessary to define second argument as array, we will talk about tools to build AngularJS's projects in the last session


Actually I don't like such approaches.
We will talk about services today, so you will be able to move this logic into a separate service


创建


test


Update it


No, just a single, consistent way of serializing what we send.

In this case, if we do a `JSON.stringify` on the message when it's a string *too*, a string like `foo` will be serialized as `"foo"`, and an object like `{foo:123}` will be serialized as `{"foo":123}`. The receiving side can safely do a `JSON.parse` and gets back the original data type, either a string or an Object.


will check it out.
What's better in PDO ?


Aww, GitHug :)
<img src="https://c2.staticflickr.com/6/5513/9330868963_7cedf38fc1_z.jpg" width="200px">


type b:2


today we will talk about modules a it more
it is not bad to create module like "app.controllers", but it is better to do it in a bit another way
I'll share my thoughts about it and probably we will have good discussion


I don't really like having every dependency in one big global dependency file, but atm this seems like the most practical solution. Node_modules (dependencies) are stored within the module they are used in (like it was before this commit), but this presents an issue with "npm install" when adding new dependencies to a module (you often need to run "npm install" manually in every module, it does not run recursively).

See [https://github.com/npm/npm/issues/1341](https://github.com/npm/npm/issues/1341)


Una linea mas de las tantas que he puesto ya


Verified this works on Centos 6.3, FWIW.


I think I tried this while setting this up, JSON parse didn't like it when it was a string to begin with. I'd have to double check but I think that's why there's all those checks and catches.

> On 15 jan. 2015, at 09:53, Jos de Jong <notifications@github.com> wrote:
>
> No, just a single, consistent way of serializing what we send.
>
> In this case, if we do a JSON.stringify on the message when it's a string too, a string like foo will be serialized as "foo", and an object like {foo:123} will be serialized as {"foo":123}. The receiving side can safely do a JSON.parse and gets back the original data type, either a string or an Object.
>
> —
> Reply to this email directly or view it on GitHub.
>


Fixed mainline


@bbatsov it turned out `prelude-css` required in `prelude-scss`, so this commit is fine I think


I think we don't need this one, I'll remove this commit


```toBoolean``` method, should that not check for true value in a list too otherwise any bogus string will return true.


Fixed.


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3151
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3144
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3136
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3136
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3139
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3132
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3126
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2802
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1640


竟然不发 minor


여기 라인부터 추가해 주세요


Don't you like lambdas? :cry: Don't worry, I'll do some changes to that part of the code.


Great catch @gmarz ! I was sure I had tested this already.

Not sure ElasticsearchAuthenticationException is the proper name for a for 403. Authentication != Authorization. Perhaps throw an `ElasticsearchAuthException(Auth.Forbidden)` or something like that. Thoughts?


The elaborate violationSuppressXPath strategy was ultimately not necessary if you either leverage the Lombok configuration to NOT fully qualify java.lang declarations, or are using a new version of PMD.  A bug was identified in PMD and it has since been patched:  http://sourceforge.net/p/pmd/bugs/1164/

Basically, Lombok is, by default, fully qualifying the generated code.  The PMD scanner was not recognizing the @java.lang.SupressWarnings("all") as a @SuppressWarnings("all") -- the code only tested that "annotation.equals("SuppressWarnings")" -- or something like that.  It was a trivial fix.

So, PMD 5.1.0+ will properly recognize java.lang.SuppressWarnings, or SuppressWarnings.  Or, you can just disable Lombok's formatting of fully qualifying java.lang objects...

I prefer the latter since I don't see the point of having the generated code be explicit like java.lang.String -- String will be just fine.

Hope this helps!


Dashboard image renewal. Removal  of  "preview" text that was forgotten by mistake


False by default


Removed. Indeed there is no need of this line here


居然还在更新 orz


Please re-add the script name. This is necessary to distinguish different files in multi-script or composite enging environments.


Exact, it's an affectation we need to clear all. Fixed mainline


Transaction


Test commend <false>


@jleclanche Help me out here.  This isn't the actual agreement is it? We aren't setting users to "Yes I accepted the agreement" by default.


huh libtool is host-only tool. you cant compile for target.


Looks like it was reformatted somehow, even though im just using a text editor... Ill see how I can filter out these changes to see actual code changes..


some reading
http://code.tutsplus.com/tutorials/pdo-vs-mysqli-which-should-you-use--net-24059
comments down there are good :)


Hi Arnaud,

OK, I will create a pull request.
> BTW Have you created an RFP for statismo on debian's bug tracker?
No, to be frank I have no experience with getting packages into debian
upstream.

Best
Stefan

On 14/01/15 08:58, Arnaud Gelas wrote:
>
> @zarquon42b <https://github.com/zarquon42b> this is awesome! I think
> you can create a pull request for this one!
> On my side, I am actually planning to remove the fedora packaging from
> the repository, since I still need to fix issues on the one for
> v0.10.1 (following review process) and I need to modify it for
> v0.10.2, I will create one dedicated repository for that...
> BTW Have you created an RFP for statismo on debian's bug tracker?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/statismo/statismo/commit/44cf60d7599bf29dfede0f886436d6c3980da635#commitcomment-9273920>.
>


yes of course, just waited for `mailparser` to release. I'd need to change the `mailparser` dependency in package.json though, as it depends on a change introduced in 0.4.8


fixed in 4db2576


Does this test leave a moto server around if an assert fails between ``setup()`` and ``cleanup()``?


thanks! Did you a PR for that?


No, the new user id column is created without a default, so it needs to be NULLable. We do the transition a few lines below.


All changes are ready mainline


Please avoid merging master into your local branch before pushing to master. Use rebasing + push without force and merge commit. Thanks !


saw approval from alexcrichton
at https://github.com/estsauver/rust/commit/2a320f21d0e5f943b9cd02bb7882531bfb7ef0b9


merging estsauver/rust/playpen_20732 = 2a320f21 into auto


status: {"merge_sha": "1c78ad937b4da9dd872b0a865025f3e2e885f90d"}


estsauver/rust/playpen_20732 = 2a320f21 merged ok, testing candidate = 1c78ad93


yes, it was missing, added


This needs to be removed and fixed