Thanks @wkeese for the review.

> The only thing I don't understand is the code above, which seems reversed from what it should be.

Looks confusing indeed, although being technically correct. The mqSmall media query uses `min-device-width: smallBreakpoint`, that is it matches for screens larger than the small breakpoint, and mqMedium works similarly wrt. the medium breakpoint.

To reduce confusion, I could rename the variables mqSmall => mqAboveSmall and mqMedium => mqAboveMedium (rather than the long variants mqLargerThanSmall / mqLargerThanMedium), or just add comments. Just tell if one or the other would be good enough for you.

Other related remarks/explanations:
* The entire thing could be rewritten in various more or less equivalent ways, for instance using a combination of min-device-width and max-device-width media features for the medium channel, but my preference went to only one media feature per query plus logical boolean operators.)
* I don't technically enforce smallBreakpoint <= mediumBreakpoint (consistently with the apparently redundant checks of both queries for the small and large channels). I'll add a comment about it.


agreed. I don't like it either, but the only sane fix for this would be to build addons after kodi.
And it would make building addons without first configuring kodi impossible.

Opinions?


dlatego ze nie ma tej metody to jest tak, nie ustalilismy czy torpeda ma jakis Radius, podobnie jak player


This strategy should be cautious. I can come up with many scenes may affected by this adjust:
1. hundreds of vm boot from the same base image
2. applicant's hot io size is larger than rbdcache's size, rbdcache is busy in exchanging osd side's pagecahce

This strategy may not generic enough


Erm... should say *margin*. /me needs more :coffee:


true if you're using SkyWay's TURN server. Defaults to true. You must apply at  to use.


Rejected in this form. At least for bilinear scaling and other ``--vo=opengl`` default settings, this should be disabled by default.


Thanks for the tips about javadocs and the link... I was always unsure as to which verb form to use. I'll try to stick to third person then.

Your second point I don't quite understand, in what sense is this backwards incompatible? Sure some alignments will be different now, but I wouldn't call that backwards incompatible. We looked at this issue for quite a while and compared it to other implementations and the strategy of no-open-penalty-at-beginning  seemed to be the consensus.


Nice ! Can you move the -webkit- prefixed properties on top of the unprefixed ones ?


83442720-ERVZoneMult-Issue4338 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (598 of 598 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.49%25-green.svg)


This is going to be awesome. Super excited for this to land.


I can confirm that this commit is definitely what is causing the problem.  Let me know when you fix it @mostaphaRoudsari .


Why check for scale_sep?


    ------------------------------------------------------------
    Client connecting to localhost, TCP port 5001
    TCP window size: 2.50 MByte (default)
    ------------------------------------------------------------
    [  3] local 127.0.0.1 port 41728 connected with 127.0.0.1 port 5001
    [ ID] Interval       Transfer     Bandwidth
    [  3]  0.0-10.0 sec  7.71 GBytes  6.62 Gbits/sec


>This is significantly faster for FBOs on most modern GPUs, although it
did not result in a huge difference for the video source texture on the
sizes I tested. It might be more significant for 1080p or 4K content, so
it's worth revisiting this in the future.

Maybe for your shitty drivers.... as far as I know, nobody on nvidia could measure a difference. Still ok though, if you're fine with the idea of adding additional hacks just for shitty drivers/GPUs.


It is not necessary to set iceServers if you're using SkyWay's TURN server.


Please include meaningful names for variables


```scala

class RowDNA[T,TX <: Traversable[T],TY] (val attributes:TX, val label:Option[TY] = None) {
  val isLabeled:Boolean = { label != None }
  val nbAttributes:Int = attributes.size
  override def toString = {
    "attributes: [" + attributes.mkString(", ") + "] label: " + label.getOrElse("(unlabeled)")
  }
}

trait DataDNA2[T,TX <: Traversable[T],TY] extends Traversable[RowDNA[T,TX,TY]] {
  val rows:Traversable[RowDNA[T,TX,TY]]
  val nbObjects: Int
  def foreach[U](f: RowDNA[T,TX,TY] => U): Unit = {
    rows.foreach(f)
  }
}

class Data2 extends DataDNA2[Double,Seq[Double],Int] {
  val r1 = new RowDNA[Double,Seq[Double], Int](Seq(1.5,2.5,3.5),Some(1))
  val r2 = new RowDNA[Double,Seq[Double], Int](Seq(1.5,2.5,3.5),Some(2))
  val rows = Seq(r1,r2)
  val nbObjects: Int = rows.size
  // TODO: implements the remaining parts
}

val datatest = new Data2
println(datatest)
```

Do you think this will be usable with RDD as well?


ok, will go back to this as the end


Use OPT_REPLACED.


done


ありがとうございます。

@dac4b820fd5ed768df163613b95d10eb225303c6


Acked-by: Feng Yang <fyang@redhat.com>


fixed


Why break this for every user and make use of it more complicated? It only requires 1 line per filter. I'd rather argue with should remove ``lradius`` again.


ok Thanks @mcm-ham
So we want that once donor is booking crossroads-truck for some value say ($100) and then if crossroads-truck pricing is changed, we do not want to change the value for which they have booked.
I will add this changes.


fixed, and now package name is just py27-pcre which I like much more.


Yo también he visto los mensajes en inglés y tampoco sé la razón de por qué habláis en inglés, la verdad


Here an example with some apache code:
https://github.com/samized/springboot-camel-bug


Get an array of PeerIDs of users connected with the same API key.


这样有换行符不知道能否正常读取


I have translated many strings to arabic, yet the website says that number of completed translations = 0 ! What am I missing ?


good catch


If you wish to use SkyWay's TURN server, you can apply  here.


si se hace ciencia abierta, se hace de forma que pueda entenderla todo el
mundo posible.

El 22 de enero de 2015, 10:01, Maribel García Arenas <
notifications@github.com> escribió:

> Yo también he visto los mensajes en inglés y tampoco sé la razón de por
> qué habláis en inglés, la verdad
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/noisy-gecco-2015/commit/946563504153291e7e4cc1ff9fc2c0a8e68fc234#commitcomment-9392797>
> .
>

--
JJ


见鬼，哪里搞错了，我修复一下。


The issue is that `plus_atom::value` does have a different type than `minux_atom::value`. Although the compiler could use the conversion operator to "cast" both expression into `atom_value`, at least GCC complains about this line and does in fact not convert the values.


This option doesn't need to be set if you're using SkyWay's TURN server.


Spaces.


Lots of changes in here that should probably be in a different commit, eg. ObjectImpl


@jamesisaacs in the case you describe, although ES would continue to index the removed field (setting it to null), API users wouldn't see it as no doubt the developer would remove that field from the view template. As such I don't think it's a serious problem.

I think that even with this auto-recreate/import tool, the engineer carrying out the deployment still needs to be aware of  which indices need to be recreated. Most of the time, their thinking will switch from "after the deployment has been done, I need to ssh onto the server and recreate X" to "X will be recreated during this deployment", but there may be the occasional time where we'll be thinking "ok, mappings have been removed so I'll need to recreate manually this time round". I haven't been able to come up with a more fool-proof way to do this, so that we can essentially "fire [off] and forget" on a deploy and be sure it will do the right thing every time (apart from writing an ActiveRecord-esque migration system that chooses when to recreate rather than what migrations to apply).


Добавлен Hpple для парсингта html


Y tengo otra pregunta. Por qué lo habéis llamado noisy-gecco y no
2015-Gecco-Noisy como hicimos con Evo* para que luego aparezcan
ordenados que sino esto empieza a ser poco tratable.

J, se puede cambiar el nombre?

Maribel

On 22/01/15 01:19, Antonio Mora wrote:
> ¿¿¿¿¿Por qué leches habláis en inglés entre vosotros?!!?!?!?!?!?!
>
>
>
> Bueno, no estaba al tanto de que esto se iba a enviar, en cuyo caso
> hubiese aportado algo…
>
> Participaré (mucho) más en la versión completa, claro. ;)
>
>
>
> De: Juan Julián Merelo Guervós [mailto:notifications@github.com]
> Enviado el: miércoles, 21 de enero de 2015 19:36
> Para: geneura-papers/noisy-gecco-2015
> CC: Antonio Mora
> Asunto: Re: [noisy-gecco-2015] First version of the abstract written
> (9465635)
>
>
>
> just go and change it.
>
> 2015-01-21 19:34 GMT+01:00 Pablo García Sánchez
> <notifications@github.com>:
>
> > The three problems should use the same verbal tense: "the evolution of
> > bots for A, evolution of bots for B and finally, the design of
> backstories
> > for C" @jj <https://github.com/jj> @amorag <https://github.com/amorag>
> > @deantares <https://github.com/deantares>
> >
> > Also, "operartors or eas" or "operators for eas" at the end?
> >
> > —
> > Reply to this email directly or view it on GitHub
> >
> <https://github.com/geneura-papers/noisy-gecco-2015/commit/946563504153291e7e4cc1ff9fc2c0a8e68fc234#commitcomment-9381691>
>
> > .
> >
>
>
>
> --
> JJ
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/noisy-gecco-2015/commit/946563504153291e7e4cc1ff9fc2c0a8e68fc234#commitcomment-9381709>
> .
> <https://github.com/notifications/beacon/AC6-WmPE2QIPiOp8I0bDzFEAvVcCu1s5ks5nj-j9gaJpZM4DVYbv.gif>
>
>
> No se encontraron virus en este mensaje.
> Comprobado por AVG - www.avg.com
> Versión: 2013.0.3495 / Base de datos de virus: 4257/8970 - Fecha de
> publicación: 01/21/15
>
> _____
>
> No se encontraron virus en este mensaje.
> Comprobado por AVG - www.avg.com
> Versión: 2013.0.3495 / Base de datos de virus: 4257/8953 - Fecha de
> publicación: 01/18/15
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/noisy-gecco-2015/commit/946563504153291e7e4cc1ff9fc2c0a8e68fc234#commitcomment-9388462>.
>


修改之后还是最好先git diff看一下再git add比较好


赞！！


    ------------------------------------------------------------
    Client connecting to localhost, TCP port 5001
    TCP window size: 2.50 MByte (default)
    ------------------------------------------------------------
    [  3] local 127.0.0.1 port 39959 connected with 127.0.0.1 port 5001
    [ ID] Interval       Transfer     Bandwidth
    [  3]  0.0-10.0 sec  7.69 GBytes  6.60 Gbits/sec


这次增加的太多了，看了前面几行没什么问题就没往下看了，我的错。
辛亏你发现得早。


I don't remember the exact circumstances, but given the commit message I don't think I intended to add the plone.app.robotframework pinning. @pbauer and me actually stumbled over that and repinned to the current version to see whether that works better for us.

With this in mind I second the motion of removing our custom plone.app.robotframework pinning and relying on the one from Plone core.


Remove the hard coded values and define as constants


This also fixes bug.
https://bugs.winehq.org/show_bug.cgi?id=30104


Le template d'article créé (content-single.php) va être utilisé pour toutes les catégories. Il faut différencier chaque catégories.


These functions are used in a callback struct and that is the only way they are invoked so their pointer is taken. I've tweaked layout and naming a bit to make this clearer.


还好还好，习惯先看commit了


http://twittercounter.com/ provides an api that returns **publicly available** Twitter account statistics. For this application, the `followersperdate` object gives us the information we're looking for.

The key for the api **does not** give anyone access to modify or change the Twitter account or post tweets. It is a **READ ONLY** key that gets statistics and publicly available information.


L 01/21/2015 - 21:29:53: [SM] Native "IsClientInGame" reported: Client index 122 is invalid
L 01/21/2015 - 21:29:53: [SM] Displaying call stack trace for plugin "saxtonhale.smx":
L 01/21/2015 - 21:29:53: [SM]   [0]  Line 3745, saxtonhale.sp::ClientTimer()


Just a note: For spells, I have been using this [card generator project](http://crobi.github.io/rpg-cards/). The quick reference sheet is actually based on the design of the card generator.

The players handbook contains hundreds of spells, are you planning on adding them all? Or just create customized reference sheets where each player sees only his or her spells?


done


I assume _register_hook has no return value?


Oh... It's my remiss.


ok


Thanks, fixed by ae56a8b9e4c37e5b5044e7e53b81b4277d01212f.


yeah sure, as i'm planning to invest quite some time in the framework i hope to be of help some day.

btw i thought about where to put my above comments. maybe the google group would have been the better place?
i have some other questions regarding the api, should i put them there?


Why not? The s3 is still low on ram compared to modern devices. Performance-wise I didnt notice any difference so far


Why cant we use the interface name as a name if no name is provided?
I am not oposed to the possibility to have a simpler lookup by name, but as soon as the behavior I am going to write is not core or very common, I am going to namespace it, and the interface name is already a namespaced name.


Looks like even on my fancybox setup it says 2.1.5 the `&& locked.length` is not part of the code I've got (don't you tick revision for each fix release?).  #988


I thought "Autotools: Build plugins with Libtool on MinGW too"


do we need to dispose this font?


wut


"Go to" <TufanneT> [http://www.facebook.com/tufankam]


这时候调用 rt_ringbuffer_space_len(rb) 已经晚了，因为上面已经对 rb 进行了修改。下面的那个同理。可以改改再来，加油～

另外，commit message 的内容可以写的更丰富些，第一行是简要信息，最好不要超过 85 个字符。第二行是空行，然后第三行开始之后是详细描述。可以把问题的细节，谁报告的问题，解决的方法等写上。参考： https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=72dd299d5039a336493993dcc63413cf31d0e662


The assignment 5 can be pushed here, so that we can talk it over~:walking:


@matheusgimenez apenas fazendo umas melhorias no Admin que você já havia pedido a um tempo. Qualquer coisa que quiser de CSS é só criar issue ai que vamos evoluindo esse filhote.


另外，commit message 最好是英文。多谢！


ditto


@karenetheridge ++


What happens if you leave that bit out? Will all the other methods use the default colormap (see `beautify()`) if `colormap=None`? If yes, I'd rather have this block removed, so the plotting methods use the default settings (which are configurable in a central config file) if not overwritten explicitly.


Yes - I've neatened this up by using explicit variables to compute that register arg lists and such to remove the need to use -2 etc. all over the place.


thanks for spotting it.


Fixing line endings is :+1:, but could it in a separate commit ?


I suppose it can have. Fixed that now. Thanks!


Heading
lorem ipsum


Putting all 1300 icons together in one sprite is not necessarily a good idea - you'd almost certainly use *more* bandwidth, as most of the icons are unused. All the images together are currently almost 20Mb, so you'd have to reduce the resolution or customize the sprite to contain only those icons that are really used.


thank you


    ------------------------------------------------------------
    Client connecting to localhost, TCP port 5001
    TCP window size: 2.50 MByte (default)
    ------------------------------------------------------------
    [  3] local 127.0.0.1 port 46482 connected with 127.0.0.1 port 5001
    [ ID] Interval       Transfer     Bandwidth
    [  3]  0.0-10.0 sec  7.56 GBytes  6.49 Gbits/sec


WITHOUT a timezone -- another pattern should be used, which is out of scope for the case with timezone pattern.


I just copy/pasted what used to be in extensions.xwiki.org and which was broken by the import. You can put anything you prefer :)


Como posso utilizar esse arquivo em uma instalação do CiviCRM?


is there any fix for bad param issue?


done


An empty array will eventually be removed up by cleanup, but it's better to pop straight away, because cleanup might not get called (e.g. if keepalive is False).


Can Nikola get rid of `TaskMultiplier`? I guess that using stages it wont be necessary any more...

Is there any plugin other than GZip that uses `TaskMultiplier`?


There's no fix for rejected virtual numbers.


@AlexanderWillner why did you delete the range?


Yes, keeping the old behaviour is a good idea :)
I'm totally okay with it, please, go ahead and merge it :)


Hi, I'm trying to submit this library to the FreeBSD Ports Collection, and we have a minor issue with its name. Is it called python-pcre or just pcre? Could you please upload it to PyPi?


What happened to the readme? O_O


Maybe, but it doesn't hurt. Also, this is intended to get Google hits, not Github hits.


- You may refer to Please refer to
+ You may refer to
or
- Please refer to


    ------------------------------------------------------------
    Client connecting to localhost, TCP port 5001
    TCP window size: 2.50 MByte (default)
    ------------------------------------------------------------
    [  3] local 127.0.0.1 port 43344 connected with 127.0.0.1 port 5001
    [ ID] Interval       Transfer     Bandwidth
    [  3]  0.0-10.0 sec  7.60 GBytes  6.53 Gbits/sec


done (dep of dove)


Yeah you are right it's useless


Какой-то отстойный класс из одного огромного метода :)


Why do you want to make injected events and instances protected? In case you want to use them outside the class they are declared, it is rather suspicious to me as I am not sure what you are trying to achieve by that.


Any reason to lock after getting the time rather than before?

Thinking that maybe it's possible that someone else locks between the calls and spends some time with the lock held -> "now" becomes "a moment ago" and the if might be late. Not sure if it's relevant here, but...


Did you mean to use tabs here?


done


While reading the code again, I was wondering, where `cin_islabel()` is checking for a label. After all no line pointer is given. Turns out, it checks the current cursor line, which must not be the same as `lnum`.  So that is the reason, why the old code changed the cursor line to `lnum`.


I actually already fixed this locally, I will probably make a minor release tonight with this fix.


this.state.fetchState is not used anywhere in this component. The fetch state comes by the properties:
fetchState: React.PropTypes.number.isRequired


For function comments `///` is used instead of `/*` and `*/`.


I am referring to the 'query' parameter you pass to the constructor. IMO this should be a Lucene query, especially since in a local environment there is no need for serialization. If we need so serialize, it should be handled by the configured serializer (be it native Java or Avro) to do it transparently for you. Similar to how we handle the Lucene Document in 'add' work.


Hey! This issue caught my eye so I took a look at the change.  Anyway:

I'm thinking the exception catching only wrap the `getSystemTimerManager`, as `action` could throw an `IOException`, causing the whole thing to be tried again!


```
- The following examples various ways
+ The following example shows various ways
```

I'm not very sure if this can be a typo, but the latter reads much natural to me.


What's that for a language construct?


Không đẩy thư mục .idea lên


此包名作废。


Correct, thanks. Before it's booked we were thinking it makes sense to store the quote/price as part of the crossroads_transports table instead, not offer.

One thing about storing price on crossroads_transports though, we probably just want to set offer.crossroads_transports_id on the client and then on the server save the price and mark offer.crossroads_truck_cost readonly via the API, otherwise people can play with the price locally. If we do change the price we'll manually send a socket.io broadcast to update the crossroads_transports locally.


`s/highlightion/highlighting/`


此包名不用。


4660-glheErrorMsgCleanup (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1586 of 1591 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69%25-yellow.svg)


@greg80303, I have another proposal that is very close to yours, but a bit different:
	1. Remove ClearKey specific event `ENAME_CLEARKEY_LICENSE_REQUEST_COMPLETE`, remove  `updateKeySessionClearKey` from `ProtectionController` and from `ProtectionModel`
	2. Add `isClearKey()` method to `ProtectionExtensions`.
	3. In `ProtectionController` use `ProtectionExtensions.isClearKey` to pass the third `isClearKey` parameter to `ProtectionModel.updateKeySession()`. Something like this:
```
//ProtectionController.js
updateKeySession: function(sessionToken, message) {
    var isClearKey = this.protectionExt.isClearKey();

    this.protectionModel.updateKeySession(sessionToken, msg, isClearKey);
},

```
Thus, the ProtectionModel could be able to convert arguments in an appropriate state as before.


Unhandled Fundamental Failure


comps/ has a rubygem- prefix, which is what the packaging guidelines would need too, it should be here?


@quintesse sorry I had to revert this because it blocked `ant clean publish` but feel free to make it work again ;)


应用市场数据所请求权限。


@line 185: No asserts for the new dicts?


Less is more. It was previously a duplicate of the website. This keeps it more targeted.


great @Dappsen ! just one thing, I have changed the language key in order to explain this, could you let me know the translation in german for it now? I can add it to the file :)

"Enter the URL of an image which represents your page. If empty, the icon from the Advanced section of the page will be used and if empty, the site Logo will be used."


why not override Model.save method to clean field value? This is a clear, easy way and less code than using signal handlers.


No abs() available? If not, ABS() macro would be nice...


`~1.0.5` might be a better version constraint. Or, if you are following semantic versioning, then `~1.0` or even `^1.0.5` would be better suggestions.

The key thing here is you should use a version **constraint**. If you want to have a specific version of a dependency, then that's what the composer.lock file is all about.


lol.. a view factory.


支持到5.0


@jreidinger W T F!
You are changing the implementation of a ****ing messy method, and don't bother commenting on the safety of doing that?


Do we need to call this `@_view`? or can we just call it `@view`?


thanks again!


#heigut


URL für das Bild einfügen, das die Seite repräsentieren soll. Falls
leer, wird das Icon aus der "Erweitert" Sektion genutzt. Falls auch
leer, wird das Seitenlogo genutzt.

Greetings :)

Am 22.01.2015 um 10:39 schrieb Julio Camarero:
>
> great @Dappsen <https://github.com/Dappsen> ! just one thing, I have
> changed the language key in order to explain this, could you let me
> know the translation in german for it now? I can add it to the file :)
>
> "Enter the URL of an image which represents your page. If empty, the
> icon from the Advanced section of the page will be used and if empty,
> the site Logo will be used."
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juliocamarero/facebook-liferay-integration/commit/eb921b68b754372d29ce06b82f96100250d5bb74#commitcomment-9393340>.
>

--

Integrata-Stiftung für humane Nutzung der Informationstechnologie
Postadresse: Vor dem Kreuzberg 28
D-72070 Tübingen


this functionality will not work


Haha, passing the constructor to atom.views.addViewProvider somehow makes the entire plugin not load.


Better use:
for i, layer in enumerate(layers):


This method is used in yast2-sysconfig, which means that breaking this will eat people's configuration data. For me, "reduce deepest nesting" is a pretty tiny gain against a big risk.


What was 1.0.0 removed?


83442720-ERVZoneMult-Issue4338 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-73.08%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Weird, perhaps file a bug against atom, they are pretty responsive.


Unneeded newline?


нет


Oops, meant commit 5c16863696cbad74d54e660908f7b708b264324d in the title.


Maybe move below the two lines you added


нет

2015-01-22 10:00 GMT+03:00 ilnur <notifications@github.com>:

> Эти конфигурационные файлы поддерживаются ejudge-ом старой версией?
> У меня стоит верися 2.3.29:
> https://ejudge.ru/wiki/index.php/%D0%9E%D0%B1%D1%80%D0%B0%D0%B7_%D0%B4%D0%BB%D1%8F_%D0%B2%D0%B8%D1%80%D1%82%D1%83%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D0%B9_%D0%BC%D0%B0%D1%88%D0%B8%D0%BD%D1%8B
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blackav/regionals-2015-training/commit/c405fd1641e95f51dc57f35998eedc4580306ba0#commitcomment-9391421>
> .
>


Indentation


Looks good. I can't think of anything to add right now. I like the prefix naming convention.


There is a system of translations proofing, but it is not very important for us. The main thing, is to have "Untranslated" = 0 (not it is 138)


This commit accidentally included the major update of the Mitchell parcel query that should have been included in the subsequent commit (https://github.com/groundtruth/PoziConnectConfig/commit/f3cc19f8389d2f92613986df09761f0bc0a9cd6f)


I see that in this commit, which is a follow-up of pull request #25, you've removed the `optarg != NULL` checks. Although `optarg` should never be `NULL` in case of option `'i'` and `'d'`, which is guaranteed by (the successful configuration of) `getopts`, I believe it is good to check for it nevertheless. It is easy to make errors in `getopts` and these simple checks will avoid NULL pointer deferences. It would therefore be good to include these checks again.


I think its on purpose, the method used to take an object with members modelConstructor and viewConstructor, now it takes two arguments.


Won't this memoize the error cases as well? Also should we have a way to clear the cache?


fungera dette :)


Hi,

You need to refer your custom bus (`cxf`) in the endpoint URI:

    from("cxf:/incident?serviceClass=" + IncidentService.class.getName() + "&bus=#cxf")

Otherwise Camel will try to create the bus for you. Unfortunately Camel refreshes Spring context while creating default bus, what collides a little bit with the Spring 4 application lifecycle.

Please try it and let me know how it works. BTW I will use your example as a base for Camel+CXF tests. I will also try to make camel-spring-boot and camel-cxf a bit smarter to handle bus registration nicely.

Cheers!


I would have expected an update to the `.iml` file to go along with this change.  Please resubmit with that file's changes.


We could have a `@memoized(ignore=(None,))` to have it not cache `None` values?


@softark thanks! https://github.com/yiisoft/yii2/commit/4002512dd1149197a000ffeaf132a16064927ac5


:beer:   do you mean `+      cleanup(dir, done);
`can take up to 100s?


So when do we add localization? :P


It should not be used outside the class, that's all.


Ah yep that makes sense.


Should we have a `USER_TOPLIST_URI` constant perhaps?


Definitely a good thing to consider.  Looks like the current System.Timeout code does this: http://hackage.haskell.org/package/base-4.7.0.2/docs/src/System-Timeout.html

It looks like System.Timeout has a timer manager based implementation, as well, but with a fair amount more machinery.  Maybe a simpler implementation like this can be used if you can be sure `action` is interruptible?


Nightly passes.
Weekly has a few pos tests failing in one of the config, which I'll ignore.
It also has 2/3 neg tests around string interpolators that failed in 4 builds. These are a bit weird, so I'll come back to them in a future version, but I won't worry about them now.


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=4f626fb4abc14164a031b0df894819c3
 plone-5.0-python-2.7 [FAILURE]


i think we're referring to SortUseNameSpace->format()
imo, it's safe because it's a strict regex
it only looks for /^use/ <- begin of line. and it does not allow spaces. If the core parser indent everything correctly, then it's not an issue, certain fail-safe already been considered as well in the code.


両方がそれぞれシンメトリックNATの内側にいるというふうに読めなくはないので、このままでいきます。


Ah yep, that makes sense, so kind of like how python marks things as private.


Could / should we look into loading these in parallel? We should maybe check if we can trigger non-blocking loads and then do a second blocking pass to emit them in order?


`@param[out] pp ...` because `pp` is set in this function.
There is no example for that in memory.c, sorry for that.


うーん、確かにそうですね。そうしましょうか。

dj_level_diffはどうしましょうか。
- dj_level_target (例えば、'AA')
- dj_level_diff (例えば、'-54')
ってやればいいかな？

なるべく、下の例みたいな階層は作りたくないです。
{dj_level_diff: {target: 'AA', value: '-54'}}


I tested with inline  HTML which had lines beginning with use, and it touched them. It must not touch inline HTML. Sorry. This has to be fixed.


sure @mcm-ham


could you provide me with the failing snippet (inline html)? so that i can work on it


I appreciate what you are trying to do and I'm fine with this if you think it's for the best, but I also believe that because we are in full control of the code, if you know you shouldn't do it (access the variable directly) you probably wouldn't do that by accident. So, keeping things simple (i.e. named `@view`) might be considered preferable.. but in the end I'll defer to your judgement since you are writing the code.


Please, give the key names accordingly to their meaning.
'radiobuttons' should become something like 'workTypeRemoteCheckbox'


Monolio,

Can you explain what you mean with B/Projection?


ThreeView,

For me is working fine in 2.73a, but I will investigate it.


please, name the class 'work-type-option-remote' to display what does it mean for us


I have not found where the constant is declared ACQUIA_SEARCH_ENVIRONMENT_ID


That would require NMS, I already did that in Derius. https://github.com/Derius/Derius-Core/blob/master/src/dk/muj/derius/DeriusSender.java


s/.CH/.IO


I'm not sure this is needed, the title should be set in *DisplayableLFImpl.setTitle0*


ssss


7: M102 unrecognized bullet/signature


will removed


control queue returns a tuple. First element will be stored in control_elem, second one in index. This is the assert that the control_elem should be a CONTROL_ELEMENT.LOCAL which is 0 or 1 IIRC.


+1 for your suggestion of making `blank` mean all countries. Having an explicit `none` country could also be considered. A final thought could be having a `+NO` type notation to add to the list without having to redefine it, but that is probably overkill.


We are talking about the journal record from the vanilla saved game files, right?
I suggest to just add a second enum for the journal record (REC_JOUR_LEGACY or something) that has the "\nOUR" value. After all the vanilla record and the OpenMW record are not the same, so having them share an enum constant doesn't actually gives us any advantages.

btw. this

> change them all to use the FourCC template

is a very good idea.


@mitjanikolaus because the reasoner exited with an exception after my refactoring, since the "port" property of the dummy was not string but int. Quick fix - maybe overwriting the range somewhere makes more sense.


I think we can also follow the same signature here for the method name, what do you think ? logRequest etc


logResponse :)


`from pytest.mark import parametrize`

This makes the code even shorter :)


Good call on this syntax, @mpapis.


Why not cherry-pick?


I blame github for not letting me comment on the catch statement.


cool, get some sleep. i'm having problems building kodi-platform. I cloned https://github.com/notspiff/kodi-platform but can't figure out how to point it to the kodi cmake stuff. i get the following error: http://pastebin.com/rzE3upLc. I've tried setting many variables to different paths all over the place, but nothing finds kodi's package configuration file


Is this message overly verbose?


You could do this update if you need to make sure that it's indeed no lower than 0.14.3 / 0.3.1. But otherwise it's not needed. There is no need to go and update all the `^x.y.z` every time. They install the lastest in 0.14 / 0.3 anyway.


``The PeerServer cloud service does not provide a TURN server. You'll have to find your own. ``は削除したほうがいいと思います。


Yes, what I meant to say it will bring everything into one function with less duplicate code but it is only a suggestion.


I checked it again and you're right, I misinterpreted my own comment. :-)
You have to take the return status into account.


リンクが貼られていないです。


1277852-CommandLineInterface (nealkruis) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.86%25-red.svg)


@nikku what was the breaking change?


Personal curiosity, why remove the refresh?


can be refactored to common pattern with something like:
```
let isGood path = .. then Some path else None

["14.0"; "12.0"; "11.0"; "10.0"]
|> List.tryPick (findVSInstallDirInRegistry >> isGood)
|> function Some p -> p | None -> failwith "could not"
```


[TestMethod]
        [ExpectedException(typeof(ArgumentException))]
        public void NodeNextCantBeThis()
        {
            SinglyLinkedListNode node = new SinglyLinkedListNode("foo");
            node.Next = node;
        }


lalalalalala


nah it's good


This test expected for a new argument exception when setting the value of the next node equal to the node on which this method is being invoked.

When such an attempt is made we will initializes a new instance of the ArgumentException class.  Otherwise the value of the next node will be returned.


magic number!!

![magic number!!](http://i.imgur.com/CERPqgq.jpg)

Y U NO Use HALFSIES?


Hi @Parth-Brahmbhatt,

I've been testing this feature and it works great, congrats.
However in this last commit I believe you forgot to change the keyword :bt-tracker to :code-distributor. As consequence nimbus does not generate/submit the storm-code-distributor.meta file.

Arigato.


Rodo sabrias decirme que tipo de Json se espera aca? Porque como en el test se usa un toJson de un String esto no falla, pero yo que no tengo esas utilidades no se que poner. Digo, yo imaginaba que para armarlo necesitaria poner algo del estilo....
{"string", "4108923712dasdhjk123"}

Que onda? quise poner algun breakpoint y ver efectivamente el body en texto plano que mandabas pero no tuve exito


Fixes https://github.com/aws/aws-flow-ruby/issues/82, https://github.com/aws/aws-flow-ruby/issues/70


Why not drop `fake_client` (and `subject.instance_variable_set :@client, fake_client` below) and do `allow(subject.client).to ...` ?


Fixes  https://github.com/aws/aws-flow-ruby/issues/70


This a clever way to ~~fake~~ simulate a response.


n00b Q: What is the intended semantic difference between clone() and copySyntax()?  Should we DRY here by having one call the other?


@cquammen When you have a chance, let me know what you think. This avoid a Slicer crash after updating to a recent VTK.

The associated Slicer code is in [Modules/Loadable/Volumes/Widgets/qSlicerScalarVolumeDisplayWidget.cxx#L243-244](https://github.com/Slicer/Slicer/blob/f59a689a0f6d2912538ed72dad16efc70601f0ed/Modules/Loadable/Volumes/Widgets/qSlicerScalarVolumeDisplayWidget.cxx#L243-244)

After reverting the patch, you can reproduce by (1) loading MRHead, and (2) opening the volumes module.


nice beginning thanks


version is supposed to go in version.sbt, fwiw. I just deleted the version number from the viz file.


Please put in development group.


`fake_client` was my workaround, since `CouchRest::Database` instances have a `@streamer` instance variable (itself an instance of `CouchRest::Streamer`) that would have been harder to mock (see [here](https://github.com/couchrest/couchrest/blob/master/lib/couchrest/helper/streamer.rb)).


VMOV is redundant, you can do VSUB directly in to vD0


Spaces for alignment.


 [TestMethod]
        public void NodeToString()
        {
            SinglyLinkedListNode node = new SinglyLinkedListNode("foo");
            Assert.AreEqual("foo", node.ToString());
        }


@bytemaster Stop reverting the submodules.


Oops, did this end up in the x86? Forward branching was never merged (right?), so this probably shouldn't be there. Though I guess it doesn't hurt much...


Override (C# Reference): https://msdn.microsoft.com/en-us/library/ebca9ah3.aspx

Object.ToString Method: https://msdn.microsoft.com/en-us/library/system.object.tostring(v=vs.110).aspx

Knowing When to Use Override and New Keywords (C# Programming Guide): https://msdn.microsoft.com/en-us/library/ms173153.aspx


I tested with almost 100 files on windows and the import to iTunes didn't cause any crash, it was fast and smooth, I guess you were importing almost thousand :P

I'll test any way the new method and trying with hundreds more files.


84202576-DesSpecOA-PerPersonUsedWhenFlowArea (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (597 of 597 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.36%25-green.svg)


=D


I guess there are two schools of thought, its good to discuss this stuff :) :+1:


Did you mean to expose your credentials on github?


nazwa zipa z rozkładem zakodowana na sztywno w testach. jeśli pobrałeś nowy to podmień. do zrobienia znajdowanie w bieżącym katalogu odpowiedniego.


Should we just go ahead and remove the dead fields, methods, and calls here?  I think the new approach is better and don't think we'd go back, and if we did we'd have to roll back parser def etc. to this cl anyway?


Uh, weird indeed. I hadn't realized it (maybe some IDEA correction?). I'll revert to the previous `else if` / `else if`.


@mushishi78 Great job! but seems this is wrong. Could you review #5938 where I explain why I suspect this is wrong. It is not covered for the test suite. I can work in a PR if you prefer. Thanks


ToString's default implementation is to return the name of the type of the object.

We have previously modified public string to Value.

We are now overriding string to return Value provided by the accessor on public string Value.


Nice man :)


Thanks! I will fix it!


The name of the node foo is equivalent to it's Value.  When we call ToString it will return the string Value.


r+


![screen shot 2015-01-22 at 19 27 57](https://cloud.githubusercontent.com/assets/1155163/5867641/cd1ebaa0-a26c-11e4-9d2b-da45ae666272.png)


insert space after `name,`


I assume you changed this for a unit test. Is there a changed file missing from this PR?


I'm putting these in the main template file just temporarily until I get the layout the way I like it.


82420068_GridViewMultiEdit (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2174 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.36%25-yellow.svg)


sorting the collection on the dates.


Fixed via fdeb0ac


How ? I'm a bit tired and i've a headache. Thank you Orange Dolphin :P


Since all the elements are going to be clickable, it's easier to use `<div>`s and `<a>`s than `<ul>` and `<li>`


why not only "dotnet" and "nuget"?


VSUB(vD0, V0, vB0);

Then just delete the VMOV


Is there a way to do something when HTML is done rendering?


Shouldn't it be a "LimitedTimesPerTurnManaAbility" (that does not exist yet)?


No, that is not it.  Apparently, something else has happened that caused the new test errors:

```
--- FAIL: TestPermalink (0.00s)
	page_permalink_test.go:68: Test 0: Expected abs url: /x/y/z/boofar/, got: x/y/z/boofar/
	page_permalink_test.go:78: Test 0: Expected abs url: /x/y/z/boofar/, got: x/y/z/boofar/
```

I could not reproduce the error when I first run `go get -v github.com/spf13/hugo` with the latest Hugo HEAD, but after running `go get -u -v github.com/spf13/hugo`, I can't get rid of the error messages.  :-p  It seems likely that the behaviour of an upstream library has changed.


 I will check it out.

Sent from my iPhone

On Jan 22, 2015, at 6:32 PM, LevelX2 <notifications@github.com<mailto:notifications@github.com>> wrote:

Shouldn't it be a "LimitedTimesPerTurnManaAbility" (that does not exist yet)?

—
Reply to this email directly or view it on GitHub<https://github.com/magefree/mage/commit/d218279b042152f54a7703f7465877eadf93a7a9#commitcomment-9408077>.


Tole tearin it up


This chunk is definitely wrong, revert plz. Assignment is relevant here.


these should be gone entirely for 2.4.0-stable, it's configurable via PaperCip now


commented out?


Browserify 8.0 (way 7.0 in the last release)


why is this commented out?


La idea era que el body directamente fuera el id, pero si querés lo cambio a algo del estilo que decís de clave-valor. Confirmame de que forma te parece mejor que se cambia en un toque


Yeah, nothing about Searchy or Crowbar is registered for shit.


is this the right dependency? why not `'~> 2.4.0'`


Can you update this commit message to answer "why" ? thx :)


can we use Context instead of Ctx?


I did not test negative exponents.  At quick glance it looks like it should work though.


Looks good! I'll give this a quick test in the morning and merge it.


No, it was changed because the existing unit test started failing. Previously getAttributeNames() of the request object was never used by AccessEvent (and consequently the test) so it did not matter what value this method returns.
However as we now creating a copy of attribute map on the first access, we need to get list of keys from getAttributeNames() method. So we just included all the keys the test is using.


not intended...


I'm thinking `attr_accessible` should stay until this is upgraded for Rails 5. By adding a dependency on https://github.com/rails/protected_attributes


At what point are plugins expected to register flags? If you depend on WorldGuard, wouldn't the init have already been completed before the plugin is enabled?


Please keep consistent syntax with the rest of the project. Lets revert to the pre 1.9 hash syntax in this case.


Why bumping the required ruby version?


Found the "culprit":

* https://github.com/PuerkitoBio/purell/pull/5

If I do this:

```
$ cd $GOPATH/src/github.com/PuerkitoBio/purell
$ git reset --hard HEAD^
HEAD is now at 1909519 Merge pull request #4 from ciarand/master
$ rm -rf $GOPATH/pkg/
$ cd $GOPATH/src/github.com/spf13/hugo
$ go get -v github.com/spf13/hugo
github.com/PuerkitoBio/purell
github.com/spf13/hugo/helpers
github.com/spf13/hugo/source
github.com/spf13/hugo/target
github.com/spf13/hugo/tpl
github.com/spf13/hugo/hugolib
github.com/spf13/hugo/create
github.com/spf13/hugo/commands
github.com/spf13/hugo
$ go test -v ./...
```

The page_permalink_test.go errors then disappear.  Please investigate.  :-)

I will be reverting this commit for housekeeping purposes.  ;-)


Ae, @Fellype, coloquei o item no final E dentro do campo de texto usando um RelativeLayout. Bjs.


Client trims the "\n", but there was no "\n" so it trimmed the letter "t" in the end of "request".


Weeeeelll maybe using a another task to calculate its dependencies, and making sure somehow that it depends on every other task ever (like if it were stage +inf)


And no, off the top of my head I don't think there's another use of it anywhere.


Client trims the last character which is expected to be "\n" (used to trim the last digit of the pid).


So, it looks like this code potentially changes the argument "xs" silently?


This sounds like to me that we are increase the footprint of api in helping our implementation. For most cases, epoch is  available system already. If we channel everything through state machine, we should not need this.

If it is an opaque data structure, at least we have the chance to reuse it later.


Stripped it directly from the x86 code there.


If you're going to use this heading, people are going to expect that all grunt tasks be available in a list.

At that point, this is not only a list of ways to build or preview, so `grunt && grunt watch` as a single list item is not appropriate. All other grunt tasks would have to be listed (I'm not sure how many there are)


Why not `Tracy\Bridges\Nette` or `Tracy\Bridges\NetteDI`?


In another word, we can channel this call through the state machine?


Before fromaddr.sin_family was initialized, it got trashed with an invalid value and the server terminated the connect() attempt below with EAFNOSUPPORT.


maybe adds language_choice: :sylvan


It has to be done in `onLoad()`. Unfortunate, but Bukkit doesn't have anything after `onEnable()` and region data needs flag information in order to load correctly.


remove this line


do not modify this line


this is good ;-)


A screenshot of the new UI:
![screenshot]
(http://i.imgur.com/cxyJ9ec.png)


High: you must test all the public methods, and cover the uses of the private methods from the public invocation.
In this case you are testing just getDollarsAmount. Did you create the class using TDD? Maybe you found it on the internet and then create the test, that's ok but cover all the public methods.


Using this code:

	$f3->route('GET|HEAD /test', function ($f3, $args) {
		trigger_error("Harmless notice", E_USER_NOTICE);
	});

I get the following response for `GET /test`:

	Internal Server Error

	Harmless notice

	• /vagrant/vendor/bcosca/fatfree/lib/base.php:1422 Base->call()
	• index.php:36 Base->run()

This is fixed with my proposed change.

_Tested using PHP 5.3.10-1ubuntu3.15._


1277852-CommandLineInterface (nealkruis) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.34%25-red.svg)


Reverted in a61cd19cf8438049d0228d9ee50eec1dd9360d6f


Medium: contents must be in capital letters.


Hmmm.... look like I may have an issue with my release script. The commit log should identify a release tag.


would an increment method here be useful? Seems like: `def increment(s: Int): MaybeLength`


medium: N should be "number" to be clear.


No, -xs makes a copy of xs. Besides, with both the old and new code, we didn't make a copy when it was a :Max anyway.


Thanks for the explanation.

Will you use the nested numbering scheme of healpix? I remember that
healpix key is non-unique cross different n_side.

The fixed node<->skypatch mapping makes sense. But different experiments
have different sky coverages; I wonder what the implication on storage
balance this has.

Is buffering zones (adding a margin to the trixel region for the data
actually stored on a node) compatible with the current model? (the answer
seems to be yes; as the model is sufficiently coarse)

Can I say that Data Set:= table of (ra, dec, attributes), each entry
corresponds to an 'object?

I wonder if trillion can also host intensity maps?

On Thu, Jan 22, 2015 at 3:28 PM, Demitri Muna <notifications@github.com>
wrote:

> I do need more documentation; that is still on my plate. Trillian is
> currently modeled to have a central server (represented by the "server"
> table, which will be filled out with properties I'm sure over time).
>
> Node: A second server that is connected to the central server. The node
> may provide storage, compute capability, or both. Note that the central
> server is also a node in this sense. (For a while, it will be the only
> node.)
>
> Dataset: A catalog or specific release of data. Examples would be SDSS,
> WISE, 2MASS, etc. A dataset may cover the full sky or some portion of it;
> this is wholly independent of Trillian.
>
> Trixel: I divide the sky into regions (mapped to HEALPix pixels, though
> "region" might be a better word than "pixel" here). A "trixel" (Trillian
> pixel) is a container that stores all of the data within a HEALPix region -
> there is a one to one mapping between HEALPix regions and trixels. A simple
> way to think of a trixel is as a folder with all of the data relating to
> that part of the sky. (In reality, it will also contain a database.)
>
> Do you assert that a node always host the same portion of sky, regard less
> of the data set?
>
> Trixels are stored on nodes. When Trillian is "initialized", twelve
> trixels will be created (the most course resolution of HEALPix) and placed
> on the first node (i.e. the central server). As data is added, it is placed
> into the trixel that represents that part of the sky. When the disk becomes
> full, a trixel is subdivided into four (the next higher resolution, or
> n_side++), and, for example, three of the new trixels are moved to a new
> node (another server). (There is a lot of room for optimization of how
> trixels are subdivided and stored.)
>
> So to answer the question, yes, a node will host a particular part of the
> sky at any given time, but the part of the sky a node contains may change
> over time as new data is added.
>
> I hope that's clear! Diagrams will be helpful at some point.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trillian/trillian/commit/d539a55019402345d3a47ba955c89afd4a3b24a8#commitcomment-9407323>
> .
>


 [TestMethod]
        public void FirstOnShortList()
        {
            SinglyLinkedList list = new SinglyLinkedList();
            list.AddLast("foo");
            Assert.AreEqual("foo", list.First());
        }


why does this change from constant to dynamic? Why isn't it still constant?


Nice find and good that the windows build is fixed.

But, now that I look at it, aren't the str_make_new functions exactly the same in objstr.c and objstrunicode.c?  Why is it duplicated in objstrunicode??


same here. Why not constant?


I think you meant to set canShootTick = 0 in java/net/divinerpg/items/vanilla/ItemProjectileShooter.java like you did in java/net/divinerpg/items/vanilla/ItemCorruptedCannon.java.


ok, so xs is unchanged in the caller?  Then I'm happy.


Fixes #54 - Looks good to me once the AppVeyor build confirms!


Bug fix, if callstate was last in FAN, and the mode was switched to Auto, while temperature was between target and low/hi, the fan would not shut off.


low: add the { to the if.


改簡介會不會比較一致？


low: add the {


If that is the case then it needs to be re-factored rather than reverted :)


yeah TrinityCore... dumbass


併？還是並啊？糟＝＝


Improved OS detection


Wait, got it. Here it is always dynamic because it is either 1 or 1 + N where N is the size of T.


got some tabs here...


Hi Strazzere,
I'm trying to reconfirm the output result of unpack qihooed app by creating a hellworld android example.
But after a simple helloworld is created, I can't find the link to pack the app by Qihoo. Can you give me the link to packing the app by Qihoo? (like bangcle has http://www.secneo.com )
Thank and Best Regards
Lap


84202576-DesSpecOA-PerPersonUsedWhenFlowArea (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-73.52%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Created the private field firstNode.

SinglyLinkedLists.SinglyLinkedList.firstNode is never assigned to, and will always have its default value null.

This is a desirable design but we must instruct that we want to return the value null to resolve this warning.


Comment: usually I prefer something like:
// given
String expected = "IV";

// when
String actual = new ArabicNumber(4).toRoman();

//then
assertEquals(expected, actual);

THIS IS NOT A CORRECTION, JUST A EXAMPLE TO FOLLOW IN A COMPLEX TEST.


What I meant to say was that the zero comparison is unnecessary.


Any reason to remove "RUN go get github.com/beego/bee" ? bee command can't be found when I am doing debug


In order to solve this test we must tackle the AddLast method.


fixed it, thanks


High: the name of the test must explain what the test do. You should use something testArabicToRomanWithTwoDigits

PLEASE, DONT CORRECT THIS HIGH, JUST KEEP IN MIND FOR NEXT PULL REQUEST.


low: use a method to do it in a for loop like "createAndOpenFiles(20)"


low: not needed.


1277852-CommandLineInterface (nealkruis) - x86_64-MacOS-10.9-clang-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.86%25-red.svg)


Thanks for catching this. Fixed in commit f7e0d1e


High: Use a @BeforeTest in a method to remove the data.. or add it in the first line of the test. The test must be cohesive.


I think the image is just for deployment so I remove the unnecessary. You can add it later. I'm ok with that :smiley:


not sure what you mean? they are both allowed


Ah... so that's why the icon wasn't updating. Thanks for this fix!


what does "order" mean as a mode? How is it different than "sale"?


You could probably reduce some of the checks with never null


![screen shot 2015-01-22 at 20 11 00](https://cloud.githubusercontent.com/assets/1155163/5868090/d2a29ca2-a272-11e4-8362-d4685210fb6c.png)


GREAT JOB!!!, just re send the high pointed the coverage.


x


[TestMethod]
public void FirstOnShortList()
{
SinglyLinkedList list = new SinglyLinkedList();
list.AddLast("foo");
Assert.AreEqual("foo", list.First());
}


`if ($code & error_reporting())` is enough.


This also gives us the benefit of supporting GIF (at least with GNU social's ImageMagick plugin, which I believe is necessary for that). ;)
https://social.umeahackerspace.se/notice/176990


know nothing for beego still, it looks I can use "go run pirate.go" for the
same, so keep it clean, I will update the README.md

On Fri, Jan 23, 2015 at 9:08 AM, tobe <notifications@github.com> wrote:

> I think the image is just for deployment so I remove the unnecessary. You
> can add it later. I'm ok with that [image: :smiley:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tobegit3hub/pirate/commit/b2972cd13f05866f24736727f6c35041866f53fc#commitcomment-9408432>
> .
>

--
True software development embraces consistent inconsistency.
blog: http://larrycaiyu.com/blog (en), http://larrycaiyu.com (chinese)


Not sure, sometimes when you increment a const by 1 you make it dynamic, as in the case of options. So its not clear it would help


Exactly


Similar to above, since the length is dependent on if the outer option is defined or not it needs to be a dynamic


rEMOVE!


平行集合?


Thanks. Upgrade paths are very important.


test comment


 [TestMethod]
        public void NodeLastWhenNotLast()
        {
            SinglyLinkedListNode node = new SinglyLinkedListNode("foo");
            Assert.IsTrue(node.IsLast());

        }


When I downloaded the code from this repository, I receive below error. Please assist to fix the issue.

C:\A Work\Study\NodeJs\Code>node index.js
module.js:340
    throw err;
          ^
Error: Cannot find module 'formidable'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (C:\A Work\Study\NodeJs\Code\requestHandlers.js:3:18)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)


@xt1 would you please clarify the version of OData Linq to QueryString supported ? I cannot quite understand the meaning of "subset".


誠に申し訳ありません m(_ _)m
私の残したゴミですよねこれw


bool is an alias of System.Boolean to declare a function to evaluate to a true or false value.

In this case we want to evaluate true/false if the IsLast method is called on a certain node.  If the next node has the value of null then it will return true.  If the next node has a value other than null it will return true.


車子併排，用併
資料平行集合好像也ＯＫ～
不然先擱著好了之後再來美化～
下週討論一下這Repository怎麼改～ Thanks !


Does this test do anything different from the one above?  I'm pretty sure it's duplicate code, as it stands. (I tried to reimplement them both faithfully when switching to spies.


This is kind of awkward, but the good news is that `:records` and `:record_ids` fail unless you touch one of their objects, because they succeed at being lazy (at least for the first request).


you don't need the check


For Job Changer


`return new Page(length, slicedBlocks);`


you don't need this


Sorry, I'm very confused by this comment...

1. What's an "invalid value"? I don't think there are any values you could write to `mode` that would cause a crash, impact other USARTS, or violate memory safety in any other way. In particular, "leaking" the `parity` and `stop_bits` would allow the device driver to configure the USART incorrectly, but it's specific to the USART that is "owns". What's the problem? How would using a struct with enums fix that?

2. Exposing particular layers of abstraction to a other modules (e.g. device drivers) and safety seem to be pretty different concerns in general. The way to deal with the former is not to expose make methods or fields public. The way to deal with the latter is by marking unsafe features `unsafe`.

3. I'm really not sure what would be `unsafe` here. A device driver (or another platform driver for that matter) that "owns" a particular `USART` should be able to configure it however it wants. Sure, the console driver only uses it as a uart, but there are scores of possible configurations for a USART.

Obviously, we need to enforce certain functional properties of underlying hardware controllers *when they are virtualized*, and would otherwise allow device drivers to interfere with each other if they share the same underlying hardware resource. But this is not the case with USART. With the exception of, maybe, the interrupt controlling registers, we could just as well expose the USART as an array of `u32`s in terms of memory safey, as each USART has completely non-overlapping memory registers.


Giving Matt access to this repo was a mistake


`new Page(1000);`


fixt


It's not a bug, it's a feature


`testGetEmptyRegion`


I think there's probably a way to do this with a partial mock on `subject.client` but I think it's actually fine as is.  If the metaprogramming at `set_instance_variable` feels awkward it's because `Harvester` fails at dependency injection.  Let the awkwardness serve as a reminder, until it can be improved. :)


`testGetRegionFromNoColumnPage`


actually in digging through this a little more, I think values I assumed went there is wrong:  https://github.com/reactioncommerce/reaction-core/server/methods/orders/methods.coffee#L50

`if paymentMethod.mode is 'authorize' and paymentMethod.status is 'approved'`, so this should actually be

`allowedValues: ["authorize", 'capture']`


@mattheath - this is how easy it is to bump the secure version number for minor updates


Why did this change from the original?


I have got some stuff in the latest hxcpp to detect 'legitimate errors', but have not checked the no-files situation.  Have you tried the latest version?  I will see if I can reproduce it.


IF? You introduced a guaranteed crash in (rare) case when the first pSummoner->SummonCreature fails.


where is the java version ?  thank you.


Hey david, sorry for being out of touch lately, I've had to put my head down a bit.

I know in general the version should be in version.sbt, this was just a hack I put in to get things running quickly for a test since I hadn't merged upstream in a while and couldn't figure out why "sbt publishLocal" wasn't publishing any of the libraries as 0.11-SNAPSHOT. Does version have to be directly input to publishLocal the way it is for publish?


I had used this tool on my Arma3, since todays update Arma wont start anymore. What can I do? Deleted all tbbmalloc DLLs and the arma.exe and resynced with steam, but it doesnt help.


Yes and TorrentHandle is a mutable object anyway,


I left it as docbook so that we had access to the 'question' and 'answer' tags.
Can you drop this one please?


Thinking of the implication of this being a checked vs. unchecked exception. It seems like there's nothing the framework can really do anyways to recover from an exception- just pass it long. Having an exception in there (FlowmixException) to denote a framework-specific exception seems like the use for something custom.

What do you think about a runtime exception? Any specific need for a checked exception here?


Closes #1


Thankfully we can loose this paragraph completely.


> https://github.com/chjj/marked

citing a single source isn't helpful, but noted, however chjj didn't do this himself.


is 'were' really correct here?


Script is disable for now due to lack of reseources from android_build.


Thế đéo nào


Lets just drop references to this kind of resource


Hmm this is one 3rd-party pull request that sneaked its way in. Good catch.


The problems remaining after this commit are isolated to the shared examples:

  - They assume that first item returned by `#records` has an id matching the first returned by `#record_ids` and that `#get_record` accepts that id as an argument.  I'm open to a refactor that fixes this up, but the assumption is partially in support of...
  - They test that the record returned by `#records` and `#get_record` are the same.  I think the current implementation legitimately fails this.
  - They assume that the minter will be passed the id: `oai:oaipmh.huygens.knaw.nl:arthurianfiction:MAN0000000010`.  This needs to be fixed.  It seems it could easily accept the id from point 1.


Suggestion po, maybe we can put this `$output` variable before the `if ($action == 'encrypt')` statement so we don't have to use else statement.
If this cause problem po, disregard and simply fix the linebreak po in your `else`
```php
} else {
```
 :smile:


Do we need both minified and not for the novtt version, or could we assume one is good enough?


@openspectrum: Like this!
```
def print_horizontal_pyramid(height)
  line_length = (height * 2) - 1
  (1..height).each do |i|
    num_asts = (2 * i) - 1
    width = (2 * height) -1

    asts_str = "*" * num_asts

    line = asts_str.center(width)
    print line
    print "\n"
  end
end
```


I have updated the PR to remove the redundancy.

On 23 Jan 2015, at 8:13, bcosca wrote:

> `if ($code & error_reporting())` is enough.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sorbits/fatfree-core/commit/73a44a15d1b242c94edb2620c35920c7688d866e#commitcomment-9408476


This commit is nonsense, meh.


@thejameskyle Couldn't we just persist before repl.compile(), then just let it throw?


These are sync by default? That's handy.


Copyright 2015 Calrissian.?? this was automatic, there is no original FlowmixException


I don't actually know.  I thought publishLocal worked just fine with
version.sbt

On Thu, Jan 22, 2015 at 5:31 PM, gabeos <notifications@github.com> wrote:

> Hey david, sorry for being out of touch lately, I've had to put my head
> down a bit.
>
> I know in general the version should be in version.sbt, this was just a
> hack I put in to get things running quickly for a test since I hadn't
> merged upstream in a while and couldn't figure out why "sbt publishLocal"
> wasn't publishing any of the libraries as 0.11-SNAPSHOT. Does version have
> to be directly input to publishLocal the way it is for publish?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gabeos/breeze/commit/fb8806215717c0a0bb971985c4e8e96d0ae6d613#commitcomment-9408662>
> .
>


The runtime exception seems to heavy, other option is putting the exception on a error flow or something


and no need to make apologies.  We all have real work to do :)

On Thu, Jan 22, 2015 at 5:41 PM, David Hall <david.lw.hall@gmail.com> wrote:

> I don't actually know.  I thought publishLocal worked just fine with
> version.sbt
>
> On Thu, Jan 22, 2015 at 5:31 PM, gabeos <notifications@github.com> wrote:
>
>> Hey david, sorry for being out of touch lately, I've had to put my head
>> down a bit.
>>
>> I know in general the version should be in version.sbt, this was just a
>> hack I put in to get things running quickly for a test since I hadn't
>> merged upstream in a while and couldn't figure out why "sbt publishLocal"
>> wasn't publishing any of the libraries as 0.11-SNAPSHOT. Does version have
>> to be directly input to publishLocal the way it is for publish?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/gabeos/breeze/commit/fb8806215717c0a0bb971985c4e8e96d0ae6d613#commitcomment-9408662>
>> .
>>
>
>


1540218-SlinkyGroundHX (mmatts) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.08%25-red.svg)


 [TestMethod]
        public void NodeEqualityWithEqualValues()
        {
            SinglyLinkedListNode node1 = new SinglyLinkedListNode("foo");
            SinglyLinkedListNode node2 = new SinglyLinkedListNode("foo");
            Assert.AreEqual(node1, node2);
            //Equivalent to: Assert.IsTrue(node1.Equals(node2));
        }


Our heading has always been this:

/*
 * Copyright 2015 The Calrissian Authors
 *


@kitcambridge please review,


you're missing a "/" in your closing ```section``` tag


Add support for casting JSON to ARRAY or MAP types


@lapnd Can you please open a new issue and add the sample you're attempting to unpack? I've only stumbled upon a few actual examples and Qihoo doesn't seem to allow non-chinese developers use their SDK.

If you're looking for an example - I believe there are some on unpack.cn?


looks good


Always add a blank line at the end.


In this test the error was between comparing the objects vs the value.

We created two new nodes, each with their next node being equal to null.  However, these nodes are orphans and are not members of any apparent list.

In this test we want to confirm that they are equal by comparing their values both equal to "foo".


> The runtime exception seems to heavy,

What do you mean? If you extend RuntimeException instead of Exception, you wuldn't need to add throws calls. The framework calling the add and evict methods is just going to be try..catch'ing around Exception anyways so there's not much it can do to recover specifically from a FlowmixException, it's most likely just going to pass it right to an exception stream bolt.


I'm wondering if it would be nicer to have vtt.js after video.js, at least in the unminified version, assuming the order isn't required. But not a big deal either way.


Careful, "implements" is not the same thing as "extends". "implements" is for interfaces while "extends" is for classes. You still need to extend Object here to be pure Java.


Everything inside of HTML should be indented.


lgtm!


Everything inside of body should be indented.


What's with the special treatment for the exactly value of 12 in these commits?

LDV always has a length of 8 bytes to load.
If you want to obey strict C standards and prevent memory segfaults you could shorten the length to avoid writing past the final byte of the factor, but why do this *only* for (RSP_element == 12) and not all the other values that overflow?

When element == 0x8, you write 8 bytes to vector bytes 8, 9, 10, 11, 12, 13, 14, and 15.
When element == 0x9, you write 7 bytes to vector bytes 9, 10, 11, 12, 13, 14, and 15.
...
The general formula is:
```c
length = 8;
if (RSPOpC.del > 8)
    length -= RSPOpC.del - 8;
```


Errr...I used to have a trycatch then changed something. One moment.


Collection <T> Class: https://msdn.microsoft.com/en-us/library/ms132397(v=vs.110).aspx


Can we include some text to the effect that "pacemaker runs on lots of different messaging layers, corosync2 is the current state of the art but use whatever comes with your distro (and follow their setup instructions)"


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (2179 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.5%25-yellow.svg)


![screen shot 2015-01-22 at 5 51 54 pm](https://cloud.githubusercontent.com/assets/148908/5868506/6ee7446e-a25f-11e4-8e84-99c8f0f2f3af.png)


? Question:

I believe that the Equals being asserted is:
 public static void AreEqual(object expected, object actual, string message);

We must override this to specify that the object we are seeking to compare is the SinglyLinkedListNode object.


I'd prefer to document cman in preference to the plugin :-)


Since we are using HTML 5 po, (Denoted with `<!DOCTYPE html>` ), please refrain from using `<b>` element and use `<strong>` instead po.
"the `<b>` tag should be used as a LAST resort when no other tag is more appropriate."
source: http://goo.gl/kMrAh
:bow:


How come we lost all this bit?
Important info for people because its not always obvious


Always add an addition blank line at the bottom of your documents.


I think that the default engine feature is not needed. Any plugins do not use this feature.


More CSS was added too! :+1:


The format you've used for the `id` field is really only by convention in crmsh and pcs. Pacemaker itself doesn't care.
Just so you know. Happy for you to continue using it.


like


Does `source,XML` mean this gets indented automagically?
If not, can we get the whitespace back please :)


This seemed a minimal change (unless I missed something). It did take me a while though... I wasn't capitalizing `File`. :/


function output($class) {
     ...

      return '<div class="<?php echo BOOTSTRAP_CONTAINER; ?>">

' . $this->alertBlock($output) . '

';
    }

Thoughts ?


Janitor would be a good name for a library ;)

But i thought more of something like renaming Resource to ClosableResource and ResourceManager to ClosableResourceLifecycleManager or something.


Фикс необходим именно для работы templateExists, ниже он не используется


Full Screen mode not working.


. We haven't tested OpenJDK.


mmh yes I know, but without rooms_availability_reference_modal $_GET['rooms_id'] shouldn't be setted.


Ubuntu - all our test and production servers are on Ubuntu.


Dependency Mgmt nur für Dependencies, die direkt oder transitiv in >1 Maven Modulen verwendet werden.


Our developer machines run Ubuntu/RedHat/Mac OS X, so they should be ok too.


REACT or react.js (bit weird otherwise)


Which conference is it for? :) who's the audience...


I did this because not all code paths needed a build, but in fact, it's only when `args.Version == true` that that is the case. I'll move that condition to the top and then call `Build()` just once after it.


We don't offer any licenses and trials


I think you mean "pontificating about" rather than "praising"


> Is your thinking to replace some of the code in stfio::importABF2File() with a call to ABF_ReadOpen() instead?
Essentially yes, but as you say, I'm not sure we can use ABF_ReadOpen out of the box because some of the ABF_* functions might not be applicable to ABF2 so that we might have to modify ABF_ReadOpen a bit.


hey, there are so many combinations of os, version and config these things happen.
its not a big deal !


Anyone can add this parameter to the URL manually.
And what happens if that URL is modified in that module and Rooms is not updated accordingly?
Third party modules must be as decoupled as possible


page. -> section.


Indeed, thanks. Fixed in fae697dc12fceeacc215bf866e328752ddec72c4


believer _in_?


@SubJunk failing also for Java 6 on windows


This "fix" introduced some significant regression by my customer, I didn't really understand the cause, so preferred to rollback


s/to admit/admitting/


s/as/than/


s/have been//


> server_name isn't set at all times, only for apache (since it's an apache specific setting)

Then there is something wrong in the nginx recipe : http://nginx.org/en/docs/http/server_names.html
This attribute is common to both Webserver.


Почему в этом месте нельзя написать var result = Q(self.routes[data.call](data.arguments)) - и не делать проверки на 'then' in result?


Vou ajustar no próximo commit. Faltou css específico, ai ele pegou do "body > *"


Shouldn't this be two separate tests?


Nevermind.. :)

Getting it to report like Ignore takes a whole different effort.. :)


FYI, it is not recommanded and can cause many issues. This option will be removed from proposed [init.d](https://gitlab.com/gitlab-org/gitlab-ci-runner/blob/master/lib/support/init.d/gitlab_ci_runner#L18) script in gitlab CI.

https://gitlab.com/gitlab-org/gitlab-ci-runner/issues/7


Hello @rgdlee98,
I would be happy to know how to improve the tbmsg


s/His work there involves/He works on/

(Keep it simple)


"Practically speaking, chunks of up to 100mb succeed most of the time"?


If you need to prompt your users that Chamilo uses Cookies, uncomment the line on main/inc/con/configuration.php
You'll have a message on the top of the screen, that prompt the user to accept the use of cookie for Chamilo. It'll remove the message for one year (it adds a cookie with one year expired time)


Aside _from_ that


refs CLX6-200


Now that you have content in the system, you can get basic contextual recommendations.
content or contextual?
See how here - > For details, see the <a href="{{ site.baseurl }}/docs/content-based-recommendation">Content-based recommendation section<a/>.


TeamCity OsmSharp :: GitHub - OsmSharp - PullRequests [Build 101](http://build.osmsharp.com:8080/viewLog.html?buildId=4169&buildTypeId=OsmSharp_GitHubOsmSharpPullrequests) is now running


content-based


This is a log message from Tomcat, it's the way it is :)


Good stuff. Not sure what the conf is so can't comment about tone and fit of content, but I suggested a few tweaks to the wording here and there.


1: M100 needs more reviewers
1: M101 signature is missing


@jkabat Are you sure it must be a root namespace


Well as a short rundown. ATM we need to specify TOOLCHAIN and NDK_PATH ... both are specific to the used ndk version. ATM those pathes are specified in the node (slave) configuration see:

http://jenkins.kodi.tv/computer/Linux-VM-1-Camelot/

That means those pathes are hardcoded by build slave. If we want to have it dynamically selectable in the job (f.e. you can select the ndk version on each build) - we would need to specifiy assumptions about how the path of the installed ndk and toolchain is named (f.e. we specify a some sort of android-build-tools root dir in the node like /home/jenkins/dev/androidtools/) and then just assume the 2 pathes to be made of android-ndk-<revision> and <ARCH>-linux-androideabi-4.8-vanilla-<revision/android-<API_VER> - that means we need to be able to specify the ndk revision, api version and architecture in the job - and then all those concatinated pathes need to match what is available on the slave ... does this make sense?


do not use foreach in tests. call add method explicitly with hard coded parameters.


22:1: I101 Imported names are in the wrong order. Should be current_app, has_request_context, request, session
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures
63: D203 Expected 1 blank line *before* class docstring, found 0
181:9: B901 blind except: statement
228:9: B901 blind except: statement