Sorry :/ https://github.com/mapbox/mapbox-gl-js/commit/15a5b24026365451f91649af62e0aaa4471c1e60 should fix the build.


Okay, good to hear.


Okay awesome.


Change comment above (create -> flush)


Awesome, glad to hear it.


This also seems to break with illuminate/html. At least, this is what I get when I try to composer update:

- Installation request for illuminate/html ~5.0 -> satisfiable by illuminate/html[5.0.x-dev].
- Removal request for illuminate/html == 5.0.9999999.9999999-dev


Awesome.


getThrower is supposed to expose the underlying value available as an API. IDragonfire's changes are probably more useful. Should these 2 ideas be split into different methods (allowing API access to the Thrower value of items) as well as tracking where an item was dropped from no matter the location?

It sounds like similar issues but I could see some implementations having difficulty merging the 2 ideas.


if the build  for a cluster fails, it still ends up pushing to other clusters and report a failure.  So a failing job does not mean it does not change the state, it could have changed the state on other clusters.


This is not in the policy for either of the cameras.  Truth be told, I was hoping that reading from a PAF was a stop gap while a better mechanism for storing camera parameters came along.  I don't know the value for either of the instruments.  I can make it a command line argument if you can give me a default number.


This is all slimroms here, thought I had author correct and clearly commited wrong. Not sure how to change after the fact but again all SlimROMS here


I don't think so. OpenCL runtime would take care it after clRelease***() in other classes.
It's too heavy to have sync call for every release.


In terms of bundled plugins, both DAWs have their advantages. I would love to have the huge selection of LADSPA plugins over in FL. The large selection means that I have multiple versions of the same type of plugin to work with, so if I don't like the sound of one I can switch to another. Reverb plugins are a great example of this. FL only has 2 reverb plugins, one being a slightly improved version of the other, and I'm stuck with how that one sounds. It's not a bad plugin, and I can always get a free VST if I want something that sounds different.

The generator plugins are more versatile. That being said, tripleoscillator is a lot better than 3xosc due to its blend mode options. Still, FL has a decent selection. They have a lot of generators you can buy separately, most of which I don't have. I can supplement those with free plugins such as Synth1, though, which is something I can't do in LMMS. Really, though, the generators in the signature bundle are good for a huge amount of tasks if you know how to use them well.

Audio manipulation is very much suited to a DAW.
--
And this is the point where I decided to go and make this:
https://soundcloud.com/test_flight/fl-resampled-neuro-bass

And I recorded a video so you can see how FL's audio chopping works, in case you're interested:
https://www.youtube.com/watch?v=ld58s7OiydY

Most DAWs have audio manipulation along these lines. While I haven't really tried any others, I really like FL's way of doing things.

And yes, I did make the bass used in the video :3


Looks good


Nobody, it will track all the historical events with WebCL's lifecycle.


isn't getRoomUsers doing another request for users?


The reason I suggested this is that you don't need an instance variable here, but if you have just the local variables sentences, there is a naming collision with your model..so I just changed the name of the local variable.


s/configurations/configuration/

:/


shouldn't this be "status.error!" ?


asset tagging - initial beta testing


There are may be some middle status, for example: CL_QUEUED, CL_SUBMITTED, CL_RUNNING.
But we only take care the CL_COMPLETE. Left others do nothing.


I can for instance write a note here, about those pesky braces!


Thanks! For Uchiwa


Magic!


Good catch. I think the check in the sourceDoc function should be changed to `if (sourceDoc !== undefined)`.


@matiassingers ah that makes sense, never realized that


No, it only call once.  Check the code in getCallbacksFromCLEvent.
```m_callbackRegisterQueue.remove(j--);``` would remove the callback when it's triggered once.


@Zikk420 thanks man.
@Omnione I'm told not all the trials were covered in the command Omni, but this should fix what was there that my update broke.


Hola niños :D


I truly don't know what to do about this.  The use of kwargs['root'] was used in enough places that I didn't want to just remove it.  I thought about adding a command line variable.  Isn't this something the ArgumentParser should tell the mapper about?  If my help is needed to resolve this, I'm happy to have a look, but at the time it seemed like the HSC team may have a better idea what was originally intended by that behavior.


you missing your file in sentence folder


Sorry, I wasn't clear in my first comment. I don't see that you need to even check for the image.

If the user wants to 'create' one, you can just make the call to `gce.ex_create_image()` (regardless of whether or not it already exists). Similarly, you can attempt to delete the image with `gce.ex_delete_image()` (assuming that method can take a string parameter vs a libcloud image object).  In either case, if the call succeeds, the user gets the desired outcome and if it turns out to be a no-op for their desired outcome (e.g. the image already exists on a create request), then that's fine too.

I also think you'd save an API call by removing the check.


yes, I am in the process of adding more combinations, with identifier names, different combinations of , in and outside of named imports


I liked it


oAuth I think.


> (Is "HyperText Markup Language" ever localized?)

Some people try:

http://de.wikipedia.org/wiki/Hypertext_Markup_Language: "Hypertext-Auszeichnungssprache"
http://es.wikipedia.org/wiki/HTML: "lenguaje de marcas de hipertexto"
http://no.wikipedia.org/wiki/HTML: "hypertekstmarkeringsspråk"
http://pt.wikipedia.org/wiki/HTML: "Linguagem de Marcação de Hipertexto"
http://tr.wikipedia.org/wiki/HTML: "Zengin Metin İşaret Dili"

Not sure if those translations would ever show up in software, though. And the Zotero Style Repository isn't localized either, so people are likely to come across the English term anyway.


Well good.


Because return type is ImportStatement | ImportEqualsDeclaration.


Looks good


this is ok


should fix this


this part is alright


Oh, didn't see it because of github


He's more than likely copying my style for the rest of the Voicemail modules where config files are found at the root of the packages.


Yeah, I'd say we not worry about localizing this.


You can't make this change, because the zip doesn't contain OSC.  Should be "openshift cli"


Dave never hurts to get constructive feedback.  Small things can snowball, especially when writing code professional level (new job?).

Also no one has any way of knowing your not maintaining this branch anymore.  You can put up a dead-end or delete the branch if needed.  But this commit exists in your main repo as well.


@CyrusNajmabadi  @JsonFreeman  do you have any preference on avoiding lookAhead or having it. I like that we are actually following grammar here by doing the look ahead. (there is no need to do extra check during typecheck). But I am not completely against idea of always parsing IdentifierName and later reporting error if it isn't identifier.


Why is this here? Is this necessary. I am still running 1.3.


TeamCity Ylab :: synteny/ylab [Build 44](http://192.168.30.225:8111/viewLog.html?buildId=681&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


TeamCity Ylab :: zmactep/ylab [Build 187](http://192.168.30.225:8111/viewLog.html?buildId=682&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


Okay.


I think it'd be clearer as:
```perl
$params{BUILD_REQUIRES} = { %{ $params{BUILD_REQUIRES} || {} }, %{ delete $params{TEST_REQUIRES} }
```


First, thanks for the PR. New checks are ok, I dont like the approach, though. As well new non-standard metrics as new resource types are likely to cause high maintanence efforts in the future. I wont introduce them unless there are really appealing reasons. And I fail to see them.


Mandates that Play Bots will be against Serf Bot


I think this check would provide a little performance improvement.


Fixed, commit e38961f6f87910f816d5d525e3a8c60b732e8010


Going about it this way by taking parts of the code that could be turned into a logical template variable should be placed into a partial like this. Many templates can be sliced and turned into partials which is what I found to be the best way of reusing redundant HTML.


Je pense qu'il faut faire un $answer->setImage non ?


"external_id" should definitley be left as is, as Orion mentioned people often use it to refer to system other than PhenoTips (thus "external" id). We should add another field with a label "Phenotips patient reference" or smth like that which refers to either nothing or PhenotIps id - and nothing else.


r+


Generally an awesome pattern (how to watch non-scope values), but in this case it's not required. `'nav.keys'` will do the trick to!


Proposed commit message:

Removes the TDReplicator -clearDbRef method.
This method seemed to be appropriate when all replications
were executed on a main replication thread. This method
served two purposes, previously.

First, it would assume a successful write to the remote
checkpoint document and write the last sequence value
to the local checkpoint. This is problematic if the write request
to the remote checkpoint document fails. In a previous
commit, we've ensured the replicator thread remains running
until a callback block is called from the last request to write to
the remote checkpoint document. In that callback block, we
now write the local lastSequence value to the checkpoint
document if the remote write was successful. This ensures
they are synchronized. Writing the local value in -clearDbRef
only potentially confuses the situation and can result in a
mismatch between the local and remote checkpoint documents.

Additionally, -clearDbRef set the pointer to the TD_Database
to nil. It is now set to nil after the replicator's thread has exited
its runloop. This part of -clearDbRef is still necessary since it's
one of the mechanism to make each TDReplicator object only
useable once. The pointer to the TD_Database should not
be set to nil until after all asynchronous tasks have completed


No, the error was that before_deploy, web, and app_server roles where gone. The node issue is fixed by using my role.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/613
success: http://build.servo.org/builders/linux2/builds/612
success: http://build.servo.org/builders/android/builds/648
success: http://build.servo.org/builders/mac1/builds/829
success: http://build.servo.org/builders/mac2/builds/829


good idea


BTW, why do we need a hidden field here? Assuming we did use external_id for linking to other PhenpoTips patients, whats wrong with just displaying that id in one way or another directly, why do we need a hidden field?


This will ignore the message, you need to put it as a parameter:

    logger.error("Could not process patient's family information: {}", ex.getMessage());


Reverted: https://github.com/rmzelle/zotero/commit/0f1b10448f7873745f3029b6d512859f2ad9c3af


I am not strongly against lookAhead, so I don't mind if you keep it. But my suggestion to avoid it does not involve the checker. What I meant was that you check if it's an identifier right after parsing the name. And if it is not, you parseExpected(SyntaxKind.AsKeyword) and that will give the error. No error in the checker.


You did beta2! :p


В slim этот файл был бы в два раза короче и выглядел бы намного чище :)


Godoc


Can we not do this with tags. Having to set the version in this file is a bit rubbish. :(


fast-forwarding master to auto = aba5c160


(found out there was a bug open for it)
https://bugs.freedesktop.org/show_bug.cgi?id=47201


OK, can squash as appropriate.


I think this function needs to be split out somehow into a smaller class - there is a lot of responsibility in this one file, which is going to make it more difficult to maintain and extend in the future. One possible approach would be to put the commands into a command factory that builds the commands out or to use a manager to delegate the commands as requested. If you decide to put the commands in their own files, which may seem like a pain now but may buy you some flexibility later, you can use require to load them.


shouldn't we verify things about `'new ten'` here as well?


Boom :exclamation: I love it!


shouldn't we verify things about `'new twenty'` here as well?


I think both with timeout and without are valid use-cases.  Here's a non-timeout one, you want to tail -f some file in a container.


Awesome. I use this module a lot, too.


cool


This is VERY good.

I assume that Glimmr doesn't work yet?


The law being that I lately haven't been able to write a single line of code without fucking it up.


Are these really INFO?


same as above


I'll just leave the change where I put the JavaScript code in their own files as a separate commit, so we don't conflate moving and changing code.


this is for the future documentation for example snmp environment config


saw approval from mbrubeck
at https://github.com/Ms2ger/servo/commit/2026cbada236fc87b27d5e88be7b9062560bff8f


merging Ms2ger/servo/warnings = 2026cbad into auto


Ms2ger/servo/warnings = 2026cbad merged ok, testing candidate = 88b78142


@fat


It's okay.


??

chr(0x10ffff) is valid python3.


Isn't this and the next line before after = the wrong way round?


The filter should be applied to the final return statement.


This Wait is an infinite wait on the client creating the input/output/error streams and the server receiving them. Not a connection timeout for tail -f or whatnot.


Huh, how was it working before?


No need to pass the email to the function since it can be accessed inside of it.


TeamCity Ylab :: synteny/ylab [Build 44](http://192.168.30.225:8111/viewLog.html?buildId=681&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 136 Build time: 00:12:35


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 159](http://192.168.30.225:8111/viewLog.html?buildId=683&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 159](http://192.168.30.225:8111/viewLog.html?buildId=683&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 127 Build time: 00:00:01


TeamCity Ybackend :: zmactep/ybackend [Build 55](http://192.168.30.225:8111/viewLog.html?buildId=684&buildTypeId=Ybackend_ZmactepYbackend&guest=1) is now running


I'll make them V(something greater than 0)


TeamCity Ybackend :: zmactep/ybackend [Build 55](http://192.168.30.225:8111/viewLog.html?buildId=684&buildTypeId=Ybackend_ZmactepYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:15


TeamCity Ylab :: zmactep/ylab [Build 187](http://192.168.30.225:8111/viewLog.html?buildId=682&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 136 Build time: 00:12:36


My point of view is that this change removes information. How the user knows that "--this-option" will have to be translated to syntax LEDGER_THIS-OPTION or LEDGER_THIS_OPTION ? I propose to revert this change.


that a thumbs up to the commit message or to the contents of the push?

—
Sent from Mailbox

On Wed, Jan 28, 2015 at 3:16 PM, Jonathan Bender <notifications@github.com>
wrote:

> :+1:
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/donerightio/doneright.io/commit/e7868d78f1bf687e33b41aa8cffa1b0ee761ffbe#commitcomment-9486073


Is it worth noting somewhere in the docs what the differences are between `preference` variables and `state`? For example, preference name & variables are stored in `Map settings`, but cannot (or *can?*) be Maps themselves, unlike your helpful examples of the complex structures allowed in `state`?


just in case, the before / after = is swapped with the next line.


@daenney for some reason this module actually has stuff committed into fixtures/modules: https://github.com/puppetlabs/puppetlabs-inifile/tree/master/spec/fixtures/modules

And you can see this commit is trying to add spec/fixtures/modules/create_ini_settings_test/manifests/init.pp

It doesn't hurt to stop ignoring spec/fixtures/modules because this module doesn't use any other modules in its spec testing https://github.com/puppetlabs/puppetlabs-inifile/blob/master/.fixtures.yml

@mhaskel 's suggestion is the least work though, so this commit could just undo the .gitignore changes and git add -f the new test manifest.


The global arg allows us to override the global-ness of the path (which actually means 'does the path start with `::`', rather than 'is the path semantically global). We use the override for `use` imports where the syntax is non-global but the semantics are global. (I'll put all this in a comment)


just repeating what I said on IRC here for reference: why would we want to store the client channel name in our db if we're not displaying it, but only using it to set it once when no name has been set? I think the fix here should be not marking the channel as changed when only the client name changes.


could you please revert all of these?


i don't use netbeans.


Note for future PR, it makes for much cleaner history if you rebase your branch on top of the latest upstream/master instead of merging it.


Is a similar fix needed in native?


buffer overflow weakness


It would be nice if:
 - you could apply this annotation: org.hibernate.search.testsupport.TestForIssue
 - briefly describe the purpose of the test


partially addressing #66


Published to http://vui-docs-internal.s3-website-us-east-1.amazonaws.com/35_ecf92ae2eaa775611be3f939d8e0edd138db2e52


the idea is that we first load the internal channel group, which contains all channels with their IDs, channel numbers and other metadata, and then the other ones. I also doubt that this would improve loading speed.


Is this the right syntax? Should it not be:

```
package { 'subversion':
  ensure => present
}
```

As per #20 I think associated packages like this should be managed with require_packages instead, to avoid clashing with a user managing that package in another module.


exploring a possible solution for https://github.com/braver/isotope-ui/issues/13


another repeat from IRC: the reason is that we don't hold the group locked while loading from backends and updating. if this somehow marks all groups as changed, then that's the thing that needs fixing.


I agree but according to `npm help 5 package.json`
>  The most important things in your package.json are the name and version  fields.   Those  are  actually required, and your package won't install
       without them.


@bighazycrab

what is a big hazy crab exactly?


Actually this should be:
`"should update the selected item when only the tracked property on the selected object change"`


La good practice c'est de mettre tout ce qui est logique dans la fonction update, et laisser seulement ce qui a rapport avec l'affichage dans la fonction draw. Donc ce bout de code devrait être dans update selon moi.


You didn't get it right, try again :)


> I agree but according to npm help 5 package.json

Yeh, it's a design floor imo.


I don't think i has been declared yet. Also, it looks like the for should be in an else.


Published to http://vui-docs-internal.s3-website-us-east-1.amazonaws.com/3_3da9b6783d669873773510683afed5243cde6bd3


Well, we can but that is not really what we are testing here. The `label` is totally ignored by the `ngOptions` directive, since we are just tracking by `id`.

What we are really checking below is that the value of the select element changes when the object itself doesn't change but the `id` changes.


same as above :-)


haha dang!


fixed in https://github.com/mapbox/mapbox-gl-native/commit/793985580d202de8613a09bfe176b102eff04cdc


Hm.. if the idea is to support multiple handlers per route, I think we could come up with a different approach. One that allows you to add handlers similarly to addEventListener(...) and then you can remove handlers in the same way.

But for now, if you need multiple handlers, I would suggest adding a handler (single function) which itself loops through some array of sub-callbacks and Rlite can stay tiny and clean of this, as it isn't its primary use case.


@jrieken, @steveluc, @derekcicerone @basarat, @ashwinr and @teppeis, As users of the existing LS interface, this changes the LanguageService interaction with the host.

Before the language service would ask for a list of files in the context getScriptFileNames(), and it will not ask any more questions if the file was not part of the list; it will implicitly assume that the file was not found, and an error will be reported for any /// references or imports referencing it.

With this change the LanguageService can call getScriptSnapshot() on a file that was not in the original list returned from getScriptFileNames(). This can happen if a /// reference or import was encountered that was not included in the list from getScriptFileNames().

The change allows the host to skip the reference resolution step, before done using preProcessFile(). In a later change I have exposed the underlying Program object from the LanguageService interface to allow for querying the complete list of files after resolution, e.g. LanguageService .getProgram().getSourceFiles().

Please let me know if you have any concerns with this change. Thanks!


This is the main change here. we are going back to the host to ask for this file that we did not get in getScriptFileNames() the first time around. this allows the host to go fetch these files on demand, and skip the resolution step before invoking a language service operation.


OK - it is just that the issue itself was initially opened for what is displayed in the select box under those conditions. But I guess my comments just reveal lack of knowledge when it comes to this part of the code :-)


could you please cut a release so we can take advantage of this feature


> Thanks. I'm learning the process as I go. Unit testing is quite a bit different than what I'm used to but I'm getting the gist of it. I haven’t looked at the documentation process yet, which explains why I missed that altogether. It’s been sort of jumping into a moving train but I’m enjoying it :)

Unit testing has only been recently added, and all new functionality should utilize it if possible. Let me know if you have any questions how to organize things.

> Yes, getSaveFileName() is used in several other places, some of which would certainly benefit from this. As I mentioned above, I was trying to minimize the number of changes for my first submission. The question about separate issues also applies here. I guess it's just being used to a chain of responsibilities. In my “day job” (again) I would go nuts (and QA would shoot me) if I just started changing/fixing things without an issue attached to it. Even for my personal projects I keep a list of things so I can keep track (and later understand what I did).

Yep, every project is different and this one doesn't have much manpower so a lot of things that require a ton of extra administration normally gets shortcut. The way I separate things is by commit, not by issues. I would suggest having 3 commits in your final pull request: 1 that changes the `getSaveFileName()` function, another that updates/extends the unit tests, and a third that updates all usages of `getSaveFileName()` where it makes sense. This is preferable to separate issues as it's lower overhead but it still lets us divide the work nicely and examine the changes in nice sane chunks.

And I'm glad you're here to help with development, I see you're picking up things pretty quick and we're excited to have you onboard. Can't wait til you get your first commits in!


Thank you for your explanation @MrColdbird, everything is clear now :)
I will improve the translation.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1094 of 1098 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.64%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.9%25-green.svg)


I would suggest that `lein` should be place under `/usr/local/bin`. Following the convention of Linux Filesystem Hierarchy - https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard


@dhawalhshah This is how the widget is added and how config parameters can be passed.


@jprichardson Thanks for the feedback. I reverted this change: https://github.com/feross/standard/commit/ebde3e003339556ea54535af3e4dab1b171f5b16


@aag1091 The brackets are there to signal to the user to replace with your customer id, secret, and environment location.


I'll update this in a release soon.


Thanks jamie :)


If coverity is any smart, it should NOT complain if you take the lock out here as it is not needed. If it does complain, we should mark it as false positive.


Notice that there is a pre-built `drake.jar` file under the releases https://github.com/Factual/drake/releases so if there is no major bug, i would suggest using a released version.


frameworks/base/core/java/android/app/Activity.java:799: error: <identifier> expected
    $ /**


@aaronjudd I checked it out and everything appears to be working as intended


Thanks matthew


It is really awesome, but I have found some cases where `colorize` just pukes. Here is an example of trying to use it on my `zshrc`, actually.

![oops](https://cloud.githubusercontent.com/assets/569571/5946534/5377f616-a6eb-11e4-803e-950d5c80a96a.png)

It inserts random line-breaks and tries to escape some characters that really shouldn't be.

Anyway, I like being able to choose between `more`, `cat`, and `colorize` depending on the situation. If it is a relatively straight-forward source file, `colorize` can do it well, generally.


@janonich None of these need to be instance variables. Lets use local variables instead.

Instance variables exist across the entire instance of a class and space is allocated in the heap when the constructor is called. They will persist indefinitely until the SwerveDrive class is no longer utilized. Local variables exist inside methods, loops, if statements and are created and destroyed inside the same space. Once the method is done executing, for example, the variable will be destroyed.


Ah, so that's where they were. Quite a bit more in Creature.as

Just ignore this file then.


Below is the list of Data migrations that need to be implemented:

- core/migrations/0011_build_created_by_identity.py:class Migration(DataMigration):
- core/migrations/0016_build_provider_admin_and_creds.py:class Migration(DataMigration):
- core/migrations/0018_build_accountprovider.py:class Migration(DataMigration):
- core/migrations/0021_assign_provider_virtualization_type.py:class Migration(DataMigration):
- core/migrations/0025_copy_selected_identity.py:class Migration(DataMigration):
- core/migrations/0032_create_dummy_applications.py:class Migration(DataMigration):
- core/migrations/0034_machine_to_application.py:class Migration(DataMigration):
- core/migrations/0045_prepare_deprecate_featured_and_make_tag.py:class Migration(DataMigration):
- core/migrations/0048_add_default_project.py:class Migration(DataMigration):
- core/migrations/0051_add_size_to_history.py:class Migration(DataMigration):
- core/migrations/0053_add_and_assign_auto_imaging_provider_trait.py:class Migration(DataMigration):
- core/migrations/0057_remove_duplicate_memberships.py:class Migration(DataMigration):
- core/migrations/0062_remove_default_project.py:class Migration(DataMigration):
- core/migrations/0066_add_uuid_to_identity_provider_and_project.py:class Migration(DataMigration):
- core/migrations/0068_add_and_assign_iplant_and_google_dns_trait.py:class Migration(DataMigration):
- core/migrations/0071_migrate_version_from_semantic.py:class Migration(DataMigration):
- core/migrations/0075_update_machinesource_instancesource.py:class Migration(DataMigration):
- core/migrations/0082_add_default_status_types.py:class Migration(DataMigration):


@janonich This is a good way to help you understand how the code is working, but since all these methods are only going to be called once per updateSwerve method call, we will create unneeded overhead (see the instance variable comment above) to support them.

Instead, lets document the different math with comments and have it exist in this updateSwerve method. You will be able to get the same level of documentation you're receiving by breaking this into different methods that you would if you blocked off sections with comments.


This is all down very intentionally. It's so that the file can be placed in wp-content/languages/pw-transients-manager


@janonich Store these Math.pow results in local variables for reuse.

```double forwardSquared = Math.pow(forward, 2); ```


Why is this removed?


This was correct before.


I think we need to guard this based on the account type.

When the VPC account is added to CI, this should fail right out of the gate.


xD


This shouldn't depend on how the value is displayed graphically.  Add `getValue(name)` or similar and use that.

Also, you can probably use members.


Can you remind us why it was there in the first place? Why does an Event Descriptor need its own `time` is Events and StartRun and EndRun records have times?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/614
success: http://build.servo.org/builders/linux2/builds/613
success: http://build.servo.org/builders/android/builds/649
success: http://build.servo.org/builders/mac1/builds/830
success: http://build.servo.org/builders/mac2/builds/830


Confusing typo there. Read online version if you are following via email.


@janonich Store the result of 180 / Math.PI inside a local variable for reuse.


@janonich Store the results of Math.pow's inside local variables for reuse.


ZOMMMGGGGGGG

![](http://i.imgur.com/axbjx9i.jpg)


Can you move this to the specific operation(s) that is unchecked?


Since you wrote this, 1.7.4 has come out :-)


Before going down this road of making small changes, i think we need to decide what "source" is. Is this a URL (URI?) type item which points to the data source or is this a full name of a detector.

Lets discuss further.


86121908_copy_schedule (macumber) - i386-Windows-7-VisualStudio-12: OK (2170 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.09%25-yellow.svg)


If Puppet is set as CM and Ruby gets uninstalled, Puppet gets removed too.

```
==> virtualbox-iso: Provisioning with shell script: script/minimize.sh
    virtualbox-iso: ==> Installed packages before cleanup
[...]
    virtualbox-iso: puppet                       install
    virtualbox-iso: puppet-common        install
[...]
    virtualbox-iso: ==> Removing default system Ruby
[...]
    virtualbox-iso: The following packages will be REMOVED:
    virtualbox-iso: libaugeas-ruby* libaugeas-ruby1.9.1*
    virtualbox-iso: libffi5* libruby1.9.1* puppet*
    virtualbox-iso: puppet-common* ruby* ruby1.9.1*
[...]
    virtualbox-iso: Removing puppet ...
[ ok irtualbox-iso: [....] Stopping puppet agent.
    virtualbox-iso: Purging configuration files for puppet ...
    virtualbox-iso: Removing puppet-common ...
    virtualbox-iso: Purging configuration files for puppet-common ...
    virtualbox-iso: Removing libaugeas-ruby ...
    virtualbox-iso: Removing libaugeas-ruby1.9.1 ...
    virtualbox-iso: Removing ruby ...
    virtualbox-iso: Removing ruby1.9.1 ...
[...]
    virtualbox-iso: ==> Removing man pages
    virtualbox-iso: ==> Removing APT files
    virtualbox-iso: ==> Removing anything in /usr/src
    virtualbox-iso: ==> Removing any docs
    virtualbox-iso: ==> Removing caches
```


why ipv4 only?


Looks good


Could you add that it's initialized to be a zero vector?


Hi @vikramahuja1001, @Vikram Ahuja , @Amitjha1412, @gauravm043
Anybody can check if there are mistake here?


r=glennw


fast-forwarding master to auto = 88b78142


This is great. Thanks Kot. Can you also run `devtools::document()` to create the `.Rd` file? (make sure you have the latest version of devtools first)

Also, I wonder if we should consider naming this function in a way that makes it clear how it differs from changing the internal (OM) binning structure.

Oh, and can you remove the last example line which has a hard coded file path in it? That will fail `devtools::check()`. (give that a quick run too)


Those descriptions are helpful :-)


any reason not to implement this here?


Indeed o["r2"] was not set correctly. Thanks.


don't be leaky. add a custom exception for array-out-of-bounds.


@mhegazy Cool - thanks for the heads-up: sounds like the change for us is that we should expect calls to getScriptSnapshot() for files which may not exist (if the user made an invalid reference). What should the error response be in that case (like throwing an exception) so that the user gets a good error message?


saw approval from glennw
at https://github.com/pcwalton/servo/commit/abddfa742f5de9f0eac886004353f633325c2c97


merging pcwalton/servo/font-stretch = abddfa74 into auto


pcwalton/servo/font-stretch = abddfa74 merged ok, testing candidate = 3736396c


For the record, I really prefer putting using "NULL == _someFrame" rather than "_someFrame == NULL", because in the event that one "=" is missing, "NULL = _someFrame" will throw a compilation error whereas "_someFrame = NULL" will slip by unnoticed.


Yeahh, that is wrong, good catch. I think only the non <> case should prefix ::, and in fact that should be dealt with elsewhere (by item_path_str) because type params shouldn't be prefixed. I wonder if this prefix here is just totally bogus?


Similar comment as the above one about NULL. Accidentally writing "this = _inCoordinatesOf" should throw a compilation error, whereas "_inCoordinatesOf = this" can slip by.


Oh right! I see. So we should test that explicitly then.

What is display in the text box will be taken from the option and not from the selected value. Is that OK?


I had to remove JSON.stringify here, when replacing the placeholder with JSON text.
Otherwise it would be escaped JSON text and not parsed below.


Time was there because I feel we should ad time to any entry that is made in these databases so we know when it is created. If that is handled database side then I think that is OK, but I like the idea of explicitly stating this in the arch. document.


@janonich Looks like this code is trying to do Field Centric control without a gyro right now? A gyro would certainly be easier software wise. Would just require modifying the forwardIn and strafeIn parameters before assigning them to forward and strafe in updateSwerve. It also would not require keeping track of time.

```
forward = forwardIn * Math.cos(gyro.getAngle()) + strafeIn * Math.sin(gyro.getAngle())
strafe = -1 * forwardIn * Math.sin(gyro.getAngle()) + strafeIn * Math.cos(gyro.getAngle())
```


OK, then we are all on the same page as far as the implementation goes. We did address the idea that someone might really want this information and could get it from mongo.

We can clarify this in API docs in a couple days.


Sona:  Your comments on the Jira say you needed a sample-app pom change to go with this.


literally beat me by seconds


AlwaysTinkering: there was a bug in the docs where I said they both used
the "I" parameter, the docs should be fixed now.


We can get time using mongodb's _id field: http://docs.mongodb.org/manual/reference/method/ObjectId.getTimestamp/#ObjectId.getTimestamp
This is one of the reasons why I am keen on using the built-in mongodb hashed ids. Unless we want absolute precision, this would be enough


This is nice. Do more.


This is a mess. Add more headers please.


Why was this removed?


Thanks Sean.
I did the modifications you suggested.


I haven't actually tested it with OpenJDK since I've been using the Sun/Oracle Java, but in theory it should work the same.


This change is not Windows specific. Assuming the problem affects the POSIX version as well, this change should be submitted to https://github.com/antirez/redis


Is there any reason to move this on the concer ?


alignment


On further analysis, item_path_str does not prefix `::` for global paths, and this is a trait, never a type param, so I think in the non-<> case, the :: prefix is legit.


ok,we'll try taking them out then


oh here's another thing I missed - should we be appending to the existing environment or building a new one from scratch? I think yesterday we agreed on the latter


@godiard I can only check it by tomorrow as it is already late night here. Is it fine with you?


I'm simply a programmer who found  code by  'dockeryZ' on StackOverflow (
http://stackoverflow.com/a/3451954/707700 ), and simply wanted to
acknowledge that I am not the original coder.

Honor to whom honor's due.

It was not my intention to harass you in anyway, but indeed I should have
checked first if there was a similar account on GitHub, so my apologies.

Kind greetings from Belgium,

Wim

2015-01-28 16:36 GMT+01:00 dockeryz <notifications@github.com>:
>
> who's this?
>
> On Wed, Jan 28, 2015 at 10:33 AM, Wim Deprez <notifications@github.com>
> wrote:
>
> > Working version of showing collection history
> >
> > Used interesting manipulations of DATE to get the different date ranges
> > (depending whether a user wants a monthly report, a quarterly report or
a
> > yearly report)
> >
> > With thanks to @SKRocks, @dockeryZ from inspiration through
StackOverflow
> >
> > !! page-ophaalhistoriek.php , line 63: still have to check if this is
> > correct !!
> >
> > Any feedback welcome, enjoy!
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
https://github.com/vvim/myrecy/commit/5ad5fe685093c6394d8be346e14d4b56c3b2cb30
> >
>
>
>
> --
> All the best,
>
> Zane Dockery
> B.A. Spanish
> A.A.S CIS & Web Technologies
>
> —
> Reply to this email directly or view it on GitHub.


Yes, one of my tests failed and I got unreasonably paranoid.  I will remove all of the "self" prefixes as I can.  In the future if one tests fails just because I left out a needed "self" prefix, I will just include what I need to get the test to pass.


bien joué soué g vois que tu as pris git en main!


r=mbrubeck


Meant to say "I will remove as many "self" prefixes as I can."


To keep the whole code base consistent I'd like to point out few general code style guidelines

1. Avoid blank lines between the `import` statements. I might do this for readability in the future but for now let's keep it consistent
2. Avoid trailing whitespaces. There's one in `ExpressionParser.java` on line 325


Ok, well thank you, I am indeed dockeryZ
http://stackexchange.com/users/172938/dockeryz

I'm glad I was able to help you out, though I cannot remember exactly which
question it was.

I appreciate the acknowledgement.  Best of luck with your project.

On Wed, Jan 28, 2015 at 4:08 PM, Wim Deprez <notifications@github.com>
wrote:

> I'm simply a programmer who found code by 'dockeryZ' on StackOverflow (
> http://stackoverflow.com/a/3451954/707700 ), and simply wanted to
> acknowledge that I am not the original coder.
>
> Honor to whom honor's due.
>
> It was not my intention to harass you in anyway, but indeed I should have
> checked first if there was a similar account on GitHub, so my apologies.
>
> Kind greetings from Belgium,
>
> Wim
>
> 2015-01-28 16:36 GMT+01:00 dockeryz <notifications@github.com>:
> >
> > who's this?
> >
> > On Wed, Jan 28, 2015 at 10:33 AM, Wim Deprez <notifications@github.com>
> > wrote:
> >
> > > Working version of showing collection history
> > >
> > > Used interesting manipulations of DATE to get the different date
> ranges
> > > (depending whether a user wants a monthly report, a quarterly report
> or
> a
> > > yearly report)
> > >
> > > With thanks to @SKRocks, @dockeryZ from inspiration through
> StackOverflow
> > >
> > > !! page-ophaalhistoriek.php , line 63: still have to check if this is
> > > correct !!
> > >
> > > Any feedback welcome, enjoy!
> > >
> > > ---
> > > Reply to this email directly or view it on GitHub:
> > >
> > >
>
> https://github.com/vvim/myrecy/commit/5ad5fe685093c6394d8be346e14d4b56c3b2cb30
> > >
> >
> >
> >
> > --
> > All the best,
> >
> > Zane Dockery
> > B.A. Spanish
> > A.A.S CIS & Web Technologies
> >
> > —
> > Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vvim/myrecy/commit/5ad5fe685093c6394d8be346e14d4b56c3b2cb30#commitcomment-9486934>
> .
>

--
All the best,

Zane Dockery
B.A. Spanish
A.A.S CIS & Web Technologies


reasons why explained in-person


This will be invaluable, thanks!


Oh, because otherwise you have crazy reflection shenanigans. Reasonable.


I guess so, if we get those options from http://www.w3.org/TR/html5/forms.html#dom-select-selectedoptions or http://www.w3.org/TR/html5/forms.html#dom-select-selectedindex


Hey! Is it possible to get in contact with you somehow?


In fact I had already done this spontaneously: https://code.djangoproject.com/ticket/24239 but it looks like you have been faster than me for this. Sorry for the busy work.


ha! They seem to be putting up one a day...and yet the sites are all the same!


should this be called #last_engagement ?


Hi we have met on game a while ago, you told me some stuffs that you are able to do etc.. so i was wondering if it is possible to play the game with the .unity3d file on a personnal webserver. that's all :]


+1 for splitting the commit that redirects stdout/stderr


What exactly is 'stuff'?


alignment


Just an idea: Maybe we should print the position to stderr when this happens, so user can resume with --skip if she wants to? Preferably with some margin, eg. not counting the current inner loop.


Thank you for this : )


great commit I r8 it 8/8


just kidding what the fuck is this


I guess this is ok.


Tu as testé ? Ça marche bien ? Vu que je libère sur le exit, on doit pas voir grand chose.


Can you add "This class is mutable." to the end? I like the word "mutable".


sweet.


tight.


Hi Have no problem with that …. but I think the standards document should not assume this is done. These fields should be there and then we can implement them in which way we want.

Lets have this a top level “design” document. If we implement this in mongo using _id that is fine.

S
On Jan 28, 2015, at 4:05 PM, Arman Arkilic <notifications@github.com<mailto:notifications@github.com>> wrote:

We can get time using mongodb's _id field: http://docs.mongodb.org/manual/reference/method/ObjectId.getTimestamp/#ObjectId.getTimestamp
This is one of the reasons why I am keen on using the built-in mongodb hashed ids. Unless we want absolute precision, this would be enough

—
Reply to this email directly or view it on GitHub<https://github.com/ericdill/docs/commit/7250da36b4c923d01c2357c659377a08381c86e3#commitcomment-9486894>.


@magopian This was breaking builds.  I had to revert this.


:boom:


Hi, are we catching the IllegalArgumentException thrown from the try block? why do we require a try/catch block here? (it doesn't have anything to do with java 6/7 right?)


NO


ack


@whyrusleeping sorry to comment here in repo but would be interested in talking with you, could you fire over your email or skype?


ack thx


what is this for?


@crisptrutski I had to mess with saucy here... let me know if you approve.


i don't think we need to add this


Now that it can also be written as `x` or `X` we could rename it to something less specific, like `WILDCARD`, which is also more appropriate for what the token stands for.


if the incoming lock bits are all zeroes, lockedState should be set to true here.


Probably would be a lot of work, but as Snort and Suricata have similar code, wouldn't it be good to make these Text Descriptions utilize a Variable format like  ie:   $IDS_type.

gettext("ETPro for {$IDS_type} offers daily updates and extensive coverage of current malware threats.");


looks like `E.decodeUTF8 <$> BS.readFile friendlyName` would be a better way, if we're touching the line anyway


spaces between these commas then it looks good to me!


hopefully this can be switched back


and this


sweet


Pfft, at den eventen blir kalt en ekstra gang kan jeg ikke se på som bedre.


yes sir!


nickpick I know but the indentation here is really off.


nice.


hopefully we can switch this back


ok


Do you really need the:

for episodeKey in season_diff[seasonKey]:
    episodes.append(season_diff[seasonKey][episodeKey])
show['seasons'].append({ 'number': seasonKey, 'episodes': episodes })

can't you just:

show['seasons'].append({ 'number': seasonKey, 'episodes': season_diff[seasonKey] })

you night also need to make a similar change for the "if show_col2:" else section


Closes #814


It appears I have been commenting on the commit (https://github.com/AaronFriesen/Trydent/commit/a47b7f278f64b6318f9280441c938af6bae68d9a) rather than on the files changed (https://github.com/AaronFriesen/Trydent/pull/3/files). I'm going to comment on the files changed in the future.


OK, I correct myself: what I am testing here is the functionality contained in ``FileStructure``, which is just a wrapper around an ``RDD[String]`` that has the lines of a file(*). So here I _assume_ the writing and reading of a file to/from hdfs works, and I am testing that the wrapping up into a ``FileStructure`` does too.

(*) (the actual motivation for doing this seemingly useless wrapper is considering each line of an XML as an XML itself, so I just needed to add a prefix and a suffix to each line)


Closes #815


:zap:


Here, we could simplify the grammar by grouping the wildcard terminals into a non-terminal
```
<version-expr> ::= <wildcard>
                 | <major> "." <wildcard>
                 | <major> "." <minor> "." <wildcard>

<wildcard> ::= "*" | "x" | "X"
```


[Based this off git](https://github.com/git/git/blob/627736ca799edacf13881da7e671964a0afb94b8/color.c#L285-295).

The `1` argument to `isatty` should probably be replaced with `STDIN_FILENO` [based on a _real_ quick search](https://en.wikipedia.org/wiki/File_descriptor).


:rainbow:


oh snap!


Merge


:accept:


This would probably be better as
```
<p>© ${settings.PLATFORM_NAME} ${settings.COPYRIGHT_YEAR}</p>
```


ack


Not sure I understand (maybe conversation will help?). The test is specific for XML syntax, yes.

What would be a ``TODO`` is to use ScalaCheck to make a better test, though.


These are useful initializers for the URIData. What is the motivation to drop this?


Before, overriding this functionality required:
* the creation of a new controller
* the controller override to be specified in the routes config
* the entire controller action to be overridden

This approach has the following benefits:
* the user model class should already exist within everyone's project. so no need to create a new class / file
* without the controller override, there is no need to modify the routes for this change
* the override can be confined to this specific method instead of an entire controller action


:+1: (fwiw)


why did you drop the persistence APIs? How do you store the lock bits across power cycles?


are these headers really necessary?


War die config/neiintegration.cfg in meinem Paket schon so mit drinnen? Die hatte ich nämlich so zumindest auf meinem Client eingestellt gehabt ... glaube ich.


The objectVersion in msg objects isn't used for anything currently. It was added to msg objects during the protocol v3 upgrade so as to be consistent with all of the other object types.


Can you please confirm that this is fixed in master?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/615
success: http://build.servo.org/builders/linux2/builds/614
success: http://build.servo.org/builders/android/builds/650
success: http://build.servo.org/builders/mac1/builds/831
success: http://build.servo.org/builders/mac2/builds/831


kind of obsolete


typo: doubled full stop


This should have been `ftello` yet, changed to `ftell` in subsequent commit.
But I leave it this way, cause everything will be ok once I integrate review commits on original ones.


I could be wrong but the else should only be hit when we're removing shows from trakt, so there is no real point in adding more data there. Would have done it if I had a smart solution, but got no time to think about it right now.


awesome !!


could you please align these?


Once we check for the result of `ftell`, I thought it would be coherent to check also for `fseek`.


Looks good


Now, if a payment is a scholarship, authorization is handled separately.


fast-forwarding master to auto = 3736396c


same here


Straight-forward


Could you please also share the application code for driving/testing the URIBeaconConfigService? Thanks.


@ilanschnell I'm just now looking through back emails and such so this may be on the mailing list and I didn't see it, but why did you make this commit?  To the best of my knowledge (and testing), quotation marks were not needed here.

Also, please advance the version numbers in `setup.py` and `meta.yaml` when bumping versions.  This caused a new build 0 of 2.0.0 to be built on binstar because it's setup to automatically build on push to master (see the builds in the [dev channel][1]).  Now there are two conflicting versions of that build if anyone internally was using `conda/c/dev` and `conda` and no v2.0.1 to go along with it.  Note, I've already done this in 985fa772d136600a13336ffed6dff6d146bcb602.

[1]: https://binstar.org/conda/conda-env/files


good


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/fe265c6c830e0ddd33b1ae41418bd8e1f46c222b


merging pcwalton/servo/text-overflow = fe265c6c into auto


pcwalton/servo/text-overflow = fe265c6c merged ok, testing candidate = 01659758


Bug 457726 - Fix global undefine in gitPush.js
Signed-off by: Brandon Dalesandro brandonadalesandro@gmail.com


@gforcada It was fixed in the following commit, same PR (see cfa6d71).


Yea, but this change affects the `readPosition` so I'm wondering why did it work at all.


Sam is correct here. This was patterned after node_voicemail_main.


For https://github.com/Hitchwiki/hitchwiki/issues/23


[  -n "...." ], no?


This looks good to me. Has this been tested with together with puppet?

One thing that strikes me is that this PR will create a lot of conflicts with [HI-328](https://tickets.puppetlabs.com/browse/HI-328) and [PR-230](https://github.com/puppetlabs/hiera/pull/230) since that too changes the same method signatures (passes the recursive_guard all the way down).


Pass, would you mind taking a crack at our long test. https://github.com/Ontraport/frontend-interview-test-long


Built successfully, just a repo sync and make clean. Thanks Paranoid Team.


Looks good, if only the entire world came prehydrated. I'd just add extra `{}`s between that if and the try block for readability ;)


Watch out of the repetition of "our dream." :)


@edolstra: I see now it *is* just a stdenv bootstrapping problem, most likely. That ``preHook`` is only passed to the final stdenv, and our *final* ``zlib`` is built by bootstrap tools (on master).


This method, while amusing, does not seem to function very well even on newer versions of internet explorer. Will save .csv to server and provide a link instead for now.


Do not understand why you would test -d the directory and then just mkdir -p it
Skip the test entirely.


Reusing `option` name for unrelated variables here in same scope is a bit smelly though :fish:


Is this documentation used any more? Is it worth updating this for Sonic Pi `v2.x`?


Neat! Thanks for looking into this :)

Should this be `module.modulemap`?

> **Note**
>
> For compatibility with previous releases, if a module map file named module.modulemap is not found, Clang will also search for a file named module.map. This behavior is deprecated and we plan to eventually remove it.

—http://clang.llvm.org/docs/Modules.html#module-map-language


reviewed code change here


Yep, Jeff pointed that out. Repetition of "consuming for" also corrected.


N'oublie pas de renvoyer un commit si tu as modifié un fichier de code.


the else part is hit when you have the show in KODI but not in TRAKT and the other way around as well, when the show was not found in show_col2.


I'll update the test to show you what I mean...


I really hope people will actually see that Easter egg! I guess I might have to decrease the damage limit a bit to make that happen.


Sorry about that extra s


FWIW, I finally got around to testing NVVM (in place of NVPTX) on a branch (https://github.com/jrk/Halide/tree/nvvm) and we consistently saw 30% or greater performance bumps for @gchauras's work, significantly outperforming OpenCL on NVIDIA hardware as well. The bad news is that NVVM only jumped from LLVM 3.2 to LLVM 3.4 in CUDA 7 RC1 about *two weeks ago*; it's unlikely to move past 3.4 for a very long while yet. I think it is possible to make a translation layer, but in my experience on both this and the Simit GPU backend, that bitcode/LL text format compatibility really is a deal breaker for using NVVM otherwise.


Java Script code is useless....
Uploading will be fine without home-controller code

forget about change in home-controller


I'll update the sample.


J'ai testé de cette façon:

>test
>cat /proc/4/maps

Toutes les regions sont visibles, mais les fd pour les map non anonymes ne sont plus valides au moment de la lecture du coup je peux pas résoudre le nom de fichier (j'affiche [fd lost] à la place)


Razzeee, thanks for ur hard work on this, much appreciated. :)  Is it necessary for us to remove everything from our collection and then re-sync for the 'added to collection' and 'watched at' to properly sync? I've already got movies and tv shows showing up on trakt from a previous sync but the watched date shows up as at the last sync time (from the previous commit). Currently, re-syncing does not change the dates, so I'm guessing I have to remove then re-sync?

Thanks! ;)


Ich hatte sie noch leicht Abgeändert

Und die meisten Blöcke können jetzt auch mit dem forge multipart sägen zu Covern oder so zersägt werden


llvm 3.4 + MCJIT doesn't work on 32-bit OS X due to some relocation
weirdness. Apart from that 3.4 should still work, but it's not a priority
for nightly testing.

On Wed, Jan 28, 2015 at 1:50 PM, Jonathan Ragan-Kelley <
notifications@github.com> wrote:

> FWIW, I finally got around to testing NVVM (in place of NVPTX) on a branch
> (https://github.com/jrk/Halide/tree/nvvm) and we consistently saw 30% or
> greater performance bumps for @gchauras <https://github.com/gchauras>'s
> work, significantly outperforming OpenCL on NVIDIA hardware as well. The
> bad news is that NVVM only jumped from LLVM 3.2 to LLVM 3.4 in CUDA 7 RC1
> about *two weeks ago*; it's unlikely to move past 3.4 for a very long
> while yet. I think it is possible to make a translation layer, but in my
> experience on both this and the Simit GPU backend, that bitcode/LL text
> format compatibility really is a deal breaker for using NVVM otherwise.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/halide/Halide/commit/a08801cc5ea71ed07771ad7d5d99c72e16de1df4#commitcomment-9487712>
> .
>


This link is broken :(


Allowing a default key of `''` seems dangerous.

Consider removing this default and throwing an exception if a key is not provided.


Both objectVersion and streamNumber = 1. It was reading the objectVersion off of the wire and thinking that it is the streamNumber. At this point, since no one else has this updated code, it would be possible for someone to propagate an msg object with the stream number set to something other than 1. But doing so would have no noticeable affect: the objectProcessor thread does already check the msgVersion (i.e. objectVersion) correctly. It then doesn't check the streamNumber for validity but doesn't use the streamNumber for anything important anyway. So the biggest attack anyone could utilize with this bug is determining whether someone is running PyBitmessage or an alternative implementation. I would imagine that there are already a dozen ways to determine the same thing.


TESTS FAILED
 Mr.roboto url : http://jenkins.plone.org/roboto/get_info?push=f53abc8ef438480884cd80ddff9c65d8
 plone-5.0-python-2.7 [FAILURE]


Oh OK. I got rid of the specific ``toString`` for ``EventDetail`` when I created case class specifics to each part of the event (ie, "basic info", "user info", etc). I am remembering that my motivation for having a ``toString`` mentioning the XPath was to debug directly on screen different mapping errors. In this version, since the class ``XMLField`` encapsulates the paths to be used, I don't need to be printing things to examine them.


I don't think you should be doing that..


In the interest of backward compatibility i think this is fine. One of the nice things about mongo is that its pretty flexible in regards to the _id field on inserts. Here is a snippet from the insert() docs on mongodb:

> If the document does not specify an _id field, then MongoDB will add the _id field and assign a unique ObjectId for the document before inserting. Most drivers create an ObjectId and insert the _id field, but the mongod will create and populate the _id if the driver or application does not.

>If the document contains an _id field, the _id value must be unique within the collection to avoid duplicate key error.

In our case you are allowing the application (meteor or its client) to create an _id and by doing so you are trusting that they will choose one that is unique to avoid error.  IMO i dont think there is a real reason to allow the client to create an id when creating a new record when the driver or mongo itself will create a unique one already.


Thank you!


I'm worried the folks at TranslateWiki will be frustrated by these for not using the more standard format:

```
taxon_concept_search_keyword:
  one: "taxon"
  other: "taxa"
```

...Which you would then have to cleverly call from the controller:

```
@all_params = []
[:taxon_concept, :article, :image, :etc].each do |keyword|
  @all_params << [I18n.t("#{keyword}_search_keyword", count: 1),I18n.t("#{keyword}_keyword", count: 123),keyword]
end
```

...Sorry to be a bother about this, I just know they're going to complain. :)


Will do.


Really - wouldn't a very simple lambda just not use threading altogether (ie remove the Thread.sleep)? I kinda liked what was there before :)


Eh, but without the sleep :)


Compiler error message:
````
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:44:0: (to 68:3) Error in final record unification
Can't unify record constructors
Have:  <UNIF:U316::{Unit}> ++ [Body = ()]
Need:  [Html = ()]
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:44:0: (to 68:3) Stuck unifying these records after canceling matching pieces:
Have:  ([Body = ()]) ++ <UNIF:U316::{Unit}>
Need:  [Html = ()]
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:37:17: (to 42:10) Error in final record unification
Can't unify record constructors
Have:  [Html = ()]
Need:  <UNIF:U316::{Unit}> ++ [Body = ()]
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:37:17: (to 42:10) Stuck unifying these records after canceling matching pieces:
Have:  [Html = ()]
Need:  ([Body = ()]) ++ <UNIF:U316::{Unit}>
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:24:3: (to 27:16) Error in final record unification
Can't unify record constructors
Have:  [Html = ()]
Need:  [Dyn = (), MakeForm = (), Body = ()]
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:24:3: (to 27:16) Stuck unifying these records after canceling matching pieces:
Have:  [Html = ()]
Need:  [Dyn = (), MakeForm = (), Body = ()]
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:25:3: (to 27:16) Error in final record unification
Can't unify record constructors
Have:  <UNIF:U316::{Unit}> ++ [Body = ()]
Need:  [Html = ()]
/home/admin/wrk/urweb/urtutorial/step7.3/auth.ur:25:3: (to 27:16) Stuck unifying these records after canceling matching pieces:
Have:  ([Body = ()]) ++ <UNIF:U316::{Unit}>
Need:  [Html = ()]
````


Is the "a" at the end of EioKillera intentional or a typo?


Consider renaming this to `selectedBlockfacesLayer` or equivalent so it is clear what the layer contains.


Is there a good reason this got changed from a destroy_all to a delete_all?

This regresses some of the behaviour from this commit

https://github.com/spree/spree/pull/5600

Specifically when adding adjusting a fresh order the backend via the cart, you end up with every increasing inventory units.


Hi @nicolo! The RSpec tag should be `identifiers_option` instead of `header_names_option`. This tag allows to select specs that are related or depend on a specific option:
```bash
# run only specs related to the header_names option
rspec spec --tag header_names_option
```

I find useful those tags because options are very transversal features which often spread among several spec files. Even if I haven't tagged the specs systematically, I try to tag them it when I modify them because it's much easier to tag pertinently when one just focused on the feature than afterwards. The idea being tagging without  bloating specs with tags.


Ah oui c'est vrai, je ne fais que désallouer, je ne détruis pas la liste.


Minor typo: Need space within "and findAll()"


"Ни дня без коммита"


Ah ha!  I just got to [the email][1] that explained it was caused by issues with spaces in the path.  My bad on this one.  I should have caught it because I've worked with Matt W's code that fixed some the space issues.

It would definitely help future developers if the commit message here had explained the context of this issue.  Links to the post at a minimum or ideally a short explanation with the commit message so the explanation is always with code.

[1]: https://groups.google.com/a/continuum.io/forum/#!topic/anaconda/dbQOix8rFDo


Je confirme le bon fonctionnement : j'ai modifié test pour ajouter une boucle infinie et depuis un autre terminal j'affiche /proc/6/maps.


Imagine a case where someone attempts to update a record with _id = '1' but instead has a typo in the application and tries to update _id = '11'. Instead of getting a 404 for the update they will create a new record. Maybe i'm thinking too deeply into this but i just always try to be extra defensive.


nice :D


Ran it against Puppet with no spec failures. I haven't run it with Puppet acceptance.

The conflicts will have to be resolved; maybe we should be using extra_data to pass options? It looks meant to be an options hash argument, but I'm not super familiar with the code.


In org.eclipse.jetty.util.Uptime.DefaultImpl(), on like 65 with the other set of exception catches, shouldn't have you have also caught NoClassDefFoundError?  That's the actual exception that gets thrown if java.lang.management.ManagementFactory is restricted (as it is on Google App Engine).

Here's the stack trace I got:

java.lang.NoClassDefFoundError: java.lang.management.ManagementFactory is a restricted class. Please see the Google App Engine developer's guide for more details.
	at com.google.appengine.runtime.Request.process-766931303f63e8b3(Request.java)
	at java.lang.management.ManagementFactory.<clinit>(ManagementFactory.java)
	at java.lang.reflect.Method.invoke(Method.java:45)
	at org.eclipse.jetty.util.Uptime$DefaultImpl.<init>(Uptime.java:54)
	at org.eclipse.jetty.util.Uptime.<init>(Uptime.java:99)
	at org.eclipse.jetty.util.Uptime.<clinit>(Uptime.java:86)
	at org.eclipse.jetty.util.log.Log.initialized(Log.java:186)
	at org.eclipse.jetty.util.log.Log.getLogger(Log.java:288)
	at org.eclipse.jetty.util.log.Log.getLogger(Log.java:278)
	at org.eclipse.jetty.util.UrlEncoded.<clinit>(UrlEncoded.java:58)


There is code introduced in https://github.com/azavea/nyc-trees/pull/377/ that needs access to the *actual* `GeoJSON` layer, so we probably still need to return `blockfaceLayer` here.


Perfect!


This comment is now out of date. :)

Digression: Are you planning on having a dependency tree defined by the new transform API? It seems like that would help with this magic ordering.


"We only have one image. Each pixel of the image consists of red, green, blue and alpha values (see the r,g,b,a in line 11 and 17)" Ok, I understand this part !

"Now, because we only have black and white pixels, and because the red/green and blue values are all either 255 (white) or 0 (black), we just get the red value for each 9x9 black or white pixel block in the big picture." Humm... Why you get the red value and not green value for example ? In addition, you mean 19x19 black or white pixel block in the big picture isn't it ?

"One is the red value of each block of the big image and the other the alpha values of a single 9x9 block, the center block" that's not clear.

Thank you for your answer !


Question to think about: should this be a `Cursor<Type>`?


This one is tricky. It makes `1` be equivalent to `1.*`, whereas prior to this commit it's treated as `1.0.0`. See [link](https://github.com/zafarkhaja/jsemver/blob/master/src/test/java/com/github/zafarkhaja/semver/expr/ExpressionParserTest.java#L102).
Besides the fact that I'm not sure it's an intuitive behavior it's also a breaking change, so we need to think twice before doing this. Is it really important for the node-semver compatibility? Is it widely used in the npm/bower community?


86121908_copy_schedule (macumber) - Win64-Windows-7-VisualStudio-12: OK (2173 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.22%25-yellow.svg)


Was this removed because it was never used?


In my opinion, passing these two parameters in the command constructor makes code look uglier than before. Is there any reason to pass these variables ... or is this just needed to simplify mocks in tests?

If this change is just for tests, could we create some *getters*  inside the command to get the Guzzle client and the Distill object in order to mock them?


Just `return Visit(…)`


It's added in a later commit.


Yep, as far as I can tell.


Why remove this? By doing that you always go into the RedeemCoupon check, which is unnecessary.


you could probably find out what it tries to do by responding with different data on the 0xE2, 0xE4 and 0xE8 command and see if that changes anything

I have a 486 with a SB1.5 (or something?) somewhere, I could try to find out what it does there


Conceptually the encoding is defined in the UriBeacon spec not the Config spec so it would eventually go into a UriBeacon helper class as a static method.

Also the encoding doesn't implement urn:uuid so I was going to add that before moving it into a UriBeacon helper class.


Pretty pointless change o.o


Thanks, @ilanschnell!  This is tangentially related to https://github.com/conda/conda-env/pull/47 as well.  Looking at the timeline of b00986da65037608961cdc93221e4c9873f8a7ae, I think I had to do the other because `--root` wasn't available until a month after I wrote pipe-abomination.


Fixed
Thanks!


Technically yes. I'll admit I didn't think about that when writing the patch. However, it would require an attacker to have access to already have access to the file system, since srcFile and destFile are not direct user input, but rather files that have been located by sickrage scanning a directory. So a malicious filename could result in command injection, but the impact is minimal since the attacker requires machine access.


Damn, whoops. Thanks!

Yeah, hopefully. I've opened an issue at #607 which I've yet to add a proposal to.


Prosím vyvarujte sa v commitoch subjektívnym názorom.☺ "Ficov balicek" je subjektívny. Takého dobrého premiéra sme ešte nemali. Vyviedol nás z krízy. Ale kam nás dovedie.


This should be inside `g_once_init_enter()` - the boot ID isn't going to change after our process starts, and I'd like to avoid `malloc` and `g_object_ref` inside hot paths as much as possible.

Could also use the lower level `g_file_get_contents` which takes a pathname as a string to avoid a `GFile` allocation.


Hmm.. Good point, I was looking at it differently.


Why not use this for the next greeting? Better than to remove it completely. It must be a valid value after all.


Yeah, but there was one little `return;` that was bugging me ;~;


Alternatively, we could do this inside `ostree_repo_open` or so, and cache the result in the repo struct.


comment on first patch


:shipit:


comment on second patch


@mamico yes, sorry I thought I was seeing all changes instead of just a commit, my bad!

everything looks fine. I would suggest to push the unrelated commits (txt->rst and gitignore) directly to master so that the branch is less cluttered and gives less chances to merge conflicts :+1:


I like this a lot. In the future we should think about the preconditions for all of these methods and implement checks like this to verify them. For now probably not a priority, maybe when we factor hoist_launchable into its own package.


Easy to miss if you put it at the end of an already long line.


Persistence is done in the https://github.com/google/uribeacon/blob/master/beacons/mbed/main.cpp

It saves all settable state (Params_t), not just the lock bits. The restore is done prior to the call to new and save is done when the service is shut down.


`go/tls` does [not do](http://golang.org/src/crypto/tls/tls.go?s=4745:4821#L160) these checks. Is there any situation where these might be problematic (FAT filesystem?), or did they just forget too?


Sure, thanks!


Yeah, I probably click on ptjs or rumor, so it's likely the next one, but I just wasn't sure.


Why break this into two strings?


The result is not as simple as I'd like. But It seems to work on a simple example. Found out that IsoNormal used in MH has apparently changed in Distributions, the new constructor is way more complicated.

I profiled a run, despite the complicated setup, most of the CPU time is spent in the log-lik function, which is good news.


Looks like Python has the facility using pipes.quote to escape user input for use with os.system


Should be `/user/cloudera...`


Not that I can think of besides intentionally trying to skip the callbacks possibly for performance.  Please submit a PR updating it back.


```asm
bcd: macro

x = 10
rept \1 - 1
x = x * 100
endr

rept (_NARG + 1) / 2
    dn ((\2) / x) % 10, ((\2) / (x / 10)) % 10
x = x / 100
endr

endm
```

```asm
coins: macro
    bcd 2, \1
endm

money: macro
    bcd 3, \1
endm
```

```asm
    coins 180
```


Can't tell, I don't see any issue with any of the gems even Spree backend seems correct https://github.com/spree/spree/blob/2-3-stable/backend/spree_backend.gemspec#L25 so your Gemfile probably look like this:

```ruby
gem 'spree', '2.3.0'
```
when it should be like this to allow patch updates:
```ruby
gem 'spree', '~> 2.3.0'
```
because latest 2-3-stable of Spree is v2.3.6


I would do something like:
```diff
--- a/pkgs/stdenv/linux/default.nix
+++ b/pkgs/stdenv/linux/default.nix
@@ -26,6 +26,11 @@ rec {
       export NIX_ENFORCE_PURITY=1
       ${if system == "x86_64-linux" then "NIX_LIB64_IN_SELF_RPATH=1" else ""}
       ${if system == "mips64el-linux" then "NIX_LIB32_IN_SELF_RPATH=1" else ""}
+    ''
+    # platforms where bootstrap tools support the flag
+    + lib.optionalString (system == "x86_64-linux" || system == "i686-linux")
+    ''
+      commonStripFlags="--enable-deterministic-archives"
     '';
```

That way we get the flag during the whole bootstrapping process on those two platforms. (That line will be twice in the preHook, but I didn't want to complicate the expression and I wanted to preserve it in the final stdenv on all linux platforms.)

Any suggestions?


APK is https://github.com/google/uribeacon/releases
source is here: https://github.com/google/uribeacon/tree/master/android-uribeacon/uribeacon-validator


I don't get it, why remove this? Let it be messy, if you leave it in, the one who adds PTJs has the dialog right away.


Oh look, spaces.


This method doesn't return names and namespaces, it returns URIs.


actually, kinematic is also added here but will fullly be in step 3.


This MUST be a fatalf


Also, if err ... ; err != nil {}


Please use the keyword arguments here (as I suggested), as they make this much more readable. This is supposed to be an example for someone who has never seen this functionality before. What will they make of "40, False, True"?


Might have gotten the wrong URL, here is main.cpp
https://github.com/google/uribeacon/tree/master/beacons/mbed


Hi. This patch avoids the component overriding ... The line can be removed?


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/615


Thanks for making this change to MH, I haven't noticed the relevant change in Distributions before you told me.

Yes, I had run a couple of trials a while back, the runtime seem to be reasonable compared to previous configurations of the package. It is a complex setup indeed, with a steep learning curve of the package's code.


@AsgerPetersen how's this for closure on #261?


@asmeurer I would love to -- I don't have the bandwidth to this week.  I would *really* like to keep the automated builds of conda-build, however.  It's important that we get all of the various conda packages building automatically when pushed to `master` so we can have more eyes internally (and in the broader community for those who want to help out) on code before its released.


From my earlier review:

> While you can see the names and namespaces, it would be more valuable to call out that the method gives URIs for valid datasets underneath the repository URI.


Is there a reason to be squashing these commits? There was a logical separation between them, and now we have a large single commit, with the wrong title.

This should at least be called "Remove Spree::Money preferences", because we aren't just removing it from the admin.


It would be a really long line.. unless I'm using that wrong o.o

Though, I guess I can just move the comment down under the Msg.


Oh, I actually missed it. I added in the others back in but forgot this one :P


@hmiah101
you have to resync, but w're still in dev there might be other problems happening.
In fact I just found a bug.

@snagytx
Your right we need to fix that for shows that are not yet in your trakt collection. Otherwise they are wrong.
Btw, your code improvement isn't working, don't ask me why :/


My previous review comment:

> "JSON format" refers to any JSON, so I think this should be more clear and link to the partition strategy format, which is JSON.

The link doesn't need to be removed, it was actually correct. The link text needs to be more clear than "JSON format" because it "refers to any JSON".


:sweat_smile: thank you!


Yup, it's used at http://www.raspberrypi.org/documentation/usage/sonic-pi/README.md

(I'll let someone from the RPF comment on whether it warrants an update!)


xD


BTW I think you can do `this.closeDropDown.bind(this, true)` (instead of the slightly wordier `function(){ this.closDropDown(true); }.bind(this); }`)


If you can provide a test case where an issue can be reproduced, we can look into a fix.  From what I remember, this was needed to ensure the admin template layouts were used if layouts weren't set in the frontend.


This reference name is too long. The reference links help by keeping shortening to a word or two rather than something that distracts from the rest of the text when reading unrendered markdown. The reference above, "using-kite-properties" should also be shortened.


Please shorten this reference link as well.


Is there any benefit of doing:

    if(a) {
      if (b) {
        return;
      }
      // Do things.
    }

over

    if (a && !b) {
      // Do things.
    }


Just nitpicking, but ==== ends with h1, however ~~~~ used in previous subtopics is h2.


The `ripple` namespace should not be used here. classes in namespace `Json` should not depend on identifiers in the ripple namespace.


For example you can see it here http://www.warcraftmovies.com/movieview.php?id=240417  0:24  the same is in Blade edge arena with bridge.


I'm not sure I understand. Don't I loose the 100ms delay if I go this way?


This change also didn't address the earlier review comment:

> If we are mentioning a repository URI, then we should add it to the URIs document.


This introduces cycles in the dependency graph of classes. protocol/ depends on json/ and now json/ depends on protocol/. The json library should be a leaf in this dependency graph, and not depend on identifiers outside its namespace.


Please, add a README file in the resource directory pointing to all the location and license of the image file you took.


И зачем?


69208874-LBNL_CoilVsSpacePeak (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I like how you highlighted the potential harms that may result as a product of allowing compromising information to be publicly accessible. While it is easy to focus on the benefits of open data and how society can interact with an increased production of data, it is also important to take note of the risks that are inherent in making information more easily accessible, as to make sure more good than harm comes from this relative recent phenomenon.


I'm not sure this is necessary. It was mentioned in a blog post, but did this repo ever have ``HTML()``?


r+


But as I said, testing is more important than having these builds (which I don't think anyone is even using right now), so until you have a chance to work on this, I'm going to revert this.


Should `output` be passed by `const&`?


Make a Qml file out of the keyboard (and probably other items) as they are used in several files.


saw approval from glennw
at https://github.com/mrobinson/servo/commit/fb3c2c38ee2ee8fcd125668532a676cfb46564ed


merging mrobinson/servo/layers = fb3c2c38 into auto


mrobinson/servo/layers = fb3c2c38 merged ok, testing candidate = 9fac4837


This block creates the "install" target, which currently doesn't appear to do anything sensible. It is not really necessary (the default target invoked by "make" will already install) and appears very broken.

Is this necessary for CPack somehow?

Cf [#747](https://github.com/UV-CDAT/uvcdat/pull/747#issuecomment-71473731)


Works for me.  Sorry I overwrote this in the first place.  Had tunnel vision on that particular day. :-)


It seems like you could reduce some duplication by switching the inner and outer if's like

```js
if (rend) {
    if (this.selectionMode === "single") {
      ...
   } else {  // multiple
     ...
   }
   input.setAttribute("aria-activedescendant", evt.newValue.id);
} else {
    input.removeAttribute("aria-activedescendant");
}
```


I'll try it. I just looks less readable/explicite what the `true` argument is for, anyway.


Nope - I put it in just because my current naming is kind-of-unusual.

I'd just name this HTML(), but I'm expecting that people will copy-paste this and use it as-is. Hopefully not though.


needed to create a paragraph break; in markdown, two returns for a <p> equivalent


I'm wondering why you need this method.  IIRC, ComboBox forwards keystrokes to the List, and List processes them.  So when you forward up/down arrow keys, won't list scroll automatically?  (And if it doesn't scroll, isn't that a bug in List?)


comment 1


Czy dictionaryColor nie zawiera 32 kolorów obrazka? Tj. pobranych ze słownika z  pliku. Jeżeli tak to numeracja powinna iść od 1, a nie od 32.


comment 2


@Razzeee

the bug is a weird one. i have removed episode collection where the collection date was of recent sync date. and re-ran latest dev code.

most of the shows did add to collection correctly, some shows have added with sync date. i have also noticed a couple of episodes with a date of the tomorrow.


> The change allows the host to skip the reference resolution step, before done using preProcessFile().

Thanks! I just recently moved this code into my `tsconfig`'s files expansion : https://github.com/TypeStrong/atom-typescript/blob/c37c031cdda0e899b96893ef7c25cc5c2aa04379/lib/main/tsconfig/tsconfig.ts#L197-L238 but I'll leave it in my code for now. Also useful information for @fdecampredon

------

@mhegazy I was wondering how I would handle the user modifying the files after original language service creation and adding  `///<reference` / `import`. I suspect that would no longer be an issue after this change. right? (assuming I keep the LanguageServiceHost updated with the changed file content)?


Kind of ugly to be using both `g_file_enumerate_children` and `gs_file_open_dir_fd`.  Maybe do a preparatory patch here where `cleanup_tmpdir` is ported to use only the latter, then do the tmpobjects stuff?


This seems like a place where we could avoid a malloc.


Se debe establecer un modo de trabajo con la base de datos , quiza usemos el orm viene integrado en el play framework , o tal vez se implemente otro tipo de patron para trabajar con la bd ( tablegateway por ejemplo ) , esto lo dejo abierto para luego poder discutir estos puntos.


Another nitpick in commit message, 4.60 instead of 5.60. Or is it really intentional?


Yes, but I'd loose the clear separation between the code for handling each of the two selection modes. At least this was my thought - that the code is easier to follow/debug this way, because the selection mode is the big discriminant here.


There’s a typo here: it should be UNSIGNED_MAX_1_BYTE. Another idea is to not define it here at all, since it is only used once in the `signet.c` file, and the number is not magic at all, so it doesn’t need a name.


@spencems
as said the ones dated today are from my bug. the ones in a future are probably due to a bug in kodi 14 from my understandings of their tickets.


I just went for the existing code :)

I'd generally agree with you, however given a and b are already compound expressions, I think this is better for readability.


Actually I mean `gs_dirfd_iterator_init_at`, not `gs_file_open_dir_fd`.


`tunncate` is a typo?


After porting this could be `gs_dirfd_iterator_cleanup`


I can make the following occur:

authRequiredNav - not logged in, go to http://localhost:3000/ask
notFoundNoSession - not logged in, go to http://localhost:3000/doc/doc-no-exist
notFoundWithSession - logged in, go to http://localhost:3000/doc/doc-no-exist

How do I make the follow occur in the UI?

preventedWithSession, preventedNoSession

Note that I can make a 401 occur by entering incorrect login info, but at that point I'm in the login dialog and error messaging occurs there, so the main page shouldn't change underneath it (and it is changing now, with the errorCondition div content being loaded).

Not sure in what case a 403 is returned, if I knew that I would be able to map that case to Mitch's spec.


@ericelliott is this in the right repo? :)


This comment is somewhat obsoleted by the change.

Also thanks for fixing my shit. :satisfied:


done


According to the grammar in the above Javadoc this should be simpler

1. Check for the `wildcard` at the `major` position
  1.1. If found - return
  1.2. If not - consume the `major`, consume the `dot`
2. Repeat p. 1.1. for the `minor`
3. If reach the `patch` must consume the `wildcard`


plugins should be located in Plugins/Android or Plugins/iOS


yea. it should be truncate. :(


Also allows regions which have preset aria tags, such as video players, to be excluded from the jquery.a11y aria_label function. Keeping their native behaviour. And stopping aria labels from popping out.


background(127); Will fix the pixel drag

bg = loadImage("sprites/cookie_madness.jpg"); was a test image I forgot to comment out

Also the java version in processing doesn't support Iterators so that set me back a lot.


empty line, beware of these changes. Feel free to rebase it.


We don't need the `this.handleOnInput(this.value);` call when `selectionMode === "multiple"`?  It seems like the `input` event should fire whenever `selectedItems` changes, regardless of `selectionMode`.


This should be `@logger ||= LinuxAdmin.logger` otherwise the attr_writer above it pointless


I submitted the wrong commit I blackboard, use the above^


preventedWithSession shouldn't happen given our requirements.
preventedNoSession would be loading the ask page, filling it out but not submitting it, then restarting the middle tier and then trying to post your question.


Because the option is a list of identifiers for distinct entities and the `header_names` option name is plural, it should be named `identifiers` instead of `identifier`. See also [the `Configuration` module](https://github.com/nicolo/simple_token_authentication/commit/9ed2322623895b06542a3817a0c96aeeffdb4b5d#diff-d6cb4f96b0a4d01d2139f0da6442d0dfR6).


Adding a comment about overlapping regions by the stride might be good.


r+


From what I understand, 0xE2 is an undocumented DMA identification routine that as far as I can tell, takes your data byte and encodes it as a byte that is written out over DMA. 0xE4 writes a test register, 0xE8 reads the test register back. The demo seems to write a fixed byte to the test register, and then read it back, so I don't think it's reading any IRQ configuration from that.


86714894-BoostSuperBuild (kbenne) - i386-Windows-7-VisualStudio-12: OK (2175 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.32%25-yellow.svg)


The thing is, that the private key should always be private - only the user should be able to modify it.
An unprotected key can be a sign of an attack.

Change your SSH host keys to 777 and run SSH in debug mode:
$ sudo /usr/sbin/sshd -d
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@         WARNING: UNPROTECTED PRIVATE KEY FILE!          @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
Permissions 0777 for '/etc/ssh/ssh_host_rsa_key' are too open.
It is recommended that your private key files are NOT accessible by others.
This private key will be ignored.
key_load_private: bad permissions
Could not load host key: /etc/ssh/ssh_host_rsa_key
....

Maybe go/tls does this not, because they want to be as generic as possible.
If the user needs a private key which has 755, than its his problem.

But I think that this is security risk and it's careless if a server does not protect
its own private key(s).


lol


LGTM


A small comment describing the problem the package has would be nice -- if there's something meaningful to say. I realize that's not always the case. Just my 2 cents ...


Could you just forward the SPACE key to the List, and the List handles selection?   Or is there some weird reason that List doesn't select/deselect items by SPACE key?   (I think there might have been but I can't remember for sure.)


The final plugin is located in those directories. "./gradlew build" from the root of the project and the full plugin is located in "build/unity-plugin/".

All this change is doing is updating the UA SDK.


Thanks bromy.


Having a special boolean here seems weird.  It's not really "cleanup", more of a "commit", right?

Possibly change `ostree_repo_commit_transaction` to call it directly?  And how about `rename_pending_loose_objects` or something?


@peti I wanted to add smthing, but can't deside what exactly to write. it's just old and can't be build againt current libs :(


Should update the function API doc to say that it returns a boolean for whether or not the event was handled (or something like that).


Steal https://github.com/mopidy/mopidy/blob/develop/mopidy/commands.py#L68-72 ?


sick changes bro ! :dancers:


Did you ommit the `.to_s` call for any specific reason?

I think it is prudent to add it as you did in the `identifier_header_name` method because one can reasonnably expect `{ user: :phone_number }` to be a correct value for the `identifiers` option even if using a String is suggested by the documentation.


I think the `stream` parameter should appear after the other optional parameters, for backwards compatibility for code which specifies the `sentence` or `highlight` by position.


good point :)


@ose1955 Почему убран кусок кода в `dev-modified/admin/controller/catalog/product.php`? Не вижу никаких причин для этого. Похоже на ошибку.


Fixed.  Removing the define will probably fall under considerations of a final review. Currently the library still does not meet the spec, when it does and it undergoes final review and re-organization I will come back to this topic.


Looks like it breaks if `^1.0` is passed. No?
If I'm not mistaken `^1.0` should be equivalent to `>=1.0.0 & <2.0.0` but the code give us `>=1.0.0 & <1.1.0`.


A clear and easy-to-follow solution! I believe it is more readable to explicitly enumerate the neighbour deltas than to calculate it, like I did.

I guess line 42 could be just: live_cells.exists(pos)? Performancewise even better to make it a set?

As mine examines each cell in each iteration. Probably a better performing approach would be to explore just the neighbourhood of the live cells (although worst-case is still quadratic per iteration). My approach:

https://gist.github.com/MagnusAhlander/d48a66347a7cf437a7e8

The toString-method is of course still quadratic.


Hello Dear
Thanks for this code

You have fotor sdk for android

Please if you have send for me


I think you forgot to check closing the dropdown by SPACE/ENTER?   IIUC SPACE or ENTER should close the dropdown and emit a "change" event.


My Gemfile has:

```ruby
gem 'spree',             github: 'spree/spree',              branch: '2-3-stable'
```
So I need to run ```shell bundle update --source spree ``` or Do I need to change it like you suggest?


Here's the explanation: when the List is used independently (not in the dropdown of Combobox), it has the default value (true) for KeyNav.focusDescendants. Thus, when navigating items, it gives them the focus, which leads to automatic scroll thanks to the browser generic mechanism - ther's no code in List for that, it's just the standard behavior of an element with native scroll to autoscroll for ensuring the focused element is visible.

Now, in the Combobox context, as you know, focusDescendants is set to false, to preserve the focus on the input element. That's why Combobox handles the autoscroll. Admittedly, this c/should be said in a comment.


Likewise here, don't you need to test closing the dropdown?

Also, it seems like all these `end()` calls are meaningless.  I thought `end()` only made sense after a command like `findById(...)`, and then `end()` would clear the found node from the stack.


ui应该不是abstract吧，应该自己可以控制显示，然后我们在此基础上附加显示


You could still do `this.closeDropDown.bind(this, true/*refocus*/)` similar to what you did above.


Yeah, it's sometimes difficult to say something that's helpful. It's fine the way it is, IMHO. Whoever wants to know what's wrong with `lushtags` can simply try to build it and see for themselves. :smile:


@peti yeah :D
And it seems that I was the only user.


We don't. I had the idea to distinguish between the external ids that are phenotips ids and non phenotips ids.
If an id was selected from suggestions, it would get copied here.


TODO: onResult(boolean async, ResultHandler<E> handler);


Good catch @Kikobeats Thank you.


OK.  In that case, it seems like this code should be added to List (instead of putting it in ComboBox)?


Updated.


This was an error in bottle and got fixed in https://github.com/bottlepy/bottle/commit/eeae2212f66df1c61fa302b079d11d4d0c3851c7


This broke shebang coloring.


I'm not actually sure this commit is really a good idea.

First the png, it looks a lot nicer than the gif, but it might be less compatible. @yellowled, what do you think about that part?

To be able to write the html for the progress widget in the template, I had to introduce ajax detection to **serendipity_admin.php** to not echo all the html of the backend like the menu, but only the main content. I think that is super useful - not only here, but for future changes - but it is quite a big feature to prevent ~20 lines of javascript. @garvinhicking, would you be ok with adding such a feature for 2.x?

The update all button itself works very good now, all that is really missing now are language constants, that someone else looks over the design, and maybe to look onto the error header in case an update fails to be able to react (but on the other hand, nothing bad would currently happen in such a case, it would just not echo the error and continue with the next one).


Added a "/" in front of the path /user/cloudera/datasets/movies


Not PEP8!


No, but if there is no text at all on the page before the script, it will crash.
This code actually just searches for the first string before the script and assumes that this is the name.
As there is always the Wiki head, if the name doesn't get found it will output something not related, but it won't run endless.


Hi,

I'm currently bulding the new REST API version on this repo.

I'm probably going to put the project on Mashape or something similar when the API is done for sandboxing.

And yeah this is a free to use API with a generated key for authentification ;)


It would be nice to select on <-finished along with a <-time.After(10*time.Second). That way the failure mode for the case where it never finishes is a timeout error reported by the test, rather than a test that hangs.


Make sure stderr is escaped properly here too!


Maybe add links to "VirtualBox" and "Vagrant" so they can go look them up easily?  On second thought... maybe not.  Depends on how much spoon feeding we think people should get used to.  Being resourceful is important...


For sure it should fire for both selection modes, but the code path is different. In multiple mode handleOnInput is called by _validateMultiple(), which itself is called either by the OK button action, or from this observer code depending on whether the popup is a ComboPopup with OK button or a List without OK button. The last time I checked it, it was working correctly in both modes, and I think the unit test counts the input and change events, but I'll do more tests.


Di ko makita yung script haha


This is just a fallback, normally the name of a script should be found in the wiki. The first element of the list because there is only one element.


Binary file not shown


Had a quick play with this and its looking good.  Like the extra graph and sensor data appears to be stable and reported correctly.  Also learned that Sonar only operates within 25 degree lean/tilt as a side effect of this when it showed the zero values and I checked the code.  Thanks.


I don't think so. You can check usages, but it should be called by the button.


"Since we work on remote Virtual Machines (VMs), ... "


Should we mention that setting this option modifies the `header_names` option default values? I think it may be useful, even if the behaviour is quite expectable.


Oops, you removed a spec example!


If this is the only usage, yes, why not.


Besides, the `identifier` method returns `:email` as a symbol by default.


mo dosyalarını göndermiyoruz. Internationalization 'un çalışması için po'dan mo dosyasını oluşturmak gerek bunun için de aşağıdaki komutu çalıştırmak gerekiyor:

django-admin.py compilemessages


Did you not like the idea of creating a vector from std::intersection? Slightly less efficient but also less verbose.


> Or is there some weird reason that List doesn't select/deselect items by SPACE key?

Yes, there is a reason. List toggles the selection in https://github.com/ibm-js/deliteful/blob/0.6.0-alpha/list/List.js#L464-472, but as you can see in the code it does it only if the event target is a child of an item renderer. That's why the event forwarding doesn't work - because the target is the input element. (Again, I'll add a comment in the code to explain it.) Okay, maybe Combobox could change the target of the event, but I thought this would be a less sane approach.


I'm not clear on what you want, here. If you're asking for a change to URIs.md, let's handle that separately. I can create a JIRA. I'm not sure what "it" is you want to add. A discussion of repository URIs? I would need context and what you want to say about them.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/617
success: http://build.servo.org/builders/linux2/builds/616
success: http://build.servo.org/builders/android/builds/652
success: http://build.servo.org/builders/mac1/builds/833
success: http://build.servo.org/builders/mac2/builds/833


Shortened to just "uris"


Sorry.
This was necessary to get an overview, to know what is what.


RIL should now work (both slots) when building CM-11.0 but for camera I am missing some hals.
Don't have device so I still testing.


69208874-LBNL_CoilVsSpacePeak (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (599 of 599 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.49%25-green.svg)


I see, makes sense, although it seems slightly wrong that on mobile that there are no `input` events until the OK button.  But anyway that's unrelated to this PR.


Have you checked the changes against file-tests?

https://github.com/boot-clj/boot/blob/master/boot/pod/test/boot/file_test.clj
(tests might require some changes for windows compat)

e.g. `lein test` at boot/pod should work


Right, I'll add it. (In fact I did add the @returns but it got lost when I copied the code changes from one checkout to another for making my PR.)


fast-forwarding master to auto = 9fac4837


Usually the string representation of an object in Ruby is denoted by the `#to_s` method. When an object is interpolated in a string (like `"#{object}"`) or inspected (like `object.inspect`) the `#to_s` method is called on that object, to it's convenient for the string representation of the object to be in its own custom `#to_s` method.


Given that the ctdb_rundir is guaranteed to exist because this agent makes it, this change looks safe.


I got fed up with the inefficiency.  Three passes, three allocations, three deallocations.  I just went to the source for `std::symmetric_difference` in libc++ and cribbed that.


saw approval from metajack
at https://github.com/mbrubeck/servo/commit/53135b2566e9dc0ba10a39e85e6f30e07589cac9


merging mbrubeck/servo/cache-dir = 53135b25 into auto


mbrubeck/servo/cache-dir = 53135b25 merged ok, testing candidate = 74e32d11