Maybe use a percentage (e.g. 60%) instead of hardcoding a number of examples, possibly warning the user if the resulting <percentage> of <size of the full dataset> is below an acceptable value (e.g. 1000 examples).


ah ok, i think that was leftover from when the username and password were being sent as a query string.


Code reviewed and approved


compiler do it


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10053/testReport/) for this commit**


通奸 ＝ 空间


You are hallucinating this!


Poor code.  Barely acceptable


i saw that in a passport/express tutorial and thought it was required. will delete.


:clap:


Is there an English version for this?


could you add comment why this class create program and what's going on?


add comment what is role of this class?


Oh boy, I forgot to update all the wiring between options and config values :( Thanks for spotting this!


No worries!


example 展示的是公开 api 不要使用 lib 下的东西，付到 Menu 上

var SubMenu = Menu.SubMenu


remember case in witch j == len(files)


Just a reminder: this is a fix for issue that broke integration tests.


~WebCLUserEvent() override;


Glad to help! Let me know when you're done with this fix.


That's what ate up all my time last night! Really really painful to attach to a process inside a sandbox, add a breakpoint, and then figure out how this compiled Haskell code with no C stack decided to call `access`. Turns out a standard call to `getFilePermissions` calls it three times, instead of using `stat`.

> On Jan 15, 2015, at 09:21, Shea Levy <notifications@github.com> wrote:
>
> (on the other hand, why are build systems using access anyway? Just try to run the damn binary!)
>
> —
> Reply to this email directly or view it on GitHub.
>


This reads a bit better if you use the initialiser syntax. i.e.:

var response = new PollRequestResponseModel {
    Name = poll.Name,
    Creator = poll.Creator,
    VotingStrategy = poll.VotingStrategy,
    ...

Even better, you could move it to a private function (e.g. ToModel(poll)), which will hopefully reduce the urge to use regions within methods...


It is also possible to use `train_test_split` from `sklearn.cross_validation`:
http://scikit-learn.org/stable/modules/generated/sklearn.cross_validation.train_test_split.html


Ugh, and why is a compiler calling `getFilePermissions`? :grinning:


@linwiz I wrote it  few times :)

it's ok for mySQL SQL interpreter to  work on varchars as on booleans so

>> set field = NOT field  << - means make it opposite

in details:
 set value in column "field (which is for example "1") to opposite value (so "0" here). All is made on varchars - as you defined them. I would use boolean :)

In our case it just mean to switch the pin output.


@vladberteanu i guess i was thinking that this api would be open to the outside world, but i'm not sure why i thought that. i also applied it inconsistently. i wasn't thinking it through.


Just figured out why I was still running in to the 'Cannot bind a reference' error. You need to remove the sample_name_labels and library_name_labels from the `has` section on top.


Is it safe to release objects in arbitrary order?
for example, if there is dependency between WebCLProgram and WebCLKernel, can we release them like this?


Giving it a try..


@ricardomv Good catch; I actually was just experimenting with the dashboard and wasn't ready to commit it, so including it here was a mistake.


```
FormValidation.warning("The ID '%s' is already in use in %s", value, storeContext.getFullDisplayName());
```

Would be better on so many levels... obviously some ModelObjects may not support full display name... but doesn't stop you from trying ;-)


I tracked down the call yesterday but don't have it with me :( probably
unnecessary, but it's in the ghc-binary precompiled code (and the thing
we're building, but that's not what breaks us)

On Thursday, January 15, 2015, Shea Levy <notifications@github.com> wrote:

> Ugh, and why is a compiler calling getFilePermissions? [image: :grinning:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/copumpkin/nix/commit/94de7bc34ea8f3879077705bce7d8b5b80da9269#commitcomment-9298161>
> .
>


brackets probably need escaping, as it's a regex


r=nick29581

Fixed error message and added help


r+ rollup


Usage:
`csv:[id=object_id]//<directory or csv file>`

Parameters:
**id**: Object id. Default: 0. If the URL is a directory, the file opened is *directory/object__id__.csv*, where **id** is formatted as `%02d`. If the URL is a csv file, this parameter is ignored.

Examples:
`./SensorViewer -posys csv://somedirectory`
`./SensorViewer -posys csv://somedirectory/object00.csv`


UsetComstFiledTypes should be UserCustomFieldTypes, spelling error in commit comment!


Code reviewed and approved


@nikomatsakis and I discussed offline.  @nikomatsakis points out that in an example like this (which is a further simplified version of the problem encountered above):

```rust
fn main() {
    let x = 3u8;
    let p = Option::Some(&x);
    let y = 4u8;
    constraints(p, &y);
}

fn constraints<'a> (px: Option<&'a u8>, py: &'a u8)
{
    loop  { }
}
```

the constraint-set cannot be solved under the new regime.  The constraints in question are: the implicit lifetime in `&x` needs to outlive the scope of `let p = ...`, the implicit lifetime in `&y` needs to be contained within the scope following `let y = ...;`, and both lifetimes need to be compatible with the `'a` in `fn constraints`.

The current solution adopted in the PR (effectively moving `let y = ...;` up above the `let p = ...;`) is fine.

A long-term option that we should investigate is: if we ever put in better variance handling for type parameters, then presumably the `p` binding can use one liftetime, and then when we pass it into the call to constraints, it can be restricted to the narrower sublifetime.


In addition, it might be more safe to release them opposite order like
```
for (int i = m_descendantWebCLObjects.size(); i >= 0; i--)
```
because later object might depend on earlier object.


> I wanted to use that a bit on our next lan, eh eh.

You didn't open an issue even if you've seen a bug you evil cheater !
Lucky me to have fixed that before you could accomplish your plan...


Programmatic node modules shouldn't `console.log`.


oops :D


boobs


如果你这样操作的话，应该是 rebase

```
git checkout refactor-test
git rebase master
```


`if` vs `it`


in c++11, we use ~WebCLImage() override if it's inherited class.


This is my first forking practice.


I'd rather not pass empty arrays. I will just try to document the support for the args somewhere. Can you remove the empty `callback_args` arrays?


I,m just wondering why you are compressing the CSV into a zipped archive ?
Doing so intentionaly disable git's hability to track changes inside the file.


This might be cleaner with sets.  You could turn it into something like:
```
(not (subset? required-user-keys (set params)))
```
which isn't any shorter but takes a little less of my brain to read.


Solves post a pre ordered equations


@antis81 - if you want to pretty up the examples a bit, a pull request would be most welcome!


@bors: retry


Hello World


This looks great.


ok : As it's often the case with such import error (cannot import name xxx) : it's because of a circular import :
```
/home/gstarck/.virtualenvs/shinken-py27/bin/python /home/gstarck/work/work/SFL/Supervision/shinken/shinken/macroresolver.py
Traceback (most recent call last):
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/macroresolver.py", line 38, in <module>
    from shinken.objects.item import Item
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/objects/__init__.py", line 33, in <module>
    from item import Item, Items
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/objects/item.py", line 41, in <module>
    from shinken.commandcall import CommandCall
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/commandcall.py", line 27, in <module>
    from shinken.property import StringProp, BoolProp, IntegerProp
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/property.py", line 28, in <module>
    from shinken.util import to_float, to_split, to_char, to_int, unique_value, list_split, strip_and_uniq
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/util.py", line 38, in <module>
    from shinken.macroresolver import MacroResolver
  File "/home/gstarck/work/work/SFL/Supervision/shinken/shinken/macroresolver.py", line 38, in <module>
    from shinken.objects.item import Item
ImportError: cannot import name Item
```

damn.. not always easy to correctly solve ..


maybe explain how the value is obtained?


I'd like to use `classes` as the callback arg for fieldsets and fields. Unfortunately, I can't attach anything to the `legend` because I didn't set it up right. Can we try this argument structure?

`
$contents['callback_args']['classes'] // Classes for field or fieldset
$contents['callback_args']['legend_classes'] // Classes for legend
`


#include "modules/webcl/WebCL.h"
ditto all


If this fixes it I'm baffled, because List extends Collection.


This file has inconsistent indentation because it started from a 3rd party project.


> You didn't open an issue even if you've seen a bug you evil cheater !
Lucky me to have fixed that before you could accomplish your plan...

Eh eh. :angel: :smile_cat: Again, this won't stand in a trial. :stuck_out_tongue_closed_eyes:

> If you see something that can be improved, please feel free to go, I won't feel offended if you fix my mistakes ;-)

Thanks. This is team spirit. :)


I don't think it's mandatory to place `result_callback` since you have placed documentation for it anyway. (`@yield [Boolean]`...)

If anything it looks redundant to have an assigned variable which is not used in our function.


Why do you add this include?

I think the include "motion.h" was included from "ParserPacket.h" and finally loaded from https://github.com/officinerobotiche/orblibcpp/blob/develop/include/PacketSerial.h#L20

This is correct inclusion file "motion.h"? @Myzhar


Maybe an expression form,  like `2 * 2**30 - 1` would be better in this case...


Only contact & sync use this. I think the string approach would work. We can do the join "\n" only in contact client and save all in one field if its modified from cozy-contact (and in the future we can change it for an optional 7 fields form / some kind of heuristic splitter).

I think not breaking data should be the priority here.
@jsilvestre, what do you think ?


Shouldn't this be disabled on the line itself? It occurs once.


do not know PDO semantic, sorry.


don't typedef. it's weird.


there is no `throws IllegalArgumentException` also the return is no `DateTime`


1: M111 unrecognized component name: authorids


WebCLKernelArgInfo::IMAGE is better


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10054/testReport/) for this commit**


Is there any fix here that has a significant impact on Felix-Plugin connectivity?  I'm afraid I'm not seeing it.


same as above


I know this is the code I told you to implement, but can we not print an empty class attribute? Also if we reverse the arguments we don't have to pass any empty string for slug for the legend.

```
function rtb_print_element_class( $classes, $slug = '' ) {

	$classes = empty( $classes ) ? array() : $additional_classes;

	if ( !empty( $slug ) ) {
		array_push( $classes, $slug );
	}

	return empty( $classes ) ? '' : 'class="' . join( ' ', $classes ) .'"';
}
```


I wasn't sure on it, so I closed the pull request, but its true ^^


javaDoc and method doesnt match


Everywhere you use `$additional_classes` can you just use `$classes`? Just a nitpick. :)


If you moved the view-model creation to a private function (e.g. ToModel(vote)), you could replace all this last section with a simple Linq statement, like:

var response = votes.Select(ToModel).ToList();


You're not the only one, I haven't used PDO until now.


Why did Scalr remove Eucalyptus support? Is Scalr deprecating Eucalyptus in future versions?


this one can be easily solved / "interrupted" (the circular import) :

In shinken/util.py :

remove (del) :
```from shinken.macroresolver import MacroResolver```
and also in the same file del :
```
# Will expand the value with macros from the
# host/service ref before brok it
def expand_with_macros(ref, value):
    return MacroResolver().resolve_simple_macros_in_string(value, ref.get_data_for_checks())
```

it's apparently not used anywhere so it's ok to remove that.  At least for a try ..

try continue with that.


What you said is correct. But not the problem in smaller versions to 21.
But enjoy your observation and made this process via code and even doing
the scan.

Thank you very much.

2015-01-15 12:06 GMT-03:00 Conradowatz <notifications@github.com>:

> I wasn't sure on it, so I closed the pull request, but its true ^^
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rudsonlive/NavigationDrawer-MaterialDesign/commit/cba194d7d98cdead14017eeee24cd09a84feff7f#commitcomment-9298466>
> .
>

--
*Rudson Lima ( live-O )* Desenvolvedor Android
*Contato* +55 85 87050560* - *Fortaleza-ce
*Google Play *CepLive-O e Navigation Drawer - Live-O
<https://play.google.com/store/apps/developer?id=Rudson+Lima>
*Social* facebook <https://www.facebook.com/rudsonlive> | google+
<http://google.com/+RudsonLima-O> | linkedin
<http://br.linkedin.com/in/rudsonlive/>


some tests failed:
failure: http://build.servo.org/builders/mac1/builds/755


Actually, I'd really prefer to go much simpler with this. Instead of wiring up a build-your-own-submit button thing where we can filter all the elements, let's just filter the output HTML. If someone wants to change it they can rewrite the button, since it's not a complicated element. Just something like this:

```
?>

<button etc></button>

<?php
$button = ob_get_clean();

return apply_fitler( 'rtb_booking_form_submit_button', $button );
```

Sorry, I should have made that clearer before you wired all this stuff up.


Hmm, I did not expose the hooks on purpose so you can't tamper with them once registered. The only way of interaction for a third party should be to register hooks IMHO.


Is it sufficient to check there are two of them? You could easily check you have the correct list of IDs, for example, by doing something like this:

CollectionAssert.AreEqual(new [] { 1, 2 }, responseVotes.Select(r => r.Id).ToArray());


Two things

1. We now send keepalives every 5 seconds to the plugin; that code was just AWOL before.
2. We now haven't got a broken timer that means we never time any connection out.

Both of those affect both ACL and plugin connections, so we can now spot failed connections reliably.

To make this more confusing, the code that Dave was running had the first bug, but not the second in it - so his behaviour was different.


could you answer my old question "is it safe to call OpenCL api in another thread?"


I think so too. Will pick this up and merge it (unless @rogeliog gets there first).


Oh I see you handled the issue or printing an empty class here. I like the addition of `$class_attr` and `sprintf` here. Can you add in a check so that an empty slug isn't added and then one-line the return?

```
return empty( $class_attr ) ? '' : return sprintf( 'class="%s%', $class_attr );
```


do you think it's ok to emit dom exception in another thread? I don't think so.


~~Object~~ String


~~Object~~ Function


This code doesn't even remotely exist anymore. The ground up rewrite buddha did doesn't have the bug. Is there a voodo way he can merge this into v0.3.6 and cut a v0.3.7 and NPM publish that even though it's long past that version? I guess that makes total sense, I've just never done it. That would be ideal!


Should be in the commit to serendipity-entryproperties.php. By placing a hidden type=password field, the browser fills the first one and leaves the rest alone :-)

> On 15.01.2015, at 15:45, Ian <notifications@github.com> wrote:
>
> ;-) Where/How did it do this?
>
> —
> Reply to this email directly or view it on GitHub.
>


Actually, for me it seems to break /help and /version.  But it fixes using the old command line style options.  I don't know what the proper fix for /help and /version is.  Presumably getting posix detection working on detecting those options.


Just default to using `path.join` for any path concatenation, much safer and you never fall into Windows fallacies.


I can just about code..... but I can't spell .. one bit!!!! Thanks Rosemary! Fixed with commit 28608286abd44c30f5aa02a7d709def3827cdd16


Yes inline makes sense. Thanks


could you answer my old question "is it safe to call OpenCL api in another thread?"

In OpenGL, it's super not-safe.


Should the object used in the callback use `status` or `result` as the property name or does it matter?


Тебе необходимо понять механизм функционирования `digest loop` в angularjs. А потом заодно и мне растолковать, как же он всё-таки, зараза, работает :)
А тут мне интуиция подсказывает, что присвоение значения `filter_status` надо вынести в метод контролллера, раз из шаблона не стреляет.
Как-то примерно так, за работоспособность не ручаюсь:
```javascript
...
$scope.setStatus = function(status) {
    this.filter_status = status;
};
...
```
и в шаблоне
```html
<a ... ng-click="setStatus('{{sample_status[$index].name}}')" ... ></a>
```


alright :)


you don't implement
```
INVALID_OPERATION -- if the blocking form of this function is called from a WebCLCallback
INVALID_VALUE -- if eventWaitList is empty
INVALID_CONTEXT -- if events specified in eventWaitList do not belong to the same context
INVALID_EVENT_WAIT_LIST -- if any event in eventWaitList is invalid
INVALID_EVENT_WAIT_LIST -- if a callback is not provided, and any event in eventWaitList is a WebCLUserEvent or a newly created (non-activated) WebCLEvent
EXEC_STATUS_ERROR_FOR_EVENTS_IN_WAIT_LIST -- if the execution status of any of the events in eventWaitList is a negative integer value
```


This connection stuff is throwing errors for me.

/Users/kelsey/projects/sports2/sports2/routes/index.js:15
  if (err) throw err;
                 ^
Error: connect ECONNREFUSED


That bug never made it to a release so I'm not sure the fix really needs mentioning in the CHANGES.


Here is some progress:
Exception -> string(225) "SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?=NOT ? WHERE pinID = ?' at line 1"

i checked the ($field == 1 ? 0 : 1) too, same type of error. Can't figure out why its happening


Whoops. Fixed with commit 0f896e806d35aafdcfd08818cef29c10e1df7ecf


who delete this callback pointer?


IMO it should be implemented in Blink thread. WebCLEvent already has callback mechanism. You need to implement observer to observe WebCLEvents. WebCLEvent should notify done message to the observer. When all events are completed, you can call the callback.


Well ,,, yes. I have read the commit, but my question was more about where you experienced such(what) an issue...?


There was already a mechanism for default eps. Is there a good reason to duplicate it and include magic numbers?


var names should end with an 's' if they have a plural cardinality.


How come there are two entries for ``StartArguments``? same for ``WorkingDir`` 5 lines below


Know it's problem few hours ago ... As I wrote .. but do not know solution for PDO ...

Have in mind that you are trying to add additional abstraction layer over mySQL try to print out the resulting query something what is really sent to mySQL from PDO


whenFinished can be destructed before another thread call it.


same here $value-label -> $value-labels


standard label should be the first, no?


this is a issue with merge of XML files.
Pelase fix by deleting duplicates


Maybe DRY this out?


Their is a strchr() on line 257 that could result in p being NULL.


OpenCL has mechanism to register finish callback to command queue. use it, instead of incorrect thread implementation. I don't think it's safe to call OpenCL api in another thread.


Good idea. Added.


I think it's a style choice personally, seems it's done in Rails as well, https://github.com/rails/rails/blob/2750cc41484266c731c4bf0460d74b0de49e7450/actionpack/lib/action_controller/caching.rb#L81.  I would tend to agree though that it's odd to declare a variable unless it's used, and I prefer the callback to be defined in the method definition, so perhaps we should get rid of the yields generally unless a block variable is not defined. WDYT?


I actually like this code slightly better than the version that compares to 100, below, because it doesn't have to do a store to reset the counter. Note that you could compare to zero instead of to 0x5F and I think that would save an instruction, though I kind of doubt the resulting performance improvement would be measurable.


yes! OpenCL has already callback mechanism. Don't use thread.


Does this need to inherit ActiveRecord if all it's being used for are validations?


@opoplawski @akallabeth is currently working on a complete fix of this.
And I'm trying to create/extend some tests with proper cases we can use.


I'm not sure about silently accepting invalid specifiers here.
Alternative is calling span_help() and span_fatal(), but I didn't want to duplicate error messages from parse_nt.


this function is called only by clBuildProgram.
So it's called in Blink thread always.
add ASSERT(isMainThread())


When I was writing the code for this, it wasn't supposed to matter whether optional parameters were supposed to be in the message body or as ?options on the URL. Can you show me some examples that aren't working for you?


I agree with the conclusion.

As for Rails your example is flawed because `block` is in fact used in the function :): https://github.com/rails/rails/blob/2750cc41484266c731c4bf0460d74b0de49e7450/actionpack/lib/action_controller/caching.rb#L83


hi! just an idea:
make the view menu work more like the navigation and the zoom menus,
i.e. let the button say "Window", "Presentation", or "Full Screen"
depending on the current mode of operation.
in presentation mode, the items "continuous", "dual page", and "side pane" could imho be grayed out or not be present at all.


I guess now you want a float compare that doesn't forward to dune-common?


There's a way to build a tableless model without creating a table http://railscasts.com/episodes/193-tableless-model


Typos: 'Wehn', 'ondes'


Good question! It's been a while... :) The code added in this commit is more or less exactly the `float_cmp` code from pyMOR (without a proper comment or citation, of course), hence the magic numbers. The motivation for this was that the current `FloatCmp` mechanism in dune-common has fialed us severely over the years and subsequently our variant for vectors also fails.

I agree that having them side-by-side is not a clean thing. I would thus propose to postpone this into its onw issue (since I am really not sure how to deal with this) and leave it as it is. If it is only the magic number that you want to get rid of I could temporarily use the epsilon from dune-common, but this would not really solve the overall problem.


Yes, I will use concat, and change the second var to configModules.


Please release this


Yup, main motivation, s.a.


@smarquespt It can be applied to non moving things as well.
What's your opinion about: "Desvio da margem esquerda da sombra" ?


Feel free to change around. In your version, I was getting and then fixing an error in case no hooks were present.


yes


Did you install the package `libmarkdown-devel`?


With a linear search it's about the same speed. I get a speedup by hard-coding the comparison like this:

```nim
  return (c >= 0x0300 and c <= 0x036f) or
    (c >= 0x1ab0 and c <= 0x1aff) or
    (c >= 0x1dc0 and c <= 0x1dff) or
    (c >= 0x20d0 and c <= 0x20ff) or
    (c >= 0xfe20 and c <= 0xfe2f)
```
Do we want this or do you have anything better in mind?


I feel bad mentioning this to you - because you are following the style you need in the other parts.

On the other hand, I love that syntax, it's probably saved me a thousand lines of code over the years- I can often get rid of the `{}` too.


Yep, now it's working with your modifications.


you need to use the second argument to escape the ``/`` separator too


Thanks, fixed.


Needs to be documented


Hey Timo,
This change gave many problems with my larger and more complex models. In my version I have set it back to 5000, but I think 2000 would be good enough for most of my models. Could this value be set a bit higher again?


return std::vector< K >(this->begin(),  this->end()); ??


For this g_file_get_child() is better.


`update` 和 `save` 可访问性，想了一下是不是应该为 `@public` 更合适？


Ah! It's an issue with Chrome only.

It fills the logon password to the s9y backend into the entryproperties form for password protected entries. Everytime I edit or create an entry on blog.s9y.org it would make the blog article protected.

> On 15.01.2015, at 16:22, Ian <notifications@github.com> wrote:
>
> Well ,,, yes. I have read the commit, but my question was more about where you experienced such(what) an issue...?
>
> —
> Reply to this email directly or view it on GitHub.
>


Indentation is not right here.


some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3155
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3140
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3140
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3143
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3136
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3130
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2808
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2806
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1644
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1637


This file was updated with the wrong class. DO NOT USE THIS CLASS UPDATE!


which of the three solvers is it?


@WanWizard ?


`@abstract` 抽象方法声明还需要么？


@stof good point, but I'll create a new issue for that.


I was searching for the error but wasn't able to find. :+1:


If you declare child inside this block you could avoid the clear.


Internally, we've been calling anything non-SWORD our "Native API" but we aren't really going to call it this in our official docs, are we?

For guidance on naming I would suggest looking at the [spreadsheet](https://docs.google.com/a/harvard.edu/spreadsheets/d/12yN3otyqXPQ4uM_iYife7xSwr1PdtoZzazanDgBDqCI/edit?usp=sharing) we worked on with @mcrosas during a [2014-11-04 Dataverse 4.0 API meeting](https://docs.google.com/a/harvard.edu/document/d/1GOAc0dIDcVohmAbOZ-Ejem1Ng8gpZcdMXUM7QLsbQRU/edit?usp=sharing).

In that meeting, we decided to change the name of the Data Deposit API to the SWORD API, for example.

Here's the main ticket for documenting APIs: #915

/cc @eaquigley @posixeleni @scolapasta @michbarsinai


You can remove this check, I think this method will always be called with a valid project_id (button clicked). Unless you can find a case where it wouldn't be called correctly...


r+ rollup


I have a thought, is it possible to pass Ref_ID or some Ref Key with the Token? Such as I pass the Token to gcm with user ID, and the call back will include the user ID or Ref_ID. Then I can handle it using user ID / Ref ID to process something...


nobody uses them. Why you implement them?


Created http://www.doctrine-project.org/jira/browse/DCOM-266


@bors: retry
* #3887
* #3228


Nobody uses it. Why implement it?


saw approval from christophermancini
at https://github.com/basho/riak-ruby-client/commit/1c8baef84eb25f0560128a11fa5a86cc9151eb95


merging basho/riak-ruby-client/bk-j70-yz-objects = 1c8baef8 into borshop-integration-201-bk-j70-yz-objects


basho/riak-ruby-client/bk-j70-yz-objects = 1c8baef8 merged ok, testing candidate = e583f0e8


You can DRY to much :) I would agree if it was done a few times but it's only done twice in that file.


True, though the path of least surprise is best IMHO.


Feel free ;PppPp. I don't have time to dive into that huge readme.md right now.


now = time.time() also should go to _execute()


saw approval from jdm
at https://github.com/ebalint/servo/commit/1d91e9000c721ac55f34c194b87f34955be08178


merging ebalint/servo/canvas = 1d91e900 into auto


ebalint/servo/canvas = 1d91e900 merged ok, testing candidate = d9d7fdf7


Sample,

```
gcm:push(RegisteredName, Reference, RegIds, Payload)
```
And the callback (err fun) include the Reference


Looks good to me.


if (D > radius1 + radius2)))


r+


We're currently doing qthread_yield() calls in both chpl_sync_lock() and chpl_sync_unlock() without seeing any problems, so at least for now doing a qthread_yield() should be fine.


It had to do with the BlockSchurPreconditioner, so I have set those two higher. I could test it again to see if it is just one of those two?


g_file_get_child here too


We need to talk about the best way to implement this stuff


saw approval from steveklabnik
at https://github.com/icorderi/rust/commit/ab24ffe21a742287ee12d5992d4c90e83abb374d


merging 49 batched pull requests into batch


This all needs linking up somewhere, wasn't sure how to do it


You need to update the example in the docs too


These definitions should not be inline anyway.


Good question :smiley: By looking at the source, I'm guessing, it could be rephrased to: "Clear......"
@PCMan Can you help ?


IMHO it's better to replace `yield` with `block.call`.


status: {"merge_sha": "953e4158b096a44c1bcd0ea3ce4628a8e6c6e987", "rollup_pulls": [[19353, "ab24ffe21a742287ee12d5992d4c90e83abb374d"], [20463, "9f5fc563d3d592d5e44ab71759ffa26d326b3daa"], [20632, "4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d"], [20892, "9302dc5d9e13f716a21a5d9ebdcddc149a864b19"], [20929, "eabf2082856668c75ed6f7c229b24fb7755440bc"], [20964, "78b7e13bf02e59ad05a9d15725e3c36e9dcf7187"], [20976, "415fc5f0f10b6180193ecd309b21ae80a1efa6a9"], [20985, "11737a3e1d5080c10f1ca366a12cf8fed7941d49"], [20986, "a3d87fa448de23d9d2faaf6f68803e5925653244"], [20988, "8eba032f52a0b16b39a94267b4884f361e022c36"], [21001, "e1ff480e433697ae546e2cedebf659dc1b19572f"], [21005, "933303413e4fe97dbfd7e7f0a6f26dfb077696e8"], [21011, "ba9e223c57de82fbdb4da1446de570e028477aec"], [21013, "c403794310814d2d83e80f2f10308195505b48be"], [21014, "285277dd804e8e380dde764a00c97a721b4ef976"], [21015, "be407180d726f0121ccce9a7439f14de1731435c"], [21020, "e485d297ea6e882725c3d5b510183a3f8d816530"], [21023, "95f9e309f7307ace9218307f943f29662e21a1e5"], [21028, "425f449fdacb72f98a3e7c4326997b09b9b9a127"], [21029, "b704983ee925dff219ecc5b8e7dd2ba9fec64c1f"], [21031, "db7de969cfb50587475185e25bd09b7e73cafe83"], [21036, "d6e67e938bfce049432b3084787c055911b76f5c"], [21038, "2297b0cb0028965a2ef1d6a5de3d4c2dbe172825"], [21040, "16a8c4d2382d72aa414d89192422187acd290270"], [21041, "462dd647163195bbe4736c933588af3907ac6a38"], [21046, "599232503a7959faafa21bc8b38ca98f4b28e536"], [21054, "71884601f955c67b055fad8351074eae4f849769"], [21059, "6a7f0a99d8005187736c3c26c5cc2d538a42590f"], [21066, "323abc0eb0e99d445a38aa4fc0da93f5791ff492"], [21071, "9af8a646a964985fe42a91ea34672266c91ae295"], [21075, "31ac1fb93df9b9a2db332f055052dbfb779bdf91"], [21103, "1217007c8335ec2b3097583ff3e0ad15a35af26e"], [21105, "07f723f19bdf1054d140fc713f72f04a2f1b4258"], [21109, "ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1"], [21110, "806c13589a319292849443d4b8ad44d2edc78cbf"], [21120, "6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1"], [21124, "40219249cf87585023e0d1b44de261dd56752142"], [21126, "fb556288737ececbc12b177b45a0717ff4dd5b66"], [21133, "5a16ceb291fd1b021efc342e3058c0f1ce534778"], [21141, "428da78de10310744a33b5e5b7d85e1a11e8e7ed"], [21148, "bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc"], [21164, "5e646755f4c5fc7ccdbb6b40d61010f2b1c25fe5"], [21168, "e6f7f23a6f0258a07bc6e20f6603743f7c334870"], [21169, "9002fdbc500ec63ed183eee714e9ca27ef5c8995"], [21172, "e5ad89d176004931d7ffbf87e7c23bc71fc7418a"], [21190, "f99d43ecc0d043350d38e44b86f33900a8391491"], [21191, "2c71adaaa21e5d9e4fe80625e41982ac83303df8"]]}


Testing rollup candidate = 953e415

**Successful merges:**

- #19353 Add full Rust language grammar definition to docs (icorderi/docs/grammar = ab24ffe21a742287ee12d5992d4c90e83abb374d)
- #20463 [r+] Return passed value from black_box (amaranth/black_box_output = 9f5fc563d3d592d5e44ab71759ffa26d326b3daa)
- #20632 Replace usage of deriving with derive in docs (gchp/reference = 4b14f67df3c28cd1cd8ea5bf794a3e542c663d8d)
- #20892 Replace uint with u32 in trpl/guessing-game.md (CarVac/master = 9302dc5d9e13f716a21a5d9ebdcddc149a864b19)
- #20929 Ease parsing of an English sentence (laurilehmijoki/master = eabf2082856668c75ed6f7c229b24fb7755440bc)
- #20964 Fix attr syntax in recursion limit diagnostic (sfackler/recursion-syntax = 78b7e13bf02e59ad05a9d15725e3c36e9dcf7187)
- #20976 Remove unused import. (jbcrail/rm-unused-import = 415fc5f0f10b6180193ecd309b21ae80a1efa6a9)
- #20985 iOS: fixed install phase (vhbit/ios-install = 11737a3e1d5080c10f1ca366a12cf8fed7941d49)
- #20986 [r+] Doc fixes (alkor/doc-fixes = a3d87fa448de23d9d2faaf6f68803e5925653244)
- #20988 Purge references to Rust tasks from TRPL. (ciphergoth/task-to-thread = 8eba032f52a0b16b39a94267b4884f361e022c36)
- #21001 Remove usage and reference of feature(globs) from the book (camjackson/master = e1ff480e433697ae546e2cedebf659dc1b19572f)
- #21005 Update #[deriving] documentation. (huonw/deriving-docs = 933303413e4fe97dbfd7e7f0a6f26dfb077696e8)
- #21011 Small grammar fix in the book (steveklabnik/gh20993 = ba9e223c57de82fbdb4da1446de570e028477aec)
- #21013 Small fix in the book (steveklabnik/gh20914 = c403794310814d2d83e80f2f10308195505b48be)
- #21014 Clean up unary operators in the reference (steveklabnik/gh20876 = 285277dd804e8e380dde764a00c97a721b4ef976)
- #21015 Link to sections in the book's README.md (steveklabnik/gh20852 = be407180d726f0121ccce9a7439f14de1731435c)
- #21020 Improve example in the intro. (steveklabnik/gh20844 = e485d297ea6e882725c3d5b510183a3f8d816530)
- #21023 Clean up wording around uninitialized values. (steveklabnik/gh20840 = 95f9e309f7307ace9218307f943f29662e21a1e5)
- #21028 Remove PDF link on 404 page (steveklabnik/gh17368 = 425f449fdacb72f98a3e7c4326997b09b9b9a127)
- #21029 [r+] Improve the ownership guide a tad (steveklabnik/gh19924 = b704983ee925dff219ecc5b8e7dd2ba9fec64c1f)
- #21031 Improve clarity of paragraph in the pointer guide (steveklabnik/gh19067 = db7de969cfb50587475185e25bd09b7e73cafe83)
- #21036 Vec's IntoIter should be Send/Sync when Vec is (renato-zannon/into-iter-impls = d6e67e938bfce049432b3084787c055911b76f5c)
- #21038 Elaborate on destructuring let (steveklabnik/gh20471 = 2297b0cb0028965a2ef1d6a5de3d4c2dbe172825)
- #21040 Don't use 'synonym' with regards to newtypes (steveklabnik/gh20037 = 16a8c4d2382d72aa414d89192422187acd290270)
- #21041 Add explanation of main to rustdoc docs (steveklabnik/gh17554 = 462dd647163195bbe4736c933588af3907ac6a38)
- #21046 [r+] Windows building fixes (steveklabnik/gh16654 = 599232503a7959faafa21bc8b38ca98f4b28e536)
- #21054 Remove dead link from make tips (steveklabnik/gh17950 = 71884601f955c67b055fad8351074eae4f849769)
- #21059 Add note about TLS lookups in random() (steveklabnik/gh16072 = 6a7f0a99d8005187736c3c26c5cc2d538a42590f)
- #21066 add test for issue #20575 (japaric/issue-20575 = 323abc0eb0e99d445a38aa4fc0da93f5791ff492)
- #21071 make the book more mobile friendly (sfaxon/mobile-friendly-book = 9af8a646a964985fe42a91ea34672266c91ae295)
- #21075 Various changes to Rust Introduction (iKevinY/intro-changes = 31ac1fb93df9b9a2db332f055052dbfb779bdf91)
- #21103 [r+] Fix a typo and use if-let instead of match in std::result docs (nagisa/result-typo = 1217007c8335ec2b3097583ff3e0ad15a35af26e)
- #21105 Remove unneeded box import in examples (csouth3/kill-box-import = 07f723f19bdf1054d140fc713f72f04a2f1b4258)
- #21109 Provide example of generic inverse() (steveklabnik/gh17224 = ad0ce88c6cceec7a5cc3efc91b9447b05fd578a1)
- #21110 [r+] Updating email address for Rohit Joshi (rohitjoshi/patch-1 = 806c13589a319292849443d4b8ad44d2edc78cbf)
- #21120 [r+] Issue model lexer questionmark (fhahn/issue-model-lexer-questionmark = 6cfbcca41e259ddf93fb86a54e8d5f5bbcd3e6f1)
- #21124 [r+] Re-direct to the right place. (steveklabnik/fix_redirect = 40219249cf87585023e0d1b44de261dd56752142)
- #21126 Dlist examples (sleepynate/dlist-examples = fb556288737ececbc12b177b45a0717ff4dd5b66)
- #21133 Improve Rust Documentation & Reference on mobile (iKevinY/mobile-rustdoc = 5a16ceb291fd1b021efc342e3058c0f1ce534778)
- #21141 [r+] TRPL: Anti-example failing for the wrong reason. (tcard/master = 428da78de10310744a33b5e5b7d85e1a11e8e7ed)
- #21148 fix wrong link (bombless/patch-1 = bf899e997e8aa3bf806f7cf0cf2a5e714ff705cc)
- #21164 doc: fix links to servo (richo/doc/servo-link = 5e646755f4c5fc7ccdbb6b40d61010f2b1c25fe5)
- #21168 Doc tweak: explicitly state that vector contents are on the heap (aidanhs/aphs-doc-vec-heap = e6f7f23a6f0258a07bc6e20f6603743f7c334870)
- #21169 Make link to style guide direct in CONTRIBUTING.md (aidanhs/aphs-contributing-style-link = 9002fdbc500ec63ed183eee714e9ca27ef5c8995)
- #21172 Remove erroneous stability attribute. (brson/tuple = e5ad89d176004931d7ffbf87e7c23bc71fc7418a)
- #21190 [r+] remove try_node_id_to_type in favor of node_id_to_type_opt (FlaPer87/remove_duplicated_func = f99d43ecc0d043350d38e44b86f33900a8391491)
- #21191 Disable -C lto optimizations on opt_level=0 (Zoxc/lto = 2c71adaaa21e5d9e4fe80625e41982ac83303df8)

**Failed merges:**

- #20998 s/deriving/derives in Comments/Docs (estsauver/20984 = 7e472ef163f414411f56b0258928c518253966b3)
- #21185 Update of the the Rust Reference so that it mentions isize/usize instead of int/uint (ctrompette/reference-int = 4a5edb8b53a41ca70193ce37b55e04baa2031677)


TeamCity Bij12 Voorgangsrapportage Natuur - LCV :: CDS BIJ12 :: Build [Build 2.3-SNAPSHOT-81-c6556f716041e8dfd8daebb4e46c772e6a1b42f4](http://buildserver.geodan.nl/teamcity/viewLog.html?buildId=74221&buildTypeId=vrn_CdsBij12_Build) outcome was **SUCCESS**
Summary: Tests passed: 58 Build time: 00:03:01


You'll need to re-base on develop as this was recently updated (to handle both logged-in users and anonymous users). But should fit your helper well!


How about to store this controls in 2-dimentional array. It will be easy to iterate by 2-dimentional index for check and read values. Or create mapping EditText[3][3] to Double[3][3] array


@jdorweiler awesome, thanks a lot for this.

Can you please remove that space at the end? It just looks bad =)


Oh yes, now that you say this, I remember this too. We have even discussed this somewhere. Well done!


Can we add some documentation here with the link to the issue we filed on Marmotta? If this is fixed I'd like us to know that we should clean this up later.


r=nikomatsakis p=1


nobody uses ImageBufferCache


var active = (leByte == 0x01 || leByte == 0x02 || leByte == 0x03 || leByte == 0x04);


Based on:
http://stackoverflow.com/questions/13876165/how-to-override-maven-property-in-command-line


I'd add a separate function which computes and returns a new maxDist for readability.


Hi @scalpel4k! Thanks for reporting this and for your interest in LLVM software.

Unfortunately, this isn't where such issues should be reported, it's just a mirror provided for convenience to the community.

The appropriate place for such things is the LLVM Bugzilla: http://llvm.org/bugs/, or on the mailing lists.

Please report your issues there so they will be seen and handled!


if (Active)


Right... Why did I do that... I think I forgot to finish it.

I believe the goal was to plot tracking data on the map that matches the data shown on the year calendar heatmap. The year calendar heatmap shows the last X months of tracking data, where X is calculated based on the width of the screen. For drawing the year calendar, the cartodb API is queried, and when the data returns, everything is calculated and the heatmap is drawn.
For the map, you need a separate call to the cartodb API (actually it's not to the API, but via the cartodbjs). It would be silly though to wait for the API call that is needed for the year heatmap before being able to send a request for the map data. But the only way to achieve that is to make sure that both the year-heatmap drawing function and the map drawing function now in advance which date range they will need to display. For that, they both need that X I was talking about before (which can be calculated without any data because it solely depends on the width of the element) and the last date_time the bird was tracked.

But I didn't get to implementing the whole concept yet.


Good catch; the inline docs say `result`, and I believe it's that way in other drivers and in the core medic-transport code.


r=nikomatsakis rollup


done


<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" />


I'm really curious if Twilio or SMSSync have a partial failure mode for messages > 160 characters (GSM 7-bit) or 70 characters (UCS-2/UTF-16). It can happen, protocol-wise.


No -- it's the slicers, so the verbose label is preferred here.


Should be "Fixed #46"


-<?xml version="1.0" encoding="utf-8"?>


-</configuration>


Makes sense now that I understand that you mean the Docker plugin!


if you use `fs.exist` here, we wouldn't need to use `process.nextTick`


<TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>


about this comment :
> Indeed but I was trying to keep some consistency with the rest of the function which already silent the error.

The fact that some error are already made (more or less) silent by such return with an arbitrary value is simply bad.
Simply don't mimic such behavior and try to do the right thing directly : raise an explicit exception which will (normally otherwise it will have to) be caught somewhere upfront..


TeamCity Bij12 Voorgangsrapportage Natuur - LCV :: CDS BIJ12 :: Build [Build 2.3-SNAPSHOT-82-733df838c11c752654dc4061aadf882f00bf74b4](http://buildserver.geodan.nl/teamcity/viewLog.html?buildId=74223&buildTypeId=vrn_CdsBij12_Build) outcome was **SUCCESS**
Summary: Tests passed: 58 Build time: 00:01:52


good point.  will fix this.


Gracias  dacid sw antemano yo voy a probar cuamdo arregle el ordenador unas rooms de lollipop sw hace 2 dias a ver como van


LGTM


all tests pass:
success: http://buildbot.bos1/builders/ruby-client-test/builds/226


It's easier to see what was modified when the whitespace differences are ignored: https://github.com/gvas/grunt-saucelabs/commit/4d453fe7ad6a4e4835a5b43fe8552a183cd9cc53?w=1


LGTM, thanks


delete -


That's a bug, `properties` should be passed to `find` in the body.
A global grep shows that nobody actually uses `find!` with properties.


s/list/is/, presumably


Lazy swede https://github.com/sindresorhus/pageres/commit/72fb4649830ed0ea8a58be4a7d3bc12ba66be574


-        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.2" />


-<?xml version="1.0" encoding="utf-8"?>


add comment why WebCLObject is needed. it should include the relationship between javascript object and c++ object and how you release all objects before WebCL destruction.


custom tag 2.0으로 변환 필요


Vypadá to dobře :+1:

Asi bude potřeba upravit commit message, ale to ti už řeknou v rámci pull requestu.


-</configuration>


I don't think it needs to inherit ScriptWrappableBase


But then, this is not a *service* but a *target*, I'm not sure whether the API makes sense.


Again, pass to `find`.


don't we need to check OpenCL version?


An orphan heredoc marker?


libipnut 0.8.0 breaks weston build.  Patch is available, but not clear how compatible the rest is.
http://lists.freedesktop.org/archives/wayland-devel/2015-January/019365.html
Wait with uploading libinput 0.8.0 until weston 1.6.1, scheduled Jan 26


Não gostei. kkk zua


return true or false


Why in enderio? Why not enderzoo?


다른 곳에서 `contributors`를 다른 용도로 쓸 수도 있는데 `ordered_contributors`를 위해서 `uniq`를 빼는 게 좋은 선택일까?


1. `self`는 없어도 됨
2. 공백문자


Prefer `execFile` whenever you can as it's fast and safer. `execFile(nodePath, ['--v8-options'], func...`


return;


для чого тобі два скріпти окремі - calcRoute.js і /initMaps.js ? Можна їх об*єднати в один файл?


Early return here to reduce nesting.


Shouldn't this be [0, 1]?  Or am I misunderstanding range syntax?


You should probably delete `~/.cache/cabal2nix/tasty-ant-xml-1.0.1.sha256`; maybe the file got corrupted.


Comment says it is supposed to be thread local logger but it uses `__gshared`


The comment is IMHO an useful explanation why the parameter is unused.


Does it make sense to move the documentation out of the driver files and into one place? Maybe in the readme or only in abstract.js and then in the driver files only document special things related to that driver?


I have no issues in merging this into master (untested by myself, I dont use gentoo)
It is not core/critical, if Patrik (p3root) also using gentoo doesn't have any issue: just go ahead:


Could some license experts check this term?
2015


на вид лучше, но зато теперь не работает - первое попавшееся значение массива вставляет.


Please reindent and submit to deal.II -- I'm not sure how well higher order mappings are tested.


maybe we should use a `while-loop` here since we will loop this an unknown number of times until the date is parsed


Good question, I think you are right and I will add "requirejs-domready/domReady!" to the first one.


Remote-tracking branch 'origin/master' from Canop


I prefer `spawn`, why `execFile`?


Yeah, I think we can put generic API inline docs in abstract.js and not copy/paste it in to every subclass. That'd leave room for driver-specific inline docs in the subclasses.


\Desktop\Some Things\LPerm\LeagueSharp\System\LeagueSharp.dll


Reviewed PR and looks good.


The idris expression evaluates in a package set where `doCheck` is always false -- for all its build inputs. Settings that apply to Idris only are in the section below.


This part may need more extended documentation in general to explain what each bit is used for and how it affects user code. I am not sure about it, for example, despite the fact I have actually proposed this change :)


I was going to write it at the wrong place anyway.


I feel like sending "ts" by default would be right, if it wasn't set...

```
python
post_data.setdefault('ts', time.time())
```


I seriously hope this works...


SetAttack


maybe declare these as final since they will not change during runtime


Because the problem exists in EnderIO that this is meant to fix?


Ha yes, I put a semicolon where I should have put a colon, good catch.


headers h <- wyglada jak jakaś biblioteka z C :D


@phated It is spawn, just with a nicer interface when you only care about the output of a short-running process: https://github.com/joyent/node/blob/cfcb1de130867197cbc9c6012b7e84e08e53d032/lib/child_process.js#L670


This looks like an obvious bug fix, but it may break code that depends on the bug.


Probably doesn't matter, but shouldn't the `upload-dir` be a bit more generic here now that we've made the change to `all-branches`?


Looks good except for a couple of things.  The purpose of using a Stream instead of Byte[] is so that large files won't use very much memory.  For example, if you are running on a 32bit IIS server, you will get an OutOfMemory after the user views or uploads Videos if a large file ever is stored in bytes[] vs a stream.  Even if the files are only 5MB, the OutOfMemory will still happen due to Memory Fragmentation.  The Non-Stream solution would require that we only support 64bit AND that we do a forced Garbage Collection any time that a large file ends up getting assigned or removed from a byte[].


**error:** comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]

```
    for (int i = 0; i < deck.size(); i++)
                    ~ ^ ~~~~~~~~~~~
```


Both. These tests are the cause of the randomly failing core test. The rest of the commit ensures that the failure became deterministic on every run. There is no functional change in this commit.


Cool, never looked into `execFile`, just always see it listed as a safer alternative to `exec`


may this also be done when the exception is thrown?


It wasn't an bulkiness issue, it was to allow people to have incompatible "Map" implementations (we had one case internally).  Regardless the effect is the same.  Sorry about that for some reason I that we were using a wild card for the exports from that directory.


@jacknagel Fixed, this was a stupid local setup issue.


I don't think these are CLIs per se, simple examples to do pub/sub. I should add request/reply and queuing as well, although I think the sub example has an option for a queue group.


**error:** comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]

```
    if (x <=deck.size())
        ~ ^ ~~~~~~~~~~~
```


I would prefer it to fail if both are supplied, prevents shooting in foot.


Then probably the dateString has already changed.


Could clarify local path versus s3 path


I need still need to work over the "Beta" function, I cannot get it to work with Github's API :/


Not really necessary, it's only a local variable. Otherwise the code would be flooded with final keywords.


co tu się dzieje?


Would it be better to create a separate repo that has nats cli and also combines pub/sub? Having a single binary for nats would be useful for testing/debugging


With a while loop you have to manage the stop condition yourself and that's absolutely not desired. It's perfectly common to return early from a for loop.


Oh, this has been bugging me ever since I first added `register_receive_handler`... anyone see any distinct advantage to moving that over to the more traditional Node.js events framework?


co tu się dzieje? jeżeli wynik jest NaN to go zwróć?


and insert into


rax retry tests


first implementation of design of web based administration panel


@charroch Good spot, though shouldn't it be `list?.statements?.length`?


del.20 add 30


Sure. If you include ?hgvs=1, you don't get any hgvs's in the returned json.


Good point. There are many instances of that sort of thing that need to be fixed. There's also a [file path -> relative URL conversion](https://github.com/jeffposnick/sw-precache/blob/master/sw-precache.js#L78) that assumes `path.sep` is `/` and that will break if it's not.

I'll address that all in one go.


So... I'm thinking this should be a full namespace, rather than just a boolean up/down. I think we want something closer to `driver.set_state('available', true);`; that'd let us reuse the interface for other stuff, sort of as a generic way to notify drivers of state changes they may (or may not) be interested in, without adding tons of new methods for each state change type.


love it!  thanks @browningeric


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10056/testReport/) for this commit**


But... no code seems to use this module. It was added by @jsrain in 053a8f479671421b717e5bf7e92fe1ba5ee337a3 and according to http://lists.opensuse.org/opensuse-factory/2008-11/msg00789.html it did not catch on.


Weird typo, nice spot @xu-cheng.


Aside: tests! Hooray!


LICENSE and README.md should probably be added for each of the submodules before merging into master.


Good to see you know what you're doing because I've no idea what this is about ;)


I think the actual content LGTM (modulo minor comment). One organizational nit, and I'm happy to be struck down .. right now the files are a mix of utility files (`util.go`) and tests (`podupdate.go`). I think a developer in here would appreciate some split between those to lower the cognitive load when glancing through files. Maybe a separate directory, like `test/podupdate.go` (not sure how well that plays with the package)?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/539
success: http://build.servo.org/builders/linux2/builds/537
success: http://build.servo.org/builders/android/builds/575
success: http://build.servo.org/builders/mac1/builds/756
success: http://build.servo.org/builders/mac2/builds/756


It's good that you thought of unoccupied sync too. Though it wasn't actually used in the newest s0beit it definitely could've been.


IIS :) ? are you planning to migrate everything to Windows


$ git tag -a v2.0 -m 'version two with 2 player'


Cool.  Medium term, let's also think about whether the "applications" / "deployment" split makes sense to preserve internally or if it's just baggage from the config-file based system we're migrating from.


чому в цьому класі нема equals / hashcode?


I'm suddenly getting method-ambiguity warnings about this method vs. the one on the previous line.


Can we set `_e.message` here, and use that instead of an additional argument?


Чому в цьому класі нема equals/hashcode?


其他库也依赖了 co？


What if another unrelated plugin sends a header? Won't this never get sent?


the cheat sends (float)0xFFFFFFFFFFFFFFFF as train speed while in a car and it causes clients to crash. It did work when I tested it. I figured this was a pretty arbitrary number, and just any really high value would crash people. Does the hydra angle only change when actually in hydra?


I am just curious - what is this empty `A` file about? :)


fast-forwarding master to auto = d9d7fdf7


Ah, thanks - I wasn't sure where this cache lived. It is indeed cached as `nil`. I'll `rm` that.


Can you make this relative?


AFAIK, Kibana 4 does run through its own port `5601`, so I just noticed that this httpauth is no longer effective to protect the analytics panel (before it ran through port `80` via nginx) :-S


TeamCity Bij12 Voorgangsrapportage Natuur - LCV :: CDS BIJ12 :: Build [Build 2.3-SNAPSHOT-83-d4e0bf0d18a7e6ff8d6b2749cf7f49b94038587a](http://buildserver.geodan.nl/teamcity/viewLog.html?buildId=74227&buildTypeId=vrn_CdsBij12_Build) outcome was **SUCCESS**
Summary: Tests passed: 61 Build time: 00:02:20


@pmuchowski do you mind explaining to me a bit about the reason for this change? :)


But this may omit some side effects that other code depends on. I would keep this in and just drop the return value.


I'm guessing the "hydra angle" is also used for vehicles with movable parts.


Ignore my previous message here; your commit is right.


I suppose I'd make an excellent cheat maker!


I know this file is still around for some issuers, but you should take it out ;). It is not necessary.


@Lyr3x does this make sense? Seems to me like a good solution. your opinion?


so good!


Thanks!

Could you by chance resubmit with a signed-off-by so that I can apply?


Oh, and for this https://github.com/jeffposnick/sw-precache/blob/00c2b0bc7ab785cae7446b3a166e83435c644f02/sw-precache.js#L43-L53 see [`pretty-bytes`](https://github.com/sindresorhus/pretty-bytes).


@luacs1998 could you give me a yay or nay on whether the current functionality is satisfactory for your use-case or whether something different/more is required to achieve your goals?


Thank you: fixed.


so this is the zen mode. wondrous:)


@MikeN123 maybe its some mimimi :stuck_out_tongue_winking_eye: Just putting my two cents.


@jacknagel In case you're interested: https://github.com/mikemcquaid/dotfiles/commit/86f3ea605fcb02674a4d4de307f871aa76ab70c9


Thanks for the pull request.  The problem is that there are whitespace changes everywhere so I can't tell what actually changed.  Can you make a pull that has just the changes w/o reformatting?


If you are using an external package, you should include a readme, and some details on how to install.
Also there should be a requirements.txt someplace so others can just run `pip install -r requirements.txt` and get all the packages they need.

Check this out for details on it:
https://pip.pypa.io/en/latest/user_guide.html#id8

Might want to move everything to a sub folder.


@jishi Sorry for the late reply... I did some testing.  It worked pretty amazing, but had some issues.

FYI, I have 24 Sonos devices (including every type of Sonos product).  I also have the Sonos Windows App open when I did the testing so I could easily see what Sonos was doing.

Test #1: using Multiple Groups
(1 Group of 4 devices, 1 Group of 2 devices, 1 Group of 1 devices).  Each of these zones was playing Pandora.
All other zones playing no music or paused.

.... /sayall/Hello, dinner is ready

-Several second delay
-Played TTS over all speakers

Results: "1 Group of 4" only had 3 devices and did not go back to using Pandora.  "1 Group of 2" went back to using Pandora and resumed playing (but it was a different song).  "1 Group of 1" resumed playing Pandora (but it was playing a different song).

------------------

- Test #2: using No Groups
- 1 Group of 1 playing Pandora, 1 Group of 1 playing Pandora
All other zones playing no music or paused.

.... /sayall/Hello, dinner is ready

SUCCESS!

After 8 second delay, everything grouped and played TTS, and successfully ungrouped and began replaying Pandora (but it was a different song).

-----

Test #3: Same test again

- Approximately half of the rooms grouped (the other half did nothing)
- No TTS in any rooms

If I manually "Grouped All/Party Mode" in the Sonos Desktop app, it immediately plays the TTS and then automatically restores the devices to their original state after playing the TTS.

-------

Test #4: Same test again

- 22 of 24 devices grouped together
- No TTS in any rooms

Same as before... If I manually "Grouped All/Party Mode" in the Sonos Desktop app, it immediately plays the TTS and then automatically restores the devices to their original state after playing the TTS.

-------

Test #5: Same test again

SUCCESS!

After 15 second delay, everything grouped and played TTS, and successfully ungrouped and began replaying Pandora (but it was a different song).

-------

Test #6: Same test again, but this time using MP3 instead of Pandora

- 3 of 24 devices grouped together
- No TTS in any rooms

Same as before... If I manually "Grouped All/Party Mode" in the Sonos Desktop app, it immediately plays the TTS and then automatically restores the devices to their original state after playing the TTS.  Mp3 resumed playback exactly where it left off.

--------

Test #7: Repeat of Test #6

SUCCESS!

After 15 second delay (8 seconds to play TTS, 7 seconds to ungroup/resume), everything grouped and played TTS, and successfully ungrouped and began replaying Mp3 exactly where it left off.

--------

Test #8: Party Mode

- All zones Grouped

.... /sayall/Hello, dinner is ready

Immediately plays TTS, but then ungrouped every zone (instead of leaving it in Party Mode).

--------

Test #9: Repeat of Test #8

- All zones Grouped

.... /sayall/Hello, dinner is ready

Immediately plays TTS, and ungrouped 1 Zone (the rest were left as a group), no music resumed.

If I "regroup" everything in the Sonos Desktop software, the TTS immediately plays again.

--------

Test #10: Repeat of Test #8

- All zones Grouped

.... /sayall/Hello, dinner is ready

Immediately plays TTS, and ungrouped 3 Zone (the rest were left as a group), no music resumed.

If I "regroup" everything in the Sonos Desktop software, the TTS immediately plays again.

------

Observations:

1. It looks like it is having trouble "Grouping" reliably.

2. If the system is in "Party-Mode" originally, it doesn't want to resume to its normal state.

3. As expected, the more grouping/ungrouping that needs to be done, the longer the delay for the TTS (and resuming the music).

Not sure if this is possible, but perhaps a separate command to allow the option to play the TTS over each existing group might help.  Granted, the groups might not play the TTS in-sync.  But that shouldn't matter too much.

This would make the TTS immediate (and would eliminate grouping issues).

4. Music services like Pandora, will resume playing the "channel", but will not resume playback of the specific song after playing the TTS.  This is typical for Pandora, whenever you "navigate away" from it, you lose the song you were listening to.

------

FYI: When clicking on your PayPal donate button, PayPal gives an error:

Det gick inte att slutföra din senaste åtgärd:

Om du höll på att handla eller betala och överföra rekommenderar vi att du väntar minst en halvtimme och sedan kontrollerar om det finns någon bekräftelse på transaktionen, antingen på ditt PayPal-konto eller i din e-post.

Om du kom till den här sidan från en annan webbplats återgår du till den platsen (använd inte webbläsarens Tillbaka-knapp) och startar om aktiviteten.

Om du kom från PayPals webbplats klickar du på PayPal-logotypen i övre, vänstra hörnet och återgår till vår hemsida och startar om aktiviteten. Du kanske måste logga in igen.


I plan to write a `README.md` that explains how to write an end to end test and also explain some of the utility functions. I think we should point people to a representative test (e.g. basic) which I think for many people will be good enough to work out how to write their own test. Personally, I think it is fine to have `util.go` in the same directory (and so in the same package) as the test files. We could put it in `test/e2e./util` put I think this is over-organization and too much of a pain to use.

Note that I view this whole CL as a stepping stone towards an improved e2e test framework so things are likely to change anyway.


Should you expect performance improvements thes changes or is it only cosmetic / refactoring for futures evolutions ?
Thanks,
R.


moving the filter to use esperanto which my PR does, is likely the best solution.


1: M100 needs more reviewers
1: M101 signature is missing


does it make sense if we define this thread only once? (somewhere near the constructor)
and then on every refresh we re-submit the same instance.


36:1: F401 'CFG_XAPIAN_ENABLED' imported but unused
36:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
36:1: F401 'CFG_OAI_ID_FIELD' imported but unused
36:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
36:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
36:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
36:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
36:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
36:1: F401 'CFG_SCOAP3_SITE' imported but unused
36:1: F401 'CFG_BASE_URL' imported but unused
36:1: F401 'CFG_SITE_RECORD' imported but unused
36:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
36:1: F401 'CFG_INSPIRE_SITE' imported but unused
36:1: F401 'CFG_LOGDIR' imported but unused
36:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
36:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
36:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
36:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
36:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
36:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
36:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
36:1: F401 'CFG_SOLR_URL' imported but unused
36:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
36:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
37:6: E126 continuation line over-indented for hanging indent
76:1: F401 'get_most_popular_field_values' imported but unused
77:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
77:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
78:6: E126 continuation line over-indented for hanging indent
80:1: F401 'get_fieldvalues_alephseq_like' imported but unused
83:1: F401 'record_xml_output' imported but unused
83:1: F401 'create_record' imported but unused
84:1: F401 'rank_by_citations' imported but unused
84:1: F401 'get_bibrank_methods' imported but unused
89:1: F401 'register_page_view_event' imported but unused
89:1: F401 'calculate_reading_similarity_list' imported but unused
90:1: F401 'stem' imported but unused
91:1: F401 'BibIndexDefaultTokenizer' imported but unused
92:1: F401 'author_name_requires_phrase_search' imported but unused
92:1: F401 'get_field_tags' imported but unused
94:1: F401 'wash_index_term' imported but unused
94:1: F401 'wash_author_name' imported but unused
94:1: F401 'lower_index_term' imported but unused
95:1: F401 'CFG_BIBINDEX_SYNONYM_MATCH_TYPE' imported but unused
96:1: F401 'create_excel' imported but unused
96:1: F401 'get_output_format_content_type' imported but unused
96:1: F401 'format_record' imported but unused
96:1: F401 'format_records' imported but unused
97:1: F401 'create_download_history_graph_and_box' imported but unused
98:1: F401 'DataCacher' imported but unused
99:1: F401 'perform_external_collection_search' imported but unused
99:1: F401 'print_external_results_overview' imported but unused
101:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
101:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
104:1: F401 'get_detailed_page_tabs' imported but unused
104:1: F401 'get_detailed_page_tabs_counts' imported but unused
106:1: F401 'deserialize_via_marshal' imported but unused
106:1: F401 'DatabaseError' imported but unused
106:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
107:1: F401 'acc_authorize_action' imported but unused
109:1: F401 'encode_for_xml' imported but unused
109:1: F401 'wash_for_utf8' imported but unused
109:1: F401 'strip_accents' imported but unused
115:1: F401 'get_citedby_hitset' imported but unused
115:1: F401 'calculate_cited_by_list' imported but unused
115:1: F401 'get_refersto_hitset' imported but unused
115:1: F401 'get_records_with_num_cites' imported but unused
115:1: F401 'get_cited_by_list' imported but unused
115:1: F401 'get_citers_log' imported but unused
115:1: F401 'calculate_co_cited_with_list' imported but unused
115:1: F401 'get_refers_to_list' imported but unused
120:1: F401 'create_citation_history_graph_and_box' imported but unused
121:1: F401 'get_self_refers_to_list' imported but unused
121:1: F401 'get_self_cited_by' imported but unused
121:1: F401 'get_self_cited_by_list' imported but unused
122:55: E126 continuation line over-indented for hanging indent
125:1: F401 'wash_table_column_name' imported but unused
125:1: F401 'get_table_update_time' imported but unused
125:1: F401 'run_sql_with_limit' imported but unused
127:1: F401 'collect_user_info' imported but unused
128:1: F401 'pagefooteronly' imported but unused
128:1: F401 'create_error_box' imported but unused
128:1: F401 'write_warning' imported but unused
128:1: F401 'pageheaderonly' imported but unused
131:1: F401 'apache' imported but unused
133:1: F401 'do_calculate_hosted_collections_results' imported but unused
133:1: F401 'calculate_hosted_collections_results' imported but unused
134:1: F401 'CFG_EXTERNAL_COLLECTION_MAXRESULTS' imported but unused
136:1: F401 'BIBAUTHORID_LIMIT_TO_COLLECTIONS' imported but unused
141:22: E203 whitespace before ':'
141:14: E225 missing whitespace around operator
142:24: E203 whitespace before ':'
143:24: E203 whitespace before ':'
144:28: E203 whitespace before ':'
145:30: E203 whitespace before ':'
146:24: E203 whitespace before ':'
147:23: E203 whitespace before ':'
148:29: E203 whitespace before ':'
149:26: E203 whitespace before ':'
150:33: E203 whitespace before ':'
151:30: E203 whitespace before ':'
152:30: E203 whitespace before ':'
153:30: E203 whitespace before ':'
154:30: E203 whitespace before ':'
155:30: E203 whitespace before ':'
156:30: E203 whitespace before ':'
157:41: E703 statement ends with a semicolon
160:1: F401 'collection_restricted_p' imported but unused
161:1: F401 'restricted_collection_cache' imported but unused
162:1: F401 'get_permitted_restricted_collections' imported but unused
163:1: F401 'get_all_restricted_recids' imported but unused
166:1: F401 'check_user_can_view_record' imported but unused
170:1: F401 'get_field_i18nname' imported but unused
178: D401 First line should be imperative: 'Create', not 'Creates'
178: D202 No blank lines allowed *after* function docstring, found 1
178: D400 First line should end with '.', not 'n'
178: D205 Blank line missing between one-line summary and description
186:33: E261 at least two spaces before inline comment
195:1: F401 'get_synonym_terms' imported but unused
197:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
200: D401 First line should be imperative: 'Return', not 'Returns'
200: D300 Expected """-quotes, got '-quotes
221:1: F401 'get_collection_allchildren' imported but unused
224: D401 First line should be imperative: 'Return', not 'Returns'
224: D202 No blank lines allowed *after* function docstring, found 1
234:34: E261 at least two spaces before inline comment
282: D400 First line should end with '.', not 'o'
282: D205 Blank line missing between one-line summary and description
282: D208 Docstring is over-indented
327:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names
330: D209 Put multi-line docstring closing quotes on separate line
330: D400 First line should end with '.', not 'y'
330: D205 Blank line missing between one-line summary and description
330: D208 Docstring is over-indented
343:38: E203 whitespace before ','
374:1: E302 expected 2 blank lines, found 0
374: D209 Put multi-line docstring closing quotes on separate line
374: D400 First line should end with '.', not 'g'
374: D205 Blank line missing between one-line summary and description
374: D208 Docstring is over-indented
403: D209 Put multi-line docstring closing quotes on separate line
403: D205 Blank line missing between one-line summary and description
420: D290 White spaces around docstring should be trimmed.
420: D400 First line should end with '.', not 'h'
420: D205 Blank line missing between one-line summary and description
438: D401 First line should be imperative: 'I', not 'Is'
438: D400 First line should end with '.', not '?'
449:1: E302 expected 2 blank lines, found 1
449: D205 Blank line missing between one-line summary and description
449: D208 Docstring is over-indented
456:1: F401 'CACHE_SORTED_DATA' imported but unused
459: D205 Blank line missing between one-line summary and description
459: D208 Docstring is over-indented
473:20: E127 continuation line over-indented for visual indent
475:25: E126 continuation line over-indented for hanging indent
526: D103 Docstring missing
536: D401 First line should be imperative: 'calculate', not 'calculates'
536: D209 Put multi-line docstring closing quotes on separate line
536: D202 No blank lines allowed *after* function docstring, found 1
536: D400 First line should end with '.', not 'e'
536: D205 Blank line missing between one-line summary and description
547:20: E261 at least two spaces before inline comment
551:17: E261 at least two spaces before inline comment
594: D290 White spaces around docstring should be trimmed.
594: D400 First line should end with '.', not 'n'
600:25: E261 at least two spaces before inline comment
601:13: E222 multiple spaces after operator
624:10: E261 at least two spaces before inline comment
643: D103 Docstring missing
644:25: E128 continuation line under-indented for visual indent
645:25: E128 continuation line under-indented for visual indent
646:25: E128 continuation line under-indented for visual indent
647:25: E128 continuation line under-indented for visual indent
664: D401 First line should be imperative: 'Set', not 'Sets'
664: D202 No blank lines allowed *after* function docstring, found 1
664: D400 First line should end with '.', not 'l'
664: D200 One-line docstring should not occupy 3 lines
665:23: E128 continuation line under-indented for visual indent
666:23: E128 continuation line under-indented for visual indent
667:23: E128 continuation line under-indented for visual indent
668:23: E128 continuation line under-indented for visual indent
669:23: E128 continuation line under-indented for visual indent


74: D102 Docstring missing
114: D101 Docstring missing
115: D102 Docstring missing
144: D103 Docstring missing
183: D203 Expected 1 blank line *before* class docstring, found 0
183: D204 Expected 1 blank line *after* class docstring, found 0
183: D400 First line should end with '.', not 'e'
183: D205 Blank line missing between one-line summary and description
188: D102 Docstring missing


4: I102 copyright year is outdated, expected 2015 but got 2014


1: D100 Docstring missing


243: D401 First line should be imperative: 'Searche', not 'Searches'
243: D209 Put multi-line docstring closing quotes on separate line
243: D400 First line should end with '.', not 'd'
243: D205 Blank line missing between one-line summary and description


42: D102 Docstring missing
45:5: F999 redefinition of unused 'visit' from line 41
46: D102 Docstring missing
49:5: F999 redefinition of unused 'visit' from line 45
50: D102 Docstring missing
53:5: F999 redefinition of unused 'visit' from line 49
54: D102 Docstring missing
59:5: F999 redefinition of unused 'visit' from line 53
60: D102 Docstring missing
63:5: F999 redefinition of unused 'visit' from line 59
64: D102 Docstring missing
68:5: F999 redefinition of unused 'visit' from line 63
69: D102 Docstring missing
77:5: F999 redefinition of unused 'visit' from line 68
78: D102 Docstring missing
87:5: F999 redefinition of unused 'visit' from line 77
88: D102 Docstring missing
93:5: F999 redefinition of unused 'visit' from line 87
94: D102 Docstring missing
99:5: F999 redefinition of unused 'visit' from line 93
100: D102 Docstring missing
110:5: F999 redefinition of unused 'visit' from line 99
111: D102 Docstring missing


76: D102 Docstring missing
82: D102 Docstring missing
85:5: F999 redefinition of unused 'visit' from line 81
86: D102 Docstring missing
89:5: F999 redefinition of unused 'visit' from line 85
90: D102 Docstring missing
93:5: F999 redefinition of unused 'visit' from line 89
94: D102 Docstring missing
101:5: F999 redefinition of unused 'visit' from line 93
102: D102 Docstring missing
105:5: F999 redefinition of unused 'visit' from line 101
106: D102 Docstring missing
109:5: F999 redefinition of unused 'visit' from line 105
110: D102 Docstring missing
113:5: F999 redefinition of unused 'visit' from line 109
114: D102 Docstring missing
117:5: F999 redefinition of unused 'visit' from line 113
118: D102 Docstring missing
121:5: F999 redefinition of unused 'visit' from line 117
122: D102 Docstring missing
125:5: F999 redefinition of unused 'visit' from line 121
126: D102 Docstring missing
129:5: F999 redefinition of unused 'visit' from line 125
130: D102 Docstring missing


@christopherthielen, do you have an example?


Yeah you can leave it like that....


Looks fine. That fake actors in the spec is unnecessary. I thought I had taken it out.


是用 co 封装的 spm-client，不过应该也是可以去掉的。


So this is a bug fix. It is a minor one, avoiding a useless FW restart if `FW_SERVICES_zone_RPC` is just whitespace.


There are still various places mem_check_x needs to be called (in ARM and THUMB instructions) but this is a step in the right direction. Now at least MMBN4 won't freeze when checking e-mails (still complains about reads to unused memory).


Well, `type` is the type of the tree node, and some types point to constant values, in this case `2`, to denote that there's no side-effect so we can take shortcuts. In our case we had `let (foo = bar()) 2` and we said that the type of `let` was the type of `2` but that's not true because if we have statements we should not pretend that `let` is a constant with no side-effect. `baseType()` returns the same type without the constant bit.


See readme file and my comments about the PR ;).


Looks like this broken Auto Zoom behaviour - https://groups.google.com/forum/#!topic/osmand/3tB-v1MC4_c


I've tested this and works fine on my local. If you can double check and consider merging it I think this little container is perfect.


It might be worth mentioning that my current PRs: #234 or the (Vadim preferred :grinning:) alternative #237 complete the process of not permitting duplicate or empty area names by enforcing the "restrictions" (with suitable user notifications).  2.1 would silently accept such things but this could cause some internal data problems:
* faulty behaviour from mapper area selection widget
* information loss from key clashes in output from TLuaInterpreter::getAreaTable(...)
* possible problems from TLuaInterpreter::deleteArea(...) where the supplied argument for the area to delete is an area name string and not an area Id number

The above PR's fix existing cases in a sensible way, telling the user what is happening (by pop-up dialogue {234} or main console message {237} ).

For the not impossible case of _multiple unnamed areas_ the potential for problems only increases...
Unique numeric codes for areas makes sense from a machine point of view but unique names work better for humans IMHO.

_Oh dear, just had a thought, "Huston we may have a problem here!", __What happens if the user names their area with a number which does not match the Id?___ e.g. if they type:
```
lua setAreaName( 1, "2" )
lua setAreaName( 2, "1" )
```
Lua's dynamic typing is really going to confuse things isn't it? :stuck_out_tongue_winking_eye: :confounded: :bomb:


Looks like something in this broken Auto Zoom behaviour - https://groups.google.com/forum/#!topic/osmand/3tB-v1MC4_c


I have problems with some classes names and I asked Rafał Korytkowski about it and it's his solution.


Also the rescue can be from a NoMethodError, to reduce the chances of it being called unnecessarily. I'm cnot sure it matters.


Definitely.  Will try soon when I get another slice of time.

Btw, I believe the white spaces came about from my wrapping code in IIFEs.  Will check either way.

Sincerely,
Monico A. Moreno
(from mobile device)

> On Jan 15, 2015, at 10:17 AM, Amir Yasin <notifications@github.com> wrote:
>
> Thanks for the pull request. The problem is that there are whitespace changes everywhere so I can't tell what actually changed. Can you make a pull that has just the changes w/o reformatting?
>
> —
> Reply to this email directly or view it on GitHub.
>


"# the kernel packages are handled by autoyast on its own" is IMHO a useful coment


There is an omission here, because it is only checking the top bit when the sizes of the two types are equal.  This leads to the odd situation:
```
julia> convert(Int, typemax(UInt64))
ERROR: InexactError()
 in convert at /Users/stevenj/Code/julia/usr/lib/julia/sys.dylib

julia> convert(Int8, typemax(UInt64))
-1
```
described in #9786


This method could be potentially re-used where you're calling `PopularArticle.last || PopularArticle.new` twice in `popular_articles_controller.rb`. Then there's only one place to make changes instead of three?


2.0.x ?


@bors: retry


Doesn't this want to default to false?


I removed the rescue in favor of just checking:
```ruby
Cellect::Server.adapter.load_workflows(name) unless Actor[name]
```


Well, it depends on what you mean by never changing. If your C code isn't permitted to change things, you will declare them const — but since we're interfacing with Ruby code, and a lot of what we're passing around is pointers, you have to tell C/C++ that not only are the pointers constant (can't point to a different location in memory) but their contents are also const. I always have to look this up, but I think it's something like `cost void * const x`. And then the compiler won't let you modify it (easily), and will enforce that constness.

Generally if I think something is going to behave in a way that is unexpected, I'll make a note of it. But I always try to explain my code in comments regardless.

Most C coders also use really short variable names. I try to use longer names more similar to Ruby for the following reason: you already have to type a ton of stuff when coding C++. If you have an 80-character typename (consisting of templates, for example), why spend only two characters on the variable name? You're going to be typing all day anyway, so why not make your code simpler to read by giving lengthy variable names?

This is probably more than you asked, but hopefully it helps.


Nop. It's the next version which is in dev. The 2.0.0 is stable. :)


It does


This will be updated today, sorry for the wait!


I guess this would be call after the next line, that where the index variable is created


TeamCity Ylab :: synteny/ylab [Build 24](http://192.168.30.225:8111/viewLog.html?buildId=525&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


generally speaking, if you wanna try things you can work from a branch and deploy to OpsWorks from this branch. in OpsWorks under Stack Settings ->"Use custom Chef cookbooks" you can choose a branch for the Chef recipes (the default is master)


Thank you for your thoughts.

I'll make the relevant changes and send a PR ASAP.


I think it is an easy-to-check way to express "write comments in English, not in German" (cough StarOffice cough Storage cough). We can keep it disabled in the common style file.


Hmm.. I'm not sure if creating an empty table (extra footprint in the db) is the best way to go. If there are going to be extra fields on this model in the future then I could understand. Just getting an opinion from somebody outside of the team @benlovell


@parlarjb note the `// FIXME`s in the test code. I have similar ones in the billing app too.

It's strange because the rxSortableColumn tests all behave normally, but I'm seeing implementations lately that sort backwards...


This would be nice as a respective method: ``Device.send_data(data)``, but I can add that...


That's happen when reading too fast :disappointed:


Project FDF in C programming from 42


IDFXT (Unknown) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


how is handled rebalancing then ?


@cosimoc Cheers. I note that there's a few other places in the tests where we do this too, so I'll make a separate commit to clean it all up.


Ah sorry I misread. Everything looks good then.


"Generic function to iterate over unused and used subflows"

Because active/backup refers rather to the low-prio flag.


Ahh, you don't need to wrap NodeJS files in IFFEs because you can't actually pollute global scope in node in the same way you can in the browser.  Also if it were just the IFFEs it should only show 2-3 lines changed.  The culprit (I suspect) is probably tabs->spaces.


LOL Can you tell I taught school for 29 years, mostly in elementary?


Hmm, though it is not actually due to this patch; need to further back in the history, I guess.


Document that the lines of this file should be of the form
```
<rev_id>
```
or
```
<rev_id><TAB><page_id>
```


Amend the commit message, without a `#` it is not linked to the issue.


Hahaha.. I need to go back!!!!!!


Need to put quotations marks in [data-ls-module=steps]


Hey Wolfgang,
The asserts Assert (density_c_P >= 0, ExcMessage ("The product of density and c_P needs to be a non-negative quantity.")); and Assert (density_c_P + latent_heat_LHS >= 0,+ ExcMessage ("The sum of density times c_P and the latent heat contribution "+ "to the left hand side needs to be a non-negative quantity.")); give me some trouble.

This probably has to do with the fact that I use a sticky air where there is a very high density contrast. This causes some over- and undershoots in the first few timestep, because the diffusion hasn't kicked in hard enough yet. After a few timesteps this problem is solved. But these asserts are preventing the models to get past this point. I have just commented them in the current version of the code I use.


Instead of a counter, just use a bool.


new package release 2


Hmm... The build is failing, but it looks like it's just zk data not getting cleared properly between runs


такий метод є в ProfileService, Богдан має знати


IDFXT (Unknown) - x86_64-MacOS-10.9-clang: OK (1584 of 1584 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


IDFXT (Unknown) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Which of the two is failing for you? Assuming that you don't have any latent heat, then density_c_P really is less than zero, for given temperature and pressure. That's a problem you're better off fixing inside your material model.


Is there not a maven plugin or something for maven-jar-plugin that can take it's places, or will Ant be necessary?


Yes, though it'd be less explicit and people would have to search for where it's defined.


@alexciarlillo fixed in https://github.com/roots/roots/pull/1255


I don't see why we should deviate from the style guide: https://github.com/bbatsov/ruby-style-guide#no-bang-bang


it would be nice to have these in qml-mateiral, maybe with a visual signal when the value changes


TeamCity Ylab :: synteny/ylab [Build 24](http://192.168.30.225:8111/viewLog.html?buildId=525&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 125 Build time: 00:11:26


That's cheating :D


Yeah I've noticed intermittent failures on builds. It's setting up a fresh zookeeper for each build though. Or did you mean clearing the data between individual specs?


Yes, thanks. Also, warning in Chrome console became too annoying :)


It seems like your are mixing up used and backup subflows.

Let's summarize:

The scheduler first tries to send on unused active subflows. If the segment in question has already been sent on all active subflows once, we should send it on a used active subflow.

If none of the above matches. E.g., the segment in question not been sent on any active subflow (thus, we will not fallback to used subflows) and the active subflows are definitely unavailable, then we check the backup subflows. And there the same as above applies. If the segment has been sent on all backup subflows once, we will send it on a used backup subflow.


and instead of just '+' i would put '9+'


In the uuid validity check, the test is not correct.

    if ("${fsuuid}" != '') and "${fsuuid}" =~ /^[a-f0-9]{8}\-[a-f0-9]{4}\-[a-f0-9]{4}\-[a-f0-9]{4}\-[a-f0-9]{12}$/ {
		fail("The chosen fs uuid: '${fsuuid}' is not valid.")
	}

It should be like in host.pp :

    	if ("${uuid}" != '') and (! ("${uuid}" =~ /^[a-f0-9]{8}\-[a-f0-9]{4}\-[a-f0-9]{4}\-[a-f0-9]{4}\-[a-f0-9]{12}$/)) {
    		fail("The chosen UUID: '${uuid}' is not valid.")
     	}

Or even better :

    if ("${uuid}" != '') and "${uuid}" !~ /^[a-f0-9]{8}\-[a-f0-9]{4}\-[a-f0-9]{4}\-[a-f0-9]{4}\-[a-f0-9]{12}$/) {
    		fail("The chosen UUID: '${uuid}' is not valid.")
     	}


Ok clear! Thanks for the explanation :)


should this also be casted to `(Bucket *)`like done in the upper line-change?


I mean that I think between each ruby version, it's persisting the data in /tmp/zookeeper.  I'll see if 44442a4ac7 fixes it


yep, that's the intention


Thanks


I am indeed not using latent heat at the moment. Setting a minimum density in the material model might indeed be a better way to solve this problem. Thanks!


How so? I believe that the user and role interactions are covered by the Rolify tests.


revert of https://github.com/twosigma/beaker-notebook/commit/b5ad42767cc37761c25950605550df88eaa3b59b


generator 调用还是得要 co


:cool:


Today If streamer plugin will recompile on my VPS, i'll upload it to my public server and test these fixes.


Cool. Thx. Will check for tabs then.

I did use the "?=1" in the gh diff url, so I'm thinking tabs might be it.

Also, I used the IIFEs to avoid the jshint flag about using the function form of "use strict", not to avoid global pollution. ;-)

But that decision is ur prerogative.  Let me know.

Sincerely,
Monico A. Moreno
(from mobile device)

> On Jan 15, 2015, at 10:30 AM, Amir Yasin <notifications@github.com> wrote:
>
> Ahh, you don't need to wrap NodeJS files in IFFEs because you can't actually pollute global scope in node in the same way you can in the browser. Also if it were just the IFFEs it should only show 2-3 lines changed. The culprit (I suspect) is probably tabs->spaces.
>
> —
> Reply to this email directly or view it on GitHub.
>


@ethomson After ~2.5 years as a plain user I'll give it a try. I never coded plain C, what could possibly go wrong? :innocent:

In turn, I would really appreciate seeing contributional work in form of PR's provided to https://github.com/macgitver/GitWrap and/or https://github.com/macgitver/MacGitver. Clearly not pushing anyone here! It is just, we are just 2 developers. Further, it would be really nice, finally seeing GitWrap appearing besides libqgit2 - also this has to be discussed somewhere else.


cool new syntax :-)


Would it make more sense to the user if we said the distance is clamped to [refDistance, maxDistance]?


r+


Trying to remember why this commit was made, and therefore what will break if this gets reverted...


This is just a taster of the clean up I plan to do. If I should continue please let me know.


@matthieugrieger That was quick =) I'll test the !nextsong command a bit today...


Great! It would have taken me weeks to figure out the function router.CalculateRange for this task of mine. But:

/// Returns all points located at a given weight (distance/time) from the orgin.
public HashSet<GeoCoordinate> CalculateRange(Vehicle vehicle, RouterPoint orgine, float weight)

How do i pass the parameter weight?

I tried "0.08" for 8 minutes but i only get 3 points...

Another problem: I succeeded in 'pulling' a PBF-file into an PostgreSQL-database. I can open it via
            NpgsqlConnection con = getPsqlCon();
            IDataSourceReadOnly source = new OsmSharp.Data.PostgreSQL.Osm.PostgreSQLDataSource(con);

How do i create a router based on a database?

If that is solved, i could use PostgreSQL/ST_MakePolygon to build the polygon of the resulting pointset.

Groetjes naar belgie;-)


COMMENT GITHUB : de ticket wordt zo niet meer aangemaakt......


Correcting in url parm, should be "?w=1"

Sincerely,
Monico A. Moreno
(from mobile device)

> On Jan 15, 2015, at 10:43 AM, CDN Admin <cdnadmin@collaborare.net> wrote:
>
> Cool. Thx. Will check for tabs then.
>
> I did use the "?=1" in the gh diff url, so I'm thinking tabs might be it.
>
> Also, I used the IIFEs to avoid the jshint flag about using the function form of "use strict", not to avoid global pollution. ;-)
>
> But that decision is ur prerogative.  Let me know.
>
> Sincerely,
> Monico A. Moreno
> (from mobile device)
>
>> On Jan 15, 2015, at 10:30 AM, Amir Yasin <notifications@github.com> wrote:
>>
>> Ahh, you don't need to wrap NodeJS files in IFFEs because you can't actually pollute global scope in node in the same way you can in the browser. Also if it were just the IFFEs it should only show 2-3 lines changed. The culprit (I suspect) is probably tabs->spaces.
>>
>> —
>> Reply to this email directly or view it on GitHub.
>>


@donnapep Not to get too picky, but you can lose the closing `/` for this `<input>` tag


OptionalTypedArgs (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (333 of 333 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hey Guys;

Unfortunately the update don't make effects in OpenProject:

https://community.openproject.org/topics/3597 (To Comments);

I try to start a new instalation - Do not Work;
I Try to Update a current version - Do not Work.

Sergio Caixeta


The method name suggests a `(NSDate *)date` parameter at the end.

I suggest renaming it into `crv_defaultImageDataRepresentation`.


why?


`nullptr`?


Wheres the oversight? I just checked the behavior of the previous revision vs the 1.14.5 release and the behavior is identical.


No commented-out code, plx.


Nice :)


saw approval from jdm
at https://github.com/akiss77/servo/commit/7773ecf2bab646e4916eaf199f4c4a981f003d8b


merging akiss77/servo/pr-update-mozjs = 7773ecf2 into auto


akiss77/servo/pr-update-mozjs = 7773ecf2 merged ok, testing candidate = 772570d0


I am looking at the rolify documentation. Looks good on the model tests for your autogenerated role and user models :+1:


:+1: You can test it in a similar way to `CRVImageAsset`.


`fileAttributes` is not a parameter.


Any reason to duplicate `util.import_from_path` instead of reuse it?


还是一头雾水


am not a big fan of using variables for the version numbers. what does it add really?


note : the librato stuff should definitely go to external


r=nikomatsakis p=7UFCS


I found it initially confusing in the update method that we have a local variable `update_data` and in this class we have have an `update_data` method, especially since there is no direct call to this method.  I do not feel strongly about changing the names, but I thought I should point that out.


Why is this retarded?


Should probably find out what other values are valid here, since the Apple API has changed since tutorial was written


Neat!  We'll try to advertise those a bit.

Just to clarify, though, you're talking about the *examples* that you're seeing strange behavior in - yes?  You're not seeing strange data in the events themselves?

I do want the examples to be good, of course, but if they're a little noisier than (say) git.git, that's okay with me, as I think that easy code samples are better examples than denser ones.


Oops, oh well ;)


```Ruby
last_name { Faker::Name.last_name }
```


Whoops, thats a mistake.


Thanks @jowr.  I figured it was something stupid that I did...  Can you perhaps add some REFPROP/COOLPROP tests for trivial outputs?


Alternatively (prefer) I can disable "use strict" in jshint altogether, esp since there's no global pollution in Node

Sincerely,
Monico A. Moreno
(from mobile device)

> On Jan 15, 2015, at 10:46 AM, CDN Admin <cdnadmin@collaborare.net> wrote:
>
> Correcting in url parm, should be "?w=1"
>
> Sincerely,
> Monico A. Moreno
> (from mobile device)
>
>> On Jan 15, 2015, at 10:43 AM, CDN Admin <cdnadmin@collaborare.net> wrote:
>>
>> Cool. Thx. Will check for tabs then.
>>
>> I did use the "?=1" in the gh diff url, so I'm thinking tabs might be it.
>>
>> Also, I used the IIFEs to avoid the jshint flag about using the function form of "use strict", not to avoid global pollution. ;-)
>>
>> But that decision is ur prerogative.  Let me know.
>>
>> Sincerely,
>> Monico A. Moreno
>> (from mobile device)
>>
>>> On Jan 15, 2015, at 10:30 AM, Amir Yasin <notifications@github.com> wrote:
>>>
>>> Ahh, you don't need to wrap NodeJS files in IFFEs because you can't actually pollute global scope in node in the same way you can in the browser. Also if it were just the IFFEs it should only show 2-3 lines changed. The culprit (I suspect) is probably tabs->spaces.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub.
>>>


I moved that part of the code and improved logging. Since image dimension and other image metadata are optional, I don't think that throwing an exception to the user of the ImageContentReader would be helpful.


Thanks :+1:


throw new Exception


Actually... I think it's even worse order. You shouldn't specify expectations in `context` blocks, even if that means 100+ lines of test code.

> Arrange in `context`, act and assert in `it`.

The initializer parameters should be arranged by `context` blocks:

```objc
 __block NSURL *url = nil;

context(@"with no url", ^{

    beforeEach(^{
        url = nil;
    }

    it(@"should fail to download", ^{
        expect(^{
            [manager downloadAssetFromURL:nil progress:nil completion:nil];
        }).to.raise(NSInternalInconsistencyException);
    }
}
```


I've been using it to pass a build config file.


Not until March ;-) I'll add an issue.


Smaller file size


Hi @pocketjoso just curious about what is the issue we are aiming to fix here?

Its kind of weird that after upgrade to the latest penthouse, we are unable to generate correct CSS file (using grunt-penthouse) anymore, seems the CSS file break somewhere in the middle and stop collecting the rest.

I am still trying to dig into that what might be the cause of the break, (we are providing minified CSS as input for penthouse).

Thanks!

Roderick


:bug: This is the cause of that regression I think Vadim!  I was a tad careless in my deletions.


typo: langauges


Wouldn't this just cause the PM to close, rather than crashing?


And the null terms here.


Do we have a contact at this company to point out their null issues, or did a user submit it?


Please to not reindent all the code


@RobVermeer
Weet jij hoe het mobiele menuknopje verticaal in het midden van de header geplaatst kan worden? Ik heb nu een padding-top van 15% gedaan, maar dat plaatst hem nog niet op alle formaten mooi in het midden.


Rather than this, wouldn't it make more sense to just allow an arbitrary script in hex? Why limit it to OP_RETURN?


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I agree with ricardo's 2nd point. 9+ is clearer than just +.


Oh i see!


Yes, as you pointed out it can be accidentally conflicted between the default plugin and other plugins.

But think about most common use cases. Most cases use the only one plugin, and the prefix for the default and only plugin is redundant.
And we should consider about backward compatibility. So we cannot rapidly change. It's why I choose this design.

I agree that it's controversial. I think this feature will be steadily discussed and changed.


Hm, abstract...


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1638
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3156
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3149
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3151
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3141
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3141
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3144
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3137
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3131
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2809
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2807
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1645