I've run my tests again and I've got same results...
Please find here all needed informations.

Interface :
```
root@gluster1:~# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 02:00:c0:a8:de:1f brd ff:ff:ff:ff:ff:ff
    inet 192.168.222.31/24 brd 192.168.222.255 scope global eth0
       valid_lft forever preferred_lft forever
    inet 192.168.222.40/32 scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::c0ff:fea8:de1f/64 scope link
```

VRRP logs :
```
Jan 19 17:37:14 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Now in FAULT state
Jan 19 17:37:23 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Transition to MASTER STATE
Jan 19 17:37:24 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Entering MASTER STATE
Jan 19 19:19:39 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Entering FAULT STATE
Jan 19 19:19:39 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Now in FAULT state
Jan 19 19:22:51 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) prio is higher than received advert
Jan 19 19:22:51 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Transition to MASTER STATE
Jan 19 19:22:52 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Entering MASTER STATE
Jan 19 20:14:58 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Entering FAULT STATE
Jan 19 20:14:58 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Now in FAULT state
Jan 19 20:15:58 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) prio is higher than received advert
Jan 19 20:15:58 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Transition to MASTER STATE
Jan 19 20:15:59 ubuntu Keepalived_vrrp[8759]: VRRP_Instance(VI_gluster) Entering MASTER STATE
```
(no ping/pong bounce)

Facter (run during master state) :
```
root@gluster1:~# facter | grep eth
interfaces => eth0,lo
ipaddress_eth0 => 192.168.222.31
macaddress_eth0 => 02:00:c0:a8:de:1f
mtu_eth0 => 9000
netmask_eth0 => 255.255.255.0
network_eth0 => 192.168.222.0

root@gluster1:~# facter | grep 192.168.222.31
ipaddress => 192.168.222.31
ipaddress_eth0 => 192.168.222.31

root@gluster1:~# facter | grep 192.168.222.40
# nothing
```

Software versions :
```
root@gluster1:~# facter --version
2.3.0

root@gluster1:~# puppet --version
3.7.3

root@gluster1:~# keepalived --version
Keepalived v1.2.7 (08/14,2013)
```

Keepalived configuration :
```shell
# Managed by Puppet
vrrp_script check_gluster {
  script    "/usr/bin/killall -0 glusterd"
  interval  2
  weight
}

vrrp_instance VI_gluster {
  interface                 eth0
  state                     MASTER
  virtual_router_id         70
  priority                  254
  advert_int                1
  garp_master_delay         5

  # notify scripts and alerts are optional
  #
  # filenames of scripts to run on transitions
  # can be unquoted (if just filename)
  # or quoted (if has parameters)

  authentication {
    auth_type PASS
    auth_pass #############
  }

  track_script {
    check_gluster
  }

  virtual_ipaddress {
    192.168.222.40 dev eth0
  }

  unicast_peer {
    192.168.222.31
    192.168.222.32
    192.168.222.33
    192.168.222.34
    192.168.222.35
    192.168.222.36
    192.168.222.37
    192.168.222.38
    192.168.222.39
  }

}
```

I think facter doesn't retrieve the virtual IP because ifconfig doesn't see it :
```
root@gluster1:~# ifconfig -a
eth0      Link encap:Ethernet  HWaddr 02:00:c0:a8:de:1f
          inet addr:192.168.222.31  Bcast:192.168.222.255  Mask:255.255.255.0
          inet6 addr: fe80::c0ff:fea8:de1f/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:9000  Metric:1
          RX packets:481655 errors:0 dropped:28786 overruns:0 frame:0
          TX packets:400484 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:163126463 (163.1 MB)  TX bytes:36414097 (36.4 MB)

lo        Link encap:Local Loopback
          inet addr:127.0.0.1  Mask:255.0.0.0
          inet6 addr: ::1/128 Scope:Host
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:201948 errors:0 dropped:0 overruns:0 frame:0
          TX packets:201948 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:15292756 (15.2 MB)  TX bytes:15292756 (15.2 MB)
```

This bug seems to be related with the issue :
https://tickets.puppetlabs.com/browse/FACT-184
(see "Issue Links" and "title")

Let me know if you need another informations...


You're right, I'll undo my changes to the double spaces.


So, the fix is this particular line, right?
The other changes are unrelated?


Much better, although it seems to be removing information. Howabout:
`A mapping executes until it finishes or encounters an error, where an error causes the rest of the mapping to be discarded.`

I'm sure there's a more concise way of saying that.


Загрузка страниц очередями имеет свой недостаток.
Например, если все треды находятся на нулевой, то оставшиеся три страницы загружаются вхолостую.


Then lend your wonderful advice @xPythonic <3


Обратный порядок слов, поэтому запятая нужна.


Yes, I think you're right. Thanks for spotting that so quickly. I'll commit a fix shortly.


better to make designation table independent of employee,  and assign designation id to employee


こちらの `DOCUMENT_ROOT` も修正しました。


Great! Nice idea @achbed.


OK, maybe we should do that for all our API clients then.


Because it doesn't work from from authoring screen, how it should behave when pressing on the + button needs to be specified in a story, at the moment we don't have it.


Can in theory be bypassed by using */ME claps*

You should look at using `event.getMessage().toLowerCase().startsWith("me ")` or some variant of `equalsIgnoreCase()` and `split()`

However this should probably be handled in the [code that handles /me](https://github.com/NerdNu/NerdMessage/blob/master/src/nu/nerd/nerdmessage/NerdMessage.java#L97) and change it to use `sendMessage` with a loop rather than `broadcastMessage` as it currently does. This solution would work, but it seems neater to just never send the message in the first place


90:105: E231 missing whitespace after ':'
91:105: E231 missing whitespace after ':'
92:87: E128 continuation line under-indented for visual indent
92:93: E231 missing whitespace after ':'
93:105: E231 missing whitespace after ':'
94:87: E128 continuation line under-indented for visual indent
94:103: E231 missing whitespace after ':'
95:87: E128 continuation line under-indented for visual indent
95:93: E231 missing whitespace after ':'
96:87: E128 continuation line under-indented for visual indent
96:94: E231 missing whitespace after ':'
97:105: E231 missing whitespace after ':'
98:87: E128 continuation line under-indented for visual indent
98:103: E231 missing whitespace after ':'
99:87: E128 continuation line under-indented for visual indent
99:93: E231 missing whitespace after ':'
100:87: E128 continuation line under-indented for visual indent
100:94: E231 missing whitespace after ':'
101:105: E231 missing whitespace after ':'
102:105: E231 missing whitespace after ':'
103:115: E231 missing whitespace after ':'
105:105: E231 missing whitespace after ':'
106:87: E128 continuation line under-indented for visual indent
106:103: E231 missing whitespace after ':'
107:87: E128 continuation line under-indented for visual indent
107:103: E231 missing whitespace after ':'
108:105: E231 missing whitespace after ':'
109:87: E128 continuation line under-indented for visual indent
109:103: E231 missing whitespace after ':'
110:87: E128 continuation line under-indented for visual indent
110:92: E231 missing whitespace after ':'
111:87: E128 continuation line under-indented for visual indent
111:93: E231 missing whitespace after ':'
112:87: E128 continuation line under-indented for visual indent
112:94: E231 missing whitespace after ':'
113:105: E231 missing whitespace after ':'


I think that having the preview is useful, no clear requirements on this so this was my best guess...


This code has been changed (and is wrong); rather look at the final diff rather than the individual commits.


@rha-odoo its done, I have added the context as you suggested.


Great. I'll change it.


Yes, you are right. I don't know how to fix it either.


Adding a frontend dependency with composer? I don't think thats a best practice at all. If you want to install it with a dependency manager, I would prefer to use bower. This can also install jquery.


That's much clearer. Great.


Yeah, it's not the nicest way of showing them. https://github.com/fmoralesc/vim-tutor-mode has some nice looking syntax for representing key presses.


@mirasrael So does `make oracle` work for oracle 12c?


Thanks, good point. I've fixed this.


You never end your files with an empty line. Thats against the coding standards. You can set this as a setting in your editor. In Sublime text, it's this setting: "ensure_newline_at_eof_on_save": true


Sure


`new PagesLoader(0, aib.lastPage + 1, function(pNum, formEl) {`

Ой вей! А внутри тредов-то ссылки на страницы не указаны! Там aib.lastPage всегда равно единице!


Корректная проверка происходит только из списка тредов! Це неправильно.


LGTM。

下次别忘记发成 CL，这种 merge commit 不在 Gerrit 上看根本看不下去。


It definitely conflicts, I tried it. The problem is that `UnionState` and the associated logic don't properly deal with one state chain being shorter than the other.

Here's what happens: pressing `S` will detect both the change command and the initial state of the surround plugin, but the `UnionState` will immediately return any Commands if a Transition happens to return one (it does this to handle the "change caret command" used by operators like d*x*). This means that after pressing `S` the change command will be executed, which switches to Insert mode and resets the state machine to that of Insert mode.

There are ways to get this working by properly marking "terminal states" and their values, but then I'd need to refactor the `State` and `Transition` interfaces. Since I made this change for myself because I trigger `C` by muscle memory, I didn't think it feasible to correct this. And as you said, a plugin's mapping *will* override the "core" ones if they use the exact same states, so it only matters if we bind a command where we have a plugin using a longer mapping.


Must have missed this one `Gcc` -> `GCC`


Hello


No, but I don't expect people to report every random error message.


pvr.myth: Here 'string' the word in comment, not the class


At first i installed everything with bower, but later i thought that maybe its more user friendly to only run composer install once. But this can easily be changed.


Ha! I'll fix that.


Loving it!


Closing comment */ was missing and thus the resume was not displaying properly.


Added Shake functionality and SMS Plugin


CRSFじゃなくてCSRF


Ok ill fix this :)


@josevalim moving the CSRF token out of the (signed) session opens up the possibility of a cookie injection attack. In particular, an attacker could overwrite the cookie as part of a hijacked plain HTTP connection, and then trigger the CSRF attack. Even if the site uses HTTPS and marks the cookie as secure, most (all?) browsers will allow the cookie value to be overwritten by an insecure HTTP response claiming to originate from the same site.


@Garcia98 this will be needed for shinano too or maybe add and ifneq if this isn't needed by Rhine family?


Please don't push yet by the way. Much easier to review :)


Can you please log the error, so we can see it in kibana!


Even better.


Sorry, I got overeager. I should have waited for the first pass of review to finish.


It's fine, I do it too.


alright!


2015-01-19
kl 18.44


I guess much better now


Errors should be logged!


pvr.mythtv: Also we have to separate with space all defined strings, not only PRIu64.
I noticed LOGTAG , PRId... .


You're right, I saw it reverted later


you're okay with having your tenant name there?


You may be right, although I'm not totally convinced, yet. I completely agree - after another careful inspection - that my additions of `close(new_sock)` on line 230 (+/-) and 370 (+/-) may break new incoming TCP connections. However, by definition, you're overwriting the `new_sock` resource on line 233 (+/-) with every new connection, since you loose the reference to the 'previous' socket. Do you agree?


好，下次注意= =||


Singleton


I did this with a script (thats why it hit some comments because the parser was not that mighty...). ^^ - agree all defined strings have to seperated by space - i only fixed those which failed the compilation. (not sure why the others didn't... Maybe the spaces are only needed when the define is encapsulated by string constants ...


Srting?


update_sqlite_coverage (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1555 of 1592 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.68%25-yellow.svg)


Yeah, If we can build in a way of amending *any* months date (not just
december), then that'd be cool.

— Anthony

On Mon, Jan 19, 2015 at 12:45 PM, Mike Street <notifications@github.com>
wrote:

> @MrQwest <https://github.com/MrQwest> Ah ok, we can add an exception e.g.
> if the month is December, use a different date? That's the exception to the
> rule though - so we can address that in the info-update
> <https://github.com/mikestreety/CrCreatives/blob/revamp/data/info-update.php>
> page
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mikestreety/CrCreatives/commit/dbdbffeafe1a53915751b6c179b6d2abe1a19be9#commitcomment-9338628>
> .
>


Could add a comma like so:
Even when you move around in the file, `" and `. will take you...

or

Even when you move around in the file `" and `. will take you
to the remembered position, at least until you make another change or leave the file.

(ignore the weird formatting, a backslash doesn't seem to be able to escape backticks on GH)


If don't think it's a problem to add bower in here. We're moving towards a more modern approach to frontend, using a big frontend framework. I think it's better to do it the right way.


PagesLoader не подходит. Либо, его надо менять, либо вернуть все как раньше.


Mhhh yeah you are right - i wonder why it didn't bail out because of PRId ... fucked up clang shit...


Perrrfect!

— Anthony

On Mon, Jan 19, 2015 at 12:43 PM, Mike Street <notifications@github.com>
wrote:

> Yeah, this function checks if the attending link exists - if not, it
> doesn't render out the links but keeps the date
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mikestreety/CrCreatives/commit/f7fd48e0f5f2594af121cdb5a7475600c68677be#commitcomment-9338601>
> .
>


C’est intéressant mais ce n’est pas mon approche. Mes objets sur fichier sont des objets *core*, donc aucune notion de GPU ou de rendu :).


TACK @macpac!


@tijsverkoyen what do you think?


I think the comma before `type` was beneficial, as I initially read that as `file type`.


@brverbur thanks for the feedback! I had not thought about hijacked connections. It seems by signing the cookie in this case we may circumvent such attacks, can't we?


Would it be better to have an array somewhere with a list of correctly-cased filenames? Then this could be implemented by a lookup.

I'm concerned that this block of code might be overlooked when new libraries are added in the future, and it would be good to figure out how that can be avoided.


Does `facecolor='None'` work correctly? The reason I made it `'k'` is because it should be black with 0 alpha, but just `transparent=True` gets white with 0 alpha on mpl 1.4.2.


it might be a good idea to fetch the public key only once and persist in memory. Currently, we do not need to change the keys every night but in future that will not be the case. Nevertheless, we do not need to abuse the server for now!


Yes, and possibly px:copy too.


Ok - based on that:

http://stackoverflow.com/questions/11869593/c99-printf-formatters-vs-c11-user-defined-literals

It has something to do with user defined strings and others. Seems PRid is user defined and therefore doesn't need the special treatment ... wtf.


Im already adding bower.


hum .. strange because I have only do a pull from your repo, set the configuration in the solution, and commit it (and push).
So just check "Generate" in the properties of the solution to the console project.


The latest `python-basemap` package will have this fixed. It will probably fail once it moves out of testing.


Ah ok..the tests right now ignore transparency..I'll add it.

On some matplotlib versions, using facecolor='k' results in a black background though...maybe a white facecolor is a good compromise?


(regarding line 631) I just checked the example vimrc, and it's 78, so might want to change that as well as the instances of `72` -> `78` on line 629 and 637.


I used this version to support tls1.2,but I get error “uncaught err:Error: 0:error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number:openssl\ssl\s3_pkt.c:347:”。


Thanks


update_sqlite_coverage (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The socket number is not lost, since there is
```
    FD_SET(new_sock, &conf->master);
```
at line 309. If it was lost, how could we accept data from that socket in the first place? You might notice that the collector even writes a notice when exporter closes a connection. The output is only a few lines before subsequent `close()` call (972).


Could be `making them hard to...`


Uhhhhh.... Did you merge kingman into master, Nader?


The default for mpl 1.3.1 _is_ black background; it just has alpha=0 as well. And the testing function ignores alpha. But mpl 1.4.2 seems to have a bug somehow and makes it white with alpha=0, so the tests fail. We could change it to white, but we'd need to update the baseline images.


Good news. Will they move it to the site-packages directory or adjust the search path of the data?


I do not understand your note. Could you rephrase?

After thinking about this I realized it might be better to change the scale variable into an `int16_t` and put the actual scale factor (2000, 4000, 8000, 16000) there instead of the setting bitmask.


LGTM


Surely this should either be YOU'RE or YOU ARE


not really. I can change the color of fully transparent pixels in the compare_images() function. Right now it sets it to fully white and no transparency...I'll just set it to white and leave the transparency as it is. Then it should always work.


Thanks, this is what I needed to fix my tests :dancers:


`is used, in which case it can't be...`


Looks good, I'll publish a new package soon.


You could say: `if options['disable_ssl_verification'].present? && boolify(options['disable_ssl_verification']).nil?`


remove dead code


The search path will be changed; the data's in a separate package to allow for keeping out the really high-resolution stuff.


url should be public, not private


Ah yes, good point. That works as well now that we have our own `compare_images`.


Follow is my code for https request:

var httpsClient = require('https');
var options = {
  hostname:host,
  path:serverPath,
  port:443,
  method:'GET',
  secureProtocol:'TLSv1_2_client_method',
  headers:{
    'Content-Type':'application/x-www-form-urlencoded'
  }
}
var req = httpsClient.request(options, function(res) {
  res.setEncodeing('utf8');
  res.on('data', function(data){
    console.log(data);
 }
});
req.end();
req.on('error', function(e){
   console.log('error:'+e);
});


:+1: starting to make more and more sense, good job!


It might be good idea to move this case classes somewhere else


This filtering only occurs when generator find both parameters :

    paginate: n
    not_paginated_categories:
      - 'toto'


Right. Please ignore this one then. I guess that `close(new_sock)` on 370 should also be removed.


Loading public key probably should be separated from this logic to separate concerns


This corresponds to a rebase from develop branch on Tue 20 January 2015 10:18


Good to know that there's a method to convert object to proc. Because I was wondering the same thing. Thanks


Thanks Memphiz. Seems to be okay. Later i will update because it is a better style with space.


Somehow this looks a bit scary/sloppy to me compared to inlining the env: `system(%{ENV=foo pg_restore …})`

I guess it's because we're defining it more globally than necessary. I suppose it probably has no ill effects though.


This does not need to be addressed as part of this PR, but... `loadTiffFromJar` is not only technically wrong... at this point, Maven accesses the `target/classes/` directory directly. A more appropriate name would be `loadTiffResource`. And while we are at it, there is nothing colocalization-specific to the `TestImageAccessor` class, therefore a better place would be a generic ImgLib2 test helper library.


``` path = "/tmp/" + path + ".com" ```

The extention name of gaussian if "com" ? O.o


should be public address and probably should be loaded via configuration and not hardcoded


As the link suggests this might not be needed in the future. Hell those compiler devs are a bit undecided as it seems ;) - i try a less intrusive way of making the pvr-addons compile on osx clang with enabled c++11 anyway (without touching all the std stuff in cpp files but only headers...)


PS, you could drop `facecolor` entirely; I only added it just recently (a day or two ago) for mpl 1.4.2 and its `compare_images`.


Extracting the ruby version to a variable might make it slightly easier to maintain.


TeamCity Ylab :: Feodorov/ylab [Build 56](http://192.168.30.225:8111/viewLog.html?buildId=571&buildTypeId=Ylab_FeodorovYlab&guest=1) is now running


This setting has been renamed to `POOTLE_CONTACT_REPORT_EMAIL` in https://github.com/translate/pootle/commit/d900025c4ab322c8765d923f3718462a9a6fee90


Committing Secret Keys to Git Should be avoided :)


Can anyone tell me where I can find (what I assume is) the build number? (r729 for 7.0.1, r703 for 6.3, r656 for 6.1, r635 for 5.9 etc.) I can't find what the build number for 7.0.2 anywhere.


Let's lose the `this.` prefix.


@d10, @phated please review. It needs feedback.


这是做开发呢, 还是做翻译呢?
疑惑中...


Probando comentarios de codigo en github.


It does not work (or you need another clock to do this specific task).


That's something I've always wondered...


Thanks for taking the time to spot and fix this - I've just merged another pull request that I think does the same.


`Math.max` and `Math.min` have (or at least had, at some stage in the past) performance issues because they cannot be inlined. Better write:

```java
        return min > val ? min : max < val ? max : val;
```


Excellent.


That was quick thought of using `+=` because it's already string in first place. And when I thought I need to add `"\n"` my brain suggested to add `+` without thinking another alternatives. I usually use `"#{}"` when construct a string with using non-string variables. Dont get me wrong, I like your idea.


It would be great to salvage the original git history of these files.


@Sharuru Thx， I‘ve fixed it .


Yeah would prefer them in their own namespace too


Hier sollten die normalen Header benutzt werden, da wir das ja zurück portieren wollen.


I may be misunderstanding, but doesn't C++ automatically join two strings that are next to each other?

The above should be the same as:

    "/"  "some example path"

Which is concatenated. Is this not this true, or is this a readability change?


Sorry, I thought it was `packages` widget because PR was about that one


Thank you


Leerzeichen um "." fehlt


no problem with the last commit?


It supposedly limits your thinking. This might give some insight: http://laravel.io/forum/10-26-2014-laravel-5-where-is-the-models-folder


You should not Commit passwords too. I was able to login here. I am sending you an Email.


update:
```
[cli/threadexecutor.cpp:530] -> [cli/threadexecutor.h:47]: (performance, inconclusive) Technically the member function 'ThreadExecutor::check' can be static.
[cli/threadexecutor.cpp:525] -> [cli/threadexecutor.h:60]: (performance, inconclusive) Technically the member function 'ThreadExecutor::addFileContent' can be static.
[gui/settingsdialog.cpp:239]: (error, inconclusive) Possible null pointer dereference: item
[lib/checkbufferoverrun.cpp:771]: (style, inconclusive) Reading from empty STL container
[lib/checkuninitvar.cpp:1025] -> [lib/checkuninitvar.h:86]: (performance, inconclusive) Technically the member function 'CheckUninitVar::analyseWholeProgram' can be static.
[lib/checkuninitvar.cpp:1031] -> [lib/checkuninitvar.h:88]: (performance, inconclusive) Technically the member function 'CheckUninitVar::analyseFunctions' can be static.
[lib/checkunusedfunctions.cpp:69]: (style, inconclusive) Boolean variable 'usedOtherFile' is used in bitwise operation. Did you mean '||'?
[lib/checkunusedfunctions.cpp:269] -> [lib/checkunusedfunctions.h:54]: (performance, inconclusive) Technically the member function 'CheckUnusedFunctions::analyseWholeProgram' can be static.
[lib/checkunusedfunctions.cpp:199]: (performance, inconclusive) Use const reference for 'called_from_file' to avoid unnecessary data copying.
[lib/checkunusedvar.cpp:537] -> [lib/checkunusedvar.cpp:533]: (style, inconclusive) Found duplicate branches for 'if' and 'else'.
[lib/cppcheck.cpp:423] -> [lib/cppcheck.h:156]: (performance, inconclusive) Technically the member function 'CppCheck::executeRules' can be static.
[lib/settings.cpp:219] -> [lib/settings.h:266]: (performance, inconclusive) Technically the member function 'Settings::platformFile' can be static.
[lib/templatesimplifier.cpp:616]: (style, inconclusive) Reading from empty STL container
[lib/tokenlist.cpp:966] -> [lib/tokenlist.h:129]: (style, inconclusive) Technically the member function 'TokenList::createAst' can be const.
[lib/tokenize.cpp:5874] -> [lib/tokenize.h:273]: (style, inconclusive) Technically the member function 'Tokenizer::simplifyStaticConst' can be const.
[lib/tokenize.cpp:5374] -> [lib/tokenize.h:432]: (style, inconclusive) Technically the member function 'Tokenizer::simplifyFunctionReturn' can be const.
[lib/tokenize.cpp:9772] -> [lib/tokenize.h:665]: (style, inconclusive) Technically the member function 'Tokenizer::simplifyMicrosoftStringFunctions' can be const.
[lib/tokenize.cpp:10519] -> [lib/tokenize.h:812]: (style, inconclusive) Technically the member function 'Tokenizer::setPodTypes' can be const.
[lib/valueflow.cpp:570]: (style, inconclusive) Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'?
[lib/valueflow.cpp:571]: (style, inconclusive) Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'?
[test/testmathlib.cpp:543]: (style, inconclusive) Technically the member function 'TestMathLib::isValidSuffix' can be const.
[test/teststl.cpp:1343]: (performance, inconclusive) Technically the member function 'TestStl::getArraylength' can be static.
[test/testsuite.cpp:230] -> [test/testsuite.h:67]: (performance, inconclusive) Technically the member function 'TestFixture::complainMissingLib' can be static.
[test/testsuite.cpp:248] -> [test/testsuite.h:74]: (style, inconclusive) Technically the member function 'TestFixture::warn' can be const.
[test/testsuppressions.cpp:178]: (style, inconclusive) Technically the member function 'TestSuppressions::runChecks' can be const.
[test/testtokenize.cpp:3170]: (style, inconclusive) Technically the member function 'TestTokenizer::line2' can be const.
```


I was just scared about performance if we have for example several packages. Also, thought about look of all this data in one widget. If we display it , it should be togglable


Added VolumeDown+Shake trigger


TeamCity Ybackend :: Feodorov/ybackend [Build 71](http://192.168.30.225:8111/viewLog.html?buildId=572&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


Use `system "#{bin}/xpstopdf", "--help"` instead of `system "#{bin}/xpstopdf --help"`


Looks great to me, so happy to see the first commit from another person, now this is no longer just my baby ;)


lululu


can you please put the configuration values into the OAuth2ProviderSettings class, and not use the config directly in this class?


Beim PHPDoc welches das gleiche ist wie die Basisimplementierung sollten wir lieber ein `{@inheritdoc}` schreiben


I had also seen that but because there is no need for thread safety, I had not changed it. But it's more c++ style to do it like that ^^


We should find a substition for no way, because that is rather spoken language: [no way!](http://jmichaeldolan.com/admin/uploadedimages/NO%20WAY%20no%20border.png).


TeamCity Ybackend :: Feodorov/ybackend [Build 71](http://192.168.30.225:8111/viewLog.html?buildId=572&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 6; exit code 1 Build time: 00:01:48


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 128](http://192.168.30.225:8111/viewLog.html?buildId=573&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


OK


Oh I did not see, it is ok.


Remove the space after the square bracket and use a newline instead:

```rb
args = [
  "--disable-debug",
  "..."
]
```

instead of:

```rb
args = [ "--disable-debug",
             "..."
]
```


That will need to be tested by everybody to make sure it is compatible with most environments (GCC/MinGW/MSVS)


Line is too long. [108/100]


We use a **lot** of functions with prototypes of the form:

    bool foo(<params>, T& r_retval);

The class of crash bug fixed in this commit can occur anywhere where we either:

* Set `r_retval` but return `false`
* Don't set `r_retval` but return `true`

This seems like exactly the sort of bug that we could check for systematically using static analysis. :wink:


But this is completely different, we're not talking about a models folder, we're talking about the models not polluting the root namespace


Yes you can change the default folder if you want but...

> Following framework conventions makes contributions easier
And it's true! If you make a package and you need to publish a model, you can't do that properly if the developper move your model on another directory.


Add a trailing comma here.


@opdenkamp - would this come handy at some point (i mean in mainline)? This allows to specify the GIT_REPO for testing with different upstream repos. Without that it tried to checkout the given revision from the already cloned repo (which was cloned from your github of course) and fail... - for mainline we would set the GIT_REPO to opdenkamp of course...


> FEATURE: TopicCreator now supports 'pinned_at' parameter
Thanks! Now I can add this to the phpBB importer. :-)


Nice cleanups. We can see how much you like the const keyword ;-)


it would have been handy, but now this PR has been created https://github.com/xbmc/xbmc/pull/6227 ;-)


I wouldn't use a flag value of UNKNOWN, as it will cause all sorts of pain with URL parsing in the Enrichment. If it's not set, "" or null leading to the parameter being stripped off the querystring should be fine...


TeamCity Ylab :: Feodorov/ylab [Build 56](http://192.168.30.225:8111/viewLog.html?buildId=571&buildTypeId=Ylab_FeodorovYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:11:52


TeamCity Ylab :: Feodorov/ylab [Build 57](http://192.168.30.225:8111/viewLog.html?buildId=574&buildTypeId=Ylab_FeodorovYlab&guest=1) is now running


hmpdate.img is not a root filesystem image. It is a u-boot script with binary blobs appended to it created with mkimage.


Is this feature documented?


@fblundun - could you explain the process the JS Tracker follows to get the page URI and the referer off the DOM? Fallback values (if any) etc


That forum post gets quoted a lot, but everything else in Laravel has a specific place it starts out. This includes nesting Controllers and Console Commands in Http and Console to keep them separate. Models however start off in the global namespace... it doesn't really fit.


"We tried to open the project in {} " in both, "but it seems that it no longer exists" in the second.


Could be `https://cdnjs.com/libraries/lodash.js/`


Fixed this potential null pointer crash while at it.


io.js v1.0.3 is out already! :P


Space before opening parenthesis


@tochev Мисля, че на този ред трябва да е `cp cont/$c/...`, а не `host/$c/...`. Ще го оправя.


what are the pre-requisites to perform mobile testing using appium and selenium script on sauce labs?


I guess the easiest would be to add a boolean class member.
Note to self: do not forget to clear it in GameMap::ClearAll


Space before opening parenthesis and curly brace on next line


a_zero is always false here


Hipsters flee


Space and align with upper line first argument


Space before opening (


Can't we use `afterPaste`?


Ditto


Shouldn't we check this earlier? E.g. at the beginning of `init`?


Nope.. this is OK, as per the HTTP Specification: http://tools.ietf.org/html/rfc2617#page-5.

The UID and PWD is concatenated UID:PWD and then Base64 encoded. Therefore the issue is with Drools UrlResource not handling Basic Authentication correctly. I'll raise a JIRA.


Concerning the z-score cut-off, it is used because it is also a part of the calculation from the ETL (for instance https://github.com/transmart/transmart-data/blob/master/ddl/oracle/tm_cz/procedures/i2b2_mrna_zscore_calc.sql#L346). Maybe it's not  optimal but I think it's better to be coherent between the two z-score calculations.

Concerning your observation about standard deviation I understand the problem. Maybe in the case of z-scores calculated on the fly the standard deviation could be calculated from log-intensity, but in the case of pre-calculated z-score it would still be a problem.


i should change this udelay(100); to 50 in file pm-8x60.c at line 993


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 128](http://192.168.30.225:8111/viewLog.html?buildId=573&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 6; exit code 1 Build time: 00:11:00


TeamCity Ylab :: zmactep/ylab [Build 160](http://192.168.30.225:8111/viewLog.html?buildId=575&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


@bors: retry
* #3228


update_sqlite_coverage (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.49%25-red.svg)


I think the idea is that for simple models, like a User, you can put them
in the App namespace. Once your model gets larger, you can create App\User
and put the model, its repository, presenter, events and the like in there
in order to bundle 'domain models'.

On Tue, Jan 20, 2015 at 10:35 AM, Stephen Rees-Carter <
notifications@github.com> wrote:

> That forum post gets quoted a lot, but everything else in Laravel has a
> specific place it starts out. This includes nesting Controllers and Console
> Commands in Http and Console to keep them separate. Models however start
> off in the global namespace... it doesn't really fit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/framework/commit/cb1142897be11c59b374340fa0826408b13b9f55#commitcomment-9352566>
> .
>


What do you think about the new solution?


Xoá log này đi


LOL.


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/e239bd964421045a9c339caa89ee1b9216fc1889


merging Ms2ger/servo/doc-js = e239bd96 into auto


Great catch, @maedoc !


Ms2ger/servo/doc-js = e239bd96 merged ok, testing candidate = 0b890902


I’m not so sure it won’t break the regular DB import. Though, I’ll implement this in a completely different way I think like I did in another app.


:+1: I have no idea about this stuff, but since it doesn't touch anything else, I'm happy to include it :-D


its not working: http://pastebin.com/EUeRkg7Z


:+1:  bloody helpful!


TeamCity Ylab :: Feodorov/ylab [Build 57](http://192.168.30.225:8111/viewLog.html?buildId=574&buildTypeId=Ylab_FeodorovYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:12:12


Is this really the way to go from a response to a public key? This code looks very cumbersome.
Have a look at https://playframework.com/documentation/2.3.x/ScalaWS and use the `.getStream()` method instead.


如果要改这里, 请连同 contents 一起改.


doesnt work: http://pastebin.com/EUeRkg7Z


intuitively, it seems like groups should really live at the libtextsecure level. there's nothing about groups in the axolotl spec.


Sync with TMRh20 sources


Hello @natilivni ,

In the JS Tracker, the `locationHrefAlias` variable corresponds to the page URI and the `configReferrerUrl` variable corresponds to the referer: https://github.com/snowplow/snowplow-javascript-tracker/blob/master/src/js/tracker.js#L96-L99

The `getReferrer` function is used to get the referrer: https://github.com/snowplow/snowplow-javascript-tracker/blob/master/src/js/lib/helpers.js#L87-L114. If it fails, it just returns an empty string. Note that if there is a "referrer" or "referer" parameter in the querystring, its value will be used as the referrer.

The `fixupUrl` function is used to deal with cases where the page is cached or translated: https://github.com/snowplow/snowplow-javascript-tracker/blob/master/src/js/lib/proxies.js#L84-L99

The `purify` function is used to remove the fragment: https://github.com/snowplow/snowplow-javascript-tracker/blob/master/src/js/lib/helpers.js#L87-L114

There are also API methods allowing users to set the URI and referer manually: https://github.com/snowplow/snowplow-javascript-tracker/blob/master/src/js/tracker.js#L817-L833

Does that all make sense?


Add shebang


@charlotte-raillere Yeah, this is a bit confusing. Next time, do `git rebase master` rather than `git merge master`. For reference, this is the [diff between master and the head of this PR](https://gist.github.com/cataphract/992961ccc4a032cb580e).


TeamCity Ylab :: zmactep/ylab [Build 161](http://192.168.30.225:8111/viewLog.html?buildId=576&buildTypeId=Ylab_ZmactepYlab&guest=1) is now running


Are these specs correct? Choosing a start date and an end date (e.g. 2014-07-01 and 2014-07-03) should return events for those 3 days and not 6 weeks as it says in the documentation.


Changed this version to make use of item_exists, load_file_content and save_file_content, introduced in the last merges


od, xxd, hexdump 这几个外部命令都可以方便的找到 7f45 的位置，您的环境有哪个命令？
od和xxd都是主流发行版默认安装的命令，通用性比较好。


You're totally right, I was hesitating at first but I shouldn’t have used static struct at the end though it takes less codes.

I will implement your solution as soon as I have time.


Yes, this could be just "pass = true;" instead (and the compiler will probably optimize it to that). I wrote it as is to clarify the operation.


Responsive table from http://zurb.com/playground/playground/responsive-tables/index.html


Thanks!


Fixes with reference to https://github.com/pwmvx1289/fossasia10/commit/ca6627880298b3b1e8ae0e61c86f05e7cf70e8af#commitcomment-9352870


TeamCity Ylab :: zmactep/ylab [Build 160](http://192.168.30.225:8111/viewLog.html?buildId=575&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:11:49


TeamCity Ylab :: Feodorov/ylab [Build 58](http://192.168.30.225:8111/viewLog.html?buildId=577&buildTypeId=Ylab_FeodorovYlab&guest=1) is now running


Yes, I just able to complete it on virtual machine:
make -j4 oracle
The trick in using "/" in jdbc url for PDB, instead of ":" for SID which refers to CDB


I had a look yesterday but couldn't really decide. Initially I liked that it would limit the growth of checksum files to the number of new allowed folders.

One of the issue with the proposal is that the user loses authorisations in the past. The authorisation is just used to make sure no rogue code is executed, if it was valid in the past it is probably still valid. In a scenario where the `.envrc` file is checked-in in a git repository and the user wants to do a `git rebase` or `git bisect`, it would force him to re-run `direnv allow` whenever the `.envrc` changes, even if the `.envrc` was allowed in the past. The proposal makes it less convenient.

When developing the feature my thought was that an empty filename is cheap, the size of the inode + 64 bytes for the filename, and disk is cheap. I also knew that at some point we might hit a limit on some filesystems of number of files per directory (this can be solved by partitioning the files in sub-directories like git). As one of the first direnv users I currently have 225 files in the allow folder and am happy to keep ignoring the cruft that is building up until I hit that limit.

So in conclusion I don't mind adding the filename inside of those allow files, it is going to make the storage a bit more expensive but I see how that could be useful. I still want to keep the old checksumming though. That's my current thought, which can be changed with arguments :)


What about [two word](http://slack.com) [links](https://slack.com/)


fast-forwarding develop to borshop-integration-1053-bugfix/suppress-unnecessary-warnings = 7bb560ae


@smarquespt In Portugal Portuguese is incorrect although some people use it.
What flavour do you speak ?


Ne refreshuj-e companyChecklist.tpl.
Forma se ne refresh-uje, tako da ovo nema nikakvog uticaja.
Location.reload() ne radi nista jer se dobija isti slucaj kao i iznad.


@mwjames :)


this will show a compile error in quartus.


This `writing` parameter doesn't seem to be configurable anywhere and can probably be removed.


Either use function name { or name() {

But not both.

I prefer the latter.


why?  This is straight declaration, no need to wrap it in a function.


What? That's allright. Normal event emitter has that aliasing inside.


@nebukazar
Thanks, I'll move it to the top: https://github.com/ccd0/4chan-x/commit/b6d3f739513b75a87fc2550a362dcd96878754c2


You have slightly misunderstood this. You don't need to import anymore than one command. Its just to get the path to the commands.


I played with this a bit with different zoom levels.

I think we can go a bit further out than `16`.  There is still about 1px of space between most blockfaces in our test data at zoom level `14`.

We could also make the map monochrome at higher zoom levels.
You can still make out the street lines (but not each side of the street) at `12`.

I'm worried about having the maps look "broken" if there are no blocks shown at the highest zoom level.
Can we restrict the minimum zoom level of the map as whole to be the minimum level we show for our layers?

That said, this is a tricky UX problem to solve.  It's probably fine if we make an issue to take care of this in a future PR.


Do you ever expect to call this more than once per docker-admin run?  If not, don't make it a function.


Check your code please.


@PILO7980 ^


:heart:


But this one is not my latest file. The correct one is on the pull request: https://github.com/lxde/lxqt-powermanagement/pull/9


This line especially. If you had tested the command you would find that this simply wouldnt work.


Looks good.


< What flavour do you speak ?

I´m sorry but I don´t understand your question.


This can be a constant.


listAllRelationTypes();


`assets_uri_base` and `assets` can also be constants.


New what about [two word](http://slack.com) [links](https://slack.com/)


It probably does if you did `.aggregate(Sum(Value(1)))`, yes. Don't have much time today, if you wouldn't mind adding a ticket? If not, I'll do so later or tomorrow.


Teh Failz


We don't really have a use for ALL ALL locations, that I can think of.


Thanks, I think we had that already, I always forget that.


You cannot use "empty" Entities to create a RelationType.


Grammar error


Create a helper method to catch the exception message.
errorOnCreateRelationType(... message)


We talked about never showing a zoomed out map, since we can't show meaningful progress and features are not tappable. The trick is deciding where to set the initial location. We will never be showing a blank map in the shipping application, but I do think this is a bigger UX question that is outside the scope of this PR. Part of shutting it off the low zooms was to start the discussion of how to address them.

I will revert the ``minZoom`` and restore it in a future PR when we have a real answer.


Assert that default cardinalities are ONE.


Don't add extra boolean. You should have every info encapsulated in `input`


@smarquespt The word "voltagem" comes in the dictionary, yes. Some people began translating "Voltage" to "Voltagem" because the word is similar. But nevertheless the correct word is "tensão" or "tensão eléctrica".
In Brazil the use of "voltagem" is correct.
I reviewed the new pull. Voltagem is the only pending "issue"


Use constants for String literals.


#include <stdio.h>


Well, how can I add an external form controller in the application directory? I tried, but it doesn't work.

application/blocks/external_form/controllers/my_form.php

```
<?php
namespace Application\Block\ExternalForm\Form\Controller;

use Concrete\Core\Controller\AbstractController;

class MyForm extends AbstractController
{

    public function action_test_search()
    {
        $this->set('response', t('Thanks!'));
        return true;
    }

    public function view()
    {
        $this->set('message', t('This is a great form.'));
    }
}
```


Don't need condition. Just always have that stage.


What about a simplified map when zoomed out? Like hunchlab style tiles which may be the average "color" of the features within that square?


Can't this just be `rsync -avP --delete  "elasticsearch-$current/config/" "config"` (untested)?


Add a test that throws an exception for an unidirectional RelationType with reverse name.


Why was this "unnecessary"? Now the immediate instructions return non-sensical results because they use whatever register number the compiler chooses as the immediate value, instead of the value specified in the code.


Why not `for field_name in fields`?


Fine. At the time I can´t do a rebase. If you don´t mind please change it to "Tensão" to close this pull request.


I don't see any benefit in the self type. I think it's actually more confusing.


Create a bidirectional RelationType with reverse name. Everything is ok.


Need a single echo to make an empty line between maintainer and content lines.


It is not a URL, it just seemed like the most reasonable way to specify the auth type, username, and password, in a single environment variable/string.


This is a bit ridiculous.  These should be static methods.


What about [two word](http://slack.com) [links](https://slack.com/)


debugger statement left in


i.e. this should be `object functions`.  There's not a good enough benefit in having these merged a.l.a cart vs. a method delegate.


Thanks Tyler!


`assets_uri_base` can be a constant.


What about [two word](http://slack.com) [links](https://slack.com/) `asdf asdfas` asdfasdf ```adsfas```


Yes, but this is the wrong commit for these lines.


comentário


Ah, I was actually thinking about that when I saw that you were trying to get the hash from somewhere else. Can you tell me from what version of ember this did change, so that I can change a bit my code and handle the previous versions too?

Anyway, the issue with the `on='submit'` remains ;-)


That may work, and is an option to bring up in the discussion. There are a pile of other features to create which may force a clever visualization to take a back seat.


1. naming convention from the [relevant rfc](https://tools.ietf.org/html/rfc2617#section-3.2.2.2)
2. typo, should actually be HA1
3. honestly I couldn't think of what else to call it at the time.


name switch


We should probably pin a version here since that is what we advocate (even though we are pinned by the repo above).


SL_PM_AUTH was taking from the feature request issue, easy to change.

Specifying the credentials in the URL is problematic because there's no way to specify the auth scheme as part of the URL.


This should be `broker[:version] || 'latest'`.


Thanks, Fixed it.


No we aren't (it's only /1.4/), so pinning here is necessary. ;)


Can't we just add something to `ENV PATH`?


Any time the Board changes size, calling this method will fix all of the Pieces. The problem is making sure to call this every time from TicTacGoGameActivity


@Wild1145 It doesn't work because I forgot to change the utils file. I edited the utils in my IDE. Is that the only thing not working? (I tested the command, it works, and it does disable WE)


This is sufficient to get the correct sizes assuming that the dimensions of the Board are the same landscape and portrait. That is currently the case, but it may not always be.


Dislike this change :P


@dweeezil while reviewing the outstanding pull requests I noticed this SA fix is still outstanding.  The fix itself looks good to me but I wanted to refresh your memory on this, and get @nedbass who's more familiar with this code to weigh in before I merge it.  Certainly what's it's doing now looks wrong because it will leave an undefined gap in the new SA buffer.

It might also be nice to pull this fix out in to its own pull request so it can be retested.


Being too slow is a temporary condition that we hope to improve.  In the long term uploads will mainly be for replays that we don't have/can't get.


Yeah, True -- I am creating the initial user and then attempting to create a user with the same username expecting an error. i wasn't sure how to do it, otherwise.


Hey @nblackburn, I think you’re missing a “<” in “For example `div id=\"my-paddle-product\"></div>`”.


Why does this end with `+1`?


This commit add the unnecessary dependency to Drools. Could you replace `org.drools.util.StringUtils` with `org.apache.commons.lang3.StringUtils`?


Also fixed bug in Pair. Commit is not limited to Javadoc either.


This async.each never calls it's callback. The async.forever clause at the end of this sequence goes into an infinite loop on the `detroit 1


TransOption (macumber) - i386-Windows-7-VisualStudio-12: OK (2180 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


This is the callback that is never called causing the beforeEach on the test to timeout.


To make the line below evaluate to `static const size_t kHeapStatisticsBufferLength = +1+1+1+1+1;`


Are there cases where we don't want a git accessor? Should there be?


see #1443


John and I couldn't think of a good reason either, so I think he ended up just removing that bit altogether.


This proved necessary on a standard Ubuntu 14.04 install, otherwise /var/log/mail will show:

```NOQUEUE: reject: RCPT from localhost[::1]: 454 4.7.1 <user@example.com>: Relay access denied; from=<notifications@cyclescape.example.org> to=<user@example.com> proto=ESMTP helo=<localhost.localdomain>```

because v6 is enabled in the OS, and that localhost appears to resolve to the v6 address, but isn't permitted to relay (it's not in mynetworks).


Having trouble finding the stripe equivalent here. Looking at the API docs (https://stripe.com/docs/api#charge_object) it looks like there is just a "paid" boolean and not a proper status.


This is a bit frustrating but will get there eventually


:+1: Thank you @akr!!! <3 <3 <3


Fixed, thanks @adamschwartz.


Why is this a simplification? This is almost a tuning patch, and not reducing any code.


I think you can remove this line too, as `network` is already mentioned below.


Maybe? Was the a specific place you saw that was questionable?

- Eric && Frank

On Tue, Jan 20, 2015 at 4:33 PM, Andrew Bruce <notifications@github.com>
wrote:

> Are there cases where we don't want a git accessor? Should there be?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cloudfoundry-incubator/bookbinder/commit/bc90d6138b979f2c45821676b02baa12365bba1b#commitcomment-9366948>
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "Pub Tools" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to pub-tools+unsubscribe@pivotal.io.
> To post to this group, send email to pub-tools@pivotal.io.
> To view this discussion on the web visit
> https://groups.google.com/a/pivotal.io/d/msgid/pub-tools/cloudfoundry-incubator/bookbinder/commit/bc90d6138b979f2c45821676b02baa12365bba1b/9366948%40github.com
> <https://groups.google.com/a/pivotal.io/d/msgid/pub-tools/cloudfoundry-incubator/bookbinder/commit/bc90d6138b979f2c45821676b02baa12365bba1b/9366948%40github.com?utm_medium=email&utm_source=footer>
> .
>


Awesome. Just approved Paddle. :+1:


Jordan's comment


is this needed


Just the removal of the ArgumentError.


Implements #2


Gonna go read up on web server stuff. I have no idea what I'm doing,


Oh, hah. Didn't see that.


So, why these options? Is gzip unnecessary for ATV and local? Does it create problems in some situations? I guess I am asking what the best setting would be in an ideal situation?


Hah, yes. I'll take a look.


@mmoayyed , while the doc root pages are there, (API Docs) Trying to follow the links results in 404.


```javascript
function fancyAlert(arg) {
  if(arg) {
    $.facebox({div:'#foo'})
  }
}
```


cookies有个del方法啊


Hm, that’s probably a legitimate concern for things like `Result::unwrap` which require `Show` (and soon will require `String`, which will probably increase the frequency of these errors). I wonder if just changing the last bit to ‘try using `:?` instead **if you are using a format string**’ or something similar would be enough.


4626-rhoCp_soil_calc_bug (mmatts) - i386-Windows-7-VisualStudio-12: OK (1586 of 1591 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69%25-yellow.svg)


Hi @infocortex, thanks a lot for this PR!

Could you point me to the corresponding dataset on which `self.first_level` was incorrectly set to `true`? In theory, I thought we should be able to determine if the study is a first or second-level from the fsf file and I would like to check what went wrong.


Gotta love that late night coding.


Whoops, I was just copying the doc comment above. Mind if I change that in this PR at the same time?


We don't want anyone should being able to create a git_hub_repository without a git_accessor. Was raising the error a way of enforcing that? Was it for that purpose?


Isn't that the other test you have below, where you create a user with the same dupeUserName? This one looked more like an accidental copy/paste.


Looks like you'll need to normal, state and mode from
```
  "object": "charge",
  "created": 1421801047,
  "livemode": false,
  "paid": true,
  "amount": 2800,
  "currency": "usd",
  "refunded": false,
  "captured": true,
```


Ok so I just talked to `mmum` on IRC:
```
07:40 huafu: hi! does anyone knows/remembers around which version of EmberJS the hash in helpers wasn't anymore accessible directly as a parameter, but as a property (hash) of options parameter?
07:42 huafu: I menat in handlebars helpers
07:43 mmun: in handlebars/handlebars 2.0 hash is in options
07:43 mmun: in htmlbars hash is a helper argument
07:43 huafu: mmun: thanks, so it is not dependent of EmberJS but handlebars version right?
07:44 mmun: huafu: correct - in 1.10 we switched to used HTMLBars BUT we also wrapped the behaviour so that your old helpers continue t owork
07:44 huafu: how can I make a if for that?
07:44 mmun: and by we i mean rwjblue
07:44 huafu: mmun: hmm, so how should I get the hash from an helper so that it is compatible with any version?
07:44 huafu: ;-)
07:45 mmun: just write your helper the old way
07:45 mmun: it will work in all versions
07:45 huafu: so getting my hash with arguments[arguments.length - 1] ?
07:45 mmun: .options
07:45 mmun: er .hash
```

So this code is ok to get the hash ;-)


`ContentEquals() already checks reference equality, so you don't really need to `==` check.
http://source.roslyn.codeplex.com/#Microsoft.CodeAnalysis/Text/SourceText.cs,dc290adccf6f9ba7


Yup.


test it out :-)


Ah interesting, I've never thought of doing that in constructors as a way of enforcing proper dependency construction. Yah, we could put that back in.


4626-rhoCp_soil_calc_bug (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1095 of 1095 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.89%25-green.svg)


may want to fix this


```javascript
function fancyAlert(arg) {
  if(arg) {
    $.facebox({div:'#foo'})
  }
}
``` Post text


Done in https://github.com/dkorolev/Bricks/commit/ebddd78c49b9d910bc4aeb4ddbb223ab811b4b3e, please see https://github.com/KnowSheet/Bricks/pull/49.


Agreed. Being warning clean matters more!


@u8sand
preferencesdialog.ui:
- `[ CHANGE ]` button is enabled only if item is selected.
- `[ RESET ]` button will warn the user before continuing "Are you sure you want to reset the shortcut keys to original bindings?" (YES/NO).

keydialog.ui (NEW):
- Depending on which button the user pressed under the Keys tab in `preferencesdialog.ui`, either `[ CHANGE ]` OR `[ ADD ]` will be shown (not both).
- keySequenceEdit and commandLineEdit needs to be filled in before `[ ADD ]`/`[ CHANGE ]` button is enabled.
- If user tried to change/add a shortcut that already exists, display messagebox "{Shortcut} is already being used. Input a shortcut that is not already being used.".


Multibit steel my money , in my balance apear real 303$ and in blockchain money are in a error adress called : 1FYMZEHnszCHKTBdFZ2DLrUuk3dGwYKQxh
Please i want my money back , i dont have any fault . my adress is 1rzhWUU7LP9iyyeas4hT223kogqy6w67G , you can see that are 6 transaction and no one of this is confirmed by me .
Please help me
And i cant generate private key , multibit dont let me .


Added Ben Han's dining hall preference


Hi. Did you add yourself to the contributors.txt file?


@josh Great!!!


A send to a buffered channel will block if the channel is full, which means you can invert the use of the spaces in the buffer.  If you can put, then you can proceed.  This code normally looks like

```go
type limiter chan struct{}
func (l limiter) enter() { l <- struct{}{} }
func (l limiter) leave() { <-l }

var Limiter limiter = make(chan struct{}, size)
```
(from https://github.com/dgryski/carbonapi/blob/master/main.go#L257 )


wegen speed?


Hi @afh, this commit makes the compilation with makeinfo to fail. I am on Debian stable, with texinfo 4.13, and error message is below. If I remove "@c option", then this can compile successfully. This is problematic as I cannot compile anymore the documentation, and I am a frequent contributor.
I understand that you did this change to be able to check if documentation is up-to-date. Is there any other way to do that ?
Could you adapt your tool so that it can run on syntax proposed just below? With "@c option" on just next line?

    +@item --help
    @c option
    @itemx -h````

Thanks
Thierry

$ git checkout next
Already on 'next'
~/dev/ledger/doc$ LANG=C makeinfo ledger3.texi
ledger3.texi:4: @include `version.texi': No such file or directory.
ledger3.texi:5448: @code missing close brace.
ledger3.texi:5444: @code missing close brace.
ledger3.texi:5440: @code missing close brace.
ledger3.texi:5436: @code missing close brace.
ledger3.texi:5432: @code missing close brace.
ledger3.texi:5428: @code missing close brace.
ledger3.texi:5522: @code missing close brace.
ledger3.texi:5518: @code missing close brace.
ledger3.texi:5514: @code missing close brace.
ledger3.texi:5510: @code missing close brace.
ledger3.texi:5507: @code missing close brace.
ledger3.texi:5504: @code missing close brace.
ledger3.texi:5501: @code missing close brace.
ledger3.texi:5497: @code missing close brace.
ledger3.texi:5493: @code missing close brace.
ledger3.texi:5489: @code missing close brace.
ledger3.texi:5485: @code missing close brace.
ledger3.texi:5482: @code missing close brace.
ledger3.texi:5478: @code missing close brace.
ledger3.texi:5475: @code missing close brace.
ledger3.texi:5471: @code missing close brace.
ledger3.texi:5467: @code missing close brace.
ledger3.texi:5463: @code missing close brace.
ledger3.texi:5459: @code missing close brace.
ledger3.texi:5546: @code missing close brace.
ledger3.texi:5541: @code missing close brace.
ledger3.texi:5538: @code missing close brace.
ledger3.texi:5534: @code missing close brace.
ledger3.texi:5649: @code missing close brace.
ledger3.texi:5638: @code missing close brace.
ledger3.texi:5634: @code missing close brace.
ledger3.texi:5631: @code missing close brace.
ledger3.texi:5627: @code missing close brace.
ledger3.texi:5624: @code missing close brace.
ledger3.texi:5620: @code missing close brace.
ledger3.texi:5617: @code missing close brace.
ledger3.texi:5611: @code missing close brace.
ledger3.texi:5607: @code missing close brace.
ledger3.texi:5603: @code missing close brace.
ledger3.texi:5600: @code missing close brace.
ledger3.texi:5597: @code missing close brace.
ledger3.texi:5594: @code missing close brace.
ledger3.texi:5590: @code missing close brace.
ledger3.texi:5586: @code missing close brace.
ledger3.texi:5583: @code missing close brace.
ledger3.texi:5579: @code missing close brace.
ledger3.texi:5576: @code missing close brace.
ledger3.texi:5572: @code missing close brace.
ledger3.texi:5568: @code missing close brace.
ledger3.texi:5564: @code missing close brace.
ledger3.texi:5560: @code missing close brace.
ledger3.texi:5556: @code missing close brace.
ledger3.texi:5686: @code missing close brace.
ledger3.texi:5683: @code missing close brace.
ledger3.texi:5679: @code missing close brace.
ledger3.texi:5676: @code missing close brace.
ledger3.texi:5672: @code missing close brace.
ledger3.texi:5668: @code missing close brace.
ledger3.texi:5664: @code missing close brace.
ledger3.texi:5660: @code missing close brace.
ledger3.texi:5723: @code missing close brace.
ledger3.texi:5719: @code missing close brace.
ledger3.texi:5715: @code missing close brace.
ledger3.texi:5711: @code missing close brace.
ledger3.texi:5708: @code missing close brace.
ledger3.texi:5704: @code missing close brace.
ledger3.texi:5700: @code missing close brace.
ledger3.texi:5697: @code missing close brace.
ledger3.texi:5817: @code missing close brace.
ledger3.texi:5813: @code missing close brace.
ledger3.texi:5810: @code missing close brace.
ledger3.texi:5807: @code missing close brace.
ledger3.texi:5771: @code missing close brace.
ledger3.texi:5768: @code missing close brace.
ledger3.texi:5764: @code missing close brace.
ledger3.texi:5761: @code missing close brace.
ledger3.texi:5755: @code missing close brace.
ledger3.texi:5947: @code missing close brace.
ledger3.texi:5942: @code missing close brace.
ledger3.texi:5933: @code missing close brace.
ledger3.texi:5924: @code missing close brace.
ledger3.texi:5921: @code missing close brace.
ledger3.texi:5915: @code missing close brace.
ledger3.texi:5912: @code missing close brace.
ledger3.texi:5884: @code missing close brace.
ledger3.texi:5873: @code missing close brace.
ledger3.texi:5867: @code missing close brace.
ledger3.texi:5863: @code missing close brace.
ledger3.texi:5860: @code missing close brace.
ledger3.texi:5855: @code missing close brace.
ledger3.texi:5851: @code missing close brace.
ledger3.texi:6641: @code missing close brace.
ledger3.texi:6637: @code missing close brace.
ledger3.texi:6633: @code missing close brace.
ledger3.texi:6629: @code missing close brace.
ledger3.texi:6625: @code missing close brace.
ledger3.texi:6620: @code missing close brace.
ledger3.texi:6615: @code missing close brace.
ledger3.texi:6611: @code missing close brace.
Too many errors!  Gave up.
Too many errors!  Gave up.


Sure, no problem. Will do that and send a new pull request.

I do feel the need to explain that I had he same reservation, but I added this dependency because the issue from which this was cloned was fixed by this exact same code. Since that was already approved and pulled into mainline, I figured it would be more consistent to stick to that solution.


great! thanks for this


For non-MSVC you ended up not including getopt at all! Proper fix in 7a8880ae.

From pp.c in JtR tree, you can compile a "standard" stand-alone pp using this line:
```
$ gcc -W -Wall -std=c99 -O2 -s -m64 -DLINUX -o ../run/pp64 pp.c -DAC_BUILT
```
...and in that case we must not introduce dependency on other object files (for debugging/merging reasons).

Within a normal JtR build though, getopt.h is not even needed!


Está a Funcionar a Sessão. Apenas não está a funcionar correctamente quando se faz Redirect que é necessário verificar...


I think we also need tests for
1. last entered room is at the top of the list
2. duplicated entries get removed
3. the size of the list is limited to 10


Same slice issue here?


Make 10 a constant var?


Neat. Thanks!


yep


Could also be `expected[expected.length - 1]` or `_(expected).last()`


Exposing the promise publicly just for testing seems suboptimal. How about taking a callback param in the ctor, to notify the caller with list loading is done?


Concerned at all that this will show up in commit history?


What is the added dep on Scala for? (The jUnit I totally get, but the Scala escapes me...)


Just curious where in the TRM is this long of a delay needed?


As far as I can see this is the only place that a `ConnectAttempt` is constructed.  So with the newly added (preceding) guard we should never construct a `ConnectAttempt` with `slot_ == nullptr`.  That may be sufficient to mask the issue at hand, so the occurrence drops from hours to years.

Is it worth `assert`ing that `slot_ != nullptr` in `ConnectAttempt`'s ctor?


Yup, in the next pull I (mostly) revert this, with some changes. For review sanity, I havent included it here.


It looks like this is in the `validatePairs`  helper which is used beyond just removal. Maybe "ensure we are updating the amount of our little rects [etc]" so its a bit more generic


Just curious: what was the motivation to change to [flexjson] from [gson]?


What about [two word](http://slack.com) [links](https://slack.com/)


@ns827 초크님이 틀을 안잡아주셔서..ㅠ


음.. 그냥 커밋에는 마일스톤을 붙일 수 없는 것 같네요. 이슈에 등록하고 해결처리 부탁드립니다.
https://github.com/disjukr/jews/issues?q=milestone%3A%220.9.0+release%22+is%3Aclosed
여기서 릴리즈에 반영될 것들을 확인하고 있는..=3


This simple constructor is probably a good idea, vs. the more complicated one I have. But did you just like the code style, or is this required for the JSON bizniz? (Or some other reason?)


I goofed this and added it to the wrong file but I don't see any way to cancel my commit request...


@jagtalon This was already done [with CSS]( https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/share/spice/whois/whois.css#L31). Although this is probably best practise.. :smile:


Hi @sergiuionescu,

Your suggestion makes more sense then a simple directory.
```
root@application01:/etc/php5# find . | grep opcache
./mods-available/opcache.ini
root@application01:/etc/php5# php5enmod opcache
root@application01:/etc/php5# find . | grep opcache
./mods-available/opcache.ini
./cgi/conf.d/05-opcache.ini
./cli/conf.d/05-opcache.ini
./fpm/conf.d/05-opcache.ini
root@application01:/etc/php5# php5dismod opcache
root@application01:/etc/php5# find . | grep opcache
./mods-available/opcache.ini
```


Good one =]


@nherment How do you set expire when calling the save() method?


Will deploy to beta.docs.silverstripe.org so we can test.


Please add a && yum clean all here to remove the yum cache from this layer.


Did you mean `sub`?


They are actually not compatible


commit summaries should be present tense. "add syllabus" not "added syllabus" ;)


Any reason this test case was removed?


Whould this method be clearer if (re)named to [getBoard]? Even then, the [get***] prefix bothers me. It's nothing close to a simple getter. In fact, the object returned isn't "accessed" by the getter, rather a newly constructed [Board] object is returned every time, initialized to the values within the JSON model. This _might_ be okay, if the [Board] was immutable, so that the returned boards would always be [equal()], even though never the same instances. Yet, since they _are_ mutable, using a getter name convention seems (slightly) smelly.


Aha! Here's where you need the private "simple" constructor. As I suspected, to support conversion from another representation. Good.


Domain restriction via [Meteor Docs](http://docs.meteor.com/#/full/accounts_config).

Is there a way to do this with a friendly rejection for non-authorized domains?


This should be an exception when the string value is not convertable.


Yes.  Explicit is better here.


No, there are three things now:

    ImportElement: ImportTypeElement | ImportObjectElement | ImportFunctionValueElement


stray print?


LGTM


Now what about [two word](http://slack.com) [links](https://slack.com/)


These are new unique keys for the newer client


Well, for my own sanity, because going back and reordering commits is a PITA when they depend on each other.


Isn't this already in master https://github.com/silverstripe-labs/silverstripe-behat-extension/commit/6f648a418ae8580ce7c73640fd6153c76f7c2387


We used the latest revision e0441d0c6b8b
<https://code.google.com/p/tesseract-ocr/source/detail?r=e0441d0c6b8b3999327422cc1be38efba3cf754b>
from Tesseract official repository. We can't release it yet since it's
still in beta.

We're considering a release with tesseract 3.03RC, which is already
available in Linux but not officially for Windows.

On Mon, Jan 19, 2015 at 12:46 AM, Conny Kreyßel <notifications@github.com>
wrote:

> @nguyenq <https://github.com/nguyenq> Can you tell me what src base you
> use for "tesseract 3.04"? I dont see any tag/branch for 3.04 in tesseract
> src repo at google code.
>
> Do you think you can release it now?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nguyenq/tess4j/commit/1926a26067187814a55b17971b93984d36c5eb41#commitcomment-9334496>
> .
>


Again, wondering why-for the Scala dep? And what about jUnit - is this project untestable? _{smirk}_


Rule of silence.


Why do you need the builder as a param?


用 `filter-branch` 把密码从代码树里删掉啦 (三A三)


pre code
```javascript
code looks``` post code


Not sure if I should change the MAINTAINER line, but don't want to loose the connection to the original work.


Kitty,
I think there might be a problem with the anvil names when they are placed in a specific direction. The id of a copper anvil is either 226:1 or 226:9, I think the 1 and 9 designate the direction the anvil is facing.

When the anvil is 226:1, the name is fine, when the anvil is 226:9 it shows tile.Anvil.name.

It seems to happen with all the anvils.


sp after comma


The name suggests it should it be testing `sub` too...


Why is init.qcom.rc.orig necessary?


Generally, this looks fine. I did drop a few scattered line-comments, but nothing major. If you push as is, I would be fine.

Ummm... so do I just say "Okay, you can push" or "Okay, I'm gonna pull"? In the meantime, I'm choosing the no-action-on-my-part route, unless/until you tell me otherwise.


Sorry, I mean you use the commercial version or the academic version? cause we want try free software or open source.

IBM ILOG CPLEX Optimization Studio provide 3 Preview Edition Trial in http://www-01.ibm.com/software/websphere/products/optimization/cplex-studio-preview-edition/, the 1st Preview edition can not handle your window fusion work through my experiments, so I want to know whether Academic Initiative version work.


I've tested to set transport layer to `polling`, and it still returns `jwr` with io.sails 0.11.0. It's probably reliable enough to check if there's any errors through `jwr` object. But it certainly needs more test


rax retry tests


Je travail sur un socle de base pour la ou je bosse avec laravel. Mais on regarde pour passer sur la version 5 donc je continue mais surment dans une autre branche pour la 5


It doesn't look like that's the case anymore in latest master.


Definitely. We should reference the McPhee & Hopper paper from '99, and the MICS paper. The abstract needs to make sense on its own, though, without being able to read the rest of the paper (or read other, older papers), so we want to keep that in mind when finalizing the "real" abstract. It's not a huge deal here since I don't think they're actually going to care a lot about what we say, as long as it looks like we've got something we can turn into a paper.


![plot1 r](https://cloud.githubusercontent.co
![plot1 r](https://cloud.githubusercontent.com/assets/10055640/5829773/7d6ed810-a162-11e4-9715-4bcd2b2ac058.png)
m/assets/10055640/5829769/63ca1794-a162-11e4-8de6-787b1fc062de.png)


Shouldn't there be a part of the diff that removes the old binding?


We use the academic version.  In fact, we don't use CPLEX anymore, so
often, but instead use GALA.

On Tue, Jan 20, 2015 at 8:38 PM, merlinzone <notifications@github.com>
wrote:

> Sorry, I mean you use the commercial version or the academic version?
> cause we want try free software or open source.
>
> IBM ILOG CPLEX Optimization Studio provide 3 Preview Edition Trial in
> http://www-01.ibm.com/software/websphere/products/optimization/cplex-studio-preview-edition/,
> the 1st Preview edition can not handle your window fusion work through my
> experiments, so I want to know whether Academic Initiative version work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Rhoana/rhoana/commit/5ec4545eae0beb904910cfcc926428a9409896e6#commitcomment-9367496>
> .
>


Add log Hello World


Interesting! It sounds like you've definitely hit a bug, but unfortunately it's not puppet-gluster's fault. If you have a workaround, I'm happy to accept patches, however I think I have the solution for you:

Since puppet's fact isn't smart and is using ifconfig, then I think we should workaround that. I think the trick to getting it to show is to add labels to each VIP. I do this in my puppet-keepalived module. You should either use it (it *just works*) or instead emulate what I did. (Setting aliases is a standard thing.)

In other news ifconfig is deprecated. Since a long time!


@halostatue  this test case looks really funky -- are there any REAL use cases for that last argument to Apply? Or can it be removed?


Gambiarra interessante!


Thank you, the newest code with GALA is not pushed to github Rhoana?


`{0} - {1}`?


Certain interrupts can be masked; in the example from class, that applies to 32-255.  Masking an interrupt means that while that interrupt is "in control" of the processor, it can't be interrupted itself.
Other interrupt codes (0-31) can't be masked because they are reserved by the hardware.


why not inline this?


Now that you've committed it, this should not be the SECRET_KEY you use in production. See https://docs.djangoproject.com/en/dev/ref/settings/#std:setting-SECRET_KEY and http://stackoverflow.com/a/14786138/580947 for ways of doing this (you can pull it out of an environment variable or a config file that is not source controlled).


Bam


Do dis


can you give some clues or the website.


Can you share your colleagues code, as the code is not working on linux?


Hi, thanks for this!

First off, I noticed that Polish has no unit tests! Can you help me fix this?
It should be easy, just copy one from another locale in `test/environments/sugar/` . I suppose copying from `date_ru.js` would make the most sense? Being optimistic that Polish has similar test cases and also that you might read a bit of Russian to piece them together? But if not we can work it out together. Anyway if we can somehow get those test cases translated and add as many as you can think of to test the `relative` method, that would really make this a lot tighter.


You shouldn't need `+` here as `num` should be guaranteed to be a number at the point this method is called.


gives error:
Debugger entered--Lisp error: (wrong-type-argument listp 2)
  apply(call-process-region (170 633 "structured-haskell-mode" nil #<buffer  *temp*> nil "parse" "decl" . 2))


Why is this commented out?


Leftover debug?


Unrelated bugfixes like this are fine by me to push to master directly as you see them.


Good job!


How about `ostree_repo_is_remote` or something?  Both cases are http.


Leftover debug


Polling I/O relies on bits to define the current controller state using bits for busy and done states.  01 indicates that the controller is done, meaning it just finished a task, 10 is busy, meaning it is in the middle of completing a task, and 00 means that it's idle.
In order to use polling to determine when a device is free, there need to be while loops that continually poll until a device controller is in an idle state, which can be slow and inefficient.


I understand why you're doing this - it's faster to check up front, but I'm not entirely sure it's worth the duplicate code.  I'd like to get some sort of command line into ostree itself for this.  Something like `ostree fetch remotename` which only downloads the summary file, then `ostree refs -r remotename` ?


"Washington DC" wasn't in the SubCountries list; it kept making the tests fail. Is there a workaround?


Default python style doesn't have parenthesis here.


That `+` is for `num.toFixed(0).slice(-1)` not for `num`. If you would like to make it more explicit, you can change it to `Number(...)`.


Move hard-coded 360 to header (like `DAYS_PER_LYEAR`, etc).


You might want to change to fv.zero?


My apologies.

I followed the exact same notes as I did at work as I did just now when I got home. This time it worked like a charm first try.

At work, when I ran the git push heroku master command, the build would fail. I did configure a nodejs-grunt BUILDPACK. When I used the default BUILDPACK, heroku thought Strider was a ruby app and failed the build and deploy. It wasn’t until I removed this change in the dev.sh file that the app would deploy successfully.

Obviously, the problem was not in your dev.sh change.

Sorry about that. Thanks for the help though.

Peter

> On Jan 20, 2015, at 4:32 PM, Keyvan Fatehi <notifications@github.com> wrote:
>
> Hey Peter,
>
> That's great, but I was just referring to this file, "dev.sh" -- this should most certainly not be executed at all in deployment or on heroku... it's just a convenience script for npm link'ing the various other projects as git repositories so we can hack on multiple parts of strider as separate git repos easily while still having them in the npm dependency tree for strider.
>
> That said why would this file "dev.sh" would have any effect on heroku ?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Strider-CD/strider/commit/d203219ed24f8e0ab23289425250ae092de2c651#commitcomment-9366091>.
>


Can we call this `OSTREE_HOST` or something as `URL` typically refers to the whole thing.


Par šo jautājumu ir pretrunīgi norādījumi:
 - Lappuses numurē apakšā lapas vidū ar arābu cipariem, sākot ar lappusi, kas seko titullapai. (Prasības noslēguma darbu izstrādāšanai un aizstāvēšanai Latvijas Universitātē, apstiprināts 3.02.2013)
 - Lappušu skaitīšanu sāk ar darba titullapu, uz kuras numuru neraksta. (Maģistra darba izstrādes un aizstāvēšanas metodiskie norādījumi, apstiprināts 23.09.2013)


Thanks. I will leave it as is until better knowledge


star (*) 는 빼는게 좋을듯~ 아래 링크 참고~!!
http://jsperf.com/css-star-performance


Removing these values does not seem to be related to the coverity issue. This is probably an independent bugfix?


a template
the block HTML representation


Les fichiers "test[reseau-social]" sont les fichiers fonctionnels indépendants qui nous ont permi d'extraire un flux rss et d'envoyer un élément sur le réseau social correspondant.
Pour ce qui est d'une implémentation structurée avec des classes, nous avons commencé à implémenter les fichiers "class[Reseau-social]".
La structure de l'article extrait est totalement gérée par feedparser, dont nous prenons dans cet exemple le titre et le lien de la dernière entrée chronologique:
title = d.entries[0].title
+link = d.entries[0].link

afin de les poster comme message twitter:
{'status':title+' '+link}

Du coup, la structure qui représente l'article est inclue dans feedparser.


a custom design


`hello`


@DominikGuzei why does this code look like this?


Removing these assignments does not seem to be related to this coverity issue. Is this probably an independent bugfix? If yes, this should go into a separate commit explaining the issue it is fixing.


`StrListPrivData` is not the best name for this class.
A suggestion: it could be a slice(or cursor)...  :
```c
typedef struct _StringSlice {
  char *start;
  int length;
  const char *string;
} StringSlice;
```


naming is kind of weird here. You can just name it like it ?
- (void)setS3ImageURL:(NSURL*)URL withAccessKey:(NSString *)accessKey withBucketKey:(NSString*)bucketKey withSecretKey:(NSString*)secretKey;


s3_link is type of NSString but getImageForURL is expecting a NSURL. Did you test your code ?


If user want to be able to customize this property ?


you can remove it ?


same here


is this include anythigs?


TeamCity Ylab :: synteny/ylab [Build 29](http://192.168.30.225:8111/viewLog.html?buildId=589&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


I'm [already in there](https://github.com/antlr/antlr4/blob/master/contributors.txt#L65).


@tjora,

Yes thats fine. So for instance even though that commit should be split in
two they are both fine in the pull request.

Stu

On 21 January 2015 at 09:11, tjora <notifications@github.com> wrote:

> No problem!
>
> I will try to make separate things in separate commits next time. Is it ok
> to keep related changes in the same pull request?
>
> Sigve
>
> On Tue, Jan 20, 2015 at 4:50 PM, Stuart Hodgson <notifications@github.com>
>
> wrote:
>
> > @tjora <https://github.com/tjora>. Thanks for this refactor. I would
> ask
> > in future that these two changes, the possible leak and the re factor be
> > two different commits. Makes it easier to see what is going on.
> >
> > Thanks
> >
> > Stu
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/tjora/cocotb/commit/9cbf3345e84e312e47f9266c7488a8fab8b3178d#commitcomment-9358425>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tjora/cocotb/commit/9cbf3345e84e312e47f9266c7488a8fab8b3178d#commitcomment-9372094>
> .
>


+1
http://doc.intercom.io/api/#create-or-update-user


TeamCity OsmSharp :: GitHub - OsmSharp [Build 933](http://build.osmsharp.com:8080/viewLog.html?buildId=4146&buildTypeId=bt16) is now running


The getter does not take any parameters. Check the unit tests for how to use this.


duplicate line ?


To implement the block in BEM terms, use the created technology files
или что-то в этом духе


Will do


the block или `hello` block (но везде одинаково по документу)


Don't forget that `:taken` should be overridable by the `options[:message]`.
(e.g. `validates :email, unique: { message: "EMAIL TAKEN" }` ).


Thank you Alexis to have modified your script. I was actually somewhat reluctant to upgrade texinfo so as to keep stable my Debian stable. Only Emacs and Ledger are bleeding edge. Of course! :-)

BTW, the new script makes the tests CheckManpage and CheckTexinfo to fail. But I believe this is intentional, isn't it?


Is these really needed?


Atkal, eksistē cits, pusotru gadu jaunāks dokuments (kurš oficiāli ir paredzēts tikai maģistrantiem), kur ir teikts otrādāk.

http://estudijas.lu.lv/mod/resource/view.php?id=88291

sk. 21. lpp, attēla apraksts centrēts.


Sorry-will change. This still worked though on my end, but will add for thoroughness.


Size must be an integer (number)!  Do not add the 'kb', 'mb', etc to the data.  This is why I told you to use ```Ext.util.Format.fileSize()``` function. This can be applied to the grid column for that data.


What do you mean specifically?


I'll add that as a property, good point


Will fix


TeamCity Ylab :: synteny/ylab [Build 30](http://192.168.30.225:8111/viewLog.html?buildId=590&buildTypeId=Ylab_SyntenyYlab&guest=1) is now running


Huh - why?


Again why ? How would it animate ?


http://estudijas.lu.lv/mod/resource/view.php?id=88291

dokuments, par kuru gāja runa. sk. 14. lpp, 2. rindkopa.


This member variable seems to be unused and can be removed. We found no other code that accesses it.


Well, you are calling it with a parameter though:

```
[self performSelector:property.customGetter withObject:nil]
```


Remove this variable as it is unused.


Just NSLog


Converting your original PSD to Responsive HTML 5 is a job best left to the professionals. If you need to maintain the integrity of your design, a seamless transformation has to take place. Many creative professionals don't wish to engage in the tedious coding and leg-work that's required for this, hence they may use free download software to do these conversions. However, unless you're willing to experiment and waste a lot of time/effort, a PSD to Responsive HTML 5 can be competently done by a professional conversion service provider. ClapCreative


> P.S. we don't want to add Infinispan to the end user deployment.

I'm missing something,
in the test, I get the CacheContainer I defined in the server configuration and then I put/get something in it in the different nodes. How do you test infinispan if you don't add it as a dependency? Maybe I didn't understand exactly what you want to test.


What does the "portbindings.VIF_TYPE_ROUTED" line do here?


`json.dumps()` would be nicer, but this doesn’t really matter here.


Ok, so you have a warning I think, haven't you ?


You’re force-pushing far too often.


SCons use Python in a reversed strange way.
However it is good to have clean Python file.
Explicit is better than implicit.


This will definitely conflict with my pending change at https://github.com/Metaswitch/calico/commit/05a9bd07da877868ba73424854a6d592bf5b2f37 - and it may be that my change makes this one unnecessary.

First step, I think, is to understand in detail why you needed this change for Red Hat.


I also don't really understand, now that I'm looking at this, why the parameter is nil instead of the actual value. Maybe you can explain how I am supposed to deal with this scenario?

I have a User model with the following property:

```
typedef NS_ENUM(NSUInteger, SlingUserStatus) {
    SlingUserStatusUninvited,
    SlingUserStatusUnverified,
    SlingUserStatusVerified
};

@property (nonatomic) SlingUserStatus status;
```

I use the following custom setter to transform the string I get from json:

```
- (void)setStatusWithNSString:(NSString *)string {
    if ([string isEqualToString:@"uninvited"]) {
        self.status = SlingUserStatusUninvited;
        return;
    }

    if ([string isEqualToString:@"unverified"]) {
        self.status = SlingUserStatusUnverified;
        return;
    }

    self.status = SlingUserStatusVerified;
}
```

Now, when I call `toDictionary` on my user object, I want it back as a string, right? So I need a custom getter. I thought this would work?

```
- (NSString *)JSONObjectForStatus:(SlingUserStatus)status {
    switch (status) {
        case SlingUserStatusUninvited:
            return @"uninvited";
            break;

        case SlingUserStatusUnverified:
            return @"unverified";
            break;

        default:
            return @"verified";
            break;
    }
}
```

But if it's not supposed to take any parameters, how can I write this getter?


Makes no sense.


How about taking the chance to rename ```get_current_time``` to  ```current_time``` while you are at working on the RTC drivers?


a user action using
A click on the button adds the user name from the input field into the greeting phrase


schema:update must be after generate:entities FqBundle


bad docstring for ScanPosts here.  ScanPosts does not load tasks.


Can we stick with "restarted" instead of "started"?


Redundant.


missing `from __future__ import unicode_literals`


Do this only once.


Also, for the date field, please use the same format as the database. DB dateTime is in this format: YYYY/MM/DD. Please make sure this is defined in the model for the files.


Nice, except for the one minor comment


Can you update git@rapi.la:rapila-design.git with the updated icomoon project file in Admin/Icomoon Project.json?


i-bem.js без артикля


Yeah but it still works. Fixing for thoroughness


Oh ok


I’d prefer this to be a **class attribute** and not a method, like `name` and `is_default`.


What about -f /etc/bird.conf, instead of -f /etc/redhat-release ?  Surely that would be a more direct test of what we really need?


Too much logic. A simple Metrics.store(target, field, value) should suffice.


Why the extra "impl"? These classes don't have a single interface they're implementing.


или  YModules modular system или a modular system called YModules


TeamCity Ylab :: synteny/ylab [Build 29](http://192.168.30.225:8111/viewLog.html?buildId=589&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 126 Build time: 00:12:07


Why `sut`? :smile:


Similarly here.


Too much logic, move out to a private method.


TeamCity Ybackend :: Feodorov/ybackend [Build 73](http://192.168.30.225:8111/viewLog.html?buildId=591&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


I think we've lost all the 6s in this stanza.


Map<String, Field> not HashMap<String, Field> metricFields = ...


If there are two buttons with btn-danger in page, what do you do? Select from <form> children.


TeamCity Ybackend :: Feodorov/ybackend [Build 73](http://192.168.30.225:8111/viewLog.html?buildId=591&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:16


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 130](http://192.168.30.225:8111/viewLog.html?buildId=592&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


a block name


There are always several ways to write code and I don't like c++ exception handling and the function name neither...

But in my opinion it is a good concept to stay simular to the zxing java version (because zxing c++ is nearly a 1:1 java 	copy). This will be a big benefit for transfering further development and bug-fixes from the java version to the c++ branch. Therefore I would not change the function name or the exception concept.

For comparison the Java version:
private static Result maybeReturnResult(Result result) throws FormatException {
    String text = result.getText();
    if (text.charAt(0) == '0') {
      return new Result(text.substring(1), null, result.getResultPoints(), BarcodeFormat.UPC_A);
    } else {
      throw FormatException.getFormatInstance();
    }
  }


This one has nothing to do with object_delete, it fades all the messages in page.


Actually, I believe this test is needed.
``getDecoderOutputFieldTypes()`` returns a ``List`` of zero or more ``FieldMetaType``s. For the RDSEncoder, we expect a single enum, ``FLOAT`` but can't use Generics or anything to guarantee that. So, we should assert it here in tests. It'll be good to keep.


Done


I think it should be no default.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.3.0.933](http://build.osmsharp.com:8080/viewLog.html?buildId=4146&buildTypeId=bt16) outcome was **FAILURE**
Summary: Tests failed: 7, passed: 498 Build time: 0:0:0
### Failed tests
```
OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceAgainstReferenceBig: Test(s) failed.   Expected: not null
  But was:  null
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceAgainstReferenceRealNetwork: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  10.050864112246295d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceBig: Test(s) failed.   Expected: not null
  But was:  null
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceRegression2: Test(s) failed.   Expected: not null
  But was:  null
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHVerifiedContractionTests.TestCHVerifiedContractionTestNetworkReal: Test(s) failed. Routes are different before/after contraction!
   at NUnit.Framework.Assert.Fail(String message, Object[] args)
   at OsmSharp.Test.Unittests.Routing.CH.CHVerifiedContractionBaseTests.pre_processor_OnAfterContractionEvent(UInt32 vertex, List`1 edges) in c:\14K-SERVER-ROOT\TeamCity\buildAgent\work\84949b4048d1023a\OsmSharp.Test.UnitTests\Routing\CH\CHVerifiedContractionBaseTests.cs:line 235

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.Serialization.Sorted.CHRoutingSerializationComparizonTests.RoutingSerializationV2CHRoutingV2ComparisonTestNetworkBig: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  81.874928507390237d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.Serialization.Sorted.CHRoutingSerializationComparizonTests.RoutingSerializationV2CHRoutingV2ComparisonTestRealNetwork1: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  44.934710477927688d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

```


TeamCity OsmSharp :: GitHub - OsmSharp [Build 934](http://build.osmsharp.com:8080/viewLog.html?buildId=4147&buildTypeId=bt16) is now running


There should be no version number in here.


No version number.


No it isn't
Probably a mistake


Still need to change region but rest is done


a function
но надо подумать, как правильно сказать.


a


This line should be removed. The next snprintf line handles the printout correctly.


Never expose an impl class when an interface will do.


Not sure what is not obvious here, but ... :] Here's once more ... A getter does not get a parameter ... why ... because you have the value already - it's stored in your class.

Check out the complete github repo and look into EnumModel.h and EnumModel.m from the unit tests - it demoes exactly what you want to do


Thanks. I'll extend it so that it respects additional options :)


Why did you change the app name? Please use "Xplorer." This way we can avoid legal issues...


a constructor that describes reaction on an event


Im not that kinda guy so fork u too...


You're absolutely right, this was quite stupid of me :) Still, there is a bug here in JSONModel, please see my comments on https://github.com/icanzilb/JSONModel/pull/272.


the event that causes reaction


I've fixed only those parts where Python raised some exception. There still might be hidden errors.


Yeah, good catch @anubhavchaturvedi, if you ``exception.expect()`` and then call two functions that are expected to throw Exceptions, the test will pass if _either_ throws an Exception.

As an aside: for this kind of reason, it's usually best practice to only make a single assertion per test. These tests we are porting from Python, however, tend to test the operation and change of state over time, requiring lots of assertions. Something to keep an eye out for when porting; we can keep these 1-1 tests from Python but might be well off to add more _unit_ tests as we see fit.


TeamCity Ylab :: synteny/ylab [Build 30](http://192.168.30.225:8111/viewLog.html?buildId=590&buildTypeId=Ylab_SyntenyYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 126 Build time: 00:12:26


Yes, using a boolean would make things easier to read and be less hackish as well.


In either case, the test would fail. If for some reason the "bits" have values greater than 1, the downstream assertions would surely fail. In any case, an explicit assertion here will help debug these cases.

+1 to add assertion


fasfsadfasf by akash


Shouldn't --declaration option also be present in the services one?


Now the pager icons are gone.


Do you want this as an arguement ?


In the test I'm including a dependency to infinispan-core because I'm using the CacheContainer.
I have the feeling I didn't understand what you want to test as expleined in the other commet.


I think the `PickleFunctions` trait is a bit irregular, since it is not used for selecting picklers/unpicklers. `PickleFunctions` only slightly simplifies the lives of customizers (which are very few). Like @jsuereth mentioned, the `pickle`/`unpickle` methods could be provided via delegation:

```scala
package object serialization extends picklers.AllPicklers {
 def pickle(..)(..) = scala.pickling.pickle(..)(..)
 def unpickle(..)(..) = scala.pickling.unpickle(..)(..)
}
```

So, I’d also vote for moving those methods back to where they were.


Fixes #28


This keeps throwing typeerror _init_() takes exactly 2 argumensts 1 given


We are adding a minimal support of local device contacts. This branch is a pure dev / "proof of concept" branch.
One of the goal is to find people from your phonebook that have a matrix id.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 130](http://192.168.30.225:8111/viewLog.html?buildId=592&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:15


According to http://www.cplusplus.com/reference/cstring/strncpy/ the last byte of the target buffer must be set to 0 otherwise you would not get a null terminated string if the length of the source is >=128 as in this case strncopy does not put a 0 at the end.

Probably it would be also better to use omnet's cStringTokenizer as it's easier to use.