TeamCity OsmSharp :: GitHub - OsmSharp - pullrequests [Build 4.3.0.84](http://build.osmsharp.com:8080/viewLog.html?buildId=4052&buildTypeId=OsmSharp_GitHubOsmSharpPullrequests) outcome was **FAILURE**
Summary: Tests failed: 11 (8 new), passed: 424 Build time: 0:0:0
### Failed tests
```
OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceRegression1: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Instructions.InstructionRegressionTestsCH.InstructionRegressionCHTest2: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Instructions.InstructionRegressionTestsCH.InstructionRegressionCHTest3: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Instructions.InstructionRegressionTestsCH.InstructionRegressionCHTest4: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.RoutingRegressionTests.RoutingRegressionTest5Contracted: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.RoutingRegressionTests.RoutingRegressionTest6Contracted: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.RoutingRegressionTests.RoutingRegressionTest7Contracted: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.RoutingRegressionTests.RoutingRegressionTest8Contracted: Test(s) failed. System.IndexOutOfRangeException : Index was outside the bounds of the array.
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.RecalculateQueue() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 167
   at OsmSharp.Routing.CH.PreProcessing.CHPreProcessor.Start() in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\CH\PreProcessing\CHPreProcessor.cs:line 99

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.Serialization.Sorted.CHRoutingSerializationComparizonTests.RoutingSerializationV2CHRoutingV2ComparisonTestNetwork: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  13.859102561135382d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.Serialization.Sorted.CHRoutingSerializationComparizonTests.RoutingSerializationV2CHRoutingV2ComparisonTestNetworkBig: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  5.9641326098436576d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.Serialization.Sorted.CHRoutingSerializationComparizonTests.RoutingSerializationV2CHRoutingV2ComparisonTestRealNetwork1: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  2.5069684076638596d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

##### there are 1 more failed tests, see build details
```


Shouldnt the client wait on connect for a few seconds if the server is not available/ready?


Okay, I have redone this commit: the corrected one is 1f0021d8daba65a71901829197db030c78665dc7. Thanks again!


Hey thx, but I use the phpbb functions now, which is much better, because a framework should solve these problems once and make the solution reusable...and phpbb did it with the utf8_* functions.

Am 3. Januar 2015 13:05:30 MEZ, schrieb AlexSheer <notifications@github.com>:
>It's not right? you should replace
>		if (mb_strlen($query, 'UTF-8') < 3)
>		{
>			return array();
>		}
>
>this code
>		if(function_exists('mb_strlen'))
>		{
>			if (mb_strlen($query, 'UTF-8') < 3)
>			{
>				return array();
>			}
>		}
>		else
>		{
>			$dummy = array();
>			if (preg_match_all("/.{1}/us", $query, $dummy) < 3)
>			return array();
>		}
>See this at http://www.phpbbguru.net/community/topic42750.html#p447594
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/RobertHeim/phpbb-ext-topictags/commit/2f86a8d7349b8f7c98ddbecc1f12a1dbd5873047#commitcomment-9142347


Indeed, no, I've reverted it right after pushing. Not sure why switching branches introduced this silly submodule change...


Regarding Stripe: should it really be included in the repo?


Well, if I recall correctly, it won't allow you to boot an unsigned kernel without this commit.


删除IDE配置文件


aa


I like this!


And the features that enables the options are worth it...

And if I am not mistaken it would allow to compile more easily some modules with hard floating, right?


Yeah, this is better.


Rogue 't' between Sequential and Enum :-)


Thanks a lot for quick fix for the issue


I would use local versions that have been compressed (should be available on their site).


I really like the sequential wrap around behaviour, and the ability to add exceptions. Nice!


yeah that doesnt work with lists


Better to use some consistency in the comments. My suggestion:
* Always a whitespace after the comment starts (like is done for the block comments).
* End non-header comments with a dot.
* Always use capital letters.


I think the code is self-explanatory enough here.


This is generally the right direction to solve this (compare my comments to #568 in a couple of minutes), but will not work, as the `$watch` is done a little wrong.

`scope.$watch('history.activeKeys')` means executing the listener everytime the object `history.activeKeys` is newly assigned - which happens (in this case) only once, when the object is defined for the first time. The watch can never fire this way.

What we want is to execute a function everytime a specific property of this object changes. There are two ways to do this:

- Given the `$watch` as it's defined in this commit we could implement it as a so called __deep watch__ by passing a third argument `true` to this function. This would check every key and every value of the object constantly - which is usually not a good idea on big objects (can get slow), but would work in this scenario perhaps. It still would be the wrong tool for the job
- In #570 this was solved by watching the specific property we're interested in only - `history.activeKeys.redo` and `history.activeKeys.undo`. This way we are only notified when a new definition for this keybinding was added - which means that we have to update the key hint.

A proper version was added through  18043a4.


The code is self-explanatory.
My view: comments should explain the motivation behind the code more than explaining what it does.


The title was supposed to be "Save backup as $XDG_DATA_HOME/games_backup.tar.gz." but I forgot to escape the "$" :smile:


agree, it's from an earlier version, thank you

On Sat, Jan 3, 2015 at 4:49 PM, sebaste <notifications@github.com> wrote:

> minDonationAmount == 0 doesn't make any sense to me, considering the
> current design of the donation selection, with the single button "Donate".
> I would change it to be == 1.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EmpathyApp/EmpathyApp/commit/685090dcf4afdbfba628ea9abc796b5d251dbf48#commitcomment-9142874>
> .
>

--
http://www.svenskafreds.se/fredskalender-for-goteborg
https://github.com/EmpathyApp/EmpathyApp/
http://ihavearrived.org/


for now probably, alternatively we can use composer, but still need one
line to include i think, it will just look different

On Sat, Jan 3, 2015 at 4:52 PM, sebaste <notifications@github.com> wrote:

> Regarding Stripe: should it really be included in the repo?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EmpathyApp/EmpathyApp/commit/685090dcf4afdbfba628ea9abc796b5d251dbf48#commitcomment-9142889>
> .
>

--
http://www.svenskafreds.se/fredskalender-for-goteborg
https://github.com/EmpathyApp/EmpathyApp/
http://ihavearrived.org/


I leave a comment for textbox:
the wparam always give Upper case in KeyPress event .for example,press <w > give 87 instead of 119.


In case subtitle is phone number retrieved from AddressBook it might contain whitespace. Searching in subtitles for: "0750", now, will show results as: "075 0" etc.


this is awesome stuff, but I wonder if we might risk going a bit further, like also supporting "fname, f_name, first_name?"


Soo fast ... Enjoy!


Oops, wrong title but can't edit title anymore.


regarding to the first comment, I mean the drop-down combobox,while dropping down, I move the items by Up or down arrow,all  items are highlighted.


You should only add events that are really available ;)


so many foreign terms :scream:


Any idea when you plan to update the gem?


thanks for the hint.. because i don't want to disable SELinux xD


Not sure here ... maybe it could be read from the json response? If a new types arrive we'd still need to adjust our code ;)


You're welcome @cloud8421 :wink:


Tough. No wonder there're only few opensource projects (OpenWRT and DD-WRT) for this kind. It cannot create from the devices in the market easily.


-mfpu=neon-vfpv4 is just there for GCC compatibility.  Actual VFPv4 support
is turned on by default for a couple subarchs.
https://codeaurora.org/cgit/quic/la/platform/external/clang/tree/lib/Basic/Targets.cpp?h=LA.AF.1.1.1#n3713

On Sat, Jan 3, 2015 at 9:55 AM, Maxime Poulain <notifications@github.com>
wrote:

> And the features that enables the options are worth it...
>
> And if I am not mistaken it would allow to compile more easily some
> modules with hard floating, right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OptiPop/build/commit/d2491f80fdade2ee1849a8b11794bb332c201999#commitcomment-9142895>
> .
>


The two commands above aren't mine.


This turned out to be easier than I thought. I just added a hook to the annotatorjs submission, which updates the autocomplete list based on the data being submitted.

A couple of consequences:

 * the autocomplete update happens when you submit the tag, not when you first type it in. This seems desirable -- otherwise we would have typing errors cluttering up the autocomplete
 * the autocomplete update will still happen regardless of what happens on the backend (e.g. server error, or tag being rejected as invalid). This seems as good a way of handling that (hopefully rare) situation as any other


I don't even know what they are for.


84694650_EnableCodeCoverage (lefticus) - x86_64-MacOS-10.9-clang: OK (1576 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Congratulations, you found a bug!


a


J'avais un peu commençé :)


oh - I see they are already part of CoreBundle. oops :rabbit2:


Thank you for that idea :D


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1768](http://teamcity.monogame.net/viewLog.html?buildId=4150&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


great! waiting for bot verdict ;)


r+ rollup


Yeah I agree with you, it's kind of strange :) But with the code you posted, you'll need to remove the .framework files from the source directory before the build. Otherwise, cmake will find them in ./extlibs/, and ${SNDFILE_LIBRARY} will always be extlibs/libs-osx/Frameworks/sndfile.framework.

I see 3 solutions :
 - Remove the extlibs from the source before compiling
 - Add a "global" switch which disable internal extlibs usage (but it's a bit strange, I agree with you)
 - Overrides SNDFILE_LIBRARY and FREETYPE_LIBRARY when running cmake, to make them match brew's installed files.

Feel free to correct me if I'm wrong ;)


So my understanding is that although you can specify 10px in QT, it may actually scale to a different number of pixels if the OS is properly set up for hidpi scaling?


@JeromSar Unless I am missing something blindingly obvious, it will check if the warning is greater than 10 or less than 0, if it is not it then checks if the warning is for my username and if it is stops it, else continues? Or have I messed something up somewhere?


Nope? `RD` is `cpu->Reg[inst_cream->Rd]`


Does DebugLogF() get printed outside of debug builds? If not, how do I send a normal log message?


I'm not sure about Qt CSS or font sizes but that should be how widget sizes (i.e. QWidget::setWidth/setHeight) work.


親フォルダの終端が空白文字だと保存に失敗する問題への対応。

ex.
・ファイル名設定を「?illust-year?-?illust-month?-?illust-day? ?title?/#page-number#」のようにする。
・「.」というタイトルのマンガ形式を保存しようとする。
・ファイルパスは「2015-01-01 /01.jpg」のようになる。
・親フォルダを作る時「2015-01-01 」を指定するが、実際に作られるものは「2015-01-01」のように、終端の空白文字が除去されてしまう（Windowsのみ？不明）
・親フォルダ作成後、「2015-01-01 /01.jpg」で画像ファイルを作成しようと試みるも、親フォルダ名の終端の空白ありなしで不一致が起きエラーとなってしまう。

なので、親フォルダが空白文字で終わっている場合はそれを除去するように修正した。

あとs/\.+$//をやめてs/\./_/gにした。
保存フォルダ名が変わってしまう場合があるかも？


Check my git i have pushed necessary mdss hook.


"froms" => "from"


Script isn't part of the repo?


Maybe version comments would be useful?


I think https://github.com/ArcEye/machinekit/commit/94ebbc2039404eb5fdb0d6c4dc1fc6a231027a5f#diff-582191dbbc629ee2711157444c8d5a19R85 can go, not needed


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1768](http://teamcity.monogame.net/viewLog.html?buildId=4150&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 289, ignored: 6 Build time: 00:16:13


here you can connect a signal to another signal:


@dominikh @shurcooL @hajimehoshi @ajhager @iansmith @phaikawl This change is not backwards compatible. I hope you don't mind. At some point the API will become stable, but right now I'm still looking for the best options. Please make sure that your libraries still work. :-)


commited profiles.release in src/cargo/util/toml.rs:818 by accident, commited to master by accident, decided to scrap this one.


This blog post implies that real hi-dpi support doesn't exist until QT 5.4: http://blog.davidedmundson.co.uk/blog/kde_apps_high_dpi


GaborRFMap.nib: maximum value for respective text fields of right tab of MapStimTable increased to 11 for orientation change and 10 for temporal frequency.


Dankeschön @lfdm! I thought it did actually work in my testing but I might not have tested both undo and redo and I can see why your fix is the right solution. Question though - why is this not a scope issue?


:) <3


i think you can join this class with `NotificationServer` and move the code to a cpp file


How dare you make tungsten useful!


I"m curious about Line 24 in this script.

You're writing to output2, which doesn't appear to be opened. If no error is thrown when you run it, I think it's dead code.

Having an integration-type test would be really helpful here. Read in a test file, write out the processed data, compare that data to a pre-written "known good" output example.


I tested that if ```options``` is undefined, the query will still work fine.


That was a hangover from debugging - overlooked.
I have done a new commit to remove it.
Do I now have to do a new PR with both commits, or is there an easier way?


But Ctrl+L will conflict with the "Open URL" shortcut as soon as the Qt interface supports this dialog.


This is done so that we return a float of 2 decimal places to NSSound as volume. Otherwise Knot crashes


:boat:


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1769](http://teamcity.monogame.net/viewLog.html?buildId=4152&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


You need to update the link to following: https://pipes.yahoo.com/pipes/pipe.run?_id=42e21512250c3875a3eb1643fe5eb875&_render=rss (to include rendering as RSS).
It's also good idea to add the blog's URL as comment before this link...


Answered quite thoroughly in #568 now ;) Happy reading hehe - it got a bit long...


Nitpick: There should be no period in the first line of the commit message. :P


> This blog post implies that real hi-dpi support doesn't exist until QT 5.4: http://blog.davidedmundson.co.uk/blog/kde_apps_high_dpi

Hm as I understood it, Qt 4.8 got backports of a lot of the Qt 5 high-dpi support:
http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/

However, it looks like CSS styling may have bugs:
https://bugreports.qt-project.org/browse/QTBUG-27389


New Create


Está línea e sincorrecta


@bors: retry


Debes hacerlo como esta


Alignment is slightly off here (two spaces too many)


No uppercase at all in filenames, please.


ugh, probably, though I feel if you want non-enumerable properties, you should make non-enumerable properties rather than relying on everyone else implementing hasOwnProperty in their for-in loops. It's advice from an era when we didn't have the ability to set non-enumerable properties. Many of the benefits of prototypical inheritance that *aren't* simulating classes are lost because everyone does this. It's bad. That said, I should probably conform rather than go against the dumb grain, people are unlikely to change their code and make prototype methods non-enumerable.


By default the user programmable internal CMOS oscillator generates a clock of 2.08 Mhz (MCLK) on power up,
the oscillator clock ranges from 2.08Mhz to 133Mhz, for the LED toggling a clock of 26.6 Mhz is used.

Oscillator reference : http://www.latticesemi.com/~/media/Documents/DataSheets/MachXO23/MachXO2FamilyDataSheet.pdf
Page: 33


Is the separate make still needed now that I've fixed the CMakeLists.txt?


Please use our typedef uint32 instead of the C99 uint32_t type directly.


@lojack5: if you are to review one item please review this: why on earth DataDict in its `__get__` method if the key does not exist tries to return the `bush.game.masterFiles[0]` - and failing this Oblivion.esm (deleted this part, is not exactly game generic) ?


This line is where #7 occurs. We need special handling for multiple pieces. This entire nested for should go into Spaces eventually, where here we could just call board.getSpace(i, j).render() or something like that.


I would like to keep them separate because of their purpose, but we'll see


https://github.com/nickdoherty81/android_packages_apps_Settings/commit/0d4f3a7c3a6d5b79c51a312d3a9bdaa01b4d4f92 <-- I did it up clean again and also here is the logcat --> http://pastebin.com/kCY80NT8


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2995
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2989
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2990
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2981
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2981
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2984
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2977
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2972
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2648
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2646
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1485
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1476


fast-forwarding master to auto = fe7e285d


Like through a lambda expression?


Why this is not merged?
https://github.com/MotorolaMobilityLLC/kernel-msm/commit/250571cfd605edcf6d69d5f518f847c4263bd83c


++iter, please. :P


Please move it one level up, because it does not change within loop. It's like constant.


@JeffBezanson does this need to be (top <:)?


it may only change within `if curve.array_index == AXES[axis]:` so move it there.


#5 probably happens around here. I think we should move this into spaces as well. Something like
foreach (space) {
  space.explodePieces() // Only explodes if currently have more than 2
  space.resolveFullCollisions()
}

explodePieces would return a list of the pieces exploded so we can remove them from the pieces List if we make one.


please move it out of loop because loop only reads it.


Use 0 instead of NULL.

(I kinda would like to use nullptr, but I'm holding off for reasons of portability with older compilers)


saw approval from nikomatsakis
at https://github.com/nikomatsakis/rust/commit/472046e67bde8a80cd3f3615f16b4d44956542bc


merging nikomatsakis/rust/rollup = 472046e6 into auto


status: {"merge_sha": "46bbaa02e42f2b8de5e8a7267ca3be7c0a72c6bc"}


nikomatsakis/rust/rollup = 472046e6 merged ok, testing candidate = 46bbaa02


Is this python3 compatible? The original code would make byhour a list in both python 2 and 3

The new version AFAIK returns a list in python 2 and an iterator in python 3

Same below


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1769](http://teamcity.monogame.net/viewLog.html?buildId=4152&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 289, ignored: 6 Build time: 00:16:22


Yeah, It is probably better if it fails at installation rather than just printing an error. In most cases openant is not really usable without the udev rules. For develop just printing an error is fine I think. That being said I don't have a lot of experience in writing setup scripts.


"} else {"

But is there a reason you're not directly returning it->second; there? Would make the whole else branch superfluous, and is way more readable IMHO.


Your are removing things that you should not remove and your commit is not following ours. We're not removing nothing from res/xml/device_info_settings.xml but you are.


TARGET_SCREEN_WIDTH := 720


@casey-collab


Maybe you need device/qcom/sepolicy too (from CM12)


I say we disallow 1 person group chats. This is a chat application after all, not some notes app


Similar to below, disallow single user group chats


working test: https://freeshell.de/~iarthur/clockframe.html


güzel


The else branch is to load (from file here) shader text and compile it, if it's not already loaded and compiled. Makes shader objects loaded on-demand, and referenced via a (UString) name.


`QObject::connect(adaptor, SIGNAL(notificationsChanged()), this, SIGNAL(notificationsChanged()));`


84694650_EnableCodeCoverage (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (1576 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


参考になります


thank you very much


actually I take it back, just need to learn to accept JS doesn't implement prototypes the same way self does, all the other iteration methods only iterate own keys, Object.keys, Object.assign, so whatever. I'll change it when I wake up.


> But with the code you posted, you'll need to remove the .framework files from the source directory before the build. Otherwise, cmake will find them in ./extlibs/, and ${SNDFILE_LIBRARY} will always be extlibs/libs-osx/Frameworks/sndfile.framework.

Yes, indeed, but this is also true with your original version: those two "install" commands happens after the build, when `make install` is executed. Disabling those two lines is in any case required if those frameworks are not used (regardless of solution 1, 2 or 3). With solution 1, the install might even fail because it's not able to find the file to copy.

In https://github.com/Homebrew/homebrew/pull/35479, DomT4 implemented solution 1 which seems not that bad actually.

Solution 2 would imply editing https://github.com/ludvichzme/SFML/blob/brew/src/SFML/Graphics/CMakeLists.txt#L99-L101 and https://github.com/ludvichzme/SFML/blob/brew/src/SFML/Audio/CMakeLists.txt#L38-L39 too, which can very quickly become a burden to maintain.

Solution 3 is the cleanest -- from cmake's philosophy point of view at least. But not the easiest for the formula.

Between solution 1 and 3, I don't really care as long as the brew guys are happy.


Huh, didn't know that was possible, thanks :)


Thanks!


r+ rollup


@ChronoMonochrome @mkaluza

can u guys pls help me to make SELinux working again ?

I've reverted all lines under: "# Security options" and "# Boot options" .. but after using menuconfig and save changes even if not nothing was changed then SELinux is disabled automatically again.. that means some other line is also needed for SELinux.. but wich / where lines ??


Creates files according to the  names created in the navigation bar so that any clcik on tabs on the navigation bar will lead to page though the page will be empty right now


You're welcome


Yes, I got that. I was more talking about the control-flow style here.
I.e.:

```cpp
if (it != _shaderObjectMap.end())
  return it->second;

std::ifstream infile(filename.c_str());
std::stringstream sstream;
// [...]
```

I personally like frequent and early returns instead of blowing up the intendation level, but opinions differ there. :)


Only just realised that's what you meant. I'll change it to that way, and try remember to do so in future, just to keep the style all the same.


Thanks :)


why did you create a shallow copy of list with `[:]` slice operator?


The problem is that switching branches **doesn't** introduce reasonable submodule changes, but keep the current state of the submodule until you run `git submodule init && git submodule update` (our makefiles does this automatically!). If you instead do `git add .`, git thinks you wanted to change the submodule commit to whatever it was in the other branch. This is totally confusing.

If you make a habit of doing `git add -p` instead of `git add .`, you'll avoid these kind of issues (and a lot of others too).

I'd also recommend having two different folders with a checkout of `master` and `release-0.3` if you can afford the disk space. Switching branches causes a lot of recompiling, so you'll save quite some time.


BTW, a little off topic but I am adding copyright headers to the code, so I need your email. Could you PM?


Wgat is it D:/website ?


It may be mixed. It doesn't have to. I would keep object to restrict objects.


@e-jigsaw 補足はええよww


Good idea. Need to try, if that forces array creation before saving.


@e-jigsaw アップデートしたのでそっちのほうがよいかと


https://github.com/crdroidandroid/android_packages_apps_Settings/commit/68f4a8498ad88768badfc72ad8c6f7eacf20f33e you removed it here, i was just catching up...


What is 2 and what is 24? Can you replace the magic numbers with names?


r+


same here


why did you create a shallow copy of list with [:] slice operator?


これがウォッチャー！！


Why does the initial donation amount need to be able to come in a HTTP query string?
Better to state the reason in the comment than explaining what the function does, which is easy to see.


Still in your java class just check your logcat that's all


仁義なき削除


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/fbf257f878c3488b6f8f2fa991a62a03df54f16d


merging Ms2ger/servo/attributes = fbf257f8 into auto


Ms2ger/servo/attributes = fbf257f8 merged ok, testing candidate = d8b6cec7


```cpp
switch (var.type) {
  case SHADER_FLOAT:
}
```
Maybe even align the glUniform* calls with spaces after the ':'?


ここでみずちさん


what's the point of this? I have not tested, but this breaks the `actors` field, and probably many others. Why should we avoid indexing lists?


I just tested with a Debian 6.0 (Squeeze, GTK 2.20, GLib 2.24) VM, and it seems to work OK. I had to force use of the fallback as the icons we request were found, but the new fallbacks were available just fine too.

We should probably check on Windows with GTK 2.16, and if it works there we probably can go ahead and apply this patch.


the easiest way is to amend the commit, and remove the include
then force-push the same branch
the PR will be updated automagically, and the bot will have another go at it


Related to pull-request #138 "Use country key instead of country value for user-country setting", this commit fixes the problem of updating the content of ip_users.user_country from country-value to country-key when upgrading.


@e-jigsaw 一旦しばらく更新されてないやつを削除したのと、ちょこちょこフィードURLが変わってた


okay bro .


ok, thankyou


while (obj);


ricardo.vieira at tecnico.ulisboa.pt


Michał, co to jest ten input w testach?


if (


mizchiさんのはてダ消してはてブロを追うように


check later commit


If wrapped functions e.g. `get_textures` does not return valid result (because lack of `list(set(x))` then make them private for module by adding prefix `__` to their names.
But in the other case I would like to get them directly usable but in that case every function needs to return`list(set(items))`


@ixti: Awesome, thanks for the solutions.


Thanks :)


Wrong switch style there too


shinyhappypeople? O_o :D


OK, that will have to wait for tomorrow, I will get fully git-literate eventually:)


removed code complexity


i read that this should be enabled for "recent" phones (late 2010+)
anyway it should only affects edge connections


Canola oil is spelled incorrectly


Oh, this is here missing the license information header comment


No. Everything is fine now, just forgot to push that.


Thanks for the explanation. I think I actually did `git commit --amend -a` while I was switching between the two branches, in order to synchronize a few changes. This wasn't a great idea.


We've changed the header comment a bit since. Please replace it with the updated version currently in the tree. :)


Comment update required here as well.


Unless there's something I'm missing, this change should make our code ISO compliant, more or less.


Missing comment header.


Here too


It affected network performance in some cases while bringing nothing particularly great to the table, IIRC. We went through these value during CM10.1 development so I thought they should still be used even though I don't remember exactly why any particular value is used while there's nothing to state otherwise.


See updated pie-parsing code. This is no longer an issue, since the pie names are now malloc-ed with `DYN_STR`.


r+


[QuickCheck](https://github.com/pao/QuickCheck.jl) would be nice to catch bugs like this.


Why would you turn debug_fs on, if you when your goal is to disable as many debugs as possible?


Really? It seems to suppress the error when I run the script within my editor. However, it shouldn't matter either way, since the `do shell script` command (which originally invoked this script) is not passing the script's output back to AppleScript. Therefore, effectively, the output of `compile-config.sh` is entirely ignored.

I see that the extra redirection is unnecessary, so I'll revert the change.


struct ShaderObject {


Add a space between > and the name


Why do you want to drop privilege ? fatx does not need to be run as root, it works perfectly as a standard user. Maybe you need to add the user to the group "disk" to read devices.


CamelCase instead of _ please :)


Thanks.


if you already committed a second commit, explore 'git rebase -i <sha>'
and learn to squash commits in rebase


namespace Graphics {


Not sure if spacing works, but I can fix it.


The two commits are ready now.


Typo introduced, but that's better than a buffer overflow!


{ not in a new line, please


all tests pass:
success: http://build.servo.org/builders/linux1/builds/449
success: http://build.servo.org/builders/linux2/builds/448
success: http://build.servo.org/builders/android/builds/484
success: http://build.servo.org/builders/mac1/builds/665
success: http://build.servo.org/builders/mac2/builds/666


@radkovo Correct me if I am wrong, but `HashSet` doesn't guarantee any order. So this algorithm went from strictly ordered to random order. If it works I suspect it might be just luck.


This change should not be done in this way of course, but it is necessary.

The problem is that files are stored in a list, but that is not a list of basestring.

could we make the type check after ```for f in separate:```?


This change is pointless, and no we're missing a blank line before the return statement.


fast-forwarding master to auto = d8b6cec7


Hi,

A question about suppressing byte compilation in lisp subdir.

First of all, my ~/.emacs hasn't been touched for over 10 years, and I'm revisiting it again, using the new emacs24 features. Your config setting is highly praised, *"is a great place for finding awesome config stuff managed by someone who turns ... elisp into works of art"*, and it aligns with *my* requirement of breaking the *humongous* ~/.emacs file into manageable building blocks.

However, I don't understand why to suppress byte compilation in lisp subdir. Reading the post from http://nullprogram.com/blog/2013/06/02/, I want to know

-  if your config uses any `eval-after-load`, and pros and cons of using it.
-  it is said that *"the delayed expression should be properly byte-compiled"* (http://lunaryorn.com/blog/2013/05/31/byte-compiling-eval-after-load/).  I know byte compilation would speed things up, especially when I config it once and leave it intact for years and years, but why you are suppressing it here.

Thanks!!!


It's a dependency for something else
On 3 Jan 2015 17:53, "knizmi" <notifications@github.com> wrote:

> Why would you turn debug_fs on, if you when your goal is to disable as
> many debugs as possible?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bedalus/moggy/commit/b30d5418afc8fb3597d323e6182530bff0c8d786#commitcomment-9143238>
> .
>


saw approval from jdm
at https://github.com/catchmrbharath/servo/commit/b0bdb4c62e8581503dfc82ee409e213e348bdae0


merging catchmrbharath/servo/4497 = b0bdb4c6 into auto


catchmrbharath/servo/4497 = b0bdb4c6 merged ok, testing candidate = c820f463


can't you just do
```python
if name == 'files':
    continue
```
?

seems quite natural to me. I know, this is saying that "files" is a special field, just like language. But I don't see this as a problem.

Otherwise, your solution (checking inside the `for f in separate`) is fine.


Sorry, I just realized that this was not the main commit! Did you revert this change for performance reasons?


Yes, it's for performance reasons. Although the difference is probably marginal in this case...


Test


`.emacs.desktop` shouldn't be an Emacs Lisp file extension, but a file name.

See e.g. http://github.com/search?q=extension%3Adesktop+lisp&type=Code


Robustness. To prevent errors when the elements are not processed in the correct order.


General comment:
You might want to consider logging things for Firebug during development. To get it to work with all browsers, you can use this: https://github.com/patik/console.log-wrapper


That will break the test suite.


log messages were put there, while they were useful while developing. I assume that only developers have set there log level to FINEST, so it should not bother others.


Why did you set RESTRICT="mirror" ?


Are you having issues with pgp_autosign as well?


:D you are welcome :D happy I'm not the only one who uses FormData ;))


Hi @benjaminhu01. I would very much like to talk with you about the update you present. For some reason, that I think may be simply resolved, your new code in BDX.m is  creating a conflict with the present Master.
Please let's look, compare and resolve the conflcts? Please have a look at how to do this using GIT commands?
Look here: https://help.github.com/articles/resolving-a-merge-conflict-from-the-command-line/
and here:
https://github.com/bdxrg/V1sprint/pull/3- In the middle of the screen you can see in blue letters: Use the Command Line and there a legend is created.
and here:
https://www.youtube.com/results?search_query=github+merge+conflict for videos demonstrating HOW.

Please get in touch after you have gone over this.

Thanks,

Adrian


@nkzawa bump `ws` to version 0.6.4 to include https://github.com/einaros/ws/pull/424.


Maybe AUDIT_GENERIC. check out this https://github.com/TeamCanjica/Samsung_STE_Kernel/commit/990ea488092ab55cf9d0e1ca27f7545a2ddc1d38
BTW, why do you need selinux? IMO it's so redundant, like having antivirus on android phone. It just spends resources, and does nothing useful for 99% users. If I remember correctly, it makes ~500-700 kB less available RAM.


remote="cm" needed here :)


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1087 of 1087 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Re. the reason for `no-byte-compile`, see [this comment I made earlier today elsewhere](https://github.com/milkypostman/melpa/pull/2339#issuecomment-68592802). I also didn't want to deal with issues relating to outdated or incompatible byte-compiled files. But if you fork this config for your own purposes, you can feel free to remove that setting if you understand the risks.

In general, performance-sensitive code should be extracted into separate packages, which then *will* be byte-compiled.  I try not to have any speed-critical code in the various `init*.el` files, so I don't think that byte-compiling them will make any noticeable difference.


@jenshnielsen Yeah, it's fine. It doesn't need to be a list. The old version of dateutil explicitly converts to a tuple in the constructor anyway. The new version explicitly converts to a set.


Oh, so that's why Emacs Lisp has `.emacs` as a file extension.

Could you please try with `.emacs.desktop` in both `extensions:` and `filenames:`?  I just did so myself, and there were no errors.


toto je problem len pre VS2010 - opravit jednou z moznosti:
a) add_definitions(-D_USE_MATH_DEFINES) v CMakeLists.txt ak je kompiler MSVC
b) obalit #ifdef len pre VS2010


fixes #194?


Okay, giving this another try.


Est-ce que tu pourrais mettre à jour le wiki stp ? Je crois que t'as rajouté un paquet de fonctions non documentées...


nie, toto je skarede riesenie (zbytocne sa importuje vsetko z cv namespacu, co pre unity build je extremne zbytocne - podrobne vysvetlenie je dost zlozite...)

prave odstranujem z projektu vsetky "using namespace"

toto treba zmazat, a vsetky errory opravit pridanim "cv::" prefixu (bez uvodzoviek)


Awesome! No more "How do I make a TARDIS" spam in chat :smile:


bolo by vhodne skontrolovat vsetky subory a spravne ich naformatovat - nech sa to vyriesi jednym commitom a potom nebudeme mat v commitoch zbytocne white-space zmeny...


I think that the db.xml default is what actually does what your saying. The is null check actually just makes the scroll wheel default to true for new blocks.

Honestly I don't have a strong opinion either way, I simply implemented out as @nkay was attempting to. I think it's probably a non issue for what it does


Ha, good timing, what a coincident. Thanks for the clarifications! I *didn't* understand the risks BTW.

Oh, another thing, why they recommend to use `eval-after-load`? Are you using them? Thanks!


Did you mean strength?


There are a lot of variants of this on the web. I would use this instead: http://www.jquerybyexample.net/2012/06/get-url-parameters-using-jquery.html


That's great!
As a minor improvement I suggest to swap lines 98-99. Your logger may throw an error/exception and you will never execute the line 99, and the state of the your object may be unpredictable.  :smile:


hi. Can you help me? Idk what the point of this does ->
public List<SpellSlot> Slots


aye. I'll close the ticket.


C'est fait !


Make sure the comments are correct.


Agreed. But maybe we should move this discussion to the issues list, before we lose track of it.


And BTW, it's awesome to see the bot running. :-)


the sortOrderWithLimit() already returns String => no need to call the toString() on it again.


please instead of this comment add a reference to the place where we took this class from to give credit.


`defaultNaming = bemNaming`, и дальше `if object defaultNaming = bemNaming(defaultNaming)` ?

Запутанная история Рапунциль, какая-то.


Please revert this commit, or replace the code with this year's.


nooooooooooooo!!!! never call a method in java with capital first letter. Never ever ever :)


maybe extract the "20" to a constant like:
private static final int EVENTS_PER_PAGE = 20;


he movido todos los js a una carpeta así que he tenido que cambiar la ruta, debería funcionar si tienes la carpeta js como toca


Please use the starting and closing braces always - even not needed in this case. But it is a good practice.


same, please add braces


please rename the "arg0" to "loader"


only minor comments - otherwise very nice.


Fixed in https://github.com/andrewblond/bem-walk/commit/a9ffaf62e6139a713549d37d3214e7466940ed91


These hexadecimal color specifications are always subject to change. If more colors are added at a later point, I would define them all together and use good labels for them.


Understood.  Thanks @xboxfanj for the clarification.  Good to know! Appreciate the prompt response!


wp -> Wordpress.


Damm copy/paste ! must fix


dope, we'll have to figure out how to deploy this later


@ktoso you may want to add these to your investigation.
Unfortunately I have not had time to try to track down the bug, but at least these changes will give you more clues.


some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2649
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1486
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1477


Ich würde sagen, das passt so. Mir würde auch nichts besseres Einfallen


Mein Vorschlag:

Gesellschaft & Gegner


> Oh, another thing, why they recommend to use eval-after-load? Are you using them? Thanks!

Yes, I use it a lot. It defers the execution of code until after other libraries have been loaded: it can be used to make sure that Ruby-related code is never executed when a user never opens a file in `ruby-mode`, for example. This makes the start-up time shorter.


Ça c'est pointu ! Hihi merci !


> Solution 2 would imply editing https://github.com/ludvichzme/SFML/blob/brew/src/SFML/Graphics/CMakeLists.txt#L99-L101 and https://github.com/ludvichzme/SFML/blob/brew/src/SFML/Audio/CMakeLists.txt#L38-L39 too, which can very quickly become a burden to maintain.

Didn't noticed those lines :)

DomT4 implentation is pretty good. But it seems that they prefer that extlibs installation is disabled on the sfml side, rather than in the formula.
So it seems that we should go for solution 3, and maybe we can use the following parameters in the brew formula :
-DSNDFILE_LIBRARY=$(brew --prefix libsndfile)/lib/libsndfile.dylib
-DFREETYPE_LIBRARY=$(brew --prefix freetype)/lib/freetype.dylib

(also, shouldn't it be done for libjpeg.a and libglew.a ?)

This will work with your idea for the CMakeList file, and there will be no additionnal user parameter.

What do you think ?


@ktoso Previous commit had a syntax error, this is the commit you're looking for (adding debug info)


Cool!
Will this allow weather changing from SD2? (There is a boss in AQ20 that starts sandstorm on aggro)


bad copy paste
Set {Opcode.SMSG_BATTLEGROUND_PLAYER_POSITIONS, 0x1BE9}^,

on {Opcode.SMSG_BATTLEGROUND_PLAYER_POSITIONS, 0x1BE9},


Congratulations!  Another good shot at king safety!


rfspeelpenning, C:\Users\USER\TribalTrouble, open file "Config" & insert:
online=false
reg_key=MAFB-9LAB-FUNL-VTAH
----------------------------------------------------
"ant run"
I've build TT and run it and in the game font is terrible, as 16-bit game and text is illegible (why?), but graphic of game is normal. And why is it run only on xp, while "binaries/TribalTroubleSetup.exe" works on Windows 8.1?
Also you can inserte next lines to "tribaltrouble\tt\classes\com\oddlabs\tt\global\Settings.java"
	//reg key
	public boolean online = false;
	public String reg_key = "MAFB-9LAB-FUNL-VTAH";
----------------------------------------------------
There "server" & "servlet" folders, but how to use files in these foldes and run server on vps (linux)?


upravene v dalsom commite


The output for complex function-like macros does not appear to be finished. This is a complex task, so I've just added the option to disable it. For my case, I can get by without these macros in my Ruby bindings, and generating them causes invalid Ruby code.


saw approval from pcwalton
at https://github.com/nikomatsakis/rust/commit/dc97247d112dc77bd709417d6bc870bbcfde9b54


merging nikomatsakis/rust/autoderef-overloaded-calls = dc97247d into auto


status: {"merge_sha": "39519ff5c181bc22faeb99dda947e3feed61fd8b"}


nikomatsakis/rust/autoderef-overloaded-calls = dc97247d merged ok, testing candidate = 39519ff5


Yeah, it would be useful to fuzz the macros.


No problem, Chet :)


Outputting a warning to alert the user the macros are being skipped (configuration by :skip_macro_functions option)


Had to update the was constant names were generated. See comment in code for explanation.


Thank you for the detailed response, I did send you a  [PR](https://github.com/timoxley/split-object/pull/1) for the same :)


This was causing some invalid Ruby to be generated. I first gave them generated names, but this wasn't very useful. Just ignoring them for now. After running the tests, no harm seems to be done.


You could have used the method with one parameter here.


index should prob be home with login/ register


Please remember to add JavaDocs, on every new method.


Making sure not to output invalid Ruby numbers like `SOME_CONST = 2U`


This method should be dropped.


Method with one parameter could be used here.


Thank you! I've just made you a collaborator so you can merge pull requests. Let me know if you have any questions.

About your #243, it looks like a good change, but to be honest I'm too confused by the number of various cases to handle to review it completely, but if you think your change is still useful, feel free to merge it yourself.

By various cases I mean:
 1. What if `reply->error() != QNetworkReply::NoError`? It will still show an error message ("Failed retrieving
list of docsets"), won't it?
 2. `availMetadata.clear();` called and another message box created in case of some weird failure: `!docset[1].startsWith("http")` - would it ever happen? I know I've added this check myself in 8a66b332988bf9f2dfc4fb5160b6dec3d7cab13b but honestly I don't remember why. Maybe it should be removed. `clear()`ing the list can make it empty even if the download from kapeli.com succeeded, so it looks wrong, so even if this case ever happens, I wouldn't do `clear()` there, and wouldn't show the error message anyway unless both downloads fail.

So basically your change is good, but seems like it could be incomplete and not fix all the issues - hence I was hesitating if I should merge it.


Is this a merge commit?


C'était exprès les create_one = function _ -> ... : ça permet "facilement" de tester des script en changeant la source... Le mieux serait de donner les scripts à exécuter en paramètres mais en attendant je modifiais ici.


@migueldeicaza I'm sorry, what is not indented?


Perhaps you should rename the method to get_european_union_vat_countries() ? Having a method called get_european_union_countries() return two countries which actually aren't members of the European Union seems somewhat non-optimal, despite the fact that the real meaning is now documented.


@tenderlove could you explain how you was thinking on simplifying these methods signatures? I'm working to remove this deprecated code but I don't know how to simplify it :sweat_smile:


Optimized solution.


Could you change this into an if statement? The short-circuit form is a little difficult to read.


Ah mince. Tu es libre de le rétablir.
Je ne voyais juste pas l'intérêt de l'écrire de cette façon, et ça me permettait de remettre le fichier dans la limite de 80 caractères à cet endroit.


@dpgeorge: FYI ("confirmed" part - using timeit module).


Fixes issue #140 " Invoice is sent even if you cancel the email form"


Yes it must.
Yes, but i want to clarify the function's signature first.

Poke @Grz3s or @virusav
Do you guys know any case where weather should be modified for an event or only in a small area instead a whole zone?

Assuming nothing else would have to get changed, one would likely use code along the lines of
```
        case TYPE_OSSIRIAN:
            if (uiData == IN_PROGRESS)
                instance->SetWeather(3128, WEATHER_TYPE_STORM, 1.0f, true);
            else
                instance->SetWeather(3128, WEATHER_TYPE_FINE, 0.0f, false);
```
or
```
diff --git a/scripts/kalimdor/ruins_of_ahnqiraj/instance_ruins_of_ahnqiraj.cpp b/scripts/kalimdor/ruins_of_ahnqiraj/instance_ruins_of_ahnqiraj.cpp
index 04bdfa6..394a4c6 100644
--- a/scripts/kalimdor/ruins_of_ahnqiraj/instance_ruins_of_ahnqiraj.cpp
+++ b/scripts/kalimdor/ruins_of_ahnqiraj/instance_ruins_of_ahnqiraj.cpp
@@ -175,7 +175,13 @@ void instance_ruins_of_ahnqiraj::SetData(uint32 uiType, uint32 uiData)
         case TYPE_MOAM:
         case TYPE_BURU:
         case TYPE_AYAMISS:
+            m_auiEncounter[uiType] = uiData;
+            break;
         case TYPE_OSSIRIAN:
+            if (uiData == IN_PROGRESS)
+                instance->SetWeather(3128, WEATHER_TYPE_STORM, 1.0f, true);
+            else
+                instance->SetWeather(3128, WEATHER_TYPE_FINE, 0.0f, false);
             m_auiEncounter[uiType] = uiData;
             break;
     }

```
Maybe you will directly get fine enough results in case of unsetting with
.. SetWeather(3128, WEATHER_TYPE_STORM, 1.0f, false); // Let system roll the next weather when it is time for an update


You reference the customButton element with $('#customButton').on(... in the script. It has to exist in the DOM at this point - the DOM needs to be ready.
Another way to solve it would be to wrap it in $(document).ready(function() { ... });. Then it should be called once the DOM is ready; right now it is called immediately.


This is a 404 on tip right now.  Is this supposed to be targeting sampi's AddJobs?  If so, the shape of that one is actually "/cluster/hosts/:host_id/jobs" at the moment.

Which way should this resolve?  Do we add a loop over multiple POSTs here (or would that violate some other constraints about atomicity or throughput)?


Didn't this cause the tests to fail last time? I think it was something about `ping6` becoming inaccessible...


develop (mjwitte) - x86_64-MacOS-10.9-clang-Debug: OK (1087 of 1087 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@GLolol It did and as no one opened a pull request, I did this again to open https://github.com/travis-ci/travis-ci/issues/3080.


Also, if you plan to keep using your code note that there is a missing </td> in the first one after the </h3>


one here


Lo diré de otra forma: ¿Programas con Glasfish o te has montado un Apache?


another here (missing </td> at the end of the line)


dabba


@cala Or you could just start an entry on the wiki somewhere and teach all of us mere mortals? :wink:


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1770](http://teamcity.monogame.net/viewLog.html?buildId=4154&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


con Glassfish


Well if you take a look a official 3.5.0 source a15 arch doesn't activate the vfp4 attr.
What clang prebuilt are you using? I am using google's


Est-ce que c'est la facon *recommandée* de faire les choses ou c'est juste un woraround?


Oh, good catch.  Could you please fix the other vars too?


r+


This had the unfortunate side-effect of converting some hard-coded "TRUE" constants in the macro to "true_". This logic has been updated in the next commit to only convert parts of the macro value that are also macro parameters.


> Didn't noticed those lines :)

I don't blame you, our build system is rather big. ;-)

Apparently setting cmake variable in the formula is considered as bad practice so solution 3 is not that great (I find that a bit strange but I'm not a brew guru and they have probably some good reasons). [See Mike's answer](https://github.com/Homebrew/homebrew/pull/35479#discussion_r22433930).

But now I realise we might be talking about slightly different solution 1: I had in mind that removing the extlibs folder would *not* be on SFML side but on the user side (brew, here). It goes without saying that I'm not dropping this folder and make the life of the majority of OS X users more complex, just to make brew formula one line shorter.

> also, shouldn't it be done for libjpeg.a and libglew.a ?

Very good question. I'll have to think about it (tomorrow, too tired tonight).


Organize imports in order: Scala/Java, other libraries, Spark


This commit made some trouble while trying to compile OpenBTS from this repo: https://github.com/Nuand/dev

The file dev/openbts/TransceiverRAD1/bladeRFDevice.cpp relies on BLADERF_FORMAT_SC16_Q12, changed that to BLADERF_FORMAT_SC16_Q11 in two places (around line 120-130), and it seems to work now :)


> Gnomeragan

I bet this is how the hate between the gnomes and the other races - obviously less versed in spelling - must have been started... :P


Field должен быть создан внутри QWidget-а, сюда передаваться по ссылке через конструктор.


ImageManager тоже должен быть создан в widget и передаваться сюда по ссылке.


Step by 10 or 100?  No need for so many iterations


Outputting a warning rather than failing the generation completely.


"length" --> "nonzeros" or "nnz"


The README file must not be edited directly, you have to update only the files in doc/ sub-folder of the module (there are also the authors and editors).

The readme is generated with:

make modules-readme modules=modules/dispatcher


I'd like to keep the vh.CommonMarkHelper class if possible. The methods implemented aren't necessarily specific to commonmark: it exists to abstract away the specifics of the AST, in case we want to move from CommonMark to Pandoc.... or from Pandoc to something else.


countLife тоже должен быть внутри field


Last I checked, we required that every heading be exactly level 2.


Where to save this files ?


Вместо этого что-то вроде:
field.MoveBita(true); // true - влево, false - вправо
field.StopMoveBita();


It appears that the default value  for the inactive threshold parameter is 3, but the documentation is mentioning 1:

"Default value is "1" (set active with first success)."

I guess this one here needs to be changed.


@bors: retry


This seems less helpful than the existing error message...?

I try to make sure the error messages are actionable: "fix this specific item" is more useful than "something is wrong". Any reason for the change?


Drawer должен иметь собственную ссылку на ImageManager, а не ходить в него через field


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1770](http://teamcity.monogame.net/viewLog.html?buildId=4154&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 293, ignored: 6 Build time: 00:16:30


Glad to know I'm not the only one who's ever accidentally pushed to master when I meant to make a PR :stuck_out_tongue:


We try to keep the lines up to maximum 80 characters (with tab size of 4 chars), to fit properly when looking at the source code on a terminal editor (e.g., the case of working via ssh). That was the reason to have the comment on two lines -- they should not be merged.


Это должно быть private.
Вместо этого - константные методы:
GetPoint(pointNum);
GetBrick(brickNum);
GetBall();
GetBita();
возвращающие константную ссылку на QImage или QMovie:

const QImage& GetBall()
etc


Thanks, to be honest i really don't now for what i need SELinux xD But of course i know it has something to do with security and encryption ... but i agree that on Android it's not really needed. :-)


r+


If we are doing this, then before shuffling, we should add some additional random data.  I would say 3 lines of each character length from 15 to 130.  Then shuffle to scatter so that these longer lines get scattered into the file.

I have implemented this in 4ae968f   I am running now to see what it flushes out.  We have needed THIS addition for a long time.


tttttoooollll


malo by to byt uz spravene na celom projekte


Wat


Variables should be declared at beginning of function or block (the standard C requirement, some still compile on old systems) .


3arg ArrayAdapter can be used when layout (2nd arg) contains id to TextView, so we can remove 3rd (resourcetextviewid) arg


:+1: I like it, it's a clear improvement.
About those JavaDocs - they won't add any useful information. It's completely clear what the code does by its usage, you can't clarify it any more with JavaDocs.


Wrm heb je dit verwijderd?


Hey David,

Sorry it was the third time I tried this commit and I didn't wrote a complete message,

Mainly is a cleaning commit, removing code that was not used on cooking (old), js that has been moved to mockup pattern that nobody thought that is still loaded in plone, jsregistry.xml that it was empty.

The other part is a compiled css/js for plone based on the instructions:
https://github.com/plone/documentation/blob/5.0/adapt-and-extend/theming/resources.rst

The other part is adding jquery as default on production mode ( we discussed that at the last framework team) Mainly there was a bug on the actual production env where we where loading jquery twice and select2 was not registered correctly.

The last part is moving to use less 2.1.2, we had a lot of problems on paths and grunt compilation because of the less version, so I adapted the generate_gruntfile.py and the code to be more optimal, there is no need to modify less variables twice now, and images and fonts can be embedded on data-uri.

About the broken tests, I already solved ( didn't remember to remove the test that check that old js is there ) and missed to add the plone-legacy-comiled.* on github.

What I really don't like is that bower components folders is a bit a mess everytime mockup gets updated, files change its paths... I don't see a way to deliver plone on dev without a bower components folder on the repo...


Функции с переменными не нужно мешать. И вообще, сделай всё по какому-нибудь style-guide, а то читать невозможно.
http://habrahabr.ru/post/150329/
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html


Als je de compiler-provided stdarg gaat gebruiken, roep va_end(args) als je er klaar mee bent. Ik weet niet wat 't doet, maar de C standaard zegt dat 't moet.


Het is wel fijn als 't terug gaat, dan weet je zeker dat 't aan 't begin van de lijn wordt geplaatst.


The history is managed via git comments now, currently there is an ongoing process to remove those from all the files. While is not relevant for this pull request to be accepted, just to have in mind it will disappear very soon.


Fucking hell. Ik had helemaal geen zin om die shizz te implementeren.
Why so try-hard? We gaan 't toch nooit gebruiken.


Thanks @phlipper. Typo fixed.


I think line number 77 should start with a capital S.


Could you add the missing periods?


"open them" maybe?


you need to adjust the usage output, otherwise nobody knows about the new options.


Try using git commit --author= or just cherry-pick


And besides, on this driver for Shamu the only scenario where this freq bug happens is when using load_based_syncs, which is a bit incomplete compared to the latest msm-3.10, my point with this patch is to filter out the migration boosts if the task load is < 15%, even when using the normal code path.


It's actually in the C extension, check out this line: https://github.com/adafruit/Adafruit_Python_DHT/blob/master/source/Raspberry_Pi/pi_dht_read.c#L38  Python C extensions have some conventions where their naming defines how python exposes the function.  You might want to check out a quick guide on writing a C extension to get an idea of the general conventions: http://dan.iel.fm/posts/python-c-extensions/


r=pcwalton


在初始化mainDao的时候，不是要传入两个参数吗？一个是Goodpath="F:\\index0.json",另外一个是List,在程序中，List和Goodpath都是文件路径，所以你这样写一个json字符串是会出错的。所以还需要一个List="F:\\list.json" 存放的是你写在List字符串的内容


博文辛苦啦，啦啦啦


It's actually `HTTP::Response::Body` :D


Good catch, will fix.


Keeping this code path here for obvious future re-use saves someone needing to rediscover this specific commit. ;)

I'm sure this whole script could benefit from a focused clean-up.


Fixed in 82b5dfa


3. TicTacToe.java


is there anything else i need to go with this commit to make it work? im working with a cm12 base and everytime i add this as a cherrypick with changes for my rom (just logo and logo name) my about phone settings f.c. Any input would be much appreciated.


If you look at the state controller in `SnakeGame`, with your logic, you move the snake and then check if the next move is valid - it doesn't give time for the player to change direction.


Also with your current logic, I think you'd end up eating your tail too soon here.


@UniversalMediaServer/developers is this change okay? It seemed like one of the checks was redundant but if not please let me know


I did the same but i must have read too much Lovecraft lately, and i can easily picture something that is not necessary evil but is wrong and out of place in this reality :3


<img src = "http://t1.gstatic.com/images?q=tbn:ANd9GcQJSYmkWndbpdP4MrwM1LA4DAtU3rZMcEE1ybLkkV78CkFEfnf7MQ">

i was thinking about small machine that draws something like that. you put it in a mirror or anywhere you want, and while you are taking shower, this device makes a drawing or some quotes.


The init script needs some patching: https://github.com/freifunk-berlin/firmware/commit/82a09a2f4480647b9dd51c0085d7e89fa44641ac#diff-fbb01f684d9bef30d1275d2e46707d0eL115


Original from curseForge


@mattcantstop what do you think about this?


Check out the test: https://freeshell.de/~iarthur/clockframe.html


drop http

just make it //..... on all of them


```diff
+        img.vid-screenshot(src = "//i.ytimg.com/vi/VERQEr-bVTs/sddefault.jpg", data-vid-id="VERQEr-bVTs")
-        img.vid-screenshot(src = "http://i.ytimg.com/vi/VERQEr-bVTs/sddefault.jpg", data-vid-id="VERQEr-bVTs")
```


@rasabbey i use Wart! Only and solely Wart..to the extent that yestrday i registered 400 senders on it! I don't even know that Android thing...


@bors: retry


It needs to be inside the git repo's directory. Other than that I'm fine with any dir we pick.


Well done, @aaronjorbin! Does Redis' `add` method behave the same as memcached's `add` method (i.e., does it only add the key/value pair if the key isn't set)?


Great! I've been busy, but I'll try to get this finished over the next week. Or did you want to do it?


r=alexcrichton p=1


what if channelName is 0 or false or an empty string or Nan or null or -0 ?


some traits we call "II" or "III" are simply higher modifier values of the existing trait. the only time we really need a new ID is when the name text is different in game. In the trait table there are fields for the and mod value to go with trait ID and modifier ID


People who give their channels silly names will experence silly behavior!


k


Finally fixed :D


Or is that the other PR?


It looks like this alpha is already in 0..1


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9733/testReport/) for this commit**


uhbuhbuhb


84694650_EnableCodeCoverage (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (1576 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:D Good! now gravel doesen Glitching!


@chiensiTB I assume these are the only lines that you really wanted to change! You overwrote so many changes that @chriswmackey and I made up there. I will go ahead and revert back and add your changes so we will have a fixed version dated as 2 Jan 2015.


Actually, that point of `bundler` was one of its weak points. And one of the reasons that `bundle update` wasn't recommended for frequent usage. But, nevertheless, those jars that have `-SNAPSHOT` at the end of their versions get updated daily.


asparams → params


I will also add this line.


fixes #99


Thanks! Never found these. GitHub! Add more feature to your editor!


See 53e46a228fe78382f053cd9764b59a45ab095efb


I am not sure if this would work correctly here because isn't $price a string?


For one liner docstrings, please keep the closing """ on the same line - PEP8.
Thanks :)


I think those assertions and the definitions of the `*_dict` variables do not bring much to the test but make it very hard to follow. I would just get rid of them and check keep the assertions that check the outcome of the calls to the `transform` method.


Zmien nazwe na HandCursorEnterEvent, bo CanvasInsideMoveEvent nic nie mowi


Thanks mkaluza.. now it is compiling like a charm xD


@casey-collab OK, I split the line in question in to two smaller lines, each less than 120 characters.


Ich muss zugeben, dass mir da momentan auch nichts besseres einfällt. "Leute" vielleicht noch, aber "Wer" trifft es auch...


> Apparently setting cmake variable in the formula is considered as bad practice

There's not a firm rule against it. It's more just we want to reduce the number of variables we feed ` CMake ` downstream as it's difficult to keep track on what upstream have removed or changed, and we can end up feeding it variables that end up doing nothing useful. In general, the more variables we feed, the more likely things are to break.

> 1: I had in mind that removing the extlibs folder would not be on SFML side but on the user side

This isn't actually too odious a step to have to take for Brew providing the folder doesn't move around too regularly, but presumably, you will always keep the extlibs folder in the top level directory, because that's where the ` CMakeLists ` seems to expect it, so we should be good. I don't *think* Mike would hate the idea of removing the folder regularly, It's easy enough to maintain. Mike can correct me if I'm wrong though.


I would change those to the unicode symbols for consistency.


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2650
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2997
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2991
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2992
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2983
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2983
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2986
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2979
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2974


Why the elseif?
Why don't you want to randomize the input file of a test just uses the top 160 lines of the word list?


I think it would be better to follow the format we've been using for getContent where we retrieve the data(comment) from the callback. (i.e. cb(cmts) in the second input of Comment.find.) there may be an instance where 100,000+ comments are assigned to one post, and it would be better to transform subset of cids into a comment than all the cids.


It would be great if you can pull my latest changes so I can merge your change into mine. I fixed a few bugs and made small changes.


You mean "try opening them" or "so we have to open them"? The problem is that we don't know yet whether we will be able to open them or not. Either the audio CD has extra content and Windows can't see the tracks as files or the path is just wrong (in which case it will fail later inside the source file).


Nice! It would be awesome if you could also include the api endpoints to add and get comments.
I would prefer those to be in the following format:
getComment GET /cid
addComment POST /pid/content (this needs to be synchronous since ordering of comments matter!) (fyi, you could retrieve the author of the comment from req.user so passing in author is unnecessary)


I think to be on the safe side and in order to allow several calls we could do, in ResumeGraphic()

    m_currentNode = m_currentNode.find_child_by_attribute("id", gId.c_str());
    m_svgNodeStack.push_back(m_currentNode);

And in EndResumedGraphic()

    m_svgNodeStack.pop_back();
    m_currentNode = m_svgNodeStack.back();

OK?

    m_currentNode = m_currentNode.append_child("g");
    m_svgNodeStack.push_back(m_currentNode);

And


Yep i realised, fixed already :)


I was only talking about grammar. Is it singular?


r+


Ik heb liever printf helemaal beneden dan deze stuff hier boven.


saw approval from alexcrichton
at https://github.com/akiss77/rust/commit/6e5fb8bd1bef7a36c32194b35ec16d0365adbcf1


merging akiss77/rust/aarch64-configure = 6e5fb8bd into auto


status: {"merge_sha": "496dc4eae7de9d14cd49511a9acfbf5f11ae6c3f"}


akiss77/rust/aarch64-configure = 6e5fb8bd merged ok, testing candidate = 496dc4ea


Well the singular here refers to the track we are currently opening while I refer to the tracks in general that all cannot be accessed in some cases. I can change to "try opening them" since I'm not sure the singular is right (even in French).


Good.


sure :)


So could we just use EndGraphic instead of EndResumedGraphic? Lines 210-211 do the same thing, and if bounding boxes are ever turned on, it wouldn't be a problem to have them on for beams, correct?


1: ok, i can do this
2: ok, maybe, i can try this
3: Yes, except when using the PPP programming style, then i guess it would
be better to use lower case when writing a subcomment, what do you think?

On Sat, Jan 3, 2015 at 5:01 PM, sebaste <notifications@github.com> wrote:

> Better to use some consistency in the comments. My suggestion:
>
>    - Always a whitespace after the comment starts (like is done for the
>    block comments).
>    - End non-header comments with a dot.
>    - Always use capital letters.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EmpathyApp/EmpathyApp/commit/685090dcf4afdbfba628ea9abc796b5d251dbf48#commitcomment-9142909>
> .
>

--
http://www.svenskafreds.se/fredskalender-for-goteborg
https://github.com/EmpathyApp/EmpathyApp/
http://ihavearrived.org/


Why do you need addLibraryPath? The test runs fine for me without...


@Schmoozerd as far as I know the weather can't be unset in AQ20. Once the sandstorm starts (on boss aggro) it won't stop until the next instance reset.


Then write a trivial PR to fix the safety issue.


Can you remove the extra tab spaces on `140` & `141`?


we'll use this abbreviation i think, it's so common in our code. here is a list of abbreviations: https://github.com/EmpathyApp/EmpathyApp/wiki/Abbreviations


how can user data is accessable, if we uncomment above code then user.email shows error can you help me out! on this


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.90012642225032%25-red.svg)


Il faudra aussi lister les mods qui ont été customisés/adaptés sur le serveur pour ne pas avoir à reproduire les modifications.


I've just been thinking that doing that is a mistake because the player is not set at this level. I will rollback that.


I'd prefer to have the keep EndResumedGraphic for clarity and consistency.
It could also be problematic with the BBoxDeviceContext not to have it.

On Sat, Jan 3, 2015 at 9:25 PM, Andrew Horwitz <notifications@github.com>
wrote:

> So could we just use EndGraphic instead of EndResumedGraphic? Lines
> 210-211 do the same thing, and if bounding boxes are ever turned on, it
> wouldn't be a problem to have them on for beams, correct?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DDMAL/verovio/commit/45bd6bffd1e5a3ad45b191a725058623490541de#commitcomment-9143588>
> .
>


doh! thank you for this, important because this could lead to problems otherwise (even if the order is the same as now)


This is available now -- you just have to request the custom data inside of your route code first -- I just showed an example in the issue =)


r=alexcrichton


J'ai aussi ajouté une liste en "*raw*" depuis les logs des variables globales à corriger pendant le *boot*, il faudra travailler dessus au plus vite.


disasm is your friend


Take a look at libuv repo.


I think you meant to pass `authbox_digest` here


The addition of these conflicts has broken it:
The following inconsistecies were found: UniversalStorage conflicts with UniversalStorage-KAS.
Error!

You can't install UniversalStorage-KAS if it depends on UniversalStorage but UniversalStorage conflicts with it.


r+


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@eventualbuddha @stefanpenner @Rich-Harris @thejameskyle Currently only fails 16/62.


I had to dig up the old discussion about this.

http://forum.xda-developers.com/showthread.php?p=36748649#post36748649

At least it seems to increase latency quite a bit.


Thank you -- fixed by 6728cc0dcd51ef5f63974a8f7f4fc25ceae628e1.


revert-4649-VarHPWH (mjwitte) - x86_64-MacOS-10.9-clang: OK (1576 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Bug是如果是管理员删的帖子，就会扣管理员的分数。这个Patch修复了这个Bug。


The server constantly calculates the ping for online players, there is not really a packet or something similar to fetch this from the client. So this method should be actually `getPing()` in my opinion.


The tradeoff in readability is too big for the performace I guess.


There are other classes with this alias method, like `Keg`, `Version`, or `Bottle::Filename`. Does your FIXME means all these methods should be deprecated, or just `Pathname#to_str`?


And even further back there's more explaining about its effects in practice:

http://forum.xda-developers.com/showpost.php?p=36717931&postcount=104


@SvePu - could you please check my changes? Thank you


Puedes encontrar direcciones reales de ejemplo [aquí](http://www.spamhaus.org/sbl/latest/)


It doesn't look like `STRING_PATTERN` is used anymore but if it is, the change will not match `foo-bar` strings anymore.


Yeah, it works fine without it. Mistake on my part.


ref: [https://github.com/jekyll/jekyll-help/issues/112](https://github.com/jekyll/jekyll-help/issues/112)


If you just want to make `await` a contextual keyword (i.e. free these names for use for variables, etc, otherwise), I think there's still no real need to create a dedicated node type for it.

We already have some "virtual" token types, such as `js2-CALL`, so passing the new one here to `js2-make-unary` should be sufficient. Removing them from `js2-kwd-tokens` is a good thing, though.


Oops! Thanks for the catch!


Neat! :fr:


Any idea why my build had proper size without this commit? I haven't tested it myself, but it seems to be ok.
http://mfi.re/?z83nwy7i1gwh0po


The "uncomment the following 3 lines to build on Windows" is not really correct, as it calls VBCC cross compiler from on a Unix-like host system to produce AmigaOS executable. I don't even use Windows :P.


in progress


Eh, this looks kinda ugly. I'd try to avoid this irregularity, if it's at all possible.


Maybe check to see if they already have a Fire/Fighting/Ground move first? I'm pretty sure something like Medicham won't be happy with Flamethrower accidentally overwriting its High Jump Kick, which works even better against the machines.


are you sure you are getting a proper dt.img ?? wat size is the dt.img i get a 1.2mb dt.img where it should be 4 or 5mb


Shameless plug, I recently built an updated version of Glyph's script that's a bit more resilient and similar to zsh. Feel free to check it out and give feedback if you're interested in updating. It's called bash-preexec. https://github.com/rcaloras/bash-preexec


Typo! canloa instead of canola


Closes #17


For code blocks that can be run as doctests, put them in a

```
.. doctest::
```

block. (strongly preferred)

At the very least, `For example::` will put the code in a quoted block.


I @mikelove, thanks for this detailed review. We will work on this in the next days. Your last points are already addressed. Our main problem is to keep track with the fast pace of DESeq development. If you think you can put a script similar to ours into the main distribution, this would help a lot.


I've never used JSON, but agree that's quite a lot nicer than XML.  If we ever feel the need to redo this .ini reading, that'll be the way to go.

Even though this GetPrivateProfileString comes from Windows 16 bit, it still seems like it works easiest and simplest for us at present.  Gives us a lot of flexibility for letting end-users change things.


I know the actual drawing of the test cold have been done with a for statement which would have made it cleaner but its just a test so I didnt bother.


It should be TOKEN, not `token'.

I'm not sure I like how the highlighting happens in a predicate function (I would expect it to only answer a question, and not modify anything), but the last optional argument is extraneous for sure. Why have it? It's not used anywhere.


TeamCity ChameleonForms :: Continuous Integration [Build 208](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3477&buildTypeId=bt20) is now running


```
:obj:`Rational`
```

instead of

```
``Rational``
```

and so on, will eventually enable these to be cross-referenced properly.


:clap: :clap: :clap: :fireworks:


A convention for naming: these variables should start with a lower case. Typically we reserve names that start with a capital for Packages or Classes.
ie: dan = Person()


Please move all the lines so it looks like one paragraph.


this probably didn't run for you. I believe the more complex math operations are under the math package.
arcsin = math.asin


I think this should be 03.01.2015 not 13.01.2015


> Just moving the block gives parse error

Ah, right. In addition to that, after (and if) we do `js2-ts-seek` later, we'll also need to account for possibly having `async` as the next keyword. So we maybe-match it again, and pass the result as the 4th argument to `js2-parse-function`.


Btw, have you managed to run these tests from your IDE? I'm using intellij and the current setup only allow me to run tests from a separate maven module (or project).


Wenn ich `https://www.münchen-transparent.de/` (mit ü) aufrufe, bekomme ich bei firefox eine Zertifikat-warnung angezeigt: `Das Zertifikat gilt nur für folgende Namen: www.hoessl.eu, hoessl.eu`)

Wäre es deshalb nicht besser, ein Weiterleitung auf die Version mit ue statt ü einzurichten?


TeamCity ChameleonForms :: Continuous Integration [Build 1.2.1-PullRequest111+002](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3477&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2998 Build time: 0:0:0


TeamCity ChameleonForms :: Continuous Integration [Build 209](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3478&buildTypeId=bt20) is now running


Only succeeded from Maven so far :)


package ch03fundamentalstructures.ex01;
import java.util.Scanner;

class StringReverse{
	public static void main (String [] args){

		String reverse="";
		Scanner input = new Scanner(System.in);
		System.out.println("Enter the input");
		String userinput = input.nextLine();
		System.out.println("The entered value is: \t" + userinput);

		for(int i = ((userinput.length())-1); i>=0; i--)
		{
			reverse += userinput.charAt(i);

		}
		System.out.println("The entered value reversed: \t" + reverse.toLowerCase());

	}
}


Good stuff. I think there is plenty more to do in terms of testing also.


+1 for Windows ME joke


Please put a comment here, why `rm -f` is used instead of `file: state=absent` and why this removes `sources.list.dpkg-divert`


Indeed, I just usually start with some cleanup before making any changes ;)


Yeah, this needs work :-)


Related #10


line 65, 66 indent them by 2 more


- It's not "the Middle Earth", it's just "Middle Earth".
- lol using "rekt" instead of "wrecked"... yeah I can get behind this


This line is causing XL failure:

/opt/ibmcmp/vacpp/bg/12.1/bin/.orig/bgxlC: 1501-230 (S) Internal compiler error; please contact your Service Representative. For more information visit:
http://www.ibm.com/support/docview.wss?uid=swg21110810


saw approval from jdm
at https://github.com/servo/servo/commit/d5c64f7f30054996e4db70d59cc6fb34e0be987d


merging servo/servo/pre-rustup_20141221 = d5c64f7f into auto


servo/servo/pre-rustup_20141221 = d5c64f7f merged ok, testing candidate = 98b8f175


Not removed graphically because TicTacGo.java line 726 is not being run. I'll have to look at what collision resolution used to be done in TicTacGo.java and incorporate that as well.


TeamCity ChameleonForms :: Continuous Integration [Build 1.2.1-PullRequest112+003](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3478&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2998 Build time: 0:0:0


Of course, how could I forget :P


This needs another name. It's ok to have primed (`'`) names on local variables/functions, but not as part of the public API. Though personally I'd just delete this function.


might get annoying :wink:


Find any issues?


I don't see the need to target v4.5 here... were you getting some particular error?


I missed this earlier, but both

```
``Int``s
```

and

```
obj:`Int`s:
```

are invalid ReST. The trailing 's' needs to be escaped:

```
:obj:`Int`\ s:
```


@fefifofum That was real quick. :+1: . I would like to contribute to CAF latest lp or kk tag port if you don't mind :)


I don't see the need to switch from FAKE to Rake.


Methods for getting relevant data instead of figuring out which Arguments[*] to use.


Nice.


Will need to look at changing the encoding of the whole file. Just changing this is going to cause a mismatch.


yeah? :)


@eht16 first thanks for testing on Windows and for the Windows snapshots - looks pretty good now.

Regarding the standard icon names, the names mentioned here should be used:

http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#names

I also found a handy table mapping "stock id" to "standard icon name" here:

https://docs.google.com/spreadsheet/pub?key=0AsPAM3pPwxagdGF4THNMMUpjUW5xMXZfdUNzMXhEa2c&output=html

So it seems that "text-x-generic" should be used instead of "gtk-file". The ui_get_mime_icon() patch from https://github.com/geany/geany/pull/396 fixes the problem in the Documents tab for me (I haven't seen the issue in the context menu so I'm not sure if the patch addresses it or if it's a different code path).


Forgot to mention there's the strange case when GIcon is returned but then no icon is rendered for it - there's some more discussion here https://github.com/techee/geany/commit/7880c0fc123da98ffa0881f84c93714c60526ac6


Only pathname, since it was removed upstream in Ruby. This was added years ago to make Homebrew run on 1.9+, because we pass pathnames to methods that expect "string-like" objects in many places.

I've attempted to make good on this several times, but each time it was just too much work. I've settled for fixing places that rely on it as I notice them.


@Simn maybe we could try to improve performances of haxe.xml.Parser in Flash ? That could be for instance to write the string to a ByteArray and read its bytes using array access (which should be faster than using fastCodeAt) or even with flash.Memory


I admit I don't know much about Paket, but Fuchu is a pretty small project and we're not using github-file-references here, so I don't think it's worth it...


Ah, thanks. In exchange, I'll try to remember to add `[av skip]` to the next commit message ;)

Is the docs format itself documented somewhere? I've looked around a bit for references but found none (in `CONTRIBUTING.md` and `doc/README.md`, for example), so I'm mostly just copy-pasting syntax that I see in other parts of the docs. Obviously, that doesn't always turn out right...


These changes to the hash function look good to me.  I think that at the moment no one is using the hash function for textures, with the exception of the Bioshock Infinite fix, which uses the texture based ShaderOverride.

That means this will break that fix, but that is probably OK given that the HelixMod fix is preferred. It lowers the example value of the BI fix, but I think that is OK.  I would not put in anything special to keep that working.  If we think it's useful we can go back and redo the BI fix using this new code.

I think that we should rename the routines though to use the coding style that is already in place.  I'll address that in a different checkin comment.  Switching to all lower case with underscores like 'record_resource_view_stats' makes it needlessly confusing.  All lower case in this code base is almost always a local variable, not functions.

The coding style here is starting caps with InterCaps (camel case).  It's my belief that any one coding style is not better than another- the important part is consistency.

I also see that I have been inconsistent with some of my own routine names, starting some with lower case.


This line is causing an IBM XL compiler failure:

/opt/ibmcmp/vacpp/bg/12.1/bin/.orig/bgxlC: 1501-230 (S) Internal compiler error; please contact your Service Representative. For more information visit:
http://www.ibm.com/support/docview.wss?uid=swg21110810


Nope, I think this should go in the ``runtests`` test suite to avoid regressions.


By the way, is ``:obj`Int`:s`` valid?


This could be moved into `defaults/main.yml`, couldn't it?


This seems like a good choice.  The naming was attempting to keep them small, and also the most common abbreviation used by forum dwellers.

If it makes sense we can also make another build target for FC4. In general I was making them a one-stop build, including zipping the ShaderFixes into a single zip with a post-build script.  Not sure that's necessary anymore, but maybe.


An Error


Instead of adding this event.key in self.keys condition, you should make a try: except: I think. The keys in self.keys tell us in which direction the character should go for each key in WASD. The keys for the spells and the space key will not act the same way as those, so they should be handled differently.


Upload files


No support for quoted searches at this point.


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/449


The Server chrashed and there stand:..../scr/Block.Hunt/BlockHunt.....line 99


I would just check all of the png_*() function calls.  If any of them throw compiler warnings or use typecasts, check them out.  The png_uint_32 was defined as "unsigned long int", which will be 64-bit wide under linux 64 due to the 'long'.


<#result3 --> (/,^add,1,2,_)>.   <- the subject i meant, not the predicate


This addition also needs to happen in `mkxp.pro`.


If this code is dead we should just remove it.


No, I don't think that is valid syntax.

Sphinx documentation syntax is documented [on their website](http://sphinx-doc.org/contents.html). It supports ReST syntax, which is fully documented [elsewhere](http://docutils.sourceforge.net/docs/ref/rst/directives.html).

You can check locally if the docs build with `make -C doc html` and `make -C doc latex`. (Best to check both formats; sometimes errors only show up in one format but not the other.)


I think if the game controller subsystem takes care of closing any open joysticks. At least that's what valgrind is telling me (ie. `SDL_JoystickClose` is no longer required).


done


How do you know the prompt's going to include the username?


Is lens-action planned to be on hackage? hspec-expectations-lens already fails to build :)
```
Building hspec-expectations-lens-0.3.0.0...
Preprocessing library hspec-expectations-lens-0.3.0.0...
[1 of 2] Compiling Test.Hspec.Expectations.Lens ( src/Test/Hspec/Expectations/Lens.hs, dist/build/Test/Hspec/Expectations/Lens.
o )

src/Test/Hspec/Expectations/Lens.hs:145:49:
    Not in scope: type constructor or class ‘Acting’

src/Test/Hspec/Expectations/Lens.hs:147:10:
    Not in scope: ‘^!?’
    Perhaps you meant one of these:
      ‘^?’ (imported from Control.Lens),
      ‘^?!’ (imported from Control.Lens),
      ‘^@?’ (imported from Control.Lens)

src/Test/Hspec/Expectations/Lens.hs:147:14:
    Not in scope: ‘acts’
    Perhaps you meant ‘acos’ (imported from Prelude)
 * ERROR: dev-haskell/hspec-expectations-lens-0.3.0.0::gentoo-haskell failed (compile phase):
```


`SDL_CONTROLLER_BINDTYPE_NONE` unhandled.


Fair point. I guess we should use base_prompt?


Why is this called PlayerConnection? Horrible horrible name.

The Mojang server has multiple protocol states. You should instead call this PlayerPlayProtocol or something like that.


ffg


When a client is connected to the server, there is always a Player as this would interface to NetHandlerPlayServer.


This should be `m.Loaded && !m.HasChanged()` or else it won't identify changes to the mesh properly and the device implementation won't reload the mesh at all. See #88


Thanks; although I didn't see this before I pushed my fix, I've been able to test now that the docs build locally. While I'm at it, I might as well add that info to `CONTRIBUTING.md` =)


Yeah I'm sure there are some optimization opportunities. The main problems remains Xml itself though.


This seems like a fine change to move all that verbose and duplicate code into a subroutine.

Not sure about the routine name of 'wrstrip' though, as style-wise it looks like a c-library function like 'strlen', or 'swscanf' but it's not, it's local.  Not a big deal, but it would be nice to make it more obvious that it's our function.


Nice. Could you put this in FactCheck format?


Comment test.


Bad method.

You should require registering of "channel messages" and abstract ByteBuf to the API.


@bors: retry
* #3595


Dummy players are Agent, not player.

This should never be Optional.


Maybe instead of ByteBuff, we could just use DataInputStream?

> registering of "channel messages"

I can see registering channels, but channel messages?


Quite quick RC phase. :| :-1:


Yeah, that's what it was invented for :)
Doesn't that make ssh a simple helper function for login though?

On Sat, Jan 3, 2015 at 9:32 PM, Stephen Hazleton <notifications@github.com>
wrote:

> Fair point. I guess we should use base_prompt?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lathonez/shutit/commit/cb8d03b2c7eba26ad840a4ca8b8d684a44bdf782#commitcomment-9143770>
> .
>


Sure, that would be a good idea.


For this heavy changes, I ignored the Cito support (only for the first 2-3 steps)

I started with removing a lot (shadows, slopes, etc.).
After the basics and shadows where running again, I made this commit.

In the next [Commit](https://github.com/TobiMob/manicdigger/commit/d7d769235864e227494e0c2b689828e98bad3b44) slopes and smooth shadows seem to work.

In my next step I will restore the Cito support and check with a profiler, if I messed something up.


saw approval from jdm
at https://github.com/servo/servo/commit/d5c64f7f30054996e4db70d59cc6fb34e0be987d


merging servo/servo/pre-rustup_20141221 = d5c64f7f into auto


servo/servo/pre-rustup_20141221 = d5c64f7f merged ok, testing candidate = e8fac368


I had a script by you that saved a bunch of diagnostic information about SketchUp to a file. I can;t find it - do you have it?


Not quite sure how to do that, since ideally you'd want to store the affine expression that breaks the testing.


Removed in the next commit of this PR.


Also fails travis on 0.3.


@dawnthorne, any objections/issues with this?


You don't actually call login though, you just want to set the prompt?

Can you paste the code you'd suggest as an alternative (e.g. not having the helper)?


pierwszy zestaw


Path.GetDirectoryName(document.Project.FilePath)


cool.. will change


For this change, and subsequent usage of this logging, I really think this is not a good approach and should be reverted.

Logging is one of those endlessly debated time-wasting things, and this just changes the logging without actually improving it.  Having the 'if Logfile' encapsulated is nice, but I think is not worth the refactor cost.  Right now, with this change, we now have two different forms of logging in the same file, and I think that is bad.  Either do them all, or don't do any, is what I would suggest.  Switching styles mid-file is needlessly confusing.

Also for refactoring everything to use a new logging, I would humbly suggest that is not a good use of time.  If we are going to improve logging from this low-budget approach, we should just bite the bullet and bring in a real logging subsystem like Log4C and do it for real.

Please keep in mind that I have personal pet-peeve with people building their own logging systems, so this can easily be just my own personal tic.  But my only real complaint is that I think it must be consistent.


r+ rollup

Thanks!


Hello, thank you for this idea!! I was copying a built libart library because I don't really master Android's makefile :p.

Your solution makes the devices boots but there are still some segfaults left.

Here is a commit I made based on yours and getting rid off all sefgualts.

https://github.com/Khaon/android_art/commit/6ab888efd4d149b3d4dddf33fa9bd253d2b29009


Testing for localStorage in progress..


Ah, I see!
Great to see someone working on rendering code :)
Looking forward to the finished version.


oops thanks


dobavlenie DB + sozdal content types


@gibiansky does that actually work for you ? I wonder how it would. I just had a look at this again. In fact neither my initial change nor your version make sense to me now. When you set formatexpr it will be invoked on every single keystroke in vim. This won't work at all because hindent will get invalid content most of the time.

Locally I just changed it to this :
```vim
if has("autocmd")
    let hindent_filter = "hindent --style " . g:hindent_style
    autocmd FileType haskell let &formatprg=hindent_filter
endif
```


Fixed #101


Why?


What do you suggest?


```php
const PREFIX_NULL = "[n/a]";
//...
return self::PREFIX_NULL;
//...
```


who did this @danielgrimshaw
@ZachOhara


Isn't there an extra `'` at the end of the IP?


@sirmordred I get this when I try to compile with these changes.
http://pastebin.com/eKUg8fZ1


Great, will try that tomorrow and let you know! :)


Yes, it was FsCheck that wouldn't compile otherwise.


Right, I had trouble bending FAKE to my will, that's all.


Why not?


Interesting.  Not sure this is worth the risk of invalidating all those prior generated files.

Also, this is doing an odd thing that is not really Windows oriented to strip that null.  It's swimming upstream if the D3DDisassemble provides a Blob with an ending null, and we go out of our way to remove it.  Not sure of the full ramifications here.

Hasn't really proven to be a problem for all the files I've looked at, but maybe the tools you use don't handle this well.


How is nuget's buggy target files any better? What's the extra large cost of paket?


r+ rollup

Thanks!


commit for fixe this example: <rect x="2" y="2" width="50" height="100" rx="10" ry="10" style="stroke:black;stroke-width:5px;fill:none;"/>


all tests pass:
success: http://build.servo.org/builders/linux1/builds/451
success: http://build.servo.org/builders/linux2/builds/450
success: http://build.servo.org/builders/android/builds/486
success: http://build.servo.org/builders/mac1/builds/667
success: http://build.servo.org/builders/mac2/builds/668


```files``` now is a special field so starts with ```_```. But I think that the control on the string type will be usefull.


@bors: retry


@Montellese when starting newly added music from the home screen - they are not played in order anymore with this commit - seems like a sort attribute missing now?