**In the first pic:** The permanent and temporary columns may be combined, as far as i understand the system, an IP may not be blocked temporary as well as permanent at the same time. It can be converted to a switch between temporary and permanent. The lift ban option in the third row (temporary ban) can also be made to be orange in color to just sync well since the permanent ban has a red button. Also sorting based on column header may be implemented. It could help to view the data as the user would want when there are a lot of rows.

**In the second pic:** The dialog options `yes` and `no` can be of different colors just to make identification of options a lot easier.

Otherwise looks pretty usable! :)


문제도 같이 올려주시면 좋을것 같은데요 흠


Crees que esta clase funciona más como servicio? Que tal renombrar la clase a PalabraService? crees que debas crear una interfaz?


아닛 혼자만 문제를 풀고 있다니 ㅋㅋ 같이좀 풀어여


actually, urls.py is a bit special than other Python source files. force to apply PEP8 spec to such file does not give any benefit to it and developers. In contrast, it'll make code hard to read, and it'll easily break another PEP8 spec, the max length of each line. So, how shall we face this two situation at same time? Eventually, you will find that no changes to the original way is a good choice, and be extensible, solid for writing and reading code in a long time.


No we don't, the sysfs interface allocates a buffer of PAGE_SIZE, buf will not be lesser than PAGE_SIZE. Interface will not get called with NULL buf


@johache opened this [as an issue](https://github.com/Temasys/AdapterJS/issues/39) apparently this is too fundamental and needs to get fixed.


I think you forget to write tests :)


@nguyenq Can you tell me what src base you use for "tesseract 3.04"? I dont see any tag/branch for 3.04 in tesseract src repo at google code.

Do you think you can release it now?


I thought the sing-in was after review, sorry about that. I had checked the ceph kernel commit messages before this and apart from ceph: tag,  did not find anything specific to be followed. Let me know if I am missing anything other than the signoff


( ͡° ͜ʖ ͡°)	( ͠° ͟ʖ ͡°)	ᕦ( ͡° ͜ʖ ͡°)ᕤ	( ͡~ ͜ʖ ͡°)
( ͡o ͜ʖ ͡o)	͡° ͜ʖ ͡ -	( ͡͡ ° ͜ ʖ ͡ °)	( ͡ ͡° ͡°  ʖ ͡° ͡°)
(ง ͠° ͟ل͜ ͡°)ง	( ͡° ͜ʖ ͡ °)	(ʖ ͜° ͜ʖ)	[ ͡° ͜ʖ ͡°]
ヽ༼ຈل͜ຈ༽ﾉ	( ͡o ͜ʖ ͡o)	{ ͡• ͜ʖ ͡•}	( ͡° ͜V ͡°)
( ͡^ ͜ʖ ͡^)	( ‾ʖ̫‾)	( ͡°╭͜ʖ╮͡° )	ᕦ( ͡°╭͜ʖ╮͡° )ᕤ

╚═( ͡° ͜ʖ ͡°)═╝
╚═(███)═╝
╚═(███)═╝
.╚═(███)═╝
..╚═(███)═╝
…╚═(███)═╝
…╚═(███)═╝
..╚═(███)═╝
.╚═(███)═╝
╚═(███)═╝
.╚═(███)═╝
..╚═(███)═╝
…╚═(███)═╝
…╚═(███)═╝
…..╚(███)╝
……╚(██)╝
………(█)
……….*


these are option keys, which indicate to the user-code if a particular option key is supported (for example crc/nocrc both belong to the same option key crc). This is the initial options export commit, tcp_nodelay is added in the next commit


Intentional? Just checking as it seems unrelated.


Please enable ds for dual sim


Yet another one of these bug fixes. I wonder if we should automatically pass all options to the Template.


Yes i forgot to do a separate commit. It is not working well with all servers so it has to be off for now.


Lets minify script after I merge here. Here is your starting point

http://jscompress.com/


memset(result_idx, 0, sizeof(result_idx));
이것도 괜찮을 것 같습니다.  그냥 개인 취향입니다...


memset(result_idx, 0, sizeof(result_idx));
여기도 그냥 개인 취향입니다...


ай вей


TeamCity Ybackend :: Feodorov/ybackend [Build 65](http://192.168.30.225:8111/viewLog.html?buildId=556&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 122](http://192.168.30.225:8111/viewLog.html?buildId=557&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


ай


TeamCity Ybackend :: Feodorov/ybackend [Build 65](http://192.168.30.225:8111/viewLog.html?buildId=556&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:01:45


TeamCity Ybackend :: Feodorov/ybackend [Build 66](http://192.168.30.225:8111/viewLog.html?buildId=558&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


TeamCity Ybackend :: Feodorov/ybackend [Build 66](http://192.168.30.225:8111/viewLog.html?buildId=558&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:01:46


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 123](http://192.168.30.225:8111/viewLog.html?buildId=559&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


Here you can us another name as "uploadhi" or "level"


This should probably be removed.


All the echos are printed outside of the <body> markup


Setting Browser vendor prefix to last 2 versions


@breskeby why port to jets3t - smaller footprint?
I don't think  [jets3 supports ec2 instance metadata] (https://bitbucket.org/jmurty/jets3t/issue/163/provide-support-for-aws-iam-instance-roles) I was hoping to support ec2 instance metadata auth as sometimes there can be strict security policies prohibiting AWS credentials on CI platforms, environment variables, build files, config files, etc.


Make this line a link to the file


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 122](http://192.168.30.225:8111/viewLog.html?buildId=557&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:10:09


It should be rather 2013-2015


Semantic 이 조금 바뀌는데요.  밑에 코드는 null 이면 null return.  여기는 null 이면 assert.


Also add a <img src="" border="1"> to preview the uploaded image


Is this intentionally done before cancel call on the encapsulated stream?


hey, cool stuff, just looking at this branch. you're doing the needed cleanups that I haven't done :)
just wanted to say that I did not do model-parallel for overfeat like this, as the resulting network is actually not equivalent (the number of parameters is reduced, as only feature maps are connected within a GPU), so the resulting network might give lower or higher error.

For overfeat, or OxfordNet, it is preferable to do DataParallel (using nn.DataParallel)


if you would like an example for DataParallel, I am happy to help.


To late


If you make a pull request I could merge it. Cheers.


TeamCity Ybackend :: Feodorov/ybackend [Build 67](http://192.168.30.225:8111/viewLog.html?buildId=560&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


For this first upload level, I think we can remove most of the checks and be minimal


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 123](http://192.168.30.225:8111/viewLog.html?buildId=559&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:09:59


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 124](http://192.168.30.225:8111/viewLog.html?buildId=561&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


sun pls


TeamCity Ybackend :: Feodorov/ybackend [Build 67](http://192.168.30.225:8111/viewLog.html?buildId=560&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:01:45


Shhh. Comments don't need to be correct.


TeamCity Ybackend :: Feodorov/ybackend [Build 68](http://192.168.30.225:8111/viewLog.html?buildId=562&buildTypeId=Ybackend_FeodorovYbackend&guest=1) is now running


U DONE MESSED UP


Hi @truebit I haven't found a better place to contact you than your latest commit.

Are you planning to create a pull request with you changes to `jenkinsci/clang-scanbuild-plugin`?
If I compile and install your .hpi plugin manually, will I lose the automatic updates from jenkinsci later in the future?

Thanks for spending time on this plugin :)


test


why should `domain` allowed to be `nil`? I would suggest raising an error.

if it's only for email validation, then I'd be willing to refactor email validation to a new class and submit a pull request.

note: this 'feature' cost quite a bit of time trying to debug what was happening: Mailgunner gem was initialized before`MAILGUN_SMTP_LOGIN` was pulled in from `dotenv` gem


TeamCity Ybackend :: Feodorov/ybackend [Build 68](http://192.168.30.225:8111/viewLog.html?buildId=562&buildTypeId=Ybackend_FeodorovYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:01:45


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 125](http://192.168.30.225:8111/viewLog.html?buildId=563&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/10136/testReport/) for this commit**


@jbenet im trying to figure out where this commit is... it says its on fix/ipns, but it doesnt appear to be


The count should be done on the actual services list, not on the size of the output. That makes the code more resilient to change.


Looks much better, thanks.


All test cases are done with Password Validation task.. Check you all and if any changes are their  then let me konw..
@amitheda @anushamh @gauribhapkar


RETURN_WITH_ERROR => WITH_ERROR 변경은 alloc 실패했을때 leak 발생 방지하기 위해서인가요?


Was this an intentional change to remove the call to `__initialize`?

Note, the significance is that it removes the ability to pass  `stores: { ... }` into the Reactor constructor.  Didn't know if that was an intentional API change.  I noticed that you did rename `attachStores` to `registerStores` ... didn't know if that was in an attempt to promote the use of setter injection over the constructor injection.

We should update the docs either way.


This array does not own its data, as it is a view of the flat 24 item arange, so the checks for the result of rollaxis not owning their data aren't really checking whether rollaxis is returning a view. I guess adding `.copy()` at the end is all that is needed. although having an `assert_(a.flags[`OWNDATA`])` right after this line won't hurt.


I've lessen the blue by a touch, what do you think lesdmark?

![ingot_tin](https://cloud.githubusercontent.com/assets/6283808/5796939/f2047238-a000-11e4-84a2-1e6af2634520.png) ![ingot_tin2](https://cloud.githubusercontent.com/assets/6283808/5796930/e2e103fc-a000-11e4-8b69-5deeec1b363f.png)

Also I've re-sized the gold ingot and made them both the same positioning as the rest.

![iron](https://cloud.githubusercontent.com/assets/6283808/5797122/48ae8c4c-a004-11e4-8c60-c10dff912e46.png) ![gold](https://cloud.githubusercontent.com/assets/6283808/5797121/472c618c-a004-11e4-806a-efbc0ff97017.png)


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 124](http://192.168.30.225:8111/viewLog.html?buildId=561&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:10:00


done


Kitty, I believe there is a bug in BlockCharcoal and BlockToolRack, that was introduced in this commit.

The method removedByPlayer is creating a cyclic reference in the Block base class.

Each time you try to remove a toolrach or charcoal block the client/server crashes.


7a2c038580cf56a9276e8a1b723c6a324a1d6da9
@amitheda @gauribhapkar @anushamh


This is nice! Shouldn't we have something similar for `get closed`, too? Promises obtained using `get closed` before lock release continues exposing the encapsulated stream's `closed` while promises obtained after lock release points at `[[closedAfterRelease]]`.


Does not have to be static.


In my oppinion resizing belongs to initramfs. Much safer and would always work.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 125](http://192.168.30.225:8111/viewLog.html?buildId=563&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 9 Build time: 00:10:13


try to give number to each values


기존 코드는 [MAX_KEY+1], readline(... MAX_KEY ...), 여기서 길이 -1 했는데요.  이것이 필요한진 모르겠습니다.  -1 하는 것이 맞다면 MAX_KEY + 1 으로 변경해야 할 것 같은데요.


예.. leak 방지입니다.


I understand the rest of the changes, but why this one? Is it related to adding the prefix?


Nope, removed it now.


J'adore travailler pour rien, j'apelle pas ça un merge moi, j'apelle ça un deny ...


update


pourquoi avoir complètement ignoré ma hiérarchie de fichier ? Surtout si en plus vous n'avez même pas changé le makefile en conséquence ?


decremented?


기존 코드가 *error  값의 설정없이 NULL을 리턴하고 있는 데, 이게 호출하는 쪽에서 기대하는 바와 다릅니다.
그리고, 이 함수를 호출하는 부분을 살펴보니, result가 NULL인 경우는 없어서 간단히 assert로 변경하였습니다.


Ok. :-)


Cambiar ~ por !


In my old theme, I've had the clock on the left in the first line - it's doesn't get in the way like that:

![image](https://cloud.githubusercontent.com/assets/907063/5797275/13940584-9fb7-11e4-8819-9e2897261315.png)


This should be very simple. It was said in the past that this script targets POSIX compatibility. POSIX recognises `.' (http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#dot). `source', on the other hand, is non-standard and should not be in there to respect the original intent. This is common enough to appear in a web search, e.g.: http://stackoverflow.com/questions/11588583/is-the-shells-source-posix-standard. I recommend you cherry pick this commit.


After someone reviews it, please merge it today so that it is in the
nightly.

On Mon, Jan 19, 2015 at 2:35 AM, Kacper Michajłow <notifications@github.com>
wrote:

> @XhmikosR <https://github.com/XhmikosR> @Underground78
> <https://github.com/Underground78>: Do you know that feel when you look
> again at your code and suddenly your mind is screaming "Am I retarded?" - I
> do now. Image with the same size can still be different, doesn't it? Here
> is the fix: 4ed72ed
> <https://github.com/kasper93/mpc-hc/commit/4ed72edb57443e9cce4e2787cf8ee2f7ec052528>
>
> I wish I have spotted it earlier. Sorry.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kasper93/mpc-hc/commit/5640051f91eef7ca203c7deedaa581f4f4654155#commitcomment-9332808>
> .
>


Noooo, I need that iteration functionality.


I disagree. 1) using good practices is the best example even for those who copy/paste their code. 2) mv "file" "destination" really looks silly. When did you ever type that interactively? "file", surrounded by quotes?


Hi @hiccup01, thanks for your PR! I've added an ````apt-get update```` here to ensure the package library is up to date, but also I suspect that the ````node```` package is not actually required - it's a different package that was around before NodeJS came around, just had the same name.

See https://github.com/joyent/node/wiki/installing-node.js-via-package-manager#debian-and-ubuntu-based-linux-distributions.


grats - sounds promising. I wonder why your clients don't timeout during handshake phase. Calcing stage0 and stage1 of the handshake needs 10 secs each during my tests - ios6 and ios8 was not willing to wait that long most of the time


Why change this :(


If we want to have telemetry simulator in Companion working, those functions need to be called.


Added README.md information as to reason for the fork


Let's first agree on the fact that there is a bug because you are flooding the PATH environment variable by prepending to it multiple times. If we agree on that, we can discuss how to avoid doing it in a way that you like better.


"<key>\r\n" 을 read해야 하기 때문에,  readline() 시에 최소한 MEMCACHED_MAX_KEY+1 이상이어야 합니다.
MEMCACHED_MAX_KEY가 251이지만 "\r\n"이 있다는 의미를 명확히 하기 위해, +2를 해 두었습니다.


三个T的完整答案。 功能是实现了，但是没有优化。


This misses the other half of the change - ImmutableVector2f.create(v) - that won't create a new vector if not needed.


it reads a hbase table and displays data on the screen


Well played! :smile: :+1:


r+


Did that, images still don't show, when I run it on my machine the images are in the bin folder to be seen but the files for git don't have a bin folder so I'm not sure where they go.
________________________________
From: Jayke R. Huempfner [notifications@github.com]
Sent: Sunday, January 18, 2015 2:57 PM
To: JaykeBird/EternalConflict
Subject: Re: [EternalConflict] Upload images try (cf8f2fb)

Hmm... it seems there's been an issue... The images haven't been uploaded to GitHub themselves, and Eclipse has only registered a link with them. On your computer, in Eclipse's Solution Explorer, the image files have a little arrow with a box around them, don't they?

Here's what you should do: go back into Eclipse, delete the images from Eclipse itself (right-click and select "Delete"). Then, again, drag the images in like before, but this time, at the dialog, make sure the option "Copy files" is selected before clicking "OK".

I had assumed that "copy files" was the default option, which is why I didn't mention it, but it seems not.

—
Reply to this email directly or view it on GitHub<https://github.com/JaykeBird/EternalConflict/commit/cf8f2fbf38ee46c59e47245573065214c7980374#commitcomment-9331848>.


@themestechnology I should have seen this before I merged the pull request. Can you please add a new pull request with all needed changes applied?


Incorrect. This code proves it:

cd /tmp; mkdir hacking; echo 'HACKING_DIR=$(dirname "$0")' > hacking/env-setup; . hacking/env-setup; echo "$HACKING_DIR"

$0 is never set when sourcing, and you definitely don't want to execute.

I recommend merging this commit.


@mekanix, there are a few references to Cheffile left in the README after the move to Ansible.


Does this affect the input the python api is getting to build its query? If so, we might have missed it because we have mainly tested for single word concordances and not for phrases. Just asking...


The `nounset` shell option is not the default and quite rare for this not to be a bug. Who sets it, wants it exactly like this.


Thanks for these great commit, Carl!


did you test this? I did something similar for getting rid of the smp warning in dmesg here

https://github.com/Memphiz/OpenELEC.tv/commits/aml_fix_smp_warning

but mine made it unstable (lockup after around 60secs)


This is a Test read me message


I don't remember what that was, but the old code did not have the problem you mentioned in a comment to #48, but it also had some serious problems with visibility as far as I remember, need to test and write a third version


궁금했던건 readline() 호출할때 MAX_KEY+2 가 맞는지 였습니다.  기존 코드는 char [MAX_KEY+1] 인데, readline(MAX_KEY) 하는데요.  -1 해야하는지, 아니면 그냥 실수였는지...


Question is: what makes you think that HACKING_DIR=$PWD/hacking is insufficient.

BASH_SOURCE is strange, even in Bash.

Example:

cd /tmp; mkdir hacking; echo 'HACKING_DIR=$(dirname "$BASH_SOURCE")' > hacking/env-setup; . hacking/env-setup; echo "$HACKING_DIR"

Do you need the full path, the relative path, or what?


FAILURE 대신 PROTOCOL_ERROR, PARTIAL_READ 등 리턴하는 것은 에러 유형을 좀더 자세히 알기위해서 인가요?

여기 코드는 제가 잘 모르는데요.  quit_server() 일찍해도 괜찮은지 모르겠습니다...


63: D203 Expected 1 blank line *before* class docstring, found 0


The concept is architecturally sound, and it is IMHO the 'right' way to do it.

Jordi Guillaumes i Pons
Barcelona - Catalunya - Europa

El 16/01/2015, a les 21:41, Mark Pizzolato <notifications@github.com> va escriure:
> Hi Leo,
>
> I'm sure it is missing pieces and/or various arguments to some of the calls I defined.
>
> Meanwhile, the vision here is that any number of external programs can exist which can provide a front panel interface to a particular simulator. This program might provide a GUI display which can be interacted with or it might somehow act as a bridge to physical hardware which is the original or a model of the original hardware front panel. In the GUI case, folks could write per simulator dedicated front panel implementations OR a single program could, in theory, exist which had configuration files that contained enough descriptive information and bitmap images to provide front panel interface for many fundamentally different simulators.
>
> At some point there will be at least one additional variant of the PANEL constructor API. One which comes to mind now is one which might provide a front panel for a device (or set of devices on a simulator). The implication here is that multiple PANEL objects can exist concurrently (only one controlling the CPU). Each with different probe (REGISTER) and timing attributes. Such an additional concurrent PANEL object might provide blinking lights on a disk device, or spinning reels on a tape device, etc...
>
> So as for interaction...
>
> Using the current PANEL constructor, the panel program starts and it creates the PANEL object which starts the simulator process. Depending on the front panel design, the "start" state might be with the CPU powered on or might need some user input on the panel to turn on the power switch. Maybe the power switch actually invokes the PANEL constructor. Once the PANEL is constructed, the front panel program describes what information it is interested in seeing changes for (i.e. what REGISTERs are to be displayed). The front panel program can either poll for state changes whenever it is interested in updating its view by calling sim_panel_get_registers() OR it can setup a callback with sim_panel_set_display_callback. If a callback is defined, a best effort will be made to update the local copy of the register data and call the callback routine when this update has happened (this will only happen when the simulator is actually running).
>
> When a front panel program has some input which it wants to affect the simulator with, one of the APIs like sim_panel_exec_run or sim_panel_exec_halt or sim_panel_exec_step would be called. Additionally there also needs to be a sim_panel_set_register API to allow a panel to change some register contents.
>
> Please poke holes in this idea or suggest missing pieces.
>
> Thanks.
>
> Mark
> —
> Reply to this email directly or view it on GitHub.
>


Ah, are you putting things in the "bin" folder? Not a good place. Lol. The "bin" folder is where the compiled versions of the code are put, and it's common practice not to upload those when committing your code, so the "bin" is always excluded when you upload stuff.

Try putting the images in a different folder and seeing what happens.


I came up with a very similar answer, but I was left wondering whether we should have a more high level answer, i.e. without spelling out the `StateT \s ->...` explicitly but building on existing functions. What do you think?


Sounds good to mee too.

Stefano Bodrato

Torino - Italy

Date: Mon, 19 Jan 2015 00:00:27 -0800
From: notifications@github.com
To: simh@noreply.github.com
Subject: Re: [simh] FRONTPANEL: Initial API description (b198e13)

The concept is architecturally sound, and it is IMHO the 'right' way to do it.

Jordi Guillaumes i Pons
Barcelona - Catalunya - Europa

El 16/01/2015, a les 21:41, Mark Pizzolato <notifications@github.com> va escriure:
> Hi Leo,
>
> I'm sure it is missing pieces and/or various arguments to some of the calls I defined.
>
> Meanwhile, the vision here is that any number of external programs can exist which can provide a front panel interface to a particular simulator. This program might provide a GUI display which can be interacted with or it might somehow act as a bridge to physical hardware which is the original or a model of the original hardware front panel. In the GUI case, folks could write per simulator dedicated front panel implementations OR a single program could, in theory, exist which had configuration files that contained enough descriptive information and bitmap images to provide front panel interface for many fundamentally different simulators.
>
> At some point there will be at least one additional variant of the PANEL constructor API. One which comes to mind now is one which might provide a front panel for a device (or set of devices on a simulator). The implication here is that multiple PANEL objects can exist concurrently (only one controlling the CPU). Each with different probe (REGISTER) and timing attributes. Such an additional concurrent PANEL object might provide blinking lights on a disk device, or spinning reels on a tape device, etc...
>
> So as for interaction...
>
> Using the current PANEL constructor, the panel program starts and it creates the PANEL object which starts the simulator process. Depending on the front panel design, the "start" state might be with the CPU powered on or might need some user input on the panel to turn on the power switch. Maybe the power switch actually invokes the PANEL constructor. Once the PANEL is constructed, the front panel program describes what information it is interested in seeing changes for (i.e. what REGISTERs are to be displayed). The front panel program can either poll for state changes whenever it is interested in updating its view by calling sim_panel_get_registers() OR it can setup a callback with sim_panel_set_display_callback. If a callback is defined, a best effort will be made to update the local copy of the register data and call the callback routine when this update has happened (this will only happen when the simulator is actually running).
>
> When a front panel program has some input which it wants to affect the simulator with, one of the APIs like sim_panel_exec_run or sim_panel_exec_halt or sim_panel_exec_step would be called. Additionally there also needs to be a sim_panel_set_register API to allow a panel to change some register contents.
>
> Please poke holes in this idea or suggest missing pieces.
>
> Thanks.
>
> Mark
> —
> Reply to this email directly or view it on GitHub.
>
—
Reply to this email directly or view it on GitHub.

 		 	   		  =


Awesome work!


Wow, what a great UX improvement. Great work!


Fixes #1


Thanks for this find! Yeah, this workaround isn't working since the CF2 config relies on finding an EEPROM among the memories to store the configuration. I'm modifying the CF1 firmware instead to reply with 0 memories so we can switch on the memory fetching again.


제가 보기엔 실수였던 거 같습니다.
"<key>\r\n"을 read하여야 하는 데요..
"<key>"는 최대 250바이트일 수 있고, "\r\n"까지도 read하여야 하기 때문입니다.


Va? Ska Magnus lägga golfklubborna på hyllan o börja med schacket igen?


oh tha'ts it ! super simple :P


Sorry about the confusion.
The compile Error was pointing to the Adafruit_ST7735.h libary, but in fact was about the Adafruit_GFX.h libary.
I am sure you used: https://github.com/zero-signal/Adafruit_GFX
because they are the only one with the "gettextsize"-function.
Got it running and sketch is awesome.


The main problem is with pools of moves in which it's likely that the randomizer gets some moves out from the initial 4 and then it's impossible to have it unless I do sort the moves with a function that weighs the moves (which is another option).

You're right, they aren't literally mandatory, however many Pokémon are close to useless without their move: Chansey and Softboiled, Persian and Slash and so on.


That's true. However ```tryLaunchUnknownFile``` uses the file extension to determine what kind of file you're trying to launch. So while we're only using blueMSX to emulator msx 1 and 2 cartridges i'd rather not rely on the file extension and add some proper checks when the time comes (something like this https://github.com/OpenEmu/OpenEmu/blob/master/OpenEmu/MSX/OEMSXSystemController.m#L45).


saw approval from shino
at https://github.com/basho/riak_cs/commit/d5faf3dd36063c2a9b3e08164601407ead1a652c


merging basho/riak_cs/feature/update-dependencies = d5faf3dd into borshop-integration-1047-feature/update-dependencies


basho/riak_cs/feature/update-dependencies = d5faf3dd merged ok, testing candidate = 618bb4bf


測試2


測試3


Jena complains:

```
[error] o.a.jena.riot - [line: 26, col: 18] Undefined prefix: rdf
```


Thanks for saving me. I am trying to use these changes in WART project here (https://github.com/shirioko/WART) which has a known issue "no_route", user voice can be seen here https://github.com/shirioko/WART/commit/682d88c1252f970f318d65ebe1f3d94caad5a01e, help us.


I have create a new function for some similar code and add validation and correct function for 1.4 version
I have done all point .
Thanks for your valuable comment, I have updated code accordingly on git


Han ska nog göra båda delar :-) han var på klubben i tisdags och ska bli medlem igen.                                                                                Skickat från min BlackBerry 10-smarttelefon.                                                                                Från: impalleSkickat: måndagen den 19:e januari 2015 09:07Till: Migge/LandskronaSKSvara till: Migge/LandskronaSKKopia: Mikael SvenssonÄmne: Re: [LandskronaSK] Added Magnus Kullberg. (1f0e2ff)Va? Ska Magnus lägga golfklubborna på hyllan o börja med schacket igen?

—Reply to this email directly or view it on GitHub.


that's my first word's in my first blog


I found out we should remove all `-p`'s from here. EXPOSE manages tunneling ports. If we use `-p` here again on that ports, then random host ports are assigned.


Hey, that looks cool - thanks!


OUT_OF_RANGE 는 발생하지 않아서 빼셨나요?


이 부분이 코드를 이해하는 데 어려움이 있는 부분입니다.
사실은 memcached_io_read() 내부의 io_wait()에서 이미 memcached_quit_server()를 호출한 상태인데요..
memcached_io_read() 호출 후의 기존 handling 부분과 동일하게 처리하려고 수정한 것입니다.
실제 이 경우는 memcached_quit_server()를 생략해도 됩니다.
단, error code는 MEMCACHED_IN_PROGRESS를 리턴해 주면 에러 유형을 정확히 알 수 있게 됩니다.

PROTOCOL_ERROR와 PARTIAL_READ도 에러 유형을 자세히 리턴하기 위함입니다.


That makes sense.


What does this commit title mean? Do not try with the new version? Since it did (just had a quick local test) with the old...


코드가 많이 이동해서 free 해야하는 모든 버퍼들을 다 포함하는진 잘 모르겠습니다.


The difference is in design. The tutorial is not displayed in step 3 on mobile at all because that's when you choose level 2 values. I you want to type a different one and the keyboard shows up the tutorial would be taking too much space on the mobile device. This is why it's disabled.


just test


Thanks, an interesting idea.
I'll take a closer look at this and get back to you very soon.


OUT_OF_RANGE는 실패 경우이기 때문에 제외시켰습니다.
그러면, 아래 else 문으로 빠져서, 현재의 result를 free하고 error handling으로 넘어가게 됩니다.


Omitting composer.lock has produced this problem:

 * Person A runs "setup.sh" (which triggers "composer install"). It autogenerates "composer.lock" locally.
 * Person B runs "setup.sh" (which triggers "composer install"). It autogenerates "composer.lock" locally.
 * Person A updates "composer.json". He takes care to regenerate or update "composer.lock" locally. He commits "composer.json" but not "composer.lock". He pushes/merges the change.
 * Person B pulls the latest code. He runs "setup.sh" which triggers "composer install" -- but he doesn't notice the warning that "composer.lock" is out-of-date. Consequently, he doesn't get updated libraries.

Regarding my previous point that we want (for lack of a better phrase) to "librarify" civicrm-core.git, I don't think that committing composer.lock is really an obstacle to that:

```
For your library you may commit the composer.lock file if you want to. This can help your team to always test against the same dependency versions. However, this lock file will not have any effect on other projects that depend on it. It only has an effect on the main project.
```

So I'm starting to lean back towards committing composer.lock. We could modify setup.sh to delete composer.lock, but it feels like we're going out on a limb... better to just stick with getcomposer.org's recommendation...


예.. 다 포함합니다..
server_idx 만큼 results_on_each_server에 등록된 smget_result를 free 시키고,
results_on_each_server와 responses_on_each_server  array를 free 시키면 됩니다.


self.pool['stock.pack.operation'] please


פרק שבוא אנחנו מדברים על חדשות וסיכומי שנה שיצאו ממספר אפליקציות שונות


no need to use False


you could simplify these 3 lines in only 1 using list comprehention


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/759


We have seperated out connection specific options. the messenger layer does not have access to ceph options and did not want to add a pointer to generic ceph-options at the messenger layer which is more of a service library


Hi,

I've downloaded the module and installed it on my linux server. But it doesn't work .It works on my Windows PC. Is it only for Windows ?

Please reply ASAP.


More options/items expected in RDMA integration, hence separate options added to the messenger connection.


LGTM, thanks.


Currently TCP_NODELAY is default - can be disabled via NO_TCP_NODELAY (in line with other options like nocrc)


Good point, I'll change it.


@zxqfox о! спасибо! Почему-то попал в коммит.


ok, after readion common/imageio_module.c dimension() gives the max allowed size for the format, so the code is correct


But that's how it works officially. If you get stopped in GVG/BG maps you will still walk to the last target cell. You can even activate more traps on the way. Same for boss monsters.


can't reuse flags, ceph-options not accessible to messenger and we don't want to add generic options to the messenger library


Currently all ceph connection have tcp_nodelay set by default, this was missed in the kernel and we are fixing it now. It can be disabled by if not required. This can go either ways - I think we can wait and see what the community wants and change it accordingly


@GrahamCampbell Lol


Glad that you got rid of the gradients.


fast-forwarding develop to borshop-integration-1047-feature/update-dependencies = 618bb4bf


@smarterclayton thanks! I thought we are getting rid of `api.Config` in favor of `List` object.


With this check, we're restricted to `int`s, no? Ok with leaving it, but from my perspective this is equivalent to just using proper ints (though with a side of indirection).


Please note, the changes here are done so that future connection options are easy to add. Also we will be having new connection options was RDMA support comes in.  If all OSD/MDS/FS have to check and set options it will result in code duplication.
We can probably add the set option interface to set the ceph-connection options and not have a separate _with_options interface


yes, we moved to jets3t because of the much smaller footprint. jets3t is about 500kb. the amazon aws sdk is about 12mb which bloated the gradle distribution.

One thing I noticed during testing this is, that new sites like 'germany' require sha-256 authentication which is not supported by this implementation. So I guess it would be good to tackle this one first, to support all data-centers.

In the long run the plan is to detangle sftp, s3 support out of the gradle core. Once we achieved this, we can move the S3 support into a separate plugin. If somebody  then decides to use the s3 plugin, the 12 mb footprint is okay I guess.


I prefer calling g_variant_unref(modems_result); once it's not needed anymore instead of putting it in the bottom.


Doesn't work :(


Thank you!


Added Doctype works fine, good job


Ah ouais, t’as un format de fichier « vao ». Marrant ça :D


You're right.


This attribute is handled by [mongoose-timestamp](https://github.com/drudge/mongoose-timestamp), you should remove it from model definition.


Hum.


Really?


After fixing this comment, you can send the PR.


TeamCity Ylab :: Feodorov/ylab [Build 54](http://192.168.30.225:8111/viewLog.html?buildId=564&buildTypeId=Ylab_FeodorovYlab&guest=1) is now running


you forgot newline before Args


Resources (I use prefix with -r and have /resource/ in URI) use dcterms:title, classes and properties (parts of ontology with /ontology/ in URI) use rdfs:label


The commit description says "moved compilers to peer dependency" but I see that they are in both dev dependency and peer dependency. What would happen in this case? I mean, since its a dev dependency it will install it (stylus 0.41, stylus images 1.0.3) under node_modules even though its a peer dependency.
And why not specifying versions 0.47 and 1.0.4 of stylus and stylus images explicitly? I mean, if it will somehow install stylus 0.41 and stylus-images 1.0.4 (or vise verca) it will break.


Nope, this is pure UI stuff. The javascript is getting the search terms
from the query string, which is URL encoded. No python was harmed in the
crafting of this commit. ;-)

> J. de Joode <mailto:notifications@github.com>
> 19 January 2015 07:55
>
> Does this affect the input the python api is getting to build its
> query? If so, we might have missed it because we have mainly tested
> for single word concordances and not for phrases. Just asking...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CentreForResearchInAppliedLinguistics/clic/commit/1d08139b1c11de43824722b73489c4ddae221156#commitcomment-9334970>.
>


No I don't of course.


add parameter type string instead of "type"


jk


add correct return type


please remove comments in production code


@Teun @kevingy
After testing in the real world the last change memory leak back. Not as much as before, but still there.
The easiest way to repetition is create two streams one of which is constantly opening the page and throw an exception, then restart the flow.

Unfortunately, you can solve a memory leak
or the creation Dispose and destructor (which is trying very hard to not object does not use a managed resource)
or create a soft link, but then the very idea of access to open pages is doubtful.

The reason for the leak, to store all windows in a static list. At any errors in SimpleBrowser, and the application uses its list of clogging. If you are running multiple streams that parse multiple pages mistakes are always possible.

I think the decision to remove static from SimpleBrowser is reasonable. Finally, if necessary, you can create a shared point elsewhere in the application.


i would suggest to use protected so that subclasses may use the function.


Wouldn't it be better to use the exists() method to check if the file is available instead of opening it, which allocates resources and a file descriptor from the operating system?


`allowedMetrics` should probably be a `Seq`.  `List`s tend to be linked lists and typically pretty inefficient.


(nit) space after , and before _


no space before :


maybe look for a more expressive variable name than $temp


absolutely ridiculous


Typical ScalaDoc is to surround code blocks with triple braces, like this:
```
/**
 * {{{
 *   class Foo ....
 * }}}
 */
```


please remove this comment


a new chance


What happened here?


What about "-fno-builtin-memcmp"? It's gcc bug. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052


Hi thouis, can your tell which version of IBM ILOG CPLEX Optimization Studio you use for rhoana? in the website http://www-01.ibm.com/software/websphere/products/optimization/cplex-studio-preview-edition/, I tried the Preview edition but problem size limited, you use Academic Initiative version or the full version in the site https://www-112.ibm.com/software/howtobuy/buyingtools/paexpress/Express?P0=E1&part_number=D0CV0LL,D0LF1LL,D0TKXLL,D0TLFLL,D0CV2LL,D12N0LL,D120VLL&catalogLocale=en_US&Locale=en_US&country=USA&PT=jsp&CC=USA&VP=&TACTICS=&S_TACT=&S_CMP=&brand=SSVLBB


we use concatenation in the format $schulungsTitel . ' am ' . $startzeit ... with spaces


Should we also check for internal classes or classes that extend internal classes that don't implement `Serializable` / `__sleep()` /  `__wakeup()`?


test


Nice one. Does all R code suppose to be such brain consuming? Can we do something about it?


Other style nits, though not a big deal:  space after if, and no extra spaces after ( and before )


gofmt fixed the comment line I guess.
But if you're talking about TODOs, then I don't know. Anybody wants to take a look?


In general all patches in make files should have a comment explaining why they are necessary.

If they have been submitted to an issue should they should contain a link to the issue as well. Sometimes this can be inferred from the patch file name. This is not the case here.


Do you mean that we should do sanity test before every submit? I only confirmed the final deliverable.


Maybe it would be nice to also add a test for:
private List<BeanWithGeneric<String>> beans;
because it may be required to only autowire BeanWithGeneric services typified on String


this change not work, still 1 region.


Yeah it was intentional. For my purposes it made more sense attaching
stores at runtime or lazily.

I would be open to support both. Although I'd want to see evidence of
people only adding stores at construction and not setting anymore
afterwards

On Sunday, January 18, 2015, Austin Brown <notifications@github.com> wrote:

> Was this an intentional change to remove the call to __initialize?
>
> Note, the significance is that it removes the ability to pass stores: {
> ... } into the Reactor constructor. Didn't know if that was an
> intentional API change. I noticed that you did rename attachStores to
> registerStores ... didn't know if that was in an attempt to promote the
> use of setter injection over the constructor injection.
>
> We should update the docs either way.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/optimizely/nuclear-js/commit/a8e5ff990a4d67dda2532acfe74b1b07532970b0#commitcomment-9334760>
> .
>


This is an O(n^2) operation, and a slow one at that because both dps and allowedMetrics are Lists.   Suggest at least turning `allowedMetrics` into a Set, and dps should be a `Seq` ... (ideally an ArrayBuffer or Vector)


I think this should be:

    module.exports = '$repo';

(notice the quotes)


TeamCity Ylab :: Feodorov/ylab [Build 54](http://192.168.30.225:8111/viewLog.html?buildId=564&buildTypeId=Ylab_FeodorovYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:10:37


видалити пробіл


Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>


не комітай паролю. скільки можна?


і знову те саме.


AgentControllerServerDaemon의 생성자의 경우 매개변수를 ip, port, consoleProperties, consoleCommunicationSetting 순으로 받는데,
SingleConsole의 생성자의 경우 3, 4번째 매개변수의 순서가 다른데요.
순서를 동일하게 맞추는게 더 좋을 것 같습니다.
```
public AgentControllerServerDaemon(String ip, int port, ConsoleProperties consoleProperties, ConsoleCommunicationSetting consoleCommunicationSetting)
```


@parasyte two questions :
1. is the cache source coordinates still required ?
https://github.com/melonjs/melonJS/blob/master/src/video/webgl/texture.js#L38-L41

2. what is the purpose of this function, I could not find where it is used :
https://github.com/melonjs/melonJS/blob/master/src/video/webgl/texture.js#L79-L97


Indeed same issue than @toddlucas grunt-typescript add typescript 1.3.0 as a peerDependency. I opened an issue on their github.

Thanks a lot for the help !

Maybe you could manage bower version to get rid of compatibility. It's a little bit more easier than a commit hash ;-)


Any way to add a test or example?


Should test file read and promise chain? I'm not sure.


That is not gonna work … did you test it ?

Well, since this is already in develop, I send a pull request to fix it: #1839


I have not checked it, but BlockLogPile also has the same call, it might have the same problem too.


Doesn't need to..I explained a way below.


How does this handle tuples with more or less than 2 elements?


hey @libargutxi , this might be worth a pull request! @maethu ?


fixed in https://github.com/helpshift/ekaf/commit/25472e2968bc63093086f73a150aa37081b58c5b
new tag 1.5


since i didn't create that copyright ... i can't change it :)


Redundant `self` detected.


@Ryan2015 赞，记得在首页加个链接


... _yasuoWall;


sidasito


Thank you for the functional input; indeed to combine the 2 columns is a great idea, why didn't I think of that ;). Sorting is indeed a option I definitely add in a later stage.

With the button's I did try a different color; but it did not please me in a optical sense; now I only used an underline on the text to set the two buttons apart; perhaps I should try a different color but close to the color it already has; since you are correct that it needs to be more different; especially on 'important' actions.

Again thanks for you valued input


as for the other tests, this should use a fake object `type('Fake', (object,), {'name': 1})()`


Heh, glad you like it :)


Well can't this be added in flag ?
I would like to understand what could be the change for RDMA. It will be wiser to separate out RDMA specific DS or maintain a union.


.... _Orbwalker;


That is a more future proof, and better solution than the one I gave you.
But what does this do, that the setuptools find_packages don't do?


Way out mentioned below.


....MapType


My R skills are kinda rusty :-) Are vector() and c() the same thing? If yes - better use c()


Yes, agreed..


ChooseOrbwalker


@a-detiste, FYI: http://forums.3drealms.com/vb/showthread.php?t=20855 says:

"Also, for the record, v1.2 of Wolfenstein said v1.1 ingame, because someone here at the time forgot to change it ingame. Only difference there was that in v1.1 the elevator to the secret level in 1-1 didn't actually go there, it went to 1-2. That was fixed in v1.2, but there's no way of telling which is which w/o trying the secret elevator in 1-1."


@amitheda @pushpalata06 @gauribhapkar


Play


No problem at all. Hope it's useful.


Chose


Ага.

2015-01-19 1:40 GMT+03:00 SiPlus <notifications@github.com>:

> GetUserLanguage тогда?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Warsow/qfusion/commit/3f57c09bfc4f5402389421b1cf831f31cad70f0e#commitcomment-9332316>
> .
>

--
Best regards,
 Victor Luchitz


Yes, that will be good. Also, if tcp vs RDMA structures are vastly different I think we should separate these.


You better pass, colName as parameter. It becomes much clear invocation. Compare:
CountReads(..., ..., F) and CountReads(..., ..., "SAMs"). Last one gives clear information about what the is going on.


Please add a comment on why you dont use next.
Or better yet, change https://github.com/clochix/cozy-emails/blob/master/server/utils/errors.coffee#L93 to fit your needs


Aaaaaaah yes, good one!


Cool, I'll take a look at the fix for Germany.
Completely makes sense to detangle the different transport's from gradle core.


haha!


Strange print. Better remove it or at least make clear what are you printing.
Listing like: 1 23 141 "omg" - is bad (


log error at this level instead of in model/account


Ce sont ses mots. Pas les miens :)


the error middleware should take care of displaying errors as much as possible.


@t0ggah: We agree that this should be in `Photo`, but we aren't sure what makes it difficult — why can't we just move it there? Also my name is Sindre.


This commit belongs to this issue: https://github.com/volontariat/voluntary_music_metadata_enrichment/issues/7


It looks like lines 421-439 have some repeated code.


Index is bad variable name. What exactly is it? [plz give me you copy of Code Complete book, with it i can write down related chapter numbers here]


space after (.


Use `let` instead of an instance variable


pass type instead of sam=T


if the purpose was not to stop when one account is broken, you need to do something like ;

```coffee
   #...
    return cb null if account.isRefreshing()
    account.imap_fetchMails limitByBox, onlyFavorites, (err) ->
          log.error "REFRESHING ACCOUNT FAILED", err if err
          cb null
, callback
````


I'm not sure on that.
If a user is giving a bug report to a developer, does the developer want the log in their own language or another?


I have moved it there in the next commit. I wanted to have a green test before i moved it into the Photo class.


og @henrikgs  :-)


I see duplication in SplitByAnnotationGFF, SplitByAttributeGFF. DRY principle (do not repeat youself). We should do something about it


D'oh. We're going through this commit by commit. Our bad!


Oops, just realized that I forgot to update the links :P


Why not use  && ? it seems that the closed resource of `is_resource()` always return false;
http://3v4l.org/A5AWj


Compare ',' with String.equals()


Lets give it a name of these names.


Nice trivia :smile:

I pushed WIP v1.2 packaging on this branch, repacking works, but patching not yet:
https://github.com/a-detiste/game-data-packager/commit/8dd23ad0ff349f8d6303273ac0e857ba50448b50
(and `wolf3d-full-old-data` is just a temporary placeholder till I find a better solution)

It needs a new 'implode' extract method, because the Python lib can't process this old zip.

https://gist.github.com/a-detiste/6948bebc972d64969bcb


We think using `any?` in this case would read better, though. Something like this:

```
ruby
message.split.any? { |word| word.in? Mingle.config.instagram_reject_words }
```


NB: the `/./` is to test for presence, as 'true' isn't special-cased


Really we just suck at `inject`.


@jgorset hijacked my keyboard. Sorry about that. :wink:


grinderPropertiesUrl 로 수정하는게 좋을 것 같아요.


* Yes. ;( See the warnings in your console. When those are gone, it can be removed!
* That function is used by the compositor when a region is unknown (this is where the warning is printed) https://github.com/melonjs/melonJS/blob/7e6be6505c14ebccaaf25d4a91539f1265166f3e/src/video/webgl/compositor.js#L319-L329

I would love to get rid of these things, but we can't do that until #592, #595, and #632 are fixed.


Indeed @jco-odoo is right. why don't you recreate the pack operations in default_get() , it's like it should always create a new one from default_get()


I think this is a better solution(inside Photo class) and i can make an new pull request on it:
``` ruby
def include_rejected_word?(rejected_words)
  return false if !message || message.empty?

  !message.match(/\b(#{rejected_words.join('|')})\b/i).nil?
end
```


TestFixtureSetup will be called if the TestFixture needs to run, if all the fixture is ignored, it will not be called. It is a way to say: "we need 1 test C* cluster and 1 shared sessio for all the tests in the fixture".

IMO, it is not worthy to use the patch version in the attrs from master.


Oh, my)
I see, you put a lot of efforts in this piece of code! Quite accurate code and it makes it easy to trace you intentions.

As you will be fixing my comments here, keep in mind, that small commits is better than large ones. This commit is HUGE, i can't get through it by now. And, if you can, please, commit non source code files in separate commits, so i didn't bother to see them.

Sorry, i didn't run you code at all, my bad. And i will run it someday! And i will know, how good you tests are.

Keep up good work and post commit to fix issues from this small review, and we continue to more detailed analysis.

Aaaand sorry for my english, if i've made some mistakes - let me know. :-)


I'm not sure this comment is helpful/necessary.


yes but requires too much stuff. thats why I prefer it as target, like installer, where nothing else runs..


This is messing up file links in mod/filestorage where we use get_parent_cloudpath().
They are now pointing to /filestorage instead of /cloud.
is it ok to hardwire it there?


I don't think this is working correctly at the moment. It's not showing the correct launches as having occurred: http://cl.ly/ZM7D


Thanks for the explanation. I've tried to reproduce the problem but I didn't get the behaviour you describe for either of the 2 problems: I don't get an endless loop (even if I introduce an artificial exception somewhere in the loading) and I don't get an exception in calling `StructureIO.getStructure("4D6T.F")` with `params.setCreateAtomBonds(true);`. Would you guys be able to post your code?

In any case I would suggest that a better solution to the patch above would be:

```java
		try {
			MMCIFFileReader reader = new MMCIFFileReader(path);
			reader.setFetchBehavior(fetchBehavior);
			reader.setObsoleteBehavior(obsoleteBehavior);

			reader.setFileParsingParameters(params);

			s = reader.getStructureById(pdbId.toLowerCase());

		} finally {
			flagLoadingFinished(pdbId);
		}
```
Like that all the original exceptions (including the IOException) are thrown, while the loading is always flagged (either if exception is thrown or not).


lines 59 and 72 of d_rot2_fuse: u_infocode_check should be inside if statement

line 76 of d_rot2_swapdiag: u_infocode_check should be inside if statement


Sweet!


You should remove lodash-node since it is deprecated, and add lodash-es6 instead.


I hope this gets released ASAP :+1:


@ophian No it's just a JS check that the jquery uploader will not get enabled when the "Download"-option is chosen. In that case, as I read the code, it would fallback to just the normal PHP execution.


Voila la nouvelle ligne que j'ai ajouter un route qui point vers le HomeController Exactement vers la methode showWelcome


I would not do that. This example is not redundant for the reason I mentioned in our correspondence: people need something to copy and paste. And also something which is easy to play with: e.g. now when I am working on serialization I wanted to use this script to try if it works and sadly found out that it was deleted...


thanks. fixed even though droid builds are likely utterly broken these days.


@breskeby we could just add the 'aws-java-sdk-s3' dependency instead of the entire AWS SDK?

```groovy
dependencies {
    compile "com.amazonaws:aws-java-sdk-s3:1.9.0"
}
```
Is 2.7mb still too large?

![image](https://cloud.githubusercontent.com/assets/1910629/5798285/2b804578-a01a-11e4-80e8-7b89f9fcab58.png)


lines 90-101 of d_orthfact_qr: INFO.NE.* should be INFO.EQ.*


Almost forgot - as you fixing code - write down after my commend something like "done", so we both know, that comment wasn't ignored :-)

Every review would end in LGTM stage - Look Good To Me, and it is iterative process, currently we are only in first stage.


I was just being nosey, looking through your code :neckbeard:

The Umbraco core has an extension method that you can reuse for this: [Umbraco.Core.StringExtensions.ToDelimitedList()](https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Core/StringExtensions.cs#L405)
Saves you having the extra extension class.


You are right ! It worked in spite of wrong implementation, because the close method is invoked at least once from edt. Nevertheless it should be implemented like you suggest. I'll do that.


d_orthfact_qr has been changed with a later commit. I had to commit some
intermediate states to switch to other branches for testing.

--
Thomas Mach
http://people.cs.kuleuven.be/thomas.mach

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm


It's in the orign/master


Because it's faster? I guess the code we proposed would loop through a lot of arrays a lot of times.


So, by adding support for 1.1. we naturally support 1.2 as well and there are patches available from 1.0 to 1.1/1.2, right?

> (and wolf3d-full-old-data is just a temporary placeholder till I find a better solution)

Why give it a new name when it is just another set of alternative files that cannot get co-installed with the regular wolf3d-full-data anyway?


Joshua Hutchison


optimization -  read(byte[], int, int)


Sure. That is what the `@todo` annotation is about ;-)


This is a step towards fixing the issue #880. It disposes of all BOY elements, when they are no longer needed. It doesn't fix the memory leak, but at least it pushes it down significantly.


nit: new line for this open brace


OK. Although I would probably not mix that kind of thing in that function (just to keep things as modular as possible), but I do see your point in having the base class allowing this to the user/developer.

I'm probably gonna remove that comment. We'll wait for the reaction of the next const maniac that comes across that code. ;-)


This commit solves the issue #876.


This is probably not what you want to do. It means that if I get a new message, and that the thread in which it was has been archived, it would not be shown in the inbox?


I have changed it locally, still working on the wording.


You could move the variable assignment for `user` and `rules` to inside the case? Otherwise it is getting the rules for every request.

(Tell me to stop commenting if you think I'm trolling :trollface:)


delete file text


Joshua Hutchison Facebook.com


I was talking about the formatting change. If it's gofmt that did it, it's fine as-is.

The TODOs are internal details and can be revisited after 3.1 is out / if someone runs into an issue.


Ah. Are you releasing 3.0 today?


I don't know about benchmarks on the three methods, but the reason why i would use the regexp is because it also looks at different word boundaries(!,?(()). You probably need an regexp anyway in the split method to account for all the different boundaries.


this helped for me


For now, yes. We could decide that everything internal should use semantic versioning and have some helper methods e.g. `omero.utils.checkversionbetween(ver, minver, maxver)`


@shijiang1130
Please note that README is generated during Build from lib/Ado/Manual.pod
If we decide to add something to README and README.md, lib/Ado/Manual.pod should be edited.
Also it should be more clear what you are trying to do, i.e. put some more clear comment like "Install some dependencies using PPM".
Please note also that you could clone also those projects from github too.
Thanks,
Krasimir


That is … so smart! Awesome! :+1:


Would you mind adding a comment why this is required? Is this because hydra is flaky? Tests with timeouts are the bane of my life :(


Either tonight (Monday) or Tuesday morning.


Maybe it would be better to have two queues, for acting and reacting?


We have here a multi-layer alternative scheme:
*  either v1.0/1.1/1.2 with patching
*  v1.4 with 3 alternatives versions

I don't want to end up with a .deb that mix up 1.4 & 1.2 files.

There is now support for 'alternative files', but not 'alternative package';
or 'alternative set of files'... that gets tricky; and we must check if adding
this would be re-usable for other games.
Maybe adding a "debian: package:" value that replaces package.name just before the end is less intrusive & just easier. (and the package would keep the internal name wolf3d-full-old-data in the yaml)

> that cannot get co-installed

right! , dpkg complained loudly on this of course


永远pass


Awesome!


Display/media/audio-caf defines are obsolete now because cm is using pathmap build system


Fixed in f8f4207846dd5829f68c0472913dda9aaf02847e.


OT: have you written the blog post?


I never call the raw `crypto_auth()`, `crypto_onetimeauth()`, `crypto_box()`, `crypto_secretbox()` or `crypto_sign()` primitives from sodium, I always call the specific implementations, so I'm not sure of the need to expose them in libsodium-sys. What do you think?


The ack command doesn't exist in all systems by default and has to be installed previously. I think it would be better to use the grep command instead. Also on Debian systems the command is called **ack-grep** and not **ack**


Hi, you can only have *one* maintainer, the other folks can be added into the "Uploaders:" field :)


why does Arquillian even need ProjectExamplesActivator ?


thanks a lot Gilles!

One question: have you tested it on 3.7.1 (LTS) and 4.5.1(LTS) ?

From what I understood from SonarQube site this should work as API breaks occur on 3.7.1. It's good if we can support all these versions in the same version of the plugin (if we can).


I have tested the commit in two different systems OracleLinux and Debian with differents git version and the old-rev variable doesn't get the parent branch value.


awesome


Commerce station: It could actually give you a nice profit if you move planets around, use planet generators, or play with a high planet frequency.

Guardian: That's a temporary fix at best. Like I said, I have to draw up a completely new design for the Guardian.


Also don't forget the problem with resizing if debugging parameter is used. I think this problem currently still exists.
What I did was adding to debug-shell.service After=fs-resize.service. Should be tested.


> OT: have you written the blog post?

85% of it.


This 'user' parameter shouldn't also be changed?

Regards,
AF


Please can you change this commit so it also updates the version in `package.json`?


It even happens on my machine. Limiting how long the tests run is a crazy idea.


**说人话**


Thanks.


We have received a bug report about this contribution:
http://www.qcad.org/bugtracker/index.php?do=details&task_id=1166


well it would be even less, as we already ship joda-time. Is there something blocking us at the moment from keeping jets3t for now?


thanks for this @ischneider

I did get a JS error when showing the dialog for the second time

![screen shot 2015-01-19 at 10 56 45](https://cloud.githubusercontent.com/assets/319678/5798665/f5ea2ff0-9fc9-11e4-97f5-c4128f761847.png)


Exactly.


WAT.


Probably a good chance to make it consts. I'll take care


Yes it will by fixed by @sle-odoo i want him to validate the commit by testing it on windows before pushing it.


I don't know what I was thinking, but I was wrong. `tell` is still there and is still the method I want. I have made a new release with some [update notes](https://github.com/gaverhae/okku/blob/fcf6b256b41754821ade737c9c2df1b3305de55b/CHANGES.md).


Jup


fast-forwarding master to auto = ccf5f96f


Oh nice, I'll take a look


Why was the IDiscount interface deleted? I really prefer this approach. By doing this, the implementations do just what the are supposed to and they don't need to contain all the logic related to an Order (like AbsDiscount).


I have a better suggestion that I'll be committing shortly:  detection of the specified media source based on file/folder.  If it's a folder, scan it for media to play.  If it's a file, attempt to load it as a playlist.  This allows us to consolidate options and make things more bulletproof.


If you have the IP on your interface, but it's not showing up in facter, then there is an issue with your puppet. Either you've uncovered some strange bug, or something else... ?

The only thing I can think of is that perhaps:
1) You made a mistake copy+pasting, or ran facter before the IP was actually on the interface.
2) Some misconfigured VRRP/Keepalived setups can cause the IP's to ping-pong/bounce back and forth, so if you run facter at the wrong second, it will be missing.

ATM, I think puppet-gluster doesn't need a patch for anything relating to this, but LMK if you think it does.


Added cms, framework and node_modules to gitignore as they are all package-managed.


Nice touch the Idea of the TranscationFactory .


The \r\n are in the db right after <p> marks. They appear as \\r\\n. I guess somehow those line returns are not getting escaped out when the db transfers. They don't show up on my current site.


Correction effectuée pour la réconciliation.


@marr75 I know, sorry. It would be nice if Bower only allowed authorized users to submit packages to its registry - see issue #152 for more background behind what happened.

But I think we got it figured out now, so it won't happen again.


just curious, why is the `*` in `.*/gulpfile.js` required?


@frodopwns I added much better messaging on failure, especially for odd case of `is_close_to()` requiring a tolerance arg of type `timedelta` (definitely the correct way to do it, but maybe unexpected)


Bah ouais, VAO = tu load, et t'as directement les datas des attributes prêtes à être envoyées telles quelles au gpu :)


:+1: got it. I think we can finally close this thread off now :)


Ah I see your point, OK.   Well then, either way is fine with me.


Haha if i could make guided projectiles i would.


Not sure about commenting out the function in render_skybox.cpp or in src/graphics/shadow_matrixes.cpp .
These are leftover debug code that I plan to use for testing : the render_skybox code is here to generate a cubemap from SH coeff so I can test that the inverse operation (in generateSH coefficient) works.

In shadow_matrixes this are for a functionnality I didn't fully implement yet.


(I fear that commented out code may be thought as old code that can be removed)


Thanks @geoffreysamper.  Fixed with slightly different code that doesn't check for specific verbs.

You can now also see the ACTUAL Http headers that are sent to the server from the client, not just the headers you specify (ie. including content-length, auth headers etc.)


I just realized I should not do this myself when a create a new version/revision.


awesome!


U need to add a timer delay below the code for the motors:

Timer.delay(0.1);


@DanielRosenwasser This commit addresses two issues:

* Previously we removed all watchers before compiling and attached new ones after, and therefore we'd miss any changes that occured *during* compilation. We now watch cached files at all times.
* Previously we would start a new compilation 250ms after the *first* change notification. Now we start a new compilation 250ms after the *last* change notification.


Oops this commit was supposed to read Homework wk01 D05


Excellent.


cool :smile:


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1933](http://teamcity.monogame.net/viewLog.html?buildId=4995&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This makes is very fast?


Add support library depend in the project for save min sdk version as 7.


Huh - I didn't notice till now you literally submitted this on Christmas day, now that's diligence! :)


Have you tried to talk with the dvdnav developers (which are probably the same as the VLC devs) about this issue?


The new tring i much nicer, thank.


all category have finish. sorry ceck gaess...


thanks a lot! :)


86441310-PlantObject2 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-72.79%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-48.86%25-red.svg)


This is not so nice, but I did it to avoid changing a lot of specs which are transitively calling this now because it is called from `set_target_dependencies`.


A more precise commit message (short summary) would be great next time. ;)


There are already test unit tests in the app -- seems like it would be easier to extend those rather than add new test infrastructure.


we don't need $(npm bin) in run-script, it sets the path to there before npm run.
but adding devDepends are fine (I didn't do that, cause 1.4 dons't released yet.)


Wooooooooooooooooooooooooooooooooooooooooooooooooooo


See issue #27 ;)


merge


You got me this time :-) Will push fix.


Do you want me to make a PR here, or will you do it?


We should not commit any changes that just change white-space.  They just add noise to the overall readability of the commit.


Do we need this file?  Was it just to test Jetty 9?  If so, it could now be removed, right?


I wonder why it says Imangani did this commit...


Should be equivalent to `(this.start <= that.start && that.start < this.end) || (that.start <= this.start && this.start < that.end)`


In the vim help for isfname, it states that "Multi-byte characters 256 and above are always included, only the characters up to 255 are specified with this option." Also "If the character is '@', all characters where isalpha() returns TRUE are included.  Normally these are the characters a to z and A to Z, plus accented characters." This is why I restricted it to 256 and below. Also, there may be differences in C's isalpha and Java's isLetter, but I figured they'd be close enough.

Also, I think the hash set still might be the easiest way of storing keywords, since a keyword specification could be, for example, "a,^a" or "@,^a,a". Obviously you could still check the specs, but IMO the hash set is the cleanest solution.


Am Montag, 19. Januar 2015, 16:33:37 schrieb Christian Wansart:
> See issue #27 ;)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/BluePanel/rails-website/commit/3e809090832fc2526b06f16f6b
> 8a5f0c110b8803#commitcomment-9348692

Yeah, but the issues and their descriptions are not in the git log.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1933](http://teamcity.monogame.net/viewLog.html?buildId=4995&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 366, ignored: 6 Build time: 00:18:25


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1934](http://teamcity.monogame.net/viewLog.html?buildId=4997&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


because if there is no match you are checking against a null object, basically there is a null check missing. using an exception instead of an if.


`httpConfig` instead of `http_config` - Java conventions are for camelCase rather than snake_case.  :)


Hard-coded buffer size?


Hot-fixed in v3.3.2.1. v3.3.3 will be released shortly.


Why `QueuedThreadPool` instead of `ExecutorThreadPool`, which directly uses a JDK Executor?  See http://stackoverflow.com/questions/5619735/jetty-configuration-threadpool - especially Jesse Mcconnell's comment (he's one of the core Jetty developers)


Squash with https://github.com/Team-OSE/packages_apps_Settings/commit/01db3e768d4751f4e4895735450be33e325f4180


I think both solutions are sub-optimal. Sometimes, an environment variable being empty is intended. A possible solution is to use a flag like approach, minus the defaults. You register all the environment variables in the beginning and throw an error at another method call (say Populate) which must be invoked before the variables are used. This should probably go in a some central go library that we maintain.


これだとGameとCardに全く関係がないように見える(=GameにCardを渡していない)ので、実態と違う感じがしますね。
まずは、Gameが使うCardをDIしてみてはどうでしょうか。

```
new Game(cards);
```

とか

```
var game = new Game();
game.setCards(cards);
```

みたいな感じですね。


Better to use the logger to log this rather than printing to stdout


I like it! After a little review I think we can merge this one....


Prefer detailed imports rather than `.*`.


Ok, Well I seem to have a mistake here.
The error that I am getting is  ValueError need more than 1 value to unpack
on this line,
     (ret, srchash) = filemod.source_list(['salt://http/httpd.conf',
                                   'salt://http/httpd.conf.fallback'],
                                  'filehash', 'base')

I thought prematurely this might be a fix for it.


`format('L')` は 0か1を返すらしいので、 `$time->format('z') / (365 + $time->format('L'))` と書けばさらにシンプルになりますね。


Now It works. Thank you very much!


It was removed days ago. will double check.


Gameクラスを作ったので、`var a = new Game(); var b = new Game()`としたら、２つのゲームを同時に動かせそうな気がしますが、できませんね！
原因の一つはここです。
オブジェクト思考的には、関連のない別々のインスタンスは(上記ではaとb)はそれぞれ独立に動くはずですが、実はグローバル変数に依存してしまってるんですね。こういうグローバル変数への依存はひどいバグの種になるので本当に避けたほうがいいです。


これもGameに置いたほうがいいでしょうね。


The error comes from :
salt/salt/modules/file.py(2547)source_list()
-> _, senv = single.split(env_splitter)


Can you explain how this is supposed to work?
Won't the watchdog panic the machine regardless since we've not been tickling it?


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1934](http://teamcity.monogame.net/viewLog.html?buildId=4997&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 366, ignored: 6 Build time: 00:16:04


１回めのflip時にenableFlipが初期化されていないですね。
そして、これグローバル変数になってしまいますね。
`window.enableFlip`と一緒。


初期化したほうがいいですし、グローバル変数じゃないほうがいいですね。


@suwatch I'm seeing the duration on its own line instead of on closing tag line. Is that what you would expect? e.g.

                </step>
                <!-- duration: 109ms -->
                <step title="Setup post receive hook" date="2015-01-20T00:53:06.412" />
                <!-- duration: 125ms -->


ここスタイル守れてないです！


ここもスタイル守れてないです！


Cardにcardsという属性があるのは何かおかしくないですか?


Hey! I think I found my mistake! This should be `data->tahco_motor_type`, not `data->motor_type`. Also on line 577.

See issue ev3dev/ev3decv#245.


lol this was a massacre :p But to your defence French grammar is a mess ^^


> Why is OP required for whois?

No good reason, it was changed to public in a later commit. Soon I want to add more metadata for admins (e.g. ip address) than normal users, though.

> Make it a configurable option?

Making things configurable increases code complexity, I avoid it whenever possible.


"L'autre site non-officiel". J'aime bien!


RegNooo!


Where is `xxd` ??
需要额外的外部命令,不能通用.


Made some changes. Question.. would I want do to pass nil here to ensure they use the correct init? Or just pass an empty string and make them figure it out


You're creating intermediate strings here, both with `cmd.parameters[0]` and the newline. Essentially, you're using three strings instead of just pushing directly into one. Consider using `<<` instead of `+=`, and use interpolation rather than `+ "\n"`. Example:

```ruby
code << "#{cmd.parameters.first}\n"
```


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.81%25-red.svg)


For some reason, setThreadPool method is missing from the updated version of Jetty 9.2.6. The thread pool has to be a QueuedThreadPool passed as a constructor argument.


@rocco Have a look at hooks, as a possible work around.  They are not restricted.
before_plugin_install, after_plugin_install, ...

You could also consider using documentation to simply tell the user what they need to do to install the plugin.  ie. create a symlink, download and install X and copy Y.dll ....

@sgrebnov isn't Images/ located in CordovaApp/platforms/wp8/Images/ so it should be fine ... and isn't CordovaApp/platforms/wp8 == project_dir?


"eigenvectors" is one word.


@hildeth (also Cc:ing @gbtitus and @ronawho since it has runtime implications):

Doing some detective-work on performance slips since the last release, this commit resulted in the ~15% execution time regression for the no-local version of the promoted op= test on 11/06, visible in this graph:

  http://chapel.sourceforge.net/perf/chap04/?startdate=2014/09/18&enddate=2015/01/19&graphs=promotedoptimenolocal

The cause seems to be due to overheads added to comm calls contained within compiler-generated assignment routines.

Reviewing the commit, it feels like a big hammer in that, presumably, most calls to memcpy() are not made with the trivial src==dest case.  To that end, I'm curious whether we could approach the valgrind errors that this silenced by addressing/fixing the code paths that did result in such calls rather than replacing memcpy() with chpl_memcpy() semi-globally.

For example, if such calls resulted from doing something like "A = A" (not that I'm saying they did), then I'd rather catch that case higher in the software stack than at the per-element assignment level.  Or to say it's a user error.

Do you have any notes as to what code paths were leading to the valgrind issues?


*vectors


Ref: #4286


update readme


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


dddd


Yes pass `nil` so it blows up and the developer knows they screwed up.


This is stupid


Ok


Dude, what is button supposed to mean?


Cool! Is there a reason we have both a `tacho_motor_type` and a `motor_type`? I have structures set up like this for the WeDo and I'm not entirely satisfied with it - a union might be a better choice here, but if it works for now, let's run with it.


Good catch! I did actually change BUILD_MULTIPLE_APKS within build.gradle, but missed it in build.js!


Simply use
``` if(ObjectUtils.equals(problem.getProblemURI().getURI(), qualityReportURI)) { } ```
instead of
```
Resource problemURI = problem.getProblemURI();
 if(problemURI != null && problemURI.getURI() != null
    && problemURI.getURI().equals(qualityReportURI)) {}
```


Job pr-scala failed for 31442594 Took 64 min. (ping @retronym) [(results)](https://scala-webapps.epfl.ch/jenkins/job/pr-scala/9549/):

To retry exactly this commit, comment `PLS REBUILD/pr-scala@3144259495431f3038f19491c29a903959dbfe72` on PR 4254.
NOTE: New commits are rebuilt automatically as they appear. A forced rebuild is only necessary for transient failures.


.gitignore exists for a reason, you know.


Aaarrrggghhh - yes it should be!  Thanks.  I'll fix it and resubmit.


That's what I meant ;-)


Consider adding a `to_proc` method; this would allow you to directly use the `&` unary operator on instances of `Serializable_Lambda` (meaning you could write `&@lambda` instead of `&@lambda.code`).

Just seems a little bit more idiomatic and expressive that way.

```ruby
def to_proc
  @code
end
```


Small issue, tested and it now transfer correctly below 5K ZEN.


I've added units to the docstring: d0676ad0a84afbf2ee7392c0d1b06662074d024f

The unit is float only because this is the return type from time.time().


I agree that an exception is a better idea. Done: ee2b27edc506695cd3f3532ae15b2aa6b8233f51


Reason: see commit message on 49a1f89e184a6618cac8bb77689b170109efd483. `tacho_motor_type` will eventually be replaced by a string that is used for the driver_id. `motor_type` is probably more appropriately named `output_port_status`.


Done: d8cb397e26ebeb0238aa550bc94d1bdf6f649d39


will keep in the mind. For this time will "ignore the space" while doing the merge so It won't add noise to the trunk


Also did $array to $storage as it is bad practice to use reserved words like "array" as variable/method names.


It works much simplier...
```
for (QualityProblem problem : problems) {}
```
List implements iterable interface..


what does that mean?


Update documentation to talk about these kwarg options.


I chose to leave the xids as strings here to avoid conversions back and forth between int & strings. The mlab.py plugin has a similar loop that finds xid entries in /proc/virtual/ and has no need to convert those entries to ints otherwise. Please let me know if you still see an issue or have a concern.


@vjovanov Can you give me a feedback? I also have questions about persisted and inline.


Just a question. We clean a model, would it me meaningless to return the cleaned model and not the problems which left over?? We clean the model but not the problems. Maybe the method name should be also more explisit. cleanProblems or cleanModel


Doh. Done: 3df7b2d2cc8a2593d40b59e6db8487d170973325


@tux3 @novist the minor change I mentioned (tux3 left IRC before I pushed lol)


Good idea. Done: d8d164632725eae1c400f4bcd0f5a8fffc015082


@ronag Consistent how?  The chat example was always a bit more complicated AFAIK.


I've updated the docstring for the utime & stime fields.
Is the docstring clearer now? 0892dd2a3727f19a94f6dae1ec7f868c8d9c2ce7


Hi

As I said in commit message it's not complete, I was in middle of something
just commit so that code does not loss on my system!

Regards
Ahsan

On Tuesday, January 20, 2015, Ruslan Kovalov <notifications@github.com>
wrote:

> Just a question. We clean a model, would it me meaningless to return the
> cleaned model and not the problems which left over?? We clean the model but
> not the problems. Maybe the method name should be also more explisit.
> cleanProblems or cleanModel
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/diachron/quality-extension/commit/b06bb940b79d7282baaa6e39dd5c55def845650b#commitcomment-9349106>
> .
>

--
Mian Ahsan Iqbal


86441310-PlantObject2 (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.27%25-red.svg)


this condition needs to be guarded as well.


Good question. This check appears to be unnecessary. The IOError will catch it. So, I've removed this patch.exists check. 080f2a2ab0a229fc5322fcc0eeed1329257b5016


[High] Use uppercase for class naming.


I agree. I've added the message_type as a parameter so that the field is set here.

705fdb8791258bb93c301d4cfd5d69b4aa4d428e


Deleted: 27addec02f443616abcf4583174576a487ce48f1


No problem: b69637074283e122d780668c95abba4f8f7a1bc0


Whoops. Fixed: b935130be97ca6c445a0fd8a8f64330d487e558b


"essential" is probably a clearer term here? I can leave that up to you.


@cici Pls help to review this PR :)


Done: 54f8e56bc9a963aee6d52366e25c704a8341d6fb


This Fixes #97


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/e2803f7198b30d4dfc59d6e6f5aa0ee320136f84


merging basho/riak_cs/bugfix/fix-hardcoded-crashdump-path = e2803f71 into borshop-integration-1052-bugfix/fix-hardcoded-crashdump-path


basho/riak_cs/bugfix/fix-hardcoded-crashdump-path = e2803f71 merged ok, testing candidate = ba338671


I agree. The reload is done in a tearDown method: 79182c3b3b2c228afc11f6e20e9dae1f9fc781cb


still not happy with the text.
```Generates and sets an anti-forgery cookie if one is not available or not valid. Also sets response headers.```


<see cref="FlushAsync"/>


This was just a re-applied patch. Nothing new has happened.


line breaks


@mje113 Could you explain why adding 5 minutes to the expires_in is the appropriate thing to do here?  I was using dali 2.6.4 and set the  expires_in to 30.days.  Memcached interprets anything over 30 days as a timestamp and adding 5 minutes made it greater than 30 days, therefore my cache didn't work.


Noted .. oh well, it didn't get mentioned in previous releases


上の修正はコードの簡略化で内容に変更なしです。
下の修正で編集ボタンを追加してます。


*labels


listo parce


@tschottdorf Can the node only send heartbeats to the groups, which local nodes are the leader of. Moreover considering there is a gossip protocol involved already, probably we could simply always generate heartbeat messages locally until the known leader is not healthy in the future. In another word, we could never send out heartbeat messages.


Good question. I wanted to make sure that the expected value did not contain the same list that was being returned but that it had the same values. That syntax takes an array slice of all elements. It's not clear, though so I've changed it to use 'list' instead. 77937e750c281d93f42817598e90d9e2394ae468

This is an example of what could happen if the actual array were given without making a copy.

```python
>>> original = [1,2,3]
>>> v1 = {'515': original}
>>> v2 = {'515': original[:]}
>>> original.append(4)
>>> print original
[1, 2, 3, 4]
>>> print v1
{'515': [1, 2, 3, 4]}
>>> print v2
{'515': [1, 2, 3]}```


Done: f2b2e605f9b92fcf0047ccc9b012246873154326


This was a mistake. Only mocking methods is preferable. I've changed the tests to mock the getpwuid method instead. f96851e50d6e1996e89ce108b9ced563a13daaba


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.32%25-red.svg)


I figured it out. The trick was using [both of them together](https://github.com/abdyer/android-test-demo/commit/ad0e8318c17b5ffe909d213742db05a7e5329e84). Thanks for prompting me to revisit this.


Fixed: e6d2f7f691691b6e19304f32a6e6f5a5101fb790


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/768


Seems I derped on this and forgot to update the untextured list and remove the ones that are there.  I am working on some things for another mod and will update it in that pull request


Throwing a comment in each of these with an example line would make this much easier to parse.


[Tip] getInstance method in a Singleton class should be synchronized to ensure only one instance.


Same mistake. Tests mock methods of the sys module now. caa7b89d9daff795050d6cfdd069fb82662b080c


lol


OK. I am mistaken. the constructor accepts the ThreadPool interface. will use the ExecutorThreadPool for latest JDK


Alright, I think I remember now - I implemented it myself and was going to push the change to the mainline version. But if zero-signal version works, that's good. :)
Thanks for trying this out. If anything is missing / not working feel free to post an issue and I'll take a look at it. I'll make sure to document the needed changes to get this to compile.


Does `\n` still break lines? or shoul I turn all `\n` into `@n`?


I agree. This looks like a carry over from tests that needed to compare the returned & expected values. I've removed the unnecessary variable. f400b055010d00d8fffcf94e3ceb07a946823e5d


Only `@n` breaks lines properly.


Hey @melyan @ankur-gupta91
 I updated the "Sign in"  to "Login" on the most pages just to be consistent. Please review and merge.
Thanks


You may need to check directly in the source code. Maybe some of the "path" generated was Windows friendly as I developed on window. I can run on linux, as my colleuge did, but need some tweaks.


pass


Okey! Thanks (replacing `\n` with `@n` is as easy as `string.gsub(mytext,"\n","@n")`)


You and these merge commits.


Github bug


:D


i don't like the switch method here because it isn't what we learn in OOP but...


@luiji - would we want to fix this in the release-2.0.0 branch, too?


Maintenant, on est webscale


lmao going to use this plugin due to its self-loathing nature


This line is no longer required


The options in this line cannot be removed because the syntax for sequelize() requires 3 parameters followed by the object. Is there any other way ?
`console.log(options);` gives `{}`


To be fair, even with my smaller projects ([here's an example](https://github.com/simple-cms/page/tree/master/src/SimpleCms/Page)) I've been namespacing by it's section rather than what it is.

For example Rather than having `App\Models` and `App\Repositories`, I have `App\Blog` and `App\Media`.

I find `use App\Media\RepositoryInterface` a lot cleaner than `App\Interfaces\MediaInterface`, but maybe that's just me.


This commit breaks the Plone 5 AT tests:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3391/


Did you update rspec? Is it better to use eq false than be_falsy? I guess it it’s important to assert that we get actual bools? When you fix that wouldn’t it be good to use the expect syntax as well?


TeamCity Ylab :: zmactep/ylab [Build 161](http://192.168.30.225:8111/viewLog.html?buildId=576&buildTypeId=Ylab_ZmactepYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:11:59


instead of using the generic "Exception", can you create a custom exception case classes and maybe a
```
sealed trait MyCustomException
case class MyCustomExceptionOne(message: String) extends MyCustomException
```
So that, anyone pattern matching on the Left(...), knows which expected exceptions to handle?


See https://github.com/fruux/sabre-vobject/commit/34fc363991bf242facff41da0b86c980ad00ac8b. It solves my issue here.


I reverted that commit for now.

The changes in Products.MimetypesRegistry also break the Plone 4.3 tests:

http://jenkins.plone.org/job/plone-4.3-python-2.7/2828/console

@thet Please revert your commits or fix the failing tests asap.


now the fun begins!


i guess the link should point to http://wiki.jmonkeyengine.org/doku.php instead of relying on a redirect


Thanks Fred!


... actually doesn't hang, just stops for a long time... some sort of decimal buffering?


LGTM.


Please add another line "chown -R ${JENKINS_USER:-jenkins} /var/cache/jenkins"!


TeamCity Ylab :: Feodorov/ylab [Build 58](http://192.168.30.225:8111/viewLog.html?buildId=577&buildTypeId=Ylab_FeodorovYlab&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 121 Build time: 00:11:52


Unless our web guys change it again tomorrow ;) Thanks for the hint tho.

Normen Hansen

> Am 20.01.2015 um 11:04 schrieb Michael Zuegg <notifications@github.com>:
>
> i guess the link should point to http://wiki.jmonkeyengine.org/doku.php instead of relying on a redirect
>
> —
> Reply to this email directly or view it on GitHub.
>


@mirasrael yep, thank you! It looks fine.


我们只翻译。


Spletni naslov daj med zavite oklepaje, da ga bo ukaz `\url` zagrabil v celoti, torej
```LaTeX
\url{http://www.imdb.com/list/ls055592025/}
```


`Module#prepend`, sweet!


i think i introduced a bug here, there is no unit test catching it :( will add one
basically there will be a newline before the first element, which is not the expected behavior


same here :/


can you please leave this variable as it is and instead put a jwtToken variable? but besides this must fail, as the expiration date will not be valid anymore a few hours after this is generated. So please find a way to generate a fresh JWT for the tests.


and here


found the bug because a unit test caught this here


naptınız lan


`[loadingType='loadAndUpload']`


Don't set `album_invalid`, for you don't use it. This is what makes the tests fail (`flake8`).


Maybe I should reinforce that the 3.0.0-amd is a tag  and that the `volo add lodash/3.0.0-amd` corresponds to the second AMD loader example. Help organizing examples would be appreciated.


Turns out I needed to do 'make all' in order to get it to work. So nothing wrong per se with the smoke tests, but maybe some way of running them that establishes the prerequisites would help.


It’s now `.com`. :smiley:


Alright. Then we will have to adapt the Dockerfile. Does this then result in a new EPEL release?


Sorry about this commit, the first line started with "#354:  ..." and git commit interpreted it as a comment and didn't include that descritive line. Guess it's the right moment for #349


Whoops, sorry.


Will do.


You can write this shorter:

```
else {
    loader [ def.loadingType || 'loadAndUpload' ]( def.uploadUrl );
}
```


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/579


既然方法名是setPaths，那么把ROOT_PATH当做参数传递给setPaths里面，在函数内对paths.ROOT_PATH做赋值会不会更清晰一点？


Splacing?


Fixes #1


Please rename to OtpErlangTransportFactory


Forget about it. I was just thinking if it is needed to store the scale factor in your `lis3dh_t` struct. But now I think it's much safer than dedicating this to an application.
I like your proposal to use "normal" `int16_t` instead of bitmasks!


meanIndex is only a uint8_t, I declared it that way specifically because I was wrapping it around. In other words, I don't believe 140 and 141 should be changed liked that, the change to 147 alone will fix the divide by zero.


the documentation of the error value of `runBatch` doesn't quite seem to be correct after this


geht bis zu einer gewissen länge, dann steigt BE aus, k.a. der ansatz passt, frage ist warum


LGTM


`PLUGINS_OPPOSITE_PATH`、`OUTPUT_TEMPLATE_OPPOSITE_PATH `这一类相对路径是相对静态的。
个人觉得`core.data.paths`里面只存储绝对路径，而相对路径放回到`settings.py`里面会不会比较便于修改配置？


nope not a bug here, but there is inconsistency between the emit_ functions


It would be good to either log individual item errors as we run into them, or assemble them into this error return code


Yes, I'm really wondering how this didn't cause any malfunction?! Thanks for your alert eye!


nope is fine


also fine


We might want to use `!inCompat` instead of `Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP` here also, e.g. for testing.


Also, why Volo only? I think Bower and Component are much more popular.


Doesn't look like it should do any harm, though I'm also not really sure it helps.


Yeah, I figured I might as well assert that they're real bools, but I don't feel strongly. Could have gone either way :)

The cleanup took more time than I aimed for so I skipped the expect syntax this time.


Adding again remote


Adding a line note


volo is an amd package manager so fitting with the amd example.


the "issue" is actually this: all other emit functions that have sub-element functions do not send a \n before calling the function, but expect the function to check idx for the zero element
since there is no guiding standard, i'm unsure as to which is the correct way.


I was able to figure out how to get the windows test and non-windows test into one gulp task! It's still different code for windows, but I think this is as good as it gets for now. Can anyone else test this please?


String.


I tried to remove this div together with the .console-container-row from the css (but still referring to it in the div) and set the margin-top and margin-bottom to 0 in .console and that seems to make it work without that div. That would allow us to kill the last piece of inline styling


:-1: Who cares. It's one test. Future versions of Ava will remove the `[anonymous]` when there's only one test.


As you're using slf4j, you should log like this: "Registering {} as a root resource class" instead. Right now the name is not logged properly.


Because python is obviously the most awesome language in the world!


> Guess it's the right moment for #349

Do you want to do it?

I think the following should do it:

    % git push origin/stable/2.x.x origin/master
    ...

... - oh you did it already! Great! :+1:


btw I have no strong feelings on keeping the volo install example. less is more but I'd like to draw attention to the branches.


update_sqlite_coverage (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1555 of 1592 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.68%25-yellow.svg)


It has expiration date for long period of time. How you would propose to check jwt validation with now jwt token?


+1 We just hit same issue as @mjgallag
cc. @jperl

@glasser looking forward to hopefully lodash - I'm sure the community can be of some help doing qa


Thanks


Sure, I will put the comment in teardown to explain this.


Ho i can run this code (spring-security-oauth) and how to configure the system for that.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1936](http://teamcity.monogame.net/viewLog.html?buildId=5003&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Oh, yeah. I remember now. Someone had the same problem with Hrisey and they solved it this way.


@stulees I think that's an acceptable trade-off if it means a better experience for the user. It also makes it easier for us so that we don't have to go track down those custom layout files that we created months ago every time we need to test custom layouts.


Not a good idea to use System.exit from a library. In case of problems, the default factory should be returned.


I went and translated this into powershell, in case you ever feel a strong desire to remove the shell script:
```
  - ps: if ($env:APPVEYOR_PULL_REQUEST_NUMBER -and $env:APPVEYOR_BUILD_NUMBER -ne ((Invoke-RestMethod `
        https://ci.appveyor.com/api/projects/timholy/$env:APPVEYOR_PROJECT_SLUG/history?recordsNumber=50).builds | `
        Where-Object pullRequestId -eq $env:APPVEYOR_PULL_REQUEST_NUMBER)[0].buildNumber) { `
        throw "There are newer queued builds for this pull request, failing early." }
```


Add only the default constructor with default value.


hello @shirioko ... many thanks for the great app.  I am trying to register using a virtual number from the US and there is an error ... (attached) ... please advice.
![new picture](https://cloud.githubusercontent.com/assets/8974905/5815671/b0111f0e-a0a8-11e4-9a85-3c7089a08d8a.jpg)


@markelog Will you fix that? ;-D


The large MD files that you break down to create these have dates in their names. You should use the dates in the filenames here rather than "today"'s date, as that is more accurate.


These are the versions I used for building the them for the Mozilla addons website. They're included in the extension there. In the tagged release on GitHub, the max version is a little higher, but everything else is the same. (In practical real-world usage, there should be no difference.)


@kokoff as noticed by @rc1035, unfortunately this commit breaks the user interface on Linux. I am moving this commit to a new branch `menufix`. If you want to continue working on this feature please work on that branch. Once it is tested to be working, we can move it back to master. As the deadline is tomorrow, we may just want to leave this for the next team to work on.


r+


If the names in *tExternals* follows the case of the library files in the Android runtime folder, then it produces a .so file with a lowerCamelCase name (line 680) instead of a lowercase name. That will certainly cause issues in different places when loading the external modules (and the mapping is needed to have a file location working from either the repo or the installed version).


awesome dude


(This applies to more places in the code) Maybe skip printing the error to the console and throw an exception instead of returning null? The client may want to report the problem in a different way.


I don't like this method. It says it only sorts attributes (by its name) while it totally reprocess the HTML. The next step will be to compose two methods like this - e.g. `sortAttributes( normalizeStyle( html ) );` what would be absolutely slow, because every function will reparse and rewrite the data.

We do lack proper methods for HTML comparison, but we should not create more useless ones like this one. Create this function locally in tests which need it.


Yep


zzzz


@stulees I think I got my info from the idiomatic style guide and jQuery's style guide. Regardless, for every article that says to do it one way, there's probably another article saying why's it better to do it the other way. At this point I suppose it's up to the developer's discretion since they both do the job.


Support for timeouts added, the main part of  #3 addressed


It should be "creating copy of"


Don't add a separate method. Instead have a separate constructor for CookieMonster


Daniel,

It's very hard to merge these commits into the mainline of the resbaz repositories because it's all been done on the master branch. If you could create a new branch it would be easier for merging when you issue a pull request.

There are a number of ways to do it, I'm happy to help if you need. I'm sitting at Steve's desk tomorrow, back again on Monday next week. I can't think of how to do it off the top of my head, but we can probably work it out between us.


It only creates the atlas if the image is not already cached. In almost every case, the image is already cached, it just does not have the expected region defined.


Maybe a `SHADOW_MIN_ALPHA` instead of `6` if we also have a `SHADOW_MAX_ALPHA`?


IMHO a very controversial cleanup.
Introducing the function that does "many things"
depending on different values is not the best practice.
How about introducing the internal func find_env()
and wrapping setenv()/getenv() around it?

What in particular makes me to dislike your patch,
is this:
---
+ if (value != NULL && *value == NULL) {
+ /* Return existing var value. */
---
So to get the variable, the caller needs to first
initialize it with NULL?! Anti-cleanup. :)


I never use the `npm -g` + `npm ln` style. Do you think it's distracting to include that in the npm usage?


saw approval from Manishearth
at https://github.com/Ms2ger/servo/commit/6694fd43793775f9efa1b4424bcf58ddfb5988a0


merging Ms2ger/servo/lastmodified = 6694fd43 into auto


Ms2ger/servo/lastmodified = 6694fd43 merged ok, testing candidate = 9e78116b


Sync with TMRh20 sources


Nice. :+1: