Should be fixed in 64958965db9a36cdea685ac0b5df5f061b0620a1


is the jar file corrupted? I cant access it when I download the zip file


This comment was deleted in a subsequent commit, since we explicitly list the exceptions we intend to catch.


You can have it add syntax highlighting by postfixing C# like this:
```C#


Maybe could be `getHasTwoFactorAttribute` for now.


@greg80303 Yes, leave ```Capabilities.supportsEncryptedMedia()``` and move the contents of ```Capabilities.setup()``` back to ```DashContext``` so that it can be overridden by a page using dash.js /cc @KozhinM


This is called as `label` on line 31 inside `create_adjustment`.

How is this passing tests?


Was this rename really intended?  Looks like an overreaching `s/uint/usize/`...


Starting CLI tests on Windows.


As expected, after reverting changes to `contracts.rb` and `decorators.rb` back, specs are green. Wrapping up a PR.


Done.


c'mon arco :) more lollipop sweatness :)
and also this feature will be disabled until user disable low_ram prop in build.prop
let's leave the choice to the users


Should change this to return OrderDto instead of HttpWebResponse.  This may be unnecessary unless they need to capture our Id.  If there are errors they will be thrown as exceptions.


@virgil this is for you 'bro!


Also, yeah, I considered flattening `JsCore.If(cond1, JsCore.If(cond2, consequent, alternative), alternative)` … I’ll add it.


Why is this necessary?

If tests fail without this, maybe the `update_adjustable_adjustment_total` method is broken.


can you please put the workflow in the comment:
first A
then B
expect C


These rand functions also look like too much `s/uint/usize/`.


Ciekawy commit! :)


gotta drop that `< 0` though

(in case curious:
```
> false < 0
false
> true < 0
false
```
)


very interesting


Can you make it uint16_t given you've changed to a vector now, thanks.


We do currently use `=` in JsCore stuff, yeah, but in future this would probably be buried in some `Let` expansion (flattening our tail calls into loops, right?).

And I’m happy to switch to `undefined` here as well. Mongo semantics are basically `undefined` for bad projections and `null` for other bad expressions, but `=` is a special case that doesn’t really map to anything in Mongo.


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (330 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69788519637463%25-yellow.svg)


mm wait, this work but i would prefer a  different fix by the way :)


This was updated 4 days ago... Are there any changes from what was done before Christmas?


Let's go ahead and change OrderDto back to Order and OrderItemDto back to OrderItem.  This will help make it a bit more simple for the customer.  You will probably need to use aliases in the OrderService like:

using OrderDto = Cloud.Api.V2.Model.Order

etc.


And in all these tests, `bigusize` is probably a mistake, no?


Awesome changes. Keep it up!

How are we doing on performance?


:grinning:

Thought I might as well make a new package since the old one was so hopelessly out of date and `algebra` was already reserved anyway…


SPaG successfullyAdded


I see two parameters, `pred` and `haystack`, not `needles`.


ja.


Whoops, this got forced pushed by mistake.  As it was off a fresh clone of METADATA I hope it is ok.


This is a great idea - thanks!


I think they all need one more space, unless its not formatting properly on Github.


Oh dear, thanks for catching this! Does https://github.com/rust-lang/num/commit/45f5cc39bd5337271ead78c38061eaa1a4b93e59 look ok? (I'll publish if so)


@cvium Just wanted to double check you saw the unit tests are failing now. Not a big deal, but the release process will be held up until we sort it out.

You can always double check on the branches page the status of the tests, it'll link to both travis and our jenkins when you hover over the :x: or :heavy_check_mark: on the develop branch.
https://github.com/Flexget/Flexget/branches


The whole condition reduces to `object_name.endswith("-proxy")`


done


84694650_EnableCodeCoverage (lefticus) - x86_64-MacOS-10.9-clang: OK (1461 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.70304568527918%25-yellow.svg)


I'd argue that since every single command is named like this, it makes sense to take advantage of that instead of having dozens of lines of `FooCommand => "Foo"`; one of these things is much more likely to have typos.

It is a reasonable thought, though.


Ah, `needles` was below the fold. My mistake.


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (596 of 596 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is a new forum for me and frankly I hardly feel like I know what I'm doing!  So I will just cut to the chase.  Through the course of my life I have had some considerable obstacles to overcome that have caused me to become financially "broke"!  No kidding.  My mother was an nonrecovering alcoholic that caused me a great deal of mental anguish.  It affects me to this day.  It had a significant impact as one of the causes of my divorce from my first wife.  I became extremely depressed, almost to the point of suicide.  But I survived it as time has a way of healing old wounds.  Now I am trying desperately to find a way to get out of the financial doldrums I am in through internet marketing.  My desire to use Reddit is one of those methods I am exploring.  If anyone can help me understand how this forum works and be willing to talk to me about it I would be forever grateful.


I like this. :+1:


Maybe WithNetNSAtPath() would be less ambiguous?


Very interesting... Is this squashed so you don't keep around the witness, or a different reason?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/503
success: http://build.servo.org/builders/linux2/builds/501
success: http://build.servo.org/builders/android/builds/539
success: http://build.servo.org/builders/mac1/builds/720
success: http://build.servo.org/builders/mac2/builds/720


Looks right to me, thanks!


this is a good patch
dexpreoptimizing should be only on linux hosts
also look inline comments mate
thanx


why there is such difference in name format?


Ah shit. Didn't see actually. Makes sense though. My bad. Will fix in a minute.


Ignore this, looks like you fixed it in a subsequent push.


ı dont know this define is doing what.. let's dig the art sources :)


Ben, you are correct that tickets are typically resolved at the point when
the code required to fix them is in master.  This can span multiple commits
and/or verification of the fix, so it's not always immediately resolved.
The tickets are then typically "closed" once the release is complete.

On Fri, Jan 9, 2015 at 11:35 AM, Ben McCann <notifications@github.com>
wrote:

> Oh, looks like they have been marked as resolved now instead of waiting
> for the RC to ship
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mongodb/mongo/commit/f58fa5f78a91ce36d8e31d6730ebfdaa6cc1d5ab#commitcomment-9221245>
> .
>


I just cleaned up the code a little bit, and kept logging to only what is needed so we don't burden ST with a ton of messages.


fast-forwarding master to auto = ebb702ab


CLI tests pass on Windows.


Why roll our own `exec` and not use the stock one? Looks like you just omitted the chown command and case statement. Sure those don't *need* to be run every time a command is exec'd but we are now diverging from the standard app exec process, right?


@sirmordred Yeah, I use Darwin and it gives segfault 11 if you do dexpreopt on it. Realized this was missing. Will look into that other param.


Yep, that's the only reason at the moment.


Any particular reason to change the stopsignal?


Starting CLI tests on Linux.


This is broken.
maps are not thread safe.


I've designed it so that the material physics are appended automatically.


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1467 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.7307206068268%25-yellow.svg)


This will probably break older devices that don't have v0lte


org.openmrs.htmlformentry -> htmlformentry. This can be later used to GET  the module.


Fixed with 6a50731


Sweet


@doutriaux1 this will require the v1.0.0 tag point to be moved, and once set, we'll need to convert master back to checking out "master" versions of the metrics and UV-CDAT..


Doesn't seem to when you convert to raw first, at least. The raw vector isn't null terminated.


@sirmordred you may also need eth0 in dhcpd initialized, like on TF700T.


@bors: retry


Nice!


It is because I changed the naming. Not sure how to change the test to accommodate it. The mock object needs to contain a Torrent class file or at least an object with a `content` field.


runs [a] differently


@virgil this is for you 'bro!


@r04r your code style has significantly improved :)


Worth a minor version bump?


@pepol can the "however" part be in a new sentence?


The param does no harm nor anything by itself (remains disabled), but leaving it defined allows us to have a choice/try it if we dare using the lowram trigger as sirmordred says.


Oh doh, I missed that


Broken link here.


Huh, I failed a copy paste in the commit message. The second commit is supposed to be a7a663182710f5a933e096a860b858a47b54387a


No it won't, it's not the default APN. It might if they manually select this one, but the user bears the risk if they decide to change stuff like that.


This is removed but I don't see where it was added?


Delay this require into the body of getExcerptFromReadme.


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3087
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3080
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3081
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3072
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3072
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3075
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3068
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3063
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2740
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2738
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1576
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1568


fast-forwarding master to auto = 73a25f55


I do. There was a hole in the encapsulation that could be broken accidentally or intentionally. Now it is fixed, so I really see no reason why to revert it. Bugs should be fixed regardless there is evidence of real world misuse.

Is the reason why you want revert the router optimization? In that case you can rely on immutability by contract. I.e. refUrl will be always the same.


this whole function is weird btw, we should revisit our approach to dat options before we do the beta


I'm having a hard time understanding this one.  -cdst is to let you specify a different destination file name than is being copied.  Is that correct?


r+ rollup


This looks good to me. Thanks!


should i be checking for isClosed also? additionally, should we try to 'validate' that you passed in a valid levelup instance and return an error?


what does this comment mean?


CLI tests pass on Linux.

And now we wait for the Jenkins jobs ... ^^


Thanks! It definitely has, looking back at all the minichan code it's just so horrible. Though in my defense most of it has been written while giving zero fucks late at night ;)


Dynamic Programming


oops!


@arthurnn just merged 4.2 :dancers:


LGTM. Before I merge your commit, can you sign this CLA (corporate policy):
https://cla.developers.google.com/clas

Thanks for your contribution!


Ah ok, well guess it will be a temporary tradeoff. Use the old commit to keep necessary packages working and manually change env to $_ENV.

Hope it won't be too much work to port to the final version from this this commit =/


I'm getting problems with my build, in every #ifndef OMAP_TUNA block, like this:
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:31:88: error: no 'Ti::status_t Ti::Camera::OMXCameraAdapter::initDccFileDataSave(void**, int)' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 status_t OMXCameraAdapter::initDccFileDataSave(OMX_HANDLETYPE* omxHandle, int portIndex)
                                                                                ^
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:65:82: error: no 'Ti::status_t Ti::Camera::OMXCameraAdapter::sniffDccFileDataSave(OMX_BUFFERHEADERTYPE*)' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 status_t OMXCameraAdapter::sniffDccFileDataSave(OMX_BUFFERHEADERTYPE* pBuffHeader)
                                                                                ^
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:137:62: error: no 'FILE* Ti::Camera::OMXCameraAdapter::parseDCCsubDir(DIR*, char*)' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 FILE * OMXCameraAdapter::parseDCCsubDir(DIR *pDir, char *path)
                                                              ^
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:215:66: error: no 'FILE* Ti::Camera::OMXCameraAdapter::fopenCameraDCC(const char*)' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 FILE * OMXCameraAdapter::fopenCameraDCC(const char *dccFolderPath)
                                                                  ^
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:245:58: error: no 'Ti::status_t Ti::Camera::OMXCameraAdapter::fseekDCCuseCasePos(FILE*)' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 status_t OMXCameraAdapter::fseekDCCuseCasePos(FILE *pFile)
                                                          ^
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:303:48: error: no 'Ti::status_t Ti::Camera::OMXCameraAdapter::saveDccFileDataSave()' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 status_t OMXCameraAdapter::saveDccFileDataSave()
                                                ^
device/samsung/tuna/camera/OMXCameraAdapter/OMXDccDataSave.cpp:343:49: error: no 'Ti::status_t Ti::Camera::OMXCameraAdapter::closeDccFileDataSave()' member function declared in class 'Ti::Camera::OMXCameraAdapter'
 status_t OMXCameraAdapter::closeDccFileDataSave()

what's the problem with my setup?


r+


IDFXT (Unknown) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-73.9873417721519%25-red.svg)


saw approval from alexcrichton
at https://github.com/kmcallister/rust/commit/a96a8b2b2526aaa631183f71aef9acf390b61f48


merging kmcallister/rust/macro-cleanup = a96a8b2b into auto


status: {"merge_sha": "c133b2110b79d7a735032e4af431ee3a1143f3ce"}


kmcallister/rust/macro-cleanup = a96a8b2b merged ok, testing candidate = c133b211


It's fontcustom.yml, not fontconfig.yml ;)


this line is complained by go1.4 compiler that no new vars assigned, with [go1.4] (https://golang.org/doc/go1.4#forrange) the variable-free form is now legal

    $ go version
    go version go1.4 linux/amd64

```go
    for range sigchan {
```


r+ rollup


Maybe we should open a bug for this.  I think we can just use github's issue system for that :)


Can you quote the bug ticket here please?


ok found it https://android.googlesource.com/platform/build/+/5e0dbe0%5E!/
this option is used for saving space probably
ı dont know it is needed or not


I think it's clear now that there is no default way to handle packages in Laravel 5. Handle your package the way you like.

So no need to refer to the 846c9351 commit, just update to the latest and try to get your package working using a ServiceProvider.


r+ p=1


Well ok, i'll let it so.. for some time.. till many user report some issues with sdcard.. but i don't removed SELinux Files from Ramdisk... only the Service for AUDIT .. waht u say to me ... only this.
We'll see .. :-)


The only place we use __PIC__ in libc is in the ARM unwind helper in arm/aeabi/aeabi_unwind_exidx.c


@migueldeicaza - I never got a response from you before, but I don't see anything missing an indent.  Can you please clarify if there is still an issue?


Why only include `pages/*`? Why not snippets, team members, skills, etc.?


Zone.java has these two static finals.
public static final int DEFAULT_ZONE_ID = 0;
public static final int UNSET_ZONE_ID = -1;

Instead of using -1, I suggest using Zone.UNSET_ZONE_ID


Without the `type` property, pushSettings will be typed as an anonymous model representing the nesting structure. What do you try to achieve?


Remove this


What I normally do here is look at the colors in terms of HSV.  I pick a good saturation and value, and then divide 360 by the number of lines I want, and set hue = 0, 1*(360/lines), 2*(360/lines), ... so the colors are maximally different.

An even better algorithm would be to pick a default number, like 4, then pick the colors 90 degrees apart.  Then for the next 8, divide those in two.  And so on.  That way the colors will be the same every time.  (But in the case of 5 lines, color 0 and color 4 are awfully similar.)

:)


Is "inputs" variable even used?


@akoeplinger - thanks for your help on this dealing with the circular build to include Mono.Posix.  It builds now, so hopefully can get this PR accepted.


use strict;


Jhonathan, deberías seguir la convención para los commits.

es hora de git commit --amend

https://github.com/ajoslin/conventional-changelog/blob/master/CONVENTIONS.md


Like it.  How do I delete files from the repo after they've already been added.  Updating the .gitignore and deleting locally won't remove it from the repo, will it?

Also, what is .egg?  I should look it up.


Please note that despite this happening chronologically after a lot of work was done to this gem, its parent's parent is https://github.com/neo4jrb/neo4j/commit/e1c3245b56e682f5ff2126e7538730dbfa25635a, which was v4.0.0.rc.4. It includes no changes after that commit other than a requirement of neo4j-core 4.0.0.

Unless you are trying to avoid something that happened after v4.0.0.rc.4 was released, you should use 4.1.0.


I kind of liked the world filter; sanitize is something that we should be clear that we're doing at trace collection time, not in the client.


Hmm also bei mir scheint es nicht zu funktionieren... Habs mit WG 5.8 und 5.8.1 getestet und wenn man als nicht-op ein Fass anklickt bekommt man diese Fehlermeldung, hast du irgend eine andere Version genutzt?

```
23:18:07 [SCHWERWIEGEND] Could not pass event PlayerInteractEvent to Brewery v1.3
org.bukkit.event.EventException
	at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
	at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:30)
	at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:478)
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:463)
	at org.bukkit.craftbukkit.v1_6_R3.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:207)
	at net.minecraft.server.v1_6_R3.PlayerInteractManager.interact(PlayerInteractManager.java:374)
	at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:631)
	at net.minecraft.server.v1_6_R3.Packet15Place.handle(SourceFile:58)
	at org.spigotmc.netty.NettyNetworkManager.b(NettyNetworkManager.java:230)
	at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:117)
	at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
	at org.spigotmc.netty.NettyServerConnection.b(NettyServerConnection.java:132)
	at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:594)
	at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:240)
	at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:483)
	at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:415)
	at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.NoSuchMethodError: com.sk89q.worldguard.bukkit.WorldGuardPlugin.getRegionContainer()Lcom/sk89q/worldguard/bukkit/RegionContainer;
	at com.dre.brewery.integration.WGBarrel.checkAccess(WGBarrel.java:18)
	at com.dre.brewery.Barrel.hasPermsOpen(Barrel.java:127)
	at com.dre.brewery.listeners.PlayerListener.onPlayerInteract(PlayerListener.java:128)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
	... 17 more
```


Would 'tx'/'rx' be more idiomatic than 'ta'/'ra'?  (I think that's what these are, but I could be wrong.)


I don't like this @ptubig please find a better solution


Hi @hughmcguire
Now that @bdolor has successfully added "make_clickable" to all footnote links, I'd like to raise a UI question.
How do you feel about modifying the code to make all of these external links open in a new tab/window?
I understand there are different views on this, but I prefer opening new tabs/windows rather than potentially losing web readers.

If you agree, here's one code suggestion (thought I don't have skills to implement it in class-pb-footnotes.php), from http://blog.robbychen.com/wordpress-make_clickable/
```
function mc_ignore_shortcode($content) {
    $content = do_shortcode($content);
    return make_clickable($content);
}

add_filter( 'the_content', 'mc_ignore_shortcode' );

function blank_link($content) {
    return preg_replace('/<a /','<a target="_blank" ', make_clickable($content));
}

add_filter( 'the_content', 'blank_link' );
```


Why are they 'classes' and not 'class'?


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (331 of 331 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ooof, I don't think we want to be default-deleting every MDS' session/whatever table if somebody forgets to supply a rank!
I'm not sure if we should just remove the "do it to all" functionality, or simply require that users specify a rank whenever they invoke this tool. Although the snaptable doesn't have a rank, hrm.


I think getModels() is returning an object.

"ErrorException in BelongsToMany.php line 177:
Argument 1 passed to Illuminate\Database\Eloquent\Relations\BelongsToMany::hydratePivotRelation() must be of the type array, object given..."


Split


This fixes that.


For mod, who is spoiling the post:
```
TypeError: this.model.get(...).set is not a function
```
For user, who is receiving the new info about the post being spoiled:
```
Uncaught TypeError: undefined is not a function
client-1b11d3bd2f.min.js:1 Hidamari.renderSpoiler
```


@katyhuff I fix this link and push direct to swcarpentry/site (see 194b952).


My understanding was that inputs are used like the dependencies in a Makefile — if any of the source files are newer than the output(s) derived from them only then will the action run.


Hmm, do we want to keep running if we hit an error? What if we hit other errors?


Rather than doubling up the code, can't we just fill in in_ranks with either the named rank or all ranks? ;)


Fuck, hold on. Not sober. Let me test it.


Does this need to be a svg element?  I would probably use a div.  (Everything else will remain the same, except you can just set the innerHTML or text to the butterbar message.)


Sure, will do.


@godiard "The brush sound have a end, if i draw a very long line without stop, the sound start and stop many times. Is possible cut it to make it more constant?"

I dont understand what you mean :-/

--

A ver si entiendo, el sonido de dibujo es muy "feo", o se repite demasiadas veces y queda feo..
O sea, que tengo que buscar otro sonido?


I noticed in the demo that when selected, the text overflows on top of the other legend entries next to the selected text.  Maybe that could be avoided somehow?


Should probably be `zikula:install:start`


"[0]" is for testing purposes,so it returns a string, as setting an Array causes a crash during search()


yup


Line 17: I think default values will trigger a ValueError


Не прокатит, если мы будем не в корне проекта. Например. в папке images.


r+ rollup

Thanks!


Oh, and let's just move this to a js file in this CL.


So simple.


you're using asyncio.wait but only on one thing? seems like you could just do:

instead of:

    asyncio.wait_for(asyncio.wait([asyncio.async(client_coro())]))

just use wait_for

    asyncio.wait_for(client_coro(), timeout=0.1)

right? The other test waits on a client_done & server_done, and it looks like a little bit of copy/paste gone wrong in this test.


r=larsbergstrom


I'm not sure about this one.  The intent was for the ReadFile to be asynchronous so both new data AND hStop could be waited on.  This thread needs to end when hStop is set because pLP is a pointer to a stack variable in the master thread, so the master waits for this thread to shutdown before it cleans up its stack.

BUT, looking at the code a few years later, I'm not sure that is what it is doing.  The pipe was not opened with FILE_FLAG_OVERLAPPED, the pipe is a wait pipe, which also means ReadFile will wait until data is available.

So the concern is not getting stuck in ReadFile when the master thread is trying to shut down...

What return code are you typically seeing when ReadFile returns at the end of the remote session?


I'm not sure why this has been removed. Every RAMPs board I've used (8 or 9 - a mixture of v1.3 and v1.4) doesn't have power on the PWM/servo pins. The board layout for v1.4 on the wiki shows that it requires a jumper to be put on the upper to pins on the three pin header to the left of the servo headers.


This works on 3.3.5 too


For now I just duplicated code from ffi_callback.py. Maybe we can make a convention that a file starting with underscore is not a test, and use such for support modules...


I had added that in there when I was debugging the infinite forks. I think it's a better choice than QUIT.

TERM is the signal sent by most PaaS's to shutdown an app (ex: https://devcenter.heroku.com/articles/dynos#shutdown).


This doesn't really add any new fonts, actually. It does change the font styling, but that's not exactly the same thing. :D


saw approval from larsbergstrom
at https://github.com/mrobinson/servo/commit/b60f3544050a22a830418cc7f8e4342705dbad04


merging mrobinson/servo/fix-compositor-timing-issues = b60f3544 into auto


mrobinson/servo/fix-compositor-timing-issues = b60f3544 merged ok, testing candidate = c1d218cf


-O3 is said to often produce slower code in kernel; binary is larger and fits into cache less often


@djneo92nl nice ;) as I quickly kickstarted this change for the project you actually work on: would you be willing to make a pull request to the master branch of this package with your complete fix? I don't have an install at hand to test it.


Right. Sorry Graham, I forgot to update to the latest commits :'(


1) It seems really silly that `$request->getUrl() !== $request->getUrl()`.
2) It seems incredibly stupid that `$request->getUrl()` is now an expensive operation.
3) I have never seen any code broken by the previous behavior but I have seen code broken by this fix.

To sum it from my point of view we are sacrificing performance to workaround (meaning not actually fixing it) a problem which does not exist in the real-world.


In this format moving to dyna_salt was not easy. We have up to 3 file objects.  Each have a variable sized buffer.  Thus, there are 3 places where there were allocated pointers.  What I did is to allocate the salt struct large enough to contain all the salt data AND the data for the 3 allocated file objects. Then the file object pointer (the H[x].h) are kept NULL.  The salt dupe logic is then run, and compares work, since ALL of those pointers are still null.   THEN in a late setup, (at salt_set), if the pointers are null, we assign them, and we do it only that one time.

Also, a couple of other salt objects were moved outside of the comparable location (things like fname, offset and full_zip_idx were deemed to NOT be useful, since the same zip item can be found in multiple files, at different offsets, or simple just a different file name).

I do see one thing that needs to be removed (some early code, trying to get this to work).

This was NOT a fun hash to work on.  It is WAY too overcomplex!


So why the negative margin here?


@gazpachoking I have temporarily removed the failing tests. It is getting late here, so I will fix it tomorrow! The tests are failing because they need to be changed, the plugin itself is correct.


Where's that 1<<22 come from? Why not just do a read_full or (check this, but I'm pretty sure) specify length of 0?


Thanks to NathanW2 at https://github.com/NathanW2 for providing ROAM. "IntraMaps Roam is a field data collection application built using the QGIS libraries and Python. It was built to be easy to use on (windows) based tablet devices, with Android planned for the future."


its a hardware issue... not a firmware issue...


No problem. :)


What does this mean for pattern3 , is this going to merge cleanly?

If you are going to do more small fixes can perhaps consider merging in pattern3 first (even though it's not fully py3 compatible yet). Would be great if you could take a look/play with pattern3!


Well, I did not see one million dollars in cash but it exists in the real world. I also did not see a problem caused by this changed but I saw a bug caused by previous implementation.


I know it's slightly offtopic, but does the same coverage report code work on a Mac? Or do you run this on Linux as well?


Hey there. I think your substitution for "int" had some side effects. e.g.:
srd/unistd.rs:
-// We use phantom types to maintain memory safety.
+// We use phantom types to maisizeain memory safety.


84694650_EnableCodeCoverage (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (1461 of 1576 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.70304568527918%25-yellow.svg)


This doesn't seem like a good idea. `=` isn't really a BinOp in the usual sense, although it yields a value, so if we need it I would suggest having a `JsCore.Assign` case class. But why do we need mutation in our functional core language anyway?


Drunk coding best coding.


Ah, I didn't realize you right away you just pulled in the changes from FSQ in this commit.


**Do or do not, there is no try.**

Either remove this completely if you have no plans of pushing back into Bricks, or make it an ```#ifdef```` if you do.


I am sorry, I forgot the ".json" in the file name.


K, no prob.


Fixed tab spacing for better readability.


No, that's not the trouble, I restyled as you say and there's still a space there. Take a look: http://imgur.com/8CVMX6h


This (and the whole ```bool successfully_processed``` thing) is not a good idea since it would now attempt to respect retry delays on "Unavailable" as well.

The case where "wi-fi connected" events are transient will be a dangerous one.

I too don't think it's a blocker for the 1st launch. Just pointing out that's a piece of logic you took out has been here for a reason.


Yea.. it was an over-eager sed script.   I personally think it gives the comments a fun, quirky personality.


See https://github.com/frenetic-lang/ocaml-tdk/pull/6


Why would you want to make the ```OnMessage()``` method private?


Same here.

If you want to hide the interface from implementation, it's probably worth it, but the comment is off.


we can remove this from SimpleMessenger and AsyncMessenger now too


Да, точно, просто я забыл, почему это сделано именно там. Тогда надо это в сам инит засунуть. Но точно не в конструктор `Database`.


changed .gitignore* not makefile


@arjunguha Not sure, but if I understand the comment correctly then there was a bug here.


If you swap the above two lines there would be no need to ```resize()```.


Looking forward to Monday when it returns...


Not true, need an ```if``` or ```enable ? "Enabled" : "Disabled"```.


@sirmordred Nexus devices with CM seem to use it, so it might be useful.


Мы вроде как все еще умеем модели, раскиданные по разным файлам. Правда, чем дальше, тем хуже их поддержка.


inconsistent coding style


This does not fix the conceptual problem. When filepath is encoded with `encodeFilename(path, True)` on python 2 @ Windows it may end up with non existent path (e.g. `Trentemøller - Miss You (Mahmut Orhan Remix)-Y9o7ILCPSFU.m4a` becomes `Trentemoller - Miss You (Mahmut Orhan Remix)-Y9o7ILCPSFU.m4a`, `ø` becomes `o`). And this non-existent path is passed to ffmpeg/ffprobe/whatever.
Possible workarounds are:
1. Encode filepaths with `encodeFilename(path, True)` before writing to disk.
2. Perform all the subprocessing on temporary file with plain ASCII name and rollback to original name right after it's done.
3. Provide compat subprocess implementation that works with unicode.


ok , let me know when you have the fix


need to list address_helper.h in common/Makefile.am so it gets included in the tarball


bekomme unter debian und/oder Arch

root@cubie:/usr/local/src# git clone -b WIP/zille_deint https://github.com/rellla/libvdpau-sunxi.git
Cloning into 'libvdpau-sunxi'...
remote: Counting objects: 387, done.
remote: Compressing objects: 100% (132/132), done.
remote: Total 387 (delta 254), reused 387 (delta 254)
Receiving objects: 100% (387/387), 203.09 KiB | 154 KiB/s, done.
Resolving deltas: 100% (254/254), done.
root@cubie:/usr/local/src# cd libvdpau-sunxi
root@cubie:/usr/local/src/libvdpau-sunxi# make -j3
gcc -MD -MP -MQ device.o -fpic -fvisibility=hidden -pipe -O2 -mfloat-abi=hard -mtune=cortex-a8 -D__ARM_NEON__ -mfpu=neon -march=armv7-a -fPIC -Werror=overloaded-virtual -Wno-parentheses -fsigned-char  -c device.c -o device.o
gcc -MD -MP -MQ presentation_queue.o -fpic -fvisibility=hidden -pipe -O2 -mfloat-abi=hard -mtune=cortex-a8 -D__ARM_NEON__ -mfpu=neon -march=armv7-a -fPIC -Werror=overloaded-virtual -Wno-parentheses -fsigned-char  -c presentation_queue.c -o presentation_queue.o
gcc -MD -MP -MQ surface_output.o -fpic -fvisibility=hidden -pipe -O2 -mfloat-abi=hard -mtune=cortex-a8 -D__ARM_NEON__ -mfpu=neon -march=armv7-a -fPIC -Werror=overloaded-virtual -Wno-parentheses -fsigned-char  -c surface_output.c -o surface_output.o
presentation_queue.c:30:18: fatal error: glib.h: No such file or directory
compilation terminated.
make: *** [presentation_queue.o] Error 1
make: *** Waiting for unfinished jobs....


Short Summary of Contents of my personal web projects and fiddles on github


The `WorldType.Editor` check should be made in the `LoadWidgetAtGameStart` trait.  This is the logic class for loading the ingame player or observer UI, which shouldn't care about the editor.


the msg/xio/*.h shoudl also be listed in msg/Makefile.am


These should all live in Mods.Common.


Да, в `ResultView` я уже не смог подобным образом сделать expand/collapse. Видимо, тут swt немного сломан. `addKeyListener()` норм, в принципе.


Good point. I'm reverting this back to using the stock /exec.


> Maybe we can make a convention that a file starting with underscore is not a test, and use such for support modules...

Sounds ok to me.


grrr... this construct every normal developer uses is supported only since php 5.5. :angry: splitting the line into something like ```$cleanup = $globalParams->get(...); if (!empty($cleanup)) {``` should solve it. That's because on older php versions empty() requires a valiable as param, not a function result - so unlogical that I can't memorize this.


rax retry tests


It would be cleaner to have an EditorMenuLogic class instead of mixing the two and adding WorldType checks here and in LeaveMapLogic.


Если честно, то я сам не знаю, как сделать красиво и для маленького окна, и для огромного, поэтому сделал так. Когда оно висит в углу, то вполне нормально выглядит.


Looks like you've got some redundant code you could wrap up using a function or something.


You forgot to change the date part of the name `2014-12-04`. (Please make it `2015-01-07`)


Line has a typo!


Pedantic coder here! I would prefer that related constants with similar names to all start out the same but vary their suffixes instead of their prefixes. Keep it in mind for future additions. This will be an added suggestion in the Coding Standards topic.


Use `Platform.UnresolvePath` to remove the system path components and keep a manageable path length.

It currently looks like the following on my system:
![screen shot 2015-01-10 at 12 01 40](https://cloud.githubusercontent.com/assets/167819/5688823/b3da07da-98c0-11e4-9683-169fc4c393ac.png)


That's not the proper way to initialize an array, but that way lets me know the array is COMPLETELY empty


random question, what text editor do you use?


Can we use the LazyLoader getJSON definition instead?


Отвечает за то, что для конца и начала паттерна-операции в буфер записывается три или два инта соответственно. Если выносить это в константу, то это будет очень странная константа.
Дальше по коду
```java
 	if(type == PatternType.OPERATION_END)
 		data
 			.putInt(dptIndex.number)
 			.putInt(index.number)
 			.putInt(poolEntry.number);
 	else
		data
			.putInt(index.number)
			.putInt(index.timesExecuted++);
```


This section is making a bunch of hardcoded assumptions, and will need to be cleaned up at some point.


Brackets.


Locks for multithreading?


@pepol I'd rather make this a new sentence ("but those ..")


Otherwise things like the stylesheets were getting included. Need to experiment more, for sure.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/504
success: http://build.servo.org/builders/linux2/builds/502
success: http://build.servo.org/builders/android/builds/540
success: http://build.servo.org/builders/mac1/builds/721
success: http://build.servo.org/builders/mac2/builds/721


Awesome ^_^


It is a common practise named "defensive copying".

ad 1) To determine that two "value" objects are same you should use `==` because identity doesn't matter here. And `$request->getUrl() == $request->getUrl()`.

ad incredibly stupid: calm down. Clone is cheap operation. And premature optimization is the root of all evil.

ad 3) which code?


ever used vim?


@pepol I don't think any of those commas are necessary.


A very useful debug message; line too long though.

(is likely fixed in the ```indent``` commit, just a note from looking through this commit only.)


Hopefully this one won't cause a kernel panic
![derp-faces-17](https://cloud.githubusercontent.com/assets/5847078/5688856/6b93ffda-982a-11e4-9a39-8728e2730150.jpg)


"HEIGHT", I assume.


Yep, I use vi on my VPS. I like the way it's set up on there. I know vim and vi are slightly different though.


This looks pretty true, indeed :)


the docblock is now incorrect


incorrect should be string|null


`</span>`**`</a>`**`</span>`


Useful information should not be deleted.
This info is needed to get it working.


fast-forwarding master to auto = c1d218cf


This should be `MapClassification.System` if it is saved to a system directory.


I'm scared. This at least needs a comment.


when you run `vi`, you're probably actually running vim, unless your computer is from over 20 years ago. Do you use it 'powerfully', or just basic usage?

also, do you have a `~/.vimrc` config file? [here's mine](https://github.com/joshhartigan/dotfiles/blob/arch-linux/.vimrc)


The OSD isn't sensitive to this, and FileStore doesn't take any measures to ensure this is true.  The PG life cycle stuff is pretty well constrained...


Microsoft Visual Studio Ultimate or Microsoft Visual C++ Express, use 2010 or higher.


@joeolenick I was doing some more reading for this and found that this actually will not work! I had a hunch so I did some testing and the single | (pipe) does not work like this you will need to do double pipes.

e.g.
```javascript
if(char.toLowerCase() === 'a' ||
   char.toLowerCase() === 'e' ||
   char.toLowerCase() === 'i'  ||
   char.toLowerCase() === 'o'  ||
   char.toLowerCase() === 'u'  ||
   char.toLowerCase() === 'y'
) {
   // Code to execute if is a vowel.
}
```

I was really excited for it to work but good thing to verify.


I have a .vimrc, let me get it.


This should use the actual filename instead of resetting to the map title every time.


Either I'm missing something or this line will not prepend the buffer with device ID.

If we have a device ID here, we should prepend it.

If we do not, and can not have a device ID here, I'm not even sure these log events are worth sending -- perhaps only their count and types.


r=jdm


ref #203


This will need to be split into a logic class that binds to widgets at some point.


I’m happy to add `Assign` and error on `BinOp("=", …)`, but we need it because we don’t really have a functional core yet, at least not one that works everywhere and generates reasonable code (at the very least, `Let` needs to change to not use a lambda, and so we need to keep track of bindings, handle alpha-conversion, etc. … thanks to JS’s broken scoping).

We can make a ticket to turn JsCore into SlamScript – and I would be happy to work on fixing that. My hesitation there is that I think we should throw it away in favor of PureScript as soon as we can, but that might be a ways off, realistically. It’s just a bit big to fit into the same ticket here.


@Myoldmopar
How's this for unit tests?


yep, the seller of Ramps should tell this :-D


84694650_EnableCodeCoverage (lefticus) - i386-Windows-7-VisualStudio-12: OK (1467 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.7307206068268%25-yellow.svg)


@Myoldmopar
And the rest of them.


A comment on the actual commit.


Nit: space after the `if` (although I never liked that style personally).


What the deuce. I ran the solution against the same www.pp.com site and it works.


They don't. The various sellers of RAMPS boards provide almost no information with them, or less. It's a common enough pitfall to be worth a warning, though maybe it would be better to have it in the comments where that feature is enabled rather than in the readme.


ACK,  looks good all the way down.


can perhaps be further simplified, not sure


Or not. I thought I did, since my vim acts differently on my vps than anywhere else.


oh one other thing i was thinking was maybe instead of leaving /dev/block/mmcblk0p16 unused it could be used as swap and just set priorities on the two swaps so that itll use zram first so that it will work just like normal but will have extra space to use in a really heavy usage scenario. And since it is still internal mem it wont have the side effect of being slow wheres if the user used a sd for swap it would be.(wish their was a easyer way to discuss things like this without using github or filling forum posts)


This seems a bit odd, are you trying to handle things like AUTO:4001 ?


I use it for everything, but not powerfully.


This check will be false-positive, because actually we have group 'conjurers'


# egrep -i "^conjur" /etc/group
conjurers:x:50000:


Aie ! Attention ton fix ne supprime plus les unités si elles sont dans le brouillard.


do you use hjkl or the arrow keys?


Nicely done!


@doadin https://github.com/Harakhti/android_device_samsung_ancora/commit/0459f839aec18273898312a3988e709a23efce40


Arrow keys.


still unsure why the linter doesn't catch that.


As far as I can tell that's not necessary, unless we want all RPMs to have a suffix of some kind?


Should not be copyable.


You should use programming to determine whether or not i is a prime or not within this loop


Anyway this is not the right way to use the group resource. See comment in pivotal

> On Jan 9, 2015, at 6:21 PM, hleb-rubanau <notifications@github.com> wrote:
>
> egrep -i "^conjur" /etc/group
>
> conjurers50000:
>
> —
> Reply to this email directly or view it on GitHub.
>


@ChronoMonochrome  ths actually builds ;) tomorrow I'll try t boot it - dn't want to break my phone for the night ;P


Its really great to see the library for pdfViewer.... Thanks for posting it.
I am trying to use this library, i am done with all the above steps successfully and when i am running the app getting file not found error.

  Intent intent = new Intent(MainActivity.this, ViewPdfInsideApp.class);
  intent.putExtra(PdfViewerActivity.EXTRA_PDFFILENAME, "your file name ");
  startActivity(intent);

 Tried giving  - pdf file from
1. raw folder as  "application/pdfs/demo.pdf"
2. from assets folder - "/asstes/pdfs/demo.pdf"
3. from External file - Environment.getExternalStorageDirectory().getAbsolutePath() + "/PDF/demo.pdf"

but getting error  ST='file 'application/pdfs/demo.pdf' not found'

Please let me know if i need to write any other code.

Thanks


I don't need ur comments


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1090 of 1090 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Just to keep ordering consistant if two classes end up returnign the same priority.


How do u determine that?


Yes, I was thinking we could do this for the sake of consistency

On Jan 9, 2015, at 6:24 PM, Jonathan <notifications@github.com> wrote:

As far as I can tell that's not necessary, unless we want all RPMs to have
a suffix of some kind?

—
Reply to this email directly or view it on GitHub
<https://github.com/rstudio/rstudio/commit/4b6e9a8a94c047e56111e4119c2c2e02c70d67d3#commitcomment-9227042>
.


Why mixing interpolation and format?  Choose one.


try and use hjkl. learning to use vim properly is a super-helpful skill


I'm trying to double check my understanding of the goal here.  The problem is comparing two strings (my assumption here is that `.build` is a build string) like this: `py27_0` and `py27_p0`.  The `p0` is the convention for flagging some as having a special feature (numpy + mlk, for example) and since letters come after numbers when doing comparisons, `p0` would always be considered the latest.  By swapping, we short circuit that comparison to force patched versions that follow the convention to be considered less.

The problem with this logic is that `py33_0` is less than `py34_0`, but this code would invert that comparison.  If that's correct, a generic `conda.packages.Package` shouldn't do this because in a generic sense, the above statement should be false.  This particular logic to remain a part of `conda.resolve.Package` until we can figure out a less opaque way of doing that comparison.


Any chance you could submit a pull request for this?


Really 100%


Do we need to do the same conversion on the ban table as well? It keys off of phone.


r+ rollup


@virgil i've added optionl [\ ] in order to permit spaces

probably a + would be also better as html allows it?


this needs a second argument of the host to bind to (localhost, presumably) -- otherwise it will accept connections on any host


This doesn't look right. This means the tck.spi module will be using a generated manifest rather than the provided one with OSGI info. If this is intentional, you might as well delete the manifest file also as it is no longer being used.


Looks good to me.


It doesn't matter if this or that commit is "final..." Always use descriptive commit messages.

In software development, nothing is ever "final." I recall looking at code I wrote years ago and thinking: "what was I thinking when I wrote this..." Since I didn't leave myself sufficient notes to understand quickly what's going on.

I'm not asking for more detailed notes just for my benefit, but for your benefit. Years from now when you look back at the code, it will be easier for you and anyone else that helps you to quickly grasp how the code worked.


Done: https://github.com/meteor/meteor/commit/e568b223614cbcf812c1208601e03240187084c0


I agree that the comments in Marlin should include information like this, and any other non-obvious things that users should pay attention to for any given option. I've been adding some comments to Configuration.h along these lines in my own fork as part of the Doxygen effort.


Thats a really cool name you have there


Pretty sure you can avoid calling `fs.unlink` and the file will get overwritten by `fs.writeFile`. If not, there's probably a different file writing mode you could use: http://nodejs.org/api/fs.html#fs_fs_open_path_flags_mode_callback


@kevva, I tried using `rc`, and (for some stew-pid reason) `require('rc')('npm')` does not pick the correct config file on Ubuntu. For example:

```javascript
require('rc')('npm')['save-prefix']
```

should return `^`, but instead it returns `undefined` on my system.

However, I have found another package called [`npmconf`](https://www.npmjs.com/package/npmconf), which is entirely focused on npm configs. Here is how I tested it:

```javascript
require('npmconf').load({some:'configs'}, function (er, conf) {console.log(conf.get('save-prefix'))})
```

which returned `^`.

Should we use this? I have prepared a commit for it: aced1c47185b33d294d49eee338dc7741931662a. :sunglasses:

---

PS just found a bug in this diff, `filter` would actually filter the array of setting name, and `result` would end up with the name of the config, which is not our intent. :p


Are you using this function?


Is this for improved error reporting?


It bricks will be removed on cleanup iteration.


I 've alaways had a problem of this lib while compoling vlc and it was the only way (for me) to resolve that issue.


Fixes #2 for for user creation


On Saturday, January 10, 2015, Janusz Majnert <notifications@github.com>
wrote:

> I'm sorry, I haven't been following the manifest spec closely so I might
> have missed the reasons why we can't use solely the manifest URL as the
> app's identity. Any pointers?
>

Because the manifest can live on a different origin (e.g., a CDN) and two
apps can share the same manifest for whatever reason.

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/w3c/manifest/commit/a2e8c31ecda1ca7d5673a02e08698e5cf64b5df2#commitcomment-9219133>
> .
>


mike is testing accepting this file


For what it's worth, that was intentional because as I understand it, dash is similar to bash but with fewer features targeted at interactive usage. So ideal for scripting but less for using interactively. Here's a comparison which seems reasonable: https://www.wikivs.com/wiki/Bash_vs_dash

Though, I really don't care which it is so long as one of them is specified.


See also https://github.com/needim/noty/issues/242


This code is running in the server itself, so I think it would be better to ignore the connection, rather than throwing an error. Throwing an error here means a malicious party could potentially cause the app to crash just by attempting to connect a shell without providing the correct secret key.

Maybe, just to be polite, we could try to send back a reason for disconnecting that could be displayed to the user who ran `meteor shell`. I don't feel strongly about that, though.


On Friday, January 9, 2015, Kenneth Rohde Christiansen <
notifications@github.com> wrote:

> When we handle updates we need to make sure that - while the start_url -
> can change it may not change domain - or similar
>

This is assured by the processing algorithm for start_url, I think. Will
check.

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/w3c/manifest/commit/a2e8c31ecda1ca7d5673a02e08698e5cf64b5df2#commitcomment-9218356>
> .
>


Happy 2015!


Should we be locking down permissions on this file? If this file ends up readable to other users on the machine, then the whole secret key thing is kind of pointless. (presumably the point of the secret key thing is to protect from other users on the same machine, rather than remote users, since remote users shouldn't be able to connect to the shell server when it's bound to localhost?)


this commit linked the incorrect issue, correct issue is #82


My mistake. Still working out Autopkgr and didn't know that I needed to add the repo that contained the pkg.recipe. It works now. Thanks!


Still doing a pass over this, but I want to flag it as very security-sensitive code (cc @n1mmy) in case we have a nascent special code review process for such stuff.


@lcd047 this is actually a bug (at least on go 1.4). the shescape of empty string ends up turning the command run into something like: `go build '' -o /dev/null`. Since the first argument is not a flag (empty string), `go build` interprets `-o` as a package name and barfs, leading to an empty `:Errors` list.

I think you want `opts` to be after the NullOutput call, since `go build`'s CLI parser is pretty strict like that. `go build -o /dev/null ''` works fine, for example.

It _appears_ that `go test` doesn't care, but it would probably be worth keeping parity.

Serves me right for using master, eh? :smile:


I want to make separate and clean native-dependent logic which will simply call ForceUpload method when necessary. It was not the best idea that file queue should handle it on it's own.


Thank you JL! (but I cannot know if it fixes the problem...I guess you know it already)


Why not just switch to sh? It's the only one that literally every Unix user
ever has installed, and its not like we need the extra features.
On Jan 9, 2015 3:43 PM, "mdinger" <notifications@github.com> wrote:

> For what it's worth, that was intentional because as I understand it, dash
> is similar to bash but with fewer features targeted at interactive usage.
> So ideal for scripting but less for using interactively. Here's a
> comparison which seems reasonable:
> https://www.wikivs.com/wiki/Bash_vs_dash
>
> Though, I really don't care which it is so long as one of them is
> specified.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rust-lang/rust-by-example/commit/cfb95581b6ada90ba925c5b51c66a27beb69ef7f#commitcomment-9227260>
> .
>


I'm not convinced we should create an instance in every call...


IMO the main point of the secret key thing is in case of port collision when you run meteor shell in a different app folder that accidentally has the same port number.

Right now, this file (I think) has the same permissions as the socket file had before? Or is there something about how socket files work that protects against other users?


Because it should not be called by any external user code. Passing shit there can break serialization.


Yeah, good point. This error is being displayed on the wrong end.


test


Yes it is! It's in travis
El 10/01/2015 00:46, "MarianoJT88" <notifications@github.com> escribió:

> Thank you JL! (but I cannot know if it fixes the problem...I guess you
> know it already)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jlblancoc/mrpt/commit/d585ec7e345b632ee02c2ff1c16cfc930c0435e3#commitcomment-9227299>
> .
>


rax retry tests


Wish we could just use `files.readFile` :)

In any case, I think you can say `"utf8"` instead of `{encoding: "utf-8"}`.


Why not modifying CFLAGS in this conditional?
Then you wouldn't need the rest of the changes.


Yeah it could allow arbitrary remote code execution if done wrong!


These are internal implementation-only methods, why should users even thing "what if I call it on my own?"


we create instance every time we get Default... I know it is just a port and probably not worth to invest more time in this library


Tempting to make this a JSON file, so that its contents are little easier to understand, but maybe that's not a goal here.


Didn't get it. I want to put id in the beginning, and append file contents after it. What is your implementation?


Note to everyone: this is ***not*** how you resolve merge conflicts.


Yeah, my goal is to move the tool half of the shell into tools/ eventually, then we can use all of the nice utilities there.


Ah good point - probably yes.


Maybe call `reconnect()`, which will print the `"Server unavailable (waiting to reconnect)"` message?


nit: unnecessary line


The idea was to log something only if debug mode is on :) It is not a usual case to change it dynamically in production, and common scenario will be something like
```
#ifdef DEBUG
stats.SetDebugMode(true);
#endif


I don't understand -- if two apps use the same port for the 'meteor shell' server, they won't both be able to run at the same time regardless of the secret key. (That said, I haven't, er, read all the code yet, so I might be missing something.)

It looks like shell.sock (the current socket file) is not writeable by other users, so other users can't send commands to the 'meteor shell' server. If the secret key file is readable by other users, that will allow other users to send commands. So it does seem like it's a change from the current behavior, but not sure if it's a change we actually care about or not.


r+


Done: https://github.com/meteor/meteor/commit/73f865df3b60d23cdab2d5fc7e4a473dec34d37b


Why here? It should correctly call it's destructor and shutdown everything, no?


Yep, indent fixes everything.


Oh, okay. I will try to make this file unreadable, then. And yeah on further inspection it looks like port collision is impossible between two running apps.


wow.


Good point, I simply forgot to append id.


nit: missing space after the annotation


We can change it to JSON later if we want to store more things inside.


Hey Graham, which part exactly? I'm not a docblock expert, happy to fix whatever the issue is.

I used this function for comparison:

https://github.com/laravel/framework/blob/b254bebab0af23e86f9306ee296078575f8580a9/src/Illuminate/Support/Collection.php#L146


4558_hpwh_coil_removing_heat_from_tank (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I'm not convinved this comment is helpful


As noted here: https://github.com/joomla/joomla-cms/pull/5593#issuecomment-69422198

This is not complete but if @brianteeman do a new PR i hope he can fix that together :smile:


The problem with that approach is that we lose control over the data format. Right now everything is under control of the repo and can be changed as needed, like it happened for coderbyheart/ugrm-data#107

Of we were to include data on runtime, it could happen that we can't use the days and would need to ask the author to fix it ... That is even less practical than the current approach.

**But** I already have an idea how to fix this: coderbyheart/ugrm#13


Hmmm, does the NickColourPlugin still work with two of these in its scope (it addsTo the swingUI)?

Might need to fiddle around a bit or annotate them


nit: the comment should be on the next line. not sure why reformatter didn't fix it


We are appending old memory_storage elements with possible new elements. The only issue here can be multithreading (in todo).
However, this is a very uncommon case which I made just to feel safe. In most scenarios, C++ code will generate several events in different constructors and immediately after that native code will initialize storage path.


should we remove this #if and decide if we want to keep randomized hashing or not?


Thanks for the feedback! You are totally right about naming because as I go
back to understand my own code it is kind of hard, and I'm the one who
wrote it! haha. I have always been a bit unclear about when/why to use
private methods can you provide any insight?

On Fri, Jan 9, 2015 at 11:44 AM, Bion Johnson <notifications@github.com>
wrote:

> these three lines do exactly the same thing as lines 36-38. You should
> remove the duplicated logic either with a class (preferable) or at least
> with one or a few private methods.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rkeblitis/ship-to-me/commit/832b13f9fe707ed9f7bcbcbf686a1008698c1db1#commitcomment-9224176>
> .
>


I think either all of them or none should have targetFramework="portable-net45+win"


rax retry tests


I copied and pasted that, we need mozSystem as the remote servers dont have CORS headers, wasnt sure if it was worth adding an optional param to the shared one or just to have a copy here


The master branch should keep a game that works. New features should all have their own branch. The features should then be reviewed and tested to make sure they have no problems before merging them into the master branch


Something like this?


Great!


@ioquatix How is this for handling multiple runner views? Each one is associated to an editor view and each editor view can only have one instance of its script running.


yes


Hey @hhuijser,

These are purposely set to 1.6.

For io-delta if compiled on 1.6 and run on 1.7+ we run into:

```java
{"throwable":"com/liferay/io/delta/ByteChannelReader : Unsupported major.minor version 51.0 (unable to load class com.liferay.io.delta.ByteChannelReader)"}
```


Could you explain the reason to move this line?


rough example of craigslist webscraper


@michaelwehrley @eschlange what does the `$` signify in the variable name `$taskStatusId`?


This might fix #30.


Add video player here


Found BROKEN by linux-matlab.
Here's the log file for step 'testbot update':
```
From github.com:casadi/testbot
 * branch            master     -> FETCH_HEAD
There are no candidates for merging among the refs that you just fetched.
Generally this means that you provided a wildcard refspec which had no
matches on the remote end.

```


whoops, I don't know what I did here, this was unintentionall... I didn't even know I had this file modified!


[CodeMagica/RailsBestPractices] remove unused methods (Spree::FrontendConfiguration#by_number)
reference:


[CodeMagica/RailsBestPractices] remove trailing whitespace
reference: http://rails-bestpractices.com/posts/60-remove-trailing-whitespace


A comment like "used by integration devs to provide a callback function at build time".

I know the commit explain this but a simple comment would make future readers easier.

My 2 cts.


@michaelwehrley @eschlange `while` loops are not idiomatic Ruby. This could be rewritten in one line using `.each` and a range or array.


:crying_cat_face:

(I have never seen this... did you confirm the issue?)


how do you test the game? (lol) I want to try too


FWIW I can verify it's not just Greenway piping out these codes. RelayHealth does too. So this was a :+1: change.


What's the problem where with calling the default constructor? I was putting the initialization of the TGraphErrors there. Should I new the TGraphErrors in every constructor instead?


[CodeMagica/RailsBestPractices] replace instance variable with local variable
reference: http://rails-bestpractices.com/posts/27-replace-instance-variable-with-local-variable


[CodeMagica/RailsBestPractices] simplify render in controllers
reference: http://rails-bestpractices.com/posts/62-simplify-render-in-controllers


It should run with `python main.py`. You're probably missing a couple of libraries to run it though. I'll PM you


Okay, I'll do it later and send another PR.


Fixed in commit #5213d5993246b352c70d32d5f577226f04e7687b


Found BROKEN by full.


@michaelwehrley @eschlange I'm not crazy about the amount of logic in this view template. If we start seeing bugs, I think it should be refactored.


Still some issues with the keyboard interrupt shortcut, will sort out soon


Based on the way JavaScript closures work, you can just use a variable to refer to the `<span>`, so (simple example incoming...)

```js
var $thingy = $('<span>').appendTo(linkSpan);

apiCall.done( function () {
  // can refer to thingy here
  $thingy.text( 'yay!' );
}
```

This avoids having to assign unique ids and all that mess.


This helps... I was having to keep one L5 and one EXODUS branch... due to block based ota by them. I just deleted EXODUS branch and moved it to L5 though... everytime this changes I have to revet this: https://github.com/VanirAOSP/device_lge_g2-common/commit/390411c26afaa4b1c855e5b21bc38b8ce500d9e9 so hopefully this stays. :+1:


I guess I don't have to "new it", I can just put a graph member in instead of a pointer to the graph. I'll fix this tomorrow.


I was assured on IRC that this was the case. I successfully reproduced this on FF 35. And, I have to say, it looks a bit better.


lilojljooijhkiukl;hnhlnj


> Dang, sorry, same exact errors. There must be something on my end that is goofed up.

What happens when you do clone the repository in to a new folder?


sample


[CodeMagica/RailsBestPractices] remove unused methods (ApplicationHelper#redirect_from_root?)
reference:


attached is the associated PNG file.


4660-GLHE_Vertical_Input_Fixes (mmatts) - i386-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Feel free to tweak it. :)


Indeed. I now recall why I just put Android specific code inside the Linux `tuntap_open` - they share most code for the rooted Android case.

I'm thinking about extracting a common `fastd_tuntap_open_linux(const char * dev_name)` shared by both Android and Linux versions of `fastd_tuntap_open`. Does it make sense to you?


This commit lgtm.


What's the matter with the Kriegsbiel?
On Jan 8, 2015 7:31 PM, "anandaguneratne" <notifications@github.com> wrote:

> I say partially fixed because due to inconsistent data formatting (see
> here: #147 <https://github.com/sIKE23/Mage-Wars/issues/147>) the
> Kriegsbiel still does not work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sIKE23/Mage-Wars/commit/59327bbbc188fb0f622760cd355e1eb711be68cc#commitcomment-9212440>
> .
>


Return an error instead of an empty manifest when "manifest" doesn't exist?


It won't work for me, for some reason. Would it be possible for you to make such a change? At the moment, I'm trying it with this method body:

    var linkElement = AFCH.makeLinkElementToPage( 'Special:RandomInCategory/' + pagename, displayTitle, false ),
    	linkText = displayTitle || pagename.replace( /_/g, ' ' ),
    	request = {
    		action: 'query',
    		titles: 'Category:' + pagename,
    		prop: 'categoryinfo'
    	},
    	linkSpan = $( '<span>' ).append( linkElement ),
    	countSpan = $( '<span>' ).appendTo( linkSpan );

    AFCH.api.get( request )
    	.done( function ( data ) {
    		if ( data.query.pages ) {
    			var pageKey = Object.keys( data.query.pages )[ 0 ],
    				pagesCount = data.query.pages[ pageKey ].categoryinfo.pages;
    			AFCH.log( JSON.stringify( data ) + ' ==> ' + pagesCount );
    			countSpan.text( ' (' + pagesCount + ')' );
    		}
    	} );

    return linkSpan;


I think this line is still required here:
`document.activeElement.blur();`


@desaiuditd Let's also add `is_array( $data )` to the beginning of this conditional statement.


should these tests be in a shared example tests?


For lzma support, decompressXWalkLibrary will access private library directory, so we need ensure it is ready before that.


I'm using this ... with no problems...


I suppose this is a good candidate for a regression test because it has parameters and grid spacings and such in weird ranges.  But for now I should look a little more, before fixing a regression.


why ??


I don't get the point of these. Looks like it might be using the setter for side effects...what's the deal?


old_addr also serves as an input parameter for the user, so I think it needs to stay in klp_func.


**FAILURE** - TeamCity Infinispan :: Pull requests monitor [Build 8269](http://ci.infinispan.org/viewLog.html?buildId=22707&buildTypeId=bt9&guest=1) for 0410a0973d96daea42f4a00a11c19d506c64f984
Tests: 11232, 5 failed (5 new), 23 ignored. Build time: 01:53:45

Failed tests detected
* (new) TestSuite: org.infinispan.manager.CacheManagerTest.testCacheManagerRestartReusingConfigurations

* (new) TestSuite: org.infinispan.tx.totalorder.statetransfer.ReplTotalOrderVersionedStateTransferTest.testStateTransfer

* (new) TestSuite: org.infinispan.client.hotrod.near.EvictEagerNearCacheTest.testEvictAfterReachingMax

* (new) org.infinispan.server.test.query.ManualIndexingIT.testManualIndexing

* (new) TestSuite: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave

Error message is logged

Process exited with code 1

Build duration (secs) is too large: 6806


because I provide only one button for the user who lost their patience want to leave.


``T<:QuadExpr`` is equivalent to ``^{S}(::QuadExpr,::S)``


Still u got some typos in the htmls: See the lisT / Crop ProcessinG / Choose IteM


Yeah, but then I have to write ``QuadExpr`` twice...


Thank you, @martint
Comments addressed


thank you so much i find this is great and looking forward to use in my
project

On Sat, Dec 27, 2014 at 3:25 AM, Ruslan Ismagilov <notifications@github.com>
wrote:

> Hi, thanks for review.
>
> You can put any logic with data in DataService in app.js:
>
> https://github.com/isRuslan/angular-shopping-cart/blob/master/src/app/app.js#L71
> There you can load/fetch/get any remote data and bind it into the shop.
>
> Shop object by itself has hardcoded products, so it preferable to
> dynamically load them:
>
> https://github.com/isRuslan/angular-shopping-cart/blob/master/src/app/js/store.js#L12
>
> If you want to work with users, the right way will be create UserService
> where all users-logic (api-request, users methods) will be.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/isRuslan/angular-shopping-cart/commit/1a7e101cae02a222530e9c9442e13b1688ba9b6a#commitcomment-9097249>
> .
>

--
*Thanking You*
*Webonerds Solutions*
                       Busy to build...


Nice to see NDB finally learning what dibi supported 7 years ago.


We now have ambiguity warnings:
```
julia> using JuMP
Warning: New definition
    ^(T<:GenericQuadExpr{Float64,Variable},S) at /home/mlubin/.julia/v0.4/JuMP/src/operators.jl:270
is ambiguous with:
    ^(Any,Integer) at intfuncs.jl:86.
To fix, define
    ^(T<:GenericQuadExpr{Float64,Variable},_<:Integer)
before the new definition.
```


You can also do:

"form-group #{'has-error' unless errors.empty?}"

Not a big fan of using + with strings, unless it's a multiline thing where I have something like output += "more stuff" or something like that.


Maybe just undefine ``^`` since it will fall back to multiplication anyway?


That's weird, I'm not getting any on my build.


In the setters for these, it triggers some actions, but there is a check something like:

```ObjC
- (void)setDiningHouses:(NSArray *)diningHouses
{
    if ([_diningHouses isEqual:diningHouses]) {
        return;
    }
}
```

If the menu items are changed, these are still returning true because the objects have the same in memory address.

My thinking was that if `controllerDidChangeContent` changed, then it should definitely update because something is new.  Another option would be to do something like `setDiningHouses:(NSArray *) withForcedRefresh:(BOOL)`.

Let me know what you think.


This is on 0.3.


I did it in this order on purpose, so that the handler gets unregistered _before_ removing the func from the stack, so that the handler wouldn't be called with no func to redirect to.  But maybe that's not a big deal... If I made your suggested change then I could change the `if (WARN_ON(!func))` in the handler to just `if (!func)` and it should be just fine.  Thoughts?


?
```
/home/mlubin/.julia/__v0.4__/JuMP/src/operators
```


@alexborro Do you mind if I improve the calculations (line 434 - 456) done here.
I am running into a lot of issues with the way this is set up so I have completely disabled this.
Ex:

// Travel limits after homing
#define X_MAX_POS 300
#define X_MIN_POS 0
#define Y_MAX_POS 185
#define Y_MIN_POS 0
#define Z_MAX_POS 190
#define Z_MIN_POS 0

#define LEFT_PROBE_BED_POSITION  55    // (left, front)
#define RIGHT_PROBE_BED_POSITION 220   // (right, front)
#define BACK_PROBE_BED_POSITION  120   // (right, back)
#define FRONT_PROBE_BED_POSITION 25    // (left, back)

Print area: 195mm x 180mm (actual travel area and space, due to restrictions around build platform)
Z Probe X: -27, Y: -60mm
2 Grid Points

Current solution:
(-(X_PROBE_OFFSET_FROM_EXTRUDER * AUTO_BED_LEVELING_GRID_POINTS) >= (RIGHT_PROBE_BED_POSITION - LEFT_PROBE_BED_POSITION)) =
(-(-27 * 2) >= (220 - 55)) = false

((X_PROBE_OFFSET_FROM_EXTRUDER * AUTO_BED_LEVELING_GRID_POINTS) >= (RIGHT_PROBE_BED_POSITION - LEFT_PROBE_BED_POSITION))
((-27 * 2) >= (220 - 55) = false

(-(Y_PROBE_OFFSET_FROM_EXTRUDER * AUTO_BED_LEVELING_GRID_POINTS) >= (BACK_PROBE_BED_POSITION - FRONT_PROBE_BED_POSITION))
(-(-60 * 2) >= (120 - 25) = true = error

((Y_PROBE_OFFSET_FROM_EXTRUDER * AUTO_BED_LEVELING_GRID_POINTS) >= (BACK_PROBE_BED_POSITION - FRONT_PROBE_BED_POSITION))
((-60 * 2) >= (120 - 25) = false

Instead of taking the offset and multiplying by the number of grid points, why not calculate the work area from the set travel limits, take the offset and add to the respective probe position to see if it is out of said area?
Something like the following:
#ifdef AUTO_BED_LEVELING_GRID // Check if Probe_Offset (X or Y) is greater than Max_Length (X or Y)

	#if X_PROBE_OFFSET_FROM_EXTRUDER < 0
		#if ((-X_PROBE_OFFSET_FROM_EXTRUDER) + RIGHT_PROBE_BED_POSITION) >= X_MAX_LENGTH
		#error "The X axis probing range is too large, reduce RIGHT_PROBE_BED_POSITION"
	  #endif
	#else
		#if (X_PROBE_OFFSET_FROM_EXTRUDER + RIGHT_PROBE_BED_POSITION) >= X_MAX_LENGTH
		#error "The X axis probing range is too large, reduce RIGHT_PROBE_BED_POSITION"
	  #endif
	#endif

	#if Y_PROBE_OFFSET_FROM_EXTRUDER < 0
		#if ((-Y_PROBE_OFFSET_FROM_EXTRUDER) + BACK_PROBE_BED_POSITION) >= Y_MAX_LENGTH
		#error "The Y axis probing range is too large, reduce BACK_PROBE_BED_POSITION"
	  #endif
	#else
		#if (Y_PROBE_OFFSET_FROM_EXTRUDER + BACK_PROBE_BED_POSITION) >= Y_MAX_LENGTH
		#error "The Y axis probing range is too large, reduce BACK_PROBE_BED_POSITION"
	  #endif
	#endif

#endif


Oh, I symlink JuMP to v0.4 and v0.3.


Good question. When you think about it... It makes more sense to have the layer.redraw() method accept a parameter to maintain state. Hmmm

I'll do some digging. If I find a sane way for this tool to over come it... I'll post it here. ☺
Thanks @acanimal

Jamie


Shouldn't this say "Error loading %v: %v" ?


Can you explain why?

I know of a theoretical reason this is needed: to prevent the klp_func from being freed.  But in reality I think it's impossible for that to happen, since the ftrace handler runs much more quickly than it would take for patch_disable to complete and patch_unregister to free the klp_func.  But maybe that's not convincing enough :-)


At the time I was thinking it was a jquery wrapped object - which it isn't in hindsight- and I have seen that notation before so I just simply wanted to updated it.  Nothing more than that.


The `id` and `class` attributes of the `<select>` are not needed. Commit aee87f54b9d1df6d86555335253826025e28e4ee removes them.


#ssm


@piscisaureus I accidentally made myself the author when I split the commit. Here's the comment about this: https://github.com/joyent/node/commit/fbff7054a475#commitcomment-8628288


Ok


On these public functions using contID they should probably use the types.UUID type from appc/spec/schema


I can't seem to get this to work. Consistently says Login Failed, without any real indication that the injected did too.


I like it! I'll make the change.


Again, not working here either. I'm missing something.


@jconstanti: És incorrecte i insultant tractar de «dialectes» les llengues de la família nàhuatl.


It looks like resourceid.py never made it into the commit?


сам ты шин -_-


This would be great - it would allow streamlining of the tests that do much the same thing as test (1) - so assuming failure would save time.


Oops hardcoded path


Hi Trent,

I removed all the tabs and comments to ensure all indents were multiples of
four spaces. Git wouldn't push the commits until I removed the file from my
branch.

Steve

On Wed, Jan 7, 2015 at 12:12 AM, Trent Lukaczyk <notifications@github.com>
wrote:

> sorry to be picky, but here too -- four space tabs
> http://stackoverflow.com/a/6338054
> =)
> thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/spendres/SU2/commit/fb111751ab544149bc4cb2f14043cc9fb4f42817#commitcomment-9180096>
> .
>


Specialize this to always put {}'s around `what`, and disallow {}'s in `with`


lose the {}'s after replaceAll is specialized to {} whats


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3078
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3071
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3072
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3063
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3063
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3066
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3059
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3054
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2731
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2729
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1567
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1559


fast-forwarding master to auto = 32545a04


const ( ) ?


Shouldn't these be excluded from the Silverlight and CF builds as well?


saw approval from huonw
at https://github.com/brson/rust/commit/a728b4c9b8936ec63f88a3d8a6e5622e43ee4fc5


merging brson/rust/rustdocwarnings = a728b4c9 into auto


status: {"merge_sha": "20bce44810eb5146f609b4362990ef8835e55bb5"}


brson/rust/rustdocwarnings = a728b4c9 merged ok, testing candidate = 20bce448


well this is currently all constant and could be a static initializer, but if you intend for DefaultIPNet to be dynamically determined in the near future then it makes sense.  How about a TODO noting the intent if so?


r=jdm


Also, this assumes your $GOROOT is writeable without sudo and therefore `gopherjs` writes its files there instead of falling back to $GOPATH. This wasn't the case on my system, so I had to temporary change this to $GOPATH when updating.

This is just for your information.


Again, for your information, I had to `brew install rename`.


@rpayanm looks great awesome

May you replace `Usted desea` with `Desea`


saw approval from jdm
at https://github.com/Manishearth/servo/commit/d444674291ba4d200e7b98f5a7527c983b6307b9


merging Manishearth/servo/android-warn = d4446742 into auto


Manishearth/servo/android-warn = d4446742 merged ok, testing candidate = f4727af6


So this debian/changelog appears to be a replication of the output of some variant of "git log".  Is there some way to generate this file rather than committing it?  BTW, I have committed some of this debianize patch to my codebase, but not all of it.  Also, you may want to use the checkpatch script to check your patches against the style guidelines.  I am more comfortable with patches than merge/pull requests -- seems simpler to me -- but I can convert pull requests to patches so it isn't a big deal.  If you plan to make large changes though, you should look into stacked git so that you can make sane patch sets easily.


some tests failed:
failure: http://build.servo.org/builders/android/builds/524


this was not supposed to be in the commit message gaiz x_X


It has the same formatting inconsistency as the rest of the cards in the set, missing the space between its 2 attacks.


may be or may not.. that is the question!


小伙子不错哦


if this my machine and there is no `@workspaceData` then it will become `null` is it ok?


Okay. I see you've decided to remove the space between the attacks (rather than adding a space in the other files). I'll make the necessary changes to the getAttackBar function.


Correct.


@craigmcnamara Did you mean to say "Test on rbx-2.4.1" in this commit message?


This section should be replaced for something more *meaningful*.


Mind squashing this into the earlier 4.0 commit?


Good!


Can be simplified to `Array(v).each do xxx end`. ;)

```irb
irb(main):012:0> Array([2, 3])
=> [2, 3]
irb(main):013:0> Array(2)
=> [2]
```


可以用 Array#flatten


I should make this clearer in the API.  It is unsafe to access the RequestBodyObject.  This object has not gone through the input validation.  getRequestObject() is the proper method you should call.  If you did call this you would see that "code" is not in it because input validation would have stripped the value.

Please use getRequestObject() and use `io.cattle.platform.util.type.CollectionUtils.toMap(Object)` to turn it into a map in a safe fashion.

To deal with the input validation you need to add a field "code" to the Token.java and then set @io.github.ibuildthecloud.gdapi.annotation.Field(required=true).  Then you need to edit the token-auth.json to set "token.code" : "cr".


Why do you throw and then catch right below?


Input validation framework should handle this, this is uneeded


There were a total of 20 that has the additional spaces, it was the easy
route...
On Jan 8, 2015 10:34 PM, "anandaguneratne" <notifications@github.com> wrote:

> Okay. I see you've decided to remove the space between the attacks (rather
> than adding a space in the other files). I'll make the necessary changes to
> the getAttackBar function.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sIKE23/Mage-Wars/commit/489b76e617f4e16dbea0eed43346988eee2cb6c4#commitcomment-9213569>
> .
>


r=jdm


I think these flickering/flashing/... are different from the DRAWFX ones...

That's why I listed them as a separate bool-section, while the drawfx part are an enum:
https://63ee82fe1e211f830a73a03bc5805789f92048a7.googledrive.com/host/0B-6rsj6uHlolV2ZGMjNQLUZiLXc/objflags_delerium4.txt

Is there any reason you combined them? In fact the flickering/flashing may not seem so misplaced in the old flags value


Use `ranges << xxx` instead of `+=`.

```irb
irb(main):021:0> array = []
=> []
irb(main):022:0> ref_of_array = array
=> []
irb(main):023:0> array += [1]
=> [1]
irb(main):024:0> ref_of_array
=> []
```


Please don't catch `Exception`


Internal unknown errors are not a "ClientVisibileException".  Just throw a Runtime Exception in such a case and the framework will return 500 and properly mask the messages so the user doesn't see internal errors.


Sorry for the noise here.  I accidentally edited this.


We should consider adding a default spec for the inline classes


saw approval from jdm
at https://github.com/Manishearth/servo/commit/1d48e1218c45c428c1f996b21e700a37387e8bba


merging Manishearth/servo/android-warn = 1d48e121 into auto


Manishearth/servo/android-warn = 1d48e121 merged ok, testing candidate = 46d2ee3c


This is now irrelevant since the namespaced fiinders are all happening via Formtastic's 3.1 revision


org.apache.commons.lang3.ObjectUtils.toString(Object) is safer way than casting to a string


Main change is here


Please don't catch Exception


Remove paypal html form and for the future payment button. Instead, get all payment button in db under payment_payment_user_method


More ObjectUtils.toString


I left the r component of polarCoords in here.  I could take it out.  It could be relevant later as r changes a little bit from 0-2Pi.


ONLY A TSET


This seems a bit strange to me - this is the SLD 1.0 XSD definition?


done.


I assume the real error is IOException that should be caught.   Just throw IOException and change all the signatures to `throws IOException`


Now unused because namespaced finders take precedence


I think this is messing up a unit test on IE9: on Travis

IE 9.0.0 (Windows 7) $location location cancellation should listen on click events on href and prevent browser default in html5 mode FAILED
	Expected '$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart$locationChangeStart' to equal '$locationChangeStart'.


Now unused because namespaced finders take precedence with Formtastic 3.1


Is this right?  It seems you are doing milliseconds + seconds.


use directly LOGGER.info


some tests failed:
failure: http://build.servo.org/builders/android/builds/525


r=jdm


From here to L84, superfluous format changes.


OFSpec1.3.4:
The total duration in nanoseconds can be computed as "duration sec × 10の9乗 + duration nsec".

なので、

Time queue has been alive in nanoseconds
は
Time queue has been alive in nanoseconds beyond duration_sec.
ですね。
例えば、今回の場合のキュー生成からの経過時間は
4294963425*10の９乗 + 3912967296
になるとのことです。


saw approval from jdm
at https://github.com/Manishearth/servo/commit/a8326a9138e25e4aa38645a2b83d824443903a18


merging Manishearth/servo/android-warn = a8326a91 into auto


Manishearth/servo/android-warn = a8326a91 merged ok, testing candidate = d9751c0f


awash, turing access cut off


@tomconroy the action layer is something that should be opt-in and NuclearJS shouldn't be prescriptive of how people want to dispatch actions.

At Optimizely we are adopting the idea of a Flux Module which contains the getters, actions and any other functions for a specific domain of the application.  Modules can require other modules and compose getters together to create new getters specific to a certain implementation.

We've found that this abstraction works well since we develop at such large scale with dozens of developers all working out of the codebase.  This level of abstraction and misdirection might not be desired for people writing smaller apps with NuclearJS thus the action layer was taken out.

In my opinion action layer of misdirection is always a good thing, it allows you to create semantic functions that anyone can call and not worry about the implementation of whats going on under the hood or that it's a flux system for that matter.  The other benefit is it allows you to create actions that are composed of other actions, there is nothing wrong with having an action that calls two or more actions from other parts of the system.


Make this class as final, And rename class as TrainingConstant.
Check this http://www.javapractices.com/topic/TopicAction.do?Id=2


This all should go in a spring xml in api-logic project.  I believe AuthDaoImpl is already defined there too.


That;s because I pushed using `git push origin --tags` only, forgot to push with `git push origin`. Fixed now.


他にコメントは有りません。大規模な改造ですが、丁寧に作って頂きありがとうございました。


Better to make all letters capital in final data types for eg
public static string FILE_PATH = "";


What is the use of this arguement fileNameFor here


this is what was causing the duplications, obviously.


@rougeth Sorry, I am not a neovim fun, and now I have switched to Emacs.


oo


you can directly do if (readFromFile){}
and please follow boolean method name convention like it should be preceeding with 'is' or 'has' , or some verb that expect yes/no ansewers


Which environments do `String#replace` not work in?


I don't know. Someone thought it was a good idea around 2005-2006.


@casey-collab


parseInt(Conf['additionalCooldown'], 10)


cbecc-materials-bugs (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


If you are joking about AutismRP then I'll make it.

200+ addons all from leaked coderhire sources and all custom jobs are VIP ONLY

Sent from my iPhone

> On 9 Jan 2015, at 5:56 am, Matthew Nameful <notifications@github.com> wrote:
>
> Really? It is? Oh god, I never knew. Now I can make AutismRP..
> Jokes aside, thank you for the update :)
>
> —
> Reply to this email directly or view it on GitHub.
>


- how to go from Certificate to the x509.Certificate expected by wfe.RA.RevokeCertificate?
- how to verify that the POSTed authentication matches the cert given in the ID? (so we don't validate one message and delete a different cert?)


Delete


1277852-CommandLineInterface (nealkruis) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.80152187698161%25-red.svg)


I am sorry, this is an awful commit message


I can't remember where this crept up, though I do remember the bug...possibly old mobile WebKit? Those browsers would coerce the replacement function to a string. Need to look through my old notes; it's been a while. :smile_cat:


Sure thing, I've been out of the office all week, I'll be back on Monday.


Looks good Andrea.


4660-GLHE_Vertical_Input_Fixes (mmatts) - x86_64-MacOS-10.9-clang: OK (1584 of 1584 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Extra newline at end of file.


I think by using a recursive general call for each sort method we can make it more efficient. As in, first, it checks the first letter of a name, then if there are any that have the same first letter, it checks the second letters of each, and so on, but it could work with numbers as well, by checking the first digit, then second and so on, but with ints it may be less efficient than say with floating points.


There **is** this: https://github.com/bestiejs/maddy/blob/gh-pages/lib/maddy.js#L362-379. :wink:


Looks good to me :).


Misspelt canola oil.


Fixed.


Cause sed erro, I think it should be escaped:
```shell
NGINX_CONFIG="auth_basic \"Restricted\";\nauth_basic_user_file \/app\/\.htpasswd;"
```


@bsaiken : I know i'm a little picky but can you follow the commit comment rule when you have an issue number for a specific task:

`git commit -m "Issue #[IssueId]" -m "Some additional message if you need"` (be as explicit as possible, the last part is not mandatory but appreciated)

https://github.com/FWAJL/FieldWorkAssistantMVC/wiki/4.Use-the-repository-with-Git

Thank you.


@d10 Good spelunking; you know my code better than I do! :wink: If it's just old desktop Safari, then we can drop it...Safari 2.0.3 is about ten years old. I thought for sure there was a mobile browser, too (Nokia, maybe?). Probably not worth the weight either way.


What specifically did I do wrong?

Brian

On 09.01.2015 05:17, FWAJL wrote:
> @bsaiken [1] : I know i'm a little picky but can you follow the commit
> comment rule when you have an issue number for a specific task:
>
> git commit -m "Issue #[IssueId]" -m "Some additional message if you
> need" (be as explicit as possible, the last part is not mandatory but
> appreciated)
>
> https://github.com/FWAJL/FieldWorkAssistantMVC/wiki/4.Use-the-repository-with-Git
> [2]
>
> Thank you.
>
> --
> Reply to this email directly or view it on GitHub [3].
>
> 	*
>
> Links:
> ------
> [1] https://github.com/bsaiken
> [2]
> https://github.com/FWAJL/FieldWorkAssistantMVC/wiki/4.Use-the-repository-with-Git
> [3]
> https://github.com/FWAJL/FieldWorkAssistantMVC/commit/b7070485987c154bb60c7e666bb33dcc78196114#commitcomment-9213807


Nothing big, just adding the issue number in the comment helps linking a commit to an issue automatically.


Related issue: #26


Yeah okay this one is marked version="0.7.2" so we obviously don't care too much about the version number.


What about Rust and Corrode tokens?

//FC

On Thu, Jan 8, 2015 at 10:31 PM, anandaguneratne <notifications@github.com>
wrote:

> It has the same formatting inconsistency as the rest of the cards in the
> set, missing the space between its 2 attacks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sIKE23/Mage-Wars/commit/59327bbbc188fb0f622760cd355e1eb711be68cc#commitcomment-9213552>
> .
>


what happened to the divide by 2.0? Was that something we did wrong perviously?

Oh wait let me guess it get's taken up by the default implementation of getAnchorPointX()


hola que tal ha ido todo?


Nice catch. I think a better solution might be to use a protocol-relative URL: `//fonts.google...`. That way it works both on github.io over HTTPS and on a local dumb static HTTP web server.


I have been including the issue number.  Is my syntax wrong?

On 09.01.2015 05:20, FWAJL wrote:
> Nothing big, just adding the issue number in the comment helps linking
> a commit to an issue automatically.
>
> --
> Reply to this email directly or view it on GitHub [1].
>
> 	*
>
> Links:
> ------
> [1]
> https://github.com/FWAJL/FieldWorkAssistantMVC/commit/b7070485987c154bb60c7e666bb33dcc78196114#commitcomment-9213819


r+ rollup


hello


This commit has nothing to do with PostMark and was an accidental name on my part. This code is working on the calculator.


hello second


Yes, that's fine.


@aino-kunal add custom configuration info


Want you that I reversed all type  (s_IsUpdate == method)?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/490
success: http://build.servo.org/builders/linux2/builds/488
success: http://build.servo.org/builders/android/builds/526
success: http://build.servo.org/builders/mac1/builds/707
success: http://build.servo.org/builders/mac2/builds/707


Nice:)  Is there any way to have App Op button when you go in an app info ?


no need for while.
boolean re;
 re = ( (n & (n-1)) ==0)?true:false;
 return re;

this will be enough


fast-forwarding master to auto = d9751c0f


cbecc-materials-bugs (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2071 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.6526508226691%25-yellow.svg)


Is this idiomatic or is it preferred to return the output in golang?  This looks like C code to me, why supply a pointer to Net{} when LoadNet() could return (*Net, err)?


Post your issue to http://youtrack.sk89q.com/ and also link the output of `/wg report -p`.


This makes sense - yet how/when do we merge to master?


Ok, I checked it out and here's what's going down:

Since our models are doing their correct fancy Core Data things, the arrays ARE in fact equal by the time this check is performed (note that it is using `isEqualToArray`, which is correct because we don't care if the array is the same as long as the contents are the same).

There's 1 or 2 simple solutions here, let's discuss tomorrow and choose one.


SQLAlchemy has reams of documentation on how save/merge work for pretty good reason - basically, you're not "merging" data, you're merging out-of-session data into the session. See the comment on line 42 for how to actually merge data - you load the entry first using db.query, modify it somehow and then save it. If it doesn't exist, you create a new one - either way, they both get saved. This means that this code:

    with db_session() as db: # start a db session
        p = db.query(Pre).filter(Pre.name==formattedPre['name']).first() # find a pre with the current name
        if not p: # if there isn't one...
            p = Pre(**formattedPre) # create a new one
        else:
            p.update(**formattedPre) # otherwise, just merge the new data over the old data
        db.save(p) # then we save it
    db.commit() # don't forget to commit

Effectively handles all cases, unless there's something special you need to do (which you'd handle in the if..then..else).

Note that commits can happen after each entry (slow, but ensures that it saves if a later entry crashes) or after all entries (one problem during processing won't save anything, but much quicker).


:+1: :+1: :+1: :+1:


does the CustomScrollBarUI handle both vertical and horizontal scroll bars?


Are you talking about `ParameterStatus` messages after authentication? Per
[the protocol docs](
http://www.postgresql.org/docs/current/static/protocol-flow.html#PROTOCOL-ASYNC
)?

If so, I agree that we should be emitting server_version_num and I'm
surprised we aren't, that seems like a major oversight. I'll raise it on
-hackers. It looks as simple as adding the `GUC_REPORT` flag to
`server_version_num` in `guc.c`.


This has now been merged into the `5.4` branch as qtproject/qtwebkit@6f6582e0310058efddf0bbda842e5ef67754b124 (with a slightly tweaked commit message).


The naming of this file and the structs is ambiguous, what is a `Net`?  Why is it named `Net` and how does it differ from a `Network` should be self-explanatory in the naming, and that's just not the case.  The ambiguity is reflected in the filenames as well...  can we use more descriptive names?


Ok, Done !!!


Why does an operator need access to my phone number?


How else are you to dial in?

You can easily use a Google voice number.
On Jan 8, 2015 9:51 PM, "Eric Schoffstall" <notifications@github.com> wrote:

> Why does an operator need access to my phone number?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bigboringsystem/bigboringsystem/commit/d9b404786b08577df723928d27790b0fd032e76d#commitcomment-9213950>
> .
>


not need, it doesn't fix the problem.


not needed anymore./


この修正の意図は？


I will take another look, but I had considered writing tests and didn't because there were no existing examples for the similar files in `git.extensions.impl`, otherwise tests would be very simple given this is basically a copy paste of the others.


4660-GLHE_Vertical_Input_Fixes (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1590 of 1590 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@mtwebster Thanks for the heads up on the calculator desklet. I haven't had a chance to work on it for quite a while, and there are several bugs that I know of - it definitely needs some work!