@dkumor.  I'm having trouble with the function I added called "tt_coincidencetimes_nd" which loads the coincidence times into a structure.  The structure is defined on line 108 of ttag.h and the function is called out on line 766 of ttag.h.  The problem appears to be with the TT_WARN macro on line 537 of analysis.c.  When I comment it out, the library compiles fine but when uncommented, I get the following error:
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
gcc -c src/analysis.c -o bin/analysis.c.o -Wall -fPIC
src/analysis.c: In function ‘tt_coincidencetimes_nd’:
src/analysis.c:907:0: error: unterminated argument list invoking macro "TT_WARN"

 ^
src/analysis.c:537:5: error: ‘TT_WARN’ undeclared (first use in this function)
     TT_WARN(tt_datanum(buffer) == 0, return (coincidenceTimes*)calloc(1, sizeof(coincidenceTimes); , "Buffer is empty!");
     ^
src/analysis.c:537:5: note: each undeclared identifier is reported only once for each function it appears in
src/analysis.c:537:5: error: expected ‘;’ at end of input
src/analysis.c:537:5: error: expected declaration or statement at end of input
src/analysis.c:537:5: warning: control reaches end of non-void function [-Wreturn-type]
     TT_WARN(tt_datanum(buffer) == 0, return (coincidenceTimes*)calloc(1, sizeof(coincidenceTimes); , "Buffer is empty!");
     ^
make: *** [bin/analysis.c.o] Error 1
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

I don't think I understand the TT_WARN macro well.  Some places in your code the line is terminated with ";" and other places, where there is an "else" statement on the next line, it is not terminated.


@sfgeorge here is an illustration of how to add `svn` commits to a `git` mirror. The meat is in `git svn rebase` which for safety (in my opinion, however valid) should be done against a `svn_rebase` branch for opening a pull request. This way, the original clone stays clean.

cc @runningferret


Very strange; I do not understand why what worked fine for EitherT doesn't work for ExceptT, but perhaps I need to fiddle with it a bit.


r+


we moved marlin to its own place... this is just a fork that serves as an archive

https://github.com/MarlinFirmware

i have allready added you as collab... you just need to accept the invite


Oops, I should have said second line without `-type d`.
This:

```
find /tmp/ocpu-temp/ -mindepth 1 -mmin +60 -user www-data -empty -exec rmdir {} \; || true
find /tmp/ocpu-www-data/tmp_library/ -mindepth 1 -mmin +1440 -user www-data  -empty -exec rmdir {} \; || true
```

And I assume it would only cause a bug, when no file in `/tmp/ocpu-temp/` has been edited in the last 60 minutes, because otherwise the directory should get that mod date too, right? On my server with this setting it apparently hasn't caused problems, but ocpu-temp gets touched often I suppose.


Actually, the difficulty of this library is probably a pretty strong indictment of the Haskell-style approach of doing error handling in any way other than the way which has been time and again proven to work nicely, which is a proper open sum exception type in the mould of SML. Ornate, type-specific error schemes are a beguiling notion, but rarely do they work well—and to work around them, we are forced to write inelegant libraries like this one...


By the way: did you get a chance to look at https://gist.github.com/larskuhtz/28a945ca50fe1bc955f6? I wonder if the `gfmapLT` function (or something along those lines) could be an alternate basis for the implementation of the operators in this package.

(the gist works only for `either`-style types, but by I think it could be simplified and extended to included `Maybe` and `MaybeT`, too)


@LegionXI/owners @LegionXI/editors
Any new NPC custom changes go into npc_list_custom.sql now.
Notice "transcendental4" got an INSERT instead of a REPLACE. this is because it does not exist in darkstar.
Keep in mind client updates will force you to occasionally update these ID's. That only takes looking at what they are in npc_list.sql and altering this file to match.


You're right, I'm missing something else in there. Will wait for your new push.


@sfgeorge also see the last section of [this article](http://viget.com/extend/effectively-using-git-with-subversion) for another explanation


So is this for writing comment?


Well, right now it gets called on idle and on close.  But maybe it shouldn't ...


Hi Daniel, there are actually 11 parameters for both items you listed (but
I might have miscounted..). The way the parameter descriptors work is kind
of confusing because of the appearance of the ';' as a separator. So the
'L' is the object type that must be followed by a class ID and the
semicolon is the terminator, anything before the L is a separate type
signature. So for example a 'bool, bool, long, string, bool, string'  would
be ZZJLjava.lang.String;ZLjava.lang.String;

On Tue, Jan 6, 2015, 2:48 AM danielweck <notifications@github.com> wrote:

> Sorry @JCCR <https://github.com/JCCR> there is obviously something I am
> missing, I hope you can educate me about this last ZL string parameter, and
> the mismatched number of parameters
>
> 10 string parameters:
>
> https://github.com/readium/readium-sdk/blob/develop/Platform/Android/jni/epub3.cpp#L315
> 11 string parameters:
>
> https://github.com/readium/readium-sdk/blob/develop/Platform/Android/jni/packagejni.cpp#L636
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/readium/readium-sdk/commit/1a48ec8b66a34735a1f52b50065ba2f6a91ceb0e#commitcomment-9166928>
> .
>


Hey, is there update to 1.7.18 possible?


So this is for writing comments regarding the entire code?


Fork everyone.


Yes. The ``assertFailure`` call asserts that it is a ``Failure`` wrapping an ``error.UnauthorizedLogin``.


true?


@nolanlawson Is there anything I can do to prepare a pull request that you'd merge? I could easily make it so that `replicatedDocs.length` will be 3 in the above test. If the `change` event is being triggered separately for every single doc that gets replicated, we could also set `change.doc` instead of `change.docs[]`


Serienjunkies.org will be removed from pyload since it is not supported anymore and broken.


Yes same here, but a user is complaining that his temp dir gets deleted when the server is idle for a while.


I think we should choose a better name to hold the CI environment information. `info` seems a bit too generic.


I see interesting. Yeah it seems like just having onIdle and only calling it on idle would be a little clearer conceptually.


This should probably be part of the CI plugin. I should be able to just use `info.isRelease`.


I think, the package is not about the error type (open sum or something else), but about the monad to wrap and thread the errors through the computation context. In Haskell we simply have to many (sometimes) similar but yet slightly different ways of doing it (`Either`, `EitherT`, `Maybe`, `MaybeT`, `Except`, `ExceptT`, `ErrorT`, `MonadError`, `MonadCatch`, asynchronous exceptions in `IO`, explicit error continuations, etc.).

To me the two, data representation of exceptions and control for propagating them, seem mostly orthorgonal, but I may be missing something here.


Oh yes! As 'Z' stands on its own as boolean (no ';' separator), there are indeed 11 parameters. Thanks! :)
(could the JNI designers have made it more confusing?...)


TOOD -> TODO.  If you're grepping or using the TODO view in IDEA, you'll end up missing this.


Sure just watch my repo. The related issue is https://igniterealtime.org/issues/browse/SMACK-583


Oops, it was meant to be temporary I forgot about renaming it back after
some heavy debugging.

On Tue, Jan 6, 2015, 2:34 AM danielweck <notifications@github.com> wrote:

> @JCCR <https://github.com/JCCR> indeed I see how the renaming could be
> very useful during debugging (because of file/class name collision), but
> shouldn't this change either be (1) temporary, or (2) applied to all other
> homonyms consistently?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/readium/readium-sdk/commit/7d2b0df1906df534ea7da5a2fcf1a2672627583c#commitcomment-9166758>
> .
>


Content seems to be empty


Might want to consider adding `go test -race` as well.


Since name already includes the group symbol, does the server really need to send more information about the user?


Hrm, I'm not sure about this. @6to5/owners thoughts?


See PR #747


zo


Well, the actual complexity arises from trying to support changing the error type; if all errors are in one big type, then mapping between the myriad of different monads that contain them would be trivial.

Incidentally, `MonadThrow` is a really nice thing (but like any other error monad mechanism, you kind of have an all-or-nothing effect, or else you are left with having to write kludges like hoist-error).


I think this should also be part of the plugin (the anding/aggregation of `travisBranch` and `travisPullRequest` into `isMaster`).


@jmhertlein I don't think all changes made it in this commit.


fm

On Tue, Jan 6, 2015 at 7:31 PM, Zyluss <notifications@github.com> wrote:

> zo
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Zyluss/zyluss.github.io/commit/21a3180a30f90545ea58afd18d5ef5818af0f32b#commitcomment-9173099


should be `~4.0` really?


I tested the above on my server and with some toy examples and I think this is right, but probably test it yourself too since I screwed up before.


This is the build.sh that uses only -package


This enables Travis to build the project using containers instead of full VMs.


r=aturon


Consider changing this to be `psql -c "CREATE EXTENSION IF NOT EXISTS postgis;"`


Can you add `envdir /etc/nyc-trees.d/env /opt/app/manage.py loaddata apps/survey/fixtures/blockface.json` below this line?

That will load the (testing) data for the blockfaces.


r+


No... didn't want to do such a change without "approval". :-D


Please, take a look at the demo http://jsfiddle.net/OlegKi/ejpn9/15/. I wrote it today morning, but haven't still the time to test it on IE8 (it's not on my main computer and I have to search for the image). I do another things now. It would be very good if you have IE8 and could test whether the recursion will be stopped in the way.

Thanks
Oleg


I think partly because of this https://github.com/laravel/laravel/commit/203a0c3ba176dba6ddf2e4aecd3648452ca2273c I don't understand why people can't wait till L5 is in beta before throwing their toys out of the cot.


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/3228/console to remedy the problem.


develop (axelstudios) - i386-Windows-7-VisualStudio-12: OK (2173 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.31444241316271%25-yellow.svg)


@myleshorton This changeset implements the idea of using onIdle only when idled.


When I originally set this up it wasn't entirely clear to me that we should be setting this for filesystem which spanned multiple block devices.  At the time nothing else in Linux filesystem stack did this, everything always layered on top of something like md or lvm which presented a single block device.  It was also only used by NFS export so it wasn't critical early on.

That said we should probably revisit this decision.  It looks like btrfs does set this flag and it only really only means that `.s_dev` is set in the super block.  We are setting that these days so I'd expect that setting this flag should just work.  Have you tried enabling it?


@myleshorton This was a bonus of panicking on an empty onIdle. I realized that we weren't closing the inbound connections from CDN on idle.


Need to get myself using some `strlen`, currently I have been using: `for (length=0; *(sentence+length) != '\0'; length++);` which is not ideal.

Maybe for palindrome you need to assign memory on the heap? I did not know what they meant by you cant assume anything about the size of the input sentence. Here is what I put.

```
  //create memory on heap for reversed sentence and compute
  char* reversed = new char[length];
  reverse(sentence,reversed);

  //compare sentence and reversed sentence then delete memort off heap
  isPalindrome = compare(sentence,reversed);
  delete []reversed;
```


@myleshorton Since there's no point to using an idletiming.Conn without an onIdle callback, I panic here.


What exactly do you think is nice about `MonadThrow`?

Do you think that `SomeException` is the closest we can get to an open sum style exception handling? If my understanding is correct, and open sum would still be "closed" statically at link time? `SomeException` remains open since it uses runtime reflection?


Ok !

2015-01-06 14:16 GMT-03:00 fabmarc <notifications@github.com>:

> New comment
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angelobms/AmbulanteV1/commit/2825472153f31c8bc2fb0b0032e1bba1848bdb9d#commitcomment-9171900>
> .
>

--
Atenciosamente*, *
_________________________________
*Angelo Brandão Miranda Santos*
Analista de Sistemas
Skype: angelobms /
angelobms@outlook.com <angelo-brandao@hotmail.com>
Twitter: @angelobms
Tel.: +55 71 8808-3676 (Oi)

"Que ninguém se engane, só se consegue a simplicidade através de muito
trabalho." Clarice Lispector


Thanks @rlinehan, that sounds good to me.  Maybe call the method 'description'?  Since it's not always a URI?  Don't care too much about the name, personally, but my vote is for avoiding to_s.


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3038
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3032
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3033
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3024
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3024
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3027
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3020
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3015
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2692
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2690
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1528
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1520


fast-forwarding master to auto = 6539cb41


I commented on #464 about this, but breaking 1.8.7 compatibility in a 2.x release will be a SemVer violation, so unless you're planning on the next release being VCR 3.0, or you've decided against maintaining SemVer or you have some other way to ensure you don't break 1.8.7 compatibility...this seems like an unwise change, IMO.


r+ p=1


Nice!


Huh.  Yeah, I think that's a typo left over from an earlier approach that was scrapped.


You scoped guess, but you left answer in the global scope.

```
var guess, answer;
```


Not CI testing it isn't breaking compatibility.


This one also fails to load from the SD card


Awesome! At least I know what to expect now. Setting up a server this week!

(Then there is no problem running RGBA ;) )


I like it!


I have the same username on Github :D


Since this can have 3 different values, it's not just a flag that indicates if the text field is multiline anymore, so we should rename it and update the doc. Something like `type` would be best now.


Generally people use === instead of == in JS. It's a common interview question to ask what the difference between =, == and === is in javascript. So it's probably worth looking up at some point.


r+


GOOD JOB. YOU RULE!


Great. If updating your codebase, please make sure to consider the [migration instructions for 0.9.0](https://github.com/DemocracyOS/app/wiki/Migrating-to-0.9.0)


Sorry, guys. We do not maintain this gem anymore. It is way outdated.
Plz try out another one: https://github.com/rightscale/right_aws_api


I don't like this use of exceptions for flow control, since it's not explicit about what is expected.  Is this a ValueError?  IOError?  I can figure it out with close reading but it's not ideal.  It seems like you can just dedupe the unique pairs of (category, mimeType) by doing list(set(fileMimes))


saw approval from nick29581
at https://github.com/cmr/rust/commit/522a9ccebac5de4861fda04fb48fd9e12af7dbe7


FWIW on my iPad that demo grid gradually gets wider over time.


merging cmr/rust/mem = 522a9cce into auto


status: {"merge_sha": "d361ba2ba85eab8ed677b9578fa79ef8a882fd3a"}


cmr/rust/mem = 522a9cce merged ok, testing candidate = d361ba2b


Prefer to name this:

   category = ...


Why was _INDICATORS removed?


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


nooo, definitely not. if you see my previous revision on the left, I had commented out that whole section and just returned a "we can't do this error", but I thought a-u should handle the general case where some app has approval, rather than the specific Bridgy case.


80757414-AddAutoSizing (Myoldmopar) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.0503144654088%25-red.svg)


Ok, I understand the point with result tables.
In my understanding, the current code compute a unique id per query using the computer time as an initializer of the ids sequence, and then increment the id by one for each query. It's a reasonable way of avoiding collision assuming:
- query frequency is lower than time precision
- AND Qserv doesn't restart,
if this both conditions are met, then some ids will be duplicated.
Furthermore, current strategy doesn't prevent id collisions for more than one year.

This problem is not trivial and that's why the current strategy with time in milliseconds as an initializer seems reasonable.

Two other strategies are do-able quickly:
- use random id for each query, here collisions are still possible (probability isn't even 0 as integer are coded on 64 bits).
- use random number as an initializer and then increment id by one for each query, here collisions are possible only if Qserv restart.

An other solution is to have id in an infinite set (like a string), and then increment the maximum previous id by one at each Qserv restart, this seems safer as it prevents all collisions, but might require a new ticket.

Would you have a preference for one of these strategies or do we stick with the current one?


Looking at the hexadecimal, it appears load.applescript is already UTF-8 encoded?


You're right. How about `=>` instead?


Could you please pull this commit to the master if is fully tested.
Thanks


Судя по прилеганию малой шестерни, все считается правильно.
![ecc_cycl](https://cloud.githubusercontent.com/assets/5071282/5634028/87d066d2-95ed-11e4-9a02-74dc217cb91c.png)


That won't work because in line 372 it is only called for /proc/stb/power/vfd:
https://github.com/openatv/enigma2/blob/ed879848f8d19bf8d88d07b35ee1bb997cca2e09/lib/python/Components/Lcd.py#L372

I only know Xtrend boxes which support this. Do other boxes with /proc/stb/lcd/vfd exist?


Nevermind, it was a duplicate.


I set rar_malloc(length)  (so allocating NO extra).  When I re-ran, here is what happened, no crash, and same items listed. I 'enhanced' the debugging output a bit, and here it is:

Bert$ErnIE       (u3-rar)
Bert$ErnIE       (u3-rar)
rarvm_getbits() out of data: offset 2 with 1 in buffer
rarvm_getbits() out of data: offset 2 with 1 in buffer
rarvm_getbits() out of data: offset 3 with 1 in buffer
rarvm_getbits() out of data: offset 4 with 1 in buffer
rarvm_getbits() out of data: offset 5 with 1 in buffer
Bert$ErnIE       (u3-rar3hp)
Bert$ErnIE       (u3-rar3hp)


Feel free to ignore this (I'm glad you're making VCR you're own and not simply sticking with the build stuff I had set up!), but I thought I'd share the reasons I find the 100% doc check so valuable:

* Actually following SemVer (and not simply claiming to do so) requires that you have an explicit public API.  That public API needs to be documented some how.  While having 100% doc coverage doesn't ensure the docs are good it does prevent you from forgetting to either label something `@private` or document it as public.  In this way, it forces you to make an explicit decision about every new class/method/etc which, IMO, is a very good thing.
* It's surprisingly easy to have doc comments that aren't actually picked up by YARD doc (or whatever doc tool you use) properly, meaning you can put effort into documenting something and then have it not show up on the rendered docs.  [Here's one example](https://github.com/rspec/rspec-core/commit/a5d9b01baae5e1d9f6a3509cabe526ede9db23ba) in RSpec that we only caught because of having a 100% doc check like this.

I'm a fan of automating as many useful code checks as you can, so I personally like having this...but as I said, please feel free to ignore this suggestion :).


Yes, I think that `SomeException` is the closest thing to a proper exception type. It is open, in the sense that it is existential; (I am thinking about semantics, I have no idea what link time has to do with that).

The implementation of the exceptions w/ runtime reflection is of course unfortunate, but that's how they had to do it since they didn't design exception handling properly from the start.


初投稿です。
環境依存にはなりますが、以下のようにして、クライアントのローカルタイムを
書き込んだ時間として割り当てるのはどうでしょうか。

```
/* 47行目 （動作未確認） */
	function getLocaldate(){
		DD = new Date();

		year = DD.getFullYear();
		mon = DD.getMonth() + 1;
		dates = DD.getDate();
		hour = DD.getHours();
		min = DD.getMinutes();
		sec = DD.getSeconds();
		document.write(year, "-", mon, "-", dates, " ", hour, ":", min, ":", sec);
	};

    function addMessage(message, date){
      $("#dummy").after('<tr><td>' + getLocalDate() + '</td>' + '<td>' + message + '</td></tr>');
    };
```


@XhmikosR ah, sorry, totally forgot to tag. Yes I'll sort that, just at my daughters recital but will do when I get home!


saw approval from huon
at https://github.com/nick29581/rust/commit/b2f46c5f2ccec689f2133711e913bd809c28b1c4


merging nick29581/rust/arrays-3 = b2f46c5f into auto


Hmm, is it wise to create a new version of the standard library but leave out fixes to obvious errors? Like https://github.com/elm-lang/core/issues/65, which I fixed in https://github.com/elm-lang/core/pull/74.


merging nick29581/rust/arrays-3 = b2f46c5f into auto failed


Doesn't this require the modules to be installed globally?  I was trying to explicitly not require that.


I know this is LIS and it's just for Linux stuffs, but if at one point you're going to test Windows guest OS, there will have to be some changes:
    vm_time = self.remote_client.get_vm_time()
    ...

But if won't ever be the case, ignore this comment. :)


Wasn't this default going to be removed?


Awesome, I sign off on this PR


rewrite


I like the idea of a page having some description of collabs..
Actually almost all of us don't even know each other.

It would be nice to have the names of each one, country, job, etc.. just a
brief description.

Cheers.

Alex.

2015-01-06 16:22 GMT-02:00 Bo Herrmannsen <notifications@github.com>:

> we moved marlin to its own place... this is just a fork that serves as an
> archive
>
> https://github.com/MarlinFirmware
>
> i have allready added you as collab... you just need to accept the invite
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ErikZalm/Marlin/commit/c48eaf3c6b308112e5afff5309cc08a67d9f2b80#commitcomment-9172973>
> .
>

--
*"Não é o mais forte da espécie que sobrevive, nem o mais inteligente. É
aquele que se adapta melhor as mudanças"  ( Charles Darwin )*

Alex Borro


> Not CI testing it isn't breaking compatibility.

I agree, but dropping it from CI means you're CI tool won't notify you when you do break compatibility.  My experience is that it's really, really hard to maintain 1.8.7 compatibility if you don't have a CI tool telling you when you break it.  There are many, many subtle changes between 1.8.7 and 1.9+ so even if you know about the differences, you're still likely to break compatibility.  I'd estimate that about 25% of my RSpec PRs fail on 1.8.7 initially.  YMMV, of course.


https://docs.npmjs.com/misc/scripts#path

> If you depend on modules that define executable scripts, like test suites, then those executables will be added to the PATH for executing the scripts.


Can you verify that if `opts` is null here, this still works?


Here you're looking for response.status not response.statusCode

statusCode is a function and you display its body when you do console.log(). This is why you're seeing that JS code in the console.


@dg Would you welcome a pull request which makes Url completely immutable (returning clone object)? I could prepare one...


Thank you! This commit fixed the build. It was broken since http://ci.cgeo.org/job/c-geo/3228/


@mariapaola5 results on output/tables/table_retraite.csv


I'm in two minds about this one. On the one hand I'm not really sure whether the fix is good, on the other hand it's seems fairly clear to me that because this fix works that the 'check its the same' logic is actually broken.


Thanks!


Doesn't seem to be working properly at the moment (https://robotgame.net/user/3937)


I've got [no problem keeping to SEMVER](https://rubygems.org/gems/shogun), but I had never considered using doc tokens as a way of definining public/private API. If that's a common enough use I'm willing to bet I can build a service for tracking public/private api changes.


Pull request is easy, compatibility is hard…


Why do you reload the page? Simply transitioning to the login page should be fine.


Consider yourself "Approved" :-D

Do we also want to get rid of the two instances of this setting in "Movies" and "TV Shows" as well?


Looks good! It's equivalent to what I've said.


I much prefer the other way of extending the prototype over this; I find it more readable and coherent.  I understand it's a style thing and it was the only remaining use of lodash, but if you can use `assign(CacheSwap.prototype, {..}) here in the same way `_.extend` was used, I will be happy to merge this.


hmm.... can we do that so it stays permanent when we click on our handle in git?


Thanks Jean-André. It's working like you said. Everything ok!!


Hah,  just found that one too


I'm really looking forward to getting this running. I'm hoping this paves the way for a new party in my country...


You can certainly use another method to state what the public API is, but I think if you do you should explicitly say what that is in VCR's README.  Otherwise users will not know how to tell if something is part of the library's public API and subject to semver.


It works even if `opts` is `null`, `false` or `undefined`. They are regarded as `{}` here.

https://github.com/sindresorhus/object-assign/blob/4cd0365f5a78dd369473ca0bbd31f7b234148c42/index.js#L18

```js
Object(null); //=> {}
Object(false); //=> {}
Object(undefined); //=> {}
```


Hi, thanks for participating.

Please cut your changes in atomic commits, it's really hard to understand witch change comes with witch change.

I just released a completely new rewriting of code, you really should update your local git repo and check if this version is good enouth for your use.

Thanks, and sorry for the [long] response delay !


Does this change potentially break anything?


Hi Valentin, Sorry could you change this line, too?

https://github.com/dmwm/WMCore/pull/5554/files#diff-b867f72f7a57b63b7b534415ee52280fR206
https://github.com/dmwm/WMCore/pull/5554/files#diff-b867f72f7a57b63b7b534415ee52280fR214


That should be included...


Why did this line get left in?


Why full resolution?


Thanks


I do not know what you mean. Show your code ;)


hmm so far i can only see that we can set our location on git...


I think all this new code needs some tests.


@ianwalter

I'm afraid to say that what you did is sugar-coat what you ultimately wanted to achieve in the first place: Being able to call `nsPopoverProvider.getDefaults()` (or `nsPopover.getDefaults()` if you want) in a convenient manner.

I'm not interested in dragging this any longer, I'll leave @nohros to decide whether this is a good way for providers.


Added in https://github.com/azavea/nyc-trees/commit/1f7b68e2be9031554a190afc0f597dd217893e2d.


Fixed in https://github.com/azavea/nyc-trees/commit/dd12dd18ff0401adc2c52bca23a073c6335618d7.


Hm, so basically, if the command will fail, the assertion will be false, and the test stops.

Maybe this part can be done in the wsman client class, and instead of asserting, raise an exception instead. It looks like a useful thing to have in the future, in case you will want to check the return value of your scripts, like you do here.

So, I suggest something like this in the wsman client:

def run_checked_wsman_cmd(self, cmd, other_params, blabla, return_value=0, ...):
      s_out, s_err, return_code = self.run_wsman_cmd(cmd)
      if return_code != return_value:
           raise someException("Command execution failed with code %(code)s:\n"
                                             "Command: %(cmd)s\n"
                                             "Output: %(output)s\n"
                                             "Error: %(error)s" % {...})


David - I think it is the case that we want some .c9 files tracked, but not others. Is that wrong? (I will look later today).


Thank you !


Hey, why there is runtime dependency in rack-test?


operator error


Sure. I removed it from the pull request.


We learned that today actually! = - assigned == -equal w/o type === -
exactly equal to.... right? I can do === because the guess and the var are
strings right? I'll look at the scope thing.

On Tue, Jan 6, 2015 at 10:45 AM, Nathan Sass <notifications@github.com>
wrote:

> GOOD JOB. YOU RULE!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/katiereid/Guessing_Game/commit/45b18bf2111e63ee966ba97714d74034ae4b5968#commitcomment-9173341>
> .
>


This needs fixing in the french language file too.


oh oh oh! sorry, I did run the tests, but this is not being linted :o:


C# is a compiled language, so the module references are all checked at compile time.

Python is an interpreted language, and wildcard imports do not work well for tools like pylint and pyflakes which are commonly used to check for problems.


create an issue and tell about ourselfes... it can be locked so only we can add to it?


I will send a PR for that in a bit :-)


Why were these two lines commented out?  Without them, the json-fortran stuff does not get installed *and* the dependencies are not correctly resolved.


I thought first it was clearer since they serve slightly different purposes but you are right that is not worth.  I removed it.


True, the good thing is we can drop the files in CrowdIn and have it done :)


With link time I mean that for a "static" open sum it could be checked at link time that, for instance, all cases are covered by an exception handler. For `SomeException` that is not possible.


Addresses #13.


"And environments" feels a little enterprisey. Otherwise I generally like the more generic statement.


It’s inferred from `++`’s return type. `map {…} ?? right` has to return a `Stream<T>`, so `map` has to return a `Stream<T>`, so `.cons()` is inferred to belong to `Stream<T>`.


![localhost 4000 2015-01-07 04-03-29](https://cloud.githubusercontent.com/assets/4990822/5634332/2cbbdec2-9622-11e4-8d82-380073b27295.png)

`document.write()`するとおかしくなったので`return`で返すことにしました。
今コード書いてます。


We need it persisting to the languages files immediately. As I said, we cannot allow commits into cachet unless the translations are upto date. You agreed, then you pushed this anyway?


r- failing a test locally, will push a fix shortly


*prerequisites


A counter per Qserv instance, kept centrally and persistent over restarts, is one alternative, but it could have performance problems with multiple czars.  A counter per czar, still persistent, along with a czar identifier, would be better.  Another could be a hash of the query; with anywhere from 160 to 512 bits, collisions should be negligible.  I don't know if that would make the table name too long.


maybe the e_code will be also be useful. Also, specifying something like: "Error message: %s", "Output: %s" etc. instead would be more clear when you check the logs.

Also, the first element in the tuple should be in the string:

    assert_msg = 'Failed to get host time.\n%s\n%s' % ...

Also, I don't thing str(something) is useful, since you specify %s in the string, which will stringify it anyways.


I changed to `undefined` for readability, `void 0` is much faster in browsers like IE10 which was the original reason.


Higher-order reducibles have to call the function returned from `reducible.reducer()` in their own returned function, and ergo it is called multiple times.


I don't think sanitizing belongs in this class anyway. Better to wrap your request object in a decorator perhaps?


It shouldn't -- overlap now knows a symbol is not a sequence, so the type is no longer *exactly* Boolean when it know the argument was 'foo (it was a more specific type).


:cake: :D


It's only been re-worded slightly. I can't speak/write French so I'm unable to immediately update, but I was going to push it to CrowdIn.


It’s been a while and I was on vacation when this happened, so it may have been invalidated more recently. At any rate, you can feel free to try dropping a level of indirection and see how it goes.


All this information can be pulled from http://jd.bukkit.org/rb/apidocs/org/bukkit/plugin/PluginDescriptionFile.html rather than hardcoded. It keeps changes contained to multiple files.


Okay I rescind the part of my previous comment where I said I was unable to identify the case where the user query falls after the last item. I have corrected a typo and now that works. I'm still a little mystified by this reported count, though. I feel like I must be missing something.


Stay strong, dynerthebardy


np, thanks for the kick!


@sonamtobgay Please ask on the forums, and as @barryvdh said, ensure you're using the correct file extension. And actually, make sure you are actually using the view component to render the file and are not manually requiring it - that would be a bad idea.


me gusta
Se ve bien .


`\s*` should be `\\s-*`, and it probably should go after `\\|`, since matching `^` after one or more repetitions it will be impossible.


I think a doc string specifying the objective of these tests and their steps would be useful.


Actually spun this up in 15 mins...
Which reinstates the {{varName|slug}} filter, we can add others as we identify the need

https://github.com/madeofpeople/metalsmith-swig-helpers

tested and confirmed working
just add it in metalsmith.json just before your template call.

I'll do a pullrequest.

```
    "metalsmith-swig-helpers": {},
    "metalsmith-templates": {
      "engine": "swig"
    }
```


By the way, I'm pretty sure there's no international checkbox on the at-door registration form.


Just to check what is going on here:)


not pep8 compliant. run pep8 and pylint before commits, to make sure you don't introduce more stuff for pep8 and pylint to complain about.

(imports should be ordered).


oh, sorry, I'm not sure why those got commented out.  I must have installed json-fortran once and never noticed it not getting reinstalled here.


@844196
\>4:3:82015-1-7
![1360069667491](https://cloud.githubusercontent.com/assets/9349287/5634477/3fa6f052-9623-11e4-9c8f-3e9715a85d96.jpg)


Anyway, I've pushed the new language file revisions to CrowdIn, let's see what we get.


"don't discuss the matter publicly" sounds bad. Discussing information that is already public does not violate the privacy. Open company means we need to support open discussion, no?


I thought that we shouldn't be pushing if there isn't an `en` translation?


Thanks for the heads up. Fixed it.


typo - recibe should be recipe


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.94803548795944%25-red.svg)


i: and f: is not really clear. Use image and flava' instead. :P


My bad, emacs regexps are tricky :)


I thought there were fewer cases of Pair/List updates punting after this change when running the TR test suite, so I left it.


Should we use numbers in method names, or `Two`?


Really if people are expecting their argument to be a String they should try the to_s on it before griping.  IMO


Why is it wrong ?


it looks like this line is causing an ArrayIndexOutOfBoundsException when you use a 'from' value after the last item in the browse index (i.e. results size is 0)


use % instead of string.format

Not really an issue, but it's preferable.


Why spaces? Tabs would look much prettier.


Okee doke.  I'll fix it along with the branch I am working on this afternoon.


I don't like it either, the only thing is the evaluation on current step with JS I'll have to map the one => 1


I'd prefer to not embed this inside magic.py itself, it should be in another module.


![screenshot from 2015-01-07 00 44 28](https://cloud.githubusercontent.com/assets/9139390/5634520/624c02fe-9606-11e4-8292-7e569758896c.png)

This test compiles but crashes on executing.


That's why I did not resolve it but I was wondering what about in case of a permalink...


"Please review this, @casey-collab"


> I thought that we shouldn't be pushing if there isn't an en translation?

But there would always be an en version...


Looks good to me. Good job - you cleaned it up :+1:


A simple edit was made to a comment on the first line to test branching and merging.


I think this is reasonable, but I'd prefer to not embed a bunch of semi-volatile data inside magic.py.  If you want to pursue this can you:

 - rename util -> contrib (more conventional)
 - move the generated map into a standalone file inside contrib
 - See other inline comments.

Thanks!


@noordawod Not true.

Your own example shows that a method intended to be used in an angular apps config block is added to `this`. The $get method returns whats injected when the provider is used elsewhere in the app (in our case the directive). In the example, they use the setter for error messages in the config block and a getter in the injected object (although they don't show it being used). Since we're using the same method for getting and setting, $get returns `this`, however it might be more intuitive to simply revert the code as it was before (which I'm sorry to have removed).


Hi! I've just tried Laravel 5 yesterday.. I am a newbie here..
It just suddenly happen but.. I'm experiencing that views with blade templating are not being rendered unlike before this commit it was working fine though. So I'm guessing my issue might be related here?

If it is, Laravel 5 is still in alpha, cant be helped with such issues.. :-)
But right now I really dont know what's causing it. I just updated hours after this commit.


I'm not sure this is the proper place for initializing the win_client. It should be in the tests.


Why else would I be talking about a backlog where changes aren't persisted to all files?


Some of the boiler-plate from the hash_or_legacy_array can go.


Keys removed.


We obviously had our wires crossed. My understanding was that we shouldn't be pushing code which had text in a view, but **at least** had it in `en`. The problem we'll have by keeping other languages updated at the same time is that it'll slow down fixes and stuff, by having to wait for a translation.

Remember that any non-existent translation will fallback to `en` for us - which isn't ideal, but it's at least something rather than `cachet.support_link` or whatever.


@swistaczek: It's used by the provided application testing libraries.


7? Seconds?

Don't use magic values. Define something like _TIME_STUFF_STUFF and use self._TIME_STUFF_STUFF instead of 7.


ditto.


Will it find the library if you run with the environment LD_LIBRARY_PATH=`brew --prefix`?


I'm saying we need to keep the other files updated even if we use a placeholder translation.


Apart from the fact it sounds silly, but fine


Yeah that's a good point about palindrome. For questions similar to this I have just been putting a large integer as the length of these temporary arrays.


Prototype WIP:

* Hide all important note history from the main audit trail
* Provide an important note revision table behind a toggle if more than one edit
* Make the note itself red again, remove header
* Indicate that user is last modified, not necessarily author

![important-notes-prototype](https://cloud.githubusercontent.com/assets/319055/5634622/382c501e-95d9-11e4-8835-7ec9808380dd.gif)


But how can someone who only speaks English update a French translation? You'd have to upload to CrowdIn, wait for the translation then merge it back?


This was a while ago, but I believe the problem was in using JSON.stringify on the JXONNode, leading to "TypeError: JSON.stringify got a cyclic data structure".  I didn't need to access parent nodes from child nodes, so the easiest solution was to suppress that line.

There may have been other problems (though probably nothing to do with GC) -- I wasn't using this in a browser, but in an embedded script in Java 8's Nashorn JS interpreter.  I wanted to expose JXON's string-parsing functionality to script writers, hence the addition of the "parse" function to the module's exports.


The intention is thar it sounds Zombie-esque. Something a zombie would say.

> On Jan 6, 2015, at 11:21 AM, Arona Jones <notifications@github.com> wrote:
>
> Apart from the fact it sounds silly, but fine
>
> —
> Reply to this email directly or view it on GitHub.
>


Just curious, why did you put this check in the `mocks` package instead of where the interface is defined in the `fleet` package?


Right.  I will check — I used the fact that it was converted to an `Uri.t` without checking the doc.  If it should not, I'll leave it as a string.


:+1: for the GIF (we should totally do these more often)


Doesn't matter whether the compilers do, we should do this anyway because it's the right way to do things, which is why it's present in node.


Ok :)


Is there some benefit to this?


@mrmateo  should we add this to the 1.1.x branch as well? I think so. I can take care of that if you agree.


Great, It Works!
Thank you for this fast commit

But when I chose the .torrent file, it doesn't appear in the input cell, it remains empty.
Then, if I click on the "add torrent" button, it work, but it is disturbing...

Is it possible that the action of the button "browse" refers directly to the input "add_torrent_url" instead of using the field "add_torrent_file" ? (to bring up the file path in the input)

This way:
onclick="$('#add_torrent_url').click();"


@millerw8 do you think this should be included in the 1.1.x branch as well? I can take care of that if you agree.


I see. Thanks.


I meant update it just duplicating the english. So that the file formatting and order remains identical in all files.


I approve this change


Autsch :-)


Normally I do more of a formal thing, but the block is gross enough to constitute a better desc than something formal :P

> On Jan 6, 2015, at 11:24 AM, Arona Jones <notifications@github.com> wrote:
>
> Ok :)
>
> —
> Reply to this email directly or view it on GitHub.
>


Is there a benefit from splitting up the line?


Laravel 5 will actually be released in beta very shortly.


Maybe a little nitpicky, but is `class Registry < Krikri::Registry; end` more clear?

@AudreyAltman, @anarchivist do either of these read easier for you?


Right, so if I update the English file, then I can copy the whole language string to French - even though it's the English phrase?


Argument accepted and agreed with :D


PR with backport please. Nice find.


Feel free to. It was just a feature add-on.


Sure - we could use ```AdminPrefsManager``` to hold and access all these values.


Did this cause an error?  It's the same as defining uriStr?


Как используется такая конструкция и чем её заменить знаешь? Если нет, погугли, будет полезно


Either way is fine with me, but I was going by something I saw in the bbatsov style guide:  https://github.com/bbatsov/ruby-style-guide#single-line-classes


Не очень красиво, стоит вынести в хелпер


Is a 0.6 release around the corner then?


Yes I'm really excited about it.
And I found the problem with my issue.. It was clearly my fault....

Cant wait for Laravel 5 to release!


Yeh. The main reason I suggest this is so that if the files are refactored like they were before, we MUST persist the changes, including new comments, and movement between files.


That settles it, as far as I'm concerned.


This is easier if the files are always totally uptodate, even if they're not 100% translated.


FixWindowsSQLiteBuild (lefticus) - i386-Windows-7-VisualStudio-12: OK (1582 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ok, that makes sense. I'll update the French file now.


Can we use this prima driver with titan ?
The current have some bugs while searching new wifi ( display 3 and then after 15 display the others )


Thanks, done

Here is the updated clean commit:

https://github.com/MaMazav/pdf.js/compare/J2k_Partial_region_decoding


Done.


Auto-Gif was overriding spoilers.


I'm worried about this not being done in the new code.  We ran into this problem specifically in a CentOS environment; the OS didn't allow writes on new directories unless we explicitly chmod'd after creation.

I'm tempted to go ahead with your changes and revert if a bug is filed.


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3033
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3039
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3034
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3025
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3016
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2691
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1529


On second thought, that definitely should be a bug with `mkdirp` and not our problem, so I'll go ahead with this.


Looks good - must have left forgotten to change that back to the local server :-).

Thanks!


@akre54 Sure thing, I'll take a look now.


Shouldn't this be?

```
score.to_f > Settings.GEOMONITOR_TOLERANCE
```

since `score.present?` requires a `String` object...


One issue with `SomeException` is that it is not obvious from the signature of a function which exceptions can be thrown by that function. It would be nice to use the explicit type in cases when it exists (for instance functions that call only "exception-free" pure functions), and use the generalized representation as `SomeException` only when required.

I think that is a big issue. Usually we rely on haddock generated documentation, but `SomeException` escapes from it. So even though with `Control.Exception` we have a way to (dynamically) pattern match on the Exception constructors when the type is known, it's often tedious or even impossible to figure out which types of exceptions are possible.

The only solution that I see right now is to establish a culture of rigorously documenting explicitly what exceptions can be raised (recursively) by a function.


Cool. I will try it and then accept if everything is ok. BTW we can do the same for multiEnum type.


Thanks!


saw approval from cmr
at https://github.com/pczarn/rust/commit/4ffa69f5a1e652c39816cf26cab245bf9593220b


merging pczarn/rust/interp_tt-cleanup = 4ffa69f5 into auto


status: {"merge_sha": "1e931186985661dea3b74050e9a198db68b3cc09"}


pczarn/rust/interp_tt-cleanup = 4ffa69f5 merged ok, testing candidate = 1e931186


Not sure about this. Why this was needed?


[SideCI/RailsBestPractices] move code into controller
reference: http://rails-bestpractices.com/posts/24-move-code-into-controller


Not necessarily - there are 2 cases where this would be a bad thing to do:
- if you're working on a project that doesn't use the same line endings your OS defaults to. Like if the line endings for the project are specified as `lf` in the `.editorconfig`, but you're editing on windows. Then we'd be creating files that don't match the project settings.
- if the compiler made a file with `lf` line endings, but the OS uses `crlf`, then adding a `crlf` line ending to that file would be very bad... which is why it matters _a lot_ what the compilers do.

...If we really want to, we could take the output of the compiler and rewrite the whole thing to use a particular line ending defined by the configuration options. Then the user could choose to pass `os.EOL` as that config option and would get a file that matches the default line endings for his/her platform. Or they could choose to pass an option that's specific to their project.


I see; many thanks :)


The current patch sets this to BitSet8(0) if GQRs are modified... maybe note this explicitly?  (Or change the code if you have a better idea how to represent that.)


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.87626262626263%25-red.svg)


Upon further reflection, it's not linted because it's JSON and JSON linters don't care much about whitespace. But! I added some gulp tasks that should at least convert tabs to spaces automatically when tests run: https://github.com/mozilla/node-firefox-ports/pull/28


yeah I think that is reasonable


Oh, you are right. It overrided composite spoilers. Nice catch!


It would be nice to add the "--needed" parameter for the Archlinux command.


I agree with @ianwalter when he say that the code should be reverted as it was before (the method setDefaults should be re-added). The example present in the angularjs documentation for the provider shows exactly this.

@ianwalter and @noordawod do you agree?


Fixed #130


was wrong


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3034
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3040
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3035
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3026
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3026
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3029
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3022
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3017
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2694
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2692
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1530
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1522


wszystko ok. Akceptuję commit.


Yup, I updated my pull request to revert the code but still keeping the changes from #56


So it does. https://github.com/symfony/symfony/blob/v2.5.8/src/Symfony/Component/HttpFoundation/Request.php#L716. This might be confusing for people having the input facade overwrite this method. :/


What tipped you off to try it?


why simple type here? actually, I don't see the point of simple type. It just complicates things with the `this.type` reference. You can perfectly bound it to be yourself at each case manually.


Avoid protected fields - that's the same rule as avoiding public fields. Protected methods are part of the 'provider' API, to be used by extending classes... Looks like here it should be just private.


Hmm, we probably want to check `TypeOutlives` too


This is the minority of cases, so let's worry about that if someone files an issue and is having that problem. It's much better to just stick with what the majority of people will be doing than to spend a long time debating such a small point as this. If it really bothers you, then we can have this be the default and have an option to customize it. If you don't want to add that, then we can just get rid of this feature, since it really only exists for the tests anyway.


saw approval from brson
at https://github.com/vhbit/rust/commit/72e08006da9f9bdf73f57a99092aae3109373b93


merging vhbit/rust/ios-cstring = 72e08006 into auto


status: {"merge_sha": "ea6f65c5f1a3f84e010d2cef02a0160804e9567a"}


vhbit/rust/ios-cstring = 72e08006 merged ok, testing candidate = ea6f65c5


I like what it says below "in major JavaScript engines".


Class for DynamicArray of Integers and the other for String


How is this not an implementation of the Fisher-Yates algorithm?

`Step 1 - Write down numbers from 1 through N` equivalent to `temporary list`

`Step 2 - Pick a random number k between one and the number of unstruck numbers remaining (inclusive).` -> `random.nextInt(temporaryList.size())`

`Step 3 - Counting from the low end, strike out the kth number not yet struck out, and write it down elsewhere` -> `temporaryList.remove(...)` strikes out the kth number, `cards.add(...)` writes it elsewhere

`Step 4 - Repeat from step 2 until all the numbers have been struck out.` -> the while loop

`Step 5 - The sequence of numbers written down in step 3 is now a random permutation of the original numbers.` -> `cards` now contains the random permutation.

Is there an off-by-one error somewhere that introduces bias?


do we get an error on the trait itself? I think we probably should?


Just thought to mention that I think it would be a mistake to assume that yotta is somehow for "other projects".

Yotta is intended to be the build mechanism of choice for a wide range of embedded software from large commercially supported libraries to hobby projects and everything in between.

Therefore I would suggest that if something in yotta makes it unsuitable for large projects like polarSSL, we're doing something wrong, and we should be made aware of what that is.

Dan

From: Paul Bakker <notifications@github.com>
Sent: 6 Jan 2015 15:11
To: ARMmbed/yotta
Cc: Dan Ros
Subject: Re: [yotta] First stab at replacing cmake with scons as yotta's build system (f0578ff)

Hmm.. I'm personally not really a fan of SCons. PolarSSL uses CMake as well as a result (both were evaluated when we decided to add a more complex system than just a single Makefile). Granted, PolarSSL is a much different project than what is done in Yotta.

Most of the movements in open source projects have been from SCons to CMake, not the other way around as far as I remember and can find online..

—
Reply to this email directly or view it on GitHub<https://github.com/ARMmbed/yotta/commit/f0578ff47b321053fc848fe4b225a02556d97138#commitcomment-9169821>.

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782


What was introduced in `layouthelpers.lua`?

Please use a seperate commit for copying the GPG-file, followed by a commit with your changes to it. Otherwise we cannot easily do code review.


Similarly, I think we should get one here, but I know why we don't... and that's kind of a larger bug probably not worth tackling just now.


Because this package is the one attempting to implement that interface. You would get a cycle dependency if you put it in fleet.


r+


Don't you agree that a more suitable name would be something like `presetDialog` or `preset_dialog`?


I get an error in Chromium and Firefox when using `dc.js`/`dc.min.js` from this point on.

The error is Chromium:
> Uncaught SyntaxError: Failed to execute 'querySelector' on 'Element': '#1-clip' is not a valid selector.


Yes, but i will not add that for a couple of reason. If i do that i need two add torrents buttons. I hidden the real input and filepath field since it its just the normal browser version and looks like shit, the second is that the real file path isnt showed, on my computer it came up as C:\fakepath\xxxxxx.torrent so i didnt see the point.


Approved for what? -> igloo.


Isn't that what I did?! Or do you mean moving

highScore = gameInfo.getHighScore();

from under dead state to the restarting state


JFYI: in our projects all argument variables should be named with 'a' prefix, i.e. aIntent in this case.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9792/testReport/) for this commit**


I like this idea, but before we introduce it as an API for the whole of Supcom, I'd like it if we revisit the function signature. There are a bit too many parameters, and it can be very confusing to distinguish at the callsite which parameters are which.

I'd suggest we make this take `parent`, `title`, `layout` and `callbacks`, where `layout` and `callbacks` are tables with relevant key/value pairs.

What do you think of this?


My view of exceptions is that it is not tractable to have both the kind of static knowledge of which exceptions may be raised, at the same time as retaining modularity. There may come a time when this is not the case, but I don't think it will be in Haskell.

The cure for this uncertainty (closed exception types) is beguiling at first, but it is very destructive to composability—you end up having to decide between concrete monad stacks (where you can do type-changing exception handling) which are totally anti-modular and uncomposable, or the MTL-style effect constraints (where you cannot do type-changing exception handling) which is more modular and composable.

Furthermore, the hierarchies of exception types that arise when you try to do strongly typed exceptions (i.e. the injections from a lower exception type into a higher one) reify the intensional structure of a program in a way that destroys the canonicity of errors (you might have two errors `MasterError (ComponentError1 SubcomponentError)` and `MasterError (ComponentError2 SubcomponentError)` which have the same "moral" meaning but whose *inten***s***ion* is totally different).


Why not use ``@mkdir()``?


Why? :(


That is not needed, its existence is checked on the line before.
Doing that also causes some issues on broken systems, as shown on the Crash Archive


Looks pretty straight forward. You seem to be making a lot of progress on the Hubs feature. Do you have a better feel for how much time you'll need to complete it?


Use consistent logging style: always write a sentence, i.e. start with a capital letter, end it with dot.


> So you have to decide whether to validate using the flags the caller provided

In current usage, this validates against the results of the completed load and merge (exactly what you wanted).  The call simply takes a clientcmd.AuthInfo object, so it's up to the caller to decide whether or not call the method before or after load/merge resolution.  I chose to call it afterwards.

Leaving the signature opens allows other callers to decide to do something different.  Consider the case where we want `kubectl config validate` or `kubectl config set --validate=true foo bar` (which looks very reasonable to me).


Oh okey :P Thanks!


Thanks for your fast response!


Yes, this is #789, and we will apply the fix in #800 very soon. We were lacking a test case for anonymous divs.


you can replace:
if self.image_count == 0 or self.image_count == 1:
by
if self.image_count <=  1:


> Validate loading files feels wrong to me. Can validate be called more than once?

This is only validating readability, not correctness of content.

Yes, you should be able to call the method more than once, though it is usually not useful to do so.


first mod with git push and deploy. success update with confirmation on http resolve.


cc @peti for the haskell-packages.nix changes


Sticking to the notation that `a,b,c,...` are for vector components and `i,j,k,l,...` are for dofs, then this should be

`F_{p,i} = -u_a T_{,a} T^{-1} \xi_i u_{b,b} \xi_i`

You'll need to fix all the subsequent terms too.


You are only calling this on the client correct? Calling this on the server is a huge lag and net spam inducer.


 if update == True:
should be:
 if update:


yup, absolutely

> On 6 Jan 2015, at 14:48, Dan Ros <notifications@github.com> wrote:
>
> Just thought to mention that I think it would be a mistake to assume that yotta is somehow for "other projects".
>
> Yotta is intended to be the build mechanism of choice for a wide range of embedded software from large commercially supported libraries to hobby projects and everything in between.
>
> Therefore I would suggest that if something in yotta makes it unsuitable for large projects like polarSSL, we're doing something wrong, and we should be made aware of what that is.
>
> Dan
>
>
> From: Paul Bakker <notifications@github.com>
> Sent: 6 Jan 2015 15:11
> To: ARMmbed/yotta
> Cc: Dan Ros
> Subject: Re: [yotta] First stab at replacing cmake with scons as yotta's build system (f0578ff)
>
>
> Hmm.. I'm personally not really a fan of SCons. PolarSSL uses CMake as well as a result (both were evaluated when we decided to add a more complex system than just a single Makefile). Granted, PolarSSL is a much different project than what is done in Yotta.
>
> Most of the movements in open source projects have been from SCons to CMake, not the other way around as far as I remember and can find online..
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ARMmbed/yotta/commit/f0578ff47b321053fc848fe4b225a02556d97138#commitcomment-9169821>.
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
> ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
> ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
> —
> Reply to this email directly or view it on GitHub.
>


Love it.


@yas375 : that's a typo; fixed in https://github.com/carezone/caremobile/pull/1930


don't do this


Nitpicky, but you use double quotes above and single quotes here. The style for npm itself is double quotes everywhere you're not trying to embed double quotes in the string. I acknowledge this may be due to a rage for order on my part, but I do think consistency is helpful for orienting new contributors.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9771/testReport/) for this commit**


FixWindowsSQLiteBuild (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yeah, I borrowed a couple of `>>> 0` tricks from sha.js ;) Though, it is still 2-3 times slower on latest v8.


`Comparable` インタフェースを implements できます。


BTW:
SSE does work on Athlon XP.
It'S SSE2 what's missing.

So /arch:SSE would be fine, just not /arsch:SSE2

We decided to specify /arch:SSE for client and dll modules makefile and keep the VS2013 default for blakserv/others. Or do you think /arch:IA32 for everything is a better choice?

See:
https://github.com/cyberjunk/Meridian59/commit/ad70f120f2ffe846f9dff955c2f7d39c624cc8fb


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0-PullRequest91+006](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3485&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2998 Build time: 0:0:0


heh. thanks. fixed. good catch.


非常感谢！我先自己研究下。


looks good. do you have some test cases?


Would it work this way?
```groovy
findbugs {
  toolVersion = org.gradle.internal.jvm.Jvm.current().javaVersion.java8 ?  "3.0.0" : "2.0.3"
  sourceSets = [sourceSets.main]
  ignoreFailures = false
  reportsDir = file("$project.buildDir/findbugsReports")
  effort = "max"
  reportLevel = "high"
}
```


overall good stuff

- test cases
- fix up style, maybe break up utility functions into more files
- now that you've seen this, try starting from scratch


let's rename this class to C4ImageGenerator or C4Generator


It looks to me as if the code in rpq.h is there just to be shared by the various cpp files. If that's the case (and it's not intended for export to native code in other packages) then it probably belongs in the src directory rather than inst/include (this effectively makes it private to the package). In this scenario you'd include it with #include "rpq.h" rather than <rpq.h>


You sure of this one?
![image](https://cloud.githubusercontent.com/assets/1838015/5623289/3f4d1c22-95a5-11e4-8a78-270149add595.png)
It escapes it fine but the results aren't pretty, when it's on streampost.create, it escapes fine but also displays properly as plaintext


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/9772/testReport/) for this commit**


I think you still have the call in both places - I had ugly results if I called CGI.escapeHTML twice


Just a comment on commit summaries (titles), you should say in the title what the commit actually changed. So something like "Added Basics and Startup Options to Sections" would be more suitable.


It worked fine for me™ with it only on creation


yep!

吕龙 Lewis
TEL: +86 15811276963
QQ: 14937464
EMAIL: lvlong@chukong-inc.com<mailto:lvlong@chukong-inc.com>

在 2015年1月6日，上午8:13，slackmoehrle <notifications@github.com<mailto:notifications@github.com>> 写道：

his email directly o


we should just use the create_db function directly, since it has the same net effect and removes all this duplicate code


FixWindowsSQLiteBuild (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1582 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think the body of a destructor should always catch exceptions (especially when they call other functions, future maintainers of which might not be aware that they are in a "no throw" zone). I also think you should declare the destructor virtual (in case this class is ever derived from -- the only downside is that it will occupy an extra 8 bytes for the vtable pointer). I'd rewrite as:

```cpp
virtual ~PqConnection() {
  try {
    disconnect();
  } catch(...) {}
}
```


Oh, I'm a fool. I had it on both.


Gracias Adolfo, adelante. ¿Qué opinas de "Gestió d'arxius"? ¿es válido? lo ideal es que el nombre sea lo más corto posible, por eso en español elegí "Mis archivos" en lugar de "Gestor de archivos" (por la longitud)


I would think so ... Duh! :)


OK. Thanks for the early updating. I will hold this PR for now until I start 3.4 version.


IA32 matches the previous behavior so I'm inclined to go that way and
reduce the odds of breaking anything.  The extra performance that SSE gives
doesn't matter in this case.

On Mon, Jan 5, 2015 at 6:04 PM, Clint Banzhaf <notifications@github.com>
wrote:

> BTW:
> SSE does work on Athlon XP.
> It'S SSE2 what's missing.
>
> So /arch:SSE would be fine, just not /arsch:SSE2
>
> We decided to specify /arch:SSE for client and dll modules makefile and
> keep the VS2013 default for blakserv/others. Or do you think /arch:IA32 for
> everything is a better choice?
>
> See:
> cyberjunk@ad70f12
> <https://github.com/cyberjunk/Meridian59/commit/ad70f120f2ffe846f9dff955c2f7d39c624cc8fb>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Meridian59/Meridian59/commit/a669ab2a0655b5786f27af3518b49ce9f9423f05#commitcomment-9163454>
> .
>


I don't think this is how crop should work, it's counter intuitive to have a filter that crops. It would be useful in the middle of a chain of filters but not by itself. Let's remove this filter and just add a crop function to C4Image.


Magic numbers? Can these be avoided?
Same goes for line 64, or line 61. Replacing them with constants would be ideal such that there is no confusion whatsoever for anyone that attempts to join the project.


See comment above


@wolfmanjm You're hearing what I'm saying. This line turns on volumetric mode AND sets the diameter to 3mm:

M200 D3 ;

This line turns on volumetric mode *and does not set a value*, making your gcode independent of filament diameter (this is what you want it to do):

M200 ;

This line switches back to extrude-by-millimeters mode:

M200 D0 ;

The machine needs to start in extrude-by-millimeters mode because that is how the existing software works, and starting in volumetric mode will break compatibility with other slicers and with the manual controls in host software. If you include the M200 line without a D value, it will not override your stored value, it will just tell the printer to use that value instead of extruding by millimeters.


On closer examination I'm even less comfortable with this method being an un-named explicit conversion operator.  It returns a copy of a vector -- a fairly heavy-weight object.  Generally I don't expect that invoking `static_cast` will produce a copy of anything, much less an entire vector.


Hey @chrisdavies sorry to use this message off-topic about this commit.
I've started to use rlite and I wonder if you could care to add the MIT license to it.
If you do that I'll be able to use it in an open-source full-stack framework I'm working on.
We love it because is good enough and is so tiny!
Do you think you can do that for us?

https://github.com/chrisdavies/rlite


I guess it could check if `gettext` is already installed, and then compile the translations.


@chrisvest that is correct.  by parking threads in the AQS when the pool is over-subscribed, we leverage the fairness guarentees that it provides (in Java 7 and above), ensuring FIFO allocation of Connections as they come available.


Static import `toList()`


Nice!


IDFXT (Unknown) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This isn't guarded behind `CHROOT_ENABLED`, which means it breaks on darwin (and probably others).


If there is no way to automate this, we always have to:
 * merge PR
 * wait for the build
 * bump version
 * release/tag

:(


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3026
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3020
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3021
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3012
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3012
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3015
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3008
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3003
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2679
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2677
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1516
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1507


fast-forwarding master to auto = c7dd3c4d


What does the above mean exactly? The "crypt" format is the very last resort for attacking hashes that are supported by your OS but not by your version of JtR but it should normally never ever be output by hashID I think. Unless I misread something here, both line 65 and 66 should say "john=descrypt". That's for any version at or greater than 1.8.


I apologies the express static middleware doesn't effect `res.sendFile`, but it worked on its recently depreciated  counter part `res.sendfile`.

You'll have to refactor to:

```javascript
var router = require('express').Router();
var path = require('path');
// server routes ====================

// NONE

// frontend routes ==================

//route to handle all angular requests
router.route('/')
  .get(function(req, res){
    res.sendFile(path.join(__dirname, '../public', 'index.html'));
  });

module.exports = router;
```
http://stackoverflow.com/a/25463996/2259303


Copy this too (verifies there are no nulls)


...się narobił ;)


Use proper Javadoc formatting (HTML list)


Add clarifying paranthesis


`stream` is never used.


Nice cleanup.  You might consider renaming the local from `it` to `id` or some such, since we don't have an iterator in out hands.


gratuitous semicolon


You can style this project however you want, because it's yours ;), but `==` is almost always a bad idea.


Hmm but you may be outputting both there, yes? In that case it's sort of correct (but probably a waste) to include "crypt" too. I should probably test your little tool before talking too much.


inconsistent spacing around operators


This is a big boost in readability.  And I'll grant you, the `auto` definitely wins the readability contest here.


saw approval from huonw
at https://github.com/nick29581/rust/commit/f27044b6ebbda2d96f3071ef9cea918def93eb14


merging nick29581/rust/arrays-3 = f27044b6 into auto


merging nick29581/rust/arrays-3 = f27044b6 into auto failed


I need this update already :+1:

The current version of locationService.Get( address) crashes when trying to create a location because there aren't any verification providers in Excavator.


I don't follow


This should stay as an `if` since otherwise it just does `page = page`


84202472-TurnOffInputEchoByDefault (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (1582 of 1582 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


No! It's an operator, it deserves a space! You said so yourself!


I do!


Sorry, that was cryptic. No space between the exclamation point and its operand, plz.


This is so much clearer than the `BOOST_FOREACH` without the braces.  Thanks.


Oh and to add (my own) insult to injury you are actually saying descrypt right below this comment. Maybe you are just smarter than me and did the right thing. I will now officially shut up until I wake up tomorrow.


Docs image:

![screen shot 2015-01-06 at 3 27 36 pm](https://cloud.githubusercontent.com/assets/185555/5623416/d0cc63c0-95b8-11e4-87ba-8be005bda100.png)


Well, seeing as the methods attached to tracker aren't variable... if tracker exists it definitely is set.


It's a unary operator, thus exempt from that rule, and we use it cuddled, like, everywhere in the npm code base. Plus it looks weird to me after so much Node hacking, but I admit that is not a criterion with an objective basis.


A ZF controller to accept incoming XML-RPC requests, and route the request to the appropriate model, based on the action in the request.


This completely breaks wildcard routes for alternate methods, for example:

```go
r.Handle("GET", "/v1/search", search)
r.Handle("OPTIONS", "/*path", handler)
```

GET requests for `/v1/search` will **always** return a 405 with this change.


`it` might be named `node`.


@azturner  @mikepetersonccv  Any idea when this will be pushed to master (or why it's not already)?


saw approval from alexcrichton
at https://github.com/huonw/rust/commit/3e9d5938cc4030de2e8c8e140633cc4d7d58733c


merging huonw/rust/ungate-AT-globs = 3e9d5938 into auto


status: {"merge_sha": "0311fa3f1832251bfffc0cdfb9828ee996057538"}


huonw/rust/ungate-AT-globs = 3e9d5938 merged ok, testing candidate = 0311fa3f


That's correct. I use == for reasons. I think the === best practice doctrine is an over correction and should not be a best practice.


One way or another, there should be a test on `func` to confirm that it's set before calling apply on it. There are a couple logical ways to get to this line without tracker being set, and that means the possibility exists for weird edge case bugs that will be a pain to debug later. If you add a guard here, you don't need one on line 66.


changed -> changes.  I find the second part of the comment confusing.  The code sets the MAX LSN unconditionally, but the comment implies it is conditional.  I think that was why I rewrote it some when these changes were originally put in.


Looks good.


I disagree with this pretty vehemently, having been bit by `==` issues enough in the past that I think it is at the very least a useful eslint rule. More to the point, it's inconsistent with usage in the rest of the npm code base. I'm prepared to go to the mat for this one.


Decided to add this on because why not


This module is single quotes everywhere actually, and I should change the double quotes here to match the rest.


> I just wanted to add that using a static Random object in your tests may prevent you from parallelizing your unit tests deterministically

That's a good point. @Priya91 can you take a look at file an issue if necessary?


Why shouldn't the remaining person be able to read the chat history?


@gooopy 이 부분 머지하면서 쿼리가 잘못된듯 ㅠㅠ

```python
entries = query_db('select id, title, text, writer from entries order by id desc')
```

이런 식으로? `query_db` 함수도 한 번 보세여 ㅋㅋ


Just list me as an author for this repo for now.


여기도 똑같이?


Please point to the GitHub url instead.


I see. Well Smoothie does not really work that way. M200 will do nothing.
M200 D0 will turn off volumetric mode.
If you save M200 D3.0 with M500 then smoothie will start in volumetric mode. I don't really see that breaking anything
By default Smoothie will start up in millimeter mode unless it is overriden by M500.
BTW we do not exactly do what Marlin does. ONLY printing E values will use volumetric mode if set. retracts and extrudes always use mm mode regardless of whether volumetric mode is on or not.

If like triffid hunter you want everything to use volumetric then you just leave M200 off, and set your E steps/mm to E steps/mm³ then everyone is happy :)


I put it there because it needs to be in include in RcppExports, so that the type XPtr type can refer to it


FYI, https://github.com/paf31/purescript-thermite


Ok, so in Smoothie, if you save an M200 value with M500, then send M200 D0 (or any other M200 value), do you have a way to get back to the saved value without resetting? That's what M200 without a D value is for.


This could be a problem in all the places we've used Debian mirrors, given the way Debian format them?


Move this method refactoring to a separate commit


Why does this line end with a / and the other routes do not?


you don't need to make this generic, `Renderable member` should do just fine as a param


In your old def below this ended with a / and it no longer does.


Great! Sorry I wasn't fast enough to get this.

-N

On Mon, Jan 5, 2015 at 6:28 PM, Arjun Guha <notifications@github.com> wrote:

> Fixed star
>
> I CPSd the TDK local compiler to compile SDX but CPSd * wrong
>
> @jnfoster @seliopou
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/frenetic-lang/frenetic/commit/33dd1e7b64466e7d4190906902391a3180a53039
>


``` java
return entity == null ? 0 : ENTITY_SPLITTER.split(entity).length;
```


``` java
@Nullable String entity
```


yea you can do M501, that will reload the config-overide file which stores the original/saved M200 Dxxx.
The "original" value is not stored anywhere, so M200 would not have anywhere to restore it from. If you feel it is really important to use another 4 bytes of ram to store the previous M200 value then please file an issue on github and I'll add it. That is if M501 is not a good workaround.


add one for the spinner that will spin the zipties for the colector


(Sorry Sound for hijacking your issue list ;)


We need to use https://github.com/onel0p3z/hapi-mysql for it to work. I already submitted a PR to the creator of hapi-mysql (https://github.com/seldo/hapi-mysql/pull/2) to fix this issue.


This is doing nothing?


some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3004
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3027
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3021
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3022
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3013
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3013
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3016
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3009
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2680
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2678
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1517
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1508


This turned out far harder to follow than expected.  Here's what was added, starting on 106.

+          // Emit excluded when resultList[] exists, but has no entries
+          if(resultList[i].values() === null || resultList[i].values === undefined || resultList[i].values.length === 0)
+          {
+            emit('excluded', 1);
+            continue;
+          }


80757414-AddAutoSizing (Myoldmopar) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.11868686868688%25-red.svg)


only to 'auto select' if no fields are selected like find('list', ['id', 'title']);


no space after 0


what is this


I didn't say anything about storing the previous value, I was just talking about switching back to the saved value once another value has been set.

Does M501 restore all of the values from M500, or can you select just one? I still think M200 to use the stored value is a better way to do it, but if smoothie will ignore an M200 with no D value, then the method I suggested will work fine.


Fixed: 6d5e9e60b8e58fd323aa33773a54f55825eae30d


Hi,faker
Thanks for your commitment.
The $TEMP_KERNEL_DIR save to the /tmp. The system will reboot after successful update,  and the $TEMP_KERNEL_DIR will be automatically deleted.


This is a **big** move!


I thought you don't pass start and end dates... How do you figure them out? based on ttl?


r+


IDFXT (Unknown) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.92405063291139%25-red.svg)


Please see latest commit so we can put this to rest.


Logging results via callback:

![screen shot 2015-01-06 at 3 57 29 pm](https://cloud.githubusercontent.com/assets/185555/5623693/c5cb36aa-95bc-11e4-9cb6-644242d801fd.png)


also, use -1 as value - so that if there's error in logic - you'll fail fast


I would define the double-height as the standard height * 2, so if the height changes we only need to change it in one place.


thx :+1:  :)


Awesome that would be great. I took a first pass at making the install script Docker compatible: https://github.com/PredictionIO/PredictionIO/blob/develop/bin/install.sh

It now checks of a user exists as well because that was another problem. By default docker seemed to do everything as root which is probably not the best solution so a Dockerfile that creates a user first would be good. Is there a way then to execute the install script using that user as the install script checks $USER?


r=aturon p=1


Please, don't rely on default onStartCommand behavior - it isn't clear from the code what it actually does.. As you're not handling intent, just return START_STICKY.


I prefer not to source control .gitignore files.


@bors: retry


I think `present?` just checks if not the following:
 - nil
 - whitespace string
 - false

http://api.rubyonrails.org/classes/Object.html#method-i-blank-3F


You don't need to call super.onCreate() and onDestroy() methods for the service - it is different from Activity. So remove this line.


r+ p=1


the convention for tracking an empty directory is an empty file named ".gitkeep" ... if you want to update this along with the .gitignore change I commented on, I will approve.


I think this breaks insertion into chests....which before I rewrote it worked for every direction except down.


Personally when using CMake I do:

    mkdir -p build/debug
    cd build/debug
    cmake -DCMAKE_BUILD_TYPE=Debug ../..

Which means that the build artefacts are kept out of the main source tree.  Makes cleaning up simpler.  I should really include a script that does this automatically for users.


ok done.


You can remove the ```div``` from before these lines of css.

```.content.scroll.double-footer``` instead of ```div.content.scroll.double-footer```.

I usually don't specify div unless I need to make the class specific to divs. Since CSS is read from right to left, you can usually drop that part off.


Approved for making the change..... igloo????


This is clever, but not as elegant as using an import function. Also is just as hard to read as my crazy brace expansion clustercrap. Check my update to the `import` branch. It's not using `eval` either.


I thought for a moment that it was pretty nice to be able to say `T: Hash`, but I think that it's rare enough that it may not be worth it.


This func name isn't clear on what it actually does. Please rename it so it reflects what is actually scheduled.


@westonruter This is still putting 2 new lines after the code block instead of 1.

![screen shot 2015-01-06 at 2 04 20 pm](https://cloud.githubusercontent.com/assets/522158/5635244/0becd1f8-95ad-11e4-8812-7203be168b69.png)


d


We are not authors... so it would be better to wait until - G33K - write which licence to add. Do you agree?


By all means, gentlemen. I'm happy we've reached a resolution to this :)


This macro call breaks the "make errors" target.  The function name is ASN1_item_verify(), which implies the first argument should be ASN1_F_ASN1_ITEM_VERIFY.


Compilers ignoring `os.EOL` isn't a "minority of cases":

- Jade: https://github.com/jadejs/jade/blob/714d6d3b8355875b35ded7bd7a5b5897e89d17b3/lib/compiler.js#L81
- Stylus:https://github.com/LearnBoost/stylus/blob/d1702c9e8f68c69f9540acdf043d0131a5b852f8/lib/visitor/compiler.js#L144

Unless you consider Windows a minority... then it would be, but for the purposes of this issue we're focusing on platforms with different line endings. And on platforms that don't use LF, sticking the default OS EOL on the end of the file will cause mixed line endings every single time for Jade, Stylus, and probably all other compilers.


Don't use magic numbers. Create static finals instead.


"Sort of"? It seems to be completely fixed...


@miraculixx I'll take a look!


Avoid getters of class internals... The need for such getters indicates non-optimal design decisions.


Good that I just began today with the translating : P
Would be a disaster if I startet earlier and were just for finish and then someone updates it.
Good that this was not happening ^^
Yeey thanks to Neui!


Heylo


It does however appear to work as expected in IE 8.


aha, sorry, didn't realize the left side was a change of yours too.

writing API code we can't actually test in prod is a little odd, but it is documented, and we can write a unit test based on that, so sgtm. thanks!

we should also watch for (or even solicit!) anyone with a approved app who'd be willing to test for us.


s/mShared/aShared - don't use m prefix for non-members.


@thejameskyle What's the complete alternate text that you're suggesting? `Use JavaScript of the future in current browsers and JavaScript engines?` or `Use JavaScript of the future in current major JavaScript engines` or something else completely?


Same here, replace m prefix


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2169 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13162705667276%25-yellow.svg)


Ah, right I forgot about the two phases of the Tick.

Will fix in the next commit.


I submitted another request to the gradle-bot to get the readytalk-ci plugin included in the gradle-plugins repo.


Please check the branch code, it's documented.
Do you think it's also necessary to comment parameters and functions whose names show clearly what they are/do?


Oh and CoffeeScript actually _refuses_ to support CRLF: https://github.com/jashkenas/coffeescript/pull/1823


The macro call above breaks the "make errors" target.  The function is ssl3_get_key_exchange().  The first argument to the macro needs to be SSL_F_SSL3_GET_KEY_EXCHANGE.


I am not understanding the paragraph above. I am still not fully recovered from the fever and these drugs are making me high. And the following may not make sense.

If the domain is not registered with us, the user has to configure the secondary name servers with their current registrar, correct? What I am not understanding is the value of pointing their name servers to us then (first paragraph of the warning). Could they achieve the same secondary configuration by **not** pointing to us?

To be clear: our UI for secondary configuration is not useful for hosted domains, right? Everything needs to happen on their current registrar.

The rest is awesome! I want to include some of this in the current UI to make things clearer. Thanks for the writeup :+1:


Hi @andizer,

Just wondering what you're trying to do here. Hope you don't mind some feedback. I don't mean to be harsh, so please take it as a learning experience:

1. Splitting the option classes into their own files:
While I completely agree that having them in separate file would be *better* practice, the reason I choose not to do so is performance.
The way things are set up now, means that all the option classes are *always* needed, that literally means on every page load. Includes are relatively 'expensive' calls to make. WordPress itself includes files, themes include files, plugins do. It all adds up and people end up with slow websites (not just because of the includes of course... ). While I definitely don't advocate having everything in one file, the option classes are *very closely related* and having **eleven (11!)** include calls rather than *one* for this **_on every page load_** did not seem sensible when I set it up and to be fair, I'm still of that opinion.

2. Removing the class_exist() wrappers:
First of all, having these wrapper is a practice which is - rightfully - very much advocated by the WP team to avoid conflicts and while it would be *very very silly* for another plugin or theme to have a class named the same as one of ours, it would be even *more silly* to have websites go down over it.
Secondly, as that was applied consistently, the autoload function does not do a `class_exists()` check before trying to load a class, so removing the wrappers without adding that check to the autoload function is irresponsible.
Thirdly, *you don't know the order in which plugins are loaded*. You might think that as the autoloader is in place, there shouldn't be a problem, but it only kicks in once it's loaded. *Speaking extremely generally*, most WP plugin programmers aren't good PHP programmers. This can lead to a - albeit unlikely - situation where two other plugins are loaded in before WPSEO and both could try and hard include the same WPSEO file. The site using those two plugins *would go down*

Maybe I'm missing something, but altogether I'm no advocate of these changes.


Use TextUtils.isEmpty() isntead of double checks (for null and for emptiness)


In case others once work on this:
I assume this won't create a proper copy of the ctx.
Had bad_access issues and invalid checksums.


Should probably include the fact that the other languages MUST be 100% synced at all costs. Even if they contain the incorrect language.


Good idea.


Fixed the cs: https://github.com/cachethq/Cachet/commit/c758ff560c2b6e36d1c613391d189e159614bcf4.


string[]


I was wondering about that.


> To be clear: our UI for secondary configuration is not useful for hosted domains, right? Everything needs to happen on their current registrar.

No. The UI is necessary for all domains hoping to use secondary DNS because we need to setup the AXFR server. There is the additional step that is necessary for hosted domains to add the delegation at their registrar as well. I'll think more about better phrasing.


Initial Creation


Better iterate over the divs (`document.getElementsByClassName('quickindex')`) and use the id or alternatively add a class to the anchor. Using this you might pick up unrelated anchors, e.g. from some plugin sidebar or so.


if u r not going to add actually doco then dont bother with the empty doco nodes


'rt' is the same as 'r', t means "text mode" and is the default mode.


It would be cleaner to make a list of pairs (or triplets) of tone numbers and waits and then loop over that rather than calling `playTone` and `wait1MSec` each time.


invert this


Instead of adding ```double-footer``` to ```.content``` and ```double``` to ```footer```, you could add one class to a parent element and have it impact both elements. I think that might be easier to manage—especially if the double-footer impacts additional elements down the road.

Example, if you add ```.double-header``` to ```body``` (or another parent element of the content and footer), you could set the content and footer like this:

```
.double-footer .content.scroll {
    ...
}
.double-footer footer {
    ...
}
```


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-MacOS-10.9-clang-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.94803548795944%25-red.svg)


LGTM


Too many new lines here.


why do these keys follow different conventions?


Interesting! How come you ran into this? I wonder if I should move this into the main repo.


Write more meaningful logs: 1. write what has happened first, in this case: "Login failed: ", 2. write the real reason for the failure (if known), in this case: "provided login or password is empty."
Also never write password to the log.


Huh. Well that's an unfortunate compatibility fail. Safari's `Map` implementation also doesn't support `-0 !== +0` keys.

Native `Map` is still faster than `Object` property lookups. We can replace the constructor argument with a forEach loop that fills the `Map`.


Fixed in https://github.com/cachethq/Cachet/commit/d7486ef98ace2879960daae3c58214fed3275303.


So I got the decrypted message in decimal, but converting into ascii gave me weird stuff... Not sure what I did wrong...


functions dont need ; at the end of them


Yeah i'm dumb, the key is in decimal, not ascii


Cool. Maybe an example would help?


Looking good! +1 after the couple of notes.


@robkooper I was trying to figure out why this says `LEVEL:-3` (why is it negative)? But then I realized that in this edit I only meant to change line 24. I am not sure how I committed this with so many other changes that I am unqualified to implement, but wanted to check with you - did I accidentally revert some changes, or is this diff as expected?


UtF8 :) Or, even better, comments in english :)


Isn't the point of failing unittests to show that some things are not working the way they should work?
If we remove the unittest, wouldn't we also have to remove the feature that it's supposed to test?


Updated README accordingly :)


It seems that current design lacks indication of login failure (though maybe I haven't looked through all the code...)


Thank you, I will do that


ok, I replaced format with fmt, eclise was issuing a warning because format is a built-in python symbol and it can cause confusion.


> Use JavaScript of the future in current major JavaScript engines.


We could move the parameter onto the `hash` function itself. I'm not sure how much of a use case there is for specialization based on the hasher, though maybe it will be more of a thing when negative bounds are added?


Would it be natural to generalize this definition to total(?) orders?


this is beautiful


Recent examination of code has revealed that op_ctx->export is NULL here, we need some other way to handle this.

Also, the fsal_export release function CAN NOT call put_gsh_export because put_gsh_export is what calls release in the first place.


:relaxed: Th-thanks~


Мда)) Надо будет все под UTF-8 переделать. А вообще это был коммент для себя, а-ля "вставить на место j"


84694650_EnableCodeCoverage (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-Debug: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It takes about 1.4s to compute on an XO4, and possibly more on different environments.  Since most peoples GST install doesn't usually change we can safely cache it.

Cacheing it to a file makes it really easy to clear cache (if you install more mimes).  Is there a better way to cache it?


Check that listener isn't null. It is important because passing null won't throw NullPointerException here, but sometime later, which will be hard to debug (at minimum)...


Было бы хорошо иметь Джавадок который описывает основные особенности метода. Один-два пункта.


Great commit
![purplerain_poster630__120410202121](https://cloud.githubusercontent.com/assets/1216762/5635515/9980682c-959e-11e4-8aaf-590a0969bb80.jpg)


r=aturon