Be careful about gender in PL texts. Always try to make the PL version do not imply the user is he or she. E.g. "Czy na pewno chcesz usunąć tę dyskusję?" or something similar.


This should fix the remaining issue with logback. My bad.
https://github.com/reactor/reactor/commit/25d76cce450c670ece79b7f0a75367055fcebf34


You should set the objects to None after releasing them otherwise there's a risk of double-releasing them.


Hi Jason,

do you have any testing comparison with this fix on some heavily loaded machine?


r+


ok


I know this predates your change, but can we mark STARTUPINFO as IDisposable at some point?


^ @MitchellMcKenna


Nice job @trbs !


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/0627d4c5994e2c5f33b97b23fc6fbc61fb1f9bd0


merging pcwalton/servo/word-break = 0627d4c5 into auto


pcwalton/servo/word-break = 0627d4c5 merged ok, testing candidate = 3d9200e4


Support for native i386/i686 packages (points to correct native glusterfs repositories) + support for noarch repository.


There is no need to prefix everything with arm_. We know it's arm as it's in a GICv3 driver.


You still missed the 's' in my last name LOL :)


Thanks, sorry :v :')


@bors: retry


Haha... No problem... It's a better fix than what I did on my personal
source

On Thursday, January 8, 2015, laufersteppenwolf <notifications@github.com>
wrote:

> oops, sorry about that :p :D
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/T210-dev/android_hardware_marvell/commit/ec52501666c6861855942fded6a558c22917a878#commitcomment-9203682>
> .
>

--
Sent from Gmail Mobile


PHP because of a single <? include() ?> sounds as not a best design choice of technology here to me.


Is there any reason why this is not merged, into develop branch at least ??
wed also need to update
http://revel-docs.daffodil.uk.com/manual/tool.html
and
http://revel-docs.daffodil.uk.com/manual/debug.html


I recall that this JS needed to be in the mako file due to its reliance on `addon_enabled_settings`. See the line comments in https://github.com/CenterForOpenScience/osf.io/blob/3e0bcd94c74f60c8360a5962d320e7aa215d21c5/website/static/js/addon-permissions.js#L60-62


That's why I got rid of the list really ;)


Basically it extracts the values from the options hash, and converts them to ActiveRecord::Relation calls.

For example, it turns the hash `{ :conditions => { :id => 10}, :limit => 20}` in to `where({:id => 10}).limit(20)`.


Improves the docker situation a lot! :dancers:


ofw_bus_is_compatible() is supposed to work for the child device (driver) whereas I'm trying to iterate through subordinate nodes before the child device is created so that I create no device but ITS.
Yes, this is the exact intention - to avoid creating anything else but ITS (actually it is written in the comment above the condition). This is because GICv3 is not really a bus, we just need to make it like bus in FreeBSD to maintain the preferred way of auto-configuration.
I thought that this would make more sense since creating any other device will be just wrong.


Haha I know just joking ;)


release-candidate target updated in 93ba4b1


I think these need to be prefixed with _ ?


I'm confused, but this  code part solved my issue.. I had get the error in json "{

    "error":

    [
        "errUnknownCmd"
    ]

}"

The error was taken when elfinder try to connect to controller by "showConnector()" method


rax retry tests


Why?


Another way to do this is to use `Cmd` object for interpolation:

```jl
codecov = coverage? `--code-coverage=user --inline=no` : `--code-coverage=none`
```

We should probably make this a recommendation in the section on calling external programs.


Flawless victory.


Humm.. forget it, the release already checks if the program is None and sets it to None after releasing, so calling release twice has no effect. Better to leave the shader as is in case a race condition causes it to be used while it's getting cleaned up.


Cool, that is about what I meant by "more clever." Though this won't work on Windows since we don't have a `$(JULIAHOME)/julia` symlink.


Just a note: During our testing, we found an issue with external auth since `activate_account` is never actually called, and therefore this code path is missed when AUTH_USE_CAS is enabled (since account activation links aren't sent out).

I'm fixing this auth problem upstream and will PR a cherry-pick to feature-pocs with the fix.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.1809](http://teamcity.monogame.net/viewLog.html?buildId=4243&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 304, ignored: 6 Build time: 00:16:09


Hi again,

Try this ?

https://github.com/PrestaShop/PrestaShop/commit/65e4bf20a43da3c76ab4c872ad0e2fe0a6203e11

Regards


empty main block will not work
python needs something like print or one function call


I reckon it might be nice to re-add those wrapping `/`s here, for pattern recognition (no pun intended):

    'Expect header %s to match /%s/, got %s'


Okay... Will modify accordingly :)


Not sure that one works


Cool. Glad to see it fixed.


@bors: retry


Sorry I missed this update earlier. Looks good.

Ack.


fdt_addrsize_cells() does exactly the same thing. Are those fdt_ functions somehow forbidden to use?


Didn't know that, thanks!


ProcessThread.ResetIdealProcessor().  Is this something that should become platform specific?


Good point. They're not, but we might as well leave it, in case we can add them back in later.


This needs to have a fallback. Old purchase records may not have item_price


find more sutable name for the file


@arnoudj Github isn't ideal for reporting this. Could you file a bug on https://bugs.launchpad.net/puppet-keystone ? Your input is also valuable on incoming patches at https://review.openstack.org/#/q/project:stackforge/puppet-keystone,n,z .


Let's absint() quantity and ensure it's not less than 1.


Should this link be to ".../browse/TK-130"?


@macbre md5's second parameter is a boolean, so doing this causes the same memcache key for every shared help article in a language, causing https://wikia-inc.atlassian.net/browse/MAIN-3485 .


good idea, will do


@dsawa I am about to revert this change. It turns out if I get rid of the `href='#'` in and instead use `href="javascript:void(0)"` the original scroll position code works! So it solves the url and the scrolling issue. Thanks for pointing me in the right direction.


* it's not clear that `getElement` can return single element or array. Change the name or implementation
* add plz one line break after each method
* why do you need word `Element` inside each method? Looks like the only thing which you can manage is element, so lets remove entropy


Same here.


Bill, yeah, nothing has changed after the Getting Involved section. It's all in tact


Seems to work, though...


I think so.


I don't think the `: extending` or `:extend` keys for `has_many` are documented anywhere.

Here's a brief:

The `extend` and `extending` keys accept a module or array of modules that will be applied to the association returned by the has_many association.

```
#   module NamedExtension
#     def greeting
#       "hello"
#     end
#   end
#
#   class Account < ActiveRecord::Base
#     has_many :comments_with_extend, extend: NamedExtension
#   end
#
#   person = Account.first.people.find_or_create_by_name("David Heinemeier Hansson")
#   person.comments_with_extend.greeting # => "hello"
```


This was corrected in this commit
https://github.com/royopa/api-rosetta-code/commit/869d0c64b8f121a8f21c2435fc3a02308353b04d


It's misnamed as it's not fdt specific and is broken on little-endian systems when either of the two properties are missing.


some tests failed:
failure: http://buildbot.bos1/builders/test-eleveldb/builds/346


it's wrong way. Plz check event delegation and functionality which `$.widget` provides to work with events delegation


I wanted to stay aligned in terms of name space with previous GIC driver which also has arm_ for its device methods. Although I have no problem with removing it.


This is corrected in this commit
https://github.com/royopa/api-rosetta-code/commit/ebfa25d9ee86733e16aa87d9eb7dbd6a872c762f


I renamed the directory in commit
https://github.com/royopa/api-rosetta-code/commit/8cc0417ba80c0d1468af161fd9ec8afb08feced0


jquery has method `.each` why do you use `underscore`?


I fixed this in the credentials script here https://github.com/AltBeacon/android-beacon-library/pull/74
So these won't be needed anymore.


dependency on structure. It's better to be dependent on attribute or css class


This is corrected in last commit


Plz don't write angular-like directives. Implement everything using widgets


We didn't have one at the time, and a big enough timer or sleep delay could have overflowed it, I opted to go with the safer option, we can change it later when we implement a GSP event.


Messed up the title. I edited the readme to show how to run the simple static local server.


There is a circular import problem, since ``map`` imports ``searchController``. I am making a ``mapUtils`` module that contains the ``zoom`` definition and helper function.


Found BROKEN by windows-vs2010.
2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\function\plugin_interface.hpp(109): warning C4101: 'ex' : unreferenced local variable [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\function\plugin_interface.hpp(109): warning C4101: 'ex' : unreferenced local variable [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\../std_vector_tools.hpp(369): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\../std_vector_tools.hpp(499): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\../std_vector_tools.hpp(488): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\matrix_impl.hpp(809): warning C4244: 'argument' : conversion from 'double' to 'const int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\../std_vector_tools.hpp(499): warning C4018: '<' : signed/unsigned mismatch [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  ..\..\..\casadi\core\misc\integration_tools.cpp(334): warning C4101: 'e' : unreferenced local variable [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\misc/variable.hpp(71): warning C4099: 'casadi::Variable' : type name first seen using 'class' now seen using 'struct' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\misc\variable.hpp(71): warning C4099: 'casadi::Variable' : type name first seen using 'class' now seen using 'struct' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\matrix_impl.hpp(809): warning C4244: 'argument' : conversion from 'double' to 'const int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\misc\variable.hpp(71): warning C4099: 'casadi::Variable' : type name first seen using 'class' now seen using 'struct' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  ..\..\..\casadi\core\mx\constant_mx.cpp(119): warning C4244: 'initializing' : conversion from 'double' to 'int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\binary_mx_impl.hpp(206): warning C4065: switch statement contains 'default' but no 'case' labels [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\binary_mx_impl.hpp(206): warning C4065: switch statement contains 'default' but no 'case' labels [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\mx\binary_mx_impl.hpp(206): warning C4065: switch statement contains 'default' but no 'case' labels [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\matrix_impl.hpp(809): warning C4244: 'argument' : conversion from 'double' to 'const int', possible loss of data [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

"C:\Users\casadibot\windowsbot\windows-vs2010\source\build\swig\python\python.vcxproj" (default target) (1) ->

"C:\Users\casadibot\windowsbot\windows-vs2010\source\build\swig\python\_casadi.vcxproj" (default target) (3) ->

"C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj" (default target) (4) ->

(ClCompile target) ->

  c:\users\casadibot\windowsbot\windows-vs2010\source\casadi\core\matrix\generic_matrix.hpp(233): error C2039: 'zz_adj' : is not a member of 'casadi::MX' [C:\Users\casadibot\windowsbot\windows-vs2010\source\build\casadi\core\casadi.vcxproj]

    66 Warning(s)

    1 Error(s)

Time Elapsed 00:04:54.42

```


I'm not sure what's the matter either. I did some research and couldn't
come up with anything.  Here's the screenshots (attached).

1.png is the screenshot after I entered an item into the form, pushed save
and was redirected to the list.
2.png is the rails console shot of doing l = List.first and l.items

On Wed, Jan 7, 2015 at 6:57 AM, Bobbilee <notifications@github.com> wrote:

> yes that seems weird...take a screen grab of ur return instead of copy and
> paste
>
> Sent from my iPhone
>
> > On Jan 6, 2015, at 8:47 PM, cflammia <notifications@github.com> wrote:
> >
> > Okay, I got
> > 2.0.0-p481 :012 > l = List.first
> > List Load (2.5ms) SELECT "lists".* FROM "lists" ORDER BY "lists"."id"
> > ASC LIMIT 1
> > => #<List id: 1, title: "Friday Party", user_id: 1, created_at:
> > "2015-01-05 05:22:08", updated_at: "2015-01-06 03:19:10">
> > 2.0.0-p481 :013 > l.items
> > Item Load (3.1ms) SELECT "items".* FROM "items" WHERE "items"."list_id"
> > = ? [["list_id", 1]]
> > => #<ActiveRecord::Associations::CollectionProxy []>
> >
> > I used first instead of last because I knew I had created items in the
> > first one. l=List.first is showing, so lists are good. It appears the
> > items aren't saved though. I'm not sure what
> > <ActiveRecord::Associations::CollectionProxy []> means? Is this an
> error?
> >
> > On Tue, Jan 6, 2015 at 9:30 PM, Bobbilee <notifications@github.com>
> wrote:
> >
> > > check In rails console all of these things - l = List.last
> > > l.items
> > > and see what it returns then u know if the items are being saved to
> the
> > > list
> > >
> > > Sent from my iPhone
> > >
> > > > On Jan 6, 2015, at 8:06 PM, cflammia <notifications@github.com>
> wrote:
> > > >
> > > > I get the following, which means that yes, my new item was saved,
> > > correct? I'm not sure why it's not rendering though?
> > > >
> > > > Processing by ItemsController#create as HTML
> > > > Parameters: {"utf8"=>"✓",
> > > "authenticity_token"=>"+UuvEmeg9vbsqXtBdoaqHKhiA/ZpDIpEW3lNJU+mNeU=",
> > > "item"=>{"name"=>"Order drinks."}, "commit"=>"Save"}
> > > > (0.1ms) begin transaction
> > > > SQL (14.0ms) INSERT INTO "items" ("created_at", "name",
> "updated_at")
> > > VALUES (?, ?, ?) ["created_at", Wed, 07 Jan 2015 04:05:02 UTC +00:00],
> > > ["name", "Order drinks."], ["updated_at", Wed, 07 Jan 2015 04:05:02
> UTC
> > > +00:00] commit transaction
> > > > Redirected to http://localhost:3000/lists
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub.
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/cflammia/blocitoff2/commit/e2f308590884f94e974c581a1167dd80ff787c37#commitcomment-9179836>
>
> > > .
> > >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cflammia/blocitoff2/commit/e2f308590884f94e974c581a1167dd80ff787c37#commitcomment-9185540>
> .
>


Oh dear. :crocodiletears:


@empty thanks :)


Is Destiny the new fps? or will COD and Halo prevail


You can do circular imports in commonJS, but there are nuances around loading that I would rather avoid thinking about.


@empty thanks and thanks to all the contributors !


Why should it?


Accidentally has the wrong commit message


@Memphiz, @Montellese this should hopefully fix it.
triggered a jenkins build http://jenkins.kodi.tv/job/IOS-ATV2/ but its in queue only


I'm not sure. We have this same setting on zamboni but I recall seeing task exceptions I'm pretty sure. I was just thinking if sentry catches it an admin email could probably be disabled.


Needs double colon to be formatted as quoted code block in ReST


これ、SPAしかプレイしていないので、もっと使えるやつも持ってきます。


`2 * sizeof(void *)` should never overflow, because as `sizeof(void *)` increases, so does the size of the value storing that multiplication.

However, cldefines_size is still multiplied by two. This could potentially cause overflow if you need more than 32767 definitions on a 16 bit system, 2147483647 on a 32 bit system, or 9223372036854775807 on a 64 bit system.

For a 16-bit system, to define 32767 definitions requires typing at least (`-DC ` assuming you keep using the character C so you don't run out of unique 8-bit characters) 4 * 32767 = 131068 characters (which is ~128KB of RAM).

For a 32-bit system, to define 2147483647 definitions requires typing at least (`-DC ` assuming you keep using the character C so you don't run out of unique 8-bit characters) 4 * 2147483647 = 8589934588 characters (which is ~8GB of RAM).

For a 64-bit system, to define 9223372036854775807 definitions requires typing at least (`-DC ` assuming you keep using the character C so you don't run out of unique 8-bit characters) 4 * 9223372036854775807 = 3.689348815×10¹⁹ characters (which is ~32EB of RAM).

Unless any of these systems uses mapping to allow more memory than the processor can address, I think this is a non-issue. If not, then tell me how best to fix this.


Comparison Operators missing -In, -NotIn and case-sensitive variants.


I'm just curious, what's the reason of this change ?


Will not be updated to lollipop then?


while this shouldn't be necessary, clearly we've got some bad data in the trees table some how. A NULL parent_id should in fact indicate a proper top-level mode of a collection, so I think this fix is a good one for robustness, even if it's not the usual case.


Found BROKEN by full.


I think you can cut out `RSpec.` in favor of just `describe`.  Additionally, the `context` should be `#generate`, but I'm just being a bit pedantic!  :wink:


Thank you so much. This is extremely helpful!


FYI, you're missing a closing `>`


Mmmh... But this is the "new" style of doing things in RSpec.


Superfluous newline?


Oops, sorry. I guessed I said/wrote it too much.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Scoping the `svg_string` on the pattern object doesn't make sense here.  We should implement `==` on the `SVG` class instead of mocking that behavior here.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/474
success: http://build.servo.org/builders/linux2/builds/473
success: http://build.servo.org/builders/android/builds/509
success: http://build.servo.org/builders/mac1/builds/690
success: http://build.servo.org/builders/mac2/builds/691


:+1:  :)


This might be useful enough to expose as a command line option for developers who want to fast path, but maybe not worth doing right now.


@trbs +1


I don't see an easy way to separate the display for prenatal section and the clinical symptoms section.
Meaning that if there are phenotypes present in either, the error will be displayed for both.
Is that ok?


Should be `this`?


Dropdown assignee list will now fill the height of the "subcontent-wrap--outer" div when expanded.
![screen shot 2015-01-08 at 11 39 57 am](https://cloud.githubusercontent.com/assets/1305122/5667154/21907d00-972b-11e4-8901-e639d2dd2a04.png)


This doesn't seem like we're accurately testing the behavior here.  What if some pattern generated a color that was the background color, but wasn't actually used as such?  I think we should focus on an implementation of `SVG` that isn't just wrapping a string, but instead knows properties about itself.  https://github.com/aseldawy/rasem looks promising here :)


Should be `\code{TRUE}`


@CarlAmbroselli muito massa que você esteja usando o Ambe, porém para eu aceitar seu PR preciso que você mantenha o padrão do projeto e que tire esse arquivo do seu commit.


If we're moving towards building the docs as part of the build and making this work more broadly, people need to be aware of these platform differences. If you want to buy a Mac (or teach people how to use Linux) for everyone who uses Julia, be my guest.

I'll fix this at some point if it ever breaks my source build.


Could you please also add a bullet point to NEWs and then submit a pull request?


Oh thanks!


@PixelGuy75 yes


Again, see my comments about implementing `==` on the `SVG` class itself.


Ah, I see -- I didn't know this!  Actually a fan, considering it scopes RSpec's DSL and doesn't pollute the global namespace.  :cool:


This code looks familiar, it would be nice if there was a central function to merge this, ofwbus_setup_dinfo and simplebus_setup_dinfo.


@borshop: retry


Please adhere to naming conventions. Please also change string content to be "Average Test Run Duration"


The all value fixed it and jqui loads correctly


thank you :)
btw. nice mod :+1:
hope you can fix the issues regarding AE2 ;)


fast-forwarding master to auto = 3d9200e4


@sibomots I'm not sure whether you got me right.

No i did not meant the creation of the task.
In the creation process I totally agree with you that the interval shouldn't be `Optional`, when creating a repeating task.

I was referring to the `Task.getInterval()` method.
A repeating task is executed every <interval> ticks.
A one time task is not repeated -> it has no interval (absence / null != 0). You represented it as `0`, but it could have been `-1` as well, because it does not make any difference at all. It's a magic value, that indicates the absence of the interval. The `0` could also be "all the time" (execute it immediately again when it finished the previous execution). In contrast to this method we are currently using `Optional` in (almost) the entire API  to indicate whether something is/can be absent.

The `Scheduler` has a method `getScheduledTasks()` for all the returned tasks you don't know whether the are repeating and IMO checking the existence of an interval with `Optional.isPresent()` is more straight forward than <1.

If you don't change it, please add some javadocs, to the method that state, that `getInterval() == 0` states the absence of any interval / the task will not be repeated.


Test initial


Cool thanks. Do we build shared libraries for ios?
With my adjustments to `CORE_SYSTEM_NAME` we might be able to use that instead of `OS` but it doesn't really matter to me.


The array has a size of MAXPULSESTREAMLENGTH,
i assume that the index can only run until MAXPULSESTREAMLENGTH-1
In addition i think we do need to adjust in libs/pililight/protocol.h
within the the protocol_t structure the size of int raw[255].
I think we can leave the size of int binary[128] and do not need to modify it,
but we do need to pay attention for code that assumes that the size of the binary array is half the raw size.


Cheers


I would suggest to use `<=>` + `include Comparable` instead.


This looks great to me.  Two minor concerns:

1) We have no way to turn off compression support on the client.  Normally we would turn it off on the server. The only scenario where I see this being problematic is if we are doing DDP to a different (3rd party) server, and that server uses compression in a way that exposes a problem with the client.  I think this is unlikely enough that I don't think we need to worry about it .

2) Do we need to update the devbundle (any new binary dependencies)?

Otherwise looks great - excited to try this out!


asasasas


And again:

```
error: Could not read 094be7534c611312a46d9c54171d932464179f1d
error: Could not read 094be7534c611312a46d9c54171d932464179f1d
error: Could not read 094be7534c611312a46d9c54171d932464179f1d
Already up-to-date.
```

I'm presuming it's just me running into this, but I'm not sure why. I did a hard git reset to check I hadn't screwed anything up.


This commit breaks em-websocket on windows ruby 2.0+


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/899c9429d0095086ca1575bddef840af48407de1


merging pcwalton/servo/pointer-events = 899c9429 into auto


pcwalton/servo/pointer-events = 899c9429 merged ok, testing candidate = a88e6680


Yeah, call it only once in the `PomMergeDriver` if and only if it was modified (so you'll need the rules to return which poms were modified)


saw approval from russelldb
at https://github.com/basho/eleveldb/commit/074949b214c5fe6840e93ebfbf066537d3168e71


merging basho/eleveldb/bug/rdb/doc-gen = 074949b2 into borshop-integration-132-bug/rdb/doc-gen


basho/eleveldb/bug/rdb/doc-gen = 074949b2 merged ok, testing candidate = 10fcb78a


This method seems in need of a refactoring, but I'm not sure what.  Any ideas @maxmeyer?


cflags is not defined here. The proper reference should be CFLAGS.


Yes.  I thought about doing so in the context on this pull request, but there was already so much change I decided against it.  This behavior is already disabled by default so leaving it in place a while longer shouldn't cause us any trouble.


Just noticing this now - but this magic value is used a lot.  Perhaps we can promote this to a `let`?


I think is better add a function SpeechManager.enabled() returning False if the check is false.
Then, in sugar, you only need do:
```
+    if not manager or not manager.enabled():
+        return
```

Here, check_modules(),  has_espeak_module() and HAS_GST should be private.


+1 this is cleaner


@mtwebster the biggest difference IS that it isn't modal, at least where the text entry is concerned. If the sticky note were modal, there probably wouldn't be an focusing issues, because the modal code handles the stage input mode mode quite nicely, but since making the sticky notes modal would make them behave oddly, it means I couldn't use the "FULLSCREEN" mode, as IIRC this would make non-cinnamon objects unresponsive. This isn't the first time I've had to fix a focus problem, but I don't know a better way to do it, as the "NORMAL" mode doesn't seem to work with clutter text entry.


Any suggestions on how comparing generated patterns? Implementing `<=>` on `PatternGenerator` as well?


This was preventing binary uploads from working; if any part of the request is unicode the the whole request is attempted to be encoded in local encoding (usually ascii)
the ui_path was becoming unicode due to a returned id from trello being unicode, once appended to base_ui, ui_path was unicode.


whoa this is weird. in npm and asp.net vNext, the dependent specifies if it's needed for development or not. Is this to get around the AppVeyor issue?


@japamment, I know it's a bit of a pain, but I think the repository should only be modified via pull requests instead of pushing changes, so that others can verify and/or disccuss the changes.
https://help.github.com/articles/using-pull-requests/
Would that be acceptable to you?


Hmm.  I thought snakeyaml was calling `rule.setStrategy(String strategy)`, which allows you to do `strategy.toUpperCase()`.

Is snakeyaml doing direct field injection?  (instead of calling the setter?)


From the device trees I've seen the only children of the GICv3 device are ITS. I would prefer the parent doesn't restrict which children it allows as if, for example, a future revision of the GICv3 added some other child type we would need to then add support here which could easily be missed.


This comment seems wrong.  Why isn't this the version of the deployment config?  You already have DeploymentPodAnnotation.


I think this should do it: https://github.com/django/django/pull/3863. The issue was that `get_cache_key()` has side-effects (setting cache keys) and those weren't cleaned up between tests.


You can do _change_image(-1) here and remove:
+            self.make_button_sensitive()
+            jobject = self.image_list[self.current_image_index]
+            self._object_id = jobject.object_id
+            self.read_file(jobject.file_path)


Let's change `xz` to a valid pattern name, so we can more tightly test what this `it` is trying to assume.


Thanks! No rush, I'll keep an eye out and reopen the Homebrew PR when you have something ready.

On an unrelated note, why disable issue reporting for this repo?


Here too: self._change_image(1)


In terms of the "why would I tell you that", even though it was pointless you should not change somebody else's WIP code without their permission.


done.


Shoot, knew I'd miss something


Good point, I'll reword this.


Mmmh... This method was a result of a refactoring ;-). It's a bit of redundancy in here.


Not a huge fan of adding a dependency on Cucumber for this small purpose.


r+


It's not in use, right? Was pulled in by [#5](https://github.com/eHealthAfrica/direct-delivery/pull/5#discussion_r22650119).


Put this in the `Configurable` interface as the only method. Modify all existing users to either include this method, or implement `ConfigurationSupport` directly. Can so something similar with a new `Taggable` interface, perhaps?


Must be `private`.


all tests pass:
success: http://buildbot.bos1/builders/test-eleveldb/builds/348


I don't get what is not fdt specific in acquiring #address-cells and #size-cells.
You are right that it is broken for missing properties but as far as I understand this is because fdt32_to_cpu() doesn't work properly here. Maybe we should fix fdt32_to_cpu() instead (or change it to be32toh). fdt_addrsize_cells() is being either misused everywhere and should be removed from FreeBSD or it is OK to use but should be fixed. OF_ functions seem to me like lower level abstraction that is why I wanted to use fdt_


ok tamer


MAMA I MADE it thats it its global now

you must change the global var usePID to true in the CLIENT program if you want to use the PID.

@danielgrimshaw
@ZachOhara
@zachw000


Was waiting to see were this project https://github.com/derekparker/delve was going, Being able to attach to a running process would eliminate the need for a special command to revel


It's great. :+1:


OK


Why do we run a newer form of the test om older clusters?


sad


@rclayton why don't you accept this pull request and then I'll follow-up with another one that adds the license and updates the groupId to "io.github.fallwizard".


I made the validations more readable.


*"Raw"* всё же скорее *"сырой"*, чем *"чистый"*


XZPattern? It needs to some kind of "unknown" constant.


@erichs Passes, created a new failing test. TAG


This leaves me with

svnversion: Undefined variable.

when running submit.


sure, sgtm.


No objections, thank you.

best regards,
Kirill
On Dec 23, 2014 1:56 AM, "Roger Kapsi" <notifications@github.com> wrote:

> Cool. Any objections to change it to?
>
> Map<Key<?>, Binding<?>> dst = new HashMap<Key<?>, Binding<?>>();
> do {
>   dst.putAll(injector.getBindings());
> } while ((injector = injector.getParent()) != null);
>
> return dst;
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fkirill/jersey2-guice/commit/059c9f17a04e3a3b980e1bf5b6c3e5c94c437544#commitcomment-9070381>
> .
>


@Mamaduka I think something went wrong here.. Now the message is always displayed even when the user has the field filled in.


@mwjames what about changing padding to ´padding: 0.5em;´ to allow a more compact view?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1091 of 1091 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


No, I refused to use it in Java because it's stupid. But as a concession I tend to follow the same pattern that is in use in whatever source file I'm editing just to avoid the argument. This one was inconsistent obviously.


Just merged it.  We should think about a breaking update that changes the package names as well.  Call it 2.1.0?


Yes, that fixes the problem. It's basically the kind of problems I faced fixing the issues with --reverse, things that were set and forgotten to be unset.


=> `map.addLayer([ayer);`


        m <- NULL
        set <- function(y) {
                x <<- y
                m <<- NULL
        }
        get <- function() x
        setmean <- function(solve) m <<- solve
        getmean <- function() m
        list(set = set, get = get,
             setmean = setmean,
             getmean = getmean)


Wow, this has become THE most said sentence since the announcement of Laravel 5.

Ohh this and that ---> very simple to integrate, but was dropped of the core...


Why can't we provide the new `time`?


I maintain issues for my projects in a different issue tracker. I should add notes on reporting issues in the `README` and/or add a `CONTRIBUTING` file.


We use PrioritizedTicker, right?
From briefly scrolling over the current code, PrioritizedTicker doesn't create any threads. It shoves stuff into the Executor to create threads. So it doesn't make any sense to me that the Executor pushes back stuff to the Ticker in order to create a thread, and the Ticker does the same.
It is possible that the booleans passed around prevent infinite bouncing, but I don't get the point of the whole of this mechanics. Admittedly, I didn't read all of the code. Someone ought to investigate this though.
Posting it to IRC as well...


first commit


Here i could make a comment on the Harpers magazine article.


absolutely, this will have to be refactored.


thanks, keep on the good work


Fixed in https://github.com/ibm-js/deliteful/commit/a45046d52db80b11bc70bd59943d75058fa46f71


Another possibilty would to move the cli stuff to separate gem which depends on `geo_pattern`. Something like `geo_pattern-cli`. I just added it to test the commandline usage together with aruba.


DeploymentAnnotation is an annotation on a deployer Pod. The annotation value is the name of the deployment (a ReplicationController) on which the deployer Pod acts.


It is part of the test matrix defined in https://docs.google.com/document/d/1wwh569PwAWvEZcLc0gHSrO1xr-N-T5cnKjepjc0dXvI/edit#heading=h.20sqp7sxyy7q (build version HEAD + cloud provider GKE).

This would be much cleaner if the tests were sever version aware or if we had server capabilities (#2953).


DeploymentPodAnnotation is an annotation on a deployment (a ReplicationController). The annotation value is the name of the deployer Pod which will act upon the deployment to make it effective.


good catch!


        m <- x$getinverse()
        if(!is.null(m)) {
                message("getting cached data")
                return(m)
        }
        data <- x$get()
        m <- solve(data, ...)
        x$setinverse(m)
        m


Well spotted and an elegant fix :)


энтузиастов


all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3071
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3064
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3065
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3056
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3056
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3059
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3052
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3047
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2724
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2722
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1560
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1552


fast-forwarding master to auto = a8a210b5


Well, I used the create_pot script which didn't take care of those translations as it is in policykit file.


This is my favorite part. :heart:


mw-standard `editpage-copywarn` comes with `padding: 1em` therefore `padding: 0.5em;` would look rather squeezed compared to the bottom.


LIQUIFY := true on BoardConfig.mk


Yes, I remember we put AddonPermissionsTable on the global scope so that it could be initialized in addon_permissions.mako. But with this change, it is initialized in addons.mako.


Main — это специальное имя


Would you mind if I leave as it is till one came up with a good implementation of SVG-class? Maybe merging stuff and then fixing the "quality" of the tests. Better having not so good tests, than having none, I would say. I fixed stuff at different places in 3 PRs. I don't want to loose the overview and don't want to rebase/resolve merge conflicts at to many different places.


Ага, а теперь смотри как у тебя будут проходить миграции с таким кодом:

Ты разворачиваешь проект, создаешь базу и вводишь `rake db:migrate`. Проходит миграция на создание листингов, то есть этот файл, в ней создается текстовый атрибут `event`. Потом дело доходит до файла `db/migrate/20150108132138_rename_column_in_listings.rb`, код внутри которого описывает, что нужно в таблице `listings` переименовать атрибут `sobitie` в атрибут `event`. А атрибута `sobitie` нету. Происходит ошибка и миграции не проходят, откатываясь к пустой базе.

Есть идеи, как сделать правильно?


What was the original point of calling this "Prioritised"?
It doesn't set any priorities, does it? It probably respects the passed Runnables being PrioRunnable if you use an Executor which follows priority of PrioRunnable. But this solely depends on which Executor the given Node is using.


Either way works


Main — это специальная функция


Fair enough. Thanks for the info!


Yeah, I think we should move ahead with this PR and address the larger issue separately.

Thanks,Taylor Blau

http://ttaylorr.com

On Thu, Jan 8, 2015 at 1:16 PM, maxmeyer <notifications@github.com> wrote:

> Would you mind if I leave as it is till one came up with a good implementation of SVG-class? Maybe merging stuff and then fixing the "quality" of the tests. Better having not so good tests, than having none, I would say. I fixed stuff at different places in 3 PRs. I don't want to loose the overview and don't want to rebase/resolve merge conflicts at to many different places.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/maxmeyer/geo_pattern/commit/2beea692bf42474509e1c1c6a9879d5bd7ac1bee#commitcomment-9206566


Пробел перед закрывающей конструкцией `%>` забыл


переменную


Presumably this particular override is needed even once mtl and xformers are updated. Do the ghc-specific configurations "stack" with the common one?


jk

would it suffice to change the julia path to `$(JULIAHOME)/usr/bin/julia` instead of w/o the `usr/bin` bit?


I guess it'll work:
![screen shot 2015-01-08 at 12 12 37 pm](https://cloud.githubusercontent.com/assets/1305122/5667811/55e67906-9730-11e4-93c0-8a91cc9f9787.png)


This looks very nice - give me some time to take a closer look.


Функция, имеющая


Ok, add an annotation for the deployment number and use that on the replication controller.  I want each RC to have "deployment"="1" as an annotation for maximal clarity for end users.

----- Original Message -----
> DeploymentPodAnnotation is an annotation on a deployment (a
> ReplicationController). The annotation value is the name of the deployer Pod
> which will act upon the deployment to make it effective.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ironcladlou/origin/commit/0eb02342983df5fddb3b9f0ca9e9642a53fff9a6#commitcomment-9206503


Ты прочитал про то, как вернуть все как было, если захочешь сделать `rake db:rollback`?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/475
success: http://build.servo.org/builders/linux2/builds/474
success: http://build.servo.org/builders/android/builds/510
success: http://build.servo.org/builders/mac1/builds/691
success: http://build.servo.org/builders/mac2/builds/692


@ajlennon Hi Alex, I tried further fixing it, but your appveryor setup is ws2ipdef.h that includes sockaddr_in6.

Could you check where that's defined in your toolchain?


The git-plugin 2.3.3 and later includes this change


> это алиас
Может псевдоним?


Before merging, please explain your reasoning behind this line, since the Constructor does not accept db and collection name.


saw approval from aturon
at https://github.com/nikomatsakis/rust/commit/a661bd6575dd3fac17cf77fdea8b76ca790ac212


merging nikomatsakis/rust/int-feature = a661bd65 into auto


status: {"merge_sha": "81e6142030bc9a648a83ebb2333e38a831e5de16"}


nikomatsakis/rust/int-feature = a661bd65 merged ok, testing candidate = 81e61420


Yes, since `Cmd` interpolate into `Cmd` the way you want, it's a good way to build them up incrementally.


A gem turbolink não permitia que o show fosse exibido corretamente em dispositivos com tela pequena. É necessário investigar isso com mais cuidado para voltar a utilizar o turbolink.


It should either be made static and only used within the one file, or fixed and moved to dev/ofw/ofw_bus_subr.c. In the latter case it should be prefixes with ofw_.

It's broken because it uses OF_getprop and fdt32_to_cpu when it should be using OF_getpropenc. If, for example, the #address-cells property is missing, it will set cell = 2, then pass it thought fdt32_to_cpu. This may then change the endian of the value.


fast-forwarding master to auto = a88e6680


The code has not link for "RUN" action and process.


Fixed in fbb7abdc9cefeaee0e2cfb0dadd162452a5c207e


Hi Oliver!
Why did you change this? '3373' is not working for me while '3372' is...
Regards


I'd like to add that annotation/value to the RC's (for bonus use by clients), but not use them for any internal behavior at this point. Acceptable?


That's fine - it's really for clients and users.

----- Original Message -----
> I'd like to add that annotation/value to the RC's (for bonus use by clients),
> but not use them for any internal behavior at this point. Acceptable?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ironcladlou/origin/commit/0eb02342983df5fddb3b9f0ca9e9642a53fff9a6#commitcomment-9206696


\>More awkward naming sense
AHHHHHHHHHHHHH :ghost:


> 64-х битное число

[64-битное число](http://www.gramota.ru/spravka/letters/?rub=rubric_99)


@roconnor next test of your wisdom: Any nice way to "inherit" scopes? e.g. `amazonka-core` is built with a scope where `transformers` = `transformers-4`, can I make it so that anything that depends on `amazonka-core` has that same `transformers` = `transformers-4` scope by default?


saw approval from jdm
at https://github.com/ebalint/servo/commit/17a0c54ce5cf88a041ea5a92102dc27a560cdb88


merging ebalint/servo/canvas = 17a0c54c into auto


ebalint/servo/canvas = 17a0c54c merged ok, testing candidate = fe3b2a55


some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1561


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fast-forwarding 2.0 to borshop-integration-132-bug/rdb/doc-gen = 10fcb78a


I don't think we should merge this as I like my drawables nice and hi-res!

What say? @pcarenza @frap129 @ljjehl


Would it be possible to detect the presence of subqueries just by creating a method on AbstractParsedStmt that examines its member m_joinTree instead?  It seems like overkill to add a new member to AbstractParsedStmt only to do this check.  Most statements won't be used in a view.


It seems like in case of multiple plugins, this would end up saving the same plugin multiple times to config.json.


TeamManagement should have a space. -.-


Using getAlert would be more consistent here, but not a big deal.


Why are you looking at old code? The current code does the same thing, but is in a different location: its at line 344 of PatternMatch.cc

The philosophy of the pattern matcher wavers between two different design points.   The first, original design was that it should provide function, and not set policy.  That is, functionally, it should be able to compare any pattern to any other pattern.  But users always want policy, and so the policy is supposed to be implemented in the callbacks, which are supposed to accept or reject matches based on specific policy criteria.  So that's the main split: a policy-free functional pattern matcher, and a set of specific, tailored policies in the callbacks.

VariableNodes were invented only later, to simplify the specification of the pattern.  Again: in principle, any type, node or link could be considered a variable, or a constant, and the callbacks should decide which is which and do as desired.  In practice, no one was interested in this general capability. Thus, to simplify pattern specification, the variable node was invented.  The variable node is meant to be a convenience *to the user*, only.  The pattern matcher does not need them, and can work happily without them.  Variables are policy, not function.

Unfortunately, this clean split between policy and function has gotten blurrier and blurrier.  checks for variable nodes have crept into the engine; they really should not be there.

Conversely, there are some left-overs of the general approach in other parts of the code. I think that you discovered one of these.  So the short answer is: a) I don't remember and b) if you remove it, do any of the unit tests break?   The pattern matcher is very heavily driven by unit tests.  If you don't break one, then it is a safe change.


Oops, thanks for cleaning this up. I just had one of those moments when, a day or so after making a commit, I suddenly realise at a random moment that there might be an issue, then saw this commit :)


Updated the comment.


I think actually we could stick to the default OS, but install the 2014 runtime dynamically (this makes sense too in terms of documenting what users will need to run things)?


Overriding "time" is very hard. Many low-level core packages depend on it, like "unix", "directory", and "process". You have replace all of them to build with a non-core time library. I tried, but I ran into tons of errors during the build process.


r+ p=10000


I've used it for quite a few builds and I personally haven't noticed a difference except when I placed them side by side, but that could also be the fact that my GS3 is 720p and my OnePlus One is 1080. While modern phones have enough storage, processing power, and ram to load apps quite quickly, 70% compression makes it load much much faster.


Why did you change this?


nice, thanks! I thought it is something that uses plone-uuids.


Is there any need to check element validity? Eg, alert.checkIsValid().


saw approval from alexcrichton
at https://github.com/brson/rust/commit/1f70acbf4c4f345265a7626bd927187d3bfed91f


merging brson/rust/feature-staging2 = 1f70acbf into auto


status: {"merge_sha": "544a45aee98eeb1531813a091bc9bc90a1e5bcff"}


brson/rust/feature-staging2 = 1f70acbf merged ok, testing candidate = 544a45ae


Yes, they do. Common ones are applied first; the compiler-specific ones go on top of those.


в def up записать что меняем на event
в def down записать что это раньше было sobitie
так наверное


I guess I'm still not sure I see the issue with having them behave as normal cinnamon modal actors (of course I haven't worked on the applet as long as you, so I'm just talking) - iirc we go to fullscreen mode when we pop up a menu, like from an applet.  Clicking anywhere else breaks that mode.  This is what we want I think.

Would it be helpful to make some sort of widget type that would basically emulate a popup menu's grab/modal behavior, but not actually *be* a popup menu?  I mean, it could be any type of actor really.  Instead of you having to include all of this in your guys' applets and desklets, you could just subclass this 'special' actor.  This could maybe help out with desklet behavior in general (which is still fairly buggy).  This would also place the responsibility of keeping things working on our side of the API and not force you guys to deal with it like this.

Again, I might actually *look* at some of this later and go, wtf am I thinking? This would never work... I'm just spitballing...


@azaytsev let's move these Safari based tests to iOSTest.java


Why desc has +1 tabs indentation ?


определение


Done. But I've not updated this usage with using, as there's other work to be done in the finally.


I know this isn't your code, but seems like using an indexer here is awfully fragile.  Just a thought.


Good. Annotations are an awkward, un-intuitive anti-pattern piggybacked into the core language as a 3rd party pseudo-language, and a silly abuse of reflection. annotations that affect 3rd party code generation tools are fine (PHPDocumentor etc), but annotations that affect code execution is abuse.


> i assume that the index can only run until MAXPULSESTREAMLENGTH-1

i shall fix that indeed. Small mistake :smile:

> In addition i think we do need to adjust in libs/pililight/protocol.h

Did that ofc locally. Must have forgotten to commit it.

> I think we can leave the size of int binary[128] and do not need to modify it,
but we do need to pay attention for code that assumes that the size of the binary array is half the raw size.

Letting it relate to the `MAXPULSESTREAMLENGTH` is the best way.


We should use alert.waitForInvalid() here, at least according to the api docs.


Need `:param:` and `:raises:`


I think we need this line to add in the scopes for `stories.published.visible`, just not the paging.
I'll add it back.


Looks good


80309490-VRFTable (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2063 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.28702010968921%25-yellow.svg)


@kumpera I don't think including ws2ipdef.h is the way to go, MSDN explicitly says:
"Ws2ipdef.h header file is automatically included by the Ws2tcpip.h header file. The Ws2def.h and **Ws2ipdef.h header files should never be used directly.**"

I guess including Ws2tcpip.h should be the correct fix?


80309490-VRFTable (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


It is possible to customize `build_prefix` and/or `build_bindir` (some distribution packagers may do such things), but that may not be well-tested across all platforms. And `doc/Makefile` isn't including `Make.inc` at the moment since it hasn't yet needed to. That would likely be the most robust thing to do - assuming there aren't any conflicting variable definitions in there.


Finally, we are not doing the data entry job right. We are developing the product. Don't harrash me on such things.


what about calling `checkIsValid`?  May only be relevant if we're concerned about stale refs, tho.


вывод


Yeah I'm running into that now. Damn.


I hadn't updated these as I wasn't sure what our policy was on internal fields (vs public, which would be pascal cased, or vs private, which would be _ prefixed).  Either way these (and those on some of the other existing types) should be fixed.  I'll go with _.


Why not just kill this if-test, then?


some tests failed:
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3073
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3058
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3049
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1562


Same stupidity here too?


I tried to dig it down but the behavoir is really strange. If i add the strategy snakeyaml uses the default constructor and than the set method to set the value. If i don't add the strategy to the ruleset file, snakeyaml is looking for a constructor with exact one argument !?!  I didn't really understand that code part :-)


thanks, noted.


ok ... sure .... thanks :)


Good, the less magic the better IMO.


Do you think this look awesome array. Need to be beautiful. We are not doing client project where we can do anything that works. We are developing for our reputation?


I have made a search on my whole script, and  i don"t use the "generate" function in my parent project.

I will update the exemple to reflet the new usage. (sorry if the repo is a mess, i'm not very familiar with the git concept ...)


I think I'd prefer web-api over web-service for this kind of thing; as web-service is more generic. (Technically googel calendar is a web service)


I'm not sure, but iirc Memphiz said static wouldn't work. Since pic is supposed to be the issue here, static is not of much use anyway as it'll fail without pic. Unless darwin does something differently.

And this patch is only a quick bandaid, I plan on doing this properly, e.g. by adding it to kodi-config.cmake. For now, I'm hoping this fixes the build.


Why track nvidia audio and tegra124 ?? they are empty


This whole block looks weirdly wrong to me: Why isn't it just returning `makeRoughnum(1)` and `1`, respectively, instead of adding 1 to whatever kind of zero `y` is?  According to the Racket docs for `expt`, when the exponent is inexact-zero, the result is always inexact-one, and when it's exact-zero, the result is always exact-one.


we also need to adjust init.pp line 436
```
  $gr_apache_24                          = $::graphite::params::apache_24,
->
  $gr_apache_24                          = $::graphite::params::gr_apache_24,
```


I realize you're following an establish pattern, but isn't
```js
autoDismissAlerts: this.args.autoDismissAlerts && this.args.autoDismissAlerts !== 'false',
```
much more straightforward?


How similar is this file to sys/arm/arm/busdma_machdep.c? Could we just use the same file on both?


Can we use a waitForElement func here?


I would still include this patch, although maybe call the command "gdb" or somethig like that...

gdb is a tried and test tool..


Hope this gets an official replacement at some point. In addition to what others have said, this was also useful for date format normalization.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


waitForElement?


Same here and below.


Few questions inline.


Do i miss something? The POM tracks the state by himself in the variable *changed*. The first guarding clause in savePom() is:
```
 if(!changed)
        return;
```

So if nothing is changed, the pom will never be written.


saw approval from alexcrichton
at https://github.com/alexcrichton/rust/commit/7541f82faba6b2839b5e640605d7caab6cc6ec4f


merging alexcrichton/rust/rollup = 7541f82f into auto


status: {"merge_sha": "00b112c45a604fa6f4b59af2a40c9deeadfdb7c6"}


alexcrichton/rust/rollup = 7541f82f merged ok, testing candidate = 00b112c4


I know this was used previously (and I think it must still be cleaned here and there in some modules/.py file of shinken), but:

Please avoid "from xxx import *"  :

* Because it puts a lot of stuff into your namespace (might shadow some other object from previous import and you won't know about it).
* Because you don't know exactly what is imported and can't find place from what module certain thing was imported easily (readability).
* Because you can't use cool tools like pyflakes to detect statically errors in your code.

( http://stackoverflow.com/questions/2386714/why-is-import-bad )


I agree with Ben, the `add` stuff all over the place confuses me.  It seems inefficient, too.

Though I'm not sure we're trying to copy Racket in all cases, what their docs does seems like the sensible thing to do in this case.  Is that what the `add` calls are accomplishing?


LGTM. Thanks for refactoring!


Prevent me from tracking your stupidity. Be on the right track. Hope this comment help you learn more.


otherwise:

for non-trivial changes (docs, typo, etc..), please always create a dedicated branch..

otherwise we risk getting errors in tests , at it resulted here, that could be hard to fix afterwhile and so leave an unstable master..


Looks good


Oh, it's not of any specific length! They can be longer if the sub-process adds a prefix - which compute does - but the length is not defined - it is supposed to be treated as an opaque string.


n/p, sounds good to me.


rax retry tests


Can we add an explanation of what a DIY Quantified Self Portait is? maybe with an example?


replace with github content


ISTM that the add(y, 1) does an automatic casting of 1 to the appropriate level. Otherwise, you'd have to explicitly specify what type of 1 is being returned.


I don't think I've ever seen AtomicReference extended.  Is this some to-the-metal performance trick, or something that should be a has-a relationship?


@nikhilkh Thanks for review :+1:


okay we should get rid of these nasty magic numbers, then.  it looked like the deferred result fills the element, so I'm not sure why this is necessary.


OK.

BTW. So what you are saying is that FDT code is somehow deprecated and is kept there because some stuff is still in use (like fdt_regsize(), fdt_get_range() in UART code) ?


If you had read the thread, you'd know the answer.


(ps also fix text input)


But this change has nothing at all to do with server version - it is testing an implementation detail of kubelet.


Oh. Hah.  You're right.  I forgot about that.

Since this is the case, you can remove some of the logic in `ProjectAndParentVersionRule` that checks for changes


And now you get to merge it~


Ok, that was my fault. I will revert everything. Because this just means that you renamed the internal used variable from apache_24 to gr_apache_24 (which is an parameter)

I didnt checked this at first.


This breaks the tmux-rails script for HOL; it can't start the tmux server with this in here


Thanks :sweat_smile:


Just wondering if you have a specific use case in mind for this addition? The `hidePopUpViewAnimated` is only ever called manually, therefore you shouldn't need to be notified before the animation takes place. You can just perform any actions you need to before calling `hidePopUpViewAnimated`.

Please let me know if I've overlooked something here.

Cheers,
Al


@Pross - thanks for the PR but if possible can you fix this http://cld.wthms.co/1fDdP


For substitutions, the fix is simple. I'll add a commit shortly after further testing

```php
if ($subs && isset($subs[$class]) {}
```

isset bizarrely returns false if the key is set but the value is null ( http://php.net/manual/en/function.isset.php )

changing isset to array_key_exists will allow:

```php
$rule = new \Dice\Rule;
$rule->substitutions['B'] = null;
$this->dice->addRule('MethodWithDefaultNull', $rule);
$obj = $this->dice->create('MethodWithDefaultNull');
```


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


That's still a hack. Why don't you check the actual ontology?


Did that allready :)

2015-01-08 19:49 GMT+01:00 Phil Clay <notifications@github.com>:

> Oh. Hah. You're right. I forgot about that.
>
> Since this is the case, you can remove some of the logic in
> ProjectAndParentVersionRule that checks for changes
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cecom/pomutils/commit/32a376bda0f3ceed0682d2d5a07058e6783058d7#commitcomment-9207086>
> .
>


First of all, a buffer object cannot be passed to `write()`, nor can a `bytearray`, so my suggestions weren't really helpful.

Hopefully, this one is better:

I found a little hack that would allow using sequences of integers and byte objects as input to `write()`, in both Python 2 and 3.
It needs 2 changes:

* the declaration of `jack_ringbuffer_write()` in the `ffi.cdef()` has to be changed from `const char* src` to `const unsigned char* src` (or `const signed char* src`).
I hope this is safe, but I don't know.

* `ffi.dlopen()` should be used instead of `ffi.verify()`, because the above manipulation triggers an ugly warning: `warning: pointer targets in passing argument 2 of ‘jack_ringbuffer_write’ differ in signedness [-Wpointer-sign]` (or we should find a platform-independent way to disable the warning)


lets see what comes out - but just for clarification - we link statically other stuff on ios too nowadays ... so in general it works ...


Ok thanks for you work!


Can I infer from this you are happy with the corresponding userland change?


I created a new PR (#3171) which includes a test for the fix proposed by @Hypercubed

@pkozlowski-opensource @karianna @RobJacobs @chrisirhc
Who else should participate to such a meeting? Could you PM me at: antoine_DOT_pairet@gmail.com with your timezone so I can organise a hangout.
thanks in advance


... or "`unsigned char[]`"?


NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
;_;
bakape a jerk!


Removed the dead code.  (BTW, it *looked* dead even before the roughnums were added. Was being conservative in not outright removing it, as I wanted to postpone changing something that wasn't operationally broken.)


Minor, but shouldn't @Override still be on a separate line? Not sure if that is a formatting issue with the formatter.


Really? It is? Oh god, I never knew. Now I can make AutismRP..
Jokes aside, thank you for the update :)


LGTM.


Yes, thanks, this should be moved.  I'm also looking into the existing Windows implementation, which looks odd.


Hello Tony,

It were the first changes which I made. I transferred mostly the settings from `jQuery.jqGrid.bootstrap-fixes.css` which I posted [here](https://github.com/OlegKi/jqGrid-plugins). Later I made many other tests under different conditions, included some other changes and reverted some other. You can see all the changes [here](https://github.com/OlegKi/jqGrid/compare/tonytomov:master...master). You need just scroll a little till the differences in `css/ui.jqgrid.css` (it's the second file directly after the first `build.gradle`). How you can see, the current settings have no more an additional `border-right: 1px solid inherit`.

I see that you added CSS `box-sizing: content-box` on gbox. I find this simple and very good setting. I will follow the way too.

You can see on [the demo](http://www.ok-soft-gmbh.com/jqGrid/OK/autoresizeOnDoubleClickOnColumnResizerWithShrink.htm) how the grid looks like in combination with `bootstrap.css` 3.3.1. By the way you can make double click on the resize between the column headers to see the new feature which I implemented.

I think that I need to review and revert some changed made in `ui.jqgrid.css`. In any way I want don't have any `!important` with exception of one which is really required.

By the way, try to add the footer in the grid and how it looks on your version of `ui.jqgrid.css` together with  `bootstrap.css` 3.3.1. One more problem (which I also not solved) is the color of top-border in searching toolbar.

Best regards
Oleg


Any updates?


More specifically:

    #if ($services.ontologies.hpo.size() <= 0)

This covers both "no core" and "not indexed" cases.


Right now we conflate {server version, kubelet version, kubernetes version} as pretty much all meaning the same thing. Any cluster deployed from a binary release will have consistent server version and kubelet version and this test relies on having a kubelet version newer than the 0.7.0 binary release.

If it's really an implementation detail, does it really belong in an e2e test? Or would it make more sense in a unit/integration test?


maybe some javadoc explaining why you added the Enum version of this method would help.
I see no real benefit to this method since there's no check on the actual Enum type... so simple strings would do and we have that already


@dkumor.  This function uses a staging buffer that is the size of the whole buffer to copy the coincidence tags into.  That way I only need to loop through the coincidence algorithm once.  After I know how many coincidence tags I have, I simply do a memcopy to the output structure and free the staging buffer.  It runs a little faster than "coincidencetimes_nd" where I loop through the coincidence algorithm twice:  Once to find the total number of coincidences.  Then allocate the correct size arrays.  Then loop through again to write the results.  My question is what is the best way write line 562 to get the size of the staging buffer?  I get the warning, " implicit declaration of function ‘TT_MAXDATA’ [-Wimplicit-function-declaration]" with is as written now.


r=mbrubeck


The error checking idiom I want to see goes something like this:

```python
try:
    d = subprocess.check_output(["/sbin/modinfo", "zfs", "-0"])
except subprocess.CalledProcessError as e:
    sys.stderr.write("%s: Command '%s' exited with return code %d\n" %
             (sys.argv[0], e.cmd[0], e.returncode))
    sys.stderr.write("%s: tunable descriptions will be disabled\n" %
             sys.argv[0])
except OSError as e:
    sys.stderr.write("%s: Failed to run /sbin/modinfo: %s\n" %
             (sys.argv[0], e.strerror))
    sys.stderr.write("%s: tunable descriptions will be disabled\n" %
             sys.argv[0])
```


BTW, the next CFFI release (0.9) will introduce a `from_buffer()` function which will be able to get a `cdata` pointer from a buffer object, see http://cffi.readthedocs.org/en/latest/.

With this, there would be no more need to return the "raw" CFFI pointer, right?


Agree. There are small differences here and there and I think no one will complain if we unify common part of the devinfo structure.


Thanks. I actually built it a couple days ago and installed it, just upgraded to the official release.  This resolves the issue I was seeing but now I'm hitting the timeout identified here: https://issues.jenkins-ci.org/browse/JENKINS-23476

Gonna see if I can make a quick patch for it, if it's a lot of effort I might have to go with a different approach.


Interesting.
* https://mail.python.org/pipermail/python-win32/2010-May/010547.html
* http://twistedmatrix.com/documents/current/api/twisted.python.win32.html#quoteArguments
* http://twistedmatrix.com/trac/browser/tags/releases/twisted-14.0.2/twisted/python/win32.py
* https://github.com/martine/ninja/issues/689

Your idea seems nice and simple, but if I push that change, we might have another iteration or two, since I don't own a Windows machine right now. If you submit something that works for you, we'll pull it.


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/475


That does the same, who cares?


no we are testing autodismiss.


oops sorry about the direct commit - I thought I was on my own fork. Can I revert it, or is it not worth it?


Lack of space before ')' makes it hard to read by the lame me


This should be using the promise we have above, so instead something like
```javascript

function (musicalWorksList) {
  return musicalWorksList.follow('prx:items');
}
```


:+1:

@jlem Totally agree with you


Try "If set to greater than 0, the index number of the earliest ledger for which to acquire."


Only added them because they exist in make file. I know they're empty @deadman96385


Perhaps a derived `<=>` here?  (Technically it's an isomorphism between `*->*->*->*`-types, but no polykinds, so eh.)


what does 'interchangeable' mean in this context? Since describe() returns a string, I think this constraint regarding the return value is too tight, or I am missing something


Wasn't thinking in that direction. Figured there should be an error message if it fails at all.

Would ```("$!{displayHtml}" == '' || $services.hpo.count() < 1)``` suffice?


This line should have been removed.


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/af7cf26e76f2a8d134680a0a0e1c2408173519b5


merging pcwalton/servo/outline-offset = af7cf26e into auto


pcwalton/servo/outline-offset = af7cf26e merged ok, testing candidate = 112ab497


#pragma aside,it looks good.


Ignore other refactors, here's where I changed the tests you wrote (I'm trying to move to one spec per `it` command)


Yes, in general new code should use the openfirmware code if possible. There are a few cases where we are unable to in the early boot code as the infrastructure they depend on may not have been set up.


It could maybe be a unit test but it would be pretty complicated.  Is e2e
not the right place to prove that complex interactions work as expected?

If someone wanted to fix this as a unit test, I could buy that

On Thu, Jan 8, 2015 at 10:59 AM, roberthbailey <notifications@github.com>
wrote:

> Right now we conflate {server version, kubelet version, kubernetes
> version} as pretty much all meaning the same thing. Any cluster deployed
> from a binary release will have consistent server version and kubelet
> version and this test relies on having a kubelet version newer than the
> 0.7.0 binary release.
>
> If it's really an implementation detail, does it really belong in an e2e
> test? Or would it make more sense in a unit/integration test?
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/GoogleCloudPlatform/kubernetes/commit/e045c6ce2fd81b85637894a1655a90bc367b90f7#commitcomment-9207203>
> .
>


Not sure, but would not harm. I've never built a test cases for invalid element.


One makes my head hurt, the other doesn't.


Yeah I forgot one.


this has the potential for NPE being thrown...


Just wondering if you this is done?


If there is an alert with no button we are screwed.


In this case, there are two different issues. We know exactly when the ontology isn't available, and the message should say so. On the other hand, if the display failed, it's an actual error. This should rarely happen, it usually does if the "predefined phenotypes" mapping is wrong (syntax error). That's something only mapping writers (admins) should see, and the message should be different.


I'm always nervous about modifying standard license files even though this isn't really a modification to the MIT license on Linguist.

Assuming this is OK then I'm :+1: but perhaps we should seek advice from legal?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang-Debug: OK (1091 of 1091 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Or should mk1mf.pl be updated to declare a static const char cflags[] similar to mkbuildinf.pl instead of using a literal?


Aright @zspencer I just split the two into separate entries. :bomb: :boom: 6b9cde9f947d4c878a35c76d082b1db653c63917


I thought I replied, but I don't see it, so I'll summarize. We need to satisfy this:

* http://msdn.microsoft.com/en-us/library/windows/desktop/bb776391(v=vs.85).aspx

Your idea seems nice and simple. If you test it, we'll pull it. I don't have a Windows machine right now.


This should be "_ahrs->get_gps().status() < AP_GPS::GPS_OK_FIX_3D"
In general it is a good idea to avoid assuming operator precedence issues, and either simplify expressions to avoid them, or add parentheses to make them clear. In the above case the "!" has higher precedence and ends up taking the logical negative of the gps status enum, which makes no sense.


@danielegenta Yes, this is a 'default feature' see https://github.com/blog/1932-syntax-highlighted-diffs (thanks @kevinkub)


same problem here


I'd suggest to keep python code in separate py script


Hum, not sure this part seems to work.


The last one is not actually true, e.g. log is concave.


be more verbose;


This one is a type, should be left unchanged.


Thanks @zenorocha! When I have a bit of time, I'll publish the builder on Maven Central and send a PR with the changes required to build the Go SDK from the Liferay repo :blush:


This one needs to te be added.


semi <-> >=


Nice find by cppcheck.  Thanks!


I believe this is just POC?
We do need some interface here, take a look to the
http://en.wikipedia.org/wiki/Command_pattern


Web API doesn't necessarily mean RESTful, I meant web service is a generic term that can mean a web application or a web api.


can this give division by zero?


@antoinepairet could please one of you guys send a http://doodle.com/ to find a slot for such a meeting?


Also this looks like we don't have a web-api entry?


@purplecabbage: yeah, that's the reason i didn't fix this months ago.

But I got tired of this bug and decided to at least do something.


Gonna want to revert this at some point. :)


Yes. (we are working on review to other changes on your branch too)


It is a performance trick often used for non-blocking data structures, in particular Multi Producer Single Consumer structures. Its used in [scalaz actors](https://github.com/scalaz/scalaz/blob/series/7.2.x/concurrent/src/main/scala/scalaz/concurrent/Actor.scala#L69), [Akka](https://github.com/akka/akka/blob/master/akka-actor/src/main/java/akka/dispatch/AbstractNodeQueue.java#L16), and netty [here](https://github.com/akka/akka/blob/master/akka-actor/src/main/java/akka/dispatch/AbstractNodeQueue.java#L16) and [here](https://github.com/netty/netty/blob/netty-4.0.19.Final/common/src/main/java/io/netty/util/internal/MpscLinkedQueue.java#L42). Other alternatives are to have a volatile field and use the unsafe atomic operations tools ([as is done in newer version of netty here](https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/MpscLinkedQueueTailRef.java#L28)) that ultimately underpin atomics. If this was a public structure, that would be the way to go as to not expose the atomic methods publicly.


that looks a bit verbose!


@S11001001 brilliant idea. Thanks.


Ok.
I'm still going to keep the java changes. ```display``` is never used in java; it should return something if it fails, and it shouldn't be a null. Are you ok with that?


Doesn't quite make sense to me to pass in end_selector if that is the target element.

Instead you can refer to this element inside the widget as $(this.element)


Thanks a lot!


Learn to read, I didn't blame him or anyone, I just sayd it's very old.

Yet I don't understand why would you keep useless new lines.


\lambda^-1 somewhere


lgtm


:+1: looks good to me.  Only question I have before merging this in is if we need any tests around `exhibit_search_*_url` methods and the behavior they introduce.

I don't think we have integration tests that will catch this breaking in the future, as was evident by the issue not breaking our build in the first place.


Like this or using some `default` helper would be better.
autoDismissAlerts: this.args.autoDismissAlerts ?  this.args.autoDismissAlerts : false;


This is from the skelton test, we must fix it


Timeout on clone can be adjusted in the job definition from the job configuration page. Timeout on checkout can likewise be adjusted there. Timeout on submodule update is not implemented.


this constructor is very dangerous.
Let's provide more constructors and have each of them implement a single branch of this code.

Also, some bit of documentation for the map.put('value') branch would be useful.


Пробуй более детальное описание комитов. Что исправил, что немного изменил и т.д.


I need to commit before go, so the current was good. I'm currently fixing the tests. But code is good, only tests must be fixed.


Additionally it is needed to pass some arguments to the command


If you put these variables into the scope of the defining function, then different instances of the widget will override each other's data. So you should move them inside the widget, either as local variables in the functions that use them, or as properties of the widget (this.*). As you have it now, it won't work reliably with multiple instances.


Sure, we can take that out. So do you think these should be in the same entry then? Thinking my quick fix now needs to move into a branch and PR...


(see above)


Feel free to move the second message outside to remove duplication.


this method is public but it returns an unmodifiable list? potential problems in the caller code...


this.inputclick();


80309490-VRFTable (kbenne) - i386-Windows-7-VisualStudio-12: OK (2169 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13162705667276%25-yellow.svg)


I think we need to add some array bounds checking to the autotest of the EKF. Perhaps include a sample log file in a libraries/AP_NavEKF/data directory and then run that log file through replay with bounds checking as part of autotest?
There are also some coding strategies that could be used in the EKF to make this sort of bug less likely. For example, it could have:
 memset(H_LOS, 0, sizeof(H_LOS));
in this case.
Or we could add an ARRAY_SIZE() macro.


You should define default options here.


80309490-VRFTable (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


> Not really. A lot of mods have "no redistribution" or "no alteration" clauses in their license.

A new mod that fixes the mod? Would have to look up the individual licenses, but that might be an option.

Anyway, generally ignoring the script bugs sounds like a bad idea. Yes, some of these broken scripts work as intended in vanilla MW. But we have seen already plenty that do not work properly as intended. So having them fail in OpenMW and drawing attention to the problem could actually be a good thing. Maybe the MW modding community needs a bit of shaking up and some additional QA.

But even without this point, supporting the original VM (either separately or via translation) sounds like a huge task and at least at this point I do not see how it could possibly be worth it. Unless this becomes epidemic and there is little support from the modding community for fixing their stuff, I would rather modify our mission statement a bit:

> Support all existing content, including Tribunal, Bloodmoon and all non-defective user created mods (in case they don’t use external programs)


I need to show you how to use interactive rebase to fold this sort of fix into an earlier patch before submitting the PR


Yes.


You are consequently avoiding the "this" context - why? The widget instance should refer to its own properties as this.*, e.g. this.end_date_automate(interval);


Clicking the "To csv" option only saves highlighted data in the selected directory.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2165 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.94881170018282%25-yellow.svg)


@adamstegman I'm not positive, but i think Alex has deprecated the "<<:" syntax.


it would be nice to add some enums for things like _fusionModeGPS


This is test repository.


Thanks


r+


I think it would be more efficient if you just called get() and checked the result for null, one fewer call to the hashing machinery


We don't need redefine tempfile here


Events not namespaced - so that they could be double-bound.


May be it's better to check for the state afterwards?


I think I'd avoid breaking the :tag: over two lines, just for ease of editing/reading the plain text. Also missing a period at the end of this sentence. Also there's a double space after "and".


What about comparing just the data maps and avoiding the conversions to Strings?


Following debug info disappears without finishTest(). Is it ok?
```
PASS successfullyParsed is true

TEST COMPLETE
```


The concurrency bug in Android 4.4 seems to still be an issue so I think the reference to it should be kept in this comment.


Before calling self.read_file() we need delete the old temporary file.
Please add:
```
+        # remove the old file
+        os.remove(self._tempfile)
```


Looks like we can use the same key in lots of places. Akismet will recognize that and separate log data by requesting site. The free account also says "80,000 checks across all sites". Seem like we'll use around 40,000 / month in new records, plus a little more in edits. So I think we're should be OK


Actually fixes #28


jejejeje it's not problem :D


Nice. Let's add some doc about the 'endDelimiter'. In my experience with Oracle, the meaning of the end delimiter was painful to figure out :)


Double-click on input will bind these events twice. Better to namespace them, and use off/on to rebind.


Writing this as `oParentNode.nodeType === oParentNode.ELEMENT_NODE && …` (instead of probing `oParentNode.attributes`) would be more according [to specs](http://www.w3.org/TR/DOM-Level-2-Core/core.html#ID-NodeHasAttrs), I guess?


Yea branch and PR would be good. A web service can be user facing or program facing, I would prefer we stop using the phrase web service unless we have to.


Let's use a DEFAULT_DELIMITER constant for this


note that you can just use 2 instead of 2.0f. The integer gets promoted to a float when used as part of an expression with other floats.
The sqrtf() is needed though.


I needed this for a simple CSS trick to an image wasn't needed for the "toggle arrow"


true, I will fix that quickly!


all tests pass:
success: http://build.servo.org/builders/linux1/builds/478
success: http://build.servo.org/builders/linux2/builds/476
success: http://build.servo.org/builders/android/builds/513
success: http://build.servo.org/builders/mac1/builds/694
success: http://build.servo.org/builders/mac2/builds/695


Let's add docs on these, particularly for those that are optional. In this case catalog and schema names are probably optional (although it's best if you set them)


29 [Gen 1] Random Battle battles
21 OU battles
7 UU battles
4 Ubers battles

kek


No content changed in this commit, correct?


One thing to keep in mind is that zinc probably requires a lot of Unix functionality on Windows, and I had working versions of all of those -- except `ln`.  Maybe other developers are using different versions of windows `ln` that actually work, but just using `mklink` seemed like a better solution.


It should always contain the item otherwise it would mean that the VM and the JavaDebugger do not agree over breakpoints.

Thus in favor of readability I would suggest to leave it as is.
But I can also change it if you want.


If burdening Redis is a concern, I'd be equally concerned about burdening the database, which has consequences to all the rest of the content. Redis as a result storage also has the advantage of auto expiration of results.


that would be the column name, not the table name, I think...


Why is it that webkit is preferred over the standard in all these?


There is a fix for this issue in git. See commit 56cd7404


Ahh this one is wrong commit taken. Stack pointer store should be first here or last in longjmp. Will fix in a minute.


That's... reassuring. :)


Found BROKEN by full.
MXtests) ... ok
test_MXfunction5 (__main__.MXtests) ... ok
test_MXineq (__main__.MXtests) ... ok
test_MXorder (__main__.MXtests) ... ok
test_MXreshape (__main__.MXtests) ... ok
test_MXslicingnew (__main__.MXtests) ... ok
test_MXtrans (__main__.MXtests) ... ok
test_MXvec (__main__.MXtests) ... ok
test_MXvecNZ (__main__.MXtests) ... ok
test_MXvertcat (__main__.MXtests) ... ok
test_MatrixAlgebraTableDense (__main__.MXtests) ... ok
test_bizarre_bug (__main__.MXtests) ... ERROR
test_blockcat (__main__.MXtests) ... ok
test_blocksplit (__main__.MXtests) ... ok
test_bug_1042 (__main__.MXtests) ... ok
test_bug_1042bis (__main__.MXtests) ... ok
test_bug_1042tris (__main__.MXtests) ... ok
test_bug_1046 (__main__.MXtests) ... ok
test_chaining (__main__.MXtests) ... ok
test_constmxmul (__main__.MXtests) ... ok
test_dependsOn (__main__.MXtests) ... ok
test_diagcat (__main__.MXtests) ... ok
test_empty_symm_jac (__main__.MXtests) ... ok
test_erase (__main__.MXtests) ... ok
test_getSymbols (__main__.MXtests) ... ok
test_getinputExpr (__main__.MXtests) ... ok
test_graph_substitute (__main__.MXtests) ... ok
test_horzcat_simp (__main__.MXtests) ... ok
test_horzsplit (__main__.MXtests) ... ok
test_horzsplit_simp (__main__.MXtests) ... ok
test_identityMX (__main__.MXtests) ... ok
test_identitySX (__main__.MXtests) ... ok
test_if_else (__main__.MXtests) ... ok
test_if_else_zero (__main__.MXtests) ... ok
test_imatrix_index (__main__.MXtests) ... ok
test_indexingOutOfBounds (__main__.MXtests) ... ok
test_indexinglimits (__main__.MXtests) ... ok
test_isRegular (__main__.MXtests) ... ok
test_issue1041 (__main__.MXtests) ... ok
test_issue107 (__main__.MXtests) ... ok
test_issue184 (__main__.MXtests) ... ok
test_issue83 (__main__.MXtests) ... ok
test_iter (__main__.MXtests) ... ok
test_jacobian_empty (__main__.MXtests) ... ok
test_jacobian_tools (__main__.MXtests) ... ok
test_kron (__main__.MXtests) ... ok
test_matrix_expand (__main__.MXtests) ... ok
test_mul (__main__.MXtests) ... ok
test_mul_sparsity (__main__.MXtests) ... ok
test_mul_zero_wrong (__main__.MXtests) ... ok
test_mxnull (__main__.MXtests) ... ok
test_mxnullop (__main__.MXtests) ... ok
test_mxnulloutput (__main__.MXtests) ... ok
test_null (__main__.MXtests) ... ok
test_printLimiting (__main__.MXtests) ... ok
test_regression491 (__main__.MXtests) ... ok
test_repmat (__main__.MXtests) ... ok
test_reshape (__main__.MXtests) ... ok
test_reshape_sp (__main__.MXtests) ... ok
test_scalarMX (__main__.MXtests) ... ok
test_setSparse (__main__.MXtests) ... ok
test_singularcat (__main__.MXtests) ... ok
test_sparsity_indexing (__main__.MXtests) ... ok
test_subsass (__main__.MXtests) ... ok
test_symbolcheck (__main__.MXtests) ... ok
test_ticket (__main__.MXtests) ... ok
test_trans (__main__.MXtests) ... ok
test_transpose_bug (__main__.MXtests) ... ERROR
test_tril2symm (__main__.MXtests) ... ok
test_truth (__main__.MXtests) ... ok
test_unite (__main__.MXtests) ... ok
test_veccats (__main__.MXtests) ... ok
test_vertcat (__main__.MXtests) ... ok
test_vertcat_empty (__main__.MXtests) ... skipped 'known bug (run with --known_bugs to include it)'
test_vertcat_simp (__main__.MXtests) ... ok
test_vertsplit (__main__.MXtests) ... ok
test_vertsplit_derivative (__main__.MXtests) ... ok
test_vertsplit_simp (__main__.MXtests) ... ok

======================================================================
ERROR: test_bizarre_bug (__main__.MXtests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "mx.py", line 2221, in test_bizarre_bug
    R= MXFunction([As,Bs],[solve(dense(Ast),Bs,"csparse")])
  File "/home/casadibot/slaves/linuxbot/full/source/python_install/casadi/casadi.py", line 15953, in dense
    return _casadi.dense(*args)
NotImplementedError: Wrong number or type of arguments for overloaded function 'dense'.
  Possible Python usages are:
    dense(array(int) )
    dense(array(double) )
    dense(SX)
You have: dense(MX)

======================================================================
ERROR: test_transpose_bug (__main__.MXtests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "mx.py", line 2177, in test_transpose_bug
    f = MXFunction([As],[dense(As.T),dense(As).T,As.T,As,dense(As)])
  File "/home/casadibot/slaves/linuxbot/full/source/python_install/casadi/casadi.py", line 15953, in dense
    return _casadi.dense(*args)
NotImplementedError: Wrong number or type of arguments for overloaded function 'dense'.
  Possible Python usages are:
    dense(array(int) )
    dense(array(double) )
    dense(SX)
You have: dense(MX)

----------------------------------------------------------------------
Ran 102 tests in 3.004s

FAILED (errors=2, skipped=3)

==============================
19. nlp.py
20. vectortools.py
21. function.py
22. lpsolver.py
23. ad.py
24. socpsolver.py
25. sx.py
26. mx_jacobian_sparsity.py
Ran 26 tests, 2 fails.
make: *** [unittests_py] Error 1

```


AWESOME


Prueba


I'd suggest to remove the "For more details" sentence.


prego!


Lets set up a time to go over this. too many emails and work is crazy right
now because of tax season..but i dont want u to get stuck.

send me a google invite to talk today.

Im busy from 12-1 today PST but after that I have nothing until 4pm
ᐧ

On Thu, Jan 8, 2015 at 9:31 AM, cflammia <notifications@github.com> wrote:

> I'm not sure what's the matter either. I did some research and couldn't
> come up with anything. Here's the screenshots (attached).
>
> 1.png is the screenshot after I entered an item into the form, pushed save
> and was redirected to the list.
> 2.png is the rails console shot of doing l = List.first and l.items
>
> On Wed, Jan 7, 2015 at 6:57 AM, Bobbilee <notifications@github.com>
> wrote:
>
> > yes that seems weird...take a screen grab of ur return instead of copy
> and
> > paste
> >
> > Sent from my iPhone
> >
> > > On Jan 6, 2015, at 8:47 PM, cflammia <notifications@github.com>
> wrote:
> > >
> > > Okay, I got
> > > 2.0.0-p481 :012 > l = List.first
> > > List Load (2.5ms) SELECT "lists".* FROM "lists" ORDER BY "lists"."id"
> > > ASC LIMIT 1
> > > => #<List id: 1, title: "Friday Party", user_id: 1, created_at:
> > > "2015-01-05 05:22:08", updated_at: "2015-01-06 03:19:10">
> > > 2.0.0-p481 :013 > l.items
> > > Item Load (3.1ms) SELECT "items".* FROM "items" WHERE
> "items"."list_id"
> > > = ? [["list_id", 1]]
> > > => #<ActiveRecord::Associations::CollectionProxy []>
> > >
> > > I used first instead of last because I knew I had created items in the
> > > first one. l=List.first is showing, so lists are good. It appears the
> > > items aren't saved though. I'm not sure what
> > > <ActiveRecord::Associations::CollectionProxy []> means? Is this an
> > error?
> > >
> > > On Tue, Jan 6, 2015 at 9:30 PM, Bobbilee <notifications@github.com>
> > wrote:
> > >
> > > > check In rails console all of these things - l = List.last
> > > > l.items
> > > > and see what it returns then u know if the items are being saved to
> > the
> > > > list
> > > >
> > > > Sent from my iPhone
> > > >
> > > > > On Jan 6, 2015, at 8:06 PM, cflammia <notifications@github.com>
> > wrote:
> > > > >
> > > > > I get the following, which means that yes, my new item was saved,
> > > > correct? I'm not sure why it's not rendering though?
> > > > >
> > > > > Processing by ItemsController#create as HTML
> > > > > Parameters: {"utf8"=>"✓",
> > > >
> "authenticity_token"=>"+UuvEmeg9vbsqXtBdoaqHKhiA/ZpDIpEW3lNJU+mNeU=",
> > > > "item"=>{"name"=>"Order drinks."}, "commit"=>"Save"}
> > > > > (0.1ms) begin transaction
> > > > > SQL (14.0ms) INSERT INTO "items" ("created_at", "name",
> > "updated_at")
> > > > VALUES (?, ?, ?) ["created_at", Wed, 07 Jan 2015 04:05:02 UTC
> +00:00],
> > > > ["name", "Order drinks."], ["updated_at", Wed, 07 Jan 2015 04:05:02
> > UTC
> > > > +00:00] commit transaction
> > > > > Redirected to http://localhost:3000/lists
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub.
> > > > >
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> >
> https://github.com/cflammia/blocitoff2/commit/e2f308590884f94e974c581a1167dd80ff787c37#commitcomment-9179836>
>
> >
> > > > .
> > > >
> > > —
> > > Reply to this email directly or view it on GitHub.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/cflammia/blocitoff2/commit/e2f308590884f94e974c581a1167dd80ff787c37#commitcomment-9185540>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cflammia/blocitoff2/commit/e2f308590884f94e974c581a1167dd80ff787c37#commitcomment-9205853>
> .
>

--
*Bobbilee Hartman*
*Software Engineer II at Intuit*
bobbileehartman.com / (612) 749-4804


fast-forwarding master to auto = 112ab497


Interesting. So when we return from main(), the app doesn't exit automatically on Android?


@lgalfaso - I think that strictly this should have been a style: or refact: commit. The chore: commits are about changes to the build process or related to the project files rather than code itself.


:v It doesn't matter though since it is translated properly, I will probably fix it after next update.


@talniv Can you comment on this approach and wording?


See https://github.com/github/linguist/pull/1965 for a little more context.


Sounds like a good idea... will add that


As part of the 2010 Census, the populations and properties of New Jersey, Tennessee, and Illinois were surveyed for information about property types, finances, and personal living arrangements. The survey gathered information about family and household income, property values, housing expenses, and other related questions.
In this report, we compare the overall quality and availability of low income housing options between the three states New Jersey, Tennessee, and Illinois. We measure the quality of low income housing using three metrics; newness, affordability, and crowdedness.


develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2065 of 2188 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.37842778793419%25-yellow.svg)


Doesn't compile


saw approval from zwarich
at https://github.com/mrobinson/servo/commit/9ac759ed80554cc097e0d1c2282edf5d51d28482


merging mrobinson/servo/compositor-message-renames = 9ac759ed into auto


mrobinson/servo/compositor-message-renames = 9ac759ed merged ok, testing candidate = 14587092


All in all - this is the right approach.

But the script has massive scoping problems, both for variables and events. You should use the this-context for instance properties (that's what it's there fore) - make sure each instance strictly stays within its own capsule. Very similar (if not equivalent) to Python modules, classes and instances.

Other than that - there are a few minor style issues which could be fixed, but not important enough to side-track you at this point.


Great to see you are paying attention!


Thanks Doug. Once the gem is done, I'm building a stand-alone app for it
using Sinatra. Just a web form to upload the PDF, enter your API key, enter
the recipient address and it'll get sent for you and bill your API account.

On Thu, Jan 8, 2015 at 9:42 AM, Doug Steinberg <notifications@github.com>
wrote:

> Awesome work on this gem so far! It's really nice. I think I'm going to
> try it out when it's done.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pmichaeljones/TryPaperAPI/commit/bc4278ddb2c1775912e0b9c3c2bd29e82972b78a#commitcomment-9205050>
> .
>

--
Patrick M. Jones
Ruby on Rails Developer | External API Integration Specialist |
pmichaeljones@gmail.com
Software Project Portfolio: https://pmichaeljones.herokuapp.com
GitHub Profile: http://github.com/pmichaeljones


@kumpera This breaks the Linux build:

```
  CC     mono-time.lo
mono-time.c: In function ‘get_boot_time’:
mono-time.c:92:12: error: ‘KERN_BOOTTIME’ undeclared (first use in this function)
mono-time.c:92:12: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [mono-time.lo] Error 1
```


setBody didn't actually do any setting .. so I thought the name was misleading


Should this be `args.join(' ')`? `getArgs()` supports `extraArgs` being undefined, but it will throw here if it is.


This one has already been review in the past. It is OK to me.


Same comment as above


`key in ['usercss', 'additionalCooldown']`


Looks very nice :) I still have a few comments left though...


I'd like to see that in a separate commit -- just to make it clear exactly when we changed the default :)


Может просто массив, что бы не таскать слайс через аргументы ?
var length [PacketLengthBytes]byte

Как Go выделяет память для "стековых переменных" ? вообще есть "стековые переменные" ?


Woah, that's a lot of stuff! Looks awesome, I like your example too.
Sorry for being so unresponsive, I'm currently still away from home after the holidays. I'll get back to this next week sometime.


I think we should include a list of the default `TEMPLATE_CONTEXT_PROCESSORS` heres so that people who haven't customized them will know what to add.


It only works on the front page for me, doesn't work at all in threads.