Nothing I couldn't figure out with a little help from Google.

On Mon, Jan 26, 2015 at 3:02 PM, Garrett Wills <notifications@github.com>
wrote:

> Looks good, have any issues along the way?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/acarpenter88/a-carpenter-site/commit/eff26f273e46917c8d193e4cfa88492a494f7d41#commitcomment-9447016>
> .
>


Not exactly sure what you mean, but I have a cold so my brain is not functioning correctly :smile:

Up above in two cases you set `plistPaths`. In one case they are guaranteed to be plists (if `build-state` exists) due to the regex and in the other case (if `build-state.dat` does not exist) you are listing all files so it later needs to be filtered down to just plists. Instead of filtering down here with the `continue` I believe you can just filter in the second branch and then this continue can be removed (but again, I may be missing something in my sickness haze) :mask:


Eureka! I get openssl in phpinfo!  Now to re-run the tests...


this file was changed a little bit on line 9,11,699 to work with shadow dom.


What is the error that occurs? Can you post the traceback?


There is no index.html file included with this commit. Make sure that you saved the file in the appropriate place and then commit it to the repo. Make sure you remember to add your changed files before committing.


Possibly. I'm just lenient on adding options if I can avoid it as it requires adding it the API, CLI, as well as documenting and supporting it. Don't really see any way around this though.


The libreto guys named the emulator wrong ;)
https://github.com/libretro/libretro-o2em


aha :)


Ok. Next question... why are you fetching characters then? :smiley:


Looks good, any issues along the way? Also nice emojis haha.


Yay! no I had no problems at all :+1:  Thank you. Looking forward next assignment.


This is stopping the addon.


So far so good.

I think I do met a problem which makes me can't save the ssh key on my PC.
I'm trying to deal with it.


Looks good, any issues along the way.


Also `extends` should really be using `hasOwnProperty` since it's used in contexts where it'd usually be `Object.assign` which only clones enumerable own properties. Thanks!


Since there is `#include <AP_BattMonitor.h>`I can not compile, for example `ardupilot/libraries/AP_HAL/examples/RCOutput`
Build result: `/home/mirko/mirkix/ardupilot/libraries/DataFlash/DataFlash.h:16:28: fatal error: AP_BattMonitor.h: No such file or directory
 #include <AP_BattMonitor.h>
                            ^
compilation terminated.
`


Looks good, any issues along the way?


pip copies scripts that are entry_points

easy_install makes a reference to the script that can run as python

On Mon, Jan 26, 2015 at 6:12 PM, Olga Botvinnik <notifications@github.com>
wrote:

> What is the error that occurs? Can you post the traceback?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/YeoLab/gscripts/commit/d57027e92065924fc168b618553dc19879ec2a61#commitcomment-9447189>
> .
>


@quirkey
Found [here](https://code.google.com/p/chromium/wiki/LinuxZygote) that you can get rid of the zygote process by passing the --renderer-cmd-prefix flag.

You might add the info you've researched to the [CEF Issue 1362](https://code.google.com/p/chromiumembedded/issues/detail?id=1362).

Btw. I recall you've been asking on how to update CEF to a newer version. Have you managed to do it? Maybe this issue was fixed in later Chrome versions.


Looks good, any issues along the way? Also props for editing your readme with relevant content.


Take out this index link (the whole <li> tag) -- the logo will be clickable for the home page. Just leave it out for now, though.


I think only the first point is abour generell upgrading, some kind of introduction. DAM is mentioned because t3blog recommends to use it ("You can use it without DAM – but then you will have to reprogramm quite a few lines of TypoScript and PHP-Code"). I will clearify this, please have a look at that part in the next version.


I see, yes @Sdw- looks like it's the same for High Five.


Because fiveam is not loadead when the asd is read you can't call fiveam:run 'main directory here, use
asdf/package:symbol-call instead. i.e. (asdf/package:symbol-call 'fiveam 'run 'main)


Haha, I thought so, but didn't want to derail the discussion (and hence the hint at that issue). So, when looking at this closer, I realized this wouldn't actually affect me since I'm using the runtime. Therefore, I don't think you should make this change unless you get this request from other 6to5 users. Sorry if this wasted your time!


Added the needed negation in the latest commit


You've declared this outside the block on 159, is that intentional? I think the decl on 159 is spurious.


That's no good, but still strange. I haven't had any issues with `pip install -e .`. Can you show what the traceback is when you try to run a gscripts script after an unsuccessful `pip install`? I've had to remove the `path/to/python/lib/site-packages/gscripts*` directory before to get the install to work.


Thanks Nate, I've updated the wiki:

https://wiki.galaxyproject.org/Admin/Config/Performance/Scaling?action=diff&rev1=18&rev2=19


What for what?


I am showing number of created characters on users show page  so I thought that I need to fetch them for @characters.count


Looks good, any issues along the way? Glad you practiced with adding additional commits as well, it will help you along the way.


This
 tag should open and close on the same line -- should look like this:
About this site

Then, delete the
 tag from line 24.


Just as shortcut to not create extra closure: `conn:on("sent", conn.close)`


ok. part 2... Getting the debug output :)


@donnapep Does this work okay? According to Angular documentation you can't use conditionals in expressions - https://docs.angularjs.org/guide/expression


I didn't know that Homebrew has style checker!

`brew audit` claims that test definition is old style as:
```
dartsim:
 * Stable: version 4.3.4 is redundant with version scanned from URL
 * Use new-style test definitions (test do)
```
Should we change it also?


Job pr-scala failed for 86afdef4 Took 271 min. (ping @RomanHargrave) [(results)](https://scala-webapps.epfl.ch/jenkins/job/pr-scala/9570/):

To retry exactly this commit, comment `PLS REBUILD/pr-scala@86afdef4dcab385c55834ef6208ba2f8b9fa63c4` on PR 4266.
NOTE: New commits are rebuilt automatically as they appear. A forced rebuild is only necessary for transient failures.


It's all good! I like these types of discussions because they typically raise legitimate concerns/issues that I haven't considered.

In 3.0.0 the runtime is actually going away in favor of a `selfContained` transformer that adds `var _to5Helpers = require("6to5-runtime/helpers")` (or whatever module system you're using) to the top of your file and changes all the helper calls to reference it. I only bring this up because I haven't managed to talk to anyone who actually uses the optional runtime. In your case would this be satisfactory or should I add the ability to generate/use it back in?


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/3315/console to remedy the problem.


This \<body> tag should be before the \<header> tag -- the header section is a part of the body.


This \<body> tag should be before this \<header> tag -- the header section is a part of the body.


@Zoey76 Then please check this out.

https://gist.github.com/Sdw-/570e0c1da0c07a1a406e

Just RequestAddExpandQuestAlarm might not be present in H5


Please clarify how to enable/disable floats. To define, or undefine.
Same applies to other defines: e.g. what does the following means and control?
```lua
// #define DEVELOP_VERSION
#define FULL_VERSION_FOR_USER
```
TIA


Looks good, any issues along the way?


agreed

Also this may have been what @iwillig was doing anyway, I was just throwing the comment out there while I was here :)


Take the \<img> tag out of the div & delete the div tag entirely -- no need for it, we can style the logo from the img tag itself.


How could I forget the " in the href?


Same comment as above regarding the logo in a div


`g_strcompress` might be useful here.


This looks a bit odd. If `HistoryTable` is a specialized version of the generic `Table` class then I think you should omit the `<T>` from it.

Then later on in the code where there is:

```
    override func getInsertAndArgs<T>(item: T) -> (String?, [AnyObject?]) {
 let site = item as Site
```
Can be replaced with:

```
    override func getInsertAndArgs(item: Site) -> (String?, [AnyObject?]) {
```
I think?


@stulees Yup, it does. That documentation sounds like it's only applicable when using the curly brackets.


I got that problem sending an email unencrypted and unsigned, but other cases might produce the same. Adding the TODO.

Also this headers need some review, as I'm not sure if the match well all the cases.


`$refClass->isTrait()` will never be true because `$reflection->getDeclaringClass()` does not return traits. Use the new method from nette/reflection instead.


Your commit looks good, however, it seems you have included two index.html files. You can delete the git folder, along with its contents. Did you have any issues with the homework?


looks good! images-d running it and seems fine.


I'd be using the `selfContained` transformer (very excited about it). If I understand this correctly, the functions inside `6to5-runtime/helpers` would not be compacted, correct?


This should be in an \<h1> tag, rather than a paragraph tag


Again my apoligies. was not my intention.

ive corrected the commit!!

Cheers
Dragon


Ok I did not get what you meant, but now it is clearer, and indeed you're right. I will add the filtering and so remove the unnecessary 'continue'.


Agree, I think it's better to look through the list returned by contentsOfDirectoryAtPath on line 185. There you can perform filtering to narrow it down to plist files, and subsequently prepend the directory path component to form the absolute path, and just add that into the array.

Once you do that you don't need to add any special cases on the per-file handling down here. Any loop overhead will be negligible, feel free to benchmark if you are not convinced.


Use Scala style imports to avoid multiple lines from same library


Is it possible to also use prepared statement placeholders here instead of string substitution? Just to prevent any kind of SQL injection? (I know it is probably far fetched in this case but I think it is a good practice to just prevent string substitutions completely in SQL, or at least escape the strings to be sure they are not evil)


@rpl do you mind reviewing this commit when you have some time?


We should discuss how ActiveRecord/AREL handles queries. (please remind me)

It's not a bad way to do it, but whenever possible you should try to prepare all required data for the template. In this case you could have done something like: `@user_character_count = @user.characters.count`.

Alternatively you could have just used `@user.characters.count` in the template directly. It breaks the guideline above (to prepare everything) - but sometimes, for example when it's only displayed on one place, it can be used "inline" so you don't create unnecessary variable.


Move the \<form> tag so it is below the "search for a city" text, and have it only include the text box and submit button (also check spelling -- should be "form")


This is to make sure ```php do_action( "manage_{$post->post_type}_posts_custom_column", $column_name, $post->ID );```is called correctly in the admin.


No, it seemed to work pretty well for me.


I think you want to be checking on `source`, and not `target` here, right?


My over confidence in the change.


This is ground work for #39


More arguing that enforcing dns label or dns subdomain for all Kube core APIs is reasonable - forcing it on all Kube-like APIs is potentially impossible / counter-productive.

Kube API: service, node, pod, rc, a few others
Kube-like API: anyone who wants to build things that run on top of Kube, but benefit from common API conventions and patterns.

Is "name" so strong a convention that forcing it on "Kube-like" provides benefit?

For Service there's a clear use case to keeping it DNS like, for RC it can be anything that roughly looks right in a URL, for Pods it should be long enough to describe things, for nodes it should be hostnames or host-like names.  However for secrets or service accounts or resource controllers or quota objects or builds or routes or user accounts I'm not sure that the common convention should be mandatory.  I don't know if I would go so far as to be free form - but if resource X chooses to interpret Name differently from resource Y, does a client need to know that?  Or does it only need to read and write name?

----- Original Message -----
> Are you arguing for letting Name be a free-form string?  I thought the
> discussion was DNS Label vs DNS Subdomain ?
>
> On Mon, Jan 26, 2015 at 10:59 AM, Clayton Coleman <notifications@github.com>
> wrote:
>
> > Let's lay out the arguments for strict names:
> >
> > * every API that is deemed "kube compatible" will follow the rules
> > * except for those that decide they need names that don't follow the rules
> > * it means that clients can do things to manipulate names like add
> > prefixes and suffixes for sets of resources
> > * they could always only use prefixes/suffixes out of a-z0-9
> > * if you want to represent a name that is surfaced as some other resource
> > type (in a different system, different problem domain) you have to map the
> > underlying name space to the kube name convention
> > * so "foo:bar_x" in underlying system has to become "foo_x045_bar_x00_x"
> > as a name
> > * or you create a mapper class
> > * consistency - clients can write a single validator for all objects
> > * except for objects that don't follow the rules, and also client
> > validators are bad because they may not have the same validation results as
> > the server
> > * consistency - you can point someone to the API doc that says "here's
> > what names are"
> > * validation of object references
> > * you can strictly validate object reference names prior to checking them
> > * see statements about client validators and resources that don't follow
> > the rules
> >
> > Other arguments I'm missing?
> >
> > ----- Original Message -----
> > > Is it a hardship to say that kubernetes names DO allow DNS-subdomains
> > (and
> > > all that entails) but do not allow arbitrary stings, and if you want to
> > jam
> > > an arbitrary string with "TZ" in it you have to tr that "TZ" into "tz"?
> > >
> > > ---
> > > Reply to this email directly or view it on GitHub:
> > >
> > https://github.com/smarterclayton/kubernetes/commit/c0e94dc996969f2cd784c41fe13ff3f395949cf9#commitcomment-9445165
> >
> > --
> > Reply to this email directly or view it on GitHub
> > <https://github.com/smarterclayton/kubernetes/commit/c0e94dc996969f2cd784c41fe13ff3f395949cf9#commitcomment-9445884>
> > .
> >
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/smarterclayton/kubernetes/commit/c0e94dc996969f2cd784c41fe13ff3f395949cf9#commitcomment-9446714


So variable definition which I have caught inside it did not propagate
through cases.
(It's to fix another warning)

On Mon, 26 Jan 2015 22:06 Alexander Vershilov <notifications@github.com>
wrote:

> Just curious, why do { .. } while ( 0 ); is needed here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MPogoda/kbdd/commit/cc88e678ec520b00bf856142063edcc5ecae2f2e#commitcomment-9447065>
> .
>


@Majkl578 that is now impossible thanks to https://github.com/nette/safe-stream/commit/313134b8d511469291dd946d5416485b90c159a3#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R26


done


The original motivation for looking at the build-state.dat instead of doing directory traversal is to prevent analyzer results from files since deleted from the project from showing up. Doing this is OK but may introduce said outdated results. I'm not sure how well xcode's clean works, but in Xcode 5 it doesn't remove intermediates of files that's deleted from the project. Probably not a big deal, but people may run into it occasionally (the few people who actually use analyze via xctool) and be perplexed.


I just opened an issue for it. I'll close it lol


This is used by many extensions and I'm not sure how to refactor it. What is the recommended way now?


Oeps ik bedoel #73


I wonder if it would make sense to delegate things like 'what is my query' and 'what are the query arguments' to the `Site` object. The `Site` object could implement a `SQLInsertable` protocol in a class extension that looks like this:

```
protocol SQLInsertable {
    var query: String { get }
    var queryArguments: [AnyObject] { get }
}
```

Then the `insert(db:, item: err:)` code can be really generic and you don't even have to cast to a `Site`. You can just use `item.query` and `item.arguments`.


So there are 2 points :
1) general web app performance : using a CDN with the whole Modernizr, or a local custom Modernizr ;
2) WP-specific (main goal of Sage) : putting Modernizr alone in the header for the plugins that require it.

So why not using a CDN Modernizr .js in HEAD ?


mañana cambios esto, quitamos PDO y probamos como la versión anterior.


test


I see, thanks


Looks good, any issues along the way?


I completely remove this line in the last commit. I don't think it makes sense to have it.


@donnapep Got it, thanks


Does this not leave the buildbots flying around doing nothing? Surely one should leave both effects turned on?


test line


algo que no me vuelva loco porfavor!!! @divadcr


Alread done :stuck_out_tongue:


Strike "or not" (it's not needed).


Good call @kleinfreund :bow:

It seemed like a good opportunity to throw a wider net on this by defining the html5 elements properly, as they are used quite extensively in the default template.

AFAIK, even IE11 doesn't handle `<main>` correctly. IE8/9 gets it wrong for all html5 elements and `<details>` and `<summary>` are missed by IE10 and 11.


I don't see the benefit here. Only unnecesary obstructions. I'll now have to go and fix ~15 different compiler extensions and tag ~30 different releases once this is removed... Not happy.


**To remove log formatting**
*Comment*
`log4j.appender.stdout.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss} %-5p %c{1}:%L - %m%n`

*Uncomment*
`#log4j.appender.stdout.layout.ConversionPattern=%m%n`


You mean this only here, or also on the other buttons and to use keyboard.xml and translate there numbers 0-9 to  RDS.Action(foo)?
To use the number values was for me the way which make the most sense. The Rass Images show always in menu list the fields with numbers from 0-9, thats why I added in the code a value check related to this numbers.
If it is required with RDS prefix then I change it.


I was searching how to fix problem with current_user, when I used current_user in Characters controller it was returning nil, with this line of code problem was fixed.


Absolutely.

... and it's gone.

https://github.com/fantasyland/fantasy-promises/pull/12

On Mon Jan 26 2015 at 1:47:29 PM Simon Richardson <notifications@github.com>
wrote:

> Can we revert this and put it in a PR?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fantasyland/fantasy-promises/commit/9c3aa06921074478872e85e0b4cef4c8da955b83#commitcomment-9446746>
> .
>


```javascript
$(function(){});
```
 тоже самое но короче


`Enumerator#any?` returns `true` or `false` directly, so there's no need to compare it to `true`.


A bunch of states till depend on this. We need to replace those states maybe but for now this is still required.
I'm adding it back in for the time being


So the fact that you are able to commit, push, pull and do the basics of github is good. But the assignment requires you to commit an index.html file, which you saved your code as a basic text file. Just do an additional commit after you have saved it as an html file and you should be good.


No new lines at the end of file.


Nicely I had tested the old version on my live board ... and got 5 spam posts in some minutes (just because the addon was not working in that moment :p).


```javascript
.on('click',
```

Гараздо лучше


Okay awesome.


Go ahead and take out this whole line (\
\Index\\
) -- the logo will eventually be clickable


`Enumerator#all?` returns `true` or `false` directly, so there's no need to compare it to `true`.


Shouldn't this be `func getInsertAndArgs<T>(item: T) -> (String, [AnyObject?])?`

In other words, if this fails, it returns nil instead of a tuple. If it succeeds it *must* return a tuple with the SQL string and an array of zero or more arguments. Then later you can also do:

```
if let (query, args) = getInsertAndArgs(site) {
    ...
}
```
Instead of:

```
let (query, args) = getInsertAndArgs(site)
if let query = query {
    ...
}
```


Okay, if you can't figure it out shoot me an email or stop by the CSET offices tomorrow during my office hours and I will help you out.


> I don't get what you mean. It is first checking that the expanded value of of csfmt_str will fit in buf, reallocating buf if not, and then expanding into it.

Sorry, I was referring to the comment:

```c
/* csfmt_str = "%4d %6s  "; */
```

It didn't seem very DRY.

> I'd be ok with that. Not sure if a bit more inefficient, as we's redefine the constant in every loop iteration. But maybe the compiler optimizes that anyway.

Yes, the compiler most likely would optimize a `const char[]` by hoisting it to the top (semantically speaking, since in assembly it matters little). Though you're entirely right in that it's not guaranteed. Therefore, I think the clearest, always performant and most correct would be a const pointer to a string literal:

```c
const char *csfmt_str = "%4d %6s  ";
```

> Sorry, don't know what you mean.

I was right and wrong. Basically, pointers to string literals should always be declared const, because they are usually stored in read-only memory: http://programmers.stackexchange.com/a/184088

To recap from the SE answer:

```c
char var1[] = "september";
var1[0] = 'S'; // Ok - 10 element char array allocated on stack
char const *var2 = "september";
var2[0] = 'S'; // Compile time error - pointer to constant string
char *var3 = "september";
var3[0] = 'S'; // Modifying some memory - which may result in modifying... something or crash
```

The usual warning associated with this is can be found on the [gcc docs](https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html). Ctrl-f for `write-strings`.

Let me know if I've made some confusing statements again, this tends to happen :).


Pero las  torres neutrales sí


Alright awesome.


Oh noes. I really didn't want this to happen. :(


Glad to hear it.


Great! Yeah, they wont be compacted.


MDM providers can now configure login hosts, remote access consumer key and callback URL at runtime, for applications built on Mobile SDK 3.1.


Indent the header tag under the body (on this file and the other)


Fuck...


Yes, only mono side chain is supported by the daw/format currently according to the docs (and the de facto buses it lets you connect)

> On Jan 26, 2015, at 21:25, Yair Chuchem <notifications@github.com> wrote:
>
> Does this mean it expects the side-chain to be mono?
>
> —
> Reply to this email directly or view it on GitHub.
>


are you a wizard? :sake:


should be "form" not "fourm"


When I tested this, it was actually a little slower booting. Though my test wasn't perhaps under the best of conditions, different toolchains, etc.

And originally I ganked all of this from AICP's gerrit. :) They seem to be adding LZ4 to everything, with fresh custom code to go with (much of which I ganked), and maybe since I last updated they've even updated their LZ4 stuff even more. Jus' sayin'. :)


Be careful: `x - 0 == x` but `0 - x != x`.


This should be an h1 tag, not a paragraph tag -- made a note before but you might not have seen it


Indeed. What's usually done is setting `display: block;` for all the _new_ HTML5 sectioning elements which are block-level.


Take out github keys from application.yml


Why?


ah yes, its most probably needed on darwin as well. @Memphiz?


Fixes #43


Putting some review here.
`i2c` global, hence sloow.
`local i2c = i2c` at the top solves.


[x] done
[x] done
[x] done


@gwilakers
 The only issues I had were described in the email I sent with suggestions on describing the different interfaces with GitHub. Once I understood the instructions were for the Web Page repository I was good to go.


ah, thx!


i never figured out what those file are and what they do - i only know that they are copied in some of the depends makefiles to somewhere ... @davilla? *grasps a straw*


This doesn't let you set a static quit message so regresses that functionality - I would be in favor of letting you set a message AND this option - would you be up to modify this to add a new config option? If you need help with how to do that I'd be happy to do so.


Please, consider replacing `string.FUN(str, ...)` with `str:FUN(...)` which doesn't derefence global `string` and is _generally_ faster (at least on mainstream)


thx!


Published to http://vui-docs-internal.s3-website-us-east-1.amazonaws.com/29_b7a99ec32619b28e400a1719c2387a625139a426


Works if you are running a Python SimpleServer at http://localhost:8000/juxtapose/embed/index.html?src=test.json


`UH` spoils global


typo: offset


We could add attributes `FUNC_ATTR_NONNULL_ALL`  and `FUNC_ATTR_NONNULL_RET` to `next_fenc()`.


Typo in commit message: variable


weird braces, same in `return (foo)`


this triggers now a bug see issue #67


Alright cool, and again, thanks for the suggestions.


:+1:  this is great solution.


L'ancienne syntaxe est la bonne, à savoir `<author>lawyer@boyer.net (Lawyer Boyer)</author>`, voir par exemple:
* http://cyber.law.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt
* http://www.rssboard.org/rss-profile#element-channel-item-author

La syntaxe "User <user@example.com>" n'est pas une syntaxe valide en RSS pour plusieurs raisons : XML incorret (càd mal-formé, il faudrait échapper les caractères < et >) et cela ne suit pas les spécifications RSS.


(+) good test
(-) badd..


ungrabMouse()


Consider not hardcoding printing, instead `return nil, errcode` and let the caller print/not-print/ignore/print-in-afrikaans/whatever.


@amjadm61 thank you for commenting. This bug looks to be closed along with the associated PR. If there are changes you'd recommend to the existing icons, you should [file a bug](https://bugzilla.mozilla.org/enter_bug.cgi?product=www.mozilla.org&component=Pages%20%26%20Content) with your comments.

Thanks again!


I think we should make people import the full class. I see so many people coming to laravel new (as there first php framework), and they don't understand that the Eloquent class doesn't actually exist - it's just an alias to the Model class that's namespaced.


Why prefer empty over null? At least, it is clear that null is not a valid URL, while "" is not.


not sure if this will break the current div area and cause "here" to be on the next line when viewing the docs page from a desktop.


I'm not sure why this fixed your problem with current_user - but it's not a way to fix that problem. You effectively turned off Cross-Site Request Forgery (CSRF) attacks protection (see http://api.rubyonrails.org/classes/ActionController/RequestForgeryProtection.html). That's sometimes useful, but generally you should have really good reasons to do so.

`current_user` being nil made me realize something. Only user controller has `before_filter :authenticate_user!` - meaning only user controller action require signed in user. That's wrong. You should restrict access only to signed in user.


`return t, h` might denote read is ok, `return nil, errcode` might denote errcode happened.
Then `M.get*` is obsolete and the caller is responsible for storing `t` and `h`, just as it imo should.


Forgot reported by @zephyr29


@frap129 should look better this way :)


Le is None est à mon avis inutile (à tester), je mettrai plutôt:
```python
+repository = os.path.basename(os.path.realpath(args.repository)) if not args.reponame else args.reponame
```


The test isn't currently doing anything, so I would either delete the `def test` or update the syntax and add a test.


This is duplicated.


I was just about to suggest and begin coding this feature. You read my mind. Great job!


This is opening a security hole. http://mymaliciousisteyoutu.be would now embed into Vanilla.


as far as I know there are some asserts here and there that make sure the destinationKeyPath is not nil


@Come-from-Beyond I only see how the Irwin–Hall distribution applies to summing. Are you sure it applies to xor'ing?


I've been playing with this a bit with a Favicons table. I'd like to keep the implementation details out of Site, but with Favicons I created a wrapper around a Favicon object that could expose some extra methods and arguments. I could do the same here. I probably could make that an extension, but again, I just wanted to avoid exposing it to the outside world.


http://events.linuxfoundation.org/sites/events/files/lcjpcojp13_klee.pdf
Yeah, I thought so as well, the case study here used an improved lzo patch and unaligned memory access enabled for lz4 and lzo, but I might try merging more stuff in on a new branch at a later date. lzma has a good file size ratio, but honestly the kernel isn't even that big, so it's not that much of a game changer. Keep me updated if you get any results.


900 c'est grand je trouve. La valeur est en minutes, donc ça signifie que ttl=900 correspond à 15h, c'est trop à mon goût (enfin tout dépend du dépôt...).
Sinon on peut aussi mettre le ttl en argument, comme ça on peut facilement le modifier...


Has RedstoneFlux updated? And BC, Undergroundbiome?


Isn't there a way to integrate this: https://github.com/AlexAltea/ps3autotests and http://achurch.org/cell-test/ ?


I love this attention to detail! Really! If you like to pay attention to formatting details too (like me, hehehe), you could add an space between `){` at the end of this line. ;- )


Looks good ben


I've ported CoFHLib on my fork. I've already talked to skyboy about it. He will get around to looking at it when he has time. For now, I will be switching the RF API submodule to my fork.


Swift requires that if you inherit from a Generic, you be Generic. You don't have to do anything with it. It just has to be there. i.e. HistoryTable<Any> does that exact same thing here. But I think you're right, I should have specialized these methods when I implemented GenericTable<Site>...


Also, those aren't hard dependencies, so it doesn't matter.


Is updated, thanks.


ah, i misunderstood what you were trying to do there.
please ignore what i said and leave it like it is.


@eLobato : These validations are just for the sake of consistency. These are infact disabled by passing a `:validate => false` in `docker_container_wizard_states/exposed_port.rb`. The reason being, validation failures are not exactly handled gracefully right now, and a two-layer validation failure throws a completely meaningless message on the screen :( A better way to go about this would be much appreciated :(


awesome. just need to add success message on +/update+


I've been trying to get the lg-devs '[lge-LA.BF.1.1_RB1.05](https://github.com/lg-devs/android_kernel_lge_msm8974-caf)' G2 stuff to work lately, so I've not even played with that LZ4 on that setup lately (they seem to have all that LZ4 stuff, about exactly, already in their stuff). They seem to be doing some radical things, but I can't get 'em to boot. Interesting direction they're going in though, they seem to be really tearing the guts out of the G2 and putting it all back in rightwise (perhaps).


Il serait préférable de mettre une variable "constante", genre PROG_VERSION ou VERSION en début de script et l'utiliser ici avec un .format. Ainsi ça évite des modifications confuses si on change le numéro de version par exemple...


The use-case behind this change is a bit complex, but I will outline it. I am running tests using a virtual machine that runs the Appium server and executes the tests, while the devices are connected to the same local network but not directly to the VM. Because of this, each device needs to be manually connected to the adb server by executing 'adb connect 192.168.56.XXX' for each device connected to the network. This is done before each test sweep without killing the server by simply trying to connect to any device that is currently not connected. The problem that arises is that sometimes the device will freeze or for whatever other reason cause the command ' adb -s 192.168.56.XXX shell "echo 'ready'" ' to fail. This will then cause Appium to kill the server in an attempt to reconnect to the devices. The problem is that if the server is killed, all of the network connected devices are disconnected and will not reconnect automatically. This breaks the setup I have as I am running Appium servers in parallel to test on multiple devices at one time, but there is only one instance of the adb server, so it will make any other running tests fail because the adb server got killed.


Do we really need the full blown thing?


1. Tega ne bi dal v svoj commit.
2. Prva vrstica v commit messagu naj se ne konča s piko. Glej link v #2.


Looks like the indentation is still wrong.


I wasn't aware of that, I find that solution on stackoverflow forum after a lot of attempts with different solutions including adding before_filter :authenticate_user! on other Controllers but then I was receiving some errors. I can't recall now which one exactly.


Well, keep in mind it's the caf kernel, and it's still a major work in progress.


develop (rraustad) - x86_64-MacOS-10.9-clang: OK (1094 of 1094 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Do not fix them, it works.


I see. Let's remove the `test` and add it when necessary.


Feels a bit of a specific problem, that maybe should better be dealt with in your private
configuration file. You can just add that entry to the dictionary.


we usually don't wrap values in logs with `()` we either use `[]` or `''`


Zakaj pišemo kodo, ki ne dela ničesar? Razred `User` je nekaj drugega, saj ga vsaj kličemo.


Can you send PR?


Sorry guys made a mistake; the appropriate commit name is "Centralize QuickSettings constants"


Na vrhu datotek ne bi pisal, kdo in kdaj jih je naredil, saj imamo za to že Git. Grdi, grdi Eclipse.


What happens, if a user thinks it's fun to give "foo/bar" as an argument?


There's no need for this check (it will always be `true`), so this can be rewritten as:

```
var handler = new HttpClientHandler { AutomaticDecompression = DecompressionMethods.Deflate | DecompressionMethods.GZip };
```


Kljub temu, da PEP8 zapoveduje, da naj bodo importi iz različnih skupin (splošne knjižnice, 3rd party knjižnice, lastni moduli) ločeni s praznimi vrsticami, jaz vseeno ne bi dajal praznih vrstic.


j


@urras Any reason to revert this? Can you please tell me what went well and what not?


Ok. running it, and looking at the output, it seems like at some point the code in handle_ssl_error was changed to look for the SSL_ERROR_WANT_READ / SSL_ERROR_WANT_WRITE, and changes the errno to EAGAIN. The original version i wrote would would check for errno = EAGAIN and the SSL error to be  SSL_ERROR_WANT_READ / SSL_ERROR_WANT_WRITE and re-run the operation. (My comments said that the method didn't properly check for that case.)  It seems to be checking it now. Not specifically for the EAGAIN combination, just for the SSL_ERROR_WANT_READ / SSL_ERROR_WANT_WRITE error code.

Anyway. I removed my check, and it tries to read and exits. Now, the test is still failing as it says it couldn't failed to open the HTTPS stream. I have to check this on Linux as well (both without my changes and with them)


Put authenticate_user filter back to *all* the controllers that need it. Then we'll handle the errors you are getting.


I'm not sure what spawned this but am glad there are no diff's.

On 1/26/2015 3:59 PM, Tik-Tok wrote:
>
> develop (rraustad) - x86_64-MacOS-10.9-clang: OK (1094 of 1094 tests
> passed)
>
> Build Badge
> <https://nrel.github.io/EnergyPlusBuildResults/EnergyPlus-4dd29a6ee080fe2b2ad74057eb3e4cdef5ddac40-x86_64-MacOS-10.9-clang.html>
> Test Badge
> <https://nrel.github.io/EnergyPlusBuildResults/EnergyPlus-4dd29a6ee080fe2b2ad74057eb3e4cdef5ddac40-x86_64-MacOS-10.9-clang.html>
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NREL/EnergyPlus/commit/4dd29a6ee080fe2b2ad74057eb3e4cdef5ddac40#commitcomment-9448000>.
>

--
Richard Raustad
Florida Solar Energy Center
1679 Clearlake Road
Cocoa, FL 32922
Ph: (321)638-1454
http://www.fsec.ucf.edu/en/

Program Director
Electric Vehicle Transportation Center
http://evtc.fsec.ucf.edu/


Endline Madus...endline ^^


null check missing? pos < 0 check missing?
-> StringIndexOutOfBoundsException


They sure are. Thanks!


Done!


Yah, for sure. Still fun to play with. :)


DOORPI_PATH=/home/DoorPI

oder in DoorPI.sh von meigrafd den Pfad ändern


Ok, done.


- leagues & league apis added
- lines aligned in columns, like before


Tule so manjše spremembe, ki bi jih naredil glede moje prejšnje komentarje.


Done


@baskaran-md It was conflicting with some changes I made to the Build History pane, otherwise it works fairly well. I think I'm going to wait until #85 is merged into upstream before I cherry pick the changes though :)


You switched the arguments, but the docs are still wrong (doc block).

I tried using scope but now it doesn't work anymore. scope is in `$context['scope']` not `$options['scope']`.


In e336b1a gefixt.

Gut das du dazu schon einen [commit](b5b1bd) gemacht hattest: Wenn man versucht, das Problem mit den chromium developer tools zu debuggen, wird plötzlich alles korrekt angezeigt.


I can't disagree with that :P


ыфыф


Merged into master. Thanks.


Not sure if that joggling is good per se.
Maybe we should always attach the context as last argument to be safe?


You merged the pull request into develop, thus making a commit to develop, which spawns the CI machines to update just like any other branch.

There aren't any regressions checked on develop.  The last regressions run on that branch before it was merged show there were diffs in one file.  See the comment [here](https://github.com/NREL/EnergyPlus/pull/4670#commitcomment-9319821).  I think that diff was expected though.  Of course now that develop has "moved", all the other branches will show a regression against it.  And that is OK.


that had to be causing some issues lol


This should no longer be applicable.


-In this article, you’ll learn about:
+In this article, you’ll learn...


-
What the difference is between .* and .*?, greedy and non-greedy.
+
The difference is between .* and .*?, greedy and non-greedy.


Nice to know :-)


I grabbed these from: http://www.gnu.org/software/emacs/manual/html_node/emacs/Choosing-Modes.html


Thanks for the tip, I wasn't aware of this! (I had based my implementation on parseCriteria().)


@daenney ping, either I need to move my example manifest or I need a way to be able to hook into module sync


Boaz, it looks like this change broke the vRA LB / Application discovery logic.
The CSP_HOST property actually was referring onto vRA Load Balancer FQDN.
Now, after your change it points onto the components registry URL instead. This is incorrect.


What Regex Named Capture Groups are and why you should use them.


1277852-CommandLineInterface (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1586 of 1592 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.62%25-yellow.svg)


How to use String#gsub without and with the block syntax, and without or with


Hey wang, it seems this commit really did fix the kexec boot, but only for all Jellybean kexec roms (4.2.2 and 4.3) as KK 4.4+ and LP roms still don't boot. I'm looking into it and going to try different things, but I wanted to let you know we've finally made progress and would like to thank you for your assistance so far. :)


relevant https://github.com/Modernizr/Modernizr/issues/878#issuecomment-41448059 and https://github.com/h5bp/html5-boilerplate/issues/1605


Thanks a lot :) After 12.2 you'll see me contributing again probably (except i fail any exams :D)


Looks like the section labels/captions got caught in the code here


> I wonder if this should be static (and possibly final) so we can ...
I've introduced a parameter for such issues, could be null too :-) .


Whatever we do as far as CDNs go:

We need to implement a way to reconcile the bower included version of a dependency (jQuery) with the CDN version of it. If I include version 1.11.1 of jQuery in my bower.json, then the CDN needs to be set to load cdn.google.com/whatever/jquery/1.11.1/jquery.js.


The difference is between .* and .*?, greedy and non-greedy.


Any reason `extractMeta` is a NOP and not delegating to ember-data's version?


Here the target will probably be marked as dirty. And the counter will update itself again in case target will be saved down the road.

I don't like the direction of this patch because the correct thread safe increment and decrement logic should live in separated method and be reusable.

Please take a look at #11410.
I am not sure if it fixes this bug, but I think that direction is better.


What's the .gitattributes file for? Kinda curious, a lot of other repositories use it.


Looks like the section labels/captions got caught in the code here in the generated HTML


I think an example would be good here - e.g., the Animas Vibe combo insulin delivery and CGM system would have tags `insulin-pump` and `cgm`.

Another question here is do we expect to include `bgm` tag on pumps with linked meters? I think if we get the BG data from the pump on download, then we must...


Adjusted in latest commit


Simple String#gsub Syntax (remove "Non-block")


Should prevent improper severity (and other field) selections soon.


For this to work in docker 1.3.2, I had to put the 2 ENVs on separate lines without '='


there should be no comma here


Related commit: https://github.com/Walkman100/GitUpdater/commit/252cfe266087084ebf222a5b24ac420269059969


Related commit: https://github.com/Walkman100/Walkman/commit/0f5f51a85d26cf554fb702d2a92c7bf8dfda8179


Block String#gsub Syntax

Makes it easy to see and consistent between Simple and Block in the title


split this into two sentences


in Ruby, such as String#match, String#scan, and String#gsub.


Just use `(generate-temporary decl)` here.


Screw you git


object, whereas String#scan returns all matches, but the results come in the form of Arrays of Arrays.


The value passed into the block is the full string matched, rather than a


syntax. Instead of just returning with <code>$1</code>, you will need


Why remove this?


will probably ignore the passed in argument to the gsub block if you are using


@samth It's actually a part of racket/list and I reimplemented it in lazy/list.


Sorry about that..


Markdown will convert the leading 4 spaces to "preformat".


This is a great idea, but you'll need to make two changes before I merge.  First, we don't usually want to put links around code blocks because it makes weird formatting.  It would be better to have another sentences saying something like: Checkout the syscalls tutorial for a reminder on how to use `fork`.  Then the link would be around `syscalls tutorial`.  Second, you need to make the url a relative url instead of an absolute url (i.e. it shouldn't have the `https://github ...` stuff in the front.  This will make it more likely that the link doesn't break in the future.


@RNCDev hey! just mentioning your name here, I think you will be notified! We can talk about code here! This is good!! =) :+1:


Why was there any doubt? Of course this fixed it.


not really, je vais peut-être refaire from scratch éventuellement mais j'ai surtout updater le readme pour le monde qui tombe sur ce repo la par hasard.


@RNCDev I've used this website to generate the files we don't want to push to github. For example, generated files. Please if you see this. Reply! =) :+1:


@hsmade interesting. Have you reproduced on 1.4.1? The automated builds at https://registry.hub.docker.com/u/tumblr/collins/ are cooking along just fine. Please feel free to open an issue against collins and we can investigate further.

Out of curiosity, have you tried to use our tumblr/collins instead of building your own?


Bonsoir,

Est ce qu'il ne serait pas mieux de le mettre sur drive ou slideshare et partager le lien ?


Bonne idée


fyi `mailbox-name.donain` looks like a misspelling


Yes, which didn't work either. That's when I tried to build it. I'll give
it a go  on 1.4 tomorrow, thx!

On Mon, Jan 26, 2015 at 10:23 PM, Gabe Conradi <notifications@github.com>
wrote:

> @hsmade <https://github.com/hsmade> interesting. Have you reproduced on
> 1.4.1? The automated builds at
> https://registry.hub.docker.com/u/tumblr/collins/ are cooking along just
> fine. Please feel free to open an issue against collins and we can
> investigate further.
>
> Out of curiosity, have you tried to use our tumblr/collins instead of
> building your own?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tumblr/collins/commit/f0b8be6e58974dda66d61306b6ef7a274c736757#commitcomment-9448369>
> .
>


On the ride up, I realized that attempting to implement
polymophism in Avro to have more type safe records is a fool's
errand.  It's just the wrong tool for the job and the schemas
are going to get complex without much gain.

Also, for a union, the java code generation just generates a
reference to a type of Object anyway, so it's only run-time type
checking.

So here is my crack at a generic SeqAnnRegion:

   https://github.com/diekhans/ga4gh-schemas-genome-ann/blob/genome-annotation-generic/src/main/resources/avro/sequenceAnnotations.avdl

It uses a enum to categorize the feature into an easier to use
value for the common case.

Oddly, this is very similar to something I am trying to kill off
in the metadata schema.


In 4ae52db `databraid` now makes sure `tcross` is stored as a row-vector.  We might consider getting rid of this line since now it is a bug if it's not a row vector.


We're using 1.5.8 in self service...  Should we change it or any other projects to use 1.7.10?


DJN8
![image](https://cloud.githubusercontent.com/assets/5495274/5908736/3871fa02-a578-11e4-95eb-e8e16fcf2766.png)


looks good.


I have no idea.

But Google was made for the reason of searching. :P


Looks good.  Thanks for the fix.


Agreed. We should have a unit-test for this, though.


Made the Sidebar admin a mezzanine.core.admin.SingletonAdmin in commit 0075cab3dc7a2722e2218b396ed7c78893d744c1.


It's not critical. I wouldn't bother to change it if it's working as is.


1277852-CommandLineInterface (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


You're right, I guess it's fine to override `toString` in this one case. `Underscore` can't be used/abused anywhere else.


should we maybe call this class 'about-me'?


Shouldn't these properties not have "thekey" in them?


actual fix


The code is based on opencv sample (FaceDetection). The cascade classifier
we made based on the method developed by Viola Jones.

2015-01-26 15:00 GMT-03:00 nisakhairil <notifications@github.com>:

> I just figure the problem,just an error with setup the open cv with
> eclipse but i need some help from you about this code? Can i have ur email ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Asaffe/fruits_detection/commit/34c3d76bf2badfee468eae80d160e10bbdc6569b#commitcomment-9444851>
> .
>


Seems you coming through :) ... I'd say it were unlikely that if the server part was closing the connection, the libc on any platform on the other end would throwing EAGAIN. But of course some behavior diff is possible. Please keep in mind that under circumstances it could need a bit different handling which might need some ifdefs. Of course it were better (and is often) everything to be the same.

Thanks.


r u fucking srs m8


Broken English, no way to understand without reading the previous text. To fix, drop the 'for', add comma:

remove all constituent types FOR that are of the given type kind


@ysangkok
It may be applied to xorring as well, it's "sum modulo 2" operation after all. A proof ought to be provided that it's indeed safe to xor several RNGs.


I think this is a little problematic. There will probably be animations where the passengers are sliding into the elevator as it leaves. I think we need some mechanism to tell the elevator to not start moving.


Hi Bernd,

After discussions, we have created a few days ago the repositories Power_Packages_SMD.pretty and Power_Packages_ThroughHole.pretty. What are the reasons justifying an extra repository for SOT-669?

Carl


Yeah, they are still beaming around as usual. There was a tiny little beam connecting the engineer to the build bots that's now a beam to the building instead. Same look as the ACU


unneeded


If I remove that check on Linux, the test fails. If I leave it in, it passes...

On windows, if I leave it out, it fails but doesn't hang... If I leave it in, it hangs...


Dear

Your codes are concise and easy-to-understand.

Thank you for your advice.

Sincerely

From: bjimmykim [mailto:notifications@github.com]
Sent: Monday, January 26, 2015 10:43 PM
To: masatak/ProgrammingAssignment2
Cc: masatak
Subject: Re: [ProgrammingAssignment2] First Commit (d3e0fa8)

https://github.com/bjimmykim/peer-assignment/blob/master/cachematrix.R

2599a33325fe074feda45099bce1f91589d819d8

—
Reply to this email directly or view it on GitHub <https://github.com/masatak/ProgrammingAssignment2/commit/d3e0fa8725fecb80d644138a41f3761c88045078#commitcomment-9440281> .イメージは差出人によって削除されました。


Hi, Please let me know if there is a gem for this latest changes? (or) I have to clone and make a gem? Thanks, AM.


I'm proposing that
- error messages should pretty-print types for readability;
- in fact, many (but not all) callers of `toString` on `Type` should use pretty-printing instead;
- Underscore should be handled by pretty-printing (hence, it should probably move up if we keep this architecture — something I'm not sure about).


commit


So we're always creating the replicated stream for every site, which seems logical and necessary for generating consistent sequence numbers. Maybe remove the option not to create it -- spares the null checks, and probably should always create in test anyway lest we exercise code paths we'd never see in production.


Holy cow, this is awesome. :)


Let's get rid of this and set only 'fsync' on the client when it's a standalone. Avoid mutating client, db, and collection since you won't be able to in PyMongo 3.0.


Haha, YES.


Good change!


This won't work since OBJECT typed targets are used. You already have to use squeeze-backports to use glesv2, so cmake 2.8.9 can also be installed from backports.


I don't see this used or required in the integrations, but I do see underscore_string used but not declared here.


I think my priorities are something like:

1. Portable.
2. Fast.
3. Compact.

If using a certain number type makes Wren do something wrong on a platform we care about, I definitely don't want to that! If using a certain number leads to faster machine code, I like that. Otherwise, keeping it compact seems nice.

My intuition is to use `uint32_t`, but I think the right thing to do is probably do some profiling on different cases and see how it affects behavior.

I would definitely like to have some coherent strategy, and the codebase right now definitely doesn't. It's all over the place, which just reflects my own confusion about which type to prefer and why.


Perhaps, it is not a bad idea. Ideally the defaults.toml would never need to be changed - obviously this will not be the case as long as new coins come out though. The main reason not to is it is just adding one additional (and unnecessary) step to getting things setup.

What might make sense is to move the currencies and algos out to their own files - that might make more sense at this point. Anyways, I'll open an issue for this - I definitely agree its annoying.


É preferível usar a constante M_PI (que está definida em cmath) do que criar um define para o PI


I think I asked the wrong question. I meant to ask why are there ever commits that are not pull requested. We have put some great checks and balances (both people's eyes and automated tooling) to make pull requests a useful process for collaboration and continuing to make sure good code gets into master, and IMHO committing straight to master seems counter-active to those efforts.


Nice catch. I can see the support call we would have had now...


@bubnenkoff No, I didn't.


@jhaynie If this is for internal use only, why's the repo public? Wondering if we just need to change this copy, or if we need to go private...


Did you try to compile with `USE_FNAME_CASE`? It seems there's an extra argument here :).


pourquoi il a un couleur en dur lui ? (déjà avant ton commit )


what would happen if they passed a 0 or a 1 or something besides what this function expects?


Thanks @zalary, it's not currently used - it was from a different approach. Will get that out of there.


lgtm


I forgot to import the math module to use the pow function


Are you retarded?


Good job!


sorry these comments are sort of scattered, but

same question as on parseBool.  what happens if they send us something not expected.   what f they give the number 21000?  or what if they give us the actual value lendio expects, like '848'


Clearly, I broke it in my last patch. nice catch.


@hsmade checking the build logs, it appears the hub is running the build with 1.3.3. The current docs state that both with and without '=' are acceptable syntax. When i try a build with
```
ENV APP_HOME /opt/collins \
    LOG_HOME /var/log/collins
```
It sets the APP_HOME var to '/opt/collins  LOG_HOME /var/log/collins'.

Let us know how it goes!


Dear bjimmykim
Your codes are concise and easy-to-understand.
Thank you for your advice.
Sincerely


Retract my earlier comment. Obviously: want it to be one per node, not one per site (which would be overkill)


I'm running the script locally and not seeing the problem. Has it been already fixed by the later commit? If not, how I reproduce it? [This one](https://github.com/plum-umd/contract-corpus/blob/master/progs/1420482332997.sch) has multiple modules but I didn't have problem running it.


Yo dawg, I heard you like Runnables


Looks like there is a bit of duplication that can get cleaned up here.

```ruby
controller_path.split('/')[2..-2]
sub_namespace = "#{sub_namespace}/" if sub_namespace.length > 0
```


Mark Takahashi - 01/26/2015


/cc @drewolson


Once 1.8 lands I'm OK with dropping <1.6 support.


deleted!!!photo


Suport for polish characters
'filename' => '[ \w\\.\\/\\-żźćąśłęó,ŻŹĆĄŚŁĘÓ]+'


Great, very happy to go with "preferred form" phrasing and this has been a useful clarificatory discussion (at least for me!)


ah, I see they're indexed starting at 1 here, nevermind


This is for #2648


DBus-related function are marked as "since 2.26".
I don't really like that `USE_GIO` defines, it's better avoid them if possible. Maybe it's worth to package some newer version of GLib instead? GLib have little to no dependencies, so it shouldn't be hard to just recompile some newer version for Squeeze.


related: https://github.com/roots/roots/issues/1286


After adding in the html_safe to the raw method, some of the n1,n2,n3 ... is not in iths right places. Having hard time following why .

```
.....F......

Failures:

  1) Forme Sinatra ERB integration it should behave like erb integration #form should correctly handle situation Sequel integration with subforms where multiple templates are used with same form object
     Failure/Error: sin_get('/nest_seq').sub(%r{<input name=\"_csrf\" type=\"hidden\" value=\"([^\"]+)\"/>}, "<input name=\"_csrf\" type=\"hidden\" value=\"csrf\"/>").should == "0 <form action=\"/baz\" class=\"forme album\" method=\"post\"><input name=\"_csrf\" type=\"hidden\" value=\"csrf\"/> 1 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Foo</legend><label>Name: <input id=\"album_artist_attributes_name\" name=\"album[artist_attributes][name]\" type=\"text\" value=\"A\"/></label></fieldset> 2 n1 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Artist</legend> n2 <label>Name2: <input id=\"album_artist_attributes_name2\" name=\"album[artist_attributes][name2]\" type=\"text\" value=\"A2\"/></label> n3 </fieldset> n4 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Bar</legend><label>Name3: <input id=\"album_artist_attributes_name3\" name=\"album[artist_attributes][name3]\" type=\"text\" value=\"A3\"/></label></fieldset> n5 3 </form>4"
       expected: "0 <form action=\"/baz\" class=\"forme album\" method=\"post\"><input name=\"_csrf\" type=\"hidden\" value=\"csrf\"/> 1 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Foo</legend><label>Name: <input id=\"album_artist_attributes_name\" name=\"album[artist_attributes][name]\" type=\"text\" value=\"A\"/></label></fieldset> 2 n1 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Artist</legend> n2 <label>Name2: <input id=\"album_artist_attributes_name2\" name=\"album[artist_attributes][name2]\" type=\"text\" value=\"A2\"/></label> n3 </fieldset> n4 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Bar</legend><label>Name3: <input id=\"album_artist_attributes_name3\" name=\"album[artist_attributes][name3]\" type=\"text\" value=\"A3\"/></label></fieldset> n5 3 </form>4"
            got: "0 <form action=\"/baz\" class=\"forme album\" method=\"post\"><input name=\"_csrf\" type=\"hidden\" value=\"csrf\"/> 1 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Foo</legend><label>Name: <input id=\"album_artist_attributes_name\" name=\"album[artist_attributes][name]\" type=\"text\" value=\"A\"/></label></fieldset> 2 <input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Artist</legend></fieldset><input id=\"album_artist_attributes_id\" name=\"album[artist_attributes][id]\" type=\"hidden\" value=\"2\"/><fieldset class=\"inputs\"><legend>Bar</legend><label>Name3: <input id=\"album_artist_attributes_name3\" name=\"album[artist_attributes][name3]\" type=\"text\" value=\"A3\"/></label></fieldset> n1 n2 <label>Name2: <input id=\"album_artist_attributes_name2\" name=\"album[artist_attributes][name2]\" type=\"text\" value=\"A2\"/></label> n3 n4 n5 3 </form>4" (using ==)
     Shared Example Group: "erb integration" called from ./padrino_integration.rb:38
     # ./erb_helper.rb:159:in `block (2 levels) in <top (required)>'

Finished in 0.07464 seconds (files took 0.84084 seconds to load)
12 examples, 1 failure

Failed examples:

rspec ./erb_helper.rb:158 # Forme Sinatra ERB integration it should behave like erb integration #form should correctly handle situation Sequel integration with subforms where multiple templates are used with same form object
```


Bad habit on my part, and lack of other core committers making changes in a timely manner.  You're right though my changes should be going through the review process as well.


I'm not able to reproduce this issue against the current async-api branches.
do you mind linking to a sample mail, and/or sending a copy to test_imap_013@cdev?


it seems like this might be well suited to some string normalization.


What is the benefit of using Set instead of List? I am just wondering.


You're right. I'm not sure how that happened. Fixed in 5db52ac1c3c7f9fc5762a59dfbbb850d2bf1fa61


Hey that's a nice idea, didn't thought of it. Did you check the different log sizes by hand?


:+1: exactly what I was thinking.


First Commit


`find_xscreensaver_window()` have no GIO dependency, it's pure Xlib.


Armor, not armour. US spelling, not UK!


`deactivate_xscreensaver()` have no GIO dependency, it's pure Xlib.


Same here, it's Armor.


+1

On Mon, Jan 26, 2015 at 1:52 PM, Rufus Pollock <notifications@github.com>
wrote:

> Great, very happy to go with "preferred form" phrasing and this has been a
> useful clarificatory discussion (at least for me!)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/okfn/opendefinition/commit/6ee94fe4dff1a674347edcffd5e43bae37e6150e#commitcomment-9448744>
> .
>

--

Herb Lainchbury, Dynamic Solutions
250.704.6154
http://www.dynamic-solutions.com


Looks fine.  Ack


An input-sanity assert should still have *some* message.


This essentially cuts out XScreenSaver support, which can work without any GIO.


Ja, scheint zu helfen.


@ldacosta what's the point for all these interpreter objects? they are bringing in the appropriate implicits and then invoking ``FieldReader.apply``.
alternatively you could move the responsibility of bringing the right implicits in scope to ``FieldReader`` itself. then either ``FeildReader`` could simply provide a ``readField[T]`` method (rename and parameterize the current ``FieldReader.apply`` method) - or ``FieldReader[T]`` could provide a ``readField`` method (i.e., only rename don't re-parameterize) and we can do away with the objects here.

i have less of an opinion about ``readField`` vs ``readField[T]`` (i personally prefer the latter, since that allows the type annotation to be closer to call site - as opposed to the top level when mixing in something like ``FieldReader[T]``)


OK


@eschlange If I understand you correctly, are you essentially saying that the user is neither logged in nor that they are on the new_session path (for either user or participant)?  The reason - I believe - you specify the new_password path is b/c that is the only other page a user could be on besides the sign_in pages that allows them to not be logged in.  Given that, if we add another public view wouldn't we also have to place that in this file?  Would it make more sense to just check again that the user isn't on a sign_in path?  For instance,

def no_authorization_and_sign_in_page?
      !current_user &&
        !current_participant &&
         signed_in?
end

def  signed_in?
 (current_page?(Engine.routes.url_helpers.new_user_session_path) ||
 current_page?(Engine.routes.url_helpers.new_participant_session_path))
end

and then something like:

def no_authorization_and_user_password_update_page?
      !current_user &&
        !current_participant &&
           signed_in?
end

Thanks.


`AB` => `DEFAULT_AUTHENTICATION_BACKENDS`?


Pretty sweet


looks good.


Oh, I'll add those. I wonder how it works without `pthread.h` included.


This method is only used once so why pass in a boolean? I guess you are thinking it will be used again at some point?


first commit to spoon-knife


I'll change this to `pthread_create` which is used anyway in other parts of code. I don't like to add use of deprecated APIs.


model:make does import the full class. This is more for backwards
compatibility of people moving stuff over from L4.

On Mon, Jan 26, 2015 at 2:46 PM, Graham Campbell <notifications@github.com>
wrote:

> I think we should make people import the full class. I see so many people
> coming to laravel new (as there first php framework), and they don't
> understand that the Eloquent class doesn't actually exist - it's just an
> alias to the Model class that's namespaced.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/laravel/commit/7dc60a86dc66a92d5046e811cb4fb325250c7a3b#commitcomment-9447781>
> .
>


The 3 genre background images are removed, but for other skins it is still possible to use with the following: "stringcompare(RDS.radiostyle,"NAME")". The NAME's are visible in below structure.


A window can be re-sized so small that a negative number could be returned for scale, this is a catch to prevent it.


As requested the mod of the PVR channel OSD menu with channel logos instead of an list point


comment!


Isn't the return value of `TextEditor::screenPositionForBufferPosition` in screen space rather than typewriter space, though?


Ok, can we remove this alias in L5.1 then please? That gives people time to update.


Addition on line 189 was for testing purposes and can/should be deleted


typo: s/cab/can

I'll fix it directly, as it's the only problem I can find :)


thanks, looking forward to seeing this live.

Note that Emacs does a few weird or unexpected conversions of `mode:string` into the actual mode.  Probably not a big deal for the initial release, which can just follow Linguist's list.  But for a second pass I can dig deeper into Emacs if that would be useful.


There seemed to be some invisible characters after desc =, I've removed them !


really... not much we can do in collectd.c without COLLECTDC_H?


Reviewing this diff is easier if you append `?w=1` to the end of the URL: https://github.com/cdzombak/INDLinkLabel/commit/ef134fe8c0c82d016d5e854de1743a865ed25541?w=1


I think the spacing is off here.


Since it's Java, I thought I could write once, run away.

A little piece of my soul died when I wrote this.


@RNCDev Look at this! I am not using setOnClickListener... hahaha

Check out the issue page and you will see this library called butterknife.


Hi John, I can confirm the change you made today corrected the i18n hierarchical URL issue but now there's a problem with the canonical URLs. When I view a post, it shows <link rel="canonical" href="http://mydomain.com/blog/" /> instead of <link rel="canonical" href="http://mydomain.com/blog/my-post-name/" />


> But for a second pass I can dig deeper into Emacs if that would be useful.

That could potentially be very useful. Thanks for the quick review!


I think "the structure" is here too many times. :-)


I can understand not capitalizing most comments, but I see no reason for lower-casing an acronym.


Same as above.


Why did you remove the check for start_tls and ldaps://? They're mutually exclusive, it should be a startup error.


You are right, but that if I understand the RoboVM correctly, I'll have to do a bit of refactoring of plugin first, otherwise it will be very ugly. So I used this for now, which is the same as what previous versions did. I'll look into the mixed IPAs soon though.


You seems to be more then able to do this yourself! Let me know if you need any help


This breaks new discussion posting.


HAHAHA


can you send me a pull request?


The issue is not a big deal and not notable by the user. But it was so eye catching during debug.
Owens calculation is correct. The issue is that the old version does not reach the new gain, while the new version does. This is in line with copyWithGain().
Lets assume we have a buffer size of four frames and change the Gain from 1 to 2 and back to 1 within four callbacks. The gain_delta is (2 - 1) / 4 = 0.25
Old version will be:
1.0 1.0 1.0 1.0 | 1.0 1.25 1.5 1.75 | 2.0 1.75 1.5 1.25 | 1.0 1.0 1.0 1.0
New version will be:
1.0 1.0 1.0 1.0 | 1.25 1.5 1.75  2.0 | 1.75 1.5 1.25 1.0 | 1.0 1.0 1.0 1.0
| is the point where the new Gain is applied. You see, that in the original version the gain still increases in the third callback even though the target gain requested by the user is already 1.0, lower than the current gain of 1.75


To be honest, in Laravel 5 I find myself very rarely using facades at all, I know this isn't a facade but  the whole alias system seems defunct now there are so many ways to use things in to your application.


If you have at least one true RNG, it is a one-time-pad, which is proved. The case for PRNG's is more tricky, I assume that's what you're looking for?


`Calculate()` assumes an object. Posting a new discussion requests an array. Havoc ensues.


Can you send me a pull request?


82420068_GridViewMultiEdit (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.24%25-red.svg)


What is this package used for?


http://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes

Seems interesting.


> To be honest, in Laravel 5 I find myself very rarely using facades at all, I know this isn't a facade but the whole alias system seems defunct now there are so many ways to use things in to your application.

I agree. I think we should only alias the things you might want to use in your views. In L5 most of the stuff can be achieved using the new global helper functions even then.


It looks like some of the errno codes are different in Windows... Hmmm.


Sure. Was inspired by https://github.com/stianjensen/wikipendium.no/blob/master/wikipendium/settings/base.py#L183


What's the new default xbian user password? `raspberry` doesn't work anymore on the image from 24-01-'15?


I created a rake task to extract it. From squerb_foundation, run `rake update:old_input_dependencies_js[port]` where `port` is the port widgets is running on. I defaulted it to 4000 but I use 9000.


82420068_GridViewMultiEdit (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


What is a protokey?


@lukert33 - why do you have an explicit require for this? Rails should just load everything under app


Agreed. In L4 I made an effort to not use aliases in my views but now that is exclusively why I am using them


I just meant that the maintainer credit as Jasonm23 is fine.


calling the ``foldLeft`` on ``thePath.drop(1)`` would work instead.
```scala
Seq().drop(1) === Seq()
Seq("hello").drop(1) === Seq()
```


architecture.md ligne 328 : un @importpar dossier ;
ajouter un espace après @import


hello please tell me how to do it denogage program I try there u message out that we must help the administrator
here is my email (ligaban@yahoo.fr) my number (0634776753)
thank you


Hello Carl.

> After discussions, we have created a few days ago the repositories
> Power_Packages_SMD.pretty and Power_Packages_ThroughHole.pretty. What
> are the reasons justifying an extra repository for SOT-669?
>

Sorry, i wasnt aware of this.
But could you be so nice and move the files to
Power_Packages_SMD.pretty?
I have a very slow connection, only 5kbs.

PS: Also i noticed i put the .wrl and .wings files also in this wrong
folder.

With best regards: Bernd Wiebus alias dl1eic

Am Montag, den 26.01.2015, 13:36 -0800 schrieb CarlPoirier:
> Hi Bernd,
>

> Carl
>
> —
> Reply to this email directly or view it on GitHub.
>
>


Nit: would be good to comment here so future readers know what value this represents without having to read more code or look up the commit comment, i.e. something like:

```
  wakeUpAlarm: 60000, // ms, i.e. 60 seconds
```


Not sure you really want this in here. Normally, you keep files out of your workspace that you don't want to publish, unless they are files that are necessary for all developers to use this project. Hope that makes sense.


Seems fine


Same goes for the `.gitignore` file.


Есть причина, по которой это всё запихано в один большой коммит?


This commit looks like a minor correction. Do you think you could squash it into 936df47 and force push to the same branch?


Done.


Returning 0 does not indicate an error.  It indicates 0 CPU's, which probably is an error scenario.
However, there is no clue to the end user as to *why* the error occurred.
Also, the way you have structured the code, you are now masking
Exception which may be potentially thrown by cmd.run() which is not good.

Instead of letting an exception be thrown, I would recommend you
restructure the code slightly to something like this:

    if not cmd.has_key(__grains__['kernel']):
        print("Operation not supported on %" % (__grains__['kernel']))
        return 0

    data = __salt__['cmd.run'](cmd[__grains__['kernel']])
    ret = int(data.strip())


The build team has reviewed this update for the next release.


I tried some things. My first commits and code rewrites ever. Although it are just some ctrl-c / ctrl-v from the sickbeard / couchpotato modules;). Have some spare time at the end of this week to try a bit more. I'll let you if i'm stuck


Cool thanks for chatting it through. Happy to add people on to help lighten the load.


Thanks. I'm going to test GitLab now.


Well you can come along way with copy paste, google and stack overflow :D


unless


@weltling Before this change, did the test case pass on your machine? (not just not block, but actually pass).   Also, is there a definition of the actual numeric codes for errno for windows? It seems to be different than posix.


unless :)


Needs to be paired with:
https://github.com/ojkelly/civicrm-packages/commit/4e88b13ef5263ac874c9922c2dd6c1051a59f1f0


Fixed in commit f847994


The same goes here as for 47f69d7 and da0d180. This commit doesn't seem to be relevant for the history of the `MailAddressGenerator` class. Do you think you could squash it into 936df47 and force push to the same branch?


What I get coming back from the client side is:

num bytes read: -1
nr_bytes <= 0, errno = 11 (Resource temporarily unavailable), err = 2,  retry = 0, ssl_pending 0
stream->eof = 0

I get this 2 or 3 times, and then the test fails with:

Warning: file_get_contents(https://127.0.0.1:64321/): failed to open stream: HTTP request failed!  in C:\php-sdk\phpdev\vc11\x86\php-src\ext\openssl\tests\Serve
rClientTestCase.inc(92) : eval()'d code on line 8
bool(false)


Btw, it would be wise to make branch where you commit all headphones stuff and leave master branch alone. Unless you are gonna delete the fork later


Running
<pre> c:\php-sdk\phpdev\vc11\x86\php-src>php.exe -c C:\php-sdk\phpdev\vc11\x86\php-src\php.ini ext\openssl\tests\bug65538_001.php </pre>


@rjcruz rodo aca tambien hay que poner por defecto al owner en status PENDING_SUPPLIER_VOTE o lo que fuere. Sino queda en PENDING_ASSISTANCE_CONFIRMATION y ya el chavon esta ACCEPTED


this is the hell xDDD


recursive?


@davilla fyi


Great. @wolftune could you send a PR with your precise suggestion for 2.2.5 and any suggestion you have for making other clauses use the same language that I believe you mentioned on-list? Then we can comment on that commit further if needed. Thanks all.


I'm confused as to why you did fix those two un-necessary semicolons, without fixing the exact same un-necessary semicolons in the function `getNoun`.

JSHint should have caught them all.

https://github.com/udacity/frontend-nanodegree-mobile-portfolio/issues/2


In order to run multiple TrifleJS.exe in parallel, each with a different version of IE emulated, we have to use different file names (for example: TrifleJS.IE8.exe, TrifleJS.IE9.exe, etc.) to associate a different registry value for each of them. Get the file name at runtime and set the registry value for it.


Use item**2 instead of item*item


Oh, is there a way to get a process ID in Windows, to print out with the debug prints?


The test case shows scope working as a validator though.


In accordance with convention, use underscore_case for method names


Mükemmel olur


I can surely do that for you. I will approve your footprint and 3D model before however. I don't have access to a recent version of KiCad right now, but I should have the time tonight.

Thanks!


Will this still work on older browsers using the prefixed version?


Your pull request solved this problem. Cheers.


Тесты теперь не проходят. Я пока откатил эти изменения


@skeptical @valib are you sure? Because I tried every level of escaping, between 3 and 7 backslashes, and they didn't work


This is OpenSearch client instead of the REST client.  This was breaking the integration tests.  I already pushed a fix to master.  I renamed the clients to avoid future regressions.


It seems to me taht there is a date overlap. Use test_legislation to detect this kind of problem.


travis build failed:
````
[lib/checkbufferoverrun.cpp:931]: (warning) Found extra whitespace inside Token::Match() call: "%varid% [ %any% ]  = 0 ;"
````


Thanks! I will do that :)


working according to test's specifications


The text case might work because the strict check applies for null being passed, If it is an empty array or alike it might be different. At least in my real life scenario the order was wrong.

I hotfixed it merging the params for now, but we should probably into it.


Don't use return without the necessity


I love this!


I guess you can also argue that you've improved the latency by one sample :)  This seems ok.


1277852-CommandLineInterface (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1581 of 1586 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.68%25-yellow.svg)


@ysangkok
Assuming that xored RNGs don't give normal distribution, do we still have the problem of possible correlation between the generators?


bla


`provide a configuration file`


classic ^^


Leona, could you elaborate on this commit message? What new resource are you adding and why? I can get that information from reading the patch, but the commit message should be a self-contained summary.

It's also customary to finish each commit message with a Signed-off-by: tag, http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=4e8a2372f9255a1464ef488ed925455f53fbdaa1#n286


@SubJunk try it and you will see :)


As with 'factory_girl' and 'dotenv', that module (kept in app/models/) was not loading into my controller unless explicitly required.


Wir können auch eine *.txt* Datei daraus machen um Ärger unter WIN usern zu erspraren.


@mariomariani yes, we should remove one of the functions
Thanks!


Two things:
- `code according to the guidelines` could be `code according to the style guidelines`, although `to format code` might already imply this.
- Might want to mention `git-clang-format` to avoid people running clang format on 10,000 files for their one line change, at least initially. Ideally everything will be properly formatted, so a one line change not following the style guidelines would still result in a 1 line diff.


Le data-main="../app" indique le point d'entrée de l'application, qui est ici le fichier app.js.
Tu n'as pas besoin de l'inclure encore une fois.


Thanks for this new quicksim wrapper.  One quick but important request: please reformat the code to use 4 spaces for indentation instead of 6 (or did you use tabs?  I can't quite tell from the github file browser).


82420068_GridViewMultiEdit (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.24%25-red.svg)


It's a really bad idea to use the exact same commit message for two patches or more, because it's impossible to tell them apart without delving into the diffs. Could you use a different title for this as compared with the first one?


What is the purpose of the --model option?  It doesn't look like it is needed; the model values should come from the fibermap file, not the command line.


This line makes me slightly uneasy in a couple of ways, but both of them are minor.

First, excepting the call to ``initalizePlugins()`` I think you need ``self.schema`` as an instance variable for single frame measurement, but not in forced. Given that, it seems unfortunate that the base should insist all subclasses provide it. Maybe consider passing a schema argument to ``initializePlugins()``?

Second, the name of the method here is a wee bit grating -- "edit output schema" sounds like something you'd do quickly and then put it back, whereas you're actually getting a reference to it and then holding on to it. That method name isn't something you're setting here though, so I guess I can't quibble.


this isn't going to work because we dont have a unmarshall_dataout method in ModeSense6


version 0.4.0 released


Hello Carl.

> I can surely do that for you.

Thank you very much.

> I will approve your footprint and 3D model before however.

This would be nice, too.

The Footprint is made by this suggestion:
www.nxp.com/documents/leaflet/939775016838_LR.pdf page 9

and the mesh model by the datasheet of a PSMN028-100YS Transistor from
NXP.

I guess the link to the datasheet could be this:
http://www.nxp.com/documents/data_sheet/PSMN028-100YS.pdf

With best regards: Bernd Wiebus alias dl1eic

Am Montag, den 26.01.2015, 14:40 -0800 schrieb CarlPoirier:
> I can surely do that for you. I will approve your footprint and 3D
> model before however. I don't have access to a recent version of KiCad
> right now, but I should have the time tonight.
>
> Thanks!
>
> —
> Reply to this email directly or view it on GitHub.
>
>


Can we use regular for loops? The forEach has measurable perf impact. I know it is in compile only, but best not to do that.


@lichti1901 Haven't built yet, thanks for the heads up :P


Nice to use md 'variables' to point to a layout based implementation on SoundCloud API. Well done!


this is about the location of library. if this is a node package we can tell where the library lives, i.e. in the bin folder next to the package typescriptservice.js. if this file is consumed in a different method, e.g. including typescriptservices.js in an html file, we have no way of knowing where the library is, and this API should not be used.


It looks like --airmass and --exptime are needed because I forgot to include that information in the input simulation files.  OK to leave these here for now, but I'll add that information to the headers of the input simspec files and then we can remove these options.


Oh, that's good to know.  No need to redo the register step, right?


What about system.lineseparator (or whever its called, nio.filesystems.getLineSep.() s is a wrapper

~ iPhone


that means that this is not maintained. you want this to be the host, not the reslting object. the other option is to use host.getCurrentDirectory.bind(host) to do that.


82420068_GridViewMultiEdit (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


i am not sure i understand the proposed change,, can you elaborate.


@valib cool it works for me too, thanks for the fix :)


Better to just make nstart=0 and nspectra=500 as the defaults in the argparse parser, instead of checking for None and resetting them here.


Register just link name to your repo url and nothing else. It's not affiliated to version anyhow.

Just remove version string and be happy :)


a different implementation of IScriptSnapshot. this one is a simple utility to go from string to IScriptSnapshot.


@nirvdrum we should start expecting the rubysl specs to have zero failures. With things like ERB where you can't load the specs yet due to errors in the fixtures of `before` blocks we can exclude like this for now, and you can `untag` when you want to see if they're running.


I feel like this is cheating, or at least exposing information in the wrong kind of way.
This should be exposed with timestamps (or age) associated with the up/down buttons on the floor object. Getting it from the users does not correspond to reality and increases coupling, making tests harder to write.


test


Since `convolution-effect.html` and `convolution-effect2.html` is almost identical, I think it is better to get rid of this file. Please disregard this pull request.


```js
	function addLink(post, m, loader, link, isYtube) {
		var msg, src, time, dataObj;
		if(!post) {
			return;
		}
```


It doesn't work, if I call method with array [2,2,2] (for example), then args - [args.min] returns empty array


Code style: clearer to use dictionary keys of 'b', 'r', and 'z' instead of 0, 1, and 2 so that later code looks like wavelimits['r'][0] instead of wavelimits[1][0].  The loop over arms would then be:

    for arm in ['b', 'r', 'z']:
        ...

instead of

    for arm in range(3):
        ...

i.e. try to refer to spectrographs by integers 0-9, but arms as characters 'b', 'r', or 'z' instead of 0,1, or 2.


You should stick an @author tag up here on every file you've added @joecohens


I don't think the key check is necessary. It will just be nil if the key is present, and the guard below will take care of it.


1277852-CommandLineInterface (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1586 of 1592 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.62%25-yellow.svg)


Coding style: reserve ALL_CAPS for constants that should never change.  Variables should be lowercase.


It sure is!


Although `pattern.match()` intuitively sounds correct, this actually fails if the match occurs in the middle of the target string. The `search()` operation should be used instead.

> "Python offers two different primitive operations based on regular expressions: re.match() checks for a match only at the beginning of the string, while re.search() checks for a match anywhere in the string."

https://docs.python.org/2/library/re.html#search-vs-match


This is also cheating. :)
The elevator couldn't possibly know the intentions of the users.

I think this is already somewhat solved with getPressedFloors() in https://github.com/magwo/elevatorsaga/pull/43


Sorry for being a bad project curator, will download and merge as soon as I get some free time


See above comment about using 'b', 'r', and 'z' for keys of the dictionaries, and "for arm in ['b', 'r', 'z']" to avoid having this armName lookup.


FYI: this trailing `,` makes this invalid JSON


@rneher --- Site is live at: [nextflu.org](http://nextflu.org)


This should be in handleDestinationArrival() if needed.


Good point. I intended to return and fix the rest. I just did. Thanks for the reminder and sorry for the confusion!


HHAHAHA, I knew if I planted a hint in your ear, you would do it :)


Yeah looks good, nice job!


Can you please open an issue and provide a reproduction script to demonstrate? I'm unable to find a case where the object is left marked as dirty afterwards, or where the counter cache is included in the rest of the columns marked for update.


Maybe move this to `generate_assessment_zips.py`, so it's defined where it's used?


wip ... need to swap r and b and also need to handle videobookmark ...


1277852-CommandLineInterface (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


buena @blackjid


Actually looking a little bit further, this incrementing occurs in a place where it cannot possibly cause an object to be marked as dirty.


Sweet as :+1:


@buildmaster RE your last comment have updated :)


Alrighty, looks good. Ack


I can code in C#, mcml and XAML but XCode escapes me.


Ack


Still doesn't work
```shell
~# bash lf | grep -v /usr/lib/node_modules/ | wc -l
6678
~# bash lf  | wc -l
7457
```
where `lf` represent master version


I think you misspelled version somewhere at the beginning...


And adding some required includes...


Ah - great catch, thanks!


I tried reverting just this change, and it did cause deoptimization with node 0.11.  It was soft, though.  Output:
```
[deoptimizing (DEOPT soft): begin 0x13d23ff4c641 slice (opt #2) @10, FP to SP delta: 48]
            ;;; deoptimize: Insufficient type feedback for LHS of binary operation
  translating slice => node=287, height=32
    0x7fff5fbff0b8: [top + 80] <- 0xb3d2a149399 ; [sp + 80] 0xb3d2a149399 <String[23]: <http://commonmark.org>>
    0x7fff5fbff0b0: [top + 72] <- 0x100000000 ; [sp + 72] 1
    0x7fff5fbff0a8: [top + 64] <- 0xffffffff00000000 ; [sp + 64] -1
    0x7fff5fbff0a0: [top + 56] <- 0x1062222069d5 ; caller's pc
    0x7fff5fbff098: [top + 48] <- 0x7fff5fbff0f0 ; caller's fp
    0x7fff5fbff090: [top + 40] <- 0x13d23ff841f9; context
    0x7fff5fbff088: [top + 32] <- 0x13d23ff4c641; function
    0x7fff5fbff080: [top + 24] <- 0xb3d2a149399 ; [sp + 16] 0xb3d2a149399 <String[23]: <http://commonmark.org>>
    0x7fff5fbff078: [top + 16] <- 23 ; rdx (smi)
    0x7fff5fbff070: [top + 8] <- 1 ; rbx (smi)
    0x7fff5fbff068: [top + 0] <- 4294967295 ; rax (heap number)
[deoptimizing (soft): end 0x13d23ff4c641 slice @10 => node=287, pc=0x106222191dab, state=NO_REGISTERS, alignment=no padding, took 0.039 ms]
Materialized a new heap number 0xffffffff00000000 [-1.000000e+00] in slot 0x7fff5fbff068
[removing optimized code for: slice]
```


I know its unimportant, but I really want this center aligned!


This also exposes information that is not intended to be exposed. The floor object shouldn't know how many users are on the floor.. what is known is that the up or down buttons have been pressed. Sorry!


Found BROKEN by quick.
Here's the log file for step 'all_1':
```
[ 10%] Linting casadi_qcqpsolver_socp
[ 10%] Built target lint_casadi_qcqpsolver_socp
[ 10%] Linting casadi_linearsolver_lapacklu
[ 10%] Built target lint_casadi_linearsolver_lapacklu
[ 10%] Linting casadi
mx/mx.hpp:491:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
Category 'whitespace/end_of_line' errors found: 1
Total errors found: 1
make[3]: *** [casadi/core/CMakeFiles/lint_casadi] Error 1
make[2]: *** [casadi/core/CMakeFiles/lint_casadi.dir/all] Error 2
make[1]: *** [casadi/CMakeFiles/lint.dir/rule] Error 2
make: *** [lint] Error 2

```


The cases themselves should also be intented a level.
See for example https://github.com/xoreos/xoreos/blob/master/src/common/hash.h#L73


* Yes, I think that's better. I didn't want to repeat "style" too many times, hence the current wording, but with the other change, this won't matter.
* :+1:


I was seeing `el.name` be lowercase whilst `el.data` was uppercase.


Hi! The devel branch of my fork solves the inline code css issue...it will be included in the next release =)


I ran into this same issue today in my own code that updates userAuth and syncs those changes to the session. Is this due to some change in `PopulateWith()` that now it will copy values from int to string but wouldn't allow the copy before before? (`userAuth.Id` is `int` and `session.Id` is `string`)


@cpjolicoeur Thoughts on changing this to a string? Otherwise it gets marshaled into a string or raw bytes. Couldn't find an easy way to fix it except by storing the string on creation


should everything that uses meta instead use this.subscription.get and this.subscription.set then you wouldn't need the updateSubscription method at all.


@jeffgabhart `PopulateWith()` hasn't changed for a while, the AutoMapping tries to coerce where it can.


I just added a `Header.mem` as a faster test for this in mirage/ocaml-cohttp#243  (assuming that not having a Host header will be the most common case)


Oh OK. Good. :)


Changes from ff0000/generator-red-static#11


Changes from ff0000/generator-red-static#12


@chrisleavoy, yeah, could be. Though I didn't add it to the events_handler.go since it's possible that some might trigger events on other nodes which may not be the leader.


1277852-CommandLineInterface (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.49%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Simpler:
```
pg_controldata ${OCF_RESKEY_pgdata} | sed -rn 's/^Database cluster state:\s+(.*)/\1/p'
```

Also, we should check the output of pg_controldata is always in english, and set LANG=C if it might be translated based on the system setup.


Any reason why this is not using `Plug.Conn.Cookies.encode/2`?


That still references shader**C**ode, with the uppercase c. The doxygen comment a few lines above too


Still the wrong copyright comment header here


Agree, nixed.


Still the wrong comment header here too


Capitalized all references.


Still the wrong copyright comment header here too


@SubJunk thanks. Anyway I don't understand people who names the media files in that way.


I think it's better to be as specific about what kind of exception you're catching as possible, so that an unanticipated error can't just slip through the cracks. What kind of error do you anticipate being raised here?


No problems. I did find that the GitHub GUI client was installed along with the shell, and that the GUI seems to be ignorant of anything done via the shell, e.g. a repo cloned in the shell UI didn't show up in the GUI unless I cloned it again.


it looks like this writes the files into whatever directory you were in when you ran the code.  It should use the NIGHT and EXPID from the input files and by default write to $DESI_SPECTRO_REDUX/$PRODNAME/exposures/NIGHT/EXPID/*.fits .  A command line argument could override that default to write somewhere else for testing.


Is setting all the flags the desired behaviour, or should we just set the general failure flag and leave the others alone? Would the fact that ``flag_apertureTruncated`` & ``flag_sincCoeffsTruncated`` are _not_ set when we set a general failure be useful information in figuring out what went wrong?


for (


for(


You're right about the doubled line.  Fixed.  I don't use node_modules so I can't test that the code contributed in https://github.com/graysky2/lostfiles/commit/89e02faf0e47602b50fe5b7450a5acebf7183e0e works.  Please refine and send a PR.


I'm not sure what IN_PSF and IN_IMG should be for this quick simulator, but they shouldn't just be a literal copy of what was in the example in the datamodel with the arm and expid replaced.  Maybe just drop these two keywords for now.


indent++


Yes. If you don't see speed change in benchmark - it's ok to ignore such reports.

Look at `(DEOPT hard)` first.


**re-salve** ficou estranho. Eu colocaria: **salve novamente** :)


These I/O pieces are ok for now, but eventually we should write desisim.io.* routines for reading/writing each of these file formats.


Please make that ShaderInstance, with a capital S. struct and class names begin with a capital.


Thanks for the explanation -- I understand now :).


This doesn't seem to listen for new group chats being added to an existing connection?


Are you thinking startScene is going to be the platform independent way of starting a scene? I was just looking at how this is different in the Mac vs. iOS templates.

Consistency will be very good, since it's currently only used with iOS, right?


This should not have been committed.  I have deleted .gitattributes in a new commit.
The presence of .gitattributes was causing windows users to see all files as modified, even .png for some reason.
The default behavior of git is to checkout windows style, but commit unix style.
Users can also `$ git config --global core.autocrlf true`
See https://help.github.com/articles/dealing-with-line-endings/ for more info.


this is good work


Small vg demo. I haven't put it into examples html page - not sure whether it will work in gh-pages.


No, just on the classes, nor on the top level comments.


I had no idea it worked this way. Awesome.


Certainly wouldn't hurt to coerce it to lowercase here though.


 I can see components pulled to /tmp, and then I get:
"Set devtools.debugger.remote-enabled pref and manually accept incoming connection. To avoid conflict, only one running app can have this pref set."


Those priorities are among the main reasons why I gained interest in Wren and started using it as an embedded language. Can't agree more.

For now we can switch to `uint32_t` (which is the same as `size_t` on 32-bit platforms). I don't expect this to affect performances on 64-bit CPUs (given that handling native-sized variable is theoretically faster).

As for the global strategy, I guess it will become naturally clear and auto-define itself during the development. Some generics guidelines are to be found, 'though.


test


So the point here is that (on every iteration except the first) we're just copying from ``measRecord`` to the flag handler, and the call to `setCenter()` is purely incidental? I guess I see the logic, but I think it makes it a little awkward to read, even with the comment.


He wanted to try it


This is called in bash conditional tests and should conform with command success return code. So you should not use OCF code here, but return 0 on success. I guess this function body could just be :
```
return test "$OCF_RESKEY_startable" = "" -o "$OCF_RESKEY_startable" = "$(uname -n)"
```


Ok. Thanks so much!


Shouldn't it be PKG_MAINTAINER:= near the PKG_NAME:= field?


According to http://tools.ietf.org/html/rfc6265#section-5.4,

```
 When the user agent generates an HTTP request, the user agent MUST NOT attach more than one Cookie header field.
```

Any reason why Plug is making a different assumption here?


I thought we were not a fan of putting code into the __init__.py


I left it in because I wasn't sure if macros and routines really *should* look exactly the same, so I thought someone might want to tweak this in the future. Given I don't want to write and support a separate latex command for each, I'm happy to swap it  though. That would give us sstroutine and sstroutinenolabel.


This seems to break regular command-line Sass 3.3.14, which then fails with:
```
    File style.css is a CSS file.
    Did you mean: sass --update style.scss:style.css
```

Is this expected?


86714894-BoostSuperBuild (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2071 of 2190 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.57%25-yellow.svg)


move to the project class!


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/3316/console
Build was first broken at http://ci.cgeo.org/job/c-geo/3315/