Should have two empty rows between class declaratoins. #nitpick


Not that I can think of.
On Mar 3, 2015 4:19 AM, "Alex Curtis" <notifications@github.com> wrote:

> @brianhyder <https://github.com/brianhyder> I have a separate page_service
> that reads the page_media for a page. Are there any other places that
> reference media? -- Currently I have article, page and custom object (peers
> + children).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alexcurtis/clean-pencilblue/commit/c8525de1d537cc7e04b74967c5ac164b94b2c006#commitcomment-10001900>
> .
>


Doing this transform within the `$not: { $not:` collapsing is confusing. Do it separately.


Fixed nested-group sample application


if i remember correctly,
it was i who suggest to use 1 letter back then in *athena
lol


Is this change needed?


@vsizov These changelog entries are in the wrong section. They should go to 7.9


This sounds very promising !

I do not think we follow too much the sonar because it is very accurate so we should follow it.

About the biases, the baro bias looks OK, difficult to say from the graph if it is drifting over time, or if it takes time to converge. If it is the later, then higher P at initialization may help.

The accelero bias varies too much, (1m/s2 is huge!). I think it overcompensates the noise of the other sensors, we might reduce the associated variance in Q to put more trust in the model.

Very weird that the estimates follows the baro and has an offset with the GPS.. It should be the contrary.

Getting there!


too high?


Hey peeps, I get notifications for all this because that's how organizations work I guess. I couldn't help but notice you're treating function names like they're unique, which is kinda dirty. Your new name is probably not going to cause problems bit there's no need to risk it. You can do equality checks on functions directly. If you're worried about multiple spinners duplicating the handling because they each create an exit function, you can define the function outside of spinner to ensure there's only one instance of it.

There's really no good reason to be doing a check of function name. I hesitate to say 'ever', but I can't remember ever needing to do it.


Sagara, We are working on restructuring our carbon components (Some components going to be merged).. We'll fix these POM issues asap with that effort.. I have asked Damith to check on other comments that you provided..


Most recent commit from you doesn't work on my machine. Also found a import PIL line, are these related? Are you using PIL to get this to work?


Should be IManageable


I think this should be flowing through from script you run launching the job on mesos ./launchGuantlet.sh --mesos master://master:5050 --test.id 32352352352ab3 //something like that?


Why did you add PIL,

We've agreed to not use it.


We do no use wildcard imports as per https://wiki.openmrs.org/display/docs/Coding+Conventions#CodingConventions-CodeStyle


My rationale, keep header noise to a minimum and this take up two extra lines for questionable value.  But I don't code JS so I'm open.


Should be IManager


I can tell this branch is the bit of the code which does all the work, but it's really, really tough to understand how it's working -- can you make it clearer somehow (comments, refactor, var names etc.)?


@stefanpenner There was a typo here.


This deprecation can also be fixed in `config/environments/production.rb`


Why not just recurse for this, then leave the compress code to squash out the not,not?


Hi All

fatal: [ansible.server] => error while evaluating conditional: pwgrub.stdout.find('password') != 0
can everyone help?

Thanks
Harsono


Please use `strcmpi` instead of `strcmp`.


If you did $not compressing and $ne expansion separately, I don't think we'd need some of these tests.


Pure convention. Even more, watch out the first line, it should only contain `/*`, no text.


Hey, sure I agree but it's really low risk in this case and moving the exit function outside the spinner was not readily possible as `wrote` is initialised there. Moving `wrote` to the module scope could have had other side effects. To be honest I needed a quick fix and the impact is pretty low so I didn't bother too much, better than the warning popping out every few seconds. If you are ok with moving `wrote` outside of the spinner too, I can make the changes and submit a new PR.


You would need to add a @should annotation to the method being tested.
Have you seen this? https://wiki.openmrs.org/display/docs/Generate+Test+Case+Plugin


Just use a for loop to construct these. Easier to see how many nots in a `for (int i = 0; i <=3; i++)`


Please add this [jar](https://github.com/bsenduran/sample-recipes/raw/master/publisher-resources/admincall-auth-1.0.jar) in `ES_HOME/repository/components/lib`

And this [jar](http://maven.wso2.org/nexus/content/groups/wso2-public/com/nimbusds/wso2/nimbus-jose-jwt/2.26.1.wso2v2/nimbus-jose-jwt-2.26.1.wso2v2.jar) in `ES_HOME/repository/components/dropins`


I've gone ahead and removed the left over browser code and enabled the EXIF reader as well.
Rebase with master and remove this commit.


noted.. I will re factor this


Looks like you are making a lot of progress :)


I've also added a test to verify the EXIF data is read


@cassy1 Thx, done


Я не имею ничего против, просто раньше об этом не задумывался. Это я так вслух прокомментировал код.


Hey can you please publish it and provide gradle dependency for it? It will ease the usage that way. Thanks


Why should adjust it ? (My bad English...)


`mappingLanguages.contains(dbpedia_lang))` looks simpler


Не уверен, что будет работать для многопоточных программ.


Needs to iterate over EACH instance in the case there may be more than one.

Needs to parseInt and remove any additional characters: `5,342`


• pkgrel should be an integer.
• ".beta2.1" should be left out.
- Pacman relies on pkgver and pkgrel incrementing to determine if a version in the arch repo is newer than an installed version. Also, moving the beta version to the pkgver wouldn't work as removing beta version upon release will end up bringing the version back down to "14.2" which pacman sees as a lower number than "14.2.beta2.1" preventing an upgrade. Perhaps adding a reversed date (14.2.YYYYMMDD) as most pkgbuilds do when building from a git repo would be sufficient.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2207](http://teamcity.monogame.net/viewLog.html?buildId=5615&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


//Are these meant to have "@SmallTest" on them as well?


```
'label' => Yii::t('OrderModule.order', 'Настройки зазказов'),
```


It was fixed before. please refer to #41 PR


Good thing, this introduction. I'd like to add a tiny bit:

Tests not only assure that a thing works as intended but also that it _remains_ that way. Thus one can do a refactoring and improve code and one can be relatively sure that there are no old bugs introduced that were already fixed in the old code.


noted. will do the change


[SideCI/RailsBestPractices] remove unused methods (ApplicationController#admin_user!)
reference:


Yes we agree but right now the Helix repository contains `resource.language.en_gb` with version `1.0.3` but the `language_addons` branch ships the same addon with version `1.0.0` so it will automatically be updated to the addon from the Helix repository which is also outdated.


I have created the new register.


"inflicts damage on the {}" does not make sense for named creatures, such as "Adramelech, Lord of Fire". It is grammatically correct even without, however.

"Inflicts damage on Bitterwood Fox" (gramatically correct, even though inserting 'the' works too)
"Inflicts damage on the Adramelech, Lord of Fire" (bad)
"Inflicts damage on Adramelech, Lord of Fire" (good)


another constraint: File needs to end with `Test.py`


@ElizarovEugene ок, сделаю бекап и попробую руками накатить, когда появится время

@vlmaksime нет, он у меня и не пропадал никогда, все работает как часы, вот и думаю обновляться или нет, так как у меня 80% это релизы с лоста


You are right, @lavadiablo. It only fails when adding a gadget is the first thing you try to do on the page. However, if you first edit a gadget and then try to add a gadget, the button works. I was focusing on the 'edit' scenario and missed the first one.

Fixed on master for 7.0M2 and fixed on the stable branch for 6.4.3 under http://jira.xwiki.org/browse/XWIKI-11870

Thanks for catching this!


Per SquashedPotato suggestion we should also include a ".fa" rule, so it doesn't get overriden by ".global__image-outer-wrap--missing-image i"

His suggestion works alright:

    .SGPP__gridTileIcons .fa{font-size: inherit; color: inherit}


@Paxxi what are you doing?:) You completely screwed up formatting in this file.


I thought we are still asking players whether they want the die roll area to the left or at the bottom of the board?


yes


Weird indeed, why it returns in this order?


with this change,  `iter_lattice` is no longer tested.  is there a reason for this.


@Shazwazza I've tried to fix this by making `GetChildComments` return `ReadOnlyComment` but the results from that query are incorrect due to wrong annotations on the model. If I correct the annotations, none of the normal non-child comments work any more. So I took a shortcut. Help! :)


I didn't think 3 groups had been mentioned yet


Is it fixed here: 88d7168871536ea46c159f3a887dcc800cb2f617 ? If so, I'll accept ;)


Same here


@Shazwazza AAARGH. Yes, I did this, sorry. Remove it again and look at the wonderful YSOD on all of the forum pages that have child comments :/ Don't know how else to fix that.


I don't use this module, so I don't care so much. I just get spammed :) You guys were just talking about how to do it best, and seemed to arrive at something that is not it so I thought I'd interject.

Anyway I noticed you've got a PR back to Isaacs, so I'm sure he'll form his own opinion. Cheers


This one is not dodgy at all. Constness here applies to the pointer, not the pointed-to object. Metadata is *meant* to be modified while the Type object is frozen. That's the whole point of having metadata.

I just grepped the whole codebase for const_cast. The basic usage of const_cast is to get a non-const Type internally to typelib when the API user only has access to const Type objects. In other words, it is borne out of laziness for not building a complete duplicate const and non-const API for the 6 cases where it would be needed. (There are 7 const_cast, but the 7th is actually explicitely *adding* const !)


line 14 001


Slightly inconsistent phrasing of this check between lines 284 and 299/311?


line 75


考试系统


Indent these lines as in other inuit modules (example [here]( https://github.com/inuitcss/objects.pack/blob/master/_objects.pack.scss#L13)).


https://www.dropbox.com/s/lr28fob267lm7uh/Diagrama%20Paquetes.jpg?dl=0 aquí la foto de los paquetes, no se si estará bien


line 16 001


Looks awesome. A couple of things that look like they might have changed and it'd be good to check there are test cases for:
Cellar discarding nothing
Chancellor discarding a Tunnel - does *not* gain a Gold ("without tripping callbacks")
Mine doesn't let you choose to trash a non-Treasure from hand


This is the directiveName not the name of the field ;)


Yes please. That would be great! You need to generate a JavaScript translation file one your local machine if you want to see the Swedish translation.


Is that really required, you will set the release and next dev version during the release process anyways, right?


Works for me on Debian Wheezy, too. Nice catch - didn't know that until now! Might simplify a lot of things...

May I ask you to create PR for this?


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2207](http://teamcity.monogame.net/viewLog.html?buildId=5615&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 441, ignored: 6 Build time: 00:14:17


Intressant. Borde vi arbeta på denna? Isf behöver jag en introduktion. P.S kan vi chatta på FB?


cool thing, using the quoting as hint highlighting :) maybe we could do this too in other tutorials


Oh ok, thanks! Thought you were answering in Isaac's repo, got confused... You know you can unsubscribe to avoid getting spammed ;)

Agreed I should not have used that and would not generally. This module is the one that displays the spinner on the terminal when npm installs something. We use it as well for our cli. Use is pretty trivial and low risk hence the hack, but your comment makes me think I'd better send a different PR ;)


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


"throw new RDBMSConnectionException(e) " this thrown exception catches in an upper level and corresponding error logging is done there.


xzxz\z\


Aaaaaaaaaaaaaa


I have a few problems with this code. First, this expands the generated API, when I think you simply make a utility function somewhere that does the string-to-number conversion you need. Secondly, the error handling is inconsistent with our style, we never do this kind of multi-value return in APIs.  There are other issues but these are the main ones.

I'd like to revert this change.


READMEとサイト内に書けば良いと思います


noted .I will look into it.


noted. I will check on this.


这个文件最好能说明清楚
1.你这个项目的目的
2.别人怎么用这个项目
3.别人是否可以参与这个项目的开发


standard includes may actually be before that, however includes from coala will not work because they would be seen relative to the directory the test lies in. Thats why we add the "." to sys.path, maybe this helps a little more because PyCharm usually inserts coala imports before this and then you'll get an import error - so making this clear could help people fixing this error. (Just move the import behind the sys.path.insert)


@FriedSock Perhaps it was my fault for not starting off on 1.0.0 to begin with, but this gem is now in production and a fairly stable API so I'd rather it didn't stay in the development stage


filterM is lazy, not needed to rewrite findM implementation.
Try in ghci:
> let findM p xs = listToMaybe <$> filterM p xs
> findM (\a -> return (a>5)) [1,6,undefined]
Just 6


Thanks appreciate!


yes. however as mentioned i kept them there to let you test the add-on upgrade logic so we don't have to start bumping them in isengard repo yet. If all OK i will delete them from the Helix repo and all will be as normal.


I can go with that.


so this is actually more than some codestyle


actually this is wrong. Our test script will execute the file so you can write in your main routine whatever you want. However you should have a good reason for breaking consistency.


core and admin is different module, and you cannot import object defined in the another module.


Инициализацию полей нулями C# делает и сам. Если хочется, лучше писать инициализацию прямо в месте объявления поля, private int numberOfElems = 0;


incrimination must be by the end


ok fixed go to the repository and select the file then click on the pencil
to edit

*Nelson.R.*

On Tue, Mar 3, 2015 at 1:15 AM, abal274 <notifications@github.com> wrote:

> I'm not sure why it's not letting me edit this but there is an error it
> should be CREATE TABLE STUDENTS instead of STUDENT
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FatimahALhashim/no-line-up/commit/089180b1fc96e89e20471cf0bad1f153c0cb1b8c#commitcomment-9999806>
> .
>


Yes, it's :)


@eiriktsarpalis  - My feeling is that the "Distributed.*" operators need to be taught separately from cloud files - at this point in the tutorial sequence I don't think the learner has a strong intuition about what the "Distributed.*" do, or whether they bring advantages v. explicit pipelines.  Let's add a separate tutorial on that.

So my question here is really whether there is a big difference in performance between the CloudStream.* pipelines we used here originally and the Distributed.mapReduce operator?

(As an aside, one of the problems MBrace may have is if it is perceived to have a programming model that is "too big" - with new combinators that give special results - especially in the learning paths)


>
>
>  This looks a bit fragile, and could result in unexpected behavior: if
> this signal is emitted after we process the argument list, and the there
> was an absolute path in the list, it would get opened again and become the
> focused document -- it'd no longer be the last one on the CL, but the last
> *absolute* one.
>
I've just checked and all the gtk-mac-integration library does is that it
emits the signal when

-(BOOL) application: (NSApplication*)theApplication openFile: (NSString*)
file

NSApplication delegate is called by osx and I'm afraid we cannot do
anything to change this behaviour.

You are right about the possible incorrect behaviour but I don't see any
nice way to fix this - we could pass the list of files we get when parsing
the commandline to osx.c (the callback happens always after our parameter
processing) and then check in the callback if we have already opened them.
But I'm not sure if it's worth it because (at least how I use geany from
commandline) is by specifying a relative path (typically in the same
directory) or a pattern like *.c (which also creates relative file names).

> It would probably be better to find a way not to get notified about
> command-line arguments… even if it just means exiting the callback early if
> e.g. the !main_is_realized() or something.
>
I think there's no guarantee you can't get the callback after
main_is_realized() so I don't think this will help.


didnt think here, radius vs range are 2 different value's indeed. Corrected this to 52


OK :)


(Also I'd recommend even functional concepts such as "lift2" and "(+)" as first class values should not generally be assumed on the initial learning paths unless central to the topic - each topic needs to be really independently taught on a very minimal basis of F# knowledge.)


Комментарии лучше писать в формате XML Documentation, https://msdn.microsoft.com/en-us/library/b2s063f7(v=vs.110).aspx


> (or we should use GtkApplication, which seem to basically work like
> NSApplication -- oh wait, it's GTK3)
>
Out of curiosity - are there any plans for Geany to use GtkApplication on
GTK 3? There are some things directly in GtkApplication like the global
menu for osx. Not that I need it because I can get the same from the
gtk-mac-integration library, just curious.


There needs to be something that explains when to use what. Even if a particular API isn't the most efficient way of doing something, it is works for 80% of situations well enough, that should be what is shown in the majority of samples - a set of advanced samples should be then shown that illustrate the specific edge-cases where another API is applicable.


has to begin with `test_` I think


there are more. I recall `assertIn` checks if something is in something else; `assertIsInstance` asserts that an object is an instance of a class. Consult official documentation for all assertion methods, I think it's best to link there and not list everything here. Maybe mention the most important ones only but do not claim it's all. (There's many others, e.g. assertEqual is just a convenience wrapper that picks the right assert function specific to the given type so e.g. for lists you get some more helpful information when it's not equal.)


В C# для таких штук есть свойства: https://msdn.microsoft.com/en-us/library/x9fsa0sw.aspx и даже https://msdn.microsoft.com/en-us/library/bb384054.aspx


Is this assertion really necessary? :)


Checked in 2.6 and 2.7. It works in both


I'd usually do `path/to/file` and not *path/to/file* makes more sense IMO and I think we should be consistent about that.


I think this belongs in Configuration constructor itself. If we do it here, it only works when our entry point into the shell is this file (and not, for example, through Shell::debug)


our codestyle says when params don't fit into one line, everyone gets an own line. Especially a template should obey that.


I'd prefer to see no operators define in MBrace :) They are undiscoverable by intellisense and commute badly with operators defined in other libraries.  Just use "Send". If necessary define the operator as a notational convenience in the same file.


I can find `cmp_to_key()` nowhere in the code base..


Feel free to ignore; just a nit.


Sure it's no problem to bump the version of the addon. The "problem" right now is that the addon in the Helix repo has the highest version and it is missing some of the new strings so when you start the `language_addons` branch, it automatically updates the English language addon and you end up missing strings in the dialogs that you want to test.

From my tests on WIN32 the initial updating seems to work OK and since we only distribute the English language addon the others aren't updated anyway. So language updates should be kept to a minimum. Obviously we still need to test all the other platforms but that seems to be more of a proper packaging issue first :-/


Ah okay, sorry, i was just testing with a package submitted in the packagist. I will redo the files so the configuration is the one responsible about retrieving the configuration that the plugin manager gives.


It's too long for me,I'm a rooky,I can't read at once right now.


調べてみた結果、ライセンス表示の位置はあっているみたいですよ
まぁ、書けそうなところ全てに書いておきましょうね


Yeap, I'll fix. Thank you


There were 2 copies of iter_lattice & add_get_del_lattice in the previous version, so I just removed the extra ones. I don't know if there was some misuse of git from my part (with a merge conflict), but, at least in that version of the file which have in my laptop, and what I believe I actually pushed to github, there is a test for iter_lattices included. Could you please confirm that you did not miss the other versions?


Similar to previous question - is there any specific advantage to using "Distributed.map" here?  If so, what's the general principle at work?

Also why isn't "Distributed.map" called "Array.mapCloud"?  For a corresponding Async operation over arrays I believe I would expect the name Array.mapAsync.  The name "Distributed" is particularly hard to remember and seems odd because it doesn't feel connected to the other names being used in the API.


ah right. I could push an update en_gb to helix so you at least have all strings.


No worries. This is looking good, by the way!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12213/testReport/) for this commit**


Array out of bounds exception on line 177.  Not sure why.


Please use java method name convention, by having first letter of the method as lowercase.


Is there a possibility of getValue() returning null?


Looks like this change broke queued email delivery, which reuses the same SMTP mailer object for multiple deliveries.


Oops, forgot to link to the bug: https://github.com/zopefoundation/zope.sendmail/issues/1


you can test it with the recipe detailed here https://github.com/bobthecow/psysh/issues/166#issuecomment-76931589, let me know if something is not ok


You should mock the interface (IUsersRepo) instead of the class (UsersRepo). Please fix.


Same comment as above.


Doh! Sorry I didn't check the child comments thing today :( I can fix all of that first thing, i'll put it on my #1 priority list


86046200_CondenserToZone (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1461 of 1604 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-91.08%25-yellow.svg)


No, I believe that the compiler will optimize this code and merge those strings automatically.


tedad karbaran


So, was baseband showing up after this change?


oops.  Sorry, I missed that.


Close #4


Isn't `TSRMLS_CC` macro unnecessary now?


Close #3


Неймспейсы лучше называть как-то отлично от классов, а то можно запутаться, где что


SAme comment as above.


end of review :)


86046200_CondenserToZone (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


have you considered whether this should also be changed to std::unordered_set? as far as i can see we never lookup in this container, only insert and iterate


I went back and forth on the name.  The result is tainted, but it's tainted by either self or one of the arguments.  The idea is the parameter specifies an index in `[self] + arguments` and that's the source object to obtain taint status from.  If that object isn't tainted, we don't taint the result.


Sounds good to me! And thank you for this project. I love the idea behind it.


Right, the dictionary is a newer API than the setters, it doesn't make sense to keep it as it was.


EBI ino dorostesh kon
jaie save baiad update bashe
ejrash kon lotfan


Same comment as above. Use the interface instead of the class.


Looks good at first glance. I'll double check query builder supports slave connections


Ahh, I completely forgot `callBoolean` existed.  Thanks.


Agreed.  I'll change that.


@felixKubicek have a look, what's the problem here?


I guess, by default, NavigateToSymbolic should use the "near" constraint, which should in turn default to within 0.7 m from the convex hull of the entity.


What situation is this helpful in ?


Тут ещё надо провести валидацию результата. На случай, если там есть неизвестные токены.


@catsky may help your theming:

```rails g bootstrap:themed [RESOURCE_NAME]```


Ouch! it's a careless typo!  I'll fix it.
Is there any point to be corrected/modified?


Тут ещё надо провести проверку результата. На случай, если там есть неизвестные токены.


Yes! :)


We can get into situation where we have bugs with the same id, but with different statuses. In this case we acount only 1 bug('by random'). Is it correct?
I think the reason of bug is accounted many times is that we collect bugs with the same statuses several times, see https://github.com/Mirantis/launchpad-reports-summary/blob/master/launchpad_reporting/launchpad/release_chart.py#L18 where we have intersecting statuses.


In fact, I don't know what's best, it should just be consistent https://github.com/Swiip/generator-gulp-angular/blob/master/app/templates/gulp/_scripts.js#L38


@eregon My thinking here is this is never going to be a solution to all cases of taint, but should handle a very common pattern.  If you know that you're going to be potentially returning a Fixnum, just don't use the annotation parameter.  I did handle the common case of `nil` being a possible value in the return type domain, thus the big `if` guard in the `execute`.  That protects you in the case you can return either an Array or `nil`, for instance.  But if you can return a Fixnum, Array, or `nil`, then you'll have to use the node directly.

Regarding wrapping: This was C. Humer's suggestion after I was advocating for a new annotation like `@CreateCast` that could instead be used to do extra processing on the return value.  It's only used for methods that opt-in currently.  Overhead-wise, I don't think it's much more than what you'd have to do to taint the object from within the node, although it does add an extra level to the call stack.


Yes... @glinscott : If we don't do this then I assume the new code won't get pulled down by the workers out there in the field?


The correct workaround is to disable the "foreach" macro via QT_NO_KEYWORDS and use Q_FOREACH instead. Everything else just adds more brokenness.


I think @eregon meant the type of the local variable anyway.


end


Yeah, it should as the paths end up more-or-less the same

Side note: Just been testing this with `siege` and am more an more convinced that it's a better approach — a tiny % cost for a massive gain in readability and showing up programmer error.


I've a pull request open (#65) and was wondering if this is still of interest to logstash-contrib and if so, how to go about migrating it to [github.com/logstash-plugins](http://github.com/logstash-plugins). The new repo seems people less :(.

Cheers


@SelenIT, русский перевод появился 2 недели назад и не кажется мне удачным, напр. _@-правило_ и _соседний селектор_


Ah I understand the name now - how about `taintFrom`? Don't want to bikeshed though so if you disagree leave it.


Small Typo General Assembly


@kalashnikovisme  почему не Member.not_confirmed.decorate ? oo


Yes it is. I remove it in master after merging. https://github.com/php/php-src/blob/master/main/main.c.  You could read the  merging commit: https://github.com/php/php-src/commit/bb2e62ecda3f3935a076063be66b394ac6831c09 .


Ok, so the issue is if you have [concept_name concept_id="1" locale="EN_US" tag="preferred" name="yes"] and [concept_name concept_id="1" locale="EN_US" tag="preferred_EN" name="true"]. It will result in having 2 names to be set as fully specified and locale preferred. Aren't tags set like that wrong anyway? Would it be a good fix if we make preferred to be set as fully specified names and preferred\___ to be just locale preferred (I think it was like that before TRUNK-4040, see https://github.com/openmrs/openmrs-core/commit/8e869e9d5ebbc234ee6f3c02f5fa455ad21c3a79)?


`It may include, without` seems to not be finished.


Done :)


glyphicons für die Menüleiste "Vorlagen-Ansicht" erstellt (Mobile Geräte)


Really? I'm still on the fence about it. Are new people more likely to understand SQL or this DSL? Now if it can be used in storage to clean up that mess then I'm all for it. Its these cases here where its just as easy both ways that I'm not sure about.


@yehudasa A record in src_attrs has to be overwritten if *it is not an ACL record* **or** *it is not an intra-region op*.  C++ checks operands from left to right, so it checks key inequality to ACL and if it evaluates to *true* then it dives into the execution branch without checking the second operand of *or* operator, otherwise it looks at *intra_region*. But I agree that the comment above is misleading and the condition is hard to understand at first glance, so I'll change it.


Should we change this to lp_purchase-link--button?


Yes there is a possibility. Thanks for pointing that out. I'll make a new pull request with
newLocationId.toString().equals(currentHealthCenter.getValue()).

Here "newLocationId" cannot be null or length equals to 0. If it so this expression doesn't execute.


lp_purchaseLinkShortcode needs to be changed as well


maybe that is the 'correct' workaround, but it has some implications, e.g. QT_NO_KEYWORDS also removes the signal/slot/emit qt-keywords, which are more than widely used in qt-based code.

this patch is clearly a sub-optimal workaround, but it is a huge help when working with legacy code.


@todivasudha You have added only your name. You haven;t yet added your github handle.


I think this needs to be the line above the fail?


Oh, fun. Darn, that could be tricky, if a lot of emails are going to be sent() then we potentially need to check them all in vote()


Put JS classes at the beginning of the classes list please.
Also, this triggers a function, so it should be called lp_js_doPurchase.
Lastly, I am not sure it is correct to add this JS class to the shortcode link, because the behavior attached to this class is not applicable to this link afaik.


Why not use $o.$iframeWrapper here?


@pepelsbey, очень интересен Ваш вариант перевода, который бы правильно передавал смысл.
раз http://htmlbook.ru/css/cat/atrules
два http://htmlbook.ru/css/selector/adjacent
ИМХО, Мержевич — довольно авторитетный персонаж


> Are new people more likely to understand SQL or this DSL

Haha! OK, maybe personal preference sneaking in in terms of readability. Interested to hear what others had to say about that **specifically**.

But where the DSL maps so obviously to the GPL… I'd ask them to step away from their IDE if they couldn't read the "*obvious*". :grin:


Fixed in #3524.


Unvomment, or get uaexpert c server and stare in wireshark for relevant types. I am afk for today and probably tommorow...

> Am 03.03.2015 um 12:19 schrieb Julius Pfrommer <notifications@github.com>:
>
> Hmm. Dunno.
> How can we test this?
>
> —
> Reply to this email directly or view it on GitHub.
>


When misses are zero, the resulting hitRatio will always be zero, even if the number of this is non-zero. Is this correct?


Sorry I should have thought about this a bit more before merging - isn't this the sort of thing that would be perfect written in Ruby code? The docs literally say 'Same as sym.to_s.succ.intern', so can't we literally write `sym.to_s.succ.intern`? Maybe Rubinius already has that, or we can have a `truffle/src/main/ruby/core/symbol.rb` file and write it ourselves.


Lastly, this test method name does not seem to follow our convention. Did you generate it using this plugin? https://wiki.openmrs.org/display/docs/Generate+Test+Case+Plugin


No problem, dont forget to change it in the dialer to!


Sorry, I don't know why I assumed that this is master-only commit.


FYI: the whole default currency UI has been removed in the meantime.


@jwaterfield could you move this docstring up above `__init__` so that it shows up in the docs please.


test


ah, its just a typo, no one will be mislead. I would fix it on line 7
because that's the tooltip. and changing there will change here


Hei, ser du dette @StaaleA


@meecrobe, «соседний селектор» — это ошибка, правильно «соседский селектор», с @-правило другая проблема — это не перевод термина, переводом было бы «собака-правило», но «директива» здесь гораздо лучше.


I thought it is common practice to indent one level when changing the object scope you operate on.
I.e. indent one level when filtering the results (like .find()) and outdent again when removing the filter (.end()).


:facepalm: meant to assert concept there. Fixing and rebasing ASAP :)


@ZachBeta gets it. :ice_cream:


nitpick: better off putting `(desc.t, desc.name) == (CephOsdName, 'target')` into the same line.


Никто не оспаривает авторитет Мержевича, но у него не было задачи составить словарь, он занимался справочником, а это разные вещи.


ja


Not sure what happened here, it's not something I touched so I can only guess that visual studio auto formatted it when fixing the include. Anyway I'll get it sorted out whit the other issue


@meecrobe, предлагаю дать нам время закончить термины для HTML и CSS, вынести их в отдельные файлы HTML.md и CSS.md и тогда уже обсудить насколько наша версия лучше и, если договоримся, внести изменения в проект Vocabs.


Happy with this change


Do this so angular iterates over an array instead of object properties, which allows ordering


cool, ça va devenir très simple de généraliser la classe pour https://github.com/softwarevidal/jax-rs-linker/issues/40 :)


Fair point. And I think I side with you for the most part. I'm much more
comfortable with PHP than SQL.

I know a couple guys I work with that would freak out a little from a query
builder. But you're right it does map very close. That being the case it
sounds like personal preference. So carry on :)
On Mar 3, 2015 6:52 AM, "Gawain Lynch" <notifications@github.com> wrote:

> Are new people more likely to understand SQL or this DSL
>
> Haha! OK, maybe personal preference sneaking in in terms of readability.
> Interested to hear what others had to say about that *specifically*.
>
> But where the DSL maps so obviously to the GPL… I'd ask them to step away
> from their IDE if they couldn't read the "*obvious*". [image: :grin:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GawainLynch/bolt/commit/8e897d4df8e7c97c14e7cfe9ebbc9414eaee73c4#commitcomment-10005786>
> .
>


Thank you. I will try and modify my project as soon as possible and send you a new & hopefully improved version of it.


If you had backmerged in the last 10 days, you would have found that the entire dynamic pricing widget was totally rewritten.


mineur : extraire les deux `e.getKind()` en 1 variable


@FabiApfelkern
create() - updated die ElasticSearch-Daten
update() - aktualisiert das updatedAt-Datum


i


This looks like an average of Read/Write ratio per single node. Not an overall ReadWrite ratio per cluster. Is this expected?


IMHO
opal/mca/common/verbs should not be compiled when configure'd with --without-verbs
or an other option should be made available if we do not want to compile this part


This should be "exploit" not "exploid".


Just completely throws this away. What a pity that so much time has been wasted because you did not backmerge as I had insisted on.


Hi Vladimir, I've run some tests and made some comments. Let me know when you need further testing.


Is the window menu really the only one we're searching for? That's a bit surprising to me.


This isn't showing up properly in the docs, not entirely sure why as the syntax looks correct. try is without the line break.


This change was needed.  It addresses a condition when a query is constructed and no basic clauses exist initially.  Like so `{ "$and" : [ { "$and" : [ { "pet" : { "$eq" : "cat" } } ] } ] }`.  This unfortunately is a valid query so a check up front for the content of basicClauses was needed.  All that was done here was the wrapping of the original `if-else if` block with another `if` block.  Unfortunately this is how git chose to record the difference.


redeem what?


What I meant is using _const_ consistently throughout the code base. Some functions return non-const _Type*_, others don't. Some return _const&_, others don't. I understand that the code grew over time and hence has some edges. And it works. But undefined behavior is lurking, nevertheless ;-)


oh, it's the bloody 21 lines thing again. OK, didn't catch that. whatever floats your boat


NO. Must be .lp_redeem__code.lp_is-hidden


As it says in the comment above: 'variant' -> .lp_time-pass-widget--small


o_O
I don't remember who it was :P


ListElement по идее деталь реализации списка, так что его нехорошо принимать в паблик-методы или возвращать из методов. Иначе, если мы заходим переделать список в список на массивах, будет печально. И вообще, ListElement по-хорошему должен быть вложенным классом в классе List


We wanted to get rid off
- IDs in CSS
- multiple nested tag selectors


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 231](http://192.168.30.225:8111/viewLog.html?buildId=895&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


Since it is only a small part of a page, I prefer
```ruby
= render partial: 'shared/ontology_search'
```


Since it is only a small part of a page, I prefer
```ruby
    = render partial: 'shared/ontology_search'
```


@swannodette This bug was filed as a bug against Firefox, because we've already implemented this bit of ES6: https://bugzilla.mozilla.org/show_bug.cgi?id=1138325

We're going to keep the change for now. That means that sites using this function are broken right now in Firefox Nightly, and in about 4 months will be broken in release Firefox. Would you please encourage Clojurescript developers to upgrade, so that their sites don't break in Firefox?

If your impression is that there are many Clojurescript sites (or a major one) that will not upgrade, let me know. Then we should back the change out of Firefox and bring this up with the ES6 standard committee.


Здесь как и в задаче про стек, надо бы переделать на проперти


Now this controller handles a lot of business logic and gets quite complex. Please put create a model to handle the search itself and simply return the search result to this controller.


Please remove the space before the comma.


Missing newline at the end of the file.


Did you mean "calculates the 0n2b *counts* ..."


How weird, I don't have a ghostdoc file (perhaps older version or where the file writes on my system).


It isn't though, is it?

```haskell
λ: head $ filter (> 5) [1 ..]
6
λ: head $ filterM (return . (> 5)) [1 ..]
*** Exception: stack overflow
```

Have a look at the source: http://hackage.haskell.org/package/base-4.7.0.2/docs/src/Control-Monad.html#filterM


ROFL. I forgotten :D:D:D


Code gave errors. Found about something called activity. Have not been able to use yet but will soon.


How about using the removed codes for this `else` clause?
I haven't tried but when using [StaggeredGridLayoutManager](https://developer.android.com/reference/android/support/v7/widget/StaggeredGridLayoutManager.html), this will lead to app crash, so I'd like to avoid throwing exception here.

```java
} else {
    firstVisiblePosition = getChildPosition(getChildAt(0));
    lastVisiblePosition = getChildPosition(getChildAt(getChildCount() - 1));
}
```


As you mentioned, setting content type explicitly is not needed. JsValue automatically adds it.
And I fixed typo.


I have never done anything with cucumber, but couldn't this be done with a single regex that matches all the cases (with/without tasks/projects)? The implementation of those cases is the same. Or alternatively use the same line in the features file. As I said, I'm no expert on cucumber and if this is a convention, I can live with it.


typo: `tpyes`


この100ってなんですか？　マジックナンバーより定数の方が良いと思いますー。


Why not:
```ruby
Given(/^there are at least two repositories$/) do
  @repository_one = FactoryGirl.create :repository, name: 'RepoOne'
  @repository_two = FactoryGirl.create :repository, name: 'RepoTwo'
end
```
The same question for the other (ontology) creations in this file.


Did you mean Xperia M4 Aqua at line 30?


fix heigth to height in array definition


Does this have to be a class? You could just have the constants as module level variables.


I have had bad dealing with GhostDoc in the past, so actually gave up on using it


I suppose that "Forwards Amazon..." would be better.


ah ben bravo :P


Why the nesting?
This is probably because of some wrong nesting that was applied to .lp_powered-by before.


This nesting is almost certainly wrong without having looked at its context.


for i in  /bin/*; do i=${i##*/} ; done


@nickytonline wow, that's amazing.I learned something new. Weird. Thanks.


Not just the replace strategy but any `_strategy` directive.


Спасибо буду ждать :)


Please add a comment on leaving out the strategy here


Ok. Mach das erstmal so. Wir werden das aber später noch besser machen.


I'm afraid you have a trouble with your email address :/
The one you commited may be miss written (missing "y").


Why? :-/


Yes!

On Mon, Mar 2, 2015 at 9:03 PM, LipGlossary <notifications@github.com>
wrote:

> You made your first pull request!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/casa4801/EloquentYWeb/commit/0e8a16ddd7f1f0c5b37941d3e6067e8e1df50c60#commitcomment-9998578>
> .
>


Might be useful to have a unittest to checks that the exceptions are raised correctly and that the correct default values are used. The same `__init__` and maybe `eff_mass_to_counts`.


sudo is required for a2enmod and a2dissite too


Maybe "to get initialized" would sound better in this case.


Looks suspicious in terms of componentized markup.
We use such a "label" in multiple places. Therefore it should be a "label" component. A class ".lp_revenue-model" looks like duplication of the generic component.


status: :unauthorized - это 401


It may not be strictly necessary.  I added it because this is a multi project build and I don't know if we can rely on the main class finder finding the correct one (the plugins in the project also have application classes in them).  Lets discuss https://github.com/grails/grails-core/commit/41fc5ebac7433738043ce43d23bd610cca8454c4 and https://github.com/grails/grails-core/commit/8cf635c9548b8a5eb7f2ca7501e3d424ce217f19 in our meeting today.


This is just practice


Build team has reviewed for next release.


You should separate messages text and configuration variables by some namespace


Not sure, but I would say "if {...} has already been initialized."


@pedrobaeza Apologies for breaking the builds... And thanks for taking care of this repository


This has changed to `#include "pilight.h"`


Yes.


I would say "to start"


And this should be `"187"` for most default protocols.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 231](http://192.168.30.225:8111/viewLog.html?buildId=895&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 53 Build time: 00:11:24


Reviewed and approved.


翻译


Just a note: Commenting out code is not desired. Please remove it, if you think it not needed anymore (together with accompanying comments).


"can handle result of..."
here should be an article or plural form of result


@ChronoMonochrome thanks, can you also send me your ramdisk? A link or something else is okay


It would be hard to argue against the fact that the code has inconsistencies. However, I really do not see any case for undefined behaviour ...


note column added to users


I think so, yes.


According to the item#7, (Add friends and likes (photos) to previous UserService), not only implies the definition of each method on the interface, but also the implementation of each of them.


Yes, that's the right fix.


Why not pass `normalizedAlphaValues` the additional parameter `flippedDim` and handle the flipping of `alpha` directly there (move the code below inside the function).


Sim, retornou 6! \o/


OK


This note applies to all your recent commits. The current code style of `m2t` prefers `a = b` over `a=b` (spaces). Personally I don't have hard feelings but keeping a uniform style is preferable.


Apparently, both /usr/share/backgrounds and /usr/share/wallpapers are being used for installing wallpaper packages' contents in Debian land. I have opted for /backgrounds so far. If anybody would like to see that changed to /wallpapers, I wouldn't mind.


ok


ofc
no one will remember... that's the way it is
haha


I've noticed OMXPlayer was enabled again in a build from yesterday.
It seems some rebase went wrong and this rbp2.xml is never read.


I agree with @PeterPablo


I think it is better to specify who "chooses" and "starts"


This wasn't necessary before. Did you check if this is correct with the testsuite? (Run `testGraphical()` and then `make` in the `test/tex` directory.)


shut the hell up


update master from laur area 51


приставка items_ не нужна, а то как-то некрасиво звучит ItemController.items_city... пусть просто city, category, subcategory


Wenn mehrere Smilies auf ein Emoji zeigen, ist das nicht schlimm. Das ist notwendig aus BC-Gründen.

Bei den Schilder-Smilies müssen wir mal gucken, wie häufig die verwendet werden. Wenn sie häufig verwenet werden, unterstützen wir sie weiter. Ansonsten fallen sie weg.


The test on `CMAKE_BUILD_TYPE` does not make sense because multi-config generators (e.g. VS IDE) do not determine the configuration until build time.  Instead one should tell CMake to add the `DEBUGBUILD` compile definition only in debug configurations.  Something like this should work (untested):

    if(NOT CMAKE_VERSION VERSION_LESS 3.0)
      set_property(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS $<$<CONFIG:Debug>:DEBUGBUILD>)
    else()
      set_property(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_DEBUG DEBUGBUILD)
    endif()

Also, IMO the switch for `ENABLE_CURLDEBUG` should be independent of the build configuration.  It should be possible to have debug symbols without the extra code enabled by `CURLDEBUG`.


Don't worry :smile:

Let's fix all builds!


finy_by лучше писать явнее

category = Category.where(uri: params[:category_uri]).first


Sorry @LJeub. I just saw, that you took care of that with your second commit.


I would prefer Strings.isNullOrEmpty(characValue.getKey()) but it's personnal


test


yo nigas!


Maybe it is better to write "correspond to" here?


Pourquoi le <code>!important</code> ?


по городу мы наверное показываем список 2-х уровневый

Категория 1
  Подкатегория 1.1
  Подкатегория 1.2
Категория 2
  Подкатегория 2.1
  Подкатегория 2.2
  Подкатегория 2.3


Why not doing this in the while (line 339) ?


@PeterPablo: It's probably easier to review the diffs of the whole PR than every single commit. It's way faster and you don't need to worry about intermediate mutations (although it's of course nice if all intermediate commits have beautiful code as well :smile: ).


по категории + город тоже показываем список, но уже просто Подкатегорий


ici ce n'est pas init mais init_circle


registration *is* in process


This is new line


Likie I said before I like `extended`. And for the short one I would just omit speficitation.

`Player Menu`
`Player Menu (extended)` or `full` if you prefere, but I don't like `advanced` because it is not advanced.


86046200_CondenserToZone (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (606 of 606 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-3.13%25-green.svg)


тут могут быть разные буквы, типа aLl или All, лучше params[:city_uri] привести явно к нишнему кейсу


Thanks, I was unaware of Xcode 6.3 beta 2 :-)

On Tue, Mar 3, 2015 at 6:03 AM, Marcin Krzyzanowski <
notifications@github.com> wrote:

> check here https://twitter.com/krzyzanowskim/status/570555070590414848
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/krzyzanowskim/CryptoSwift/commit/cd752b61e3711c69403d1a19470fe88958450218#commitcomment-10001648>
> .
>


Oh, my fail. I had to check another variant:
> let findM p xs = listToMaybe <$> filterM p xs
> findM (\a -> putStrLn (show a) >> return (a>5)) [1,6,undefined]
1
6
*** Exception: Prelude.undefined
Sorry for noice.


What's the matter with line 129  in `getArchiveFilenameList`, maybe a typo?


np,
question: If i remove multi value return (just -1 for fail and 0 for ok)
would you leave them?
The main difference to $(class.name)_$(name)_number is that i can't
recognize between 0 and error state + if i have uint64_t it makes sense to
add int64_t and/or double as well.

On Tue, Mar 3, 2015 at 1:08 PM, Pieter Hintjens <notifications@github.com>
wrote:

> I have a few problems with this code. First, this expands the generated
> API, when I think you simply make a utility function somewhere that does
> the string-to-number conversion you need. Secondly, the error handling is
> inconsistent with our style, we never do this kind of multi-value return in
> APIs. There are other issues but these are the main ones.
>
> I'd like to revert this change.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/karolhrdina/zproto/commit/a2569707b2b8f4df17a2927564a8add05ca3bc6d#commitcomment-10004924>
> .
>


ну и роуты изменятся на красивее items#city ... items#category


1: M101 signature is missing
3: M102 unrecognized bullet/signature
1: M110 missing component name
3: M190 line is too long (242 > 72)


I would say "has already been unregistered"


You are correct. I've added it back in.


GD is actually very nice. ?


Commentaire sur cette action peut-être ?


Would adding `flipImageIfAxesReversed()` in `imageAsTikZ` be more appropriate?


Good catch, this removes unnecessary complexity.


Ça serait bien de toujours mettre des espaces.
$base-line-height/2 => $base-line-height / 2;


This was deprecated on moment not moment-timezone.  This will break the time-zone stuff.


I don't understand what have you updated ?
Moreover, you should create a new test case to test facets on characteristic.


We usually start with the method name. Can you look at the other tests and see their names?


FYI, this method will generate results for "extra" variants existing when say increasing the number of attributes from 1 to 2, the variants that remain with only one attribute will provide results through the above if additional checks are not put in place on the other side of entry/attribute changes...  It may also be a desired condition, the impact of which I have not yet evaluated...


dump comment


Strange order of words and difficult to understand. Maybe smth like this:
You should rarely (if ever) call this method. Not only because it is expensive in terms of resources, but also because it invalidates your registration ID, which you should not change in normal situation.


I have tested this code and found two problems on my build.

When I try to compile the git raw from your repositry, it barfs asking for other build files such as bind.

When I apply these patches against the official ISC 4.3.1 code tree I end up with a route missing the last character of the next hop address. Looks like a strcpy handling of "client-address" that is one octet too short somewhere.....

Mar  3 14:23:24 xx dhcpd: Solicit message from fe80::16cc:20ff:fe8a:15c4 port 546, transaction ID 0x4ECA400
Mar  3 14:23:24 xx dhcpd: Unable to pick client address: no IPv6 pools on this shared network
Mar  3 14:23:24 xx dhcpd: Advertise PD: address 2001:db8:7d92:f00::/56 to client with duid 00:03:00:01:14:cc:20:8a:15:c4 iaid = 1 valid for 60 seconds
Mar  3 14:23:24 xx dhcpd: Sending Advertise to fe80::16cc:20ff:fe8a:15c4 port 546
Mar  3 14:23:25 xx dhcpd: Solicit message from fe80::16cc:20ff:fe8a:15c4 port 546, transaction ID 0x36D52D00
Mar  3 14:23:25 xx dhcpd: Advertise PD: address 2001:db8:7d92:f00::/56 to client with duid 00:03:00:01:14:cc:20:8a:15:c4 iaid = 1 valid for 60 seconds
Mar  3 14:23:25 xx dhcpd: Sending Advertise to fe80::16cc:20ff:fe8a:15c4 port 546
Mar  3 14:23:27 xx dhcpd: Request message from fe80::16cc:20ff:fe8a:15c4 port 546, transaction ID 0xE24A3C00
Mar  3 14:23:27 xx dhcpd: Reply PD: address 2001: db8:7d92:f00::/56 to client with duid 00:03:00:01:14:cc:20:8a:15:c4 iaid = 1 valid for 60 seconds
Mar  3 14:23:27 xx dhcpd: execute_statement argv[0] = /usr/local/sbin/prefix-delegation-routing.rb
Mar  3 14:23:27 xx dhcpd: execute_statement argv[1] = add
Mar  3 14:23:27 xx dhcpd: execute_statement argv[2] = 0:0:0:1:0:0:0:0:0:0:0:0:0:1a:0:19:0:0:0:0:0:0:0:0:38:20:1:d:b8:7d:92:f:0:0:0:0:0:0:0:0:0
Mar  3 14:23:27 xx dhcpd: execute_statement argv[3] = fe80::16cc:20ff:fe8a:15c
Mar  3 14:23:27 xx dhcpd: execute_statement argv[4] = eth0
Mar  3 14:23:27 xx dhcpd: Sending Reply to fe80::16cc:20ff:fe8a:15c4 port 546

It should be 15c4 not 15c as the last sextet.

and therefore the resulting route is incorrect

route -6
Kernel IPv6 routing table
Destination                    Next Hop                   Flag Met Ref Use If
2001:db8:7d92:f00::/56         fe80::16cc:20ff:fe8a:15c   UG   1024 0     0 eth0


in python it's hard to read if statments if they are very long.

I would like you to make simplify the code using the following patern
```python
if special_case:
    ....   #what to do with special_case
    return
... # normal case


"for notification" or "to notify"


I have updated the tests in order to reflect the changes. I suppose you know exactly you are doing ;)


True, but opening single commits has the advantage of understanding the author's intentions due to less changed code and a meaningful commit message :smile:


Michal, what is the user story motivating the need to know organization as the DPU is executed?


Pivo ID: [#85113770]


The case it not very explicit. i would rather have
```python
if invitee_phone is None:
   .....
```
for that you might have to change the ```clear_phone()``` to return ```None``` in case the phone number is empty


@nirvdrum OK, I missed that if indeed!


Nevermind. @0robustus1 just told me that the partial-renderer is called internally anyway.


I don't like type system proliferation (how many syntaxes can we invent for numbers?), and already deprecated the entire V1 codec as it was too complex and slow.  So adding to this is probably a Bad Idea. I'd suggest writing your own utility code that translates $(class.name)_$(name) () into whatever you need.

IMO you are using zproto wrongly, to encode application data. My strong advice is to look at [XRAP](http://rfc.zeromq.org/spec:40) and encoding your application objects as JSON so there is no conversion issue. We can add XRAP support to Malamute if that's needed.


I think the indexing should be simpler, so `0` always means self and `1` means first argument, `2` the second, etc. So basically do the check on needsSelf in `makeGenericMethod` instead of the `TaintResultNode`.


My opinion is that it is not necessary to clean up because, as whyrusleeping says, each test is run inside its own 'trash' directory, and this directory is cleaned up when the test succeeds. So I think it is better for clarity to avoid cleaning up files.

Having files named "expected" and "actual" by default is a convention that helps save time when writing and reviewing tests. As the tests should be quite short and are cleaned up anyway when they succeed, there should not often be the need for many such files.


I would say "to handle"


Yeah I meant the local `Boolean` which is likely an anti-pattern, but indeed the true solution seems `callBoolean` here.


:sweat_smile:  Thanks!


to start


Maybe it would be better to wrap the file arguments in a `normalizePath(winslash = "/")` call at [subprocess.R#L51](https://github.com/HenrikBengtsson/covr/blob/5ddb51383196ba129bc0bd10ef4bdffbd64864d3/R/subprocess.R#L51).

Theoretically the method you proposed would fail if there was an escape somewhere else in the subprocess script (which there isn't likely to be).


@eregon I was thinking the same thing, but `0` can't always mean self because we don't always require self in a method.  Even if the methods `needsSelf`, you might want to taint from a different object.  This seemed like the most straightforward way to disambiguate.


Usually, this is *a* store application.


good idea!


We don't update translations directly in the github repository. Those have to be translated using Transifex once a PR has been merged.


Is this valid IDL? I think it should be

    readonly attribute SyncNetworkType minRequiredNetwork;

but I don't want to change it, if there's a subtle meaning that I'm missing.


Oops, good spot - new commit: d080663e624ebaf4096bbb77742904bec82df811


@eregon Variable renamed in: 596a74a58e89c837ecaa1a58a3f4adbf9a490f95

@chrisseaton Annotation parameter renamed in: 27f115f3ffdb97da1675689ee3384e2319f5678b


86046200_CondenserToZone (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1106 of 1106 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.04%25-green.svg)


@param blabla. Betyder att det ord som är efter @param - i detta fall blabla- förklaras.


This description could be a bit more extensive. Right now it basically says the same as the setting's label.


Я думаю, что читабельнее было бы, если строки имели вид:
```
GSM:
    ASU Level: 5
    DBM: 2
    ...
```
Это "Cell Info" никакой полезной для пользователя информации не несёт.


Reviewed and approved.


Yes. And how do I create the container DIV with an id? And how would I add 'position: relative' to the container?


Thank you @mgencur I'll look into these now once again. Much appreciated.


First project I looked at, bugzilla, does exactly this, that is adds headers to [CSS](http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=blob;f=skins/standard/global.css;h=60e06af7383a5ec0962163e80bb4c226022cfc0b;hb=6419b7fcbf9c8efa2d7b55c7e40cfbdf08a5cd5c) and [templates](http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=blob;f=template/en/default/index.html.tmpl;h=84a5b7d5cdda2ffd2ff054af3ac352e5210bd1f9;hb=6419b7fcbf9c8efa2d7b55c7e40cfbdf08a5cd5c)

HTML source just happens to be what Pootle delivers.  The creative work is the source that creates those.  The questions you ask about downstream changes are already present as the whole work is GPL2.

The possibility of a legal fight isn't really part of this question.  Lets stick to what we need to do to protect the work and avoid crystal balls to somehow see into the future.

1. The only real world difference to having them is that we are then actually following the GPL implementation advice instead of ignoring it.
2. That is a legal requirement yes.  The no more no less is actually unclear since the implementation advice actually does define the minimum and but exluding the header we're ignoring that.
3. Correct
4. Correct

My view on what the commit is trying to achieve is this, to communicate explicitly that this creative work is licensed under the GPL2.  That is all its trying to achieve.  The headers do that, leaving them out does not achieve that.

You can copyright a creative work and these are part of one.  Look and feel isn't really part of the issue here.


Sorry, thanks for merging. I'm back at JD again. Sent using CloudMagicOn Tue, Mar 3, 2015 at 06:34,  artsy/eigen <reply@reply.github.com> wrote:            Merge pull request #243 from artsy/alloy-fix-sharing-on-ipad@1aurabrown => [Sharing] Fix crash on iPad.---Reply to this email directly or view it on GitHub:https://github.com/artsy/eigen/commit/7757bddc4f4b9f8e413eacbf17e1a945c689759b


Verify that application


I had a plan to redirect all "splice" calls that disregard their return value to "spliceVoid". Haven't done it yet though :)


Dear Luke,
I think there was another minor bug in the Halo routine when copying the
velocity_vectors.
Here a corrected script:
Cheers,
Ben

!! add this generations velocity vectors in halo_type
        !! this is a bit more difficult as the vel_vec_red_level has to
be taken into account
        do k = 1, grid%Nz
           do j = 1, grid%Ny
              do i = 1, grid%Nx
vel_vec_red_lev=result%vel_vec_red_lev(i,j,k,halo_type)
                 !! determine how many velocity vectors need to be added
to the halo array
                 !! here, we have to consider the vel_vec_red_lev of the
halo array!
ncounters_s2=int(result%velocity_counter(i,j,k,s2type)/vel_vec_red_lev)
                 do jj=1,ncounters_s2 !! add ncounter_s2 velocity vectors
                    result%velocity_counter(i,j,k,halo_type)= & !!
increase halo_counter
                         result%velocity_counter(i,j,k,halo_type)+1
counter=result%velocity_counter(i,j,k,halo_type)
                    if(mod(counter,vel_vec_red_lev).eq.0)then
                       counter=counter/vel_vec_red_lev
                       if(counter.gt.nvelocities)then
                          !! increase reduction-level in storing
velocity vectors
                          vel_vec_red_lev = vel_vec_red_lev*2
result%vel_vec_red_lev(i,j,k,halo_type)=vel_vec_red_lev
                          !! move every second index to the first half
of the array!
                          do nn=1,3
                             velocity_dummy= &
result%velocity_vectors(i,j,k,halo_type,every_second_index,nn)
result%velocity_vectors(i,j,k,halo_type,first_half_indices,nn)= &
                                  velocity_dummy
                          enddo
                          !! don't save this one
                       else
                          !! the reduction level of halo_type is not
necesarily the same one as the level of s2type!
                          !! Therefore, there we have to consider that
there can be less or more velocity vectors than nvelocities!
                          !! As a solution, we just ncounter_s2 velocity
vecotrs that correspond to random positions in the s2 array.
                          call randu(randomu)
                          !! random * ncounters in s2type
counter_s2=int(randomu(1)*(int(result%velocity_counter(i,j,k,s2type)/result%vel_vec_red_lev(i,j,k,s2type))-1)+0.5)+1
result%velocity_vectors(i,j,k,halo_type,counter,:)= &
result%velocity_vectors(i,j,k,s2type,counter_s2,:)
                       endif
                    endif
                 enddo
              enddo
           enddo
        enddo

On 03.03.15 11:08, Luke Stagner wrote:
>
> Ok I think i get it now. I was confused by what you meant by saving
> every 2,4,... index. I thought it was taking every 2,4,...index in the
> full velocity vector and shoving all of them into the front of the
> array. But what you meant is taking every 2,4,... velocity vector and
> then storing it. I had it backwards where you save every vector and
> then throw some out.
>
> I will need to think on it some more.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/D3DEnergetic/FIDASIM/commit/42f787462a6b8dc43cdddf886748a71c6e2276a4#commitcomment-10002866>.
>

--

Dr. Benedikt Geiger
Max-Planck-Institut für Plasmaphysik, E2M
Boltzmannstr. 2
D-85748 Garching bei München

Phone    +49 89 3299-1731


*webhook.

On Monday, March 2, 2015, Alejandro Zeise <atzeise@gmail.com> wrote:

> Yeah I need a github we hook to a PHP script on the VPS. Problem is i
> don't have my login info, or ip.
>
> On Monday, March 2, 2015, PEMapModder <notifications@github.com
> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
>
>> Is it possible in any ways that it can do it automatically? (Like,
>> something like Jenkins, or you setup the GitHub webhook listener)
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/PocketBukkit/PocketBukkit/commit/742d92a7c8bec5a1931a15fec84197516dec2ed7#commitcomment-9988056>
>> .
>>
>
>
> --
>
>

--


I wouldn't add a setting for this. There's also no setting for highlighting the currently played file/item.


It might be helpful to provide a link to OPFPushException class.


How do you manage the minimum required for character fields?


When I read next row and then do some check values in procRow, sometimes (i.e. for reporting) I need to know the raw (source) newLine string. It could has a getter to get current line.


That's a great idea! We need an reminder issue about that, maybe I could do that if I have time.


OPERATION FREEDOM DISASTER


Maybe put this and the folder resume setting into a separate group.


set_trace is obsolete and can be removed completely


thanks matt, that's better!


@crowbot: Looks like it was from this "(e.g., one is errors made when email addresses are copied [...] but the other is due to unusual things such as a response being sent to multiple request addresses, perhaps using BCC)" in https://github.com/mysociety/alaveteli/issues/1075#issuecomment-65076869 -- annoyingly I can't now find the source of _that_ comment. I thought it was in the AskTheEU's guide but I don't see it in there so maybe an email. As you linked before, https://github.com/mysociety/alaveteli/blob/rails-3-develop/app/mailers/request_mailer.rb#L258 suggests if there's a bad email in there with any good ones, it's simply ignored. So I have dropped the multiple email addresses paragraph entirely.


Not sure, but probably you wished to say
"If this method is called, your registration becomes invalid"


?? This seems misplaced. Did you happen to delete the line note from line 55 and are replying to it?


The issue was created. I assigned myself but feel free to do it when you have the time :)


Probably "as an argument" would be better.


nice!


node: bad option: -
node: bad option: -
ᐧ

Thanks
David

Shaping Connected Experiences

<http://davidmermelstein.dunked.com/>  Portfolio
<http://davidmermelstein.com/>     <http://www.linkedin.com/in/merms>
Linkedin <http://www.linkedin.com/in/merms>    Twitter
<http://www.twitter.com/dmerms>      773.744.0760

On Tue, Mar 3, 2015 at 2:20 AM, Martin N. <notifications@github.com> wrote:

> Right, what does
>
> node - - version
>
> output?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AVGP/susi/commit/fa59094a26641840530c9fef5110fa1f75d7b7e0#commitcomment-10001020>
> .
>


Sounds reasonable. Thanks!


厉害. :+1:


There already is some hashing functionality used in the Video Info Scanner so maybe something can be re-used. Maybe @mkortstiege can help out here.


89435026-initialize-SysTotCoolCap (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Took a stab at it, some of these might be wrong.


It's probably more likely that my idea of how to test it is wrong.

> Is the goal of setting a browserslist just so that we don't add unnecessary prefixes?

Correct.


mDozeFragement needs to be mDozeFragment ;)


I would put an article between creates and instance.


what about str/unicode? Is it handled by the other condition (`not hasattr(values, '__iter__')`)?


It's not that it's of no interest, but that someone needs to take the initiative to migrate it into a new plugin.

See http://www.elasticsearch.org/guide/en/logstash/current/_how_to_write_a_logstash_filter_plugin.html

It needs to fit the format being described there, including name and directory structure.  You don't even need to publish it to the logstash-plugins repo.  You could keep it in your own, and publish the plugin to ruby-gems yourself.  We wouldn't accept the plugin into the logstash-plugins repository without rspec tests, which do seem absent in the referenced PR.  A guide will be written soon for helping people get started with that.


To give a general answer, `foo DIV: { bar. baz }.` is the same as `foo DIV << { bar. baz }.` which is in turn same as `foo DIV << bar << baz.`. So insert content at that level of granularity which is appropriate for you use case.


That document is subject to minor changes in the build-up to Logstash 1.5 release, btw.


README.md contains examples of setting an id attribute. Maybe style attribute can be set similarly.


> You are right about the possible incorrect behaviour but I don't see any nice way to fix this - we could pass the list of files we get when parsing the commandline to osx.c (the callback happens always after our parameter processing) and then check in the callback if we have already opened them.

Well, maybe then resolve relative paths and open everything (twice)?

> But I'm not sure if it's worth it because (at least how I use geany from commandline) is by specifying a relative path (typically in the same directory) or a pattern like *.c (which also creates relative file names).

Indeed it's probably not very important -- although I can already see a bug report from some confused user :)
So yeah if it's too much trouble maybe just leave it alone (or better, add a FIXME or something, so we can remember it when it blows off in our faces).


point 1) i see

point 2)
Maybe we are.

Our transport has two zproto messages, SEND and REPLY. They are almost
identical:

    <message name = "send">
        <field name = "aux"         type = "hash" />
        <field name = "request"     type = "chunk" />
    </message>

    <message name = "reply">
        <field name = "aux"         type = "hash" />
        <field name = "response"    type = "chunk">this is repeated upn
request, i.e. special key : value in aux </field>
        <field name = "request"     type = "chunk" />
    </message>

For simple cases when i can encode the app data into aux i thought it is
not a bad idea to do so. Am i wrong?
^^^ So this is the case for which i wanted to create those functions, but
in retrospective, you are right, the multi return idea was bad + it's true
i can put those into utility functions.
In my defense, when i saw .._unsigned () it didn't make sense to me (at
first) not to have other numbers as well. So i made a PR :)

I will take a look at XRAP (you even sent me a link, thank you),  but i
don't have time to read it now. I've been sick with really strong flu and
now i am under time pressure to finish some user stories.

Thanks for you time and sorry for the bad pull requests.

On Tue, Mar 3, 2015 at 2:40 PM, Pieter Hintjens <notifications@github.com>
wrote:

> I don't like type system proliferation (how many syntaxes can we invent
> for numbers?), and already deprecated the entire V1 codec as it was too
> complex and slow. So adding to this is probably a Bad Idea. I'd suggest
> writing your own utility code that translates $(class.name)_$(name) ()
> into whatever you need.
>
> IMO you are using zproto wrongly, to encode application data. My strong
> advice is to look at XRAP <http://rfc.zeromq.org/spec:40> and encoding
> your application objects as JSON so there is no conversion issue. We can
> add XRAP support to Malamute if that's needed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/karolhrdina/zproto/commit/a2569707b2b8f4df17a2927564a8add05ca3bc6d#commitcomment-10006597>
> .
>


You can avoid this deep a nesting by

<pre>

          custom_values.select(&:invalid?) do |invalid_custom_value|
              invalid_custom_value.errors.each do |_, message|
                errors.add("custom_field_#{invalid_custom_value.custom_field.id}".to_sym, message)
              end
          end
</pre>


corresponds to


If you like better, we can pass a hash specifying `{ :variable_name => :serializable_field_name }`


With this addition it's now possible to use `context.Instance` within custom `TypeConverters`

    public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
    {
        IPublishedContent content
        if (context != null)
        {
            content = (IPublishedContent)context.Instance;
        }

		// Do the conversion.
    }

This is great if you need to substitute values when converting. E.g Substituting `SeoTitle` with `Name`


@julen your comments please


That seems fine and it works the same in the test cases I was looking at.  We have to maintain the _oldpos var though since its used later to seek to the correct part of the video that was interrupted when we destroy the instream


general note: adding meta data to lager logging is nice, but it is only useful for tracing when it is consistent. This does not only mean to use the same tag for the same value, but also use consistent tags.

Here we have: ip, server_ip and clientIP. So one is without any qualifier (server or client), one is using camel case and the other an underline. Also some other log messages that do contain IP's in the message do not contain any meta data.


> Out of curiosity - are there any plans for Geany to use GtkApplication on GTK 3?

No, and there probably won't be until we drop GTK2 support altogether.   GtkApplication is real nice and all, but having code with and without it looks like a huge PITA.  Just as an example, GtkApplication handles files passed in as arguments just like NSApplication seem to: it emits a "open" signal for each file -- and many other fancy things like this that we currently do manually and completely differently.

The only real way we could reasonably use it before dropping GTK2 support would be to copy/reimplement the class in our code.


For better or worse, this case actually seems to be legal according to the current draft. There is a recent V8 bug for it (https://code.google.com/p/v8/issues/detail?id=3926).


Same here.


in a wrong way


For now?


This issue happens in IE9, see: http://jsbin.com/nohavapeju/2/edit?html,css,js,output

When having existing classes (E), and we're removing the class (A), if another class (B) was added since the removed class (A) was initially added, the names of the previous classes are joined with the new class (E and B) without a separator space.


I agree.  This comment has already been updated and exists in this PR in a separate commit.  https://github.com/cloudant/sync-android/commit/940aa5b142bef08a2ec7325069bd302d399daa6a#diff-10b697b5119c2ac1b73822d862ec16dcL175


And here.


"or you do not have rights to view it."  Perhaps some directions for creating a project or getting access to an existing one along with a TODO to touch up those directions if we ever get a "/how-to-create-a-project" endpoint on the apiserver.


Are you sure by that ? You are passing here error object, not request as in it is in function declaration


Published to http://ui.edev.desire2learn.com/43_625a8d9d076a03699f4a88c28cc9944d5ed56af0


Published to http://ui.edev.desire2learn.com/42_625a8d9d076a03699f4a88c28cc9944d5ed56af0


In the proposed implementation you get the same behaviour.
When the variable is not set or its value is `nil` it will return the default value.

[Code](https://github.com/Microsoft/AppInsights-Ruby/pull/7/files#diff-efda51c28226c99fac923b305722a1a3R11)
```ruby
def ver
  @ver ||= 1
end
```


It doesn't fit nicely with the contact us text, I'll add it back when we have a better design for it (if we want to include it)

On Tue, Mar 3, 2015 at 2:01 PM, Eiríkur Heiðar Nilsson
<notifications@github.com> wrote:

> For now?
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aranja/aranja.com/commit/825f15f654bebbe145686f794607cd2e7b723392#commitcomment-10006921


@benbc Is UdcContants not available to reference?


@claudiosmweb @mikejolley This is potentially a breaking change for any extensions that already use wc_select_params strings to localize their select2 fields.

Not sure if I'm the one who's doing it wrong here.


godoc and this loading order should be using ClientConfigLoadingRules.FilePriority


For example [std::set<Type*> Registry::reverseDepends(Type const& type)](https://github.com/orocos-toolchain/typelib/blob/master/typelib/registry.cc#L618) looks suspicious: The first _const_cast_ is used to enforce calling the _const_ variant of the function. Then the content of the returned list (containing pointers to objects of _const_ qualification) is used to return copies of these pointers -- but without constness. These can now be modified.

[This](http://en.cppreference.com/w/cpp/language/const_cast) has a similar looking example:

    const int j = 3; // j is declared const
    int* pj = const_cast<int*>(&j);
    *pj = 4;         // undefined behavior!

Mind: I'm just not sure that there is no undefined behavior. Since nobody is reporting problems we are probably fine and have more urgent things to do ;-)


This one is also legal according to the spec (althout let and const aren't).


FromIP is not available here, you should have committed the FromIP cset before this one


Résolution d'un conflit au niveau du nom


@benbc One _can_ record any existing value of the system property and reset it after the test finishes


89435026-initialize-SysTotCoolCap (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1620 of 1620 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It surely is.. I've added you as collaborator, you can push a fix as soon as you like ;-)


You can now use 'hour' and  'hours' instead 'hourplural'.
I updated the lang/en.php for that.

Same for 'minute' and 'minutes', 'week' and 'weeks', 'day' and 'days'.

If all changes to the simplier form of this date stuff are made, 'hourplural' and so on can removed from lang-files.


Ajout d'une boucle qui supprime les div récupérée en Ajax


This commit causes both Ocarina of Time and Cave Story to not display correctly for me. Reverting it causes them both to work fine if IS_CAVE_STORY is defined according to the game.


"filestovirutoso bude mat checkbox ze 'vytvor usera navirtuose ktory sa bude volat ako organizacia a nastav prava na loadnuty graf' - eDem story


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12227/testReport/) for this commit**


Ajout d'une classe et d'un texte au bouton interactif


Published to http://ui.edev.desire2learn.com/41_7c80397a7cfbd116adf3df6b44585235f401e5be


* when logging FromIP, the FromPort should also be logged and added to the meta data
* IP+Post combinations in string messages (not in the meta data) should be formatted as IP:Port, e.g. 192.168.1.1:1813


I have dug a little further...

there is:
````
- name: Retrieve OpenShift Master credentials
  local_action: command /usr/bin/rsync --compress --archive --rsh 'ssh -S none -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null' vagrant@{{ hostvars['master']['openshift_public_ip'] }}:/var/lib/openshift/openshift.local.certificates/admin/ {{ mktemp.stdout }}
  ignore_errors: yes
````

and a log entry like:
````
failed: [node-1 -> 127.0.0.1] => {"changed": true, "cmd": ["/usr/bin/rsync", "--compress", "--archive", "--rsh", "ssh -S none -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null", "vagrant@{{", "ansible_default_ipv4[address]", "}}:/var/lib/openshift/openshift.local.certificates/admin/", "/tmp/openshift-ansible-YdCGhDf"], "delta": "0:00:00.002028", "end": "2015-03-03 14:57:27.794058", "rc": 1, "start": "2015-03-03 14:57:27.792030", "warnings": ["Consider using synchronize module rather than running rsync"]}
stderr: Unexpected remote arg: }}:/var/lib/openshift/openshift.local.certificates/admin/
rsync error: syntax or usage error (code 1) at main.c(1330) [sender=3.1.1]

````

The interessting part is ```vagrant@{{", "ansible_default_ipv4[address]", "}}:/var/lib/openshift/openshift.local.certificates/admin/"``` it looks like a substitution has not taken place?!
````
$ grep default_ipv4 group_vars/all
openshift_public_ip: "{{ ansible_default_ipv4['address'] }}"
````


@benbc Isn't this not community pulling in enterprise as a dependency?


Optimisation des commentaires inutiles


légère modification design. L'ensemble est désormais responsive


This can be removed and the entire thing handled by FilePriority.


rendre la vidéo responsive en fct des div ajoutés


@lassewesth No. We can't have dependencies on the UDC package. We specifically document the fact that it's okay to rip out the jar to reassure people that it's turn-offable.


Ah I thought you were talking about annotating the Rubinius methods in their Ruby source code - maybe we should do that as well.


One-way hashing cluster name for anonymity?

Spicy.

Whatever happened to rot13?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12228/testReport/) for this commit**


lookups in unordered_set are most of the time faster than set, so yes, definitely we should use a lot more unordered_set than set


\`\`\`bash
\`\`\`

少了下面的 \`\`\`


Thanks


This will be updated later when support for messages from multiple accounts is added.


Do you also make the changes in installer and upgrader for the _actual_effort_* renaming to current effort done naming?

I think after this we are finished with database changes for 1.0 and make a database schema change freeze?


Your API should be able to handle trailing slashes.


`NewWithArgs` に渡しているのが `os.Args[1:]` なのでこれでいいかと思ったのですが、誤解してますかね。


A few comments about the tests:

```
+ (test_cmp expected actual2 || test_cmp actual2 also_ok) &&
```

`test_cmp also_ok actual2` is nicer than `test_cmp actual2 also_ok`, because this way the diff is always in the same direction in case of failure.
(Lines starting with - are always what we expect and lines starting with + are always what we actually get.)

```
echo "HTTP/1.1 302 Found" | head -c 18 >expected
```

Maybe: `printf "HTTP/1.1 302 Found" >expected`

Or maybe the tests should look like:

```
curl -I http://127.0.0.1:5001/webui >actual &&
RESP=$(head -1 actual) &&
(test "$RESP" = "HTTP/1.1 302 Found" || test "$RESP" = "HTTP/1.1 301 Moved Permanently")
```


Hello


maybe try `<%= label.name.replace(/(browser|status)-/, "") %>`?


@ardumont: Cool stuff!

Can you please split this into two separate pull requests:
1. For tests (they should work without cask as we have another workaround for missing ert/cl-lib).
2. For cask introduction.


The to_s would imply creating a RubyString versus just using the ByteList directly. Would it be better to avoid creating the RubyString?

The following methods in rubinius common are not yet implemented in java. I think I only the to_proc might be good to use.
```ruby
  def length
    to_s.length
  end

  alias_method :size, :length

  def succ
    to_s.succ.to_sym
  end

  alias_method :next, :succ

  def [](index, other = undefined)
    if index.kind_of?(Regexp)
      unless undefined.equal?(other)
        match, str = to_s.send(:subpattern, index, other)
        Regexp.last_match = match
        return str
      end

      str = to_s
      match_data = index.search_region(str, 0, str.num_bytes, true)
      Regexp.last_match = match_data
      if match_data
        result = match_data.to_s
        Rubinius::Type.infect result, index
        return result
      end
    else
      to_s[index, other]
    end
  end

  alias_method :slice, :[]

  # Returns a Proc object which respond to the given method by sym.
  def to_proc
    # Put sym in the outer enclosure so that this proc can be instance_eval'd.
    # If we used self in the block and the block is passed to instance_eval, then
    # self becomes the object instance_eval was called on. So to get around this,
    # we leave the symbol in sym and use it in the block.
    #
    sym = self
    Proc.new do |*args, &b|
      raise ArgumentError, "no receiver given" if args.empty?
      args.shift.__send__(sym, *args, &b)
    end
  end

```


C'est pas très beau de commiter les fichiers de conf Intellij ;)


Buena esa no me la sabia jejejejej :yum:


Its on!


unreadable


This is scoped to the `if` block below.


Will try in a bit.


"both financial" instead?


A few large blocks of commented out code here also


"a bigger, more expansive"
or "a bigger and more expansive"


make a prettier context name?


r+


 @mmostajab Are you doing client side or SDK based warping?
Have you tried hooking up an OpenGL debugger and tried looking at the render textures to see if they contain sane data?


missing word:
"Take a look at our.."


I guess I missed this before - you should complete this `<your license>` for all of these  -  `Apache V 2.0` will probably suffice.


Sorry, this one I shouldn't add... this actually happened automatically...


You could actually use any context from any of the merged files.


I don't think it is possible to have a self documenting JSON file. Since it seems to be a popular request to get the JSON explanation and example out of here, I will put it on the feature docs for vfolders.


You should also fix the example below ...


Just a really minor thing that probably is not affecting to any of your current testing streams. Knowing how types work in Java, I think it would be more secure calculating syncBits value in this way:

int syncBits = ((mpaData[i] & 0xFF) << 8 ) | (mpaData[i + 1] & 0xFF);

With previous sentence it is really difficult/low probability getting a wrong sequence as valid, but I think it could happen.


                andycall

                boolean93

                zeroling

                lecion


Also, having product code replicated in tests isn't cool. And what's with the modulo Integer.MAX_VALUE?


can you pull in those changes? After that I think you can actually add (and publish!)


it's just a copy paste from table browser, you can check it there


Why not use `UpdateConfigFile`?


podríamos considerar agregar `locked` al glossary?


# Sorry to see the farm has gone


才发现


J'ai remarqué que le nombre associé aux tags à une seule lettre n'est pas correct.
Ça n'arrive que rarement, mais par exemple pour un article où il a du code écrit en C, j'ajoute le tag `C`.
`substr_count()` compte donc tous les mots commençant par C ou contenant la lettre C (C++, CSS, GCC, ...).

J'utilise là autre fonction ([array_count_values](http://php.net/manual/fr/function.array-count-values.php)) qui, en passant, __devrait__ économiser un peu de ressources puisqu'utilisée une seule fois.


I don't see the point on having not browseable vfolders that are hidden but still apply.


saw approval from jdm
at https://github.com/aweinstock314/servo/commit/bcc27d9bd01f973bf9f48c6e310e235ee02a8c99


merging aweinstock314/servo/master = bcc27d9b into auto


aweinstock314/servo/master = bcc27d9b merged ok, testing candidate = 417a932e


s/either/both/


Thanks, done.


No it's a typo.


s/from/with/


老A坑我，这边一失去技能就崩，我还不知道什么情况


Yep, thanks ;)


I would remove the stats maybe, and add them to a blog post at a later time.. wdyt? they seem a bit lonely..


Published to http://ui.edev.desire2learn.com/44_ae30901ca5453d1e0118cda58a29e13c1d8cb4e7


I think this should probably be implemented as handle_callback, which gets called by during the handling of the callback.


The update pulling is only based on the state of the slave that pulls updates. So the state of the master is irrelevant in this case. We trust the clustering logic to give us event when a new master gets elected and when we, as a slave, are available again after having joined a new master.


Could you please write docstrings for this function? In general, it would be a good idea to run pylint and pep8 over all of your code. edX doesn't allow pylint/pep8 errors.


另外刺槐失去效果写错了，如果直接在代码里设置mark，则会出现十分诡异的情况


Javadoc this, please.


Thanks, this applet https://github.com/lestcape/Spices-Menu will get you more thanks if i find a way to implement this without convert the cinnamon desktop on scrap...


Fixed


Please add a docstring here as well


roll back


It's better to split the android NDK expression into two separate files each implementing a version instead of filling the expression with conditionals all over the place. This is the convention we also follow for other Nix packages which require (for some reason) multiple versions to be supported.


Thread.sleep() is something we should look into avoiding. In general. I guess, not critical at this point as long as everything works fine, but in perspective we should think about something else. What was the reason for this one?


Are these 3 variables used anywhere (in each of these 3 files)?


And this one?


The warping is done by the SDK not by my application.

You mean to use something like geDebugger?


I guess this whole header needs updated


This is a fix for https://github.com/magnumripper/JohnTheRipper/commit/914cc054f2cc86ceb47af4a6d1bf4a1196659bc2


Can you tell me what is being changed here? Everything looks very unnecessary and in some cases will make the code harder to read ie. lines #46 & #54-55


What was the reason for commenting these tests out? They passed for me.


89435026-initialize-SysTotCoolCap (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (622 of 622 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-3.65%25-green.svg)


いやいや、あってますね。ただ作りがよろしくないだけです。一旦マージして作り変えます。


Rather than mutating a the input object (or the actual flags themselves), return back a separate server info.

What we found in start.go, was that directly mutating flags and the objects bound to those flags leads to madness during maintenance as calls have to made in the proper sequence, flags have different values depending on where you call them in the chain, and it becomes impossible to determine actual user intent (did he set this flag or did we do it synthetically).


Note: this is a global comment - all of these headers should be re-checked for the name/usage/copyright/etc.


Ok, no need to change it then I think. I thought it might have been a temporary workaround.


@lassewesth @chrisvest I'm open to other suggestions here. I was just trying to get the thing working without thinking too hard about it.


That is a global comment about the comment blocks also - if you want to keep these in just add a comment line about why they are there