`is3D` is returned by `[data, is3D] = getXYZDataFromLine(m2t, h);` but is also readily available in `m2t.axesContainers{end}.is3D`. Hence we can use that in `writePlotData`. Also, I would not return `is3D` with the `getXYZData*` functions because it carries the risk of going back to the old approach where dimensionality was inferred from the data (we have `isAxis3D` for that and an axis can be 2d but the data can have an unnecessary column of ones for the z dimension).

Now, `hasLines` is used by `splitByArraySize` (and that wasn't easy to spot). If I get it correctly, its only function is to avoid adding one additional point if we are using **markers only**. I think we can easily get rid of that check and just add this point any way, thus avoiding to pass `hasLines` across three functions from the main one!

Finally, I think that we should merge `splitByArraySize` into `splitLine` and delete the `dataCell{1} = data;` wrapping. Can't see why we are doing that :smile:

This would reduce `drawLine`'s complexity, but due to the peculiarity of the `writePlotData` I do not think it would be re-usable in other contexts.


Arduino:1.6.0 (Windows 7), ："Arduino Mega or Mega 2560, ATmega2560 (Mega 2560)"

SdFatUtil.cpp.o: In function `SdFatUtil::FreeRam()':
C:\Users\GsoftB\AppData\Local\Temp\build5743999789393343371.tmp/SdFatUtil.cpp:33: undefined reference to `SdFatUtil::__brkval'
C:\Users\GsoftB\AppData\Local\Temp\build5743999789393343371.tmp/SdFatUtil.cpp:33: undefined reference to `SdFatUtil::__brkval'
C:\Users\GsoftB\AppData\Local\Temp\build5743999789393343371.tmp/SdFatUtil.cpp:36: undefined reference to `SdFatUtil::__bss_end'
C:\Users\GsoftB\AppData\Local\Temp\build5743999789393343371.tmp/SdFatUtil.cpp:36: undefined reference to `SdFatUtil::__bss_end'
collect2: error: ld returned 1 exit status


not used in this function...


oh yeah, hrm... I'll fix this

On Mon, Mar 9, 2015 at 1:04 PM, Sal <notifications@github.com> wrote:

> I think the CI build failed with this
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/loosebazooka/gradle-appengine-plugin/commit/ad06dc4eb22c172fca985afc67b8d291b504744d#commitcomment-10104245>
> .
>


I think it works nicely. It was originally going to be the `EventHandler` monad. I just wanted a way to return a value, but also signal whether or not we should call one of those three methods on the event. `Writer` was my first thought  but it seemed unnecessary to drag `transformers` in, so I just built a quick writer monad. Then, since nothing uses the return value, I decided not to implement `Monad` since `Apply` is enough.

I might place the monad with a tuple of `Boolean`s though.


recovered, phew


Should this be .com and not .vom?


u


nada que comentar


This looks great. I'll try it out ASAP


Indeed, thank you for the PR, but I assume this should be a pull request against the actual Kubernetes repo rather than my fork.


I don't see where this is used, maybe should be removed as well.


Hmmm. Not exactly the expected effect. But it turned out a great help in debugging - it appears that ctest considers the forked test a full test run somehow.,,


I think right now we're consistent across the Framework on using the actual class name versus `$this` but I do agree with that in principle and wouldn't mind changing it across the board.


Are you sure it was the Material design one? I think you're talking about this one... https://www.youtube.com/watch?v=AbunztfV5vU


procctl is also available on 10.x, isn't it?


@gemri
Where did you get this way of computing `<C>` from?

`[C] α J/K` but you had `(J²-J)/T²`

Furthermore, the heat capacity is defined as `Q/ΔT`(transferred heat energy per temperaturedifference), so one would need energy-data for simulations at different temperatures to compute anything meaningful.
(For a quick reference see [here](http://en.wikipedia.org/wiki/Heat_capacity#Extensive_and_intensive_quantities).)

If I missed the point of what you wanted to achieve, please explain.


Don't write "Update fib.s" in GIT commit messages. Instead, you should summarize the changes in the first line.


Me and @cvan never make grammar mistakes.


89812206_radiance_fix (rpg777) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-83.6%25-red.svg)


Наколькі я разумею гэта прамежкавы стан


It will be fetched (through Form_Input::getTitle) and would be used for the Group-<label>. See https://github.com/SjonHortensius/pfsense/blob/bootstrap/usr/local/www/classes/Form/Section.class.php#L24


Please improve your English expression.


dat message de commit :o


Ah, worse! On my machine everything higher than 512 sounds excellent, but once you go down to 256 it gets way choppy


@jfarcand, heya and sorry for the regression but this is the thing we might need to discuss. With your fix you signal CLOSE always (as expected in the failing unit tests), but according to the JavaDoc in ```Enum``` we promise to signal once only :
```java
public enum Event {

    /**
     * This event is fired when the connection is open. This event is only fired once.
     */
    OPEN,

    /**
     * This event is fired when the connection gets closed. This event is only fired once.
     */
    CLOSE,

```
This is what I tried to explain initially here #117.

Maybe that JavaDoc just needs to be changed...


Tests passed with without issue on OS X 10.4.11/PowerPC, trying it again on 10.9.5 tests don't quite work out.

libtool: link: clang -I../src -pipe -O2 -o pad pad.o getsize.o genrand.o hwrand.o aes.o util.o progress.o sig.o  -L/usr/pkgsrc/current/sysutils/diskscrub/work/.buildlink/lib
ld: warning: ld: warning: ignoring file pad.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): pad.oignoring file getsize.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): getsize.o

ld: warning: ignoring file genrand.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): genrand.o
ld: warning: ignoring file hwrand.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): hwrand.o
ld: warning: ignoring file aes.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): aes.o
ld: warning: ignoring file util.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): util.old: warning:
ignoring file progress.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): progress.o
ld: warning: ignoring file sig.o, file was built for unsupported file format ( 0xCF 0xFA 0xED 0xFE 0x07 0x00 0x00 0x01 0x03 0x00 0x00 0x00 0x01 0x00 0x00 0x00 ) which is not the architecture being linked (i386): sig.o
Undefined symbols for architecture i386:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1

Need to work out if that's specific to pkgsrc


I like the ~/.iron/config.json idea!


Yes, thanks for pointing it out!


Noice


Don't write comments in Chinese. Please do it in English!


location.origin was redefined before calling this method. But is better to redefined it here too, because this method called more than once. Thanks.


See my last few commits.


Thanks Professor! I saw the mails coming in late Friday and early Saturday, so thanks for putting this all together. I'm not sure how the data and args lines got like that, they look fine in my terminal, but regardless, thanks for refining it.


88620866-ExpandObjectsCrashWithTwoPeriods (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1145 of 1146 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.57%25-green.svg)


why the extra ; ?


Did you try onchange="uploadFile(this.files)" instead of `onchange="angular.element(this).scope().uploadFile(this.files)"`? this is more idiomatic


no need for empty success and errror handlers


@jfarcand I was under the assumption that ```Options``` were only to be created through the fluent ```OptionsBuilder```and therefore stay backwards compatible by keeping :
```java
public T pauseBeforeReconnectInSeconds(int reconnectInSecond)
```
and adding
```java
public T pauseBeforeReconnectInMilliseconds(int reconnectTimeoutInMilliseconds)
```


is name here the actual tarball filename?


Ok, I'll create pull request altogether with usage example.


Is the `StringtPairArray.h` include still needed?


Also, the more I test it out, the more it only sounds good at first, and when things happen it will start getting choppy. Great start, just gotta work out kinks


nice


As seen with @slyg , I replace left by text-indent and recreate a tag, it should be fix the problem.


See: https://sourceforge.net/p/phpmyadmin/bugs/4791/


FYI, I re-wrote this quite a bit so definitely make sure you re-test it from your perspective.


If I understand what's going on correctly, we also need this line:

`!core/client/dist/assets/**`

?


Would you be willing to PR all of these 1.8 changes? I'm focusing on starting prism for sponge but would love to make your work official in the mean time.


This line allow us to change the password to a blank new one. This approach breaks login form and html5 forms with [required] attribute on password fields.


Done in 408aaabd5a3804a6fc0580b6ab7d3a31060e601e


Rekt


Can you show the error message?


How would it have already gotten set if the authentication was via the device?
When I look at my saved SMS docs on staging the owner_id is not set in the call object.


No, it's the "name" property (it's defined as "special" a few lines above).


Secondly, if it was actually already set, then why are you even storing the `owner_id` in the kvs store?


89812206_radiance_fix (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I was originally trying to be clear that we don't store anything if the parse doesn't work, but this is one of the things that could be tightened up a lot by simply saying beforehand that a failed parse aborts all further processing (which we now mostly have)


I am fine  either way but to have script calls in each package.json file seemed redundant.  I played with having just one package.json at root to satisfy the node request but didn't get to spend much time so I just pulled in @wesleytodd PR.  @colde - would you mind adding back what you need to get the test to work and submit a PR?  The ideal solution would be to have a root level package.json with test folder moved to root,  but all the build files and dependencies in the build folder.


Done 408aaabd5a3804a6fc0580b6ab7d3a31060e601e


HotFix-EvapCoolerFlowRate (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1647 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi @RunninglVlan nicely spot, do you think this is even better?:
```javascript
var assets = app.assets.find("My Image", pc.asset.ASSET_IMAGE);
var img = new Image();
img.src = assets[0].getFileUrl();
```

And could you please fill our CLA here: https://docs.google.com/a/playcanvas.com/forms/d/1Ih69zQfJG-QDLIEpHr6CsaAs6fPORNOVnMv5nuo0cjk/viewform
This protects the Engine from copyright issues. So we can merge your pull requests.


Deixa essa linha comentanda. Além disso, coloca um comentário antes explicando que é para a pessoa mudar esse path quando for rodar.


right, this one should be a single value. I think we need to be prescriptive on this so that it's clear how

a=foo:yes
a=foo:no

should be handled.


@AdoHe This is no longer needed in v2.0. Reference: https://github.com/coreos/etcd/blob/8788c74b48746cffa7aecd1b765be433cf21bb36/Documentation/backward_compatibility.md#read-consistency-flag


@mity: I'm glad my changes were of use to you. I merged your upstream changes into my fork and adapted my code.

The only problem I had was that I had to revert one of your other revs: mity/mctrl@6304e5cb9f5507dcfd47afe916e181d9306974d9. It was causing a link error in Psiphon (although not in `ex_html.c`, even though it's also using the static lib). I really don't know why.


Default value should be `False`.


Muda o nome do arquivo para um nome mais sugestivo.


OK


Dette er en test


@Before and @After are called before and after each test method.
So if new unit tests are added to this class the changes will affect them.
Same for @Before/AfterClass.
The unit test tries to be as autonomous as it can.


acho mais legal executionTimeDataModif, executionTimeDataWide, ou algo do tipo, do que só colocar 2. O nome da variável perde a expressividade.


A comma feels right to me here but I admit it is a matter of taste.


It doesn't harm anyone I think.


how about we just hold on to `byte[] buffer` and `Slice bufferSlice`, so we don't have to unwrap


The error message is the throw exception. `$values should be an sequential array, associative array given.  Or you can set "names_for_values" option to true.`


Thought this is a private function so didn't use regular doc commentation.
I'll make one^^


Comparar o que dos dois?

Gostei que tu fez um README.md nessa pasta. Tinha como fazer na pasta pai também?


Haven't you told me that I need a newline before documentation?


Aquí he supuesto que se debería crear una Exception propia de este tipo: "OpenExchangeRatesNotValidIDException" cuando se de el caso de error ya que por ejemplo no hayamos especificado el api key o sea inválida.
¿Sería correcto esto?


I would not use defaults for location and address here as they are somehow required. As a rule of thumb: Use defaults only for optional parameters.


Check out the new drag and drop feature on Guardians.  I've moved the drag to the div, and added highlight and hover classes on the drop target.


You can remove the comment:


sorry this didn't occur to me before but `utils.get_discussion_categories_ids()` is gonna get called on every iteration of the loop in this list comprehension.   i think we should call it once and pass its result as a variable into the comprehension.


Thanks @nihco2 , appreciate it.


Why are these variables public? They're not used in any other script. It's preferred to make things private by default, and then public *only* when you need to access it in another script, and even then, there are several other things you should try/do before making it public, e.g. "readonly", use a property, or have a method which encapsulates interaction (Pancake.Cook() rather than if (!pancake.Cooked) { do stuff, then pancake.Cooked = true; }).

Exposing them publicly means any other script could mess this script up, which is confusing, since it wouldn't even be code in this file. It also clutters up the autocomplete.

Additionally, making them public (by default, but you could separately turn this off) exposes them in the editor, meaning someone could accidentally change it, or at least adds another confusing option. Even if no one touches it, it also makes it serialized, which means Unity will save the default value in the scene file, which will overwrite whatever default is written here (although these two in particular doesn't set a default, other public variables in this file do).


Please watch for changes of indentation (4 vs. 2 whitespace)


Oh damn I forgot to change it for `search_for()`...


- not working


Fuck! Thought this was your commit! :-)


Well, maybe we should add PSR-5, even if it's not proposed yet, as a requirement.


I've had a couple of those nights haha.


@pmorie Yes I realized over the weekend that I forgot that step, it's coming :)


Added weight calculation s.t. for any given side effect, all of its edges have weight equal to 1 plus .25 times the number of standard deviations of that edge's frequency value is from that side effect's mean frequency.

Weight = 1 + .25 * (edge freq. - mean freq.) / Standard Deviation

This formula will likely need to be adjusted to account for bias/encourage accurate block recognition.


eek! sloppy mistake


Wow it does seem ```chown(1)``` is missing now. Also I agree with the ```cp -p``` will have to figure this out.


I forgot it!


would let it there as it is. If someone reads it again it's more obvious. Maybe the reader doesn't know that when `current_match is None` that no more matches are found, he could also think that this is an error^^


i don't think set() is necessary here.


Just to follow the syntax, change
private URI testHttpUri, testHttpsUri, testFtpUri, testSocksUri;

to this:
private URI testHttpUri;
private URI testHttpsUri;
private URI testFtpUri;
private URI testSocksUri;


ok


no, style is

```python
def method(*params):
    """
    Some description.

    :param params: All the nice params.
    """
    pass  # Let's do something interesting!
```


ack


so there's a newline after the brief description


okay


This typedef / using used to have some value.  But I doubt that being able to replace the name `Sections` with `Parameters` serves a good purpose now.  Although this would expand the scope of your change (and you can say no), I'd suggest removing this `using` declaration and fixing all of the `Parameters` that complain to be `Sections`.

You could also say that you'd prefer to do it in a different pull request.  Or "not my problem."  I won't hold up the pull request over this.


Should have read
*removed obsolete average *pair distance* files*


yeah okay this one is really unneded xD


Is this DMCA request legitimate? It seems like all those repos used a public API at `api.naxos.com` :confused:


Ok, I see that for `Form_Group` but `Form_Checkbox` and `Form_Select` never call `getTitle()`


If you don't specify an access modifier, it'll default to Internal, which means any file in the same  "assembly" can touch it -- for our purposes that basically means it's public. Change to private


really? okay I'll migrate it to the next one (3f5f49d05d0d4257e274747d2cbb6ae925ce538c).


Make private


then only `no more matches found`. Describing in the comment what the code does clutters everything with unneeded info thus *de*creasing readability


1506-GridViewHeaderLabel (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


yeah, I could hang you for this one! :D


This change is correct.


same issue


1.62 skipped


Checking membership of a set is O(1) while checking membership of a list O(n). That being said, I'm not sure the time complexity of converting a list to a set, which seems like it could be O(n) itself.


oh this line can be ignored.. was playing with vehiclestore to test the textures :)


Released github-api-plugin for jenkins in tact


Thanks so much, Levent! The road is now clear to Cryptol 2.2...


No, but it used to lower the dependence on css files or creating a module on javascript only (without style-files).


Based on the usage, this should be a property. Rather than having to remember to set this every time, just do
```
private bool HasColor {
get {
return sr.color != Color.white;
}
}
```


Group calls getTitle() on Input, which could be an instance of Select / Checkbox. Try changing $title in your code and you should see the difference in the resulting html


El 2015-03-09 08:54, Guy Sheffer escribió:

> Hey,
> Are you planning to report CPU and temperatures to the GUI?
>
> --
> Reply to this email directly or view it on GitHub [1].

yes in conky applicaction.

PD: I made a mistake in sending the pull-request

Links:
------
[1]
https://github.com/Qubotica/OctoPi/commit/441b19827c8cacfa2a48cc43e24b53b85c11d325#commitcomment-10097779


This is still needed for Linux, which uses upper case mac address as peripheral ID in string.
If user specified lower case one, it would fail the string comparison.


Or  get_if_exists<int>(sec, "delete_branch", setup.deleteBatch);


oh my


I have it solved. Will make a PR shortly.


1. Good point, I'll add another test case.
2. That is fully correct, since the tests in the further commits all work like they should, so `pos = current_match.end()`  would be wrong!
3. A zero char match would match nothing after each char, so you get `len(string)` matches containing nothing. if you do that it's your fault. Since it really matches regex patterns it behaves like a regex processor, so this a intended behaviour^^


Nope, we don't want that. That's dev assets. I am perfect.


MonoBehaviour also has a GetComponent method, so you can just do
```
GetComponent<SpriteRenderer>();
```


Thanks Byron! Rendani and I fixed our changes too so we can now latex this :)


Since I comment for every test function shortly what it does I would keep it, even if it's obvious.


I'm shocked that lines 82-91 were acceptable... rewriting those.


Remove above 2 prints unless needed


Hm yes will do that


was it you rhythms


Thanks! We'll add ours to this txt and then we'll latex it


I pulled the branch and tried implementing a deselectPiece function that would be called after sendMove is finished, but wasn't able to get it working. I think I might be getting confused as to the use of `this` when passed through the function as arguments. Maybe we can jump on a Hangout and do some paired programming on this..


okay I misunderstood, I'll change^^


You are right, there are repeats


Heh, you know what I imagined? Someone telling - @bob I need help. )
No worries, best wishes


89812206_radiance_fix (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I got it.
I'll fix it tomorrow.


Looks great thanks!


I changed it in a way that untrimmed parameters are used now if no Vcal setting can be found in the ini file.


Thanks Andre! Looks good


don't know what you mean


Agreed. Do you want to PR?


What suggestions? What is this? :)


Added it to the preparation and after all tests are done, a summary of the test durations is shown. During the tests, it is now displayed for how long the test has been running already.


This will not work https://developer.mozilla.org/en-US/docs/Web-based_protocol_handlers ?


Define a little evil in the function?
might be better not to define.


A slimmer alternate ...


We might need some of these back for Button Key Remapping and possibly Sweep2Wake, if we implement it...


Cool! Thanks for adding.


Is there an obvious bug I'm being oblivious to our do you just not like getting the log that way?


:P Yeah


88620866-ExpandObjectsCrashWithTwoPeriods (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This was a joke anyway


I know .gitignore and will implement it

I was wondering about that file

thanks

Dan Williams, PMP, PMI-ACP, CSP

Cell: 425-8776333

שָׁלוֹם עֲלֵיכֶם

peace to you

From: Jean-Denis Vauguet [mailto:notifications@github.com]
Sent: Sunday, March 08, 2015 7:00 PM
To: danielwilliams12/first-app
Subject: Re: [first-app] Updated gem file for deployment to Heroku (6c1eada)

Excellent.

I can see Cloud9 has created a hidden directory, .c9, with a few configuration files describing the state of the workspace in the cloud. Because this is irrelevant to the application itself and actually "pollutes" the commits, we could ignore (stop tracking) this repository.

As a side exercise, could you research what's a .gitignore file and how you could use it to ignore Cloud9's config directory?

—
Reply to this email directly or view it on GitHub <https://github.com/danielwilliams12/first-app/commit/6c1eada1ae19d9439d8c3087fb28a604f1e3e25b#commitcomment-10091939> .  <https://github.com/notifications/beacon/AGEhg5_GxfOkH56VNqhpEBq2ThW6-5Y-ks5nzPYNgaJpZM4DrasX.gif>


It's weird to have the allocation/resize logic spread out all over. I would move this and the resize code that's currently in decompressZip/decompressSnappy into a single method, such as `ensureBufferSize`, that does the initial allocation or grows the buffer if needed.


There's no bug, I'm just ashamed (on reflection) to have written it.


Here I didn't know if i have to delete the first element "x" i find or I have to delete all the occurances of element "x". For example: I have to delete '5' from the list. Do I have to delete all the nodes which contains '5' as data or only the first node which contains '5' as data?


dfgh


No, this is mistake


My bad, we should just symlink this the "right way" instead of cp. Is anyone keen to push a quick fix? I can't at the moment.

PS: the problem is the hardlink as stated by @skarekrow - can't traverse filesystems. There seem to be folks out there having the exact same issue with `chown` `chgrp` on separate ZFS filesystems under `/usr` .


I would prefer something like

    The core Girder model types are described in the :ref:`concepts` section of the user guide.

For some reason the word 'semantics' bothers me, but it is correct to say it.  Feel free to merge as is.

LGTM.


3. If this would hold true than re.finditer with such an expression and one match would result in an endless loop. I'm sure this doesn't hold true thus I disagree here.


a bit late, ack :D


By itself the commit LGTM.

But maybe we should leave this in a specialization branch for now? I mean we do not know yet what exactly we will need. So it might be premature to add it to the core.


Hey @scott-mcpherson, you can use `git pull --rebase` to avoid this split in commit history.


Already dine Peter :)

On Mon, Mar 9, 2015, 12:50 PM Peter Toth <notifications@github.com> wrote:

> My bad, we should just symlink this the "right way" instead of cp. Is
> anyone keen to push a quick fix? I can't at the moment.
>
> PS: the problem is the hardlink as stated by @skarekrow
> <https://github.com/skarekrow> - can't traverse filesystems. There seem
> to be folks out there having the exact same issue with chown chgrp on
> separate ZFS filesystems under /usr .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pannon/iocage/commit/4c9ad28274a38a019d027c6b950551baedcbaa07#commitcomment-10105063>
> .
>


They're Instances of Element not Input.


Yuck! This is a horrible solution. My expectation is that you would simply fix any use of Maps to use LinkedMaps instead.


Great!


Do you want it to be a symlink instead of cp?


I can edit my PR real quick.


A URL when created should be 100% reversible to the exact String that was used to create it.


Everywhere that refers to Java the application, as opposed to java or java_ks the module, should be capped. So, here, "java keystore" would be capped (unless it's a keystore for the java module?).


Actually, I don't remember… this is at least a month old.


I think we'll adopt it as it gets finalized.  From what I've noticed, most of it is the existing de facto standard and matches a lot of what we're already doing, just some tweaks to make like this one.


Yeah, I think symlink is better.


Err, even though `ch` is never returned, in this case it's still being dropped on the floor.  The `<-ch` at the end of this function will never unblock, correct?

I'm also totally uncomfortable with changing the `log.Fatal` into a `log.Warn`; we should **never** be hitting this code path.  That is, `BlockUntilContainerStops()` should **never** be called twice with the same argument (if it is, it's a bug in the caller and should be fixed there).  After all, even with the fix it just creates a harder-to-troubleshoot error condition where we have something stuck on a channel and leaking associated resources...


Java should be capped here. I won't go on about it from here, but you should check for these throughout.


Alright will do that then. I also agree. I think it will survive an upgrade too.


Not understand this comment...maybe explain this


* misspelled 'config'.
* what if CurrentConfig.get() returns a null value?
* this code is hard to read. I would hard code the things we're checking for so that it's not blurry what the code is doing. Something like this:

```
var config = CurrentConfig.get() || {};
var configRoute = config.route || {};

if (configRoute.controller) Iron.findGenerator('route').invoke(args, opts);
if (configRoute.template) Iron.findGenerator('template').invoke(args, opts);
```

Less clever; easier to read.


Is this syntax supported for plugins as well? If not, is there a JIRA tracking that?


They are both, Input is more specific
```php
class Form_Select extends Form_Input {}
class Form_Checkbox extends Form_Input {}
class Form_Input extends Form_Element {}
```


Since module names are lowercased by convention, I'd recommend recasting sentences that place module names at the beginning of a sentence. Just even "The java_ks module supports...".


@webron If you can help round up subresource designs/issues, suggestions, I'd appreciate it.  This is not complete but would be great to get more input before I merge.


My bad, my dyslexia is kicking reading between Section, and Select.


I think it already worked for IPv4. This just prepares the way for being able to make it work for IPv6 as well.


All done just testing to make sure it didn't break anything real quick.


Aonde você está dizendo o código de resposta 201 created ?


Ah, no worries :)


Number of the season should not be hardcoded. Same with all the texts.


@adam-p: About the mity/mctrl@6304e5c: These removed GUIDs are defined in standard lib `windowscodecs.lib` (part of MS SDK). `MCTRL.DLL` is linked with it so for static build you would need to add this lib into your project dependencies.


Tested it just myself, for example:
```python
it = re.finditer("", "123456")
```
would produce a callable iterator with 7 elements in it (okay `len(string)` + 1), with nothing matched.


So keep the createTcpListeners() prototype the same?


I'm not sure I've seen this repo before. Definitely don't remember making any suggestions for it.

Nevermind. Maybe you tagged the wrong person in the description? :)


In a short time I'll add collisions stuff to models, so GuardSoul remember to fix impassable lines on your map. I hope that's OK for Torm, too.


Convenient sorting with multiple fields. I like that.


LGTM


Same as noted above. Season should not be hardcoded.


Finally remove this line, i'll store it in the parent method


They're used by the vncInetdSock bits.


Remove it too


GridViewBugFixes (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2166 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.18%25-yellow.svg)


path again?


1506-GridViewHeaderLabel (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2152 of 2182 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.63%25-yellow.svg)


This should be `bytesWritten`


I was using tab-indent-mode. I'll switch to spaces.


Yesssssssssssss


This idiom: check `exists`, set if `exists` happens a lot.  I get that it predates your changes.  But it really puts me in favor of Vinnie's suggestion of a `maybe_get` template function.  Or perhaps call it `get_if_exists`.  Since you'd be passing the destination into the template you could probably eliminate the need for the explicit template argument that `get<int>` currently uses.  You could infer `T` from the type of (in this case) `budget` (which is presumably an `int`).

I really like the idea because it gets rid of the duplicated strings (in this case `"budget"` twice).

Again, this problem predates your changes.  So I won't hold up the pull request for it.


HotFix-EvapCoolerFlowRate (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity Akka.NET :: Akka.NET PR Build [Build 113](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=177&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) is now running


@duvillierA Apologies for inconvenience, I upgrade version on Limbo but never do that in Legacy, could you please have a look ?


Would you mind rephrasing that? I'm having problems understanding that explanation.  Probably because it's still morning and my brain isn't quite working yet...  I might need diagrams :|


@jberkel that was the first thing I tried, then I was puzzled by why it wouldn't compile, but of course you can't use EnumSet since Flag isn't an Enum :-)


Does this need to be documented?


I'm OK making the change. Will do.


Isso mesmo o ideal é sempre deixar explicito as informações que vamos utiliar no metodo.
Talvez ficasse até mais elgante algo como

```php
$this->jogadores = $this->sortearClubes($jogadores, $clubes);
```

ou mesmo poderiamos utilizar um service de sorteio

```php
$this->jogadores = SorteioService::getInstance()->sortearClubes($jogadores, $clubes);
```

Isso nos permitiria mais para frente aprimorar o algoritimo e talvez até escolher o algoritimo.


Oh, indeed, I meant @LukeMarlin not @LukeMartin


This is already fixed in further revisions. Thanks for code review!


I'm still wondering about the whole thing: in `releases/$release/root/usr/sbin` chown & chgrp are hardlinked.  The two `tar` piped together should recreate the hardlink when copying in `base/$releases/root`.


How do you download it?


This would prevent tracking a user if they go backwards during the checkout process. I think there's a lot of value in knowing if your customers are doing so while checking out.


Consider `std::reverse_copy`


`detail` namespaces are not necessary in .cpp files.


Well... Forgot that pfSense isn't running PHP 5.6....


O Dominio não pode dizer qual implementação de infra utilizar. provavlemente teriamos que utilizar um IoC para ca.

```php
static function builder($nome, $repositorioCampeonato, $repositorioClube) {
  ...
}
```


"The Regulations" би трябвало да е


Consider `std::lexicographical_compare` and replacing `uint256` with `std::uint8_t S_big[32]`. Rationale: Fewer dependencies on other types.


"can be changed any time" май е по-добре.


Thanks!


Hello, when using the plot_forecast() the legend overlaps with the forecast which is very annoying. Anyway to fix this? I would like to help if I can.


Thanks @macfarlandian , this works!


Why did `scons vcxproj` make these changes? Hmm..


Is the vcxproj at the tip of _develop_ stale?


Done


Sure, absolutely fine


By the way, good GIT practice would have been a branch for this fix here independent of the coded test. Now I have to wait till you update the tests and can merge both.


Sorry, not sure about how to use ContentService in this specific instance. Could you elaborate a bit?


For every case which is not mentioned in the Regulations, the Council can amend the Regulations and the amendments enter into force immediately.


You're awesome @Praburaj thank you!


"A Member is a visitor who has paid his/her Membership Subscription for that month."


```
if ((auto iter = map_.find(section) != map_.end())
    *iter = Section{section};
```


Yes, of course.

Although, with Max’s help, we’ve empirically determined that assigning to array elements one or two beyond the end does not seem to do any damage in this environment.

From: coachFitz0807 [mailto:notifications@github.com]
Sent: Monday, March 9, 2015 12:35 PM
To: ligerbots/RecycleRush2015Robot
Cc: cfrankston
Subject: Re: [RecycleRush2015Robot] Rationalize joystick button assignments. (cc51555)

I think this needs to be 11 rather than 10. C++ assumes a zero-based index.

—
Reply to this email directly or view it on GitHub <https://github.com/ligerbots/RecycleRush2015Robot/commit/cc5155547b045d5bf6f14c70889ffdfb82108738#commitcomment-10103601> .  <https://github.com/notifications/beacon/ADNHQCzyNUi8QSXnibpcoDzK731ea40Jks5nzcNCgaJpZM4DrwsN.gif>


Should use  0 on request_var.  Request var accepts either an int (0) or a string ('')


Looks good


@ipgray I need their institutions for this participation


@ipgray I need his institution


@ipgray I need their institutions


Agree, `Parameters` is superfluous.


I have an ask, this 10.76 works on tfs 1.1, right?


do we need to know about the `tag` here, or can we `hintStaticallyElided`?


You didn't send a pull request, I was just curious because I saw the commit.


Simply because I wanted to make sure it stopped even if the limit switch are the opposite of where you guys have told me you “think” they are..

If the switches are correct, the extra check won’t matter.

From: coachFitz0807 [mailto:notifications@github.com]
Sent: Monday, March 9, 2015 12:43 PM
To: ligerbots/RecycleRush2015Robot
Cc: Charles Frankston
Subject: Re: [RecycleRush2015Robot] Working elevator simulation. (1febd3c)

Why are we checking for IsAtTop()? We should only zero the elevator at the bottom. Then it counts up as it goes up. There is a max encoder value that should be reached when the elevator IsAtTop().

—
Reply to this email directly or view it on GitHub <https://github.com/ligerbots/RecycleRush2015Robot/commit/1febd3cbfcf1fe1c06f5879e0b027c91518ee972#commitcomment-10103781> .  <https://github.com/notifications/beacon/ABenTlYq-KZmQyIGoe2xp9ZDNd-_--CTks5nzcUlgaJpZM4DrxB5.gif>


WAOW


1506-GridViewHeaderLabel (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Good catch; fixed.


This illustrates a weakness in the `Section` interface. This would be better:
```
if (! get<std::string>(keyValues, "path", m_name))
    throw std::runtime_error (
        "Missing path in RocksDBFactory backend");
```


you can grab this tag off the pickler, rather than implicitly looking it up again.


86605826-AddTransformerLossToABUPS (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1651 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Again, we can probably hint statically elided, since we aern't using the runtime hint (which comes back in beginEntry).


Maybe I'm wrong, but it doesn't make sense for me. I found the problem when I tried to run the test on my 32-bit Win7 machine. The right path should be "C:\Windows\System32\calc.exe" I have even checked in Task Manager :-)

BTW, do you mind me cloning the repo and making some pull requests? I'm not a python guru, just want to try hand at it.


Yeah, fixed in a later commit.


Looks good


I feel like this generate method should be on the sbt.serialization package object....


TeamCity Akka.NET :: Akka.NET PR Build [Build 113](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=177&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: xUnit failed for the following assemblies: D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Persistence.Tests\bin\Release\Akka.Persistence.Tests.dll, D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Tests\bin\Release\Akka.Tests.dll ... Build time: 00:10:58
### Failed tests
```
Akka.Persistence.Tests.dll: Akka.Persistence.Tests.PersistentActorSpec.PersistentActor_should_receiver_RecoveryFinished_if_its_handled_after_all_events_have_been_replayed: <no details avaliable>

Akka.Tests.dll: Akka.Tests.Actor.InboxSpec.Inbox_have_a_default_and_custom_timeouts: <no details avaliable>

Akka.Tests.dll: Akka.Tests.Routing.RoutingSpec.Router_in_general_must_evict_terminated_routees: <no details avaliable>

Akka.Tests.dll: Akka.Tests.Routing.TailChoppingSpec.Tail_chopping_router_must_throw_exception_if_no_result_will_arrive_within_the_given_time: <no details avaliable>

Akka.Persistence.Tests.dll: Akka.Persistence.Tests.GuaranteedDeliveryCrashSpec.GuaranteedDelivery_should_not_send_when_actor_crashes: <no details avaliable>

Akka.Tests.dll: Akka.Tests.Routing.ConsistentHashingRouterSpec.ConsistentHashingRouterMustAdjustNodeRingWhenRouteeDies: <no details avaliable>

```


I thought about that, but problem is there is no bijection between syntactic and semantic urls. Percent encoding, punycode, &c &c, there are many different ways to represent the same url. Then there is double slashes and /../ which you might want to normalize, but which become (strictly speaking) a different URL. Add to that the performance gain (which I have no idea what it is, since I didn't profile), and caching the input string looks quite appealing and safe.

I can't think of any other way to guarantee URL(x).toString == x. Using ordered maps will solve our problem from the other project, true. Maybe it doesn't matter. I'll leave the decision to you.


Good idea; added.


I think I'd just match against `disabledTag.key` rather than constructing a new FastTypeTag.   I may have fixed `==` in FastTypeTag, but for a while it was doing runtime reflection.


All the (very limited) testing we’ve done per date has been with the encoder values going from zero to negative something as the elevator moves up.

At this point, given that every second spent fiddling with the robot hardware/wiring takes away from software debugging time, I’m leery of touching something that’s working, even if the sign isn’t what we want. This is one of the reasons for the simulator code – make sure our logic and UI work with the negative values (although there are still plenty of ways in which the simulator could diverge from the real robot).

From: coachFitz0807 [mailto:notifications@github.com]
Sent: Monday, March 9, 2015 12:46 PM
To: ligerbots/RecycleRush2015Robot
Cc: Charles Frankston
Subject: Re: [RecycleRush2015Robot] Working elevator simulation. (1febd3c)

Any way we can keep positive up and negative down? We can invert the motor and/or the encoder.

—
Reply to this email directly or view it on GitHub <https://github.com/ligerbots/RecycleRush2015Robot/commit/1febd3cbfcf1fe1c06f5879e0b027c91518ee972#commitcomment-10103837> .  <https://github.com/notifications/beacon/ABenTujO5Ab-XIeeQZ8ith8TVJwpa0Foks5nzcW2gaJpZM4DrxB5.gif>


```scala
case `disabledTag` => Disabled
```
if you're using these things as instance-equality, go whole hog.


86605826-AddTransformerLossToABUPS (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


> Ctags labels can not contain spaces

Do you have any citation for this? I'm looking at <http://ctags.sourceforge.net/FORMAT> and I can't find that specified—Tab characters forbidden, yes, some unclear implications that spaces should perhaps be encoded with `\s`, but it's not clear to me. The current "case class" works for me, although your PR has led me to look more closely at the Tagbar config and ctags def we provide in vim-scala and I see there are some inconsistencies: the ctags def is producing `c` as the kind label for case classes, but the Tagbar config expects `r`. If I fix this, the space in "case class" works fine using Exuberant Ctags and tagbar (and looks much nicer...). I'll fix this existing problem in vim-scala.

I'm open to changing it if it's in fact clear that the spaces shouldn't be allowed and that causes problems for alternative implementations like `sctags`, but I'd like to see a clear spec to be convinced—I'd consider exuberant ctags pretty much the reference implementation, and it seems to work.

> Also we track "abstract" as an "implementation"

That sounds self-contradictory :wink: I have no problem with this change though, the ctags def we currently ship isn't even producing `a` kinds at all so this is vestigial anyway.


This code is giving incorrect reference lines for me (wrong plane). If I switch the values of ```x``` and ```y``` on lines 16 and 17, the lines are correct. If this is indeed incorrect behavior, I can submit a pull request.


I'm a little uncomfortable with the scale of the changes without some sort of test.  I know this is annoying to test, but could we have something to demonstrate this working?


コメントのコピー機能


html back


@auvipy you need to just pick up the development effort. I would suggest by first checking out existing bugs and doing bug fixes plus pr for them.


Commentaire


@mpalmi please review


Eu acabei de ler sobre os status code, vou alterar cada um,.., sim eu sei ,mas como estamos testando localmente tem q ser localhost


It's not enough to move "ob_end_clean();" after the last catch block?

I don't see why we need to set Content-Length to the size of the buffer when the "print $data" could not have executed.


Just a note:  `java.util.Date` is not a final class, and therefore can be subclassed.   You don't have an 'open sum' pickler here, nor should you.   I think it's safe to elide the date type.


I'd prefer to give this a better name than "value".  even "millis" feels better.


Looks good


Yes, I like this.


This can only work if `options` is empty and only if `tar` can autodetect the compression (GNU tar only?).

It looks like existing `:type http-tar` recipes provide `"xzf"`, or `"xjf"` as needed.


You can get this off the long pickler.


It doesn't matter that it recreates it. It can't survive the traversal. So
it wouldn't even work.

On Mon, Mar 9, 2015, 1:02 PM Ollivier Robert <notifications@github.com>
wrote:

> I'm still wondering about the whole thing: in
> releases/$release/root/usr/sbin chown & chgrp are hardlinked. The two tar
> piped together should recreate the hardlink when copying in
> base/$releases/root.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pannon/iocage/commit/4c9ad28274a38a019d027c6b950551baedcbaa07#commitcomment-10105300>
> .
>


Gostei dessa de um serviço, na vdd eu ja tinha falado isso desde o inicio, tu n me escuta kkkk


Oh forgot fixes https://github.com/red-eclipse/data/issues/5


I already added docs!

Although I just spotted an error on the Actions.md. I'll fix it


again, you can probably elide the type.


Instead of pulling notes, issues and evidence from the DB via model_namespace:: use the content service to:

* #all_issues to access issue and their associated evidence
* #all_notes to access reporting nodes

You'll have to jump through the evidence association to get the list of nodes affected by a given issue:

`content_service.all_issues.map(&:evidence).map(&:node).uniq` ? Not creat but beats going down the `model_namespace` route.

Also, probably once we start using the ContentService for Word it will make more sense, maybe we can even create a "relevant_nodes" method or something (let's not do it just yet though, until we clarify the use case).


the if/else statement below could actually be modified to simply be:
control.settings = data.config;


en backtrackant depuis une variable, on réinitialise sa valeur


I think the loop would be easier to read if it was written like this:

```
do {
   uncompressedLength += inflate();
   if (inflater.finished() || buffer.length() >= maxBufferSize) {
       break;
   }

   grow();
}

checkState(inflater.finished());
```

I also don't think we need to track or check bytesWritten separately. If `inflate()` fails, the buffer will be resized. At some point, it will exceed the max buffer size and the loop will terminate.


:eyes: :+1:


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


To migrate the `self.bs` to the next commit I need to make an edit, to work with fixups is too complicated.
I'll do that if everything else if fixupped^^


Nice, thanks.


I'm aware of the backtick notation, but I think it's a better style to always assume a pattern variable and do match in if clause.


we should check with @havocp .  I feel this may exist in sbt-protocol, so we'll not want to cause ambiguous implicits (i.e. once this sbt 0.13.8-RC1 is out, we'll ahve to fix sbt-server).


IMO this should read something like: "For languages like go, use the standard tooling for formatting (go fmt in this case)."


Shouldn't this line be
```javascript
new DirectPlayProfile


Apart from normalization (which is acceptable modification) as long as the URL remains true and valid to the original intent in the same order I think we're good.  If someone wants absolute purity then that is outside of the scope of URL.  Our goal should be to simply make sure the output URL is a proper representation of the original URL.  In summation, I recant my 100% reversible statement. ;)


Hi,
I was using normally whatsapp api, but now sometimes I can do Login and send a message, but now many times I received the message: not authorized.
Why?
I read something about token, limit of 10 requests by day for ip.... is something because of it?

Tkjs


I assume we remove this for the new TUple2 in sbt-serialziation?


The README should be updated to reflect that the revert of this feature as I spent some time trying to figure out why it wouldn't work as advertised. https://github.com/paulyoder/angular-bootstrap-show-errors#skip-form-group-check


Fix for my bug, and a reversal of the above: https://github.com/KrauseFx/fastlane/pull/112


why the space here?


no


You can hint you're statically eliding your own type here.


How do these two flags work?  (How is run different from what we had before; how is --build different from --compile-module-js?)


Yes.


Again, you can pull this off the pickler.


Resolves Issue #9


Done


Very good! Thanks! Theoretically we should distinguish between `iojs` and `node` numbers, but right now node is at 14 and iojs jumped straight to 42 to follow with 43. Hopefully node will not catch up that quick :)


This is just a matter of preference and I imagine it's influenced by `sctags` giving better nesting/scoping results, but personally I almost always want the method folds expanded by default because they're often what I'm trying to find quickly. I could see myself possibly changing my mind about this if I had proper nesting within containing classes, and I'm not going to be too insistent about it because honestly I mostly use something like CtrlP tag search for that use case these days, so I'll leave this ultimately to you or anyone else who may speak up about it.

I agree with not folding the packages scope by default. There's usually only one and having it unfolded makes it apparent what that is, with very little vertical space traded in exchange. :+1:


so... we do a string comparison on the JSON?


@dkayiwa you seriously need to add a comment here. What dev could possibly know what's going on here if they come back to peek at this code in a month? :-)


Yeah good point, I don't think you brought up that reversible thing to begin with. It's something I got in my head but now that you mention it, semantic equivalence is fine. I'll see what I can do.


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2092 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.79%25-yellow.svg)


0576dad64424f16a0cfbd6e259cacee8c0c97d9b is my attempt to address this.


nice.  WIll help us not corrupt our own cache.


Looks good


you mean with empty matches (which is not nothing matched)


Lol, I'm an idiot.


testing a change


cool. Now the question is, do we need to keep the `filter` above or can it be removed in preference of this?

Sadly we don't have ~~good~~ any test coverage on the sbt-plugin, but you could try it out by doing a `gen-ensime` on the `ensime-sbt` itself after a `localPublish` (make sure it's using your version and not the one from maven central/sonatype).


You'll want to allocate the string for log.warn ahead of time.  Additionally, log.trace(e) could ALSO throw an OOM if things haven't recovered yet.   You should try { } catch {} that guy, if you want to return r.


r+


error


Actually, @bantonsson may be able to let us know exactly what we can/can't do in this scenario.


yuck oil is much better.


 Am I misunderstanding the request_var function?

I assumed the 1 will initialize the $use_earliest var as an int with the value of 1.  Using 0 would have the html selecting "no" as a default unless I add a second php line to change $use_earliest to be 1.

From
https://wiki.phpbb.com/Function.request_var

mixed request_var ( $var_name , $default [, $multibyte [, $cookie ]] )

var_name: 	The name of the variable to pull (i.e. $_REQUEST['var'] is the same as request_var('var', '');)

default: 	The default parameter has a dual purpose. The first is to cast the variable type, and the second is to set a default value if the requested var does not exist.


Hilarious misspelling. But misspelled.


I guess we don't have a concurrent data structure that automatically does this?


Also the `$release` is not broken down to individual ZFS datasets under `/usr` - base is as this is the only way to make a basejail functionality work.


this is keep failing for me locally because of in this line: https://github.com/droolsjbpm/jbpm/commit/e890d200206ab9ca6e30bae33d2e039f2bef1aa4#diff-60cd72957742bb0b92fa6a68194ef546R112 the resource.getConfiguration() is never null and thus not handling property the CSV. any idea? maybe I am missing some other changes locally?


done


FYI - there's a race here, where in a truly concurrent system, you may accidentally remove MORE than necessary from the cache, because you're not using an atomic operation.


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/8343eb0b8a73eca97d9f1fbbb3e4ce68545d2c3e


merging Ms2ger/servo/disable-flaky-canvas-reftest = 8343eb0b into auto


Ms2ger/servo/disable-flaky-canvas-reftest = 8343eb0b merged ok, testing candidate = 7cd776b7


Again, this is not atomic.  Will the TrieMap throw an exception if the key is deleted by another thread?  If not, everything is gravy.


I think we should ask Zeev about this idea... Because like that they all run on one process, each one runs on a thread and he should run threads by himself... I'm not sure how it will effect the speed of the servers...


Done


That sure does sound simpler – something like `sym_name == ":#{key.to_a[0]}"`? Except that breaks the tests :-/


Such code should be moved to TearDown or SetUp


We've been moving toward creating an entire class for each dialog in lieu of creating the entire class inline. There are many benefits to doing so.


Ewewew


The whole thing is wrapped in ivy gloal lock, so it should be ok? I am using `concurrent.Map` I think for `clean` potentially going in there and cleaning the in-memory cache out.


86605826-AddTransformerLossToABUPS (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1651 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


C++14 as i know. Not supported by all compilers.


The filter line can be kept. I generated the .ensime file for the ensime-sbt project with no problems.


So does this one work for us ?


```cpp
 << "Test for open empty file";
```
Redundant info - what's a test should be said in test case name


Maybe we need https://github.com/jsuereth/viewducers


Looks good


Oh, hmm, I see that it's more complicated than that. But, do we need to support giving objects a color that is not their original?


As i mentioned in [UPDATE 2](https://github.com/glittergallery/GlitterGallery/pull/226), it was fixable if only we changed project to instance variable. Error message was: undefined method `urlbase' for nil:NilClass"   ie view couldn't figure out project.urlbase as project was nil:NilClass.

Do we need this temp solution?


Closes #5


Don't catch all throwables here.  VERY VERY bad.  IN particular: InterruptedException.

You should at least limit yourself to IOException or something lower in the hierarchy.


Create camera for PixelVoid (EasterEgg)


Yes, this looks ok.


This value should be a macro


How about this at the beginning of the function?
```
if ($message === false)
    throw new Exception("DeviceManager->DoNotStreamMessage(): message isn't an object");
```
I think we only hit this error when Fetch returns "false" instead of an object.


These values should have been macros


I've gone through a lot of effort to remove the necessity to perform JSONObject or splittable construction from View-related code. It is not yet consistent across the board, but many service facade endpoints have been refactored to perform these duties. This kind of functionality only tends to clutter and complicate the UI over time.

Please, let's talk so we can figure out another way to get these things done.


oh sorry, exactly.


this can go in the footer, no? just for our internal usage.


It's already supported for plugins.


There are a few magic numbers here


Fixed.


Looks good (but I don't like the magic numbers)


86605826-AddTransformerLossToABUPS (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1645 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


You're working with a lot of stuff from the wolf right now, wolf, wolfSr, and c, which is also from wolf. Usually to me, I've found that to be a sign the behavior should be on the wolf object. This might be ok for now, but at some point we might want to move some of this behavior to wolf. E.g. wolf.GiveColor(), wolf.TakeColor()


"French translation, by french person, not litteral translation so. It make more sense. " La blague ...


Done


Can I bump a zImage for use with anykernel installer?


Unused variable?


Why?


On a slow server, you could have a lot of log messages :P

But is it not better to release the lock after a (long) timeout? Because this "workaround" will just add more messages in the log file but it will not solve the problem because the lock could never be released (as we had before).


@sonalkr132 wouldn't replacing `project` with `@project` fix it?


This should probably be a property that just returns the sprite renderer's color.


I'd suggest doing something with `cause` as well. Here's one possibility: https://gist.github.com/brianr/319cd1a3b6d3d4bf2980


Values m_left_border of SkinConfig::m_render_params and height of SkinConfig::m_render_params->getImage() are always 110 and 128, but only in current layout.


Looks good


Remove unused code / try to avoid committing in future. It creates clutter which may be forgotten about.


Do you know why?


@djazayeri i agree! :)
Added some comments at: https://github.com/openmrs/openmrs-module-uiframework/commit/c6a9bb1179d7e3930a299b373b27b5b6d730b932


I believe the JDBC driver labels it HPCC System, since this is referencing a single hpcc system


Hey @balazsgyenes you don't need to use "self" here. Just do
mypHcontrol.savepH(reactor.sample_pH)
mypHcontrol.savepHset(reactor.pHSetpoint)
mypHcontrol.switch()


NumLevels


Nice


I suppose, I'm not even sure what it is.


So here is the part of the FORMAT:
```
A tagfield has a name, a colon, and a value: "name:value".
- The name consist only out of alphabetical characters.  Upper and lower case
  are allowed.  Lower case is recommended.  Case matters ("kind:" and "Kind:
  are different tagfields).
- The value may be empty.
  It cannot contain a <Tab>.
  When a value contains a "\t", this stands for a <Tab>.
  When a value contains a "\r", this stands for a <CR>.
  When a value contains a "\n", this stands for a <NL>.
  When a value contains a "\\", this stands for a single '\' character.
  Other use of the backslash character is reserved for future expansion.
  Warning: When a tagfield value holds an MS-DOS file name, the backslashes
  must be doubled!
```

My experience: "case class" (with space) will work OK in current ctags setup because it does not produce scopes, I have tried to put "case class:Foo" in the tagfields and in breaks tagbar. I have tried some other escape variants without success but I have not tried with \s though - I will try with it soon.


err.set(...)


Sounds good @Squareys. Thanks for following up.


I've been refactoring the code so that the use of autobeans is restricted to the service facade layer.


You're welcome!


@renanmzmendes ^^^


@sutram thanks, but is it perhaps redundant now?


This works, but it may have been more intuitive to just constrain the Z rotation


Why is there an asymmetry between the server and client RL records?  Is the model that a client has some transient metadata that eventually is synced upstream, and is therefore "glued on" to the canonical server RL record?


For now yes. I don't think I'm using this feature yet.


Try to avoid duplicating code from the commented out section, that way we can narrow down what part doesn't work


Looks good


Done


I have no strong feelings about leaving methods unfolded, just the local variables eat a lot of vertical space in the larger sources.


Looks goofd to me


Yes, for 32-bit Windows this is valid point. Additional check is required.
I have no 32-bit Windows in my environment. :)

And yes, you're welcome to fork the repo and make pull requests. I really
appreciate your contribution!

2015-03-09 21:10 GMT+03:00 airelil <notifications@github.com>:

> Maybe I'm wrong, but it doesn't make sense for me. I found the problem
> when I tried to run the test on my 32-bit Win7 machine. The right path
> should be "C:\Windows\System32\calc.exe" I have even checked in Task
> Manager :-)
>
> BTW, do you mind me cloning the repo and making some pull requests? I'm
> not a python guru, just want to try hand at it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vasily-v-ryabov/pywinauto-64/commit/21eb32facd8986923f4b5416b14ba4fe1acb95bc#commitcomment-10105475>
> .
>


couple of minor comments.


that should be fine then.


I added another renaming procedure to the pipeline. It takes place after typechecking and before code generation. It transforms all EApp to EVals, and if it comes across any ECalls, the single expression it contains is reworked to an ETuple, containing all parameters. The code generator then relies on this structure and compiles all EVals and ECalls as is. This is not yet tested for BIF's with arity 0.

Some thoughts:

* + and - BIF's are now only defined for Ints, I guess we need to add all combinations of Int/double etc for bifs later on.
* I realize that my use of the error function breaks the ErrM philosophy, I will attempt to care of this in both PreCodeGen.hs and CodeGenerator.hs


I believe this will work as intended, because `&&` and `||` have the same "priority level" and the code will be executed from left-to-right. But, when reading the code, this might be confusing. Consider the following:

``` ruby
1 && true || 2
=> true
1 && false || 2
=> 2
```

Which is equivalent to:

``` ruby
(1 && true) || 2
=> true
(1 && false) || 2
=> 2
```

I'd use the version with parenthesis though, because in your case, I feel like it makes it more obvious what the two possible valid options are:

``` ruby
(user_exists? && record_owned_by_user?) || user_is?('admin', 'moderator')
```


That wasn't so obvious to fix. I simplified the code so now both folder selection and  reset-search action will reset the filter. I hope it's fine.


@eric-brechemier Thanks!


I don't think the button matters much, but a minor concern might be that for a user of WASD, z is a bit out of the way, maybe something like C for color?


Thsi was Dasvd's code? Looks ok to me


Since `walCheckpointer_` is a member of `DatabaseCon`, it's going to get destructed, too. And doesn't the `~unique_ptr` have the same effect as calling `reset()`? (If not, what is the difference?)


develop (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


mnkbg


I'm not sure what the second half of this sentence is saying exactly. I'm wondering if you mean "propagate" where you say "accomplish"? Even with that, I'm wondering if there's any more direct way of phrasing this.


Just a clarification: with nesting and folded methods you see all the methods be they are not themselves unfolded to expose the local variables in the method - I think most of the ctags definitions don't even produce tags for these (I checked Java)


Same as for the `CommentPolicy`.


Oh damn I thought I already acked it before so I didn't read over again, sorry ._.
-> unack

I would replace `&` with a plain `and`. Since it's an English text I won't use special signs like `&`.

Please change also the commit message and add a tag.
And if possible reference the issue in the detailed commit message^^

I blame myself for not looking at your commit better :O


I will follow the JDBC connector pattern "HPCC System"


Freeze / Thaw imo is more useful as the doublebuffering...


Please mention addition of `save-excursion` in the commit message or split it out into a separate commit.  Also, please remove trailing whitespace.


This resolves chapmanu/inside#238


Is this code related to CPSDT or GIS code for Kathleen?

Looks ok


That does sound clearer.


Sorry, I was an idiot, let's not do this.


I decided to just give a level of 1, since this is relatively useful trace message in terms of what the kernel is doing.


With this change, line 108 no longer needs to construct `std::string` to do `i.first + i.second`.


Manages Java keystores using a combination of the binaries `openssl` and `keytool`.


About shallow nesting, did you know Rails has built-in support for this? Check the [Rails Guide about Routing](http://guides.rubyonrails.org/routing.html), section 2.7.2 "Shallow Nesting".


Incorrect label. Should be FB6393.


I hint everything out of habit. Is that bad?


Le commented out code


老伍，这个this.inInsert是指insert post, 还是insert likes object?
我的理解 like operation 触发的是post update，所以like的操作应该是isUpdate?


Should be no hard return between these lines.


这个直接用likes.length代替？


@fommil It may not be because of how Maven defines "provided".

https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html

Unless I am mistaken, "provided" jars should only appear during compile and not during runtime. I assume that the plugin should follow the same approach.


Should be no hard return before this line.


Looks good as long as ``desc->cmd_desc_mapd.its_dev->lpis.lpi_num`` is always non-zero.


Super protected. =]


Looks good


so now you don't test with `max_matches = 0` and you still don't test the corner case when the match itself has only one char.


Can you add description about using Formatter and DateValidator. The description here is a general idea about accessing/manipulating DB columns that are not suitable to be directly used.


Wouldn't it be better to write `${project.version}` here? Otherwise, you'll have to manually update it every time...


I don't do it often but I ran out of time Saturday.  But in my defense, it did need to get changed.


Can you fix the use of magic numbers here.


This commit seems to leave indentation in a broken state without the following commit:

    cond: Wrong type argument: number-or-marker-p, nil


Finally, a time management patch passed LTC. Congrats!


```
Running "jshint:all" (jshint) task
   src/countdown.js
    193 |      this.totalSecsLeft = this.totalSecsLeft < 0 ? Math.abs(this.totalSecsLeft) : this.totalSecsLeft;
                                                                                ^ Line is too long.
>> 1 error in 12 files
```


LOVE IT


A commit is a commit. As long as it's not a readme bump haha
On Mar 9, 2015 1:52 PM, "Dwaligon" <notifications@github.com> wrote:

> I don't do it often but I ran out of time Saturday. But in my defense, it
> did need to get changed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Dwaligon/twitchcreep/commit/8738f903b73289df8e1bbeeafc7e1ab91f4e5dee#commitcomment-10106276>
> .
>


so, no +1 here?


protobuf::message& _in was not used as reference here, but was copied.


After this, indentation of normal command calls (not branching structures) seems to go back to the level of the opening command name.

Also, the reason we keep the closing paren one level deeper is that opening a conditional block without extra indentation on the `)` looks funny:

    if(SOME_VAR AND
        SOME_OTHER_VAR
      )
      message(...)
    endif()


> the local variables eat a lot of vertical space in the larger sources.

Totally agree, these were also broken in the ctags config currently distributed (again different labels from the Tagbar config). I'm fixing that now and folding them by default.


Laravel-doctrine is PHP 5.5+.

This merge cannot be accepted with this particular change.


Isn't this O(N^2)? or do we not care because the list will be small enough. I'd suggested using a map in https://github.com/GoogleCloudPlatform/kubernetes/issues/5188#issue-60381026, I feel like you're reimplementing a set but I'm not familiar enough with this code to push for one or the other. As long as the expected size of the ip list is small enough it shouldn't matter.


LOL.  I was in javascript mode and didn't even think to add a :hover tag!  Definitely the way to go.  I'll refactor and re-submit push.


Oh, cool. I'll have to remember that one


Congrats indeed! And there may be some more gain from tuning..


This seems to have broken the ability to define a style before you've added the source. Before, we would add the styles via JSON, initialize the map with our extended styles, then add a GeoJSON source after the map was initialized. Now, because of the validation, the map cannot be initialized because the source is not defined yet. Was this an intentional change or an accidental one?


@mpalmi please review. This allows you to not have to run make bare when you modify CONFIG_REPOS.


The issue with that is that we are also reading in a scaleX value in that navigation string which doesn't really make sense to be stored in Location since it's not describing a point on the timeline. That was the only reason I chose to build the Location in the FindController which passed that and a scaleX value to the timeline. ScaleX is more of a UI-state variable -- would it be better if we had another class (UIState?) that consisted of a Location (specifying the current point of interest) and a ScaleX?


Thanks guys!


Actually maybe more "natural" date handling would be to use CanToString with ISO 8601 format like `2000-01-01T00:00:00`, and put it in sbt/serialization


Less farts, please.


Fine by me


What do you think about making a script:  unittest.sh?

It seems superfluous since this should really be done by Maven, but since mvn test doesn't work outside of Google's special non-publicly available environment and because we don't want to break that, I think this makes sense as a stop-gap.

Having unittest.sh would allow populating all/most of the /path/to/dexmaker strings, too.
We could even check in vogar.jar to make the build & test cycle more repeatable for other developers.

Thoughts?

PS.  If we agree on this, maybe it would make sense to go ahead and push this in a separate PR so that it doesn't get held up by the other functional mods to dex maker.  Having this in a single commit could make things easier to revert should we ever need to in the future.


Because you used a nested `resources :posts, except: [:index]`, it's expected that the missing "index" action will be available through a different route. One would expect the root `resources :posts` to provide the "index" action: `resource :posts, only: [:index]`.

In some previous checkpoint, you were told to actually *not* provide the index action (if I remember correctly). In such cases, it's always a good idea to add a little comment in the routes file, to explain why there is a missing action, so that new developers (and yourself, in a few weeks/months!) can quickly understand what's going on:

``` ruby
# No index action, because we don't want to allow users to browse posts as a list.
resources :posts, only: [] do
  # ...
end
```


No.

> The URL template supplied when registering must be of the same domain as the webpage attempting to perform the registration or the registration will fail. For example, http://example.com/homepage.html can register a protocol handler for http://example.com/handle_mailto/%s, but not for http://example.org/handle_mailto/%s.


It is probably debatable which of these is more clear to begin with.  But considering the arguments are exactly the same I think you are correct, plus using `isTRUE` makes it a little safer as well!


86605826-AddTransformerLossToABUPS (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (637 of 637 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.19%25-green.svg)


الله يليك يا ريس @amrturk


*3. If it is possible to cut a word out, always cut it out.* --George Orwell [[0]](http://en.wikipedia.org/wiki/Politics_and_the_English_Language)

:-D


:clap:


according to our codestyle bracket closing should be on the same line as last contents. (We actually had a big dispute over this and I lost :))


Indeed, I don't know why I didn't even see that with all the time I looked at it


86605826-AddTransformerLossToABUPS (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1651 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


maybe `ErrorCodeMiddlewareConfigurationInvalid` ?


Naïve question, perhaps, but something on which I haven't been entirely clear before: why shouldn't every string literal in the entire codebase get a prefix of "b" or "u"?


The SSHSession just has its network connection closed when the qemu machine is destroyed at the end of the test. (sshClient is closed) Presumably s.Run() will return at that point with an IO error and close the session.

Should I add a StopJournal() function?


Semi-intentional. You should now use the `addSource` and `addLayer` methods instead of loading style JSON via AJAX and modifying it before passing it into the map. [Updated example.](https://www.mapbox.com/mapbox-gl-js/example/geojson-line/)


Eek, sorry for the "more-or-less" mass rebuild, should have pushed it to staging instead :unamused:


Ah, I *think* the `kind2scope` settings in Tagbar are just for display purposes, it's the `kinds` array that actually needs to match the ctags output (e.g. `C:cclasses`, so there's no question there, though the ctags config we distribute again probably needs updates to match).


FYI, when using `auth`, I see duplicate requests (e.g. account creation) where the authorization header isn't set (triggering a 401). Specifying explicitly the header below (`Authorization: XXX`) fixes the issue.

Not sure if it's related to my setup but I wanted to share it in case you see lots of 401 requests in your logs.


If ~~it is~~ **it's** possible to cut a word ~~out~~, always cut it ~~out~~. --George Orwell's smartass editor :)


I don't see why you need to define that contents three times if you only strip away some. Then we also can reduce this test to one loop where you just invoke the test functions a few times.


Just a few commits ago we did a try-except on a string with a .encode('utf-8') call inside the try. Why isn't that the right thing to do here? Or given that this appears to be making a 2-versus-3 distinction, why isn't using sys to ask the interpreter what version of Python it is running the right thing to do?


need to roll this back, should have been changed in travis-de not master


It should be the same, but note it is in decimal here (json limitation) but Hex everywhere else (USB convention).
I would put a comment here but can't (json limitation).

So for docs see the FakeDevice class:

        static final int VID = 0x9101;  // Google VID.
        static final int PID = 0x2001;  // Reserved for non-production uses.


HotFix-EvapCoolerFlowRate (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yup, thanks, that makes sense. I'll put off this part of this feature (ie. the marker drawing at timestamp) until we have some sort of annotation drawing capability. In the meantime I'll update this pull request just to commit the first part of the change once I address all your other comments.


Would be good if this also reloaded the currently viewed page which I guess will be the most common workflow. This does not work for me on OSX/Chrome.


GridViewBugFixes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


since you use this loop several times, you may want to put it into a function.


s/shorcut/shortcut


THERE IT IS


hi @fmbiete,
not sure, if the new folder already exists but we are not subscribded to it, this might help us


Hah!


This repo is public, I think even now u can make any changes to it.


:+1: Thanks


Btw, can it be compiled using master already or you still need to push some changes?


Ah. Missed that. Would it clear things up if we separate out that use case from this constructor?


@johnellison, would be happy to hop on and code together.

```$(DOMElement).click function() {
   // this refers to the DOMElement that was clicked
  sendMove( this ) // passes the DOMElement as an arg to function sendMove so that data can be extracted
});```

What is your thought for the deselectPiece function?  lines 34-36 do that.  We could wrap them in a function so that they can be called again after sendMove has sent the AJAX call.

I'd be happy to work on refactoring the js code or take suggestions if you'd like to.  I think you mentioend Browserify which I've never used.


Good spot. Sounds like something that'd need a bug opened for and referenced here.

In most practical uses this isn't totally critical as the user will yank the USB cable when they're done which forces the connection to terminate anyway. This path would only be needed e.g. to allow quitting one USB-using app and opening another without re-plugging the device
also note if the JS app closes gracefully it will close the USB device anyway, in the closeDevice() method below


Err, I may have that backward, Tagbar's docs sound as if the `C:cclasses` in the `kinds` array is the part where `cclasses` can be changed arbitrarily for display. I'll try it with sctags' scoping support, it looks like we've nearly got it all straight now.


yep that would be easy to deal with.


delete dead code


Yes, it looks good. Although maybe drop `close` as it doesn't make much sense without a `sock` argument?
I'm also wondering if localhost handling should be special cased into its own function? It is a bit conflicting to specify both an address, and a localhost boolean.


@jfirebaugh Thanks for the response. We've actually folded the styles into our build process so we aren't doing it via AJAX. It seems that one should be able to define the source/style together before initializing the map? I think I saw that somewhere else. Is that supported?


That goes only for make_unique


we did talk about these kinds of comments describing what one can read just in the code, did we?


esto tiene que validar que la respuesta sea 401.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/973
success: http://build.servo.org/builders/linux2/builds/972
success: http://build.servo.org/builders/android/builds/1008
success: http://build.servo.org/builders/mac1/builds/1188
success: http://build.servo.org/builders/mac2/builds/1189
success: http://build.servo.org/builders/gonk/builds/159


Wow, thank you! As you can see, I tried to fix this but it didn't work. Looks like I forgot about collections. I assume you tested this? if so I can merge it right away. Otherwise I can test it when I get home tonight.


`interface` is a bit of an odd naming (although we do already use that in Xvnc). `node` that `getaddrinfo()` uses isn't very standard either. Would `address` or `host` be too confusing?


Hang over from the module I copied and pasted from.


no +1


yeah, I'd use a generator here too, makes it even easier since you don't have to create a list here.


There should be a docs.eao.hawaii.edu address, and everything should be in the same place underneath that. It doesn't seem to be available right now (at least not on the EAO wifi), but I'm assuming that's due to the server work.

I can't access the old website either right now, but it'll be back up later. Do you want anything moved across from www.jach.hawaii.edu/JCMT/continuum/scuba2/filter/? If its a hassle for you to see the old website from the UK let me know and I can stuff across for you.


I'm not positive I'm following. Are you suggesting a multiple lines option but the ability to instead do something like.

````js
/*
TODO: Clean this up.
TODO: Make it not terrible
*/
````
That sounds pretty good to me.


This looks very good!


sorry for bad english..there may be an exstra double quotes


I like the way it behaves currently, but that's a personal opinion at the end. Make it an option?


Why isn't `getType()` abstract as well?


Maybe `INITIAL_BATTERY_LEVEL`?


fast-forwarding master to auto = 7cd776b7


:+1: looking good thx for making the changes


Err, I must've confused you a bit, sorry for that. This might cause weird bugs because the GStreamer people apparently didn't find simple `GObject` to be good enough for them or maybe `GInitiallyUnowned` didn't exist back then or maybe they just hadn't heard of it... so they made a `GstObject` and you might or might not be required to only use `gst_*` functions on those. So this probably should be `gst_object_ref_sink`.


I know that this is a backslash character...


okay :P


But then checkins is a bit more complicated, I wanted to make it as easy as possible.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: js/voice_commands.js


Hey, I never said I was sensible :-)

Thanks Soumith.  Sorry again.


I'll try^^


Oh, that sounds like a good idea. I had wondered a little why the defaults were different from those in dimmconfig.lis. :)


Yep. Fully tested. I thought I might as well send you the fix since I am using your plugin on my server


Remove unnecessary import of main file or rework manifest to avoid CSS duplication


I didn't remember this in earlier passes, but what about returning a list of authtuples
 [ { create_in_container, policies},  {object, AuthzId} ]

And return a 404 if the named object doesn't exist?


`max_matches = 0` is default for this parameter, so this is covered from `test_search_for()`.


526 columns... ogodwhy


Just a short question is the file deleted in your case or does it stay on hdd?


And if the match has one char where should be a problem? Even if it has no chars then I need to test agains an empty string. If you want I make test cases for them, but in my opinion there's no need for^^


I like the idea of removing the redundancy, but I think this change ends up hurting readability too much.  I am ok with a little redundancy if it is easier to read.

Changing the anonymous function bodies to use `structure` totally makes sense though. e.g. 44-45 to

```r
structure(paste0("^", xx), class = class(xx))
```


Yeah, I just now saw that it does that. I'm working on the WM stuff now, what's here now is just enough to trick the compiler into not complaining, but the functionality is totally broken.


not also no test?


Spooner!


history


are you sure?
The functions from `re` don't do it, so I thought I do it like them^^


yeah yeah, I'll strip them...


你应该是对的。我当时就是直接copy的post的simplesigma的东西。给发个patch fix这个吧。


Errm.


Created it in #161


you should hintTag (yes). What I'm saying is you can hintStaticallyElided too.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 235](http://192.168.30.225:8111/viewLog.html?buildId=900&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


代替这个time吗？time这个是likes object的一个field啊表示like这个动作什么时候发生的。


yeah.  I think we may already have something like that in there. If not, we probably should.


Yeah thank me *cough* xD
But that makes it clear why I define it^^ (if I remove `The backslash character.` the rest of the sentence makes not much sense :O)


Previous comments: https://github.com/FreeBSDFoundation/freebsd/commit/160e5ad9743e301614a4c334b194eddfeff2b9ef


job well done!


Looks good.


you mean `re` functions return a list? But in this case a generator makes totally sense IMO.


The test covers that. If I would add +1 here the first chars from the return would be missing^^


The default string types are unicode in Python3, so there would be no need to add the `u` prefix if it wasn't needed before.

I added the `b` prefix where the tests were checking certain portions of a Bytes stream, which would be bytes versus a unicode string.


sbt server can pickle protocol.ModuleID but not actual ModuleID. with this we could remove the "protocol converter" for ModuleID. (but we still need protocol.ModuleID on the client side)


algo


added in case it would signal onComplete instead of onError, but it doesn't as well.


Hi,
Some directories are mandatory, and if you don't send them to the client (for exemple an android client), it is stuck. So if an user remove one of these directories, i prefer to recreate it automatically instead of having a call to our helpdesk ...
They should exists, but on some servers it's not the case (they can be in local language ...)
This patch is a bit extreme but it work(tm).
Also i could check if the directory already exists before creating it, but it's one more call to the server for the same result.


good.


Awesome! All of these need a space after `option.`.


Remove Console.Write...


Sounds good. I'm in this hangout: https://plus.google.com/hangouts/_/g2dktwp3moajsyk6kijr72ye3ia


Previous comments: https://github.com/FreeBSDFoundation/freebsd/commit/9e9366b9a9c7ebc3be839a865189b0f18eaff269


Anything is better than an `Exception` - ISE seemed reasonable, but happy to change to something else


@ajvb Is an HTTP response being thrown away there, too?


Basically, yes. For example, if we upload a client record, we know its local numeric ID. If we get a 404, or some other conflict marker, we need to delete the local record, and we need to do so via the numeric ID.

Server records, by contrast, don't have numeric IDs, nor do they have a client last modified time. And so on.

There's probably some cleanup we can do here once things stabilize.


That's exactly how I felt. Will change in a sec.


Previous comments: https://github.com/FreeBSDFoundation/freebsd/commit/7251df25ad155a4f304ae0cc03971f57f147863e


c'est very subtle ahah


No hard line break needed before this line.


I'll fix this, thanks for your feedback


Can the $default_*_db_id variable used here be the global variables defined in lines 11-12 instead, do we need both?


We have not been able to interface with the camera because it needs to be plugged into the d-link (which is bagged with the robot), hence the code being untested.


No hard break needed before this line.


No hard break before this line.


okay, I turn the functions into generators.


@adam3smith : Is this really what they want? The example look a little strange here https://www.zotero.org/styles/?q=zib and they have for example two "in"s...


...this password is used...

Use present tense rather than past tense whenever possible.


Please make tutorial on the eelbot
Prosze zrób, poradnik o eelbocie


@bors: retry


No hard line break.


This is only the frame. Code and configurations have not been added yet.


a match with one and a match with 0 chars is a corner case thus a potential bug and important to test IMO.


inlantuie metodele unde e cazul, plus aliniaza metodele inlantuite, arata mai aranjat


Yes, I commited my secrets to the internet.

No, those secrets aren't valid anymore.


Ah ha, that's where we wanted the loop.


... this autorequires the specified file...


'true'


oh man.. this is really bad (imho)..


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 235](http://192.168.30.225:8111/viewLog.html?buildId=900&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 41 Build time: 00:09:13
### Failed tests
```
ru.biocad.ybackend.api.model.dao.DataDaoTest.Data should select data by params and project id: class org.h2.jdbc.JdbcSQLException: Ambiguous column name "NAME"; SQL statement:
select data.id as i_on_data, data.project as p_on_data, data.name as n_on_data, data.filetype as f_on_data, data.datatype as d1_on_data, data.created as c1_on_data, data.creation_time as ct_on_data, data.modified as m_on_data, data.modification_time as mt_on_data, data.datasource as d2_on_data, data.external_id as ei_on_data, data.comment as c2_on_data, data.access_project as ap_on_data, data.access_all as aa_on_data, data.deleted as d3_on_data , dt.id as i_on_dt, dt.data as d_on_dt, dt.tag as t_on_dt , tg.id as i_on_tg, tg.name as n_on_tg , filetype.id as i_on_filetype, filetype.name as n_on_filetype , dtype.id as i_on_dtype, dtype.name as n_on_dtype , ds.id as i_on_ds, ds.user_id as ui_on_ds, ds.task_id as ti_on_ds , u.id as i_on_u, u.login as l1_on_u, u.firstname as f_on_u, u.middlename as m_on_u, u.lastname as l2_on_u, u.email as e_on_u from data.data left join data.data_tag dt on  data.id = dt.data left join data.tag tg on  dt.tag = tg.id left join meta.filetypes filetype on  filetype = filetype.id left join meta.datatypes dtype on  data.datatype = dtype.id left join meta.datasources ds on  data.datasource = ds.id left join users.users u on  data.created = u.id  where  data.datatype = ? and  data.project = ? and  name like ?  [90059-185]
org.h2.jdbc.JdbcSQLException: Ambiguous column name "NAME"; SQL statement:
select data.id as i_on_data, data.project as p_on_data, data.name as n_on_data, data.filetype as f_on_data, data.datatype as d1_on_data, data.created as c1_on_data, data.creation_time as ct_on_data, data.modified as m_on_data, data.modification_time as mt_on_data, data.datasource as d2_on_data, data.external_id as ei_on_data, data.comment as c2_on_data, data.access_project as ap_on_data, data.access_all as aa_on_data, data.deleted as d3_on_data , dt.id as i_on_dt, dt.data as d_on_dt, dt.tag as t_on_dt , tg.id as i_on_tg, tg.name as n_on_tg , filetype.id as i_on_filetype, filetype.name as n_on_filetype , dtype.id as i_on_dtype, dtype.name as n_on_dtype , ds.id as i_on_ds, ds.user_id as ui_on_ds, ds.task_id as ti_on_ds , u.id as i_on_u, u.login as l1_on_u, u.firstname as f_on_u, u.middlename as m_on_u, u.lastname as l2_on_u, u.email as e_on_u from data.data left join data.data_tag dt on  data.id = dt.data left join data.tag tg on  dt.tag = tg.id left join meta.filetypes filetype on  filetype = filetype.id left join meta.datatypes dtype on  data.datatype = dtype.id left join meta.datasources ds on  data.datasource = ds.id left join users.users u on  data.created = u.id  where  data.datatype = ? and  data.project = ? and  name like ?  [90059-185]
      at org.h2.message.DbException.getJdbcSQLException(DbException.java:345)

```


this way if the user doesn't need all results we'll save a bit
performance...

2015-03-09 20:26 GMT+01:00 Makman2 <notifications@github.com>:

> okay, I turn the functions into generators.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/2db2fb47c1f6e516e596385932c2ae2b2d5ecd8d#commitcomment-10106878>
> .
>


Nice!


DeliveryBoardItemFactory.cs is updated to handle null values from database. All other files are not relevant.


thanks!


Это не совсем правильно, потому что List мб и пустым. Хотя сначала она у вас точно не пустая, но потом ведб мб удаление.


use post_params method


modifica wait time inapoi in 30, pentru ca 5 poate fi prea scurt. in cazul in care  site-ul raspunde greu si ai lag o sa cada testele


The second clause isn't clear to me. I'm not sure what is meant by "accomplish the same alias." Propagate, maybe? Also, I'm not really sure what it's doing; is there some more direct way of expressing this?


commiting test


Set to nullptr?


hmmm, I have been using this since forever on EC2 ... have not noticed any 401s but thanks for the heads-up!


Мне кажется, не разумно задавать избыточные данные и потом их проверять. Лучше сразу задавать мнимиум данных -  скажем, вершину, длину и ширину.


All URLs they have in their sample citations are preceded by ", in:" yes.


Yeah, just create a new class and name it `SystemInformation` or something. Also, it *kinda* but not really fits in `ProductInformation`


Thanks for doing this - looks good to me.


please add a list with the changes you have introduces with each new version on the wiki: https://wiki.jenkins-ci.org/display/JENKINS/HipChat+Plugin
...without this users will have a very hard time to find out what has changed and why they should upgrade.


Тут virtual писать не обязательно (а по новому стандарту лучше override)


No, i think its old code that was denied at main line, as was found to be useless. I remember i tried to use it in sg2 kernel, and after some time removed, as no one seen any change... its was messing with code update at that time...


0x9101 is what I see for the vendorId (37121); I'm just not sure what the 6353 (0x18d1) is in this line.


И тут тоже замечание что и про Rectangle


why are this indexes remoed @benniboy - accident? at least order save fails because of this.


Hmm I think it's better if you have a look, I'm not sure what the right implementation approach would be, here.


`ptid.validTid() ? ptid.tid : ptid.pid`

This pattern looks common enough to deserve a member function.


Done.


I'd start with the more active "Manages Java keystores...", but also, I'm not sure what is meant by binaries. Also needs a period.


Я бы предполоил, что тут имеет смысл вызвать Rhomb::draw(). Вы же хотите тут напрсовать ромб?


This looks unnecessary.


@jtappa I see that this got merged before the copyedit was done, so I've made some more notes. Just do a new PR after these are fixed, and please let me know if you have any questions.


Это скорее уж метод point, и length тоже


@juanpastas Why is necessary to use `to_a.uniq` ?


It seems `_breakpointManager` should be marked `mutable`.


@schme16 Maybe it should be an option, no ? Just an idea. :smile:


Work in progress :)


Minor comment that is not clear from your commit message or code comments:
Why do you think it is important to have all simulators in the same file? General programming advice is to keep files as short as possible and this one will only grow as more simulators are added. I agree that with only two simulators it may not have been warranted to split them into two files from the beginning, but why spend time to merge them into a single file again?


I'd prefer not to; the resulting code is less readable, in my opinion.  Also, `ed25519_order` is already of type `uint256`, and even if it weren't, `uint256` is required by `RippleAddress` itself.


The try-except was for handling `bytes` vs `str` objects.  In this case they are both unicode strings, but the interpreters present them differently for some reason.  I've changed the test to just check what version of Python is in use.


You wrote `authorize @topic.destroy`, when you actually wanted `authorize @topic`.


Unused?


Лучше просто
  Rhomb r(параметры...);
(см http://msimuni.wikidot.com/cpp-typical#simple_creation)


Line 30 and 33 as well


You didn't assigned a string to the error:

``` ruby
flash[:error] = "There was an error deleting the topic." # for instance
```


opps! yes this should be VID = 0x18d1. (9101 was PID of a different product I was dealing with and I obviously got mixed up here)

This also highlights that the actual VID/PID in the manifest.json are spurious for the FakeDevice test cases (the fake device will appear regardless of what values are put in the manifest). I don't think there's a lot of benefit in fixing that (for real devices, the access is controlled by android OS).


when an exception is catched here, it's possible there is data in the output buffer,
so i'm cleaning it, but i'm not closing it, so i can set the Content-Length of the error message, and remove the content-type if it's not needed.

I can move all ob_end_flush stuff to the end (will rework that, thanks)


Love it!


:100: :+1:


Thanks!


Published to http://ui.edev.d2l.com/51_214b6749ad54765ece0b30c945f2f85be2cf17a8


Set Specialization work now ?


Why you are using ruby 1.9.3 ?


que


Quoting the property names makes this test pass:

```js
var NumericEnum = {
    '0': 'Zero',
    '1': 'One'
};
```


How about:
```
A field name may not contain percent (%), period (.) or underscore (_) characters.
```


It looks like we need to disable dirty region handling for now... See e09d578d207afe6bd414f4fb9aac2d04b0f65116


HotFix-EvapCoolerFlowRate (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Both modes need to be possible with a release build