1: D100 Missing docstring in public module
20:1: E402 module level import not at top of file
21:1: I201 Missing newline before sections or imports.
21:1: E402 module level import not at top of file
22:1: I100 Imports statements are in the wrong order. import urllib should be before import MySQLdb
22:1: I201 Missing newline before sections or imports.
22:1: E402 module level import not at top of file
24:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from six
26:1: E402 module level import not at top of file
27:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_CERN_SITE, CFG_SITE_ADMIN_EMAIL, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_VERSION
27:1: E402 module level import not at top of file
28:6: E126 continuation line over-indented for hanging indent
36:1: E402 module level import not at top of file
37:1: I101 Imported names are in the wrong order. Should be CFG_EXTERNAL_AUTHENTICATION, CFG_EXTERNAL_AUTH_DEFAULT, SUPERADMINROLE
37:1: E402 module level import not at top of file
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.modules.access.local_config
39:1: E402 module level import not at top of file
40:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, get_user_preferences
40:1: E402 module level import not at top of file
41:9: E126 continuation line over-indented for hanging indent
42:1: E402 module level import not at top of file
43:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.modules.access.control
43:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
48:1: E402 module level import not at top of file
50:1: E302 expected 2 blank lines, found 1
50: D400 First line should end with a period (not 'e')
56:13: E126 continuation line over-indented for hanging indent
56:15: E251 unexpected spaces around keyword / parameter equals
56:17: E251 unexpected spaces around keyword / parameter equals
57:16: E251 unexpected spaces around keyword / parameter equals
57:18: E251 unexpected spaces around keyword / parameter equals
58:18: E251 unexpected spaces around keyword / parameter equals
58:20: E251 unexpected spaces around keyword / parameter equals
59:26: E251 unexpected spaces around keyword / parameter equals
59:28: E251 unexpected spaces around keyword / parameter equals
60:12: E126 continuation line over-indented for hanging indent
62:1: E302 expected 2 blank lines, found 1
64:5: F841 local variable '_' is assigned to but never used
71:44: E713 test for membership should be 'not in'
77:1: E302 expected 2 blank lines, found 1
77: D209 Multi-line docstring closing quotes should be on a separate line
77: D400 First line should end with a period (not 'e')
77: D205 1 blank line required between summary line and description (found 0)
77: D208 Docstring is over-indented
98:14: E126 continuation line over-indented for hanging indent
98:16: E251 unexpected spaces around keyword / parameter equals
98:18: E251 unexpected spaces around keyword / parameter equals
99:17: E251 unexpected spaces around keyword / parameter equals
99:19: E251 unexpected spaces around keyword / parameter equals
100:19: E251 unexpected spaces around keyword / parameter equals
100:21: E251 unexpected spaces around keyword / parameter equals
101:19: E251 unexpected spaces around keyword / parameter equals
101:21: E251 unexpected spaces around keyword / parameter equals
102:24: E251 unexpected spaces around keyword / parameter equals
102:26: E251 unexpected spaces around keyword / parameter equals
103:12: E126 continuation line over-indented for hanging indent
105:1: E302 expected 2 blank lines, found 1
105: D202 No blank lines allowed after function docstring (found 1)
121:13: E225 missing whitespace around operator
121:18: E225 missing whitespace around operator
121:23: E225 missing whitespace around operator
121:32: E225 missing whitespace around operator
126:13: E225 missing whitespace around operator
130:21: E126 continuation line over-indented for hanging indent
130:23: E251 unexpected spaces around keyword / parameter equals
130:25: E251 unexpected spaces around keyword / parameter equals
131:25: E251 unexpected spaces around keyword / parameter equals
131:27: E251 unexpected spaces around keyword / parameter equals
132:19: E126 continuation line over-indented for hanging indent
157:14: E126 continuation line over-indented for hanging indent
157:16: E251 unexpected spaces around keyword / parameter equals
157:18: E251 unexpected spaces around keyword / parameter equals
158:22: E251 unexpected spaces around keyword / parameter equals
158:24: E251 unexpected spaces around keyword / parameter equals
159:26: E251 unexpected spaces around keyword / parameter equals
159:28: E251 unexpected spaces around keyword / parameter equals
160:21: E251 unexpected spaces around keyword / parameter equals
160:23: E251 unexpected spaces around keyword / parameter equals
161:21: E251 unexpected spaces around keyword / parameter equals
161:23: E251 unexpected spaces around keyword / parameter equals
162:20: E251 unexpected spaces around keyword / parameter equals
162:22: E251 unexpected spaces around keyword / parameter equals
163:22: E251 unexpected spaces around keyword / parameter equals
163:24: E251 unexpected spaces around keyword / parameter equals
164:22: E251 unexpected spaces around keyword / parameter equals
164:24: E251 unexpected spaces around keyword / parameter equals
165:19: E251 unexpected spaces around keyword / parameter equals
165:21: E251 unexpected spaces around keyword / parameter equals
166:20: E251 unexpected spaces around keyword / parameter equals
166:22: E251 unexpected spaces around keyword / parameter equals
167:25: E251 unexpected spaces around keyword / parameter equals
167:27: E251 unexpected spaces around keyword / parameter equals
168:23: E251 unexpected spaces around keyword / parameter equals
168:25: E251 unexpected spaces around keyword / parameter equals
169:21: E251 unexpected spaces around keyword / parameter equals
169:23: E251 unexpected spaces around keyword / parameter equals
170:28: E251 unexpected spaces around keyword / parameter equals
170:30: E251 unexpected spaces around keyword / parameter equals
171:22: E251 unexpected spaces around keyword / parameter equals
171:24: E251 unexpected spaces around keyword / parameter equals
172:12: E126 continuation line over-indented for hanging indent
174:1: E302 expected 2 blank lines, found 1
174: D400 First line should end with a period (not 't')
180:37: E251 unexpected spaces around keyword / parameter equals
180:39: E251 unexpected spaces around keyword / parameter equals
180:31: E211 whitespace before '('
181:37: E251 unexpected spaces around keyword / parameter equals
181:39: E251 unexpected spaces around keyword / parameter equals
182:39: E251 unexpected spaces around keyword / parameter equals
182:41: E251 unexpected spaces around keyword / parameter equals
183:35: E251 unexpected spaces around keyword / parameter equals
183:37: E251 unexpected spaces around keyword / parameter equals
186:5: B901 blind except: statement
191:37: E251 unexpected spaces around keyword / parameter equals
191:39: E251 unexpected spaces around keyword / parameter equals
191:31: E211 whitespace before '('
192:37: E251 unexpected spaces around keyword / parameter equals
192:39: E251 unexpected spaces around keyword / parameter equals
193:39: E251 unexpected spaces around keyword / parameter equals
193:41: E251 unexpected spaces around keyword / parameter equals
194:35: E251 unexpected spaces around keyword / parameter equals
194:37: E251 unexpected spaces around keyword / parameter equals
195:19: E211 whitespace before '('
197:5: B901 blind except: statement
230:13: B901 blind except: statement
248:5: B901 blind except: statement
253:1: E302 expected 2 blank lines, found 1
256:14: E126 continuation line over-indented for hanging indent
256:16: E251 unexpected spaces around keyword / parameter equals
256:18: E251 unexpected spaces around keyword / parameter equals
257:19: E251 unexpected spaces around keyword / parameter equals
257:21: E251 unexpected spaces around keyword / parameter equals
258:18: E251 unexpected spaces around keyword / parameter equals
258:20: E251 unexpected spaces around keyword / parameter equals
259:12: E126 continuation line over-indented for hanging indent
261:1: E302 expected 2 blank lines, found 1
261: D202 No blank lines allowed after function docstring (found 1)
265:5: F841 local variable '_' is assigned to but never used
268:14: E126 continuation line over-indented for hanging indent
268:16: E251 unexpected spaces around keyword / parameter equals
268:18: E251 unexpected spaces around keyword / parameter equals
269:18: E251 unexpected spaces around keyword / parameter equals
269:20: E251 unexpected spaces around keyword / parameter equals
270:12: E126 continuation line over-indented for hanging indent
276:55: E251 unexpected spaces around keyword / parameter equals
276:57: E251 unexpected spaces around keyword / parameter equals
278:1: E302 expected 2 blank lines, found 1
278: D202 No blank lines allowed after function docstring (found 1)
278: D400 First line should end with a period (not 'd')
278: D205 1 blank line required between summary line and description (found 0)
299:14: E126 continuation line over-indented for hanging indent
299:16: E251 unexpected spaces around keyword / parameter equals
299:18: E251 unexpected spaces around keyword / parameter equals
300:19: E251 unexpected spaces around keyword / parameter equals
300:21: E251 unexpected spaces around keyword / parameter equals
301:28: E251 unexpected spaces around keyword / parameter equals
301:30: E251 unexpected spaces around keyword / parameter equals
302:31: E251 unexpected spaces around keyword / parameter equals
302:33: E251 unexpected spaces around keyword / parameter equals
303:22: E251 unexpected spaces around keyword / parameter equals
303:24: E251 unexpected spaces around keyword / parameter equals
304:24: E251 unexpected spaces around keyword / parameter equals
304:26: E251 unexpected spaces around keyword / parameter equals
305:12: E126 continuation line over-indented for hanging indent
311:17: E126 continuation line over-indented for hanging indent
311:19: E251 unexpected spaces around keyword / parameter equals
311:21: E251 unexpected spaces around keyword / parameter equals
312:24: E251 unexpected spaces around keyword / parameter equals
312:26: E251 unexpected spaces around keyword / parameter equals
313:31: E251 unexpected spaces around keyword / parameter equals
313:33: E251 unexpected spaces around keyword / parameter equals
314:29: E251 unexpected spaces around keyword / parameter equals
314:31: E251 unexpected spaces around keyword / parameter equals
315:27: E251 unexpected spaces around keyword / parameter equals
315:29: E251 unexpected spaces around keyword / parameter equals
320:17: E126 continuation line over-indented for hanging indent
320:19: E251 unexpected spaces around keyword / parameter equals
320:21: E251 unexpected spaces around keyword / parameter equals
321:31: E251 unexpected spaces around keyword / parameter equals
321:33: E251 unexpected spaces around keyword / parameter equals
322:27: E251 unexpected spaces around keyword / parameter equals
322:29: E251 unexpected spaces around keyword / parameter equals
326:8: E225 missing whitespace around operator
327:17: E126 continuation line over-indented for hanging indent
327:19: E251 unexpected spaces around keyword / parameter equals
327:21: E251 unexpected spaces around keyword / parameter equals
328:26: E251 unexpected spaces around keyword / parameter equals
328:28: E251 unexpected spaces around keyword / parameter equals
329:27: E251 unexpected spaces around keyword / parameter equals
329:29: E251 unexpected spaces around keyword / parameter equals
352:1: E302 expected 2 blank lines, found 1
355:14: E126 continuation line over-indented for hanging indent
355:21: E251 unexpected spaces around keyword / parameter equals
355:23: E251 unexpected spaces around keyword / parameter equals
356:16: E251 unexpected spaces around keyword / parameter equals
356:18: E251 unexpected spaces around keyword / parameter equals
357:19: E251 unexpected spaces around keyword / parameter equals
357:21: E251 unexpected spaces around keyword / parameter equals
358:12: E126 continuation line over-indented for hanging indent
361:1: E302 expected 2 blank lines, found 1
361: D103 Missing docstring in public function
388:5: E266 too many leading '#' for block comment
393:14: E126 continuation line over-indented for hanging indent
393:16: E251 unexpected spaces around keyword / parameter equals
393:18: E251 unexpected spaces around keyword / parameter equals
394:21: E251 unexpected spaces around keyword / parameter equals
394:23: E251 unexpected spaces around keyword / parameter equals
395:22: E251 unexpected spaces around keyword / parameter equals
395:24: E251 unexpected spaces around keyword / parameter equals
396:32: E251 unexpected spaces around keyword / parameter equals
396:34: E251 unexpected spaces around keyword / parameter equals
397:21: E251 unexpected spaces around keyword / parameter equals
397:23: E251 unexpected spaces around keyword / parameter equals
398:29: E251 unexpected spaces around keyword / parameter equals
398:31: E251 unexpected spaces around keyword / parameter equals
399:17: E251 unexpected spaces around keyword / parameter equals
399:19: E251 unexpected spaces around keyword / parameter equals
400:12: E126 continuation line over-indented for hanging indent
404: D103 Missing docstring in public function
405:55: E251 unexpected spaces around keyword / parameter equals
405:57: E251 unexpected spaces around keyword / parameter equals
408:1: E302 expected 2 blank lines, found 1
408: D103 Missing docstring in public function
412:1: E302 expected 2 blank lines, found 1
412: D103 Missing docstring in public function
416:1: E302 expected 2 blank lines, found 1
416: D103 Missing docstring in public function
417:58: E251 unexpected spaces around keyword / parameter equals
417:60: E251 unexpected spaces around keyword / parameter equals
417:70: E251 unexpected spaces around keyword / parameter equals
417:72: E251 unexpected spaces around keyword / parameter equals
420:1: E302 expected 2 blank lines, found 1
420: D103 Missing docstring in public function
421:59: E201 whitespace after '('
421:62: E251 unexpected spaces around keyword / parameter equals
421:64: E251 unexpected spaces around keyword / parameter equals
422:44: E128 continuation line under-indented for visual indent
422:47: E251 unexpected spaces around keyword / parameter equals
422:49: E251 unexpected spaces around keyword / parameter equals
423:42: E124 closing bracket does not match visual indentation
426:1: E302 expected 2 blank lines, found 1
426: D103 Missing docstring in public function
428:14: E126 continuation line over-indented for hanging indent
428:16: E251 unexpected spaces around keyword / parameter equals
428:18: E251 unexpected spaces around keyword / parameter equals
429:21: E251 unexpected spaces around keyword / parameter equals
429:23: E251 unexpected spaces around keyword / parameter equals
430:17: E251 unexpected spaces around keyword / parameter equals
430:19: E251 unexpected spaces around keyword / parameter equals
431:18: E251 unexpected spaces around keyword / parameter equals
431:20: E251 unexpected spaces around keyword / parameter equals
432:12: E126 continuation line over-indented for hanging indent
434:1: E302 expected 2 blank lines, found 1
434: D401 First line should be in imperative mood ('Return', not 'Returns')


1: D400 First line should end with a period (not 'G')
26:6: E126 continuation line over-indented for hanging indent
34:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
41:1: I100 Imports statements are in the wrong order. from invenio.modules should be before from invenio.utils.url
43:1: I101 Imported names are in the wrong order. Should be InvenioWebAccessMailCookieDeletedError, InvenioWebAccessMailCookieError, mail_cookie_check_mail_activation, mail_cookie_check_pw_reset, mail_cookie_check_role, mail_cookie_create_pw_reset, mail_cookie_delete_cookie, mail_cookie_retrieve_kind
43:1: F401 'mail_cookie_check_pw_reset' imported but unused
43:1: F401 'mail_cookie_delete_cookie' imported but unused
49:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.access.mailcookie
54: D101 Missing docstring in public class
63: D102 Missing docstring in public method
66: D102 Missing docstring in public method
67:48: E203 whitespace before ':'
81:17: E128 continuation line under-indented for visual indent
83:21: E128 continuation line under-indented for visual indent
84:21: E128 continuation line under-indented for visual indent
85:30: E203 whitespace before ':'
86:36: E203 whitespace before ':'
88:17: E122 continuation line missing indentation or outdented
89:17: E122 continuation line missing indentation or outdented
90:17: E122 continuation line missing indentation or outdented
91:17: E122 continuation line missing indentation or outdented
92:17: E122 continuation line missing indentation or outdented
93:17: E122 continuation line missing indentation or outdented
101:25: E128 continuation line under-indented for visual indent
104:29: E128 continuation line under-indented for visual indent
107:127: E203 whitespace before ':'
107:197: E203 whitespace before ':'
109:21: E128 continuation line under-indented for visual indent
114:29: E128 continuation line under-indented for visual indent
116:127: E203 whitespace before ':'
116:197: E203 whitespace before ':'
118:25: E128 continuation line under-indented for visual indent
120:21: E128 continuation line under-indented for visual indent
121:21: E128 continuation line under-indented for visual indent
122:21: E128 continuation line under-indented for visual indent
125:17: E128 continuation line under-indented for visual indent
126:17: E128 continuation line under-indented for visual indent
128: D102 Missing docstring in public method
130:36: E126 continuation line over-indented for hanging indent
130:53: E203 whitespace before ':'
131:44: E203 whitespace before ':'
133:48: E203 whitespace before ':'
167: D102 Missing docstring in public method
168:45: E203 whitespace before ':'
197:27: E251 unexpected spaces around keyword / parameter equals
209:34: E251 unexpected spaces around keyword / parameter equals
209:36: E251 unexpected spaces around keyword / parameter equals
215:5: E303 too many blank lines (2)
215: D102 Missing docstring in public method
237:42: E251 unexpected spaces around keyword / parameter equals
237:44: E251 unexpected spaces around keyword / parameter equals
253:38: E251 unexpected spaces around keyword / parameter equals
253:40: E251 unexpected spaces around keyword / parameter equals
261:17: E128 continuation line under-indented for visual indent
262:17: E128 continuation line under-indented for visual indent
264:36: E231 missing whitespace after ','
272:38: E251 unexpected spaces around keyword / parameter equals
272:40: E251 unexpected spaces around keyword / parameter equals
281:34: E251 unexpected spaces around keyword / parameter equals
281:36: E251 unexpected spaces around keyword / parameter equals
286: D102 Missing docstring in public method
305:34: E251 unexpected spaces around keyword / parameter equals
305:36: E251 unexpected spaces around keyword / parameter equals
310: D102 Missing docstring in public method
328:34: E251 unexpected spaces around keyword / parameter equals
328:36: E251 unexpected spaces around keyword / parameter equals
334: D101 Missing docstring in public class
338: D102 Missing docstring in public method
342: D102 Missing docstring in public method
351: D102 Missing docstring in public method
353:70: E202 whitespace before '}'


1: D400 First line should end with a period (not 'd')
1: D205 1 blank line required between summary line and description (found 0)
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
36:1: F401 'urlparse' imported but unused
36:1: E402 module level import not at top of file
37:1: I100 Imports statements are in the wrong order. import socket should be before import urlparse
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. import smtplib should be before import socket
38:1: E402 module level import not at top of file
39:1: I100 Imports statements are in the wrong order. import re should be before import smtplib
39:1: E402 module level import not at top of file
40:1: I100 Imports statements are in the wrong order. import random should be before import re
40:1: F401 'random' imported but unused
40:1: E402 module level import not at top of file
41:1: I100 Imports statements are in the wrong order. import datetime should be before import random
41:1: E402 module level import not at top of file
43:1: F401 'Request' imported but unused
43:1: E402 module level import not at top of file
44:1: I201 Missing newline before sections or imports.
44:1: F401 'iteritems' imported but unused
44:1: E402 module level import not at top of file
45:1: I100 Imports statements are in the wrong order. from socket should be before from six
45:1: I201 Missing newline before sections or imports.
45:1: F401 'gaierror' imported but unused
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. import os should be before from socket
46:1: E402 module level import not at top of file
47:1: I100 Imports statements are in the wrong order. import binascii should be before import os
47:1: E402 module level import not at top of file
48:1: E402 module level import not at top of file
50:1: E402 module level import not at top of file
51:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_ACCESS_CONTROL_LEVEL_GUESTS, CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_ACCESS_CONTROL_LIMIT_REGISTRATION_TO_DOMAIN, CFG_ACCESS_CONTROL_NOTIFY_ADMIN_ABOUT_NEW_ACCOUNTS, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_NEW_ACCOUNT, CFG_BIBAUTHORID_ENABLED, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_SITE_ADMIN_EMAIL, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBSESSION_ADDRESS_ACTIVATION_EXPIRE_IN_DAYS
51:1: F401 'CFG_SITE_RECORD' imported but unused
51:1: F401 'CFG_BIBAUTHORID_ENABLED' imported but unused
51:1: F401 'CFG_INSPIRE_SITE' imported but unused
51:1: E402 module level import not at top of file
52:6: E126 continuation line over-indented for hanging indent
75:1: I101 Imported names are in the wrong order. Should be OperationalError, run_sql
75:1: E402 module level import not at top of file
76:1: E402 module level import not at top of file
79:1: I101 Imported names are in the wrong order. Should be gettext_set_language, wash_language, wash_languages
79:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.serializers
79:1: F401 'wash_language' imported but unused
79:1: F401 'wash_languages' imported but unused
79:1: E402 module level import not at top of file
80:1: E402 module level import not at top of file
81:1: E402 module level import not at top of file
82:1: E402 module level import not at top of file
83:1: F401 'get_groups' imported but unused
83:1: E402 module level import not at top of file
84:1: E402 module level import not at top of file
86:1: I100 Imports statements are in the wrong order. from invenio.legacy.websession.webuser_config should be before from invenio.modules.accounts.models
86:1: E402 module level import not at top of file
107:1: E303 too many blank lines (4)
117:1: E302 expected 2 blank lines, found 1
117: D400 First line should end with a period (not 's')
117: D208 Docstring is over-indented
133:1: E302 expected 2 blank lines, found 1
133: D202 No blank lines allowed after function docstring (found 1)
180:5: E303 too many blank lines (2)
196:1: E302 expected 2 blank lines, found 1
196: D205 1 blank line required between summary line and description (found 0)
196: D208 Docstring is over-indented
212:42: E701 multiple statements on one line (colon)
213:42: E701 multiple statements on one line (colon)
220:22: E261 at least two spaces before inline comment
250:1: I100 Imports statements are in the wrong order. from invenio.ext.login should be before from invenio.legacy.websession.webuser_config
250:1: E402 module level import not at top of file
251:1: F999 redefinition of unused 'getUid' from line 196
251:1: E731 do not assign a lambda expression, use a def
254: D200 One-line docstring should fit on one line with quotes (found 2)
263:1: E302 expected 2 blank lines, found 1
263: D200 One-line docstring should fit on one line with quotes (found 3)
269:1: E302 expected 2 blank lines, found 1
269: D200 One-line docstring should fit on one line with quotes (found 3)
275:1: E302 expected 2 blank lines, found 1
275:40: E251 unexpected spaces around keyword / parameter equals
275:42: E251 unexpected spaces around keyword / parameter equals
275: D205 1 blank line required between summary line and description (found 0)
282:1: E302 expected 2 blank lines, found 1
282: D200 One-line docstring should fit on one line with quotes (found 3)
288:1: E302 expected 2 blank lines, found 1
296:1: E302 expected 2 blank lines, found 1
296: D205 1 blank line required between summary line and description (found 0)
317:1: E302 expected 2 blank lines, found 1
317: D209 Multi-line docstring closing quotes should be on a separate line
317: D205 1 blank line required between summary line and description (found 0)
330:1: E302 expected 2 blank lines, found 1
330: D400 First line should end with a period (not 't')
330: D208 Docstring is over-indented
346:1: E302 expected 2 blank lines, found 1
352:1: E302 expected 2 blank lines, found 1
362:1: E302 expected 2 blank lines, found 1
367:1: E302 expected 2 blank lines, found 1
375:1: E302 expected 2 blank lines, found 1
375: D205 1 blank line required between summary line and description (found 0)
375: D208 Docstring is over-indented
390:1: E302 expected 2 blank lines, found 1
390: D205 1 blank line required between summary line and description (found 0)
390: D208 Docstring is over-indented
405:1: E302 expected 2 blank lines, found 1
405: D209 Multi-line docstring closing quotes should be on a separate line
405: D400 First line should end with a period (not 'e')
405: D205 1 blank line required between summary line and description (found 0)
424: D202 No blank lines allowed after function docstring (found 1)
424: D400 First line should end with a period (not 'd')
424: D205 1 blank line required between summary line and description (found 0)
424: D208 Docstring is over-indented
425:9: E128 continuation line under-indented for visual indent
469:18: E261 at least two spaces before inline comment
471:74: E261 at least two spaces before inline comment
475:26: E261 at least two spaces before inline comment
477:26: E261 at least two spaces before inline comment
488:13: B901 blind except: statement
507:5: B901 blind except: statement
510:23: E261 at least two spaces before inline comment
511:21: F821 undefined name 'uid'
514:1: E302 expected 2 blank lines, found 1
514: D400 First line should end with a period (not 'd')
514: D205 1 blank line required between summary line and description (found 0)
531:1: E302 expected 2 blank lines, found 1
537:1: E302 expected 2 blank lines, found 1
537: D401 First line should be in imperative mood ('Merge', not 'Merges')
537: D205 1 blank line required between summary line and description (found 0)
549:9: E266 too many leading '#' for block comment
550:9: E266 too many leading '#' for block comment
551:9: E266 too many leading '#' for block comment
555:9: E266 too many leading '#' for block comment
571:9: E266 too many leading '#' for block comment
576: D202 No blank lines allowed after function docstring (found 1)
576: D400 First line should end with a period (not 'r')
576: D205 1 blank line required between summary line and description (found 0)
592:1: E302 expected 2 blank lines, found 1
592: D202 No blank lines allowed after function docstring (found 1)
592: D400 First line should end with a period (not '1')
592: D200 One-line docstring should fit on one line with quotes (found 2)
604: D205 1 blank line required between summary line and description (found 0)
614:1: E302 expected 2 blank lines, found 1
628:1: E302 expected 2 blank lines, found 1
628: D209 Multi-line docstring closing quotes should be on a separate line
628: D400 First line should end with a period (not 'e')
628: D205 1 blank line required between summary line and description (found 0)
637:1: E302 expected 2 blank lines, found 1
637: D205 1 blank line required between summary line and description (found 0)
647:11: E127 continuation line over-indented for visual indent
658:9: E116 unexpected indentation (comment)
661:1: E302 expected 2 blank lines, found 1
661: D209 Multi-line docstring closing quotes should be on a separate line
661: D400 First line should end with a period (not 'e')
661: D205 1 blank line required between summary line and description (found 0)
670:1: E302 expected 2 blank lines, found 1
670: D209 Multi-line docstring closing quotes should be on a separate line
670: D205 1 blank line required between summary line and description (found 0)
682:1: E302 expected 2 blank lines, found 1
682: D202 No blank lines allowed after function docstring (found 1)
720:1: E302 expected 2 blank lines, found 1
720: D400 First line should end with a period (not ')')
720: D205 1 blank line required between summary line and description (found 0)
734:1: E302 expected 2 blank lines, found 1
734: D400 First line should end with a period (not ')')
734: D205 1 blank line required between summary line and description (found 0)
758:1: E302 expected 2 blank lines, found 1
758: D103 Missing docstring in public function
763:42: E261 at least two spaces before inline comment
765:1: E302 expected 2 blank lines, found 1
765: D103 Missing docstring in public function
771: D400 First line should end with a period (not 'y')
771: D205 1 blank line required between summary line and description (found 0)
808: D202 No blank lines allowed after function docstring (found 1)
831: D202 No blank lines allowed after function docstring (found 1)


26:1: E402 module level import not at top of file
27:1: F401 'time' imported but unused
27:1: E402 module level import not at top of file
29:1: F401 'iteritems' imported but unused
29:1: E402 module level import not at top of file
31:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_ACCESS_CONTROL_LEVEL_GUESTS, CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_ACCESS_CONTROL_LIMIT_REGISTRATION_TO_DOMAIN, CFG_ACCESS_CONTROL_NOTIFY_ADMIN_ABOUT_NEW_ACCOUNTS, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_ACTIVATION, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_DELETION, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_NEW_ACCOUNT, CFG_SITE_ADMIN_EMAIL, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
31:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. import invenio.modules.access.control should be before import invenio.modules.access.engine
46:1: E402 module level import not at top of file
47:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before import invenio.modules.access.control
47:1: E402 module level import not at top of file
48:1: I101 Imported names are in the wrong order. Should be addadminbox, addcheckboxes, createhiddenform, tupletotable, tupletotable_onlyselected
48:1: E402 module level import not at top of file
49:9: E126 continuation line over-indented for hanging indent
50:1: E402 module level import not at top of file
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.modules.access.firerole
52:1: E402 module level import not at top of file
53:1: I101 Imported names are in the wrong order. Should be OperationalError, run_sql, wash_table_column_name
53:1: E402 module level import not at top of file
54:1: E402 module level import not at top of file
55:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, page_not_authorized
55:1: F401 'collect_user_info' imported but unused
55:1: E402 module level import not at top of file
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.legacy.webuser
56:1: E402 module level import not at top of file
58:1: F401 'wash_url_argument' imported but unused
58:1: E402 module level import not at top of file
59:1: I101 Imported names are in the wrong order. Should be CFG_ACC_EMPTY_ROLE_DEFINITION_SRC, CFG_EXTERNAL_AUTHENTICATION, CFG_EXTERNAL_AUTH_DEFAULT, DELEGATEADDUSERROLE, MAXPAGEUSERS, MAXSELECTUSERS, SUPERADMINROLE, WEBACCESSACTION
59:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils.url
59:1: E402 module level import not at top of file
64:1: I100 Imports statements are in the wrong order. from invenio.modules.access.errors should be before from invenio.modules.access.local_config
64:1: E402 module level import not at top of file
65:1: I100 Imports statements are in the wrong order. from cgi should be before from invenio.modules.access.errors
65:1: I201 Missing newline before sections or imports.
65:1: E402 module level import not at top of file
67:1: E302 expected 2 blank lines, found 1
67: D209 Multi-line docstring closing quotes should be on a separate line
83:13: E122 continuation line missing indentation or outdented
84:13: E122 continuation line missing indentation or outdented
87:13: E122 continuation line missing indentation or outdented
88:13: E122 continuation line missing indentation or outdented
91:13: E122 continuation line missing indentation or outdented
92:13: E122 continuation line missing indentation or outdented
95:13: E122 continuation line missing indentation or outdented
96:13: E122 continuation line missing indentation or outdented
99:13: E122 continuation line missing indentation or outdented
100:13: E122 continuation line missing indentation or outdented
103:13: E122 continuation line missing indentation or outdented
104:13: E122 continuation line missing indentation or outdented
107:13: E122 continuation line missing indentation or outdented
108:13: E122 continuation line missing indentation or outdented
111:13: E122 continuation line missing indentation or outdented
112:13: E122 continuation line missing indentation or outdented
122:27: E701 multiple statements on one line (colon)
131:1: E302 expected 2 blank lines, found 1
131: D202 No blank lines allowed after function docstring (found 1)
139:9: E128 continuation line under-indented for visual indent
141:1: E302 expected 2 blank lines, found 1
141: D210 No whitespaces allowed surrounding docstring text
141: None: None
141: D202 No blank lines allowed after function docstring (found 1)
150:22: E701 multiple statements on one line (colon)
166:17: E128 continuation line under-indented for visual indent
167:17: E128 continuation line under-indented for visual indent
168:17: E128 continuation line under-indented for visual indent
169:17: E128 continuation line under-indented for visual indent
171:1: E302 expected 2 blank lines, found 1
171: D202 No blank lines allowed after function docstring (found 1)
175:22: E701 multiple statements on one line (colon)
178:9: E128 continuation line under-indented for visual indent
186:29: F841 local variable 'err' is assigned to but never used
194:34: E261 at least two spaces before inline comment
194:35: E262 inline comment should start with '# '
196:13: E266 too many leading '#' for block comment
197:13: E266 too many leading '#' for block comment
199:13: E266 too many leading '#' for block comment
200:13: E266 too many leading '#' for block comment
201:13: E266 too many leading '#' for block comment
205:21: E266 too many leading '#' for block comment
206:21: E266 too many leading '#' for block comment
207:21: E266 too many leading '#' for block comment
215:21: E266 too many leading '#' for block comment
216:21: E266 too many leading '#' for block comment
217:21: E266 too many leading '#' for block comment
218:21: E266 too many leading '#' for block comment
219:21: E266 too many leading '#' for block comment
229:17: E266 too many leading '#' for block comment
230:17: E266 too many leading '#' for block comment
246:17: E128 continuation line under-indented for visual indent
251:11: E221 multiple spaces before operator
285:17: E128 continuation line under-indented for visual indent
286:17: E128 continuation line under-indented for visual indent
287:17: E128 continuation line under-indented for visual indent
288:17: E128 continuation line under-indented for visual indent
291: D202 No blank lines allowed after function docstring (found 1)
295:22: E701 multiple statements on one line (colon)
300:29: F841 local variable 'err' is assigned to but never used
310:5: F841 local variable 'roles2' is assigned to but never used
320:21: E266 too many leading '#' for block comment
347:17: E128 continuation line under-indented for visual indent
352:11: E221 multiple spaces before operator
383:17: E128 continuation line under-indented for visual indent
384:17: E128 continuation line under-indented for visual indent
385:17: E128 continuation line under-indented for visual indent
386:17: E128 continuation line under-indented for visual indent
389: D210 No whitespaces allowed surrounding docstring text
389: None: None
389: D202 No blank lines allowed after function docstring (found 1)
393:22: E701 multiple statements on one line (colon)
405:9: E221 multiple spaces before operator
410:29: E128 continuation line under-indented for visual indent
411:29: E128 continuation line under-indented for visual indent
432:25: E128 continuation line under-indented for visual indent
441:17: E128 continuation line under-indented for visual indent
448:17: E128 continuation line under-indented for visual indent
449:17: E128 continuation line under-indented for visual indent
450:17: E128 continuation line under-indented for visual indent
451:17: E128 continuation line under-indented for visual indent
454: D202 No blank lines allowed after function docstring (found 1)
458:22: E701 multiple statements on one line (colon)
471:17: E128 continuation line under-indented for visual indent
472:17: E128 continuation line under-indented for visual indent
473:17: E128 continuation line under-indented for visual indent
474:17: E128 continuation line under-indented for visual indent
477: D209 Multi-line docstring closing quotes should be on a separate line
477: D202 No blank lines allowed after function docstring (found 1)
477: D400 First line should end with a period (not 'e')
477: D205 1 blank line required between summary line and description (found 0)
483:22: E701 multiple statements on one line (colon)
486:31: E701 multiple statements on one line (colon)
490:34: E701 multiple statements on one line (colon)
493:11: E221 multiple spaces before operator
517:5: E303 too many blank lines (2)
529:14: E221 multiple spaces before operator
534:12: E221 multiple spaces before operator
553:17: E128 continuation line under-indented for visual indent
554:17: E128 continuation line under-indented for visual indent
555:17: E128 continuation line under-indented for visual indent
556:17: E128 continuation line under-indented for visual indent
559: D209 Multi-line docstring closing quotes should be on a separate line
559: D202 No blank lines allowed after function docstring (found 1)
559: D205 1 blank line required between summary line and description (found 0)
564:22: E701 multiple statements on one line (colon)
567:31: E701 multiple statements on one line (colon)
571:34: E701 multiple statements on one line (colon)
574:11: E221 multiple spaces before operator
610:14: E221 multiple spaces before operator
615:12: E221 multiple spaces before operator
619:29: E128 continuation line under-indented for visual indent
620:29: E128 continuation line under-indented for visual indent
621:29: E128 continuation line under-indented for visual indent
622:29: E128 continuation line under-indented for visual indent
632:17: E128 continuation line under-indented for visual indent
633:17: E128 continuation line under-indented for visual indent
634:17: E128 continuation line under-indented for visual indent
635:17: E128 continuation line under-indented for visual indent
637:1: E302 expected 2 blank lines, found 1
637: D202 No blank lines allowed after function docstring (found 1)
641:22: E701 multiple statements on one line (colon)
693:17: E128 continuation line under-indented for visual indent
694:17: E128 continuation line under-indented for visual indent
695:17: E128 continuation line under-indented for visual indent
696:17: E128 continuation line under-indented for visual indent
697:17: E128 continuation line under-indented for visual indent
699:1: E302 expected 2 blank lines, found 1
699: D202 No blank lines allowed after function docstring (found 1)
703:22: E701 multiple statements on one line (colon)
748:1: E302 expected 2 blank lines, found 1
748: D202 No blank lines allowed after function docstring (found 1)
752:22: E701 multiple statements on one line (colon)
774:1: E302 expected 2 blank lines, found 1
774: D202 No blank lines allowed after function docstring (found 1)
778:22: E701 multiple statements on one line (colon)
790:33: E127 continuation line over-indented for visual indent
791:33: E127 continuation line over-indented for visual indent
792:33: E127 continuation line over-indented for visual indent
824: D202 No blank lines allowed after function docstring (found 1)
824: D400 First line should end with a period (not 'e')
828:22: E701 multiple statements on one line (colon)
845:13: F841 local variable 'res2' is assigned to but never used
857:1: E302 expected 2 blank lines, found 1
857: D209 Multi-line docstring closing quotes should be on a separate line
857: D202 No blank lines allowed after function docstring (found 1)
857: D205 1 blank line required between summary line and description (found 0)
865:22: E701 multiple statements on one line (colon)
877:17: E128 continuation line under-indented for visual indent
878:17: E128 continuation line under-indented for visual indent
879:17: E128 continuation line under-indented for visual indent
880:17: E128 continuation line under-indented for visual indent
881:17: E128 continuation line under-indented for visual indent
920:17: E128 continuation line under-indented for visual indent
921:17: E128 continuation line under-indented for visual indent
922:17: E128 continuation line under-indented for visual indent
923:17: E128 continuation line under-indented for visual indent
924:17: E128 continuation line under-indented for visual indent
926:1: E302 expected 2 blank lines, found 1
926: D202 No blank lines allowed after function docstring (found 1)
926: D400 First line should end with a period (not 't')
930:22: E701 multiple statements on one line (colon)
949:1: E302 expected 2 blank lines, found 1
949: D202 No blank lines allowed after function docstring (found 1)
949: D400 First line should end with a period (not 't')
953:22: E701 multiple statements on one line (colon)
963:15: E222 multiple spaces after operator
964:15: E222 multiple spaces after operator
972:33: E128 continuation line under-indented for visual indent
973:33: E128 continuation line under-indented for visual indent
974:33: E128 continuation line under-indented for visual indent
975:33: E128 continuation line under-indented for visual indent
1000:1: E302 expected 2 blank lines, found 1
1000: D202 No blank lines allowed after function docstring (found 1)
1000: D400 First line should end with a period (not 't')
1004:22: E701 multiple statements on one line (colon)
1025:9: E303 too many blank lines (2)
1026:33: E128 continuation line under-indented for visual indent
1027:33: E128 continuation line under-indented for visual indent
1028:33: E128 continuation line under-indented for visual indent
1029:33: E128 continuation line under-indented for visual indent
1046:1: E302 expected 2 blank lines, found 1
1046: D202 No blank lines allowed after function docstring (found 1)
1046: D400 First line should end with a period (not 't')
1050:22: E701 multiple statements on one line (colon)
1060:37: E128 continuation line under-indented for visual indent
1061:21: E128 continuation line under-indented for visual indent
1062:37: E128 continuation line under-indented for visual indent
1063:37: E128 continuation line under-indented for visual indent
1066:13: F841 local variable 'res2' is assigned to but never used
1069:17: F841 local variable 'emailsent' is assigned to but never used
1080:1: E302 expected 2 blank lines, found 1
1080:62: E203 whitespace before ','
1080: D202 No blank lines allowed after function docstring (found 1)
1080: D400 First line should end with a period (not 't')
1085:22: E701 multiple statements on one line (colon)
1121:1: E302 expected 2 blank lines, found 1
1121: D202 No blank lines allowed after function docstring (found 1)
1125:22: E701 multiple statements on one line (colon)
1131:9: F841 local variable 'res2' is assigned to but never used
1152:1: E302 expected 2 blank lines, found 1
1152: D202 No blank lines allowed after function docstring (found 1)
1156:22: E701 multiple statements on one line (colon)
1166:5: B901 blind except: statement
1172:5: B901 blind except: statement
1175:9: E221 multiple spaces before operator
1183:36: E225 missing whitespace around operator
1183:76: E225 missing whitespace around operator
1183:120: E225 missing whitespace around operator
1193:35: E225 missing whitespace around operator
1193:71: E225 missing whitespace around operator
1193:107: E225 missing whitespace around operator
1193:144: E225 missing whitespace around operator
1193:181: E225 missing whitespace around operator
1193:218: E225 missing whitespace around operator
1196:29: E128 continuation line under-indented for visual indent
1197:29: E128 continuation line under-indented for visual indent
1223:31: E221 multiple spaces before operator
1225:60: E221 multiple spaces before operator
1226:51: E225 missing whitespace around operator
1227:36: E225 missing whitespace around operator
1228:64: E231 missing whitespace after ','
1239:46: E221 multiple spaces before operator
1259:1: E302 expected 2 blank lines, found 1
1259: D202 No blank lines allowed after function docstring (found 1)
1266:21: E128 continuation line under-indented for visual indent
1267:21: E128 continuation line under-indented for visual indent
1268:21: E128 continuation line under-indented for visual indent
1297:17: E128 continuation line under-indented for visual indent
1298:17: E128 continuation line under-indented for visual indent
1299:17: E128 continuation line under-indented for visual indent
1300:17: E128 continuation line under-indented for visual indent
1301:17: E128 continuation line under-indented for visual indent
1304: D401 First line should be in imperative mood ('let', not 'lets')
1304: D209 Multi-line docstring closing quotes should be on a separate line
1304: D202 No blank lines allowed after function docstring (found 1)
1304: D400 First line should end with a period (not 's')
1304: D208 Docstring is over-indented
1330:29: E128 continuation line under-indented for visual indent
1331:29: E128 continuation line under-indented for visual indent
1332:29: E128 continuation line under-indented for visual indent
1333:29: E128 continuation line under-indented for visual indent
1334:29: E128 continuation line under-indented for visual indent
1355:29: E701 multiple statements on one line (colon)
1371:33: E128 continuation line under-indented for visual indent
1372:33: E128 continuation line under-indented for visual indent
1373:33: E128 continuation line under-indented for visual indent
1374:33: E128 continuation line under-indented for visual indent
1375:33: E128 continuation line under-indented for visual indent
1376:33: E128 continuation line under-indented for visual indent
1389:37: E128 continuation line under-indented for visual indent
1390:37: E128 continuation line under-indented for visual indent
1391:37: E128 continuation line under-indented for visual indent
1392:37: E128 continuation line under-indented for visual indent
1402:49: E128 continuation line under-indented for visual indent
1403:49: E128 continuation line under-indented for visual indent
1404:49: E128 continuation line under-indented for visual indent
1409:21: E701 multiple statements on one line (colon)
1412:8: E701 multiple statements on one line (colon)
1413:21: E701 multiple statements on one line (colon)
1416:17: E128 continuation line under-indented for visual indent
1417:17: E128 continuation line under-indented for visual indent
1418:17: E128 continuation line under-indented for visual indent
1419:17: E128 continuation line under-indented for visual indent
1422: D209 Multi-line docstring closing quotes should be on a separate line
1422: D202 No blank lines allowed after function docstring (found 1)
1467:33: E128 continuation line under-indented for visual indent
1475:17: E221 multiple spaces before operator
1479:37: E128 continuation line under-indented for visual indent
1480:37: E128 continuation line under-indented for visual indent
1481:37: E128 continuation line under-indented for visual indent
1512:53: E701 multiple statements on one line (colon)
1512:71: E231 missing whitespace after ','
1512:77: E231 missing whitespace after ','
1514:54: E231 missing whitespace after ','
1517:45: E128 continuation line under-indented for visual indent
1518:45: E128 continuation line under-indented for visual indent
1519:45: E128 continuation line under-indented for visual indent
1520:45: E128 continuation line under-indented for visual indent
1521:45: E128 continuation line under-indented for visual indent
1522:45: E128 continuation line under-indented for visual indent
1523:45: E128 continuation line under-indented for visual indent
1525:24: E701 multiple statements on one line (colon)
1526:38: E701 multiple statements on one line (colon)
1535:49: E128 continuation line under-indented for visual indent
1536:49: E128 continuation line under-indented for visual indent
1537:49: E128 continuation line under-indented for visual indent
1538:49: E128 continuation line under-indented for visual indent
1539:49: E128 continuation line under-indented for visual indent
1548:39: E221 multiple spaces before operator
1561:17: E128 continuation line under-indented for visual indent
1562:17: E128 continuation line under-indented for visual indent
1563:17: E128 continuation line under-indented for visual indent
1564:17: E128 continuation line under-indented for visual indent
1565:17: E128 continuation line under-indented for visual indent
1568: D209 Multi-line docstring closing quotes should be on a separate line
1568: D202 No blank lines allowed after function docstring (found 1)
1605:9: F841 local variable 'email_out' is assigned to but never used
1618:33: E128 continuation line under-indented for visual indent
1626:37: E128 continuation line under-indented for visual indent
1627:37: E128 continuation line under-indented for visual indent
1628:37: E128 continuation line under-indented for visual indent
1629:37: E128 continuation line under-indented for visual indent
1636:41: E128 continuation line under-indented for visual indent
1637:41: E128 continuation line under-indented for visual indent
1638:41: E128 continuation line under-indented for visual indent
1639:41: E128 continuation line under-indented for visual indent
1640:41: E128 continuation line under-indented for visual indent
1659:17: E128 continuation line under-indented for visual indent
1660:17: E128 continuation line under-indented for visual indent
1661:17: E128 continuation line under-indented for visual indent
1662:17: E128 continuation line under-indented for visual indent
1663:17: E128 continuation line under-indented for visual indent
1665:1: E302 expected 2 blank lines, found 1
1665: D210 No whitespaces allowed surrounding docstring text
1665: None: None
1665: D202 No blank lines allowed after function docstring (found 1)
1669:22: E701 multiple statements on one line (colon)
1697:17: E128 continuation line under-indented for visual indent
1698:17: E128 continuation line under-indented for visual indent
1699:17: E128 continuation line under-indented for visual indent
1700:17: E128 continuation line under-indented for visual indent
1703: D210 No whitespaces allowed surrounding docstring text
1703: None: None
1703: D202 No blank lines allowed after function docstring (found 1)
1713:29: E128 continuation line under-indented for visual indent
1726:29: E128 continuation line under-indented for visual indent
1741: D209 Multi-line docstring closing quotes should be on a separate line
1741: D202 No blank lines allowed after function docstring (found 1)
1741: D400 First line should end with a period (not ':')
1749:22: E701 multiple statements on one line (colon)
1753:10: E225 missing whitespace around operator
1797:37: E128 continuation line under-indented for visual indent
1798:37: E128 continuation line under-indented for visual indent
1799:37: E128 continuation line under-indented for visual indent
1800:37: E128 continuation line under-indented for visual indent
1801:37: E128 continuation line under-indented for visual indent
1805:41: E128 continuation line under-indented for visual indent
1806:41: E128 continuation line under-indented for visual indent
1807:41: E128 continuation line under-indented for visual indent
1816:41: E128 continuation line under-indented for visual indent
1832:8: E701 multiple statements on one line (colon)
1833:21: E701 multiple statements on one line (colon)
1836:17: E128 continuation line under-indented for visual indent
1837:17: E128 continuation line under-indented for visual indent
1838:17: E128 continuation line under-indented for visual indent
1839:17: E128 continuation line under-indented for visual indent
1841:1: E302 expected 2 blank lines, found 1
1841: D202 No blank lines allowed after function docstring (found 1)
1841: D400 First line should end with a period (not ':')
1852:22: E701 multiple statements on one line (colon)
1855:27: E225 missing whitespace around operator
1865:10: E225 missing whitespace around operator
1912:41: E127 continuation line over-indented for visual indent
1913:41: E127 continuation line over-indented for visual indent
1913:48: E251 unexpected spaces around keyword / parameter equals
1913:50: E251 unexpected spaces around keyword / parameter equals
1914:41: E127 continuation line over-indented for visual indent
1915:41: E127 continuation line over-indented for visual indent
1916:41: E127 continuation line over-indented for visual indent
1917:41: E127 continuation line over-indented for visual indent
1918:41: E127 continuation line over-indented for visual indent
1921:45: E128 continuation line under-indented for visual indent
1927:25: E128 continuation line under-indented for visual indent
1928:25: E128 continuation line under-indented for visual indent
1934:5: E303 too many blank lines (2)
1937:21: E127 continuation line over-indented for visual indent
1938:21: E127 continuation line over-indented for visual indent
1939:21: E127 continuation line over-indented for visual indent
1940:21: E127 continuation line over-indented for visual indent
1944:1: E303 too many blank lines (3)
1944: D209 Multi-line docstring closing quotes should be on a separate line
1944: D202 No blank lines allowed after function docstring (found 1)
1944: D400 First line should end with a period (not ',')
1952:22: E701 multiple statements on one line (colon)
1959:29: E128 continuation line under-indented for visual indent
1960:29: E128 continuation line under-indented for visual indent
1961:29: E128 continuation line under-indented for visual indent
1962:29: E128 continuation line under-indented for visual indent
1970:33: E128 continuation line under-indented for visual indent
1971:33: E128 continuation line under-indented for visual indent
1972:33: E128 continuation line under-indented for visual indent
1986:17: E128 continuation line under-indented for visual indent
1987:17: E128 continuation line under-indented for visual indent
1988:17: E128 continuation line under-indented for visual indent
1989:17: E128 continuation line under-indented for visual indent
1992: D202 No blank lines allowed after function docstring (found 1)
1996:22: E701 multiple statements on one line (colon)
1999:29: E128 continuation line under-indented for visual indent
2000:29: E128 continuation line under-indented for visual indent
2001:29: E128 continuation line under-indented for visual indent
2002:29: E128 continuation line under-indented for visual indent
2024:25: E203 whitespace before ':'
2024:48: E203 whitespace before ':'
2032:17: E128 continuation line under-indented for visual indent
2033:17: E128 continuation line under-indented for visual indent
2034:17: E128 continuation line under-indented for visual indent
2035:17: E128 continuation line under-indented for visual indent
2038: D210 No whitespaces allowed surrounding docstring text
2038: None: None
2038: D202 No blank lines allowed after function docstring (found 1)
2065:12: E221 multiple spaces before operator
2069:62: E261 at least two spaces before inline comment
2090:1: E303 too many blank lines (3)
2090: D209 Multi-line docstring closing quotes should be on a separate line
2090: D202 No blank lines allowed after function docstring (found 1)
2090: D208 Docstring is over-indented
2100:22: E701 multiple statements on one line (colon)
2109:29: E128 continuation line under-indented for visual indent
2110:29: E128 continuation line under-indented for visual indent
2111:29: E128 continuation line under-indented for visual indent
2122:13: E221 multiple spaces before operator
2126:33: E128 continuation line under-indented for visual indent
2127:33: E128 continuation line under-indented for visual indent
2128:33: E128 continuation line under-indented for visual indent
2159:54: E701 multiple statements on one line (colon)
2159:77: E231 missing whitespace after ','
2159:83: E231 missing whitespace after ','
2161:55: E231 missing whitespace after ','
2164:41: E128 continuation line under-indented for visual indent
2165:41: E128 continuation line under-indented for visual indent
2166:41: E128 continuation line under-indented for visual indent
2167:41: E128 continuation line under-indented for visual indent
2168:41: E128 continuation line under-indented for visual indent
2169:41: E128 continuation line under-indented for visual indent
2170:41: E128 continuation line under-indented for visual indent
2172:20: E701 multiple statements on one line (colon)
2173:34: E701 multiple statements on one line (colon)
2182:45: E128 continuation line under-indented for visual indent
2183:45: E128 continuation line under-indented for visual indent
2184:45: E128 continuation line under-indented for visual indent
2185:45: E128 continuation line under-indented for visual indent
2186:45: E128 continuation line under-indented for visual indent
2195:35: E221 multiple spaces before operator
2221:17: E128 continuation line under-indented for visual indent
2222:17: E128 continuation line under-indented for visual indent
2223:17: E128 continuation line under-indented for visual indent
2224:17: E128 continuation line under-indented for visual indent
2227: D209 Multi-line docstring closing quotes should be on a separate line
2227: D202 No blank lines allowed after function docstring (found 1)
2235:22: E701 multiple statements on one line (colon)
2249:9: E221 multiple spaces before operator
2253:29: E128 continuation line under-indented for visual indent
2254:29: E128 continuation line under-indented for visual indent
2255:29: E128 continuation line under-indented for visual indent
2265:34: E701 multiple statements on one line (colon)
2276:37: E128 continuation line under-indented for visual indent
2277:37: E128 continuation line under-indented for visual indent
2278:37: E128 continuation line under-indented for visual indent
2279:37: E128 continuation line under-indented for visual indent
2280:37: E128 continuation line under-indented for visual indent
2292:38: E701 multiple statements on one line (colon)
2293:25: E701 multiple statements on one line (colon)
2297:41: E128 continuation line under-indented for visual indent
2298:41: E128 continuation line under-indented for visual indent
2299:41: E128 continuation line under-indented for visual indent
2300:41: E128 continuation line under-indented for visual indent
2301:41: E128 continuation line under-indented for visual indent
2302:41: E128 continuation line under-indented for visual indent
2303:41: E128 continuation line under-indented for visual indent
2304:41: E128 continuation line under-indented for visual indent
2313:45: E128 continuation line under-indented for visual indent
2314:45: E128 continuation line under-indented for visual indent
2315:45: E128 continuation line under-indented for visual indent
2316:45: E128 continuation line under-indented for visual indent
2317:45: E128 continuation line under-indented for visual indent
2325:35: E221 multiple spaces before operator
2344:32: E701 multiple statements on one line (colon)
2353:17: E128 continuation line under-indented for visual indent
2354:17: E128 continuation line under-indented for visual indent
2355:17: E128 continuation line under-indented for visual indent
2356:17: E128 continuation line under-indented for visual indent
2359: D209 Multi-line docstring closing quotes should be on a separate line
2359: D202 No blank lines allowed after function docstring (found 1)
2367:22: E701 multiple statements on one line (colon)
2379:33: E128 continuation line under-indented for visual indent
2380:33: E128 continuation line under-indented for visual indent
2381:33: E128 continuation line under-indented for visual indent
2386:37: E128 continuation line under-indented for visual indent
2387:37: E128 continuation line under-indented for visual indent
2388:37: E128 continuation line under-indented for visual indent
2389:37: E128 continuation line under-indented for visual indent
2404:39: E701 multiple statements on one line (colon)
2409:40: E261 at least two spaces before inline comment
2414:37: E128 continuation line under-indented for visual indent
2415:37: E128 continuation line under-indented for visual indent
2416:37: E128 continuation line under-indented for visual indent
2417:37: E128 continuation line under-indented for visual indent
2426:38: E701 multiple statements on one line (colon)
2429:41: E128 continuation line under-indented for visual indent
2430:41: E128 continuation line under-indented for visual indent
2431:41: E128 continuation line under-indented for visual indent
2432:41: E128 continuation line under-indented for visual indent
2433:41: E128 continuation line under-indented for visual indent
2438:33: E128 continuation line under-indented for visual indent
2439:33: E128 continuation line under-indented for visual indent
2440:33: E128 continuation line under-indented for visual indent
2441:33: E128 continuation line under-indented for visual indent
2442:33: E128 continuation line under-indented for visual indent
2477:13: E701 multiple statements on one line (colon)
2478:9: E701 multiple statements on one line (colon)
2481:17: E128 continuation line under-indented for visual indent
2482:17: E128 continuation line under-indented for visual indent
2483:17: E128 continuation line under-indented for visual indent
2484:17: E128 continuation line under-indented for visual indent
2487: D210 No whitespaces allowed surrounding docstring text
2487: None: None
2487: D202 No blank lines allowed after function docstring (found 1)
2491:22: E701 multiple statements on one line (colon)
2511:17: E128 continuation line under-indented for visual indent
2512:17: E128 continuation line under-indented for visual indent
2513:17: E128 continuation line under-indented for visual indent
2514:17: E128 continuation line under-indented for visual indent
2517: D210 No whitespaces allowed surrounding docstring text
2517: None: None
2517: D202 No blank lines allowed after function docstring (found 1)
2534:16: E221 multiple spaces before operator
2537:16: E221 multiple spaces before operator
2541:1: E302 expected 2 blank lines, found 1
2541: D210 No whitespaces allowed surrounding docstring text
2541: None: None
2541: D209 Multi-line docstring closing quotes should be on a separate line
2541: D202 No blank lines allowed after function docstring (found 1)
2541: D400 First line should end with a period (not ':')
2551:22: E701 multiple statements on one line (colon)
2572:33: E128 continuation line under-indented for visual indent
2573:33: E128 continuation line under-indented for visual indent
2574:33: E128 continuation line under-indented for visual indent
2575:33: E128 continuation line under-indented for visual indent
2583:36: E701 multiple statements on one line (colon)
2585:41: E128 continuation line under-indented for visual indent
2586:41: E128 continuation line under-indented for visual indent
2587:41: E128 continuation line under-indented for visual indent
2588:41: E128 continuation line under-indented for visual indent
2589:41: E128 continuation line under-indented for visual indent
2590:41: E128 continuation line under-indented for visual indent
2607:37: E701 multiple statements on one line (colon)
2609:37: E128 continuation line under-indented for visual indent
2610:37: E128 continuation line under-indented for visual indent
2611:37: E128 continuation line under-indented for visual indent
2612:37: E128 continuation line under-indented for visual indent
2613:37: E128 continuation line under-indented for visual indent
2614:37: E128 continuation line under-indented for visual indent
2639:12: E221 multiple spaces before operator
2681:40: E261 at least two spaces before inline comment
2682:27: E701 multiple statements on one line (colon)
2683:25: E701 multiple statements on one line (colon)
2684:32: E701 multiple statements on one line (colon)
2708:41: E128 continuation line under-indented for visual indent
2709:41: E128 continuation line under-indented for visual indent
2710:41: E128 continuation line under-indented for visual indent
2711:41: E128 continuation line under-indented for visual indent
2712:41: E128 continuation line under-indented for visual indent
2713:41: E128 continuation line under-indented for visual indent
2714:41: E128 continuation line under-indented for visual indent
2728:13: E701 multiple statements on one line (colon)
2731:5: E303 too many blank lines (2)
2735:41: E128 continuation line under-indented for visual indent
2736:41: E128 continuation line under-indented for visual indent
2737:41: E128 continuation line under-indented for visual indent
2741:29: E261 at least two spaces before inline comment
2744:43: E701 multiple statements on one line (colon)
2757:13: E701 multiple statements on one line (colon)
2760:8: E701 multiple statements on one line (colon)
2761:21: E701 multiple statements on one line (colon)
2764:17: E128 continuation line under-indented for visual indent
2764:22: E251 unexpected spaces around keyword / parameter equals
2764:24: E251 unexpected spaces around keyword / parameter equals
2765:17: E128 continuation line under-indented for visual indent
2766:17: E128 continuation line under-indented for visual indent
2767:17: E128 continuation line under-indented for visual indent
2770: D209 Multi-line docstring closing quotes should be on a separate line
2770: D202 No blank lines allowed after function docstring (found 1)
2770: D208 Docstring is over-indented
2781:22: E701 multiple statements on one line (colon)
2789:15: E221 multiple spaces before operator
2790:33: E128 continuation line under-indented for visual indent
2791:33: E128 continuation line under-indented for visual indent
2792:33: E128 continuation line under-indented for visual indent
2793:33: E128 continuation line under-indented for visual indent
2799:41: E128 continuation line under-indented for visual indent
2800:41: E128 continuation line under-indented for visual indent
2801:41: E128 continuation line under-indented for visual indent
2802:41: E128 continuation line under-indented for visual indent
2803:41: E128 continuation line under-indented for visual indent
2804:41: E128 continuation line under-indented for visual indent
2819:37: E128 continuation line under-indented for visual indent
2820:37: E128 continuation line under-indented for visual indent
2821:37: E128 continuation line under-indented for visual indent
2822:37: E128 continuation line under-indented for visual indent
2823:37: E128 continuation line under-indented for visual indent
2824:37: E128 continuation line under-indented for visual indent
2837:37: E128 continuation line under-indented for visual indent
2838:37: E128 continuation line under-indented for visual indent
2839:37: E128 continuation line under-indented for visual indent
2840:37: E128 continuation line under-indented for visual indent
2841:37: E128 continuation line under-indented for visual indent
2856:17: E128 continuation line under-indented for visual indent
2857:17: E128 continuation line under-indented for visual indent
2858:17: E128 continuation line under-indented for visual indent
2859:17: E128 continuation line under-indented for visual indent
2862: D209 Multi-line docstring closing quotes should be on a separate line
2862: D202 No blank lines allowed after function docstring (found 1)
2862: D400 First line should end with a period (not 's')
2862: D205 1 blank line required between summary line and description (found 0)
2880:22: E701 multiple statements on one line (colon)
2887:8: E701 multiple statements on one line (colon)
2888:22: E701 multiple statements on one line (colon)
2913:5: E303 too many blank lines (2)
2918:33: E128 continuation line under-indented for visual indent
2919:33: E128 continuation line under-indented for visual indent
2920:33: E128 continuation line under-indented for visual indent
2921:33: E128 continuation line under-indented for visual indent
2927:41: E128 continuation line under-indented for visual indent
2928:41: E128 continuation line under-indented for visual indent
2929:41: E128 continuation line under-indented for visual indent
2930:41: E128 continuation line under-indented for visual indent
2931:41: E128 continuation line under-indented for visual indent
2937:37: E128 continuation line under-indented for visual indent
2938:37: E128 continuation line under-indented for visual indent
2939:37: E128 continuation line under-indented for visual indent
2940:37: E128 continuation line under-indented for visual indent
2945:37: E128 continuation line under-indented for visual indent
2946:37: E128 continuation line under-indented for visual indent
2947:37: E128 continuation line under-indented for visual indent
2948:37: E128 continuation line under-indented for visual indent
2949:37: E128 continuation line under-indented for visual indent
2951:17: E701 multiple statements on one line (colon)
2955:37: E701 multiple statements on one line (colon)
2968:80: E701 multiple statements on one line (colon)
3014:24: E221 multiple spaces before operator
3045:17: E128 continuation line under-indented for visual indent
3046:17: E128 continuation line under-indented for visual indent
3047:17: E128 continuation line under-indented for visual indent
3048:17: E128 continuation line under-indented for visual indent
3051: D209 Multi-line docstring closing quotes should be on a separate line
3051: D202 No blank lines allowed after function docstring (found 1)
3051: D205 1 blank line required between summary line and description (found 0)
3052:9: E128 continuation line under-indented for visual indent
3076:9: E128 continuation line under-indented for visual indent
3078:11: E221 multiple spaces before operator
3086:5: E303 too many blank lines (2)
3100:11: E221 multiple spaces before operator
3129: D209 Multi-line docstring closing quotes should be on a separate line
3129: D202 No blank lines allowed after function docstring (found 1)
3129: D400 First line should end with a period (not 'f')
3129: D205 1 blank line required between summary line and description (found 0)
3158:13: E128 continuation line under-indented for visual indent
3163: D209 Multi-line docstring closing quotes should be on a separate line
3163: D202 No blank lines allowed after function docstring (found 1)
3163: D400 First line should end with a period (not 't')
3163: D205 1 blank line required between summary line and description (found 0)
3195:1: E303 too many blank lines (3)
3195: D209 Multi-line docstring closing quotes should be on a separate line
3195: D202 No blank lines allowed after function docstring (found 1)
3213:45: E128 continuation line under-indented for visual indent
3214:45: E128 continuation line under-indented for visual indent
3218:1: E302 expected 2 blank lines, found 1
3218: D209 Multi-line docstring closing quotes should be on a separate line
3218: D202 No blank lines allowed after function docstring (found 1)
3240:114: E261 at least two spaces before inline comment
3250: D209 Multi-line docstring closing quotes should be on a separate line
3250: D202 No blank lines allowed after function docstring (found 1)
3250: D208 Docstring is over-indented
3276:118: E261 at least two spaces before inline comment
3289: D202 No blank lines allowed after function docstring (found 1)
3289: D400 First line should end with a period (not 'e')
3323:1: E302 expected 2 blank lines, found 1
3323: D103 Missing docstring in public function
3326:1: E302 expected 2 blank lines, found 1
3326: D209 Multi-line docstring closing quotes should be on a separate line
3326: D202 No blank lines allowed after function docstring (found 1)
3326: D400 First line should end with a period (not 'a')
3326: D205 1 blank line required between summary line and description (found 0)
3337:13: E128 continuation line under-indented for visual indent
3338:13: E128 continuation line under-indented for visual indent
3339:13: E128 continuation line under-indented for visual indent
3341:15: E221 multiple spaces before operator
3348:17: E128 continuation line under-indented for visual indent
3349:17: E128 continuation line under-indented for visual indent
3350:17: E128 continuation line under-indented for visual indent
3351:17: E128 continuation line under-indented for visual indent
3354: D210 No whitespaces allowed surrounding docstring text
3354: None: None
3354: D202 No blank lines allowed after function docstring (found 1)
3368:17: E128 continuation line under-indented for visual indent
3369:15: E221 multiple spaces before operator
3384:17: E128 continuation line under-indented for visual indent
3385:17: E128 continuation line under-indented for visual indent
3386:17: E128 continuation line under-indented for visual indent
3387:17: E128 continuation line under-indented for visual indent
3393:1: E303 too many blank lines (5)
3393: D209 Multi-line docstring closing quotes should be on a separate line
3393: D202 No blank lines allowed after function docstring (found 1)
3393: D400 First line should end with a period (not 's')
3394:17: E128 continuation line under-indented for visual indent
3395:17: E128 continuation line under-indented for visual indent
3417:11: E221 multiple spaces before operator
3462: D202 No blank lines allowed after function docstring (found 1)
3463:9: E128 continuation line under-indented for visual indent
3464:9: E128 continuation line under-indented for visual indent
3468:9: E128 continuation line under-indented for visual indent
3469:9: E128 continuation line under-indented for visual indent
3472: D202 No blank lines allowed after function docstring (found 1)
3473:9: E128 continuation line under-indented for visual indent
3474:9: E128 continuation line under-indented for visual indent
3478:9: E128 continuation line under-indented for visual indent
3479:9: E128 continuation line under-indented for visual indent
3482: D202 No blank lines allowed after function docstring (found 1)
3483:9: E128 continuation line under-indented for visual indent
3484:9: E128 continuation line under-indented for visual indent
3488:9: E128 continuation line under-indented for visual indent
3489:9: E128 continuation line under-indented for visual indent
3492: D209 Multi-line docstring closing quotes should be on a separate line
3492: D202 No blank lines allowed after function docstring (found 1)
3492: D205 1 blank line required between summary line and description (found 0)
3492: D208 Docstring is over-indented
3519: D209 Multi-line docstring closing quotes should be on a separate line
3519: D202 No blank lines allowed after function docstring (found 1)
3519: D205 1 blank line required between summary line and description (found 0)
3533: D209 Multi-line docstring closing quotes should be on a separate line
3533: D202 No blank lines allowed after function docstring (found 1)
3544: D209 Multi-line docstring closing quotes should be on a separate line
3544: D202 No blank lines allowed after function docstring (found 1)
3544: D205 1 blank line required between summary line and description (found 0)
3551:1: E302 expected 2 blank lines, found 1
3551: D209 Multi-line docstring closing quotes should be on a separate line
3551: D400 First line should end with a period (not 'd')
3551: D205 1 blank line required between summary line and description (found 0)
3565:1: E302 expected 2 blank lines, found 1
3565: D209 Multi-line docstring closing quotes should be on a separate line
3565: D400 First line should end with a period (not 't')
3565: D205 1 blank line required between summary line and description (found 0)
3578:1: E302 expected 2 blank lines, found 1
3578: D209 Multi-line docstring closing quotes should be on a separate line
3578: D400 First line should end with a period (not 't')
3578: D205 1 blank line required between summary line and description (found 0)
3591:1: E302 expected 2 blank lines, found 1
3591: D209 Multi-line docstring closing quotes should be on a separate line
3591: D400 First line should end with a period (not 't')
3591: D205 1 blank line required between summary line and description (found 0)


1: D210 No whitespaces allowed surrounding docstring text
1: None: None
25:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
27:1: F401 'config' imported but unused
27:1: E402 module level import not at top of file
142:16: E126 continuation line over-indented for hanging indent
148:58: E203 whitespace before ','
208:15: E126 continuation line over-indented for hanging indent
211:1: E402 module level import not at top of file
244:17: E203 whitespace before ':'
245:22: E203 whitespace before ':'
246:20: E203 whitespace before ':'
247:18: E203 whitespace before ':'
248:24: E203 whitespace before ':'
249:22: E203 whitespace before ':'
250:19: E203 whitespace before ':'
251:20: E203 whitespace before ':'
252:23: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:17: E203 whitespace before ':'
255:19: E203 whitespace before ':'
256:20: E203 whitespace before ':'
257:21: E203 whitespace before ':'
258:19: E203 whitespace before ':'
259:19: E203 whitespace before ':'
260:20: E203 whitespace before ':'
261:17: E203 whitespace before ':'
262:24: E203 whitespace before ':'
263:23: E203 whitespace before ':'
264:21: E203 whitespace before ':'
265:37: E203 whitespace before ':'
279:4: E131 continuation line unaligned for hanging indent
308:1: W391 blank line at end of file


(also, `git-merge --ff-only HEAD` returns exit status 0 - success)


22:1: I101 Imported names are in the wrong order. Should be Blueprint, redirect, url_for
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.modules.accounts.models
27:1: I101 Imported names are in the wrong order. Should be sorted_by, templated
27:1: I100 Imports statements are in the wrong order. from invenio.base.decorators should be before from invenio.base.i18n
28:1: I100 Imports statements are in the wrong order. from flask_breadcrumbs should be before from invenio.base.decorators
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
45: D103 Missing docstring in public function
74: D103 Missing docstring in public function
86: D103 Missing docstring in public function
97: D103 Missing docstring in public function
106: D103 Missing docstring in public function
114: D103 Missing docstring in public function
120: D103 Missing docstring in public function
126: D103 Missing docstring in public function


had to add this back. When running a test that expects an exception to be thrown, we have a validation which does not allow result to be null(which it is if there is an exception). I think we either remove the validation or leave this in..


Ok in that case ignore my 2nd comment!


add a pig and a student


Please, point what keys are required. While --output is optional, the --lang is must, as I see:
`"Output language must be specified with --lang=languageName"`


朱灵好像写错了，只有使用杀才会让人弃两张牌，而这个自己使用其他牌也要弃牌


Space issue here.


After a quick glance the code seems ok from here (not actually tested).

In any case I think it would be a good thing trying to understand the reason why Yii
does not fulfil CActiveRecord#count definition, though.


On Mon, Mar 30, 2015 at 11:54 PM, plieven <notifications@github.com> wrote:

> If the test tool is working on /dev/sg* wouldn't it be the point to put
> the test tool into a separate repo as we discussed some time ago?
>

Yeah, probably.

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sahlberg/libiscsi/commit/c72edd514d0e059c5110d867d667c016d1dce5a7#commitcomment-10482656>
> .
>


It is not a good idea to create a global $logger here. please pass logger as an option.


Use stdint types when possible, so uint32_t here.


static bool before definition.


`null` не обязательно, потому что поле устанавливается в конструкторе.
Лучше всего будет
```java
private final Socket clientSocket;
```


Also we would probably like the possibility to log to stderr and a file at the same time.

We could use something like this:

~~~ ruby
  class MultiLogger < BasicObject
    def initialize(*loggers)
      @loggers = loggers
    end

    def method_missing(name, *args, &b)
      @loggers.map {|x| x.respond_to?(name) && x.public_send(name, *args, &b) }.any?
    end
  end
~~~


@Henningstone
In general, go for readable, not short. The comma operator is one of the things that should be omitted completely, because (as in this case) skimming the source code is not sufficient for understanding it.


Implicit conversion from int to unsigned char is unsafe. All other set
aout related functions use int as parameter. There is no reason to use
unsigned char. The problem is caused by a wrong index value that causes
the array pointer to point somewhere undefined in the memory.

Michael Haberler writes:

> what exactly is wrong with unsigned char? can index be > 255 ? there is no usage of 'signed' AFAICT?
>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/strahlex/machinekit-1/commit/9d93fb2f23f7430fdecfdf1154c4441a44d9f95d#commitcomment-10487901

--
Alexander


I'm glad you found it useful :) I just modified a few things that were making it difficult to use in my implementation, the most important being the alerts. I didn't want my software's users to have to close alert dialogs if the map displays no data (which can be normal), or if there is a bug.

Regarding commit <tt>07e1ec6</tt>, I reversed the order of the legend ranges, because I think that is standard for most maps, but I'm sure implementing it as an optional parameter might be even better. Lines 1088-1096 were a bit problematic, though. If we take the ranges [ [-1.324, 1], [ 1, 3.131], [3.131, 6.104]] for example, with a precision of 3, then the original code would have resulted in the following legend ranges when using the 'distinct' parameter: [[-1.323, 1], [2, 3.131], [3.132, 6.104]].

I just simplified it so that it doesn't increment integer values differently than float values, always ensuring that it increments by the set precision.

Thanks for including it in your library :)
-skaindl


We are not supposed to add html markup in jade unless absolutely necessary or requiring more than appropriate efforts. Not sure if we have a css or something to handle the line break, probably its fine.


...we could leave it as you've done and ignore this commit. I really don't know what's the best solution. Having the same checkbox on two different tabs can be convenient, or misleading: I don't know!


Super :)


Das kann nicht funktionieren: Count types wird asynchron aufgerufen.


I think you swapped the variables by error: j <----> i   shouldn't it be:
for ( int j = 0; i < ids.length && j < size; j++, i++) {
  String id = ids[i];
  ....


Копипаст плох дублированием данных, что неизбежно приведёт к тому, что они
разойдутся в процессе эволюции программы, что, в свою очередь, приведёт к
сотне багов. Копипаста надо стараться избегать. К тому же, в современных
языках вряд ли борьба с копипастом сильно ухудшит читаемость.

2015-03-31 0:03 GMT+03:00 Vladislav Tankov <notifications@github.com>:

> Но ведь иногда есть смысл оставлять копипаст, когда его отсутствие сильно
> ухудшает читаемость кода? (Не в данном случае, естественно)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TanVD/SpbSU-Homeworks/commit/4813457faf520bdb30eb3fb79f02eb3b321a5463#commitcomment-10476879>
> .
>


hmmmmm chaos mógł być :) chodzi o sytuację opisaną w giscie w case: https://gist.github.com/bslipek/dc7274975d0256f3e100#case

Ewentualnie wersja uproszczona: każdy może czytać, user może dodać komentarz, admin może wszystko.


this may fix #1


use nanoTime instead, currentTimeMillis will return +-1hour at DST timezone change


This is wrong, as Ubuntu << 15.04 are upstart. 15.04+ are systemd now


I'd increase that to something higher, e.g. 20-ish. 10sec is pretty close to DEFAULT_SUBSCRIBE_RETRY_WAIT_TIME_MILLIS + some timeout (when sentinel was down retries were happening every 7 seconds).


this is dead code. I don't see it called from anywhere. please drop dead code.


So this is a very odd choice to default to upstart.

Ideally the default would be systemd, with windows & old Ubuntu special cased.


system.out is a leftover no?


This still needs to reference _newTag.name, no?


Default should be systemd, or one must do runtime detection. E.g. [ -d /run/systemd/system ] is the canonical test to check that pid 1 is systemd


Init system refactoring has already been done by ericsnow and co, and as such this code is irrelevant.


исправил скролбар


See inline comments. Ubuntu != Upstart


Hm, somehow i don't like it that the terminal colors are needed when testing for coordinate systems.
also, this information is now redundant, as it's already in `py/openage/hardcoded`, not in this format though. But I'd rather leave out the console test for now than copying the color table.


You are correct!  Fixed thanks.


Maybe check for a more snf-image-creator specific environmental variable before checking TMPDIR. We need to separate the temporary files created for example by tempfile.TemporaryFile from the creator's  temporary COW file. SNF_IMAGE_CREATOR_TMPCOW, or SNF_TMPCOW could be a the name. The problem is that the cow file may reach or even exceed the size of1G. 99% of the time /tmp is not the right place for this kind of files. /var/tmp is more suitable, since it is never on a tmpfs (files under /var/tmp will survive reboots). If the user has exported the TMPDIR variable to save the temporary files on a non-default location, I think we should give him the possibility to change the place where the cow files gets saved.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 281](http://192.168.30.225:8111/viewLog.html?buildId=1059&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


it is very brittle and likely to break. Initialize can be called from anywhere and Create() may be called more by different threads at the same time.


确实……我回去改


test


@aznashwan ok, where is the pull request / commits for the re-factoring? Can I check them?


开issue吧


Tanks.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 282](http://192.168.30.225:8111/viewLog.html?buildId=1060&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


What was the point of adding extra blank lines??


Important NOTE - if your covering DON'T call withdraw_card()  my bad call update_game_time()


@vijaydev yeah, @matthewd already fixed it, thanks <3.


Okay, thanks for the heads up! I've already rebased my branches. Luckily I am not touching the trigger stuff right now, so everything is fine for me.


Bisher funktionierts auf jeden Fall immer?! Soll ich also synchron machen oder hast du eine bessere Idee?


Sure, but no such system exist in a functional state. Everyone ships /etc/shadow in e.g. base-files package or similar, and it's accidental removal renders system unusable.


Do we really need a space below the title?


This is not a problem. Libguestfs is Linux-specific too :-)


>  That, clearly, could only happen if another thread run in
             between those points.

There's no possibility another thread will be running this, and the `did_emsg` check is used in other parts of the code. In any case, your variant  is cleaner and adds less dependencies on globals, so :+1:


Lieber keine synchronen calls mehr. Die wollen wir möglichst weg haben.


Test comment


The topic would be created in a standard branch. In this test case we need to create user with definite group that is preset inside branch permissions (harder) or create topic in definite branch with required permissions set for "registered users" group.


Log it


employees Added


Geht asynchron nicht, wenn $EVENT_TYPES bereits im EventTypeInput::__construct() gefüllt werden?


Good :+1:


@levelboy Ok, i understood. For testing the code, i choosed to generate random numbers(i tried controlled input to) because i thaught that's more usefull to see more than one results on how the function works.


This class comes from [hoa/ruler](https://github.com/hoaproject/Ruler/blob/master/Visitor/Interpreter.php#L53) (I forgot to restore the original license and authors) and I guess they've done it in a big switch for performance reasons. I'm inclined to follow them.


@pkozlowski-opensource: Where do you run your `ghpr()` function ? On a new branch ? On master ?
Would [this process][1] (from ngMaterial) work for Angular too ?

[1]: https://github.com/angular/material/blob/master/docs/guides/MERGE_REQUESTS.md


@AlisVero Контент, не контекст х)


jj


Added Contribution


Need to double check this, but seems that in some cases there are possibility that monitor don't have wl.modes


The recommended way of building the distribution is `ant dist`. Could you please remove the reference to "Build | Prepare Plugin Module for Deployment"?


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 281](http://192.168.30.225:8111/viewLog.html?buildId=1059&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:38


kk


wtf? what are you looking at? :D


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 282](http://192.168.30.225:8111/viewLog.html?buildId=1060&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:41


@DataMachina when you call `tostring()` on a table, you usually get something that looks like: `"table: 0x2390dd0"`. And the `0x2390dd0` there is used as an internal ID by AdvDuplicator. However, if the table has a metatable with a `__tostring` method, then it'll call that instead, and you no longer get a sensible ID.

@Divran does it make sense to only do this for colors? I think it should probably be done for every table with a metatable.

There is a nice solution that doesn't require modifying the metatable available [here](http://lua-users.org/lists/lua-l/2011-05/msg00106.html) - to generate IDs for a bunch of objects, you keep a weak table where the keys are the objects, and the values are new empty tables, and then you take the IDs from the empty tables.


@drnic this breaks when there are no additional templates being merged in got:
```
Error 40001: Required property `name' was not specified in object ({})
```


accept=application/json 은 디버그 용으로 만든 것입니다.
그리고 ajax 콜과 함께 dataType:json으로 넘기면 자동으로 Accept:application/json ... 이 들어가게 됩니다.

수정해주세요.


That is probably the reason why for cf release they use [`(( merge || meta.ha_proxy_templates ))`](https://github.com/cloudfoundry/cf-release/blob/master/templates/cf-jobs.yml#L171)


Would it make sense to generalize this to MonadError?  Hmmm, perhaps not without generalizing the error type and putting an IsList constraint on it...


what did xml.send and why isn't it needed anymore?


Why is the spec file part of this repository? You can not use it without any manual tricks and the plan is to use a service to keep the package up to date.


Comment on exécute ces tests ?


Okay, i've pushed an update to the develop branch is you want to check it out, and give it a go.


See the line above.


I think it would be better to only set NOOBS_CHECK if it is currently unset. E.g.
NOOBS_CHECK=${NOOBS_CHECK:-1}
That means an advanced user can explicitly skip the check (rather than having to say "no" every update), or force it when using BOOT_PATH (if they know that makes sense).


Now am i in the group??


Is already defined by `Release: 0`.


add Parameters of Grade


Users.logout() is enough for getting "Anonymous user"


Will be replaced by the service. So I prefer to keep the version only numeric otherwise the service can't handle it.


せいてき（（いみしん


You should cast to `T` here, not to `List<T>`, and the method should return a `T` instead of an `IQueryable`


we don't have QA plugin on autotests instance for now...


>@Divran does it make sense to only do this for colors? I think it should probably be done for every table with a metatable.

idk


Nothing, ignore this one ;p


Is there a reason for removing the shebangs?


> There's no possibility another thread will be running this

Yes, yes, I know. But this is like every other warning fix previously marked as MI. Clang analysis signals them because they could be a problem in case of multithreading. So we'd better fix them, to make clang shut up, and to push code towards thread-safety, even if not needed by us.


Is there a reason why thor is not installed using 'gem'?

ruby-thor does not exist on ubuntu precise but installing it via 'gem install thor' works fine.
I know that ubuntu precise is no longer supported but up to this commit it worked fine :)


Might be worth adding -L to curl. git sometimes redirects which curl doesn't handle by default.
We do this for updating rpi-update, which was found to sometimes fail.
Should probably also do it with the "JUST_CHECK" commit messages.


Some comment here


MarkdownDocs (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13403/testReport/) for this commit**


yes, since this avoids using a multi-line string that jumps in at the left...

doing it like this maintains readability in the code, and avoids ugly indentation


something is missing here, will fix, nice catch


changed to

```python
        except OSError, err:
            raise EasyBuildError("Can't change to makefiles dir %s: %s", makefiles, err)
```


JCommuneSeleniumConfig.driver.getCurrentUrl()


yep, again, nice catch


I cringe reading this =)

[ -d /run/systemd/systemd ] -> system is running PID 1 as systemd. You can check that in go code natively, without forking out to a shell.

check that system is running upstart can be done with
* "initctl version"
* or check that unix:abstract=/com/ubuntu/upstart socket exists
* or as a private DBus socket call to Version api over unix:abstract=/com/ubuntu/upstart


the advantage is marginal, but since this triple is used in multiple places, defining it once in a dedicated variable and just using that variable avoids mistakes


Мне кажется подобное "заявление" лучше убрать в файл реализации.


Странно, а почему это свойство до сих пор щеголяет модификатором copy?


Wahrscheinlich hast du auch nie den Fall bei dem 0 zurück kommen sollte.