Could you add a TODO explaining your plans re commented out steps


Reviewed, everything's fine!


*Added new objects to utilize the designs of Banzuela.
*Added and modified the behaviors of card objects when a card is hovered a larger version of the card with card arts appears.


Since the package is never actually imported, this file isn't necessary.


OK! They have been removed.


Game-making process:

1. Environment creation:
As a beginner in creating a video game, I decided to start creating my game with the free assets in the asset store in unity to study how it works. At first, when I tried to create and design my own environment, when I placed new objects that weren't part of the first one that I placed, it kept falling through the ground. Due to this, I decided to find an environment in the existing projects in unity and looked for a video tutorial on how to set up the environment. Research led me to the Stealth project, and since it's setting looked a lot like an underground maze, I decided to use it as a practice for my game.
Since it was preset with walls and rooms already, my environment had its own collision mesh, and it no longer needed additional designs, so I set it up as it is, placed the preset lighting that came with it, and created some of the lights in the unlighted room area. I also added a bluish fog effect to make the environment look a little bit darker.

2. Alarms Systems implementation:
The alarm system implementation is more like a practice on how the player character affects her environment and C# coding.

3. Scripting:
Reading the Unity forums and watching some game developers create their games helped me in writing the scripts for my game easily. Using C# as the main scripting language, I was able to write down the scripts that I needed for the game. Almost all of them are implemented by myself, except for the Headlook and Character Motor scripts.

4. Player:
    4.1. Creation
           Using Autodesk Character Generator, I created all the characters that I used and would have used for my game, since rigging and skinning in Blender made it a little bit harder to animate and took too much time.
    4.2. Control
    4.3. Gun Rigging
    4.4. Animation

5. Camera Controls:

6. Items Animation:


* Created card objects which uses small sprites of cards.
* Adding behaviors per card objects. When a card is hovered it will pull up a little and when clicked it will show in the middle.


`for i, info in dictresult['jobs'].iteritems()`

and delete the next line


It seems to really not be so easy to get this behavior right... but this should help:

http://stackoverflow.com/questions/97459/automatically-select-all-text-on-focus-in-winforms-textbox


Uploading an image with spaces in it results in

`![1426624191257-sensor shield rev 1.6 pcb.jpg](/uploads/files/1426694730123-1426624191257-sensor%20shield%20rev%201.6%20pcb.jpg)`

Instead of encodeURIComponent we can maybe call utils.sluggify() that will convert spaces to dashes.

Which seems to display correctly for me.


some tests failed:
failure: http://build.servo.org/builders/android/builds/1076


* modified card behaviors when a card is clicked it will transfer to the middle and when another card is clicked the new card will be transferred at the middle and at the same time the previous card is transferred back to it's original position


Looks good, but I think we still have a problem with the content on that page.  We might have to switch up the order of phone_0_num and phone_0_desc.  I've asked @jameshupp to take a look at it


84696534-IntegrateValidationDocumentation (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Thanks for the suggestion, Joerg !


CBECC (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This change impacts V1 and V2 at once. @jackscotti any idea how to make it work for V2 only without doing something insane?


* Arranged the card at the game room to avoid some game bug like cards swapping and cards stocked after hovering on them.


Wups, I guess I did it again


@DanielWright Ok, this makes sense. I'll just want to re-enable this before going to production with any of this.


Thanks!!


Yeah, we can create a new *.md file for each upcoming issue, but maybe it should be made from a template instead of just being empty.

And ok to refer to Git Rev News issues as "editions".


I'd recommend since you already have lodash required using the `_.kebabCase()` function here and for the classify below using `_.camelCase()`


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.30](http://teamcity.monogame.net/viewLog.html?buildId=5754&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:14:57


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.31](http://teamcity.monogame.net/viewLog.html?buildId=5756&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This is another place we did not notice that may cause the seg fault bug.
But why is this happening? getting a version that has been garbage collected? or getting a version that did not exist ever?


@haonanlu


@scopatz, this is what I did


Here is a nice instruction how to use Travis together with Sauce Labs: http://sauceio.com/index.php/2013/03/building-a-ci-system-using-selenium-builder-github-travis-and-sauce-labs/ - Such a famous project like yours can also apply for the "Open Sauce" program which is free: https://saucelabs.com/opensauce/ - Let me know if you need help with the integration of Travis and / or Sauce Labs. I integrated both services for the company that I am working for. :smiley:


missing await I think.


Fixes #5


FYI:

```c#
// Return true for all characters below or equal U+007f, which is ASCII.
        private static bool IsAscii(char ch) {
            return (ch <= '\x007f');
        }
````

The CharUnicodeInfo.GetUnicodeCategory method seems to be highly optimized:
http://referencesource.microsoft.com/#mscorlib/system/globalization/charunicodeinfo.cs,c07c731d275fb0bb


87727128_GridViewInheritance (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2100 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.67%25-yellow.svg)


That lighbox typo of yours is nicely consistent! :)


If we were serious about making this a generic application, we probably wouldn't put the MOJ-specific code here. I don't think we are, though.


Ik zou verwachten dat dit een aparte tabel wordt omdat de data over de offset kan veranderen, terwijl geboortejaar dat niet kan.
- Naam "timeOffset". Dit is gebruikelijker. Zie http://en.wikipedia.org/wiki/Time_offset
- Zou je uren kunnen doen? Dit is de 'normale unit'.
- En als desc: "Time offset (h) subtracted from or added to UTC (= GMT0)."


Shouldn't the last three arguments' passed values to ``P_StartQuakeXYZ`` be converted from fixed to float/double or something?


I agree that it has value checking this. But I think a better way to do it would be as a post-condition in Erasure, not by overriding tyepdReturn and testing ctx.erasedPhase.


rax retry tests


`cluster = str(info.get('JobIds', ['Unknown'])[0])


Yep. Making this change now to docs and will push shortly.


TeamCity xBIM :: Xbim Essentials :: Release [Build 34](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1166&buildTypeId=XBIM_XbimEssentials_Release) is now running


and if is private? also uses the public one?


TeamCity xBIM :: Xbim Essentials :: Release [Build 34](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1166&buildTypeId=XBIM_XbimEssentials_Release) outcome was **SUCCESS**
Summary: Running Build time: 00:00:55


findById (177) requires Long but value here is String.  How to reconcile?


try adding these countries to the following file, it should do the trick and keep che code cleaner: https://github.com/alphagov/smart-answers/blob/master/lib/data/ukba_additional_countries.yml


`route_setting` was part of a big refactor that launched in Grape 0.10.x — if your app is still on Grape 0.9 or below, you can just use api-pagination 3.x instead of 4.x


87727128_GridViewInheritance (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Related to #53


further tests showed that it cannot find a column in the old_values_....

why is that?

@haonanlu


OK, you may keep it like this, no need to change.


The responsibility of the class is to persist measures, so I definitely agree that the test involves db.
Or rename the class if it does something else :-)


This PR removes description of --skip-install from help file. After this change users when typing `--help` will see:
```bash
yo aspnet --help
Usage:
  yo aspnet:app [options]

Options:
  -h,   --help        # Print generator's options and usage
        --skip-cache  # Do not remember prompt answers       Default: false
        --gulp        # Description for gulp

Description:

  Creates a basic ASP.NET 5 application

Subgenerators:

  yo aspnet:BowerJson [options]
  yo aspnet:Class [options] <name>
  yo aspnet:CoffeeScript [options] <name>
  yo aspnet:Gruntfile [options] <name>
  yo aspnet:Gulpfile [options] <name>
  yo aspnet:HTMLPage [options] <name>
  yo aspnet:JavaScript [options] <name>
  yo aspnet:JScript [options] <name>
  yo aspnet:JSON [options] <name>
  yo aspnet:MvcController [options] <name>
  yo aspnet:MvcView [options] <name>
  yo aspnet:PackageJson [options]
  yo aspnet:StartupClass [options]
  yo aspnet:TextFile [options] <name>
  yo aspnet:TypeScript [options] <name>
  yo aspnet:WebApiController [options] <name>
```
Thanks!


yup yup, that looks right to me!


There are two errors in this patch.

1. if you want check if a square is contained in a bitboard with the & operator following order is important:
bitboard & square
Other around this delivers another and probable not intended result, so use
border & s

2. The condition Pt != (PAWN || KING) is also not what you intended.
Correct is Pt != PAWN || Pt != KING.
But you can delete this condition  completely because the function evaluate_pieces is not called for pawns and kings delivers anytime zero (see around line 380).


I see, thanks for the information!


@nanaze sorry for missing that.  looks like the test is failing in 8, rather than the patch (note that 8 doesn't support array.prototype.reduce, and the patch didn't touch the ternary else function (now on line 356) that 8 uses).  the test i included would fail with the current implementation identically.

as it exists, the current implementation passes tests, but does not correctly implement the method, so i wonder if leaving the patch would still be preferable, while we update the existing alternate method (that 8 uses).  what's the best way to move forward here - should i try to patch the function used by clients that don't implement the prototype method?  lmk if any of the above is unclear.


84696534-IntegrateValidationDocumentation (lefticus) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-50.58%25-red.svg)


Links are incorrect. Please update.


90298376_ResultsViewerUpdate (macumber) - i386-Windows-7-VisualStudio-12: OK (2180 of 2194 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.36%25-yellow.svg)


Changed github username to "bencotte"
These files written Fall Semester of 2014 (August - December)


@Foggalong Oh I see. Thanks man! ;-)


FromRepoId & ToRepoId is an unique index, maybe it isn't a good idea?


Looks good to me


Pas du tout

2015-03-18 17:22 GMT+01:00 Dimitri Pertin <notifications@github.com>:

> Related to #53 <https://github.com/rozofs/rozofs/issues/53>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rozofs/rozofs/commit/ed73ed23265cb7297870f768b147b7da69d0f180#commitcomment-10267951>
> .
>

--


A little bit selfish, but I accept it


Зрозумів) перероблю на англійську краще


something blows up that cannot move pieces...


This not showing anything during boot on xperia amami, so is splash image in wrong format or something other related? Previous splash header worked?


Oops... I meant "Removed" :wink:


write d tuc


pwet pwset psezég"é. prout


Thanks for your comment. This is just a working branch where I've just applied 2to3 and I'll work on it later when I have more  time but definitely before F23


This commit also includes a refactor of insertRelationship to simplify the function. A hash was a reasonable
data structure when only storing subject, predicate, object, but adding objectType, subjectType and
datatypeURIs, plus multiple values for each of these, using a data frame makes the logic much simpler.


Looks like this would affect both V1 and V2. I guess I can make a note to move this to the yaml file when we publish this.


Actually, it only restores time sig on the staff you started from, leaving a hole in other staves.  Next commit will fix this to restore time sigs to all staves.


Chances are that if a python port is on Cheeseshop, it'll be happy with USES= python:autoplist,
and you can set WANT_PKG_PLIST to N


public and private here means, http or https. I guess it this is private should be https (so private)


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.31](http://teamcity.monogame.net/viewLog.html?buildId=5756&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:15:42


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.32](http://teamcity.monogame.net/viewLog.html?buildId=5758&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


yes, looks obvious. let's apply to testing.


Because of these modifications, if you compile with java 7 you get these errors:
[javac] synchrobench-master/java/src/arrays/lockbased/Vector.java:40: error: cannot find symbol
    [javac] import java.util.Spliterator;
    [javac]                 ^
    [javac]   symbol:   class Spliterator
    [javac]   location: package java.util

For files
java/src/arrays/lockbased/Vector.java
java/src/arrays/sequential/SequentialVector.java
java/src/arrays/transactional/Vector.java


simple test


re


q


Sorry for the random comment.

What are your thoughts on renaming this method `rotates_to_fit_into?`. As far as readability, you'd then be left with code like:

```ruby
if small_item.rotates_to_fit_into? big_bix
  # It fits, it ships
end
```


this was considered deprecated by @koobs a good while ago.
I'd set it to something that will error out ( /you/have/to/check/what/port/create/gives/you  or some such)


Btw those simple one-liners are probably nicer to put in-line (`echo "test ALL = NOPASSWD: /sbin/shutdown -r now,/sbin/shutdown -h now" >> /etc/sudoers) but that's just a detail...


Er is meer data in de UserInfo tabel dat kan veranderen namelijk: lengte(bij kinderen), gewicht, idOnPump en gender(in uitzonderlijke gevallen). Daarom wordt wanneer er client side iets veranderd aan de UserInfo server side een nieuwe entiteit aangemaakt inplaats van de bestaande gewijzigd. Ik vind het veel overzichtelijker om 1 entiteit te hebben met alle parameters van de gebruiker i.p.v alle los te doen. Dit is ook met synchroniseren veel makkelijker. Het beetje extra schijfruimte dat het kost (omdat er hetzelfde geboortejaar vaak staat) beschouw ik als irrelevant.

"Timezone" naar "timeOffset", minuten naar uren en description ga ik aanpassen.


a


this file should not be commited


TeamCity xBIM :: XbimExchange :: Build [Build 121](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1167&buildTypeId=XBIM_XbimExchange_Build) is now running


TeamCity xBIM :: XbimExchange :: Build [Build 121](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1167&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Compilation error: Xbim.COBieLite.SerialisationHelper\SerialisationHelper.csproj Build time: 00:00:20


Can you add mirage_key.mli?


Why the braces?


By the way, you can consider to integrate the test suite as [Lab-20](http://wiki.csie.ncku.edu.tw/embedded/Lab20) attempted to do.


Spurious.


ok... !?!?


хм...поидее если не указывать длинную передаваемых данных то он может непойми что передать...ну по крайней мере я всегда так думал.
а если в 52 строке тоже заголовок закомментить, можно он ещё тогда и страницу профиля получать начнёт???


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


90447068-BalancedExhaust-Issue4711 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1656 of 1659 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


You should validate the avaiability of the new tasks created by FreeRTOS.


I think you are right, and this should be simplified to just ```if(!s)```


84696534-IntegrateValidationDocumentation (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-ValidationDocumentation: OK (480 of 481 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.79%25-yellow.svg)


@rec
https://github.com/ripple/rippled/blob/develop/src/ripple/core/LoadEvent.h#L31 ?


```scss
/// Sets the gutter of an element
/// A value with a CSS unit used to create a gutter between elements
///
/// @type number
///
/// @example
///   $gutter: 42px;
```


all right … painfuller to set up though


Opens file in 'rb' mode as suggested in #299


Nice find :)


import path shouldn't look like this. please investigate why direct import is broken


I'm very tempted to remove as much as possible side-effect functions from the API (`add_to_*` functions were an unfortunate error) so I'd prefer this function to be:

```
val bootvar: ?doc:string -> ?default:string -> string -> bootvar
```

and modify `register` to be:
```
val register: ?tracing:tracing -> ?bootvars:bootvar list -> string -> job impl list -> unit
```

What do you think? Could even add `~opam` and `~ocamlfind` optional arguments as well to start deprecating the other `add_to_*` functions.


Why is this line inside the try block?


It's a missing template. We need one that has `.content_main` with no `.content_sidebar`. It'd basically be  https://github.com/cfpb/cfgov-refresh/blob/flapjack/_layouts/content-base-main-first.html without `.content_sidebar`


Thanks for this. I was just getting ready to submit a PR, and I saw that you had already fixed it. :+1:


so it is not like a diff thing?


BasicAppApp?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.32](http://teamcity.monogame.net/viewLog.html?buildId=5758&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:16:12


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.33](http://teamcity.monogame.net/viewLog.html?buildId=5760&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


tested it and its good to go..


test


sdfsdf


Why do you need this?


@cpw @bloodmc

Welcome back indeed. Come join us again in #sponge-dev :P.


Ok, here is the difference:

With the ```|| *s1 == 0```
```
tokenizing '**token*2***token5*xxx**' with * char using strtokm
0 - ''
1 - ''
2 - 'token'
3 - '2'
4 - ''
5 - ''
6 - 'token5'
7 - 'xxx'
8 - ''

tokenizing '**token*2***token5*xxx*' with * char using strtokm
0 - ''
1 - ''
2 - 'token'
3 - '2'
4 - ''
5 - ''
6 - 'token5'
7 - 'xxx'

tokenizing '**token*2***token5*xxx' with * char using strtokm
0 - ''
1 - ''
2 - 'token'
3 - '2'
4 - ''
5 - ''
6 - 'token5'
7 - 'xxx'
```

Without the ```|| *s==0```

```
tokenizing '**token*2***token5*xxx**' with * char using strtokm
0 - ''
1 - ''
2 - 'token'
3 - '2'
4 - ''
5 - ''
6 - 'token5'
7 - 'xxx'
8 - ''
9 - ''

tokenizing '**token*2***token5*xxx*' with * char using strtokm
0 - ''
1 - ''
2 - 'token'
3 - '2'
4 - ''
5 - ''
6 - 'token5'
7 - 'xxx'
8 - ''

tokenizing '**token*2***token5*xxx' with * char using strtokm
0 - ''
1 - ''
2 - 'token'
3 - '2'
4 - ''
5 - ''
6 - 'token5'
7 - 'xxx'
```

I think the first one is right (with the ```|| *s==0```   I think there is a spurious token being output for trailing delims if it is there.   I added that else clause to the if late in the process, but I think it is right.


whasf drunk for st pats eh


Why do we need to split lines? Can't we just check the last character?


Not a big deal, but you can also do

```python
from tests.base import fake
```


To be honest I'm surprised it took this long to be calculated this way. Always made more sense to me.


Absolutely


fast-forwarding develop to borshop-integration-463-bugfix/zl/sync-create-index = 5868266b


Great, thanks for picking this up so quickly!


Maybe we should send them to the more specific URL: http://girder.readthedocs.org/en/latest/python-client.html ?


Hey Cody, Whenever I'm in the lab at school, I can look at whatever else you added. I saw a few side notes you put in and I like the way you worded a few things so I might make a few changes on what I named things. It'll make it easier for me to understand. See you soon.


PyCharm made that, I've removed it.


@bennyn Thank you for heads up! I'll give this a try when I have some free time and let you know if you need help.


Thanks I did not make it lol...


a


no idea what  is going on here =S


asd


`UseMiddleware'


why this change?


Good You fixed so quickly !


Nooo popravde netusim, ako sa to tam dostalo takto odmazane. Nemal som v plane to odmazavat. Vratim to naspat :-)
Diky za info.


Thanks! I was wondering why I have texts and my testers don't :smiley:


Nice, thanks @jasonrclark


r+


When clicking on the links they just go to the raw image. Can we just remove the link and display the image instead or link to a page with some related content?


This would be better written as

```
if (dev_num < m_available_devices.size()) {
    return m_available_devices[dev_num];
}
```


Could cause division by 0.


@AlisVero лучше писать ```user_id { User.last ? User.last.id : 1 }```

а то тесты падают, потому что пользователя нет.


saw approval from jdm
at https://github.com/servo/servo/commit/cac1fad07630c443d41ba39468bac4ef7eee04cb


merging servo/servo/rustup_20150311 = cac1fad0 into auto


servo/servo/rustup_20150311 = cac1fad0 merged ok, testing candidate = e6989937


Ah, I left out a step. Can you delete this branch and recreate with:
```sh
git checkout --orphan gh-pages
git rm -rf '*'
git commit --allow-empty -m 'create `gh-pages` branch'
git push origin gh-pages
```

Same goes for `blist`.


Strings should get interned when they are resolved in the constant pool.


(No need to track the actual source code in this branch.)


Maybe we should keep the constant for legacy reasons?


This probably shouldn't be a property.  Accessing it has the side effect of "advancing" (calling `-[DisplayController moveDownOneLine]`).


With this implementation, there is no way to set custom headers.


Let's remove it?


Do we still want this console log?


You have removed the padding here (which is the right thing to have done) but you haven't replaced this padding anywhere, so the white space between the bottom of the last element in the manual and the print this page link is now $gutter when it should be $gutter*3


The MinkeLite defaults look good to me.


Uncommited in 216a84c.


I just copy-pasted the commands you gave. *shrug*


Вообще в списке топиков блогов и на странице конкретного блога. Там такая же ссылка на подписку как и в открытом блоге, но админу блога сообщение приходит с ссылкой на подтверждение или оказ пользователю в запросе.


No problem @mnelson. Note, though, that this is only on the `dev` branch and not in the 3.11.0 release that just went out. I noticed our deploy script was pushing more than just `master` and `release` out, which is why this showed up.

You can certainly feel free to test against `dev`, and this change should show up for release in a new agent coming soon. Will ping you back for real when that happens.


Added in fc12940.


Ah whoops only saw your second comment. Will do.


@livemixlove It looks as though lines 99 through 102 are no longer necessary? (i.e. span is loaded by Javascript rather than PHP)


It also works in 7 (at least it used to), hence the lack of version reference.


Would be useful to have some documentations as well :p


Had planned on a 90% rewrite, just want to make sure credit is given for the original work where its due


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.33](http://teamcity.monogame.net/viewLog.html?buildId=5760&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:15:24


Sorry I don't understand what you mean.
Here the 2 URLs are:
 - '/projects.json',
 - '/projects_xhr.json'


Planned on a 90% redo, if not starting from scratch, just making sure credit is given where due to the original work


onion stink


Good point, updated!


i dont understand  how can i work on this thing?


main/only change is on vpApi-services at 811 - $loki to id. I re-gulped to allow changes across entire services.js


84696534-IntegrateValidationDocumentation (lefticus) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-50.58%25-red.svg)


wow are we gonna get comments by TAs? Awesome!


90298376_ResultsViewerUpdate (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2105 of 2194 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.94%25-yellow.svg)


Same as https://github.com/bignerdranch/DemoMonkey/commit/2a117845823697e34ad0f263a1f1b827d3a801e1#commitcomment-10268730 .


90298376_ResultsViewerUpdate (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Maybe we need to build it differently then, this is a recent change in omnibus - we have to use the latest version to avoid other bugs - they added fedora dist tags to be compliant

https://github.com/chef/omnibus/pull/424

what do you think we should do?


This looks wrong, there is no `chanopts.fallback`, only `fallback` as far as I can see.  I think this line can be removed.


:shipit:


It is a command line arg currently, that's just for unit tests.
https://github.com/ActiveState/logyard-apps/commit/ed74fdf398584174dd9f7f6e211495df00eb51fd#diff-56727b88b26db588b65d5034eee34095R25


"Jorum"


commit名字打錯了XD 我要說的是map padding


It might look prettier to use a `continue` instead of an `else` (since it more clearly says "skip the rest of the loop").


:+1: The converter's rules work (mostly).


Is it any different from  `GetMethod` with `BindingFlags.FlatenHierarchy` ?


The name "mixed-safe" was arbitrary.  The directive could be called "unconditional", "no-mixed-content", "no-csp-upgrades, etc.


This has a lot of copypasta.


Updated!


What if that monday is a holiday. Would it make sense to keep that start
date as a monday? I forgot to ask during the meeting if it's always a
monday? We wrote the method so that we could take the beginning of the week
on the off-chance that the start date is a wednesday or something. idk I
could be going down a rabbithole here.

On Mon, Mar 16, 2015 at 9:34 PM, John Foley <notifications@github.com>
wrote:

> In order to avoid having to do this, lets just validate that the start
> date is always a monday.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/uncollege/fellow_tracker/commit/183a9acbbba7f1b9bf1a5a14acdc0a8328135f1f#commitcomment-10228506>
> .
>


shoots


Mostly as a note to myself: this `defer` is executed when the _function_ exits, so there may be up to three unclosed bodies (from the retries).


Indeed it can


@sayedihashimi for .gif files it creates a link for some reason *shrug*.  If it is a .jpg, .png the markdown does not.


Why is failing to read from a HTTP request a panic rather than a retry?


what is this about?


s


89224666-FixNANProblems-Issue4557 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1643 of 1659 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


16: M102 unrecognized bullet/signature
17: M102 unrecognized bullet/signature
1: M111 unrecognized component name: WebSubmit
3: M190 line is too long (74 > 72)


Out of curiosity, what's the relationship between the discard code there and [here](https://github.com/tangrams/tangram/blob/labels/src/styles/text/label_line.js#L121)?


* Changed "redisplay()" do "displayTime()"


some tests failed:
failure: http://build.servo.org/builders/android/builds/1077


Yes, agree on all of this.  Changed `add_to_bootvar` to `bootvar` in 47e75ab as suggested.  Should I also add the `?opam` and `?ocamlfind` (or `?packages` and `?libraries`?) arguments in this patch or better to do that separately ?


Let's remove `src` from library names


:+1: Begone, MRC!


89224666-FixNANProblems-Issue4557 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


$ns should be renamed to something like $pref


file should be opened with 'wb'  (see [warning](https://github.com/kennethreitz/tablib/blob/develop/tablib/core.py#L493-L502))


I don't think this buys anything. `mc.Object.Type` is a static type (for example `(object) "foo"` has static type `object` not `string`).

The difference I can see is that if we call a base method, with your change we are going to look for "static overrides" even though the there are no corresponding overrides. I don't think we want that.


Indeed, but that does invite another question - in the position you describe, /should/ d5 be scored as isolated and a lever?

In other words, if a pawn is passed or a lever, should we spare it the isolated penalty? I guess that is a matter for a different test...


ditto 'wb'


@rmcmx can you review this please?


Раз умножаешь умножение всё равно разворачиваешь, сделай каждый элемент в отдельное поле аля _00, _01 и тд. Со __slots__ будет эффективнее. Впринципе не обязательно.


This is introducing a critical bug.


Nice, I didn't see the call to *newStringConstant* in *resolve*


`get_device` uses `m_available_devices`, but everything here should be using `m_devices`. `m_available_devices` is only for listing devices available to be opened. Most operations can only be performed on devices that are added to the session, which are listed in `m_devices`.


this doesn't seem correct? Each schema should only contain the concepts with the according prefix (Not all of them).


Угол в радианах делай, градусы тока в UI. Можно функций написать для преобразований.


Majro > to odmazal terramax, to bylo spis mysleno na nej...ale ten duvod bude asi ten ruby tool nicmene, bych to spis odmazal az nejakym skriptem


This decision was made after pairing on the layout/spacing with Rebecca Cottrell @rivalee


why did you add a black king through this method "addPieceToBoard(ChessPiece.getBlackKing(), 'e', 8);" and not through using the array itself like you did by pawn("pieces[x][1] = ChessPiece.getWhitePawn();")?


I have this same issue, any chance of this getting accepted?


suggestion: take `time.time()` before these calls and pass the timestamp as an (optional?) parameter to both the write_*_csv functions, which will make maintaining association between the two files output by a test session that much easier.


Testing


Тут (not self) == other сейчас, надо not (self == other)


Also, if the library wants to be flexible for adding and removing devices in the session, using integer device indicies isn't a good idea because the devices will be reordered when devices are added and removed, and `m_devices` is a `set` so it's not really ordered anyway.


Also, where is your counter for whitePieces and blackPieces totals?


Updated, this method was refactored alot, initially was doing things a bit differently.


automatically generated


I think `?opam` and `?ocamlfind` are less confusing than package and library (as ocamlfind call them package as well).  No strong opinion to add them now or later.


might want to change this from a pure random to a sort of path finding setting


I guess we don't need "blah"? :)


Nice! You can simplify this code as below

```js
[layer.xAxis, layer.yAxis].map(function(ax){
  if (ax.type == 'addMeasureAxis' && ax.orderRule){
    typeof ax.orderRule == "string" ? s.addOrderRule(ax.orderRule) : (s._orderRules = ax.orderRule)
  }
})
```


I have no idea on what to do here, rather how to juggle between the different tasks.


To your first question, because I think it is clearer

To your second question, I didn't do that yet

On Wed, Mar 18, 2015 at 1:20 PM, reuvainsilverman <notifications@github.com>
wrote:

> Also, where is your counter for whitePieces and blackPieces totals?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/shmuelr/touro-mco152/commit/e786e19fe57519cb5ac53db3e47dc01a6ab6f692#commitcomment-10269300>
> .
>


r+


remember to merge this area of code with the most recent bit of code


the annotations will go into each schema. Maybe, we should create one main schema (without prefix) that imports all other schemas and contains the annotations? The main entrypoint if you want.


То же самое что с матрицей.


Hey @chrisrogers ! , I need your help here. The module-overlay is too small when there's no video to play. And also the notice that the stream is archiving can use some styling( I did try to set it white and failed horribly)


changed to private


I don't think this is going to work as expected if the session has multiple devices opened, because only one device is configured in this function and then `session->run` runs all the devices.


@mamantoha This version has a vulnerability. http://www.osvdb.org/show/osvdb/117461 Is it possible to go back to `>= 1.7.0` ?


Hi Denis,

There is no _drop_conn in "exp_duplicate_database()" like it was in v7.0:

https://github.com/odoo/odoo/blob/7.0/openerp/service/web_services.py#L195:L197

I created a PR to add it back: https://github.com/odoo/odoo/pull/5833

Tnx,
Jos


I'm not sure what should be locked, but using lock(lockobject) appears to work okay so I've changed it.  This code was mimicking that in the MWFVFS.WorkerThread class elsewhere in this file.


I checked with @rivalee before I made this comment so I'm not entirely clear what's gone on here.


As we decided on the doc, the utility team will define those

https://docs.google.com/a/berkeley.edu/document/d/1aJyOA94E5bDwzrIDPn_wh-LBV047MBQxtpL-o4tEtkI/edit#heading=h.76m4j13vea4m


:+1: Will be happy to help! :)


Тут лучше [Number](https://docs.python.org/3/library/numbers.html#numbers.Number)


I've added it.  I was going back and forth in my mind whether it should be included.  :-)


This is a little more than just a parser. I think a better name would be `TemplateCompiler`.


Let's drop 4 lines above


saw approval from jdm
at https://github.com/servo/servo/commit/5f15eb5fbfb7a8649132cc8b3a07314389836714


merging servo/servo/rustup_20150311 = 5f15eb5f into auto


servo/servo/rustup_20150311 = 5f15eb5f merged ok, testing candidate = 99cf9dbf


You could avoid this repetition (and support an arbitrary number of devices) with C++11 lambdas.


Тут стоит проставить assert что other это Number, умножение на матрицу справа запрещено.


Updated!


Avoid polling by using a condition variable.


Два раза length вычисляеть не ок.


Hi @tpietzsch. Sorry I needed to do task nbr 2 before task nbr 3 in order not to become crazy.


This isn't just bridging `NSString` to `String` though, the `NSString.init(data:encoding:)` is a failable initializer returning `NSString?`, and the compiler requires a forced downcast - with Swift 1.2 at least.


Well, this comment might be outdated in arm32 as well...

-[Unknown]


Добавь __slots__, меньше жрать памяти будет.


then should be on next line


A forced unwrap would also quell the compiler error.


I have a added back in $gutter*3 and amended the commit.


**(and emacs)**


Thanks!


Jaj tak mne dosiel mail a hned som myslel, ze to ja :-D


How about making this a `fixup` commit so that the next merging rebase fixes my faulty commit?


I missed it here.
Due to that the CLI with higher priority will block the  Logger task to perform the system log saving regularly,right?


I'm not sure using ThreadPool would really gain much in this context.  Not that many threads are being created, and those are not being created all that rapidly.  Since threading elsewhere in this file uses this approach, I'm inclined to stick with it.

I think that having the separate ThumbnailCreator class helps to isolate the code used by the thread.  For instance, the boolean variable "stopped" is guaranteed to be in the right initial state for each thread by this approach.  And again, this is the approach used by the threading elsewhere in this file and I'd rather keep things at least somewhat consistent.


Does the utility team know this? I am not sure that this was communicated
to them. I assumed that since you were in charge of returning canonical
trips, you would be in charge of returning all trip lists. For now, in
order to make progress, I'm going to define this.


:hammer: :hamster:


I considered that, but I wanted the initial refactor to be as much of a straight "code moves around" affair as possible. I guess it makes good sense to improve some things while I'm at it. I'll stack a commit on top.


Do we need to keep the comments?


LGTM


space before =


The main rule for line labels is to make them "fit" so the discard moves the label to the next fitting segment first. In the "abstract" logic of the discard, it will move it, whatever the label is (not implemented for point labels but we can consolidate later the place holder move_in_tile method for them), only if you want to make it fit inside tile boundaries. I agree that this actually has the same behavior now since we're currently using line labels that have to be inside tile boundaries, but the logic is different. In the case of using line labels that don't have to be inside tile boundaries, we'd have line labels fitting rule broken.


Space before =


Looks pretty interesting.

Could the names of the variables be kept instead of regenerated using names "x'", "x'0", etc?

I would personally have tried to code it in OCaml, maybe as a tactical usable around "apply_in_once"  in tactics/tactics.ml. In any case, this is a very good case study of how to program tactics.


Doh, forgot to remove that one :)


Looks good


Space after ,


I love lemons, but I love apples too.. :+1:


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.34](http://teamcity.monogame.net/viewLog.html?buildId=5763&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Do we need comment?


oh i am glad you like it..


Bit/Doge


Hey! :p  (Just kidding, I don't care)


Obviously! Added in 1f980a6.


Ах да, делай по дефолту единичную матрицу а не нулевую.


This will type hello world, that's it.


Revert


This looks to me like it sets teh affinity of the *callers* thread, and then later also sets the affinity for the new thread when it starts...


it can be good to know what bug.


No ei tähän kyllä pätevyysvaatimuksia tule vaan jotain ihan muuta.


if (pid && pid == getpid() && ... ?


Space after =


Yup this will work, though I would propose once Swift 1.2 is released that we use a failable cast for clarity.


The `uExpiration` field is the number of seconds since the Ripple epoch (January 1, 2000 at 00:00:00).

The only "reliable" time (i.e. the time that everyone agrees on) across the peer-to-peer network is the time when the last validated ledger closed. So we check expirations against that time.


I don't think we should define this here since it's not specific for repository connectors. Vicki, is there another place that has this information already?

If not, where do you think it should be?
I'm thinking that with each connector distributed through the marketplace we should say which versions of the "connected" software (Sharepoint, Documentum, ...) are supported. From this official documentation we should just link to the Marketplace page.

Thoughts?


I'd move the actual sched_setaffinity() into a private helper to make it clear that set_affinity() is a public method that can be called by any thread


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1654 of 1661 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


sometimes you use " or ' instead of having the same one all the time. Is there a reason?


It's not - it's from further down in `doApply` - a number of non-`tem` checks where interspersed.


That's robotto verctorised

—
Joel

On Wed, Mar 18, 2015 at 4:49 PM, Pierre Spring <notifications@github.com>
wrote:

> @lejoe Didn't you want to use Roboto?
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/swissjeese/logo.js/commit/3cd57c90d91b8144dfa10a858e7fbba2bf35f0aa#commitcomment-10267061


INCONSISTENT INDENTATION


add a @ruby=nil here to suppress the 'uninitialized variable' warning and this should be good to go


This way of adding searchable fields was deprecated in Wagtail 0.4 and removed in 0.6. Heres an example of the new format: http://docs.wagtail.io/en/stable/core_components/search/indexing.html#example


Space after ,


As mentioned above I think the documentation should just document how to use the Alfresco connectors and only mention versions if there are different instructions depending on the version. What it should do though is ask people to check the marketplace page (or wherever we decide to put the info) to check for the supported versions.


JUST USE BRACES


i punkt ist aber nicht viereckig bei roboto, oder?

On Wed, Mar 18, 2015 at 6:38 PM, lejoe <notifications@github.com> wrote:

> That's robotto verctorised
>
>
>
> —
> Joel
>
> On Wed, Mar 18, 2015 at 4:49 PM, Pierre Spring <notifications@github.com>
> wrote:
>
> > @lejoe Didn't you want to use Roboto?
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/swissjeese/logo.js/commit/3cd57c90d91b8144dfa10a858e7fbba2bf35f0aa#commitcomment-10267061
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/swissjeese/logo.js/commit/3cd57c90d91b8144dfa10a858e7fbba2bf35f0aa#commitcomment-10269750>
> .
>

--
http://nelm.io/pierre


Share this code with VB.


EMPTY COMMENT


This PR restores detailed behaviour that was removed (consciously, but a bit carelessly) by https://github.com/Metaswitch/calico/commit/70341e30e5914bcc964d1501a44aa7924707ae6d


Question: in language is hardcoded how can we set it to FR?


Just use CountExpression but allow the type to specified in the ctor. Switch on the type during SQL gen. COUNT_BIG seems to be SQL Server only.


This needs a more explicit feature check.


Should use 2 spaces.


(Pt != (PAWN || KING)) is incorrect. Should be (Pt != PAWN && Pt != KING).


I think you can `open Lwt.Infix` to just get these operators.


84696534-IntegrateValidationDocumentation (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-50.58%25-red.svg)


This method does the exact same thing as the above one. Could these be combined?

I prefer the implementation of the top one, but the name of the bottom one:
```
def get_blog_index(self):
    # Find closest ancestor which is a blog index
    return self.get_ancestors().type(BlogIndexPage).last()
````


Space after =


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/5703aeea1f9d66786ecdf81e30dd0d8d868608fe/app.js)


Ну в целом проблема из-за того что ты передаешь хидер Host, только с ним я получаю реджект.
Ну и да, я получил usess куку, но для этого пришлось много чего поправить. Могу скинуть к тебе на email исправленный код, но он требует доработки и вероятно правок, у меня руки кривые :)


@lukewaters Can you tweak this per my comment above?


Space after ,


The removal of line 20 and 22 in 3.3.4, is breaking my collapsing submenu.  It would still show the elements inside, even when it was suppose to be collapsed.  Reverting back to 3.3.3 fixed it.

Here's a code snippet in case it helps.

{{header.L1nav.0.nav_text}}

{{header.L1nav.1.nav_text}}

                        {{header.L1nav.2.nav_text}}

                            {{#each header.L1nav.2.subNavItem}}

{{this.text}}

                            {{/each}}

                        {{header.L1nav.3.nav_text}}

                            {{#each header.L1nav.3.subNavItem}}

{{this.text}}

                            {{/each}}


Put the cool off sleep time back in to avoid premature closing when the MiniEoR files arrive before the last lumisection, see discussion about run 238209 at https://hypernews.cern.ch/HyperNews/CMS/get/smops/822.html


This could be changed to ``BlogPage.objects.descendant_of(self).live()``


Space before {


Hope I can check this at weekend.

My personal experience of using github.com: I find the way how github handles notifications not optimal for me. Clicked once and looking somewhere else the notification is lost and its hard to find it again (must search for commits, issues, maybe closed issues etc.)

My personal wish is when I login back on a flyspray installation, that there is an icon informing me that since my last visit events happened (because I don't read the automatic notif emails). Maybe with a counting number like you know from facebook or a shopping cart counter on ecommerce shopping sites.

Then clicking on that icon it shows me the events between my last action from the last action of my last flyspray session. Ideally this is just a condensed event log. With condensed I mean something like

    WHERE "eventnottriggeredbyme" GROUP BY task_id

or

    WHERE "eventnottriggeredbyme" GROUP BY task_id, "eventtype"

and maybe using GROUP_CONCAT() and/or COUNT() for more condensing the events display.
(I don't know if postgresql supports such feature like GROUP_CONCAT(). It is a mysql invented non-SQL standard feature, but quite handy for some cases.)

The GROUP BY reduces the amount of redundant information. If on one task there is a lot of comments and changes since my last login it would still be enough to show me "5 new comments, assigned to jahto on task 123 title)

Using the events log doesn't need writing/deleting notification entries for each recipient.
But storing the timestamp of last login - or page view - or notification page view. Ok, this is not thought to the end by me yet...

Please take my writings not as affront, just as collections of ideas.


Why check for type function? It means that the code will fail silently if something else is introduced; I would remove the check since it makes the error more obvious.


90521284_GridViewDropzoneBulkDelete (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2098 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.58%25-yellow.svg)


instead of having to call render, you could rename this whole method to ``get_context`` and just return that dictionary in the 3rd argument:

```python
def get_context(self, request):
    ... (contents the exact same as before)

    return {
        'self': self,
        'blogs': blogs,
        'category': category,
        'tag': tag
    }
```


Both `aws-lambda-plugin` and `aws-lambda-jenkins-plugin` are now being published on the update center. Please open a PR to https://github.com/jenkinsci/backend-update-center2 (`src/main/resources/artifact-ignores.properties`) to clean up that mess.


Instead of a function called `callback()`, I would use an anonymous function here in the example, since the code is more compact and more standard. `statusCallback()` is fine as a named function.


:) glad I could help


What happens to the rest of the bxslider files I downloaded? I don't know where to put them or if they can be ignored for CC.


Can you please explain what exactly is going on there and what's the problem with the current code


Yep, should work also.


@mdboom This fixes the problem for me.


89224666-FixNANProblems-Issue4557 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (642 of 643 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.3%25-green.svg)


Thanks!


Space before }


This patch adds an option to the dropdown in bulk manual enrolment form. Initially, the enrolment period used to get reset to "unlimited" if default enrol period was set to anything more than 365 days. I have added an option "default" which show up when default time period is enabled by the user and value of "default" would be the default time period.


Rest of the files? You only need the css, js and images/*


For this commit, the package is not correct in the java files


Oh, in that case I'd just leave it as it is. It's not that big of a deal, was just wondering where the change came from.


saw approval from andrewjstone
at https://github.com/basho/riak_core/commit/8ca1b806c1dccc1c6053a3f8d706b3c530e6b9ae


merging basho/riak_core/feature/clique-0.2.6 = 8ca1b806 into borshop-integration-717-feature/clique-0.2.6


basho/riak_core/feature/clique-0.2.6 = 8ca1b806 merged ok, testing candidate = 2e72a68e


We need to pull the recent changes to Sensu plugins into ursula-monitoring and bump the this ref.


single quote


Thanks for this library!


90521284_GridViewDropzoneBulkDelete (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Though this achieves the thing we want visually you've now associated the space with the print page link where it should be on the manuals content. Let's get together tomorrow after stand-up and run through this (5 mins max)


Right, you got the point.


No space after function


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.34](http://teamcity.monogame.net/viewLog.html?buildId=5763&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:16:17


Few comments:
* Please consider 4b5f909 and 9d8954c associated with #749
* Check for the existence of the config file
* Instead of passing a complete different config file, it seems we want to inherit the main rules and allow each plugin to specify there own. This should already be possible with `jshint`. For jcsc, the developer are working on it. See https://github.com/jscs-dev/node-jscs/issues/73


Space after if


In the current callback per signal implementation, where would the notification be sent from to trigger the condition variable, i.e. will the signal callbacks always return in the same order?


What do you think of doing something like this instead?

``` elisp
(setq ivy-history (cons ivy-text (delete ivy-text (cdr ivy-history))))
```

That way re-performing a search will move it back to the front of the list.

Also, you could get the `isearch`-style `C-s C-s` to repeat the last search by modifying `ivy-next-line` to something along these lines:

``` elisp
(defun ivy-next-line ()
  "Select the next completion candidate."
  (interactive)
  (if (string= ivy-text "")
      (previous-history-element)
    (unless (>= ivy--index (1- ivy--length))
      (cl-incf ivy--index))))
```

I'm really enjoying `swiper` by the way - thanks!


Single quote


Cool, how do we do that for jshint?


This actually adds a dependency between authentication and cache, and doesn't provide an easy way to pass a cache object to the authetnication policy.


Enduring Scalelord's Add Counters ability is a may ability. Currently having two on the battlefield and adding a counter to one creates an infinite loop.


No space after ( or before )


... to visualize a cut through the gradient field. That is to see, whether the gradient field looks like intended.


Put var at the top


It depends on the use scenario how `system_logger` behaves. That is, the accuracy of system statistics we expect. Please always consider the effects of kernel preemption.


No space before )


This is a really great change, @pablo15


@psvmcc так вроде вы кроме как на https ничего особо и не меняли...только в 57 строке ошибка у вас - он в "простом" режиме никогда у вас куку не найдёт.
В общем пусть кто то ещё попробует заменить http на https и закамментить заголовок, у меня, к сожалению https лоста не пашет из-за провайдера :(


There's no requirement to use `namespace test`. Its useful when you want to make public a set of types and functions at namespace scope (e.g. common_ledger.h). and use them without namespace qualification.


What's this?


There is no opening and closing brackets { } for the if and the else


double space. No space after ( or before )


`BEAST_DEFINE_TESTSUITE(Path, app, ripple)`


Good catch, i'll secure this !


https://github.com/NodeBB/NodeBB/commit/3ed3612047c4f115da9bafc7aaaefd0ab19ec430

if you're cherry picking this commit (recommended) don't forget the ajaxify bit, because otherwise it will only work if you open the attachment in a new tab


ok


What is the grammar production that cares about this?


Remove blank lines


Done.


We do not create enum classes with only two members intended to replace `bool` anymore. Please end this practice immediately.


In order from top to bottom, right? I would mention that in the comment here


consider reformatting the line (e.g. space is missing after semicolons)


Also, should this be on Node or Declaration?


Also added some documentation to `Mirage_runtime.Configvar` in 57f6c2d.


The io util or marshaling/unmarshaling errors could indicate EOF or data mismatch(bad UTF,etc) errors, without that stage, program would be badly broken, I just don't see trying to call the API again using this poor man retry policy would fix that situation, so easiest thing would be to fail fast. However I do agree in retrying but not this retry policy something more intelligent and more complex.


@scottschurr Would you prefer `tx_json[sfFee::jss] = std::to_string(10)` ?


Why would you do that?


Right now, the parser does not make nodes for tokens like this. Is there a particular reason this is necessary?


Space after if


OK, this is nice, but prints out lines in the format
PHI/PSI ResName First_AtomIndex_of_the_Angle

though for cosmetics, it would be more convenient to have the following:
PHI/PSI ResName ResID

Thanks


Why?


No opening and closing bracket for if and else


This corrected the issue with turbolinks.


No space after ( or before )


> What do you think of doing something like this instead?

Nice idea, thanks!


Exactly. You read my mind. Or 2 different tests ! Do you have time for this ?

Lever is not a long term feature
Passed and Isolated are not
We can only speculate if it will make any difference or not, so this needs a test.
(Or maybe it has already been done)


looks good :)


No additional functionality, Jon?


Ah.  Thanks for that explanation.  So, yes, for these purposes the time comes from the ledger.  So the actual expiration check must wait for `doApply`.


Нам нужны ещё __sub__ и __negate__


All solutions added


А ещё dot и cross


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1545


I am preparing the push... please wait...
dinner..

From: Bruno de Lacheisserie
Sent: Wednesday, March 18, 2015 6:36 PM
To: LK8000/LK8000
Cc: Paolo Ventafridda
Subject: Re: [LK8000] WindowControl : move coordinate calculation From "AddClient" method to new "CalcChildRect" method (537a1e8)

it can be good to know what bug.

—
Reply to this email directly or view it on GitHub.


saw approval from andrewjstone
at https://github.com/basho/riak_kv/commit/ac2eed7377b185a8f1133d9a974a97a7fa8b73e5


merging basho/riak_kv/feature/riak_kv_quanta = ac2eed73 into borshop-integration-1092-feature/riak_kv_quanta


basho/riak_kv/feature/riak_kv_quanta = ac2eed73 merged ok, testing candidate = f2b3188f


la classe HtmlButton a une méthode onClick...
$bt=$bootstrap->htmlButton("btMasquer","Messages...","btn-primary");
$bt.onClick($this->jquery->getDeferred("project/messages/".$id, "#ZoneMessages"));


danger here with `log`, this usage has not been vetted. Although its certainly something we should support. Proceed with caution


Why are we removing these variables?


Why are we adding custom gutters?


Indentation?


Well, mostly it's because when you have to execute merges to review and ultimately approve PRs, you often get conflicts in composer.lock (because everyone has a different version of hash). These can easily be fixed by not including composer.lock, as everyone re-generates them with composer update *anyway*


I'd rather have `format[1] = '0' + digit_count + (relative ? 1 : 0)` here, seems a little simpler to understand


Just overlooked it, did a `git checkout master grid.scss`


No need to mention `IMPL_` in the include guard but why are we calling this RipplePathFind.h?


57ю я специально так сделал, тк оно не уходило в hard, и соответсвенно не получало usess. По причине того что на том этапе передаются тоже куки:
```Set-Cookie: __cfduid=deblablabla88; expires=Thu, 17-Mar-16 17:58:08 GMT; path=/; domain=.lostfilm.tv; HttpOnly```
Там не только https, еще оно давало редирект без **www.**, https я добавил изначально, оно не влияет ни на что, убрал на http, и получил нужные куки :)
gist обновил


(and the conflict appears *after* you did a git pull of a PR, but *before* you can do a composer update :-) )


This the the first markdown file in the repository datasciencecoursera.


I can remove them -- I figured that it's just a mixin, and makes our grid a lot more flexible to use. I still think that something like this might be what you're looking for in order to make the respondent view layout look "right".


Guys, today I was working with an artist at the Citilab who's making a project with BeetleBlocks, and I noticed this color scheme has issues when you start embedding blocks... take a look at this for instance:

![image](https://cloud.githubusercontent.com/assets/1016697/6715820/7d5bb5c6-cda1-11e4-862f-34bc216a6ce9.png)


Besides the ternary operator comment, looks nice, can you fix that and I'll merge it.

Thanks a lot for working on that !


OK. Makes sense. Thanks for doing it.


(Just as an example of their usage.)


This is due to the fact I don't want infinite lookahead when parsing a decorator, just to determine if what follows is a valid declaration. With out it, isDeclarationStart would see an `@` token and assume a declaration follows and when the token after the decorator isn't a valid declaration we would fail in a number of places. Instead, if the thing that follows the decorator isn't a valid declaration, I attach the decorators to an `IncompleteDeclaration` token, which I then report as a grammar error during type check.


@dmak78 this page is a good example of where we're following article-to-article linking instructions, but the `gulp kb` task is still generating links resulting in 404s.

All of the links while browsing on Github.
All of the links are broken while browsing on centurylinkcloud.com.

Are we missing something?


We have to remember to update this to the dakar connect stuff in the end :)


it's... generated :/

Origin is `timedata.cpp` and we'll have to patch that in order for it to be generated here properly, so propose to not have that block this PR.


OK.


Ну в общем надо проверить - если заработает - я напишу нормально, что бы и простой способ тоже работал


90298376_ResultsViewerUpdate (macumber) - Win64-Windows-7-VisualStudio-12: OK (2178 of 2194 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


I think I'm mistaken; I can't actually reference `monodoc.dll`:

    $ mcs -r:monodoc g.cs
    error CS0006: Metadata file `monodoc' could not be found
    Compilation failed: 1 error(s), 0 warnings

This is because monodoc.dll is installed in `$prefix/lib/mono/4.0` on OS X, but `mcs.exe` is in `$prefix/lib/mono/4.5`, so it can't be easily found...

...unless you use the monodoc package:

    $ mcs -pkg:monodoc g.cs

So I'm kinda right, kinda wrong?

Then there's the question of how "stable" `monodoc.dll` is. IIRC, we've previously stated that it's not a stable API, but that doesn't alter the fact that it *can* be used without too much difficulty...


appearently this is useless: https://github.com/Itseez/opencv/blob/0b99f6bcd63046a0465c397c2770ad43a48cd0ff/modules/core/src/system.cpp#L781
and probably the cause why #1240 still happens


Will this mess up scripts that look for the first ERROR line in logs? I'm not sure that its all that relevant as we don't see a lot of "failed to validate workflow" errors in the build czar logs but would something like `$self->error_message( join("\n", @errors));` be better?


develop (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1151 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


> How would you recommend moving forward here?

This is why MSDN suggests using abstract classes over interfaces. ;-)

That said, I'd suggest keeping the interface unchanged, then extending the interface via an `internal` interface, and use the new interface where necessary. I don't know how viable that is. :-(


:laughing:


No worries, I'll continue working on a makara solution regardless of the rpm <> makara situation.


Why would you do that?


This didn't fix the issue of destroying/starting... :sob:


not ID = key?


It would be better to move the CSS to an external file rather than adding to the weight of the page.


Ok, thanks.

Are you in a refactoring state right now? If so, you you give me a "ping" in the forum when you feel it safer to pull master again? I will do some more testing on out stage environment this time. Promise ;)


The `_domain` suffix in the domain is a bit redundant :)


I use this in parseCallExpressionRest to opt into a slightly more expensive lookahead when parsing the covering grammar for decorators preceding a ComputedPropertyName. Consider:
```TypeScript
class C {
  @dec ["test"](p: number) {  }
}
```
Normally, parseCallExpressionRest would greedily parse the decorator expression as `dec["test"](p` and report an error when it encounters `:`. Instead, when [Decorator] is set, I do a much smaller lookahead to try to parse a signature and avoid a parse error.


90447068-BalancedExhaust-Issue4711 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1644 of 1659 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.1%25-yellow.svg)


I think it has:

http://tests.stockfishchess.org/tests/view/532cf7e70ebc5906b1e85e04

..and some similar tests. All indicate that passed pawns should get the penalty.

Coming back to stranded, It's interesting that the first take failed SPRT by being a 0-Elo patch. But halving the penalty was an Elo loss. It implies that maybe the idea is conceptually valid but you lose as much from the extra computation as you gain from detecting the condition.


> Also, you could get the isearch-style C-s C-s to repeat the last search by modifying ivy-next-line to something along these lines:

Also very good! I've added this modification.


hi - I was just trying to run the toshi tests - even with this update, i'm still getting:

`rspec ./spec/toshi/regression_spec.rb:44 # TheBlueMatt BitcoindComparisonTool should complete successfully`

which seems the same problem as the main brance - is this something you were encountering and then fixed?


The classname should be capitalized per the coding standards https://make.wordpress.org/core/handbook/coding-standards/php/#naming-conventions


I just pushed some breaking changes to all themes for 0.7x yesterday (and updated vanilla and lav). As far as I can tell everything seems fine but still needs a bit of testing. That said, it's probably not "safe" until we hit 0.7x :P


Comment xD


![ap model before texture](https://cloud.githubusercontent.com/assets/11542034/6715966/4f2a3e4e-cd5f-11e4-971c-63170eef75a9.PNG)


fast-forwarding develop to borshop-integration-717-feature/clique-0.2.6 = 2e72a68e


I added it to Node as modifiers is also on Node.


Just in case it got filtered - I sent it to your samba email - let me know you want me to send to another email of mailing list.

Thanks!


When escaping URLs, it's better to escape the entire thing rather than the piece you're appending, e.g.

```
echo '<li><a title="Facebook" href="' esc_url( 'https://www.facebook.com/' . $facebook_username . '/' ) . '">' . '<span class="genericon genericon-facebook"></span>' . '</a></li>';
```


Just to note this commit will need to be altered so that it contains only the new modules (Email-MIME, Email-MIME-ContentType-1.017, Email-MIME-Encodings, Email-MessageID, and Mime-LITE), no removals, so that this still works okay on older OS versions.


May I suggest using JSON as an output format for the text, so that it's possible to machine-consume it, if so desired w/o special processing?


@vinniefalco: It's not necessarily a preference.  But elsewhere I have set `SFields` in JSON objects like this:
```
tx_json[sfFee.getJsonName()] = std::to_string(10);
```
But not all JSON fields are available as `SFields`, so I can't do that consistently.  I like getting the name from the `SField` when possible.  The `SField` is closest to "the truth".  But that approach means some strings come from `SFields` and some from `jss`.  That feels inconsistent.  So I haven't got a great answer.


This method is missing proper indentation.


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.33%25-red.svg)


I added these tokens so that I can refine the covering grammar for ElementAccess/CallExpression and ComputedPropertyName. I need the actual offsets for these tokens when I refine an ElementAccess into a ComputedPropertyName and a CallExpression into a Signature. See `extractDeclarationNameFromDecoratorTail` in parser.ts


Also, you have the facilities of stringbuffer_t lying around, why not use that instead of fancy string arithmetic?


Please return these changes.


See https://github.com/Microsoft/TypeScript/commit/5db3b0d904b3448da48e5e2c821d34f9f970f316#commitcomment-10270601


Agreed, I'll fix.


I believe that the whole message can be constructed in `MissingPropertyException` class since it is specific enough.


This was to save having to loop through the population checking if the
parent was equal to each member in replace parent. But I was thinking it
was using the organism == operator when it was probably just comparing
pointer values so I guess it wasn't as big of a deal as I thought.
On Mar 18, 2015 11:03 AM, "Akiira" <notifications@github.com> wrote:

> A pointer is a four byte word and an int is a four byte word so I don't
> think we are saving anything by this. Actually it makes it worse because
> now we need to look the index up in the array. This should probably be
> undone unless there was some other reason besides efficiency for this.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Akiira/Comp-524-program/commit/4c9f08ff8a6d9c97c16c42c68e37ab2a708f4323#commitcomment-10265904>
> .
>


please revert this until a  better solution is found. it is currently leading to incorrect cleanup of the console when a lot of foreground color changes occur.


Or, since this is in the context of a PgSQL extenion, the PgSQL stringInfoData stuff in src/include/lib/stringinfo.h (death to manual string fiddling!)


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1044
success: http://build.servo.org/builders/linux2/builds/1044
success: http://build.servo.org/builders/android/builds/1078
success: http://build.servo.org/builders/mac1/builds/1260
success: http://build.servo.org/builders/mac2/builds/1260
success: http://build.servo.org/builders/gonk/builds/231


The first `error_message` should be exactly the same as it was before (unless we previously got unlucky and it contained a format string!).  The difference is that now the other validation errors aren't dropped on the floor.

A quick grep of the code suggests two prevailing patterns:
```perl
die('Errors encountered while validating workflow: '. join("\n", @validation_errors));
```
and
```perl
$self->error_message(@errors);
die "Errors validating workflow\n";
```

That second one is clearly bad (hence this commit).  The first one isn't an `error_message` at all, but produces more useful output.

Maybe we should standardize this somehow.  There's a lot of copying and pasting involved here!


ack


I forgot remove it.


I needed to change this because I needed to get the node with position and the orientation defined into URDF file. If I get the visual node, the position and orientation will be zeros.

gazebo_model plugin uses getModelName.


LGTM


Тоже недавно lostfilm повторно отвалился, попробовал закомментировать `386` строку — ожило. Спасибо @psvmcc


Sure


fast-forwarding master to auto = 99cf9dbf


There is a data corruption bug somewhere after 0.22.13, this change look suspicios, so I started to eliminate possible roots. Also, I do not really see why it was needed at the first place - there is nothing at startup time which introduced overhead (no cache, empty logs).
Why was it needed?


Sorry, I am used to puts simple gets and sets into headers.


This


90447068-BalancedExhaust-Issue4711 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1644 of 1659 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.1%25-yellow.svg)


Thanks!


Ah, handy - thanks!


If think we should lookup MemTotal to have the available memory not MemFree.


Need to mention SAM constructors: `Runnable { ... }`


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/1930


Can I ask from where did you get this?


s/Fenerates/Generates/


You shouldn't need Auth. Just the User. Correct me if I'm wrong


This will block if nobody is reading the events. Thus `stream.Close()` will block indefinitely.


So (isolated & !passed) was not good.
How about (isolated  & !lever) ?

For your stranded, If 1/2 was fare and 1 was bad, then I would definitively try a 3/4.

I saw your new test, which actually gives a higher score in many case, and generally a lower score in the endgame compared to the full isolated penalty.


@borshop merge


90447068-BalancedExhaust-Issue4711 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I mean it.


Для тех кто не хочет править руками, можете проверить из моего дерева https://github.com/psvmcc/TorrentMonitor, если все будет ок у всех, надеюсь Евгений вернет lostfilm к себе :)


Wouldn't an early EOF / corrupt JSON be something that might get back better results on a retry?  I guess I'm used to things that travel over the network (even on loopback) being something that could possibly give back random junk and program against _that_ defensively.

At least, I figure `log.Fatalf` (which would at least give a message about why it failed, rather than a traceback) to be prettier.


Should we check that /proc/meminfo is available ? /proc could have not been mounted.


Done: #2242


add space


spelling error on canola!


maybe be an class attribute what do you think?


add space after if and before bracket


`AbeInputS`  should be `AbeInputs`


I don't see this `notifyOwnerOngoing()` method anywhere.


`AbeInputS` should be `AbeInputs`


@mjwitte Looks like the humidifier sizing change is throwing these diffs.  Seems ready to go in.  Shall I merge?


CBECC (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2037 of 2157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.44%25-yellow.svg)


r=Manishearth


Shouldn't we still allow someone to pass in their own codec?, I know that was the intention here but not sure how practical it is in practice.


Can you please disable selenium by default? This breaks travis.


Comment seems not really updated. Some upper case is still present here.


r+


Does the given service is managed by an upstart job?

Is the given service managed by an upstart job?
or
Does the given service get managed by an upstart job?

The first one seems nicer


Can buffer the Stream.Events channel to give some leeway, but why would a client create a Stream and not read from Events?


saw approval from Manishearth
at https://github.com/michaelwu/servo/commit/2f999ec728510838096a12d310abed77efaeb5f2


merging michaelwu/servo/enable-b2s-pie = 2f999ec7 into auto


michaelwu/servo/enable-b2s-pie = 2f999ec7 merged ok, testing candidate = 4dc5287b


Why not just close the channels? Then it's safe to be called as many times as you want.


Everyone of your ideas is worth thinking for the future. Problem being: can't be implemented now, even adding the timestamp of your last login or some kind of counter would mean database schema changes again. Strictly a no-no-never-ever at this stage, have to wait for at least 1.1. So I must do the work with what's already available there. And because of that language issue, I'm even myself suggesting postponing this to the inevitable 1.0.1. after already writing otherwise quite functioning implementation. Maybe not exactly to your taste, but a working one.


Dodane:
-Wyswietlanie postaci
-Poruszanie postacia


Is there a case where `INFTIM` is 0? If not, then we should write `if (!rc && timeout == INFTIM)` here, correct?


@diogob It looks like my inner front-ender really wanted to refactor some javascripts. A lot better now. Thank you for the tips.


Maybe the client has been reading events, but decides it wants to stop. So it stops reading from the channel (it's about to call `stream.Close()` but hasn't yet) Then the server sends down some events, the goroutine processes one, and sends it to the `stream.Events` channel and blocks. Then the client calls `stream.Close()` and is now deadlocked.


When using npm I do not get the latest version... Is this because you did not change the version number? If so, could you please change it?


Still has quotes in other 2 lines


@nathanyoung It is perhaps that I am missing something. Can you point me to an article that has broken links to other articles? This comment is on the README of APIDocs but you referenced running `gulp kb`. There may have been a legit bug introduced when I refactored to get the article-to-article links working for APIDocs, but currently I run `gulp kb` and the generated pages seem to have good links to other articles.


I actually install epel as part of my tests. So I can remove this epel install altogether.


That'd be excellent. Please do this in this file, and remove it from the other kickstarts lying around, thanks!


I see the same issue... Line 452 is tryig to read the undecayed lhe file from processtmp. I would remove the line 442

rm -r tmpprocess

since tmpprocess folder is not going into the contents of the final gridpack tar file


Sorry, forgot to include this: http://staging.centurylinkcloud.com/knowledge-base/blueprints/centurylink-cloud-public-blueprint-packages

At this point it feels like we're getting inconsistent results when we follow the instructions, and it's resulting in a lot of 404s.


The main idea was to prevent user induced errors but you're right, it's much better not to fail silently.


CBECC (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Yeah, we probably should come up with a 'best practice' of some sort for multiple error messages, but it doesn't have to be part of this PR. That seems like a different issue altogether!


Nit: Use a different name? This looks like you're declaring and assigning twice.


This line lost the changes from https://github.com/ksmyth/superagent/commit/fd6ea137ff4ab5ac75ed203cd2c1f0e03437d83d


Thanks.  See liqd/thentos#15.


this was my guess at how to do this. let me know if it is incorrect


ф


One of the common mistakes/issues/confusions that we'll inevitably see is that users will not know what their username is or attempt to add the entire URL (especially with Facebook, where they've de-emphasized usernames). It would be nice if the inputs allowed the username OR the URL.


again, more guesses...


not sure how to do multiple field here.


Should this still be `manifold` when used in code? Is this an accidental 's/manifold/Manifold/g'?


more guesses...


ready for review/comment. I didn't submit the PR because I figured it was worthwhile figuring those out first?


It also breaks the tests whenever you're not running the selenium server, not just on travis.


Excellent


@Myoldmopar @jasondegraw is reviewing this, I believe.


@no-reply can take a look at this when he is ready


Cool thanks I am looking into it. I may very well have given erroneous instructions regarding the formatting. I may have conflated instructions for APIDocs versus Knowledge Base when I revised the READMEs this morning and when responding on related issues. I will look into it and follow up with accurate instructions on formatting. Stay tuned. Sorry for any confusion.


Yes


Ah, so this is for manual testing, rather than being driven by the automated tests?


Perfect


One other thing to think about: the data for each widget is self-contained. This means that if I want to social widgets (one in the header, one in the footer), I need to maintain two copies of the widget, which isn't ideal (I have to remember to update both any time I make a change).


Oops. Yes, thanks.


@pythonesque we should be using [semer](http://semver.org/).  In that case you should have set the version to 2.3.1 instead of changing the major.


@d4weed @apercas @mbarrenechea  Would one of you mind merging this?  Gracias!


That's the idea, to tilt toward the middle game. I think that it is easier to "un-strand" a pawn than "un-isolate" it.

And in my case, 1 was fair but 0.5 bad. Which logically would imply going > 1, odd as it sounds.

btw No-one appears to have tried the  (isolated & !lever)  idea so far, at least going by a search on fish cooking results.


No, I think `0` and `INFTIM` are orthogonal.  glibc's `poll(2)` makes this explicit:

> Specifying a timeout of zero causes poll() to return immediately, even if no file descriptors are ready.


Where ever you end up, we'd like the API and KB should follow the same link convention.


Thanks ! It used to be that those couldn't be managed by ARC.


Can you use strong instead ?


One more thought: there's a fair bit of repetitive code, especially relating to each individual service. This means that adding or removing a service would involve touching a lot of code. It would be good to refactor things so that adding a new supported service could be as simple as adding a new entry to an array.


ditto


This call can potentially get expensive if the site has a lot of widgets and sidebars and will run every time the widget is registered (which is every pageload). Might be better to move the enqueuing hook to be called in the `widget` method instead and queue the CSS in the footer.


Right.


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/import.lib.php


Please add a test that selects a subset of the topics in a category, and that verifies upon save (and subsequent reload) that only the correct subset are selected.


`esc_html` is a better choice, since we're not outputting the title as an attribute, but rather as text.


I would suggest something like:

```
[juju] add generate-bundle option

Add a 'generate-bundle' switch to optionally collect a YAML
bundle of the current environment using juju-deployerizer.

Signed-off-by: ...
```

You should also test for success in `generate_bundle()` before assuming that `'output'` is valid.

This is likely not acceptable:

```
+ if not self.check_ext_prog(program):
+ self.call_ext_prog("pip install --system juju-deployerizer")
```

Remember: we are printing a banner that says:

```
No changes will be made to system configuration.
```

That line would appear to make that claim into a lie...

Personally I find the long option names juju is using a bit ugly & cumbersome for manual use but they are in keeping with what the plugin has already...


Agreed.


Ah, looks like a later commit fixed this.


It is really ugly! Please don't write code like these!
You should create your own state machine for command parsing and reordering.


@Soldez this is perfect.


ソリューションほしいですな、フォルダとかファイルを追加したとき、他の人もソリューションいじらないといけないのはめんどくさいです。ω。


https://gitorious.org/rubi/bathos/commit/849ea90082bf97ff92936433b9465394f6644ba1
Following the solution in that link. Add `*` on the right side of `.rodata` in `main.ld`.


Ah, I think you meant to write `if (!rc && timeout && timeout != INFTIM)` here...! Yes, that makes sense now.


Extra newline


@Soldez you can combine these two lines `return number1 + number2;`


@harsaharsa current code shows different api behavior between ios and android re. expected failures.  Is this temporary?


The commit message ("Update social.php") isn't super useful to me or future Chris Rudzki. Some suggestions on better commit messages: https://vip.wordpress.com/documentation/commit-messages/


@Dorimanx, you will require to check which code requires qcom,memory-reservation-type
I believe MDSS code will be doing that.
lollipop-caf branch has latest mdss code where this kind of reservation maybe not required.


@Soldez this can be reduced to one line too. always simplify. less code - better code


In Git's source code, they established a useful rule to write the shorter case first (is easier to read):

```c
timeout = elapsed >= orig_timeout ? 0 : orig_timeout - elapsed;
```


Because flushing empty cache at startup time is useless. Flushing cache consists of iterating all keys from index and removing them from cache. Since cache is empty at startup time it will waste time on these operations.


Please add a test like:

    it('saves correctly when a subset of topics are selected within a category', ...


Fixed in 33959b986c05843018f900f04f8ade2c5e572633


Yes, sorry, you're right. Will do that in just a moment.


nice :) seen the entertaining presentation from the author from 8 years ago? https://www.youtube.com/watch?v=4XpnKHJAok8


"hood"? :P


try the descending sort.


Gah, I did, copy/paste error.  Apologies.


Last comment for now: I imagine that `if (!rc && orig_timeout && timeout)` would be even better because it illustrates that we only want to use this conditional if `orig_timeout` has been set, i.e. if the conditional code above has been run.

It is true that `timeout` is only possibly re-set to 0 in the code between. But that is only obvious after a thorough analysis, while it is obvious that `orig_timeout` (which we just introduced) is not touched in between.


Are you using activator in this project?


I arrived 14 minutes too late with the same fix :D


Just to be sure, this supports all the other types too? Like `number` and `boolean` ?


Perhaps a more expressive title would be nicer (e.g. "View $username's profile on Twitter")


Looks good. Maybe add a test.


Yes


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1660 of 1662 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Thanks! I'll take a look at these later today.


Thank you, but I'm still not seeing the updated version when using npm install..... any ideas?


That was by design.  If you want to not run the full test suite, the documentation says what you should do.

I'll see if I can fix this with cabal.  Move this discussion to the pr?


Nice optimization! It took some time to realize that casting an int to uint will create create an overflown uint. This is needed to handle negative values. As this is not very easy to spot, I'll add a comment explaining the optimization technique.


This should be:


There is no "logical implication"

One needs three points to get a better  idea.
If it's a straight line, you are right.
But it could be a bell shape curve. 0.75 can be the optimum, and dropping faster to the left.


And this:

        "VALUES (%u, %u, %u, '%s', '%s', '%s', '%s', '%s', '%s', '%s', %i, '%s', '%s', %i, %i, '%s', %u, %i, %i, %i, %i, %i, %i, '%s', %i, %i);",


This bit is only reformatted to find a missing closing curly bracket: in the original version, `\mathbf{A^{-1}` was only closed in the very end of it, by `\right].}`


s/recomment/recommend/


90447068-BalancedExhaust-Issue4711 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (641 of 643 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.27%25-green.svg)


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Please, use github issues/pull requests/trello for discussion your assumptions, but do not make changes and version based on them.


+1 for this


Remove this extra space. It'll slow the code down. :trollface:


ddddd


I get
   ` RuntimeException: Unknown animator name: alpha`
when I try to launch the app on Genymotion emulator.


We will have to change a bit of the elastic search classes to suit purposes of our app


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/44df8f6a8cabb812b3c90c59a9191849d36337d4/app.js)


Okay, so here is what I just cobbled together here... dunno whether you prefer your version or mine (be honest!):

```diff
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index a9b41d8..ec7fef2 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -446,7 +446,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
   static HANDLE hEvent;
   WSANETWORKEVENTS ev;
   HANDLE h, handle_array[FD_SETSIZE + 2];
-  DWORD ret, wait_timeout, nhandles;
+  DWORD ret, wait_timeout, nhandles, at_least_until = 0;
   fd_set rfds, wfds, xfds;
   BOOL poll_again;
   MSG msg;
@@ -459,6 +459,9 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
       return -1;
     }

+  if (timeout != INFTIM)
+    at_least_until = GetTickCount() + timeout;
+
   if (!hEvent)
     hEvent = CreateEvent (NULL, FALSE, FALSE, NULL);

@@ -603,7 +606,13 @@ restart:
 	rc++;
     }

-  if (!rc && timeout == INFTIM)
+  if (!rc && timeout)
+    {
+       DWORD now = GetTickTime();
+       timeout = at_least_until <= now ? 0 : now - at_least_until;
+    }
+
+  if (!rc && timeout)
     {
       SleepEx (1, TRUE);
       goto restart;
```


@grizo how did this work? I am curious too


add new


Have to leave that one :palm_tree:


nice!


I would also suggest breaking before the "-j" The full line should be:
```ruby
      should have_rule("-A iscsi -s #{ip}/32 -p tcp -m tcp --dport 3260" \
                       ' -j ACCEPT')
```

Sorry if this is too nitpicky!


You have to use an authorized favicon. Moreover, you have to download it and put it in the repository. We can't use someone else bandwidth...


Sure.  I pushed up a change for that, too.


At startup time we can check cache size and if it is zero, do not iterate over sorted index and do not try to remove keys which can not be present in the cache anyway.

Data is being corrupted because of changes which were not tested enough and are not even being investigated. Trello issues are being kept empty, there are year-old tickets and nothing changes in this aspect. How long will it take to find a bug by discussing it in pull request?


grrr stupid mistake. Thanks.


This is very interesting but it lacks interactivity. As is, it is does not bring more than a slide show. In GCompris all activities are here to complement a book, not to replace it. I have no much idea on how to add interactivity at this point but I think it is mandatory. If you have no idea, raise the issue on the mailing list, maybe we will have teachers helping us.


Sorry for this merge commit, my bad.  Normaly everything is OK !


nice catch, feel free to create a pull request


Ruby should alias `is_an?` =>  `is_a?`


> ... But I can now evidence-founded say, that there's not a leak in diffs: Neither in lg2, nor gitwrap not diffviews. Our leaks have slightly more serious backgrounds :)

Well, that's actually good news, although it sounds bad == complicated :). But at least you get to the point a little more specifically. Sorry, I'm "on a jump" - reply's about to come later.


Because the functions were created from `doRipplePathFind` in RipplePathFind.cpp. `doRipplePathFind` is defined in src\ripple\rpc\handlers\Handlers.h, which doesn't seem appropriate for these functions.


Space after if


I was also thinking about that, but these two lines were added in different commits of yours, meaning I would also need to create two different fixup commits, and the next rebase would then likely trigger conflicts as adjacent lines are charged. That and my laziness were the reasons why I didn't do fixup commits. But I still can do if you prefer.


Var at the top


Gah, I committed a thinko: `timeout` should never be adjusted if it is `INFTIM`... ;-)

My rationale for writing the diff the way I did, BTW, was to use one less local variable (in my mind, there was no need for both `start` and `orig_timeout`) and to localize the `now` variable to the conditional code block...


Remove blank line


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/343e9f0420dfefb3480dcdfed6455fc8b777c27d/app.js)


Oh. Good point, Bernat. Thanks for pointing this out!


I think both is probably good, but it will be nice to have an official safety mechanism to ensure we don’t blow things up.  I might be able to only have Travis run the longer test when it’s a tagged release (before publishing to pymomo) but I also think if we pre-build the patched gpsim a <10minute build time won’t be much of a bottleneck.  I’ll implement this today.

—
Sent from Mailbox

On Wed, Mar 18, 2015 at 8:46 AM, Tim Burke <notifications@github.com>
wrote:

> I'm fine with that if you think its the way to go.  A more lightweight
> alternative would be to just ask each other if we've run build all
> before opening the PR.
> On 3/18/15 12:59 AM, Austin McGee wrote:
>> We could add a step to the pymomo CI that pulls the latest
>> MoMo-Firmware Dev and runs the full build. This will significantly
>> bloat the Travis build time (and might take some work for AppVeyor)
>> but would ensure that we don't break things. I think it's an OK
>> tradeoff for now, and hopefully we can move to a container-based build
>> system that caches build dependencies like xc8 and gpsim at some point.
>>
>>
>>
>> —
>> Sent from Mailbox
>>
>> On Tue, Mar 17, 2015 at 8:30 PM, Tim Burke <notifications@github.com>
>> wrote:
>>
>> > Just saw and commented on the other PR that you opened.
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >
>> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10251283
>>
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10253256>.
>>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10266960


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1660 of 1667 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


try updating the port here or below


I think that this version has the disadvantage that `GetTickCount() + timeout` can roll over and `at_least_until` will be less than `now` before any time has elapsed.


a) Valgrind is full of "uninitialised data used in conditional"
b) Valgrind is full of glib and webkit leaks.
c) Something's keeping our widgets or parts of them alive. I'd bet that this is a problem deep inside libBlueSky.


End line with ;


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/e777a24846acb37723a068fc3e88ffbf16d07554/app.js)


> But I still can do if you prefer.

No need to. Thanks for the clarification!


I guess I imagined the use case is that you have a main goroutine that starts the subscription and then another goroutine that consumes the events and errors sent over the channels. The main goroutine has the ability to call Close() and know that the Subscription is completely cleaned up due to the blocking on <-stream.hasQuit. I guess you still have the problem of knowing how to stop the other goroutine which is consuming two channels. It's easy if it's only one as you can range over it and the close stops the loop... I guess I'm just a bit averse to wrapping an io.ReadCloser in a mutex with lots of comments explaining why.
Here's another suggestion: calling Close() eventually results in a SubscriptionClosedError being returned on Stream.Events which indicates that the Subscription is fully Closed? Would be good to see some example client code that explains fully your use case. It's hard to cover all bases without examples :-)


Changed in https://github.com/bignerdranch/DemoMonkey/commit/52d2623f570f6b59b53e182e5ecd4d359cf88ef0 .


Changed in https://github.com/bignerdranch/DemoMonkey/commit/f20439e5cf1fcc1ee9378ca20d5cb96e3102ab06 .


*megusta*


Changed in https://github.com/bignerdranch/DemoMonkey/commit/212a9dd862f410ab0b13d19e61b7e26d5c6c754a, https://github.com/bignerdranch/DemoMonkey/commit/7d19781ff0d79add831560e25773810a2f9859ff, and https://github.com/bignerdranch/DemoMonkey/commit/b525095e46179c7ffcf68ed2cadd9312d3e6ab40.


Ah, that's right! Okay, then!


89224666-FixNANProblems-Issue4557 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1151 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.62%25-green.svg)


develop (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1151 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


Darn, I should have waited :)
Does yours increase the exported filesize by 10k, if not then please still submit it as for some strange reason mine did :/


I know the old hack would also translate the master sword in OOT when you change from an adult to a kid. Does translating everything correct this? I guess I'll find out soon enough


Please add to your profile is shown in the online and add them to friends


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2088 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.6%25-yellow.svg)


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


`Player.play()` already handles the volume tweening, no?


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


FWIW, it might be better in the future to also write down _why_ you reverted it ;)

(In this case: it made the panel go away immediately on Linux/Windows, unless you mouse up on one of the buttons or something like that)


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Should add a 'JOIN' query for the tables bugdet_item and 'bi_status'.


I'll do that but I can't align it like you have or rubocop will complain.


vishwas


Ok, the naming of that constant sucks.  Suggestions welcome...


Nit: "property" :)


Remove spaces after ( and before )


<s>This should be uppercase Boolean...</s> Actually, we're assigning 1 and 0 to it, so this should be `Integer` or the values should be true/false?

Nit: we seem to be inconsistently using `manifold.Integer` and `Integer` in the README