  Jobandtalent mail

    /* Client-specific Styles & Reset */

    #outlook a {
      padding:0;
    }

    body.outlook p {
      display: inline !important;
    }

    body{
      width:100% !important;
      min-width: 100%;
      -webkit-text-size-adjust:100%;
      -ms-text-size-adjust:100%;
      margin: 0;
      padding: 0;
    }

    .ExternalClass {
      width:100%;
    }

    .ExternalClass,
    .ExternalClass p,
    .ExternalClass span,
    .ExternalClass font,
    .ExternalClass td,
    .ExternalClass div {
      line-height: 100%;
    }

    #backgroundTable {
      margin:0;
      padding:0;
      width:100% !important;
      line-height: 100% !important;
    }

    img {
      outline:none;
      text-decoration:none;
      -ms-interpolation-mode: bicubic;
      width: auto;
      max-width: 100%;
      float: left;
      clear: both;
      display: block;
    }

    center {
      width: 100%;
      min-width: 580px;
    }

    a img {
      border: none;
    }

    p {
      margin: 0 0 0 10px;
    }

    table {
      border-spacing: 0;
      border-collapse: collapse;
    }

    td {
      word-break: break-word;
      -webkit-hyphens: auto;
      -moz-hyphens: auto;
      hyphens: auto;
      border-collapse: collapse !important;
    }

    table, tr, td {
      padding: 0;
      vertical-align: top;
      text-align: left;
    }

    /* Media Queries */

    @media only screen and (max-width: 600px) {

      table[class="body"] center {
        min-width: 0 !important;
      }

      table[class="body"] .container {
        width: 95% !important;
        margin: 0 auto;
      }

      table[class="body"] .row {
        width: 100% !important;
        display: block !important;
      }

      table[class="body"] .wrapper {
        display: block !important;
        padding-right: 0 !important;
      }

      table[class="body"] .columns,
      table[class="body"] .column {
        table-layout: fixed !important;
        float: none !important;
        width: 100% !important;
        padding-right: 0px !important;
        padding-left: 0px !important;
        display: block !important;
      }

      table[class="body"] .wrapper.first .columns,
      table[class="body"] .wrapper.first .column {
        display: table !important;
      }

      table[class="body"] table.columns td,
      table[class="body"] table.column td {
        width: 100% !important;
      }

      table[class="body"] .columns td.one,
      table[class="body"] .column td.one { width: 8.333333% !important; }
      table[class="body"] .columns td.two,
      table[class="body"] .column td.two { width: 16.666666% !important; }
      table[class="body"] .columns td.three,
      table[class="body"] .column td.three { width: 25% !important; }
      table[class="body"] .columns td.four,
      table[class="body"] .column td.four { width: 33.333333% !important; }
      table[class="body"] .columns td.five,
      table[class="body"] .column td.five { width: 41.666666% !important; }
      table[class="body"] .columns td.six,
      table[class="body"] .column td.six { width: 50% !important; }
      table[class="body"] .columns td.seven,
      table[class="body"] .column td.seven { width: 58.333333% !important; }
      table[class="body"] .columns td.eight,
      table[class="body"] .column td.eight { width: 66.666666% !important; }
      table[class="body"] .columns td.nine,
      table[class="body"] .column td.nine { width: 75% !important; }
      table[class="body"] .columns td.ten,
      table[class="body"] .column td.ten { width: 83.333333% !important; }
      table[class="body"] .columns td.eleven,
      table[class="body"] .column td.eleven { width: 91.666666% !important; }
      table[class="body"] .columns td.twelve,
      table[class="body"] .column td.twelve { width: 100% !important; }

      table[class="body"] td.offset-by-one,
      table[class="body"] td.offset-by-two,
      table[class="body"] td.offset-by-three,
      table[class="body"] td.offset-by-four,
      table[class="body"] td.offset-by-five,
      table[class="body"] td.offset-by-six,
      table[class="body"] td.offset-by-seven,
      table[class="body"] td.offset-by-eight,
      table[class="body"] td.offset-by-nine,
      table[class="body"] td.offset-by-ten,
      table[class="body"] td.offset-by-eleven {
        padding-left: 0 !important;
      }

      table[class="body"] table.columns td.expander {
        width: 1px !important;
      }

      table[class="body"] .right-text-pad,
      table[class="body"] .text-pad-right {
        padding-left: 10px !important;
      }

      table[class="body"] .left-text-pad,
      table[class="body"] .text-pad-left {
        padding-right: 10px !important;
      }

      table[class="body"] .hide-for-small,
      table[class="body"] .show-for-desktop {
        display: none !important;
      }

      table[class="body"] .show-for-small,
      table[class="body"] .hide-for-desktop {
        display: inherit !important;
      }

      table[class="body"] .button,
      table[class="body"] .tiny-button,
      table[class="body"] .small-button,
      table[class="body"] .medium-button,
      table[class="body"] .large-button, {
        display: block!important;
        width: 100%!important;
      }

      /* Custom media-queries */

      a[class="call_to_action"], a.call_to_action { display:block!important; }
      div[class="column"], div.column { width:100%!important; float:none!important; display:block!important;}
      div[id="pad_on_mobile"] { padding:0 10px!important; }
      div[class="column"] td { text-align:left!important; }

      img[class="companies_image"] { width:100%!important; }
      div[class="alternative_suggestions"] a[class="company"] { margin-left:auto!important; margin-right:auto!important; }
      div[class="job_opening_invitation"] div[class="column"] a { width:auto!important; display:block!important; margin-bottom:20px!important;}
      div[class="job_opening_invitation"] div[class="column-wrap bottom_bordered"] { padding-bottom:0px!important; }
      div[class="opportunities_newsletter"] .image_cell { width:65px!important; }
      div[class="opportunities_newsletter"] .image_cell img { width:65px!important; min-width:0!important; }
      div[class="opportunities_newsletter"] .bordered .variable_pad { padding:10px!important; }

      div[class="notification_review"] .image_cell { width:65px!important; }
      div[class="notification_review"] .image_cell img { width:65px!important; min-width:0!important; }

      div[class="welcome"] div[class="wrapper"] table { margin-bottom:0px!important;}

      div[class="job_opening_invitation"] h1[class="main_heading"] { padding-bottom:15px!important; font-size:15px!important; font-weight:600!important; }
      div[class="job_opening_invitation"] p[class="description_tag"] { padding-top:10px!important; }
      div[class="job_opening_invitation"] td[class="wrapper image_cell"] img { width:100px!important; }
      div[class="job_opening_invitation"] td[class="unpad_mobile"] { padding-bottom:0!important; }
    }

    /* Targeting clients that accept media quieries */
    @media all {
      div[class="opportunities_newsletter"] .image_cell img,
      div[class="notification_review"] .image_cell img {
        min-width:150px;
      }
    }

  Today we have 37000 Jobs

  Today, March 16, jobandtalent have access to more than 37,000 jobs. Don't miss out on opportunity.

                View jobs

    -- The jobandtalent Team

                      You are receiving this email because reply@reply.github.com is registered at Jobandtalent.com (3rd floor, 36-37 Featherstone Street London EC1Y 8QZ) and agreed to receive email from us.

	If you would like to unsubscribe and stop receiving these emails click here


I don't think we want this to be a fixup, as I think it's worth keeping this as a separate commit so that one can still verify that git-wrapper was taken from msysGit's commit 74a198d after the next rebasing merge.

Also, as unfortunately GitHub does a bad job at displaying diffs for whitespace changes, could you briefly say in the commit message what whitespace as been changed to what?


Yup that looks good there ( I just checked http://cs.smu.ca/bluemixhackathon/ )

Could you add http://cs.smu.ca/bluemixhackathon/ to the "Website" at the top for this repo for easy access. Thanks.


Oh yeah, I suppose so. PR?


Succeeded?


no check?


Ah, I see, ok. That's fine I guess, although I think you could still make a subroutine and just pass in polarity positive for this case.


Must follow standards, unless meeting one of the following 3 dozen exemptions... :wink:


Ce block doit être rajouter dans geonode/templates/base.html ~ligne 228.


Done! Updating README as well.


This is fixed in `1.0.2-1`. In the future, please file new issues for stuff like this.


the printing is specific to the console so it belongs there, we'll have
other interactors later that won't print it here.

2015-03-16 14:44 GMT+01:00 AhmedKamal1432 <notifications@github.com>:

> @sils1297 <https://github.com/sils1297> if _print_section_beginning just
> print section name, what about implement it in only in Interactor class ?
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/AhmedKamal1432/coala/commit/3c189d19c0990b92005aafe2d05d5c0984d73738#commitcomment-10214118>
> .
>


I don't see these partials in the code did I miss them, or did you forget to commit them?


Yeah, I know... It's probably the least important of my core code pet peeves.


IMO this should be squashed to ec3c7f25decbebdfad359b45fd2369c4571ed85b (keeping only this commit's message).


On the controller we make
`@invoice = Invoice.new()` and then we "fill it" with requests params, and then we calculate amounts.
if the invoice doesn't have id, the system will complain if items and payments do have id.
I use `Invoice.new()` so I can use the same code with either the "new" or "edit" invoice pages.
I guess if I add the `id` to the invoice when it's editing, I could leave the `id` attrib of the items on. But I don't know which procedure is simpler. Maybe item ids shouln't be removed with this code in the controller
```ruby
@invoice = Invoice.new()
if invoice_params[:id]
  @invoice.id = invoice_params[:id]
@invoice.attributes = invoice_params # not saved
@invoice.set_amounts
```
yeah,  it sounds simpler. this way we shouldn't need to do any javascript mangling.


What do you guys think about removing that **would**?

> All proceeds go to Feed NS

versus

> All proceeds *would* go to Feed NS
... unless we realize that we need to pay rent and then coulda, shoulda, woulda.
:wink:


I escaped the remote password.
The latest version is here: https://github.com/higebu/packer/releases/tag/v0.7.5.higebu4


that's pretty cool, but now you can't call with "--help" !

```
  download [<flags>] <projectRev>
    Retrieve a build Artifact
```

then:
```
$ alchemist download --help
alchemist: error: required argument 'projectRev' not provided, try --help
```


this was just sugar to make `events=" 'someeventobj'"` work on models it was working fine as a normal scope object field.


Hi Jacob,

I have been checking out final results from guess api. I realized when you compute last_timestamp you use last successful submission time https://github.com/SMISC/api/blob/master/util.py#L292

However, It might not be true. The better way might be checking the timestamp of a submission that finishes competition. Because I have submitted same bot id's multiple times since tuesday to learn number of total submission.


This commit should be reverted, if request.pop yields none something really bad has happend -> e.g. receiving a message with the same identifier in a single batch.


Why?


We should be using ```weakSelf```.


or `will go to`


Simple script, to disconnect and reconnect to LAN / WLAN. Use careful with network drives!
*This script written in AutoIt, some virus scanners can find harmful - because many viruses written in AutoIt.

Egyszerű szkript a hálózati újracsatlakozáshoz. Óvatosan használd csatlakoztatott hálózati meghajtóknál!
*Néhány víruskereső veszélyesnek találhatja a szoftvert, mivel sok vírust írtak már AutoIt-ben.


@rickginer the many ways to use window, windows with and without marker or markers.


should be rism-ch


That breaks the build …


It throws a NullPointerException Otherwise


No, partest gets the error count from the compiler's reporter: https://github.com/vsalvis/dotty/blob/vsalvis-partest/test/dotty/partest/DottyPartestCompiler.scala#L28


+1 for that too


This must be pop, a get will not cancel the timeout


Ultimately the validation is whether the command exists at the time and place it is executed.  Checking earlier creates a race condition.

If there is a concern that samtools1.2 may not exist, let's make sure there is enough logging around the command execution to make it clear why the execution failed (e.g., "Command not found").


@nfeske: above fixup commit solves current buildbot problems on hw with CortexA8 and Armv6


my bad


If two applications have distinct classpaths and are using the same mapping file, we must increment the id in case of CNFE to mantain the same image on both ends.


hi


The suffix 1 or 2 is still there, and those tests are listed in the corresponding section in tests/dotc/test.scala... Would replacing underscore by dash be better?


In the title, instead of just "Refactor git-wrapper" how about "Refactor git-wrapper code into more functions"?


hell


Cool, thanks!


After having a look, I don't believe so. signal_session_component.h looks competly different from base/ respectively base-nova. There are classes missing in this header file compared to the base/ version.


Needs more comments!


Thanks. Merged to staging.


Like


The quotes file contains the blockquote and quote html elements. I named it quotes since that covered both of these. Pullquotes are a classed version of blockquotes.


sneaky


But it's fine.


sneaky #2


А где сам файл?


Ok. So then I will just keep a note and look for a possible unification later.


Comentando sobre este cometer


I have it there since that is usually where other frameworks have it. There might be a better place for it.


space


Please don't replace `:` with spaces. Instead, split the SHA-256 with something like:

    // Split the SHA256 cert into blocks of 24 chars.
    var sha = session.client.cert.sha256;
    var block = 24;
    var splitsha = [];
    for (var i = 0; i < sha.length; i += block) {
      splitsha.push(sha.slice(i, i + block));
    }

and then assign `title.args.cert` like so:

    cert: splitsha.join('\u200b')

This will add zero-width spaces at strategic places in the SHA-256 so that it can break and be displayed nicely.

Note: Please also display the SHA-256 in WebIDE using the same uppercase, `:`-separated format.


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-66.1%25-red.svg)


Updated. I appreciate your help guys :)


Same here, I only used :idle to load some minor modes, but not *right now*, e.g yasnippet's global minor mode.


Is it necessary to modify this function for this single case where just this one line of code would be enough? Are there other use cases or situation where would need an ```evaluateScript:onWebView:``` function?


Guaranteeing order in a json dict could be cumbersome. Why not unmarshal to a map and check the map keys/values?


You don't need the constant for the root path but i prefer it before using relative paths or calling plugin_dir_path.

I think I would prefer `config` over `includes` for this. The name `includes` would imply that the directory/folder could contain anything, including logic. `config` would imply that the directory/folder only include data and no functions or classes. But I don't really care what it is called.

Sure, the path could be filterable. The ep_config_mapping filter would be sufficient in most cases but it would not hurt to add one more in case one would want to change the mappings completely.


[Jive] Test User wrote: test


I've pushed some fixes for the Windows build. @kumpera please review to make sure I didn't screw up :)


@Mumfrey Can you make an example of a local capture injection if possible?
This looks like a very powerful feature but I do not know how to use it. Would be good to know what it can and can't do.


I will not have so much time this week for fs dev. Will do some tests and report issues, but delay on ui work.
For notifications: i saw floele made some work for viewing notifications years before. I think its in the section where screenshots are added for fs1.0 design discussion.
i haven't thought much about notifications, thought using info from event log is enough. Don't set u under time pressure.


@larsbrinkhoff Well, that's a relief then. :)

Have fun on your quest!


cool!


>Would replacing underscore by dash be better?

I would say yes, as `2741_2` was renamed to `27412` which doesn't make me think that last `2` is actually a run number


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The baseline should allow L2 GDHS when CPU's are in standalone PC (minimally).  With this patch, the CPU's have to hit full PC to allow L2 GDHS state.


The commit message is very nice for the historic background, but it actually says nothing about what this change actually does in detail. I would have expected something along the lines of:

"Extend the module file name parsing to turn builtin command names like git-log into calling the main git executable with the log command argument."


It's automatic. Converters always run in the toolbox process because they produce DOM output. The link is that the command has a returnType of 'imageSummary' (which is described above) and the converter is from 'imageSummary' to 'dom'.


30414/Dolineanu A. Vlad Ionut/Assignment 2.2/listFunctions.c

Don't forget, you're dealing with a queue. The names of the operations are important (enqueue/dequeue)


Well I think it should be running in parallel eventually... I'm not sure if I'm doing something wrong in how I get the compiler (e.g. that somehow in scala-partest each worker thread gets its own compiler, but here we don't), or whether the compiler should be thread-safe but isn't (yet)? Currently I'm just using `dotty.tools.dotc.Bench` resp. `dotty.tools.dotc.Main` like the other DottyTests.

One of the reasons for partest that Martin stated was also that he thinks it's easier to collaborate when tests are independent files than when everybody is hammering on the test file.


> This reduces the disk footprint of a full Git for Windows setup by
853,092,969 bytes.

While this is funny to read, you should really do the math in here to show how that number is calculated (number of aliases for builtins times main git exe size).


ResultsSchema (sanyalj) - x86_64-MacOS-10.9-clang: OK (1567 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.03%25-yellow.svg)


@hmaeda just added the API documentation to the wiki. https://github.com/Project-OSRM/osrm-backend/wiki/Server-api


The links in Readme.md and the links shown during installation pages are wrong after switching from wiki to github managed website flyspray.org


IMO that is bad reference counting practice. You should never use an object unless *your* code owns a reference to it. Assuming some other code owns a reference and "borrowing" it is a recipe for obscure bugs when the other code changes.


Yes. Just more compact, and equally readable, to my eyes anyway!


May be easier to follow if  $(LD$(sm)) everywhere as we are using both $(LDcore) and $(LD$(sm)) in the current code.


The way we are using them, I think they should all be in the same file.


Ok, I'll create another clean PR, sorry about that.


indentation is wrong


I think you borked this one... lots of repeating 75's....


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Coverage Too Low

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.02%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Perhaps yes. In that case thhough probably the line
    ctx->owner_thread = CONTEXT_NO_OWNER;
should move up top with the set_context.


Also, I haven't checked in detail, but don't we need to modify the `install` target, too?


That surprises me others put it in type. Looking at a file called type.scss, I wouldn't think the only thing I'd find is a small divider.

Where are our horizontal rules? Will other (similar) classes be added to this file?


nice this commit should definitely get in.


I've tested this out, and it doesn't look fully functional to me. Zooming still distorts the position of the circles, and rescaling the window distorts the canvas as a whole (but not the shape of the circles any more). Also when you drag, it draws a circle. Is there a reason you say it's fully functional when it's not?


You could simply skip the test if text2cstring.pl doesn't exist. It's meant as a safeguard for forgetful programmers, not really a test. And I agree we shouldn't depend on Perl.


Fixup with 055a65c56a49e3d03e80f8e2dd93019dcd155b13?


If you see inside there is a skip section for non-Linux platforms already.


正規表現を/^～$/とかにしないとホスト名偽装に対応できないっす


@timgraham, @ttanner What about a `ordered_fields` property instead? Then you'd have
```
self.fields = self.ordered_fields
```
or similar. Just came to my mind, since we don't really have a pattern like that in Django anywhere, the admin usually has getter methods for everything, so just from a naming perspective I'd at least name it `get_ordered_fields` and return the fields…


No worries :+1:
I'd propose you rebase after we finish the discussion in this PR, this will help us by having the conversation in a single place.


@bezoerb https://github.com/addyosmani/critical/releases/tag/v0.5.6


Yeah, it should have this `@extend .icon-arrow-down-24;`. I'll fix it right now.


**[jsUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/jsUnit_trunkUnit/7315/testReport/) for this commit**


You might as well fix the type "against"


No worries, it was just a reminder for the next time ;)


let the tests fail.. please correct tests


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


this is a bit excessive i think it's better to just make these definitions as some of these seem quite useless


Should not we have CROSS_COMPILE$(sm) instead of CROSS_COMPILE only so that we can change both compilers dynamically? But then we should set CROSS_COMPILE of the libs somewhere.


with this commit the tests are failing, please correct the tests


nice!


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Fracas indeed. Depending on what you're using it for, you could require version 3.1.2, which is nodejs compatible. I tested it on your earthquake analysis and it seemed to work.

If some of the features and bug fixes are in the 4.x branch tho then perhaps the Ides of March(-ish) is indeed a sign of the things to come.

> Le Mar 16, 2015 à 08:51, Jeremy Singer-Vine <notifications@github.com> a écrit :
>
> Tell me more. I'm not up to speed on the whole io/node fracas, but nbjs relies pretty heavily on jsdom when it's not being loaded in a browser.
>
>
>
> > On Mar 15, 2015, at 9:27 PM, Michael Keller <notifications@github.com> wrote:
> >
> > et tu brute?
> >
> >
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
> —
> Reply to this email directly or view it on GitHub.
>


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/structure.lib.php


What makes more sense?
if (null == googleMap)
or
if (googleMap == null)
? :dancer:


Notes in a scale should also now be properly chosen before the game starts (hopefully), and should be in order.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: .travis.yml, doc/config.rst, libraries/charset_conversion.lib.php


In keeping with the style of the rest of the JavaScript here it would be good to break this out into a named function. This will also make it easier to add any tests (if you think any are appropriate)


Doc `build_system.md` to be updated


Instead of a per-file gitignore, a generic one could be used, such as in the EMF-IncQuery project: http://git.eclipse.org/c/incquery/org.eclipse.incquery.git/tree/plugins/org.eclipse.incquery.patternlanguage.emf/src-gen/.gitignore


Добрый день, Андрей.

Посмотрела пример с перегрузкой операции с проверкой на null, у меня проверка работает.
--
С уважением, Кравчук А.И.

> On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com> wrote:
>
> Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на вечернем
> вообще программированию не учили, и не у кого что то спросить, или кто бы
> сказал как правильно, а тут вот как раз ответы на все вопросы. Так что
> спасибо Вам)
>
> 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
> notifications@github.com> написал:
>
> > Андрей, надеюсь, что Вы не пугаетесь моего большого количества вопросов.
> > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде все было ну
> > если не идеально, то почти))
> > --
> > С уважением, Кравчук А.И.
> >
> > > On 14 Mar 2015, at 21:03, andrew-minich1 <notifications@github.com>
> > wrote:
> > >
> > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего серьёзного,
> > всё
> > > понял. Я вот кстати до этих курсов вообще не понимал для чего интерфейсы
> > > нужны, а теперь понимаю что без них вообще никак)
> > >
> > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
> > > notifications@github.com> написал:
> > >
> > > > Название интерфейса IGetDiscount лучше заменить на IDiscount, вообще,
> > > > интерфейсы, если вспомнить FCL именуются чаще как причастия -
> > > > форматируемый, сериализуемый и т.д. или как существительные ICompare
> > > > (компаратор) , а вот методы наооборот, как глаголы или словосочетания.
> > > > Здесь все наоборот.
> > > > Опять реализация интерфеса оказалась не в том проекте
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
> >
> > > > .
> > > >
> > > —
> > > Reply to this email directly or view it on GitHub <
> > https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
> >
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
> > .
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
>


@dawagner I opened a bug for that #64.


Does Directx 9 code no need change ?


amazing results :)


Could also use `map`


Is this extra class necessary? I am not entirely sure.


This is going to miss the `LoggerUtils.pageExitLogging();` code won't it?
Also if there is a question that requires submission on the page, it seems that type of question will not be able to block the page exit.

Can you refactor this code so the `navigate_away` does not assume the there is a click_element. Instead there a callback function is passed into `SaveOnChangePage#navigate_away`, in the case of `SaveOnChangePage#intercept_navigation` this callback will change the window.location to the click_element.href.  In the case of the single page submit button this call back will close the window.


Yepp. Far from clean merge, that's why needed your view.


Is this logger ID correct?


its incorrect config


точно :)


I'm from MrMouette Team.


This fixes a regression introduced in *this* branch (774588b4).


>whether the compiler should be thread-safe but isn't (yet)?

It should but I guess its not.
There's a workaround for this: you can have different classloaders in different worker threads. This will allow you to have no sharing even between Dotty global `objects`. Though it is ugly.

>One of the reasons for partest that Martin stated was also that he thinks it's easier to collaborate when tests are independent files than when everybody is hammering on the test file.

I don't remember us having problems with conflicts in `tests.scala` As most changes there are single line changes, git resolves such conflicts without any help. Unless we indeed are working on the same test, but than conflicts are inevitable in either way of organizing test definitions.

This file can be easily split to give it structure if we need it, as we have all scala means to do it: inheritance, deligation, etc.


Thanks, @Ferdi for helping me find this bug!


Empty comment blocks should be removed.


This feedback shouldn't block merging, but in future it would be good to rebase out any accidental commits like this (where you've accidentally committed a line added for debugging and then removed it in a later commit).


![Uploading DocuPage7.png . . .]()


Добавил подсветку поля при некорректном значении цвета в 8ee57faa97735008509db93492147db2f6915140


I'm confused. This link looks like it has nothing in it except an empty `<i>`.


Another per-file gitignore.


Ok, I removed this (latest commit). I don't really understand why it was written like this in the first place (original: https://github.com/scala/scala-partest-interface/blob/master/src/main/scala/tools/partest/TestingInterface.scala#L91)


Delete some files.


The file is installed by both the main `abrt` package as well as `abrt-atomic`. Does RPM allow such conflict? If so, do we really want to have it? What about configuration file and manpage?


I like this commit in general, but I have a few comments here.


@laptobbe Yeah, that's something we'll need to do before this gets released.


The removal of this gitignore seems a bug to me.


Also the commit message seems to be missing something?


This is a weird “fix” since it's not correct. Oder?


It is a bad idea to filter out folders, as it might cause build path issues when checked out into Eclipse.


@thii Are you using git tags for your marketing version number? That appears to be a SHA1, not a tag.


Why are these tests ignored?


We already support running uninstalled from git, I'd prefer maintaining that over `/usr/local` myself.


But they are beautiful, we will have a Use later...

> Am 16.03.2015 um 15:13 schrieb AEnterprise <notifications@github.com>:
>
> this is a bit excessive i think it's better to just make these definitions as some of these seem quite useless
>
> —
> Reply to this email directly or view it on GitHub.
>


![Uploading DocuPage7.png . . .]()


Please, don't add this debug plug-in as a dependency in this commit.


1: M111 unrecognized component name: oauthclient


78:1: I201 Missing newline before sections or imports.
80:1: I100 Imports statements are in the wrong order. from flask should be before import requests
80:1: F401 'current_app' imported but unused
81:1: I201 Missing newline before sections or imports.
83:1: F401 'db' imported but unused
155: D103 Docstring missing
167: D103 Docstring missing


Please, don't use non-English comments.


This commit is not related to the original pull request, please, open a separate one, as this relates to the update of an existing transformation instead of the addition of a VIATRA-based implementation.


keep them arround for now then, we'll only migrate the ones we use to BCA, i'll put the others in a seperate txt file on my local pc as backup, if we ever do use them we have them but i think it's bad practice to add code that isn't used, only thing that could heapen is that we forget we have it and make a new version of it


This fixes #1027.


That will not work because $(sm) will be evaluated too late here. The other way around is possible though. Should I replace all $(sm) with core in this file?


The problem is that succeeded could mean either the compilation succeeded (=the test failed) or the test succeeded... Renamed it to NoneFailed.


Is it ok that you have AgeCategory in Team Entity, but not vice versa - no Team in AgeCategory Entity?


@danielmarbach is this a temporary fix or is it valid and something we want applied on the ATTs suite?

/cc @andreasohlund @johnsimons


fhdfhdfh


**jruby-1_7** started getting messy as well :( e.g. https://travis-ci.org/kares/jruby/jobs/54532920#L1543-L1546
... that is `TARGET='test-extended'` (exactly the same code as on jruby's jruby-1_7 branch) otherwise also failing are `TARGET='test-jruby-jars'`, `TARGET='jruby-jars-extended'`, `TARGET='main-extended'`


80:1: I201 Missing newline before sections or imports.
82:1: I100 Imports statements are in the wrong order. from flask should be before import requests


Any ETA on versión 1.3.15 where this fix is made? We are holding a new release of our product because this exact problem. It's likely hard to reproduce, but when it happens it makes the application unusable.


It looks ok for me. I have added property replacement only to the newest version purposely as I didn't want to introduce new functionality to previous parser versions. Regarding propertyReplacer: xml mapper should be created per deployment as property replacer differs between different deployment - it is ok in you code because createMapper function is invoke during deployment. Xml mapper will be used only by this deployment and because of that there will be only one parser used.


im not sure how portable is strerror_r() iirc this doesnt build on windows


Si prega i gentili utenti ospiti di questo repository di fare commit seri. Grazie!! :)


you can verify with `make w32`


Not yet! It's a goal before WWDC 2015 when we can start thinking about dropping iOS 7


aborting *to avoid* deadlocks.


Yeah I think it's something about encoding fixes I made that only breaks on travis in these embedded scenarios. Waiting on a private Travis instance to investigate.


if (googleMap == null) , I don't even know how that line landed there, but
it still works anyway,

*Cheers*
*-------------*
*Mativo Dominic M* *|* *@mativodominic* *|* *skype: mativo.dominic*

On Mon, Mar 16, 2015 at 5:14 PM, Salad Thieves <notifications@github.com>
wrote:

> What makes more sense?
> if (null == googleMap)
> or
> if (googleMap == null)
> ? [image: :dancer:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/C4AProjects/pug/commit/ce8b0de02aa82b639490c785a63595b4803bd143#commitcomment-10214807>
> .
>


I guess in that case alpha must be released without the ui. The current backend implementation is based on existing notification system, not event log. Messages formatted differently and a lot shorter than email and jabber notifications. Hard to estimate if they contain enough and right information without ui, they probably need a lot more tuning.

Couldn't find floeles screenshots anywhere.


@danielmarbach can you please document why it is ok?


i would prefer not to depend on global libc vars for checks like this. sdb_lock should be able to report that in a portable way., maybe with ret value or just with a second ref arg


哈哈，Your English is very poor!There is spend whole week understanding your lesson.Not to understand!


i was able to build sucessfully , but he boots, optimizing apps, and afther it completes , just bootloops.

Is not kernel related, must be something i have missed here.

http://pastebin.com/nUEjcPNP

By any chance do you know what could be related? thanks


That’s great!

Thanks,

Mauro Vime

> El 16/3/2015, a las 15:29, dkhamsing <notifications@github.com> escribió:
>
> Add iGrades by @maurovc
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/dkhamsing/open-source-ios-apps/commit/61078bc4994c279d0d0a64077b046e41af0663e9


That’s great!

Thanks,

Mauro Vime

> El 16/3/2015, a las 15:23, dkhamsing <notifications@github.com> escribió:
>
> Add VisitBCN by @maurovc
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/dkhamsing/open-source-ios-apps/commit/f8edd820f2ac1eaef3393449da468b17a4f18af9


Just checking that when you wrote 'Drupal page' in the commit message you mean 'CMS page'. We'll need to check with WP and Joomla! as well.


It's certainly possible to use both in parallel. Right now, sbt test would run both in that case, which would double testing times. Also there's the practical aspect that you have to maintain the two infrastructures in sync when it comes to flags/error number files and directories (which are currently used as a way to sort tests into passing/failing/untried etc.). So I'm not sure it would make your life easier in the long run :)

Currently you would just dump that failing test into a separate directory (starting with pos- resp. neg-) and put that in DottyPartestConfig, and use `sbt test-only partest`. I could also add the capability to provide it as argument, either the directory or just the test like `sbt test-only partest -- pos/txxxx.scala`

Not sure about ContextEscapeDetector... This would usually be called by JUnit after the test finishes?


Yes, CMS page, my mistake.


лучше так:
```
storage_path(''logs/laravel_testing.log')
```


I think the problem here is the verb "enticed". I "entice" my dogs to do what I want by giving them a treat. I don't think that accurately represents what was going on in this situation, and is why I was confused.


I split issue 2 on your list here: https://github.com/cubecart/v6/issues/390

I don't understand your first one.


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-51.31%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Uhh yeah it works using the css class in order to display a message. Here it is how it works http://fortawesome.github.io/Font-Awesome/icon/external-link/


For some reason, this didn't make it into osc 0.151.0-8.1 (most recent version in http://download.opensuse.org/update/13.2/noarch/):
m4z@foo:~/tmp> rpm -qlp osc-0.151.0-8.1.noarch.rpm | grep core.py
/usr/lib/python2.7/site-packages/osc/core.py
/usr/lib/python2.7/site-packages/osc/core.pyc
m4z@foo:~/tmp> rpm2cpio osc-0.151.0-8.1.noarch.rpm | cpio -ivd ./usr/lib/python2.7/site-packages/osc/core.py
./usr/lib/python2.7/site-packages/osc/core.py
3470 blocks
m4z@foo:~/tmp> grep ASD usr/lib/python2.7/site-packages/osc/core.py
    print("ASD", dst_updatelink)


лучше сделать
```
$path = storage_path('logs/laravel_testing.log');
```
чем каждый раз использовать эту конструкцию (мелкий копипаст получается)


yup sounds like a good plan!


Копипаст в тестах - тоже не хорошо.
Можно в общем классе UnitCase делать общие методы и туда выносить весь одинаковый код.


:smile:


part of iqss/geoconnect#99


`local` é palavra-chave do shell, não acho boa ideia criar uma variável com o mesmo nome.


bub bub


Владимир, добрый день!

Большое Вам спасибо за полезные комментарии!
Постаралась исправить код, очень радуюсь, что действительно получается на много оптимальнее и проще!

Единственное, я не совсем понимаю, что это значит:
"42-43, 50-51: все еще отбить * +, чтобы не выглядело кирпичом"
?

Ещё раз спасибо!
Михаль Розенвальд
107 ПМИ ФКН


Nice. Happy for this to go straight on master.


Что за чудо с кучей пустых строк?


Значит что то я неправильно делаю, у меня вот так

16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
notifications@github.com> написал:

> Добрый день, Андрей.
>
> Посмотрела пример с перегрузкой операции с проверкой на null, у меня
> проверка работает.
> --
> С уважением, Кравчук А.И.
>
> > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com>
> wrote:
> >
> > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
> вечернем
> > вообще программированию не учили, и не у кого что то спросить, или кто
> бы
> > сказал как правильно, а тут вот как раз ответы на все вопросы. Так что
> > спасибо Вам)
> >
> > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
> > notifications@github.com> написал:
> >
> > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
> вопросов.
> > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде все было
> ну
> > > если не идеально, то почти))
> > > --
> > > С уважением, Кравчук А.И.
> > >
> > > > On 14 Mar 2015, at 21:03, andrew-minich1 <notifications@github.com>
> > > wrote:
> > > >
> > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
> серьёзного,
> > > всё
> > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
> интерфейсы
> > > > нужны, а теперь понимаю что без них вообще никак)
> > > >
> > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
> > > > notifications@github.com> написал:
> > > >
> > > > > Название интерфейса IGetDiscount лучше заменить на IDiscount,
> вообще,
> > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия -
> > > > > форматируемый, сериализуемый и т.д. или как существительные
> ICompare
> > > > > (компаратор) , а вот методы наооборот, как глаголы или
> словосочетания.
> > > > > Здесь все наоборот.
> > > > > Опять реализация интерфеса оказалась не в том проекте
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub
> > > > > <
> > >
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
>
> > >
> > > > > .
> > > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub <
> > >
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
>
> > >
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
>
> > > .
> > >
> > —
> > Reply to this email directly or view it on GitHub <
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
> .
>


kjk


@xevenheaven Take a look at this too (just so you know about it)


Why remove this line?


This can be simplified even further as: sudo with-rw nano /etc/rsyslog.d/10-ninja.conf


You probably have a component here.

Use components branch.


Aqui funcionou perfeito o alinhamento!

Mas realmente ficou lento. Achei estranho que no final, após imprimir a última linha, ele trava uns 5 segundos, e daí libera o prompt.


Maybe add error handling here?


> Also there's the practical aspect that you have to maintain the two infrastructures in sync when it comes to flags/error number files and directories (which are currently used as a way to sort tests into passing/failing/untried etc.). So I'm not sure it would make your life easier in the long run :)

That's the particular point I propose to change: instead of having 2 infrastructures(or three: performance regression tests), have a single one that generates the other.

@vsalvis I propose to meet tomorrow after the Scala Meeting and discuss.
I believe that by plugging into carefully decided places in both Dotty and partest we can get best from all worlds.

In short: we can tweak
https://github.com/lampepfl/dotty/blob/master/test/test/CompilerTest.scala to allow generating test definitions of PartTest instead of running the test itself. Than we'll have a separate `sbt test-only partest` that generates the partest definitions and runs them after. No need to maintain multiple definitions: all infrastructure will reuse the existing ones. Also we'll maintain IDE support and benchmarks, instead of breaking both.


Is `p` used? What's the deal?


Please remove this file if it is use less


Good point - thanks for the comment! Build configurations for multi-component projects are always tricky to keep in sync.  Do you think updating the documentation is enough, or would it be better to update the gradle file to include this properties?


When calling `INFO` on Redic, the return value is a string blob, so that line won't work.


What is the use of a java file in a python based project?


looool. keep it please.


It's still not clear for me what does it mean.
`NoneFailed`: failed to run? or to compile?


no me explique bien la primera vez y lo modifique para que se entendiera mejor  la idea que pretende esta organizaccion


@synhershko I applied it already in the general suite


Added Kenneth to README.md


This patch is wrong. We really want to go through if's. The elif would lead to a situation where if an option is specified all the other ones in the if chain will be ignored even if specified.


This commit breaks animation when you reopen node.


The problem is because multiple saga tests are reusing the same endpoint the ressource manager id can overlap therefore making the ATTs crash. With that we get a manager id per ATT run.


not at all! good catch, probably a left over from some refactoring.


These mobs used to spawn no matter what the light level. They locally defined isValidLightLevel() { return true; }. That may be why they need a buff. Do we want it like the old DRPG and have them spawn in light or keep it like you have it?


This really isn't necessary. Once the veth end has been moved into the container, a failure of the container will remove the entire pair. And failure of the container is by far the most likely reason for that command - and other commands on the interface - to fail. Consequently we make no attempt to remove the veth elsewhere in the code.


:heart:


Я что-то не нашла в письме как)
--
С уважением, Кравчук А.И.

> On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com> wrote:
>
> Значит что то я неправильно делаю, у меня вот так
>
> 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
> notifications@github.com> написал:
>
> > Добрый день, Андрей.
> >
> > Посмотрела пример с перегрузкой операции с проверкой на null, у меня
> > проверка работает.
> > --
> > С уважением, Кравчук А.И.
> >
> > > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com>
> > wrote:
> > >
> > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
> > вечернем
> > > вообще программированию не учили, и не у кого что то спросить, или кто
> > бы
> > > сказал как правильно, а тут вот как раз ответы на все вопросы. Так что
> > > спасибо Вам)
> > >
> > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
> > > notifications@github.com> написал:
> > >
> > > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
> > вопросов.
> > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде все было
> > ну
> > > > если не идеально, то почти))
> > > > --
> > > > С уважением, Кравчук А.И.
> > > >
> > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <notifications@github.com>
> > > > wrote:
> > > > >
> > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
> > серьёзного,
> > > > всё
> > > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
> > интерфейсы
> > > > > нужны, а теперь понимаю что без них вообще никак)
> > > > >
> > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
> > > > > notifications@github.com> написал:
> > > > >
> > > > > > Название интерфейса IGetDiscount лучше заменить на IDiscount,
> > вообще,
> > > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия -
> > > > > > форматируемый, сериализуемый и т.д. или как существительные
> > ICompare
> > > > > > (компаратор) , а вот методы наооборот, как глаголы или
> > словосочетания.
> > > > > > Здесь все наоборот.
> > > > > > Опять реализация интерфеса оказалась не в том проекте
> > > > > >
> > > > > > —
> > > > > > Reply to this email directly or view it on GitHub
> > > > > > <
> > > >
> > https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
> >
> > > >
> > > > > > .
> > > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub <
> > > >
> > https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
> >
> > > >
> > > > >
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
> >
> > > > .
> > > >
> > > —
> > > Reply to this email directly or view it on GitHub <
> > https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
> >
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
> > .
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380>.
>


I would be more comfortable with `ssl_verify_client on` here.
If we're using a non-standard port for client certificate auth, IMO it should be for that purpose only.

Having a separate port for cert auth appears to be required currently for nginx, but it's very clearly a hack and we should acknowledge that explicitly


this change introduce acces rights problems

a t-field is usually preferable to a t-raw when you want to display a field: the name_get is automatic and you don't need to access the field itself (and you avoid access rights problems)


I am not keen on this, tbh. Setting globals in functions, and then depending on those settings elsewhere, is quite obscure & brittle. Yes, I know we do it elsewhere. And yes, we should use local vars in many places we currently use globals.

I'd be happy for the significant change - adding cidr validation to `weave launch-dns` to go straight on master.


esto me gustaria más que fuera con un

#if 0

#endif

no soy muy amigo de comentar código :(


Je ne sais pas si c'était seulement utilisé ici, mais je pense qu'il faut quelque chose qui définisse en un seul endroit comment on écrit les ids de binets-termes.
Je ne pense pas l'avoir mis au bon endroit, pour l'instant c'est make_term_id dans helper/common


Хорошо получилось, функционально.
Но. Если почитаете теорию про виды разные тестов, то узнаете, что тесты бывают: юнит, модульные, функциональные.
В данном случае написан функциональный тест, потому что он проверяет все от запроса пользователя до отправки письма и перехода по ссылке.

И одно другому не мешает, хотя и градус тестирования разный.
Настоящий юнит-тест в идеале проверяет как работает один конкретный метод.
Например, метод, который отправляет письмо.
При этом этот юнит-тест по настоящему вызывает только сам метод, а все остальное "эмулирует" с помощью Mock-ов, и проверяет, все ли Mock-объекты были использованы, которые должны были использоваться.

Для примера.
Есть класс (объект) А с методом sendConfirmMail и в этом методе конструируется шифрованная ссылка.
Юнит-тест вызывает этот метод А->sendConfirmMail().
Но на самом деле никаких писем отправлять не надо.
Если письма отправляются через Mail::queue, то должен быть создан Mock-объект от класса Mail, а затем должно быть проверено, что queue был вызван именно с теми параметрами, с которыми должен быть вызван.

Предлагаю написать именно такой тест (отдельно).
Подробности например здесь:
http://laravel.com/docs/4.2/testing
http://culttt.com/2013/07/22/getting-started-with-mockery/


That's exactly what I'm doing... thankx for the aid, I just needed confirmations of it. Then when everything is uploaded, you are obviously welcomed to contribute for Gore, more stuff here comes from your repo/projects... maybe I'll do the same for batman doom reborn. Hey, c1m5 is really freaking!


Center-align instead?


Voilà make_term_id. Le nomde la fonction dessous porte à confusion : elle ne produit pas un id mais un bout de chemin.


@biakaveron Apologies - I'll fix.


I think we should be careful about using the term 'schema_name' here. In general we want one schema for each format, and we should represent that model of the world in the API of the test helpers. So I'd prefer to use `format_name` as the argument (or `format`) and to call this method `get_all_for_format`.


as above, I think this would be better named `get_all_for_formats(format_names)`


dffffffff


saw approval from seancribbs
at https://github.com/c-bik/cuttlefish/commit/23666e1716eb6ffd3ab39eb01b6a3f1fe4ef9edf


merging c-bik/cuttlefish/develop = 23666e17 into borshop-integration-187-develop


c-bik/cuttlefish/develop = 23666e17 merged ok, testing candidate = c4684273


Hey, how can I use "discovery.probe" this function?


I'll fix the first line of the message when I push to arm64-dev to be "Update the types used for fpcr and fpsr.".


is it this missing?

https://github.com/temasek/android_art/commit/0d581562927f9b031de12eccd975d6bacd983011

i dont have the -O1 flags, neither the -O3 .


А я фотографию прикрепил, вот ещё раз)

16 марта 2015 г., 17:44 пользователь AnzhelikaKravchuk <
notifications@github.com> написал:

> Я что-то не нашла в письме как)
> --
> С уважением, Кравчук А.И.
>
> > On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com>
> wrote:
> >
> > Значит что то я неправильно делаю, у меня вот так
> >
> > 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
> > notifications@github.com> написал:
> >
> > > Добрый день, Андрей.
> > >
> > > Посмотрела пример с перегрузкой операции с проверкой на null, у меня
> > > проверка работает.
> > > --
> > > С уважением, Кравчук А.И.
> > >
> > > > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com>
> > > wrote:
> > > >
> > > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
> > > вечернем
> > > > вообще программированию не учили, и не у кого что то спросить, или
> кто
> > > бы
> > > > сказал как правильно, а тут вот как раз ответы на все вопросы. Так
> что
> > > > спасибо Вам)
> > > >
> > > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
> > > > notifications@github.com> написал:
> > > >
> > > > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
> > > вопросов.
> > > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде все
> было
> > > ну
> > > > > если не идеально, то почти))
> > > > > --
> > > > > С уважением, Кравчук А.И.
> > > > >
> > > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <
> notifications@github.com>
> > > > > wrote:
> > > > > >
> > > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
> > > серьёзного,
> > > > > всё
> > > > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
> > > интерфейсы
> > > > > > нужны, а теперь понимаю что без них вообще никак)
> > > > > >
> > > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
> > > > > > notifications@github.com> написал:
> > > > > >
> > > > > > > Название интерфейса IGetDiscount лучше заменить на IDiscount,
> > > вообще,
> > > > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия -
> > > > > > > форматируемый, сериализуемый и т.д. или как существительные
> > > ICompare
> > > > > > > (компаратор) , а вот методы наооборот, как глаголы или
> > > словосочетания.
> > > > > > > Здесь все наоборот.
> > > > > > > Опять реализация интерфеса оказалась не в том проекте
> > > > > > >
> > > > > > > —
> > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > <
> > > > >
> > >
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
>
> > >
> > > > >
> > > > > > > .
> > > > > > >
> > > > > > —
> > > > > > Reply to this email directly or view it on GitHub <
> > > > >
> > >
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
>
> > >
> > > > >
> > > > > >
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub
> > > > > <
> > >
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
>
> > >
> > > > > .
> > > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub <
> > >
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
>
> > >
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
>
> > > .
> > >
> > —
> > Reply to this email directly or view it on GitHub <
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380
> >.
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541>
> .
>


remove this completely:

```
 DIR = os.path.abspath(os.path.normpath(os.path.join(
     __file__, '..', '..', '..', '..', '..', 'trytond'
 )))
 if os.path.isdir(DIR):
     sys.path.insert(0, os.path.dirname(DIR))

```


Аа через git не видно, это через gmail

16 марта 2015 г., 17:50 пользователь Андрей Минич <andrew.minich1@gmail.com>
написал:

> А я фотографию прикрепил, вот ещё раз)
>
> 16 марта 2015 г., 17:44 пользователь AnzhelikaKravchuk <
> notifications@github.com> написал:
>
> Я что-то не нашла в письме как)
>> --
>> С уважением, Кравчук А.И.
>>
>> > On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com>
>> wrote:
>> >
>> > Значит что то я неправильно делаю, у меня вот так
>> >
>> > 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
>> > notifications@github.com> написал:
>> >
>> > > Добрый день, Андрей.
>> > >
>> > > Посмотрела пример с перегрузкой операции с проверкой на null, у меня
>> > > проверка работает.
>> > > --
>> > > С уважением, Кравчук А.И.
>> > >
>> > > > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com>
>>
>> > > wrote:
>> > > >
>> > > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
>> > > вечернем
>> > > > вообще программированию не учили, и не у кого что то спросить, или
>> кто
>> > > бы
>> > > > сказал как правильно, а тут вот как раз ответы на все вопросы. Так
>> что
>> > > > спасибо Вам)
>> > > >
>> > > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
>> > > > notifications@github.com> написал:
>> > > >
>> > > > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
>> > > вопросов.
>> > > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде все
>> было
>> > > ну
>> > > > > если не идеально, то почти))
>> > > > > --
>> > > > > С уважением, Кравчук А.И.
>> > > > >
>> > > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <
>> notifications@github.com>
>> > > > > wrote:
>> > > > > >
>> > > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
>> > > серьёзного,
>> > > > > всё
>> > > > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
>> > > интерфейсы
>> > > > > > нужны, а теперь понимаю что без них вообще никак)
>> > > > > >
>> > > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
>> > > > > > notifications@github.com> написал:
>> > > > > >
>> > > > > > > Название интерфейса IGetDiscount лучше заменить на IDiscount,
>> > > вообще,
>> > > > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия -
>> > > > > > > форматируемый, сериализуемый и т.д. или как существительные
>> > > ICompare
>> > > > > > > (компаратор) , а вот методы наооборот, как глаголы или
>> > > словосочетания.
>> > > > > > > Здесь все наоборот.
>> > > > > > > Опять реализация интерфеса оказалась не в том проекте
>> > > > > > >
>> > > > > > > —
>> > > > > > > Reply to this email directly or view it on GitHub
>> > > > > > > <
>> > > > >
>> > >
>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
>>
>> > >
>> > > > >
>> > > > > > > .
>> > > > > > >
>> > > > > > —
>> > > > > > Reply to this email directly or view it on GitHub <
>> > > > >
>> > >
>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
>>
>> > >
>> > > > >
>> > > > > >
>> > > > >
>> > > > > —
>> > > > > Reply to this email directly or view it on GitHub
>> > > > > <
>> > >
>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
>>
>> > >
>> > > > > .
>> > > > >
>> > > > —
>> > > > Reply to this email directly or view it on GitHub <
>> > >
>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
>>
>> > >
>> > > >
>> > >
>> > > —
>> > > Reply to this email directly or view it on GitHub
>> > > <
>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
>>
>> > > .
>> > >
>> > —
>> > Reply to this email directly or view it on GitHub <
>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380
>> >.
>>
>> >
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541>
>> .
>>
>
>


this is probably also something that need not be stored on the `EnumContext`, yeah?


public static Polynomial operator +(Polynomial first, Polynomial second)
            {
                if (first == null || second == null) throw new
ArgumentNullException("Exeption!!!!!!!!!!!!!!!!!!!!!");
                double[] result = new double[Math.Max(first.factors.Length,
second.factors.Length)];
                first.factors.CopyTo(result, result.Length -
first.factors.Length);
                for (int i = second.factors.Length - 1, y = result.Length -
1; i > -1; i--, y--)
                {
                    result[y] += second[i];
                }
                return new Polynomial(result);
            }

16 марта 2015 г., 17:51 пользователь Андрей Минич <andrew.minich1@gmail.com>
написал:

> Аа через git не видно, это через gmail
>
> 16 марта 2015 г., 17:50 пользователь Андрей Минич <
> andrew.minich1@gmail.com> написал:
>
> А я фотографию прикрепил, вот ещё раз)
>>
>> 16 марта 2015 г., 17:44 пользователь AnzhelikaKravchuk <
>> notifications@github.com> написал:
>>
>> Я что-то не нашла в письме как)
>>> --
>>> С уважением, Кравчук А.И.
>>>
>>> > On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com>
>>> wrote:
>>> >
>>> > Значит что то я неправильно делаю, у меня вот так
>>> >
>>> > 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
>>> > notifications@github.com> написал:
>>> >
>>> > > Добрый день, Андрей.
>>> > >
>>> > > Посмотрела пример с перегрузкой операции с проверкой на null, у меня
>>> > > проверка работает.
>>> > > --
>>> > > С уважением, Кравчук А.И.
>>> > >
>>> > > > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com>
>>>
>>> > > wrote:
>>> > > >
>>> > > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
>>> > > вечернем
>>> > > > вообще программированию не учили, и не у кого что то спросить, или
>>> кто
>>> > > бы
>>> > > > сказал как правильно, а тут вот как раз ответы на все вопросы. Так
>>> что
>>> > > > спасибо Вам)
>>> > > >
>>> > > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
>>> > > > notifications@github.com> написал:
>>> > > >
>>> > > > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
>>> > > вопросов.
>>> > > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде
>>> все было
>>> > > ну
>>> > > > > если не идеально, то почти))
>>> > > > > --
>>> > > > > С уважением, Кравчук А.И.
>>> > > > >
>>> > > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <
>>> notifications@github.com>
>>> > > > > wrote:
>>> > > > > >
>>> > > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
>>> > > серьёзного,
>>> > > > > всё
>>> > > > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
>>> > > интерфейсы
>>> > > > > > нужны, а теперь понимаю что без них вообще никак)
>>> > > > > >
>>> > > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
>>> > > > > > notifications@github.com> написал:
>>> > > > > >
>>> > > > > > > Название интерфейса IGetDiscount лучше заменить на
>>> IDiscount,
>>> > > вообще,
>>> > > > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия
>>> -
>>> > > > > > > форматируемый, сериализуемый и т.д. или как существительные
>>> > > ICompare
>>> > > > > > > (компаратор) , а вот методы наооборот, как глаголы или
>>> > > словосочетания.
>>> > > > > > > Здесь все наоборот.
>>> > > > > > > Опять реализация интерфеса оказалась не в том проекте
>>> > > > > > >
>>> > > > > > > —
>>> > > > > > > Reply to this email directly or view it on GitHub
>>> > > > > > > <
>>> > > > >
>>> > >
>>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
>>>
>>> > >
>>> > > > >
>>> > > > > > > .
>>> > > > > > >
>>> > > > > > —
>>> > > > > > Reply to this email directly or view it on GitHub <
>>> > > > >
>>> > >
>>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
>>>
>>> > >
>>> > > > >
>>> > > > > >
>>> > > > >
>>> > > > > —
>>> > > > > Reply to this email directly or view it on GitHub
>>> > > > > <
>>> > >
>>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
>>>
>>> > >
>>> > > > > .
>>> > > > >
>>> > > > —
>>> > > > Reply to this email directly or view it on GitHub <
>>> > >
>>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
>>>
>>> > >
>>> > > >
>>> > >
>>> > > —
>>> > > Reply to this email directly or view it on GitHub
>>> > > <
>>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
>>>
>>> > > .
>>> > >
>>> > —
>>> > Reply to this email directly or view it on GitHub <
>>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380
>>> >.
>>>
>>> >
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541>
>>> .
>>>
>>
>>
>


If you remove the change to `gitconfig-mode` then I could merge this. You would then have to set `indent-tabs-mode` to `nil` using a hook.

Please also put `gitconfig-indentation-string`s body on a single line.


@tamird Yes.


@acrymble You and I keep swapping this back and forth! We can talk about on next Skype meeting, but I actually feel like I belong more in the "usability" category.


@antoinerosselet That's for you ;-) Thanks!


Moving and changing breaks diff on GitHub, so I'm going to assume the only changes you made to amqp_client were to make it jshint compliant.  If that's not true, let me know.


This doesn't hurt, I usually have this in a global `.gitignore` See https://help.github.com/articles/ignoring-files/#create-a-global-gitignore & https://gist.github.com/octocat/9257657


unneeded import


Add a unit test to make sure we always create only one fake crash report


@thomasf Yes, actually `:defer N` I think is the best solution.


Did you decide against the "trimming at the end approach" so we don't have to have the different `if (description) {` blocks ?


Rename fakeCrashReport to template… or something similar?


I'm not seeing the new theme in the 3.3 release.  Cornflower Blue in
Windows Game, and Spinning Cube in Universal Project.

Thanks,

Chris Williams

On Tue, Mar 3, 2015 at 7:07 AM, MonoGame Build Bot <notifications@github.com
> wrote:

> TeamCity MonoGame :: Develop (Win) Build 3.3.0.2207
> <http://teamcity.monogame.net/viewLog.html?buildId=5615&buildTypeId=MonoGame_DevelopWin&guest=1>
> outcome was *SUCCESS*
> Summary: Tests passed: 441, ignored: 6 Build time: 00:14:17
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mono/MonoGame/commit/f84a1c95d0486d6884fc98288af3a5dae6c1da29#commitcomment-10004896>
> .
>


вроде все так

--
С уважением, Кравчук А.И.

> On 16 Mar 2015, at 17:52, andrew-minich1 <notifications@github.com> wrote:
>
> public static Polynomial operator +(Polynomial first, Polynomial second)
> {
> if (first == null || second == null) throw new
> ArgumentNullException("Exeption!!!!!!!!!!!!!!!!!!!!!");
> double[] result = new double[Math.Max(first.factors.Length,
> second.factors.Length)];
> first.factors.CopyTo(result, result.Length -
> first.factors.Length);
> for (int i = second.factors.Length - 1, y = result.Length -
> 1; i > -1; i--, y--)
> {
> result[y] += second[i];
> }
> return new Polynomial(result);
> }
>
> 16 марта 2015 г., 17:51 пользователь Андрей Минич <andrew.minich1@gmail.com>
> написал:
>
> > Аа через git не видно, это через gmail
> >
> > 16 марта 2015 г., 17:50 пользователь Андрей Минич <
> > andrew.minich1@gmail.com> написал:
> >
> > А я фотографию прикрепил, вот ещё раз)
> >>
> >> 16 марта 2015 г., 17:44 пользователь AnzhelikaKravchuk <
> >> notifications@github.com> написал:
> >>
> >> Я что-то не нашла в письме как)
> >>> --
> >>> С уважением, Кравчук А.И.
> >>>
> >>> > On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com>
> >>> wrote:
> >>> >
> >>> > Значит что то я неправильно делаю, у меня вот так
> >>> >
> >>> > 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
> >>> > notifications@github.com> написал:
> >>> >
> >>> > > Добрый день, Андрей.
> >>> > >
> >>> > > Посмотрела пример с перегрузкой операции с проверкой на null, у меня
> >>> > > проверка работает.
> >>> > > --
> >>> > > С уважением, Кравчук А.И.
> >>> > >
> >>> > > > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com>
> >>>
> >>> > > wrote:
> >>> > > >
> >>> > > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
> >>> > > вечернем
> >>> > > > вообще программированию не учили, и не у кого что то спросить, или
> >>> кто
> >>> > > бы
> >>> > > > сказал как правильно, а тут вот как раз ответы на все вопросы. Так
> >>> что
> >>> > > > спасибо Вам)
> >>> > > >
> >>> > > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
> >>> > > > notifications@github.com> написал:
> >>> > > >
> >>> > > > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
> >>> > > вопросов.
> >>> > > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде
> >>> все было
> >>> > > ну
> >>> > > > > если не идеально, то почти))
> >>> > > > > --
> >>> > > > > С уважением, Кравчук А.И.
> >>> > > > >
> >>> > > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <
> >>> notifications@github.com>
> >>> > > > > wrote:
> >>> > > > > >
> >>> > > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
> >>> > > серьёзного,
> >>> > > > > всё
> >>> > > > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
> >>> > > интерфейсы
> >>> > > > > > нужны, а теперь понимаю что без них вообще никак)
> >>> > > > > >
> >>> > > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
> >>> > > > > > notifications@github.com> написал:
> >>> > > > > >
> >>> > > > > > > Название интерфейса IGetDiscount лучше заменить на
> >>> IDiscount,
> >>> > > вообще,
> >>> > > > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия
> >>> -
> >>> > > > > > > форматируемый, сериализуемый и т.д. или как существительные
> >>> > > ICompare
> >>> > > > > > > (компаратор) , а вот методы наооборот, как глаголы или
> >>> > > словосочетания.
> >>> > > > > > > Здесь все наоборот.
> >>> > > > > > > Опять реализация интерфеса оказалась не в том проекте
> >>> > > > > > >
> >>> > > > > > > —
> >>> > > > > > > Reply to this email directly or view it on GitHub
> >>> > > > > > > <
> >>> > > > >
> >>> > >
> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
> >>>
> >>> > >
> >>> > > > >
> >>> > > > > > > .
> >>> > > > > > >
> >>> > > > > > —
> >>> > > > > > Reply to this email directly or view it on GitHub <
> >>> > > > >
> >>> > >
> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
> >>>
> >>> > >
> >>> > > > >
> >>> > > > > >
> >>> > > > >
> >>> > > > > —
> >>> > > > > Reply to this email directly or view it on GitHub
> >>> > > > > <
> >>> > >
> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
> >>>
> >>> > >
> >>> > > > > .
> >>> > > > >
> >>> > > > —
> >>> > > > Reply to this email directly or view it on GitHub <
> >>> > >
> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
> >>>
> >>> > >
> >>> > > >
> >>> > >
> >>> > > —
> >>> > > Reply to this email directly or view it on GitHub
> >>> > > <
> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
> >>>
> >>> > > .
> >>> > >
> >>> > —
> >>> > Reply to this email directly or view it on GitHub <
> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380
> >>> >.
> >>>
> >>> >
> >>>
> >>> —
> >>> Reply to this email directly or view it on GitHub
> >>> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541>
> >>> .
> >>>
> >>
> >>
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215682>.
>


As a separate method, this looks just wrong.


what is it some information?  if you add some examples could be great.


ah yeah sorry :smile: , that's all I did


zzzz


Apparently not.


My build script crashes on
```
[javac] Compiling 14 source files to /Users/esh/work/mag/rolls/spitfire/platforms/android/ant-build/classes
    [javac] /Users/esh/work/mag/rolls/spitfire/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:419: cannot find symbol
    [javac] symbol  : variable LOLLIPOP
    [javac] location: class android.os.Build.VERSION_CODES
    [javac]         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
    [javac]                                                         ^
    [javac] /Users/esh/work/mag/rolls/spitfire/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:420: cannot find symbol
```
Am I doing something wrong ? I've tried rebuilding the project platform folders and trying the highest SDK version.


You didn't update `OpenPgpUtilsTest`. After changing `UserInfo` to `UserId` I get the following for `splitUserIdWithOnlyNameShouldReturnNameOnly`:

```
expected:<Max Mustermann[]> but was:<Max Mustermann[ [this is a nothing]]>
```

Is that an intentional change?


This is optional as well?


I used ```git mv``` so history will be preserved, even though it doesn't look that way from this diff view


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


Sorry. Stupid situation! :-(


You could use node1.is(PythonTokenType.INDENT, PythonTokenType.DEDENT)


Yes, it’s still a pretty easy query language based on Lucene syntax but it is still powerful. Integrate your parser was really easy for me and allows me to build also complex query. I hope to contribute in some ways with this parser but I see that you guys are really smart and you’re doing already an awesome job. Thanks a lot, really!!!

Raffaele Izzia
izziaraffaele@gmail.com

Phone : +31(0) 6 164 445 54
Linkedin : http://www.linkedin.com/in/izziaraffaele <http://www.linkedin.com/in/izziaraffaele>
Email : izziaraffaele@gmail.com <mailto:izziaraffaele@gmail.com>
> Il giorno 16/mar/2015, alle ore 01:37, Lucas Bickel <notifications@github.com> ha scritto:
>
> I was wondering why your visitor works without having any recursion and this query explained it. Orchestrate seems quite easy to integrate if all you need to do is build a string
>
> You are probably missing this case in your visitor though:
>
> eq(id,my-resource-id),and(eq(gender,male),like(name,Resource name))
>
> This wraps the whole AST in an AST\QueryOperation. This is in essence similar to an AST\AndOperation but without explicitly expressing an and (some search machine use cases came to mind when designing it).
>
> Oh and, yeah, these id values won't work with the parser in it's current state. I'll need to take care of that issue before v2.0.0-alpha2.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/izziaraffaele/php-rql-parser/commit/ca88856bb9c39ee9a6a084ab5158b07d66a07e4d#commitcomment-10205672>.
>


Can we not specify the organisers as part of the event creation API ?


Are the elements rooms? or what kind of element?


Но вот оно бросает не то исключение что написано, странно)
16 марта 2015 г. 17:56 пользователь "AnzhelikaKravchuk" <
notifications@github.com> написал:

> вроде все так
>
> --
> С уважением, Кравчук А.И.
>
> > On 16 Mar 2015, at 17:52, andrew-minich1 <notifications@github.com>
> wrote:
> >
> > public static Polynomial operator +(Polynomial first, Polynomial second)
> > {
> > if (first == null || second == null) throw new
> > ArgumentNullException("Exeption!!!!!!!!!!!!!!!!!!!!!");
> > double[] result = new double[Math.Max(first.factors.Length,
> > second.factors.Length)];
> > first.factors.CopyTo(result, result.Length -
> > first.factors.Length);
> > for (int i = second.factors.Length - 1, y = result.Length -
> > 1; i > -1; i--, y--)
> > {
> > result[y] += second[i];
> > }
> > return new Polynomial(result);
> > }
> >
> > 16 марта 2015 г., 17:51 пользователь Андрей Минич <
> andrew.minich1@gmail.com>
> > написал:
> >
> > > Аа через git не видно, это через gmail
> > >
> > > 16 марта 2015 г., 17:50 пользователь Андрей Минич <
> > > andrew.minich1@gmail.com> написал:
> > >
> > > А я фотографию прикрепил, вот ещё раз)
> > >>
> > >> 16 марта 2015 г., 17:44 пользователь AnzhelikaKravchuk <
> > >> notifications@github.com> написал:
> > >>
> > >> Я что-то не нашла в письме как)
> > >>> --
> > >>> С уважением, Кравчук А.И.
> > >>>
> > >>> > On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com>
>
> > >>> wrote:
> > >>> >
> > >>> > Значит что то я неправильно делаю, у меня вот так
> > >>> >
> > >>> > 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
> > >>> > notifications@github.com> написал:
> > >>> >
> > >>> > > Добрый день, Андрей.
> > >>> > >
> > >>> > > Посмотрела пример с перегрузкой операции с проверкой на null, у
> меня
> > >>> > > проверка работает.
> > >>> > > --
> > >>> > > С уважением, Кравчук А.И.
> > >>> > >
> > >>> > > > On 14 Mar 2015, at 22:10, andrew-minich1 <
> notifications@github.com>
> > >>>
> > >>> > > wrote:
> > >>> > > >
> > >>> > > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас
> на
> > >>> > > вечернем
> > >>> > > > вообще программированию не учили, и не у кого что то спросить,
> или
> > >>> кто
> > >>> > > бы
> > >>> > > > сказал как правильно, а тут вот как раз ответы на все вопросы.
> Так
> > >>> что
> > >>> > > > спасибо Вам)
> > >>> > > >
> > >>> > > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
> > >>> > > > notifications@github.com> написал:
> > >>> > > >
> > >>> > > > > Андрей, надеюсь, что Вы не пугаетесь моего большого
> количества
> > >>> > > вопросов.
> > >>> > > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в
> коде
> > >>> все было
> > >>> > > ну
> > >>> > > > > если не идеально, то почти))
> > >>> > > > > --
> > >>> > > > > С уважением, Кравчук А.И.
> > >>> > > > >
> > >>> > > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <
> > >>> notifications@github.com>
> > >>> > > > > wrote:
> > >>> > > > > >
> > >>> > > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы
> ничего
> > >>> > > серьёзного,
> > >>> > > > > всё
> > >>> > > > > > понял. Я вот кстати до этих курсов вообще не понимал для
> чего
> > >>> > > интерфейсы
> > >>> > > > > > нужны, а теперь понимаю что без них вообще никак)
> > >>> > > > > >
> > >>> > > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
> > >>> > > > > > notifications@github.com> написал:
> > >>> > > > > >
> > >>> > > > > > > Название интерфейса IGetDiscount лучше заменить на
> > >>> IDiscount,
> > >>> > > вообще,
> > >>> > > > > > > интерфейсы, если вспомнить FCL именуются чаще как
> причастия
> > >>> -
> > >>> > > > > > > форматируемый, сериализуемый и т.д. или как
> существительные
> > >>> > > ICompare
> > >>> > > > > > > (компаратор) , а вот методы наооборот, как глаголы или
> > >>> > > словосочетания.
> > >>> > > > > > > Здесь все наоборот.
> > >>> > > > > > > Опять реализация интерфеса оказалась не в том проекте
> > >>> > > > > > >
> > >>> > > > > > > —
> > >>> > > > > > > Reply to this email directly or view it on GitHub
> > >>> > > > > > > <
> > >>> > > > >
> > >>> > >
> > >>>
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>
>
> > >>>
> > >>> > >
> > >>> > > > >
> > >>> > > > > > > .
> > >>> > > > > > >
> > >>> > > > > > —
> > >>> > > > > > Reply to this email directly or view it on GitHub <
> > >>> > > > >
> > >>> > >
> > >>>
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>.
>
> > >>>
> > >>> > >
> > >>> > > > >
> > >>> > > > > >
> > >>> > > > >
> > >>> > > > > —
> > >>> > > > > Reply to this email directly or view it on GitHub
> > >>> > > > > <
> > >>> > >
> > >>>
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>
>
> > >>>
> > >>> > >
> > >>> > > > > .
> > >>> > > > >
> > >>> > > > —
> > >>> > > > Reply to this email directly or view it on GitHub <
> > >>> > >
> > >>>
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>.
>
> > >>>
> > >>> > >
> > >>> > > >
> > >>> > >
> > >>> > > —
> > >>> > > Reply to this email directly or view it on GitHub
> > >>> > > <
> > >>>
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>
>
> > >>>
> > >>> > > .
> > >>> > >
> > >>> > —
> > >>> > Reply to this email directly or view it on GitHub <
> > >>>
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380
> > >>> >.
> > >>>
> > >>> >
> > >>>
> > >>> —
> > >>> Reply to this email directly or view it on GitHub
> > >>> <
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541>
>
> > >>> .
> > >>>
> > >>
> > >>
> > >
> > —
> > Reply to this email directly or view it on GitHub <
> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215682
> >.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215778>
> .
>


@chrisgwilliams - Because that PR hasn't been merged yet.


I fear having `null` is not better and may hide further issues, don't you think?


@crackfoo The proper way to do this is copy defaults.toml. I believe this is given in the instructions. defaults.toml is just that, defaults. When you change them it will be a site specific config, and ideally would be named as such.


Be careful with line size and indentation


What about building cwm from cm-11.0 branch with f2fs support?
Did you notice that when you flash lp on cwm line is shown that filed system format is ext4?

And Ariesve team just edited their twrp without building new one


This will work. 't' is only applied to 'Quantified' and 'CoreExpr" here. Though I'm surprised you had to add an extractT... isn't there an Injection CoreTC LCoreTC instance?


43: если ways не нужен снаружи countWays, нужно создать его прямо там.


move up to preserve alpha ordering (I know, pedantic)


sample review


all tests pass:
success: http://buildbot.bos1/builders/test-cuttlefish/builds/143


What kind of condition?, please give a example


Ok, added commit to fix this.


@sindresorhus thanks :+1:


C'est pas une mise à jour, il y a qu'une virgule d'ajoutée pour pouvoir mettre l'autre lib en dessous ^_^
Ca reste la version 0.9.9


Hi Simon,

a) I finally put back a limited version of my userimg; found a number of packages that would not compile (Compose, Cairo, Gadfly, and also GLAbstraction and GLPlot) GLFW and ModernGL compiled OK. I have not understood yet the ordering constraints of such. The day before things were so strange that I decided I wanted a vanilla Julia 0.4 straight out of the Git tree.

b) Your example has allowed me to make progress and to set up a grid of subscreens which resize automagically. When I put only images in the grid all is fine. **When I put 3 images and 1 plot (2D surface), then in 3 subscreens the view is hidden by a uniforme colored backplane (in 3 subscreen the last one showing an image)**. I get to see the plot very briefly when resizing the window with the mouse and during the start up phase(dark window). I guess that I have a signal/event handling problem or a buffer problem
but do not know how to attack this. (I suppose that monitoring the event loop could be interesting)

My code is https://github.com/AlainLich/Romeo.jl/find/master files test/RomeoVolume.jl and test/RomeoLib.jl

c) The next thing I would like to figure out is to draw a scene (lets say 1 cube + 1 sphere), and I have not found examples of such (I thought that I would find this in GLAbstraction tests.. but this did not work). Also
how to integrate this directly in Romeo? Just pass a GLAbstraction built scene to visualize? (*what I would like to achieve for now is representing a graph/plot in one subscreen and synchronously the coordinate system in another subscreen*)

Thanks for your help, this is becoming interesting.

Best
Alain


Oh it's because clauseT's arguments must be LCore.


Ah sry.
Yes this is an intentional change. The case with "[]" brackets is not specified anywhere so I removed the pattern matching for it.
I moved the test into OpenKeychain:
https://github.com/open-keychain/open-keychain/commit/484c3092eecbf775f355879587c2bea7612edac7


Do you have a link which support this change?
I am asking because this [v8 test](https://code.google.com/p/v8/source/browse/branches/bleeding_edge/test/mjsunit/es6/object-tostring.js) still expects `~`.


Update SMSG_SET_PHASE_SHIFT_CHANGE sending to new format


It would be nice to avoid the duplication with the code in create_bridge. Only if that doesn't turn out to be hideous, if course.


You might be interested in my new premium version.  I've completely refactored Android.
http://christocracy.github.io/cordova-background-geolocation/

- No more ForegroundService
- No more in-plugin HTTP -- plugin now executes javascript callback just like ios.
- Significant battery efficiency with FusedLocationProvider.
- No more stationary geo-fence.  Uses android activity-detection api.


Попробуйте в LINQPade такой код

void Main()
{
	Point p1 = new Point(), p2 = null;
	try
	{
		Point p3 = p1 + p2;
		p3.Dump();
	}
	catch(ArgumentNullException ex)
	{
		ex.Dump();
	}
}

class Point
{
	public int x;

	public static Point operator + (Point lhs, Point rhs)
	{
		if(lhs == null || rhs == null)
			throw new ArgumentNullException();
		Point p = new Point(){ x = lhs.x + rhs.x };
		return p;
	}
}

--
С уважением, Кравчук А.И.

> On 16 Mar 2015, at 17:56, Anzhelika Kravchuk <anzhelika.kravchuk@gmail.com> wrote:
>
> вроде все так
>
> --
> С уважением, Кравчук А.И.
>
>> On 16 Mar 2015, at 17:52, andrew-minich1 <notifications@github.com <mailto:notifications@github.com>> wrote:
>>
>> public static Polynomial operator +(Polynomial first, Polynomial second)
>> {
>> if (first == null || second == null) throw new
>> ArgumentNullException("Exeption!!!!!!!!!!!!!!!!!!!!!");
>> double[] result = new double[Math.Max(first.factors.Length,
>> second.factors.Length)];
>> first.factors.CopyTo(result, result.Length -
>> first.factors.Length);
>> for (int i = second.factors.Length - 1, y = result.Length -
>> 1; i > -1; i--, y--)
>> {
>> result[y] += second[i];
>> }
>> return new Polynomial(result);
>> }
>>
>> 16 марта 2015 г., 17:51 пользователь Андрей Минич <andrew.minich1@gmail.com <mailto:andrew.minich1@gmail.com>>
>> написал:
>>
>> > Аа через git не видно, это через gmail
>> >
>> > 16 марта 2015 г., 17:50 пользователь Андрей Минич <
>> > andrew.minich1@gmail.com <mailto:andrew.minich1@gmail.com>> написал:
>> >
>> > А я фотографию прикрепил, вот ещё раз)
>> >>
>> >> 16 марта 2015 г., 17:44 пользователь AnzhelikaKravchuk <
>> >> notifications@github.com <mailto:notifications@github.com>> написал:
>> >>
>> >> Я что-то не нашла в письме как)
>> >>> --
>> >>> С уважением, Кравчук А.И.
>> >>>
>> >>> > On 16 Mar 2015, at 17:37, andrew-minich1 <notifications@github.com <mailto:notifications@github.com>>
>> >>> wrote:
>> >>> >
>> >>> > Значит что то я неправильно делаю, у меня вот так
>> >>> >
>> >>> > 16 марта 2015 г., 17:15 пользователь AnzhelikaKravchuk <
>> >>> > notifications@github.com <mailto:notifications@github.com>> написал:
>> >>> >
>> >>> > > Добрый день, Андрей.
>> >>> > >
>> >>> > > Посмотрела пример с перегрузкой операции с проверкой на null, у меня
>> >>> > > проверка работает.
>> >>> > > --
>> >>> > > С уважением, Кравчук А.И.
>> >>> > >
>> >>> > > > On 14 Mar 2015, at 22:10, andrew-minich1 <notifications@github.com <mailto:notifications@github.com>>
>> >>>
>> >>> > > wrote:
>> >>> > > >
>> >>> > > > Да мне наоборот очень нравятся курсы! я ведь говорил что у нас на
>> >>> > > вечернем
>> >>> > > > вообще программированию не учили, и не у кого что то спросить, или
>> >>> кто
>> >>> > > бы
>> >>> > > > сказал как правильно, а тут вот как раз ответы на все вопросы. Так
>> >>> что
>> >>> > > > спасибо Вам)
>> >>> > > >
>> >>> > > > 14 марта 2015 г., 21:22 пользователь AnzhelikaKravchuk <
>> >>> > > > notifications@github.com <mailto:notifications@github.com>> написал:
>> >>> > > >
>> >>> > > > > Андрей, надеюсь, что Вы не пугаетесь моего большого количества
>> >>> > > вопросов.
>> >>> > > > > Мне нравится, как Вы работаете, поэтому хочется, чтобы в коде
>> >>> все было
>> >>> > > ну
>> >>> > > > > если не идеально, то почти))
>> >>> > > > > --
>> >>> > > > > С уважением, Кравчук А.И.
>> >>> > > > >
>> >>> > > > > > On 14 Mar 2015, at 21:03, andrew-minich1 <
>> >>> notifications@github.com <mailto:notifications@github.com>>
>> >>> > > > > wrote:
>> >>> > > > > >
>> >>> > > > > > О, спасибо что посмотрели, ошибки исправлю, вроде бы ничего
>> >>> > > серьёзного,
>> >>> > > > > всё
>> >>> > > > > > понял. Я вот кстати до этих курсов вообще не понимал для чего
>> >>> > > интерфейсы
>> >>> > > > > > нужны, а теперь понимаю что без них вообще никак)
>> >>> > > > > >
>> >>> > > > > > 14 марта 2015 г., 20:00 пользователь AnzhelikaKravchuk <
>> >>> > > > > > notifications@github.com <mailto:notifications@github.com>> написал:
>> >>> > > > > >
>> >>> > > > > > > Название интерфейса IGetDiscount лучше заменить на
>> >>> IDiscount,
>> >>> > > вообще,
>> >>> > > > > > > интерфейсы, если вспомнить FCL именуются чаще как причастия
>> >>> -
>> >>> > > > > > > форматируемый, сериализуемый и т.д. или как существительные
>> >>> > > ICompare
>> >>> > > > > > > (компаратор) , а вот методы наооборот, как глаголы или
>> >>> > > словосочетания.
>> >>> > > > > > > Здесь все наоборот.
>> >>> > > > > > > Опять реализация интерфеса оказалась не в том проекте
>> >>> > > > > > >
>> >>> > > > > > > —
>> >>> > > > > > > Reply to this email directly or view it on GitHub
>> >>> > > > > > > <
>> >>> > > > >
>> >>> > >
>> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199352>>
>> >>>
>> >>> > >
>> >>> > > > >
>> >>> > > > > > > .
>> >>> > > > > > >
>> >>> > > > > > —
>> >>> > > > > > Reply to this email directly or view it on GitHub <
>> >>> > > > >
>> >>> > >
>> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199634>>.
>> >>>
>> >>> > >
>> >>> > > > >
>> >>> > > > > >
>> >>> > > > >
>> >>> > > > > —
>> >>> > > > > Reply to this email directly or view it on GitHub
>> >>> > > > > <
>> >>> > >
>> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199722>>
>> >>>
>> >>> > >
>> >>> > > > > .
>> >>> > > > >
>> >>> > > > —
>> >>> > > > Reply to this email directly or view it on GitHub <
>> >>> > >
>> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10199900>>.
>> >>>
>> >>> > >
>> >>> > > >
>> >>> > >
>> >>> > > —
>> >>> > > Reply to this email directly or view it on GitHub
>> >>> > > <
>> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10214845>>
>> >>>
>> >>> > > .
>> >>> > >
>> >>> > —
>> >>> > Reply to this email directly or view it on GitHub <
>> >>> https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215380>
>> >>> >.
>> >>>
>> >>> >
>> >>>
>> >>> —
>> >>> Reply to this email directly or view it on GitHub
>> >>> <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541 <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215541>>
>> >>> .
>> >>>
>> >>
>> >>
>> >
>> —
>> Reply to this email directly or view it on GitHub <https://github.com/andrew-minich1/ASP.NET.1501.Minich.Day4/commit/93734367e7d64d46a9c1fdb0e97490f7d122a212#commitcomment-10215682>.
>>
>


Кажется все ок, я засчитаю ее. Единственное, на 18 не должно быть объявления i, оно уже есть в цикле на следующей строке.


:+1: I'll remove the test


Seems like a good suggestion to me.


code duplication, factor out in a method?


Can you add a few more spaced?   Those of us blessed with the Real Editor just do M-q to refloat/format the paragraph.


Yes. Mainly because I didn't quite get what you were hinting at, but also because we still need to check if there's already some string in the description right?


Ahhh ok, good to know.  And great job on the new release!

Thanks,

Chris Williams

On Mon, Mar 16, 2015 at 10:58 AM, Tom Spilman <notifications@github.com>
wrote:

> @chrisgwilliams <https://github.com/chrisgwilliams> - Because that PR
> hasn't been merged yet.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mono/MonoGame/commit/f84a1c95d0486d6884fc98288af3a5dae6c1da29#commitcomment-10215840>
> .
>


Excellent - happy to get rid of those utils wherever possible.  Do you know of one that would replace my deepMerge method?  I really tried not to write that one, but I couldn't find an implementation that kept object identity for properties deeper in the hierarchy (e.g. a child AMQPSymbol property turned into "object").


Ugh, I hate when linting tools start making things *less* clear.


screen.unfreeze() does not use this parameter, right?


En effet c'est utilisé à énormément d'endroits. On pourra remplacer partout.


Тут тоже ок. Кстати, множественное число от index -- indices. Про кирпич можешь просто проигнорировать.


@runephilosof This was discussed in https://github.com/rails/rails/pull/14166


Si tu peux me dire quand c'est intégré, j'ai un autre PR sympa qui est prêt pour un affiche plus joli des lancés de dés.


> code duplication, factor out in a method?

yep, you're right... refactoring


Please use LOGGER.  printing stack trace is bad practice


nnnnnnnnnnnnnnnnn


@noodlefrenzy yeah actually lodash has _.merge which looks like it does what you're deep merge does. I started porting that yesterday, but then I ran into a weird case where you do a deepMerge with a single parameter and figured I'd hold off until I better understood the intention.


removed in 85af98d