Is this supposed to remove anything but originalMonthsPicturePage? Presumably that has this class, since you take trouble to remove it...is that required for this to work?


Does not seem to work with click...
Either we can use nargs bit then with a fixed number of arguments or we can use multiple=True like now.


Do not forget to git tag also before npm publish, nice!


Everything looks fine to me, the documentation covers the cases that I wasn't able to get to work initially as well as other relevant ones.


`scala.collection.immutable.Map[A, B]` extends `Iterable[(A, B)]`, so I feel like all we need is `CanBuildFrom[Map[A, B], (A, B), Map[A, B]]`. This seems to be there:

```scala
scala> trait Foo
defined trait Foo

scala> trait Bar
defined trait Bar

scala> implicitly[scala.collection.generic.CanBuildFrom[Map[Foo, Bar], (Foo, Bar), Map[Foo, Bar]]]
res0: scala.collection.generic.CanBuildFrom[Map[Foo,Bar],(Foo, Bar),Map[Foo,Bar]] = scala.collection.generic.GenMapFactory$MapCanBuildFrom@406492c

scala> Map(1 -> "foo") map { case (k, v) => (k + 1, v) }
res1: scala.collection.immutable.Map[Int,String] = Map(2 -> foo)
```


Would it be clearer to just set previous to originalMonthsPicturePage? A name like 'pageToInsertAfter' might convey the intent better.


Looks good to me. Merge after Travis IMO.


Shouldn't that be `private`, or at least `protected`?


What? Is this intended as a debugging statement? This can't go in production code


Great, that's helpful.


Thanks for this suggestion. I actually fixed this in a different way, by adding README.md as a symlink (since github isn't Meld's primary home).


include `counter` in the toString also?


FYI - This rename wasn't intentional... Just fast forwarding some 1.8 changes in to prepare for 1.9 and missed the variable name part when handling the merge conflict.


@stevenroose Do you want to file that issue, since you've recently experienced confusion here?


What is this?


Should be: data.WriteBit(1);


Can you keep with the remaining style? We're not huge on forced style, but if () { should be on one line, thanks. Otherwise, these chained conditionals are really hard to read.


Yes I agree. I'm used to PEP8 that's why I keep beeing inconsistent.
But if you really want [ x ] and f( x ) I'll try do do it that way.


The cObject FORM has been moved as well. Documented with https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/commit/bd48b0e3b5385ae99a66848c2c7efb0dcb79976f


I'd much rather throw a warning here and use "Xx" (atomic number 0) since the user will spot the problem immediately.


See my comments, but with some minor fixes, this is good to go.


Not used. Review code before commiting changes.


This is surprising...perhaps only because I still have trouble sometimes working out what 'this' is in JS. If 'this' is the whole CalendarConfigurator it's strange that we 'initialize' it for each month.


Sorry I thought we had thos conversation a couple of days ago.
You liked the idea with docstrings so I started to change everything into that...


Maybe these should be like:
` /^helplink\.([^\.]*)\.title$/`
so that the helplink name can't have a . in it?


I was initially thinking that it would be just for this branch. Now that I think about it, though, it would probably make more sense to update the `getExpiryDate()` function in OmniPay/Common so that it doesn't give out spurious dates and just returns null when it's not set.


Good catch :)


This doesn't appear to me to draw anything, rather it creates the content of the calendar page bottom. Name could be improved.


I would deny user creation if there if even 1 characters dropped/changed by clean_username().

Give the user the chance to edit his input instead of creating a username he doesn't want.

Didn't dived into code, just quick anwser.


let's move this into utils/multiversion/install.sh?


So we should drop "clean_username" imo


Oh... no.   Browserify 9.x ALWAYS passes a config object in.  If you don't specify one, it passes in `{}`.  :(


What if a leaf plan projects endpoints of multiple relationship arguments (i.e. solves multiple pattern relationships)? Would like to see a test around this to ensure that initTable puts the leafplan in the right spot in the plan table.


Nah, @JeffBezanson gets his name in there even though he's not a top three contributor ;-)

We could take the names out altogether, since they're not really necessary, but I kind of like having them in there.


@djazayeri  while you are in Chicago you think you can find a UX person to fix this hack style that I did? :)  ^^


In what sense is this a holiday text?


would it be bad if it does?


Will this also include ways to modify the appbar/statusbar during the activity lifecycle? e.g. change the color from the initial one.


@rvagg doh, I always use `PR:`. I'll use PR-URL next time.


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2160 of 2183 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.95%25-yellow.svg)


meh, i guess not necessarily


I haven't tested it yet, but why should this change fix the issue?
The scope = SCOPE_GROUP_TEMPLATE only when the role is a Site Role which would mean that this fix wouldn't work for Regular Roles. But even for Site Role, the previously existing clause in the condition was that the category is one of a control panel portlet which should not even be available for Site Roles.

Thoughts?


89812206_radiance_fix (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It appears we would only have to pass wrapper to this one method to remove the need for it to be a member.


@jwforres roger...hoping to get rid off this soon


CBECC (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Oh, you are right. I forgot to change this :-/ I will look into this as soon as possible


For this method you pass the parent element into which things should be inserted, for the others you make them member variables. It would be better to be consistent. Where something isn't widely used by many methods I tend to favor passing the container. Another reason is that it's very fundamental to what these methods do to insert things into a particular container. Having to set a member variable to the desired container first obscures this.


Okay! But I would prefer *not* to split between MinGW and MSys2 packages... that would make maintaining more cumbersome than absolutely necessary.


PORTS: http://www.sbsfaq.com/?p=3730


:-1: these changes would cause problems that will be hard to fix. Please rever this.


Never knew! You could have deleted it earlier, about four years ago :-)


What failures are you anticipating that will be caught?  I am increasingly wary of just catching exceptions, although this might be justified.


Now it becomes clear this must be a jsonString. How about calling it jsonConfig both here and in the calling method?


Hi, David,

I have time for one quick clarification, before I finish reading the rest...

I'm not suggesting you create different branches for different issues.
I'm suggesting that you just commit each fix separately, sequentially, on
your single branch.  The pull request will then let me see separate
commits to merge or not merge individually, as I deem necessary, but still
all on one branch.

Scott

> Hi Scott,
>
> Glad my contributions thus far are helpful. Feel free to ask me if you
> need
> clarification on any of them.
>
> I'm still getting used to the githib work flow paradigm. I can definitely
> see the advantage of separate commits, but I still tend to think and work
> in a more linear dependent fashion (root + A) then (root + A + B) then
> (root + A + B + C) instead of treating them as parallel and independent
> branches from a common root: (root -> branch A), (root -> branch B) and
> (root -> branch C) which could eventually be merged back into (master + A
> +
> B + C) or any other combination. I just need to force myself to think that
> way when I run into a new issue and want to just jump on it and fix it
> right away, especially when it's a one-line fix. Anyway, I'll try to do
> better with that part. It's a useful discipline.
>
> Regarding the Permutation.java bug, I suspect you are probably concerned
> that the method was being called incorrectly from elsewhere and that the
> fix I have proposed might be masking another bigger problem. The fact is,
> I
> didn't fix it as a result of any problem that I encountered. I simply
> noticed that code while I was single stepping through an unrelated issue
> and the incorrect upper limit happened to catch my eye as a common
> easy-to-miss faux pas. I don't know of any place that the function
> actually
> gets called with the invalid value, but being a bit of a purist, I decided
> to override the old "If it ain't broke, don't fix it." adage and make the
> correction anyway to prevent a potential problem in the future.
>
> Regarding ANTLR, I'd definitely like to see it integrated into the build
> as
> you suggest. In fact, since I was unfamiliar with it, I downloaded the
> latest version (4.5) along with supporting plug-ins for eclipse, netbeans
> and intelij. I've already spent several hours going through the whole
> ANTLR
> 2.0 tutorial at http://javadude.com/articles/antlrtut/ as well as the
> entire ANTLR 3.0 video tutorial at
> http://javadude.com/articles/antlr3xtut/.
> Both of them are developed by the same guy who does a really excellent
> job.
> Unfortunately, I don't see a 4.0 tutorial by him. Having worked briefly
> with lex and yacc in the '80's, and having written a small recursive
> descent language parser and interpreter for SNMP from scratch in C and C++
> around the same time, I am familiar with the concepts involved, so I have
> been playing with it a good bit this past week. I did note that the ANTLR
> grammar itself has evolved with each major release and so they are not
> completely backwards compatible with prior major releases. That said, I
> wouldn't mind helping to migrate zomic to a newer version (either 3.x or
> 4.x) if you'll help with the regression testing. On the other hand, I know
> that the  if you want to leave zomic alone and only do small maintenance
> fixes (like the EOF fix within comments) then that's your call and I'm OK
> with it either way. Vzome currently uses ANTLR 2.7.2, but since it's so
> old, most of the info I have been able to find online is not directly
> applicable. Also, many of the available plug-ins for visualizing the ASTs
> (including all of the ones I have installed) are designed to work with 3.x
> or 4.x. Finally, you mentioned that you are working on a Python API for
> vzome, which presumably would provide all of the zomic functionality and
> more. If you think our time would be better spent working on that, I'd be
> glad to do that instead. In case you'e interested, I came across a library
> of grammar definitions for different languages including python at
> https://github.com/antlr/grammars-v4. Note that these are all written for
> ANTLR 4.x, so there's one more reason to upgrade. I suspect that zomic
> could remain static using the ANTLR 2.x library and the new Python API
> could coexist with it in vzome-core using ANTLR 4.5, but I'm not sure if
> that's so, or if it's a good idea either. Anyway, I still have several
> other questions and ideas and suggestions for zomic (and/or Python) that
> we
> we'll need to discuss some other time.
>
> On Thu, Mar 5, 2015 at 2:50 AM, Scott Vorthmann <notifications@github.com>
> wrote:
>
>> All good stuff, David. I'll probably take most of these as manual fixes;
>> I
>> want to think a little more deeply about a couple of them, as the core
>> defect may be elsewhere.
>>
>> One hint for future reference: you can make an individual commit for
>> each
>> separate bug fix. This would be much preferable for me, since I could
>> pull
>> then selectively merge certain commits using git, rather than
>> copy-paste.
>>
>> Another request: please create a defect for the Permutation.java bug,
>> and
>> explain how to reproduce it, attaching a vZome file if necessary.
>>
>> I'll try to reproduce all the others, and I'll let you know if I fail.
>>
>> Finally, yes, I'll verify how you incorporated the EOF fix into the
>> ANTLR
>> grammars, and while I'm at it, I'll work out how to make ANTLR part of
>> the
>> build, even if an optional part.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/david-hall/vzome-core/commit/c9d4e7cb6dd0183b787fec6a1d32362be0f289fe#commitcomment-10046183>
>> .
>>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/david-hall/vzome-core/commit/c9d4e7cb6dd0183b787fec6a1d32362be0f289fe#commitcomment-10077190


@westcripp I tested this and not working. it still needs systemui restart. For now at lease


Thanks for setting all this up Jason. First, I'll be concentrating on the hiding on load, which in testing works well. Beyond that, I'll modify the disabled actions to hide instead, which I think is a better user experience. For whatever reason though my original filtering setup isn't working now. Not sure what the issue there is (as we made no change to the live files) but you can see by jumping around on options here: http://mp.eomedia.webfactional.com/tractors/


@the-twee learn to use `git revert`


Yeah. I just don't know how to github, sorry.


This is not any better.  It is still not reentrant.


Neat that we can get rid of all the MooTools stuff for so little code. It actually makes pretty good sense the way it is...I wouldn't object strongly to merging it. Up to you whether any of my comments are worth acting on.


Well I will see ya looper


> But if it doesn't get updated when there are breaking changes

I'm saying we need to remember to update it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12431/testReport/) for this commit**


Typo?


now I know this isn't a one-off I've updated changelog-maker: https://github.com/rvagg/changelog-maker/commit/04e19598c01b51cf3cc23fc7e38e6f41bdfa5e84


尽量保证每行代码不超过100字符


注释的双斜杠后加单空格


取消单行if，加大括号


Yeah I just wanted to mess around with Markdown for a project I'm working on. It's really awesome, give it a shot sometime!


Not needed, for reference: https://source.android.com/devices/storage/config-example.html


feel free to submit something that works better. In the mean time this WORKS on all officially supported systems and nothing else does...


This commit is implicated in breaking unwinding on ubuntu 14 compiled with debugging.  Please see:
  https://github.com/facebook/hhvm/issues/4946


This was done after speaking with Ian, the Great Disk Guru of Charrisburg (nee Cloverfield). Reallocate will occasionally fail. I don't know why :). I'm very wary of this as well. But in general we seem to agree for now that we never want to fail when reallocate fails, regardless of the reason. We'd rather have incorrect disk allocations than lose processing time and real work, while generating RT tickets.


添加变量声明，亦可作为重置，因为程序中有大量全局变量，所以显式声明是必要的


数组的内容换行书写，属个人风格


I'll put a test in this branch anyway, so if this workaround can be removed, we can know it hasn't broken the driver.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12432/testReport/) for this commit**


注意这些echo，如果是debug用的，可以移除


I have mixed feelings about this. It's certainly still bizarre to have a Bloom document without a head. OTOH, nothing we're doing here really cares. If there's no head there's certainly no base in it, which is all we're trying to achieve. I lean towards just stopping if there's no head.


You're Welcome jj.


Whitespace in front :)


Ok, 1.3.3 fixes this by merging the keys from the passed-in-config over top of any config found from package.json.  I'm not overly enamoured with this solution, because I'd rather not spend time hunting down package.json - I'd rather just take the config that was passed in.  But I don't have a better solution for now.  :/


关联数组作参数是亦换行书写，防止单行调用过长，也属个人风格


give a space `media_object (optional)`


Is there a reason we don't put the images into the repo directly? See #8

I would vote for putting them in the repo as it's way easier to manipulate the image later (the images are quite larg'ish and I would like to downsize them) If no one objects, I'll copy them over.

![screen shot 2015-03-06 at 22 50 12](https://cloud.githubusercontent.com/assets/164400/6537038/2f645bc2-c453-11e4-9004-c8713d04659c.png)


I should really be ashamed of myself


#BEWM


beside in 2.1.0 we did  not tun ON use system JPEG/PNG for VTK so as you explained me if you don't tell it to use system it will build its own. So basically my patch makes it work THE SAME AS BEFORE on mac and BETTER on Linux


统一变量名格式，所有lower_under（小写字母下划线分割）改为camelCase。并不是说camelCase一定好，只是要统一格式。根据风格，也可以全调整为lower_under。在php5以前，大多是lower_under，但5以后面向对象越来越多所以现在更倾向于camelCase


exactly as i was thinking... for creating objects with peewee use create()


(BLABLA)是我不太了解具体功能所以留给你写。在if else最前面的注释只需大致说明逻辑即可，具体的需要进一步注释的内容则在if else体内继续加就可以


This should really be l10nId instead of a string. See: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs

NotificationHelper.send already accepts l10nIds as bodyL10n: https://github.com/mozilla-b2g/gaia/blob/master/shared/js/notification_helper.js#L28


Whoops, sorry about that.


Hi,

I saw your commits for this repository. Even I too wanted to contribute for this repository have some doubts in it can I ask you.


This patch is correct, but there are many more changes needed to support r70. See my pull request https://github.com/RobotWebTools/ros3djs/pull/106 for the updates I had to make to the full codebase.


and on mac everything but VTK seems to be happy with system JPEG/PNG so it makes for a faster/easier build. VTK was not using our own JPEG/PNGs anyway...


其余的修改我就不一一comment了，有些逻辑不是一看就能明白的最好就写上注释，我都以(MANQUE D'EXPLICATION SUR LA LOGIQUE)等标注了


@Myoldmopar do you have any idea if there's a pattern that causes this to be a problem? I'm looking at this:

https://github.com/lefticus/decent_ci/blob/master/ci.rb#L276

Which cleans up each build after it has completed, and this: https://github.com/lefticus/decent_ci/blob/master/ci.rb#L294

which cleans up each regression baseline build after the entire run has completed... so I am at a loss as to how folders are getting left behind.


Go


@carpodaster do eet! sorry, old habits... :/


I find these code confusing. Can we combine ```indexingPair()``` and ```indexingPairs()``` into one method?


Fast as usual :P


You get a free "you get to pass go, collect your reward" Monopoly award for this one ;-). But yeah, in future, even small changes do need a pull request. I know it sounds a bit pedantic, but we're really trying to establish the "two pairs of eyes" principle here.


Ha!  You beat me to it.


Function docblocks should be in third person.
Thank you for improving indentation!


OK. I see the difference. That makes it a lot simpler to manage. I'll give
it a shot.

On Fri, Mar 6, 2015 at 4:43 PM, Scott Vorthmann <notifications@github.com>
wrote:

> Hi, David,
>
> I have time for one quick clarification, before I finish reading the
> rest...
>
> I'm not suggesting you create different branches for different issues.
> I'm suggesting that you just commit each fix separately, sequentially, on
> your single branch. The pull request will then let me see separate
> commits to merge or not merge individually, as I deem necessary, but still
> all on one branch.
>
> Scott
>
>
>
> > Hi Scott,
> >
> > Glad my contributions thus far are helpful. Feel free to ask me if you
> > need
> > clarification on any of them.
> >
> > I'm still getting used to the githib work flow paradigm. I can definitely
> > see the advantage of separate commits, but I still tend to think and work
> > in a more linear dependent fashion (root + A) then (root + A + B) then
> > (root + A + B + C) instead of treating them as parallel and independent
> > branches from a common root: (root -> branch A), (root -> branch B) and
> > (root -> branch C) which could eventually be merged back into (master + A
> > +
> > B + C) or any other combination. I just need to force myself to think
> that
> > way when I run into a new issue and want to just jump on it and fix it
> > right away, especially when it's a one-line fix. Anyway, I'll try to do
> > better with that part. It's a useful discipline.
> >
> > Regarding the Permutation.java bug, I suspect you are probably concerned
> > that the method was being called incorrectly from elsewhere and that the
> > fix I have proposed might be masking another bigger problem. The fact is,
> > I
> > didn't fix it as a result of any problem that I encountered. I simply
> > noticed that code while I was single stepping through an unrelated issue
> > and the incorrect upper limit happened to catch my eye as a common
> > easy-to-miss faux pas. I don't know of any place that the function
> > actually
> > gets called with the invalid value, but being a bit of a purist, I
> decided
> > to override the old "If it ain't broke, don't fix it." adage and make the
> > correction anyway to prevent a potential problem in the future.
> >
> > Regarding ANTLR, I'd definitely like to see it integrated into the build
> > as
> > you suggest. In fact, since I was unfamiliar with it, I downloaded the
> > latest version (4.5) along with supporting plug-ins for eclipse, netbeans
> > and intelij. I've already spent several hours going through the whole
> > ANTLR
> > 2.0 tutorial at http://javadude.com/articles/antlrtut/ as well as the
> > entire ANTLR 3.0 video tutorial at
> > http://javadude.com/articles/antlr3xtut/.
> > Both of them are developed by the same guy who does a really excellent
> > job.
> > Unfortunately, I don't see a 4.0 tutorial by him. Having worked briefly
> > with lex and yacc in the '80's, and having written a small recursive
> > descent language parser and interpreter for SNMP from scratch in C and
> C++
> > around the same time, I am familiar with the concepts involved, so I have
> > been playing with it a good bit this past week. I did note that the ANTLR
> > grammar itself has evolved with each major release and so they are not
> > completely backwards compatible with prior major releases. That said, I
> > wouldn't mind helping to migrate zomic to a newer version (either 3.x or
> > 4.x) if you'll help with the regression testing. On the other hand, I
> know
> > that the if you want to leave zomic alone and only do small maintenance
> > fixes (like the EOF fix within comments) then that's your call and I'm OK
> > with it either way. Vzome currently uses ANTLR 2.7.2, but since it's so
> > old, most of the info I have been able to find online is not directly
> > applicable. Also, many of the available plug-ins for visualizing the ASTs
> > (including all of the ones I have installed) are designed to work with
> 3.x
> > or 4.x. Finally, you mentioned that you are working on a Python API for
> > vzome, which presumably would provide all of the zomic functionality and
> > more. If you think our time would be better spent working on that, I'd be
> > glad to do that instead. In case you'e interested, I came across a
> library
> > of grammar definitions for different languages including python at
> > https://github.com/antlr/grammars-v4. Note that these are all written
> for
> > ANTLR 4.x, so there's one more reason to upgrade. I suspect that zomic
> > could remain static using the ANTLR 2.x library and the new Python API
> > could coexist with it in vzome-core using ANTLR 4.5, but I'm not sure if
> > that's so, or if it's a good idea either. Anyway, I still have several
> > other questions and ideas and suggestions for zomic (and/or Python) that
> > we
> > we'll need to discuss some other time.
> >
> > On Thu, Mar 5, 2015 at 2:50 AM, Scott Vorthmann <
> notifications@github.com>
> > wrote:
> >
> >> All good stuff, David. I'll probably take most of these as manual fixes;
> >> I
> >> want to think a little more deeply about a couple of them, as the core
> >> defect may be elsewhere.
> >>
> >> One hint for future reference: you can make an individual commit for
> >> each
> >> separate bug fix. This would be much preferable for me, since I could
> >> pull
> >> then selectively merge certain commits using git, rather than
> >> copy-paste.
> >>
> >> Another request: please create a defect for the Permutation.java bug,
> >> and
> >> explain how to reproduce it, attaching a vZome file if necessary.
> >>
> >> I'll try to reproduce all the others, and I'll let you know if I fail.
> >>
> >> Finally, yes, I'll verify how you incorporated the EOF fix into the
> >> ANTLR
> >> grammars, and while I'm at it, I'll work out how to make ANTLR part of
> >> the
> >> build, even if an optional part.
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/david-hall/vzome-core/commit/c9d4e7cb6dd0183b787fec6a1d32362be0f289fe#commitcomment-10046183
> >
> >> .
> >>
> >
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/david-hall/vzome-core/commit/c9d4e7cb6dd0183b787fec6a1d32362be0f289fe#commitcomment-10077190
>
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/david-hall/vzome-core/commit/c9d4e7cb6dd0183b787fec6a1d32362be0f289fe#commitcomment-10080231>
> .
>


@r-darwish FYI - this was probably a remnant of an older change, and caused the tar file to explode (including node_modules).


presumably not permanent? we should file a bug to DNS cname 'beta.uproxy.org' or 'feedback.uproxy.org' to alias this if the production 'uproxy.org' doesn't do what we need.


Ignore the change above (excluding webapp/) - I reverted it in the latest commit


This could interfere with LINQ queries where the query provider supports `NewArrayInit` expressions but not `Call` expressions.

Consider the snippet below.

    public class C {
        public void M() {
            Expression<Action<F>> e = f => f();
        }

        public delegate void F(params int[] args);
    }

The compiler would rewrite `M` as something like this:

    public void M()
    {
        var p = Expression.Parameter(typeof(C.F), "f");
        Expression.Lambda<Action<C.F>>(
            Expression.Invoke(
                p,
                Expression.Call(null, methodof(System.Array.Empty()))),
            p);
    }

Without the `Array.Empty<T>()` optimization, the LINQ expression tree emitted would not contain any `Call` expressions.


edited for test


refs #2725


`%>` => `-%>` will get rid of some of the noise here. And using `unless` or `if !` instead of `if not` should make rubocop happier (not sure if rubocop checks templates).


The reason why I frequently have a bunch of i* variable as class members (normally in things I know I have to call a lot) is to avoid creating new vars every time a function is called; if I know it's only used in a very linear fashion, I just keep rewriting to the same var.

Granted, this is a leftover from some AS3 optimization I've done that had observably minimized garbage collection. I'm not 100% sure it's going to help here as local vars might get collected right after the function is executed? I'll need to test again.


Is this a good spot for this (on a real VM)?  I thought we tended to put things in `/var/stackato`, but I can see how that can be difficult on a local test


been seein a lot of people using fish, haven't heard of prezto!


Added some Cvars in practicemode, that should be there..

public void OnSetupMenuSelect(Menu menu, MenuAction action, int param1, int param2) {
    int client = param1;
    char buffer[64];
    menu.GetItem(param2, buffer, sizeof(buffer));
    if (StrEqual(buffer, "launch_practice")) {
        g_InPracticeMode = !g_InPracticeMode;
        if (g_InPracticeMode) {
            // TODO: I'm not sure if it's possible to force
            // set cheat-protected cvars without this,
            // it'd be nice if it was so this isn't needed.
            SetCvar("sv_cheats", 1);
		 SetCvar("mp_roundtime", 60);
		 SetCvar ("bot_quota", 0);
		 SetCvar ("mp_freezetime", 0);

            for (int i = 0; i < g_BinaryOptionNames.Length; i++) {
                bool enabled = view_as<bool>(g_BinaryOptionEnabled.Get(i));
                ChangeSetting(i, enabled, false);
            }

            ServerCommand("exec sourcemod/pugsetup/practice_start.cfg");
            GivePracticeMenu(client, ITEMDRAW_DEFAULT);
            PugSetupMessageToAll("Practice mode is now enabled");
        } else {
            ServerCommand("exec sourcemod/pugsetup/practice_end.cfg");
        }
    }
}


Maybe the guide could sync up with the angular jscs file? https://github.com/angular/angular.js/blob/master/.jscs.json - I could do a PR for that. We could also make an angular preset in jscs (although I think it would mostly just follow the google preset).


Yeah, I noticed that I often had to start it if the machine rebooted


What's with the commented out code? Do they need to be here?


Managed to get this branch up and running. The issue is "error: GLSL 1.50 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.40, 1.00 ES, and 3.00 ES", but any version less than 1.50 means no uniform arrays which are used pervasively in the renderer/translator/shader.

I don't envision much of a performance difference on desktop - the shaders are essentially free compared to the CPU interpreter bottleneck and once that is improved full-speed should be easily attainable. If you have a ton of patience you could split all of the uniforms out to be singular, which would probably have to be done for mobile anyway, but citra probably won't be ready for mobile for a long time.


I like the general direction of this. However I think public types and internal implementation types should be separated more clearly. It looks like the kernel level notifications are directly produced by compiler-2.2 instead of being translated via the SPI. The problem with that is that a future version of the product that has compiler-2.2 as a binary dependency would then have a dependency on the 2.2 kernel. We need to go through an SPI to avoid that.


ilk yukleme


We could make it private/protected, but I don't see any harm in leaving it public.


it's just wrong opcode id... - this opcode name is SMSG_CLEAR_COOLDOWN


<input> doesn't actually need a closing tag as the are void elements. Like <img>


Can be simplified to:-
`Return (_lineBuffer = 0) OrElse IsWhitespace(Peek(-1))


Someone's been busy


fail


Tidy this one up.


Vtk was using CDAT built JPEG and one. Please check the cmakecache.txt


#KANGBANG


Tidy Up


The way it was working is this.

We built JPEG and then find JPEG was founding it.


Look at using `NextIs(1,">"c)`


.DELETE_ON_ERROR tells make to do that for you.

The problem with the `|| rm` is that it returns exit code 0 so the build doesn't fail.


@piemonte thanks! helpful. added the above ```@interface``` category.

i know open source isn't a tutorial (pretty new to iOS) but I think I'm missing a step so thought I'd share.

I'm trying to let the user trigger a screenshot with the below method
```
- (void)grabScreenshot {
    [vision captureVideoFrameAsPhoto];
}
```
But I'm unsure how to extract the ```UIImage```.

Should I be working with the ```_capturePhotoFromSampleBuffer``` method you mentioned?
https://github.com/piemonte/PBJVision/blob/master/Source/PBJVision.m#L1604-L1673

Going to keep digging - thanks again and enjoy your weekend!


Oh, nice to know, thanks.
Still, I prefer to see matching pairs, rather than an `<input>` followed by a `<button` :-)


#KANGBANG kanged right from showp1984 this time. good to know you can use the "git commit --amend --reset-author" command


There's some oddness with the input bar at wide screen sizes when the console is below the editor.

![screen shot 2015-03-06 at 17 16 26](https://cloud.githubusercontent.com/assets/1320418/6537422/a18c80e6-c424-11e4-9137-e2d79e04219d.png)


BTW, one-line comment is fine for LESS (unlike CSS). But, anyway, remove is better.


LULZ #KANGBANG


yeah this has Jrior001 as author but should still be about 8 different commits #KANGBANG


Just starting but serious now.


#THEKANGBANGISREAL


You can just Pkg.checkout to fix it. I have to make it work on both 2.x and 3.0. I'll get around to it soon


lulz #KANGBANG


createAndRecord


I doubt this will work. The following hapens here:
1. global variable google_remarketing_only is set to true
2. *Async* request starts
3. variable google_remarketing_only is set to false
4. request completes (some time in the future) and sees: google_remarketing_only === false


It happens in the /core main.cpp, and I am using GCC 4.9 as well. I downloaded the source and built it myself, but it's giving me those errors above no matter what. I am fairly new to C++.


My guess is that `-e` exits immediately after evaluating the expression, without visiting the event loop, so the printing doesn't happen. With `-E` you'll see the exception, or something like `./julia -e '@async error(); sleep(0)'`.


Can you multi-line this?


It was working and now all builds are causing bootloops. Please revert


Kris, what do you mean by crippling effects of running these options while
already off?


thanks


Spacing seems off here


It's fine in some cases. I think it's something to do with HTML and XHTML, I think HTML does not require you to close void elements and is actually invalid HTML to do so however XHTML requires all elements to be closed I think however if you need to do that you just do `<input ..blah.. />`


I watched a console log once while running the script while the options were on (default) and the system library started killing itself. The machine then would not reboot.


Correct.


Minor nits on formatting. Looks good overall though. Also, I haven't verified the changes-- just a code review.


What about it?


So whats the reason that you fork this then change the name and remove my name from all documentation then republish it to the CDN http://libraries.io/bower/ng-azure-mobile-service and to bower?  You didnt make any real changes to this and if you did have a suggestion I would have been happy to accept a pull request.


This is not waiting for the processes to terminate. It returns as soon as they are interrupted (but not yet finished).


Yeah that's a good point, maybe you should be able to plug a retry algorithm in here instead of just a bool.


Oh, I will remove the word 'create'


Is this used in this test? (ProtoBuf)?


This looks good to me.


@bdolor @BakingSoda thanks for this! ... I wonder if we should genericify this so that it just enables user to select a PDF body font-size... of Xpt (so dropdown with X font-sizes). In all the "new" themes, everything is defined by ems based on a fixed body font. We could/should rebuild the old themes to do this as well... while we are at it we could add same for body line-height, so:

then the feature would be:
a) user selects body font (default, or dropdown of 7-14pt) ...
b) user selects line-height (default, or 1.1-1.7)
b) and injected into CSS would be:

body {
font-size: Xpt;
line-height: Y;
}

Again, in order to make this work we'd want to review the Open Source themes and make sure they are all based on ems.

Thoughts?


Make sure all the sample apps are updated.


Oh, I guess the "all languages" part isn't relevant anymore XD


Each process should be sent only one exception. There is no point in stabbing it multiple times.


This should be deleted


fix invoicecnote.php


Can you document the return value?


@aashish24 just looked at the VTK build funny but with USE_SYSTEM_JPEG=OFF it actually finds it....
```
 JPEG_INCLUDE_DIR                 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX1
 JPEG_LIBRARY                     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX1
```
so I think we're good...


CBECC (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2040 of 2157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.58%25-yellow.svg)


By the way, sprinkling `-invalidateAllColouring` calls around is not necessary anymore since I switched to calling the syntax colorer in drawRect.


On Fri, Mar 06, 2015 at 08:39:55AM -0800, daurnimator wrote:
> oh, you wrote your own `rawgeti` function.
>

Yeah. I had to refactor the code anyhow so it could be reused from
ssl:setAlpnProtos. And I already had getfield.

Although doing that made me think the time is ripe to move to a Lua 5.3
compat library, since in Lua 5.3 lua_rawgeti usefully returns the type.
That's a little different from the way my getfield and rawgeti helper
routines work, but it'd be nice to base things off a standardized API.

How is the 5.3 compat library coming along? Any interest in supporting a
macro to make the implementation statically defined?

Normally Lua modules are loaded with RTLD_LOCAL, so extern functions don't
cause a problem. But sometimes you have to load a module RTLD_GLOBAL. For
example, a Lua->Perl bridge. Like Lua, Perl modules won't load unless the
Perl API is already exported to the global namespace. So for our Perl module
at work I use the same trick I use in luaossl (dladdr + dlopen) to re-load
the module; in this case so I can upgrade it to RTLD_GLOBAL.

And people including modules with the application binary will also end up
with namespace clashing. Enrico Tassi's Lua packing library for Debian
requires all modules to be symlinks to a shared library in /usr/lib, next to
a static archive version. Presumably people do this enough that Tassi made
it mandatory to support using Lua modules that way.

cqueues has polluting extern functions, although fixing that will be more
problematic because of interdependencies among the socket and dns code.


CBECC (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Le terme générique content-item est préférable pour des raisons de taille de fichier. Exemple:

```scss
.content-item {
  .content-illu {
    ...
  }
}
```
donne
```css
.content-item .content-illu {
  ...
}
```
alors que
```scss
.article-item,
.tutorial-item {
  .article-illu,
  .tutorial-illu {
   ...
  }
}
```
donne
```css
.article-item .article-illu,
.tutorial-item .article-illu,
.article-item .tutorial-illu,
.tutorial-item .article-illu {
  ...
}
```

---

Encore que, la ça va niveau imbrication, mais si on avance encore, on va avoir des trucs super longs pour rien. Je préfère qu'on ai deux classes à appliquer sur un élément que des sélecteurs de 3km ;)


In my opinion it's a pure waste of time to deprecate and support something that only existed for a couple days. No commit is supposed to be a release unless it is tagged as such.


The `*colorize?*` stuff is enforced at the outermost layer (in the print writers for `*out*` and `*err*`), so we never really have to reference it in our code. The only exception is for things like REPLy that do I/O in a different way and don't print through `*out*` and `*err*`.


What's the purpose of Tickets vs View?

Also, I opted not to use View since it's kind of a loaded term is iOS development.


love it.
+1 for updating Open Source themes.
+1 for handing more control over to the user.
+1 for abandoning the strategy of hucking a percentage-based font-size over the fence just hoping it works out. What say you @BakingSoda ?


Oh, and to answer the question, it does. :)


this is not tested at all don't use it. I can't test it before sunday evening


@bnoordhuis do we grow them?


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 13](http://TeamCity/viewLog.html?buildId=1181863&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) is now running


It's not a unit test, it's more to watch what it does in a browser's debugger to make sure it's building correctly. (manual test for debugging)


Gosh, I totally missed it. Mind submitting a PR?


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 13](http://TeamCity/viewLog.html?buildId=1181863&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) outcome was **SUCCESS**
Summary: Tests passed: 33 Build time: 0:0:0


Wow. How did the json file get corrupted?


There are two template pages, one for the picture page and one for the calendar page. Both get deleted, but the calendars don't actually use the template, they just get built by the js code.


I am not 100% sure about this patch, the idea was that you could handle several devices at the same time. But I agree though that right now we do not handle them. Might make sense to do once we handle merges of notifications.


This is not safe.

toUtf8 returns a QByteArray containing a copy of the data from m_message (in utf8 form, naturally), but this copy is stored in a temporary. constData grabs a pointer to the start of this temporary copy.

When this statement ends, the temporary is destroyed, and the returned pointer will be pointing at anything: you may get lucky and have this work, but it may just as likely crash.

The same problem applies for any of the QString toAscii/toUtf8/toLatin1/etc type methods.

A fix would be to store QByteArray instead of QString and do the toUtf8 in the constructor.


@gbggrant does this branch need to me merged into master?


The following if can be combined into one,
```vb
If CanGet(3) AndAlso IsDouble(Peek(2)) AndAlso IsDoubleQuote(Peek(1))
             AndAlso CamGet(4) AndAlso IsLetterC(Peek(4)) Then

End If
```


That one worked :)


Why delete province


This one must not only be added here, but it must be added to both, includeJS and includeJSLibs.

=> https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/commit/76ed0937721462b4d6ab3a6e2aa0c0432796eba2


don't we ant to filter districts to the selected city


Why is registration removed?


Sounds amazing. @bdolor @hughmcguire  This would definitely open up more options for users.


```vb
If t Is Nothing OrElse t.Kind<>SyntaxKind.IdentifierToken Then Return False
Return TryIdentifierAsContextualKeyword(DirectCast(t, IdentifierTokenSyntax), k)


What about creating a tag for 0.4.2?


to deal with those two boxes (untested):
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Internet Settings\Zones\0
1803 = 0
2200 = 0
http://support.microsoft.com/kb/182569

HKEY_CURRENT_USER\Software\Microsoft\Internet Explorer\Download\
CheckExeSignatures = 0

HKCU\Software \Microsoft\Internet Explorer\Main\
CheckExeSignatures = 0
https://technet.microsoft.com/en-us/library/cc783259(v=ws.10).aspx


This also leaves future subclasses the freedom of having a custom syntax definition system that is different than the provided one. But, on the other hand, now we have two methods of setting a syntax definition, and one can get out of sync with the other.


This can be simplified a bit since you really are doing this:
```
if method.in?[:city, :district]
  choices = preselected_choices[method] if preselected_choices[method]
end
```


Nice :+1:


You changed the comments but ... not the type :)


@indutny TryAllocateForWrite()?


Okay, that was easy. Do you think many people are using this? Is it necessary to add a new release just for this?


Cuz it's in the banner now


delete


I've chosen date_default_timezone_get because it sets system timezone to the configured value or reading it from the system configuration if none is set for php or fallback to UTC.

This will overwrite the configured one to UTC because the hook is called before every request. Maybe this should be changed to something like

if(!ini_get(date.timezone)){
date_default_timezone_set('UTC');
}

This would only set the timezone if none is set in php.ini and fix errors like the last ones I've seen on community.invoiceplane.com


The root cause is https://github.com/midgetspy/Sick-Beard/blob/development/sickbeard/helpers.py#L221

gzip encoding has been requested by getURLFileLike and Plex is honouring the request.

getURLFileLike does not support decoding and its use replaced urllib2.urlopen() without any encoding requests, it simply returns a file like object of the original source, including the compression from http.

sickbeard.helpers.readURLFileLike will however solve this and IS required anytime getURLFileLike is now called.

Infact, getURLFileLike  should never have been called direct, instead sickbeard.helpers.getURL() should be used, which wraps the getURLFileLike and readURLFileLike into one.

#923 proposed


Yep, but it creates `new Buffer()`.


rax retry tests


Forgot to add the Test.cpp in the patch :(


oops! this was for testing, changed it back


I got verification from active_merchant that even though they are not provisioning new merchants with LinkPoint that the endpoints still work and is needed for existing merchants.  Might want to reverse this push.  take a look at https://github.com/Shopify/active_merchant/issues/1604


```HINTS .``` to allow direct download or recomment a cmake variable to add a folder to search in ? Add a comment about the url to download it: https://raw.github.com/philsquared/Catch/master/single_include/catch.hpp


Actually, this already was a property some day ago, and I de-promoted it, because it doesn't have a setter and is not observable even on the textView. Plus, it does not directly map to an instance variable (the code which produces the return value must re-colour everything), so it doesn't fit the meaning of  "property" very well.

(also, the leading `@property (nonatomic, readonly)` made the declaration very long, but that's more an excuse than a good reason, unless you have a 13" screen)


https://github.com/CyanogenMod/android_frameworks_base/commit/3b0afb92f90ded2ed5a381d87361d49d38be392d
Thanks for your work.


Thanks!! I m sorry I missed this.


https://github.com/tweepy/tweepy/blob/master/tweepy/auth.py#L34

Works if callback is not set or is ```None```.


Great thanks for the fix! Going to try the build again right now


> and it doesn't account for the buffer growing.

Replace 'buffer' with 'memory' and it seems like an accurate assessment to me. :-)


do not *add* a logger.


I'm not sure what this does, at least it's not familiar with the code


Great. Books we're currently producing that require this feature have a deadline we are obliged to meet (mid to late March) Since this is the preferred route, what timelines are you looking at @hughmcguire ,that is, to update the themes?


woah. good work :shipit:


@maniqui It's nifty experiment thingie, but the codebase is just bit behind. I've fixed the breakage, and the suggested correction is on point. Thanks.


Thanks, the commit you linked doesn't fix the soft reboots. There's a patch on cm gerrit which does, hopefully will get merged soon. This is just a temporary revert to fix the reboots.


Yes that sounds good :+1:


You are right ! :)
It was fixed in [0931] https://github.com/classicdb/database/commit/360b200fbcc459b898ae082e5581dfe2eb791e00


```JavaScript
    var getReview = function (movie){

    switch(movie){

    case "Toy Story 2":
    title = "Great story. Mean prospector.";
    break;

    case "Lion King":
    title = "Great songs.";
    break;

    case "Finding Memo":
    title = "Cool animation, and funny turtles.";
    break;

    default:
    title = "I dont know";
    }
    };

    getReview("Toy Story 2");
```


Snytax Highlight :)


Ahh ok should be soon


```JavaScript
//Code here
```


@plopesc the more you know... Fixed, thanks! :)


Hurray for variables :)


Wait, I adjust memory in `Buffer::Buffer`, and this is a way to grow the BIO itself.


All identifiers starting with _ or containing __ are reserved (as per the norm). Consider renaming to NONNULL and NONNULL_


If your building this is the patch http://review.cyanogenmod.org/#/c/90691/


you have to edit the site.py of that python and replace ``ascii`` by ``utf-8`` in the following method:

```python
def setencoding():
    """Set the string encoding used by the Unicode implementation.  The
    default is 'ascii', but if you're willing to experiment, you can
    change this."""
    encoding = "utf-8" # Default value set by _PyUnicode_Init()
```


Oops.


Teste


@scripstace code looks good so far but I was expecting to see a test around what happens to a unauthenticated user if he/she tries to go to the show page.


@itamarnet Essa nova `zztool nl_eof` é importante você conhecer.

É bom usar sempre que for passar um `sed` no resultado de um `printf` sem o `\n` no final, já que o GNU sed não adiciona o `\n` automaticamente na última linha, como fazem as outras versões do sed :/

Por isso deu aquelas diferenças em nossos testes, de no meu aparecer linhas em branco a mais do que no teu.

Veja exemplos de aplicação dessa ferramentas nos commits 1a27b93fee7bd76b3e412a820a26f1c7fb805243 e f5782ca02e03a3775c100a0b49617c5b2bee42c5


@nmpetkov : thanks for the clearer explanation. I understand what you are saying, but I am not sure I agree.

[the original `get()` method in 1.3](https://github.com/zikula/core/blob/1.3/src/system/Groups/lib/Groups/Api/User.php#L67-L133) doesn't seem to have the functionality to see if a user is a member of a group at all. This appears to have been added to 1.4 specifically (by either @Guite or @drak).

As the code is currently (after this commit we are discussing) if there is no `uid` parameter, the `$groupmembership` var should contain the requested group. It will be an array and it will have one (1) item, the groupEntity ***or*** the group is not found and `$groupmembership` will be `null` and therefore `is_array()` will fail, returning `false` as expected.

so, I'm not seeing the problem - the `get()` method should either return the result array, which includes the group and it's members or it returns false if the group is not found. maybe I continue to misunderstand :stuck_out_tongue_winking_eye:


No need to include `()` around return value


The (totally unpublished and unknown to anyone except me) style guide says add a line break before the return statement. Which reminds me to actually put a link in the developer documentation to the PHP Standard Recommendations.
````php
Zend_Registry ....

return ....
```


The code makes me think that it actually *only* is an stdWrap. Doing something like _config.pageTitle = MeinTitel_ is not possible.

https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/commit/0182528c0db7cd02c50db9a8889b6db482ed1446


is this what I need?

` $ionicConfigProvider.views.swipeBackEnabled(true);`


This needs to be changed I'll re pull in a minute :wink:


I've improved this logic, coming soon through other dbPool ticket.


To avoid repeating the `$school` variable name, you may want to use a `switch`:

```
switch ( $school ) {
   case 'rs':
   case 'el':
   case 'ar':
   case' ge'
      return true;
}
return false;
```

Even better, you could use `in_array`:

```
return in_array(
    $school,
    [ 'mc', 'rs', 'el', 'ar, 'ge' ]
);
```


Think you put an extra > `/>>`


LGTM


Thanks @jamiesnape .  I'll push a fix.


I think the original issue is with Organization Roles, which will end up with SCOPE_GROUP_TEMPLATE from [EditRolePermissionsAction.java#L340-L344](https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/rolesadmin/action/EditRolePermissionsAction.java#L340-L344).

Since an Organization role has the option to add an "Access in Control Panel" permission for the "Users and Organizations" portlet, this block will attempt to give the role the portal-scoped permission.

From what I can tell this only affects Organization roles.  Site roles behave as expected.


/** Access the value of a previously bind int parameter.
 * @param handle[in] Handler to a valid parameter.
 * @param value[in] Non null pointer to an integer that will
         hold the parameter value on success, undefined otherwise.
 * return true of success, false on failure.
*/


@aldenml no more ugly  hack hiding the list view here. finally understood effing LoadManager and fixed these issues everywhere.


I dislike that you have everything in one big hairy file. I suggest splitting this up into separate model files, for example one for schools called `school.php`.


Um, okay.  Could it be that you forgot to update the `new Buffer(...)` call in TryAllocateForWrite()?


`SUCCESS`


/** Set the value of a previously bind int parameter.
 * @param handle[in] Handler to a valid parameter.
 * @param value[in] The parameter value to set.
 * return true of success, false on failure.
*/


Undefined on failure.


Access the value of a previously bind string parameter.


@aldenml this was the reason why when one removed the last element on a playlist, the playlist wouldn't refresh, therefore I was doing an ugly hack hiding the listview.

Now if nothing comes in at the end of a data load by the Loader, we don't just exit, we clear the adapter and notifyDataSetChanged.


You can use `isset` on multiple variables:

```
isset( $variable[ 'year' ], $variable[ 'start' ], $variable[ 'end' ] )
```


[add an empty line]
Set the value of a previously bind string parameter.


@bnoordhuis : https://github.com/indutny/io.js/commit/8ef701cb13ba904453d08740c5d8d7f69e2128a9#diff-7e7100680ecd1a84159d5e6304900d34R407 ?


Thanks. I'll add it to the POT file too.


This makes it so that whenever a music file is deleted from within FrostWire we make sure to clean the playlists that may have the song.


ha well, timeline ... many hands make light work @BakingSoda @bdolor  ...  let's do this: which theme do you use most often? I will em'ify that one

... then you can build a test version of the new feature as described above, and if we are all happy with results -- we'll get the rest of them done by hook/crook.

QUESTIONS:
-do we also want to add "page margin" styling options?
-is mpdf going to work with the same stylesheets?


Validation should be moved to controller.


correct. you don't write ``</input>``. Input tags like for instance ``<meta>`` and ``<img>`` are closed by prepending a space and a  / before the > if you want to make it nice and validating. You can just omit them though and use the lazy method like i do.


@param value[in] Non null pointer to a null terminated string to set.


May make sense to enforce certain limits for start and end.


Yeah... just saw that! Did not notice it at first - we must improve out testing!


The DoS wouldn't be distributed. It's just a DoS, not a DDoS.


Not a great function name.


not sure why this is necessary... but these defaults are being set in `dvl-core` i'm assuming.


if


its


You can remove this bar by passing an option when initializing FormRenderer.


Avoid click-here-syndrome.


Should be like: string newText = item.SubItems[3].Text.Replace(Configuration.Settings.General.ListViewLineSeparatorString, Environment.NewLine);


Instead of doing this, you want to enable styledControls, which is inside of dvl-core.


Oh geez, must be having a fuzzy finger moment :blush:


You can check out Screendoor to see how it's implemented w/ formrenderer.


Yeah, me like. We have this for all hashes, even MD4, right?


it worked for me at first . but than stops working . problem coming from base commit . need to add a part of code to phonestatusbar for recreate statusbar.


`.ets` doesn't actually exist, sadly. Do you think `.template.ts` (or `.ets`) is preferable to `.ejs`? I stuck with `.ejs` because then syntax highlighting mostly worked, but I agree it's kind of odd to use.


Aw sorry, I had your patch applied locally but I probably backed out the changes to node_crypto_bio.cc
 by accident.

I still stand by my point that it's icky though. :-)  It feels like a conflagration of things that are only very tangentially related.

(Also, I assume the 'alive' variable is a bit of leftover debug code?)


commit message:
Print test output if the test fails

ctest by default put all logs in a file and never display it even if a test fails.

Add the relevant option to output on failure.


300ms delay. This should definitely pass the under 2second barrier.


You can switch to a more readable style by following these two rules:

1. Always leave a line break after `<?php`
2. Always leave a line break before `?>`

It's going to look like this:

```
        <select name="start_year"><?php
            for ( $year = 0; $year <= 14; $year++ ) {
                ?><option value="<?php
                echo $year
                ?>"><?php
                echo 2000 + $year;
                ?></option><?php
```


Great, got it.


if `result == null`, this line will throw an exception...


Oh yeah, sorry for `alive`.


Where is `$school` defined?


Camel casing.


nit: space after `,`


***Commit message***
*Reformat .travis.yml test commands*

Do not execute tests if the build fails.
Indent the commands for readability.


Not sure how hot this is, but for small array sizes, manual copying is faster than `subarray`. In my experience, somewhere around `< 128`.


Has stdWrap.

https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/commit/6a0ca944ae417cd1157206caa83a5356823ebe3d


Closes #23


The most pointless subclass in the world?


Got you. Maybe we could just do `var err error` at the beginning next time.


nit: spaces within `()~


***commit message***
*Use ctest for testing*

Test were enabled with the ```enable_testing``` command.
Nevertheless this method is very basic.

Include CTest, as this cmake utility enable automatic
build + test + coverage generation + memchek test (valgrind) + sending report
in one command: ```make Experimental```
There is far more feature added by this utility, see:
http://www.cmake.org/Wiki/CMake/Testing_With_CTest#Dashboards


This URL should probably be based on where it is running and configurable.


Yeah, this renaming is long overdue.

Again, feel free to remove/rename recently-introduced things that you want to change, instead of leaving them around and deprecating them.


These run in parallel, is this what you want?


This will output the wrong URL due to the asynchronous nature of the call.


This should check if `counter == total` to avoid precision errors.


Retirei a possibilidade de deleção da pasta data.


nit: space after `(`


Why is this a vector and not a set?


Nit: avoid double spaces


Looks good.  I guess it's ok that ``__db_print``'s signature has changed (lost its default value), as we don't expect anyone to call it but our own functions.   The comments by dbprint_prefix when it's defined seem confusing; it's being called a Parameter but clearly isn't...


Why not just exprs = ies.exprs ?


ah, Firefox.


I must say that I am not so fund of all this wrapping. Could you not:
~~~
void CConfigurableDomain::apply(CParameterBlackboard* pParameterBlackboard,
                               CSyncerSet& syncerSet,
                              bool bForce) const
~~~


Fluvio q isso cara?


@baylee looks good, I guess this wouldn't be an issue if our server and angular app were being served by different URLs/IP Addresses


@rbvermaa: Shouldn't this be called **`deployment.`**`ec2`?


cc https://github.com/iojs/io.js/pull/1085


would like the *what?* to run forever?


detach will *what?*


its to load dscfork base classes


Be aware personal taste here: I prefer to have the title on the same line as the /**
But feel free to do as you prefer.


This reverts styles to an older commit and I'm assuming was unintentional. I'll revert.


Gdy jest się w zakładce ustawienia nie działa boczne menu. Problem można wyeliminować, zmieniając ustawienie formularzy z  ustawienia w kolumnach(jedno obok drugiego), na ustawienie jedno pod drugim. Co myślicie o takiej zmianie?


Well, I have no idea what to tell you, as I simply cannot reproduce this
under any circumstances.

On Fri, Mar 6, 2015 at 4:22 PM, Xiaomita <notifications@github.com> wrote:

> It happens in the /core main.cpp, and I am using GCC 4.9 as well. I
> downloaded the source and built it myself, but it's giving me those errors
> above no matter what. I am fairly new to C++.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MoochMcGee/Emotionless/commit/f5d64f236400fa7cddf6fd99aed3659f581acb5d#commitcomment-10080783>
> .
>


infom -> info


I'm a comment


Is this line not longer than 100 char ?
~~~
if (pApplicableDomainConfiguration != NULL
    _pLastAppliedConfiguration != pApplicableDomainConfiguration) {
~~~


This isn't doing what you think it is doing. It is letting the boolean value False through.


:-1: correct the line too long and you will receive your +1


I think we should add a helper function to do this on selftest or something


FYI @nex3


Lousy fingers...


Cool, suggestion on how to get the `dvl-core` JS into the KB? I see that the CSS is being imported via `@import 'vendor/assets/stylesheets/dvl/app';` but I've been trying something like this (in `layout.jade`) `script(src='/vendor/assets/javascripts/dvl/core')` but that obviously doesn't work. Maybe it would be best to just load this JS from a CDN?


You forgot the implementation ;)


Luther is king. All good children inherit from Luther.

re: page margin - we didn't come across this issue during the accessibility testing.
re: mpdf - yes, it does grab existing web stylesheets from child/parent themes. It [supports em, pt, px](http://mpdf1.com/manual/index.php?tid=34)


Not sure why it keeps changing the environment.UserName to just the computer's UserName that I am on at the time


Awesome!


Still keeps changing the UserName to the computer that I am on instead of staying as Environment.UserName


You need to add it to your load path somehow. You're welcome to just copy and paste directly for now, but I've also noticed that the knowledge base doesn't have a good way of managing (concatentating + minifying) javascript. I think we need to solve that.


I don't think this is going to work. There's no limitation in the interface of one file per galley, and (at least on my system) there's a fatal error with an expedited submission in viewing:

Fatal error: Call to a member function getFileType() on null in /home/asmecher/git/ojs/plugins/viewableFiles/pdfArticleGalley/PdfArticleGalleyPlugin.inc.php on line 56


I think this may be the opposite of what we want. If `--branch` is specified then you should *not* be specifying `--commit`. They are mutually exclusive in the sense that a branch implies a commit. A commit does not have any allegiance to a particular branch.


rax retry tests


Fixed, thanks!


I see what you did there...
![image](https://cloud.githubusercontent.com/assets/1569362/6538404/a66ec2b2-c416-11e4-9575-b5d18a2c0168.png)


Mh, interesting approach … but cool that it works! =P


Yeah definitely, I'll look into it.


We can revert this if people actually still need to use it, but I don't think it's being used. so I'd like to remove it as no one has touched the code in over 2 years, and it's doubtful people still using it will upgrade to Spree 3.


> How is the 5.3 compat library coming along? Any interest in supporting a
> macro to make the implementation statically defined?

I think it's always had that? See `COMPAT53_PREFIX`
https://github.com/keplerproject/lua-compat-5.3/blob/893bac7a0dbb6aab8216eab45188050f52937290/c-api/compat-5.3.h#L30


This commit looks like it should be squashed into this commit: https://github.com/VikingsFan/WebApi/commit/1b598bbaf8d38574e79318f41136b9b44e9531dd


Beleza Aurelio, já estou me inteirando das modificações.


I understand where this is coming from - we want "consistency in where we send people for support". That said, I wonder if this is poor UX/DX due to the double hop required after this change: a developer reading this will visit the support page, then see the email address (or one of the other 3 support channels on there) and then send the email. Isn't it actually better UX/DX to get the user where they need to go in fewest steps possible?


Can you make it possible to change the ''item-cost''. I want to change de Diamond item, into some other mod or other vanilla item, how can i do to change this, i tried to put some other Item-ip, but that didnt work, so, can you help me?


CBECC (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2140 of 2157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.21%25-yellow.svg)


develop (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


ngko nek wus iso milih lokasi ta clone maning haha asik kiye iso tak input form jadwal Tv juga haha


@aboe76 Ah, thanks for mentioning that. We have been having trouble with that state when setting up the tests on openSUSE, as you've maybe seen. The weird thing was that I quickly tried to reproduce the error on my own, and the npm/bower state installed just fine for me on openSUSE, using the same states via gitfs...I didn't have time to look into it too much before SaltConf, but I can take another look here.


Untested and probably don't need the stuff from the Python 3.x documentation examples but I am done for the week.


Good job!


Maravilha!! Aqui continua funcionando, mandou muito bem.
Mais uma que aprendo e mais detalhes sobre incompatibilidade sendo descoberto!


@purpleidea -- should be good to go. issues with partitioning appeared related to having existing mounts or UUIDs in /etc/fstab as well as requiring a dd if=/dev/zero of=/dev/to-be-formatted after performing the vgremove, pvremove, and lvremove on the volumes.


define default values in model is not very good as it loads data from database. it's strange usecase ( same as in Gii search model, because it is nothing more than just 1 function with filters. but that's another question).

my change just doesn't send empty filters. So it is ok if
1. user sets default filters via JS
2. user sets filters after model creation. (it can be function like setFilterA() or attribute set)

sorry for taking your time


Why use the rebase, but remove the feature that is the reason for the rebase lol.


should be `wfMessage( 'key' )->inContentLanguage()->isBlank()` instead of `wfEmptyMsg` but we can update this at a later date.


Cara, essa passou batido.
Foi mal!


ahh sor :)


89224666-FixNANProblems-Issue4557 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@jessevondoom


why are you forward declaring if the header is included ?


config.sys_language_isocode_default is missing.


No problem!


Nice, but change the version number as this break retro-compatibility.


[![Rice-Bale-Shaped Bottle](http://api.artsmia.org/images/5175/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5175)


[![General Guo Ziyi's Banquet](http://api.artsmia.org/images/5176/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5176)


[![Traveling in Autumn Mountains](http://api.artsmia.org/images/4326/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4326)


[![Army tunic](http://api.artsmia.org/images/112158/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=112158)


[![Qur'anic board](http://api.artsmia.org/images/111379/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111379)


[![Anne Klein with a Baby in Transit](http://api.artsmia.org/images/108443/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108443)


[![Reminiscences of 1865](http://api.artsmia.org/images/689/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=689)


[![Gelede mask](http://api.artsmia.org/images/114437/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=114437)


[![Le Grande Maitre de la Frisure a la Mode](http://api.artsmia.org/images/9830/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9830)


[![Cosmo I de' Medici](http://api.artsmia.org/images/7216/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7216)


[![Monstrosities of 1822](http://api.artsmia.org/images/61303/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=61303)


[![The Fountain Maker](http://api.artsmia.org/images/61315/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=61315)


[![Plate 10 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74692/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74692)


[![Plate 5 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74693/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74693)


[![Inconveniences of a Crowded Drawing Room](http://api.artsmia.org/images/75121/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75121)


[![Plate 8 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74695/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74695)


[![Burgundian Nobleman](http://api.artsmia.org/images/74564/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74564)


[![Plate 2 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74694/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74694)


[![Monstrosities of 1821](http://api.artsmia.org/images/75135/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75135)


[![Monstrocities of 1799, Scene Kensington Gardens](http://api.artsmia.org/images/75855/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75855)


[![An Apothecary, from Des Manouvriers habilles](http://api.artsmia.org/images/75492/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75492)


[![Blowing up the Pic Nic's or Harlequin Quixotte attacking the Puppets](http://api.artsmia.org/images/75861/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75861)


[![Morning, Noon, Night](http://api.artsmia.org/images/76001/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76001)


[![Hercules, from Collection de figures thÃ©Ã¢trales](http://api.artsmia.org/images/76168/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76168)


[![Neptune, from Collection de figures thÃ©Ã¢trales](http://api.artsmia.org/images/76178/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76178)


[![Mr. Des-fadaises (Mr. Nonsense)](http://api.artsmia.org/images/76220/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76220)


[![Homme de QualitÃ© en Habit d'EstÃ©](http://api.artsmia.org/images/76225/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76225)


[![Gentleman Dressed for a Ball](http://api.artsmia.org/images/76424/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76424)


[![The Secondhand Clothing Dealer](http://api.artsmia.org/images/76666/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76666)


[![The Seller of Mirrors and Glasses](http://api.artsmia.org/images/76670/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76670)


[![The Painter](http://api.artsmia.org/images/76672/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76672)


[![The Fisherman](http://api.artsmia.org/images/76673/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76673)


[![The Rotisserie Cook](http://api.artsmia.org/images/76676/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76676)


[![Portrait of Georg von Roggenbach at age 38](http://api.artsmia.org/images/112644/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=112644)


[![Portrait of Jan Nicquet](http://api.artsmia.org/images/116509/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116509)


[![Three German Soldiers](http://api.artsmia.org/images/118943/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=118943)


[![The Great Standard Bearer](http://api.artsmia.org/images/119658/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119658)


[![Nocturne: Palaces from "The Second Venice Set"](http://api.artsmia.org/images/7399/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7399)


[![Phil / Fingerprint](http://api.artsmia.org/images/7695/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7695)


[![The Exchange Bridge](http://api.artsmia.org/images/8228/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=8228)


[![The Goldweigher's Field](http://api.artsmia.org/images/8833/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=8833)


[![The Exchange Bridge](http://api.artsmia.org/images/9186/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9186)


[![Christ Presented to the People (Ecce Homo)](http://api.artsmia.org/images/9202/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9202)


[![Copperplate matrix for "Un Corps de garde"](http://api.artsmia.org/images/27870/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=27870)


[![The Goldweigher's Field](http://api.artsmia.org/images/41906/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=41906)


[![A Perspective of Arches, with a Smoking Fire In the Center, plate 6 from Carceri d'Invenzione](http://api.artsmia.org/images/52607/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=52607)


[![Le Hibou (The Owl)](http://api.artsmia.org/images/56005/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=56005)


[![Un Corps de Garde](http://api.artsmia.org/images/63126/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63126)


[![Un Corps de Garde](http://api.artsmia.org/images/63127/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63127)


[![Le Hibou (The Owl)](http://api.artsmia.org/images/90869/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90869)


[![Effet de Pluie](http://api.artsmia.org/images/105335/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=105335)


[![Stallion and Jack Fighting](http://api.artsmia.org/images/108171/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108171)


[![Study for "Stallion and Jack Fighting"](http://api.artsmia.org/images/108212/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108212)


[![Perspective of Arches, with a Smoking Fire, Plate 6 from Carceri d'Invenzione](http://api.artsmia.org/images/111004/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111004)


[![Ecce Homo](http://api.artsmia.org/images/115357/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115357)


[![Saint Jerome](http://api.artsmia.org/images/118947/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=118947)


[![Saint Jerome, unfinished](http://api.artsmia.org/images/118948/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=118948)


[![Nocturne:  Palaces](http://api.artsmia.org/images/120316/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120316)


[![Effet de Pluie](http://api.artsmia.org/images/120643/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120643)


[![Pepper No. 30](http://api.artsmia.org/images/1922/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1922)


[![Architectural Phantasy](http://api.artsmia.org/images/2820/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2820)


[![Vertical Repetition](http://api.artsmia.org/images/2821/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2821)


[![Light Pattern](http://api.artsmia.org/images/2822/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2822)


[![Pepper No. 30](http://api.artsmia.org/images/3297/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=3297)


[![Untitled (Swimmer)](http://api.artsmia.org/images/3368/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=3368)


[![Cigarette No. 37, New York](http://api.artsmia.org/images/4832/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4832)


[![Milk Drop Coronet](http://api.artsmia.org/images/5018/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5018)


[![Calla Lily](http://api.artsmia.org/images/7835/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7835)


[![Milk Drop Coronet](http://api.artsmia.org/images/11537/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11537)


[![Cats and Dogs, Alameda, California](http://api.artsmia.org/images/11562/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11562)


[![Man in a Window](http://api.artsmia.org/images/11914/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11914)


[![Acre, from Carnal Clocks series](http://api.artsmia.org/images/19493/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=19493)


[![Romance of Ambrose Bierce No. 3](http://api.artsmia.org/images/20042/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=20042)


[![Abstraction In Nature](http://api.artsmia.org/images/20479/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=20479)


[![Homage to Stieglitz](http://api.artsmia.org/images/24272/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=24272)


[![Untitled (Swimmer)](http://api.artsmia.org/images/24952/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=24952)


[![Samuel F. B. Morse (1791-1872)](http://api.artsmia.org/images/25968/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=25968)


[![General William Tecumseh Sherman (1820-1891)](http://api.artsmia.org/images/26015/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=26015)


[![Edwin Booth (1833-1893)](http://api.artsmia.org/images/26040/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=26040)


[![Colonel Elmer Ephraim Ellsworth (1837-1861)](http://api.artsmia.org/images/26238/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=26238)


[![Heather Brown, Mimi Brown, Bebe Brown Nixon, Laurie Brown, Harwichport, Massachusetts](http://api.artsmia.org/images/27645/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=27645)


[![Silvered Steel](http://api.artsmia.org/images/28224/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=28224)


[![The Rail Splitter](http://api.artsmia.org/images/30075/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=30075)


[![Nude on Sand](http://api.artsmia.org/images/36669/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=36669)


[![Fotogram II](http://api.artsmia.org/images/58723/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=58723)


[![New Zealand](http://api.artsmia.org/images/99168/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=99168)


[![Looking South East from 45th Street and Madison Avenue](http://api.artsmia.org/images/107223/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=107223)


[![The Brown Sisters, Cataumet, Mass.](http://api.artsmia.org/images/108785/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108785)


[![Throw (C-918)](http://api.artsmia.org/images/109112/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=109112)


[![Photograph of Photograph](http://api.artsmia.org/images/109602/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=109602)


[![Nineteen Lincolns](http://api.artsmia.org/images/111187/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111187)


[![Nineteen Lincolns](http://api.artsmia.org/images/111188/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111188)


[![Nineteen Lincolns](http://api.artsmia.org/images/111189/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111189)


[![Nineteen Lincolns](http://api.artsmia.org/images/111190/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111190)


[![Nineteen Lincolns](http://api.artsmia.org/images/111191/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111191)


[![Nineteen Lincolns](http://api.artsmia.org/images/111192/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111192)


[![Nineteen Lincolns](http://api.artsmia.org/images/111193/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111193)


[![Nineteen Lincolns](http://api.artsmia.org/images/111194/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111194)


[![Nineteen Lincolns](http://api.artsmia.org/images/111195/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111195)


[![Nineteen Lincolns](http://api.artsmia.org/images/111196/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111196)


[![Nineteen Lincolns](http://api.artsmia.org/images/111197/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111197)


[![Nineteen Lincolns](http://api.artsmia.org/images/111198/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111198)


[![Nineteen Lincolns](http://api.artsmia.org/images/111199/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111199)


[![Nineteen Lincolns](http://api.artsmia.org/images/111200/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111200)


[![Nineteen Lincolns](http://api.artsmia.org/images/111201/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111201)


[![Nineteen Lincolns](http://api.artsmia.org/images/111202/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111202)


[![Nineteen Lincolns](http://api.artsmia.org/images/111203/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111203)


[![Nineteen Lincolns](http://api.artsmia.org/images/111204/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111204)


[![The Kuehn Children, Tyrol](http://api.artsmia.org/images/111869/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111869)


[![Sea Circus (RGB branch)](http://api.artsmia.org/images/112652/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=112652)


[![Sea Circus (shell & ball)](http://api.artsmia.org/images/112653/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=112653)


[![Muhammad Ali](http://api.artsmia.org/images/113343/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=113343)


[![Man with Birds](http://api.artsmia.org/images/114904/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=114904)


[![Bones II, from the "Deep South" series](http://api.artsmia.org/images/114969/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=114969)


[![Enrique Dimitri Magnussen](http://api.artsmia.org/images/115016/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115016)


[![Maksim Obruchev](http://api.artsmia.org/images/115021/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115021)


[![Diana Ginzborg](http://api.artsmia.org/images/115025/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115025)


[![Abbott & Cordova, 7 August 1971](http://api.artsmia.org/images/115352/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115352)


[![Untitled (Atomic Bomb Test Crater, Nevada, U.S.A.)](http://api.artsmia.org/images/115770/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115770)


[![Untitled (Atomic Bomb Test Crater, Nevada, U.S.A.)](http://api.artsmia.org/images/115771/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115771)


[![Atomic Bomb Exploding, Bikini-Atoll ("Bravo" Blast, 1st March, 1954)](http://api.artsmia.org/images/115772/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115772)


[![Atomic Bomb Exploding, Bikini-Atoll ("Bravo" Blast, 1st March, 1954)](http://api.artsmia.org/images/115827/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115827)


[![Atomic Bomb Exploding, Bikini-Atoll ("Bravo" Blast, 1st March, 1954)](http://api.artsmia.org/images/115828/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115828)


[![Calla Lily](http://api.artsmia.org/images/116528/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116528)


[![Calla Lily](http://api.artsmia.org/images/116530/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116530)


[![136 Mini Film Cameras in the Smithsonian Institution History of Photography Collection With Old Style Photoshop Filter](http://api.artsmia.org/images/118837/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=118837)


[![Former Tea House in a Park next to the Afghan Exhibition of Economic and Social Achievements in the Shah Shahid District of Kabul, Afghanistan:  Chronotopia](http://api.artsmia.org/images/119397/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119397)


[![Second-hand Reading](http://api.artsmia.org/images/119599/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119599)


[![The Watch](http://api.artsmia.org/images/119768/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119768)


[![St. James](http://api.artsmia.org/images/120054/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120054)


[![The Japanese Bridge](http://api.artsmia.org/images/1413/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1413)


[![Cologne Cathedral](http://api.artsmia.org/images/1943/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1943)


[![Reminiscences of 1865](http://api.artsmia.org/images/689/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=689)


[![Pepper No. 30](http://api.artsmia.org/images/1922/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1922)


[![Architectural Phantasy](http://api.artsmia.org/images/2820/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2820)


[![Vertical Repetition](http://api.artsmia.org/images/2821/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2821)


[![Light Pattern](http://api.artsmia.org/images/2822/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2822)


[![Pepper No. 30](http://api.artsmia.org/images/3297/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=3297)


[![Untitled (Swimmer)](http://api.artsmia.org/images/3368/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=3368)


[![Traveling in Autumn Mountains](http://api.artsmia.org/images/4326/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4326)


[![Milk Drop Coronet](http://api.artsmia.org/images/5018/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5018)


[![Cigarette No. 37, New York](http://api.artsmia.org/images/4832/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4832)


[![Rice-Bale-Shaped Bottle](http://api.artsmia.org/images/5175/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5175)


[![Nocturne: Palaces from "The Second Venice Set"](http://api.artsmia.org/images/7399/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7399)


[![Calla Lily](http://api.artsmia.org/images/7835/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7835)


[![General Guo Ziyi's Banquet](http://api.artsmia.org/images/5176/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5176)


[![Cosmo I de' Medici](http://api.artsmia.org/images/7216/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7216)


[![Phil / Fingerprint](http://api.artsmia.org/images/7695/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7695)


[![The Exchange Bridge](http://api.artsmia.org/images/8228/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=8228)


[![The Goldweigher's Field](http://api.artsmia.org/images/8833/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=8833)


[![The Exchange Bridge](http://api.artsmia.org/images/9186/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9186)


[![Christ Presented to the People (Ecce Homo)](http://api.artsmia.org/images/9202/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9202)


[![Le Grande Maitre de la Frisure a la Mode](http://api.artsmia.org/images/9830/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9830)


[![Milk Drop Coronet](http://api.artsmia.org/images/11537/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11537)


[![Cats and Dogs, Alameda, California](http://api.artsmia.org/images/11562/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11562)


[![Man in a Window](http://api.artsmia.org/images/11914/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11914)


[![Acre, from Carnal Clocks series](http://api.artsmia.org/images/19493/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=19493)


[![Romance of Ambrose Bierce No. 3](http://api.artsmia.org/images/20042/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=20042)


[![Abstraction In Nature](http://api.artsmia.org/images/20479/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=20479)


[![Homage to Stieglitz](http://api.artsmia.org/images/24272/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=24272)


[![Untitled (Swimmer)](http://api.artsmia.org/images/24952/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=24952)


[![Samuel F. B. Morse (1791-1872)](http://api.artsmia.org/images/25968/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=25968)


[![General William Tecumseh Sherman (1820-1891)](http://api.artsmia.org/images/26015/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=26015)


[![Edwin Booth (1833-1893)](http://api.artsmia.org/images/26040/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=26040)


[![Colonel Elmer Ephraim Ellsworth (1837-1861)](http://api.artsmia.org/images/26238/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=26238)


[![Heather Brown, Mimi Brown, Bebe Brown Nixon, Laurie Brown, Harwichport, Massachusetts](http://api.artsmia.org/images/27645/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=27645)


[![Copperplate matrix for "Un Corps de garde"](http://api.artsmia.org/images/27870/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=27870)


[![Silvered Steel](http://api.artsmia.org/images/28224/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=28224)


[![The Rail Splitter](http://api.artsmia.org/images/30075/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=30075)


[![Nude on Sand](http://api.artsmia.org/images/36669/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=36669)


[![The Goldweigher's Field](http://api.artsmia.org/images/41906/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=41906)


[![A Perspective of Arches, with a Smoking Fire In the Center, plate 6 from Carceri d'Invenzione](http://api.artsmia.org/images/52607/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=52607)


[![Le Hibou (The Owl)](http://api.artsmia.org/images/56005/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=56005)


[![Fotogram II](http://api.artsmia.org/images/58723/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=58723)


[![Monstrosities of 1822](http://api.artsmia.org/images/61303/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=61303)


[![The Fountain Maker](http://api.artsmia.org/images/61315/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=61315)


[![Un Corps de Garde](http://api.artsmia.org/images/63126/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63126)


[![Un Corps de Garde](http://api.artsmia.org/images/63127/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63127)


[![Burgundian Nobleman](http://api.artsmia.org/images/74564/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74564)


[![Plate 10 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74692/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74692)


[![Plate 5 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74693/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74693)


[![Plate 2 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74694/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74694)


[![Plate 8 from Le Iardin de la Noblesse FranÃ§oise (The Garden of the French Nobles)](http://api.artsmia.org/images/74695/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=74695)


[![Inconveniences of a Crowded Drawing Room](http://api.artsmia.org/images/75121/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75121)


[![Monstrosities of 1821](http://api.artsmia.org/images/75135/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75135)


[![An Apothecary, from Des Manouvriers habilles](http://api.artsmia.org/images/75492/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75492)


[![Monstrocities of 1799, Scene Kensington Gardens](http://api.artsmia.org/images/75855/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75855)


[![Morning, Noon, Night](http://api.artsmia.org/images/76001/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76001)


[![Blowing up the Pic Nic's or Harlequin Quixotte attacking the Puppets](http://api.artsmia.org/images/75861/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=75861)


[![Hercules, from Collection de figures thÃ©Ã¢trales](http://api.artsmia.org/images/76168/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76168)


[![Neptune, from Collection de figures thÃ©Ã¢trales](http://api.artsmia.org/images/76178/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76178)


[![Homme de QualitÃ© en Habit d'EstÃ©](http://api.artsmia.org/images/76225/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76225)


[![Mr. Des-fadaises (Mr. Nonsense)](http://api.artsmia.org/images/76220/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76220)


[![The Secondhand Clothing Dealer](http://api.artsmia.org/images/76666/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76666)


[![The Seller of Mirrors and Glasses](http://api.artsmia.org/images/76670/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76670)


[![The Painter](http://api.artsmia.org/images/76672/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76672)


[![The Fisherman](http://api.artsmia.org/images/76673/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76673)


[![Le Hibou (The Owl)](http://api.artsmia.org/images/90869/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90869)


[![Gentleman Dressed for a Ball](http://api.artsmia.org/images/76424/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76424)


[![The Rotisserie Cook](http://api.artsmia.org/images/76676/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76676)


[![Effet de Pluie](http://api.artsmia.org/images/105335/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=105335)


[![Stallion and Jack Fighting](http://api.artsmia.org/images/108171/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108171)


[![New Zealand](http://api.artsmia.org/images/99168/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=99168)


[![Study for "Stallion and Jack Fighting"](http://api.artsmia.org/images/108212/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108212)


[![Looking South East from 45th Street and Madison Avenue](http://api.artsmia.org/images/107223/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=107223)


[![Anne Klein with a Baby in Transit](http://api.artsmia.org/images/108443/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108443)


[![The Brown Sisters, Cataumet, Mass.](http://api.artsmia.org/images/108785/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108785)


[![Photograph of Photograph](http://api.artsmia.org/images/109602/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=109602)


[![Perspective of Arches, with a Smoking Fire, Plate 6 from Carceri d'Invenzione](http://api.artsmia.org/images/111004/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111004)


[![Nineteen Lincolns](http://api.artsmia.org/images/111188/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111188)


[![Nineteen Lincolns](http://api.artsmia.org/images/111187/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111187)


[![Throw (C-918)](http://api.artsmia.org/images/109112/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=109112)


[![Nineteen Lincolns](http://api.artsmia.org/images/111189/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111189)


[![Nineteen Lincolns](http://api.artsmia.org/images/111192/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111192)


[![Nineteen Lincolns](http://api.artsmia.org/images/111190/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111190)


[![Nineteen Lincolns](http://api.artsmia.org/images/111193/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111193)


[![Nineteen Lincolns](http://api.artsmia.org/images/111195/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111195)


[![Nineteen Lincolns](http://api.artsmia.org/images/111194/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111194)


[![Nineteen Lincolns](http://api.artsmia.org/images/111196/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111196)


[![Nineteen Lincolns](http://api.artsmia.org/images/111191/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111191)


[![Nineteen Lincolns](http://api.artsmia.org/images/111197/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111197)


[![Nineteen Lincolns](http://api.artsmia.org/images/111198/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111198)


[![Nineteen Lincolns](http://api.artsmia.org/images/111199/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111199)


[![Nineteen Lincolns](http://api.artsmia.org/images/111200/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111200)


[![Nineteen Lincolns](http://api.artsmia.org/images/111201/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111201)


[![Nineteen Lincolns](http://api.artsmia.org/images/111202/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=111202)