We might want to reconsider the color of the icon here as it looks like a link.

![Server Details](http://i.imgur.com/3pKetSK.png)


I like it. Suffinct. :)


[![Fluted Vessel](http://api.artsmia.org/images/106516/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106516)


Кейсы в `item` некрасивые :( Но, может, и ладно.


Is `Archive::Zip` still required for `Problem.pm` above?


Yeah that's true, I'll change it.


drop `defined` -- empty file/logger is no better then undefined


oh shit, that's awesome!


Style nit: long line.


I know existing code is inconsistent, bu I would prefer to drop `return` in the new code at least.


Debug leftover.


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/1151


variable names such as p, N, T are hard to understand. Could we replace them with names better to be understood?


@lencioni: I decided I'm never going to make any mistakes every again, so I won't need to use it in the future...


Duplicates condition above


Finally, I understood why this method didn't work.
I just had to inherit other base class:
```python
    from scrapy.contrib.spiders.crawl import CrawlSpider
```


Break line after `undef`


I will just add this when I merge (working on it now)


```python
    class CompendiumSpider(scrapy.CrawlSpider):
```


for the algorithms, could we put the reference in a comment? something like
# glmnet: used for lasso regression
# lasso.cv$lambda.lse: used for least square error. we've tried x,y,z and found that lse is the best suitable


Thanks for the v2 support, Kirk!


If you aren't using `lodash-amd-an` could you unpublish it.


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/b9c4ab6882f45d0a3179b04b3fccc1ae98edce4d


merging Ms2ger/servo/layout-old-path = b9c4ab68 into auto


Ms2ger/servo/layout-old-path = b9c4ab68 merged ok, testing candidate = 04d78b6f


Looks fine. :)


Meh... I perhaps `Source::Git` instead?


I'm just curious why you removed this. I thought it made a nice mini-header.


code style:
if {
...
} else {
...
}
instead of
if {
...
}
else {
}


no need for amd if you want node there's [lodash-node](https://www.npmjs.com/package/lodash-node) or [lodash](https://www.npmjs.com/package/lodash) or [lodash-compat](https://www.npmjs.com/package/lodash-compat) which support modules, e.g. `require('lodash/object/keys')`.


Le problème de lien faisait suite à https://github.com/shaarli/Shaarli/commit/b4b7d3343ae158e9267ad7dfa9aa69f3e9e0fdf2


The line that handles this is the line above with `DROP TABLE IF EXISTS`.  That's the reason the table is nuked each time you run this script.


Debug leftover.


This should actually say "The operation" not "The clause"


Source/Project64/N64 System/Debugger/Debugger - View Memory.cpp

nubfail

u forgot parenthesis


Looks fine as well. Thanks for the level update. :)


@jhpoelen sure. i've just made another small modification: now, instead of `opts`, simply any optional arguments are just passed to `get_interactions_by_taxa` with `...`; `showfield` is also renamed there:
[https://github.com/jemmybutton/rglobi/commit/5c49fd736b425cb790f004d2a81c35c7dcef9e7e](https://github.com/jemmybutton/rglobi/commit/5c49fd736b425cb790f004d2a81c35c7dcef9e7e)
it seems, r doesn't allow overriding existing argument easily, so `get_prey_of` won't likely return parasites or anything like that


Since self.follow_redirects can equal 'https' this will always allow redirects if it's set to 'https"... (hint: try this:

python -c "if 'https': print 'True'"

)


This is what `BinaryFile::load` is for, is not it?


reading a CSV file is a great chance to use the `csv` module from the Python standard library.


Straight-forward. :)


if you were using the `csv` module, you'd be able to skip this.


Well, my reasoning is that `supported_styles` is an array and the lookup for it is O(n). Thus the older version required O(m * n) where m is number of keys in `@app.style`, n - number of elements in `supported_styles`, but the newer one requires O(n * 1) since the hash lookup is a constant. But my math might be wrong :) And I don't have a benchmark, unfortunately :) How can I make one?
Btw, I think this change is a bit hasty. I should've solved the problem, made the tests green and only then made some other changes.


Code style is critical. However, in schools, we don't usually emphasize the importance. In industry, code in poor style can not be used until the programmer has changed it to good style. As you are about to graduate, maybe let's start learning good coding styles.

Each language has its own styling requirements. Please refer to https://google-styleguide.googlecode.com/svn/trunk/Rguide.xml for a good R style guide. And please change your code according to the good style.


Looks good!


Wow, looks simple. :D Thanks for the extra doc fix.


tuple assignment:
```python
name, site, food, pay, twit = truck.split(',')
```


yes it is. I see it now


Thanks.  Looks a little strange to have to pass layout_num-1 for int_to_alpha when int_to_roman expects layout_num.  Seems like the logic for int_to_alpha can be simplified, but not worth messing with...


Hi @Geograph-us.

Thanks for the example, I havent had a chance to build proper unit tests for page.sendEvent(), its only a proof of concept for now. This will help me out, much appreciated.

Steven


The code above duplicates `problems_add_new`, extract it.


Leaving a comment test test


Just to know: Why not always use the faster algorithm?


or since you are just turning around and inserting the same values in the same order, just pass in the 'truckList' variable:

```python
cur.execute(query, truckList)
```


Make it `add_remote`, `link` means different thing in CATS


We don't use camel-cased variable names in Python.  This should be `truck_list` or `trucklist`.


url, not link


Sure


Great decision! :palm_tree: :snowman:


what does this do?


Hmmm. I've gone ahead and figured out the prime generator in Java... it is as you showed on the board fairly easy and of course not perfect, since it is most likely a prime. But finding the inverse (d) is stumping me a little bit. For now I've mitigated the issue because Java actually has a method for the BigInteger class (which is what I'm working with since we want huge integers) called modInverse(mod) that goes ahead and finds d for us. I'm still trying to figure out how to do it on my own... it seems like its easier to do in python!


the 'pay' field has comma-separated content which means that it looks like multiple fields.  you want to put it in quotation marks to force it to be read as a single value.


Fixed issues #5 #6 #7


Make the code `1091` instead and move it down after `090` (it is messy, I'll explain during meeting)


This actually makes the icons look a little weird as the background is square and icon is a triangle. Instead we could just change the color of the icon itself to yellow, or we could create a custom icon using Font Custom.

![Warning Icon](http://i.imgur.com/9j9NVZF.png)


you check to see if the channel is `undefined`, so this will work the first time, but `undefined === null` is false, so setting `channelsServed[channels[i]] = null` will probably be a problem.


"Не указан удалённый репозиторий" is more precise translation


Having metadata on it's own line seems inconvenient, but makes sense for non "Metric" metadata. What if we extend the Datapoint object to also support the desc, type, and unit? Then leave adding additional metadata as is?


Fixed #4


In this project I will analyse reviews of Turkish Airlines. I will fetch reviews from http://www.airlinequality.com/Forum/turkish.htm website.
Every reviews have following structural fields along with the free form review itself.
Customers are allowed to evaluate airlines using multi-criteria e.g. catering, staff service, seat comfort, cabin flown...

1) Rating : 8/10
2) Date : 19 March 2015
3) Country: Brazil
..

I will extract adjectives from reviews using OpenNLP Part of Speech tagger tool.

I will visualize, top used adjectives and ratings per country using a heat map.
In short there will be three dimensions : adjectives, countries, ratings.
I will try  visualize that  3-dimensions data in a meaningful way using a data visualization software.

Data visualization or data visualisation is viewed by many disciplines as a modern equivalent of visual communication. It is not owned by any one field,
but rather finds interpretation across many (e.g. it is viewed as a modern branch of descriptive statistics by some, but also as a grounded theory development
tool by others).(http://en.wikipedia.org/wiki/Data_visualization)


Works beautifully :heart: :heart: :heart:


This is common code... not sure is it is enough to merit common base class.


Something odd going on with indentation in lines 297-306.


Oh I missed [this comment](https://github.com/forms-js/web-component/commit/93fc70cf584dac474c88e30784223db8a0e563d3#commitcomment-10401134). Ditching the `app` worked. Thanks!


Oh, I see -- you fixed the indentation here.

git rebase is helpful here to squash multiple commits.


I disagree that it's inconvenient. I think it's easier to write metadata output that's not tied to a data point existing.


`$git_author_name` and `$git_author_email` are now unused in `Problem.pm`


You should return the Config class, remember JS can access java methods.


WTF?


You are using this column below as a value upon which to look up trucks.  You probably aren't seeing issues right now, but with a large enough number of trucks, this will start to perform poorly because the DB has to scan all rows to figure out which ones have a given value.

The solution to this is to create an 'index' on this field.  Then, when you look up trucks by cuisine, the DB will use that index.  It has massive impact on the performance of queries where the `cuisine` row appears in a WHERE clause.


Much nicer.
Awesome work.


(sorry for the late reply) Thank you! The only reason I needed sync is the module I'm calling cannot run async but I think I managed to convince the author to fix this.


Uha, påskeæg!


Can you change to only the number being linked?

`[server] Freigeist opened pull request #1669: Send name updates on roompromote/-demote only to the same room`

In that example, only #1669 should be linked.


is `self.neighborhood` a byte-string or a unicode object?  both the `__repr__` and `__str__` special methods should be sure to return a byte string.


Won't parseTcollectorValue return a "bad line" error for the json lines? I don't see how it detects the line is json and not the old format.


this doesn't work on mysql.


Is this route intentional? sql\old\3.3.5a\world\


@VSadov, we need to add back Obsolete and hidden versions of the existing ones. See VB MethodBlockSyntax.vb for example. This will allow existing compiled binaries to keep working while preventing new source dependencies. I believe we have a work item for removing these by RTM.

Other than that looks good to me!


With this method as a user I have to:

 * Understand how to create metadata entries for metrics
 * Decide when and how often to print out metadata information
 * Implement the code to print it at that rate...

If it is part of the datapoint, I just have that part of my object when writing out the line.


Sorry about that, I honestly forgot that was possible.


This is unnecessary.  `<stdexcept>` is included two lines above this addition.


All the paths have continues, so so you we never get to the place where the errors are actually logged if at least one of these things parses ... I think


What is the secondary data directory though? Seems like this is somehow tied to `dfs.domain.socket.path`


@SzymonPobiega I agree that we need to test integration scenarios but I'm not 100% sure the AT for NH should be taking a dependency on the SqlTransport, it doesn't feel right IMO.

@Particular/engineers
What do others think ?
Maybe a more general question, how should we test our permutations (containers, transports, persistences) ?


I'll admit that I didn't 100% understand this part. It looks like a change was made earlier, to resize this to a square, instead of a rectangle matching the requested size. But this messes up the positioning of the preview. It also means that you can drag outside of the preview, and it will still move.


It tries all three, and proceeds at the first one that parses and has valid data, and does a continue if it does. Only if all 3 fail will it print errors.


Rather than 'above config' please reference the actual config param `mesos.hdfs.native-hadoop-binaries`, in case these get reordered.


Can this be plural, in the case of multiple zks?


Can this be a plural zk, or a manually entered master URI(s)?


I just realized this doesn't follow the packages style of camelCasing variables. I can clean that up before I submit a PR.


Boom! Glad to hear :)


gotcha... that looks correct. So for a bad line we would see multiple errors as it tries to parse it. Make sense.


No idea. It's passed to MesosSchedulerDriver


90946736_WSHP_#4567 (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


@EPaulG FYI: Missing a `"` at the end of the snap manual link.


yes, it's the one accepted by the db updater


Could you explain why it's meant to use raw pointer?


> Maybe a more general question, how should we test our permutations (containers, transports, persistences

yes but not in the repos for those projects


Should this %v the data? If it doesn't how would we know why the DataPoint was invalid?


@drinker22 the domain name has changed. Updated it now and new package will be published soon on nuget.episerver.com


This is not 'highlight' I suggest 'Add link to ...'


Most of the complexity here has to do with the fact that there is no guarantee that if a file is called foo_test.py that it will try to import from foo.  I think  perhaps that the lack of convention there should probably be addressed.


@Paladin yes i tryed that, but seems that only work if you are under JApplication* because when i set that on libraries/cms/plugin/plugin.php seems that $application variable is not set.

I understand your point that this is not a correct fix because maybe someone like to use JFactory::getApplication('site') but i didnt found a better solution


this is a comment on that


This is redundant, just check `remote_url` in template


It is natural to me that the easier way is to print the metadata once on start, then not worry about it every again in the rest of the program. That is the way Bret's .net library works, and how I think scollector should be refactored to work.


weird, I'll double check what happened there


@jucarave please review


It should be empty string.


Sorry about that, thank you for pointing that out I will take care of it
and try fixing it up by this weekend. Is that OK?

Best regards

Hanshuang

2015-03-25 19:07 GMT-04:00 Guan Wang <notifications@github.com>:

> Code style is critical. However, in schools, we don't usually emphasize
> the importance. In industry, code in poor style can not be used until the
> programmer has changed it to good style. As you are about to graduate,
> maybe let's start learning good coding styles.
>
> Each language has its own styling requirements. Please refer to
> https://google-styleguide.googlecode.com/svn/trunk/Rguide.xml for a good
> R style guide. And please change your code according to the good style.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chqsark/capstone/commit/ff530c659ed0e3837209703c34b26ece55336b86#commitcomment-10401649>
> .
>


1) Documentation is unclear, but `git remote` seems to be porcelain, not plumbing.
  Maybe `git config remote.origin.url` ?
2) 'fetch' below is a refspec, you need url


Don't remove class implement, it's used elsewhere.


Foundation from 5.5.0 to 5.5.1


So, git call for every problem every time somebody looks at problem list?
Store url in a database instead, as we discussed.


Why didn't you just do '[\t ]+' like other white spaces in the line?


Use the [tools that Pyramid provides](http://docs.pylonsproject.org/docs/pyramid/en/latest/api/httpexceptions.html#pyramid.httpexceptions.HTTPInternalServerError) for returning error responses


VSHPWH (shenb) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.51%25-red.svg)


All I used is <url-pattern>/*</url-pattern>.


He literally came home and was like "whoever wrote the copy on your dvhacks project on github needs to be fired".

I wrote it 0____0

I told him @JakeLoo did.... sorry buddy, I needed to save my ass :P


If you want to roll with that then you could catch the ftp error and raise an JESftpError with a nicer error msg.


Reason?


This was actually intentional, since it creates a line break when parsed by markdown. But if it increases readable, it's fine by me.


This is quite confused condition, re-think it please.


Awesome, thanks!


Will the documentation in http://docs.hhvm.com/manual/en/function.array-filter.php be updated somehow to reflect this change?  If not, does a PR need to be opened against the documentation?

Are there other late additions to PHP 5.6 that also need to be backported[sic] into hhvm?


Why is simple `git pull` not enough?


The `ElementIdLifeCycleManager` was not being disposed causing duplicate entries when you re-opened the same graph.


@hoangthienan I fixed this bug in commit 344211bf7c1a7294377851469f77b79ef15a6a67.


обновить?


What about aging? I.e. the host page only shows metadata more recent than a day or two.


Debug leftover.


scollector resends the same data each hour. It doesn't have to change to be resent.


Ah, gotcha. Didn't really consider readability with this change--I just have my editor configured to remove this stuff when I save and thought it was unusual for it to be in these places.

I checked out the before and after rendered, and it seems pretty odd to me to put a line break in the middle of a paragraph like that. If you are looking for a way to break up the text visually to help people parse the ideas, it might work to bold the terms "Generic extensions" and "Type-specific extensions".


I'm not too sure on the use of MapColor here. I think it's more 'coincidental' that the map color is the same as the dye color. I would do something like:
```java
float[] rgb = EntitySheep.func_175513_a((EnumDyeColor) (Object) this);
return new Color(rgb[0], rgb[1], rgb[2]);
```
But also would cache the color object in a field.


We already have this five lines higher.


ast_optimizations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Whats wrong with 4233, 4267 and 5740?


Ah, ok. I wasn't aware of that change, though it makes sense. Other than that I didn't notice anything that could potentially be an issue. One thing I did notice is that for the TemplatePack project the packages.config says we are using version 1.1.2beta5. With the recent bug fixes do we want to upgrade this to the current version or continue using that same version for this release?


This is where accepting multiple input formats gets annoying. Since both the json types are valid json, one will succeed and one fail. But the fail one will fail, not due to json parsing (which will succeed), but due to the data not being valid (i.e., everything is 0 or empty). I admit this error message is less than ideal, but making it more specific might actually confuse people more, as they are trying to figure out why scollector is complaining about a nil value for something they didn't even specify.


Is title visible enough? Do we lack space to display url as text?


oh, you just added that the other day and I merged without noticing.


I don't like the idea of using "home" so I'll need to come up with another solution for this. Home is just temporary so we are able to navigate between pages


This does not create a repository. `get_repo` ?


LGTM!


possible leftover line


Yes, that's great.


correct -- `@@` vars have surprising inheritance semantics which are not as explicit as methods, so rubocop advises to steer clear


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/95ead0dbfbc8fdb07f8b80c56dce4d4f701b9c94/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/95ead0dbfbc8fdb07f8b80c56dce4d4f701b9c94/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/95ead0dbfbc8fdb07f8b80c56dce4d4f701b9c94/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/95ead0dbfbc8fdb07f8b80c56dce4d4f701b9c94/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/95ead0dbfbc8fdb07f8b80c56dce4d4f701b9c94/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Nice! I couldn't think of a way to do this in a way that wasn't hacky either. I guess this works for now.


No worries, and good point!

(FWIW, I also have my editor setup to trim trailing spaces, but not for markdown files ;) )


Gotcha. Might change it to JSON object is not a valid opentsdb.DataPoint object and a similar message for metadata.Metasend, so it is a bit clearer that the JSON is valid just not the right type.


yeah, will fix this up after https://github.com/brianmario/mysql2/pull/592 and https://github.com/brianmario/mysql2/pull/595


New Colors


Do not commit binary or object files.
Please redo the pull request.


This is not `pid` any more, and I do not understand why you mangle `sha`


On 26 March 2015 9:10:50 AM AEST, Greg Horn <notifications@github.com> wrote:
> what does this do?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/peddie/pipes-zeromq4/commit/eb2dc251b63ecb7537761eea9a74f866c49aaac2#commitcomment-10401700

It's meant to test the build against the packages in the latest Platform, which are usually much older than what cabal will fetch if unconstrained.  I don't think it makes much difference for this package (though I left right after landing it and have yet to see whether it went OK).

It's stolen straight from hvr's 'multi-ghc-travis' configuration.

Matt


Why leave call to `get_repo` here, but not above?
Generally, this seems under-thought change.


fair, this can be fixed with `defer.callback do |_result|` to indicate that the argument is unused and appease the cop. will fix after https://github.com/brianmario/mysql2/pull/592 and https://github.com/brianmario/mysql2/pull/595


Based on #32 we might want to change the way we save magnet links. It sounds like his torrent client expects on file per magnet link.


This is what I used for A* in the last assignment. It's 3 different classes: Astar, BFS, and CostComparator.
I think it will be helpful for this assignment.


I'd really like to use this new context parameter but it doesn't look like npm was ever updated? When can we expect this to be pushed to npm?


@Catacola Can you push this to npm?


I hate eGit


Satirepandaen har lagt et æg!


I was waiting for https://github.com/wit-ai/node-wit/pull/4 @irfaan to release a new build in npm. I'll do it tomorrow without the pull request if it's not finish.


Since you do not check result of `rmtree` anyway, I do not see much value in additional warning -- just call `rmtree` in one line.


The <module>_ucli_node_create() functions must not take parameters. They are all collected automatically through xmacros to build the .modules subtree.


Not ivs


Another debug leftover.


xcode 的第二段 同时打成同事了…


Hm, this is still kind of weird because we're still calling `get_context_data` where we don't need to. What about this idea:

1. Make `get_donation_level_formset` do what `add_donation_level_formset` does right now, but return the formset instead of adding it.
2. In `get_context_data`, we can just do `context["donation_level_formset"] = self.get_donation_level_formset()`
3. In `form_valid`, we simply have to call `formset = self.get_donation_level_formset()`


... `&& $remote_url` ?


Since the PR need resending anyway, squish this into 'Add pull for remote problem' commit


I changed a += 1 to a + 1. The assignment was borking the recursion. Look at the ruby solution on rosettacode. It is really fast but doesn't generate the actual change combinations. I wonder if we could figure out how to cache our results?

Best wishes,
Erich

> On Mar 25, 2015, at 1:46 PM, David <notifications@github.com> wrote:
>
> I'm not seeing what you changed to fix the hash problem. Didn't we try this exact solution and get a different answer? Yes, takes 2 minutes to run for me too.
>
> —
> Reply to this email directly or view it on GitHub.
>


Mismatch


Pycifrw is no longer needed.....


@andrew-t  repull request  please


add project


rax retry tests


heh, nvm. all good.


@drewbarontini So it's a development dependency?


Hi @timlinux this raise another error since there is no `crontab` file/directory.


However, I do like this part in RFC 5737: "These blocks are not for local use, and the filters may be used in both local and public contexts.". There are lots of private IP addresses used in testcases, etc...should/could they all be updated?


I think it's common to say "evolves quickly" rather than "evolves often"


ㅇㅇ 마즘 polymorphic association 하나로 status랑 hashtag 다 커버하는 거.


Soon (TM)


This class is awesome !


Maybe you can move this section of clarifying your project goals before the Setup section, and turn it into a list of what your app is going to do.


Hey did you get Siddu's permission before putting this here?


Clarify instructions:

Create a new directory for the app, and inside create a new file named `package.json`


없어도 되는 건데 (동작은 하니까) 없어야 되는 거 (convention과 다르니까)
만들어지는 named route도 다르고 ㅇㅇ


Cool!


change to string return type


r+


test


My hunch is that this change is causing crashes when test/format corrupts files and runs salvage.  There is a lot of grey area between "trusted" and "malicious" input...


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1166 of 1166 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.77%25-green.svg)


```haskell
splitWords "ACB          DE    FG" -- ["ACB","DE","FG"]
```


me gusta!


eliminates leading space from string

```haskell
dropSpace " rodrigo" -- "rodrigo"
```


@wonzhq i am not sure if we need to `delete tick_event` here.

in the case you described, the Objecter's timer removes the tick_event from its events queue, and calls `Context::complete()` which in turn calls `Objecter::C_Tick::finish()`, where `Objecter::tick()` gets called.

put in another way, `Context::complete()` will delete the tick_event before `Context::complete()` returns. am i right?

and i'd suggest moving the `tick_event` out of the `if` block. as it should always be deleted and reset after `cancel_event()`, no matter it returns true or false.


90022444-FewReleasePrepThings (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.54%25-red.svg)


Thanks!


Can you make this a multi-line comment using triple single quotes.


Related to BroadleafCommerce/QA#434


PR #162 does that.


I'm not sure what conflicts you are trying to fix here, this caused the app crash on me. And I didn't see the conflicts before either.


bench: 8193650


dffidid


This is awesome!


This changes the meaning - it needs to iterate over the result set in order to measure the time to iterate.


Yeah on 2nd thought it's not a good idea to add magic behavior for `bool` since it'll automatically update unsupplied bool properties back to false, better to throw an exception than unintentionally overwrite data. I've also added a test for nullable ints in this commit: https://github.com/ServiceStack/ServiceStack.OrmLite/commit/13665605ef5209794910f8716de291c27cb8eae7

This change is [deploying to MyGet](https://github.com/ServiceStack/ServiceStack/wiki/MyGet) now, should be available in 20mins.


You sure the butthole isn't on purpose ;P
am I joking? Or am I serious?


Thanks @oplatek – I like this clean-up.


Why there is a non-sense line here?


Why do we change to use fedora for docker-prod?


These might take you great effort!! good job!


Joking.


不知道为什么发到我另外一个账号了。 晕迷。
修改得非常棒。

李子轩 - iOS/Rails工程师 - 创始人@scoooter.io - Purdue
http://scoooter.io


oh good upper/lower/digits I wish Clojure had these :+1:


if it breaks things for you, then i'll revert it


the changes to the `splitWords` function prevents it from behaving baaaadly when the given string has leading space characters. fixed y'all


Looks really cool. I'll have to test this out!


Looks good Frank, Lucene >= 4.7 mandates Java 1.7; Correct? If u r ready to merge this patch u may want to update the parent pom.xml to Java 1.7.


Wait, could you app been crashing due to @paulinar changes? See how there are a bunch of commits after my change. What kind of errors were you getting?

![screen shot 2015-03-24 at 8 53 12 pm](https://cloud.githubusercontent.com/assets/5770941/6818144/d5d1761c-d267-11e4-8efd-4372f54f4ffe.png)


All I did was move UIUtility to a package called utilities and renamed the import statements


r+


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-65.41%25-red.svg)


saw approval from metajack
at https://github.com/glennw/servo/commit/a3b1fac5035c2a408ad53a54532d1f81f0298cd4


merging glennw/servo/glutin-fixes = a3b1fac5 into auto


glennw/servo/glutin-fixes = a3b1fac5 merged ok, testing candidate = 29269630


This was made automatically via Laravel, right?


Since roms were supplied, it was assumed it would work on a non-CD console. I've only tried it in HBMAME (emulation of a non-CD console), and the Z80 actually executes invalid code, which usually indicates a bug in the m1 rom. I appreciate that your Z80 skills are not much good, so I guess the problem isn't entirely unexpected. Normally I'd have a go at fixing it, but have zero knowledge of neogeo programming and so have no idea what your Z80 code is supposed to do. I guess you could use the HBMAME debugger and see where it's going wrong.


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


this should really be a jurisdiction, it could be a county, not just a city


You want to pass through doActions as you received it, don't you?


Might as well add polyacid's touch reaction to this (and all it's horrible code), since it's replacing polytrinic.


causing -> preventing*


Can be merged to 1.4.1 ?


I think what you have here is something like a repr--if you compare to the name properties of the other tokens, they're mostly semi-verbose user-facing strings.


Also, do we care about case in exact matches?


I was not looking at the last branch.  I was looking at the commits in
chronological order.  This is one of the flaws of reviewing individual
commits.  In the version I looked at, there was still code at the end of
the measure to transfer values from the ShapeImpl status to the SdssShape
status.  But I suppose that goes away eventually?

On Tue, Mar 24, 2015 at 9:39 AM, Jim Bosch <notifications@github.com> wrote:

> I don't quite follow w.r.t. line 151 - it might be easier if you actually
> put your comments on the line in question (click on the mouse-over plus
> sign when you highlight the line number).
>
> By the last commit on this branch there should only be one enum remaining.
> If you see signs of the old SdssShapeImpl one still existing, please point
> them out on the "Files changed" diff.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lsst/meas_base/commit/eb23f182d32533ea17d577f7c3988cd20b763eff#commitcomment-10371751>
> .
>


Several charms were facing a mysql/access_network race condition, these upgrades were a welcome upgrade.


--> we can use...


--> you have the teracy-dev VM by following the...


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-89.63%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


you could probably do a better job here you're creating an extra row at the top. I will brainstorm and think of a solution.


>> Open ...., you should see the `test.rst` file, click it to see the result.


Doesn't look like this is still needed. The 0.6.8 release does have getSteamLevel.

With the github url, I found that I have to run `npm install` inside node_modules/steam or otherwise I get the following error when attempting to run it:

```
[...]/steam-chat-bot/node_modules/steam/lib/steam_client.js:18
th.join(__dirname, '../resources/protobufs/dota/steammessages.proto')).build()
                                                                      ^
TypeError: Cannot read property 'build' of null
    at Object.<anonymous> ([...]/steam-chat-bot/node_modules/steam/lib/steam_client.js:18:108)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> ([...]/steam-chat-bot/lib/chatBot.js:2:13)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
```


yup, he agreed as long as the attribution was kept.


yes


MongoDB university with node.js and express


По аналогии с тем как мы делаем слабую ссылку на `self` при передачи указателя в блок, это имеет смысл и для других объектов, которые не должны удерживаться блоком. Например grayView вполне мог бы помереть раньше блока при выходе с текущего контроллера, а значит его оправдано передать в блок по слабой ссылке.


Not sure why this changed from 30 (declared initially) to 33 later in my program. But it caused quite a few issues. In fact, when you entered 19 characters, it would remove all of them. If you entered 20 characters, it would remove 19 leaving 1 character behind. Once I put this line in, it completely fixed the issue with removing multiple characters with a single press of the backspace.


I also wanted to add the ability to press the numberpad enter key as well to complete name creation. A small but needed addition to my conditionals.


Please add the [connectors.json](https://raw.githubusercontent.com/bsenduran/sample-recipes/master/publisher-resources/connectors.json) to publisher/config
Edit the path and add the connectors details


Missing r for: `AssertAll...`?


Ok, I wasn't thinking straight this morning. Two things are wrong with the changed code:

1. `(A and B) or C` ≠  `A ? B : C` if B could be `false` and `C` ≠ `B`
2. `foo = false or true` doesn't parse the way I was expecting:

````
irb(main):010:0> foo = false or true
=> true
irb(main):011:0> foo
=> false
````

Instead, I've settled on

```ruby
      modified?(source_path) || ((dest_path and !File.exist?(dest_path)) or false)
```
with `modified?` changed to check for a `nil` path.


@benmgreene thanks for PR. I think the change is not safe in case when `Meteor.typeahead` is applied outside of `Template.instance()`, i.e. when call with custom data source function. Please update the PR.


read, comment


the example project can not be run correctly


@fengmk2 写文档是个苦差~
还是得完成相关实现才好给文档添加 demo
（先推个半成品，晚上继续）


* Adjust spacing of multi-line computations
* Add parenthesis around the *squared* terms so the computations are clearer


r+


Yep, thx.


I've managed to get the line editing working with Chrome, but not Firefox.
This is the line I was concerned about that did nothing except exit an error condition, though I think you already know this.


![silveradooo 2](https://cloud.githubusercontent.com/assets/11449632/6818453/f95c2cac-d303-11e4-8ba7-4f79fb6150ca.png)


Anh traitravinh oi,
moviHD.net script error roi, anh sua giup dum em voi.
Thank you anh,
Duc


ResultsSchema (sanyalj) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-50.51%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Typo? Did you mean `ASSERT(priority != -1)`?


--> just update the .rst files and we...


--> can see...


? This will halt the emu if `SetAppCpuTimeLimit` is called


在后台任务处理完之后，它在UI线程会处理从后台任务传递过来的执行结果。


Ack. FWIW, this "CN or subjectAltName" business is also in https://cabforum.org/wp-content/uploads/BRv1.2.3.pdf section 11.1.3


Do you mean we need to transform netmask to node mask? But how to do? For example, netmask gotten from the interface is in type in_addr, so, how to transform it to node mask?


Retina-resolution image needs to be added.


Thanks Seth, but it still does not work on home page it only goes through the 5 slides and then repeats... it also only has 5 little buttons as pictured,  but the control panel for iced mocha settings does now have 10 options for the slides so its definitely a step towards what we are trying to achieve.

![untitled](https://cloud.githubusercontent.com/assets/11142210/6818507/83be95ec-d287-11e4-8edd-c28b1d50af72.jpg)


Hi Hung,

This is general IP address, refer to link http://library.mobrien.com/net.shtml to get node mask.

Regards,
Hoang


I'll do after school (German time) ;) At the moment, I've applied only one PQSMod to all planets, all values are through code, because I had to understand the way PQSMods are applied.

----- Ursprüngliche Nachricht -----
Von: "Nathaniel Lewis" <notifications@github.com>
Gesendet: 25.03.2015 00:16
An: "ThomasKerman/Kopernicus" <Kopernicus@noreply.github.com>
Cc: "Dorian Stoll" <dorianstoll@googlemail.com>
Betreff: Re: [Kopernicus] Merge pull request #3 fromBryceSchroeder/development (cdd8b15)

Could you push what you have so I can see how you went about setting it up?
—
Reply to this email directly or view it on GitHub.


If I read this right, you are using a member of shape result to pass an intensity.  Isn't there a better way to do this?


read comment write change


This could be removed all together.


admin


change prompt information presentation way.


ok great


sysinit not required.


I chose `annotationIDsByAnnotation` in e99244828f646cc086a4d700753309ead678860c without realizing that the object values are actually dictionaries that happen to only contains IDs at the moment. With mappings in Objective-C, it’s crucial to get the naming right to prevent difficult-to-debug errors later. Let’s call it `annotationPropertiesByAnnotation`.


Yay! :stuck_out_tongue_closed_eyes:


Just checking that you are sure this is right.  I thought that in the past, the order was xx, yy, xy for the ShapeResult


Same comment about the ambiguity of intensity and flux.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1140
success: http://build.servo.org/builders/linux2/builds/1140
success: http://build.servo.org/builders/android/builds/1174
success: http://build.servo.org/builders/mac1/builds/1353
success: http://build.servo.org/builders/mac2/builds/1356
success: http://build.servo.org/builders/gonk/builds/322


Updated with the previous color scheme, also updated various splash images to use consistent colors

![image](https://cloud.githubusercontent.com/assets/7192646/6818638/2fc51c08-d279-11e4-9ca2-01c2f594ad4d.png)


90022444-FewReleasePrepThings (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.53%25-red.svg)


There's you effin' problem right there, @Ironholds


return list.toArray(new L2ItemInstance[0]);


Yes, fixed here - https://github.com/synfig/synfig/commit/156a6955396df030b5a2c8736f449ba63a934527


I like it :+1: Was gonna suggest something like this when I got to annotation shapes, which are going to probably start storing styling properties.


fast-forwarding master to auto = 29269630


why need pin8? why does the ppd60-t2 need to used DigitalOutPut pin? in line58 of codes, these is only analogy data calibration, and it seems pin8 is useless.

would you tell me if you connect ppd60-t2 to arduino with for fingerpin:
1.   GND
2.   Analog Output (0-3.5V)
3.   Vin: 5V
4.  Digital Output (LoPulseOccaupance Time)


saw approval from jdm
at https://github.com/mmatyas/servo/commit/2fbac266f684f5b3862b838ecf6105936288cf7f


merging mmatyas/servo/canvas_stroke = 2fbac266 into auto


mmatyas/servo/canvas_stroke = 2fbac266 merged ok, testing candidate = 6cd92ccd


Ha makes sense, that was dumb saving `$_` and there was confusion b/w types heh heh. There is a trivial test case.


is the fact that the covariances were not scaled by fluxScale a bug in previous version?


@smalyshev I think this should also be merged into 5.4 .


These were the lines I complained about on one of the previous commits.  I see now that you changed things so that the error flags are written directly to the SdssShape flags.


The missing links!! Setting the empty arrays outside of the loops resolves the issue I was having of only one pairing being show. And it makes perfect sense! With the empty array inside the loop it would add the item but then loop through...clear out that item, because the array was set to empty, and then add the next item.


Don't really know how this got here, but it is rather bad.


I'm glad your paying attention to this stuff.


But since this doesn't really impact performance, I can bring this up again in a different PR.


@snozawa
why we need this?
for example, if we add feature to access end-coords like `(send *pr* :larm-end-coords)`, is it sufficient?


How should we access Rails console after this commit?


Имя метода должно записываться в camel-case нотации (пропущена одна большая буква).


Kein Problem mit Deutscher Sprache :)

Knox und Tima patchi in nun in die default.prop rein, securestorage war schon mit false drin.

Zu der selinux.fs Geschichte: Was bewirkt das?

Sorry, dass ich da so rum zicke, aber ich baue immer nur gerne was ein was ich auch verstehe.
Danke!


Перед вызовом блока нужно проверять его на равенство nil. Т.к. этот блок получен на вход метода, нельзя с уверенностью знать что он определён. Если блок не определён, программа упадёт.


Very cool!


Andy for the win! Though I do wonder, why wasn't I able to reproduce this error on Chrome, Chromium, Opera, Firefox, Fireweasel, and K-Melon, or on mobile?

Was this due to a specific caching method? I use ACP.


:trophy:


r+, this is great!


./launcher enter app ... works just fine


What is the suggested way to bind inside an ng-repeat so that the getter/setter can know the object to reference when it's not absolute? In other words, if used inside a ng-repeat where the context is an item in an array, how would the getter/setter know which object in the array to act on?

Since the getter/setter assumes $scope as context indirectly, what about a 2nd parameter to provide that context?


Для констант желательно использовать константы, а не макро-подстановки.


I should note that this logic has a minor issue when post-shader and blend-subtitles are both enabled: we draw the subtitles, sample from them and then immediate draw them again using finish_pass_fbo. (in the code below this comment)

If this unnecessary extra pass bothers us, it would be possible to work around it in theory, requiring:

1. checking for load_filestr before blend_subs
2. swapping FBOTEX_FUZZ for 0 in this case
3. skipping the finish_pass_fbo line in the post_shader code if blend_subs is enabled

But I deemed this too convoluted and complicated to be worth bothering about. Maybe there's a better way to structure the logic here, though.


with reference to issue #78


Что произойдёт если данные обновятся "внезапно"? Например будет перезаписано свойство `self.repositories`, или на его месте вовсе окажется NSMutableArray, в который будут внесены изменения...


I don't know if this adds nothing or not, but a function must contains a Returns clause. IMO, the Effect clause is saying too much about the returned future. The single effect is that the futures/shared_futures are moved/copied some where.  IMO, everything else should be associated to the Return clause.


did you mispell canola?


Эта строка условно корректна. Выглядит не очень хорошо, т.к. происходят частые обращения к сетевому стеку. Вообще говоря если кэширование настроено правильно, то это допустимо кроме одного тонкого момента: представим что у нас 20000 репозиториев и пользователь очень быстро прокручивает таблицу до самого низа. В таком случае придётся довольно долго ждать. результатов это раз. Т.к. ячейки переиспользуются, а сетевые запросы и их completion-блоки живут пока не выполнятся, на самом нижнем экране мы будем видеть мигающие данные в ячейках (для каждой из 10 ячеек на экране выполняется по 200 сетевых запросов, каждый из которых по завершению отрисовывает полученные данные). Чтобы этого избежать, желательно предусмотреть инвалидацию запросов при уходе ячейки с экрана (метод `tableView:didEndDisplayingCell:forRowAtIndexPath:`).


Для подобного рода задач есть готовое решение под названием `AFNetworkReachabilityManager`. Он поддерживает инициализацию с заданным именем сервера. Кроме того он умеет рассылать нотификации или вызывать колбэк когда сервер меняет статус доступности во время работы приложения.


这样做不对，是会有问题的。


future_errc are more error codes than error conditions

```
       template <> struct is_error_code_enum<future_errc> : public true_type { };
```

We can create an error_code or an error_condition using

```
       error_code make_error_code(future_errc e) noexcept;
       error_condition make_error_condition(future_errc e) noexcept;
```
In addition future_error is created explicitly from an error_code.

```
    class future_error : public logic_error {
    public:
future_error(error_code ec); // exposition only
      const error_code& code() const noexcept;
      const char*       what() const noexcept;
    };
```


Перед вызовом блока его следует проверять на равенство nil. Блок получен на вход метода и мы не можем быть уверены в том что он определён. В противном случае (когда блок не определён) программа упадёт.


Man, I really should have broken this up into more than one commit...


hey I see it now, nice fix thanks!


Huh, okay. I didn't quite get that. Makes sense now.


For some reason I don't see the nice comment bubble glyph and instead see what appears to be an equals sign. Any idea what's going wrong?


Когда какой-то параметр передаётся в конструктор, следует всё же показывать его публично в виде readonly-свойства. Как правило это позволяет клиентам работать с объектом более комфортно.


Как мы обсуждали на лекции, если есть слабая ссылка, которая используется несколько раз, её следует сначала сделать сильном в локальном контексте, чтобы объект "внезапно" не пропал во время работы с ним.


Перед вызовом блока его нужно проверить на равенство nil.


I would replace "supplied to the call to when_all" by "stored on the shared state".


No, I had the issue with Cura. I don't think it's really a problem. even at 115200, the GCODE is flowing __much__ faster than the printer can move the axis.

As for extruders, 1 makes more sense. the ones who have duals, should know how to patch. However in my case, I have 1 working, but using the dual plate, I still need to take off the 57 mm. thinking how to patch it.


You can use transactions with `begin;`, `commit;` and `rollback` sql commands.

```c++
		db <<
			"create table if not exists user ("
			"	age int,"
			"	name text,"
			"	weight real"
			");";

		db << "begin;"; // begin a transaction ...
		db << "insert into user (age,name,weight) values (?,?,?);"
			<< 20
			<< u"bob"
			<< 83.25f;
		db << "insert into user (age,name,weight) values (?,?,?);" // utf16 string
			<< 21
			<< u"jack"
			<< 68.5;
		db << "commit;"; // commit all the changes.

		db << "begin;"; // begin another transaction ....
		db << "insert into user (age,name,weight) values (?,?,?);" // utf16 string
			<< 19
			<< u"chirs"
			<< 82.7;
		db << "rollback;"; // cancel this transaction ...

```

But i'm not sure transactions are the reason for your comment :`it is very slow When I am lauching multiple queries in a for loop`.
You can create a new issue in https://github.com/aminroosta/sqlite_modern_cpp/issues page.
If you provide a sample code which explains the problem it will be very helpful.


90022444-FewReleasePrepThings (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.47%25-red.svg)


some tests failed:
failure: http://build.servo.org/builders/mac1/builds/1354


Hey there guys, any news on how should be the final code here?
So far, I've tested on WP, iOS and Droid and no error.
But my mobile app does not use ipv6 anyway, so looks like I'm safe.


Remove this line


This seems overspecified. There is not always a need to move/copy the stored future/shared_future. The shared state could store directly the Sequence and just change a flag to state the Sequence is ready.


90022444-FewReleasePrepThings (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Hi,

gpaparse@otenet.gr wants to follow you.

****** Is gpaparse@otenet.gr you friend? ******
If Yes please follow the link below:
http://invites.infoaxe.net/signup_e.html?fullname=Dmst-sweng/git-intro&email=reply@reply.github.com&invitername=gpaparse&inviterid=30805254&userid=0&token=0&emailmasterid=099b4afb-f636-46d8-8036-d51d73833e0c&from=gpaparse@otenet.gr&template=invite_reminder_a&src=txt_yes

If No please follow the link below:
http://invites.infoaxe.net/signup_e.html?fullname=Dmst-sweng/git-intro&email=reply@reply.github.com&invitername=gpaparse&inviterid=30805254&userid=0&token=0&emailmasterid=099b4afb-f636-46d8-8036-d51d73833e0c&from=gpaparse@otenet.gr&template=invite_reminder_a&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.infoaxe.net/uns_inviter.jsp?email=reply@reply.github.com&iid=099b4afb-f636-46d8-8036-d51d73833e0c&from=gpaparse@otenet.gr


saw approval from jdm
at https://github.com/frewsxcv/servo/commit/605e21c40676cb863c878fefc26982c31d257bd8


merging frewsxcv/servo/window-docs = 605e21c4 into auto


frewsxcv/servo/window-docs = 605e21c4 merged ok, testing candidate = 8b5df113


Same overspecification here.


No need. I missed the fact that it was doing various other things too. Good
work. Keep it

On Tue, Mar 24, 2015 at 7:17 PM, Swati Jadhav <notifications@github.com>
wrote:

> Here I have used the Gogovan Class as we have redirected all GGV-api call
> from the class itself.
>
> https://github.com/crossroads/api.goodcity/compare/GCW-209-add-status-polling-to-gogovan-or#diff-4
>
> @steveyken <https://github.com/steveyken> Should I replace it with the
> above one?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/crossroads/api.goodcity/commit/2b4263f41d03718fd8a6f0c13003bdad18187763#commitcomment-10364459>
> .
>


90022444-FewReleasePrepThings (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.53%25-red.svg)


Maybe change this description? It should only parse them when passing the option.


30411/Antal A. Norbert Zoltan/Assignment 3/main.c

You could even pass the "file" parameter here as an argument if you wish to not have it global, but that's just a personal preference.


woot


Instead of having all the logic in one function, why not split it a bit?

Try creating a ```listFunctions.h``` file and a ```treeFunctions.h``` file, each with their ```.c``` counterparts. In the lists file, you can create an ```addLast``` method which will take care and simplify this ```getListFromTree``` method. Also, you can have a delete function for the list element there as well.
The ```treeFunctions``` file can contain the ```createBinTree``` method and the prettyPrint one.

The methods ```getListFromTree``` and ```getTreeFromList``` can indeed still be placed in the ```main.c``` file.


Overall, very very well done! And you were also terribly quick!
Good job :+1:


:+1:  Thanks


I don't see how this allows control of context short of adding functions to my model. Did I misunderstand what this is meant to solve? My scenario comes down to using a getter/setter inside ng-repeat and the getter/setter isn't on my model so I need a way to determine which object is actually being referenced/modified.


Hi @sunil-sharma Did you manage to refactor yet?


I've encountered this and hadn't had time to dig into the issue.  Thanks so much for the fix!


Can't inlineSourceMap just imply sourceMap? Not sure I see the value in making this an error.


merge two files


Is the '=' supposed to be there at the end?


indent


I think it's fine to have a test recipe -- :+1:


r=jdm


加上了，怎么不行啊，感觉参数没有起作用


a few comments around the configurable fields would be nice.


We use this all the time and have not had any problems. Did you experience any problems?


Looks like the annotation view [tries to keep its tint color in sync](https://github.com/mapbox/mapbox-gl-native/blob/3caa2f306b0a046f31152f14d419db15639210b5/platform/ios/MGLUserLocationAnnotationView.m#L130) with the map view’s.


Can you break up this line into multiple lines?


;; Sorry I confused working branch. (I modified and pushed the Markdown-authoring tree; )


90693826-Central-cooling-coils-not-autosizing-to-correct-airflow-in-some-cases-#4810 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1671 of 1675 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


i'd suggest to use something like
```
int dm_ids[k] = {0};
int dm_ids[k] = {0};
```
to initialize arrays on stack just for the sake of conciseness. but `memset` should be fast enough.


90022444-FewReleasePrepThings (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (654 of 656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.59%25-green.svg)


It’s a little clearer if you nix the `//`s, which aren’t technically part of the license.


breaks my build
core/res/res/values/config.xml:25: error: Resource does not already exist in overlay at 'config_disabledComponents'


そんなわけないやんけ〜


This fix looks fine to me as well.  I'd like to pull it in.


No, No, No. That is not the right way to do it. Quote variables to allow spaces.
i.e.

    cdl.py "Some really long name"


:heartpulse:


I'm not sure what happened here. I'm going to try and undo this.


You use regex probably because you might not know of [Beautiful Soup](http://www.crummy.com/software/BeautifulSoup/bs4/doc/)


I don't understand why we need location data. Could you explain?


I think *!important* is not a good solution here. Noticed this after upgrading as my custom styles were overwritten...


xxxxxxxxxxxx


Yes, I did.
https://github.com/crossroads/api.goodcity/blob/master/app/controllers/api/v1/authentication_controller.rb#L206
https://github.com/crossroads/api.goodcity/blob/master/app/controllers/application_controller.rb#L14
Can you please review changes in above links ?


`enum` type should have `Members` not `Properties`. Similarly below.


private static final változók nevei csupa nagybetűsek szoktak lenni.

Nincs olyan kártya, hogy "T", hanem "10"


I am surprised there is nothing existing we can use to do this. Seems error prone to implement this logic ourselves.


This should be `array` instead of `enum` and the member section should be

```
#### Items

- (enum)
    - (..)
```


This code looks  find (not including the pile of .DSStore files).  I don't have an IOS device to test it on, however.


丧心病狂。。


#4 test


Actually I think this is OK, it looks like it just merged contents from ```master``` to ```autoupdate```. I will investigate if there are any issues tomorrow on my other machine.


@eviltoylet Sounds good! I'll change the API along those lines. :+1:


Isn't it a bit strange that we append PLATFORM_C_FLAGS_DEBUG here, but we append CMAKE_CXX_FLAGS for the release build?

Aren't the CMAKE_CXX_FLAGS_DEBUG flags appended to the CMAKE_CXX_FLAGS anyway for debug builds? If so this is redundant.


Seems like we ought to use the Globals locale date preference chose the date format rather that hard coded.


This looks a bit weird, I'd say we should just list them all here sorted alphabetically. We don't have that many contributors and even projects that do can keep this file up to date without significant effort :)


Awesome. Can you just add one more thing? A case with arrays with missing elements:
```ts
function baz3([ , z, , ]) { }
```


> put in another way, Context::complete() will delete the tick_event before Context::complete() returns. am i right?

This is a little tricky. In `shutdown()`, the `timer` thread is deleted. If the `timer` thread is deleted before `Objecter::tick()` is able to run. Then `tick_event` will not be deleted by `Context::complete()`. Seems like this is the case in 11183.

> and i'd suggest moving the tick_event out of the if block. as it should always be deleted and reset after cancel_event(), no matter it returns true or false.

Yep, this make sense.


Is this so hard to setup your IDE for using tabs?


The source code in all these files is the same. Rather than duplicating it, I would just combine this all into one file.


https://code.djangoproject.com/ticket/22394

this is the related ticket for your works. you could assign and have some idea then a PR will be good way to review.


Thanks for the translation! Is it finished, so that we can incorporate it into our own repository?


@larrybotha i actually did this in the current site I am working on :)


I don't think you need getExportsOfImportDeclaration. I would try to rephrase this to use getExportsOfModule, that way you do not have to expose getExportsOfImportDeclaration.


90693826-Central-cooling-coils-not-autosizing-to-correct-airflow-in-some-cases-#4810 (mjwitte) - x86_64-MacOS-10.9-clang: OK (1664 of 1669 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg)


for...of?


Added this comment to see the sync


Comment what it means to filter out exportStar?


test


I think I would rather call it getExports**for**ImportDeclaration


Lol github app: the new wechat :p

Yeah it was good, thanks for asking. Didn't do much, just went out with Jess's friends.


the only options i know of are btoa, which does not support unicode, and node's buffer.tostring, which obviously does not exist on cscript. if you know of a simpler way i would be happy to use it :)


as well


Howdy!


yup. this is padding. see: http://en.wikipedia.org/wiki/Base64#Padding


『注意：/bushu_cybend/cybend 文件中的cybend.com需要更改为自己的ip或域名地址』


closures work with both php 5.3 and 5.4 right?


We do use it, don't we? We use it if has the Module flag, and I would think external modules do have that flag, no?


I moved the functionality to a utility function and added a test in 245450ae9fb82cf08f93c1744900480b9f6b4c91.


:) when i wrote that i thought to myself Jason would make this comment. i do not know, either this or the other one would be error. i am fine with both. this way it was simpler to change in the emitter. but should be easy to do it the other way around as well.


Is this for performance?


3번째 실습과제


Why is it so imperative that mapToArray be called here? Can't this just return the SymbolTable, and the language service convert it into an array?


Sorry, my bad. My atom installation got corrupt. Although most plugins still worked, I also wasn't able to upgrade to a new version, and I had to manually remove all references to atom in AppData. I've also discovered literally thousands of temporary linter files with the extension ts in my AppData/temp folder, and deleted them as well. After reinstalling Atom, and atom-typescript (linter and autocomplete-plus), I got it working again.

Side note: After installing a subset of my previously installed packages, your plugin stopped working again. I'll try to discover what happens there and let you know.

Cheers, Erik

Sent from my Windows Phone

-----Original Message-----
From: "Basarat Ali Syed" <notifications@github.com>
Sent: 24/03/2015 08:20
To: "TypeStrong/atom-typescript" <atom-typescript@noreply.github.com>
Cc: "Erik Vullings" <erik.vullings@gmail.com>
Subject: Re: [atom-typescript] :memo: clarify `formatCodeOptions` (1380a83)

Also, I've noticed that there is no Intellisense support for internal
variables in a forEach, e.g. in below example, although r1 and r2's type
are well-defined (and shown in the tooltip), there is no Intellisense
support for r1.
I tried it. It works:

my source:
interface ILookupResult {
    name: string;
    score: number;
}

function mergeResults(result1: ILookupResult[], result2: ILookupResult[]):
    ILookupResult[] {
    var r: ILookupResult[] = [];
    result1.forEach((r1) => {
        result2.forEach((r2) => {
            r1.
        });
    });
    r = r.sort((a, b) => { return b.score - a.score; });
    return r;
}—
Reply to this email directly or view it on GitHub.


haha. nice catch!


@fangfangyang 这个修改并不大，只是把arc的参数暴露给drawCircle了而已。请问能否详细描述一下如何调用的这个方法呢？我感觉可能是参数问题，或者是没有用上Canvas renderer（走WebGL了）


Did'nt work as expected. Even code like

if (_x.ContainsKey(name))
{
    value = _x[name];
}

will create a warning "requires unproven: ContainsKey(key)".


You'll also need to update .gitignore


@ValeraS У тебя 3 исключающих коммента, я запутался.
Сформулируй в новом комменте, пожалуйста.


There was a lot of typing.... I got tired.... :hurtrealbad:


very nice. thank you.


As I said, we do not load beacons in the start. what the beacons mean is
totally under our discretion. we load nearby events first. if the user
selects a event we load the beacons for navigation.

On Wed, Mar 25, 2015, 11:58 Karthik Balakrishnan <notifications@github.com>
wrote:

> I don't understand why we need location data. Could you explain?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/karthikb351/map.a.ble-Android/commit/3d6701b522e6d85e280a7e1e3b2eca8f385f7496#commitcomment-10383057>
> .
>


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1142
success: http://build.servo.org/builders/linux2/builds/1142
success: http://build.servo.org/builders/android/builds/1176
success: http://build.servo.org/builders/mac1/builds/1355
success: http://build.servo.org/builders/mac2/builds/1358
success: http://build.servo.org/builders/gonk/builds/324


This is a problem since ding_place2book does not follow the same versioning scheme as other ding modules.

[v2.0.0 was released almost 3 years ago](https://github.com/ding2/ding_place2book/releases/tag/v2.0.0).


Ok, works now. by default only 3c3.a and 3c2.a are exported right now. since these definitations are based on genotype, will be easy to add more.


fast-forwarding master to auto = 8b5df113


If these are unused, feel free to remove them, rather than commenting them.


verions 0.2 not work, why?


saw approval from jdm
at https://github.com/saneyuki/servo/commit/39191daaed4d11045fcf1f0dbaa74cd2d721c253


merging saneyuki/servo/binding = 39191daa into auto


saneyuki/servo/binding = 39191daa merged ok, testing candidate = e77c4e2d


Hi Humans!

MikeMeeks here, I like Node.js and Coffeescript (that's what I'm made of!).
I've had tacos on the moon and find time far superior to Earth tacos.


And mention moon tacos


Good! Now we need:
- **IPolynomial** and its implementations for orders 1 and 2 that essentially will be just wrappers around Math.NET. This will replace Math.NET usage on line 42.
- **IElitePointSelector** and its implementations for orders 1 and 2. Also wrappers around Math.NET. Will be used on line 51.

Let's keep all these interfaces and their implementations in this file for now.


Xcode knows best.

:+1:


Oj, har tydligen glömt fixa på min stationära dator. Fixar ikväll.

—
Sent from Mailbox

On Wed, Mar 25, 2015 at 12:09 AM, Daniel Rapp <notifications@github.com>
wrote:

> @jcmandersson Grymt! Men massa indentering med 4-spaces här :'(.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jcmandersson/Operation/commit/c24ef3239c760c8c0b0ddee953ed6643c5803db4#commitcomment-10379497


Why


1. МирРез - лишний параметр.
2. передача мира на сервер два варианта:
  - `ОсновнойОбъект.Мир = Объект.мир;` и `Объект.Мир = ОсновнойОбъект.Мир;`
  - добавить параметр мир в метод `ОсновнойОбъект.ВыполнитьТест(..., Объект.Мир)`


ИМХО сохранение контекста между запусками не должно гарантироваться.
Зависимые тесты должны запускаться вместе.


Не, так не пойдет. В старых версиях не будет работать. ![screen](http://fs1.directupload.net/images/150325/ia5hlqgw.png)

"include" следует использовать только для новых скриптов, по крайней мере, пока в этом логе не будут только "1.3.1" (лог апдейтов)
![screen](http://fs2.directupload.net/images/150325/y3kt67nd.png)

И зачем вы удалили ```Contrib/Source/*.txt``` ?


why ;_;


А может тогда нужно при каждом запуске очищать и `Мир`?


ack, thx!


I didn't see SymbolTable being exposed anywhere in `services.ts` so I wanted to stay consistent.


make it private


This is more of a reminder for myself to ask @ahejlsberg about the appropriate uses more than it is anything else.


90022444-FewReleasePrepThings (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1164 of 1166 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.77%25-green.svg)


Sounds fine by me


This should address Ben's review comments


И ещё, должны ли миры для разных тестовых наборов различаться или могут быть общими?


Squashed from Art pull request.  Something that's been needed for a while @aethelwulffe


updated


`exports` is optional so it's possible you can get `undefined` back.


Also this should be `exportedSymbols`


Mention moon tacos


爱爱爱


No this had nothing to do with caching or browser. The JS code simple replaced all user images from the stream and not only this from the profile owner, before this commit.


I think the `, True` portion is wrong here.  If anything, it should be a default filename, but it probably should be None.


looks fine


merged.


Ooohh I see. Makes sense then.
On Mar 25, 2015 12:28 AM, "Andreas Strobel" <notifications@github.com>
wrote:

> No this had nothing to do with caching or browser. The JS code simple
> replaced all user images from the stream and not only this from the profile
> owner, before this commit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/humhub/humhub/commit/5c0ef3d68191ae2898dedf2e667fd23acee53f6c#commitcomment-10383562>
> .
>


I would like to keep the NotificationListenerService out of the bluetooth package. This should be independent from the transport technology. I would put it in a "notifications" package


HotFixPurchasedAirUnitTest (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1674 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Should be passed via HcsMessageInfo rather as bool. The message should automatically get displayed once this is done.


@wonzhq

> If the timer thread is deleted before Objecter::tick() is able to run.

i don't think it is the case. in `SafeTimer::timer_thread()`, the callback is called **right after** it is removed from the queue. and the thread func does **not** check for `stopping` after removing the callback. so the chances are that 1) the timer thread removes the callback 2) Objecter not able to cancel it 3) `complete()` gets called.

1. on timer side, `timer_thread()` removes the event from its queue when holding timer_lock, and it relinquishes this lock,
1. in shutdown(), it tries to cancel the time event after acquiring the timer_lock, but it fails to do so (this is the case where `cancel_event()` returns false, and i don't think we should delete tick_event), as this event is already removed. and rwlock is `unlock()`'ed. but `timer.shutdown()` is not called yet at this moment.
1. on timer side, and `callback.complete(0)` is called. then `tick()` waits for rwlock. and this lock is acquired, so `complete()` will delete called
1. back to the timer side, tick() acquires the rwlock, and `complete()` returns after deleting the timer_event.


A comment here stating that `True` means read from the default location would be helpful.


Always prefer the interface List instead of the implementation ArrayList


I faintly remember looking at this in the past and recall that a grep still showed places in the code that needed to be fixed. Recommend doing a grep for "genericname2" to ensure not missing stuff.


a lot of warnings building the static library like that: use of GNU ?: conditional expression extension, omitting middle operand [-Wgnu-conditional-omitted-operand]


This should probably be:

```python
help="Location of coverage config file "
"[NOSE_COVER_CONFIG_FILE]")
```

The README.txt is generated from this information.  You should probably drop your edit to README.txt or run `make readme` from the doc directory.


本地没有，改为从网络获取


This string should be localized


After much trouble it now works, exactly the same as Rayjax describes [in the last paragraph here at stackoverflow](http://stackoverflow.com/questions/23625615/unable-to-get-disqus-to-work-correctly-in-a-single-page-app), confusing me as well......


Missing space


I would not move this to bluetooth package. Let's move it to "notifications"


Например, @pumbaEO хотел юзать один контекст в разных тест.наборах. Мне эта схема с одним контекстом в разных тест.наборах пока не нравится.

По поводу разных тест.наборов - я специально добавил ИдентификаторКонтекста для возможности использования как совместно, так и раздельно. Пусть автор тестов решает, как будет юзать работу с контекстом. я ему дал необходимый инструментарий.


go for it (I am a bit clueless on this one, so up to you)


Works now. Thanks.


Same here, let's use "notifications" package, this should be independent from the bluetooth stuff


Cool, will see if i get the migration timestamp thing working


Agreed.


@eviltoylet I changed the search API to match original. I didn't go along with the highlight approach as it felt like a lot of code for a little thing. I can see it is compositionally better. It's enough for us to provide some highlighter with the library and let users build solutions matching their needs. :)


I don't get how component.build.fonts can be set when build is an array :-/ Can you help? :-)


I would also keep this out of the "bluetooth" package. I'm not sure where this would go... probably because this class is still far from being clear :)

Let's leave it in the top "nuntius" package for now.


Кстати, сбрасывается кеш самих обработок, но не контекст. ИМХО между перезапуском тестов в течение одной сессии браузера тестов контекст сохраняется и это хорошо. как раз удобно для итеративной разработки  тестов и доработки единичного теста из набора.


Prefer List instead of ArrayList


This feels like something that should not be public?


in gulp is 8080 not 8888


Even if LOL make me smile :) ...let's change this to:

```Log.d(TAG, "Notification from " + sbn.getPackageName() + " filtered.");```

And mind the spaces around "} else {"


Hmm so when we use `build` as an array, `build.scripts` disappear, right? That would mean changing the error message as well.


lgtm


You can remove my hardcoded stuff now that we have the real blacklisting working :)


90693826-Central-cooling-coils-not-autosizing-to-correct-airflow-in-some-cases-#4810 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1671 of 1675 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


Overseen that one. Please stop insulting people.

I recommend doing a whitespace-cleanup on all source files. Using tabs is archaic.


Я по этому первый комментарий и написал. Получается сохранение контекста внутри тестовой обработки, это не запланированное поведение и оно не гарантируется? А мир сохраняется всегда. То есть глобальные переменные тестовой обработки для сохранения контекста использовать неправильно, а нужно использовать `Мир`?


This is meant to be bluetooth independent (in fact I am working on the LAN patch to use TCP instead of bluetooth with this). So let's move it to the top "nuntius" package for now until we create a more fitting package


This is never used at the moment, you can remove from the patch.


@andyjmaclean: did you intentionally upgrade Blacklight here?

If you are just trying to update the styleguide gem, after changing the ref in Gemfile, use `bundle install`, not `bundle update`


I think we can accept the request as soon as you make the changes in the comments (or I can do them if you are busy)


> There are lots of private IP addresses used in testcases, etc...should/could they all be updated?

No, used not for host resolving.

Resolving of `10.0.0.0` returns sometimes `localhost` (local vm under NAT and openvz vps by provider, but in firm and labor nets unresolved host). And `192.0.2.0` was everywhere unresolved.


I first thought I do the same for the provisioning file argument as you did for the storage dir. But my initial test was wrong and using a provisioning file containing e.g. a `ä` actually didn't work with the `utf8()`changes.. The original code worked though, so I reverted my changes. I did not look into the details why the storage dir needs the `utf8()`conversion but loading the provisioning file fails when using it.

Feel free to add more fixes if you are still encountering issues with non-Latin1 characters in the provisioning file path.


Fixes #57


Hello,
Why removing gabc.lang ? I use it on a regular basis (putting it in /usr/share/gtksourceview-3.0/language-specs under debian) with gedit, and it does highlight code, making proofreading easier.


So this whole 'if' shouldn't be here. I can't find anywhere in the code base that `squid_verified_default` is used from in the config.py. So it looks to me that there was some confusion in the past about the difference between `squid_verification` and `squid_verified_default`. I think the one we want to keep is `squid_verification`.


@aethelwulffe Squashed version of Art's pull request


this check could be replaced with the following more understandable code
```
if TARGET_IPHONE_SIMULATOR == 1 {
```


Oh, sorry, I imagined it was only compatible with GtkSourceView 2... I'll put it back.


Hi, maybe my fork https://github.com/evgygor/logstash-output-influxdb/ can provide more flexibility in that cases?

From my README:
...This fork permits to create fields on the fly, according to fields names and datatypes that arrives to that output plugin.

I added 2 configuration paramters:
# This settings revokes the needs to use data_points and coerce_values configuration # to create appropriate insert to influxedb. Should be used with fields_to_skip configuration # This setting sets data points (column) names as field name from arrived to plugin event, # value for data points config :use_event_fields_for_data_points, :validate => :boolean, :default => true

# The array with keys to delete from future processing. # By the default event that arrived to the output plugin contains keys "@version", "@timestamp" # and can contains another fields like, for example, "command" that added by input plugin EXEC. # Of course we doesn't needs those fields to be processed and inserted to influxdb when configuration # use_event_fields_for_data_points is true. # We doesn't deletes the keys from event, we creates new Hash from event and after that, we deletes unwanted # keys...


@zzet так, не подглядывай )


@rexxars: Please have a look at this changeset and pull it into you branch if you don't have any beefs with it, so that @christeredvartsen can review this as well.


I would remove one Type from the name...


I think the ! can be dropped from these strings.  Seems to be adding 2 new search options.  Not really related to the genericval2 purpose


Need to add the .idea directory to your gitignore and also set it to be excluded from the project's source files in pycharm settings...this is to avoid problems when merging commits where we both have different pycharm settings. Let me know if you cant find it in the settings and I'll tell you where it is :smile:


saw approval from shino
at https://github.com/basho/yokozuna/commit/3601057f16b79dcc661ab060d17430103c0e857a


basho/yokozuna/bugfix/zl/proper-handling-of-assignment-stupid-zeeshan-tricks-are-for-kids = 3601057f merged ok, testing candidate = 007dadd4


merging basho/yokozuna/bugfix/zl/proper-handling-of-assignment-stupid-zeeshan-tricks-are-for-kids = 3601057f into borshop-integration-476-bugfix/zl/proper-handling-of-assignment-stupid-zeeshan-tricks-are-for-kids


rozluznijcie sie
sprawdzcie bledny plik ten ktory ja robilem jest tutaj
https://github.com/lbarulski/ImageStorage/blob/master/src/ImageStorage/Image/Transformation/WatermarkRand.php


ten byl edutowany 19 lut.


If you remove Bundler, you should clearly remove rubygems-bundler as well, because Bundler is not even installed.


The workflow I've tried to follow is based on [GitFlow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow), in short:
- bugfixes and maintenance is done in a support branch and once we collect more fixes to release, I collect all of them into ```hotfix/X.Y.Z``` branched off of the master, test and merge back to master and develop.
- features are developed in topic branch branched off of develop and released with next major release
It might be not ideal workflow, but it's one well structured that makes it no-brainer.

If your commits to master are fixes only, and no major new features, we may handle it this way, perhaps simpler than reverting:
1. Create new branch ```hotfix/3.2.3-vz``` branched off of master
2. Merge ```hotfix/3.2.3```, the one that I started, into ```hotfix/3.2.3-vz```, and publish the ```hotfix/3.2.3-vz```
3. We continue testing in ```hotfix/3.2.3-vz```
4. We release 3.2.3 from ```hotfix/3.2.3-vz```

I can stick to whatever you prefer.


I don't think the indent class should have been included here?


NameCriteria seems great but I won't add suffix Criteria as long as we don't need it.


1. в ОФ можно работать с глобальными переменными из модуля обработки, в УФ они уже бесполезны.
2. при перезапуске тестов тест.обработка всегда пересоздается, так что глобальные переменные нужно инициализировать заново, это можно сделать в ПередЗапускомТеста или ПередЗапускомТестовогоНабора (#395 сделаю сегодня/завтра). Для каких-то тестов это может быть неприемлемо.

Поэтому моя рекомендация: использовать работу с контекстом из юТест. Тогда серверные тесты очень легко перевести на УФ.


@Dimeranda, what if I add an existing name? This should clear all previous records. I thing we need more complex logic here.


Love it :+1:


@apaikan first test, a traditional "class level" test but still useful to start real worl examples.


@Imperadeiro98 @nixel2007 I left this string commented because I had translated only half of it. You can see that the end of the sentence is in English. (I haven't understood its meaning; maybe someone else will.) So put # back, plz


@Dimeranda, similar thing. If I put not existing username, this should say that "user is not in list yet". But now it causing an error in this case.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1143
success: http://build.servo.org/builders/linux2/builds/1143
success: http://build.servo.org/builders/android/builds/1177
success: http://build.servo.org/builders/mac1/builds/1356
success: http://build.servo.org/builders/mac2/builds/1359
success: http://build.servo.org/builders/gonk/builds/325


Sorry, I did not know and did not see that it brakes the OpenSSL build. Can you give me a helping hand to achieve enabled-if-supported condition with configure.ac?

Am 24. März 2015 22:54:57 MEZ, schrieb Daniel Stenberg <notifications@github.com>:
>I agree the memory clearing feature can be enabled by default, but I
>disagree with that then leading to configure to fail because the
>OpenSSL backend doesn't support it... So, I think it should be default
>if the backend supports it otherwise not.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/libssh2/libssh2/commit/22bd8d81d8fab956085e2079bf8c29872455ce59#commitcomment-10378222


@kbandla I thought if you do understood me correctly.. I was talking about some overhead if we (I) manage to create decorator which **additionally** to warning **suggests the modern method name** when the old one was called. In that case we (I) will go through all class properties and find the most suitable variant (s) or another solution would be to add warnings.warn() to every deprecated method which, I think, not the best idea. So that we can talk about some overhead in this case...
Generally, I believe that printing to stderr warning message is a good idea. It is a general practice and if a person wants to find out modern method name he should look into doc-ion.
Overall, **API remains the same for "right" users which don't use "private" methods directly.**


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1046


does the execution time really belong into the message? maybe it should be put into the metadata or logged somewhere else.


fast-forwarding master to auto = e77c4e2d


Yeah, I'll work on a fix!


Yep, works perfectly fine on PHP 5.3.


What is effect-node? Maybe animation-effect.


@benoitg  je comprends ce qui es fait ? on regarde la longueur du dom "el" ? pas sa valeur ?


nit, this was already here but we should not be using underscores in identifiers.


I thought we were throwing exceptions now when we encounter unexpected situtations?


We should localize this piece of text and use the plugin's textdomain `wpas` like so

```
__( 'User was deleted', 'wpas' );
```


These classes (`visible-lg` and `hidden-lg`) have different cutoffs than our usual mobile/nonmobile switch. With this change I can't see the topic on my portrait monitor (window is 1080px wide). I think we should switch that to the same cutoff.


Update `$max-font` on README please.


Cool. Want me to fix it in this one or in a follow up?


You are right, there is no inherent benefit of it. I just like to keep it explicit as much as possible that we are supporting/using the latest versions as much as possible. And the semver-range I see more as a 'backup' that takes away the need to immediately have update manually and push a new version yourself.


@flip4bytes Did you do a `stylus -u autoprefixer-stylus -w css/style.styl` to this? I'd imagine a lot more stuff would be changing in the style.css file than just those 2 values. $max-font is used in almost every sizing calculation.


r=jm


common.lua is now clean. I will make a PR later for the tabs


Should not be "Opening braces for classes MUST go on the next line"?


Is the ordering your preference or a standard?


nutoriously hard part of the code to get into!


> What is effect-node? Maybe animation-effect.

EffectFunction?


saw approval from jdm
at https://github.com/Ms2ger/servo/commit/07bdc9c885cdbbb2a113c9590bb3f190dfa3289c


merging Ms2ger/servo/wpt_20150317 = 07bdc9c8 into auto


Ms2ger/servo/wpt_20150317 = 07bdc9c8 merged ok, testing candidate = a0b6e152


this is wrong , please re do it.


These three specialisations are all the same. I guess that's because you can't do a disjunction in the DSL guards? But you could move the code that calls the Ruby helper into a helper method itself.

Also, note that you don't need to make the block explicit like you've done here and where you modified `zip_internal`, below. You could still do:

```java
return ruby(frame, "zip_internal(*others, &block)", "others", new RubyArray(getContext().getCoreLibrary().getArrayClass(), others, others.length), "block", proc);
```


it's about the following comparison "value < zero" in the unsigned case. With "const", gcc complains about it being always false.


sorry for the noise tonight - @chelmuth: please add to staging


fast-forwarding develop to borshop-integration-476-bugfix/zl/proper-handling-of-assignment-stupid-zeeshan-tricks-are-for-kids = 007dadd4


@artempartos молчу-молчу ^_^


update


The check for IS_DIRECTORY still checks the global dir, is that intentional ?


> If you have a normal effect that moves the spell to another zone, wouldn't that stop it from going to the graveyard normally since there is no more spell on the stack to put into the graveyard?

Yes it would stop it, because Spell.resolve checks that the spell object is still on the stack before it moves the card.
```
          if (game.getState().getZone(card.getMainCard().getId()) == Zone.STACK) {
                card.moveToZone(Zone.GRAVEYARD, ability.getSourceId(), game, false);
            }
```
Maybe it was designed this way to be more compliant to the 608.2k rule.
**_608.2k As the final part of an instant or sorcery spell’s resolution, the spell is put into its owner’s graveyard._**
But I also see no technical reason to do it this way instead of letting the last effect doing the move. Maybe if some effects are added to a spell (e.g. Splice) it's harder to guarantee that the move effect happens really last .


90179052-SetupEMSActuatorMissingDuplicates (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1148 of 1148 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.63%25-green.svg)


Because it's way simpler to write/read/edit smaller tests like these than to add editing as another factor.


short answer, no we can not remove it:

the thing is that `bundler` and `rubygems-bundler` do not depend on each other - so `rubygems-bundler` will not include `bundler` as dependency, but then some people will continue to use `bundler` and then `rubygems-bundler` helps RVM team to get rid of problem reports like:

> `rake` does not work in RVM

when in fact the problem is:

> I forgot to type `bundle exec rake`

this was significant (`10%+`) amount of tickets before `rubygems-bundler` was added as global gem.


Why check if mandate is not cancel instead of mandate is valid?
What if mandate is draft or expired ?


... And the failure doesn't affect stream or reader's state.


Ummm that's not what you had told me. You told me to set  the priority to an invalid number at start up and then check for the same number in GetPriority.


dfgdf


因为这是一个复杂的问题


Из этого следует, что не получиться реализовать замену скалярного значения массивом, не использовав при этом ключи:
```php
// Плохо
$original = array(1, 2);
$instance = ArrayMap::create($original);
$instance->map(function ($value, $key) {
    return array($value * 2);
});
$this->assertEquals(array(array(2), array(4)), $instance->getArray());
```

```php
// Хорошо
$original = array(1, 2);
$instance = ArrayMap::create($original);
$instance->map(function ($value, $key) {
    return array($key => array($value * 2));
});
$this->assertEquals(array(array(2), array(4)), $instance->getArray());
```


是我们想要Observer 在UI主线程中处理的结果


How abouting documenting this new option in ctrlp.txt as well?


Thanks @cornae I can't say I really understand it ;). I would love to hear an explanation by you in hangout when you have time.


Before this commit, each outlet in the kitbuilder had its own slide container, and because of this each outlet had its own scrollbar rendered. I moved the 'slide' div container to the main kit-builder route. This way the outlets dont load their own scrollbars. This made the animation look better because the scrollbar is no longer moving with the route animations.


Addressed https://github.com/whatwg/streams/commit/374ac78ba99082ca68e9d9d3fa93069f8f1c2ab8


修改天猫数据为0的情况


Yep, but only if you're adding new icons.


You should not instantiate implementation classes. Why do you need to call `new PhenoTipsPatient(patientDoc)` and can't you use [`patientRepository.getPatientById(.)`](https://github.com/phenotips/phenotips/blob/master/components/patient-data/api/src/main/java/org/phenotips/data/PatientRepository.java#L43) instead?


Is it worth noting that the stream will be closed in this case? (It depends on what you mean by "the stream was cancelled")


:cake: pulled


Don't depend on internal implementations, only on exposed APIs.


> As of c++11 static initialization is guaranteed thread safe.

Just FYI, magic statics (as microsoft calls them) are not in the visual c++ version we're using right now. So keep that mind when relying on them. I wouldn't change this particular case though, the code is pretty harmless at the moment and then new visual studio will land.


@SubJunk I think that the same should be done also for the Samsung-NotCD.conf


Wir könnten die Adresse en-/decodieren: folgendes Javascript
decodeURIComponent(atob("bWFpbHRvJTNBaW5mbyU0MGV4YW1wbGUuY29t"))
liefert z.B.
mailto:info@example.com

Erzeugt wird das Ganze z.B. in der JavaScript-Konsole (Crtl-Shift-J) mit
btoa(encodeURIComponent("mailto:info@example.com"))

Durch der Mitencoden von "mailto:" liefern wir dem Bot zusätzlich keinerlei Anhaltspunkte.


Static variables in headers are bad, very very bad.


Hi John!
Putting the recheck string in '' did not work for me with your code, python did not match "recheck my-ci-name" but " 'recheck my-ci-name' ". Does this work for you?
greets
Silvan


Ez nem jó. Kifejezetten azt kértem, hogy ne használj hozzá harmadik féltől származó dolgokat (Knockout, jQuery, stb). Majd eljutunk odáig is.

A következő megoldások valamelyikét kellett volna használnod:
 + A `window.onload`-ra definiálni egy függvényt, ami hozzárendeli az eseménykezelőket a html elemekhez.

        window.onload = function() {
            document.getElementById("magicButton").onclick = function() {
                magic();
            }
        }

 + vagy `DOMContentLoaded` eseményre megírni ugyanezt (ezt nem támogatja a (jól gondolod) IE<9, erre lehetett volna még valamilyen workaround-ot találni, de nem fontos).

Az esemény hozzárendelésére is több mód kínálkozik:
 + A fent ismertetett módon az elem `onclick` függvényeként definiálni az eseményt (ennek hátránya, hogy ha másik eseménykezelőt is szeretnél hozzáadni az elemhez, akkor le kell kezelned, hogy az előző eseménykezelőt ne írja felül.
 + Vagy használni a következő formulát:

        document.getElementById("magicButton").addEventListener("click", function() {
            magic();
        });

    Ennek az a hátránya, hogy IE 9-es előtti verzióiban nem működik (így értettem a böngészőfüggetlenséget...)
 + Az előző pontban megfogalmazott probléma kiküszöbölésére az IE saját `attachEvent` függvényének használata (feltételes elágazással megállapítva, hogy a böngésző melyiket támogatja):

        if(document.addEventListener) {
            document.getElementById("magicButton").addEventListener("click", function() {
                magic();
            });
        }
        else if(document.attachEvent) {
            document.getElementById("magicButton").attachEvent("click", function() {
                magic();
            });
        }


1: M100 needs more reviewers
1: M101 signature is missing


28:1: I100 Imports statements are in the wrong order. from invenio.utils.shell should be before from invenio.version


Don't instantiate `new EditAccessLevel`, use `@Inject @Named("edit") private AccessLevel editAccess;`


Good point! Please rename "techkey": "Add private deploy key."


Is a.fetch('suse', Hash.new).fetch('autoyast', Hash.new)['repos'] more idiomatic?


"the stream was cancelled, but uncleanly" or something?


So here you have a method that just wraps another method.
Couldn't you just use `this.getId();` directly?
What is this new method for?
Do you override it anywhere? Could there ever be a more legit sender object than the ID?

A "Sender Object" can also be a SenderEntity class instance if you look in the IdUtil.


Pass va_list by reference maybe?


AsyncTask也不会帮助你 -》AsyncTask并不能给你带来什么帮助

测试AsyncTask是很难的-》测试AsyncTask非常困难

这里是一篇关于获得成功的一些方法的帖子->这是一篇有关如何成功测试AsyncTask的帖子


I generally avoid `for ... in ...` loops, especially for objects that can be fairly large. Perhaps this can be converted to a `while` loop or a traditional `for` loop.

http://jsperf.com/fastest-array-loops-in-javascript/11


https://github.com/CyanogenMod/android_system_core/commit/92d5ea9c997964d5568688e817e9c7972aa2ab2e

@arco maybe we can fix backlight issue through healthd_charger huh?


有些句子不太通顺，改改就好了。辛苦了么么哒


Curly braces on new lines.


Вынес в отдельную задачу этот момент. Пока что пусть так работает.


@AtaZh if you understand russian - наличие "строительных" уровней и уровней-загадок особенно отделяет CC от жестоких игр класса ААА, которые отталкивают девушек.
nevertheless, this string will be removed from locale-file cause of rewriting teachers block.


gps test


Why do we need a health mixin? I'm not saying it's a bad idea.
But I have not had any use cases for such a Mixin myself I think.
Where and how are you going to use this personally?


Hi @gmr, I am trying to get a better handle on the implementation of `SelectConnection`, so I am hoping to get some help with these questions:

1. With a name like `_flush_outbound` it sounds like it was intended to flush all outbound data, however control might eventually end up in `BaseConnection._handle_write` that attempts to send only the first frame from `outbound_buffer`, but not the subsequent frames.
2. If it's not going to flush everything, what is the purpose of calling `self.ioloop.poller.poll(write_only=True)` here at all? Won't IOLoop/poller do this anyway, after control leaves `_send_frame` or `_send_message` and lands in the `while self.open` loop of `*Poller.start()`?

Thank you for your patience,
Vitaly


Don't instantiate `new DefaultPatientAccess`, do:

```
PatientAccess patientAccess = permissionsManager.getPatientAccess(patientRepository.getPatientById(patientId));


Addressed https://github.com/whatwg/streams/commit/809afb717c7780651314c89c77acdc4089999d22


Just found your github profile :)

Some quick remarks on your work so far that you may (or not) take into account :
- overall very nice start :)
- might need to check your settings about tabs/spaces as it looks slightly different than default m64p
- prefer memset over ZeroMemory because of portability
- instead of modifying the emulate_game_controller_via_input_plugin which is reserved for input plugin compatibility, you should write your own network "input backend" (you could put that in the network directory), and setup the callbacks/user_data appropriately in main.c. All you need to implement is one callback is_connected (which tells the core if your controller is connected and which pak it contains) and one callback get_input (which tells the core what buttons are pressed, and joystick values).

Hope to see more good stuff :)


Can you remove the pin... to be just length, label and validatedStatus?


`value` -> the fulfillment value's `value`


coucou!!


super(ReviewBot.ReviewBot, self).__init__(*args, **kwargs) ?


ditto


Ясно, учту.


> uncleanly

Done https://github.com/whatwg/streams/commit/3102eff0fcb712ad4bc3cbf05f624c2997836613


Hej ni kan inte ha en main metod här ni behöver lägga allt i konstruktören för e J panel men det vet ni kanske redan.


No it wont, The cpu_percent has to be between 5 to 80


Fixes #33


But then you're giving out whether quick unlock is enabled or not; effectively giving knowledge to someone, who picked up your device, that they can bruteforce the PIN without ever being locked out.


Постараюсь. Есть такой момент, что иногда подмечаешь некоторые мелкие косяки во время работы над какой-то фичей, и понимаешь, что если сейчас не исправишь, то потом забудется; и хочется сразу исправить) Попробую отмечать где-то проблемные моменты, а потом скопом исправлять в отдельном коммите.


Can you let the random port directive? I usually run this container along side a service discovery container.


在我们的Android在线教育社区 Big Nerd Ranch中，我们在 Android bootcamp 的课程中一直坚持使用Fragment进行开发是正确的，尤其是对初学者（尤其是对于初学者来说），此外，我们在我们的咨询项目中广泛地使用了Fragment


test


继续 issue #3  应该不用那么暴力的删除这两个属性


Remove the spacing.


进入 Flow 和 Mortar


1 trailing blank lines detected.


Use a guard clause instead of wrapping the code inside a conditional expression.


Done https://github.com/whatwg/streams/commit/09698a410bfd984e9edbb327d9f1e8b48037389b


Done


os.Getpid() is int type. so it may be "%d"


Please fix the style here.


Just an idea... maybe ?
"Jasper is on the team since 2012" -> "Jasper joined the team in 2012"


"Better deref than sorry".


why?


Ja det blev fel där, vi har koll på det.


В текущей версии уже исправлено.


@valib for sure. I want to convert all of them


Can  you put an XML-formatted comment for us?  It's a bit easier if you do it as you add or change things, since you know best the purpose of your change.


as I got it the `-z noexecstack` is understood by gcc although it _should_ be `-Wl,-z,noexecstack` (since its a linker flag). Why this trickery, why not change it once and for all into `-Wl,-z,noexecstack`?


newView is not defined.