1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
30:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. import cgi should be before import time
31:1: E402 module level import not at top of file
32:1: I201 Missing newline before sections or imports.
32:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL
33:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
33:1: I201 Missing newline before sections or imports.
33:1: E402 module level import not at top of file
34:28: E126 continuation line over-indented for hanging indent
39:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, page_not_authorized
39:1: E402 module level import not at top of file
40:29: E126 continuation line over-indented for hanging indent
41:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly
41:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.legacy.webpage
42:1: E402 module level import not at top of file
43:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, get_fieldvalues, guess_primary_collection_of_a_record, record_exists
43:1: E402 module level import not at top of file
44:6: E126 continuation line over-indented for hanging indent
47:1: I101 Imported names are in the wrong order. Should be make_canonical_urlargd, redirect_to_url
47:1: E402 module level import not at top of file
48:30: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
49:1: E402 module level import not at top of file
50:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
50:1: E402 module level import not at top of file
51:1: E402 module level import not at top of file
52:1: E402 module level import not at top of file
53:1: E402 module level import not at top of file
54:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.access.mailcookie
54:1: E402 module level import not at top of file
56:1: I100 Imports statements are in the wrong order. import invenio.legacy.bibcirculation.db_layer should be before import invenio.legacy.template
56:1: E402 module level import not at top of file
57:1: E402 module level import not at top of file
58:1: I101 Imported names are in the wrong order. Should be ill_register_request, ill_register_request_with_recid, ill_request_with_recid, perform_book_proposal_send, perform_borrower_loans, perform_get_holdings_information, perform_loanshistoricaloverview, perform_new_request, perform_new_request_send
58:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.api should be before from invenio.legacy.bibcirculation.utils
58:1: E402 module level import not at top of file
59:36: E126 continuation line over-indented for hanging indent
67:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.adminlib should be before from invenio.legacy.bibcirculation.api
67:1: E402 module level import not at top of file
68:44: E126 continuation line over-indented for hanging indent
69:1: I101 Imported names are in the wrong order. Should be AMZ_ACQUISITION_IDENTIFIER_TAG, CFG_BIBCIRCULATION_ACQ_STATUS_NEW, CFG_BIBCIRCULATION_ILLS_EMAIL, CFG_BIBCIRCULATION_ILL_STATUS_NEW
69:1: E402 module level import not at top of file
70:43: E126 continuation line over-indented for hanging indent
74:1: E402 module level import not at top of file
75:1: E731 do not assign a lambda expression, use a def
82:1: E302 expected 2 blank lines, found 1
82: D203 Expected 1 blank line *before* class docstring, found 0
87: D102 Docstring missing
90: D400 First line should end with '.', not 't'
90: D208 Docstring is over-indented
90: D200 One-line docstring should not occupy 3 lines
97: D401 First line should be imperative: 'Display', not 'Displays'
97: D202 No blank lines allowed *after* method docstring, found 1
97: D400 First line should end with '.', not 'r'
97: D205 Blank line missing between one-line summary and description
112:70: E502 the backslash is redundant between brackets
119:30: E203 whitespace before ':'
121:25: E203 whitespace before ':'
122:21: E126 continuation line over-indented for hanging indent
128:52: E502 the backslash is redundant between brackets
129:44: E251 unexpected spaces around keyword / parameter equals
129:46: E251 unexpected spaces around keyword / parameter equals
138:26: E251 unexpected spaces around keyword / parameter equals
138:34: E251 unexpected spaces around keyword / parameter equals
138:26: E221 multiple spaces before operator
139:25: E251 unexpected spaces around keyword / parameter equals
139:34: E251 unexpected spaces around keyword / parameter equals
139:25: E221 multiple spaces before operator
140:24: E251 unexpected spaces around keyword / parameter equals
140:34: E251 unexpected spaces around keyword / parameter equals
140:24: E221 multiple spaces before operator
141:32: E251 unexpected spaces around keyword / parameter equals
141:34: E251 unexpected spaces around keyword / parameter equals
142:24: E251 unexpected spaces around keyword / parameter equals
142:34: E251 unexpected spaces around keyword / parameter equals
142:24: E221 multiple spaces before operator
143:29: E251 unexpected spaces around keyword / parameter equals
143:34: E251 unexpected spaces around keyword / parameter equals
143:29: E221 multiple spaces before operator
144:30: E251 unexpected spaces around keyword / parameter equals
144:34: E251 unexpected spaces around keyword / parameter equals
144:30: E221 multiple spaces before operator
147: D202 No blank lines allowed *after* method docstring, found 1
147: D200 One-line docstring should not occupy 3 lines
157:86: E502 the backslash is redundant between brackets
164:30: E203 whitespace before ':'
167:25: E203 whitespace before ':'
173:52: E502 the backslash is redundant between brackets
174:29: E128 continuation line under-indented for visual indent
174:33: E251 unexpected spaces around keyword / parameter equals
174:35: E251 unexpected spaces around keyword / parameter equals
179:26: E251 unexpected spaces around keyword / parameter equals
179:34: E251 unexpected spaces around keyword / parameter equals
179:26: E221 multiple spaces before operator
180:25: E251 unexpected spaces around keyword / parameter equals
180:34: E251 unexpected spaces around keyword / parameter equals
180:25: E221 multiple spaces before operator
181:24: E251 unexpected spaces around keyword / parameter equals
181:34: E251 unexpected spaces around keyword / parameter equals
181:24: E221 multiple spaces before operator
182:32: E251 unexpected spaces around keyword / parameter equals
182:34: E251 unexpected spaces around keyword / parameter equals
183:24: E251 unexpected spaces around keyword / parameter equals
183:34: E251 unexpected spaces around keyword / parameter equals
183:24: E221 multiple spaces before operator
184:29: E251 unexpected spaces around keyword / parameter equals
184:34: E251 unexpected spaces around keyword / parameter equals
184:29: E221 multiple spaces before operator
185:30: E251 unexpected spaces around keyword / parameter equals
185:34: E251 unexpected spaces around keyword / parameter equals
185:30: E221 multiple spaces before operator
189: D203 Expected 1 blank line *before* class docstring, found 0
189: D204 Expected 1 blank line *after* class docstring, found 2
193:5: E303 too many blank lines (2)
194:37: E231 missing whitespace after ','
199: D290 White spaces around docstring should be trimmed.
199: D400 First line should end with '.', not 't'
199: D200 One-line docstring should not occupy 2 lines
203:59: E128 continuation line under-indented for visual indent
205: D401 First line should be imperative: 'Display', not 'Displays'
205: D202 No blank lines allowed *after* method docstring, found 1
205: D400 First line should end with '.', not 'r'
205: D205 Blank line missing between one-line summary and description
230:73: E502 the backslash is redundant between brackets
237:30: E203 whitespace before ':'
240:25: E203 whitespace before ':'
246:52: E502 the backslash is redundant between brackets
247:33: E128 continuation line under-indented for visual indent
247:37: E251 unexpected spaces around keyword / parameter equals
247:39: E251 unexpected spaces around keyword / parameter equals
250:25: E128 continuation line under-indented for visual indent
251:25: E126 continuation line over-indented for hanging indent
265:26: E251 unexpected spaces around keyword / parameter equals
265:34: E251 unexpected spaces around keyword / parameter equals
265:26: E221 multiple spaces before operator
266:25: E251 unexpected spaces around keyword / parameter equals
266:34: E251 unexpected spaces around keyword / parameter equals
266:25: E221 multiple spaces before operator
267:24: E251 unexpected spaces around keyword / parameter equals
267:34: E251 unexpected spaces around keyword / parameter equals
267:24: E221 multiple spaces before operator
268:32: E251 unexpected spaces around keyword / parameter equals
268:34: E251 unexpected spaces around keyword / parameter equals
269:24: E251 unexpected spaces around keyword / parameter equals
269:34: E251 unexpected spaces around keyword / parameter equals
269:24: E221 multiple spaces before operator
270:29: E251 unexpected spaces around keyword / parameter equals
270:34: E251 unexpected spaces around keyword / parameter equals
270:29: E221 multiple spaces before operator
271:30: E251 unexpected spaces around keyword / parameter equals
271:34: E251 unexpected spaces around keyword / parameter equals
271:30: E221 multiple spaces before operator
273: D401 First line should be imperative: 'Display', not 'Displays'
273: D202 No blank lines allowed *after* method docstring, found 1
273: D400 First line should end with '.', not 'r'
273: D205 Blank line missing between one-line summary and description
285:75: E502 the backslash is redundant between brackets
292:30: E203 whitespace before ':'
295:25: E203 whitespace before ':'
301:52: E502 the backslash is redundant between brackets
302:44: E251 unexpected spaces around keyword / parameter equals
302:46: E251 unexpected spaces around keyword / parameter equals
304:9: E266 too many leading '#' for block comment
311:26: E251 unexpected spaces around keyword / parameter equals
311:34: E251 unexpected spaces around keyword / parameter equals
311:26: E221 multiple spaces before operator
312:25: E251 unexpected spaces around keyword / parameter equals
312:34: E251 unexpected spaces around keyword / parameter equals
312:25: E221 multiple spaces before operator
313:24: E251 unexpected spaces around keyword / parameter equals
313:34: E251 unexpected spaces around keyword / parameter equals
313:24: E221 multiple spaces before operator
314:32: E251 unexpected spaces around keyword / parameter equals
314:34: E251 unexpected spaces around keyword / parameter equals
315:24: E251 unexpected spaces around keyword / parameter equals
315:34: E251 unexpected spaces around keyword / parameter equals
315:24: E221 multiple spaces before operator
316:29: E251 unexpected spaces around keyword / parameter equals
316:34: E251 unexpected spaces around keyword / parameter equals
316:29: E221 multiple spaces before operator
317:30: E251 unexpected spaces around keyword / parameter equals
317:34: E251 unexpected spaces around keyword / parameter equals
317:30: E221 multiple spaces before operator
319: D401 First line should be imperative: 'Display', not 'Displays'
319: D202 No blank lines allowed *after* method docstring, found 1
319: D400 First line should end with '.', not 'r'
319: D205 Blank line missing between one-line summary and description
327:13: E128 continuation line under-indented for visual indent
330:76: E231 missing whitespace after ','
357:22: E222 multiple spaces after operator
370:75: E502 the backslash is redundant between brackets
377:30: E203 whitespace before ':'
380:25: E203 whitespace before ':'
386:52: E502 the backslash is redundant between brackets
387:44: E251 unexpected spaces around keyword / parameter equals
387:46: E251 unexpected spaces around keyword / parameter equals
405:41: E126 continuation line over-indented for hanging indent
410:26: E251 unexpected spaces around keyword / parameter equals
410:34: E251 unexpected spaces around keyword / parameter equals
410:26: E221 multiple spaces before operator
411:25: E251 unexpected spaces around keyword / parameter equals
411:34: E251 unexpected spaces around keyword / parameter equals
411:25: E221 multiple spaces before operator
412:24: E251 unexpected spaces around keyword / parameter equals
412:34: E251 unexpected spaces around keyword / parameter equals
412:24: E221 multiple spaces before operator
413:32: E251 unexpected spaces around keyword / parameter equals
413:34: E251 unexpected spaces around keyword / parameter equals
414:24: E251 unexpected spaces around keyword / parameter equals
414:34: E251 unexpected spaces around keyword / parameter equals
414:24: E221 multiple spaces before operator
415:29: E251 unexpected spaces around keyword / parameter equals
415:34: E251 unexpected spaces around keyword / parameter equals
415:29: E221 multiple spaces before operator
416:30: E251 unexpected spaces around keyword / parameter equals
416:34: E251 unexpected spaces around keyword / parameter equals
416:30: E221 multiple spaces before operator
418: D401 First line should be imperative: 'Display', not 'Displays'
418: D202 No blank lines allowed *after* method docstring, found 1
418: D400 First line should end with '.', not 'r'
418: D205 Blank line missing between one-line summary and description
426:13: E128 continuation line under-indented for visual indent
454:75: E502 the backslash is redundant between brackets
461:30: E203 whitespace before ':'
464:25: E203 whitespace before ':'
470:52: E502 the backslash is redundant between brackets
471:44: E251 unexpected spaces around keyword / parameter equals
471:46: E251 unexpected spaces around keyword / parameter equals
474:52: E203 whitespace before ':'
475:48: E203 whitespace before ':'
481:9: E266 too many leading '#' for block comment
493:26: E251 unexpected spaces around keyword / parameter equals
493:34: E251 unexpected spaces around keyword / parameter equals
493:26: E221 multiple spaces before operator
494:25: E251 unexpected spaces around keyword / parameter equals
494:34: E251 unexpected spaces around keyword / parameter equals
494:25: E221 multiple spaces before operator
495:24: E251 unexpected spaces around keyword / parameter equals
495:34: E251 unexpected spaces around keyword / parameter equals
495:24: E221 multiple spaces before operator
496:32: E251 unexpected spaces around keyword / parameter equals
496:34: E251 unexpected spaces around keyword / parameter equals
497:24: E251 unexpected spaces around keyword / parameter equals
497:34: E251 unexpected spaces around keyword / parameter equals
497:24: E221 multiple spaces before operator
498:29: E251 unexpected spaces around keyword / parameter equals
498:34: E251 unexpected spaces around keyword / parameter equals
498:29: E221 multiple spaces before operator
499:30: E251 unexpected spaces around keyword / parameter equals
499:34: E251 unexpected spaces around keyword / parameter equals
499:30: E221 multiple spaces before operator
501: D401 First line should be imperative: 'Display', not 'Displays'
501: D202 No blank lines allowed *after* method docstring, found 1
501: D400 First line should end with '.', not 'r'
501: D205 Blank line missing between one-line summary and description
513:78: E502 the backslash is redundant between brackets
520:30: E203 whitespace before ':'
523:25: E203 whitespace before ':'
529:52: E502 the backslash is redundant between brackets
530:44: E251 unexpected spaces around keyword / parameter equals
530:46: E251 unexpected spaces around keyword / parameter equals
532:9: E266 too many leading '#' for block comment
539:26: E251 unexpected spaces around keyword / parameter equals
539:34: E251 unexpected spaces around keyword / parameter equals
539:26: E221 multiple spaces before operator
540:25: E251 unexpected spaces around keyword / parameter equals
540:34: E251 unexpected spaces around keyword / parameter equals
540:25: E221 multiple spaces before operator
541:24: E251 unexpected spaces around keyword / parameter equals
541:34: E251 unexpected spaces around keyword / parameter equals
541:24: E221 multiple spaces before operator
542:32: E251 unexpected spaces around keyword / parameter equals
542:34: E251 unexpected spaces around keyword / parameter equals
543:24: E251 unexpected spaces around keyword / parameter equals
543:34: E251 unexpected spaces around keyword / parameter equals
543:24: E221 multiple spaces before operator
544:29: E251 unexpected spaces around keyword / parameter equals
544:34: E251 unexpected spaces around keyword / parameter equals
544:29: E221 multiple spaces before operator
545:30: E251 unexpected spaces around keyword / parameter equals
545:34: E251 unexpected spaces around keyword / parameter equals
545:30: E221 multiple spaces before operator
547: D401 First line should be imperative: 'Display', not 'Displays'
547: D202 No blank lines allowed *after* method docstring, found 1
547: D400 First line should end with '.', not 'r'
547: D205 Blank line missing between one-line summary and description
555:13: E128 continuation line under-indented for visual indent
565:78: E502 the backslash is redundant between brackets
572:30: E203 whitespace before ':'
575:25: E203 whitespace before ':'
581:52: E502 the backslash is redundant between brackets
582:33: E128 continuation line under-indented for visual indent
582:37: E251 unexpected spaces around keyword / parameter equals
582:39: E251 unexpected spaces around keyword / parameter equals
593:17: E128 continuation line under-indented for visual indent
594:17: E128 continuation line under-indented for visual indent
594:53: E203 whitespace before ':'
595:17: E128 continuation line under-indented for visual indent
595:38: E203 whitespace before ':'
596:17: E128 continuation line under-indented for visual indent
596:61: E202 whitespace before '}'
598:13: E266 too many leading '#' for block comment
600:37: E128 continuation line under-indented for visual indent
601:37: E126 continuation line over-indented for hanging indent
613:26: E251 unexpected spaces around keyword / parameter equals
613:34: E251 unexpected spaces around keyword / parameter equals
613:26: E221 multiple spaces before operator
614:25: E251 unexpected spaces around keyword / parameter equals
614:34: E251 unexpected spaces around keyword / parameter equals
614:25: E221 multiple spaces before operator
615:24: E251 unexpected spaces around keyword / parameter equals
615:34: E251 unexpected spaces around keyword / parameter equals
615:24: E221 multiple spaces before operator
616:32: E251 unexpected spaces around keyword / parameter equals
616:34: E251 unexpected spaces around keyword / parameter equals
617:24: E251 unexpected spaces around keyword / parameter equals
617:34: E251 unexpected spaces around keyword / parameter equals
617:24: E221 multiple spaces before operator
618:29: E251 unexpected spaces around keyword / parameter equals
618:34: E251 unexpected spaces around keyword / parameter equals
618:29: E221 multiple spaces before operator
619:30: E251 unexpected spaces around keyword / parameter equals
619:34: E251 unexpected spaces around keyword / parameter equals
619:30: E221 multiple spaces before operator
621: D102 Docstring missing
624:17: E128 continuation line under-indented for visual indent
664:79: E502 the backslash is redundant between brackets
671:30: E203 whitespace before ':'
674:25: E203 whitespace before ':'
680:52: E502 the backslash is redundant between brackets
681:33: E128 continuation line under-indented for visual indent
681:37: E251 unexpected spaces around keyword / parameter equals
681:39: E251 unexpected spaces around keyword / parameter equals
683:9: E266 too many leading '#' for block comment
690:55: E128 continuation line under-indented for visual indent
692:26: E251 unexpected spaces around keyword / parameter equals
692:34: E251 unexpected spaces around keyword / parameter equals
692:26: E221 multiple spaces before operator
693:25: E251 unexpected spaces around keyword / parameter equals
693:34: E251 unexpected spaces around keyword / parameter equals
693:25: E221 multiple spaces before operator
694:24: E251 unexpected spaces around keyword / parameter equals
694:34: E251 unexpected spaces around keyword / parameter equals
694:24: E221 multiple spaces before operator
695:32: E251 unexpected spaces around keyword / parameter equals
695:34: E251 unexpected spaces around keyword / parameter equals
696:24: E251 unexpected spaces around keyword / parameter equals
696:34: E251 unexpected spaces around keyword / parameter equals
696:24: E221 multiple spaces before operator
697:29: E251 unexpected spaces around keyword / parameter equals
697:34: E251 unexpected spaces around keyword / parameter equals
697:29: E221 multiple spaces before operator
698:30: E251 unexpected spaces around keyword / parameter equals
698:34: E251 unexpected spaces around keyword / parameter equals
698:30: E221 multiple spaces before operator
700: D102 Docstring missing
703:17: E128 continuation line under-indented for visual indent
743:79: E502 the backslash is redundant between brackets
750:30: E203 whitespace before ':'
753:25: E203 whitespace before ':'
759:52: E502 the backslash is redundant between brackets
760:33: E128 continuation line under-indented for visual indent
760:37: E251 unexpected spaces around keyword / parameter equals
760:39: E251 unexpected spaces around keyword / parameter equals
769:66: E128 continuation line under-indented for visual indent
776:60: E203 whitespace before ':'
777:56: E203 whitespace before ':'
781:13: E303 too many blank lines (2)
784:55: E126 continuation line over-indented for hanging indent
800:32: E251 unexpected spaces around keyword / parameter equals
800:34: E251 unexpected spaces around keyword / parameter equals
801:30: E251 unexpected spaces around keyword / parameter equals
801:34: E251 unexpected spaces around keyword / parameter equals
801:30: E221 multiple spaces before operator
802:31: E251 unexpected spaces around keyword / parameter equals
802:34: E251 unexpected spaces around keyword / parameter equals
802:31: E221 multiple spaces before operator
803:30: E251 unexpected spaces around keyword / parameter equals
803:32: E251 unexpected spaces around keyword / parameter equals
803:43: E251 unexpected spaces around keyword / parameter equals
803:45: E251 unexpected spaces around keyword / parameter equals
804:31: E251 unexpected spaces around keyword / parameter equals
804:34: E251 unexpected spaces around keyword / parameter equals
804:31: E221 multiple spaces before operator
807:23: E124 closing bracket does not match visual indentation
816:61: E502 the backslash is redundant between brackets
817:41: E127 continuation line over-indented for visual indent
817:105: E502 the backslash is redundant between brackets
822: D203 Expected 1 blank line *before* class docstring, found 0
829: D102 Docstring missing
833:5: E303 too many blank lines (2)
833: D401 First line should be imperative: 'Redirect', not 'Redirects'
833: D202 No blank lines allowed *after* method docstring, found 1
833: D400 First line should end with '.', not 'n'
833: D200 One-line docstring should not occupy 3 lines
840: D202 No blank lines allowed *after* method docstring, found 1
840: D200 One-line docstring should not occupy 3 lines
848:39: E203 whitespace before ':'
866:30: E251 unexpected spaces around keyword / parameter equals
866:32: E251 unexpected spaces around keyword / parameter equals
867:37: E251 unexpected spaces around keyword / parameter equals
867:39: E251 unexpected spaces around keyword / parameter equals
868:29: E251 unexpected spaces around keyword / parameter equals
868:31: E251 unexpected spaces around keyword / parameter equals
869:36: E251 unexpected spaces around keyword / parameter equals
869:38: E251 unexpected spaces around keyword / parameter equals
870:33: E251 unexpected spaces around keyword / parameter equals
870:35: E251 unexpected spaces around keyword / parameter equals
871:28: E251 unexpected spaces around keyword / parameter equals
871:30: E251 unexpected spaces around keyword / parameter equals
872:33: E251 unexpected spaces around keyword / parameter equals
872:35: E251 unexpected spaces around keyword / parameter equals
873:28: E251 unexpected spaces around keyword / parameter equals
873:30: E251 unexpected spaces around keyword / parameter equals
890:33: E128 continuation line under-indented for visual indent
892:21: E127 continuation line over-indented for visual indent
893:33: E128 continuation line under-indented for visual indent
899:9: E303 too many blank lines (2)
899:59: E502 the backslash is redundant between brackets
900:21: E126 continuation line over-indented for hanging indent
901:21: E126 continuation line over-indented for hanging indent
907:51: E502 the backslash is redundant between brackets
908:105: E502 the backslash is redundant between brackets
910:53: E502 the backslash is redundant between brackets
922:71: E225 missing whitespace around operator
931:44: E251 unexpected spaces around keyword / parameter equals
931:46: E251 unexpected spaces around keyword / parameter equals
935:31: E127 continuation line over-indented for visual indent
936:31: E127 continuation line over-indented for visual indent
937:31: E127 continuation line over-indented for visual indent
938:31: E127 continuation line over-indented for visual indent
944:5: E303 too many blank lines (2)
944: D200 One-line docstring should not occupy 3 lines
950:9: F841 local variable '_' is assigned to but never used
955:49: E251 unexpected spaces around keyword / parameter equals
955:51: E251 unexpected spaces around keyword / parameter equals
960:21: E131 continuation line unaligned for hanging indent
961:17: E122 continuation line missing indentation or outdented
961:26: E203 whitespace before ':'
966:17: E122 continuation line missing indentation or outdented
966:21: E203 whitespace before ':'
971:86: E203 whitespace before ':'
973:22: E127 continuation line over-indented for visual indent
973:68: E203 whitespace before ':'
975:45: E124 closing bracket does not match visual indentation
978:52: E502 the backslash is redundant between brackets
979:17: E128 continuation line under-indented for visual indent
979:21: E251 unexpected spaces around keyword / parameter equals
979:23: E251 unexpected spaces around keyword / parameter equals
997:51: E502 the backslash is redundant between brackets
998:105: E502 the backslash is redundant between brackets
1000:53: E502 the backslash is redundant between brackets
1012:71: E225 missing whitespace around operator
1021:44: E251 unexpected spaces around keyword / parameter equals
1021:46: E251 unexpected spaces around keyword / parameter equals
1025:31: E127 continuation line over-indented for visual indent
1026:31: E127 continuation line over-indented for visual indent
1027:31: E127 continuation line over-indented for visual indent
1028:31: E127 continuation line over-indented for visual indent
1030: D400 First line should end with '.', not ','
1030: D205 Blank line missing between one-line summary and description
1043:9: F841 local variable '_' is assigned to but never used
1048:49: E251 unexpected spaces around keyword / parameter equals
1048:51: E251 unexpected spaces around keyword / parameter equals
1053:21: E131 continuation line unaligned for hanging indent
1054:17: E122 continuation line missing indentation or outdented
1054:26: E203 whitespace before ':'
1059:17: E122 continuation line missing indentation or outdented
1059:21: E203 whitespace before ':'
1064:86: E203 whitespace before ':'
1066:22: E127 continuation line over-indented for visual indent
1066:95: E502 the backslash is redundant between brackets
1066:68: E203 whitespace before ':'
1066:92: E203 whitespace before ':'
1067:17: E128 continuation line under-indented for visual indent
1070:52: E502 the backslash is redundant between brackets
1071:17: E128 continuation line under-indented for visual indent
1071:21: E251 unexpected spaces around keyword / parameter equals
1071:23: E251 unexpected spaces around keyword / parameter equals
1098:51: E502 the backslash is redundant between brackets
1099:105: E502 the backslash is redundant between brackets
1101:53: E502 the backslash is redundant between brackets
1113:71: E225 missing whitespace around operator
1125:31: E127 continuation line over-indented for visual indent
1126:31: E127 continuation line over-indented for visual indent
1127:31: E127 continuation line over-indented for visual indent
1128:31: E127 continuation line over-indented for visual indent
1129:31: E128 continuation line under-indented for visual indent
1132:5: E303 too many blank lines (2)
1132: D202 No blank lines allowed *after* method docstring, found 1
1132: D200 One-line docstring should not occupy 3 lines
1139:9: F841 local variable '_' is assigned to but never used
1147:49: E251 unexpected spaces around keyword / parameter equals
1147:51: E251 unexpected spaces around keyword / parameter equals
1152:21: E131 continuation line unaligned for hanging indent
1153:17: E122 continuation line missing indentation or outdented
1153:26: E203 whitespace before ':'
1158:17: E122 continuation line missing indentation or outdented
1158:21: E203 whitespace before ':'
1161:9: E303 too many blank lines (2)
1164:86: E203 whitespace before ':'
1166:22: E127 continuation line over-indented for visual indent
1166:95: E502 the backslash is redundant between brackets
1166:68: E203 whitespace before ':'
1166:92: E203 whitespace before ':'
1167:17: E128 continuation line under-indented for visual indent
1170:52: E502 the backslash is redundant between brackets
1171:17: E128 continuation line under-indented for visual indent
1171:21: E251 unexpected spaces around keyword / parameter equals
1171:23: E251 unexpected spaces around keyword / parameter equals
1175:9: E303 too many blank lines (3)
1176:53: E127 continuation line over-indented for visual indent
1177:53: E127 continuation line over-indented for visual indent
1183:51: E502 the backslash is redundant between brackets
1184:105: E502 the backslash is redundant between brackets
1186:53: E502 the backslash is redundant between brackets
1198:71: E225 missing whitespace around operator
1207:44: E251 unexpected spaces around keyword / parameter equals
1207:46: E251 unexpected spaces around keyword / parameter equals
1211:31: E127 continuation line over-indented for visual indent
1212:31: E127 continuation line over-indented for visual indent
1213:31: E127 continuation line over-indented for visual indent
1214:31: E127 continuation line over-indented for visual indent
1216: D202 No blank lines allowed *after* method docstring, found 1
1216: D200 One-line docstring should not occupy 3 lines
1229:9: F841 local variable '_' is assigned to but never used
1234:71: E251 unexpected spaces around keyword / parameter equals
1234:73: E251 unexpected spaces around keyword / parameter equals
1234:73: E222 multiple spaces after operator
1235:69: E251 unexpected spaces around keyword / parameter equals
1235:71: E251 unexpected spaces around keyword / parameter equals
1235:71: E222 multiple spaces after operator
1236:67: E251 unexpected spaces around keyword / parameter equals
1236:69: E251 unexpected spaces around keyword / parameter equals
1236:69: E222 multiple spaces after operator
1237:58: E251 unexpected spaces around keyword / parameter equals
1237:60: E251 unexpected spaces around keyword / parameter equals
1238:60: E251 unexpected spaces around keyword / parameter equals
1238:62: E251 unexpected spaces around keyword / parameter equals
1244:49: E251 unexpected spaces around keyword / parameter equals
1244:51: E251 unexpected spaces around keyword / parameter equals
1249:21: E131 continuation line unaligned for hanging indent
1250:17: E122 continuation line missing indentation or outdented
1250:26: E203 whitespace before ':'
1255:17: E122 continuation line missing indentation or outdented
1255:21: E203 whitespace before ':'
1258:9: E303 too many blank lines (2)
1261:86: E203 whitespace before ':'
1263:22: E127 continuation line over-indented for visual indent
1263:95: E502 the backslash is redundant between brackets
1263:68: E203 whitespace before ':'
1263:92: E203 whitespace before ':'
1264:17: E128 continuation line under-indented for visual indent
1267:52: E502 the backslash is redundant between brackets
1268:17: E128 continuation line under-indented for visual indent
1268:21: E251 unexpected spaces around keyword / parameter equals
1268:23: E251 unexpected spaces around keyword / parameter equals
1272:9: E303 too many blank lines (3)
1273:53: E127 continuation line over-indented for visual indent
1274:53: E127 continuation line over-indented for visual indent
1280:51: E502 the backslash is redundant between brackets
1281:105: E502 the backslash is redundant between brackets
1283:53: E502 the backslash is redundant between brackets
1295:71: E225 missing whitespace around operator
1307:31: E127 continuation line over-indented for visual indent
1308:31: E127 continuation line over-indented for visual indent
1309:31: E127 continuation line over-indented for visual indent
1310:31: E127 continuation line over-indented for visual indent


1: D100 Docstring missing
27:1: E402 module level import not at top of file
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from datetime should be before from intbitset
29:1: I201 Missing newline before sections or imports.
29:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before from invenio.legacy.search_engine
34:1: E402 module level import not at top of file
35:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_indexer should be before from invenio.legacy.bibrank.citation_searcher
35:1: E402 module level import not at top of file
36:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibformat.dblayer should be before from invenio.legacy.bibrank.citation_indexer
36:1: E402 module level import not at top of file
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.modules.records.api should be before from invenio.utils.shell
38:1: E402 module level import not at top of file
39:1: I101 Imported names are in the wrong order. Should be task_get_option, task_has_option, task_init, task_set_option, task_sleep_now_if_required, task_update_progress, write_message
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.modules.records.api
39:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
49: D103 Docstring missing
59: D103 Docstring missing
127:1: E266 too many leading '#' for block comment
128:1: E266 too many leading '#' for block comment
137:1: E266 too many leading '#' for block comment
143:1: E266 too many leading '#' for block comment
150:1: E266 too many leading '#' for block comment
155:1: E266 too many leading '#' for block comment
190:1: E266 too many leading '#' for block comment
191:1: E266 too many leading '#' for block comment
199:5: F841 local variable 'dummy' is assigned to but never used
261: D103 Docstring missing
436:60: E251 unexpected spaces around keyword / parameter equals
437:18: E127 continuation line over-indented for visual indent
444:13: W503 line break before binary operator
445:13: W503 line break before binary operator
495:1: E266 too many leading '#' for block comment


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2011
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. import datetime should be before from time
31:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be CFG_LOGDIR, CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_URL, CFG_WEBALERT_MAX_NUM_OF_RECORDS_IN_ALERT_EMAIL, CFG_WEBALERT_SEND_EMAIL_NUMBER_OF_TRIES, CFG_WEBALERT_SEND_EMAIL_SLEEPTIME_BETWEEN_TRIES
33:1: E402 module level import not at top of file
34:6: E126 continuation line over-indented for hanging indent
41:1: I101 Imported names are in the wrong order. Should be add_to_basket, get_basket_owner_id
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.webbasket.api should be before from invenio.legacy.webbasket.db_layer
42:1: E402 module level import not at top of file
43:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, perform_request_search
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.legacy.webbasket.api
43:1: E402 module level import not at top of file
44:6: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.search_engine
45:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.legacy.webuser
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: E402 module level import not at top of file
52:1: I101 Imported names are in the wrong order. Should be CFG_EXTERNAL_COLLECTION_MAXRESULTS_ALERTS, CFG_EXTERNAL_COLLECTION_TIMEOUT
52:1: E402 module level import not at top of file
53:1: E122 continuation line missing indentation or outdented
54:1: E122 continuation line missing indentation or outdented
55:1: E402 module level import not at top of file
56:1: E402 module level import not at top of file
57:1: E402 module level import not at top of file
59:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.collections.models
59:1: E402 module level import not at top of file
63:1: E302 expected 2 blank lines, found 1
63: D202 No blank lines allowed *after* function docstring, found 1
68:1: E302 expected 2 blank lines, found 1
68: D202 No blank lines allowed *after* function docstring, found 1
73:1: E302 expected 2 blank lines, found 1
73: D401 First line should be imperative: 'Return', not 'Returns'
73: D202 No blank lines allowed *after* function docstring, found 1
78:1: E302 expected 2 blank lines, found 1
78: D401 First line should be imperative: 'Return', not 'Returns'
78: D202 No blank lines allowed *after* function docstring, found 1
78: D400 First line should end with '.', not 'm'
84:1: E302 expected 2 blank lines, found 1
84: D202 No blank lines allowed *after* function docstring, found 1
84: D400 First line should end with '.', not 's'
94:29: E261 at least two spaces before inline comment
122:99: E502 the backslash is redundant between brackets
157:1: E302 expected 2 blank lines, found 1
157: D401 First line should be imperative: 'Return', not 'Returns'
157: D202 No blank lines allowed *after* function docstring, found 1
163:1: E302 expected 2 blank lines, found 1
172:37: E261 at least two spaces before inline comment
173:29: E261 at least two spaces before inline comment
203:99: E502 the backslash is redundant between brackets
262:1: E302 expected 2 blank lines, found 1
262: D202 No blank lines allowed *after* function docstring, found 1
267:1: E302 expected 2 blank lines, found 1
267: D401 First line should be imperative: 'Return', not 'Returns'
267: D202 No blank lines allowed *after* function docstring, found 1
271:6: E221 multiple spaces before operator
272:6: E221 multiple spaces before operator
273:7: E221 multiple spaces before operator
274:8: E221 multiple spaces before operator
275:6: E221 multiple spaces before operator
276:7: E221 multiple spaces before operator
277:7: E221 multiple spaces before operator
278:7: E221 multiple spaces before operator
279:7: E221 multiple spaces before operator
280:7: E221 multiple spaces before operator
281:7: E221 multiple spaces before operator
282:8: E221 multiple spaces before operator
283:7: E221 multiple spaces before operator
284:7: E221 multiple spaces before operator
285:7: E221 multiple spaces before operator
286:8: E221 multiple spaces before operator
287:7: E221 multiple spaces before operator
288:7: E221 multiple spaces before operator
289:7: E221 multiple spaces before operator
290:7: E221 multiple spaces before operator
298:25: E261 at least two spaces before inline comment
298:26: E262 inline comment should start with '# '
300:10: E261 at least two spaces before inline comment
305:18: E261 at least two spaces before inline comment
305:19: E262 inline comment should start with '# '
318:35: E128 continuation line under-indented for visual indent
319:35: E128 continuation line under-indented for visual indent
320:35: E128 continuation line under-indented for visual indent
324:1: E302 expected 2 blank lines, found 1
324: D209 Put multi-line docstring closing quotes on separate line
324: D202 No blank lines allowed *after* function docstring, found 1
367:1: E302 expected 2 blank lines, found 1
367: D209 Put multi-line docstring closing quotes on separate line
367: D202 No blank lines allowed *after* function docstring, found 1
380:1: E302 expected 2 blank lines, found 1
380: D209 Put multi-line docstring closing quotes on separate line
380: D202 No blank lines allowed *after* function docstring, found 1
393:1: E302 expected 2 blank lines, found 1
393: D209 Put multi-line docstring closing quotes on separate line
393: D202 No blank lines allowed *after* function docstring, found 1
405:1: E302 expected 2 blank lines, found 1
405: D209 Put multi-line docstring closing quotes on separate line
405: D202 No blank lines allowed *after* function docstring, found 1
422:1: E302 expected 2 blank lines, found 1
422: D401 First line should be imperative: 'Log', not 'Logs'
422: D202 No blank lines allowed *after* function docstring, found 1
433:1: E302 expected 2 blank lines, found 1
433: D209 Put multi-line docstring closing quotes on separate line
433: D202 No blank lines allowed *after* function docstring, found 1
433: D400 First line should end with '.', not 's'
433: D205 Blank line missing between one-line summary and description
451:82: E502 the backslash is redundant between brackets
456:106: E502 the backslash is redundant between brackets
461:1: E302 expected 2 blank lines, found 1
461: D202 No blank lines allowed *after* function docstring, found 1
461: D400 First line should end with '.', not '?'
466:1: E302 expected 2 blank lines, found 1
466: D202 No blank lines allowed *after* function docstring, found 1
466: D400 First line should end with '.', not '?'
471:1: E302 expected 2 blank lines, found 1
471: D209 Put multi-line docstring closing quotes on separate line
471: D202 No blank lines allowed *after* function docstring, found 1
480:31: E261 at least two spaces before inline comment
486:1: E302 expected 2 blank lines, found 1
486: D209 Put multi-line docstring closing quotes on separate line
486: D202 No blank lines allowed *after* function docstring, found 1
486: D400 First line should end with '.', not 's'
486: D205 Blank line missing between one-line summary and description
494:1: E302 expected 2 blank lines, found 1
494: D209 Put multi-line docstring closing quotes on separate line
494: D202 No blank lines allowed *after* function docstring, found 1
494: D205 Blank line missing between one-line summary and description
509:1: E302 expected 2 blank lines, found 1
509: D209 Put multi-line docstring closing quotes on separate line
509: D202 No blank lines allowed *after* function docstring, found 1
509: D400 First line should end with '.', not 's'
509: D205 Blank line missing between one-line summary and description
532: D209 Put multi-line docstring closing quotes on separate line
532: D205 Blank line missing between one-line summary and description
543:64: E261 at least two spaces before inline comment
543:65: E262 inline comment should start with '# '
555:1: E302 expected 2 blank lines, found 1
555: D202 No blank lines allowed *after* function docstring, found 1
555: D400 First line should end with '.', not 'l'
576:44: E261 at least two spaces before inline comment
576:45: E262 inline comment should start with '# '


22:1: E402 module level import not at top of file
23:1: E402 module level import not at top of file
24:1: I100 Imports statements are in the wrong order. import datetime should be before import os
24:1: F401 'datetime' imported but unused
24:1: E402 module level import not at top of file
25:1: F401 'time' imported but unused
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. import sys should be before import time
26:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. import threading should be before from invenio.utils
29:1: I201 Missing newline before sections or imports.
29:1: F401 'threading' imported but unused
29:1: E402 module level import not at top of file
30:1: I201 Missing newline before sections or imports.
30:1: E402 module level import not at top of file
42:1: I101 Imported names are in the wrong order. Should be CFG_BIBRANK_SHOW_DOWNLOAD_STATS, CFG_CACHEDIR, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_WEBDIR, CFG_WEBSEARCH_DEFAULT_SEARCH_INTERFACE, CFG_WEBSEARCH_ENABLED_SEARCH_INTERFACES, CFG_WEBSEARCH_INSTANT_BROWSE_RSS, CFG_WEBSEARCH_MAX_RECORDS_IN_GROUPS, CFG_WEBSEARCH_RSS_I18N_COLLECTIONS, CFG_WEBSEARCH_RSS_MAX_CACHED_REQUESTS, CFG_WEBSEARCH_RSS_TTL, CFG_WEBSEARCH_USE_MATHJAX_FOR_FORMATS, CFG_WEBSEARCH_WILDCARD_LIMIT
42:1: I100 Imports statements are in the wrong order. from invenio.config should be before from werkzeug.local
42:1: F401 'CFG_WEBSEARCH_USE_MATHJAX_FOR_FORMATS' imported but unused
42:1: F401 'CFG_WEBSEARCH_RSS_TTL' imported but unused
42:1: F401 'CFG_WEBSEARCH_RSS_MAX_CACHED_REQUESTS' imported but unused
42:1: F401 'CFG_WEBSEARCH_RSS_I18N_COLLECTIONS' imported but unused
42:1: F401 'CFG_INSPIRE_SITE' imported but unused
42:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_STATS' imported but unused
42:1: F401 'CFG_CACHEDIR' imported but unused
42:1: F401 'CFG_WEBSEARCH_INSTANT_BROWSE_RSS' imported but unused
42:1: E402 module level import not at top of file
61:1: E402 module level import not at top of file
62:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
62:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.dbquery
62:1: E402 module level import not at top of file
63:1: I101 Imported names are in the wrong order. Should be drop_default_urlargd, make_canonical_urlargd, redirect_to_url
63:1: E402 module level import not at top of file
64:1: I100 Imports statements are in the wrong order. from invenio.utils.html should be before from invenio.utils.url
64:1: F401 'get_mathjax_header' imported but unused
64:1: E402 module level import not at top of file
65:1: F401 'nmtoken_from_string' imported but unused
65:1: E402 module level import not at top of file
66:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, get_user_preferences, isUserSuperAdmin, logoutUser, page_not_authorized
66:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.utils.html
66:1: E402 module level import not at top of file
68:1: I100 Imports statements are in the wrong order. from invenio.legacy.webcomment.webinterface should be before from invenio.legacy.webuser
68:1: E402 module level import not at top of file
69:1: E402 module level import not at top of file
70:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.webinterface should be before from invenio.legacy.weblinkback.webinterface
70:1: E402 module level import not at top of file
71:1: I101 Imported names are in the wrong order. Should be create_error_box, page, pageheaderonly
71:1: F401 'pageheaderonly' imported but unused
71:1: E402 module level import not at top of file
72:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webpage
72:1: E402 module level import not at top of file
73:1: I101 Imported names are in the wrong order. Should be EM_REPOSITORY, check_user_can_view_record, collection_reclist_cache, collection_restricted_p, get_coll_i18nname, get_most_popular_field_values, guess_primary_collection_of_a_record, perform_request_search, restricted_collection_cache
73:1: F401 'collection_reclist_cache' imported but unused
73:1: F401 'get_most_popular_field_values' imported but unused
73:1: F401 'EM_REPOSITORY' imported but unused
73:1: E402 module level import not at top of file
82:1: E402 module level import not at top of file
83:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.collections.models
83:1: F401 'get_fieldvalues' imported but unused
83:1: F401 'get_fieldvalues_alephseq_like' imported but unused
83:1: E402 module level import not at top of file
84:6: E126 continuation line over-indented for hanging indent
85:1: E402 module level import not at top of file
86:1: E402 module level import not at top of file
87:1: E402 module level import not at top of file
88:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: E402 module level import not at top of file
91:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.modules.formatter.engine
91:1: I201 Missing newline before sections or imports.
91:1: E402 module level import not at top of file
92:1: I201 Missing newline before sections or imports.
92:1: E402 module level import not at top of file
93:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before from invenio.legacy.bibupload.engine
93:1: F401 'get_cited_by_list' imported but unused
93:1: E402 module level import not at top of file
94:1: F401 'get_download_weight_total' imported but unused
94:1: E402 module level import not at top of file
95:1: F401 'summarize_records' imported but unused
95:1: E402 module level import not at top of file
96:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.search_engine.summarizer
96:1: E402 module level import not at top of file
97:1: E402 module level import not at top of file
98:1: E402 module level import not at top of file
99:1: I101 Imported names are in the wrong order. Should be WebInterfaceFilesPages, WebInterfaceManageDocFilesPages
99:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.webinterface should be before from invenio.legacy.bibmerge.webinterface
99:1: E402 module level import not at top of file
100:1: E402 module level import not at top of file
101:1: F401 'mymkdir' imported but unused
101:1: E402 module level import not at top of file
103:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.utils.shell
103:1: E402 module level import not at top of file
112: D202 No blank lines allowed *after* function docstring, found 1
112: D200 One-line docstring should not occupy 3 lines
151: D290 White spaces around docstring should be trimmed.
151: D203 Expected 1 blank line *before* class docstring, found 0
151: D204 Expected 1 blank line *after* class docstring, found 0
155: D102 Docstring missing
157:17: E203 whitespace before ':'
158:21: E203 whitespace before ':'
168:13: E266 too many leading '#' for block comment
170:22: E203 whitespace before ':'
171:26: E203 whitespace before ':'
172:21: E203 whitespace before ':'
173:26: E203 whitespace before ':'
174:23: E203 whitespace before ':'
188: D290 White spaces around docstring should be trimmed.
188: D203 Expected 1 blank line *before* class docstring, found 0
188: D400 First line should end with '.', not 't'
197: D102 Docstring missing
218: D102 Docstring missing
233:17: E128 continuation line under-indented for visual indent
261:86: E203 whitespace before ':'
263:21: E127 continuation line over-indented for visual indent
263:67: E203 whitespace before ':'
263:91: E203 whitespace before ':'
266:52: E502 the backslash is redundant between brackets
267:17: E128 continuation line under-indented for visual indent
267:32: E502 the backslash is redundant between brackets
268:17: E128 continuation line under-indented for visual indent
281:42: E261 at least two spaces before inline comment
281:43: E262 inline comment should start with '# '
296: D290 White spaces around docstring should be trimmed.
296: D203 Expected 1 blank line *before* class docstring, found 0
296: D400 First line should end with '.', not 't'
305: D102 Docstring missing
324: D102 Docstring missing
336:17: E128 continuation line under-indented for visual indent
366:21: E128 continuation line under-indented for visual indent
367:21: E128 continuation line under-indented for visual indent
386: D290 White spaces around docstring should be trimmed.
386: D203 Expected 1 blank line *before* class docstring, found 0
391: D290 White spaces around docstring should be trimmed.
404:17: E128 continuation line under-indented for visual indent
405:40: E126 continuation line over-indented for hanging indent
448:102: E203 whitespace before ':'
450:37: E127 continuation line over-indented for visual indent
450:83: E203 whitespace before ':'
450:107: E203 whitespace before ':'
453:64: E502 the backslash is redundant between brackets
454:29: E128 continuation line under-indented for visual indent
454:44: E502 the backslash is redundant between brackets
455:29: E128 continuation line under-indented for visual indent
465:94: E203 whitespace before ':'
467:29: E127 continuation line over-indented for visual indent
467:75: E203 whitespace before ':'
467:99: E203 whitespace before ':'
470:60: E502 the backslash is redundant between brackets
471:25: E128 continuation line under-indented for visual indent
471:40: E502 the backslash is redundant between brackets
472:25: E128 continuation line under-indented for visual indent
498: D202 No blank lines allowed *after* method docstring, found 1
508:94: E203 whitespace before ':'
510:29: E127 continuation line over-indented for visual indent
510:75: E203 whitespace before ':'
510:99: E203 whitespace before ':'
513:60: E502 the backslash is redundant between brackets
514:25: E128 continuation line under-indented for visual indent
514:40: E502 the backslash is redundant between brackets
515:25: E128 continuation line under-indented for visual indent
543:9: E303 too many blank lines (2)
555: D290 White spaces around docstring should be trimmed.
555: D203 Expected 1 blank line *before* class docstring, found 0
560: D290 White spaces around docstring should be trimmed.
560: D202 No blank lines allowed *after* method docstring, found 1
587:1: E302 expected 2 blank lines, found 1
587: D290 White spaces around docstring should be trimmed.
600: D209 Put multi-line docstring closing quotes on separate line
600: D400 First line should end with '.', not 't'
600: D205 Blank line missing between one-line summary and description
613: D401 First line should be imperative: 'Thi', not 'This'
613: D290 White spaces around docstring should be trimmed.
613: D209 Put multi-line docstring closing quotes on separate line
613: D202 No blank lines allowed *after* method docstring, found 1
613: D400 First line should end with '.', not 'r'
613: D205 Blank line missing between one-line summary and description
704:13: E266 too many leading '#' for block comment
705:13: E266 too many leading '#' for block comment
713: D400 First line should end with '.', not 'I'
715:63: E231 missing whitespace after ','
722: D290 White spaces around docstring should be trimmed.
731: D400 First line should end with '.', not 'e'
736:55: E202 whitespace before '}'
778: D209 Put multi-line docstring closing quotes on separate line
778: D400 First line should end with '.', not 'g'
778: D205 Blank line missing between one-line summary and description
783:84: E203 whitespace before ':'
794:17: E128 continuation line under-indented for visual indent
797:13: F841 local variable 'user_preferences' is assigned to but never used
811:5: F841 local variable 'normalised_name' is assigned to but never used
830: D400 First line should end with '.', not 'e'
830: D205 Blank line missing between one-line summary and description
850:59: E502 the backslash is redundant between brackets
851:32: F812 list comprehension redefines 'doi' from line 830
874:27: F841 local variable 'e' is assigned to but never used
888: D203 Expected 1 blank line *before* class docstring, found 0
900: D290 White spaces around docstring should be trimmed.
900: D203 Expected 1 blank line *before* class docstring, found 0
900: D400 First line should end with '.', not 't'
905: D102 Docstring missing
914: D102 Docstring missing
924:17: E128 continuation line under-indented for visual indent
954:86: E203 whitespace before ':'
956:21: E127 continuation line over-indented for visual indent
956:67: E203 whitespace before ':'
956:91: E203 whitespace before ':'
959:52: E502 the backslash is redundant between brackets
960:17: E128 continuation line under-indented for visual indent
960:32: E502 the backslash is redundant between brackets
961:17: E128 continuation line under-indented for visual indent


1: D100 Docstring missing
2: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils
41:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.records.api
45:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly, warning_page, write_warning
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.webjournal should be before from invenio.legacy.webuser
50:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
50:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webjournal
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
53:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, guess_primary_collection_of_a_record, is_user_owner_of_record, record_exists
54:6: E126 continuation line over-indented for hanging indent
57:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
57:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.search_engine
60:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
63:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.search.models
69:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
69:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
69:1: E402 module level import not at top of file
70:6: E126 continuation line over-indented for hanging indent
76: D101 Docstring missing
78: D102 Docstring missing
118:94: E203 whitespace before ':'
120:30: E127 continuation line over-indented for visual indent
120:95: E502 the backslash is redundant between brackets
120:76: E203 whitespace before ':'
120:92: E203 whitespace before ':'
128:60: E502 the backslash is redundant between brackets
129:52: E251 unexpected spaces around keyword / parameter equals
129:54: E251 unexpected spaces around keyword / parameter equals
158:17: E266 too many leading '#' for block comment
159:17: E266 too many leading '#' for block comment
177:13: E266 too many leading '#' for block comment
201:37: E266 too many leading '#' for block comment
202:37: E266 too many leading '#' for block comment
205:45: E128 continuation line under-indented for visual indent
212:107: E203 whitespace before ':'
214:37: E122 continuation line missing indentation or outdented
214:102: E502 the backslash is redundant between brackets
214:83: E203 whitespace before ':'
214:99: E203 whitespace before ':'
215:41: E128 continuation line under-indented for visual indent
276:25: E128 continuation line under-indented for visual indent
276:79: E502 the backslash is redundant between brackets
277:41: E127 continuation line over-indented for visual indent
278:54: E502 the backslash is redundant between brackets
279:25: E128 continuation line under-indented for visual indent
281:25: E126 continuation line over-indented for hanging indent
288:25: E127 continuation line over-indented for visual indent
289:25: E127 continuation line over-indented for visual indent
290:25: E127 continuation line over-indented for visual indent
291:25: E127 continuation line over-indented for visual indent
294: D400 First line should end with '.', not 't'
294: D205 Blank line missing between one-line summary and description
294: D208 Docstring is over-indented
306:1: E302 expected 2 blank lines, found 1
306: D290 White spaces around docstring should be trimmed.
306: D202 No blank lines allowed *after* function docstring, found 1
306: D400 First line should end with '.', not 's'
315:13: E203 whitespace before ':'
322:13: E266 too many leading '#' for block comment
334:17: E266 too many leading '#' for block comment
349: D101 Docstring missing
353: D400 First line should end with '.', not 'd'
353: D200 One-line docstring should not occupy 3 lines
374:22: E126 continuation line over-indented for hanging indent
374:50: E203 whitespace before ':'
375:55: E203 whitespace before ':'
385:9: E122 continuation line missing indentation or outdented
438:96: E128 continuation line under-indented for visual indent
449:50: E502 the backslash is redundant between brackets
469:5: E128 continuation line under-indented for visual indent
479:26: E251 unexpected spaces around keyword / parameter equals
479:28: E251 unexpected spaces around keyword / parameter equals
482:111: E502 the backslash is redundant between brackets
482:34: E251 unexpected spaces around keyword / parameter equals
482:36: E251 unexpected spaces around keyword / parameter equals
483:37: E127 continuation line over-indented for visual indent
484:25: E251 unexpected spaces around keyword / parameter equals
484:27: E251 unexpected spaces around keyword / parameter equals
485:24: E251 unexpected spaces around keyword / parameter equals
485:26: E251 unexpected spaces around keyword / parameter equals
490: D202 No blank lines allowed *after* method docstring, found 1
490: D400 First line should end with '.', not 'e'
490: D300 Expected """-quotes, got '-quotes
505:16: E127 continuation line over-indented for visual indent
509:35: E128 continuation line under-indented for visual indent
510:35: E128 continuation line under-indented for visual indent
520:13: B901 blind except: statement
526:13: B901 blind except: statement
531:17: E128 continuation line under-indented for visual indent
532:17: E128 continuation line under-indented for visual indent
533:17: E128 continuation line under-indented for visual indent


the space before the second `<$>` was too much, not the one you removed.  (-:


Right now we there is no gradlew helper, so the user needs a gradle installation or a gradle IDE plugin


@dmcgowan how is this different from `tarsum.v1+sha256:....` ?


Added WARNING_CFLAGS to enable control these without effecting other.


do you know if the bn_ functions are thread-safe?


We can definitely incorporate a separate export textures option.  But textures, by convention, should be placed in a folder called "textures" within the object's directory.  This also allows us to point CryEngine to the textures in the MTL file so you do not have to do it manually.  In other words, when you drag the object into the CryEngine scene from the rollup bar it will already have textures applied.  I have tested and verified that it works.  But I would be happy to create a separate export textures tool for such case.


Тут ошибка.
А именно, при подходящих параметрах может возникнуть такая проблема.
Возможно, цикл обошёл не все элементы массива open_addr_hash_array в поиске свободного места.
Так как нет гарантии, что hash_num принимает все значения в диапазоне {0, ..., open_addr_hash_array.size() - 1} когда индекс i пробегает этот диапазон.
Т.е. места, куда вставлять данный элемент, может не найтись.
Даже несмотря на то, что свободные ячейки в массиве есть.
И тогда эта функция вернёт номер уже занятой ячейки.
Что приведёт к перезаписи содержимого ячейки – фактически к неожиданному удалению элемента, который в ней находился.
Кажется из hash_linear, hash_quadratic и hash_double, только в hash_linear все элементы массива обязательно будут проверены.
Т.е. в hash_quadratic вероятно та же проблема.

Если закомментировать srand() в Universal_Hash, а в main() запустить srand(2) вместо srand(time) и задать 15 строк, то строка "iuw" будет найдена во всех структурах, кроме Double_Hash:
...
iuw nuzql kll wmto kjojj hsdicgx tmeee mfn tabfrx ijcy iqlke fnuzg cvsk iyuvxpj fgjm
[CLASS] Ordinary string :
iuw nuzql kll wmto kjojj hsdicgx tmeee mfn tabfrx ijcy iqlke fnuzg cvsk iyuvxpj fgjm
[Debug] Class Ordinary search : [CLASS Debug] Ordinary search :
Found!

Search in Division Hash :
Found in Class hash!
...
Search in Quadratic Hash :
iuw : Found in hash!
Search in Double Hash :
NOT found in hash.
...

Возможно еще, как минимум теоретически, что все ячейки закончились.
Нужно как-то отделить эту ситуацию от обычного хода дел: упасть, перевыделить память под ячейки, и т.п.
А не возвращать номер ячейки, где лежит другой элемент.
Это касается уже всех трёх функций (hash_linear, hash_quadratic и hash_double).
По хорошему, у них на выходе должно выполняться постусловие: элемент по индексу hash_num либо совпадает с search_string, либо равен зарезервированному значению "0".


Really `item` is preserved after the loop, that's really not C/C++ like. Will unindent it by one level^^


(I had a train trip to fill ;) )

I would like to rather err on the side of showing not all of them then to show too many. The approach you outlined would show tables of plugins that do not use our api, but I don't see us patching all old plugins to use the api.

But granted, when writing it the way I did it was more because I didn't know `SHOW TABLES FROM DATABASE`. And I wasn't really happy with the code, had to convince myself to push it anyway to show you the functionality.


That'll be part of my verification, but the DLL looks identical from `depends` so I'm extremely confident it will :)


This looks like a bug since `user.toEmber` requires as parameter a user object. Here you're passing `userId` which seems to be just an user id instead of user object.


strange, I do not get this, what version of gcc?


Don't worry about this guard condition. I don't mind being able to blank out the title.


This looks great. I second @jdmgoogle's question.


In the future I will comment it out.


why not `s/r = +i/return +i/` ?


OK I do it!


Is this the correct label for this spec?


ack


No need to use quotes for object keys unless they characters like `-`.

`{id: currentUser}`
`{'id-field': currentUser}`


The file has lots of tabs...


This one is doing better than the "double_history" patch which was doing awesome.  I could not see what it was doing differently...this one it is clear has improved its late middlegame and endgame.

Komodo 8 64-bit 8T    3234 - Stockfish 070315 64 POPCNT 8p    231.0 - 326.0    +83/=296/-178    41.47%
Komodo 8 64-bit 8T    3234 - Stockfish 080315 64 POPCNT-dh    221.5 - 385.5    +73/=297/-237    36.49%
Komodo 8 64-bit 8T    3234 - Stockfish 100315 64 POPCNT-cm    71.0 - 136.0    +20/=102/-85    34.30%


This would be referring to a tarsum v0.  We no longer use the v0 tarsum anywhere for generating digests because of its use of `mtime`. Note for other parts of the document `tarsum.v1+sha256` is currently the same version as `tarsum.dev+sha256`, but only `tarsum.v1+sha256` should be used to generate new content.


ESTP should be written capital cases


fi i had this line he doesnt compile. Is there any part i missed? Thanks


well that's python.


teams instead of Teams ;)


every variable is just a name for an object. Each name is valid from its declaration in the function around.


then you won't need this line btw


Hi @bbockelm
Now that I think a bit more on this, your suggestion should not get it out of the exception if WMAgent_JobID is NoneType. What we need is similar to Line#1121:
tmpDict["WMAgentID"]=int(results[i].get("WMAgent_JobID"))  if results[i].get("WMAgent_JobID") is not None else 0


not only to coach, but **also** to


Ah I see.  My bad, I will merge these.


Oops, sorry!


We still have a to fix the problem of libpulse-simple for all those who launched lutris between the last two runtime updates. One solution is to add an older version of libpulse-simple and libpulsecommon [from wheezy](https://packages.debian.org/wheezy/libpulse0) to the runtime (until we release a new version of Lutris with this commit in). It works for me on xubuntu 14.04.
You think it's ok ? Is there a risk for incompatibilities with more recent distros ?


For this to work, the user would also have to download the rest of the "shapefile", which consists of 4 files in this case, all located in the same folder (cities.shp, cities.prj, cities.shx, cities.dbf).


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1103 of 1103 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.04%25-green.svg)


Deleted files goes here


The `CITIES_PATH` is oudated as well, should probably read `ds = DataSource('/path/to/your/cities.shp')`


* Update README.md (08th Mar '15)
+ 26 - 08th Mar


You can use ```<<``` here, since ```status``` is a variable.


In callbacks usually the convention is that the first argument is the error. `done('success')` would mean that you're calling the callback with an error. To signal success you should do `done(null)`.


```Ruby
params.require(:order).permit(permitted_checkout_attributes)
```
is sufficient here, you don't need to check for present.


Nitpicking here - Wouldn't this be more correct?

```ruby
 it "CANNOT use must_equal in a thread without using expect"
```


I think it's very needed, because we for example have all textures in external folder. It's especially useful while many meshes uses same texture. So we will be forced to change all those directories manually :/


Кстати, профилировать имеет смысл код, скомпилированный с оптимизацией (например, -O2 или выше).
После включения оптимизации, скорость разных мест изменится по-разному.


dude, in the submission process, hitting this --

"This icon will be used on the App Store and must be in the JPG or PNG format, with a minimum resolution of at least 72 DPI, and in the RGB color space. It must not contain layers or rounded corners."

@lawinslow @mwernimont can you square these icons? sorry for the late notice.


@miguelportilla @scottschurr Thanks for the great feedback! I made another push with the latest round of comments (renamed maybe_get, catch boost::bad_lexical_cast only, & added braces for some `if` statement). Probably ready to go at this point.


Maybe rename this to `get_defence_request_scopes`?


dang, I didn't even think about that. That should be an easy fix.


Indentation must be fixed here because it's very confusing.


lets try it


@as-cii could you explain me why `[@card.board, @card]` instead of `@card` only?


@andrewgaul this test is problematic. The message could differ from different providers, I don't see why we should check for the exact aws response


Right, I've forgotten about this. Thanks for the fix!


This is a different story - I have to check if the HEP protocol (used for siptrace to sipcapture communication) does support WS proto.....be with you back after checking with Homer guys


просто свободно плавающий logo? разве не надо заключить в какую нибудь общую секцию вроде хедера или контента?


@davidfowl - so with aaaf6caa32f7496886c0b0e981b506eceffdf4c4 it comes down to ~200 events when starting OmniSharp. Now, most of them will be ```DocumentAdded``` and they could even be send as a single message.


I cannot wait for expectations to be deprecated on object! :clap: :clap: :clap:


I tested the netinst iso files and they let you select packages to install in a GUI installer, but the package list is empty. If developers want to make functional netinst isos, they can add a target and fix the netinst isos to become functional.

At this point, since the files don’t even work, I see no need to add a make target.


Yeah, I do think that will make sense, but I hadn't looked through all the templates to see if there are any special cases that it might break.  I also think the `bytes` variable might be better named `repeat` or something, because it doesn't always indicate the number of bytes to consume.


I tested the netinst iso files and they let you select packages to install in a GUI installer, but the package list is empty. If developers want to make functional netinst isos, they can add a target and fix the netinst isos to become functional.

At this point, since the files don’t even work, I see no need to add a make target.

From: mpalmi [mailto:notifications@github.com]
Sent: Tuesday, March 10, 2015 11:21 AM
To: ykhodorkovskiy/clip
Cc: Yuli Khodorkovskiy
Subject: Re: [clip] Issue #101: Do not move netinst iso after building (19c1f2c)

Seems reasonable to me, but what if a user wants to use the netinst iso? Should there be a separate target for netinst?

—
Reply to this email directly or view it on GitHub<https://github.com/ykhodorkovskiy/clip/commit/19c1f2c50fac7fc01d162876f02c68802f292cb6#commitcomment-10122662>.


@pkoms I think we sorted out most of this in #31 (happy reading) ;)


LGTM


The code sample in the patch above is similar but also different enough from the code I have that I can't confidently make the intended change. I may be working with a different rev than it's for.  I have:

URL: https://github.com/PromyLOPh/pianobar
Repository Root: https://github.com/PromyLOPh/pianobar
Repository UUID: 3c926597-1997-fd3a-0d48-ce57b7db7bff
Revision: 986

(Apologies for the clumsiness of the information on my part. I've been writing C and ASM as a hobby for 30 years, but am not versed in contemporary version-control methods. Just let me know what/how I can provide a more useful description if needed.)


So can you use asterisks in things too? Can't think of a use but it's cool to know.


@psych777 for your new One Pattern feat I have a couple of small tips.  Otherwise its looking good and really appreciate all the help you have been giving. =)

First one is all feats need the following at the top of the scripts. This prevents the feat from executing if it gets disabled from some outside source (archetype, feat, magic item, spell)...

~ If we're disabled, do nothing
doneif (tagis[Helper.FtDisable] <> 0)

Two is always make sure you do a += when dealing with field[abValue].value instead of = which does a set.  What if someone uses an adjustment or another script to adjust the value on this feat?  By using "=" that change will not be taken into account.

Three is it makes the script allot easier to work with if you use the value[] macro and it makes the script shorter and faster to write: field[abValue].value += #value[cPUDisPatt] + #value[cPUEnhDisr]

Four is the Disrupt Pattern ability is setup to have is "abValue" adjusted not to adjust the Fix Damage section directly.  The reason is it is easier to have a single script manipulate the text damage than multiple places.  Especially sense this extra damage is the type that is increased on a critical hit we need to be using the extradamage[] macro instead.  This fits into HL standards for "extra" damage.

On top of this the extradamage is only in specific situations which means we should be displayed as situational damage or it should be something a person can activate on the In-Play tab.  Otherwise a person on the iPad will always be adding this damage when they roll damage.  Which is not really correct because it only happens under a specific situation.  Adding situational text is great for those that use only paper character sheets as they will have a note next to the weapon to remind them.

If we can make these changes to the feat I would appreciate it!


Accidental commit


We may need this id, I guess we'll need to see what the API looks like in the end.  But it was used last time I looked.  The alternative, I guess would be to identify a dampening record by triggerId+triggerMode.


Fair enough. I'm fine with this change, given the current standing of netinst isos.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/9663/testReport/) for this commit**


:+1: will rebase with master HEAD, or add a provisioning step to fall back to a previous version of go-cloudstack after `updatedeps` as discussed


Nice!  I love the whole help text you are adding to the livename.  That helps cut down on questions I get!


@sabinaya Awesome. Can you update the README with
1. How to run the file
2. Sample input
3. Sample output

Also explain the correlation between the sample input and output


@kintner Should we be doing [the request in a background thread](https://github.com/kruppel/codepath.twitter/blob/master/Twitter/Classes/Categories/UIImageView+Twitter.swift)?


:+1: I was proposing "details", but "detail" is ok too.


@psych777 P.S. - Thanks for fixing my screw up with the .1st file. =)


:yum: :yellow_heart: :+1:


Why do we need this type? For marshalling?  If we have to have it then it should probably be a constant.


:dancers:


Do not merge yet, installs development files too. Fuck. Fixing.


Nope.


Why do we need this type? For marshalling? If we have to have it then it should probably be set via constants.  This will make the data passing much more verbose.


@sabinaya You need to update it here :)


This line is incorrect for 3.0 and caused the issue 692 bug. The proper check should be about "field->containing_oneof()" because there will always be a has_() for each oneof.


aka `dwAvgBytesPerSec` - should be `sampleRate * numChannels * 2` (for 16 bit)


Actually, this should not be transient and neither should safetyMatch, these are part of the trigger definition.


@hien- Just check out the browser console, the issues will be printed there.


I know it is confusing but, as best as I can figure out, the `*.Rmd` files should go into the `vignettes` directory.  When the package is installed they need to be moved to `inst/doc` but that should happen in the stage where the vignettes are built.


The indentation looks a little confusing. You can use the UART_PFIFO_TXFIFOSIZE(x) macro.
uint8_t txfifo_size = 2 << (UART_PFIFO_TXFIFOSIZE(dev->PFIFO));


Why get rid of tests? Or these are irrelevant after the change?


This made it worse why did we change the name?


@tmat I preserved this logic from previous revisions. If an assembly reference claims it has public key, but it's nil, or malformed - throw. Do you think we should relax this?


I want to run requestHandler in a separate thread because requests are locking the gui.  Every 3 seconds a timer sends a signal to request the data for whatever tab is currently open.  I see the lock every three seconds.  I imagine its when I process the data and store it.  The network requests are async.


Hi !
Thank you for these patches. I am going to them it too.

I ran into a quite interesting bug. Although 'add' is called only once per PD, 'del' is called twice when the lease is removed.
del 0:0:0:0:0:0:0:0:0:20:1:d:b8:0:0:0:2:0:0:0:0:0:0:10:0 eth2
del 0:0:0:0:0:0:0:0:3c:20:1:d:b8:0:1:2f:f0:0:0:0:0:0:0:0:0 eth2

The second time is the legitimate one. The first one causes the script to execute 'ip route del' which funnily enough erases IPv4 default route.
I fixed it in a very ugly way as I don't really know ruby.

if route.length != 0 and route[0].length > 8
                system("ip route del #{route[0]}")
end

'8' is completly arbitrary. Cleaner fix would be welcome.

Thanks again,


@tmat I preserved this logic from previous revisions. It validated the length of a public key token. Do you think we should relax this?


I think the only action here is to update tree-ops-ext with a notes example. Note that the prefixes "oa", "cnt" and "dctypes" aren't in our context, so we'll either need to use absolute URLs for them, or add the prefixes. I'll create an issue.


Awesome! if you happen to need it in the future my config is here: http://pastebin.com/uYt670W4


oups xD


hm looks a bit like duplicate code.
will have a closer look when I'm not on the phone :)


Just found it, thanks.


+1  @greg80303 want to merge this?


FYI, @ericadeahl and I tweaked this padding after adding small search to the `#topnav`. We may need to adjust this again when we bring it back.


Looks good


I wonder how they trigger the check then because I am pretty sure that they automatically regenerate the project files when CMake stuff changes.


Perhaps we remove the `"default":[]` from the devices schema instead so it isn't pre-populated?


@rizar This broke the `master` branch. `glimpses.items() + states.items()` doesn't work on Python 3 because they're dict views and not lists :)


Nope, it will look it up from Vagrant Cloud


Also, if you have a sample request that shows the "wrong" behaviour and why you want this stripped, that would help too!

Thanks for the explanation!


problem of this is if handle_401 returns 401 again (in case of GSS api error), then you got infinite loop.


Here we go :cry: https://github.com/sphereio/sphere-jvm-sdk/commit/597d3138738e4bbc3f167023443ed289913b07c2


So looking back at the commit where I introduced this bug, all I was trying to do was add a small wrapper around the call to `OsShell.process()` that ensured we always set the working directory. Given that intent, then the code I *should* have written would have been something like this:

    return self.run_shell_command_raw(command, _C, *args, **kwargs)

I.e., since I was originally passing all parameters received by `run_shell_command()` on to `OsShell.process()`, I should have done the same thing with `run_shell_command_raw()`.

Would you mind changing your code so this call does the same, rather than listing each parameter? That way we'll avoid having the same problem again in the future.

Thanks.

Do you know if it's best practice to remove `command` from the `args` parameter, since it's now referred to explicitly?


This introduces some color contrast issues:

![image](https://cloud.githubusercontent.com/assets/113896/6580895/ab383d26-c710-11e4-90b0-20ad5a220abd.png)

![image](https://cloud.githubusercontent.com/assets/113896/6580928/e52be8e8-c710-11e4-88b0-f937c7ea1724.png)

Could we make it white?


Ccmlnode.hu


It caused tests to fail to compile, and there's no need to rename it. It wasn't named in parallel with `Vector*` and doesn't need to be parallel with `Geometry*`.


Du coup tu as bien le Builld passed ? :)


I think you mean http://github.com/burtonsamograd/med


@TheImmortal Using the animation for Giga Impact adds a 'must recharge' tag. Also I'm sure Head Charge\Head Smash uses the same animation anyway.
On another note can you tell me how am I supposed to post my fixes now that Seasonal's on main? Ty


%size ? I'm not sure if String.format supports that :)


@kellyselden that break appears expected. That library must check if the view is tagless or not. I have no idea what $() is supposed to be for a tagless view, it is basically just an invalid case.

An add-on that adds this to every view seems dubious.


This was removed. We aren't going to store this in the app. In future we hope to pull this from the web.


HumidifierSizing_#4688 (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1641 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


The 0.8.3 version removed the double ripple effect on tabs. I like the double ripple effect. :<


LGTM


I suspect the reason is because how routing works?


code eka wenas karanda puluwnda?


Correct!


:disappointed_relieved: :+1:


It's all contained within the `BUILD_ALL.vcxproj` file. You can't invoke it separately.


Yeah, I wasn't sure about it. But don't think people would expect it be `onLineSegments reverse`. Maybe I could add comments to make this clear. I'm not desperate to have this, the `reversed` iso just seemed to fit nicely with the rest of the PR.


At least as far as I know, I couldn't find anything similar to it. It will rerun CMake on build if needed.


So this would exclude a `Filter` which is actually usable but was also subclassed, right? I guess we can live with that until we have such a `Filter`...


@stefanpenner after researching more, I agree with the change and the unexpectedness of using it.

If you're curious, the library is [ember-animate](https://github.com/gigafied/ember-animate). It manages to function with it so maybe it was unused code.


Correct - I didn't have any better ideas, and since this addresses our current filters I thought it'd do for now.


I don't think you need this change, but I'm wondering if there is an additional bug here.

First, on your change: What we want is to calculate the working directory -- based on the root directory -- only if no explicit working directory is provided. Your change will override the working directory if a `root_dir` is provided, even if an explicit `working_dir` is provided.

However, I think my original code is wrong! I'm testing to see if there is a `working_dir` parameter, and of course there always will be one, albeit usually set to `None`. That's what I should be checking for.

Since you discovered the bug, do you fancy making that change as well?


I added a comment in line 43 that I'm not sure about the condition, what should we use here? Do you have any ideas?


Mouais


lol


Layout ?


Done. What about .html files in inst/doc?


No problem. Ambient animations are always a huge tax when they aren't hardware accelerated.


:goat:


DebugLibrary should be installed since 7b5566f4d, can we re-enable it in the robot tests?


                        ISetEntry orphaned = current;
                        current = current.next();
                        orphaned.remove();

It should be:

                        ISetEntry orphaned = current;
                        current = current.next();
			if (entry == head) {
				head = head.next();
			}
                        orphaned.remove();


I get an error after i have installed the package Class 'PayPal\Api\Payer' not found. But i have use PayPal\Api\Payer;


HumidifierSizing_#4688 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (637 of 637 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.19%25-green.svg)


Well spotted...thanks!

I've added a few comments to the changes. If you agree with them would you like to resubmit the pull request?

Thanks for taking the trouble to fix this.


@miguelportilla @scottschurr FYI: Vinnie weighted in on this and he prefers `maybe_get`. Rational: `maybe_` is an established prefix (`maybe_const`, `maybe_multi`, `maybe_get`). It's also briefer.

We don't need to change in this PR.


@djazayeri  ie, this change


有道理!


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2221](http://teamcity.monogame.net/viewLog.html?buildId=5648&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


они в смысле отзывы?


не очень поняла про что именно ты говоришь


@jsuereth You're basically living on the edge here, and anything you do can potentially throw an OOME again, so I wouldn't worry too much about preallocating things. Doing things after an OOME without specifically "releasing" memory by clearing a cache or something similar is just a best effort thing with your fingers crossed. The completely broken thing is that it can be anyone that gets to handle the OOME and not the guy hogging the memory, so how do you handle it properly?


вот тут поподробнее, зачем вопреки бему?


`exec` and `status_command` etc. use `/bin/sh -c "..."`


Actually our API limits query responses by default to 20 items. Max amount is 500. So for larger sets you would need to work with offsets / pagination. More info here: http://dev.sphere.io/http-api.html#limit

To get count of all customers for given query you just need to do this ```all.fetch().getTotal();```


The same way you did before? Except this time quality matters and please no multiple commits.


So yep.


so if I provide some other argument, it'll swallow it? Eg. if I have a typo and provide "--keep-old-metric-data" - it will not keep it? Not good and dangerous.

Please see my original comment - of the flow how it shuould be


Technically the `.html` files in `inst/doc` are to be regenerated when the vignettes are rebuilt by the package.  I was doing that on my system and now realize that the maximal model may take a few hours to fit.


Of course :-/ What about replacing the link by:
`wget https://raw.githubusercontent.com/django/django/master/tests/gis_tests/data/cities/cities.{shp,prj,shx,dbf}`


Technically payloadLength is only file size if transferType is BLEFileTransferMessageTypeTransfer. I see the headers are set properly but this might make the serialization logic funny?


It would be loaded using the default wordpress plugin loading, which is what is happening currently without autoloader setup.

CMB has built in checks to make sure it isn't run multiple times, so the dependency management issues you mention shouldn't be a problem.

So:
* Installed in root and autoloaded in wp-config.php
 * init.php returns without doing anything cause add_action isn't defined
 * CMB2 is run again when plugins are loaded this time successfully
 * Any further instances of CMB2 that attempt to run don't because of CMB2's built in safety.
* Installed as a library in a plugin or theme
 * Autoloaded successfully during plugin or theme loading
 * Any further instances of CMB2 that attempt to run don't because of CMB2's built in safety.


@Swyter I had to shorten this string. Max characters is 80. Does the change make sense? Google translate said that "contemporáneo" means "contemporary", so I substituted it for "moderno" which is "modern" in english (apparently)


I confused all up a bit. The mess is supposedly fixed after c904f35728. Thanks, @joelteon.


I agree that `onLineSegments reverse` is much less useful, and would surprise users in a bad way.  I think these definitions are useful; adding a comment would make them better.


я таки не поняла зачем нам хедер если не навигации не лого там не будет?


This broke `cordova prepare` in my app where `INFOPLIST_FILE` contained `"$(SRCROOT)/Project/Project-Info.plist"`.  Removing `$(SRCROOT)/` doesn't seem to cause any problems in case anyone else starts getting "could not find -Info.plist file, or config.xml file.".


also, you cannot just call method parseArgument which parses specific one, right ;)


What I mean is in General prctice we do have the option to measure eye sight. We do have eaye trauma. Sometimens we can view the fundus and circulation. We do have equipment to measure eye pressure. But we defenitely do no surgery. We als do not give intra ocular injections, may be more but this was my idea when I saw the discussion going on between Brady and you over the correct placement and the on of discussion.

Fsgl might have some more and better thoughts on this.


ack


If you're interested in only total, you can just limit the response to 1 result.


HumidifierSizing_#4688 (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1641 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


Shit, never ever can I commit without PRs and not break master. Guess I should stop doing it altogether.


uhh thanks!


I'm curious why you chose to return JSON and render the HTML using JS?


Good


Have a look at http://jekyllrb.com/docs/templates/#includes. I think this way you can also use a custom class and you can make the selectors much easier. If you feel really fancy, you could even pass a parameter for `onlyCurrent` so that we can use the same include on the front page and the projects page.


Yeah, you're right. Maybe something like this (68 chars) sounds a bit more stylish:
> Vence a los sofistas del mundo moderno con esta práctica aplicación.

Or this (74 chars):
> Vence a los sofistas del mundo contemporáneo con esta práctica aplicación.

What do you think? :)


Should EncodeBytees be EncodeBytes?


Why not `15 * 1024`?


Good job on working on this again!


The `collapsed` class is frequently used in Bootstrap, we should namespace it so there's no conflict


@loriculberson as a general practice - we shouldn't be merging our own pull requests. The proper technique is to create the pull request then have someone else from the team review it. This has a couple of benefits to it: first: it helps bring other memebers of the team up to speed on the new features, Second: it puts eyes on it that can find issues that may have been missed.

Credence for Pushing:

If you push to your branch, you create a pull request.
Then have a different member or all members review, posting comments or ideas or enchancements
They will merge the branch to master after reviewing if there are no issues.


Actually, collapsed doesn't describe it accurately as it's not fully collapsed and has a height of 215px.


Hmm in this case it does because when we insert NULL it's always considered unique so the user can keep clicking on "New Record" and add multiple values. But with '' the user needs to change the value to something else before adding a new record.


Can you reword the line of docs instead of removing?


please fix this before merging :)


This method fetches different resources and it may take a while. How can you make it non-blocking?


Oops. I'll fix in a subsequent change.


> I was very clever when I wrote this


why not just do if(input.length!=0) and not have three return statements


If there's something reliable I'm happy to take it, this doesn't look like production ready, agreed. :)


There's no errback, so if the labrad request itself fails (as opposed to a synchronous exception being thrown)  the drLoggerCallback will not be called. How about something like this:
```python
@inlineCallbacks
def doLogging():
    try:
        p = self.cxn[self.drLoggerName].packet()
        ...
        result = yield p.send()
        self.drLoggerCallback(result)
    except Exception as e:
        self.drLoggerCallback(None, err=e)
doLogging()
```
I personally prefer the inlineCallbacks style to manually adding errbacks and callbacks, not least because, as here, the exception handling is more explicit and unifies synchronous and asynchronous errors.


I thought you did this? This confuses me.


woooooooooo