This is a copy of the tests I'd written for the other cookbook. I just copied it over.

We should remove this file, and add it back on a different branch.


App crashes when:
1. All points are NAN
2. When an edge point is NAN (ie. index 0 or index = (length - 1))

Terminating app due to uncaught exception 'NSRangeException', reason: '-[__NSCFArray objectAtIndex:]: index (7) beyond bounds (7)


Typo: `s/chuncked/chunked/`.


I miss your beautiful contribution to builds and DSLs every day when I have to plod through legacy Makefiles.


Ok I guess.


This fix seems useful to any user who dislikes going back and forward through multiple screens to get simple things done.


Odd thing, I haven't seen this issue on all my updated 3.4 sites but the one I did have issue with this fixed the problem.


This file shouldn't be included.


30414/Huruiala V. Vasile Alexandru/assignments/codeblocks/assignment1extra/JKN_io.c

So I'm thinking here's the part where strtok might be of use.
You read the line, the first token is clearly the country name and the other ones will be waves.


can you put this "{" on a new line? same goes for occurrences of this in the class.


It's OK, already did
On Mar 2, 2015 3:56 PM, "Jamie Chung" <notifications@github.com> wrote:

> Yeah was thinking about it. Will roll this back.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EduFocal/api/commit/aea6b56da06d6d2ab5a064e6cd00d4e9e63d8d12#commitcomment-9993887>
> .
>


Could use a top-level comment to say what this is doing.


Ah OK, gotya


That last patch needs a style.

I also have that sound ouch update but I haven't tested at all. So if it
builds and someone can, just cherry pick it.
On Mar 2, 2015 11:14 PM, "Kacper Michajłow" <notifications@github.com>
wrote:

> @mpc-hc <https://github.com/mpc-hc>: I have to go. I have
> https://github.com/kasper93/mpc-hc/compare if you agree I can push before
> I go.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kasper93/mpc-hc/commit/c210d6ddedd90a6c37936d2f9a6aefd2923c7d86#commitcomment-9994233>
> .
>


Uh? why?


30414/Huruiala V. Vasile Alexandru/assignments/codeblocks/assignment1extra/input.dat

leet!


consider creating once class for a table and then use > symbol to describe styling of the rows. .messages > tr { }


Oh it was resetted already :)


We're just tactically waiting with these suggestions until you are no longer stressed out about bytes implementations!


Well, I thought that since the segmentation module is present only short period of the lifetime program (during the segemntation), it'd be more efficient to put into the function, so once the funtion runs, the module disspeard from the memory.


how?


30414/Huruiala V. Vasile Alexandru/assignments/codeblocks/assignment1extra/JKN_battle.c

Before even reading it I can tell you that this method does too many things. It will need to be split.


That last patch need new astyle. This is what current version does.


A simple

```scala
SimpleSqlParser(testData, delimeter).DDL.run() === expected
```

should be all you need. You can even inline the `expected` val.


I'll test it ;)

-----Original Message-----
From: "Jeison Pacateque" <notifications@github.com>
Sent: 3/2/2015 4:19 PM
To: "JeisonPacateque/Asphalt-Mixtures-Aging-Simulator" <Asphalt-Mixtures-Aging-Simulator@noreply.github.com>
Cc: "Santiago Puerto" <hibikimsp@gmail.com>
Subject: Re: [Asphalt-Mixtures-Aging-Simulator] little improvement in Output,fem_mechanics CONSISTENT with the model of classe (a766428)

Well, I thought that since the segmentation module is present only short period of the lifetime program (during the segemntation), it'd be more efficient to put into the function, so once the funtion runs, the module disspeard from the memory.
—
Reply to this email directly or view it on GitHub.


committing .bin/ local.properties file is unnecessary

local.properties even says "+# This file must *NOT* be checked into Version Control Systems" (i.e. GitHub)


use nth-child to describe TDs (http://www.w3schools.com/cssref/sel_nth-child.asp)
.messages tr td:nth-child(1) { }


I just made a change (https://github.com/azavea/nyc-trees/pull/707/files#diff-3178765eaf2e28def49d127a49277a1bR128) which requires this line, so please leave it in.


lower camelCase. be consistent


Otherwise +1


I'd suggest making Server 2003-specific changes as a separate commit.


this looks like a method that might be called getStrongestCountry()
I'll let you guess what the return type should be and what it's parameters are


Med den här versionen kan ni använda remify i princip hur som helst:
```css
.foo {
  padding: remify(10px);
  margin: remify(0 10px 0 10px);
  border: remify(1px) solid black;
}
```
Detta producerar dessvärre duplicerade properties:
```css
.foo {
  padding: remify(10px) remify(0px);
}
```
Ping @JonasStattin @daniel73


Blah, don't care for the big if statement. Can we instead pass a function name to the ARCHS tuple which contains the logic to handle either the x86/amd64 or armv7 cases?


Let's remove this debug output.


Тогда уже пора и в самом валидаторе прописать что кастомные методы начинаются с большой буквы, т.к. в валидаторе имя метода начинается с "**v**alidate"


@Simn I'm starting to think we could use `::` operator for short lambdas. Wait. no, I just need some sleep :)


The man page does not mention that `raise` sets `errno`.  Do you have reason to think it does?


Changed resolution to: ``Windows: use the `GetAdaptersAddresses` (Windows Server 2003: `GetAdaptersInfo`) function to retrieve the DHCP servers.``


maybe add a comment with bug link would be useful?


bad name for a file, do not use prefix *my-* in a real world app, use a descriptive name, e.g. common.css, main.css, global.css and so on


> Even if it does, AppVeyor doesn't. And downloading the latest version will
> be slower.

That's not true, AppVeyor picks up new io.js versions really quickly, it had io.js 1.4.1 4 days ago, the day it was released. Also, the command:
```powershell
Install-Product node $env:nodejs_version
```
never downloads anything, it uses latest matching already installed version so switching is always fast.

> One thing at a time.

Sure, I didn't mean it was terrible that it didn't land in this particular commit. ;)


that makes sense. I guess I wanted to keep a more general addFirstLink for some reason.
I'll change it in the next iteration.


Changed resolution to: ``Windows: use the `GetAdaptersAddresses` (Windows Server 2003: `GetAdaptersInfo`) function to retrieve the network interface netmask.``

For netmask6, added a caveat: ``Windows Server 2003: IPv6 netmasks are not supported.``


use descriptive names


b2, b3?


Changed resolution to: ``Windows: use the `GetAdaptersAddresses` (Windows Server 2003: `GetAdaptersInfo`) function to retrieve the network interface netmask.``


@efiring there is also a `SymmetricalLogLocator` class in ticker.py that inherits from `Locator` instead of `LogLocator`, but it is not currently being advertised as part of the `__all__` tuple, so I don't know if it is being used by anyone, but if so, perhaps you should also add an `isinstance` check for it here as well.  In general, is there not a better way to check if the normalization is Linear or Log scaled?  I have not found such a function, but it seems like a basic property that should be able to be queried.


It does. You are probably doing somthing wrong. Post the settings you are using on the forum so that people can replicate your  issue
.


@micheldumontier Can you clarify if this is in fact the correct URI for the has-data-item rather than just a convenient human readable hack? That is, which should be used when using the property in OWL files etc?


Added caveat:  `Windows Server 2003: IPv6 netmasks are not supported.`


what does </table> do here?


@stephentoub If the problem stems from process launched by the tests then could it be solved by adding <CoverageEnabledForProject>false</CoverageEnabledForProject> to ProcessTest_ConsoleApp.csproj?


Yes, I get it. It is confusing to first check for the "not" condition, then
the "else" to the "not".

On Mon, Mar 2, 2015 at 12:11 PM, Colby Aley <notifications@github.com>
wrote:

> I think this block is a little confusing. I'd change it around a little
> bit...
>
> if Post.where(title: "Unique Post 1").any?
>   puts "Unique Post 1 exists already"
> else
>   puts "Unique Post 1 not found"
>   Post.create(
>     title:  "Unique Post 1",
>     body:   "This is a description for Unique Post 1"
>   )
> end
>
> Does it make sense how this solution is a little more clear?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stephenwlott/bloccit/commit/0f1cfc83c2bbd24c0df4eb0bbb8e407c35be57f9#commitcomment-9993112>
> .
>


use .js file to place scripts, remove js from html


In some way, the `JsonSerializable` module is hidden from SDK users.
You need to specify how to export to json an object but instead of repeat the same pattern for every object it was extracted into a module.

If there is a different pattern for context classes we will create a new module or we can start using Decorator pattern.
Right now I don't see it as an issue.


use css classes


Added caveat: ``Windows Server 2003: the `GetAdaptersInfo` function is used for DHCP and netmask lookup.  This function does not support IPv6 netmasks.``


Using `xcodebuild` instead of implicit `xctool` due to problems with KIF and xctool.


Pushed. I really need to go now. Maybe @Underground78 can take care about soundtouch. Good night!


Please look at the code and tell me if you think that warning is legitimate.


;d yea.. just playing to fix travis files around


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12177/testReport/) for this commit**


I looked at it and have formed my own opinion already...


also, this looks like a method that might be called "computeSoloPossibilities" or however you want to call it. It will clearly have to deal only with the strongest country. either it's possible for it to defeat everything by itself or it will defeat only a number of sentinels, so you guess the parameters of this function


approved


Using get and set, incomplete.


shouldn't it delete the password from the storage if the box is unchecked?


@pallavit, no, that property is just something custom picked up by our build process to determine whether to run xunit directly or using the code coverage tool.  In this case, it's a normal desktop app that's being run via Process.Start, and as such when the CLR loads the app, it checks for these environment variables to determine whether to attach the profiler.


I believe the `#submit` method requires a :requested_by


OK just noticed it.
On Mar 2, 2015 11:20 PM, "Kacper Michajłow" <notifications@github.com>
wrote:

> That last patch need new astyle. This is what current version does.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kasper93/mpc-hc/commit/c210d6ddedd90a6c37936d2f9a6aefd2923c7d86#commitcomment-9994328>
> .
>


I find these a bit redundant. I somehow understand the first part (Country * Sent = *Sentinel) but these two variables are redundant at this step.


Some other code register that callback I think and removes it, I tested it and it seemed to work OK already


I committed a fix for it already. I just wanted to bring it to everyone's attention since it is likely to cause erroneous behavior.


OK. Yay.


Touché...

But I have given up on short lambas for the times being because you have rejected them so often. My new idea is to introduce long lambdas: =====>


@micheldumontier Is there a reason that this is only for RDF datasets? Shouldn't it read "Datasets MAY ..."


way too generic, you don't want all of you images to have all these styles. use a css class


Thank you :) :+1:


r=mbrubeck

This is just updating Cargo packages to already-reviewed head commits.


PrettyGridView (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2082 of 2204 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.46%25-yellow.svg)


wow!


Since we're mangling paths in the Python anyway, can we mangle them enough to not require this branching?


so you might tell me that "hey, here's where I used them", but then again I now need to look up to see what exactly these two variables contain. Again, I think it might have been just simpler and more clear to use Sent->headArmy / Sent->tailArmy instead


That is certainly true. I waited more than 1 week for node 0.12. If they
have made things faster remains to be seen.

Anyway, being that AppVeyor is generally Uber slow I'm trying to keep
things simple first. We didn't even have caching enabled a few days ago.

I'll need to check things closer before changing this.
On Mar 2, 2015 11:22 PM, "Michał Gołębiowski" <notifications@github.com>
wrote:

> Even if it does, AppVeyor doesn't. And downloading the latest version will
> be slower.
>
> That's not true, AppVeyor picks up new io.js versions really quickly, it
> had io.js 1.4.1 4 days ago, the day it was released. Also, the command:
>
> Install-Product node $env:nodejs_version
>
> never downloads anything, it uses latest matching already installed
> version so switching is always fast.
>
> One thing at a time.
>
> Sure, I didn't mean it was terrible that it didn't land in this particular
> commit. ;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gruntjs/grunt/commit/2215218be3571eeeae5e7a38409075af6f628c8e#commitcomment-9994381>
> .
>


How about
```
'Are you sure want to cancel mapping this block?'
```


Not "wow!" yet: I haven't tested it!


Here's a micro optimization.  Given my understanding of the standard, if you declare these two numbers static they are more likely to be inlined in those calculations that use them.  That removes a couple of memory references so those calculations may run a bit faster.  But you will have to declare storage for the statics in SHAMap.cpp so it's a slightly more invasive change.


Otherwise +1


Skolacka chyba! :D  Melo by to byt
for file in "$data"/* ; do
Ta tvoje verze se rozbije na mezerach! Navic zbytecne spousti subshell


Yup, sorry about that. I just landed a fix (cl/87537844 for Googlers) which should be pushed to Github later today. Basically it just adds a new file, which defines the VisibilityState enum.


nice and precise!


whitespace


Could you please explain why you enable pinning (which is good) and allow invalid certs and disable domain name validation and chain validation at the same time? Just trying to understand because it looked 'suspicious' to me.


Autorship please


It should still be fixed regardless.


To je asi zbytecne . GCC to vzdy prelozi tak, aby bylo spustitelne


Would prefer using the namespaced functions directly to importing them into module scope.


postfix const


Kdyz uz to makeujes, tak bych skoncil v pripade neuspechu. To by zachytilo i tu kontrolu na Makefile


the add-on still can't change the contents of the channel tag directly and still has to trigger an update if something changed.

see https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/addons/PVRClient.cpp#L554
the contents get written into a c-type struct and that gets passed to the add-on

I do want to get rid of all the triggers done by add-ons at some point by the way, and have add-ons write updates directly btw.


Kde se to pouziva? Jen v nazvu souboru?


30414/Huruiala V. Vasile Alexandru/assignments/codeblocks/assignment1extra/main.c

I think you don't really need to pass these parameters by address here. You're not using them anywhere else after this point. This makes sense for the readFile(...) function, yes, as you are using them further in the main function but the Battle function can simply use them as they are without you having to worry that the right stuff isn't returned to the main function, right?


I also see that you used where/any instead of exists?, which makes it read
a little differently.

On Mon, Mar 2, 2015 at 12:11 PM, Colby Aley <notifications@github.com>
wrote:

> I think this block is a little confusing. I'd change it around a little
> bit...
>
> if Post.where(title: "Unique Post 1").any?
>   puts "Unique Post 1 exists already"
> else
>   puts "Unique Post 1 not found"
>   Post.create(
>     title:  "Unique Post 1",
>     body:   "This is a description for Unique Post 1"
>   )
> end
>
> Does it make sense how this solution is a little more clear?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stephenwlott/bloccit/commit/0f1cfc83c2bbd24c0df4eb0bbb8e407c35be57f9#commitcomment-9993112>
> .
>


Again, probably not a good idea to put the token in the source.


Other than my comments, very well done. If you have any questions, feel free to ask.
I'll review it again after you change stuff around


Original comments in e90864c and cc5c259812a3ec2217c3347735aa0480ba59e9aa


please add the -dupecheck option, like we do for the main textures file (see line 114)


This throws HTTP 500 errors.


My bad... One sec and I'll correct.
On Mar 2, 2015 4:33 PM, "Davor Bertovic" <notifications@github.com> wrote:

> Autorship please
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scotthartbti/android_frameworks_base/commit/b70f4dff666bb506927ea6cfdbed58896c7d0554#commitcomment-9994586>
> .
>


Rebased version of 8dec0cb4a3d2b1d445fc7e073cf664653ee280f0


Rebased version of 15e3bd90cb08ec2bc609ec5538008cd0331f2b37


I really don't like from anillo import anillo
Additionally, having it in __init__.py file is not a good practice! Do you have plans change it?


I don't think I will ever update, though I might return to it, because E3 development is null, I haven't even left stock ROM :(


Why HTML, but just a simple README markdown render or just a plain json?


I had the same reaction as @BobDean.

Plus, I generally don't like including the implementation language in package names, unless it is really essential to understanding what the package does.


Duplicita se 4), tohle se muze smazat


Also added version at the start of the program.


rebased version of a8c077f93ed5acc2b0009cfafddb4c0a31b2f4cb


Hi Paul,

Connor here. Do you think that you could change the last tag here to something like:

outputfitsfile = orig_dir+'synthetic_image_'+filename[filename.index('broadband_')+10:filename.index('.fits')]+'_band_'+str(self.band)+'_camera_'+str(camera)+'_nobkg'+'.fits'

Or something like this to indicate that no background has been added? It might be a bit confusing to have a 'bg_##'.fits tag in the filename when no background is being added.


* URL should be masked
* no token


#87  , @anjain  can you please finish this work?

I know that there are changes left to be made on the Stripe javascript, at the very least.


rebased version of 661007a64c847bef66585cbbcecc521262f9c995


Jeste jsem udelal
5) kontrola parametru #parameters_check
   * pro kontrolu P1 a P2
   * vola se podobne jako kontrola velikosti dat


![image](https://cloud.githubusercontent.com/assets/4340267/6451156/dfb44d86-c12c-11e4-851a-9249b15153f3.png)
**build passing** :-)


Yup, this looks good.


Thanks! The LinkedHashMap was added to keep insertion order. Now the tables
will be created with the same column order they are defined.

This is why it's so important to use interfaces  for collection types (Map,
List, etc... as opposed to specific HashMap or ArrayList). Because of
generic interface use, i was able to change the data type of the map
without having to change additional code in other methods.
On Mar 2, 2015 11:56 AM, "Eliezer Abate" <notifications@github.com> wrote:

> Good Work!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CS108FinalProject/QuizWebsite/commit/46e92b135d476544a9a01bbc3d26ba9d86d06890#commitcomment-9992834>
> .
>


I am still lost on this point: the data is present inside of the variable. Why is using a getter more economical than using what is inside of variable? And, why does the variable contain data that is not used if it appears there are circumstances wherein the data would be used?


they were kind of useless, but i ran into problems when I used something like
&((*Sentinel)->headArmy), probably I felt it wold be simpler, even though i have to later update the header parameters


имхо, лучше писать что именно за кука, т.к. по имени метода более-менее понятно.
как и выше фраза "для быстродействия/оптимизации" - лучше "заполнение связи вручную чтобы сэкономить запрос на получение связи".


Move it to `profiles/killbill/src/test/resources/plugin.yml` instead?


I will try, i have not internet connection on my home, i use the university connection, but is difficult to me do something on a laptop.


We don't care whether the certificate is not signed by a certificate authority that's in the iOS trust store or not.
In our case, we are pinning directly on the Open Whisper Systems CA. We don't have to pay for a third-party signature. Similarly, we don't validate the entire chain, we just make sure that it is signed by the Open Whisper Systems certificate authority. https://github.com/AFNetworking/AFNetworking/blob/master/AFNetworking/AFSecurityPolicy.m#L287


Would it be useful to state which toolboxes require it - or do you just want everyone to do these steps?


Have you read the history of #258? (BTW would it worth continuing the discussion there?)


Since I nuked the older visual studio projects, we do not need to support anything older than C99 anymore.  It's time to move on.


PrettyGridView (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Isn't that confusing. You say default is false and then the property is a nullable type...


@u55 The SymmetricalLogLocator would need to be handled differently; it is not just a matter of log or linear scaling.  That's why this functionality really should be in the Locator in the long run.  I am just trying to come up with a reasonable bug fix first, that will handle the great majority of cases.  I think that in fact the code I have here will work for the SymmetricalLogLocator, even though it is not customized for it.


Very nice!


OK. See 600e4b9.


Test for this would be nice - I am adding that as a chore in pivotal.


Nice, ready for PR?


As noted in the PR you'll only get the fatal error if PDO is not enabled on your server.


what's if we reload the config?


So this means the information is no longer present when a message is received. Should we at least add it to the headers?


sorry for the mistake.

I've force pushed another version that correctly defines BUILDOPT_HAWKEY_SACK_CREATE2.

Tested on Fedora 21.


А раньше автоподгружаемые связи составляли ключ и получалось что кеш не использовался если изменялся список подгружаемых связей...


IMPORTANT: "Open a **git** command prompt" ("Open Git Shell") ?


Do you mean the ABM providers or configuration?

On Mon, 2 Mar 2015 at 21:24 AbuBaniaz <notifications@github.com> wrote:

> It does. You are probably doing somthing wrong. Post the settings you are
> using on the forum so that people can replicate your issue
> .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/oe-alliance/oe-alliance-plugins/commit/b8da7a65712c095f8bf0910aaf43f7c653acbca5#commitcomment-9994404>
> .
>


r=pcwalton


Copy paste error. (note the negation is obsolete in obsolete ;) )


Чтобы в текущей сессии сразу иметь актуальные данные?


Thanks for the comment! It looks like this has been raised as an issue in the reflux bug tracker by someone else, and they're using your suggested solution. https://github.com/spoike/refluxjs/issues/265 hopefully this can be merged into reflux soon.


LGTM

Would be useful to have a reference to the reason if possible though - e.g., errata, empirical evidence, other limitations in the arm64 branch, etc.

In other words, is there a reason we might revisit this later on and consider removing the quirk?


All fixed up.  Sometimes I get lazy.. No disrespect intended.  I'll make
sure to do a better job giving credit where its due going forward.
On Mar 2, 2015 4:36 PM, "Scott Hart" <scott.hart.bti@gmail.com> wrote:

> My bad... One sec and I'll correct.
> On Mar 2, 2015 4:33 PM, "Davor Bertovic" <notifications@github.com> wrote:
>
>> Autorship please
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/scotthartbti/android_frameworks_base/commit/b70f4dff666bb506927ea6cfdbed58896c7d0554#commitcomment-9994586>
>> .
>>
>


Getter setter throw an exception?


w00t! thanks


why fully qualified reference?


Here as well


Why do you need to set VERILATOR_ROOT? It fails here with:
``Vdut.mk:59: ../../../verilator/include/verilated.mk: No such file or directory``
Removing it fixes the problem.


It's a design principle. "_data" is an internal implementation concern of DataObject and not part of the interface it publishes for external use. Article file data is intended to be accessed via getter functions instead, e.g. $articleFile->getSubmissionId() and $articleFile->getFileId(). To give it a metaphor, using _data directly is getting into your car using a screwdriver; sure, you can do it, but why bother when the keys are in your pocket?


Having the same problem as @soleares


Whoops, my mistake.


Another benefit of this approach is it cuts down on the number of specializations, which cuts down on the amount of generated code.


What about using ``-Wno-fatal`` instead of disabling warnings? You are not disabling all warnings anyway, so some code (like mor1kx) still causes the simulation to fail without ``-Wno-fatal``.


This is a bad merge from an old commit when it made sense.


Hoping I'm not screwing things up!


You should not call touch here
look at in the function updateCacheControl in lib/pf/config/cached.pm as an example of how to this in code


ack


sure thing, not sure if i should just move the include folder inside of a created ../usr folder, or move all the other folders inside of ../usr


OK


LGTM


We are mostly doing TryGets. Time to introduce a custom headers type?


2 other suggestions:

1. If this is important, a prerequisite perhaps move to the top
2. Perhaps also provide a link to the MDCS repo


LGTM, should be rolled into an earlier change


some tests failed:
failure: http://build.servo.org/builders/mac2/builds/1111


GasHumidifier (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-79.42%25-red.svg)


я бы предложил отказаться от использования 'init_action' в качестве примера в связи с тем, что этот хук может вызываться несколько раз при редиректах роутера и могу быть те, кто ожидают что он будет запущен только один раз. лучше "engine_init_complete"


LGTM, should be rolled into earlier change


average


Well, I just tried different things, trying to explore the bootstrap and html) as I understood we're styding now))


It works!


Sorry I forget to mention that I am using it against AsyncDisplayKit's table view which have different behaviour than UITableView when it come to move.

In UITableView, when warp in batched update, move uses the old array for from index and new array for to index.

In AsyncDisplayKit's table view, when wrap in batched update, move seems to act on the state of the array after remove and insert.

My finding will have to be double confirmed as I didn't do any test its mostly based on what I remember.

Also, if the same item (as defined by equality tests) is being insert into the array and cause duplicate, it can cause the delta result to not be accurate.

I just wrote an alternative, it is not efficient, but does try to avoid the 2 issues (false positive move/duplicate).

They are not thoroughly tested but did pass a simple unit tests.

```
    // Deleted
    NSMutableArray *newArrayMutableCopy = [newArray mutableCopy];
    NSMutableIndexSet *deletedIndices = [NSMutableIndexSet indexSet];
    for (NSUInteger i = 0; i < oldArray.count; i++) {
        id objectInOldArray = oldArray[i];
        NSUInteger indexInNewArray = [newArrayMutableCopy indexOfObject:objectInOldArray];
        if (indexInNewArray == NSNotFound) {
            [deletedIndices addIndex:i];
        } else {
            [newArrayMutableCopy replaceObjectAtIndex:indexInNewArray withObject:[NSNull null]];
        }
    }

    // Inserted
    NSMutableArray *oldArrayMutableCopy = [oldArray mutableCopy];
    NSMutableIndexSet *insertedIndices = [NSMutableIndexSet indexSet];
    for (NSUInteger i = 0; i < newArray.count; i++) {
        id objectInNewArray = newArray[i];
        NSUInteger indexInOldArray = [oldArrayMutableCopy indexOfObject:objectInNewArray];
        if (indexInOldArray == NSNotFound) {
            [insertedIndices addIndex:i];
        } else {
            [oldArrayMutableCopy replaceObjectAtIndex:indexInOldArray withObject:[NSNull null]];
        }
    }

    // Moved
    oldArrayMutableCopy = [oldArray mutableCopy];
    NSMutableArray *unchangedIndexPairs = [NSMutableArray array];
    NSMutableArray *movedIndexPairs = [NSMutableArray array];
    for (NSUInteger indexInNewArray = 0; indexInNewArray < newArray.count; indexInNewArray++) {
        id objectInNewArray = newArray[indexInNewArray];
        NSUInteger indexInOldArray = [oldArrayMutableCopy indexOfObject:objectInNewArray];
        if (indexInOldArray == NSNotFound) {
            // Ignore Inserted
            continue;
        } else {
            [oldArrayMutableCopy replaceObjectAtIndex:indexInOldArray withObject:[NSNull null]];
        }
        if ([deletedIndices containsIndex:indexInOldArray]) {
            // Ignore Deleted
            continue;
        }

        NSUInteger previousInsertedCount = [insertedIndices countOfIndexesInRange:NSMakeRange(0, indexInNewArray + 1)];
        NSUInteger previousDeletedCount = [deletedIndices countOfIndexesInRange:NSMakeRange(0, indexInOldArray + 1)];
        NSUInteger transformedIndex = indexInNewArray - previousInsertedCount + previousDeletedCount;
        if (transformedIndex != indexInOldArray) {
            [movedIndexPairs addObject:@[ @(indexInOldArray), @(indexInNewArray) ]];
        } else {
            [unchangedIndexPairs addObject:@[ @(indexInOldArray), @(indexInNewArray) ]];
        }
    }

    return [LXDelta deltaWithAddedIndices:[insertedIndices copy]
                           removedIndices:[deletedIndices copy]
                          movedIndexPairs:[movedIndexPairs copy]
                      unchangedIndexPairs:[unchangedIndexPairs copy]];
```


In fact guid have same size as pointer so copy more fast that reference.


The `0, false, null` makes me unhappy


remove one


Is there a #define for this 8192?


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/09358b908d937a3dfbb74a5bdcc083dbf2b1df1c


merging pcwalton/servo/text-shadow = 09358b90 into auto


pcwalton/servo/text-shadow = 09358b90 merged ok, testing candidate = 93d1f40a


We could add ARM64TODO into the panic message to differentiate it from an invariant we want to leave in


А почему бы не условится что если в параметре exportSQL не указан путь к дампам, то брать путь по-умолчанию ```Plugin::GetPath(__CLASS__) . '/data/```?


Дізнайтеся більше на сайті


I think you're looking for the stdint.h macros for sized constants. `UINT32_C(0xFF)`


Add ARM64TODO please for ease of tracking these TODOs


Качественное обновление


Done.


@dannon, I have no problems with this as long as it is easy to turn on for a system administrator (as opposed to auth module developer).  For the active directory plugin its quite useful information for configuring it correctly but it does disclose the module options (which contains the AD username/password for AD searching).  Given the logging information is now displayed using log.debug I guess there is not much need for the config option.


Not quite sure what the comment means, and does the XXX imply we have to change this?


Similarly here I think you were going for `UINT64_C(0xFF)`


Probably not super important, but should the legacy columns be deleted in other alter table statements?  I don't think it would break anything if not, probably they would just never get populated.


This commit fixes the issue that the bind-polymer directive stopped working after the initial link.
This was caused because in the second link, the attribute didn't have the value with the curly braces notation anymore. To fix this, we retrieve the bind expressions in the compile phase rather than the linking phase.


Overall seems reasonable with the caveats you've noted


Also I got rid of the own implementation to traverse expressions by using the Angular $parser. This returns both a getter and setter used in the MutationObserver.


this can be removed


But, but, it's not Christmas yet!


should roll into earlier commits


j


remove these three


На сьогодні подій не заплановано


Good work!


this has to be the first parameter


There has been some confusion about the scope setting for this directive, but as it relies on resolving expressions against the current scope, this is the only correct value for the scope attribute.


remove this...there's no reason for it to be here


If we're using this function, and we are also distributing the same code to .org, do we need to include a helper functions file or something so we don't break .org? /cc @nickdaugherty


`href=""` ?


ul in particular is OS dependent, like unsigned long.  Along with uint#_t, there are uint#_c(value) macros for sized literals.


Meant for issue #14.


I don't think this docstring is needed. If you want to keep it, make it a comment next to the for loop instead


The `false, `false, false, []` is also pretty cryptic here.
Consider adding a comment around this? Or perhaps a new method like Dependency.fromKey(key) that defaults all of these things would be good.


renew


this is a good docstring


@AlwinEsch: I don't know where you tested this but on win32 I got a warning that
```
CPVRChannel channel = pItem->GetPVRChannelInfoTag();
```
was forcing a boolean value from a non-boolean type. That means that it used the
```
CPVRChannel(bool bRadio = false)
```
constructor. Such constructors should really be defined with `explicit` to avoid such unobvious code. Did you intend to use that constructor or did you intend to get a copy of the original object?


Looks like that needs to be a `..`


Can't do that because the Voldemort code uses the package name "voldemort.*" (not "com.linkedin.voldemort.*" or anything like that), so calling any Scala package just "voldemort" causes import errors.


Do you mean similar to the `_classesCompat` above?


Remove colons("::").
The two following lines(golang, golang-go.tools) are not literal code block but list items.


It should be. Added.


please use href's like `{{ path("moderation_approve") }}`


Done.


The first sentence contains a grammar error, but I can't correct it without knowing original message that it tries to convey


nit: no space between range and (size)


To get picky, I would suggest:
```
For example, if you are storing an Object with three fields ("id", "name", and "price"), the corresponding
Hive table will have four columns: "rowkey", "id", "name", and "price".
```
+1 for having "three" and "four" spelt out instead of as numerals.


@bors: retry


windows :-1:


roll into earlier commit


for details. \["more" is redundant?]


Holly tits how long did this take?!


You don't need to keep creating new UmbracoHelper instances, this is already exposed by the base class (on nearly all umbraco base classes). Just do this.Umbraco.....


Should this be `url[0:6]`? Just stumbled over it, while looking at recent commits...


![feels good man](http://i0.kym-cdn.com/entries/icons/original/000/000/142/feelsgood.jpg)


as any of the fields in the object type.


Second one sounds good to me. The /usr folder is an artifact of dpkg extraction.


talked in person; redundant code deleted


Do this lat/lon thing for location questions as well, no more array responses anywhere.


nice


What family is 138? And why are these all level 0?


OK


not sure i understand this one. What's the original message?


roll up into earlier commit


Looks good to me. My only concern is the creeping `false, false, false`-style method signatures code smell, which could be refactored in some hypothetical future.


Interesting.  So this is for a sharded gazetteer?  I've always assumed our gazetteer would be efficient enough on a single index given the memory efficiencies of FSTs (what the Lucene "Memory" postings format uses).


@ChronoMonochrome I'm having problems with my kernel, I have just compiled mkaluza sources just as they were but I have a loop on samsung galaxy s advance written. Please, can you send me your kernel building script?


Ok, sounds great!  Yeah, it's trivial for the sysadmin to swap loglevel to/from DEBUG in galaxy.ini.  I'll go ahead and make these changes.


this doesn't seem to work with release 3.6.0, any ideas? https://gist.github.com/anonymous/4c200cdc3a987cf6b32c


Perhaps \[common]:
```
the corresponding Hive table will instead have the schema (name binary, id string).
```


I'd prefer if this didn't happen every time the page is hit. Can it be cached?


@ide Yeah, it worked perfectly for UITableView. Though for ASTableView it had quite a weird behaviour for me. :( It could be ASTableView issue though.


A few comments, otherwise LGTM.


Perhaps this should be implemented with nested lists?


You can also workaround the error by passing `--clang=1` like `npm install --clang=1`


straight reverting this seems to work... checking tests now


I think for backward compatibility it would be best if the old constructors still exist and call the new ones.


Does this speed up MySQL insertion as well?


wow so egocentrical


Steve,
  As far as I can tell, all of the functionality for the RunOfCards class is complete.  As you can see I added the functionality to handle runs of red and black threes and I made sure cards could be added to smaller runs.  With respect to the black threes one can only make a run when going out, but I found unnecessary complications trying to pass in a parameter which indicated going out or using an instance variable.  It is the job of the player to know when he is going out, so I decided to push that test up to the player class.  I am sure there are remaining optimizations I can do on my existing code and I think now would be a good time to give one pass to optimizing what I currently have.  In particular, you pointed out that my CardRunMethods module only serves my RunOfCards class unlike the CardSupport module which serves classes across three different games.  In addition, I have duplication in the RunOfCards class because I do not understand name spacing well enough.  I could not call any methods dealing with threes in the CardRunMethods module, so I had to duplicate checking for threes in the RunOfCards class.  I think the CanastaConstants Module makes sense even though it would only be used by the Canasta game, because it should just contain a bunch of constants unique to Canasta, but I could put those constants in a CanastaGame class but then I would have to rewrite my tests.  In addition, I am not sure if I should move any methods in the CanastaConstants module to some other location as anything titled constants should just be constants.  Any input would be more than welcome.


Would not rely on it that the AppKernel and the Application are in the global namespace.
I already have seen a bunch of applications moving the AppKernel to their own NS (OroCrm, graviton, ..)


Change use "note" admonition directitve.

```reST
.. note::
  Enabled to omit `import` statement for standard packages.
```


I have improved the strings in https://github.com/mixxxdj/mixxx/commit/2de306d9bc717b45ec6af4d62d60aa6389d0e84e

I was already about to add some notes to the manual, but I have not found a suitable place.
@esbrandt or @kain88-de: can you point out a place, where I can put it?

Should I remove the manual hint form the GUI? It is probably redundant, since the user should allways find more infos in the manual.


I deployed and this isn't working in production. I think it would be better to check: `document.location.pathname.length < 2`


no worries, it was changed.


Verify your email address :P


Should we update changelog? There is changelog page in the Settings.


Ah, yes, we'll want an HTML list.


I'll mention this only here but this applies for every else in this commit as well as other commits in this pull request.

Please remove the final qualifer on all local variables. During the early years in Java, there was increase of using final as a qualifier on local variables as a defensive mechanism. I believe that is now considered a bad pattern, at least I do. I would remove the use of it except where it actually makes sense. Instead of adding the final qualifier, I would prefer keeping the code blocks smaller to avoid making the mistakes that would necessitate this kind of defensive coding.

Similarly, this was intentionally written to blow up and throw `NullPointerException` when used in a manner that required you to provide defaultIfNull checks. The idea here is also to avoid defensive coding and instead provide a better API so that the null checks are not needed in the first place. In this particular case, what's more important is what creates this maps (ProducerConfigBuilder... ConsumerConfigBuilder...), as that's the API that is exposed to the user. If the API that is exposed to the user is allowing the user to write code that creates this kind of problems, then that's exposing a major flaw in those APIs and we should fix it there rather than defend against it here.


I don't know if [`userOrg`](https://github.com/bintray/gradle-bintray-plugin#buildgradle) property isn't also needed if there is an organization.


it's correct. either can be used.


Since `shape` is reminiscent of numpy, and we're closely allied with Python, why not `ndim`?


PR? :)

Med vänliga hälsningar / Best Regards,
*Erik Sandrén*

On Mon, Mar 2, 2015 at 10:44 PM, Daniel Rönnkvist <notifications@github.com>
wrote:

> Nice, ready for PR?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/danielronnkvist/quadproject/commit/24d1d0560c45464cb3c96561a0c84a2d2f5ef43d#commitcomment-9994810>
> .
>


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12179/testReport/) for this commit**


Broke the build :(
> SpongePluginContainer.java:68: error: SpongePluginContainer is not abstract and does not override abstract method shouldLoadInEnvironment() in ModContainer


Change to match the length of above line ("~" * 39).


This is an event for Bootstrap 3 and it will not work with Bootstrap 2.3.2 included in Joomla!
Proper events are

	.on('show', function(e){

	}).on('shown', function(e) {

	}).on('hide', function(e) {

	}).on('hidden', function(e) {

	});

To fix closing Modal with Tooltip in that Modal you have to add in each event

		if (e.target !== e.currentTarget) return;


 I don't mean that's a bug but just an additional suggestion .
 and  think the invisible npc shouldn't be considered into
 the cell_nostack effect. ^_^


Pull Request :+1:

Mvh,
*Daniel Rönnkvist*


We shouldn't need to do this. Collection data types for public methods should always be a generic interface type as opposed to a specific one whenever they are being returned or taken as a parameter.

Let's say I now need to change the internal implementation of getSentMessage() or of the database method that it calls, then I would also have to change every method that calls getSentMessage(). On the other hand, if we keep the List interface type, I'm free to change the internal list structure  to LinkedList, ArrayList, etc... because a specific type was not hard-coded. I think it's better if you change whatever is calling this methods to take a List instead of an ArrayList. Please let me know if this doesn't make sense.


+https://stat.ethz.ch/pipermail/r-sig-mixed-models/2007q3/000272.html
+http://www.r-tutor.com/
+http://www.inside-r.org/howto/applications-r-business-contest-detailed-instructions
+http://bioconductor.org/help/course-materials/2010/BioC2010/
+http://books.google.cl/books?id=F3tAehmRHSwC&printsec=frontcover&dq=Bioconductor+Case+Studies+by+Hahne&source=bl&ots=QXPXFe75Br&sig=5SDP9VJMycJghKEOS3DYAF1jtFY&hl=es&ei=X3KPTYiRBZKRgQe2noXBDQ&sa=X&oi=book_result&ct=result&resnum=2&ved=0CCcQ6AEwAQ#v=onepage&q&f=false
+http://cloudst.at/
+http://crdata.org/
+http://costaleconomist.blogspot.com/
+http://www.ef-prime.com/products/ranalyticflow_en/download.html
+http://www1.maths.lth.se/help/R/RCC/
+http://freakonometrics.blog.free.fr/index.php?
+http://www.inside-r.org/howto/fuzzy-hybrid-system-forecasting-time-series
+http://ereros.org/
+http://www.usar.org.es/programa.php
+http://ipsur.r-forge.r-project.org/book/index.php
+http://www.fort.usgs.gov/brdscience/learnR.htm
+http://machinelearning101.pbworks.com/w/browse/#view=ViewFolder&param=References%20for%20R
+http://www.r-bloggers.com/making-rs-paste-act-more-like-concat/
+http://stackoverflow.com/tags/r
+http://planetr.stderr.org/
+http://halweb.uc3m.es/esp/Personal/personas/jmmarin/esp/Progra/SobreR.html
+http://quantlib.org/index.shtml
+http://www.statmethods.net/
+http://sphaerula.com/legacy/R/index.html
+https://github.com/languages/R
+http://developer.r-project.org/
+http://cran.r-project.org/doc/FAQ/R-FAQ.html#R-Web-Interfaces
+http://processtrends.com/TOC_R.htm
+http://www.oga-lab.net/RGM2/func.php?rd_id=zoo:rollapply
+http://www.oga-lab.net/RGM2/images.php?show=all&pageID=531
+http://www.stat.auckland.ac.nz/~paul/plaudits/plaudits.html
+http://en.wikibooks.org/wiki/R_Programming
+http://www.r-bloggers.com/RUG/
+http://bloguit.com/pfv19751007/wp-login.php?loggedout=true
+http://www.math.ncu.edu.tw/~chenwc/R_note/
+http://errefuralle.1espacio.com/users/sign_in
+http://errefuralle.1espacio.com/
+http://www.mail-archive.com/r-help@stat.math.ethz.ch/
+http://rapache.net/
+http://groups.google.com/group/rdatamining
+http://www.rdatamining.com/
+https://github.com/RevolutionAnalytics/RHadoop
+http://www.rgraph.net/index.html#intro
+http://rpad.googlecode.com/svn-history/r76/Rpad_homepage/index.html
+http://sas-and-r.blogspot.com/
+http://www.wekaleamstudios.co.uk/about/
+http://www.squirelove.net/r-node/doku.php
+http://statisfaction.wordpress.com/
+http://rapache.net/index.html
+http://rgarch.r-forge.r-project.org/index.html
+http://definetti.uark.edu/~gpetris/dlm/
+http://www-stat.stanford.edu/~tibs/ElemStatLearn/
+http://www.datanalytics.com/blog/2011/12/23/%c2%bfnos-leemos-the-elements-of-statistical-learning-de-tapa-a-tapa/comment-page-1/#comment-5419
+https://github.com/reading-esl
+http://www.jjgibaja.net/
+http://www.burns-stat.com/pages/spoetry.html
+http://esl.ubidata.org/
+http://www.ceremade.dauphine.fr/~xian/
+http://demo.usar.org.es/
+http://pairach.com/2012/02/26/r-tutorials-from-universities-around-the-world/
+https://github.com/jeffreybreen/tutorial-201203-big-data
+http://jeffreybreen.wordpress.com/2012/03/10/big-data-step-by-step-slides/
+http://heuristically.wordpress.com/
+http://www.r-es.org/
+http://www.ggobi.org/
+http://prezi.com/wkkftr7hmsnt/bugs-en-r/
+http://planet-r.org/
+http://systematicinvestor.wordpress.com/
+http://r-spatial.sourceforge.net/gallery/
+http://pj.freefaculty.org/R/Rtips.html
+http://rconvert.com/
+http://userwww.service.emory.edu/~djachoc/
+http://wiki.stdout.org/rcookbook/
+http://www.rhipe.org/getpack.html
+http://otexts.com/fpp/
+http://www.census.gov/srd/www/x12a/
+http://rdotnet.codeplex.com/
+http://zoonek.free.fr/blosxom/R/2012-06-01_Optimization.html
+http://rparatodos.wordpress.com/paquetes/crear-paquete/estructura/
+http://rparatodos.wordpress.com/
+http://www.rpubs.com/
+http://pairach.com/2012/06/06/r-style-guide/
+http://www.bio.umontreal.ca/numecolr/
+http://www.r-es.org/Documentaci%C3%B3n&structure=Comunidad#Materiales_Proyecto_R_UCA
+http://rbresearch.wordpress.com/
+http://www.revolutionanalytics.com/what-is-open-source-r/r-language-features/
+http://www.grserrano.es/
+http://www.grserrano.es/wp/
+http://www.portfolioprobe.com/
+http://ryouready.wordpress.com/
+http://analisisydecision.es/
+http://www.gutierrezandres.com/
+http://www.datanalytics.com/blog/
+http://www.sigmafield.org/
+http://codealamode.blogspot.com.es/
+http://www.r-es.org/Comunidad
+http://freakonometrics.blog.free.fr/
+http://onertipaday.blogspot.com/
+http://www.statmethods.net/index.html
+http://www.mayin.org/ajayshah/KB/R/
+http://knuth.uca.es/R/doku.php
+http://en.wikibooks.org/wiki/R_Programming/Text_Processing
+http://www.inside-r.org/
+http://jmr.r-forge.r-project.org/
+http://fishyoperations.com/
+http://www.rexeranalytics.com/index.html
+https://wiki.helsinki.fi/display/mathstatKurssit/Data-analysis+with+R,+fall+2010
+http://search.r-project.org/cgi-bin/namazu.cgi
+http://sas.uwaterloo.ca/stats_navigation/StatSoftware/R/statsRus.htm
+http://www.spatstat.org/spatstat/
+http://gallery.r-enthusiasts.com/
+http://mc-stan.org/index.html
+http://bayes.squarespace.com/bmr/
+http://www.portfolioprobe.com/user-area/some-hints-for-the-r-beginner/
+http://www.sr.bham.ac.uk/~ajrs/index.html
+http://thebiobucket.blogspot.com/
+http://procomun.wordpress.com/2011/02/23/que-es-r/
+http://r-es.org/IV+Jornadas
+http://mazamascience.com/WorkingWithData/
+http://r-pbd.org/
+http://little-book-of-r-for-multivariate-analysis.readthedocs.org/en/latest/src/multivariateanalysis.html
+http://jason.bryer.org/sqlutils/
+http://gking.harvard.edu/readme
+http://r-es.org/Documentaci%C3%B3n
+http://mathesaurus.sourceforge.net/octave-r.html
+http://lincolntneves.weebly.com/1/post/2013/04/estatstica-multivariada-qual-tcnica-devo-usar.html
+http://www.agrocampus-ouest.fr/igagrocampus-ouest.fr/math/RforStat/
+http://www.econometricsbysimulation.com/
+http://www.wiley.com/WileyCDA/Section/id-302388.html
+http://bayes.bgsu.edu/bcwr/
+http://www.netstorm.be/
+http://yihui.name/en/
+http://www.noamross.net/blog/2013/4/25/faster-talk.html
+http://www.ats.ucla.edu/stat/r/faq/default.htm
+http://www.manning.com/zumel/
+http://darrenjw.wordpress.com/2011/01/01/calling-java-code-from-r/
+https://dl.dropboxusercontent.com/u/62560154/cursoR_AIL/introduccion.html#/
+http://appliedpredictivemodeling.com/
+http://journal.r-project.org/archive/
+http://www.datamind.org/#/
+http://www.r-statistics.com/
+http://www.edii.uclm.es/~useR-2013/
+http://www.biz.uiowa.edu/faculty/jledolter/datamining/
+http://www.computerworld.com/s/article/9239799/60_R_resources_to_improve_your_data_skills
+http://www.rdatamining.com/home
+https://github.com/stevengj/PyCall.jl
+http://rportable.sourceforge.net/
+http://www.rinfinance.com/
+http://www-personal.buseco.monash.edu.au/~hyndman/Rlibrary/forecast/forecast/00Index.html
+http://tur-www1.massey.ac.nz/~pscowper/ts/
+http://www.rmetrics.org/
+http://addictedtor.free.fr/graphiques/
+http://alnitak.u-strasbg.fr/~wraff/RReportGenerator/index.php
+http://code.google.com/p/sqldf/
+http://www.statistiklabor.de/en/
+http://www.r-project.org/conferences/useR-2008/
+http://www.statistik.uni-dortmund.de/useR-2008/abstracts/AbstractsByTopic.html#Econometrics%20&%20Finance
+http://www.stat.pitt.edu/stoffer/tsa2/
+http://halweb.uc3m.es/esp/Personal/personas/jmmarin/esp/ManualR/PRINCIPAL.htm
+http://www.cuddyvalley.org/psychoR/
+http://preprints.stat.ucla.edu/index_body.php?sort=preprintID&order=DESC&where=+WHERE+authors+LIKE+%27%25leeuw%25%27+&count=60&limit=60&position=0&collapse_search=false&collapse_sort=false&display_authors_string=leeuw&display_title_string=
+http://scc.stat.ucla.edu/
+http://www.meetup.com/LAarea-R-usergroup/es/
+http://forums.stat.ucla.edu/?5
+http://idisk.mac.com/jdeleeuw-Public?view=web
+http://rseek.org/
+http://code.google.com/p/r-orange/
+http://had.co.nz/ggplot2/
+http://www.stat.ucla.edu/~jeroen/
+http://yeroon.net/lme4/
+http://vps.jeroenooms.com/stockplot/
+http://rosuda.org/iPlots/iplots.html
+http://cran.r-project.org/web/views/
+http://www.deducer.org/
+http://www.stochas.org/
+http://www.stat.columbia.edu/~gelman/arm/examples/
+http://colorbrewer2.org/
+http://lists.hmdc.harvard.edu/lists/zelig/
+http://public.me.com/jdeleeuw
+http://www.drewconway.com/zia/?p=1762
+http://gking.harvard.edu/zelig/
+http://www.bioconductor.org/docs/install/
+http://www.r-project.org/useR-2006/Abstracts/index.html
+http://www.liaad.up.pt/~ltorgo/DataMiningWithR/
+http://www.omegahat.org/RMatlab/
+http://www.sciviews.org/SciViews-R/index.html
+http://rcom.univie.ac.at/
+http://www.quantmod.com/
+https://nurometic.com/
+http://www.r-bloggers.com/
+http://www.joeconway.com/plr/
+http://www.vcasmo.com/user/drewconway
+http://learnr.wordpress.com/
+http://journal.r-project.org/index.html
+http://www.red-r.org/
+http://www.red-r.org/downloads
+http://inside-r.org/
+http://www.stats.ox.ac.uk/pub/MASS4/
+http://stotastic.com/wordpress/2010/05/basket-option-pricing/
+http://stotastic.com/wordpress/
+http://rosettacode.org/wiki/Main_Page
+http://crantastic.org/
+http://bm2.genes.nig.ac.jp/RGM2/index.php?clear=all
+http://blog.ynada.com/
+http://manyeyes.alphaworks.ibm.com/manyeyes/
+http://blog.revolutionanalytics.com/
+https://www.rmetrics.org/blog
+http://r4stats.com/
+http://www.stats.uwo.ca/faculty/yu/Rmpi/
+https://r-forge.r-project.org/
+http://www.shogun-toolbox.org/doc/index.html


@Enigmatologist this one?


Don't worry, it might take that long to finish this! :)


Jaha! Jepp! ill doit


I'm now curious which way Babble is going. To me Babble should not include anything vip related. Or is it time for me to find another translation plugin?


this test needs a test ...
it is way too complicated, pls keep in mind that a test is
- short (init SUT, run single operation, validate result)
- deterministic in what to be validated
- independent


Questions about rabbitmq java client's automatic connection recovery... how does it work the Shutdown Listener based connection recovery we had already implemented in this project?

While rabbitmq official java-client's automatic connection recovery is probably preferrable, what we had has been production tested. So I'm a little nervous to add this in without extensive testing in production.


Should be an array of references to the orders schema. Similar to this:
[{type: mongoose.Schema.Types.ObjectId, ref: 'Order'}],


Again similar to how we did it for the previous, except this will be an array of references to the Product schema


defining a dataProvider for one entry is kind of an overkill ;)


Also please make sure to keep formatting consistent with the rest of the project.


Yes, that's what this change does. In my tests there was a minimum speedup of six times, rising to 250 times when the database wasn't in the same physical location as the minecraft server (it's still slower when they're separated, but a **lot** less slower than it used to be)


Not sure how this is any less blocking? Can you explain what you are trying to do here and what problem you are trying to avoid?


Why only report 31 bits per counter, instead of all 32?

On Mon, Mar 2, 2015 at 1:31 PM, Scott Schurr <notifications@github.com>
wrote:

> Here's a micro optimization. Given my understanding of the standard, if
> you declare these two numbers static they are more likely to be inlined in
> those calculations that use them. That removes a couple of memory
> references so those calculations may run a bit faster. But you will have to
> declare storage for the statics in SHAMap.cpp so it's a slightly more
> invasive change.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mtrippled/rippled/commit/3402005f0a2e9672ffaa4bd3ac56c3fcf5c9a605#commitcomment-9994531>
> .
>


@lxcid I believe it isn't documented anywhere how UITableView moves rows in a batched update so I think you're right that ASTableView behaves differently. But I think the ASDK developers want ASTableView to be a drop-in replacement for UITableView so they might be interested in learning about this difference in behavior if you open an issue with them.


Koristis syntaxu koja vrijedi u svim Rubyima za hasheve:

```ruby
:default => '1900-01-01'
```
Ta sintaksa se zove hash-rocket

Od Rubya 1.9.3 (ranije od tog neces koristit a neces ni nju, trenutno je vani Ruby 2.2.1) postoji syntaxa za hasheve u sljedecem obliku koja je lakse citljiva:

```ruby
default: '1900-01-01'
```

Nju mozes koristiti kada imas za hash keyeve symbole ( a to je najcesci case). Da ti je hash key string, svejedno bi koristio hash rocket:
```ruby
'default' => '1900-01-01'
```


@anikalindtner all we need to add are the image sources! (except for the map, I guess).
And otherwise I think we can :shipit:

:tada:


Thanks


I kinda tested both and this is the one that ended up working in both phpunit and travis...

I didn't really follow up after tests and smoke screening where both ok. I'll "prod" it on api-ci and we'll know ;)


Inace, ovaj commit message koji si napravio nije deskriptivan.

Ovdje bi bolji bio commit message tipa: 'Add temp_admin column to User.' Nisam siguran zasto je i ona dvojka na kraju imena klase,


You are right this is a problem, with or without the RunOnUiThread. It's correct that you can't show a dialog from a BroadcastReceiver. The reason is that the context provided to onReceive does not support showing a dialog. However the dialog is shown by the context *mActivity* which is accessible because the BroadcastReceiver is an anonymous inner class of *NowPlayingFragment*. This is actually bad, we shouldn't hold on to a reference to the activity.
But it's gets worse! This functionality is currently not working because when the server is not connected is starts the *DisconnectedActivty* and the BroadcastReceiver check for that in it's onReceive (*isManualDisconnect*).
So we have two options
1. Remove this functionality completely, as it is not currently working, and we haven't (at least that I know of) had any complaints about it.
2. Refactor the BroadcastReceiver to be a top level class and register, and only have it registered when we are waiting for a network connection.

However none of this is related to the commit at hand.


aahhhhhhh ...... okay I never understood teardown, thought this is kind of a function that creates variables or whatever is needed between different test cases, dunno how that should work... but now, I blame myself :O


@unRob Hola, oye.. Probaste algún caso en especial en el que se diera que el parámetro no viene? Es que logro pensar en dos escenarios:
1: Si se hace un get a /semovi_taxis sin incluir el parámetro del :id, entonces la acción que se ejecutaría sería la del index y no la del show, por lo que no entraría a este método.

2: Si por alguna razón, se redirigiera específicamente a la acción show de ese controlador, sin pasarle el parámetro tronaría antes, porque la ruta del show le dice que siempre va a tener el parámetro :id por lo que tampoco entraría a este método y tampoco evaluaría esa condición. Lanzaría un error como este: No route matches {:action=>"show", :controller=>"semovi_taxis"} missing required keys: [:id]

Ahora, que más bien habría que probar que el parámetro está presente y no es un string vacía, por ejemplo. Pero no sé, quizás tú tienes en mente otro escenario ?


little bit macro magic going on here. shouldn't be a problem.


Also, this is "just" in the Test folder, so for now it will do.


I just figured it out.  The condition evaluates to true, but when we try to update the href it references a non-existent page element.  Specifically, `$("#firefox_link")` and `$("#chrome_link")` don't exist on the main page.


Thanks, removed!


Je oma heeft een massa van een 1000 manen


Hi Mark, I'm honestly not very excited about adding these four constructors.  As far as I can see the only downside of not having these constructors is that someone with a `std::atomic` in their hands must call `atomic.load()` in order to construct a `Json::Value`.  I'm hopeful that we won't have enough atomics in the system for that to become a serious problem.


Generalno je dobra praksa imat kod na engleskom napisan. Ako i to zanemarimo, ovdje ti '@zahtjevi' varijabla mozda ne treba posto je ona uvijek 1. I vjerojatno ni na hrvatskom nije njen naziv bas dobar, vjerojatno bi bilo bolje 'broj_zahtjeva' ili sl (pretpostavljam da se o tom radi).


Oops - it fixes #902, not 901.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/897
success: http://build.servo.org/builders/linux2/builds/895
success: http://build.servo.org/builders/android/builds/933
success: http://build.servo.org/builders/mac1/builds/1112
success: http://build.servo.org/builders/mac2/builds/1112
success: http://build.servo.org/builders/gonk/builds/83


I am not sure I understand when a node needs a mapping. Consider adding a comment explaining conditions when the mapping is needed.


Okay, I agree that the Locator classes should really implement their own tolerance handling.

I checked this patch on my computer, not against master but against version 1.4.3, and it works correctly for the use cases that were previously causing me problems.  The fix looks good to me.  Thank you very much @efiring.


Perhaps leave the $fail check and error printing outside the function.  In other words just have check_machine_image() set fail=yes (or not).  Then outside the function test $fail and $force and print the error message.

Looking at your other commit for the Accton specifics it looks like this would eliminate some redundant code.

That way everyone can share the same error printing.  Of course a custom function could also print additional error messages if necessary.


Done, I've added a verbose parameter to hide all those warnings (you can enable them with -Ob verbose True)


@unRob esta expresión la construiste bajo algún requerimiento en especial ? Tengo entendido que debe comenzar con a, b o m y terminar con 5 dígitos. No encontré dónde se especificaba esto.. examinaste el wsdl ?


Why is protected used here and not private? I'm not quite seeing the use of the protected visibility in controllers.

Looking forward to seeing the answer. Thanks


this ready for serious expansion ;)


It feels like we can look too far up the hierarchy.


@markoheijnen I hope you won't end up feeling that way. You'll notice this isn't merged yet, so perhaps not time to abandon ship yet :smile: We're code reviewing stuff now, and looking at ways we can improve the code, which I hope we can agree is a good thing, and will help everyone. We'll be looking to a way to minimise, or remove altogether, any VIP specific requirements on the .org codebase. Do keep holding us to it, and do keep mentioning when you see stuff that concerns you. Is that OK?


@sibivk -I updated the OpenLdap example to do authentication-only, instead of search first.  Maybe need something similar for AD


Luckily enough JavaScript does have a `String#split()`, so you could write this code more concisely as:

```javascript
return entry.split(': ')[1]
```


I have problem with importing I have downloaded this version: V1.7.5-Aniways-V2.3.11
also download aniways from there: http://www.aniways.com/platforms/2/downloadSdk
I change aniways this folder "AniwaysResourcesProject" to "Android-SDK".
and i also pasted "libs" to telegram project "libs" files.

When i import V1.7.5-Aniways-V2.3.11 to Android Studio i face this error:
Error:
(Configuration with name 'default' not found)
![error](https://cloud.githubusercontent.com/assets/10077500/6452106/c932f9b6-c14c-11e4-82ce-9af54ab30f9c.png)

How to solve this. can you provide me full source code with Android-SDK working files?


@darioizzo I just checked this for the new build system and works like a charm. Are you planning a release of PaGMO soon?


Najcesce ti ne trebaju protected metode (vec private), dosta je to drukcije od tog kako u Javi funkcionira. Bas sam prosli tjedan odrzao predavanje na internim Ruby Talksima o tome, pogledaj ovdje slajdove: http://slides.com/damirsvrtan/ruby-talks-1#/. Mozemo uzivo o tome prodiskutirati.

Znam da si ovo vjerojatno vidio iz Deviseovog README-a, neznam zasto im je tako napisano.


fast-forwarding master to auto = 93d1f40a


75127368_DCFSEC (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


c ES -> -ER
c -(-ES v -ER)
c ES a ER

9 0
3 0


Kad nesto u Rubyu ispitujes sa if-om, jedino sto ti moze vratiti false vrijednost su 'false' i 'nil'.

Ovdje si mogao napisat npr. `if current_user`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12180/testReport/) for this commit**


Sort of. `_classesCompat()` seemed a bit odd to me too.

Instead of:
```js
this._addClass( "ui-droppable-hover" );
```
You could have:
```js
this._addHoverClass();
```
and:
```js
_addHoverClass: function() {
    this._addClass( "ui-droppable-hover" );
}
```
Then you can just:
```js
_addHoverClass: function() {
    this._super();
    if ( this.options.hoverClass ) {
        this.element.removeClass( this.options.hoverClass );
    }
}
```
And everything will be very straight-forward and there won't be other logic bundled in (not to mention not needing to run through the accept logic multiple times).


Seems simple enough.


great! thanks a lot


Ah, different branch. Didn't saw the branch name ^^. I will look at what you guys are doing, you know me right? ;). But good to see some code reviewing.


Looks good! You got the idea.


Give me specific and concrete modules that have this issue.


I added those constructors to make it easier to work with atomics and JSON.
I don't think they cause harm in terms of taking up space or cycles if not
used, do they? I guess there's function call overhead instead of calling
.load() directly. Is that your concern?

On Mon, Mar 2, 2015 at 2:23 PM, Scott Schurr <notifications@github.com>
wrote:

> Hi Mark, I'm honestly not very excited about adding these four
> constructors. As far as I can see the only downside of not having these
> constructors is that someone with a std::atomic in their hands must call
> atomic.load() in order to construct a Json::Value. I'm hopeful that we
> won't have enough atomics in the system for that to become a serious
> problem.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mtrippled/rippled/commit/2a2cf5b5cfe118bafabcee429ed8cfdccfa86beb#commitcomment-9995453>
> .
>


(s)brk < mmap


saw approval from pcwalton
at https://github.com/glennw/servo/commit/f68386f0fa9dfe79deb8a73f45a93afe40f2561d


merging glennw/servo/iframe-vis-fix = f68386f0 into auto


glennw/servo/iframe-vis-fix = f68386f0 merged ok, testing candidate = 891dd496


* needs moar tests :D
* I'll split the ``call_user_func`` silliness into simpler things with more provider use
* that should take care of indepentizing each method call


HVACSizingSim_CoincidentPlant (EnergyArchmage) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.87%25-red.svg)


Sto oznacava temp_admin, nekakav datum? Vjerojatno bi ti bolje dosao neki drugi naziv ovdje, ako mi otkrijes sto mislis ovdje mozemo nesto bolje smislit :)


It feels like every time we do a release, it becomes harder and harder to get the partests to pass. They tend to just run out of memory from being contended with their parallelization + other workers on the same node. :-(
Anyway, eventually they'll all pass, after a sufficient number of restarts ^^


Only suggestion here is re: formatting. Conventionally, if you add a new line after the starting curly brace for a function body `{`, you should also put the ending brace on its own line.

Revised, it would look like this:

```javascript
console.log(favoriteAnimal(function(sentence) {
  return sentence.replace("animal", "aardvark")
}) === "aardvarks are the best!");
```


I tried to stick to the naming convention of using `axis` as the word for an actual...axis itself, and `dimension` or `dim` as a shape element (i.e., the size of a particular axis), so under that convention `num_axes` or `naxes` makes more sense to me.  (And aesthetically I prefer the written out `num_axes` over the abbreviated names.) But I agree that `ndim` is more universal.

Anyway, I'll change it if you still prefer, let me know.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12181/testReport/) for this commit**


yes, you are right. I will fix that in the next PR.


@lapistano thanks for the review so far, I'll take care of these ``<1``.


Koje sve statuse moze jedno oruzje poprimiti? Vjerojatno bi ih dobro bilo sve popisati i staviti u enum: http://edgeapi.rubyonrails.org/classes/ActiveRecord/Enum.html


75127368_DCFSEC (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1619 of 1625 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


Looks fabulous. I heartily approve! :shipit:


My thinking was that if someone had extended `DeviseController`, they would expect these methods to be public and could be depending on them.

If we made them private, that would break all such code.  So, I figured making them protected would allow anyone using them in an inherited controller to still have access, but they'd no longer be actually public.

I have very little experience with devise, so I might be being overly paranoid.


Redo


with pleasures


> I waited more than 1 week for node 0.12

They've added it 6 days after the release (http://help.appveyor.com/discussions/suggestions/559-add-nodejs-012) but from what I see this was one of the longer delays.

> Anyway, being that AppVeyor is generally Uber slow I'm trying to keep
things simple first.

That is a problem, indeed. :/ Not only slow execution but time spent in a queue is enormous.

Anyway, your argument was that installing the latest is slower which is not the case. Slow installation was made using the `Update-NodeJsInstallation` command that was performing an actual downloading & installation; this was fixed by switching to `Install-Product node` in https://github.com/gruntjs/grunt/commit/09f8fc498b570ef1ed8f8e61a5ef63efef82fc76.

io.js doesn't have any LTS releases yet, only the latest one is supported so IMO it doesn't make sense to test on older ones than latest provided by AppVeyor.


http://vignette1.wikia.nocookie.net/epicrapbattlesofhistory/images/c/c9/GIF.gif/revision/latest?cb=20150203184545

On Mon, Mar 2, 2015 at 1:13 PM, Nate Holland <notifications@github.com>
wrote:

> You should probably write some tests.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nherson/spaz/commit/ab3cbe7feb89544e90b5d5b6773a2426f0c52bfa#commitcomment-9994192>
> .
>


All looks good! No improvements to be made.


haha just read your comment again and got the point now, didn't work well in a phone browser ;)
all FileItem tags were copies and that got changed, so it didn't need an explicit constructor.

just change this one to this should the trick?
```C++
CPVRChannel channel(*pItem->GetPVRChannelInfoTag());
```


saw approval from aberghage
at https://github.com/basho/yokozuna/commit/a2e9ce70cc6d932f6dbba5689f4fa3be2c5bb2b9


merging basho/yokozuna/bugfix/im/handle-get-ring-timeouts = a2e9ce70 into borshop-integration-458-bugfix/im/handle-get-ring-timeouts


basho/yokozuna/bugfix/im/handle-get-ring-timeouts = a2e9ce70 merged ok, testing candidate = 32f8c6eb


Got it: https://github.com/dariomanesku/cmftStudio/commit/46ed1d87cad0ba873cd1fb38e56309b8e294e14e


Why declare a `vector` when you only use an array? (Alternatively, keep the vector, expose a vector accessor from `Blob`, and use `vector`'s constructor instead of a loop.)


Well as long as it works with prototype chain. That was basically something I wasn't/am not sure of.


what kept you from using a dataProvider?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12182/testReport/) for this commit**


private methods are also inherited in Ruby, so there's no reason for making them protected. The difference is that you can call protected methods from the scope of any object belonging to the same class.

I don't know why that would be useful in the case of controllers, so i think this should be private. As well as other stuff noted in the README.


In C++ the use of the preprocessor should be avoided as much as possible. Please use the `const` keyword instead.


This is a great... thanks for the feature. And the included tests. Can you also add some documentation? Plus stick to the existing coding conventions within the project (formatting, no prefixing class variables with underscores, etc..)


I won't push tonight, I've tried to get feedback on IRC but now I have to many choices:
{{{
* Underground78 is on ##English to figure out what to do
<Underground78> <ianp> abridged is pretty much only used for books (and dictionaries)
<Underground78> <Underground78> hmm ok
<Underground78> <ianp> outside of that, it's not really used
<Underground78> <ianp> Underground78: one common way of naming that is an "advanced" menu and a default menu
<Underground78> <kimspindel> Underground78: ah, hmm - yeah, what ianp said
<Underground78> <kimspindel> maybe "condensed"
<Underground78> <ianp> The default is the simpler options, the "advanced" menu, or "full" menu, contains more
* x-euro-x (~x-euro-x@201.21.137.151) vient de rentrer
<Underground78> <ianp> I would rather use the word 'shortened' than 'abridged' probably, if it's not a book, but it wouldn't be used for menus really...
<Underground78> <ianp> in practice
<Et0h> I agree, 'abridged' is only used in relation to literature and a few other specialist uses.
<nanashio> Another possibility is limited/full
* Spec-Chum (~Spec-Chum@0546e90e.skybroadband.com) vient de rentrer
<Et0h> Or 'simple' / 'basic'.
<Underground78> hmm yeah that's another possibility
<Et0h> I mean, 'simple' and 'basic' on the one hand. For the full one it could be 'extended', 'full', 'advanced'.
}}}


hmm... should I plop everything in ``Tests`` into ``namepace GravitonVcapBundleTests;``?

That might make sense.


I won't push tonight, I've tried to get feedback on IRC but now I have to many choices:

```
* Underground78 is on ##English to figure out what to do
<Underground78> <ianp> abridged is pretty much only used for books (and dictionaries)
<Underground78> <Underground78> hmm ok
<Underground78> <ianp> outside of that, it's not really used
<Underground78> <ianp> Underground78: one common way of naming that is an "advanced" menu and a default menu
<Underground78> <kimspindel> Underground78: ah, hmm - yeah, what ianp said
<Underground78> <kimspindel> maybe "condensed"
<Underground78> <ianp> The default is the simpler options, the "advanced" menu, or "full" menu, contains more
* x-euro-x (~x-euro-x@201.21.137.151) vient de rentrer
<Underground78> <ianp> I would rather use the word 'shortened' than 'abridged' probably, if it's not a book, but it wouldn't be used for menus really...
<Underground78> <ianp> in practice
<Et0h> I agree, 'abridged' is only used in relation to literature and a few other specialist uses.
<nanashio> Another possibility is limited/full
* Spec-Chum (~Spec-Chum@0546e90e.skybroadband.com) vient de rentrer
<Et0h> Or 'simple' / 'basic'.
<Underground78> hmm yeah that's another possibility
<Et0h> I mean, 'simple' and 'basic' on the one hand. For the full one it could be 'extended', 'full', 'advanced'.
```


Dont you use LTEv.2 here?


@markoheijnen New idea, better idea (I think): https://github.com/Automattic/babble/issues/216


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12183/testReport/) for this commit**


Do we need to hold on to the entire message in memory? Looks like we're only using the delivery tag for that message and never re-looking up the message at any point.


nice


Can we make this customizable? Can we allow a scheme?


Ova metoda bi pripadala user klasi a ne kontrolleru, tako da mozes pitat `user.overdue?`.

Npr ljepse bi tamo bila napisana na nacin:

```ruby
def overdue?
	user.weapons.any? do |weapon|
		weapon.status != 0 && weapon.borrowed_at + 1.month < Date.today
	end
end
```


In general OO visibility, `protected` denotes that the methods are available to be overridden by the subclasses, that was probably the initial intent of the existing methods being protected here. In Ruby `private` allows the same, so in practice in Ruby this OO visibility distinction does not exist, so it actually doesn't matter much in this case, as long as they are not public :).


Sad neznam jesam li pospan ili lud, al zar nebi bilo overdue ako je weapon.borrowed_at + 1.month VECI od Date.today a ne obrnuto? :)


I'll go ahead and stick my nose in this conversation.  I don't, personally, have a problem with Mark thinking of `fetchDuration` as a counter of microseconds.  But I can also sympathize with Micky's position, especially since the name `fetchDuration` sure sounds like it ought to be modeling a `std::duration`.  Mark, since you're counting microseconds, perhaps the name should reflect that?  For example, `fetchMicrosecs` might track `fetchBytes` well.


Isn't this PR just playing with canvas and the only websockets is the inclusion of the library.. this is a commit message failure..


Here on linux was no warning about it.

Was to have a copy of channel.


:smile: :palm_tree:

when-you-see-it.png


Ofast turns on fast-math btw (if Ofast is to be the default)


@ajurasz BTW I propose to use Groovy whenever possible. Groovy is cool :)


Use built-in `zip` instead. It has the proper meaning as you need in Py3k, and it is explicitly set to `itertools.izip` for Python 2.


84692518-Markdown-Documentation (kbenne) - Win64-Windows-7-VisualStudio-12: OK (1620 of 1620 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Utils.sleep is going to block.

Why did you get rid of the while? It was there to ensure that all the messages that were prefetched from RabbitMQ got emitted immediately.

This is not only blocking, it's going to block longer due to incrementing of nextTupleCallsWithoutMessage.


Excellent change, just calling `getNodeStore()` once.


@ajurasz I plan to donate this Paho [1] component to the Camel upstream. There is existing MQTT [2] component, but it supports only consumer and uses some less popular MQTT library. Paho component will get much wider adoption.

[1] https://eclipse.org/paho
[2] http://camel.apache.org/mqtt.html


Well, interesting, but are you sure?


yup


I think we prefer explicit initialization like `= { NULL }` -- though it's not really important as statics are implicitly initialized.


¿EN SERIO?

Voy a irme a la casa de mi güela en Llanes y dedicame a la agricultura. Avisa mañana a Victor.


e


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/991


I am transforming now links to path() function and indentations problems.


Is `names_b` ever needed? I'm not sure whether `node_b in self.names_b` check below is necessary.


I would narrow that denotion to Java and similars, and would love to practice Ruby in all cases -> basically never use `protected` in any case (except for the almost only case where people should use protected, for comparing objects). Guess that many people who are beginning with Ruby get a general thought that method visibility in Ruby is the same as in Java, and would love to clear that stuff out in a way that Devise doesn't use the `protected` keyword in its documentation and code.


@mtwebster thanks for the heads-up. I will try it soon.


(the extra comma is unnecessary and invalid C89 -- what do you mean, "pedantic"? :D)


The difference between `protected` and `private` is that you cannot call a private method on `self` and since this change is changing the visibility of these methods, anyone use `self.` would experience a breaking change if we were to make them private.

Consider:

```ruby
class Base
  def non_public
    "base"
  end
end
```

I subclass:

```ruby
class Child < Base

  def doit
    puts "Hello #{self.non_public}"
  end
end
```

Now, `Base` changes to use `private`

```ruby
class Base

private

  def non_public
    "base"
  end
end
```

`Child` is now broken:

```
2.1.0 :017 >   Child.new.doit
NoMethodError: private method `non_public' called for #<Child:0x007f974a20c450>
	from (irb):13:in `doit'
	from (irb):17
	from /Users/davec/.rvm/rubies/ruby-2.1.0/bin/irb:11:in `<main>'
```

So, this isn't a change designed around improving the design of this controller or being more "correct" for OO purposes, but around solving the problem of Rails exposing public methods as actions without also breaking backwards compatibility.


I'd prefer not to have chunks of commented out code. Please remove the code that is not required. Then send up another commit.


trailing whitespace :(


See, `node_a` is mapped through `names_a`, but `node_b` is not.


It's not exactly how I saw the implementation, but it doesn't look half bad, good work :)


75127368_DCFSEC (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1617 of 1625 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


Change this into `RuntimeLibraries`

See https://github.com/Slicer/Slicer/blob/47579984acc86b520afa7e5cdcecdfe77d10ca85/CMake/SlicerCPack.cmake#L116


Sorry I got side tracked by this wording thing and I forgot and now I'm late and I have to go.


Drzimo se konvencije da koristimo tab za indentaciju koji je velicine dva spacea. Mozda na pocetku izgleda stisnutije, ali se covjek navikne i lakse na kraju bude citat kod (ne treba onda kod ic neznam kolko u sirinu).


Haha. I'll be there.
On Mon, Mar 2, 2015 at 5:16 PM Eric Dill <notifications@github.com> wrote:

> MNT: Frustrated end of day commit
>
> - Resampling is not working for reasons that currently escape
>   my grasp.  I'll bug @danielballan tomorrow if he doesn't grow
>   too angry at the constant pesterings from this guy
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ericdill/dataportal/commit/
> 2ff8dea633f8b088ce9c8a7ce4a9cc798b9c159c
>


`menu_reorder_child()` would be a more explicit name don't you think? cause many things can have child we could reorder


Maybe split this into multiple tests? /cc @anba


Surely the right interface here is the variadic generalization of `Reshape(n, c, h, w)`? I can write that if you prefer...


I guess, there should be a standard tool for fixing indentation, see, for example, `doctest` module.


PEP-257 Errors.


we just hide them,https://github.com/NodeBB/nodebb-package-manager/issues/5


Morat ces mi mrvicu detaljnije ovdje pojasnit sto se dogadja da bih znao odgovorit :)


In the OSC protocol, type 'i' specifically means a 32 bit integer. If you explicitly ask for a 32 bit value by using the 'i' typetag (rather than letting pyliblo determine which type to use), IMHO any value larger than 32 bit should result in an OverflowError. Note that many OSC implementations will not automatically convert back and forth between 32 and 64 bit types like liblo does.


One last thing: since you're changing the type of something in the public interface, could you please include the string `[breaking-change]` in the commit message? (This follows the convention in `rustc`.)


84692518-Markdown-Documentation (kbenne) - i386-Windows-7-VisualStudio-12: OK (1620 of 1620 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


```
"nbbpm": {
  "index": false
}
```


Loading scripts from the src attribute of a script element works correctly on Linux and Mac OSX but fails on Windows. Copying the file contents to a CDATA section like this works on all platforms. It would be nice to figure out why the src attribute fails on Windows, but this change fixes the immediate issue and has the advantage of not requiring any change to Typica's executable.


not wheel url my.mail.ru
http://my.mail.ru/mail/playcine/video/_myvideo/11.html


`if not os.path.isdir(os.path.join(os.getcwd(), 'www', 'static_doc')):`
https://docs.python.org/2/library/os.path.html#os.path.isdir


I think, it's worth extracting the common `try: trampoline... except: ...` wrapping code.


Vidim da to koristis na vise mjesta. Spremas nekakve id-eve kog je user promovirao ili nesto slicno? Vjerojatno bi ovo trebalo ici u zasebnu tablicu


PEP-8 Errors.


I'm honored you've chosen to include my library in your project. Thanks! If you run into issues or have feedback, please don't hesitate to let me know.


Thanks, fixed as suggested.  (I used a vector to handle the (de)allocation for me; I thought it was supposed to be nearly 'zero overhead' in theory...)


I still find this name a bit opaque, although I'm not sure I have a better suggestion. At least, we could say something a little plainer in the doc comment; to me, this is the "volume of a slice"...


Pijana indentacija :)


AFAIK `mode='exec'` is the default argument value anyway.


Vrlo vjerojatno bi se ljepse citalo sa:

```ruby
unless current_user.paid?
```


This functionality was removed because it was actually not being used anywhere, and in fact the only time we care about validation, we **DONT** want the `OP_0`'s to be allowed anyway.


Cooool. :+1:


The least ambiguous way to check for unset values is to use a double pointer (**time.Time in this case). However, I think everyone can agree that double pointers are annoying/stupid. While I still think my reasoning in #258 is valid, in practice it's very unlikely to (purposefully) use the go zero value as a meaningful timestamp in cassandra, so making Unmarshal set *time.Time to the go zero value probably makes more sense than doing nothing.


Mozes koristiti u order() metodi i simbole, ne samo stringove, cesto je upravo tako vise konvencijalno:
```ruby
.order(:name)
```


opps!
good thing we arent going to use it most likely


It is not obvious why returning the first variable is the right thing to do here.


clang warning, but seems to be an error in real :)


Please do, not familiar with writing boost implementations of variadic python functions.


This could have stayed as is, but it was clearer IMHO to replace them with just the final result.  There was no need to build the `scriptPubKey` for the `multisigInput` tests.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/898
success: http://build.servo.org/builders/linux2/builds/896
success: http://build.servo.org/builders/android/builds/934
success: http://build.servo.org/builders/mac1/builds/1113
success: http://build.servo.org/builders/mac2/builds/1113
success: http://build.servo.org/builders/gonk/builds/84


Ili bi dobro dosao komentar sto je 'uweapon' ili jos bolje, vise deskriptivno ime za varijablu. current_users_weapons?


Why are the EFAC/EQUAD/EMAX additions put inton NGC6440E.tim when we don't know what those values should be?  Shouldn't those simply be put into one of the tests instead?  Say as a couple additions to test_toa_reader.py?


75127368_DCFSEC (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (625 of 625 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-3.65%25-green.svg)


Is the try/except clause necessary? Wouldn't `l = 1234567890123456` work in Python2 as well, and automatically be converted to long?


Ne bi trebao koristiti varijable koje imaju ime @tmp - one nista ne predstavljaju i kad se kasnije dolje u kodu pogleda (ili u viewu), nije nikako jasno sto oznacava @tmp :)


I'm not 100% sure, but I think it should also be the locale version on Windows.

BTW, you'll hate me for this but… wouldn't it be simpler to pass locale version directly instead? :)


You are my Hero!
This works! AWESOME! Or like others said 'Legen... dary!'


Ok


setup.py should not be modified with a "psray" specific change.  Can you please remove this commit?


This somehow killed the new SVG logo which was faster...


Many changes occurred, the README is out of date.... I'll fix it next.


fast-forwarding master to auto = 891dd496


Ovo se moglo vjerojatno napraviti sa jednom metodom a ne visestrukim pozivom metode update_attribute vec update_attributes.


```
64 bit:
$ ../run/john -test=4 -form=ssha512
Benchmarking: SSHA512, LDAP [32/64 OpenSSL]... (8xOMP) DONE
Many salts:     8091K c/s real, 1094K c/s virtual
Only one salt:  7152K c/s real, 1013K c/s virtual

Benchmarking: SSHA512, LDAP [128/128 SSE4.1 2x]... (8xOMP) DONE
Many salts:     14357K c/s real, 1971K c/s virtual
Only one salt:  12625K c/s real, 1913K c/s virtual

32 bit:
$ ../run/john -test=4 -form=ssha512
Benchmarking: SSHA512, LDAP [32/32 OpenSSL]... (8xOMP) DONE
Many salts:     4101K c/s real, 836548 c/s virtual
Only one salt:  3854K c/s real, 771251 c/s virtual

Benchmarking: SSHA512, LDAP [128/128 SSE4.1 2x]... (8xOMP) DONE
Many salts:     12429K c/s real, 1754K c/s virtual
Only one salt:  11591K c/s real, 1728K c/s virtual
```

32 bit improvement was great.  64 bit, not as much, but still not 'bad'.  about 1.8x improvement on 64 bit, aboout 3x on 32 bit.  The reason 32 bit is so much better is the 64 bit rol commands needed.  Yes, oSSL 'does' do these rol commands using MMX, but that is only helps some.  Getting into a 64 bit mode and staying there (in the SIMD code), greatly helps the 32 bit CPU's.   The 64 bit CPU's get some gain, mostly from doing 2 hashes at a time (in the interleaved mode).  The loss (less than 2x), comes from the buffer manipulation overhead getting data into interleaved mode, and since we have to adjust this buffer at each salt.


Yes, that would probably be better.  I just stuck them in there to make sure that functionality got used, but the values are arbitrary.


Ako uvijek redirectas, znaci da ti ovdje ne trebaju instance varijable - one su ti potrebne kada zelis nesto prenjet viewu.


should we start using the github markup for usernames so they link?


True.  But, I have no idea how to remove a commit.


Neznam sta se tocno ovdje dogadja, ali pretpostavljam da pospremas neku posebnu vrijednost posto user sa user_id-em 0 vrlo vjerojatno ne postoji :)


Ovu @zahtjevi varijablu si mogao vrlo vjerojatno napuniti sa @weapons.count :)


Ista stvar kao i kod @tmp


Mozda znas, mozda ne, postoji metoda `.zero?()` :)


saw approval from jdm
at https://github.com/glennw/servo/commit/611fd7a8461a27387c06786d06dd48a39c112393


merging glennw/servo/reap-more-stuff = 611fd7a8 into auto


@jordansissel that answers my question. Thanks for the detailed explanation. I thought the dropping of the milestone option might have something to do with the next release, which is why I was explicit about the version I used for testing the PR.

Moving forward where should one look for planned deprecations? Looking through the commits for 1.5.0-rc1 I see references to commits where milestones were deprecated so I keep an eye the code for now.

Thanks again for your time and help!


glennw/servo/reap-more-stuff = 611fd7a8 merged ok, testing candidate = 86de99ea


Imas dvostruku negaciju ovdje :)


You could consider free functions instead:

    template <class T,
        class = std::enable_if_t<
            std::is_same <T, double>::value ||
            std::is_same <T, bool>::value ||
            std::is_same<T, std::uint32_t>::value ||
            std::is_same<T, std::int32_t>::value>>
    Json::Value from_atomic (std::atomic<T> const& other)
    {
        return Json::Value (other.load ());
    }

Relaxing the `enable_if` ruleset will let you convert more atomic types, if needed.


Takodjer i ovdje. ovo mozes i provjerit sa `.nil?` ako maknes onaj prvi usklicnik


great, thanks


ovo bi trebala bit metoda `first_name()` ? Ne trebas jos predavat user-a kao parametar, user-a vec imas sa `self`


I just merged it in.


75127368_DCFSEC (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1619 of 1625 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


I'm not concerned about the execution efficiency here.  What's happening here is that we're widening the interface of the `Json::Value` class by adding four constructors.  If we thought everyone and their cat would be converting `std::atomics` to `Json::Value` then I'd have no problem with this change.  But I don't foresee that.  Personally, I think a class interface should be only as wide as it needs to be.  Consider `Effective C++` "Item 18: Strive for classes that are complete and minimal."  These four constructors don't fit the "minimal" part of that item.  Does that make sense?


Ha! :)


-1 - this duplicated info has [the same problem I already mentioned](https://github.com/SUSE-Cloud/automation/pull/228#discussion_r25340580)


OK, rather than "remove" the commit, I just undid the damage with a new commit that should now be added to the pull request.  Hopefully that worked.


Heh.  I was hoping we could use this as a point of learning for us both!  Note:  did it get added because you did a "git commit -a" or a "git add ."?  If so, those are dangerous practices....


> Moving forward where should one look for planned deprecations

We try to deprecate things gracefully between releases. Usually a gradient of: first warning on use of a deprecated item, then removing the deprecated item and producing a specific error about it, then removing the item entirely. Of course, this is only between GA releases. Between betas/RC releases, I don't expect such things.


Ovu si aplikaciju radio uz Hartlov tutorial? :)


@chriscool: curious what you think about cleaning up after each test case. we don't need to, since the whole dir is cleaned up. but may be nice to make it obvious which files are failing. is there a strong reason either direction?


iteration (kbenne) - x86_64-MacOS-10.9-clang: OK (1614 of 1614 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


20:07:04 T:1284  NOTICE: total m3u links
20:07:04 T:1284  NOTICE: 1181
20:07:05 T:2752  NOTICE: Thread BackgroundLoader start, auto delete: false
20:07:06 T:3516  NOTICE: Thread LanguageInvoker start, auto delete: false
20:07:07 T:3516  NOTICE: -->Python Interpreter Initialized<--
20:07:07 T:3516  NOTICE: CommonFunctions-2.5.1
20:07:08 T:3516  NOTICE: http://my.mail.ru/mail/playcine/video/_myvideo/9.html
20:07:08 T:3516  NOTICE: common resolver
20:07:08 T:3516  NOTICE: my.mail.ru
20:07:13 T:4104   ERROR: Playlist Player: skipping unplayable item: 0, path [plugin://plugin.video.live.streamspro/?url=http%3A%2F%2Fmy.mail.ru%2Fmail%2Fplaycine%2Fvideo%2F_myvideo%2F9.html&mode=19]
20:07:13 T:4748  NOTICE: Thread BackgroundLoader start, auto delete: false
20:07:20 T:2664  NOTICE: Previous line repeats 1 times.
20:07:20 T:2664  NOTICE: Thread LanguageInvoker start, auto delete: false
20:07:20 T:2664  NOTICE: -->Python Interpreter Initialized<--
20:07:20 T:2664  NOTICE: Kodi Log Uploader: started
20:07:20 T:2664  NOTICE: Kodi Log Uploader: settings: len(email)=18
20:07:20 T:2664  NOTICE: Kodi Log Uploader: settings: skip_oldlog=True
20:07:22 T:2664  NOTICE: Kodi Log Uploader: reading log...


If we end up actually needing to disable the tests, please at least change the version condition to be specific to MSVC/Win64. No reason to disable already passing tests on the other platforms.


Dobro ti je stavit sve te log fileove u .gitignore da ti se ne trackaju. Pri svakom paljenu servera ce ti se nesto zapisat nesto unutra, a to nije potrebno imat.


82420068_GridViewMultiEdit (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.48%25-red.svg)


Ista stvar i sa ovim assetima. Zapravo ih nisi ni trebao kompajlirat u developmentu, mozes ih odavdje obrisat.


Yep indeed. Will do.


So this does seem to break the AOV list on our `RenderPassSettings`. @danieldresser is nominating @cedriclaunay to take a look at fixing the IERendering side.


Isto i ovaj fajl mozes gitignorat.


I'm in "monkey see-monkey do" mode.
I cleaned up because I saw other test cases doing it.

The argument I have is that it makes test modular.
if tests cleanup then it is reasonable to attempt to output to a file, then check if the file exists/it's contents.
If tests do not cleanup and you choose a filename already used, then command writing the file could fail and you would not detect it. (lots of tests use the "actual" and "expected" files)


Indeed.


I get a startup error  on  c.auth = { ... }


doc comments updated, see most recent version:

```
  /**
   * @brief Compute the volume of a slice; i.e., the product of dimensions
   *        among a range of axes.
   *
   * @param start_axis The first axis to include in the slice.
   *
   * @param end_axis The first axis to exclude from the slice.
   */
```


Metamaps.Create.newSynapse isn't a jquery reference, so it can't be used in either of the ways you use it here...

.hide() just happens to be a function that may have mislead you


82420068_GridViewMultiEdit (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Could you add a way to opt out of the label being drawn? I'm having issues with backwards compatibility with the UISlider right now, since it didn't previous have a label. Of course, I could redo the UI for these elements, but it seems reasonable that someone would want to have a customized label.


$scope.user = {
    email: '',
   password: '',
   username: ''
}


> I'm not 100% sure, but I think it should also be the locale version on
> Windows.
>
> BTW, you'll hate me for this but… wouldn't it be simpler to pass locale
> version directly instead? :)
>
If it should be in locale on Windows as well, then definitely (will post
the patch tomorrow, midnight here and post-midnight patches from myself
usually aren't in the best quality :-)


Haha jquery may be smarter than you think, because it works! The second line is a typo, though, you're right.

I haven't tested this cross-browser, but I'm fairly sure jquery can just do it. I could rewrite it with jquery but figured this was nicer


That means, this should go away.


sounds good to me!