I'd say at least worth filing an issue in the gpg tracker.


The message needs to mention something about null. e.g. "Illustration must not be null and requires at least one point."


Thanks! We're excited that view animation is finally stable.


```go
if err := t.Commit(); err != nil {
	log.Fatal(err)
}
```


so there are some dependencies to consider right. There isn't any reason for importer to know about attribute mapper and I think we can put more weight on client a bit


Doing the write with `t.mux` held defeats the purpose of splitting the serialization from the write?


Das Login-"Fenster", das erscheint wenn man auf " Schlagworte:  Neue hinzufügen (Login)" klickt, funktioniert bei mir auch nicht mehr.


Since this is a transliteration of the C prototype into Chapel, I preserved the C identifiers.  I think preserving that correspondance outweighs the arguably poor/vague choice of name.  I did add a comment giving the C type which I wasn't able to express with Chapel.  Note that there shouldn't be any confusion here to anyone other than developers of the FFTW module since these routines are not available to end-users (unless they manually use the sub-module).

in1 and out1 can't be renamed in and out because those are reserved words in Chapel.


:joy: :joy: :joy: :joy:


@andrewfraley Might be stupid questions, but where do I define them? Asking for usinbg this for `-Djboss.bind.address` :-)


Thanks @ensiform. My sanity can live to tell the tale.


90298376_ResultsViewerUpdate (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Also needs to check that `instanceKey` is still registered, I think?


This section needs more comments, I took me a few minutes to follow your logic here.


Same comment as before, I'm concerned that this may fail in unexpected ways.


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.31%25-red.svg)


It looks like this is a new check.  Looks reasonable.


Need to catch errors here.


LGTM!


merci chef !


Underwriting happens automatically every time we save?


Ta funkcja jest trochę skomplikowana, przydałyby się komentarze.


The crash has gone, but the issue is still present - that's password mismatch...


Approved.


eventTime should be SystemClock.uptimeMillis() on each iteration.


Nope.  Never mind.  It was there before but I missed it.


some tests failed:
failure: http://build.servo.org/builders/mac2/builds/1249


This is shaping up to be an incredible project, with many groundbreaking techniques.  I'd love to adapt the TEI from history.state.gov to be to use this.


Project should build now.


Ponieważ pod postacią var formTab = document.getElementsByTagName('form')[0]; - nie chciało działać, ponieważ traktowało formTab jako tablicę.


Looks good to me!


PEP8 nit pick, space around the `+` operator.


Agree to both.  Blush about second.


TestSubsystem.xml was part of the initial commit.
Other files was copy/pasted in the python script from an old test directory of the pfw.


In this case `eblob_generate_sorted_index()` will be called from background thread only for closed blob and will not be called for new one.


Having trouble following that then. I see `app_picture_format.json` deleted but can't find any of its parts moved to another place.


Indenting for the catch is off.


@matzew it's a resource you could use in a wrapper recipe.  So you could have a recipe that looks like:

```
include_recipe "jboss-eap"

jboss_java_option "jboss bind address" do
    option "-Djboss.bind.address=0.0.0.0"
end
```


I guess this is how we were doing it previously, anyway.


Je pense qu'un énum des titres permis serais pertinent, et le constructeur prend une valeur de l'énum en parametre


cc @pablopareja


you can get rid of the new PointerCoords() and assign directly to coord.


Good change, I was thinking about that but then got distracted and forgot.


Given the order in which we did things, Travis was never in the state necessary to catch this.


Offset bug fixad :-)


Check if updateScheduler needs jenkinsRootUrl.


Need to catch errors here


saw approval from SimonSapin
at https://github.com/mbrubeck/servo/commit/531bcb12aeceede095a973861d3a77c2a4cdf28f


@phmagic The service is killed when Tower disconnects.

Previously, you could also kill the service by exiting the watchapp on the pebble, but that wasn't a good idea.  The user might want to switch to a stopwatch app, start a timer, and switch back.


merging mbrubeck/servo/rtl-position = 531bcb12 into auto


mbrubeck/servo/rtl-position = 531bcb12 merged ok, testing candidate = b255b49e


I have that under blog posts right now ( which probably isn't the best place for it ) can you remove it from line 14 as part of this PR?


no i did not mean to do that, my bad


Based on: https://bugs.dojotoolkit.org/ticket/18360


For this and the one in the loop, you can probably consolidate all the points.get() into a local variable. Probably not a big deal, but if the implementation of the list changes if could go from a O(n) = 1 to a O(n) = n.


Catch not aligned.


It would've been nice if this change was mentioned in breaking changes list for the release.


90298376_ResultsViewerUpdate (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


fixes #70


Add a doc comment explaining the return value?


There's probably more yet.  But its a better start.


Add a test for this?


Great job! I just listed a few minor things that I am picking on you for.


Thanks! I'll add a line to clear the stream in the loop.


It will. But why can't it be called from eblob_base_ctl_open()?
It should not be called because there will be new bctl with higher index number, but apparently there is a bug somewhere since 0.22.13 version, which I'm trying to figure out.

What was the purpose of disabling binlog at the first place?


First implementation of #19 and related to #18


I added another version,hopefully it's better now.


I applied your initial reply but not the extended one because it turned out that it wasn't as useful as it first looked (In your 3. we also need the concrete type of the event).


These should be errors, not debug messages.


fuck


it didn't save


>  the browser tooltips are different than the tooltips we implement ourselves in ... where do we implement that?

Our red tooltips are in e18bb310b4743a0897e143451c74d98e527565cd.

We could implement `required` ourselves and use our tooltips, but is really so important that the tooltips look exactly similar?


getting some interesting results! Do you think it may also be worth tuning the length of the fast move verification check time? (Currently 10% of normal time.)


s/will keep updating this party/maintains this guide/


we dont' need this line see later comment


nope that Ares project file. I used Ares to edit it :)
John


@agudian , looks straightforward.. I'll merge this one..


you can use `self.restURInoAPI + '/task'` instead of `resturi`


I would have made the introduction of start() functions a separate content, as it is really an unrelated, albeit good change.


This isn't a breaking change for existing users of the 1.x series of the driver. In is only a change for users coming from one of the 2.0.0 beta releases.


Hmm, does this mean comments under a post will have pagination? That seems very odd. It functions well the way it is, though improving by showing the latest comments (limit = 2 or 4) initially and if "View comments" clicked show 50, and if "View more comments" clicked, show 50 more. Pagination is sort of turning back the wheel and advancements in web based discussion.


The API understands both of these?


That was not displayed on purpose because the user can't do anything about it, those messages should use the notification service instead


No problem.  And the great thing is it still work in an if statement (nil is false, piece is true)


Hax? :)


Why not reverse these two lines lol


I'd say yes, but it doesn't have to be in this patchset.  It's OK by me to prototype functionality in the command line, we can always move it to the shared library later.


Not sure what happened here lol, I had to merge it back in :S


The three lines above can be replaced with: `retryIssuesBySchedd.setDefault(schedd, []).append(msg)`


Unhandled Fundamental Failure


This to be compatible with current behavior, since `'disconnect'` event also emits the error.


Allman style please!
```
for ()
{
}
```


Zrezygnowałam na rzecz podpunktu 6 "* Zmodyfikuj kod w taki sposób, żeby wynik aktualizował się za każdym razem, gdy użytkownik wpisze znak. Podpowiedź tutaj." . Czy można dwa zdarzenia obsłużyć? Czy jest sens?


`g_assert_cmpuint` ?


hmm..

Actually :
the 2 identical calls to self.scheduler_loop(..) are apparently useless : if you comment them out this test still succeed (well, at least on my side)..
So are the 2 sched's loops really necessary or not :-?

Otherwise : the `hst.modified_attributes` and `getattr(hst, DICT_MODATTR["MODATTR_RETRY_CHECK_INTERVAL"].attribute` values aren't asserted *before* the ext command is executed.. so we unfortunately also can't be sure that the values have actually been properly changed/set by the execution of the external command.. :s


@basileis @bhupeshpant19jan Please use this updated html for pre launch.


Thanks for noticing that. Will be fixed on the next push.


When `eblob_base_ctl_open()` is called from `eblob_add_new_base()`, it is called for just created empty base and it will not call `eblob_generate_sorted_index()` for it. The purpose was uselessness of enabling binlog and flushing cache on startup because at startup eblob is not available for any external operation and no one can change the cache at this time.


What is this? Is this still needed?


Source/Project64/User Interface/Rom Browser Class.cpp

you are right it really should have been split to two commits


It's the backend, not the frontend who cannot contact the Grid scheduler.


Instead of storing the libs as strings, why not store them as a array of pre-compiled regexes?
`Libs []*regexp.Regexp`


What is the rationale here? Shrinking this by 1 byte looks like it eliminates space for the null terminator


@msgerbush @babbtx added option to request a set of devices by a list of id's


You will need to add unit tests for this code.

Note that you have a lot of failing tests on this branch.


tab indent?


cc @migurski


Allman style


What if at startup time process has scanned blob, populated its keys into the cache, then sorted it, but did not flush the cache and started working?


What are your plans for these TODOs?


I think it's a new thing. I ~~stole~~ modeled this off of Ledger_test.cpp, which @vinnie handed to me a few weeks ago (even though I have the credit in the git log).


Ahahah! I fix the code... Thanks for letting me know!


I still don't think this is the correct version-> when did we make the jump to version 1? Also, our current version is 0.1.3, so that is a huge jump.


I've never seen this before. Why?


We should add `retries=2` at the end so that requests are retried (up to two times) in case of failures


This is where we need to decide whether to support key ids or not.  Collisions are a real-world thing.  We could say "fingerprint" and silently support key ids?  Or that, but also warn?  Not sure.  I know key ids are convenient, but they're just 32 bit integers.


Wow, I guess git knows when you overwrite something.


thanks, but I am  not sure that works.
created a simple wrapper, with a default.rb in receipts, containing exactly
you snippet, but I don't see EAP binding on 0.0.0.0

On Tue, Mar 17, 2015 at 7:32 PM, Andy Fraley <notifications@github.com>
wrote:

> @matzew <https://github.com/matzew> it's a resource you could use in a
> wrapper recipe. So you could have a recipe that looks like:
>
> include_recipe "jboss-eap"
>
> jboss_java_option "jboss bind address" do
>     option "-Djboss.bind.address=0.0.0.0"
> end
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/andrewfraley/chef-jboss-eap/commit/ca04b69b7db6bd57bf8520364f9bad1abd16b872#commitcomment-10243655>
> .
>

--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf


*to __an__ event store*

Nitpick: I'd say *__Akka's__ persistence* might work a bit better, but it's ok if you leave it.

*to __modify__ it* the repetition sounds bad.


We've settled on using SessionAuthenticationAllowInactiveUser and OAuth2AuthenticationAllowInactiveUser for account and preference information.


saw approval from aberghage
at https://github.com/basho/riak_pb/commit/f138b473e059dbb10ef74acc77ca71719afcad08


merging basho/riak_pb/zl/add-optional-timeout-to-RpbYokozunaIndex = f138b473 into borshop-integration-111-zl/add-optional-timeout-to-RpbYokozunaIndex


basho/riak_pb/zl/add-optional-timeout-to-RpbYokozunaIndex = f138b473 merged ok, testing candidate = 2fd169e2


*recrate __the__ current state*


@beanieboi you are not testing, that no other values are included. in our case its not a problem. but therefore the match_array matcher exists (compare arrays, without ordering)


this was erroneously included in the initial commit. Chose the path of using the current "as-is" [system] scriptpath [0] directory. Alternate static_files location would be specified via the currently documented ``document_root`` property.


At startup time sorting process is executed before keys from the blob are populated into cache.


Should this be: ``ManyToManyField.allow_unsaved_instance_assignment``?


We don't want to allow is_staff to post. I think you can just use IsUserInUrl in permissions.


whoops! we could add an expectation on the count to make sure there are no others


This does look like it assumes the order of values in `ostree.gpgsigs` is the same as the returned value of `ostree_gpg_verify_result_lookup`?   Should there be a way to get a direct reference to a signature value, something like `ostree_gpg_verify_result_get_signature()` ?


I think so, yes.
There are two cases where you want to write an error page.
An error payload is produced or an exception happens.
It can even happen than an exception is raised while writing an error page...


this smells a bit funny... why the backwards merge with such a huge delta?


Please, can you use `camelCase` instead of `snake_case`?


I'd make this: `Signatures deleted: %u` so that a later conversion to gettext (if we ever do) is saner.


30414/Ghiurau A. Alexandra Cristina/Assignment2.2/main.c

It's not quite alright, a bit frustrating, I hope I'll finish it by 23.59.


meikanchulainihaiyouzheyishoujiayou


We could also choose to use 64 bit key ids here.


@dalgaaf , feel free to let me know what other SUSE distros should be added to this conditional.


`...otherwise, they'll be placed below your online contacts.`


A note that we can increase performance here by generating tiles up to `z20` at add time instead of the current map default of `z18`, which would increase the resolution of the algorithm's partitioning. But I think we're ok here for now, with mere points.


You should find this at the end of standalone.conf, but no guarantee the option works how you expect it to :)

```
JAVA_OPTS="$JAVA_OPTS -Djboss.bind.address=0.0.0.0"
```


Causing javaw.exe leaking


Let's not complicate and use null.


type=>types


These assertions only verify that `values` is a superset of those 6 tuples.  What you really want to check is that `values` is equal to the set of those 6 tuples, which you could do using set equality to handle ordering issues.


is a predetermined => is predetermined


m... alf, pilasweb.js lo subimos al repo también, es nuestra versión de producción del archivo. La idea es que siempre esté ahí actualizado, así quien quiera usarlo lo puede hacer sin compilarlo.


r=SimonSapin


:smile: :clock3: :small_red_triangle: :black_circle: :notebook: :star:


:D


I believe Changelog should record only things users might notice, I don't believe internal changes should appear here... For instance I would remove lines 16, 17, 19, 22, 23 and 26. What do you think?


rax retry tests


See my comment in `verify_result_finalized_cb()`.  I kinda wanted to keep this gross temp dir hack confined to `OstreeGpgVerifier`.  The result object really doesn't need to know about it.


@LeventErkok the least I could do after all the SBV help you're giving us :+1: https://hackage.haskell.org/package/gitrev-1.0.0


XD gg ^^


NIT: Not your fault, but this part of the instructions are stale.  You can build CoreFX from a regular command window, Dev12 or Dev14 command prompt now.


Agreed!


@rmcmx Could you review this please?, thanks.


@sueloverso, does `seconds == 0 && micro_seconds == 0` have a special meaning? Otherwise, isn't this just `seconds == 0 && micro_seconds < 1000`?


*state dumps __taking into account events__ up to __a__ certain point in __the__ event stream.*

*a snapshot we __only need to reapply the events that happened after it's creation to obtain the current state.__*

*Usually __it's a good idea to use them but here we'll leave them out for clarity.__*


Hi Bryce,

I agree, but wasn't 0.3.3 released a long time back?

Here is the tag for it: https://github.com/sockjs/sockjs-protocol/tree/v0.3.3

As SockJS lacks a written spec, the protocol tests effectively _are_ the spec.

So making changes to the 0.3.3 protocol tests after 0.3.3 has been released (as in this commit and others) effectively retrospectively changes the protocol.

This is going to make it impossible for us to offer any meaningful compatibility guarantees with SockJS, which would a  big problem for us.

Perhaps I have got the wrong end of the stick here but I can't understand why the 0.3.3 tests are being changed after the ship has sailed....


all tests pass:
success: http://buildbot.bos1/builders/test-riak_pb/builds/112


Those are in two different handlers, I think.


In this project, we intend to introduce different components of an adaptive flow-based mechanism to manage users' traffic over wireless mesh networks. The offered solution is deployed on a real test-bed environment.
The specifications of the introduced system are as follows:

--Hardware


This does not seem to fully fix the m naming issue as the following class still  gives the error: io.realm.exceptions.RealmException: Could not find io.realm.RealmJsonImpl

        public class SampleRealmModel extends RealmObject
        {
         private int mP;

         public int getP()
         {
            return mP;
         }

         public void setP(int p)
         {
            mP = p;
         }
        }

Cerainly more specific error messages would help your wonderful developers find these sorts of bugs ;)


I’m not sure what I was thinking. I was fixing a problem that turned out to be in my test case and didn’t back out these changes (at some point they made sense to me, but now I see the problem).  I’ll restore it (and the [count - 1] = 0) to the original code.

mikem

From: noahfalk [mailto:notifications@github.com]
Sent: Tuesday, March 17, 2015 11:45 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Undef some temporary code that uses the global pointer table and fixed a pre-existing off by one error getting a managed string. (11109dc)

What is the rationale here? Shrinking this by 1 byte looks like it eliminates space for the null terminator

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/11109dc5195c7e61c3347d25964b82b4f51cb2e6#commitcomment-10243979>.


What is the concern here exactly?  `directory` defaults to `bower_components`


*returns __a__ suitable violation*


Can you use json.load instead of `literal_eval` please ? `literal_eval` is the counterpart of `str`. Since you are using `json.save` its counterpart is `json.load`.


This should be named object_type


You say "Not isolated, but we have..." in the comment but i think this condition
if (!(neighbours & ~ supporters))
is true for isolated pawns and code inside block is executed (which is useless)
Maybe you should write
if (!(neighbours & ~ supporters) && !isolated)
to make it faster?


I think the backend_id attribute should also be used for host objects. Seems to be missing at the moment.


I'd write *to __the__ corresponding __methods__ (__either__ `start` or `roll`).


Sweet; how do I +1 packages?


this is first test


Qua volendo puoi fare `threadFilters, tagFilters []string`


I think that's been on the todo list for Hackage2 for years...


To reduce duplicate code, please construct an array with basic attributes and then add the individual attributes for the objects later.


Why do you have the Settings singleton emit a signal when you already have the SettingsWidget signal with the same purpose?


Yes, sending in a timeout of zero on Windows does have special meaning (noted in the link in #1764).  Although no calls to `__wt_sleep` currently ever send in `(0,0)`, it is possible someone, someday may want that and I don't want to change that to a 1 msec sleep out from underneath them.


Is there any particular reason you made this change? It doesn't really simplify anything technically, and has no impact visually...


I had a different approach in mind. I was thinking of putting these seven lines here https://github.com/nizamyusli/CRABClient/blob/b96d8539c19e6439cc7e2414eeab4e76688dcafa/src/python/CRABClient/Commands/SubCommand.py#L454

In practice you don't need to initialize the prox at all if you already did it in the last N minutes.


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (rraustad) - x86_64-MacOS-10.9-clang: OK (1651 of 1652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Uh... the first is grammatically correct, the second is not. In other words, this is the opposite of a correction...


Again, I'd drop the parentheses after the method's name.


Edit: didn't mean to say public to private. I meant private to public.


Почему-то никогда не уходит по этой ветке. Однако если сделать унарной операцией ещё какой-нибудь, не использующийся символ, например, `%`, то эта ветка отрабатывает


can we do this without the bson_ext gem? that's a native extension (which breaks out support for building a WAR file under JRuby...helpful for those who want to deploy as a WAR file to an app server or servlet engine...


you're wrong. if it helps, i could change it to "when they next appear online to you"


style comment: can you define that as a separate function and just assign it here? That would save on the indenting.


In general:

* The documentation of this new feature is totally missing
* This feature is currently only available when using CSV based geomaps, this should be reflected in the docs
* Be compatible to old format CSV files (when only 4 columns are given, it's always of type host)
* Add the other missing object types: maps, dynamic groups, aggregations


The `key_id` string can be an abbreviated key ID or the full fingerprint -- basically whatever the user passes as a command line argument.  I considered doing a keyring lookup here to normalize to the full fingerprint, but there's use cases where the keyring may not be available and all we really need to do is a trailing substring match against the signature's fingerprint.


We should not use print, we are always using logger.info. Proposal, you keep the logger.info as it is, and then add a new logger.debug that only prints the joid/clusterID pairs


Se estila hacer así? No es mejor subirlo a otro repo / otro branch de
manera de dejarlo de trackear como un cambio en el git de dev?

Francamente es la primera vez con la que me encuentro algo así, y había
supuesto que era por lo que decís, pero en el decimocuarto "git diff" que
me ocupó 10.000 pantallas de la terminal me harté...

El 17 de marzo de 2015, 15:58, Hugo Ruscitti <notifications@github.com>
escribió:

> m... alf, pilasweb.js lo subimos al repo también, es nuestra versión de
> producción del archivo. La idea es que siempre esté ahí actualizado, así
> quien quiera usarlo lo puede hacer sin compilarlo.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Program-AR/pilasweb/commit/1be8f322ab08d0844ed9ab8a6d3356a26ce52061#commitcomment-10244211>
> .
>


same as above


Случайно запушил


Но всё работает...


I added a new PR to clean the code up: https://github.com/rakudo/rakudo/pull/389


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1151 of 1151 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.64%25-green.svg)


What do you think about pushing these params into a controller method or something, so that if additions to the required params need to be made to the Builder in an app, we can add those relatively easily?


That was one that got moved to a string literal: https://github.com/dimagi/commcare-hq/commit/205edc69258fd6beb64b334b08bc70b41a3caee7#diff-3da12d18db7c43d6f26972f3d94f4c2dR254


Не смогли на нашем демо или на своем сервере создать объявление ?

Выдает какието ошибки ?


Я не мог, вот везде так, а тут по-другому. Знаешь, как бесит?


Yes.


*if __the player who tries to roll is not the one who's turn it is__*


I would suggest to please put this into a constant.


test test 123


I agree that this a good idea, but I question whether it needs to be done with this PR, or if the next person to pick it up (most likely @HowardHinnant) can start with that.


Yes


I would treat the changes more as progress towards the next version. I can rename the file if that makes it more clear.


Great, you didn't forget the `man` pages update. Nice.


😃 Nope! It will be 2.0.0 and it will happen this week.

Thanks for your help.
Kalle

Sent from my iPhone

> On 17 mar 2015, at 17:12, jochenberger <notifications@github.com> wrote:
>
> @kallestenflo Anything else you need help with?
>
> —
> Reply to this email directly or view it on GitHub.
>


Do we still need this method then ?


I don't have much context, but there are no glaring issues that I can see! Tests pass on this?


This var is used in i2c calls as u8 pointer. It's better to cast integers in one function then cast pointer between functions.


Good job keeping all the logic out of the view and controller!


Shouldn't the index on the vector of x begin at 0? This would describe the entire series as x0:n. It seems like the same might apply to line 60.


specify the `CultureInfo`


No. Slave isr is called without any checks from main isr.


Can you do a pull-request on KWMedical/Slicer ? It'll be easier than me cherry picking it.


That would be perfect, and save a lot of confusion imho :)


thx, didn't recognize this failure.


The change in form is pretty abrupt here. I think it'd be better to use the same form of *returned by __X__ if/when*.

In this line I'd go with

*returned by `start` when the game is already running*


Can you fix this in rectify tab as well?


Need to check Is this call possible when isr is executed or not.


It kept it to avoid calling `self._agentConfig[endpoint]` in the two other methods using it, but I can update.


As discussed above, I'd suggest using separate parameters for regex and byte string. I'd also prefer if the regex compilation is performed beforehand, so that we don't need to compile regexes while inspecting process memories.


Az i-re nem is volna szükséged, az úgy is mindvégig 0 marad.


Interesting thought, building the accounts in a map.  I'm not convinced though, since the next thing you do is get references to the accounts in the map and never pay attention to the map again.  It looks like that's the pattern for every use of `createAndFundAccounts`.  Is this better than creating each account individually, potentially with a `mk_account` function?


Well this is kind of too long, but IMO better then previous very short version. When I think about it the `metavar` + short explanation might suffice. But I'll leave it up to you to decide.


Ah... I see. You build the app up programmatically instead of pulling the ready-made source, and you check for the inclusion of certain XML instead of looking for an exact match of the entire output. I.e. you make the test a lot more readable and only test precisely the thing it was supposed to test.

Hard to argue with "554 additions and 3,418 deletions"!


If needle has already been validated, then just call MustCompile


This won't work because you need git inside the container.
Instead create an image that starts off rocker/r-base and install the following
```
RUN \
  # Update aptitude
  apt-get update && \
  # Install software dependencies
  apt-get install -y \
    git \
    curl \
    libcurl4-openssl-dev \
    libxml2-dev \
    default-jre \
    default-jdk
```
and then add the packages you need for your repository
```
RUN install2.r --error \
    stringr \
    devtools \
    httpuv \
    jsonlite \
```


please consider moving it above [Line 613](https://github.com/Animatron/player/commit/78ea4016c126d97c3b3fff3722f119f7a35cd0fb#diff-b1cc3465b61577db8f93a00a469e9413R613), with a code like:

```javascript
var headers = gzip_it ? ... : ...;
headers['cache-control'] = 'max-age=300';
```

It's optional, and I hope we'll change to smth like _not Jake_ in near future, but anyway :)


We had a very similar discussion with the `bool` parameters to `makeAndApplyPayment` (called on line 181) here: https://github.com/ripple/rippled/pull/878#discussion_r24878414. We settled on the decision that it was fine to use the single `bool sign`, since it's pretty clear what it means. If it's *not* clear, I can rename it to `signTransactions`, but I don't think we need a new `enum` in this case.


Yes, it should be an invariant that the ordering of signatures in the result matches the ordering in `ostree.gpgsigs`.  That was deliberate.  Perhaps worth an explicit test case?  (might have to use the library bindings)

What would `ostree_gpg_verify_result_get_signature()` return?


Tom is right, there are some pretty long lines here.


capture softerrors


Nice work, Tino!


*__that a player tried to roll before the game was started__*


Ok, I'm not so easy with type hint on "probably not found" classes but I admit this wont break anything at this point.

But, as you will probably add tests fort this feature, you need - at least - expression language as a dev dependency.

Also, you may add the component as a *suggestion*: what do you think ?


Rails will automatically set the `created_at` field to the current time if a field with that name is present.  No need to do it yourself.


yes.. the spell entry's in creature_templete was not set.. big thanks :-)..


I did the merge manually first but this PR was still open so I merged it just in case. git is awesome


Also, do this:

```ruby
@message = current_user.message.create(...message_data if necessary...)
```


you rock, Tino!


Probably unused.


Something seems to be off here.

For strings <= 7 characters, the for loop is skipping characters because `step` is then > 1. While for strings longer than 7 characters, `step` will be 1 and the whole string will be taken into account. This is rather in conflict with the comment above.


@Soldez your commit worked correctly. `return @"Yeah!";`


Encapsulate the "can't send message if you've sent one without the last hour" logic in the `Message` model, not the controller.  Or at least expose an interface that the controller can use that expresses the domain logic, e.g., `Message#rate_limited?` or whatever.


Le 17/03/2015 19:44, Dan Korostelev a écrit :
> What is this? Is this still needed?

Yes, I think that was a good idea to prevent javascript: URL injection
if flash.


You might try a TargetTransformInfo hook, which is probably the cleanest way to do this without disrupting anything else. That said, I can't predict whether LLVM upstream will accept that, as it's usually pretty opposed to target-specific hooks in instcombine in general.


please remove


BTW, the current logic is site wide.  Nobody will be able to create _any_ message if one has been created in the last hour.  Is that your intention?


Collisions are a real-world thing when querying a public key server.  I think it's less of an issue when using your own trusted local keyring.


Why not put them all in here?


Do you think you could print a message here? Even if it's just a str() of the exception, it would be nice to have something displayed in case something unexpected happens.


What I meant was, when you run [statementlist.js](https://github.com/benjie/hsbc-scrape/blob/c5d0a5edd546b9ed01c73c1c4f6106de58fb45f6/statementlist.js#L5) it returns an object that contains a `statements` property - there's no `statement` singular property.


What is the purpose of rocker/hadleyverse then.  The whole point of using custom docker containers is so you don't have to install all the common dependencies every time. :frown:


I mean the `mt/Include.hx` check.


@rhb-anme you didn't miss this detail. `return @"nice";`


please use the following order: ```View```, ```Edit```, ```Delete```


Both are correct.
What I have used is the bitwise operation http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.22.2


Agreed. I just copied this style from some other test.


oh great! whew

is that where i should be committing it to? seems like i can see other
peoples work..

On Tue, Mar 17, 2015 at 12:25 PM, dothework <notifications@github.com>
wrote:

> @Soldez <https://github.com/Soldez> your commit worked correctly. return
> @"Yeah!";
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Soldez/ios-exercises/commit/c670a0955f27e0d00c2bb57c275fa49d3dacaaf3#commitcomment-10244718>
> .
>


I guess you mean "color-blind" ;)


I prefer like that ^^


Straight forward


catch errors


We could.  Then the output line exceeds 80 characters, which bugs me.  But yeah.  :smile:


style: scancount--


Maybe be even more defensive and check for `size <= 0`?


Similar here.


Yes. your repositories will be public for now. That's a good thing, a very
good thing.

On Tue, Mar 17, 2015 at 3:27 PM, Soldez <notifications@github.com> wrote:

> oh great! whew
>
> is that where i should be committing it to? seems like i can see other
> peoples work..
>
> On Tue, Mar 17, 2015 at 12:25 PM, dothework <notifications@github.com>
> wrote:
>
> > @Soldez <https://github.com/Soldez> your commit worked correctly. return
> > @"Yeah!";
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Soldez/ios-exercises/commit/c670a0955f27e0d00c2bb57c275fa49d3dacaaf3#commitcomment-10244718
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Soldez/ios-exercises/commit/c670a0955f27e0d00c2bb57c275fa49d3dacaaf3#commitcomment-10244767>
> .
>


Testing github forking and merging


Whoa...


Lehetne mind a CLN, LMPD és RSD-re külön teszt.
Pl: testIfPotSizeIsThreeTimesOfSmallBlindThenItShouldBeACleanPot és stb (bár lehet rövidebben is meg lehet fogalmazni :P)


@dubslow
>It doesn't really simplify anything technically, and has no impact visually...

It has visual and UX impact.
Right now you would have **multiple alphabetical lists** (each for ``Online``, ``Away``, ``Busy``, ``Offline``), and you would have to look *through at least 3 of them* to just find out status of a person.

With this improvement, you have **1** alphabetical list through which you *have to* look through, and you know whether:
a) person is offline or not (you look at "online" list, which includes all "online" statuses)
b) status of person in case where they're online (online/away/busy/rawr)

So.. how exactly it's not an improvement?


Make a little birdhouse in your soul


test change


This should probably be removed, doesn't make sense in our project structure.


Why not `hasOwnProperty('frame')`? Let's decide on a single way to do that.


"clenups". typo? :)


It's understandable doing the braces/indent format changes "along the way" while making other changes, since it's just easier and less time-consuming to slowly reformat the Project64 source to use Allman rather than to do it all at once, but in this case it seems to be a repeatedly recurring habit of some sort (this is not the first commit where it happens), so maybe if I can just get it over with and just convert the source it will prevent the need for it in the future.


change functions name


This repo has two xcodeproj files - it should only have one. The  UITableView+BLCImagesTableViewController.h and UITableView+BLCImagesTableViewController.m files aren't needed - they should be deleted. The .pch file should be deleted too.


nice to see so much activity here :)


change names


Lehetne inkább enum, s akkor az enumértékek nevei CLEAN_POT, LIMPET_POT és RAISED_POT.
És ekkor a getPotStatus() (sor 32) egy ilyen értéket adna vissza.


`var isCountryMatch =` isn't necessary here as far as I can tell.


Cinema is different than literature.  Although, it was in April 2013, Banks announced that he had inoperable cancer and was unlikely to live beyond a year. He died on 9 June 2013.


awesome, I'll use this.


That's a doozy of a C bug


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1034
success: http://build.servo.org/builders/linux2/builds/1034
success: http://build.servo.org/builders/android/builds/1068
success: http://build.servo.org/builders/mac1/builds/1250
success: http://build.servo.org/builders/mac2/builds/1250
success: http://build.servo.org/builders/gonk/builds/221


I would move this to buildResults, and use the count of Errors to set it
```
r.Results.Success = true
if len(r.Results.Errors) > 0 {
    r.Results.Success = false
}
```


Please ignore lines 4-6 and 13-15


Kicsit feleslegesnek tűnik eltárolni a smalBlind-ot és a többit, hisz egy getteren keresztűl elérhető a gameState-ből, és azt is elteszed példányváltozóba.


@scopatz I'm trying to:
1. filter by natural uranium and then
2. group by time created to get natural U "mined" per time step.

I don't think it has to be in this order, but I just can't figure out why this won't work. right now I'm getting this:

```
$ cymetric ~/cyclus/metrics/natu.sqlite -e "print(U_Mined[:])"
/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/metrics.py:10: QAWarning: pyne.data is not yet QA compliant.
  from pyne import data
Traceback (most recent call last):
  File "/home/opotowsky/.local/bin/cymetric", line 4, in <module>
    main()
  File "/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/main.py", line 36, in main
    exec_code(ns.exec_code, db, write=ns.write)
  File "/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/execution.py", line 197, in exec_code
    exec(code, glb, loc)
  File "<string>", line 1, in <module>
  File "/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/execution.py", line 123, in __getitem__
    return self.evaler.eval(self.name, conds=conds)
  File "/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/evaluator.py", line 58, in eval
    raw = m(series=series, conds=conds, known_tables=self.known_tables)
  File "/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/metrics.py", line 63, in __call__
    return f(series)
  File "/home/opotowsky/.local/lib/python2.7/site-packages/cymetric/metrics.py", line 225, in u_mined
    u = u0.groupby(level=['SimId', 'QualId', 'ResourceId', 'ObjId','TimeCreated'])['Mass'].sum()
  File "/usr/lib/python2.7/dist-packages/pandas/core/groupby.py", line 3009, in __getitem__
    raise KeyError("Column not found: %s" % key)
KeyError: u'Column not found: Mass'
```

Is the filtering step somehow removing the mass column?


editing authorship!


```js
else if ('COM.CO' == [second, first].join('.'))
```

Simplified?


si, aunque suene raro si, es super común. por ejemplo jquery [1] o bootstrap [2] lo hacen
así, tienen un directorio build o dist con la última versión compilada, y lo actualizan a cada rato, es lo mas práctico para acceder a la última versión.

Lo del ver muchas lineas en el git diff es un bajón, pero se soluciona usando un cliente de git o haciendo diff solo de los archivos puntuales.

1 - https://github.com/jquery/jquery/tree/master/build
2 - https://github.com/twbs/bootstrap/tree/master/dist


*__A new game copy__ is created*


This is the side effect of `time delay` between stream creation and the next command (module delete).


Might be nice to return false for Firebug 2.


Hmm, what do you think they should be?


Itt is ezen phase-ek lehetnének enumértékek.


enum-enum :)


fast-forwarding master to auto = b255b49e


r+


You forgot to rename pir4 to pir5 in protocol pir5 >

```
 return protocolInfo = {
    name: 'pir5',
    type: 'pir',
    values: {
```


no...?

On Mon, Mar 16, 2015 at 11:52 PM, Pranav Mathur <notifications@github.com>
wrote:

> can i copy this
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZachOhara/APCS/commit/a1e127eba48c928c413feb143338a0c6e8ec995f#commitcomment-10229971>
> .
>


*knows __it has happened__.* maybe?


Could we handle an empty pages index outside the loop, then only handle the non-null case here?


*change __the__ game state*


This is confusing: start = end


This commit for Job #531


habit. will reduce to `function ...`


`cb` should be the last argument, pass cssclass as an optional second argument of the form `{ cssClass: 'foo'}`


callbacks should be last argument


There's an issue for this: https://github.com/jOOQ/jOOQ/issues/2936. I guess this could be done, finally


update your view, change it around a bit. haha -- we're on the same page.

you cool with checking `CO.COM` via `[first, second]` or prefer `COM.COM` against `[second, first]` -- let me know. i'll await feedback.


saw approval from SimonSapin
at https://github.com/pcwalton/servo/commit/d10627a2b3f3887dd7276db05662afbd3369b32b


merging pcwalton/servo/transforms = d10627a2 into auto


pcwalton/servo/transforms = d10627a2 merged ok, testing candidate = 203240c1


new JUnit test for registrarion


On lines 177-180 i would write
```
stranded = !(   (b1 && (SquareBB[frontmost_sq(Us, b1)] & ourPawns))
             || (b2 && (SquareBB[frontmost_sq(Us, b2)] & ourPawns)));
```
which may be also faster because if first part fails (supporting pawn is found) then second part is not evaluated (Short-circuit evaluation)


missing newline at eof


This can be `compare(partitionStart, partitionEnd)`


*can __bring it to life__.*


this is no longer the case :-)
we should add an updated description of the class here


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1150 of 1151 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


Should be all lowercase


Dear @gmacdougall thank you for your feedback. I'm going to review that based in what is really need it. Thank you!


Extensions that need to make difference between FB2 and FB3 can use getFirebugVersion I think.
Would be nice to have version comparator though!

Honza


Hmm, if we do this, only the 'fixed' symfony components are locked to 2.6.4.. The other ones that are dependencies asre stil 2.6.5.. See a portion of what i'm getting:

```
  - Installing symfony/stopwatch (v2.6.5)
    Loading from cache

  - Installing symfony/routing (v2.6.5)
    Loading from cache

  - Installing symfony/debug (v2.6.5)
    Loading from cache

  - Installing symfony/http-kernel (v2.6.5)
    Loading from cache

  - Installing symfony/web-profiler-bundle (v2.6.4)
    Loading from cache
```

I wonder if this is what we want..


That's not very clear I think. Something like that would be better: "Returns a Java class that represents a Kotlin package. The methods and fields of this class are generated from top-level functions and properties in the Kotlin package."


This line must be also removed.


@rhb-anme is the *exact* redirect URI that has been set up in Instagram?


pinging @GawainLynch :koala:


nice ;) where i can get spells, creatures,.... etc for dreanor, panda, cata etc. ?


can you extend the example description a bit, i.e. briefly explain what the algorithm does or provide an external link and define what is the expected input format, when parameters are provided?


I think it's good to leave these in. The changelog is good for both the end-users and the developers, especially if the commits to the repository are piecemeal. It may also help users realize what might change or break when they use the application.  I've seen some projects list user-visible changes and internal details separately, but there are not so many things here to make that necessary at this time.

That said, I'm not the boss.


Please use complete sentences.


See above.


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


the content-type should be application/json.


Basic implementation for #19 generalized


Why is this "contains" thing removed? We have to decide based on tolerance level, which exploit are to be tolerated which aren't. why you replaced that with a simple Any() ?


You know? I read that thread last year, but had forgotten about it till now.  The "cool kids" remark stuck in my head back then and when I saw it again, I remembered.


> the commit message should point out, however, that the manual git config call is no longer necessary with this change.

Isn't that what I say with 'Pass core.autocrlf *only* as an option to "clone"' already?


Cool - doesn't appear to be much of value there worth preserving (any more).


Package private


Yea, exactly. I think its a good strategy for testing individual features
as long as we still have some more general tests.


test 1


79453838-AutomateSomeDocumentation (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.24%25-red.svg)


Haha ja, i ärlighetens namn så skrev jag ihop det där på nån minut bara, hade skitmycket att göra kvällen innan resan till Stockholm :-)


Maybe you could write a short paragraph about the general idea behind Akka persistence here?


`this` not needed


This was coincidence - test finder is ran sequentially before parralel even matters.


*__There are several things we'll__ need to implement in out `GameActor`:*


83782874_LBNL_ThermostatOffsetFault (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1645 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


remove this.


That should have changed to interiorColor, not vin, right?


Make the class final


We cannot change that If-series into  switch case statement because we are going like this
if tolerance is less than 10, then add Exploit A
if also tolerance is less than 9 then add B too
if tolerance is even less than 8 as well, then add C, D, E as well... also, this logic is run at runtime, we need to convert it into a constant dictionary or something so those if-checks aren't run everytime  bot has to determine whether to tolerate the exploit or not.


Which license is this, out of curiosity? Please make sure it's BSD/MIT-compatible, if possible. If not, let's talk further via email.


Ein Traum!


Sorry Mike, you're right. GitHub's collapsed text didn't show me the whole thing.


I think this needs some more detail. It's not a method, it's a property, and should be documented accordingly.


I think rendering related feature should be in osgDart/ShapeNode for osg or something in gui for GLUT viewer.


But when you add a dependency to a package that's not there you will have to have your own image anyway. It is a problem if you have a package with multiple authors that keep using new packages. If you don't plan to keep adding dependencies to this package then it's fine.

The biggest benefit is that you don't have to download R on your CI server every time (as opposed to travis and appveyor).


Unless you use zsh :wink:


Yeah. "cool kids" ;)


Also b1 and b2 should be constant

```
                const Bitboard b1 = ABEF_Stripe & b;
                const Bitboard b2 = CDGH_Stripe & b;
```


it is because you cannot do `int("")`


Some people choose to include Gemfile.lock in their repository. Want to do some investigation on why? I'm kind of curious. =)


did you run into any specific problems with jekyll 3?


OK, it's a defensible point. I'll change it.


disregard the first comment. Turns out git is installed in the container implicitely


These two methods should probably stay in `WindowOperator`


Nice


Not fully usefull since "Autoreload doesn't reload if modules imported by the tasks module change" see: https://github.com/celery/celery/issues/1025


Static import


Instead of creating a whole Event system for this. Reactive Framework has a ToEvent() extension method which could save you the creation of IMessage, the EventArgs, the delegate and this MessageQueue class.
Read more here: http://introtorx.com/Content/v1.0.10621.0/10_LeavingTheMonad.html#ToEventT


I don't think you are using the items keyword arg in the filter correctly. It is supposed to be list-like See the pandas documentation: http://pandas.pydata.org/pandas-docs/dev/generated/pandas.DataFrame.filter.html Try printing out the value filter to see the result of the operation that you have performed.


Given that this name is exactly the name of the class above plus a suffix, I would expect an inheritance relationship. I specifically avoided that with the old names, though the difference was subtle (the FB/Goog mixins lack the word "Test"). I would love to come up with something better.


It just doesn't seem like quite the right factoring to me. Ideally code inside Base would call `process_messages`, and the code for a custom transport would handle only what's different about that transport. In other words, it should be impossible to have a worker that *doesn't* call `process_messages`.


Done.


```
- `persistenceId` is the unique identifier of our persistent actor, used by the persistence mechanism to associate the stored events with our actor; here we'll use the `gameId` (which happens to be a UUID)
- `receiveCommand` handles new incomming messages, like `receive` in a regular actor
```

Quick note on using *a* before UUID: while the letter that starts UUID is associated with a vowel the sound it starts with when being read is a consonant and that's what decides whether you should use *a* or *an*.


>Messages you are trying to send to your friends

is more correct than

>Messages you are trying to send your friends

The latter sometimes sees usage, as native English speakers sometimes skip prepositions here and there, however it is not grammatically correct despite its colloquial usage.

The second change is correct however, I got myself confused when reading it the first time.


@mvidaurre check out #6194 I've done a first pass reviewing these, but would be good to have second eyes.


@josefs Please check.


Actually there seems no problem because we verified validateLength( flow, 6 ); before doing the assertions below.


Validation is missing in the Action model.


Oh right, I forgot about the alphabetiztion aspect of it.

I think I'd prefer having it sorted by status first and name second, but apparently the two of you think otherwise, so I'm willing to go with it.


Oh, we have to ask @delahee if they still use this. It allows #if mt , I'm not sure there are still such parts of haxe std


This doesn't appear to ever be called with create_user=False


One line


Still no need to do all the DB connection work twice. I'll submit a PR.

On Tue, Mar 17, 2015 at 3:48 PM, Shawn Allen <notifications@github.com>
wrote:

> Sorry Mike, you're right. GitHub's collapsed text didn't show me the whole
> thing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/18F/project-monitor/commit/e1db50c7eee49ba0387489dcb67cce27ba6b2ac2#commitcomment-10245151>
> .
>

--
Alison Rowland
Technical Lead, https://fbopen.gsa.gov | 18F
202-317-0124


This is never called with email


Same line


Please also drop the comment a few lines above that recommend this kind of restructuring.


Chain here


ACK. Actually the system doesn't call this method already.


@Ian-Stewart-Binks It seemed that on my graph_regions file, paths had a fill of "none", causing all of them to be interpreted as regions. Even if this isn't the case for your file (spooky), I don't think this change is incompatible with what you have... but please let me know otherwise.


I don't think the type parameter is needed


Wrap after the `&&`


That's why I removed it - I couldn't find anything calling it.

On Tue, Mar 17, 2015 at 3:55 PM Dawn Chen <notifications@github.com> wrote:

> ACK. Actually the system doesn't call this method already.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ncdc/kubernetes/commit/c08f41c18bf0e8823d08c65f0c0be05f51a6ce46#commitcomment-10245282>
> .
>


79453838-AutomateSomeDocumentation (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hmmm, I agree users should see what might cause changes and breaks, but the main question is whether they should see what doesn't cause changes and breaks... I understand that some projects communicate some technical internal details (I have [LibreOffice](https://people.gnome.org/~michael/blog/2015-01-29-under-the-hood-4-4.html) in mind), but they don't appear in the [changelog](https://wiki.documentfoundation.org/ReleaseNotes/4.4), which only list changes visible to the user. Do you have examples of projects with changelogs mixing the two?


> Reviewed-By: cjihrig <cjihrig@gmail.com>

should be `Reviewed-By: Colin Ihrig <cjihrig@gmail.com>` :)


We might need an [Unicode CSV writer](https://github.com/jdunck/python-unicodecsv).


Wrap


```
- `receiveRecover` handles the stored events when an actor is being restored/recreated; since our game's state is a single object with a method for applying events, we'll just delegate to it.
```


Unhandled Fundamental Failure


Use `partitionStart`


90447068-BalancedExhaust-Issue4711 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yeah, this was a debugging step that I accidently committed - already reverted and thanks for the catch!


I copy pasted the git author field :P lol I knew I couldn't get it right


Okay, but glad you figured it out! :) But I think it should be `getConfig()`, not `getconfig()`...


<!DOCTYPE>

<title>First Project</title>

Don't Know if This Will Work

 Trying Really Hard

I will get this.


lopez hernandez karina


karina


Missing the `extra_author_sources`


This would most certainly work.


shorthand property assignment


r+


Replace double `#` by single `#`


Consider not requiring dimensions to be integers? All modern browsers handle fractional CSS values, and the old ones do too (though in slightly different ways). You get fewer rounding errors in layout esp when large quantities of elements are stacking/flowing in percentages if you just let the browser do the rounding. Also, subpixel reporting is essential for high DPR displays. See info in column 4 here: http://cruft.io/posts/percentage-calculations-in-ie/


saw approval from jdm
at https://github.com/doublec/servo/commit/0d799915fff70a31df9279dcaecd5284037f0ac6


merging doublec/servo/view_source_protocol_and_plain_text = 0d799915 into auto


doublec/servo/view_source_protocol_and_plain_text = 0d799915 merged ok, testing candidate = 3e3c731b


Hey. You should just use knowledge_base.vegan_substitutions. Everything is pre-loaded.


`author_extra_sources` VS `extra_author_sources`


For this method, yes. Unfortunately overall you're still going to effectively have these keys stripped from your parsed results since there are additional checks to prevent overwriting prototype methods. See #73 for more comments.


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1650 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


ouch


Rather than using number for food groups, use the enums in enums.py. Ex, FoodGroup.POULTRY_PRODUCTS


I sadly had to revert b/c `Bugsnag` bower package doesn't have minified version :(


hi @Jannes123, you should make a PR and let others/our CI review your code first before pushing it to AIFDR repository..


Thanks for the feedback @Medros .  Are you saying changing jquery.ui to jquery-ui resolves this issue?  For reference this comes from the following issue: https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/793


ok, the application says Norton and the file is correct it says .DAT. When I open it, it just tells me to login into Norton ....


```cpp를 써보세옇

```cpp
template <class T>
T GetMax (T a, T b) {
  T result;
  result = (a>b)? a:b;
  return (result);
}
```


rax retry tests


How would you prevent event bubbling now? Seems like event.stopPropagation() is gone.


82706250-AdaptiveConvectionNew (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1149 of 1149 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.65%25-green.svg)


What for?

[w3.org](http://www.w3.org/TR/html401/interact/forms.html#form-controls):
>The elements used to create controls generally appear inside a FORM element, but _may also appear outside of a FORM element declaration **when they are used to build user interfaces**_

When submitting the information to server isn't needed the form element isn't needed either, moreover we don't even have a `submit` element.


Sleeping over this, I stumbled across a few questions:
- Will this PR in the end also include an updated UPnPDiscoveryService using this new feature?
- There does not seem to be any test about using allThingsRemoved at all?
- What are the concrete use cases where we would use TTL? Although it sounds like a good idea - when contemplating about it, I could not come up with any example. Can you?
- I think the main feature required is a "delete every discovery result of my supported thing types that I did not discover on the latest full scan". Example UPnP: When doing an active scan, it finds 10 devices, but had 15 in the inbox before. All "outdated" ones should be removed. We need to avoid deleting all 15 entries first and later on add the 10 current ones - this would lead to "flickering" of devices that were and still are present. (The MAX! binding e.g. does a full scan every 20 seconds - a discovered cube should not be removed unless it really disappeared). Is this something you have on the radar?


Clean flash with this commit produces a no sim card found error.

Also, seems to fix VoLTE, but breaks headset speaker


My concern was that there could be meta data with video links that were
created by hand, in which case your code would ignore some activity records.

I.e. there are two videos as part of an activity, the one that is been
added as part of the link in the activity record and the other is in the
metadata, when this code executes, it will not add another meta entry for
the first video.

I also am not sure how this relates to Google+ changing anything.  I will
conduct more experiments and list all the so-called malformed videos.

Best

Patrick Martinent

On 17 March 2015 at 04:57, Mauro Solcia <notifications@github.com> wrote:

> As per pointed out in this comment
> <https://github.com/patt0/gde-app/commit/2255cd71636c5d76b02a2dc34a15c5648cdcc21f#commitcomment-10213994>
> it's most likely that Google + change the shared URL to one different from
> the one we are going to input in the meta.link.
>
> I think we could instead do something like this gist
> <https://gist.github.com/SmokyBob/17235b15865fdbb98c78>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/patt0/gde-app/commit/f0512f47eca2b8cfc6eb2a78e460de0d7816b857#commitcomment-10225455>
> .
>


Sorry!  Still learning my way around github, trying to undo this commit right now.


omg proof tti stole from ttr!111!!!11


omg omg omg !!!!1111oneoneone!!!
i love how they put "Community Puppetmaster" XD

On Mon, Mar 16, 2015 at 10:21 PM, CrazyClyde <notifications@github.com>
wrote:

> omg proof tti stole from ttr!111!!!11
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ToontownInfinite/src/commit/88f72f56834560a19866f2e462c73924e435c45b#commitcomment-10227444>
> .
>

--
  Best of hopes on your new application from Scottdaguy, Drewciarblox and
the founder of SupernovA Jaso98


So you didn't go for a `namedtuple` approach after all? Is there a specific reason?


À voir avec le frontEnd, mais je crois qu'on ne gere pas le tri de commande par date, ni par prix.


Some testing of setup/composerit.php snippets in an old xampp:

```php
        // Test working, Psycho
        chdir('../');
        echo '<h3>Step 1: Trying to download Composer:</h3>';
        #$composerfile = readfile('https://getcomposer.org/installer');
        $composerfile= file_get_contents('https://getcomposer.org/installer');
        file_put_contents('composerinstaller', $composerfile);

        echo 'Download done'.'<br>';

        $result0=shell_exec('..\\..\\php\\php.exe composerinstaller 2>&1');
        echo '<strong><pre>Result0:'.$result0.'</pre></strong>';
```

output:
```
Download done

Result0:Some settings on your machine make Composer unable to work properly.
Make sure that you fix the issues listed below and run this script again:

Your ionCube Loader extension (3.3) is incompatible with Phar files.
Upgrade to ionCube 4.0.9 or higher or remove this line (path may be different) from your `php.ini` to disable it:
    zend_extension = /usr/lib/php5/20090626+lfs/ioncube_loader_lin_5.3.so

The php.ini used by your command-line PHP is: C:\xampp\php\php.ini
If you can not modify the ini file, you can also run `php -d option=value` to modify ini values on the fly. You can use -d multiple times.

Your PHP (5.3.1) is too old, you must upgrade to PHP 5.3.2 or higher.

The php.ini used by your command-line PHP is: C:\xampp\php\php.ini
If you can not modify the ini file, you can also run `php -d option=value` to modify ini values on the fly. You can use -d multiple times.
```


For us it does but to block any merge issues I added a map config in
require to remap jquery.ui to jquery-ui.

It's basically how the file is named in jquery ui's case it's jquery-ui.

I don't want you to change it again right now just incase it causes anyone
else issue. If anyone else runs into this and they are using require.js you
can point them at the require config docs and add a map config.

{ map: { "*": { "jquery.ui": "jquery-ui" } } }

This will make it so that when you require/define a module it will use that
map before it attempts to find a file jquery.ui
On Mar 16, 2015 8:15 PM, "Trent Richardson" <notifications@github.com>
wrote:

> Thanks for the feedback @Medros <https://github.com/Medros> . Are you
> saying changing jquery.ui to jquery-ui resolves this issue? For reference
> this comes from the following issue: #793
> <https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/793>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trentrichardson/jQuery-Timepicker-Addon/commit/8c597e858143d8de3c315d7273cb44b9b72c5c17#commitcomment-10227370>
> .
>


@CrazyClyde You are 9 months late.


by auto-localize I minerals will detect the user's language and choose the appropriate localization file.If nothing is defined, the raw t() text will be shown and I believe an error will be logged to console. (You should write tests to test that every localized term is defined, they're quite easy to set up.)


@DentonA
I think, in this case you should separately check, that user has not received previous branch (NOTIFICATION_BRANCH) notification.
Because assertNotificationsNotSent(topic, topicCreator) checks only new branch (BRANCH_NAME_TO_MOVE_TOPIC_IN) notification.


Bon choix pour le theme. J'aime.


Should be able to just set GOPATH instead of this, will test.


Est-ce que ça serait pertinent d'ajouter le numero de commande afin de faciliter la job des ti-gars d'entrepôt?


Work by Sampada, no Github issue - such a wonderful work and no documentation.


i am 9 months early :D
Also glad to hear tti is coming back. ;)

On Mon, Mar 16, 2015 at 10:24 PM, Kevin <notifications@github.com> wrote:

> @CrazyClyde <https://github.com/CrazyClyde> You are 9 months late.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ToontownInfinite/src/commit/88f72f56834560a19866f2e462c73924e435c45b#commitcomment-10227473>
> .
>

--
  Best of hopes on your new application from Scottdaguy, Drewciarblox and
the founder of SupernovA Jaso98


what default value?


Ok, sounds good.  Thanks again @Medros


This would bomb if a nil config (which is valid) is passed.  I'd move the section below which sets the default config above this line and change the `upgradeManager` signature to take the entire config struct instead of the individual entries.


Ryan,

In your edit, you have the following production, and
my comments apply also to the code for  "primary_value tCOLON2 paren_args"

2501 | primary_value '.' paren_args
2502  + {
2503  + yTrace(vps, "method_call: | primary_value tDOT paren_args");
2504  + omObjSType *srcOfs = RpNameToken::srcOffsetO(vps, $2);
2505  + omObjSType* sym_call = RpNameToken::s("call", srcOfs, vps);
2506  + $$ = RubyParser::new_call($1, sym_call, $3, vps);
2507  + }

The sym_call variable at line 2505 is totally not safe with respect to GC.
The srcOfs is ok because RpNameToken::srcOffsetO returns a SmallInteger (or perhaps nil)
but a Symbol is a real object, subject to movement by in-memory GC .
Since sym_call is passed directly into RubyParser::new_call and
RubyParser::new_call is responsible for putting it's args into handles
before anything that would cause gc, this would be ok.  However
a safer style is as follows (similar to code for  "stmt kRESCUE_MOD stmt"
near line 790 in grammar.y .  Then if some other call to a parser function
or om:: function is added between line 2505 and 2506 the symH would be
safe from GC .

 | primary_value '.' paren_args
    {
    yTrace(vps, "method_call: | primary_value tDOT paren_args");
    omObjSType *srcOfs = RpNameToken::srcOffsetO(vps, $2);
    OmScopeType scp(vps->omPtr);
    omObjSType** symH = scp.add( RpNameToken::s("call", srcOfs, vps));
    $$ = RubyParser::new_call($1, *symH, $3, vps);
    }

Since the symbol has a constant value "call" , a more efficient implementation
would be as follows, to allow the symbol object to be initialized once at
parser initialization.

--- a/src/kernel/parser/rubyast.ht
+++ b/src/kernel/parser/rubyast.ht
@@ -229,6 +229,7 @@ typedef enum {
   a_sym_BEGIN,
   a_sym_while,
   a_sym_rest_args,
+  a_sym_call,
   a_sym_INVALID,
   NUM_AST_SYMBOLS // must be last
 } AstSymbolEType ;

--- a/src/kernel/parser/grammar.y
+++ b/src/kernel/parser/grammar.y
@@ -3654,6 +3657,7 @@ static void initAstSymbol(om *omPtr, NODE** symbolsH, AstSymbolEType e_sym
     case  a_sym_BEGIN:         str = "BEGIN";  break;
     case  a_sym_while:         str = "while";  break;
     case  a_sym_rest_args: str = "rest_args";  break;
+    case a_sym_call:  str = "call"; break;

And then you can code the production like this:

 | primary_value '.' paren_args
    {
    yTrace(vps, "method_call: | primary_value tDOT paren_args");
    omObjSType *srcOfs = RpNameToken::srcOffsetO(vps, $2);
    $$ = RubyParser::new_call_1($1, a_sym_call, srcOfs, $3, vps);
    }

Allen


some tests failed:
failure: http://build.servo.org/builders/mac2/builds/1242


As noted below, I suggest changing the signature to accept the entire config struct so it won't have to be changed in the future if any new information is needed.


测试


This should be exported since it's used in  the `Confg` struct.  It'll need a comment too once exported.


Thanks, I have edited the code to fix this.

> On Mar 16, 2015, at 9:09 PM, Adam Snyder <notifications@github.com> wrote:
>
> Rather than using number for food groups, use the enums in enums.py. Ex, FoodGroup.POULTRY_PRODUCTS
>
> —
> Reply to this email directly or view it on GitHub.
>


Please disregard this, still learning my way around github and accidentally used commit on the master file.


saw approval from jdm
at https://github.com/mattnenterprise/servo/commit/f0835831327aab10b82e061b239cc287a132024b


merging mattnenterprise/servo/page_load_thread_name = f0835831 into auto


mattnenterprise/servo/page_load_thread_name = f0835831 merged ok, testing candidate = 990a965d


Regarding:
`session.currentUser.reviewedOffers.@each`

I thought `reviewedOffers` is defined on user not userProfile so the alias that was there before was correct. Alternatively to avoid confusion with session and controller having the same property name but of a different type how about this since it doesn't look like we're using the currentUser property:

```js
reviewerOffers: function() {
  var currentUserId = this.session.get("currentUser.id");
  return this.store.all("offer").filterBy("reviewedBy.id", currentUserId);
}.property('session.currentUser.id')
```


leave comment on line to test rebase


```harvest_app``` will still be ```null``` if it goes to else clause, causing ```harvester_app.after``` to throw, is this intended?


thank's Lars

I don't know who request this. only for my proyect I can request? I search
this.

the history about this .txt file are.
The first version run in a wince ipaq machine, for edit only have the
notepad and launch when files are .txt
never change this (making a .r4 file or something), but the idea for system
without .exe (the .txt are executable sources) like me.

Best Regards
Pablo

2015-03-16 15:23 GMT-03:00 Lars Brinkhoff <notifications@github.com>:

> Hello,
>
> Would you consider your language to be a kind of Forth? If so, I could
> send you a pull request to make GitHub classify the .txt files a Forth.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/phreda4/reda4/commit/30f3a1ad36c8d83415f92438669b717be3a9caf4#commitcomment-10220333>
> .
>


```!mappingFile``` will do :)


81606030-Cooling-airflow-rate-being-used-in-heating-mode-for-variable-speed-cooling-coils-(Github-#4564) (rraustad) - x86_64-MacOS-10.9-clang: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


r+


[ci skip]


For reference, needs two tabs here, not spaces. I'll fix it.


Wow, thanks, I'm a dork.  Not sure why I didn't see that refactor before.


sp.  s/Invlalid/Invalid/


This should be an [en dash][1] (as it should be for all algorithms named after multiple people), that's why there were two dashes there. Restructured Text is smart, it should be able to handle the real Unicode en-dash: –.

[1]: https://en.wikipedia.org/wiki/Dash#Relationships_and_connections


I'm not familiar with the requirements, maybe just ping me to help me understand.

1. Are we updating mapping with no strategy to migrate data? (Fine if that's the requirement)
2. We seem to warn about update deleting the index, but we go ahead and delete it anyway. Maybe this should go in docs?


Don't need the wrap it in ```else``` here, throw will exit anyway


Did this do it? (Is there still a spike on the hour?)


lol whoops


@tchaikov , in the (oid.snap == CEPH_NOSNAP) case, can_create is true, and obc is non-zero, pmissing will not be set to head.

  if (oid.snap == CEPH_NOSNAP) {
    ObjectContextRef obc = get_object_context(head, can_create);
    if (!obc) {
      if (pmissing)
	*pmissing = head;
      return -ENOENT;
    }
    dout(10) << "find_object_context " << oid
	     << " @" << oid.snap
	     << " oi=" << obc->obs.oi
	     << dendl;
    *pobc = obc;

    if (can_create && !obc->ssc)
      obc->ssc = get_snapset_context(oid, true);

    return 0;
  }


additionalSlinkyGHXWork (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1644 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.34%25-yellow.svg)


additionalSlinkyGHXWork (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yeah I just pushed it up for safe keeping it still needs some tweaking.

On Mon, Mar 16, 2015 at 10:19 PM, David Smit <notifications@github.com>
wrote:

> Clean flash with this commit produces a no sim card found error.
>
> Also, seems to fix VoLTE, but breaks headset speaker
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/razrqcom-dev-team/proprietary_vendor_motorola/commit/8f0bb5e57c1116b542201118a3f74f903067c7c8#commitcomment-10227416>
> .
>


TeamCity Helios :: Helios PR Build [Build 15](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=268&buildTypeId=Helios_HeliosPrBuild&guest=1) is now running


81606030-Cooling-airflow-rate-being-used-in-heating-mode-for-variable-speed-cooling-coils-(Github-#4564) (rraustad) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why are bus routes stored in an array, instead of a hash? Every time you want to find a route, you do a linear search (unnecessarily) vs the constant time access time of hashes. If anyone else needs an array of bus routes, then you can just write a wrapper function that squashes the hash into an array.


ah yes this is important :(


TeamCity Helios :: Helios PR Build [Build 15](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=268&buildTypeId=Helios_HeliosPrBuild&guest=1) outcome was **UNKNOWN**
Summary: Canceled Build time: 00:01:15


Yup, we're on Ch 16 this week :thumbsup:


TeamCity Helios :: Helios PR Build [Build 16](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=269&buildTypeId=Helios_HeliosPrBuild&guest=1) is now running


Man, I could've sworn I'd tried this - I have no idea what I actually tried now.  WTF.  Thanks, man, I'll switch these all over to lodash and drop deepMerge.


TeamCity Helios :: Helios PR Build [Build 16](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=269&buildTypeId=Helios_HeliosPrBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 107, ignored: 19 Build time: 00:00:57


11/10 - ign gem uf teh yeer
Gud wurk. Kiep tit up.
Kthxbai


Added a line to decode the url and all that is left are the play lists
which we will NOT support for now.

https://github.com/patt0/gde-app/commit/4814c9ef34a2c7c378ba46f57a5163f088a71003

Patrick Martinent

On 17 March 2015 at 07:50, Patrick Martinent <patrick.martinent@gmail.com>
wrote:

> My concern was that there could be meta data with video links that were
> created by hand, in which case your code would ignore some activity records.
>
> I.e. there are two videos as part of an activity, the one that is been
> added as part of the link in the activity record and the other is in the
> metadata, when this code executes, it will not add another meta entry for
> the first video.
>
> I also am not sure how this relates to Google+ changing anything.  I will
> conduct more experiments and list all the so-called malformed videos.
>
> Best
>
>
> Patrick Martinent
>
>
>
> On 17 March 2015 at 04:57, Mauro Solcia <notifications@github.com> wrote:
>
>> As per pointed out in this comment
>> <https://github.com/patt0/gde-app/commit/2255cd71636c5d76b02a2dc34a15c5648cdcc21f#commitcomment-10213994>
>> it's most likely that Google + change the shared URL to one different from
>> the one we are going to input in the meta.link.
>>
>> I think we could instead do something like this gist
>> <https://gist.github.com/SmokyBob/17235b15865fdbb98c78>
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/patt0/gde-app/commit/f0512f47eca2b8cfc6eb2a78e460de0d7816b857#commitcomment-10225455>
>> .
>>
>
>


no worries, I think there was a lot of confusion because deepMerge became a monster it wasn't mean to :smile:. deepMerge === (_.merge || _.clone || _.cloneDeep || _.defaults) afaict


This is a test comment


@david-yz-liu  Which paths? The normal paths should be interpreted as normal, since they don't contain the 'z'.

Can you identify a path by the id attribute in the graph_regions file that this happens to?


I'd say Groff is similar to HTML and TeX, which are both `markup`.  (I guess an argument could be made that TeX should be `programming`...)

At first I thought Inno Setup looked like some INI variant, but apparently can contain code, so `programming`.

LilyPond is some kind of notation for music.  Ok, upon closer examination, it may embed Scheme programs which would qualify as `programming`.

Gettext Catalog are just translated strings, so I'd say `data`.

As for Darcs Patch and Diff, I guess they often do contain snippets of code, but they don't provide any programming features themselves.  `data`.


do you have pympsse installed correctly?


*state (__stored in it's `game` field__)*


OK, I see your point. I'll use your suggestion then.


Please.....

server_list.txt is in this repo as an example of correct usage, not intended for personal usage.

This commit has overwritten correct usage, with an incorrect usage.


> Might be nice to return false for Firebug 2.

I agree. Version compare is too low-level for something so frequently used.


I handled it like this:

````
git log | grep username
````

And just took the last line there. Not totally error-prone though :)


Excuse my rusted C expertise here: could this not be part of the following switch statement?


Argh!! So this is what was happening to all of my titles. I switched to `**What it does**` because I just assumed that I was terrible at rST.


@david-yz-liu Ah yes I see the problem now. I'll see what I can do.


Thanks, @jungshadow.  My only comment on this PR (I trust you did the line ending conversions correctly) is that with `text=auto`, I'm not sure it's necessary or desirable to add `* text eol=lf`.  `text=auto` by itself should ensure normalized LF line endings in the repo (e.g. see [here](http://schacon.github.io/git/gitattributes.html)).


I have already had my server_list.txt removed once from this repo, then I put it back, and now have it overwritten .

please play kindly in my git.


Why not change this to _DEFAULT_BIN_PATHS and leave the MDADM or STORCLI stuff out all together?


I'm not sure this is the correct behavior


I even server_list.txt in the .gitignore file to prevent it from being overwritten...


Instead of changing the name of the node. I would just add something like "ordinality=%s" at the end. Similar to how the AggregationNode is printed when masking is present


@david-yz-liu All clear, thanks for the change!


We usually want full names, so it should be pretty easy to spot.


Here's a fun trick:

```js
else if ('CO' == first && ~COLOMBIAN_DOMAINS.indexOf(second))
```


:boom:


I've found better results with `git log --grep="somestring"` instead of `git log | grep somestring`.


For everybody else:

> A value of zero causes the thread to relinquish the remainder of its time slice to any other thread that is ready to run. If there are no other threads ready to run, the function returns immediately, and the thread continues execution.

Since the special meaning doesn't appear in the POSIX port, I don't see any way we'd ever use `__wt_sleep` in that way, and, we already have a version of  that functionality in `__wt_yield`, so why wouldn't our code use `__wt_yield` instead?

I'd remove it; if you really want to keep it, I think it needs a pretty big comment to make sure the next person doesn't remove it.


yes! will fix in the pull request asap.


These are really properties of `RemoteTabs`, no?


*an event __to the `ActorSystem`'s default `eventStream`__*

I'm lowering the case on `EventStream` since when I say it this way it refers to a field.


Oh, you're using this as the storage schema, too. So only `GUID` needs to go.


search_property is listed twice in the import section.


Suggestion, the if statement above can be rewritten to be simpler, more readable and less error-prone:

```Go
execpath = strings.TrimSuffix(execpath, deleteSuffix)
```


This is upstream code I'm simply moving around here, not anything new. Also, this patch has been accepted and integrated upstream "as is" now (see https://git.fedorahosted.org/cgit/system-config-printer.git/commit/?id=320b77b21da9b738788ca147edbf21ed06e32ddb), so I'd rather not change this commit now, not to diverge, if that's ok.


Yeah I don’t really mind not having every dependency of my package
installed and I don’t want to make a custom docker container just for my
package. I just want to have the most common package dependencies already
installed + pandoc, latex ect, which the rocker/hadleyverse package should
accomplish.

Unfortunately it doesn’t look like there is support for using custom
.drone.yml directly with the drone.io service, you have to use one of their
predefined languages, so this experiment is probably going to be put on the
shelf for now, I will just have to live with the horribly slow travis
builds.

On Tue, Mar 17, 2015 at 3:50 PM, Kirill Sevastyanenko <
notifications@github.com> wrote:

> disregard the first comment. Turns out git is installed in the container
> implicitely
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jimhester/covr/commit/278e52b2611f0efa971da62cc30c2d16d9a6dab8#commitcomment-10245188>
> .
>


This isn't thread-safe, although use of this cache can be accessed from multiple threads when used within a region server that is serving multiple regions. Probably the easiest way to get around this is to use a Guava cache.


Tabs don't have their own GUID, at least on the Sync side. By all means use a numeric ID for the primary key.


I agree that's the most common refactoring technique, however there are [more than that](http://en.wikipedia.org/wiki/Code_refactoring#List_of_refactoring_techniques). My understanding of the verb *refactor* is more what modern programming IDEs imply: a collective term for everything from renaming variables to extracting code for reuse into a library.


If we'd like to show IDE specific banners, they should be provided by ENV variables.


@ntdb Why pass these parameters to update_all_courses here and below? When that method receives a non-empty hash of raw ids, it skips the call Wiki.course_list, so we can't test the difference between a delisted course and a deleted course.


Should this comment not be converted to a logging command stating: "we have passed through lines of actually unreachable code"?


*We __perform__ other actions __depending on what event was applied. We omit them here for brevity.__*


@rqueue the BRWireframe base class does all of the things the BRModuleWireframeInterface did (in the form of abstract methods) so we can actually delete that interface. Also, there is no place in the app that references a wireframe via the interface - wireframes always know all about each other.


Ok, so what about isFirebug2Installed and isFirebug3Installed?
(hm.. not the best names)

Btw.I don't know another way how to diff between FB2 and FB3 synchronously than compare versions from bootstrapped addons info.

Honza


I am restoring this file as it represents the correct usage for server_list.txt.
This sample file is in .gitignore, so that it cannot be accidentally overwritten.


Using MAXINT32 alone will cause and error since the number it's too big for D-Bus. I believe that's because python-dbus expects seconds instead of milliseconds here, hence the division. In any case I need to use something smaller than MAXINT32, that's for sure, so I'd rather keep this since I know it works.


Sure! Will do so tomorrow.


Actually, given that the class above no longer contains any test functions, I think it would make sense for these to actually inherit from that.


Will do this tomorrow, too ;-)


empty file


we could also keep it if we think we will find value by referencing only via the protocol. But, in practice, I'm not sure where that would be.


@RawKStar77 thanks for adding this note! Could you link to http://anno.fund/ instead?

It's live, just not announced.


The forId method is a static method in DateTimeZone, not CachedDateTimeZone, so calling it like this is confusing. This should just be a call to CachedDateTimeZone.forId.


I think it would be better to put common/djangoapps/util/test_third_party_auth_util.py in common/djangoapps/third_party_auth/tests/utils.py


If you don't mind spending $10/mo you can have drone builds for your packages https://www.digitalocean.com/pricing/
But unfortunately others won't be able to see the logs... Which is kind of pointless of OSS
Or if you let them, they will also have enough priveleges to test their own repositories :)


Hm, wait, bootstrappedAddons is a string, so this cannot work. I guess you meant to do JSON.parse or so.


This line doesn't seem to compile (seems there isn't an IllegalDataException constructor that takes two parameters). Could you also verify that the full ConvertTimezoneFunctionIT tests pass?


I can buy that. Done.

On Tue, Mar 17, 2015, 13:07 Dmitri Shuralyov <notifications@github.com>
wrote:

> Suggestion, the if statement above can be rewritten to be simpler, more
> readable and less error-prone:
>
> execpath = strings.TrimSuffix(execpath, deleteSuffix)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kardianos/osext/commit/e61421bbfae9c64ff5836c1776b58b2deb34269f#commitcomment-10245488>
> .
>


Thanks for this :)
How can i update my meeblip se ?


sory.. btc.exe not work


> Ok, so what about isFirebug2Installed and isFirebug3Installed?

How about, `isFirebugInstalled`, `getFirebugVersion`, `getFirebugMajorVersion`


test_run_scripts/git_source/all_tests-pe-centos6.sh  - now gives errors running pre-suite/02_pe_r10k.rb; beaker errs prior to the tests running.

test_run_scripts/all_tests-pe-centos6.sh  - 2 erred tests:
tests/git_source/git_source_git.rb - errs on line 95 with "xinetd class not found," and:          tests/git_source/git_source_ssh.rb - errs on line 38 with "mv: cannot stat `/etc/r10k.yaml.bak': No such file."


I still miss the statement whether moving the `-c` to the right of the `clone` argument is reliably writing the setting to `.git/config` or not... I am really unsure whether this is guaranteed by Git.


The ones we've lock down pass Travis and Codeception… I don't know basically…

Being a point release; a) Symfony shouldn't have done this to us; b) the others shouldn't matter.

We need to test before further releases, but Fabien deserves a kick in his butt for this one.


Are we ok with amend + force push for minor stuff like this?


I don't feel that strongly, so I'll remove it.


> Version compare is too low-level for something so frequently used.

(My thinking is not so much that it is frequently used, only that Firebug 2 and 3 are separate products and any behavior that depends on Firebug being installed, and that uses the new API, would very likely only work with Firebug 3.)

>  (hm.. not the best names)

No... For instance we will eventually get Firebug 4, 5, etc.


*with __the__ following routes*


My only comment -- is this the appropriate way of travelling up a directory tree? (I used a check for `dir.empty()` as `parent()` should set the directory to empty if there is no parent; ie, we're at root)


Woops in haste forgot to remove some commented lines of code, sorry ><


Ah, nice technique to separate the world save data from the jar, properties, and other bits. Perhaps we should make `/minecraft-data` a standard part of the `minecraft-server` image itself.


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/test03/app.js)


some good stuff


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (641 of 642 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.27%25-green.svg)


make this an if to match the style you added in visitUnnest (or switch that one to a ternary operator)


It would be nice if we had formal definitions of the types, for the next times...


I'm reading the [help for git clone](http://git-scm.com/docs/git-clone.html) in such a way that *all* options need to go to the right of the command. In fact, I was very surprised that git did not choke on your original syntax.

As a side note, `git clone -c core.autocrlf=false` is what the MSYS1-based SDK installer [has been using](https://github.com/git-for-windows/sdk/blob/master/installer/installer.iss#L24) successfully [all the time](https://github.com/git-for-windows/sdk/blob/master/installer/installer.iss#L74).


I'll start out by saying that it's a real step up to not be using string literals here.  Thanks for making this change.

One thing we'll need to resolve (in future pull requests) is whether `jss` is the right place to be getting the names of `SField`s since the `SField`s themselves know their names..  I suppose the `SField`s could get their strings from `jss`.  At any rate we should eventually harmonize the string source.


How do you think about to add quotes around two more variables here?


I'll come through these and stub in the current user :soon:


I've always been confused by this as I thought that at the root
path.parent() returned the root. Here are the docs which I still can't make
sense of:

http://www.boost.org/doc/libs/1_46_1/libs/filesystem/v3/doc/reference.html#path-parent_path

Perhaps my test is working because eventually we get to empty and then the
parent of an empty path is is also empty?

On Tue, Mar 17, 2015 at 4:15 PM, Kevin Ushey <notifications@github.com>
wrote:

> My only comment -- is this the appropriate way of travelling up a
> directory tree? (I used a check for dir.empty() as parent() should set
> the directory to empty if there is no parent; ie, we're at root)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstudio/rstudio/commit/3e1c1a3f4c07c935c0174b4120701eb616a3cd38#commitcomment-10245654>
> .
>


requests is third party, so it should not be grouped with __future__


Sorry, you misunderstood what I meant. The entire if statement can be replaced:

```diff
-if strings.HasSuffix(execpath, deletedSuffix) {
-	execpath = execpath[:len(execpath)-len(deletedSuffix)]
-}
+execpath = strings.TrimSuffix(execpath, deletedSuffix)
```

If you look at the source of `strings.TrimSuffix`, it already performs the `HasSuffix` if check:

```Go
// TrimSuffix returns s without the provided trailing suffix string.
// If s doesn't end with suffix, s is returned unchanged.
func TrimSuffix(s, suffix string) string {
	if HasSuffix(s, suffix) {
		return s[:len(s)-len(suffix)]
	}
	return s
}
```


Nevermind. I've satisfied myself that it's a good test even when we pass the rawids. We just have to *not* pass the delisted id we're testing for here.


verrrry niiiice!


Hi, can i use this script with phonegap? Thanks


Damn seeds.


prevents N+1 query


I think it would make more sense to group oauth2_provider with provider than with django


sweeeet.


Use absolute import


Hier bin ich mir nicht sicher ob das so geht. Hab mir grad den cider-nrepl kaputt gemacht irgnedwie :(


Site is starting to look nice!


I originally had this as a scope on the CourseInstance class, but Rails couldn't figure out to not do needless N+1 queries, so I'm doing it this way instead


orders button in effect!


hey andy,
this looks like a good start. for future commits, i’d recommend splitting them up so that they’re a bit more atomic; e.g., the removal of the app/views/_patterns/ folder could have been its own commit, which would have made it easier to identify that change vs the one that begins to integrate the mustache templates.


This sed line is actually fairly safe. By anchoring, `source:.*$ will only match lines on the root level, so it's impossible to craft something later in the file which matches this.


Seeing this pylint directive makes me wonder if it would be better to instead have a `get_auth_entry_value` method that can raise NotImplemented in this class and be overridden by subclasses.


nice work!


Yeah, wrong copy paste, should be fixed at:
https://github.com/firebug/firebug.sdk/commit/4bb5a86bed08821cfbf5f8424f3aef871cbea1b3

@cadorn: any tips how to make changes in modules without npm publish and npm install in extensions after every commit?

Honza


@me4oslav What's libmtp?


a sufficiently strange defaultjson URL could break out of shell quoting or yaml quoting. then again, someone could just edit the file manually and mess it up.

% encoding or a real solution like local config avoid this.


@Icesory Damn you were faster ;)


I must admit that I don't know. This is the already existing code for saving the waypoint with less indentation - didn't touch that. I can have a look nevertheless.


looks good to me


Could this be done with something like `course_instance.any?(&:schedulable)`


> How about, isFirebugInstalled, getFirebugVersion, getFirebugMajorVersion

Yep better

Honza


v view_worker je še hrošč... v scripturl manjka eno podpičje...


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1035
success: http://build.servo.org/builders/linux2/builds/1035
success: http://build.servo.org/builders/android/builds/1069
success: http://build.servo.org/builders/mac1/builds/1251
success: http://build.servo.org/builders/mac2/builds/1251
success: http://build.servo.org/builders/gonk/builds/222


Is there any summary for changelog?


saw approval from aberghage
at https://github.com/basho/riak_pb/commit/ed7b6e68b53f87ce9b9d081e81d722fe9773f787


merging basho/riak_pb/zl/add-optional-timeout-to-RpbYokozunaIndex = ed7b6e68 into borshop-integration-112-zl/add-optional-timeout-to-RpbYokozunaIndex


basho/riak_pb/zl/add-optional-timeout-to-RpbYokozunaIndex = ed7b6e68 merged ok, testing candidate = 78c50efa


Sorry again for a nagging question: at least to me, those return values could be represented by the enum you defined at https://github.com/irungentoo/toxcore/commit/ea8d27259f7d0314b08f6eb32edf15fec3822530#diff-a58028aec4211a18b170732935eba2e3R1542 That at least would remove the duplication and keep all return codes in a single place (the enum definition).


Only because it's clever :P


Yes, should have figured it myself :)
Works as expected.
See 7eb7d1111d30e735c258ffb18bc24d8a4dadeb6d now


90447068-BalancedExhaust-Issue4711 (mjwitte) - x86_64-MacOS-10.9-clang: OK (1645 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


"><img src=x onerror=alert(0)>


*give __you a__ basic idea of how __a CQRS/ES-based__ application*

Also, are you sure you want to use *could* in this sentence? I find it confusing. Are you trying to imply there are other significantly different ways it could look while still being CQRS/ES?


No you were faster. I have started my pc to merge the pir and see you have it already done ;)


Yup


language != MD2 ;)


Ok, thanks for your answered.
Perhaps I don't override correctly the errorPage process.


Isn't that another pr ;)

On Tue, Mar 17, 2015 at 7:31 PM, Ragnar Þór Valgeirsson
<notifications@github.com> wrote:

> This should probably be removed, doesn't make sense in our project structure.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aranja/gulp-base/commit/0a41f37d8613a44c3f8d68079739e24b57f32caf#commitcomment-10244829


fast-forwarding master to auto = 203240c1


Yes!


And here we need to pass the 9999 value in the hash, because we're testing for a course that is listed but doesn't actually exist on Wikipedia.


Interestingly, my approach to the unit tests side-steps JSON altogether.  I'm not saying that's better (although I personally prefer it), but it certainly is different.


I was having issues getting `jekyll serve --watch` to reliably reload resources. I've since learned that it had to do with some optimizations Jekyll was making to support partial rebuilds -- so I probably could have fixed it by disabling that. But the hiccups were enough to convince me to just wait for Jekyll 3 final.


+1 for blue


See comment on line 293 for the double sched loop. You need to do one loop for excuting and the second one for consuming result.
I did not try to ensure it was necessary in my case, just copied-pasted it.

The case was failing before the fix, you can give a try. The svc.modified_attributes is 0L atteh beginning and svc.retry)interval is 5


I believe the issue is that the default maven repository used by AndroidStudio (jcenter) doesn't have the updated packages yet. If you switch to the following in your build.gradle file (and clear caches if necessary), it should work:

```groovy
allprojects {
    repositories {
        mavenCentral()
    }
}
```
Or you can wait for a few hours to see the updated packages.