`sanitizeOperators` should be changed to only operate on the values of fields when the key is actually an operator. For example, the user can specify as an update `{foo: {}}` which means to replace the document entirely with the specified object. In this case, removing empty-object values would change the semantics of the request.

IMO we should provide an even stronger constraint, namely that we should whitelist specific operators for which this treatment is allowed. I think it's better to err on the side of safety here because having mongo barf on a particular query which we didn't sanitize is easily fixed, but accidentally and silently changing the semantics of a query is not.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2221](http://teamcity.monogame.net/viewLog.html?buildId=5648&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 444, ignored: 6 Build time: 00:13:53


Sorry, I cced you in the PR on this stuff.
We talked with @iron76 . This seems to us the best thing to do also at firmware level (it means ask modification for the firmware, yes)


Previous command rendered an error:

```bash
$ cordova plugin remove jxcore-cordova/io.jxcore.node
Plugin "jxcore-cordova/io.jxcore.node" is not present in the project. See `cordova plugin list`.
```


Can you add 30px bottom margin to the link?


I'm really happy about you committing this!  It's a great start. But I really think we need to show such outdated tables where no plugin atill exists.

We could internally create a small list of plugin table names for old plugins (simply assoc pluginname to tablename, that would maybe a dozeb plugins or so?). Plus, the maintenance section would ideally tell users to check tables before removing them. Maybe we could even output two sections, one for matching tables that are not needed, and those tables we couldn't match to naything. Or color them differently... Just a thought.

> On 10.03.2015, at 18:02, onli <notifications@github.com> wrote:
>
> (I had a train trip to fill ;) )
>
> I would like to rather err on the side of showing not all of them then to show too many. The approach you outlined would show tables of plugins that do not use our api, but I don't see us patching all old plugins to use the api.
>
> But granted, when writing it the way I did it was more because I didn't know SHOW TABLES FROM DATABASE. And I wasn't really happy with the code, had to convince myself to push it anyway to show you the functionality.
>
> —
> Reply to this email directly or view it on GitHub.
>


`create` is a private method. We should stop exporting `mapboxgl.Source`.


This was well done.


that works perfectly, I think it would be more user friendly that way (for people not overly familiar with shape files)


Cause if `r` is string, then non-numeric indices will affect "i < r" comparison.


I do not remember writing the original method, maybe @davidwells that is you? I think this looks good though.


I'm confused because it doesn't print hello world.


Since we don't control the upstream code, in the interest of making it easier to rebase our changes on top of future updates, please revert these whitespace changes. You can do so in a later commit on this branch and we'll squash-merge this onto our `dnanexus` branch.


ewwww, stacks!


This is very helpful information. The code is very confusing, but this comment helps me understand what is going on.


That might as well be a class docstring.


Not a very descriptive name for the robot


Nice use of tons and tons of comments throughout


You can get rid of this variable, also `middle`.


Great Heading!


I had filed the streams doc under advanced concepts, not sure where the right place is: http://dotnet.github.io/orleans/Advanced-Concepts/Orleans-Streams


Why have you created a "copy" of the other method? Why not simply have one method where you randomly select the data for login / cart / address / ... ?


It would be good to also include the build date. Can you please add that?


在找工作么，为啥又开始刷题了


R+ this.


This looks like it might be a special case: `response` was `json_decref()`ed already, above. For this case you might just need to get rid of the json_decref() above.


, __it__ is


This explanation of why start-up may not be functioning correctly is clear and helpful. It makes it well known what steps could be taken to try and execute a proper start-up.


Why is this script after the `body` tag?


solid select statement, i like the structure


gotta love this


This footer is unclear, it doesn't say which 333 section this is!


...and a sweet feature enhancement :D

Nice one


You declare `$target_path` but then use `$targetPath`.
This makes tests failing.


do you really need quotes? probably i'm thinking. maybe review if needed


LGTM


Next time please do not commit credentials!!


It is very overwhelming and confusing to see every sensor compacted together in a single text block. It may be more beneficial to separate the sensors out by type so that a given sensor can be located more quickly. Additionally, it would help provide a quicker overview of the functionality of the robot.


In the async case, you use the json root, but not the original message text. So in this case, you still need to free that original `message`


~~on~~ __at the__


Something wrong with the formatting?


Sorry!


xml code comment


Didn't `insert` commands already prohibit such documents? The only behavior change that I know of was with subdocuments inside `$push`, or did you discover something else?


This helps __to ensure__ that


Nice this totally makes sense. :+1:


The reason I don't have everything in a single RUN like this is that if a step fails the whole thing needs to be done again when edited and re-run. if you have individual steps then there is no need to re-do the previous steps. It's also easier to debug.


rm this javadoc - doesn't add value and sounds weird


@bmagnan preprod patch done, fix will be in prod tomorrow


Super correction :p


@constantinoschristoforou will you please describe to me what this commit is doing? Also I'd like to thank you for taking time to improve the software.

Also all additions to the /shared/ directory have to be merged with calls to action. Please take a look here for more information:
http://docs.inboundnow.com/guide/contributing-inbound-now-codebase/#toc-11

I'd like to see all improvements guided in over time.


Ohh, I see, I missed it. Ok, I think I will delete this one and leave the other one at the higher level, as it is more discoverable. I think we want streams to be first class citizen, easy to use, not an advanced capability.


great name


Yikes


Superb! waiting for your reply! Thanks!

On Tue, Mar 10, 2015 at 1:15 PM, Bogdan Andrei IANCU <
notifications@github.com> wrote:

> This is a different story - I have to check if the HEP protocol (used for
> siptrace to sipcapture communication) does support WS proto.....be with you
> back after checking with Homer guys
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenSIPS/opensips/commit/178b0cc26b05a81947de150fe1c2df36d600ccaa#commitcomment-10125159>
> .
>
> _______________________________________________
> Devel mailing list
> Devel@lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>


so we are silently proceeding further?


So many `each` :) Can we simplify it a bit?


looks good, but all changes to /shared/ directory have to go into calls-to-action and then be propagated over to the others. http://docs.inboundnow.com/guide/contributing-inbound-now-codebase/#toc-11


was it intentional to not keep this line?


same here: can we actually silently proceed? I think we have to stop here...


@trautmane, what do you think about excluding IDE specific project files from the repository?  I am using Eclipse and do not commit its project files, and I will always break your configuration with changes to pom.xml.


This will cause the docker daemon to do SELinux activity even if the user did not execute docker with the --selinux-enabled flag.

The underlying libraries are just checking if SELinux is enabled on the system.    The selinuxSetDisabled() turns off SELinux support.


Because of the comment on the above line :). I don't copy the profiles over right now, because it's not clear to me what should happen in that case and we haven't had a discussion.


You should also check the content-type


No big changes here. Can you discard this commit? I'm still new to working with merge requests too.


So you still need

- if !config.EnableSelinuxSupport {
- selinuxSetDisabled()
- }

You could put this on the else branch of your code.


Hello,
Cool it is back to normal on preprod.
Thanks.


ah, I see you got this in bf42abd3f2348e734956b5407eb49f82106126fc


don't call it test*, call validate or verify


Nice schema!!!


Use capital c


Alert(data) is still in there is that on purpose?


Not sure if this is the correct fix. The post section is already creating the directory, that is the reason why %ghost was used, I guess. This may requires to remove this mkdir from the post section. I have to verify this on SUSE systems.


Nice Schema


That makes sense. I think I was worried about `yield`s making the GUI unresponsive but this is called in the timer thread, so maybe that will be OK. I actually don't remember (if I ever knew) how the timer thread vs the GUI thread vs the reactor actually works.


I WANNA USE SCARF CHARMANDER


What is auto_now=True?


:) I can't really pronounce the sentence because I can't speak a word of Spanish. I like the look of the longer (74 char) string. Which do you prefer? Or shall we just toss a coin? :)


Was this not needed. Any comment @davidwells?


In line test


hah, nevermind me, I see you also got this one in b4b386fb71386b216a1b1b813201cb2ca1a0313a ... I should probably read from the top next time


Can't we build it with a recursive method ?


it is really hacky to test thru logging... We may add some info logging in future. I'd rather restructure the code to return boolean or error message/object if there's any problem. Smth simple, but not hacky :)


you could have just gone through the file line by line instead of reading the file into an array and going through each line


Good color choice


@chinshr
without params[:order].present

params[:order] will resolve to true and
params.require(:order) will throw an exception
```
ActionController::ParameterMissing: param is missing or the value is empty: order
```


+1 on the commit message.


The issue with using lots of RUN lines is that it adds to the number of layers that the resulting image has, unless you export/import the container when finished


Needs more whitespace


worst commit in the history of ROSS.


This looks good. I even verified that this css file is not located in this location any more. I believe this commit passes. Would love more detail though.


This is the very first line you will write when learning a brand new language :+1:


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: js/tbl_change.js, libraries/insert_edit.lib.php


Good job with this project


we can directly take ajax request


had no access to code


Awesome line. But the printed words can be even facier :-1:


To be consistent with the Java web pages, this file should be called `ExtensionsAPI.html`. The `Extensions.html` page now lists extensions that are available.


could have shortened the if, else if, else statements


Created readme.md file


@constantinoschristoforou  What does these changes do? @davidwells would you review as well?


What are your plans for session_id?


some change


The code could use some commenting to make the conversion more clear...


good error checking


You did a great job with comments, but you could use a greater variety of test cases


~~for Java~~


Would also like more comments here.


I think that this is a very useful method for a point object.


OK


Won't this make it run in the main job instead of the Archetypes job?


Please more comments


lalalala still testing


good!


2/2
Looks good!


Nice switch statement. Not really sure what all the comment entails.


1297-ExteriorLightsSchedule (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Brad didn't yet mirror the binaries to S3, so you'll have to retest after he did.
http://downloads.dlang.org/pre-releases/2.x/2.067.0/


Some of the code could use some commenting/explanation.


1297-ExteriorLightsSchedule (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Hi @ticoann , I am not sure I understand this comment. This listDatasetFileDetails API (that I wrote following @giffels directions) is distributing the work to get the lumis over many calls (one per block). Is there a more efficient way to do it in DBS3? Otherwise what should we do then when we need the lumis of a whole dataset?


I like that this code is easy to understand, and that it can be used to teach.

I don't like that you didn't actually write this yourself. Unless of course the comments in the code are lying, in which case shame on you.


2/2
Good work!


Does this somehow call the function? How does it do that?


88734010-AFN-horizontal-openings (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1653 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


I like the comments. They are clear and you use them consistently throughout the file.


I'll have to look at the larger context of the code, but remember that calling yield inside an inlineCallbacks-decorated generator just adds the generator completion as a callback/errback to the yielded deferred, so the execution is no different from adding those manually (the callbacks run in the reactor). When you say "timer thread" I hope you mean that you are using twisted timing routines, not an actual separate thread. The former just schedules functions to be run in the reactor at certain intervals, the latter would create all kinds of thread safety problems, for example here the drLoggerCallback could be called in the timer thread (for synchronous errors) or from the reactor thread (for asynchronous errors). That would almost certainly not be what you want. Also, I hope you're using the qtreactor, in which case the twisted reactor and qt gui event loop work together, and there's no distinction between reactor thread and gui thread.


Yay comments!


The huge if else state is not always good..


Hi Sean, this is fine but just FYI

"all the world under these same licenses. Safecast will be attributed as the source."

reads like I wouldn't be able to use code I've written in my other personal projects without attributing Safecast. Nor would I be able to say, use code I've written for Safecast in another project under the GPL. Or use code I've previously released under the GPL in a Safecast project.

In this case I don't mind, but it seems slightly more restrictive than necessary.


Use inotifywait to wait until there is a file change. Don't restart bluetooth daemon.


Um. Okay, the... the second one. :)

--
By the way, F-Droid builds happen automagically or they have to be pushed over somehow? I want to test it.


why?


The message doesn't match the condition (0 is not a negative number). It should say "Limit must be positive"


Good that there's a section describing all of the concepts used in the code.


That easy? Great, thanks Phil! :-)


create deneme


Format like this for readability:

```java
List<String> result = Splitter.on(delimiter.toStringUtf8())
    .limit((int) limit)
    .splitToList(string.toStringUtf8());
```


Might want to comment this line, explaining what order this is getting sorted in. And why you are sorting just the untextured list.


I think you answered a different question (why `+i`).
I asked a stupid question, now I realize that the array has to be scanned fully because we don't store properties in order. (And even if we did, they would have been lexiographically ordered).


Yes - must have forgotten to add this when I added support for strategies of strategies. I checked the two equity curves after the fix and they are identical.


This code does not handle any exceptions, such as what might happen when you do not have the right kind of input.  Additionally, there are no comments, which makes him bad.


Function comment that.


Yes, I am using the qtreactor, and by "timer thread" I mean "whatever thread it is that the QTimer object's `timeout` signal runs in". So I assume that the qtreactor makes that work well with Twisted (otherwise what's the point of qtreactor, I guess).


2/2
Good work. Error message in rails are tricky but once you get a hang of rails convention you'll be able to pinpoint most errors quickly!


This should fail


2/2
Looks good! This is one of the most powerful parts of rails.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


This brakes org.codehaus.groovy.tools.GroovyStarter for me when launching a script via the IntelliJ "Groovy" launcher. The script uses a library that users xml-apis ... bang. If I remove the hack, it works.

Can it be removed please, as it is not clear why it was added anyway - and there is most likely a workaround for that situation, while I did not find any workaround for this. Once the "Node" class is loaded by the system classloader, it can't be unloaded. And NodeList is also already loaded when the script starts. And their classloaders are not the same. (The (defining) classloader attribute for Node is null and for NodeList is RootLoader - but they would need to match, afaik.)

Caught: java.lang.LinkageError: loader constraint violation in interface itable initialization: when resolving method "org.apache.xerces.dom.NodeImpl.getChildNodes()Lorg/w3c/dom/NodeList;" the class loader (instance of org/codehaus/groovy/tools/RootLoader) of the current class, org/apache/xerces/dom/NodeImpl, and the class loader (instance of <bootloader>) for interface org/w3c/dom/Node have different Class objects for the type getChildNodes used in the signature
java.lang.LinkageError: loader constraint violation in interface itable initialization: when resolving method "org.apache.xerces.dom.NodeImpl.getChildNodes()Lorg/w3c/dom/NodeList;" the class loader (instance of org/codehaus/groovy/tools/RootLoader) of the current class, org/apache/xerces/dom/NodeImpl, and the class loader (instance of <bootloader>) for interface org/w3c/dom/Node have different Class objects for the type getChildNodes used in the signature
	at org.apache.xerces.parsers.AbstractDOMParser.startDocument(Unknown Source)
	at org.apache.xerces.impl.dtd.XMLDTDValidator.startDocument(Unknown Source)
	at org.apache.xerces.impl.XMLDocumentScannerImpl.startEntity(Unknown Source)
	at org.apache.xerces.impl.XMLVersionDetector.startDocumentParsing(Unknown Source)
	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
	at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
	at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
	at org.openqa.selenium.firefox.internal.FileExtension.readIdFromInstallRdf(FileExtension.java:97)
	at org.openqa.selenium.firefox.internal.FileExtension.writeTo(FileExtension.java:60)
	at org.openqa.selenium.firefox.internal.ClasspathExtension.writeTo(ClasspathExtension.java:63)
	at org.openqa.selenium.firefox.FirefoxProfile.installExtensions(FirefoxProfile.java:424)
	at org.openqa.selenium.firefox.FirefoxProfile.layoutOnDisk(FirefoxProfile.java:402)
	at org.openqa.selenium.firefox.internal.NewProfileExtensionConnection.start(NewProfileExtensionConnection.java:89)
	at org.openqa.selenium.firefox.FirefoxDriver.startClient(FirefoxDriver.java:246)
	at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:114)
	at org.openqa.selenium.firefox.FirefoxDriver.<init>(FirefoxDriver.java:191)
	at org.openqa.selenium.firefox.FirefoxDriver.<init>(FirefoxDriver.java:186)
	at org.openqa.selenium.firefox.FirefoxDriver.<init>(FirefoxDriver.java:182)
	at org.openqa.selenium.firefox.FirefoxDriver.<init>(FirefoxDriver.java:95)
	at ch.bluesky.testing.selenium.WebDriverFactory$6.newInstance(WebDriverFactory.java:85)
	at Main.run(Main.groovy:45)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134)


I am assuming this method is from an external library?


Hi @rblanchot @MefhigosetH

In this commit I changed the method for debugging, for some reason the default tracebacks are not working well, now we can print messages and tracebacks for specific methods.

**For debug methods**
Is necessary import the debugger:
```python
from ..pinguino_api.tools import Debugger
```
and add the decorator to method target:
```python
    @Debugger.debug_method
    def method_target(self):
        ....
```
Like [here](https://github.com/PinguinoIDE/pinguino-ide/blob/master/qtgui/pinguino_api/pinguino_tools.py#L192)

This log start and end of method, the time spent and if an exception occurs the traceback will also be printed.
_Only works after initialization of Pinguino IDE._

**For redirect messages**
Is necessary import the loggin:
```python
import logging
```
and where is needed print some output:
```python
logging.info("message")
```

This new features can be enable and disable from Python Shell DockWindow.


Nice! Will test again.


api.nilas.comn?


2/2
Good work!


Why did you remove this line? Its beautiful!


It should say that limit must be a positive number (0 not allowed)


Yeah, lets kill this method.


possibility (is missing an __i__)


hmm should have seen that myself..


maybe you can use -stl
```
    -stl, --show-time-lapse [i]
           Display time lapse between send/receive pairs.  This option is most useful when Time::HiRes is available, in which case the time lapse will be displayed
           in thousandths of a second.  If Time::HiRes is unavailable or "i" is given as an argument the lapse will be displayed in integer seconds only.
```


IMO this logic shouldn't be in a fork of the driver at all, and should instead be a database utility helper in nucleus. The implicit change in query semantics (even with the operator whitelist) will be hard to keep track of and may have unforeseen side effects.


Did you meant to do this? TimestampFormatterExtension makes more sense.


Just tried to do this:
```python
self.assertEqual(iter(expected_results[i]), return_value)
```
Assert fails:
```
AssertionError: <list_iterator object at 0x7f1ee9bf45c0> != <generator object split at 0x7f1ee9bf2b40>
```


Looks good (and straightforward) to me.


calloc here ?


~~running~~ you to run


Auto-generated code is confusing.


~~accetpance~~ __acceptance__, or maybe just __Concordion__ tests?


Okay. Thanks @supritashankar. I will update it shortly :+1:


You should make all these paths local. It is more of a programing convention, but would really allow for easy cleanup, and people to have the same setup if they want to run the program.

For example:
```
Texture_Synthesis/
    source/
        default/
        key/
        pack/
    modded_jars/
    output/
        differences/
        default/
```


Desafio ok, porém poderia ter explorado mais, alteração simples.


Not a big deal but no need for parentheses for an empty func in ruby


This is the error:
```
CC	libavformat/avisynth.o
In file included from libavformat/avisynth.c:43:0:
/usr/i686-w64-mingw32/include/avisynth/avisynth_c.h:300:63: error: expected ';', ',' or ')' before '=' token
 AVSC_API(int, avs_row_size)(const AVS_VideoInfo * p, int plane=0);
                                                               ^
```


Cool will update it now.

I don't know how to get F-Droid to update. I'm going to contact them to find out whats going on. The page was auto-generated I think.. I never signed up for F-Droid, I just saw the traffic on GitHub from them, and was pleasantly surprised to see the app on the front page :)


2/2
Good work!


@indydedeken @edouardalvescamilo Please look carrefully at this commit as it modifies the variable names of station objects fields.


Also, if you end up doing this, you will want to controll it with the .gitignore. For example using a .gitkeep file.

```
# Ignore all files
modded_jars/*
# Keep the git keep file
!modded_jars/.gitkeep
```


HumidifierSizing_#4688 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1146 of 1146 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.63%25-green.svg)


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


`viewStruct` does not exist anymore as my successive refactorings had it useless.


__the__ package


Close all the open log handles. Lck files deleted on exit.


I am working on renaming `lat` to `latitude` and `lng` to `longitude` to harmonize with `Geolocation` API.


Out of curiosity, why did you change this? The max number I set based on what the max inventory of a character is. anything more than 90,000 wont fit in a single characters inventory, even if completely empty.

Giving all at once, I guess, would be cleaner. Not sure why it was done the other way...


Isn't this actually called, "The Hallow"? http://terraria.gamepedia.com/The_Hallow


userFriendlyLogFile has time stamp in seconds resolution.


This one's officialy named "Underworld.". http://terraria.gamepedia.com/Underworld


a


developersLogFile has time stamp in milliseconds resolution.


b


hiya,it was a long day, i was tired and distracted with that stackdump wierdness so i knew i was forgetting something but couldn't remember, and it was the doneif bit. :o)sorry, was thinking i would be getting the exact total and not possibly adding to an already existing number. will test it with the += tonight.i don't think i've ever seen the #value macro before so that is kewl to learn....now if i can just remember it in the future...little unsure on the last point. the extra damage of Disrupt Pattern is multiplied with critical hit but the extra damage from One Pattern is not, so i thought it needed to be kept separate from the damage that does multiply. i do see the damage is situational now though...somehow no matter how many times i read it my brain just glossed over the "if your target does match your active creature type" lol. i think the easiest way would be to make something they can activate on in play tab like you suggested. maybe the extradamage macro will help solve it(i couldn't find a explanation of it on the webpage i found other macros on).lookin to edit and test in a min...
Date: Tue, 10 Mar 2015 10:18:46 -0700
From: notifications@github.com
To: HL-Pack-3PP@noreply.github.com
CC: kiddtaylor@hotmail.com
Subject: Re: [HL-Pack-3PP] Corrected typo in COM_3PPPack_PathOfWar - Tags.1st (n ame instead of name) (44833d4)

@psych777 for your new One Pattern feat I have a couple of small tips.  Otherwise its looking good and really appreciate all the help you have been giving. =)

First one is all feats need the following at the top of the scripts. This prevents the feat from executing if it gets disabled from some outside source (archetype, feat, magic item, spell)...

~ If we're disabled, do nothing

doneif (tagis[Helper.FtDisable] <> 0)

Two is always make sure you do a += when dealing with field[abValue].value instead of = which does a set.  What if someone uses an adjustment or another script to adjust the value on this feat?  By using "=" that change will not be taken into account.

Three is it makes the script allot easier to work with if you use the value[] macro and it makes the script shorter and faster to write: field[abValue].value += #value[cPUDisPatt] + #value[cPUEnhDisr]

Four is the Disrupt Pattern ability is setup to have is "abValue" adjusted not to adjust the Fix Damage section directly.  The reason is it is easier to have a single script manipulate the text damage than multiple places.  Especially sense this extra damage is the type that is increased on a critical hit we need to be using the extradamage[] macro instead.  This fits into HL standards for "extra" damage.

On top of this the extradamage is only in specific situations which means we should be displayed as situational damage or it should be something a person can activate on the In-Play tab.  Otherwise a person on the iPad will always be adding this damage when they roll damage.  Which is not really correct because it only happens under a specific situation.  Adding situational text is great for those that use only paper character sheets as they will have a note next to the weapon to remind them.

If we can make these changes to the feat I would appreciate it!

—
Reply to this email directly or view it on GitHub.


For cats and users we were looking for something that iterates through all the users and cats in the database (for loop, etc.). Look into this because its really important for showing lots of useful information on a page and we will definitely be using this in the future!


2/2
Good work! See my comment above.


jooh sori, aattelinkin että jotain unohtu laittaa tänne :--D


I'd prefer a solution outside the application to do this.
Maybe some magic XSD would be sufficient?


There will need to be a new automatic system based on CADC's new group management service, as soon as that service actually becomes available.


hehe it really confused me at first cuz i couldn't compile because of the 1st file, and i'm thinking "but i haven't touched that one!" hahaha

Date: Tue, 10 Mar 2015 10:21:14 -0700
From: notifications@github.com
To: HL-Pack-3PP@noreply.github.com
CC: kiddtaylor@hotmail.com
Subject: Re: [HL-Pack-3PP] Corrected typo in COM_3PPPack_PathOfWar - Tags.1st (n ame instead of name) (44833d4)

@psych777 P.S. - Thanks for fixing my screw up with the .1st file. =)

—
Reply to this email directly or view it on GitHub.


The way I envisioned this, this is just a shim while we're running against 2.4 so everything doesn't just break at once when we switch to 2.6. Once we're on 2.6 and higher, we could think about removing the compatibility translations one by one, removing each one in a controlled manner and deciding whether to fix them in application code or in a utility helper.

I think that in this case the refactoring to use the putative utility library would be such a large undertaking as to basically eclipse the risk of temporarily modifying the driver.


2/2
Great work!


Cool, you will see I've updated it soon. New app will come through the Play store in a couple of hours. Won't be long :) Sorry about the wait.....


敘述句要用分號分隔
`for ( ... ; ... ; ...)`


Bronze 2 conferido


So after our 'de morgan's law' discussion this could be re-writting to:
Step 1: `if (!(utcb || regs.fpu_on) && !(ec->utcb || ec->regs.fpu_on))`
Step 2: `if (!(utcb || regs.fpu_on || ec->utcb || ec->regs.fpu_on))`

Right .-)


You can use <br> for a line break


There may be some additional ones here http://terraria.gamepedia.com/Environment


Gostei da mudança


bardzo ładny commit maćku


Should be something like (https://github.com/kharidiron/StarryPy/blob/master/plugins/admin_messenger/admin_messenger.py#L17):

```
self.prefix = self.config.chat_prefix
...

if parsed.message.startswith(self.prefix * 2)
  ...
```


Warning: feof() expects parameter 1 to be resource, boolean given


Warning: fgetcsv() expects parameter 1 to be resource, boolean


slam dev


Hmm... yea you're right. Using non-discrete values for chromosomes is going to be a bit tricky. Can you tell me your use case?


Look into other forms of ruby loops for cleaner? code. Ex.
<% @user.each do |user| %>

<%= user.username %>

<% end %>


Irrelevant. I'll add proper tests soon.


2/2
Looks good! See my comments above.


Is container-level --privileged going to work fine with a user-namespaced daemon?


@PatrykKaczmarek There is no need for any discussion in here. I just want some clarification in here.
@ecler mentioned this rule about colon-aligning when there are >= 3 colons in one of previous review, so I'm 100% sure that he knows it. Nevertheless he don't keep it anywhere in this class. So I'm just confused and curious why?
Please let him speak for himself.

If there is any reason why this rule can't be used in here (for example `Maybe it >3 colons appear there is problem with code structure`) then codestyle in wiki should be updated with info about exception when we don't use this rule. If not, this code is against our codestyle and should be fixed.

@PatrykKaczmarek Again please respect my right to having own opinion in code review and respect @ecler rights to dissagree with it and argue with me :wink:. If you think that I'm wrong in here, you should put some arguments (I really can't find those in your comment, sorry if I'm blind :sunglasses:).

From my side this is end of topic and there won't be any more discussion.


Good catch on the `%post` mkdir command. I'll remove that and re-push.


TeamCity Akka.NET :: Akka.NET PR Build [Build 118](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=186&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) is now running


Code for the Arduino UNO R3 breadboarded version of the sensor.


Thanks. I've gone with end date desc, start_date desc if that makes sense?


But I consider then renaming `assertIteratorsEqual()` into `assertIteratorElementsEqual()`.


This also raises the question of what to do with the Stan analyses; KKL
will take 8 hours on a 4-core Macbook Pro using the parallel library and
running the four chains in parallel. I guess it doesn't make sense to
include code that executes in the vignette.

--
Shravan Vasishth
Professor for Psycholinguistics and Neurolinguistics
Department of Linguistics
University of Potsdam, Germany
http://www.ling.uni-potsdam.de/~vasishth

On Tue, Mar 10, 2015 at 6:46 PM, Douglas Bates <notifications@github.com>
wrote:

> Technically the .html files in inst/doc are to be regenerated when the
> vignettes are rebuilt by the package. I was doing that on my system and now
> realize that the maximal model may take a few hours to fit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dmbates/RePsychLing/commit/079142db68db3f9f4bccf47f7d82f3bbba2a626d#commitcomment-10125786>
> .
>


I don't think it matters who owns the files in this case (root or www-data would be better, although maybe slightly prefer root), but if we can avoid running the webhook as root, that would be great.


@cody-lny No this is dumb.

Dumby!


nice!


No problem. Will update this soon. Thanks!


OK, sounds reasonable. @ptn24 and I discussed making a new builder helper/pattern to construct the queries in a 2.6-compatible way from the ground up. The approach is good as long as the refactoring doesn't get postponed forever :)


I did some updates for more flexibility and less assumptions.I insist with my strategy of extracting the activities.
I am curious what's your opinion on this.

Thank you... gheo

      From: Csaba Trucza <notifications@github.com>
 To: gheorghina/HolidayPlanner <HolidayPlanner@noreply.github.com>
Cc: Gheorghina <gheorghinab@yahoo.com>
 Sent: Tuesday, March 10, 2015 4:00 PM
 Subject: Re: [HolidayPlanner] Updated employees activities (75558f4)

What if a manager wants to reject a holiday request even if it is valid? For example an important release will be done on that date?
I think the manager (the real person using this code) should be able to decide if the request will be rejected or approved.
Or am I missing something?—
Reply to this email directly or view it on GitHub.


r u making fun of me


@timkutnick

I just had to to do this in Internal Tools. Check out this commit. Seems like a clean way to do it:
https://github.com/dotandbo/dotandbo-internal/commit/5e1563bbb0fa7fbff6fc9c10ec2915d8f2f778c9


It helps when files exist, yes.


FYI you can combine this and the above which can sometimes look nice and keep manifests shorter:

    ['/srv/sites/control', '/opt/puppet']:
      ensure  => directory,
      owner   => root,
      [...]


Nice catch. Your change looks correct based on the spec here:
http://www.w3.org/TR/2012/WD-XMLHttpRequest-20120117/
Ready state of 4:
"The data transfer has been completed *or something went wrong* during the transfer"


I've got Windows instances not properly reporting the platform on AWS and this change is causing them to be added to the Linux template instead, as they appear as unknown but the 'if' below this line doesn't trap them.


wow, that's surprisingly terse to cause stack dumps to get ts line numbers... nice


ddd


C'est bon pour ma partie!


Poderia ser mais elaborado, mas está correto


I agree. this is much more accurate.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12550/testReport/) for this commit**


I bet this will be broken by typescript at HEAD...


I already disabled FlushDelay for 'unix socket' transport, since it has no sense there - see NewUnix*() calls.
As for 5ms, this value has been chosen arbitrarily for our production app. And it works well here (i.e. saves significantly paid and limited network bandiwdth), since the average rpc response time here is 500ms :)
I'm ready to change FlushDelay or even disable it by default for network transports (TCP and TLS) if this satisfies the average gorpc user.


That's Respec shorthand, if you use a local anchor with class="sectionRef", it fills in the content with the title of the section.


Boa solução


ЗАЧЕМ? при запросе инфы по компании апи выдает ее посты


thanks for this .did you test it .revert fixes issues ?


Yeah, this wouldn't have been the right spot to `Submit()`, I think. Needs to be on an extra (green) thread based off a timer or something.


Thanks, fixed in 57d42aef9


wow with the arrow syntax it's very tricky to correctly infer what "return" will do here :)


You are Dumb-Dumby!


cool, better than traceur already (minus the bit about working)


@josh-lny YOU are Dumb-Dumby!


Added README


ok, conferido


88734010-AFN-horizontal-openings (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1653 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


TeamCity Akka.NET :: Akka.NET PR Build [Build 118](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=186&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: xUnit failed for the following assemblies: D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Persistence.Tests\bin\Release\Akka.Persistence.Tests.dll   at Microsoft.FSharp.Core.Operators.FailWith[T](String message)   at Fake.XUnitHel... Build time: 00:10:24
### Failed tests
```
Akka.Persistence.Tests.dll: Akka.Persistence.Tests.GuaranteedDeliveryCrashSpec.GuaranteedDelivery_should_not_send_when_actor_crashes: <no details avaliable>

Akka.Persistence.Tests.dll: Akka.Persistence.Tests.SnapshotSpec.PersistentActor_should_recover_state_from_scratch_if_snapshot_based_recovery_was_disabled: <no details avaliable>

```


Yeah it's not ideal.


Removed St. Helena Bend


No, because it is not a regular Hash.


just remove the `hintStaticallyElided`


It's for @PaulBarrett79 - this is [his](https://twitter.com/JSOxford/status/537646959704940544) [part](https://twitter.com/JSOxford/status/555672537359597568) of the jsoxford website.

@spikeheap what's a "closing tag"?


Shouldn't this just be
```go
if tailNode, instance_exist := t.Cached.Instances[instKey]; instance_exist {
```

P.S. Please `go fmt`.


jhg


literal_eval? Should not this be json.loads?


@RyanBalfanz hmmmm....you'll have to fill me in tomorrow on how you picked up on this....


Wouldn't it be an error in the program if the instance doesn't already exist?  It doesn't look like `Update()` should be inserting anything.


No need to use template here.


The docs suggest it as a way to supply a default if the parameter doesn't exist.

http://guides.rubyonrails.org/action_controller_overview.html#more-examples


`mapWithIndex(elems) { ... }`


Adding the extra message seems unnecessary. That's the only detail I see in this PR.


![image](https://cloud.githubusercontent.com/assets/243627/6582658/c8ab4e34-c76f-11e4-9b51-6f6ba3ad7842.png)

```
[Colors]
color_terminals=linux,xterm
base_color=normal=lightgray,black:marked=magenta,black:executable=green,black:directory=lightgray,black:editnormal=green,black:editbold=red,black
```


`debugWarn("unexpected call to ... )"`


How dare you change my text file >:(


compare `diff` in seen with `itemsAhead` and you should not read from the array if `diff` is less than `itemsAhead`, might be an off by one somewhere there, but basically something like that.


I'll be honest, I skimmed the doc.  I'm probably just implementing it wrong.  but it compiles.. so that's half the battle!


c'est un beau package


let's change this line to disable rollbar in development. Eg:

    if Rails.env.test? || Rails.env.development?
      config.enabled = false
    end


C'est une belle grammaire.


you could use

```r
expect_match("0.1)", fixed=TRUE)
```


C'est un beau commit initial.


C'est une belle ignoration de git.


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2153 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.58%25-yellow.svg)


Can this (and other messages), be localized?


no entiendo, por que .S_CPP? assembler o c++?


there is typo here.


@jlhawn sorry to cross-talk between PRs, but shouldn't a Digest be of the form `<digest-alg-name>:<hex-encoded-digest>` as described in docker/distribution#62 ? If that's the case the regexp should match only hexadecimal characters after the `:` sign. Let me know if I'm wrong.


I totally agree.


This puncutation usually comes with a little whitespace:

```
% egrep -r 'case.*@.?_.?\*' src
src/library/scala/util/matching/Regex.scala:   *    case p4(all @ _*) => all mkString "/" // "bbb/cc"
src/manual/scala/tools/docutil/EmitHtml.scala:        case DefinitionList(definitions @ _*) =>
src/manual/scala/tools/docutil/EmitManPage.scala:        case DefinitionList(definitions @ _*) =>
src/reflect/scala/reflect/internal/Trees.scala:      case Seq(_, rest @ _*) => Block(stats.init.toList, stats.last)
src/scaladoc/scala/tools/nsc/doc/html/page/diagram/DotDiagramGenerator.scala:    case Elem(prefix, "svg", attribs, scope, child @ _*) => {
src/scaladoc/scala/tools/nsc/doc/html/page/diagram/DotDiagramGenerator.scala:    case g @ Elem(prefix, "g", attribs, scope, children @ _*) if (List("edge", "node").contains((g \ "@class").toString)) => {
src/scaladoc/scala/tools/nsc/doc/html/page/diagram/DotDiagramGenerator.scala:                case Seq(Elem(prefix, "a", attribs, scope, children @ _*)) =>
src/scaladoc/scala/tools/nsc/doc/html/page/diagram/DotDiagramGenerator.scala:    case Elem(prefix, label, attribs, scope, child @ _*) =>
```


This is my favourite thing in all of the internets.


You could combine lines three and four.


My bad. This is C, not C++. And there are no defaulted args in C. Oh well.


That's a pretty string.


`return ParseDigest(ts.Sum(nil))` should be sufficient assuming it does not return a non-empty digest on error.


Cool, adding your name at the top (:


Let's reduce indentation level here, else clause not necessary.


What kind of iterator is this? In-order? Pre-order?


Bronze 1 Ok


Stupid name for class. Change it to something more interesting, like "FlyingSpaghettiMonster" or "BinLaden'sAnus".


Compile errors http://i.imgur.com/oG3SiST.png

and more


I wonder if `GetV2ImageBlobReader` can receive just `digest.Digest` interface and call methods itself. Or you prefer not changing signatures for now?


Easy-to-understand function, interacts with node well


Math is cool (This is a required statement form the lab instructions).


Don't know what this does :( please clarify


Renamed classes and created third class to separate responsibilities:
-LcdSizer => determines height and width of each digit segment based on lcd_height argument
-LcdRowPrinter => prints each of 5 rows of number, iterating over every digit in number argument
-LcdPrinter => prints all rows to render complete output to console


Good imports


Good job. You created a board.

I'm proud of you, son.


confusing


Por que colocar o iTunesManager (Singleton) como property?


You should have put some sweet code in here for when the mouse was dragged


Yep, its a global message that cannot be changed, I'll add that now


to model ingeneering stuff, for a class ,i was testing it, to see if it could balance the density of water and hidrogen vs the density of air, for a theoretical dirigible, to show case evolutive algorithms, below is the code, slightly modified fifteen example:
require 'darwinning'
Dair=1.225 #kg/m3
DH2O=1000 #kg/m3
DH2 =0.08988 #kg/m3
class Dirigible < Darwinning::Organism
	@name = "Dirigible"
	@genes = [Darwinning::Gene.new(name: "mH2O", value_range: (0.0..10.0)),
		Darwinning::Gene.new(name: "mH2", value_range: (0.0..10.0))
		]

	def fitness
		# Try to get the sum of the 3 digits to add up to 15
		#@genes

(((((genotypes[0])*DH2O)+((genotypes[1])*DH2))/(genotypes.inject { |sum, x| sum + x }))-Dair).abs
	end
end

# create a population of 10 Dirigibles
# with a goal of getting a fitness value of 0 (or the closeset after 100 generations),
# a mutation rate of 0.1
# fitness will be calculated by the fitness function provided in the Dirigible class definition
p1 = Darwinning::Population.new(organism: Dirigible, population_size: 10,fitness_goal: 0.0001, generations_limit: 100)

 puts "First Generation of Population"
 p1.members.each { |m| m.nice_print }  # print the initial population members

p1.evolve! # create new generations until fitness goal is met or generation limit is met

puts "Solution:"
p1.best_member.nice_print # print the member representing the solution

puts "Solution met after #{p1.generation} generations."


index.html - стартовая страница
page1.html - страница со списком группы
page2.html - страница с документами
style.css - файл со стилями


Let's be a bit more specific here. Something about taking an action on the given page, not linking to an asset and recommend using an anchor tag for that (and then linking to the anchor tag).

I've seen these used interchangeably and we should make it more clear about why you would use one over the other


good job!


too much commenting, just write the code before i get any more confused


this is good code for distance. good job.


Bronze 2 ok


Yes. Though, we first have to make sure the package runs in full test isolation before re-adding it to another alltests group. I'm just going in tiny steps to make sure I catch all regressions.


Remove TODOs once they are complete.


sugestion pastebin text based log instead gfx.


Do you think we should have styling for reset and submit as well? Done through attributes on the button.


Yes, i thought about this over lunch! Is there any repository of iconography we're using yet?


TeamCity Akka.NET :: Akka.NET PR Build [Build 119](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=187&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) is now running


Hi,

Yes, it is, but it is executed only as a fall back if we have no other
option but to fail. This is because imageJPEG() can either save the image
to file or stdout but not to a variable. But you are right, we can do the
resampling part only once, in exchange to some readability. I will try to
figure that out.
Also, if we really are to eliminate code duplication, we might think of
merging createsmall into createthumbnail. Both scripts are essentially the
same, except the former is proportional and the latter is squared, but
there is no reason to keep too big thumbnails squared and to have "small
preview" too small. Let me think about it a bit...
10 марта 2015 г. 20:29 пользователь "Marco Siebecke" <
notifications@github.com> написал:

> hm looks a bit like duplicate code.
> will have a closer look when I'm not on the phone :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gentoomaniac/minigal-nano-ng/commit/d29364de7b0002f9094f4ac5d5cf0e6443636f94#commitcomment-10125444>
> .
>


good use of !


What is this needed for? fmt.Print should know that Digest's underlying type is a string anyways.


If you want to do a one-liner you could use CRM_Utils_Array::first()


and the image does the same


What did you have for lunch that jogged your memory?

And no, we don't have iconography yet.


same here, build failed
http://pastebin.com/NShaL9W2


Permet de supprimer une quête dans la table character_queststatus au bout d'un certain temps.


This seems like a useful test as well, but I don't think it tests the code path you fixed. Don't you need to have a 'case' or 'default' label for that?


Other than that, LGTM


I really like your comments, they improve readability.


`could not find ':' in digest` would be a better error message


Magic numbers here


nice use of recursion


I thought literal_eval would work in all cases, but looks that not. Maybe Stefano was right that better to use the bash "tr + grep + tail".


could have used _ in addition to camel case


Change the excpection to 401


For readablity, consider a case statment


Interesting project.


Thanks @tardyp we've already identified this and there is a fix in progress.


Maybe add more comment so others will understand the code more.


What is the progress on this? Drawing roads could be very nice feature for next build.


More descriptive variable names?


@dansut
Had a quick look at the changes. Most of them are fine but I am not sure if I understood some parts completely. I guess that we need to look at a way to give the prefix OID and then map the rest of the OID to the Registry structure.

Most applications will only use the Arduino OID. I was thinking in a more general term with any OID but if I understand your solution correctly you want to allow the application to use the Arduino OID prefix.

I don't think we have to think about backwards compatibility. Cosa is not that type of project. Feel free to propose any changes necessary.


Spelling on Casey Reas is wrong on the added file. Says Read. :)


What does this do?


no need for a struct, this can be a string.


BANG


why not use a Digest type directly instead of a string?


VC++2010
error C2065: 'ssize_t' : undeclared identifier


Hmm. I guess we could use gmake's $(patsubst pattern,replacement,text) to truncate the sha1 to 7 digits in $(PKG)_SUBDIR.


options! I was having options! :cake: :apple: :tea:


Wow, what a name for a class


add a TODO


Very nice print statement!


there's a misspelling: passionat -> passionate
The website looks much better than the previous one!


Consider add more functionality to your memorable CSSE120 project.


I have not finished reading through this thread yet, but there are a few more things to consider:

1) How much longer do we intend to use Mongo? I have heard discussion of moving to a different database.

2) If 1 applies, then do we still need to design a builder pattern for our next potential database?


Still trying to figure out how to stop the button highlight from removing the image.
![image_loss](https://cloud.githubusercontent.com/assets/2898615/6583062/45fbfa26-c727-11e4-8682-5230ba7c6eb2.PNG)


You are right. This does not test that case. I'll add another test.


TeamCity Akka.NET :: Akka.NET PR Build [Build 119](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=187&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: xUnit failed for the following assemblies: D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Persistence.Tests\bin\Release\Akka.Persistence.Tests.dll, D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Tests\bin\Release\Akka.Tests.dll ... Build time: 00:09:28
### Failed tests
```
Akka.Persistence.Tests.dll: Akka.Persistence.Tests.GuaranteedDeliverySpec.GuaranteedDelivery_must_resend_replayed_deliveries_with_an_initially_in_order_strategy_before_delivering_fresh_messages: <no details avaliable>

Akka.Tests.dll: Akka.Tests.Routing.ResizerSpec.DefaultResizer_must_grow_as_needed_under_pressure: <no details avaliable>

```


http://thegeekcrusade-serveur.com/forums/viewtopic.php?f=7&t=35409&p=81760

Commit indispensable : 9353959


##### Testing npm install on windows
![Windows Build status](http://webinoswintest.epu.ntua.gr/Home/BuildStatus/11393/c6efc6bc-7664-4863-b4e9-dc1c732c3213) [Check log here](http://webinoswintest.epu.ntua.gr/Home/BuildLog/11393)


either explain in the function comment when it can panic, or change the signature to return an error.


Nice description.


Feedback! great!


Looks good to me - I had an uncommitted change that looked like this but yours looks more efficient:

                     # XXX: handle other data field implementations
                    old_value = None
                    try:
                        old_value = field.get(obj).data
                    except:
                        pass
                    if old_value is None or value != old_value:
                         field.set(obj, value)
                         filename = item[key]['filename']


This class could be named better.


Somehow the changes to TARGet got added into this pull request, so there's something I don't understand. I may try to learn how to fix that history...But regardless, this closes #2.


Is this ready for a pull request?  Seems like some of your commits serve a good purpose.

I want to find a fork that allows overlay of ads based on blocked content.  Have you found in the code where I might be able to test some stuff out to block original content and add new content?


I didn't have time to look at it until today. Thanks for fixing it.

On Tue, Mar 10, 2015 at 3:27 AM, Michael Cohen <notifications@github.com>
wrote:

> This change actually broke Travis. Fixed in
> https://codereview.appspot.com/213170043
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/rekall/commit/6b577587a6b0f01d71810a22e8384a9fee9f99bd#commitcomment-10117371>
> .
>


Should probably update your version.


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1653 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


You don't put open brackets on the next line. Boooooooooooooooooo.


90022444-FewReleasePrepThings (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I didn't have to do this, and mine seems to work; does radosgw need mon execute permission for something?


You are sure the list isn't empty. Good job. Here's your degree.


Ignore this part.


Удалена строка вызова не объявленной переменной


@markcs @xDereCx Please see https://tvheadend.org/issues/2708 and https://github.com/tvheadend/tvheadend/pull/605


Nope, I guess this was what you fixed in the new pull request, right?


having `err` there is misleading, can you put `nil` instead?


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2091 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.74%25-yellow.svg)


`unsupported`


Good job you added the listeners


some problem with Net4.0 files, but can ignore, the ZKL files are okay.


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I have very little idea what any of this does


cc @francesco-romano some annotations:
  * You should lock the `controlMutex` mutex before editing the `desiredJointTorques` variable .
  * Perhaps instead of introducing all this logic with the `newlySwitchedControlModes` and `torqueModeEnabled` variables it is easier to simply always call `readStatus` in the `run` ? This would also restore the "transparency" of the jtc from the user point of view.
  * We should reset the `desiredJointTorques` only if the joint is not already controlled in torque (i.e. hi


very good algorithm to print the pyramid


alternatively, we could add another layer to our tests which would just compare the json structure of each gg that goes into `save_outputs` - basically, a text alternative to our test-table


Good use of numbers to make your code clear


should have commented code better


I like the word numerator


Hi,

This fix is already there in version 1.6.0.14 but the error is still there. JS/Ajax is not working in admin panel at all.

Thanks


Добавление вызова метода repaint() для переключения панелей.


Still has two spaces ;)


and the image makes more hard to reach files.
Anyway:
aokromes@:~/src/6/src/server/game$ rgrep TALENT_SPEC_SHAMAN_ENCHANCEMENT *
aokromes@:~/src/6/src/server/game$


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2222](http://teamcity.monogame.net/viewLog.html?buildId=5650&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Just remove it alltogether :)


Well, I am not sure that's the issue in the hypernews, actually `literal_eval` should have worked. If you ask me I would not use curl, but RESTInteractions to do that call :)

Anyway, I don't know what the user problem is, I will let you investigate further


Релиз, парни! Оверскролл, скроллбэк и все остальные удовольствия под капотом ;)


Getting rid of the choose property of pol objects also required a minor tweak to disp.m


This is an incredibly annoying feature...

Damn button doesn't turn green when I edit some settings.


It looks kind of right, if I judge from pthread. I don't see where it
alerts the main thread of a change. But that might be implementation
details that qt just "has"
On Mar 10, 2015 1:54 PM, "Dwaligon" <notifications@github.com> wrote:

> I'll be honest, I skimmed the doc. I'm probably just implementing it
> wrong. but it compiles.. so that's half the battle!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Dwaligon/twitchcreep/commit/f2a41b9e53ae116227cd7f43f1d55bb780938276#commitcomment-10127215>
> .
>


Hello Celso,

Very, very good work!

I like this plugin because it is simple and lightweight, keep it like that :=)

Can you associate a "cancel" button with the  "edit " button and the "Confirm" one.

when one abandons its action , these buttons remains displayed.

Best regards


Note: the position to which the player can move must be given in a "normalized" manner, from 0 to 104 in X and from 0 to 68 in Y


IMO you can keep it then.

2015-03-10 19:39 GMT+01:00 Makman2 <notifications@github.com>:

> But I consider then renaming assertIteratorsEqual() into
> assertIteratorElementsEqual().
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/af458dafec88842b1cff8206c80654570a7cf190#commitcomment-10126909>
> .
>


currently, `tarsum.DefaultTHash` makes sha256 the default hash algorithm for tarsum. This is abstracted by the tarsum package. Should we do something similar in the digest package?


por que a self.tableview.tableHeaderView é inicializada 2 vezes?


are you suggesting a further action item here on these commits, or just complaining? it's not clear.


...or you find it useful, hit us up!


This is useless, I used it for logging purposes and forgot to remove.


okay, looks like all of that is working beautifully now.i thought of an additional bit i would like to do but i have no idea how. disrupt pattern can't be used unless the cryptic is psionically focused. was thinking it might be interesting to make the One Pattern unavailable to be activated (greyed out?) unless psi focused. is there a way to make an activateable greyed out like that?

Date: Tue, 10 Mar 2015 10:18:46 -0700
From: notifications@github.com
To: HL-Pack-3PP@noreply.github.com
CC: kiddtaylor@hotmail.com
Subject: Re: [HL-Pack-3PP] Corrected typo in COM_3PPPack_PathOfWar - Tags.1st (n ame instead of name) (44833d4)

@psych777 for your new One Pattern feat I have a couple of small tips.  Otherwise its looking good and really appreciate all the help you have been giving. =)

First one is all feats need the following at the top of the scripts. This prevents the feat from executing if it gets disabled from some outside source (archetype, feat, magic item, spell)...

~ If we're disabled, do nothing

doneif (tagis[Helper.FtDisable] <> 0)

Two is always make sure you do a += when dealing with field[abValue].value instead of = which does a set.  What if someone uses an adjustment or another script to adjust the value on this feat?  By using "=" that change will not be taken into account.

Three is it makes the script allot easier to work with if you use the value[] macro and it makes the script shorter and faster to write: field[abValue].value += #value[cPUDisPatt] + #value[cPUEnhDisr]

Four is the Disrupt Pattern ability is setup to have is "abValue" adjusted not to adjust the Fix Damage section directly.  The reason is it is easier to have a single script manipulate the text damage than multiple places.  Especially sense this extra damage is the type that is increased on a critical hit we need to be using the extradamage[] macro instead.  This fits into HL standards for "extra" damage.

On top of this the extradamage is only in specific situations which means we should be displayed as situational damage or it should be something a person can activate on the In-Play tab.  Otherwise a person on the iPad will always be adding this damage when they roll damage.  Which is not really correct because it only happens under a specific situation.  Adding situational text is great for those that use only paper character sheets as they will have a note next to the weapon to remind them.

If we can make these changes to the feat I would appreciate it!

—
Reply to this email directly or view it on GitHub.


nope.  RSolr.solr_escape is correct.


Hi Marco, is this function used in CRAB? Sorry I should've said more clear in the comments. (I almost forgot what I said that. :smile: ) I thought this function is created to be used in the agent, I didn't realize this is used outside the agent.
In that case, I should've have said "This returns completely different format expected from agent to process" i.e.
It is returning

files[f['logical_file_name']]['Parents'] = list of lfn

But other function returns different format which the Agent component expect.
https://github.com/dmwm/WMCore/blob/2afc01ae571390f5fa009dd258be757adac89c28/src/python/WMCore/Services/DBS/DBS3Reader.py#L468
files[f['logical_file_name']]['ParentList'] = list of file info not just lfn

So I simply thought function had a bug but since we are not using the function in agent yet, we couldn't find it before.
But if this api is used by CRAB. I won't touch anything and remove the comments I made. (Maybe clarify this function returns different format for reason.

https://github.com/dmwm/WMCore/blob/2afc01ae571390f5fa009dd258be757adac89c28/src/python/WMCore/Services/DBS/DBS3Reader.py#L505


:like


+1
I missed that the composite id should triggerId + triggerMode.
Good catch.


por que criar o atributo "busca" se ele só é utilizado no viewDidLoad?


@dougborg, why did you pull in README.md from master?  It doesn't correspond to what's available in 1.0.4: e.g. ARM64 is supported in master but not 1.0.4.


This is wrong. Value can be bitarray or anything that works. not only int.


Typo, "containg".


LGTM other than the typo.


Iván Rojo Naranjo


Personally, I would not like to test for changes in the whole JSON file, since then we would have to deal with many false test failures. You can imagine there are many insignificant changes to the JSON that will result in the same plotly, but would cause the JSON-diff test to fail. I prefer the current system of writing expect_ statements that test only the relevant parts of the JSON/list that comes out of gg2list.


This is completely wrong!
0.23em of font-size: $fs--175 = 5.6
whereas ($fs * 0.23) = 3.2


Yes, when we marshall generic Data classes, we may miss the type in a json object, so type should be explicit to deal with it.
+1 as a constant.


> Расскажи, зачем ты делаешь

А это jshint ругался, на необъявленную переменную window и console - исправил. Так же почистил код на соответствие стайлгайду яндекса.


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Whatever. After all, you devs have been around longer, and you guys expect all plugins to be all complex(ahem @iJoshuaHD) and don't think about the users themselves. I want my plugin to be easy to understand and easy to use.


this is for #145 , seems to be fixed. testing in production now.


реализовал вручную, но не глубокое копирование, тк для моей задачи глубокое не нужно https://github.com/fib0n/graph/commit/ac8ac617750605abd7dd67dd55935be51d56232c


done https://github.com/fib0n/graph/commit/ac8ac617750605abd7dd67dd55935be51d56232c


All of the changes in this file are wrong.
The pixel values here are used to adjust size and position of an icon from an icon font.
That's why there are non-standard values here, which need to be precisely as they are.


stu, this is for issue #145


@joekarl Is this code functioning? It seems like it would make more sense to use points instead of polygons.


I ended up leaving it out because it didn't seem to make a difference when it was in or not.  But thank you for the explanation.  (And nice catch!)

Is there any advantage to using
@section Scripts {
  @Scripts.Render("~/bundles/jqueryval")
}
over just directly calling
@Scripts.Render("~/bundles/jqueryui")

other than potentially being able to group all the script tags in the final html?


Hi Dennis,
could you pls tell me the ticket number for the "thing persistence update" issue? Then I will add the number to the TODOs of HueBridgeHandler and HueLightHandler...
Thx...
//Thomas


Fair enough. Maybe the compromise is that we can somehow "mark" the rows in the `test-table` that have changes made to them (like by comparing the JSON files). It's starting to get tough to visually inspect all of rows!


Yeah, that was accidental. I originally thought that was a good idea because I thought Seth updated the README when he did his build updates. I will revert it now...


Добавил отдельную ф-ю graphLazyCompile для ленивых вычислений https://github.com/fib0n/graph/commit/ac8ac617750605abd7dd67dd55935be51d56232c


```ruby
config.action_mailer.default_url_options = { host:  Figaro.env.domain_name }
```


yeah that sounds like a good idea to me


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2222](http://teamcity.monogame.net/viewLog.html?buildId=5650&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 441, ignored: 6 Build time: 00:14:19


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2223](http://teamcity.monogame.net/viewLog.html?buildId=5652&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


yup. sorry about the noise here


Agreed


The problem was that using the ```null``` method it isn't possible to make build inputs optional (with exception to anything that uses ```true```/```false```).  Adding ```true```/```false``` optionals for every build input complicates the build further as well.

The way I see it we could either:
1) Make anything that is non-free and already disabled by default an optional build input
```nix
buildInputs = [ anything gpl compatible ]
++ optionals nonfreeLicensing [ faac faad2 fdk_aac openssl ];
# openssl is non-FOSS and lumped with unfree software in FFmpegs configure script
```
2) For every build input add a true/false optional, change the configure flags to use the new optionals, add asserts for each optional, and make every build input optional

Option 1 is far simpler, but option 2 is a more robust solution at the expense of adding a bit more complication.  I don't mind either method, I just tried to keep everything as simple as possible.

@peti What are your thoughts on this should be handled?


@tiborvass This may just be out of date. We had some discussion in the past about whether we want to support base64 encoded digest bytes rather than hexadecimal. I think we decided to go with hex encoding, so yeah, it should be `[a-fA-F0-9]+`


I can't find any java code in here!!!


Didn't mean to invoke the mention mechanic @ heroku . Just a note to self.


The symbol 'character' is undefined here unless 'const int character = translateChar(&event->xkey)' is added at the top of this case. How can this compile?


Nooooooo! Exact pixel values are required for this thing to make it fit into the WordPress sidebar!
All the dimensions have been COMPLETELY changed!


Okay.
I've updated the code into something that compiles and pushed it to your branch, and merged to master. Expect further modifications on master while we test with the physical component to merge back into this branch later


this line is very long, good job/


cool port name


generally want to avoid putting side effects in asserts, in case they're compiled out (here and later in this patch)


14 * 8.5 = 119px
That's quite a change from the 12px that were there before.


Hey @harrietp  in future can you please do this in a branch as we're setting up for DL for Thursday?


may be assigned permissions as a contributor?


function not used, and rename to translation


1297-ExteriorLightsSchedule (macumber) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


1297-ExteriorLightsSchedule (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


que se modifico de este archivo?


Aaargh... em is a relative unit, based on the font size :-(
 ($fs * 2.75) is NOT equal 2.75em, if the font size is 16px and not 14!!!!


I gave up on Moto E Dual SIM, no way SaberSunset works properly on Dual SIM :( Maybe that's a legacy PA or AOSP fault in something and I don't realize.


you don't need this or the empty config property above, we won't be using the config engine here


Noooooooo!!!!
It will break, if the dimensions are changed, because it uses a background image!


I am in support of this for sure! #668

But why is the `setV` method overridden? It looks identical to the method inherited from the superclass.


Correct value: 50%


This could be written as `{Demonstration.Comments:htmlEncode:nl2br}`


well reverting this comment fixs the errors


@substack I noticed that the latest browserify no longer works with the mappings that worked with the original pathfilter.

Anyway you can provide a synopsis of what was wrong and the changes you made?  Thanks!


@sils1297 Well probably inline comments would be a good idea. Also, scattered reviews make it tough to keep track of what's to be prioritised in terms of work.
My suggestion from my last 3 years of receiving reviews. Please consolidate what you want in a single place. :) P.S I fixed this part of the commit in my local repo. Got lost while rebasing and rewording.


Should this be:
```
if not os.path.exists(identity):
```?
I think that is actually what you are testing for.


There is no error on clean TC. If it's custom, it's your job to fix your code and not revert our code.


build passed after patch applied, #605


WHAT!?
Why $fs--05 * 6 and not $fs--3?


*specifikace


What exactly is this `audit` cursor that is kept around"


no no no no no!!!


`onUpdate` should pass the values of `_x` and `_y` in both before and after states.

```javascript
function onUpdate(oldX, oldY, newX, newY) {
    // ...
}
```


TeamCity Helios :: Helios PR Build [Build 7](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=188&buildTypeId=Helios_HeliosPrBuild&guest=1) is now running


Found this issue: https://github.com/defunctzombie/node-browser-resolve/issues/56


TeamCity Helios :: Helios PR Build [Build 7](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=188&buildTypeId=Helios_HeliosPrBuild&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:05


Nvm, they are tested. Covered from `test_unescaped_search_in_between_regex_pattern`. The test patterns contain matching groups.


90022444-FewReleasePrepThings (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Kudo's for using this ;) I actually forgot about it!


This resource can be used to customize any Y level, and can be used to create patches of more than just water. Maybe call it SurfacePatch instead?

I made some minor changes to the implementation in https://github.com/MCTCP/TerrainControl/commit/2b6e144aab66d34e758e784b0eab357855e0813e . I also made one change in behaviour: materialcheck is now inverted to sourceBlocks. All other resources use sourceBlocks, so I felt it was better to invert this list.

On another note, maybe the spawn Y can be changed to min and max Y?


And suddenly all the relativity is gone


JS objects can not be used as keys for other objects, so this won't work.
But we may add `session.id` soon, which will enable using `easymotionMarkers[editor.session.id]` instead.


no units for line-height values


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2223](http://teamcity.monogame.net/viewLog.html?buildId=5652&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 441, ignored: 6 Build time: 00:15:06


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2224](http://teamcity.monogame.net/viewLog.html?buildId=5654&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2158 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.81%25-yellow.svg)


Add `@param` for `settings` and `settings.obUpdate`. For example: https://github.com/melonjs/melonJS/blob/b37536aa0a80559da5107c749a5e3d6694578f1d/src/entity/entity.js#L18-L27


@hnrch02 The `/docs/dist/` Gruntworker change has been deployed. :arrow_up:


Ah that's a good idea.


thx!


We could round, not that it makes a diff. (1 meter)


Suppression d'une ligne de test.


Preferably revert this feature.

Why this is a bad idea:
http://ux.stackexchange.com/questions/12741/disable-the-save-button-until-changes-are-made
http://www.joelonsoftware.com/items/2008/07/01.html


It calls set() instead, which sets _x and _y, then calls the onUpdate. This way the callback is only invoked once. Really though the base vector could be refactored to just call set() inside setV().


Won't an early return here cause the needed count to be truncated?


r+


Dittod


True, but I didn't really wan to muck about with the logic in this patch. I just duplicated the geosubmit and stuffed in the extra `radioType` field.


what


@mundya I presume you're happy with this change slyly finding its way into master via this PR?


Это у меня было какое-то сомнение в работе rand с классе.


Some pictures


Can you confirm this line is part of this patch?


Why did you rename this?


asdasda


Thanks! I try to keep it that way with improvements and optimizations.

You can further explain your idea with an example or something?


Shouldnt the system allow use to set that path in the configProps passed in.  If I want to run this as a server from my own java I really dont want to have to depend on environment variables.


Да, это я упустил


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (638 of 638 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.21%25-green.svg)


that's how you properly give feedback. much better, thanks.

we'll consider it.


closes #6


Good point! I like it better this way, then.


Зачем мне это, если есть грязный хак!))))


On my browser (FF)the alttext is displayed. but if I click 'view image' the svg is seen.


Hi, Thank you for reporting this and for your contribution, this will be included in V1.5.09 release which is currently under testing


Sorry to hear that. I was sure I'd seen this before.


Still not changing to OGL


test


2/2 Nice!


Only if one specifically enables it when compiling ogre on windows. (Though I'm not sure if the compiler will complain about implicit casting from float to double anyway.)


Done


What is eptr if no variables exist? Should be set to something /tmp by default or current directory.


Excellent one less thing for site owners to worry about!


![screen shot 2015-03-09 at 6 51 28 pm](https://cloud.githubusercontent.com/assets/10427178/6567975/72fb12ea-c68d-11e4-8310-431f0209d2f9.png)


2/2 great job!


도현님. 좋은 코드 고마워요. 방금 전 확인해봤는데, 피드밸 일부가 중복되서 나오는 문제가 있네요.


Current directory if no variable is set.


hello


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1146 of 1146 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.63%25-green.svg)


if WITH_KERNEL_VM is disable, mmu.c should remove from rules.mk at first place. So why we need add WITH_KERNEL_VM to the source which never get compiled in?


I tried commit but I don't see it here.


It depends on the plugin generator itself. A plugin generator could have made EssentialsPE if it was programmed well enough.


wat?


Good job. While your solution does work, a much more efficient and clean syntax (and what we were looking for) is:

```
<% @todo_models.count.each do |todo|%>
  <%= todo.tasks %>
  <%= todo.finished %>
<% end %>
```

You should google "each loop ruby" or "each loop rails" to learn more about this type of syntax – it will come up frequently throughout the rest of the course!

2/2


I don't think wrapping that where clause in an if statement is necessarily harder. A hack like this at least deserves a comment about what's going on.


@weierophinney may be it should be just written as `composer require phly/http`


> 모든 status 뷰 상단에 검색창을 넣을 야심이 있었는데, 그 경우 search 라우트를 새로 파면 좀 거시기하지 않나?

인과관계가 성립되나? "모든 뷰에 다 넣어야 하지 않나"라는 뜻이라면, 검색 폼을 `statuses/index.html.slim`에 넣지 않고 레이아웃 파일에 넣을 수 있지 (상단 네비게이션 바)


Yeah, that snuck into the commit. It was cleaned up in a later commit


0.5/2

So I saw that you created all your models and implemented the meow function, however I don't see anything in your pages controller or your home view. Let me know if there's anything I missed or you forgot to commit.


ㅇㅋ 그렇게 하는 걸로


I would rather see control->tmpdir set in main() rather than the workaround in open_tmpoutfile(). eptr could be set to ./ and be done with it. JM2C. I'll propose a patch if you like.

	if (control->tmpdir) {
		control->outfile = realloc(NULL, strlen(control->tmpdir) + 16);
		if (unlikely(!control->outfile))
			fatal_return(("Failed to allocate outfile name\n"), -1);
		strcpy(control->outfile, control->tmpdir);
		strcat(control->outfile, "lrzipout.XXXXXX");
	} else {
		control->outfile = realloc(NULL, 16);
		if (unlikely(!control->outfile))
			fatal_return(("Failed to allocate outfile name\n"), -1);
		strcpy(control->outfile, "lrzipout.XXXXXX");
	}


tbh that would make me want to stay on the server not leave :^)


Thanks guys! I'm half done!

On Mon, 9 Mar 2015 21:55 Mega <notifications@github.com> wrote:

> Hontou ni nice [image: :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NodeBB/NodeBB/commit/5b5615740324eee39da8e48412d16f225dfc1006#commitcomment-10112347>
> .
>


1297-ExteriorLightsSchedule (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2162 of 2183 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/980
failure: http://build.servo.org/builders/mac2/builds/1196


best commit eva


lol nerd


what is this?


I still don't understand what this `hint*` stuff is doing in scala-pickling, sorry about that. Do you only want to see the `hintStaticallyTyped` call going away or also the `hintTag` call?


this makes no sense at all


i needed this!


yes, it was moved to the global conf.py.


@woongy 여기서 sign_up에 대한 두 가지 sanitizer를 만든 이유가 뭐야?


@metrue ，我最近也好忙， 也只能周末做，慢慢来边学边做 :+1:


@vvo, Appium on Sauce now uses SemVer for version>=1 ,so you can just set:

```
appium-version=1
```

We are going to make it work with no version, but need to address some backward compatibility issues first.


Hey, have you looked at PR #3?


It was there temporarily, and then removed. I moved the border to the css class 'align-center'.


사용자 정보 설정 좀 해 주세요 ㅠ


히이이이이익


Build fails with this message:

    ghcjs-0.1.0-7.10.0.20150307.bin: ghc no longer supports single-file style package databases (dist/package.conf.inplace) use 'ghc-pkg init' to create the database with the correct format.


Fixed.


It is better practice for gender to be an Enum.


Nice job! thanks for fixing this...


Wow, getting banned from PocketMine for two weeks was the best thing that happened to me. It's quarter-finals and that was good to get my mind off PocketMine for a while. So no magical red ribbon on a Steve that crafts games!


@chazelton331 i'm stuck on this failing spec: "Failure/Error: expect(assigns(:articles)).to eq([ article1, article2 ])"


ㅈㅅ 잘못 넣은 듯. 왜 그랫지


I think I forgot to commit... Sorry about that. I've just committed it now.
Thanks for the heads up.

Sincerely,
Rachel Lee

*B.A. Statistics *
*UC Berkeley, 2016*
*rachel6394@berkeley.edu <rachel6394@berkeley.edu>*
*(858) 997-3542*

On Mon, Mar 9, 2015 at 6:59 PM, Jessica Lin <notifications@github.com>
wrote:

> Hey, I don't see any new commit with your solutions to the hw, did you
> forget to commit?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/reychil/sp15-hw3/commit/79d5fae959eba8ac9f3936ba114f87a97d385c78#commitcomment-10112396>
> .
>


I don't think making those stats 'correct' when profiling is worth the increased complexity.


@woongy 위의 질문에 대한 걸 추측해보자면, 여기서 required:true를 안 넣은 걸로 보아 team을 넣지 않아도 signup이 가능하게 하려고 한걸까? 만약 그렇다면...
첫번째, form에서 required는 default가 true인 것 같다.
두번째, team input을 required:false로 바꿔봤지만 User 모델에서 `validates :team, presence:true` 때문에 어차피 blank가 안 된다.
세번째, presence validater도 지우니까 DB 차원에서 null:false constraint때문에 입력이 안된다.

결론은 실수인건가?


hfsdhfgsdfh


라고 썼는데 실수였군 ㅋㅋ


updated tx icons to match color scheme


Indeed. Thanks.


Added back in, with link to REST API.


@MissChocoe I think we can add an option to this, so if it is switched on, the we use roundRectangle otherwise not. What do you think?


Was dependent on https://github.com/JuliaParallel/MPI.jl/pull/38 and https://github.com/JuliaLang/julia/pull/10453, both of which have been merged. Can you try it out now?


Hello nathan.

I saw all changes you have made in the settings dialog.
But this approach I find interesting.

I do not know if you remember a link I sent you a time ago, speaking at one of the points (**The Boolean Parameter Trap**), just about this: http://doc.qt.digia.com/qq/qq13-apis.html


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


83782874_LBNL_ThermostatOffsetFault (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


83782874_LBNL_ThermostatOffsetFault (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1145 of 1146 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.56%25-green.svg)


Thanks.


Things are working pretty well. I do have a question though. When add comments that works great but when I edit that is not. For example if comments has "my comments" and I change it to "the comments" that is not saving but if I replace "my comments" with "new ponies" that works fine. I will look at it more just one thing I just noticed.


83782874_LBNL_ThermostatOffsetFault (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Just did, and it works. Thanks.


Ceilometerグラフの作業用ブランチ
 Isuue#1065（https://github.com/project-hatohol/hatohol/issues/1065）の対処後に、
必要な箇所をrebaseしたりして再登録する。


I did a couple of small cosmetic changes. Also removed "Job Postings". It's a bit weird to have on the site compared to ML.


We are using integers for now.


Listo voy a corregir

Enviado desde mi iPhone

> El 9/03/2015, a las 20:40, "Camilo" <notifications@github.com> escribió:
>
> Andres, estas colocando en el repositorio de Producto una consulta que deberia ir en el repositorio de Categoria
>
> —
> Reply to this email directly or view it on GitHub.
>


Great! Thanks.


@jazzido @mtigas @floodfish: I'd love to hear y'all's thoughts on this one. Before, all selections' data was combined into a single HTML table. This commit separates each one into separate <table> elements. The transition appears as below:
![screenshot from 2015-03-09 22 39 33](https://cloud.githubusercontent.com/assets/548250/6568398/39d28168-c6ad-11e4-8382-a50c3fa69ef6.png)

Benefits to this include the ability to modify each individual selection: e.g. by changing the selection method on one (rather than wholesale) or downloading individual ones.

But the downside is the change -- and the fact that we still end up appending the tables in the output CSV. And that this is hard to explain to users...


jghg


Love the idea.

Re: concatenation in the exported CSV — What about an option like ‘Get as a single table’? If unchecked, the user gets a zipfile that contains each table as a separate CSV. Too weird?


LGTM


Ehh, not bad, actually. It's all kind of weird... :)


delete


Testing Commint............


@chrisie Can you instead integrate the `validator` package perhaps ([link](https://github.com/chriso/validator.js))?  Then you could do `validator.isEmail(val)` here.


See my other comment on this pull request.  As similar, you could use `validator.isURL` here.


acertado


An support airplay protocol player...

1.airplay协议支持使用https://github.com/juhovh/shairplay
2.音频播放使用VLC


东西得一样一样做 >_>


I think if any errors are returned from this callback or from getInfo you still should close the source.


Contact another Nexus 5 developer who uses GCC 4.9.
On Mar 10, 2015 2:10 AM, "Sebastian Jena" <notifications@github.com> wrote:

> I still have the same issue... I have totally no idea :/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android_build/commit/2dd7b438743d066ecbea92dc1f180b49692fdd65#commitcomment-10104347>
> .
>


Good call, will do.


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2156 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.72%25-yellow.svg)


83782874_LBNL_ThermostatOffsetFault (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@vcunat This commit rather seriously breaks Darwin.  `gettext` is unable to build now with:

```
building path(s) ‘/nix/store/nvmf57hv9krkz1bcg94ik1jndw2rjl5n-perl-LocaleGettext-1.05’
unpacking sources
unpacking source archive /nix/store/krv8jbr41wr5mwnxqjivij32qagmjx16-gettext-1.05.tar.gz
source root is gettext-1.05
patching sources
configuring
checking for gettext... no
checking for gettext in -lintl...gettext function not found. Please install libintl at Makefile.PL line 18.
 no
builder for ‘/nix/store/1klybb4pwnrf3bcpr2lm2hwz7b1wa7xv-perl-LocaleGettext-1.05.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/b98f2mx3bmxzs2jw1ywbyqih9g5lhf8j-help2man-1.46.5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/dm9vh6vlngyzj1n5bjhndkj4qj685g5a-libtool-2.4.5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/gfpzgk9yas6j2xmfzm9zzkxllp11527v-cctools-port-862.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/s74x0hkqp44i292rg67kpax4rin6d876-clang-wrapper-3.5.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/17hwvxwgw7n2f8875snzbnrgf26gf589-TeXLive-linkdir.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/3l4m70vb491nchqw5zl3wm3qf0h8wdr6-acl2-v6-5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/v6dc2scsvrzsb634h06rv9m2lvgbdb7q-bzr-tools-2.5.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/kaxqisp7rzw5q6zyshr993g3psbd79kl-compcert-2.4.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/x2bmi33gldh3ljbzzdb5ymhmkpa4fz0w-idris-wrapper.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/p0sdmrklxpxd2clyyi6ncsv24y535405-mtr-0.85.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/966pz0bingvadm64l8fr179dxh3g9ig4-setup.sh.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/l2ajyf5lhzx7sr3128wqrgpfjxiin354-stdenv-darwin-boot-3.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/gnnhzcd959v14ycskx9kypg635cbsj3d-texlive-core-2014.drv’: 1 dependencies couldn't be built
```

I've confirmed that if I revert this commit, everything builds fine.

Pinging @joelteon @copumpkin


rax retry tests


Note that I tracked this commit down as being the problem with:

``` bash
git bisect run nix-build . -j8 -Q -A pkgs.gettext
```


Sorry, I think there's some kind of mistake - I still don't see any commits from you?


It's here: https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh


Do you have the config.log for the failed test? Very often the specific failure is misleading (autoconf will pass an unrelated flag to the compiler that breaks the test)


What am i doing wrong? From the sp hw 3 directory, i am doing

git commit -m "comment"

Best,
Rachel
On Mar 9, 2015 7:58 PM, "Jessica Lin" <notifications@github.com> wrote:

> Sorry, I think there's some kind of mistake - I still don't see any
> commits from you?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/reychil/sp15-hw3/commit/79d5fae959eba8ac9f3936ba114f87a97d385c78#commitcomment-10112920>
> .
>


Prefer to avoid Confederate generals.


Это было сделано, чтобы не выйти за пределы size_t. Не был уверен, как это будет работать, если значение будет больше.


Missing return.


This is half-wrong. The !immunize command only checks if the nick is in var.DOCTORS, it does not check that their current role is "doctor" -- this means that an amnesiac that would turn into a doctor would be allowed to immunize before they turn. You should add in a proper role check to the immunize command to properly fail out in this case.

(if this was already fixed, you can ignore, I'm going through commits in order)


Grade: 2/2


Can I ask what makes you think it works as a passive aura on the entire party?

I'll gladly admit I'm not an expert of spells and how they work in the core, but this _seems_ to make some sense to me because:

1. The code is in the Pet class.
2. So it's the pet asking 'Does my owner, the hunter, have the Ferocious Inspiration talent?'.
3. If that is the case, spell 34457 is cast **on the pet** and not on any party/raid member.
4. According to my TBC QSW, spell 34457 puts an aura on the pet that triggers spell 34456 on proc:
  ID 6 (SPELL_EFFECT_APPLY_AURA)
  Targets (1, 0) (TARGET_SELF, NO_TARGET)
  Aura Id 42 (SPELL_AURA_PROC_TRIGGER_SPELL)
  Trigger spell: 34456 - Ferocious Inspiration. Chance = 101
  ToolTip: All damage increased.
5. And that triggered spell causes the party members aura in a 100 yard radius:
  ID 6 (SPELL_EFFECT_APPLY_AURA)
  Targets (20, 0) (TARGET_ALL_PARTY_AROUND_CASTER, NO_TARGET)
  Aura Id 79 (SPELL_AURA_MOD_DAMAGE_PERCENT_DONE)
  Radius (Id 12) 100.00

So it looks like this matches your description of how it should work. Did I miss anything?


Your right. I think that the following code would also do and require less work:

    ISetEntry orphaned = current;
    current = current.next();
    if (orphaned  == head) {
         head = head.next();
    }
      else{
          orphaned.remove();
     }


ok


The decorator already performs the check for the role, so this is a non-issue.


I'd rather log and send a traceback in this instance since if this happens there is a bug somewhere else that needs fixing. Instead of masking over the bug with this, I think it's better to alert us that there's an issue somewhere (or do both -- log it and also give them immunizations so they can make use of their role)


@s0undt3ch I was trying to look into this today and yesterday, but I was having a hard time even getting openSUSE to bootstrap. Right now we are running openSUSE 13.1 on the test suite...should we switch to 13.2 at some point? I ran a quick test just changing the cloud config on Jenkins to try running this on 13.2 yesterday but it didn't bootstrap.


Uploaded


Simples, mas ok


develop (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Feel free to include your own name to files that you modify.


А, да! Косяк!


ResultsSchema (sanyalj) - i386-Windows-7-VisualStudio-12: OK (1639 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


I'll merge in this pull request -- but it looks like you only added a new file which isn't referenced anywhere.  Did you also make changes to update "cpus_per_instance" with the data from instanceTypes?


Conferido e OK


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2224](http://teamcity.monogame.net/viewLog.html?buildId=5654&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 441, ignored: 6 Build time: 00:14:56


Don't you know about nesting in SASS?


what you


ack


> I see. Maybe you could skip the "implicit referenced" lines.

Maybe a way to match the candidate's meta is to look at the **`ParmVarDecl`** line:
```
ParmVarDecl 0x252dc60 <col:20, col:43> col:43 __format 'const char *restrict'
```
The keyword `restrict` is missing from the function declaration in the Clang's AST (`-x c`), but `ParmVarDecl` is complete.

I finished implementing a parsing system for different type of comments from the Clang's AST. So, now it is time to rework the way to match the candidate's meta. Next, read the comments directly from the files/buffer.

> Furthermore, at least [some C code is not valid in C++] (http://en.wikipedia.org/wiki/Compatibility_of_C_and_C++#Constructs_valid_in_C_but_not_in_C.2B.2B), so always forcing the `c++` mode would get you a syntax error in those (probably rare) cases.

Clang can deal with some errors/warnings providing the `-w` switch, but reserved C++ keywords are problematic:
```
// example.c
/**
 * This is a comment.
 */
struct template
{
    int new;
    struct template* class;
};
```
The above code fails miserably:
`$ cat example.c | clang -fno-color-diagnostaics -fsyntax-only -w -Xclang -ast-dump -Xclang -ast-dump-filter -Xclang template -x c++ -`


should use pkgconf and CFLAGS is not for LIBS =)


git status nii näkee mitkä kaikki filet on synkattuna  ^^


Qual a necessidade desta classe? Não foi utilizada no projeto.


Надо же как-то поздравить,хоть я и слоупок))


Please keep the description as a single sentence


Hi,

michael@flaga.net wants to follow you.

****** Is michael@flaga.net you friend? ******
If Yes please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Mpflaga/arduino-easytransfer&email=reply@reply.github.com&invitername=michael&inviterid=37135949&userid=0&token=0&emailmasterid=08694c5d-6661-4a42-9b91-0c080525c3a7&from=michael@flaga.net&src=txt_yes

If No please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Mpflaga/arduino-easytransfer&email=reply@reply.github.com&invitername=michael&inviterid=37135949&userid=0&token=0&emailmasterid=08694c5d-6661-4a42-9b91-0c080525c3a7&from=michael@flaga.net&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.flipmailer.com/uns_inviter.jsp?email=reply@reply.github.com&iid=08694c5d-6661-4a42-9b91-0c080525c3a7&from=michael@flaga.net


1: M111 unrecognized component name: testutils


No line break in l10n here


don`t you think is better let the curly braces in code ?