29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
36:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_SOLR_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_XAPIAN_ENABLED
36:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 36
36:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 36
36:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 36
36:1: F999 redefinition of unused 'CFG_LOGDIR' from line 36
36:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 36
36:1: F401 'CFG_XAPIAN_ENABLED' imported but unused
36:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
36:1: F401 'CFG_OAI_ID_FIELD' imported but unused
36:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
36:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
36:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
36:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
36:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
36:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
36:1: F401 'CFG_SITE_RECORD' imported but unused
36:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
36:1: F401 'CFG_INSPIRE_SITE' imported but unused
36:1: F401 'CFG_LOGDIR' imported but unused
36:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
36:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
36:1: F401 'CFG_BASE_URL' imported but unused
36:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
36:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
36:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
36:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
36:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
36:1: F401 'CFG_SOLR_URL' imported but unused
36:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
36:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
36:1: E402 module level import not at top of file
37:6: E126 continuation line over-indented for hanging indent
80:1: E402 module level import not at top of file
81:1: F401 'get_most_popular_field_values' imported but unused
81:1: E402 module level import not at top of file
82:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
82:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils
82:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
82:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
82:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
82:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
82:1: E402 module level import not at top of file
83:6: E126 continuation line over-indented for hanging indent
87:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors
87:1: F401 'get_fieldvalues_alephseq_like' imported but unused
87:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
90:1: I201 Missing newline before sections or imports.
90:1: F401 'create_record' imported but unused
90:1: F401 'record_xml_output' imported but unused
90:1: E402 module level import not at top of file
91:1: I101 Imported names are in the wrong order. Should be get_bibrank_methods, is_method_valid, rank_by_citations, rank_records
91:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.record_sorter should be before from invenio.legacy.bibrecord
91:1: F401 'rank_by_citations' imported but unused
91:1: F401 'get_bibrank_methods' imported but unused
91:1: E402 module level import not at top of file
96:1: I101 Imported names are in the wrong order. Should be calculate_reading_similarity_list, register_page_view_event
96:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.downloads_similarity should be before from invenio.legacy.bibrank.record_sorter
96:1: F401 'register_page_view_event' imported but unused
96:1: F401 'calculate_reading_similarity_list' imported but unused
96:1: E402 module level import not at top of file
97:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_stemmer should be before from invenio.legacy.bibrank.downloads_similarity
97:1: F401 'stem' imported but unused
97:1: E402 module level import not at top of file
98:1: F401 'BibIndexDefaultTokenizer' imported but unused
98:1: E402 module level import not at top of file
99:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.modules.indexer.tokenizers.BibIndexDefaultTokenizer
99:1: F401 'author_name_requires_phrase_search' imported but unused
99:1: F401 'get_field_tags' imported but unused
99:1: E402 module level import not at top of file
101:1: I101 Imported names are in the wrong order. Should be lower_index_term, wash_author_name, wash_index_term
101:1: F401 'wash_index_term' imported but unused
101:1: F401 'wash_author_name' imported but unused
101:1: F401 'lower_index_term' imported but unused
101:1: E402 module level import not at top of file
102:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_config should be before from invenio.legacy.bibindex.engine_washer
102:1: F401 'CFG_BIBINDEX_SYNONYM_MATCH_TYPE' imported but unused
102:1: E402 module level import not at top of file
103:1: I101 Imported names are in the wrong order. Should be create_excel, format_record, format_records, get_output_format_content_type
103:1: F401 'create_excel' imported but unused
103:1: F401 'get_output_format_content_type' imported but unused
103:1: F401 'format_record' imported but unused
103:1: F401 'format_records' imported but unused
103:1: E402 module level import not at top of file
104:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.downloads_grapher should be before from invenio.modules.formatter
104:1: F401 'create_download_history_graph_and_box' imported but unused
104:1: E402 module level import not at top of file
105:1: F401 'DataCacher' imported but unused
105:1: E402 module level import not at top of file
106:1: I101 Imported names are in the wrong order. Should be perform_external_collection_search, print_external_results_overview
106:1: F401 'perform_external_collection_search' imported but unused
106:1: F401 'print_external_results_overview' imported but unused
106:1: E402 module level import not at top of file
107:1: E402 module level import not at top of file
108:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, VIEWRESTRCOLL
108:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
108:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
108:1: E402 module level import not at top of file
111:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch.adminlib should be before from invenio.modules.access.local_config
111:1: F401 'get_detailed_page_tabs' imported but unused
111:1: F401 'get_detailed_page_tabs_counts' imported but unused
111:1: E402 module level import not at top of file
112:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.legacy.websearch.adminlib
112:1: I201 Missing newline before sections or imports.
112:1: E402 module level import not at top of file
113:1: I101 Imported names are in the wrong order. Should be DatabaseError, InvenioDbQueryWildcardLimitError, deserialize_via_marshal
113:1: I201 Missing newline before sections or imports.
113:1: F401 'deserialize_via_marshal' imported but unused
113:1: F401 'DatabaseError' imported but unused
113:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
113:1: E402 module level import not at top of file
114:1: F401 'acc_authorize_action' imported but unused
114:1: E402 module level import not at top of file
115:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine
115:1: E402 module level import not at top of file
116:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
116:1: F401 'encode_for_xml' imported but unused
116:1: F401 'wash_for_utf8' imported but unused
116:1: F401 'strip_accents' imported but unused
116:1: E402 module level import not at top of file
117:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
117:1: E402 module level import not at top of file
119:1: E402 module level import not at top of file
122:1: I101 Imported names are in the wrong order. Should be calculate_cited_by_list, calculate_co_cited_with_list, get_cited_by_list, get_citedby_hitset, get_citers_log, get_records_with_num_cites, get_refers_to_list, get_refersto_hitset
122:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before import invenio.legacy.template
122:1: F401 'get_citedby_hitset' imported but unused
122:1: F401 'calculate_cited_by_list' imported but unused
122:1: F401 'get_refersto_hitset' imported but unused
122:1: F401 'get_records_with_num_cites' imported but unused
122:1: F401 'get_cited_by_list' imported but unused
122:1: F401 'get_citers_log' imported but unused
122:1: F401 'calculate_co_cited_with_list' imported but unused
122:1: F401 'get_refers_to_list' imported but unused
122:1: E402 module level import not at top of file
127:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_grapher should be before from invenio.legacy.bibrank.citation_searcher
127:1: F401 'create_citation_history_graph_and_box' imported but unused
127:1: E402 module level import not at top of file
128:1: I101 Imported names are in the wrong order. Should be get_self_cited_by, get_self_cited_by_list, get_self_refers_to_list
128:1: F401 'get_self_refers_to_list' imported but unused
128:1: F401 'get_self_cited_by' imported but unused
128:1: F401 'get_self_cited_by_list' imported but unused
128:1: E402 module level import not at top of file
129:55: E126 continuation line over-indented for hanging indent
132:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
132:1: F401 'wash_table_column_name' imported but unused
132:1: F401 'get_table_update_time' imported but unused
132:1: F401 'run_sql_with_limit' imported but unused
132:1: E402 module level import not at top of file
134:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
134:1: F401 'collect_user_info' imported but unused
134:1: E402 module level import not at top of file
135:1: I101 Imported names are in the wrong order. Should be create_error_box, pagefooteronly, pageheaderonly, write_warning
135:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
135:1: F401 'pagefooteronly' imported but unused
135:1: F401 'create_error_box' imported but unused
135:1: F401 'write_warning' imported but unused
135:1: F401 'pageheaderonly' imported but unused
135:1: E402 module level import not at top of file
136:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webpage
136:1: E402 module level import not at top of file
138:1: F401 'apache' imported but unused
138:1: E402 module level import not at top of file
140:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch_external_collections should be before from invenio.utils
140:1: F401 'do_calculate_hosted_collections_results' imported but unused
140:1: F401 'calculate_hosted_collections_results' imported but unused
140:1: E402 module level import not at top of file
141:1: F401 'CFG_EXTERNAL_COLLECTION_MAXRESULTS' imported but unused
141:1: E402 module level import not at top of file
146:22: E203 whitespace before ':'
146:14: E225 missing whitespace around operator
147:24: E203 whitespace before ':'
148:24: E203 whitespace before ':'
149:28: E203 whitespace before ':'
150:30: E203 whitespace before ':'
151:24: E203 whitespace before ':'
152:23: E203 whitespace before ':'
153:29: E203 whitespace before ':'
154:26: E203 whitespace before ':'
155:33: E203 whitespace before ':'
156:30: E203 whitespace before ':'
157:30: E203 whitespace before ':'
158:30: E203 whitespace before ':'
159:30: E203 whitespace before ':'
160:30: E203 whitespace before ':'
161:30: E203 whitespace before ':'
162:41: E703 statement ends with a semicolon
164:1: E402 module level import not at top of file
165:1: F401 'collection_restricted_p' imported but unused
165:1: E402 module level import not at top of file
166:1: F401 'restricted_collection_cache' imported but unused
166:1: E402 module level import not at top of file
167:1: F401 'get_permitted_restricted_collections' imported but unused
167:1: E402 module level import not at top of file
168:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.utils
168:1: F401 'get_all_restricted_recids' imported but unused
168:1: E402 module level import not at top of file
171:1: F401 'check_user_can_view_record' imported but unused
171:1: E402 module level import not at top of file
173:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.records.access
173:1: E402 module level import not at top of file
174:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.collections.cache
174:1: E402 module level import not at top of file
175:1: F401 'get_field_i18nname' imported but unused
175:1: E402 module level import not at top of file
177:1: I100 Imports statements are in the wrong order. from invenio.modules.indexer.models should be before from invenio.modules.search.cache
177:1: E402 module level import not at top of file
183: D401 First line should be imperative: 'Create', not 'Creates'
183: D202 No blank lines allowed *after* function docstring, found 1
183: D400 First line should end with '.', not 'n'
183: D205 Blank line missing between one-line summary and description
191:33: E261 at least two spaces before inline comment
200:1: F401 'get_synonym_terms' imported but unused
200:1: E402 module level import not at top of file
202:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
202:1: E402 module level import not at top of file
205: D401 First line should be imperative: 'Return', not 'Returns'
205: D300 Expected """-quotes, got '-quotes
226:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers
226:1: F401 'get_collection_allchildren' imported but unused
226:1: E402 module level import not at top of file
229: D401 First line should be imperative: 'Return', not 'Returns'
229: D202 No blank lines allowed *after* function docstring, found 1
232:5: E266 too many leading '#' for block comment
236:5: E266 too many leading '#' for block comment
237:5: E266 too many leading '#' for block comment
239:34: E261 at least two spaces before inline comment
256:13: B901 blind except: statement
261:9: E266 too many leading '#' for block comment
273:9: E266 too many leading '#' for block comment
278:17: E266 too many leading '#' for block comment
287: D400 First line should end with '.', not 'o'
287: D205 Blank line missing between one-line summary and description
287: D208 Docstring is over-indented
332:1: F403 'from invenio.modules.search.engine import *' used; unable to detect undefined names
332:1: E402 module level import not at top of file
335: D209 Put multi-line docstring closing quotes on separate line
335: D400 First line should end with '.', not 'y'
335: D205 Blank line missing between one-line summary and description
335: D208 Docstring is over-indented
348:38: E203 whitespace before ','
379:1: E302 expected 2 blank lines, found 0
379: D209 Put multi-line docstring closing quotes on separate line
379: D400 First line should end with '.', not 'g'
379: D205 Blank line missing between one-line summary and description
379: D208 Docstring is over-indented
408: D209 Put multi-line docstring closing quotes on separate line
408: D205 Blank line missing between one-line summary and description
420:1: E402 module level import not at top of file
425: D290 White spaces around docstring should be trimmed.
425: D400 First line should end with '.', not 'h'
425: D205 Blank line missing between one-line summary and description
443: D401 First line should be imperative: 'I', not 'Is'
443: D400 First line should end with '.', not '?'
454:1: E302 expected 2 blank lines, found 1
454: D205 Blank line missing between one-line summary and description
454: D208 Docstring is over-indented
461:1: I101 Imported names are in the wrong order. Should be CACHE_SORTED_DATA, SORTING_METHODS
461:1: F401 'CACHE_SORTED_DATA' imported but unused
461:1: E402 module level import not at top of file
464: D205 Blank line missing between one-line summary and description
464: D208 Docstring is over-indented
478:20: E127 continuation line over-indented for visual indent
480:25: E126 continuation line over-indented for hanging indent
531: D103 Docstring missing
541: D401 First line should be imperative: 'calculate', not 'calculates'
541: D209 Put multi-line docstring closing quotes on separate line
541: D202 No blank lines allowed *after* function docstring, found 1
541: D400 First line should end with '.', not 'e'
541: D205 Blank line missing between one-line summary and description
552:20: E261 at least two spaces before inline comment
556:17: E261 at least two spaces before inline comment
599: D290 White spaces around docstring should be trimmed.
599: D400 First line should end with '.', not 'n'
605:25: E261 at least two spaces before inline comment
606:13: E222 multiple spaces after operator
629:10: E261 at least two spaces before inline comment
646:1: E266 too many leading '#' for block comment
648: D103 Docstring missing
649:25: E128 continuation line under-indented for visual indent
650:25: E128 continuation line under-indented for visual indent
651:25: E128 continuation line under-indented for visual indent
652:25: E128 continuation line under-indented for visual indent
669: D401 First line should be imperative: 'Set', not 'Sets'
669: D202 No blank lines allowed *after* function docstring, found 1
669: D400 First line should end with '.', not 'l'
669: D200 One-line docstring should not occupy 3 lines
670:23: E128 continuation line under-indented for visual indent
671:23: E128 continuation line under-indented for visual indent
672:23: E128 continuation line under-indented for visual indent
673:23: E128 continuation line under-indented for visual indent
674:23: E128 continuation line under-indented for visual indent
712:9: B901 blind except: statement


As for client side :+1:


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: E402 module level import not at top of file
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from datetime should be before from intbitset
29:1: I201 Missing newline before sections or imports.
29:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before from invenio.legacy.search_engine
34:1: E402 module level import not at top of file
35:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_indexer should be before from invenio.legacy.bibrank.citation_searcher
35:1: E402 module level import not at top of file
36:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibformat.dblayer should be before from invenio.legacy.bibrank.citation_indexer
36:1: E402 module level import not at top of file
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.modules.records.api should be before from invenio.utils.shell
38:1: E402 module level import not at top of file
39:1: I101 Imported names are in the wrong order. Should be task_get_option, task_has_option, task_init, task_set_option, task_sleep_now_if_required, task_update_progress, write_message
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.modules.records.api
39:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
49: D103 Docstring missing
59: D103 Docstring missing
127:1: E266 too many leading '#' for block comment
128:1: E266 too many leading '#' for block comment
137:1: E266 too many leading '#' for block comment
143:1: E266 too many leading '#' for block comment
150:1: E266 too many leading '#' for block comment
155:1: E266 too many leading '#' for block comment
193:1: E266 too many leading '#' for block comment
194:1: E266 too many leading '#' for block comment
202:5: F841 local variable 'dummy' is assigned to but never used
264: D103 Docstring missing
439:60: E251 unexpected spaces around keyword / parameter equals
440:18: E127 continuation line over-indented for visual indent
447:13: W503 line break before binary operator
448:13: W503 line break before binary operator
498:1: E266 too many leading '#' for block comment


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2011
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. import datetime should be before from time
31:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be CFG_LOGDIR, CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_URL, CFG_WEBALERT_MAX_NUM_OF_RECORDS_IN_ALERT_EMAIL, CFG_WEBALERT_SEND_EMAIL_NUMBER_OF_TRIES, CFG_WEBALERT_SEND_EMAIL_SLEEPTIME_BETWEEN_TRIES
33:1: E402 module level import not at top of file
34:6: E126 continuation line over-indented for hanging indent
41:1: I101 Imported names are in the wrong order. Should be add_to_basket, get_basket_owner_id
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.webbasket.api should be before from invenio.legacy.webbasket.db_layer
42:1: E402 module level import not at top of file
43:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, perform_request_search
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.legacy.webbasket.api
43:1: E402 module level import not at top of file
44:6: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.search_engine
45:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.legacy.webuser
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: E402 module level import not at top of file
52:1: I101 Imported names are in the wrong order. Should be CFG_EXTERNAL_COLLECTION_MAXRESULTS_ALERTS, CFG_EXTERNAL_COLLECTION_TIMEOUT
52:1: E402 module level import not at top of file
53:1: E122 continuation line missing indentation or outdented
54:1: E122 continuation line missing indentation or outdented
55:1: E402 module level import not at top of file
56:1: E402 module level import not at top of file
57:1: E402 module level import not at top of file
59:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.collections.models
59:1: E402 module level import not at top of file
63:1: E302 expected 2 blank lines, found 1
63: D202 No blank lines allowed *after* function docstring, found 1
68:1: E302 expected 2 blank lines, found 1
68: D202 No blank lines allowed *after* function docstring, found 1
73:1: E302 expected 2 blank lines, found 1
73: D401 First line should be imperative: 'Return', not 'Returns'
73: D202 No blank lines allowed *after* function docstring, found 1
78:1: E302 expected 2 blank lines, found 1
78: D401 First line should be imperative: 'Return', not 'Returns'
78: D202 No blank lines allowed *after* function docstring, found 1
78: D400 First line should end with '.', not 'm'
84:1: E302 expected 2 blank lines, found 1
84: D202 No blank lines allowed *after* function docstring, found 1
84: D400 First line should end with '.', not 's'
94:29: E261 at least two spaces before inline comment
122:99: E502 the backslash is redundant between brackets
157:1: E302 expected 2 blank lines, found 1
157: D401 First line should be imperative: 'Return', not 'Returns'
157: D202 No blank lines allowed *after* function docstring, found 1
163:1: E302 expected 2 blank lines, found 1
172:37: E261 at least two spaces before inline comment
173:29: E261 at least two spaces before inline comment
203:99: E502 the backslash is redundant between brackets
262:1: E302 expected 2 blank lines, found 1
262: D202 No blank lines allowed *after* function docstring, found 1
267:1: E302 expected 2 blank lines, found 1
267: D401 First line should be imperative: 'Return', not 'Returns'
267: D202 No blank lines allowed *after* function docstring, found 1
271:6: E221 multiple spaces before operator
272:6: E221 multiple spaces before operator
273:7: E221 multiple spaces before operator
274:8: E221 multiple spaces before operator
275:6: E221 multiple spaces before operator
276:7: E221 multiple spaces before operator
277:7: E221 multiple spaces before operator
278:7: E221 multiple spaces before operator
279:7: E221 multiple spaces before operator
280:7: E221 multiple spaces before operator
281:7: E221 multiple spaces before operator
282:8: E221 multiple spaces before operator
283:7: E221 multiple spaces before operator
284:7: E221 multiple spaces before operator
285:7: E221 multiple spaces before operator
286:8: E221 multiple spaces before operator
287:7: E221 multiple spaces before operator
288:7: E221 multiple spaces before operator
289:7: E221 multiple spaces before operator
290:7: E221 multiple spaces before operator
298:25: E261 at least two spaces before inline comment
298:26: E262 inline comment should start with '# '
300:10: E261 at least two spaces before inline comment
305:18: E261 at least two spaces before inline comment
305:19: E262 inline comment should start with '# '
318:35: E128 continuation line under-indented for visual indent
319:35: E128 continuation line under-indented for visual indent
320:35: E128 continuation line under-indented for visual indent
324:1: E302 expected 2 blank lines, found 1
324: D209 Put multi-line docstring closing quotes on separate line
324: D202 No blank lines allowed *after* function docstring, found 1
367:1: E302 expected 2 blank lines, found 1
367: D209 Put multi-line docstring closing quotes on separate line
367: D202 No blank lines allowed *after* function docstring, found 1
380:1: E302 expected 2 blank lines, found 1
380: D209 Put multi-line docstring closing quotes on separate line
380: D202 No blank lines allowed *after* function docstring, found 1
393:1: E302 expected 2 blank lines, found 1
393: D209 Put multi-line docstring closing quotes on separate line
393: D202 No blank lines allowed *after* function docstring, found 1
405:1: E302 expected 2 blank lines, found 1
405: D209 Put multi-line docstring closing quotes on separate line
405: D202 No blank lines allowed *after* function docstring, found 1
422:1: E302 expected 2 blank lines, found 1
422: D401 First line should be imperative: 'Log', not 'Logs'
422: D202 No blank lines allowed *after* function docstring, found 1
433:1: E302 expected 2 blank lines, found 1
433: D209 Put multi-line docstring closing quotes on separate line
433: D202 No blank lines allowed *after* function docstring, found 1
433: D400 First line should end with '.', not 's'
433: D205 Blank line missing between one-line summary and description
451:82: E502 the backslash is redundant between brackets
456:106: E502 the backslash is redundant between brackets
461:1: E302 expected 2 blank lines, found 1
461: D202 No blank lines allowed *after* function docstring, found 1
461: D400 First line should end with '.', not '?'
466:1: E302 expected 2 blank lines, found 1
466: D202 No blank lines allowed *after* function docstring, found 1
466: D400 First line should end with '.', not '?'
471:1: E302 expected 2 blank lines, found 1
471: D209 Put multi-line docstring closing quotes on separate line
471: D202 No blank lines allowed *after* function docstring, found 1
480:31: E261 at least two spaces before inline comment
486:1: E302 expected 2 blank lines, found 1
486: D209 Put multi-line docstring closing quotes on separate line
486: D202 No blank lines allowed *after* function docstring, found 1
486: D400 First line should end with '.', not 's'
486: D205 Blank line missing between one-line summary and description
494:1: E302 expected 2 blank lines, found 1
494: D209 Put multi-line docstring closing quotes on separate line
494: D202 No blank lines allowed *after* function docstring, found 1
494: D205 Blank line missing between one-line summary and description
509:1: E302 expected 2 blank lines, found 1
509: D209 Put multi-line docstring closing quotes on separate line
509: D202 No blank lines allowed *after* function docstring, found 1
509: D400 First line should end with '.', not 's'
509: D205 Blank line missing between one-line summary and description
532: D209 Put multi-line docstring closing quotes on separate line
532: D205 Blank line missing between one-line summary and description
543:64: E261 at least two spaces before inline comment
543:65: E262 inline comment should start with '# '
555:1: E302 expected 2 blank lines, found 1
555: D202 No blank lines allowed *after* function docstring, found 1
555: D400 First line should end with '.', not 'l'
576:44: E261 at least two spaces before inline comment
576:45: E262 inline comment should start with '# '


1: D100 Docstring missing
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: I100 Imports statements are in the wrong order. import fnmatch should be before import time
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
36:1: I201 Missing newline before sections or imports.
36:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
38:1: E402 module level import not at top of file
39:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_ADDING_RECORDS_STARTED_STR, CFG_BIBINDEX_INDEX_TABLE_TYPE, CFG_BIBINDEX_SPECIAL_TAGS, CFG_BIBINDEX_TOKENIZER_TYPE, CFG_BIBINDEX_UPDATE_MESSAGE, CFG_BIBINDEX_UPDATE_MODE, CFG_BIBINDEX_WASH_INDEX_TERMS, CFG_CHECK_MYSQL_THREADS, CFG_MAX_MYSQL_THREADS, CFG_MYSQL_THREAD_TIMEOUT
39:1: E402 module level import not at top of file
40:6: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibauthority.config should be before from invenio.legacy.bibindex.engine_config
49:1: E402 module level import not at top of file
50:6: E126 continuation line over-indented for hanging indent
51:1: I101 Imported names are in the wrong order. Should be get_control_nos_from_recID, get_index_strings_by_control_no
51:1: F401 'get_index_strings_by_control_no' imported but unused
51:1: E402 module level import not at top of file
52:6: E126 continuation line over-indented for hanging indent
53:1: I101 Imported names are in the wrong order. Should be get_synonym_terms, perform_request_search, search_pattern
53:1: E402 module level import not at top of file
54:6: E126 continuation line over-indented for hanging indent
56:1: I101 Imported names are in the wrong order. Should be DatabaseError, deserialize_via_marshal, run_sql, serialize_via_marshal, wash_table_column_name
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.legacy.search_engine
56:1: E402 module level import not at top of file
57:6: E126 continuation line over-indented for hanging indent
58:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_washer should be before from invenio.legacy.dbquery
58:1: E402 module level import not at top of file
59:1: I101 Imported names are in the wrong order. Should be get_datetime, task_get_option, task_get_task_param, task_init, task_set_option, task_sleep_now_if_required, task_update_progress, write_message
59:1: E402 module level import not at top of file
62:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.legacy.bibsched.bibtask
62:1: E402 module level import not at top of file
63:1: I201 Missing newline before sections or imports.
63:1: E402 module level import not at top of file
64:1: F401 'get_def_name' imported but unused
64:1: E402 module level import not at top of file
65:1: E402 module level import not at top of file
66:1: I101 Imported names are in the wrong order. Should be CFG_JOURNAL_PUBINFO_STANDARD_FORM, CFG_JOURNAL_PUBINFO_STANDARD_FORM_REGEXP_CHECK, CFG_JOURNAL_TAG
66:1: F401 'CFG_JOURNAL_PUBINFO_STANDARD_FORM_REGEXP_CHECK' imported but unused
66:1: F401 'CFG_JOURNAL_PUBINFO_STANDARD_FORM' imported but unused
66:1: F401 'CFG_JOURNAL_TAG' imported but unused
66:1: E402 module level import not at top of file
70:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.termcollectors should be before from invenio.modules.indexer.tokenizers.BibIndexJournalTokenizer
70:1: E402 module level import not at top of file
71:1: I101 Imported names are in the wrong order. Should be filter_for_virtual_indexes, get_all_index_names_and_column_values, get_all_indexes, get_all_synonym_knowledge_bases, get_field_tags, get_index_remove_html_markup, get_index_remove_latex_markup, get_index_remove_stopwords, get_index_tags, get_index_virtual_indexes, get_marc_tag_indexes, get_min_last_updated, get_nonmarc_tag_indexes, get_records_range_for_index, get_virtual_index_building_blocks, list_union, load_tokenizers, make_prefix, recognize_marc_tag, remove_inexistent_indexes, run_sql_drop_silently
71:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.legacy.bibindex.termcollectors
71:1: F401 'get_field_tags' imported but unused
71:1: F401 'get_all_index_names_and_column_values' imported but unused
71:1: E402 module level import not at top of file
92:1: E402 module level import not at top of file
93:1: F401 'get_record' imported but unused
93:1: E402 module level import not at top of file
94:1: E402 module level import not at top of file
95:1: I101 Imported names are in the wrong order. Should be NonmarcTermCollector, TermCollector
95:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.termcollectors should be before from invenio.utils.memoise
95:1: F999 redefinition of unused 'TermCollector' from line 70
95:1: E402 module level import not at top of file
99:1: E402 module level import not at top of file
114:17: E261 at least two spaces before inline comment
115:25: E261 at least two spaces before inline comment
122: D401 First line should be imperative: 'Return', not 'Returns'
131: D400 First line should end with '.', not 'n'
131: D205 Blank line missing between one-line summary and description
131: D208 Docstring is over-indented
146:66: E502 the backslash is redundant between brackets
151: D400 First line should end with '.', not 'd'
151: D205 Blank line missing between one-line summary and description
180: D400 First line should end with '.', not 'e'
180: D205 Blank line missing between one-line summary and description
188: D209 Put multi-line docstring closing quotes on separate line
188: D205 Blank line missing between one-line summary and description
191:53: E502 the backslash is redundant between brackets
214:67: E225 missing whitespace around operator
215:30: E124 closing bracket does not match visual indentation
215:31: E261 at least two spaces before inline comment
224:33: E261 at least two spaces before inline comment
236:33: E261 at least two spaces before inline comment
247:33: E261 at least two spaces before inline comment
259:33: E261 at least two spaces before inline comment
270:33: E261 at least two spaces before inline comment
282:33: E261 at least two spaces before inline comment
292: D401 First line should be imperative: 'Remove', not 'Removes'
292: D300 Expected """-quotes, got '-quotes
297: D401 First line should be imperative: 'Return', not 'Returns'
297: D400 First line should end with '.', not 'd'
309: D401 First line should be imperative: 'Return', not 'Returns'
309: D400 First line should end with '.', not 'e'
309: D205 Blank line missing between one-line summary and description
309: D208 Docstring is over-indented
320:68: E502 the backslash is redundant between brackets
328: D401 First line should be imperative: 'Check', not 'Checks'
328: D205 Blank line missing between one-line summary and description
328: D208 Docstring is over-indented
349: D401 First line should be imperative: 'Return', not 'Returns'
349: D400 First line should end with '.', not 's'
351:10: E225 missing whitespace around operator
366:56: E261 at least two spaces before inline comment
374: D290 White spaces around docstring should be trimmed.
374: D400 First line should end with '.', not 's'
374: D205 Blank line missing between one-line summary and description
385:70: E502 the backslash is redundant between brackets
386:32: E127 continuation line over-indented for visual indent
390: D401 First line should be imperative: 'Return', not 'Returns'
390: D400 First line should end with '.', not 'e'
390: D300 Expected """-quotes, got '-quotes
403: D401 First line should be imperative: 'Create', not 'Creates'
403: D209 Put multi-line docstring closing quotes on separate line
403: D400 First line should end with '.', not 'd'
403: D205 Blank line missing between one-line summary and description
422: D401 First line should be imperative: 'Return', not 'Returns'
422: D400 First line should end with '.', not 't'
444:74: E502 the backslash is redundant between brackets
448:52: E261 at least two spaces before inline comment
449:52: E261 at least two spaces before inline comment
450:54: E261 at least two spaces before inline comment
451:54: E261 at least two spaces before inline comment
454: D205 Blank line missing between one-line summary and description
454: D208 Docstring is over-indented
464:70: E502 the backslash is redundant between brackets
470: D290 White spaces around docstring should be trimmed.
470: D400 First line should end with '.', not 'd'
480: D401 First line should be imperative: 'find_affected_record', not 'find_affected_records'
480: D205 Blank line missing between one-line summary and description
480: D208 Docstring is over-indented
491: D202 No blank lines allowed *after* function docstring, found 1
491: D400 First line should end with '.', not 'd'
491: D205 Blank line missing between one-line summary and description
491: D208 Docstring is over-indented
512:37: E127 continuation line over-indented for visual indent
538:24: E127 continuation line over-indented for visual indent
547:20: E126 continuation line over-indented for hanging indent
585: D401 First line should be imperative: 'Split', not 'Splits'
585: D400 First line should end with '.', not 's'
585: D205 Blank line missing between one-line summary and description
585: D208 Docstring is over-indented
606: D203 Expected 1 blank line *before* class docstring, found 0
606: D205 Blank line missing between one-line summary and description
606: D208 Docstring is over-indented
625: D102 Docstring missing
630:65: E502 the backslash is redundant between brackets
631:49: E128 continuation line under-indented for visual indent
631:57: E502 the backslash is redundant between brackets
632:49: E128 continuation line under-indented for visual indent
632:62: E502 the backslash is redundant between brackets
633:49: E128 continuation line under-indented for visual indent
636:24: E261 at least two spaces before inline comment
639: D401 First line should be imperative: 'Update', not 'Updates'
639: D400 First line should end with '.', not 'B'
639: D205 Blank line missing between one-line summary and description
639: D208 Docstring is over-indented
644:57: E502 the backslash is redundant between brackets
646:64: E502 the backslash is redundant between brackets
648:62: E502 the backslash is redundant between brackets
649:23: E128 continuation line under-indented for visual indent
668:63: E502 the backslash is redundant between brackets
671:73: E502 the backslash is redundant between brackets
676:62: E502 the backslash is redundant between brackets
690:65: E502 the backslash is redundant between brackets
702:75: E502 the backslash is redundant between brackets
708:55: E502 the backslash is redundant between brackets
710:54: E502 the backslash is redundant between brackets
711:23: E128 continuation line under-indented for visual indent
713: D400 First line should end with '.', not 'y'
716:28: E261 at least two spaces before inline comment
720:74: E502 the backslash is redundant between brackets
724:74: E502 the backslash is redundant between brackets
726:134: E261 at least two spaces before inline comment
728:14: E261 at least two spaces before inline comment
729:70: E502 the backslash is redundant between brackets
733:142: E261 at least two spaces before inline comment
735:17: E266 too many leading '#' for block comment
736:17: E266 too many leading '#' for block comment
739:20: E261 at least two spaces before inline comment
740:104: E261 at least two spaces before inline comment
742: D401 First line should be imperative: 'Keep', not 'Keeps'
742: D400 First line should end with '.', not 'g'
742: D205 Blank line missing between one-line summary and description
742: D208 Docstring is over-indented
762:29: F841 local variable 'e' is assigned to but never used
763:84: E502 the backslash is redundant between brackets
775: D400 First line should end with '.', not 'y'
775: D205 Blank line missing between one-line summary and description
789: D401 First line should be imperative: 'Clean', not 'Cleans'
789: D300 Expected """-quotes, got '-quotes
794: D203 Expected 1 blank line *before* class docstring, found 0
794: D205 Blank line missing between one-line summary and description
794: D208 Docstring is over-indented
810: D401 First line should be imperative: 'Create', not 'Creates'
810: D205 Blank line missing between one-line summary and description
810: D208 Docstring is over-indented
819:43: E127 continuation line over-indented for visual indent
820:43: E127 continuation line over-indented for visual indent
821:43: E127 continuation line over-indented for visual indent
825: D401 First line should be imperative: 'Set', not 'Sets'
825: D400 First line should end with '.', not 'l'
825: D205 Blank line missing between one-line summary and description
825: D208 Docstring is over-indented
833: D205 Blank line missing between one-line summary and description
833: D208 Docstring is over-indented
852:85: E502 the backslash is redundant between brackets
874:28: E126 continuation line over-indented for hanging indent
877:87: E502 the backslash is redundant between brackets
907: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
907: D202 No blank lines allowed *after* method docstring, found 1
907: D400 First line should end with '.', not 'x'
907: D205 Blank line missing between one-line summary and description
907: D208 Docstring is over-indented
927: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
927: D202 No blank lines allowed *after* method docstring, found 1
927: D400 First line should end with '.', not 'x'
927: D205 Blank line missing between one-line summary and description
927: D208 Docstring is over-indented
947: D401 First line should be imperative: 'Update', not 'Updates'
947: D400 First line should end with '.', not ':'
947: D205 Blank line missing between one-line summary and description
947: D208 Docstring is over-indented
977:55: E502 the backslash is redundant between brackets
978:24: E127 continuation line over-indented for visual indent
979:24: E127 continuation line over-indented for visual indent
979:69: E261 at least two spaces before inline comment
981:174: E261 at least two spaces before inline comment
985: D401 First line should be imperative: 'Insert', not 'Inserts'
985: D400 First line should end with '.', not 'e'
985: D205 Blank line missing between one-line summary and description
985: D208 Docstring is over-indented
1013:179: E261 at least two spaces before inline comment
1015:174: E261 at least two spaces before inline comment
1019: D401 First line should be imperative: 'Remove', not 'Removes'
1019: D400 First line should end with '.', not 'd'
1019: D205 Blank line missing between one-line summary and description
1019: D208 Docstring is over-indented
1044:179: E261 at least two spaces before inline comment
1046:174: E261 at least two spaces before inline comment
1050: D401 First line should be imperative: 'Update', not 'Updates'
1050: D400 First line should end with '.', not 'o'
1050: D205 Blank line missing between one-line summary and description
1050: D208 Docstring is over-indented
1089: D401 First line should be imperative: 'Update', not 'Updates'
1089: D205 Blank line missing between one-line summary and description
1089: D208 Docstring is over-indented
1104: D401 First line should be imperative: 'Update', not 'Updates'
1104: D400 First line should end with '.', not 'd'
1104: D205 Blank line missing between one-line summary and description
1104: D208 Docstring is over-indented
1132: D401 First line should be imperative: 'Remove', not 'Removes'
1132: D400 First line should end with '.', not 'e'
1139: D401 First line should be imperative: 'Clean', not 'Cleans'
1139: D400 First line should end with '.', not ')'
1139: D205 Blank line missing between one-line summary and description
1139: D208 Docstring is over-indented
1146:18: E127 continuation line over-indented for visual indent
1150: D401 First line should be imperative: 'Remove', not 'Removes'
1150: D400 First line should end with '.', not ')'
1150: D205 Blank line missing between one-line summary and description
1150: D208 Docstring is over-indented
1167:5: E303 too many blank lines (2)
1167: D401 First line should be imperative: 'Remove', not 'Removes'
1167: D205 Blank line missing between one-line summary and description
1167: D208 Docstring is over-indented
1205: D203 Expected 1 blank line *before* class docstring, found 0
1205: D400 First line should end with '.', not 'x'
1205: D205 Blank line missing between one-line summary and description
1205: D208 Docstring is over-indented
1216: D401 First line should be imperative: 'Create', not 'Creates'
1216: D205 Blank line missing between one-line summary and description
1257: D401 First line should be imperative: 'Fill', not 'Fills'
1257: D400 First line should end with '.', not 'h'
1257: D205 Blank line missing between one-line summary and description
1257: D208 Docstring is over-indented
1280: D401 First line should be imperative: 'Prevent', not 'Prevents'
1280: D208 Docstring is over-indented
1280: D200 One-line docstring should not occupy 3 lines
1286: D401 First line should be imperative: 'Turn', not 'Turns'
1286: D208 Docstring is over-indented
1286: D200 One-line docstring should not occupy 3 lines
1292: D401 First line should be imperative: 'Return', not 'Returns'
1292: D209 Put multi-line docstring closing quotes on separate line
1292: D202 No blank lines allowed *after* method docstring, found 1
1292: D400 First line should end with '.', not 'e'
1292: D205 Blank line missing between one-line summary and description
1292: D208 Docstring is over-indented
1307: D401 First line should be imperative: 'Inform', not 'Informs'
1307: D205 Blank line missing between one-line summary and description
1307: D208 Docstring is over-indented
1327: D401 First line should be imperative: 'Display', not 'Displays'
1327: D300 Expected """-quotes, got '-quotes
1334: D401 First line should be imperative: 'Return', not 'Returns'
1334: D300 Expected """-quotes, got '-quotes
1338: D401 First line should be imperative: 'Print', not 'Prints'
1338: D300 Expected """-quotes, got '-quotes
1342: D202 No blank lines allowed *after* method docstring, found 1
1342: D300 Expected """-quotes, got '-quotes
1355:62: E502 the backslash is redundant between brackets
1356:17: E128 continuation line under-indented for visual indent
1358:75: E502 the backslash is redundant between brackets
1359:31: E127 continuation line over-indented for visual indent
1361: D401 First line should be imperative: 'Fetche', not 'Fetches'
1361: D400 First line should end with '.', not 's'
1361: D205 Blank line missing between one-line summary and description
1374:35: E261 at least two spaces before inline comment
1391:73: E502 the backslash is redundant between brackets
1392:25: E128 continuation line under-indented for visual indent
1402:73: E502 the backslash is redundant between brackets
1403:25: E128 continuation line under-indented for visual indent
1458:31: E701 multiple statements on one line (colon)
1479:27: E701 multiple statements on one line (colon)
1482:184: E261 at least two spaces before inline comment
1485:179: E261 at least two spaces before inline comment
1497: D401 First line should be imperative: 'Divide', not 'Divides'
1497: D209 Put multi-line docstring closing quotes on separate line
1497: D400 First line should end with '.', not ','
1497: D205 Blank line missing between one-line summary and description
1497: D208 Docstring is over-indented
1519: D209 Put multi-line docstring closing quotes on separate line
1519: D205 Blank line missing between one-line summary and description
1530:81: E502 the backslash is redundant between brackets
1531:17: E128 continuation line under-indented for visual indent
1534:63: E502 the backslash is redundant between brackets
1535:21: E128 continuation line under-indented for visual indent
1537: D401 First line should be imperative: 'Keep', not 'Keeps'
1537: D400 First line should end with '.', not 'g'
1537: D205 Blank line missing between one-line summary and description
1537: D208 Docstring is over-indented
1557:9: B901 blind except: statement
1561:5: E303 too many blank lines (2)
1561: D401 First line should be imperative: 'Fetche', not 'Fetches'
1561: D400 First line should end with '.', not 's'
1561: D205 Blank line missing between one-line summary and description
1577: D401 First line should be imperative: 'Delete', not 'Deletes'
1577: D209 Put multi-line docstring closing quotes on separate line
1577: D400 First line should end with '.', not 'w'
1577: D205 Blank line missing between one-line summary and description
1577: D208 Docstring is over-indented
1580:82: E502 the backslash is redundant between brackets
1581:17: E128 continuation line under-indented for visual indent
1591:80: E502 the backslash is redundant between brackets
1592:17: E128 continuation line under-indented for visual indent
1594: D401 First line should be imperative: 'Find', not 'Finds'
1594: D200 One-line docstring should not occupy 3 lines
1603: D400 First line should end with '.', not 'r'
1603: D205 Blank line missing between one-line summary and description
1627: D400 First line should end with '.', not 'e'
1645:35: E261 at least two spaces before inline comment
1676: D400 First line should end with '.', not 'e'
1678:9: E266 too many leading '#' for block comment
1684:19: E261 at least two spaces before inline comment
1686:9: E266 too many leading '#' for block comment
1689:17: E127 continuation line over-indented for visual indent
1694: D202 No blank lines allowed *after* method docstring, found 1
1694: D400 First line should end with '.', not 'y'
1694: D205 Blank line missing between one-line summary and description
1718:15: E261 at least two spaces before inline comment
1720:16: E713 test for membership should be 'not in'
1733:49: E713 test for membership should be 'not in'
1753:29: E128 continuation line under-indented for visual indent
1754:33: E128 continuation line under-indented for visual indent
1759:21: E126 continuation line over-indented for hanging indent
1770:13: E128 continuation line under-indented for visual indent
1771:13: E128 continuation line under-indented for visual indent
1794:13: E128 continuation line under-indented for visual indent
1795:13: E128 continuation line under-indented for visual indent
1811:13: E126 continuation line over-indented for hanging indent
1816:1: E302 expected 2 blank lines, found 1
1824:1: E302 expected 2 blank lines, found 1
1824: D290 White spaces around docstring should be trimmed.
1824: D400 First line should end with '.', not 'e'
1824: D205 Blank line missing between one-line summary and description
1858:78: E502 the backslash is redundant between brackets
1859:17: E128 continuation line under-indented for visual indent
1872:1: E302 expected 2 blank lines, found 1
1872: D290 White spaces around docstring should be trimmed.
1879: D401 First line should be imperative: 'Find', not 'Finds'
1879: D290 White spaces around docstring should be trimmed.
1879: D400 First line should end with '.', not ']'
1879: D205 Blank line missing between one-line summary and description
1879: D208 Docstring is over-indented
1898:36: E127 continuation line over-indented for visual indent
1904:41: E127 continuation line over-indented for visual indent
1907:36: E127 continuation line over-indented for visual indent
1913:41: E127 continuation line over-indented for visual indent
1918:36: E127 continuation line over-indented for visual indent
1925:41: E127 continuation line over-indented for visual indent
1946: D401 First line should be imperative: 'Find', not 'Finds'
1946: D290 White spaces around docstring should be trimmed.
1946: D400 First line should end with '.', not ']'
1946: D205 Blank line missing between one-line summary and description
1946: D208 Docstring is over-indented
1986:48: E261 at least two spaces before inline comment
1992: D401 First line should be imperative: 'Find', not 'Finds'
1992: D205 Blank line missing between one-line summary and description
1992: D208 Docstring is over-indented
2008: D401 First line should be imperative: 'Get', not 'Gets'
2008: D400 First line should end with '.', not 'n'
2008: D205 Blank line missing between one-line summary and description
2008: D208 Docstring is over-indented
2043: D401 First line should be imperative: 'Get', not 'Gets'
2043: D400 First line should end with '.', not 'e'
2043: D205 Blank line missing between one-line summary and description
2043: D208 Docstring is over-indented
2061: D401 First line should be imperative: 'Remove', not 'Removes'
2061: D205 Blank line missing between one-line summary and description
2061: D208 Docstring is over-indented
2085: D401 First line should be imperative: 'Decide', not 'Decides'
2085: D205 Blank line missing between one-line summary and description
2085: D208 Docstring is over-indented
2094: D205 Blank line missing between one-line summary and description
2094: D208 Docstring is over-indented
2127: D401 First line should be imperative: 'Run', not 'Runs'
2127: D205 Blank line missing between one-line summary and description
2127: D208 Docstring is over-indented
2183:85: E502 the backslash is redundant between brackets
2184:56: E128 continuation line under-indented for visual indent
2184:86: E502 the backslash is redundant between brackets
2185:56: E128 continuation line under-indented for visual indent
2191:5: E303 too many blank lines (2)
2212:29: E126 continuation line over-indented for hanging indent
2251:29: E126 continuation line over-indented for hanging indent
2263:25: E126 continuation line over-indented for hanging indent
2290:29: E126 continuation line over-indented for hanging indent
2304:25: E126 continuation line over-indented for hanging indent
2329:5: E303 too many blank lines (2)
2333:1: E266 too many leading '#' for block comment


The /dev/log with syslog_local() format is the default,  why do you need "-u /dev/log" ?

Anyway, from my point of view it's regression, -u has been introduced many years ago to bypass built-in syslog routines. I don't think it's correct to change the format in this case when we know that for local logs is RFC3164 unexpected.


hélas non :-( mais j ai déjà bien mieux (mais pas encore push) ;-)


Je poste ça ce soir


This is wrong. FIT files have exact information about start and stop events. `applyPauses()` will only apply pauses created by the device itself.


Hello

I have added a new game called "Toby" in the Scratch additional projects. (English Language)
For some reason, my commit also includes a foreign file (Kulüp yöneticileri için bilgiler.md). I have been trying to remove it from the commit, but being new to git, I can't work out how to do this.
Any help appreciated !

Caroline


will be randomized


Still no "smoke.txt" file inside the sfx folder :/


Vide discussão no issue #170


Was this pull request incorporated?
Have not figured out how to determine this


@jarveson Are you planning to make a PR for this?


develop (axelstudios) - i386-Windows-7-VisualStudio-12: OK (2196 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.23%25-yellow.svg)


syncronize => synchronize

To access the Transifex service and synchronize the translation files you must create a `~/.transifexrc` config file:


`c2cgeoportal Transifex interface <https://www.transifex.com/projects/p/geomapfish/resource/c2cgeoportal/>`_.


I don't understand this.


I don't really understand this patch, could you explain a little further? What UserWarning do you refer to (I don't have one)? Thanks :-)


Enabling Qcom hw aac encoder, makes my loganre camcorder crash. I don't know if the same issue happens also on serrano though.


Meow


Unless we really really want to use specs


* s/RFC3164/RFC5424/


If the names python2 and python are available depends on the distribution. `/usr/bin/env python` is the best you can do in any case as the user can control with his $PATH which of his python versions is actually used.

I cannot see anything in pep-0394 that would speak against using python. Actually it recommends that python should point to python2:

> The more general python command should be installed whenever any version of Python 2 is installed and should invoke the same version of Python as the python2 command

Distributions that chose to ignore this and point to python3 have to do some extra work in their blueman packages at the moment (Python 3 support should be ready soon and included in release 2.0, though).


Do we maybe want to mention that with microservices (as Fowler defines them), the comms mechanism can be a bunch of things, so long as they're lightweight?

For us, it's usually HTTP 1.1, but there's a bunch of others which you can mix and match depending on needs. e.g. HTTP2/SPDY & messaging. MQTT for instance seems to be gaining popularity for inter-microservice comms in some circles, since it's messaging with low overheads and low complexity (dumb pipes, smart endpoints).


Doesn't this always check the same token?  It would be more interesting to create a bunch of session tokens for a bunch of users, and check all of them in parallel.


(If I got this wrong, that means this function wants more comment.  :-)


BTW, this is also strange behaviour:

$ logger --stderr --rfc5424 tests
<5>Mar  5 11:59:39 logger: tests

.. I expect RFC3164 format or error message, rather than silently ignore --rfc5424.


Well, they're using the new API, but perhaps calling it in an old way. As we've learned, it's one of the trickier issues with microservices - if you change an API, and other services are consuming it, you may need to change those too (or you maintain backward compatibility - somehow).


:comments_closed 和 :sticky 只有管理员才能设置，这里不能 permit


88620944-FluidCoolerWithLowSpeedAuto (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1142 of 1142 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.62%25-green.svg)


closes #17


No, you're right. It always checks the same token. I just wanted a simple benchmark for all the basic functionality (http parsing, routing, request body decoding etc.). We should obviously have more varied, in-depth benchmarks for specific functionality as well, but that wasn't really my intention here.


I was going to fix it, but you came first :D


As I mentioned on #1044, if the commit there used `on_map_list_items.html` (and presumably had a blank `around_map_list_items.html`) then I don't think much of this commit (or next one) would be necessary, it could use the existing on_map behaviour.


QwtUpdate (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2152 of 2181 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.67%25-yellow.svg)


Yup, sure. If you `pip install --upgrade setuptools` to v12, when you run this `setup.py`, it will raise a `UserWarning` that says it has normalised `0.5dev` to `0.5.dev0`. There's not much more to it  ;)


I think this has snuck in from a different PR :)


I'm not really a fan of such alignments; it requires large code changes to maintain


This is great - but you haven't specified it on the model.


Could this be done using the existing `/ajax` call? There might well be a reason I'm missing, but it seems to be making two very similar calls on any map change. You could add it cobrand specifically if you were worried about the output.


```php
use CamelCaseModel;
```

This should be here.


Саламат


no, not the scripts themselves
it's there integration/generation which respect MVC


Okay, so just a quick heads up

- Partners as defined as part of our packages are a 'sponsorship' package now. Albeit a special one

Your section above about 'partners' may have to be changed to something like friends/contributors/educators or something along those lines?


Добавьте сюда поиск (Саламат)


Сама фабрика знала что ей возвращать


@jacobwilliams

I am using stream access+ unformatted+ deferred length string by at least 1 year... it is a standard, robust approach.


A quick note about commit messages. It's totally up to you whether you would like to do it, but just know that you can provide a list of items, and GitHub will format it as a nice… list.

If you write:

```
Add avatar image uploading for users to display.

* Install CarrierWave for uploading, MiniMagick to manipulate images.
* Generate avatar uploader and set configuration options to upload and
  display images.
* Create and run migration to add avatar string (path to file) to user table.
* Add uploader to user model.
* Permit avatar in user params in user controller.
* Install Fog to work with Amazon Web Services.
* Set environmental variables for AWS for security.
* Update app layout to display avatar.
* Update topic and post show views to display avatar of users who posted
  them.
```

it would be rendered on GitHub as:

##### Add avatar image uploading for users to display.

* Install CarrierWave for uploading, MiniMagick to manipulate images.
* Generate avatar uploader and set configuration options to upload and
  display images.
* Create and run migration to add avatar string (path to file) to user table.
* Add uploader to user model.
* Permit avatar in user params in user controller.
* Install Fog to work with Amazon Web Services.
* Set environmental variables for AWS for security.
* Update app layout to display avatar.
* Update topic and post show views to display avatar of users who posted
  them.

It also makes it easier to read as plain text, in the terminal.


деле, вы


Now we are a bit further:
00:06:34.996 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:72:9: error: 'u_char' does not name a type
00:06:34.996          u_char  ether_dhost[ETHER_ADDR_LEN];
00:06:34.996          ^
00:06:34.996 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:73:9: error: 'u_char' does not name a type
00:06:34.996          u_char  ether_shost[ETHER_ADDR_LEN];
00:06:34.996          ^
00:06:34.996 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:74:9: error: 'u_short' does not name a type
00:06:34.996          u_short ether_type;
00:06:34.996          ^
00:06:34.996 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:81:9: error: 'u_char' does not name a type
00:06:34.996          u_char octet[ETHER_ADDR_LEN];
00:06:34.996          ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:88:5: error: 'u_char' does not name a type
00:06:34.997      u_char dsap;
00:06:34.997      ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:89:5: error: 'u_char' does not name a type
00:06:34.997      u_char ssap;
00:06:34.997      ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/headers/ethernet.h:90:5: error: 'u_char' does not name a type
00:06:34.997      u_char ctrl;
00:06:34.997      ^
00:06:34.997 In file included from inet/common/serializer/headerserializers/arp/ARPSerializer.cc:24:0:
00:06:34.997 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:26:9: error: 'u_short' does not name a type
00:06:34.997          u_short ar_hrd;                  // Hardware type (16 bits)
00:06:34.997          ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:27:9: error: 'u_short' does not name a type
00:06:34.997          u_short ar_pro;                  // Protocol type (16 bits)
00:06:34.997          ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:30:9: error: 'u_short' does not name a type
00:06:34.997          u_short ar_op;                   // Operation code (16 bits)
00:06:34.997          ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:31:9: error: 'u_char' does not name a type
00:06:34.997          u_char ar_sha[ETHER_ADDR_LEN];   // source hardware address (n bytes)
00:06:34.997          ^
00:06:34.997 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:32:9: error: 'u_int32_t' does not name a type
00:06:34.997          u_int32_t ar_spa;                // source protocol address (m bytes)
00:06:34.997          ^
00:06:34.998 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:33:9: error: 'u_char' does not name a type
00:06:34.998          u_char ar_tha[ETHER_ADDR_LEN];   // target hardware address (n bytes)
00:06:34.998          ^
00:06:34.998 ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:34:9: error: 'u_int32_t' does not name a type
00:06:34.998          u_int32_t ar_tpa;                // target protocol address (m bytes)
00:06:34.998          ^
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc: In member function 'int inet::serializer::ARPSerializer::serialize(const inet::ARPPacket*, unsigned char*, unsigned int)':
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:40:13: error: 'struct INETFw::arphdr' has no member named 'ar_hrd'
00:06:34.998      arphdr->ar_hrd = htons(1); //ethernet
00:06:34.998              ^
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:40:29: error: 'htons' was not declared in this scope
00:06:34.998      arphdr->ar_hrd = htons(1); //ethernet
00:06:34.998                              ^
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:41:13: error: 'struct INETFw::arphdr' has no member named 'ar_pro'
00:06:34.998      arphdr->ar_pro = htons(ETHERTYPE_IP);
00:06:34.998              ^
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:44:13: error: 'struct INETFw::arphdr' has no member named 'ar_op'
00:06:34.998      arphdr->ar_op = htons(pkt->getOpcode());
00:06:34.998              ^
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:45:53: error: 'struct INETFw::arphdr' has no member named 'ar_sha'
00:06:34.998      pkt->getSrcMACAddress().getAddressBytes(arphdr->ar_sha);
00:06:34.998                                                      ^
00:06:34.998 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:46:13: error: 'struct INETFw::arphdr' has no member named 'ar_spa'
00:06:34.998      arphdr->ar_spa = htonl(pkt->getSrcIPAddress().getInt());
00:06:34.998              ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:46:59: error: 'htonl' was not declared in this scope
00:06:34.999      arphdr->ar_spa = htonl(pkt->getSrcIPAddress().getInt());
00:06:34.999                                                            ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:47:54: error: 'struct INETFw::arphdr' has no member named 'ar_tha'
00:06:34.999      pkt->getDestMACAddress().getAddressBytes(arphdr->ar_tha);
00:06:34.999                                                       ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:48:13: error: 'struct INETFw::arphdr' has no member named 'ar_tpa'
00:06:34.999      arphdr->ar_tpa = htonl(pkt->getDestIPAddress().getInt());
00:06:34.999              ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc: In member function 'void inet::serializer::ARPSerializer::parse(const unsigned char*, unsigned int, inet::ARPPacket*)':
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:63:34: error: 'struct INETFw::arphdr' has no member named 'ar_op'
00:06:34.999      pkt->setOpcode(ntohs(arphdr->ar_op));
00:06:34.999                                   ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:63:39: error: 'ntohs' was not declared in this scope
00:06:34.999      pkt->setOpcode(ntohs(arphdr->ar_op));
00:06:34.999                                        ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:65:34: error: 'struct INETFw::arphdr' has no member named 'ar_sha'
00:06:34.999      temp.setAddressBytes(arphdr->ar_sha);
00:06:34.999                                   ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:67:34: error: 'struct INETFw::arphdr' has no member named 'ar_tha'
00:06:34.999      temp.setAddressBytes(arphdr->ar_tha);
00:06:34.999                                   ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:69:52: error: 'struct INETFw::arphdr' has no member named 'ar_spa'
00:06:34.999      pkt->setSrcIPAddress(IPv4Address(ntohl(arphdr->ar_spa)));
00:06:34.999                                                     ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:69:58: error: 'ntohl' was not declared in this scope
00:06:34.999      pkt->setSrcIPAddress(IPv4Address(ntohl(arphdr->ar_spa)));
00:06:34.999                                                           ^
00:06:34.999 inet/common/serializer/headerserializers/arp/ARPSerializer.cc:70:53: error: 'struct INETFw::arphdr' has no member named 'ar_tpa'
00:06:34.999      pkt->setDestIPAddress(IPv4Address(ntohl(arphdr->ar_tpa)));


Можно было  сделать не в констркторе а в переменной класса


`"INSERT INTO #{entity_name}"  #{field_names_str} VALUES#{fields_values_str}`


don't you think the nei sprites look kind of bad in game? @fewizz


случае, команда


Не ошибок, если id не найден


Сделать масив – какой ключ, какое значение


As per pep-394, `python2` should be available if python 2 is installed. Is there any example of a modern distribution *lacking* `python2`?

pep-394 mentions that `python2` should exists if python 2 is installed, and the same applies for `python3`. To which version `python` points to may vary.
Since blueman *only* works with python 2, it makes sense to point to that one *explicitly*.

>  In order to tolerate differences across platforms, all new code that needs to invoke the Python interpreter should not specify python , but rather should specify either python2 or python3 [...]

This is the case with blueman. `python2` should be specified.

> Avoiding breakage of such third party scripts is the key reason this PEP recommends that python continue to refer to python2 for the time being. Until the conventions described in this PEP are more widely adopted, having python invoke python2 will remain the recommended option.

These conventions have been widely adopted for several years now, hence, many distributions have since included python 3 as the default python.

---

All this argument aside, there are no downsides to using `python2` instead of `python` in these scripts. However, there are downsides to keeping it as it is (notably, that downstream patching is required for blueman to work as expected on distributions that have python3 as the default python).


которая, как аргумент, принимает (пояснение)


в которых были изменения


I'm not sure what this commit is for?


@6a6d74 is it o.k. to merge this?


There is a lot that needs to be removed from this PR, as it overlaps with MAID-844 and Mahmouds work, so I'll clean it out soon


одну t в слове committer потерял


Ok, I think it's better to fix this with a Windows box at hand, so I'll
forward this bug.

Thank you,
levy

On Thu, Mar 5, 2015 at 12:12 PM, tillsteinbach <notifications@github.com>
wrote:

> Now we are a bit further:
> 00:06:34.996
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:72:9:
> error: 'u_char' does not name a type
> 00:06:34.996 u_char ether_dhost[ETHER_ADDR_LEN];
> 00:06:34.996 ^
> 00:06:34.996
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:73:9:
> error: 'u_char' does not name a type
> 00:06:34.996 u_char ether_shost[ETHER_ADDR_LEN];
> 00:06:34.996 ^
> 00:06:34.996
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:74:9:
> error: 'u_short' does not name a type
> 00:06:34.996 u_short ether_type;
> 00:06:34.996 ^
> 00:06:34.996
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:81:9:
> error: 'u_char' does not name a type
> 00:06:34.996 u_char octet[ETHER_ADDR_LEN];
> 00:06:34.996 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:88:5:
> error: 'u_char' does not name a type
> 00:06:34.997 u_char dsap;
> 00:06:34.997 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:89:5:
> error: 'u_char' does not name a type
> 00:06:34.997 u_char ssap;
> 00:06:34.997 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/headers/ethernet.h:90:5:
> error: 'u_char' does not name a type
> 00:06:34.997 u_char ctrl;
> 00:06:34.997 ^
> 00:06:34.997 In file included from
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:24:0:
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:26:9:
> error: 'u_short' does not name a type
> 00:06:34.997 u_short ar_hrd; // Hardware type (16 bits)
> 00:06:34.997 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:27:9:
> error: 'u_short' does not name a type
> 00:06:34.997 u_short ar_pro; // Protocol type (16 bits)
> 00:06:34.997 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:30:9:
> error: 'u_short' does not name a type
> 00:06:34.997 u_short ar_op; // Operation code (16 bits)
> 00:06:34.997 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:31:9:
> error: 'u_char' does not name a type
> 00:06:34.997 u_char ar_sha[ETHER_ADDR_LEN]; // source hardware address (n
> bytes)
> 00:06:34.997 ^
> 00:06:34.997
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:32:9:
> error: 'u_int32_t' does not name a type
> 00:06:34.997 u_int32_t ar_spa; // source protocol address (m bytes)
> 00:06:34.997 ^
> 00:06:34.998
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:33:9:
> error: 'u_char' does not name a type
> 00:06:34.998 u_char ar_tha[ETHER_ADDR_LEN]; // target hardware address (n
> bytes)
> 00:06:34.998 ^
> 00:06:34.998
> ../src/inet/common/serializer/headerserializers/arp/headers/arp.h:34:9:
> error: 'u_int32_t' does not name a type
> 00:06:34.998 u_int32_t ar_tpa; // target protocol address (m bytes)
> 00:06:34.998 ^
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc: In member
> function 'int inet::serializer::ARPSerializer::serialize(const
> inet::ARPPacket*, unsigned char*, unsigned int)':
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:40:13: error:
> 'struct INETFw::arphdr' has no member named 'ar_hrd'
> 00:06:34.998 arphdr->ar_hrd = htons(1); //ethernet
> 00:06:34.998 ^
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:40:29: error:
> 'htons' was not declared in this scope
> 00:06:34.998 arphdr->ar_hrd = htons(1); //ethernet
> 00:06:34.998 ^
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:41:13: error:
> 'struct INETFw::arphdr' has no member named 'ar_pro'
> 00:06:34.998 arphdr->ar_pro = htons(ETHERTYPE_IP);
> 00:06:34.998 ^
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:44:13: error:
> 'struct INETFw::arphdr' has no member named 'ar_op'
> 00:06:34.998 arphdr->ar_op = htons(pkt->getOpcode());
> 00:06:34.998 ^
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:45:53: error:
> 'struct INETFw::arphdr' has no member named 'ar_sha'
> 00:06:34.998 pkt->getSrcMACAddress().getAddressBytes(arphdr->ar_sha);
> 00:06:34.998 ^
> 00:06:34.998
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:46:13: error:
> 'struct INETFw::arphdr' has no member named 'ar_spa'
> 00:06:34.998 arphdr->ar_spa = htonl(pkt->getSrcIPAddress().getInt());
> 00:06:34.998 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:46:59: error:
> 'htonl' was not declared in this scope
> 00:06:34.999 arphdr->ar_spa = htonl(pkt->getSrcIPAddress().getInt());
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:47:54: error:
> 'struct INETFw::arphdr' has no member named 'ar_tha'
> 00:06:34.999 pkt->getDestMACAddress().getAddressBytes(arphdr->ar_tha);
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:48:13: error:
> 'struct INETFw::arphdr' has no member named 'ar_tpa'
> 00:06:34.999 arphdr->ar_tpa = htonl(pkt->getDestIPAddress().getInt());
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc: In member
> function 'void inet::serializer::ARPSerializer::parse(const unsigned char*,
> unsigned int, inet::ARPPacket*)':
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:63:34: error:
> 'struct INETFw::arphdr' has no member named 'ar_op'
> 00:06:34.999 pkt->setOpcode(ntohs(arphdr->ar_op));
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:63:39: error:
> 'ntohs' was not declared in this scope
> 00:06:34.999 pkt->setOpcode(ntohs(arphdr->ar_op));
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:65:34: error:
> 'struct INETFw::arphdr' has no member named 'ar_sha'
> 00:06:34.999 temp.setAddressBytes(arphdr->ar_sha);
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:67:34: error:
> 'struct INETFw::arphdr' has no member named 'ar_tha'
> 00:06:34.999 temp.setAddressBytes(arphdr->ar_tha);
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:69:52: error:
> 'struct INETFw::arphdr' has no member named 'ar_spa'
> 00:06:34.999 pkt->setSrcIPAddress(IPv4Address(ntohl(arphdr->ar_spa)));
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:69:58: error:
> 'ntohl' was not declared in this scope
> 00:06:34.999 pkt->setSrcIPAddress(IPv4Address(ntohl(arphdr->ar_spa)));
> 00:06:34.999 ^
> 00:06:34.999
> inet/common/serializer/headerserializers/arp/ARPSerializer.cc:70:53: error:
> 'struct INETFw::arphdr' has no member named 'ar_tpa'
> 00:06:34.999 pkt->setDestIPAddress(IPv4Address(ntohl(arphdr->ar_tpa)));
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/inet-framework/inet/commit/618aaf7c535e59faf36bf3376496ab94eed2b215#commitcomment-10049141>
> .
>


увидеть, в каких


QwtUpdate (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I agree :)


There should be a test for this.


Also the category being added in map_pins (and later status too) doesn't appear to be being used by the JavaScript, if I've followed it through correctly. If it's only used for getting a list of categories of the displayed pins, that could remain server side and not be given to the client?


This is perfect. Thank you!


Why are those lines commented out? If they're not required anymore, just remove them.


Changing this API requires to change it in Driver.php and the the other driver implementations too.


Jquery eingebunden. Nicht Bootstrap


You set the placeholders, but not the values.


Agreed. I didn't add one at this commit due to it making another test give warnings, but there should be an explicit test.


Seems to be there now, thank you :)

BTW Ozy, generally it's a good thing to have someone that ambitious on the team, but asking for permission also helps organizing stuff :)


Trying the comment function


catched -> caught


> this change means that MemberLiteral.objectExpression is not longer used at all.

Correct.

> Am I supposed to figure out which object I need to bind() to for myself now? (for meta references to top-level object decls which are auto-bound).

I don't know what you mean.


Yeah, we can make this safer, but likely the truly safest way is to ensure its not happening inside a comment.

To me, the safest transformation is:
1. Replace leading hash bang (this is already safe.
2. attempt parse.
3. If parse fails, replace instrumentation comments more specifically using the regex you provided rather than just a leading `#`


@seafoox Do you remember why you used `setTimeout` instead of relying on `xmlHttp.ontimeout = function() {}`?

Thanks


Dommage pour l'animation, elle était vraiment sympa !

Sinon, ce qui se fait souvent dans c'est de faire clignoter(disparaître puis réapparaître) rapidement pendant un cours laps de temps l'image du Joueur ou PNJ touché. Et généralement l'objet dans cet état est invulnérable pendant cette période.


I needed a quick animation for modals, without having to use a new navigator state


gee good job conor.....


Personally I like them and have gotten used it them without even noticing they changed.


Yes, I see your point. If the 2.0 release will not have full support for Python 3 (which I doubt as it's really close), it will ship with python2 as the interpreter. Promised. :wink:


Link pro zenhub?


This file contains x y z coordinates, from accelerometer(Android phone). x y z each component rotate 10 time in x y and z direction. As we can see in 3D graph, velocity vector turned three direction after every 10 rounds.


Beach Freinds actions.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: db_central_columns.php, libraries/central_columns.lib.php


I'd go with `6px` as per https://github.com/mysociety/alavetelitheme/pull/36#discussion_r25853099


vv


lk,lk


Pois é fiz merd*, mas no meu esta correto, pq?

2015-03-05 8:24 GMT-03:00 Andreo Vieira <notifications@github.com>:

> Link pro zenhub?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angelorubin/defender/commit/60b8621ce66009cffd3643ddcd8f4632f84170b4#commitcomment-10049322>
> .
>


@iherman - thanks for this. I think it looks good ...

Before I accept the pull request, I want to go through the changes to identify any that _also_ need to be in the csv2json doc ... should be later today.

BTW, after the discussion yesterday, I was simply going to remove the `t1:` type prefixes and use absolute URLs. I'll make that change post-merge.


I think this.hosts is defined twice. (see l. 37)


Yes, but C++03 is not C99 compatible.


Thanks, I'll fix that ;)


i suggest the first sentence then


    <!-- Compose screen, prefixed to the subject of a message when replying to it (if not already present). Do not translate. -->

https://github.com/AOKP/packages_apps_UnifiedEmail/blob/7b1779cdd491f47611b0b200f4fc996ff9f81e86/res/values/strings.xml


vishwas


I think the `catch` is unnecessary because `.to.be.fulfilled` is handling this already.


C99 says: `No two signed integer types shall have the same rank, even if they hav e the same
representation.`

I'm wondering if it's needed to following this...


yes, I agree :-)


Can't report issue in your depot.
It seems Dawn does not compile anymore.


This is not the only way to get the QueryManager (this is not even the standard way), you should register it as mock component to not have two different instances with different mocks.


重复的就跳过它不是可以加快速度么...


Passing a L.latLngBounds object into fitbounds causes a lat undefined error because:
L.latLngBounds(L.latLngBounds(arr)) === null


Updated based on comments in 49abcf27d1c23aaf9d6aed0399da4cca75e2c4c2


@witzigs
Bitte den Wrapper verwenden, oder https


Комментарии лучше писать в формате с /// --- https://msdn.microsoft.com/en-us/library/b2s063f7(v=vs.110).aspx


I don't understand the `true && X` construct - the `true &&` part just seems to be redundant.

Having two catch clauses would be more elegant than inspecting the type with string operations, i.e. something like:

```
    } catch (const Xapian::InvalidArgumentError &) {
        return true;
    } catch (const Xapian::Error &) {
        return false;
    }
```

But actually it would be better to let unexpected errors propagate, as then the test harness with catch them, report them, and fail the test case:

```
    } catch (const Xapian::InvalidArgumentError &) {
        return true;
    }
```

But I assume this is because the database might be one which we can't call check on (remote or inmemory or a multidatabase or whatever), in which case `get_named_writable_database_path()` will throw that exception.  If so, then you really only want to wrap that single statement in the `try`/`catch` - we don't want to ignore `InvalidArgumentError` if an invalid argument is passed somewhere when actually checking a database.


In case of Ambient display ... low light... hotplug will not resume!
But when low light goes off, there will be crash... I think because suspend notifiers are called again.
In that case, you will need to ensure via client drivers that previous state should not be equal to current state. But this will only fix the crash, not sure if driver will wakeup completely.

I changed to State notifier driver. You can use state notifier anywhere you think suspend-resume is done.
On Shamu, it's in panel:
https://github.com/neobuddy89/shamu/commit/a6564086fbe95c6d480d3b194210ec0b673b2222
On Hammerhead, it's in mdss:
https://github.com/neobuddy89/hammerhead/commit/0e79b2acdc201afd70582fd102bc64729b8720ae
On G2, you can put it in powersuspend drivers.

Regarding FB notifiers, I don't understand use of "FB_EVENT_BLANK"


Replied here:
https://github.com/dorimanx/Dorimanx-LG-G2-D802-Kernel/commit/bca4da3fc77d28556aa0b97e488768e941c0367d


I Used this code on moodle2.8.2. It needs a minor change otherwise it results in a Fatal error. Two modifications are required wherever add_to_log has been  commented out in the function:
---------------For example view.php----------------------------
//before line no.50
// $event = .......
require_once('classes/event/course_module_viewed.php'); // for including the class file
use mod_certificate\event; // use keyword for using the namespace

Otherwise, it is really a great help. Thanks.


I would really like braces around `@filepath` here (sorry for not having a clear coding style document in the repo). But the removal of the braces on the next line is fine (the indentation serves as a brace there).


That sounds like I could help there!

2015-03-04 18:05 GMT+01:00 Jeff Bezanson <notifications@github.com>:

> Help would be great! If you look at the diff so far, it gives an idea of
> some of the tedious work needed: anywhere the system was using jl_tuple*
> on a tuple value, it should use jl_sv* instead. Anywhere we are operating
> on tuple types, we should use jl_datatype_t and jl_datatype_t->parameters
> instead.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JuliaLang/julia/commit/246c0784bae64a7ec9d88838c650b040fc205150#commitcomment-10034028>
> .
>


Makes sense to check the csv2json alternatives indeed. Once you have made the merge, I am happy to take care of editing (via another PR) the text to settle #296 and #294 which seem to be, after all, relatively clear.

As for removing ``t1``: I am a bit undecided whether it is good to have them or not; it makes the examples a bit more difficult to read. Maybe. I let you decide on that!

Cheers


К интерфейсу (и его методам) комментарии ещё нужнее, чем к классу, потому что интерфейс чаще используется как тип параметра/поля и т.д.


typo


roger that!


Проперти именуются с заглавной


Этот метод был бы полезен как public


。。。。。。英语不好


可是这样如果重复提供一个选项就跪了……比如`ls -a -a`


Fixed with commit e61a608.


r=jgraham+Manishearth p=1


"php": ">=5.3", this won't be possible yet


Removing the script parameter here broke the .try() checks above...  I think I have a fix but we should confirm


saw approval from jgraham
at https://github.com/Ms2ger/servo/commit/7de5f57467239c42e5be44db96175ebc588abddf


merging Ms2ger/servo/wpt_20150304 = 7de5f574 into auto


Ms2ger/servo/wpt_20150304 = 7de5f574 merged ok, testing candidate = 0091d2b7


1. repeating defaults is a bad idea - the number 16 is already the default. committed a code that which does not repeat it
2. you are missing a "type=int" parameter, without it, you'll get a string, not an integer


Exactly! Instead of having the factory abstraction, I initialize separately the engine and the index. The factory design pattern is used in OO languages like C++ or Java, but in Python classes are also objects. So, I just pass the classes.
@hachreak


That's a pitty. This is a good potential to increase the performance.
However once we start profiling ettercap, I guess it pop up again.


alignRight: true,
^^ this is not a good API name and a boolean is too specific for potential future changes

How about:
alignment: "right"
alignment: "left"
this allows for future enhancements rather than a boolean


If you want Symfony2 to use Fallbacks, you should introduce your own Symfony1 FrontController class which doesn't catch the exceptions thrown by symfony1. Default: `sfFrontWebController`


Why do we have so many comment blocks with an extra line in?
+      /**
+       *
+       * @instance
+       * @type {object}
+       * @default  null
+       */
i.e. the
+       *
it is a waste of space.

Also, isn't @instance the default or does it need to be on each and every method and property definition?


Sorry, I meant to say: If you want Symfony 2 to handle your 404 and 500 errors.


you should probably add another separated commit to add:
(b) 'mediatek,mt8173-pinctrl'
to the list.


What are the following objects mixed in for?
TemporalUtils, FileSizeMixin


Yoda-style comparisons you are using.  Strange, they are.  Consistent, however, it is.  Mind, I do not.


ok matt, yes sure. i checked and saw, that this might be a stupid chain reaction of some random facts. i had problems with updating, than manually updated the files "autoUpdateer.cfc" and "Filewriter.cfc, and the "Zip.cfc". Afterwards the update was working, but i had this error. now i found out, that on the git repo there is a file i was missing: `requirements\mura\dbUpdates\6.2.cfm`, so i copied that file and manually run:
`#$.getBean('configBean').applyDbUpdates()#` this just as an information for similar errors.

sorry matt for the interruption. i think, the problem is more the way i updated, as far as nobody else has the same problem.


Hi Tom,

What is the reason why you have removed the "near silicon" output?

Cheers,
Rasmus


Thank you Rushor.


What is this section needed for, why would the value be NaN? Isn't that true of any numeric value?
+         // Make sure that the inner width is a valid number...
+         // Set the outer width (based on the requested inner width of the input field)...
+         var w = parseInt(this._width, 10);
+         if (isNaN(w))
+         {
+            this._width = "180";
+            this._outerWidth = "250";
+         }
+         else
+         {
+            this._outerWidth = (w + 70) + "";
+         }


I am still not able to modify a module from the front end. I see .jmoddiv in the source that is it. No buttom to modify it.


Thanks for the hard work all the time. I wonder if you have plans for building androideabi 4.9 as well..?


No need for `getKeeps` prefix, support for `keeps*` was added in https://github.com/SpongePowered/SpongeAPI/commit/900554f96d706800e4a25b72e264effc9843e37b#diff-77aa108a686c3e8752f7601fcc17320bR53


파일 업로드 정보를 표시합니다.


Hi @dspinellis – this commit was already merged (and then fixed for the issue you raise in https://github.com/stephencelis/ghi/commit/5c628a1f85d5a65f0641aae42083253a97670946 ).


I used /dev/log just as an easy way to showcase the problem (without the need to add a socket). In practice, of course, different sockets are used. For example, the problem came up in a test inside the rsyslog testbench, which uses a private socket for this test to avoid emitting strang log records to the system log.

I will look into the format option for the local socket.


`BitString` is a lower layer abstraction used in `Encoder`. Now move back to class `Encoder` to implement encode and output to file.


I have changed the test to actually compile a small piece of C code and switched to C 0.07 to get rid of the `inreplace`.


Ouaip j'ai ai également pensé à ça!  Je vais voir déjà si ça rend un truc cool l attaque et je verrai les motifs après


This import should be moved into cli.lua as well.


Hi @andrewssobral ! Can you please send me the source code to shakarim94@gmail.com. Thanks in advance!


@Epix37 On my computer, the width has to be at least 652 to show the HearthStats menu item.


Oh, and I guess I really need to clarify this one: rfc3164 is NOT the same format that is written by syslog(). It is rfc3164 minus the hostname. That's probably why there is a third formatter inside logger.c. If the hostname is present inside the local log socket message, it is (by default) interpreted as TAG, and the real TAG is moved to the MSG part of the message.


1. I'll make the suggested change re: the alignment configuration attribute.
2. The extra line could be removed, ideally it should actually be filled with a comment describing the function or attribute (and indeed we should have had the JSDoc comment in the first place). The line can be removed, I'd rather it was populated with text though. It'll all get removed in production anyway.
3. @instance has to be added for all JSDoc blocks otherwise the HTML output is rendered incorrectly - so yes, it needs to be added
4. We need the mixins so that we don't rely on Alfresco Share specific code that only exists in "alfresco.js" so that this widget can be unit tested (and also included in other clients)
5. In order to get the width behaviour to render correctly we need to calculate the outer width, I can't do that on a String which is why I'm parsing the value. The SearchBox was rendering correctly before because of the widget hierarchy it was placed in - the unit test tests it in isolation so these updates were required to ensure consistent rendering.


On Lakka, compiling without this HAVE_NEON=1 gives an error on launch, about a symbol not found.