1: D290 White spaces around docstring should be trimmed.
1: D400 First line should end with '.', not 's'
24:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email, get_user_info, isGuestUser
28:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.utils.url
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBCOMMENT_ALLOW_COMMENTS, CFG_WEBCOMMENT_ALLOW_REVIEWS, CFG_WEBCOMMENT_AUTHOR_DELETE_COMMENT_OPTION, CFG_WEBCOMMENT_MAX_ATTACHED_FILES, CFG_WEBCOMMENT_MAX_ATTACHMENT_SIZE, CFG_WEBCOMMENT_NB_REPORTS_BEFORE_SEND_EMAIL_TO_ADMIN, CFG_WEBCOMMENT_USE_RICH_TEXT_EDITOR
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.mail
31:1: E402 module level import not at top of file
32:28: E126 continuation line over-indented for hanging indent
47:1: I101 Imported names are in the wrong order. Should be create_html_select, get_html_text_editor
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.html
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.formatter
50:1: E402 module level import not at top of file
51:1: I101 Imported names are in the wrong order. Should be acc_get_role_id, acc_get_user_roles_from_user_info
51:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
51:1: E402 module level import not at top of file
52:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.access.control
52:1: E402 module level import not at top of file
54:1: E302 expected 2 blank lines, found 1
54: D203 Expected 1 blank line *before* class docstring, found 0
54: D400 First line should end with '.', not 'l'
57: D202 No blank lines allowed *after* method docstring, found 1
57: D400 First line should end with '.', not 'd'
57: D205 Blank line missing between one-line summary and description
92:13: F841 local variable 'last_comment_round_name' is assigned to but never used
98:139: E221 multiple spaces before operator
101:85: E231 missing whitespace after ','
101:87: E221 multiple spaces before operator
140:34: E127 continuation line over-indented for visual indent
152:13: E128 continuation line under-indented for visual indent
154:33: E203 whitespace before ':'
159:36: E225 missing whitespace around operator
160:168: E502 the backslash is redundant between brackets
160:57: E225 missing whitespace around operator
161:67: E127 continuation line over-indented for visual indent
164:13: E124 closing bracket does not match visual indentation
178:14: E127 continuation line over-indented for visual indent
180:14: E124 closing bracket does not match visual indentation
184: D401 First line should be imperative: 'Display', not 'Displays'
184: D205 Blank line missing between one-line summary and description
209: D400 First line should end with '.', not 'd'
209: D205 Blank line missing between one-line summary and description
244:26: E201 whitespace after '{'
244:45: E203 whitespace before ':'
244:22: E222 multiple spaces after operator
245:46: E203 whitespace before ':'
246:44: E203 whitespace before ':'
247:44: E203 whitespace before ':'
248:44: E203 whitespace before ':'
248:62: E261 at least two spaces before inline comment
248:63: E262 inline comment should start with '# '
249:44: E203 whitespace before ':'
249:62: E261 at least two spaces before inline comment
249:63: E262 inline comment should start with '# '
250:25: E124 closing bracket does not match visual indentation
260:13: F841 local variable 'last_comment_round_name' is assigned to but never used
294:106: E231 missing whitespace after ':'
294:143: E231 missing whitespace after ':'
295:32: E222 multiple spaces after operator
316:37: E225 missing whitespace around operator
336:13: E122 continuation line missing indentation or outdented
336:14: E201 whitespace after '{'
336:40: E203 whitespace before ':'
337:40: E203 whitespace before ':'
338:40: E203 whitespace before ':'
339:40: E203 whitespace before ':'
340:40: E203 whitespace before ':'
341:40: E203 whitespace before ':'
342:40: E203 whitespace before ':'
343:40: E203 whitespace before ':'
344:41: E203 whitespace before ':'
345:60: E225 missing whitespace around operator
346:40: E203 whitespace before ':'
347:13: E124 closing bracket does not match visual indentation
359:28: E128 continuation line under-indented for visual indent
360:28: E128 continuation line under-indented for visual indent
363: D400 First line should end with '.', not 'n'
363: D205 Blank line missing between one-line summary and description
402:35: E128 continuation line under-indented for visual indent
403:35: E126 continuation line over-indented for hanging indent
408:81: E225 missing whitespace around operator
408:100: E225 missing whitespace around operator
410:83: E225 missing whitespace around operator
433:105: E225 missing whitespace around operator
435:106: E225 missing whitespace around operator
441:110: E225 missing whitespace around operator
452:111: E271 multiple spaces after keyword
461:37: E126 continuation line over-indented for hanging indent
488:17: E127 continuation line over-indented for visual indent
488:33: E203 whitespace before ':'
489:33: E203 whitespace before ':'
490:33: E203 whitespace before ':'
500: D400 First line should end with '.', not 'n'
500: D205 Blank line missing between one-line summary and description
533:107: E231 missing whitespace after ':'
534:9: E266 too many leading '#' for block comment
568:94: E225 missing whitespace around operator
574:99: E225 missing whitespace around operator
589:31: E203 whitespace before ':'
590:16: E128 continuation line under-indented for visual indent
591:16: E128 continuation line under-indented for visual indent
591:31: E203 whitespace before ':'
592:16: E128 continuation line under-indented for visual indent
592:31: E203 whitespace before ':'
593:16: E128 continuation line under-indented for visual indent
594:16: E128 continuation line under-indented for visual indent
594:31: E203 whitespace before ':'
595:16: E128 continuation line under-indented for visual indent
595:31: E203 whitespace before ':'
596:16: E128 continuation line under-indented for visual indent
596:31: E203 whitespace before ':'
597:16: E124 closing bracket does not match visual indentation
600: D400 First line should end with '.', not 's'
600: D205 Blank line missing between one-line summary and description
609:55: E231 missing whitespace after ','
692:13: F841 local variable 'c_round_name' is assigned to but never used
693:13: F841 local variable 'c_restriction' is assigned to but never used
702:26: E201 whitespace after '{'
702:45: E203 whitespace before ':'
702:22: E222 multiple spaces after operator
703:46: E203 whitespace before ':'
704:44: E203 whitespace before ':'
705:44: E203 whitespace before ':'
706:44: E203 whitespace before ':'
707:44: E203 whitespace before ':'
708:44: E203 whitespace before ':'
709:44: E203 whitespace before ':'
710:44: E203 whitespace before ':'
711:44: E203 whitespace before ':'
712:25: E124 closing bracket does not match visual indentation
719:22: E201 whitespace after '{'
719:37: E203 whitespace before ':'
719:19: E222 multiple spaces after operator
720:42: E203 whitespace before ':'
721:36: E203 whitespace before ':'
722:36: E203 whitespace before ':'
724:36: E203 whitespace before ':'
725:36: E203 whitespace before ':'
726:36: E203 whitespace before ':'
727:36: E203 whitespace before ':'
731:9: E266 too many leading '#' for block comment
736:13: F841 local variable 'last_comment_round_name' is assigned to but never used
747:20: E127 continuation line over-indented for visual indent
754:35: E127 continuation line over-indented for visual indent
754:73: E221 multiple spaces before operator
763:132: E202 whitespace before ')'
764:33: E127 continuation line over-indented for visual indent
764:71: E221 multiple spaces before operator
765:140: E225 missing whitespace around operator
838:76: E261 at least two spaces before inline comment
846:275: E231 missing whitespace after ':'
847:163: E231 missing whitespace after ':'
880:38: E203 whitespace before ':'
880:62: E231 missing whitespace after ':'
882:38: E203 whitespace before ':'
882:61: E231 missing whitespace after ':'
883:38: E203 whitespace before ':'
883:63: E231 missing whitespace after ':'
885:35: E203 whitespace before ':'
892:9: E266 too many leading '#' for block comment
917:9: E266 too many leading '#' for block comment
1085:9: E122 continuation line missing indentation or outdented
1086:47: E203 whitespace before ','
1088:43: E225 missing whitespace around operator
1104: D401 First line should be imperative: 'print', not 'prints'
1104: D400 First line should end with '.', not 'm'
1112: D202 No blank lines allowed *after* method docstring, found 1
1112: D400 First line should end with '.', not 'n'
1112: D205 Blank line missing between one-line summary and description
1124:15: E221 multiple spaces before operator
1157: D400 First line should end with '.', not 'n'
1157: D205 Blank line missing between one-line summary and description
1175:15: E221 multiple spaces before operator
1177:9: E122 continuation line missing indentation or outdented
1178:9: E128 continuation line under-indented for visual indent
1179:9: E128 continuation line under-indented for visual indent
1196: D400 First line should end with '.', not 's'
1196: D205 Blank line missing between one-line summary and description
1216:22: E201 whitespace after '{'
1216:40: E203 whitespace before ':'
1217:40: E203 whitespace before ':'
1217:65: E202 whitespace before '}'
1222: D400 First line should end with '.', not 'r'
1222: D205 Blank line missing between one-line summary and description
1229:9: F841 local variable '_' is assigned to but never used
1238: D400 First line should end with '.', not 's'
1238: D205 Blank line missing between one-line summary and description
1257:22: E201 whitespace after '{'
1257:37: E203 whitespace before ':'
1257:19: E222 multiple spaces after operator
1258:42: E203 whitespace before ':'
1259:36: E203 whitespace before ':'
1260:36: E203 whitespace before ':'
1261:36: E203 whitespace before ':'
1262:36: E203 whitespace before ':'
1281:20: E222 multiple spaces after operator
1306:13: E122 continuation line missing indentation or outdented
1307:121: E502 the backslash is redundant between brackets
1308:28: E127 continuation line over-indented for visual indent
1309:100: E502 the backslash is redundant between brackets
1310:31: E127 continuation line over-indented for visual indent
1311:238: E271 multiple spaces after keyword
1320:50: E251 unexpected spaces around keyword / parameter equals
1320:52: E251 unexpected spaces around keyword / parameter equals
1355: D400 First line should end with '.', not 's'
1355: D205 Blank line missing between one-line summary and description
1373:22: E201 whitespace after '{'
1373:37: E203 whitespace before ':'
1373:19: E222 multiple spaces after operator
1374:42: E203 whitespace before ':'
1375:36: E203 whitespace before ':'
1376:36: E203 whitespace before ':'
1377:36: E203 whitespace before ':'
1378:36: E203 whitespace before ':'
1388:13: E128 continuation line under-indented for visual indent
1427:1: E128 continuation line under-indented for visual indent
1428:50: E251 unexpected spaces around keyword / parameter equals
1428:52: E251 unexpected spaces around keyword / parameter equals
1469:35: E203 whitespace before ':'
1469:42: E225 missing whitespace around operator
1470:35: E203 whitespace before ':'
1470:41: E225 missing whitespace around operator
1485: D400 First line should end with '.', not 'd'
1485: D205 Blank line missing between one-line summary and description
1492:22: E201 whitespace after '{'
1492:37: E203 whitespace before ':'
1492:19: E222 multiple spaces after operator
1493:42: E203 whitespace before ':'
1494:36: E203 whitespace before ':'
1495:36: E203 whitespace before ':'
1496:36: E203 whitespace before ':'
1497:36: E203 whitespace before ':'
1501:51: E221 multiple spaces before operator
1512:101: E222 multiple spaces after operator
1516: D401 First line should be imperative: 'Create', not 'Creates'
1516: D290 White spaces around docstring should be trimmed.
1516: D205 Blank line missing between one-line summary and description
1539:15: E221 multiple spaces before operator
1579: D400 First line should end with '.', not 'e'
1579: D200 One-line docstring should not occupy 3 lines
1605:19: E225 missing whitespace around operator
1609:36: E203 whitespace before ':'
1612:35: E203 whitespace before ':'
1613:35: E203 whitespace before ':'
1618:39: E225 missing whitespace around operator
1620: D400 First line should end with '.', not 'e'
1635:18: E225 missing whitespace around operator
1666: D400 First line should end with '.', not ')'
1666: D205 Blank line missing between one-line summary and description
1690:27: E127 continuation line over-indented for visual indent
1693:27: E127 continuation line over-indented for visual indent
1716:13: E201 whitespace after '{'
1716:25: E203 whitespace before ':'
1717:25: E203 whitespace before ':'
1718:25: E203 whitespace before ':'
1719:25: E203 whitespace before ':'
1721:26: E203 whitespace before ':'
1722:25: E203 whitespace before ':'
1723:25: E203 whitespace before ':'
1724:25: E203 whitespace before ':'
1754: D401 First line should be imperative: 'output', not 'outputs'
1754: D290 White spaces around docstring should be trimmed.
1754: D400 First line should end with '.', not 'd'
1758: D401 First line should be imperative: 'prepare', not 'prepares'
1758: D290 White spaces around docstring should be trimmed.
1758: D400 First line should end with '.', not 'r'
1773: D401 First line should be imperative: 'output', not 'outputs'
1773: D290 White spaces around docstring should be trimmed.
1773: D400 First line should end with '.', not 'w'
1788:34: E203 whitespace before ':'
1796: D400 First line should end with '.', not 't'
1796: D205 Blank line missing between one-line summary and description
1803:9: F841 local variable '_' is assigned to but never used
1842:17: E128 continuation line under-indented for visual indent
1842:50: E225 missing whitespace around operator
1842:69: E225 missing whitespace around operator
1843:17: E128 continuation line under-indented for visual indent
1843:36: E203 whitespace before ','
1843:23: E231 missing whitespace after ':'
1844:17: E128 continuation line under-indented for visual indent
1844:49: E203 whitespace before ','
1845:17: E128 continuation line under-indented for visual indent
1846:17: E128 continuation line under-indented for visual indent
1852:17: E128 continuation line under-indented for visual indent
1852:50: E225 missing whitespace around operator
1852:69: E225 missing whitespace around operator
1853:17: E128 continuation line under-indented for visual indent
1853:36: E203 whitespace before ','
1853:23: E231 missing whitespace after ':'
1854:17: E128 continuation line under-indented for visual indent
1855:17: E128 continuation line under-indented for visual indent
1860: D400 First line should end with '.', not 't'
1860: D205 Blank line missing between one-line summary and description
1866:9: F841 local variable '_' is assigned to but never used
1900:49: E225 missing whitespace around operator
1900:68: E225 missing whitespace around operator
1901:54: E272 multiple spaces before keyword
1903:49: E225 missing whitespace around operator
1903:68: E225 missing whitespace around operator
1904:54: E272 multiple spaces before keyword
1910:13: E128 continuation line under-indented for visual indent
1910:39: E203 whitespace before ','
1911:13: E128 continuation line under-indented for visual indent
1912:13: E128 continuation line under-indented for visual indent
1913:13: E128 continuation line under-indented for visual indent
1914:13: E128 continuation line under-indented for visual indent
1915:13: E128 continuation line under-indented for visual indent
1920: D400 First line should end with '.', not 't'
1920: D205 Blank line missing between one-line summary and description
1970:73: E261 at least two spaces before inline comment
1970:73: E262 inline comment should start with '# '
1972:81: E261 at least two spaces before inline comment
1972:81: E262 inline comment should start with '# '
1973:81: E261 at least two spaces before inline comment
1973:81: E262 inline comment should start with '# '
1974:81: E261 at least two spaces before inline comment
1974:81: E262 inline comment should start with '# '
1975:81: E261 at least two spaces before inline comment
1975:81: E262 inline comment should start with '# '
1976:81: E261 at least two spaces before inline comment
1976:81: E262 inline comment should start with '# '
1978:81: E261 at least two spaces before inline comment
1978:81: E262 inline comment should start with '# '
1979:81: E261 at least two spaces before inline comment
1979:81: E262 inline comment should start with '# '
1980:81: E261 at least two spaces before inline comment
1980:81: E262 inline comment should start with '# '
1981:81: E261 at least two spaces before inline comment
1981:81: E262 inline comment should start with '# '
1984:76: E261 at least two spaces before inline comment
1984:76: E262 inline comment should start with '# '
1986:84: E261 at least two spaces before inline comment
1986:84: E262 inline comment should start with '# '
1987:84: E261 at least two spaces before inline comment
1987:84: E262 inline comment should start with '# '
1988:84: E261 at least two spaces before inline comment
1988:84: E262 inline comment should start with '# '
1989:84: E261 at least two spaces before inline comment
1989:84: E262 inline comment should start with '# '
1990:84: E261 at least two spaces before inline comment
1990:84: E262 inline comment should start with '# '
1992:84: E262 inline comment should start with '# '
1993:84: E262 inline comment should start with '# '
1994:84: E262 inline comment should start with '# '
1995:84: E262 inline comment should start with '# '
1996:84: E262 inline comment should start with '# '
1998:84: E261 at least two spaces before inline comment
2001:65: E261 at least two spaces before inline comment
2001:66: E262 inline comment should start with '# '
2002:65: E261 at least two spaces before inline comment
2002:66: E262 inline comment should start with '# '
2003:66: E261 at least two spaces before inline comment
2003:66: E262 inline comment should start with '# '
2010:75: E261 at least two spaces before inline comment
2011:75: E261 at least two spaces before inline comment
2012:75: E261 at least two spaces before inline comment
2013:70: E261 at least two spaces before inline comment
2028:15: E128 continuation line under-indented for visual indent
2029:15: E128 continuation line under-indented for visual indent
2030:15: E128 continuation line under-indented for visual indent
2031:23: E211 whitespace before '('
2044:13: E122 continuation line missing indentation or outdented
2045:13: E122 continuation line missing indentation or outdented
2046:13: E122 continuation line missing indentation or outdented
2050:13: E122 continuation line missing indentation or outdented
2051:13: E122 continuation line missing indentation or outdented
2052:13: E122 continuation line missing indentation or outdented
2072:36: E225 missing whitespace around operator
2074:36: E225 missing whitespace around operator
2101: D400 First line should end with '.', not ','
2101: D205 Blank line missing between one-line summary and description
2113:37: E225 missing whitespace around operator
2113:86: E225 missing whitespace around operator
2125: D400 First line should end with '.', not ','
2125: D205 Blank line missing between one-line summary and description
2137:37: E225 missing whitespace around operator
2137:86: E225 missing whitespace around operator
2151:5: E303 too many blank lines (3)
2151: D400 First line should end with '.', not ','
2151: D205 Blank line missing between one-line summary and description
2163:37: E225 missing whitespace around operator
2163:86: E225 missing whitespace around operator
2175: D202 No blank lines allowed *after* method docstring, found 1
2175: D400 First line should end with '.', not ')'
2185:21: E126 continuation line over-indented for hanging indent
2188:26: E225 missing whitespace around operator
2224:9: E122 continuation line missing indentation or outdented
2225:9: E122 continuation line missing indentation or outdented
2226:9: E122 continuation line missing indentation or outdented
2227:9: E122 continuation line missing indentation or outdented
2228:9: E122 continuation line missing indentation or outdented
2229:9: E122 continuation line missing indentation or outdented
2230:9: E122 continuation line missing indentation or outdented
2231:9: E124 closing bracket does not match visual indentation
2234: D401 First line should be imperative: 'Print', not 'Prints'
2234: D400 First line should end with '.', not 'w'
2234: D205 Blank line missing between one-line summary and description
2256:15: E127 continuation line over-indented for visual indent
2256:109: E502 the backslash is redundant between brackets
2258:16: E127 continuation line over-indented for visual indent
2260:48: E225 missing whitespace around operator
2260:67: E225 missing whitespace around operator
2264: D401 First line should be imperative: 'Print', not 'Prints'
2264: D400 First line should end with '.', not 'w'
2264: D205 Blank line missing between one-line summary and description
2286:72: E221 multiple spaces before operator
2287:16: E127 continuation line over-indented for visual indent
2287:82: E502 the backslash is redundant between brackets
2287:44: E225 missing whitespace around operator
2287:63: E225 missing whitespace around operator
2291:81: E221 multiple spaces before operator
2292:20: E126 continuation line over-indented for hanging indent
2292:86: E502 the backslash is redundant between brackets
2292:48: E225 missing whitespace around operator
2292:67: E225 missing whitespace around operator
2296:79: E221 multiple spaces before operator
2297:20: E126 continuation line over-indented for hanging indent
2297:86: E502 the backslash is redundant between brackets
2297:48: E225 missing whitespace around operator
2297:67: E225 missing whitespace around operator
2301:16: E127 continuation line over-indented for visual indent
2305: D401 First line should be imperative: 'Print', not 'Prints'
2305: D400 First line should end with '.', not 'e'
2305: D205 Blank line missing between one-line summary and description
2332:15: E271 multiple spaces after keyword
2334: D202 No blank lines allowed *after* method docstring, found 1
2334: D400 First line should end with '.', not 'e'
2334: D205 Blank line missing between one-line summary and description
2372: D400 First line should end with '.', not 'r'
2414:78: E251 unexpected spaces around keyword / parameter equals
2414:80: E251 unexpected spaces around keyword / parameter equals
2415:78: E251 unexpected spaces around keyword / parameter equals
2415:80: E251 unexpected spaces around keyword / parameter equals
2416:79: E251 unexpected spaces around keyword / parameter equals
2416:81: E251 unexpected spaces around keyword / parameter equals
2417:55: E231 missing whitespace after ','
2417:78: E251 unexpected spaces around keyword / parameter equals
2417:80: E251 unexpected spaces around keyword / parameter equals
2425:22: E222 multiple spaces after operator
2460:9: E303 too many blank lines (3)
2523:34: E126 continuation line over-indented for hanging indent
2526:102: E502 the backslash is redundant between brackets
2526:77: E225 missing whitespace around operator
2526:96: E225 missing whitespace around operator
2531:98: E502 the backslash is redundant between brackets
2531:73: E225 missing whitespace around operator
2531:92: E225 missing whitespace around operator
2555:25: E127 continuation line over-indented for visual indent
2555:37: E203 whitespace before ':'
2556:37: E203 whitespace before ':'
2557:37: E203 whitespace before ':'
2558:37: E203 whitespace before ':'
2559:37: E203 whitespace before ':'
2560:37: E203 whitespace before ':'
2565:24: E261 at least two spaces before inline comment
2570:16: E127 continuation line over-indented for visual indent
2597:52: E126 continuation line over-indented for hanging indent


3: L102 copyright year is outdated, expected 2015 but got 2014


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
30:1: I101 Imported names are in the wrong order. Should be DatabaseError, run_sql
32:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.legacy.dbquery
33:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.bibsched.bibtask
34:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_CHARS_ALPHANUMERIC_SEPARATORS, CFG_BIBINDEX_CHARS_PUNCTUATION
34:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibrecord
35:6: E126 continuation line over-indented for hanging indent
55: D200 One-line docstring should not occupy 3 lines
65:9: E128 continuation line under-indented for visual indent
68:1: E302 expected 2 blank lines, found 1
68: D401 First line should be imperative: 'Return', not 'Returns'
68: D209 Put multi-line docstring closing quotes on separate line
68: D205 Blank line missing between one-line summary and description
68: D208 Docstring is over-indented
84: D401 First line should be imperative: 'Return', not 'Returns'
84: D209 Put multi-line docstring closing quotes on separate line
84: D400 First line should end with '.', not 'e'
84: D205 Blank line missing between one-line summary and description
84: D208 Docstring is over-indented
99: D401 First line should be imperative: 'Return', not 'Returns'
99: D400 First line should end with '.', not 'e'
99: D205 Blank line missing between one-line summary and description
99: D208 Docstring is over-indented
107:5: B901 blind except: statement
114: D401 First line should be imperative: 'Get', not 'Gets'
114: D290 White spaces around docstring should be trimmed.
114: D209 Put multi-line docstring closing quotes on separate line
114: D400 First line should end with '.', not 'd'
114: D205 Blank line missing between one-line summary and description
114: D208 Docstring is over-indented
120:5: B901 blind except: statement
127: D401 First line should be imperative: 'Get', not 'Gets'
127: D290 White spaces around docstring should be trimmed.
127: D209 Put multi-line docstring closing quotes on separate line
127: D400 First line should end with '.', not 'd'
127: D205 Blank line missing between one-line summary and description
127: D208 Docstring is over-indented
133:5: B901 blind except: statement
140: D205 Blank line missing between one-line summary and description
170: D400 First line should end with '.', not 's'
170: D205 Blank line missing between one-line summary and description
170: D208 Docstring is over-indented
181:11: E271 multiple spaces after keyword
187:1: F401 'get_idx_indexer' imported but unused
187:1: E402 module level import not at top of file
190: D401 First line should be imperative: 'Return', not 'Returns'
190: D209 Put multi-line docstring closing quotes on separate line
190: D205 Blank line missing between one-line summary and description
190: D208 Docstring is over-indented
212: D401 First line should be imperative: 'Return', not 'Returns'
212: D290 White spaces around docstring should be trimmed.
221: D401 First line should be imperative: 'Return', not 'Returns'
221: D209 Put multi-line docstring closing quotes on separate line
221: D400 First line should end with '.', not 'h'
221: D205 Blank line missing between one-line summary and description
221: D208 Docstring is over-indented
232: D401 First line should be imperative: 'Check', not 'Checks'
232: D400 First line should end with '.', not 'l'
241:1: E302 expected 2 blank lines, found 1
241: D400 First line should end with '.', not 's'
241: D205 Blank line missing between one-line summary and description
241: D208 Docstring is over-indented
255:1: E302 expected 2 blank lines, found 1
255: D401 First line should be imperative: 'Return', not 'Returns'
255: D205 Blank line missing between one-line summary and description
255: D208 Docstring is over-indented
268: D401 First line should be imperative: 'Return', not 'Returns'
268: D209 Put multi-line docstring closing quotes on separate line
268: D205 Blank line missing between one-line summary and description
268: D208 Docstring is over-indented
281: D401 First line should be imperative: 'Return', not 'Returns'
281: D209 Put multi-line docstring closing quotes on separate line
281: D205 Blank line missing between one-line summary and description
281: D208 Docstring is over-indented
291: D401 First line should be imperative: 'Return', not 'Returns'
291: D400 First line should end with '.', not 's'
291: D205 Blank line missing between one-line summary and description
291: D208 Docstring is over-indented
299:5: F841 local variable 'out' is assigned to but never used
321: D401 First line should be imperative: 'Return', not 'Returns'
321: D209 Put multi-line docstring closing quotes on separate line
321: D400 First line should end with '.', not 'g'
321: D205 Blank line missing between one-line summary and description
321: D208 Docstring is over-indented
326:26: E261 at least two spaces before inline comment
326:27: E262 inline comment should start with '# '
327:26: E261 at least two spaces before inline comment
327:27: E262 inline comment should start with '# '
342:25: E261 at least two spaces before inline comment
342:26: E262 inline comment should start with '# '
362: D401 First line should be imperative: 'Return', not 'Returns'
362: D209 Put multi-line docstring closing quotes on separate line
362: D400 First line should end with '.', not 'g'
362: D205 Blank line missing between one-line summary and description
362: D208 Docstring is over-indented
399: D401 First line should be imperative: 'Return', not 'Returns'
399: D205 Blank line missing between one-line summary and description
399: D208 Docstring is over-indented
437: D401 First line should be imperative: 'Return', not 'Returns'
437: D400 First line should end with '.', not ':'
437: D205 Blank line missing between one-line summary and description
437: D208 Docstring is over-indented
442:10: E225 missing whitespace around operator
450: D401 First line should be imperative: 'Remove', not 'Removes'
450: D205 Blank line missing between one-line summary and description
450: D208 Docstring is over-indented
463: D208 Docstring is over-indented
463: D200 One-line docstring should not occupy 3 lines
477: D401 First line should be imperative: 'Create', not 'Creates'
477: D400 First line should end with '.', not 'd'
477: D205 Blank line missing between one-line summary and description
477: D208 Docstring is over-indented
487: D101 Docstring missing
491: D401 First line should be imperative: 'Return', not 'Returns'
491: D300 Expected """-quotes, got '-quotes
501: D401 First line should be imperative: 'Return', not 'Returns'
501: D400 First line should end with '.', not 'y'
501: D205 Blank line missing between one-line summary and description
501: D208 Docstring is over-indented
512:47: E202 whitespace before ')'
516: D401 First line should be imperative: 'Check', not 'Checks'
516: D400 First line should end with '.', not 't'
519:25: E272 multiple spaces before keyword
526: D401 First line should be imperative: 'Check', not 'Checks'
526: D209 Put multi-line docstring closing quotes on separate line
526: D400 First line should end with '.', not ';'
526: D205 Blank line missing between one-line summary and description
526: D208 Docstring is over-indented
532: D401 First line should be imperative: 'Return', not 'Returns'
532: D209 Put multi-line docstring closing quotes on separate line
532: D400 First line should end with '.', not ';'
532: D205 Blank line missing between one-line summary and description
532: D208 Docstring is over-indented
541: D401 First line should be imperative: 'Find', not 'Finds'
541: D400 First line should end with '.', not 'n'
541: D205 Blank line missing between one-line summary and description
541: D208 Docstring is over-indented


1: D100 Docstring missing
21:1: I201 Missing newline before sections or imports.
23:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibindex.engine_stopwords
23:1: F401 'CFG_ETCDIR' imported but unused
24:6: E126 continuation line over-indented for hanging indent
68:1: E302 expected 2 blank lines, found 1
68: D400 First line should end with '.', not 'g'
68: D205 Blank line missing between one-line summary and description
81:1: E302 expected 2 blank lines, found 0
81: D103 Docstring missing
92: D401 First line should be imperative: 'Return', not 'Returns'
92: D205 Blank line missing between one-line summary and description
92: D208 Docstring is over-indented
106: D401 First line should be imperative: 'Return', not 'Returns'
106: D205 Blank line missing between one-line summary and description
106: D208 Docstring is over-indented
120:1: E302 expected 2 blank lines, found 1
120: D401 First line should be imperative: 'Return', not 'Returns'
120: D208 Docstring is over-indented
130:1: E302 expected 2 blank lines, found 1
130: D400 First line should end with '.', not 'e'
130: D205 Blank line missing between one-line summary and description
159:1: E302 expected 2 blank lines, found 1
159: D400 First line should end with '.', not 'e'
159: D205 Blank line missing between one-line summary and description


25:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
43:152: E203 whitespace before ':'
50:160: E203 whitespace before ':'
57:160: E203 whitespace before ':'
65:107: E203 whitespace before ':'
73:96: E203 whitespace before ':'
81:96: E203 whitespace before ':'
89:101: E203 whitespace before ':'
97:101: E203 whitespace before ':'
105:116: E203 whitespace before ':'
113:116: E203 whitespace before ':'
121:107: E203 whitespace before ':'
129:114: E203 whitespace before ':'
137:131: E203 whitespace before ':'
155:18: E128 continuation line under-indented for visual indent
155:83: E203 whitespace before ':'
166:18: E128 continuation line under-indented for visual indent
166:88: E203 whitespace before ':'
177:18: E128 continuation line under-indented for visual indent
177:88: E203 whitespace before ':'
188:18: E128 continuation line under-indented for visual indent
188:101: E203 whitespace before ':'
203:18: E128 continuation line under-indented for visual indent
203:101: E203 whitespace before ':'
216:18: E128 continuation line under-indented for visual indent
216:108: E203 whitespace before ':'
229:18: E128 continuation line under-indented for visual indent
229:126: E203 whitespace before ':'
232:13: E128 continuation line under-indented for visual indent
233:13: E128 continuation line under-indented for visual indent
234:13: E128 continuation line under-indented for visual indent
235:13: E128 continuation line under-indented for visual indent
236:13: E128 continuation line under-indented for visual indent
237:13: E128 continuation line under-indented for visual indent
238:13: E128 continuation line under-indented for visual indent
239:13: E128 continuation line under-indented for visual indent
240:13: E128 continuation line under-indented for visual indent
241:13: E128 continuation line under-indented for visual indent
242:13: E128 continuation line under-indented for visual indent
243:13: E128 continuation line under-indented for visual indent
244:13: E128 continuation line under-indented for visual indent
245:13: E128 continuation line under-indented for visual indent
246:13: E128 continuation line under-indented for visual indent
247:13: E128 continuation line under-indented for visual indent
248:13: E128 continuation line under-indented for visual indent
249:13: E128 continuation line under-indented for visual indent
250:13: E128 continuation line under-indented for visual indent
251:13: E128 continuation line under-indented for visual indent
252:13: E128 continuation line under-indented for visual indent
253:13: E128 continuation line under-indented for visual indent
254:13: E128 continuation line under-indented for visual indent
263:18: E128 continuation line under-indented for visual indent
263:97: E203 whitespace before ':'
283:1: E303 too many blank lines (3)
320:1: E303 too many blank lines (3)
325:5: E303 too many blank lines (2)
334:42: E231 missing whitespace after ','
334:47: E231 missing whitespace after ','
334:53: E231 missing whitespace after ','
340:39: E231 missing whitespace after ','
340:45: E231 missing whitespace after ','
340:51: E231 missing whitespace after ','
340:57: E231 missing whitespace after ','
340:63: E231 missing whitespace after ','
346:39: E231 missing whitespace after ','
346:45: E231 missing whitespace after ','
346:51: E231 missing whitespace after ','
346:57: E231 missing whitespace after ','
359:90: E231 missing whitespace after ','
359:96: E231 missing whitespace after ','


1: D400 First line should end with '.', not 'n'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D400 First line should end with '.', not 'n'
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
40:41: E251 unexpected spaces around keyword / parameter equals
40:43: E251 unexpected spaces around keyword / parameter equals
40:66: E251 unexpected spaces around keyword / parameter equals
40:68: E251 unexpected spaces around keyword / parameter equals
40:94: E251 unexpected spaces around keyword / parameter equals
40:96: E251 unexpected spaces around keyword / parameter equals
40:123: E251 unexpected spaces around keyword / parameter equals
40:125: E251 unexpected spaces around keyword / parameter equals
40: D102 Docstring missing
45:5: E303 too many blank lines (2)
45: D401 First line should be imperative: 'Use', not 'Uses'
45: D209 Put multi-line docstring closing quotes on separate line
45: D400 First line should end with '.', not 's'
45: D205 Blank line missing between one-line summary and description
45: D208 Docstring is over-indented
48:55: E231 missing whitespace after ','
50: D205 Blank line missing between one-line summary and description
58: D102 Docstring missing
61: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
32:1: E303 too many blank lines (3)
32: D203 Expected 1 blank line *before* class docstring, found 0
41:41: E251 unexpected spaces around keyword / parameter equals
41:43: E251 unexpected spaces around keyword / parameter equals
41:66: E251 unexpected spaces around keyword / parameter equals
41:68: E251 unexpected spaces around keyword / parameter equals
41:94: E251 unexpected spaces around keyword / parameter equals
41:96: E251 unexpected spaces around keyword / parameter equals
41:123: E251 unexpected spaces around keyword / parameter equals
41:125: E251 unexpected spaces around keyword / parameter equals
41: D102 Docstring missing
43:49: E127 continuation line over-indented for visual indent
44:49: E127 continuation line over-indented for visual indent
45:49: E127 continuation line over-indented for visual indent
71:35: E203 whitespace before ':'
72:35: E203 whitespace before ':'
73:35: E203 whitespace before ':'
74:35: E203 whitespace before ':'
75:35: E203 whitespace before ':'
89:25: E116 unexpected indentation (comment)
100:21: E116 unexpected indentation (comment)
106: D202 No blank lines allowed *after* method docstring, found 1
128:61: E251 unexpected spaces around keyword / parameter equals
128:63: E251 unexpected spaces around keyword / parameter equals
142:22: E711 comparison to None should be 'if cond is not None:'
159:9: F841 local variable 'raw' is assigned to but never used
180: D202 No blank lines allowed *after* method docstring, found 1
196: D401 First line should be imperative: 'List', not 'Lists'
196: D400 First line should end with '.', not ']'
198:21: E711 comparison to None should be 'if cond is None:'
202: D401 First line should be imperative: 'List', not 'Lists'
202: D400 First line should end with '.', not 'l'
212: D401 First line should be imperative: 'Bring', not 'Brings'
212: D202 No blank lines allowed *after* function docstring, found 1
212: D400 First line should end with '.', not 's'
229: D401 First line should be imperative: 'Run', not 'Runs'
229: D400 First line should end with '.', not 'l'
232:18: E272 multiple spaces before keyword
238: D401 First line should be imperative: 'Find', not 'Finds'
238: D400 First line should end with '.', not "'"
261:5: E303 too many blank lines (2)
288:5: E303 too many blank lines (2)
288: D205 Blank line missing between one-line summary and description
288: D208 Docstring is over-indented
297:5: E303 too many blank lines (2)
297: D400 First line should end with '.', not 'r'
302:5: E303 too many blank lines (2)
302: D290 White spaces around docstring should be trimmed.
326:5: E303 too many blank lines (2)
326: D205 Blank line missing between one-line summary and description
326: D208 Docstring is over-indented
336:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
32: D103 Docstring missing
41: D103 Docstring missing
50: D103 Docstring missing
59: D103 Docstring missing
63: D209 Put multi-line docstring closing quotes on separate line
63: D203 Expected 1 blank line *before* class docstring, found 0
63: D302 Use u""" for docstrings with Unicode
63: D205 Blank line missing between one-line summary and description
63: D208 Docstring is over-indented
69:41: E251 unexpected spaces around keyword / parameter equals
69:43: E251 unexpected spaces around keyword / parameter equals
69:66: E251 unexpected spaces around keyword / parameter equals
69:68: E251 unexpected spaces around keyword / parameter equals
69:94: E251 unexpected spaces around keyword / parameter equals
69:96: E251 unexpected spaces around keyword / parameter equals
69:123: E251 unexpected spaces around keyword / parameter equals
69:125: E251 unexpected spaces around keyword / parameter equals
69: D400 First line should end with '.', not 'n'
72:49: E127 continuation line over-indented for visual indent
73:49: E127 continuation line over-indented for visual indent
74:49: E127 continuation line over-indented for visual indent
77:5: E303 too many blank lines (2)
77: D400 First line should end with '.', not 'r'
82:5: E303 too many blank lines (2)
82: D401 First line should be imperative: 'Split', not 'Splits'
82: D400 First line should end with '.', not 's'
82: D205 Blank line missing between one-line summary and description
104:22: E201 whitespace after '['
129:5: E303 too many blank lines (2)
129: D102 Docstring missing
132: D102 Docstring missing


1: D100 Docstring missing
22: D203 Expected 1 blank line *before* class docstring, found 0
22: D204 Expected 1 blank line *after* class docstring, found 2
22: D400 First line should end with '.', not ')'
22: D205 Blank line missing between one-line summary and description
22: D208 Docstring is over-indented
30:5: E303 too many blank lines (2)
30: D102 Docstring missing
34:5: E303 too many blank lines (2)
34: D401 First line should be imperative: 'Return', not 'Returns'
34: D400 First line should end with '.', not 'n'
38: D205 Blank line missing between one-line summary and description
45:15: F821 undefined name 'get_record'
49: D401 First line should be imperative: 'Return', not 'Returns'
49: D200 One-line docstring should not occupy 3 lines


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
25:6: E126 continuation line over-indented for hanging indent
27:1: I101 Imported names are in the wrong order. Should be strip_accents, wash_for_utf8
28:1: I101 Imported names are in the wrong order. Should be apply_stemming, length_check, lower_index_term, remove_latex_markup, remove_stopwords
28:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_washer should be before from invenio.utils.text
29:6: E126 continuation line over-indented for hanging indent
31:1: I101 Imported names are in the wrong order. Should be latex_formula_re, re_arxiv, re_block_punctuation_begin, re_block_punctuation_end, re_punctuation, re_separators
31:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.legacy.bibindex.engine_washer
32:6: E126 continuation line over-indented for hanging indent
41:1: E303 too many blank lines (3)
41: D203 Expected 1 blank line *before* class docstring, found 0
41: D205 Blank line missing between one-line summary and description
41: D208 Docstring is over-indented
47:41: E251 unexpected spaces around keyword / parameter equals
47:43: E251 unexpected spaces around keyword / parameter equals
47:66: E251 unexpected spaces around keyword / parameter equals
47:68: E251 unexpected spaces around keyword / parameter equals
47:94: E251 unexpected spaces around keyword / parameter equals
47:96: E251 unexpected spaces around keyword / parameter equals
47:123: E251 unexpected spaces around keyword / parameter equals
47:125: E251 unexpected spaces around keyword / parameter equals
47: D400 First line should end with '.', not 'n'
55:5: E303 too many blank lines (2)
55: D401 First line should be imperative: 'Pick', not 'Picks'
55: D400 First line should end with '.', not ')'
66:5: E303 too many blank lines (3)
66: D202 No blank lines allowed *after* method docstring, found 1
66: D400 First line should end with '.', not 's'
66: D205 Blank line missing between one-line summary and description
66: D208 Docstring is over-indented
117:5: E303 too many blank lines (2)
117: D202 No blank lines allowed *after* method docstring, found 1
117: D400 First line should end with '.', not 's'
117: D205 Blank line missing between one-line summary and description
117: D208 Docstring is over-indented
159:5: E303 too many blank lines (2)
159: D400 First line should end with '.', not 's'
159: D205 Blank line missing between one-line summary and description
159: D208 Docstring is over-indented
167: D401 First line should be imperative: 'Pick', not 'Picks'
167: D400 First line should end with '.', not 'n'
167: D205 Blank line missing between one-line summary and description


1: D208 Docstring is over-indented
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
39:41: E251 unexpected spaces around keyword / parameter equals
39:43: E251 unexpected spaces around keyword / parameter equals
39:66: E251 unexpected spaces around keyword / parameter equals
39:68: E251 unexpected spaces around keyword / parameter equals
39:94: E251 unexpected spaces around keyword / parameter equals
39:96: E251 unexpected spaces around keyword / parameter equals
39:123: E251 unexpected spaces around keyword / parameter equals
39:125: E251 unexpected spaces around keyword / parameter equals
39: D400 First line should end with '.', not 'y'
39: D205 Blank line missing between one-line summary and description
39: D208 Docstring is over-indented
48:5: E303 too many blank lines (2)
48: D401 First line should be imperative: 'Pick', not 'Picks'
48: D400 First line should end with '.', not ')'
57: D401 First line should be imperative: 'Pick', not 'Picks'
57: D400 First line should end with '.', not 'n'
57: D205 Blank line missing between one-line summary and description
65: D102 Docstring missing
68: D102 Docstring missing
71: D102 Docstring missing
73:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
20:21: W291 trailing whitespace
29:1: E303 too many blank lines (4)
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D204 Expected 1 blank line *after* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
34:41: E251 unexpected spaces around keyword / parameter equals
34:43: E251 unexpected spaces around keyword / parameter equals
34:66: E251 unexpected spaces around keyword / parameter equals
34:68: E251 unexpected spaces around keyword / parameter equals
34:94: E251 unexpected spaces around keyword / parameter equals
34:96: E251 unexpected spaces around keyword / parameter equals
34:123: E251 unexpected spaces around keyword / parameter equals
34:125: E251 unexpected spaces around keyword / parameter equals
34: D102 Docstring missing
36:49: E127 continuation line over-indented for visual indent
37:49: E127 continuation line over-indented for visual indent
38:49: E127 continuation line over-indented for visual indent
40: D401 First line should be imperative: 'Return', not 'Returns'
40: D200 One-line docstring should not occupy 3 lines


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
27: D203 Expected 1 blank line *before* class docstring, found 0
27: D205 Blank line missing between one-line summary and description
27: D208 Docstring is over-indented
43:41: E251 unexpected spaces around keyword / parameter equals
43:43: E251 unexpected spaces around keyword / parameter equals
43: D102 Docstring missing
44:24: E127 continuation line over-indented for visual indent
44:40: E251 unexpected spaces around keyword / parameter equals
44:42: E251 unexpected spaces around keyword / parameter equals
45:24: E127 continuation line over-indented for visual indent
45:42: E251 unexpected spaces around keyword / parameter equals
45:44: E251 unexpected spaces around keyword / parameter equals
46:24: E127 continuation line over-indented for visual indent
46:43: E251 unexpected spaces around keyword / parameter equals
46:45: E251 unexpected spaces around keyword / parameter equals
50:5: E303 too many blank lines (2)
50: D208 Docstring is over-indented
68: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
26: D203 Expected 1 blank line *before* class docstring, found 0
26: D205 Blank line missing between one-line summary and description
26: D208 Docstring is over-indented
39:41: E251 unexpected spaces around keyword / parameter equals
39:43: E251 unexpected spaces around keyword / parameter equals
39:66: E251 unexpected spaces around keyword / parameter equals
39:68: E251 unexpected spaces around keyword / parameter equals
39:94: E251 unexpected spaces around keyword / parameter equals
39:96: E251 unexpected spaces around keyword / parameter equals
39:123: E251 unexpected spaces around keyword / parameter equals
39:125: E251 unexpected spaces around keyword / parameter equals
39: D102 Docstring missing
43:5: E303 too many blank lines (2)
43: D208 Docstring is over-indented
61: D102 Docstring missing
64: D102 Docstring missing
67: D102 Docstring missing
70: D102 Docstring missing


1: D100 Docstring missing
20:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
23:1: E302 expected 2 blank lines, found 1
23: D203 Expected 1 blank line *before* class docstring, found 0
23: D400 First line should end with '.', not 'g'
23: D205 Blank line missing between one-line summary and description
23: D208 Docstring is over-indented
53: D102 Docstring missing
57:5: E303 too many blank lines (2)
57: D102 Docstring missing
70:60: W601 .has_key() is deprecated, use 'in'
72:39: E127 continuation line over-indented for visual indent
73:47: W601 .has_key() is deprecated, use 'in'
80: D400 First line should end with '.', not 'd'
80: D205 Blank line missing between one-line summary and description


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
25:1: I100 Imports statements are in the wrong order. import logging should be before import sys
27:1: I100 Imports statements are in the wrong order. import re should be before import urllib2
31:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_FULLTEXT_INDEX_LOCAL_FILES_ONLY, CFG_BIBINDEX_SPLASH_PAGES, CFG_SOLR_URL, CFG_XAPIAN_ENABLED
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
32:6: E126 continuation line over-indented for hanging indent
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.websubmit.file_converter should be before from invenio.utils.html
38:1: I100 Imports statements are in the wrong order. from invenio.legacy.miscutil.solrutils_bibindex_indexer should be before from invenio.legacy.websubmit.file_converter
40:1: I101 Imported names are in the wrong order. Should be BibRecDocs, InvenioBibDocFileError, bibdocfile_url_p, bibdocfile_url_to_bibdoc, download_url
40:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.miscutil.xapianutils_bibindex_indexer
41:6: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibsched.bibtask
46:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.ext.logging
46:1: I201 Missing newline before sections or imports.
47:1: I201 Missing newline before sections or imports.
49:29: E261 at least two spaces before inline comment
52: D203 Expected 1 blank line *before* class docstring, found 0
52: D208 Docstring is over-indented
52: D200 One-line docstring should not occupy 3 lines
57:41: E251 unexpected spaces around keyword / parameter equals
57:43: E251 unexpected spaces around keyword / parameter equals
57:66: E251 unexpected spaces around keyword / parameter equals
57:68: E251 unexpected spaces around keyword / parameter equals
57:94: E251 unexpected spaces around keyword / parameter equals
57:96: E251 unexpected spaces around keyword / parameter equals
57:123: E251 unexpected spaces around keyword / parameter equals
57:125: E251 unexpected spaces around keyword / parameter equals
57: D102 Docstring missing
60:49: E127 continuation line over-indented for visual indent
61:49: E127 continuation line over-indented for visual indent
62:49: E127 continuation line over-indented for visual indent
64: D401 First line should be imperative: 'Allow', not 'Allows'
64: D400 First line should end with '.', not 'g'
68: D400 First line should end with '.', not 'r'
73:5: E303 too many blank lines (2)
73: D401 First line should be imperative: 'Return', not 'Returns'
73: D400 First line should end with '.', not 'y'
73: D205 Blank line missing between one-line summary and description
73: D208 Docstring is over-indented
101:28: E713 test for membership should be 'not in'
158:66: E261 at least two spaces before inline comment
185:5: E303 too many blank lines (2)
185: D102 Docstring missing
189:5: E303 too many blank lines (2)
189: D102 Docstring missing
192: D102 Docstring missing
194:1: W391 blank line at end of file


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
26: D203 Expected 1 blank line *before* class docstring, found 0
26: D208 Docstring is over-indented
26: D200 One-line docstring should not occupy 3 lines
31:41: E251 unexpected spaces around keyword / parameter equals
31:43: E251 unexpected spaces around keyword / parameter equals
31:66: E251 unexpected spaces around keyword / parameter equals
31:68: E251 unexpected spaces around keyword / parameter equals
31:94: E251 unexpected spaces around keyword / parameter equals
31:96: E251 unexpected spaces around keyword / parameter equals
31:123: E251 unexpected spaces around keyword / parameter equals
31:125: E251 unexpected spaces around keyword / parameter equals
31: D102 Docstring missing
35:5: E303 too many blank lines (2)
35: D401 First line should be imperative: 'Tokenize', not 'Tokenizes'
35: D400 First line should end with '.', not 'y'
46: D102 Docstring missing
49: D102 Docstring missing
52: D102 Docstring missing
55: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
30:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.indexer.tokenizers.BibIndexMultiFieldTokenizer
50: D203 Expected 1 blank line *before* class docstring, found 0
50: D205 Blank line missing between one-line summary and description
50: D208 Docstring is over-indented
60:41: E251 unexpected spaces around keyword / parameter equals
60:43: E251 unexpected spaces around keyword / parameter equals
60:66: E251 unexpected spaces around keyword / parameter equals
60:68: E251 unexpected spaces around keyword / parameter equals
60:94: E251 unexpected spaces around keyword / parameter equals
60:96: E251 unexpected spaces around keyword / parameter equals
60:123: E251 unexpected spaces around keyword / parameter equals
60:125: E251 unexpected spaces around keyword / parameter equals
60: D102 Docstring missing
67:5: E303 too many blank lines (2)
67: D400 First line should end with '.', not 's'
67: D205 Blank line missing between one-line summary and description
112: D401 First line should be imperative: 'Tokenize', not 'Tokenizes'
112: D205 Blank line missing between one-line summary and description
128: D102 Docstring missing
131: D102 Docstring missing
134: D102 Docstring missing
137: D102 Docstring missing
140: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
26:1: F401 'CFG_BIBINDEX_INDEX_TABLE_TYPE' imported but unused
31:1: E303 too many blank lines (3)
31: D203 Expected 1 blank line *before* class docstring, found 0
31: D205 Blank line missing between one-line summary and description
31: D208 Docstring is over-indented
59:41: E251 unexpected spaces around keyword / parameter equals
59:43: E251 unexpected spaces around keyword / parameter equals
59:66: E251 unexpected spaces around keyword / parameter equals
59:68: E251 unexpected spaces around keyword / parameter equals
59:94: E251 unexpected spaces around keyword / parameter equals
59:96: E251 unexpected spaces around keyword / parameter equals
59:123: E251 unexpected spaces around keyword / parameter equals
59:125: E251 unexpected spaces around keyword / parameter equals
59: D400 First line should end with '.', not 'y'
59: D205 Blank line missing between one-line summary and description
59: D208 Docstring is over-indented
68:5: E303 too many blank lines (2)
68: D401 First line should be imperative: 'Pick', not 'Picks'
68: D400 First line should end with '.', not ')'
73:5: E303 too many blank lines (2)
73: D102 Docstring missing
76: D102 Docstring missing
79: D102 Docstring missing
81:1: W391 blank line at end of file


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
33: D203 Expected 1 blank line *before* class docstring, found 0
33: D205 Blank line missing between one-line summary and description
33: D208 Docstring is over-indented
50:41: E251 unexpected spaces around keyword / parameter equals
50:43: E251 unexpected spaces around keyword / parameter equals
50:66: E251 unexpected spaces around keyword / parameter equals
50:68: E251 unexpected spaces around keyword / parameter equals
50:94: E251 unexpected spaces around keyword / parameter equals
50:96: E251 unexpected spaces around keyword / parameter equals
50:123: E251 unexpected spaces around keyword / parameter equals
50:125: E251 unexpected spaces around keyword / parameter equals
50: D102 Docstring missing
54:5: E303 too many blank lines (2)
54: D400 First line should end with '.', not 'e'
54: D205 Blank line missing between one-line summary and description
54: D208 Docstring is over-indented
60: D102 Docstring missing
63: D102 Docstring missing
66: D102 Docstring missing
69: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
29:1: E303 too many blank lines (3)
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
43:41: E251 unexpected spaces around keyword / parameter equals
43:43: E251 unexpected spaces around keyword / parameter equals
43:66: E251 unexpected spaces around keyword / parameter equals
43:68: E251 unexpected spaces around keyword / parameter equals
43:94: E251 unexpected spaces around keyword / parameter equals
43:96: E251 unexpected spaces around keyword / parameter equals
43:123: E251 unexpected spaces around keyword / parameter equals
43:125: E251 unexpected spaces around keyword / parameter equals
43: D400 First line should end with '.', not 'y'
43: D205 Blank line missing between one-line summary and description
43: D208 Docstring is over-indented
52:5: E303 too many blank lines (2)
52: D401 First line should be imperative: 'Pick', not 'Picks'
52: D400 First line should end with '.', not ')'
57:5: E303 too many blank lines (2)
57: D102 Docstring missing
60: D102 Docstring missing
63: D102 Docstring missing
65:1: W391 blank line at end of file


Again, I'd prefer service here, if it works.  (Presumably 'initctl' is already a thing of the past, now?)


Again...


Small nitpick: please use 2 space indentation :)


83782874_LBNL_ThermostatOffsetFault (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@jensopetersen That is actually nothing to worry about. The system property has changed between log4j 1.2 and 2.x and I forgot to update the printout of that property when Jetty starts. I will send a fix shortly. Thanks.


@glenngillen yeah it was removed but we have some people asking for it. You can find the old markup here https://github.com/thoughtbot/refills/tree/27dd74bf158e45d47d51810feb3e0a77a2c1eac9/source

@tysongach better to take it back since people are looking for it? With a tweak? Make it SVG?


omfg...
instead of technical issue you've made some headache for the users. why did you do this?

this is related to https://github.com/ReDetection/homebrew-qtox/pull/11


Doing this mean :
`path` will now be `site_opts['docbase']`, wrapper cookbooks don't know (so they are not defining it) about this `site_opts['docbase']`, therefore `site_opts['docbase']` falls back to the default value. Which means you have the default docbase in `path` rather than the `docroot` you defined in your wrapper cookbook.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1158 of 1161 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.56%25-green.svg)


:scissors: too much whitespace :wink:


Nit picking, but change "Not defined" to "No defined" please


Note that we're checking `result.errors.empty?`, *not* `result.success`. Pop quiz: why do we get password-mismatch error messages added without getting `success` set to `false`?


Changed :+1:


Changed juga :+1:


I mean this technical issue does not really affect users experience and could be silently fixed. Instead, you're making additional steps thus negative experience. But users don't care about the issue, most likely!


@limer-org przecież skrypt wrzuciłem na samej górze, a potem niżej wkleiłem wyniki działania.
Poza tym nie ma jak dokumentacja w postaci kodu źródłowego. Zapraszam do lektury:
https://github.com/smarty-php/smarty/blob/master/libs/plugins/modifiercompiler.string_format.php
(to jest dokładnie to czego używa lms).
sprintf w PHP musi korzystać z jakichś wywołań funkcji api systemu operacyjnego na którym działa, więc może być tak, że działa tak jak na danej platformie systemowej funkcje api na których jest realizowany.


Why not used a batch session ?


Note the calls to [`Hash#symbolize_keys`](http://api.rubyonrails.org/classes/Hash.html#method-i-symbolize_keys) in the preceding two lines; *almost* everything coming from the view layer in Rails has string keys. Oops.


I am tempted to encode dimension as hashes keyed at dimension name, to do things like:
```
select pc_summary(p)::json#>'{dims,X,size}' from mytab
```

but... could a (invalid) schema use the same name for different dimension ?


comment


I'm not sure this helper should be in this module, why not in sonar-server ?


You can remove this branch entirely


Add a checkForNull


```show me the money``` was an old StarCraft cheat used to obtain minerals and gas ^^


I put it here because it's directly linked to the BatchReport.Measure class


True that. But the empty body exception is very predictable, and therefore avoidable - and perhaps loggable with a much more informative message.


removed on https://github.com/ginetta/grunt-skeleton-angular-styleguide/commit/e53c7a7a5021e68586208e0f94277dfdac38873c


This is not my interpretation of the code nor the docstring. Custom REPLs need to print custom things regardless of eval.


String requestURI = request.getRequestURI();// 访问Servlet的URI
String method = request.getMethod();// 访问Servlet的方式Get或Post
String param = request.getParameter("param");// 客户端提交的参数param值


ggg


@tfm it's done


I add it, but should we add it for all the nullable columns of the database ? What's the point ?


I still prefer to have a separate tests for different types of measure, but maybe for later


Reverted in 80d8d1fc276cd6a075b28e89f75f141bc6770b7f since it's a duplicate :) Funny, two pull requests were merged adding kafka in 1 day difference.


dfgfgdf


That commit message though.

See also: http://whatthecommit.com/


Done.


I think this method could be written easier considering you have a ```prev``` pointer and the length of the list
Something like:

``` if the length of the list is smaller than z
- print everything

else
- take a pointer starting from the tail and go 'back' z positions
- starting from where that pointer is now (z positions from the tail), print everything until the end

```


I'm still thinking that you should have used DbTester


Haha, and then this happens...

![heh](https://cloud.githubusercontent.com/assets/146040/6729137/c974ec14-ce2f-11e4-8790-1d7389f007ce.png)


OK, my mistake on that one, sorry...

I've recently re-jigged `mrinfo` a bit to allow gradient import options, and misunderstood the purpose of the check you'd put in place there. I just looked at the earlier version before I messed it up, it does indeed only prevent multiple inputs if exporting to file. I'll revert to that behaviour, I totally agree that the command should allow anything it can reasonably handle, even if it's hard to see how the output could be used easily - as long as the output is predictable...


But it should not. It should only be used in the compute stack, batch stack should not used id.


I will fix:
1. border & s
2. Remove the condition Pt != (PAWN || KING)

and resubmit.


@terasa sluchaj


Thanks for this


As soon as a method can return null, you should add a @CheckForNull on it


Difficult to write that the right way. I am just not too happy with that :-/

That is a solution that would work now, and it seems like it will work nicely. But what I imagined we would have is a small api-field to register a table, and then a small piece of code to show when such a database table is still there but not used anymore (and of course in the core code to create and update the table, but that is a different story)

This is doing more, and it is not small anymore. I realize you proposed that in https://github.com/s9y/Serendipity/commit/56323412b8b0359dfc40e27d208c93153218b513 but got no answer, sorry about that!
You remember probably that I was not too keen on the idea of the db cleanup, and maybe that is the same thing. But to show all tables that don't belong to s9y, that does not seem like it should be our work, and part of the core. There is already the prefix for that (I might miss something here).

$legacy_plugintables looks like a maintenance nightmare to me. I'd prefer if we'd say "to let users list your tables after the plugin is uninstalled, please use the plugin-API to create your database table". We could update some of the important ones ourselves - we will have to anyway, to have proper test-cases of the db-api - and then it would be immediately helpful as well for at least some plugins.


The docstring of both `clojure.main/repl` and `cljs.repl/repl`:

```
     - :print, function of one argument, prints its argument to the output
       default: println
```

Yes, REPLs need to print stuff outside of eval, but the whole point of the `:print` arg is to enable the REPL to print return values as such.


This is probably not a best idea ever but atleast we can get all builds green


> the end of the environment can be marked also by a pointer to a NUL character

Do you have any authoritative source for that? Like the man page to the Unix equivalent of `CreateProcess` that documents how such an environment block is built?

Also, does a pointer to a NUL character, i.e. a pointer to an empty string, really mean that the end of the environment block is reached? I would expect that such an empty string should just be skipped, and that more non-empty strings might follow.


Is int32 still a thing?

On Thu, Mar 19, 2015 at 4:47 PM, Simon Krajewski <notifications@github.com>
wrote:

> Fixed in 9eb1e35
> <https://github.com/HaxeFoundation/haxe/commit/9eb1e35af1042dfec841191147b415b38437f2fe>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HaxeFoundation/haxe/commit/c9eb7d76ad304c7c7a349c06c2098a5e3ee3a301#commitcomment-10280830>
> .
>


Kafkaesque (comparative more Kafkaesque, superlative most Kafkaesque)

Marked by a senseless, disorienting, often menacing complexity.

:-)


- image recognition on products currently in the pantry? prevents multiple buys and helps manage what add on the grocery list


89224666-FixNANProblems-Issue4557 (rraustad) - i386-Windows-7-VisualStudio-12: OK (1665 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg)


I think there would be an issue with spaces around the commas. You probably should split by a characterset including comma and white space.


But the DNI is a type of NIF, isn't it? I understood that we were going to use one directive name, and depending on its values, it will do one kind of validation orr another. But I am not sure about it.


83782874_LBNL_ThermostatOffsetFault (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (650 of 652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.42%25-green.svg)


This could have been much simpler with
http://www.nodeclipse.org/projects/gradle/android/Make-Android-Eclipse-project-ready-for-Android-Studio


Hello zz85, I can't find anywhere an explaination on how to use the "frames" option in ExtrudeGeometry. I opened this (http://stackoverflow.com/questions/24520158/how-to-extrude-different-shapes-on-the-same-spline-without-interruptions) old topic without any answer, and it seems the same of what is written here (https://github.com/mrdoob/three.js/issues/1810#issuecomment-5358963). So, probably, I can use the "frames" option to set the orientation for the starting point of each spline, but how to use it? How to write the arrays of tangents, normals, binormals, and pass them in frames? In which order? Would be good an example in the Three.js docs for ExtrudeGeometry (http://threejs.org/docs/#Reference/Extras.Geometries/ExtrudeGeometry). Thanks a lot, and ...ps: I really like your accomplishments!! You're great! :)


This file is autogenerated. Update the rst and that it is not impacting other page in documentation and resubmit a request.


Refused. What should be the benefit of this ?


Magic values (position and name), move to constant with significant name. After that You can remove those unnecessary comments because code shows Your intentions.


i think it not need, see https://github.com/brandonkelly/yii2/blob/ef8925618f316d7324cd7898f006163550b8e2af/framework/helpers/BaseArrayHelper.php#L96

https://github.com/yiisoft/yii2/blob/master/tests/unit/framework/helpers/ArrayHelperTest.php#L82


Please remove the unused flags width, height and imageType.


Some kind of error handle would be nice if map is null here.


At this point we already know the number of entries in `deltaenv` thanks to the `while` loop above. So how about instead

    while (--i >= 0)
        size = do_putenv(tmpenv, deltaenv[i], size, 0);

Compared to before, this iterates `deltaenv` in reverse, but that should not matter in this case.


What if mMap will be null after setup?


FYI - generally we leave these things in a `~/.sbt/0.13/plugins.sbt` or some such.  At a minimum, this should be in a different commit.


Express.js default code!

you can access init page at 'localhost:3000/'


Thanks for adding these.  Additionally, (as I said when adding the .idea directory), you really do want a `~/.gitignore-global` and configure git to automatically pull in your global ignore file for whatever IDE you're using.


Please just return 0,0 in this case - there's nothing really tying this list to that font.


@matejhof is this needed? On my machine it compiles even without this. The `include_directories` was rather done at a module level, in order to avoid including unneeded directories if they were not needed for the specific module.


In giornata non riesco, ma stasera ho intenzione di sistemare la questione
delle richieste post e get nel file API di elgg e di conseguenza anche la
routes nelle foowd_api.
Se ci mettete mano conviene che mi avvisiate o meglio ancora che lo
committiate, in modo che nessuno stravolga il lavoro altrui.

Se c'è bisogno è di contattarmi possiamo sentirci su skype a partire dalle
18:00, ma prima avvisatemi su whatssapp please.

Buon pomeriggio a tutti.
Il 19/mar/2015 10:14 "scardoni" <scardoni.simone@gmail.com> ha scritto:

>
> Ciao Marco,
> confermo la cancellazione di tali files.
>
> Il 19/03/2015 09:54, Marco ha scritto:
>
> Ciao Simone,
> A me sono rimasti dei fle relativi alle API offerte, tipo Get.php,
> Post.php, Get.php .... , solo che sul repo non li vedo più, sono stati per
> caso cancellati.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coder-molok/foowd_alpha2/commit/6a4e90197c5273c5cbe5673cc26a8f3da2c332f9#commitcomment-10280948>
> .
>
>
>


I wonder what is the different between DNI and NIF, is it only the letter? if it's I think the best way is to use only one directive :)


I agree that the people pages weren't especially useful, but it's a shame to break the URLs.  Could we perhaps add redirections instead?


would you mind if I squash this commit in the PR?


The beamer package includes *hyperref*. You can use the command ````\url{…}```` for URLs


:) Again, mind if I squash this commit before committing?


Please avoid "m" prefix, googleMap will be better name.


The term "tell-tale" here as well in the commit message confuses me as I cannot think of / find a suitable translation to German that makes sense for me in this context. Could we maybe use a less informal term and say something like "reference" or "indicator"?


Here Fragment instance returned by findFragmentById() method could be null and if not could be not an instance of SupportMapFragment in those two cases app will crash.


I'm assuming the actual behavioral problem you are trying to describe for consumers - that maintaining eval/print simplifies the interaction model downstream. What's here is simply preserving the original printing behavior of the ClojureScript standard REPLs which may very well not be ideal in this case. There's a few places this needs to change around debugging and error printing. We should probably adopt the approach taken by the socket REPL patch which allows disabling the binding of `*err*`to `*out*`.


@lynicidn By the time that line of code is executed, the damage described in #7764 has already been done:
https://github.com/brandonkelly/yii2/blob/ef8925618f316d7324cd7898f006163550b8e2af/framework/helpers/BaseArrayHelper.php#L87-L88


opened issue #9


Forgot that there are cases where max == min, and that will be problem... maybe we can return a list full of 1'?


Yeah. Btw, I eventually plan to merge the two functions back in one, since the main gui refresh function is just a loop around that switch.


Definitely not the best idea. Better to revert.


Avoid "m" prefix in class field names.


If I'm understanding the change correctly it basically ensures that the environment as possibly modified by third-party code is propagated back to the environment we use to spawn processes. And I'm aking myself whether we even want this. I mean, why would we want to pick up and pass the `CHARSET` environment variable as set by `curl_global_init()`? It seems to me as if no other code than cURL would depend on this, and cURL will set it again if it is missing anyway, so why bother picking it up in the first place?

Sorry if I'm missing something here ...


Ahhh vandaar ;-)


Hello zz85, I can't find anywhere an explaination on how to use the "frames" option in ExtrudeGeometry. I opened this (http://stackoverflow.com/questions/24520158/how-to-extrude-different-shapes-on-the-same-spline-without-interruptions) old topic without any answer, and it seems the same of what is written here (mrdoob#1810 (comment)). So, probably, I can use the "frames" option to set the orientation for the starting point of each spline, but how to use it? How to write the arrays of tangents, normals, binormals, and pass them in frames? In which order? Would be good an example in the Three.js docs for ExtrudeGeometry (http://threejs.org/docs/#Reference/Extras.Geometries/ExtrudeGeometry). Thanks a lot, and ...ps: I really like your accomplishments!! You're great! :)


all credit to Lai Jiangshan <laijs@cn.fujitsu.com>. I was getting a bad commit error and had to do this.


I suggest to revert this change in a commit that will make code strict c99 compliant


Now that say it, I must I can't remember whether I tried without the offset.

Anyway @akien-mga requested to change the rotation value to 30° so I'll have an opportunity to test again.


@barakd That's right, the flag should be set before the call, so that a second call won't be triggered. As I wrote, it was off the top of my head, I didn't analyse it in detail.

As for the extra code, it's not really necessary (you can set a property that doesn't exist, it will be added automatically). If declared, it should be `protected`, not `public` (there's no use for it outside of the `WC_Cart` class).


I would think they should follow the same alphabetic order as usual imports, yes.

As for separating by blank lines, I don't think eclipse actually has a control setting for that - at least, I've never see it. I think Eclipse always puts a blank line between categories of imports - there is no way to tell it otherwise (unless there is a setting somewhere I don't know of).


Sorry about that. I had a test where I'm sure scaling x/yoffset was wrong, but now it looks like it was right and shouldn't have been removed. This is fixed when #2955 is merged.


It sure would; but so did the old code.


Added.

On Wed, Mar 18, 2015 at 7:25 PM, Andrey Breslav <notifications@github.com>
wrote:

> Need to mention SAM constructors: Runnable { ... }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JetBrains/kotlin-web-site/commit/27bfd1884cf1fc71cf2800fa158f5c69e02a204a#commitcomment-10270797>
> .
>


I think that we want to know what crashes our camera opening, not just the general crash. Add more catch blocks and handle the. This kind of code should't appear in app, especially in pice of code which is that important. It's called "Pokemon Exception Handling" ;) http://blog.codinghorror.com/new-programming-jargon/


BTW, static imports are now configured to go at the top, above normal imports. so right now this eclipse file configures is to be:

static java.*
static javax.*
static org.*
static com.*
static * (all other unmatched imports)
java .*
javax .*
org .*
com .*
* (all other unmatched imports)


Always use CamelCase names. ArActivity


Always use CamelCase names. ArFragment


Plz release to grails, thanks


Avoid "m" prefix in class fields names.


If you mean the explicit identification of evaluation results vs. e.g. printed output, yes. It's pretty important if you want to interact with a REPL programmatically. Distinguishing between results and arbitrary printed content using `*out*` vs. `*err*` seems imprecise?

Anyway, I can work around this if necessary, it just won't be super-pretty.


Anyway, this commit was green on all builders


Shit code mate :trollface:


This deprecated surface setting can be removed, our app doesn't support API 11 devices.


At least change to Log.e().


At least change to Log.w().


That's a good point.  I filed #49 for this and suggestions welcome.


This line is causing [CI to fail](https://travis-ci.org/michaeldv/awesome_print/jobs/54950871):

```
There was a LoadError while loading awesome_print.gemspec:
cannot load such file -- awesome_print/version from
  /home/travis/build/michaeldv/awesome_print/awesome_print.gemspec:3:in `<main>'
Does it try to require a relative path? That's been removed in Ruby 1.9.
```

I approve of the idea, though; what's the right way to `require_relative` in a multi-version-compatible gem these days?


At least change to Log.e().

catch(Exception e) comment above.


They were uploaded but just unpublished but: yes.


I think you didn't update the output rickshaw.js and rickshaw.min.js files, pulling this branch didn't work for me until I did make clean + make build


@legaultpierre is "Margaree Consultants"


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/10030/testReport/) for this commit**


Bad code formatting.


89224666-FixNANProblems-Issue4557 (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1665 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg)


That is a valid else case that needs testing.


Filter IP For black and white


Done. See https://github.com/schemaorg/schemaorg/pull/387/files


Sorry, half your reply appeared as folded on github, dunno why. We have a process that reliably works on precise, trusty, squeeze and wheezy. Given the history of array of installation issues, I would be very risk-averse to switching to something else unless we e.g. bundled an entire copy of the modules ourselves too (might not be a bad thing, but presumably a faff and quite large). "that'd mean we may get more version clashes" is a rather important thing to avoid IMO, it already feels more fragile than other packaging systems.


Does this mean we had the heartbeat at 10 seconds instead of 10 ms ?


Markdown file


Well, show_problem_list_notification() calls notify_problem_list() which destroys the list passed as argument. That means that after show_problem_list_notification() the variable passed to the call holds a freed pointer and must not be used. ```GList *``` looks like passing a read only list, ```GList **``` tells the caller that the called function takes over the list might changed its value.


Oh, obviously as the altered documentation above says. But the SDAM spec seems to have said 10ms previously. I guess it's good we're updating this = )


Quand tu retravailles sur une branche, fait un merge de la branche master quand elle est plus à jour que là où tu recommences à travailler. Sinon il y aura encore plein de soucis au niveau du merge après ton travail.


86046200_CondenserToZone_CherryPick (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.3%25-red.svg)


@legaultpierre:
- W.D. Montgomery: Charles River Associates, USA
- E. Krause: Lawrence Berkeley National Laboratory, USA
- A. Pegov: Institute for Systes Studies, Russian Academy of Sciences, Russian Federation


Performs a nil-check. (NilCheck)


Doesn't depend on instance state (UtilityFunction)


Has approx 6 statements (TooManyStatements)


Use the new Ruby 1.9 hash syntax.


Redundant curly braces around a hash parameter.


Extra empty line detected at block body beginning.


Extra empty line detected at block body end.


Assignment Branch Condition size for test_data is too high. [23.35/20]


Because I think it's a good value and I don't want ```abrt-applet``` to hang in case of bugs in ```abrt-dbus```.


@sidorares
While that was quick and flattering, I'd prefer to remove it from the list. This really was only a dirty hack-around kind of thing. I'll try to do something else with it that's a bit more meaningful. I'd be happy to PR adding it to the list once it's ready. :)


Alle Language use $ and u € thats not work :)


@stopiccot Why would you use { 0, 0 } instead of { 0 }?


Fragments should be created with static newInstance method. http://stackoverflow.com/questions/9245408/best-practice-for-instantiating-a-new-android-fragment.


Better leave the reverts to me.


Correct. That's because the following is stated in original Rickshaw repo in [Contributing](https://github.com/shutterstock/rickshaw#contributing) section:
> Please don't include updated versions of rickshaw.js and rickshaw.min.js. Just changes to the source files will suffice.


Can you still revert a commit if it has comments?


86046200_CondenserToZone_CherryPick (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Given that the plugin is now moved to -bad, it could default to no I suppose.


You should add empty constructor and newInstance method for fragment. http://stackoverflow.com/questions/10450348/do-fragments-really-need-an-empty-constructor


Use the async variant in this case. It won't hang at all.


This not-initialized variable used several lines below caused me 15minutes of debugging. Please initialize your variables!


git revert {hash}


Feel free to rewrite the code using the async variant. I'm not going to struggle with asyc D-Bus calls in C.


Font size should be set in XML and the value should be in dimensions resource files.


Empty constructor is missing.


Perfect thanks!


Static class should be declared as be final to avoid inheritance.


@tomkralidis flake8 is not happy :) : geonode/catalogue/backends/pycsw_local.py:115:43: W601 .has_key() is deprecated, use 'in' could you change this? Thanks.


perf


Yes, it does, because then the sorting order is reversed (the worst case for most sorting algorithms).


Always add brackets.


I don't understand this patch. offset and consumed are just helpers to fast forward into an array of iovectors. they will be reset in iscsi_iovector_readv_writev if needed. setting nalloc seems to be dangerous (memory leaking etc.) and makes no sense to me.

Where you seeing scsi_task_add_data_in_buffer adding buffers twice?


Eloquent stuff here Lou, I like where you are going with this!


What if locationManager is still null?


I already have my own auth plugin :P
My private auth plugin supports password in chat.


I want to avoid the direct access to members which might get changed in background or might be loaded only when needed. Actually the function is used 2 times in notify_problems_list() (each call is in a separate code execution path so the function is called only once in a single notify_problems_list() call).  The 3rd call might never happen because it is called in action_restart().


Thank @tobya , I will make the merge of the changes. Best Regards!


This is a good idea - if this has worked well for you, I might add this in to my copy?


What if sensorManager is null?


Anyway i still highly encourage everybody to use scoped variables. It's obviously a much better practice.


> > the end of the environment can be marked also by a pointer to a NUL character
>
> Do you have any authoritative source for that?

Well, the most authoritative source is the inspection after a real life `putenv()` call ;-) Yes, the last `environ` entry points to the last part of the environment block (which is terminated by a double `NUL` as documented [in the *lpEnvironment* description of `CreateProcess()`' documentation](https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx)).

> Also, does a pointer to a NUL character, i.e. a pointer to an empty string, really mean that the end of the environment block is reached? I would expect that such an empty string should just be skipped, and that more non-empty strings might follow.

Nope, a double `NUL` marks the end of the environment block (which is an array of consecutive, `NUL`-terminated environment variable settings). That definitely marks the end.


Sure, I'll change it to *indicator*.


I can make you sure that without this patch abrt-applet crashes at start-up if there is a new problem directory.


Sure.  Find my email on website


> java.lang.RuntimeException: Command name evaluates to null:
> $distributionObject

This breaks! Unfortunately cd is a void command.


Can this be simplified further?


Before you rewrite it, I'd like to merge this pull request because I need it for Fedora updates.


Read Twitter Dm?
On 19 Mar 2015 11:56, "xxFlare" <notifications@github.com> wrote:

> I already have my own auth plugin :P
> My private auth plugin supports password in chat.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xxFlare/SimpleAuth/commit/900bc41ebe47e7f54747e3146a2fd467a878bd06#commitcomment-10283546>
> .
>


This breaks! Unfortunately cf is a void command.


Thanks :)


@SiPlus Dunno, I just copied text from error message


> If I'm understanding the change correctly it basically ensures that the environment as possibly modified by third-party code is propagated back to the environment we use to spawn processes.

Not only that: we also query it via `getenv()` calls (that are redirected to `mingw_getenv()`.

> And I'm aking myself whether we even want this. I mean, why would we want to pick up and pass the CHARSET environment variable as set by curl_global_init()? It seems to me as if no other code than cURL would depend on this, and cURL will set it again if it is missing anyway, so why bother picking it up in the first place?

That is a red herring. The point is not so much that we might want to query the value of `CHARSET` – which BTW we might want to do, let's not make assumptions now for all future! – but that the binary search relies on the `environ` array to be sorted. And appending `CHARSET` will definitely shatter that assumption, just think of the `GIT_PREFIX` variable we *do* need to set before even `git-remote-https` is called.


Isn't this going to break RTL translations?


The difference between nif and dni it's a bit bigger than only a
letter(juridical nif I mean) if you want I will explain you this afternoon.
I have implemented the recommandation that Braulio told us about regular
expressions and assignation to a variable. If you are in a hurray you can
check it in my document about regular expressions in google drive.
El 19/3/2015 12:19, "MiguelChamizo" <notifications@github.com> escribió:

> I wonder what is the different between DNI and NIF, is it only the letter?
> if it's I think the best way is to use only one directive :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/anenchu/rc-spanishIdValidator/commit/0454717971f6f1c30c8a429cae30e521a9bb5b50#commitcomment-10283016>
> .
>


First changes


I think this could be also made a constant.


I have a question on this line. Why are you loading the core 'ng'? Does '$injector' need to load it to work?


One consideration for printed output (even if directed to *err*): it needs to be modeled after `print` (in contrast to the default of `println` for `:print`).

Rationale: this supports evaluating forms that essentially call either `print` or `println`, without presuming a newline should be sent to `*err*`.

The pattern I've used in Ambly is `:print-no-newline` followed by `:flush`; perhaps with `*err*` semantics the `:flush` isn't necessary.


ConstructionsGridView (rpg777) - i386-Windows-7-VisualStudio-12: OK (2173 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.0%25-yellow.svg)


... that's not going to work for anyone but you, did you mean to push this to master?


Thanks for adding the curve code!


/cc @ghickman @jonathanchu Please review this :)


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


pi->envp can be null because we do not intialize this variable in name_acquired_handler() because it is not necessary as we are sure that the crashed application is not running.


"This is and AngularJS library which provides validation directives for common Spanish official ID numbers like DNI or NIF."

Some comments here:
- change "and" to "an" in the first sentence. I believe the "common" adjective is rather unnecessary for the description of the image, you can do without it. I would also change "numbers" for "documents"

"Usage of the validation directives it's very easy."
- Not wrong, but I would probably omit this sentence.

"Each input you want to validate must contain the **ng-model** and the directive, **rc-dni** in this example. Now the directive will set invalid the input if it is not correct."
- This explanation feels rather "clunky" to me. I would also keep it slightly simpler and more assertive. For example: "Each input you want to validate must contain the **ng-model** and the custom directive rc-dni" (whether the directive is rc-dni or nif-validate is not relevant, you can always change the name once the corresponding implementation has been uploaded).
- Remove the second sentence. Instead, simply say something along the lines "An example of application can be found below" or something similar
- After the example is set, you can then write something like "If a non-valid DNI is provided in this input element, AngularJS will identify it as a validation error".

"For more information visit the tutorial page to see the Getting started tutorial and code samples.
Dependencies"
- This is ok, but rather than "... visit ... to see ..." I would say "....visit... and check ...."


You still need to test the result here. For all you know "juju env" could spit out random garbage and exit with failure - if you don't test (and rely on env being not None) you'll never know.


Bagaimana dengan: Mengutamakan standar yang berkelanjutan


"juju environment not defined" or "The juju environment is not defined" or "No juju environment found" would all be better.


Nice!


I'll continue the discussion in the issue.


There you go: 22cc9c9.

BTW for your reading pleasure http://en.wikipedia.org/wiki/Tell-tale :grinning:


Is this being set somewhere else?


npm WARN package.json Dependency 'http' exists in both dependencies and devDependencies, using 'http@*' from dependencies


Masukan dari saya: Apa saja yang diharapkan dari io.js?


We need to "Extract function" a little bit here, methinks.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1160 of 1162 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


Next lucky dude to change this file should try to reduce duplication.


Sorry for that, I will update soon.
I think we can do something like:

```ruby
$:.push File.expand_path('../lib', __FILE__)
require 'awesome_print/version'
```

I get this from [here](https://github.com/Ink/filepicker-rails/blob/master/filepicker_rails.gemspec#L1-L4). This gemspec was generated using the rails engine template.


Masukan dari saya: Pertimbangan di atas dikompilasi dari proyek roadmap. Kami masih mengharapkan kontribusi Anda.


More than straight-forward and looking fine as for me, but, since we're there, for you to know: ;)
https://cppkid.wordpress.com/2008/08/27/why-i-prefer-n-to-stdendl/

So you'll have a better idea when you want to flush or not when using newlines.


Hi,

thanks for your PR. I will change the way how to search for a host. I never had this problem because i always specified the hostname including the domain. That's why i can't use your implementation as it would break my way how to do it.

Short Question: Which additional benefit do you see in "return <bool>, host" ?
Line 225 would fail in this case if the host does not exist.

Cheers
Thomas


Very bad translation / très mauvaise traduction !


Kebijakan vs Kebijaksanaan?


comment


oh you're right. No, the directory still has to be adjusted by the user. Setting it to my path is as bad as the alternative "../lib/MUMPS" though. can we detect the installation directory of MUMPS automatically?


Without (`([^\\])`, `$1`), `a\\[`results in accessing `a.[`.


86046200_CondenserToZone_CherryPick (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (622 of 622 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-3.65%25-green.svg)


@Nick0703  + https://github.com/crdroidandroid/android_frameworks_base/commit/428deb08f55598fee4cb9a72921f50130bbc7394

will solve bad drawable back button in pac rom