I am done for today. Please review.


If you try to set null value from test class then checkstyle throws an exception so this validation is useless. Can you pass null value from xml file or it will be pass empty array here? If you can pass null value that means that api for testing is different than for xml file and some cases could not be validated


@gck-ableton: I guess CMake doesn't care, but the proper casing is `Qt5Qml` I think.


I don’t know if it was fate or not, but this was exactly what I was looking for in regards to text in Dragon Tempest.

From: LevelX2 [mailto:notifications@github.com]
Sent: Wednesday, March 11, 2015 2:08 PM
To: magefree/mage
Subject: Re: [mage] Replaced all usages of EmptyEffect by InfoEffect. (f31c317)

Thanks, I was also a little bit suprised that the effect was used so sparsely.

—
Reply to this email directly or view it on GitHub<https://github.com/magefree/mage/commit/f31c31767580e8293298c8fe9d44c7ec85ff8a8a#commitcomment-10150058>.


Implementation of:

interface IPriceManager
{
 void AddArticle(string name, double price, DateTime insertionDateTime);
 bool AddPromotion (string articleName, double discount, DateTime startDate, int durationDays);
 double GetPrice(string name, DateTime date);
 IEnumerable<string> GetArticleNames();
 void SetChristmasPeriod(DateTime startDate, DateTime endDate);
 void SetClearancePeriod(DateTime startDate, int DaysDuration);
}

- An user adds articles in the catalog using the method AddArticle.
- When AddArticle method is called and the article exists in the catalog, an ArgumentException will be thrown.
- GetArticleNames method returns article's names of all articles in catalog
- GetPrice method returns the price of an article in a specific date. If the article doesn't exist, an exception with the text "Article [name] doesn't exist", will be thrown.
- An user set a promotion with the AddPromotion method. The promotions have a start date and days during which apply the discount.
- SetChristmasPeriod method sets the Christmas' discount period, in which 30% off is applied to all articles.
- SetClearancePeriod method sets a period during which 50% off is applied to all articles.
- If you have several promotions for the same product at the same time, apply the highest.


@gck-ableton: this change should just be part of the previous commit.


Can this fail fast with a useful message or warn with a useful message?


ok thx
Do you have workspaces with accented character in label?


@SergeyTravin
This change caused an additional test to fail in core.  Can you take a look?

https://github.com/pentaho/pentaho-kettle/blob/master/core/test-src/org/pentaho/di/core/row/value/ValueMetaBaseTest.java#L138


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (637 of 637 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.19%25-green.svg)


There are a lot of whitespace & tab->spaces issues with this file.
If you want me to fix this too in this PR, say Ho.


@gck-ableton: `QRegExp` is obsolete in Qt5, so maybe it's not worth supporting it.


go for it! :)


Actually, one of these tests caught an error because I used logger.log_level instead of logger.level.  So these are to catch those errors, which they did.

"we can assume setters/getters always work"  -- https://www.youtube.com/watch?v=wg4trPZFUwc


Would prefer this to be a separate commit.


Ah, I see.


`git bisect` flags this commit as the source of a segfault in `Pkg.test("Tk")`. It fails on [this line](https://github.com/JuliaLang/Tk.jl/blob/b8b2c205c08158424f5399b1629c2606a8928216/test/runtests.jl#L133) and the segfault happens [here](https://github.com/JuliaLang/Tk.jl/blob/b8b2c205c08158424f5399b1629c2606a8928216/src/tkwidget.jl#L93-L94). That `ccall` looks good to me, and it gets called many times previously, so I worry this is exposing some internal julia bug.


Thanks for following up! I've been sick recently (still am) so haven't gotten around to doing anything. I probably won't get to looking at this until I get better, so please spend some time on it :)

I don't think there's any point in deciding the API up front. It's something that's easily iterable and changeable.

I think the most flexible approach may be to jettison the concept of formatted vs non-formatted text. Honestly, there's so many levels of "formatting" that can happen. For example, FI => Finland => Suomi. We may want to hook in at different steps. Maybe the right solution is for each pipeline step to:
- know what comes before it
- output the following:
  - result of its transform
  - input it received from previous pipeline


I guess that you have addressed to the wrong @falvarez :)


I have read that link, understood the standards and format all the files code according to it.


@mpalmi


@kaishin I noticed this problem today and was going to fix it, but it looks like you've already addressed it here. However, the production site still points to `/`?

![neat-snafu](https://cloud.githubusercontent.com/assets/5566826/6604821/b0d12904-c801-11e4-8082-9218db8d11a9.gif)


twisted logic


haha I think so! @falvarez


It's a common mistake, one that I ofcourse have never fallen victim to.. *cough* *cough*


@mpalmi ping


Somehow this is pointing to the wrong commit.  It should be pointing to 9537272afa63b77fde4d004deeaebf460e9968af, not af9028...


@s0undt3ch and @rallytime I will try and debug this from an opensuse vm.
strange that npm install bower doesn't work,  @s0undt3ch is there more logging on the install part?


this is not the correct approach, look at how the other accessors have been implemented to be immune to the state-transition renames.  Files/directories must be opened relative to c.fd using the *At functions.


Why not capture the exception and include it in the error message?  Also I think we should do a `HEAD` request, to avoid retrieving the content.  Something like:

    def require_ostree_repo(url):
        configurl = url + '/config'
        try:
            subprocess.check_call(['curl', '--head', configurl])
        except:
            fail_msg("Unable to verify find {0} and verify it as an ostree repository. Please check your repository and re-run".format(configurl))

Should both show the error text and give the hint about it being an ostree repo.


I think I should make a separate function for creating a connection and can use in any method.


@phst: I don't know the reason: you'll have to ask Fujii why he did it. I restored `p4-diff-all-opened` in commit 50382e2733ce0b9b4a915a049d72a294270cd4fe. I've never needed `p4-diff-head` myself, but if you have a use for it, please open an issue and explain your use case and I'll see if I can restore it too.


This is unluckily what QML gives us, when you do the `//` syntax in QML.  The alternative would be to have an  `expectMessage()` and `expectMessageRegex()` and both taking a string – which I find sad...


comment faire pour les commit


no prob. Let's just say you were prepping me for the tutorial on Thursday!
:P

On Wed, Mar 11, 2015 at 9:15 AM, Jordan Eldredge <notifications@github.com>
wrote:

> Interesting. Sorry for the bad PR ;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gdtrice/dotfiles/commit/ee80a800d053190958802f295036f05724a261e0#commitcomment-10146116>
> .
>


I should handle that case also by putting space check in it as this registration phase is not complete yet I will handle that case.


Of course :-)  I have created a workspace with accented character in label for the test in My Web Pydio used before production.


WinEquivalentLayer_#4625 (Nigusse) - x86_64-MacOS-10.9-clang: OK (1649 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


From Prof Delvelnne:

"Regarding notes: as suggested, I offer 0.5 bonus point on the final grade for  half a course written in LaTeX. So pair up for a full 2-hour course."

"Dear students,

in our effort to write notes for the course, it would be nice that you all share a common LaTeX template so as to assemble the final document easily.

One possible way is the following: the first group to finish (as far as I know that would be Dounia+Cyril) could share their document or template, and the others would use it. Of course i let you free to organize this differently."


If the user is registered successfully there will be successful registration message and it will redirect the user to login page after registration process.


I'm not sure I understand this one. Why not require a password change with the livecd?


Is this a `.get` on a Option? If is that safe to do?


Great, thanks!


Understood


we're downgrading to 1.6.7 because that's what the stripe gem is using and so bundler is dying during the `bundle install` process.
it doesn't look like there were very many differences between 1.6.7 and 1.7


Does ```$document``` has access to ```querySelectorAll```?

If it does, I think it'd be better to use it. It'd be easier to mock for tests, for example.


There's a bug in Tk's cfunction usage


I took away the version number attribute, but left culture, token and architecture attributes.


I'll take another look at the PR and update them where it makes sense to do so


Ah ha! Yes!

```
2015-03-11 08:58:29,889 [salt.state       ][INFO    ] Completed state [nodejs] at time 08:58:29.889323
2015-03-11 08:58:29,890 [salt.state       ][INFO    ] Running state [bower] at time 08:58:29.890166
2015-03-11 08:58:29,890 [salt.state       ][ERROR   ] State 'npm.installed' found in SLS 'bower' is unavailable
```

looking at the state module in question...


These app.config files shouldn't be here, it looks like I just reverted them on top of my commit by accident when testing for the existence of the reflection bug. Then they slipped here too. Good catch though.


This is a merge conflict. You won't want this committed. It's something you should fix locally before committing and pushing.


It's a stateless system. If you reboot CLIP the new password change won't be there...it will still be the old password and force to change it at first login.

That's why I see it as pointless to force a user to change their password.


Before I merge this -- can I see a run of it w/ instructions? (in my office now)


LG.  It wouldn't hurt to have some javadoc that outlines an example Bundle structure, took a little while to understand from the code.


This is pretty cool! Useful than ever. Thanks a lot.


makes sense


@mity: Are you interested in upstreaming this change/feature? In order to use the HTML control as our main UI, we needed to be able to intercept all external link clicks, prevent them from being followed, and open them in an external browser.


The `bower` binary is not being found the `$PATH`...


Commit 0005ea3873202ddefaae6466a932c159c08fd1c3 fixes the issue. Thanks
for pointing this out.


heh, wrong state module...


true


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1149 of 1149 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.64%25-green.svg)


I left here as they come. We can remove them when the Nuget packages get updated so that it doesn't feel like this example is especially prepared and not an "ordinary Orleans Nuget example".


Maybe it was slipped in this commit but [it's in `src` too](https://github.com/swagger-api/swagger-ui/blob/develop_2.0/src/main/html/index.html#L59)

Please use develop_2.0 branch


@addyosmani Isn't this meant to be `New since 1.3`?


I went ahead and added duplicate removal strategies for both cases. You can use them like this:

```cs
// Remove entries with duplicate first term
var tableA = RantDictionary.FromDirectory("dictionary", NsfwFilter.Allow, TableMergeBehavior.RemoveFirstTermDuplicates);

// Remove duplicate entries
var tableB = RantDictionary.FromDirectory("dictionary", NsfwFilter.Allow, TableMergeBehavior.RemoveEntryDuplicates);
```


comment is misleading here, as it also checks whether this is actually a known channel. but that may no longer be needed either


If QML is giving us this, then let's keep it.


got to check for failing `new` too (oom), which is what this does too


This is nice!


:grimacing:


@akhayrutdinov  this change caused a test failure in kettle engine.  Can you take a look?  We're getting in an infinte loop here:https://github.com/pentaho/pentaho-kettle/blob/master/engine/src/org/pentaho/di/trans/step/BaseStep.java#L1515

The test that fails is this one: https://github.com/pentaho/pentaho-kettle/blob/master/engine/test-src/org/pentaho/di/trans/steps/dummytrans/DummyTransTest.java#L58


This will break setting of patterns. I'll propose a different way.


Emacs complains that it doesn’t know a function “line” here.  Am I missing a dependency?


yeah I checked all `erase()` calls in /pvr and /epg another time to be sure that they're all correct, and found some nice ones like this. must have been an idiot who wrote this! ;-)


Yeah, it is annoying that networkx doesn't provide functions for testing membership of nodes / edges.


I wanted to be extra sure...


hurray to icons in the ide ;-)


LOL. Sorry, but that's funny :trollface:

I'll try, but I can't promise I'll remember to not use my name in the future.
Does this happen to you a lot?


    except CalledProcessError, e:
        fail_msg("Failed to validate OSTree repository {0}: {1}".format(configurl, e))

So we capture the exception text too would be good.


:+1: Agreed.


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2229](http://teamcity.monogame.net/viewLog.html?buildId=5664&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Got the tests working on travis. Seems we have an error for `TestBelongs`: https://travis-ci.org/web2py/pydal/jobs/53994690
I'll wait you to fix this before reviewing the imports.


[`npm` is not found in path](https://github.com/saltstack/salt/blob/develop/salt/modules/npm.py#L25-L29), hence the failure...

Got a clue why @aboe76 ?


Yeah, React doesn't like root refs anymore. We can do it without the wrapper, but it seemed more straightforward and perhaps clearer, to wrap it rather than call `ReactTestUtils.findRenderedComponent` a bunch of times. If you'd prefer that i can switch it.


@beledouxdenis
This commit & merge generate a huge regression.
You cannot require:
* to not (re)compute storable computed fields of a record being created in a one2many field, and in the same time
* to continue to check strictly security rules at the end of its creation
... maybe some security rules depend on such (related) storable fields.
Many thanks to review this new approach.


dow!


New code ignore 10 or 12 mm Z rods.


I am afraid that is my dogfood ..


Should be // FEATURE_PAL


Yes, I'll remove the file, and add it to the `.gitignore`.


saw approval from zeeshanlakhani
at https://github.com/basho/riak_kv/commit/8fc9938b0bf31ecb5ef41b8f9031c1595ebd01f1


merging basho/riak_kv/feature/jrd/index_hashtrees = 8fc9938b into borshop-integration-1088-feature/jrd/index_hashtrees


basho/riak_kv/feature/jrd/index_hashtrees = 8fc9938b merged ok, testing candidate = 404619cb


Why are these so loose?  We shouldn't have this kind of stuff in straightforward tests like this...


@aboe76  the [nodejs-0.12.0-63.1.x86_64.rpm](http://download.opensuse.org/repositories/devel:/languages:/nodejs/openSUSE_13.1/x86_64/nodejs-0.12.0-63.1.x86_64.rpm) package does not include npm...


It seems the autoloader is not registered. Did you install cake according to: http://book.cakephp.org/2.0/en/installation/advanced-installation.html#installing-cakephp-with-composer


@jthelin It doesn't look like this was the intended place to add comments, but in any event, the changes are to be seen at https://github.com/dotnet/orleans/pull/204/files.


You didn't introduce this, but this is another survey for reservations vs. survey for event bug: the URL for this `href` should be different depending on how you arrived at / submitted this survey


OK, I will!

But as it's a Java7 feature, does it mean TestNG dropped the support of Java6 and before?


on suse you need to install with npm install -g bower, to have /usr/bin/bower


That looks good.  Does it still work?  It would be nice to have spec tests.  Maybe we can learn how to do specs together.

Can you change those line endings back to remove the clutter from the PR?  The easiest way to do that, IMHO, is to install my package `git-diff-popup`, and then undo the diff on each line needed.  Maybe if you know git better than me you can do it a different way.  Then just push your PR again and it will change here.


If 10 or 12 mm Z rods then side holes too near to linear beraing support.

New
![1 0 7](https://cloud.githubusercontent.com/assets/329586/6605212/2b62bb8c-c83f-11e4-81f7-6d8b524296b2.png)

Old
![1 0 6](https://cloud.githubusercontent.com/assets/329586/6605218/3675e210-c83f-11e4-85de-70ea66a40dd0.png)

[Look at interactive old version](http://openjscad.org#https://raw.githubusercontent.com/smartfriendz/smartcore/d1400bbdef29c651c9301244aed9ee33151a53f4/sources/openjscad/smartcore-v1.0.1.jscad)


The initial problem is the missing `npm` binary... look at the 0.12.0-63.1 rpm contents...


There is an errant h2 here.  example below

```markdown
Many thanks to [RethinkDB](http://rethinkdb.com) for permission to re-use their CLA!
h2 Terms of the Agreement
```


Back porting some of these ideas into chrisfried:reorganizing, for my own personal use until the Angular port is functional if nothing else.

![Uploading Screenshot 2015-03-11 12.40.31.png . . .]()


Or is `npm` a symlink of some sort created at install time?


a named, constant lambda is also known as a method :D


yes npm is provided with the package npm, that what the sls was installing.
pkg.installed npm


we can remove this now


Good addition!


shall I go to irc?


Should you add something about the fact that it's not just between opponents but also: 'amongst all instances of the Darwin class in the tournament (in essence all members of the Darwin class communicate).'


heh, need to start my own client, but I guess it's better ;)


I wonder - do we need to have this `#if` here? Can't we assume that it is always present on Apple here?
And a nit - if you keep the `#if HAVE_SYSCTL`, it would be nice to move the size variable inside of the `#if`


Maybe I wasn't clear. I meant most of lens won't conflict with anything (`foldMapByOf`, `<<<>=` etc.). I've updated the list with possible conflicts with other libraries (http://lpaste.net/124451), there are others but I think these most of the most used ones. I think I'll exclude these too.

I'll still make a `Diagrams` module for just diagrams things.


useless type casting since Reason is also SellResult, as a msg


@MaruthiPrasadA

Please give the latest commit a try.

I did a more thorough review of the sandbox integration and made some changes to better accommodate the sandbox API endpoints.

Please rebase/pull again recompile.

Also, please run the integration test in `Coinbase.Tests\IntegrationTests.cs :: integration_test_create_button()` using your sandbox API key and secret.

If the test passes, then everything should be functioning. If not, then I think there is a deeper problem with your Proxy setup. I've just run the integration test with my sandbox api key and secret and the output is a valid sandbox checkout URL.

Please let me know how it goes, thank you.


I wonder if we can set the actual art type now instead of `OTHER`


Yes, will do.


Is het nog gelukt @BianCionaa of ben je er niet mer aan toe gekomen?


you forgotten to set default value to Reason


Thank you. I really appreciate the work you are doing here:-)


This might help: https://i.imgur.com/BugAoJC.jpg

It seems that GetStatus() == 1 if it is active, and 0 if not active (either completed // not on the event list). Probably just need to loop over and if the GetShortDescription() is the Defeat Dreadpage Ohmna thingy and GetStatus() == 1, enable the module.


I don't think I have nearly enough Haskell experience to be very productive if we go with Haskell. I imagine you feel much the same way about Scala, so Python is probably the best middle ground..


Also, there shouldn't be any need to change any of the code now.

Just create a `var api = new CoinbaseApi(key, secret, useSandbox: true)`

Revert any changes you've made thus far; the API should take care of the rest and have a valid rebased URL to the sandbox API.


With that said, I'd love to learn Haskell...


this should really be:
notifyStatusMessage(getHumanLabel(), "Complete");


TeamCity MonoGame :: Develop (Win) [Build 3.3.0.2229](http://teamcity.monogame.net/viewLog.html?buildId=5664&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 444, ignored: 6 Build time: 00:14:09


Good catch. Thanks!


size of ObjectGuid is 16, not 8, so 16 + 16 + 1


Well, maybe I should just revert this check. If the method name you used didn't actually exist on the channel then it would've failed fast with an error anyway.


I don't think we can say that a livecd is stateless. Consider the case that the livecd is booted, loaded with some sensitive data, and left running.

Assuming the system has not been powered down, there may be sensitive information in RAM that you would want to protect some (untrusted) person with knowledge of the default password from accessing.


I'd rather switch it.


I'm on it.


I'm in #salt-devel, `s0undt3ch__`


Nice job! It's still better with a README! ;)


rax retry tests


Full path of server.conf will be useful here I think. `/usr/local/gateone/var/server.conf` if I'm correct.


Should be fixed on `master`


This is undesirable when the main logger uses a formatter that's inappropriate for `STDERR` - e.g. logging to syslog without trailing newlines.


ah, thanks will fix


I keep getting an error that the repo object doesn't have a commits method.  I don't see the method here either: https://github.com/gitpython-developers/GitPython/blob/master/git/repo/base.py.

```
tdhopper@~/repos/qadium/datamicroscopes/common (ds-build) [master] $ pip install .
Processing /Users/tdhopper/repos/qadium/datamicroscopes/common
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/var/folders/3y/5xxk9vkn6rj17zp77pxl9z100000gn/T/pip-yyZ43X-build/setup.py", line 79, in <module>
        sha1 = get_git_sha1()
      File "/var/folders/3y/5xxk9vkn6rj17zp77pxl9z100000gn/T/pip-yyZ43X-build/setup.py", line 27, in get_git_sha1
        sha1 = repo.commits()[0].id
    AttributeError: 'Repo' object has no attribute 'commits'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

      File "<string>", line 20, in <module>

      File "/var/folders/3y/5xxk9vkn6rj17zp77pxl9z100000gn/T/pip-yyZ43X-build/setup.py", line 79, in <module>

        sha1 = get_git_sha1()

      File "/var/folders/3y/5xxk9vkn6rj17zp77pxl9z100000gn/T/pip-yyZ43X-build/setup.py", line 27, in get_git_sha1

        sha1 = repo.commits()[0].id

    AttributeError: 'Repo' object has no attribute 'commits'

    ----------------------------------------
    Command "python setup.py egg_info" failed with error code 1 in /var/folders/3y/5xxk9vkn6rj17zp77pxl9z100000gn/T/pip-yyZ43X-build
```


I agree with you. It's good security to force a password change. I'll remove this brancyh.


that generator is pretty outdated, lets build on `0.12` and ditch `npm install npm` which was needed for `0.8`.


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/3476/console to remedy the problem.


This should actually be:
Tasks = new Meteor.Collection("tasks");


Initial dirty mockup screens


I agree


This might break the failed count as well. Yet to test extensively.


Of course, thank you. Fixed.


Initial boilerplate project


Fixes #4


You don't need to send an update, it doesn't mean anything. The only thing you can send to this page is a `length` for how many status updates you want, and even that is overkill (it'll send 20 by default).


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/897


DragNDropBCLHVAC (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2093 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.83%25-yellow.svg)


Jay had linked it, and it looked rather slow in comparison


True, but sometimes they just slip through.

I have to force myself really hard sometimes to not instantly clean code the moment I see it. And then there is also the problem that you seem to have multiple different styles in your codebase.
You don't want to see my local `my_nuclear_reactor` branch.


Thanks. When the rebase was doing the zipping, I thought that this was the most up to date code from the csc dir making code.


really ? how disappointing :(


aa


+Aims Community College
+Ruby on Rails Language: Software Development of Web Applications


Yummy coconut


Just curious, what made you adding the callback? Could you add this use case to the commit message?


![bg2](https://cloud.githubusercontent.com/assets/9778300/6589106/ed6a77fc-c7d5-11e4-863c-bf2b2b58a0d0.jpg)

![snake](https://cloud.githubusercontent.com/assets/9778300/6589107/ed6f658c-c7d5-11e4-96de-9b9699032ed8.png)
![apple](https://cloud.githubusercontent.com/assets/9778300/6589108/ed948236-c7d5-11e4-890f-6700f4e86e2d.png)

this update is for the sounds and graphics.


Views vs View controller:
Views are objects that are visible from the interface builder and visible to users.
View controllers control views and handle the communication going to and from each view.

Outlet vs Action
The fundamental difference seems to be that we can use Outlet to allow the view controller to talk to views. We could, for example, change something that the user sees such as a font color through an outlet.
An Action by contrast allows us to learn about events which occur on a view object. For example, if a user presses a button, we would use an action to write a method for that action.

Class vs Instance
As we learned earlier, a class is a blueprint from which objects can be created. Any time we create an object from a class, that is an instance of the class. When we create an instance, we can expect the behavior of the object to be similar to its class object, but the data would differ.


Git test am980859


@nirvdrum Yes, we have discussed it and I have a pull request almost ready (with the rubinius code). Thank you for revert it and apologize for the mistake.


Note before this change we found that we would get exceptions during the join of the Logger threads during our disconnection and deconstruction of the SessionWrapper.


@mgaunard Are you against SFINAE-friendly result_of?


ICSSolarCollector_#4723 (Nigusse) - x86_64-MacOS-10.9-clang: OK (1647 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This was not necessary for the reshout problem this just solves an n+1 problem


Great!


these icons are ginormous


aha! there you go. this is what I was talking about :) :+1:


http://jsperf.com/polymer-vs-object-observe/6

took the first one that I found, but indeed does not look that good ;P


Nice helper method, but probably want to use ruby conventions for your method names to be `snake_case` vs `camelCase`.


Careful, don't leave `binding.pry` statements in your code.


Hi Kapil,
    Thanks.  I'll fix that: 2.4.0-rc1.  There are a whole lot of loose ends
that I'm trying to tie up.

By the way, in fileconnection.cpp, I discover in FileConnection::refill()
that the file should not be refilled at restart time.  This happens
after a process migration, and there is no such file on the destination.
It happens when migrating a Java process (the dmtcp-forum e-mail from
Eliot Moss).

In this case, I can make sure that FileConnection::refill() does not
refill the file.  But I also need to close the open file descriptor
associated with that file.  Is there a way to do it directly
in FileConnection::refill() (and before the code reaches
Connection::restoreOptions() in connection.cpp)?

If not, my plan is to set some flag on that file object in
fileconnection.cpp, and then close _fds[0] in restoreOptions().
But I don't know if this is good style.

Thanks,
- Gene

On Tue, Mar 10, 2015 at 05:25:19PM -0700, Kapil Arya wrote:
> This should be 2.4.0-rc1 (see https://github.com/dmtcp/dmtcp/wiki/DMTCP-Release-Guide and http://semver.org/).
>
> Also, for future, let's not mix code changes with version/release changes :-).
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/dmtcp/dmtcp/commit/dd7a4b7a5c31d1af616596a82298f287f3e6b187#commitcomment-10132620


fast-forwarding develop to borshop-integration-1088-feature/update-dependent-libs = 8deec023


so, why del this file?


DragNDropBCLHVAC (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I assume `n` is supposed to be the number of fibonacci numbers returned. I see in your test you are asserting `ten_fibs` by passing `n=11`.


@247webdev Any progress on using this in the controller yet?


This function doesn't need to be a method of `class TestRecursionVsIteration`. Instead it can be just a top level function in this module. One heuristic by which to decide is to see whether you ever use `self` inside the function. In this case you don't.

HOWEVER, for tests, it's good style to use `self.assertEquals` or the equivalent, instead of raw `asssert`. So I take back what I said.


While '... import *' is okay in tests depending on culture of the team, for the sake of building up good coding style you should explicitly import the functions you are testing.

Another way to say this is never to use `import *` if you can help it.


Made file slightly more human readable.


All good.  I am appreciating your fastidious attention to detail, and I'll follow this pattern in future coding.


Thank you.


This was corrected on a later commit.


This was just corrected. I will push shortly.


No problem.  I just wanted to make sure I didn't misunderstand.


All good.  Glad to see your additions to the XML-doc -- they need your excellent understanding of it.


Let's create a separate issue on github to discuss this. The file connection code is quite complex (someday we should simplify it :-)) and so I would prefer doing a code review before anything is merged in there.


I don't really understand this based on the commit message, how does making these getters allow me to "extend"?


I hope there is a corresponding `100_percent_test_coverage` branch. :-)

Yes, there certainly are evolving styles in the code base. Since this was only my second non-trivial Python project, I started off trying some aspects of PEP8, but I find many of the indenting rules ridiculous and rather hard to read.

In the case of PRs, it makes them much harder to review, slowing down the merge process since I have other projects going on also. I just figured I'd let you know for both of our sakes.


would it be better to just disable it, so the color and structure name is always visible?


Good.  m_commandPipe is certainly clearer than m_cpipe.


Could you explain the significance of this change? According to TeamCity's own [documentation](https://confluence.jetbrains.com/display/TCD9/Custom+Chart#CustomChart-DefaultStatisticsValuesProvidedbyTeamCity), the keys are the ones you changed in this commit.

| Key                                                  | Description                                                                                | Unit                       |
|------------------------------------------------------|--------------------------------------------------------------------------------------------------------|----------------------------|
| CodeCoverageB                                        | Block-level code coverage                                                                              | %                          |
| CodeCoverageC                                        | Class-level code coverage                                                                              | %                          |
| CodeCoverageL                                        | Line-level code coverage                                                                               | %                          |
| CodeCoverageM                                        | Method-level code coverage                                                                             | %                          |
| CodeCoverageAbsLCovered                              | The number of covered lines                                                                            | int                        |
| CodeCoverageAbsMCovered                              | The number of covered methods                                                                          | int                        |
| CodeCoverageAbsCCovered                              | The number of covered classes                                                                          | int                        |
| CodeCoverageAbsLTotal                                | The total number of lines                                                                              | int                        |
| CodeCoverageAbsMTotal                                | The total number of methods                                                                            | int                        |


@oysterkwok 求example~我只是觉得这么写着比较好看。。。


I actually tried that both ways.  Just didn't bother to commit without.  Same error, and I've seen that in JavaScript before.  :P


@paulp I bet I'm going to regret this at some point


Not sure what else to do though, given that decodedName is still giving me mangled rubbish


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2170 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.36%25-yellow.svg)


Looking good. Should we update the  Mac / Windows instructions too?


Awesome idea! Never though of adding an uninstall script.


All good.  This optimization only makes it leaner code -- always desirable.


Weren’t there a lot more packages?


コメント機能を追加。


You should write tests for 'getPossibleMoves' function. Based on the coverage report, the function is not tested at all.


Might want to strip `stdout` before passing it along, it has a tendency to prefix with a newline.


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - i386-Windows-7-VisualStudio-12: OK (1649 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


Yes, in a couple hours' testing, the patch seems to have corrected the volume-creep-up problem.
Thanks.


You didn't pass all self-written tests. One case failed out of 9.


CalcFibはパフォーマンスが再帰を使っているので良くないですね。
複数呼ばれた際のメモ化も検討して欲しいです。

@heroyctさんのGetFiboはAPIとして取り扱いにくいです。
フィボナッチ数が指定した数だけすぐに計算されるのは無駄が多いと思います。
APIの利用場面次第ですが遅延実行の場合のほうがより多くのケースをカバーできると思う。

あと、yield returnが可読性を下げているとは思えません。


再帰呼びだしと、即時計算がパフォーマンス的に問題


@englercj I really need to get my PR act together. I can try to get to this (and the other one I textually committed to) in the next couple days.


Yep, but I have the on my "headless" Laptop and can't fetch them right now, because I don't have a HDMI cable. So I'm going to add the rest the next time I'm at the lab.


So the reason for the Helper.FirstCopy tag is for Class Abilities that get bootstrapped multiple time to the class.  Because "each" time it is bootstrapped will mean multiple fires of the script logic.  But sometimes you only want the First instance of the Class Ability to add a "bonus".

Take a look at the THIRD example in this post on the forums I did and you can see Helper.FirstCopy being used:
http://forums.wolflair.com/showpost.php?p=204722&postcount=58


Show! Estou atualizando


I have plans to add tower lean to the simulated annealing process. That will make it run somewhat slower, but should provide better accuracy in the XY plane.

When you run G32 [OPQRS] (simulated annealing), it will save the settings the next time you send M500. When you run G31 A ("autolevel") it saves the depths to the SD card, but you still have to type M500 so it'll remember to enable it the next time the controller boots.

I haven't found it necessary to recalibrate after each print, even with scraping - I routinely wash my borosilicate plate and reinstall it, and the calibration still holds. Whatever glue is on the surface is thin enough that it won't matter. If your plate doesn't have any watercut logo or other etching on it, you might want to mark it somehow (maybe a tiny line with a glass cutter) so you can see how it's supposed to be oriented, and which side is up. Reinstalling it the same way should correct any such issues - if not, you might want to get a borosilicate plate made specifically for 3D printing. If it's just oven glass like I used to use, it might not be quite as flat.


88621024-ElectricLoadCenterStorageBattery-Crash (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1651 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


88734010-AFN-horizontal-openings (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fail


A code review is good.  But I don't even have a first version working
if I don't know how to close a file descriptor at restart time. :-(
This arose from Eliot Moss's bug report about migrating Java on dmtcp-forum.

I'm attaching a patch file of the code that I have so far.
  patch -p1 < migrate-java-fix.patch
in a _clean_ clone from github to see my changes.

The story is that I checkpoint a java app (from our test suite)
on dekaksi.  I try to restart on CCIS Linux.  The Java jvm
maps as read-only and MAP_SHARED for a lot of .jar files.  (Probably
it's shared for the sake of efficiency.)  The jvm opens a
file descriptor, fd, on each .jar file, and calls mmap using that fd.
Unfortunately, the Java jvm doesn't close that fd (even though it's
allowed to, and it would be better style to do so).

So, at restart time, we have the MAP_SHARED areas with a backing
file that no longer exists (since CCIS Linux has a different version
of Java from dekaksi).  So, I re-map the area as 'MAP_PRIVATE | MAP_ANONYMOUS'.

Now, my job would be done, except that jvm left the dangling fd's open.
So, I need to tell FileConnection::refill() to ignore these fd's.
I also need to tell Connection:restoreOptions() not
to restore the former modes of those fd's.  Maybe I can re-direct
those fd's to /dev/null, since there is no such file on CCIS Linux.

So, this gives you an approximate "code review".
Any suggestions?

[ Sorry to break my promise to give you time off from DMTCP.  Feel free
  to ignore this e-mail if you like.  :-) ]

Best,
- Gene

On Tue, Mar 10, 2015 at 07:21:23PM -0700, Kapil Arya wrote:
> Let's create a separate issue on github to discuss this. The file connection code is quite complex (someday we should simplify it :-)) and so I would prefer doing a code review before anything is merged in there.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/dmtcp/dmtcp/commit/dd7a4b7a5c31d1af616596a82298f287f3e6b187#commitcomment-10133898


Where did you get the 254?


This is a markdown document


+1 Looks good


41d5b1e3ac0e9f5a11dd9550c767654cd987fcdd Old code. Removed all lead-related functions/references


> I'd you'd still like a separate module I'd prefer to have a Diagrams module that only exports functions from diagrams for people that want that

That would also work for me.

I could have been more clear, above.  Because `lens` exports so much, I find it's common to overlap with part of `lens` I'm not planning to use.  It need not be overlap between `lens` & `diagrams`, just overlap between `lens` and some library or some name I want locally.


This schema file should not really need to be included in this [every] app that uses Orleans NuGet packages, but that is a problem with the current NuGet packages rather then this sample app.


Cool!


RowMajor (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1050 of 1058 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.24%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-67.69%25-yellow.svg)


@jorgenavas This does not look right or I am not understanding something. For example, 'not and' must become 'or not'.

If the comment is correct, a better way to implement this would be using `op::boolop::nnf (op::boolop::lneg (e))` and if nnf does not push negation far enough, create another variant of nnf that does.


Eric said that's a bug of `specs2 2.x`, which is fixed in `specs2 3.x`


@amritb Who are you?


Arbitrary


ResultsSchema (sanyalj) - x86_64-MacOS-10.9-clang: OK (1633 of 1641 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


This will work fine, but for "semantic" correctness with ND blobs, the weights should be initialized with no extra singleton axes: in the `channel_shared_` case should have the "empty" shape (see `loss_layer.cpp` for example), and the other case should be 1D (like the biases in conv/IP layers).


Perhaps this commit go first, then followed by the commit ```Fixed issue #2453: ...```?


Good use of the for each loop.


VSHPWH (shenb) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Should this be 0.0.0.0-5.0.8.0 to match the version number in the packages.config ?


should also be 1D


88621024-ElectricLoadCenterStorageBattery-Crash (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1146 of 1147 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.57%25-green.svg)


?? 이 수정은 왜 한거임? .person-thumbnail 안쓰지 않나


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


rax retry tests


Removed the hard-coded stuff here. Let's update them dynamically instead.


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


88734010-AFN-horizontal-openings (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


I also don't know why this doesn't work. should fix


scss-lint 라는 게 있어 ಠ_ಠ


Thats wired! I never made this commit.


so should I grab a new jar for Civtest?

On Tue, Mar 10, 2015 at 7:18 PM erocs <notifications@github.com> wrote:

> Does look better.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Civcraft/Citadel/commit/64bcd273a380ee415167e3c4522bf1ced3a23065#commitcomment-10132544>
> .
>


this seems odd


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


yes as well as namelayer.

On Tue, Mar 10, 2015 at 10:52 PM, ttk2 <notifications@github.com> wrote:

> so should I grab a new jar for Civtest?
>
> On Tue, Mar 10, 2015 at 7:18 PM erocs <notifications@github.com> wrote:
>
> > Does look better.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Civcraft/Citadel/commit/64bcd273a380ee415167e3c4522bf1ced3a23065#commitcomment-10132544
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Civcraft/Citadel/commit/64bcd273a380ee415167e3c4522bf1ced3a23065#commitcomment-10134157>
> .
>


I think you should have an else here


음.. 일단 width:48px을 지운 건 실수였고, margin-bottom: 0px 대신 0으로 쓴 건 @woongy 말대로 scss-lint 때문임. 지금 우리의 pre-commit (호윤이가 쓰고 있지 않은) 이, '이번 커밋에서 수정한 rb, scss 파일'에 대해 스타일 체크를 해주는데 내가 중간에 statuses.css.scss를 바꿀 일이 있었기 때문에(나중에 다시 되돌렸지만) 한번 스타일 체크에 걸렸고 그걸 수정해놓은거.

뭐 엄밀히 말하면 이 커밋과 연관이 없긴 함.


comment lines here should not end in period, nor titlecase the next line. @pyrohh can you fix that in your vim-patch.sh PR?


What do you mean?
I cannot understand it.


@amritb
Have you never this commit ?!
Amazing!!

![寿司ゆき:oh_no](https://d1zd1v0cxnbx2w.cloudfront.net/images/sets/sushiyuki/14.png)


This makes sense. I like that your code is self-documenting.


Shouldn't this be Version=5.0.8.0 like the package reference?
Without SpecificVersion=False being specified, I would actually think that Visual Studio is really doing wrong thing if it lets explicit versioned assembly name like this match against v5.0.8.0 binaries.

Even using specific assembly name + SpecificVersion=False feels more like a nasty kludge to me [bad smell!], so my personal preference is to leave the assembly name unversioned unless absolutely necessary for any compatibility reason.
For example:
``` xml
<Reference Include="Newtonsoft.Json">
<HintPath>..\packages\Newtonsoft.Json.5.0.8\lib\net45\Newtonsoft.Json.dll</HintPath>
</Reference>
```


Don't take the name from the symbol, take it from the tree. If you insist on taking it from the symbol, you most likely need to get the name atPhase(somethingEarlier) if it no longer looks like the way it was born.

Also, fromName.contains("$") is always going to be wrong, because it lumps every operator name like $plus$plus together with every name which contains a $ for other reasons.


I first did that, but in the course of running the program it will be enabled (through editor I guess). We can take a look at it later


I guess the only way to get accurate point data would be to


Why is `autocorrect="off"` dropped and `autocapitalize="off"` listed twice?


it tried to cherry-pick msm_hotplug for my phone redmi 1s but the problem is i cant get it booting once i have cherry-picked fastlane its stuck at mi bootlogo for ever i figured out this commit was there everywhere whe you cherry-pick msm_hotplug but even this did not help what m i doing wrong here ???


Looks like you misspelled "canola"!


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (1656 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@23Skidoo Why did you bump the cabal-version constraints here?  This causes build problems for me on some configurations.


I realize you didn't introduce the problem, but these DllImports should all be SetLastError = true.  If you can fix that now, great, if not we can fix it after you check it in.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/1912


forgot that I had already replaced this in a newer commit


:dancers:


This is a good start. Any idea on how to get it to ignore missing values for each column?


i got the driver unplugging the cores but it aint hotplugging the cores here is my cherry-pick

https://github.com/tarunkapadia93/android_kernel_xiaomi_armani/commits/final-new

https://github.com/tarunkapadia93/android_kernel_xiaomi_armani/commits/final-new/arch/arm/mach-msm/msm_mpdecision.c


The original is correct.  It executes no matter what, but it doesn't complete no matter what.


Boring abstract stuff to get out of the way for redesigning Renderer and multi-cam support.


I don't think this change makes sense


typo


`s/photography/pornography/` ;)


very good! U r a genius


@zeroedin-bill -- No reason, just fit in our build setup easier that way.  Good point though, maybe makes more sense to try to fit it in with the --enable-debug flag.  I'll add to our backlog to review this for our next release.


I can't tell what you've changed.  This file needs to be updated to be compliant with #1028 so that I can read it.


This comment now redundant? (blame me)


Only thought is that "map is undefined" will be less useful than a message you write.

-------- Original message --------
From: Wyatt Cready
Date:03/11/2015 3:48 PM (GMT-05:00)
To: "NGPVAN/amqp.channel"
Cc: Todd Ogin
Subject: Re: [amqp.channel] Make sure we handle consumption of `null` messages (8802d8c)

Well, maybe I should just revert this check. If the method name you used didn't actually exist on the channel then it would've failed fast with an error anyway.

—
Reply to this email directly or view it on GitHub<https://github.com/NGPVAN/amqp.channel/commit/8802d8c8b05b38b0554283fd3dfd64b8d5d68577#commitcomment-10150838>.


True. Some developer/tester docs need to be added to my pile to explain

* What boards can be used/should be targeted (and what this implies for tests)
* What magic pytest stuff is going on


Everyone reading this is reading this, so this intro is superfluous.


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1146 of 1147 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.57%25-green.svg)


I'm reading about gradle plugins, and I'm not sure that this can be used as a way of doing:
```
if ('idea') then ...
```


WinEquivalentLayer_#4625 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The python b64 decoder does not deal with edge cases.  It raised exceptions decoding b64 from Turtle and decoded it incorrectly in other cases.  The base64 command is much more robust.


Well, you and @Bertram25 know better this than I do so I will follow your judgement on that. I would just say that the less libraries, the better ^^


You need to make your text compliant with #1028


Any reason this was set to 15?  Default is 5 if KeepAliveTimeout is not set, according to apache 2.2 docs. https://httpd.apache.org/docs/2.2/mod/core.html#keepalivetimeout


r+


I think you can send a boolean instead of a string


It would be better if you use the repo created in lab1-git as a base.  That way we can just link to that location, and the user knows exactly what to do.


C'est "fibonacci"  plutôt  que "fibonathier"


Why did we just create a blank repo if you're using something else as an example?


awkward


anything verbatim should be in backticks; you almost never want double quotes


nice


We actually have a custom field calls skills in NB.  I was thinking we should put this there.


This can safely be changed to just `path.normalize(result.file)`.


Баг пофикшен


You never explain what tracking is


saw approval from jdm
at https://github.com/ienzam/servo/commit/6d13361c64fbd1d13ee97821929a616bfb4e29ed


merging ienzam/servo/force_relayout_cleanup = 6d13361c into auto


ienzam/servo/force_relayout_cleanup = 6d13361c merged ok, testing candidate = 7b6e314d


Have I misread, can you apply the decorator to the class?


This is duplicating material from lab1.  Again, it would be better to improve the lab directly than to have the same material in two separate locations.


WinEquivalentLayer_#4625 (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Close #25


makes no sense


This should not be a quotation, it should be a verbatim code block


You could however not all the tests here need to be done after the power-cycle (plus you'd have to move the power-cycle test out of the class otherwise you'd get a cyclic dependency).


This is actually wrong, even though all of GTK+ uses it. The return value is not const.


`maintainer` and `maintainer_email` are now required for uploading to cookbooks to hosted Chef.  That is the likely source of these bugs.  The starter kit you get from hosted Chef should now include both of these fields.

However, I agree that pulling this cookbook out of the repo is the right way to go.


Yes, it needs to default to empty for now, so that we don't break existing clusters.


Aw rats! I was looking for a way to specify the key for the message, why did this get removed? It looked like the only way to specify the key for the messages


hm, i guess since we can never actually get to fail: unless fp = calloc() passes, i won't complain about losing the check on fp != NULL...   :+1:


what do you think about this @aldenml

the if above is there to throw an exception.

the if he removed, was to explicitly execute code when data!=null, which would happen on the else.


I guess that's why they say to never write code you can't test :)


not everything that's not a file is a folder. You must consider symlinks, devices, ...

however, both conditions end up on the same holder...


Something like this:
`temp <- data.frame(question=df[[input$questions]]) %>% filter(!is.na(question))`


Not able to do what you are saying? How is it possible to get away with not try/catch -ing the Exception. My Compiler gives an error.


This is unnecessary, since the paths get fed through `htmllint` which does the same thing.


This currently needs to match the master's path. However, we are planning to eliminate direct access to etcd in Kubelet. Not sure what the ETA is for that. @erictune


Any discussion of merge tools would need lots of pictures to be helpful.   My first impression of this section is that it's a distraction from the important essential components of git.

But I'm probably biased because I've never found merge tools helpful in my workflow.  I'm willing to be convinced otherwise.


@valib works great, thanks!


You're referencing this PR as an implementation of #5. But your implementation differs significantly from the ideas laid out there... Notably adding an argument to the function but not implementing the `precompile` boolean argument and the fact that you left the rendering engine `template` on the Module prototype.

Some other nits are:
- it should be `x-mod-template`and `[type=text/x-mod-template]` should be the default selector. KISS
- it should be `data-name` not `data-template`
- Use a proper loop instead of the more expensive `$(selector).each`. Don't be lazy. ;)
- Generally speaking `$.method(selector)` is faster than `$(selector).method`

I like that you can pass an object to register templates. IMO this should be the only way to change the default of scanning the module markup, thus the arbitrary string arguments are not needed.


I would just add a case block here. Then in `process_flags/1` have the exit clause return the atom `:exit`. In the case block check if the return value is equal to `:exit`, if it is, do nothing (the main function will return immediately), otherwise continue executing the remaining code in main.


Your asterisk is messing up the formatting because that's a special markdown command.  This is one of the reasons why all verbatim text must be in backticks.


Is that the error you get? I figured it'd be something like "someMethod is not a function". Either way, you're probably right. I'll throw my own error.


Hey! If you're running into issues with `railtie.config.eager_load_paths.reject! {|path| path  =~ /app\/overrides\z/ }` we just figured this one out. Deface doesn't work alongside some gems, (dotenv-rails) in our case.

If you're using dotenv-rails, we just switched to [Figaro](https://github.com/laserlemon/figaro), and now our app starts up.

cc:/ @bsima


I'm happy to have it do that if you want. It's a pretty open-ended question the way it appears on the form, though -- responses my not fit `skills` field very well


You haven't discussed fast forward merges yet.


we actually need this log here.


please revert this change.


what?


Same problem as well. Whats the current solution? Roll back to version 2.5.0?


Your explanations are getting much too sparse as the document goes on.


Doesn't look correct to me!


:grin: It's being used in the modules extended onto the connection. I felt like this is a straight forward way to reuse it. What's your suggestion?


Needs much more explanation.


Lets bring back in your old example and keep the newer one too. Shows usage in function scope and just with defining object literals globally. Sound good?


The code you see here looks unnecessary, but it gives us flexibility for what could change on all the different OSes.

Unsure if we should revert...

what do you think @aldenml


Yes it works. Thnx Thnx Thx
This was the problem. I have registered autoloader and is all OK, but when
i login into my paypal account a click continue sand me an error
Error: PayPalPaymentController
could not be found.
*Error* Create the class PayPalPaymentController below in file:
app\Controller\PayPalPaymentController.php

Plugin has all the Controllers in Plugin/Paypal path.

On Wed, Mar 11, 2015 at 8:37 PM, Gerd Katzenbeisser <
notifications@github.com> wrote:

> It seems the autoloader is not registered. Did you install cake according
> to:
> http://book.cakephp.org/2.0/en/installation/advanced-installation.html#installing-cakephp-with-composer
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakito/CakePHP-PayPalRest-Plugin/commit/2d58063066907e8e1a7a5455b8c1f6427582c9a9#commitcomment-10150604>
> .
>


What is a fluent interface?  Is this terminology I should already be familiar with?


Thanks! :+1:


`justify` -- sorry, didn't see this commit earlier


@donileo Yes, rolling back to 2.5.0 resolves this issue.


This assert is actually no longer correct,

entry used to be initialized to NULL
*entry has no such initialization or guarantee


Test comment


Ça fixe quoi ? Le `&` permet d'avoir grunt en fond et un serveur HTTP en même temps.


The second one is good, already forgot that the first one only applies for `if`'s.


The sentence is bad either way.  I'd be more inclined to accept a pull request that completely rewords it.


Would `def self.is_referential_integrity_slq(sql)` not work? Or could move it to `ConnectionHelper` without the `self.` part, and classes including it will have it available.


Yes!

On Wed, 11 Mar 2015 19:27 Arthur Verschaeve <notifications@github.com>
wrote:

> @addyosmani <https://github.com/addyosmani> Isn't this meant to be New
> since 1.3?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tastejs/todomvc/commit/935aed054725ecb26c4862fa7d0fa309b79d3140#commitcomment-10150439>
> .
>


seems like the best option. I'll add that in the runtime


Please, write more descriptive commit messages


this comma is incorrect


I am using prepared statement to write data in to SQL table


Since OdcmType is not using Global, should it be the owner of the property?


This does not look like a clean solution.
Perhaps create a separate listener for the refreshContent?
That would make the source code easier to read.

What are the different GatePlayerWalkType values?
Are there two or more?
Does it matter?
Maybe check if event.getGateTo() is null and act upon that instead?


This looks really good now :smile_cat:


Which error?


updating it :)


We should revert, the folder happens to be the same, but the logic is about having it different (or not) by OSes.


This fix was already merged in another pull request. Thanks for catching this. :-)


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1146 of 1146 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.64%25-green.svg)


How so? This is the command not the response...


TeamCity Akka.NET :: Akka.NET PR Build [Build 134](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=229&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) is now running


very nice refactor :+1:


This method could use a more descriptive name.
It has to do with portal blocks only and fixing those.
The word "portal" should be in the method name?

refreshContent looks vauge and does not sound like it has anything to do with portal blocks specifically.


Oh actually... why the extra `(` and `)`?


Inside that putRow() call, it tries to clone the (mocked) rowmeta, but that method was not defined on the mock, so it returns null, which causes the issues. I believe this to be fixed in #1093


remove duplicated routes


Fixed in https://github.com/tastejs/todomvc/commit/804c524774d23aa036404840aec56df769a9366c.


I bet we do this `new String(text)` for a good reason, like not sharing the same filtered string across all the different searches.

please revert this one.


my game manager used to rely on this broken behavior as well. I remember changing my code to use CAddonMgr instead of CAddon::Enabled()

what if CAddon::Enabled() forwards the call to CAddonMgr?


Uncaught Exception


The annotate the method that it's now throwing the exception


You are correct - my bad!


^this

empty class, empty methods.


Python 2.7+ in fact as I'm using [Dictionary Comprehension](https://www.python.org/dev/peps/pep-0274/)


Partial notes can be null. The student can take the first partial exam and owe the other two, for example


Hmm. I can't quite remember exactly which link I clicked on this morning to get here, but I think it was the one in my "notifications" inbox on the GH site.
It definitely gets me to different place than clicking on the link you refer above!
Guess i'm either a GH noob or i'm somehow good at finding alternate click flows that break things ;)
I'll merge the PR and we can do any other cleanup down stream....


hardcoded path. GJ.


Did you change something in this file or is it just the whitespace thing ? (I'm really sorry about that, I'm gradually fixing that problem in my projects).


I see that I forgot something: we do need a copy of tags in some situations. Or at least of it's values. The reason is that you don't want to actually update the tags in dialogs until the user actually wants to persist the changes. So we have to re-add some copy ctors. Will look into it later. But because of that, we do need some of this "nonsense" ;-)


r+


`extra-doc-files` requires `cabal-version >= 1.18`.


good to say - this will run everyday at

```1 am + random(120 minutes)```

and will output a log to ...path to log...


would be good to have a one or few lines description saying what that script is about.


da uma olhada na função require


looks promising
So, no Travis integration.. are tests still passing?


This line is most probably not necessary as the `org.ow2.asm` package is already an OSGi bundle and embedding it would cause problems when that dependency is also used. (BTW.: Updating to a newer version is a much nicer way to solve this OSGi problem.)
Thank you.
PS.: I hope to find some time to check these new changes this weekend. It would be nice if jayway/JsonPath new version could use this version.


save_and_open_page should never get checked in. Please remove it.


Just whitespace.


found the bower path:
/root/node_modules/bower/bin/bower


Given the issue @bdero identified at https://github.com/jazkarta/edx-platform/blob/5f28dfc2ea6fd5bde87f3d58215a9d96f045d6c1/lms/static/js/ccx/schedule.js#L108-L186 making this a transaction is going to make the race condition worse. The first save_ccx will block any subsequent ones, causing more of them to fail.


You can tell github to omit whitespace in a diff with ?w=1: https://github.com/whitequark/tgls/commit/26c0807426d34f12dfd83138b577abcc2e72f58c?w=1#commitcomment-10151726


The tests still pass. I'll add some unit tests. Though, I wanna show it to you guys first before you guys tell me "stop it, david. stop it"


Forgive my ignorance, but how will Travis know how to match Python 2.6 with `requirements-python26.txt`?


Please, write more descriptive commit messages. Also try to use unique messages.


yup. https://www.youtube.com/watch?v=VrAjPXykbXA


Hi!

Does this more generic fix https://github.com/kisli/vmime/commit/1b964969c53c5f17cd38014086a0beebe635b6ca resolve the issue?

Thanks,

Vincent


Typo: s/actication/activation/ in a few places.


Can we put that file in extra-source-files?


não precisa dessa variável, coloca o var no construtor da classe


size is incorrect. Size of ObjectGuid is 16 bytes, not 8 bytes


Actually GettableData wasn't useful for me, I had to come up with a solution to iterate over all the variables of a given statement. Is there any easier way?


Nice commit


TeamCity Akka.NET :: Akka.NET PR Build [Build 134](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=229&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: xUnit failed for the following assemblies: D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Persistence.Tests\bin\Release\Akka.Persistence.Tests.dll   at Microsoft.FSharp.Core.Operators.FailWith[T](String message)   at Fake.XUnitHel... Build time: 00:12:47
### Failed tests
```
Akka.Persistence.Tests.dll: Akka.Persistence.Tests.PersistentViewSpec.PersistentView_should_check_if_incoming_message_is_persistent: <no details avaliable>

Akka.Persistence.Tests.dll: Akka.Persistence.Tests.GuaranteedDeliveryCrashSpec.GuaranteedDelivery_should_not_send_when_actor_crashes: <no details avaliable>

```


No I am not happy now :8ball:


"Discourage" makes no sense. pcap2john.py does indeed use it to tell us something about the sniffed C/R.


yeah, it's a bit sketchy, but this method will only ever be called after the getStrategy method returns successfully. You're right though... maybe I'll just do .getOrElse(throw Execption) ?


I'm embarrassed by the initial position of this call, which was at the very end of this method: this would lead to a situation where a retried query would be logged _before_ the initial one, which is weird, so I moved it to the beginning of the method - of course now this means that we need to be sure it would never throw an exception.


da uma olhada na função require


TODO: Here the closure should be verified


By default this is false currently.


it makes you commit when you change it.


compara primeiro se é null e depois se contém na lista


Why not a simple boolean?


use html.erb or plain html.
don't use pure erb for html views


There are actually three GatewalkTypes. In GatePlayerWalkType.INTO, the value for GateFrom is null, thus we shouldn't execute anything on it. Same goes for the other two.

Having it's own listener is surely an option. I suppose a normal null check will suffice, yes :)


da uma lida sobre string interpolation em scala


Oversaw it and deleting it now :)


Oh ok yeah I've had a problem with that in the past. I'll see if I can fix it up. See issue here - https://github.com/WestonSF/ArcGISDataToolkit/issues/8


:cry: Thank you very much for the excellent job you've done on this project :bow:


never use the word 'swag' again


really sorry...


Looking through this again, I think it would be better to use the unminified versions of files like this. That makes debugging easier, if we every have to trace into jquery (or other libraries) and we are going to minify it anyways. That is, unless there is some significant difference between the minified and unminified versions.


Please do not check in Thumbs.db. Add them to .gitignore to ignore them.


@Montellese this whole commit can go now as i have merged the unification ...


Yes. Specifically, it should be {{ route('songs.index') }} because songs is a "resource route" http://laravel.com/docs/5.0/controllers#restful-resource-controllers


Naming this is harder than I thought. What about recalculatePortalOrientation? Or refreshPortalOrientation?


Ooohh, I didn't see his post. Yes, I'll update your grade!


yep, agreed.


嗨,

hjwdzh@gmail.com 想關注您

****** hjwdzh@gmail.com 是您的朋友嗎？ ******
好/是: http://invites.infoaxe.net/signup_e.html?fullname=Hjwdzh/physbam-drive-pc&email=reply@reply.github.com&invitername=hjwdzh&inviterid=37132591&userid=0&token=0&emailmasterid=ef5a4e35-122d-44eb-9056-8dc7a61e5ae4&from=hjwdzh@gmail.com&src=txt_yes

不/否: http://invites.infoaxe.net/signup_e.html?fullname=Hjwdzh/physbam-drive-pc&email=reply@reply.github.com&invitername=hjwdzh&inviterid=37132591&userid=0&token=0&emailmasterid=ef5a4e35-122d-44eb-9056-8dc7a61e5ae4&from=hjwdzh@gmail.com&src=txt_no

按一下這裡，將您自己從所有這類電子郵件移除
http://invites.infoaxe.net/uns_inviter.jsp?email=reply@reply.github.com&iid=ef5a4e35-122d-44eb-9056-8dc7a61e5ae4&from=hjwdzh@gmail.com


@mightybyte It won't be copied to the haddock HTML dir if we do that. What we can do is base64-encode and inline it (`<<data:image/png;base64,...>>`).


From what I could tell, the issue revolves around how Deface loops over all of the railties and removes the path `app/overrides` from the `eager_load_paths` variable. For whatever reason, this throws an error when Deface tries to modify the dotenv railtie. (It has something to do with the classes that each railtie inherits from - I believe that dotenv does not inherit from the proper `Rails::Engine::Configuration` class and instead inherits from the `Rails::Configuration` class. This sort-of makes sense, because dotenv would need access to the entire Rails configuration, not just the engine, but then `Rails::Configuration` does not have the [`eager_load_paths`](http://www.rubydoc.info/docs/rails/4.1.7/Rails/Engine/Configuration#eager_load_paths-instance_method) method.)

In any case, @jharlan92, your solution to comment out the offending code works, however that also modifies the core functionality of deface, which is not desirable, and in fact led to other errors in our app. Our solution is to simply switch to [figaro](https://github.com/laserlemon/figaro) and it just worked.


Heya @neftaly ! Yep it's totally acceptable, and a practise that we use at Vend :). Lookin forward to seeing the end result!


Curious.  Why remove the periods?


.were with 1px false. (with -.- ) D:


Hi Guy,

There is still an issue with `moveArray` function, which I have later fixed in this commit: https://github.com/aderuwe/angular-spring-data-rest/commit/15b5caadb3d5431de9e7f99b6f79263202d4e243.

The original code used only the first key in the `_embedded` object: `var key = Object.keys(embeddedObject)[0];`. This meant that if `_embedded` contained more than one type of named resource, the 2nd to Nth types would not be taken into account by `moveArray` and would miss being processed.

In my commit I've modified `moveArray` so that the complete set of named resources is taken into account by iterating through all the keys in `_embedded` and moving them to `_embeddedItems`.

Here is an example scenario:

```javascript
{
   "progress":0,
   "_links":{
      "random":{
         "href":"\/app_dev.php\/api\/ln\/cards\/random"
      }
   },
   "_embedded":{
      "learning-entity":{
         "id":1,
         "name":"Sample A",
         "discr":"action",
         "_embedded":{
            "content":{ ...},
            "outcomes":[ ...]
         }
      }
   }
}
```
The `content`and `outcomes` named resources are both embedded in `learning-entity`. Without the change, only `content` would be taken into account by the `moveArray` function while `outcomes` would be discarded.

Can you please include this commit as well ? Please let me know if more info is needed.

Thank you and regards,
Mihai


What?!


Everything looks fine.  I'll merge it.

In the future you shouldn't do the version upgrading stuff.  The merges may not be one-to-one with the releases.


that sounds fine to me I think, unless you know a graceful way to recover from that case.


Edited description for #61943, added #56426 to 6_2-ignoreList


The second parameter should be queryOptions.isLogQueryParameters(), I will fix this shortly.


No mal echo


What could be a sensible default for this value?


I believe I understand what you're trying to say. I'll have a closer look soon to make sure, and adjust this code as needed.

Thanks a lot for the feedback!


all tests pass:
success: http://build.servo.org/builders/linux1/builds/989
success: http://build.servo.org/builders/linux2/builds/988
success: http://build.servo.org/builders/android/builds/1023
success: http://build.servo.org/builders/mac1/builds/1204
success: http://build.servo.org/builders/mac2/builds/1205
success: http://build.servo.org/builders/gonk/builds/175


I'm deferring the actual logging of different types of requests to different SLF4J loggers so that users can configure them as they wish.


Currently the log level at which each type of query is logged is not configurable. Do you think it would be a good idea to make it configurable?


I don'  know how to use 3 functions available to receive payment
notifications.

On Wed, Mar 11, 2015 at 9:24 PM, Viorena Çerenishti <
viorenacerenishti@gmail.com> wrote:

> Yes it works. Thnx Thnx Thx
> This was the problem. I have registered autoloader and is all OK, but when
> i login into my paypal account a click continue sand me an error  Error: PayPalPaymentController
> could not be found.
> *Error* Create the class PayPalPaymentController below in file:
> app\Controller\PayPalPaymentController.php
>
> Plugin has all the Controllers in Plugin/Paypal path.
>
>
> On Wed, Mar 11, 2015 at 8:37 PM, Gerd Katzenbeisser <
> notifications@github.com> wrote:
>
>> It seems the autoloader is not registered. Did you install cake according
>> to:
>> http://book.cakephp.org/2.0/en/installation/advanced-installation.html#installing-cakephp-with-composer
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/hakito/CakePHP-PayPalRest-Plugin/commit/2d58063066907e8e1a7a5455b8c1f6427582c9a9#commitcomment-10150604>
>> .
>>
>
>


Not sure about this. I'd opt for another container (e.g. a bunch of dialog members) for temporarily holding the data beside the actual tag until they are about to be persisted (aka written back to the tag). Reintroducing the "obtain the original nonsense" we just got the chance to get rid off could and should be avoided. This is so error prone...


@kohske, I've switched to C++11 in cd058a85d50030aa245230f834572ff94d0b8616
a `configure` script flag `--disable-cxx11` may be set to force using the C++98 compiler (in case it supports the `long long` type, it's OK)


está ordenado de la siguiente manera:
	turno-año-mes-dia el id de usuario no se añade a la reserva de momento


right now is probably just defensive programming. I see no reason why not to prevent a potential race condition here in the future


fast-forwarding master to auto = 7b6e314d


IT HAS BEGUN.


First thoughts:

You may want to change the values in these places/methods in the codebase:

_WorldClient.cs:_
*m_Model.Client.Send(new ReportClientScreenSizePacket(800, 600));*

_WorldInput.cs:_
*UltimaVars.EngineVars.CursorDirection = Utility.DirectionFromPoints(new Point (400, 300), UltimaEngine.Input.MousePosition);*

and

*float distanceFromCenterOfScreen = Utility.DistanceBetweenTwoPoints(new Point(400, 300), UltimaEngine.Input.MousePosition);*

...

_IsometricWorldView.cs:_

Changing the screen resolution might effect how the world renders. I'd suggest looking at

*private static void render(out Vector2 renderOffset)*

to see if this is the case.


notice that the variable is private. You have to access it through the isInitialised() method which does return a simple boolean


If you customize your cell with `cellConfig`, your settings will be overwritten once the method `update` is invoked. This change set prevents that from happening.


Hadoop:-  Modern Data Operating System

Schema on write (RDBMD)                                             Schema on read(Hadoop)
- Schema must be created before any data can be                - Data is simply caopied to the file store, no transformation
loaded                                                            is needed

- An Explicit load operation has to take place which             - A SerDe (Serializer/Deserlizer) is applied during read time to
transforms data to DB intrenal structure.                           extract the required columns(Late binding)

- New columns must be added explicitly before new data            - New data can start flowing any time and will appear retroactively
for such columns can be loaded into the databases.                  once the SerDe is updated to parse it.

* Read is fats                                                      * load is fast
* Standards/Galernance                                              * Flexibility/Agility


WinEquivalentLayer_#4625 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (639 of 639 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.22%25-green.svg)


Initial commit. Module shell


better to fetch it from input if you are expecting it there then let it return `nil`. I think It's also one of the controversial rubocop rules.


use double quotes here, not single quotes


use string interpolation here.

also, make it an actual link, ie, http:// in front of it.


Utopic uses sysv by default, and vivid too ( may be at release this can be changed ), but next ubuntu 15.10 should be used systemd


hmm I don't agree. I don't see the big deal about creating a copy and getting the one to update via the unique id + client id. Has worked fine for years, though I agree that it's nice that it's no longer needed for all operations.


yeah that's correct too it would not touch other keys but then people would write ugly stuff like
```ruby
output[:success] = true
output[:count] = 42
```
and then it's just a step from "fixing" it to
```ruby
output = {success: true, count: 42}
```
I think examples should show the best possible way.


If that works, I think that would be good.  It won't build with GHC 7.6 otherwise.


WinEquivalentLayer_#4625 (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


WinEquivalentLayer_#4625 (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks, updated.


I realize that this code could be made easier if JAVA-584 is implemented: a getObject() method would spare me the raw ByteBuffer manipulation. However we still would lack of a method that tells how many variables are bound.


@fnikitin @pamichel j'ai additioné cette fonction pour generer des random dans la base de donnée car la migration ne fonctionnait pas... regarder si ca va conforme votre format.


hm maybe just persistence? the main point is that it's persisted.


You're right. It doesn't work.


There actually is a good reason for those `compress` tags: Their cache busting behavior.

As long as we cannot use `CachedStaticFilesStorage` we should probably still use those `compress` tags.


Why should it be that?


Cheers! Hopefully I can finish it after work, though I need to brush up on SMACSS.


Должно и так работать (версия 8.0)


This is cool @DanielWright ! What did you use to perf test it?


OK, I'll do a PR. But it should work if you install a recent version of Cabal beforehand.


Whoops, sorry about that @anthonny.

On Thu, Mar 12, 2015, 01:35 Anthonny Quérouil <notifications@github.com>
wrote:

> @jaredmorgs <https://github.com/jaredmorgs> *message* is a javascript
> object and you can't define twice the same attribute.
>
> I took care of it, i'll publish soon
> I changed this code like this :
>
> content: 'Settings Saved, do not save further configuration changes until HubPress confirms posts were regenerated successfully.'
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HubPress/hubpress.io/commit/6bfc4e559cb8ac7cc8f58db9cb6c12e897da129e#commitcomment-10145077>
> .
>


uploading source code


Shouldn't this change instead be "Compensate for basis magnitudes" and maybe not include the changes in internal.h? Also, do the changes to compute_basis.c really belong here?


Thanks for the tip! Will remember that for next time. Love this peer review
activity: it lets me learn as well as contribute.

On Thu, Mar 12, 2015, 01:33 Anthonny Quérouil <notifications@github.com>
wrote:

> @jaredmorgs <https://github.com/jaredmorgs> you must escape quote in the
> string :
> browser\'s
>
> I took care of it, i'll publish soon
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HubPress/hubpress.io/commit/04dcab074f22eaafbc1d31699f09d3d314247190#commitcomment-10145003>
> .
>


Serieux ... x)


Typo in the word "corresponding."


Indeed... Seems much more flexible than the previous approach.


This is great.  Nice work sdake.  Need this to use docker-compose with kolla.

LGTM.


Let's leave the 1/3 in the recursion


What commits caused the changes? Any reason not to squash this with the earlier magnitude scaling patch?


Когда конкретно тебе нужно, чтобы сервер вернул тебе список пользователей?


@ddossot  thanks to _you_ for the appreciation (and the tweet!).

It will leave a "hole in my heart" to be sure, but I had much rather relinquish ownership now than letting it die a slow, "sclerosis" death just because I stick to it for no other reasons than "sentimental" ones.


What are all these?


I'm not sure where you think about defining the method. The modules are not included in the test-case but extended onto the AR::Base connection. See https://github.com/rails/rails/commit/0c7c6286f653b947db8a2a17c11f0c213a8d23ea#diff-229d2a073da743f7ca5214e3e9fb421fR99

I don't think `ConnectionHelper` would be a good fit. The code is very specific to the tests in these files and not reusable outside it's scope.


For a Debian type OS with `manage_package_repo => true`, this line results in `Error 400 on SERVER: Cannot reassign variable mongos_pidfilepath` (because this var is already assigned at https://github.com/puppetlabs/puppetlabs-mongodb/commit/d6f2c0266045d7a2c29b4fd65cd5d2a9438ef320#diff-2f383a197b1a428561b364755701d60eR139


Alleeeeez


...and the equivalent to this is?


Does the line above it work?? I would think that should be 780, not 760.

```
$ ./count_finder.pl 79 24 150
Found 150 of length 79  (required 161 total lines to do)
Found 78 of length 24
```


Easyyy


Pay a little attention pls kthx


A double precision divide inside the innermost loop of your MSE calculation?


ok, nevermind then :)


This line appears 6 times in this patch. Some refactoring would be nice here.


NOTE,

```
$ ./count_finder.pl 79 23 150
Found 150 of length 79  (required 161 total lines to do)
Found 76 of length 23
```

So I think that even though PLAINTEXT_LENGTH is set to 24 in this format, that it is only finding 23 byte passwords, and failing on the 24's   Or is this format actually setup for 23 byte password max?


Using `Object.create(null)` is actually really nice because it prevents other code from messing with your prototype chain.

I've opened issue #31 about the naming convention.


Looks like some mixed spaces and tabs going on here.


I did a little bit of changes (small things). Rendering again now, I'll commit later tonight


estoy adelantando algo en el tiempo libre
pues lo mas nuevo que hice es que ya un usuario puede aplicar a un chance creado estoy viendo que mas implemento santiago me propuso calificar los chances
no se usted que me proponga.


Yup, only 23 char, even though the PLAIN_LEN is 24 in the header.

```
$ ../run/john -list=format-all-details -form=sha512crypt-opencl
Format label                         sha512crypt-opencl
 Disabled in configuration file      no
Min. password length in bytes        0
Max. password length in bytes        23
Min. keys per crypt                  1
Max. keys per crypt                  1
Flags
 Case sensitive                      yes
 Supports 8-bit characters           yes
 Converts 8859-1 to UTF-16/UCS-2     no
 Honours --encoding=NAME             no
 False positives possible            no
 Uses a bitslice implementation      no
 The split() method unifies case     no
 A $dynamic$ format                  no
 A dynamic sized salt                no
 Parallelized with OpenMP            no
Number of test vectors               6
Algorithm name                       SHA512 OpenCL
Format name                          crypt(3) $6$
Benchmark comment                    (rounds=5000)
Benchmark length                     -1
Binary size                          64
Salt size                            32
Tunable cost parameters              iteration count
```

So in that case, 760 is correct.


Oh!, you got it just while I was typing.


It gives me Reference error:

Your app is crashing. Here's the latest log.

C:\Users\Tom\AppData\Local\.meteor\myapp\.meteor\local\build\programs\server\boot.js:233
}).run();
   ^
ReferenceError: Mongo is not defined
    at app/myapp.js:1:48
    at app/myapp.js:46:3
    at C:\Users\Tom\AppData\Local\.meteor\myapp\.meteor\local\build\programs\server\boot.js:196:10
    at Array.forEach (native)
    at Function._.each._.forEach (C:\Users\Tom\AppData\Local\.meteor\tools\dc9fb5197a\lib\node_modules\underscore\underscore.js:79:11)
    at C:\Users\Tom\AppData\Local\.meteor\myapp\.meteor\local\build\programs\server\boot.js:102:5
=> Exited with code: 8
=> Your application is crashing. Waiting for file change.

when i change it to Meteor it works.

Could it be I am on windows?


What's going on here? A lot more explanation is needed.


Great, thanks.


Hey @palant.  I know you are the top author of this excellent product (according to github you are #1 haha)

Could you help me find the lines of code in which all areas of ads are blocked?

I wanted to better understand how these extensions work in chrome and firefox and want to single step debug this project when it iterates through all my matches and finally blocks them.

Could you click on the gutter of some calling areas where I can put a break point to test this out?

Thank you so much for your help in understanding the code base of this or the gecko version!


Very cool!  Tried it out on Super Mario Sunshine and I think it will be a big improvement for that game once the "Pitch and Roll only" option is implemented.

I think some games would benefit from having options to stabilize the x/y/z axis as well.  For instance, no zoom or height movement in Smash Brothers, no zoom in Paper Mario, (maybe) no height movement in Super Mario Sunshine would be a big improvement for motion sickness and comfort.

I guess it couldn't be done in the same way, because you'd have to track the position of an object over time, as opposed to the offset in the same frame.  Plus it would be jarring once you loose the object you're tracking...  Seems technically possible, but hard to do right.  Guess it would be a lot easier on games with static scenes.  Do you have any plans to tackle positional stabilization?


ZMITH LORD TY FOR GRACING ME WITH YOUR PRESENCE


You might be right. Sometimes I tend to be paranoid and want to technically restrict to much instead of believing in the people knowing what is okay under what circumstances.


I was hoping that you could assert the policy you are passing to botocore is the custom policy.  Here is an s3 example: https://github.com/aws/aws-cli/blob/develop/tests/unit/customizations/s3/test_cp_command.py#L42


That commit is very bad. :)


I had to remove ora


I honestly can't find it. Could you please send me the link instead of mocking me.


Yes, good catch.


The `mro()[1:]` looks wrong to me, why skip the first element? Also, the event might be handed several time to the same method, bound on different classes.


I see why it was set to 24 (to pack int inputs). It just makes the 'normal' method of finding length a little difficult on this format.

I had always wondered about 24 bytes. It is the first item on a different hash-count per step grouping (23 is the last of the 2nd group.).   But if we stop at 23, then this makes sense, as does the 760 candidates.


ok


Whats all this commented out code?


Is that name descriptive enough? I have the feel, that I can't get the if-statement into the name...it could be a bit missleading, because most people think of a structure when they see "portal".

But a name like "recalculatePortalMaterialOrientation" sound really long and dumb to me :/


You can still see the results in the console, just not in chrome.


*facepalm* I knew this, and at one point nearly added it to the docs.  (Side note, going off to add this to the docs).


Ah, yes, the Windows launcher comes with Meteor 0.8.3, that would explain it.


Here's my attempt: 2da560a7, but it doesn't seem to work either


@tomkordys you are probably using a very outdated Windows port. The newest versions are here: https://github.com/meteor/meteor/wiki/Preview-of-Meteor-on-Windows. Also we are going to release the official Windows Port soon.


Ok, aber funktioniert der Tag über Vererbung hinweg? Was passiert, wenn eine Seite `block css` überschreibt?


Hey @gorhill.  I know you are the top author of this sweet open source project, but could you help me find the lines of code in which all areas of ads are blocked?

I wanted to better understand how these extensions work and want to single step debug this project when it iterates through all my matches and finally blocks them to see how things like this are executed in my DOM.

Could you click on the gutter in github or just reference some files and line numbers of some calling areas where I can put a break point to test this out?

I also looked through all the network and couldnt find any significant forks that did anything too dramatic to the source.  I was wondering why no one has published another forked version that has made it to the chrome store that does something a little different than master would.  Weird.  There is no rule against it if someone did that would there be so long as they obey the GPL3?

Thanks!


Makes sense, cheers


The 24 byte 'expectation' was also what caused the 1184 vs 1168.  Sorry for the confusion.  In the first 100 count of 79 byte inputs, there are 73 that are 23 bytes, and 74 of 24 bytes.


disable_icanon() made it so that you could actually "Press a key".  Without, standard input is buffered, and you need to press Enter specifically, not "any key".

disable_echo() prevented the key to entered from appearing on the screen.


Valeu


Funny, it looks even simpler now. :)


I might need to move PLAINTEXT_LENGTH definition to next to the comment explaining that 23 is the real safe.

I will improve that.


Done


Mmmh... Good point, but I think the answer is yes.

Also, could you update the CHANGES file with a one liner describing your change? Users get upset when I push new versions and I don't update it :)


Arrumei


this should be @SamLau95 ++!


nitpicking: everywhere else you did not put the parenthesis


Where is the implementation of this method?


Good doc. :)


Since you assign `env` in the line above, you could exchange `getEnvironment` with `env`.


This no-op patch makes the format look more like the other ones.
```diff
diff --git a/src/opencl_cryptsha512.h b/src/opencl_cryptsha512.h
index b6fb024..c306343 100644
--- a/src/opencl_cryptsha512.h
+++ b/src/opencl_cryptsha512.h
@@ -29,11 +29,11 @@
 //Constants.
 #define SALT_LENGTH             16
 #define SALT_ALIGN              4
-#define PLAINTEXT_LENGTH        24
+#define PLAINTEXT_LENGTH        23
 #define CIPHERTEXT_LENGTH	86
 #define BUFFER_ARRAY            8
 #define SALT_ARRAY              (SALT_LENGTH / 8)
-#define PLAINTEXT_ARRAY         (PLAINTEXT_LENGTH / 8)
+#define PLAINTEXT_ARRAY         ((PLAINTEXT_LENGTH + 7) / 8)
 #define BINARY_SIZE             64
 #define BINARY_ALIGN            4
 #define STEP                    0
diff --git a/src/opencl_cryptsha512_fmt_plug.c b/src/opencl_cryptsha512_fmt_plug.c
index bff396c..07e92fd 100644
--- a/src/opencl_cryptsha512_fmt_plug.c
+++ b/src/opencl_cryptsha512_fmt_plug.c
@@ -523,7 +523,7 @@ struct fmt_main fmt_opencl_cryptsha512 = {
 		BENCHMARK_COMMENT,
 		BENCHMARK_LENGTH,
 		0,
-		PLAINTEXT_LENGTH - 1,
+		PLAINTEXT_LENGTH,
 		BINARY_SIZE,
 		BINARY_ALIGN,
 		SALT_SIZE,
```


Added a litte more documentation to the describe what is happening inside the media queries.


This means the marking won't be immediate, right?


Gute Frage. Kann mich nicht an ein Fehlverhalten erinnern, ob es aber wirklich funktioniert müsste getestet werden.


gnaaaa :-D
I have to stop looking at single commits ;-)


I believe this line is where huginn is hanging up when pushed to dev server. It cant find local host because it's no longer on the local machine


This is a markdown file.


@egilburg my bad. I somehow constrained my thinking to a solution with an implicit receiver. Sure we could define a class method on the test-case and call that. Sorry for my confusion :sweat:


Nice deduplication. :)


@rosenk The web page for the service is: https://budueba.com/hackage I hope this helps.


Coming from using SublimeGit I and possibly others who have switched are used to seeing the current commit SHA1 and commit message for where HEAD is currently at in the status view for quick reference.


I think you mean to call this "patch". "put" already exists.


It's useless and the compiler will strip it out, but I would put a line:

    debug = NULL;

After the `client_list_delete()` then you will get a null pointer dereference and a hard crash if someone tries a use after free. It's sheer luck that the heap page is almost always still readable due to the allocations being small so you don't get any SIGSEGV.


This commit allows the simulateClick function to intelligently act as though it were the simulateSelectorClick function proposed in https://github.com/borismus/keysocket/pull/104


Since you try to simplify things, please consider moving https://github.com/egeerardyn/matlab2tikz/commit/de00019bd66a1e29d166cdd458bc4a7cdc4c0a1f#diff-76782b0b358b916574ab8ad22a7ce6fbR5838 down to function `versionArray()` and remove passing `env` in `isVersionBelow()` and `versionArray()`.


Hadn't read below: ignore me.


@johnament - any particular reason why tomee-embedded is the default profile for the travis build?
As it fails - it doesn't give a decent picture on PR.

I'd rather go for either 'safe profile'(like wildfly-embedded) or go for build matrix
```
env:
  matrix:
    - PROFILE=glassfish-embedded-arquillian
    - PROFILE=tomee-embedded-arquillian
    - PROFILE=wildfly-embedded-arquillian

script: "mvn clean install -P${PROFILE}"
```

what you think?


Sorry, wrong issue, should be #527.


revert this commit, with https://github.com/docktor/docktor/commit/094a9706bc67d576162a5cbd7e4b1d5896524d13

--> it works for me


Ad missing controller:
Did you enable routes for the plugin? This might be the reason for the missing controller message.

Ad how to use:
PayPal redirects the user to the controller mentioned above. Simply add the three methods from the readme to your AppModel. You can simply just add your code for completing payment in afterPayPalPaymentExecution() and ignore the others.

Actually beforePayPalPaymentExecution() is here to check some preconditions for accepting the payment. For example guess an order item has expired and you don't want paypal to actually perform the payment you can return false here and the payment will not be completed.


Yep I wanted to downgrade it, since we don't know if it's a bug -- if it's caused by a query kill, for example. But since this case should be rare maybe I should make it as a warning.


You know, if you intended to return a set anyway, you could have worked on one in the first place. (That is, `output = set()` and `output.add(filename)`.


@jleclanche It is the default Pootle project which includes the translations for Pootle itself. I have been wondering if it is worth keeping it.

@dwaynebailey Are you ok with dropping this? It has been commented for long time.


does oulier means outlier?


This is a little non-standard in Toolkit I think! Setting `self.__local_site_cache_location = None` in the constructor would have been more conventional and then just checking here.


This class got cleaned up while removing the preview dialog https://github.com/cubing/wca-workbook-assistant/commit/510d2beed6e78dfd4335b59c0e6ce83ae775a767


Thank you!
I was just looking at how this is done. :)
http://stackoverflow.com/questions/17821532/how-to-open-navigation-drawer-with-no-actionbar-open-with-just-a-button


Simulation is working fine, as far as I can tell.

The tests still need some work, mainly because they cannot be grouped as they currently are, since they need differently compiled versions (due to added conditional compilation) of functions.

I will concentrate on finalizing the break criterium and data-set generation before returning to the Tests.

Until the tests work, I won't merge this into master, but here is a point from which on most parts of the codebase should be stable enough to provide a branching point.

Also codereview would be very much appreciated.