I am wondering if we shouldn't cache the config locally, because it seems that this will be called potentially several times per call.

We could do something similar to the coinbase plugin (https://github.com/killbill/killbill-coinbase-plugin/blob/master/lib/coinbase/models/coinbase_response.rb#L79), i.e. have a thread that polls the config (every minute?). Another benefit would be that when we refresh the config, we could update the logger (turn on DEBUG at runtime) and currency conversions.


We're just following GoodN64 conventions here.

I think that if I was in charge of GoodN64 naming specs, I would have done what you said and said (v1.x), not (V1.x).  So grammatically/semantically speaking it possibly should be a lowercase 'V', but it's their own little convention and is being held throughout 99% the rest of the RDB file.  Besides, their version numbering scheme is wrong with Nintendo's official development one anyway.  I can think of things they got wrong besides upper-casing the 'v'.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 232](http://192.168.30.225:8111/viewLog.html?buildId=897&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


Getting the word 'Instructor' in here links nicely to the other field...perhaps it could be as simple as that word: 'Instructor'...overall I think this is perhaps the least bad...


Why is this method private? Can the method somehow harm or modify data within the object so that access should be restricted for security reasons? In other case I suggest making the method public. Someone else might want to use it (who knows).

Just like with the other similar method there could be one alternate version of this one where you can specify the levelshtein max distance.


Good job.


dsfsdfsdf


sdf


sdfsdf


@mhaskel Looks like it's :tada: time!


Need to specify a dependency between this and the file /etc/auto.mnt


Can we get rid of BUILDING_TPIE_DLL? Using a cmakedefine like you're doing here seems to be the right thing (and sufficient), right?


Excellent!


Incorrect comment, port 2468 not opened.


Spurious space.


Spotted a spelling mistake (probably made by myself way way back). "To" --> "Too".


Why can't we initialize promotions = [] in the Enviroment class?


@aslakhellesoy feel free to fix it, i just wanted to have a placeholder here


Can you coordinate work on String with @nirvdrum? He's working on it as well and we don't want to conflict or duplicate work by mistake.


Do we need ConcurrentHashMap here? or concurrent version of LinkedHashMap?


Coverage:
Statements: 69.82%
Branches: 52.88%
Functions: 87.5%
Lines: 69.82%

You should add more tests according to the coverage report.


pipeline.Pipeline?


Не совсем так. У тебя есть тег  и у него класс platforms-list__platform-logo--apple – это класс модификатора, модификатор не может быть без основного класса platforms-list__platform-logo. То есть у тега  будет два класса


It's not an English problem at all (it's Apple's convention), and you write better than most native speakers I know (although my perspective may be skewed as I live in China and hear truly poor English all day long).


really ??! I ubsoulutely missed that ... hehe, thank u anyway for always great help / support !


i am duplicating this function, so i don't have to parse the binaries to atoms. atoms are the way lager handles metadata, this should probably be changed in the future


Coverage:
Statements: 88.6%
Branches: 77.35%
Functions: 95.24%
Lines: 88.86%

You should add more appropriate tests according to the coverage report despite you’ve written 61 test cases.


Fixed in 2.0.


why is this Pipelines? extra s in the end?


lessons


Good job.


Lets keep the text consistent for all the models: "a pipeline configuration named "...


What about this indentation? Is it correct? @ThiefMaster?


Please delete or change the last comment line.


Actually now that I think about it you are executing something for each sub command... How about we create a method "getAliasesLevenshtein(int maxDistance)" that returns aliases for the command itself. Then we create "getSubCommandAliasesLevenshtein(int maxDistance)" that for loops that method for each sub command.

It would seem cleaner to have a method searching the aliases of just one command as a smaller building block. Would it not?


Empty type parameter, is that a mistake? I saw some more of these.


Where does "fbp-test" comes from?


I don't think there's any style guide for wrapping this kind of stuff in templates ;)


No.. i mean how to change that SW/HW Thing ... decoding ...how can i see what i've and how to switch between SW/HW Decoder ..


For sure. I'll speak with him. Thanks!


you could also enhance the unit tests to add (note the space between the return and semicolon):

        [Fact]
        public void ShouldThrowParserExceptionWhenEptyReturnWithoutFunctionBody2()
        {
            Assert.Throws<ParserException>(() => RunTest(@"return ;"));
        }


Methods don't belong in the view, e.g. @selected_employee should be filled in the controller.


@BrandonBrowning Could you give me a script to test this? Thank you.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 232](http://192.168.30.225:8111/viewLog.html?buildId=897&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 55 Build time: 00:10:50


It seems like the levenshtein suggestion is displayed all alone? I think it should rather be displayed together with the rest of the information as well. So in my opinion I think it would be better if we displayed both lines like:

```
Did you mean hurr?
More than 50 alternatives available.
```
or

```
Did you mean hurr?
Use derp, glerp, hurr or durr.
```


OK


Overzealous find&replacing, surprised rustc didn't error for it!


Don't create more empty lines than needed. Protip: it's never more than one.


I'm not quite following the code. If you want to translate a set of points x, y (both numpy 1d arrays) into polar coordinates relative to a center, cx, cy, it's simply:
theta = np.arctan2(x-cx, y-cy)
radius = np.sqrt((x-cx)**2 + (y-cy)**2)

With a little cleverness, you can process many centers at once for a whole image.


1. Piping to a running *bspc* process that would then write the messages to *bspwm*'s socket just seems like an unnecessary indirection.
2. The socket path and template would just be passed as arguments to *sxhkd*.
I don't see the need for making a general infrastructure for something that's only going to be used in the context of *bspwm* anyway.


just, why do you get the RectTransform component? We don't need it :D


Sorry for more comments, but this would probably be better as `($fnew)(T, x[i])`


Your git commit messages were a bit misleading.


This will cause error when accessing from https


This function was not documented and I think has no business in being public.


Review by @gzm0 to push on scala-js/master.


This causes the carouselIndex to be reset to 0 even if specified via the `rn-carousel-index="myScopeVariable"` attribute.

Maybe this would fix it:

```
if (typeof $scope.carouselIndex !== 'number') {
  $scope.carouselIndex = 0;
}
```


`You.toLowerCase()` is not a good idea. You will fuck the letter case up by doing that since the word "you" should start with a lower case letter but eigennames such as "Cayorion" still should have an upper case first letter even in the middle of a sentence.

Rather create a new variable "you" using `String You = ep.describeTo(ep, false);`.


Good point, thanks for looking as always, filed #361.


Can you avoid calling `iround` etc.? On 0.4 this prints a bunch of deprecation warnings when the tests run.


Use JavaDoc. If you use IDEA or Android Studio, simply type "/**", then press Enter and fill the scratch. Later, you can use Ctrl+Q to see formatted JavaDoc


Yeah that was the problem I was having, I was just seeking some feedback from @Zidane or @DDoS to see where the issue might have come up. I'll push the correct ref now.


Running "shell:runtime:kill" (shell) task
Fatal error: No running process for target:runtime


This test was just to have something that failed with the previous setup. Sites wasn't included in the context so I thought the best way to test that we'd improved the template was to check that there weren't any variables used in it which wouldn't be rendered. I guess a Django person might do that deliberately, but this template editing isn't really supposed to be for programmers, so I think this test is OK.

I think we should redo these email templates so that they only accept a very limited selection of strings as discussed in #417.


Google plus email return


"// Result" - unnecessary, redundant comments


We're adding a couple of lines here but IMO it's way clearer than a multiline block with 3 statements as a single expressions inside parens.


I think checking for this first makes more sense since it's a quick check and if it's `true` it avoids computing `valid_csrf_token?` altogether.


The argument encodingConverter cannot be optional here because the encodingConverter is used in the methods: `getClientRequestParameters` and `getRequestTarget` without checking if the encodingConverter is null.


I do agree that is easier to understand. What is simpler than system ("touch $file")
However this approach has a few drawbacks.
* File permissions are not set properly so this could probably cause issues if a process running as root does set the proper user and group for the file.
* The overhead of calling a process to just touch a file seems like a lot with no benefit other than simplicity.
* Security there is always a danger when calling an external process if someone would replace touch with another executable the someone can access get into the machine that way I do agree this is unlikely to happen but it a possibility.

Also it is very easy to wrap the "complicated" touch function into an utility method which could handle would also the file permission issue.

If you do not want to make any major changes in your workflow at the moment.
At least put the full path of the touch executable in order to reduce the chance of someone putting an alternative version of touch in order to reduce this attack vector.


`List.first` is clearer than `Enum.at(0)`. `hd` could not be used since a `nil` return value makes sense in the context of this function.


Pattern matching FTW


Extracting this function makes `cross_origin_js?` more concise and clear.


Note that empty `catch` blocks are bad, do not ignore exceptions. You should at least write some logs.


roots and leaves in the device tree are always hard to keep straight for me, because parent in blivet devices means what child would mean in a typical tree. But I remain puzzled why you start w/ roots instead of leaves, here.

Another thing that troubles me is the calculation of depth. It's based on the depth of the leftmost ancestor, but that could, I think, be more or less than the depth of the tree as a whole.

Also, we leave some devices kind of hanging, it seems. So, an array, A, with two member, d1, d2, will print out like:

d1
  A
d2

with no indication that d2 is a parent of A (because A was already done the first time). So, I'ld prefer:
A
  d1
  d2
although I may be missing something here.


Thats confusing! I would suggest:
```C
if ((NMTMNU_GET_NODEINFO(tempNodeId)->nodeCfg &
                          (NMT_NODEASSIGN_NODE_IS_CN | NMT_NODEASSIGN_NODE_EXISTS)) ==
                          (NMT_NODEASSIGN_NODE_IS_CN | NMT_NODEASSIGN_NODE_EXISTS))
```


The comment about the SMH can be kicked right?


Since you are looping through the responses individually, it would make more sense to call your variable |response| rather than |responses|.


This class looks doubtful. What is it for? And why do you have a convert(String arg) method that does not take the CommandSender sender parameter from the read method? We lose information as we move forward to "convert".


Так, ну вроде бы все поправил. И travis одобрил проект Sedona. Pink пока
проверяется.

С уважением, Евгений

  04.03.2015, 17:58:38 пользователь Alexey Maleykov (notifications@github.com)
  написал:

  Не совсем так. У тебя есть тег и у него класс
  platforms-list__platform-logo--apple – это класс модификатора, модификатор не
  может быть без основного класса platforms-list__platform-logo. То есть у тега
  будет два класса

  —
  Reply to this email directly or view it on GitHub.


Same as with the RequestParser. The encodingConverter is used in the method: `generateUrl` without checking if the encodingConverter is null.


You don't need to override this method since you don't do anything in it. You can remove it and save 5 sloc :)


don't use master


Geting this error now:

```
Fuel\Core\PhpErrorException [ Notice ]:
Undefined variable: self

orm/classes/query.php @ line 283
```


I tend to agree with James on this one.
What's wrong with utime?


This seems to work for PHP >= 5.4 only. Can't we use the full syntax to create the arrays?


What about the gazeb models path? Wont we have to download the models and point the path to a local directory where the models are stored?


Thats confusing! I would suggest:
```C
if ((nodeCfg & (NMT_NODEASSIGN_NODE_IS_CN | NMT_NODEASSIGN_NODE_EXISTS)) ==
                        (NMT_NODEASSIGN_NODE_IS_CN | NMT_NODEASSIGN_NODE_EXISTS))
```


Please use store procedure instead


Thats confusing! I would suggest:
```C
if ((nodeCfg & (NMT_NODEASSIGN_MN_PRES | NMT_NODEASSIGN_NODE_EXISTS)) ==
                        (NMT_NODEASSIGN_MN_PRES | NMT_NODEASSIGN_NODE_EXISTS))
```


Here you should explain how to provide featureNS as object, maybe with a code example.


I think the change is confusing. Please see my inline comments


Okay updated the ref, should work now.


Better to read Education levels from DB.


isValid should have an implementation already in ArgReaderAbstract that renders specific yet basic/standard implementations like this one handled already.

Did I not give you that feedback in the last commit? Here we go again:
I am of the belief that a default implementation of isValid should be present in ArgReaderAbstract and that it should do a try-catch like you made here but not on something like "convert". It should use the "read(String arg, CommandSender sender)" method and return false upon catching an error.


An events interface is in the works, and this is certainly an event I could add. See #30.


Better to read Job gread from DB,


I was also really surprised to see this. Perhaps we should file a bug to the compiler?


again, better to read it from DB


Shouldn't it be const ref?


Das stimmt nicht für VOeBB, denn dort gibt es ein paar links mehr.


Why? What is this for?


please use DP instead


:-1: だめー


please use SP instead


Thanks! This is much easier to read! :smile_cat:


Done in 5f7d37480d7fb31d1850652739dd66d41e8f25d9.


Hier wird "Autor: Titel" per Doppelpunkt getrennt? Autor ist nicht gegeben bei VOeBB, trennt also nach 1. Doppelpunkt im Titel


Here's some example output of an lvm-on-md setup created on disk images:

existing 100 GiB file /data/tmp/blivet.4vpkKX-disk1 (2)
  existing 100 GiB loop loop0 (6)
    existing 100 GiB dm-linear disk1 (13) with existing gpt disklabel
      existing 50.07 GiB partition disk1p1 (470) with existing mdmember
        existing 50.04 GiB mdarray pv00 (486) with existing lvmpv
          existing 50.04 GiB lvmvg blivet00 (322)
            existing 50 GiB lvmlv blivet00-data00 (329) with existing xfs filesystem mounted at /data
existing 100 GiB file /data/tmp/blivet.WFx7DX-disk2 (21)
  existing 100 GiB loop loop1 (25)
    existing 100 GiB dm-linear disk2 (32) with existing gpt disklabel
      existing 50.07 GiB partition disk2p1 (478) with existing mdmember
existing 1024 MiB cdrom sr0 (137)

The problem is that some devices can have many parents and some devices can have many children, so there's no good way to represent the tree with any detail. You could do a decent job if only showing device name, but I think that's less useful than the above.


Any specific reason for using hydro-devel branch in ardrone_autonomy? The indigo-devel should be used in case people are using indigo


Issue: https://github.com/suzukiplan/Touhou-VGS-MML-data/issues/41


Also I am not sure if the tum_simulator repository that has been forked to our github org works with indigo. But this one does - git clone https://github.com/algron/tum_simulator -b indigo


@mogoodrich i think that is already happening somewhere in the module, because when i installed the modules the app would appear on the home page


please avoid using connection string at presentation level. (I expect you to use the 3 tier architecture at lease for new pages you develop)


Pushed a fix for this on master


Invalid source code formatting.
the "catch" statement should be on its own line below the "}" bracket.


This looks good, but where is this method called? It's commented out in the controller, but I don't see it in a view either.


Thanks! Is there a plan for making this work more reliably? I'd love for it to happen, but if it fails a lot nobody's going to pay attention to it.


Oh! Nice! You do have such a default implementation! :smile_cat:


all tests pass:
success: http://build.servo.org/builders/linux1/builds/928
success: http://build.servo.org/builders/linux2/builds/926
success: http://build.servo.org/builders/android/builds/964
success: http://build.servo.org/builders/mac1/builds/1143
success: http://build.servo.org/builders/mac2/builds/1143
success: http://build.servo.org/builders/gonk/builds/114


this will be empty if nothing was found... maybe set rpi_hardware_version to unknown in line 105?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1140 of 1140 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.62%25-green.svg)


Okay, But the one that I had forked does work, as of today evening while we
checked, since that also has been modified from the original version.

On Wed, Mar 4, 2015 at 8:53 PM, Aditya Agarwal <notifications@github.com>
wrote:

> Also I am not sure if the tum_simulator repository that has been forked to
> our github org works with indigo. But this one does - git clone
> https://github.com/algron/tum_simulator -b indigo
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/quadrotor-IITKgp/quad_simulator/commit/ee78da5a9b3b37a3dcc932cd232d6c1a3f477fd3#commitcomment-10031598>
> .
>

--
Abhinav Jain
*Second Year Undergraduate Student*
Department of Mathematics
Indian Institute of Technology, Kharagpur


To preserve order you should use a LinkedHashSet.


Oh, I see that whitespace is being removed. That's not helpful. I'll try again:

```
existing 100 GiB file /data/tmp/blivet.4vpkKX-disk1 (2)
  existing 100 GiB loop loop0 (6)
    existing 100 GiB dm-linear disk1 (13) with existing gpt disklabel
      existing 50.07 GiB partition disk1p1 (470) with existing mdmember
        existing 50.04 GiB mdarray pv00 (486) with existing lvmpv
          existing 50.04 GiB lvmvg blivet00 (322)
            existing 50 GiB lvmlv blivet00-data00 (329) with existing xfs filesystem mounted at /data
existing 100 GiB file /data/tmp/blivet.WFx7DX-disk2 (21)
  existing 100 GiB loop loop1 (25)
    existing 100 GiB dm-linear disk2 (32) with existing gpt disklabel
      existing 50.07 GiB partition disk2p1 (478) with existing mdmember
existing 1024 MiB cdrom sr0 (137)
```


Wtf xD ?


那一个中文字对应几个 -


For reasons see https://github.com/composer/composer/issues/1905#issuecomment-41631659 and https://github.com/composer/composer/pull/3715#issuecomment-73271923


I'll have a look at this version of this tum_simulator as well. I guess
that'd save us the effort of tweaking the original tum_simulator ourselves.

On Wed, Mar 4, 2015 at 8:54 PM, Abhinav Jain <abhinavjain241@gmail.com>
wrote:

> Okay, But the one that I had forked does work, as of today evening while
> we checked, since that also has been modified from the original version.
>
> On Wed, Mar 4, 2015 at 8:53 PM, Aditya Agarwal <notifications@github.com>
> wrote:
>
>> Also I am not sure if the tum_simulator repository that has been forked
>> to our github org works with indigo. But this one does - git clone
>> https://github.com/algron/tum_simulator -b indigo
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/quadrotor-IITKgp/quad_simulator/commit/ee78da5a9b3b37a3dcc932cd232d6c1a3f477fd3#commitcomment-10031598>
>> .
>>
>
>
>
> --
> Abhinav Jain
> *Second Year Undergraduate Student*
> Department of Mathematics
> Indian Institute of Technology, Kharagpur
>
>

--
Abhinav Jain
*Second Year Undergraduate Student*
Department of Mathematics
Indian Institute of Technology, Kharagpur


LinkedHashSet should be used or simply an ArrayList here.


I actually have a problem with this, i will probably write to the devlist, there are 2 patient dashboard and these actions get added to both, but the return Url is one here meaning if am on the clinician facing patient dashboard i get redirected to the data entry one which is not desired in that case


Nice! :smile_cat:


re: logging a bug, probably! Do you want to go ahead with that, or else if you don't have time to log it I can do it later :)


utime does not have subsecond precision but futimens does


fast-forwarding master to auto = 761f7f05


Shouldn't the FetcherBolts do something about the 304 returned by the server, like for instance send an update for the URL on the status stream but not send the binary content to the subsequent bolts? I don't quite get the point of specifying these otherwise.

I am not really happy with the use of the cached* keys. This is not what a normal browser would use. Also I can't see anywhere in the code where we'd convert from the values initially returned by the servers to these cached ones.


1: M100 needs more reviewers
1: M101 signature is missing


1: M111 unrecognized component name: general


mkdir -p $HOME/.ldict/fanyi
mkdir -p $HOME/.ldict/dict

有什么实际效果吗？


Yes :-) And there are still (presumably many) clashes - even in the first few values.


@psndcsrv do you remember why this was synchronous?
My guess is that it had to do with handling the case where the state needed to be saved when the 'next' button is pushed.  If the page is 'exiting' then async requests will get dropped by some browsers. At least that is what Zeus discovered when trying to log page exits.


Never put scripts at the start of the <body>, it blocks loading of the page.


You should probably write "player". The only non player CommandSender we have at the moment is Console, and players don't care much about the console. Player would be the least confusing.


player


I feel ... stupid  -_-'


That's interesting because [tools/jsrun.py](https://github.com/kripken/emscripten/blob/master/tools/jsrun.py#L23) is checking for `jsc` in the JS engine name before adding the additional `--` argument separator.  I did not change that behavior.

Looking at my environment, I had the Webkit `jsc` set as my `SPIDERMONKEY_ENGINE` runtime, instead of the actual standalone Firefox runtime, which was wrong.


Oh. I swear you needed to reference a transform to get its parent... removing it now.


font-face är ren CSS. Så bör det vara en setting?


I'm a bit busy so you can feel free to do it :)


This shifts the entire content 45 pixels to the left, not a desirable effect. It also messes up the responsive nature of the site (all responsive rules now have to account for an extra 45 pixels).


ng-options should be bs-options


Alright :) I'll look into the .describeTo method and change it after I know how this boolean makes it correct :) Thank you for pointing it out. :)


Maybe make clear in name of method that you will obtain only a MAIN file.


Well, I don't really understand all of this, but if it works, fine. What was wrong with the "optional" stuff, for instance? But go ahead and merge if you think it's OK.


Typo, "oer" should be "over"


Nice! :smile_cat: This looks better.


Yeah this might be more human friendly?


Так, что-то я задумался и понял, что не понял. А как тогда мне правильно сделать валидацию?


Clearer to use |response| rather than |responses|.


Yeah this might be more human friendly. Should definitely not have been saying "integer" :P


@waterlink here is the output I get from this test:

```
4.690000   0.090000   4.780000 (  4.807243)
  7.560000   0.120000   7.680000 (  7.903846)
```

Seems worthwhile to use a hash, particularly since it's a trivial refactoring at this point. Thanks for the feedback.


I extracted `facebookUserJson ` to a seperate class (it will be used by other login providers as well), but I'm not sure how can I get rid of all this nested blocks? Any ideas and tips @PatrykKaczmarek and @akashivskyy ? Specifically I don't know how to structure the code when I obviously need to wait for completion in some of these blocks.


Samma fast för Firefox:
```css
-moz-osx-font-smoothing: grayscale;
```


2015-03-04 23:28 GMT+08:00 xgdgsc <notifications@github.com>:

> mkdir -p $HOME/.ldict/fanyi
> mkdir -p $HOME/.ldict/dict
>
> 有什么实际效果吗？
>

完了，看来 $HOME 是无效的？
第一次就捅篓子…
我原意是需要在 $HOME 创建那两个目录，有其他办法实现吗？

--
Regards,
Jactry Zeng


to fix https://cloud.githubusercontent.com/assets/135148/6473882/ac3c2980-c1fc-11e4-9559-c9755ef610f2.png


Awesome. Thanks for adding the empty line at the end.


Agreed... definitely something that needs to be worked out.


Well you're not using the provided API, you're directly setting the parameters in the config.
```java
		config.put("rabbitmq.autoRecovery", true);
		config.put("rabbitmq.queueName", "testQueue");
		config.put("rabbitmq.prefetchCount", 2*BATCH_SIZE);
```

Instead you should have been using the provided API (or provide new API along those lines in your new feature).
```java
ConsumerConfig spoutConfig = new ConsumerConfigBuilder().connection(connectionConfig)
                                                        .queue("your.rabbitmq.queue")
                                                        .prefetch(200)
                                                        .requeueOnFail()
                                                        .build();
```

And then have the builder take of care of ensuring all the required fields are there. ConfigUtils is not the right place for defaults as it lacks context on what the right defaults should be. Different use cases may require different defaults.


reject


I guess it depends on the blend of reasons for checking if the parameter responds to `include?`. I can see two main reasons:

1. Check whether it makes "semantic" sense for this matcher to be applied
2. Guard code further down which might (i.e. did previously) rely on the presence of this method.

If it's principally the latter, then changing the guard to check for `any?` would make most sense. If it's principally the former, I'd leave it as it is. If it's both, I could also add a check for `respond_to?(:any?)` potentially?


Could you use `candidates.models.election_date_2015` instead, possibly? (At some point I'll move election metadata like this into settings, but at least then it'll just be a case of replacing references to `election_date_2015`.)


@dkayiwa Made the changes no scope for null pointer exception now :) can you please review the PR :)


LGTM


In my Chrome there was a problem with arrows on Dashboard page (they were at the bottm)


Ah, okay... I was just commenting because Dave mentioned that the home page button was *not* showing on on devtest02.  I haven't looked into it at all though.


No new tests?


why @JoeZ99 do you add this files??


Well, in my opinion (and according to my blog post), the only true solution is declarative programming in shape of streams (pipelines).

In Objective-C world this is also known as ReactiveCocoa. :trollface:


jag kommenterar
nu


Fix to https://cloud.githubusercontent.com/assets/135148/6474016/caec47c4-c1fd-11e4-80d7-85df23559ad2.png


От таблиц меня отучила тётя France de Vaal (если есть выбор и это необязательно таблицы). Она бы в этом случае вообще использовала бы dl, dt, dd, но точно не ul, либо
другую организацию контента
, поэтому думаю пока так оставить, пусть будет другая организация.


You should create two sets of strings:

* One set with true-strings.
* One set with false-strings.

See this method returns false for stuff like "bloopleschteinnen". An for that reason (that no exception is thrown) the isValid will always return true. That does not bode well for the arbitrary argument order we want to implement later on.

In fact it might be a good idea to look over all of the ArgumentReaders and see if there are any other than never throws exceptions.


yayyy!


Fix to https://cloud.githubusercontent.com/assets/135148/6473941/393c13cc-c1fd-11e4-9ccc-82dec01431aa.png
and https://cloud.githubusercontent.com/assets/135148/6473998/a72034ae-c1fd-11e4-99b6-f7c6b2ed18e7.png


1: D100 Docstring missing


Sätt alltid enkel-färg fallback, typ:

```css
background:  #1e4883;
background: linear-gradient(left, #1e4883, #325a91);
```

http://caniuse.com/#search=linear-gradient


I mean "as reported in #81"


Guess the new initialization syntax doesn't work on Windows :(


:+1:  for this feature


I ran into #215 when trying to add a test. It'll be added once that's resolved.


Rodger, I'll switch to old school.


Cellar: cellar.feature:28 tests
Chancellor: interactions/tunnel_chancellor.feature tests
Mine: I have no framework that lets me test invalid parameters at the moment, which is a shame. I should.


Same results as @coderdave. stateDidChange seems to have a conflict in this context with McFly.


Give twemproxy a single redis instance (only for simplicity; works with multiple obviously)
Bash variables represent ports

```
$ redis-cli -p $nutcracker set _name r0
$ redis-cli -p $nutcracker eval "local command = table.remove(ARGV, 1); table.insert(ARGV, 1, KEYS[1]); return { redis.call('get', '_name'), redis.call(command, unpack(ARGV)) }" 1 a get
1) "r0"
2) (nil)

# looking good

$ redis-cli -p $nutcracker eval "local command = table.remove(ARGV, 1); table.insert(ARGV, 1, KEYS[1]); return { redis.call('get', '_name'), redis.call(command, unpack(ARGV)) }" 1 a set 5
(error) ERR Invalid argument

# oh no

$ redis-cli -p $redis eval "local command = table.remove(ARGV, 1); table.insert(ARGV, 1, KEYS[1]); return { redis.call('get', '_name'), redis.call(command, unpack(ARGV)) }" 1 a set 5
1) "r0"
2) OK

# works directly on client
```


Since you have the default implementation of isValid in ArgReaderAbstract... this custom isValid implementation looks unnecessary to me. Does it serve any purpose that the ArgReaderAbstract#isValid would not?


It is because the CI build for the appointment UI module is still failing so the module isn't getting deployed.


This just looks dangerous, even though it may work on most machines.  Memcpy() is optimized and guaranteed to work.


I'm concerned if this is actually blocking and I want to understand the issue you're trying to convey but it's not clear to me.

The original code was:

```java
 while ((message = consumer.nextMessage()) != Message.NONE) {
  << extract and emit >>
}
```

The while condition was only if there were still messages left ( != NONE as opposed == NONE ) which is different from you what you state above.


When we updated reqmgr2 validation, we tighten up the validation. And optional strictly means that user doesn't have to specify (since default value is provided) not it that it is optional for the spec itself.
I think those parameters specified anyway by user so we didn't have problem in production but I think it broke the test.


OK I think I understand what this is for now. This method might be a good idea... but remove the custom isValid if possible.


@nickbender @coderdave the method you want to use here is `storeDidChange`, not `stateDidChange`


Maybe we should not put the back-end script within the web app directory? and create a /bin or /sbin directory for the back-end part. What do you think?


I'll be home soon then I'll do the changes my self.


Я что-то засомневалась: мы про этот блок: Переключение меню
или про этот:  x ? В общем, можно что-то javascript-ом вставлять.


lgtm - only thought is whether anything in rsyslog.d might contain secrets?

Actually it looks like [they do](http://wiki.rsyslog.com/index.php/Security) (or at least they can).

That's orthogonal to this patch though - I've filed Issue #525 to address that.


这个一般是写在程序里吧。


nice. seuraava projekti vois olla pisteytyssysteemi jotta pause menust vois jatkaa viel kans samaa peliä


I copied this straight from [PDAL source](https://github.com/PDAL/PDAL/blob/master/include/pdal/Utils.hpp#L104), just replacing a `sizeof` with a specified size.


Do we need to worry about byte order?  You can use Extractor if you like to take care of that.  I think it will handle all of this stuff pretty efficiently.


So after I have read some more... Shouldn't this class extend ARAbstractException?


Not saying I wouldn't be happy to change, but if I change this we should nuke the usage in source too, no?


Have you considered using [MailKit](https://github.com/jstedfast/MailKit) instead? Just trying to save you some trouble...


Ah, okay, thanks!


Yeah, from the commit message of ce6973f6c892dc7ed7fe2add3798aafed75819e1 it looks like this was an honest oversight. I first thought that the check was modified to pass always in a funny way at some stage, but the commit history speaks another language.


Awesome!


Åhå


Extractor looks like what I need, I didn't know it existed. I'll update this driver to use Extractor so we can hopefully move that directions.


Nice :smile: now it's looking good


Oh, I see. You could add `\u{62}` in the mean time.

Anyway, you’re fixing these issues so quickly it’s probably just a matter of minutes :) _/me shuts up_


aaaaggghh!!! thanks again, these things remember me why i hate java


ok，我明天看看怎么弄好，多谢了 :)

xgdgsc <notifications@github.com>于2015年3月4日星期三写道：

> 这个一般是写在程序里吧。
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Jactry/repo/commit/0797297b554482fc73937ab025d9ee88ef199562#commitcomment-10032029>
> .
>

--
Regards,
Jactry Zeng


I'll separate the tests for the buttons and the one for doing the layout with ``class`` and ``id`` attributes.


Do you use MX player? If no, just download it - it support both types of decoders.


looks good, but maybe it should log the issue in console before return. Thanks a lot, I will look into it


|response| would be clearer than |responses|


you already have child_process


with back-end, do you mean the db_mgmt* scripts? If we make those kinds of changes, we'll have to rework the structure within the scripts as well. What kind of structure do you propose? At least I would like to separate the scripts from documentation, readme and requirements


Istället för att skriva `font-family: 'GillSansMTStd-Bold';` kan ni skriva:

```css
font-family: 'GillSansMTStd`;
font-weight: bold;
```

Så slipper ni sätta `font-family` när ni bara ska ändra `font-style` eller `font-weight`.

Alltså, alla Gill Sans fonter bör heta `GillSansMTStd`


facepalm what is this


No that is not possible. The config.h file is included both when building the dll, and when using the dll. So on windows that is not possible.


Check it out. Without the try/catch it becomes a rabid spitter of weird JSON parse errors without any call stack.

Took me a while to figure out what the heck was going on.


Most times it happens because receiveMessage is receiving something not even intended for frameTalk, so I don't know if anything but a debug message would be necessary.


Här borde du kunna använda font variabeln


keep the part that removes the blue.
reject the part that removes the border completely in advanced mode.


one user could show up in more than one thread.  then, logins and logouts would race.

i'm not sure what happens if a logged-in user logs in / a logged-out user logs out.  perhaps this is what we want?


:joy: :ok_hand:


why isn't god allowed to play?


You don't have a lot of logic in the view, but to consider #2 http://www.toptal.com/ruby-on-rails/top-10-mistakes-that-rails-programmers-make


bugfix for: https://github.com/jedie/django-tools/issues/6


I didn't want to have to parse some array by hand. This is much easier to handle on the network.


oh i see...


I prefer:

    Just uids <- getUIDs

because of the better error message and because it's pattern matching.


LGTM


Mostly because she has a different password. I'm not sure we would gain anything by changing this.


Thinking about it more... I think I understand what you're saying, you're saying that `ack`/`fail`/etc is starved due to the while loop in the `nextTuple`. I think changing the while condition to just an if condition will help in there. Let me think about this some more.


@arjunguha It makes it so I can do this


Great! I was looking for these earlier. And nice user-friendly improvement to add the note to your post form that all fields should be filled in.


reject


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/dbi/DBIMysqli.class.php


Method `emit(int, bool)` is a private, withoud descriptive name. Feedback initialization is only needed on Ranger instance initialization and I do not see reason to overload emit method to make it public in order to access in Ranger class.
Please see file Ranger.cpp


Este es mi primer archivo hola mundo


Was that causing an issue?


J'ai effectuer cette modification car nous nous étions "trompés" dans nos méthodes (getter, setter, solCasesSure) et s'est, au final, la solution la plus logique.
Donc, pour balayer la ligne i on itère sur le nombre de colonnes, et inversement pour les colonnes.


Oh right, nevermind.


|response| rather than |responses|


wtf l'espace...


OK, so, damn, apparently this doesn't work everywhere. In particular it doesn't work for the language module sources. @davidfestal any suggestions?


use `|env| unsafe {...}` instead could reduce an indentation


PROBOcol :)


Correction d'une petite confusion dans remplirMat
Renommage d'une méthode
Rajout de commentaires de compréhension


fixed and tested in 0c38243

Tell me if it's fine


Nice touch.


Thanks, it's about the S860 (with currently 4.2).
But today I found this link and will try this version first...

http://www.50lollipop.org/mp3-0/lenovo-s860-6159.html


you don't seem to use that file in this test. (yet, probably but still it makes no sense in this commit and is irritating.)


y estos son los segundos archivos


Would separate concurrent logins from the same user not return different sessions?


everybody needs this


use `fromMaybe`?


Consider http://www.toptal.com/ruby-on-rails/top-10-mistakes-that-rails-programmers-make


Syntax error, die Einrückung passt hier nicht


more informative error string?  "Got no session token"?


`.filter` länkarna borde vara elements, och inte beroende av `.filter-groups` modulen


bug in level 4


It wasn't really fixed, but [this later commit](https://github.com/kbroman/qtlcharts/commit/03cb54d117a9da330d1fe576fbfa6e0ac66cff96) seems to do the trick.


Yes. Brainfart / deleted the wrong parts of the message.


This fix some reboot problems with your fix. Phone reboots if it go to supend.

https://github.com/walter79/android_kernel_htc_leo/commit/ebc23b4c6e4716e376857498f128c35909e5ea20


styling på ett element


I'd revert this, it's much less likely to be correct and it's breaking a few tests, the initial logic was elegant.


How would you choose to start/stop sending events?


reject


Yeah, that's better.


Yeah this is part of the next commit i guess


I think it should be `#ifndef SHIBOKEN_SKIP`, not `#ifndef SHIBOKEN` — see `smtk/model/{Operator.h,Session.h}` among others. Does this really do anything for you?


Looks good later we should refactor that in a utility function


Men det här är ju den kompilerade filen :P


It looks like it's been aded by @knowuh:
https://github.com/concord-consortium/lara/commit/d66f3bd7b8605e1a409692dbee3f6a8000a1814e#diff-64fd8f5000672b54fd5d489e1d8e42a7R26

@scytacki, we don't use anywhere `onbeforeunload` event. Instead, we manually modify "next" button click handler and when everything is saved, we execute the original action. To save iframe state, we call `IFrameSaver#save`.

I feel we don't need sync request, as when we call `IFrameSaver#save`, we first have to use iframe-phone to request iframe's state. So, `IFrameSaver#save` is async operation anyway.

And `IFrameSaver#save_to_server` which used to be sync (and is async because of this commit) isn't used anywhere outside `IFrameSaver`.


Ill change it.


Integrated developpement through automated building is important and you
should feel bad for your lack of proactivity. :~)

2015-03-04 9:18 GMT-05:00 Marc-Antoine Hinse <notifications@github.com>:

> I won't setup maven only for one jar that I'm probably going to drop anyway
>
> On Wed, Mar 4, 2015, 07:45 Louis Dion-Marcil <notifications@github.com>
> wrote:
>
> > You should setup maven for proper build requirements instead of using
> > precompiled jars.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/ldionmarcil/blindr/commit/befaccfc24be339d78b2212fb40d63cd3e4f1729#commitcomment-10028587
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ldionmarcil/blindr/commit/befaccfc24be339d78b2212fb40d63cd3e4f1729#commitcomment-10030226>
> .
>


这样记录里还是有啊,是不是没法删除的..?


line 634: compiling this with cygwin suggested to change it to:
return (!d->abstract && d->size == 0 && (d->name==jl_emptytuple || !d->mutabl));


基本的に文字列末尾は\Zより\zがよいかな？どうだろう？ http://www.rubylife.jp/regexp/anchor/index4.html


let Just r = parseUrl $ ...


このwhenブロックって必要ですか。
(setq i (argmax plist))
(if (string-equal (elt (send req :objects) i) (send req :target_object)) (send res :succeeded t) (send res :succeeded nil))
という感じだと思うのですが。(armaxは自作)


lgtm


Fuck this function to hell and back. Why did it take me 3 hours to fix this?!


この:Objecctsは:objectsのtypoですね。


let Just req = parse...


Could we also add io.js?


Some compiler warnings for this line:
```
/home/oni-link/git/neovim/src/nvim/terminal.c:876:27: warning: conversion to ‘size_t’ from ‘int’ may change the sign of the result [-Wsign-conversion]
   return term->cursor.row + term->sb_current + 1;
                           ^
/home/oni-link/git/neovim/src/nvim/terminal.c:876:3: warning: conversion to ‘int’ from ‘size_t’ may alter its value [-Wconversion]
   return term->cursor.row + term->sb_current + 1;
   ^
```


Kan det här en template stil?


actually give me a minute to confirm that. I want to make sure it's not something else breaking the tests.


Gives me this:
```
julia.h: In function ‘jl_is_datatype_singleton’:
julia.h:634:53: warning: comparison of distinct pointer types lacks a cast [enabled by default]
     return (!d->abstract && d->size == 0 && (d->name==jl_emptytuple || !d->mutabl));
                                                     ^
julia.h: At top level:
julia.h:498:30: error: expected declaration specifiers or ‘...’ before numeric constant
 #define jl_sv1(t) jl_svref(t,1)
                              ^
julia.h:743:20: note: in expansion of macro ‘jl_sv1’
 DLLEXPORT jl_sv_t *jl_sv1(void *a);
                    ^
In file included from jltypes.c:14:0:
julia_internal.h:43:26: error: unknown type name ‘jl_tuple_t’
 void jl_check_type_tuple(jl_tuple_t *t, jl_sym_t *name, const char *ctx);
[...]
```


8841-18/Mar/2013.
Zinatul Ashiqin Zainuddin.
68100, Gombak.MY


Should it has `!` even if there is no `:ok` counterpart function?


`runLoginBench` and `runSignupBench` are the same up to one expression (namely, `mk*Gens`) that can easily be moved into the argument.


OK


바인딩 주소 로그는 Akka 로그 수준을 DEBUG로 하면 TCP 매니저가 출력해주므로 불필요하다.


use smart pointers please


Här borde du kunna använda font variabeln


New and comment less "At The Moment".


不清楚，没有深究，每次都是多写几个，比字符串长就可以了。


Det är sant, jag menar i headings.styl


`/translate/searchtranslate` 还是有问题, 我根据 `infoid``141068563354155ac1a9da31.91101597` 查询翻译, 始终返回
```json
{
    "errcode": 1,
    "errmsg": "not found"
}
```
 数据库里是有这一个 `infoid` 的


1: M111 unrecognized component name: docextract


31:1: I100 Imports statements are in the wrong order. import getopt should be before import sys
34:1: I201 Missing newline before sections or imports.
37:1: I101 Imported names are in the wrong order. Should be CFG_OAI_FAILED_HARVESTING_EMAILS_ADMIN, CFG_OAI_FAILED_HARVESTING_STOP_QUEUE, CFG_SITE_SUPPORT_EMAIL
37:1: I100 Imports statements are in the wrong order. from invenio.config should be before from sqlalchemy
37:1: I201 Missing newline before sections or imports.
43:1: I101 Imported names are in the wrong order. Should be task_get_option, task_get_task_param, task_init, task_set_option, write_message
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.modules.oaiharvester.models
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.oaiharvest should be before from invenio.legacy.oaiharvest.config
50:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.oaiharvest
52:1: I100 Imports statements are in the wrong order. from invenio.base.factory should be before from invenio.ext.logging
54:1: I101 Imported names are in the wrong order. Should be compare_timestamps_with_tolerance, create_ticket, generate_harvest_report
59:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.legacy.webuser
61:1: I101 Imported names are in the wrong order. Should be BibWorkflowEngineLog, BibWorkflowObjectLog, Workflow
64:1: I100 Imports statements are in the wrong order. from invenio.modules.workflows.api should be before from invenio.modules.workflows.registry
66:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.workflows.errors
241:17: E266 too many leading '#' for block comment
258:21: E266 too many leading '#' for block comment
274: D290 White spaces around docstring should be trimmed.
280:13: E266 too many leading '#' for block comment
281:13: E266 too many leading '#' for block comment
388:27: F821 undefined name '__revision__'


1: M100 needs more reviewers
1: M101 signature is missing


1: D400 First line should end with '.', not 'd'
1: D205 Blank line missing between one-line summary and description
2: L102 copyright year is outdated, expected 2015 but got 2014
23:1: E402 module level import not at top of file
24:1: E402 module level import not at top of file
25:1: I101 Imported names are in the wrong order. Should be CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_URL
25:1: I201 Missing newline before sections or imports.
25:1: E402 module level import not at top of file
26:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
28:1: E402 module level import not at top of file
31:25: E126 continuation line over-indented for hanging indent
33:1: E302 expected 2 blank lines, found 1
33: D290 White spaces around docstring should be trimmed.
33: D203 Expected 1 blank line *before* class docstring, found 0
33: D400 First line should end with '.', not 's'
36: D400 First line should end with '.', not 'e'
36: D208 Docstring is over-indented
36: D200 One-line docstring should not occupy 3 lines
47: D209 Put multi-line docstring closing quotes on separate line
47: D400 First line should end with '.', not 'l'
47: D205 Blank line missing between one-line summary and description
47: D208 Docstring is over-indented
50:9: F841 local variable '_' is assigned to but never used
55: D401 First line should be imperative: 'Draw', not 'Draws'
55: D400 First line should end with '.', not 'r'
55: D205 Blank line missing between one-line summary and description
55: D208 Docstring is over-indented
73:5: E303 too many blank lines (2)
73: D401 First line should be imperative: 'Draw', not 'Draws'
73: D400 First line should end with '.', not 'r'
73: D205 Blank line missing between one-line summary and description
73: D208 Docstring is over-indented
87: D401 First line should be imperative: 'Draw', not 'Draws'
87: D400 First line should end with '.', not 'r'
87: D205 Blank line missing between one-line summary and description
87: D208 Docstring is over-indented
99: D209 Put multi-line docstring closing quotes on separate line
99: D400 First line should end with '.', not 'l'
99: D205 Blank line missing between one-line summary and description
99: D208 Docstring is over-indented
112: D102 Docstring missing
127: D401 First line should be imperative: 'Draw', not 'Draws'
127: D400 First line should end with '.', not 'x'
127: D205 Blank line missing between one-line summary and description
127: D208 Docstring is over-indented
146: D401 First line should be imperative: 'Draw', not 'Draws'
146: D400 First line should end with '.', not 'x'
146: D205 Blank line missing between one-line summary and description
146: D208 Docstring is over-indented
164: D401 First line should be imperative: 'Draw', not 'Draws'
164: D400 First line should end with '.', not 's'
164: D205 Blank line missing between one-line summary and description
164: D208 Docstring is over-indented
197: D401 First line should be imperative: 'Draw', not 'Draws'
197: D400 First line should end with '.', not 't'
197: D205 Blank line missing between one-line summary and description
197: D208 Docstring is over-indented
241:79: E502 the backslash is redundant between brackets
242:74: E502 the backslash is redundant between brackets
245:95: E502 the backslash is redundant between brackets
246:86: E502 the backslash is redundant between brackets
247:87: E502 the backslash is redundant between brackets
254:5: E303 too many blank lines (2)
254: D401 First line should be imperative: 'Draw', not 'Draws'
254: D209 Put multi-line docstring closing quotes on separate line
254: D400 First line should end with '.', not 'x'
254: D205 Blank line missing between one-line summary and description
254: D208 Docstring is over-indented
259:9: F841 local variable '_' is assigned to but never used
268:42: E261 at least two spaces before inline comment
268:43: E262 inline comment should start with '# '
272:31: F841 local variable 'e' is assigned to but never used
280: D401 First line should be imperative: 'Return', not 'Returns'
280: D400 First line should end with '.', not ':'
280: D205 Blank line missing between one-line summary and description
289:9: F841 local variable '_' is assigned to but never used
294:18: E225 missing whitespace around operator
296:18: E127 continuation line over-indented for visual indent
299: D401 First line should be imperative: 'Output', not 'Outputs'
299: D400 First line should end with '.', not 'o'
306: D401 First line should be imperative: 'Output', not 'Outputs'
306: D400 First line should end with '.', not 'o'
313: D401 First line should be imperative: 'Output', not 'Outputs'
313: D400 First line should end with '.', not 's'
315:9: F841 local variable '_' is assigned to but never used
322: D401 First line should be imperative: 'Print', not 'Prints'
322: D209 Put multi-line docstring closing quotes on separate line
322: D400 First line should end with '.', not 't'
322: D205 Blank line missing between one-line summary and description
322: D208 Docstring is over-indented
336: D401 First line should be imperative: 'Print', not 'Prints'
336: D400 First line should end with '.', not 'e'
338:9: F841 local variable '_' is assigned to but never used
343: D102 Docstring missing
347: D400 First line should end with '.', not 'n'
360:15: E221 multiple spaces before operator
377: D401 First line should be imperative: 'Print', not 'Prints'
377: D400 First line should end with '.', not ','
377: D205 Blank line missing between one-line summary and description
406: D102 Docstring missing
408:22: E711 comparison to None should be 'if cond is not None:'
415: D102 Docstring missing
418: D102 Docstring missing
424:21: E711 comparison to None should be 'if cond is not None:'
429: D102 Docstring missing
435:21: E711 comparison to None should be 'if cond is not None:'
440: D102 Docstring missing
443: D102 Docstring missing
446: D400 First line should end with '.', not 'y'
449:65: E502 the backslash is redundant between brackets
451:46: E231 missing whitespace after ':'
457:34: E127 continuation line over-indented for visual indent
459: D102 Docstring missing
467: D102 Docstring missing
471: D102 Docstring missing
474: D102 Docstring missing
477: D102 Docstring missing
483: D102 Docstring missing
489: D401 First line should be imperative: 'construct', not 'constructs'
489: D400 First line should end with '.', not 'r'
492:26: E711 comparison to None should be 'if cond is None:'
508:68: E502 the backslash is redundant between brackets
510:49: E231 missing whitespace after ':'
515:68: E502 the backslash is redundant between brackets
517:49: E231 missing whitespace after ':'
527: D102 Docstring missing
534: D401 First line should be imperative: 'Write', not 'Writes'
534: D400 First line should end with '.', not 's'
578: D401 First line should be imperative: 'Create', not 'Creates'
578: D205 Blank line missing between one-line summary and description
603: D102 Docstring missing
607: D400 First line should end with '.', not 'u'
607: D208 Docstring is over-indented
607: D200 One-line docstring should not occupy 3 lines
620:70: E502 the backslash is redundant between brackets
624:72: E502 the backslash is redundant between brackets
625:38: E128 continuation line under-indented for visual indent
626:38: E128 continuation line under-indented for visual indent
627:38: E128 continuation line under-indented for visual indent
628:70: E502 the backslash is redundant between brackets
632:70: E502 the backslash is redundant between brackets
636:73: E502 the backslash is redundant between brackets
641:63: E203 whitespace before ','
644:23: E711 comparison to None should be 'if cond is not None:'
646:23: E126 continuation line over-indented for hanging indent
654: D401 First line should be imperative: 'Convert', not 'Converts'
654: D400 First line should end with '.', not 's'
654: D205 Blank line missing between one-line summary and description
665: D401 First line should be imperative: 'format', not 'formats'
665: D400 First line should end with '.', not 't'
665: D205 Blank line missing between one-line summary and description
671:17: E711 comparison to None should be 'if cond is None:'
675: D102 Docstring missing
676:17: E711 comparison to None should be 'if cond is None:'
680: D102 Docstring missing
681:25: E711 comparison to None should be 'if cond is None:'
684:16: E127 continuation line over-indented for visual indent
685:16: E127 continuation line over-indented for visual indent
687: D102 Docstring missing
698: D400 First line should end with '.', not 'w'
698: D205 Blank line missing between one-line summary and description
698: D208 Docstring is over-indented
710:21: E126 continuation line over-indented for hanging indent
711:28: E203 whitespace before ':'
712:17: E121 continuation line under-indented for hanging indent
725:22: E203 whitespace before ':'
726:28: E203 whitespace before ':'
727:8: E122 continuation line missing indentation or outdented
729: D400 First line should end with '.', not 'e'
729: D205 Blank line missing between one-line summary and description
750:16: E713 test for membership should be 'not in'


2: L101 copyright is missing


3: L102 copyright year is outdated, expected 2015 but got 2014


3: L102 copyright year is outdated, expected 2015 but got 2011


1: M111 unrecognized component name: general


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2013
26:1: I100 Imports statements are in the wrong order. from invenio.legacy.docextract.text should be before from invenio.legacy.refextract.kbs
45: D103 Docstring missing
57: D103 Docstring missing
66:1: E302 expected 2 blank lines, found 1
66: D103 Docstring missing
74: D103 Docstring missing
78: D400 First line should end with '.', not 'e'
101: D400 First line should end with '.', not 'd'
101: D205 Blank line missing between one-line summary and description
101: D208 Docstring is over-indented
117: D103 Docstring missing
142: D400 First line should end with '.', not 'e'
142: D205 Blank line missing between one-line summary and description
142: D208 Docstring is over-indented


1: D100 Docstring missing
24: D103 Docstring missing


4: L102 copyright year is outdated, expected 2015 but got 2014
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
37:1: I100 Imports statements are in the wrong order. import cgi should be before import time
37:1: E402 module level import not at top of file
38:1: E402 module level import not at top of file
39:1: I100 Imports statements are in the wrong order. import binascii should be before import subprocess
39:1: E402 module level import not at top of file
40:1: I100 Imports statements are in the wrong order. import StringIO should be before import binascii
40:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
43:1: I100 Imports statements are in the wrong order. from functools should be before from flask
43:1: I201 Missing newline before sections or imports.
43:1: E402 module level import not at top of file
44:1: E402 module level import not at top of file
45:1: I201 Missing newline before sections or imports.
45:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: I100 Imports statements are in the wrong order. from urllib should be before from six.moves.urllib.parse
47:1: I201 Missing newline before sections or imports.
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from itertools should be before from urllib
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
133:1: E402 module level import not at top of file
136:1: F401 'pyparsing' imported but unused
136:1: E402 module level import not at top of file
137:1: I100 Imports statements are in the wrong order. from flask.ext.testing should be before import pyparsing
137:1: I201 Missing newline before sections or imports.
137:1: E402 module level import not at top of file
215: D101 Docstring missing
216: D102 Docstring missing
251:5: E731 do not assign a lambda expression, use a def
371:5: B901 blind except: statement
792:9: B901 blind except: statement
813:9: B901 blind except: statement
837:9: B901 blind except: statement
869:9: B901 blind except: statement
880:13: B901 blind except: statement
903:9: B901 blind except: statement
924:9: B901 blind except: statement
941:9: B901 blind except: statement
1191:9: B901 blind except: statement


1: D100 Docstring missing


1: D200 One-line docstring should not occupy 3 lines
2: L102 copyright year is outdated, expected 2015 but got 2013
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: I100 Imports statements are in the wrong order. import cgi should be before import unittest
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
36:1: I100 Imports statements are in the wrong order. from functools should be before from warnings
36:1: E402 module level import not at top of file
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from urllib should be before from urlparse
38:1: E402 module level import not at top of file
39:1: I100 Imports statements are in the wrong order. from itertools should be before from urllib
39:1: E402 module level import not at top of file
48:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_JSTESTDRIVER_PORT, CFG_LOGDIR, CFG_PREFIX, CFG_PYLIBDIR, CFG_SITE_NAME_INTL, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_WEBDIR
48:1: E402 module level import not at top of file
57:1: I101 Imported names are in the wrong order. Should be CFG_TESTS_REQUIRE_HTML_VALIDATION, w3c_errors_to_str, w3c_validate
57:1: E402 module level import not at top of file
58:36: E128 continuation line under-indented for visual indent
59:36: E128 continuation line under-indented for visual indent
69:1: E302 expected 2 blank lines, found 1
70: D202 No blank lines allowed *after* function docstring, found 1
70: D400 First line should end with '.', not 'y'
70: D205 Blank line missing between one-line summary and description
126:1: E302 expected 2 blank lines, found 1
127: D290 White spaces around docstring should be trimmed.
127: D400 First line should end with '.', not 's'
132:1: E302 expected 2 blank lines, found 1
133: D400 First line should end with '.', not 'e'
133: D205 Blank line missing between one-line summary and description
143:1: E302 expected 2 blank lines, found 1
143: D290 White spaces around docstring should be trimmed.
143: D209 Put multi-line docstring closing quotes on separate line
143: D202 No blank lines allowed *after* function docstring, found 1
143: D400 First line should end with '.', not 'y'
143: D205 Blank line missing between one-line summary and description
154:1: E302 expected 2 blank lines, found 1
154: D290 White spaces around docstring should be trimmed.
154: D209 Put multi-line docstring closing quotes on separate line
154: D202 No blank lines allowed *after* function docstring, found 1
154: D400 First line should end with '.', not 'y'
154: D205 Blank line missing between one-line summary and description
165:1: E302 expected 2 blank lines, found 1
165: D290 White spaces around docstring should be trimmed.
165: D209 Put multi-line docstring closing quotes on separate line
165: D202 No blank lines allowed *after* function docstring, found 1
165: D400 First line should end with '.', not 'y'
165: D205 Blank line missing between one-line summary and description
176:1: E302 expected 2 blank lines, found 1
176: D203 Expected 1 blank line *before* class docstring, found 0
176: D204 Expected 1 blank line *after* class docstring, found 0
180:1: E302 expected 2 blank lines, found 1
181: D205 Blank line missing between one-line summary and description
190:5: B901 blind except: statement
194:1: E302 expected 2 blank lines, found 1
194: D400 First line should end with '.', not 'd'
194: D205 Blank line missing between one-line summary and description
204:37: E261 at least two spaces before inline comment
219:1: E302 expected 2 blank lines, found 1
220: D400 First line should end with '.', not 's'
220: D205 Blank line missing between one-line summary and description
220: D208 Docstring is over-indented
272:55: W602 deprecated form of raising exception
273:23: E126 continuation line over-indented for hanging indent
289:55: W602 deprecated form of raising exception
290:23: E127 continuation line over-indented for visual indent
299:20: E126 continuation line over-indented for hanging indent
304:20: E127 continuation line over-indented for visual indent
319:59: W602 deprecated form of raising exception
320:27: E126 continuation line over-indented for hanging indent
328:35: E126 continuation line over-indented for hanging indent
330:55: W602 deprecated form of raising exception
333:5: E303 too many blank lines (2)
334:80: E502 the backslash is redundant between brackets
337:82: E502 the backslash is redundant between brackets
356:1: E302 expected 2 blank lines, found 1
356: D400 First line should end with '.', not 'y'
356: D205 Blank line missing between one-line summary and description
356: D208 Docstring is over-indented
366:1: E302 expected 2 blank lines, found 1
367: D202 No blank lines allowed *after* function docstring, found 1
367: D400 First line should end with '.', not 'd'
367: D205 Blank line missing between one-line summary and description
390:1: E302 expected 2 blank lines, found 1
391: D400 First line should end with '.', not 'h'
391: D205 Blank line missing between one-line summary and description
397: D400 First line should end with '.', not 'd'
397: D200 One-line docstring should not occupy 3 lines
418: D400 First line should end with '.', not 'n'
418: D205 Blank line missing between one-line summary and description
432:145: E502 the backslash is redundant between brackets
442:9: E128 continuation line under-indented for visual indent
464:1: E302 expected 2 blank lines, found 1
465: D202 No blank lines allowed *after* function docstring, found 1
465: D400 First line should end with '.', not 'y'
465: D205 Blank line missing between one-line summary and description
490:1: E302 expected 2 blank lines, found 1
491: D202 No blank lines allowed *after* function docstring, found 1
491: D400 First line should end with '.', not 'y'
491: D205 Blank line missing between one-line summary and description
517: D203 Expected 1 blank line *before* class docstring, found 0
517: D204 Expected 1 blank line *after* class docstring, found 0
517: D300 Expected """-quotes, got '-quotes
528: D290 White spaces around docstring should be trimmed.
528: D203 Expected 1 blank line *before* class docstring, found 0
528: D400 First line should end with '.', not 's'
528: D205 Blank line missing between one-line summary and description
533: D202 No blank lines allowed *after* method docstring, found 1
536:9: E266 too many leading '#' for block comment
547: D202 No blank lines allowed *after* method docstring, found 1
553: D290 White spaces around docstring should be trimmed.
553: D202 No blank lines allowed *after* method docstring, found 1
553: D400 First line should end with '.', not 's'
553: D205 Blank line missing between one-line summary and description
566:9: B901 blind except: statement
569: D290 White spaces around docstring should be trimmed.
569: D202 No blank lines allowed *after* method docstring, found 1
569: D400 First line should end with '.', not 's'
569: D205 Blank line missing between one-line summary and description
582:9: B901 blind except: statement
585: D290 White spaces around docstring should be trimmed.
585: D202 No blank lines allowed *after* method docstring, found 1
585: D400 First line should end with '.', not 's'
585: D205 Blank line missing between one-line summary and description
598:9: B901 blind except: statement
601: D290 White spaces around docstring should be trimmed.
601: D202 No blank lines allowed *after* method docstring, found 1
601: D400 First line should end with '.', not 's'
601: D205 Blank line missing between one-line summary and description
622:9: B901 blind except: statement
629:123: E225 missing whitespace around operator
630:13: B901 blind except: statement
637: D290 White spaces around docstring should be trimmed.
637: D202 No blank lines allowed *after* method docstring, found 1
637: D400 First line should end with '.', not 's'
637: D205 Blank line missing between one-line summary and description
650:9: B901 blind except: statement
653: D290 White spaces around docstring should be trimmed.
653: D202 No blank lines allowed *after* method docstring, found 1
653: D400 First line should end with '.', not 's'
653: D205 Blank line missing between one-line summary and description
666:9: B901 blind except: statement
669: D290 White spaces around docstring should be trimmed.
669: D202 No blank lines allowed *after* method docstring, found 1
669: D400 First line should end with '.', not 's'
669: D205 Blank line missing between one-line summary and description
682:9: B901 blind except: statement
685: D290 White spaces around docstring should be trimmed.
685: D202 No blank lines allowed *after* method docstring, found 1
685: D400 First line should end with '.', not 's'
685: D205 Blank line missing between one-line summary and description
697:9: B901 blind except: statement
700: D290 White spaces around docstring should be trimmed.
700: D400 First line should end with '.', not 'd'
700: D205 Blank line missing between one-line summary and description
710:9: B901 blind except: statement
713: D290 White spaces around docstring should be trimmed.
713: D400 First line should end with '.', not 'd'
713: D205 Blank line missing between one-line summary and description
723:9: B901 blind except: statement
726: D290 White spaces around docstring should be trimmed.
726: D400 First line should end with '.', not 'n'
726: D205 Blank line missing between one-line summary and description
741:16: E713 test for membership should be 'not in'
765: D290 White spaces around docstring should be trimmed.
765: D202 No blank lines allowed *after* method docstring, found 1
765: D400 First line should end with '.', not 'n'
765: D200 One-line docstring should not occupy 2 lines
773:66: E502 the backslash is redundant between brackets
773: D290 White spaces around docstring should be trimmed.
773: D202 No blank lines allowed *after* method docstring, found 1
773: D400 First line should end with '.', not 'n'
773: D205 Blank line missing between one-line summary and description
823: D290 White spaces around docstring should be trimmed.
823: D202 No blank lines allowed *after* method docstring, found 1
823: D400 First line should end with '.', not 's'
823: D205 Blank line missing between one-line summary and description
861: D290 White spaces around docstring should be trimmed.
861: D202 No blank lines allowed *after* method docstring, found 1
861: D400 First line should end with '.', not 'n'
861: D205 Blank line missing between one-line summary and description
887: D290 White spaces around docstring should be trimmed.
887: D202 No blank lines allowed *after* method docstring, found 1
887: D400 First line should end with '.', not 'n'
887: D205 Blank line missing between one-line summary and description
910: D290 White spaces around docstring should be trimmed.
910: D202 No blank lines allowed *after* method docstring, found 1
910: D400 First line should end with '.', not 'n'
910: D205 Blank line missing between one-line summary and description
936: D290 White spaces around docstring should be trimmed.
936: D202 No blank lines allowed *after* method docstring, found 1
936: D400 First line should end with '.', not 't'
936: D205 Blank line missing between one-line summary and description
957: D290 White spaces around docstring should be trimmed.
957: D209 Put multi-line docstring closing quotes on separate line
957: D202 No blank lines allowed *after* method docstring, found 1
957: D400 First line should end with '.', not 'n'
957: D205 Blank line missing between one-line summary and description
964:9: B901 blind except: statement
968: D203 Expected 1 blank line *before* class docstring, found 0
968: D400 First line should end with '.', not 't'
968: D205 Blank line missing between one-line summary and description
995: D103 Docstring missing
1003: D401 First line should be imperative: 'Make', not 'Makes'
1003: D400 First line should end with '.', not 'r'


86:40: E128 continuation line under-indented for visual indent


199:1: E303 too many blank lines (3)


I'm assuming all the parens around the print statements are to bring the code into v3 compliance?


Nice. :smile: