26:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.bibrecord should be before from invenio.testutils
28:1: E402 module level import not at top of file
29:1: I101 Imported names are in the wrong order. Should be Querystring, match_records, transform_input_to_marcxml
29:1: I100 Imports statements are in the wrong order. from invenio.bibmatch_engine should be before from invenio.bibrecord
29:1: E402 module level import not at top of file
30:37: E126 continuation line over-indented for hanging indent
31:1: E402 module level import not at top of file
32:1: I100 Imports statements are in the wrong order. from invenio.invenio_connector should be before from invenio.testutils
32:1: E402 module level import not at top of file
34:1: E302 expected 2 blank lines, found 1
34: D203 Expected 1 blank line *before* class docstring, found 0
37: D400 First line should end with '.', not 's'
547: D400 First line should end with '.', not 'd'
551:75: E502 the backslash is redundant between brackets
552:77: E502 the backslash is redundant between brackets
558:72: E502 the backslash is redundant between brackets
559:74: E502 the backslash is redundant between brackets
566:72: E502 the backslash is redundant between brackets
570: D400 First line should end with '.', not 'd'
573:68: E502 the backslash is redundant between brackets
577: D400 First line should end with '.', not 'd'
580:70: E502 the backslash is redundant between brackets
584: D400 First line should end with '.', not 'd'
587:70: E502 the backslash is redundant between brackets
591: D400 First line should end with '.', not ')'
594:72: E502 the backslash is redundant between brackets
595:110: E502 the backslash is redundant between brackets
599: D400 First line should end with '.', not 't'
603:72: E502 the backslash is redundant between brackets
607: D400 First line should end with '.', not 'h'
611:72: E502 the backslash is redundant between brackets
612:73: E502 the backslash is redundant between brackets
616: D400 First line should end with '.', not 's'
627: D400 First line should end with '.', not 'n'
630:72: E502 the backslash is redundant between brackets
631:86: E502 the backslash is redundant between brackets
634:72: E502 the backslash is redundant between brackets
635:89: E502 the backslash is redundant between brackets
639: D400 First line should end with '.', not 'h'
643:72: E502 the backslash is redundant between brackets
644:91: E502 the backslash is redundant between brackets
645:87: E502 the backslash is redundant between brackets
651:76: E502 the backslash is redundant between brackets
652:95: E502 the backslash is redundant between brackets
653:91: E502 the backslash is redundant between brackets
655:89: E502 the backslash is redundant between brackets
661: D400 First line should end with '.', not 'h'
665:76: E502 the backslash is redundant between brackets
666:95: E502 the backslash is redundant between brackets
667:91: E502 the backslash is redundant between brackets
668:115: E502 the backslash is redundant between brackets
669:82: E502 the backslash is redundant between brackets
674:76: E502 the backslash is redundant between brackets
675:95: E502 the backslash is redundant between brackets
676:91: E502 the backslash is redundant between brackets
677:115: E502 the backslash is redundant between brackets
678:80: E502 the backslash is redundant between brackets


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


1: D400 First line should end with '.', not ','
1: D205 Blank line missing between one-line summary and description
1: L101 copyright is missing


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing
24:1: F401 'os' imported but unused
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:39: E126 continuation line over-indented for hanging indent
29:1: I101 Imported names are in the wrong order. Should be CFG_SITE_SECURE_URL, CFG_SITE_URL
29:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.invenio_connector
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
32:1: E302 expected 2 blank lines, found 1
32: D203 Expected 1 blank line *before* class docstring, found 0
35: D400 First line should end with '.', not 'h'
39:42: E502 the backslash is redundant between brackets
42: D400 First line should end with '.', not 'h'
46:42: E502 the backslash is redundant between brackets
49: D400 First line should end with '.', not 'h'
53:42: E502 the backslash is redundant between brackets
56: D400 First line should end with '.', not 'h'
64:42: E502 the backslash is redundant between brackets
67: D400 First line should end with '.', not 'h'
75:42: E502 the backslash is redundant between brackets


24:1: F401 'os' imported but unused
24:1: E402 module level import not at top of file
25:1: I201 Missing newline before sections or imports.
25:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. from invenio.invenio_connector should be before from invenio.testutils
27:1: E402 module level import not at top of file
28:39: E126 continuation line over-indented for hanging indent
29:1: I101 Imported names are in the wrong order. Should be CFG_SITE_SECURE_URL, CFG_SITE_URL
29:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.invenio_connector
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
32:1: E302 expected 2 blank lines, found 1
32: D203 Expected 1 blank line *before* class docstring, found 0
35: D400 First line should end with '.', not 'h'
39:42: E502 the backslash is redundant between brackets
42: D400 First line should end with '.', not 'h'
46:42: E502 the backslash is redundant between brackets
49: D400 First line should end with '.', not 'h'
53:42: E502 the backslash is redundant between brackets
56: D400 First line should end with '.', not 'h'
65:42: E502 the backslash is redundant between brackets
68: D400 First line should end with '.', not 'h'
76:42: E502 the backslash is redundant between brackets


26:1: I101 Imported names are in the wrong order. Should be CFG_WEBSEARCH_EXTERNAL_COLLECTION_SEARCH_MAXRESULTS, CFG_WEBSEARCH_EXTERNAL_COLLECTION_SEARCH_TIMEOUT
26:1: E402 module level import not at top of file
27:6: E126 continuation line over-indented for hanging indent
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
72:122: E502 the backslash is redundant between brackets
73:125: E502 the backslash is redundant between brackets
74:125: E502 the backslash is redundant between brackets
133:93: E231 missing whitespace after ':'


1:1: E266 too many leading '#' for block comment
1: D200 One-line docstring should not occupy 3 lines
2:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
5:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
10:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
15:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
20: L101 copyright is missing
37:1: E402 module level import not at top of file
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: I100 Imports statements are in the wrong order. import cgi should be before import unittest
41:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: I100 Imports statements are in the wrong order. from urlparse should be before from warnings
44:1: E402 module level import not at top of file
45:1: I100 Imports statements are in the wrong order. from urllib should be before from urlparse
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from itertools should be before from urllib
46:1: E402 module level import not at top of file
55:1: I101 Imported names are in the wrong order. Should be CFG_LOGDIR, CFG_PYLIBDIR, CFG_SITE_NAME_INTL, CFG_SITE_SECURE_URL, CFG_SITE_URL
55:1: E402 module level import not at top of file
56:6: E126 continuation line over-indented for hanging indent
57:1: I101 Imported names are in the wrong order. Should be CFG_TESTS_REQUIRE_HTML_VALIDATION, w3c_errors_to_str, w3c_validate
57:1: E402 module level import not at top of file
58:6: E126 continuation line over-indented for hanging indent
59:1: I100 Imports statements are in the wrong order. from invenio.pluginutils should be before from invenio.w3c_validator
59:1: E402 module level import not at top of file
69:1: E302 expected 2 blank lines, found 1
70: D202 No blank lines allowed *after* function docstring, found 1
70: D400 First line should end with '.', not 'y'
70: D205 Blank line missing between one-line summary and description
126:1: E302 expected 2 blank lines, found 1
127: D290 White spaces around docstring should be trimmed.
127: D400 First line should end with '.', not 's'
132:1: E302 expected 2 blank lines, found 1
133: D400 First line should end with '.', not 'e'
133: D205 Blank line missing between one-line summary and description
143:1: E302 expected 2 blank lines, found 1
143: D290 White spaces around docstring should be trimmed.
143: D209 Put multi-line docstring closing quotes on separate line
143: D202 No blank lines allowed *after* function docstring, found 1
143: D400 First line should end with '.', not 'y'
143: D205 Blank line missing between one-line summary and description
154:1: E302 expected 2 blank lines, found 1
154: D290 White spaces around docstring should be trimmed.
154: D209 Put multi-line docstring closing quotes on separate line
154: D202 No blank lines allowed *after* function docstring, found 1
154: D400 First line should end with '.', not 'y'
154: D205 Blank line missing between one-line summary and description
165:1: E302 expected 2 blank lines, found 1
165: D203 Expected 1 blank line *before* class docstring, found 0
165: D204 Expected 1 blank line *after* class docstring, found 0
169:1: E302 expected 2 blank lines, found 1
170: D205 Blank line missing between one-line summary and description
179:5: B901 blind except: statement
183:1: E302 expected 2 blank lines, found 1
183: D400 First line should end with '.', not 'd'
183: D205 Blank line missing between one-line summary and description
193:37: E261 at least two spaces before inline comment
208:1: E302 expected 2 blank lines, found 1
209: D400 First line should end with '.', not 's'
209: D205 Blank line missing between one-line summary and description
209: D208 Docstring is over-indented
261:55: W602 deprecated form of raising exception
262:23: E126 continuation line over-indented for hanging indent
278:55: W602 deprecated form of raising exception
279:23: E127 continuation line over-indented for visual indent
288:20: E126 continuation line over-indented for hanging indent
293:20: E127 continuation line over-indented for visual indent
308:59: W602 deprecated form of raising exception
309:27: E126 continuation line over-indented for hanging indent
317:35: E126 continuation line over-indented for hanging indent
319:55: W602 deprecated form of raising exception
322:5: E303 too many blank lines (2)
323:80: E502 the backslash is redundant between brackets
326:82: E502 the backslash is redundant between brackets
345:1: E302 expected 2 blank lines, found 1
345: D400 First line should end with '.', not 'y'
345: D205 Blank line missing between one-line summary and description
345: D208 Docstring is over-indented
355:1: E302 expected 2 blank lines, found 1
356: D202 No blank lines allowed *after* function docstring, found 1
356: D400 First line should end with '.', not 'd'
356: D205 Blank line missing between one-line summary and description
378:1: E302 expected 2 blank lines, found 1
379: D202 No blank lines allowed *after* function docstring, found 1
379: D400 First line should end with '.', not 'y'
379: D205 Blank line missing between one-line summary and description
403:1: E302 expected 2 blank lines, found 1
404: D202 No blank lines allowed *after* function docstring, found 1
404: D400 First line should end with '.', not 'y'
404: D205 Blank line missing between one-line summary and description
429: D290 White spaces around docstring should be trimmed.
429: D203 Expected 1 blank line *before* class docstring, found 0
429: D400 First line should end with '.', not 's'
429: D205 Blank line missing between one-line summary and description
434: D202 No blank lines allowed *after* method docstring, found 1
437:9: E266 too many leading '#' for block comment
448: D202 No blank lines allowed *after* method docstring, found 1
454: D290 White spaces around docstring should be trimmed.
454: D202 No blank lines allowed *after* method docstring, found 1
454: D400 First line should end with '.', not 's'
454: D205 Blank line missing between one-line summary and description
467:9: B901 blind except: statement
470: D290 White spaces around docstring should be trimmed.
470: D202 No blank lines allowed *after* method docstring, found 1
470: D400 First line should end with '.', not 's'
470: D205 Blank line missing between one-line summary and description
483:9: B901 blind except: statement
486: D290 White spaces around docstring should be trimmed.
486: D202 No blank lines allowed *after* method docstring, found 1
486: D400 First line should end with '.', not 's'
486: D205 Blank line missing between one-line summary and description
499:9: B901 blind except: statement
502: D290 White spaces around docstring should be trimmed.
502: D202 No blank lines allowed *after* method docstring, found 1
502: D400 First line should end with '.', not 's'
502: D205 Blank line missing between one-line summary and description
523:9: B901 blind except: statement
530:123: E225 missing whitespace around operator
531:13: B901 blind except: statement
538: D290 White spaces around docstring should be trimmed.
538: D202 No blank lines allowed *after* method docstring, found 1
538: D400 First line should end with '.', not 's'
538: D205 Blank line missing between one-line summary and description
551:9: B901 blind except: statement
554: D290 White spaces around docstring should be trimmed.
554: D202 No blank lines allowed *after* method docstring, found 1
554: D400 First line should end with '.', not 's'
554: D205 Blank line missing between one-line summary and description
567:9: B901 blind except: statement
570: D290 White spaces around docstring should be trimmed.
570: D202 No blank lines allowed *after* method docstring, found 1
570: D400 First line should end with '.', not 's'
570: D205 Blank line missing between one-line summary and description
582:9: B901 blind except: statement
585: D290 White spaces around docstring should be trimmed.
585: D400 First line should end with '.', not 'n'
585: D205 Blank line missing between one-line summary and description
595:12: E713 test for membership should be 'not in'
619: D290 White spaces around docstring should be trimmed.
619: D202 No blank lines allowed *after* method docstring, found 1
619: D400 First line should end with '.', not 'n'
619: D200 One-line docstring should not occupy 2 lines
627:66: E502 the backslash is redundant between brackets
627: D290 White spaces around docstring should be trimmed.
627: D202 No blank lines allowed *after* method docstring, found 1
627: D400 First line should end with '.', not 'n'
627: D205 Blank line missing between one-line summary and description
671: D290 White spaces around docstring should be trimmed.
671: D202 No blank lines allowed *after* method docstring, found 1
671: D400 First line should end with '.', not 's'
671: D205 Blank line missing between one-line summary and description
709: D290 White spaces around docstring should be trimmed.
709: D202 No blank lines allowed *after* method docstring, found 1
709: D400 First line should end with '.', not 'n'
709: D205 Blank line missing between one-line summary and description
735: D290 White spaces around docstring should be trimmed.
735: D202 No blank lines allowed *after* method docstring, found 1
735: D400 First line should end with '.', not 'n'
735: D205 Blank line missing between one-line summary and description
758: D290 White spaces around docstring should be trimmed.
758: D202 No blank lines allowed *after* method docstring, found 1
758: D400 First line should end with '.', not 'n'
758: D205 Blank line missing between one-line summary and description
784: D290 White spaces around docstring should be trimmed.
784: D202 No blank lines allowed *after* method docstring, found 1
784: D400 First line should end with '.', not 't'
784: D205 Blank line missing between one-line summary and description
805: D290 White spaces around docstring should be trimmed.
805: D209 Put multi-line docstring closing quotes on separate line
805: D202 No blank lines allowed *after* method docstring, found 1
805: D400 First line should end with '.', not 'n'
805: D205 Blank line missing between one-line summary and description
812:9: B901 blind except: statement
816: D203 Expected 1 blank line *before* class docstring, found 0
816: D400 First line should end with '.', not 't'
816: D205 Blank line missing between one-line summary and description


1: D200 One-line docstring should not occupy 3 lines
37:1: E402 module level import not at top of file
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: I100 Imports statements are in the wrong order. import cgi should be before import unittest
41:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
43:1: I100 Imports statements are in the wrong order. import difflib should be before import subprocess
43:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from functools should be before from warnings
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from urllib should be before from urlparse
48:1: E402 module level import not at top of file
49:1: I100 Imports statements are in the wrong order. from itertools should be before from urllib
49:1: E402 module level import not at top of file
50:1: E402 module level import not at top of file
59:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_JSTESTDRIVER_PORT, CFG_LOGDIR, CFG_PREFIX, CFG_PYLIBDIR, CFG_SITE_NAME_INTL, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_WEBDIR
59:1: E402 module level import not at top of file
68:1: I101 Imported names are in the wrong order. Should be CFG_TESTS_REQUIRE_HTML_VALIDATION, w3c_errors_to_str, w3c_validate
68:1: E402 module level import not at top of file
71:1: I100 Imports statements are in the wrong order. from invenio.pluginutils should be before from invenio.w3c_validator
71:1: E402 module level import not at top of file
81:1: E302 expected 2 blank lines, found 1
82: D202 No blank lines allowed *after* function docstring, found 1
82: D400 First line should end with '.', not 'y'
82: D205 Blank line missing between one-line summary and description
138:1: E302 expected 2 blank lines, found 1
139: D290 White spaces around docstring should be trimmed.
139: D400 First line should end with '.', not 's'
144:1: E302 expected 2 blank lines, found 1
145: D400 First line should end with '.', not 'e'
145: D205 Blank line missing between one-line summary and description
155:1: E302 expected 2 blank lines, found 1
155: D290 White spaces around docstring should be trimmed.
155: D209 Put multi-line docstring closing quotes on separate line
155: D202 No blank lines allowed *after* function docstring, found 1
155: D400 First line should end with '.', not 'y'
155: D205 Blank line missing between one-line summary and description
166:1: E302 expected 2 blank lines, found 1
166: D290 White spaces around docstring should be trimmed.
166: D209 Put multi-line docstring closing quotes on separate line
166: D202 No blank lines allowed *after* function docstring, found 1
166: D400 First line should end with '.', not 'y'
166: D205 Blank line missing between one-line summary and description
177:1: E302 expected 2 blank lines, found 1
177: D290 White spaces around docstring should be trimmed.
177: D209 Put multi-line docstring closing quotes on separate line
177: D202 No blank lines allowed *after* function docstring, found 1
177: D400 First line should end with '.', not 'y'
177: D205 Blank line missing between one-line summary and description
188:1: E302 expected 2 blank lines, found 1
188: D203 Expected 1 blank line *before* class docstring, found 0
188: D204 Expected 1 blank line *after* class docstring, found 0
192:1: E302 expected 2 blank lines, found 1
193: D205 Blank line missing between one-line summary and description
202:5: B901 blind except: statement
206:1: E302 expected 2 blank lines, found 1
206: D400 First line should end with '.', not 'd'
206: D205 Blank line missing between one-line summary and description
216:37: E261 at least two spaces before inline comment
231:1: E302 expected 2 blank lines, found 1
232: D400 First line should end with '.', not 's'
232: D205 Blank line missing between one-line summary and description
232: D208 Docstring is over-indented
284:55: W602 deprecated form of raising exception
285:23: E126 continuation line over-indented for hanging indent
301:55: W602 deprecated form of raising exception
302:23: E127 continuation line over-indented for visual indent
311:20: E126 continuation line over-indented for hanging indent
316:20: E127 continuation line over-indented for visual indent
331:59: W602 deprecated form of raising exception
332:27: E126 continuation line over-indented for hanging indent
340:35: E126 continuation line over-indented for hanging indent
342:55: W602 deprecated form of raising exception
345:5: E303 too many blank lines (2)
346:80: E502 the backslash is redundant between brackets
349:82: E502 the backslash is redundant between brackets
368:1: E302 expected 2 blank lines, found 1
368: D400 First line should end with '.', not 'y'
368: D205 Blank line missing between one-line summary and description
368: D208 Docstring is over-indented
378:1: E302 expected 2 blank lines, found 1
379: D202 No blank lines allowed *after* function docstring, found 1
379: D400 First line should end with '.', not 'd'
379: D205 Blank line missing between one-line summary and description
401:1: E302 expected 2 blank lines, found 1
402: D400 First line should end with '.', not 'h'
402: D205 Blank line missing between one-line summary and description
408: D400 First line should end with '.', not 'd'
408: D200 One-line docstring should not occupy 3 lines
429: D400 First line should end with '.', not 'n'
429: D205 Blank line missing between one-line summary and description
443:145: E502 the backslash is redundant between brackets
453:9: E128 continuation line under-indented for visual indent
475:1: E302 expected 2 blank lines, found 1
476: D202 No blank lines allowed *after* function docstring, found 1
476: D400 First line should end with '.', not 'y'
476: D205 Blank line missing between one-line summary and description
500:1: E302 expected 2 blank lines, found 1
501: D202 No blank lines allowed *after* function docstring, found 1
501: D400 First line should end with '.', not 'y'
501: D205 Blank line missing between one-line summary and description
526: D203 Expected 1 blank line *before* class docstring, found 0
526: D204 Expected 1 blank line *after* class docstring, found 0
526: D300 Expected """-quotes, got '-quotes
537: D290 White spaces around docstring should be trimmed.
537: D203 Expected 1 blank line *before* class docstring, found 0
537: D400 First line should end with '.', not 's'
537: D205 Blank line missing between one-line summary and description
542: D202 No blank lines allowed *after* method docstring, found 1
545:9: E266 too many leading '#' for block comment
556: D202 No blank lines allowed *after* method docstring, found 1
562: D290 White spaces around docstring should be trimmed.
562: D202 No blank lines allowed *after* method docstring, found 1
562: D400 First line should end with '.', not 's'
562: D205 Blank line missing between one-line summary and description
575:9: B901 blind except: statement
578: D290 White spaces around docstring should be trimmed.
578: D202 No blank lines allowed *after* method docstring, found 1
578: D400 First line should end with '.', not 's'
578: D205 Blank line missing between one-line summary and description
591:9: B901 blind except: statement
594: D290 White spaces around docstring should be trimmed.
594: D202 No blank lines allowed *after* method docstring, found 1
594: D400 First line should end with '.', not 's'
594: D205 Blank line missing between one-line summary and description
607:9: B901 blind except: statement
610: D290 White spaces around docstring should be trimmed.
610: D202 No blank lines allowed *after* method docstring, found 1
610: D400 First line should end with '.', not 's'
610: D205 Blank line missing between one-line summary and description
631:9: B901 blind except: statement
638:123: E225 missing whitespace around operator
639:13: B901 blind except: statement
646: D290 White spaces around docstring should be trimmed.
646: D202 No blank lines allowed *after* method docstring, found 1
646: D400 First line should end with '.', not 's'
646: D205 Blank line missing between one-line summary and description
659:9: B901 blind except: statement
662: D290 White spaces around docstring should be trimmed.
662: D202 No blank lines allowed *after* method docstring, found 1
662: D400 First line should end with '.', not 's'
662: D205 Blank line missing between one-line summary and description
675:9: B901 blind except: statement
678: D290 White spaces around docstring should be trimmed.
678: D202 No blank lines allowed *after* method docstring, found 1
678: D400 First line should end with '.', not 's'
678: D205 Blank line missing between one-line summary and description
691:9: B901 blind except: statement
694: D290 White spaces around docstring should be trimmed.
694: D202 No blank lines allowed *after* method docstring, found 1
694: D400 First line should end with '.', not 's'
694: D205 Blank line missing between one-line summary and description
706:9: B901 blind except: statement
709: D290 White spaces around docstring should be trimmed.
709: D400 First line should end with '.', not 'd'
709: D205 Blank line missing between one-line summary and description
719:9: B901 blind except: statement
722: D290 White spaces around docstring should be trimmed.
722: D400 First line should end with '.', not 'd'
722: D205 Blank line missing between one-line summary and description
732:9: B901 blind except: statement
735: D290 White spaces around docstring should be trimmed.
735: D400 First line should end with '.', not 'n'
735: D205 Blank line missing between one-line summary and description
750:16: E713 test for membership should be 'not in'
774: D290 White spaces around docstring should be trimmed.
774: D202 No blank lines allowed *after* method docstring, found 1
774: D400 First line should end with '.', not 'n'
774: D200 One-line docstring should not occupy 2 lines
782:66: E502 the backslash is redundant between brackets
782: D290 White spaces around docstring should be trimmed.
782: D202 No blank lines allowed *after* method docstring, found 1
782: D400 First line should end with '.', not 'n'
782: D205 Blank line missing between one-line summary and description
832: D290 White spaces around docstring should be trimmed.
832: D202 No blank lines allowed *after* method docstring, found 1
832: D400 First line should end with '.', not 's'
832: D205 Blank line missing between one-line summary and description
870: D290 White spaces around docstring should be trimmed.
870: D202 No blank lines allowed *after* method docstring, found 1
870: D400 First line should end with '.', not 'n'
870: D205 Blank line missing between one-line summary and description
896: D290 White spaces around docstring should be trimmed.
896: D202 No blank lines allowed *after* method docstring, found 1
896: D400 First line should end with '.', not 'n'
896: D205 Blank line missing between one-line summary and description
919: D290 White spaces around docstring should be trimmed.
919: D202 No blank lines allowed *after* method docstring, found 1
919: D400 First line should end with '.', not 'n'
919: D205 Blank line missing between one-line summary and description
945: D290 White spaces around docstring should be trimmed.
945: D202 No blank lines allowed *after* method docstring, found 1
945: D400 First line should end with '.', not 't'
945: D205 Blank line missing between one-line summary and description
966: D290 White spaces around docstring should be trimmed.
966: D209 Put multi-line docstring closing quotes on separate line
966: D202 No blank lines allowed *after* method docstring, found 1
966: D400 First line should end with '.', not 'n'
966: D205 Blank line missing between one-line summary and description
973:9: B901 blind except: statement
977: D203 Expected 1 blank line *before* class docstring, found 0
977: D400 First line should end with '.', not 't'
977: D205 Blank line missing between one-line summary and description
1004: D101 Docstring missing
1005: D102 Docstring missing
1018: D103 Docstring missing
1026: D401 First line should be imperative: 'Make', not 'Makes'
1026: D400 First line should end with '.', not 'r'


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing
23:1: I101 Imported names are in the wrong order. Should be InvenioWebTestCase, make_test_suite, run_test_suite
24:31: E126 continuation line over-indented for hanging indent
28: D203 Expected 1 blank line *before* class docstring, found 0
31: D202 No blank lines allowed *after* method docstring, found 1
31: D400 First line should end with '.', not 'e'


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I101 Imported names are in the wrong order. Should be InvenioWebTestCase, make_test_suite, run_test_suite
28: D203 Expected 1 blank line *before* class docstring, found 0
31: D202 No blank lines allowed *after* method docstring, found 1
31: D400 First line should end with '.', not 'e'


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
22: L101 copyright is missing
26:1: I101 Imported names are in the wrong order. Should be CFG_WEBSEARCH_EXTERNAL_COLLECTION_SEARCH_MAXRESULTS, CFG_WEBSEARCH_EXTERNAL_COLLECTION_SEARCH_TIMEOUT
26:1: E402 module level import not at top of file
27:6: E126 continuation line over-indented for hanging indent
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
72:122: E502 the backslash is redundant between brackets
73:125: E502 the backslash is redundant between brackets
74:125: E502 the backslash is redundant between brackets
133:93: E231 missing whitespace after ':'


Maybe check if creature_template 42601 (overloaded harvest golem) has those 2 spells into it's template?
I don't have the DB/Core set up on my PC so I don't know the table structure. I guess "default" would be

```sql
UPDATE `creature_template` SET `spell1`=79425, `spell2`=79430 WHERE `entry`=42601;


The only ansible thing we're still using is the elasticsearch provisioning, so everything should still work without this


develop (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1147 of 1147 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Oui c'est vrai. Tu penses que ça vaudrait le coup d'afficher ce genre d'information à l'utilisateur ? Je trouve que lui donner le montant demandé et le montant accordé est suffisant pour qu'il voit tout seul. En même temps c'est vrai que ça permettra d'avoir l'info en un coup d'oeil. Ca se justifiera davantage avec les condiotionnal subsides. On garde ça pour plus tard ?


Source currency is always the same inside the for, so it doesn't make sense obtain it in each iteration.


Javaslat:
A Card osztályba bekerülhetnének olyan metódusok, hogy:
boolean isEqualRank(Card other): ami true-t ad vissza, ha this.rank.equals(other.rank) egyébként meg false
boolean isEqualColor(Card other): hasonlóan az előzőhöz.
boolean isBigCard(): true ha nagy lap egyébként meg false.

Ezek segítségével szebb és olvashatóbb kódot kapnátok.


This commit isn't included when installing from npm, maybe bump the version number?


The compilation error can be nicely resolved by adding an annotation "__ref" in front of "perf_remove_from_context"  which resides inside ./kernel/events/core.c file.


you already have 'in the future' in the previous sentence. What about 'we cannot guarantee that these specific binary builds will remain usable as the required dependencies change over time.'


OK


Mettre a jour certain champ vec les nouveau modele


Oui, c'est poru ca que j'ai mergé, mais ce prendra du sens avec les conditonnal subsidies.


This change breaks eprints when opening, e.g. http://local/id/eprint/150
Error :Can't call method "base_id" on an undefined value at /opt/eprints3/perl_lib/EPrints/Apache/CRUD.pm line 897.\n,


Nice restructure, not creating the bools until you need them.

I'm noticing that the bools are only needed for their check and then never used again.  For extra credit you could consider wrapping each pair of bools plus check in braces.  Vaguely like this:
```
{
    bool const setFlag = ...;
    bool const clrFlag = ...;
    if (setFlag && clrFlag) { journal << ...; return temBAD_NEWS; }
}
```
It reduces the scope of the variables to just where you need them.  Just a thought.  What you have is good too.


Autant que possible on ne laisse pas trainer de debug code dans ce qui se rends au master. Si c'est du code qu'on veux reutiliser, on le met dans une classe test dans le package testing.


Awesome!


Maybe I'm just being dense here, but why are we connecting to the db twice?


bet-nek fix értéket nem jó megadni.
Vagy tartjuk, ahhoz a call értéke kell, vagy emelünk ahhoz a call+minimumRise értéke kell, s egyébként meg bedobást jelent a bet értéke.


Unhandled Fundamental Failure


Need cs_LastBlockFile lock? or is cs_main sufficient?


Nem kell a 100-al való szorzás.
Math.random()  < 0.7 ugyanaz jelenti


T'es queries sont ouvertes à l'injection sql. Va voir sur le liens suivant comment y remedier.
http://docs.oracle.com/javase/7/docs/api/java/sql/PreparedStatement.html


this is my pass


Can we please not intermix whitespace changes with everything else?


Ez így nem helyes. Függőségnek (bár tesztbe), de a csomagot tetted be, amiben vagyunk. Azaz önmagának követelménye ez a projekt? Fura.


Nice!!


Not sure if it will work


He-he :laughing:


I can't believe I was exposing a global. Ugh, I'm so embarrassed.


...and more whitespace only changes...


com.wcs.poker.gamestate.Player-hez nem kell a package információ, jó az Player-ként


Why the upper case, unlike all the other ones?


83782874_LBNL_ThermostatOffsetFault (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yeah!!!! that looks like it worked.  @shawnbot for the win!


This is public interface in a public assembly; *can* it be changed as you're doing?


Que bueno Josue, las imagenes las tendrias que editar antes del mismo
tamaño para que salgan bien


Please revert all whitespace changes.


File name and (header guard) are wrong. Please rename to match `caf_weak`.


isn't it possible (though very unlikely) due to out-of-order blocks for the nHeightLast to be lower in a subsequent file?


no need If !NULL, free can work with null ptr.


Thanks. I think it is fixed.

On Mar 17, 2015, at 11:44 AM, niphlod <notifications@github.com> wrote:

> lots of files changed.... sure it's all fine ?
>
> some languages that were present have been dropped
> web2py.js has changed a lot (and in my POV it doesn't require to be changed to accomodate bs3)
> auth versioning enabled by default
> —
> Reply to this email directly or view it on GitHub.
>


Unhandled Fundamental Failure


Fixed!


I benchmarked this version against the previous (both are input independent)
Previous version: (a3efcff04ff929ba0d1c38a4b66a71aef1546e6c) 53.6 ms
This version: 34.7 ms


This update seems to cause IE8 to crash across all my VM's. Rolling back to previous version of cukoomon seems to fix the problem.


При установке были еще проблемы?


"cache".  We want to keep cash, not clean it up ;)


Coding style: Add an empty line after line 28 (and before 38). Looks good otherwise. :)


This is hardly just a format change!


@tchoulihan never mind, it is all good. If a model is updated, we need to blow away its cache, because it is stale after update. I forgot. However, commented code needs to go.


ooo ya profe Bueno entonces eso haré y ya cuando queden bien las imagenes lo subo profe gracias por la ayuda profe es muy atento


develop (jasondegraw) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


If you want to work on the master branch, you must rename your repository to jnorthr.github.io and set the repositoryName attribute to jnorthr.github.io


We probably don't need to explicitly declare all of these internal/private properties if their initial values are all falsy.


Cheers! :D


Line is too long. [101/100]


This looks straight-forward to me, but hopefully Burgess can give it his blessing as well since I haven't written an Extension Point yet. :)


no worries, we'll just leave it for now


This gives a Build error

Revert Needed


Ember Addons provide a "test" application and the Brocfile is customized to build this "test" application.

I think it would be beneficial to keep the "test" structure as common to an ember addon as possible (leverage the test brocfile and test application) and I don't think it would be a good idea to include other "plugins" in the devDependency for the package. In order to support this, I provided a hook to manually load plugins not in the package.json

The risks with this approach are dependency loading (doesn't account for DAG) and if ember-cli internals change around this, our test suite breaks.

I've looked at being able to provide a test hook within ember-cli-deploy to resolve test adapters for leverage in a test scenario. With this approach, a test for verifying the s3 assets upload properly would be...

Test file...
* installs the `ember-deploy-s3` plugin
* executes `LOAD_ADAPTERS =ember-deploy-s3 ember deploy --environment test-s3`
* reaches out to s3 and verifies assets are present


Looks like an inconsistent tabs/spaces formatting here.


At 14.04, I can see the icon in the Unity app switcher (I'm assigning the icon in the MainWindow class). Is this not working in 12.04?


"Fixed" ![img](http://static-cdn.jtvnw.net/jtv_user_pictures/emoticon-2867-src-f02f9d40f66f0840-28x28.png)


No, it’s a fix for the EstimateFalsePositiveRate and the format changes
--
Will

On March 17, 2015 at 1:08:55 PM, Matt Joiner (notifications@github.com) wrote:

This is hardly just a format change!

—
Reply to this email directly or view it on GitHub.


@nwoods


aaaaaaaaaaaaaaaaaaaaaah!!


Commenting probably isn't enough here. We should add statsd integration


it is a good practice to get the body declaration on the top of the file


Ennek nincs helye itt!

Ha meg akarsz győződni arról, hogy a kód azt teszi amit szeretnél, akkor írjál rá tesztet. Ezt itt nehéz teszteli érdemes lesz kiszervezni, s akkor már tudsz rá tesztet írni.


It looks that PythoWin console doesn't have the encoding attribute in its sys.stdout object. There is a similar report:
http://sourceforge.net/p/pywin32/mailman/message/28927618/
I'll try to figure out a better solution


Thanks for the report, it should be fixed now via https://github.com/brad-accuvant/cuckoomon-modified/commit/fb212e4053ed0d5029d94c827b0a3b1a1a3c161f


TeamCity xBIM :: XbimExchange :: Build [Build 119](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1163&buildTypeId=XBIM_XbimExchange_Build) is now running


move the helpers block into a `application_helpers.rb` file


I'm not an attorney, but I thought for copyright notices, you were supposed to use the year of first publication. I've seen ranges used to indicate continued work done. My suggestion would be to change this to say:

```Copyright 2014–2015, University of Florida```

What does everyone else think?


yep, I only use this helper method for [escaping body content](https://github.com/Mashape/httpsnippet/commit/5285cccb91a9a479b12cc8d0bddad6d30840ceac#diff-a4e420d2d3db848f8a12053288c8b241R34) since they end up on multiple lines due to processing through shell-quote method directly before.


Not really, `xprop | grep _NET_WM_ICON` on scudcloud window prints nothing.


Ha kiszerveznéd, akkor nem volna szükség a !flush vizsgálatra.
Illetve s > 4 helyett nem jó az s == 5 vizsgálat? :)


Isn't this redundant since "--" starts with '-'?


R+ assuming tests pass.


Please check this: https://boagworld.com/dev/ios-safari-resizing-issues/


same func as in _brk? can it be placed as utils in base/ to share/reuse code?


TeamCity xBIM :: XbimExchange :: Build [Build 119](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1163&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:02:03


omgizz, that's  why it's not fixed

On Tue, Mar 17, 2015 at 10:59 PM, Chiang, Yi-Yo <notifications@github.com>
wrote:

> Why are you adding this?
> There's already ".page(params[:page]).per(100)" at line 24.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/joshua5201/tioj/commit/8b8c3b92123a1ede189e39148f5e5a1c3bc9a47c#commitcomment-10238490>
> .
>


return type: unsigned int


@masom You'll have to run it with sudo, otherwise you won't be able to copy ffmpeg bin to /usr/local/bin


Hi,
that shouldn't be too big of a deal. Rather than using
`QT5_USE_MODULES(rtabmap Widgets Core Gui Svg PrintSupport)`
We could extend `${LIBRARIES}` by
`Qt5::Widgets Qt5::Core Qt5::Gui Qt5::Svg Qt5::PrintSupport`

Also, the `find_package` needs to be changed:
Rather than
`FIND_PACKAGE(Qt5 COMPONENTS Widgets Core Gui Svg)`
We would need to use
`find_package(Qt5Widgets)`
`find_package(Qt5Core)`
`...`

Which then leads to a more complicated
`Qt5Widgets_FOUND AND ...` instead of `Qt5_FOUND`

Not a big deal I think. More info can be found here: http://doc.qt.io/qt-5/cmake-manual.html#using-qt-5-with-cmake-older-than-2-8-9


Also, if the `$1` is not "--" but is instead an actual option, won't this result in that option getting dropped by the `shift` below?


Absolutely. I addressed this in https://github.com/MaximilianMeister/nailed/issues/10


@hhugo What is this line for ?


indentation of "to/" is still slightly odd here (sorry to be so pedantic! cf Wadler's Law)


I don't think these files are meant to be called from the command-line. Therefore, remove the ```#!/usr/bin/env python``` lines


Sorry for misunderstanding the Issue. So basically what you want is to redirect the users who account are deactivated to a landing page letting them know that their account is disabled? If so I think we already show a message on the login screen when the deactivated users try to login. You can see that [here](https://github.com/virtualcommons/vcweb/blob/develop/vcweb/core/forms.py#L109). Let me know if I'm still misunderstanding the issue.


Why did this file disappear? I don't see any removal of a `MyClass` type anywhere else in this patch, so presumably it still exists...

If it *doesn't* exist, and this removal is "just cleanup", then it should be part of a separate commit.


@sralmai you should update the documentation for this feature. Also, since it's been pretty darn long I would also just fork this and submit it to supermarket-- looks like abandonware here.


As discussed, could you check what it shows on the status page and make sure it doesn't become insane/overly verbose?


@bedney Yes, this would be the intention and thank you for pointing out the problems in the code comments.


@elandau gotcha!


Hmm, it works indeed for **Unity** app switcher, but I'm using compiz one and it seems to use the icon from `_NET_WM_ICON` xproperty.


is there any way to enable this feature in php.ini ?


Source/Project64/User Interface/Rom Browser Class.cpp

Since these last 8 lines are the only relevant part to this entire commit, I was thinking it could look more organized for people reading to have the braces indentation changes from K&R to Allman as part of some separate commits.  So I guess if it helps prevent that I should do a pull request to convert rest of the source to Allman (well at least as far as function scope goes, static initializers, listings and things like that I'd leave as K&R).


```python
r'(?:https?|ftp)://[\.\-\+\?\(\)\{\}\^\$\w\d/:;@&=,%#]+'
```

ちなみに正規表現が苦手なら https://regex101.com/#python このサイト最強だからブクマしとき。


:-1:

This totally bypassed discussion on this to see if some of these multi-column indexes are duplicating indexes between columns.

We now have:

```
  add_index "spree_promotion_rules_users", ["promotion_rule_id"], name: "index_promotion_rules_users_on_promotion_rule_id"
  add_index "spree_promotion_rules_users", ["user_id", "promotion_rule_id"], name: "index_promotion_rules_users_on_user_id_and_promotion_rule_id"
  add_index "spree_promotion_rules_users", ["user_id"], name: "index_promotion_rules_users_on_user_id"
```

```
  add_index "spree_products_promotion_rules", ["product_id"], name: "index_products_promotion_rules_on_product_id"
  add_index "spree_products_promotion_rules", ["promotion_rule_id", "product_id"], name: "index_products_promotion_rules_on_promotion_rule_and_product"
  add_index "spree_products_promotion_rules", ["promotion_rule_id"], name: "index_products_promotion_rules_on_promotion_rule_id"
```

```
  add_index "spree_orders_promotions", ["order_id", "promotion_id"], name: "index_spree_orders_promotions_on_order_id_and_promotion_id"
  add_index "spree_orders_promotions", ["promotion_id", "order_id"], name: "index_spree_orders_promotions_on_promotion_id_and_order_id"
```

```
  add_index "spree_properties_prototypes", ["prototype_id", "property_id"], name: "index_properties_prototypes_on_prototype_and_property"
  add_index "spree_properties_prototypes", ["prototype_id"], name: "index_spree_properties_prototypes_on_prototype_id"
```

```
  add_index "spree_taxons_prototypes", ["prototype_id", "taxon_id"], name: "index_spree_taxons_prototypes_on_prototype_id_and_taxon_id"
  add_index "spree_taxons_prototypes", ["prototype_id"], name: "index_spree_taxons_prototypes_on_prototype_id"
  add_index "spree_taxons_prototypes", ["taxon_id"], name: "index_spree_taxons_prototypes_on_taxon_id"
```
```
  add_index "spree_option_types_prototypes", ["prototype_id", "option_type_id"], name: "index_option_types_prototypes_on_prototype_and_option_type"
  add_index "spree_option_types_prototypes", ["prototype_id"], name: "index_spree_option_types_prototypes_on_prototype_id"
```

```
  add_index "spree_option_types_prototypes", ["prototype_id", "option_type_id"], name: "index_option_types_prototypes_on_prototype_and_option_type"
  add_index "spree_option_types_prototypes", ["prototype_id"], name: "index_spree_option_types_prototypes_on_prototype_id"
```

```

  add_index "spree_option_values_variants", ["option_value_id", "variant_id"], name: "index_option_values_variants_on_option_value_and_variant"
  add_index "spree_option_values_variants", ["variant_id", "option_value_id"], name: "index_option_values_variants_on_variant_id_and_option_value_id"
  add_index "spree_option_values_variants", ["variant_id"], name: "index_spree_option_values_variants_on_variant_id"
```

In both MySQL and PostgreSQL the query planner is able to use the left most index from a multi-column index. This means we have too many indexes which affects storage space used and insert performance in to these tables.

If multi-column indexes are correct, we should remove the old index on only the single column as part of this migration.


Értem a szándékot, itt emelni szeretnél, de mi van ha a minimumRise értéke nagyobb mint a bigBlind * 3, akkor a server úgy fogja értékelni, hogy csak call-od volt (látom a 41-es sorban bet = gameState.getCall()).

A stratégiát nem ismerem amit meg akarsz valósítani (issue-ba jó lett volna leírni), de gyanús, hogy cal + minimum rise + bigblind * 3 lett volna amit szerettél volna.


Based on the naming of "dropns-classic", presumably this should be `MyNamespace.MyClass`, and thus there should be a `MyFramework/MyClass.xml` file. Did you forget to `git add` it?


As you've disconnected from IRC:

It looks like your Document class hasn’t been initialized. Try
`Document initialize. Main startUp.`


...and considering that we have a `MyClass` type here, there should be a `MyClass.xml` file *somewhere*...


form line 351 to line 358, those line of code can be moved in a function of the participant_manager, same from line 360 to 372 for labels.

The function could be named ```keep_reset_tags(tags, action)``` and ```keep_reset_labels(labels, actions)```


I think you should also track restart.


in the commit message, didn't you mean "add debug compilation flags to coverage mode" ?


```markdown
`users`:
```


force a disk flush here to commit the index before removing the file?


Also, there's five sections here.


ilyenünk ne legyen. :)


no need If(ptr) free(ptr)

just free(ptr) will do it


Nope, check the develop branch.


Is this change expected and/or desirable?


squash the latex generator removal in this commit


Actually, you don't. That's the very hacky part of it. the String container in typelib initializes its element type using the platform's signed-ness instead of using its provided argument.

This is why there is a problem on ARM. While the TLB file says "int8_t", the String container accesses "uint8_t" which is not defined.


We have here an issue with the logic, because with the optinAction() the participant is 'scheduled'. The schedule process is very dependant on if the participant has tags or labels. However u are adding the tags and labels after the optin action has run.


Master branch breaks, I will bump the version while it get fixed.


And we are positive that this was the cause? Because it doesnt make sense, unless we are hitting a runtime and/or jit bug. Another that I am thinking is what happens if the thread gets preempted while doing the lookup. Then a modify could hit while a search is happening. Nasty issue in there if that is possible (which won't be solved either way by that change, maybe we are just masking it).


Ismét fix érték. Majd elmondhatjátok ezek honnan jöttek.


break;


Is there a reason to do this instead of `data instanceof Blob`?


A lot of python source files are missing copyright headers


For unconditional branches, offset is 11 bits so line 369+ should probably be
```
if ((delta < -2048) || (delta > 2046) || (delta & 1)) {
  //out of range or non-even offset
}
ut16 opcode = 0xe000 | (delta & 0x7FF);


I think this PR is fairly straight forward, looks good to me.


AAah gotcha. I was reading some docs about sudo not being available in Travis and then I realized it only applied to the containers.


Could you please remember to fix this sooner than later Thomas? :)

On the same topic I've also noticed FilterTest this week which has:

        // Give some time to finish the conversion
        // TODO: use a cleaner way to find if the conversion is done
        Thread.sleep(30000);

In addition that other test doesn't use PageObject and directly manipulates ids, for example:

        // Set input
        WebElement inputType = getDriver().findElement(By.id("filter_input_type"));
        // TODO: make sure the right type is selected
        WebElement inputElement = getDriver().findElement(By.id("filter_input_properties_descriptor_source"));
        inputElement.sendKeys("url:" + url.toString());

        // Set output
        WebElement outputType = getDriver().findElement(By.id("filter_output_type"));
        // TODO: make sure the right type is selected
        File tmp = File.createTempFile("result", ".xml");
        WebElement outputElement = getDriver().findElement(By.id("filter_output_properties_descriptor_target"));
        outputElement.sendKeys("file:" + tmp.getAbsolutePath());

The problem is we all know how temporary stuff have a bad tendency to remain there forever... :)

Globally these 2 tests add 40s more at each commit. That's a lot just for 2 tests.

Thanks!


Right, so better to really have it in both places.

I saw you used a better code for filesystem path files: `QtGui.QIcon(os.path.join(INSTALL_DIR, 'resources', 'scudcloud.png')))`.

Can you apply the same in other `lib` classes?

And a dummy question: why should I repeat the `INSTALL_DIR` in all files? I've tried to have it only in the `scudcloud` file, but this appears to not works.


Merged in 242c8b9f7cd480c645c60341787e5e2fec1d3a6c (because it doesn't hurt)


TypeParameter changes should be part of a separate commit; I don't see what this has to do with the rest of the commit.


It should extend AddOnModule...i think


ez egy olyan metódus aminek nagyon jó helye volna a GameState-ban. S lehetne az a neve: isCurrentPlayerBlind()


LGTM apart from the verbal comments on the hangout about lines 751-755.


This file doesn't seem to be used. Please remove it and update the commit message


Please review


test


You don't need to zero `mHash` here. You can detect that the hash needs to be computed by checking `mSeq`. If `mSeq` isn't zero, then the node is dirty. I don't think you need to zero `mHashes[m]` either -- I don't see any case where you check for that anyway.


I'm thinking about moving all those scripts to `/usr/local/sbin`, what do you think ?


The review will be tricky because this is my commit message but not my patch


Yes that is possible, but the worst case result of that is that you just end up keeping that file around a little longer than you need to.  It seemed like it was easier to reason about the block data files if they were consecutive, but maybe it doesn't matter.


Also, we will probably change the `oc-` prefix soon, so we can do both changes at the same time


This doesn't set `mHashes[pos]` to zero if there's no child. You do that in `setChild`, but IMO it makes more sense to do that here.


Comment was fixed in the following commit.


@scopatz
Are the docstrings here and below needed? From what I can tell, they aren't needed.


We'll need `$.parseJSON(xhr.responseText)`.


Looks good to me.  Thanks.


The malloc overhead is larger than a tiny fraction of the misalignment, so it's kinda hard to predict.

A totally different approach is to use anonymous mmap() which will always give you a page boundary.


adduser is required in the postinst of the Debian package: https://github.com/odoo/odoo/blob/8.0/debian/postinst


this will result in a duplicate id (the add-on id is exactly the id of the implementations of AddOn.class)


Only that I didn't really understand the semantics of ``instanceof``.  Using it would actually simplify the code, since ``f instanceof Blob`` is ``true`` when ``f`` is a ``File``.


Mhh. problem is that the original commit 7d128a0fe59e54658465831104d3b4db1bd96947 uses ggarg@redhat.com

is there a way to alter this ?


Thanks for pointing me to ```flat $value```. That does indeed look cleaner and also passes all tests. Would you mind to revert this commit and instead ```s/$value.flat/flat $value/```?


The file mode change on test/functionnal-tests/ACTCampaignEngine.py shouldn't be done in this commit.
The TestSubsystem.xml file is modified here but the other files are added; why ? I suppose TestSubsystem.xml should be added here too.


u should have other function here like
```
def get_keep_tags(self, participant_tags)
    ... here all the logic of comparing the participant tags list and returning a join between the 2
```

```
def get_keep_labels(self, participant_labels):
    ... all the logic between to get the join between the participant labels and the keep-labels
```


what happens if it's not found?


and where is this used in 1.3.15??


Looks great. Thanks @adrianbanks.


develop (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1150 of 1150 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's actually needed by Odoo website themes because they rely on some js library.


`s/readed/read/`


commit message: `s/reeded/read/`


kjhjkhkj


This was a hack to prevent the last metadata in the list from not being matched (as the regex does a lookahead for the next ` @:`). Guess this should've been documented.


Adding an inline comment so you can see how they work.

Also, be careful with white space.  Use it to imbue meaning and clarity into the file. Some people like code with allot of space and breathing room. Others like code that is condensed and terse.


Sorry, one more comment update ;-). Line 15 should maybe read:

A block will not be considered a warning if it contains a comment line with only the word `empty`.


{database} should read {dataset} ;-)


> should each use of property want a different default value

I'm curious, what is the use-case where this is desirable? If the property is set via a config file or dynamic source both locations would get the same value for the property. Having different defaults for the same property in various places in the code seems like it would typically be a bug and would make the system hard to reason about.


New naming looks good! When in doubt, I just reference the official spec doc and see what they use for naming and use that for inspiration. :)


ahh  ... i though we had fixed this, I think I just updated this in my local buster-functional ... my bad totally forgot to send a PR for the fix.


build is now in progress


This test is failing on line 95 - Error: Could not find class xinetd


Module Executive Summary:
This module includes the functions required for pre-processing data for 1-time correlation analysis of data collected on the CHX beam line, and other beam lines or facilities conducting x-ray photon correlation spectroscopy (XPCS) experiments. The functions included in this module provide the following data analysis capabilities:
- generate a circular mask for analysis of XPCS data.
- subdivide the circular mask into distinct wedges, or regions of interest (ROI)
- index all pixels contained within the wedge mask when the mask is applied to images collected through XPCS


Hmm ... that's a good question. The only consumer of this particular API that I'm aware of is monodoc.dll itself and mdoc. I created it when the original mdoc changes to support classic/unified documentation were implemented, and I needed a way to control/change some things from mdoc via dependency injection; it's really only changing because those requirements further evolved to include documenting multiple framework owners/platforms in the same doc set.

How would you recommend moving forward here?


`eblob_add_new_base()` doen't call `eblob_generate_sorted_index()`.


you can use `"'%s'" % value` instead of `escapedValue`.


Was this in the wrong file all along?


Looks good!


Optional (since it was already like this in previous code): no need to call `hide()` if the dialog is going to be destroyed immediately afterwards


When do you want to go over this so I know how it works? I understand what your telling me what it's important I know how to implement it.
Thanks again,

> On Mar 17, 2015, at 10:27, Greg Larrenaga <notifications@github.com> wrote:
>
> Adding an inline comment so you can see how they work.
>
> Also, be careful with white space. Use it to imbue meaning and clarity into the file. Some people like code with allot of space and breathing room. Others like code that is condensed and terse.
>
> —
> Reply to this email directly or view it on GitHub.
>


Hey, I'm working on a project where we are already depending on guzzle 5.0+ but need to use this segment.io library with guzzle 4.0 . Have you run into any issues using this?


Change le nom de méthode, tu dis que c'est get par nom, mais tu select les ids de toutes les commandes


It's already part of the base image you're using, though:

```console
$ docker run --rm debian:jessie dpkg -l adduser
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
ii  adduser        3.113+nmu3   all          add and remove users and groups
```


Is it necessary to put these in temporary variables?  Seems like naming them a and b obscures rather than reveals.


`assert` is a no-op in release builds.  Use `abort`, or better yet proper error handling.


thanks!


The `if / else if / else` to determine `maxSourceAmount` shows up both here and in `doApply`.  Would you consider making a `maxSourceAmount_` member variable that is computed and set here in `preCheck`?  You could then re-use the value in `doApply`, rather than re-computing it.


Si tu ne select que l'id, tu n'as pas accès au autres informations


Thanks :)
It worked.


`eblob_generate_sorted_index()` can be called from `eblob_base_ctl_open()` only if base is not empty and exceeds thresholds.


Do you still need `npm` at runtime then?


I added it to the wrong file.


This fails because it tries to fetch all examples, where `main` is redefined multiple times. Instead, list each top-level lib independently:

```
github.com/mozilla/masche/listlibs
github.com/mozilla/masche/memsearch
```


squash this with the initial import too.


Don't think you need to divide `GLib.MAXINT32` here, since it signifies "no timeout"


This is a comment on github, Did you reply via email?

If you use the Github interface, You will see that these comments are attached to a specific line and commit.


This we agreed should be removed anyway, so I'm ok with it but @dchen1107 should verify


ligne 46 incomplete, donc la methode ne fonctionne pas


Pas de ça dans les pull requests


the ratio of improvement will be 11.66%, if my comsumption is correct
(i am not sure about my comsumption!
(the explan is on the bottom of my ''lab38 note''


People might use this to do code review and bring your attention to a specific line.


But it doesn't exist in the original file either https://github.com/rubinius/rubinius-core-api/blob/master/lib/rubinius/kernel/common/thread.rb - where did you get the line from in the first place? If you wrote it yourself it should be in https://github.com/jruby/jruby/blob/master/truffle/src/main/ruby/core/thread.rb.


Add more exceptions and extend the framework to handle the exceptions at rest server level.


This was actually a quick test run to see if I could get things running... unfortunately the unit tests failed and due to having to get things off the ground quickly, I moved back to Segment's library. The uecode guys are aware of the issue though: https://github.com/uecode/segment-io-php/issues/3


Is the extra space before the question mark a European thing? (I've noticed you adding a space before a colon as well.) In American English there's no space before the question mark here.


It works, thanks guys! Couldn't be happier. Now if only we could see something for the WiFi/Bluetooth coexistence (A2DP) while WiFi scanning. (Audio cuts out during WiFi scan) I'll keep lurking ;)

I wish I knew more to be able to help out. The limits of what I've been able to do is scour kernel modules, their settings, and config files from my stock G900A looking for clues to fix things on my G900T on CM-12 20150317. So far, I haven't been very useful.


This (or the whole landing of MS' serialization code?) seems to break Mono's NUnit.
Before this patch, there was a huge amount of failing Remoting tests (mcs/System.Runtime.Remoting).

After this patch, NUnit fails with

``<Unhandled Exception:
System.MissingMethodException: Attempted to access a missing method.
  at (wrapper managed-to-native) System.RuntimeFieldHandle:SetValueInternal (System.Reflection.FieldInfo,object,object)
  at System.RuntimeFieldHandle.SetValue (System.Reflection.RtFieldInfo field, System.Object obj, System.Object value, System.RuntimeType fieldType, FieldAttributes fieldAttr, System.RuntimeType declaringType, System.Boolean& domainInitialized) [0x00000] in /raid/local/src/mono/mcs/class/corlib/System/RuntimeFieldHandle.cs:116>``

Did you run the remoting tests after the landing? Remoting & serialization are pretty interweaved.


Ditto re: space before question mark


there are a lot of ".old/blablabla" files. please remove them.


I have added ServerMessages file, add all your error messages there.

Create own new exception classes if required.


me pedistes que cambie todo default_tabs.js a default_list_group.js


Érdemes volna a stratégiával kapcsolatos részt majd külön osztályba szervezni.


i think the API is still a bit bloated. there are at least 4 ways to obtain properties...
context.getProperties(key) (even the javadocs think its a bad idea....and why is it plural?)
context.getProperties().getProperty(key)
context.getPropertiesAssistant().getProperty(key)
context.getPropertiesAssistant().getProperties().getProperty(key)

i would delete the options in the context. And i think one can reduce the complexity of the whole Properties-Class


Log file name is mylog.log.

Change it to some valid name.


Well, my ARM system tells me a different thing ;) --  might have to do with order of registration i.e. looks like the container type is handled before the uint8_t type is made known
```xml
root@LAP-01-U:/opt/software/base/orogen/std# cat /proc/cpuinfo
Processor	: ARMv7 Processor rev 3 (v7l)
BogoMIPS	: 497.82
Features	: swp half thumb fastmult vfp edsp thumbee neon vfpv3 tls
CPU implementer	: 0x41
CPU architecture: 7
CPU variant	: 0x1
CPU part	: 0xc08
CPU revision	: 3

Hardware	: Gumstix Overo
Revision	: 0020
```
```xml
/usr/bin/ruby1.9.1 /opt/software/tools/orogen/bin/orogen --corba --extensions=metadata_support --no-rtt-scripting --parallel-build=1 --transports=corba,mqueue,typelib --type-export-policy=used std.orogen
OroGen[INFO]: loading plugin /opt/software/install/share/orogen/plugins/orogen_metadata.rb
FILE: /opt/software/tools/orogen/lib/orogen/orocos.tlb
/opt/software/tools/orogen/lib/orogen/gen/imports.rb:42:in `merge_xml': cannot load xml: cannot find string element /uint8_t in registry (ArgumentError)
	from /opt/software/tools/orogen/lib/orogen/gen/imports.rb:42:in `from_raw_data'
	from /opt/software/tools/orogen/lib/orogen/gen/project.rb:290:in `using_rtt_typekit'
	from /opt/software/tools/orogen/lib/orogen/gen/project.rb:280:in `initialize'


I think this will fail once #63 is merged because then, the tests will use a python module and its directory will need to be in the PYTHONPATH.


So, `Select()` is used to select definitions: i) packages/objects, ii) fields, iii) methods. Apply is used just for function application.

So here the trees exactly represent what is written. Now each of these applications has a symbol attached to it, and the symbol will uniquely identify what definition is applied.

`__ifThenElse` should be captured by the library, and should be handled by the logic that is already there. If that is not the case the logic is broken :)

I think we should try to do all with quasi-quotes. They already did the dirty work and if we can reuse it great!
If not both cases above should be subsumed by:
```
case Apply(lhs, rhs) =>
   val annotatedSym = lhs.symbol
```


just a comment


Ok I'll check it out.

> On Mar 17, 2015, at 10:35, Greg Larrenaga <notifications@github.com> wrote:
>
> People might use this to do code review and bring your attention to a specific line.
>
> —
> Reply to this email directly or view it on GitHub.
>


Done.

BTW, can you comment in hawkular/hawkular-metrics repo instead of this one? It's easier for me to get the notifications. Thanks.


Leaving regex as it is and changing url as per Google Code url.


Oops, IIRC, we talked about that but I forgot about it.


@tisto Go for it.

I recall using "Background" keywords. It came to me from reading books about RSpec and Cucumber, and experimenting with CoreJet testrunner. With CoreJet the idea was to write BDD stories in a story / ticket tracker, create tests from those stories and make "burn chart" from fixed tests. In those "business" stories there was no room for repetative detailed technical test setup and it was hidden in "Background". But for Plone, we use BDD in a more pragmatic way (to structure the test better and make them more readable for developers), so I can understand that "Backgound" hurts more than helps.


rax retry tests


done


Okay you don't like verbose comments, but ack :)


Érdemes volna a Card osztályt felturbózni néhány hasznos metódussal.
Pl: boolean isRankEqual(Card other): ami true-t ad vissza ha az adott kártya rank-ja egyenlő az other kártya rank-jával. Így rövídebb kódot írhatunk majd háshol.


Is expression supposed to contain a regex? If so, I'd call the variable "regex" for clarity.
Also, is there a way to specify a byte string in the form `0xffffff` ?


This should be `AT_FDCWD`, not `-1`.  However, the libglnx API docs are lying, we do want to support `-1` there too.  I'll submit a patch.


Minor comment. Should the message be "included in libfabric" vs. "include".


I got it from `rubinius` repo https://github.com/rubinius/rubinius/blob/v2.4.1/kernel/common/thread.rb#L123


Could choose to do instead:

    g_autofree gchar *temp_dir = data;  /* Assume ownership */


Itt is felokosíthatnánk a Card osztályt egy isRank(String rank) metódussal


Na vida real, esse button não poderia ser `type="submit"`. Botões do tipo submit sempre executarção a ação atrelada ao `<form>` e não faria sentido um botão cancelar executar essa ação. Nesse caso, usa-se `type="button"`.


ack


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1657 of 1658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Willst du ernsthaft Nutzertracking auf der Github-Page einsetzen?


LGTM.


+1. Works great and it's a visible improvement.


Interesting.  It looks like my earlier suggestion (automating the call to the base `Transactor::preCheck`) was not so good.  This transaction doesn't ever invoke `Transactor::preCheck`.  I presume that's because this Transactor deals with pseudo transactions, so it lives by slightly different rules.


card1.getRank().matches("[2-6]") is egy olyan dolog amit a kártya magáról meg mondhatna, azaz lehetne egy olyan metódusa, hogy:
boolean rankMatches(String regexp)


This is now https://github.com/GNOME/libglnx/pull/4


Great job.


Testing to add ssl to nginx


Right, so isn't `truffle/src/main/ruby/core/rubinius/common/thread.rb` the correct file? It would only belong in `truffle/src/main/ruby/core/rubinius/api/kernel/common/thread.rb` if it came from the Rubinius core project https://github.com/rubinius/rubinius-core-api/blob/master/lib/rubinius/kernel/common/thread.rb. It's critical we get this right as they have different authors and copyright messages.


oh, frankly I think you wont need that, the API is drop-incompatible and a true superset

if anything comes up I'd rather fix it in the hal library rather than educating users about library history and changes

ok to stick to the new API exclusively I think


Thanks @adg. I wasn't aware we could mix the two namespaces.


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Este es otro comentario


meaning..  I think its safe to take out that option and only use the xthread_funct api


Changed to image[RGB] everywhere


Right.  This code was cut-and-pasted from test code when I wrote it.  Removed.


Because in python "global" namespace is really per-module and in order to use INSTALL_DIR from other files you have to import them explicitly. *Explicit is better than implicit* is a part of The Zen of Python.

Having it only in `scudcloud` file will not work unless the `scudcloud` file is on `sys.path` or you're doing some interpreter magic (like adding it to `__builtin__` namespace or trying to look it up via `sys.modules["__main__"]`).  None of this will be necessary once the package is restructured properly.


`order` isn't being used here? Or am I missing something?


replace initial `/a/b/c` with `/x/y/z`, to be clear that the initial path is not used in the final resolution.


for clarity - this isn't for merging in to anything, I'm just checking this stuff out because I've never really done django in the "normal" way


ack


CharacterController script
- Set MaxGate & GateBarRegenFull1GatePerSecond from characterStatus in SetStatus method


lgtm, shipit


develop (jasondegraw) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Didn't I remove "This function is a generator"?


And I thought it was fixed too :) We all have our days :)


Is this supposed to return actual data from the process memory? If so, I'd like to avoid that. MIG should never transport endpoint data back and forth, only indicators that something is searched for, and something is found.


All the code on ` truffle/src/main/ruby/core/rubinius/api/kernel/common/thread.rb` came from `https://github.com/rubinius/rubinius/blob/v2.4.1/kernel/common/thread.rb`.

I realized that after I compared both - that's the reason of these changes.


The MiqApprovals are ActiveRecord relationships


This newline should be removed.


This newline should also be removed.


No need for recovery if you're not panicking :)


Sorry, the invariants were not documented correctly - CyphertextArray must always be 96 bytes long, due to constraints in our janky radio modems. So, if we need to put a bigger header or tag into the cyphertext, we have to do so by making the plaintext smaller - that tradeoff is OK with me.


Ok, I'll take a look and see if I need to change anything.


There should also be a newline at the end of each file.


Double use of 'cloning'.


Sounds good, please let me know I'll make the change.


I think that should fit into only two lines:
```python
    matches = trim_empty_matches(matches,
                                 [compiled_begin_pattern.groups + 1])
```


Looks like the indentation's gone weird here - needs to be fixed before pushing up to Spree otherwise they'll complain.


Might look cleaner as
```go
if err := ioutil.WriteFile(s.file_path, buf, FILE_MODE); err != nil {
	return err
}
```


Maybe a comment after repeated so it is obvious that it's an adjective.


:thumbsup:


develop (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1150 of 1150 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Lets see if we can straighten thing out!


So you're telling me that the test suite would catch this now?


@magnumripper isn't a reset() function better than a check inside the hot path?


@luistinygod This is for debugging the duplicate content issue.


Resolves https://github.com/reactioncommerce/reaction/issues/340


I guess this is a copy and paste error and should really say 2.0.0-beta-3?


I don't know.  If it is, I think that test should be on MiqApproval rather than MiqRequest


@nikhilkh updated, thanks!


This would break any and all existing scripts which use `mdoc update --dropns...`.

I also don't see a need for for renaming this option to `--droppedns`. Keep it as `--dropns`.


are you planning on submitting a pull request for this? I was about to start writing code when i noticed this fork


How about I just embed *etcdgeneric directly till we remove WithPodStatus?

IMO any resource should be able to implement GenericRESTStorage and plug itself under a url in the apiserver, but there are a few stragglers that need direct access to the datastore. Thoughts?


test


It's a French thing I guess. I'll be more careful.


nothing


@jundl77 the properties-api is the last one to implement, can you check if everything compiles before your next push? I have just eliminated some, will push in a second.
And where do you access the registered Events-IDs?


This is just a question for my own education.  `uExpiration` is a 32-bit value of seconds past the epoch?  How linear is time in rippled?  It seems like we could get the current time without going to the ledger.  If that's true, then we could reject any transaction that is past pull date, not just the ones with a zero expiration.  But I may not have a good understanding of how rippled manages time...


fixed


Need? No. I just was just under a mistaken impression about how relaxed our constraints are.  We can certainly keep the prior sizes to avoid shrinking the plaintext payload.


A classe `container` tem um propósito genérico. Não precisa ficar nomeadamente atrelada a elementos. Ou seja, `container-top`, `container-breadcrumb`, `container-form` pode ser apenas `container`


test/


OK, then maybe this needs to be configurable in some way. Or maybe after you disable Bloom filtering it'll be faster ....


Choosing a more specific word than "lobotomizing" will help out non-native English speakers. :)


There is extra space at the begining of sql/updates/world/ 2015_03_17_01_world.sql file name:
" sql/updates/world/ 2015_03_17_01_world.sql" instead of "sql/updates/world/ 2015_03_17_01_world.sql"

Just try to pull :)


usar apenas uma classe chamada `container`


No mais, show!


Yes. Try it, checkout the previous commit and run the tests.


Please don't be offended - but there is a much tidier way of doing the entity spawning...
And no need to extend a new class for BL mobs...
I'm going to mess all this up later on :P


Rails 4.1 올라오면서 생긴 기능 ㅠㅠ
http://guides.rubyonrails.org/4_1_release_notes.html#active-support-notable-changes


I *think* this broke btrfs mounting, at least for me. It still worked at 5f7d374


Aargh.  Yes, that was the original design, it's hard to check things when you only have one implementation of a general design (which implies I should have implemented a second).  Moved to mapIntensityToUint8, and provided with a trivial implementation.


@adrian-the-git Ta! :)


It's ok to embed and return *REST.  In retrospect returning the interface isn't a good idea, just because we want to let that cross connection stuff be possible.  We can always clean up later.

----- Original Message -----
> How about I just embed *etcdgeneric directly till we remove WithPodStatus?
>
> IMO any resource should be able to implement GenericRESTStorage and plug
> itself under a url in the apiserver, but there are a few stragglers that
> need direct access to the datastore. Thoughts?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bprashanth/kubernetes/commit/cc0fa7ec425e8081fdae8d1e8fe3986bd8b26c16#commitcomment-10242841


избегай подобного дрочерства, пожалуйста, в будущем. чем короче дифф, тем лучше. толку от этого изменения никакого.


No, The module accepts regular expression or raw bytes.
It tries to parse the expression to a hex failing which the module assumes that the "expression" is not a hex of raw bytes but rather a regular expression.
Maybe it would be better for clarity that we have 2 separate fields instead?


Sure, if it fully fixes the problem. Actually I'm not even sure the original problem remains in the self-test code, we have reworked it a little.


Yup. Then I guess we need to change that.


This makes for a worse user experience, because the browser tooltips are different than the tooltips we implement ourselves in ... where do we implement that?

Furthermore, the browser implementation appears to only highlight one missing field at a time. It's better for users if we display all errors on the form at once, as we were doing before.


Is this a typo?  Please see https://github.com/openSUSE/obs-service-tar_scm/issues/69


Doesn't regexp.MustCompile automatically panic if it cannot compile the regular expression? I put that in with that intention.


Fits also into three lines:
```python
        matches = trim_empty_matches(matches,
                                     [compiled_begin_pattern.groups + 1,
                                          compiled_begin_pattern.groups + 2])
```
or
```python
        matches = trim_empty_matches(matches,
                                     [compiled_begin_pattern.groups + 1,
                                      compiled_begin_pattern.groups + 2])
```


Aaarggghhhh :( Looks like it indeed.

The other (cleaner) solution would be to move that stuff to base/orogen/std, where we have more information (i.e. can do the string handling in Ruby). This will, however, have effects on the orocos-toolchain guys as orogen will probably stop being usable without base/orogen/std around. This however might be already problem, anyways, because of other changes for clang.

Anyways, can you check #36 ? I hope this would workaround the issue ...


TeamCity Helios :: Helios PR Build [Build 17](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=270&buildTypeId=Helios_HeliosPrBuild&guest=1) is now running


TeamCity Helios :: Helios Unstable Latest [Build 5](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=271&buildTypeId=Helios_HeliosUnstableLatest) is now running


I agree it's not *limited* to default methods, but it's *crucial* there. As for #20297, I think it's about the whole scheme of resolving "ambiguities", not about winnowing per se.


This should be done before calling this.setup();


Ok, I'll fix that.


Agreed, 2 separate fields would be better.


i'd prefer not to change anything in our radio firmware, so lets just stick to 96 for ct. its easy to change pt size.


Since you saw the original problem, it is up to you do some check to assure the situation now.


This function is a generator can be removed


TeamCity Helios :: Helios PR Build [Build 17](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=270&buildTypeId=Helios_HeliosPrBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 107, ignored: 19 Build time: 00:02:03


This check looks new.  Looks reasonable to me.


I just saw your tweet.
It seems you want to use gh-pages. Here are the steps:
- in the settings of your repository, you must set gh-pages as default branch
- in the configuration.json of the gh-pages branch, you must set the username ton jnorthr and the repositoryName to hubpress.io

Then your blog is available at https://jnorthr.github.io/hubpress.io


Then don't use `MustCompile` :) `Compile` will return a regex and an error.


TeamCity Helios :: Helios Unstable Latest [Build 5](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=271&buildTypeId=Helios_HeliosUnstableLatest) outcome was **SUCCESS**
Summary: Tests passed: 107, ignored: 19 Build time: 00:01:54


This check also looks new.  And, again, it looks reasonable to me.


maybe add test.check-format as a dependency on the test task?


Did you leave this in by mistake?


Check your editor. ;-)

It should remove trailing whitespace.


Please avoid whitespace only changes.


r=jgraham


I think you need some commas here - "Therefore, in Calico, networks are simply..."


r=Manishearth


This is a dictionary. We use dictionary and member elsewhere, so why are we reverting to object and property here?


The "funny" thing is your documentation uses `--dropns`, which this same commit attempted to remove!


Why is "Networks" capitalised here?


Unrelated to this commit, but WTF is a "magic type"? Surely a better name could have been found...


Confirmed. Was Travis catching this before? I don't remember.


I translated the missing §D4 rule in the German translation.


saw approval from jgraham, Manishearth
at https://github.com/Ms2ger/servo/commit/4deb2d1d0c523f6d4bf4d84ef11f49f5a2ba9a5d


merging Ms2ger/servo/wpt_20150304 = 4deb2d1d into auto


Ms2ger/servo/wpt_20150304 = 4deb2d1d merged ok, testing candidate = 8adfb110


Awesome! Thank you :)


fffffff


86121534_1304_WarnOnPATUpdate (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Cambio de License


I'm running Rails 3.2.18 and hitting the same inflection problem, could it be changed to
```Rails.version >= "3.3"```
to skip the inflection on my 3.2+ version too?


Same curiosity about checking the expiration time...


Good, but better to `warnOnce` here


r=SimonSapin


I would suggest splitting up each validation into a separate function (`validateRegex`, `validateLabel`, etc...) because when writing the param creator, we'll need to call each validation separately for each parameter. See the `file` module for an illustration of that logic: https://github.com/mozilla/mig/blob/master/src/mig/modules/file/paramscreator.go#L155-L178


## This is a markdown file.


De nada Josue! nos estamos viendo el jueves :)


Certeza que você quer esse arquivo aqui, e não no `/docs`? Todos os arquivos `.md` nesse diretório ficam visíveis ao usuário final, como [aqui](http://gds-alpha.herokuapp.com/conteudo/publico-alvo)…


@weierophinney How we can decide which use between basic and digest? I mean the "api" authentication adapter should be set only to use one, HTTP Basic or Digest, why both?


For some reason, I didn't like this (I worry that someone will just see the "this is supported in Calico" and not read the rest).  How about "Network creation events on the API are treated as no-op events by Calico; a positive (201) response will be sent, but not programming will actually occur."


Assuming the regex already went through validation, you can call MustCompile here


Merging


Thanks for this fork. Mind sending a pull request after you're done? I'd like to merge this into the main repository with a few cosmetic tweaks. I'll add you into CONTRIBUTORS.txt if you want to. :)


It was reverted and a better fix was pushed and provided, thanks anyway :)


? Accidental?


OK for moving them to /usr/local/sbin, OK to perform the change at the same time.


You remap ggarg@redhat.com to garg.gaurav52@gmail.com in .mailmap since all the work done on Ceph was not in the context of Red Hat. It probably was a mistake. If the situation changes in the future we'll figure out something ;-)


Hey @wesleycho how's this look?
Thanks


Agreed, but then the tests fail...


When it comes to our own generated configuration, we'll only do one at a time. However, the `Zend\Authentication\Adapter\Http` instance allows intercepting both (you can attach both basic and digest resolvers to the instance). As such, I added it just for completeness.


Can we add a success notification as well? It's bad to post a form and get no feedback. The "Your identity is verified" message is good as far as it goes, but for a success message we should use the same notifications system we're using on the rest of the site.


Why the variable rename? `Parse()` will be returning *file paths*; "assemblyName" is ambiguous at best, misleading at worst ("Assembly Name", as in "Fully Qualified Assembly Name"?).


Thanks for the heads up.


W jakim celu jest przypisywany dwa razy ten sam element do dwóch różnych zmiennych? Pod zmienną `formTab` i `form` jest ten sam reprezentujący ten sam element.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/9949/testReport/) for this commit**


As mentioned in the monodoc review, I *really* dislike the name "owner", especially when you appear to intend "framework".


Could this be implemented as all of the attribute readers == UNSET_VALUE? That way you're not tracking separate things.


Oh, sorry, just re-read your msg.


Maybe you can write some description about this class


I think it might be worth emphasising the *must* here!


...then there's the joyful question of providing owner ^H^H^H framework information for assemblies which have `=` in the path name!

On the one hand, I can't think of any common reason this would happen, but on the other...why prevent directory names from containing `=`?


:ok:man


Ok, we should be sure to use only one.


Czemu zrezygnowałaś ze zdarzenia `submit`?


Since we own `OstreeGpgVerifyResult`, it could also own `temp_dir` itself, right?  Something like `_ostree_gpg_verify_result_set_temp_dir()`?

But maybe it's not worth doing, I'm fine with this code as is too.


Hey thanks for running with this @washburnad. Seems like it is going to work really well! Easy to grab the color of the piece causing the obstruction


I can't say I saw that one specifically, but I've been testing around this area and found some logged errors that can be addressed with #1042 - it's at least possible that they also fix the ```Services is undefined``` error you mention.


Is there anything special we need people to set the quotas to?  Didn't we have some issues with this and Nick (quotas for DHCP agents)?


Before:
![screenshot_2015-03-17-19-06-08](https://cloud.githubusercontent.com/assets/1543473/6694298/b23c3cfc-ccd9-11e4-9a34-841da3e19153.png)

After:
![screenshot_2015-03-17-19-08-22](https://cloud.githubusercontent.com/assets/1543473/6694310/ba8942ec-ccd9-11e4-8d08-67c6173b499f.png)

@romracer
Maybe check if it's something that single-sim could also benefit from.
Then it's only a question of adjusting Settings part to remove preference if !isMotoXtDevice()


Something's fishy with my local repo. Trying again.


The init task for grunt is always dying since the shuffling of the front end bits.

```
Running "shell:ember:dev" (shell) task
Warning: Command failed: /bin/sh -c ./node_modules/.bin/ember build --silent
 Use --force to continue.
```


86121534_1304_WarnOnPATUpdate (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Can we keep these, for backwards-compatibility at least?


nor below? i was just modelling these all after what was in place with project_tasks


Hi esatterwhite, did you do an `npm install` since you got the latest code?
Might even be helpful to `rm -rf node_modules` beforehand.

On Tue, Mar 17, 2015 at 12:16 PM, esatterwhite <notifications@github.com>
wrote:

> The init task for grunt is always dying since the shuffling of the front
> end bits.
>
> Running "shell:ember:dev" (shell) task
> Warning: Command failed: /bin/sh -c ./node_modules/.bin/ember build --silent
>  Use --force to continue.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TryGhost/Ghost/commit/60dcfff956e70cd0dee1b8dbfcb1790eb8d33803#commitcomment-10243260>
> .
>


More helper methods, with nice names.


@sunfishcode: Do you think we could make this patch more general by making it target-defined? Maybe in TargetLowering or something?


Testing Anothertest


Mmm, you did good.
The issue is because the test is running twice (once in standard mode, once in remote mode). The second time fails... Let me think of a way to handle this...


@lucasallan this is how it should be - `randomizer` is only present in Rubinius, and not rubinius-core-api.


argh.  sorry.  how on earth did this work for me?!


I've reverted that change


Typo: the variable should be named `cleanups` (missing `a`)


De fapt nu trebuia summary (e gol mereu), era body. Fixat in 42448fdb57983617ebb42ab53cff16ddd8d18a0e


Только ограничения, при установке больше ничего. А вот в работе завал. Куча ошибок, свё пропускал-пропускал. Но когда не смог создать свое объявление - остановился..))) Нужно еще много чего дорабатывать...


Really; more helper methods, with nice names. Do we really need a 46-line block here?


Wow, I can't believe I missed that.  Yes, you're right.  Thank you for pointing that out.  This error was introduced in commit [49f8cb6caf4a45a92b2511119def97de3eb17f87](https://github.com/groovy/GMavenPlus/commit/49f8cb6caf4a45a92b2511119def97de3eb17f87), so it's been wrong since all the way back to 1.2.


[![Gourd-Shaped Ewer](http://api.artsmia.org/images/10020/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=10020)


[![Cape Trinity, Saguenay River, Moonlight](http://api.artsmia.org/images/120525/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120525)


[![Trees I](http://api.artsmia.org/images/105486/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=105486)


I'm a bit concerned that concatenating regexes will fail in unexpected ways. Some regexes may have flags like `(?i)` which sets the regex to case insensitive. Would that propagate the flag to all subsequent regexes?

I prefer deterministic code where possible, even if it's a little bit slower.


I bet we could extract these private methods somewhere and then inject `client` and `attribute_mapper`.


more pointless whitespace changes...


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (642 of 642 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.28%25-green.svg)


Conversion:

```sql
INSERT INTO judge_solution (url, title, content, is_public, publish_on) SELECT SUBSTR(url, 11), title, content, 1, NOW() FROM django_flatpage WHERE url LIKE '/solution/%'
```


nope, neverminde. I just needed to delete `bower_components` and `node_modules` from the client directory and re-run


Is this the 32 bit key id?  See http://www.asheesh.org/note/debian/short-key-ids-are-bad-news.html  (Ok, that's apparently down, https://github.com/freedomofpress/securedrop/issues/520 dscribes it too).

I'd say it's safest to only support fingerprints initially unless someone needs key ids.  If we do do key ids, I'd say 64 bit only.  This is the `keyid-format 0xlong` in `~/.gnupg/gpg.conf` - I wonder if it affects gpgme too?


I applied the code. Do you see anything that I might have missed?


@lukaseder  I've been meaning to ask for a while.  Is it really necessary to have Eclipse files in git?  I use it too, but when I commit into git, I put them in the .gitignore alongside /.idea

I'm asking out of curiosity and totally not trying to be tell you how to run your project.  Rather I want to understand this tendency and see if there is some positive trade-off that I have overlooked.


De fapt trebuia adaugat si in .info. Fixat in 5684188e3a5767254dd03bc7da79adc5b45e6c79


Fixed in bd22565c262b2549d67d6cab33bc91c1310df7bf.


soft errors are important too, but must not be stored in the results.Errors array.
I would suggest storing it in a SoftErrors array in the results.Statistics.


Ho, I forgot.

Original idea from Xenith @ https://hightechlowlife.eu
Code has been fixed in next commits; this one was a false guess.


Remove space after 'subscriptions'.


OK, cool, so you're replacing the `connection` dependency with a `client`, right? And then the client will contain some common logic?


The Builder is the class used to build Illustrations.


Which happens just when blob has been closed because of thresholds and we are about to open new base, right?


I've opened an [issue](https://github.com/groovy/GMavenPlus/issues/38) to document this.


We define these `noop` functions in a few places. We could save some lines using lodash, https://lodash.com/docs#noop `_.noop()`


Not a static int.


I'm not sure this is correct. The tabs are not part of the headers but are being retained.


Why quadratic? Isn't this easier as:
```go
for inst_key := range t.Cached.Instances {
	if _, alive := cleanups[inst_key]; !inst_key {
		delete(t.Cached.Instances, inst_key)
	}
}
```

... Actually, I _must_ be missing something, because I think as written you'll always end up with an empty `t.Cached.Instances` at the end (since no `inst_key` can prefix-match *every* `docker_id`)...


Oh, okay.
I remember testing things and realizing that the colours weren't right, and I ended up just switching the red, blue and green...
At least now I know what was wrong!