I have no idea. I'm just trying things.


I am just noticing the comment here, it doesn't make sense next to the one you added


Yes you're right, I forgot there is an "{}" inside. Thanks!


What if someone deletes the cache location in the middle of a tk session? I think we should drop the caching and calculate the path every time and check the disk every time.


These should probably be split into 2 subfolders like the scanner tests "should_fail" & "should_succeed".  Also there were some weird typos in the filenames it looks like: tes12.mc and test12.mc have different contents.  Also file extensions should be all renamed from .mc to .mC for consistency.

I will get around to these changes later if someone doesn't beat me to it.


Do you know where is it's source code (is it opensource) ?


Ok


`into a single one.` -> `into a single line.`

I'd added why: `This is required to implement JSON-per-line protocol for JSON streams with the newline character as a separator.`


Linje 1 har det sneket seg inn et mellomrom før `---`


Please do keep the vertical alignment


Só corrigindo algumas coisinhas no texto: experiência* e Câmara dos Deputados*


Riktig hash skal være `d695430b328a022170054ca8560b520f7338f8fe`


sorry, i do not know. However, the author has a github page, accessible from a hyperlinked picture on the hosting website: https://budueba.com/


What do you think of instead of creating a Logger for each update call, create the different loggers on creation of QueryLogger and then change logger.log() to logger.log(host, statement, latencyMs)?


We should wrap this call in a umask reset to ensure that it actually gets 0700 permissions!


Sweet!  Can you send me a pull request so I can integrated into the main repo?
Also, lots of new stuff in the main repo (including support for GLSL and masks).


Thanks :) your welcome.


hmm... wow. No, I am not sure. Thinking through the tests I ran, I can't
remember if I checked the whole block or not. Also, I am using the F1 so
I'm not sure if that behaves just like the F4 here.

I will give this a try next chance I get and let you know what happens.

On Wed, Mar 11, 2015 at 10:54 AM, Cliff L. Biffle <notifications@github.com>
wrote:

> Ran across your code when I was looking for examples to clarify ST's
> (awful) docs. Are you confident that this DMA configuration results in
> complete block transfers? I assume you'd notice if your application were
> e.g. failing to read the final 12 bytes of a block....
>
> I ask because, from what I can tell, the SDIO peripheral on the STM32F4
> fails to generate the last three DRQs during a block transfer. I see this
> with or without PFCTRL set (you're not setting it here), and with or
> without using interrupts to synchronize. There's an offhand comment in the
> reference manual about enabling four-transfer burst mode, which seems to
> fix it. You don't appear to be setting it here, and I'm curious if you
> tried and what your results were.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openstenoproject/stenosaurus/commit/cdc10ebdcb58158677603463a5b5b255a3fdfedc#commitcomment-10144030>
> .
>


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: js/navigation.js


> I might need to move PLAINTEXT_LENGTH definition to next to the comment explaining that 23 is the real safe.

That would be confusing anyway. c2f8265 changes the code to our conventions instead.


Thank you for fixing this :)


Fixed. By the way, are commenting on the PR via the `Files Changed` tab? Your comment is showing up like this on the PR:

![lel](https://cloud.githubusercontent.com/assets/4174345/6607613/962d1512-c816-11e4-8d66-33bcc918ed67.png)

and will cease to exist (as opposed to saying `outdated diff` if a new revision is pushed, regardless of if the line has changed or not. Not sure if you already know that, but I do it occasionally, and try not to.


add `status: :created`


COM_3PPPack_PathOfWarEx - Helper Things.user

The comments I can blame on the editor.  The tag names...force of habit, I guess.  I'll clean it up tonight.


Bronze 2
Adicionado Text Field e um Button para o sistema de busca
Implementado o sistema de busca com try catch.


r+


yep, that's the good point of lazyness ^^


@Montellese I hope that fixes the compile error ;)


unfinished?


Because this method is only used in *CountingJoin. Maybe we should merge it with the more generic tupleEquals() which requires both compareColumns to be provided.


So, effectively,
```go
_, exist := t.Cached.Instances[instKey]
```


Please make this a table testing as `TestIPAddressPortSet`. I think the case of `127.0.0.1:4001` should still be covered.


@aleos89 the warning messages are still showing up.

pc.c: In function ‘pc_checkskill’:
pc.c:5524: warning: unused variable ‘i’
        CC      pc_groups.c
        CC      pet.c
        CC      quest.c
        CC      script.c
        CC      searchstore.c
        CC      skill.c
skill.c: In function ‘skill_parse_row_skilldamage’:
skill.c:20509: warning: unused variable ‘skill_id’
skill.c: In function ‘skill_unitsetting’:
skill.c:12079: warning: array subscript is above array bounds


This is an debian based offloader currently under development


Unneeded. Thanks for spotting this.


Do this via `defer`?


saw approval from jdm
at https://github.com/brson/servo/commit/de07bff8d6f664e0fafcbe58a5d076f35cc4c43a


merging brson/servo/cleanup2 = de07bff8 into auto


brson/servo/cleanup2 = de07bff8 merged ok, testing candidate = 1f33b53b


Yes, but it's annoying to try and debug anything in the browser when it is constantly redirecting...maybe there's a way to test this that won't redirect the browser that can still detect browser default action behavior, maybe location hash?


yes, it will be as it used to be before FOW (we ask the server and it sends the order).
It will be like picking a creature or building a room as the answer will be async.


No need to unlock if the instance doesn't exist? That seems really odd.


will it listen on all interface? does empty string work?


That would probably work.  It redirects on the test-successful sometimes too which is also annoying.


Since you have a separate logger for each type to be logged, the user can control the visibility of the messages that way.  I think the levels you are using now are good and sensible, and if a user wants to change what is visible in the logs they can adjust it.  I could see a use case for wanting to control the levels, but that maybe complicate the API a bit.


Is a RuntimeException possible/expected here?


Why did you remove the blank line here?


Should probably add a comment about why no locking is required here.
Not sure if we want to check for existence here; is it an invariant failure if it doesn't exist? (And write comments about the invariant if it exists)


嗨,

hjwdzh@gmail.com 想關注您

****** hjwdzh@gmail.com 是您的朋友嗎？ ******
好/是: http://invites.infoaxe.net/signup_e.html?fullname=Hjwdzh/physbam-drive-pc&email=reply@reply.github.com&invitername=hjwdzh&inviterid=37132591&userid=0&token=0&emailmasterid=cc3ded21-e77d-4b3c-b0df-bd46c83d94ca&from=hjwdzh@gmail.com&template=invite_reminder_b&src=txt_yes

不/否: http://invites.infoaxe.net/signup_e.html?fullname=Hjwdzh/physbam-drive-pc&email=reply@reply.github.com&invitername=hjwdzh&inviterid=37132591&userid=0&token=0&emailmasterid=cc3ded21-e77d-4b3c-b0df-bd46c83d94ca&from=hjwdzh@gmail.com&template=invite_reminder_b&src=txt_no

按一下這裡，將您自己從所有這類電子郵件移除
http://invites.infoaxe.net/uns_inviter.jsp?email=reply@reply.github.com&iid=cc3ded21-e77d-4b3c-b0df-bd46c83d94ca&from=hjwdzh@gmail.com


Missing closing angle bracket her


```go
offset, _ = tailNode[fname]
```
No need to do the hash lookup twice (which might end up with races if it got removed at the right time).  Same with fetching `tailNode` above.


Shouldn't this be in a `finally` block?


Always use specific version instead of `+`.


https://github.com/ParticularLabs/GitVersion/issues/121 might be related


I'm aware. That's not an issue with this version. The next version will be 22, it's just not published by Google yet.  @chalup


@saleiva, we removed a needed line with the friday fix and that was happening :D.

![screen shot 2015-03-11 at 22 58 30](https://cloud.githubusercontent.com/assets/132146/6607857/6ef1c0b6-c842-11e4-896d-14dfa5ae9a05.png)

Fixed with change.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12626/testReport/) for this commit**


Why is this an add, rather than a `StoreInt64`? (also, I thought you mentioned using unsigned)


With [JAVA-115](https://datastax-oss.atlassian.net/browse/JAVA-115) and [JAVA-547](https://datastax-oss.atlassian.net/browse/JAVA-547) also targeted for 2.10 we can probably consolidate this logic into BoundStatement.getValues().   I'm not sure of the best way to do this though.


Thanks — completely forgot about the initialization logic, as I was focussed only on the public PSR-7 interface!


This looks like it's extracting the current set of pods and then comparing it. Eventually we have a desire to run tests in parallel. I think this test needs to somehow isolate "some pods it's monitoring" (maybe because it starts some scratch pods) versus "some random pods", because this test may fail if another test time-slices?


@kbruner That's an interesting find! What version of Ruby were you using? Well, it's more the version of RubyGems but I'm surprised I didn't run across this myself.

In any case I'm dup'ing the String constant now in 951072d6367057c257e987a7c7e6f5f7de1999eb when passed to `Gem::Version.new`. If you have the time, could you verify that fix (it's in master)? Thanks!


Assuming you do need it to be an add for some odd reason, `AddInt64` should return the result anyway (no need to do an extra load to get it back out again)


:+1:  on using `javax.inject.Inject`


I verified this fixes problem with MongoDB >=2.6 with versions 2.6.6 and 3.0.0.
It seems `make clean` did not clean some `*.cache` files created by previous version of OCaml.


I am new to this, but is there a reason why Lines 61 and 45 are checking for the same condition ?


The same thing is happening here as mentioned before.


<!-- struts /target/classes/org/showcase/struts2/action/employee.properties from struts2-showcase -->
employee=Employee
employee.firstName=First Name
employee.lastName=Last Name
employee.description=Description
employee.id.required=Id is required
employee.lastName.required=Last Name is required
employee.birthDate.required=Birthdate is required
employee.backtolist=Back to Employee List

<!-- to reference value assigned for employee.firstName from within index.jsp: -->
<%@ taglib prefix="s" uri="/struts-tags" %>
<s:action var="skillAction" namespace="/skill" name="list"/>

<s:form name="editForm" action="save">
    <s:textfield label="Employee Id" name="currentEmployee.empId"/>
    <s:textfield label="%{getText('employee.firstName')}" name="currentEmployee.firstName"/>
<!-- getText will get employee.firstName from action properties file aka EmployeeAction.properties -->
<!-- and the resulting label will read when rendered-->
First Name:


I could be wrong, but I think the Parquet internals use the same backing array for all plain-encoded pages to avoid an unnecessary copy.


I hope you have the disposition to keep working on this. :-)


Err. Wait. `offset` is local, nobody else has access to it anyway. (I blame GitHub for not having a review-commit workflow)

```go
atomic.StoreUint64(&tailNode[childKey], childVal)
```


<s:action var="skillAction" namespace="/skill" name="list"/>

<s:form name="editForm" action="save">
    <s:textfield label="Employee Id" name="currentEmployee.empId"/>
    <s:textfield label="%{getText('employee.firstName')}" name="currentEmployee.firstName"/>


Should we add something to the wiki about "Using Regular Expressions with DB4S"?  Kinda of thinking it'll be a useful feature for people that are into regex's.

?


Same need to help with load balancing.


I thought that originally but you need to look at what close does.  It renames the file rather than just closing streams (the atomic part of the atomic file writer)
Abort which is in the finally courses the steam and delete the temp file.


Remember to fix that function made from excrement!


closes #1


:+1: for spotting that.


We don't strictly need it here.  I put it here for consistency sake, and future proofing.  I'm indifferent on keeping it or removing it, and will defer to what you'd prefer.


<s:action var="skillAction"
namespace="/skill" name="list"/>

<s:form name="editForm" action="save">
    <s:textfield label="Employee Id" name="currentEmployee.empId"/>
    <s:textfield label="%{getText('employee.firstName')}" name="currentEmployee.firstName"/>

when rendered you should see:
First Name:


Fixed, will include this with whatever you decide on the other comment.


Done. Now that this change is in, I don't need to maintain a fork to remove `private: true`. Who is the current maintainer of this module, and would they like to be an npm owner?`


> The return value is not constant

how is it not?  It always returns the same value, doesn't it?


Ship it!
![Ship it!](http://i.giphy.com/iXWEu3SxQDDmE.gif)


There should be no reason to write back the thing you just got?  You should just be editing a structure in-place.


@coulix this is fixed in 1.0.0 beta. See #72


you removed too much .. /configure.sh should stay otherwise influs & grafana are not configured correctly


You probably want self.machine.host here.


I think this audit change code should be in a separate commit with a longer docstring. The code looks reasonable, but conceptually I don't follow. What is the difference between checking the field names and levels off perms retrieved off the user, and calling `_get_joint_writable_fields`? It's already pretty complex, but this could be making it more complex.


Yeah I should probably stop putting in comments that can't be seen in the editor. =(


Can you make a pull request, so it can get into the main repo?
Thanks


It's best to keep import statements at the top of your file, or at least outside of class/function/method definitions. This makes them easier to find and change.


Alright, I filled the form.


@ntdb I think the situation for issue #33 is that the course ids both aren't listed in a cohort *and* have been deleted from Wikipedia. So when .update_all_courses runs, it doesn't end up updating that course because it can't get any data at all from Wikipedia.

Try to make this test pass with 'id: 1' (which does not exist) instead of 589 (which does exist).


Indentation seems wrong here?


Now it tests two cases: 127.0.0.1:4001 and [2001:db8::1:1234]:4001.


closes #4


I appreciate this.  The confusion was due to my usual method of computing length, by looking for PLAINTEXT_LENGTH.


@hrpmrl, @relshire has added this license.

I recall an email 13/02/2015 also CC'd @hdzierz

```It’s nice of AgResearch to consult, but I think it unlikely that we would opt out of involvement in the project based on their choice (of license)```

Any further comments or actions?


I forgot how tests are supposed to be run. Could you add instructions to the README?

It seems like since an error occured, we should be returning a nonzero exit code here.


remove the time from the messages since it is in the code below


Readme


mmm, yes of course


ok. sorry :/


yes, but LOG comment, this var not use in method


yes, same folder
if need not


wow!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12627/testReport/) for this commit**


some tests failed:
failure: http://build.servo.org/builders/android/builds/1024


(You'll need to regenerate the wiki/course_list cassette after making any changes.)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12628/testReport/) for this commit**


I thought you would use hasTrailingComma here, but this works too.


Thank you for information :D Trust me that I was trying to do everything I know, but my knowledge of git is not that perfect.


Probably id: 9999 is better to try, since we know that won't exist on any wiki.

And we can test 589 also as a case that does exist (on English Wikipedia) but we don't expect to be listed in a cohort.


I am a nice comment


@adam-p: The feature would be fine to get upstream. But I have some doubts about the API as it is now.

I see existence of the style `MC_HS_NOTIFYNAV` as not really needed. The return value from `MC_HN_NAVLINK` should be enough:

 * By definition main/parent window procedure should return 0 to notification it does not know or does not want to handle. This also answers your second question: Zero = default behavior. (See http://www.codeproject.com/Articles/646482/Custom-Controls-in-Win-API-Control-Customization, section Descision-making Notifications at the bottom of the article)
 * Any performance loss is negligible as user do not tend to click links too often to make one `SendMessage()` call per click measurable.
 * Control style bits are a scarce resource, lets save the bit for better purpose in the future.

Also, I tend to think the following behavior might be better:

 * `MC_HN_NAVLINK` would be fired for any link (including `app:`). (It could then likely be renamed to just `MC_HN_LINK` to be more descriptive.)
 * Zero return value from it would then trigger the default action as said above: I.e. sending the current notification `MC_HN_APPLINK` for `app:` links, and following the link in all other cases. Non-zero return value would mean suppressing of the default action (control does nothing).

My point of view is that apps will likely want to handle only the `app:` links (then they may just handle `MC_HN_APPLINK`) and ignore `MC_HN_(NAV)LINK`, or **all** links regardless the protocol and then the handler needs only to handle `MC_HN_(NAV)LINK` and ignore `MC_HN_APPLINK`.

Also it IMHO makes the API easier to understand. The scope defined as "all protocols but one" as it is now for `MC_HN_NAVLINK` simply seems ugly to me.

And last but not least consider possible future compatibility issues: Some other protocol might need new special notification in the future. And we could not remove it from the scope if `MC_HN_NAVLINK` for compatibility reasons. So that would create an asymmetry between `app:` and that other special protocol in the API.

Any opinions about this?

Finally, just a technical note: When you start on a new feature which might be good candidate for going upstream, consider please doing that work in extra feature branch and then create a pull request for it. It is then much easier to discuss it, review it and work with it. And the pull requests is the core feature which makes github so effective tool. See https://help.github.com/articles/using-pull-requests/


Zašto ne koristiš kod kao ja? Moraš ih dodati obrnutim redoslijedom.


confirmed, totally on purpose

https://github.com/frostwire/frostwire-desktop/commit/459722d08bbf9c961bf0d9a241157da497e91448


GridViewBugFixes (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Never at the root of a `.d.ts` file. Only do this inside `declare module 'something'`


[::] will listen on all interfaces; empty string will not work, because address is used in URI construction code (like "http://" + address)


The while loop is meant to be nested inside the if statement, not to be part of the "main" thread.


Why not .R8?


This test will always pass as written; just omit it and do the iteration. You can also skip the `hasOwnProperty` check below, and you can consider using `_.forEach` for the loop (or not, I don't think there's a strong argument either way?)


No problem! Tracker has some really elegant programming patterns if you can find them ;)

I've built my own mixin that has a bunch of other features you may want to check out. They don't have rigorous tests but there are example apps that demonstrate correctness.

1. When you're subscribing to a bunch of posts (maybe 1000), you will get a ton of re-renders while posts are coming in. [So I block the state from updating until the subscriptions are ready](https://github.com/ccorcos/meteor-react-utils/blob/master/src/utils.coffee#L166).

2. For fine-grained reactivity, [I transfer all props to reactive-vars, called `this.rprops`](https://github.com/ccorcos/meteor-react-utils/blob/master/src/utils.coffee#L35). This way, in getMeteorState, [you can reactively update to only the props that the function depends on](https://github.com/ccorcos/meteor-react-utils/blob/master/examples/rprops/main.cjsx#L14).

3. [LinkVar](https://github.com/ccorcos/meteor-react-utils/blob/master/src/utils.coffee#L44) is the same as `this.linkState` but for reactive-vars. [This is super convenient.](https://github.com/ccorcos/meteor-react-utils/blob/master/examples/linkVar/main.coffee#L23) I don't really know how to describe why its so awesome other than it is. I think people in the React community could really like it because it prevents you from having a ton of different callbacks back to the common ancestor of two components.

4. On a similar note, [`sessionVar`](https://github.com/ccorcos/meteor-react-utils/blob/master/src/utils.coffee#L53) will link a reactive-var to a session variable so the [state is preserved across hot-code pushes and across component mounts and unmounts](https://github.com/ccorcos/meteor-react-utils/blob/master/examples/sessionVar/client/main.coffee#L20).


4551-More_F90_Cleanups (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


revert this change. (now I was not clear it)


Explain why not an issue for getArgumentIndex, and also, why not an issue for preceding commas.


FYI, the same pattern appears in 'phong' fragment shader, too.


It's the mobile client, a compromise rather than forgetting to do it later.


@gnardini esto si queres lo podemos charlar con tu TM y preguntarle si es parte de la card o es un bug que se tiene que reportar y resolver en otro momento.


Will ammend :)


It's still not commonJS compatible and relies on `window.$`: I have a PR with a fix in but it has been ignored so far.

I'd be willing to maintain a fork with commonJS compatibility if you no longer want to update your fork and the maintainers of this module don't want support in the actual library—we use this library at work so I'd keep it up to date.


Wow! you remember even. I'm sorry that doubted this line


linea muy larga :D


@gnardini fijate los comments y mergealo, algunas cosas no te las marque las charlamos mañana!


Don't merge it. ı think it was bad idea. There is no problem on bootanim except some stutters but that is normal ı think


Standard-Regel:
* Klassen werden in einen Ordner mit dem Namen "class" gespeichert, der idR außerhalb von htdocs liegt
* Dateiname: klassenname.class.php (viele Entwicklungsumgebungen erkennen das auch automatisch)


```
"http://idle.land/s/maps/#{route.params.map.split(' ').join '%20'}?x=#{route.params.mapx}&y=#{route.params.mapy}"
```


Jede zweite Zeile ist eine Leerzeile - hier hast Du einen Fehler in der Codierung.
Bitte Check & Fix


er, ... why did that go to a line break though


Why do Body/EmailBody and Subject/EmailSubject not have the same types? Why is choice made for []byte vs string in these cases?


Möglichst Präzise:
Was sind "die Daten"?


ı couldnt try this change yet but ı think it should be good right?
did you try it?
thanx


This code is dead.  I just need to delete it.


@friedmud : Loose tolerances in function_sideintegral/tests.   I just copied from another 'tests' file, and will tighten them up.

a


I would suggest "casefold" over lowercase, since unicode doesn't necessarily have the concept of lowercase. Additionally, casefold version of a UTF-8 encoded string is not guaranteed to be the same byte-width as the non-casefold variant.


That's a good point. There's no reason as far as I can see. THCudaStorage_copy and THCudaStorage_copyCuda behave in exactly the same way. This could be cleaned up.


"number" ist kein Datentyp, s. http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.param.pkg.html


@ragesoss Good thoughts, on it.


NOPE


Iskreno - too much mi je sad učiti nešto novo. Pokušao sam ih syncati obrnutim redoslijedom, ali to nije pomoglo. Znači, ako ih sad pobrišem pa ponovno dodam kontra redoslijedom će biti ok...

Ajd, ispravit ću...

________________________________
From: Milivoj Milani <notifications@github.com>
Sent: 11 March 2015 23:21
To: ArmA3Pro/mission-pack
Cc: Vedran Filipovi�
Subject: Re: [mission-pack] Moduli (3518c7e)

Zašto ne koristiš kod kao ja? Moraš ih dodati obrnutim redoslijedom.

—
Reply to this email directly or view it on GitHub<https://github.com/ArmA3Pro/mission-pack/commit/3518c7e3ce7b36be8536951f882bb8a41e863f99#commitcomment-10153589>.


sure, i don't use this module anymore. what's your npm username?


Building OpenELEC with latest libnfs master (including this change) now results in a build failure, are there more code changes required in libnfs or is this an OE issue?

Build log: http://pastebin.com/UHci91Nh


Ramere wimberly


I updated the slides for this quarter we did.
@Neutrogena @hedai @hugh-li  you can use this slides for your presentation this quarter.


Funktionsnamen sollte erklären, was die Funktion tut:
* Liest sie die Daten nur ein, speichert sie in der Intanz und gibt return true oder return $this? Dann loadData()
* Lädt sie die Daten und gibt sie zurück? Dann getData() oder returnData()


It's callumacrae again. Thanks!


That's the question. :) Already fixed in 098f316.


This comment isn't necessary


I forgot to comment before merging this: the gulp js file should also be updated to rebuild the test bundle automatically as well.


Add a newline


Richtig, aber mächtig old-school.
Die PHP-Funktion die Du suchst heißt http://php.net/file_get_contents


I think it would be nice since it's an optional feature. It's also worth mentioning that's it accepts a Perl-like syntax with non-greedy quantifiers :grinning:


There is 22.0.0 in latest support repository already


mongoc_uri_lowercase_hostname() asserts that its input is ASCII.  If we ever decide to accept non-ASCII hostnames we will have to change this.


Oh come on, LED smoke is the best!


Hey, it might make sense to go back and scope this line - it wiped out the bullets site wide.


Yes


How is this change a pure cosmetic change?


Heads up - this change appears to have broken bower - not sure if this is an rx issue or bower issue

```
module.js:340
    throw err;
          ^
Error: Cannot find module 'rx'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/ubuntu/.buildkite/builds/contests-ip-10-168-80-147/99designs/contests/node_modules/bower/node_modules/insight/node_modules/inquirer/lib/utils/utils.js:8:10)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
891    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
```


K, you're added: https://www.npmjs.com/package/jquery-placeholder

On Wed, Mar 11, 2015 at 3:34 PM Callum Macrae <notifications@github.com>
wrote:

> It's callumacrae again. Thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mathiasbynens/jquery-placeholder/commit/b4aff96f7881b20f7c5dfb28b46c88ff8e0edfc9#commitcomment-10153826>
> .
>


could you please add buckys instant messanger source code. and ı want you to a new video about how to transfer a file in java application. thanks  u re awesome


thank you£¡

Sent from my iPhone

> On Mar 11, 2015, at 15:34, Taeyoung Kim <notifications@github.com> wrote:
>
> I updated the slides for this quarter we did.
> @Neutrogena @hedai @hugh-li you can use this slides for your presentation this quarter.
>
> ¡ª
> Reply to this email directly or view it on GitHub.
>


There wasn't when I made this pull request yesterday, and they still aren't
from what I see from Android Studio (it can't resolve that version).
They're never immediately available after API releases.

On Wed, Mar 11, 2015, 5:37 PM Jerzy Chałupski <notifications@github.com>
wrote:

> There is 22.0.0 in latest support repository already
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/afollestad/android-floating-action-button/commit/81ce7232b1316f54bcc482c8290db3024c643f48#commitcomment-10153859>
> .
>


integer 24/8 == (23+7)/8 == 3


a boolean is enough and code is easier to read. Please change it


Methoden machen "normalerweise" keine direkte Bildschirmausgaben.
Eine typische Methode gibt die Daten als Array zurück - ausgegeben werden die Inhalte dann prozedural.

Solltest du einmal davon abweichen wollen, muss de Methode so benannt sein:
printData() zum Beispiel


@XhmikosR good catch.


This looks like a functional change, not cleanup.


LOG comment, this var not use in method


Yea, that's a pretty good match, @JakeGinnivan.


You probably need to update support repository through Android SDK.


Copyright ist idR 1601.communication gmbt


Perfekt!


Please use this regexp `s/^.*-([0-9]+)$/\1/` and match against SPK_REV (always incrementing), that's safer than making assumption on future upstream version numbering scheme.


camelCase, bitte.


Or implement punycode \o/


I am not completely sure to understand if this change is mandatory, but I had to do extra modification to make the current code working nicely with this change, as we can no longer wrap a module within another function.


Bitte achte auf Dein Denglisch.
$username und $passwort vertragen sich nicht wirklich ;-)


Lines 7 and 8 need to be moved all the way to the end. This is so the window does not close before you actually run the app.


Yeah, I've tried. It hasn't been available to me yet.

I've been an Android dev for 3-4 years. I've done this many times.


Bitte überlege Dir, ob Du das Passwort innerhalb der Instanz dauerhaft benötigst.
Ich könnte mir vorstellen, dass Du das nur einmalig als Parameter für einen Login benötigst.
Wenn es so ist, bitte nicht dauerhaft speichern


s. o.


I'm sorry but still not sure what I'm suppose to do copy input? Confused


Passt, bitte künftig:
http://de2.php.net/manual/de/function.crypt.php


it was an annoying bug :)


I updated the PR regardless, though


OK, let's wait until it's available, update this PR with `22.0.0` and merge it then.


Benennung nicht gut.
$passwordHash fände ich gut.


@katerynaz15 I'm not sure about this one. Let's talk about it tonight.


Good point! PTAL.


> If the load is missing a cookie, I open bungie.net in a new tab, load the cookie, and reload the extension.

Awesome.


this still needs to be double quotes, or people are going to be confused with how other commands work. `\":map\"`


Name this `uncompressedSize` or `inputSize`


Das ist viel des Guten, den Abgleich der Hashes kannst du innerhalb einer Methode machen - der muss nicht in der Instanz verfügbar gehalten bleiben


Haha :D


awesome! we'll have preview on cloud downloads


IP-Adressen sind kein INT, sondern ein string
(Es gibt keine Zahl 123.123.123.132 - INTs erlauben nur ein Nachkommastellen-Trennzeichen)


It was a mess with angular v0.8.0-master
hope that's fine now


@maxwen Hello, where is the file that modifed Power menu to show it in the bottom? I am on hammerhead build...


Replacing http by https is not the best way.
I finally used "//domaine.com" syntaxe to let browser decide.
Thank you for your contribution ;)


Hier fehlt was


Most of the sprites that would otherwise fall back to this definition aren't R8.


Oops, sorry for that


Haha, kinda late huh?


Rename the other one `storage.max-shard-rows`


Der Beweis, das camelCase "immer" sinnvoll ist: Schon hier hattest Du vergessen, dass Du Deine Klasse in Großbuchstaben geschrieben hattest ;-)


Thanks！

发自我的 iPhone

> 在 2015年3月11日，15:34，Taeyoung Kim <notifications@github.com> 写道：
>
> I updated the slides for this quarter we did.
> @Neutrogena @hedai @hugh-li you can use this slides for your presentation this quarter.
>
> —
> Reply to this email directly or view it on GitHub.
>


@XhmikosR we already discussed this point on the 27th of October where I say that `grunt.util` will be deprecated but in fact it was only some functions under `grunt.util` that have been deprecated.
[comment](https://github.com/yeoman/grunt-usemin/pull/469#issuecomment-60578469)


"Approximate maximum uncompressed size of a shard"


You could simplify `isBetValid(bet) == false` using negation: `!isBetValid(bet)`


Looks like this

![freaktrain](https://cloud.githubusercontent.com/assets/1522517/6608711/99ec4192-c806-11e4-939c-419d88567be9.gif)


Hi,
By changing px values you didn't fix the alignement bug, you just adjust alignement in your case.
Last CSS files I suggested are using full `em` values and some `display: table;` layout.
Thank you for your suggestion ;)


Thank you！


Move these above, after `max-shard-rows`


NOPE, seek not seer


verarbeiten ist kein guter Methodenname.
checkLogin() oder login() ist ein guter :-)

Die Reihenfolge der Parameter erscheint mir untypisch. Normalerweise gibt man erst den Benutzernamen, und dann das Passwort ein. Ich hätte die Reihenfolge so gewählt:
* $user
* $email
* $pwd1
* $pwd2


Fixed in 35ce52287988d5b9b00588d5c1eb536503201283.


new


Looks like this can throw an AuthenticationFailedException.  Some handling for this exception would be good to clue the user in that an authentication issue happened.


Please replace the spaces with tabs on the two lines above.


I'd be sad if `MAX_PARAMETER_VALUE_STRING_LENGTH` and `MAX_QUERY_STRING_LENGTH` weren't configurable. One of the best parts of a slow-query logger is the ability to grab the statement verbatim and then trace it.  FWM if that's a separate commit/issue.

Looks good though!


nitpick: `os.SEEK_SET` for the second argument to Seek


@jennyq I've updated the core templates to use `{% block content %}` instead of `{% block body %}` for semantic purposes. I'll need to revert this to the former one.


This drops the visibleSeries parameter.
It is needed, because calculating the stats for all of the series whenever new data is added is too expensive  - and is about to become a lot more expensive.


chez moi ça le deuxième `&`ça veut pas :

```bash
$ npm run watch

> sudweb-2015@1.0.0 watch /Users/frank/code/sudweb:2015
> npm run thumbs && grunt & http-server -o

sh: http-server: command not found

npm ERR! Darwin 14.1.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "watch"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code ELIFECYCLE
npm ERR! sudweb-2015@1.0.0 watch: `npm run thumbs && grunt & http-server -o `
npm ERR! Exit status 127
npm ERR!
npm ERR! Failed at the sudweb-2015@1.0.0 watch script 'npm run thumbs && grunt & http-server -o '.
npm ERR! This is most likely a problem with the sudweb-2015 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run thumbs && grunt & http-server -o
npm ERR! You can get their info via:
npm ERR!     npm owner ls sudweb-2015
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/frank/code/sudweb:2015/npm-debug.log
```


do u get any crashes from player, when they leave the instance?


Passt. Wenn Du ganz sauber und mit gesalzenen PWDs arbeiten möchtest, mach Dir eine eigene hash-funktion wie heute besprochen. Entsprechend nutze dann hier folgenden Aufruf:

`$pwd = $this->getPwdHash($pwd);`


Link to Google


Could have <= 0?


Nice catch


where is bla bla ?


pas mall


Habe ich noch nie benutzt, ich greife immer auf $_SERVER zu. Spricht aber scheinbar nichts gegen - könnte mir nur vorstellen, dass $_SERVER minimale Performance-Vorteile hat


Add parens


I'll need an example image and actual points to troubleshoot. My guess is that your second point sits outside the image. I think by default the outside of the image has value 0, so if you try to draw a line that extends beyond the image coordinates, you will see all zeros.

btw, try the mailing list for this kind of help. I only saw this comment by chance on my github feed, but did not get any email notifications or anything!


And here you can get rid of the if/else block as well. Since your boolean expression `(bet >= 5) & (bet <= 10)` already returns true or false, you can simply return its value rather than checking for it. So you can replace the if/else with:

`return bet >= 5 && bet <=10`

You'll notice that you don't need the brackets since JS will read the expression from left to right anyway. Also, you were using bitwise AND (`&`) which is usually a bad idea in JS since JS doesn't have Integers but works with Floats. A logical AND is written `&&` and is usually recommended since it's faster than bitwise AND.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12633/testReport/) for this commit**


Íå, åùå äåëàþ

On Mar 11, 2015, at 10:13, RaMMicHaeL <notifications@github.com> wrote:

> Ïðèâåò!
> Ïåðåâîä ãîòîâ?
> ß ñëó÷àéíî óâèäåë êîììèòû, íî íå áûë ñîçäàí ïóë ðåêâåñò.
>
> —
> Reply to this email directly or view it on GitHub.
>


Heh, remember how often I did such things :). No worries.


Might as well move this case up, save the `:empty()` call.


Hej Flo,
We worked in this feature today too :)
But we aren't happy with this solution, because there is no fallback to german language in the result of GetItemCategoryTree. Additionaly, it only work if the category-tree in plenty is splitted like in shopware. If you to import the same category (same plentyId) with different translations/languages, there will be a problem with the mapping (1:1map isn't possible, because there are two or more correspondending categories in shopware).
So we decided to extended the category-mapping with a language-column. It's not completely tested and a bit dirty, but I try to complete and commit my lines tomorrow ;)


Thanks :)


test


You don't need to `break` here, since returning from the function also stops further execution. A `break` is useful if you want to continue doing stuff after the switch block.


Nice use of early returns! :)


Would love to know how you did this.


Just a head's up: if you define a variable in JS without using `var`, it's defined as a global variable (and it puts it on the window object), which is generally discouraged. In this case it doesn't seem like you need to use globals since you're grabbing the value of bet and guess form the DOM, so it would probably be better to declare them using `var`.


@agocke Were these intended?

Src/Compilers/VisualBasic/**vbc2**/packages.config → src/Compilers/CSharp/**csc2**/packages.config
Src/Compilers/CSharp/**csc2**/packages.config → src/Compilers/VisualBasic/**vbc2**/packages.config


From Scala's documentation it looks like `count` counts elements satisfying a predicate.


The `_lp_shorten_path` function must not be modified because your change will adds a runtime cost.

Instead `$LP_CURRENT_DIR_ONLY` must be checked at line 271 when `LP_PATH_DEFAULT` is set.


u can use the utility class `.u-pointer` for this @mikeyrayvon


顺便提醒一句，这个角色也可能会有歧义，我给漏过了，虫娘检查一下要~


I have no idea how it happened. And I think those erroneous renames are just Git being a little weird. Those files are identical, so it doesn't matter.


Thanks for contributing!

This would benefit from a customValidate (http://nifi.incubator.apache.org/docs/nifi-docs/developer-guide.html#validating-processor-properties) to tie the username and password properties together and ensure both are supplied.

Did you test this against non-authenticated SMTP?  Navigating through the backing SMTPTransport class, it seems like empty credentials take us down a path that may lead to exceptions with empty values.  Either way, consider setting a flag via customValidate that indicates the desire for authentication and handle accordingly in your process method.


You could remove the if/else block here as well by simply returning the expression, and you could also shorten it by combining your checks for whether `bet` is between `MIN_BET` and `MAX_BET` like this:

`(MIN_BET <= bet <= MAX_BET)`

Same thing for `MAX_GUESS`.


4551-More_F90_Cleanups (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (639 of 639 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.22%25-green.svg)


A suggestion: nn.ZeroPadding. There can be mirror-padding, and other kinds of padding as well.


Change the example to `Foo(a,,b,` Otherwise, it's ambiguous which comma is the one to the left of the missing node.


If we are replacing `versionDigits` with `versionNamingPattern` then we need to log a deprecation WARNING explaining replacement whenever we find that the user has specified `versionDigits`.

This will need to be for the ManifestMerger element as directly on the plugin (if we allow that)


this shouldn't be needed yet, right?


Good correction, this is one place it seems to differ from Apache Spark in terms of what methods do. I think its probably better to default to what Scala does than what Spark does, especially given in this case that count actually is aliasing `len` and `size`. I can fix this in a little.


Update docs on what it returns


4551-More_F90_Cleanups (mmatts) - x86_64-MacOS-10.9-clang: OK (1649 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Now you can do cool stuff, like this:

```bash
def find(src, pattern, isRoot) {
	if (isRoot) {
		return @(sudo find $src) | @(grep $pattern);
	} else {
		return @(find $src) | @(grep $pattern);
	}
}

finded = find("/", "linux", true);
for (f in finded) {
	print(f);
}
```


:smile:


please try to stay consistent with underscore_function_names as you have elsewhere


Well, it's really about whether the last real argument gets counted or not. If you are to the right of the trailing comma, the argument to the left of that comma gets counted. If you are to the left of the trailing comma, the argument to the left does not get counted, because it's yourself.


These should both have an optional `offset` and `timestamp`:

```python
def clear_key_before(self, key, namespace, offset=None, timestamp=None)
    raise NotImplementedError

def clear_key_after(self, key, namespace, offset=None, timestamp=None)
    raise NotImplementedError
```


Hmm... I'll have to think about this more.  Perhaps you can convince me.


wildcard imports and generally discouraged

I'd also recommend a more pithy naming scheme (the final application can have a long name, but is there really any reason to have 360VideosMetadata duplicated three times in the file names?)

I'd go with:

gui.py
cmd.py
mp4.py


Minor. Should the order of the arguments be inverted? (output device first, followed by exit status?)


Petit soucis : le cadavre de Corki reste sur place après la commande despawn, je ne trouve pas comment faire disparaître le cadavre (j'ai cherché dans les flags).
![wowscrnshot_031115_235725](https://cloud.githubusercontent.com/assets/4172776/6609012/fbdb16d0-c84c-11e4-88bd-b3878f01786d.jpg)


@addyosmani could you make a new version for that fix?
Catching all after the success callback messes up our tests when failing and catching before the callback causes duplicate calls. See https://github.com/bezoerb/grunt-critical/issues/9
Thanks


Lines 140 and 141 aren't correct. You could delete line 140 and use #define without semicolon at the end.


@christorpelund: https://github.com/serverspec/specinfra/pull/341


4551-More_F90_Cleanups (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Je m'en sert uniquement pour avoir un lien sur les stats. Sinon, c'est inaccessible sans connaître l'adresse.
Mais je pense qu'il faut rendre ça un petit peu plus esthétique, là c'est très moche. Et ça marche pas! Mais j'ai pas regardé pourquoi pour le moment ;)


LGTM


I do have a test case! I just implemented the new automated test tools, so the testcase file name is just signals rather than signals.script. Could you please regrade my hw3 again?


I don't know why you did this but sure man whatever man


Should "You" be changed to whatever is actually receiving the params? Web server, web app, controller... etc


comment


Petit soucis : le cadavre de Corki reste sur place après la commande despawn, je ne trouve pas comment faire disparaître le cadavre (j'ai cherché dans les flags).
![wowscrnshot_031115_235725](https://cloud.githubusercontent.com/assets/4172776/6609072/a7b61478-c84d-11e4-8977-42c315fb3f89.jpg)


A number low enough to get those thinking about slow queries understanding what we consider 'slow' would be good (300 ms? Maybe that's too low?  Somewhere in 1-2s range maybe?).   I think it will depend on the use case, which is why I think percentile-triggered logging would also be nice since I think some users will be interested in outliers.


Can you explain why you added `-e`?


Workaround for issue #57


Wow Tino... seeing a lot of no changes here.. tsk tsk tsk.


It should not be, OD_QM4 was not used before. This commit does change the meaning of OD_DISABLE_QM:
- before:
always set to 0, 1 is meaningless
- after:
0 optimizes for PSNR, 1 is the previous behavior.

This is why a patchset is confusing.


Looks like this got into the repo by accident. Not an image file.


I believe we want:

```ruby
if Rails.env.test?
  # In memory
elsif Rails.env.development?
  # Filestore
else
  # S3
end
```


Maybe we will break these into model specs. I'm starting to realize if we have these here, the model spec files will be very small.


Amend https://github.com/ndlib/sipity/blob/d6b055cf283e17335ccbad6d737112f3a74d2862/config/initializers/figaro.rb to include requirements for the given keys.


you are amazing


When I did this earlier I cloned master, not grails 2.4 branch. But I created the pull request branch against the "grails 2.4" branch.

Anyways, I now notice that MichaelSullivan has a pending pull request that fixes the exact same thing. So, lets squash my pull request please.


Do you think there would be any desire to want to programmatically turn slow query logging on and off?  The way it works now, you would have to recreate your cluster instance.  I like it the way it currently is but thought I'd bring that up for discussion.


See my comments to #159.  I think we should deprecate this commit, and rewrite `plist-get-value` after the manner described in that issue.

This will mean breaking some configurations that rely on this magical comma behavior, so I'm OK with keeping it but leaving it undocumented, so that we are free to remove if it we choose in the future.  It will be an "implementation detail", whereas the scheme describe in #159 is the canonical and documented approach to dynamism in property values.


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2092 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.79%25-yellow.svg)


Go with Figaro method names that reflect the configuration option and purpose:

```ruby
datastore :s3,
  bucket_name: Figaro.env.dragonfly_s3_bucket_name,
  access_key_id: Figaro.env.dragonfly_s3_access_key_id,
  secret_access_key: Figaro.env.dragonfly_s3_secret_access_key,
  root_path: Figaro.env.dragonfly_s3_root_path
```


One thing to be aware of here is that when storing data in buckets/blocks of a certain size, you can only delete whole blocks. If you have a block size of 10000 then you can only delete the chunks `[0, 9999]`, `[10000, 19999]`, `[20000, 29999]`, etc.

Since you're using `<= offset` here, calling `writer.clear_key_before('foo', 20000)` is actually deleting all data up to and including timestamp 29999 (offset 2).

I've thought about this some more and I think `clear_key_after` should be inclusive of the specified timestamp, while `clear_key_before` should not. To summarize:

- `clear_key_after(key, timestamp)` clears `[timestamp, infinity)`
- `clear_key_before(key, timestamp)` clears `[0, timestamp)`

The only change necessary is to have the writer decrement the `offset` by 1 (only if it's greater than zero) in `clear_key_before`.

The tests should be picking this up. Can you update the block size in the tests? It should be 10000 if you're testing timestamps like 10000, 20000, 30000. You should also then add some tests for timestamps between block boundaries, e.g. 15000, 25000, 29999, etc.


+1 :+1:


yeah, lot's of 'no changes' here...hmmm. j/k


// Fetch the latest snapshot of the project and get an analysis summary for any changes made since the break mode was entered


LGTM!, thanks a lot for putting all this together.


Gah, we should just kill this page, it doesn't have anything that isn't covered in the guides for [Mac OS X](http://www.mono-project.com/docs/compiling-mono/mac/),
[Linux](http://www.mono-project.com/docs/compiling-mono/linux/) and
[Windows](http://www.mono-project.com/docs/compiling-mono/windows/) anyway and building with monolite is described in the mono [README](https://github.com/mono/mono#if-you-dont-have-a-working-mono-installation) as well.

Thoughts?


@tolbertam If you mean via JMX invocation eventually, then yes, that would be extremely useful. In other words, I would use this with clients daily if it could be invoked at runtime w/o bouncing an app process.


Nice work, Tino!  Interesting thought, DJ.


Hi @jni
This is a short code that ilustrates my problem, I just try to identify the line with highest coeficient of variation (CV), based on image intensity values.

>>>img = io.imread('/home/jaimebayes/Pictures/Satelite/san_diego1.png')
>>>rows, cols = img.shape[0],img.shape[1]
>>>val = -np.inf
>>>pts = []
>>>#profile line just by rows, in this case
>>>for  i in range(rows):
>>>    arr = profile_line(img[0], (i, 0), (i, cols-1))
>>>    t = np.std(arr) / np.mean(arr)
>>>    if t > val:
>>>        val = t
>>>        pts = [i,0,i,cols-1]

I don't know why arr list, has those zeros there:
[ 59.  70.  44.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.
   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.
   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.
   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.
   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.
   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.
   0.   0.   0.   0.   0.   0.   0.   0.   0.   0.]

Next issue, I will post in mailing list.
Hope this helps, Thanks Juan @jni


yeah


nice cats!


@tdenniston To escape special characters.

http://ss64.com/bash/echo.html

Or is it better to remove?


Why the square brackets?


PRs: Yes, I was planning to create a PR, from `master` (I have no other changes I intend to make soon). In fact, I will (probably?) still need to create a branch from your last commit, cherry pick this rev, and PR from it. A simple PR gets all of my other static-lib crap.

I agree with your suggested changes. It would be tempting to get rid of `MC_HN_APPLINK` altogether, but the compatibility reason is sufficient. I will probably stop using it and just use `MC_HN_LINK`.

However: Are you sure you wouldn't prefer something like `MC_HN_BEFORENAVIGATION`? It's more descriptive and matches the internal message. (I don't have a strong feeling either way. I just thought about using it when I was writing the code earlier.)

I'll submit a PR tomorrow.


to ignore space OR star


The following change is made to dereferenceCollection(). This is the same as what already exists in dereferenceEntityJoin(): https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/hql/internal/ast/tree/DotNode.java#L487


4551-More_F90_Cleanups (mmatts) - i386-Windows-7-VisualStudio-12: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Your ``thiscommit`` downloads a new boot image but doesn't get the latest git code. This doesn't seem like something we should encourage.

Also, boot images should have version numbers.


Maybe I missed this before, but is `:id` actually going to be in the term params, given that they're `params[:term]`?  (Even if they change from being under `params[:term]`, they won't ever be top-level, right?)


Yes, but more needs to be put in place. Such as an extension of the
continuous effect system.
On 11 Mar 2015 23:56, "ShawnieBoy" <notifications@github.com> wrote:

> Would this enable reducing the cost of other cards? Not only
> self-adjusting cards like Affinity?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/magarena/magarena/commit/c4342f4c01e1fae8c0167e7840d811626fd9bd47#commitcomment-10145644>
> .
>


Yep, this looks correct! :)


Oh... I thought the intention was to ignore any number of spaces. Guess I was wrong.


additionalSlinkyGHXWork (mmatts) - i386-Windows-7-VisualStudio-12: OK (1643 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


@zznate I was thinking of an API call, but JMX sounds even better for turning it on and off in production.  The ability to change the threshold for which it logs would be great too.


@Montellese you mean change to use a function getcodechars or a function iscodechar?


Oh, except, there's no good reason to have a standalone `ArrayShuffle` class with an instance method like this.  To call this method you'd have to do this (for example):

```ruby
ArrayShuffle.new.shuffle([10, 20, 30, 40])
```

Any of the following would be more humane interfaces for anyone using this code:

```ruby
ArrayShuffle.shuffle([10, 20, 30, 40])
shuffle([10, 20, 30, 40])
[10, 20, 30, 40].shuffle
```


Well it actually allows for values other than zero. Got another name in mind XD ?


Evo - simple je, copy i promijeni.

	// briefing
	player createDiaryRecord ["Diary",["Logistics","Our sympathizers have smuggled some of Russian AT weaponry to the Castle."]];
	player createDiaryRecord ["Diary",["Execution","Try to setup ambush flank and rear security due to constant enemy patrols wondering around."]];
	player createDiaryRecord ["Diary",["Mission","Ambush the enemy artillery column travelling from Solnichniy to Elektrozavodsk and escape."]];
	player createDiaryRecord ["Diary",["Situation","Enemy forces around Elektrozavodsk: Elements of Russian infantry company."]];
	player createDiaryRecord ["Diary",["Situation","Friendly forces: 2 squads of infantry."]];
	player createDiaryRecord ["Diary",["Situation","Chernarus Republic is occupied by armed forces of Russian Federation. A handful of rebels are trying to do as much damage as possible to the enemy and recruit some new faces along the way."]];


h


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Just a couple of parens, for a 2% boost.


ah ok cool. dont have another name in mind.


:+1: updated!


Yep, `MC_HN_BEFORENAVIGATION` is even better name.


Is it normal that the Dedicated Server Essentials mod of tyrsis doesn't show up in your release?


Just noticed the [recent comment](https://datastax-oss.atlassian.net/browse/JAVA-561?focusedCommentId=20934&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-20934) from @pcmanus regarding configuring speculative retry with percentiles.  If the driver ends up implementing that and tracking request percentiles for speculative retry, it would be a 'nice to have' to support percentile configuration here as well (if not in 2.0.10 then later :smile: ).


Added 2 spaces


Okay.


@ntdb Any objections to me pushing the latest version to production? I've been keeping staging up to date, and haven't noticed any problems.


For example with the color class (since it's not hidden behind macros):
https://github.com/b4n/overview-plugin/blob/7609a30ddd7455d0f0f012fd89aacdc755e02437/overview/overviewcolor.c#L295

I'm assuming that G_GNUC macro expands to `const` attribute here:
https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html


O_O :hand:


Let's also add an assert so that you can't have `imageModificationBlock`s and `stretchable` since that doesn't make any sense.


seems ok to me


Interesting, may I know where did you get an idea about that?


Then do the proper translations. Your 2 lines of that broke building.

1) Either do a proper translations that won't break building

or

2) Remove the strings.xml altogether since cm doesn't have strings.xml in pt-rBR


In the kde edition the theming files are copied to the /root directory too, but QT_STYLE_OVERRIDE=gtk its a solution too.


So... if I may be so bold as to ask, what feature of PHP are you using here that requires a version released  a month ago? This seems like it's going to cause headaches in lots of people's environments.

Is this version truly required? The only thing I see in the release notes for this version that seems like it could be relevant is a bugfix change in open-ssl to make certificate matching not be case-sensitive (though you don't list open-ssl in your dependencies, I suspect you actually do require it).


rax retry tests


Awesome, I'll push my commonjs stuff up next time the developers make a release (unless they merge it here!)


t.mux.Unlock() and defer t.mux.Unlock() get called at the same time, however I find calling unlock after updating the object increases the readability.


@julianlam handleACPRedirect is missing a return true/false


I find this part incorrect (for motivations, check here: http://www.example42.com/2014/10/29/reusability-features-every-module-should-have/ ).
I'd suggest to outline pros and cons of the alternatives.
(And frankly, defining the templates override an anti-pattern is quite excessive. I'd rather say the opposite, in certain cases)


hahah that's what I get for trying to fix a bug for you :P


add comment
add add


the incompatibility is with 1.1 to 1.2, so i'd much rather use my existing regex patterns and simply do -eq 1 and -eq 1 (SPK_REV won't matter with respect to the upgrade)


This line 91 is causing a compiler error for us because there is no "mtk_removeAllObservationsForOwner:owner keyPath:keyPath" method.  Shouldn't this call be replaced with "mtk_removeObservationsForOwner:owner keyPath:keyPath"?


Oops good catch the mutex unlock should actually happen outside of the curly brackets :scream:
```
func (t *tracker) IsChildNodeInitialized(instKey string, childkey string) bool {
	var exist bool
	t.mux.Lock()
	if _, instance_exist := t.Cached.Instances[instKey]; instance_exist {
		tailNode := t.Cached.Instances[instKey]
		if _, childNode_exist := tailNode[childkey]; childNode_exist {
			exist = childNode_exist
		}
	}
	t.mux.Unlock()
	runtime.Gosched()
	return exist
}
```


> For example with the color class (since it's not hidden behind macros)

How is it not constant?  Assuming `g_boxed_type_register_static()` does not return `0` first then something else, this will always return the same value (as `type` is static): either `g_boxed_type_register_static()` constantly returns 0, so this function will as well, or it didn't return 0 the first time, so it'll just return `type` itself next times.


Hmm. To me, `defer`ing the `Unlock` to right after the `Lock` call would clearly mean "Make sure this is unlocked when we're done", which seems more like the intended behaviour here.  We don't really need to do anything after the unlock (which would be where the readability comes in - it would mean having an explicit unlock is a signal that there's something unusual going on.)

I don't feel that strongly about it, though :)


@mrmarkfrench I bumped up the version due to some build failures on TravisCI. I'm investigating why and will bump it back up whenever I fix the issue :smile:.


additionalSlinkyGHXWork (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Modified the tests to look for just the monitoring pods.


I added the `#ifdef __linux__` here as a courtesy to the O3X project to avoid a build failure when they merge this should this be merged into ZoL HEAD.


Agreed.  It'd be nice to support tintColor, though…


Ok, lets do it.


DEATH TO :pushpin::gun:


4551-More_F90_Cleanups (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1655 of 1655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


For the future, I'm wondering if there is a way we can export with JSON and then read the JSON with JS. Generating JS like this makes my security-spidey-sense tingle.

e.g. would much prefer something like:

<template id="disqus-json">
  {{ json_encode(['title' => "{$post[0]->post_title} - Compass Bible Church", 'url' => '...', 'shortname' => 'compasshb']); }}
</template>
<script>
  var disqus_options = JSON.parse(document.querySelector('#disqus-options').innerHTML);
  var disqus_shortname = disqus_options.shortname;
  var disqus_url = disqus_options.url;
  var disqus_title = disqus_options.title;
  // ...
</script>


additionalSlinkyGHXWork (mmatts) - x86_64-MacOS-10.9-clang: OK (1636 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.21%25-yellow.svg)


xd


Updated!


don't forget to scp this pyrepo


Typo. Should be "Lauder" not "Laurder"


Grazie.


Mind sending this to the main repo as a PR if it is working?  I had to do this to an older project but never got around to fixing it in Archetype.


you mean change the url as a setting parament?
1. I don't known where is the better place to save this configuration. It's not about keyboard layout.
2. may be the data structure change as well when url changed. so need change code not just url.
3. I think the better way is change codingtable as addon. can update alone. may be support codingtable in first step. and change as addon the next.


ok


Can this be set up with the laravel dependency injector and injected instead of instantiated here?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12634/testReport/) for this commit**


Is it possible to inject the Song repository via the controller method instead of using static access?

Same q with `view`


Turns out you can't match against `Iterable` of a specific type.  Because of type erasure, any collection with any type will match.  That's the reason the original logic was written in such a funny way, which I've restored.  See the unit test below that fails if you match `Iterable[PipelineStep]`

@jakemannix


@ntdb No objections! I've only made small, test-driven changes this week and don't expect anything to blow up.


This should really be `request.details`.


the application id is still present in the appengine-web.xml file, check if it can be changed to a generic name other than the project id of the console project


You're right, my testing was pointless since that code path is never taken with my browser versions.


sweet factory girl!


hot config file!


Since this is a list, should probably use `<ul>` and `<li>`.


I hope that database cleaner just works haha. I really don't want to have to figure it out.


Thanks right @pugiemonn ! I have no clue how it happened!


This might be better off as a utility method not tied to Haar?


This patch hunk is very heavy handed - this code will run *every time* ipython evaluates a line/expression.

`_scan_id` is changed in exactly one place in the code base. If the problem really is due to multiple sessions being active, let's address that. At the very least, we need to know the mechanism of scan_id mis-steps.


i dont know what happend to my revel ,for yesterday it shows well ,but today the computer said it can not read the commond of revel .i tried to download agin of revel from github ,not use the commend of "go get",because the google is block .so i tried to replace of the version of revel .and restart my computer again.but it fails agin


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1650 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Just noticed that I should have an `else` clause that raises an exception here.


updated Citadel, what issue is addressed in the new version?

On Tue, Mar 10, 2015 at 9:54 PM rourke750 <notifications@github.com> wrote:

> yes as well as namelayer.
>
> On Tue, Mar 10, 2015 at 10:52 PM, ttk2 <notifications@github.com> wrote:
>
> > so should I grab a new jar for Civtest?
> >
> > On Tue, Mar 10, 2015 at 7:18 PM erocs <notifications@github.com> wrote:
> >
> > > Does look better.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/Civcraft/Citadel/commit/64bcd273a380ee415167e3c4522bf1ced3a23065#commitcomment-10132544
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Civcraft/Citadel/commit/64bcd273a380ee415167e3c4522bf1ced3a23065#commitcomment-10134157
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Civcraft/Citadel/commit/64bcd273a380ee415167e3c4522bf1ced3a23065#commitcomment-10134173>
> .
>


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2091 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.74%25-yellow.svg)


:heart:


So, I like to define things that I treat as constants in the body of a file as constants at the top - partly to avoid misspelling, and partly so that if someone else uses that constant variable, and I change its value, they're still cool. If it were C, I might expose them... typedef enum, perhaps. I'm going to keep the caps variables, and accept the other changes with edits. I'll hit it at the weekend - thank you for the work.


Don't worry. @amritb is a friend of pugiemonn.com.


Hi Brian,

It doesn't need 8,  4 to 6 works, but 8 doesn't hurt and may catch any
strange new directory structures in the future. It stops when it finds the
source file.

I'd appreciate some credit on working this out.

Btw - is Aerospike still limiting bin names to 14 characters ? It seemed
when I looked at the code I saw 128 as a max size of most everything. I
couldn't find code limiting bins to 14. At least 24 or 32 would be helpful
- 14 seems to be too limiting.

Bert

On Tue, Mar 10, 2015 at 5:07 PM, Brian Nichols <notifications@github.com>
wrote:

> 8 directory levels? Yikes. I will take your word for it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bertbeck/aerospike-client-csharp/commit/c90de2790007e904d6ee7fea3fc9ff24841a1631#commitcomment-10131761>
> .
>


I see - let's add to the list to ask @pieper


Depois de subir a atualizaçao, na tela de sincronizar as categorias, não conseguia ver as categorias do MercadoLivre, e também não conseguia fazer Login. Voltei as alteraçoes o modulo voltou a funcionar como antes.


That works too.


@paulirish
Do you know why the Mobile Safari removed the Cancel button“(×)” ?


Why did this change?


이거 없으면 썸네일 왕창 커져서 layout 깨짐 ㅠㅠ 수정 부탁..


:shipit:


@tmcdonell What was the reason for making the handling of events explicit? I changed it back so that events are automatically garbage collected and it didn't seem to break anything. Was it just for performance reasons or is there some sort of race condition I'm missing?


마스터에 수정되어있어 ㅋㅋ


요거는 statuses_path 대신 request.referrer 같은 걸 쓰는게 어떨까?

예를 들어 daily view 보다가 back 버튼 누르면 daily view로 다시 돌아가야 할 테니까 (지금은 무조건 statuses로 감)


Probably don't want to eat this error and continue here. I would just remove this try/catch and make the method throw `Exception` so the errors bubble up.


What in Heaven's name?


See
Thanks for your direction

2015-03-10 1:15 GMT+08:00 Jim Huang <notifications@github.com>:

> Please improve your English expression.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HahaSula/arm-lecture/commit/cdfbf51ebd8c204e75e9ab4c5b6fe41853991661#commitcomment-10104448>
> .
>


merge나 rebase하면서 그럼 conflict 나겠네? 여기서 고치는 것이 맞지 않은지?


1.在布局文件中 使用控件
<com.huangying.leftmoveview.MoveView
        android:id="@+id/mv"
        android:layout_width="match_parent"
        android:layout_height="200dp"
        android:layout_centerHorizontal="true"
        android:layout_centerVertical="true"
        android:background="@android:color/white" />
2.在代码中 给这个控件添加任意布局
ImageView iv = new ImageView(MainActivity.this);
iv.setImageResource(imgs.get(position));
moveView.addView(iv);

3.有问题 email to hy_ying11@163.com


Yay!


develop (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


develop (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1143 of 1143 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can you add test cases for the negative cases (i.e. when the union contains both 2 maps or 2 arrays)?


HelloWorld.md ## This is a markdown file


this hurts me, i don't feel well. so many errors?!


shouldn't this be continue instead of return? Will all type be processed? Add unit tests.


@mad100141 Sorry I didn't explain earlier :) This file right here is a result of how *awesome* the arara team is :) http://en.wikipedia.org/wiki/Norfolk_dialect


就这句话来说, 翻译为:
```
FilterDecl 删除所有未通过过滤器 f 的名称所在的 Go 声明 (包括结构体字段名和接口方法名) 来缩减 AST.
```
可能好一点, 其实不是统一的问题, 是翻译水平问题, 语言有差异,
就像这句话, 当时就是找不到通顺的中文表达方法.


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1650 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


이 라인은 왜? 아래 코드 있으면 이 줄은 없어도 충분하지 않은지?


Huh?

I'm not sure why anyone would have told you this. MSDN shows these classes as having these interfaces, and if you look at the actual classes in the .NET DLLs, they have these interfaces.


Makes sense.

I think that markers make more sense than polygons (from a usability point of view). It's unfortunate that the data doesn't allow for accurate points to be derived.


Works OK on Debian 7.6 and FreeBSD 10.0, but I agree that OS X definitely needs testing.


Good stuff.  Those true and false aren't even necessary.  You could just write

```ruby
def completed?
  completed_on != nil
end
```


DragNDropBCLHVAC (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


HumidifierSizing_#4688 (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1640 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.21%25-yellow.svg)


All this looks great.  It's definitely time to get your text editor indenting properly, though. :wink:


:smile:


Don't add the generated files such as ` lab-1/fibseq` in GIT repository. Please set `.gitignore` properly.


Please improve your English expression.


@vermiculus I'm looking at the errors. I can't see anything other than errors. ERROR!


you forgot assert. Im not sure what its testing, if any


That's good! You are eliminating the unnecessary usage of instruction `bx`.


Please follow the consistent coding style.


When_Function_is_annotated_then_its_OdcmObject_and_Parameters_have_Description_set() ?


Good for practice!
Don't leave the dead code.


This all looks quite good @ronaldonagata.


s/close/closed/


a este codigo hay que borrarle desde la lines 8 a la 11 para que corrar como deviera ya que al hacer los cambios se quedo esta parte del codigo


Hi, thanks for some of the clarifications - I've been working on getting started with your bundle in the past day, but have been running into some issues figuring out how the 'match' method was changed and this clarifies that.  - However, I've been unable to figure out how to apply a Limit or OrderBy function - can you describe how that works?

Thanks! - and if this would be better posted elsewhere, please let me know.


Can you validate the correctness as well? I meant, can you implement a flexible way to verify the implementation every time when you modify.


GridViewBugFixes (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This route shouldn't be necessary -- it's taken care of by `resources :items`


Just reviewed the codes.
What about to try to refactor the method Token::typeToString($type) ?
I guess to use reflection is better.


@evanweaver @kbenne this is a little fishy looking :fishing_pole_and_fish:


Is there a base class where we could put the description?


I think it would be cleaner to make a new "levels" or "tags" model that has a relationship to the books model, and then seed this data into the database

This way, you can just call helpers from the new model to do all of this logic for you


I will fix this lol, a tab -> space problem


Good stuff.

Since the `completed_on != nil` returns true or false, you could rewrite this as

```ruby
def completed?
  completed_on != nil
end
```


Great work @raphaelzin :+1:


Doesn't this need to be outside of the if statement? Otherwise it does not work for my environment.


Sorry, what? I have no idea how the two are related...


For your information, I only modified this function. Didn't create it.


Nice one :+1:


develop (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2165 of 2184 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13%25-yellow.svg)


Consider generating a random file name here. We'd like to enable the tests to run in parallel at some point, and this will be a contended resource.


This comment should be updated to talk about `underT` instead of `under`.  Maybe also add a note referring the reader to the functions `transformed` etc.


`puts` is pretty unreliable in Rails.  If you want to log stuff you can use the Rails logger, e.g.

`logger.debug "Get an image!"`

Here's more info: http://guides.rubyonrails.org/debugging_rails_applications.html#log-levels


ICSSolarCollector_#4723 (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1652 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


develop (DavidGoldwasser) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


HI,
     [self.session removeObserver:self forKeyPath:sessionVolumeKeyPath];
will cause crash, if the following is never been called:
    // Observe outputVolume
    [self.session addObserver:self
                   forKeyPath:sessionVolumeKeyPath
                      options:(NSKeyValueObservingOptionOld | NSKeyValueObservingOptionNew)
                      context:sessionContext];


s/invertable/invertible/ (here and elsewhere)


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (637 of 637 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.19%25-green.svg)


This should be a separate file


Should this behavior be a config flag on CodeGenTestBase?


s/boxEnvelope/rectEnvelope/


Good stuff with the guard clause.  I always find `unless !` pretty mind-bendy to reason about.  It might easier to decipher as

```ruby
@item.get_image if @item.image_url.nil?
```


Hi,

The value for key "WMAgent_JobID" cannot be NoneType.  I think Line 1121 is also wrong.

Brian


I am not sure how this pull went unchecked for so long, apologies.... This is a touchy subject because this was only changed in 2.8.0 which many of the repo's don't push (URGH). Changing it here will cause older ModSecurity versions to bork if they load experimental rules. What we have been doing in general is moving 2.8+ stuff to the 3.0.0 branches (stuff like @detectXSS).


VSHPWH (shenb) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Great work overall on this @nicguy59 -- especially digging into Gems.


Is there any way to replace the url to https://u.f-q.me/watch?v=IpRzDu1Seqk ?


LGTM


have_the_right... ?


Ugh.  I guess Sync will depend on Storage long term, so 0fg.


If you're certain.


this is the fork/commit to fork/submit pull request method.


They aren't, I was thinking your PR was for https://github.com/neovim/neovim/blob/master/scripts/legacy2luatest.pl. I'll fix it when I push this.


+1 `npm ls --level=0` displays:
```
npm ERR! missing: wreck@5.x.x, required by subtext@1.0.2
```


Solved this problem?
```
Process disconnected from parent !
Error: channel closed
    at process.target.send (child_process.js:414:26)
    at SyncWriteStream.write (/usr/local/lib/node_modules/pm2/lib/ProcessContainer.js:125:17)
    at Console.warn (console.js:63:16)
    at ipcSend (/usr/local/lib/node_modules/pm2/node_modules/pmx/lib/utils/transport.js:23:13)
    at Object.Transport.send (/usr/local/lib/node_modules/pm2/node_modules/pmx/lib/utils/transport.js:32:3)
    at null.<anonymous> (/usr/local/lib/node_modules/pm2/node_modules/pmx/lib/Probe.js:32:17)
    at wrapper [as _onTimeout] (timers.js:265:14)
    at Timer.listOnTimeout (timers.js:110:15)
Channel is already closed can't broadcast error:
Error: channel closed
    at process.target.send (child_process.js:414:26)
    at process.uncaughtListener (/usr/local/lib/node_modules/pm2/lib/ProcessContainer.js:158:17)
    at process.emit (events.js:107:17)
    at process._fatalException (node.js:236:26)
    at process.emit (events.js:107:17)
    at process.target.send (child_process.js:414:12)
    at SyncWriteStream.write (/usr/local/lib/node_modules/pm2/lib/ProcessContainer.js:125:17)
    at Console.warn (console.js:63:16)
    at ipcSend (/usr/local/lib/node_modules/pm2/node_modules/pmx/lib/utils/transport.js:23:13)
    at Object.Transport.send (/usr/local/lib/node_modules/pm2/node_modules/pmx/lib/utils/transport.js:32:3)
    at null.<anonymous> (/usr/local/lib/node_modules/pm2/node_modules/pmx/lib/Probe.js:32:17)

```


Agreed - you should not depend on a file's content for a model to behave properly (and almost certainly not the location of the file). If all the `tagtypes` are `'levels'` is there a DRYer way to do it? Will there be other tagtypes in the future?

Better, can you give us a use-case or a sample input / output for this function? Its purpose is still very unclear to me.


@Sliim this number is just big enough to hold any possible candidates, helm itself also uses this number, see https://github.com/emacs-helm/helm/search?utf8=%E2%9C%93&q=candidate-number-limit , so I think It's ok to hardcode it.


@sara-liu this makes sense, every time you cross through the portlet the Configuration Object needs to be set.


this should probably be `if @warranty.save! then do things` instead of `@warranty.save!` then `if @warranty.save`. I don't think you'll get the effect you want doing it this way ;)


Good stuff.  Since `completed_on == nil` is giving you a true/false back you could rewrite this into a single line method...

```ruby
def completed?
  !completed_on == nil
end
```

Or, even better:

```ruby
def completed?
  !completed_on.nil?
end
```


Yes, it's from scipy.
http://en.wikipedia.org/wiki/Pearson_product-moment_correlation_coefficient
I'm calling pearson on a list of pixel lightnesses. This is the heart of the image detection. My threshold magic number is the tolerance for error (which *should* be exposed)


This worked!  I uncommented it and got an image...


Great job @deazeredo -- nice clean git commits, too.  :+1:


we might want to add this in a private function `def set_contacts` use a `before_action :set_contacts, only: [:contact]` that way we can get in the habit of just adding to the before action instead of setting the contact in every function.  something i need to do better too.


Ah. It stopped passing for me, don't know why.  I removed it for 4 reasons:
1) I did not want to debug it
2) merging is not done in the atomtable any more, so the test really does not belong here, anyway
3) there is recent work on functions that compute truth values,
4) the right thing to do would be to extend the TVMergeUTest

If you think the above code was valid .. then please copy it into TVMergeUTest (and make sure it really is workingg correctly.


I don't think so, this commit concerns only stop/restart issues.
`channel closed` error can happen anytime you try to communicate with a worker which is dead/disconnected (IPC terminated between the worker and the master).
You can workaround it though by checking if (worker.state !== 'disconnected').
I'm gonna inspect this on pmx tomorrow.
It's 5a.m here in France. Good night :)


HumidifierSizing_#4688 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Oops. I meant Fixes #2.


i _think_ you can do `if @contact = Contact.create(contact_params)` and go from there if you want to minimize this code.


all this is bad, don't like how i did it, should think about the best way to set other things in controllers that aren't associated with them.


this whole model is nasty, we need to clean this up. too hard to see whats going on and error handling is pretty bad.


Be careful with naming stuff just `p` in Ruby -- it's actually a shorthand for `puts` -- so you could get some weird behaviour...


Nice catch.


ICSSolarCollector_#4723 (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Was trying to add symlinks to the real files, I just thought it would be "nice" to have the pointers in the template directory for editing purposes. They're not required.


Nice work getting it into one line.

Even simpler would be

```ruby
def completed?
  !completed_on.nil?
end
```


whoops, i think we are supposed to pluralize the controllers as you did. i have not been doing this, should probably go back and change all my controller names


I think wanting to export as separate tables may actually be common enough: when there's a report or something with multiple interesting tables. It's not a must-have, for sure. But it'd be kind of nice.


Sure thing; there's a lot I don't know about packaging... consider this my learning exercise.


The main motivation behind using a yaml file is that it will be much easier for worldreader's admins to make changes/updates to the level tags using this file than by making changes to their database.
Not all the tagtypes are levels just the ones creating using this file. I suppose it could be a little DRYer to set the `tagType` after the yaml is loaded, but we would lose explicitness.

What this pull request is meant to do is internally map tags for levels.
Example: When a partner searches for books with the tag "Primary 1", then it should return all books that contain the "A" level, "Pre-Primary, Primary 1 (Ghana)" level, "Standard 1 (Kenya Primary)" level, and the "Standard 1 (Tanzania)" level, which are how we store the labels in the database.


Good job on this one @Racinettee -- :+1:


@jurodriguez este query sirve para filtrar la lista mientras tecleas - será buena idea quitarlo?


Good night - -


I'll adjust the CSS; I am of the opinion that semantic HTML should use header tags when possible instead of "meaningless" span tags.


why the hell is there a suspect ladder to begin with


Sure thing.


not sure the best way to this as i've said a billion times. my first though would be that in `warranties#create` you would do a contact.new or something without having to specify a different route and method. would imagine all of those params would come in together but once again not sure, especially when we integrate _wizzzzaarrrrds_


`test`


I think we want to use Pascal casing here.  Maybe ProcessEnvironment, Registy and RegistryLevel2?  What do you think @stephentoub?


This errors out if `result` is nil.  One thing you can use is Ruby's `try` method: `result.try(:id)`

Overall, nice work on this method (and the controller).


You're right I should have looked at this more carefully. I'll push an update tonight.


just an unrelated note. It would help for easy reading if the commit message text width is set to 72. especially headline.
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html


Good work on this.


Note (to myself): Parameter wasn't used anywhere, but might be handy to have a way to bypass the check.
Probably doesn't hurt to keep this, but I'll remove this for now and might bring it back later.


Thanks.


Note (to myself): Looks like a smart thing to do since there's no reason to keep track of the $exists array outside of this method. Also the $exists variable wasn't passed as reference anyway so it didn't solve the purpose it was probably introduced in the first place (this is a leftover from Mage_Cron). Only draw back is the now multiple db queries will be made which is probably neglect-able for the low number of schedules.


ジャムふぁいとぉ。ω。
うにｔｙ教えてね・ω・


Note (to myself): Good move to extract that into a separate function in order to keep the methods smaller.


It's pretty rare in Rails to need to spell out routes like this.  `resources` will cover 90% of cases.


놀랍게도 그 줄이 없으면 `#edit`에서 새로고침하면 작동하지 않는다네 친구.
그리고 아랫줄이 없으면 `#index`에서 `#edit`로 넘어갔을 때 작동하지 않더군.. 결국 둘 다 필요함


this shouldn't be necessary?


No entendí muy bien esta parte hablas de sacar todo en el div *menu*


:thumbsup:


오 좋은 생각이군 (request.referrer같은게 있는줄 몰랐음)


All that was missing from this was looking up the related project (e.g. `@project = Project.find(params[:project_id])`).  The rest is great.


Err, nope. It shouldn't. Why did I put that there. Will check it out.


Si, olvide removerlo de `GAME_UI_COMPONENTS.`


그렇게 해봤더니, 문제는 `#edit`에서 새로고침했을 때는 back을 해도 자기 자신에게 간다는 건데. 이건 예외처리를 해야겠다.


これどうなん？


こうかも


primer commit desde github


Fixed.


HumidifierSizing_#4688 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1641 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


Sucede que el método que carga las categorías se encuentra en el `init` lo que hice fue sacarlo y ponerlo en fuera, de esa manera solo cargara una vez.


@shimshon70 ClearKey support is already present in the development branch.  At the bottom of the index.html streams list, there are some example CommonEncryption files that use ClearKey.  However, the EME spec has been updated to further standardize the ClearKey initialization data format.  Chrome 41+ only supports this new version of ClearKey.  dash.js and the sample content will now have to be updated to support Chrome at this EME API level.


oops :)


Revisé tus comentarios tengo algunas dudas en unas cuantas. Comentaré las lineas para revisarlo.


@echiou @varunrau @SamLau95
I think sam will add more input, but could you consider adding a separate page in the UI for the administrators so that they could edit the tags there?


Formatting changes


created new cs file


@littleguy77, this commit should fix some problems you had. Could you give a try? :)


Arguably it'd be even easier for the admins to make changes/updates on the app itself rather than having to dig through the app files (on a production server? or on development, then deploy to production? either of these cases seems like a pain) to make changes.

If this functionality is part of a feature (eg. only used for search) and not part of the core model functionality then do you think it'd be better to put this mapping in a service object?


test


Slightly unrelated but the `self.query` method is quite a beast with ~30 LOC and it is not very clear what it's doing after some time staring at it.

I think after thinking about this problem some more there are two cases:
1. The mapping will never change. In which case, might as well leave the mapping as constants in the model / elsewhere, not in a .yml file.
2. The mapping will change. In which case, a model called something like `TagMapping` that maps a search tag to model tags is more appropriate which allows changes through a web interface.


By "but" i mean "bug". Also, can we or can't we delete createpost.html?


This was an existing code in Interop.Manual.cs. However let me know if you both feel so and I will change this accordingly.


We probably want it in md link form:
 * Join our Google Groups: [trace-viewer](https://groups.google.com/forum/#!forum/trace-viewer), [trace-viewer-bugs](https://groups.google.com/forum/#!forum/trace-viewer-bugs)


rubocop to the rescue!


q


HumidifierSizing_#4688 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (637 of 637 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.19%25-green.svg)


Could we do this in smaller steps instead of a single line like this?


90k as a hard limit assumes (correctly) that most players have 1000 as the default max stack of any item. It doesn't account for players with larger inventories, like say someone who has 10000 as their max stack size.


Should use ``nsIVersionComparator`` instead:

```javascript
var versionComparator = Components.classes["@mozilla.org/xpcom/version-comparator;1"]
    .getService(Components.interfaces.nsIVersionComparator);
versionComparator.compare("1.0", "1.0b4"); // 1
```


robot을 추가하셨군요. 잘 하셨어요. 원본 repository(imyaman/kkeun-ma-rit-gi)를 fork 하여 생성된 repository(cho881020/kkeun-ma-rit-gi)를 수정하신 다음엔 원본 repository를 관리하는 사람에게 알려주면 좋습니다. 내 repository에 변경사항이 있으니 갖고가(pull) 봐라(request)...라는 의미로 pull request를 보내는 거죠.

https://github.com/cho881020/kkeun-ma-rit-gi 이 화면에서 좌측에 녹색 버튼이 보일 겁니다. 그걸 누르면 pull request를 할 수 있어요.


Triggering this error doesn't seem to cause the `cordova plugin add` command to exit with a non-zero value.


cacheing -> caching


I think its fine to delete it. I don't see it referenced in url.py and it all exists in posts.html anyways.


Nice, will [rand-dom](https://www.npmjs.com/package/rand-dom) be useful for the upcoming things in `js-art`?


why the fuck not


Could we add some commenting to the class and this last method? It's not self-evident what `explode` means in this context


jk probs to see if Sneasel and Yanma really need banned


I would probably call it `paramsReduced` to avoid confusion.


Since this commit removes the comments with lines pointing to the paper, we should drop the last line of the comments for this class


this is inside lambda expression via Linq version of ForEach, return are actually same as continue on normal for-each. this is just return for this particular element. current UnitTest could already cover this path, but will add a few more explicitly for this case here.


same as above, this is inside lambda expression. will add a few more UT.


In this file there is an example for form encoded, json, form-data, form-data (files) but not for `text/plain`actually.


css change


// 包 ast 声明了用于描述 Go packages 语法树的类型.


[Finishes #90055178]


the error message is wrong, so I just fixed it. the message is saying element type so shall comes from ItemSchema.
it's not directly related to this, if you prefer I could remove this line here and leave to you to fix it in future as appropriate.


OK, didn't know they are symlinks (looks like a ordinary text from the diff). Leave them as-is if you want.


// 一个 non-nil FieldFilter f 可用来提供控制输出:
// 那些 f(fieldname, fieldvalue) 为 true 的结构体字段被打印, 其它被过滤掉.
// 非导出结构体字段决不被打印.


야 이게 쉬운 문제가 아니구나...왜지? 하고 찾아보니까 이유가 있네. Rails 4에 turbolink라는 기능이 추가됬는데, 이놈이 이런 짓을 하네..

 Instead of letting the browser recompile the JavaScript and CSS between each page change, it keeps the current page instance alive and replaces only the body (or parts of) and the title in the head

그래서

With Turbolinks pages will change without a full reload, so you can't rely on DOMContentLoaded or jQuery.ready() to trigger your code

로군. 헐...


Sure thing. I know how hard it can be sometimes to merge a pull request, even though I rarely get any, but I feel for the ones I submit mine to (which tend to become rather big at times :S, https://github.com/SublimeText/AAAPackageDev/pull/13). I will try to be more careful in the future.

I honestly like the indenting rules that flake8 (and pep8) suggest a lot and they align with what I consider to be readable code. Probably just personal preference or old habits from before. I'm genuinely curious which rules you don't like.

I still need to write a plugin that auto-indents according to these rules because the auto-indent-to-paren from ST is 1) broken in some cases and 2) doesn't cover other cases. I haven't searched for an existing one yet, but it certainly hasn't been added during the time I was handling package_control_channel.


toUserFriendlyString?


휘동 아래 코드와 같이 바꾸면 두 개를 한줄로 줄일 수 있기는 한데, 사실 본질적으로 같은 코드기도 하고 귀찮으면 굳이 고칠 필요까진 없을꺼같음 ㅎㅎ

$(document).on 'ready page:load', remove_status_photo


I've applied this patch - with a tweak - here:
https://github.com/web2project/web2project/commit/1e9b096ea10e570a05d7834aa4f2635781733168


@yui-knk Need to add `[ci skip]` for further commits :smile:


shanchu


Hit enter on commit before finishing comment.  Here's the rest of it:
*  Moved Navigation link next to Address (closes #12)
*  Add "software hyperlink" (closes #11)
*  Add Google+ link (closes #10)
*  Improved formatting on the Address Search form


dont understand why you're checking <0


なにこれ？


田渕のコメント


nishii


木元テスト


なんでこんなことしたの？


If we think it will be useful, let's do it

> On Mar 11, 2015, at 00:09, Jeremy B. Merrill <notifications@github.com> wrote:
>
> I think wanting to export as separate tables may actually be common enough: when there's a report or something with multiple interesting tables. It's not a must-have, for sure. But it'd be kind of nice.
>
> —
> Reply to this email directly or view it on GitHub.
>


なんで？


Docrails doesn't run on travis, so its is ok here.


Close #22


I'm leaving some comments here since I couldn't find you online again. I checked through your branch, most of it is good, but there are some weird commits I would prefer to be cleaned up. I'll either do it this week sometime, or you can. It's mostly the strange commits that are "make things compile" or "line up with etc etc". I think those may be merged funny.


Use parseFloat or parseInt() maybe?


Since you seem to like generating sentences, have you thought about experimenting with different sorting algorithms (Bubble sort, quicksort, etc) to do it for you? Here's a tutorial: https://www.youtube.com/watch?v=JAvIvLMsLpU.
That way you could work with the AI more and start to make your programs more sophisticated. This is a good start though.


I'm intrigued. Perhaps you could open a pull request (even if it's a work in progress) as I'd like your explanation of the benefits of this approach to live somewhere more permanent than a commit comment. :)


Uh oh -- the missing : after `only` stopped this from working...  I was able to get it running by adding it back in.


Oh, no. I was trying to include it "globally" at first to be shared between the different templates, but it didn't work out. Forgot to delete this one.

On that note, is there a way to get functions/etc to work? Even when defining it in the header.tpl, functions aren't available in e.g. series-index.tpl, but it seems like a waste to redefine these things over and over again.

Thoughts?


You started off well on this, especially the validations.


What about update and destroy?


dont return errors. throw them.


@JuanitoFatas , @vipulnsward sorry for my mistake :sob:


VSHPWH (shenb) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We don't need cache-container name="hibernate-search" any more?


@yui-knk no, I meant its ok. There is no issue here.


Thanks.  I'll definitely merge this in with my branch that needs to go out as soon as possible.


@vipulnsward   OK, thank you!


I hope to see more tests for update and delete


If you `install os`, you do not need to `install os.path`.


mistake


move this task up, next to the other `test.unit.*` tasks


This breaks PMA, which is owned by www-data:

     UID of script "/services/http/pma/www/index.php" is smaller than min_uid

Reverting for now; any thoughts on the best way to handle this? I guess we could add a "ocfpma" user or something, though the current solution (reverting) isn't horrible.