update_sqlite_library (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1620 of 1620 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ok


Hi,

In order to hook blockfacebook into the footer ? We need to develop template file for this and in original design of default theme, there is no reference of facebook in footer.

Best regards.


how is that different from e.g. operator precedence? we could simply define what takes priority (i'd say echecktype have more priority, so `a ? (b : c) : d`)


spravne - mozte zmazat riadok 475


These changes are independent from the declared feature of the commit.


Should this just be 'Experience'?


Even with this syntax that I hate and think we should dump, you can still name the action something like willShowWithState and willHideWithState which matches better the objc notation. Although I'd dump with "withState" as well since its certainly just a holdover from ObjC methods that don't have named parameters.


Thanks!


We should also probably support gzip in the header, adding at least
```html
Accept-Encoding: gzip
```
@atteroTheGreatest Is/will gzip be supported on Syncano?


Removal of this comment is independent from the declared feature of the commit.

Why would you want to delete this comment anyway?


not necessary I'd say :)


This broke boost::ptr_ list, which relied in using std::advance instead of operator+=:
http://www.boost.org/development/tests/develop/developer/ptr_container.html

I have created a pull request for ptr_container:
https://github.com/boostorg/ptr_container/pull/5


Not really blade sorry, It was a lapsus.


Whitespace addition shouldn't be included.


Nope, not sure how this got here.


probably unnecessary


This should probably a be a struct.


i wish we had chosen a double colon for echecktype `a :: Int`


Looks good to me


if you go as far as defensive copy, I'd also make it unmodifiable in case we think stacking several error handlers becomes a use case.


nitpick: will it be clear that "maximum allowed" means what the event tracking infrastructure can accommodate, as opposed to a limit enforced by the forums themselves?


I like the idea of passing an onComplete in, but for this specific case, I'd rather it be a boolean `stopAfterFading` or something.

I'd really rather prefer the function returned the tween, but I can manually tween the volume if I want something more custom instead.


If I understand correctly, the `onBeforeSendHeaders()` code in `traffic.js` is specific to Chromium, so I should be moving this code to `platform/chromium`, right?


`setTimeout` have a minimal time of 4ms. As promises are available why don't use they as a alternative `setImmediate`:

    (new Promise(function (resolve){
        resolve(value);
    })).then(callback);


that would be quite confusing, because `::` means namespace in c# or c++, and we are already using `:` for type-hinting things, so I think a single colon makes sense


@bogdanudrescu Could you remove the code from the demo and push again?


I don't like the double `ss` in the name.  I understand the desire, but I think it's unnatural.  If you absolutely insist on a plural, wouldn't the plural of `Wcs` be `Wcses`?

Should be no spaces around the `*` or the `=`.
Ditto on next line.


Hmm; the old tests were passing, and the tests you removed were indeed allowing multiple wildcard matches embedded in the string vs. just at the beginning or end.

I appreciate the tests you added, but I'd like to see the four tests you removed passing too.


I've never seen (or possibly never noticed) you using `@property` before? Have you taken a liking to it suddenly? Or just wanted to keep the same style you had when `Target` was a `namedtuple`?


AWESOME! Thank you for commenting, sorry I had to merge cause I was too silly to separate my two commits into different PRs :S


Fix #22.


Like I said you don't have carry connection/transaction everywhere.
A code similar to
https://github.com/fsprojects/FSharp.Data.SqlClient/blob/master/src/SqlClient.Samples/WebApi.Controllers/HomeController.fs#L18
can be encapsulated in command instance factory (like DatabaseContextScopeBuilder).
IOC can be appropriate.
Connection string can be read from any source.

I don't mean to disrespect your effort but I don't plan to add this functor ```unit -> SqlCommand```.
This is open source project. You can always fork and start building your own version.


update_sqlite_library (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1620 of 1620 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This whole thing should probably be in a helper class, but we can cross that bridge when we need it I guess. Just don't let someone else rewrite this again later :)


This is cool comment! :+1:


What's the difference between these and the ones you have on bitbucket?


Yep, you should have responded to [my last comment](https://github.com/mozilla/firefox-ios/pull/182#discussion_r25448463)! I don't see anything obviously better than this without creating an additional unnecessary abstraction layer.


Tricky!  So the rule is, don't use string formatting directly, let self.warning(), self.debug(), etc. do it internally (and thus only do it when required)?  That's very subtle.  A quick grep for ``[.]warning(.*%.*%`` finds lots of examples, but not so many we couldn't fix them.  And fixing them is as simple as replacing ``%(...)`` with ``,...``?


not sure, copied from the example project that I got the rest of the stuff from.  Seemed to do the error logger setup for gulp.  As I refine the gulp process I'll revisit.


So we never found nor found a plan for a better strategy to hook the state to the `Session` itself rather than a threadlocal, correct?


Could you not change this to: ``content: string, headers: StringTableRef = nil): Future[void] =``?


Good catch.


Whats the point of this property?


@Tvaroh yes you understand correctly now.

Note that using `atomically` with the state binding and `commit`ing only after the meta binding is `set` causes Morearty to evaluate `isBinding` two times. I'm not really sure what are the implications of this, just thought I'd point it out (maybe it's expected?).


sure, the only difference is the move entirely to the subdirectory of tasks and having no tasks defined up here.


this function can be used to verify and change serial number in bind DNS zonefile. It's not clear yet how i will use it.


Ok


> This should be fixed in: c3aa752

fixed


It should be supported now.
On Mar 2, 2015 6:41 PM, "Mariusz Wisniewski" <notifications@github.com>
wrote:

> We should also probably support gzip in the header, adding at least
>
> Accept-Encoding: gzip
>
> @atteroTheGreatest <https://github.com/atteroTheGreatest> Is/will gzip be
> supported on Syncano?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Syncano/syncano-android/commit/231ebe50c2e4a55e40943abc6b1f026ae7264a25#commitcomment-9990292>
> .
>


I think you should have the same (applied) comment than the one you find on `BatchOperationsDelegator.operationQueueLocal` on clean usage of the threadlocal


Arnaud was locking the test platform this afternoon, so I take a look to the python code to access our config. I just publish the class OpenSteakConf. It should be better to access our config file, but not enough if we split the config file (common.yaml) in several parts


No sign of any QC results written to properties as committed on 2/8?
http://basespace-project.illumina.com/browse/BASE-8815


That sounds fine. I just put that line there to test the shadow dom thing actually.


puede ser porque falta jquery


That line breaks ^^


Because I added the element before removing (if there was overflow), you're right, now I don't see the purpose neighter.


@danieldresser uses `DiffColumn` in out internal RenderPassSettings, so it would be worth testing this out before we merge, to see if that code needs updating. Dan, can you take a look?


no, the non-global imports need cleanup and testing.  I'd like the unit tests to do the same tests in each type of UMD.  I think its just a matter of including a js package manager that defines 'define.amd' and 'exports' in separate test environment files.


Now, I learn that the declaration and the definition can't be separated because we can't compile the "template function" in a single file. The function is create by the compiler when we use the template.


@Joimer I changed it from 252 HP / 252+ Def because the spread doesn't make much sense when he's holding a Sash. Actually I've been thinking if it would be better to have max SpA \ Speed and Timid on him?


86721074_WarnBadActivePath (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Thanks for spotting I am fixing this now, would be good if you could test again with the fix.


This is better written as `for x, y in itertools.product(xList, yList):`, as it more clearly communicates what you're doing, and requires only a single indent.


update_sqlite_library (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Thanks.
@dczlonka Could you please add support for it in the library?


I got this from another example where the UMD setup was more concise.  I haven't fully figured out how that works consistently with exports and the other.


Oh good point :-/. OK well I'm going to do that to start since it's simpler but we'll probably come back to your way soon. Just want to land something... But now I'm off re-doing DOMException!! :P


Ok


This makes the build fail
[ERROR] <http://ci.titellus.net/jenkins/job/GeoNetwork-3.0.0/ws/web/src/main/java/org/fao/geonet/Geonetwork.java>:[43,44] error: package org.fao.geonet.geocat.kernel.reusable does not exist


Sadly, I don't know. I will have to find a way to test it.


Great, thanks for the testing :+1:


might want to think about moving it back in, need to talk through how to handle the handlebars-validation.js that is included with Torso and make it play nice with any other handlebars validation stuff that someone might want to use.


(fixed in ceylon/ceylon-common@671879a531f69471cae291a6e7ca070148172e91 FTR)


キー名を表示する時、日本語に変換する関数があった方がいいなぁ、と思ったので追加しました。

typeを色々と変えて、様々な場面に対応できるようにしています。


ライバル数が多いと、tableの高さがひどいことになってしまっていたので、固定しました。


I believe the four tests I removed were wrong, and should not have been passing.  It seems the previous code was creating improper filter packets.


Yeah, it seemed easier to make a list of adjacent cells with borders this way (without having the "inner borders" be twice as thick, which would happen if they all had a standard border).


I thought about that, but I dismiss that possibility because I had to search for an element when it already existed, I'll ask you in the chat about your suggestion.


Thank you!! Forking yours since @piquadrat  has not merged this.  I might also suggest a pull request for your master into his.


- 詳細をクリックすると、ユーザの情報をmodalで表示するようにしました

- IIDX IDでユーザを検索して、ライバルを追加できるようにしました


If you want to. It could be used in Firefox too, but I decided not to use it, since in Firefox you can clearly tell with `window.opener` if the window is a popup or not.


Shouldn't you follow the same naming standard for the function as is used in the rest of this file?


Le principe général est que du code qui repose trop sur des effets de bord est plus difficile à comprendre que du code exprimé par des fonctions pures. Une fonction pure, on peut l'appeler autant de fois qu'on veut, si on lui passe les mêmes arguments son résultat toujours sera le même.

Comme dans la plupart des langages on ne peut pas assurer qu'une fonction est pure, on se repose sur le nommage. Ici, `isAlive` indique clairement un prédicat.

Pour une méthode à effet de bord, on utiliserait un verbe à l'impératif, qui suggère un ordre. D'autre part, on évite si possible de renvoyer une valeur, parce que si il y a besoin d'obtenir plusieurs fois la valeur sans faire plusieurs fois les effets de borts, c'est l'appelant qui doit faire attention. Un cas connu en Java est la méthode `next()` des itérateurs, qui renvoie la prochaine valeur et en même temps passe l'itérateur à l'élément suivant. Si dans la boucle on a besoin plusieurs fois de l'élément courant, c'est tentant de ne pas penser à passer par une variable temporaire, et appeler `next()` plusieurs fois → bug. Idéalement les itérateurs devraient proposer `boolean hasNext()`, `E currentElement()`, et `void goToNext()`.

Ici, vous avez certainement besoin d'une méthode qui met à jour (ou tente de) l'objet suite à des dommages, mais elle ne peut pas s'appeler trompeusement `isAlive`; peut-être `checkDamages` ou `attemptToBecomeDead` ou `updateAfterHavingBeenHit`, mais pas `isAlive`. Et je suspecte qu'un prédicat `isAlive` séparé vous sera utile par ailleurs.

En général ça ne gêne pas d'avoir plein de petites méthodes, même triviales, qui ne font qu'une chose mais bien —tant qu'elles sont nommées de manière claire. Par exemple, `boolean isAlive() { return getLife() > 0; }` traduit directement "on survit jusqu'à PV=0, en dessous on est mort". Idem pour `boolean isCrossable() { return !isAlive(); }`, ça laisse un point de flexibilité pour mettre une formule plus précise si par la suite on décide qu'on peut être vivant et traversable en même temps, ou mort et pas traversable.


Actually the threadlocal is not enough.

When the thread local is used in `BatchOperationsDelegator` and `GridDialectInvocationCollector`, it is always within the boundaries of a single `flush()` method. But here error handler keeps the state across `flush()` es and `commit()` / `rollback()`. There can be several sessions playing and thus sharing this state inadvertently.

```
session1 = openSession(MONGO);
session2 = openSession(COUCHDB);
session1.getTransaction().begin();
session2.getTransaction().begin();

session1.merge(...);
session2.merge(...);

session1.flush(); //some state put in `appliedOperations`
session2.getTransaction().rollback(); // rollbacks state put in `appliedOperations`
session1.getTransaction.commit(); // oops
```


Doesn't compile, should be a `stmt` it says.


After thinking about it, yeah, I'm pretty sure it will break out audit only logs since it will include anything with level AUDIT or higher.


Minor: shouldn't this indent to the opening paren on the previous line?


This gets fired once, when newVal is undefined... It should get fired when we update $scope.forks at the beginning, and also when we change the page.


I'm curious why you wouldn't just alias note to cat.


Add POST


Remove the secret


Sorry, will fix that tonight. I had intended to do a build before
committing but forgot.

From my phone
On Mar 2, 2015 6:51 PM, "François Prunayre" <notifications@github.com>
wrote:

> This makes the build fail
> [ERROR]
> http://ci.titellus.net/jenkins/job/GeoNetwork-3.0.0/ws/web/src/main/java/org/fao/geonet/Geonetwork.java:[43,44]
> error: package org.fao.geonet.geocat.kernel.reusable does not exist
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geonetwork/core-geonetwork/commit/580a3b8ebc8dcd09b32dbf9f5579d2ba568d6baf#commitcomment-9990499>
> .
>


Why not
```
cmd.append(instDataFile)
```
?


Also the thread local is not enough because we will:

1.  leak state
2. and not clear it

if the user forgets to commit or rollback the transaction is a nice and safe try / catch.


Me too... `2` is a very good number indeed!  :stuck_out_tongue:


@rcaloras: Looks cool, thanks! Will upgrade when I have time.


Thanks; please do investigate if you have time.. I will too, but not immediately.


I'll check with D.Storch which he prefers  -- whether we highlight the change or just remove this bullet point.


Yeah AUDIT needs to be higest for sure.


tento riadok nefunguje, pada to na diluculum, skusal som spatne vratit add_executable( ${3DSOFTVIZ_NAME} ${INCL} ${SRC_DILUCULUM} ${SRC} ) a build zbehol.


Yeah I need a github we hook to a PHP script on the VPS. Problem is i don't
have my login info, or ip.

On Monday, March 2, 2015, PEMapModder <notifications@github.com> wrote:

> Is it possible in any ways that it can do it automatically? (Like,
> something like Jenkins, or you setup the GitHub webhook listener)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PocketBukkit/PocketBukkit/commit/742d92a7c8bec5a1931a15fec84197516dec2ed7#commitcomment-9988056>
> .
>

--


> Err.. or callers who pass in nil on accident?

Or callers that never set it at all. This is a `SearchViewController`, so it doesn't make sense to use without search engines being set. Having the unwrapped optional here simply enforces this precondition and helps weed out logic errors. It's cleaner than the alternative (having an additional explicit `assert` with `?`s everywhere it's used).


By design AUDIT should be printed so if AUDIT is verbose we should be fixing the verbosity of specific statements.


Yeah, presumably nobody will ever see it except when they are trying to fix your stuff ;-P


Right. Something that will be noted in my, umm, upcoming documentation cleanup. But at least it's the same as for the python logging module itself (https://docs.python.org/2/library/logging.html, although I had to deliberately search google for the optimization aspect to see that written down anywhere: "Formatting of message arguments is deferred until it cannot be avoided" from https://docs.python.org/3/howto/logging.html#optimization).


Also, as Simn pointed out, we really want :: for lists at some point.


missing newline before end of file, github shows this little red symbol, git explains it too in diff


good point, thanks


1 is ascending, 0 is descending. This is taken from the sails docs for
multiple value sorts. I don't know that the text values support multiple
values.
On Mon, Mar 2, 2015 at 10:31 AM Sarah Allen <notifications@github.com>
wrote:

> I couldn't find documentation for 0 or -1 as sort parameter, but did find
> that we can use 'desc' which is more readable
> https://github.com/balderdashy/waterline#sorting
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dhcole/midas/commit/69c4033bdc57ba986aeea92360cef6902b6666c1#commitcomment-9987594>
> .
>


oh, `head :: tail` would be GREAT!


may I release now or do you want to fix something else?


Authorization errors should be 401. 500 means the server raised an unhandled exception. The server should check the auth and if something is wrong catch the exception and return 401 with abort().


skuste:
list( APPEND SRC ${SRC_DILUCULUM} )


should be changed for more generic Exception


Let me do some checking. A library that provided a form of self adjusting computation suited to
+incremental recomputation of only the visible part of the page, perhaps
+like the work on Adapton~\cite{adapton}, seems like a promising
+approach to addressing this problem.research


that's a huge commit, you can't just say "reimplement the class" and redefining everything we had in one commit. The poor reviewer!

Usually we want commits a little smaller, one little change per commit. Its way easier to assure that there are no bugs introduced then.


q


I didn't write this :) I agree we can improve it, but don't want to stuff unrelated fixes in here. I can file a separate follow-up.


I'm slightly confused - I thought we wanted to suppress AUDIT messages unless verbose flag is provided?

After all, AUDIT is the most verbose level anyway, right?


Just to clarify things, here are the steps to reproduce the dragging issue:
1) Select 1 icon
2) Press <Control> and click on the icon
3) Start dragging it somewhere
--> broken drag event
The commit moves the <Control> handling to the button release function to fix this bug.

Also, all icons will be de-selected now after activating an icon via double click.


I don't see the order being tested in the other test. If it is, then alright. If not, I think what @zabil says makes sense.


@cheuschober
did you give me zero because they whole work was wrong or because of the wrong pull number.


Also, if you don't want to manually do it (in the case of larger changesets), you can generate those changes as a patchfile or diff by adding to the end of the URL:
 `.patch`, like so:
https://github.com/laravel/laravel/compare/v5.0.0...v5.0.1.patch

or `.diff`
https://github.com/laravel/laravel/compare/v5.0.0...v5.0.1.diff


Previous: https://github.com/FreeBSDFoundation/freebsd/commit/cc5c259812a3ec2217c3347735aa0480ba59e9aa


A lot of this code lime OPT1, OPT2 etc are from Sabermod, but you never updated the license...


How do I sign a MobileConfig? Do you know?


@FroMage could you take a look at this again? I can't reproduce your problem.


Can do


The third image is all black for me unless ```offset``` is set to ```0.1```.
(also, ```block_size```, according to the [doc](http://scikit-image.org/docs/dev/api/skimage.filters.html?highlight=threshold_adaptive#skimage.filters.threshold_adaptive) should be an uneven number.)


Again, the server should never return 500. In this case there are two options:
1. Return 400 (invalid request) as an error
2. Return 200 (OK). The room already exists, so at the end of the day the goal of the user was accomplished.

Which option to pick is a software design question. Both options are valid. The one that returns 400 gives the caller better control, but is more annoying to use. If they want to create a room they have to check first if it doesn't exist already. Even if they check, someone may create the room just after they checked, so their call to create_room() will still fail. The other option may hide subtle bugs, where a room wasn't supposed to exist yet.


@hvelarde no, nothing more to be done there apart evaluation of #40.


Ok. I'm not going to scrutinize individual lines any more. But I think the code needs some more thinking.
For example, I don't see why we would do a POST and care about the result.
I think the only time we'd ever do a AJAX get is if there's NULL in the localStorage. This will happen to ALL of our first time viewers. Thereafter we only do a AJAX POST right after they've changed the state of their localStorage (in other words, right after a `localStorage.setItem()`).

Now, two thoughts spring to mind. A large number of our visitors come from a google search or something, view one event/page and then leave. They're definitely anonymous so we know nothing's going to come back on an AJAX GET, so there's no point even bothering. Equally, if they're anonymous there's no point bothering to try to send an AJAX POST. You could include this in `main_base.html` mayhaps:
```html
{% if request.user.is_authenticated() %}
<stars data-get="{{ url('starred:get') }}" data-post="{{ url('starred:sync') }}"/>
{% endif %}
```
(pardon if I get the names wrong)
This way, your jQuery code could see if there's a "stars" element. E.g....:
```javascript
var signedIn = !!$('stars').length;
```
That'll tell the rest of your script if the user is signed in and whether it's worth bothering doing the AJAX GET or the AJAX POST later when they click stars.

Also, it's a good idea to avoid hardcoding URLS in the the .js files. This way, the ONE and only place the actual URL is every written down is in the `urls.py` file. ALL other references to it is thus by name which might never change even if the URL changes. So, to pick that up in the javascript code you'd do something like this:
```javascript
function starClicked() {
  // assume this is the function that gets clicked after the array stars has changed
  localStorage.setItem('stars', JSON.stringify('stars'));
  if (signedIn) {
    $.post($('stars').data('post'), {ids: stars, csrfmiddlewaretoken: csrfToken});
  }
}
```

Just FYI, there's another rule of thumb about avoiding English in the .js files. Some projects are different but in most Django projects it's best to keep it simple and do all the English (or whatever the language might be) to the HTML templates. For example, consider:

```html
<button>Save changes</button>
```
...together with...
```javascript
$('button').on('click', function() {
    if ($(this).text() === 'Save changes') {
      $(this).text('Changes saved');
    } else {
      $(this).text('Save changes');
    }
});
```
Now this is bad because you've written English in three places. And if the HTML changes to use the I18N function `_` like this:
```html
<button>{{ _('Save changes') }}</button>
```
and the HTML gets the I18N treatment so that it's rendered for swedes as: `<button>Spara ändringar</button>` then the javascript is going suffer badly.
A more sustainable change would be:

```html
<button data-whenclicked="{{ _('Changes saved') }}">{{ _('Save changes') }}</button>
```
...together with...
```javascript
$('button').on('click', function() {
    var $button = $(this);
    var tmp = $button.data('whenclicked');
    $button.data('whenclicked', $button.text());
    $button.text(tmp);
});
```
All of a sudden the javascript code becomes agnostic.

Note: This isn't only just for HTML templates that do (or some day will) support I18N. It's just generally a good standard practice because the place to go to manage the English copy is in the templates and not something you want to edit in the Javascript files too.

The second thought that sprung to mind is the fact that we might fail on the network. And I'm not entirely sure how we're going to solve this but let's keep the debate going to charge up our brains for ideas.
What could happen is that I visit the site on a new device, not signed in. I star this, this and that event. (3 stars in my new device's localStorage). Then I decide to sign in and my server user-profile had 10 stars saved (some might overlap). If we don't "sync those up" the next time I click a star it'll send an AJAX POST that I only want to remember 4 stars! This would be bad. And it's not unrealistic.
I can sort of imagine a solution whereby we store stars under different keys in localStorage for when you're signed in and not signed in but it needs some planning and more thought. I'll leave that to you :)


J'ai peur que ce ne soit pas assez précis comme traduction, mise en contexte.
Je propose '**erreur**' ou '**bogue**' en dernier recours :smile:.


Reviewed in https://github.com/FreeBSDFoundation/freebsd/commit/f249458fa7a72f47280ac795b1087f739a4baa1d


bad name - inpArray is a matrix, not >=3 -dimensional array


Good point: https://github.com/jenkinsci/jenkins/commit/a87a5a1a5c6c7594fb322e10c815d94052164e19.


You've declared `dependencies` twice in this file.  Put them all into one declaration.


Review in: https://github.com/FreeBSDFoundation/freebsd/commit/f20fcb980c6c30309b705760efa0de79968baf8c


Interesting, if you enter a search, go to the settings page, and go back, the results appear to show up properly.


Maybe getTenantValue**s**ForKey ?


@mulby does it "supersede" rather than replace the event_type?


"a little slower" означает медленнее...


@dmitry-a-morozov thanks for the update.

In the sample, it shows using connection string name, but I get the point of instanciating the command this way, that seems to work in my case too, and the sample is teaching me that we can have proper generic semantic in F# opposed to C# where it wouldn't be possible to call a constructor with parameters like you do.

```fsharp
(^a : (new : string * int -> ^a) (adventureWorks, 30))
```

To do that in C#, I'd need to use reflection...

So it seems I can do what I need after all :smile: and I don't even need to crack the code of the project.

I don't intend to make a fork of this great project, the maintainers always come up with great solutions.


Reviewed in:
https://github.com/FreeBSDFoundation/freebsd/commit/63fa71c323c0a9ebefa719d5ec9a8bfca9e09cc0
https://github.com/FreeBSDFoundation/freebsd/commit/03a6c51a4e13a20af7106f64a87c67dbc5a95948


I can see that we are missing this one


I just needed to keep compatibility with the `namedtuple` approach, and since I was also introducing the caching, I was also keen to keep it read-only so that the cache couldn't be invalidated by setting it.

Things might be different if we were using pure python, but since we're mixing Python and C++, I think it's best to always use methods for things that could have side effects, and never have properties with side effects - it's not what a C++ coder would expect. With that in mind, properties make sense for binding public data members (like Vec3::x), but not much else.


Reviewed in: https://github.com/FreeBSDFoundation/freebsd/commit/ccba7f2de8a6cefe1cf312819a7e02a8d61b4985


Thanks!


Can you please try the latest version of skimage?  (If you wait a few hours, there will be a release.)  I think this is due to your platform relying on a different image reader than mine (but that issue has been solved in the latest version).


Previous comments here:
https://github.com/FreeBSDFoundation/freebsd/commit/772385b420cf7baa00ac0da0d93516318ca5327d


Yep, I did default the filterable argument to False with this in mind, but some more testing is always welcome.


už funguje


wfcw


This is irrelevant now since we have new busdma implementation


ocgcore/libcard.cpp
In this version, scriptlib::card_get_origin_attribute() will get 0 on trap monsters which are destroyed/sent to grave.
This will cause an error on cards like 憑依解放/Unpossessed

The previous card_get_origin_attribute() can works on trap monsters if their attribute/race is added into cards.cdb


The follow up commit addresses this issue. The routine will stop after adding MAX_TEMPLATES files (not counting folders).


@lgu1234 Please remove the colons from these reference names - here and in the other places where it is used as an object-list name.  @jasondegraw Otherwise I think this is OK.


Accepted in:
https://github.com/FreeBSDFoundation/freebsd/commit/db3c085a3e2990c34ec3de44b45cc73ee3d2e2a4


Hi Masato
Indeed you are right. I actually only made that change to help me diagnose a problem and I wasn't planning to leave it in there when the time comes to merge this branch with master but your email served as a useful reminder.

Thank you
Luca

> On Mar 2, 2015, at 6:28 AM, monodera <notifications@github.com> wrote:
>
> Hi Luca,
>
> I think you don't need to change from mean to sum because in any case counts of two negative peaks are a half of central positive peak [suppose the eps values are 1 at the position of the star and 0 for other pixels and take (1+0)/2 and (1+1)/2].
>
> In this modification, I guess the final rectified eps values are N times as high as it should be (N is the number of input frames), and potentially make absolute flux calibration wrong when one wants to convert eps to flux unit based on broadband magnitude of standard star.
>
> Best,
> Masato
>
> —
> Reply to this email directly or view it on GitHub.
>


Doesn't work, line of code that i had before
`            Collection<GHIssue.Label> ghLabels = remotePR.getRepository().getIssue(remotePR.getNumber()).getLabels();
`
btw, this trick with labels because of https://github.com/kohsuke/github-api/commit/d90adfa98e61d6ce5d7e585ca2f5b2c9f782bbd9#commitcomment-9754064


[`sudo:false`](http://docs.travis-ci.com/user/workers/container-based-infrastructure/) maybe?


You seem to have mispelled canola.


And I just saw https://github.com/johnotander/generator-p/issues/6, sorry


Do we need to block until the callback is complete before checking `g:callback_stdout` (as we do above), or does vroom's system call hooking mean that the wait above isn't actually necessary?


Ok, Philipp and Jean-Luc, please be aware of this.  I see various examples in HoloViews (not to pick on that in particular) of things that are getting formatted every time even when messages won't be printed, which in some key spots may be slowing things down.

Probably only self.debug() is the one to worry about, because normally self.warning *does* result in a message (even if it might not for some users), so it's not going to pay off much to avoid formatting those.  I don't see any of those in HoloViews, but I do see some in Lancet. and Imagen and Topographica.


Fixed in https://github.com/FreeBSDFoundation/freebsd/commit/d189205295670073ca841763fb376c7da1e90827


Actually required to make the Debian images.


Previous comments here: https://github.com/FreeBSDFoundation/freebsd/commit/2be5bc06a0230c72904c6e8479617bf4a8ab46d6


It's fairly advanced F# feature and called "Statically Resolved Type Parameters"
https://msdn.microsoft.com/en-us/library/dd548046.aspx
Be careful when using it.
http://theburningmonk.com/2011/12/f-inline-functions-and-member-constraints/

I appreciate your understanding on this discussion.


you can just make it

      def is_public_profile?
          ! posts.published.empty?
      end


Why this change? (I don't strongly care either way, just want to know if we now expect the returned list to be modifiable)


AdvancedAFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1621 of 1621 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You can define a Queue by implementing it with a linked list, and then you can also use the indexOf() method:
private Queue<T> queueImpl = new LinkedList<T>();
...
((LinkedList<T>) queueImpl).indexOf(element);


@lucaswerkmeister yes, I just did that ;)


Done


@dhrumil24patel @sagarpomal : Please update the HTML to work with the Bootstrap theme. I don't know how to do that.


This change isn't necessary.  ```scopes()``` is just a list of names to validate against.  It doesn't actually use all of them.  The two calls to ```add_backend()``` define which backends are active to each scope.


Typo here: "lIf".


Stupid error, I was watching 'jobs' instead of 'forks' :D


That's a pity.


Reverse both lines for readability (follow logical flow, even though both versions are correct)?


I was on the fence about whether or not we want to `panic!


rename it to `index.jbuilder`


This state should probably be stored in the transaction object, which ties into what @hferentschik is doing. So you're going to have to whip him to be faster and it might mean that you will need a JTA transaction object that keeps that state *if* the datastore claims not to be transactional,


Nit: reverse two first arguments for consistency with `broadcastConfigurationChangeFromTransaction`.


I think you want:

`'"eddy ID"', ', ', '"number of cells"', `...

because there are two columns, and number of cells is a separate column.


Thanks for the tip, I really missed those other patches. I think when you
mentioned them I thought you were talking about some other patchset.
Anyway, having them present on Google's flagship device convinced me.

2015-03-01 16:14 GMT+00:00 Jake Weinstein <notifications@github.com>:

> Couple things: first off, you'll probably want to add the next two commits
> for this (first is for 8226, which is needed before the 8974 commit). You
> can grab those either from the moto git or shamu source. I suggest shamu
> since it's a bit cleaner. Rather than making new 8974 files and ifdefing,
> it just adds the 8974 changes to the existing ones. The commit is called
> 8084 optimization, but it uses the same code as the 8974 assembly files
> they added on the moto git.
>
> Also, I recommended these Motorola memcpy optimizations a few months ago
> and you said you didn't really believe in that sort of thing. What changed?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/franciscofranco/one_plus_one/commit/4bc5ff91bf940a8267615656eeb9c8c0e97e81b5#commitcomment-9975477>
> .
>


DbTable sounds great to me.


@f1vefour, can you push with your email address. You are listed as an unknown user in your commits.


you don't need to put `FactoryGirl`, just write `create(:post, user: user, published: true)`, this is because FactoryGirl module is [included](https://github.com/aliciacatalina/verba/blob/master/spec/rails_helper.rb#L27) in the `spec_helper.rb`


AdvancedAFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@ayine17, The pull number. Without the correct number I couldn't assign a grade and Blackboard enforces that I grade -every- attempt. So that attempt was a 0 since it wasn't to your pull request. If you did complete the work, please submit again on Blackboard to the correct pull number and I'll grade it based on the rubric as-usual.


Maybe you can get rid of that comment - the tenant is validated by the `TenantFilter`, so should always be present.


I rolled in the cleanups and pushed 72a8743f559fc28a110bed03c09ea32a110987d3


This is just a quick custom parser. Not related to any specific spec.

I'm hoping to illustrate how to extract specific elements from a document.


Great idea.


Would enhance readability if you included something like:

```
MODULE_DOCSTRING = 3
NEWLINE = 54
```

Which you could use in your conditionals without needing a comment.


Didn't know that, thanks for the pointer!


Yes, I'll move it over


updated


Actually that's superfluous, I'll be sure to remove it.


Should we add then invalidate the cache to avoid a race condition?


I had no idea about that. That's really helpful.


I would prefer this to just return an `IoResult<u8, IoError>` but I couldn't figure out how to substitute the `Ok()` from `port.run` to an `Ok(chip_id)`. Also, Rust was unable to figure out what `IoError` is even though I tried to include [`std:io:IoError`](http://doc.rust-lang.org/0.12.0/std/io/struct.IoError.html). Is an `IoResult` even the right type to return?


Same question as above (delete then invalidate the cache).


@mjwitte @jasondegraw Thanks. I remove ":" in the object-list names and committed a while ago.


You should add a counter example, for when the method should return `false`. Threating only the `true` case will not catch if I hard code `true` value in the method core.


I considered placing these constants as fields of the `Accelerometer` struct but that seemed to JavaScript-y.


Style-wise, all the other bullet points are capitalized and end with a period. Might be better to be consistent


hummm, it should have been rooted@android.net....I will look at my git setup


no hard and fast reason, just in the interest of expediency. I'll update this to a deep compare.


Missed make_pair at line 680


ohh forgot it will do it :p


We also need help with the pure-darwin merge, so if this stuff bothers you, please help us fix it :frowning:


Awesome! I really thought: "Why are there two files, they are identical?" even to the point that I called `diff` on them... :grinning:


Looks OK to me


I disagree. I think they're useful for several reasons:
* Since selectors are referenced only by their name strings, we get no compile time checks that they're valid, and we get no warning if we mistakenly delete them, which we could easily do during a cleanup of "unused code".
* These methods are local listeners that aren't part of the API; we expose them because we have to. It makes it obvious to calling code that they shouldn't be doing things like `controller.SELdidSelectEngine()`. Without the prefix, they will look like any other normal method.

We don't use this type of prefix on anything else because everything else is checked by the compiler. I'd gladly dump them if Swift added `@selector` support like Objective C.


OA 自动化办公系统


Removed pinMode and digitalWrite functions because of "out of memory" message.


`port.run([])` should be abstracted out to `port.i2c_transfer(addr, tx, rx)`.


Done!


A small comment here explaining why it advances by 3.
For example:
`pos += 3 # This skips the tuples which describe the line number and column that the token begins on.`


thank you so much


Here is the ugliness where I take a perfectly valid `IoError` and return an Error with a string instead.


Aha, I see. Thank you!


That is correct! :)
Or at least it's purpose must have been superseded with something else, and from what's left it's not clear what that purpose was.


No reason, I'll fix.


Wow we had all of those? I imagine it wouldn't be very bad to have different sounds for different vehicles, for example.


update_sqlite_library (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (622 of 622 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-3.65%25-green.svg)


Thanks, andreabadesso!
I appreciate your help even for just a single link fix

Regards, Dmitri


These two `port.run`s should be abstracted out to:
```.rs
self.port.i2c_receive(I2C_ADDRESS, &mut reg_current_state);
self.port.i2c_send(I2C_ADDRESS, &[CTRL_REG1, reg_current_state[0] | active_bit]);
```


i would stick with separate files for the different platforms and then have the targets inside the files determine the "size". pipistrello is not small ;)


I said it's trivial ;) How about one-way monolith entry?


Each of the pairs of `u8`s received needs to be recasted as signed 12-bit integers. I don't think this logic, copied over from the JS driver, does it correctly.


I'm not following the details but in Lancet if I do this to format two regular Python integers:

```python
self.debug("Process %d exited with code %d." % ...)
```

Then is this an issue? Would this call ``__repr__`` unecessarily for some reason?


Pushed based on review in f20fcb9 as d2c889a75f2a299933d24d0c1389bfc264f90106
(Although it seems the commit message is incorrect)


assert_instance_of(Namespace, result['namespace'][0])


If you mean it doesn't compile, then yes, that's to be expected --- that's what I mean by source compatibility.

But I've preserved binary backward compatibility. If you compile the above code with older version of github-api and run it with a newer version, it should continue to work.


@CurlyMo we will have to start using mkknlimg on the Pi 2 kernel, also we need to add dwc_otg.fiq_enable=1 dwc_otg.fiq_fsm_enable=1 dwc_otg.fiq_fsm_mask=0x3 to cmdline.txt

I'm trying hard to fix these kernel issues but it's difficult for one person.


In IOS,  ```analytics_action_configured_region``` event reported in  ```- (void)applicationWillResignActive:(UIApplication *)application``` method. I don't think this is also the correct approach, because ```applicationWillResignActive```  is triggered when home button pressed or phone receives a call. And that's why current IOS reports too much configure_region event:
![untitled 2](https://cloud.githubusercontent.com/assets/2777974/6447405/0f3edfa0-c0e0-11e4-8dbc-96b1cc2b6cf1.png)


@kevinmehall, I took your script and broke it out into `tessel.js` (port functionality) and `lib.rs` (accelerometer library). Obviously, `tessel.js` should probably be it's own cargo module eventually.

I also created a `Cargo.toml` because I'd like to be able to use `cargo build` instead of the really long command for cross-compiling to MIPS. I haven't read up on how to make that work yet (or if it's even possible).


Without having looked at the low-level details, this looks plausible to me


@quintesse yes, I just saw that :) thanks!


Even if it isn't now, it could be useful for someone later. But it doesn't matter, because zone has nothing to do with sides.


I don't think this will call ``__repr__`` on self, but it will call ``__repr__`` on the error code and format it into the string.  That computation is wasted if the logging level isn't set to include debugging messages.

If the code is simply an integer, that's probably not worth worrying about, but if the argument to %s was something with a big repr, then it *would* be worth worrying about.

So best practice is always to avoid the ``% ...`` and simply use ``,``; the latter is always faster and should work the same.


I think this (or these, I can't recall if we have the same names around) should be:

    def test_get_namespace_v3

(and I'd prefer to use v1beta3 instead of v3, same for test_delete_namespace_v3 below)


@gridaphobe Or maybe:
```
if [ -e /usr/include ]; then
  export SDK_ROOT=/
else
  export SDKROOT=$(/usr/bin/xcrun --sdk macosx10.9 --show-sdk-path)
fi
```
I.e. use the command-line tools if they are installed and otherwise Xcode.


Good, but it's unclear that the condition about matching nodata datatypes applies even when the caller set `masked=None`.

Also nitpick: I think of a singular nodata value as applying to each band, not as a list of nodata vals on the dataset as a whole.  Maybe the difference is immaterial (and I don't know how the native formats store it) but consider clarifying line 595 "or will be masked if any of _the dataset's bands' "nodata" values_ are not `None`."


test comment


testing


Sure


My bad, that isn't the structure of the returned array. A comment describing why we advance by 3 would definitely be nice!


1/61023.7 ?


LGTM, consistent with amd64 as well.


What is `mkknlimg`?

You can add additional cmdline parameters here:
https://github.com/xbianonpi/xbian/blob/master/xbian-build-img/hooks.d/pre-finish.d/rpi-cmdline

And here (also on this line):
https://github.com/xbianonpi/xbian-update/blob/master/content-tpl/DEBIAN/postinst#L934


This in no way works, because what we get back from `bulk_get` is a bzipped lump of json, rather than anything usable.


Referring to the docs here: http://sailsjs.org/#!/documentation/concepts/ORM/Querylanguage.html


Revert this if you use MSM Limiter.


Also there's a very similar message about masking below, in the `_read` docstring (line 774).  I think it has nothing to do with that function and should be removed.


Reminder that we'll need to add this to our upgrade notes.


```if ( _controller.checkBeforePlay() || (_oldpos === 0 && !_model.getVideo().checkComplete())) {``` ?


@GalaticStryder that's kind of a dick move to give credits to @Cl3Kener when I was the author of this entire script besides some optimizations.


move this outside the class definition. Also, you can use python's multiline string:

```
markup_for_form = """
<!DOCTYPE html>
<html>
  <body>
    <form  method="GET">
      Size of Magic Square:
      <input type="text" name="size" value="3">
      <br />
      <input type="submit" value="Submit">
    </form>
  </body>
</html>
"""
```

I also added closing tags for body and html


rolled into cb35bbca3c6b1857cc0961e6071f1651a7066008 locally


Alejandro Alhama Riego.


remove


Closes #161.  This work looks to already have been done by @uglybugger in a previous commit with the whitelist of good characters and then just changing all the other characters, so I just added a test to verify this is indeed closed.


alright I added a property called log with obselete tag(to notify coder of
refactored name)

On Mon, Mar 2, 2015 at 11:06 AM, BlueRaja <notifications@github.com> wrote:

> I'm not saying the whole refactoring effort should be thrown out, I'm just
> saying we need to revert the breaking changes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WildCard65/SteamBot/commit/59f6977d458ffbd613505cda2db9be8f20967b6e#commitcomment-9988326>
> .
>


will roll in 1ff4bb8ced2ff72ff9cf72f15ae0830f8cb51459


Is this supposed to be continuous?


This is interesting.. Splash always returns the result in utf8 encoding, even if the page originally used some other encoding. Could you please check that webkit fixes `<meta charset>` tags itself? If not, we should fix meta charset unconditionally.


missed find here, should be std::find


:trophy:


nitpick: I think of a singular nodata value as applying to each band, not as a list of nodata vals on the dataset as a whole.  Maybe the difference is immaterial (and I don't know how the native formats store it) but consider clarifying line 595 "or will be masked if any of _the dataset's bands' "nodata" values_ are not `None`."


Maybe try using .grid-footer-number ? If that doesn't work for you then add overline into module.typography.


Great edit!


what's the thinking behind this namespace?


missed distance here, doesn't compile in Visual Studio


wat?


That is an expensive way to get the data is present in the requested object. Why should there be additional processing called upon when the object in the iteration of the foreach loop already contains what is required?

eg. this is what is in the ArticleFile Object. When will there be an occasion that this information is inaccurate and the getter is more efficient and more accurate than was is present inside of the object?
ArticleFile Object
(
    [_data] => Array
        (
            [fileId] => 6
            [sourceFileId] => 4
            [revision] => 1
            [submissionId] => 2
            [fileName] => 2-6-1-RV.pdf
            [filetype] => application/pdf
            [fileSize] => 1647575
            [originalFileName] => 2-4-1-SM.pdf
            [fileStage] => 2
            [dateUploaded] => 2015-01-20 14:53:08
            [dateModified] => 2015-01-20 14:53:08
            [round] => 1
        )

    [_hasLoadableAdapters] =>
    [_metadataExtractionAdapters] => Array
        (
        )

    [_extractionAdaptersLoaded] =>
    [_metadataInjectionAdapters] => Array
        (
        )

    [_injectionAdaptersLoaded] =>
)


Sounds like it's a moot point in the Crispy case then. But I was just using it as an example; point still stands.

@haleyjd - any thoughts on this idea of adding deliberate delay? Granted it seems like an immensely weird concept to be emulating Medusa slowdown, to the extent that I've even questioned whether I'm actively leading this project into the realm of insanity by suggesting it :)

Following [the philosophy document guideline](https://github.com/chocolate-doom/chocolate-doom/blob/master/PHILOSOPHY#L149) of questioning, "would anyone actually want this?". The most obvious use case is if someone is developing a Vanilla level: experiencing no slowdown would give the mistaken impression that although the Medusa effect might look ugly, they wouldn't experience the game-destroying slowdown that you really get when playing with Vanilla. There might be people who eg. read about Medusa on the Doom wiki and want to experience it themselves.

I also wondered if there are any levels out there where imaginative level designers have included deliberate Medusa as some kind of special effect (like the "illusio-pit" in wow.wad)


will split it when i do total rebase.


The ordering is still wrong :)
urlparse, socket, contextlib belongs to the standard python library.

pyscopg2 and configman are third-party libs.


missed find_if at 2212


let's get curly braces on ifs here and throughout


No need to do this with `more`.  You can simply use the file as input like so...

`pbcopy < ~/.ssh/id_rsa.pub`


This should go into the previous commit.


You're correct, it also compiles without warning if you drop the casts.


Can we add the _metadataPath to log? Since we have a default path it is necessary for the user to know that too.


Well, `willShowWithState` implies a `KeyboardWatcher` will show with state, but it's really the _keyboard_ that's showing. Semantics, but that's the reason I named it this way.


You should look at [Vim Polygot](https://github.com/sheerun/vim-polyglot) as it covers pretty much every syntax.


Thanks!


these methods should be pulled out of stats imo, we'll probably want to use these elsewhere.


It's still needed to implement AI's "memory" for monoliths and also add some logic to make sure AI will visit all exits.

Thoughts about one-way one-way monolith's is there:
http://forum.vcmi.eu/viewtopic.php?p=14052#14052


Task callbacks


Does this fuzzy comparison belong in the Wcs class?  Equality usually does.  The counter argument is that it doesn't need to access privileged data members, but in this case I'm not persuaded by the argument.  It also avoids the plural of Wcs.


in arm64-dev-ddb branch now as 16311414d710f1551005c4ff04ab4be1e5599b56


Ok, сделаю скоро


some review in f249458fa7a72f47280ac795b1087f739a4baa1d


Is there any case where we would want `undefined` to be a valid value?  If so we need `value !== null`. I can't think of any but thought I would pose the question.


@diurchenko I think it needs to be && here, not ||


updated in 16311414d710f1551005c4ff04ab4be1e5599b56


The "_" prefix on the _data member is a convention indicating a private member, which shouldn't be used externally. We don't use an outright "private" designation because PHP4 doesn't support it. The execution cost of using a getter is negligible.


Where do these numbers come from?


I can't imagine wanting to use this outside of testing, but maybe you're right.


To be clear, there is a little confusion here. i.e. bookmarks don't really have "favicons". They just have icons. They can be anything, from anywhere. Sites have favicons, but we've gone to a small amount of pain to say that bookmarks don't necessarily have to point to sites right now (and in fact, folders don't).

The problem is we've got a table called "favicons" that really just holds "images" (they can be apple-touch-icons, article images, favicons, whatever), and we've got a class called "Favicon" that handles that table, so its a bit confusing to try and decouple the two.


I can imagine it being used in end-to-end regression testing.  Still testing, but not unit tests


Sure, `KeyboardHelper` sounds fine to me. Keeping the full state around is also fine by me (though not terribly useful currently, since no one will care about the animation curve/duration that's already happened).


which is now here: ebe3acf1b87e4689e7d607d954717f96a3fc8848


This causes a test failure when using MRI Ruby -- any particular reason to remove the `"map_string_msg":{}` ?


@lestcape, @collinss

I tried to do thorough testing on desklets with this patch - it seems maybe they need a little *less* special handling now.  The only issues I was seeing were related to your extra popModals, which don't appear necessary anymore (everything worked, regardless of log warnings)

This actually seems to also fix the annoying behavior with desklets being grabbable behind app windows.

Please let me know if anything actually regressed and I'll try to get on top of it quickly.  Just fyi, the dnd.js changes are the result of me taking gnome-shell's 3.10 dnd.js and re-adapting it for us.

Expect this to be backported to 2.4

Thanks


@es128 Hmm ok, I agree. I'll just use `posix-` and cross my fingers. Thanks!


You are probably right; supporting a *common* default for the items should be quite simple - but of course per unknown-number-of-column defaults is more tricky.


I was actually thinking of importing this: https://pypi.python.org/pypi/hiera-py/0.0.1 instead. But I haven't had time to code it, hopefully tomorrow.


@diurchenko in order to make code clearer, add check here like this:
if (intra_region) {
  return;
}


I'd suggest the format directory/command which imo would be more intuitive :)


then remove the checks for it later


by the way, is fixing of meta charset needed for httrack?


AdvancedAFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (623 of 623 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-3.67%25-green.svg)


Let's drop this commit. It's just going to cause more conflicts during datepicker branch rebases.


I wonder why this line has been removed. I don't expect to have it back, as it fixes a bug noticed in older releases, but I am not sure if it was just a mistake or not.


commit message could be updated to omit mention of missing cache support - we have partial cache handling in here now and a comment in the source wrt what is still missing


is this change still necessary then?


missed remove_if at 4334 and 4338


Can you
* move the router into an api.py, then move the `*ViewSet`s into that `api.py`
* move the register calls to be right after the class definitions in that `api.py`


This works on my machine, but I just pieced it together. I'm not a go programmer and it doesn't appear to fit the rest of the program.


@trusktr Yeah there are a lot of work to do from here. Opened issue #1.


Why define a retrieval key for variables that are not retrieved? It should be optional.


params is a weird name for an object. Are you expecting a hash or an actual object here?


I get a test failure when running JRuby tests just now:

    Failure: <TypeError> exception expected but none was thrown.
    test_string_encoding(BasicTest::MessageContainerTest)
    org/jruby/RubyProc.java:271:in `call'
    org/jruby/RubyProc.java:271:in `call'
    /home/cfallin/protobuf-isaiah/ruby/tests/basic.rb:229:in `test_string_encoding'
         226:       # strings are mutable so we can do this, but serialize should catch it.
         227:       m.optional_string = "asdf".encode!('UTF-8')
         228:       m.optional_string.encode!('ASCII-8BIT')
      => 229:       assert_raise TypeError do
         230:         data = TestMessage.encode(m)
         231:       end
         232:     end


This potentially changes behaviors, making DESTDIR "stronger".
Environment variables get superseded by the "=" operator in the Makefile.
However, passing them as EXTRA_OEMAKE makes them invincible.

It's not necessarily a bad thing, just making sure that it's what we want.


rebased in arm64-dev-ddb branch here fc4596405dcf5de8577ddea9bff1abeb6875a5fd


This generally should be
```python
urlpatterns = patterns('',
    url(r'^api/', include(router.urls))
)
```


original review in ccba7f2de8a6cefe1cf312819a7e02a8d61b4985


cool.


Was causing the following error, undoubtedly just due to use of spree_multi_tenant

HABTM_Zones Load (2.6ms)  SELECT "spree_shipping_methods_zones".* FROM "spree_shipping_methods_zones" WHERE "spree_zones"."tenant_id" = 1 AND "spree_shipping_methods_zones"."shipping_method_id" IN (1, 2, 3, 4, 5)  [["tenant_id", 1]]
PG::UndefinedTable: ERROR:  missing FROM-clause entry for table "spree_zones"
LINE 1: ...ones".* FROM "spree_shipping_methods_zones" WHERE "spree_zon...
                                                             ^
: SELECT "spree_shipping_methods_zones".* FROM "spree_shipping_methods_zones" WHERE "spree_zones"."tenant_id" = 1 AND "spree_shipping_methods_zones"."shipping_method_id" IN (1, 2, 3, 4, 5)


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/DisplayResults.class.php


It adds a trailer to the kernel for device tree compatibility, I am slowly working it in to the kernel, trying to keep up with mainline best I can without breaking anytime.

See this thread: www.raspberrypi.org/forums/viewtopic.php?f=29&t=93015

You can see my logs, I'm sure you have noticed the CPU bootup issues at the start.

*Before using mkknlimg: paste.debian.net/159261
*After using mkknlimg: paste.debian.net/159262


This becomes problematic if additional query parameters are added, e.g. `http://localhost:9000/?size=4&color=black`. We can use the urlparse library here. Add `import urlparse` to the top of this file, then the following

```
  parsed_url = urlparse.urlparse(self.path)
  query_params = dict(urlparse.parse_qsl(parsed_url.query))
```


now this becomes `if size in query_params:`


@mpc-hc: This is minor so I've only reset the translations for the "player menu" strings that I always found pretty unclear. I can change that if you wish.

Feel free to request other wording changes while I'm at it. Also you might want to double check the two tickets since there are some requests I dismissed.


Okay than I understand your change. Good work!


No worries.
I know how to do that.

On Mon, Mar 2, 2015 at 11:47 PM, Parth Gudhka <notifications@github.com>
wrote:

> @dhrumil24patel <https://github.com/dhrumil24patel> @sagarpomal
> <https://github.com/sagarpomal> : Please update the HTML to work with the
> Bootstrap theme. I don't know how to do that.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/parth-gudhka/MHT-Portal/commit/3ad177a7cf8019e7971eacd112bd94ab9d219d89#commitcomment-9990969>
> .
>


you can pull these three lines out of the if block, since you do them in both cases


So it's an abstract class attribute! And pylint is just wrong in reporting this as a warning.

Anyway please note that if ```@property``` and ```@abc.abstractmethod``` are used instead of ```@abc.abstractproperty``` the exception is not raised in Python2 (fixed in Python3):

```
$ cat test4.py
from __future__ import print_function
import abc

class Base(object):
    __metaclass__ = abc.ABCMeta

    @property
    @abc.abstractmethod
    def plugin_type( self ):
        pass

class Plugin(Base):
    plugin_typex = "p1"

print(Plugin().plugin_type)
$ python test4.py
None
```

So, the other Galaxy plugins should probably use ```@abc.abstractproperty``` too.


perhaps I'll rewrap this as something like
```
#define is_load_instr(ins)    \
        ((((ins) & 0x3b000000u) == 0x18000000u) || /* literal */ \
         (((ins) & 0x3f400000u) == 0x08400000u) ||  /* exclusive */ \
```
to fit in 80 chars


@crashman2600 :+1: from me again :)


@Domi-php , please see lines 235-237 in /administration/upgrade.php file.
Tables renaming was added. You added this second time.

Vitalij.


constants like maxValue are typically denoted using all caps, e.g. MAX_VALUE


remove


I’m not sure if this is really an issue at this point since the rest of the code doesn’t support IE8 already, and if the tests are converted to functional, then this code runs in Node.js and it’ll still be OK.


`http://pkg.julialang.org/?pkg=Calculus&ver=release` shows a loading error with Compat; details below.
The sha1 timestamp in `https://github.com/JuliaLang/METADATA.jl/tree/metadata-v2/Calculus/versions/0.1.6` is older than the `requires`.  Possible mis-match?

```
>>> 'using Calculus' log
ERROR: Compat not found
 in require at loading.jl:47
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in reload_path at loading.jl:152
 in _require at loading.jl:67
 in require at loading.jl:51
 in include at ./boot.jl:245
 in include_from_node1 at loading.jl:128
 in process_options at ./client.jl:285
 in _start at ./client.jl:354
while loading /vagrant/releaseAL/v0.3/Calculus/src/Calculus.jl, in expression starting on line 2
while loading /vagrant/releaseAL/PKGEVAL_Calculus_using.jl, in expression starting on line 4
Julia Version 0.3.6
Commit 0c24dca (2015-02-17 22:12 UTC)
Platform Info:
  System: Linux (x86_64-unknown-linux-gnu)
  CPU: Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Nehalem)
  LAPACK: libopenblas
  LIBM: libopenlibm
  LLVM: libLLVM-3.3
/vagrant/releaseAL/v0.3/Calculus
```


most of these are cruft...a holdover from the C++ implementation you did. I'm going through each of them and commenting on which ones you can delete

delete size


It is probably left unintentionally ;)


this is unused, delete


I think this commit had the wrong bug number on it...


delete panelsize; its only used by iconize, which is never used


delete panelsize


I moved it because you previously commented that it had to be moved because the autocomplete commit is before the tooltip actually has the classes option.


Why? I now have to add a bunch of entries to the `.gitignore` files when I do test builds of the obsolete applications. Were they upsetting something? `bootstrap` complains that they aren't committed.


this is just `return 0`, since you never change success. Delete this


Я предупреждал -- забаню!


python has True/False. You can delete these two


unused, delete


Why not field?


delete all four of these. They're used in one place, which is an unused variable


This ain't gonna work as is.


Nice. I'll test this out later this week and get it pulled in!


the previous four lines are duplicates of the first four. Delete them.


Just checked in a new (and improved?) version. I will move on to different things now for a couple of days. If you want to make it cleaner by adding goto's and other things be my guest.:-)


this is used once and not needed there. Delete this


Good idea


as per other comment, MAX_VALUE


Yes, should have been [1079920](https://bugzilla.mozilla.org/show_bug.cgi?id=1079920), not [1079220](https://bugzilla.mozilla.org/show_bug.cgi?id=1079220).  At least it wasn't a fix bug...


delete


Thanks!

Looking at the LAPACK CMakeLists.txt file, it can either:
  1. Take a -DBLAS_LIBRARIES=/path/to/lib1.a;/path/to/lib2.a;etc argument
  2. If that is not provided it uses CMake's FindBLAS (http://www.cmake.org/cmake/help/v3.0/module/FindBLAS.html)

For option 2, If you put in your LAPACK package depends_on('atlas'), then Spack will add the prefix of the Atlas install to your CMAKE_PREFIX_PATH.  FindBLAS searches for ATLAS within CMAKE_PREFIX_PATH (see http://www.cmake.org/cmake/help/v3.0/command/find_package.html), so it *should* find ATLAS as the BLAS install when built this way, *without* any extra parameters or tweaking.  The only way it finds something else would be if you have some other depends_on() that contains a BLAS implementation.

The other option would be to just make your LAPACK package add -DBLAS_LIBRARIES=/path/to/each/libatlas.a.

Can you see if the first idea works?  If it does I can add lapack with the dependency on atlas, and I can make atlas optional later.


86721074_WarnBadActivePath (macumber) - i386-Windows-7-VisualStudio-12: OK (2199 of 2212 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.41%25-yellow.svg)


PackageEvaluator hasn't been run since this fix was made


An optimization we'll probably want to to look at is using the bulk authz APIs. (see bulk_actor_is_authorized)


C&P problem, sorry and thanks.


@cala maybe you can show me the patch that you were working on, and I can take over from there.
I think it's not a very complicated fix, provided that your research done


I say :shipit:


we are going to rework this anyway with phase out of GLX


Sure, we can address the ES5 issues all at once. I was just hoping not to introduce more them. But updating these instances won't add much work later on.


lowest value is highest priority


yeah `object would be better here


Most importantly, on some levels, the medusa may be hidden so the player can't see it. Emulating the slowdown gives the player a hint that there's something wrong. In the case where the player is a mapper, he'll be able to fix his map and make sure it's Vanilla compatible.


I'm not sure that's required in the data_bag case, because we're only ever searching one bag and the ACL is on the bag not the item, AIUI.


Hmm, this is probably  just me being confused then - I thought the obsolete version of star2html was mucking up the star2html entry in  componentset.xml, because `make Makefile.dependencies` would pick up the older, obsolete version, and then I just got rid of them all to be consistent. We don't have component.xml files for all obsolete things I believe, just some?

Feel free to revert it if you want.


Correct. It doesn't belong in the autocomplete commit. It belongs in the tooltip commit, which is the commit prior to this one.


Not sure I understand why the prefix collision. Below you test for felix2:foo attr.


Ah sorry gotcha. Thought you meant previous autocomplete commit ill fix that.


I thought so.  I was just checking I did not break anything by switching
it back on.

On 03/03/15 03:59, Gary Hartnett wrote:
> Dave,
>
> This change was a long time ago. I don’t know why I changed that line.
> Change seems unrelated to the 21615 bug???
>
> Gary Hartnett
> Senior Developer @xTuple


Почему????
Почему везде ты используешь фор, там, где нужен фор, а здесь ты используешь вайл?


initial commit


in python, one typically documents classes (and functions) with a docstring: using a string as the first statement of the class. Rather than the excess of javascript docblocks, I prefer short, simple reminders about what this class is for:

```
class Matrix:
  """Data structure that stores the values of the magic squares"""
  def __init__...


I had to increase the version to be able to run buildr on Ubuntu.


unneeded, delete


nit: space after comma


This was used as static copy to prevent changes on active channel and to make sure if addon function failed that nothing is changed in channel list. With this the addon must trigger a channel update.

Can be changed to pointer, but not completely sure how it is if the addon fail.


I realize the previous comment may not make much sense, so here is how it would look in code:
Rename Logger to RemoteLogger
RemoteLogger.log becomes:
```Java
    /**
     * If this is a release build then associate the supplied string with the data for the next
     * report to a backend. Otherwise log the message locally using {@link Log#w(String, String)}.
     */
    public static void log(String tag, String message) {
        if (BuildConfig.DEBUG) {
            Log.w(tag, message);
        } else {
            Crashlytics.log(Log.WARN, tag, message);
        }
    }
```
Example usage:
```Java
    if (!downloadDatabase.registerDownload(downloadId, tempFile, localPath)) {
        RemoteLogger.log(TAG, "Could not register download entry for: " + downloadId);
        downloadManager.remove(downloadId);
    }
```


Yeah meant to already when we talked about this before.


@mitchellh can you check the gopherocity of this refactor? will post a few in-line notes with specific questions


Forcing FFmpeg seems sensible. I get 14 ms if resampling quality is set to "Low (fast)":
`20:00:35 97632.281250 T:1955529792  NOTICE: CActiveAESink::GenerateNoise took 14 ms`


Так же первое поколение можно тоже внести в метод, где ты печатаешь поле


and the fix squashed into original commit in arm64-dev-ddb branch


I don't know if this change is platform dependent but I have to change the order to make the test pass locally


f


Neat


Great point. I'll add that to the needs list for the PR


I've campaigned against catch-all for my entire career. ;) When it's scoped to a single call like this, the bug-hiding potential is very low, but still I prefer to be deliberate.


http://maven.apache.org/guides/mini/guide-central-repository-upload.html when do you think it can be available in maven repository?


@mgencur I don't think that matters. Both should work.


Claimed.


Duh, idk if that was so smart.. ^^


Всех обманула. Всё, что делает у тебя этот класс, это содержит мейн и методы на которые ссылается main


This commit has me confused.
The code edited in the AppEditorWindow is in an `AppPublishedEvent` handler method. This should not get called when the app editor is closed. This code is specifically for the case when a user opens an app for editing, clicks back into the app window, publishes the app they just edited.

The change added to line 257 of the presenter is simply a breaking change. If I open any app for editing, make a small change, try to close the window, then click `Cancel` on the save prompt. The `appTemplate` reference is now nulled out and will cause other NPEs during other operations, like trying to save.


This single line change is the only important fix that excludes *.cache.js.gz files


@Khelek приватные методы в контроллерах...фу-фу-фу. И вынесешь толком никуда ж.


Having each caller pull out the `.Name` and `.Output` is a little awkward, but I couldn't figure out how else to do it.

 * Tried an interface, but they can't abstract over fields
 * Tried a type switch, but (a) I couldn't get it to work and (b) it felt hairy

Suggestions welcome


Так делать не стоит)


someone -- @Mumfrey i think -- said that wasn't necessary


delete


Yeah I know lens helping me. Thanks for looking out. You could possibly
help me push these changes cus I can't get them to push. They are all
changed locally. Pm me please
 On Mar 2, 2015 2:02 PM, "CrackerTeg" <notifications@github.com> wrote:

> This ain't gonna work as is.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BrokenOs/device_asus_grouper/commit/ef104fc1d7214cdcb5859a205bd67cf050110f0b#commitcomment-9991756>
> .
>


Hi,
to be honest I solved this problem months ago - although the module worked only on the homepage of my CUSTOM theme - simply by adding the following lines to my blockfacebook.php:

	public function hookFooter()
	{
		return $this->hookDisplayHome();
	}

Now after latest PrestaShop update from v1.6.0.11 to 1.6.0.13 the above method doesn't work anymore and I don't know how to fix it, so any suggestions are more than welcome! ;)

Thanks!


@Khelek  а что делает ```as: :type``` ?


Should I be naming this with a private type like `instanceStateReader` or something?


delete commented-out code


this should be ```if i > size or j > size: raise IndexError


There should be an `assert` here showing `var c` is still === 1


I think leaving this comment in would be helpful.  Other than that, LGTM


delete comment


Да ну
```
    for(int i = 0; i < field.length; i++){
           for(int j = 0; j < field.length; j++){
               System.out.print(field[i][j]);
           }
           System.out.println();
       }
```


Ну могу разнести в 2 совсем отдельных класса)


testing II...


Still needs additional copyright line and "portions of" text


`var d` is unused below, can be removed


Yeah it is the same thing. Try it out.
```java
   public static void main (String [] arg){
      int a = 7;
      int b = 5;
      double result = (double)a/b;

      System.out.println("Result is " + result);
   }
```


nit: delete stray space


потому что мне нужно вывести не 110000010,а 11\n000\n010


Hi @dannon , this is only a partial fix, see https://github.com/andrewjrobinson/galaxy/commit/2288100ac73e050bd1fea9cafb38fc8bd5e4acdd


you can replace the comment with a docstring:

```
def access(self, i, j):
  """accessing value at i,j"""
```


И сделать ещё хуже, ну уж нет


This works for = and != but not for < and >


() are unneeded


delete


Is doubling necessary? We're going to need some other plan than simply increasing memory soon, but I'm ok with this for now.


probably trace is better for these


Is there a specific reason for alphabetical order?


хм
ну,видимо,я случайно сама это пофиксила  и не заметила х) щас переделаю


Hello,

I just upgraded to Electrum 2.0 from https://electrum.org/beta/
and I think this commit is the reason my console gets spammed multiple times per second
with this over and over again:

Without Trezor in watchonly mode:
>Could not connect to your Trezor. Please verify the cable is connected and that no other app is using it.
>cannot get next account
>Could not connect to your Trezor. Please verify the cable is connected and that no other app is using it.
>cannot get next account
>Could not connect to your Trezor. Please verify the cable is connected and that no other app is >using it.
>cannot get next account

With Trezor connected:
>cannot get next account
>cannot get next account
>cannot get next account
>cannot get next account
>cannot get next account


`var d` unused again


add comment above this line `# figure out how much padding to add based on # of digits in largest number`


In arm64-dev-ddb branch as fc4596405dcf5de8577ddea9bff1abeb6875a5fd


Here part of backtrace:
#0  0x0909f84e in DB2DatabaseLoader::LoadStrings (this=0x80478a6, format=0x99a11b4 "nissiiiiiiiii", preparedStatement=1, locale=1, indexTable=@0xa159c34,
    stringPool=@0xa159c40) at /mnt/software/solaris/wow/TrinityCore_6_x/src/server/shared/DataStores/DB2StorageLoader.cpp:48
	x = Unhandled dwarf expression opcode 0x9f
0x0909f84e	48	    if (data)


Yes, 14ms seems reasonable. It needs some way of switching the resampler at runtime.


Давай погрузимся немножко в теорию и вспомним, зачем нужен класс.
Класс — это такая штука, которая содержит код, написанный один раз, но описывает разное поведение, которое зависит от состояния


nit: spacing


:+1: :heart_eyes_cat:


This is a commit comment ;)


Говорят, что turbolinks говноват и порой только хуже делает. Мб лучше без него пока( а вообще есть еще https://github.com/igor-alexandrov/wiselinks )


"""Base class that magic squares inherit from"""


Use primitive types instead of objects: `int[]`


The method has a default parameter and it actually works correctly as far as I can tell, there isn't an additional bugfix in that commit -- just more refactoring.  I actually want to overhaul the debug flag completely -- we should just use appropriate loglevels for debugging and not have this extra flag IMO.


missing pmap_extract you mean?


I would prefer this to be pcb_elr, but don't care strongly enough to hold the patch up.


Or an actual object with 4 explicit fields, instead of having to remember that index `2` means _matches phenotypes but not genes_.


warum hann ich das gemacht???


I hope there is such a preference like you can set the numSeconds for SamplePreview instead of reading the data from sm/ssc files.


Посмотри на вызовы методов, везде есть
```java
int[][] field
```
тебе не кажется это странным?


Fully updated. The one on top returned issues while sorting, plus problem when the value was Unlimited or other text value. It work with the latest dataTables 1.10.5

```
$.fn.dataTableExt.aTypes.unshift(
	function (sData) {
		if (/^\d{1,3}[\.]\d{1,3}[\.]\d{1,3}[\.]\d{1,3}$/.test(sData)) {
			return 'ip-address';
		}
		return null;
	}
);

$.fn.dataTable.ext.type.detect.unshift(
	function (sData) {
		if (/((\d+(\s+)|\d+\.\d+(\s+)))(TB|GB|MB|KB|Byte|Bytes|ГБ|МБ|КБ|Байт)|(Unlimited|Ubegrenset|Nielimitowane|Ilimitado|无限制|No Limit)/i.test(sData)) {
			return 'file-size';
		}
		return null;
	}
);

$.fn.extend(jQuery.fn.dataTableExt.oSort, {
	"file-size-pre": function (a) {
		var x = a.match(/<label[^>]*>([\s\S]*?)<\/label>/)[1].match(/(\+|-)?((\d+(\.\d+)?)|(\.\d+))/);
		x && (x = x[0]);
		return a.match(/TB/i) ? (x * 1024 * 1024 * 1024 * 1024) : a.match(/GB/i) ? (x * 1024 * 1024 * 1024) : a.match(/MB/i) ? (x * 1024 * 1024) : a.match(/kB/i) ? (x * 1024) : 1;
	},
	"file-size-asc": function (a, b) {
		return ((a < b) ? -1 : ((a > b) ? 1 : 0));
	},
	"file-size-desc": function (a, b) {
		return ((a < b) ? 1 : ((a > b) ? -1 : 0));
	}
});

```


I'm a bit torn on this one, I think it might better to provide a Vagrantfile with ansible integration and rely on the ansible provisioner for the integration.  That way we could take advantage of the ansible.groups configuration instead of relying on hostname comparisons.

If there is another way to attach some type of 'group' or 'tag' metadata to a vagrant host, I could see using that as well.


these three lines aren't being used...delete them


any particular reason for IIFE args `(1,1)` here? There are 4 args, each assigned-to immediately, so I would expect either `()` or `(1,1,1,1)` for args


Ran in Unity 4 and checked console... it ran perfectly, however, priority in region types should be redrawn due to the laws of entropy.
Also, region types array may want to be extended for more available game variety, 24 region types seems reasonable, especially since continuously repeated regions occurred at 8 region types.
Lastly, water should be excluded from the region type array, water should be the default tile not a random tile.

Overall, the code is missing all in-game instantiate code as of now... I intend to not only instantiate the region tiles, randomly, but also instantiate border segments to all tiles bordering water, beaches essentially.


General question, you prefer this extra initiator implementation for the sake of separating `configurationValues.containsKey( OgmProperties.ERROR_HANDLER )` from `GridDialectInitiator`?
Provided `invocationCollector` is pushed all over the place, I'm not certain that "separation" brings much value?

Thoughts?


These don't resolve on Mac OS X or Windows? What about dmi -> bios -> release_date?


This does not seem to work.

The observatory ID is only passed in when user is non-admin, then the _observatoryId private value is updated in a loop and thus is always the value of the last observatory in the list at render time.


@kalashnikovisme метод для пути,  type_admin_trash_index_path(resource_type)


how about `~/(dog|fox)/g` here? regex literals are cute!


see my comment in the other file...you can use multiline strings for this


double space before `For example`


I think this is a matter of style that we need to agree on.  Given the comment below:
```
/* Test classification of a value based on some training data */
```
should this really be the test description:
```
it('correctly classifies a value based on training data', ...
```
My preference is actually for the latter for a couple of reason:

1. The test description is clear and shows up in our tooling results
1. We keep it dry and eliminate comments that can be expressed in the code

But interested in @sbyrnes thoughts.


You must guarantee that `errorHandler.onFlush()` never raises an exception, otherwise, you need to wrap it in a try / catch as well to be sure `invocationCollector.finishFlushCycle()` is called.


lol


`@Overwrite` is necessary for any method which is *obfuscated* in the target (the purpose of the `@Overwrite` annotation is to signal to the annotation processor that a method is intended to overwrite a target method and must be handled by the obfuscator) so @simon816 is correct, `@Overwrite` is required for *this* method because it is obfuscated.


IRC is great and very happy we have it.  These are just the main resources,
in particular the ones where core devs hang out all the time.

On Sun, Mar 1, 2015 at 1:57 PM, Rishi Goomar <notifications@github.com>
wrote:

> Why remove the IRC channel?It's still an active channel with people
> constantly helping each other out.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/meteor/meteor/commit/13e98f5a4ad85b6caf5dc3778f3e29aa3c500f30#commitcomment-9976804>
> .
>


I don't know if there is an official policy on this, bit I would prefer
that hardcoded paths and filenames are strictly for compatibility with
legacy formats and other programs only. Is there another sim that looks for
this file? If not, it should be a tag in the .SSC (isn't there one already?)
On Mar 2, 2015 1:18 PM, "sillybear" <notifications@github.com> wrote:

> I hope there is such a preference like you can set the numSeconds for
> SamplePreview instead of reading the data from sm/ssc files.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stepmania/stepmania/commit/9381276fd3313d8ebde4718c4c05907ba69062da#commitcomment-9992105>
> .
>


virtual bool triggerable(const ServerPlayer *target) const{
+        QList<ServerPlayer *> players = target->getRoom()->getAllPlayers();
+        foreach (ServerPlayer *p, players) {
+            if (p->isWounded())
+                return TriggerSkill:Triggerable(target)
+        }


There will be multiple it() tests there including it('correctly handles empty input') and it('correctly fails to classify invalid data'). The comment is meant to explain the entire describe block.

Another alternative is to make the describe(text) text more explicit but that will convolute the test output.


is there a way to add a dependency that's conditional based on the spec/features? or would these each need to be a separaate package?


While I agree with you, I think explicit type instantiation makes for more readable code which would be important for educating new developers.


Fixed a mistake I made when storing results, as they would overwrite warnings.

![Fixed1](http://i.imgur.com/RZkKoXV.png)
Build summary now reports the proper number of errors, warnings, and passes
![Fixed2](http://i.imgur.com/h7p2vgx.png)


75127368_DCFSEC (mjwitte) - x86_64-MacOS-10.9-clang: OK (1613 of 1619 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


@kalashnikovisme считаю, что оправдано в данном случае - у тебя иначе тупо код повторялся по всему файлу, что куда более фу. И в чем проблема куда-то вынести?


What does `OperationType` brings in your mind vs `instanceof InsertOrUpdateTuple`?


Returning false here cancels the form submit event, which prevents the page from refreshing and thus clearing the appended list items.  Maybe we should research alternatives to a form, because this seems like an improper way to use one.


Ну не особо,если честно.
Я же над ним функции применяю


r=mbrubeck (no changes except `basic.list` rebase)


I wonder why you didn't submit a PR for this, I would make it extensible by adding a `cookieStore` option to the `localeConf` and then doing

```js
if (localeConf.persistSelection) {
  if (localeConf.cookieStore && $injector.has(localeConf.cookieStore) {
    cookieStore = $injector.get(localeConf.cookieStore);
  } else if (localeConf.has('$cookieStore')) {
    cookieStore = $injector.get('$cookieStore);
  }
}
```


i <3 seeing that kind of commits :)


Add a newline before `disks:` for consistency.


saw approval from mbrubeck
at https://github.com/pcwalton/servo/commit/39497c5ca4b6e7dde1f71a336d4bcf57a055041a


merging pcwalton/servo/text-shadow = 39497c5c into auto


pcwalton/servo/text-shadow = 39497c5c merged ok, testing candidate = 47f2e836


This is most likely due to the subscription you are using...  eventually we plan on adding support for setting/managing the repos (at least for enterprise), but for now one the of bootstrap steps should be to disable all repos and only enable the openshift repos.

I updated the README_OSE to reflect this: https://github.com/detiber/openshift-ansible/blob/enterprise2/README_OSE.md#known-issues


This test is too big, and I'm not sure what-all it's testing.


nit: spacing


How will new people discover the IRC channel though? Most projects that have an IRC channel list it out on their websites because of how big of an impact some of the discussion in there can have and loads of developers use it.


That's a neat trick!


python has built-in string formatting; this can just be `outstr += '<td>%d</td>' % + self.mySquare.access(i,j)`


@a-detiste Can you update the French po file? I plan to release 1.1.0 shortly...


Ah, it slipped my mind that we restrict data bag searches to a single data bag.


Falls back to the primary interface's domain if not set in the registry.


```
outstr += """
    </table>
  </body>
</html>
"""


So this conflicts with batching, I guess in the current code the invocation collection takes precedence.
One way or another we will need for them not to compete but both work.


Erm, sorry but what? R-value reference to lambda? How does it even work, lambdas don't have types...


Was this actually blocking you? Can you rebase it out of this commit and submit it to master? Can you also search for other remaining SAKs across the code base and fix them all. Also, I think you can just delete these properties rather than emptying them.


I don't believe there would be any advantage to putting the filename in a tag in the simfile.  It would just add more code to NotesLoader and require adding a way to set it in edit mode.
Also, according to a comment from @ZeroTheSavior on #488, it actually is common for bms files to have a preview.ogg.


Yes


If you use `user_sudo` this shouldn't be necessary as everything should run in bash in the context of the user. Nothing should run as root (which this script runs as).


letra minuscula


delete


Что?


Seems weird that your username is hardcoded in here.


I was wondering about the incorrect `star2html` stuff that ends up in `componentset.xml` so thanks for explaining that. Regarding everything other than `star2html` some of the obsolete applications are a dump of the source code with no attempt at using the new build system. Some are applications that were ported but later moved to obsolete (e.g. `kaprh`). Others are applications that I'm interested in keeping active despite us not officially wanting to support them (`jcmtdr` being the obvious one as it's the only way someone could reduce old single-pixel continuum data from the JCMT archive -- assuming they could obtain the GSD files).

I'll revert it and fix up the star2html component name so it doesn't get in the way.


I removed it because it wasn't really an invariant - in the past we could have both localGrantsAccessToRemote==true and ignoringRemoteUserRequest==true if ignoringRemoteUserRequest was set to true after localGrantsAccessToRemote was set to true.


well you know… I wanna be super specific to avoid any issues with revisions.

I'm beginning this Data Science course https://www.coursera.org/specialization/jhudatascience/1


probably better call it `errorHandlerService` to avoid confusion


nit: spacing


Это ООП, а не функциональное программирование


nit: delete


Raindrop added support for #PREVIEW in BMS files: https://github.com/zardoru/raindrop/commit/ddf56063f14b7b9f9a99a8e8f3c5207b547ff495

I believe LunarBeat also supports the #PREVIEW tag.

Relevant quote:
> After a talk with raindrop developers, I've decided to associate the file with a #PREVIEW tag that it's not currently supported by any BMS reader.
> At any rate, [Lunatic Rave 2] simply ignores the tag so it doesn't cause parsing errors.
> If you ever want to implement the nonstandard #PREVIEW, it works pretty much like any #WAVXX tag:
> `#PREVIEW <filename>`
> Where `<filename>` is the path to the preview file relative to the BMS file's containing folder."


I think we should have a flag to toggle this setting (and others like it that wouldn't be used in production environments) openshift_devel or something similar would probably work.

I would move it into the openshift_common role as well, the base_os role will probably not be used in the future, since we wouldn't want to publish it to Galaxy.  It is more of a helper role for OpenShift Ops, I just haven't finished removing the remaining dependencies on the role yet.


When trying the 0.13-compat branch, Firefox gives me the following error just for bundling the react-router on my vendors.js with browserify/reactify (I havent even used the react-router on the app yet):

```SyntaxError: class is a reserved identifier```

The error points to this line.


See http://www.adequatelygood.com/JavaScript-Module-Pattern-In-Depth.html Module Export section


-mtune=cortex-a15
Why???
should be -a8


I think this is unused and you can delete


Its an object, you'd call it like

Split({numGroups: 3, numPictures: 4, ...})


Do you want one there (because there are 2 spaces).  But if not, there are other places that use 2 spaces.  I'm confused.


Kk


Agreed, maybe have a validate module?


at term, only for non transactional datastores, or should it be offered event for tx ones?


Oh, and `starbench` and `ccdbig` were used to benchmark the new HDF5 HDS library: http://dx.doi.org/10.1016/j.ascom.2015.02.003


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/893
failure: http://build.servo.org/builders/linux2/builds/891
failure: http://build.servo.org/builders/mac1/builds/1108
failure: http://build.servo.org/builders/mac2/builds/1108
failure: http://build.servo.org/builders/gonk/builds/79


No, if one has a `<meta charset="foobar"/>` page, it is downloaded by webkit, converted to UTF-16 from `foobar` encoding and then converted to `utf-8` by splash, but the `<meta .../>` element is unchanged, so the next time a browser will try to show it, it may show incorrect characters.

This seems like a bug in Splash itself, but you won't see it until you try to open the resulting html in a browser that interprets `meta` (which realistically may never happen in real life).  In this benchmark suite, the benchmarked instance of Splash will be that browser and it is almost certainly will be run. During these runs downloaded pages will be consistent with each other, but will be different from their online counterparts.


the above ten lines can be reduced to:

```
  newrow = (self.currow - 1) % self.size
  newcol = (self.curcol - 1) % self.size
```

note that I don't have to separately initialize the variable before setting it to a value


Thank you


Haha, whoops, nice catch. That should be using the Github variable. I'll make publish a fix for this right now.


In the future, I believe you can use ```map``` in order to get rid of having to set and reset ```login_count``` every time.


Okay, in that case, LGTM


LGTM


At the moment there are no optional dependencies, but it's what I'm working on right now.  You would be able to do something like this:

    depends_on('atlas', when='+atlas')
or:
    depends_on('atlas@3.5.0', when='@3.10.2+atlas')

Then if the user does:

    spack install lapack+atlas

They get the version that links in atlas.  Currently, though, you either depend on something or you don't, so you'd need a separate package.  I'm suggesting that we integrate a lapack that depends on atlas into the develop branch, and I'll make atlas optional (per the above description) later.


Also, my detection of meta charset is incomplete, another option according to [this SO question](http://stackoverflow.com/questions/4696499/meta-charset-utf-8-vs-meta-http-equiv-content-type) is

```html
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
```


thank you


CI build says:

E108: No such variable: "g:callback_stderr"

Are you able to run these tests yourself?


Lovely. Awesome generator btw


@Rio517 This line raises warning:
```
DEPRECATION WARNING: The configuration option `config.serve_static_assets` has been renamed to `config.serve_static_files`
```


I kind of missed it but you changed the behavior here?


У меня весь вывод на консоль через while, потому что иначе выводится некрасиво, через for у меня вывести так не получается


Still noticing a bug with sos


I'd structure the above lines as:

```
  # if the square we're trying to move to is already occupied, use the square
  # directly below the current one
  if self.mySquare.access(newrow, newcol) != 0:
    newrow = (self.currow + 1) % self.size
    newcol = self.curcol

  self.currow = newrow
  self.curcol = newcol
```


Ну передавать-то мне нужно входные параметры


missed sort at 1575


@michaelwehrley Do you mean to say that I should store them in a map, then get iterate through the map for the count?


I'd structure the above lines (from 112) as:

```
  # if the square we're trying to move to is already occupied, use the square
  # directly below the current one
  if self.mySquare.access(newrow, newcol) != 0:
    newrow = (self.currow + 1) % self.size
    newcol = self.curcol

  self.currow = newrow
  self.curcol = newcol
  self.curnum += 1
```


Glad you like it!

Fix published `generator-p@1.0.5`.


Currently matches everything except multiple commas (multiple decimals intentionally not allowed)

### Matches
1000
1,000
-5.364
46347
5
34
5,000,000
54,540,543

### Doesn't Match
3,000,0
3,000,00
4,000,000,000


@Khelek уберём тогда, пока его. Если понадобится он или любая его альтернатива - вернём.


I think you don't need to define these variables here...let subclasses define them


Overlay version of map added and installed by default to assis in asset placement and test for compatability with player/npcmonster sprites. (Looks a bit tight so far.) >> Remove '-ol' from the .png in line 14 of preloader.js to show map without collision overlay.


In Source/Core/VideoCommon/MetroidVR.cpp, line 304, you have this:

```
...
            }
        }
        else if (l = -1570)
        {
            // actually we know it is the menu's text
...
```
Is that intended to be assignment? Everywhere else it's equality. I only spotted it because GCC spat out a warning when compiling it, 'suggesting parenthesis'.


yay


thanks man


> Was this actually blocking you?

No. In the past, I've mostly removed noise like this but I learned to eventually commit them because they will show up again and again.

> Can you rebase it out of this PR and submit it to master?

Will do.


# place the first number, then keep calling moveNext()


The main goal of using openshift_public_ip and openshift_public_ips is that we are expecting externally accessible ips, so hosts in aws, gce, openstack, etc. will return an internal IP using ansible_default_ipv4.address and the rsync commands will fail.

That said, we can go ahead and set openshift_public_ip as a default variable in openshift_common, and require that the inventory configuration or playbook modifications for a cloud provider must set openshift_public_ip to the proper externally routable address.


What about the serializers? Should they be moved to this same file too or just leave them in serializers.py?


Ok


Ice creams and toppings can have flavors. Works for me :-)


I wonder if there is a need for a invocationCollector.beingProcessed

```
invocationCollector.beingProcessed(...)
super.insertOrUpdateTuple( key, tuple, tupleContext );
invocationCollector.add( new InsertOrUpdateTupleImpl( key, tuple ) );
```

The being process is a maybe applied, maybe not case.


Thanks!


Ok, thanks for this tip. I changed that, and modified the code for guessing versions, as well as provided the user a mechanism to replace the tag identifying regex. Look it over if you get some time, and let me know what you think.


Kirill missed so much the commit bombs ;)


aren't all of these squares already 0? Why are you doing this?


Resolves #3 by editing the HTML to provide a general use case for when to fork a repository


Do we need a string hash here instead of just hashing by text?


@cagryInside Agreed, let's change this so its only reported when the region changes.


I can't agree, it's like saying one should instantiate string by using `new String(<explicit bytes>)` for educational purposes. Quite a lot of people coming from JS or AS3 are used to RegExp literals and they will find this nice. As for readablity, actually explicit `EReg` instantiation may confuse novice people even more, because they have to deal with string escaping.


There shouldn't be double spaces. If you find them anywhere else feel free to remove them.


This doesn't scale well, you're explicitly listing some of the things that HPO has, while this class is supposed to be generic for any ontology. Plus, there might be other fields in HPO. Can't you list all the fields that the term actually has? `this.doc.entrySet()` or `this.doc.iterator()` gives you that.


But I'll leave the decision to @Simn


That's not good, you need to write tests...


Sorry for making a pig's breakfast out of this :)