TeamCity OsmSharp :: GitHub - OsmSharp - PullRequests [Build 171](http://build.osmsharp.com:8080/viewLog.html?buildId=4605&buildTypeId=OsmSharp_GitHubOsmSharpPullrequests) is now running


And that's why setting to NULL is usually the safe move X(. Good catch all.


Does that change the syntax highlighting? I did a quick preview and it looked the same to me.


how do i git??? ? ???? ??


Perhaps add a sentence here to say and briefly justify why Calico only uses security groups.


Perfect.


It seems like *camelCase* doesn't fit between other json attributes. I would go with:

		out.Set("registry_name",registryName)
		out.Set("index_name",repoInfo.Index.Name)


a


Could we provide an example here?  Would that be useful?


Oh? This is the file I've always changed. I correct this tonight.


:dancers:


Been busy i will check the size and make the necessary changes.. Thanks


This was a really solid start.


Hypothesis:
Timeout changed from 60 to 70 seconds because AlertTest.java takes more than 60 seconds to run and will time out if all the tests have not finished by 60 seconds. There are many tests in AlertTest.java and it takes longer than 60 seconds on both mine and and Thanh's machine to run.


`cmpSearchResults` needs to be modified as well. First by `index_name` then by `registry_name` and then the rest. `cmpRepoNamesByIndexName` won't be needed anymore.


TeamCity OsmSharp :: GitHub - OsmSharp - PullRequests [Build 4.3.0.171](http://build.osmsharp.com:8080/viewLog.html?buildId=4605&buildTypeId=OsmSharp_GitHubOsmSharpPullrequests) outcome was **FAILURE**
Summary: Tests failed: 23 (23 new), passed: 444 Build time: 0:0:0
### Failed tests
```
OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceAgainstReference: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  8.0556235395279892d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceAgainstReferenceBig: Test(s) failed. System.Exception : Exception of type 'System.Exception' was thrown.
   at OsmSharp.Routing.Graph.DirectedGraph`1.RemoveEdge(UInt32 vertex1, UInt32 vertex2, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\DirectedGraph.cs:line 519
   at OsmSharp.Routing.Graph.RouterDataSource`1.RemoveEdge(UInt32 from, UInt32 to, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\RouterDataSource.cs:line 418

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceAgainstReferenceRealNetwork: Test(s) failed. System.Exception : Exception of type 'System.Exception' was thrown.
   at OsmSharp.Routing.Graph.DirectedGraph`1.RemoveEdge(UInt32 vertex1, UInt32 vertex2, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\DirectedGraph.cs:line 519
   at OsmSharp.Routing.Graph.RouterDataSource`1.RemoveEdge(UInt32 from, UInt32 to, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\RouterDataSource.cs:line 418

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceBig: Test(s) failed. System.Exception : Exception of type 'System.Exception' was thrown.
   at OsmSharp.Routing.Graph.DirectedGraph`1.RemoveEdge(UInt32 vertex1, UInt32 vertex2, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\DirectedGraph.cs:line 519
   at OsmSharp.Routing.Graph.RouterDataSource`1.RemoveEdge(UInt32 from, UInt32 to, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\RouterDataSource.cs:line 418

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceOneWayAgainstReference: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  8.0556235395279892d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceRegression1: Test(s) failed.   Expected: 0.0d +/- 0.00010000000000000001d
  But was:  34.411609158456571d
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceRegression2: Test(s) failed. System.Exception : Exception of type 'System.Exception' was thrown.
   at OsmSharp.Routing.Graph.DirectedGraph`1.RemoveEdge(UInt32 vertex1, UInt32 vertex2, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\DirectedGraph.cs:line 519
   at OsmSharp.Routing.Graph.RouterDataSource`1.RemoveEdge(UInt32 from, UInt32 to, TEdgeData data) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Routing\Graph\RouterDataSource.cs:line 418

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceComparisonTests.TestCHEdgeDifferenceRegression2Regression2: Test(s) failed. System.NullReferenceException : Object reference not set to an instance of an object.
   at OsmSharp.Test.Unittests.Routing.RoutingComparisonTestsBase.CompareRoutes(Route reference, Route route) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Test.UnitTests\Routing\RoutingComparisonTestsBase.cs:line 204
   at OsmSharp.Test.Unittests.Routing.RoutingComparisonTestsBase.TestCompareOne(String embeddedName, Boolean contract, GeoCoordinate from, GeoCoordinate to) in c:\14K-SERVER-ROOT\TeamCity\buildAgent3\work\927bffbe08a03474\OsmSharp.Test.UnitTests\Routing\RoutingComparisonTestsBase.cs:line 113

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceRoutingTest.TestCHEdgeDifferenceShortest3: Test(s) failed.   Expected: 6
  But was:  5
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceRoutingTest.TestCHEdgeDifferenceShortest4: Test(s) failed.   Expected: 6
  But was:  5
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.CH.CHEdgeDifferenceRoutingTest.TestCHEdgeDifferenceShortest5: Test(s) failed.   Expected: 7
  But was:  4
   at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)

##### there are 13 more failed tests, see build details
```


All looks good - thanks.


Marc:
It turns out that gcc-4.8 as built for the Debian derivative on Raspberry Pi does not enable strict aliasing by default.  (It's probably an error, but still ...)

I recommend that if --disable-gnu-gcc-no-strict-aliasing is part of the configuration, then -fstrict-aliasing be added explicitly to the command line.


This code needs more work, no switch case or unecessary if else if's
:-1:
Here is an example
```c
int main(void){
	//temporally UART data holder
	uint8_t byte=0, blink=1;

	//initialize GPIO ports
	gpio_init();

	//Loop forever
	while(1)
	{
		if(blink) toggle_LEDS();
		if(data_available()){
			byte = uart_read();
			if(byte>47 && byte<58){	//numbers from 0 to 9 only
				display((char)byte);
				blink=0;
			}else if(byte==0x7e){	//a tilda(~) send microcontroller information
				display((char)0x00);
				sysinfo();
				blink=0;
			}else{					//new line character plus all others here
				display((char)0x00);
				blink=1;   //blink to show unsupported value
			}
		}
		delay();
	}
}
```


What is your secret? you are very quick.


Lint yr Javascript: http://blogs.telerik.com/kendoui/posts/13-07-09/protecting-your-mellow-with-javascript-linters

> JavaScript developers have a special relationship with a type of punishment that I like to call "closing bracket hell". You probably already know exactly what I'm talking about. It's when you have a block of JavaScript code and you cannot figure out where the last closing bracket or brace goes. JavaScript isn't analyzed by a compiler, so you can spend a lot of time banging your face on your desk until someone comes along and goes "Oh - it's right there", and then everything just jumps into place. ARRRGGGGG.


Değişikliği iyi farketmişsin, nasıl farkettiysen. Bende bunu yeni farkettim bu arada :)


Actually there is a badge for everything, it's an dynamic badge
[![Follow @gep13](https://img.shields.io/badge/Twitter-Follow%20%40gep13-blue.svg)](https://twitter.com/intent/follow?screen_name=gep13)
;)


TeamCity Akka.NET :: Akka.NET PR Build [Build 133](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=227&buildTypeId=AkkaNet_AkkaNetPrBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: xUnit failed for the following assemblies: D:\BuildAgent\work\49b164d63843fb4\src\core\Akka.Persistence.Tests\bin\Release\Akka.Persistence.Tests.dll   at Microsoft.FSharp.Core.Operators.FailWith[T](String message)   at Fake.XUnitHel... Build time: 00:09:47
### Failed tests
```
Akka.Persistence.Tests.dll: Akka.Persistence.Tests.GuaranteedDeliveryCrashSpec.GuaranteedDelivery_should_not_send_when_actor_crashes: <no details avaliable>

```


You should check equality mod 2 here instead of ordinary one.


Congrats! :+1:


What the?


Please pull all this code into a separate *private* function to make this clearer.


These tags are breaking build? Because with it formatted like entities (escaped) the content showing in messages are presenting tags. This is why I changed to unescaped version on my last commit. Attached screenshot showing last build with entities escaped. How can we proceed to have the right behaviour? CM version use tags unescaped.
![2015-03-11 16 18 10](https://cloud.githubusercontent.com/assets/1291373/6600978/90339854-c7f1-11e4-909c-80014e4826fa.png)


whitespace party!


Here, I think, beliefs from previous iteration should be compared with calculated beliefs and not vectors of errors.


Looks like the UUID for Xcode 6.2 (6C131e) is "A16FF353-8441-459E-A50C-B071F53F51B7"


This line should not change in the original `fromSource` function.
Instead do this only inside the extra function I suggested above.


So close... :disappointed:

`validates` is a method, not a hash key, so it should have looked like this:

```ruby
validates :title, presence: true
validates :embed_code, presence: true
```

Same in your other models...


Did you mean to include these console.log statements?


Not sure it matters, but Daemon is misspelled :smile:


Pull out `findComment` to script level so it can be properly optimized.
As it is now it'll created again for each line.
However this code runs a lot and thus things will be slow.


Test


text needs to be "green creatures on the battlefield" and "red creatures on the battlefield"


Ah! Sure thing! Was was under the impression you didn't want a method added. Give me a few minutes and I'll update.


I got around to fixing the issue (I had to delete the local repo, re init it locally and pull from the remote repo here), so I should be able to do things now :)


How come?


Please change to `if (!~line.indexOf('sourceMappingURL=data:'))`
I know it's considered cryptic by some but IMO expresses the intent clearer.


Hi I found this repo and was wondering what has happened to the cssdoc.net site and spec and everything regarding it. ¿Do you have an idea? I think it was a good thing having css documentation... there was no other way to contact you so I'm posting this comment :D


This is a feature flag is pulled in via the 'FEATURES' dictionary take a look at line 237.  So you don't need it here.


Just a nitpick:

    registryName := repoInfo.Index.Name
    if RepositoryNameHasIndex(result.Name) {
        registryName, result.Name = splitReposName(result.Name, false)
    }

gets rid of `resultName` and puts `resultName` out of function-wide variable declarations.


What do you think about catching `std::exception const&` instead of `...`?


Could you public your latest version on NPM?


Thanks totally matters! :) Updated.


The generated rule text should be identically, so no need to set it here.


Should this have also included a change from `val<2` to `val<GPIO_MIN` ? Or is GPIO_MIN intended for some other future purpose?


Please remove all whitespace only changes like this one.
We can clean those up in a separate PR if you feel strongly about this.


lol


ここのパッチを頂きました。
http://anago.2ch.net/test/read.cgi/software/1425420543/162


Yes it is, The ClangFormat-Xcode can not work after my Xcode updated today, so I make it work by adding this UUID to plist.


unpersistent -> nonpersistent?


They should fail, I haven't gotten `internalClick.  How did you get the tests to run? For the life of me I can't get the overrides to stick properly.


You should fall back to the default in common.py which gets pulled in to this module at the top. Take a look at line 512 of this file for an example.
`PERFORMANCE_GRAPHITE_URL = ENV_TOKENS.get('PERFORMANCE_GRAPHITE_URL', PERFORMANCE_GRAPHITE_URL)`

Same with the one below on line 530.


But you agree, or do you think this makes no sense?


Here it's better to combine the effects in one ability and set the correct text for the second effect.


Reload works for me (without changing config):
> root:/# ps|grep collect
> 7706 root     21628 S    /usr/sbin/collectd
> root:/# /etc/init.d/luci_statistics reload
> configfile: stat (/etc/collectd/conf.d) failed: No such file or directory
> rrdtool plugin: RRASingle = true: creating only AVERAGE RRAs
> root:/# ps|grep collect
> 7966 root     21604 S    /usr/sbin/collectd


What am I supposed to fill here?


Yep, this was the UUID for the 6.2 betas, there's always a new one for the final release.


r+


I think it should be "could not be detected".


Good job finding `html_safe`.


sdfasdfasdf


lets just use //

for instance

`
iframe(src="//ghbtns.com/github-btn.html?user=mojotech&repo=social-builder&type=watch&count=true", allowtransparency="true", frameborder="0", scrolling="0", width="110", height="20")
`


Wouldn't it be better to store the ControlName in the Event that is returned from ````buildForProxy````? Note that the ````orderIndex```` has nothing to do with the ````index```` in a ControlName, so we probably should leave that out to avoid confusion.


+1 local merge tested, this looks good to go if there’s nothing more to come.


このコミットは無かったことになりました


// plz


Ahh, it may not.  I thought it was a markdown code convention.  Whoops.


I usually put `ng-disabled` attribute on button, but this works as well :)


Done.


该接口暂时无法提供缩略图。


Getting the cluster Id does not depend on the rest of the parsing, no need to repeat that logic.

Also you still don't handle the case of different port numbers:  host1:2181,host1:2182


Use `<button type="submit">Login</button>` here, see comment on https://github.com/libreoss/liberator-web-frontend/pull/24/files


Yes. It does elsewhere (the vc4 tree), and it did here once, but after inadvisedly changing the line endings and whitespace to something sensible I ended up recreating the patch.

A fix is imminent.


@Aokromes http://prntscr.com/6fhnqq
rev :https://github.com/TrinityCore/TrinityCore/commit/22403121fe9c762c82dc32913aeba46a7e76a004


Brent -- I agree 100% with everything in your post. We do all of this in bcbio upstream so it doesn't change a lot from our side practically but glad to see it being tackled more generally in GEMINI.


Fixed here: https://github.com/IonicaBizau/social-builder/commit/a924b7d6844257b292506e0965399dd9b0006d52


Once you have addressed the remaining issues, squash and reference ticket.


Comments aren't indented properly here.


I counted 148, not 140


adding back the BOM


What about pypy?


Fixed on next PR.


Not my code, fixed on next PR.


а почему sell, не city?


Update to dataset.xhtml for "Map Data" and "Explore" buttons
/cc @mheppler


I don't know if are aware, but I'm getting this error here:
**E/AndroidRuntime(22604): FATAL EXCEPTION: main
03-10 19:52:50.583: E/AndroidRuntime(22604): Process: com.android.settings, PID: 22604
03-10 19:52:50.583: E/AndroidRuntime(22604): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.settings/com.android.settings.SubSettings}: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.CharSequence[] android.preference.ListPreference.getEntryValues()' on a null object reference
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2329)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2391)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.app.ActivityThread.access$900(ActivityThread.java:147)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1296)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.os.Handler.dispatchMessage(Handler.java:102)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.os.Looper.loop(Looper.java:135)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.app.ActivityThread.main(ActivityThread.java:5256)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at java.lang.reflect.Method.invoke(Native Method)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at java.lang.reflect.Method.invoke(Method.java:372)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:898)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:693)
03-10 19:52:50.583: E/AndroidRuntime(22604): Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.CharSequence[] android.preference.ListPreference.getEntryValues()' on a null object reference
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at com.android.settings.ButtonSettings.onCreate(ButtonSettings.java:213)
03-10 19:52:50.583: E/AndroidRuntime(22604): 	at android.app.Fragment.performCreate(Fragment.java:2031)**


+1 to make it shorter if we can


Muss "der V8-Engine" heißen.


@Frytiks
```sql
SELECT COUNT(*) FROM `achievement_criteria_data` WHERE `criteria_id` IN (5597,5599,5600,6789,7408,7412,7415,7416,7418,7419,9058,9718,9719,9720,9721,10718,10878,10879,10881,10898,11238,11402,12562,12912,12999,13000,13001,13002,13003,13004,13005,13006,13007);
```


int(round(len(y) / 2))

->

len(y) // 2


ну и теперь в фабрику User можно добавить 3-и вида пользователя
и в features тестах проверить для них права


I don't believe it would be: it seems like a fairly simple concept. Do you disagree?


Why did I add it?


1: M111 unrecognized component name: docker


Shouldn't this be resized?


Maybe the second list should not be on the changelog.


This bit needs to come out if we are being strict about 'before 0'


return 32


There is something wrong with my network connection, I failed to publish a new version to NPM, I will retry tomorrow morning.


```xquery
declare function local:f($n) { if($n eq 0) then 42 else local:f($n - 1) }; local:f(100)
```
```
Improper use? Potential bug? Your feedback is welcome:
Contact: basex-talk@mailman.uni-konstanz.de
Version: BaseX 8.1 beta
Java: Oracle Corporation, 1.7.0_21
OS: Windows 8, amd64
Stack Trace:
java.lang.ArrayIndexOutOfBoundsException: 32
	at org.basex.query.var.QueryStack.set(QueryStack.java:112)
	at org.basex.query.QueryContext.set(QueryContext.java:769)
	at org.basex.query.func.StaticFunc.invValue(StaticFunc.java:191)
	at org.basex.query.func.FuncCall.invokeTail(FuncCall.java:123)
	at org.basex.query.func.FuncCall.value(FuncCall.java:60)
	...
```


Sent you a pull request for Prototypes (I won't get a chance to test it until we actually get there this week though)

As for Ohmna, I think we should go with what you suggested last night - checking the current zone events until we're on the "Defeat Dreadphage Ohmna" phase.
We don't have code that filters by that kind of thing yet though, do we?
I'll sort that out.


Reordering doesnt count brah


good call, i'll add that


Je ne vois pas où j'ai foiré


Ok, removed the 2nd run and put 2 jobs. Reasonably fast now.


Je vais check où est le soucis


*journal-id-type='publisher-id'* passou a ser obrigatório


s/these/which


D'accord je dois changer, dans la bdd c'est écrit activities donc voila ...


regarde la ligne 22


Un nom de model est toujours au singulier


Informação redundante (a definição "Atributos obrigatórios" já declara essa informação)


Really useful firebase blog post about firebase structure: https://www.firebase.com/blog/2013-04-12-denormalizing-is-normal.html


s/instead/on the host/
(Don't need to say both 'rather' and 'instead' in the same sentence.)
Add "and set the container's IPv6 address directly".


Erro sintático de rst. Deve ser **.. note:: **


Je change cela après la réunion


Preferowałbym nazwę modułu "code_input" czy coś w ten deseń. codemirror jest jakby nazwą własną


je suis pas sûre que ça marche ça ...


doc should say 'ArticlesCourses entry'


to się robi przez define(["cm/lib/...", "..."], function() { ... }")


tak samo, nazwałbym moduł nie d3js, a visualization czy coś


+1000 :+1:


Je vais bien regarde quand je serai chez moi.
Merci de la notification.


bez tabów proszę - rozjeżdża się


`Array<number>` :D


I'll add comments about this. In practice I guess that won't happen, as it's just while we're in createTcpListeners() that the copy constructor is going to be called.


(see above)


I'll fold it in.


J'ai regarde sur le net et on me dit que oui.
J'ai pas fait une mini function du genre start_at < end_at.


Penso que essa nota deveria ser movida para o elemento *sig-block*


Yeah, the tl;dr is any calculated center/centroid of these polygons won't actually correspond to the actual school location. We'd probably want to center the map around this point, but wouldn't want to actually show the school location as a point (if that makes sense).


Tu as testé ? Si oui, pas de problèmes dans ce cas


Reverted your tidy-up as it changed behaviour


Typo: *deve ser inserida uma informação...*


> I think this might have broken automatically expanding the menu to the current page, for all pages except Phobos.

You mean the normal pages, like this https://dlang.dawg.eu/hash-map.html?
Most likely the js change, will look at it later.


Wow amazing work.


the other thing here is that we'd probably only want the shopId once in the array..  but this should work for flat rates - this will need refactoring (soon) to accommodate rates that are calculated per product, as well as shipping rules, so I think we can just leave that because I'll be refactoring soon.


please use `.format` here instead of the old `%` formatting


Running "csslint:strict" (csslint) task
Linting assets/styles/viper.css...ERROR

Trzeba coś z tym zrobić, albo dodać wyjątek, albo ustawić jakiś tryb CSS3  czy coś. Dodaję to jako bug bo jest to do przemyślenia


You might forget discarding this.


please use temporary variables for the various parts :
bool isNewPictureIntent
bool isWifiChange
bool isWifiConnected
bool isListeningConfig

And add a mention about the Wifi listening in Readme.md


Ah, I see! Will add another commit later when I wake up, time for me to sleep for now haha :)


Fixed


It's probably worth adding a comment that you manually inlined the `@tuple.reverse!` call here.  If we need to sync with a newer version of Rubinius it'll make it easier to understand why there's a difference.


Excellent! Looks great. Thanks!


Don't think so. mam_SUITE doesn't use helpers from escalus_stanza and the namespace is hardcoded [there](https://github.com/esl/ejabberd_tests/blob/master/tests/mam_SUITE.erl#L1492).


Looks fine while I think it's a little bit sad we can't use Ogre only for rendering and update related stuff, as now we're mixing the SFML use with sound and FPS capping.
I'll test asap.


Na razie jest OK. Chociaż strona wciąż się scrolluje - będzie trzeba się z tym niebawem rozprawić. Okienko kodu też nie zajmuje 100% klienta. Fajny pomysł z tymi nalepkami do kolejnych komunikatów debugujących :)


@zeroedin-bill -- /Zi and /debug go together and cause symbols (pdb files) to be created for easier debugging.


O que é uma informação de etiqueta *<title>*?


wrapnij to wszystko w funkcję "sampleVisualization()" a kod inicjujący, którego nie wywalimy - do funkcji initD3(), czy coś


The first style is not accepted/promoted by PEP8 or pyflakes because flake8 complains about it. I don't like it because you have to move your eyes way back to the start of the line when trying to parse the parameters in your head.

I only use your other two referenced styles, whereas the middle one is a bit problematic since the second parameter `True` could be in a new line of its own. It depends on whether you accept multiple parameters in a line (in certain situations) or not. Usually, one parameter per line is the easiest [to read].
If the function name is too long so that there is not enough spaces for the parameters I fall back to the latter "newline after left parenthesis" style, which is also accepted by PEP8.

Regarding the need to manually indent, there is a setting for that in ST (`"indent_to_bracket": true`), but as I mentioned it's unfortunately inaccurate in some situations. I really need to fix that at some point.

Visual indentation (which this indent-to-left-parenthesis is called afaik) is especially useful for cases where you'd separate the parameters of a function call which is already a parameter or multi-line list comprehensions/generators.

I generally prefer to use visual indentation, e.g. for function calls where a parameter is a long string (including when said string gets formated with `%`) and for data structures such as tuples which are then used with the `%` format operator on strings, and the "newline after parentheses" style for multiple parameters. That are too long for the visual indentation style.

Examples for visual indentation:
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/converters/__init__.py#L147-L151
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/tinycsscheme/dumper.py#L55-L58
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/csscheme.py#L68-L75
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/tinycsscheme/dumper.py#L248-L250 (two parameters on one line here)
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/tinycsscheme/parser.py#L204-L206

Examples for "newline after left parenthesis":
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/converters/__init__.py#L205-L207
https://github.com/SublimeText/InactivePanes/blob/ca417aa6699432ffbbd716ea44e8d431a8d5818f/inactive_panes.py#L339-L343
https://github.com/SublimeText/InactivePanes/blob/ca417aa6699432ffbbd716ea44e8d431a8d5818f/inactive_panes.py#L430-L438

Mixed:
https://github.com/FichteFoll/CSScheme/blob/65583cbfc58eb4ffafb3177e4363522d56ba8a28/tinycsscheme/tests/test_dumper.py#L100-L122

Regarding line lengths, I usually stick with 80 for comments and docstrings but extend to 100 for code when 80 is not feasable, so I have two rulers visible and decide on the fly. Linting for line length is disabled.


Need to edit the index page as well.


what is this budueba.com service? where I can read more about it? Is its source on github somewhere?


This should be `container.Node != nil`.  I got a:

```
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x38 pc=0x405e6c]

goroutine 1 [running]:
main.getContainers(0xc208052080, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/jwilder/go/src/github.com/jwilder/docker-gen/docker_client.go:150 +0xc5c
main.generateFromContainers(0xc208052080)
	/home/jwilder/go/src/github.com/jwilder/docker-gen/docker-gen.go:158 +0x36
main.main()
	/home/jwilder/go/src/github.com/jwilder/docker-gen/docker-gen.go:396 +0x4dc
```


Looking at issue #4059, should we be setting the default requestTimeout to 120s? On line 164 of `documentation/manual/working/javaGuide/main/ws/JavaWS.md` it is stated to be none?


I can fix the text issues.  Can you give me an example of this combining effects into one ability?


Aw. Uncrafter broke? :( Favorite feature in VirtualPack.


Yep, just noticed that :D. Thanks!


Ok, thanks ;)


yeah I was doing it for debugging. Fixing it now


Exemplo mal formado: Apresenta a tag de fechamento ``</abstract>`` ao invés de ``</trans-abstract>``


Fixed


@sayantansur I ran comparison tests for with and without the consolidation using fabtests pingpong tests. (Regular and iov for different sizes). For the patched code, the increase in latency was < 1 usec per transfer. For most of the sizes, it was < 0.2 usec per transfer. Are these values acceptable?


Typo: *deve ser inserida uma informação...*


Yeah. Thanks for catching that. Fixed in a later commit as well


Thanks for the catch, Dannon


FWIW, you can globally disable window animations by doing:
```lua
    hs.window.animationDuration = 0
```


You didn't version annotate this function.


Add GWAS.SKAT


Adding GWAS.SKAT


That's already fixed (in a better way), in current master.


It's needed? Well this is theming, if someone want to use a specific qt theme in those environments this will override that theme.
With this change QT_STYLE_OVERRIDE=gtk will be in ${custom}-image.sqfs, so live cd and installed systems will be affected.


as above.


1. Including null wouldn't work. The generator expression would generate 0 elements in list, but 0 means unlimited matches.
2. Somehow you are right, but now we test really many cases. I would maybe reduce the range to `range(1, 20)`


asdf delayed response! Bad! @Viaron


Minor: Should this be `MOBILE_CONFIG_SERVICE_ENVIRONMENT`?


Since I can vary the test pattern the results would differ. So I kept it here seperately^^


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1656 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@SumoLion - aware of that, just wondering why those flags are hardcoded into the build config when they could just as easily run off PHP's --enable-debug configure flag?


Looks good


This should have a value


remove commented out code (its in git now)


Okay. Let's stay with the example from the site above:
```javascript
{
    "autoload": {
        "psr-0": {
            "Vendor\\Namespace\\": "src/"
        }
    }
}
```
```inflectPackageVars($varsFromAbove)``` would return ```Vendor.Namespace.```. It should return ```Vendor.Namespace``` since the two trailing backslashes just mark the end of the namespace.


用这个字符代替吧 ≥


We still also have the issue of unwinding here. It feels wrong to just rely on the caller's list to go out of scope. You should get all addresses, or none.


Add some comment on the purpose of this class


Actually, when these are merged into rails master, I believe that travis will run. So good to add 'ci skip' always :)


thanks for catching this!


we need some detailed steps to reproduce this problem


Jim Huang：You can try to modify push {r3, r4, r5, lr} while not each register is taken.


I only recently stalked your GitHub profile to see it, sorry. :+1:  @Waverunner


Yep we can safely assume all exceptions are derived from std::exception in our code


I think It should not be registered in the DI. The reason is:

We have to use it globally in some places. We tried to change it a while ago and it makes a lot of things very complicated. Having both the global and local reflectors is confusing. Do I use the local one or the global one? What if they return different metadata?

So similar to how mirrors in Dart are global, I think it is ok to keep reflector this way.

Let me talk about it with Misko and then I will get back to you.


Patches welcome!


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


trafficForm不应该是个成员函数。。建议独立出来，同时再写个 roughTrafficDescription 调用它


I don't think they should be in here. I made a mistake in doing under the same piece of work. At this point I'm going to leave them be, but I broke my own rule. In future I think we should agree on separate pull requests for DB work regardless - just for clarity. If this proves a problem in the longer term we should revist.


Int does not work in JS.


You could use one catch with `|` clauses here instead of three clauses.


I can see that. However, all of the methods in encode response are easily modified through controller methods or options. There is no option to set expiry from the controller without modifying the entire encode_response method.


@vijaydev it would be run just once right?
I think after merging we should run once, to ensure the merge hasn't created failures.


这些函数可以统一到一起~


sure, that 0 thought wasn't well thought out...


I'd still limit cases to the relevant ones.


The merge commit will trigger a run, yes.


Penso que seria interessante usar a diretiva *versionchanged* aqui: http://sphinx-doc.org/markup/para.html?highlight=version#directive-versionchanged


You are completely right, need to correct this.


Oops! Good catch. Fixed.


Ill remove it


Hum...got it!

On Wednesday, March 11, 2015, Alex Dunae <notifications@github.com> wrote:

> So close... [image: :disappointed:]
>
> validates is a method, not a hash key, so it should have looked like this:
>
> validates :title, presence: true
> validates :embed_code, presence: true
>
> Same in your other models...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/deazeredo/Loudcloud/commit/74967477bb07689747f308cf611a34100d25adba#commitcomment-10146345>
> .
>

--
Cheers,

Lucas


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-MacOS-10.9-clang: OK (1645 of 1648 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Agreed. Will fix that


以及写一个专门格式化时间的函数，参阅
http://doc.qt.io/qt-5/qdatetime.html#toString-2


You forgot to remove `require "prime"`.


Wasn't sure either because of performance, that's better^^


Looking at the [graph|https://github.com/pfadipatria/hitobito/network] is doesn't seem to have done much though. This does resemble what I would expect our conf to differ from upstream though.


From what I understand : play in arena. Create another character     Play in arena with new character. End arena season. Play new season with character 1. Log in character 2. Character 2 gets achievement in login. ?


the reason could be that with psych at this point we just have more loaded jars inside $CLASSPATH then before. will check it later locally and adjust the test.


nice work :+1:


fixed


"número" deve ser trocado por "marcador de numeração".


Sorry so what shall I do? Because the results are most time test case specific I keep it in the test case itself even it's a bit scary :O


@Alonso24  Muy bien Alonso :beers:


Like I said `0` wouldn't work with generator statement (and this is also covered in the basic test)


`max_level?()` is a better name so it doesn't have to change if you someday add more levels.


@feross: Could you push this to npm?


That is correct at the moment, yes


I added that as part of the PR


If the Bio-Phage Containment Pools subzone check is too unreliable we should indeed go by event.

There currently aren't any handlers for it in RaidCore. Ideally, we'd want to check if there is an event that fires when the "Event" thingy is updated, then we should have handlers for that. If there isn't, we should have a timer every 5 secs or so that checks the current event state while not in combat.

After having written this, I actually think a timer is the better way to go. With just an event handler we'll get issues when people wipe and the addon is unloaded because the ohmna unit is destroyed and respawns. Also, reloadui stuff which would require an initial check anyways.


Why is this done twice anyway?


Lets discuss default_order_by:

I haven't tested yet, but maybe size="30" will be too short in future if the order by consists of multiple fields. Imaging I prefer for example this order:

    ORDER BY supertask_id DESC, priority ASC

Maybe we can use the tpl_double_select() for letting the user choose their default orderby?

On the left side of the double_select this:
    field1 ASC
    field1 DESC
    field2 ASC
    field2 DESC
    ....
and so on.


I did not, thank you for the catch!


Ah, you figured that out in the next commit.


Is this content or a comment?


Muy Lindo Ivan !!


Fixed


Typo: *deve ser inserida...*


Hmmmm.... we need some more consistent use of spacing going on here. In your if and while statements you don't have spaces after the variable. This statement is an example:

```
if ($usrInput2==1)
```
I'd change it to be something like: `if ($usrInput2 == 1)`


okay then `[1, 2, 3, 4, 5, 100]`


Neat!  Where did you learn about `send()`?


[Dieser hier|https://github.com/pfadipatria/hitobito_pbs/commit/795f36a018e68a7b0607624cdda95f0ef289c012] auf dem pbs repo von mir hat z. Bsp. 2 parents und macht nichts ausser pbs sachen mergen...


@anthonyfok sure, feel free to make the change!


While lr and pc are not explicitly used in this file. They are used when function is called and returns respectively.


Exemplo com fragmento de XML mau formado


Yeah, considering what you said a timer does sound better.
I'll try to sort it out later this week.
I don't mind trying the Bio-Phage Containment Pools subzone check first, but I don't have high hopes for it.


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - i386-Windows-7-VisualStudio-12: OK (1656 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Elemento *title* não contém texto. Está certo?


When using `re.split()` you provide a regex that matches the split sequence. This sequence is then removed and put into the result list. But for `re.split()` I would need the lookbehind-assertions with quantifiers to only match the split sequence when not escaped (so escape sequences mustn't be consumed!), that don't exist in python^^
So I make a normal match that eats everything including the splitting pattern. With matching groups I only extract the wanted text.


I agree if we decide to use the global reflector, we should remove it from the DI.

_and as it is the only root binding we could also remove the root injector_


Yes, @rdlowrey is right here.


This commit fixes filesToRdf per graph mode (wrong usage of copy helper and add/updateExisting graph).

----- Original Message -----
From: "Tomas Knap" <notifications@github.com>
To: "UnifiedViews/Plugins" <Plugins@noreply.github.com>
Cc: "Michal Klempa" <mkl@eea.sk>
Sent: Wednesday, March 11, 2015 3:44:38 PM
Subject: Re: [Plugins] Bugfix in FilesToRdf, per-graph not working (9f1f12d)

Michal, can you please comment this commit? Petr cannot merge the branch https://github.com/UnifiedViews/Plugins/tree/dpu/t-filesToRdf-1.5.1without your explanation

---
Reply to this email directly or view it on GitHub:
https://github.com/UnifiedViews/Plugins/commit/9f1f12d47e3d5d56c26169dfabac663b2da17d67#commitcomment-10143848


You're probably were going to make the change - for now a corresponding update needs to be made to createmobilespec.js as it is failing currently. This is breaking our automated test runs. Could you please fix that soon?


need more contents.


The latest master doesn't compile under Windows.

The error is in this method, since it must return some value.


如果你测试过了而且界面没问题可以merge了


I don't understand this.
Since split is called after valid. we can drop split and return to the default split if we don't allow '0' anymore.


fixes #141


It's never any other exception, so I think it's just fine.


+var osString = Components.classes["@mozilla.org/xre/app-info;1"]
+ .getService(Components.interfaces.nsIXULRuntime).OS;

...why are you loading this module and then never use it (you check on appInfo.OS)...?


> Int does not work in JS.

Could you be more explicit ? It works with RTTS.


i think the error should be raised here if at all


Erro sintático do rst: **.. note::*


Not really, because they're not always the same.


You're right, but that code is still very weird anyway.


I think this is the change that I cannot get to work.  I'll try to figure out how to revert this change in my fork and retest.


> <xor-freenet> [...] you don't have to bother with teaching them programming, we can assume that they know how to do so.

That is a very dangerous assumption in The Real World™.


Just wanted to point it out :)


Aparentemente sobrou um *resposta-* no começo do texto


understood "test" is used in "examples" in the mesos source tree. this PR is to change that to be more consistent naming wise in this project.

if you would prefer to mirror the mesos tree then we can either:
* close this issue
* go a bit further and make a pr to the mesos project to do the rename there was well, merge if they do, then they will be in sync

personally id favor at the minimum making the naming a bit more consistent (terminology wise) in this project regardless if it matches the mesos tree, so feel free to merge or close based on your opinion.


Yes, right, I'll change that.


Can we use past tense - this *was* a new file


good :)

2015-03-11 18:14 GMT+01:00 Makman2 <notifications@github.com>:

> okay then [1, 2, 3, 4, 5, 100]
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/e8f841ec595e8c10626f033846e1c3f151682e6e#commitcomment-10147529>
> .
>


Thanks for that, I didn't work out how to cherry-pick it in a pull request to the original repo, but I just added it to today's release of v1.0: https://github.com/distantnative/kirby-relativedate/commit/bdd7c580dec905d652fcc914cabfaeec24787a8d


Corrigir indentação


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1148 of 1148 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.63%25-green.svg)


You should be able to use your own commands, so yes.
How would you hide it?


they are recoverable. each record here is a version (with special additions) of the same record on prod


@asacalow I realised that we needed to use different variables for each ?uri ?p ?o triple. Not 100% sure this will work with your `all_triples_construct` clauses (for the extra triples stuff). Can you sanity check?


Utilizada para apresentar uma resposta ao artigo principal que está diretamente relacionado ao artigo principal? o.O


nit: this Promise isn't resolving any value -- but, its probably ok since this method is "private" and the value is expected to be set internally


but if you use it more than one time you can declare it static for the class


You shouldn't need to do this, but rather, just make the `API_URL` have the `/api/` path included as well.


Your linked error are weird as this has not changed between the last time you've tested. It's surprising you get those now.

Those functions are declared in [OGLExtensions.cpp](https://github.com/Narann/mupen64plus-video-rice/blob/master/src/OGLExtensions.cpp).

On the branch you provide, (test-narann-rice2) and [your makefile](https://github.com/littleguy77/mupen64plus-ae/blob/test-narann-rice2/jni/Android.mk#L385) doesn't seems to add this file while it's present in the [previous branch](https://github.com/littleguy77/mupen64plus-ae/blob/test-narann-rice/jni/Android.mk#L367).

Could you try using the previous branch?


Yep it works, and I'll make a test for it.
If you want to test the regex manually google some websites that do that and insert the regex.

To explain the regex:
1. `(.*?)` First capturing group (accessible via match.group(1)). Match as less chars as possible.
2. `(?<!\\)` Lookbehind-assertion: Match if now **no** backslash come. This one only makes sense with the next one.
3. `((?:\\\\)*)` Second capturing group. Match as many double-backslashes `\\` as possible, but you can also match no backslashes at all.
4. `(?:pattern)` The actual pattern that follows to split.

Applied for this string (with `;` as separator):
`1234\\\\\;5678`
1. `1234`
3. `\\\\`
2. `\` <- Lookbehind assertion fails, because a missing single backslash is detected, so the split would not match here.

The result would be the same as the input string.


maybe put that explanation into a comment or the commit message?


Corrigir a indentação


saw approval from andrewjstone
at https://github.com/basho/clique/commit/007853bff9d2fdd94b099a2bf0861e93aa61a63d


merging basho/clique/bugfix/sdc/usage-types = 007853bf into borshop-integration-55-bugfix/sdc/usage-types


basho/clique/bugfix/sdc/usage-types = 007853bf merged ok, testing candidate = 40072d21


In https://www.sqlite.org/c3ref/column_blob.html,
"""
Strings returned by sqlite3_column_text() and sqlite3_column_text16(), even empty strings, are always zero-terminated.
"""
When did you get null from it? If it's when you used an out of range idx, I prefer letting the behavior undefined as others. The sqlite3_column_xxx family has undefined behavior when the index is out of range.


Thanks for pointing this out, will push a fix soon


prova


Devemos inserir uma tabela com os valores possíveis para o atributo *related-article-type*


bla


When compiling, it is finding 29 other instances of EmptyEffect in Mage Sets.


I don't want the readers to look up every variable and results in setup...
I try to fix that^^


está faltando o nível do elemento *front* entre os elementos *article* e *article-meta*


Oh, yes, of course. :-) Will fix.


#9 close


Yep, too bad we cannot rely on Ogre for that...


Reminder to fix this.


With php7 it could e.g. Be a EngineException


@nirvdrum  Sounds good, I was thinking to add a specific tag to distinguish between other comments. e.g. `MODIFIED`

Example:
```ruby
# MODIFIED Replaced @tuple.reverse! which calls primitive method.
```


Shall I rephrase?


After re-reading, I can see that the first one is technically not acceptable because a parameter is used on the first line, however the pep8 linter doesn't seem to care since it is valid without a params on the first line. I've never noticed that distinction before.

To each his own about style – I personally find the visual indentation annoying to implement, and annoying to look at. I especially don't like breaking expressions with newlines, but sometimes that is necessary.

But anyway, yeah, even PEP8 has subtle quirks.

Something like https://github.com/Psycojoker/pyfmt seems like a reasonable step to integrate into my workflow. I suppose if the code results in gross formatting, it should probably be refactored and decomposed to be simpler anyway.


Possible, will do that^^


:+1 Looks good.


Pour information, il est préférable d'utiliser un gestionnaire de projets pour éviter de se casser la tête avec les dépendances (et sous-dépendances) de bibliothèques et leur MAJ.

Dans l'écosystème Java, on retrouve **Maven**, qui est le plus utilisé (sinon Ant et Gradle principalement).

Grâce à ça, tu as juste à définir ton projet, ses configurations et ses dépendances dans un fichier `pom.xml`.
Et au lancement via **Maven** toutes les dépendances (.jar) seront téléchargées/mises-à-jour et déposées dans le classpath du projet.

Tout bon langage a son Maven-like :
- npm et bower pour JavaScript (server-side et client-side)
- composer pour PHP
- SBT pour Scala :heart:
- pip pour Python
- ...

En bref, ça fait le café :coffee:
Et c'est indispensable :smile:


Logically it extends the CodeGenTestBase to create the XML document. Also I see another class like RoslynTestBase extending from CodeGenTestBase to expose other functionality. So I believe its better to be separate class.


replace it with the start year


hm... I understand. But double writing is usually worse because if one changes the testcases one usually wants all occurrences anyway.


Corrigir o nome do atributo *@related-article-type*


Another Test


You could hide it e.g. be using a non public func for doing the groundwork


I tested it, and here at least getaddrinfo() diesn't return an IPv6 address for an interface without IPv6. That might not be guaranteed, I guess, so I'll check for EADDRNOTAVAIL.


do as you want. Regex explanation is more important to me.


This commit deleted the metadata.rb file, which appears to have broken the cookbook for those using the development version in Git.


ewwwww, this breaks completion in non-ascii encoded files because of `offset` being used instead of `byte_offset`


Esse erro ocorre em diversos parágrafos da documentação do elemento **related-article**


Looks good to me.


Ah, yes.


At least someone understands


perv alert @Viaron !


Fixed


"OMG SEPRATE PR" - :dog: :baby: @chamblin


Have you actually looked at the homepage? I was able to find a short description of the service and also a link to the maintainers Github page.


It works! Thank you very much!
Since this is a Mac only issue, and hard to fix for non Mac user, do you think it is worth to check and warn for such situations?
Does it always happen, if a parent widget is smaller than a child widget?


It's for the IPv6-capable representation of a TcpFilter 'Pattern'.


woa


Hm, no.


Yes, it did. This was announced ahead of time on Twitter since that's my only real option for people that follow my development.


The date of the latest <i>disease occurrence</i> review.


Double calls to `inet_ntop()` here and below.


Seems like there is:
http://www.boost.org/doc/libs/1_41_0/libs/timer/timer.htm


Ditto


maybe I should get the language right


Don't you want a prefix for IPv6 rather than a mask though?


merging the pull request from venkattk


// Arrange - add reviews to the database


Only 4 `G`s mean the long form, 5 `G`s is the narrow form (that we will not support, at least now)


Someone sent me this and I had to comment. So bad!


all tests pass:
success: http://buildbot.bos1/builders/test-clique/builds/55


Did you just upgrade via composer, or did you do a fresh install?


@garys-esri - I just downloaded the current version from that link & it had the Java GeoMessage version (cc @ACueva ) - how should we handle getting this GeoMessage binary for the current template doc?


11 March 2015


I have no opinions. Psycho (?) implemented this feature. I just fixed things once again after him. Let's implement multiple sorting fields in 1.1 and think what's the right size then.


This assumes that `$lock` is always returned when `findOne()` could legally return `null`: should we add an extra guard?

```php
if ($lock && (time() - $lock['created']->sec) < $this->getConfig('locktimeout')) {
```


Looks good.


Fixed.


Yep. I landed this


Add reviews


woops :\


fragmento de XML mau formado


Ok I think Simon meant that "recoverable" in the sense that an error is "recoverable" if getting notified about it means you can modify the code to patch the error and then rerun it—versus a situation where every now and then there's a form that just doesn't fit what's expected and there's no point going back to try to rerun it. Anyway, I think we're all on the same page that it's worth letting these exceptions bubble up to pillow retry


May not be a problem, but there is already a `GcsOptions` defined in `com.google.cloud.dataflow.sdk.options`  It seems a bit strange to have 2 different ones.


@csmoore, I'll remove the links and add a "TODO" statement. We won't have a binary version of GeoMessage Simulator until we post one to ArcGIS.com.


Copy&Paste. Sorry.


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1651 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Nevermind...found one here: http://www.esri.com/apps/products/download/index.cfm#ArcGIS_for_the_Military


Would it make sense to use `CMARK_OPT_DEFAULT` instead of `0`?


good catch!
while we're in this code, perhaps the stuff after the fail: label should be spiffied up?  it does not currently kill the progression thread.  i would change usdf_fabric_close to check that fds are not -1 and just call that from fail: so that we only have one copy of the cleanup code.


Since `fnmatch` does an exact match, this will only work for `CT-lung-label` and not for `CT-lung-label1`

```
>>> import fnmatch
>>> s='CT-lung-label1'
>>> fnmatch.fnmatch(s, 'CT-*-label')
False
>>> fnmatch.fnmatch(s, 'CT-*-label1')
True
```

I would suggest to change:

```
fnmatchExp = "%s-*-label" % masterName
```

with

```
fnmatchExp = "%s-*-label*" % masterName
```


Sorry, I added now a comment for psycho on bugs.flyspray.org


modifying.


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (640 of 640 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.25%25-green.svg)


I know that. The problem is that any application started by **sudo** don't get themed properly without it. This is only related to GTK based editions. There we use gtk theme anyway. I'm open for better solutions.


Wow, that's news to me. Thanks for finding that. I'll edit again.


The 14 character bin name is still enforced by the server.  I've personally felt the 14 character limit is too small, but it's not controlled by the client.   I will log your request.


Isn't that a bit harsh? An `http.Error(..., http.StatusUnauthorized)` might be better than crashing the process no?


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


No worries, I'll get it.


:+1: for using the nice short form of `render`.


That's correct. Some qt applications in non-kde editions have really inconsistent styling without it.


Sorry for the typo:
I intended "NOT as a row"


I've been reading the Class documentation.

Sent from my iPhone

> On Mar 11, 2015, at 12:15 PM, James Edward Gray II <notifications@github.com> wrote:
>
> Neat! Where did you learn about send()?
>
> —
> Reply to this email directly or view it on GitHub.
>


Would prefer it to be called occurrenceReviewCount (I presumed it was a list)


I think you were looking for

```ruby
link_to 'Like', song_likes_path(song),  method: :post, remote: true
```


Definitely a solid start.


A


You mean for display? Or you think struct Pattern needs to be different?


@wangyuchen Note that this is a read-only mirror of CRAN and the original authors of the package most likely do not read your comments.


Fixed! But why, i dont now!


And adminUnitReviewCount, to match terms in database and code


Yeah we should probably return an error from this function. Sorry was just in a rush to try to ship something today, but good thoughts.


Fixed


Or actually we could split the jwt parsing out into it's own function which returns an error and just return nil if we can't parse a valid token.


@jcbrand Unfortunately after that change the tests dont work anymore. Can you gimme a hint?


thanks

On Wed, Mar 11, 2015 at 11:47 AM, Brian Nichols <notifications@github.com>
wrote:

> The 14 character bin name is still enforced by the server. I've personally
> felt the 14 character limit is too small, but it's not controlled by the
> client. I will log your request.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bertbeck/aerospike-client-csharp/commit/c90de2790007e904d6ee7fea3fc9ff24841a1631#commitcomment-10148270>
> .
>


b


If we do it this way, configure will fail when freerdp is not found and break compilation for many SIPE users.
We want this to be only an optional dependency that, if available during the build, enables additional features.

Have a look at how voice&video and TCP support are checked and conditionally enabled below.


i submitted a pr


Yes i have installed the plugin via Composer and setup all the steps but
when i call from my view gives me the error
*Error: * Class 'PayPal\Api\Item' not found
*File: *
C:\xampp\htdocs\cakephp11\app\Plugin\PayPal\Controller\Component\PayPalComponent.php

*Line: * 43

On Wed, Mar 11, 2015 at 6:37 PM, Gerd Katzenbeisser <
notifications@github.com> wrote:

> Did you just upgrade via composer, or did you do a fresh install?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakito/CakePHP-PayPalRest-Plugin/commit/2d58063066907e8e1a7a5455b8c1f6427582c9a9#commitcomment-10148060>
> .
>


I just thought it would be nice to be able to toggle this information if you want to separate the logs since a smart-proxy with all these modules might make it hard to see whats going on when a few hundred events fly by.


Consistent terminology in this file too please


Missing empty line above this title?


He works for Blizzard haha :p. Amazing work!


haha


Thanks, looks good!


created a change log file.... just so we can start to add stuff there...


Not necessarily a fan of the `::` but I do like the `client/scope` format which I ended up following for the producer... what happened to this branch?


@rvagg at first glance, swapping these two lines caused #121. Were they swapped for some reason that you can remember or can they be swapped back?


The bmc_setup method used to public but it was changed to private during the shell provider implementation (not me).  I figured there must have been a good reason for it, but it does make testing a little bit more difficult.


Nit: PrefixedCache sounds more natural


@KasperBrandt was it intentional to remote the project_donate template?


Should the prefix be optional?


thanks @yorikvanhavre!  Will you be able to rerun proposal 3?


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-MacOS-10.9-clang: OK (1650 of 1650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It can be, I think it makes sense.


Yes, you're right.


It makes more sense in vendor. This makes it more clear that the file is very specifically tied to the installed dependencies. I like this change. It'll also avoid issues where people copy over an application to their server without the vendor folder, then install breaks because of the bad compiled file.


Yes, it should.


I'll remove it.


Maybe it should even be something like NamespacedCache. Prefixing is just one sort of namespacing things...?


Thanks for fixing my testes :p :8ball::8ball:


I do reuse the global logger and if you want to override the global logger you can do so here.


There is a timer class in ogre as well, but the SFML one seemed better. (SFML used clock_gettime(), ogre used gettimeofday(), the former was from what I could read better to use.)

I didn't actually see that one. I can change it to boost if you want. The updated boost timer library isn't part of the boost library bundled with the Ogre SDK on windows (the old timer library which you linked too is deprecated), though if we've dropped VS2012 support anyway I guess that doesn't matter, since one would have to install boost from scratch anyway. (On that note, should we use boost for threads rather than SFML as well? That would mean bundling one less dll given that ogre already uses the boost thread library anyway.)


Is the cache prefixed? No. So, the current name is much better.


Also, the people running syncthing without any network connectivity (I was just flying on a plane again). We should probably just l.Info these (if not l.Debug) and just let the indicator speak for itself...


@loicsans perhaps you could look this over?


Woops.  I'll send in another change.


corrected the doxygen documentation syntax and added doxygen grouping statements as well


so so long ago I don't remember, perhaps try out the test suite with this switched back


LOL!


You know et. @Waverunner ;)


Any command is just a very simple method around this, so I think it's OK if it is public. Especially, because you can rename commands in Redis. You could just use your own transforms then.


Yeah, and the compiled.php and routes.php files are not really designed to
be maintained across "versions" / "deployments" of an application like most
everything else in storage such as sessions or file caches, etc.

On Wed, Mar 11, 2015 at 1:03 PM, Graham Campbell <notifications@github.com>
wrote:

> It makes more sense in vendor. This makes it more clear that the file is
> very specifically tied to the installed dependencies. I like this change.
> It'll also avoid issues where people copy over an application to their
> server without the vendor folder, then install breaks because of the bad
> compiled file.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/framework/commit/cfa7fcb60fd60b3870606c910559e67186a7a8a8#commitcomment-10148604>
> .
>


This commit does not make sense. Revert!


I think that's intended.


We don't want to handle any `EngineException` here.


@mikejolley sorry, "Testes" is "Tests" but in Portuguese xD


I don't think this is needed.


Of course; silly error .. fixed it now.


Is it possible to reduce the scope?
```c++
if ( this->mOnEdit ) {
// eventStream.Read
// malloc
// etc,
// free
}
```


We will want another conditional like SIPE_WITH_FREERDP. Voice and Video should still compile even though freerdp is not available.


I've only asked :D Not sure if we need that in percona-agent.log anyway?


closes #1


@arthurnn well, they are big internals changes, so they could break things? that's why I put them in the changelog, so people can m ow what changed.


@frank-dittrich you changed the $0$ test vector to $1$, was that necessary for some reason? I guess without that change, this commit would not have made it this far.


You already do this in SIPE_WITH_VV conditional section. I guess this should be removed.


Careful w/ use of @walter please. It subscribed me to this thread.


I'm reverting right now


Yep, its a good point! We should create an issue and we can work on getting that added, we don't want devs to need to read all of that code and re-implement it themselves. If you don't get to do so I'll add it to my list to figure out what all should be added from that side of the code soon.

I went ahead and merged those since I was behind on getting them in, otherwise I would normally opt to have that type of thing written in the original PR :)


I think the value should be NULL. Not 0.


fast-forwarding develop to borshop-integration-55-bugfix/sdc/usage-types = 40072d21


#38 is not fixed. I'm on a drops7-based, doing local development in a Vagrant box, and running into "undefined function pantheon_bulk_file_delete()" fatals.

The problem is pretty clear, in modules/pantheon/pantheon_api/pantheon_api.module, line 43:

```php
  if (count($paths) > 0) {
    pantheon_bulk_file_delete($paths);
  }
```


Yes, but maybe not in time for your meeting... Will try to do it tonight, though.


I thought about keeping it, but decided against it, to discourage the use of '0'.
Feel free to change one of the tests back to using '0', but then add a comment that '0' is obsolete, and only supported for backwards compatibility.


Agree.


@ethanmick thought about adding this to hapi-router but you can set route defaults when you create a new hapi server. Is there a reason you wanted to be able to specify them separately?


Yeah, a settings page will eventually be needed down the line anyway. lead dev (htr_xorth) of destiny tracker asked if we could have the users from a settings page hit an API on their send if the user chooses to sync.

his message (partial):
> (opt-in) This would allow me to show their vault on destinytracker and run numbers on their gear, like how many materials do you need to upgrade all your weapons?
I could also do collections, you're missing 1 of the vault of glasses armor pieces. There are all kinds of ideas.

^ Thoughts?

----------

Instead of showing the armor value, would it be better to show the light level?


COM_3PPPack_PathOfWarEx - Helper Things.user

I don't understand why you added the name back here? That should stay defined in the .1st files. Unless the editor did this as I see all my comments got deleted from the file.


si no se calcula el promedio se hacen las conversion a otro tipo de dato


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - i386-Windows-7-VisualStudio-12: OK (1651 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Please squash this commit with the previous one.


FYI, apparently the triple-backtick approach doesn't work with Doxygen markdown and you have to use a four-space indent instead.


Yes, this would be better.


Taken care. I have named these Registry_L1 and Registry_L2, it makes it closer to the Apiset versioning scheme and by the end of the exercise I expect us having names like Registry_L1_0 and Registry_L1_1 as well. Let me know if you disagree.


Seems I'm a little late to the party, but I was just approached to build an addon for Factions and started looking around for your setup, as it says [here](http://www.massivecraft.com/factions-develop) that you use maven for building.  I am now thinking of turning down the request because you've removed it.


start_sharing() isn't used outside sipe-applicationsharing.c, so it shouldn't be exposed in its header.


To be honest that looks horrible.
This construction looks not better from this rule:
```python
while (
          not match_condition(current_match) or
          (current_match is not None and pos >= len(string))):
    # Rematch until user provided condition is satisfied.
    current_match = compiled_pattern.search(string, pos)
```
We should really suggest changing that rule...


merge if you're happy


Make this static in order to be able to remove the declaration from the header.


I found the following drawbacks compared to a real hypervisor, not further investigated:

1. KIWI image builds fail with lxc
2. cross builds fail because of an error when registering QEMU with binfmt_misc

I think /proc/sys/fs/binfmt_misc is not mounted so 2. fails. No idea on 1., not tracked down further. Will check this further later.


controversial


Bir kaç gündür [fazilet-cli](https://github.com/dbtek/fazilet-cli) çalışmıyordu. Öyle farkettim. Sen de dikkatlisin ama bayağı :smile:


<!doctype html>

	<meta charset="utf-8">

GET A ROOM

ROMOVERSIKT

SUPPORT

	Campus Vaterland

	Christian Kroghs gate 2, 0186 Oslo

	telefon:
				+47 22 05 75 50

	e-post: post@westerdals.no

![westerdalslogo2](https://cloud.githubusercontent.com/assets/11390063/6603641/ac38b2a0-c823-11e4-978d-523574c5203e.png)


Thanks @iggy. I've fixed that in #21554.


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (1651 of 1654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Thanks, This is amazing! It need not compile this c file which is included in another c file.Because the "#include" will copy and paste the content of that including file to the target file.
By the way, how much the testing input number is enough?  I know I get only 16bits result. It can't hold the whole integer result.  So I wanna know that is it OK, if I test the result range only 16bits value range ?


+1

Nice!


wow... det så ikke spesielt oversiktelig ut


SIPE code uses tabs (set to 8 characters) for indentation.


No worries, fix is out already ;)


Windows is a bit of a problem as well. Do you have a build environment for that? Otherwise I'll have to sort it out afterwards. Rough first working copy here (perhaps you can incorporate some of it at least):

```diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 407bf67..9369a75 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -83,16 +83,9 @@ if(NOT DEFINED BUILD_WINVNC)
   set(BUILD_WINVNC 1)
 endif()

-# Minimum version is Windows 2000 (5.0)
+# Minimum version is Windows XP SP2 (5.2)
 if(WIN32)
-  if(NOT CMAKE_SIZEOF_VOID_P MATCHES 8)
-    add_definitions(-D_WIN32_IE=0x0500 -D_WIN32_WINNT=0x0500)
-  else()
-    set(WIN64 1)
-    # Win64 doesn't like us requesting a Windows version that didn't have
-    # 64-bit support. Request XP (5.1) instead.
-    add_definitions(-D_WIN32_IE=0x0501 -D_WIN32_WINNT=0x0501)
-  endif()
+  add_definitions(-D_WIN32_IE=0x0502 -D_WIN32_WINNT=0x0502)
 endif()

 if(CMAKE_SIZEOF_VOID_P MATCHES 8)
@@ -330,21 +323,17 @@ set(HAVE_PAM ${ENABLE_PAM})

 # Check for socket functions
 if(WIN32)
-  set(CMAKE_EXTRA_INCLUDE_FILES winsock2.h ws2tcpip.h)
-  set(CMAKE_REQUIRED_LIBRARIES ws2_32)
+  # check_function_exists() cannot handle stdcall, so just define things
+  set(HAVE_INET_ATON 1)
+  set(HAVE_GETADDRINFO 1)
 else()
-  set(CMAKE_EXTRA_INCLUDE_FILES sys/socket.h)
-endif()
-check_function_exists(inet_aton HAVE_INET_ATON)
-# This might give a false positive on Windows as it is also guarded by
-# a version check that we do not satisfy (requires Vista, but we target
-# Windows 2000).
-if(NOT WIN32)
-check_function_exists(inet_pton HAVE_INET_PTON)
+  if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+    set(CMAKE_REQUIRED_LIBRARIES socket)
+  endif()
+  check_function_exists(inet_aton HAVE_INET_ATON)
+  check_function_exists(getaddrinfo HAVE_GETADDRINFO)
+  set(CMAKE_REQUIRED_LIBRARIES)
 endif()
-check_function_exists(getaddrinfo HAVE_GETADDRINFO)
-set(CMAKE_EXTRA_INCLUDE_FILES)
-set(CMAKE_REQUIRED_LIBRARIES)

 # Generate config.h and make sure the source finds it
 configure_file(config.h.in config.h)
diff --git a/common/network/TcpSocket.cxx b/common/network/TcpSocket.cxx
index bdeda2a..4de6506 100644
--- a/common/network/TcpSocket.cxx
+++ b/common/network/TcpSocket.cxx
@@ -25,6 +25,7 @@
 #include <winsock2.h>
 #include <ws2tcpip.h>
 #define errorNumber WSAGetLastError()
+#define AI_NUMERICSERV 0
 #else
 #define errorNumber errno
 #define closesocket close
@@ -33,7 +34,6 @@
 #include <arpa/inet.h>
 #include <netinet/tcp.h>
 #include <netdb.h>
-#include <unistd.h>
 #include <errno.h>
 #include <string.h>
 #include <signal.h>
@@ -41,6 +41,8 @@
 #endif

 #include <stdlib.h>
+#include <unistd.h>
+
 #include <network/TcpSocket.h>
 #include <rfb/util.h>
 #include <rfb/LogWriter.h>
@@ -263,16 +265,17 @@ char* TcpSocket::getPeerAddress() {
     return rfb::strDup("");
   }

-#if defined(HAVE_GETADDRINFO) && defined(HAVE_INET_PTON)
+#if defined(HAVE_GETADDRINFO)
   if (sa.u.sa.sa_family == AF_INET6) {
     char buffer[INET6_ADDRSTRLEN + 2];
-    const char *name;
+    int ret;

     buffer[0] = '[';

-    name = inet_ntop(sa.u.sa.sa_family, &sa.u.sin6.sin6_addr,
-                     buffer + 1, sizeof(buffer) - 2);
-    if (name == NULL) {
+    ret = getnameinfo(&sa.u.sa, sizeof(sa.u.sin6),
+                      buffer + 1, sizeof(buffer) - 2, NULL, 0,
+                      NI_NUMERICHOST);
+    if (ret != 0) {
       vlog.error("unable to convert peer name to a string");
       return rfb::strDup("");
     }
@@ -755,7 +758,7 @@ TcpFilter::Pattern TcpFilter::parsePattern(const char* p) {
       masklen = atoi(mask.buf);
       expandMask = true;
     }
-#endif /* HAVE_INET_PTON */
+#endif /* HAVE_GETADDRINFO */
   } else {
     masklen = 32;
     expandMask = true;
@@ -788,28 +791,24 @@ TcpFilter::Pattern TcpFilter::parsePattern(const char* p) {

 char* TcpFilter::patternToStr(const TcpFilter::Pattern& p) {
   rfb::CharArray addr, mask;
-#ifdef HAVE_INET_PTON
+#ifdef HAVE_GETADDRINFO
   char buffer[INET6_ADDRSTRLEN + 2];

   if (p.address.u.sa.sa_family == AF_INET) {
-    inet_ntop(p.address.u.sa.sa_family,
-              &p.address.u.sa,
-              buffer, sizeof (buffer));
+    getnameinfo(&p.address.u.sa, sizeof(p.address.u.sin),
+                buffer, sizeof (buffer), NULL, 0, NI_NUMERICHOST);
     addr.buf = rfb::strDup(buffer);
-    inet_ntop(p.mask.u.sa.sa_family,
-              &p.mask.u.sa,
-              buffer, sizeof (buffer));
+    getnameinfo(&p.mask.u.sa, sizeof(p.mask.u.sin),
+                buffer, sizeof (buffer), NULL, 0, NI_NUMERICHOST);
     mask.buf = rfb::strDup(buffer);
   } else if (p.address.u.sa.sa_family == AF_INET6) {
     buffer[0] = '[';
-    inet_ntop(p.address.u.sa.sa_family,
-              &p.address.u.sa,
-              buffer + 1, sizeof (buffer) - 2);
+    getnameinfo(&p.address.u.sa, sizeof(p.address.u.sin6),
+                buffer + 1, sizeof (buffer) - 2, NULL, 0, NI_NUMERICHOST);
     strcat(buffer, "]");
     addr.buf = rfb::strDup(buffer);
-    inet_ntop(p.mask.u.sa.sa_family,
-              &p.mask.u.sa,
-              buffer + 1, sizeof (buffer) - 2);
+    getnameinfo(&p.mask.u.sa, sizeof(p.mask.u.sin6),
+                buffer + 1, sizeof (buffer) - 2, NULL, 0, NI_NUMERICHOST);
     strcat(buffer, "]");
     mask.buf = rfb::strDup(buffer);
   }
@@ -819,7 +818,7 @@ char* TcpFilter::patternToStr(const TcpFilter::Pattern& p) {
   addr.buf = rfb::strDup(inet_ntoa(tmp));
   tmp.s_addr = p.mask.u.sin.sin_addr.s_addr;
   mask.buf = rfb::strDup(inet_ntoa(tmp));
-#endif /* HAVE_INET_PTON */
+#endif /* HAVE_GETADDRINFO */

   char* result = new char[strlen(addr.buf)+1+strlen(mask.buf)+1+1];
   switch (p.action) {
diff --git a/common/network/TcpSocket.h b/common/network/TcpSocket.h
index 6f737f2..ae0ff9f 100644
--- a/common/network/TcpSocket.h
+++ b/common/network/TcpSocket.h
@@ -33,8 +33,14 @@
 #endif

 #include <network/Socket.h>
+
+#ifdef WIN32
+#include <winsock2.h>
+#include <ws2tcpip.h>
+#else
 #include <sys/socket.h> /* for socklen_t */
 #include <netinet/in.h> /* for struct sockaddr_in */
+#endif

 #include <list>

diff --git a/config.h.in b/config.h.in
index 490d7f6..a50e723 100644
--- a/config.h.in
+++ b/config.h.in
@@ -2,7 +2,6 @@
 #define PACKAGE_VERSION "@VERSION@"

 #cmakedefine HAVE_INET_ATON
-#cmakedefine HAVE_INET_PTON
 #cmakedefine HAVE_GETADDRINFO
 #cmakedefine HAVE_GNUTLS_SET_GLOBAL_ERRNO
 #cmakedefine HAVE_GNUTLS_SET_ERRNO
diff --git a/win/winvnc/ManagedListener.cxx b/win/winvnc/ManagedListener.cxx
index e7728bc..bc664b4 100644
--- a/win/winvnc/ManagedListener.cxx
+++ b/win/winvnc/ManagedListener.cxx
@@ -26,12 +26,16 @@ static LogWriter vlog("ManagedListener");

 ManagedListener::ManagedListener(SocketManager* mgr)
-: sock(0), filter(0), manager(mgr), addrChangeNotifier(0), server(0), port(0), localOnly(false) {
+: filter(0), manager(mgr), addrChangeNotifier(0), server(0), port(0), localOnly(false) {
 }

 ManagedListener::~ManagedListener() {
-  if (sock)
-    manager->remListener(sock);
+  if (!sockets.empty()) {
+    std::list<network::TcpListener>::iterator iter;
+    for (iter = sockets.begin(); iter != sockets.end(); ++iter)
+      manager->remListener(&*iter);
+    sockets.clear();
+  }
   delete filter;
 }

@@ -57,8 +61,11 @@ void ManagedListener::setFilter(const char* filterStr) {
   vlog.info("set filter to %s", filterStr);
   delete filter;
   filter = new network::TcpFilter(filterStr);
-  if (sock && !localOnly)
-    sock->setFilter(filter);
+  if (!sockets.empty() && !localOnly) {
+    std::list<network::TcpListener>::iterator iter;
+    for (iter = sockets.begin(); iter != sockets.end(); ++iter)
+      iter->setFilter(filter);
+  }
 }

 void ManagedListener::setAddressChangeNotifier(SocketManager::AddressChangeNotifier* acn) {
@@ -70,24 +77,35 @@ void ManagedListener::setAddressChangeNotifier(SocketManager::AddressChangeNotif

 void ManagedListener::refresh() {
-  if (sock)
-    manager->remListener(sock);
-  sock = 0;
+  std::list<network::TcpListener>::iterator iter;
+  if (!sockets.empty()) {
+    for (iter = sockets.begin(); iter != sockets.end(); ++iter)
+      manager->remListener(&*iter);
+    sockets.clear();
+  }
   if (!server)
     return;
   try {
-    if (port)
-      sock = new network::TcpListener(NULL, port, localOnly);
+    if (port) {
+      if (localOnly)
+        network::createLocalTcpListeners(&sockets, port);
+      else
+        network::createTcpListeners(&sockets, NULL, port);
+    }
   } catch (rdr::Exception& e) {
     vlog.error("%s", e.str());
   }
-  if (sock) {
-    if (!localOnly)
-      sock->setFilter(filter);
+  if (!sockets.empty()) {
+    if (!localOnly) {
+      for (iter = sockets.begin(); iter != sockets.end(); ++iter)
+        iter->setFilter(filter);
+    }
     try {
-      manager->addListener(sock, server, addrChangeNotifier);
+      for (iter = sockets.begin(); iter != sockets.end(); ++iter)
+        manager->addListener(&*iter, server, addrChangeNotifier);
     } catch (...) {
-      sock = 0;
+      // FIXME: Should unwind what we've added
+      sockets.clear();
       throw;
     }
   }
diff --git a/win/winvnc/ManagedListener.h b/win/winvnc/ManagedListener.h
index e83aa0b..e60b57f 100644
--- a/win/winvnc/ManagedListener.h
+++ b/win/winvnc/ManagedListener.h
@@ -41,7 +41,7 @@ namespace winvnc {
     void setFilter(const char* filter);
     void setAddressChangeNotifier(rfb::win32::SocketManager::AddressChangeNotifier* acn);

-    network::TcpListener* sock;
+    std::list<network::TcpListener> sockets;
   protected:
     void refresh();
     network::TcpFilter* filter;
```


Please add curly braces around each if's body, even when there's only a single line of code.


This should be fixed with bf21d2b.


@mixcas this route needs to wait on a subscription to all [with a radius?] timbres and also get data for the timbres inside a radius


why would you need this if you can assign method's result to object's attribute instead of creating instance variable and getter ?


reviewed off line. Looks fine, but suggested new naming convention.


fixing


I actually removed the `hasLines` part in 92f37ed. Surprisingly enough, none of the reliable hashes were affected by that. I've also added some TODOs in the affected part, so we can revisit that part later on in more detail.


You sure about the error code? Isn't it EAFNOSUPPORT?


I looked at DLLs in the "4.5.3" directory.


Have you considered trying out [biicode](http://www.biicode.com/)?


typo: aspectRadio :)


So we can't yield a river outside of IO? I'm just asking, to understand, I'm not sure there is much to manually control fibers flow, and there is a better way coming.


We don't actually need to manually connect anymore. Take this out and then lets merge this PR.


Both, maybe? I'm not sure if it's a big no-no to use masks with IPv6. I can't say I've ever seen anything but the prefix notation.

One option is switching to prefix for both protocols. It's rare that you want anything else for IPv4.


@mondiaz The video tests look good. One thing I'm seeing is the download popup windows for file and transcript downloads are not getting closed. It looks like there are comments in the test to close the window? Just not sure if the windows should be getting closed or not.


Given that it's fast enough for us, I think the benchmark changes are just another caveat you can mention in the pull request.


Is a `Favorite` actually directly associated to a `Topic`?


Should destroyChildren not be passed as well to the children?


yeah no need changing the design... just want the same vantage points for comparing images/options side by side.


I don't think this is right. If I understand it correctly, you want to link with freerdp library in order to be able to use its API to share just a single monitor, application, etc. This code is for *displaying* remote screen (e.g. shared from a Windows Lync client). IMHO you shouldn't need to change anything in this method.

What you care about is a replacement of executing freerdp-shadow binary below.


Hint: I expected this commit to be named "Create Favorite model. Associate with User and Post."


but whatever you can do. thx!


I'll take a look at it. Thanks for the suggestion. :)


Denk geldi diyelim :) Bu arada şu kodların içine yorumlar yazsan da biz de anlasak ve fransız kalmış olmasak olmazmı.


The checkpoint says: "The `favorited` method takes a `post` object and returns a `favorite` object if one exists - if there is an entry in the favorites table with the appropriate `user_id` and `post_id`."

I can see the `post` object being checked for (`post_id: post.id`), but what about the `user`/`user_id`? How is it working? Could you explain to me (pretending I don't know how)?


Strip tags after using `enrichText()` for valid count.


When you do this - make your you create a new release


Why were these changes necessary?  Basically it undoes some recent work we had to support browserify.


> Instead of showing the armor value, would it be better to show the light level?

I like that.


@michalc look up to date now on edit branch?


So, in 8.x they changed a lot of the API, and I thought they had gotten rid of the ability to do this. But a quick check in the docs and I see:

> routes - a route options object used to set the default configuration for every route.

Under `options`, `connections`. So, I dunno, it's probably not that useful anymore. On the other hand, perhaps in the future the plugin could give a group of route default options. (Eg, all routes in `users.js` get some extra options, all routes in `files.js` get a different set of default options.)


Nice :)


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1649 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


oh, good idea. Thanks!


Won't this always fail since the IPv4 socket is now in the way? You're also not considering disabled IPv6.

Isn't it just easier to use createTCPListeners() for this? Or am I missing something?


I think this was meant to be your `create` method.


@ethanmick that's a great idea


All specs passed except for specs requiring API keys.


Good start for sure.


Just saying: those commits have nice titles and are neatly separated feature-wise. I like it!


Specific for my projects. Should be implemented on a per mod basis.


Instead of everyone who implements OriginGradle


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Besides, I don't see why there's any harm in us implementing these interfaces until we get a newer source drop.


This ties up Finagle's processing loop.
You should say something like

    read (req, tab.getTableId, key)
    .map (_ => Thread.sleep (5000))
    .toTwitterFuture

Your version waits 5 seconds to return anything to Finagle's processing loop, so it's 5 seconds before Finagle can check for more requests. This alternate version returns a future to the loop immediately, so the loop can process the next request immediately. Then it's the future that takes 5 seconds to complete.


this isn't part of upgrading ruby and shouldn't be part of the commit.


Tabi olur, bir sonraki versiyonda ekleyeyim.


I tried out a couple of larger notebooks to confirm the new bugfix is sufficient, but we'll want to keep this in mind if people start reporting it isn't working.


I don't see `db/schema.rb` in that commit, and actually you ran `rake db:migrate` later I guess cause there is a commit for that next. When you create a new table, make it a habit to run the migration right away so that you can add it to the commit, and check everything's fine before you do. *Or*, you just forgot to include it :)


Parece ser que la codificación a ISO-8859-1 con saltos de línea de Linux funciona


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - i386-Windows-7-VisualStudio-12: OK (1649 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


89911514-Allow-OtherSideCoefficients-in-AFN (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (638 of 638 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.22%25-green.svg)


Instead of doing an if/else here cant we assign config in the above try/except block where default_sections are being parsed?


*+35 - 11th Mar


You need to add [Exposed=(Window,Worker)] to the interface to expose it to the Worker as well.


that:

```python
while (
          not match_condition(current_match) or
          (current_match is not None and pos >= len(string))):
    # Rematch until user provided condition is satisfied.
    current_match = compiled_pattern.search(string, pos)
```

is wrong. Right would be:

```python
while (
        not match_condition(current_match) or
        (current_match is not None and pos >= len(string))):
    # Rematch until user provided condition is satisfied.
    current_match = compiled_pattern.search(string, pos)
```

or

```python
while (not match_condition(current_match) or
       (current_match is not None and pos >= len(string))):
    # Rematch until user provided condition is satisfied.
    current_match = compiled_pattern.search(string, pos)
```

I know it's kind of horrible but it's the only thing that is consistent. If you want something else please open a bug.


I have a P3 you insensitive clod! :) That's not a bother, but I do have a very basic VIA C7 that I should test this on.


@rsynek This is for you.


Thank you! Seems to work nicely :)


ack.


4.5.3 is .net 4.6 :-)
Implementing them could make us incompatible and someone would have to remember to take them out when you do our 4.5 binary references snapshot in the future


we could do that also. You think it is cleaner?


ack


Bump


89976832-HPWH-fan-not-autosizing-#4693 (rraustad) - x86_64-MacOS-10.9-clang: OK (1643 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


The upgrade function must not prompt the user directly.  This information needs to be provided by the caller through some kind of callback mechanism.


@mondiaz The EmailDistQuery test looks good too. Same question regarding closing the popup window. Is the comment meant for the person running the test?


vip['interface'] ends with '_vip', this substr() call will check for _vip in the beggining. If I understood it correct, it should be replaced by:
```
substr($vip['interface'], -4) == '_vip'
```


In this commit, you introduced a little duplication in `_favorite.html.erb`, where you created a new `Favorite` twice. Not a big deal, but that could be improved at a very low cost, by creating a (for instance) `@blank_favorite` instance in the controller action which is rendering the view calling `render partial:`. Little improvement scaling to x2 better performance, as far as the `Favorite` is concerned!


With the new definitions in Performance Timeline, I believe we can remove the following definitions:
[[
interface WorkerPerformance {
  DOMHighResTimeStamp now();
};

partial interface WorkerGlobalScope {
  readonly attribute WorkerPerformance performance;
};
]]


@volaya  Btw, I added `tree.findFirstItem(element)` in f068cf5, for convenient substitution of `tree.findAllItems(element)[0]` calls.

When no element if found, it returns `None`, which is better than an out-of-range index error in this case. Worse case, when using `findFirstItem(element)` to add to `toUpdate` here, is that `[None]` is passed to the refresh operation, thereby refreshing everything (still better than an error IMO).


Why not just `uint32_t real_filenumber = filenumber + 1;`?


Shouldn't this change be in src/main/html/index.html so it gets built and retained?


when will arrive sync with WPP with 250 new opcodes? :) thx


Didn't you see the comments on https://github.com/plone/Products.PlonePAS/commit/112aa701e05b0c96657a6e641985e01abdb7f759 ?


Not sold on doing this, as didDismissWithButton: gets called even if the device goes to sleep while an alert is visible.

There's a set of delegate methods on Harpy that you can make use of to perform an action after a button is pressed.

I'm more than happy to continue the conversation here, but I'm going to close the PR as I don't agree with this change.


ack.


I thought that sort of error return value was banned by the api design doc?


Please remove the options. It was not in the original tests, and it is the source of the freezing issue that I fixed.


Soon (TM)


Nit: I think these names might be a little confusing. Could we just continue to call this `user_id`, and call the `[]Rooms` something like `unread`? (There's probably a better name than `unread` -- I guess that's a little confusing or ambiguous too.)


Soon™


I am pretty sure this change is not reflected in the docs. Here is the excerpt:

```
    The callee is responsible for stopping closing the stream when an error happens
    by calling :c:func:`uv_read_stop` or :c:func:`uv_close`. Trying to read
    from the stream again is undefined.
```

Also, please clarify, is it still undefined behaviour to call `uv_read_start` again after an error or is it ok?


Please squash this commit with the previous one.


respawn quest or quest can do well and mobs of wod when


saves about 2 lines and directly relates config to default_sections.


I think you should also add the python-memcached package dependency in tox..


that may occur duels and also can enter bg sand and when we


Should we mention that it can remain empty?


This name change shouldn't be here right?


don't tell me that's convention


edit the if condition with boxes or objects


Why the rewrite of the imports in *_gae.py* and *adapters/__init__.py*?


@deadmanevil: refer to the 2 comments above yours


Nods, and that's a pretty good reason not to use 'private' at that spot. I don't think it was useful to begin with.


You can make this prettier/easier to read by using some more indentation:

``` ruby
@another_post = Post.create(
                               user: @user,
                               body: "Damn the body of a post is long.",
                               title: "Title for anothe post.",
                               topic: Topic.create(name: 'Topic name'),
                             )
```


pushed corrected version.

2015-03-11 19:48 GMT+01:00 Udayan12167 <notifications@github.com>:

> saves about 2 lines and directly relates config to default_sections.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/6ed3f581e7f6fbc3048ae2a1cc9d3e201226025e#commitcomment-10149661>
> .
>


`output[:success] = true` wouldn't touch other keys either, I'm pretty sure I'll be the first one not following this convention :-)


no, this kind of implicates for me that the user can do with it what he wants.


Added function check


Not sure if this was a bug


Nice!


How does this solve that `You may need an appropriate loader to handle this file type.` issue? Just curious. :)


And btw, why renaming *adapters/google.py* to *adapters/google_adapters.py*?


Yes, the fix is here https://github.com/Euphoria-OS/android_packages_apps_Settings/commit/a1525095e3e7a1043fdbb1f07ea50de17ef876b7

Haven't got time to merge anything to legacy yet.


I can't find where you are using this? I think this could be done with generate_flags?


Hehe.  I'd be curious to know what it does on the P3, if you ever have occasion to try.  This was a prerequisite to patching libjpeg-turbo in place of FreeImage's stock libjpeg, so I figured I may as well try it in advance and see if anyone complains.  Guess I've got my first complaint!  ;)


Nice catch! I didn't even see that!


This happens because if you would use pieces[i][j], your inner for loop would be appending the values of the first column instead of the first row. I suggest to modify for clarification.

for(int y = 0; y < DEFAULT_BOARD_SIZE; y++){
			stringBuilder.append(DEFAULT_BOARD_SIZE - y);
			stringBuilder.append(" ");

			for(int x = 0; x< DEFAULT_BOARD_SIZE; x++){

				// I'm not sure why I have to reverse i and j to get it to print out correctly
				// Need to investigate
				if(pieces[x][y]!=null){
					stringBuilder.append(pieces[x][y].toString());
				}else{
					stringBuilder.append('.');
				}

			}
			stringBuilder.append("\n");
		}


This fixed build on non-master django. It appears that master django fails for other reasons such as use of modules that don’t exist anymore.


Nice catch! Fixed.


Yes, but Today im found how to do it. Create character, play 1 or more arena. Turn server off, start it and login.


As RequestOptions already is mutable in other ways anyway I couldn't see why not.


Those never bubble up in `trigger`


То есть последовательность ``%5d`` не является допустимой?


actually one more question - what is `Action persistence`?


rax retry tests


Hey @rpeterson, this is looking pretty solid. I should clarify, though, that part of the challenge here will be that we need to differentiate between unread rooms within Landline and unread rooms vis-à-vis the external service -- so when an external app requests a user's unreads, we need to send a different response than when the Landline client requests unreads.

The challenge comes in because Landline clients know more about the users and rooms than external clients do. When an external client requests unreads, the API needs to match up its `user_id`s with the `external_id` field on each User; similarly, instead of just passing down the `room_id` like it would for a Landline client, it needs to send the external client each room's `slug` and `topic` instead.

Make sense?


yes. how?


Ah crap forgot to merge in your generate helper.  Nice catch!


Not currently, but I can add that as an option. My concern would be with how duplicates are detected in entries with multiple subtypes: should it just check the first terms for a match, or all of them?


Yes, this is shell-dependent :)


@eviltoylet Do you want to discuss APIs for the schematic? If we can agree on something, I don't mind spending time on this. :)


嗨,

hjwdzh@gmail.com 想關注您

****** hjwdzh@gmail.com 是您的朋友嗎？ ******
好/是: http://invites.infoaxe.net/signup_e.html?fullname=Hjwdzh/physbam-drive-pc&email=reply@reply.github.com&invitername=hjwdzh&inviterid=37132591&userid=0&token=0&emailmasterid=cc3ded21-e77d-4b3c-b0df-bd46c83d94ca&from=hjwdzh@gmail.com&src=txt_yes

不/否: http://invites.infoaxe.net/signup_e.html?fullname=Hjwdzh/physbam-drive-pc&email=reply@reply.github.com&invitername=hjwdzh&inviterid=37132591&userid=0&token=0&emailmasterid=cc3ded21-e77d-4b3c-b0df-bd46c83d94ca&from=hjwdzh@gmail.com&src=txt_no

按一下這裡，將您自己從所有這類電子郵件移除
http://invites.infoaxe.net/uns_inviter.jsp?email=reply@reply.github.com&iid=cc3ded21-e77d-4b3c-b0df-bd46c83d94ca&from=hjwdzh@gmail.com


Thanks Jacek - it looks awesome!
One thing that I was considering is that we should maybe add a `/site` switch in case that the harcoded mirror (kernel.org) is blocked by a corporate firewall. WDYT?


please remove <br/>


Nope, I've just had issues attaching the forked repo with composer back into my project.  If you're looking for the commit for the pull request, that should be: a29f8815cbd0d5e08aea59334c3efe2fc139d6d9.


because otherwise
    from google.appengine.ext import ndb
in adapters/__init__.py always fails since tries to import form the wrong module. It never worked until now.


Да, там ошибка была :)


Guess so, I'll accept a patch ;-)


You have to do this because the test was making use of the refs to the MenuItems. I'd rather update the test to not be dependent on refs than impose this function wrapper. The first test is failing without this change, but the second passes without wrapping it. The same would apply anywhere you are adding this wrapper.


My own. Here are the necessary lines for Startify: https://github.com/mhinz/vim-janah/blob/master/colors/janah.vim#L116-L125


yeah, this was a mistake


Just did it for you: https://github.com/web2py/pydal/commit/4f093a3f37058360c10aa5f82ce9230682921852


Unnecessary space


Chatted with @mondiaz about the comments and confirmed the tests do not close the popup, so +1 and merging this test.


Not very sure what the callbacks are, since I am not that familiar with OpenGL/GLFW, but its nice to see the addition of functional interfaces and programming to meet Java 8 design patterns.


it's removed in https://github.com/satnogs/satnogs-client/commit/26dd9c7c601a06330a4b59993c03a88dc63f4910


Yes, thank you. Fixed in 53c618d52fcb7d080d21d0c8647ca76c41d125db


After some test, all seems to be good (in admin side or user side)


I tested it locally, got the original error, then changed it and it loaded properly after I changed it.

But. Still not working when I run the test script. :( So weird. So, re-opening.


@gck-ableton: isn't this function already in `testUtils.js`?


I'll wait you to complete the refractor of the google stuff, then we **should** review the imports, because the idea behind having a *_gae.py* file was to avoid direct google imports inside *adapters/\__init\__.py*, changed by your commit.


Thank you, fixed by using l1-norm. See 53c618d52fcb7d080d21d0c8647ca76c41d125db


I would be more than willing to change back to public.


Thanks, I was also a little bit suprised that the effect was used so sparsely.


Since we had a lot if discussions about wording lately.
My intention was to reflect that maximizing the library not automatically means ``fill the whole screen``, but the available screen. E.g. if the application window itself is not maximize, or a (future) skin displays mini decks above the maximized library.


yes, the goal of this test is the ensure the rubyipmi logger is used instead of the smart-proxy logger.


In the end this will be made mode generic so that every service will use the same pattern. But yeah I too think that  *_ENVIRONMENT might be better.


OK but I did not change that. The google imports were already in adapters/__init__.py.
All I changed was to avoid a big try except to make sure actual errors with our adapters are reported.