1: D100 Docstring missing
2: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils
41:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.records.api
45:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly, warning_page, write_warning
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.webjournal should be before from invenio.legacy.webuser
50:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
50:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webjournal
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
53:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, guess_primary_collection_of_a_record, is_user_owner_of_record, record_exists
54:6: E126 continuation line over-indented for hanging indent
57:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
57:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.search_engine
60:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
63:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.search.models
69:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
69:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
69:1: E402 module level import not at top of file
70:6: E126 continuation line over-indented for hanging indent
76: D101 Docstring missing
78: D102 Docstring missing
118:94: E203 whitespace before ':'
120:30: E127 continuation line over-indented for visual indent
120:95: E502 the backslash is redundant between brackets
120:76: E203 whitespace before ':'
120:92: E203 whitespace before ':'
128:60: E502 the backslash is redundant between brackets
129:52: E251 unexpected spaces around keyword / parameter equals
129:54: E251 unexpected spaces around keyword / parameter equals
158:17: E266 too many leading '#' for block comment
159:17: E266 too many leading '#' for block comment
177:13: E266 too many leading '#' for block comment
201:37: E266 too many leading '#' for block comment
202:37: E266 too many leading '#' for block comment
205:45: E128 continuation line under-indented for visual indent
212:107: E203 whitespace before ':'
214:37: E122 continuation line missing indentation or outdented
214:102: E502 the backslash is redundant between brackets
214:83: E203 whitespace before ':'
214:99: E203 whitespace before ':'
215:41: E128 continuation line under-indented for visual indent
276:25: E128 continuation line under-indented for visual indent
276:79: E502 the backslash is redundant between brackets
277:41: E127 continuation line over-indented for visual indent
278:54: E502 the backslash is redundant between brackets
279:25: E128 continuation line under-indented for visual indent
281:25: E126 continuation line over-indented for hanging indent
288:25: E127 continuation line over-indented for visual indent
289:25: E127 continuation line over-indented for visual indent
290:25: E127 continuation line over-indented for visual indent
291:25: E127 continuation line over-indented for visual indent
294: D400 First line should end with '.', not 't'
294: D205 Blank line missing between one-line summary and description
294: D208 Docstring is over-indented
306:1: E302 expected 2 blank lines, found 1
306: D290 White spaces around docstring should be trimmed.
306: D202 No blank lines allowed *after* function docstring, found 1
306: D400 First line should end with '.', not 's'
315:13: E203 whitespace before ':'
322:13: E266 too many leading '#' for block comment
334:17: E266 too many leading '#' for block comment
349: D101 Docstring missing
353: D400 First line should end with '.', not 'd'
353: D200 One-line docstring should not occupy 3 lines
374:22: E126 continuation line over-indented for hanging indent
374:50: E203 whitespace before ':'
375:55: E203 whitespace before ':'
385:9: E122 continuation line missing indentation or outdented
438:96: E128 continuation line under-indented for visual indent
449:50: E502 the backslash is redundant between brackets
469:5: E128 continuation line under-indented for visual indent
479:26: E251 unexpected spaces around keyword / parameter equals
479:28: E251 unexpected spaces around keyword / parameter equals
482:111: E502 the backslash is redundant between brackets
482:34: E251 unexpected spaces around keyword / parameter equals
482:36: E251 unexpected spaces around keyword / parameter equals
483:37: E127 continuation line over-indented for visual indent
484:25: E251 unexpected spaces around keyword / parameter equals
484:27: E251 unexpected spaces around keyword / parameter equals
485:24: E251 unexpected spaces around keyword / parameter equals
485:26: E251 unexpected spaces around keyword / parameter equals
490: D202 No blank lines allowed *after* method docstring, found 1
490: D400 First line should end with '.', not 'e'
490: D300 Expected """-quotes, got '-quotes
505:16: E127 continuation line over-indented for visual indent
509:35: E128 continuation line under-indented for visual indent
510:35: E128 continuation line under-indented for visual indent
520:13: B901 blind except: statement
526:13: B901 blind except: statement
531:17: E128 continuation line under-indented for visual indent
532:17: E128 continuation line under-indented for visual indent
533:17: E128 continuation line under-indented for visual indent


true - thanks for spotting!


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2011
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. import datetime should be before from time
31:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be CFG_LOGDIR, CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_URL, CFG_WEBALERT_MAX_NUM_OF_RECORDS_IN_ALERT_EMAIL, CFG_WEBALERT_SEND_EMAIL_NUMBER_OF_TRIES, CFG_WEBALERT_SEND_EMAIL_SLEEPTIME_BETWEEN_TRIES
33:1: E402 module level import not at top of file
34:6: E126 continuation line over-indented for hanging indent
41:1: I101 Imported names are in the wrong order. Should be add_to_basket, get_basket_owner_id
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.webbasket.api should be before from invenio.legacy.webbasket.db_layer
42:1: E402 module level import not at top of file
43:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, perform_request_search
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.legacy.webbasket.api
43:1: E402 module level import not at top of file
44:6: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.search_engine
45:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.legacy.webuser
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: E402 module level import not at top of file
52:1: I101 Imported names are in the wrong order. Should be CFG_EXTERNAL_COLLECTION_MAXRESULTS_ALERTS, CFG_EXTERNAL_COLLECTION_TIMEOUT
52:1: E402 module level import not at top of file
53:1: E122 continuation line missing indentation or outdented
54:1: E122 continuation line missing indentation or outdented
55:1: E402 module level import not at top of file
56:1: E402 module level import not at top of file
57:1: E402 module level import not at top of file
59:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.collections.models
59:1: E402 module level import not at top of file
63:1: E302 expected 2 blank lines, found 1
63: D202 No blank lines allowed *after* function docstring, found 1
68:1: E302 expected 2 blank lines, found 1
68: D202 No blank lines allowed *after* function docstring, found 1
73:1: E302 expected 2 blank lines, found 1
73: D401 First line should be imperative: 'Return', not 'Returns'
73: D202 No blank lines allowed *after* function docstring, found 1
78:1: E302 expected 2 blank lines, found 1
78: D401 First line should be imperative: 'Return', not 'Returns'
78: D202 No blank lines allowed *after* function docstring, found 1
78: D400 First line should end with '.', not 'm'
84:1: E302 expected 2 blank lines, found 1
84: D202 No blank lines allowed *after* function docstring, found 1
84: D400 First line should end with '.', not 's'
94:29: E261 at least two spaces before inline comment
122:99: E502 the backslash is redundant between brackets
157:1: E302 expected 2 blank lines, found 1
157: D401 First line should be imperative: 'Return', not 'Returns'
157: D202 No blank lines allowed *after* function docstring, found 1
163:1: E302 expected 2 blank lines, found 1
172:37: E261 at least two spaces before inline comment
173:29: E261 at least two spaces before inline comment
203:99: E502 the backslash is redundant between brackets
262:1: E302 expected 2 blank lines, found 1
262: D202 No blank lines allowed *after* function docstring, found 1
267:1: E302 expected 2 blank lines, found 1
267: D401 First line should be imperative: 'Return', not 'Returns'
267: D202 No blank lines allowed *after* function docstring, found 1
271:6: E221 multiple spaces before operator
272:6: E221 multiple spaces before operator
273:7: E221 multiple spaces before operator
274:8: E221 multiple spaces before operator
275:6: E221 multiple spaces before operator
276:7: E221 multiple spaces before operator
277:7: E221 multiple spaces before operator
278:7: E221 multiple spaces before operator
279:7: E221 multiple spaces before operator
280:7: E221 multiple spaces before operator
281:7: E221 multiple spaces before operator
282:8: E221 multiple spaces before operator
283:7: E221 multiple spaces before operator
284:7: E221 multiple spaces before operator
285:7: E221 multiple spaces before operator
286:8: E221 multiple spaces before operator
287:7: E221 multiple spaces before operator
288:7: E221 multiple spaces before operator
289:7: E221 multiple spaces before operator
290:7: E221 multiple spaces before operator
298:25: E261 at least two spaces before inline comment
298:26: E262 inline comment should start with '# '
300:10: E261 at least two spaces before inline comment
305:18: E261 at least two spaces before inline comment
305:19: E262 inline comment should start with '# '
318:35: E128 continuation line under-indented for visual indent
319:35: E128 continuation line under-indented for visual indent
320:35: E128 continuation line under-indented for visual indent
324:1: E302 expected 2 blank lines, found 1
324: D209 Put multi-line docstring closing quotes on separate line
324: D202 No blank lines allowed *after* function docstring, found 1
367:1: E302 expected 2 blank lines, found 1
367: D209 Put multi-line docstring closing quotes on separate line
367: D202 No blank lines allowed *after* function docstring, found 1
380:1: E302 expected 2 blank lines, found 1
380: D209 Put multi-line docstring closing quotes on separate line
380: D202 No blank lines allowed *after* function docstring, found 1
393:1: E302 expected 2 blank lines, found 1
393: D209 Put multi-line docstring closing quotes on separate line
393: D202 No blank lines allowed *after* function docstring, found 1
405:1: E302 expected 2 blank lines, found 1
405: D209 Put multi-line docstring closing quotes on separate line
405: D202 No blank lines allowed *after* function docstring, found 1
422:1: E302 expected 2 blank lines, found 1
422: D401 First line should be imperative: 'Log', not 'Logs'
422: D202 No blank lines allowed *after* function docstring, found 1
433:1: E302 expected 2 blank lines, found 1
433: D209 Put multi-line docstring closing quotes on separate line
433: D202 No blank lines allowed *after* function docstring, found 1
433: D400 First line should end with '.', not 's'
433: D205 Blank line missing between one-line summary and description
451:82: E502 the backslash is redundant between brackets
456:106: E502 the backslash is redundant between brackets
461:1: E302 expected 2 blank lines, found 1
461: D202 No blank lines allowed *after* function docstring, found 1
461: D400 First line should end with '.', not '?'
466:1: E302 expected 2 blank lines, found 1
466: D202 No blank lines allowed *after* function docstring, found 1
466: D400 First line should end with '.', not '?'
471:1: E302 expected 2 blank lines, found 1
471: D209 Put multi-line docstring closing quotes on separate line
471: D202 No blank lines allowed *after* function docstring, found 1
480:31: E261 at least two spaces before inline comment
486:1: E302 expected 2 blank lines, found 1
486: D209 Put multi-line docstring closing quotes on separate line
486: D202 No blank lines allowed *after* function docstring, found 1
486: D400 First line should end with '.', not 's'
486: D205 Blank line missing between one-line summary and description
494:1: E302 expected 2 blank lines, found 1
494: D209 Put multi-line docstring closing quotes on separate line
494: D202 No blank lines allowed *after* function docstring, found 1
494: D205 Blank line missing between one-line summary and description
509:1: E302 expected 2 blank lines, found 1
509: D209 Put multi-line docstring closing quotes on separate line
509: D202 No blank lines allowed *after* function docstring, found 1
509: D400 First line should end with '.', not 's'
509: D205 Blank line missing between one-line summary and description
532: D209 Put multi-line docstring closing quotes on separate line
532: D205 Blank line missing between one-line summary and description
543:64: E261 at least two spaces before inline comment
543:65: E262 inline comment should start with '# '
555:1: E302 expected 2 blank lines, found 1
555: D202 No blank lines allowed *after* function docstring, found 1
555: D400 First line should end with '.', not 'l'
576:44: E261 at least two spaces before inline comment
576:45: E262 inline comment should start with '# '


2: L102 copyright year is outdated, expected 2015 but got 2013
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
36:1: I100 Imports statements are in the wrong order. import tempfile should be before import zlib
36:1: E402 module level import not at top of file
37:1: I100 Imports statements are in the wrong order. import sys should be before import tempfile
37:1: E402 module level import not at top of file
38:1: F401 'traceback' imported but unused
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: I201 Missing newline before sections or imports.
40:1: E402 module level import not at top of file
47:1: I101 Imported names are in the wrong order. Should be cache_exists, delete_cache, delete_hp_change, get_cache, get_cache_post_date, get_record_last_modification_date, get_record_revision_author, uids_with_active_caches, update_cache, update_cache_post_date
47:1: E402 module level import not at top of file
48:5: E128 continuation line under-indented for visual indent
49:5: E128 continuation line under-indented for visual indent
50:5: E128 continuation line under-indented for visual indent
51:1: I101 Imported names are in the wrong order. Should be create_record, create_records, field_add_subfield, field_get_subfield_codes, field_get_subfield_values, print_rec, record_add_field, record_add_fields, record_delete_fields, record_get_field_instances, record_get_field_value, record_get_field_values, record_has_field, record_make_all_subfields_volatile, record_modify_controlfield, record_modify_subfield, record_order_subfields, record_strip_empty_fields, record_strip_empty_volatile_subfields, record_xml_output
51:1: E402 module level import not at top of file
59:1: E402 module level import not at top of file
60:1: I101 Imported names are in the wrong order. Should be CFG_BIBEDIT_EXTEND_RECORD_WITH_COLLECTION_TEMPLATE, CFG_BIBEDIT_LOCKLEVEL, CFG_BIBEDIT_QUEUE_CHECK_METHOD, CFG_BIBEDIT_TIMEOUT, CFG_BIBUPLOAD_EXTERNAL_OAIID_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_PYLIBDIR
60:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibsched.bibtask
60:1: F401 'CFG_PYLIBDIR' imported but unused
60:1: E402 module level import not at top of file
66:1: E402 module level import not at top of file
67:1: E402 module level import not at top of file
68:1: I101 Imported names are in the wrong order. Should be get_bibupload_task_opts, get_info_of_record_revision, get_marcxml_of_record_revision, get_record_revisions
68:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibedit.db_layer should be before from invenio.utils.text
68:1: E402 module level import not at top of file
71:1: I101 Imported names are in the wrong order. Should be get_all_collections_of_a_record, get_record, guess_primary_collection_of_a_record, record_exists
71:1: E402 module level import not at top of file
72:6: E126 continuation line over-indented for hanging indent
74:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
74:1: E402 module level import not at top of file
75:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email, get_user_info, get_user_preferences, list_registered_users
75:1: E402 module level import not at top of file
76:6: E126 continuation line over-indented for hanging indent
77:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.legacy.webuser
77:1: E402 module level import not at top of file
78:1: E402 module level import not at top of file
79:1: E402 module level import not at top of file
80:1: I100 Imports statements are in the wrong order. from invenio.legacy.refextract.api should be before from invenio.modules.access.engine
80:1: E402 module level import not at top of file
81:36: E126 continuation line over-indented for hanging indent
83:1: I101 Imported names are in the wrong order. Should be ParseError, transform_file
83:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord.textmarc2xmlmarc should be before from invenio.legacy.refextract.api
83:1: E402 module level import not at top of file
84:1: E402 module level import not at top of file
85:1: I100 Imports statements are in the wrong order. from invenio.modules.editor.registry should be before from invenio.modules.knowledge.api
85:1: E402 module level import not at top of file
88:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.modules.editor.registry
88:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: E402 module level import not at top of file
95:5: F401 'loads' imported but unused
96:1: E402 module level import not at top of file
116: D101 Docstring missing
119:1: E302 expected 2 blank lines, found 1
119: D203 Expected 1 blank line *before* class docstring, found 0
119: D204 Expected 1 blank line *after* class docstring, found 0
119: D400 First line should end with '.', not 's'
125:1: E302 expected 2 blank lines, found 1
125: D290 White spaces around docstring should be trimmed.
125: D400 First line should end with '.', not 'n'
125: D205 Blank line missing between one-line summary and description
129: D290 White spaces around docstring should be trimmed.
129: D400 First line should end with '.', not 'e'
172:1: E302 expected 2 blank lines, found 1
172: D103 Docstring missing
178:1: E302 expected 2 blank lines, found 1
178: D401 First line should be imperative: 'Thi', not 'This'
178: D400 First line should end with '.', not 'l'
178: D205 Blank line missing between one-line summary and description
229:1: E302 expected 2 blank lines, found 1
229: D400 First line should end with '.', not 'e'
229: D205 Blank line missing between one-line summary and description
244:1: E302 expected 2 blank lines, found 1
244: D401 First line should be imperative: 'Ha', not 'Has'
244: D400 First line should end with '.', not 'y'
244: D205 Blank line missing between one-line summary and description
252:1: E302 expected 2 blank lines, found 1
252: D400 First line should end with '.', not 'l'
252: D205 Blank line missing between one-line summary and description
278:1: E302 expected 2 blank lines, found 1
278: D400 First line should end with '.', not 'e'
278: D205 Blank line missing between one-line summary and description
285:1: E302 expected 2 blank lines, found 1
294:1: E302 expected 2 blank lines, found 1
305:1: E302 expected 2 blank lines, found 1
305: D400 First line should end with '.', not 'n'
305: D205 Blank line missing between one-line summary and description
316:1: E302 expected 2 blank lines, found 1
320:1: E302 expected 2 blank lines, found 1
320: D205 Blank line missing between one-line summary and description
331:1: E302 expected 2 blank lines, found 1
331: D103 Docstring missing
335:1: E302 expected 2 blank lines, found 1
335: D400 First line should end with '.', not 'm'
335: D205 Blank line missing between one-line summary and description
403: D400 First line should end with '.', not 'd'
403: D205 Blank line missing between one-line summary and description
416: D290 White spaces around docstring should be trimmed.
416: D400 First line should end with '.', not 'd'
416: D200 One-line docstring should not occupy 2 lines
428: D290 White spaces around docstring should be trimmed.
428: D400 First line should end with '.', not 'e'
428: D205 Blank line missing between one-line summary and description
451: D400 First line should end with '.', not 'e'
451: D205 Blank line missing between one-line summary and description
481:24: E713 test for membership should be 'not in'
490:1: E302 expected 2 blank lines, found 1
490: D401 First line should be imperative: 'Convert', not 'Converts'
490: D400 First line should end with '.', not 'p'
490: D200 One-line docstring should not occupy 3 lines
497:1: E302 expected 2 blank lines, found 1
497: D401 First line should be imperative: 'Convert', not 'Converts'
497: D400 First line should end with '.', not 'e'
497: D200 One-line docstring should not occupy 3 lines
509:1: E302 expected 2 blank lines, found 1
509: D400 First line should end with '.', not 'd'
517:1: E302 expected 2 blank lines, found 1
517: D209 Put multi-line docstring closing quotes on separate line
517: D400 First line should end with '.', not 's'
517: D205 Blank line missing between one-line summary and description
517: D208 Docstring is over-indented
530:1: E302 expected 2 blank lines, found 1
530: D205 Blank line missing between one-line summary and description
540:1: E302 expected 2 blank lines, found 1
540: D205 Blank line missing between one-line summary and description
551:1: E302 expected 2 blank lines, found 1
551: D205 Blank line missing between one-line summary and description
558:1: E302 expected 2 blank lines, found 1
558: D205 Blank line missing between one-line summary and description
578:1: E302 expected 2 blank lines, found 1
584:1: E302 expected 2 blank lines, found 1
584: D103 Docstring missing
591:1: E302 expected 2 blank lines, found 1
591: D205 Blank line missing between one-line summary and description
607: D290 White spaces around docstring should be trimmed.
607: D205 Blank line missing between one-line summary and description
628:9: E128 continuation line under-indented for visual indent
631:1: E302 expected 2 blank lines, found 1
631: D209 Put multi-line docstring closing quotes on separate line
631: D400 First line should end with '.', not ']'
631: D205 Blank line missing between one-line summary and description
631: D208 Docstring is over-indented
670:1: E302 expected 2 blank lines, found 1
670: D401 First line should be imperative: 'Return', not 'Returns'
670: D400 First line should end with '.', not ']'
675:1: E302 expected 2 blank lines, found 1
693: D205 Blank line missing between one-line summary and description
701:1: E302 expected 2 blank lines, found 1
714:1: E302 expected 2 blank lines, found 1
754:1: E302 expected 2 blank lines, found 1
772: D400 First line should end with '.', not 's'
772: D205 Blank line missing between one-line summary and description
793: D401 First line should be imperative: 'Return', not 'Returns'
793: D290 White spaces around docstring should be trimmed.
793: D400 First line should end with '.', not '0'
793: D205 Blank line missing between one-line summary and description
804:61: E128 continuation line under-indented for visual indent
805:61: E128 continuation line under-indented for visual indent
806:61: E128 continuation line under-indented for visual indent
807:61: E128 continuation line under-indented for visual indent
810: D290 White spaces around docstring should be trimmed.
810: D400 First line should end with '.', not 't'
810: D205 Blank line missing between one-line summary and description
825: D290 White spaces around docstring should be trimmed.
825: D400 First line should end with '.', not 't'
848:48: E128 continuation line under-indented for visual indent
852:1: E266 too many leading '#' for block comment
854:1: E302 expected 2 blank lines, found 1
854: D400 First line should end with '.', not 'd'
896:1: E266 too many leading '#' for block comment
898:1: E302 expected 2 blank lines, found 1
898: D400 First line should end with '.', not 't'
898: D205 Blank line missing between one-line summary and description
916: D400 First line should end with '.', not 'e'
916: D205 Blank line missing between one-line summary and description
934:5: E122 continuation line missing indentation or outdented
950:36: E127 continuation line over-indented for visual indent
951:36: E127 continuation line over-indented for visual indent
952:36: E127 continuation line over-indented for visual indent
953:36: E127 continuation line over-indented for visual indent
957: D400 First line should end with '.', not 'n'
1013:1: E266 too many leading '#' for block comment
1015: D401 First line should be imperative: 'Create', not 'Creates'
1015: D400 First line should end with '.', not 'e'
1015: D205 Blank line missing between one-line summary and description
1030: D400 First line should end with '.', not 'n'
1030: D205 Blank line missing between one-line summary and description
1050: D401 First line should be imperative: 'Change', not 'Changes'
1050: D400 First line should end with '.', not ','
1050: D205 Blank line missing between one-line summary and description
1068:9: E128 continuation line under-indented for visual indent
1078:13: E128 continuation line under-indented for visual indent
1081: D401 First line should be imperative: 'Return', not 'Returns'
1081: D290 White spaces around docstring should be trimmed.
1081: D400 First line should end with '.', not 'e'
1106:1: E266 too many leading '#' for block comment
1109: D103 Docstring missing
1123:25: E128 continuation line under-indented for visual indent
1162: D401 First line should be imperative: 'Load', not 'Loads'
1162: D205 Blank line missing between one-line summary and description
1178:52: E201 whitespace after '{'
1178:62: E203 whitespace before ':'
1178:89: E203 whitespace before ':'
1178:105: E202 whitespace before '}'
1191: D401 First line should be imperative: 'Split', not 'Splits'
1191: D400 First line should end with '.', not ':'
1191: D205 Blank line missing between one-line summary and description
1191: D300 Expected """-quotes, got '''-quotes
1271: D401 First line should be imperative: 'Create', not 'Creates'
1271: D400 First line should end with '.', not 'e'
1271: D205 Blank line missing between one-line summary and description
1271: D300 Expected """-quotes, got '''-quotes
1306: D205 Blank line missing between one-line summary and description
1306: D300 Expected """-quotes, got '''-quotes


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: E402 module level import not at top of file
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from datetime should be before from intbitset
29:1: I201 Missing newline before sections or imports.
29:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before from invenio.legacy.search_engine
34:1: E402 module level import not at top of file
35:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_indexer should be before from invenio.legacy.bibrank.citation_searcher
35:1: E402 module level import not at top of file
36:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibformat.dblayer should be before from invenio.legacy.bibrank.citation_indexer
36:1: E402 module level import not at top of file
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.modules.records.api should be before from invenio.utils.shell
38:1: E402 module level import not at top of file
39:1: I101 Imported names are in the wrong order. Should be task_get_option, task_has_option, task_init, task_set_option, task_sleep_now_if_required, task_update_progress, write_message
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.modules.records.api
39:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
49: D103 Docstring missing
59: D103 Docstring missing
127:1: E266 too many leading '#' for block comment
128:1: E266 too many leading '#' for block comment
137:1: E266 too many leading '#' for block comment
143:1: E266 too many leading '#' for block comment
150:1: E266 too many leading '#' for block comment
155:1: E266 too many leading '#' for block comment
193:1: E266 too many leading '#' for block comment
194:1: E266 too many leading '#' for block comment
202:5: F841 local variable 'dummy' is assigned to but never used
264: D103 Docstring missing
439:60: E251 unexpected spaces around keyword / parameter equals
440:18: E127 continuation line over-indented for visual indent
447:13: W503 line break before binary operator
448:13: W503 line break before binary operator
498:1: E266 too many leading '#' for block comment


1: D290 White spaces around docstring should be trimmed.
1: D400 First line should end with '.', not 'e'
5: L102 copyright year is outdated, expected 2015 but got 2013
27:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
31:1: I101 Imported names are in the wrong order. Should be check_comment_belongs_to_record, check_recID_is_in_range, check_user_can_attach_file_to_comments, check_user_can_send_comments, check_user_can_view_comment, check_user_can_view_comments, get_user_subscription_to_discussion, is_comment_deleted, perform_display_your_comments, perform_request_add_comment_or_remark, perform_request_display_comments_or_remarks, perform_request_report, perform_request_vote, query_get_comment, subscribe_user_to_discussion, toggle_comment_visibility, unsubscribe_user_from_discussion
31:1: I100 Imports statements are in the wrong order. from invenio.modules.comments.api should be before from six
31:1: E402 module level import not at top of file
32:32: E126 continuation line over-indented for hanging indent
49:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_PREFIX, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBCOMMENT_ALLOW_COMMENTS, CFG_WEBCOMMENT_ALLOW_REVIEWS, CFG_WEBCOMMENT_MAX_ATTACHED_FILES, CFG_WEBCOMMENT_MAX_ATTACHMENT_SIZE, CFG_WEBCOMMENT_USE_MATHJAX_IN_COMMENTS
49:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.comments.api
49:1: E402 module level import not at top of file
50:6: E126 continuation line over-indented for hanging indent
64:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, page_not_authorized
64:1: E402 module level import not at top of file
65:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly
65:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
65:1: E402 module level import not at top of file
66:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.legacy.webpage
66:1: E402 module level import not at top of file
67:6: E126 continuation line over-indented for hanging indent
68:1: I101 Imported names are in the wrong order. Should be make_canonical_urlargd, redirect_to_url
68:1: E402 module level import not at top of file
69:30: E126 continuation line over-indented for hanging indent
70:1: I100 Imports statements are in the wrong order. from invenio.utils.html should be before from invenio.utils.url
70:1: E402 module level import not at top of file
71:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.utils.html
71:1: E402 module level import not at top of file
72:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.ext.logging
72:1: E402 module level import not at top of file
73:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
73:1: E402 module level import not at top of file
74:1: E402 module level import not at top of file
75:1: E402 module level import not at top of file
76:1: I101 Imported names are in the wrong order. Should be InvenioWebAccessMailCookieDeletedError, InvenioWebAccessMailCookieError, mail_cookie_check_common, mail_cookie_create_authorize_action, mail_cookie_create_common
76:1: E402 module level import not at top of file
77:6: E126 continuation line over-indented for hanging indent
82:1: F401 'InvenioWebCommentError' imported but unused
82:1: E402 module level import not at top of file
83:6: E126 continuation line over-indented for hanging indent
85:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.comments.config
85:1: E402 module level import not at top of file
88:1: I100 Imports statements are in the wrong order. import os should be before import invenio.legacy.template
88:1: E402 module level import not at top of file
89:1: I201 Missing newline before sections or imports.
89:1: E402 module level import not at top of file
90:1: I101 Imported names are in the wrong order. Should be decompose_file, propose_next_docname, stream_file
90:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.utils
90:1: E402 module level import not at top of file
91:6: E126 continuation line over-indented for hanging indent
94:1: E402 module level import not at top of file
96:1: E302 expected 2 blank lines, found 1
96: D203 Expected 1 blank line *before* class docstring, found 0
102: D102 Docstring missing
104:34: E261 at least two spaces before inline comment
107: D401 First line should be imperative: 'Redirect', not 'Redirects'
107: D400 First line should end with '.', not 'n'
107: D200 One-line docstring should not occupy 3 lines
113: D205 Blank line missing between one-line summary and description
146:64: E261 at least two spaces before inline comment
155:86: E203 whitespace before ':'
157:90: E502 the backslash is redundant between brackets
157:63: E203 whitespace before ':'
157:87: E203 whitespace before ':'
158:17: E128 continuation line under-indented for visual indent
161:52: E502 the backslash is redundant between brackets
162:17: E128 continuation line under-indented for visual indent
162:21: E251 unexpected spaces around keyword / parameter equals
162:23: E251 unexpected spaces around keyword / parameter equals
195:51: E502 the backslash is redundant between brackets
196:85: E502 the backslash is redundant between brackets
198:53: E502 the backslash is redundant between brackets
225:17: E128 continuation line under-indented for visual indent
246:69: E225 missing whitespace around operator
249:78: E225 missing whitespace around operator
259:13: E303 too many blank lines (2)
260:25: E128 continuation line under-indented for visual indent
261:25: E128 continuation line under-indented for visual indent
262:25: E128 continuation line under-indented for visual indent
263:25: E128 continuation line under-indented for visual indent
263:38: E251 unexpected spaces around keyword / parameter equals
263:40: E251 unexpected spaces around keyword / parameter equals
264:25: E128 continuation line under-indented for visual indent
265:25: E128 continuation line under-indented for visual indent
266:25: E128 continuation line under-indented for visual indent
267:25: E128 continuation line under-indented for visual indent
268:21: E127 continuation line over-indented for visual indent
269:21: E127 continuation line over-indented for visual indent
270:21: E127 continuation line over-indented for visual indent
271:21: E127 continuation line over-indented for visual indent
284: D400 First line should end with '.', not '0'
284: D205 Blank line missing between one-line summary and description
328:86: E203 whitespace before ':'
332:53: E127 continuation line over-indented for visual indent
337:53: E127 continuation line over-indented for visual indent
339:90: E502 the backslash is redundant between brackets
339:63: E203 whitespace before ':'
339:87: E203 whitespace before ':'
340:17: E128 continuation line under-indented for visual indent
343:52: E502 the backslash is redundant between brackets
344:17: E128 continuation line under-indented for visual indent
344:21: E251 unexpected spaces around keyword / parameter equals
344:23: E251 unexpected spaces around keyword / parameter equals
350:56: E502 the backslash is redundant between brackets
351:48: E251 unexpected spaces around keyword / parameter equals
351:50: E251 unexpected spaces around keyword / parameter equals
354:13: E303 too many blank lines (2)
359:56: E502 the backslash is redundant between brackets
360:48: E251 unexpected spaces around keyword / parameter equals
360:50: E251 unexpected spaces around keyword / parameter equals
377:26: E261 at least two spaces before inline comment
383:55: E261 at least two spaces before inline comment
393:109: E502 the backslash is redundant between brackets
399:25: B901 blind except: statement
402:21: E266 too many leading '#' for block comment
403:21: E266 too many leading '#' for block comment
408:25: F841 local variable 'n' is assigned to but never used
424:32: E127 continuation line over-indented for visual indent
432:41: E128 continuation line under-indented for visual indent
445:21: B901 blind except: statement
459:69: E225 missing whitespace around operator
463:92: E127 continuation line over-indented for visual indent
464:92: E127 continuation line over-indented for visual indent
465:92: E127 continuation line over-indented for visual indent
465:107: E225 missing whitespace around operator
466:92: E127 continuation line over-indented for visual indent
467:92: E127 continuation line over-indented for visual indent
467:107: E225 missing whitespace around operator
477:69: E127 continuation line over-indented for visual indent
481:99: E502 the backslash is redundant between brackets
481:74: E225 missing whitespace around operator
481:93: E225 missing whitespace around operator
482:86: E502 the backslash is redundant between brackets
482:78: E225 missing whitespace around operator
484:59: F841 local variable 'e' is assigned to but never used
538: D202 No blank lines allowed *after* method docstring, found 1
538: D205 Blank line missing between one-line summary and description
580:86: E203 whitespace before ':'
582:90: E502 the backslash is redundant between brackets
582:63: E203 whitespace before ':'
582:87: E203 whitespace before ':'
583:17: E128 continuation line under-indented for visual indent
586:52: E502 the backslash is redundant between brackets
587:17: E128 continuation line under-indented for visual indent
587:21: E251 unexpected spaces around keyword / parameter equals
587:23: E251 unexpected spaces around keyword / parameter equals
591:52: E502 the backslash is redundant between brackets
592:44: E251 unexpected spaces around keyword / parameter equals
592:46: E251 unexpected spaces around keyword / parameter equals
597:52: E502 the backslash is redundant between brackets
598:44: E251 unexpected spaces around keyword / parameter equals
598:46: E251 unexpected spaces around keyword / parameter equals
602:52: E502 the backslash is redundant between brackets
603:44: E251 unexpected spaces around keyword / parameter equals
603:46: E251 unexpected spaces around keyword / parameter equals
617: D202 No blank lines allowed *after* method docstring, found 1
617: D400 First line should end with '.', not 't'
617: D205 Blank line missing between one-line summary and description
657:86: E203 whitespace before ':'
659:90: E502 the backslash is redundant between brackets
659:63: E203 whitespace before ':'
659:87: E203 whitespace before ':'
660:17: E128 continuation line under-indented for visual indent
663:52: E502 the backslash is redundant between brackets
664:17: E128 continuation line under-indented for visual indent
664:21: E251 unexpected spaces around keyword / parameter equals
664:23: E251 unexpected spaces around keyword / parameter equals
668:52: E502 the backslash is redundant between brackets
669:44: E251 unexpected spaces around keyword / parameter equals
669:46: E251 unexpected spaces around keyword / parameter equals
674:52: E502 the backslash is redundant between brackets
675:44: E251 unexpected spaces around keyword / parameter equals
675:46: E251 unexpected spaces around keyword / parameter equals
679:52: E502 the backslash is redundant between brackets
680:44: E251 unexpected spaces around keyword / parameter equals
680:46: E251 unexpected spaces around keyword / parameter equals
691:90: E225 missing whitespace around operator
694: D400 First line should end with '.', not 'w'
694: D205 Blank line missing between one-line summary and description
706:86: E203 whitespace before ':'
708:90: E502 the backslash is redundant between brackets
708:63: E203 whitespace before ':'
708:87: E203 whitespace before ':'
709:17: E128 continuation line under-indented for visual indent
712:52: E502 the backslash is redundant between brackets
713:17: E128 continuation line under-indented for visual indent
713:21: E251 unexpected spaces around keyword / parameter equals
713:23: E251 unexpected spaces around keyword / parameter equals
720: D200 One-line docstring should not occupy 3 lines
730:86: E203 whitespace before ':'
732:90: E502 the backslash is redundant between brackets
732:63: E203 whitespace before ':'
732:87: E203 whitespace before ':'
733:17: E128 continuation line under-indented for visual indent
741: D400 First line should end with '.', not 'r'
741: D200 One-line docstring should not occupy 3 lines
757:63: E502 the backslash is redundant between brackets
758:90: E502 the backslash is redundant between brackets
761:1: E302 expected 2 blank lines, found 1
761: D203 Expected 1 blank line *before* class docstring, found 0
761: D208 Docstring is over-indented
769: D102 Docstring missing
771:34: E261 at least two spaces before inline comment
773: D401 First line should be imperative: 'Thi', not 'This'
773: D290 White spaces around docstring should be trimmed.
773: D400 First line should end with '.', not 'g'
773: D205 Blank line missing between one-line summary and description
780:28: E261 at least two spaces before inline comment
782:43: E261 at least two spaces before inline comment
795: D401 First line should be imperative: 'Return', not 'Returns'
809:9: F841 local variable 'uid' is assigned to but never used
815:86: E203 whitespace before ':'
817:90: E502 the backslash is redundant between brackets
817:63: E203 whitespace before ':'
817:87: E203 whitespace before ':'
818:17: E128 continuation line under-indented for visual indent
821:52: E502 the backslash is redundant between brackets
822:44: E251 unexpected spaces around keyword / parameter equals
822:46: E251 unexpected spaces around keyword / parameter equals
835:86: E203 whitespace before ':'
837:90: E502 the backslash is redundant between brackets
837:63: E203 whitespace before ':'
837:87: E203 whitespace before ':'
838:17: E128 continuation line under-indented for visual indent
841:52: E502 the backslash is redundant between brackets
842:44: E251 unexpected spaces around keyword / parameter equals
842:46: E251 unexpected spaces around keyword / parameter equals
847:52: E502 the backslash is redundant between brackets
848:44: E251 unexpected spaces around keyword / parameter equals
848:46: E251 unexpected spaces around keyword / parameter equals
854:73: E502 the backslash is redundant between brackets
855:82: E502 the backslash is redundant between brackets
855:57: E221 multiple spaces before operator
860:69: E502 the backslash is redundant between brackets
862:20: E127 continuation line over-indented for visual indent
872:1: E302 expected 2 blank lines, found 1
872: D203 Expected 1 blank line *before* class docstring, found 0
877: D202 No blank lines allowed *after* method docstring, found 1
893:65: E502 the backslash is redundant between brackets
894:46: E127 continuation line over-indented for visual indent
901:30: E203 whitespace before ':'
904:25: E203 whitespace before ':'
910:52: E502 the backslash is redundant between brackets
911:44: E251 unexpected spaces around keyword / parameter equals
911:46: E251 unexpected spaces around keyword / parameter equals
920:30: E251 unexpected spaces around keyword / parameter equals
921:34: E126 continuation line over-indented for hanging indent
921:49: E203 whitespace before ':'
923:43: E203 whitespace before ':'
924:31: E126 continuation line over-indented for hanging indent


1: D100 Docstring missing
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: I100 Imports statements are in the wrong order. import fnmatch should be before import time
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
36:1: I201 Missing newline before sections or imports.
36:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
38:1: E402 module level import not at top of file
39:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_ADDING_RECORDS_STARTED_STR, CFG_BIBINDEX_INDEX_TABLE_TYPE, CFG_BIBINDEX_SPECIAL_TAGS, CFG_BIBINDEX_TOKENIZER_TYPE, CFG_BIBINDEX_UPDATE_MESSAGE, CFG_BIBINDEX_UPDATE_MODE, CFG_BIBINDEX_WASH_INDEX_TERMS, CFG_CHECK_MYSQL_THREADS, CFG_MAX_MYSQL_THREADS, CFG_MYSQL_THREAD_TIMEOUT
39:1: E402 module level import not at top of file
40:6: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibauthority.config should be before from invenio.legacy.bibindex.engine_config
49:1: E402 module level import not at top of file
50:6: E126 continuation line over-indented for hanging indent
51:1: I101 Imported names are in the wrong order. Should be get_control_nos_from_recID, get_index_strings_by_control_no
51:1: F401 'get_index_strings_by_control_no' imported but unused
51:1: E402 module level import not at top of file
52:6: E126 continuation line over-indented for hanging indent
53:1: I101 Imported names are in the wrong order. Should be get_synonym_terms, perform_request_search, search_pattern
53:1: E402 module level import not at top of file
54:6: E126 continuation line over-indented for hanging indent
56:1: I101 Imported names are in the wrong order. Should be DatabaseError, deserialize_via_marshal, run_sql, serialize_via_marshal, wash_table_column_name
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.legacy.search_engine
56:1: E402 module level import not at top of file
57:6: E126 continuation line over-indented for hanging indent
58:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_washer should be before from invenio.legacy.dbquery
58:1: E402 module level import not at top of file
59:1: I101 Imported names are in the wrong order. Should be get_datetime, task_get_option, task_get_task_param, task_init, task_set_option, task_sleep_now_if_required, task_update_progress, write_message
59:1: E402 module level import not at top of file
62:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.legacy.bibsched.bibtask
62:1: E402 module level import not at top of file
63:1: I201 Missing newline before sections or imports.
63:1: E402 module level import not at top of file
64:1: F401 'get_def_name' imported but unused
64:1: E402 module level import not at top of file
65:1: E402 module level import not at top of file
66:1: I101 Imported names are in the wrong order. Should be CFG_JOURNAL_PUBINFO_STANDARD_FORM, CFG_JOURNAL_PUBINFO_STANDARD_FORM_REGEXP_CHECK, CFG_JOURNAL_TAG
66:1: F401 'CFG_JOURNAL_PUBINFO_STANDARD_FORM_REGEXP_CHECK' imported but unused
66:1: F401 'CFG_JOURNAL_PUBINFO_STANDARD_FORM' imported but unused
66:1: F401 'CFG_JOURNAL_TAG' imported but unused
66:1: E402 module level import not at top of file
70:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.termcollectors should be before from invenio.modules.indexer.tokenizers.BibIndexJournalTokenizer
70:1: E402 module level import not at top of file
71:1: I101 Imported names are in the wrong order. Should be filter_for_virtual_indexes, get_all_index_names_and_column_values, get_all_indexes, get_all_synonym_knowledge_bases, get_field_tags, get_index_remove_html_markup, get_index_remove_latex_markup, get_index_remove_stopwords, get_index_tags, get_index_virtual_indexes, get_marc_tag_indexes, get_min_last_updated, get_nonmarc_tag_indexes, get_records_range_for_index, get_virtual_index_building_blocks, list_union, load_tokenizers, make_prefix, recognize_marc_tag, remove_inexistent_indexes, run_sql_drop_silently
71:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.legacy.bibindex.termcollectors
71:1: F401 'get_field_tags' imported but unused
71:1: F401 'get_all_index_names_and_column_values' imported but unused
71:1: E402 module level import not at top of file
92:1: E402 module level import not at top of file
93:1: F401 'get_record' imported but unused
93:1: E402 module level import not at top of file
94:1: E402 module level import not at top of file
95:1: I101 Imported names are in the wrong order. Should be NonmarcTermCollector, TermCollector
95:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.termcollectors should be before from invenio.utils.memoise
95:1: F999 redefinition of unused 'TermCollector' from line 70
95:1: E402 module level import not at top of file
99:1: E402 module level import not at top of file
114:17: E261 at least two spaces before inline comment
115:25: E261 at least two spaces before inline comment
122: D401 First line should be imperative: 'Return', not 'Returns'
131: D400 First line should end with '.', not 'n'
131: D205 Blank line missing between one-line summary and description
131: D208 Docstring is over-indented
146:66: E502 the backslash is redundant between brackets
151: D400 First line should end with '.', not 'd'
151: D205 Blank line missing between one-line summary and description
180: D400 First line should end with '.', not 'e'
180: D205 Blank line missing between one-line summary and description
188: D209 Put multi-line docstring closing quotes on separate line
188: D205 Blank line missing between one-line summary and description
191:53: E502 the backslash is redundant between brackets
214:67: E225 missing whitespace around operator
215:30: E124 closing bracket does not match visual indentation
215:31: E261 at least two spaces before inline comment
224:33: E261 at least two spaces before inline comment
236:33: E261 at least two spaces before inline comment
247:33: E261 at least two spaces before inline comment
259:33: E261 at least two spaces before inline comment
270:33: E261 at least two spaces before inline comment
282:33: E261 at least two spaces before inline comment
292: D401 First line should be imperative: 'Remove', not 'Removes'
292: D300 Expected """-quotes, got '-quotes
297: D401 First line should be imperative: 'Return', not 'Returns'
297: D400 First line should end with '.', not 'd'
309: D401 First line should be imperative: 'Return', not 'Returns'
309: D400 First line should end with '.', not 'e'
309: D205 Blank line missing between one-line summary and description
309: D208 Docstring is over-indented
320:68: E502 the backslash is redundant between brackets
328: D401 First line should be imperative: 'Check', not 'Checks'
328: D205 Blank line missing between one-line summary and description
328: D208 Docstring is over-indented
349: D401 First line should be imperative: 'Return', not 'Returns'
349: D400 First line should end with '.', not 's'
351:10: E225 missing whitespace around operator
366:56: E261 at least two spaces before inline comment
374: D290 White spaces around docstring should be trimmed.
374: D400 First line should end with '.', not 's'
374: D205 Blank line missing between one-line summary and description
385:70: E502 the backslash is redundant between brackets
386:32: E127 continuation line over-indented for visual indent
390: D401 First line should be imperative: 'Return', not 'Returns'
390: D400 First line should end with '.', not 'e'
390: D300 Expected """-quotes, got '-quotes
403: D401 First line should be imperative: 'Create', not 'Creates'
403: D209 Put multi-line docstring closing quotes on separate line
403: D400 First line should end with '.', not 'd'
403: D205 Blank line missing between one-line summary and description
422: D401 First line should be imperative: 'Return', not 'Returns'
422: D400 First line should end with '.', not 't'
444:74: E502 the backslash is redundant between brackets
448:52: E261 at least two spaces before inline comment
449:52: E261 at least two spaces before inline comment
450:54: E261 at least two spaces before inline comment
451:54: E261 at least two spaces before inline comment
454: D205 Blank line missing between one-line summary and description
454: D208 Docstring is over-indented
464:70: E502 the backslash is redundant between brackets
470: D290 White spaces around docstring should be trimmed.
470: D400 First line should end with '.', not 'd'
480: D401 First line should be imperative: 'find_affected_record', not 'find_affected_records'
480: D205 Blank line missing between one-line summary and description
480: D208 Docstring is over-indented
491: D202 No blank lines allowed *after* function docstring, found 1
491: D400 First line should end with '.', not 'd'
491: D205 Blank line missing between one-line summary and description
491: D208 Docstring is over-indented
512:37: E127 continuation line over-indented for visual indent
538:24: E127 continuation line over-indented for visual indent
547:20: E126 continuation line over-indented for hanging indent
585: D401 First line should be imperative: 'Split', not 'Splits'
585: D400 First line should end with '.', not 's'
585: D205 Blank line missing between one-line summary and description
585: D208 Docstring is over-indented
606: D203 Expected 1 blank line *before* class docstring, found 0
606: D205 Blank line missing between one-line summary and description
606: D208 Docstring is over-indented
625: D102 Docstring missing
630:65: E502 the backslash is redundant between brackets
631:49: E128 continuation line under-indented for visual indent
631:57: E502 the backslash is redundant between brackets
632:49: E128 continuation line under-indented for visual indent
632:62: E502 the backslash is redundant between brackets
633:49: E128 continuation line under-indented for visual indent
636:24: E261 at least two spaces before inline comment
639: D401 First line should be imperative: 'Update', not 'Updates'
639: D400 First line should end with '.', not 'B'
639: D205 Blank line missing between one-line summary and description
639: D208 Docstring is over-indented
644:57: E502 the backslash is redundant between brackets
646:64: E502 the backslash is redundant between brackets
648:62: E502 the backslash is redundant between brackets
649:23: E128 continuation line under-indented for visual indent
668:63: E502 the backslash is redundant between brackets
671:73: E502 the backslash is redundant between brackets
676:62: E502 the backslash is redundant between brackets
690:65: E502 the backslash is redundant between brackets
702:75: E502 the backslash is redundant between brackets
708:55: E502 the backslash is redundant between brackets
710:54: E502 the backslash is redundant between brackets
711:23: E128 continuation line under-indented for visual indent
713: D400 First line should end with '.', not 'y'
716:28: E261 at least two spaces before inline comment
720:74: E502 the backslash is redundant between brackets
724:74: E502 the backslash is redundant between brackets
726:134: E261 at least two spaces before inline comment
728:14: E261 at least two spaces before inline comment
729:70: E502 the backslash is redundant between brackets
733:142: E261 at least two spaces before inline comment
735:17: E266 too many leading '#' for block comment
736:17: E266 too many leading '#' for block comment
739:20: E261 at least two spaces before inline comment
740:104: E261 at least two spaces before inline comment
742: D401 First line should be imperative: 'Keep', not 'Keeps'
742: D400 First line should end with '.', not 'g'
742: D205 Blank line missing between one-line summary and description
742: D208 Docstring is over-indented
762:29: F841 local variable 'e' is assigned to but never used
763:84: E502 the backslash is redundant between brackets
775: D400 First line should end with '.', not 'y'
775: D205 Blank line missing between one-line summary and description
789: D401 First line should be imperative: 'Clean', not 'Cleans'
789: D300 Expected """-quotes, got '-quotes
794: D203 Expected 1 blank line *before* class docstring, found 0
794: D205 Blank line missing between one-line summary and description
794: D208 Docstring is over-indented
810: D401 First line should be imperative: 'Create', not 'Creates'
810: D205 Blank line missing between one-line summary and description
810: D208 Docstring is over-indented
819:43: E127 continuation line over-indented for visual indent
820:43: E127 continuation line over-indented for visual indent
821:43: E127 continuation line over-indented for visual indent
825: D401 First line should be imperative: 'Set', not 'Sets'
825: D400 First line should end with '.', not 'l'
825: D205 Blank line missing between one-line summary and description
825: D208 Docstring is over-indented
833: D205 Blank line missing between one-line summary and description
833: D208 Docstring is over-indented
852:85: E502 the backslash is redundant between brackets
874:28: E126 continuation line over-indented for hanging indent
877:87: E502 the backslash is redundant between brackets
907: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
907: D202 No blank lines allowed *after* method docstring, found 1
907: D400 First line should end with '.', not 'x'
907: D205 Blank line missing between one-line summary and description
907: D208 Docstring is over-indented
927: D401 First line should be imperative: 'Retrieve', not 'Retrieves'
927: D202 No blank lines allowed *after* method docstring, found 1
927: D400 First line should end with '.', not 'x'
927: D205 Blank line missing between one-line summary and description
927: D208 Docstring is over-indented
947: D401 First line should be imperative: 'Update', not 'Updates'
947: D400 First line should end with '.', not ':'
947: D205 Blank line missing between one-line summary and description
947: D208 Docstring is over-indented
977:55: E502 the backslash is redundant between brackets
978:24: E127 continuation line over-indented for visual indent
979:24: E127 continuation line over-indented for visual indent
979:69: E261 at least two spaces before inline comment
981:174: E261 at least two spaces before inline comment
985: D401 First line should be imperative: 'Insert', not 'Inserts'
985: D400 First line should end with '.', not 'e'
985: D205 Blank line missing between one-line summary and description
985: D208 Docstring is over-indented
1013:179: E261 at least two spaces before inline comment
1015:174: E261 at least two spaces before inline comment
1019: D401 First line should be imperative: 'Remove', not 'Removes'
1019: D400 First line should end with '.', not 'd'
1019: D205 Blank line missing between one-line summary and description
1019: D208 Docstring is over-indented
1044:179: E261 at least two spaces before inline comment
1046:174: E261 at least two spaces before inline comment
1050: D401 First line should be imperative: 'Update', not 'Updates'
1050: D400 First line should end with '.', not 'o'
1050: D205 Blank line missing between one-line summary and description
1050: D208 Docstring is over-indented
1089: D401 First line should be imperative: 'Update', not 'Updates'
1089: D205 Blank line missing between one-line summary and description
1089: D208 Docstring is over-indented
1104: D401 First line should be imperative: 'Update', not 'Updates'
1104: D400 First line should end with '.', not 'd'
1104: D205 Blank line missing between one-line summary and description
1104: D208 Docstring is over-indented
1132: D401 First line should be imperative: 'Remove', not 'Removes'
1132: D400 First line should end with '.', not 'e'
1139: D401 First line should be imperative: 'Clean', not 'Cleans'
1139: D400 First line should end with '.', not ')'
1139: D205 Blank line missing between one-line summary and description
1139: D208 Docstring is over-indented
1146:18: E127 continuation line over-indented for visual indent
1150: D401 First line should be imperative: 'Remove', not 'Removes'
1150: D400 First line should end with '.', not ')'
1150: D205 Blank line missing between one-line summary and description
1150: D208 Docstring is over-indented
1167:5: E303 too many blank lines (2)
1167: D401 First line should be imperative: 'Remove', not 'Removes'
1167: D205 Blank line missing between one-line summary and description
1167: D208 Docstring is over-indented
1205: D203 Expected 1 blank line *before* class docstring, found 0
1205: D400 First line should end with '.', not 'x'
1205: D205 Blank line missing between one-line summary and description
1205: D208 Docstring is over-indented
1216: D401 First line should be imperative: 'Create', not 'Creates'
1216: D205 Blank line missing between one-line summary and description
1257: D401 First line should be imperative: 'Fill', not 'Fills'
1257: D400 First line should end with '.', not 'h'
1257: D205 Blank line missing between one-line summary and description
1257: D208 Docstring is over-indented
1280: D401 First line should be imperative: 'Prevent', not 'Prevents'
1280: D208 Docstring is over-indented
1280: D200 One-line docstring should not occupy 3 lines
1286: D401 First line should be imperative: 'Turn', not 'Turns'
1286: D208 Docstring is over-indented
1286: D200 One-line docstring should not occupy 3 lines
1292: D401 First line should be imperative: 'Return', not 'Returns'
1292: D209 Put multi-line docstring closing quotes on separate line
1292: D202 No blank lines allowed *after* method docstring, found 1
1292: D400 First line should end with '.', not 'e'
1292: D205 Blank line missing between one-line summary and description
1292: D208 Docstring is over-indented
1307: D401 First line should be imperative: 'Inform', not 'Informs'
1307: D205 Blank line missing between one-line summary and description
1307: D208 Docstring is over-indented
1327: D401 First line should be imperative: 'Display', not 'Displays'
1327: D300 Expected """-quotes, got '-quotes
1334: D401 First line should be imperative: 'Return', not 'Returns'
1334: D300 Expected """-quotes, got '-quotes
1338: D401 First line should be imperative: 'Print', not 'Prints'
1338: D300 Expected """-quotes, got '-quotes
1342: D202 No blank lines allowed *after* method docstring, found 1
1342: D300 Expected """-quotes, got '-quotes
1355:62: E502 the backslash is redundant between brackets
1356:17: E128 continuation line under-indented for visual indent
1358:75: E502 the backslash is redundant between brackets
1359:31: E127 continuation line over-indented for visual indent
1361: D401 First line should be imperative: 'Fetche', not 'Fetches'
1361: D400 First line should end with '.', not 's'
1361: D205 Blank line missing between one-line summary and description
1374:35: E261 at least two spaces before inline comment
1391:73: E502 the backslash is redundant between brackets
1392:25: E128 continuation line under-indented for visual indent
1402:73: E502 the backslash is redundant between brackets
1403:25: E128 continuation line under-indented for visual indent
1458:31: E701 multiple statements on one line (colon)
1479:27: E701 multiple statements on one line (colon)
1482:184: E261 at least two spaces before inline comment
1485:179: E261 at least two spaces before inline comment
1497: D401 First line should be imperative: 'Divide', not 'Divides'
1497: D209 Put multi-line docstring closing quotes on separate line
1497: D400 First line should end with '.', not ','
1497: D205 Blank line missing between one-line summary and description
1497: D208 Docstring is over-indented
1519: D209 Put multi-line docstring closing quotes on separate line
1519: D205 Blank line missing between one-line summary and description
1530:81: E502 the backslash is redundant between brackets
1531:17: E128 continuation line under-indented for visual indent
1534:63: E502 the backslash is redundant between brackets
1535:21: E128 continuation line under-indented for visual indent
1537: D401 First line should be imperative: 'Keep', not 'Keeps'
1537: D400 First line should end with '.', not 'g'
1537: D205 Blank line missing between one-line summary and description
1537: D208 Docstring is over-indented
1557:9: B901 blind except: statement
1561:5: E303 too many blank lines (2)
1561: D401 First line should be imperative: 'Fetche', not 'Fetches'
1561: D400 First line should end with '.', not 's'
1561: D205 Blank line missing between one-line summary and description
1577: D401 First line should be imperative: 'Delete', not 'Deletes'
1577: D209 Put multi-line docstring closing quotes on separate line
1577: D400 First line should end with '.', not 'w'
1577: D205 Blank line missing between one-line summary and description
1577: D208 Docstring is over-indented
1580:82: E502 the backslash is redundant between brackets
1581:17: E128 continuation line under-indented for visual indent
1591:80: E502 the backslash is redundant between brackets
1592:17: E128 continuation line under-indented for visual indent
1594: D401 First line should be imperative: 'Find', not 'Finds'
1594: D200 One-line docstring should not occupy 3 lines
1603: D400 First line should end with '.', not 'r'
1603: D205 Blank line missing between one-line summary and description
1627: D400 First line should end with '.', not 'e'
1645:35: E261 at least two spaces before inline comment
1676: D400 First line should end with '.', not 'e'
1678:9: E266 too many leading '#' for block comment
1684:19: E261 at least two spaces before inline comment
1686:9: E266 too many leading '#' for block comment
1689:17: E127 continuation line over-indented for visual indent
1694: D202 No blank lines allowed *after* method docstring, found 1
1694: D400 First line should end with '.', not 'y'
1694: D205 Blank line missing between one-line summary and description
1718:15: E261 at least two spaces before inline comment
1720:16: E713 test for membership should be 'not in'
1733:49: E713 test for membership should be 'not in'
1753:29: E128 continuation line under-indented for visual indent
1754:33: E128 continuation line under-indented for visual indent
1759:21: E126 continuation line over-indented for hanging indent
1770:13: E128 continuation line under-indented for visual indent
1771:13: E128 continuation line under-indented for visual indent
1794:13: E128 continuation line under-indented for visual indent
1795:13: E128 continuation line under-indented for visual indent
1811:13: E126 continuation line over-indented for hanging indent
1816:1: E302 expected 2 blank lines, found 1
1824:1: E302 expected 2 blank lines, found 1
1824: D290 White spaces around docstring should be trimmed.
1824: D400 First line should end with '.', not 'e'
1824: D205 Blank line missing between one-line summary and description
1858:78: E502 the backslash is redundant between brackets
1859:17: E128 continuation line under-indented for visual indent
1872:1: E302 expected 2 blank lines, found 1
1872: D290 White spaces around docstring should be trimmed.
1879: D401 First line should be imperative: 'Find', not 'Finds'
1879: D290 White spaces around docstring should be trimmed.
1879: D400 First line should end with '.', not ']'
1879: D205 Blank line missing between one-line summary and description
1879: D208 Docstring is over-indented
1898:36: E127 continuation line over-indented for visual indent
1904:41: E127 continuation line over-indented for visual indent
1907:36: E127 continuation line over-indented for visual indent
1913:41: E127 continuation line over-indented for visual indent
1918:36: E127 continuation line over-indented for visual indent
1925:41: E127 continuation line over-indented for visual indent
1946: D401 First line should be imperative: 'Find', not 'Finds'
1946: D290 White spaces around docstring should be trimmed.
1946: D400 First line should end with '.', not ']'
1946: D205 Blank line missing between one-line summary and description
1946: D208 Docstring is over-indented
1986:48: E261 at least two spaces before inline comment
1992: D401 First line should be imperative: 'Find', not 'Finds'
1992: D205 Blank line missing between one-line summary and description
1992: D208 Docstring is over-indented
2008: D401 First line should be imperative: 'Get', not 'Gets'
2008: D400 First line should end with '.', not 'n'
2008: D205 Blank line missing between one-line summary and description
2008: D208 Docstring is over-indented
2043: D401 First line should be imperative: 'Get', not 'Gets'
2043: D400 First line should end with '.', not 'e'
2043: D205 Blank line missing between one-line summary and description
2043: D208 Docstring is over-indented
2061: D401 First line should be imperative: 'Remove', not 'Removes'
2061: D205 Blank line missing between one-line summary and description
2061: D208 Docstring is over-indented
2085: D401 First line should be imperative: 'Decide', not 'Decides'
2085: D205 Blank line missing between one-line summary and description
2085: D208 Docstring is over-indented
2094: D205 Blank line missing between one-line summary and description
2094: D208 Docstring is over-indented
2127: D401 First line should be imperative: 'Run', not 'Runs'
2127: D205 Blank line missing between one-line summary and description
2127: D208 Docstring is over-indented
2183:85: E502 the backslash is redundant between brackets
2184:56: E128 continuation line under-indented for visual indent
2184:86: E502 the backslash is redundant between brackets
2185:56: E128 continuation line under-indented for visual indent
2191:5: E303 too many blank lines (2)
2212:29: E126 continuation line over-indented for hanging indent
2251:29: E126 continuation line over-indented for hanging indent
2263:25: E126 continuation line over-indented for hanging indent
2290:29: E126 continuation line over-indented for hanging indent
2304:25: E126 continuation line over-indented for hanging indent
2329:5: E303 too many blank lines (2)
2333:1: E266 too many leading '#' for block comment


Were you doing a ton of stuff when you got 21 seconds earlier? It should only double the calculation time to have all channels. In any case I'm okay with the ::2 solution, but I'm really curious why it would have taken so long for you in the first place.


@ronichoudhury, how do I merge in the control panel height stuff.  I see it here on the issue, but this is working in concert with a changed tangelo plugin, right?  So, I'd need to build tangelo from source, right?


this patch got me past the failing erlang download, thanks!


Just to be safe I'd say let's leave it as it was for now.  We could have a follow up to change this and analyze addon compat etc at that point.


The other filters are:

- `search_default_query`
- `search_default_query_type`
- `search_default_record_types`
- `search_element_texts`
- `search_form`


Code would be fine with me.


Thanks :-)


This version is actually better.


I believe you should rather use:

```php
$node = $this->composer->getConfig()->get('bin-dir').'/node';
```
Indeed, 'bin-dir' can be moved out of vendor in case the config/bin-dir option is passed in composer.json:
https://getcomposer.org/doc/articles/vendor-binaries.md#can-vendor-binaries-be-installed-somewhere-other-than-vendor-bin-


This comment could also explain that OD_QM8 is upsampled/downsampled depending on the size of the block.


I would go with:

"The returned promise will fulfill with the end signal value (or null if not present) after all the events have been consumed."


yes I multitask...

merge when done with nitpicks !


It is already merged (you can do a pull on your neon-integration branch).

This does depend on a newer Tangelo, at the control-panel-height branch.  You will need to build it from source.  Let me know if you run into any trouble.


for both UMLS you shoud edit the arrows between the devise and the model as the arrow which redierct to the view should come from the devise


Please make this field ```private final```. There is no Need to have it default visible


This should be:

`ipython --ipython-dir=~/ipython_ophyd --profile=BEAMLINE`


In opinion the result of this services.json is a result of  contents out of vendor (e.g. the config/app.php configured providers are included which might be own providers, which are not comming from vendor/*) and services.json has dependencies to vendor stuff - so its a mix of vendor specific and application specific stuff.

So I think the better place was storage/framework or if you like to differentiate why not create a folder storage/vendor ?


Oops. Thanks.


Note that we want to pass the actual validation error information to the user. Also having a top-level developer_message and/or user_message is somewhat optional.

return Response({"field_errors": err.field_errors}, status=status.HTTP_400_BAD_REQUEST)


Comente ese código.


You should read the ARM reference manual in order to figure out the cycle count of each instruction.


@lukasgraf good catch. will loosen it to `>= 0.19.1`


I found this commit looking for the error you had. This helped to solve my issue.
Most important, I found this awesome project! Thank you :D


This I think is identical to
```c#
transform.position = Vector3.MoveTowards(transform.position, playerChar.position, speed * Time.deltaTime);
```

speed is in unit/sec.

:P i have nothing to do lol


Good point, I changed that.


Hey again! How are you? :)
So... got more work on this for you. Let's say, we DON'T have a value in Config, but we have in database. In my case, in database, we have:

```php
key = triggers.stat_ad_create.special.myproject.ctr
value = "0.28"
```
Guess what
```php
Setting::get('triggers.stat_ad_create.special.myproject')
```
will return? It returns:
```php
float(0.28)
```
and should return:
```php
array(1) {
  ["ctr"]=>
  string(4) "0.28"
}
```


+1 for `AssertionError`.


It seems, that this constructor is not called at all... Please update the ```DhcpServiceConfiguration```, that the ```DhcpService``` is actually provided.


Is it OK to have `/documentation` with `/` here?


Uhm, I'm Robert, not Roberto ;)


Nice!


I'm using state to store the plan here, and in update it in edit.  It works, but I was wondering if we should try to avoid this?  Currently, I have it there so that the update function will trigger a render, but it may be unnecessary.  Maybe we could store a hash of the object in the state, and add a getObjectHash function to the CrudConfig?


For later: I wonder if this blank line causes any issues with gitignore? Maybe not but we may want to clean it up anyway.


(Also this is probably something that could be in a separate commit)


First attempt to push 2 files from local repository into GitHub repository. While trying, I overwrite the initially created readme.txt file. Did so because previous attempts were unsuccessful, probably because I did not clone the GitHub's repository to local machine first, but tried to push html and css files to GitHub repository where a readme.txt file was located.


Merged https://github.com/allenai/s2-offline/pull/317 which pull in the
pipeline library version with the fix.


We should consider just passing the negative value in and change the semantics of the method.  The `decrementFlowControlWindow` is only called 1 time in conjunction with `decrementPendingBytes` and they both negate the parameter passed in.


Sorry Robert. Fixed!


Hi, apologies if this is the wrong place for this, but do you know when/if we can expect this version on rubygems? Thanks


needs update


What do you mean by freezes?


This seems like a useful comment.  Isn't it worth preserving?


Hmm.  This looks like a fight between the namespace purists and the realists…  We should sort this out with a project-wide standard.


Should there be a direct translator from IL to AST? Maybe this transformation must be made in several steps through graph of representations and transformations?


This commit should have been reset, sorry.


you'd better do replace("-", "") in api


up to you. if you do so , you ll have to change how you list them, keys are unique  in a hash.
 just use an array of string ["some_suffix_name", "another_name"], and
you can use something like ' self.send "some_suffix_name", param  '  to call a function with the same name
if you need to have something specific done when there's a match
def some_suffix_name(opt)
puts "hello "+opt.to_s
end


@kumpera The threading changes break all Mono.Debugger.Soft unit tests on Linux, one example:

```
***** MonoTests.DebuggerTests.VTypes
suspend_thread suspend took 1000 ms, which is more than the allowed 1000 ms
Stacktrace:

Native stacktrace:

	/home/alexander/dev/mono/mono/mini/mono(mono_handle_native_sigsegv+0xc8) [0x4bb188]
	/lib/x86_64-linux-gnu/libpthread.so.0(+0x10340) [0x2b7e93529340]
	/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x2b7e9376dcc9]
	/lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x2b7e937710d8]
	/home/alexander/dev/mono/mono/mini/mono() [0x644e39]
	/home/alexander/dev/mono/mono/mini/mono() [0x64503f]
	/home/alexander/dev/mono/mono/mini/mono() [0x6450e2]
	/home/alexander/dev/mono/mono/mini/mono(mono_threads_wait_pending_operations+0x139) [0x63d919]
	/home/alexander/dev/mono/mono/mini/mono(mono_thread_info_safe_suspend_sync+0x84) [0x63df24]
	/home/alexander/dev/mono/mono/mini/mono() [0x4d62f4]
	/home/alexander/dev/mono/mono/mini/mono(mono_g_hash_table_foreach+0x5c) [0x5c0cbc]
	/home/alexander/dev/mono/mono/mini/mono() [0x4d5b68]
	/home/alexander/dev/mono/mono/mini/mono() [0x4dd607]
	/home/alexander/dev/mono/mono/mini/mono() [0x4dda3b]
	/home/alexander/dev/mono/mono/mini/mono() [0x4ddf43]
	/home/alexander/dev/mono/mono/mini/mono(mono_profiler_runtime_initialized+0x22) [0x596f22]
	/home/alexander/dev/mono/mono/mini/mono() [0x43b31a]
	/home/alexander/dev/mono/mono/mini/mono(mono_main+0x377) [0x48fcd7]
	/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x2b7e93758ec5]
	/home/alexander/dev/mono/mono/mini/mono() [0x436604]

Debug info from gdb:

[New LWP 23099]
[New LWP 23098]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
0x00002b7e93528ee9 in __libc_waitpid (pid=pid@entry=23101, stat_loc=stat_loc@entry=0x7fff876b7b0c, options=options@entry=0) at ../sysdeps/unix/sysv/linux/waitpid.c:40
40	../sysdeps/unix/sysv/linux/waitpid.c: No such file or directory.
  Id   Target Id         Frame
  3    Thread 0x2b7e96598700 (LWP 23098) "Finalizer" sem_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/sem_wait.S:85
  2    Thread 0x2b7e96799700 (LWP 23099) "mono" __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
* 1    Thread 0x2b7e92c265c0 (LWP 23086) "mono" 0x00002b7e93528ee9 in __libc_waitpid (pid=pid@entry=23101, stat_loc=stat_loc@entry=0x7fff876b7b0c, options=options@entry=0) at ../sysdeps/unix/sysv/linux/waitpid.c:40

Thread 3 (Thread 0x2b7e96598700 (LWP 23098)):
#0  sem_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/sem_wait.S:85
#1  0x0000000000639727 in mono_sem_wait (sem=sem@entry=0x96ada0 <finalizer_sem>, alertable=alertable@entry=1) at mono-semaphore.c:101
#2  0x00000000005bdb3e in finalizer_thread (unused=<optimized out>) at gc.c:1072
#3  0x00000000005a1424 in start_wrapper_internal (data=<optimized out>) at threads.c:664
#4  start_wrapper (data=<optimized out>) at threads.c:711
#5  0x000000000063edde in inner_start_thread (arg=0x7fff876b8c90) at mono-threads-posix.c:93
#6  0x00002b7e93521182 in start_thread (arg=0x2b7e96598700) at pthread_create.c:312
#7  0x00002b7e9383147d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Thread 2 (Thread 0x2b7e96799700 (LWP 23099)):
#0  __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1  0x00002b7e93523672 in _L_lock_953 () from /lib/x86_64-linux-gnu/libpthread.so.0
#2  0x00002b7e935234da in __GI___pthread_mutex_lock (mutex=0x96a1a0 <loader_mutex>) at ../nptl/pthread_mutex_lock.c:114
#3  0x0000000000560dbe in mono_loader_lock () at loader.c:2458
#4  0x00000000004d302d in get_id (domain=0x13d9bf0, type=type@entry=ID_DOMAIN, val=0x13d9bf0) at debugger-agent.c:2254
#5  0x00000000004e5bd5 in buffer_add_ptr_id (val=<optimized out>, type=ID_DOMAIN, domain=<optimized out>, buf=0x2b7e96798cd0) at debugger-agent.c:2326
#6  buffer_add_domainid (domain=<optimized out>, buf=0x2b7e96798cd0) at debugger-agent.c:2454
#7  domain_commands (buf=0x2b7e96798cd0, end=0x0, p=0x0, command=1) at debugger-agent.c:7561
#8  debugger_thread (arg=<optimized out>) at debugger-agent.c:9684
#9  0x000000000063edde in inner_start_thread (arg=0x7fff876b8b40) at mono-threads-posix.c:93
#10 0x00002b7e93521182 in start_thread (arg=0x2b7e96799700) at pthread_create.c:312
#11 0x00002b7e9383147d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Thread 1 (Thread 0x2b7e92c265c0 (LWP 23086)):
#0  0x00002b7e93528ee9 in __libc_waitpid (pid=pid@entry=23101, stat_loc=stat_loc@entry=0x7fff876b7b0c, options=options@entry=0) at ../sysdeps/unix/sysv/linux/waitpid.c:40
#1  0x00000000004bb215 in mono_handle_native_sigsegv (signal=<optimized out>, ctx=<optimized out>, info=<optimized out>) at mini-exceptions.c:2346
#2  <signal handler called>
#3  0x00002b7e9376dcc9 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#4  0x00002b7e937710d8 in __GI_abort () at abort.c:89
#5  0x0000000000644e39 in monoeg_log_default_handler (log_domain=<optimized out>, log_level=G_LOG_LEVEL_ERROR, message=<optimized out>, unused_data=<optimized out>) at goutput.c:233
#6  0x000000000064503f in monoeg_g_logv (log_domain=0x0, log_level=G_LOG_LEVEL_ERROR, format=<optimized out>, args=args@entry=0x7fff876b8a58) at goutput.c:113
#7  0x00000000006450e2 in monoeg_g_log (log_domain=log_domain@entry=0x0, log_level=log_level@entry=G_LOG_LEVEL_ERROR, format=format@entry=0x702920 "suspend_thread suspend took %d ms, which is more than the allowed %d ms") at goutput.c:123
#8  0x000000000063d919 in mono_threads_wait_pending_operations () at mono-threads.c:152
#9  0x000000000063df24 in mono_thread_info_suspend_sync (error_condition=<synthetic pointer>, interrupt_kernel=0, tid=47822688323328) at mono-threads.c:599
#10 mono_thread_info_safe_suspend_sync (id=47822688323328, interrupt_kernel=interrupt_kernel@entry=0) at mono-threads.c:837
#11 0x00000000004d62f4 in notify_thread (key=0x2b7e94290280, value=0x2b7e980014c0, user_data=<optimized out>) at debugger-agent.c:2753
#12 0x00000000005c0cbc in mono_g_hash_table_foreach (hash=0x13b8860, func=func@entry=0x4d62a0 <notify_thread>, user_data=user_data@entry=0x0) at mono-hash.c:292
#13 0x00000000004d5b68 in suspend_vm () at debugger-agent.c:2851
#14 0x00000000004dd607 in process_event (event=event@entry=EVENT_KIND_VM_START, arg=arg@entry=0x2b7e9428c140, il_offset=il_offset@entry=0, ctx=ctx@entry=0x0, events=events@entry=0x1455bc0, suspend_policy=2) at debugger-agent.c:3830
#15 0x00000000004dda3b in process_profiler_event (event=event@entry=EVENT_KIND_VM_START, arg=0x2b7e9428c140) at debugger-agent.c:3885
#16 0x00000000004ddf43 in runtime_initialized (prof=<optimized out>) at debugger-agent.c:3891
#17 0x0000000000596f22 in mono_profiler_runtime_initialized () at profiler.c:889
#18 0x000000000043b31a in mini_init (filename=0x7fff876bb381 "dtest-app.exe", runtime_version=runtime_version@entry=0x0) at mini-runtime.c:3104
#19 0x000000000048fcd7 in mono_main (argc=6, argv=<optimized out>) at driver.c:1921
#20 0x00002b7e93758ec5 in __libc_start_main (main=0x436360 <main>, argc=6, argv=0x7fff876b9098, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff876b9088) at libc-start.c:287
#21 0x0000000000436604 in _start ()

=================================================================
Got a SIGABRT while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

Tests run: 1, Failures: 1, Not run: 0, Time: 1.669 seconds

Test Case Failures:
1) MonoTests.DebuggerTests.VTypes : Mono.Debugger.Soft.VMDisconnectedException : Exception of type 'Mono.Debugger.Soft.VMDisconnectedException' was thrown.
at Mono.Debugger.Soft.Connection.SendReceive (CommandSet command_set, Int32 command, Mono.Debugger.Soft.PacketWriter packet) [0x00117] in /home/alexander/dev/mono/mcs/class/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs:1551
at Mono.Debugger.Soft.Connection.get_RootDomain () [0x00000] in /home/alexander/dev/mono/mcs/class/Mono.Debugger.Soft/Mono.Debugger.Soft/Connection.cs:1783
at Mono.Debugger.Soft.VirtualMachine.connect () [0x0007c] in /home/alexander/dev/mono/mcs/class/Mono.Debugger.Soft/Mono.Debugger.Soft/VirtualMachine.cs:363
at Mono.Debugger.Soft.VirtualMachineManager.LaunchInternal (ITargetProcess p, System.Diagnostics.ProcessStartInfo info, System.Net.Sockets.Socket socket) [0x0005a] in /home/alexander/dev/mono/mcs/class/Mono.Debugger.Soft/Mono.Debugger.Soft/VirtualMachineManager.cs:66
```

Reverting the three threading commits fixes it.


When the Hero is hit for the third time, the game is meant to clear the screen and display the score. Instead, it stops responding to input and the screen stays in the exact state it was in when the Hero is hit for the third time.


@bakercp Some .gitignore pattern that I can't identify (or other configuration on my machine) seems to be ignoring all files in my `bin/data` folder. I've been having to `git add -f` all files I've added to it. I must have forgotten to do this. Are you experiencing this issue?


Correct definition of domain entity Student class, according to JPA annotations.


Try to keep all of the DatabaseCleaner config in one file. Consider removing the DatabaseCleaner config from the 2 helper files and add a new file in `spec/support/` like this: https://github.com/eliotsykes/rspec-rails-examples/blob/master/spec/support/database_cleaner.rb

The config in that example file should work with this project without modification.


Another row comment.


`@user` can be a local variable


TeamCity xBIM :: XbimExchange :: Build [Build 118](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1152&buildTypeId=XBIM_XbimExchange_Build) is now running


Does your code keep calling the draw function?

On Thu, Mar 12, 2015 at 12:06 PM, elijah9 <notifications@github.com> wrote:

> When the Hero is hit for the third time, the game is meant to clear the
> screen and display the score. Instead, it stops responding to input and the
> screen stays in the exact state it was in when the Hero is hit for the
> third time.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elijah9/CMPU-203/commit/fa9068f826ca25e74246f3346fbececfd0f7955e#commitcomment-10167729>
> .
>

--
Jay McCarthy
http://jeapostrophe.github.io

           "Wherefore, be not weary in well-doing,
      for ye are laying the foundation of a great work.
And out of small things proceedeth that which is great."
                          - D&C 64:33


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12666/testReport/) for this commit**


Do you need to press a button?

On Thu, Mar 12, 2015 at 12:07 PM, Jay McCarthy <jay.mccarthy@gmail.com>
wrote:

> Does your code keep calling the draw function?
>
> On Thu, Mar 12, 2015 at 12:06 PM, elijah9 <notifications@github.com>
> wrote:
>
>> When the Hero is hit for the third time, the game is meant to clear the
>> screen and display the score. Instead, it stops responding to input and the
>> screen stays in the exact state it was in when the Hero is hit for the
>> third time.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/elijah9/CMPU-203/commit/fa9068f826ca25e74246f3346fbececfd0f7955e#commitcomment-10167729>
>> .
>>
>
>
>
> --
> Jay McCarthy
> http://jeapostrophe.github.io
>
>            "Wherefore, be not weary in well-doing,
>       for ye are laying the foundation of a great work.
> And out of small things proceedeth that which is great."
>                           - D&C 64:33
>

--
Jay McCarthy
http://jeapostrophe.github.io

           "Wherefore, be not weary in well-doing,
      for ye are laying the foundation of a great work.
And out of small things proceedeth that which is great."
                          - D&C 64:33


I agree with Paul, we need an RFC (and probably one for python separate from C++).

In this case I agree with John.  The code uses those import shortcuts almost everywhere, and they should probably be part of the RFC.  I'm not unbiased here -- I just uses this file as boilerplate for the composite profile code in HSC, and made the same changes.


@mtibben @crispy1989 yes, there was an issue with NPM publish which did not keep my index.js so I unpublished it


These namespace changes are actually responsible for most of the rest of the diff (and it's not mentioned in the commit log).  Without a project-wide standard, I suggest you should leave it how it was.


The one in ResetPasswordPage.fill() could be removed, but removing the one in ResetPasswordCreatePage will crash the email-reading because that would start too early.


Trust me, it's not fitting in storage if you are trying to deploy without
downtime.

On Thu, Mar 12, 2015 at 10:58 AM, peterschulz <notifications@github.com>
wrote:

> In opinion the result of this services.json is a result of contents out of
> vendor (e.g. the config/app.php configured providers are included which
> might be own providers, which are not comming from vendor/*) and
> services.json has dependencies to vendor stuff - so its a mix of vendor
> specific and application specific stuff.
>
> So I think the better place was storage/framework or if you like to
> differentiate why not create a folder storage/vendor ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/framework/commit/cfa7fcb60fd60b3870606c910559e67186a7a8a8#commitcomment-10167524>
> .
>


Que va


Agreed, though I'd say it's between the people who are willing to introduce a bunch of new names to save a few characters and those who aren't :-)

In any case, I think the best practice in the meantime is to try to keep things consistent within each file, even if it's not the side you're on (though I've certainly been guilty in the past of converting entire files from aliases to no aliases when making major modifications to them).


Is  this patch doing the same like this one https://github.com/AK-Kernel/AK-OnePone/commit/ddb7a40e792a75885545881c1daf4cdd216bf142 ?


rax retry tests


meh. this is a giant dependency in terms of file size. unless you absolutely need it, i think it should be optionally defined as a jspm dependency on babel and an import in app.js or the files that it is needed in.


What about a dedicated folder for generated artifacts then? The services.json is not strictly vendor driven, but affected by the application, too.


As with REQ/REP, I would love to see this paragraph obsoleted, once "multi-flight" requests/surveys and replies/responses are implemented. Not all nodes in a network are necessarily single-threaded. We would still consider all nodes stateless, maintaining nothing but the hashmap of current transactional messages yet unfinished.


Please write down comments in English!


If my understanding is correct, we can disable third-party cookies by setting PARAM4 to 0 via the Elastic Beanstalk web UI ?

In config.clj, I find `(def ^:const duration-varnames ["PARAM4", "SP_DURATION"])`


So this did not work. I removed these and tried the git pull again to clear the error. It said that everything was up to date. Then I added these two files back in, and got the same error again. It tried making sure that the xml_added and xml_queue versions were exactly the same, but it did not correct the error.


If this commit all/mostly just changing from no-aliases to aliases, I'd *really* like to just drop it, and not just because I prefer no-aliases - I've been making large structural changes to the test code in meas_base on DM-1161, and these will create a huge (and largely unnecessary) conflict with that.


Also, read this to write better GIT commit messages: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message


I just tried pressing a bunch of keys when the game is over, nothing happens. The code only calls the draw function inside the while loop, which should stop at this point.


No code change?


Yeah, it's an intentional .gitignore pattern.


if (element.getPrevSibling() instanceof PsiWhiteSpace) element = element.getPrevSibling();

here element can change, so unless getPrevSibling returns a nonNull value, I think it's wise to have the null check. Don't you agree?


Don't add the generated files such as `lab-1/fibseq` in GIT repository.


I'm curious what this does... https://babeljs.io/docs/usage/external-helpers/#selective-builds  it may actually be even more efficient than just setting that to true.


Я понимаю, просто это уж совсем очевидная вещь :)


Reading the rest of the diffs I'll change my vote to "leave it alone".  But I do want to see that RFC


tengo entendido que no, pero tengo que probar borrando mi ~/.m2 a ver si aun corre.

en teoria `compile` es para dependencias de compile time.

Y muchas son para cuando esta compilando pruebas y herramientas.


Please write down meaningful GIT commit messages: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message


As per the documentation: https://github.com/snowplow/snowplow/wiki/Additional-configuration-options#4-setting-the-cookie-duration


Unless there's a way to delegate to the `AngularVelocity` `Order` instance in a convenient way, which I don't see, this all seems fine to me. :+1:


Don't add the generated files such as `lab-1i/fibseq` in GIT repository.


I guess we could just call `assert !writing` ?


I'm not sure what you mean by "multi-flight".  Note that the cooked mode survey relies on the Survey ID (much like REQ/REP uses the request ID), but you can support multiple outstanding surveys by using raw mode.  Raw mode gives direct access to the survey ID, and eliminates the timeout handling, letting the application instead use its own logic.


This may be a stupid question, but how do you know that the overlayfs is cluster safe?


It is NOT "shorten".


You should mention the reason why the code was shortened.