saw approval from jdm
at https://github.com/glennw/servo/commit/30ac159721421a40f64f35f4ccdfef751245eb4c


merging glennw/servo/fix-root-window-rect = 30ac1597 into auto


glennw/servo/fix-root-window-rect = 30ac1597 merged ok, testing candidate = cad58b3b


AutoDocsWithNoLTO (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


AutoDocsWithNoLTO (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1660 of 1667 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


This is much better.


@iKarith
So build scrip still fail to compile for iOS?


I must say I don't like this type of construct. Why not use a regular looking if loop?


Once concern, Ive heard people needing to vote AI commander to fix bugs, then vote themselves back to comm...


Yes, it's from the solar panel cfg

----- Ursprüngliche Nachricht -----
Von: "Nathaniel Lewis" <notifications@github.com>
Gesendet: 24.03.2015 01:05
An: "ThomasKerman/Kopernicus" <Kopernicus@noreply.github.com>
Cc: "Dorian Stoll" <dorianstoll@googlemail.com>
Betreff: Re: [Kopernicus] Custom powerCurves and an example for stars(81ff47b)

Just a question. Is the power curve you put in System.cfg the stock power curve for the sun?
—
Reply to this email directly or view it on GitHub.


開始タグの入れ忘れかな？


Validation is good.


Good catch. `//` instead of `http`.


ここは最初から再度再生する場合に true にするフラグらしいので、意味的には前回のコードであっているようです。
「最初は必ず最初から再生させる」
けど今回は最初であろうと、途中から再生させる場合があるので
「var restart = this.PlayState == PlayState.Paused;」
を削除して、

Bass.BASS_ChannelPlay(this._handle, false);
としたほうが良いと思います。


OK


@PuneetEsri Please add content to the README such that devs understand the purpose of the app.


ouch, this made browserify include both react and react with addons in my vendors bundle


Don't you need that same test for `fs_lua.change_dir_to_root`?


Yep, having --logdir as part of top level avocado was a mistake. Good catch.


whoops. fixing it.


an entirely unset value would generally be a bug, is the distinction. I am worried about encouraging defaults embedded in code (since most other config libs encourage that, people are used to doing it; I think it's a feature that you have to work hard to do it with our API, so you go to the docs and see the better alternative).


Instead of setting `'contain' => array()` in every find() you don’t want associated data, you can set `$recursive = -1` as an attribute class. It will act as a default for all the find()s of this model, and you can then use `recursive => 0 or 1` in find()s you want associated data.


First Commit JMJ


@PuneetEsri Also be sure to add licensing info in the README.


Yup; merged from master and all is well with 2.6.0.


Care to explain? React with addons is just core React plus a bit extra. There shouldn't be two separate Reacts.


Ampersand


This really should be set via configuration and not in code.  By changing it to this you are changing the expected behavior.


Cool


Why not use validation here as well?


compile error ...


Remember to remove this :)


I'm not sure CRAN allows this, shipping precompiled static libs with a package.  I think the proper way to do it is to provide the static libs to CRAN so that they can build the windows package and make it available for download.

I'm on vacation right now, but happy to look into it when I get back.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/40e2bf4099a89dc104944c0f0b5e6b78b16d4368/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/40e2bf4099a89dc104944c0f0b5e6b78b16d4368/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/40e2bf4099a89dc104944c0f0b5e6b78b16d4368/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/40e2bf4099a89dc104944c0f0b5e6b78b16d4368/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/40e2bf4099a89dc104944c0f0b5e6b78b16d4368/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


It tests that I can pass an invalid event ID to the view and it won't error.


No problem. I have no particular vested interested in array_key_exists. Changing to isset and return false.


I do agree with you that people will be surprised. Maybe it's an argument against adding this API...


Well, since I changed the test from fs.exists(".") to fs.current_dir() I don't think it goes that far. But I'll add it anyway, thanks for the sharp eye!


This totally rocks!


actually there should be a

```
#define	PAGE_SHIFT 12
```

under
```
#ifdev DEBUG_ABD
```

but github and git apparently hate me today and 3 subsequent attempts lead to the starting state - so I'll push this later in a separate commit (provided - the buildbots complain)

/sigh


Good, this refactor was needed.


But then, we want it for Emacs too.


Good


Oh it compiles fine.  It's not linking for some reason related to
-DHAVE_POSIX_MEMALIGN.  Working on it.

Joseph

On Mon, Mar 23, 2015 at 08:49:53PM -0700, eddiebrook wrote:
>@iKarith
>So build scrip still fail to compile for iOS?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/libretro/mame/commit/e3eeec11f7af6725c8341aaeeca08ee70991db26#commitcomment-10359202


You need to add our maven repo url

```groovy
        maven {
            url 'http://dl.bintray.com/esri/arcgis'
        }

```


ahah see on the gitter chat, I will restate the point when closing the merged PR also.


Good.


You are right, I am not able to reproduce what made my bundle almost double in size, but including -r 'react/addons' in the vendors generation have fixed it… nevermind


great thanks, much more concise! looks good so far, I'm still running tests/benchmarks


On 23/03/15 21:34, Hieu Hoang wrote:
> the bjam code is taken as-is from boost. We sometime (rarely) import a
> new version into moses so don't be surprised if your changes are
> overwritten in future

Ah, thanks!  That will save me some time.

The diff from upstream has gone past 2000 lines, so maybe it's time for
a refresh?  I find with these things, updating frequently (and
automatically) is usually less painful than doing it once in a blue moon.

Jeroen


Cool. Let me know if it comes up again :)


The inside of any function needs to be indented.


@XuemingRocks Great getting the data in public domain.


Consider `boost::static_vector` (see: http://www.boost.org/doc/libs/1_57_0/doc/html/boost/container/static_vector.html) which should do what you want.


AutoDocsWithNoLTO (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (653 of 655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.55%25-green.svg)


PeerReview#
The code didn't run from the first time and it crashed many times. I had to add some semicolon to the code and delete some others.Finally the code ran on the emulator but still not perfectly. I suggest that to add comments to your code, so the reviewer will know what each code does. Also, it would be nice to group them, such as variables together, functions together and so on. The camera is still not working on my side even after I manipulate the code, it will just show me blackground with no buttons or anything


Fixed with https://github.com/silverstripe/silverstripe-spamprotection/pull/19


Test


Wow totally forgot that thanks Aaron!


That looks fine.

FWIW I considered making these labels configurable so you could just set something in your `.vimrc` instead of having to fork the project. But you already discovered in a previous commit that it doesn’t make sense to change just the labels without fixing the arrangement to match the new style. I don’t have a good idea for how to do that with sensible, easy configuration, so for now I decided to leave it hard-wired.


no need to have parenthesis around the condition statement.


yeah, but I like making tests also be good examples of actual usage. "two for the price of one" :)


Common Jason, you can't just leave people hanging like that :godmode:


could remove `ids` and use `monids()` directly. more concise and easy to read, IMHO.


generators maybe?


Should be removed or unwanted


I'll go ahead and add them to the constructor since it seems easier to change and placing the documentation for the arguments in the docstring is more consistent.


Job pr-scala failed for 44d6dfa0 Took 0 s. (ping @retronym) [(results)](https://scala-webapps.epfl.ch/jenkins/job/pr-scala/9601/):

To retry exactly this commit, comment `PLS REBUILD/pr-scala@44d6dfa0e14f23cdcd4f8f0618275395371aefe6` on PR 4254.
NOTE: New commits are rebuilt automatically as they appear. A forced rebuild is only necessary for transient failures.


Please remove this  System.out.println line


I think this can be simplified a bit:

- Everything under "generated code" is actually generated in the debug or release subdirectories, so you can just exclude those directories globally without referring to individual files.

- *.rsc and *.bof files are generated so you want to exclude them everywhere (e.g. they're also under the run/server directory).

- I don't know about trying to exclude files in run/localclient.  If you actually run from there, many more files are generated as the game is run, like mail files or map updates.


Feel free to remove it and make a pull request.


ResultsSchema (sanyalj) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.44%25-red.svg)


OBS.: Ainda em fase de conclusão


单点


better later than never as they say, but shall we add a test here and trigger an exception if no callback is being passed in settings ? After all there is no point in using an `ObservableVector2d` with no callback.


But that will load info+ every time we enter Info-mode. We should load it once. My config is recommended by `use-package` author here: https://github.com/jwiegley/use-package/issues/188


I think originalEvent must be a jQuery thing and Zepto must actually just use the original event as its event


I guess inclusion of `php_version.h` isn't necessary in this case, am I right?


I wonder if we can recursively set a ttl...

> On Mar 23, 2015, at 9:43 PM, Derek Carr <notifications@github.com> wrote:
>
> I thought the same, but not sure its the right thing. In practice, will set a graceful termination time on pod delete even when deleting the namespace so I am not sure I want to just wipe the whole collection at one time.
>
> —
> Reply to this email directly or view it on GitHub.
>


Looks like this if/else statement is useless now.  Should remove it, I think, or comment the whole block out, if you think that keeping the (currently commented) RefactoringUtil.remove... call is worth leaving in place.


Had to replace `css('height')`, which just returns `auto` in Zepto, with a call to `outerHeight(true)` to get an actual number back (which this plugin needs in order to give CSS the transition calculations)


注意nRows大于字符串长度， 注意i++， 注意首末行分别处理


I hope it is fixed, thanks


The generated code is from the VS project files, where I put the files back into the source directories rather than release or debug.  (I think it makes more sense that way)

I'll update the rsc/bof to ignore them from everywhere.

I was running the client and server from within those directories and everything else was already ignored.  Most of the directories in 'run' have their own .gitignore files that ignore all files within them.


r+


url


thanks!


This assumes that the parent is always a HaxeVarDeclaration.  Is this always true?  Or can this be part of a chain where the HaxeVarDeclaration may actually be up a few levels?


Won't this attempt to add the content script to `chrome://` URLs?


agreed.


You should put the generated code in the same place as the makefiles do.  Having two different places will leave a mess (since e.g. the makefiles won't delete the code generated by the project files).


Why did you separate this script? I believe the default for `run_at` is `document_start`.


Looks like a good step in the right direction.


I'm not sure how or how useful it would be. This particular case where we poll for autophone commands while the test is running is unique to the unittests which we run in a new process. The other tests each have their own locations where we can poll for commands. There doesn't seem to be a good pattern for lifting this up into PhoneTest.


hi @mikejolley,

We're seeing these infinite recursion issues when the WC Zapier and WC Groups extensions are used together.

WooThemes ticket #268454

If I comment out the above change, the issue doesn't occur.

I've also pinged @itthinx regarding this too.

Overall, if a plugin calls get_cart() before wp_loaded, it shouldn't be possible to completely crash the site due to WooCommerce having an infinite recursion problem.

This wasn't an issue in WC 2.x, it's only come up since WC 2.3.

What do you think is the best solution here?

Thank you.


it shouldn't... we have ` if (version[1] > 0 || version[2] > 11) {` lol. Everything, every test before it is es5 okey. :D


I don't think this is right; I intentionally changed this to archive_static so that club wouldn't need the DLL.  I had forgotten to update archive_static.lib, but I did it a few days ago, so I think this change should be reverted.


Nope, defaults to `document_idle`. All is good.


I see. Will this help with the Py3.4 support? I still got a long chain of errors after your last tip, didn't get round to report it yet.


What is this stuff in quotes---is it needed?  Seems redundant.


What's this?


What exactly does it improve compared to what I have?

Knox is completely deactivated by my kernel.

What does the tima thing do?


require won't load a library twice. Or I was mistaken from all this time ?


Ok seems I'm right: http://ergoemacs.org/emacs/elisp_library_system.html


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1124
success: http://build.servo.org/builders/linux2/builds/1124
success: http://build.servo.org/builders/android/builds/1158
success: http://build.servo.org/builders/mac1/builds/1337
success: http://build.servo.org/builders/mac2/builds/1340
success: http://build.servo.org/builders/gonk/builds/306


It's the name of the setting in Visual Studio.  It makes it much easier to locate in the settings page.


We should probably make a constant for "PhotoShell"


fast-forwarding master to auto = cad58b3b


@tuhdo to be complete here is the expansion of `(use-package info+)`

```elisp
(if
    (not
     (require 'info+ nil t))
    (display-warning 'use-package
                     (format \"Could not load package %s\" \"info+\")
                     :error))
```

So it reduces to a require.


Added documentation for specifying groupname or GID for commands. Also clarified used of the possible use of multiple USER commands in a Dockerfile.


It fixes a compiler warning "_WIN32_WINNT not defined"

https://social.msdn.microsoft.com/Forums/en-US/ff5c25dd-01b6-45f9-a22b-8abd0b66c3d9/win32winnt-not-defined-defaulting-to-win32winntmaxver?forum=vcmfcatl


saw approval from jdm
at https://github.com/dmarcos/servo/commit/6735c2d6bdb0af715b307320ba7135ce751b3b7a


merging dmarcos/servo/issue4784 = 6735c2d6 into auto


dmarcos/servo/issue4784 = 6735c2d6 merged ok, testing candidate = 29d4183f


I'd rather not put VS UI in the makefile---these strings change from version to version.  Could you instead find a link to a page that lists the mappings and include it in the makefile?


I see.. add a comment that lists https://msdn.microsoft.com/en-us/library/aa383745(VS.85).aspx to explain why it's here?


Alrigh it's fine to me. Yes, the package is loaded once with `require` but `(require 'info+)` is executed every time I enter an Info page, even though subsequent executions do nothing.


Looks like you forgot to add the image to the commit :grin:


不正解です！
正解は……「最初delタグ入れてたけどやっぱやめて消したけど終了タグが残骸で残った」です！


Oh, and did I mention the loading bar??


Approved.


These instructions don't seem complete because they don't indicate how to author the right paket,dependencies?


Oh you are right, it is wrapped in the `:config`. Anyway require is made to be called several time and produce side effects only the first time, so this is ok.


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/1125
failure: http://build.servo.org/builders/mac1/builds/1338


@igillis thank you. For unit testing, I also prefer the first example.


Thanks so much for adding the TV Changes capability, for adding a test, and for following my style.


oops thanks
> On Mar 23, 2015, at 9:56 PM, Saniul Ahmed <notifications@github.com> wrote:
>
> Looks like you forgot to add the image to the commit
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Khan/Early-Math-Prototypes/commit/60551ec44e7f854b029ae596f91d1b2eac2f0f3c#commitcomment-10359674>.
>


Has approx 6 statements (TooManyStatements)


Has the parameter name 'h' (UncommunicativeParameterName)


Redundant curly braces around a hash parameter.


Space missing after comma.


saw approval from jdm
at https://github.com/glennw/servo/commit/06a79243a7e598056c2f6fdb37eb0248f76c258a


merging glennw/servo/fix-iframe-subpage = 06a79243 into auto


glennw/servo/fix-iframe-subpage = 06a79243 merged ok, testing candidate = 2f85c5bb


-1

The main reason is chokidar doesn't work well on Windows. https://github.com/wearefractal/glob-watcher/pull/13


It's main


I had to put the tests above the XMLRPC ones because the server half doesn't accept new connections after it. I'm guessing SimpleXMLRPCServer is still listening on the address, but I didn't dig closely.


@andymatuschak This commit removes 11.wav, but the code still references it here: https://github.com/Khan/Early-Math-Prototypes/blob/master/Counting%20by%20touch%20count/main.js#L33


Imagine what the two of you could do @malcrom :P


Thats alot of code, is there anyway you can build a dll or library for this?


@xmnfw As tabelas estão em Markdown no formato utilizado pelo Pandoc.


Oooooh, I love this toy!


点点滴滴


How to get session attribute on jade page?


I'm having issues with my arduino not receiving the ACK from the raspi.  Is this something you've seen or tested out before?  It seems to be receiving the signal fine (RSSI of -29), but just not sending the ACK consistantly (Typically less than 5% of the time).


Ah, yeah it looks like the older one was broken so I switched it, but it does work with static now.


I don’t actually know how to use computers
> On Mar 23, 2015, at 10:05 PM, Saniul Ahmed <notifications@github.com> wrote:
>
> @andymatuschak <https://github.com/andymatuschak> This commit removes 11.wav, but the code still references it here: https://github.com/Khan/Early-Math-Prototypes/blob/master/Counting%20by%20touch%20count/main.js#L33 <https://github.com/Khan/Early-Math-Prototypes/blob/master/Counting%20by%20touch%20count/main.js#L33>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Khan/Early-Math-Prototypes/commit/ba15836bda4671c135c8f77c03125be4dfe6d2fb#commitcomment-10359734>.
>


See my previous comment about this needing to chain up to parent


Nobody does, Andy, nobody does...


Oh you do it here. Nevermind then :)


nnnn


Notebook!


forget trailing `\` ?


@jdm Thanks :)


Got around to adding docs and a [bunch of tests](https://github.com/wtolson/Pysis/tree/labels/tests) this weekend which led to bringing up the label parser to spec. I'm hoping [TravisCI](https://travis-ci.org/wtolson/Pysis) will be helpful in building out the python3 support! :)


here too. :smile:


90022444-FewReleasePrepThings (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1665 of 1668 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


first


r+


Missing `return` after this


For now I've removed the generated code section - would it be OK if I updated the makefiles to put the source output in the source directory?  It seems very strange to me to put it in release/debug.


Nitpick: other inline comments even in the same function use the other comment style


LGTM


Damn he beat me to registering the FML events.


AutoDocsWithNoLTO (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1163 of 1165 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.78%25-green.svg)


I intentionally put them there so that "nmake clean" is as simple as deleting the debug/release directory, in every subproject.  Nothing needs to be special-cased.


The return on line 238 will be hit once there is no longer a full line of output available in the stream.


sorry, why can't build?

#include <StandardCplusplus.h>
#include <boost_1_51_0.h>

multipacket.ino:85:10: error: 'boost' has not been declared


Ok, thats cool. So I don't need to worry about this at first while pushing changes then.


Yeah but the function needs to return a gboolean


It's true, but this is pretty consistent throughout the metrics client-side codebase. The `/* */` style comments are used in single line comments that can't just comment out the full remainder of the line, and the `//` style comments are used in single line comments that can. (The one change I pushed while you were reviewing was fitting lines 197 through 201 in fewer lines.)


I'm just posting this as an idea, since our design look very similar.
 * It is possible that the same image as more than one feature.
 * You may be interested in the [visitor pattern](https://en.wikipedia.org/wiki/Visitor_pattern) for Feature.


Aqui se puede observar con el color rojo las lineas eliminadas, el verde las nuevas lineas, es algo muy pro, y tambien se puede comentar por aqui para tener interaccion con otros programadores, para que los regañes cuando veas algo muy "trucho" jaja


@dhanasiddharth  I believe it is pass code based encryption isn't it?


I'm confused; I'm pretty sure `G_SOURCE_CONTINUE` (the value returned on line 238) is a gboolean.


I guess I would also be happy with a `g_assert_not_reached` outside of the `while (TRUE)` loop then


Done!


K.it is also a form encoding....


@kyranstar Looking good!

One thing that I forgot to mention is that I set up the project so that all the shared code goes in "Final Game/Shared Code" and then is linked to in each project in Visual Studio. Currently, these files are in "Final Game/Platform/Desktop/", which means they will not be available if we want to run the game  cross-platform.

First, you should pull from GitHub again to get my latest changes. All you have to do to move these files is to open Windows File Explorer and cut-and-paste the "Map" folder that you created into the "Shared Code" directory. Then go in to VS, delete all the now-disappeared files (it should just remove them from the project). If you reload the project, it should auto-discover the shared files for you.


line count remains the same, byte count reduced :).


Kanske: "If you don't want to disable events you can instead expire temporary event queues faster"


Glad to see that you finally got it working :)


Alright as a temp fix until itsuart gets the correct info..


addressed as requested.


It's less cluttered now, which is a huge win. But I feel a bit uncomfortable with this code, just like Java programmers who migrated to Go but whose fingers still keep trying to type public static void main.


Hmm,yeah right. Mathematically one can't normalize zero vector.Can't glm::isnan() accept a vector?That triple comparison looks ugly.


`glfwSetTime` can now produce a `InvalidValue` error


A self-documented way to do it is to introduce `struct MQMessage::ForceUpload {}` and change that `bool`-taking constructor into the one taking `MQMessage::ForceUpload`.

That might even be a `enum class` to save on parentheses.


CopyrightsTo2015 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1670 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


Hi Mkhabela, I checked your file this morning and everything seems to be in order when compared to the spec, thanks a lot.


Indeed! I am excited to actually work on the integration side, but the rustc upgrade did the trick. Of course, immediately after, hyper upgraded and added new functions, which the newest websocket uses, but hey. This version works at least!


I learnt C without that, didn't even know about the issue with function declarations.


CopyrightsTo2015 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I am working on elasticsearch and logstash together. i process logs through logstash and upload them through elasticsearch version 1.4  . the problem am facing is after processing about 20 lakh lines of code, the processing almost gets stagnant to 5 lines per 10 secs. Can anyone help regarding this??


ana mesh fahem ! mesh fih table esmo locations_has_sports 3achan law el location fih aktar men sports. a lazmet el column da ?


gosh, how come this did not show up in the unit test i added ?!!!


wtf lol... odd


FR & CR done. **Approved.**


oops...


@AkamaiDASH, I think this check should be in isSupported method of our new LocalStorage class because we may want to switch to another storage model, e.g. sessionStorage or even something else.
The rest looks great! Thanks for this useful feature!


I am not sure if r.backoffDuration needs to be cleared in this case or not.


I think I'll leave that decision to @ranguard, our benevolent editor and director of all things content.

I don't (at all) see what's wrong with poking fun at Java; but I am sensitive to being inclusive, not offending people, etc, etc.


Why only if it's not default?


You won't be able to use the generated class name in one of the class's own computed properties. The binding won't be initialized yet.


Is this for indexers?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1126
success: http://build.servo.org/builders/linux2/builds/1126
success: http://build.servo.org/builders/android/builds/1160
success: http://build.servo.org/builders/mac1/builds/1339
success: http://build.servo.org/builders/mac2/builds/1342
success: http://build.servo.org/builders/gonk/builds/308


`SetTime` has this signature:

```Go
func SetTime(time float64) {
	C.glfwSetTime(C.double(time))
	panicError()
}
```

It doesn't return an error and panics on all errors.

I think the best way to handle `GLFW_INVALID_VALUE` is to panic, is that right?

If so, is it correct that we don't need to make any changes to take care of this?


빼빼로 먹고싶다..


Of course. You definitely need to show them the Object() syntax. I just didn't see a note about the literal syntax being preferable. That said, I know you can just speak to it during the lecture.


90022444-FewReleasePrepThings (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1672 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


#빼빼로 먹고싶다..


ResultsSchema (mbadams5) - x86_64-MacOS-10.9-clang: OK (1665 of 1668 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


# 빼빼로 먹고싶다..


No problem isabel
On 24 Mar 2015 7:53 AM, "Isabel Nel" <notifications@github.com> wrote:

> Hi Mkhabela, I checked your file this morning and everything seems to be
> in order when compared to the spec, thanks a lot.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BuzzSpaceB/Reporting/commit/a3186a19ecd560b44cbc533f311578398bb9db4a#commitcomment-10360048>
> .
>


If you merge with #2471, there is a new scheme for generating names, which subsumes two of the ways that exist today.


Should this be in utilities?


fast-forwarding master to auto = 2f85c5bb


Correct.


I noticed the weather is very fluffy of late. I wonder if it's because of all this wind!


Lol. Missing tests?


saw approval from jdm
at https://github.com/dmarcos/servo/commit/5c327058d34c987d2a1075b970aa51cddcbf7ff6


merging dmarcos/servo/issue4784 = 5c327058 into auto


dmarcos/servo/issue4784 = 5c327058 merged ok, testing candidate = fe916a06


I thought we don't need this anymore.


seems yes... added test for `set`, `add` and `sub`, but i did not test the 4 arguments values each time.


AutoDocsWithNoLTO (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1667 of 1673 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.64%25-yellow.svg)


I'm not sure if the phrasing is not clear or if the statement is not clear.
For the former, I can rephrase: the likelihood is a decreasing function of the sum of squares of the residuals.
For the latter, see [this](http://people.math.gatech.edu/~ecroot/3225/maximum_likelihood.pdf).


Nomas subi lo que Lore hizo en mi compu, ahi ta


Issues only


Also using the same value for x and y in the tests, and only asserting one of them for add and sub.


包袱重，这样妨碍我往前走，帮忙接着和改善。


This alert is there for testing purpose. I forgot to remove it. Thanks


makes me like even more this `_set` idea, as at least we then have a single place where we execute the callback.


Comment that these are bit flags.


Гэта ужо другая лаба на палімарфізм у гэтым навучальным годзе, але як бачу яго сутнасць не зусім да вас, @EkaterinaFomich, дайшла.

Сутнасць палімарфізма ў тым, што некалькі розных аб'ектаў (унаследванных ад аднаго класа) можна апрацоўваць аднолькава, але пры гэтым яны будуць весці сябе па рознаму.

Прапаную перарбіць гэтую лабараторную у такім напрамку:
У мэйне выпадкова генеруецца аб'ект з уласцівасцямі (матэр'ял і форма), а карыстальнік можа шмат разоў рабіць нейкі шэраг дзеянняў (з дапамогай меню як і зараз), на якія гэты аб'ект па рознаму рэагуе (вось ён палімарфізм). У рэшце карыстальнік павінен угадаць, што гэта за аб'ект. (нешта кшатлту гульні атрымаецца).

Вось прыклад аднаго такога запуска:
```
комп:
  Пэўны аб'ект ляжыць на стале, за мінімальную колькасць дзеянняў вызначыце яго матэр'ял і форму.

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 5

комп:
  1. Драўляны брусок
  2. Металічны брусок
  3. Шкляны брусок.
  4. Драўляны шар.
  5. Металічны шар.
  6. Шкляны шар.

карыстальнік: 3

комп: Вы прайгралі гэта быў металічны шар.
```

І яшчэ адзін прыклад:
```
комп:
  Пэўны аб'ект ляжыць на стале, за мінімальную колькасць дзеянняў вызначыце яго матэр'ял і форму.

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 1

комп:
  Аб'ект пакаціўся па сталу і упаў з моцным гукам, вы вярнулі аб'ект на стол

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 4

комп: Вы узялі халодны на дотык прадмет і што моцы швырнулі у сцяну. Пачуйся лязг і аб'ект распаўся ў друзачкі.

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 4

комп: Вы не збіраецеся збіраць гэтая друзачкі, каб ізноў іх разбіваць аб сцяну.

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 1

комп: Вы даткнуліся вострага кавалка.

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 2

комп: Вы узялі халодную неправільнай формы друзу  і параніліся аб востры нероўны край.

  1. Лёгка крануцца пальцам
  2. Узяць у руку.
  3. Ураніць на падлогу.
  4. Швырнуць у сцяну.
  5. Зрабіць здагадку.

карыстальнік: 5

комп:
  1. Драўляны брусок
  2. Металічны брусок
  3. Шкляны брусок.
  4. Драўляны шар.
  5. Металічны шар.
  6. Шкляны шар.

карыстальнік: 6

комп: Вы слушна здагадаліся пасля 5 дзеянняў.
```


Good point, I"ll squash them.


It looks like the client gem is not ready. I will talk to @rkh about this tomorrow.

In the future though, it is best not to raise these issues by commenting on the commits.


tak vespod ma furt slf4j tak si to muze zmenit na jakoukoliv implementaci a tim se mu zmeni i tohle :)


Thanks. Some points

Pharo is an open-source platform for professional. Open-source is important and different from open.

I think that we wrote everywhere open-source so we should keep it because else we will have to change all the book.

For the URL we use *http://www.pharoByExample.org>http://www.pharoByExample.org* and not
PharoByExample.org>http://www.pharoByExample.org because it is a question of interface. If you do not have a tool showing the link, you have no way to discover them.


nameConflictsWithSomeTempVariable


dikes za poznatek, zmenim :)


CopyrightsTo2015 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (654 of 656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.59%25-green.svg)


This method div.innerHTML actually do not returns div element, but only its content (see http://www.w3schools.com/jsref/prop_html_innerhtml.asp). Anyway I"ll use the better implementation of this.


Was it really pushed to maven? Args4j is already available, but github-api not...


Did this solve the Firefox issue?


It would have been cleaner to separate the software updates for the affected issues, wouldn't it?


Add a comment explaining how this function should be used. In particular, what names to expect, what to pass for tempVariableKind, and to only call this if you will never need the name in a nested scope.


I think it's worth explaining in a comment the relationship / difference between these names and the temp names.


Let's try to get rid of isUniqueLocalName after this change.


:clap:


There is another string alloc in simple_http.c which needs this. On my phone right now or I would fix it.


Why doesn't this share the generatedNames array?


Yes!!


Yes, however it worked fine without it. And as its part of Laravel's dependencies, I was unable to deploy this to our servers without limiting the version to 1.0.8, even though its not required for production.


Thanks for the report. Fixed by 7a7f5a967655b8159afa8dabb63cf06f87d21cc4

On 24 Mar 2015, at 4:45, David Howden wrote:

> This seems to have introduced a bug when switching themes.  Steps to
> reproduce:
> 1. Use the scaling to increase the font size
> 2. Change theme
> The font reverts original font-size but the "line-height" spacing
> remains that of the increased font size.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/textmate/textmate/commit/4a825499d6f18c0562e4d26be3e75c2e16fa2814#commitcomment-10355447


yeah, whereby probably 0.11.0 is not a good choice, but php.h is included anyway. Will fix that.

Thanks.


@marcominetti , thanks for targetting this typo


Ok for
Pharo is an open platform for professional..... because I forgot the first sentence.


Now everything in the checker takes a callback. Do these generate methods actually belong in the checker? Why is this here, but getExportNameSubstitution (for example) in the checker?


> this finally hard-codes the use of `mintty`

Yes, I guess you are correct. This is only a first step, though. You will underss
tand that I had to prove that this idea works first before I make it configurabll
e. And as a proof-of-concept, `mintty` made the most sense.

> Maybe use an environment variable that points to a default console then?

Unfortunately, it is impossible to set environment variables in `.lnk` files (i..
e. shortcuts), or in the Properties of executables. That is the reason why we haa
ve the Git wrapper in the first place ;-)

I was actually considering two options for future extensibility:

- either just append plain text to the `.exe` files (assuming that Windows won'tt
 mind if there are extra bytes at the end, evidence for which being the self-extt
ractor we use for the net installer, where the entire `.7z` archive is appended
after the `.exe`) like `\nusr\\bin\\mintty.exe ...\n\n` (i.e. some special-craftt
ed text that can be discerned easily from the `.exe` part of the file) and execuu
te that if it is found. This could even be triggered by yet another basename: foo
r example, if the wrapper is renamed to `go.exe`, it could be taught to *expect**
 that command-line to be appended to the `.exe`.

- another, possibly cleaner, but also slightly bloating way would be to have thee
 command-line as an optional resource embedded in the `.exe`. This would requiree
 a command-line option to override that setting, though, enlarging the Git wrappp
er further.


code lgtm, Question: When `XWalkCoreBridge.getInstance() == null` happens?


Using mutable types such as dictionaries in a method signature can cause side-effects, and is therefore generally discouraged. I would suggest leaving `clients` set to `None` and handling the default value assignment below.


Is this somehow generated automatically? FWIW there are duplicated names.


@marcominetti , why we need redirection from `/`?


This could be changed into
``` python
self._clients = clients or {}
```
for handling the assignment in case `clients` is not set.


I like the recursive do here, neat


I integrated the comment and did a pas on other parts.


@lidashuang 你真活跃


Why isn't GTest part of the build?

https://code.google.com/p/googletest/wiki/FAQ#Why_is_it_not_recommended_to_install_a_pre-compiled_copy_of_Goog


how did you generate the Binaries/Win64/UE4Editor-RadiantUI_SDK.dll file?


The reflection layer is initialized before all things on both of embedded mode and shared mode. But in test of XWalkCoreInternalShell, this step is skipped because there's no reflection layer. In this case, the instance of XWalkCoreBridge is null.


How about `?ws="127.0.0.1:8080?port=5858"` ?

```js
...
search: '?' + buildWebSocketUrl(host, inspectorPort, debugPort)
...

function buildWebSocketUrl(inspectorHost, inspectorPort, debugPort) {
  return 'ws="' + inspectorHost + ':' + inspectorPort + '?port=' + debugPort + '"';
}
```


This strikes me as a bad idea, simply because the definition and declaration look different now, even though they're interpreted identically. Though, if you're going to get rid of the header files (eg: auto-generate them) I'd be all for it.


Согласна. Спасибо, что убрал.


不行啊


This needs to be here, because pyfr.scripts.mesh import h5py which initializes MPI.


that you need to ask from Pavel. Maybe we should look to it.


Aipoトップページ→フォルダ→ファイル一覧ではリンク、ログインユーザ判定共に実装できました。
Aipoトップページ→フォルダ→フォルダ一覧では同じように実装しようとしたところ、ファイル構成が異なっていたようでまだ実装できていませんが、手順を説明してもらったので次回実装できるかと思います。


some tests failed:
failure: http://build.servo.org/builders/mac2/builds/1343


试一试


We don't need crossbrowser realisation of save file - we use only webkit based browsers. So I don't seer reason to backport this library here.


Feel free to reach out if you have any questions, @RnbWd !


saw approval from glennw
at https://github.com/nnethercote/servo/commit/42fab7755fac46b0a7f95bfb359a96bad4fde4ca


merging nnethercote/servo/profile-crate = 42fab775 into auto


nnethercote/servo/profile-crate = 42fab775 merged ok, testing candidate = 5565524f


Awesome, now we can change function_min and function_max! :-)


only need declare variable line 37 is better


Can we get rid of this file? The header is everywhere, even in the wiki.


\o/


Well, I think we should start with only positive transactions. User can always check his/her negative transactions by ordering account statement.


ehm.. I dont agree its abuse. since the rhs is also a bool value.


I'd prefer to keep it here since nodeId is mostly used and assigned in the checker


@sshumake Don't we want to cache the search result. Like query = caseStatus+caseOwner+caseGroup+......;


Warning: Not correct id for creature (need change to 21699)


Reviewed!


one comment


Any clues why the closing `*/` doesn't show up in a new line? Locally looks good, but GH displays it like this everywhere, even in its raw form.


you're using O(n) extra space.

a, b = 1, 1
a, b = b, a+b


removed it


Feel free to delete gui_x11.txt in this PR


Yes it was just for me to ensure that my phone is getting the notifications


Please copy/paste comments here from the design doc that explain the rationale.


generatedNames are keyed by node id, blockScopedVariableToGeneratedName are keyed by symbol id


If you are going to auto-generate header files, that tool should aware of the grammar and automatically insert "void" to the parameter list. It looks different now, but if you understand the grammar or don't care about that at all, the new code should look better and concise. I don't feel actually comfortable with the new code yet, because it's different from the way what I have been writing code, but if this is what the language allows and it's a way to write concise code, I want to train myself.


und jetzt noch der letzte Schritt, den gerefactorten Code in der game.js benutzen und die alte Funktion ersetzen, dann ist ein Ziel erreicht.


If someone can pull off said autoconf magic that would be awesome.


wow


ResultsSchema (sanyalj) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.37%25-red.svg)


..of course this is not the best solution


You can go with *actionAdminMetaBeforeWriteRobotsFile* and *actionAdminMetaAfterWriteRobotsFile* if you want, we chose the former names because they were more explicit, but the ones you propose would probably be easier to remember.

No problem with that! ;-)


After I merge the clipboard sections into `nvim_clipboard.txt`? I saw you mention that in #2231, so just wanted to clarify.


ack


Understand which version is better and why. Try to analyse their complexity


> Also, I've noticed that there is no Intellisense support for internal
variables in a forEach, e.g. in below example, although r1 and r2's type
are well-defined (and shown in the tooltip), there is no Intellisense
support for r1.

I tried it. It works:

![image](https://cloud.githubusercontent.com/assets/874898/6797149/7777b9f6-d252-11e4-915e-0a0929814b3a.png)

my source:
```ts
interface ILookupResult {
    name: string;
    score: number;
}

function mergeResults(result1: ILookupResult[], result2: ILookupResult[]):
    ILookupResult[] {
    var r: ILookupResult[] = [];
    result1.forEach((r1) => {
        result2.forEach((r2) => {
            r1.
        });
    });
    r = r.sort((a, b) => { return b.score - a.score; });
    return r;
}
```


@gitster I think you are right and we should give more visibility to contributing writers/reporters, so for their contributions I think we should add (by John Random) just after the title of the section they wrote.

With that it should be ok to have just something like the following at the end:

```
This edition of Git Rev News was curated by Christian Couder
<<christian.couder@gmail.com>> and Thomas Ferris Nicolaisen
<<tfnico@gmail.com>> with help from John Random, X Y, ...
```


Has approx 10 statements (TooManyStatements)


Method has too many lines. [14/10]


do you mean : `float32, float64`?


same here


first


@danmar What was wrong with that change?


Why do we really need meta?


Dear Benjamin,

thanks for your reply!.
1) You are right, I'll change my contribution for a warning.
2) I get your point on this. So far, the solution that we were using was to use only the Units of one of the EEG channels and call, e.g., plot_channel(....,'yUnit',cnt.yUnit{EEG_CHANNEL_IDX}), which is definitely not an elegant solution.

How should we do this without breaking the compatibility with the plotting functions?. I was thinking of maybe adding an auxiliary field to cnt/epo describing "non uV" channels?. something like yUnit_alt which will contain the units as a cell array of strings, obviously, modifying proc_selectChannels accordingly (to also "select" the units of this auxiliary field).

Best,

Sebastián


@danmar Yes, but here the rhs is computed even when `type` is already `true` which is just waste of time.


@swati suggest the following might be slightly better (just syntax)

    order_details = Gogovan.new(order.booking_id).status()


screen [and] 'more'...


Snif, another new query for homepage... Home page wasn't meant to be a dashboard : there is a dashboard for this. And we forget it more and more with every new feature...


@vu3rdd All files start with Uppercase.


could do twice program.parse via commander package. That would work also. Or have two program instance. No need this redundant dependency.


Re: Auto-generate; agreed.

Re: Manually copy and paste. Well that's it, it's not copy and paste any more, you have to pause and actually remember that yes, they are the same. It's like using a pointer in the function declaration but putting an array in the definition. Sure it's technically right, but it sure doesn't look like a good idea. It's the same reason you clutter up the prototypes with unnecessary variable names.

Actually, to me, this does feel like another K&R compatibility tweak not something that's part of the idea of Ansi prototypes.


@swatijadhav Can you make the wait time a constant in config/initializers/constants.rb


some tests failed:
failure: http://build.servo.org/builders/gonk/builds/310


Remove this?  (I guess this case never gets hit)


Fantastic!


We need pointer size to be at least 32 bit, is that the case on 8-bit or 16-bit platforms?


Is there a dtor call for this?


Ok, I'll replace it with webkit-proof code.


What's this?


Ternary operator here and in v7_iter_get_name ?


Sorry to bother you again, but I think this transition, makes the menu-icon transition after the menu title. Not sure if this was intended.


@afnogueira Thanks for the contribution.
Instead of putting some logical here, could you deplace to be compliant with the rules we use for others actions (See line 170).
You can create private MessageEvent doActionCalculateProperty and put the logical inside.
Thanks


It looks great. Thanks for your great contribution.


Hmm I feel like we should `continue` or something here and not put the frame info into the symbol table.  Unlike the other special names for closures/generators we're storing this variable in another location and so it seems misleading to store it here as well.


Feel weird to have a `strict` and a `loose` option. When setting `strict` to `false` you expect it to be `loose` :P.


camelCase for function names please :)


continuing my previous comment, I think we should not let this be an 'allowable ending symbol' since we might want to keep it out of the symbol table in the first place.


This actually returns:

`['t', 'e', 'x', 't', '/', 'p', 'l', 'a', 'i', 'n']`

Have fixed in pull request [3185](https://github.com/kivy/kivy/pull/3185)


Won't the driver handle ``silence``?


CopyrightsTo2015 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1164 of 1166 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.77%25-green.svg)


@swatijadhav  can we queue these as ```gogovan_orders``` that way we can set the priority to low. Also need to change ```config/sidekiq.yml``` to add new queue


I actually tried doing that for a while, but couldn't get it to pass, it kept `assert`ing in phi-related code and I couldn't figure out how to keep it entirely out. I'm sure I could have done something better, but the easiest way I got it to work was to just treat it like the generator and closure objects.


@afnogueira Could you update or rebase before submitting a pool request?
If I accept you pull request, this will delete change of last week.


```ruby
document.asset_file? || document.data['regenerate'] || \
  source_modified_or_dest_missing?(
    site.in_source_dir(document.relative_path), document.destination(@site.dest)
  )
```

is much more readable.  Mind doing it this way?  -- There is also no need for the return as it's implicit in Ruby.


Nice


I would prefer if we didn't skip these tests...


No, indeed, it is a mistake. It should be !=. I have removed this statement completely, because it is not necessary. I have found out that getHeaderString() is case-insensitive. Thank you.


Same comment as above (regarding style and implicit returns.)


test


No necesitamos ese fix para ie6 puede ser eliminado.


Not much of a reason to change it - but if you'd passed `this` as the parent in the ctor, Qt would do the cleaning up of these widgets for you.


gah! sorry, meant to undo before committing


ack


Yes, that is the ultimate goal


using statements go inside the namespace declarationg


@suvash Cheers, we recently did a conversion of the docs to Sphinx, and some things managed to slip through the numpty checks.

Cheers, in future if you do spot any more missing pieces of text i.e. issues or anything else wrong, can you please submit an issue instead. This way there is less chance that it will get lost in the notification streams.


"new" in commit message shortlog is not really adding information. (I could have written: ... is not really adding new information. Thats the same, you see?)


missing given when then comments


I believe this line is trying to escape any question mark which would become invalid when converted to the UNC form. However, I think it should be removed as any escaping of this sort should be performed on the same place as the conversion to UNC.
I suspect it was a misguided hack to try to get things working, and IMO should not be done even in libuv.


@wesleycho The real name of the function assertValidDirectiveName should be assertFirstLetterLowercase. I'm not trying to troll here :) Just to maybe start some discussion whether the directive names should be validated or not. I've mention that a bit in this issue: https://github.com/angular/angular.js/issues/11397
Currently you could name a directive any of those example chars: < > " | (or single space). Would that be valid directive name? assertValidDirectiveName would say yes :) But then how would you use this directive in a html?


Should be caching type then.


It looks like above that he (reverse) short-circuiting if there is no path, why allow nil path and destination now?


Can you use the P2QSTRING macro, rather than the Qt functions for conversion, please?


Good reminder, thanks!


Much cleaner :)


This might be interesting to add to the main repo as routeconstraint


Is there a reason to typedef this? Where we pass it around elsewhere we just pass it as its raw type.


There is a fourth instance of `2i` in this file that could  be changed to `(2.0*I)` as well.


Great. I will change it.

Best regards and thanks again for your contribution.

Best regards


Hay que agregar ese dispose


I don't know if the rest of @jekyll/core will accept this but I think this is definately a case of control statements.

```ruby
((source_path and modified?(source_path)) or true) || (dest_path and !File.exist?(dest_path))
```


ResultsSchema (sanyalj) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.37%25-red.svg)


очень не красиво выглядит, когда появляется например blog из ниоткуда


エンコードの時にShift-JISを使用するようって本に書いてあったので、UTF-8ではなくそちを使ったら文字化けをしてしまいました。


minor suggestion: we already have 2 times `complain 72` in `qa_crowbarsetup.sh` for two different fails. i know this is just for reference, but I would expect every fail to have its unique code


Quite hard to reproduce in Chrome. I have been able to see it (not always in firefox) when the screen is resized for example.
=> first analysis : due to a dynamic margin-top added in customize-controls.js in onChangeExpanded() #680


`${cluster%=*}` `${cluster#*=}` `${group%%+*}` are very bashy (i mean cryptic), maybe worth a comment?


Missing one `*` character.


Please tag a FIXME for @envygeeks because we are moving to RSpec and all these asserts in the same test are a classic example of why shared specs are useful.  There is nothing you can do here (and now because Minitest doesn't support shared "specs", but it would be great if you could tag a FIXME so when I'm working on the tests I can spot the problem we just noticed and remember to split this up into a shared spec.


could we give this variable a more meaningful name? like `availablenodeslist` or sth similar? `L` does not say much and makes it harder to understand what is inside the variable.
and could we also put `printf "%s\n" $L` into a separate function with a meaningful name? we use it a few times, that would be a justification ;)


maybe call it `rubyop`?


I knew this would make you tremendously happy ! We are running on a cloud
povider, the load should be handled :-)
Second option : I can set a cache so these requests are only performed once
(a day)

On Tue, Mar 24, 2015 at 8:25 AM, Cyril Lacôte <notifications@github.com>
wrote:

> Snif, another new query for homepage... Home page wasn't meant to be a
> dashboard : there is a dashboard for this. And we forget it more and more
> with every new feature...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mpetitdant/linkit/commit/dc6408c26861e8e2a5380ab3f7b05caed789ce12#commitcomment-10360803>
> .
>


тесты?


This kills me.


minor: I would state in the comment which nodes are removed from the list. just saying nodes does not say much


This assertion need be explicit.  If you created a file test for a file, if you create a folder, test for a file type directory.  Implicit testing is bad IMO and this is definitely a fallible test prone to edge abuse.


@exalted Initially I wanted to avoid mismatching between our command and Heroku's one, especially since the plugin would be downloaded when not installed.

However, I think it's fine to keep a separate naming for our command: this way we're able to draw a line between what's ours and what's not. If we name it `fork` and someone else comes along, she may think that the original `fork` version allows `HEROKU_API_KEY`, or whatever (this someone else may be ourselves in two months :smile:).

Are you strongly opposed to that? Shall we keep it as-is (or find a better name than `da-fork` maybe :laughing:)?


Please follow naming conventions for constants
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html


avoid using global state!


Its does not require an apostrophe in this case (it's old coordinates = it is old coordinates) not that it matters much.


ops yesterday I looked at that code and I pointed my suspicious on #715 (I'm looking at the github wordpress file)

content.css( 'margin-top', ( 45 - position - scroll ) );

I can always reproduce it with my Chrome, it might depend on the screen resolution ..


this function is too long, please shorten it


I dont know why I look like the author. Some mistake it seems. Please forgive.


Plugin(module) list -
block_btn：block 按鈕樣式
btn：通用按鈕樣式
collapser：介面展開功能
confirm_box：確認視窗
crumbs：微型選單
data_to_dom：JSON / DOM 資料自動轉換
datepicker：日期選擇器
fancybox：彈出視窗
form_checker：表單檢查
input_file：上傳功能
input_restrict：輸入欄位自動
list_dom：自動將 JSON-ARRAY 的資料放到 DOM 並 list
list_table：自動將 JSON-ARRAY 的資料放到 Table-DOM 並 list
multi_check_box：基本 checkbox 功能
navigation：上方主選單
notification：彈跳式訊息視窗
page_history：運用 cookie 存儲瀏覽紀錄
pagination：跳頁功能
search_link：將 DOM 轉為搜尋樣式
select：基本下拉選單
select_pipcker：進階下拉選單，支援多選功能
set_language： Web 快速多國語言切換功能
table_sorter：tatble-list 排序功能
text_shorter：文字內容自動隱藏
user_center：使用者功能，如修改密碼..基本資料(客製化)


1. given that lxc is not emulating the kernel, the binfmt handler must be registered on the host system. Like with chroot.

2. IMHO should be possible, lxc is chaining the access via them, right?

3. should be solved in the host system again


Would've been easier to inform me - I had these locally.


If you want to keep this revert, please keep the SendInventory with a playersao parameter because playersao is always known when calling the function, this permit to remove a useless lookup in the peer table


Thanks :grinning:  First time in a long time that I had to think with what to do with git!


But the thing is, this could be one or more than 1 scow... I could edit the params to make it grammatically correct if you like.
num_scows == 1 ? param = "" : param ="s";


@udalov
No, this was automatically replaced by IDE --- should be reverted to previous value.


Ini hanya mencoba saja


general requirement for the Python code is to follow PEP8 recommendations.
Configure your IDE to check PEP8 or use one of the tools for that - flake8, for instance.


You need to do something like this here: https://github.com/dimagi/commcare-hq/blob/master/corehq/apps/domain/forms.py#L485-485


should be removed ?


Yes of course. The problem here was that I already pushed it and didn't want to force push on the master branch. I will make sure to avoid this in the future.


do not use exceptions for the things that can be checked before.


This assert is triggered and don't make sense, e.g. numQuadsX * numQuadsZ is 4096 (>1024) on a 16x16 map.


function name is very general - it is not clear what format of the line is expected and what will be produced. Document the function and prefer meaningful names for the parameters in function signature . (d -> file_)


avoid side effects


Is it really important to have the ` ? true : false` ? I mean, the whole
`'true' === strtolower($this->request->query->get('newValue'))`instruction is already a comparison that returns whether true or false...


second


what is the purpose of this statement ?


a lot of functions in this module do not return but update global state. This is very bad practice leading to the code which is  hard to follow/maintain and understand. Ideally in this simple task there shouldn't be any global state at all.


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1667 of 1672 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg)


better to have only 1 return statement in the function.


What's the point of having a local history if you're using git? That's the main purpose of git.


I think it hasn't got nothing common with a state.  This code is about collecting objects. Please, see this OVAL: http://ur1.ca/jyy00 and see the appropriate OVAL results: http://ur1.ca/jyy0p. In this OVAL, the state didn't match the object, but there is no error message in OVAL results.


Ini yang terakhir mas @yaditya? Ada editan lain sebelum saya minta merge PR?


:clap:


vital commit. :+1:


Could you explain what this doing? I've seen those lines pass now for a bunch of times, but this is the first time I've seen its impact.


Nice :+1:


changed
` int mailimap_is__complex_command_tag_enabled(mailimap * imap); `
` void mailimap_set_complex_command_tag_enabled(mailimap * imap, int enabled);`
to
`int mailimap_is_163_workaround_enabled(mailimap * imap);`
`void mailimap_set_163_workaround_enabled(mailimap * imap, int enabled);`


try to transform this for-statement to the list-comprehension and remove global-state usage.


Commentator


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I vote to not merge this and instead change the input gate behaviour to return `null` or thrown an Exception when all channels have been consumed and there is a `getNextBufferOrEvent` call.

I think this is more intuitive for future users of this lower level API. Is that OK or do you need this in immediately?


try to use list-comprehension and string.join method to get the same result


If `Profile` inherits from `ToxCore`, and maybe `ToxAv`, that's going to be one huge class.


Another unrelated question: why are you working on @mbalassi's fork and don't fork it yourself?


来看看你


rewrite this block considering that dict.get has a second optional parameter to specify default value when nothing found by key.


```<(*,this,is,a) --> test>.```


thank you :)


Thank  you for  share DAws project  :+1:


tu parle de messageSend ? Car c'est comme cela qu'on initialize un objet backbone.


use a new style form for catching exceptions:

`except IOError as error`

2) except catches errors not messages (update the name of the variable where error is bounded to)


asdf
asdf


some `#ifdef VERSION_integer_gmp` may be needed here to fix #90


#111
##111


It's very easy to make some words **bold** and other words *italic* with Markdown. You can even [link to Google!](http://google.com)


I can't claim to be any kind of fan of the ternary statement, as I'm not of the opinion that this is particularly clear.


Ok if it's just a matter of getting it to work, I'll send you a PR.  I'm pretty against storing this information in two places but saying that you shouldn't touch one of them, and I think we should definitely commit to one place or the other and just make it work :)


So you have to wrap each call in both a try/catch and attach a .catch handler?


something is really going wrong with this. calling DownloadLibass from base dir results in an error "not found". calling it from deps deletes the entire tree


this commit closed issue #11


Hi @jwiegley. I'm not sure about implementing `req-package` as extension, because one of things it does is completely avoid `use-package` call when it's not necessary, so it could be much more faster and minimalistic.
Also I answered on your issue on `req-package`, let's discuss.


Why product?


r=glennw


Sorry, #21


LOL! Beat me to it..


saw approval from glennw
at https://github.com/nnethercote/servo/commit/e6ca8833ba8386988c997e6cc3ea96c7ea420964


merging nnethercote/servo/profile-crate = e6ca8833 into auto


nnethercote/servo/profile-crate = e6ca8833 merged ok, testing candidate = f3b4fa00


:+1:  You took the words out of my mouth


We did look at that, but the docs was unclear about if it would show just the name instead. Seems it might do that.


No, you don't have to. Just make sure the transform function always returns an object.


@udalov
Please use commit from https://github.com/JetBrains/kotlin/commit/a5a19cdd38c3635f2fafb5c69f56dd875ada9bbc
where line in idea-analysis has been corrected.


> Question: Can't you group the two size lines in the same font file?

It doesn't look like it. I tried to put two <Font /> definitions in the same file, and differentiate them by name in the scheme, but I get:
```
CEGUI::GenericException in function 'virtual void CEGUI::ExpatParser::parseXML(CEGUI::XMLHandler&, const CEGUI::RawDataContainer&, const CEGUI::String&)' (/home/iurt/rpmbuild/BUILD/cegui-0.8.4/cegui/src/XMLParserModules/Expat/XMLParser.cpp:72) : XML Parsing error 'junk after document element' at line 2
terminate called after throwing an instance of 'CEGUI::GenericException'
  what():  CEGUI::GenericException in function 'virtual void CEGUI::ExpatParser::parseXML(CEGUI::XMLHandler&, const CEGUI::RawDataContainer&, const CEGUI::String&)' (/home/iurt/rpmbuild/BUILD/cegui-0.8.4/cegui/src/XMLParserModules/Expat/XMLParser.cpp:72) : XML Parsing error 'junk after document element' at line 2
```

On the Speed Dreams wiki they also confirm that: "A .font file defines a "font" in the CEGUI meaning : a real font + 1 size" [1]

On the other hand it looks like we could drop the "name" argument from the .scheme file, as it's redundant with the name defined in the .font file (and if they are not in sync the game won't start).

[1] https://sourceforge.net/p/speed-dreams/wiki/UsingCEGUI/#font-files


;) sorry!


I've added blank line above `return` to emphasize there's no code execution happening further if that branch was taken.


Arf, thanks. I had this weird "something is missing" feeling.

Should be fixed now.


Here, a const would be nice to make clear this is a const string


Well honestly, we could have done just `$('#download-modal .actions a');`. `.find()` is for searching in an existing jQuery selector. But it's ok that way.


Edsko, Duncan and me have discussed this for a while, actually. In the end, we narrowly decided that we should keep the top-down solver around for a little bit longer. But with the extensions Edsko has been working on, the modular solver will actually finally be able to handle even GHC < 7 correctly, so we will hopefully be able to make the modular solver the default everywhere.


Sure I found other problems unfortunately.

We work on Martons branch so everyone in the streaming team sees what the others are doing :)


sfsdfgsfg


awefae


definition of md5_byte_t used to calculate the ofset in CoreGetRomSettings


I like the quirky sayins in the Javascript, just curious why all the math on the JS side as opposed to it being passed from the backend using built-in Jenkins functions ... my own version/change using `Util.getPastTimeString`:
https://github.com/Brantone/jenkins-build-monitor-plugin/commit/11420f149598cc7d8b136785b24daa4d51025cd1


Is Reflexil merging with ILSpy or adding compatibility?


1.The tabbar is  like  请吃饭app
2.You can init redCircle with NSNotification
  [[NSNotificationCenter defaultCenter]postNotificationName:@"initRedState" object:nil userInfo:redStateDic];


too many only ;)


For production we should disable all console output, shouldn't we?


@test, thank you :)


Nice text. Pretty clear. I think you covered almost everything. I guess some words about research would be nice once the gui is in and functional.


I don'i like getting somthing like: config = { js: { js { ... } } }


Don't we then need to build a `git-cmd.exe`, too, analogous to 857b1a5c178001c578a0433cec8bcd763b4a4f6a?


Ok, extern don't necessarily require the actual definition


yes, I agree


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/bd4d00c2ff846352513058f69287ea507bb7b3b8


merging basho/riak_cs/feature/migration-rt-15-to-20 = bd4d00c2 into borshop-integration-1104-feature/migration-rt-15-to-20


basho/riak_cs/feature/migration-rt-15-to-20 = bd4d00c2 merged ok, testing candidate = 3faa2930


ResultsSchema (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1672 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Whoop whoop!

Just one minor note: With the new close button (`×` instead of `X`), it looks a little wrong positioned.


> Creates a link tag of the given name using a URL created by the set of options if condition is true, otherwise only the name is returned.

Pretty clear to me :) But no big deal. Your version is probably easier to digest for most.


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (653 of 654 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.54%25-green.svg)


I try to find libmatio.lib,but failed.All other files like szip.lib,hdf5.dll etc are prepared.Could you give me a source to download it?Thank you.


# This is an <h1> tag


Thanks, I'll make those changes.
I wonder about the std::endl though, I use the same formatting as before, but wouldn't it be more logical to use "\n" here and only flush at the end of the stringstream?


Got the stack trace and or exception?

On Monday, 23 March 2015, 3CG <notifications@github.com> wrote:

> I should note here that I had a crash during testing that I couldn't
> replicate here...
>
> public void setCurrentModule(Module m) {
> if (currentModule == m) return;
>
>     if (currentModule != null) {
>         currentModule.moveAway();
>     }
>
>     if (m == null) return;
>
>     addActor(m);
>     m.toBack();
>     currentModule = m;
>     m.moveIn();
> }
>
> on m.moveIn()
>
> (Gamescreen.198)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srpatel/Spaceheist/commit/6dc371e2a12b713e4cf072f2b86f8c50f968d77d#commitcomment-10356891>
> .
>


I believe this is backported, and may justify a prompt 0.3.7 release. Cc: @juliabackports @tkelman


c'est php-cs-fixer qui a fait cette modif ?


obviously, yes :-)


It's required by ``pythonic/types/numpy_nary_expr.hpp``


`.php_cs.cache"` instead of `.php_cs.cache.`


! merci


Yes, that would only be a patch release. Maybe we should refrain from using a version number for design compatibility and just choose an internal format that is not visible to the user.

Yes, I would want the compatibility version (if it is a version) to be independent of a design version. They can be the same but don't have to.


# This is an
#This is an


Looks very wrong - was probably a bad merge somewhere along the line. There
should be another begin() towards the end of the function. Don't know why
this isn't crashing though :p will look tonight?

Given its all seeming ok, I should probably separate it out a bit now. Game
initialisation should happen in LobbyScreen.java :p

On Tuesday, 24 March 2015, 3CG <notifications@github.com> wrote:

> director.begin();
> {
> director = new Director();
>
> Begin the director then make a new one? Or do these braces do something
> crazy? I thought in-function braces were just if you wanted to do something
> weird with scoping.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srpatel/Spaceheist/commit/30e25625536aefb70e99d7776e1ef090503de2e5#commitcomment-10358402>
> .
>


Yes, this is right


I don't think the information which terminal program to use (be it mintty or something lese) should go to git-wrapper in the first place. Lines 196 to 198 are terminal program specific configuration options, and as such, they should be set in the terminal program, not here.

Anyway, now that we have it, I'm ok with keeping it as-is. But how about at least renaming the executable from `git-bash.exe` to `git-mintty.exe` to make the dependency on mintty more obvious? Later on, we could add code paths that try to find and make use of existing ConEmu and ConsoleZ installations if the git-wrapper is started as `git-conemu.exe` or `git-consolez.exe` respectively.


See #204


stability markers?


Yes, you are right


Oh absolutely ! I will indeed submit an issue. Just was in a hurry. Cheers !


有几个问题需要问一下你们：
@BernardXiong @AubrCool
就是按照框架的设计初衷来说是不是只允许一个pin设备存在？还是可以注册多个设备，
如果注册多个设备的话，框架里面的调试函数
/* RT-Thread Hardware PIN APIs */
void rt_pin_mode(rt_base_t pin, rt_base_t mode)
{
    _hw_pin.ops->pin_mode(&_hw_pin.parent, pin, mode);
}
FINSH_FUNCTION_EXPORT_ALIAS(rt_pin_mode, pinMode, set hardware pin mode);

void rt_pin_write(rt_base_t pin, rt_base_t value)
{
    _hw_pin.ops->pin_write(&_hw_pin.parent, pin, value);
}
FINSH_FUNCTION_EXPORT_ALIAS(rt_pin_write, pinWrite, write value to hardware pin);

int  rt_pin_read(rt_base_t pin)
{
    return _hw_pin.ops->pin_read(&_hw_pin.parent, pin);
}
FINSH_FUNCTION_EXPORT_ALIAS(rt_pin_read, pinRead, read status from hardware pin);

是不是需要修改过，也增加一个name参数来打开不同的设备？


Well, yeah. I meant to put that into a separate commit but then forgot it.


As Kanye West said:

> We're living the future so
> the present is our past.


mempak_read_command, rumblepak_read_command. I just followed your recommendations to use si_controller.h instead of adding mempak.h and rumblepak.h


Yes true, I thought about this in my sleep. Static should only be for
things which are always the same - eg textures. Otherwise use instance
properties and something like Map.self.property I suggest. Initialise the
stuff in the constructor.

My current thought is we should construct new modules for each game.

On Tuesday, 24 March 2015, 3CG <notifications@github.com> wrote:

> This could cause issues maybe, right? Static initialisation using mission
> which might not be there in time or something. Huh, it probably shouldn't
> be a static init block anyway if we want people to play >1 game!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srpatel/Spaceheist/commit/465ffdf95c66b0f3b5a96af2e54e157798013a11#commitcomment-10358634>
> .
>


I could use a show method, but it's not in the spirit of rest and with this method, we can't do performance optimisation with shouldComponentUpdate.


Actually ModPlug supports decoding to 8, 16 or 32 bit integers and a couple of sampling rates. However the ModPlug code states:
```
/* Note that ModPlug always decodes sound at 44100kHz, 32 bit, stereo and then
* down-mixes to the settings you choose. */
```
With the new sound source API, this should probably be configurable (because 32 bit requires a lot of buffersize), or the default changed to 32 bits, since that's what we really want here. Thanks for the work. I really hope I get to test this around easter holidays.


correct


Needs some javadoc here


@michaelbroper  - This doesn't work in all case scenarios:

My shop sells a manufacturers products at cut rate prices - i list the regular price as the retail price and my price as the sale price - i need google to pick up the sale price so that in comparison with other shops i attract the business because of my attitude towards pricing.


This is a simple test


![ios simulator screen shot 2015 3 24 4 42 48](https://cloud.githubusercontent.com/assets/8475091/6798124/f6ae446e-d244-11e4-82f9-4193866a8817.png)
![ios simulator screen shot 2015 3 24 4 43 06]


i think that will do. but if it doesn't -- then you just have to resolve conflicts on merge :)


DOn't touch


Needs javadoc here too


change to package visibility


javadoc


I have merged your pull request!


I just tagged 0.3.7 a few hours ago. We haven't posted the binaries yet, but the git history is there.


@eviltoylet I restored search behavior to what it was and added a highlighter. Here's how it works:

```js
var highlight = Search.highlight(() => this.state.search.query);

...

cell: highlight
```

To make this work `Search` exposes its query. `Search.highlight` generates a function that checks that value. In addition it performs a check against the cell value itself given search could match some other cell within that row. I'm not particularly fond of that bit but it works.

In the process I made it possible to pass formatters to `Search` so they may be shared with `Table` cells. Now there's just a single place to maintain if you make formatting changes this way.

Let me know what you think. I feel like we're getting close to a nice API here.


change to package visibility (class + methods)


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/965


back to history


some tests failed:
failure: http://build.servo.org/builders/gonk/builds/311


@felixboehm This is against stable7


To be honest, I pretty don't like this change, as it's just syntactic sugar, which gradates performance a little bit (but every bit is counted one day).


Only tested on Lollipop.


Nice one u have here! Working fine on my 5.0.2 CAF ROM for hammerhead


libreport sometimes removes new line characters for the last line, it would be much safer to use (\s*|$) here


Justement c'est MainWindow le Frame principal et pour les premiers chargement il gère de JPanel. L'écran d'option est un JPanel, je pensais aussi que l'écran d'accueil était un JPanel et que Mainwindow gérait les transitions ?


:+1: Great Job. This is now much more readable. Hopefully my port will also work.
There are so much new things.


The correct strings are "uReport:" and "ABRT Server:".


Extra empty line detected at block body end.


Could be. Will take a look. Feel free to make a pull request.


What happened to xz?


test ligne


package visibility


`#call` with a `#`


I'd agree if this code was part of the render loop; child management is far less critical. Furthermore, we're talking about one if per method, no additional function call, so I doubt that this would show any impact even on hundreds of iterations. In fact, when I'm able to reverse my very latest commit (9fd6733), "addChild" whould even be *faster* then before, because the function "numChildren" is called only once, not twice.

That said: this change can still be reverted if it causes any issues or is unpopular for some other reasons. I just don't think that performance speaks against it.


I just checked, and apparently the HTTP auth restrictions (only supports ISO-8859-1) also apply to the password. So I'll have to limit to that (minus : and ').
[http://stackoverflow.com/a/703341](http://stackoverflow.com/a/703341)
[http://stackoverflow.com/a/22159296](http://stackoverflow.com/a/22159296)


I'm aware of that. I intended to type ``indices.join(', ')``, not ``target.join(', ')``, when I wrote this. This is fixed in d166d06


fast-forwarding develop to borshop-integration-1104-feature/migration-rt-15-to-20 = 3faa2930


Oh, fair enough :)


Where did that list_order come from? It's always zero and nothing updates it ever. Totally useless field. Must be some leftover from development process years ago.


first


Yes I have that use case ,it is a mobile game , you can download it by this address:http://a.3533.com/youxi/53964.htm.
you should compile mono-unity and replace the original libmono.so


That has to be `org.openhab.binding`


That has to be `pom`


Reindent


Nice, but how can i change the state?


serial port communication moudule write in python lang


split


Typo appendClassContextStatements should be appendClassContentStatements


You require guava 15 here, but no jar in libs for that.


*This text will be italic*
_This will also be italic_

**This text will be bold**
__This will also be bold__

*You **can** combine them*


http://github.com - automatic!
[GitHub](http://github.com)


I think you should use an
`<addr>` element here instead.


Fixed, see https://github.com/mfhepp/schemaorg/commit/810af8cdaf79e6eb058f75d2721fe214cb09435b

-----------------------------------
martin hepp  http://www.heppnetz.de
mhepp@computer.org          @mfhepp

On 17 Mar 2015, at 20:47, tmarshbing <notifications@github.com> wrote:

> That should have changed to interiorColor, not vin, right?
>
> �
> Reply to this email directly or view it on GitHub.
>


hi Malte
I don't understand all new code.
the clear search cache function is accessible from admin (maybe with a button) ?
it is called each time user delete items (as clear cache pictures function is called after deleting a picture) ?


Probably the image is a sparse file.


helm-ff-file is unknow here, you will have to require helm-files just for one face.


WTF?


> Thanks, I'll make those changes.
I wonder about the std::endl though, I use the same formatting as before, but wouldn't it be more logical to use "\n" here and only flush at the end of the stringstream?

Since the help window is created once, it should make no difference. Thus, you can do as you see fit.


to make nullptr possible


- [x] @mentions, #refs, [links](), **formatting**, and <del>tags</del> supported
- [x] list syntax required (any unordered or ordered list supported)
- [x] this is a complete item
- [ ] this is an incomplete item


No, I think it's safer to call `super` here. Less duplicated code.
I don't think a lot will change here anytime soon (maybe with Source 2), but currently packets should be treated roughly the same.


> Since the help window is created once, it should make no difference. Thus, you can do as you see fit.

Good to know, thanks. I'll leave it as it is then.


@enoch85 Looks good :+1:


This face should be different from helm-ff-directory


Only by a api call right now: `your-ip/api/device/device/setContactTo?contact=true`


FYI, slight bug here I think... Omnisharp roslyn will return 0 errors when it checks an editor if it's all good, but that doesn't mean you won't have errors in other parts of the app (or other open editors).


I hope this will be changed when you are more or less done with it. I've got the ```dev``` tool approach to have all barclamps in the barclamps folder without the ```barclamp-``` prefix :)


Same you have to require helm-files only for this, thus expect circular require when compiling.


I wonder if this function can be inlined and used as just:

    return addChildAt(child, numChildren);


Yes, the check seems to be misplaced. Wonder how did it get there.


A regression, dired-directory face is ugly.


You are right. Sorry for confusion.


understood @shinnn :)

I'm going to do a whole bunch of manual testing on windows to see how it goes down - I have to say that my initial reaction to chokidar is a MASSIVE improvement over Gaze in terms of reliable watching/events etc

Also Gaze > 6.0 is even less stable?

The main motivation however, is this list of bugs https://github.com/gulpjs/gulp/issues/651

My thinking is that should they both be buggy in certain ways, we should experiment to find the least buggy across all platforms and go with it.


should be `?=`


Well, that should work for now. I want to use it to check if someone is home:

if absent for 15 minutes then set contact to closed

and labeled closed to 'No'


I already told you that I don't want to change the size.


(float)(extrudemultiply[extruder])/100.0;


It's a bit of a mess, I'll see to convert it to ocf_rarun.


use jndi-name instead of context
you can keep context and use it to lookup on the corresponding context


But it will be consistent and compatible with majority of themes out there. Do many people use default Emacs theme? And if they use the default one, I think they should have no problem with Dired face.


Ok I will fixed it.


/Addons/Strat_Mode/functions/SM_Map_Setup.sqf

It is using the  "cti_town_fneigh" variable stored in the town object.


r=glennw


Opps wrong comment sorry. I will change `helm-ff-dotted-directory` to something else.


Do we use the wrapper when publishing?


Alright, but the box is ok?


Not at NZZ. But our test apps do for example and I would leave this option open.


I'm using timeline based animations and it is quite common that I call addChildAt multiple times per frame per object (as it's in classic Flash), so I still consider each "sugar" unnecessary - especially in cases where I don't see any real bonus.

But my version is quite different from your already, because I didn't wanted to add Sprite3D as I will never use it in current project.


The `metadata` section is mainly instructing the field extractor. I think we should separate this completely from the metadata.

And I think changes in the field extraction should not require migrations or re-publishings.


saw approval from glennw
at https://github.com/nnethercote/servo/commit/52447ccd9b1889b21d5a5c8057a72e98a5ee96ea


merging nnethercote/servo/profile-crate = 52447ccd into auto


nnethercote/servo/profile-crate = 52447ccd merged ok, testing candidate = d1268ec9


Good to know, thanks for your research. :)

> On the other hand it looks like we could drop the "name" argument from the .scheme file, as it's redundant with the name defined in the .font file (and if they are not in sync the game won't start).

Hmm, I would just check whether no 0.8.x cegui version does need it though, just in case.


I agree on both. Didn't I write this :smile: I have to write clearer I guess.


I get an error:

```
"success": false,
  "message": "device hasn't that action"
```

command: ```user:password@localhost/api/device/thuis/setContactTo?contact=true```


Thanks for sending this along.
I won't integrate it though. The reason is that intermediate options list is used to process options from different sources: config file and command line. Combine them, and only then call mg_set_option(). Setting e.g. "listening_ports" multiple times can lead to side-effects.


You wrote in the forum...
> My best guess it that there is small gap when a permanent is created before all its fields such as subtypes are initialized via an update. The UI happens to try and read some of these fields before the update.

The UI takes a snapshot of the game state in the in [``UpdateGameView()``](https://github.com/magarena/magarena/blob/master/src/magic/ui/SwingGameController.java#L505). On the next line it then proceeds to fire the update on the EDT which (kind of) reads this copy to update the display. However, it uses ``invokeLater`` which means the game loop thread can continue on its merry way so there might be some synchronization issues. Changing the [``invokeLater``](https://github.com/magarena/magarena/blob/master/src/magic/ui/SwingGameController.java#L507) to an ``invokeAndWait`` might resolve things.


Ups: `your-ip/api/device/device/changeContactTo?contact=true`


There might be a need to backport 67ed8d1287c6dc9d7786a74e7b2c7735c4cce970 and either pull 0.3.7 or do 0.3.8 immediately, I'm not sure...


r+


+1 for reverting this change.


When I introduced the short_text, I tried it without specifyong short texts and had no segfault. Did it really segfault or is it precautionary there as well?


Why are you import this lib


0.3.7 hasn't been officially released yet.  Is this critical enough for us to retag, rebuild binaries and then release?


I incline to think that the metadata configuration should be specified on the space. Since as you say it represents the requirements of API consumers of a space.


i would create separate task for copying of settings.json. example rather than doing this always


> Hmm, I would just check whether no 0.8.x cegui version does need it though, just in case.

It seems indeed to be inconsistently used in the documentation. Here for cegui 0.7.x in the Font formatting wiki page [1]:
```
 <?xml version="1.0" ?>
 <GUIScheme Name="VanillaSkin">
  <Imageset Filename="Vanilla.imageset" />
  <Font Filename="Arial-10.font" />
  <Font Filename="Arial-Bold-10.font" />
  <Font Filename="Arial-Italic-10.font" />
  <Font Filename="Arial-BoldItalic-10.font" />
  <Font Filename="Arial-14.font" />
  <LookNFeel Filename="Vanilla.looknfeel" />
```

And here in the wiki page about schemes [2]:
> Attributes:
- name - The name of the Font Required.
- filename - Filename of the Font file. If the font created by this file does not = Name above, an exception is thrown. Required.
- resourceGroup - The resource group identifier to pass to the resource provider when loading the file. Optional.

So I guess it's safer to just keep the name, it's doesn't hurt anyway :)

[1] http://cegui.org.uk/wiki/Formatting_Tags_in_CEGUI#Font_Formatting
[2] http://cegui.org.uk/wiki/Scheme_files#Font


Non c'est moi. En gros j'ai remarqué que si je laisse le false tout court dans la création de ma chaine il est pas rajouté et du coup ça me pose problème dans la récupération au niveau du js.


LGTM!


Luckily I have not been affected by that change yet, but in my opinion, the vendor folder should be untouched. I see it as a read only package directory.

Taylor, I love laravel and you have made so many smart decisions, but please listen to your community on this one.


I think it should be per publication (publication as in NZZ or watson or a blog etc.). Unfortunately, I am not yet sure what exactly a space is... Maybe it's that, maybe not.


je vois. ça me rassure ue ce soit toi qui ait fait la modif.


As politely as I can put it, you are a bit darned swamped!

I'd really encourage you to think about #207. A lot of people value this project - I'm sure a large number would be very supportive and be able to help you delegate the administrivia to them, while still providing guidance/direction/being the benevolent dictator for life.
That, and you can extract beer from my co-workers in Brisbane if you happen to go to any of the rails meetups there!


The reported issue is not related to UpdateGameView. From the stack trace on the forum, the crash was triggered by a repaint of the UI. This is triggered by Swing itself outside of our control, it then enters into ImageCardListViewer.paintComponent, some of the cards has */* pt which requires checking the permanents on the battlefield to determine.


```
x = 0
x = 2 + 2
what is x
```


Regarding reducing numChildren call, it's questionable. You would have to count also the condition, which is in "addChildAt" even in cases, where it's called directly.


Have you cheched that this works?
When i added cli support there was an issue with changing working directory.
faf-tool bin file expect cwd to be in faf-tool npm module,
while tasks like setup etc. require cwd to be in users folder.

thus i did grunt.file.setBase(asset('.')); in faf-tool bin,
then in grunt tasks i did cwd to users folder right before task is being executed.
Because it did not worked for me in other way...


+100 for the explanatory comments


What do you mean by "functional dependency"?


``DBKeys``


Found the issue just need to find a reliable wifi connection.
On Mar 23, 2015 10:56 PM, "Software Engineer" <notifications@github.com>
wrote:

> compile error ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ProjectSkyfire/SkyFire.548/commit/b926b3f44c0122bca03852f2ccfec3c6628f4889#commitcomment-10359266>
> .
>


I think we can leave it as invokeLater since we need to be able to handle the Swing generate repaint events anyway.


If we're going to extend this functionality, maybe it's a better idea to move this to a separate class? That would make testing possible, or at least easier.
What do you think?


I think metadata changes should always lead to the documents being checked for conformity with the new metadata definitions. We need to make sure thate all the published documents conform with the specification. But it is a bit hard to say since we have not finished our metadata concepts.


What do you mean?


Yeh, that's why laravel 5 ditched Boris.


Cross-referencing https://github.com/JuliaLang/ZMQ.jl/issues/76 - I don't like deleting a tag that's been public in the history for ~12 hours, I'd rather just supersede it with a new one and go straight to 0.3.8. A very short march, potentially.


If these changes are going to be made, they should at least be logged in a CHANGELOG.md file. I think it's good to know what's going into each minor version (and every other version) in one centralised place so we don't have to trawl through commits.

Personally though, I don't think a "composer update" and minor version bump should be breaking _any_ applications unless absolutely necessary (e.g. emergency security fix). Personally I can live with it, if only that CHANGELOG.md file was there to give a heads-up!


If you don't pass in the filename on the request to /codecheck, you'll get
errors for the entire solution.
On 24 Mar 2015 09:08, "Chad T" <notifications@github.com> wrote:

> FYI, slight bug here I think... Omnisharp roslyn will return 0 errors when
> it checks an editor if it's all good, but that doesn't mean you won't have
> errors in other parts of the app (or other open editors).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OmniSharp/omnisharp-atom/commit/895ebc3f0b57dcb7f71041f8423cb1aaf8f8a1e4#commitcomment-10362197>
> .
>


#5 部分解决


I would call this metadata and the other ones fieldData.


Yes, I write this in a later ticket recommendation. With "equivalent to the one from the design" I mean that metadata is not subject to data migrations. It's a different concept.


I would call this 'Livingdocs Publication Data'


Obsidian and Pinewood stairs removed although I cannot add charcoal to the coal group as they both have different burn times in a furnace (charcoal being less) so would technically be cheating when crafting items that need coal...


> i.e, only concerns frontends

By this you mean re-publishing all the documents?


ResultsSchema (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1672 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


@FernetMenta need call DownloadLibass from deps. I'll change the guide as:
```
 2. Call DownloadLibass.bat in win32\deps\ to download source code of libass from https://github.com/libass/libass
3. Call DownloadBuildDeps.bat in win32\deps\ to download following dependecies: fontconfig, freetype, harfbuzz, libfribidi, libiconv
...
7. Run package.bat in win32\package\ to produce the final archive
```
what's the problem? I have test it many time (just dobule click it in windows explorer), it works for me. DownloadLibass remove dir libass in base dir, and recreate it. down load source zip then extract and copy files in libass folder.


Seems legit !


One last thing. Could you add Given, When, Then comments to the tests?


Unless the verdict on 67ed8d1 is that the fix is extremely critical, I think the plan of continuing to release dcf61ab33784d454b8c9515786077ab11ee63d11 as 0.3.7 is best.  We can either recommend users that encounter 67ed8d1 to use a nightly/custom build of 0.3 (which seems the most likely since we've been living with this leak on both 0.3 and 0.4 for quite a while now) or we can immediately release 0.3.8.

I've got binaries up for 0.3.7 now, so we should be ready for formal release announcement when you wake up.  I'm going to let you do the honors of announcing on the mailing list since you all but single-handedly did the backporting and pushing out of binaries for this one.  The binaries are in place, a [pull request](https://github.com/JuliaLang/julialang.github.com/pull/220) is ready for the website, and you know the formula for the announcement email.  :)


Could be. But as you said before we don't really have a concept for this yet.


Yeah but this triggers whenever we get any response (whether all errors, or just for a specific file).

There's a bigger discussion to be had on whether to just defer to the atom-linter plugin (which I've already built, for that it's worth :+1: ).


This allows to write type unsafe code like:

```
JsonObject obj = new JsonObject();
obj.put("foo", 4);
Map<String, String> map = obj.getMap();
String b = map.get("foo"); // ClassCastException
```


So we don't care about floating point precision?


good!


oguz faruk tarafından ilk düzenleme


ok


@vu3rdd What is `-optc-Os` ?


I think a better solution is to introduce CardViewerInfo object as a snapshot of MagicCard, similar to how PermanentViewerInfo object is a snapshot of MagicPermanent. This way the UI does not have a reference to a game object, only a read-only info of the data it needs to render.


Merged duplicates in 85bef15c0f243df7e2aecbf389ab110e2b1d0631.


Aferin kardeş , hızlısın.


can't we just do `else if` instead of `else { if` ? Seems more inline with our practices?


True! Combining it into one line won't change performance, but it's cleaner. Plus, I can exchange "numChildren" with "mChildren.length".

→ eed8696f9f699af3008f

Thx!


ne demek canım :)


Also, am I right in thinking these changes were made primarily to support the release of Envoyer? Just going off @taylorotwell's comment "Trust me, it's not fitting in storage if you are trying to deploy without
downtime."


tugce demirtas


done


Aman tanrım didim


True but in the old code you could also write type unsafe code:

    JsonObject obj = new JsonObject();
    obj.put("foo", 4);
    Map<String, Object> map = obj.getMap();
    String b = (String)map.get("foo"); // ClassCastException

So, I'm not sure it's really any worse ;)


bi susun :D


Çok yakışıklı çıkmışsın apo kardeş :)


Merhaba ben Fadime :)


selam


It does, but that's just a styling issue I'd say.


ooo beyler :dancer: :dancers: hadi kopalım :D


a.s


hi :D


変換できます。
修正します。


@BlueHayes that's exactly what I was thinking myself. Seems like it as a rushed decision to get a product out rather than something that was absolutely necessary for the time being.


himm


mesengera çevirdiniz burayı :D  @abdullahTR


hey ben basak


appoooooo @abdullahTR


zaaaa @abdullahTR


uwwwDA:SDAS:D


sadas


asdas


retretertt


sadasd


dfsadfa


hmm... I don't like very much the format `__className_methodName` ...
We use underscore as a prefix for private functions.
Underscore used by local prefix is fine but this new format is public/global and in this  case the prefix means the wider availibility. (I know that you use two underscores, but this is the same situation from my point of view.)

I suggest to use a dedicated name instead of underscore prefix. The name should refer why we doing this: there is something behind the scenes which prevent us to use the original name.

One suggestion:
rename the original function to `log_msg_get_value_optimized(...)` and call this function just `log_msg_get_value(...)`

other:
don't touch original function (less modifications required) and try to use a better name for the new function.


ewrewrewr


werwe


ewrewr


xvfsdgvsx


sdfsdf


dsfsdf


sdfsdfs


hüloğğğğğğğğğğğğğğğğğğğ


sdfsdfsd


companion patch: facchinm/YunBridge@bc12bb21


asdafsfdsafsafsaf :dancer:


Yes, I've got one more condition, but spare one method call (numChildren). And the method call is definitely much more expensive than the condition.

As for Sprite3D: did you test the performance impact? I took great care to make the effect on pure 2D code as minimal as possible. That said: yes, there sure is some code that needs to be executed that hadn't been previously.


System.out.println("Java");


Play()と同時に再生時間を設定すれば済むことですね。
修正します。