I think that even though the form as a whole could become valid while editing a field _other than_ postal code, the UX here is fine. In that case, the keyboard action will advance from field to field until postal code and then will trigger this listener. That works for me.

However, the flag `requirePostCode` may be false in which case there is no postal code field at all. The "symmetric" thing to do would be to use `mCVVEditText` (and then also return a boolean from `onCVVEditEntryComplete()`, etc.) And it would be nice to have a unit test for that.


In the git hub split diff, this must be the weirdest diff I've ever seen. It decided to keep the word "create?"


No space after (


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1045
success: http://build.servo.org/builders/linux2/builds/1045
success: http://build.servo.org/builders/android/builds/1079
success: http://build.servo.org/builders/mac1/builds/1261
success: http://build.servo.org/builders/mac2/builds/1261
success: http://build.servo.org/builders/gonk/builds/232


Awesome work @vsingleton !


Remove space after (


Space before {


Adding the hex signifier seems to break Ubuntu 14.04

```
$ sudo apt-key adv --keyserver hkp://keys.gnupg.net:80 --recv 0x1C4CBDCDCD2EFD2A
Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.4cjEqrpVyQ --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver hkp://keys.gnupg.net:80 --recv 0x1C4CBDCDCD2EFD2A
gpg: requesting key CD2EFD2A from hkp server keys.gnupg.net
gpgkeys: key 1C4CBDCDCD2EFD2A not found on keyserver
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
vagrant@fe01:~$ sudo apt-key adv --keyserver hkp://keys.gnupg.net:80 --recv 1C4CBDCDCD2EFD2A
Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.3OJpZFi9xa --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver hkp://keys.gnupg.net:80 --recv 1C4CBDCDCD2EFD2A
gpg: requesting key CD2EFD2A from hkp server keys.gnupg.net
gpg: key CD2EFD2A: public key "Percona MySQL Development Team <mysql-dev@percona.com>" imported
gpg: Total number processed: 1
gpg:               imported: 1
```


Space after and brfore -


Removes spaces or tab after ;


I know what I'm going to say won't be related to this plugin, but for iManager the command was to be /gamemodelist, not /gamemode. My mistake on that, and this is deleted on purpose.


This modification can cause the `WC_Cart::get_cart_from_session()` to be called multiple times unnecessarily. For example, `WC_Cart::calculate_totals()` calls `WC_Cart::get_cart()`. The method loads the cart, which is now loaded, regardless of `wp_loaded`. `WC_Cart::calculate_totals()` then calls `WC_Cart::get_cart()` a second time, causing the cart to be loaded from the session again.

Apart from the performance implications, and the fact that the error message would appear multiple times, `WC_Cart::get_cart_from_sessions()` triggers several actions and filters, which would run multiple times as well.

Furthermore, any plugin that might need to get the cart in a `woocommerce_cart_loaded_from_session` hook would trigger an infinite recursion. For example:
1. `WC_Cart::get_cart()`
2. `WC_Cart::get_cart_from_session()`
3. `do_action('woocommerce_cart_loaded_from_session', $this)`
4. Plugin action:
~~~
function woocommerce_cart_loaded_from_session($cart) {
  $items = $cart->get_cart(); // This is a legitimate call, but it will trigger an infinite loop from step #1
}
~~~

I saw that happening a couple of times already.

Possible fix
--
A fix could be the following (off the top of my head):
~~~
public function get_cart() {
  if ( ! did_action( 'wp_loaded' ) && !$this->cart_loaded_from_session ) {
    $this->get_cart_from_session();
    $this->cart_loaded_from_session = true;
    _doing_it_wrong( __FUNCTION__, __( 'Get cart should not be called before the wp_loaded action.', 'woocommerce' ), '2.3' );
  }
  return array_filter( (array) $this->cart_contents );
}
~~~


GridViewBugFixes (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Space after optionValues:


The license file needs to end after 9.8 section ends. The entire thing including and after needs to be removed. (you can refer strong-arc)
"Parts of this software are (c) 2012 Dmitri Melikyan. The original license"


Nothing in the README describes what `turn` does, or uses it in an example.

From the description of README, it seems like cycle should be given at least one positional argument (that isn't `hz`) - (`cycle` cycles between 1 or more values?)


@Matrooskin Shouldn't this be `ORDER BY id DESC` to get 2nd page of latest events?


Good point.

Another reason for reverting was the underlying issue of these commits was fixed by https://github.com/Komodo/KomodoIDE/commit/14ce81747fc9e05b3f201ad352c4b9d5d93b3ddf


fast-forwarding master to auto = 4dc5287b


68304232-1e)-Move-parent-object-sizing-calcs-to-a-common-routine (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1660 of 1667 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Please, remove line 1 and 2.


zxombie wrote:
```
Is configured there to check when its_get_devid is set? If so it may happen out of order.
This could be an issue depending on when this function was expected to be called, e.g.
if we are scheduling on multiple cores.
```

Is that not what critical section is for? To prevent rescheduling/migrating to another CPU of the current thread?


Sensacional


Please, revert the 2 deleted lines 6 and 7.


Excellent!


```
strcmp   	2098.03,	 compare to std::strcmp: 100%
pr_strcmp	1842.49,	 compare to std::strcmp: 87%
c_strcmp 	11554,	 compare to std::strcmp: 550%
```
Вот так гораздо реальней выглядит, чем на паре, когда в 1000 раз быстрее оказалось. В чем тогда был баг?


Makes sense, thanks!


Neat, thanks for fixing this :)


А, всё, прочитал комметарий.


saw approval from jdm
at https://github.com/bjwbell/servo/commit/a3fac7c0fe822ec6c601307ff15820b2ea7828ad


merging bjwbell/servo/osx-set_cursor = a3fac7c0 into auto


bjwbell/servo/osx-set_cursor = a3fac7c0 merged ok, testing candidate = 477f8d22


This is not a valid commit


This does not really “fix” JENKINS-4409 since https://github.com/jenkinsci/jenkins/commit/c4e5fbdbc9c644f1afcae031b3b4638ad5297238 already did that.


This should have been tagged BroadleafCommerce/QA#419


of course you can it's a kernel bro ,from here https://github.com/flar2/m7-Sense ,I didn't cherry-pick I just updated the files manually.


Well if you agree, there's another `switch` that could be an `if` here :wink:


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.35](http://teamcity.monogame.net/viewLog.html?buildId=5765&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@iggy could you update the pillar example with the new defaults that it should look like
if you want to overwrite the package naming in defaults/map

```jinja
salt:

  # to overwrite map.jinja salt packages
  lookup:
    salt_master: 'salt-master'
    salt_minion: 'salt-minion'
    salt_syndic: 'salt-syndic'
    salt_cloud: 'salt-cloud'
    salt_ssh: 'salt-ssh'
```
instead of:
```jinja
salt:

  # to overwrite map.jinja salt packages
  lookup:
    salt-master: 'salt-master'
    salt-minion: 'salt-minion'
    salt-syndic: 'salt-syndic'
    salt-cloud: 'salt-cloud'
    salt-ssh: 'salt-ssh'
```


Done in 535018f.


It got lost in the amount of trafic I recive there. I recovered it now and will take a look shortly.


Sounds about right. Naming variables something that's easy to reference simply by reading the name of the variable is the typical thing to do. This is to avoid confusion.


lgtm on first look. Not tested it.


In rST you normally needs a symbols line at least as long as the title line.


There's a problem if I send a PR with this "display: 'block'" in the CSS file instead of inline styling? Or it must be that way?


My intention wasn't really for you to add them to the animals array directly, but I like the initiative. :+1:

What I was getting at is the method name of fetch_CD_animals would imply, to me anyway, that it was looking for animals whos species name *starts* with the letters C or D, and as such should be written to account for the array having more than two animals with species names that start with C or D. Your previous method would only find instances of cat or dog, but would fail if we were also trying to pull out other animals such as a canary or dingo.

However, see my inline comment for a new problem you've introduced....


Are you sure the comparisons are right?


Hey Soren,
sorry but i cannot reproduce the problem. Yes, the recordselector requests the backend theme configuration from the configBuilder. But this is only used in the backend where the backend theme ist included via ext_tables(L64)->Configuration/TypoScript/Backend/Setup.txt

Did I miss something? Where does the error occur?

Cheers, Daniel


This works, but you've already used the select enumerable earlier in this file, and the rules for the challenge state you're to only use an enumerable method type once.

**Hint:** You were on the right track with your previous version....


that is awesome


It looks like you've used tabs instead of spaces in lines 154,155,157. OTherwise I like the change - thanks for finding & fixing it :+1:
Could you fix these thabs before I merge it?


CBECC (kbenne) - i386-Windows-7-VisualStudio-12: OK (2143 of 2157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.35%25-yellow.svg)


forgot to fix the type here ;-)


hehehe, cool


Wow! Must have been hard to spot :)


And he probably got from someone else :-)


This looks like the path to danger. Wouldn't a more future-proof means of passing this type of option be an optional options object?

A side-benefit is that this would allow massaging the variable arguments so that a simple `isObject` test could be used.

```
Class.create("MyVertex", "V", { abstract: true }); // Clear what intent is
Class.create("MyVertex", "V", undefined, true); // Not clear without consulting documentation on specific arguments
```


82706250-AdaptiveConvectionNew (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1661 of 1662 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Should setting the ExplicitPath.  We want failures if the file is missing.


Thanks a lot, I will carry on advertising with this flyer now and we just refine as needed. Cheers


I :heart: open source!


ExplicitPath.


For now at least, we seem to be standardizing on getting our Json names out of `jss` across most of the source code.


To much blank lines.


No, this is different order than method getLastRows. I think if you use parameter from-id, then we need return all records from this id and newer, not older.


:heart:


Totally. I only saw it after stepping in the debugger while parsing a file that was completely broken after merging #151


2oufa in the following files :
website/app/views/devise/confirmations/new.html.erb 3 lines
 website/app/views/devise/passwords/edit.html.erb
website/app/views/devise/passwords/new.html.erb
 website/app/views/devise/registrations/edit.html.erb
website/app/views/devise/registrations/new.html.erb
website/app/views/devise/sessions/new.html.erb
 website/app/views/devise/shared/_links.html.erb
website/app/views/devise/unlocks/new.html.erb
 website/db/migrate/20150318165538_add_devise_to_students.rb
website/db/schema.rb
website/config/locales/devise.en.yml

please leave 3 lines of space between each block of related code instead of 1 line of space


I think it would make sense to prevent 1 redirection/func call here because future will be on hot path for every async app...


Same here


For, can u give me some information that help me to add its JOIN


They have never been in Contao 3.


Not the author, but it seems to be a correction of da39f7677c5b2935ca8c5c39778897278ec7e462


超迅速！


ShadeOption (rpg777) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.57%25-red.svg)


@DBezemer,

Thank you very much for the pull. Just a few notes:
0. we are using the server Apache SSL template so no need for that file anymore, please remove from pull, I will also remove it for 10.7.0.
1. where we do not use colors, no need to add -e to echo, while it is not really that important, I'd rather we make as little unneeded changes as possible.
2. read -e is important when inputting a path but otherwise, not needed, as it is used for tab completion. Please remove.
3. for the db-config script, you removed:
-read -s MINUS2_PASSWD
and changed to:
+read -e MINUS2_PASSWD
This is not good as -s means we do not echo the passwd, please make sure this does not appear in other input sensitive places.
4. 'Please resolve the issue and re-run the installer' string change, I am fine with it apart from the use of 'installer' it is important that the user knows he can run this part only if he needed to.
5. I see you replaced one echo call passing \n with an echo call for each line, why? it works fine the way it is, did you find a place where it is a problem?


Please dont commit empty files


CBECC (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2140 of 2157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.21%25-yellow.svg)


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.35](http://teamcity.monogame.net/viewLog.html?buildId=5765&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:14:39


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.36](http://teamcity.monogame.net/viewLog.html?buildId=5767&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


F2FS is the future, I'd use Dori 10.0 if I had stock but I use a lollipop ROM. F2FS though!


Looks OK to me.  Go ahead and merge.


No worries. So was I, until I noticed that changing these methods could lead to a lot of time spent compiling.


A dp solution inspired from that of Petr's.


While you're in here, can you collapse the copies?


@lukecampbell Actually a 'variable' is the same things as a 'category', and we will have listeners for those if we don't already.  I'm not sure how you want them to overlap.  So we can stew on this a while.


now we need someone who is motivated to test+report questbugs in that area :)


For library modules the AndroidManifest.xml is at `build/intermediates/bundles/<flavor/type>` and not at `build/intermediates/manifests/full/<flavor/type>`


I'd prefer to adhere to the same pattern used throughout the project & everywhere else has `src` included. I'm game for removing `src` throughout though as long as it doesn't break the Js side of things.

Let's discuss offline, but either way I think this is out of scope for this PR.


> It's a French thing I guess.

Indeed. Found this on a coffee package this morning:

![space-question](https://cloud.githubusercontent.com/assets/134455/6717811/8431c924-cd85-11e4-8b49-653e12405e1c.jpg)

:-)


Sorry, I didn't realize someone had overwritten you translations.

I have an automated process that regenerates the .pot files, pushes them up to Transifiex, and then pulls down the latest translations. But I believe I can exclude pt_PT from that automated if you'd prefer to work through GitHub.

Unfortunately this latest version went out today, but I can push up a follow up soon with fixes. Let me open a new ticket.


Looks good.


Yeah, gpsim's about to get a lot better too.  I implemented python based
mib slaves so you can just write a python function and tag it in your
unit test and it will create a simulated MIB slave at whatever address
you want that forwards packets received to that function and returns its
response at a simulated i2c stimulus.  I'm using it to test the
asynchronous MIB stuff.  Next step would be to do the same with a mib
master module.

On 3/18/15 12:08 PM, Austin McGee wrote:
> I think both is probably good, but it will be nice to have an official
> safety mechanism to ensure we don’t blow things up.  I might be able
> to only have Travis run the longer test when it’s a tagged release
> (before publishing to pymomo) but I also think if we pre-build the
> patched gpsim a <10minute build time won’t be much of a bottleneck.
>  I’ll implement this today.
>
>
> —
> Sent from Mailbox
>
> On Wed, Mar 18, 2015 at 8:46 AM, Tim Burke <notifications@github.com>
> wrote:
>
> > I'm fine with that if you think its the way to go. A more lightweight
> > alternative would be to just ask each other if we've run build all
> > before opening the PR.
> > On 3/18/15 12:59 AM, Austin McGee wrote:
> >> We could add a step to the pymomo CI that pulls the latest
> >> MoMo-Firmware Dev and runs the full build. This will significantly
> >> bloat the Travis build time (and might take some work for AppVeyor)
> >> but would ensure that we don't break things. I think it's an OK
> >> tradeoff for now, and hopefully we can move to a container-based build
> >> system that caches build dependencies like xc8 and gpsim at some point.
> >>
> >>
> >>
> >> —
> >> Sent from Mailbox
> >>
> >> On Tue, Mar 17, 2015 at 8:30 PM, Tim Burke <notifications@github.com>
> >> wrote:
> >>
> >> > Just saw and commented on the other PR that you opened.
> >> > ---
> >> > Reply to this email directly or view it on GitHub:
> >> >
> >>
> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10251283
>
> >>
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >>
> <https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10253256>.
> >>
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10266960
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10271540>.
>


It's already on the internet. Nothing you can do now ;)


With that change we don't need `input_start_stdin()` further down.


(P.S. I checked the English version on the opposite side of the package: no space.)


Ari, you have a lot of great work here. We need to talk about your commit sizes. If this were broken up into pieces then we can implement parts of it. Now it will be all or nothing. It doesn't have to be that way
I cherry-picked a commit from Reuvain's branch and I'd like to cherry-pick parts of this...


Sweet!!

—
Sent from Mailbox

On Wed, Mar 18, 2015 at 12:43 PM, Tim Burke <notifications@github.com>
wrote:

> Yeah, gpsim's about to get a lot better too.  I implemented python based
> mib slaves so you can just write a python function and tag it in your
> unit test and it will create a simulated MIB slave at whatever address
> you want that forwards packets received to that function and returns its
> response at a simulated i2c stimulus.  I'm using it to test the
> asynchronous MIB stuff.  Next step would be to do the same with a mib
> master module.
> On 3/18/15 12:08 PM, Austin McGee wrote:
>> I think both is probably good, but it will be nice to have an official
>> safety mechanism to ensure we don’t blow things up.  I might be able
>> to only have Travis run the longer test when it’s a tagged release
>> (before publishing to pymomo) but I also think if we pre-build the
>> patched gpsim a <10minute build time won’t be much of a bottleneck.
>>  I’ll implement this today.
>>
>>
>> —
>> Sent from Mailbox
>>
>> On Wed, Mar 18, 2015 at 8:46 AM, Tim Burke <notifications@github.com>
>> wrote:
>>
>> > I'm fine with that if you think its the way to go. A more lightweight
>> > alternative would be to just ask each other if we've run build all
>> > before opening the PR.
>> > On 3/18/15 12:59 AM, Austin McGee wrote:
>> >> We could add a step to the pymomo CI that pulls the latest
>> >> MoMo-Firmware Dev and runs the full build. This will significantly
>> >> bloat the Travis build time (and might take some work for AppVeyor)
>> >> but would ensure that we don't break things. I think it's an OK
>> >> tradeoff for now, and hopefully we can move to a container-based build
>> >> system that caches build dependencies like xc8 and gpsim at some point.
>> >>
>> >>
>> >>
>> >> —
>> >> Sent from Mailbox
>> >>
>> >> On Tue, Mar 17, 2015 at 8:30 PM, Tim Burke <notifications@github.com>
>> >> wrote:
>> >>
>> >> > Just saw and commented on the other PR that you opened.
>> >> > ---
>> >> > Reply to this email directly or view it on GitHub:
>> >> >
>> >>
>> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10251283
>>
>> >>
>> >>
>> >> —
>> >> Reply to this email directly or view it on GitHub
>> >>
>> <https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10253256>.
>> >>
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >
>> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10266960
>>
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10271540>.
>>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/WellDone/pymomo/commit/9c7e1cf75b3ae4e3f765b81c1205e5f32d93377f#commitcomment-10272142


Why don't we need this anymore?


Missing `git_config_entry_free(ce);` before the `return 0` on the lines above?


Very nice! Thanks again


@pythonesque was correct here, I think. By not calling the handler when the json was invalid, we, technically, made a breaking change to the API.


This should be private if we are forcing them to use the factory method


@jesca, @sdsingh, for the record, can you describe how we could switch this to a database query for performance reasons later?


по 9 тесту в html  только сm,  по 6 тесту неясно с namespace и валидацией


ShadeOption (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


You can use tee to keep stdout for debug and /data/my_app_log.log for history.
I personnaly love both of the methods


These get removed later, in https://github.com/kegluneq/angular/commit/f18ec7280331bb5c1945bf64f703e3eed86d79b9, sorry, probably should have merged those in here.


Yes, checking cache size can be used instead. Can you make corresponding changes?
Pull requests is not time saver, it is place where future changes can be constructed, discussed and tested before they are merged into master. Without pull requests we will always have controversial changes in the master which can be discussed only afterwards.


Missed one:
* Update reports spec with additional reports


Also removed in https://github.com/kegluneq/angular/commit/f18ec7280331bb5c1945bf64f703e3eed86d79b9.


ack


I'm curious what the benefit of moving this code into the `reset!` body is?


Actual test fix is this change; I changed this class name `netsim_lobby` => `netsim-lobby` yesterday, and failed to update the UI tests.  This occurrence affects all the netsim tests, and there's one other instance of this change in netsim_lobby.feature.  The rest of the changes are getting consistent with this naming style, at least for the classes that the tests refer to.


LGTM


It's moved inside the `let` that defines `queue-options`.


Sweet.


@nuen
You can move the variable definition inside the request function because it is only used inside that function.


@FilipDev "In need of a better name"


1.2.0 ?


If this is the error function, the console log message should indicate an error happened.


-1 (3 divs para centralizar uma imagem)

Usa a tag footer como container, assim consegue diminuir esse número.


Looks good overall!


Great idea Joshua Marston!


r=bjz


Love this change. I would change `should be left empty` to `may be omitted` however as we don't need empty tags.


Cool! Only comment would be the poly count looks a little high. Could all the little rectangles and Autopilot lettering be done with texture instead?

Honestly I had been hoping the block would have an interface that looked like your old school autopilot screenshot http://upload.wikimedia.org/wikipedia/commons/2/26/Autopilot_System.JPG, this is cool too. : )


The comments should also change from \`file_receive\` to \`file_recv\`


@wedaly you won't need the {platform} name in the SR text.  That is provided by the alt in the img that precedes it.  ```${_(Home Page)``` will be fine.


ack


Fixed.


we should delete all of the comments since we don't need them anymore.


you don't have it with spaces after commas, do you?


here too


@spboyer ok thanks.


Those darn save and open pages


In the [latest commit](https://github.com/vholland/schemaorg/commit/19ea29e1ba71e75af1e3da8b163a913e11cce997), I changed securityScreeningType to use text. @chaals is correct that an enumeration probably won't work.

I also added the new properties to the examples.txt in the same commit.


I will add cache size check in the next version.

You are absolutely correct about the whole idea of pull requests, but sometimes we just have to make things quick and 'dirty' to check whether bug is fixed or not. Things that change logic or introduce new features should go via pull requests. Even bugfixes should go this way but not when they are rather urgent.

That's why I made a new eblob version with just a bunch of debug changes - it has to be quickly applied to system to help finding a bug.


In an ideal world we are discussing idea first and then implement it in one run, that's why trello exists.


There's a comment that says that `django_nose` has to come after south for good test-fu, but this clearly breaks that.


What's this for?


And this charter is now approved and in-force. It shouldn't change further :)


oops STREeT should be STREET. Not sure if it's cap sensitive.


r+


@carrickr
You can use `#at_xpath` instead so that you don't have to deal with array access:
```ruby
expect(x.at_xpath("//html/body/publicobject").attr("id")).to eq(@item.id)
```


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.36](http://teamcity.monogame.net/viewLog.html?buildId=5767&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:15:58


@interpotential Emogrifier throws other exceptions, like [this](https://github.com/woothemes/woocommerce/blob/master/includes/libraries/class-emogrifier.php#L182) -- since the code where Emogrifier is used doesn't expect exceptions to be thrown, it's best just to catch them and log them for later review.


they removed `.get_absolute_url()` from the Abstract User model. This hacks around it.


Ah woops! I'll make that change.


Glad you caught that ;)


This patch could probably be merged with the last one, right?  I think this was just around because you were testing with the pwpolicy command in pykickstart early on.


initial commit for README.md


May be it is better to make such quick changes / investigation in separate branch or locally?


see also http://stackoverflow.com/questions/25734384/accessing-user-get-absolute-url-in-django-1-7


oh right! I was expecting tests to blow up and I would deal with it but they didnt. I guess I should remove that comment?


@jesca, what is "cur"?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.37](http://teamcity.monogame.net/viewLog.html?buildId=5770&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Hey @haihappen , I'm still trying to figure out what is going on (I have a hard time believing what I did is correct because there should be a lot of other people hitting the same issue).

From what I can tell thus far, the problem is that the ```.delete(deleted)```  is deleting based on ```_id```, which in my case everything is ```nil```, so it deletes everything.  Basically as soon as the max_versions is exceeded everything gets toasted.

One thing I was trying to figure out why there are three ways to remove things from the versions:
.delete() # revise no paranoid
.delete_one() # revise paranoid
versions.shift # revise!

I'll see if I can come up with something actionable / reproducible.   I'm guessing my code has an issue in that if saves are batched (or versioning temporarily disabled) that it won't get back to max_versions.

Thanks for following up.


XD! I have been meaning to do essentially the exact same thing in my fork!

That's pretty hilarious. If you want to work on a unified fork together just let me know!


Hi, Allison
I am newbie in shell and Exiftool. I want to ask you something. How do you compile and build all of those script? What are you using to compile and build them?
Thank you

Regards,
Intan


error


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (639 of 639 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.22%25-green.svg)


Thanks for your comments. I will squash this commit into that one.


@slashman Yeah sure, I can do that...


@eclarizio I was suggesting to completely drop `describe "#reason"`. Looks like you prefer to have a describe.

```ruby
it { expect(request.reason).to eq(reason) }
```

In your example, does the `"sets a"` actually buy you anything?
```ruby
  it { expect(the_thing.a).to eq("a") }
  it { expect(the_thing.b).to eq("b") }
```


2/2
Good work!


The reports app is broken in this release.


Oops, meant to only push to my personal repository. Sorry


We intended this to go to julian's fork, but it seems we got something wrong in sourcetree.  I'm more of a tortoise user :( .  If there are problems with this code we can back it out tomorrow.


2/2
Good job!


I would think I would want it protected (Principle of least privilege) ,
but when I try to declare the property in the implementation file it throws
errors.  I've installed screen hero onto the macbook so I can show you
tomorrow.

On Tue, Mar 17, 2015 at 8:12 PM, laurenhasson <notifications@github.com>
wrote:

> Yes, here you want to remember the array - properties are a great way to
> "hold onto" variables for a certain class. You can declare properties in
> the @interface <https://github.com/interface> in both the header and in
> the @interface <https://github.com/interface> in the implementation file.
> What do you think is the best option here? Do you want other classes to be
> able to access the property or do you want to protect it?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cobyw/ios-exercises/commit/462b75b797ae1b9bebbb71494efe3d870775d76b#commitcomment-10250145>
> .
>


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.16](http://teamcity.monogame.net/viewLog.html?buildId=5725&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I had noted that in the commit text.  That parameter is ignored by the flashing code and the size hardcoded to 1k instead.  If it actually used that parameter then you wouldn't have needed to provide this workaround.


`settings.ssl.rejectUnauthorized || true` works for `undefined` or `null` but is really stupid when you think of it in context of folks who want rejectUnauthorized explicitly to `false` ... they will be unable to make it do so!


Hm. I thougth user can`t start spring without having it installed. Besides joining battle without such vital component as engine is not so obvious situation because springlobby shows user is in sync and all is ok. So user can (and looks like he does) think this is a bug.


just lower case `capacity[len(capacity)-1:]` and then you don't need double case  statements.


Should this line have been removed from `recipes/openwebrtc-gst-plugins-static.recipe` too?


@stevemessick, @lukechurch, this commit is on a new `comid` branch. @lukechurch, can you push this branch to an appengine version? Thanks!


:+1: for the clarification!


With the release of the picking up of YT views automatically on a weekly basis, I think we can add that to the explanation don't you think?


rax retry tests


Looks like I mispelled canola oil.


If you don't have to expose these variables, set them "static".


A lot of extra get requests here. If this was for debugging try using the console on the "webpage" when you get an error.


You can add images I believe: ![Alt text](/path/to/img.jpg)


2/2
Good work!


That would create a sentence fragment. You'd need to add an "it" after "then". I'm not sure how the net result is any better.


Also, please make the commit messages more informative than just update :-)


.idea 폴더는 git에 안 올라가도록 하는게 좋을것 같습니다.


Tested this commit. works well.


You should mention the reason why the limit is `36`.


2/2
Looks good!


Why not `atoi`?


Thanks, I did find that A Better Camera works, but hadn't considered the old JB gallery app.  I wonder if anyone has it fully working with the Camera2 app.  The quest continues...


What's the rationale for this re-export?  I don't know why one would typically need the `Default` class; and we export `with` that can be used instead of `def`.  I ask particularly because this breaks some code in the website (`def` clashes with another `def` defined in `System.Console.CmdArgs`).


Opcode is not sended by the client when reached AreaTrigger... maybe a phase issue?


Huzzah! It boots but I'm still getting the same errors as my oneliner from https://github.com/bluerider/liveroot/pull/1

FSCK fails because the partition is already mounted even when fsck is before oroot in the mkinitcpio hooks.
systemd-machine-id-commit.service fails because I have no clue.


I suppose it is useful when making functions that take records of optional arguments, in diagrams style...


Good source - comment test


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.16](http://teamcity.monogame.net/viewLog.html?buildId=5725&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 452, ignored: 6 Build time: 00:14:23


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.17](http://teamcity.monogame.net/viewLog.html?buildId=5727&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


seems like update_object issue


There's no issue if system-machine-id-commit.service fails. See : http://man7.org/linux/man-pages/man8/systemd-machine-id-commit.service.8.html

Regarding the fsck error, can I get the exact error? It might be trying to fsck the overlay...which wouldn't work.


line 580 is same of 557 ?


Commit comment:
"space it consumed" => "space is consumed"
"This ensure's" => "This ensures"

Looks good to me. For what it's worth:

Reivew-by: Chris Dunlop <chris@onthe.net.au>


@Myoldmopar basically yeah.  But I'm really just horsing around and seeing if anyone is paying attention.


Gold start for noticing!

:star:


Acked-by: FengYang


/play greatjob


This works but is very inefficient, will circle back to improve it.


Need a condition here that can determine if a relatedRecord has been loaded or not.


Thanks for this fix, it sounds like the right thing to do. Is it possible to make a testcase for the new behavior so that the fix doesn't get lost?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.17](http://teamcity.monogame.net/viewLog.html?buildId=5727&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 452, ignored: 6 Build time: 00:15:12


will disabling => will disable


when at arc_meta_limit is reached => when arc_meta_limit is reached


79453838-AutomateSomeDocumentation (Myoldmopar) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.24%25-red.svg)


I don't know why, It will crush when items is right clicked.
(ROX-Filer:31885): GLib-CRITICAL **: g_strsplit: assertion 'string != NULL' failed


This appears to have broken the build system, was there a reason it was removed?


1) Docking station position parametrized - allows to use maps with arbitrary docking station position.
2) Circle detection sensitivity increased - allows to dock in adverse lighting conditions.
3) Initial stages of docking do not check if the robot behaves as expected anymore (this was included to verify if other nodes still send commands to the robot or if the robot was moving when charging was initiated) - improves interaction with higher navigation layers that seemed to activate the charging while the robot was still moving.


Awesome!
Yeah I can't find anything in the logs about fsck. I was able to grab some videos of the screen to slow the output down. lol. Basically oroot is running which does its business and mounts root. Then fsck tries to run on the partition at /dev/<root> but it can't be mounted to run the check. it's not completely imperative since it still runs when not using oroot and we aren't writing to it when we use oroot. Thanks for all the work!


Thanks for the mention! But FWIW racket-mode just uses Emacs' `newline-and-indent`, which does the space cleanup:

```cl
(defun newline-and-indent ()
  ;; ...
  (delete-horizontal-space t)
  (newline)
  (indent-according-to-mode))
```

I know this because I'm silly not smart: I had written my own version of this, and accepted a patch to zap the whitespace ... before eventually discovering I'd reinvented the wheel. Now I just use the original wheel. :)

All that aside, this is a nice improvement for Dr Racket! I enable `show-trailing-whitespace` to help me catch that in my own code. However that shows it in other code, too; and it shows a lot. :)  IOW it will be nice for DrR now to gently help folks with this.


Lesson one - Step1


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (2180 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.32%25-yellow.svg)


Signed-off-by: Xian Chaobo <xianchaobo@huawei.com>


Use `attr_writer` to define trivial writer methods.


my nginx.conf setting for log:
 log_format  access  '$remote_addr - $remote_user [$time_local] "$request" '
             '$status $body_bytes_sent "$http_referer" '
             '"$http_user_agent" $http_x_forwarded_for';

this is default setting , I never change it.

here is some example of logfile:
220.181.108.184 - - [15/Mar/2015:16:02:20 +0800] "GET /?/m/question/518951 HTTP/1.1" 200 4334 "-" "Mozilla/5.0 (compatible; Baiduspider/2.0; +http://www.baidu.com/search/spider.html)" -
220.181.108.108 - - [15/Mar/2015:16:02:20 +0800] "GET /question/433932 HTTP/1.1" 200 7999 "-" "Mozilla/5.0 (compatible; Baiduspider/2.0; +http://www.baidu.com/search/spider.html)" -
5.255.253.124 - - [15/Mar/2015:16:02:21 +0800] "GET /?/m/answer/3219301 HTTP/1.1" 200 1673 "-" "Mozilla/5.0 (compatible; YandexBot/3.0; +http://yandex.com/bots)" -

123.157.70.118 - - [15/Mar/2015:16:01:53 +0800] "POST /source/plugin/zywx/rpc/portal.php?jsoncallback=?&mod=tuangou HTTP/1.1" 200 784 "-" "" -
123.157.70.118 - - [15/Mar/2015:16:01:55 +0800] "GET /source/plugin/zywx/rpc/home.php?jsoncallback=?&mod=misc&ac=user_setting HTTP/1.1" 200 229 "-" "" -
140.207.54.80 - - [15/Mar/2015:16:01:56 +0800] "POST /weixin/api/?signature=17917f58c82cfa5a1b5e8b34b1218e934148d7b0&timestamp=1426406515&nonce=817137958 HTTP/1.0" 200 545 "-" "Mozilla/4.0" -
123.125.71.18 - - [15/Mar/2015:16:01:56 +0800] "GET /question/147033 HTTP/1.1" 200 8158 "-" "Mozilla/5.0 (compatible; Baiduspider/2.0; +http://www.baidu.com/search/spider.html)" -
117.136.45.188 - - [15/Mar/2015:16:01:56 +0800] "POST /source/plugin/zywx/rpc/portal.php?jsoncallback=?&mod=tuangou&act=pass&page=1 HTTP/1.1" 200 1535 "-" "" -
5.255.253.124 - - [15/Mar/2015:16:01:56 +0800] "GET /?/m/answer/3523550 HTTP/1.1" 200 1688 "-" "Mozilla/5.0 (compatible; YandexBot/3.0; +http://yandex.com/bots)" -


Nope, in sniffs all areatriggers reached has always HasAreatrigger false and I don't think that is a parser issue.


Adding a build directory


nah nah nah on garde le #


Doesn't compile. I can't run it.


Can you fix this?


Commit comment:

"would iterate over all ZFS super block" => "would iterate over all ZFS super blocks"
"this design have worked" => "this design has worked"
"desgined" => "designed"
"equivilant" => "equivalent"
"functionalilty" => "functionality"

Sorry, only a bit of proof reading as, whilst the goal and the code look good to me, it's beyond my current ability to do a knowledgeable review.


Thank @maxsnew ! He's the one that fixed it (and convinced me to get over my hesitations as DrRacket doesn't behave the way it used to when I (frequently...) do "return, up arrow, type" I now do "return, up arrow, type, tab").

(Also I find it easier and more useful to compare to the default behavior racket-mode than some moderately obscure keybinding)


Le routing est interne à angular, so client side. Ça marchera pas ça.


Hi!

lol


Can you add a new line? <3


Acheiving => Achieving


I assume that `process_messages` is the main loop that each worker needs to call. To make it "impossible" to not call `process_messages`, consider the following:
- There is a command line flag, known to Base, that specifies that the current process is starting a new worker
- This command line flag accepts an option (probably a file name) that specifies a particular function that is called
- This function needs to initialize the custom transport mechanism, and then returns the `AsyncStream` object

Probably there needs to be an equivalent function that Base needs to call down to shut down the custom transport mechanism. E.g. for MPI, this would wrap `MPI_Init` and `MPI_Finalize`. Or maybe this finalization should be registered, in the initialization routine, as a finalizer.

This is probably what @JeffBezanson is looking for. I don't see much benefit of this approach -- writing a custom transport mechanism is a fairly special task, so that calling back into a routine in Base to handle the event loop seems fine.


Lisez la doc pour commencer: https://docs.angularjs.org/guide/$location
Et regarder le bon commit 66602e86d57843fb65e66f2b54358d51c61b4830


iteration (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.43%25-red.svg)


if i can't change the nginx.conf ,how can i run analog?can you give an example code in python?thanks your greate job!


@pgrenaud ça n'a pas d'allure de devoir changer la config nginx à chaque nouvelle route ajouté.
Honnêtement, je trouve que ça n'apporte que très peu de valeur :I


being exceeded.  Then request => being exceeded then request


Commit comment:

"Acheiving" => "Achieving"


TeamCity Helios :: Helios.DedicatedThreadPool :: PRs [Build 3](http://petabridge-ci.cloudapp.net/viewLog.html?buildId=280&buildTypeId=Helios_HeliosDedicatedThreadPool_PRs&guest=1) outcome was **FAILURE**
Summary: Building D:\BuildAgent\work\612e9541afb322c2\src\Helios.DedicatedThreadPool.sln failed with exitcode 1. Build time: 00:00:33


This actually creates a security hole, since I could update any user by just passing in their ID.


Good thinking with `default: Time.now`, except unfortunately it doesn't work that way in practice.  As you can see in your seeds, all your `last_sign_in_at` attributes default to `2015-03-15 00:15:07`


This needs to go at the top of the loop since the stream enters a non-good state before entering the loop (after processing the first line of input).


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-55.84%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-12.44%25-red.svg)


Good thinking.  I'll show you a slightly different way tomorrow, but I like how you figured this out.


import java.util.Scanner;

public class GuessNumber {
public static void main(String[] args) {

Scanner keyboard = new Scanner(System.in);

int guess;
int secretNumber;
for (int round = 1; round < 4; round++) {
System.out.print("Enter a guess: ");
secretNumber = (int) (Math.random() * 10 + 0);
guess = keyboard.nextInt();
System.out.println("Your guess is " + guess);

if (guess < secretNumber){
System.out.println("Your guess is smaller than the secret number." +secretNumber);
}
else if (guess > secretNumber)
System.out.println("Your guess is greater than the secret number." +secretNumber);

else if (guess == secretNumber){
System.out.println("Your guess is correct. Congratulations!" +secretNumber);
}

}

System.out.println("Bye");

}
}


Since you've got these in your ApplicationController you don't need to add them in the other controllers -- they're available everywhere.


seems like you misspelled "canola"!


- Do not enable rectangle control by default on example page.
- Properly align declaration of ```enableRectangleControl``` local variable.
- the ```enableRectangleControl``` should initially be set to ```options.enableRectangleControl || false```
- The ```enableRectangleControl``` should be set to true if the input region exists and is valid.


Hmm. Odd. I'm seeing this on the npm page:

> mholt published an hour ago
> 0.4.2 is the latest of 6 releases

Did I miss something? I'm not very good at package stuff.


If they didn't blow up, +1 for removing the lies!


+1 for removing the lies!


will there still be a input.m.o/robots.txt?


Funky! I didn't know that.


@zacatac 's code. I believe it's the pointer to the current trip in the iterator


Wagtails -> Wagtail's


it's -> its


1. Was the change to canned comments intended?
2. Why not just keep gff3_config.xml in the folder, no need for the default_gff3_config.xml rule then


Thanks for the pull request. The only thing I noticed thats wrong is the logging call. If you make any log calls, please use the LogUtil class as it checks the type of build (debug/production) to decide whether to log or not.


Yes! It's handled by completely different code here:

* https://github.com/mozilla/fjord/blob/master/fjord/base/urls.py#L14
* https://github.com/mozilla/fjord/blob/master/fjord/base/views.py#L75

The code we're removing here is from the funfactory days.


Fixed! Thank you!


@jesca, I am pretty sure that this will fail if there are only two entries in the array.


I have also updated the documentation.


Hmm... try setting cache-control and pragma to private...


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1046
success: http://build.servo.org/builders/linux2/builds/1046
success: http://build.servo.org/builders/android/builds/1080
success: http://build.servo.org/builders/mac1/builds/1262
success: http://build.servo.org/builders/mac2/builds/1262
success: http://build.servo.org/builders/gonk/builds/233


recv is just short for receive so I left the comments like that on purpose.


Should this be `Block[]`?


There is only one building system which pushes packages into repository


@sfcgeorge here are the tests for [this change](https://github.com/egonSchiele/contracts.ruby/pull/111#discussion-diff-26543041). Without that change, `nil` and `""` both get `to_s` called on them. `nil.to_s == ""`.


(seems copied from `PagesHashStrategy` but appears wrong there too)


@shankari this was fixed in a later version of this https://github.com/jimmydief/e-mission-server/commit/ad5fd212ba19d985c6303b00fb19497ee369a1d1


Honestly I just started learning Blender yesterday and I still don't know how to effectively add textures to models.  As far as creating textures, everything points towards Photo Shop, which I don't have, so I'm not sure how I'm going to do it. I do know that I want the little rectangles to look like http://static.guim.co.uk/sys-images/Technology/Pix/pictures/2009/4/3/1238779856797/HAL-9000-001.jpg and then ball shape to look like this https://encrypted-tbn1.gstatic.com/images?q=tbn:ANd9GcTxn_CcR84SSr_O-7uYNS2k9NINenFJU_DpXwQ4TN5wyneHFByq


Thanks for catching this. I'll tweak the code so it falls back to the library location.


ugh.... ok.


@shankari, @zacatac and i have discussed this yesterday, we can check whether the queryFilter type, whether it is a tuple or a database query. If it's a tuple, proceed with the function call, if it's a database query, do the database query function call


fast-forwarding master to auto = 477f8d22


For 1, yes, I will fix that.
For 2, the issue is that if we customize the gff3_config.xml it now has the potential to be source-controlled, which is probably not what we want.


+1, migrations are once again quiet.

Thanks for jumping on it.


Yes, let's discuss it tomorrow.

Le 18/03/2015 20:35, Daniel RUBANGO a écrit :
>
> For, can u give me some information that help me to add its JOIN
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/QuanticDrone/mad-doctor/commit/71733685dc43dc938529027db2af78af2009d0d2#commitcomment-10272015>.
>


Yeah but when @zacatac wrote his code, we were querying the database directly, so self.cur was the current location of the cursor. You changed the code to be a list of trips instead, so there is no cursor any more, right?

I actually thought that the functions in query_modules would return a query instead of a list of trips, i.e. {['$and': [{'alternatives_complete': True}, {'in_training': False}]} for the utility query in which case the original query based mechanism would still work.


Seems to me "if only scriptSigs are different" should be coded something like:
```
CMutableTransaction tx1 = *this;
CMutableTransaction tx2 = tx;
for (int i = 0; i < tx1.vin.size(); i++) tx1.vin[i].scriptSig = CScript();
for (int i = 0; i < tx2.vin.size(); i++) tx2.vin[i].scriptSig = CScript();
return tx1 == tx2;
```

Also, a unit test or two for IsEquivalentTo would be good.


ok


Can you please push with valid author and email settings?


i can see it


Weirdly, my backticked word .gitattribute wasn't saved in the commit message.

Update `.gitattribute` so that linguist reads ADR as JS


saw approval from jdm
at https://github.com/Adenilson/servo/commit/814283321db6f4c7d95d7fd880159412573759cc


merging Adenilson/servo/displayListGeom01 = 81428332 into auto


Adenilson/servo/displayListGeom01 = 81428332 merged ok, testing candidate = a5217556


@lamagnifica LGTM


there are several "*_xhr.json" endpoints.


90447068-BalancedExhaust-Issue4711 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1150 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.64%25-green.svg)


you are changing the input to something else, so your solution may not return the correct answer for the given input..


I like this. Good work @nikolai-b


spacing..


I see. I would have thought that isDeclarationStart would return true if it is an decorator or a declaration without a decorator. You could call it twice, once before parsing the decorator and once after. And if you don't have a valid declaration afterward, you can just parse that as a missing node.


BY the way i am thinking we probably have the same problem with the catalog -- when this one is defined globally-- because we will first look for a per-tenant catalog (which will invoke cache logics)-- and then return default one if that exists.

Other than that :+1:


90119792FourPipeInd_ErrMsg (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1659 of 1661 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.37](http://teamcity.monogame.net/viewLog.html?buildId=5770&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:14:03


90447068-BalancedExhaust-Issue4711 (jasondegraw) - x86_64-MacOS-10.9-clang: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I would try again without this require statement. This doesn't add up. If it's in the gemspec, it should be required automatically.


You should still be able to use `main`, `xlab`, and `col` via the `...`. We don't need to include them as primary arguments.

The `plot_pheno_sub` function is a trick for having hidden defaults for those arguments but still be able to take them from the `...`.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1151 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/plugins/export/ExportPdf.class.php


Yes, and this system shouldn't build and push incomplete packages with controversial changes.


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/plugins/export/PMA_ExportPdf.class.php


Is there any reason for only setting the timeout if sqlite3_open_v2 is available?


:+1: Good move


Not that I know how, but high poly models can be mapped to lower ones. Space Engineers supports level of detail models, as well.

I know the basics of adding a texture, but I am clueless when it comes to (un)wrapping U.V.s. I did the radar in GIMP but it is just a purple square.


I think I'd need to see the grammar productions. Specifically, where/how do you decide if you will parse a computed property or an element access?


Why is this needed? I don't get it :)


This may cause you headache in our version of this. We removed this validation so we actually _could_ have assemblies as parts.


Right, and I left it because I didn't really want to go to the trouble of doing an edit on the commit to remove it.


@ametaireau Actually there is no reason to have this small cache backend adapter in the cliquet.cache module. It could be here in authentication, no one uses it, and it does not much


dodaj:
 $this->assertTrue($client->getResponse()->isSuccessful());
przy każdym, żeby sprawdzić czy nie ma błędów (każdy wyjątek rzuci kod 500)


"posting helper virus"? Ha, what's that?


Okay


@tie-rack Oh, I see. :+1:


This is covered by a test case - so I'll just have to remove that test case. I didn't realize it was expected behavior to have assemblies as parts


Могу я узнать, какая ошибка вылетает?
У меня работает всё хорошо, пока даже не имею идей на этот счёт. По ошибке в гугле полазаю, поищу причины и возможные их решения.


The parser doesn't usually do refinement, it does lookahead instead.


It does say that `explicit relative imports` are acceptable.
In any case, I had already updated this to be absolute.


@CyrusNajmabadi is this correct?


I feel like that had coverage against it at one point to allow an assembly to be a part. It may be in our app, though.


To clarify, this commit fixes the saving of the audio source by moving the ```timeupdate``` event handler so that ```$('#audioSource')``` will be properly selected.  Previously, ```timeupdate``` was in the main body of ```app.js```, where the ```$('#audioSource')``` selector was returning an empty selection because the element doesn't actually exist until book.html is loaded.


@CurlyMoo
Sorry my bad forgot to change settings in github for mac


We can set the default to "YAWIK" here


Why not isConstructorWithBody? And then getFirstConstructorWithBody can use where/filter instead of forEach


Wait, I read your message now


Merge pull request #3 from su79eu7k/master


Well then you should remove the backticks (which suggest that's something that is character-for-character correct, which it no longer is)


>>>>> "Arran" == Arran Cudbard-Bell <notifications@github.com> writes:

    Arran>    Is there any reason for only setting the timeout if
    Arran> sqlite3_open_v2 is available?

I didn't bother to look to see when busywait was introduced.
I was being conservative; if that function has been around for ever then
sure.
https://www.sqlite.org/c3ref/busy_timeout.html
doesn't indicate when it was introduced.


ack


@pedrogaudencio, where does this definition comes from? I am not sure if any proceedings is a book.


Please tell me more why you need this alignment before the name. Does the ESP8266 processor give a bus error when reading bytes unaligned? It does seem a bit odd.
I'm afraid this patch is not backwards compatible, all users upgrading would need to reformat their filesystem. I will of course fix it somehow, perhaps by a define in spiffs_config.h or something. Again, please inform me of the nature of the problem a bit more.
Thanks for contributing!


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2102 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.76%25-yellow.svg)


On my system I found that `_get_lib_version()` fails and throws an exception due to the `_checkNegative` failing.  But `iio_library_get_version()` returns void, so why is any error check being performed?

Also, what is the `archtypes` member for?  Should this be `argtypes` or did I miss something in the ctypes documentation?


saw approval from Vagabond
at https://github.com/helium/plumtree/commit/771c6b1c40f94e163c683cf79b526d6db460bb7c


merging helium/plumtree/ts-test = 771c6b1c into he1000-integration-4-ts-test


helium/plumtree/ts-test = 771c6b1c merged ok, testing candidate = 1dae850b


По center-wrapper (просто заметка):
Обычно в хедере все блоки строятся как-бы слоями (элементы хедера).
Я обычно пишу так:
```
.page-header> .page-header__layer1{.center-wrapper}+.page-header__layer2{.center-wrapper}

```
И например когда у Навигации один цвет(или отсутпы), а у контента другой можно легко задать цвет(или отсутпы)


The placement of 'only' is ambiguous here (between 'only on class members' and 'only on ES5'). I would rephrase it to something like:

"Decorators on class members are only available when targeting ... "


Here's an example of this being done in the Opaque Keys library: https://github.com/edx/opaque-keys/blob/master/opaque_keys/__init__.py#L248


Using org's standard key prefix to ensure that global DBs don't get deleted.


Этот блок думаю будет уместнее в app-download
Хорошо видно на больших экранах


"A decorator cannot be used on this declaration type."

Also, is there a way to avoid using the word "type" here?


this change breaks 'anyFrontendUser'. if 'currentFrontentUser' but 'frontendUser' is not, the method returns FALSE


If we're looking for a key prefix, the filename won't start with it. Hence, ```contains```, as opposed to ```startsWith```.


Looks like you misspelled canola


Кстати, а вот ситуация такая:
* крон работает раз в */10 минут
* в течении менее чем 10 минут на трекер добавляются 2 серии подряд
* TM вытягивает обе
* в RSS мы видим одну, последнюю серию, тк в базе обновило и при формировании ленты ничего не знает про предыдущую серию

Я понимаю что ситуация 1 из 1000, но все же :)


Lined up the test creds to be use standard key prefixes. Unfortunately, I don't know what the standard is for communities, but it doesn't affect our tests in any way, since we don't use it.


format *


New test for delete all DBs - the user DBs should get deleted, but the global ones should remain.


The arguments to an ambient decorator must be constant expressions.

or

Only constant expressions can be used as arguments for an ambient decorator


This version of the defaults was from my initial pass at it, the last patch has a newer version.

As for a rationale for the setting, I think that would be a pointless exercise given how personally people seem to take the whole 'set a password' thing.


A decorator


hasLineBreakBetween


So, believe it or not, try/catch does have a performance affect in this case. We can minimize it by moving the try/catch so that it is around the loop, rather than inside the loop. We should still be able to catch the data needed to create the error message. Would you mind making that update?


*and


Ack, I'll fix it too.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Thanks for this! :)


I think a more forward-compatible to do this would look more like:

```python
    if uninstaller_type in ['AdobeCCPUninstaller']:
        # uninstaller_item_location is required
        if not 'uninstaller_item_location' in pkginfo:
           errors.append(
               "WARNING: file %s is missing uninstaller_item_location"
               % filepath[len(pkgsinfopath)+1:])
           # Skip this pkginfo unless we're running with force flag
           if not options.force:
               exit_code = -1
               continue

    # other uninstall types (now and in the future) may specify
    # uninstaller_item_location
    # if an uninstaller_item_location is specified, sanity-check it
    if 'uninstaller_item_location' in pkginfo:
        # Try to form a path and fail if the
        # uninstaller_item_location is not a valid type
        try:
            uninstalleritempath = os.path.join(
               repopath, "pkgs", pkginfo['uninstaller_item_location'])
        except TypeError:
           errors.append("WARNING: invalid uninstaller_item_location "
                         "in info file %s"
                         % filepath[len(pkgsinfopath)+1:])
           exit_code = -1
           continue

    # Check if the uninstaller item actually exists
    if not os.path.exists(uninstalleritempath):
        errors.append("WARNING: Info file %s refers to "
                      "missing uninstaller item: %s" %
                      (filepath[len(pkgsinfopath)+1:],
                       pkginfo['uninstaller_item_location']))
        # Skip this pkginfo unless we're running with force flag
        if not options.force:
            exit_code = -1
            continue
```


all tests pass:
success: http://buildbot.helium.io:8010/builders/test-plumtree-build-debian-7-64/builds/22


Shouldn't there be an + 2 on the first parameter, or is it supposed to be - 2?


Если поместить внутрь слоган, то видно что можно не создавать отдельный .col-left
.col-left можно вынести в миксин и примешивать у нужным блокам


You are absolutely right, I keep on forgetting to do smaller commits.


This will definitely work for long. The other primitive integers are handled correctly, because unifiedPrimitiveEquals uses isValidX, and those are implemented for Rational. So LGTM.


Why not use SignatureDeclaration from types.ts?


Fixed in f3dfc21.


fast-forwarding master to he1000-integration-4-ts-test = 1dae850b


hide counters within the round theme


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/130c63691ee8721d28a6c56f5bb3cb0bb93e76ef/app.js)


saw approval from Vagabond
at https://github.com/helium/plumtree/commit/3554bd35a6e523d904f69584e9db99f58a6df5f1


merging helium/plumtree/ts-license = 3554bd35 into he1000-integration-5-ts-license


helium/plumtree/ts-license = 3554bd35 merged ok, testing candidate = 67e5f9dc


@xKilt I have ported UltimaXNA to github at https://www.github.com/ZaneDubya/UltimaXNA. The linked repository has all the latest changes. I suggest you fork from there. Let me know if I can help!


I changed this because "rake db:seed" command is more conventional


h1 на странице может быть толкьо один.
Лушче задать общий h1 и отделить блоки br
Или спаны внутрь поместить


Why did you write this code?


We actually use URI.parse in many places (including onebox) - should all those be updated too?


Think of it as a square. If you want to add to the "range" of that square 2 you would -2 -2 the lower bounds and +2 +2 the upper bounds.  That way it's actually adding 4 to the LENGTH of the square but 2 to the effective checking range.


should fix that and in other files too


Это обусуждали


I am not sure what else needs to be included. My changes will prevent the crash.


@TreefortreesofDOOM what were you trying to do here? This took out the space between the name and Welcome..

```Thanks, MarkWelcome to Beacons.```


А этот блок зачем?


@aleos89 thanks for your hard work :+1:


Construct the service with two parameters


I made this change because information on env.sh is can be different from user to user. They don't want to add the change as a commit.


@cydh thanks for your hard work :+1:


How about `if (end !== undefined)`


cite внутри p, так как строчный элемент


RamereWimberly


Could you provide examples?  I'm hoping that these guidelines can be used beyond the doc team to help get better docs everywhere.


Nope, still not working. That's the only call to `durably_decorate` in the entire gem


the modification from __construct(Repository\User $userRepository) to __construct(ServiceRegisterOptions $options) propably breaks our unittests.
Add an additional Parameter for injecting the MailService (instead of using an array)


Is this still necessary after #54?


Note that this returns a decimal where 1.0 corresponds to 100%


spelling - decelerating


Ramere Wimberly


Or you can do `node.end = end !== undefined ? end : scanner.getStartPos()`


I am a nice comment


@joecohens at this point I've reconciled everything from your pull requests except loading a different layout based on category.


`<Identifier>createNode(kind, pos)`. Then you don't have to cast it in the next line


Actually, we already have createMissingNode. Can you just use that?


@jzawadzki Dzięki za info, jak zapewne widzisz, to zostało wygenerowane automatycznie. Szczerze mówiąc, nie przyglądałem się jeszcze temu. :smile:


@binarybottle - you would want the word object inside there. (not necessary for python 3, but needed for python 2.
so:

```
class DKTprotocol(object):
    ...
```


Mellow Bites Master


o gio falou que é melhor getPlugin do que plugin


Если cite будет внутри, остальной текст можно обернуть в спан с классом no-mobile


Sorki, miało być Task List w commicie. Za dużo kodowania..


@cmbirk Awesome! The category thing should be implemented differently on this repo, we needed that to cover a milestone for today. So we are on track. /cc @rodowi


Unrelated to this issue, but currently this is required to run embedded SingleNode tests in the module projects.


Добавь пусто th, если посмотришь то видно что есть в начале один пусто блок.


self.systemMountpoint needs to be checked for None before calling .startswith on it.


all tests pass:
success: http://buildbot.helium.io:8010/builders/test-plumtree-build-debian-7-64/builds/25


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.38](http://teamcity.monogame.net/viewLog.html?buildId=5773&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Thanks for the feedback, I will restore the parent constructor (it will be empty so calling it or not calling it will not do anything).


Weird, I never saw this message in the output and debugger did not break here when I debugged the test.


Про галочки говорили.
А на первый блок повесь класс tariffs__row-header


o método `View::getPlugin` não existe, isso ali foi um erro :smile:


fast-forwarding master to he1000-integration-5-ts-license = 67e5f9dc


Il y a une raison à la suppression de ce block de code ?


No need for dist_man_MANS, only man_MANS. The dist part is handled by EXTRA_DIST.


The Mail FROM Name has to be an option


I would be very surprised if this is a bug, because there we aren't doing
anything.
I certainly got an NRE error on a test there, and that was the root cause.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Tue, Mar 17, 2015 at 7:21 PM, Federico Andres Lois <
notifications@github.com> wrote:

> And we are positive that this was the cause? Because it doesnt make sense,
> unless we are hitting a runtime and/or jit bug. Another that I am thinking
> is what happens if the thread gets preempted while doing the lookup. Then a
> modify could hit while a search is happening. Nasty issue in there if that
> is possible (which won't be solved either way by that change, maybe we are
> just masking it).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ayende/ravendb/commit/a97436551e51eb2da38e1efff37e5b7afdc38fb6#commitcomment-10242093>
> .
>


Why is this true? We could be here if the page builder is full.


Sorry, I mean unnecessary files :(


The Mail Subject has to be an option. Default /*translate*/ 'Registration'


thx for your work :+1:


I agree, that allows the code in levelup to be potentially reused.
btw @juliangruber what version of level-codec does this depend on? I do not see a `Codec` class in level-codec https://github.com/Level/codec ?


Thanks yesterday I pushed from my terminal but probably put my computer to sleep to early or something and I just noticed it didn't get pushed :blush:


Inline this


Ты так и не ответил зачем подключаешь в каждом файле переменные


Could you add a class docstring with an overview of what the class does?


:+1: Thanks @sibartlett


invokes the destructor for each object before freeing the memory allocated for the array.


@aheile this is the code we can just copy paste on every hands on section that we have


Actually Q1/2


В buttons добавь hover


@FrankRuns, I would suggest inspecting the values in `fi` to make sure they are what you think they are. A simple `print` statement (or function, if on Python3) will work. Or, if you're familiar with iPython you can set a breakpoint.

```python
Python 2.7.9 (default, Dec 15 2014, 10:01:34)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> vals = range(10)
>>> ivals = enumerate(vals)
>>> foo = [(i, val*2) for (i, val) in ivals if val]
>>> foo
[(1, 2), (2, 4), (3, 6), (4, 8), (5, 10), (6, 12), (7, 14), (8, 16), (9, 18)]
```


For builtin types you can combine the :param and :type docstrings:

:param str devspec: ...


Кстати да, будет такой косяк, но уж что то больно мне не хочется под RSS отдельную таблицу заводить


So I snuck some other stuff in here. :gun: me


Ok, but autoconf/automake does not complain. So we can go with this.


This class propably can be removed, if we add the MailService as an additional parameter to the Service/Register.php


fast-forwarding integration/timeseries to borshop-integration-1092-feature/riak_kv_quanta = f2b3188f


Про типографику я тебе писал


Разбей на отдельный блоки, отлаживать проще будет.


nanna


 - Add upper bounds --max-rtt and write it into the filename.
 - Some output to tell you it's busy writing PNGs.


Pew pew.


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (642 of 643 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.27%25-green.svg)


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1047
success: http://build.servo.org/builders/linux2/builds/1047
success: http://build.servo.org/builders/android/builds/1081
success: http://build.servo.org/builders/mac1/builds/1263
success: http://build.servo.org/builders/mac2/builds/1263
success: http://build.servo.org/builders/gonk/builds/234


Здесь длину можно не задавать до планшета, тогда все блоки будут автоматом занимать 100% длинны.


Может при парсинге RSS сначала загружать все данные во временную таблицу. После парсинга отсортировать ее в порядке возрастания по сезону, эпизоду, названию. Тогда эпизоды будут добавлены в правильной последовательности.
Ну или обходить элементы RSS ленты с конца, если есть такая возможность


Seul l'emblème "secure" est intégré à pidgin, les autres ne s'affichaient pas.
Les utilisateurs "lock" s'affichent déjà avec un icone différent, un avatar grisé et un label "Idle - Away", ce qui suffit à comprendre qu'ils sont inactifs.
Les emblems servent donc à savoir si un utilisateur est à epitech (et avec ce commit https://github.com/izissise/netsoul-purple/commit/7362ba3f18bc31a744771a63d3991ae5b347e75b, l'icone epitech est grisé quand un utilisateur est lock).


In the current code? I don't see any other.


Why default to debug?


история клиарфиксов указана здесь:
https://css-tricks.com/snippets/css/clear-fix/

тебе нужен последний.
(там нет before)


additionalSlinkyGHXWork (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1649 of 1661 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.28%25-yellow.svg)


Will we have to worry about this getting out of sync from the value in `listener.go`? Is there anywhere in comment we can use?


develop (macumber) - i386-Windows-7-VisualStudio-12: OK (2176 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13%25-yellow.svg)


Ales klar


ALres is ordnung


@kaz231 I restored it in 4e67c4010a8c :)


How do I do to include this in my Bower?


fast-forwarding master to auto = a5217556


Shouldn't that rather be "qmlRegisterType<StemSlash>       ("MuseScore", 1, 0, "StemSlash");"?


What if there's some other error with `os.Stat`? I guess we just fall through to `ioutil.ReadFile`, and catch the error there? (That's totally valid, just making sure that's the desired behaviour)


Okay, I understand now what you mean. The answer to my earlier question is that isStartOfMethodSignature decides which refinement to use. Our parser doesn't do much of this cover/refinement style parsing, it's more lookahead driven. But I don't really have a problem with this.

One thing though. If it's an ElementAccessExpression, don't you have to return only the left portion of it, so that you can refine the right portion to a computed property?


Finally. The wait is over. We can unflip the flips.


Good work


I don't think you need this token check. isStartOfMethodSignature does that for you


@zenangst you wanted to parse @"companies[0]" right? Maybe we should have support for that


' / . aws - config . json`


@killera FYI to speed things up the rest of the way I also had to remove the autowired annotations from these DAOs. (You had already started setting this property in the xml.)


The present commit possibly improves text readability but has nothing to do with the performance. Optimising compilers handle such repeated constructions correctly at the lowest non-zero (i.e. turned on) optimisation level. Actually, here in few chunks is created a construction which decreases performance of the optimised build.


Медиа можно писать внутри блока
И не прописывать каждый раз название блока.
```
.center-wrapper{
  @media(...){
      ....
   }
}

А мак и мин можно вынести в отдельную переменную. Тогда не нужно запоминать значения каждый раз.
У Громова был пример. Можешь пересмотреть лекции.


Shouldn't you only do this for colon?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.38](http://teamcity.monogame.net/viewLog.html?buildId=5773&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 460, ignored: 6 Build time: 00:13:59


I just had a question for @triplevia on this log_dir_mode at 770.  I'm not super familiar with Windows permissions, but why 770?  It seems like something on my test server wants it to be 750, I'm struggling to figure out what/why.  Every puppet run, either via the service or command prompt reports that the log dir has changed modes from 750 to 770.  Any ideas on that?  Thanks!


If I understand this correctly, if we fail to read the file, we'll happily create a buffer out of nothing, fail to decode it, log the error again, and not change `e`?  Again, checking the expected behaviour.  Though I would perhaps early-return in that case.


So every call to the systemMountpoint property is going to result in opening the /proc/mounts and hashing it. That's quite a bit of activity for a property to trigger.
I was going to complain and suggest using stat, but I see that's no help since the size is 0 and the timestamp for everything is now. Still, seems like there should be a better way -- or at the least change the property to a method call.


I think that when I change the |= to an &=, it wants EVERY tag in EVERY post to match, if that makes sense? I'm not really sure how to fix it.


Hmm ... This must be ported to VH conf file


:shipit:


Confirmed, all the tests fail w/o this because the config management explicitly sets this key in order to conform to the schema.


pass


some test mode


I'm not exactly clear on when this needs to be set to false. I see there are a bunch of places that it's done, but what is the commonality among them?


Random nit: I think "interface" is a word by itself, and hence the intercaps form is `TestInterface`, not `TestInterFace`.  (... maybe I should go look for real issues.)


LGTM. Thanks.


parseVariableStatementOrFunctionDeclarationWithModifiersOrDecorators


check `err != nil` instead of `os.IsNotExist()`, perhaps?


I don't think you need to add both interfaces.  I think this block should look like `pkg/namespace/etcd/etcd.go` (almost exactly), and don't use the generic apiserver interfaces.


I'm not happy with the name of this field. IMHO, "send_no_mail" implies a user does not want to get *any* mail, although the field's purpose is to disable sending the newsletter. Besides, I would have named it something positive like `wants_newsletter` (with a default value of `True`).


[Deployment available online](https://s.brightspace.com/apps/ipa/dev/2cd51f107cdea7b08f661efa91b32814b5202f65/app.js)


`test_path` here should probably be a not-currently-existing random path; otherwise this test could erroneously pass if that file already exists because somebody ran apptail or whatever.


Should be using a `defer` in case something panicks rather than returning nicely.


What's the reason that this component uses template strings instead of plain text?


Très bien, ça me va.
N'hésite pas à détailler ce genre de chose dans tes commits.

Je cherry-pick et je push, merci


Ooops.  Fixed it.

M a r k . D i N a t a l e
D i r e c t o r . o f . O p e r a t i o n s

Cell: 404 731 1557
Email: mark@thegoatfarm.info

On Wed, Mar 18, 2015 at 4:34 PM, Eric <notifications@github.com> wrote:

> @TreefortreesofDOOM <https://github.com/TreefortreesofDOOM> what were you
> trying to do here? This took out the space between the name and Welcome..
>
> Thanks, MarkWelcome to Beacons.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/thegoatfarm/beacons/commit/254648ab098bff788546fd8bc44df671c942610f#commitcomment-10273132>
> .
>


It took me a considerable amount of time staring at this before I understood what was going on. A comment here would be super helpful.


Failing to write doesn't fail the test?


argh, bummer, those imports are defined in common...


Technically (as in "the spec says"), they're allowed to give either the name or the code for the described type.  So might want to register both to be spec compliant.


@dotnet-bot test this please


really?

On Wed, Mar 18, 2015 at 10:03 PM, Marcin Konarski <notifications@github.com>
wrote:

> test1
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AmokHuginnsson/yaal/commit/06102d94ae1a2cecb987e8e1f324c2d4dd406ffa#commitcomment-10273750>
> .
>


Dead line?


Rename this method to `dirtyAttributeNames()`.


Awesome! But, just to be clear, `unifiedPrimitiveEquals` checks for `isValidX` for other types, but just not `Long`? :(


Why are you removing file headers?


this is totally awesome, when yo done with this card thingies just like it works with materialize, update the live demo so we can all use it..i have an app the heavily depends on this cards


No checking that no error occurs?
(Why is go letting you not check the return value? I'd expect syntax to force it, like `_ = storage.Write(bytes)`, instead...)


gotcha :)


What the point of removing `Flask-SQLAlchemy` dependency?


Можно задать длину в процентах, и поменять при переходе контрольной точки
Вместо col--right можно сделать новый блок, и в БГ ему задать нужную нам картинку и поставить в нужное место


bah, what silliness :smile: okay I'll throw that in


For any of the changes that involve std:: I suggest you open bugs in the Boost tracker.  They could/should be fixed in the original source.


.controls__item можно вложить внутрь


Surprised that there's no `log.Debugf()`, but since it doesn't, I guess this makes sense.


Футер дооформи


errata - esse é o bronze 5


I don't disagree with you :)  I've never seen it in practice - I mean, I've seen symbols instead of ulongs for DescribedTypes, but never for frames.


Move them to openedx!


This should have a comment at least saying that `t.mux` should be held when calling.  Too bad there doesn't seem to be anything to let us assert that this is the case.


Исправил


do not define new variables in the middle of the code.

indentation is wrong. use tabs


All of this seems like a lot of backtracking/reparsing/covering/refining, lots of complexity. Can we just say that a decorator cannot have newlines in between its parts, and then start parsing the decorator target as soon as we see a newline, or something that we don't know how to parse in the decorator itself? This would only be for class members. So in cases like this:
```ts
@dec ["computed"]() { }
```
we would fail, but it'd be much simpler. We'd still support targets on the same line when the target is a parameter.


The script will test for your OS version, be it Fedora, CentOS or Ubuntu. It will then run yum or apt-get to update your system. Lastly it sends a text conformation if it worked.


Why is this Taylor?


Also bumped the elasticsearch js version as I was running into an error.


Please use the application directory system in org.provebit.utils.ApplicationDirectory to determine the log location.


Comment test, web -> mail


Yeah, it shouldn't be.


На мою взгляд заводить отдельный класс не нужно
```python
line_from_track = LineString([prev, cur])
````
В shapely уже все и так есть


Comment test: web -> email.


Comment test: mail -> web

On Wed, Mar 18, 2015 at 10:15 PM, Marcin Konarski <notifications@github.com>
wrote:

> Comment test: web -> email.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AmokHuginnsson/yaal/commit/ce4ccd5b7d6c9a5d455345222fc85f016082a2ae#commitcomment-10273983>
> .
>


The horizon_extensions role is an umbrella role for Rackspace specific horizon extensions. This role rebrands horizon with an RPC theme, and also installs the Rackspace tab in the dashboard, which includes the Solutions Tab.


Hi there. I've pushed a version that I think works pretty well. You should look in the source files rtsp.c and player.c for a little documentation. But I'm also pretty sure I've discovered a bug in iTunes. Specifically, if the artwork is "large" – larger than a few hundred k or a megabyte, I'm not sure of the exact amount – then iTunes may stall in sending it, and everything that follows in the stream of commands, etc, will back up. So volume changes, etc. stop working. I've reported the issue to Apple, but don't hold your breath. I'm just about to publish the sample metadata player too, so see if it's of any guidance and let me know. We can talk about how to make it more suitable for e.g. Ruby then...


What to fall out of sync the const?


Correct, empty struct is a valid case.


Cool, I'll remove it in that case.


@OzanKurt Some discussion on the commit here: https://github.com/laravel/framework/commit/cfa7fcb60fd60b3870606c910559e67186a7a8a8


Accept?


r+


Not anymore ;)


88239574_sql_annualTotalCost (asparke2) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2100 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.67%25-yellow.svg)


Caused error in Wercker deploy.


What is the precision of getmtime? Is it possible that the two times coule be both equal and valid?


Yes. It's all pretty weird. There is no isValidLong. See https://github.com/scala/scala/blob/v2.11.4/src/library/scala/math/ScalaNumericConversions.scala#L1


doch: http://www.fontsquirrel.com/fonts/roboto


@SiPlus Can you please explain to me such a special `Q_COLOR_ESCAPE` treatment? What i see here is WCHAR string being converted to UTF8 string with `Q_COLOR_ESCAPE` symbols duplicated for some reason. What is the reason?


The switching in dialogue is a nice touch, be careful you keep raising the bar. ;-)


saw approval from metajack
at https://github.com/servo/servo/commit/6a58cbd1182adcca9a19e91222f22b1b722b8c33


merging servo/servo/fix-warnings = 6a58cbd1 into auto


servo/servo/fix-warnings = 6a58cbd1 merged ok, testing candidate = 124a78fb


Looks like to the second, so `>` is probably the way to go.


This should  not fail the test though, the agenda of the test is not this error.


Hmm. This looks wrong... if the laser reports the power to be 0, it should not be auto-corrected to 1.


Again this is not the test topic, the goal is to make sure the file gets created.


Well you've got until we go online to make up your mind


LGTM


Yeah; you're hard-coding the `const` twice now.  Not that I actually _expect_ it to fall out of sync; just that it's something we might want to try doing.


iteration (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.36%25-red.svg)


88239574_sql_annualTotalCost (asparke2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Please declare var before i , unless if you are concerned to use i value when for loop finishes.


@taiyaei Thanks! :+1: :)


Would have compiled with an `#include "stemslash.h"` ;-)


I've removed ``Flask-SQLAlchemy`` dependency from the app, it uses SQLAlchemy directly instead of that glue layer keeping it similar to the other frameworks that also use SQLAlchemy.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1156 of 1157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


iteration (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


msg(player, msg) didn't work initially and I did it like this in the end. Finally it works -.-


http://stackoverflow.com/questions/3236871/how-to-return-a-string-value-from-a-bash-function cos BASH ain't a programming language.


You also may want to look at the `CFGRaph` consisting of `CFNode`s as used in `demo::lang::Pico::ControlFlow`


Thanks!


![data flow diagram](https://cloud.githubusercontent.com/assets/10723102/6719865/4d544ce2-cd94-11e4-84b3-d02026c4537f.jpg)


`while -1 == zmq.msg_send`


thanks


This looks simple enough that we can probably test that `intersection` is exactly the set of values we expect. (Also, don't call it `intersection`, since it _should_ return `map_one - map_two`.)


I can rebase #26 which doesn't need `extglob` if wanted.


Please use net.SplitHostPort as that kind of split will blow up on an IPv6 address :)


Нямам си работа :octocat:


FIX: Running "homestead provision" removed my Blackfire client id & client token.


Is this not expected to be a constant?
Also, probably want to call it `events_url` or something; `events` is a bit generic.


as per our discussion today let's make it illegal for element access to occur in a decorator context. this will simplify the parsing, and we can always relax the restriction in the future.


81606030-VSCoils-use-cooling-flow-rate-in-heating-mode (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1664 of 1668 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


Yes, except you don't have to call it bin-root anymore.


The change also causes https://issues.jenkins-ci.org/browse/JENKINS-27496.
I'll work on Jenkins core and EnvInject plugin to fix it and release the new version ASAP


I don't think we want to facet on DOIs.


![sequence diagram](https://cloud.githubusercontent.com/assets/10723102/6719957/0c550988-cd95-11e4-9504-40e0d80bc5dd.jpg)


This entire file can be removed.


88239574_sql_annualTotalCost (asparke2) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


if we loose the refinement we do not need this.


uhm, self.log_level is not the log level of the current log method. Please look at LogPrinter.log_message() method for more info and when you read this it should also get pretty clear what to do ;)


Ugh. I like case sensitivity. Disregarding is  not respected (particularly in non windows community).  Your commit msg is accurate though.


79453838-AutomateSomeDocumentation (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.41%25-red.svg)


wow. that's really stupid. You're awesome for finding this.

note to self: learn your own damn API.


![Uploading Use Case Diagram.jpg . . .]()


not needed


Damn, I thought I updated that.


@ferventcoder right. if we install the binary next to scripts this dir probably will go away right?


Hi,

miguel.abreu.belo@gmail.com wants to follow you.

****** Is miguel.abreu.belo@gmail.com you friend? ******
If Yes please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Dtcpatricio/avt&email=reply@reply.github.com&invitername=Migas&inviterid=13992262&userid=0&token=0&emailmasterid=ba27d959-f3b4-47dc-9cd9-fbbdcab4b89f&from=miguel.abreu.belo@gmail.com&template=invite_reminder_b&src=txt_yes

If No please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Dtcpatricio/avt&email=reply@reply.github.com&invitername=Migas&inviterid=13992262&userid=0&token=0&emailmasterid=ba27d959-f3b4-47dc-9cd9-fbbdcab4b89f&from=miguel.abreu.belo@gmail.com&template=invite_reminder_b&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.flipmailer.com/uns_inviter.jsp?email=reply@reply.github.com&iid=ba27d959-f3b4-47dc-9cd9-fbbdcab4b89f&from=miguel.abreu.belo@gmail.com


![use case diagram](https://cloud.githubusercontent.com/assets/10723102/6720048/c2731430-cd95-11e4-8496-286e613f0ee3.jpg)


Jenkins core has been annotated by @jglick in https://github.com/jenkinsci/jenkins/commit/9bf265e5762f1d27e8560b716a25e2dbb031c8fc (1.560+)


if we are not parsing it. for binding element i would remove it


The reason is to escape the color codes in the temporary composition string.


Can't wait for a release ... ;-)


Hi,

tong.liu2@studio.unibo.it wants to follow you.

****** Is tong.liu2@studio.unibo.it you friend? ******
If Yes please follow the link below:
http://invites.infoaxe.net/signup_e.html?fullname=Dangerblack/overconfidenagents&email=reply@reply.github.com&invitername=tong.liu2&inviterid=37188150&userid=0&token=0&emailmasterid=cf6f85a8-eb47-4f78-80bc-47408cf2f296&from=tong.liu2@studio.unibo.it&template=invite_reminder_b&src=txt_yes

If No please follow the link below:
http://invites.infoaxe.net/signup_e.html?fullname=Dangerblack/overconfidenagents&email=reply@reply.github.com&invitername=tong.liu2&inviterid=37188150&userid=0&token=0&emailmasterid=cf6f85a8-eb47-4f78-80bc-47408cf2f296&from=tong.liu2@studio.unibo.it&template=invite_reminder_b&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.infoaxe.net/uns_inviter.jsp?email=reply@reply.github.com&iid=cf6f85a8-eb47-4f78-80bc-47408cf2f296&from=tong.liu2@studio.unibo.it


Fixes #4


yes, automatically on uninstall it will be removed.


comment is not really necessary. that's a microsoft tradition :D


Yay! Bish now has a REPL!

```bash
! ./bish -r -
print("Hello, REPL!\n");
Hello, REPL!
!
```
After typing in what you want to execute, press Enter, then ^D :stuck_out_tongue:
("! " is my bash prompt)


yeah... :)


Are the measurements from the edge of the bearings or the holder? i'm using the zip tie holders and those have about a 4-5 mm wall on the edge.


これ原因でテスト落ちてるね。
Pythonでは `/` のエスケープは不要　あと何故か `g` をエスケープしてる。多分正しくは
```python
r'^http://goo\.gl/.+$'
```
で、ちゃんとやる（テンプレートの方法と合わせる）なら
```python
r'https?://goo\.gl/[\.\-\+\?\(\)\{\}\^\$\w\d/:;@&=,%#]+'
```


Please report CSS issues to [upstream](https://github.com/twbs/bootstrap), this is an automated conversion.


since you're using Error**f** already, might be better to say `working directory '%s' is invalid` here.


ConstructionsGridView (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


давай, ако аз можех да пиша це(пляспляс), досега да съм поъпдейтнал trr, така че смело


Lets say 0 and 1 cast to `true` / `false`, just for fun.

Good point on the inconsistent namespacing. After a careful 5 seconds of consideration, I will remove all `Manifold.` prefixes in the file to increase the signal to noise ratio.


looks good to me overall. mind checking the test cases calling `ContainerCreate`? Maybe we can add some windows specific tests over there to make sure this does not regress?


Could you revert this please? In C code and most of cgame, we declare all variables in the beginning of blocks.

Also this way of variable declaration gave me a lot of errors when I was compiling Half-Life 1 on VS2008.


We want this line precisely to save disk space.  I will add a proper fix...


This appears to have broken the IDE. I now get five errors where it apparently called `getLoadedModule` with a single argument.


Ehhh. We haven't really decided yet. I just removed all of these for now.


Woah, dude.  I didn't notice this pull request until just now.  Sorry about that.  Looks like I turned off the GitHub auto-watch feature at some point, so I wasn't watching this project, so I didn't get a notification or anything for this.  The only reason I noticed it is cuz I was looking at your profile and saw my name on your list of repos contributed to.

Anyway, what's the point of storing the names in localStorage?  I guess it's the first step toward making the list customizable?  Yeah, that makes sense.  The code base has diverged a bit, but I'll incorporate this change.


we can put that in our [cmake section](https://github.com/ComputationalRadiationPhysics/picongpu/blob/749cd4d70eef6aec27b43a51a0eec0cd5c9e8103/src/picongpu/CMakeLists.txt#L377-L382) with an according flag I guess


Thanks for the feedback @TysonAndre!


use ` int j, len = strlen (name);`


Looks like you misspelled "canola"!


Was it not supposed to be the other way around (like we discussed today)?


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1151 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.64%25-green.svg)


too verbose... no need to explain /create /start difference here as it's obvious in the codebase.


Make logging conditional (also see lines 971, 995)


@ferventcoder sounds good will fix. thanks.


Watch out for Shift & Alt, it is primarily used to change your keyboard settings (USA layout to other. I think?)  - I know this is in CW but it's just a hint.


some its difficulty to learn github


The only reason I can think of that Mark would not have included getters for volume, pan, etc. is that it may be unsupported in one of the target languages.

Mark has always gone for a "lowest common denominator" approach for Mojo.  If it doesn't work on one target, none of them get it.  In fact, when Monkey was first released, there was no SetColor operation due to HTML5 not supporting image tinting.  Mark had to make a hack that writes the images pixel by pixel.  This is why you should avoid SetColor for HTML5.

I would hazard against changing the Monkey side of Mojo,  If you really want to cache volume levels like this, it should be done native and as private as possible.  This is a case where encapsulation shines.


So yes, the thing is that the view name is different but the URL is actually the same.
We should have the same '/project.json' URL for both routes.


These changes look good.
Allen


@lucaswerkmeister as a temp fix, you can add `, null` in those spots. At least, it worked for me.


I thought I already sent you some comments a couple of days ago.
Allen


We use '//' comments from C99
We use bool type from C99
We use stdint.h from C99
So qfusion code is not a C89 compatible anyway.
So why we shouldn't use modern variable declaration from C99?