I am not so sure, I think Swing repaint events should still be using the snapshot last taken. If you track back from the
```
at magic.ui.duel.viewer.ImageCardListViewer.paintComponent(ImageCardListViewer.java:252)
```
error you eventually come to [this line in ``PlayerViewerInfo``](https://github.com/magarena/magarena/blob/master/src/magic/ui/duel/viewer/PlayerViewerInfo.java#L42)  which makes a copy of the permanent states for reading by the UI which should include Swing painting events. I think using ``invokeAndWait`` would alleviate synchronization issues between game shapshots made in "UpdateGameView" and ad-hoc Swing paint events.

ViewerInfo does use ``synchronized`` method calls but I am not entirely convinced there is full coverage.


neden silindi


They didn't even bother to remove the entries for the moved files from the .gitignore file.


I'm not sure that is a good policy to bump version number in the master.
The current release is 3.2.2.
My aim was to keep the master branch equivalent with the current release.

That means, I was going to bump the version to 3.2.3 at the point of merging the ```hotfix/3.2.3``` branch (I know it's been stalled for ages now!)


IMO, it would have been easier to pass the StringOption as part of Param. See #1324.


Cavil / rant ahead, be warned!

So... you are giving executor 1 minute to finish... and if it does not, what then?
executor.shutdownNow() and await termination again? (Threads are evil :smile:)
And yes, I do not like tests which outcome (fail or not) depends on timing. (Well, except benchmarks, different story)

Anyway, to add more meanig to this test, it should be checked if runnable completed without exception.
So, submitJob, save Future from it, wait for completion, examine if future.get() returns an exception or not...


I tend to think that we can test without using mocks and @visibleForTesting in this case. But that is ok.


NPE, the import path can be null for `` `package` `` and `` `module` `` literals


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1163 of 1164 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.79%25-green.svg)


ajdskfdkdfs


changed parameter name from 'imap' to session.


タイマー２、３は削除してました。
全プレーヤーが１つの時間を使うので、タイマーは１つで事足りると判断しました。


Yes if you want, but in this case inheriting from header-line should be enough.


Plus a repubishing will be an option whenever a migration has happened. In fact I guess that will be the normal case.


Note that this may clash with invalid symlinks.


その通りです。
修正します。


THX


I think we need to look at how we republish documents in detail since this is the crucial part in the migrations from a customers point of view.


I reproduced the checks we did for integers. That's not 100% satisfying (neither for floats nor for integers)


the explicit cast warns the developer there is a potential classcastexception, with the _free_ cast the developer assumes classcast exception cannot happen.

without being dogmatic, I think this lead the developer to make wrong assumption/reasoning about the code, when someone sees a stacktrace happening at line:

`String b = map.get("foo");

He will not understand where this CCE is coming from.


In the case of a complex xml element, what does this return exactly ?


Not sure about that one


a


Is it normal that there is no dependency on Optimization-Backend ?


dgfhgdfgd


sdfsdf


dsfdf


Most theme anyway are using a face with only :foreground, I want to keep a face with a special background for directories.


What are these mindc-optimizations? Is there a link with Optimization-Backend?


Isn't a republishing always optional? It depends mainly on the ability of the frontends to cope with the previous version.


:100:  Spartalı


测试一下。


Karamik7 danışmaya bekleniyorsunuz


Finally.. this is a great addition! Thanks


apoooooooooooooddfsdfs


sdfsdfgsdg


sdfasdf


Oğuz lole gir aadsadasd :D


hızlı ve mübarek :dash:  @ahmetozdemir36


The object causing the problem is a MagicCard not MagicPermanent. As mentioend for MagcPermanent we are using PermanentViewerInfo as the snapshot, for MagicCard we are using the actual model objects and invoking methods on it.


And same here, need to require *-files.  Same expect circular dependency loop when doing so.


Sometimes, when there are two possibilities, I like to explicit both of them. Obviously this is just a personal taste, but seeing both `true` and `false` makes the code eaiser to understand to me.

The same happens with some `if ... else` statements. Sometimes I could remove the `else` clause, but I like to maintain it to explictly declare that there are two alternative ways of ending some method or completing some task.


Счёд


intに変換した音量を判定に使用します。


Aqui acho que seria:

"Normalmente você não **irá passar**..."


getEntityNamespace is deprecated

use getAliasNamespace =)


Yea, you're right :+1: . I'll try not to forget it later


I donot think this is good idea to backport centos7 packaging. There is no strict testing on it.


You could have let it ;)


I don't think it's that urgent. The ZMQ fix handles the 0.3.x situation just fine with a hack-around. Let's just backport this and it will be in 0.3.8, which will come out in a month.


I already did


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1133&buildTypeId=bt8) outcome was **FAILURE**
Summary: Compilation error: src\Extensions\Nimbus.Logger.Log4net\Nimbus.Logger.Log4net.csproj (new) Build time: 00:02:17


Whew, good thing you caught that one!


Great! Works!


You sure?
https://github.com/GoodBoyDigital/pixi.js/pulls


ここも「トラックバーの最小値が0ならばできない」で。


We might want to make this configurable at a later stage. For example, when executing the task, there should be the option of specifying how to rebuild the metadata -- whether based on the natural versioning 1.1 < 1.2 < 1.3 < 1.4 or 1.1 < 1.2 <1.4 < 1.3 (last modified on the file-system). Please, create a follow-up task for this, so that we could further polish it.


Maybe not...


Deleted Certain Files as I've put them under the Activities Folder


pls fix this.


nice to meet ya :)
Now I go sleep, its 3:00 AM here.


![You're darn right it is!](http://www.filmsite.org/speeches/fewgoodmen2.jpg)
**YOU'RE DARN RIGHT IT IS!**


I think u have to downlord the github for windows
https://windows.github.com/


@maryfries Thanks! I was going to send an email about handling big images. CSS is definitely the way to do this.

Can we add comments or some annotation to the class name about the setting of zoom blocks being used?

Also when was the specific `.block` tag added at line 673. Directly specificying heights can messup layouts on different screensizes.


Ok, well thanks! I put the pull request in. Tx again!


This is not needed since you are already tagging at line 5


Yup, that should be sufficient (if close() isn't getting called, the JVM is probably tanking/tanked anyways). Looks like you'd want to lift the ScannerBase into AbstractRecordReader and just implement close() there?


Only validate changed tags, otherwise user a and user b can't contribute images only they can see.


javascript functionality hooked to class with `js-` prefix


explicit class for unusual h2


@mwalker9 Question about team-stats.arff...There are a lot of -1 values. Is this equivalent to 'unknown'?


Why you do this David?


explicit ID for non generic item


target the images not the parent element's children


dont need to tag qualify ID selectors


2 line breaks between commented sections


AutoDocsWithNoLTO (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (653 of 655 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.69%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.55%25-green.svg)


@mikeyrayvon where is this list CSS used?


¿Alguien se anima con el test?


target directly


@lemoness


This is R code for classification based Wisconsin longitudinal study data set


I have neither the time nor the inclination to explain myself to a man who rises and sleeps under the blanket of the very freedom from extraneous backticks that I provide, and then questions the manner in which I provide it. I would rather you just said thank you, and went on your way.


prefix class that only affects color with `color-`. Class name was confusing without.


Nice @dnahodil, this looks great


jshint prefers dot notation for object values. So refactored to 1 cached object and then values selected like that


What happened happened to your comment. O.o


return original.Replace('.', '_');


generic masonry functionality with `js-` prefix


pas de test code dans le master


This might be better using CURL in PHP to avoid secondary request and help with caching


r+

I don't need to see benchmarks; this is obviously the right thing to do and it is the kind of thing push-heavy code like Servo's inline layout code needs.


You should tell harrasment bot I broke the build.


Where does this number 1456763F890A84558F99AFA687C36B9037697848 come from?


This could result in a deadlock in certain situations.  We need to find an equivalent of `__sync_bool_compare_and_swap` that doesn't require pthread mutexes.


@ready for cherry-pick


Code reusability not in the spirit of React? Copy/pasting potentially complex state changes instead of using a method? I don't believe that.

The biggest hurdle to using show() and dismiss() is that they call _onShow() and _onDismiss() which rely on this.props. At this point, this.props.onShow may not be the same as nextProps.onShow. Changing _onShow() and _onDismiss() to accept a callback and then passing nextProps.onShow or this.props.onShow doesn't smell right.

We should update componentWillReceiveProps to call nextProps.onShow() and nextProps.onDismiss().


Did line-by-line evaluation of commits to CBR scheme, identified no issues.  Will now merge these changes with a local version of the mainline and test.


rename "original" to "moduleName"


I assume you mean encrypting messages? We are talking about the public key here


@hajee i think this should be
 `config.librarian_puppet.use_v1_api = '1' `  # Check https://github.com/rodjek/librarian-puppet#how-to-use
 `config.librarian_puppet.destructive = false`   # Check https://github.com/rodjek/librarian-puppet#how-to-use


Don't define this very specific method as an extension method on string. Instead move to MetadataHelpers or something like that.


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1134&buildTypeId=bt8) is now running


As discussed we are interested in allowing payload less messages so we should account for this here.


Affirmative. Some of the cells didn't have values
On Mar 24, 2015 6:06 PM, "Nate McMaster" <notifications@github.com> wrote:

> @mwalker9 <https://github.com/mwalker9> Question about
> team-stats.arff...There are a lot of -1 values. Is this equivalent to
> 'unknown'?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/natemcmaster/march-madness/commit/2b0bc647c68ae96c7116c0f301da108c3449c30a#commitcomment-10380157>
> .
>


I think it would be important to document somewhere (is the spec the right place?) how key rotations will be handled and what happens if we eventually decide that we need a new algorithm or key size.


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1134&buildTypeId=bt8) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 1443 Build time: 00:05:10
### Failed tests
```
Nimbus.IntegrationTests.dll: Nimbus.IntegrationTests.Tests.PoisonMessageTests.WhenACommandFailsToBeHandledMoreThanNTimes.ThereShouldBeExactlyOneMessageOnTheDeadLetterQueue: Test(s) failed. Shouldly.ChuckedAWobbly :
    _deadLetterMessages.Single().SomeContent
        should be

```


@lightsofapollo,
Shouldn't you set `handlingPut = true` before unlocking the mutex... At the moment the flag isn't set anywhere.
So the mutex has no effect. Granted this is the first go code I'm hacking...

Note, I'm surprised go doesn't have `tryLock` which would have been cleaner here... I checked docs `sync` package doesn't.


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1135&buildTypeId=bt8) is now running


Note - this breaks "typestr" because it's not numeric.  But, "typestr" needs another solution to be useful anyway, so I'll solve that when I work on visualizing categorical data to solve for this case specifically.


What's wrong with constexpr for float? :/
Is there some issue with Visual Studio?


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1135&buildTypeId=bt8) outcome was **UNKNOWN**
Summary: Canceled (Tests failed: 1, passed: 1382) Build time: 00:02:52
### Failed tests
```
Nimbus.IntegrationTests.dll: Nimbus.IntegrationTests.Tests.PoisonMessageTests.WhenACommandFailsToBeHandledMoreThanNTimes.ThereShouldBeExactlyOneMessageOnTheDeadLetterQueue: Test(s) failed. Shouldly.ChuckedAWobbly :
    _deadLetterMessages.Single().SomeContent
        should be

```


The impact on performance is basically negligible.
However, even though you make a smart point about the possibility of the implementation of `posixSplitPath` (and `win32SplitPath`) changing, I don't think the source code is the proper place to be safeguarding against such a change. That is what unit/regression tests are for. I believe passing in an empty string passed to `path.parse` as well as other `path` functions should be sufficient to catch a breaking change in `posixSplitPath` and `win32SplitPath`.


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1136&buildTypeId=bt8) is now running


This is a nice solution. But I need to confess that readability  is quite poor for less experienced developers (IMHO)! :)


LGTM


This issue is already fixed in 0.8.1-alpha branch.


Whoops. That should be giglab.io in both entries in the commit message.


Thanks @dretrex!


Shouldn't `gnused` just be included? Relying on this to use the system `sed` command seems a bit...bad to me.


Nice! I was out of my mind when writting the code in the old way... It's more efficient to remove the end of the list (until the duplication ends) instead of fill the list all over again.


For this and the RHEL one, why not just match with `BIND(?:-|\s)?(.*) for <blah>`.  IOW, the part immediately after BIND is the version, just extract that without trying to ensure that it is a sane version. After all, `verison.bind` can be controlled by the administrator.


Fixed by changing that `* delay` to `+ delay` (which is what i intended the first time, oopsie.)


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1136&buildTypeId=bt8) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 1443 Build time: 00:04:32
### Failed tests
```
Nimbus.IntegrationTests.dll: Nimbus.IntegrationTests.Tests.PoisonMessageTests.WhenACommandFailsToBeHandledMoreThanNTimes.ThereShouldBeExactlyOneMessageOnTheDeadLetterQueue: Test(s) failed. Shouldly.ChuckedAWobbly :
    _deadLetterMessages.Single().SomeContent
        should be

```


for some reason user.votes.create(..) does work here, so adding user in param field
(error: parent not saved)
So I modified the line to:
```
    votes.create(value: 1, post: self, user: user)
```
Any particular reason why user.votes...didn't work? Thanks!


Here and the others where you are trying for partial case-insensitivity, I'd suggest using `flags="REG_ICASE"` or `(?i:blah)`.  This way you'll match Unbound, unbound and UnBound


Yeah, I need to move this into tagsChanged and then rip out most/all of what's in resetBeforeCreate/validate/validateUpdate and call tagsChanged from REST.Create and REST.Update, unless you have another idea how to do this?


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1138&buildTypeId=bt8) is now running


Minor, but what I try to follow/enforce for `example` elements is that we shouldn't necessarily list ever version we know about, but rather enough versions to exercise the variants we know about.  IOW, 3.2.4 vs 3.2.5 isn't that much different , but 3.2.22 vs 3.2.2 is (more digits in the later part of the version).


whats prefered in such a case: silently accept invalid input or give an error message?

is the error message ok or silently ignore the invalid values?


The compiler will turn this into a multiply I'm pretty sure


:clap:
Hibernate-core has dependency on xyz.library


Are you using OctoPi? 250000 is probably not working for you due to the OctoPi bug from today:
https://github.com/guysoft/OctoPi/issues/84

Also we should decide if we ship "EXTRUDERS" set to 1 I guess.


sdfasf


Error message please! Otherwise the user will just waste time trying to find what's wrong.


In general, yes. But in this case

1. the patch is not needed on darwin, and
2. using `gnused` would have triggered a mass-rebuild, so we'd have to go through the staging branch.


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1138&buildTypeId=bt8) outcome was **SUCCESS**
Summary: Tests passed: 1444 Build time: 00:04:34


一覧表示からsummaryListを呼び出すときは渡してないので…
ちょっと今コードがごちゃごちゃしてるのは認めます。


:+1: Thanks so much!


This looks fine to me; :+1:


Hi,

tong.liu2@studio.unibo.it wants to follow you.

****** Is tong.liu2@studio.unibo.it you friend? ******
If Yes please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Dangerblack/overconfidenagents&email=reply@reply.github.com&invitername=tong.liu2&inviterid=37188150&userid=0&token=0&emailmasterid=9d95b053-1cfe-4b66-a06c-56e5adab6c51&from=tong.liu2@studio.unibo.it&template=invite_reminder_2_b&src=txt_yes

If No please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Dangerblack/overconfidenagents&email=reply@reply.github.com&invitername=tong.liu2&inviterid=37188150&userid=0&token=0&emailmasterid=9d95b053-1cfe-4b66-a06c-56e5adab6c51&from=tong.liu2@studio.unibo.it&template=invite_reminder_2_b&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.flipmailer.com/uns_inviter.jsp?email=reply@reply.github.com&iid=9d95b053-1cfe-4b66-a06c-56e5adab6c51&from=tong.liu2@studio.unibo.it


VS hasn't implement constexpr yet so we have to use const for now... it's due to be implemented in the next version though.


I suppose of yes. Do you think this would be cleaner? (note that this is in a comment, so it is not shown in the html) I can also put it at the end of the file, there are already some hidden autosummaries.


I used to think that. Then I realised that standard library functions help programmers understand what the code is doing and not how the code does it. It may be more efficient too.

The old implementation was okay but it causes a debug check (assert fail) on VC


But what if the system you're building on has BSD sed but isn't Darwin? Say you like to roll your own stuff and use nix as a package manager on top of things, then you've got a second case of breakage.


@dachary sphinx-build tries to walk thru all files listed by man_pages and write

- doctrees
- rendered man pages (if tries to read the .doctrees file while rendering the rst)

for each of them without holding a lock.

so the sphinx-build instances races with each other when writing and reading the files listed above.


I would like to talk about that Iterable thing again. In the mean time, here's something to have a look at. http://stackoverflow.com/q/10581092/1233251


Review Comment
:tada:


hpwh_residential (nmerket) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.36%25-red.svg)


o snap it workz


Turned toolbar on for development


Was "<>9__1_1#1" added because of "<F>b__1_1#1"?


This commit marks the end of chapter 4.


Oh OK. If it's in a comment then I think this is fine


Why is this the correct fix?  (I'm not saying it's not, just that it's not obvious at all.)

`loadReferenceSequence()` does a lot more than set `currentRefID`, so are the other globals not getting set going to cause other issues?


Just to be extra safe - could you add a test for using a Table object?

Something like

```php
function it_can_accept_a_table_object(Table $table)
{
    $table->render()->willReturn('foo')->once(); // or whatever it is - typing on mobile

    $this->withTable($table)->render()->shouldBe("whatever");
}
```

I'd also expect the Panel to fail out if the Table failed out - instead of the Table showing the exception inside the panel.


This is synced Lua and entirely in the responsibility of the content devs.


test


@sergiotaborda I completely understand what you are saying but the behavior u described before is the behavior that is implemented. The only thing that is in question is the code you described (n -> null). I can assure you there's no crusade againt null here. I may have writen one or two operations using link too =P

As I said before I think .net made the call for sake of performance. I find it ok. Will reopen and fix. Peace out.


I would write "are added to its name" instead of "are included its name".


Why?


@nbriz I've removed these two conditionals because they are being checked for in my filtering process + they were causing some filtering bugs (mostly when there were more than one filter and you would remove one and it wouldn't update properly). Behavior seems to work fine without these but I just wanted to make sure I wasn't stepping on your toes.


tamed git and fixed random dumb conflict


The strategy may need to be initialized with the link to the retriever, but try finishing up the behavior so we have a concrete refactor target

> On Mar 24, 2015, at 8:31 PM, Andy Goldstein <notifications@github.com> wrote:
>
> Yeah, I need to move this into tagsChanged and then rip out most/all of what's in resetBeforeCreate/validate/validateUpdate and call tagsChanged from REST.Create and REST.Update, unless you have another idea how to do this?
>
> —
> Reply to this email directly or view it on GitHub.
>


Hey Eliot,
  Thank you for the explanation! I  About your comment:```This would involve removing line 2 and renaming the variable to per_page_max.``` Should I place ```per_page_max``` in line 2 or somewhere else? (It doesn't make too much sense to me to place it in will_paginate method as it probably gets reset at every method call?)

thanks,
Helena


I think that perhaps the best approach for the change stuff would be to tackle that in a separate change.  It applies to any change that might occur to the subscription.  I'll open an issue for now, since I don't have quite enough time to propose text.


add meta tag with lang to support international

:pray:


Early tests are quite promising; now I need to integrate my autoconf macros. Stay tuned :)


member를 붙이면
```ruby
```
Prefix Verb   URI Pattern                  Controller#Action
  like POST   /hashtags/:id/like(.:format) likes#create
       DELETE /hashtags/:id/like(.:format) likes#destroy
       POST   /statuses/:id/like(.:format) likes#create
       DELETE /statuses/:id/like(.:format) likes#destroy
```
member를 안 붙이면면
```ruby
      Prefix Verb   URI Pattern                          Controller#Action
hashtag_like POST   /hashtags/:hashtag_id/like(.:format) likes#create
             DELETE /hashtags/:hashtag_id/like(.:format) likes#destroy
 status_like POST   /statuses/:status_id/like(.:format)  likes#create
             DELETE /statuses/:status_id/like(.:format)  likes#destroy
```
이렇게 되는데 (둘이 다름), 없어도 되는거임 아니면 없어야 되는거임?
난 처음에 `/statuses/:id/like` 형태가 `/statuses/:status_id/like` 형태보다 직관적이라고 생각해서 member를 붙였는데, member를 붙이면 hashtag를 like하는 path랑 status를 like하는 path랑 동일해져버리네.


Fixed


:D


@zzo Progress?


fyi @jonathanrico


#1 lives here


동작 안하는 이유는.. hashtag 모델에서 `has_many :likes, as: :likeable` 이라서 그냥 like 모델에서는 `belongs_to :likeable, polymorphic: true`에 붙게 되는건가?


saw approval from seancribbs
at https://github.com/basho/riak_kv/commit/8f54cc7b7310901182ebee026b058b8afe0336f2


merging basho/riak_kv/bug/rdb/kv679-rebase-fixup = 8f54cc7b into borshop-integration-1094-bug/rdb/kv679-rebase-fixup


basho/riak_kv/bug/rdb/kv679-rebase-fixup = 8f54cc7b merged ok, testing candidate = f73c616c


Good


Oh sure. Please feel free to rip these out and add them into a better location.


This should be `treeplot.selectAll('.annotation')`.


Additionally, the `x` and `y` values need to be scaled by `xScale` and `yScale`. However, `xScale` and `yScale` are only really available from the tree block. I just tried making their scope global, so that they'd be set by the tree block and then accessed by the meta block, but this didn't work. Because of asynchronous IO, the meta block gets called first.

Easiest solution maybe to just move the clade annotations into `tree.json`.


This commit compliments what Crowning had identified and corrected.

I noticed that QLabel was not automatically expanding to accommodate larger sized wallet balances:

![image](https://cloud.githubusercontent.com/assets/7192646/6816413/910af418-d258-11e4-95aa-f490950a4aed.png)

increased the min-width of these labels to provide a bit more room and avoid balance cutting off in Windows:

![image](https://cloud.githubusercontent.com/assets/7192646/6816421/a4606a48-d258-11e4-967e-3d80fc26c5a3.png)


I've been playing with in my demo/test site and I like it very much.  How far are you from feeling like it's ready to release.   Seems pretty solid so far.  Minor issue with the User Manual links (right corner) in the top bar, I think.    Also the 'Visit Summary' is always left out of these UI updates.
--Tony


Sorry, i have missed. It should be ok via latest commit ;)


space is missing between Storage and Queues :)


We do not have a userdanger span. Yay outdated shit.


Rather than use "intended use" here, just say that the UA can consider the options as input to the decision.  For instance, we could define parameters that constrain the usage in a way that alters the browser's assessment of what consent is necessary in other ways.


> Bugs: No sound. The Z80 code is horribly buggy, and jumps into the weeds on the 2nd NMI.

Was this result from hardware, or emulation? (I haven't been able to get it tested on a non-CD system [where it won't really work]) The Z80 code sucks because I suck at Z80 :smile: :disappointed:


the indentation is a little bit off here - up to 27


Again, I'd move this out of the definition of userVisible and into the definition of the subscription options.


Yes, it would be more correct to use `gnused` for the exact reason you mention. But that wasn't an option when I made this commit, as darwin was completely broken and we don't send mass-rebuild-inducing commits directly to master.


Indentation is off from here till line 18.


Yes.


Memory cleanup was originally done in the OvlFile destructor. Makes more sense to put it in their respective structs.


What's the use case for this being useful for a user?

Any time this is happening that I can imagine is almost certainly a bug.


Why?


Wow. Everything looks amazing. Will have to merge and update a bit but looks great.


Sorry have been waiting for another breaking change to be merged in. If
that doesn't happen soon I'll release this alone.
Thanks
   Mark

On Tuesday, March 24, 2015, Timo Tijhof <notifications@github.com> wrote:

> @zzo <https://github.com/zzo> Progress?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/karma-runner/karma-coverage/commit/00d5103aeef83d07bfd2c91fb2db482d3f197cce#commitcomment-10380672>
> .
>


It was there already, but unused. I first commented it out and removed it in a later commit.


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/1941


Don't you have to have calls in the a3wasteland.ini?


how


You should indent these, even though they're nested. It's easier to read :)


AutoDocsWithNoLTO (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1163 of 1165 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.78%25-green.svg)


This should read "display" instead of "diplay" :P


ffffff


Yes, to generate the icon font from a folder of SVGs.


Previously here was
`QtEmoticonsGrid* emoticonsGrid = new QtEmoticonsGrid(emoticons);`
`emoticonsMenu_ = new QMenu(this);`
`emoticonsMenu_->setLayout(emoticonsGrid);`
and as it turned out - it was OK: when invoking `setLayout`, `emoticonsMenu_` becomes a parent widget (takes ownership) for `emoticonsGrid` layout (http://doc.qt.io/qt-4.8/qwidget.html#setLayout).
What's more: adding `this` to
`new QtEmoticonsGrid(emoticons);` so it's
`new QtEmoticonsGrid(emoticons, this);`
caused error (during runtime)
`QLayout: Attempting to add QLayout "" to Swift::QtChatWindow "", which already has a layout` and that's now clear for me.
Finally, I made it in two lines by passing `QMenu` widget in `QtEmoticonsGrid` constructor so `emoticonsMenu_` is automatically laid out with `emoticonsGrid` and becomes his parent widget. Ufff... :)


you forgot to correct the line 310
I think it shoud be
TEXECL ${BUSYBOX} echo "0" > /sys/kernel/security/sony_ric/enable

already tried your changes and root is working fine, thanks for your great work


Actually, an even better way than what I suggested previously might be:
```yaml
rvm:
  - 1.9.3
  - 2.1.5
env:
  - PUPPET_GEM_VERSION="~> 3.3.0"
  - PUPPET_GEM_VERSION="~> 3.0"
  - PUPPET_GEM_VERSION="~> 3.0" FUTURE_PARSER="yes"
  - PUPPET_GEM_VERSION="~> 3.0" STRICT_VARIABLES="yes"
matrix:
  fast_finish: true
  include:
    - rvm: 1.8.7
      env: PUPPET_GEM_VERSION="~> 2.7.0" FACTER_GEM_VERSION="~>1.6.0"
    - rvm: 1.8.7
      env: PUPPET_GEM_VERSION="~> 2.7.0" FACTER_GEM_VERSION="~>1.7.0"
```
Much more concise and easier to remove the Ruby 1.8/Puppet 2.7 support.


This is wrong.  It should just be a nop, since 0x44 already implies zero, and code-level builders assume the code has already been appended.  Consider an array of 10 0UL values: 0xE0 0x02 0x10 0x44


melp


lgtm


Fixed for *non-tor files.


Yay, thanks


oeuoeu


You don't need use `self` here.


トランザクションの中の場合しかresetProjectAccessor()されませんが、これでいいのでしょうか？


I was thinking of putting this typedef in private section in header file but I guess it's better to not see this when looking at the header file (because we decided to not use it in API). Is it OK?


![snimek obrazovky 2015-03-25 v 2 20 53](https://cloud.githubusercontent.com/assets/3163820/6816608/d8ef33ce-d295-11e4-8740-5ae1b0f08aa0.png)

Při ukládání už. skupiny máš před přesměrováním var_dump na hodnoty a nepovede se refresh. Můžeš dát pryč?


did this fix the bug you found?


Will the 0x53 builder handle Int64s?


Yes. I will revert today


confused. na.rm = TRUE where, is that an argument to `all`?


Will the 0x55 builder handle Int64s?


Hi Daniel,

It works thanks. But my error message is weird:
fjammes@clrlsst-dbmaster-vm:~/src/qserv (u/fjammes/DM-854 $) $ mysql --host=127.0.0.1 --port=4040 --user=qsmaster qservTest_case01_qserv -e │······
"SELECT DISTINCT o1.objectId, o2.objectId FROM   Object o1, Object o2  WHERE  scisql_angSep(o1.ra_PS, o1.decl_PS, o2.ra_PS, o2.decl_PS) < 0.│······
001    AND  o1.objectId <> o2.objectId;"                                                                                │······
ERROR 4110 (Proxy) at line 1: Qserv error: "AnalysisError:Duplicate select expression names detected, rewrite SQL query using AS keyword:\nE│······
rror(s):\n\t[-1] 2 elements with name 'objectid' at positions: 1 2 Unknown error setting QuerySession"

You can merge it to master, I'll fix the error message in my ticket.


The hotfix branch was double-rating. Somebody on the forum rated it before. If read the dhc6-base.xml in hotfix branch carefully, will see two blocks of <rating></rating>

Bo


Yeah, I was saying earlier, you configured Fog to use AWS. Perfect.


General game logic implemented using messages to the console and a single clickable page element


tohle je ok, jen dej pryč to tlačítko upravit u potomků. ať tam zůstane jen to mazat.


So much nicer, thanks


.min


![snimek obrazovky 2015-03-25 v 2 28 32](https://cloud.githubusercontent.com/assets/3163820/6816669/ad0ec02a-d296-11e4-9fb5-fc387d772b4b.png)

Pravděpodobně když ještě nemám žádný filedsety, tak se mi vypisuje tenhle warning.


Good catch.


excellent :)


Wouldn't the regular expression `/...$/` match any 3 characters at the end of a string if you don't escape the dots?


@ldoktor by the way your idea is great, and I'd like to investigate it. It's well in line with what we already discussed (making avocado look more like nose, with the improvements (test API and support to stand alone executables/other languages)).


![snimek obrazovky 2015-03-25 v 2 29 29](https://cloud.githubusercontent.com/assets/3163820/6816687/cdef36ee-d296-11e4-91b6-6b71932c73d6.png)

zapomponovat sem někam tlačítko zpět, které povede na úvodní stránku definice typu


Python allows a trailing comma after the last element of a list, so that you do not need to modify that element when a new last one is inserted.


This seemed like the easier way to do this as opposed to exposing `findDOMNode` from React through `__REACT_DEVTOOLS_GLOBAL_HOOK__`. Should be fine since `publicInstance` must be an instance and not a DOMNode.


Can you use a value of, say, 129 for this?  So we can trap any signed/unsigned regressions?


Ah cool, good one


Ok. Copy that.
I remember the forum request

Would you mind fix and merge back?
Thanks a lot, Israel

On Tue, Mar 24, 2015 at 6:27 PM, bolan <notifications@github.com> wrote:

> The hotfix branch was double-rating. Somebody on the forum rated it
> before. If read the dhc6-base.xml in hotfix branch carefully, will see two
> blocks of
>
> Bo
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FGMEMBERS/dhc6/commit/68a617fc386705b4949505131c7a06fc688a474f#commitcomment-10380933>
> .
>


![silverado fw](https://cloud.githubusercontent.com/assets/11449632/6816741/37ffcda6-d2eb-11e4-9294-ab4183ff5bed.png)


This test seems redundant now with the default `missing_timeout` matching `AbstractLatentBuildSlave`'s previous default.


Would it make sense instead of deleting this line to replace it with "kLimitMode_SrxDisableSwitchInputs" parameter?


File path is relative to the plugins directory, so the Utils require should probably be `../modules/Utilities` (with 2 preceeding dots instead of 1)


current_device is the device that the OpenVPN instance is currently running on.
new_device is the device that would be selected as highest priority and up from the gateway group
this_device is the device that has experienced an event (up/down)
If current_device == new_device then things are potentially OK, the interface that the instance is running on is still the highest priority - possibly a lower priority interface has had an event, and so we do not care to restart.
But, if current_device is this_device (the device that has had the event) then we always want to resync, even though the OpenVPN instance does not need to move to another interface.
The logic of the code path is written to first assume we need to resync, then determine the particular conditions when we do NOT need to resync. So the above "But" becomes "if current_device is not this_device" then we can also potentially avoid a resync.
Both these conditions have to be true to avoid a resync - thus the "&&" of the test.
I do believe the original test works correctly. Was there a testing scenario that illustrates a case where an OpenVPN instance does not resync when it needs to?


erm, probably not :)


cette variable est inutilisée par la suite. Est-il utile de changer sa valeur ?


テスト


truth


Merged! (because that's quite a spaceship)


# テスト２


test


again, probably not, but these aren't covered by tests yet so perhaps in the PR for tomorrow?


sure


Přidávání fieldů

- ať je typ povinný, formulář se odešle i bez vyplnění, ale záznam se neuloží
- v seznamu fieldů ať je místo ID vidět Label
- při editaci fieldu se mi neukládádají žádný změny
- u sortable u fieldů bude dělat problém podle mě tahle konstrukce:

$(".sortableChilds").sortable({
			update : function () {
				var order = $('.sortableChilds').sortable('serialize');
				console.log($('.sortableChilds').sortable('serialize'));
				$.get("process-sortable.php", order);
			}
		});

protože je na stránce už víc fieldsetu, tak je i víckrát toto $('.sortableChilds') a jakmile si v mětodě update, tak se ti pomocí totohle

var order = $('.sortableChilds').sortable('serialize');

vezme první fieldset. Tzn. zkusit a) $(this).sortable... b) pomocí ID přistupovat


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1143&buildTypeId=bt8) is now running


Chris can we work on the Pagination Assignment together tomorrow?  I have some questions on the assignment itself.  I have completed the tasks outlined in the checkpoint.
I am going to move on to the next checkpoint in the meantime.

Kendric

> On Mar 24, 2015, at 9:27 PM, Chris Baglieri <notifications@github.com> wrote:
>
> Yeah, I was saying earlier, you configured Fog to use AWS. Perfect.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/kjonesga/bloccit/commit/e5a3b842f85477f609cc088d223a61fd065db74a#commitcomment-10380937>.
>


![circles fw](https://cloud.githubusercontent.com/assets/11449632/6816842/9c9c6bf6-d2ec-11e4-8ebb-cbbd2d0ae038.png)


詳細画面のレイアウト用テンプレートと、詳細画面のデータ表示テンプレートを分割しています。


@kjonesga, sounds like a plan!


噗。。。


テンプレートを分割するついでにidをいい感じに名称変更しています。


Parabens primeiro commit!


I didn't test it for the other methods, but it looked like you implemented it corrctly there


System.out.println("\t Test_AM980859");


ビューを２つに分けるのでここは削除


ok.  i don't use tmuxline myself, but if you could raise a new issue and attach a minimal config for both tmuxline and airline i can quickly troubleshoot and get a fix out.  thanks.


ビューをレイアウト用とデータ表示用に分けてファイル名を変えたのでその対応


Final Project Idea
Problem :


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1673 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Sneaky change :snake:
Why is this required?


ビューをレイアウト用とデータ表示用に分けたのでその対応


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1143&buildTypeId=bt8) outcome was **SUCCESS**
Summary: Tests passed: 1444 Build time: 00:05:12


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1144&buildTypeId=bt8) is now running


原来这样设计是只有一个pin设备，这样能够少创建设备节点，减少memory占用。


What if we want the pusher to stop, i.e. speed == 0 ?


If you have a normal effect that moves the spell to another zone, wouldn't that stop it from going to the graveyard normally since there is no more spell on the stack to put into the graveyard?


元からありませんけど、abortしたらデバッグレベルのログが出た方がいいかもしれません。


this.projectAccessorを使わない理由は何ですか？


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity Nimbus :: 0. Feature Branches [Build 0.0.0.0](http://twcbuild.cloudapp.net/viewLog.html?buildId=1144&buildTypeId=bt8) outcome was **SUCCESS**
Summary: Tests passed: 1444 Build time: 00:04:16


That would make more sense, but because of difficulties with this system, the constant movement, it has been reverted,


And that explains the constant movement, there is the issue.


:thumbsup:


right you are - pushed a fix


Issues with empty line added at the top of the figure, especially with large datasets


http://codon.com/programming-with-nothing

& accompanying video. Try reading the article first to see how much you get.

https://www.youtube.com/watch?v=VUhlNx_-wYk


ClientBuilds that were released on the same day as packet.time, I forgot about this change xD


Reason to revert: This version might brake due to 'implicit function declarations all over the sources'. Current one is stable enough.


Alright :+1: I never thought about this edge case


Why did the tests pass is a question that came up.


The reasoning is that some themes add specific styles to links which can affect the remove button. It really should always be red. You can always overwrite it in your own theme or custom css plugin.


Fixed in next commit.


We are only returning the constants you see, which fit into a `char_u`.
Conversions were chosen to minimize needed casts. So, input parameters are left as ints, and output parameters are changed to `char_u` when possible. As `char_u` can automatically cast into an `int` when needed (but not the opposite), that leaves the minimum of explicit casts, as I said.
If you're asking why `char_u` instead of `char`, that's because I consider refactoring of `char_u` something to tackle separatedly, to avoid excessive cascading of changes outside this file. It's already complicated enough.


@joao-manywho  We have a utils method for checking for null / empty strings: manywho.utils.isNullorWhitespace


Same as above.


@joao-manywho I would like this better if it was null instead of an empty string


Specifically, the comment implies that `this.isSysop` should never be `true`.

I don't think it would happen, so there's no need to check it and possibly throw. On the other hand, setting it to `false` could prevent another bug from leading to a security issue.


Instead of introducing this is shutdown, you could also check if channelcast_db is not null


That sounds really useful. If you can implement it in such a way that it doesn't break the existing behaviour then that would be a great addition - seems like that ought to be doable? Thanks :-)


问题已查明。Shadowsocks 确实是无状态的，然而当系统的网络未初始化时，无法解析服务器的域名，导致 Shadowsocks 报错退出。而我们都是用 IP 地址的所以完全无法重现，也完全没有想到这个问题。

Shadowsocks 已将其视为 Bug，并在 `master` 中修复。下个版本就可以移除这个 hack 了。


@joao-manywho try to use single quotes for strings, if only to be consistent (I know I've put in a few double quotes, that is a problem as well)


Because findElementByXpath will shutdown the simulator after the NoElementException is thrown, I change to another way to check, using try-catch blocks. Fixed in following commit.


@DanBadea
Ok, am facut refactoring la chestia asta


@Basic


In fact nope. I didn't do it in first place because it is just a pointer to a literal string. `typedef char *  va_list;` Copying a pointer is easy ;)


@NielsZeilemaker Yes, I thought making this flag makes it more clear what it means.


But it doesn't achieve the same thing, if I forget to call initialize I will still get nullpointers


What if size is NULL?


Linux != Debian ;)


Done in [`a27802f`](https://github.com/EAlexRojas/deliteful/commit/a27802fa410dcbd268e642a897bccaddbb069273)


I'll update `README.md` file with this example.
It's likely more programmers are not aware of `sqlite transactions`.


Here it looks good.
you prefer exit on invalid SSLPeerVerification ?


@NielsZeilemaker Done.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13185/testReport/) for this commit**


We know that the switch only assigns `char_u` values, so why not directly use this type for `tempc`? So even the final cast would not be needed.


On 03/25/2015 09:56 AM, Stefan Hetzl wrote:
> But please keep ProofSequences.scala and FormulaSequences.scala as
> scripts.

I think we have different categories of examples:
  - scripts,
  - example data, and
  - utility code

Scripts (e.g. hol-tape/*.scala, hoare/*.scala): I don't think we can
easily compile them as scalac doesn't like top-level statements, only
definitions.  In any case, these are meant to be executed interactively,
so they should IMHO stay where they are and only be executed by the user.

Example data: I agree that these should not be included in the jar.

Utility code (e.g. lib/ProofSequences.scala, or tbillc, etc. in
GAPScalaInteractiveShellLibrary.scala):  We can compile these, and
definitely should to prevent bit-rotting.  I don't see any reason not to
include them in the main gapt (sbt) project; this would allow us to use
them in tests as well.

> It is not clean to import examples by default (even more so as
> the examples in xml-format are not imported automatically).

Why not?  Even if the user wants to change them, they can still :load
them, and it will just work. :-)

Or do you object to the default import in the CLI?  I mean, if the user
had to type

   import at.logic.examples._

would that be better?

> Also, please leave them at their old position directly in the
> examples/-directory. The user manual relies on this.

I fixed the references in the user manual (which already had typos before).


It replaces the random file Name generated by `Input` with `inputFile`. Because reading something like `1234-56789-1234-5678.txt` is more irritating than reading `inputFile`.


any reason why I can't have this ready and waiting on the master branch?


I'll let @acv decide :)


:+1: I think I got fooled into believing default case could not occur, and did that to match other similar functions returning 0. But now I've looked at it again, and I think you're right. Great finding. Will fix it.


What's your problem with the documentation of `InteractiveConsoleTest#getArguments`? MI added quotes, maybe it's more clear now.


change-id: http://review.cyanogenmod.org/#/c/92252/


ahh, thank you - I will fix that one too :)


@joao-manywho This looks a little funky, I think what you want to do is:

if (!manywho.utils.isNullOrWhitespace(this.state.fileName) && !this.props.fileDataRequest) {.....


@ziafazal doesn't this render an entire block useless? `FEATURES['PROFILER']` is always `False`, so `if` block below never got executed no matter what actual features dictionary in json config reads. Maybe this block should be deleted?


would prefer if the method name was "withColor", that way it is inline with the API elsewhere. (withSize, withHint, withCharset etc.)


License is main. :)


I think there were some other places where this was done, but I paused reviewing shortly after this. Will continue later.


@ziafazal this looks strange too - `DEBUG_TOOLBAR` is always `True`, so code block below is always executed no matter actual json configs. Maybe it should look like left side, i.e. unconditionally adding installed apps and so on?


cool stuff! thx.
Could you also update the README with an example?


@ziafazal nit: this block was just moved 20 lines below - it mght make sense to get it back to reduce the diff.


@ziafazal same comment here as in `common.py`


Default case cannot occur here. Only usage of this function is guarded by F_is_TyC_TyD(), which guarantees default case won't occur. Return value is chosen 0 in that cases to be able to return a `char_u`. Returning `c` would imply an un safe cast from `int` to `char_u`.


There is also a number of other scripts who rely on the examples being at this place, among them also scripts not in the repository, e.g. the exercises I am preparing the course on automated deduction right now.

You cannot make such changes to the master branch without discussing them before because it breaks other people's code.

From the user perspective it is not relevant of what category an example is. He will expect all the examples at the same place: the examples-directory. Having some imported per default and some not is only confusing.


maybe in time for the Scratch conference this summer. Right now it's the bloody beginning and way too early, but I did want to create the branch and start experimenting. And as of yesterday I *think* I've got the local-variables-delegation part done in a quite demoable way. The idea is so simple, and the basics of the implementation is, too. The part that was hard and complicated was tweaking the stage watchers and updating the IDE (the variables palette) to reflect everything all the time. I really like how it has turned out by now, and I think it's nicer (and certainly more consistent) than it used to be in BYOB.

Next up is delegating sprite-local custom block (definitions). This should be way easier. However, since custom blocks are internally represented as lambdas I need to take care of the SELF / client issue, when a child delegates to a parent's custom block definition (because *that* stores the parent sprite in its environment). But Snap already has tools to deal with that, so it should be no problem.


There's a programmatic way in `sys` for it.. nice find!


Now that I've seen `toF_tyB` case, we've got the answer to why I chose 0. Believing default case cannot occur, returning 0 avoids an unsafe cast from `int` to `char_u`.
It's been sometimes since I did this. I need to review it again and convince myself about whether default case can/cannot occur.


"The default configuration of Eclipse, and the above code style settings for IntelliJ IDEA will automatically follow these rules, so you usually do not have to take care (Be careful that the default configuration for IntelliJ IDEA is not appropriate)."

Looks like it's obviously not true.


Or is the line below the issue?


new change


why print `errors` message here only ?


TeamCity xBIM :: XbimExchange :: Build [Build 137](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1198&buildTypeId=XBIM_XbimExchange_Build) is now running


If any workstream provides invalid json, the corresponding task in tasks list will be undefined as that particular task will have empty json structure ({})


TeamCity xBIM :: XbimExchange :: Build [Build 137](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1198&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Compilation error: Xbim.COBieLite.SerialisationHelper\SerialisationHelper.csproj Build time: 00:00:37


Why save f(q) if the step was rejected?


Hi Josh!

So, to fix the connection issue, I was going to pull out the entire
database interaction - queries, parameters for those queries, all of it -
and create access functions for an object or collection of objects that
could iterate through a list of parameters and prepare the statement
appropriately. This way all of the database interaction would be in a
single location and the queries themselves could be modified from that same
location. The problem with doing that is that every query is different. So
I was going to create something that would validate what you were sending
it - essentially create a set of dynamic models that could populate with,
say, json, that specified the action you would like to perform and provide
the appropriate data to do so. After that we could use the database schema
itself (keys, fields, not null fields, etc.) to determine what we need to
complete the task, keeping the validation dynamic and based solely on how
the data is structured. We could even wrap some of that functionality into
the angular code to actually do the form validation as well. So say for
instance an item has a null-able column that later becomes required, the
validation of the SQL query as well as the form validation shift and change
automatically. For that matter, we could even modify the form itself on the
fly as those templates could go through the PHP preprocessor, meaning any
changes would simply require reloading the form through ajax.

The whole reason I was doing this was to avoid SQL injection, though. The
mysqli class isn't something I've worked with before - I've used its
predecessor. In those instances you could prepare a query, but in my
experience it was easier to provide your own SQL injection protection. I
opted for this solution because the classes and functions I'm used to using
are deprecated.

Additionally, there is a gui component that uses angular. It's a little
raw, but it mostly works. I got stuck, though, because the form handler
script that I wrote to interact with the gui stops the script and crashes
when I instantiate a store object. When I instantiate it from command line,
though, it works. I'm thinking I missed a configuration option in the PHP
installation that won't let me use external references. Not quite sure.

Anyways, that's where I left it. I don't like to leave things unfinished,
and had planned to get back to it when I had a free hour or more.

Cheers,
Dave
 On Mar 24, 2015 1:52 PM, "Josh Graber" <notifications@github.com> wrote:

> I like how your solution is robust enough to even include a real SQL
> connection. Most solutions to this problem just hard code the values.
> Pulling the data in from an external source forced you to abstract it and
> allow for it to change.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dcleavenger/KataRedux/commit/e1036d36730573fcf89352d3aea6cb55224297ad#commitcomment-10373418>
> .
>


Это был черипик, я уж не помню как это сюда доставлялось)


1. Я выделил ОФ и УФ из-за того, что тесты, использующие одну глобальную переменную из модуля обработки, будут работать в ОФ, но не будут работать в УФ. Пример этого был в тестах зависимости тестов, из-за этого мне пришлось пропускать эти тесты из модуля при запуске в тонком клиенте.
2. Да, сохранение контекста (с глоб.переменной или реквизитом обработки) внутри тестовой обработки - это побочный эффект и его работа не гарантируется.

Поэтому рекомендация: использовать работу с контекстом из юТест.
Тогда серверные тесты очень легко перевести из ОФ на УФ.


[SPARK-6396][Core] Add broadcast timeout


@nobugs-hare Do we have any mechanisms how to report about these Zepto exceptions to SmartAnthill Core?


if self.time_integrator in ['SSPLMM43','SSPLMM53']


强行加入几行，使得电商数据有值，同时将数据的时间赋值，避免之后做agg后数据变为list型


TeamCity xBIM :: XbimExchange :: Build [Build 138](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1199&buildTypeId=XBIM_XbimExchange_Build) is now running


`bool dest` doesn't give you a good hint what the bool is about. I think having `bool from_user` would be a better name to reflect what is happening in the source code? What do you think?


TeamCity xBIM :: XbimExchange :: Build [Build 138](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1199&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Compilation error: Xbim.COBieLite.SerialisationHelper\SerialisationHelper.csproj Build time: 00:00:17


没什么用


А зачем он нужен?
ИМХО сейчас и так все передается?
или из-за кеширования объекта могут быть проблемы с контекстом/миром ?


We shouldn't need this variable, since you are already returning False from the step function.


This should probably be utf8mb4 in a lot of cases.


Perhaps these if statements should be nested in the reverse order.


В планах реализовать интерфейс для метода `->map($callback)`, тогда предыдущий код будет выглядеть так:
```php
$original = array(1, 2);
$instance = ArrayMap::create($original);
$instance->map(function (ElementArrayObject $element) {
    $value = $element->getValue();
    $key = $element->getKey();
    $element->setValue(array($value * 2));
    return $element;
});
$this->assertEquals(array(array(2), array(4)), $instance->getArray());
```


We should be using add_definitions instead.


`tee_session_shm_new`, I'm not sure if I like having the "_new" in a function name. You will never know when you need to replace it again? Please come up with a better name explicitly tell that the function creates new shm (i.e, `tee_session_shm_create_new`).


Update required:
- Android Support Repository (v12)
- Google Repository (v16)
- Google Play services (v23)


Has approx 7 statements (TooManyStatements)


Ma perché togli i commenti!?


ну и ключ, например)

```php
$instance->map(function (ElementArrayObject $element) {
    $value = $element->getValue();
    $key = $element->getKey();
    $element->setKey($key * 3);
    $element->setValue(array($value * 2));
    return $element;
});
```


1: M110 missing component name


8: M102 unrecognized bullet/signature
9: M102 unrecognized bullet/signature
1: M110 missing component name


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing
69:1: E402 module level import not at top of file
70:1: I100 Imports statements are in the wrong order. import os should be before from ConfigParser
70:1: E402 module level import not at top of file
71:1: E402 module level import not at top of file
72:1: E402 module level import not at top of file
73:1: E402 module level import not at top of file
74:1: E402 module level import not at top of file
76:1: E302 expected 2 blank lines, found 1
80:1: E302 expected 2 blank lines, found 1
84:1: E302 expected 2 blank lines, found 1
84: D202 No blank lines allowed *after* function docstring, found 1
84: D400 First line should end with '.', not 'g'
84: D205 Blank line missing between one-line summary and description
90:5: E266 too many leading '#' for block comment
93:5: E266 too many leading '#' for block comment
99:51: E231 missing whitespace after ','
109:5: E266 too many leading '#' for block comment
114:5: E266 too many leading '#' for block comment
119:5: E266 too many leading '#' for block comment
123:5: E266 too many leading '#' for block comment
132:5: E266 too many leading '#' for block comment
159:5: E266 too many leading '#' for block comment
164:5: E266 too many leading '#' for block comment
169:5: E266 too many leading '#' for block comment
173:5: E266 too many leading '#' for block comment
176:1: E302 expected 2 blank lines, found 1
176: D400 First line should end with '.', not 's'
176: D205 Blank line missing between one-line summary and description
182:5: E266 too many leading '#' for block comment
184:20: E127 continuation line over-indented for visual indent
185:5: E266 too many leading '#' for block comment
188:5: E266 too many leading '#' for block comment
190:5: E266 too many leading '#' for block comment
195:5: E266 too many leading '#' for block comment
200:5: E266 too many leading '#' for block comment
201:5: E266 too many leading '#' for block comment
205:5: E266 too many leading '#' for block comment
217:5: E266 too many leading '#' for block comment
218:5: E266 too many leading '#' for block comment
219:5: E266 too many leading '#' for block comment
222:5: E266 too many leading '#' for block comment
225:5: E266 too many leading '#' for block comment
230:1: E302 expected 2 blank lines, found 1
230: D205 Blank line missing between one-line summary and description
237:5: E266 too many leading '#' for block comment
239:21: E127 continuation line over-indented for visual indent
240:5: E266 too many leading '#' for block comment
243:5: E266 too many leading '#' for block comment
259:1: E302 expected 2 blank lines, found 1
259: D205 Blank line missing between one-line summary and description
266:5: E266 too many leading '#' for block comment
268:21: E127 continuation line over-indented for visual indent
269:5: E266 too many leading '#' for block comment
272:5: E266 too many leading '#' for block comment
287:1: E302 expected 2 blank lines, found 1
287: D400 First line should end with '.', not '6'
287: D205 Blank line missing between one-line summary and description
295:5: E266 too many leading '#' for block comment
297:14: E127 continuation line over-indented for visual indent
298:5: E266 too many leading '#' for block comment
301:13: E266 too many leading '#' for block comment
318:1: E302 expected 2 blank lines, found 1
318: D400 First line should end with '.', not 'r'
318: D205 Blank line missing between one-line summary and description
326:5: E266 too many leading '#' for block comment
328:14: E127 continuation line over-indented for visual indent
329:5: E266 too many leading '#' for block comment
332:16: E126 continuation line over-indented for hanging indent
333:13: E266 too many leading '#' for block comment
347:45: E128 continuation line under-indented for visual indent
348:45: E128 continuation line under-indented for visual indent
356:1: E302 expected 2 blank lines, found 1
356: D400 First line should end with '.', not 'd'
356: D205 Blank line missing between one-line summary and description
383:1: E302 expected 2 blank lines, found 1
383: D209 Put multi-line docstring closing quotes on separate line
383: D400 First line should end with '.', not 'n'
383: D205 Blank line missing between one-line summary and description
420:1: E302 expected 2 blank lines, found 1
420: D200 One-line docstring should not occupy 3 lines
434:1: E302 expected 2 blank lines, found 1
434: D400 First line should end with '.', not 'N'
434: D205 Blank line missing between one-line summary and description
444:5: E266 too many leading '#' for block comment
446:5: E266 too many leading '#' for block comment
448:5: E266 too many leading '#' for block comment
451:9: E266 too many leading '#' for block comment
452:9: E266 too many leading '#' for block comment
468:9: E266 too many leading '#' for block comment
470:32: W601 .has_key() is deprecated, use 'in'
474:49: E128 continuation line under-indented for visual indent
479:9: E266 too many leading '#' for block comment
485:82: E231 missing whitespace after ','
487:37: W601 .has_key() is deprecated, use 'in'
499:1: E302 expected 2 blank lines, found 1
499: D400 First line should end with '.', not 's'
499: D205 Blank line missing between one-line summary and description
540:13: E122 continuation line missing indentation or outdented
540:21: E203 whitespace before ':'
541:13: E122 continuation line missing indentation or outdented
541:21: E203 whitespace before ':'
542:13: E122 continuation line missing indentation or outdented
542:18: E203 whitespace before ':'
543:13: E122 continuation line missing indentation or outdented
543:21: E203 whitespace before ':'
544:13: E122 continuation line missing indentation or outdented
544:21: E203 whitespace before ':'
551:1: E302 expected 2 blank lines, found 1
551: D205 Blank line missing between one-line summary and description
560:5: E266 too many leading '#' for block comment
565:14: E126 continuation line over-indented for hanging indent
591:69: E502 the backslash is redundant between brackets
604:5: E266 too many leading '#' for block comment
605:5: E266 too many leading '#' for block comment
608:28: E261 at least two spaces before inline comment
629:1: E302 expected 2 blank lines, found 1
648:1: E302 expected 2 blank lines, found 1
648: D103 Docstring missing
657:1: E302 expected 2 blank lines, found 1
670:1: E302 expected 2 blank lines, found 1
678:72: E502 the backslash is redundant between brackets
679:20: E127 continuation line over-indented for visual indent
679:44: E231 missing whitespace after ','
683:35: E261 at least two spaces before inline comment
686:48: E231 missing whitespace after ','
692:1: E302 expected 2 blank lines, found 1
709:48: E231 missing whitespace after ','
715:1: E302 expected 2 blank lines, found 1
728:48: E231 missing whitespace after ','
734:1: E302 expected 2 blank lines, found 1
745:1: E302 expected 2 blank lines, found 1
750:1: E302 expected 2 blank lines, found 1
755:1: E302 expected 2 blank lines, found 1
755: D209 Put multi-line docstring closing quotes on separate line
755: D400 First line should end with '.', not 'h'
755: D205 Blank line missing between one-line summary and description
761:1: E302 expected 2 blank lines, found 1
761: D400 First line should end with '.', not 'e'
761: D205 Blank line missing between one-line summary and description
778:5: B901 blind except: statement
781:1: E302 expected 2 blank lines, found 1
781: D400 First line should end with '.', not 's'
781: D205 Blank line missing between one-line summary and description
789:23: E127 continuation line over-indented for visual indent
858:5: E266 too many leading '#' for block comment
878:5: E266 too many leading '#' for block comment
882:29: E127 continuation line over-indented for visual indent
884:30: E127 continuation line over-indented for visual indent
932:16: E203 whitespace before ':'
935:20: E127 continuation line over-indented for visual indent
939:67: E502 the backslash is redundant between brackets
940:33: E128 continuation line under-indented for visual indent
940:80: E502 the backslash is redundant between brackets
941:15: E127 continuation line over-indented for visual indent
942:63: E502 the backslash is redundant between brackets
942:29: E203 whitespace before ':'
943:32: E127 continuation line over-indented for visual indent
943:74: E502 the backslash is redundant between brackets
996:16: E203 whitespace before ':'
997:17: E203 whitespace before ':'
999:26: E203 whitespace before ':'
1000:58: E502 the backslash is redundant between brackets
1001:29: E127 continuation line over-indented for visual indent
1001:71: E502 the backslash is redundant between brackets
1003:58: E502 the backslash is redundant between brackets
1004:72: E502 the backslash is redundant between brackets
1006:58: E502 the backslash is redundant between brackets
1007:75: E502 the backslash is redundant between brackets
1009:63: E502 the backslash is redundant between brackets
1010:64: E502 the backslash is redundant between brackets
1012:61: E502 the backslash is redundant between brackets
1013:66: E502 the backslash is redundant between brackets
1015:63: E502 the backslash is redundant between brackets
1015:29: E203 whitespace before ':'
1016:32: E127 continuation line over-indented for visual indent
1016:74: E502 the backslash is redundant between brackets
1058:1: E302 expected 2 blank lines, found 1
1058: D400 First line should end with '.', not 'r'
1058: D205 Blank line missing between one-line summary and description
1071:11: E271 multiple spaces after keyword
1073:1: E302 expected 2 blank lines, found 1
1073: D200 One-line docstring should not occupy 3 lines
1085:1: E302 expected 2 blank lines, found 1
1085: D400 First line should end with '.', not 'y'
1085: D205 Blank line missing between one-line summary and description
1104:1: E302 expected 2 blank lines, found 0
1104: D401 First line should be imperative: 'Return', not 'Returns'
1104: D200 One-line docstring should not occupy 3 lines
1122: D400 First line should end with '.', not 'e'
1122: D205 Blank line missing between one-line summary and description
1139:1: E302 expected 2 blank lines, found 1
1139: D400 First line should end with '.', not 'L'
1139: D205 Blank line missing between one-line summary and description
1174:1: E302 expected 2 blank lines, found 1
1189:21: E261 at least two spaces before inline comment
1194:13: E266 too many leading '#' for block comment
1196:9: E266 too many leading '#' for block comment
1199:65: E231 missing whitespace after ','
1208:9: E266 too many leading '#' for block comment


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
3: L102 copyright year is outdated, expected 2015 but got 2013
43: D400 First line should end with '.', not 's'
43: D205 Blank line missing between one-line summary and description
80:5: B901 blind except: statement
91:5: B901 blind except: statement
103:5: E266 too many leading '#' for block comment
114: D400 First line should end with '.', not '2'
114: D205 Blank line missing between one-line summary and description
130: D203 Expected 1 blank line *before* class docstring, found 0
130: D204 Expected 1 blank line *after* class docstring, found 0
130: D400 First line should end with '.', not 's'
139: D102 Docstring missing


79:1: E402 module level import not at top of file
80:1: I101 Imported names are in the wrong order. Should be IndentedHelpFormatter, Option, OptionError, OptionGroup, OptionParser
80:1: E402 module level import not at top of file
82:1: I100 Imports statements are in the wrong order. import os should be before from optparse
82:1: E402 module level import not at top of file
83:1: E402 module level import not at top of file
84:1: E402 module level import not at top of file
85:1: E402 module level import not at top of file
86:1: E402 module level import not at top of file
87:1: E402 module level import not at top of file
95: D290 White spaces around docstring should be trimmed.
95: D400 First line should end with '.', not 'o'
106: D202 No blank lines allowed *after* function docstring, found 1
106: D400 First line should end with '.', not 'g'
106: D205 Blank line missing between one-line summary and description
112:5: E266 too many leading '#' for block comment
115:5: E266 too many leading '#' for block comment
117:27: E127 continuation line over-indented for visual indent
128:5: E303 too many blank lines (2)
128:5: E266 too many leading '#' for block comment
144:5: E266 too many leading '#' for block comment
149:5: E266 too many leading '#' for block comment
155:5: E266 too many leading '#' for block comment
159:5: E266 too many leading '#' for block comment
209:23: E126 continuation line over-indented for hanging indent
212:5: E266 too many leading '#' for block comment
219:5: E266 too many leading '#' for block comment
248:70: E231 missing whitespace after ','
258:5: E266 too many leading '#' for block comment
263:5: E266 too many leading '#' for block comment
268:5: E266 too many leading '#' for block comment
276:5: E266 too many leading '#' for block comment
280:5: E266 too many leading '#' for block comment
288:27: E127 continuation line over-indented for visual indent
300:5: E303 too many blank lines (3)
300:5: E266 too many leading '#' for block comment
303:1: E302 expected 2 blank lines, found 1
303: D400 First line should end with '.', not 's'
303: D205 Blank line missing between one-line summary and description
308:5: E266 too many leading '#' for block comment
309:5: E266 too many leading '#' for block comment
310:5: E266 too many leading '#' for block comment
311: D401 First line should be imperative: 'Return', not 'Returns'
311: D400 First line should end with '.', not ':'
338:5: E266 too many leading '#' for block comment
340:20: E127 continuation line over-indented for visual indent
341:5: E266 too many leading '#' for block comment
344:5: E266 too many leading '#' for block comment
346:5: E266 too many leading '#' for block comment
351:5: E266 too many leading '#' for block comment
356:5: E266 too many leading '#' for block comment
357:5: E266 too many leading '#' for block comment
361:5: E266 too many leading '#' for block comment
364:5: E266 too many leading '#' for block comment
376:5: E266 too many leading '#' for block comment
379:5: E266 too many leading '#' for block comment
384:1: E302 expected 2 blank lines, found 1
384: D205 Blank line missing between one-line summary and description
391:5: E266 too many leading '#' for block comment
393:21: E127 continuation line over-indented for visual indent
394:5: E266 too many leading '#' for block comment
398:50: E502 the backslash is redundant between brackets
399:25: E127 continuation line over-indented for visual indent
399:66: E502 the backslash is redundant between brackets
400:25: E127 continuation line over-indented for visual indent
410:1: E302 expected 2 blank lines, found 1
410: D205 Blank line missing between one-line summary and description
417:5: E266 too many leading '#' for block comment
419:21: E127 continuation line over-indented for visual indent
420:5: E266 too many leading '#' for block comment
423:5: E266 too many leading '#' for block comment
438:1: E302 expected 2 blank lines, found 1
438: D400 First line should end with '.', not '6'
438: D205 Blank line missing between one-line summary and description
446:5: E266 too many leading '#' for block comment
448:14: E127 continuation line over-indented for visual indent
449:5: E266 too many leading '#' for block comment
452:13: E266 too many leading '#' for block comment
460:50: E127 continuation line over-indented for visual indent
461:50: E127 continuation line over-indented for visual indent
462:50: E127 continuation line over-indented for visual indent
470:1: E302 expected 2 blank lines, found 1
470: D400 First line should end with '.', not 'r'
470: D205 Blank line missing between one-line summary and description
478:5: E266 too many leading '#' for block comment
480:14: E127 continuation line over-indented for visual indent
481:5: E266 too many leading '#' for block comment
484:16: E126 continuation line over-indented for hanging indent
485:13: E266 too many leading '#' for block comment
499:45: E128 continuation line under-indented for visual indent
500:45: E128 continuation line under-indented for visual indent
508:1: E302 expected 2 blank lines, found 1
508: D400 First line should end with '.', not 'd'
508: D205 Blank line missing between one-line summary and description
535:1: E302 expected 2 blank lines, found 1
535: D209 Put multi-line docstring closing quotes on separate line
535: D400 First line should end with '.', not 'n'
535: D205 Blank line missing between one-line summary and description
561:32: F841 local variable 'err' is assigned to but never used
580:1: E302 expected 2 blank lines, found 1
580: D209 Put multi-line docstring closing quotes on separate line
580: D400 First line should end with '.', not 'n'
580: D205 Blank line missing between one-line summary and description
586:5: B901 blind except: statement
587:9: F401 'pickle' imported but unused
619:1: E302 expected 2 blank lines, found 1
619: D200 One-line docstring should not occupy 3 lines
633:1: E302 expected 2 blank lines, found 1
633: D400 First line should end with '.', not 'N'
633: D205 Blank line missing between one-line summary and description
643:5: E266 too many leading '#' for block comment
645:5: E266 too many leading '#' for block comment
647:5: E266 too many leading '#' for block comment
650:9: E266 too many leading '#' for block comment
651:9: E266 too many leading '#' for block comment
667:9: E266 too many leading '#' for block comment
669:32: W601 .has_key() is deprecated, use 'in'
673:49: E128 continuation line under-indented for visual indent
678:9: E266 too many leading '#' for block comment
684:82: E231 missing whitespace after ','
686:37: W601 .has_key() is deprecated, use 'in'
698:1: E302 expected 2 blank lines, found 1
698: D400 First line should end with '.', not 's'
698: D205 Blank line missing between one-line summary and description
716:1: E302 expected 2 blank lines, found 1
716: D205 Blank line missing between one-line summary and description
725:5: E266 too many leading '#' for block comment
730:14: E126 continuation line over-indented for hanging indent
756:69: E502 the backslash is redundant between brackets
769:5: E266 too many leading '#' for block comment
770:5: E266 too many leading '#' for block comment
774:32: E261 at least two spaces before inline comment
797:1: E302 expected 2 blank lines, found 1
816:1: E302 expected 2 blank lines, found 1
816: D103 Docstring missing
825:1: E302 expected 2 blank lines, found 1
825: D103 Docstring missing
831:1: E302 expected 2 blank lines, found 1
848:1: E302 expected 2 blank lines, found 1
856:72: E502 the backslash is redundant between brackets
857:20: E127 continuation line over-indented for visual indent
857:44: E231 missing whitespace after ','
861:35: E261 at least two spaces before inline comment
872:1: E302 expected 2 blank lines, found 1
896:50: E231 missing whitespace after ','
902:1: E302 expected 2 blank lines, found 1
915:48: E231 missing whitespace after ','
921:1: E302 expected 2 blank lines, found 1
932:1: E302 expected 2 blank lines, found 1
938:1: E302 expected 2 blank lines, found 1
944:1: E302 expected 2 blank lines, found 1
950:1: E302 expected 2 blank lines, found 1
956:1: E302 expected 2 blank lines, found 1
956: D400 First line should end with '.', not 'e'
956: D205 Blank line missing between one-line summary and description
973:5: B901 blind except: statement
976:1: E302 expected 2 blank lines, found 1
976: D400 First line should end with '.', not 's'
976: D205 Blank line missing between one-line summary and description
985:23: E127 continuation line over-indented for visual indent
1053:5: E266 too many leading '#' for block comment
1059:64: E261 at least two spaces before inline comment
1060:13: E128 continuation line under-indented for visual indent
1061:13: E128 continuation line under-indented for visual indent
1061:61: E261 at least two spaces before inline comment
1062:13: E128 continuation line under-indented for visual indent
1063:13: E128 continuation line under-indented for visual indent
1064:13: E128 continuation line under-indented for visual indent
1065:13: E128 continuation line under-indented for visual indent
1066:13: E128 continuation line under-indented for visual indent
1067:13: E128 continuation line under-indented for visual indent
1067:21: E261 at least two spaces before inline comment
1074:5: E266 too many leading '#' for block comment
1124:5: E266 too many leading '#' for block comment
1147:9: E266 too many leading '#' for block comment
1158:5: E266 too many leading '#' for block comment
1162:29: E127 continuation line over-indented for visual indent
1164:30: E127 continuation line over-indented for visual indent
1220:20: E127 continuation line over-indented for visual indent
1222:91: E502 the backslash is redundant between brackets
1223:28: E127 continuation line over-indented for visual indent
1225:67: E502 the backslash is redundant between brackets
1226:33: E128 continuation line under-indented for visual indent
1226:80: E502 the backslash is redundant between brackets
1227:15: E127 continuation line over-indented for visual indent
1289:17: E203 whitespace before ':'
1291:99: E502 the backslash is redundant between brackets
1291:26: E203 whitespace before ':'
1292:29: E127 continuation line over-indented for visual indent
1293:58: E502 the backslash is redundant between brackets
1294:71: E502 the backslash is redundant between brackets
1296:58: E502 the backslash is redundant between brackets
1297:72: E502 the backslash is redundant between brackets
1299:58: E502 the backslash is redundant between brackets
1300:75: E502 the backslash is redundant between brackets
1302:63: E502 the backslash is redundant between brackets
1303:64: E502 the backslash is redundant between brackets
1305:61: E502 the backslash is redundant between brackets
1306:66: E502 the backslash is redundant between brackets
1350:1: E302 expected 2 blank lines, found 1
1350: D400 First line should end with '.', not 'r'
1350: D205 Blank line missing between one-line summary and description
1374:1: E302 expected 2 blank lines, found 1
1374: D200 One-line docstring should not occupy 3 lines
1386:1: E302 expected 2 blank lines, found 1
1386: D400 First line should end with '.', not 'y'
1386: D205 Blank line missing between one-line summary and description
1405:1: E302 expected 2 blank lines, found 0
1405: D401 First line should be imperative: 'Return', not 'Returns'
1405: D200 One-line docstring should not occupy 3 lines
1423: D400 First line should end with '.', not 'e'
1423: D205 Blank line missing between one-line summary and description
1440:1: E302 expected 2 blank lines, found 1
1440: D400 First line should end with '.', not 'L'
1440: D205 Blank line missing between one-line summary and description
1476: D400 First line should end with '.', not 's'
1476: D200 One-line docstring should not occupy 3 lines
1483:1: E302 expected 2 blank lines, found 1
1483: D400 First line should end with '.', not 's'
1483: D200 One-line docstring should not occupy 3 lines
1491: D400 First line should end with '.', not 'd'
1491: D200 One-line docstring should not occupy 3 lines
1499: D200 One-line docstring should not occupy 3 lines
1507: D200 One-line docstring should not occupy 3 lines
1515: D200 One-line docstring should not occupy 3 lines
1516:43: E128 continuation line under-indented for visual indent
1525: D202 No blank lines allowed *after* function docstring, found 1
1528: D203 Expected 1 blank line *before* class docstring, found 0
1528: D204 Expected 1 blank line *after* class docstring, found 0
1528: D400 First line should end with '.', not 'l'
1642: D290 White spaces around docstring should be trimmed.
1642: D400 First line should end with '.', not 's'
1648:9: E266 too many leading '#' for block comment
1655:5: E266 too many leading '#' for block comment
1693:9: E266 too many leading '#' for block comment


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing
77:1: E402 module level import not at top of file
78:1: I101 Imported names are in the wrong order. Should be IndentedHelpFormatter, Option, OptionError, OptionGroup, OptionParser
78:1: E402 module level import not at top of file
80:1: I100 Imports statements are in the wrong order. import os should be before from optparse
80:1: E402 module level import not at top of file
81:1: E402 module level import not at top of file
82:1: E402 module level import not at top of file
83:1: E402 module level import not at top of file
84:1: E402 module level import not at top of file
92: D290 White spaces around docstring should be trimmed.
92: D400 First line should end with '.', not 'o'
103: D202 No blank lines allowed *after* function docstring, found 1
103: D400 First line should end with '.', not 'g'
103: D205 Blank line missing between one-line summary and description
109:5: E266 too many leading '#' for block comment
112:5: E266 too many leading '#' for block comment
114:27: E127 continuation line over-indented for visual indent
125:5: E303 too many blank lines (2)
125:5: E266 too many leading '#' for block comment
131:51: E231 missing whitespace after ','
141:5: E266 too many leading '#' for block comment
146:5: E266 too many leading '#' for block comment
151:5: E266 too many leading '#' for block comment
155:5: E266 too many leading '#' for block comment
190:23: E126 continuation line over-indented for hanging indent
193:5: E266 too many leading '#' for block comment
200:5: E266 too many leading '#' for block comment
221:59: E231 missing whitespace after ','
235:5: E266 too many leading '#' for block comment
240:5: E266 too many leading '#' for block comment
245:5: E266 too many leading '#' for block comment
253:5: E266 too many leading '#' for block comment
257:5: E266 too many leading '#' for block comment
264:27: E127 continuation line over-indented for visual indent
276:5: E303 too many blank lines (3)
276:5: E266 too many leading '#' for block comment
279:1: E302 expected 2 blank lines, found 1
279: D400 First line should end with '.', not 's'
279: D205 Blank line missing between one-line summary and description
285:5: E266 too many leading '#' for block comment
287:20: E127 continuation line over-indented for visual indent
288:5: E266 too many leading '#' for block comment
291:5: E266 too many leading '#' for block comment
293:5: E266 too many leading '#' for block comment
298:5: E266 too many leading '#' for block comment
303:5: E266 too many leading '#' for block comment
304:5: E266 too many leading '#' for block comment
308:5: E266 too many leading '#' for block comment
320:5: E266 too many leading '#' for block comment
321:5: E266 too many leading '#' for block comment
322:5: E266 too many leading '#' for block comment
325:5: E266 too many leading '#' for block comment
328:5: E266 too many leading '#' for block comment
333:1: E302 expected 2 blank lines, found 1
333: D205 Blank line missing between one-line summary and description
340:5: E266 too many leading '#' for block comment
342:21: E127 continuation line over-indented for visual indent
343:5: E266 too many leading '#' for block comment
346:5: E266 too many leading '#' for block comment
362:1: E302 expected 2 blank lines, found 1
362: D205 Blank line missing between one-line summary and description
369:5: E266 too many leading '#' for block comment
371:21: E127 continuation line over-indented for visual indent
372:5: E266 too many leading '#' for block comment
375:5: E266 too many leading '#' for block comment
390:1: E302 expected 2 blank lines, found 1
390: D400 First line should end with '.', not '6'
390: D205 Blank line missing between one-line summary and description
398:5: E266 too many leading '#' for block comment
400:14: E127 continuation line over-indented for visual indent
401:5: E266 too many leading '#' for block comment
404:13: E266 too many leading '#' for block comment
412:50: E127 continuation line over-indented for visual indent
413:50: E127 continuation line over-indented for visual indent
414:50: E127 continuation line over-indented for visual indent
422:1: E302 expected 2 blank lines, found 1
422: D400 First line should end with '.', not 'r'
422: D205 Blank line missing between one-line summary and description
430:5: E266 too many leading '#' for block comment
432:14: E127 continuation line over-indented for visual indent
433:5: E266 too many leading '#' for block comment
436:16: E126 continuation line over-indented for hanging indent
437:13: E266 too many leading '#' for block comment
451:45: E128 continuation line under-indented for visual indent
452:45: E128 continuation line under-indented for visual indent
460:1: E302 expected 2 blank lines, found 1
460: D400 First line should end with '.', not 'd'
460: D205 Blank line missing between one-line summary and description
487:1: E302 expected 2 blank lines, found 1
487: D209 Put multi-line docstring closing quotes on separate line
487: D400 First line should end with '.', not 'n'
487: D205 Blank line missing between one-line summary and description
524:1: E302 expected 2 blank lines, found 1
524: D200 One-line docstring should not occupy 3 lines
538:1: E302 expected 2 blank lines, found 1
538: D400 First line should end with '.', not 'N'
538: D205 Blank line missing between one-line summary and description
548:5: E266 too many leading '#' for block comment
550:5: E266 too many leading '#' for block comment
552:5: E266 too many leading '#' for block comment
555:9: E266 too many leading '#' for block comment
556:9: E266 too many leading '#' for block comment
572:9: E266 too many leading '#' for block comment
574:32: W601 .has_key() is deprecated, use 'in'
578:49: E128 continuation line under-indented for visual indent
583:9: E266 too many leading '#' for block comment
589:82: E231 missing whitespace after ','
591:37: W601 .has_key() is deprecated, use 'in'
603:1: E302 expected 2 blank lines, found 1
603: D400 First line should end with '.', not 's'
603: D205 Blank line missing between one-line summary and description
621:1: E302 expected 2 blank lines, found 1
621: D205 Blank line missing between one-line summary and description
630:5: E266 too many leading '#' for block comment
635:14: E126 continuation line over-indented for hanging indent
661:69: E502 the backslash is redundant between brackets
674:5: E266 too many leading '#' for block comment
675:5: E266 too many leading '#' for block comment
679:32: E261 at least two spaces before inline comment
702:1: E302 expected 2 blank lines, found 1
721:1: E302 expected 2 blank lines, found 1
721: D103 Docstring missing
730:1: E302 expected 2 blank lines, found 1
747:1: E302 expected 2 blank lines, found 1
755:72: E502 the backslash is redundant between brackets
756:20: E127 continuation line over-indented for visual indent
756:44: E231 missing whitespace after ','
760:35: E261 at least two spaces before inline comment
771:1: E302 expected 2 blank lines, found 1
793:50: E231 missing whitespace after ','
799:1: E302 expected 2 blank lines, found 1
812:48: E231 missing whitespace after ','
818:1: E302 expected 2 blank lines, found 1
829:1: E302 expected 2 blank lines, found 1
835:1: E302 expected 2 blank lines, found 1
841:1: E302 expected 2 blank lines, found 1
847:1: E302 expected 2 blank lines, found 1
847: D400 First line should end with '.', not 'e'
847: D205 Blank line missing between one-line summary and description
864:5: B901 blind except: statement
867:1: E302 expected 2 blank lines, found 1
867: D400 First line should end with '.', not 's'
867: D205 Blank line missing between one-line summary and description
876:23: E127 continuation line over-indented for visual indent
944:5: E266 too many leading '#' for block comment
950:64: E261 at least two spaces before inline comment
951:13: E128 continuation line under-indented for visual indent
952:13: E128 continuation line under-indented for visual indent
952:61: E261 at least two spaces before inline comment
953:13: E128 continuation line under-indented for visual indent
954:13: E128 continuation line under-indented for visual indent
955:13: E128 continuation line under-indented for visual indent
956:13: E128 continuation line under-indented for visual indent
957:13: E128 continuation line under-indented for visual indent
957:21: E261 at least two spaces before inline comment
964:5: E266 too many leading '#' for block comment
1014:5: E266 too many leading '#' for block comment
1037:9: E266 too many leading '#' for block comment
1048:5: E266 too many leading '#' for block comment
1052:29: E127 continuation line over-indented for visual indent
1054:30: E127 continuation line over-indented for visual indent
1108:16: E203 whitespace before ':'
1111:20: E127 continuation line over-indented for visual indent
1113:91: E502 the backslash is redundant between brackets
1114:28: E127 continuation line over-indented for visual indent
1116:67: E502 the backslash is redundant between brackets
1117:33: E128 continuation line under-indented for visual indent
1117:80: E502 the backslash is redundant between brackets
1118:15: E127 continuation line over-indented for visual indent
1180:16: E203 whitespace before ':'
1181:17: E203 whitespace before ':'
1183:99: E502 the backslash is redundant between brackets
1183:26: E203 whitespace before ':'
1184:29: E127 continuation line over-indented for visual indent
1185:58: E502 the backslash is redundant between brackets
1186:71: E502 the backslash is redundant between brackets
1188:58: E502 the backslash is redundant between brackets
1189:72: E502 the backslash is redundant between brackets
1191:58: E502 the backslash is redundant between brackets
1192:75: E502 the backslash is redundant between brackets
1194:63: E502 the backslash is redundant between brackets
1195:64: E502 the backslash is redundant between brackets
1197:61: E502 the backslash is redundant between brackets
1198:66: E502 the backslash is redundant between brackets
1242:1: E302 expected 2 blank lines, found 1
1242: D400 First line should end with '.', not 'r'
1242: D205 Blank line missing between one-line summary and description
1266:1: E302 expected 2 blank lines, found 1
1266: D200 One-line docstring should not occupy 3 lines
1278:1: E302 expected 2 blank lines, found 1
1278: D400 First line should end with '.', not 'y'
1278: D205 Blank line missing between one-line summary and description
1297:1: E302 expected 2 blank lines, found 0
1297: D401 First line should be imperative: 'Return', not 'Returns'
1297: D200 One-line docstring should not occupy 3 lines
1315: D400 First line should end with '.', not 'e'
1315: D205 Blank line missing between one-line summary and description
1332:1: E302 expected 2 blank lines, found 1
1332: D400 First line should end with '.', not 'L'
1332: D205 Blank line missing between one-line summary and description
1368: D400 First line should end with '.', not 's'
1368: D200 One-line docstring should not occupy 3 lines
1375:1: E302 expected 2 blank lines, found 1
1375: D400 First line should end with '.', not 's'
1375: D200 One-line docstring should not occupy 3 lines
1383: D400 First line should end with '.', not 'd'
1383: D200 One-line docstring should not occupy 3 lines
1391: D200 One-line docstring should not occupy 3 lines
1399: D200 One-line docstring should not occupy 3 lines
1407: D200 One-line docstring should not occupy 3 lines
1408:43: E128 continuation line under-indented for visual indent
1417: D202 No blank lines allowed *after* function docstring, found 1
1420: D203 Expected 1 blank line *before* class docstring, found 0
1420: D204 Expected 1 blank line *after* class docstring, found 0
1420: D400 First line should end with '.', not 'l'
1530: D290 White spaces around docstring should be trimmed.
1530: D400 First line should end with '.', not 's'
1536:9: E266 too many leading '#' for block comment
1543:5: E266 too many leading '#' for block comment
1577:9: E266 too many leading '#' for block comment


added stylesheet


Extra empty line detected at class body beginning.


Extra empty line detected at class body end.


Extra empty line detected at block body end.


Great, thanks!


If we already know the step is rejected, why does this function even get called?

It seems to me that there are now multiple parts of the code handling step rejection.  Let's bring them together.


Please remove the BUG_ON macro and instead use plain `if (...)`. If you want you can put the error cases using the `unlikely(...)`, to save a few cycles.


Can you split the compass addition to the core, and the driver patches?


Method missing is probably a good enough error.


This function probably shouldn't get called at all if dt_variable == False.


We probably want to apply an epsilon here. Not sure what error margin we should use though.


This condition makes the one above it redundant.


I would prefer `empty()`, but since "this is only a test"TM it doesn't matter much.


I will have to use dwarf again. Could you merge this patch please?

The current code to perform the sign-extension erases the last byte of the encoding which makes it return -1 when there is a single byte of encoding.

Proof:

Current code:
let temp = acc .|. (clearBit byte 7 `shiftL` shift)
[...]
temp .|. ((-1) `shiftL` shift) -- returned value in the signed case

By substitution:
acc .|. (clearBit byte 7 `shiftL` shift) .|. ((-1) `shiftL` shift)

Distributive law of `shiftL` across (.|.):
acc .|. ((clearBit byte 7) .|. (-1)) `shiftL` shift)

(-1) is 11111..1111b:
acc .|. ((-1) `shiftL` shift)

When shift=0 (e.g. single byte of encoding case):
acc .|. (-1)

(-1) is 11111..1111b:
(-1)

My patch fixes this.


I don't understand this. Could you split it up and explain why this is necessary in the commit log?

Also, please fix your editor's indentation...


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1166 of 1166 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.77%25-green.svg)


Seems like incorrect assignment operator


Space before parenthesis.


Indentation.


Since the three defines here are macro's I guess they should be in UPPER CASE?


This is nice....


What is the reason for this change?


Indentation still wrong here.


Will this value be used somewhere?


This and the next line are repeated on line 28, 29 just below. Remove two of them please.


Indentation wrong here.


This I already applied earlier. Hence you need to rebase your changes against the latest revision and then send me another pull request


Just a few minor comments, in general I think this is a good cleanup and we should merge this back to optee_linuxdriver as soon as possible.


I think it should be "reversed", not "reverted".


done


I'm assuming this change was not intended?


This variable shouldn't have anything to do with LMMs...


Code is for the paper
"on the sampling strategies of evaluation of the joint spectral-spatial information based classifiers"

Author: Jie Liang  jie.liang@anu.edu.au


Custom module to edit all bean fields


@helgi The problem is that the name is used for the file name - and apt applies the above regex as a glob to find the files it'll load. From `apt_preferences(5)`:
```
 The files have either no or "pref" as filename extension
       and only contain alphanumeric, hyphen (-), underscore (_) and period
       (.) characters.
```


I agree with Stefan's notion of not committing such structural changes to
master without prior discussion.

I do agree with Gabriel's suggestion of including the definitions of the
(scala) examples in the main compilation, mostly because it makes it
possible to use the example code in tests without code duplication. I would
like it as well if *all examples* (not only the scala ones) existed only
once in our git repository (tape.xml.gz, for example, exists twice).

> From the user perspective it is not relevant of what category an example
> is. He will expect all the examples at the same place: the
> examples-directory. Having some imported per default and some not is only
> confusing.
>
The point could be made that the distinction is very simple: The examples
which are imported by default are exactly the examples that are written as
Scala code (i.e. those presented in files ending in .scala).

Another solution to the problem of presentation to users would be to have a
script producing, from our git repo, an end-user package with a different
structure (then e.g. all the examples could be presented in the way that is
most suitable for end-users).

Best,
Daniel


This produces e.g.: error: variable-sized object ‘test’ may not be initialized


Isn't this redundant because the connection encoding is set here: https://github.com/rstats-db/RMySQL/blob/4afa2cbe1040f9f207d47aaf1e0f43449e43c0a1/src/MyConnection.h#L32 ?


@alexmarsev: Array need to have the same order as enum, but I think we can keep track of that. I wanted to make it data member but because of https://msdn.microsoft.com/en-us/library/dn793970.aspx it is just a mess. And I think it doesn't matter much anyway.


i have to a one question


Are you going to do a PR? :+1: