I'm more fond of braces than some of the other folks around here.  I think that braces would make it easier to read the intent of this two-line `if` and less likely to break when maintained.  I'm just sharing my perspective.  Make your own call.


Ok, lets ShipIt™


I have implemented this another way. You implementation would not update the session.

Thanks for your pull request though have used update statement instead when session is already there.


@carlosescri take notice of this commit


line 91.
In the documentation of `homogeneous_gamma_process` function


[R/sumstat_dna.R:5:11:](https://github.com/paulstaab/coalsimr/blob/77edf71fb375b61ffbe90c5139b73c7f08cc9ea8/R/sumstat_dna.R#L5) *style:* **Put spaces around all infix operators.**
```r
      dna <-parse_sg_output(files,
          ^~~
```


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The braces here make it easy to see what's going on.


OK, this at least shows me *that* an error occurred. It would be slightly friendlier to explain what it means if an error occurs (viz: That the script can't generate a report just now).

```
ERROR : [Exception... "Failure" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: file:///Users/albert/SeattleTestbed/SEMESTER_PROJECTS_2015/AdvancedProject/jquery-1.11.2.min.js :: .send :: line 4" data: no]
```


You could use `goog.events.listen`.


And you can even use `goog.events.unlistenById`.


I already talked to Shawn Neal on how to return my commits to the main repo.

The most of my changes (copying a script to the remote system before execution) might overlap with the functionality of the separate winrm-fs gem and should not be placed in the winrm gem.

Some smaller commits (especially the encoding stuff) should most likely be integrated in the main repo - but I need to test them thoroughly first for other use cases (ie when running the winrm gem on windows) before I create the pull request.


E.g. https://github.com/ufo-kit/tofu/tree/defaults-alternate


fix in https://github.com/mangix/nbalive/commit/64b0c502ec00cd41fb099fd29df47dffbfa75028


Please don't embed styling into markup like this - add a class instead.


Oops, I copied an existing field + comment, and changed the field name but forgot to change the comment.


Is it dying because of the string allocation? What is -3 exactly?


Cool !


derp, thx


Yes that is correct. I was trying to change as little as possible when doing this originally.

I think the change you have should be fine for iOS.


not found. an intentional error demonstration purposes
On Mar 10, 2015 11:24 AM, "John Haley" <notifications@github.com> wrote:

> Is it dying because of the string allocation? What is -3 exactly?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nodegit/nodegit/commit/ab2b9d9138492295184aeb8268590e8293547b39#commitcomment-10122752>
> .
>


I'll give this a whirl tomorrow and try to integrate it. Anyone else see an issue with integrating this? I tried setting up the explained scenario and it does fail for me locally and works with the patch.


add curlies to if statement, space after comma before username.


Okay, that's a change from last time I tested (which was not terribly long ago!); previously, packages not yet with a stable 1+ version were considered dev versions, and you could only install dev versions if you also added their dev dependencies directly to your project (we had all sorts of issues around this before we tagged Apigility as 1.0-stable). I must say, I'm happy with the change, as it will simplify a lot of install instructions!

Mind sending a PR to change the install directions, @harikt ?


yup, that looks more correct too. thx!


curlies.


Thanks I'll pass this on to the guy who does my coding.

Bob Beroza
Sent through my iPhone 6

> On Mar 10, 2015, at 2:44 AM, Dave Reed <notifications@github.com> wrote:
>
> If you have an app in the App Store, presumably you either are a developer or know a developer (i.e., the person who wrote the app that you're checking sales for) so check with them for help.
>
> > On Mar 10, 2015, at 12:43 AM, RBConsulting <notifications@github.com> wrote:
> >
> > Sure, that's easy for you to say. I'm not a programmer.
> >
> > Maybe I'll give it a try and hope it doesn't blow up LOL
> >
> > Bob Beroza
> > Sent through my iPhone 6
> >
> > > On Mar 9, 2015, at 6:49 PM, Dave Reed <notifications@github.com> wrote:
> > >
> > > No, it's just a few lines of code as you can see by following the link. Clone the repository (you can clone my repo if you want since it has those changes) and compile and build it.
> > >
> > > > On Mar 9, 2015, at 8:02 PM, RBConsulting <notifications@github.com> wrote:
> > > >
> > > > Did you post a completed file that is zipped, that I can download?
> > > >
> > > > Bob Beroza
> > > > Sent through my iPhone 6
> > > >
> > > > > On Mar 9, 2015, at 4:44 PM, Dave Reed <notifications@github.com> wrote:
> > > > >
> > > > > Just tried it on my iPad. This is the error I was getting:
> > > > >
> > > > > 2015-03-09 19:31:45.015 AppSalesMobile[285:26334] *** Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [35.5 nan]'
> > > > >
> > > > > I set an Exception breakpoint in Xcode to find where it was and did a hack to fix it. See code here:
> > > > >
> > > > > https://github.com/dave256/AppSales-Mobile/commit/4fb1d1d48eda7a2415f49bfffe9f071ade1b0b44
> > > > >
> > > > >
> > > > > > On Mar 9, 2015, at 5:50 PM, RBConsulting <notifications@github.com> wrote:
> > > > > >
> > > > > > Thanks Dave
> > > > > > I have been using App Annie but I really like AppSales better.
> > > > > >
> > > > > > Please let know if you figure it out.
> > > > > >
> > > > > > Thank...Bob Beroza
> > > > > > Sent through my iPhone 6
> > > > > >
> > > > > > > On Mar 9, 2015, at 1:59 PM, Dave Reed <notifications@github.com> wrote:
> > > > > > >
> > > > > > > It still works on my iPhone 6, but stopped working on my iPad a while ago (sometime last fall I think).I haven't looked into why.
> > > > > > >
> > > > > > > —
> > > > > > > Reply to this email directly or view it on GitHub.
> > > > > > >
> > > > > > —
> > > > > > Reply to this email directly or view it on GitHub.
> > > > > >
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub.
> > > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub.
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub.
> > >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


space after comma.


I happened upon this site because I noticed activity other than My Own. Being a novice to cyber testing on random computers thought kitty might sniff around.No worries my pointed ears have been educated at home by these friend or foe..? Led to educational sites since July2014.can't beat them might as well join them and learn by them.


commit abdessemed


[R/sumstat_dna.R:5:11:](https://github.com/paulstaab/coalsimr/blob/3e622faf206fafbfcb983eb9c3f4a111735733e9/R/sumstat_dna.R#L5) *style:* **Put spaces around all infix operators.**
```r
      dna <-parse_sg_output(files,
          ^~~
```


Again it's my misconception of your goal. I haven't been looking at this anything but an eye only form, trying to NOT break an install used for other purposes.  Breaking sections out for general use will require separate forms wouldn't it?  I don't really understand how others (ie not eyedocs) will use this code yet. I will change my thinking towards this goal and look at the extra SQL-column option.


I just wonder why you are so against these static constants? It's just 6 extremely small objects which should take just several bytes in the RAM. I always thought, that ability to do this kind of optimisations is one of the main reasons to create all these static factories in the first place.

Just to support my argument, here is what Joshua Bloch has to say about it (and also described int in the effective java):

> A second advantage of static factory methods is that, unlike constructors, they are not required to create a new object each time they’re invoked. This allows immutable classes (Item 15) to use preconstructed instances, or to cache instances as they’re constructed, and dispense them repeatedly to avoid creating unnecessary duplicate objects. The Boolean.valueOf(boolean) method illustrates this technique: it never creates an object. This technique is similar to the Flyweight pattern [Gamma95, p. 195]. It can greatly improve performance if equivalent objects are requested often, especially if they are expensive to create.

http://www.informit.com/articles/article.aspx?p=1216151


The underscore was pre-existing (e.g. TcpListener::TcpListener), so I figured it was to prevent shadowing close().


@grahambell can confirm but I thought that the automatic link between the OMP and CADC had been broken? (although I have no idea how data access happens now).


@vcunat the solution is to add `libIntlOrEmpty` to the failing package, but I don't have time to do that right now


@sravfeyn I was envisioning something like this.  I don't like the increased computation (this iterates through all users and sends a big list of matching user ids to elasticsearch), but if we really can't rely on the case properties, I'm not sure what choice we've got.


+1 for this behaviour, but consider that the current firmware implementation is using the old behaviour of sending a zero torque after the switching.


why not :) .

*Hari K T*

You can ring me : +91 9388 75 8821

http://harikt.com , https://github.com/harikt ,
http://www.linkedin.com/in/harikt , http://www.xing.com/profile/Hari_KT

Skype  : kthari85
Twitter : harikt

On Tue, Mar 10, 2015 at 8:57 PM, weierophinney <notifications@github.com>
wrote:

> Okay, that's a change from last time I tested (which was not terribly long
> ago!); previously, packages not yet with a stable 1+ version were
> considered dev versions, and you could only install dev versions if you
> also added their dev dependencies directly to your project (we had all
> sorts of issues around this before we tagged Apigility as 1.0-stable). I
> must say, I'm happy with the change, as it will simplify a lot of install
> instructions!
>
> Mind sending a PR to change the install directions, @harikt
> <https://github.com/harikt> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/phly/http/commit/7720309c476cc62815692f520a64b1ff58fb31ab#commitcomment-10122807>
> .
>


23:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from flask.ext.registry should be before import pkg_resources


@sfgraves I am confused by your comment. The primary URL for accessing Starlink docs should be through `www.starlink.ac.uk` and not the EAO URL.


Ignore me. You are referring to @dsberry 's comment and not the patch itself.


@weierophinney one of the problem if you have noticed with apigility would be not tagging the dependencies repo. So it may be having a dependency on another dependency which is looking for some dev- branch.


Elegant! Thanks!


@amgiorgi ,
ODocument is Derived from Dictionary<string,object>

you wellcome


Looks good


It's a tiny thing, but in this and the next method you might as well have a one line `return soup.find('div', id='profile')` or whatever...


No, I'm saying I think DOMString[] uses reference semantics. AFAIK it's for typed arrays, array buffers, those kinds of things. You want to return a sequence here. Sequences are copied, so modifying them is harmless.

Returning an array with guarantees in prose that there will be no repeats, seems inferior to using the right data-type, especially when the whole point is to learn what the dictionary supports. An array with prose can mimic any dictionary, yet somehow we still have dictionaries.

Since I've advocated strongly for using the same dictionary throughout, I find it hard to swallow the reason that we're abandoning dictionaries because of the cost of re-specifying marginally different versions of them. Something about cake and eating.


This will come in with the next merge


Similarly, there's no reason to assign to former_positions before returning it


@sanyalj @mbadams5 This needs to be compiled with -fPIC on UNIX (NOT APPLE?) since it eventually gets compiled into a shared library later.  That is if this library even lives in the final version...


Any particular reason why you didn't leave the sparse check here and add you nan_to_num afterwards. In some sense the checks were kind of ordered, i.e. kwargs stuff first, then adjacency_matrix checks, etc ...


Change is in editors-pick ef02a0c


because tests using sparse adjacency matrices failed otherwise.


while at it, we could get rid of the `SRCS` variable and directly set `libgeany_la_SOURCES` now you properly extend it instead of setting it to completely different values.


Or for portability, simply replace that line with:

```ruby
File.write 'CNAME', ruhoh.config['production_url'].gsub(%r{^https?://},'')
```


This is one that I am specifically testing because it doesn't seem to get sent through to searchisko.


Well, I have advocated the same as you have, so I share your pain :)

as you might have seen, I have another PR that re-uses MediaTrackSettings, which I would be happy to see adopted. This PR is offering an alternative in case it isn't.

I could provide a third PR with a different name for the same structure; but *that* might be more than I can swallow :)


Why did you remove __construct ?
It's not so useful now. I have to add two lines for initialize:
```php
$lumberjackHandler = new LumberjackHandler();
$lumberjackHandler->init(
            '127.0.0.1',
            '5000',
            '/test.crt',
            [
                'window_size' => 5000 // window size - wtf ?
            ]
        );
```


Sure will do!


saw approval from andrewjstone
at https://github.com/basho/clique/commit/a646e7ffbbbef7b4af80431cdecd39094b0d44dc


merging basho/clique/feature/json-writer = a646e7ff into borshop-integration-47-feature/json-writer


basho/clique/feature/json-writer = a646e7ff merged ok, testing candidate = ac00915b


this comment should probably stay right after the  conditional (`if MINGW`)


`tru` to `true`


i dont think these two (API and Gateway lines) are guaranteed to be in order.


trailing whitespaces on the 2 lines above


As has been noted in #328 the `redirect_url` may not exactly match the `baseurl`. Perhaps check if the URI part of the URL starts with `/queue/item/` and be happy with that.. ?


Weird... too bad.


@case-eee where would be extract this to? Thanks!


не не, это дыра, человек сможет тогда менять владельца объявления указывая его просто в html коде.
Это надо заполнять на стороне ItemsController перед сохранением через current_user


Apart the few comments, looks nice :)


This is a wXf module that attacks (bruteforce) the login page of Damn Vulnerable Web Application (dvwa.co.uk). It requires a userlist and a password list text file to do so. Results are confirmed with Hydra and saved to log file.
![options](https://cloud.githubusercontent.com/assets/11378310/6578364/71d4e836-c74c-11e4-9254-5748a2a75aff.JPG)

![wrong1](https://cloud.githubusercontent.com/assets/11378310/6578380/8610903e-c74c-11e4-82d4-f453d14ab589.JPG)

Runs on Kali Linux.


можно 4 строки через resources сделать


Can you point me to an example code? If I understand right, you want me to leave a space between if and condition as if (...)
  {
  }
right?


Looks good, adding this to v3.0.


@domoritz I'll need to wrap the current projects `ul` in a `div` with an id or class (or assign an id to the `ul` itself).   You mentioned including a separate markdown file for this -- is this the best approach?  If so, could you point me to the  syntax for doing so?


Addressed to capture in stream in stringstream and record in error log as debug level.


r+

I see we've got WPT tests for this, so the lack of a reftest shouldn't be a problem. Thanks!


table sort plugin 이 있었군요 ^^
멋지네요


Create a cookie if there is none and store it in cookie.


button type button?


TeamCity Yandex QATools :: aShot :: pull-request-build [Build 16 [???]](http://teamcity.qatools.ru/viewLog.html?buildId=2158&buildTypeId=yandex_qatools_ashot_PullRequestBuild) is now running


saw approval from pcwalton
at https://github.com/mmatyas/servo/commit/c98bca6130c8f0bedd4f24954e5e2fdbf2af81d5


merging mmatyas/servo/canvas_arc = c98bca61 into auto


mmatyas/servo/canvas_arc = c98bca61 merged ok, testing candidate = e8f1a046


TeamCity Yandex QATools :: aShot :: pull-request-build [Build 16 [1.4.7-SNAPSHOT]](http://teamcity.qatools.ru/viewLog.html?buildId=2158&buildTypeId=yandex_qatools_ashot_PullRequestBuild) outcome was **SUCCESS**
Summary: Tests passed: 12 Build time: 0:0:0


ᕙ༼ಠ͜ʖಠ༽ノ


> Do you want to use them standalone [...]?

Yes!


It would still need to be loaded again once that function is available. It's complicated by the fact that dependency management is Wordpress is terrible and you could feasibly be using composer and thus loading this package in the development of both a site and a plugin, which makes this difficult to solve on a composer level.


### ༼つºل͟ºς༽


First change and commit.


@stuartc , we were getting weird/bad logic because the ODK form and the SF.com form didn't pass any "plan" value through.

Now, I'm stuffing the user's plan into both forms. This isn't good, but fixes the bug in production (which was only occuring when an existing free user tried to update their ODK or SF.com credentials.)

We should change the script on the form page so that it doesn't try to contact Stripe when it gets no plan variable at all, but I don't know how to do that so I'm fixing it this way for now. Make sense?

(I tried out your fixes, and while I'm sure they're way more comprehensive, they introduced some other bugs that we'll have to iron out and this blog post is now out of my hands so I need to get it stable ASAP.)


Ok. I'm confused then.  Can you give me a quick line of code of what you mean? The fixer does not remove commas at all, as far as I understand it.  I thought you meant you wanted me to show that it does not remove commas, so I added those tests.  If you can just give me a little snippet of PHP to show what you're after, that would be great.


Awesome! Thanks!


@gonemad83 this is great! I especially love the AllRecipients helper, would be very useful. We're going to take some time to review this and I think some unit tests are also needed but I don't see any reason we don't have this to the library. I appreciate your help making this better!


erratum: fixer will remove that **space**


all tests pass:
success: http://buildbot.bos1/builders/test-clique/builds/52


Commentaire sur le commit.


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.16%25-red.svg)


@mpalmi


Do you mean celery**d**?


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.38%25-red.svg)


I see your point, but I still can't see the benefit. So okay, these are not giving problems with state changes, so that's most of the Singleton problems out. And these are also really small, so it shouldn't bother in memory. So it is purely a "memory space + coding style" vs "performance improvement" discussion.
How often is this class instantiated? Maybe if we see when it is really used, it will be easier to agree on this.


Think this error message needs to be rephrased. Realized you didn't put in originally but would be good to clean up: "Cannot updated catalog entry because source is unavailable:"


A possible alternate that can reduce code repeat in these functions. Just an idea...

T const tmp (v);
return (v = get (section, name, v)) != tmp;


Alberto Fuentes Muñoz


Please review this, @casey-collab


Alright, sorry :)


I don't understand what all this extra checking is trying to achieve except slowing down compilation time of a very basic function.


Good. Then let's not mix things up and use the commit I made. Then you can do:
```python
args = TomoParams().get_defaults()
```
which is not so horrible I hope and one be happy with the `Namespace` without additional garbage. Plus the behavior is consistent with the usage with parsers.


Maybe use ```if params[:order].present?``` here as this works with a variety of types.

```ruby
[16] pry(main)> {}.present?
=> false
[17] pry(main)> [].present?
=> false
[18] pry(main)> "".present?
=> false
[19] pry(main)> nil.present?
=> false
```


I'm not a big fan of submodules and would prefer if we could all collaborate here in this repo.

@DandyDev: Perhaps you might consider periodically pulling in commits from this repo to avoid inadvertently overwriting changes in the future? (If you disagree with a particular change here, of course feel free to revert it.)


created  new repository for china location


FYI @jrubenoff: This broke `.drop_rich`. I am fixing, but it would be great to figure out an architecture that can better help us avoid these bugs in the future.


The description looks off.


Done in branch.


indObj is incorrect name. "ind" prefix is not for iterators, please use "i" prefix. But iObj is also bad because "Obj" is meaningless. I suggest "iEllTube" and "nEllTubes". Please use meaningful names down the road.


because to much arguments for constructor.

before this change you should write code like this:
```
$lumberjackHandler = new LumberjackHandler(
    new Lumberjack\Client(
        new Lumberjack\SecureSocket(
            '127.0.0.1',
            '5000',
            array('ssl_cafile' => '/test.crt')
        ),
        new Lumberjack\Encoder(),
        5000
    ),
);
```
I think this is very ugly.

We can find a compromise - I can add `return $this;` to `init` method and you can write code like this:
```
$lumberjackHandler = (new LumberjackHandler())->init(
    '127.0.0.1',
    '5000',
    '/test.crt',
    [
        'window_size' => 5000 // window size - wtf ?
    ]
);
```


you could just write a "normal" method within your controller file!  OR you could write a helper method that takes an argument (params[:user_id]) ?

so if this was in your helpers file:
```ruby
def check_user(user_id)
  session[:user_id] == user_id
end
```
on this line 89 we could just make a call to this method:
```ruby
check_user(params[:user_id])
```


pathes are a good example of config.
but ajax function is not - it is an utility method


Ancestry adds a method path as said in the documentation [here](https://github.com/stefankroes/ancestry#navigating-your-tree). I had to rename it.


And I'm sorry for incompatible change in patch version =((


Shouldn't we just log this, instead of throw an exception? Or does the parent of this script already do that?


"no newline at end of file"


isHidden ;)


What the hell is this page? :confused:


Any reason this is on both sides of the if/else instead of just at top scope?


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (604 of 604 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-2.91%25-green.svg)


This looks really good (from Holly)


I came up with the same conclusion and implemented it already.
I found out that at least mysql and postgresql support this.


r+


It needs to be opt in as this won't work on OSX.


More importantly, where are those closing tags @benfoxall ?


Add a test for this bug?

(How was this not causing major problems? Is it used anywhere?)


Looks quite good, will have a look too.


Right then.

Where exactly is a consolidate going to happen? How are they triggered?
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


If you would like to make a simple queue then I don't mind. More threads = more sources of bugs is right, if they are sharing similar resources. Far as I know the ClientThread hasn't been a problem so far, what bugs have you notice from it?


redundant code; previous line already convert s$Time column to the required date and time format


For Sound Channels 1-4, I think going with GBE's old method (basing wave generation on the host computer's clock at a set frequency e.g. 44100) is acceptable. Previous attempts at cycle-based audio processing have gone awry so far. It's something that can be revisited in the future.


Turns out that register allocation in TeX is inherently a global process and so multiple calls of `\new...` end up reserving multiple registers.  All those `\new...` inside of macros, therefore, is a very bad idea as the number of registers is limited (you might run out in larger scores).  I'm going to have to reverse or revise much of this commit.  I'm working on the best way to do that.


this check is unnecessary. Saves nothing.

We only need these checks if we're doing costly code inside like converting objects to string or iterating over collections, etc.


e.g., this check is arguable saving work.


I'm not sure what having the separate `libfactersrc` is doing here, vs. just building libfacter. I don't see any properties unique to the `src` lib, and there are no new sources added to libfacter. Is this just a way to isolate compile and link flags?


So you want to downgrade this message so we don't see it in production? Is that desirable?

(Does it not hint at a bug?)


Wait, I see it gets used later on in the test exe. Nevermind!


yeah, renaming would make it more clearer.


I am trying to get this running with the latest pyload version but it seams that the serienjunkies plugin has been removed. Is there a way to fix this?

https://github.com/pyload/pyload


This is an object library, which allows us to link in the object files into two different CMake targets: libfacter and libfacter_test.  This allows us to test hidden code on platforms that we're not exporting hidden symbols from libfacter (i.e. libfacter_test no longer links against libfacter.so, but links in the object files directly).


Are you sure the new approach works in practice? I wonder because at that point in time things like /dev and /proc are not mounted, if I am not mistaken.


#PerformanceReasons


uTest is needed to test scala.js code. There are only a few tests, which serve to check that the semantic differences between scala and scala.js don't change the output of the parser.


in upgrade.php this exception is catched and upgrade.php will not start if there is no default alias (there must be default alias). When we install newscoop it by default creates default publication and default alias.


The problem isn't with subsequent calls to `connect`. I only call connect once and get the crash so this check unfortunately won't guard against it.


1) The following names are not compliant with the coding convention:
ReachContObj, ControlFuncObj, trajectory
2) Constants are not defined properly : 1.0e-5 is still hardcoded
3) odeResMat should be renamed into something more meaningful


Funky indentation -- can't tell if `previous_readpart` assignment supposed to be part of the `if (fpse) ...`


This change is just making the default explicit.  So there is no visibility change here, it was always `Public`.


Well I find it very difficult for people to collaborate when the "manager" of the repository is another person with another repository (who may revert changes here).

Wouldn't it be more clear for collaborators to state that contributions shall be made as pull requests to the repository of @DandyDev ?

Indeed Guidelines for contributing do not mention anything about other repositories (https://github.com/getpelican/pelican-themes/blob/master/pelican-bootstrap3/CONTRIBUTING.md)

I'd suggest to officially maintain the package at @DandyDev 's, stating in the contributing guidelines that changes to the package shall be sent as pull requests to him. What do you think?


No, I've not given any thought to conversions within Brainbrowser itself, but I agree that support for .nii.gz is useful.


This is better also.
Remove 'energy', it is only worth mentioning energy costs to users when that cost is significant.
Remove the space at the beginning of each line (132, 133, 134), it is causing these lines to indent on the text view.


Done.


Nice!


Sure? Nope, but it's better than doing nothing IMHO and shouldn't do any harm. (I'm not really happy about the cleanup procedure as it is, but we need to minimize the changes to have a chance for inclusion in jessie at all.)


Good catch. May not target a local statement.


Dang, you beat me to it! Thanks :)


So I’ve been trying to get the team to have fewer commands, not more.

I see two problems here. One is that the entire DriveDistance command that this was based on is untested. The new variant just compounds that problem with more untested code and given where we are now, we will likely not have time to test. DrivePID is at least tested. The PID values are untuned, but we know that a DriveP of 0.3 or so (and all else zero) will give us a reasonable speed with maybe a centimeter of overshoot. So I would recommend that the turn commands simply use DrivePID(-x, x) (for a clockwise turn), where X is the value in radians multiplied by the distance between the left and right drive wheels. Unfortunately, I don’t know that value, although I see that Ryan made appropriate use of the rand() function as a substitute here, as instructed.

I’d have a lot more confidence if the encoders on the test bot were reliable enough to do meaningful testing.

From: coachFitz0807 [mailto:notifications@github.com]
Sent: Tuesday, March 10, 2015 8:11 AM
To: ligerbots/RecycleRush2015Robot
Subject: Re: [RecycleRush2015Robot] We now have some autos which work nicely! (60d4bcb)

This is wrong. distanceTravelledR is only a function of the encoder value. Scaling it by an input value is not correct.
It looks like you're trying to allow it to command each side differently so we can use one method to turn or drive straight, although I can't tell because there are no comments anywhere. I don't like this. The logic is much easier if we use this method to drive straight and another one to turn. We're not good enough to make an arc.

—
Reply to this email directly or view it on GitHub <https://github.com/ligerbots/RecycleRush2015Robot/commit/60d4bcb51c0e1ea16044ed9a126988e3c1c3f51b#commitcomment-10118841> .  <https://github.com/notifications/beacon/ABenTo9Syy60X5-9Jj8aZ2gWsPXys2Qbks5nztbMgaJpZM4DsQNc.gif>


hi i tested it and get the following error:
/usr/local/rvm/gems/ruby-2.2.0/gems/darwinning-0.0.3.pre.float/lib/darwinning/gene.rb:8:in `each': can't iterate from Float (TypeError)
	from /usr/local/rvm/gems/ruby-2.2.0/gems/darwinning-0.0.3.pre.float/lib/darwinning/gene.rb:8:in `to_a'
	from /usr/local/rvm/gems/ruby-2.2.0/gems/darwinning-0.0.3.pre.float/lib/darwinning/gene.rb:8:in `Array'
	from /usr/local/rvm/gems/ruby-2.2.0/gems/darwinning-0.0.3.pre.float/lib/darwinning/gene.rb:8:in `initialize'

it seems using value_range wont accept floats, mainly beacuse of the array


Good catch. Fixed.


Its working but getting following error in logs

ERROR:siptrace:pipport2su: bad protocol
ERROR:siptrace:pipport2su: bad protocol
ERROR:siptrace:pipport2su: bad protocol


Just a trial


Commit message should be "WDI San Francisco 2015-3-16 :: Steven Gordon"  However, I committed this code before reaching Section 6 of Fundamentals.  Sorry!


@jtreanor mmh, ok. It certainly fixed an issue with the crash we seeing with the steps you give us to reproduce on #9. Do you run the WebSocket server when you are testing with the link conditioner? I guess I'm having trouble tracking down the issue with crashing on the first connect, as that is working ok for me. Can you think of any other variables that might be different between my test environment and yours?


This seems wrong for the last clause.


Agreed.


@miguelportilla If the section has a key/value pair that matches the default, then we get the wrong return value. i.e. There is a key/value pair `S=0`. If the initial value of v is 0, then the function returns `false` even tho the value was stored in the section.


Ah, I missed the multiple PR bit. Makes sense.

I hate to say it but, since the method is called getSupportedConstraints rather than getSupportedCapabilities (which I voted for!) or getSupportedSettings, then returning a MediaTrackConstraintSet might have a slight advantage in my mind. On a technical note, choosing that would also let us conveniently return truthy values like this:

    { width: {}, height: {}, frameRate: {}, facingMode: {} ...  }

without getting into what the types involved are. That's perhaps a minor issue though, so maybe we'll just keep this in mind as we develop whichever PR we go for.


Does SBUS (100000bps)  work after this change? And xbus?


Why are we not rendering the flash message any more?


What about cases where the token value contains an IP address but does not start with it?


I used something like this before:
```
sudo lsof | fgrep "${MNTPOINT}" | awk '{print $2}' | sort -u | xargs sudo kill -9
```
I wouldn't use that in production maybe, but the approach could work if implemented well.


:microphone:


do we care about the http part?


Closes #1


Alright.


you might want to use classList - https://developer.mozilla.org/en-US/docs/Web/API/Element/classList


1) ind is a bad name in

 ind = find(ellTubeTimeVec <= timeVec(iTime));
+                indTime = size(ind,2);

as "ind " can potentially be a vector.

2) isOdeResInEll  is a bad name in
isOdeResInEll = dot(odeResMat(end,:)'-q1Vec,q1Mat\(odeResMat(end,:)'-q1Vec));

as "is" prefix is only for logical variables

3) {:} in matlab generates a list, here is an example:

>> aList={1,2};
>> aList{:}

ans =

     1

ans =

     2

Thus the assignment
 ellTubeTimeVec = self.properEllTube.timeVec{:};

cannot be correct by definition. We should either take a specific element or take any element (checking that all elements are the same).

ellTubeTimeVec = self.properEllTube.timeVec{1} would not be safe becuase self.properEllTube can have a zero number of tuples. Also, if it does have more than 1 tuple why should be get timeVec from the first one? Please refactor this and similar places.


:ok:


Yeah I have a work item to do a full scrub on this.


No, that's just celery now: http://celery.readthedocs.org/en/latest/django/first-steps-with-django.html#starting-the-worker-process


asfasdfaf


Maybe we should call the alias `djcelery` too?


LGTM.


cc @resmo :) I'm sure you'll like this one


@plalloni Nope, I think it's done unless you see issues. Just wanted you to take a glance at it as you wrote the resource.


Hello,

There is a problem with the calculation in pingdomstatus.rb. Lines 61 and 62 should be:

        uptime = (totalUp.to_f / (totalUp.to_f + totalUnknown.to_f + totalDown.to_f)) * 100
        oldUptime = (totalOldUp.to_f / (totalOldUp.to_f + totalOldUnknown.to_f + totalOldDown.to_f)) * 100

I used the widget and noticed the figures were different from figures in my.pingdom.com
Cheers
Matt.


I am ok with testing against 2 files. One with the API line first and the other one with the Gateway line first.
But as it is a `test_expect_failure` anyway, because the API line doesn't show up on Travis, maybe we can deal with that in another patch or later when we fix the problem of the API line not showing up?


It uses shell globbing


@chaosphere2112 is that still going to work when you loop around? Will it show frame 0 after the first loop is over?


Note that by providing a default value of true, we remove the ability of the UA to distinguish users who desire voiceActivityDetection from users who don't care. In other words: this removes any UA-specific default of AUTO, and effectively mandates that if a UA is capable of such features, then it MUST enable them by default whether the user has requested them or not (i.e. unless the user explicitly turns it off). This may be fine, I just wanted to put it out there. Are such features cost-free even on mobile devices?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/984
success: http://build.servo.org/builders/linux2/builds/983
success: http://build.servo.org/builders/android/builds/1018
success: http://build.servo.org/builders/mac1/builds/1199
success: http://build.servo.org/builders/mac2/builds/1200
success: http://build.servo.org/builders/gonk/builds/170


The particular service noted BV_MetroGIS_AddressEditor is only the data from Burnsville, so the download this week only got 27K of 165K which are in the other service.  Also, ST_PRE_DIR and ST_PRE_MOD are not needed, we do not use them at all in Dakota County.  Those fields should be empty or null.  I'll leave that up to you if you want to leave them, but they are just part of the MetroGIS data model that we don't have a need for.


@themightychris please halp


@brutasse OMFG


Still has tabs.


@ntdb I think this should be 'return [] unless raw'.


79453838-AutomateSomeDocumentation (Myoldmopar) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.31%25-red.svg)


Ignore all the whitespace changes, npm did that automagically when I ran ` npm install grunt-check-dependencies --save-dev`.


Thanks for pointing that out. I switched it because the previous one failed but I can switch it back.


woah ! :+1:
So, each line of product of the order should be checked ?
@fappels some work to be compliant on Mobilid ?


You know that `@@` is just `flip review`, right?  I'd still support giving `@@` it's most general type.  If you think it's important to have both orders, I have no strong objection to `##`, though.


fast-forwarding master to auto = e8f1a046


@ragesoss good catch. I got carried away with Rubocop it seems. :) This syntax is only valid as the last line of a method.


I did so first, but decided to start string with IP as:
1) 95% of string with issue start from ip
2) in rest 5% strings are very complex and contain a lot of staff (they are used in tests)
3) putting "^" excluded such strings as "1111.1.1.1"


In the S Machnes paper it says that the following should be a 'numerically favourable' method
fid_phase = np.conj(fid_pn) / np.absolute(fid_pn)
grad_normalized = np.real(grad*fid_phase) / self.dimensional_norm

I have tested this and it seems to give the same result for check_grad as using:
fid_phase = np.exp(-1j * np.angle(fid_pn))
I have not tested whether it is faster though.

I would also suggest putting the dyn.tau[k]* at the beginning of line 330. That is:
dg_diag = dyn.tau[k]*eig_vec_adj.dot(dyn.get_ctrl_dyn_gen(j)).dot(eig_vec)

Just so it is closer to the representation the S Machnes paper.


@ntdb testing FTW!


@cveneziani tu aurais du faire le changement dans `_partials/rbenv_ubuntu.md` puis lancer `./build.rb` pour générer le fichier `UBUNTU.md`. Je m'en charge :)

(sinon ça écrase ce genre de modifs)


HumidifierSizing_#4688 (Nigusse) - x86_64-MacOS-10.9-clang: OK (1635 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


Boton de sitio


ok


i added http part with "^" (to not skip "http://127.0.0.1"). It is not displayed in message.


@bbockelm Thanks. I agree with your suggestions and will change accordingly.


79453838-AutomateSomeDocumentation (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.25%25-red.svg)


I saw that it failed, I didn't know what I did wrong.  And I'm new to GitHub and didn't have time to go digging into how to contact people properly, etc.  I manager those servers.  Let me know if there is something I can do, within reason of course.


this is an example of how you can use an xpath expression to search for text elements, and then test their text-anchor attributes.


Not really. The information you care about is just the extremes on each axis, but how you store that is another matter. But yes, just the min and max makes a lot more sense.


Did you mean "bais"?


fwiw, note that the latest ScalaCheck also now works with Scala.js


setUp() is more usual


Feel free to e-mail me. If you're logged in to GitHub you should be able to see my e-mail address at http://github.com/iandees.


nah, it does not.


I would like to catch at least URLs like "ftp://127.0.0.1" or "multicast://224.1.2.3:6255".


Yes, that would be better, I can fix it.


Part of #4


this looks like something different than what the paper uses `k` for. Would you mind terribly calling it `i`, which would what the paper calls it?


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: js/messages.php, js/tbl_change.js, js/tbl_changemy.js, libraries/insert_edit.lib.php


Please see the bug here: http://erlang.org/pipermail/erlang-bugs/2015-February/004781.html

In `rebar3` we got around this by disabling the automatic checking of the plt: https://github.com/rebar/rebar3/pull/206


ok, i will remove http and "^" parts from regexp


It's not much but I finally got what I want. CLion is a nice IDE and I really wanted to be able to use it to debug Lua. CLion seems to only accept CMake builds right now. I want to become intimately familiar with the inner workings of Lua; a good way to do that is to step through the code in an IDE.


Общее впечатление — немного усложнено.
Хорошие принципы инженерного искусства: KIS [keep it simple], DRY [don't repeat yourself], YAGNI [you ain't gonna need it].
При этом достаточно много копи-пасты.
Длинные имена, особенно с сокращениями, усложняют чтение кода. [Известная шутка: f u cn rd ths, u cn gt a gd jb n cmptr prgmmng.]
Много предупреждений из -Weffc++, отключи этот флаг пока.

По существу темы хеширования:
1. У тебя много неоправданных хеш-коллизий — это хорошо видно при hash_size, равном степени двойки.
2. Хеш с открытой адресацией может терять элементы.


Yes I'll try and change that.  By the way my skype is valcorinne.
Cheers,
Valerie

On Mon, Mar 9, 2015 at 10:46 PM, Jessica Yuen <notifications@github.com>
wrote:

> Hey Valerie,
>
> Not sure best way to contact you, so hope here is fine. Is it possible for
> you to make the requestee and requester a Author instead of a User? (only
> because the web api will be looking up friends by an author's uuid, can't
> retrieve the info with Users)
>
> Thanks,
> Jessica
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nhubui/CMPUT404-project-socialdistribution/commit/294298b71fda31d90cd8f9b003047ab93a22790d#commitcomment-10113649>
> .
>


Ahhh so it's this. Thanks, was wondering if it was just me.


I saw that. I would love to use it at some point, both for scala.js and compiler testing in general.


Thanks! Will update my article.


It's better to use the built-in special form `save-restriction`, in case there's an error somewhere it will properly recover the session.

Also, if I already have narrowed region, you would "re-narrow" and then widen, breaking my custom selection.  The macro handles that as well.

Use like:
```elisp
(save-restriction
  (widen)
  (narrow-to-defun)
  your-code-here
  ...
  ...)
```


@axelstudios how big a of a pain would it be to get this into 1.6.3?  I get an error on my machine that @rpg777 can't reproduce.  Would be nice to be able to test in an installer


skeleton subsystem still compile in this patch but maybe i should squash a4daca077f00865b47bdf6b7f727a1e4e037f858 and 4ebc4e776b29b6d25025a33bed11ee7aa3c33b20


can you bring that comment on the other PR https://github.com/w3c/mediacapture-main/pull/143? or on the issue itself? https://github.com/w3c/mediacapture-main/issues/116

I think your proposal makes probably more sense indeed. But I think I'll await to hear more from the editors before updating the PR.


@eschlange looks like there's just an off by 1 bug in `git_tagger`. Otherwise, :100:


These are Ben Bolker's changes.


User-facing customization/options should use `defcustom` macro instead of `defvar`.


actually I was wrong, format also rounds just in a different way than round() ?


This `match` makes the code difficult to follow. Doesn't it make sense to check if we should break and compact as part of the `while` loop we are in?


+++ nickbart1980 [Mar 10 15 01:03 ]:
>>> "title-short: TeX" in knuth-ct-b.biblatex and "title-short: METAFONT" in knuth-ct-d.biblatex are incorrect and should be deleted: these are not short forms of the title.
>>The current code extracts a short title from a title, when no short title is provided, by taking the part before the colon. That is why these appear. It actually seems a pretty good fallback to me. Why aren't these short forms of the title?
>Because the CSL title of the Knuth books is “Computers & typesetting”.

OK, I took another look at knuth-ct-d.biblatex.  And there's actually
a shorttitle field in the biblatex entry -- so *that's* why we're
getting title-short in the YAML.  Do you want to remove the `shorttile`
field from the biblatex entry?

My own 2 cents:  METAFONT *is* the short title you'd want if
you were actually citing this.


`assert_nothing_raised` learned from [rails/rails](https://github.com/rails/rails/blob/3aa5beeec7985ca3e4709fdc14bf49dea492d4d2/activesupport/lib/active_support/test_case.rb#L96-L98).


Nice! It'd be interesting to think about how a general DSL for DOM testing would look using [rvest](https://github.com/hadley/rvest), but this looks great!


I haven't made any comments on the changes yet, but generally I think that if we're going to stray away from the "coaching company" guidelines that we set up in the guide, we should not post that extra paragraph under a "coaching company" headline, but maybe under the "and more"..? As in, remove the mention of coaching companies altogether.


This commit was in master already, so I pushed the suggested fixed in there fc15721.


@harikt We were tagging the Apigility repos as we went — we used `0.*` versions as milestones towards 1.0. There have been a lot of improvements in Composer in the last six months; this is likely one of them.


I don't really see the need for that. Locally, it duplicates all entries and making the search for relation twice. If no objection, I'll remove it ?

Also $watch take for watchExpression a String or a function. Not an object.


Общее впечатление от hash.cpp (не только от этого коммита) — немного усложнено.
Хорошие принципы инженерного искусства: KIS [keep it simple], DRY [don't repeat yourself], YAGNI [you ain't gonna need it].
При этом достаточно много копи-пасты.
Длинные имена, особенно с сокращениями, усложняют чтение кода. [Известная шутка: f u cn rd ths, u cn gt a gd jb n cmptr prgmmng.]
Много предупреждений из -Weffc++, отключи этот флаг пока.

По существу темы хеширования:
1. У тебя много неоправданных хеш-коллизий — это хорошо видно при hash_size, равном степени двойки.
2. Хеш с открытой адресацией может терять элементы.


I'm rather close to just merging this in my branch an letting it be for now ;)


This is a pun on `Reversing`.  I think I like it, but these instances are not "a generalized notion of list reversal extended to other containers" as the docs for `Reversing` have it.


I'll follow up in #9


I have trouble getting the distinction here. Why not move the `-W...` arguments to `CFLAGS` too? Someone may want to override them (esp. if they are using a compiler that doesn't know them, such as armcc).


1: M101 signature is missing
1: M111 unrecognized component name: overlay


MIT ftw!


Also made plotting in main.py smarter.


You're right, sorry I suggested it.


How come?


You might want to check out `{{d-button}}` here, it's a lot simpler :)


size_t и double достаточно маленькие типы, их не имеет смысла передавать по константной ссылке — лучше по значению.
При передаче по константной ссылке обращение к аргументам в функции будет через лишнюю операцию разыменования (перехода по указателю).
По константной ссылке имеет смысл передавать большие объекты, которые копировать дорого. Например, контейнеры — string, vector, и т.д.
double плохо подходит для вычислений, где нужна детерминированность результата (в частности, для хеширования).


LVGTM :+1:


ack


Looks sane, I'm afraid I won't have a chance to test till tomorrow.


hm yes unneded newline^^


Probably don't need this


(feel free to merge in the mean time if it's working :) )


Стандартное название — линейный поиск, linear search.


Underscores, yo :P


Also, why `CFLAGS = -O2` rather than `CFLAGS += -O2`? Someone may try calling `CFLAGS='...' make`


then I need to change them everywhere... ack...


Yeah, I thought about it. I guess I prefer using `##` as a "constructor":

```
_LineWidth ## 3
3 @@ _LineWidth
```

Generalising `@@` might still be nice.


ИМХО, для индексов циклов в большинстве случаев достаточно коротких имён.
Вообще, переменным, область видимости которых маленькая, можно давать короткие имена.
Так как эту область легко охватить взглядом (особенно если она в экран влезает).
И сразу видно что переменная означает.
Лучше если имя будет тем длиннее, чем неочевиднее её назначение в местах её использования.


`if (_action_blocks.find(task) == _action_blocks.end())` seems more straightforward since the iterator is not used elsewhere.


Already thought about that, but I test the complete module, so this is really shorter.
If you think I should import each function, okay


Лучше private.
ИМХО, protected сигнализирует об ошибке проектирования — предоставление классам-потомкам доступа к внутренней структуре класса-родителя.
Т.е. потомки слишком сильно завязаны на внутреннее устройство родителя и должны переделываться если в родителе что-то заметно меняется.


damn you're right


89639540-AirflowNetwork-Crash (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1653 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thank you for your fast response.
Yes, this did put correctly the case where the command line contains the key to use (cmdline.key_given true), with correct key characteristics (key_arg) for it.
But the point I noted was the "inverse" case, where the key for the to be generated certificate is not given, so it must be generated and inherit the characteristics of the signer key. This is the else part of the code :
 else {
        if (cmdline.sign_as_given) {
            term_key_ctx = EVP_PKEY_CTX_new(signer_key, NULL);
            if (!term_key_ctx
                    || !EVP_PKEY_keygen_init(term_key_ctx)
                    || !EVP_PKEY_keygen(term_key_ctx, &term_key))
                goto err;
The source code appear to be correct, but the result (of EVP_keygen_init() ?) does not lead to the correct key length. This was the issue reported.
Best regards


When you include `bgfx.lua` in your build script you have `function bgfxProject(_name, _kind, _defines)`, just add something like:

    bgfxProject("bgfx", StaticLib, { "BGFX_CONFIG_RENDERER_DIRECT3D9=1" })


А зачем несколько раз вызывать srand()?
(Ещё один вызов в main().)


Hi
1) Our problem is that we need receive Batterystatus event is across multiple html pages (in our phonegap app).
-So we included the DeviceReady call back and the Batterystatus.addEventListener in a javascript file
-We included the javascript file in the html page

2) We are receiving the Batterystatus events as long as we stay put in the particular html page.

3) However, moment we go to another page and come back to the first page, we are no longer receiving the Batterystatus event in the first page! The deviceready event is getting triggered in the first page again, but the Batterystatus events are not getting triggered.

4) I understand that we cannot register the same call back twice. But what is the solution in the above scenario? Can you please suggest a solution!

5) I understand from the previous 'Issue' raised earlier that a specific removeEventListener was added for Batterystatus. We are not able to find it in the plugin!

thanks
dcherry31


Этот (правда небольшой) блок повторяется 4 раза.
Это нехороший симптом.


Shorter tests are not better readable tests. If you think it's better I'll do it^^


error: 'uart_dev' undeclared...
s/uart_dev/dev ?


search_name лучше передавать по константной ссылке


:) . By the way I did send a mail to apigility. Did you noticed the same?

I did created a test repo https://github.com/harikt/learning-apigility/pull/1

If possible interested to hear.

Thanks!


fast-forwarding develop to borshop-integration-47-feature/json-writer = ac00915b


@bexi @Dreamium


I have seen projects where 7 digits are not enough to disambiguate commits. What do you think is the proper way to fix this?


Неожиданно, что для свободной ячейки выбрано значение "0", а не, скажем, "".
Да и лучше дать этому значению какое-нибудь имя, например, empty_slot.


As far as I can see it can be merged as
```python
    for group in utils.get_export_nodes():
        material_counter[group.name] = 0
        for object in group.objects:
        [...]
````


Nice :)


oops, accidentally pushed the wrong commit... Fixing it now


I get a `warning: -fpic ignored for target (all code is position independent)` when invoking i686-w64-mingw32-gcc (4.9.2, Linux host) with `-fPIC -fpic`.


Are these `Wrapped` lenses superceded by some new style `Lens`?


@Zarthus This is rendered on the site where the route is /docs/{page} and the controller appends .md to get the file path (after sanity checks). Whilst you are correct for GitHub's markdown renderer, this is not the primary manner the docs will be viewed.

In any case, this line is no longer used because it would've had to have been duplicated across all doc pages. Instead it's added to the page if you're not already on the index, server-side.


I was originally on the fence about what to call this, and ended up deciding to align with the terminology used in ODataLib. However, thinking about it a little more I agree it's probably best to use the terminology from the OData specification to avoid confusion. I'll change all references of "openproperty" to "dynamicproperty"


Meant to be a bracnh of tests but had to iron out a few bugs relating to date entry validation and general page issues regarding deleting table data etc when running new queries. Ironed out now.


Please help me learn a little Python here. Does returning `self.__data["Runs"]` return a _copy_ of the map or a reference to the map?

I believe we want to return a copy. For consistency across the different API methods, nothing should change for property xyz unless the user calls setXyz(). But if python is returning a reference to the map, then the user could call getRuns(), makes some changes, forget to call setRuns(), then commit(), and their changes would be written to disk.


Есть же std::numeric_limits<size_t>::max().


Yep, saw it; need to reply, as I missed the "specify a template name" part (which is necessary as all REST controllers are instances of the same class; the service name is not used).


Corrigir o nome do atributo para *@related-article-type*


ah, i see.


It's a usual guideline to forbid wildcard imports and import needed things explicitly. I'd prefer that. ALternative would be to import StringProcessing and prefix every function but I don't think you like that better


too much long line. please take care of adding newlines on this conditions.


Странное ограничение, выраженное в информационной оценке строк.
Стандартные хеш-контейнеры не накладывают требований на размер строк-элементов в таком виде.


This leaves the created object mutable.


usually shorter is better readable. Especially, since the generator automatically adapts to it if we extend test strings and shows the structure on how the expected_results are created which is more valuable info here IMO.


# Fashion
Men fashioner (ya'ni tikuvchi,chevar) nomli loyiham ommoviy,hamma uchun foydali va qulay.Ortiqcha xarajatlarsiz ishimiz tez va qulay amalga oshadi. Bu loyihamda uyimiz yoki ishxonamiz uchun turli xildagi pardalar,modalar ko'rishimiz,tanlashimiz va eng afzallik tomoni buyurtma berishimiz xam mumkin. ##Bosh sahifa: Modalar; Pardalar; Buyurtma berish; O'quv kurslari; bo'limlaridan iborat bo'ladi. ##Modalar bo'limi: | Ayollar uchun | Erkaklar uchun | Bolalar uchun | 1 tasini tanlaganimizdan so'ng,turli yoshdagi ayol, erkaklarimiz va bolalar uchun Ish va o'qish kiyimlari; Kelin liboslari; Oqshom liboslari; Qishgi kiyimlar; Odatiy kiyimlar; bo'limlariga bo'linadi.

    ##Pardalar bo'limi:
Jalyuzi pardalari; Uy uchun; Ishxona va korxonalar uchun; Restoran,kafe va mehmonxonalar uchun; bo'limlariga ajratiladi.
           ##Buyurtma berish:
 Bu bo'limga kirish uchun biz ro'yhatdan o'tishimiz zarur bo'ladi, ya'ni:

Ism:

Familya:

Viloyat(shahar) :

tel :

email :

shular to'ldirilgandan so'ng.Bo'limga kiriladi. Bo'limda

Sayitdan tanlash;

yoki

shaxsiy dizaynni yuklash;

imkonyatlari mavjud;

O'lcham olishda ko'rsatmadan foydalanishimiz zarur bo'ladi.Ko'rsatmada qanday qilib o'lcham olish xamma uchun tushunarli va to'liq ko'rsatilgan bo'ladi. Izox uchun: degan joyga buyurtmachi buyurtmasi haqida ma'lumot yozishi mumkin. ##O'quv kurslari; Bu bo'limda barcha o'quv kurslar haqida ma'lumot olish mumkin;


Python is cross platform until you are using hardcoded values.


why all this random newlines here?


FYI discussed on IRC, there is nothing wrong with master, but he is using an older fork of TF with now cannot work with the latest version of go-cloudstack...


89639540-AirflowNetwork-Crash (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1146 of 1146 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.63%25-green.svg)


But then I haven't access to the last item's `end()`. The problem is that `matches` is an iterator, so I can't go to the last element.


Как-то я раньше не заметил:
условие выхода вычисляется заново на каждой итерации цикла и каждый раз rand() выдаёт новое значение.
Подозреваю что это портит распределение длин строк — оно становится неравномерным.


Does the generated Visual Studio project not have a similar target?


Hi!

CFLAGS are designed (as best practise) to be a default and allow override using:

 make CFLAGS="-O3 -g"

I know you used environment so far but when you look at most packages out there, including these of autotools, the environment is not the preferred method of overriding make variables, but even if use environment, the optimization should be a default and not an append.

I can probably also add -Wall -W -Wdeclaration-after-statement to CFLAGS, I did not notice that when I originally renamed the variables, I agree that it may be nicer as a default.

This is why using autotools methodology of writing build system is better, as these settings are determine by the configure phase, including package customization and environment detection, this makes the makefile much simpler.

I hope it answers your questions.

Regards,
Alon


Yeah, the `Wrapped` instances turn out to be not very useful for attributes because you still need to specify the types. Instead you'd use the `_LineTexture` iso. I deleted them because I felt they just added clutter, just forgot to delete this one.


Recent experience with adding `Foldable` and `Monoid` to the Prelude have made me wary of convenience re-exports.  I think bringing all of `lens` into scope will inconvenience many users, and needing an explicit import list for `Diagrams` in order to limit the `lens` imports is unpleasant.  I'd be fine with a new module that re-exports the non-conflicting names from `Control.Lens`.  At very least, I've been meaning to document that import line somewhere; thank you for working out what it is.


ok


HumidifierSizing_#4688 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1641 of 1653 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


btw. I would prefer it if you don't ack every comment, just leave it uncommented if you agree. Less emails cluttering many peoples mail accounts.


Да вот нет, "правило" гласит что выносить нужно все, что используется больше одного раза)


please do not remove features in such way and bring it back


Это плохая формула по 2-м причинам.
1. Вообще, арифметика с плавающей точкой имеет погрешности.
   Из-за которых, вообще говоря, при повторении одного и того же вычисления
   могут получаться разные результаты.
   Что не допустимо в хеш-функции, как и в любой функции, которая должна
   на одинаковых входных данных выдавать одинаковый результат.
2. Эта формула пытается вычислить хеш-значение на основе _младших_ разрядов величины str_num * A.
   А младшие разряды double-выражений как раз самые ненадёжные в плане точности своих значений.
   Чаще всего они просто обрезаются.
   В результате, получающее хеш-значение в большинстве случаев просто равно нулю.
   Обрати внимание на распечатку которую даёт obj_Hash_by_Multiplication.debug_output(),
   там большинство строк попадает в цепочку номер 0.


this smtp_settings should only be set into config/environments/production.rb


OK, sounds good.


To be honest I don't really look at the coala dev mails, I've already over 1000 of them^^


```
value = us.custom_attributes_values.attributes_values.get(str(custom_attr.id), None)
```


Почему-то эта формула при любых str_num, param_a, param_b и чётном hash_size выдаёт чётное значение.
Не в потери ли точности при переводе size_t в double дело?
(У double мантисса меньше 64 бит, в size_t 64 бита.)
У нормальной формулы для size_t
hash_num = ((param_a * str_num + param_b) % max_str_val) % hash_size;
таких проблем нет.


Use `ConfirmationToken` here?  (Not sure.  The cryptographic requirements are the same.)


but `item` is still the name for the last match object am I wrong?


Maybe we could change this to "offering coaches" or "offering your coaches" or simply "coaching"?


this should be integrated in unit tests, not as a separate script putted in a random directory :)


The DEF files aren't needed when using __declspec(dllexport). I've verified that the DLLs still export the right function using `depends` and am running a build to sanity check it after removing this


Both vcxproj changes are just removing the ".def" files


Forgot to mention, you need to install `ffmpeg`...

> where did you create live.m3u8?

In stream.js


Verify helios still works as well.


We are eternally grateful to all coaches who are dedicated to the teams during the summer.


When reading the documentation there was no mentioning of iterator types so I played safe^^


2/2

For the home view, we were looking for you to show each instance of each model in an each loop like such:

```
<% @todo.each do |t| %>
  <%= t.thing %>
  <%= t.description %>
<% end %>
```

However, since we never explicitly mentioned how we want the home view to be formatted, you'll still get full credit.


This is very nearly ready. However in the patch to isItemAccessible, if siteId is not specified, you fetch the page. However it's fetched again by the existing code right below your insertion. I suggest moving the code so that the page is fetched before the test of siteId. That way you only have to do it once. Ideally, hibernate won't really do a second database access. It is set to cache. However it seems like a bad idea to ask the Dao to do the same thing twice.

The only way my proposal might cause an extra fetch is in the case where the sakaiId is an invalid number. I hope this won't happen often enough to be an issue.

I'm asking you to make changes because I have no easy way to test things involving search.


LGTM


Added these to the project. They were already in the folder so it seemed like the right thing to do. Tell me if I'm horribly wrong.


Pass in image path, returns X number of representative colors


But in case when user wants to keep textures in separate directory such assumption is not a solution.
As far as I remember you need to point in CryEngine your texture directory so how do you imagine such case?


here, you're returning before sending the response to the client.

res.status(403) is just setting the status code. res.end() is the one that actually sends the response.

you can either do:

```javascript
return res.status(403).end()
```
or
```javascript
return res.sendStatus(403);
```


I'm not sure how deep we want to go here, but we should have some kid of assert to verify that ctx was read properly.
At least a count of all services in the context.


Usually we don't delete, we just mark some data as deleted.
Also, we don't want to be deleting based on message text or user name, those are too nonspecific criteria.
Add an ID, then delete based on the ID.
Format the url thusly: /:type_token/:channel_token/:id


Ok, this was caused by not understanding well how Ruby classes actually work. I tried to distinguish methods from attributes but, as there's no public access to properties, everything is a method (an attribute accessor is already a method). I prefer using parentheses to call methods that are not accessors but I have no problem in following your convention.


The strings are needed from the later tests also, since that would need resolving merge conflicts on rebase I would prefer not doing that.


you see, if there would be less you might ;)

2015-03-10 17:55 GMT+01:00 Makman2 <notifications@github.com>:

> To be honest I don't really look at the coala dev mails, I've already over
> 1000 of them^^
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/65a5cb3b0499981fb4d0852cb54d498643f6f543#commitcomment-10124664>
> .
>


This error message no longer makes sense, so update it


nit pick - please add an assert that the length of runs is 1


Sorry didn't actually need that forgot to pull


Fix those before I can accept this pull request :)


roo**t**


btw I read all. (But I also don't even get most)

2015-03-10 17:57 GMT+01:00 Lasse Schuirmann <lasse.schuirmann@gmail.com>:

> you see, if there would be less you might ;)
>
> 2015-03-10 17:55 GMT+01:00 Makman2 <notifications@github.com>:
>
>> To be honest I don't really look at the coala dev mails, I've already
>> over 1000 of them^^
>>
>> --
>> Reply to this email directly or view it on GitHub
>> <https://github.com/coala-analyzer/coala/commit/65a5cb3b0499981fb4d0852cb54d498643f6f543#commitcomment-10124664>
>> .
>>
>
>


There is actually a neat processor instruction for this, try __builtin_clzll or something like that


I would change this to:

Allowing your devs dedicated time to coach a team will support a great cause, let you stay in touch with the Open Source community and help advertise that you are working together with us towards getting more Women in to Software Development.


Do not use generic names for specific functionality

lddmc_bignum_cache and instead of void* use bignum_info* seems a better idea?


+1
thanks ;D


**R**enember


Remember to push


HumidifierSizing_#4688 (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


You can skip this link entirely - I am going to remove the DELETE method. See #77


Rename to `resetTokenTimeout`?  (Again: not sure.  `expiry` sounds weird to me, but this name is easier to understand than the more general `resetTokenTimeout`.  `resetTokenExpirationPeriod`?)


1: M111 unrecognized component name: version


1: D200 One-line docstring should not occupy 3 lines
29:1: E302 expected 2 blank lines, found 1
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D204 Expected 1 blank line *after* class docstring, found 0
34:17: E128 continuation line under-indented for visual indent
41:1: E302 expected 2 blank lines, found 1
41: D203 Expected 1 blank line *before* class docstring, found 0
41: D204 Expected 1 blank line *after* class docstring, found 0
46:17: E128 continuation line under-indented for visual indent
47:16: E223 tab before operator
49:1: E302 expected 2 blank lines, found 1
49: D203 Expected 1 blank line *before* class docstring, found 0
49: D204 Expected 1 blank line *after* class docstring, found 0
53:17: E128 continuation line under-indented for visual indent
55:17: E128 continuation line under-indented for visual indent
57:17: E128 continuation line under-indented for visual indent
59:17: E128 continuation line under-indented for visual indent
61:9: E128 continuation line under-indented for visual indent
63:9: E128 continuation line under-indented for visual indent
65:9: E128 continuation line under-indented for visual indent
67:17: E128 continuation line under-indented for visual indent
70:1: E302 expected 2 blank lines, found 1
70: D203 Expected 1 blank line *before* class docstring, found 0
70: D204 Expected 1 blank line *after* class docstring, found 0
74:17: E128 continuation line under-indented for visual indent
76:17: E128 continuation line under-indented for visual indent
78:17: E128 continuation line under-indented for visual indent
80:17: E128 continuation line under-indented for visual indent
82:1: E302 expected 2 blank lines, found 1
82: D203 Expected 1 blank line *before* class docstring, found 0
82: D204 Expected 1 blank line *after* class docstring, found 0
86:17: E128 continuation line under-indented for visual indent
93:1: E302 expected 2 blank lines, found 1
93: D203 Expected 1 blank line *before* class docstring, found 0
93: D204 Expected 1 blank line *after* class docstring, found 0
97:17: E128 continuation line under-indented for visual indent
98:17: E128 continuation line under-indented for visual indent
100:17: E128 continuation line under-indented for visual indent
102:1: E302 expected 2 blank lines, found 1
102: D203 Expected 1 blank line *before* class docstring, found 0
102: D204 Expected 1 blank line *after* class docstring, found 0
109:17: E128 continuation line under-indented for visual indent
111:17: E128 continuation line under-indented for visual indent
113:17: E128 continuation line under-indented for visual indent
139: D203 Expected 1 blank line *before* class docstring, found 0
139: D204 Expected 1 blank line *after* class docstring, found 0
144:17: E128 continuation line under-indented for visual indent
150: D203 Expected 1 blank line *before* class docstring, found 0
150: D204 Expected 1 blank line *after* class docstring, found 0
156:17: E128 continuation line under-indented for visual indent
158:17: E128 continuation line under-indented for visual indent
160:17: E128 continuation line under-indented for visual indent
178: D203 Expected 1 blank line *before* class docstring, found 0
178: D204 Expected 1 blank line *after* class docstring, found 0
182:17: E128 continuation line under-indented for visual indent
187:1: E302 expected 2 blank lines, found 1
187: D203 Expected 1 blank line *before* class docstring, found 0
187: D204 Expected 1 blank line *after* class docstring, found 0
191:17: E128 continuation line under-indented for visual indent
193:17: E128 continuation line under-indented for visual indent
195:17: E128 continuation line under-indented for visual indent
197:17: E128 continuation line under-indented for visual indent
200:17: E128 continuation line under-indented for visual indent
202:17: E128 continuation line under-indented for visual indent
204:17: E128 continuation line under-indented for visual indent
206:17: E128 continuation line under-indented for visual indent
208:17: E128 continuation line under-indented for visual indent
210:17: E128 continuation line under-indented for visual indent
212:17: E128 continuation line under-indented for visual indent
214:17: E128 continuation line under-indented for visual indent
216:17: E128 continuation line under-indented for visual indent
218:17: E128 continuation line under-indented for visual indent
220:17: E128 continuation line under-indented for visual indent
223: D203 Expected 1 blank line *before* class docstring, found 0
223: D204 Expected 1 blank line *after* class docstring, found 0
227:17: E128 continuation line under-indented for visual indent
229:17: E128 continuation line under-indented for visual indent
232:17: E128 continuation line under-indented for visual indent
243: D203 Expected 1 blank line *before* class docstring, found 0
243: D204 Expected 1 blank line *after* class docstring, found 0
246:36: E261 at least two spaces before inline comment
246:37: E262 inline comment should start with '# '
247:17: E128 continuation line under-indented for visual indent
262:17: E128 continuation line under-indented for visual indent
266: D203 Expected 1 blank line *before* class docstring, found 0
266: D204 Expected 1 blank line *after* class docstring, found 0
270:17: E128 continuation line under-indented for visual indent
272:17: E128 continuation line under-indented for visual indent
275: D203 Expected 1 blank line *before* class docstring, found 0
275: D204 Expected 1 blank line *after* class docstring, found 0
279:17: E128 continuation line under-indented for visual indent
281:17: E128 continuation line under-indented for visual indent
283:17: E128 continuation line under-indented for visual indent
285:17: E128 continuation line under-indented for visual indent
287:17: E128 continuation line under-indented for visual indent
289:1: E302 expected 2 blank lines, found 1
289: D203 Expected 1 blank line *before* class docstring, found 0
289: D204 Expected 1 blank line *after* class docstring, found 0
293:17: E128 continuation line under-indented for visual indent
296:1: E302 expected 2 blank lines, found 1
296: D203 Expected 1 blank line *before* class docstring, found 0
296: D204 Expected 1 blank line *after* class docstring, found 0
300:17: E128 continuation line under-indented for visual indent
302:17: E128 continuation line under-indented for visual indent
304:1: E302 expected 2 blank lines, found 1
304: D203 Expected 1 blank line *before* class docstring, found 0
304: D204 Expected 1 blank line *after* class docstring, found 0
312:17: E128 continuation line under-indented for visual indent
322:1: E302 expected 2 blank lines, found 1
322: D203 Expected 1 blank line *before* class docstring, found 0
322: D204 Expected 1 blank line *after* class docstring, found 0
326:17: E128 continuation line under-indented for visual indent
328:17: E128 continuation line under-indented for visual indent
331:1: E302 expected 2 blank lines, found 1
331: D203 Expected 1 blank line *before* class docstring, found 0
331: D204 Expected 1 blank line *after* class docstring, found 0
335:17: E128 continuation line under-indented for visual indent
337:17: E128 continuation line under-indented for visual indent
339:17: E128 continuation line under-indented for visual indent
342:17: E128 continuation line under-indented for visual indent
344:17: E128 continuation line under-indented for visual indent
346:17: E128 continuation line under-indented for visual indent
352:17: E128 continuation line under-indented for visual indent
354:17: E128 continuation line under-indented for visual indent
356:17: E128 continuation line under-indented for visual indent
358:17: E128 continuation line under-indented for visual indent
363: D203 Expected 1 blank line *before* class docstring, found 0
363: D204 Expected 1 blank line *after* class docstring, found 0
367:17: E128 continuation line under-indented for visual indent
378: D203 Expected 1 blank line *before* class docstring, found 0
378: D204 Expected 1 blank line *after* class docstring, found 0
382:17: E128 continuation line under-indented for visual indent
388:1: E302 expected 2 blank lines, found 1
388: D203 Expected 1 blank line *before* class docstring, found 0
388: D204 Expected 1 blank line *after* class docstring, found 0
396:17: E128 continuation line under-indented for visual indent
398:1: E302 expected 2 blank lines, found 1
398: D203 Expected 1 blank line *before* class docstring, found 0
398: D204 Expected 1 blank line *after* class docstring, found 0
402:17: E128 continuation line under-indented for visual indent
404:17: E128 continuation line under-indented for visual indent
406:17: E128 continuation line under-indented for visual indent
408:17: E128 continuation line under-indented for visual indent
410:17: E128 continuation line under-indented for visual indent
412:17: E128 continuation line under-indented for visual indent
414:17: E128 continuation line under-indented for visual indent
416:17: E128 continuation line under-indented for visual indent
418:17: E128 continuation line under-indented for visual indent
419:17: E128 continuation line under-indented for visual indent


178:5: F401 'event' imported but unused


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing


27:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from operator should be before from intbitset
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
35:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from sqlalchemy.orm.collections
55:9: B901 blind except: statement
146: D102 Docstring missing
150: D102 Docstring missing
154: D102 Docstring missing
193: D102 Docstring missing
207: D102 Docstring missing
211: D102 Docstring missing
220:11: B901 blind except: statement
225: D102 Docstring missing
233: D102 Docstring missing
242: D102 Docstring missing
247: D102 Docstring missing
320:5: E731 do not assign a lambda expression, use a def
332: D200 One-line docstring should not occupy 3 lines
346: D102 Docstring missing
388:9: B901 blind except: statement
405:9: E731 do not assign a lambda expression, use a def
445:9: B901 blind except: statement
451:13: B901 blind except: statement
489: D204 Expected 1 blank line *after* class docstring, found 0
503: D102 Docstring missing
507: D102 Docstring missing
541: D204 Expected 1 blank line *after* class docstring, found 0
554: D204 Expected 1 blank line *after* class docstring, found 0
575: D204 Expected 1 blank line *after* class docstring, found 0
585: D204 Expected 1 blank line *after* class docstring, found 0
600: D204 Expected 1 blank line *after* class docstring, found 0
610: D401 First line should be imperative: 'Return', not 'Returns'
610: D202 No blank lines allowed *after* function docstring, found 1
610: D400 First line should end with '.', not 'x'
623: D204 Expected 1 blank line *after* class docstring, found 0
644: D204 Expected 1 blank line *after* class docstring, found 0
654: D102 Docstring missing
662: D204 Expected 1 blank line *after* class docstring, found 0
694: D204 Expected 1 blank line *after* class docstring, found 0
714: D102 Docstring missing
725: D102 Docstring missing
732:11: B901 blind except: statement
740: D102 Docstring missing
750: D204 Expected 1 blank line *after* class docstring, found 0
762: D204 Expected 1 blank line *after* class docstring, found 0
771: D102 Docstring missing
782: D401 First line should be imperative: 'Return', not 'Returns'
787: D204 Expected 1 blank line *after* class docstring, found 0
802: D102 Docstring missing
810: D401 First line should be imperative: 'Return', not 'Returns'
810: D290 White spaces around docstring should be trimmed.
815: D204 Expected 1 blank line *after* class docstring, found 0
899: D102 Docstring missing


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


To make the test more readable and little less brittle in the event that the input is changed, please add something like the following to verify we're starting this test case from the expected number of items
```
 self.assertEqual(len(runs), 7)
```


1: M111 unrecognized component name: script


Maybe not include counting number of BDD nodes all the time. This SHOULD be separate functionality.


1: M100 needs more reviewers
1: M101 signature is missing


24:1: I201 Missing newline before sections or imports.
25:1: I101 Imported names are in the wrong order. Should be _request_ctx_stack, current_app
25:1: I100 Imports statements are in the wrong order. from flask should be before import six
25:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
235:9: B901 blind except: statement


1: M111 unrecognized component name: collections


1: D100 Docstring missing