Right ) typo ) Thnx


Update **this**.[[queue]]


some tests failed:
failure: http://build.servo.org/builders/mac1/builds/1357


Warning here. On Windows 8.1 (yes, but don't blame me, i need Unity !), the 0.0.0.0 interface isn't working by default then hot-reload is broken.
I had to change this to 127.0.0.1 (i guess localhost would work too) to make it work.
Then it's all good !


Storebror var lite orolig bara...


So here, it's up to you whether you want to keep the old routes. If you remove them, you can use the console (`rails c`) to add/update/delete resources (both `User` and `Item`), but you may want to keep the nice UI as well.


:D


Hi. @radfast I'm found sky provider bug on overworld.
![2558-03-24_16 09 09](https://cloud.githubusercontent.com/assets/6128413/6821169/8b001418-d307-11e4-8623-6ef8869c94a3.png)


Compiling the scripts which contain the examples is - as discussed - a good idea.

But please keep ProofSequences.scala and FormulaSequences.scala as scripts. It is not clean to import examples by default (even more so as the examples in xml-format are not imported automatically).

Also, please leave them at their old position directly in the examples/-directory. The user manual relies on this.


Psssssssstttttt....Robin!
I miss you. I hope you're still cynical.


Fixes courtesy of @davepusey https://github.com/davepusey
Source: https://github.com/daz/live-f1/commit/b89089347403d7c11cef2b4724aabd5c88664cdc


@valib done


@nathanfranklin do you means putting the startTime to 0 ? You are right, that it should be the time set in the mesh (last iteration)


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1673 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Не понятно, если они будут `readonly`, то как наполнять ячейку контентом?


See commit b8289b625e, what do you say about that?


Is this indeed a Forth?


Sklansky version of priority encoder
//Compiled clean and tested
pattern each stage the number of and gate increases 2 fold and the interval also increases two fold.

ex: 1,2,3,4
First run: 1& 2; 3&4And successive inverted inputs (And at alternate node)
Second run: AND - 1&2 with 3; 1&2 with 3&4
repeats similarly


That's why it's encrypted :)


PS: yes, this means I still read your commits now and then for ruby-wisdom when I see OSS ahalogy stuff come up. I hope thats not too stalkery.


From pep8:
When catching exceptions, mention specific exceptions whenever possible instead of using a bare except: clause
A bare except: clause will catch SystemExit and KeyboardInterrupt exceptions, making it harder to interrupt a program with Control-C, and can disguise other problems. If you want to catch all exceptions that signal program errors, use except Exception: (bare except is equivalent to except BaseException: ).


Sounds good. Will replace it. Thanks!


what


@bindea-mihai
Aici trebuie ca si parametru o clasa de tip context cu o proprietate `string Id {get;set;}`.


В текущей реализации этой строки нету, но учту на будущее.


PSS: Way to initial commit w/working specs <3


character_pvp_stats_battleground
character_pvp_stats_players
account_data
account_instance_times
account_tutorial

In these tables remain the data after deleting the character...


Eventual ai putea sa faci si o versiune generica a lui ItemContext, `ItemContext<T>` care sa specifice tipul Id-ului.


Thanks. Given suggestion by Domenic at https://github.com/whatwg/streams/issues/177#issuecomment-83991120, I've changed it to happen only when the queue is empty. Fixed 951c41bc23ee842e51e3933e38d1417f405a7434


Fixed 951c41bc23ee842e51e3933e38d1417f405a7434


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Don't change this file, you can add extra parameters [here](https://github.com/phenotips/phenotips/blob/master/components/navigation/ui/src/main/resources/XWiki/SearchSuggestConfig.xml#L815) by replacing the simple document name with `$xwiki.getURL('PhenoTips.SuggestPatientsService', 'get', 'outputSyntax=plain&permission=view')&`


测试用例我这里会报错额。。
所以就先屏蔽了


Clasa TimeZone nu are de ce sa stea in namespace-ul web. Acest namespace nici nu ar trebui sa existe si oricum si daca ar exista nu ar trebui folosit din servicii.

E ok sa faci un folder aferent acestui serviciu, ex. `TimeZone` in care sa pui clasa.


You are right and I agree that it should be changed. I simply didn't figure out a better example, but wanted to add Mockito library as it may be helpful in a common projects.


-[java naming convention](http://www.oracle.com/technetwork/java/codeconventions-135099.html)
-Write out variable names. We have a IDE for a reason.
-No magic numbers! (What is 270?) -> final constants
-Comments! (Not what you do, but why you do something)


@michaelklishin CI should work shortly


> I believe this is backported

No not yet. @Keno should it be?


`.erb.txt` really ? Not `.erb` ?


`app/views/issues/3.0.1.show.html.erb.txt` really ? Not `.erb` ?


@bindea-mihai
Verificarea asta sigur nu merge.
Fie pui `if(typeof(result.time_zone) != 'undefined')` fie pui varianta mai putin specifica, dar care o include si pe asta `if(!result.time_zone)`


As the teachers page was changed, this is no longer a problem.


TeamCity xBIM :: Xbim Geometry :: Release [Build 43](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1197&buildTypeId=XBIM_XbimGeometry_Release) is now running


TeamCity xBIM :: Xbim Geometry :: Release [Build 43](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1197&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:10


Wrong singleton.


@bindea-mihai
Nu imi e clar de ce primesti aici din nou $scope ca si parametru. Nu ai acces oricum la el prin variabila $scope.
Chiar se trimite la fiecare call si scope-ul ?


Could you also add this for me please?
---
Anne-Gaelle Colom is a Senior Lecturer at the University of Westminster in London, UK. She is passionate about the use of technology in Higher Education as well as the Web and Mobile world. Anne-Gaelle joined the jQuery Mobile team in October 2011 to become the documentation lead a few months later.
---
Thank you :-)


No need to localize a var. `$error` should no be wrapped in `__()`.


There is a typo on this line. Should be NE10_LINUX_TARGET_ARCH.


Is this a good idea?


Wrong commit message: "changed size of color controls". The "important" were actually needed in this case...


You are concatenating the options as a string. I should declare this as a string also to make it clear we're talking about a string.


It worked. I have tried to write it as follows but it didn't work:
-first try:
```ruby
def create_vote
+    user.votes.create(value: 1, post: post)
```
-second try
```ruby
def create_vote
+    self.user.votes.create(value: 1)
```

Also why did you remove private in the vote.rb?


@heing What is the difference?


Polymer 部分的习题做完以后就可以开始研究实际课题了 https://github.com/fireball-x/dev/issues/423
剩下的习题和实际工作一起慢慢完成。

一边研究一边把你认为有用的资料链接到 issue 下面。缺少方向的时候直接在 bearychat 里提问，不要闷头想，很多时候都是一个链接或一个关键词的事情。


showing that error
public class DeptController extends MultiActionController{


strict comparison?


Only encode the password if it exists in `$user` as it may not be provided.


比如pipe()这个方法发起一个ajax请求，它会将方法结果缓存在内置的变量中，内置变量监听所有的的请求都正常返回了之后，才会去执行then里的callback。
如果这里不设置一个延迟处理，所有的js是按顺序执行，执行一个pipe方法，结果马上返回，当所有的pipe()都执行完时，内置变量去找callback，发现callback是undefined，将忽略callback()


@Natim should we remove it from ``REQUIREMENTS`` too ?


Copy paste!


@saschazelzer I see, I just needed my change, I'm fine with other Strings now.
Thanks for explaination


right now the lines all move together in one direction. It can easily be adapted so that the lines move individually in any direction


@kapilgarg1996
Please use double quotes and spaces on the outside of quotation marks (i.e., ```.children( "input" ).addClass( "ui-hide-default-clear" )```)
Please place the comment on the line above, and leave a blank line before the comment.
Please use ```//``` to indicate a comment rather than ```/*...*/```


WTH ?!?

Why ? Why using a shell instead of a PHP built-in ?

```php
file_put_contents(PHPCI_DIR . "daemon/daemon.pid", getmypid());
```


For #90. Good work.


See https://dashtalk.org/threads/v0-11-2-x-testing.4202/page-21#post-48352


character_pvp_stats_* is not delete, because it's a history feature
account_* has nothing to do with char delete
realmcharacters are updated on next login (char enum?)
instance, don't matter if it is persistent till next instance reset


I don't think there is. I did it just to keep the pattern with Slavek, so change it to whatever your heart pleases :)


Sure, why not.


> Не, так не пойдет. В старых версиях не будет работать.
Зачем же все эти нововведения если нужно внезапно поддерживать динозаврические времена?
Проблема юзера, велком ту 1.3.x милениум.

> При этом надо использовать узел Server3 а не Server.
Скрипты забрал с вашего бранча.

> Версиям 1.2.5 и 1.2.6 я сознательно не дал обновиться до
зачем? о_О

> И зачем вы удалили папку Contrib ?
в ней пусто. Ладно бы там все необходимое для сборки было, так нету же.
Исключил её и все её содержимое.

В SVN для этого есть ignore-on-commit list, с SVN объект не уходит, но и не проявляет желания быть загруженным на сервер. в Git есть что-то такое?


In my opinion is the use of switch a little bit overkill, because an if-statement will do also. In this case the cycle will be high.

Something like:
```
if ( $key === 'manual_ua_code' && $new_settings['ga_general']['manual_ua_code'] === '1' ) {
    ...
}
```


We also need to have the similar check in templates, because they are relying on presence of this assets.


Sorry, but what is missing is the info that you have to import "something". (in the other commands the "something" is place-held by entities like "foo.tiff"
Otherwise you might wrongly assume that this is some setup/config.
In fact, you have to pass all this + import something in the same breath => compulsory option.
Also, mention the --upload (unless some genuine reason not to).


I don't there's any need for "WTH" here.

Sure, it makes sense to use `file_put_contents()` - but what's there works. Feel free to submit a PR if you want to change it.


> It seems somewhat excessive to require linking to the ffmpeg libraries.

I agree it seems excessive to link against four additional GPL-or-LGPL-Version-2-or-3-it-depends libraries. But you have no other choice if you want proper codec handling and muxing. It is not my decision, this is how libav/ffmpeg are organized.

> The way prboom-plus handles this is by just piping the raw audio and video to some program that a user can configure, which avoids requiring to link to any particular software and allows alternatives to be used (eg, ffmpeg vs. avconv vs. x264/aac, etc).

I have to strongly disagree that (1) dumping hundreds of MB of raw video and audio data to disk and then (2) post-processing them with three different command-line utilities is the more elegant way.

> (this hasn't seemed to be an issue for prboom-plus as far as I know).

http://www.doomworld.com/vb/doom-speed-demos/68255-viddump-not-working/
http://www.doomworld.com/vb/source-ports/68046-how-to-use-the-video-capture-function-of-prboom-plus/
http://www.doomworld.com/vb/source-ports/65185-prboom-plus-viddump-output/
http://www.doomworld.com/vb/doom-speed-demos/57958-need-help-with-making-doom-youtube-videos/
http://www.doomworld.com/vb/doom-general/64647-converting-lmps-to-video/
http://www.doomworld.com/vb/source-ports/64235-prboom-plus-viddump-and-opening-title/
http://www.doomworld.com/vb/doom-speed-demos/61477-prboom-plus-newbie-question-video-capturing-and-fast-video-playbacks/
http://www.doomworld.com/vb/doom-general/57232-video-capture-using-prboom-plus-2-5-1-2-test-help/


Yes, sure please display a message like:
print _("File for checking if upgrade path is possible doesn't exists.")
Maybe if not os.path.exists(release_version_file) is not needed, though. Only Try: Except.
Thanks for comments


Ясно, учту.


远程写入


on the road learning Andorid


Wow, не знал об этом. Спасибо за информацию. Исправлю.


Понял, пока что пусть остаётся так, т.к. это хардкодные значения, вскоре они будут заменены реальными данными.


The commit message should have been extract DbConnectionPool interface...


Oh, you're right i did that thing with the other constructor so that i would not have to create an instance of the class for a simple one liner like "BEGIN".

And he's right in regards to the performance, at least for querys that require the disk to write stuff, because SQLite will try to sync with the disk every query. On my SSD it takes ~45 seconds for ~1000 "INSERT"s without a transaction and ~1ms with. Because it will then sync only on the "COMMIT".


See https://github.com/Block8/PHPCI/pull/864.


That would make the whole thing break on node I'm afraid :(


Hmm that was somehow done by the intellij move operation. I will test if this will be discarded after reformat of the code with given settings


why use `plyr:::renames`, 1) the function `rename` of `dplyr` was choose for all the other function and works great.
2) when the `rename` function of `plyr`is imported in the `NAMESPCE` like in line 64, it overwrite the previous import of the function `rename` of `dplyr`and return a warning message when the package was built and tested.
3) if the function is imported by the NAMESPACE `plyr::` is not necessary.
4) I prefere use only `dplyr`as far as possible.


Thanks :) It is a recent development for WP Email Capture :)


> А и не надо. Вместе с обновлением скриптов обновляется и ядро.
Скрипты обновляются отдельно.

>При этом надо использовать узел Server3 а не Server.
> Скрипты забрал с вашего бранча.
Я добавил Server3 и  MinVersion сегодня утром

>Версиям 1.2.5 и 1.2.6 я сознательно не дал обновиться до
>зачем? о_О

В последний момент при выпуске 1.3.0 выяснилось, что старые версии не умеют создавать новые папки при обновлении. Тогда папка Thumbnails не была бы создана,и была бы ошибка при создании миниатюр. В версии 1.3.1 я добавил костыль при обновлении с этих старых версий.

>И зачем вы удалили папку Contrib ?
в ней пусто ещё в вашем репазитрии. Ладно бы там все необходимое для сборки было, так нету же.
>Исключил её и все её содержимое.
Возможно в будущем я добавлю туда библиотеки, которые не достать из других источников: патченную версию SqPlus для компилятора Clang, папку BaseClasses.


Today is the beginning..........


Исправлено в ea036510fd39db06b84cb460e89c3678a153cf2a


HotFixPurchasedAirUnitTest (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (656 of 656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.66%25-green.svg)


It wasn't intentional and I havn't run update - no idea what happened with the styleguide and jbuilder versions.


don't question my life choices


@frankdiox Can you add the Japanese:

disabled状態にするかどうかを真偽値で指定します。


Corrected the typo ;)


1. Для обычного режима запуска раннера есть только тесты из модуля тестовой обработки. При чем тут ОФ?
2. Об этом и речь, контекст, сохраненный через ЮТест, сохраняется между запусками, а внутри тестовой обработки нет. Я правильно понимаю, что:
  - сохранение контекста внутри тестовой обработки - это побочный эффект  оптимизации скорости запуска тестов?
  - наличие этого побочного эффекта не гарантируется?


this name is not explicit. I think it should be test_get_answer_keywords_two_keywords


Sure.


Oh, sorry. I should have checked it. Indeed they are still not supported. But with current use race on initialization is not possible. We should keep it inmind tho when using this elsewhere.


Test commit


For what is it necessary or where can I find info for this?


Thanks for your reporting.


The dev of the app can decide which logic is used to set images. If he does not provide this it won't work.


So far, it fails to be ran correctly during the testing phase. The following error is produced:
```
symbol lookup error: javacpp-binding-examples/javacpp-maven-example/target/classes/lib/libjniPolygon.so: undefined symbol: _ZN8Geometry7Polygon19dimension_to_stringIiEESsRKT_
```


Looks good, thanks.


E testata verificarea asta si merge ok. Am vazut ca asta este o metoda prescurtata la ce ai spus tu. Prefer metoda asta in detrimentul la carnaciorul ala lung. Totusi stiu ca verificarea asta merge atata timp cat nu ii asignezi lui undefined o valoare.
"result.time_zone !== undefined" on the other hand nu ar fi corecta.


Well, I see I'm not the only thing you ignore ![](https://lh3.googleusercontent.com/-1Ry2WU-aucg/AAAAAAAAAAI/AAAAAAAAACA/WfmnvVbSCTE/s46-c-k-no/photo.jpg)


r+


В f8c39952879a372ce58bc8902643503303680760 не сделан пункт 2.Еще не делал или непонятно?


Thank you Killili actually the code that amin provided what exactly that I
wanted. Your code works perfectly. thank you so much for your help.

2015-03-25 10:28 GMT+01:00 Killili <notifications@github.com>:

> Oh, you're right i did that thing with the other constructor so that i
> would not have to create an instance of the class for a simple one liner
> like "BEGIN".
>
> And he's right in regards to the performance, at least for querys that
> require the disk to write stuff, because SQLite will try to sync with the
> disk every query. On my SSD it takes ~45 seconds for ~1000 "INSERT"s
> without a transaction and ~1ms with. Because it will then sync only on the
> "COMMIT".
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/aminroosta/sqlite_modern_cpp/commit/e1438f36fdaa1fb461474beb6aa19571a6c74dde#commitcomment-10385044>
> .
>


True, will fix it.


@DanBadea
Nu inteleg exact unde zici ca $scope vine ca si parametru. Ce linie ca eu nu vad...


saw approval from saneyuki
at https://github.com/Ms2ger/servo/commit/6113dd42b1674e1e08288e5b8efaf29606d0aa30


merging Ms2ger/servo/canvas = 6113dd42 into auto


Ms2ger/servo/canvas = 6113dd42 merged ok, testing candidate = 004e12c8


damn autocorrect
*hail


Well done for getting `create_vote` working. The code on this comment should have worked: https://github.com/zein1016/bloccit/commit/c35daac8160c00557fcc43ec195fde4c29db22ea#commitcomment-10374084 . Notice that `post: self` was missing from the original code.

> Also why did you remove private in the vote.rb?

I'm only making comments on here. I've not made any commits to this repo - removing private would have been a change you committed. Feel free to add it back in.


Goddamn it, I love you right now


You can directly set `public $recursive = -1;`, as a class attribute.


touché

On Wed, 25 Mar 2015 10:42 ven <notifications@github.com> wrote:

> Well, I see I'm not the only thing you ignore
> <https://camo.githubusercontent.com/f989f7e63e54c8dd009c3a1cc7cabea1fb538cde/68747470733a2f2f6c68332e676f6f676c6575736572636f6e74656e742e636f6d2f2d3152793257552d617563672f41414141414141414141492f41414141414141414143412f57666d6e765662534354452f7334362d632d6b2d6e6f2f70686f746f2e6a7067>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vendethiel/Mikuia/commit/9aa88d254da584c6526367ccf67099e1e313a58d#commitcomment-10385344>
> .
>


> But you have no other choice if you want proper codec handling and muxing.

Given the video and audio dumps should be identical in length, I can't imagine pipes being that difficult to manage. After all, it's a non-issue for prboom-plus :P

> I have to strongly disagree that (1) dumping hundreds of MB of raw video and audio data to disk and then (2) post-processing them with three different command-line utilities is the more elegant way.

I think there might be a misunderstanding here. See how prboom-plus handles it, it opens two pipes to output the video and audio streams, and them runs a third command to mux them together. It may not be the most elegant way, but it certainly leaves the simplest control for configuration.

> links

Well, you got me there. I won't read all those threads, but I'm viewing this as being a battle between flexibility and ease-of-use. I'd personally vouch for the former, but there probably is room for both.

Perhaps a somewhat unusual use-case, but one thing I enjoy of using prboom-plus is being able to dump lossless video from demos (which can be hundreds of gigabytes depending on resolution and length...) and from there, I'm capable of stepping backwards and forwards in a video player such as mpv in order to take lossless screenshots from that. I realize this must be only the first step, but being able to at least configure Chocolate Doom (even if it means editing chocolate-doom.cfg by hand) for exact codec and container formats is something that I perceive as vital.

I think I got everything I really needed to convey with my last paragraph. Carry on with the good work :)


comment


* Typo: syntaxe -> syntax
* I'd rather have ssl_verify default to DEFAULT_AUTHSERVSSLPEERVER (which is not something you introduced)

It might also be a good idea to just exit on invalid config files. Is LOG_ERR typically used for errors from which we can recover?


We need to check if the "propertyName" is empty or null. I was checking the "property" instead of the "propertyName" and this was the reason why the action failed.

if(StringUtil.isNullOrEmpty(object) && StringUtil.isNullOrEmpty(propertyName)){ ... }


Sorry, forgot to add the `broken_image`. With regard to `--upload`, I used `--logs` as an example but I can switch to using `--upload` instead if that makes more sense.


Same situation, we need to check the "propertyName"


Shouldn't this be creature_addon?


Oh yes, this would be good... but the question is how?


You use left join here. What if size is not set for some repos?


Can you put all the json data in alphabetical sort? :)


Here as well... can you sort it alphabetically


Done:
https://github.com/donbeave/grails-font-awesome/commit/37c288e9a40a20a4a33b7350f5ed44efdb09da21


Cool.

Could a unit test be added to test_controlwrapper.py which would catch this during testing?

For example, the test could check that the time has changed by checking if some value have changed like the following:
```
#configure wrapper to run a few steps

mesh_in_wrapper = wrapper.get_mesh("foo")
cell = mesh_in_wrapper.get_cell(uid_of_a_cell)
old_vel = cell.data[CUBA.VELOCITY]

wrapper.run()

cell = mesh_in_wrapper.get_cell(uid_of_a_cell)
new_vel = cell.data[CUBA.VELOCITY]

self.assertNotEqual(old_vel, new_vel)
```


HotFixPurchasedAirUnitTest (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1674 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Actually, due to the nature of the TEXECL command, it will fail if you use it like that. The way it sits now is actually the way it is supposed to be.


Can I use a LOG_WARNING has instead?


Ups. i am sleepy.


Yeah, probably. It's just important, IMHO, that the defaults are sane and the fail-safes are, well, safe.


Is this correct? It seems to me that `03 2010` should parse to `local(2010, 0, 16)`, no?


fg


sdfg


Yeah, that's probably not a bad call... but, I don't think I've ever used the trailing whitespace feature of markdown either.


for 3rd party libraries, we generally put the non-minified version in the `js/lib` folder, it will get minified anyway as part of the build, [example](https://github.com/reddit/reddit-plugin-liveupdate/tree/master/reddit_liveupdate/public/static/js/lib)


Do you want me to push a change that emboldens those words?


cocoaPods 第四段 第三方库 打错了


nit: we generally leave an extra newline at the end of the file


update_sqlite_library (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


update_sqlite_library (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


update_sqlite_library (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


90946736_WSHP_#4567 (kbenne) - i386-Windows-7-VisualStudio-12: OK (1675 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


update_sqlite_library (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


本地化第一段 同时也打错了。


Keep it up..


Store opens on start


This method looks weird to me, what if someone modifies the list while you're making a snapshot?

Wouldn't it be safer to use in ActivityFragmentLifecycle:
```
Set<WeakReference<LifecycleListener>> lifecycleListeners = new ConcurrentSkipListSet<>();

lifecycleListeners.add(new WeakReference(listener));

for (WeakReference<LifecycleListener> reference : lifecycleListeners) {
	LifecycleListener lifecycleListener = reference.get();
	if (lifecycleListener != null) {
		lifecycleListener.onStart();
	}
}
```

or the same at RequestTracker.requests.

Someone will have to remove the listeners/requests though...

I like that setFromMap trick, I'll make a mental note :)


ast_optimizations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this comment no longer applies


Imma let you finish, but I just pushed a new commit that makes these things bold. I can remove that commit if you like.


KJ, could you review this please? I think between me and run_away we messed up this PR and fork :\


This LGTM. I'll look at converting one of our existing external collectors to use the new format later this week if I get a chance.


This looks like a very bad hack.


This makes RSpec failures much easier to understand – any objections?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1153
success: http://build.servo.org/builders/linux2/builds/1152
success: http://build.servo.org/builders/android/builds/1187
success: http://build.servo.org/builders/mac1/builds/1366
success: http://build.servo.org/builders/mac2/builds/1369
success: http://build.servo.org/builders/gonk/builds/335


LGTM.


fast-forwarding master to auto = 04d78b6f


Unrelated but made me think, should `priorEnd` not be `Pos` rather than a `SrcSpan`?

It's used on 258, 315, 405 each time with `deltaFromSrcSpans` which is defined as

```
deltaFromSrcSpans ss1 ss2 = ss2delta (ss2posEnd ss1) ss2
```


Should the vtkImageViewer2 module even be there? Should it take a VTKCell input? Pipelines usually work the other way...


This should be "<4.0.0", the last version to work with nodejs according to https://www.npmjs.com/package/jsdom


This is the same as `printWhitespace`


aaaaaaaaargghhhhhhhhhhhh!


ast_optimizations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is this correct? Shouldn't this be different when we end a session?
I don't think we might need separate notifications for that.


That is a bizzare method name.


where is the lockDir lock unlocked?


Ahh ok, yea I just saw that. I actually submitted #5 without noticing as well so we can probably disregard that.


This is crazy-looking.  There must be a better way to format it.


Yeah, it's gone now.


ast_optimizations (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This will need to be deprecated, there are drifts (height's 262867-9). This will need to be in a future fork and also need to address possible OOP issue here.


Here is a proper gpg module...
https://forge.puppetlabs.com/golja/gnupg


Yeah, same question.  I was using that, please bring it back!


So you don't like my damage view? Just the number doesn't tell you when the player gets cards locked or dies.


It's all good, thank you!


The docs site has not been updated yet due to React Router's breaking changes. This is currently being worked on. We will send updates if anything changes!


This code is old and I am not sure what uses it. Every VTK class that have a RenderWindow method is given this port. It is probably a convenience method to display or export the cell in different ways.

In the current wrapper there is no way to specify conditional ports. I am not sure how to do this in a general way. Should we have some kind of conditional attribute saying when to add a port?


ast_optimizations (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


ast_optimizations (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


use what Pyramid provides.  There is an `HTTPInternalServerError` response in the `pyramid.httpexceptions` module.  You should use it.


Welp. How did this sneak in?


accept change R version


not it github, please.  There are good ways to approach injecting vars like this into JS through pyramid.


如果已经 fixed， 就赶紧为 master 的那个 SHA1 hash 打包。作为 shadowsocks-libev-2.1.4.9999.ebuild 这样。

尽量使用上游的 fix


@jdalton: I'm attempting to use this as a dependency for Guardian Scribe, which is an AMD module, in a Browserify environment. It's not an option to replace all of their AMD code, and browserify doesn't support recursive transformations (for deamdify). The only way to do it appears to be putting this line in package.json, per https://github.com/substack/node-browserify/issues/501


r+


Nice fix and tests! I'll build and deploy your changes now.


This is actually a remarkably good-looking js file.  Well done.


saw approval from jdm
at https://github.com/frewsxcv/servo/commit/ed64e6a7c6aa611b18666d632e019a87f50bb025


merging frewsxcv/servo/xhr-enum-prefix = ed64e6a7 into auto


frewsxcv/servo/xhr-enum-prefix = ed64e6a7 merged ok, testing candidate = 88ca398c


master (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (334 of 334 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@patrickmacarthur - Can you try your test with this patch?


I'm not sure about this for two reasons:

1. Maintaining state of tracking mode could mask bugs with initial defaults in testing.

1. Quitting with the map in one place due to tracking in last debug session could load up a different area of the map the next time you run if you are in a different location (or simulating differently). It's not a state of the app so much as it is a state of, well, tracking.

Not sure though. Thoughts @kkaefer? You did the original setup on app state maintenance.


@razic yeah there was an error on deploy.  This is fixed in master.  thanks!


Not related to this change, but we end up extracting the hash blocks twice (here and in ``addNewGroup``). We should have ``putIfAbsent`` take the following
``public int putIfAbsent(int position, int rawHash, Block[] hashBlocks)``


Why the style change in all of this?


v5.5.1.2 is on its way ;-)


@bors: retry
* #5207


Woo hoo! This is awesome!


The style guidelines ask us to not use var in these cases (only use it when calling new and the type is obvious).


r+, fantastic!


ast_optimizations (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@fessoga5 Please don't commit directly to the master branch. Create Pull Requests for review by other Collaborators.


This (copying a project and republishing just to change a package.json field) feels wrong. \@substack do you have guidance here.


Forgot to mention: There are timers now. The ledgrid and I2C have each a timer. This needs to be tested!


What about ParseUI?, dependencies says:

```
  "dependencies": {
    "Parse": [
      "~> 1.6"
    ],
    "ParseFacebookUtils": [
      "~> 1.6"
    ]
  }
```


Fixed setpoint temperature during boild.


What about likes and other non-post notifications?


Just wrote a shell script to accomplish the replacement in grunt before the browserify step and will be unpublishing this, since I agree in principle that copying just to change a field in package.json is very wrong. But @substack might have a better idea.


@jemmybutton this looks nice! Would you mind merging this into ropensci/rglobi main?


Hm, why was this even here, haha? Might as well delete it instead of commenting it out


I now respect the "Brune" name, again.


Hmmm I don't think we should add to our code...
The code removes the color assigned to a column when that column is unchecked in the plot pane. This is not a good idea because that color might have been chosen by the user (when the column is checked a random color is assigned, but the user can customize it later) and they might want it to stay while they do some tests (e.g. plot different columns multiple times to see how one affect each of the others).
But it's not a bug anyway :smile:


Oh, I see. Much better way to do this! But this line can still be deleted.


It's coming slightly later, but very very soon.


*When updating : set Permission "Use internal database authentication" to 1 for all user (update DB)*

Done: https://github.com/LimeSurvey/LimeSurvey/commit/32377e2ca3e86ce093d2251aaa228dc1936bd516


Great, now your dad thinks that our club is full of incompetent students.


Thanks a lot for this - having a look now.


Never mind, you did it in the next commit.


I think that given the new organic stuff this docstring should have descriptions of all the kwargs and what they do


LGTM


typo in the commit message ration - > ratio


closes #3 ... works on all devices.


@cberner each operator needs to make it own decision on what happens.  The close and finish code for most operators are the same thing, so one delegates to the other (but that is entirely the choice of the operator).  The one operator that the distinction matters for is the `TableCommitOperator` which must know that the output is complete (normal finish vs error finish).

Anyway, this commit is only about safety. It should not be necessary for the operator to perform this clean up, but it can make task teardown faster and prevent some kinds of bugs.


90946736_WSHP_#4567 (kbenne) - Win64-Windows-7-VisualStudio-12: OK (1675 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


It might have been nice to have this as a stand-alone function.  It could be useful in a number of contexts.


feels to me like this list should be read from an externally maintained csv file.


What is `appRoot`?


I had to comment out L132 for LSF to build properly.


That's the output directory?


What is `.` relative to?


ups wrong branch...


Fixed. Thanks.


@clecompte - Shouldn't the `dest` option here be `/img` or `dist/img`?
I guess it doesn't matter so long as it jives with the relative path set here `<%= secrets.s3.bucketpath %>` which could be a bit confusing. Thoughts?


method_missing (arBmind) - x86_64-MacOS-10.9-clang: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Merge 2


Not strictly opposed to this, but I personally consider this to be more difficult to read than the equivalent construct:

    if(!transaction || transaction->getResult() != tesSUCCESS)
        return;


Can you elaborate on why you did this? Pure curiosity.


Oooh! Nice approach in removing the mention of the site when it applies to the current course site.


VSHPWH (shenb) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.44%25-red.svg)


Mostly because the IDs are the unique part. You can't assign two names to an ID, but you can assign two IDs to a name. In the end it probably won't matter.

I've got a better question, though. FML doesn't store it as either `name -> id` or `id -> name`. It stores it as a list of `(name, id)` pairs. Why is that?


Cool. :smile:


I wish I'd been able to get someone in to talk about machine learning.  Using SciPi to build a learning vector that would be able to rate a tweet would be so much faster and better than this.

However, this is a really solid attempt at getting meaning out of human-generated text.  Good work


buuuuuuuuuuuuuu


One wonders how many more such cases there might be...


このインポートが不要です


I tried to do this and  when I run `npm test` I get the error
````
tests/test.js: line 147, col 1, 'describe' is not defined.
````
I need to install mocha globally and run `mocha tests/test.js` for this to pass.

Will that cause a lot of problems? Will this cause problems with Travis?


Thanks for pointing it out. But the main problem is why there is an issue in iOS7 which GCD fixed. Have you tried this code?


A personal project that aims to help people share their start-up Ideas with each other. Tools used: Node.JS, Express4, Jade template engine, Javascript, Mongodb


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.75](http://teamcity.monogame.net/viewLog.html?buildId=5858&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@whiteknightinc:

now that i've seen basically the same code both here and in the twitter scraper I wonder why you didn't make a "evil_rater" function that would take a string and return a numeric evilness value for that string.  That could have been used across both scrapers, and would mean that if you came up with a better rating system in the future, you'd just have to re-work that algorithm, rather than rewriting both this and the twitter scraper.


@l-arnold - Yes the `+` signifies that the line has been added (obviously the green also signifies that but if you are viewing in text mode or in monochrome). The `-` signifies that teh line has been removed (and same rationale re red).


panic() still occurs when b == []byte("").


Excellent merge!


VSHPWH (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.44%25-red.svg)


is it possible to redeploy (force push) the available downloads?


by no means am i suggesting force push on the master branch, just suggesting that we update the prebuilt binaries.


It is almost always a mistake in Python to use the `global` keyword.  There is nearly always a better way to accomplish what you are trying to do when you do it.  I'd love to hear a sales pitch for why this is required.


There is another way to do this without bind, using lambdas (not necessarily better):
```C++
// std::function is basically a generic function pointer type, a function pointer can be converted
// implicitly to a std::function, but lambdas and results of bind also convert to std::function
void map::draw_loop( ..., std::function<void *draw_func(int,int,lit_level)> draw_func);

void map::draw() {
    auto map_draw_function = [w, center](int x,int y,lit_level l) {
        draw_specific_tile(w, center, x, y, l);
    });
    draw_loop( ..., map_draw_function );
```


I only looked into this because I was annoyed my builds were timing out on OS X Travis and AppVeyor and the BitArray tests were among the slowest to run. That loop still takes a decent amount of time to run, but the situation is substantially improved.

I think most test time is compilation time and not runtime, and so we probably can't do much. I'll try running the tests twice in a single process and see which are still slow the second time around.


VSHPWH (shenb) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Oh hi! I just noticed both of you maintain mods that use the .schematic format, so I assume this isn't just idle nitpicking.

This isn't the final format for the ID mapping. It will change some more once I get into item IDs, and I'll probably end up doing what FML does. So don't go implementing this one just yet ;)


Declare the function parameter as `std::function< void(int,int,lit_level)>` and you can remove the template parameter and put the function body into the cpp file. A lambda, which you used, is compatible with that `std::function`.


Good catch!


Looks good.


should be sorted in

https://github.com/discourse/discourse/commit/cfa511e35de2dd5577b8e0e790e3545bf4ba5f87


This makes sense. Looks good.


Thanks, that sounds like what I was looking for. I couldn't figure out how to get a known-type callable as the parameter instead of templating.


This works like I would expect.  It is much easier to use now.


I'm not quite sure if changes made to this files are to blame, but with the unstable branch my png background image do not display anymore. With 2.3.11 they are fine.


commit


```java
            if (TransactionManager.isInTransaction()) {
                if (!isParseSucceeded) {
                    TransactionManager.abortTransaction();
                    resetProjectAccessor(iCurrentProject);
                } else {
                    TransactionManager.endTransaction();
                }
            }
```
とした方がすっきりすると思います。


Asegurar que el módulo pyqrcode es el correcto, dice Mauricio que hay varios con el mismo nombre


I like the short form provider for resolution. Looks good.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1154
success: http://build.servo.org/builders/linux2/builds/1153
success: http://build.servo.org/builders/android/builds/1188
success: http://build.servo.org/builders/mac1/builds/1367
success: http://build.servo.org/builders/mac2/builds/1370
success: http://build.servo.org/builders/gonk/builds/336


Ok, yo reviso si es el correcto...


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.75](http://teamcity.monogame.net/viewLog.html?buildId=5858&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 462, ignored: 6 Build time: 00:14:22


:dancer: \o/


fast-forwarding master to auto = 88ca398c


Just a note:

The usual procedure for building for a specific arch is usually:
ARCH=<arch> make

Not all OSX versions come with a 64-bit kernel enabled by default.


そして、下記のように否定を無くしたほうがさらに読みやすいと思います。
```java
            if (TransactionManager.isInTransaction()) {
                if (isParseSucceeded) {
                    TransactionManager.endTransaction();
                } else {
                    TransactionManager.abortTransaction();
                    resetProjectAccessor(iCurrentProject);
                }
            }
```


you're right, it is.  I'll remove this - thanks.


3e305e01386829eaffdf8ffea0df12068aa03899 で修正しました。


できるだけコミットコメントを記入するようにしてください。


Not sure if you're currently aware but these recent commits seem to have broken a lot of things


saw approval from jdm
at https://github.com/nnethercote/servo/commit/ce36e574f4f404d7b0c8d15d3d55ea62fca8deb6


merging nnethercote/servo/profiler-renaming = ce36e574 into auto


nnethercote/servo/profiler-renaming = ce36e574 merged ok, testing candidate = 6cf273d2


If I check out this commit, images are shown in my graph. But if I use the most recent unstable version, they don't. Any clue?


Thanks Bartosz! I have something in mind to prevent this!!


@jdurgin thanks josh. i see, but the chance is small, i guess. i will remove this change from this PR, but i tend to post another PR to fix this. just don't feel right at seeing this ...


Broadcast Games mean played game


Agregar DescargaSAT a línea 17


Reviewed great job


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


> `T d = dot(a, b); // dot?! what on earth is dot? and what is a?`

In some languages, this is considered the preferred way to write it. It takes a different thinking style though.


This should be scoped to room id


そもそもTransactionManager.abortTransaction();をしてもプロジェクトが元に戻らないのって何でなんでしょう？


@fenollp this is called from cb_devices_v1/v2 , now we can't create new devices, only edit existing


This should be scoped to room id aswell.


Yeah I'm pretty sure i've missed a line or two somewhere in a few files that has borked it. I'm at work so can't actually test it at the moment so I'll fix it all up when I get home.


@y-zhou
上記にいろいろ書きましたが、直すか直さないかはお任せします。
一旦リオープンします。


Looks like we used to stop finding solutions when a single solution is found for the original equation.
Did this cause the bug?


We also have a small puzzle re: token refresh. I need to look more closely at our use of `httr` and at what `httr` does re: refresh. But anecdotally we noticed that accessing a different "feed" , in the vocabulary of the Sheets API, reliably refreshes the token, when needed. The "feed" terminology corresponds to endpoint, I think, more generally. So if that is an option for you, try that in interactive use to see if it makes your lack-of-refresh problems go away. But maybe this is exactly what you are referring to above re: the call to google in the testthat helper file. In which case, no, I got no voodoo for you.


Por el momento no comentar estas líneas


haha. Thanks for the posi vibes. I'm feeling good!


What's this for, and what else is required?


No idea... that's just what coverage uses. Presumably it's meant to indicate an extension, like '.', but I guess to be extra clear that the file isn't a "normal" file?


@jksuom : Nice rearranging of the code, now things a cleaner and clearer !


Shouldn't the get like count be in a separated method?


Sorry I am in mobile now. I'll check this commit tomorrow.


@marcellosachs This caused a couple of spec failures:

```
  1) Classroom when is created must have a unique name
     Failure/Error: expect(other_classroom.errors[:name]).to include("A classroom called #{@classroom.name} already exists. Please rename this classroom to a different name.")
       expected ["has already been taken"] to include "A classroom called classroom 175 already exists. Please rename this classroom to a different name."
     # ./spec/models/classroom_spec.rb:49:in `block (3 levels) in <top (required)>'

  2) Create-a-Class page when signed in as a Teacher with an existing class cannot create a new class with the same name
     Failure/Error: expect(create_classroom_page).to have_content(
       expected to find text "A classroom called Sweathogs already exists" in "Menu Discover Community Support Profile Logout Scorebook Activity Planner Class Manager Progress Reports Invite Students Manage Classes Create a Class Create Your Class Name has already been taken 1 2 3 4 5 6 7 8 9 10 11 12 University Class Code Generate a New Code Create Class hello@quill.org 1 (646) 825-7136 Support Terms Privacy"
     # ./spec/features/teacher/class_manager/create_class_spec.rb:97:in `block (4 levels) in <top (required)>'
```


> Apparently std::forward() is constexpr only in C++14. Heh.

I don't know what the error as you were getting, but there is no such thing as `constexpr`-_only_ - [`constexpr` functions](http://en.cppreference.com/w/cpp/utility/forward) can be called at runtime without issue. Adding `constexpr` to a function definition _increases_ the ways you can call it, not the other way around.

I am curious though, do you still have the specific error?


We never put RE in Desura in the first place; they took our game, put it up
on their website, then demanded we maintain it. The process of maintaining
third party websites is hard enough without the extra hoops Desura makes
you jump through.

At one point they blocked our binary packages because I wouldn't upload
their in house MCF format files for their digital distribution platform.
The process of making these files is tedious and requires you to download
and install their frontend client then upload it from your home connection
(there's no way to create and upload these files from our build servers).

I hope that helps answer your question.

On Thu, 26 Mar 2015 02:49 freezurbern <notifications@github.com> wrote:

> Desura was dropped because of some of their requirements they put on the
> developers. Someone else can probably explain the details, but the jist i
> got from it was Desura requires you to use their client to make a file for
> getting your game included, as well as their admins being rather
> unuseful/rude.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/red-eclipse/site/commit/36ffd53e8adb42677e8ef7afa26f6d9e5d8973fa#commitcomment-10394423>
> .
>


@chrisrogers this is what you need to style ;)


Do you happen to remember the purpose of this commit, @stensrud?  It seems to be causing issues (skipping all other validations when `required: false`) per #867.


I`ve read http://www.w3.org/TR/void/#contactinfo one more time and decided not to delete these lines. Here http://lod.ifmo.ru/resource/Person145348 u don`t have contact information.


VSHPWH (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (639 of 639 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.21%25-green.svg)


Sao đoạn này e ko viết là: $subject = Subject::find($examination->subject_id); ?
Dùng hàm findSubject, mình lại phải query lại cái examination.


Could be Denver doesn't handle flush to zero?  Note of course that bForceFlushToZero defaults on on arm32, not sure about arm64.

-[Unknown]


+1 works for me


some tests failed:
failure: http://build.servo.org/builders/gonk/builds/337


One of your previous commits had this loop start / end at `min_x` / `max_x`. Why iterate over the whole map, when explicit start and end points are given?


$answerSheet = new AnswerSheet();
Dòng này ko cần đến


Awesome thanks!  Will update all the things.


We don't tend to add authors in the rest of the project, so please don't here.


Я думаю, можно принять то, что C++11 уже достаточно распространен, поэтому инициализатор указателя можно написать прямо здесь, и тогда не надо будет переписывать столько конструкторов ниже. Кроме того, я против инициализации указателей нулями - хотя бы NULL, но сейчас уже nullptr.


In which situation could ```self.lazy``` be ```True``` while at the same time ```fh``` not be ```None```.
And even if ```self.lazy is True``` while ```fh is not None``` why would we not want to try and close that file handler ?


Yeah ! :+1:


Aquí no falta mucho, sólo añadir unos cuántos métodos más y traducirlos


Ok thanks :)


This is a duplicate of the one in ``GcmRegistrationManager:23`` - can we factor this out?


Please don't add an author comment here.


Where does this version comes from ? I'm lost @trongtt


este test se borra, todo el fichero y se usa [este](https://github.com/RecuencoJones/Hibernate-One-To-One/blob/master/src/main/java/db/Test.java)


Are you sure that this change works.
I'm trying this commit in local and it's not working.


how about add this to the documentation?
https://github.com/dresende/node-orm2/wiki/Model-Properties very poorly describes all available options


cool. this probably warrants an optional parameter then.


esta clase desaparece, sustituida por [esta](https://github.com/RecuencoJones/Hibernate-One-To-One/blob/master/src/main/java/db/SessionProvider.java)


I'm not against such change but:
1/ You'll have to ask me to update the acceptance deployment
2/ It should have been cleaner to squash this change into the commit which created the branch and updated the versions


Комментарии в проекте все (я надеюсь, что уже все) на английском.


KITTEH! :D


To user info jest bardzo brzydkie. Dziedziczysz z UIAlertController, masz wiec pola title i message, czemu ich nie wykorzystasz w medodzie showAlert?a controller sobie przechowaj w klasie, zrob do tego property.


nazwy metod w swiftcie. Skoro jest WithDelay to pierwszy parametr powinien byc delay.


Replacing spaces by tabs


dismiss zamiast dismissalert, przeciez dismisujesz siebie a nie jakis inny alert.


this improved the cflags situation
https://github.com/libressl-portable/portable/commit/ad2a38ab4ae5d542206527dfa59a333352ea99ce


POSIX.1-2008 marks gettimeofday() as obsolete, recommending the use of clock_gettime(2) instead.


I was thinking about it, but wasn't completely sure compiler will like it. But I guess it should be fine.


Nie ma potrzeby alokowania tutaj timera, za chwile stworzysz go ponownie w metodzie showWithDelay(). Szkoda zasobow.


@kdambekalns With this change, my functional tests for flow application return following error:

```
Uncaught Exception in Flow #1355480641: Uncaught Exception
  The given configuration path in the pointcut designator "setting" did not
  exist. Got: "TYPO3.TYPO3CR.Search.realtimeIndexing.enabled"
```

Do I have to adjust something for that since I don't have TYPO3CR in Flow?


В тестах тоже хорошо бы комментарии переписать на английском.


Would it work to have more generic instances?

```haskell
instance Option a => Option [a]
instance Option a => Option (Maybe a)
```


Cherry-picked as 81b080cbd285779867327


If it's just to make sure that ```self.logger``` is initialized then could we not use:
```python
if not self.logger:
    self.logger = logging.getLogger("PidFile")
```
or
```python
if self.logger:
    self.logger.debug("%r closing pidfile: %s", self, self.filename)
```
or
```python
@property
def logger(self):
    if not self._logger:
        self._logger = logging.getLogger("PidFile")
    return self._logger
```

Although all three have there own slight difference in behavior.

Right now I would be afraid that if for some (unlikely) reason ```self.lazy``` would be ```True``` the file handler would not be closed.


This isn't thread safe.


Correct, will be changed.


You missed the metadata header - it should look like this, including the --- bits at the beginning and end.

---
title: <Job Advert Title (required)>
company: <Your Company (required)>
url: http://<Link to your site/a job spec (optional)>
location: <where is the job based? e.g. London,England>
contract: permanent (or contract/temporary/part-time ..)
contact:
    name: <Your name (required)>
    email: <Email address applicants should submit to (required)>
    phone: <Phone number (optional)
    ...: ...
created: !!timestamp '2015-02-20' <- The date the job was submitted
tags:
  - london
  - england
  - uk
  - python
  - sql
  - django <- include as many tags as you want
---


When you specify a partial you can leave out the file extension. 'comments/form' will do.


could use `multiset<TrackedOp *>` as an ordered container. which would be easier for other readers.


Headings should be written like this:
```
# Job Description
```


Remember to include these in your tags


That information should be in the contact section in the metadata header.


we have 300 wins more than loses, and the LLR is at -1.45 , I think the test bundles are too harsh


I don't understand - why does this hunk belong in this commit?


Same question for this hunk.


The rules are that you have to include the name of the client if you are not hiring for yourself.


Updated documentation and fixed test.


Can we have the module name in the error message please?


I commented this out because it was calling xarr.x_in_frame


As you mentioned in the submission, this won't work as you expect.

Consider instead using

    vote = Vote.new value: 5
    expect(vote.valid?).to eq(false)
    # also this could be an alternative too...
    # expect(vote).not_to be_valid


What is a best way right now? :)

CoffeeScript had awesome `nodes.value?` construction for this cases ^_^


Could this maybe be added to 1.2.x ?


Hey, you removed those lines from __modules/swagger-codegen/src/main/resources/META-INF/services/com.wordnik.swagger.codegen.CodegenConfig__:
* -com.wordnik.swagger.codegen.languages.SwiftGenerator
* -com.wordnik.swagger.codegen.languages.ThreePane

but I think they should have stayed


Hi! `Gemfile.lock` should be ignored in gems, isn't it?
http://stackoverflow.com/a/4151540


- `button` instead of `a` would probably be better semantics
- `data-href` (the link is ajax-only, and GET-ing it wouldn't even work)
- `js-delete-email` (the class is only for js, not for styling)


These spaces break the Makefile: `Makefile:22: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.`


Comments, some more info that you would like to know?


Won't this overflow the existing array if the string is too long ?


```
$this.closest('.js-email-row').fadeOut(function() {
    $(this).delete()'
})
```


Read some mysql documentation on nested joins. According to the examples given, it needs a few parenthesis. So it would be:
```
JOIN ({groups} gpg
    JOIN {users_in_groups} gpuig ON gpg.group_id = gpuig.group_id AND gpuig.user_id = ?
) ON gpg.project_id = 0
LEFT JOIN ({groups} pg
    JOIN {users_in_groups} puig ON pg.group_id = puig.group_id AND puig.user_id = ?
) ON pg.project_id = t.project_id
```
which is fine with postgresql too. Could you test?


If `nodes` is an object, I would say `nodes.value === undefined` is totally correct since `undefined` cannot be modified since es5.


`error: handleAjaxError` would work, too (also, the first argument of error is `xhr`, not `data`)


I caz write comments


This isn't right.

If I do this:

1. Login using my @xamarin.com account.
2. Log out
3. Login using my @gmail.com account.

It will log me in using my @xamarin.com account.

IMO the logic to save this as a session state is not needed, and can be completely removed.


Hm. Maybe I should change assets. But we need to change all asserts in PostCSS to have same style :)


:cancer: :bear: is going to slap you with a :cactus:

Leaking globals is baaaad; let's add a `var` to avoid it ;)


This is handled in DBLogin_Extensions.LoginOpenId (the code that uses `OpenIdRoles`), and can be removed.


because it prevents the usage from displaying $allcmds


@DarkPark it's a wki you can contribute to yourself :)


@Tharos Still not tagged? :) Any estimates?


it was duplicated by the code below anyway


Instead of removing the check, you should add a check for OAuth as well (`&& string.IsNullOrEmpty (Configuration.OauthClientId)`)


This picture is missing, please check @vpadois


Its just beautifying the runcmds list. This looks nicer in the usage. Otherwise the indentation will be different for some lines.


This should be squashed into the commit that introduced the CWLs.


You don't seem to define that one anywhere


idd, I should've added a wip tag


1: M110 missing component name


Is this stripping symbols out of the binary?

Is this to obfuscate the proprietary usage of open source components in ways that violate the software license?


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


1: M111 unrecognized component name: template


28:1: I101 Imported names are in the wrong order. Should be BlueprintAutoDiscoveryRegistry, ConfigurationRegistry, ExtensionRegistry, PackageRegistry, Registry
31:1: I201 Missing newline before sections or imports.
32:1: I201 Missing newline before sections or imports.
34:1: I101 Imported names are in the wrong order. Should be unicodifier, with_app_context
263:9: B901 blind except: statement


86: D202 No blank lines allowed after function docstring (found 1)
86: D400 First line should end with a period (not 'd')
86: D205 1 blank line required between summary line and description (found 0)
127:59: W604 backticks are deprecated, use 'repr()'
131: D203 1 blank line required before class docstring (found 0)
131: D204 1 blank line required after class docstring (found 0)
131: D200 One-line docstring should fit on one line with quotes (found 3)
138: D203 1 blank line required before class docstring (found 0)
138: D400 First line should end with a period (not 'f')
138: D205 1 blank line required between summary line and description (found 0)
151: D400 First line should end with a period (not 'e')
159:31: E261 at least two spaces before inline comment
171: D210 No whitespaces allowed surrounding docstring text
171: None: None
180: D210 No whitespaces allowed surrounding docstring text
180: None: None
180: D209 Multi-line docstring closing quotes should be on a separate line
180: D202 No blank lines allowed after function docstring (found 1)
180: D400 First line should end with a period (not 'f')
180: D205 1 blank line required between summary line and description (found 0)
212:26: E127 continuation line over-indented for visual indent
220:13: E266 too many leading '#' for block comment
221:13: E266 too many leading '#' for block comment
222:13: E266 too many leading '#' for block comment
223:13: E266 too many leading '#' for block comment
247: D210 No whitespaces allowed surrounding docstring text
247: None: None
247: D202 No blank lines allowed after function docstring (found 1)
247: D400 First line should end with a period (not 'y')
265: D210 No whitespaces allowed surrounding docstring text
265: None: None
265: D209 Multi-line docstring closing quotes should be on a separate line
265: D202 No blank lines allowed after function docstring (found 1)
265: D400 First line should end with a period (not 's')
265: D205 1 blank line required between summary line and description (found 0)
269: D210 No whitespaces allowed surrounding docstring text
269: D401 First line should be in imperative mood ('Thi', not 'This')
269: None: None
277:13: E266 too many leading '#' for block comment
300:13: E266 too many leading '#' for block comment
305:13: E266 too many leading '#' for block comment
306:13: E266 too many leading '#' for block comment
307:13: E266 too many leading '#' for block comment
313:13: E266 too many leading '#' for block comment
328:17: E266 too many leading '#' for block comment
333:13: E266 too many leading '#' for block comment
337:17: E266 too many leading '#' for block comment
338:17: E266 too many leading '#' for block comment
339:17: E266 too many leading '#' for block comment
352: D202 No blank lines allowed after function docstring (found 1)
352: D400 First line should end with a period (not 'n')
352: D205 1 blank line required between summary line and description (found 0)
422:13: B901 blind except: statement


I thought since you inked me to that file to adapt from it, it was needed to put this in. Sorry :)


28:1: I100 Imports statements are in the wrong order. from invenio.utils.shell should be before from invenio.version


28:1: I101 Imported names are in the wrong order. Should be BlueprintAutoDiscoveryRegistry, ConfigurationRegistry, ExtensionRegistry, PackageRegistry, Registry
31:1: I201 Missing newline before sections or imports.
32:1: I201 Missing newline before sections or imports.
34:1: I101 Imported names are in the wrong order. Should be unicodifier, with_app_context
273:9: B901 blind except: statement


1: D400 First line should end with a period (not 'l')
1: D205 1 blank line required between summary line and description (found 0)
38:1: I100 Imports statements are in the wrong order. import gettext should be before import babel
38:1: I201 Missing newline before sections or imports.
39:1: I201 Missing newline before sections or imports.
39:1: F999 redefinition of unused 'gettext' from line 38
40:1: I201 Missing newline before sections or imports.
40:1: F401 'iteritems' imported but unused
46: D400 First line should end with a period (not 'n')
64: D209 Multi-line docstring closing quotes should be on a separate line
64: D400 First line should end with a period (not 's')
64: D205 1 blank line required between summary line and description (found 0)
64: D208 Docstring is over-indented
82: D209 Multi-line docstring closing quotes should be on a separate line
82: D400 First line should end with a period (not 'e')
82: D205 1 blank line required between summary line and description (found 0)
82: D208 Docstring is over-indented
97: D400 First line should end with a period (not ',')
97: D205 1 blank line required between summary line and description (found 0)
116: D401 First line should be in imperative mood ('Return', not 'Returns')
116: D400 First line should end with a period (not 's')
116: D205 1 blank line required between summary line and description (found 0)


The logic below to log in the user is executed even if IsSuccessful is false.


1: D100 Missing docstring in public module


1: D400 First line should end with a period (not 'o')
1: D205 1 blank line required between summary line and description (found 0)
65:1: I201 Missing newline before sections or imports.
73: D101 Missing docstring in public class
76: D102 Missing docstring in public method
80: D102 Missing docstring in public method
86: D400 First line should end with a period (not 'n')
86: D200 One-line docstring should fit on one line with quotes (found 3)


1: D100 Missing docstring in public module
20:1: I101 Imported names are in the wrong order. Should be abort, current_app
21:1: I101 Imported names are in the wrong order. Should be AdminIndexView, BaseView
21:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio.ext.principal should be before from invenio.ext.sslify
30: D400 First line should end with a period (not 's')
30: D200 One-line docstring should fit on one line with quotes (found 3)
49: D203 1 blank line required before class docstring (found 0)
49: D204 1 blank line required after class docstring (found 0)
49: D400 First line should end with a period (not 's')
49: D200 One-line docstring should fit on one line with quotes (found 3)
57: D210 No whitespaces allowed surrounding docstring text
57: None: None
57: D400 First line should end with a period (not 'n')
70: D401 First line should be in imperative mood ('Thi', not 'This')
70: D200 One-line docstring should fit on one line with quotes (found 3)
80: D400 First line should end with a period (not 'r')
80: D200 One-line docstring should fit on one line with quotes (found 3)
88: D200 One-line docstring should fit on one line with quotes (found 3)
98: D203 1 blank line required before class docstring (found 0)
98: D204 1 blank line required after class docstring (found 0)
98: D400 First line should end with a period (not 's')
98: D200 One-line docstring should fit on one line with quotes (found 3)
111: D203 1 blank line required before class docstring (found 0)
111: D204 1 blank line required after class docstring (found 0)
111: D200 One-line docstring should fit on one line with quotes (found 3)


52:1: I101 Imported names are in the wrong order. Should be current_app, jsonify, request
52:1: I100 Imports statements are in the wrong order. from flask should be before import requests
53:1: I201 Missing newline before sections or imports.
54:1: I201 Missing newline before sections or imports.
56:1: I100 Imports statements are in the wrong order. from invenio.utils.xmlhelpers should be before from lxml.etree


44:1: I101 Imported names are in the wrong order. Should be Bundle, CleanCSSFilter, RequireJSFilter


23:1: I201 Missing newline before sections or imports.
24:1: I100 Imports statements are in the wrong order. import warnings should be before import pkg_resources
24:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.


24:1: I201 Missing newline before sections or imports.
25:1: I101 Imported names are in the wrong order. Should be _request_ctx_stack, current_app
25:1: I100 Imports statements are in the wrong order. from flask should be before import six
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
235:9: B901 blind except: statement


24:1: I201 Missing newline before sections or imports.
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from webassets.filter.requirejs should be before from werkzeug.utils
28:1: I201 Missing newline before sections or imports.
29:1: I100 Imports statements are in the wrong order. from webassets.filter should be before from webassets.filter.requirejs


23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from babel should be before import six
27:1: I100 Imports statements are in the wrong order. from contextlib should be before from babel
27:1: I201 Missing newline before sections or imports.
28:1: I101 Imported names are in the wrong order. Should be _request_ctx_stack, current_app, g
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
32:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from .errors should be before from .selectors
90:5: E266 too many leading '#' for block comment


22:1: I101 Imported names are in the wrong order. Should be current_app, request, session
23:1: I201 Missing newline before sections or imports.
32:9: E266 too many leading '#' for block comment
33:9: E266 too many leading '#' for block comment
36:13: E266 too many leading '#' for block comment
39:9: E266 too many leading '#' for block comment
42:13: E266 too many leading '#' for block comment
43:13: E266 too many leading '#' for block comment
46:13: E266 too many leading '#' for block comment
54:17: E266 too many leading '#' for block comment


1: D400 First line should end with a period (not 'e')
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
33: D202 No blank lines allowed after function docstring (found 1)


28:1: I201 Missing newline before sections or imports.


52:1: I100 Imports statements are in the wrong order. from urlparse should be before import requests
52:1: I201 Missing newline before sections or imports.
54:1: I101 Imported names are in the wrong order. Should be current_app, jsonify, request
55:1: I201 Missing newline before sections or imports.


1: D400 First line should end with a period (not 'n')
1: D205 1 blank line required between summary line and description (found 0)
27:1: E402 module level import not at top of file
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
36:1: F999 redefinition of unused 'MIMEMultipart' from line 35
36:1: E402 module level import not at top of file
37:1: F401 'MIMEText' imported but unused
37:1: E402 module level import not at top of file
38:1: E402 module level import not at top of file
39:1: I201 Missing newline before sections or imports.
39:1: E402 module level import not at top of file
40:1: I101 Imported names are in the wrong order. Should be EmailMessage, EmailMultiAlternatives
40:1: I201 Missing newline before sections or imports.
40:1: E402 module level import not at top of file
41:1: I101 Imported names are in the wrong order. Should be AbstractFormatter, DumbWriter
41:1: I100 Imports statements are in the wrong order. from formatter should be before from flask_email.message
41:1: I201 Missing newline before sections or imports.
41:1: E402 module level import not at top of file
42:1: I101 Imported names are in the wrong order. Should be StringIO, iteritems
42:1: I201 Missing newline before sections or imports.
42:1: E402 module level import not at top of file
43:1: I100 Imports statements are in the wrong order. from time should be before from six
43:1: I201 Missing newline before sections or imports.
43:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
51:1: E731 do not assign a lambda expression, use a def
86: D400 First line should end with a period (not 'd')
86: D205 1 blank line required between summary line and description (found 0)
99:25: E124 closing bracket does not match visual indentation
140:8: E714 test for object identity should be 'is not'
142:8: E714 test for object identity should be 'is not'
158: D301 Use r""" if any backslashes in a docstring
158: D400 First line should end with a period (not 'y')
158: D205 1 blank line required between summary line and description (found 0)
267:53: E502 the backslash is redundant between brackets
268:25: E128 continuation line under-indented for visual indent
268:50: E502 the backslash is redundant between brackets
268:28: E251 unexpected spaces around keyword / parameter equals
268:30: E251 unexpected spaces around keyword / parameter equals
269:25: E128 continuation line under-indented for visual indent
269:50: E502 the backslash is redundant between brackets
269:28: E251 unexpected spaces around keyword / parameter equals
269:30: E251 unexpected spaces around keyword / parameter equals
270:25: E128 continuation line under-indented for visual indent
270:44: E502 the backslash is redundant between brackets
270:31: E251 unexpected spaces around keyword / parameter equals
270:33: E251 unexpected spaces around keyword / parameter equals
271:25: E128 continuation line under-indented for visual indent
271:46: E502 the backslash is redundant between brackets
271:35: E251 unexpected spaces around keyword / parameter equals
271:37: E251 unexpected spaces around keyword / parameter equals
272:25: E128 continuation line under-indented for visual indent
272:35: E251 unexpected spaces around keyword / parameter equals
272:37: E251 unexpected spaces around keyword / parameter equals
301:24: F821 undefined name 'CFG_SITE_ADMIN_EMAIL'
301:46: F821 undefined name 'CFG_SITE_ADMIN_EMAIL'
314: D200 One-line docstring should fit on one line with quotes (found 3)
325: D209 Multi-line docstring closing quotes should be on a separate line
325: D205 1 blank line required between summary line and description (found 0)
428:21: E266 too many leading '#' for block comment
440:13: B901 blind except: statement
465: D401 First line should be in imperative mood ('Remove', not 'Removes')
465: D400 First line should end with a period (not 'n')
465: D205 1 blank line required between summary line and description (found 0)
487: D400 First line should end with a period (not 's')
487: D205 1 blank line required between summary line and description (found 0)


1: D400 First line should end with a period (not 'o')
1: D205 1 blank line required between summary line and description (found 0)
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from flask_email.backends.console should be before from .
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file


1: D400 First line should end with a period (not 'o')
1: D205 1 blank line required between summary line and description (found 0)
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from flask_email.backends.smtp should be before from .
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file


1: D400 First line should end with a period (not 'r')
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2013


24:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from flask_registry should be before from werkzeug.utils
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.


30:3: B901 blind except: statement
35:1: I101 Imported names are in the wrong order. Should be abort, current_app, g, render_template, request, send_from_directory, url_for
35:1: I100 Imports statements are in the wrong order. from flask should be before from werkzeug.wrappers
35:1: I201 Missing newline before sections or imports.
72:5: E266 too many leading '#' for block comment
79:5: E266 too many leading '#' for block comment
130:5: E266 too many leading '#' for block comment
162:13: E731 do not assign a lambda expression, use a def


27:1: I201 Missing newline before sections or imports.


22:1: I101 Imported names are in the wrong order. Should be current_app, has_request_context, request, session
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures
63: D203 1 blank line required before class docstring (found 0)
168:9: B901 blind except: statement
215:9: B901 blind except: statement
241:17: W503 line break before binary operator


> because it prevents the usage from displaying $allcmds

I don't understand why you say that, because the hunk prevents `usage` from being called at all, rather than changing the contents of the `usage`.


Thanks, @agorrod!


Also my point was that AFAICS it's not related to the heredoc conversion, so it should be in a separate commit (which explains what it's doing).


＋1


I think this change is important. Why can't this be merged?


This is exoplatform/stable/3.7.x actually


thx savoca for this wonderful function


这个程序违反了递归的原则，即每次调用，必须包括更小的参数。虽然这这个程序能正常运行，但当N大小界限不确定是它未必能正常工作。


`@awesomeThings` should be `this.awsomeThings` ?!


Maybe I'm missing something but again I don't see how that's related to the heredoc conversion.  Remember this rule from https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes:

> If a code change can be split into a sequence of patches/commits, then it should be split. Less is not more. More is more.

If you kept it as a separate commit then it would have its own commit message explaining the point of the change, which would remove the need for me to ask you stupid and annoying questions ;-)


TeamCity xBIM :: XbimExchange :: Build [Build 150](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1216&buildTypeId=XBIM_XbimExchange_Build) is now running


I got `Error C2057: expected constant expression` in vc12 with `char sbuf[max]`


@chelmuth, @nfeske: please add to staging


1: D400 First line should end with a period (not 'e')
1: D205 1 blank line required between summary line and description (found 0)
59:1: I101 Imported names are in the wrong order. Should be CFG_PYDEV_DEBUG, CFG_REMOTE_DEBUGGER_ENABLED, CFG_REMOTE_DEBUGGER_IMPORT, CFG_REMOTE_DEBUGGER_NAME, CFG_REMOTE_DEBUGGER_PYDEV_PATHS, CFG_REMOTE_DEBUGGER_PYDEV_REMOTE_IP, CFG_REMOTE_DEBUGGER_PYDEV_REMOTE_PORT, CFG_REMOTE_DEBUGGER_TYPE, CFG_REMOTE_DEBUGGER_WINPDB_PASSWORD, CFG_REMOTE_DEBUGGER_WSGI_RELOAD
59:1: E402 module level import not at top of file
68:1: I100 Imports statements are in the wrong order. from invenio should be before from .config
68:1: E402 module level import not at top of file
69:1: I100 Imports statements are in the wrong order. import os should be before from invenio
69:1: I201 Missing newline before sections or imports.
69:1: E402 module level import not at top of file
70:1: I100 Imports statements are in the wrong order. import glob should be before import os
70:1: E402 module level import not at top of file
71:1: E402 module level import not at top of file
72:1: I100 Imports statements are in the wrong order. import sys should be before import traceback
72:1: E402 module level import not at top of file
73:1: I201 Missing newline before sections or imports.
73:1: E402 module level import not at top of file
76: D103 Missing docstring in public function
89:1: E303 too many blank lines (3)
98:1: E303 too many blank lines (3)
111: D202 No blank lines allowed after function docstring (found 1)
111: D400 First line should end with a period (not 't')
117:19: E222 multiple spaces after operator
130: D400 First line should end with a period (not 'y')
130: D205 1 blank line required between summary line and description (found 0)
142: D401 First line should be in imperative mood ('Return', not 'Returns')
142: D400 First line should end with a period (not 'r')
142: D205 1 blank line required between summary line and description (found 0)
164:5: E303 too many blank lines (2)
168:1: E302 expected 2 blank lines, found 1
168: D401 First line should be in imperative mood ('Parse', not 'Parses')
168: D400 First line should end with a period (not 'v')
168: D205 1 blank line required between summary line and description (found 0)
182:13: B901 blind except: statement
194: D400 First line should end with a period (not 'e')
194: D205 1 blank line required between summary line and description (found 0)
202:5: F821 undefined name 'rpdb2'
206:1: E303 too many blank lines (3)
206: D400 First line should end with a period (not 's')
206: D200 One-line docstring should fit on one line with quotes (found 3)
211:5: F821 undefined name 'rpdb2'
215:1: E303 too many blank lines (3)
215: D202 No blank lines allowed after function docstring (found 1)
215: D400 First line should end with a period (not 'e')
215: D205 1 blank line required between summary line and description (found 0)
236:9: F821 undefined name 'putils'
237:20: F821 undefined name 'pydevd'
238:13: F821 undefined name 'pydevd'
244:16: F821 undefined name 'putils'
244:56: E261 at least two spaces before inline comment
244:57: E262 inline comment should start with '# '
245:32: F821 undefined name 'putils'
246:18: F821 undefined name 'putils'
246:57: E261 at least two spaces before inline comment
247:32: F821 undefined name 'putils'
271:5: E303 too many blank lines (3)
276:5: E303 too many blank lines (2)
278:37: F821 undefined name 'pydevd'
278:61: F821 undefined name 'pydevd'
279:9: F821 undefined name 'pydevd'
282:5: F821 undefined name 'pydevd'
282:5: E303 too many blank lines (2)
288:5: F821 undefined name 'pydevd'
294:1: W391 blank line at end of file


TeamCity xBIM :: XbimExchange :: Build [Build 150](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1216&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:31


Nice work, I look forward to using the matrix distance API (in optaplanner-webexamples), once it's part of a release! :)


PluginsZipListener name is misleading as it gives a feeling that this class listens to plugin-zip change event. Whereas this is responsible for recreating the zip if any of the plugins change.


Resultado final?


You can just add a getPlayer() method and plugin developers can use:
`getPlayer("test").getInventory().clear()` to do the clearInventory() method's work. :)


ok I didn't see you changed it too https://github.com/exoplatform/gatein-portal/commit/263054fdd4262cf718d74daeb1df1679955f683b


> What made you decide to go with the "Control.Lens" namespace? I thought you were one of the proponents of the "Package name as top-level namespace" convention.

For my own new packages, yeah. In this case I'm just following the convention of the package I'm making a subset of. I don't know Ed didn't go with `Lens` but go figure.

> I have one request. I feel that signatures like Lens s s' a a' and (a -> f a') -> (s -> f s') and etc. provide a much stronger intuition into what goes where as opposed to Lens s t a b and (s -> f t) -> (a -> f b). In the light of presence of so many parameters this becomes critical. What do you think?

I think that's a matter of taste; prelude functions like map are `(a -> b)`, not `(a -> a')`, I don't think at any rate the type should be considered in isolation, the [docs](https://hackage.haskell.org/package/basic-lens-0.0.0/docs/Control-Lens-Basic.html#g:1) explain what the types are for (something the `lens` package doesn't even bother to do, which partly motivates my rewriting of all the docs for this module). But otherwise I would like to maintain compatibility with the naming conventions of `lens` and the literature (such that it is) surrounding it.


Sorry, I don't know the changing version name will impact to acceptance deployment.

The work is still in progress (about finished now). Too many tiny works, that's why I wanted to just commits needed things first to get all projects builds green. Then I will do the clean-up with git squash


@tfnico first I agree with having "Other news" instead of "From outside the list"

About "From the mailing list" and "Discussions", I prefer "Discussions" because this way maybe we can add an "Interview" section there.

But maybe we should use "Articles" instead of "Discussions", so that it is clear that "big" news items are under it and other small items are under "Misc Git News".

Or what we can do is have "Interview" at the same level as "Discussions" and "Misc Git News" when there is an interview.

cc @gitster as he suggested "Discussions"


this hunk should probably be removed: dependencies are usually specified in the $MODULE-prereqs.cmake file. the reason MPI and cmake are there is not entirely clear to me, but I guess that they need to be enabled for all upstream modules if some downstream module wants to use them. (even if the upstream modules do not depend on them...)


this file must probably renamed to "FindPETSc.cmake" (mind the lower-case 'c'), else I get this:

```
-- Finding package PETSc using module mode
CMake Warning at cmake/Modules/OpmFind.cmake:147 (find_package):
  By not providing "FindPETSc.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "PETSc", but
  CMake did not find one.

  Could not find a package configuration file provided by "PETSc" with any of
  the following names:

    PETScConfig.cmake
    petsc-config.cmake

  Add the installation prefix of "PETSc" to CMAKE_PREFIX_PATH or set
  "PETSc_DIR" to a directory containing one of the above files.  If "PETSc"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  cmake/Modules/OpmFind.cmake:211 (find_and_append_package_to)
  cmake/Modules/OpmLibMain.cmake:112 (find_and_append_package_list_to)
  CMakeLists.txt:133 (include)
```

the same applies to `UsePETSC.cmake'


+1, a horray for documentation


lower case 'c'?


Most probably YES...


Your CodeIgniter URL is wrong ;) http://www.codeigniter.com/


Making it an i-button looks pretty ugly :/


public static readonly string AssembliesDir = Path.Combine(AppDataDirectory, "1") + "\\";
"1" should be "Assemblies"


大神~ 这里的超链接前后记得加空格哟~
话说大神竟然只报中级的，让我只敢报初级的了！


ah it's just an icon. nevermind in that case. `a href=#` it is ;)


does l3_agent_pkg also include the metada agent?


I agree. I thought calling mkvSetTrackMask before would be more important than what really is (it just clears some queues).
I'm testing with that block before the seeking loop and so far every file I tried works the same as before. I just committed that change.


please no unnecessary external kraaken dependencies if possible.


if DVR is enabled linux bridge is not supported. Maybe we should add a check for that


AWESOME!


OK


ok


Forget that, just seen it below


I just realized (by inspection) that, for everything to match, `read_size` should return `size_t`, since that's used to initialize this field.


it should work also with GRE,  I am testing that actually. Maybe you should check that l2 pop is enabled, that's another requirement.


This method can be inlined to handle


except for this dict, the other changes to this file are not merged.


This needs to be dynamic for cross build refreshes and Versions.scalaBinary is not.


Jdjcjfe


I object.
The usage could be called with this code being in place (I just verified it). But the displaying of the steps was not possible. The function that expands the steps is defined below the usage. And thus the call of usage must happen below that as well.
The code for this was even already there (line 1449 in my last commit). This removed snippet was just duplication.


Is testing for a `running` state really the right check here? Doesn't it rather depend on the kind of the system? On virtual machines we don't clean up, on local or other static hosts we do.


What is missing here is a test for getAllIds(), since currently it returns the internal list of IDs that can be modified by the caller and propagated into the cache.


That would be a really nice thing. I will also make it more efficient (and possible) in the near future to deal with bigger matrices, but step by step :) ...


you mean, the Montserrat font? Well, it is a design requirement, how to
deal with it?

2015-03-26 11:43 GMT+01:00 Stefan Marsiske <notifications@github.com>:

> please no unnecessary external kraaken dependencies if possible.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rafapolo/certcheck/commit/617b7c65318421417ad659ffe3fb659919546594#commitcomment-10408942>
> .
>

--
Rafael Polo
extrapolo.com


Well it is directly related to this conversion. If I splitted it off then there would be one commit that is broken. I thought that we should combine commits that can not live without another one.


@jleclanche Please indent properly the content of these hints. Also I don't think using `\n` is actually useful for the dashboard.


The installation of the webapp system before others is not a really good ideas because at this point the system don't have many space allowed. The partition resizing is the first task done by poppy_setup.sh. After the first system reboot the webapp system and the wireless manager will be automatically added by the installer.
I think this "optional" line is not a good ideas!


I remember there was some discussion on that earlier, and to be honest I can't remember the conclusion. It seems to me though, honestly, that we're not entirely consistent with regards to using the project's stylistic capitalisation, all-lower or all-upper or first-letter-capitalised. It's a trivial fix though, and I agree.


TeamCity xBIM :: XbimExchange :: Build [Build 151](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1218&buildTypeId=XBIM_XbimExchange_Build) is now running


Also this image exp3_both is missing @vpadois


is this php code from kiosk transformed to js code? :-)


ok


So this will change in the future? Ie standalone should have no chrome


Since we do not even know if scr is terminated, shouldn't we better return something like "return strlen(dest) == dest_size"?


Why this tizen differnece?


well browser is allowed here... in that case we should just open in external browser


TeamCity xBIM :: XbimExchange :: Build [Build 151](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1218&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:26


@andyberry88, can you explain the inter-play between the 1 second polling time (e.g. `new FileAlterationMonitor(1000)`) and the 1 minute sleep time (e.g. `Thread.sleep(60000)`)?


the font or the leaking stuff to google?


Sure, we can change it to that.

With regards to MPI - the reasoning for this is that PETSc provides its own MPI-for-uniprocessor implementation "to get everything compiling" that it depends on, in the case it didn't get a system provided one, but it cannot use that if some system MPI is available.

Anywho, I don't think it is unreasonable to either
* Require MPI when using PETSc
* Disallowing PETSc without general MPI support.

It's worth noting that since then I found out PETSc has a --use-mpi=0 configuration flag, so apparently it can run even without MPI, meaning these checks needs some sophistication.


The crucial line is actually `m2t.content.name = 'tikzpicture';` on line 492 in `saveToFile()`, where the environment name is set. I am leaving this here for clarification. No action necessary.


typo: **repository**


All other USE_* are in all-caps - I intended it to be consistent with that.


These aren't just used in the dashboard...


du grim


Also known as TUCK.


ah, got your point. I will convert it to web font now...


kæft


Oh, that's very interesting. The tests seem to be either/or: either they run much faster the second time, or they take basically the same time. Digging into it just a little: for linalg2, would you have guessed that a major chunk of the time is spent on [one line](https://github.com/JuliaLang/julia/blob/176f9bcdc7e745560107038c6fd7333e85bb4c57/test/linalg2.jl#L339)? That was not obvious to me just from looking at the source code.

I'm sure you noticed this too, but I can run the broadcast test twice without issue; it must be the combination of tests that causes the segfault.


Can you use the one line test :
parent? parent...  : 0


pik


Mrs.Funny


:) thx


Why did you add the `layoutName: false` here?


I don't get this fix. table height must not contain the border spacing? Is this spacing only outside?


You can use a bit more descriptive names here. That makes it easier to remember. Like `defaultLayout` and `extendedLayout` (in which case you would need to make the `defaultLayout` the default layout of course).


LGTM


Ok, I got it.

Indeed, I've used this script before using the poppy_setup.sh. I didn't check that this one was also configuring the wireless connection.
I'll erase that "Optionnal" line from my fork.


The commit message is a misleading. These would be more like three commits. E.g.
- Add default layout
- Factour out getWrapper()
- Add layout specs


I'm not sure. Should this test have to know about the type of machine it's running on? I think it's reasonable to try to always clean up if possible.


u pizdo mater je sfukano


After this, the `$tmp` array should already be "merged", hence making useless (and potentially "harmful") the further merge that happens below (lines 649–652). I couldn't reproduce any case in which this actually happened, so I left it as it was, but ain't it like that, @stefanorosanelli ?


The package can't handle that `runtime.Compiler` is "gopherjs". The tests show a lot "unknown compiler" errors. A solution would be to set that to "gc", but I think that it is very unlikely that `go/build` will be used with GopherJS.


test


In coffee you can also write it like this:
```coffee
viewWrapper = @getWrapper({ wrapper, layoutName, host })
```


This commit just inverts the `if form.post_form_workflow` so that the code that was below it is now on the same level


well, yes it seems like it is a BC break and most probably it will be tagged with minor version bump. the documentation would need to be updated if we would reference tag names, so you have to manage that yourself, master branch is a development active in all cases. a migration diff can be easily applied. the column names are proper and it follows all the examples and tests.


Great! Thank you Nicolas.


Just saw that the its not optional anymore (that was my oversight from a while ago) it should be
```coffee
createView: ({ host, interactive, loadResources, wrapper, layoutName, iframe }) ->
```


But I have better idea. https://github.com/kasper93/mpc-hc/commit/d422085c5cca5178d9f914176afb884e53411bfb