Am Donnerstag, 5. März 2015 schrieb jakobkroeker :

> i didn't add any special-case tests to the test-suite since this library
> is too experimental
>
> are you plan to add test in future?
> I suggest to add tests immediately after a new (public or or private)
> function is added and its interface is more or less stable. Otherwise it
> may never happen. I'm doing this for my own code.
>

once this library is mature and useful enough i will consider testing it in
the test-suite.

> offtopic: should we get serious about this and move/mark all libraries
> without sufficient documentation/tests or which are known to return wrong
> results to 'experimental' ?
>

well, buggy non-experimental procedures should be fixed.
if some library is overall buggy we may have to consider removing it from
the official distribution until it matures.

O.

--
Sincerely Yours,
---------------------------------------------------------------------
 Dr. Oleksandr Motsak                Office 48 / R. 437
Fachbereich Mathematik        Tel.   +49-631-205-2738
TU Kaiserslautern             Fax    +49-631-205-4795
D-67653 Kaiserslautern        http://www.mathematik.uni-kl.de/~motsak
---------------------------------------------------------------------


Ze indentation!


Still really bothered by that name `ErrorHandlerManager`. Maybe:
- `TransactionOperationCollector`
- `ErrorToTransactionAdaptor`


The JavaDocs are pretty poor - it's not clear why we need this field and how we're going to use it.


@ikkez: and with more than one column?


It does not appear on the screen in the form. Have these commits been overturned by others that hide the field?


This is copyright you right?


@zegenie How do you feel if the registration captcha gets absorbed into this option? So the guest captcha option would toggle both the capthca on registration form and on issue/comment reporting?

This would break some backwards compatiblity, but given that this is a release 4.0... We could enable the guest capcha to be on by default in order to avoid bots having now unrestrictred access to the registration..


I set up a pretty helpful /test script after we added python3 to travis that might be helpful (also works as a good pre-commit hook)

Basically made a new virtualenv with python 3, and wrote a script that does

workon pcb-tools-python2
make test
deactivate
workon pcb-tools-python3
make test
deactivate

That way all this stuff gets caught early. I can dig up the script when i get home if you'd like it


BTW I'm thinking let's drop this `Author` bit from new files, it tends to be outdated/wrong, and git should have the real info.


No! This is wrong! ;)


Fixes #293


I think your looking at an old commit, the latest is here: https://github.com/dropwizard/dropwizard/pull/921/files


I don't understand this change :) ReflowReason is a much more accurate name.


I'm wondering if maybe we should make an `OstreeRepoGPGVerificationStatus` structure or something, so if we decide to change what this returns later we won't have to add a whole new complex API call.


It shouldn't be necessary to educate readers on how to update their path.  I think it is a fair to assume that anybody writing grunt tasks on Windows knows how to update their path.

Simply say that the path to Growl for Windows must be in your path and be done with it - especially since the path listed here is not guaranteed to be accurate.


nl eof


TIMTOWTDI, but would pattern.isEmpty() be better here?


LGTM.


tab issue


I was specifically asking to rename the ForcedReflow variant.


Hey there! I do plan on making a pr for it, theres also a couple other changes related to this i have but haven't commited yet. The last thing im trying to fix is swizzlin' a non-square texture, if i don't figure it out soon ill pr what i have with some comments


PrettyGridView (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2176 of 2204 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.73%25-yellow.svg)


Is it possible to remove these duplicate constants, ie remove arm64.ADUFFZERO, their use has got to be a footgun.


Good idea in order to have a "proper" git dir :-)


Indeed; thanks.


Кнопку я бы назвал просто btn, так как вероятнее всего на всём сайте будут кнопки одинаково выглядящие. А те что не одинаково выглядят можно обстилить модификатором.


This doesn't make sense here; `self` isn't defined in this context.


You should be able to scrobble using the current version of TraktForVLC. Using the v1 API is not a problem as both the v1 and v2 are supported by Trakt currently.


Damn, I thought you wanted to rename the enum.


This laned in 1e7df7fbb9a9c60a99ef02d286a478fc91142c52 - thanks flod


Why do you need the prefix? :-)


that was ME


@rmccue yeah this is to create the less cache directory not the upload directory so currently the plugin is broken, going to revert this one until there's a better alternative, soz!


I'd be in favour of using HDF5 as the standard data format for built-in datasets.

That doesn't mean we have to abandon everything else (it's still very useful to be able to instantiate a dataset with iterable objects, for instance), but these would be helper classes for datasets that are not built-in.

Looking at @dmitriy-serdyuk's HDF5 PR (#9), there are a lot of things that can be simplified if we adopt some conventions on how data is laid out in the HDF5 file (the parent node name, for instance) and keep things consistent across built-in datasets.


It has been renamed (and boolean sense flipped) to may_duplicate_items_. Nate didn't compile after merge :)

See 15b547c


Why role of "presentation" within a navigation section?


this sucks


What do I ever fixed? I just did some things with Arrangement form and xml serializer and small code review, that's all i did :lol:
It should work only for RS1 because we have no options for low tunings in RS1, that was a pita in back days when you should use multipitch pedal on your tone to match song pitch, ahh f*uck that times, I like what we have now!


Nice, I'll try it.


If you're changing anything please make a descriptive commit description so its possible for devs as well as viewers to understand what's going on.


This doesn't make sense.  Here `self` is the class `BinaryTree`, which has no method `value=`, `left=`, `right=`, etc.

Also, why accept parameters that you just ignore?  The only case where that's a little justifiable is if you have a subclass that overrides a method in the parent class and you want to respect the method signature, i.e., the parent method accepts three arguments all of which the child method ignores, but you still want method calls with three arguments to succeed and not give an `ArgumentError`.


I guess the IP is different if you see it from the device (local IP `192.168`) or from the server (public ip), no?


@sils1297 I Fix the indentation problem :smile:


All appears to be in order.


@matthewd yeah we do ... totally forgot about them. The current failures are related to delayed_job and queue_classic. I'll try a PR ;)


> I can get this one to work and it makes sense too, so I'm going to stick with that.

It doesn't work, though?


Unhandled Fundamental Failure


If you have a version that's recursing infinitely, figure out why it's recursing.  Put in print statements in the right places to see where it's recursing and you don't expect it.


75127368_DCFSEC (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (634 of 635 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.17%25-green.svg)


All appears to be correct.


#bug
json depency in interface file, mission failed :)


Would you accept a new one? ;)


#bug
using json11 in interface file


Indeed.
```
attr_accessor :employee_name
```
is just ruby shorthand for adding the getter/setter as follows:
```
def employee_name
  return @employee_name
end
def employee_name=(value)
  @employee_name = value
end
```
so where in the app so you have a line of code like
```
some_response.employee_name = 'James Bond'  # some_response.class.name == Response
```


Not quite clear from the JavaDoc what it means. And classes like these are very important to be clear for others since they will potentially be read by others when they start implementing their own plugins.
I'd describe why would a plugin need to return something in this method and an example.


well, this comment already gathered more attention, than i ever anticipated, so it kind of fulfilled its purpose, i guess.


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/940


I'd rather remove this comment, it doesn't say anything additional besides what's clear from the signature.


Thanks for the face split symbolic stairs tip.

The issue tracker is nice indeed. I beg your pardon for leading to the impression that the patches were to affect your addons. I didn't think of this beforehand.
Thanks for your amazing addons. My bow at your service.


Are these changes related or did they slip in by accident?


It's going really well!

It was hard having to get familiar with java, but I'm getting better at it

On Tue, Mar 3, 2015 at 7:54 PM, Kangkook Jee <notifications@github.com>
wrote:

> how does it going with the classes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/choandrew/Project-Euler-with-Python/commit/e24a240c5fc569cea5d22b635ef2edabf5ce4a15#commitcomment-10020158>
> .
>


PrettyGridView (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


#bug
json11 in public interface - mission failed:)


#bug
implementation detail in interface


Yeah, that's it for server traces :)
Le 5 mars 2015 21:52, "Matthieu Baerts" <notifications@github.com> a écrit :

> I guess the IP is different if you see it from the device (local IP
> 192.168) or from the server (public ip), no?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MPTCP-smartphone-thesis/pcap-measurement/commit/caae989ac739901f8232e0813cb117aba1b06f56#commitcomment-10059838>
> .
>


Good point. Many thanks ...


see also
http://stackoverflow.com/questions/4700785/using-attr-accessor-and-attr-accessible-on-the-same-field


OK sorry, you need usually to call `handleOperation` in case of success.


#bug
implementation details in public interface


See https://github.com/JuliaLang/julia/pull/10230#issuecomment-77292650


You can declare a multiple constants on a single line - that would save some space. You don't write JavaDocs for them anyway :)


@josh4trunks I am in the same situation as well


This makes it so the next .get(j) won't get the one you think it will. If you are modifying the list as you iterate through it, the indexes won't be right.


this will return a Boolean value correct?


yes, i've tested. it's a preg_replace_callback now instead. that did the trick.


Yeah. Thanks. This way it workds. But don't forget to update tag for `fs`


I agree, the pagination ruins the proper display of traps after the first page.  This will be fixed when I add the jquery table with built in pagination to replace our manual pagination.  I'll have to get to this sometime soon as today I'm a bit busy, but I'll make sure this is a priority.


Look up ENUMs


I think these have been hidden also because they no longer appear in the app


`new DateTime()` will do the same trick, no need for `System.currentTimeMillis()`.


Does this make the parameter true should it be null?


is there any change in calling pattern for asynchrnous logger?
right now calling
private static ILog _logger = LogManager.GetLogger(typeof (GRVCompressionCharts));
and then start using
_logger.info("")


I have not seen this form appear anywhere in the app. Why does it exist?


Yes


You demand new release update?


indeed


> devplugin configuration

should that be "plugindev configuration"?


Probably in the future it would make more sense to have separate methods to check permissions that can be invoked from methods like this. Otherwise all our API will be blotted with objects we don't actually need in the logic.


Yes, like this one :)


We are still sending the version in the `Server` header.


Тут можно смело использовать тег thead.


@ace2nutzer, which kind of graphical glitches causes 49920000 freq? I've spent some time at this... I tested also 49920000 and I totally haven't  noticed any tearings. It doesn't matter, from this file I change it or via sysfs - tested both cases. Its further decreasing just causes slower image refresh(it's slower reacts on touching or pressing buttons). And finally, it turned out, that we always used 57051428 freq (it can't use 62400000  and sets 57051428 instead). After this freq only 49920000 is available.


Looks good


If you just let it in master, `fs` will still use `tag, "0.9"` and don't see this change


Shouldn't we break in case we found the plugin? Otherwise we continue iterating without a need.


and then merged frame into master


i guess that makes sense.  if the cookie jar is enabled you'll be pinned to the same node from your previous requests, so it would know about your creates.  good info!  makes me re-think this fix...


This is to be removed..


After working through another bug caused by this function, I realized it's not so simple: considering zero-padded booleans, i.e. bit vectors of the form '[0,...,0,b]', the buggy 'isZero' returned '0' when there were no pad bits (first bug) and 'b' when there were one or more pad bits (another bug). Ouch!


Oh yeah


There are many instances in this pull request of commits later undone. This is another where the fields have later been hidden.


+1 for having this built-in to `mina`.

The only thing I would change would be this line 6:

```sh
        queue! "export PREVIOUS=$(ls releases/ | cat | sort -nk1 | tail -2 | head -1)"
```

In using `cat` (or `more`), `awk` is not required as a dependency.


seems fixed already


Does this need to be here?


My code broke without it, so yes?


Its my pleasure to write code, I fear it is entirely selfish in that sense -- But when other people find the code useful that's a bonus, thanks :)


Коммит засчитываю, но с тебя наполнение остального текста в следующий реквест.


Is it ok to include `Annotation` here?
attributes.html is base part of micro.


i do not think we need this.


huh?


I'm curious why is this exception catched in ths interceptor dialect implementation?


@chrisseaton @eregon Please review this, since it's fairly critical and I had to change a fair bit.


It's only gathering *my* attention because it's only pinging *me* because this is *my* commit.


@dkayiwa @djazayeri  I went ahead and reverts this commit for now, in hopes of getting the Mirebalais build passing again.


It makes sense to me that relationships that exist in the database should always be represented in the models even if the app does not currently make explicit use of them.


All that's in that file is stuff for plugins and lround.  Didn't see lround used.  Hmmm.


Hmm. I would tend to leave the relationship stated because it does indeed exist in the database design.


HVACSizing_updates (mbadams5) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.43%25-red.svg)


Okay, this commit is only in _my_ repo, not in the MSOpenTech repo. Apparently, github thinks its an awesome idea to show it anyway. Also, this conversation only shows up on the MSOpenTech repo... weird.


chicken


this should be:

belongs_to :user


You have some typos in the comments here.
Also I would like to suggest your return 8 at the end and return 2 higher up.
It works like you currently have coded it. Coding in a "sorted manner" would possibly make the reading experience even more epic! :smile_cat:


I also fix this bug.
https://github.com/Pofigizm/polymer/commit/7d2398888f4d6049d59d82931cf678f8636d7317
May be usefull.


belongs to is an association - which means - comments have users and comments are on post - so model level associations - we don't need this index association here.


Yeah C# 6 I heard lets you do `IEnumerable<T>` params, right?


You should not add this tab here.


Forgot to mention that I also removed some duplicates in the file.


removed the branch from my own repo, so now this is completely untraceable... :-)


This plugin is conflicting with EDD and I need some urgent help. It's stopping customers scrolling to page 2 and so for three days now I have not been able to take orders. Please urgently advise.


I'm guessing you were missing the definition for PDAL_DLL, which is indirectly included by pdal_macros (which itself includes pdal_internal, which includes pdal_export). Seems like including Dimension and pdal_export should do the trick and be a little more succinct.


Considering the amount of times this object will be created, we should be conservative with the number of fields. We should also check if subclassing means consuming more memory per object.
For example, `OperationType operationType` could be removed and hard coded in each implementation of `AbstractGridDialectOperation` to save these 8 bytes.
Likewise for `Class type`, we could hard-code it and it would not cost 8 bytes.


Of course that can wait for a second round but better log that kind of improvement in JIRA


LGTM!


Yeah this is really really nice!
Splitting the method up into two different ones like this is much better.
I also really like the names you chose for the methods.
:cake:


Yes. It is. Thanks again!


Good example of moving logic out of the view. Nitpicky note though- reading this view I wouldn't necessarily know what "apply_button" does- I'd think 'why not just use button_to so I can see where the button goes'? And it sounds like the method applies a button, not that an "Apply" (as in 'apply to this posting') button is the goal.
Can you think of a more descriptive method name?


IDFXT (refaqtor) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.05%25-red.svg)


Merged in 4f79aa2.


empty ?


We need to get these conflicts fixed so I can get cleaned pls


84692518-Markdown-Documentation (Unknown) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Where is ```admin?``` defined?


So I am thinking that we might win a bit by doing the following:
Each GridDialectOperationImpl is also implementing `FailedOperationContext`, which means we don't need to create an new object. The drawback is that we need to add the `exception` and `appliedOperation` references to each implementation. Is that better than creating this object on failure?
Probably as failures are less expected.


i made a mistake but then me and @the-twee fixed it!


the answer should not be lower


just the "no" test


Why explicitly passing self?


I've been calling methods like this `verySlowIsFrozen` so people don't accidentally use it, but maybe we're all much more used to Truffle now?


check **ABOVE** the commit before you post stuff.


Looks good.


I still disagree with this one. I don't like having to go to the top of a function to see where the variable was declared, and the benefits to the compiler are minimal (I'm sticking with that until you write a blog post that shows empirical data proving otherwise). In JavaScript it makes sense because of variable hoisting (although that may change with ES6 and the `let` keyword, depending on how we use that). But in Java it actually makes methods longer and harder to read.


This is starting to look really clean and nice!
I'm running out of things to comment on :tada:
Remove that tab you added and return in a "sorted manner" and I could pull this I think :smile_cat:


Yes please, that's a pet peeve of mine.

The copyright owner line kinda has the same problem.  I figure it's your (or Red Hat's) project.


Makes perfect sense. Thanks Mark! :)

On Fri, Mar 6, 2015 at 12:08 AM, Mark Goodrich <notifications@github.com>
wrote:

> @dkayiwa <https://github.com/dkayiwa> @djazayeri
> <https://github.com/djazayeri> I went ahead and reverts this commit for
> now, in hopes of getting the Mirebalais build passing again.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-uiframework/commit/d33566db13a56f0f58a582337bedb9d1437baecf#commitcomment-10060179>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


IDFXT (refaqtor) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-68.05%25-red.svg)


Why did you comment this one out?


Perhaps move this to pfSense forum, discuss there?

FYI, here is my posting from before ...https://forum.pfsense.org/index.php?topic=80286.msg437854#msg437854

Thanks!


Should be Sans, not Courier.


This needs to be separate from the model change or be completed. Changes like this can get lost when they are slipped in. Soon enough someone will wonder why the start button is not correctly updating when using a single rover and we don't want to lose time finding it later.

If you want to make the full change, we need to 1) store the blockly executing status of each rover node as a property of the `blocklyNodes` object in the view and 2) check that value when switching tabs to determine and set the correct state of the button. Then, it will work properly for all cases.


@bors: retry


Ummmmm......


Nice! I like the naming choice "valueOf" :tada:


Good question.


Foreshadowing!


This does not handle RubySymbol or primitivies types.


`w` and `h` are not defined if the image is smaller than the preview width and height


That's *exactly* what I'm working on right now.  :smile:

Trying to future-proof the API without over-engineering it.  Should have something to show soon.


Do we need the 4 below at all? If it is known in source code the value is a primitive, let's just not check if it is frozen.
Also why matching boxed primitives?


@mkwork
Why? This is class for exactly json type. How can I avoid json here ??


pointed out by issue #2


guai iu are greging votania?


I think we should only have freeze(RubyBasicObject). No need to do anything in caller of freeze(int), etc.


@BrettASwift you are 100% correct – I do not consider this done. This is the first baby step towards a solution. Another worry of mine is that tracing looks a little out of whack when this is happening. I’ll have to address that part as well.

From: Brett Swift [mailto:notifications@github.com]
Sent: Thursday, March 05, 2015 4:22 PM
To: virtual-world-framework/mars-game
Cc: Marshak, Nathan X
Subject: EXTERNAL: Re: [mars-game] Now we can have > 1 rover executing at the same time. (8948ef9)

This needs to be separate from the model change or be completed. Changes like this can get lost when they are slipped in. Soon enough someone will wonder why the start button is not correctly updating when using a single rover and we don't want to lose time finding it later.

If you want to make the full change, we need to 1) store the blockly executing status of each rover node as a property of the blocklyNodes object in the view and 2) check that value when switching tabs to determine and set the correct state of the button. Then, it will work properly for all cases.

—
Reply to this email directly or view it on GitHub<https://github.com/virtual-world-framework/mars-game/commit/8948ef9ab3349bf19e39cb507a8f06b1a39279a5#commitcomment-10060382>.


saw approval from SimonSapin
at https://github.com/luniv/servo/commit/1931a69ad2151b1bbf60655eee2502c198e836bd


merging luniv/servo/viewpoint-percent-lengths = 1931a69a into auto


luniv/servo/viewpoint-percent-lengths = 1931a69a merged ok, testing candidate = 9f209463


I think it is a line ending. I had the same issue with git before where there actually weren't a tab. I actually wonder why, I do have the correct line ending setting.


Ok, I'll fix it ASAP.


Hello maintainer of project X, I made some changes here in my forked copy. This was just a practice so you don't need to add anything. Thank you and I am humbled to join the github community.
Lomberas Jess


I think I'd like this code better if the ifs were inverted, i.e. `if ( invocationCollector != null ) {` at the top level.


That is, this is not nodes, only statically-known boolean will match the first isFrozen, which is a useless call in the first place.


In what line? 56?


Thanks!


If I do it the way you suggest the compiler complains.


Isn't the RPi2 patch file in the wrong file location?

It's in:
```
projects/RPi2/patches/linux-049-STK1160-addFramescaling.patch
```
when it should be in:
```
projects/RPi2/patches/linux/linux-049-STK1160-addFramescaling.patch
```


Aww. That user silhouette is adorable. :)
Planning to put in an option to include user's photo? as in: https://www.railstutorial.org/book/sign_up#sec-showing_users
You'd have to check with your "client" to see if that's a desired functionality and if they want you to spend time (i.e. their money) on it.


So they should be defined and default to `preview_w` and `preview_h`?


so multiple retries strategies should be implemented from within the `ErrorHandler` implementation?


84692518-Markdown-Documentation (Unknown) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1647 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Merci pour la plug :)


nice


82420068_GridViewMultiEdit (evanweaver) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.5%25-yellow.svg)


No PPA?


never know this, will look at this tomorrow


@BrettASwift  Oh nuts! This change isn't even supposed to be in this branch! I wasn't ready to PR that one yet! I will undo this now.


consider exposing a type field set to `CallRequest`.


can we store the CallRequest flags on this object ?


```python
if resize_ratio < 1:
    w = int(round(orig_w * resize_ratio))
    h = int(round(orig_h * resize_ratio))
    preview_img = pil_img.resize((w, h), PIL.Image.ANTIALIAS)
else:
    w, h = orig_w, orig_h
    preview_img = pil_img
```


![karel tile](https://cloud.githubusercontent.com/assets/10536548/6515004/c4bb3254-c354-11e4-8bd6-1d3091a2a857.png)


Can we store the `checksum` on this CallRequest ?


D:
These should not have been committed. I'm going to rewrite history to delete these so the repository isn't enormous. ugh...


Can we call this field `arg1` ?


Smart. Updated on PR.


ResultsSchema (sanyalj) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.29%25-red.svg)


Good idea


gotta learn this thang


![karel beeper](https://cloud.githubusercontent.com/assets/10536548/6515078/42177b9a-c355-11e4-9754-945d76990bf5.png)


Please review the code.


I'm not acquainted with the flat format functions but I assume they shuffle internally. If done well they may well be faster for single salt but they really should by slower for many salts.

One problem here is the salt is appended, not prepended like in XSHA512. This is very hard to optimize.


Wrong url


Sorry for the confusion. This stems purely from testing and playing around. The function `setMetaDataOrogenInclude()` is currently never called because it does not (yet) do what it should...


nie


szanuję


Thanks @pschyska I'll have a look. We use https://github.com/tools/godep and it works well. The problem here is we don't use this package directly. It's referenced by https://bitbucket.org/liamstask/goose/ and gets pulled in by go get bitbucket.org/liamstask/goose/ It would be nice if Go had a mechanism similar to that of nuget where a package can list the minimum / exact version so that when you use go get it'll pull in the known supported version of the dependency.


I think you copy-pasted something strangely here.


Please quote all fields in CSV with double quotes and separate fields with comma, e.g. "1234", "23", "member".


I have already fixed it in master, see 2162ac529444588451cce302bf365ced2996834e.


|skill| rather than |skills| since you are peeling off one at a time to list below


I'm not crazy about adding another after_save callback.

Might it make sense instead to implement this as something like `user.grant_admin!`?


Do we need $_SERVER['PHP_SELF'] here?
$_SERVER['SCRIPT_NAME'] is safer.


This dup+freeze should also be done in `Hash#[]=` so maybe there is some way to avoid the duplication.


I made my comments.


Actually, I would do simething like this

```
boolean success = optimisticLockingAwareGridDialect.updateTupleWithOptimisticLock( key, oldVersionTuple, resultset, getTupleContext() );
if ( success ) {
     if ( errorHandlerManager != null ) {
        ( (InvocationCollectingGridDialect) dialect ).onUpdateTupleWithOptimisticLockSuccess(...);
    }
}
else {
    Exception rsose = buildStaleObjectStateException( id );
    if (  errorHandlerManager != null ) {
         ( (InvocationCollectingGridDialect) dialect ).onUpdateTupleWithOptimisticLockFailure(rsose, ...);
    }
    else {
        throw rsose;
    }
}
```

same for the other situation where this is happening


this is causing black text in actionbar on stock theme, should be exposed_primary_text_dark


@delcypher If I haven't made any major mistakes, the patch does read the stuff at the end. That's what the for loops are for. It's based on glibc's malloc_info implementation: https://sourceware.org/git/?p=glibc.git;a=blob;f=malloc/malloc.c#l4997 .

Out of curiosity, does your malloc_info output match the amount of memory allocated?


This makes me think that maybe a rename `ArgReaderAbstract` :arrow_forward: `ARAbstract` is in order?
And maybe the interface would be called just `AR`?


final lw


Seems nobody complained yet :-)


I'm a bit confused here. Why would the responses associated with an employee go to my_project_requests? Wouldn't the responses of an employee mean their responses to requests? not the requests that they themselves have posted?


For me it would make more sense to just store the chapter id, instead of the chapter. Why do you want the chapter that is maybe incomplete?


crap


Misspelled canola oil dummy


Some kind of comment would be nice. It looks like you learned that trick from Lucifer itself.


But please!
`valueOf(String arg, CommandSender sender)`
Take the CommandSender as an argument!


thanks a lot


82420068_GridViewMultiEdit (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Was not convert the same as valueOf?


Stolen from StackOverflow, so don't blame me. :D


Double space detected!


|goal| rather than |goals|, as above. Also- for naming, 'goals' is confusing. It gives no indication that goals are actually skills.
'current_skills' and 'desired_skills' would tell the whole story. Ah, you have it that way in schema.rb, must have updated in later commit.


`@ExplodeLoop` sounds good for this. Also, I think most cases will not use multiple parameters so I would have just one `int` if there is no major use case.


Why the for loop?
use Set#contains!


One thing I'd like if we do this is a simple way to cache the entire dataset in memory. It seems silly that one should incur a speed penalty for doing stuff out-of-core with HDF5 when we could be reading from main memory. The ability to apply a few simple transformations prior to this cache being saved ([0, 255] uint8-> [0, 1] floatX being an obvious one for MNIST) is also desirable, so that you don't have to keep doing it for every batch of every epoch. I don't know if this is best accomplished with a wrapper for the dataset object, or if some magic in Fuel already does this sort of thing. (I also realize this is getting dangerously close to a preprocessor system a la pylearn2...)


How is this code triggered from the app?


Yes definitely explode this.


An alternative is a smarter `OperationsQueue` implementation that would keep the removed elements, would allow polling reset (or a `getAppliedOperation()`) and would allow the dialect to flag the current operation as success / failure.
That way the dialect could report fine grained success / failure if it can.

`OperationsQueue` would need to become an interface with the collecting / non-collecting implementation


Building a PPA is like doing brain surgery. I set this up in 5 minutes.


Following "function" (not plural anymore)


This feels strange! "convert", "valueOf" and "read"... we are not supposed to have three of them are we?
Two seems like the proper amount (according to my intuition).


Oh also `type MyInt = Int` means the two are interchangeable. There's no wrapping or unwrapping needed. So that's a more lightweight but less safe way of making synonyms. It won't stop you from swapping around the MyInt and Int arguments to a function, but at least it communicates intent. I think newtypes are the right thing for us here because they make the type errors more clear. Like if we accidentally try to return a M22 instead of an M44, if we newtype wrap things then we get more specific hints about what we intended to do.


I believe `.bind` internally maps to `.on`. Using `.on` would provide a small performance boost.


I was being thorough.  We potentially freeze things during bootstrap.  Ideally, I'd like to get rid of all this and move everything to being node-based.


Using set#contains would really be much faster and much cleaner. One line of code instead of three!


at least move the try{ before the persist :)


because nobody cares. and nobody should, at all /me hides
(@dalehamel it's not that I dont respect your work :D)


Word.  :+1:


这个地方我还是有极低概率遇到问题。最近有点忙，过后折腾一下 gdb-python 出问题的时候attach上去看看。

On Thu, 5 Mar 2015 06:41 hackerxu <notifications@github.com> wrote:

> 这个time.sleep应当可以去掉了
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/taizilongxu/douban.fm/commit/d8fe828d60a07bb5d84cc38bdc5ba841ce02a569#commitcomment-10052528>
> .
>


I had boxed types coming through.  All of these should go away.  But we have some more tidying up to do before then I think.


Is this ever used?


valueOf?


Leftover from a refactoring. I'll clean that up.


Maybe an expressive name like `CallCollectorErrirHandler`?


84692518-Markdown-Documentation (Unknown) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (633 of 633 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.06%25-green.svg)


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I still thinking there is still a race if we have an independent command to load plugins using an independent command. How does the daemon know that it has completed loading all it's plugins if it doesn't know what the definition of 'all' is?  Instead would it be good to create an extra option for docker daemon to read a plugin configuration file which will provide it the definition of the complete list of plugins so it can effectively load all of them before responding to API requests?


Do we really need a specific implementation here?
Could we not just use the standard "read based fallback"?


Please say yes :smile_cat:


We should remove this alert now.


good


You should really remove this one.
No need keeping a comment like this one.


This looks like enough duplicated logic to justify a snippet.


This change broke tests in Lucene.Net.Codecs.Lucene40 namespace. Here is an example: http://teamcity.codebetter.com/viewLog.html?buildId=185033&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId1772304587644585012

I can't explain it why though, the code seems to do the same thing but something about iterating over the values .. I wonder if it changes the minLength / maxLength values somehow. I have it fixed locally. Let me know if you want me to do a PR with that or if you got it. The fix was to go back to using bref approach plus handling that NRE properly.


wqdqwdqwd


Just kill it!
Kill it with :fire:!


qwdqwdqwdwq


I think I see a theoretical bug here. Lines 214-217 are key buffer cleansing. If the previous key was at least one character longer, and the previous salt started with 0x0000 (or had 0x0000 in the middle, depending on alignment) we might end up not cleaning all of it.

In a previous version I had a clear_keys() function just memsetting the lot and it was more or less as fast as this so we should probable revert to that.


Another easy one.   That complex extra crap does not give much gain.  Now that is against oSSL built for Cygwin64. The code in this format only gains about 5% there. I added the 'simple' loop, during debugging, so I could dump out buffers after the first few loops (to make sure I was getting proper results while adding the SIMD code).

But the SIMD code (which is trivial) gives us 400% gain, woot woot!


I like it


No, it's not. See https://github.com/aspnet/Security/issues/167


Remove?


Why did you reshuffle the parenthesis. Makes it harder to read I think.


Remove :smile_cat:


this one could get a comment to explain what the test expects.
Or maybe the asserts in these tests could get some message to be easier next time the test fails.


LGTM


Ops!


Hi,

Sorry about the slow progress.

I want the following things to be solved in version 1.3

1) Close the OSGI issue (I have moved the JsonProvider implementations from the ‘internal' package to the ’spi’ package. Is this all? Need someone to verify this.)

2) Fix issue #68 <https://code.google.com/p/json-path/issues/detail?id=68>

3) Update dependencies (same versions as latest Spring release)

When these tasks are done I’m ready to push the button. Take a pick :-)

/Kalle

> On 05 Mar 2015, at 17:10 , jochenberger <notifications@github.com> wrote:
>
> Yes, XML hurts, it becomes bearable with Groovy however.
> Is there anything left to do for 1.3.0? Do you need a hand?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/jayway/JsonPath/commit/96ab579bfc4291d097394a99283c824247943734#commitcomment-10054480>.
>


I don't think it broke the test - I think it exposed a bug. Compare my change to the original Java version -- the previous code wasn't updating the values in the array and as such basically the tests weren't the same.


Purge the comments :exclamation: :sweat_smile:


it's fine, but just handle them in the freeze(Object) below.


FYI s3cmd-put only uploads builds on master, beta, stable (not PRs)

https://github.com/PX4/CI-Tools/blob/master/s3cmd-put


Hello! Sorry I've not got back to you on this. I wanted to look at how it impacted render time. I've not had time to do so nor check your latest code. If you can show it has a negligble impact upon render time (which I hope/expect) then it should be good to go.
For example run
time mdz -l qob_squared.mdz -R qob_squared.png
(http://jwm-art.net/mdz/gallery/qob_squared.mdz)
on both patched and unpatched versions. Whenever you're ready. Thanks.


So is this kind of a bug-fix? I thought the whole purpose of assistants was to stay around and execute work.

By the way, it would be great for assistants to eventually die and restart, just so the python process doesn't keep running old code it loaded into memory after you've deployed an upgrade.


Maybe we should call this class `ARAbstract` then?


The test for `Options.verbose` is what leads to the test failure: since this will be true by default, it shortcuts parsing of any command line arguments checked after this `if` and the default for no command line options is to start the gui, which leads to the X11 message.

Since I'm looking at this anyway at the moment, I'll have a go at fixing it and adding the second command line option.


For some reason, the whole chapter was sent in some places and id is sent in other places. I can change this to send ID everywhere.


Sounds reasonable. Please create a PR for it when you find some time.


I guess nobody has built/tested this for RPi2, as this patch isn't going to
be used.

On 5 March 2015 at 21:40, Peter Frühberger <notifications@github.com> wrote:

> Seems nobody complained yet :-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenELEC/OpenELEC.tv/commit/ce1b565e226fc9a72b59dbe738b8e1fff54d494d#commitcomment-10060766>
> .
>


@lakenen In this function, what is the reason that you are adding iframe to detect resizing on that frame rather than just doing $(window).on('resize', checkResize) ?


"Enabel" typo

Love the mod so much I am commit stalking...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12370/testReport/) for this commit**


I agree the actor and Type instances should only implement nudge for future backwards-compat reasons and simplicity, but there probably wouldn't be harm in defining increment/decrement on the Requisition / Type prototype as a function that just calls this.nudge(otherargs, 1|-1).  I don't feel strongly about it so feel free to ignore, but calling foo.increment() seems slightly nicer than foo.nudge(1).


88737258-EPW-Ruby-Access (jasondegraw) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


@tfennelly This commit caused [JENKINS-27223](https://issues.jenkins-ci.org/browse/JENKINS-27223).


LGTM


I running into a little trouble with my path for detroying "Notes".  Please see ```app/views/notes/_note.html.erb```.  Line 6 in the code in question.  I tried as many combination that I can think of.  Let me know your thoughts when you have time.   Thanks!


:boar:


No need to parse an empty object, save a call:

var bodyJSON = body ? JSON.parse(body) : {};


Too often you have code appearing under one commit that is later changed under another commit within the same pull request.


If I may give a last potential way out: Use NVM (https://github.com/creationix/nvm) and install iojs and see if the problem goes away.... I'm sorry to see that npm is giving you a hard time :( *hugs*


The intention was to make it look more like a black and white version of the full color logo.
The original logo looks somehow too massive for my eyes.
Just converting the full color version using Gimp did not work because of the reflection, so I have tried my best using a brush.
Do you have an idea to improve the logo in a better way?


Docker port should be changed from 7000 to 8701


Actually, either of these fixes changes the behavior, doesn't it?  Before if the body was null/undefined, then an exception would be thrown and the promise would resolve with the exception in an error object.  Here, we now stop the exception, continue on and the resolve as success.  We might want to leave the existing code, but put an if statement right before to make sure we're still returning an error...

...
if (!body){
  deferred.reject(....);
}
JSON.parse(body);
....


@drewpts  it make's compile time depency on json11
it is implementation detail, client shouldn't care which concret FileSetLoader it usess.


I didn't check the code, but :+1: for doing it


Shouldn't be `'cw_ingotorichalcum'`. Should just be `'Chalcum Ingot'` instead.


It's been fixed in 300de890a5095e157b88b0ffaf7ffce13f4c64ef


sorry @D-storm , I fixed it with my workaround and I cannot try the patch. have you tried to reproduce the error?


Hm, well, I imaged that the extra credit would be part of the same project. Can you put it in the same project?


yep


Добавлены шрифты


ref : #815


Yeah, sorry about that :(


Wouldn't moving it all to so-lib solve this problem?


I'd consider it a bug fix, but it might make sense to launch an assistant to give temporary support with a backfill or something. That's why I still require the keep-alive flag for this behavior.

I was planning on restarting the assistant as part of the deploy process. This will actually simplify my deploys, as I'll ideally only have to restart one process to get everything running the right code.  It would be really nice if we had the option to gradually retire an assistant by telling it to stop asking for work and die when it's done with what it has. That way a deploy would mean that everything new will run with new code but old stuff can still finish.


I agree, but now it matches the style of the surrounding code.


Is there a reason Coffeelint isn't run as part of `npm test`?


got it, i dont know why i use natural join instead of only joins, also with the (X, Y) form in FROM. Maybe is the lack of practice with SQL.
I'm going to see those articles now, thanks


nice one, let me know how you go.

On Fri, Mar 6, 2015 at 7:08 AM, LuaTenshi <notifications@github.com> wrote:

> Working on a good method to get the amount of space freed and then I will
> update the code.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LuaTenshi/discourse_docker/commit/a8b66f980e1c33979970f5930ac146a49c2003c3#commitcomment-10059119>
> .
>


How important is this change? Should I avoid using extensions before a version with this commit is released on the registry?


Thanks for pointing that out. I didn't test with OpenJDK.


Just some nitpicks:

* What's the ` />` at the end of your `input` element?
* You keep using `select#profile` as a selector; it's wasteful because the ID matches anyway. Also, it's better to cache repeated selectors in a variable.
* You're not maintaining state on reload because you're not getting a change event simply by setting the `checked` property. In turn `disableProfilesIfNeeded` isn't called.

At any rate this UI is becoming too complex for the handcrafted approach I initially took. It's really in need of some structure. If you don't mind I should probably refactor it some.


Slick. Very nice.


@rjcruz hay un temita aca. El filtrado deberia aplicarse antes que el paginado o en simultaneo mas bien. Sino existe la posibilidad que traigas una pagina y despues filtres uno o todos los resultados porque no satisfacen.
Eso ya a mi como cliente me indica que no habria mas paginas para pedir y sin embargo en paginas mas adelante podria haber otros que tengan el tag requerido. Se entiende?
Creo que el filtrado deberia resolverse a nivel base de datos cuando se hace la query. Sobre eso paginar


Caching in memory is what I meant with the `load_into_memory` in my first comment. It should be very straightforward to do, basically: `data = np.asarray(data) if load_into_memory else data` (where `data` is the HDF5 handle). Considering this changes the way the data is actually read, I think it's reasonable to have in the `Dataset`.

Converting from `uint8` to `floatX` is a bit less clear I guess. Strictly speaking its a transformation which could be useful for many datasets, including ones that don't read from HDF5. For speed reasons, maybe we should just make an exception though. The transformations could easily be re-used for the `Mapping` transformer anyway.
```python
HDF5DatasetFile(mappings=[Cast(dtype=config.floatX), Scale(1 / 255)])
# Can also be used for Mapping
cast_stream = Mapping(data_stream, mapping=Cast(dtype=config.floatX))
```
Then MNIST could even have a default like
```
MNIST(HDF5DatasetFile):
    def __init__(self, **kwargs):
        kwargs.setdefault('mappings', [Cast(dtype=config.floatX), Scale(1 / 255)])
        super(MNIST, self).__init__('mnist.hdf5', **kwargs)
```


Is this still an issue with the latest master? I have just double checked it an the Mic/Aux region appears in place of the advanced transport controls.
The disappearing of the transport controls was intended because the Mic/Aux region is only of a temporary nature and IMHO it is no problem to effort the extra click for displaying them.


Ahh yea, ran into this the other day, wasn't sure if it was caused by my compiler, or environment. I just ended up replacing  `_BSD_SOURCE` with `_DEFAULT_SOURCE`.


`filelen` is `size`_t which is unsigned. Yeah, it can't be negative.


Excellent, this is definitely heading in the right direction.  If you don't mind, please comment on what (os version, arch) permutations you have tested this on, e.g. `make check`.   Some of the hardware I used to test on has been turned off but if I need to I may be able to resurrect them.

Thank you!


Is the salt 4 bytes, or 8?  If 8, it is trivial. If 4, then it is like i did on  ecryptfs which SUX.  A flat buffer might be better.

For SSSE4.1+ the flat may actually be faster than interleaved anyway.  In flat, you still setup the buffer (data the 0x80, and the length). You just do not put into BE order, you let the loader code do it for you with SIMD instructions.

The overhead, if there is any, usually gets beaten by usage of GETPOS macros and their overhead.  BUT if you get a buffer into mixed, and leave it alone, using it over and over, then interleaved 'is' usually faster, even in SSSE4.1 machines.


ResultsSchema (sanyalj) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.36%25-red.svg)


Test koment


Neni pekne mit vice komponent (controlleru, direktiv, konfiguraci...) v jednom souboru. Rozhodil bych je pekne jedna vec - jeden soubor a pak je pripadne spojil v gulpu//gruntu


Should this have an exception message?


Idealne vyhodit do sluzby, ktera se bude starat o data. Hodi se nejen pro testy.

Preci jen

    DefinitionService.get().then(....)

Vypada lip


Yes! They all should. =)


Does having the skills in a string improve readability on the string over, say, displaying in a column?


ES6 modules are implicitly strict mode, so 'use strict' is redundant

http://babeljs.io/docs/usage/transformers/other/strict/


PRINC is deprecated and shouldn't be used. Please drop it.

Also you don't need to set PACKAGE_ARCH I think as the dynamic arch system will detect it. Confirm if it is necessary.

In either case, it'd be MACHINE_SOCARCH.


Same here?


Prace s DOMem do controlleru vubec nepatri :smiling_imp:


consider the ternary operator
```
msg = @assignment.save ? 'Assignment was successfully created' : 'There was a problem with the assignment'
redirect_to_my_project_requests, notice: msg
```


Why?


ResultsSchema (sanyalj) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.36%25-red.svg)


Since we do control most of them, I think I'd side with @gunnarmorling and not put a default. Especially since we said that this API was still experimental


Ok, there must be return pointer to class which instantiates from template. Since we have only one class at now, what should I do? :)


The change looks quite complex and I can't tell the implications by just looking at it. So what we should do is to test whether VST plugins still work on all platforms (Linux AND Win32 AND Win64) and ZynAddSubFX works on all platforms (including OS X) too. If this is the case, we can merge it.


This check here was actually somewhat of a joke.  The point is that the rpi is armv6 and Debian's armv6 support is strictly armel.  And muts had been trying to build an rpi image and was using armhf, so it kept crashing on him and finally it was figured out that he was using armhf.  That said, I'm not entirely sure of this check that you've added.  If the architecture isn't armel AND not armhf, then... it can only be one or the other.  The rpi2 script is in the repo now, and we do want to keep it separate for our needs.


Good at a glance; I'll give it a proper eyeball over the w/end and then suck it in...


Well yes but `OgmJtaTransaction` does not *say* what this implementation of `Transaction` is doing.


Tohle uz jsem videl na radku 70, rekl bych


Very nice little piece of functionality for user.


What was the reason behind switching away from the delete again?


What guarantee do you have that the directory will exist?  Will nginx create it for you, or will chef?


I just figured that if anyone does come around to look at it, they might
get put off by the fact that it doesn't build under the default
configuration.  I am not using it, was just poking around.

On Wednesday, March 4, 2015, Jan Bernitt <notifications@github.com> wrote:

> Yeah, this definitely should not be there. I can fix that or you submit a
> patch. Let me also point out that I have no idea if anybody is actually
> using this library. There are several good idea in here - some things I
> would change with respect to functional interfaces and defaults in
> interfaces but I am not really working with it - what shouldn't stop you
> but at least you should know about it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jbee/jadamant/commit/4ae9b387a7aa3116506c906fa7def8999d839dbb#commitcomment-10046017>
> .
>


No me esta funcionando un get sobre users. Debe tener que ver con un toJson que no tiene el array de orders o esta en null.

Caused by: org.codehaus.jackson.map.exc.UnrecognizedPropertyException: Unrecognized field "orders" (Class model.user.User), not marked as ignorable
 at [Source: de.undercouch.bson4jackson.io.LittleEndianInputStream@46dc99bb; pos: 311] (through reference chain: model.user.User["orders"])
	at org.codehaus.jackson.map.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:53) ~[org.codehaus.jackson.jackson-mapper-asl-1.9.5.jar:1.9.5]
	at org.codehaus.jackson.map.deser.StdDeserializationContext.unknownFieldException(StdDeserializationContext.java:267) ~[org.codehaus.jackson.jackson-mapper-asl-1.9.5.jar:1.9.5]
	at org.codehaus.jackson.map.deser.std.StdDeserializer.reportUnknownProperty(StdDeserializer.java:672) ~[org.codehaus.jackson.jackson-mapper-asl-1.9.5.jar:1.9.5]
	at org.codehaus.jackson.map.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:658) ~[org.codehaus.jackson.jackson-mapper-asl-1.9.5.jar:1.9.5]
	at org.codehaus.jackson.map.deser.BeanDeserializer.handleUnknownProperty(BeanDeserializer.java:1361) ~[org.codehaus.jackson.jackson-mapper-asl-1.9.5.jar:1.9.5]


`Time::DATE_FORMATS[:db]` isn't a "setting", and it should not be overridden


good


Looks like it, can't remember the reason for switching away from delete in the PR. I have added a question to the original commit.


@Supermanu, can you try if this works better for you? It is kinda just a shot in the dark, though...


Oh nooooooo, this appears to be a heisenbug :frowning:
With `MYPAINT_DEBUG=1 ./mypaint`, everything is working perfectly. I do indeed see a lot of lines like `DEBUG: gui.layers: Checked destination: after (0,)`. A layer will appear to start dragging after about 10 pixels of movement.

With `./mypaint` however, there's maybe an 80 pixel square in which nothing appears to happen. This is about a row and a half, so if you have two layers and you're trying to drag the bottom layer over the top layer, nothing appears to happen.

How bizarre.


Agreed, but we first need to get VSTs fixed on win32/win64 do we have capability for a baseline, no? ;)


Nestaci jen

    $location.hash(newHash);

Bez toho ifu?


@subroutines 181,000 lines in a file? What does that even mean?


Thanks! For some reason I thought this transformer wasn't enabled by default and kept writing this.


There I missed giving an empty default for an access to the files setting
somewhere. @Makman2 pointed this out on my pull request as an issue with
the PR but it was actually on master. When something's wrong on master we
usually want that fixed as fast as possible. Master is considered stable.
Am 05.03.2015 20:16 schrieb "Udayan12167" <notifications@github.com>:

> What is the bug that you faced with this?
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/9f248334126f658d3c54bbd75e70d12d6fd0fd61#commitcomment-10058171>
> .
>


Complete or incomplete may not correspond to current and past. That is- a project didn't necessarily get finished just because the end date passed. (I've been on plenty that didn't!) Perhaps scope them as 'current' and 'past' instead, to fit better with the variable names current_requests, past_requests.


So this is going to just grind away over the ignored lines? =/ It worries me if we're reading in a book of 20,000 lines, i.e. numLines = 100, iteration = 200.

Honestly it would just be better if getContent() returned an InputStream, then modify Parser let it decide to handle it as lines or bytes. It's built into the language, might as well use it.


Yep, I was doing the same thing until someone called me out on it recently :)


Didn't we already do this as UsersController, which is usually the preferred way (plural name rather than singular)?


I'll leave that for @chrisseaton, as he's actively working on Hash.


scripts.app_js now reads directly from vendorfiles.js to avoid repetative grunt config


Should the title be refactored as a constant somewhere?


I could not find a use case *today* where you need an enum set. In your MongoDB example, you confused mandatory JTA and "tag along JTA".
We make Mongo tag along JTA but that's not Mongo dialect's responsibility.
Likewise when we find a datastore that has resource local transactions, we can make it tag along JTA transaction probably by attaching some tx listener.
But Neo4J JTA or Infinispan JTA means they actively integrate with JTA.

That being said there might be multi-results use cases in the future, I don't know, Nor do I know how we will treat them should they arrive. I think the numbers should be manageable even if we end up creating a RESOURCE_LOCAL_AND_JTA flag.


> I was more referring to the note it shouldn't be included at all :)

Yeah, I don't think it belongs in a document titled "Getting Started".


I did not find where it moved.


:D


Does this mean 'Closed to Applications'? Can it be re-opened (perhaps routed to the edit form) or it's just over because the end date passed?


@dhermes  This: [plasticity/PyDiffusion/data/mesh_res_96_full.xml](https://github.com/subroutines/plasticity/blob/master/PyDiffusion/data/mesh_res_96_full.xml)
but converted for matlab.


fixed


Simply nope.


Tyhle definice nejsou treba, front-end to zvladne a v backendu k tomu nikde nepristupujes


OMG. Not necessary. Eeek.

Check out https://github.com/subroutines/plasticity/blob/bb39b3867e8bb09b296d4f3e1a097963e0107cab/PyDiffusion/data/serialized_mesh_res_96.mat


So you are saying that you removed the dependency on JBoss Tx from the mongodb module to make sure we don't mandate it.
But that also mean, we no longer test mongodb + JTA. At least not in the mongodb module.
Or am I still misunderstanding things?


In the second item:
> The `unittest` package from python defines attributes to handle skips for
> specific test cases, not only the whole test suite.


Two things:
1. `ethash` has not been imported yet.
2. Did you mean `get_next_cache_size`?


Hi @ZION959 This seems https://github.com/crdroidandroid/android_packages_apps_Settings/commit/5eff552deac0b4fdc21c8ad73ebd0a796e6684f5 O_O


Did you mean `peck_cache(db...`?


you return a transactionManager even if you set `info.setTransactionType( PersistenceUnitTransactionType.RESOURCE_LOCAL );`
This works because of specific circumstances, right?


i'll change it to `IsBeingRecorded()` to clear is up


`db` instead of `self.db`?


Why this is not a kickstart/template file? Just copy and delete some things. I think it's not wrong to put in some more stuff to see what's essential inside a test case.
In principle you could write a minimal one yourself from the 3-4 code blocks from the section **Actually Writing a Test**..


But it also affects run_tests results as o mentioned.
Am 05.03.2015 23:30 schrieb "Makman2" <notifications@github.com>:

> In the second item:
>
> The unittest package from python defines attributes to handle skips for
> specific test cases, not only the whole test suite.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/e19b86dbc39a6eb5579e5b40a81f7859e058799a#commitcomment-10061511>
> .
>


done.


could please offer access to  file "de.dhbw.mannheim.iot.ia.TcpServer"


"Do progressive sources need to be deinterlaced at all?"

No - it is the opposite of interlaced :)


82420068_GridViewMultiEdit (evanweaver) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.23%25-yellow.svg)


Yup! Done in https://github.com/danielstjules/pjs/commit/4af10a5c9e1ea425535efdd4e5adf98ca04b271b Published a new version on npm.


I don't want to get any commits from new people with those comments in the
tests and empty methods. For me a template is something I can fill out but
I shouldn't need to delete something.
Am 05.03.2015 23:31 schrieb "Makman2" <notifications@github.com>:

> Why this is not a kickstart/template file? Just copy and delete some
> things. I think it's not wrong to put in some more stuff to see what's
> essential inside a test case.
> In principle you could write a minimal one yourself from the 3-4 code
> blocks from the section *Actually Writing a Test*..
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/e19b86dbc39a6eb5579e5b40a81f7859e058799a#commitcomment-10061539>
> .
>


also fine for me


Seeing a few errors in `pyethereum/blocks.py` in this commit. Going to resolve them in my own fork and issue a PR, if that's alright.


Everything from here to line 824 is just whitespace change due to the de-indent of the now superfluous `if(!comment_mode)` block


This will spit something out like this blob of blob:
```json
{
  "audience": "pdehaan.local:5000",
  "expires": 1425592654514,
  "issuer": "login.persona.org",
  "email": "peter@deseloper.com",
  "status": "okay",
  "isMozillian": false,
  "isOkay": true
}
```


Killer, I didn't you loaded a mat data file yesterday.


Everything from line 743 to here is just whitespace change due to the de-indent of the now superfluous `if(!comment_mode)` block


Hi! How do you utilize this file? jshint seems not to understand .jshintrc-spec file extension (unless you point it explicitly) and reports all the globals in spec-files. Intellij doesn't get this file either because it does not follow regular jshint file extension convention which makes this type of .jshintrc file really problematic.


Without that, it's not the escaped character that will be written to the command buffer, but the escape character `\`


Ty


Always leave comment_mode at the end of a line, not just when the line is empty


What's this?


This method returns ```"(IN PROGRESS)"``` or ```nil``` and so has inconsistent return types.
What happens when the expression between ```<%= %>``` tags evaluates to nil? I'm not entirely sure myself, but I know it's certainly fine to return an empty string when you want 'nothing' to be injected into the page html.


75127368_DCFSEC (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1142 of 1144 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.57%25-green.svg)


Why is 'open.incomplete' needed here, but 'open' is not specified in '@current_requests'? Or am I not understanding how 'open' works for your requests?


Why leave this in as a comment?


:+1: :heart:


Sorry, I should've explained what caused my confusion. Mainly it was the type of the `collider_instance` variable. It's hard to see this without data types. Something such as,

```
Args:
error_message: The error message for the response or None if there is no error.
status_code: HTTP status code of the response.
collider_instance: One of constants.WSS_INSTANCES representing the collider instance being handled.
```


84692518-Markdown-Documentation (Unknown) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1141 of 1141 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.62%25-green.svg)


@devTristan your code wins the award for most cryptic


Can inject ```nil``` here. Is that ok - I can't remember trying it myself.


@WellingGuzman Take a look at issue #655. It has worked fine with v2.3.x, but I haven't tested since then.


You're doing two things here. First you're changing the begin_section method. Second you're using current_section for the actions.

IMO those are two distinct logical changes which could go into an own commit each. This is better for reviewing and helps detecting bugs.


This neat little trick let's me get the current `server.info.uri`-like value via the `request` object:

- browser: http://pdehaan.local:5000/
- `server.info.uri`: http://pdehaan.local:5000
- `request.info.host`: pdehaan.local:5000

If I understand this correctly, it means that it should work both locally on localhost or 0.0.0.0 or if we're on some prod-like env.


Why do we need this message class?

We could send objects from the model?!


I also like orange juice


did as you asked - looks like I created a new pull request by mistake


Nice it's working, I'll do it for SS as well in order not to increase Render's Server traffic.


> On Mar 5, 2015, at 1:41 PM, H. Joe Lee <notifications@github.com> wrote:
>
> I see. As long as RPM/distribution package is shipped with EnableCF=True, I’m fine.

Good
>
> From: James Gallagher [mailto:notifications@github.com]
> Sent: Thursday, March 05, 2015 2:37 PM
> To: OPENDAP/hdf4_handler
> Cc: Joe Lee
> Subject: Re: [hdf4_handler] Fixed comment about EnableCF in h4.conf.in (6163fa8)
>
>
> > On Mar 5, 2015, at 12:02 PM, H. Joe Lee <notifications@github.com<mailto:notifications@github.com>> wrote:
> >
> > James, this is not recommended. I don't know why you want to make it false.
> >
> >
>
> I’m not - it’s false be default. Tat is, if you write a .conf file for the handler and don’t explicitly define EnableCF as true, the option is turned off.
>
> I see that the code/build includes this option in the version of the conf file it builds, and that it is true, so I see that ‘by default’ it’s true in that sense, but the comment is confusing if you have your own conf file.
>
> Really a minor point - I only edited the comment, not the options setting
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/OPENDAP/hdf4_handler/commit/6163fa8cb63f3a94c63a89f138fe3489934eb75c#commitcomment-10057967>.
> >
>
> --
> James Gallagher
> jgallagher at opendap.org
> 406.723.8663
>
>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/OPENDAP/hdf4_handler/commit/6163fa8cb63f3a94c63a89f138fe3489934eb75c#commitcomment-10059593>.
> —
> Reply to this email directly or view it on GitHub <https://github.com/OPENDAP/hdf4_handler/commit/6163fa8cb63f3a94c63a89f138fe3489934eb75c#commitcomment-10059662>.
>

--
James Gallagher
jgallagher at opendap.org
406.723.8663


I lost track of this comment. I'll file an issue for it.


Ping @mkortstiege


ggfgfgffgfgfgfg


ffff


`CallResponse`  has tracing and flags. as well as response headers.


We have `self.arg1` here instead of `self.name


Thanks!


Yea, not sure what the deal was and didn't have time to track it down. Could be specific to my env or ruby version.  Here's the error I was getting:

```ruby
2.1.2 in compass-h5bp/ on
› bundle exec rake build --trace
** Invoke build (first_time)
** Execute build
rake aborted!
WARNING:  See http://guides.rubygems.org/specification-reference/ for help
ERROR:  While executing gem ... (Gem::InvalidSpecificationException)
    [".editorconfig
.gitignore
Gemfile
LICENSE
README.md
Rakefile
compass-h5bp.gemspec
config.rb
lib/compass-h5bp.rb
lib/compass/h5bp.rb
lib/compass/h5bp/version.rb
stylesheets/_h5bp.scss
stylesheets/h5bp/_browserupgrade.scss
stylesheets/h5bp/_errorpage.scss
stylesheets/h5bp/_helpers.scss
stylesheets/h5bp/_main.scss
stylesheets/h5bp/_media.scss
stylesheets/h5bp/_normalize.scss
test/compass_h5bp_test.rb
test/project/css/.gitkeep
test/project/sass/original.scss
test/project/sass/original_normalize.scss
test/project/sass/test.scss
test/project/sass/test_normalize.scss
", "test/compass_h5bp_test.rb
test/project/css/.gitkeep
test/project/sass/original.scss
test/project/sass/original_normalize.scss
test/project/sass/test.scss
test/project/sass/test_normalize.scss
"] are not files
/opt/rubies/2.1.2/lib/ruby/gems/2.1.0/gems/bundler-1.6.6/lib/bundler/gem_helper.rb:149:in `sh'
/opt/rubies/2.1.2/lib/ruby/gems/2.1.0/gems/bundler-1.6.6/lib/bundler/gem_helper.rb:57:in `build_gem'
/opt/rubies/2.1.2/lib/ruby/gems/2.1.0/gems/bundler-1.6.6/lib/bundler/gem_helper.rb:39:in `block in install'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:236:in `call'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:236:in `block in execute'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:231:in `each'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:231:in `execute'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:175:in `block in invoke_with_call_chain'
/opt/rubies/2.1.2/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:168:in `invoke_with_call_chain'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/task.rb:161:in `invoke'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:149:in `invoke_task'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:106:in `block (2 levels) in top_level'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:106:in `each'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:106:in `block in top_level'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:115:in `run_with_threads'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:100:in `top_level'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:78:in `block in run'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:165:in `standard_exception_handling'
/opt/rubies/2.1.2/lib/ruby/2.1.0/rake/application.rb:75:in `run'
/opt/boxen/rbenv/versions/2.1.2/bin/rake:33:in `<main>'
Tasks: TOP => build
```

Double quotes fixed it.


change it


lacking checksumType and checksum too


bad version. The next commit is better.


@hekonsek I have extracted all statistic logic to new module, so it can be referenced by any benchmark but I cannot figure out why mqtt-forward module cannot resolve classes from my new module, any idea?


HVACSizing_updates (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Missing: `flags`


At 131 lines, your ```project_requesrts/index.html.erb``` view is a monster. Work on refactoring it. That means changing the code without changing what it does. The goal is shorter simpler easier to read code. The use of helper methods is important.


Missing: `flags`.


Why have `self.name`, `self.arg2`, `self.arg3` for OutgoingResponse but not OutgoingRequest. That's weird.


I'm not sure this method name really describes what the method does. It either returns "Applications Closed" (by which I think you mean 'Closed to Applications') or a button to stop applications. In neither case does it 'open' anything.


Hello


are `arg2` and `arg3` the incomingrequest arg2 and arg3 ?

The args are called `sendFrame(err, res1, res2)` in the `send()` method


Hi Kalle,
I am going to check the OSGi issue this weekend. It might be the case that there are incompatible changes, which would "require" a 2.0 release (in case you prefer to follow semantic versioning).
(I am going to submit a bug report about not escaping in the `'` and probably other characters too when `Option#AS_PATH_LIST` is requested. It might be not too hard to fix, probably I'll give it a try too.)
Thanks for your work


This doesn't seem like a good thing to do on all games...


> * What's the ` />` at the end of your `input` element?

Right, fixed in cb1f053. And also... validator/validator#47.

I'll fix the rest of your comments tomorrow, thanks.

Regarding refactoring the UI, you have my blessing! But you need @tripu's and @deniak's more than mine...


I didn't you


This works, but "mutate input and then mutate it back" seems fragile. Better to use a deepcopy (techincally slower, yes, but Headers are not large) or better yet add functionality to MDS. For testing, compare a Header to itself before and after being passed to `fetch_events`.


Did you find a style guide that recommended doing away with the ```before_action```?  These changes add repetitive lines of code so there usually has to be a good reason. Perhaps there is one.


Hi Tere,

Pls fix the sign-off email address and provide more details on the intended change.

You will also need to modify the README file to inform that meta-fsl-ivi will add a layer
dependency on meta-fsl-demos layer.

https://github.com/Freescale/meta-fsl-ivi/blob/7.0/README

@otavio Tere is working on extending meta-ivi stock demo image with more goodies to be added for iMX Auto related targets.

Regards


@marijnh Isn't it the same as `String.prototype.codePointAt` in ES6? If so, probably makes sense to use it when available, and fall back to manual approach if not?


`Jackson.defaultMapper().writeValueAsString(input.asNative())`?


@tobydox This commit was eroneous, I fixed it (see PR). But it should not result in any functional change nor change in output, it's just cleanup for systems that do not have <sys/shm.h>


A lot of time wasted today trying to get Text to scale smoothly. In the end, I decided to just give up. The chunky scaling can be a 'feature', anyway :laughing:


Please use the Apache license that is in all the other files (now).


If these are not used, might as well remove them.


    this.getNextInTree = function (questionKey, questions) {
    var currentAnswer = $scope.answers[questionKey];
    if(!currentAnswer) {
        return;
    }

    var question = questions[questionKey];
    var next = question.answers[currentAnswer].next;
    $scope.preActive[next] = true;
    self.getNextInTree(next, questions);
};

Co nejak tahle?


AND special attacks are now used every 3 turns!


This caused the error to never get returned if the compare and swap failed.


Makes sense. Thanks!

On Thu, Mar 5, 2015 at 2:40 PM, Donald Ephraim Curtis <
notifications@github.com> wrote:

> Sorry, I should've explained what caused my confusion. Mainly it was the
> type of the collider_instance variable. It's hard to see this without
> data types. Something such as,
>
> Args:
> error_message: The error message for the response or None if there is no error.
> status_code: HTTP status code of the response.
> collider_instance: One of constants.WSS_INSTANCES representing the collider instance being handled.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jiayliu/apprtc/commit/9fd430d9fc12e2d2023b53115e53d1cfba65a989#commitcomment-10061666>
> .
>

--
Jiayang Liu


```do |skill|``` marks the start of a multi-line block, and the lines in that block should be indented 2-spaces more than the line with ```do```.


I just found this via Google/NPM website because my old company had a bot plugin like this. I just wanted to say thanks and that you should submit it to the official hubot-scripts repo so more people see it. Very nice work. I like the touch of smart extraction, I used to have to copy/paste quotes, it's nice that it caches quotes and can find them in a smart way. :+1:


@bambi73 mind sending a PR upstream?


Are you sure there will be only one response for that request by that user?


Nit: invalid comment :cat:


LGTM. Thanks for the change.


Does adPlayer use Cortex video api? HTML5 video won't work on Android. Instead you should use window.Cortex.player.playVideo(url, onEnd, onError).


thought i deleted that and amended the commit


Not of fan of a huge vertical list of check-boxes. How about an "Add Skill" button that reveals one more drop-down list. Then you scroll in the list to pick  the skill. Need another one? click "Add Skill" again. Just some thoughts.


This commit was due to @Wqer555
 Thanks!!

https://github.com/myuhe/smartrep.el/pull/18#issue-59596662


If this guarantees that the ad server will return only given mime types we can remove the lines 58-63 (hasNativeVideoSupport call).


My initial experience with gitHub is that it is confusing and blows horrible donkey chunks where u/i thought is concerned. The Mac and PC version appear to be NOTHING alike - it is a horrible experience. I can't NOT recommend using it enough - this is not a time saving tool.


I agree with Ravi - the dependency on MoDirectory is not good.  I suggested before that this interface seemed backwards.  It almost seems to me that we should have:

    ls = LoginSession(apic, username, password)
    moDir = MoDirectory(session)
    # If an event channel is needed, add one to the session
    session.eventChannel = cobra.eventchannel.EventChannel()


Why NodeInfo must be an apiobject?


Looking at this again all of errno is imported so importing EACCES and EPERM seems wrong.


does this not work?


Oh.  I cherry pick from here:
https://github.com/ResurrectionRemix/Resurrection_packages_apps_Settings/commit/592e2a5bb3d71374307dc3f358ec706a1295bfc5
I will fix it. Thanks for let me know.


Er, same for running the module in self-test mode?

```
$ PYTHONPATH=. python gui/layers.py
```

All that MYPAINT_DEBUG flag does is ramp up the debugging level, in theory.


Анастасия, обычно commit message содержит не описание, какие файлы поменялись, а смысл самого изменения. У вас тут есть коммиты из чужого pull request, посмотрите на них, например.


Thanks. Fixed on master.


I tried this change out after (1) removing my `dot` executable, and (2) changing it to be totally broken, and only got the "not found" error message in case (1), which I think is what was asked for.


correct, it got stuck when that happened, which often happened when resuming a recording somewhere in the middle here


Yes, user "destroyed" sounds so... violent. :)


yeah you're probably right, will check and drop it


Do you still need DoChecks?


Works for me. All its unit tests continue to pass which is nice. Implementing this change.


Just curious, what is the point of using push/pop here instead of just setting a true/false boolean?


Indeed. Rails 4.2 compatible only. `parent_model.reflections[attribute_name.to_s]` is `nil` in earlier versions of Rails


`index.html` is normally the page that gets loaded when a user navigates to the parent folder on the server, e.g. `http://example.org/` instead of `http://example.org/somefile.html`. It also makes it easier if we would like to switch the login page from `login-username.html` to `login.html` (the one with the PIN entry pad), without having to change the Logout button.


82420068_GridViewMultiEdit (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


@jongerrish Thanks for this change.
When will this be pushed to 3.0-SNAPSHOT?


@aalonso this is the wrong approach. Make a fsl-image-ivi in meta-fsl-demos which is enabled when meta-fsl-ivi is in place.


It's also used in the filesLoader section, and because you can load files in parallel it has to be an incremental thing :)


Welldown...
Let me have a see.

By the way.2 'o clock.You 're so crazy.


:+1: Good stuff!


HVACSizing_updates (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (641 of 641 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.19%25-green.svg)


See 705eb4f and 6f60e53


Change file detection is needed for keylock, as wanting to clean unused lock files, there's the need to remove a lock files without races.

For example:

Without the check:

Process A takes exclusive lock on file01
Process B waits for exclusive lock on file01.
Process A deletes file01 and then releases the lock.
Process B takes the lock on the removed file01 as it has the fd opened
Process C comes, creates the files as it doesn't exists, and it also take an exclusive lock.
Now B and C thinks to own an exclusive lock.

> 2. Relying on this isn't particularly useful since it's inherently racy; you detect if the named path is a different underlying file only if you catch it at the right time. The open & fstat in Lock sample a particular moment, if the file changes immediately after the open call you won't notice.

The assumption is that the deletion is done only by an exclusive lock owner. The check is done when the lock (shared or exclusive) is taken so it shouldn't be racy as no one other is having an exclusive lock to delete the file.

> This all strikes me as broken, if the caller needs to know the file they are operating on is the file the lock represents then they need to use the fd of the lock for their operations.

Perhaps I'm missing something. Doing stat on the opened fd will return the same information. The check is just to verify that the file isn't changed (same st_ino and st_dev).

> 1. I don't think that kind of thing belongs here since the caller may not care and shouldn't have to deal with errors for something honestly beyond the scope of this.

Maybe, as it's possible to call FileLock.Fd() this check can be done outside? (in keylock.go). I have to think a bit about this.


rax retry tests


should change to beers, better


The major source code


I've put in the thread and queue and stuff, so it shouldn't drop the artwork any more. The app is still quite unstable, but some progress...


This method looks like it works, and provides a needed function. However, I'm going slightly cross-eyed reading it. Can you think of a way to make the code more people-readable?
(If you happen to have the book 'Eloquent Ruby', see Chapter 10 on composing short, readable methods.)


Thanks :]


@otavio um that's seem a resanoble approach, will let the team working ivi demos to do proper changes.

Regards


Why introduce a dependence on baseAST.h to iterator.h?


88737258-EPW-Ruby-Access (jasondegraw) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


hi please i need help.
     am a final year student, with a project topic "network scanner" just like nmap. Have got no idea on how to do it, please i need your help in doing it please thanks


@vcaputo I agree. Updated.


very good


Good job. I will give it a try.


ah, yeah.  the Vistar lib will tack these onto ogv and image formats.  Should probably just make this the definitive source.  I'll fix that in the html5player project


The property should be named $iso_3166_1, and be included in the static array as such aswell, it will make the translation to call this method.


I managed to create an error here ;), should be content_ratings ofcourse.


プロジェクト名が重複してないかどうかはフレームワーク側がうまいことやってくれてる感じ？エラーハンドリングがされてないんで気になった。


Where is `GASLIMIT_ADJMAX_FACTOR` supposed to come from? It's referenced in the latest commits, but it doesn't seem to be defined anywhere.


I love Facebook! :heart_eyes:


yeah, `@adPlayer` here is still the player you wrote in this project which does use the `playVideo` call


Works, a little hard to read though.


No pude reproducirlo haciendo un GET sobre /users. Chequea que la version del server y la tuya esten actualizadas y si te sigue pasando dame los pasos que estas usando


It doesn't look like you are poised to save much by introducing more "formats" rather than more value filters. I would drop that field. If you think there is a lot of value in the string -> value object logic, you could make an abstract class or something.


some tests failed:
failure: http://build.servo.org/builders/linux1/builds/941


Thanks for pinning the v3.0 here on Git.


:+1: thanks.


I think probably new files made on Red Hat time should be © Red Hat.  But personally, I do work on projects on my own time, including tihs one, and Red Hat is an employer that actually explicitly disclaims copyright interest in free-time work (which is great).

Anyways up to you I'd say.


It's required for the `Vec<BaseAST*>& asts` in the signature of `isSingleLoopIterator()`


Looks great to me! Want me to merge it in or would you like to do the honors?


Do you have (or will you have) an admin that will need to list and modify user accounts?


Note that this fix is not just for the telegram/Xpress message toggling; I should have been more specific in the commit.  This is the proper way to turn off the bitwise flags that we were having problems with here, @ntwitch, though I have yet to discover any documentation explaining the magic of that particular operator set.


I think I'd prefer the taste of vegetable oil over the taste of canola oil.


Good idea to catch the exception from `build_pyx.run(self)`! I implemented that in the latest version.


You got datepicker working? Kudos! Your view is a little scary to read, though...


![pfft](https://cloud.githubusercontent.com/assets/146040/6517064/9ab97f4a-c397-11e4-8d0e-925b5c32f66c.jpg)

I'm not very amused


Ok, point granted.


None :) added in https://github.com/KyleAMathews/superagent-bluebird-promise/commit/5051d15e8d48be3c0d4275fea755def0f1c28fc1


IDFXT (refaqtor) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Actually, this looks like it's just a mistake and the file needs to be deleted.


I guess I'll have to do something with environment variables... Or use some portfinder script to prevent conflicts with unexpected PS processes running, such as Smogtours.


sorry It's hard to keep track of every comment^^
Will do that :)


@glasser currently, if a client sends message data before it's received the server's handshake, then the faye server might parse that data before it's set up the extension pipeline, throwing an error. So you'll see exceptions from some clients if they send messages before waiting for the handshake to be done.


Same as apply_button method: good methods, but I can't really tell from the view what they do, just by the names. Can you think of more descriptive names?


Okay I would delete the assert examples, the rest is in my opinion okay.


Why couldn’t you just say

class BaseAST;

instead?

Mike

On Mar 5, 2015, at 3:23 PM, Elliot Ronaghan <notifications@github.com<mailto:notifications@github.com>> wrote:

It's required for the Vec<BaseAST*>& asts in the signature of isSingleLoopIterator()

—
Reply to this email directly or view it on GitHub<https://github.com/ronawho/chapel/commit/76e798c4bee09b9aa7d9e85de23c7b6e78d6da88#commitcomment-10062286>.


Does this make the other method obsolete (above, in the same file)?  Can syncing methods be combined?

    syn sync maxlines=20000
    syn sync minlines=50000


@glasser so it doesn't matter whether you're using extensions or not; `websocket-extensions` will throw an error because it's being called before it's set up a pipeline, even an empty pipeline.


for future it'd probably be better to just do the if after the `href:`


what about when the role is checked via admin?


This conditional on what is now 1596 is what was setting the return for $value as null. I tried setting the 7th arg for PodForm::display() to the value of $lookup, but that didn't work. So I forced it this way.


@petarov It works for me up to v2.3.2, after that, same thing. and I need to use Slim/Logger which requires slim >= 2.4.0.


@mkortstiege will do it tomorrow. Now it's too late and I'll need some time to check what really do (like make branch for this PR, etc.). Never did PR before :).
Btw. is it really Ok to make PR from my Helix branch into master? As I mentioned on forum I never tried it on master.


Somehow when this widget loses focus, the function doesn't update... however it works for Strings with `StandardConstantWidget`. Am I doing something wrong?


Well, that's why I said `may`. I am not sure if performances are improved.
However, I found this as a good practice in many guides.


Oh duh, I'm following you now. Yes I could (and will) just say `class BaseAST;`

Wonder why I included baseAst.h, but forward declared CallExpr.. Anyways, not important. Thanks for catching this.


ここ、間違ってるっぽい


ok


Integrated in [24027](http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24027)


Ok, so does this PR remove the ability for us to respond correctly to IS NULL queries?


import java.util.ArrayList;

public class GridMember {

	private int xIndex, yIndex;
	private int costToGoal, costFromStart;
	private int totalCost;
	private GridMember previous;
	private boolean wallFound = false;

	private int xTarget, yTarget;

	public static final int DIAGONAL = 14;
	public static final int STRAIGHT = 10;
	public static final int COST__PER_GRID = 10;

	public static final int RIGHT_MOST_GRID_INDEX = 15;
	public static final int LEFT_MOST_GRID_INDEX = 0;

	public static final int TOP_MOST_GRID_INDEX = 15;
	public static final int BOTTOM_MOST_GRID_INDEX = 0;

	public GridMember(int x, int y, int targetX, int targetY,
			GridMember somePrev) {

		xIndex = x;
		yIndex = y;

		xTarget = targetX;
		yTarget = targetY;

		previous = somePrev;

		costCalculation();

	}

	private void costCalculation() {

		int diffX = Math.abs(previous.getxIndex() - xIndex);
		int diffY = Math.abs(previous.getyIndex() - yIndex);

		// Diagonal calculations
		if (diffX > 0 && diffY > 0) {
			costFromStart = previous.getCostFromStart() + DIAGONAL;
		} else {
			costFromStart = previous.getCostFromStart() + STRAIGHT;
		}

		costToGoal = Math.abs(xTarget - xIndex) + Math.abs(yTarget - yIndex);

		// discrete grid considered in this class (cost per grid =10)
		totalCost = COST__PER_GRID * costToGoal + costFromStart;

	}

	// Find neighbors
	public ArrayList<GridMember> findNeighbors() {

		ArrayList<GridMember> neighbor = new ArrayList<GridMember>();

		/////////////////////////////
		// LEFT BOUNDARY CONDITION
		/////////////////////////////

		if ((xIndex - 1) >= LEFT_MOST_GRID_INDEX) {

			// BOTTOM BOUNDARY CONDITION
			if ((yIndex - 1) >= BOTTOM_MOST_GRID_INDEX) {

				leftDiagonalBottomNeighbor();
				if (!wallFound) {

					// If no left diagonal wall present Add left diagonal
					// neighbor to the list
					neighbor.add(new GridMember(xIndex - 1, yIndex - 1,
							xTarget, yTarget, this));
				}
			}

			// TOP BOUNDARY CONDITION
			if ((yIndex + 1) <= TOP_MOST_GRID_INDEX) {

				leftDiagonalTopNeighbor();
				if (!wallFound) {

					// If no left wall present Add left top diagonal neighbor in
					// the list
					neighbor.add(new GridMember(xIndex - 1, yIndex + 1,
							xTarget, yTarget, this));
				}

			}

			leftSidewaysNeighbor();
			// LEFT SIDEWAYS

			if (!wallFound) {
				// If no left wall present Add left sideways neighbor in the
				// list
				neighbor.add(new GridMember(xIndex - 1, yIndex, xTarget,
						yTarget, this));
			}

		}

		// //////////////////////////
		// RIGHT BOUNDARY CONDITION
		// //////////////////////////
		if ((xIndex + 1) <= RIGHT_MOST_GRID_INDEX) {

			if ((yIndex - 1) > BOTTOM_MOST_GRID_INDEX) {
				rightDiagonalBottomNeighbor();

				if (!wallFound) {
					// If no right wall present Add right diagonal down neighbor
					// in the list
					neighbor.add(new GridMember(xIndex + 1, yIndex - 1,
							xTarget, yTarget, this));
				}

			}

			////////////////////////////
			// TOP BOUNDARY CONDITION
			////////////////////////////

			if ((yIndex + 1) <= TOP_MOST_GRID_INDEX) {
				rightDiagonalTopNeighbor();

				if (!wallFound) {
					// If no right wall present Add right diagonal up neighbor
					// in the list
					neighbor.add(new GridMember(xIndex + 1, yIndex + 1,
							xTarget, yTarget, this));
				}

			}

			rightSidewaysNeighbor();
			// RIGHT SIDEWAYS

			if (!wallFound) {
				// If no right wall present Add right sideways neighbor in the
				// list
				neighbor.add(new GridMember(xIndex + 1, yIndex, xTarget,
						yTarget, this));
			}

		}

		// ///////////////////
		// TOP WALL CONDITION
		// ///////////////////

		if ((yIndex + 1) <= TOP_MOST_GRID_INDEX) {

			topNeighbor() ;

			if (!wallFound) {
				// If no top wall preset Add top neighbor in the list

				neighbor.add(new GridMember(xIndex, yIndex + 1, xTarget,
						yTarget, this));
			}
		}

		// //////////////////////
		// BOTTOM WALL CONDITION
		// ///////////////////////
		if ((yIndex - 1) >= BOTTOM_MOST_GRID_INDEX) {

			bottomNeighbor();

			if (!wallFound) {
				// If no bottom wall preset Add bottom neighbor in the list
				neighbor.add(new GridMember(xIndex, yIndex - 1, xTarget,
						yTarget, this));
			}
		}

		return neighbor;
	}

	private void leftDiagonalBottomNeighbor() {

		//////////////////////////////
		// LEFT DIAGONAL BOTTOM     //
		//////////////////////////////
		wallFound = false;

		// smaller bottom wall +1 condition
		if ((xIndex >= 8) && (xIndex <= 13) && (yIndex == 6)) {

			wallFound = true;

		}

		// larger bottom wall +1 condition
		if ((xIndex >= 4) && (xIndex <= 13) && (yIndex == 12)) {

			wallFound = true;

		}

		// Left down diagonal wall condition
		if ((yIndex >= 4) && (yIndex <= 11) && (xIndex == 4)) {

			wallFound = true;

		}

	}

	private void leftSidewaysNeighbor() {

		/////////////////
		// LEFT SIDEWAYS
		/////////////////

		wallFound = false;

		// Left sideways
		if ((yIndex >= 4) && (yIndex <= 11) && (xIndex == 4)) {
			wallFound = true;
		}

	}

	private void leftDiagonalTopNeighbor() {

		// /////////////////////
		// LEFT DIAGONAL TOP
		// /////////////////////
		wallFound = false;

		// smaller top wall +1 condition
		if ((xIndex >= 8) && (xIndex <= 13) && (yIndex == 5)) {
			wallFound = true;
		}

		// larger top wall +1 condition
		if ((xIndex >= 4) && (xIndex <= 13) && (yIndex == 11)) {
			wallFound = true;
		}

		// Left up top diagonal wall condition
		if ((yIndex >= 3) && (yIndex <= 11) && (xIndex == 4)) {
			wallFound = true;
		}

	}

	private void topNeighbor() {

		wallFound = false;

		// top small wall present
		if (xIndex >= 8 && xIndex <= 12 && yIndex == 5) {
			wallFound = true;
		}

		// top larger wall present
		if (xIndex >= 4 && xIndex <= 12 && yIndex == 11) {
			wallFound = true;
		}

	}

	private void rightDiagonalBottomNeighbor() {
		// ////////////////////////
		// RIGHT DIAGONAL BOTTOM
		// /////////////////////////

		wallFound = false;

		// smaller bottom diagonal wall
		if ((xIndex >= 7) && (xIndex <= 12) && (yIndex == 6)) {
			wallFound = true;
		}

		// larger bottom diagonal wall
		if ((xIndex >= 3) && (xIndex <= 12) && (yIndex == 12)) {
			wallFound = true;
		}

		// right bottom diagonal wall
		if ((yIndex >= 4) && (yIndex <= 12) && (xIndex == 3)) {
			wallFound = true;
		}

	}

	private void rightSidewaysNeighbor() {
		// /////////////////
		// RIGHT SIDEWAYS
		// /////////////////
		wallFound = false;

		if (yIndex >= 4 && yIndex <= 11 && xIndex == 3) {
			wallFound = true;
		}

	}

	private void rightDiagonalTopNeighbor() {
		//////////////////////
		// RIGHT DIAGONAL TOP
		//////////////////////

		wallFound = false;

		// smaller top diagonal wall
		if ((xIndex >= 7) && (xIndex <= 12) && (yIndex == 5)) {
			wallFound = true;
		}

		// larger top diagonal wall
		if ((xIndex >= 4) && (xIndex <= 12) && (yIndex == 11)) {
			wallFound = true;
		}

		// right top diagonal wall
		if ((yIndex >= 3) && (yIndex <= 11) && (xIndex == 3)) {
			wallFound = true;
		}
	}

	private void bottomNeighbor() {

		wallFound = false;
		// bottom smaller wall present
		if ((xIndex >= 8 ) && (xIndex <= 12) && (yIndex == 6)) {
			wallFound = true;
		}

		// bottom larger wall present
		if ((xIndex >= 4) && (xIndex <= 12) && (yIndex == 12)) {
			wallFound = true;
		}
	}

	public void setxTarget(int xTarget) {
		this.xTarget = xTarget;
	}

	public void setyTarget(int yTarget) {
		this.yTarget = yTarget;
	}

	public int getxIndex() {
		return xIndex;
	}

	public void setxIndex(int xIndex) {
		this.xIndex = xIndex;
	}

	public int getyIndex() {
		return yIndex;
	}

	public void setyIndex(int yIndex) {
		this.yIndex = yIndex;
	}

	public int getTotalCost() {
		return totalCost;
	}

	public int getCostFromStart(){
		return costFromStart;
	}

	public GridMember getPrevious() {
		return previous;
	}

	public void setPrevious(GridMember previous) {
		this.previous = previous;
	}

	public int getCostToGoal(){
		return costToGoal;
	}

	public void setCostFromStart(int costFromStart){
		this.costFromStart = costFromStart;
	}
}


Do you have any examples that caused this to raise the error that are now addressed by this?
If so can we add them to the tests if they are not added already?
I try to make sure our tests reflect the use cases that we designed it for, that way in future updates, we know we didn't accidentally break it without it letting it go unnoticed.