1: D290 White spaces around docstring should be trimmed.
1: D400 First line should end with '.', not 's'
24:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email, get_user_info, isGuestUser
28:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.utils.url
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBCOMMENT_ALLOW_COMMENTS, CFG_WEBCOMMENT_ALLOW_REVIEWS, CFG_WEBCOMMENT_AUTHOR_DELETE_COMMENT_OPTION, CFG_WEBCOMMENT_MAX_ATTACHED_FILES, CFG_WEBCOMMENT_MAX_ATTACHMENT_SIZE, CFG_WEBCOMMENT_NB_REPORTS_BEFORE_SEND_EMAIL_TO_ADMIN, CFG_WEBCOMMENT_USE_RICH_TEXT_EDITOR
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.mail
31:1: E402 module level import not at top of file
32:28: E126 continuation line over-indented for hanging indent
47:1: I101 Imported names are in the wrong order. Should be create_html_select, get_html_text_editor
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.html
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.formatter
50:1: E402 module level import not at top of file
51:1: I101 Imported names are in the wrong order. Should be acc_get_role_id, acc_get_user_roles_from_user_info
51:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
51:1: E402 module level import not at top of file
52:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.access.control
52:1: E402 module level import not at top of file
54:1: E302 expected 2 blank lines, found 1
54: D203 Expected 1 blank line *before* class docstring, found 0
54: D400 First line should end with '.', not 'l'
57: D202 No blank lines allowed *after* method docstring, found 1
57: D400 First line should end with '.', not 'd'
57: D205 Blank line missing between one-line summary and description
92:13: F841 local variable 'last_comment_round_name' is assigned to but never used
98:139: E221 multiple spaces before operator
101:85: E231 missing whitespace after ','
101:87: E221 multiple spaces before operator
140:34: E127 continuation line over-indented for visual indent
152:13: E128 continuation line under-indented for visual indent
154:33: E203 whitespace before ':'
159:36: E225 missing whitespace around operator
160:168: E502 the backslash is redundant between brackets
160:57: E225 missing whitespace around operator
161:67: E127 continuation line over-indented for visual indent
164:13: E124 closing bracket does not match visual indentation
178:14: E127 continuation line over-indented for visual indent
180:14: E124 closing bracket does not match visual indentation
184: D401 First line should be imperative: 'Display', not 'Displays'
184: D205 Blank line missing between one-line summary and description
209: D400 First line should end with '.', not 'd'
209: D205 Blank line missing between one-line summary and description
244:26: E201 whitespace after '{'
244:45: E203 whitespace before ':'
244:22: E222 multiple spaces after operator
245:46: E203 whitespace before ':'
246:44: E203 whitespace before ':'
247:44: E203 whitespace before ':'
248:44: E203 whitespace before ':'
248:62: E261 at least two spaces before inline comment
248:63: E262 inline comment should start with '# '
249:44: E203 whitespace before ':'
249:62: E261 at least two spaces before inline comment
249:63: E262 inline comment should start with '# '
250:25: E124 closing bracket does not match visual indentation
260:13: F841 local variable 'last_comment_round_name' is assigned to but never used
294:106: E231 missing whitespace after ':'
294:143: E231 missing whitespace after ':'
295:32: E222 multiple spaces after operator
316:37: E225 missing whitespace around operator
336:13: E122 continuation line missing indentation or outdented
336:14: E201 whitespace after '{'
336:40: E203 whitespace before ':'
337:40: E203 whitespace before ':'
338:40: E203 whitespace before ':'
339:40: E203 whitespace before ':'
340:40: E203 whitespace before ':'
341:40: E203 whitespace before ':'
342:40: E203 whitespace before ':'
343:40: E203 whitespace before ':'
344:41: E203 whitespace before ':'
345:60: E225 missing whitespace around operator
346:40: E203 whitespace before ':'
347:13: E124 closing bracket does not match visual indentation
359:28: E128 continuation line under-indented for visual indent
360:28: E128 continuation line under-indented for visual indent
363: D400 First line should end with '.', not 'n'
363: D205 Blank line missing between one-line summary and description
402:35: E128 continuation line under-indented for visual indent
403:35: E126 continuation line over-indented for hanging indent
408:81: E225 missing whitespace around operator
408:100: E225 missing whitespace around operator
410:83: E225 missing whitespace around operator
433:105: E225 missing whitespace around operator
435:106: E225 missing whitespace around operator
441:110: E225 missing whitespace around operator
452:111: E271 multiple spaces after keyword
461:37: E126 continuation line over-indented for hanging indent
488:17: E127 continuation line over-indented for visual indent
488:33: E203 whitespace before ':'
489:33: E203 whitespace before ':'
490:33: E203 whitespace before ':'
500: D400 First line should end with '.', not 'n'
500: D205 Blank line missing between one-line summary and description
533:107: E231 missing whitespace after ':'
534:9: E266 too many leading '#' for block comment
568:94: E225 missing whitespace around operator
574:99: E225 missing whitespace around operator
589:31: E203 whitespace before ':'
590:16: E128 continuation line under-indented for visual indent
591:16: E128 continuation line under-indented for visual indent
591:31: E203 whitespace before ':'
592:16: E128 continuation line under-indented for visual indent
592:31: E203 whitespace before ':'
593:16: E128 continuation line under-indented for visual indent
594:16: E128 continuation line under-indented for visual indent
594:31: E203 whitespace before ':'
595:16: E128 continuation line under-indented for visual indent
595:31: E203 whitespace before ':'
596:16: E128 continuation line under-indented for visual indent
596:31: E203 whitespace before ':'
597:16: E124 closing bracket does not match visual indentation
600: D400 First line should end with '.', not 's'
600: D205 Blank line missing between one-line summary and description
609:55: E231 missing whitespace after ','
692:13: F841 local variable 'c_round_name' is assigned to but never used
693:13: F841 local variable 'c_restriction' is assigned to but never used
702:26: E201 whitespace after '{'
702:45: E203 whitespace before ':'
702:22: E222 multiple spaces after operator
703:46: E203 whitespace before ':'
704:44: E203 whitespace before ':'
705:44: E203 whitespace before ':'
706:44: E203 whitespace before ':'
707:44: E203 whitespace before ':'
708:44: E203 whitespace before ':'
709:44: E203 whitespace before ':'
710:44: E203 whitespace before ':'
711:44: E203 whitespace before ':'
712:25: E124 closing bracket does not match visual indentation
719:22: E201 whitespace after '{'
719:37: E203 whitespace before ':'
719:19: E222 multiple spaces after operator
720:42: E203 whitespace before ':'
721:36: E203 whitespace before ':'
722:36: E203 whitespace before ':'
724:36: E203 whitespace before ':'
725:36: E203 whitespace before ':'
726:36: E203 whitespace before ':'
727:36: E203 whitespace before ':'
731:9: E266 too many leading '#' for block comment
736:13: F841 local variable 'last_comment_round_name' is assigned to but never used
747:20: E127 continuation line over-indented for visual indent
754:35: E127 continuation line over-indented for visual indent
754:73: E221 multiple spaces before operator
763:132: E202 whitespace before ')'
764:33: E127 continuation line over-indented for visual indent
764:71: E221 multiple spaces before operator
765:140: E225 missing whitespace around operator
838:76: E261 at least two spaces before inline comment
846:275: E231 missing whitespace after ':'
847:163: E231 missing whitespace after ':'
880:38: E203 whitespace before ':'
880:62: E231 missing whitespace after ':'
882:38: E203 whitespace before ':'
882:61: E231 missing whitespace after ':'
883:38: E203 whitespace before ':'
883:63: E231 missing whitespace after ':'
885:35: E203 whitespace before ':'
892:9: E266 too many leading '#' for block comment
917:9: E266 too many leading '#' for block comment
1085:9: E122 continuation line missing indentation or outdented
1086:47: E203 whitespace before ','
1088:43: E225 missing whitespace around operator
1104: D401 First line should be imperative: 'print', not 'prints'
1104: D400 First line should end with '.', not 'm'
1112: D202 No blank lines allowed *after* method docstring, found 1
1112: D400 First line should end with '.', not 'n'
1112: D205 Blank line missing between one-line summary and description
1124:15: E221 multiple spaces before operator
1157: D400 First line should end with '.', not 'n'
1157: D205 Blank line missing between one-line summary and description
1175:15: E221 multiple spaces before operator
1177:9: E122 continuation line missing indentation or outdented
1178:9: E128 continuation line under-indented for visual indent
1179:9: E128 continuation line under-indented for visual indent
1196: D400 First line should end with '.', not 's'
1196: D205 Blank line missing between one-line summary and description
1216:22: E201 whitespace after '{'
1216:40: E203 whitespace before ':'
1217:40: E203 whitespace before ':'
1217:65: E202 whitespace before '}'
1222: D400 First line should end with '.', not 'r'
1222: D205 Blank line missing between one-line summary and description
1229:9: F841 local variable '_' is assigned to but never used
1238: D400 First line should end with '.', not 's'
1238: D205 Blank line missing between one-line summary and description
1257:22: E201 whitespace after '{'
1257:37: E203 whitespace before ':'
1257:19: E222 multiple spaces after operator
1258:42: E203 whitespace before ':'
1259:36: E203 whitespace before ':'
1260:36: E203 whitespace before ':'
1261:36: E203 whitespace before ':'
1262:36: E203 whitespace before ':'
1281:20: E222 multiple spaces after operator
1306:13: E122 continuation line missing indentation or outdented
1307:121: E502 the backslash is redundant between brackets
1308:28: E127 continuation line over-indented for visual indent
1309:100: E502 the backslash is redundant between brackets
1310:31: E127 continuation line over-indented for visual indent
1311:238: E271 multiple spaces after keyword
1320:50: E251 unexpected spaces around keyword / parameter equals
1320:52: E251 unexpected spaces around keyword / parameter equals
1355: D400 First line should end with '.', not 's'
1355: D205 Blank line missing between one-line summary and description
1373:22: E201 whitespace after '{'
1373:37: E203 whitespace before ':'
1373:19: E222 multiple spaces after operator
1374:42: E203 whitespace before ':'
1375:36: E203 whitespace before ':'
1376:36: E203 whitespace before ':'
1377:36: E203 whitespace before ':'
1378:36: E203 whitespace before ':'
1388:13: E128 continuation line under-indented for visual indent
1427:1: E128 continuation line under-indented for visual indent
1428:50: E251 unexpected spaces around keyword / parameter equals
1428:52: E251 unexpected spaces around keyword / parameter equals
1469:35: E203 whitespace before ':'
1469:42: E225 missing whitespace around operator
1470:35: E203 whitespace before ':'
1470:41: E225 missing whitespace around operator
1485: D400 First line should end with '.', not 'd'
1485: D205 Blank line missing between one-line summary and description
1492:22: E201 whitespace after '{'
1492:37: E203 whitespace before ':'
1492:19: E222 multiple spaces after operator
1493:42: E203 whitespace before ':'
1494:36: E203 whitespace before ':'
1495:36: E203 whitespace before ':'
1496:36: E203 whitespace before ':'
1497:36: E203 whitespace before ':'
1501:51: E221 multiple spaces before operator
1512:101: E222 multiple spaces after operator
1516: D401 First line should be imperative: 'Create', not 'Creates'
1516: D290 White spaces around docstring should be trimmed.
1516: D205 Blank line missing between one-line summary and description
1539:15: E221 multiple spaces before operator
1579: D400 First line should end with '.', not 'e'
1579: D200 One-line docstring should not occupy 3 lines
1605:19: E225 missing whitespace around operator
1609:36: E203 whitespace before ':'
1612:35: E203 whitespace before ':'
1613:35: E203 whitespace before ':'
1618:39: E225 missing whitespace around operator
1620: D400 First line should end with '.', not 'e'
1635:18: E225 missing whitespace around operator
1666: D400 First line should end with '.', not ')'
1666: D205 Blank line missing between one-line summary and description
1690:27: E127 continuation line over-indented for visual indent
1693:27: E127 continuation line over-indented for visual indent
1716:13: E201 whitespace after '{'
1716:25: E203 whitespace before ':'
1717:25: E203 whitespace before ':'
1718:25: E203 whitespace before ':'
1719:25: E203 whitespace before ':'
1721:26: E203 whitespace before ':'
1722:25: E203 whitespace before ':'
1723:25: E203 whitespace before ':'
1724:25: E203 whitespace before ':'
1754: D401 First line should be imperative: 'output', not 'outputs'
1754: D290 White spaces around docstring should be trimmed.
1754: D400 First line should end with '.', not 'd'
1758: D401 First line should be imperative: 'prepare', not 'prepares'
1758: D290 White spaces around docstring should be trimmed.
1758: D400 First line should end with '.', not 'r'
1773: D401 First line should be imperative: 'output', not 'outputs'
1773: D290 White spaces around docstring should be trimmed.
1773: D400 First line should end with '.', not 'w'
1788:34: E203 whitespace before ':'
1796: D400 First line should end with '.', not 't'
1796: D205 Blank line missing between one-line summary and description
1803:9: F841 local variable '_' is assigned to but never used
1842:17: E128 continuation line under-indented for visual indent
1842:50: E225 missing whitespace around operator
1842:69: E225 missing whitespace around operator
1843:17: E128 continuation line under-indented for visual indent
1843:36: E203 whitespace before ','
1843:23: E231 missing whitespace after ':'
1844:17: E128 continuation line under-indented for visual indent
1844:49: E203 whitespace before ','
1845:17: E128 continuation line under-indented for visual indent
1846:17: E128 continuation line under-indented for visual indent
1852:17: E128 continuation line under-indented for visual indent
1852:50: E225 missing whitespace around operator
1852:69: E225 missing whitespace around operator
1853:17: E128 continuation line under-indented for visual indent
1853:36: E203 whitespace before ','
1853:23: E231 missing whitespace after ':'
1854:17: E128 continuation line under-indented for visual indent
1855:17: E128 continuation line under-indented for visual indent
1860: D400 First line should end with '.', not 't'
1860: D205 Blank line missing between one-line summary and description
1866:9: F841 local variable '_' is assigned to but never used
1900:49: E225 missing whitespace around operator
1900:68: E225 missing whitespace around operator
1901:54: E272 multiple spaces before keyword
1903:49: E225 missing whitespace around operator
1903:68: E225 missing whitespace around operator
1904:54: E272 multiple spaces before keyword
1910:13: E128 continuation line under-indented for visual indent
1910:39: E203 whitespace before ','
1911:13: E128 continuation line under-indented for visual indent
1912:13: E128 continuation line under-indented for visual indent
1913:13: E128 continuation line under-indented for visual indent
1914:13: E128 continuation line under-indented for visual indent
1915:13: E128 continuation line under-indented for visual indent
1920: D400 First line should end with '.', not 't'
1920: D205 Blank line missing between one-line summary and description
1970:73: E261 at least two spaces before inline comment
1970:73: E262 inline comment should start with '# '
1972:81: E261 at least two spaces before inline comment
1972:81: E262 inline comment should start with '# '
1973:81: E261 at least two spaces before inline comment
1973:81: E262 inline comment should start with '# '
1974:81: E261 at least two spaces before inline comment
1974:81: E262 inline comment should start with '# '
1975:81: E261 at least two spaces before inline comment
1975:81: E262 inline comment should start with '# '
1976:81: E261 at least two spaces before inline comment
1976:81: E262 inline comment should start with '# '
1978:81: E261 at least two spaces before inline comment
1978:81: E262 inline comment should start with '# '
1979:81: E261 at least two spaces before inline comment
1979:81: E262 inline comment should start with '# '
1980:81: E261 at least two spaces before inline comment
1980:81: E262 inline comment should start with '# '
1981:81: E261 at least two spaces before inline comment
1981:81: E262 inline comment should start with '# '
1984:76: E261 at least two spaces before inline comment
1984:76: E262 inline comment should start with '# '
1986:84: E261 at least two spaces before inline comment
1986:84: E262 inline comment should start with '# '
1987:84: E261 at least two spaces before inline comment
1987:84: E262 inline comment should start with '# '
1988:84: E261 at least two spaces before inline comment
1988:84: E262 inline comment should start with '# '
1989:84: E261 at least two spaces before inline comment
1989:84: E262 inline comment should start with '# '
1990:84: E261 at least two spaces before inline comment
1990:84: E262 inline comment should start with '# '
1992:84: E262 inline comment should start with '# '
1993:84: E262 inline comment should start with '# '
1994:84: E262 inline comment should start with '# '
1995:84: E262 inline comment should start with '# '
1996:84: E262 inline comment should start with '# '
1998:84: E261 at least two spaces before inline comment
2001:65: E261 at least two spaces before inline comment
2001:66: E262 inline comment should start with '# '
2002:65: E261 at least two spaces before inline comment
2002:66: E262 inline comment should start with '# '
2003:66: E261 at least two spaces before inline comment
2003:66: E262 inline comment should start with '# '
2010:75: E261 at least two spaces before inline comment
2011:75: E261 at least two spaces before inline comment
2012:75: E261 at least two spaces before inline comment
2013:70: E261 at least two spaces before inline comment
2028:15: E128 continuation line under-indented for visual indent
2029:15: E128 continuation line under-indented for visual indent
2030:15: E128 continuation line under-indented for visual indent
2031:23: E211 whitespace before '('
2044:13: E122 continuation line missing indentation or outdented
2045:13: E122 continuation line missing indentation or outdented
2046:13: E122 continuation line missing indentation or outdented
2050:13: E122 continuation line missing indentation or outdented
2051:13: E122 continuation line missing indentation or outdented
2052:13: E122 continuation line missing indentation or outdented
2072:36: E225 missing whitespace around operator
2074:36: E225 missing whitespace around operator
2101: D400 First line should end with '.', not ','
2101: D205 Blank line missing between one-line summary and description
2113:37: E225 missing whitespace around operator
2113:86: E225 missing whitespace around operator
2125: D400 First line should end with '.', not ','
2125: D205 Blank line missing between one-line summary and description
2137:37: E225 missing whitespace around operator
2137:86: E225 missing whitespace around operator
2151:5: E303 too many blank lines (3)
2151: D400 First line should end with '.', not ','
2151: D205 Blank line missing between one-line summary and description
2163:37: E225 missing whitespace around operator
2163:86: E225 missing whitespace around operator
2175: D202 No blank lines allowed *after* method docstring, found 1
2175: D400 First line should end with '.', not ')'
2185:21: E126 continuation line over-indented for hanging indent
2188:26: E225 missing whitespace around operator
2224:9: E122 continuation line missing indentation or outdented
2225:9: E122 continuation line missing indentation or outdented
2226:9: E122 continuation line missing indentation or outdented
2227:9: E122 continuation line missing indentation or outdented
2228:9: E122 continuation line missing indentation or outdented
2229:9: E122 continuation line missing indentation or outdented
2230:9: E122 continuation line missing indentation or outdented
2231:9: E124 closing bracket does not match visual indentation
2234: D401 First line should be imperative: 'Print', not 'Prints'
2234: D400 First line should end with '.', not 'w'
2234: D205 Blank line missing between one-line summary and description
2256:15: E127 continuation line over-indented for visual indent
2256:109: E502 the backslash is redundant between brackets
2258:16: E127 continuation line over-indented for visual indent
2260:48: E225 missing whitespace around operator
2260:67: E225 missing whitespace around operator
2264: D401 First line should be imperative: 'Print', not 'Prints'
2264: D400 First line should end with '.', not 'w'
2264: D205 Blank line missing between one-line summary and description
2286:72: E221 multiple spaces before operator
2287:16: E127 continuation line over-indented for visual indent
2287:82: E502 the backslash is redundant between brackets
2287:44: E225 missing whitespace around operator
2287:63: E225 missing whitespace around operator
2291:81: E221 multiple spaces before operator
2292:20: E126 continuation line over-indented for hanging indent
2292:86: E502 the backslash is redundant between brackets
2292:48: E225 missing whitespace around operator
2292:67: E225 missing whitespace around operator
2296:79: E221 multiple spaces before operator
2297:20: E126 continuation line over-indented for hanging indent
2297:86: E502 the backslash is redundant between brackets
2297:48: E225 missing whitespace around operator
2297:67: E225 missing whitespace around operator
2301:16: E127 continuation line over-indented for visual indent
2305: D401 First line should be imperative: 'Print', not 'Prints'
2305: D400 First line should end with '.', not 'e'
2305: D205 Blank line missing between one-line summary and description
2332:15: E271 multiple spaces after keyword
2334: D202 No blank lines allowed *after* method docstring, found 1
2334: D400 First line should end with '.', not 'e'
2334: D205 Blank line missing between one-line summary and description
2372: D400 First line should end with '.', not 'r'
2414:78: E251 unexpected spaces around keyword / parameter equals
2414:80: E251 unexpected spaces around keyword / parameter equals
2415:78: E251 unexpected spaces around keyword / parameter equals
2415:80: E251 unexpected spaces around keyword / parameter equals
2416:79: E251 unexpected spaces around keyword / parameter equals
2416:81: E251 unexpected spaces around keyword / parameter equals
2417:55: E231 missing whitespace after ','
2417:78: E251 unexpected spaces around keyword / parameter equals
2417:80: E251 unexpected spaces around keyword / parameter equals
2425:22: E222 multiple spaces after operator
2460:9: E303 too many blank lines (3)
2523:34: E126 continuation line over-indented for hanging indent
2526:102: E502 the backslash is redundant between brackets
2526:77: E225 missing whitespace around operator
2526:96: E225 missing whitespace around operator
2531:98: E502 the backslash is redundant between brackets
2531:73: E225 missing whitespace around operator
2531:92: E225 missing whitespace around operator
2555:25: E127 continuation line over-indented for visual indent
2555:37: E203 whitespace before ':'
2556:37: E203 whitespace before ':'
2557:37: E203 whitespace before ':'
2558:37: E203 whitespace before ':'
2559:37: E203 whitespace before ':'
2560:37: E203 whitespace before ':'
2565:24: E261 at least two spaces before inline comment
2570:16: E127 continuation line over-indented for visual indent
2597:52: E126 continuation line over-indented for hanging indent


3: L102 copyright year is outdated, expected 2015 but got 2014


Done


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
30:1: I101 Imported names are in the wrong order. Should be DatabaseError, run_sql
32:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.legacy.dbquery
33:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.bibsched.bibtask
34:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_CHARS_ALPHANUMERIC_SEPARATORS, CFG_BIBINDEX_CHARS_PUNCTUATION
34:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibrecord
35:6: E126 continuation line over-indented for hanging indent
55: D200 One-line docstring should not occupy 3 lines
65:9: E128 continuation line under-indented for visual indent
68:1: E302 expected 2 blank lines, found 1
68: D401 First line should be imperative: 'Return', not 'Returns'
68: D209 Put multi-line docstring closing quotes on separate line
68: D205 Blank line missing between one-line summary and description
68: D208 Docstring is over-indented
84: D401 First line should be imperative: 'Return', not 'Returns'
84: D209 Put multi-line docstring closing quotes on separate line
84: D400 First line should end with '.', not 'e'
84: D205 Blank line missing between one-line summary and description
84: D208 Docstring is over-indented
99: D401 First line should be imperative: 'Return', not 'Returns'
99: D400 First line should end with '.', not 'e'
99: D205 Blank line missing between one-line summary and description
99: D208 Docstring is over-indented
107:5: B901 blind except: statement
114: D401 First line should be imperative: 'Get', not 'Gets'
114: D290 White spaces around docstring should be trimmed.
114: D209 Put multi-line docstring closing quotes on separate line
114: D400 First line should end with '.', not 'd'
114: D205 Blank line missing between one-line summary and description
114: D208 Docstring is over-indented
120:5: B901 blind except: statement
127: D401 First line should be imperative: 'Get', not 'Gets'
127: D290 White spaces around docstring should be trimmed.
127: D209 Put multi-line docstring closing quotes on separate line
127: D400 First line should end with '.', not 'd'
127: D205 Blank line missing between one-line summary and description
127: D208 Docstring is over-indented
133:5: B901 blind except: statement
140: D205 Blank line missing between one-line summary and description
170: D400 First line should end with '.', not 's'
170: D205 Blank line missing between one-line summary and description
170: D208 Docstring is over-indented
181:11: E271 multiple spaces after keyword
187:1: F401 'get_idx_indexer' imported but unused
187:1: E402 module level import not at top of file
190: D401 First line should be imperative: 'Return', not 'Returns'
190: D209 Put multi-line docstring closing quotes on separate line
190: D205 Blank line missing between one-line summary and description
190: D208 Docstring is over-indented
212: D401 First line should be imperative: 'Return', not 'Returns'
212: D290 White spaces around docstring should be trimmed.
221: D401 First line should be imperative: 'Return', not 'Returns'
221: D209 Put multi-line docstring closing quotes on separate line
221: D400 First line should end with '.', not 'h'
221: D205 Blank line missing between one-line summary and description
221: D208 Docstring is over-indented
232: D401 First line should be imperative: 'Check', not 'Checks'
232: D400 First line should end with '.', not 'l'
241:1: E302 expected 2 blank lines, found 1
241: D400 First line should end with '.', not 's'
241: D205 Blank line missing between one-line summary and description
241: D208 Docstring is over-indented
255:1: E302 expected 2 blank lines, found 1
255: D401 First line should be imperative: 'Return', not 'Returns'
255: D205 Blank line missing between one-line summary and description
255: D208 Docstring is over-indented
268: D401 First line should be imperative: 'Return', not 'Returns'
268: D209 Put multi-line docstring closing quotes on separate line
268: D205 Blank line missing between one-line summary and description
268: D208 Docstring is over-indented
281: D401 First line should be imperative: 'Return', not 'Returns'
281: D209 Put multi-line docstring closing quotes on separate line
281: D205 Blank line missing between one-line summary and description
281: D208 Docstring is over-indented
291: D401 First line should be imperative: 'Return', not 'Returns'
291: D400 First line should end with '.', not 's'
291: D205 Blank line missing between one-line summary and description
291: D208 Docstring is over-indented
299:5: F841 local variable 'out' is assigned to but never used
321: D401 First line should be imperative: 'Return', not 'Returns'
321: D209 Put multi-line docstring closing quotes on separate line
321: D400 First line should end with '.', not 'g'
321: D205 Blank line missing between one-line summary and description
321: D208 Docstring is over-indented
326:26: E261 at least two spaces before inline comment
326:27: E262 inline comment should start with '# '
327:26: E261 at least two spaces before inline comment
327:27: E262 inline comment should start with '# '
342:25: E261 at least two spaces before inline comment
342:26: E262 inline comment should start with '# '
362: D401 First line should be imperative: 'Return', not 'Returns'
362: D209 Put multi-line docstring closing quotes on separate line
362: D400 First line should end with '.', not 'g'
362: D205 Blank line missing between one-line summary and description
362: D208 Docstring is over-indented
399: D401 First line should be imperative: 'Return', not 'Returns'
399: D205 Blank line missing between one-line summary and description
399: D208 Docstring is over-indented
437: D401 First line should be imperative: 'Return', not 'Returns'
437: D400 First line should end with '.', not ':'
437: D205 Blank line missing between one-line summary and description
437: D208 Docstring is over-indented
442:10: E225 missing whitespace around operator
450: D401 First line should be imperative: 'Remove', not 'Removes'
450: D205 Blank line missing between one-line summary and description
450: D208 Docstring is over-indented
463: D208 Docstring is over-indented
463: D200 One-line docstring should not occupy 3 lines
477: D401 First line should be imperative: 'Create', not 'Creates'
477: D400 First line should end with '.', not 'd'
477: D205 Blank line missing between one-line summary and description
477: D208 Docstring is over-indented
487: D101 Docstring missing
491: D401 First line should be imperative: 'Return', not 'Returns'
491: D300 Expected """-quotes, got '-quotes
501: D401 First line should be imperative: 'Return', not 'Returns'
501: D400 First line should end with '.', not 'y'
501: D205 Blank line missing between one-line summary and description
501: D208 Docstring is over-indented
512:47: E202 whitespace before ')'
516: D401 First line should be imperative: 'Check', not 'Checks'
516: D400 First line should end with '.', not 't'
519:25: E272 multiple spaces before keyword
526: D401 First line should be imperative: 'Check', not 'Checks'
526: D209 Put multi-line docstring closing quotes on separate line
526: D400 First line should end with '.', not ';'
526: D205 Blank line missing between one-line summary and description
526: D208 Docstring is over-indented
532: D401 First line should be imperative: 'Return', not 'Returns'
532: D209 Put multi-line docstring closing quotes on separate line
532: D400 First line should end with '.', not ';'
532: D205 Blank line missing between one-line summary and description
532: D208 Docstring is over-indented
541: D401 First line should be imperative: 'Find', not 'Finds'
541: D400 First line should end with '.', not 'n'
541: D205 Blank line missing between one-line summary and description
541: D208 Docstring is over-indented


1: D100 Docstring missing
21:1: I201 Missing newline before sections or imports.
23:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibindex.engine_stopwords
23:1: F401 'CFG_ETCDIR' imported but unused
24:6: E126 continuation line over-indented for hanging indent
68:1: E302 expected 2 blank lines, found 1
68: D400 First line should end with '.', not 'g'
68: D205 Blank line missing between one-line summary and description
81:1: E302 expected 2 blank lines, found 0
81: D103 Docstring missing
92: D401 First line should be imperative: 'Return', not 'Returns'
92: D205 Blank line missing between one-line summary and description
92: D208 Docstring is over-indented
106: D401 First line should be imperative: 'Return', not 'Returns'
106: D205 Blank line missing between one-line summary and description
106: D208 Docstring is over-indented
120:1: E302 expected 2 blank lines, found 1
120: D401 First line should be imperative: 'Return', not 'Returns'
120: D208 Docstring is over-indented
130:1: E302 expected 2 blank lines, found 1
130: D400 First line should end with '.', not 'e'
130: D205 Blank line missing between one-line summary and description
159:1: E302 expected 2 blank lines, found 1
159: D400 First line should end with '.', not 'e'
159: D205 Blank line missing between one-line summary and description


25:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
43:152: E203 whitespace before ':'
50:160: E203 whitespace before ':'
57:160: E203 whitespace before ':'
65:107: E203 whitespace before ':'
73:96: E203 whitespace before ':'
81:96: E203 whitespace before ':'
89:101: E203 whitespace before ':'
97:101: E203 whitespace before ':'
105:116: E203 whitespace before ':'
113:116: E203 whitespace before ':'
121:107: E203 whitespace before ':'
129:114: E203 whitespace before ':'
137:131: E203 whitespace before ':'
155:18: E128 continuation line under-indented for visual indent
155:83: E203 whitespace before ':'
166:18: E128 continuation line under-indented for visual indent
166:88: E203 whitespace before ':'
177:18: E128 continuation line under-indented for visual indent
177:88: E203 whitespace before ':'
188:18: E128 continuation line under-indented for visual indent
188:101: E203 whitespace before ':'
203:18: E128 continuation line under-indented for visual indent
203:101: E203 whitespace before ':'
216:18: E128 continuation line under-indented for visual indent
216:108: E203 whitespace before ':'
229:18: E128 continuation line under-indented for visual indent
229:126: E203 whitespace before ':'
232:13: E128 continuation line under-indented for visual indent
233:13: E128 continuation line under-indented for visual indent
234:13: E128 continuation line under-indented for visual indent
235:13: E128 continuation line under-indented for visual indent
236:13: E128 continuation line under-indented for visual indent
237:13: E128 continuation line under-indented for visual indent
238:13: E128 continuation line under-indented for visual indent
239:13: E128 continuation line under-indented for visual indent
240:13: E128 continuation line under-indented for visual indent
241:13: E128 continuation line under-indented for visual indent
242:13: E128 continuation line under-indented for visual indent
243:13: E128 continuation line under-indented for visual indent
244:13: E128 continuation line under-indented for visual indent
245:13: E128 continuation line under-indented for visual indent
246:13: E128 continuation line under-indented for visual indent
247:13: E128 continuation line under-indented for visual indent
248:13: E128 continuation line under-indented for visual indent
249:13: E128 continuation line under-indented for visual indent
250:13: E128 continuation line under-indented for visual indent
251:13: E128 continuation line under-indented for visual indent
252:13: E128 continuation line under-indented for visual indent
253:13: E128 continuation line under-indented for visual indent
254:13: E128 continuation line under-indented for visual indent
263:18: E128 continuation line under-indented for visual indent
263:97: E203 whitespace before ':'
283:1: E303 too many blank lines (3)
320:1: E303 too many blank lines (3)
325:5: E303 too many blank lines (2)
334:42: E231 missing whitespace after ','
334:47: E231 missing whitespace after ','
334:53: E231 missing whitespace after ','
340:39: E231 missing whitespace after ','
340:45: E231 missing whitespace after ','
340:51: E231 missing whitespace after ','
340:57: E231 missing whitespace after ','
340:63: E231 missing whitespace after ','
346:39: E231 missing whitespace after ','
346:45: E231 missing whitespace after ','
346:51: E231 missing whitespace after ','
346:57: E231 missing whitespace after ','
359:90: E231 missing whitespace after ','
359:96: E231 missing whitespace after ','


1: D400 First line should end with '.', not 'n'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D400 First line should end with '.', not 'n'
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
40:41: E251 unexpected spaces around keyword / parameter equals
40:43: E251 unexpected spaces around keyword / parameter equals
40:66: E251 unexpected spaces around keyword / parameter equals
40:68: E251 unexpected spaces around keyword / parameter equals
40:94: E251 unexpected spaces around keyword / parameter equals
40:96: E251 unexpected spaces around keyword / parameter equals
40:123: E251 unexpected spaces around keyword / parameter equals
40:125: E251 unexpected spaces around keyword / parameter equals
40: D102 Docstring missing
45:5: E303 too many blank lines (2)
45: D401 First line should be imperative: 'Use', not 'Uses'
45: D209 Put multi-line docstring closing quotes on separate line
45: D400 First line should end with '.', not 's'
45: D205 Blank line missing between one-line summary and description
45: D208 Docstring is over-indented
48:55: E231 missing whitespace after ','
50: D205 Blank line missing between one-line summary and description
58: D102 Docstring missing
61: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
32:1: E303 too many blank lines (3)
32: D203 Expected 1 blank line *before* class docstring, found 0
41:41: E251 unexpected spaces around keyword / parameter equals
41:43: E251 unexpected spaces around keyword / parameter equals
41:66: E251 unexpected spaces around keyword / parameter equals
41:68: E251 unexpected spaces around keyword / parameter equals
41:94: E251 unexpected spaces around keyword / parameter equals
41:96: E251 unexpected spaces around keyword / parameter equals
41:123: E251 unexpected spaces around keyword / parameter equals
41:125: E251 unexpected spaces around keyword / parameter equals
41: D102 Docstring missing
43:49: E127 continuation line over-indented for visual indent
44:49: E127 continuation line over-indented for visual indent
45:49: E127 continuation line over-indented for visual indent
71:35: E203 whitespace before ':'
72:35: E203 whitespace before ':'
73:35: E203 whitespace before ':'
74:35: E203 whitespace before ':'
75:35: E203 whitespace before ':'
89:25: E116 unexpected indentation (comment)
100:21: E116 unexpected indentation (comment)
106: D202 No blank lines allowed *after* method docstring, found 1
128:61: E251 unexpected spaces around keyword / parameter equals
128:63: E251 unexpected spaces around keyword / parameter equals
142:22: E711 comparison to None should be 'if cond is not None:'
159:9: F841 local variable 'raw' is assigned to but never used
180: D202 No blank lines allowed *after* method docstring, found 1
196: D401 First line should be imperative: 'List', not 'Lists'
196: D400 First line should end with '.', not ']'
198:21: E711 comparison to None should be 'if cond is None:'
202: D401 First line should be imperative: 'List', not 'Lists'
202: D400 First line should end with '.', not 'l'
212: D401 First line should be imperative: 'Bring', not 'Brings'
212: D202 No blank lines allowed *after* function docstring, found 1
212: D400 First line should end with '.', not 's'
229: D401 First line should be imperative: 'Run', not 'Runs'
229: D400 First line should end with '.', not 'l'
232:18: E272 multiple spaces before keyword
238: D401 First line should be imperative: 'Find', not 'Finds'
238: D400 First line should end with '.', not "'"
261:5: E303 too many blank lines (2)
288:5: E303 too many blank lines (2)
288: D205 Blank line missing between one-line summary and description
288: D208 Docstring is over-indented
297:5: E303 too many blank lines (2)
297: D400 First line should end with '.', not 'r'
302:5: E303 too many blank lines (2)
302: D290 White spaces around docstring should be trimmed.
326:5: E303 too many blank lines (2)
326: D205 Blank line missing between one-line summary and description
326: D208 Docstring is over-indented
336:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
32: D103 Docstring missing
41: D103 Docstring missing
50: D103 Docstring missing
59: D103 Docstring missing
63: D209 Put multi-line docstring closing quotes on separate line
63: D203 Expected 1 blank line *before* class docstring, found 0
63: D302 Use u""" for docstrings with Unicode
63: D205 Blank line missing between one-line summary and description
63: D208 Docstring is over-indented
69:41: E251 unexpected spaces around keyword / parameter equals
69:43: E251 unexpected spaces around keyword / parameter equals
69:66: E251 unexpected spaces around keyword / parameter equals
69:68: E251 unexpected spaces around keyword / parameter equals
69:94: E251 unexpected spaces around keyword / parameter equals
69:96: E251 unexpected spaces around keyword / parameter equals
69:123: E251 unexpected spaces around keyword / parameter equals
69:125: E251 unexpected spaces around keyword / parameter equals
69: D400 First line should end with '.', not 'n'
72:49: E127 continuation line over-indented for visual indent
73:49: E127 continuation line over-indented for visual indent
74:49: E127 continuation line over-indented for visual indent
77:5: E303 too many blank lines (2)
77: D400 First line should end with '.', not 'r'
82:5: E303 too many blank lines (2)
82: D401 First line should be imperative: 'Split', not 'Splits'
82: D400 First line should end with '.', not 's'
82: D205 Blank line missing between one-line summary and description
104:22: E201 whitespace after '['
129:5: E303 too many blank lines (2)
129: D102 Docstring missing
132: D102 Docstring missing


1: D100 Docstring missing
22: D203 Expected 1 blank line *before* class docstring, found 0
22: D204 Expected 1 blank line *after* class docstring, found 2
22: D400 First line should end with '.', not ')'
22: D205 Blank line missing between one-line summary and description
22: D208 Docstring is over-indented
30:5: E303 too many blank lines (2)
30: D102 Docstring missing
34:5: E303 too many blank lines (2)
34: D401 First line should be imperative: 'Return', not 'Returns'
34: D400 First line should end with '.', not 'n'
38: D205 Blank line missing between one-line summary and description
45:15: F821 undefined name 'get_record'
49: D401 First line should be imperative: 'Return', not 'Returns'
49: D200 One-line docstring should not occupy 3 lines


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
25:6: E126 continuation line over-indented for hanging indent
27:1: I101 Imported names are in the wrong order. Should be strip_accents, wash_for_utf8
28:1: I101 Imported names are in the wrong order. Should be apply_stemming, length_check, lower_index_term, remove_latex_markup, remove_stopwords
28:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_washer should be before from invenio.utils.text
29:6: E126 continuation line over-indented for hanging indent
31:1: I101 Imported names are in the wrong order. Should be latex_formula_re, re_arxiv, re_block_punctuation_begin, re_block_punctuation_end, re_punctuation, re_separators
31:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.legacy.bibindex.engine_washer
32:6: E126 continuation line over-indented for hanging indent
41:1: E303 too many blank lines (3)
41: D203 Expected 1 blank line *before* class docstring, found 0
41: D205 Blank line missing between one-line summary and description
41: D208 Docstring is over-indented
47:41: E251 unexpected spaces around keyword / parameter equals
47:43: E251 unexpected spaces around keyword / parameter equals
47:66: E251 unexpected spaces around keyword / parameter equals
47:68: E251 unexpected spaces around keyword / parameter equals
47:94: E251 unexpected spaces around keyword / parameter equals
47:96: E251 unexpected spaces around keyword / parameter equals
47:123: E251 unexpected spaces around keyword / parameter equals
47:125: E251 unexpected spaces around keyword / parameter equals
47: D400 First line should end with '.', not 'n'
55:5: E303 too many blank lines (2)
55: D401 First line should be imperative: 'Pick', not 'Picks'
55: D400 First line should end with '.', not ')'
66:5: E303 too many blank lines (3)
66: D202 No blank lines allowed *after* method docstring, found 1
66: D400 First line should end with '.', not 's'
66: D205 Blank line missing between one-line summary and description
66: D208 Docstring is over-indented
117:5: E303 too many blank lines (2)
117: D202 No blank lines allowed *after* method docstring, found 1
117: D400 First line should end with '.', not 's'
117: D205 Blank line missing between one-line summary and description
117: D208 Docstring is over-indented
159:5: E303 too many blank lines (2)
159: D400 First line should end with '.', not 's'
159: D205 Blank line missing between one-line summary and description
159: D208 Docstring is over-indented
167: D401 First line should be imperative: 'Pick', not 'Picks'
167: D400 First line should end with '.', not 'n'
167: D205 Blank line missing between one-line summary and description


1: D208 Docstring is over-indented
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
39:41: E251 unexpected spaces around keyword / parameter equals
39:43: E251 unexpected spaces around keyword / parameter equals
39:66: E251 unexpected spaces around keyword / parameter equals
39:68: E251 unexpected spaces around keyword / parameter equals
39:94: E251 unexpected spaces around keyword / parameter equals
39:96: E251 unexpected spaces around keyword / parameter equals
39:123: E251 unexpected spaces around keyword / parameter equals
39:125: E251 unexpected spaces around keyword / parameter equals
39: D400 First line should end with '.', not 'y'
39: D205 Blank line missing between one-line summary and description
39: D208 Docstring is over-indented
48:5: E303 too many blank lines (2)
48: D401 First line should be imperative: 'Pick', not 'Picks'
48: D400 First line should end with '.', not ')'
57: D401 First line should be imperative: 'Pick', not 'Picks'
57: D400 First line should end with '.', not 'n'
57: D205 Blank line missing between one-line summary and description
65: D102 Docstring missing
68: D102 Docstring missing
71: D102 Docstring missing
73:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
20:21: W291 trailing whitespace
29:1: E303 too many blank lines (4)
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D204 Expected 1 blank line *after* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
34:41: E251 unexpected spaces around keyword / parameter equals
34:43: E251 unexpected spaces around keyword / parameter equals
34:66: E251 unexpected spaces around keyword / parameter equals
34:68: E251 unexpected spaces around keyword / parameter equals
34:94: E251 unexpected spaces around keyword / parameter equals
34:96: E251 unexpected spaces around keyword / parameter equals
34:123: E251 unexpected spaces around keyword / parameter equals
34:125: E251 unexpected spaces around keyword / parameter equals
34: D102 Docstring missing
36:49: E127 continuation line over-indented for visual indent
37:49: E127 continuation line over-indented for visual indent
38:49: E127 continuation line over-indented for visual indent
40: D401 First line should be imperative: 'Return', not 'Returns'
40: D200 One-line docstring should not occupy 3 lines


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
27: D203 Expected 1 blank line *before* class docstring, found 0
27: D205 Blank line missing between one-line summary and description
27: D208 Docstring is over-indented
43:41: E251 unexpected spaces around keyword / parameter equals
43:43: E251 unexpected spaces around keyword / parameter equals
43: D102 Docstring missing
44:24: E127 continuation line over-indented for visual indent
44:40: E251 unexpected spaces around keyword / parameter equals
44:42: E251 unexpected spaces around keyword / parameter equals
45:24: E127 continuation line over-indented for visual indent
45:42: E251 unexpected spaces around keyword / parameter equals
45:44: E251 unexpected spaces around keyword / parameter equals
46:24: E127 continuation line over-indented for visual indent
46:43: E251 unexpected spaces around keyword / parameter equals
46:45: E251 unexpected spaces around keyword / parameter equals
50:5: E303 too many blank lines (2)
50: D208 Docstring is over-indented
68: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
26: D203 Expected 1 blank line *before* class docstring, found 0
26: D205 Blank line missing between one-line summary and description
26: D208 Docstring is over-indented
39:41: E251 unexpected spaces around keyword / parameter equals
39:43: E251 unexpected spaces around keyword / parameter equals
39:66: E251 unexpected spaces around keyword / parameter equals
39:68: E251 unexpected spaces around keyword / parameter equals
39:94: E251 unexpected spaces around keyword / parameter equals
39:96: E251 unexpected spaces around keyword / parameter equals
39:123: E251 unexpected spaces around keyword / parameter equals
39:125: E251 unexpected spaces around keyword / parameter equals
39: D102 Docstring missing
43:5: E303 too many blank lines (2)
43: D208 Docstring is over-indented
61: D102 Docstring missing
64: D102 Docstring missing
67: D102 Docstring missing
70: D102 Docstring missing


1: D100 Docstring missing
20:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
23:1: E302 expected 2 blank lines, found 1
23: D203 Expected 1 blank line *before* class docstring, found 0
23: D400 First line should end with '.', not 'g'
23: D205 Blank line missing between one-line summary and description
23: D208 Docstring is over-indented
53: D102 Docstring missing
57:5: E303 too many blank lines (2)
57: D102 Docstring missing
70:60: W601 .has_key() is deprecated, use 'in'
72:39: E127 continuation line over-indented for visual indent
73:47: W601 .has_key() is deprecated, use 'in'
80: D400 First line should end with '.', not 'd'
80: D205 Blank line missing between one-line summary and description


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
25:1: I100 Imports statements are in the wrong order. import logging should be before import sys
27:1: I100 Imports statements are in the wrong order. import re should be before import urllib2
31:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_FULLTEXT_INDEX_LOCAL_FILES_ONLY, CFG_BIBINDEX_SPLASH_PAGES, CFG_SOLR_URL, CFG_XAPIAN_ENABLED
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
32:6: E126 continuation line over-indented for hanging indent
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.websubmit.file_converter should be before from invenio.utils.html
38:1: I100 Imports statements are in the wrong order. from invenio.legacy.miscutil.solrutils_bibindex_indexer should be before from invenio.legacy.websubmit.file_converter
40:1: I101 Imported names are in the wrong order. Should be BibRecDocs, InvenioBibDocFileError, bibdocfile_url_p, bibdocfile_url_to_bibdoc, download_url
40:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.miscutil.xapianutils_bibindex_indexer
41:6: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibsched.bibtask
46:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.ext.logging
46:1: I201 Missing newline before sections or imports.
47:1: I201 Missing newline before sections or imports.
49:29: E261 at least two spaces before inline comment
52: D203 Expected 1 blank line *before* class docstring, found 0
52: D208 Docstring is over-indented
52: D200 One-line docstring should not occupy 3 lines
57:41: E251 unexpected spaces around keyword / parameter equals
57:43: E251 unexpected spaces around keyword / parameter equals
57:66: E251 unexpected spaces around keyword / parameter equals
57:68: E251 unexpected spaces around keyword / parameter equals
57:94: E251 unexpected spaces around keyword / parameter equals
57:96: E251 unexpected spaces around keyword / parameter equals
57:123: E251 unexpected spaces around keyword / parameter equals
57:125: E251 unexpected spaces around keyword / parameter equals
57: D102 Docstring missing
60:49: E127 continuation line over-indented for visual indent
61:49: E127 continuation line over-indented for visual indent
62:49: E127 continuation line over-indented for visual indent
64: D401 First line should be imperative: 'Allow', not 'Allows'
64: D400 First line should end with '.', not 'g'
68: D400 First line should end with '.', not 'r'
73:5: E303 too many blank lines (2)
73: D401 First line should be imperative: 'Return', not 'Returns'
73: D400 First line should end with '.', not 'y'
73: D205 Blank line missing between one-line summary and description
73: D208 Docstring is over-indented
101:28: E713 test for membership should be 'not in'
158:66: E261 at least two spaces before inline comment
185:5: E303 too many blank lines (2)
185: D102 Docstring missing
189:5: E303 too many blank lines (2)
189: D102 Docstring missing
192: D102 Docstring missing
194:1: W391 blank line at end of file


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
26: D203 Expected 1 blank line *before* class docstring, found 0
26: D208 Docstring is over-indented
26: D200 One-line docstring should not occupy 3 lines
31:41: E251 unexpected spaces around keyword / parameter equals
31:43: E251 unexpected spaces around keyword / parameter equals
31:66: E251 unexpected spaces around keyword / parameter equals
31:68: E251 unexpected spaces around keyword / parameter equals
31:94: E251 unexpected spaces around keyword / parameter equals
31:96: E251 unexpected spaces around keyword / parameter equals
31:123: E251 unexpected spaces around keyword / parameter equals
31:125: E251 unexpected spaces around keyword / parameter equals
31: D102 Docstring missing
35:5: E303 too many blank lines (2)
35: D401 First line should be imperative: 'Tokenize', not 'Tokenizes'
35: D400 First line should end with '.', not 'y'
46: D102 Docstring missing
49: D102 Docstring missing
52: D102 Docstring missing
55: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
30:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.indexer.tokenizers.BibIndexMultiFieldTokenizer
50: D203 Expected 1 blank line *before* class docstring, found 0
50: D205 Blank line missing between one-line summary and description
50: D208 Docstring is over-indented
60:41: E251 unexpected spaces around keyword / parameter equals
60:43: E251 unexpected spaces around keyword / parameter equals
60:66: E251 unexpected spaces around keyword / parameter equals
60:68: E251 unexpected spaces around keyword / parameter equals
60:94: E251 unexpected spaces around keyword / parameter equals
60:96: E251 unexpected spaces around keyword / parameter equals
60:123: E251 unexpected spaces around keyword / parameter equals
60:125: E251 unexpected spaces around keyword / parameter equals
60: D102 Docstring missing
67:5: E303 too many blank lines (2)
67: D400 First line should end with '.', not 's'
67: D205 Blank line missing between one-line summary and description
112: D401 First line should be imperative: 'Tokenize', not 'Tokenizes'
112: D205 Blank line missing between one-line summary and description
128: D102 Docstring missing
131: D102 Docstring missing
134: D102 Docstring missing
137: D102 Docstring missing
140: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
26:1: F401 'CFG_BIBINDEX_INDEX_TABLE_TYPE' imported but unused
31:1: E303 too many blank lines (3)
31: D203 Expected 1 blank line *before* class docstring, found 0
31: D205 Blank line missing between one-line summary and description
31: D208 Docstring is over-indented
59:41: E251 unexpected spaces around keyword / parameter equals
59:43: E251 unexpected spaces around keyword / parameter equals
59:66: E251 unexpected spaces around keyword / parameter equals
59:68: E251 unexpected spaces around keyword / parameter equals
59:94: E251 unexpected spaces around keyword / parameter equals
59:96: E251 unexpected spaces around keyword / parameter equals
59:123: E251 unexpected spaces around keyword / parameter equals
59:125: E251 unexpected spaces around keyword / parameter equals
59: D400 First line should end with '.', not 'y'
59: D205 Blank line missing between one-line summary and description
59: D208 Docstring is over-indented
68:5: E303 too many blank lines (2)
68: D401 First line should be imperative: 'Pick', not 'Picks'
68: D400 First line should end with '.', not ')'
73:5: E303 too many blank lines (2)
73: D102 Docstring missing
76: D102 Docstring missing
79: D102 Docstring missing
81:1: W391 blank line at end of file


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
33: D203 Expected 1 blank line *before* class docstring, found 0
33: D205 Blank line missing between one-line summary and description
33: D208 Docstring is over-indented
50:41: E251 unexpected spaces around keyword / parameter equals
50:43: E251 unexpected spaces around keyword / parameter equals
50:66: E251 unexpected spaces around keyword / parameter equals
50:68: E251 unexpected spaces around keyword / parameter equals
50:94: E251 unexpected spaces around keyword / parameter equals
50:96: E251 unexpected spaces around keyword / parameter equals
50:123: E251 unexpected spaces around keyword / parameter equals
50:125: E251 unexpected spaces around keyword / parameter equals
50: D102 Docstring missing
54:5: E303 too many blank lines (2)
54: D400 First line should end with '.', not 'e'
54: D205 Blank line missing between one-line summary and description
54: D208 Docstring is over-indented
60: D102 Docstring missing
63: D102 Docstring missing
66: D102 Docstring missing
69: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
29:1: E303 too many blank lines (3)
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
43:41: E251 unexpected spaces around keyword / parameter equals
43:43: E251 unexpected spaces around keyword / parameter equals
43:66: E251 unexpected spaces around keyword / parameter equals
43:68: E251 unexpected spaces around keyword / parameter equals
43:94: E251 unexpected spaces around keyword / parameter equals
43:96: E251 unexpected spaces around keyword / parameter equals
43:123: E251 unexpected spaces around keyword / parameter equals
43:125: E251 unexpected spaces around keyword / parameter equals
43: D400 First line should end with '.', not 'y'
43: D205 Blank line missing between one-line summary and description
43: D208 Docstring is over-indented
52:5: E303 too many blank lines (2)
52: D401 First line should be imperative: 'Pick', not 'Picks'
52: D400 First line should end with '.', not ')'
57:5: E303 too many blank lines (2)
57: D102 Docstring missing
60: D102 Docstring missing
63: D102 Docstring missing
65:1: W391 blank line at end of file


E houveram também algumas alterações no HTML


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1648 of 1667 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.86%25-yellow.svg)


saw approval from SimonSapin
at https://github.com/Ms2ger/servo/commit/8b7663b9a256a9d3cddcecd2bd288b5a6ee35aee


merging Ms2ger/servo/warnings = 8b7663b9 into auto


Ms2ger/servo/warnings = 8b7663b9 merged ok, testing candidate = 12384f76


He encontrado unos problemas usando el objeto Template de esta manera.
En realidad solo se debería de crear un objeto Template por request.
Es decir:

$template = new Template();
$template->display();

Lo que hace este codigo es:

$template = new Template();
SocialManager::getSocialUserBlock(); --> este código crea a su vez otro template()
$template->display();

Voy ha enviar unas correciones para ello.


the the newly included test for increased arity fails on [MSVC 14](http://www.boost.org/development/tests/develop/developer/output/teeks99-08f-win2012R2-64on64-boost-bin-v2-libs-mpl-test-increased_arity-test-msvc-14-0-dbg-adrs-mdl-64-archt-x86-thrd-mlt.html), I'll work on a fix as soon as possible.


What is FailedToStart ultimately used for - as in, what is the intended behaviour of camus when this happens?

Looking at the code, it appears that we'll just immediately give up.  Maybe it's fine to just leave it waiting, with a status stuck on "StartingUp" or something.  We may also distinguish various "Running" states for 200 vs 500 etc -- that's if we intend on moving the running state into this runner class, which it looks like we're doing?  And ListDeploys() would just grab the current state perhaps?  (In addition to merging with other environmental information, of course - though maybe that info should be in separate data structures, and have the client decide how to present it.  I.e. here are all the tracked deploys with full status info, here are some deploys where it's just the dirs, and here's some random things I found running on ports in my range)


typo (duartion)


Good to document use of concurrent primitives, invariants etc.

(is cond only used for testing?)

Perhaps a bit overkill, but maybe status should be its own struct since it seems cond & lock are specifically guarding the status (at least we should rename them statusCond & statusLock)


Just curious, are reads of ints (I'm assuming status is ultimately an int) not atomic in go?  I know in Java they are, but longs/doubles are not (they might be read in two separate 4 byte chunks).  Or is this for a memory fence.


the code only ever WaitForStatus(Running), and the the inner if-statement with the  || r.status > Running bit, makes me think this shouldn't take a status arg


maybe run with sh -c and pass "Cmd" as a full arg - let the shell do its escaping of quotes, etc (and, conveniently, insert environment variables)

if we just use a string, and split on " " there's no way to pass args with spaces in them


Cuando se ejecuta el template ya se setea la información del usuario con la variable " _u"
$this->assign('_u', $user_info);


cmd.Process.Kill()?   (no need to find the same process?)


@bors: retry


We might like to distinguish this case from the other failed to even call cmd.Start() case.

But perhaps, should this run in parallel with the go func() Process.Wait() bit, so if it the process just crashes, we find out quickly rather than checking for a status for a process we could know has exited.  Good to fail quickly, allowing us to bump up the actual wait time for a while (or forever) in case some server is very slow to start up (fusion server is an example, because it uses crappy libs that take ~15 seconds sometimes...)

Maybe we can just have a health check routine run in parallel, moving the status through various StartingUp vs Running vs Erroring states.


If we eventually give up trying to run something, we should de-track it from the config file.


Some drawing lines in roundRect looks little bit distorted if radius less then 1 pixel.
Example: shape.graphics.drawRoundRect(0,0,400,200,0.1,0.2);
I can round it in project haxe code, would be good to have it in nme by default


I have few optimizations, please check and edit your pull request, thanks.


var CLASSES_FILENAME = /classes\d*\.dex/;


:+1: @geochik Is this ready to go? If so, please submit a pull request. If you don't know how, I can show you.


<!-- Feel free to change this text here -->


I was about write it to you when I saw you just posted a bugfix. Thanks for great support!


var DexFile = function (arrayBuffer) {
    var zip = new JSZip(arrayBuffer);

    var files = zip.file(CLASSES_FILENAME);

    //Check If contains at least one dex file
    if (files.length > 0) {
        for (var i = 0; i < files.length; i++) {
            var dv = new jDataView(files[i].asArrayBuffer());
            if (isValidDexFile(dv.getBytes(8))) {
                parseHeader(dv);
                loadStrings(dv);
                loadTypes(dv);
                loadProtos(dv);
                loadFields(dv);
                loadMethods(dv);
                loadClasses(dv);

                markInternalClasses();
            } else {
                throw "APK not compatible!";
            }
        }
    } else {
        throw "APK does not contains .dex file(s)!";
    }
};


@Gamecraafter I just use my custom version of Glype proxy on my web server. Works great except for some gui errors.


The new script is working great--I guess I passed all the checks you added!  Thank you.  I tested reading/writing/erasing a 128 byte i2c eeprom part.


for boards yaml file names, do you intend to go on template name like %vendor%_%ref%.yaml?
device yaml file naming seems ok to me if we ensure the name fits the device manual provided by the vendor

I would prefer to have:
- boards
  - %vendor%
    - %board_name%
- devices
  - %vendor%
    - %device%

to obtain something consistent and easy to browse by users.


Can you explain why the id is needed here?


Done


Yeah I noticed that. I'll update my migration to include only the indexes not made in yours.

-------- Original message --------
From: Remo Mueller <notifications@github.com>
Date: 03/20/2015 9:14 AM (GMT-05:00)
To: "myapnea/www.myapnea.org" <www.myapnea.org@noreply.github.com>
Cc: "Mankowski, Piotr W." <PMANKOWSKI@PARTNERS.ORG>
Subject: Re: [www.myapnea.org] DB indexes for common data model views (c2507a0)

It looks like this migration clashes with the earlier migration here: 8ad4600<https://github.com/myapnea/www.myapnea.org/commit/8ad46002166c67e7f9bf5f13d06f54d5a0f9ad23>

We'll have to remove one or the other on merging into a stable branch.

—
Reply to this email directly or view it on GitHub<https://github.com/myapnea/www.myapnea.org/commit/c2507a04479712caa792ee95f01c8979cc7e0e43#commitcomment-10310858>.

The information in this e-mail is intended only for the person to whom it is
addressed. If you believe this e-mail was sent to you in error and the e-mail
contains patient information, please contact the Partners Compliance HelpLine at
http://www.partners.org/complianceline . If the e-mail was sent to you in error
but does not contain patient information, please contact the sender and properly
dispose of the e-mail.


NOOO!


PSR-4 cannot be used for non-namespaced classes, except if you specify an empty prefix namespace. And empty prefix namespaces are bad for the performance of the autoloader


We're going to need to introduced more nuanced styling for h3s. These rules are affecting the site front page - library names and news cards are also rendered as h3s there. Thanks to @remlee for pointing this out. We'll discuss later today and decide what the default should be, and which should be the override.


@Aaronneyer I have no idea why, but putting parens around this (or using the { } block syntax without parens) worked.


This makes `sinon.useFakeTimers` incompatible with AMD.


Can you explain why this bit is needed. It seems the following would work just fine, and it would reduce the need for a DOM query.

```javascript
var $container = containers[settings.position];
$container.addClass(settings.theme.container_class);
$body.append($container);
```


gcc naming isn't only the arch but arch+specific vendor definitions.
usually we have -mcpu=cortex-m3|m4|m7|a5|a7|etc plus some definitions like -D__ATSAM4S16C__ for example


There are test failures here if numpy is not installed. @yellowcap, could you look at that?


@nbolton @gitscrubz Line 889 seems relevant to drag & drop. I will try it out when I get the latest nightly.


I'm not sure Speed.jl should be in this list. It was more of an experimental playground, and I don't expect to register it with the Pkg METADATA.


Esquecimento :P heheheh


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.60](http://teamcity.monogame.net/viewLog.html?buildId=5823&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


L'url de déclaration d'une typo ne suit pas la même logique que celle des tutoriel. Se serait cool si c'était harmonisé


пустой файл не нужен


This sounds like a security flaw. `$this->data` contains user-provided form data, which could contain about anything. For instance, one could just provide `$this->data['UsersLanguages']['id']` and mess with any existing row.


пустой файл тоже


79453838-AutomateSomeDocumentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (650 of 651 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.41%25-green.svg)


опять пустой файл :)


WindowRevealBug (macumber) - Win64-Windows-7-VisualStudio-12: OK (2175 of 2195 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.09%25-yellow.svg)


воу-воу :) полехче, зачем это?


зачищаем левые комменты от скаффолдинга, они только мешают


respond и format.json не нужны, мы только с html работаем


:+1: It was a poor man's structural typing.


Done


а это зачем?


Ok, thank you


а, понял - но это все лучше делать в helpers


Bueno en realidad esta parte ($this->assign('_u', $user_info))  si esta bien pues es el usuario que viene de la funcion :)


Dick


```css
@import url("./g.css?t=2009");
@import url("./h.css");
@import url("./j.css");
```

上面的结果只会匹配出 g.css 和 j.css，而 h.css 就匹配不到。


это превью не нужно


постри в задаче, похоже забыл поле АНОНС


Ah, I see.  What about _CONST? :)

Our stuff is all "public" anyway because it's one package... if this were in its own package, it'd be less of an issue.  Just that a variable like "maxRetries" could very legitimately be a variable anywhere in the code and it's hard to spot that it came from a constant in another file - maybe at least rename it to maxRunnerRetries?


этот json не нужен


тоже не нужен файл


Great, thanks!


ух, это какой-то грязный хакокостыль, не надо так или указывать прям название файла или просто подключать в основном assets файле


some tests failed:
failure: http://build.servo.org/builders/android/builds/1106


After update, file compiled.php not created


убираем


Did you mean "does not need to be"?


controller тестировать не будем, только model, lib/services, features


Bit of an ugly change. Don't pollute your commits with unrelated changes. Try to keep your changes as atomic as possible.


надо убрать


пустые тесты не нужны, их надо или писать или удалять


Done


Thanks, @adamretter, I will try this.


remove console.log


saw approval from Ms2ger
at https://github.com/gfxmonk/servo/commit/0052a27b1a1882a6b67f2f424d90a0b325480872


merging gfxmonk/servo/finalize_global = 0052a27b into auto


gfxmonk/servo/finalize_global = 0052a27b merged ok, testing candidate = 8998edb9


looks good


`graphics/coalition-pies` instead of `graphics/coalition_pies` - for consistency.


please don't use public fields. If I have seen correctly, you are using it only to get the string, so you could have a method like "public String getRegexAsString()"


@Renrhaf this doc article is already broken by design anyway: it worked before this change only if your functional test performs a single request to the app. If there is 2 requests, the second one would use a separate DB connection anyway, and so would not have changed rollbacked (and it would not see the result of the first request because of the uncommitted transaction). It might have worked in a few cases with multiple requests because of their code reinjecting the connection in the container, but this is fragile and likely to break.
Relying on a transaction wrapping the testcase to isolate tests at the DB level is not a good solution for functional tests, as it assumes you can give only partial control over the connection to your application (and things become crazy if one of your request rollbacks a transaction btw as this will impact all following requests if there is a wrapping transaction)


you can break here


Consolidate all party name stuff into one place. Ideally share between client and server code.


Headline and description here should be in the `article_header` block.


Haha, leading underscore it's not even clear if that's uppercase or lowercase :-P

Well, everything's in its own package for now, but it may not always be. It's still useful to document what is 'internal'. Also, I don't think it matters too much that a variable is a constant or a variable. It doesn't really change the meaning of the code.

As you suggest I'll rename it to maxRunnerRetries.


Thanks for the pull request. My question is, what are the disadvantages of using this in immediate mode? In what sense will this work differently? If there are no obvious drawback we can just update the code and we do not need the defines at all.


Isn't `$from` redundant? And what's that `[data-o-grid-colspan]` for?


Selector


Selector?


This will break the grid.


Not sure why, the last pull PR I submitted bumped it to commit df4ca78d21d76d5f3b7f82f018cba8134f2f59aa which is the most current. It looks like maybe it was reverted?


I'm going to add also that function "panel" inside the Display class


Firefox GTK3 builds only use system-cairo due to issues with the in tree cairo. I think Skia builds of FF are possible, but I don't think GTK3 builds can use Skia (could be wrong on the last part, it's been a while since I was looking at it).


These could do with sass nesting.


my appology, github doesn't do good job of updating comments, next time I will delete and add new one.


Most likely out of simplicity and it's a fairly cheap operation to copy the pointer, a bit more expensive to increment the ref counter though as it has to be atomic.


jeepers I really need to write up the release note.. you're too fast for me..

can you do a little text snipped on instcomp?


this causes that user set cflags get ignored, since line 13 overwrites anything that has been set in the environment

the variable ```USER_CFLAGS``` is only used once later in line 288 and doesn't have much of an effect for the actual build


Good spotting, I missed these :)


you can declare it as:
final List<Trigger....
instead of ArrayList...


79453838-AutomateSomeDocumentation (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1649 of 1667 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.92%25-yellow.svg)


Although we used Mongo as the gold standard when implementing, shouldn't we reference query as being Cloudant Query or mango / what CouchDB are calling it? @mikerhodes do you have an opinion on this?


Yes, very true. I've added a comment. RE the extra struct: it's conventional in Go to group your struct fields like this, with locks in a separate "clause" and directly next to what they are guarding.

This is a bit weird because the lock guards both status and logs, but the condition variable is only watching Status. We could lock them independently but I'm not sure that would be better.


Thanks, fixed.


Hi TC,
why you changed the whole $scope everywhere? and even you changed the code. btw could you please revert your last pushed. I will show you later. if everything is okay. then I will merge it. we should discuss beforehand.


merging


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.60](http://teamcity.monogame.net/viewLog.html?buildId=5823&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 461, ignored: 6 Build time: 00:14:22


Its become obvious I should practice more%)


You added on new line in user model but you don't modified the generators. The generators need be updated to.


Bukannya lebih baik API JS? Secara API milik JavaScript gitu.


I don't think they are specified to be so (but perhaps on a 64 bit machine they are...)

This lock/unlock is for a memory fence.


An cleaner way to write this, is:

```php
$translationFields = (array) $translationFields;
foreach ($translationFields as $translationField) {
    $query->addSelect($this->getTranslationsTable().'.'.$translationField);
}
```

Please add always the curly braces in `if` statements and loops. It is a bad practice not to and may lead to very nasty bugs.


Nice!


Wow, thanks, this feel good!


Can you also add tests?


yeah


There is a typo bug in the grid list demo source code.

the p is missing in the "px"

<md-grid-list
        md-cols-sm="1" md-cols-md="2" md-cols-gt-md="6"
        md-row-height-gt-md="1:1" md-row-height="2:2"
        md-gutter="12x" md-gutter-gt-sm="8px" >

![error-grid-demo](https://cloud.githubusercontent.com/assets/11573362/6752888/dd29e71a-cf37-11e4-9145-76548e0fa838.jpg)


I guess my point is not so much about strong impossibility. RowUpdateBuilder is not used for user queries, it's a helper for internal queries that change a row. And for that, we definitively don't want to both delete and insert, and I think it's nice to have the API make it hard to do the wrong thing. At the end of the day, it doesn't make a whole lot of sense to me to have both the static variant and the non static variant, so I'd much rather not add it.


@davidheyman You didn't miss anything. The type check was needed until a later commit where I wrote more code to handle null values from the server. The final result should have been what you ended up with.


Eu tentei subir mas não tenho os dados atualizados, pedi para eles. Sobre validar, eu nem sei do que se trata e como foi resolvido :(, mas vou subir e se der pau reporto.


Just to nit-pick, I think you mean in your commit message "update skill match pct method to prevent zero divisor"


Hey, good point. The caller can easily just loop the check which is much more flexible.

Also, we don't need to loop on the cond check, because we want to proceed when any state change is made.


retest this please


Mas @yaditya, ini semua perubahannya ya. Saya kasih izin collaborator dulu karena interpretasi mas lebih bagus daripada terjemahan saya yang kasar ini. Mohon bantuannya :)


Yes!!! Thank you so much for this :-)


Done


Instead of using `x_deaths_from_header(Array)`, you could use a pattern matching in the case clause:
```erlang
case x_death_header(Headers) of
    % ...
    {?X_DEATH_HEADER, array, Table} ->
        XDeaths = rabbit_misc:sort_field_table([{table, Info} |
                                                [XD || XD <- Table,
```


With that, when adding a new notification, previous animations are triggered again


1: M110 missing component name


This line could be moved to the `Array` case clause as it is only useful there.


[![The Fighter of the Spirit](http://api.artsmia.org/images/1366/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1366)


[![Tahkt-I-Sulayman Variation II](http://api.artsmia.org/images/1704/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1704)


[![Chinese Rock Garden](http://api.artsmia.org/images/31068/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31068)


[![Black Moonlight](http://api.artsmia.org/images/65021/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=65021)


[![Iris Awakening Hypnos (Ending Night)](http://api.artsmia.org/images/120122/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120122)


[![Aurora (Morning)](http://api.artsmia.org/images/120123/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120123)


[![Apollo at the Zenith (Noon)](http://api.artsmia.org/images/120124/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120124)


[![Apollo Descending (Evening)](http://api.artsmia.org/images/120125/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120125)


[![Endymion and Diana (Early Night)](http://api.artsmia.org/images/120126/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120126)


[![Sacrifice to Diana (Midnight)](http://api.artsmia.org/images/120127/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120127)


[![Morning Girl Reading a Letter](http://api.artsmia.org/images/120730/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120730)


[!["Elephant and Three Clowns on Tub" mechanical bank](http://api.artsmia.org/images/80418/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=80418)


[!["Chief Big Moon" mechanical bank](http://api.artsmia.org/images/80420/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=80420)


[!["Bismark [sic] Bank" mechanical bank](http://api.artsmia.org/images/80441/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=80441)


[!["Hoop-La Bank" mechanical bank](http://api.artsmia.org/images/80763/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=80763)


[!["Trick Dog, Six-Part Base" mechanical bank](http://api.artsmia.org/images/80765/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=80765)


[!["Hen and Chick" mechanical bank](http://api.artsmia.org/images/80916/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=80916)


[!["Acrobat" mechanical bank](http://api.artsmia.org/images/81089/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81089)


[!["Uncle Sam" mechanical bank](http://api.artsmia.org/images/81095/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81095)


[!["Eagle and Eaglets" or "American Eagle" mechanical bank](http://api.artsmia.org/images/81102/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81102)


[!["Creedmoor" mechanical bank](http://api.artsmia.org/images/81104/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81104)


[!["Monkey with Tray" or "Monkey, Automatic" mechanical bank](http://api.artsmia.org/images/81107/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81107)


[!["Lion and Two Monkeys" mechanical bank](http://api.artsmia.org/images/81111/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81111)


[!["Teddy and the Bear" mechanical bank](http://api.artsmia.org/images/81115/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81115)


[!["Professor Pug Frog's Great Bicycle Feat" mechanical bank](http://api.artsmia.org/images/81134/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81134)


[!["Girl Skipping Rope" mechanical bank](http://api.artsmia.org/images/81138/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81138)


[!["Clown, Harlequin and Columbine" mechanical bank](http://api.artsmia.org/images/81144/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81144)


[!["Bull Dog Bank" mechanical bank](http://api.artsmia.org/images/81328/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81328)


[!["Flatiron Building Bank, Large" still bank](http://api.artsmia.org/images/81400/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81400)


[!["Springing Cat" mechanical bank](http://api.artsmia.org/images/81604/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81604)


[!["Commonwealth Three-Coin Registering and Savings Bank" still bank](http://api.artsmia.org/images/81626/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81626)


[!["Owl, Turns Head" mechanical bank](http://api.artsmia.org/images/81634/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81634)


[!["U.S. Tank" still bank](http://api.artsmia.org/images/81743/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81743)


[!["Fidelity Trust Vault with Little Lord Fauntleroy" still bank](http://api.artsmia.org/images/81757/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81757)


[!["Frog Bank" (or "Two Frogs") mechanical bank](http://api.artsmia.org/images/81863/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81863)


[!["Frog on Round Base"](http://api.artsmia.org/images/81866/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81866)


[!["Tammany Bank" or "Little Fat Man" mechanical bank](http://api.artsmia.org/images/81890/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81890)


[!["Humpty Dumpty" mechanical bank](http://api.artsmia.org/images/81960/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81960)


[!["Independence Hall Tower" semi-mechanical bank](http://api.artsmia.org/images/81983/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=81983)


[!["Lindy Bank" still bank](http://api.artsmia.org/images/82108/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=82108)


[!["Sputnik Bank" still bank](http://api.artsmia.org/images/82718/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=82718)


[!["Columbia" still bank](http://api.artsmia.org/images/83684/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=83684)


[!["Tower Bank" safe still bank](http://api.artsmia.org/images/83685/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=83685)


[!["Hall's Excelsior" or "Cashier Bank" mechanical bank](http://api.artsmia.org/images/83706/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=83706)


[!["Bank of America Cash Drawer (registering)" still bank](http://api.artsmia.org/images/90098/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90098)


[!["Japanese Safe" still bank](http://api.artsmia.org/images/90129/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90129)


[!["Security Safe Deposit" still bank](http://api.artsmia.org/images/90193/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90193)


[![12-room dollhouse with dolls and furniture](http://api.artsmia.org/images/118536/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=118536)


[![Bleached Bone Reef](http://api.artsmia.org/images/120152/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120152)


[![Head of the Buddha](http://api.artsmia.org/images/560/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=560)


[![Bodhisattva, one of a pair](http://api.artsmia.org/images/646/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=646)


[![Presentation Hanging for an Eightieth Birthday](http://api.artsmia.org/images/661/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=661)


[![Maitreya (The Buddha of the Future)](http://api.artsmia.org/images/724/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=724)


[![The Bodhisattva Guanyin and Flying Apsaras](http://api.artsmia.org/images/807/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=807)


[![Udhyana Buddha](http://api.artsmia.org/images/1373/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1373)


[![Figure of a Monk](http://api.artsmia.org/images/1473/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1473)


[![Eighteen Arhats (åå«ç¾æ¼¢åå·)](http://api.artsmia.org/images/4565/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4565)


[![Chakrasamvara Embracing Vajravarahi](http://api.artsmia.org/images/5240/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5240)


[![The Bodhisattva Kuan-yin](http://api.artsmia.org/images/5424/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5424)


[![The Bodhisattva Guanyin](http://api.artsmia.org/images/5788/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5788)


[![The Bodhisattva Avalokitesvara](http://api.artsmia.org/images/5808/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5808)


[![Exalted Gathering in the Green Woods](http://api.artsmia.org/images/9332/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9332)


[![Ritual Buddhist Bottle Vase and Cover](http://api.artsmia.org/images/9719/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9719)


[![Ritual Buddhist Basin](http://api.artsmia.org/images/9720/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=9720)


[![Bodhisattva, one of a pair](http://api.artsmia.org/images/11983/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11983)


[![Standing Buddha](http://api.artsmia.org/images/12948/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=12948)


[![Head of a Crowned Bodhisattva](http://api.artsmia.org/images/13718/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=13718)


[![Flying Apsaras](http://api.artsmia.org/images/17458/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=17458)


[![Flying Apsaras](http://api.artsmia.org/images/17462/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=17462)


[![Figure of Bodhisattvas, one of a pair](http://api.artsmia.org/images/29581/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=29581)


[![Figure of Bodhisattvas, one of a pair](http://api.artsmia.org/images/29582/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=29582)


[![The Monk Ananda](http://api.artsmia.org/images/30633/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=30633)


[![Imperial Candlestick](http://api.artsmia.org/images/31166/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31166)


[![Imperial Candlestick](http://api.artsmia.org/images/31167/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31167)


[![Benediction Scene](http://api.artsmia.org/images/31223/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31223)


[![Farewell to Hua Yun](http://api.artsmia.org/images/31225/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31225)


[![Buddhist Reliquary](http://api.artsmia.org/images/31226/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31226)


[![Seated Guanyin](http://api.artsmia.org/images/32122/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=32122)


[![Stone Rubbing of the Five Hundred Arhats (Wu-pai Lo-han ying ch'en tu)](http://api.artsmia.org/images/33630/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33630)


[![The Eighteen Lohans](http://api.artsmia.org/images/45524/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=45524)


[![Stele of Maitreya Buddha](http://api.artsmia.org/images/61570/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=61570)


[![Buddhist Ritual Water Bottle (Kundika)](http://api.artsmia.org/images/61724/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=61724)


[![The Pleasure of Fishes](http://api.artsmia.org/images/62754/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=62754)


[![Spherical Censer](http://api.artsmia.org/images/63346/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63346)


[![Buddhist trinity of Vairocana, Maitreya and Samantabhadra](http://api.artsmia.org/images/83514/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=83514)


[![Covered Incense Burner](http://api.artsmia.org/images/90694/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90694)


[![Buddhist Long-handled Censer](http://api.artsmia.org/images/92368/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=92368)


[![Votive stele](http://api.artsmia.org/images/99734/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=99734)


[![Dvarapala (Guardian Figure)](http://api.artsmia.org/images/100842/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=100842)


[![Leaves from the Album "Three Friends of Winter"](http://api.artsmia.org/images/106533/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106533)


[![Leaf from album "Three Friends of Winter"](http://api.artsmia.org/images/106534/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106534)


[![Leaf from album "Three Friends of Winter"](http://api.artsmia.org/images/106535/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106535)


[![Leaf from album "Three Friends of Winter"](http://api.artsmia.org/images/106536/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106536)


[![Leaf from album "Three Friends of Winter"](http://api.artsmia.org/images/106537/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106537)


[![Album of miniature landscape paintings, from a double album set](http://api.artsmia.org/images/108703/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=108703)


[![Album leaf](http://api.artsmia.org/images/116140/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116140)


[![Album leaf](http://api.artsmia.org/images/116141/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116141)


[![Album leaf](http://api.artsmia.org/images/116142/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116142)


[![Album leaf](http://api.artsmia.org/images/116143/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116143)


[![Vase with the Eight Taoist Immortals](http://api.artsmia.org/images/157/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=157)


[![Ink tablet in the form of a turtle](http://api.artsmia.org/images/513/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=513)


[![Fan Painting of a Taoist Magician](http://api.artsmia.org/images/5048/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5048)


[![Kâuei-hsing (God of Literature)](http://api.artsmia.org/images/5798/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5798)


[![Official Taoist Seal](http://api.artsmia.org/images/11862/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11862)


[![Generals Who Died for their Country and Officials of Former Times](http://api.artsmia.org/images/31143/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31143)


[![Recessed-leg Altar Table](http://api.artsmia.org/images/31168/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=31168)


[![Nymph of the Luo River](http://api.artsmia.org/images/33126/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33126)


[![The Marvelous Words of the Supreme Jade Emperor (Kao-shang yu-huang pen-hsing chi-ching)](http://api.artsmia.org/images/33827/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33827)


[![Money Tree](http://api.artsmia.org/images/46241/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46241)


[![Immortals Beneath the Pine Tree](http://api.artsmia.org/images/46877/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46877)


[![Two-piece Candlestick, one of a pair](http://api.artsmia.org/images/64422/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=64422)


[![Two-piece Candlestick, one of a pair](http://api.artsmia.org/images/64423/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=64423)


[![Taoist Stele of Five Deities](http://api.artsmia.org/images/64878/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=64878)


[![Celestial Worthy of Primordial Beginning](http://api.artsmia.org/images/68565/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=68565)


[![Chen-Wu, The Taoist Deity of the North](http://api.artsmia.org/images/82959/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=82959)


[![Numinous Treasure Emissaries](http://api.artsmia.org/images/91031/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91031)


[![The Exalted Emperors and The Gods of the Five Directions](http://api.artsmia.org/images/91032/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91032)


[![Image of a Celestial Worthy](http://api.artsmia.org/images/99452/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=99452)


[![Portrait of Wang Shimin](http://api.artsmia.org/images/5122/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5122)