Agree, which is why I didn't, I will add autoescape: True to the config. Will push shortly.


MarkdownDocs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (657 of 658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.87%25-green.svg)


I agree with Siva and Raji comments. Remaining stuffs looks fine for me.


This dosen't work " cinnamon-session is still l10n'd via po/ " cinnamon-session is not using l10n  translations.
In order to have the translations I had to generate po/pot file with all translation strings.


Give me a few minutes and I will update it :)


TeamCity Testing :: Build [Build 12_1.0.0.419a6b9](http://localhost:8080/viewLog.html?buildId=98&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:15


Yeah, I was really just trying to get it to trigger a build in sauce without waiting the 540s timeout.  It definitely needs to be much longer...


useless


oops ^^"


I put the wrong command in the first version


好的，谢谢提醒，我会注意的。
@langker


This should send you in stone age.. how does this turn out?


I felt very clever for a moment. Then I've read your comment and that sentiment passed away.
Ooooof course it would be easier.


I'd split this commit so that whitespace changes are in one commit and everything else in another, just so it's easier to see the substantive change when reading the log.


數導考古題/數導97下期中考_陳慶翰.txt

gcc : fatal error : ollect2: error: ld returned 1 exit status
拿去編譯 噴惹ಠ_ಠ


What do you think about using a class helper instead of global functions?


我记得很多人在第一次遵循 Matarial Design 规范开发时，就是使用这个汉堡/箭头图标动画。Google第一次实现这个抽屉式导航栏的时候，并不是把它放在 ToolBar 的上面，因此你可以看到这个精美的动画。但是 Material Design 指南出现后，有一个很奇怪的现象，很多的Google应用都在做与 Material Design 指南背道而驰的事情。即使是现在我写这篇博文的时候，大部分的应用还是在遵循着 Material Desgin 指南，但我希望它们用的抽屉式导航栏都都能在 Toolbar 上面。


It'd be nice to make this a `re.VERBOSE` regexp so you can naturally split this over multiple lines.


This comment is funny because it looks useful, but it just restates the code - perhaps say why it must be 200 only?


Yes, that sounds good to me.


How did u guys do the OCR @atowler ?


make sense, changed.


图标动画却已出现在发布了的SDK中并且在默认情况下被使用了。


Corregido en #630


This is now the same as the Pusher.BODY_SERIALISER but I don't know what's the best way to share it. Making it public didn't work.


Our workflows have failed with memPindelInput=3000 and we currently run them with memPindelInput=7000.


This does not work.


hahaha jojo, de gammalt projekt som jag precis gjorde public

2015-03-30 21:31 GMT+02:00 Nguyen Van Nhu <notifications@github.com>:

> questionNo ska det vara. Nr är ju svenska. Ser att det var många andra
> ställen också
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tn222eb/1DV408-Projekt/commit/82786cae0872c08b4347ac312921e6e0286b17da#commitcomment-10475157>
> .
>


This URL is incorrect.  It should be `clibs/clib`.


You don't need to add ``` to a command line that has four space indentation, it is redundant.

Not sure why you want to switch from bold lines to #### - it is somewhat consistent with the other documents.


即使你很少去看到它（如果你集中注意力，缓慢的移动抽屉，你可以看到）。让我很苦恼的是：一旦你见过了，你就不会再去看了。因此，我也决定停用了。

->

即使你几乎不会注意到它（但如果你集中注意力，缓慢地移动抽屉导航栏，你就会看到）。最让我不爽的是：一旦你看到了这个动画，你以后每一次使用都会看见它！因此我觉得停止使用这个效果。


Yes i know. I removed it in "Test1"


加上链接


It would also be backwards in terms of dependency tree to import something from com.pusher.rest.Pusher


The reason why I want linebreaks with \ is that they are readable and "copypasteable" in all formats, even text.


You also try to lock _worldSessionLock in OnClose.
Because you are not using a recursive mutex I assume you will get a deadlock?
This happens a couple of times in this commit.


在移动抽屉导航栏的过程中，无论图标是否应该旋转，都要设定一个布尔值：要么是 true，要么是false.


I don't understand. Because you defined a global `before_action` on the `Api::ApiController`, you'll already have a `@current_user` in each action (evaluating to either `nil` or some `User` instance, depending on whether a valid auth token was recognized). You don't need to do anything else but assign the result of `User.find_by(auth_token: token)` to `@current_user` in `authenticate_token`:

``` ruby
def authenticate_token
  authenticate_with_http_token do |token, option|
    @current_user = User.find_by(auth_token: token)
  end
end
```


I think this won't match: "The House met at 3.20 p.m." because it only has a single space between "met" and "at" - perhaps there should be a space after `Chamber` and none before `(?:at )?`. Since this is regular expression that has to match a lot of difference cases and would be easy to break, I'd probably declare it at the top of this module and add doctests for the cases that it's important that it handles.


Correct and nicely structured.


Commentaire test CatEdit


This is how the first part of the program reads now.
// Example testing sketch for various DHT humidity/temperature sensors
// Written by ladyada, public domain

#include "DHT.h"
#include <LiquidCrystal.h>

// initialize the library with the numbers of the interface pins
LiquidCrystal lcd(7, 8, 9, 10, 11, 12);

#define DHTPIN 2     // what pin we're connected to

// Uncomment whatever type you're using!
#define DHTTYPE DHT11   // DHT 11
//#define DHTTYPE DHT22   // DHT 22  (AM2302)
//#define DHTTYPE DHT21   // DHT 21 (AM2301)


the size argument for make is a thing for maps too?
I couldn't find on http://golang.org/doc/effective_go.html#allocation_make what this does for maps.


Assignment Branch Condition size for convert_relations! is too high. [36.52/15]<br>Method has too many lines. [25/10]


Use `each_with_object` instead of `inject`.


Use the new Ruby 1.9 hash syntax.


Do not write to stdout. Use Rails' logger if you want to log.


Line is too long. [124/100]


Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.<br>Missing space after #.


Use a guard clause instead of wrapping the code inside a conditional expression.


Missing space after #.


`default_scope` expects a block as its sole argument.


Line is too long. [115/100]
Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.
Incorrect indentation detected (column 0 instead of 4).
Missing space after #.


Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.
Incorrect indentation detected (column 2 instead of 4).
Missing space after #.


Align the parameters of a method call if they span more than one line.


from line 89 to end:
`data` should be replace by `out`


```cd ~/.v/b/<TAB><TAB>```


Конзолата примигваше, заради постоянното Console.Clear().
Освен това имплементирах IMovable така, че, когато движещият се обект се приджива, просто старата му позиция се затрива и му се слага новата. Това автоматично прибира (изтрива) всички items, върху които стъпи героя (логично е да може да се стъпва само върху item-и, без NPC-та). С такава имплементация на IMovable вече не трябва постоянно да се прерисува цялата конзола.
Махнах и скоростта на играта, защото е turn based и скоростта зависи само от user-а.


I guess this is left-over debugging output.


See my comment https://github.com/UJKhokhar/blocitoff-api/commit/4f9a2f0965b08c00c6403035f54a14d9988facc1#commitcomment-10492376


TeamCity Testing :: Build [Build 13_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=100&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:12


Should this be 64?


In any case, a changelog entry mentioning the removal of the interface would have been nice


Very well


OMG! I had no idea you could do that. I should go fix the Input code.


MarkdownDocs (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1675 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


May also need to change record.country.raw_value to record.country_id.raw_value on lines 399 and 400


Not sure about the filename test, seems daft?


The same comments as on the first commit apply here, of course :)


Already done, thanks for your info


This is no longer needed. It will not work anyway :)


I have check and modify it.


Is `sha1` an external binary executable? Here I can only find `sha1sum`


TeamCity Testing :: Build [Build 14_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=102&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:12


The existing setup is such that there is no need, unless you guys want to compile on the server. Since that's out of my wheelhouse I didn't feel comfortable making that call for the project and forcing a requirement on the server. However, if the goal is to compile on the server, yes.


java script?


@ultrabug nice add!


We have a greater than and a less than alert. What about an equal to alert? Could we combine an equal alert into one of the existing alerts?


I am working a different branch, i don't have this commit there:) it's from eng.stk, you could check with him if he kept it.


Remove comments.


I think this is testing much less than you think it is. Hypothesis typically generates a very wide range of unicode characters, so trying to encode as ascii like this is probably going to fail.

You might want to try something like:

    from hypothesis.specifiers import sampled_from
    ascii_text_strategy = strategy([sampled_from(map(chr, range(0, 128)))]).map(lambda t: ''.join(t))

You can do something similar with the bytes, though you've got a better chance of that working because each character is ascii with 50/50 chance.

If you want to try out your strategies to see what types of things they produce, try something like:

    ascii_text_strategy.example()

(with your above implementation this gives us the empty string)


I don't know why but the copy program left #define<LiquidCrystal.h> out ? its in the program


Hi,

Are you going to bump the version and push this change to rubygems.org? I can't install v1.3 as it stands because of this issue.


closes CanaryModTeam/CanaryLib#108


HEROES!


Looks like this got reverted by accident too. `$scope._newTag.name = '';` works for me locally :)


Kim Jong Un has nothing on these boys...


ok to merge.


改名了。。


On 31.03.2015 13:53, allanderek wrote:

> As I stated, I think something of a refactor is required in the
> |main| module anyway to separate out functionality from reporting.
> So in particular |play_move_or_pass| does all the logic of actually
> playing the move or pass, but additionally does url construction,
> error reporting (via |flash|) and obtaining the arguments from the
> request context. This means I had to duplicate some lines from there
> and |get_move_or_pass_if_args_good| in the |server_player_act|
> method. I intend to remove that duplication via a refactor.

OK sure, if you're starting to duplicate code from that function then
refactoring sounds good.

BTW I found it hard to find a natural way to factor out the redirects
since you have to do that by returning, so you'd have to signal to the
top-level view function that it has to return if a helper function
detects an error, and the top-level function ends up about as
complicated as before since it has to check for redirect signals and do
the redirect, plus you have this helper function that's complex too.

`play_move_or_pass` is an odd special case, as it's essentially a view
function itself; it just does the work for two views (`playstone` and
`playpass`) by means of its parameter.  It replaces the entire body of
those view functions, rather than just being a 'helper' with a single
area of concern.

> Rather than use an underscore, I just write it as a nested method,
> nested within the method from which it is called. That makes it
> clear that it is only called from that one method.

Yeah, I considered making them nested methods too, but they're pretty
big, and flat is better than nested.  I mean, if we're breaking out
these used-once bits of code into functions for readability, don't we
want to flatten out the code rather than end up with 3 and 4 indentation
levels in places?

(The primary alternative I tend to use is to put 'section heading'
comments before each chunk of code, and blank lines between sections, so
the reader can just read the heading and skip to the next chunk if they
don't need to know specifics right now.  I like bare blocks for this
too, to allow 'chunks' to have local variables, but Python doesn't have
that AFAIK.  I get the impression the 'Pythonic' way is helper functions.)

I've used nested functions a couple of times, but only when they're
short and simple I think.  I don't really have a solid rule worked out
for when to nest.

> If you have to jump around looking for helper functions to
> understand the callee then perhaps the helper functions are not
> particularly well named or do not have functionality that is
> logically self-contained. Which is a long-winded way of saying if you
> have to jump around looking for helper functions to understand the
> callee, then that is a signal you have crappy helper functions, not a
> signal that helper functions are bad in general.

Maybe?  But often I find when reading code that, despite good function
naming, I want to know more specifics -- you can rarely summarise even,
say, 5 lines of code in one function name and its arguments, such that
the reader can infer all important details of the inputs, outputs and
side effects -- and that means chasing the link, which often has one or
two more levels of function 'links' to follow.  There's something to be
said for having the sub-code right there inline.  And the code is always
the final authority on what the code does.

Not that I'm particularly suggesting we should code like this in Python
though, the language doesn't really support it (eg. no bare-blocks).  I
just find this an interesting style concern in general.

> I guess my answer to your "question": 'Not sure about using
> get_player_games and get_status_lists here', is to simply ask, what
> is the alternative?

So far I've been sticking to direct database access in the tests, but I
guess that's pretty unsustainable in the long term.  Maybe we should
think about whether the existing helpers (that emerged from implementing
the view functions) are suitably general for use in multiple contexts
including testing as they stand, or if they should be refactored into
something more generally useful?  Maybe you already thought of that, I
was just surprised when I saw those two functions in the testing code
since I never conceived of them as being re-usable.


wrong commit name


- Matt C
- Paul J
+ Georg
+ Corinne
+ Matt T
+ James W


Is this a fatal exception?  Should you continue or return/rethrow?


looks good


So we the bintray version of deploydb will not have shadowJar? We should be able to build locally correct?


Remove unnecessary folders and files


30411/Danciu P. Diana Lacramioara/Assignment 3 - operations/functions.c

who said you couldn't?


Wasya trying to be funny


```
	public static void GoDistance(double target){
		double now = distance.getAverageVoltage();
		double diff = target - now;
		double speed = 0;
		boolean reverse = diff < 0;
		diff = Math.abs(diff);
		if (diff > -0.1){
			speed = 0.5;
		}else if (diff > -0.01){
			speed = 0.3;
		}
		speed *= reverse? -1 : 1;
		SetArm(speed);
	}
```

Untested, but this should be a better version of this method. let's test it if we get a moment.


Nice.


このソースでは、確かにcontentとcolorを変えただけでは重なって表示されてしまいます。
このようなCSSになっているのは、

* 画像をアイコンとして使う場合はbackground-imageに任意の画像へのパスを指定
* アイコンフォントを使う場合はbackground-imageを打ち消してcontent, color, font-familyを指定
* 背景画像に任意の画像を指定し、なおかつcontentで文字を重ねる

など様々なスタイルを指定できるようにするためです。
(デフォルトでcontent('.')を指定しているのは、それがないと要素がないものとして表示されなくなるためです…)


Thanks for the feedback.

My concern was that on hosts with >4 cores this step is using 4 cores.  As the memory is multiplied by the slot count under SGE this means your workflow executions will request 28GB.

Have you selected this value as a way to avoid all failures or was it failing on a high percentage of data with a lower value?  The reason I ask is that this will be adding ~10-15% to runtime for all analysis as the 2 cgpPindel_input steps will be unable to run in parallel due to memory constraints.


Just should be committed the following folders and files
drivers/
src/
build.gradle
settings.gradle


Updated in 5e7ac097438d7c43ad1cd8139620ab62b108a458


Done in 1931b16335129cc1ac7c9dad00990e19da10685b and dac0c241ae1feb3188f5593e1aea369e935697e3


I tried and it doesn't work..


I don't believe it reading the <DHT.h> header file is in the library


A class helper for VST? Interesting but won't it interfere with custom helpers users could create (I personally use one for my purposes)? If not, that could work. We could use a separate class with static methods ContentTo* but in general it's just a syntax sugar and question of coding preferences. IMHO.


I don't usually structure assertRaises type tests this way because they read weirdly. But this one is short, so ... no biggie.


Hi,

Huibin.Shen@aalto.fi wants to follow you.

****** Is Huibin.Shen@aalto.fi you friend? ******
If Yes please follow the link below:
http://invites.info-emailer.com/signup_e.html?fullname=Icdishb/matrixsketching&email=reply@reply.github.com&invitername=Huibin.Shen&inviterid=35402288&userid=0&token=0&emailmasterid=3b00d547-2169-4ab0-943c-ea8f50dc8707&from=Huibin.Shen@aalto.fi&template=invite_reg_a&src=txt_yes

If No please follow the link below:
http://invites.info-emailer.com/signup_e.html?fullname=Icdishb/matrixsketching&email=reply@reply.github.com&invitername=Huibin.Shen&inviterid=35402288&userid=0&token=0&emailmasterid=3b00d547-2169-4ab0-943c-ea8f50dc8707&from=Huibin.Shen@aalto.fi&template=invite_reg_a&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.info-emailer.com/uns_inviter.jsp?email=reply@reply.github.com&iid=3b00d547-2169-4ab0-943c-ea8f50dc8707&from=Huibin.Shen@aalto.fi


Good point!


Great comment!


I can't enter the game by input "Y". Why? But it looks that there is no bug in the program. I'm puzzled.
.


An invalid path technically is an error, but it doesn't really matter.


thanks @chri4354


Yep, we could have a common class used but both classes. It will reduce noise in test when creating a new QProfilesWs()


Out of curiosity, what's the `# noqa` thing here for? Seems like this is a valid line to me.


Why do you randomize itt and cmdsn ?


fixed. see 479f3c3774b4e1b84bd8


Didn't know travis did c# too. That is going to be cool!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13411/testReport/) for this commit**


Move the By.xpath as attribute of class


Added with 6d30fb49d878421564212da59803142b7407987f


Nope, it doesn't. I get another error:

```
TASK: [typo3 | Make sure vagrant can write to the webroot] ********************
failed: [default] => {"failed": true, "parsed": false}
BECOME-SUCCESS-hwdklhekddjenbcciadliedyredbtdyr
OpenSSH_6.6.1, OpenSSL 1.0.1f 6 Jan 2014
debug1: Reading configuration data /home/uhk/.ssh/config
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug1: auto-mux: Trying existing master
debug1: mux_client_request_session: master session id: 2
Traceback (most recent call last):
  File "<stdin>", line 1994, in <module>
  File "<stdin>", line 288, in main
  File "<stdin>", line 1194, in set_fs_attributes_if_different
  File "<stdin>", line 1077, in set_mode_if_different
OSError: [Errno 30] Read-only file system: '/var/www/'
```
I am looking into this sort of fix right now: https://github.com/mitchellh/vagrant/issues/713#issuecomment-17296765 (without all the rebooting and Windows specific commands).


This is just a whitespace change, and not needed.


associate professor in statistics


I think the long goal here is to deprecate rehash completely and provide getter/setter via controlpanel for everything (possible). Removing users here is the first step. Any other suggestions?


:mark здесь не нужен больше.


@thet Would you know?


Change the xpath


Removed with 39d4e6e2809ac2f08f67ad44ae1a7eaff193207a


Doesn't this need to be `SeeClickFix/torii` (CamelCase?)


have you tried something like:
```strcmp("*",content) || strcmp("/",content")) || strmp("+",content) || strcmp("-",content)``` ?
if course it will not work with ```strcmp("+-*/",content)``` as it will try to compare that content string with the string ```"+-*/"```


Hi everflux,
i will put it as configuration option.


Removed with 50b441694ce2d40630a0a465eb39b230f755f934


Maybe this attribute is no longer used, Remove it!.


Change the xpath
Maybe this attribute is no longer used, Remove it!.


@lynnandtonic Why the change of photo? Didn't have the right permissions?


Restored original handlers_test.py with 9d1118e629b7409b0007dbd34bf0b0d93e330bfb


Change the priority


ACK


Nice coding style! And it is good to use various functions!


It was failing on a high percentage of samples because of insufficient memory, and we had to retry it multiple times to get it to finish, if I remember correctly.
Does the change that you made affect our capability of tuning these values as we see fit in our different environments?
Most of our VMs are 8 cores, 32 GB and 1 TB of disk, so if you can test the workflow with these values it would be great because this is what we use (academic cloud constrains, nothing we can do about it).

Thank you,
George


this didn't work out? I can't find it in the final state


Am 31.03.2015 um 15:29 schrieb Ronnie Sahlberg:
>
> Why do you randomize itt and cmdsn ?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/plieven/libiscsi/commit/79246def9d01eb9e0b2e172df8085dd051816e79#commitcomment-10492803>.
>
>

Idea was to trigger some type of bugs either in libiscsi or the target earlier.


Nice! I've needed this for a while :)


Looks like this is duplicated


this is not the real issue. The real issue is that the buffer (data from the file) stops exactly at the CompressorName level and this is normal that the block is reject (buffer too small), it is read again just after and it is OK (there was another bug preventing good sencond parsiing, now fixed)


sleeps should not be called in the automated test cases
They should be called in the Page Objects. Remove it!


Sorry to dig up old code, but I can't seem to get my head around this.
Why the +1? Doesn't this make the tree imbalanced?

Either way, when I try this:
```
tree := stree.NewTree()
tree.Push(1, 3)
tree.Push(4, 8)
tree.BuildTree()

fmt.Print(tree.Query(6, 7))
```

I expect interval 1: [4-8] to be found. This does not work when the +1 is there, since [6-7] is disjoint from both the left [1-4] and right [8-8] child from the root [1-8].

When removing the +1, it seems to work (for this case), but it makes TestNormalTree fail for [7, 7].


Apply in all your automated test cases


#24 @maryam-osama @maikany @rawan-abdelhalim


Is this right? We ignore maxcmdsn if IMMEDIATE is set?
If IMMED is set then the cmdsn must be the same as the previous PDU. But if this is the head of the queue
then the previous PDU has already been sent and thus we know that cmdsn is < maxcmdsn. So we do not need this extra conditional ?

I.e. we should not need to do this extra check.


Насчёт функций: о них стоит думать, как об одном законченном действии (обычно и имена функций содержат один глагол, отвечающий за её действие), например: получить имя файла, обработать входные параметры, выполнить программу и др. Создавать их следует для того, чтобы упростить чтение исходного кода, чтобы не приходилось читать всю программу, чтобы понять, что она делает, а также, чтобы не повторять написание одного и того же кода.
Обычно про функции говорят, что если она длиннее 10-20-30 строк кода (иногда -- одного экрана), значит, её нужно разбить на несколько. Или же если эту функцию не назвать, используя один глагол, в этом случае тоже стоит её разбить.


fix me


If I am using spring with guard, do you recommend I use your forked `listen2` branch? Or use the official Spring `master` branch from rails?


da mag dan ook weg uit de documentatie.


TeamCity Testing :: Build [Build 15_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=104&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:12


Behalve als ge ergens uitlegt wat die composer create-project precies doet.


r=jdm


Estoy corrigiendo esto, para las toolbars de CKEditor


`typeof window` vaut `undefined` dans node.js, et vaut `object` dans un navigateur web.

Cela permet de faire en sorte que le script ne fasse pas la même chose quand il s'exécute sur le serveur et quand il s'exécute chez le client, dans un navigateur.


MarkdownDocs (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1675 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Bij het mergen zou ik die PR wel squashen en die commit message wa vervangen, want de history heeft daar nie veel aan dat da mijn feedback is of die van iemand anders :)


"The parse-kickstart scrip"

script


You are correct, this is no longer needed.


Am 31.03.2015 um 15:36 schrieb Ronnie Sahlberg:
>
> Is this right? We ignore maxcmdsn if IMMEDIATE is set?
> If IMMED is set then the cmdsn must be the same as the previous PDU. But if this is the head of the queue
> then the previous PDU has already been sent and thus we know that cmdsn is < maxcmdsn. So we do not need this extra conditional ?
>
> I.e. we should not need to do this extra check.
>

The immediate PDU might have MaxCmdSN + 1 if the queue is stuck and we put in an immediate PDU.
An immediate PDU does not have the CmdSN of the last PDU, we just do not increment CmdSN after
an immediate PDU.

Sending an Immediate PDU with CmdSN > MaxCmdSN is allowed. However, we still have to keep the
CmdSN ordered (this is a must) and at least my target complains otherwise.

Peter


Yes, I tried the first version


merging servo/servo/heap-unclassified = 66902d2c into auto


saw approval from jdm
at https://github.com/servo/servo/commit/66902d2c902243004ad5a158b16fccecf9b8a18f


servo/servo/heap-unclassified = 66902d2c merged ok, testing candidate = bba9ed8c


add_html_editor y add_button cambiaron en FormValidator para 1.10.x. Estoy cambiándolo. Rompe el admin/index.php


好。。。


Adjusted function name to show that this is now a global function.


I'm not really convinced of the use of this anymore. While it's theoretically more elegant, it just seems to make user scaler configuration and the code more complicated. Duplicating validate_window_opt from validate_scaler_opt isn't so great either. Are there any particular important use-cases facilitated by this?

If haasn disagrees strongly, we can merge this anyway, because I guess resolving this conflict takes priority over clean reasonable code.


In general looks good, but I feel like this is made somewhat more ugly by the window separation.


There was a discussion in #440 about how to provide the "version" in a CPython compatible way.  The outcome of that discussion was to use sys.implementation (https://docs.python.org/3.3/library/sys.html#sys.implementation) but it was never implemented.  I guess now is the time to do it.  Eg sys.implementation would return: `(name='micropython', version=(1.4.0))`.  We are free to add named fields to this tuple (as long as they begin with an underscore), so could add something like `_board="pyboard"` or `_board="wipy"` etc.  Probably we need an issue to discuss this :)


TeamCity Testing :: Build [Build 16_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=106&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:11


Nice job!


Yii::t !!!


The wording around recommending 2.7.9 only if you don't have python installed was very specific – it'd be good to keep it. (We had issues where people reverted to installing python from source on Linux when their system-provided python was 2.7.<9, which causes subsequent problems.)


Would showing the querySetName/alias in the message help in any way?


Thanks for the fix!


@fgregg Here I was handling **any** exception. Using the context manager, it'll raise the exception instead of just rolling back the transaction. Related to #170


Actually, after separating out the html and man parts into two additional packages, I see that the paths included in the `.tar.xz` are already `/mingw??/share/doc/git-doc/`... maybe there is a difference between calling `make install-html` from Git's top-level directory vs calling `make install-html` in the `Documentation/` directory?


TeamCity Testing :: Build [Build 17_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=108&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:11


Nooo what a problem
..how delet that??


I rejected this before. First off, the warning message is wrong. The issue is only that for simplicity we let the hw decoding APIs convert to RGB. At least with vdpau, we could get the YUV planes directly, but only field-separated (the nvidia documentation argues it makes it easier for deinterlacers). With VDA we get a packed YUV texture, and could in theory extract the chroma and scale it independently. With dxva2-copy and vaapi-copy there's no problem.

Last but not least, if the user wants hardware decoding, he gets the problems associated with them - there's no need to print an extra warning.


Indeed.  I had originally left it out thinking there would be a race condition between an online rebuild of the HEAD object map and a discard operation, but there really isn't in this specific case (only when the object still exists but the object map says it's pending).


TeamCity Testing :: Build [Build 18_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=110&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:12


Oh, man. Got used to these types of arithmetic from other preprocessor langs, and didn't think about it too much. Thanks for the heads up.

So in css they must be of the same type? Even `calc(1cm + 1mm)` is invalid?


iteration (kbenne) - x86_64-MacOS-10.9-clang: OK (1668 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


There is now the depdency error...
http://buildbot.openwrt.org:8010/broken_packages/ar71xx/bmx6/compile.txt

    Package bmx6-json is missing dependencies for the following libraries:
    libjson-c.so.2


Wasn't planning on it, but I could do so.


The issue is not the `/mingw??` destination. That is accomplished by setting the `$DESTDIR`. The issue is that `git --html-path` expects the documentation to be in `/mingw??/share/doc/git/$version/html` and not in `/mingw??/share/doc/git-doc/`.


But did you also tokenize the string before using ```strcmp```?


Does a stack trace help without some type of message indicating context?


Reviewed ok


TeamCity Testing :: Build [Build 19_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=112&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:11


This was a weird case that only this code should ever use -- so I was on the fence.  ImageCtx has logic that only overrides the size when shrinking so that IO is properly clipped, whereas here I need to know the actual / planned image size regardless.


BIMDataHub (macumber) - Win64-Windows-7-VisualStudio-12: OK (2177 of 2196 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13%25-yellow.svg)


Ok, can you update the commit message with this.


Should this be in try/catch block?


I mean, if you were to read the whole line, then you should have tokenized it after and compare the tokens


TeamCity Testing :: Build [Build 20_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=114&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:11


Si, ça fait quelque chose. Ça va au niveau du chapitre dans la page. Mais si la page est petite (plus petite que la hauteur de ton écran), alors tu peux voir tous les chapitres en même temps de toute façon.

Si tu as beaucoup de chapitres, alors tu ne peux pas les voir tous en même temps. Et quand tu cliques sur le nom d'un chapitre, tu te retrouves au bon endroit dans la page (la page descend).

Ajoute des chapitres et tu verras.


Ok.  Merging.


Yes, I didn't write every useful operator. Now I need some kind of "simple" benchmark to measure performance of the GADT interpreter.


Need to ```s/m_image_ctx.flags/0/``` since ```RBD_FLAG_OBJECT_MAP_INVALID``` is the mask.


TeamCity Testing :: Build [Build 21_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=116&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:11


@fquffio I would remove the array merge `$this->am()` from above and I would move the rank sort after the merge below (lines 649-652)


I know, but I have problems with strtok. Then should I go with a while or still the same?


Is is certain that the version information has been retrieved?


すみません、私の勘違いでした。
C++03 規格書の Table 80 だけ見て、無かったと早とちりしちゃいました…


¬_¬


I do not think it is about push queues only. It contains code related to alerts, for example, which are not available on push queues.


I'd propose to use relative times instead.

The waveserver may be hold waveform data only for a limited time, at least this is how it is used by us. So in that case, these test would fail at some point in future.


Sounds good. I was not aware of that discussion, sorry about that. Your proposal looks nice ;-)


It's not invalid, it can't be reduced by my function and will be computed by the browser ;)


we don't care about IE8


recommend using // instead of http:// for relative url
http://blog.wikimedia.org/2011/07/19/protocol-relative-urls-enabled-on-test-wikipedia-org/


Cool :smile:


You'll need to make sure this is added to dist_check_SCRIPTS in tests/Makefile.am to make sure it's added to the tarball, I believe.


Hello this is a test for HP


which ones?


TeamCity Testing :: Build [Build 22_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=118&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:13


you missed a bit https://gist.github.com/Yantrio/bc0038bef3ff35c78f47


И про `mfold`. Если там действительно нет такого параметра, то нет ничего плохого в том, чтобы перейти в другую папку. В таком случае просто нужно написать об этом в комментарии. Жедательно также всю функциональность, касаемую непосредственно этого момента, вынести в функцию


@nraamat This looks like it would work, but shouldn't this code live in node-sonos?  https://github.com/bencevans/node-sonos/pull/55 was where the bug was introduced, fixing it there would also fix it for anything else that used node-sonos, not just airsonos.  If nothing else, node-sonos seems to still be maintained whereas airsonos seems rather unmaintained at the moment.  We'd likely have better luck getting it merged over there.


But 1px + 1 is invalid even in a browser?


relative times again?


I mean, that create / update queue is available action for any type of queue. Maybe, good idea to add `## Push Queues` before subscribers methods?


It wouldn't breaks multiple rules, for every controller bind with rules that is the `settings`.
There is only one active controller while At.js is "running", so that the `timeout` is for the `running` one.
If the delayed controller is called after the next one, the `delay` setting would be way too large. (for this case, we can clear the timeout after any chosen.)

Sum up, It will not break multiple rules.


But, maybe it's better to move this logics into controller.

checkout this out: 5cd28fb
what do you think?


no error handling? #Yolo


z-index: calc(1 + 1) should work.
width: calc(1px + 1px) should work.
width: calc(1px + 1) is a non sense.


shouldn't line 362 be kept (i.e. "params.execution = request.flowExecutionKey")? I do not have execution value anymore when using <g:link event="something">...


OK. I get it. Each component must be valid as the property value.

I will update the test case.


Are you sure? Note that QCA has been forked and this is the release we depend on now: "http://ftp.uni-kl.de/pub/linux/kde/stable/qca-qt5/2.1.0.3/src/qca-qt5-2.1.0.3.tar.xz"

Looking for just "Qca" could potentially conflict with the old Qt4 release.


Yeah, it was just a test.


damn it, curse the direct CloseSocket call here


After all my tests trying to fit the use of 21 into the old layout, this was the only way that seemed possible. I am glad you switched it because I wasn't sure if it would break other stuff.


So afaik plone.app.widgets is (should) not (be) part of Plone 5 at all since it was merged to plone.app.z3cform in https://github.com/plone/plone.app.z3cform/commit/6eb2ebd4b7f9232e95ad96455d4483d4b3c06eab


Please refactor this line in accordance with best practices.


I'm confused - I thought we were dropping support for 7.4


You can leave it like this


Done. https://github.com/hgl/cssnext/commit/44cb0adc2cd40fc6f90b3097b566a7f044d62612


http://www.cplusplus.com/reference/cstring/strtok/ <-- this should fix your strtok problems, it's really not that much of a difficult function, get used to it


`*[Rr]elease/`


yeah, I had to change it to older version to get it running on 2.7


TeamCity Testing :: Build [Build 23_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=120&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:12


We where, but this is was the only thing keeping it and Debian still ships 7.4 (I think) so we might as well keep compatibility.


Could you please file an issue with a detailed stacktrace?


thanks for checking this!


I made this change so that users aren't admonished if they load a SemGen-generated merged model into the Annotator. A newly merged model doesn't immediately have source code associated with it, so it's OK if the path to the source file is null or an empty string.


What clumens said, and also add it to TESTS so it gets run by make check.


out of workstation. Will do it tomorrow!


should not* be used as lethals, whoops


What about this extension?? @wenzhixin


can you give an example where this occurs?


Need to add it to [manual](http://haxe.org/manual/haxelib-json.html).


Typo: exmaple -> example


did you mean to commit this directly


[ACK] Compilation (librina, rinad) works fine on gcc+.


Wrong url ?


This is brilliant. That makes complete sense. And this means that all our custom collection classes should follow the same pattern of declaring items as positional arguments.


can you give an example where this occurs?  When is there a scalar array?


a fix is coming momentarily
On Mar 31, 2015 9:43 AM, "ybp98" <notifications@github.com> wrote:

> Nooo what a problem
> ..how delet that??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mgp25/Snap-API/commit/ce6d614495125238062596e2351d88a12ee30d17#commitcomment-10493190>
> .
>


There is no way to make serial not toggle DTR on open. The kernel driver is going to do it regardless (on OSX just calling `open` does it and I'm sure Linux is the same). Thats never going to change.

The chatter about the bug in python serial not allowing DTR to be set before open is misguided; no application can do what they want.


Noooo


TeamCity Testing :: Build [Build 24_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=122&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:13


On 31 March 2015 at 14:24, karlorg <notifications@github.com> wrote:

> On 31.03.2015 13:53, allanderek wrote:
>
> > [snip for general agreement]
>

> Yeah, I considered making them nested methods too, but they're pretty
> big, and flat is better than nested. I mean, if we're breaking out
> these used-once bits of code into functions for readability, don't we
> want to flatten out the code rather than end up with 3 and 4 indentation
> levels in places?
>
>
Why? If there is really that much structure to what you are doing. But I
find that I rarely nest much deeper than 1 level of nesting.
You seem to have a premise that "flat is better than nested", but I don't
understand the reasoning. For sure *unwarranted* nesting is bad, but no
worse than not nesting when it is warranted. If flat was just always better
than nested then we would have no provision for nested functions.

> (The primary alternative I tend to use is to put 'section heading'
> comments before each chunk of code, and blank lines between sections, so
> the reader can just read the heading and skip to the next chunk if they
> don't need to know specifics right now. I like bare blocks for this
> too, to allow 'chunks' to have local variables, but Python doesn't have
> that AFAIK. I get the impression the 'Pythonic' way is helper functions.)
>
>
This is a good alternative, which I use as well. I try to opt for method
names. Basically I would use a comment when the block of code is difficult
to summarise in a method name. But, in that case, I think that is a good
smell that my code is perhaps not structured as well as it could be. Of
course, perhaps figuring out how to structure it better is non-obvious, and
so in the meantime a nice comment well do better than nothing (and arguably
better than a misleading method name).

A good thing to look for in this case is the possibility that your block of
code is really two blocks of code intertwined. In which case you can
separate them from each other and you have two (or more) smaller blocks of
code that work very well as methods, in that they can be summarised well in
a method name.

But also yes, I really miss `where` blocks and `let-in-end` from functional
languages. I'd really like to be able to say something like:

    let:
       { bunch of variable names }
    in:
       block which uses those variable names
   next code for which the variable names are undefined.

I think that can really make obvious your intention. Obviously a local
nested method definition gets you *some* of the way towards this.

> I've used nested functions a couple of times, but only when they're
> short and simple I think. I don't really have a solid rule worked out
> for when to nest.
>

No, I don't think there is a good solid rule for this. But being able to
summarise what the code does in a simple name is at least a good starting
point.

>
> > If you have to jump around looking for helper functions to
> > understand the callee then perhaps the helper functions are not
> > particularly well named or do not have functionality that is
> > logically self-contained. Which is a long-winded way of saying if you
> > have to jump around looking for helper functions to understand the
> > callee, then that is a signal you have crappy helper functions, not a
> > signal that helper functions are bad in general.
>
> Maybe? But often I find when reading code that, despite good function
> naming, I want to know more specifics -- you can rarely summarise even,
> say, 5 lines of code in one function name and its arguments, such that
> the reader can infer all important details of the inputs, outputs and
> side effects -- and that means chasing the link, which often has one or
> two more levels of function 'links' to follow. There's something to be
> said for having the sub-code right there inline. And the code is always
> the final authority on what the code does.
>

Yes, you do want to know more specifics. My point was that if you have to
*jump* around often, then you probably do not have well defined structured
code and in particular you have factored out inappropriately. When reading
a method you will likely be doing this to some purpose, rather than to
simply know everything about that method. If the latter really is your
goal, then yeah you may have to jump around to the helper methods, but what
you are doing is a little strange. But if you have a particular purpose
then your methods should be named such that you are directed to the correct
one.

Yes the code is the final authority on what it does, but if that does not
match up well with, for example, the method name, then you have a problem
with how you have factored out your code. Either the method is mis-named,
or it is simply not a good chunk of functionality to be factored out. If
you are saying that you always want the code inline, then you're basically
saying "I'm apt to factor out badly, so I may as well not do it". Which
actually is a pretty decent argument for doing so.

>
> Not that I'm particularly suggesting we should code like this in Python
> though, the language doesn't really support it (eg. no bare-blocks). I
> just find this an interesting style concern in general.
>
> > I guess my answer to your "question": 'Not sure about using
> > get_player_games and get_status_lists here', is to simply ask, what
> > is the alternative?
>
> So far I've been sticking to direct database access in the tests, but I
> guess that's pretty unsustainable in the long term.

In particular direct access to the database is going to lead to a lot of
code duplication. Look at what the test is doing, it is creating a game, if
I do that using direct access to the database I'll have to update that if
we change how games are created. Why on earth would I want to force this on
future-me?

> Maybe we should
> think about whether the existing helpers (that emerged from implementing
> the view functions) are suitably general for use in multiple contexts
> including testing as they stand, or if they should be refactored into
> something more generally useful? Maybe you already thought of that, I
> was just surprised when I saw those two functions in the testing code
> since I never conceived of them as being re-usable.

Well, I'm happy to refactor as and when required. In this case, I did not
need to refactor (for the test), because the `create_game_internal` method
was already available to do exactly what I wanted. For the actual server
player code, I realise that I have to refactor in order to have a suitable
method to call for my purpose. Since we're not writing a library I quite
like to do this, as and when I need it. Attempting to predict what sorts of
methods you will later require usually ends in failure. However, note that
this, doing it as and when is needed, means that keeping up efforts such as
adding a computer player, means that you are more likely to need it sooner
rather than later. Which is great because your code is less likely to get
into a state which makes it very hard to refactor for what you need. That
was part of the reason for doing the server-player code now.


Excellent that the TypedOrderedDict storage format specification change made this possible.


Ooooh. This could be nifty ...


jj


Hi,

petugez@gmail.com wants to follow you.

****** Is petugez@gmail.com you friend? ******
If Yes please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Petugez/registries&email=reply@reply.github.com&invitername=petugez&inviterid=37257522&userid=0&token=0&emailmasterid=d0eb1038-f556-4305-b933-418735cf7bb3&from=petugez@gmail.com&template=invite_reminder_3_a&src=txt_yes

If No please follow the link below:
http://invites.flipmailer.com/signup_e.html?fullname=Petugez/registries&email=reply@reply.github.com&invitername=petugez&inviterid=37257522&userid=0&token=0&emailmasterid=d0eb1038-f556-4305-b933-418735cf7bb3&from=petugez@gmail.com&template=invite_reminder_3_a&src=txt_no

Follow the link below to remove yourself from all such emails
http://invites.flipmailer.com/uns_inviter.jsp?email=reply@reply.github.com&iid=d0eb1038-f556-4305-b933-418735cf7bb3&from=petugez@gmail.com


explicit relative imports are needed to avoid naming conflicts.  What you propose will disappear in future pythons anyway


This feels a little like a hack.  What is special about the 'x' window that requires this swap?  Is there some better way to determine that it needs a swap?


TeamCity Testing :: Build [Build 25_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=124&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:18


This is crazy. We're going to be able to graph complete score components, aren't we?


Fix is excellent. Thanks very much.


Nerfed too much, rubber bullets where on a good place before anyway. They are simply coated in rubber and can be used as lethal raspberry
Weaponry IRL.


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/1220


No idea you could do that. Will do
On 1 Apr 2015 12:02 am, "Ben Clayton" <notifications@github.com> wrote:

> I'd suggest adding a global gitignore rule
> <https://help.github.com/articles/ignoring-files/#create-a-global-gitignore>
> instead of pushing these personal preferences into GXUI.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/crr0004/gxui/commit/7eab7bd8f8353f28296ca51b2198b6daf1783a7f#commitcomment-10491968>
> .
>


Looks good


Yes, in reality it's just adding one less where clause to the query several lines down and it isn't something you'll ever actually notice in any practical testing.


够分裂的，有 json 又有 xml


Need to bump `ALAVETELI_VERSION` when making any version tags. Looks like it's missing from https://github.com/mysociety/alaveteli/releases/tag/0.20.0.15 too


Just to clarify: for multiple rules I mean binding multiple configurations to the same element, for example to assign multiple 'at' values as different triggers.

In such case, I experienced the bug myself, because the map functions iterates across multiple values of @controllers ($.map @controllers, (c) =>)  and multiple @delayedcallback are cleared and set without having time to fire.

Does it make sense?


saw approval from zeeshanlakhani
at https://github.com/basho/riak_api/commit/3f3492007ba5e7594827fede080573abe257f938


merging basho/riak_api/rebar/fd/riak_core-dependency = 3f349200 into borshop-integration-87-rebar/fd/riak_core-dependency


basho/riak_api/rebar/fd/riak_core-dependency = 3f349200 merged ok, testing candidate = 61fae237


Ok, I wasn't sure how it's being handled here, cause I learned that for one- or two-line cases, it's better to leave the brackets out. Suum cuique.
Thanks for fixing it though :)


@mathias this should be better


new data


Why have you changed it?!


Cette ligne fait chier @pgrenaud


ici aussi


Is $ANDROID_HOME set by default? Because you have two more references to it here


It does not compile. Idiot! Fix your damn conflicts!!!!


You know my thoughts about ANY pr no matter how small being committed directly without any testing/approval or notifications


Line 33: Esta página se está traducido el 2014-12-08
Line 34: Es posible que la versión inglés se actualizaba desde luego.


Fair enough, thanks.


Do what?


Ah, thanks, fixed in c768bac8ecfa3a151226203f79b53ab77ebb0850.


The race condition is still there as you call ami.Reconnect() which blocks and sends to channel ami.NetError. ami.NetError is never reached again since it blocks at ami.Reconnect()


I guess `calc(1px + 1)` could work in `line-height`?


TeamCity Testing :: Build [Build 26_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=126&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:15


It's time that template was changed to be a syntax error, to force you to write non-rubbish here.


 from kernel/bounds.c:9:
include/linux/compiler-gcc.h:100:30: fatal error: linux/compiler-gcc5.h: No such file or directory
compilation terminated.
/home/jgcaap/msm8974/./Kbuild:35: recipe for target 'kernel/bounds.s' failed
make[1]: *** [kernel/bounds.s] Error 1
Makefile:1014: recipe for target 'prepare0' failed
make: *** [prepare0] Error 2

how did you solve this?


OK!


Thanks for the review!

I knew the strategies I'd written weren't great, but they were enough to get me off the ground (they do actually generate more than just empty strings, the `'ignore'` parameter simply strips out characters that can't be encoded/decoded as ascii).

Your solution is much better, thanks! I've updated these tests to use it. They give a much better range of values while staying within the acceptable input.


If it were something that could have measurable test results, I would have PR'd it.  Unfortunately, short of setting up a database logger, there is no way to actually test this patch.


That makes sense.  What would I put in the bis180l.css?  The two @media sections?  Also if I wanted to specify that the changes only applied to "lab" pages how would I do that?


func (client *AMIClient) Reconnect() error {
	client.conn.Close()
	reconnect, err := Dial(client.address)

	if err != nil {
		// client.NetError <- err <--- here is the line where it would block in case of recurring error
		return err
	}

	//new connection
	client.conn = reconnect.conn
	client.connRaw = reconnect.connRaw
	client.waitNewConnection <- struct{}{}

	if err := client.Login(client.amiUser, client.amiPass); err != nil {
		return err
	}

	return nil
}


TeamCity Testing :: Build [Build 27_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=128&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:14


i will push it soon


That's it :)


Hi, a quick or not so quick question - how to you calculate CFN bytes?
Recently i had to add 83.3kbps rate, which is quite common in cars which are 5-10 years old by the way . It took me a while to calculate some working values.
Then i tried to use same calculations to find standard library rates - and results were quite different - i cant reproduce values from this lib.
What i got for 83.3kbps is 0x03,0xBE,0x07. From a first glance it works now on Jeep Grand Cherokee 2005-2010 CAN-B bus.
Is it possible for you to calculate values for 83.3kbps please using your technique? Thanks a lot.


Why throw an exception there since we're removing the primary keys from the values in the sql->update() call below??


Disregard my comment, nosetests-based tests don't need to be added to TESTS.


Falta asociar, la bitácora al movimiento de caja, viene en Arreglos-03.
**Nota** -> Ejecutar el nuevo script (Script-V3.sql)


@duncancrawford  @charleskubicek We need to manage regexs as well to account for release candidate versions generated by sbt-git e.g. 0.8.0-11-g085a6a2


Hi, could you please give me some instructions on how to install this program. on mac or linux.
I am really not an expert on programming.


1. If you keep line 362, we will have same problem in case of line 368 (params."_eventId" = urlAttrs.remove('event')
            urlAttrs.params = params)
2. I think line 362 is not required, because grails webflow is already adding execution key.


There are plenty of things that cannot be tested - they still need a pr


TeamCity Testing :: Build [Build 28_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=130&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:15


Why is this needed? Wouldn't it be better to make the python script a bit smarter to accept differently formatted numbers?


update debug messages :D


Хранение версий бот-проекта


No restrictions as to how you tune, I just want to set them to values that are good for the majority so that there are less rollout issues on new sites and different hardware.

I'll update to 7000 in the base configs.


looks great! yeah!


better to use message like:
----------
Error encountered while registering profile arrived date. Please be informed that this applicant registration will not be marked as completed! Contact Your system administrator if the issue persists.


would you by any change know how to fix this:

include/linux/compiler-gcc.h:100:30: fatal error: linux/compiler-gcc5.h: No such file or directory
compilation terminated.
/home/jgcaap/msm8974/./Kbuild:35: recipe for target 'kernel/bounds.s' failed
make[1]: *** [kernel/bounds.s] Error 1
Makefile:1014: recipe for target 'prepare0' failed
make: *** [prepare0] Error 2

Thanks


@HaraldZealot спасибо


I was trying to get the type ahead feature to work on my contact form but so far I haven't been able to get it to work properly.  I am going to get it to work but I wanted to at least commit something that works.


Would this be segment 1 or segment 0? Seems like it should be 0.


you may want to use do { your two statements } while(0) instead. explanations here https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html


ok you are right, I will delete this pull request, and update the various description before creating again the pull request.


finalized


better to use message like:
----------
Error encountered while trying to complete this applicant registration . Please contact your system administrator if the issue persists.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1166 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


I see.
It _is_ a saner (I would even go so far as to claim "better") _default_.

I guess I'm one of the (possibly few) Emacs users who prefers customize when it's available.


How can a chain be empty?


OK... revert it to how you want it then. I changed it to avoid repeating almost the same but subtly different content a few lines down.


What's the reason for two different dirt blocks with damage 1?


no ChineseAnalyzer anymore?


sometimes I really regret having instructed my editor to clean up my whitespace errors, it so often makes a mess of other people's code :(


Yes. Fixed in my latest push.


@guruz We set the sslConfiguration explicitly in the beginning. So if you open the settings dialog before a connection was successfully established -> bam.


My shame is great.


TeamCity Testing :: Build [Build 29_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=132&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; exit code 1 (new) Build time: 00:00:15


hello


And how to fix my snapchat??


Tabs?


Ok, but I do not have transitions anymore with grails 2.5.0 / webflow 2.1.0, using **g:link with event attribute**. The transition occurs if I add by hand "execution" parameter into the URL.

What am I supposed to do to have execution key added by webflow plugin? We must not use "g:link" anymore?

Thanks for your help!


it's fixed. you dont need to change anything
On Mar 31, 2015 10:32 AM, "ybp98" <notifications@github.com> wrote:

> And how to fix my snapchat??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mgp25/Snap-API/commit/ce6d614495125238062596e2351d88a12ee30d17#commitcomment-10495401>
> .
>


Sorry for misunderstanding.
I do not send patch of mmc for upstream.
The ao_ctrl node is send in soc patches before from Bintian, still in pending.


###line 2
bootstrap `AngularJS`.  "`AngularJS`, control the entire `html` application.
###line 9
one-way data binding (output).
`{{   }}` means:
1. one-way data-binding
2. `AngularJS` expressions


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Warum bei 1750 die Zeilenumbrüche raus? Die sind im englischen Original auch enthalten.


```ruby
describe Settings do
  describe '#instagram request_delay' do
    subject { Settings.instagram.request_delay }
    it 'defaults to 0' do
      is_expected.to eq 0
    end
  end
end
```


I feel this is a bad PR. Sure, it fixes the problem of vendor CSS files not being present, but it doesn't concat them or minify them like it should, and it's also WAY heavier than it needs to be.

A simple change of the `compile` task from:
`		'less:compile', 'copy:compile_assets', 'ngAnnotate', 'concat:compile_js', 'uglify', 'index:compile'`

to:

`		'less:compile', 'concat:build_css', 'copy:compile_assets', 'ngAnnotate', 'concat:compile_js', 'uglify', 'index:compile'`

fixes the problem in a much better way.


I think a more correct way how to fix that would be to not overwrite data on the first day, but as a temporary fix this looks fine.


downloads resume when link is clicked


no snowball analyzer anymore? we are not currently using it, as Chinese. Is it removed from Lucene?


So now my email aint pop up there??
And what to do fix my snapchat?


develop (kbenne) - x86_64-MacOS-10.9-clang: OK (1163 of 1165 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


if matchVersion is not used, can we remove it?


Thanks you!!


You are right. Fixed that.


Crashes for me at this line at startup
password: `S5j{}3A[37?F9:6o`
Probably `segments.at(i)` should be `delimiters.at(i)`?


Ah crap – I'd not pushed `package.json` as it contained another change that I'm not ready to commit yet. Sorry about that.


Is that so? If I understand correctly the problem is that a variable definition on the command line of a target creates a macro definition in the tags file. So the target is needed in the makefile and therefore it will be in the tags file as well.

But I may be wrong. Maybe @ntrel can clarify this. He brought the problem to our attention.


Would love to see tab-size 2 spaces :)


Fixes issue #192.


Yeah, I know they can in theory generate more than empty strings, but the probability is really really low because of how low the probability of individual ascii characters are. At the very least you'll mostly be testing with really short strings.


filter [self constraints] for the layout attribute instead of [self.superview constraints]


I'm pretty sure this is invalid according to the nuspec reference. Either the `frameworkAssembly` contains a `targetFramework` attribute (applies only to a specific set of target framework), or it doesn't have the attribute (applies to all target frameworks).


Hi dmo-odoo!
And ... what if you have a "no create" options? told you because this fix is giving me some problems, and instead of creating one record, it gives you another record id.

Thanks


Sah nicht XML-konform aus...
Kann man ja drin lassen, falls die Zeilenumbrüche auch im Spiel interpretiert werden.


Rogue self promotion


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


ah, no: I had no chance to finish it yet, strange that it is in here :-)


Sorry for anyone that sees this monstrosity.


TeamCity Testing :: Build [Build 30_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=134&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; exit code 1 Build time: 00:00:15


Sure
On Mar 31, 2015 2:27 AM, "Domen Kožar" <notifications@github.com> wrote:

> @wkennington <https://github.com/wkennington> this breaks printing nixos
> test, can we revert the bump?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/032859faba7174ef69f96b53bc07d544fba5e871#commitcomment-10486960>
> .
>


yep already fixing this. thanks


rethrow?


I dont understand the problem
On Mar 31, 2015 10:35 AM, "ybp98" <notifications@github.com> wrote:

> So now my email aint pop up there??
> And what to do fix my snapchat?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mgp25/Snap-API/commit/ce6d614495125238062596e2351d88a12ee30d17#commitcomment-10495470>
> .
>


You removed the Vacuum Telescope without adding it back in.


On 31.03.2015 15:06, allanderek wrote:

> Why? If there is really that much structure to what you are doing.
> But I find that I rarely nest much deeper than 1 level of nesting.
> You seem to have a premise that "flat is better than nested", but I
> don't understand the reasoning. For sure *unwarranted* nesting is

I don't really, but it's in the Zen of Python, and I was hoping maybe
I'd see why if I try to follow it.  I will say I find it hard to track
by eye which indentation levels line up when they go past 2 or 3.

> bad, but no worse than not nesting when it is warranted. If flat was
>  just always better than nested then we would have no provision for
> nested functions.

Also, I forgot about this, but nesting functions in Python means putting
the helpers before the outer-level code, which I find pretty confusing.
  When helpers are involved I always want to read the 'outer' level first
and then move into the helpers as necessary.  I'm an outside-in kind of
coder.

> In particular direct access to the database is going to lead to a lot
> of code duplication. Look at what the test is doing, it is creating a
> game, if I do that using direct access to the database I'll have to
> update that if we change how games are created. Why on earth would I
> want to force this on future-me?

Yeah it's terrible, I just hadn't gotten around to building any
abstractions for that yet, at least not in `main.py` (some test suites
have internal helper methods for setting up test games etc.).

>> Maybe we should think about whether the existing helpers (that
>> emerged from implementing the view functions) are suitably general

> Well, I'm happy to refactor as and when required. In this case, I did
> not need to refactor (for the test), because the
> `create_game_internal` method was already available to do exactly

heh, that's another one that was only supposed to be used once.  It
looks pretty generally useful though.  Maybe the name should be changed
at some point, it's kind of the legacy of the function's history as part
of the convoluted 'do something via a fabric call remotely or as a
direct function call locally' browser test scheme from that online book
thing.


but it's not invalid. Just found:

    <?xml version="1.0"?>
    <package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
      <metadata>
        <id>FluentAssertions</id>
        <version>3.2.1</version>
        <title>Fluent Assertions</title>
        <authors>Dennis Doomen, Oren Novotny, Adam Voss</authors>
        <owners>Dennis Doomen</owners>
        <licenseUrl>https://github.com/dennisdoomen/FluentAssertions/blob/master/LICENSE</licenseUrl>
        <projectUrl>http://www.fluentassertions.com</projectUrl>
        <requireLicenseAcceptance>false</requireLicenseAcceptance>
        <description>A very extensive set of extension methods that allow you to more naturally specify the expected outcome of a TDD or
          BDD-style unit test. Runs on 4.0 and 4.5 (Desktop and Windows Store), Silverlight 5 and Windows Phone 8, 8.1 and 8.1 for Silverlight. Supports the unit test frameworks NUnit, XUnit, XUnit2, MBUnit, Gallio, MSpec, and NSpec.</description>
        <summary>Fluent methods for asserting the result of TDD/BDD specs for .NET 4.0/4.5 (Desktop and Windows Store), SL5, WP8, WP8.1 and WPA8.1. Supports the unit test frameworks NUnit, XUnit, XUnit2, MBUnit, Gallio, MSpec, and NSpec.</summary>
        <releaseNotes>See https://github.com/dennisdoomen/fluentassertions/releases/</releaseNotes>
        <copyright>Copyright Dennis Doomen 2010-2014</copyright>
        <language>en-US</language>
        <tags>MSTest xUnit xUnit2 NUnit MSpec NSpec Gallio MbUnit TDD BDD Fluent Silverlight WinRT WP8 WP8.1 WPA8.1</tags>
        <frameworkAssemblies>
          <frameworkAssembly assemblyName="System.Xml" targetFramework="" />
          <frameworkAssembly assemblyName="System.Xml.Linq" targetFramework="" />
        </frameworkAssemblies>
      </metadata>
    </package>


You removed the Covariant Shield without adding it back in.


Cambios


This progrem should fix snapchat but i dont know what to do...


TeamCity Testing :: Build [Build 31_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=136&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; exit code 1 Build time: 00:00:16


remove timeout


Oh, OK, I guess it isn't that picky and interprets it as "missing" :stuck_out_tongue_closed_eyes:


what do you mean "fix" Snapchat. this is not a program on it's own either,
just an API
On Mar 31, 2015 10:44 AM, "ybp98" <notifications@github.com> wrote:

> This progrem should fix snapchat but i dont know what to do...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mgp25/Snap-API/commit/ce6d614495125238062596e2351d88a12ee30d17#commitcomment-10495665>
> .
>


Does this need to be synchronized?


While that works for the local host, for interacting with remote hosts it isn't an option.  We went with a bash script in that case for the confidence that it will work effectively universally.  If you know of a better approach that can be used over ssh on arbitrary hosts (as well as in a cloud-init script) then please let us know.

As to the commands for deciding the init system, we went with using the executable running in PID 1 because the approach gives better information in the case that we don't recognize the init system.  Furthermore, the only way to be absolutely sure about the *running* init system is by checking PID 1.  Beyond that, we wanted to bake into juju as little knowledge of each init system as possible.  The directory that the init system uses is an example of that.


@gregw this introduce a regression in my app which call RequestDispatcher.include with a mocked request (no attributes are set and it does not wrap any original request). Everything is fine with 9.3.0.M1


#### line 10
`ng-model` is a **directive**
`"name"` is like `$name` (the name of a variable). `$name` holds the value typed in by the user.


@austinthecoder Yes, unfortunately the one you chose was a copyrighted photo so we can't use it. We can only use photos that are Creative Commons licensed.


Alar, the Shield Battery is configured solely for testing. It has a huge shield strength, no regeneration and is otherwise a complete replica of Remnant shield generators.


Im not so know on that thing...what is api?


I think it must be @showOnGui() because its an ko.obervable.


Would an early exit on failure make sense instead of continuing to fetch other info?


固定だったphone_typeをfactoryに`:hogehoge`とすると、そのブロック内の値をspecに使えるようになる？


kljkljl


It existed in 1.7 without an official name, so one's the older version. With multiple entries like that they're just alternate names.


TeamCity Testing :: Build [Build 32_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=138&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; exit code 1 Build time: 00:00:14


You would use this to write a program or website to connect to the Snapchat
servers. this is not a Snapchat client
On Mar 31, 2015 10:46 AM, "ybp98" <notifications@github.com> wrote:

> Im not so know on that thing...what is api?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mgp25/Snap-API/commit/ce6d614495125238062596e2351d88a12ee30d17#commitcomment-10495732>
> .
>


@bors: retry
* #5285


Thank you @ldynia  for your commments. @mastfreaky please read the usage section and the gist!


TeamCity xBIM :: XbimExchange :: Build [Build 164](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1248&buildTypeId=XBIM_XbimExchange_Build) is now running


This breaks "shutdown -n" with your implementation of abort, I think... use "$@" in abort.


Why did you change the default timeout to only 5 minutes from 10 minutes?


@xnox As noted in my last comment, we have to be able to run this on arbitrary remote systems, both via ssh and a cloud-init script.  So using a bash script was our best option.  We also needed to be confident about the running init system, which is what checking PID 1 accomplishes perfectly.

@martinpitt We no longer assume /sbin/init implies upstart.


rax retry tests


resolve #11


いきなりcreateを呼べているのは、`spec_helper`に書いているため  44a590e


You can have an array as the value of the `ingredients` property. So then to access them it would be `booze.$id.ingredients[i]` where `i` is the index of an ingredient in the array. I think an array here makes sense. I think it'd be the same for the instructions, too, since for both the order of the ingredients/instructions is important.


Think you need to wrap it inside parentheses.

```js
(rc.registry.slice(-1) !== '/' ? rc.registry + '/' : rc.registry)
```


This and others need to set the path for the framework as relative to the build products in order to be portable as long as people install into ~/Library/Developer/OpenWebRTC/iPhone.sdk/OpenWebRTC.framework as is the default.


If it's a security issue then we should fix it.  Could you elaborate?  What would you suggest to fix it?


saw approval from jdm
at https://github.com/servo/servo/commit/66902d2c902243004ad5a158b16fccecf9b8a18f


merging servo/servo/heap-unclassified = 66902d2c into auto


servo/servo/heap-unclassified = 66902d2c merged ok, testing candidate = 0a32c5d5


TeamCity Testing :: Build [Build 33_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=140&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; built version not deployed.Exception.Message (new); exit code 1 Build time: 00:00:14


cc @DanielePucci @rbonghi


Add record count if useful, otherwise remove comment


TeamCity Testing :: Build [Build 34_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=142&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; built version not deployed.Exception.Message; exit code 1 Build time: 00:00:14


Unfortunately, it didn't seem to work as intended....


Whoops, this is an outdated version of the file I meant to upload.
Correct updated version will be uploaded later.


TeamCity xBIM :: XbimExchange :: Build [Build 164](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1248&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:03:33


`spec/factories/phones.rb`に、`association`を書いたことによって、Contactクラスを作成する必要がなくなった


TeamCity Testing :: Build [Build 35_1.0.0.1b1d7de](http://localhost:8080/viewLog.html?buildId=144&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; built version not deployed.Exception.Message; exit code 1 Build time: 00:00:15


Some additional test cases would be good here:
- no duplicate strings
- triplicate
- more than one string duplicated


@mschnitzer Really cool manpage! :+1:

I would propose to switch explanation and option. Why? If you look at  any manpage, you usually see this structure:

    option:
       explanation

I think, this is easier to read than the other way around (first explanation, then option). If you use option first, you can even sort them. This makes it easier for our readers to find the requested option.

If you apply this structure, you can even simplify the XML a bit. For example, the `-f` option, would look like this:

    <varlistentry>
      <term><option>-f</option></term>
      <listitem>
        <para>Never prompt</para>
      </listitem>
    </varlistentry>

I think, that's enough. You don't need the `<cmdsynopsis>` element. :grinning:


I am not sure how to fuse these two maps. Currently you can just display them individually from rviz.


What isn't working?


Part of issue #2, #3 and #4.


>ただし、build (または create )メソッドに Contact が渡された場合はそのオブジェクトが使われます。

これはちょっとよくわからない


@emilioeduardob Why are we not using standard sign-in Devise helpers instead?


This seems pedantic on my part, but I was curious since I'd never thought to do this before so I looked into the code. I think this should be `'governor'` instead of `'executive'`, since it's describing the precise `actor` instead of the branch/body.

https://github.com/sunlightlabs/billy/blob/master/billy/scrape/bills.py#L138


想减少循环的次数，试过2，4，6，8，但是好像执行的结果耗时都差不多，按道理来说8应该更快的。。。


MarkdownDocs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


Ci segments starts from 1 not 0: http://www.codeigniter.com/userguide3/libraries/uri.html#CI_URI


You can run `ssh remote.server test -d /run/systemd/system` through ssh just fine, though.


Dlaczego?


wwwww


@wellle This commit breaks vim-speeddating support; see #45.


@luiges90 生成野武将还是跳出了sweat:


:sweat:


TeamCity Testing :: Build [Build 36_1.0.0.628d759](http://localhost:8080/viewLog.html?buildId=146&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; built version not deployed (new); exit code 1 Build time: 00:00:17


索引超出了数组界限。weights[type.ID] = type.generationChance;


怎么用


To wykrywanie mógłbyś zrobić automatycznie w kodzie.


Could we combine with Tom's version on Trello?


TeamCity Testing :: Build [Build 37_1.0.0.628d759](http://localhost:8080/viewLog.html?buildId=148&buildTypeId=Shamrock_Build) outcome was **FAILURE**
Summary: Tests passed: 1; webApplication.dll (new); exit code 1 Build time: 00:00:13


Hi @johntopley, I've just released a 1.3.1 version.
Let me know if it's OK for you now.


Co dlaczego? Ja tu nic nie widzę, a ta spacja to błąd githuba, bo ja jej nie mam w kodzie ;u


I was on the receiving end of several last night, they can become lethal
pretty easy when you've got a gung-ho detective turned officer who won't
stop at a single clip.

On Tuesday, March 31, 2015, stuicey <notifications@github.com> wrote:

> Nerfed too much, rubber bullets where on a good place before anyway. They
> are simply coated in rubber and can be used as lethal raspberry
> Weaponry IRL.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stuicey/ApolloStation/commit/90f9c9bf1b667a24ee164681d7759744cde9d618#commitcomment-10493870>
> .
>


Does the employee mailer properly do HTML? that one has content_type: "text/html" specified in the mail action itself? https://github.com/NEU-Libraries/cerberus/blob/develop/app/mailers/employee_mailer.rb#L10


TeamCity Testing :: Build [Build 38_1.0.0.628d759](http://localhost:8080/viewLog.html?buildId=150&buildTypeId=Shamrock_Build) outcome was **SUCCESS**
Summary: Tests passed: 1 Build time: 00:00:15


Can this code be exposed?


It's a predictable file name in a world-writable directory. So any user can destroy  any file in the system (also from other users, or from root) by e. g. `ln -s /etc/shadow /tmp/discover_init_system.sh` and then wait for juju to run. (google for /tmp overwrite race, there have been plenty of CVEs in the past). So if you create/call a shell script, please use `mktemp`.

But I'm still convinced that this is overkill. You can check what's running on a remote system with a single shell command (testing for /run/systemd/system and/or for `initctl --system list`).


CBECC (kbenne) - i386-Windows-7-VisualStudio-12: OK (2137 of 2157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.07%25-yellow.svg)


commit demo


Works great!

```php
array (size=1)
  'ctr' => float 0.28
```


Thanks! Good tip.


Właśnie chodzi o tą spację :P

Następnym razem patrz dobrze `git status` ;)


TeamCity xBIM :: XbimExchange :: Build [Build 165](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1249&buildTypeId=XBIM_XbimExchange_Build) is now running


Typo? Put `ZTE-Q7` in MT7620N Profiles?


wiki is false by default, it might be a good idea to use `clean="false"` because the html cleaner takes a lot of computer power.


俊男,不要洗了


Hmm it looks like you might have changed things other than what you intended to change, I think this is reverting changes which I made before...


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/10556/testReport/) for this commit**


Sure, here is an example reproducible below:

test.c
```C
static int foo ()
{
	return 0;
}

int bar ()
{
	return foo ();
}
```

main.c
```C
extern int bar ();

static int foo ()
{
	return 2;
}

int main ()
{
	return bar () + foo ();
}
```
```
~/tests$ gcc test.c main.c -o main.elf
~/tests$ objdump -t main.elf | grep foo
00000000004004b4 l     F .text	000000000000000b              foo
00000000004004d0 l     F .text	000000000000000b              foo

```
Typically see this when people change function definitions in header files to be static. If you do a search for "static" in your includes directory you'll probably find quite a few of these.

Also if using ARM, you may have mapping symbols ($a, $t, $d) that are likely to appear multiple times in an ELF binary.


Review complete


4位4位互换，感觉如果8位8位互换效率应该是这个的一倍才对，但是试了没效果。。。


Я вообще предполагала, что вся работа с mfold должна быть в конечном коде в виде функции.
Или внутри этой функции должны быть еще функции типа смены рабочей директории и записи результатов в файлы?

И тогда еще такой вопрос - если смена рабочей директории происходит внутри функции, после выполнения функции какая директория останется рабочей - новая или старая?


ah, sorry - will do, I missed Tom's version somehow


sucess -> success ? (I know it was like this before your change...)


That was easy..


The `.async` flag is set in `helper-cache`.


Is this really part of the public interface?
I see this as a helper method for Author, nothing else.


never mind, I see why this was done


I like !string.empty() for this -- its says more directly what you are wanting to check


To znaczy?


Thanks for the explanation.  I'll open a bug for this.


Хорошо было бы выделить функцию в, которая меняет текущую директорию, запускает `mfold` и меняет директорию обратно, чтобы внешний код не почувствовал изменений.

Смена рабочей директории происходит на весь скрипт.


TeamCity xBIM :: XbimExchange :: Build [Build 165](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1249&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:05:26


TeamCity xBIM :: XbimExchange :: Build [Build 166](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1251&buildTypeId=XBIM_XbimExchange_Build) is now running


I think it can be removed, because in Users.signIn method logout has already implemented.


pending where? I was wondering, could you send me a pull request (or patch) on top of this branch with the changes affecting this commit? I am now unclear whether  the changes you mention require additional code that need to be pulled from other branches or repositories.


This is reverting a change which was made later on (because the dev wiki is out of date)


++viter preferred in our style guide


Reverting a change


Added fields:
user_id to Orders table
server_id to VoiceMumbleParams table


r+


Projeto Igreja


What do you mean by reload? You mean the list doesn't update?


Oh yah good point


:kiss:


Yeah, it's also useful if you want to reset all the work you did to a backup. If I restore from a backup, the table will still be there and the migration will fail without `force: true`. I think there's very little downside to including it actually.


++i preferred


The special thing about the "x" windows is that the axis order for the roi is txZYc and for the other windows it is txYZc.
I could test if the Y- and Z-axis are NOT in the scene's "along" tuple. But that wouldn't be better.
Or I could check the "_swappedDefault" field of the scene. But I don't like accessing other objects' private fields.


А обработку результатов mfold тогда в отдельную функцию выносить?


Could you explain why we need this? An empty "action" isn't valid in HTML5?


Kleine anpassing gemaakt in Angucomplete, omdat het daarin niet mogelijk was om minder strict te zoeken.
Meerdere woorden zoeken gaat nu simpelweg met spaties! ("thijs van gerw" etc.)


Do we support that? I know in the past @SamSaffron was against using postres extensions. So for now the optional attributes are serialized into a text field as JSON.


Ok. Danke für die Änderungen.
Wer bist du im Forum?

Bitte bei weiteren commits die freie Zeile am Ende der Datei raus lassen.
Ich muss die Dateien so weit es geht am Original lassen, um beim nächsten Patch von Obsidian weniger Arbeit zu haben.


TeamCity xBIM :: XbimExchange :: Build [Build 166](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1251&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:02:50


might i suggest "Look for external subtitles for videos provided by the UPnP server. This can cause extensive CPU, filesystem and network load." basically what you said but less :)


I think it can be removed, because method logout has already implemented in Users.signUpAndSignIn()


Could you please exclude this file from your PR so I can merge it?


It's explained in the commit's message.


I thought json was native in latest pogresql. Might be wrong though.


まあ、いいでしょう


Does this really work ?
I could not get it to work when I tried to obtain a 1:1 scale,
verified with   QCOMPARE( mCanvas->mapUnitsPerPixel (), 1.0 );


@nmiddleweek  @paulo882  that fixes too many digits in the field as mentioned by Sarah during the last demo


develop (kbenne) - Win64-Windows-7-VisualStudio-12: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


Pourquoi le ...echo....


This actually closes #173 as noted by racke. Either that or I accidentally discovered time travel.


Of course I read the commit message and no it's not explained. It says:

    XWIKI-11983: Fix HTML5 violations.
    * Replace <form action=""> by <form action="$doc.getURL()">. I could have simply removed the "action" property, but it is not valid in XHTML 1.0 and I would have broken Colibri.


backward test


big thanks :D


I noticed you are right, execution key is added by the webflow pluigin, but it seems to be added after "engin.Transition" makes the routing decision. Hence the flow loop on the first step.

A work around is to use params=[_eventId: "something"] on g:link tag, instead of event="something". This workaround is consistent with what we are already  doing with sortableColumns, so it is perfectly acceptable.


A revoir


Please bring better description on what the example below does.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/10557/testReport/) for this commit**


I would propose not to rename `platform` to `plat_spec` back because it makes diff quite unreadable. Also i propose to note in JSDoc that type of platform parameter is changed from string to object.


nit: you may want to invert `if` to reduce nesting...


`count` should default to `1` and be a min of `1` because your breaking an array into chunks and the array with 1 or less chunks is just a shallow clone of the array.


saw approval from zeeshanlakhani
at https://github.com/basho/riak_pipe/commit/cf15aeca51abf450134f3fe0fe793fe34e705a3f


merging basho/riak_pipe/feature/bump-core-2.1.1 = cf15aeca into borshop-integration-97-feature/bump-core-2.1.1


basho/riak_pipe/feature/bump-core-2.1.1 = cf15aeca merged ok, testing candidate = c2d7d28b


This logic could moved to `platforms.getPlatformSpec()`


The "r" QgsRectangle is created right before entering the loop, using the default constructor.
Does it not create an empty rectangle already ? It should...


I think asserts should be moved to webdriver layer, but I'm not sure


Yes, an empty action is invalid in HTML5.


Yep, it's native. You can even WHERE and JOIN in the json.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (657 of 658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.87%25-green.svg)


Why is this needed?


http://screencloud.net/v/5Rjm

The records show you banned yourself!

Also you broke the site, I called it.


Although it looks like you used somebody else's code to submit your assignment, I hope you understood the concept.

Author(string N, string E, string G ); <---- Try not to use N, E, G or something like that while declaring a variable.


I think this might be fixed in master now. Could you please check, and if it's not fixed, provide a YAML with burndown data which exhibits the problem?


@borshop: retry


Do we need to use `try/catch` here? IMO `Q` will reject promise automatically in case of exception.


It would be good to have a proper test for this before we merge it. I added a test for the `burndowns` command. Maybe the test can be done in a similar way.


Argh... Stupid Sublime git plugin overwrote my commit message for wp-parsely.php and combined it with this commit.


Ok got it. I was reading http://stackoverflow.com/questions/9401521/is-action-really-required-on-forms and indeed it says:

````
Yes, the form is required to have an action attribute in HTML4. If it's not set, the browser will likely use the same method as providing an empty string to it. You really should set action="" which is perfectly valid HTML4, follows standards, and achieves the same exact result.

In HTML5, you can actually specify an action on the submit button itself. If there isn't one, it uses the form's action and if that is not set, it defaults to the empty string (note you cannot explicitly set the action to an empty string in HTML5).
`````
So either the action is not specified at all and it works fine in HTML5 (but not in HTML4) or if you specify it, then it cannot be empty in HTML5 (but it's fine in HTML4) :)


Why do you require an integer? The function doesn't even make use of it.


At last!


I fixed the test and cherry-picked this commit.


On 31 March 2015 at 15:43, karlorg <notifications@github.com> wrote:

> On 31.03.2015 15:06, allanderek wrote:
>
> > Why? If there is really that much structure to what you are doing.
> > But I find that I rarely nest much deeper than 1 level of nesting.
> > You seem to have a premise that "flat is better than nested", but I
> > don't understand the reasoning. For sure *unwarranted* nesting is
>
> I don't really, but it's in the Zen of Python, and I was hoping maybe
> I'd see why if I try to follow it. I will say I find it hard to track
> by eye which indentation levels line up when they go past 2 or 3.
>
>
Ah, I think that's more a set of guide lines to be used when discussing
changes/additions to the *language*. So where they say flat is better than
nested it means, for example, `elif` is a good idea, because you get a set
of branches all nested to the same depth rather than ever more nested
else-ifs. So:

    if a == 1:
        blah
    elif a == 2:
        other blah
    else:
        more blah

is better than:

   if a == 1:
     blah
   else:
      if a == 2:
         other blah
      else:
         more blah

> > bad, but no worse than not nesting when it is warranted. If flat was
> > just always better than nested then we would have no provision for
> > nested functions.
>
> Also, I forgot about this, but nesting functions in Python means putting
> the helpers before the outer-level code, which I find pretty confusing.
> When helpers are involved I always want to read the 'outer' level first
> and then move into the helpers as necessary. I'm an outside-in kind of
> coder.

Yeah that's fair. I do miss Haskell's `where` clause. It is a bit more
tricky to see how it would work elegantly in Python, but definitely it
would be nice to define some helper methods and simple variables after the
fact.

>
>
> > In particular direct access to the database is going to lead to a lot
> > of code duplication. Look at what the test is doing, it is creating a
> > game, if I do that using direct access to the database I'll have to
> > update that if we change how games are created. Why on earth would I
> > want to force this on future-me?
>
> Yeah it's terrible, I just hadn't gotten around to building any
> abstractions for that yet, at least not in `main.py` (some test suites
> have internal helper methods for setting up test games etc.).
>
> >> Maybe we should think about whether the existing helpers (that
> >> emerged from implementing the view functions) are suitably general
>
> > Well, I'm happy to refactor as and when required. In this case, I did
> > not need to refactor (for the test), because the
> > `create_game_internal` method was already available to do exactly
>
> heh, that's another one that was only supposed to be used once. It
> looks pretty generally useful though. Maybe the name should be changed
> at some point, it's kind of the legacy of the function's history as part
> of the convoluted 'do something via a fabric call remotely or as a
> direct function call locally' browser test scheme from that online book
> thing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/allanderek/drunken-octo-avenger/commit/91b3ccd3fcc8139c1df45bf405c0f76a1ac4cfff#commitcomment-10495640>
> .
>


Cherry-picked.


Да


nit: You may want to invert `if` here to reduce nesting


cambio desde la pagina


`sourcePath` is undefined here. Probably should be `plat_spec.sourcePath`


>これまでのファク トリで使われてきた静的な文字列とは異なり、ブロックを使うと Factory Girl はそれを “遅延評価すべ き属性” と見なします。

？？？


I think this might be fixed in master now. Could you check and provide a YAML file with burndown data exhibiting the issue, if it isn't?


W jakim celu jest tutaj wywołanie @message.clients.clear?


遅延評価：
必要になるまで実行を行わないこと


gde, suka, skobka '{' ?????


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/1221


Poprawiłbym ten fragment i wrzucił poszczególnych klientów do partiala, przez "collection", zrobi się wtedy odrobinę większy porządek w tym miejscu.


要は、Fakerを使わないと、firstnameとかはspecで使おうが使わまいがメモリを消費してしまうけど、fakerで定義してしまえばspecで使わなければメモリを消費しないってことかな


Nothing can prevent a physical computer attack


Why are you coming unknown Sheena? Can you fix this?


I can´t start xvdr on oe 5.0.7. Kodi crashed without writing log. On V 5.0.6 was OK.
???


Is there a bug here?  What is the space is not in the free list (ie we've just given it out)?


literally a one-line fix..


Forgot to make this change in the unit tests when I originally pushed this.  Pretty silly of me.


Akcje, które robią coś "dużego" jak: wysyłka, generowanie jakiś dokumentów, odpytanie jakiegoś zewnętrznego api powinny iść przez zapytanie typu POST.


Ok, that's too many brackets gone. Use brackets for the first `if`, but not for the single-line `if ` and `else if` inside.


Instead of this, switch the one a few lines down to use concatenation. The other exceptions in this file use concatenation.


Seems reasonable.


saw approval from zeeshanlakhani
at https://github.com/basho/riak_api/commit/3f3492007ba5e7594827fede080573abe257f938


merging basho/riak_api/rebar/fd/riak_core-dependency = 3f349200 into borshop-integration-87-rebar/fd/riak_core-dependency


basho/riak_api/rebar/fd/riak_core-dependency = 3f349200 merged ok, testing candidate = 94a9485a


@wkeese i was following https://github.com/dojo/dojo/blob/master/tests/unit/dom-attr.js#L3-L8 as a style guide. I will fix that indenting.


saw approval from jdm
at https://github.com/JIoJIaJIu/servo/commit/8de3c01fe4cc85dc25db049949a4dfd312e0c492


@xeno-by I get the following error when using `findMacroClassLoader` (during macro expansion):
```
[debug] 	-classpath
[debug] 	/Users/martin/Documents/Projects/Duhemm/parsermacro/sandbox-clients/target/scala-2.11/classes:/Users/martin/Documents/Projects/Duhemm/parsermacro/sandbox-macros/target/scala-2.11/classes:/Users/martin/.ivy2/cache/org.scalameta/scalameta_2.11/jars/scalameta_2.11-0.1.0-SNAPSHOT.jar:/Users/martin/.ivy2/cache/org.scalameta/scalameta-foundation_2.11/jars/scalameta-foundation_2.11-0.1.0-SNAPSHOT.jar:/Users/martin/.ivy2/cache/org.scala-lang/scala-reflect/jars/scala-reflect-2.11.6.jar
java.lang.ClassCastException: scala.meta.syntactic.Token$BOF cannot be cast to scala.meta.syntactic.Token
	at Macros$$anonfun$1.apply(Macros.scala:18)
	at scala.collection.TraversableLike$$anonfun$filterImpl$1.apply(TraversableLike.scala:259)
	at scala.collection.Iterator$class.foreach(Iterator.scala:750)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1202)
	at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
	at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
	at scala.collection.TraversableLike$class.filterImpl(TraversableLike.scala:258)
	at scala.collection.TraversableLike$class.filterNot(TraversableLike.scala:278)
	at scala.collection.AbstractTraversable.filterNot(Traversable.scala:104)
	at Macros$.forImpl(Macros.scala:18)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.duhemm.parsermacro.Runtime$class.org$duhemm$parsermacro$Runtime$$invoke(Runtime.scala:58)
	at org.duhemm.parsermacro.Runtime$$anonfun$legacyRuntime$1$$anonfun$apply$3.apply(Runtime.scala:68)
	at org.duhemm.parsermacro.Runtime$$anonfun$legacyRuntime$1$$anonfun$apply$3.apply(Runtime.scala:68)
	at org.duhemm.parsermacro.AnalyzerPlugins$MacroPlugin$.pluginsMacroExpand(AnalyzerPlugins.scala:103)
    [...]
```

Any idea?


merging JIoJIaJIu/servo/gc = 8de3c01f into auto


JIoJIaJIu/servo/gc = 8de3c01f merged ok, testing candidate = 52cc63a2


Same for this. What is author in this context? when you look at the implementation you notice it is a terrible wording for "give me metadata for the Creator"
It is not used anywhere according to my grep FU and its a PITA for others implementing this interface. Like Collective.solr. Can we get rid of this?


all tests pass:
success: http://buildbot.bos1/builders/test-riak_pipe/builds/106


Make this a single method that takes three parameters, since these are all part of the same operation.


Name this `stats`


@dudekm `$userRepository`


Remove the entry for InterstellarTokamakFusionReator in your GameData/TweakScale/ScaleExponents.cfg or you will be sad.


失礼しました、先のコメント（行中のアイコンの位置を揃える）の意図を勘違いしていました。
これがないとそもそも要素が消えてしまうんですね。了解です。
(今アイコンと前後の文字がくっついて読めなくなってっているので、これで調整ができるのかと考えていました。。)


Yes, but this case is the "no callback provided" case.