1: D290 White spaces around docstring should be trimmed.
1: D400 First line should end with '.', not 's'
24:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email, get_user_info, isGuestUser
28:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.utils.url
28:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBCOMMENT_ALLOW_COMMENTS, CFG_WEBCOMMENT_ALLOW_REVIEWS, CFG_WEBCOMMENT_AUTHOR_DELETE_COMMENT_OPTION, CFG_WEBCOMMENT_MAX_ATTACHED_FILES, CFG_WEBCOMMENT_MAX_ATTACHMENT_SIZE, CFG_WEBCOMMENT_NB_REPORTS_BEFORE_SEND_EMAIL_TO_ADMIN, CFG_WEBCOMMENT_USE_RICH_TEXT_EDITOR
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.mail
31:1: E402 module level import not at top of file
32:28: E126 continuation line over-indented for hanging indent
47:1: I101 Imported names are in the wrong order. Should be create_html_select, get_html_text_editor
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.html
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.formatter
50:1: E402 module level import not at top of file
51:1: I101 Imported names are in the wrong order. Should be acc_get_role_id, acc_get_user_roles_from_user_info
51:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
51:1: E402 module level import not at top of file
52:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.access.control
52:1: E402 module level import not at top of file
54:1: E302 expected 2 blank lines, found 1
54: D203 Expected 1 blank line *before* class docstring, found 0
54: D400 First line should end with '.', not 'l'
57: D202 No blank lines allowed *after* method docstring, found 1
57: D400 First line should end with '.', not 'd'
57: D205 Blank line missing between one-line summary and description
92:13: F841 local variable 'last_comment_round_name' is assigned to but never used
98:139: E221 multiple spaces before operator
101:85: E231 missing whitespace after ','
101:87: E221 multiple spaces before operator
140:34: E127 continuation line over-indented for visual indent
152:13: E128 continuation line under-indented for visual indent
154:33: E203 whitespace before ':'
159:36: E225 missing whitespace around operator
160:168: E502 the backslash is redundant between brackets
160:57: E225 missing whitespace around operator
161:67: E127 continuation line over-indented for visual indent
164:13: E124 closing bracket does not match visual indentation
178:14: E127 continuation line over-indented for visual indent
180:14: E124 closing bracket does not match visual indentation
184: D401 First line should be imperative: 'Display', not 'Displays'
184: D205 Blank line missing between one-line summary and description
209: D400 First line should end with '.', not 'd'
209: D205 Blank line missing between one-line summary and description
244:26: E201 whitespace after '{'
244:45: E203 whitespace before ':'
244:22: E222 multiple spaces after operator
245:46: E203 whitespace before ':'
246:44: E203 whitespace before ':'
247:44: E203 whitespace before ':'
248:44: E203 whitespace before ':'
248:62: E261 at least two spaces before inline comment
248:63: E262 inline comment should start with '# '
249:44: E203 whitespace before ':'
249:62: E261 at least two spaces before inline comment
249:63: E262 inline comment should start with '# '
250:25: E124 closing bracket does not match visual indentation
260:13: F841 local variable 'last_comment_round_name' is assigned to but never used
294:106: E231 missing whitespace after ':'
294:143: E231 missing whitespace after ':'
295:32: E222 multiple spaces after operator
316:37: E225 missing whitespace around operator
336:13: E122 continuation line missing indentation or outdented
336:14: E201 whitespace after '{'
336:40: E203 whitespace before ':'
337:40: E203 whitespace before ':'
338:40: E203 whitespace before ':'
339:40: E203 whitespace before ':'
340:40: E203 whitespace before ':'
341:40: E203 whitespace before ':'
342:40: E203 whitespace before ':'
343:40: E203 whitespace before ':'
344:41: E203 whitespace before ':'
345:60: E225 missing whitespace around operator
346:40: E203 whitespace before ':'
347:13: E124 closing bracket does not match visual indentation
359:28: E128 continuation line under-indented for visual indent
360:28: E128 continuation line under-indented for visual indent
363: D400 First line should end with '.', not 'n'
363: D205 Blank line missing between one-line summary and description
402:35: E128 continuation line under-indented for visual indent
403:35: E126 continuation line over-indented for hanging indent
408:81: E225 missing whitespace around operator
408:100: E225 missing whitespace around operator
410:83: E225 missing whitespace around operator
433:105: E225 missing whitespace around operator
435:106: E225 missing whitespace around operator
441:110: E225 missing whitespace around operator
452:111: E271 multiple spaces after keyword
461:37: E126 continuation line over-indented for hanging indent
488:17: E127 continuation line over-indented for visual indent
488:33: E203 whitespace before ':'
489:33: E203 whitespace before ':'
490:33: E203 whitespace before ':'
500: D400 First line should end with '.', not 'n'
500: D205 Blank line missing between one-line summary and description
533:107: E231 missing whitespace after ':'
534:9: E266 too many leading '#' for block comment
568:94: E225 missing whitespace around operator
574:99: E225 missing whitespace around operator
589:31: E203 whitespace before ':'
590:16: E128 continuation line under-indented for visual indent
591:16: E128 continuation line under-indented for visual indent
591:31: E203 whitespace before ':'
592:16: E128 continuation line under-indented for visual indent
592:31: E203 whitespace before ':'
593:16: E128 continuation line under-indented for visual indent
594:16: E128 continuation line under-indented for visual indent
594:31: E203 whitespace before ':'
595:16: E128 continuation line under-indented for visual indent
595:31: E203 whitespace before ':'
596:16: E128 continuation line under-indented for visual indent
596:31: E203 whitespace before ':'
597:16: E124 closing bracket does not match visual indentation
600: D400 First line should end with '.', not 's'
600: D205 Blank line missing between one-line summary and description
609:55: E231 missing whitespace after ','
692:13: F841 local variable 'c_round_name' is assigned to but never used
693:13: F841 local variable 'c_restriction' is assigned to but never used
702:26: E201 whitespace after '{'
702:45: E203 whitespace before ':'
702:22: E222 multiple spaces after operator
703:46: E203 whitespace before ':'
704:44: E203 whitespace before ':'
705:44: E203 whitespace before ':'
706:44: E203 whitespace before ':'
707:44: E203 whitespace before ':'
708:44: E203 whitespace before ':'
709:44: E203 whitespace before ':'
710:44: E203 whitespace before ':'
711:44: E203 whitespace before ':'
712:25: E124 closing bracket does not match visual indentation
719:22: E201 whitespace after '{'
719:37: E203 whitespace before ':'
719:19: E222 multiple spaces after operator
720:42: E203 whitespace before ':'
721:36: E203 whitespace before ':'
722:36: E203 whitespace before ':'
724:36: E203 whitespace before ':'
725:36: E203 whitespace before ':'
726:36: E203 whitespace before ':'
727:36: E203 whitespace before ':'
731:9: E266 too many leading '#' for block comment
736:13: F841 local variable 'last_comment_round_name' is assigned to but never used
747:20: E127 continuation line over-indented for visual indent
754:35: E127 continuation line over-indented for visual indent
754:73: E221 multiple spaces before operator
763:132: E202 whitespace before ')'
764:33: E127 continuation line over-indented for visual indent
764:71: E221 multiple spaces before operator
765:140: E225 missing whitespace around operator
838:76: E261 at least two spaces before inline comment
846:275: E231 missing whitespace after ':'
847:163: E231 missing whitespace after ':'
880:38: E203 whitespace before ':'
880:62: E231 missing whitespace after ':'
882:38: E203 whitespace before ':'
882:61: E231 missing whitespace after ':'
883:38: E203 whitespace before ':'
883:63: E231 missing whitespace after ':'
885:35: E203 whitespace before ':'
892:9: E266 too many leading '#' for block comment
917:9: E266 too many leading '#' for block comment
1085:9: E122 continuation line missing indentation or outdented
1086:47: E203 whitespace before ','
1088:43: E225 missing whitespace around operator
1104: D401 First line should be imperative: 'print', not 'prints'
1104: D400 First line should end with '.', not 'm'
1112: D202 No blank lines allowed *after* method docstring, found 1
1112: D400 First line should end with '.', not 'n'
1112: D205 Blank line missing between one-line summary and description
1124:15: E221 multiple spaces before operator
1157: D400 First line should end with '.', not 'n'
1157: D205 Blank line missing between one-line summary and description
1175:15: E221 multiple spaces before operator
1177:9: E122 continuation line missing indentation or outdented
1178:9: E128 continuation line under-indented for visual indent
1179:9: E128 continuation line under-indented for visual indent
1196: D400 First line should end with '.', not 's'
1196: D205 Blank line missing between one-line summary and description
1216:22: E201 whitespace after '{'
1216:40: E203 whitespace before ':'
1217:40: E203 whitespace before ':'
1217:65: E202 whitespace before '}'
1222: D400 First line should end with '.', not 'r'
1222: D205 Blank line missing between one-line summary and description
1229:9: F841 local variable '_' is assigned to but never used
1238: D400 First line should end with '.', not 's'
1238: D205 Blank line missing between one-line summary and description
1257:22: E201 whitespace after '{'
1257:37: E203 whitespace before ':'
1257:19: E222 multiple spaces after operator
1258:42: E203 whitespace before ':'
1259:36: E203 whitespace before ':'
1260:36: E203 whitespace before ':'
1261:36: E203 whitespace before ':'
1262:36: E203 whitespace before ':'
1281:20: E222 multiple spaces after operator
1306:13: E122 continuation line missing indentation or outdented
1307:121: E502 the backslash is redundant between brackets
1308:28: E127 continuation line over-indented for visual indent
1309:100: E502 the backslash is redundant between brackets
1310:31: E127 continuation line over-indented for visual indent
1311:238: E271 multiple spaces after keyword
1320:50: E251 unexpected spaces around keyword / parameter equals
1320:52: E251 unexpected spaces around keyword / parameter equals
1355: D400 First line should end with '.', not 's'
1355: D205 Blank line missing between one-line summary and description
1373:22: E201 whitespace after '{'
1373:37: E203 whitespace before ':'
1373:19: E222 multiple spaces after operator
1374:42: E203 whitespace before ':'
1375:36: E203 whitespace before ':'
1376:36: E203 whitespace before ':'
1377:36: E203 whitespace before ':'
1378:36: E203 whitespace before ':'
1388:13: E128 continuation line under-indented for visual indent
1427:1: E128 continuation line under-indented for visual indent
1428:50: E251 unexpected spaces around keyword / parameter equals
1428:52: E251 unexpected spaces around keyword / parameter equals
1469:35: E203 whitespace before ':'
1469:42: E225 missing whitespace around operator
1470:35: E203 whitespace before ':'
1470:41: E225 missing whitespace around operator
1485: D400 First line should end with '.', not 'd'
1485: D205 Blank line missing between one-line summary and description
1492:22: E201 whitespace after '{'
1492:37: E203 whitespace before ':'
1492:19: E222 multiple spaces after operator
1493:42: E203 whitespace before ':'
1494:36: E203 whitespace before ':'
1495:36: E203 whitespace before ':'
1496:36: E203 whitespace before ':'
1497:36: E203 whitespace before ':'
1501:51: E221 multiple spaces before operator
1512:101: E222 multiple spaces after operator
1516: D401 First line should be imperative: 'Create', not 'Creates'
1516: D290 White spaces around docstring should be trimmed.
1516: D205 Blank line missing between one-line summary and description
1539:15: E221 multiple spaces before operator
1579: D400 First line should end with '.', not 'e'
1579: D200 One-line docstring should not occupy 3 lines
1605:19: E225 missing whitespace around operator
1609:36: E203 whitespace before ':'
1612:35: E203 whitespace before ':'
1613:35: E203 whitespace before ':'
1618:39: E225 missing whitespace around operator
1620: D400 First line should end with '.', not 'e'
1635:18: E225 missing whitespace around operator
1666: D400 First line should end with '.', not ')'
1666: D205 Blank line missing between one-line summary and description
1690:27: E127 continuation line over-indented for visual indent
1693:27: E127 continuation line over-indented for visual indent
1716:13: E201 whitespace after '{'
1716:25: E203 whitespace before ':'
1717:25: E203 whitespace before ':'
1718:25: E203 whitespace before ':'
1719:25: E203 whitespace before ':'
1721:26: E203 whitespace before ':'
1722:25: E203 whitespace before ':'
1723:25: E203 whitespace before ':'
1724:25: E203 whitespace before ':'
1754: D401 First line should be imperative: 'output', not 'outputs'
1754: D290 White spaces around docstring should be trimmed.
1754: D400 First line should end with '.', not 'd'
1758: D401 First line should be imperative: 'prepare', not 'prepares'
1758: D290 White spaces around docstring should be trimmed.
1758: D400 First line should end with '.', not 'r'
1773: D401 First line should be imperative: 'output', not 'outputs'
1773: D290 White spaces around docstring should be trimmed.
1773: D400 First line should end with '.', not 'w'
1788:34: E203 whitespace before ':'
1796: D400 First line should end with '.', not 't'
1796: D205 Blank line missing between one-line summary and description
1803:9: F841 local variable '_' is assigned to but never used
1842:17: E128 continuation line under-indented for visual indent
1842:50: E225 missing whitespace around operator
1842:69: E225 missing whitespace around operator
1843:17: E128 continuation line under-indented for visual indent
1843:36: E203 whitespace before ','
1843:23: E231 missing whitespace after ':'
1844:17: E128 continuation line under-indented for visual indent
1844:49: E203 whitespace before ','
1845:17: E128 continuation line under-indented for visual indent
1846:17: E128 continuation line under-indented for visual indent
1852:17: E128 continuation line under-indented for visual indent
1852:50: E225 missing whitespace around operator
1852:69: E225 missing whitespace around operator
1853:17: E128 continuation line under-indented for visual indent
1853:36: E203 whitespace before ','
1853:23: E231 missing whitespace after ':'
1854:17: E128 continuation line under-indented for visual indent
1855:17: E128 continuation line under-indented for visual indent
1860: D400 First line should end with '.', not 't'
1860: D205 Blank line missing between one-line summary and description
1866:9: F841 local variable '_' is assigned to but never used
1900:49: E225 missing whitespace around operator
1900:68: E225 missing whitespace around operator
1901:54: E272 multiple spaces before keyword
1903:49: E225 missing whitespace around operator
1903:68: E225 missing whitespace around operator
1904:54: E272 multiple spaces before keyword
1910:13: E128 continuation line under-indented for visual indent
1910:39: E203 whitespace before ','
1911:13: E128 continuation line under-indented for visual indent
1912:13: E128 continuation line under-indented for visual indent
1913:13: E128 continuation line under-indented for visual indent
1914:13: E128 continuation line under-indented for visual indent
1915:13: E128 continuation line under-indented for visual indent
1920: D400 First line should end with '.', not 't'
1920: D205 Blank line missing between one-line summary and description
1970:73: E261 at least two spaces before inline comment
1970:73: E262 inline comment should start with '# '
1972:81: E261 at least two spaces before inline comment
1972:81: E262 inline comment should start with '# '
1973:81: E261 at least two spaces before inline comment
1973:81: E262 inline comment should start with '# '
1974:81: E261 at least two spaces before inline comment
1974:81: E262 inline comment should start with '# '
1975:81: E261 at least two spaces before inline comment
1975:81: E262 inline comment should start with '# '
1976:81: E261 at least two spaces before inline comment
1976:81: E262 inline comment should start with '# '
1978:81: E261 at least two spaces before inline comment
1978:81: E262 inline comment should start with '# '
1979:81: E261 at least two spaces before inline comment
1979:81: E262 inline comment should start with '# '
1980:81: E261 at least two spaces before inline comment
1980:81: E262 inline comment should start with '# '
1981:81: E261 at least two spaces before inline comment
1981:81: E262 inline comment should start with '# '
1984:76: E261 at least two spaces before inline comment
1984:76: E262 inline comment should start with '# '
1986:84: E261 at least two spaces before inline comment
1986:84: E262 inline comment should start with '# '
1987:84: E261 at least two spaces before inline comment
1987:84: E262 inline comment should start with '# '
1988:84: E261 at least two spaces before inline comment
1988:84: E262 inline comment should start with '# '
1989:84: E261 at least two spaces before inline comment
1989:84: E262 inline comment should start with '# '
1990:84: E261 at least two spaces before inline comment
1990:84: E262 inline comment should start with '# '
1992:84: E262 inline comment should start with '# '
1993:84: E262 inline comment should start with '# '
1994:84: E262 inline comment should start with '# '
1995:84: E262 inline comment should start with '# '
1996:84: E262 inline comment should start with '# '
1998:84: E261 at least two spaces before inline comment
2001:65: E261 at least two spaces before inline comment
2001:66: E262 inline comment should start with '# '
2002:65: E261 at least two spaces before inline comment
2002:66: E262 inline comment should start with '# '
2003:66: E261 at least two spaces before inline comment
2003:66: E262 inline comment should start with '# '
2010:75: E261 at least two spaces before inline comment
2011:75: E261 at least two spaces before inline comment
2012:75: E261 at least two spaces before inline comment
2013:70: E261 at least two spaces before inline comment
2028:15: E128 continuation line under-indented for visual indent
2029:15: E128 continuation line under-indented for visual indent
2030:15: E128 continuation line under-indented for visual indent
2031:23: E211 whitespace before '('
2044:13: E122 continuation line missing indentation or outdented
2045:13: E122 continuation line missing indentation or outdented
2046:13: E122 continuation line missing indentation or outdented
2050:13: E122 continuation line missing indentation or outdented
2051:13: E122 continuation line missing indentation or outdented
2052:13: E122 continuation line missing indentation or outdented
2072:36: E225 missing whitespace around operator
2074:36: E225 missing whitespace around operator
2101: D400 First line should end with '.', not ','
2101: D205 Blank line missing between one-line summary and description
2113:37: E225 missing whitespace around operator
2113:86: E225 missing whitespace around operator
2125: D400 First line should end with '.', not ','
2125: D205 Blank line missing between one-line summary and description
2137:37: E225 missing whitespace around operator
2137:86: E225 missing whitespace around operator
2151:5: E303 too many blank lines (3)
2151: D400 First line should end with '.', not ','
2151: D205 Blank line missing between one-line summary and description
2163:37: E225 missing whitespace around operator
2163:86: E225 missing whitespace around operator
2175: D202 No blank lines allowed *after* method docstring, found 1
2175: D400 First line should end with '.', not ')'
2185:21: E126 continuation line over-indented for hanging indent
2188:26: E225 missing whitespace around operator
2224:9: E122 continuation line missing indentation or outdented
2225:9: E122 continuation line missing indentation or outdented
2226:9: E122 continuation line missing indentation or outdented
2227:9: E122 continuation line missing indentation or outdented
2228:9: E122 continuation line missing indentation or outdented
2229:9: E122 continuation line missing indentation or outdented
2230:9: E122 continuation line missing indentation or outdented
2231:9: E124 closing bracket does not match visual indentation
2234: D401 First line should be imperative: 'Print', not 'Prints'
2234: D400 First line should end with '.', not 'w'
2234: D205 Blank line missing between one-line summary and description
2256:15: E127 continuation line over-indented for visual indent
2256:109: E502 the backslash is redundant between brackets
2258:16: E127 continuation line over-indented for visual indent
2260:48: E225 missing whitespace around operator
2260:67: E225 missing whitespace around operator
2264: D401 First line should be imperative: 'Print', not 'Prints'
2264: D400 First line should end with '.', not 'w'
2264: D205 Blank line missing between one-line summary and description
2286:72: E221 multiple spaces before operator
2287:16: E127 continuation line over-indented for visual indent
2287:82: E502 the backslash is redundant between brackets
2287:44: E225 missing whitespace around operator
2287:63: E225 missing whitespace around operator
2291:81: E221 multiple spaces before operator
2292:20: E126 continuation line over-indented for hanging indent
2292:86: E502 the backslash is redundant between brackets
2292:48: E225 missing whitespace around operator
2292:67: E225 missing whitespace around operator
2296:79: E221 multiple spaces before operator
2297:20: E126 continuation line over-indented for hanging indent
2297:86: E502 the backslash is redundant between brackets
2297:48: E225 missing whitespace around operator
2297:67: E225 missing whitespace around operator
2301:16: E127 continuation line over-indented for visual indent
2305: D401 First line should be imperative: 'Print', not 'Prints'
2305: D400 First line should end with '.', not 'e'
2305: D205 Blank line missing between one-line summary and description
2332:15: E271 multiple spaces after keyword
2334: D202 No blank lines allowed *after* method docstring, found 1
2334: D400 First line should end with '.', not 'e'
2334: D205 Blank line missing between one-line summary and description
2372: D400 First line should end with '.', not 'r'
2414:78: E251 unexpected spaces around keyword / parameter equals
2414:80: E251 unexpected spaces around keyword / parameter equals
2415:78: E251 unexpected spaces around keyword / parameter equals
2415:80: E251 unexpected spaces around keyword / parameter equals
2416:79: E251 unexpected spaces around keyword / parameter equals
2416:81: E251 unexpected spaces around keyword / parameter equals
2417:55: E231 missing whitespace after ','
2417:78: E251 unexpected spaces around keyword / parameter equals
2417:80: E251 unexpected spaces around keyword / parameter equals
2425:22: E222 multiple spaces after operator
2460:9: E303 too many blank lines (3)
2523:34: E126 continuation line over-indented for hanging indent
2526:102: E502 the backslash is redundant between brackets
2526:77: E225 missing whitespace around operator
2526:96: E225 missing whitespace around operator
2531:98: E502 the backslash is redundant between brackets
2531:73: E225 missing whitespace around operator
2531:92: E225 missing whitespace around operator
2555:25: E127 continuation line over-indented for visual indent
2555:37: E203 whitespace before ':'
2556:37: E203 whitespace before ':'
2557:37: E203 whitespace before ':'
2558:37: E203 whitespace before ':'
2559:37: E203 whitespace before ':'
2560:37: E203 whitespace before ':'
2565:24: E261 at least two spaces before inline comment
2570:16: E127 continuation line over-indented for visual indent
2597:52: E126 continuation line over-indented for hanging indent


Is 'box' redundant?


3: L102 copyright year is outdated, expected 2015 but got 2014


I'd prefer to keep them separate. While using the same type for both probably wouldn't lead to any bugs, it would only save us ~5 lines of trivial code.


:exclamation: :boom: please clean up before making a commit and pushing, you can use
`
make clean
`
from within the repo,
or just add a .gitignore file and ignore the 'out' directory, plus all the files that shouldn't matter. just leave the sources.
```c
out
*~
.*
```
by all means remove them :x:


needs ```local $@```


Should you do this for sendrawtransaction as well?


This image is the one release by Ubuntu almost a year ago. Should we start out with something newer? 14.10 or just a 14.04 with upgrades?


Why croak() here (and below) if you're just ignoring the exceptions in the eval below in ```_has_nimblegen_capture_primary_pair```?


Minor style nitpick: you could perhaps replace the LBYL `if` with a EAFP `try`.


:bow:


That explains it. I had tried the former but figured it was a scope issue -
didn't realize the practical difference between the two but it makes sense
now. I badly need to read up on memory usage.
On Mar 13, 2015 9:25 AM, "Laurent Pugin" <notifications@github.com> wrote:

> PS You need to create it on the heap and not on the stack, of course, so it
> should be note->m_accid = new Accid();
>
> On Fri, Mar 13, 2015 at 2:23 PM, Laurent Pugin <lxpugin@gmail.com> wrote:
>
> > This would be a temporary solution. You need to make sure that m_accid
> set
> > to NULL in the Note constructor, then in Reset and the destructor delete
> it
> > if not NULL and set it to NULL (in Reset). You would create it in
> > view_element only if required and not NULL.
> >
> > As I said, we need some more thinking on how to handle @accid vs <accid>
> > within note. The typical complication with the several ways approach of
> > encoding the same thing in MEI ;-)
> >
> > On Fri, Mar 13, 2015 at 1:27 PM, Andrew Horwitz <
> notifications@github.com>
> > wrote:
> >
> >> Is this as easy as creating the Accid in view_element:414 (lower in this
> >> commit, what I replaced) then just assigning note->m_accid = &accid
> after
> >> it?
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/DDMAL/verovio/commit/8f89e8a86ceafdb93eb8999ed0ef0a6d96f973ea#commitcomment-10184177
> >
> >> .
> >>
> >
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DDMAL/verovio/commit/8f89e8a86ceafdb93eb8999ed0ef0a6d96f973ea#commitcomment-10185041>
> .
>


Interessante como tu fez o find. Mas tem uma maneira mais simples de fazer


Probably, the error code "TP_QT_ERROR_NOT_IMPLEMENTED" is inappropriate. Would be replaced by TP_QT_ERROR_INVALID_ARGUMENT. The error message will be corrected as well.


I'm not sure I understand this. I was worrying about the Map traversal. What are you trying to minimise? Acid-state actions?


cucumber doesnt use different yml file. so it should work fine


Ok


But, right thing to do, hence rolled it in :)


This link is rendered to `https://github.com/atom/settings-view)` on https://atom.io/docs/v0.187.0/using-atom-atom-packages (a trailing parentheses)


Claimants should still be able to see claims they have submitted. Claimants should be able to see all claims under their name regardless of the claim's status. Approvers should be able to see all claims with the submitted status that don't match their name.


any reason you're not using vt normalize as well?

On Fri, Mar 13, 2015 at 3:52 AM, Brad Chapman <notifications@github.com> wrote:
> Multi-alleleic decomposition for GEMINI: update with latest recommendations from @brentp
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/chapmanb/bcbio-nextgen/commit/741dfd2ef831a249add77f3c1a8f930ffa8c702b


1: M100 needs more reviewers
1: M101 signature is missing


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
30:1: I101 Imported names are in the wrong order. Should be DatabaseError, run_sql
32:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.legacy.dbquery
33:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.bibsched.bibtask
34:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_CHARS_ALPHANUMERIC_SEPARATORS, CFG_BIBINDEX_CHARS_PUNCTUATION
34:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibrecord
35:6: E126 continuation line over-indented for hanging indent
55: D200 One-line docstring should not occupy 3 lines
65:9: E128 continuation line under-indented for visual indent
68:1: E302 expected 2 blank lines, found 1
68: D401 First line should be imperative: 'Return', not 'Returns'
68: D209 Put multi-line docstring closing quotes on separate line
68: D205 Blank line missing between one-line summary and description
68: D208 Docstring is over-indented
84: D401 First line should be imperative: 'Return', not 'Returns'
84: D209 Put multi-line docstring closing quotes on separate line
84: D400 First line should end with '.', not 'e'
84: D205 Blank line missing between one-line summary and description
84: D208 Docstring is over-indented
99: D401 First line should be imperative: 'Return', not 'Returns'
99: D400 First line should end with '.', not 'e'
99: D205 Blank line missing between one-line summary and description
99: D208 Docstring is over-indented
107:5: B901 blind except: statement
114: D401 First line should be imperative: 'Get', not 'Gets'
114: D290 White spaces around docstring should be trimmed.
114: D209 Put multi-line docstring closing quotes on separate line
114: D400 First line should end with '.', not 'd'
114: D205 Blank line missing between one-line summary and description
114: D208 Docstring is over-indented
120:5: B901 blind except: statement
127: D401 First line should be imperative: 'Get', not 'Gets'
127: D290 White spaces around docstring should be trimmed.
127: D209 Put multi-line docstring closing quotes on separate line
127: D400 First line should end with '.', not 'd'
127: D205 Blank line missing between one-line summary and description
127: D208 Docstring is over-indented
133:5: B901 blind except: statement
140: D205 Blank line missing between one-line summary and description
170: D400 First line should end with '.', not 's'
170: D205 Blank line missing between one-line summary and description
170: D208 Docstring is over-indented
181:11: E271 multiple spaces after keyword
187:1: F401 'get_idx_indexer' imported but unused
187:1: E402 module level import not at top of file
190: D401 First line should be imperative: 'Return', not 'Returns'
190: D209 Put multi-line docstring closing quotes on separate line
190: D205 Blank line missing between one-line summary and description
190: D208 Docstring is over-indented
212: D401 First line should be imperative: 'Return', not 'Returns'
212: D290 White spaces around docstring should be trimmed.
221: D401 First line should be imperative: 'Return', not 'Returns'
221: D209 Put multi-line docstring closing quotes on separate line
221: D400 First line should end with '.', not 'h'
221: D205 Blank line missing between one-line summary and description
221: D208 Docstring is over-indented
232: D401 First line should be imperative: 'Check', not 'Checks'
232: D400 First line should end with '.', not 'l'
241:1: E302 expected 2 blank lines, found 1
241: D400 First line should end with '.', not 's'
241: D205 Blank line missing between one-line summary and description
241: D208 Docstring is over-indented
255:1: E302 expected 2 blank lines, found 1
255: D401 First line should be imperative: 'Return', not 'Returns'
255: D205 Blank line missing between one-line summary and description
255: D208 Docstring is over-indented
268: D401 First line should be imperative: 'Return', not 'Returns'
268: D209 Put multi-line docstring closing quotes on separate line
268: D205 Blank line missing between one-line summary and description
268: D208 Docstring is over-indented
281: D401 First line should be imperative: 'Return', not 'Returns'
281: D209 Put multi-line docstring closing quotes on separate line
281: D205 Blank line missing between one-line summary and description
281: D208 Docstring is over-indented
291: D401 First line should be imperative: 'Return', not 'Returns'
291: D400 First line should end with '.', not 's'
291: D205 Blank line missing between one-line summary and description
291: D208 Docstring is over-indented
299:5: F841 local variable 'out' is assigned to but never used
321: D401 First line should be imperative: 'Return', not 'Returns'
321: D209 Put multi-line docstring closing quotes on separate line
321: D400 First line should end with '.', not 'g'
321: D205 Blank line missing between one-line summary and description
321: D208 Docstring is over-indented
326:26: E261 at least two spaces before inline comment
326:27: E262 inline comment should start with '# '
327:26: E261 at least two spaces before inline comment
327:27: E262 inline comment should start with '# '
342:25: E261 at least two spaces before inline comment
342:26: E262 inline comment should start with '# '
362: D401 First line should be imperative: 'Return', not 'Returns'
362: D209 Put multi-line docstring closing quotes on separate line
362: D400 First line should end with '.', not 'g'
362: D205 Blank line missing between one-line summary and description
362: D208 Docstring is over-indented
399: D401 First line should be imperative: 'Return', not 'Returns'
399: D205 Blank line missing between one-line summary and description
399: D208 Docstring is over-indented
437: D401 First line should be imperative: 'Return', not 'Returns'
437: D400 First line should end with '.', not ':'
437: D205 Blank line missing between one-line summary and description
437: D208 Docstring is over-indented
442:10: E225 missing whitespace around operator
450: D401 First line should be imperative: 'Remove', not 'Removes'
450: D205 Blank line missing between one-line summary and description
450: D208 Docstring is over-indented
463: D208 Docstring is over-indented
463: D200 One-line docstring should not occupy 3 lines
477: D401 First line should be imperative: 'Create', not 'Creates'
477: D400 First line should end with '.', not 'd'
477: D205 Blank line missing between one-line summary and description
477: D208 Docstring is over-indented
487: D101 Docstring missing
491: D401 First line should be imperative: 'Return', not 'Returns'
491: D300 Expected """-quotes, got '-quotes
501: D401 First line should be imperative: 'Return', not 'Returns'
501: D400 First line should end with '.', not 'y'
501: D205 Blank line missing between one-line summary and description
501: D208 Docstring is over-indented
512:47: E202 whitespace before ')'
516: D401 First line should be imperative: 'Check', not 'Checks'
516: D400 First line should end with '.', not 't'
519:25: E272 multiple spaces before keyword
526: D401 First line should be imperative: 'Check', not 'Checks'
526: D209 Put multi-line docstring closing quotes on separate line
526: D400 First line should end with '.', not ';'
526: D205 Blank line missing between one-line summary and description
526: D208 Docstring is over-indented
532: D401 First line should be imperative: 'Return', not 'Returns'
532: D209 Put multi-line docstring closing quotes on separate line
532: D400 First line should end with '.', not ';'
532: D205 Blank line missing between one-line summary and description
532: D208 Docstring is over-indented
541: D401 First line should be imperative: 'Find', not 'Finds'
541: D400 First line should end with '.', not 'n'
541: D205 Blank line missing between one-line summary and description
541: D208 Docstring is over-indented


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
23:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibindex.engine_stopwords
23:1: F401 'CFG_ETCDIR' imported but unused
24:6: E126 continuation line over-indented for hanging indent
68:1: E302 expected 2 blank lines, found 1
68: D400 First line should end with '.', not 'g'
68: D205 Blank line missing between one-line summary and description
81:1: E302 expected 2 blank lines, found 0
81: D103 Docstring missing
92: D401 First line should be imperative: 'Return', not 'Returns'
92: D205 Blank line missing between one-line summary and description
92: D208 Docstring is over-indented
106: D401 First line should be imperative: 'Return', not 'Returns'
106: D205 Blank line missing between one-line summary and description
106: D208 Docstring is over-indented
120:1: E302 expected 2 blank lines, found 1
120: D401 First line should be imperative: 'Return', not 'Returns'
120: D208 Docstring is over-indented
130:1: E302 expected 2 blank lines, found 1
130: D400 First line should end with '.', not 'e'
130: D205 Blank line missing between one-line summary and description
159:1: E302 expected 2 blank lines, found 1
159: D400 First line should end with '.', not 'e'
159: D205 Blank line missing between one-line summary and description


4: L102 copyright year is outdated, expected 2015 but got 2013
25:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
43:152: E203 whitespace before ':'
50:160: E203 whitespace before ':'
57:160: E203 whitespace before ':'
65:107: E203 whitespace before ':'
73:96: E203 whitespace before ':'
81:96: E203 whitespace before ':'
89:101: E203 whitespace before ':'
97:101: E203 whitespace before ':'
105:116: E203 whitespace before ':'
113:116: E203 whitespace before ':'
121:107: E203 whitespace before ':'
129:114: E203 whitespace before ':'
137:131: E203 whitespace before ':'
155:18: E128 continuation line under-indented for visual indent
155:83: E203 whitespace before ':'
166:18: E128 continuation line under-indented for visual indent
166:88: E203 whitespace before ':'
177:18: E128 continuation line under-indented for visual indent
177:88: E203 whitespace before ':'
188:18: E128 continuation line under-indented for visual indent
188:101: E203 whitespace before ':'
203:18: E128 continuation line under-indented for visual indent
203:101: E203 whitespace before ':'
216:18: E128 continuation line under-indented for visual indent
216:108: E203 whitespace before ':'
229:18: E128 continuation line under-indented for visual indent
229:126: E203 whitespace before ':'
232:13: E128 continuation line under-indented for visual indent
233:13: E128 continuation line under-indented for visual indent
234:13: E128 continuation line under-indented for visual indent
235:13: E128 continuation line under-indented for visual indent
236:13: E128 continuation line under-indented for visual indent
237:13: E128 continuation line under-indented for visual indent
238:13: E128 continuation line under-indented for visual indent
239:13: E128 continuation line under-indented for visual indent
240:13: E128 continuation line under-indented for visual indent
241:13: E128 continuation line under-indented for visual indent
242:13: E128 continuation line under-indented for visual indent
243:13: E128 continuation line under-indented for visual indent
244:13: E128 continuation line under-indented for visual indent
245:13: E128 continuation line under-indented for visual indent
246:13: E128 continuation line under-indented for visual indent
247:13: E128 continuation line under-indented for visual indent
248:13: E128 continuation line under-indented for visual indent
249:13: E128 continuation line under-indented for visual indent
250:13: E128 continuation line under-indented for visual indent
251:13: E128 continuation line under-indented for visual indent
252:13: E128 continuation line under-indented for visual indent
253:13: E128 continuation line under-indented for visual indent
254:13: E128 continuation line under-indented for visual indent
263:18: E128 continuation line under-indented for visual indent
263:97: E203 whitespace before ':'
283:1: E303 too many blank lines (3)
320:1: E303 too many blank lines (3)
325:5: E303 too many blank lines (2)
334:42: E231 missing whitespace after ','
334:47: E231 missing whitespace after ','
334:53: E231 missing whitespace after ','
340:39: E231 missing whitespace after ','
340:45: E231 missing whitespace after ','
340:51: E231 missing whitespace after ','
340:57: E231 missing whitespace after ','
340:63: E231 missing whitespace after ','
346:39: E231 missing whitespace after ','
346:45: E231 missing whitespace after ','
346:51: E231 missing whitespace after ','
346:57: E231 missing whitespace after ','
359:90: E231 missing whitespace after ','
359:96: E231 missing whitespace after ','


1: D400 First line should end with '.', not 'n'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D400 First line should end with '.', not 'n'
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
40:41: E251 unexpected spaces around keyword / parameter equals
40:43: E251 unexpected spaces around keyword / parameter equals
40:66: E251 unexpected spaces around keyword / parameter equals
40:68: E251 unexpected spaces around keyword / parameter equals
40:94: E251 unexpected spaces around keyword / parameter equals
40:96: E251 unexpected spaces around keyword / parameter equals
40:123: E251 unexpected spaces around keyword / parameter equals
40:125: E251 unexpected spaces around keyword / parameter equals
40: D102 Docstring missing
45:5: E303 too many blank lines (2)
45: D401 First line should be imperative: 'Use', not 'Uses'
45: D209 Put multi-line docstring closing quotes on separate line
45: D400 First line should end with '.', not 's'
45: D205 Blank line missing between one-line summary and description
45: D208 Docstring is over-indented
48:55: E231 missing whitespace after ','
50: D205 Blank line missing between one-line summary and description
58: D102 Docstring missing
61: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2012
32:1: E303 too many blank lines (3)
32: D203 Expected 1 blank line *before* class docstring, found 0
41:41: E251 unexpected spaces around keyword / parameter equals
41:43: E251 unexpected spaces around keyword / parameter equals
41:66: E251 unexpected spaces around keyword / parameter equals
41:68: E251 unexpected spaces around keyword / parameter equals
41:94: E251 unexpected spaces around keyword / parameter equals
41:96: E251 unexpected spaces around keyword / parameter equals
41:123: E251 unexpected spaces around keyword / parameter equals
41:125: E251 unexpected spaces around keyword / parameter equals
41: D102 Docstring missing
43:49: E127 continuation line over-indented for visual indent
44:49: E127 continuation line over-indented for visual indent
45:49: E127 continuation line over-indented for visual indent
71:35: E203 whitespace before ':'
72:35: E203 whitespace before ':'
73:35: E203 whitespace before ':'
74:35: E203 whitespace before ':'
75:35: E203 whitespace before ':'
89:25: E116 unexpected indentation (comment)
100:21: E116 unexpected indentation (comment)
106: D202 No blank lines allowed *after* method docstring, found 1
128:61: E251 unexpected spaces around keyword / parameter equals
128:63: E251 unexpected spaces around keyword / parameter equals
142:22: E711 comparison to None should be 'if cond is not None:'
159:9: F841 local variable 'raw' is assigned to but never used
180: D202 No blank lines allowed *after* method docstring, found 1
196: D401 First line should be imperative: 'List', not 'Lists'
196: D400 First line should end with '.', not ']'
198:21: E711 comparison to None should be 'if cond is None:'
202: D401 First line should be imperative: 'List', not 'Lists'
202: D400 First line should end with '.', not 'l'
212: D401 First line should be imperative: 'Bring', not 'Brings'
212: D202 No blank lines allowed *after* function docstring, found 1
212: D400 First line should end with '.', not 's'
229: D401 First line should be imperative: 'Run', not 'Runs'
229: D400 First line should end with '.', not 'l'
232:18: E272 multiple spaces before keyword
238: D401 First line should be imperative: 'Find', not 'Finds'
238: D400 First line should end with '.', not "'"
261:5: E303 too many blank lines (2)
288:5: E303 too many blank lines (2)
288: D205 Blank line missing between one-line summary and description
288: D208 Docstring is over-indented
297:5: E303 too many blank lines (2)
297: D400 First line should end with '.', not 'r'
302:5: E303 too many blank lines (2)
302: D290 White spaces around docstring should be trimmed.
326:5: E303 too many blank lines (2)
326: D205 Blank line missing between one-line summary and description
326: D208 Docstring is over-indented
336:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2012
32: D103 Docstring missing
41: D103 Docstring missing
50: D103 Docstring missing
59: D103 Docstring missing
63: D209 Put multi-line docstring closing quotes on separate line
63: D203 Expected 1 blank line *before* class docstring, found 0
63: D302 Use u""" for docstrings with Unicode
63: D205 Blank line missing between one-line summary and description
63: D208 Docstring is over-indented
69:41: E251 unexpected spaces around keyword / parameter equals
69:43: E251 unexpected spaces around keyword / parameter equals
69:66: E251 unexpected spaces around keyword / parameter equals
69:68: E251 unexpected spaces around keyword / parameter equals
69:94: E251 unexpected spaces around keyword / parameter equals
69:96: E251 unexpected spaces around keyword / parameter equals
69:123: E251 unexpected spaces around keyword / parameter equals
69:125: E251 unexpected spaces around keyword / parameter equals
69: D400 First line should end with '.', not 'n'
72:49: E127 continuation line over-indented for visual indent
73:49: E127 continuation line over-indented for visual indent
74:49: E127 continuation line over-indented for visual indent
77:5: E303 too many blank lines (2)
77: D400 First line should end with '.', not 'r'
82:5: E303 too many blank lines (2)
82: D401 First line should be imperative: 'Split', not 'Splits'
82: D400 First line should end with '.', not 's'
82: D205 Blank line missing between one-line summary and description
104:22: E201 whitespace after '['
129:5: E303 too many blank lines (2)
129: D102 Docstring missing
132: D102 Docstring missing


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2013
22: D203 Expected 1 blank line *before* class docstring, found 0
22: D204 Expected 1 blank line *after* class docstring, found 2
22: D400 First line should end with '.', not ')'
22: D205 Blank line missing between one-line summary and description
22: D208 Docstring is over-indented
30:5: E303 too many blank lines (2)
30: D102 Docstring missing
34:5: E303 too many blank lines (2)
34: D401 First line should be imperative: 'Return', not 'Returns'
34: D400 First line should end with '.', not 'n'
38: D205 Blank line missing between one-line summary and description
45:15: F821 undefined name 'get_record'
49: D401 First line should be imperative: 'Return', not 'Returns'
49: D200 One-line docstring should not occupy 3 lines


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
25:6: E126 continuation line over-indented for hanging indent
27:1: I101 Imported names are in the wrong order. Should be strip_accents, wash_for_utf8
28:1: I101 Imported names are in the wrong order. Should be apply_stemming, length_check, lower_index_term, remove_latex_markup, remove_stopwords
28:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_washer should be before from invenio.utils.text
29:6: E126 continuation line over-indented for hanging indent
31:1: I101 Imported names are in the wrong order. Should be latex_formula_re, re_arxiv, re_block_punctuation_begin, re_block_punctuation_end, re_punctuation, re_separators
31:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.legacy.bibindex.engine_washer
32:6: E126 continuation line over-indented for hanging indent
41:1: E303 too many blank lines (3)
41: D203 Expected 1 blank line *before* class docstring, found 0
41: D205 Blank line missing between one-line summary and description
41: D208 Docstring is over-indented
47:41: E251 unexpected spaces around keyword / parameter equals
47:43: E251 unexpected spaces around keyword / parameter equals
47:66: E251 unexpected spaces around keyword / parameter equals
47:68: E251 unexpected spaces around keyword / parameter equals
47:94: E251 unexpected spaces around keyword / parameter equals
47:96: E251 unexpected spaces around keyword / parameter equals
47:123: E251 unexpected spaces around keyword / parameter equals
47:125: E251 unexpected spaces around keyword / parameter equals
47: D400 First line should end with '.', not 'n'
55:5: E303 too many blank lines (2)
55: D401 First line should be imperative: 'Pick', not 'Picks'
55: D400 First line should end with '.', not ')'
66:5: E303 too many blank lines (3)
66: D202 No blank lines allowed *after* method docstring, found 1
66: D400 First line should end with '.', not 's'
66: D205 Blank line missing between one-line summary and description
66: D208 Docstring is over-indented
117:5: E303 too many blank lines (2)
117: D202 No blank lines allowed *after* method docstring, found 1
117: D400 First line should end with '.', not 's'
117: D205 Blank line missing between one-line summary and description
117: D208 Docstring is over-indented
159:5: E303 too many blank lines (2)
159: D400 First line should end with '.', not 's'
159: D205 Blank line missing between one-line summary and description
159: D208 Docstring is over-indented
167: D401 First line should be imperative: 'Pick', not 'Picks'
167: D400 First line should end with '.', not 'n'
167: D205 Blank line missing between one-line summary and description


1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
39:41: E251 unexpected spaces around keyword / parameter equals
39:43: E251 unexpected spaces around keyword / parameter equals
39:66: E251 unexpected spaces around keyword / parameter equals
39:68: E251 unexpected spaces around keyword / parameter equals
39:94: E251 unexpected spaces around keyword / parameter equals
39:96: E251 unexpected spaces around keyword / parameter equals
39:123: E251 unexpected spaces around keyword / parameter equals
39:125: E251 unexpected spaces around keyword / parameter equals
39: D400 First line should end with '.', not 'y'
39: D205 Blank line missing between one-line summary and description
39: D208 Docstring is over-indented
48:5: E303 too many blank lines (2)
48: D401 First line should be imperative: 'Pick', not 'Picks'
48: D400 First line should end with '.', not ')'
57: D401 First line should be imperative: 'Pick', not 'Picks'
57: D400 First line should end with '.', not 'n'
57: D205 Blank line missing between one-line summary and description
65: D102 Docstring missing
68: D102 Docstring missing
71: D102 Docstring missing
73:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2012
20:21: W291 trailing whitespace
29:1: E303 too many blank lines (4)
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D204 Expected 1 blank line *after* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
34:41: E251 unexpected spaces around keyword / parameter equals
34:43: E251 unexpected spaces around keyword / parameter equals
34:66: E251 unexpected spaces around keyword / parameter equals
34:68: E251 unexpected spaces around keyword / parameter equals
34:94: E251 unexpected spaces around keyword / parameter equals
34:96: E251 unexpected spaces around keyword / parameter equals
34:123: E251 unexpected spaces around keyword / parameter equals
34:125: E251 unexpected spaces around keyword / parameter equals
34: D102 Docstring missing
36:49: E127 continuation line over-indented for visual indent
37:49: E127 continuation line over-indented for visual indent
38:49: E127 continuation line over-indented for visual indent
40: D401 First line should be imperative: 'Return', not 'Returns'
40: D200 One-line docstring should not occupy 3 lines


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2013
27: D203 Expected 1 blank line *before* class docstring, found 0
27: D205 Blank line missing between one-line summary and description
27: D208 Docstring is over-indented
43:41: E251 unexpected spaces around keyword / parameter equals
43:43: E251 unexpected spaces around keyword / parameter equals
43: D102 Docstring missing
44:24: E127 continuation line over-indented for visual indent
44:40: E251 unexpected spaces around keyword / parameter equals
44:42: E251 unexpected spaces around keyword / parameter equals
45:24: E127 continuation line over-indented for visual indent
45:42: E251 unexpected spaces around keyword / parameter equals
45:44: E251 unexpected spaces around keyword / parameter equals
46:24: E127 continuation line over-indented for visual indent
46:43: E251 unexpected spaces around keyword / parameter equals
46:45: E251 unexpected spaces around keyword / parameter equals
50:5: E303 too many blank lines (2)
50: D208 Docstring is over-indented
68: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
26: D203 Expected 1 blank line *before* class docstring, found 0
26: D205 Blank line missing between one-line summary and description
26: D208 Docstring is over-indented
39:41: E251 unexpected spaces around keyword / parameter equals
39:43: E251 unexpected spaces around keyword / parameter equals
39:66: E251 unexpected spaces around keyword / parameter equals
39:68: E251 unexpected spaces around keyword / parameter equals
39:94: E251 unexpected spaces around keyword / parameter equals
39:96: E251 unexpected spaces around keyword / parameter equals
39:123: E251 unexpected spaces around keyword / parameter equals
39:125: E251 unexpected spaces around keyword / parameter equals
39: D102 Docstring missing
43:5: E303 too many blank lines (2)
43: D208 Docstring is over-indented
61: D102 Docstring missing
64: D102 Docstring missing
67: D102 Docstring missing
70: D102 Docstring missing


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2014
20:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
23:1: E302 expected 2 blank lines, found 1
23: D203 Expected 1 blank line *before* class docstring, found 0
23: D400 First line should end with '.', not 'g'
23: D205 Blank line missing between one-line summary and description
23: D208 Docstring is over-indented
53: D102 Docstring missing
57:5: E303 too many blank lines (2)
57: D102 Docstring missing
70:60: W601 .has_key() is deprecated, use 'in'
72:39: E127 continuation line over-indented for visual indent
73:47: W601 .has_key() is deprecated, use 'in'
80: D400 First line should end with '.', not 'd'
80: D205 Blank line missing between one-line summary and description


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
25:1: I100 Imports statements are in the wrong order. import logging should be before import sys
27:1: I100 Imports statements are in the wrong order. import re should be before import urllib2
31:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_FULLTEXT_INDEX_LOCAL_FILES_ONLY, CFG_BIBINDEX_SPLASH_PAGES, CFG_SOLR_URL, CFG_XAPIAN_ENABLED
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
32:6: E126 continuation line over-indented for hanging indent
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.websubmit.file_converter should be before from invenio.utils.html
38:1: I100 Imports statements are in the wrong order. from invenio.legacy.miscutil.solrutils_bibindex_indexer should be before from invenio.legacy.websubmit.file_converter
40:1: I101 Imported names are in the wrong order. Should be BibRecDocs, InvenioBibDocFileError, bibdocfile_url_p, bibdocfile_url_to_bibdoc, download_url
40:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.miscutil.xapianutils_bibindex_indexer
41:6: E126 continuation line over-indented for hanging indent
45:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibsched.bibtask
46:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.ext.logging
46:1: I201 Missing newline before sections or imports.
47:1: I201 Missing newline before sections or imports.
49:29: E261 at least two spaces before inline comment
52: D203 Expected 1 blank line *before* class docstring, found 0
52: D208 Docstring is over-indented
52: D200 One-line docstring should not occupy 3 lines
57:41: E251 unexpected spaces around keyword / parameter equals
57:43: E251 unexpected spaces around keyword / parameter equals
57:66: E251 unexpected spaces around keyword / parameter equals
57:68: E251 unexpected spaces around keyword / parameter equals
57:94: E251 unexpected spaces around keyword / parameter equals
57:96: E251 unexpected spaces around keyword / parameter equals
57:123: E251 unexpected spaces around keyword / parameter equals
57:125: E251 unexpected spaces around keyword / parameter equals
57: D102 Docstring missing
60:49: E127 continuation line over-indented for visual indent
61:49: E127 continuation line over-indented for visual indent
62:49: E127 continuation line over-indented for visual indent
64: D401 First line should be imperative: 'Allow', not 'Allows'
64: D400 First line should end with '.', not 'g'
68: D400 First line should end with '.', not 'r'
73:5: E303 too many blank lines (2)
73: D401 First line should be imperative: 'Return', not 'Returns'
73: D400 First line should end with '.', not 'y'
73: D205 Blank line missing between one-line summary and description
73: D208 Docstring is over-indented
101:28: E713 test for membership should be 'not in'
158:66: E261 at least two spaces before inline comment
185:5: E303 too many blank lines (2)
185: D102 Docstring missing
189:5: E303 too many blank lines (2)
189: D102 Docstring missing
192: D102 Docstring missing
194:1: W391 blank line at end of file


1: D400 First line should end with '.', not 's'
1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
26: D203 Expected 1 blank line *before* class docstring, found 0
26: D208 Docstring is over-indented
26: D200 One-line docstring should not occupy 3 lines
31:41: E251 unexpected spaces around keyword / parameter equals
31:43: E251 unexpected spaces around keyword / parameter equals
31:66: E251 unexpected spaces around keyword / parameter equals
31:68: E251 unexpected spaces around keyword / parameter equals
31:94: E251 unexpected spaces around keyword / parameter equals
31:96: E251 unexpected spaces around keyword / parameter equals
31:123: E251 unexpected spaces around keyword / parameter equals
31:125: E251 unexpected spaces around keyword / parameter equals
31: D102 Docstring missing
35:5: E303 too many blank lines (2)
35: D401 First line should be imperative: 'Tokenize', not 'Tokenizes'
35: D400 First line should end with '.', not 'y'
46: D102 Docstring missing
49: D102 Docstring missing
52: D102 Docstring missing
55: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
30:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.indexer.tokenizers.BibIndexMultiFieldTokenizer
50: D203 Expected 1 blank line *before* class docstring, found 0
50: D205 Blank line missing between one-line summary and description
50: D208 Docstring is over-indented
60:41: E251 unexpected spaces around keyword / parameter equals
60:43: E251 unexpected spaces around keyword / parameter equals
60:66: E251 unexpected spaces around keyword / parameter equals
60:68: E251 unexpected spaces around keyword / parameter equals
60:94: E251 unexpected spaces around keyword / parameter equals
60:96: E251 unexpected spaces around keyword / parameter equals
60:123: E251 unexpected spaces around keyword / parameter equals
60:125: E251 unexpected spaces around keyword / parameter equals
60: D102 Docstring missing
67:5: E303 too many blank lines (2)
67: D400 First line should end with '.', not 's'
67: D205 Blank line missing between one-line summary and description
112: D401 First line should be imperative: 'Tokenize', not 'Tokenizes'
112: D205 Blank line missing between one-line summary and description
128: D102 Docstring missing
131: D102 Docstring missing
134: D102 Docstring missing
137: D102 Docstring missing
140: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2012
26:1: F401 'CFG_BIBINDEX_INDEX_TABLE_TYPE' imported but unused
31:1: E303 too many blank lines (3)
31: D203 Expected 1 blank line *before* class docstring, found 0
31: D205 Blank line missing between one-line summary and description
31: D208 Docstring is over-indented
59:41: E251 unexpected spaces around keyword / parameter equals
59:43: E251 unexpected spaces around keyword / parameter equals
59:66: E251 unexpected spaces around keyword / parameter equals
59:68: E251 unexpected spaces around keyword / parameter equals
59:94: E251 unexpected spaces around keyword / parameter equals
59:96: E251 unexpected spaces around keyword / parameter equals
59:123: E251 unexpected spaces around keyword / parameter equals
59:125: E251 unexpected spaces around keyword / parameter equals
59: D400 First line should end with '.', not 'y'
59: D205 Blank line missing between one-line summary and description
59: D208 Docstring is over-indented
68:5: E303 too many blank lines (2)
68: D401 First line should be imperative: 'Pick', not 'Picks'
68: D400 First line should end with '.', not ')'
73:5: E303 too many blank lines (2)
73: D102 Docstring missing
76: D102 Docstring missing
79: D102 Docstring missing
81:1: W391 blank line at end of file


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
33: D203 Expected 1 blank line *before* class docstring, found 0
33: D205 Blank line missing between one-line summary and description
33: D208 Docstring is over-indented
50:41: E251 unexpected spaces around keyword / parameter equals
50:43: E251 unexpected spaces around keyword / parameter equals
50:66: E251 unexpected spaces around keyword / parameter equals
50:68: E251 unexpected spaces around keyword / parameter equals
50:94: E251 unexpected spaces around keyword / parameter equals
50:96: E251 unexpected spaces around keyword / parameter equals
50:123: E251 unexpected spaces around keyword / parameter equals
50:125: E251 unexpected spaces around keyword / parameter equals
50: D102 Docstring missing
54:5: E303 too many blank lines (2)
54: D400 First line should end with '.', not 'e'
54: D205 Blank line missing between one-line summary and description
54: D208 Docstring is over-indented
60: D102 Docstring missing
63: D102 Docstring missing
66: D102 Docstring missing
69: D102 Docstring missing


1: D205 Blank line missing between one-line summary and description
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2012
29:1: E303 too many blank lines (3)
29: D203 Expected 1 blank line *before* class docstring, found 0
29: D205 Blank line missing between one-line summary and description
29: D208 Docstring is over-indented
43:41: E251 unexpected spaces around keyword / parameter equals
43:43: E251 unexpected spaces around keyword / parameter equals
43:66: E251 unexpected spaces around keyword / parameter equals
43:68: E251 unexpected spaces around keyword / parameter equals
43:94: E251 unexpected spaces around keyword / parameter equals
43:96: E251 unexpected spaces around keyword / parameter equals
43:123: E251 unexpected spaces around keyword / parameter equals
43:125: E251 unexpected spaces around keyword / parameter equals
43: D400 First line should end with '.', not 'y'
43: D205 Blank line missing between one-line summary and description
43: D208 Docstring is over-indented
52:5: E303 too many blank lines (2)
52: D401 First line should be imperative: 'Pick', not 'Picks'
52: D400 First line should end with '.', not ')'
57:5: E303 too many blank lines (2)
57: D102 Docstring missing
60: D102 Docstring missing
63: D102 Docstring missing
65:1: W391 blank line at end of file


1: D400 First line should end with '.', not 'e'
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2012
48: D203 Expected 1 blank line *before* class docstring, found 0
48: D204 Expected 1 blank line *after* class docstring, found 0
48: D208 Docstring is over-indented
121: D290 White spaces around docstring should be trimmed.
121: D400 First line should end with '.', not 's'
125: D290 White spaces around docstring should be trimmed.
125: D400 First line should end with '.', not 's'
129: D290 White spaces around docstring should be trimmed.
129: D400 First line should end with '.', not 's'
134: D290 White spaces around docstring should be trimmed.
134: D400 First line should end with '.', not 's'
138: D290 White spaces around docstring should be trimmed.
138: D400 First line should end with '.', not 's'
142: D290 White spaces around docstring should be trimmed.
142: D400 First line should end with '.', not 's'
146: D401 First line should be imperative: 'Choose', not 'Chooses'
146: D209 Put multi-line docstring closing quotes on separate line
146: D400 First line should end with '.', not 's'
146: D205 Blank line missing between one-line summary and description
146: D208 Docstring is over-indented
151: D401 First line should be imperative: 'Choose', not 'Chooses'
151: D400 First line should end with '.', not 'n'
151: D205 Blank line missing between one-line summary and description
151: D208 Docstring is over-indented
159: D102 Docstring missing
169: D102 Docstring missing


1: D200 One-line docstring should not occupy 2 lines
4: L102 copyright year is outdated, expected 2015 but got 2012
23:6: E126 continuation line over-indented for hanging indent
28:1: E303 too many blank lines (3)
28: D203 Expected 1 blank line *before* class docstring, found 0
28: D208 Docstring is over-indented
28: D200 One-line docstring should not occupy 3 lines
33:41: E251 unexpected spaces around keyword / parameter equals
33:43: E251 unexpected spaces around keyword / parameter equals
33:66: E251 unexpected spaces around keyword / parameter equals
33:68: E251 unexpected spaces around keyword / parameter equals
33:94: E251 unexpected spaces around keyword / parameter equals
33:96: E251 unexpected spaces around keyword / parameter equals
33:123: E251 unexpected spaces around keyword / parameter equals
33:125: E251 unexpected spaces around keyword / parameter equals
33: D102 Docstring missing
35:49: E127 continuation line over-indented for visual indent
36:49: E127 continuation line over-indented for visual indent
37:49: E127 continuation line over-indented for visual indent
40:5: E303 too many blank lines (2)
40: D400 First line should end with '.', not 'e'
40: D205 Blank line missing between one-line summary and description
57:5: E303 too many blank lines (2)
57: D400 First line should end with '.', not 'r'
62:5: E303 too many blank lines (2)
62: D205 Blank line missing between one-line summary and description
62: D208 Docstring is over-indented
71:1: W391 blank line at end of file


1: D100 Docstring missing
4: L102 copyright year is outdated, expected 2015 but got 2012
20:1: E302 expected 2 blank lines, found 1
20: D103 Docstring missing


24:1: E402 module level import not at top of file
25:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
25:1: E402 module level import not at top of file
81:28: E261 at least two spaces before inline comment
89:1: E302 expected 2 blank lines, found 1
93:8: E111 indentation is not a multiple of four
94:8: E111 indentation is not a multiple of four
95:8: E111 indentation is not a multiple of four
96:8: E111 indentation is not a multiple of four
97:8: E111 indentation is not a multiple of four


This can be:

```c
char_u *p = get_var_value((char_u *)"g:colors_name");
```

To amortize the increase in lines a bit I believe :).

Didn't do in-depth review (e.g.: checking out `load_colors()` to see if we can somehow simplify this more).


No, I didn't know about it.  I followed what we do for `$~`.  I can revisit though.


I think tokens are more usually said to "expire" than to "time out". Timeout is something that actions do, while expiry sounds a bit more passive to me. Anyway, it's not important in enough for me to seriously debate this, so if you want this changed, I can change it.


You're relying on the fact that ```${path}_capture``` will sort before ```${path}_primary``` right?

While true, it seems kinda sketchy.


@wburns, do you happen to know the answer to this?


Not sure I understand.

Do you have a patch to illustrate?

On Fri, Mar 13, 2015 at 10:22 AM, Vern <notifications@github.com> wrote:

> #BUG
> This is a copy and paste bug!
> Explanation of Dummy Read
>
> Please note that during the explanation of the algorithm we will make
> reference to a “Dummy Read”. This
> read is not a true read of the I2C bus, but is a read of the IICD register
> in the IIC block. It will not be seen
> on the bus or in any I2C specification because it is internal to the
> design of the I2C hardware block. The I2C hardware block includes a state
> machine that will perform an IIC byte transfer on the bus each time the
> IICD register is written to or read. The first byte (I2C device address) is
> sent out when the I2C address value is written to the IICD register. Once
> this has been written out then it needs the Dummy Read to initiate the
> transfer of the next byte. Note that it is a Dummy Read because there is no
> real data in the IICD register yet because the hardware has not actually
> done the transfer. Throughout the text of this document you will see
> references to the “Dummy Read” this is an artifact of the implementation of
> the I2C controller block in the host MCU.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Freescale/linux-fslc/commit/1d5ef2a83e3097408924b5eea8d7750bbde21e45#commitcomment-10184985>
> .
>


Subtle


画像ファイルが正しくコミットされているか確認していただけますか？
3ファイル削除のみで追加されていないように見えます。


It would probably be better to link to [issues where target release = 2.6.1 and tracker type = Issue](https://pulp.plan.io/issues?utf8=%E2%9C%93&set_filter=1&f%5B%5D=cf_4&op%5Bcf_4%5D=%3D&v%5Bcf_4%5D%5B%5D=2.6.1&f%5B%5D=tracker_id&op%5Btracker_id%5D=%3D&v%5Btracker_id%5D%5B%5D=1&f%5B%5D=&c%5B%5D=project&c%5B%5D=tracker&c%5B%5D=status&c%5B%5D=priority&c%5B%5D=cf_5&c%5B%5D=subject&c%5B%5D=author&c%5B%5D=assigned_to&c%5B%5D=cf_3&group_by=).

This really should be added to the conf file https://github.com/pulp/pulp/blob/master/docs/conf.py#L266 but that is really part of [story 731](https://pulp.plan.io/issues/731).


i i  oi oi oi oi;oi ;o i ; UW; OIUWLKkkkl KJL KJ; OI


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/12703/testReport/) for this commit**


spacing around the "+" operator


Temporary for testing storing pieces in the Board.


@mrock77 このコミットでも画像ファイルのpngが反映されていないようです。


Separate from the bugfix links, I think adding a note that the upgrade and uninstall now stops the pulp_celerybeat, pulp_resource_manager, and pulp_workers would be good since that is release note worthy.


also we should replace
```
var cmd = ['node', path.join(__dirname, 'background.js'), '--',  data ];
```


A tag `link` é orfã. Deve ser fechada com `/>`


To avoid upgrading on every 'provision'.


Doh, thanks! Messed up there when updating the doc. Fixed in https://github.com/kripken/emscripten/commit/7b6d5c301c8d28199b3abdab820e49d5db633d05 .


It is better. I guess in my head I would have preferred that the knowledge that the setting is AUTHSERVSSLNOPEERVER was in the function that needs it and the global config be more like:

    #define DEFAULT_AUTH_SERVER_TLS_PEER_VERIF 1 /* true */

And then at the place it's consumed turn that into the 0. It's easier to reason without the double-negation ("No Peer Verification must be off")


How can I run this testcase? Without this, *all* sorts of things go wrong (naive path concatenation when building GCC for example).


Well nothing in the sim happens concurrently, and `ChangeState(self, self.DeadState)` is called later in the function, so it should be okay.

I am not sure of the semantic difference between `KillThread` and `thread:Destroy()`, if there is any. It could well be that the coroutine is allowed to finish when using `Destroy()`, but it would be a bit weird.


Project Final Deliverables


This method only tests file filters so I would make this explicit in the name.


Ah, I get it.  My exception text is ending up in the output caught by the text.  I probably have it going to stdout and not stderr.  Thanks for the comment (and the mal project)!


아하~ 이렇게 하면 되는거였군요.


right, thx!


missing }).then(....


Código bem comentado. Só fiz um comentário lá embaixo, mas no mais está muito bom.


r+


Have you installed a fresh package of the development version or you just applied the code here?


I originally thought so too, but if `custom_properties` exists in `app.profile` already, then it's impossible to remove properties. This makes sure `custom_properties` dict is reset every time.


Katzgrau said:
> Out of curiosity, what's the justification for app name?

One of the justifications for having an app name is logs generated by the same server which is serving different apps. Especially if one is not making (correct) use of custom file names, having an appname included in the log files allows for differentiating between these different logs.

Secondly, trying to follow the [OWASP Logging Cheat Sheet](https://www.owasp.org/index.php/Logging_Cheat_Sheet) which states:
"The application logs must record "when, where, who and what" for each event."

We have:
WHEN and WHAT but we're missing a WHERE and WHO. Where = applicationName and WHO = hostname. Perhaps we could rename hostname to SOURCE or something similar? Allowing to pass either a hostname or source_ip address or something similar?

I remember when I started working on this that @richjenks is working on shortcode/templating but I was too far in to hold off on this PR.

Katzgrau said:
> In the way the app name and hostname are currently embedding in the log line, there would be extra > whitespace left over if the getAppName and getHostname function did return null.
That gets resolved by Line 202 in Logger.php:
`$message = preg_replace("/[[:blank:]]+/"," ", $message);`

I do realise that might screw up formatting of the logLine which @richjenks is working on but we'll have to see then if we can resolve this somehow.

Katzgrau said:
> Thanks for the tests - it would need some docs too
I've added some PHPDoc blocks in the LoggerTest. I can't seem to find any other place where you've documented the tests so far so let's call this a start.

I can agree waiting until @richjenks is submitting his changes but happy to hear you like the idea! :+1:


Ok


@ hellowlol. Thanks for you help! I think I nailed it:D. Please correct me if i dropped the `var s = moment` on the wrong place of the code. At least it's working now.
![1](https://cloud.githubusercontent.com/assets/3150962/6639391/76f15ff8-c98f-11e4-82c0-3a38d6c3814b.jpg)


`values[i] = &names[i]`


It might make sense to put the part of code which is not relevant to android in the else block.

Also, make sure the code formatting matches the existing code.


'+'escape問題が解決したわけではないです。cgi引っ越しで動かなくなってた箇所の変更です。


1) Ok
2) You're right, this is actually pretty dodgy. Will fix.


less points for using switch case :-1:


saw approval from jdm
at https://github.com/yodalee/servo/commit/bfdafc0faf7f77fdd664056f6ebf674a72a3be52


merging yodalee/servo/issue4768-textencoder = bfdafc0f into auto


yodalee/servo/issue4768-textencoder = bfdafc0f merged ok, testing candidate = 9814a481


-1
`div` tem que ser fechada com `</div>`


Yeah, that may be more helpful.


Ah, good stuff. I missed that one - I got here directly from the [comment on your blog post](https://www.dotdeb.org/2015/02/08/mysql-5-6-23-for-wheezy/#comment-34459).


We do that as part of the output for variant calling, so don't duplicate it here. All of the stuff that feeds in here from bcbio will be pre-normalized and flattened.


Not sure. One the one hand, this is a bit silly, on the other hand, I don't like mixing do-notation and `>>=`


typo:
One of the requirements of the Summer of Code is that you are a two-person team.


Are you sure about the version of seo-bundle ? Cause I get an error with composer :
'sonata-project/page-bundle dev-master requires sonata-project/seo-bundle ~2.0@dev -> no matching package found.'

Thanks.


Good question - I'm not really sure. I was going to use `default=False`, but saw the above line.


.calc-row:not(:last-child)
{
	margin-bottom: 10px;
}

#question
{
	margin-top: 50px;
	font-size: 60px;
}

#answer
{
	margin-top: 30px;
	font-size: 60px;
}

.container
{
	max-width: 700px;
}


J'ai fait cela dans l'optique que Fireball soit créé par Firelord. J'avais besoin que Firelord sache sur qu'elle Map il se trouve. Après peut être serait-il intéressant que se soit Map qui crée Fireball pour Firelord, dans l'approche logique cela me parait un peu étrange mais peut être plus digeste au niveau du code ?


Yep, this needs changing.


got it. just made sure we weren't recommending something you had ruled out.

On Fri, Mar 13, 2015 at 7:46 AM, Brad Chapman <notifications@github.com>
wrote:

> We do that as part of the output for variant calling, so don't duplicate
> it here. All of the stuff that feeds in here from bcbio will be
> pre-normalized and flattened.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chapmanb/bcbio-nextgen/commit/741dfd2ef831a249add77f3c1a8f930ffa8c702b#commitcomment-10185460>
> .
>


Crap, I think you are right. Cheers for picking up on this!


I don't understand. This is `Frontend.Pages.mainPage`?


April 14th is a Tuesday! :)