> We don't want to encourage using the same wildcard certificate for production, staging and development environments

@jabley would it be possible to make this clearer in the manual - I only found it by trawling the commit history.


I see. Well, in that case, I agree with removing the warning from the player, but maybe we should keep the note in the manual for now.


I'm pretty sure this and the getter require a mutex. there's a race. the rest of the object should use `GetReporter()` when getting the reporter to give to streams.


reviewing my own PR, but the '&&' there are not really necessary since I am running `set -o errexit` (aka `set -e`), but they don't hurt.


Нет, это со мной что-то не так...
Не хватает функций add и roll.


Alright, fixed readme.


I guess I'm more curious what happens when a before/after actually throw an exception.  That's what would happen if an assert fails, for example.


bfd


Извини, если ошибаюсь, но по-моему ты не те скобки поставил (местами).


But this doesn't.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13451/testReport/) for this commit**


good point.


HTML5 아웃라인을 결정짓는 섹션닝 태그는 헤딩으로 제목을 주어야 합니다.

![2015-04-01 9 01 33](https://cloud.githubusercontent.com/assets/1835204/6931931/09b61ca8-d84e-11e4-805f-ac9bfbee3b1f.png)


Why you removed this part?


Prefer to handle it as soon as I know I can do so. Also it's needed for `t.Save(c)` anyway.

More broadly, I dislike the idea of having data structures with potentially uninitialized fields. I might rewrite this to decode into an `UpdateTodoReq` struct, then have something like `func (t *Todo) Merge(u UpdateTodoReq)`, but it seems like a bunch of extra code for a small app.


Yes thank you for catching that.


may be use is_writable for directory?


ack. Removed most ad-hoc logging.


I will when I get off from work lol


Fixes #201.


getSDKClassLoader is not the issue (I hope haha), it just gets the relevant class loader from a map, the issue was line 83 which is now loadCustomClass


I'm reluctant to make everyone (users of intTypes) pay for #include<map> until IntIntMap occurs in more than one place.


how about `WriteLearnJSON`


You should upload small real book as example.


접근성 측면에서 반복되는 메뉴 영역을 건너뛸 수 있는 바로가기가 있으면 좋겠습니다.


This feels like a quibble. I like seeing the path prefix to an API up in the consts stanza of the file.


클래스 이름이 main인 것을 보면 이 영역은 페이지의 메인 콘텐츠 영역입니다. 이럴 때는 `<main>` 태그를 사용할 수 있습니다.


Yes, that's fine.


optparse is deprecated since python 2.7, use argparse instead.


Good job on this Lari... thanks for all your work


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13452/testReport/) for this commit**


90179004-ConstrNumBackNotInitializedComplexGlazing (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1675 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


oh, about !faq list, i was going to make it automatically detect what's currently in FAQ with the local faq = { .. } table


Ok, I just made lodash usage much thinner by only importing the specific bits that I need and only importing it if you specifically need it.

https://github.com/lookfirst/gulp-helpers/commit/7c135d0ce891258a28d62d0fad864ce2a4c8f7a3


체크박스는 `<label>` 태그를 사용하여 `다시 보지 않음` 영역을 클릭해도 체크박스 컨트롤이 되도록 하는 것이 좋습니다.


It is better to avoid using `git add .`, which may accidently add a lot of files to the repository.

You can use `git status` to check what will be checked in.

Besides, I usually run Sourcetree GUI on the side even I will mostly use commad-line, which is quite helpful and has both Mac/Win version. I do not know a nice git GUI for Linux though.

FYI, @superxiao.


I don't think AppDomains are in CoreCLR.


토글 기능은 페이지의 이동이 발생하지 않기 때문에 `<button>`을 이용하여 마크업하는 것이 좋겠습니다.


I'm only able to buy 7 items per purchase. Is this intended?


this is a general improvement that uses the normal error thrown by mkdir and adds more information. it is not only for the writeable case.


I don't think we've said yea or nay to Mongo 3.0 yet. I would put this commit on another branch. The PR for the image fix looks good, so if you leave that on its own branch and PR it I'll merge it.


상세 토글 역시 마찬가지로 `<button>`이 좋겠습니다.


This should be `NEWLINE`, not `\n`


sgtm


We should maintain the assertion that the final delimiter is not in the `+newlineCharacterSet`.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1166 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


90179004-ConstrNumBackNotInitializedComplexGlazing (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


iteration (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2173 of 2196 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.95%25-yellow.svg)


in Go we try to put important things first, which tends to be types but not all of them.

In this case the notFound and badRequest types are really auxiliary and not important to understand the rest of the code, same for errorHandler


@yunshao04 SONG_DEF has been totally removed from UI.


it is also dangerous. but yep, we can make it support infinite loops with a 0 if you like. its forbidden in sandbox mode


check /etc/yum/olpc-exclude for NetworkManager being listed.


`선택` 텍스트는 `<label>`을 이용하여 체크박스와 연결 시켜주는 것이 좋겠습니다.


Great. I neglected to include the localstorage, I only included the backbone.localstorage file and I thought that would suffice. Can't tell you how many times I re-worked the code last night! Overall, your writing style is very clear (even reminding people to insert commas between properties), but that part was a bit vague.


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1233
success: http://build.servo.org/builders/linux2/builds/1231
success: http://build.servo.org/builders/android/builds/1267
success: http://build.servo.org/builders/mac1/builds/1446
success: http://build.servo.org/builders/mac2/builds/1449
success: http://build.servo.org/builders/gonk/builds/413


`<label>`에 텍스트가 없습니다. 이것 역시 `중요`라는 텍스트를 `<label>` 안으로 넣는 것이 좋겠습니다.


Is this the same as the method `either` that is there already?


r=jdm


Excelente sólo faltó el tag jajaaj


`<span class="icon"></span>`에 텍스트가 없습니다. 스크린리더 사용자는 이 아이콘에 들어간 정보를 알 수 없습니다.


Does beanutils have additional commons dependences with higher versions than currently in pom.XML?


`zoom`과 `new-window`도 위와 마찬가지입니다.


Right. Good catch.


fast-forwarding master to auto = b20cc69a


This looks good to me. Thanks!


시간을 나타내는 곳에 HTML5 `<time>` 태그를 고려해볼 수도 있겠습니다.


I like it.
But in this case, _mysqlConn is an auto_ptr (don't really want to share this thing), which doesn't implement that operator.


Looks good :)


that is great - much better than the one I tried to map out.  thanks!


saw approval from jdm
at https://github.com/mbrubeck/servo/commit/9cd976a4e74825f45eee28a21ad9f90ad4b1ae90


merging mbrubeck/servo/yodalee-issue4768-textencoder = 9cd976a4 into auto


mbrubeck/servo/yodalee-issue4768-textencoder = 9cd976a4 merged ok, testing candidate = f86d18c5


`sans-serif`와 같은 기본 글꼴을 fallback으로 적어주는 것이 좋습니다.


Please use the awesome requests library instead.
http://docs.python-requests.org/en/latest/


`<p>` 태그는 문단을 나타내는 태그인데 전체적으로 margin과 padding을 없애는 것은 적절해 보이지 않습니다.


Note: This means that "prime repository" is now defined before the term is used.


Dead code, right? Can remove this.


porque adicionou segundo passo de novo?

por sinal,  sengundos tá escrito errado


I have the same files as you in my /usr/local/lib/ directory and they also exist in my /usr/lib directory as well.   I can see the linked files by the colors in my terminal.  I am stumped.  I know this is a good clean install of Fann-2.2.0 as I can run the maketests example and all is OK.

From: tty02-fl
Sent: Tuesday, March 31, 2015 4:25 PM
To: FutureLinkCorporation/fann2
Cc: jfperez
Subject: Re: [fann2] fixing issue #6 -- bumping version (beb24b3)

In ubuntu 14.04 you can use /usr/local/lib/ and also can create links in /usr/lib/
This what I have in my OS before install with pip.
lrwxrwxrwx 1 root root 18 ago 7 2014 /usr/local/lib/libdoublefann.so -> libdoublefann.so.2
lrwxrwxrwx 1 root root 22 ago 7 2014 /usr/local/lib/libdoublefann.so.2 -> libdoublefann.so.2.2.0
-rw-r--r-- 1 root root 126928 ago 7 2014 /usr/local/lib/libdoublefann.so.2.2.0
lrwxrwxrwx 1 root root 12 ago 7 2014 /usr/local/lib/libfann.so -> libfann.so.2
lrwxrwxrwx 1 root root 16 ago 7 2014 /usr/local/lib/libfann.so.2 -> libfann.so.2.2.0
-rw-r--r-- 1 root root 126927 ago 7 2014 /usr/local/lib/libfann.so.2.2.0
lrwxrwxrwx 1 root root 17 ago 7 2014 /usr/local/lib/libfixedfann.so -> libfixedfann.so.2
lrwxrwxrwx 1 root root 21 ago 7 2014 /usr/local/lib/libfixedfann.so.2 -> libfixedfann.so.2.2.0
-rw-r--r-- 1 root root 83295 ago 7 2014 /usr/local/lib/libfixedfann.so.2.2.0
lrwxrwxrwx 1 root root 17 ago 7 2014 /usr/local/lib/libfloatfann.so -> libfloatfann.so.2
lrwxrwxrwx 1 root root 21 ago 7 2014 /usr/local/lib/libfloatfann.so.2 -> libfloatfann.so.2.2.0
-rw-r--r-- 1 root root 126927 ago 7 2014 /usr/local/lib/libfloatfann.so.2.2.0

—
Reply to this email directly or view it on GitHub.


Oh, bother.  Stoopid auto_ptr...


What are the critical changes in ```cache.ml```?


I know but from what you tell me the Pdf version is already outdated? Page ii indicates that the publishing date as 2015-01-05. Surely, that's the most recent 1? I got my current code to work using Marionette 1.7.


Can you highlight in this commit what diffs are useful to observe? It's tough with all the formatting changes.


`cursor` 속성이 사용되었다면 뭔가 내가 적합하지 않은 태그를 사용했다는 조짐일 수 있습니다.
예를 들어 키보드 초점을 받을 수 없는 태그에 단지 `onclick`만을 사용했다든지.


`:hover` 가상 선택자를 사용했다면 `:focus`도 함께 사용해 주는 것이 좋습니다.


would `isreal(kernel)` also work?


90179004-ConstrNumBackNotInitializedComplexGlazing (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1675 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


yay. I did wonder about this.


rename f to directory or something else that conveys a meaning.


s/BError/Error/

(I think)


Porque era importante para o processo de fervura.

Em 31.03.2015 21:27, Mauricio Borges Silva escreveu:

> porque adicionou segundo passo de novo?
>
> por sinal, sengundos tá escrito errado
>
> --
> Reply to this email directly or view it on GitHub [1].

Links:
------
[1]
https://github.com/ThiagoRuis/proto-cookbook/commit/4d7fca572f71db8d90b9f6ed8e2c4650e1960427#commitcomment-10508281


The error message it prints now is misleading. I'll figure out how to squelch it for the next version of npm. That just means it wasn't able to clone the repo publicly, and is going to fall back to trying to clone via an ssh repository URL.


From the book: `inv = addToInventory(inv, dragonLoot)` Changed since the function does not return any values.


You can prob remove this now.


If you're not doing anything with the exception remove the as e part.
Also decode('utf-8') might throw a UnicodeDecodeError.


Why not just do the CAS here?


@tmat correct.  The appropriate replacement API here comes from `AppContext`.  But that is only available in 4.6 hence it can't be used here.  This will quickly be switched to `AppContext` once I merge this change into the core CLR branch.


First thing I want to confirm is that this actually is *not* used anywhere? I'm assuming that the way you got the system/os level locks working is based on your AsyncLock class in some magical way? (which I'd love to know how it works in plain english ! ) I read your notes about 'Global\' prefix, etc... but it seems were not using that either. In any case if you can explain how this works it would be great.

Then my advise would be to remove this FileSystemHelper if we aren't using it. If we need to use it for something, we need to rename it to be more specific (regarding OS level locks or something), then interface it and make it a single resolver so it can be replaced in case we need to run on Mono or something.


This is bad-style. It will even catch the KeyboardInterrupt Exception (strg+c). Please be explicit about the kind of exceptions that your catching.


Changed from `displayInventory(inv)`


```ruby
    - env: rails=3.2.0
      rvm: 2.2
```


선택자가 너무 상세한 것이 좀 마음에 걸립니다.
css 선택자는 상세할 수록 우선 순위가 높아지므로 필요해 의해 스타일은 재정의해야 할 때 선택자를 너무 상세하게 사용하면 힘들 수 있습니다.


Gotcha, wasn't sure about the syntax


Fantastic! Does 3p tomorrow work?

> On Mar 31, 2015, at 5:02 PM, Luke Cycon <notifications@github.com> wrote:
>
> First stab at enumerating the refinements
>
> @ranjitjhala
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/UCSD-PL/tournament/commit/c144acc76a191144699a4b990c12c4351aeb0f50


`dialog_field_check_box` seems to suggest: `:refresh_json_value => {:checked => true}`

Also, is it possible to just use a `DialogFieldCheckbox` here? One that was not saved to the database? But we know returns the correct values?


Literally any other time besides 3-4 :P
On Mar 31, 2015 5:38 PM, "Ranjit Jhala" <notifications@github.com> wrote:

> Fantastic! Does 3p tomorrow work?
>
> > On Mar 31, 2015, at 5:02 PM, Luke Cycon <notifications@github.com>
> wrote:
> >
> > First stab at enumerating the refinements
> >
> > @ranjitjhala
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/UCSD-PL/tournament/commit/c144acc76a191144699a4b990c12c4351aeb0f50
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/UCSD-PL/tournament/commit/c144acc76a191144699a4b990c12c4351aeb0f50#commitcomment-10508365>
> .
>


replace f, as above.


Thanks. I meant it to match the filename, but clearly mangled it.


I'm not to sure about this, but are you just actually posting some text?


90179004-ConstrNumBackNotInitializedComplexGlazing (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1676 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Can't we switch master to 4.6?


yes @kenyany it isn't installing. Doesn't fail the build per-se... however the dependency is MIA


Make the path to the directory repository configurable via argparser.


Or not yet, until we have working CoreCLR build?


Added default sound in app delegate for notification for Issue #20 Should the Ceaseless notification play a sound?


I'm having to force `v2.7.3` in the interim.


couldn't you just do:

```ruby
automated_hash["value"].to_s.presence || initial_values
```

or

```ruby
automate_hash["value"].blank? ? initial_values : automated_hash["value"].to_s
```

I dunno. the `return` statements get me.
(don't need to make this change. Just saw that you were changing the line...)


Can you explain why you chose 3 as the value to set for the bond energy? I'm curious, because before you set it for 450 and in the original the initial value was something else. I'm interested in your thinking about how you chose that number.


I can't test the joystick code since I don't receive any joystick events, so I hope it works fine. It should output a number between -1.0 and +1.0 in the upper left corner of the display depending on how the device is tilted.


Good idea.


Thanks for the fix!


Thanks for spotting that mate. Semi-colons, a coders nightmare. :)


CIAADRVUART_ENABLE_FUNCIONALITY is defined in ciaaDriverUart_Internal.h, so it should be included first


great solution! thanks ;)


Part of #63


Need to communicate to backend that retryNumber starts from 1 rather than 0.


Out of curiosity (I'm still learning about this stuff) what's the reason for the change from the `list` function? Other than that looks good to me! :+1:


seems odd that asking `what are the values` has side effects like this.
The `refresh_button_pressed` seems like it is stating that an action is being performed.
This one seems a little different.

All in all, I really like the `refresh_json_value` pattern.
Passing the `checked_value` into here throws me a little. I was expecting it to be like the other implementations with no parameters. (I do see why it is passed in, but I would have thought that the `checked_value` would be stored in `values` or something and not passed into this method.

Of course, this inconsistency isn't really introduced by you. It just really stands out for me.

Also, `refresh_json_value` seems to contain `:checked => true` in others. `:checked_value` seems a little off here and the total list of values (think that is what is in `refreshed_values`) is just plain different.
maybe voice is a better medium here.


I can't reproduce this, @naterkane, so if you could run an install with that with `--loglevel=silly` on the command line and then upload it as a gist, it would help me figure out what's going on here.


Could you change this to test `"456"`. All the other tests here test the default value.


90179004-ConstrNumBackNotInitializedComplexGlazing (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (658 of 659 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-4.88%25-green.svg)


This require is a bit sucky. I want to change it to a YAML load, but I'll need to convert the whole of elizadata.js to YAML first... :/


verify for my understanding: `default_value` has to be in this list of values?


You still need the `ElasticSearchAPIClient.` before `APICall`. Same for `APICallback` below. Both `APICall` and `APICallback` are nested classes inside `ElasticSearchAPIClient`.


Yep :+1:


This is fine but who will be using this? These states should be rkt specific and more or less internal. It's ok to print them to the user in `rkt list` but that's about it. rkt should be free to change them at will.


ご指摘ありがとうございます。修正します。
未送信WALの扱いをどうするかは、運用ポリシーによると思う(ディスク使用率の閾値で削除する？定期的に削除する？など)ので、難しいところですね・・・。


some tests failed:
failure: http://build.servo.org/builders/linux2/builds/1232


I thought you were going to call this `dynamic_field_refresh` and make it public.
And put in `alias_method :dynamic_date_refresh, :dynamic_field_refresh` (3 times) for backwards compatibility.


Why the change?


this is pretty sweet :+1:


Sure.
That's a lot of ~~crap~~ code replication there.
The next step on re factoring is abstract that logic.


I've tried with the black arrow. It doesn't work with the calendar. It makes a mess. It's difficult to have so much details in 16x16 and on top of that, it has to look like it comes from the same icon family.
I'm not too worried about active sorting, 3D button, only one arrow at a time, etc. Something will work.


saw approval from Ms2ger
at https://github.com/jdm/servo/commit/883ba03bb92b4bd46fb4154e7c1572b99786f6ac


Append ?=w1 to the url of this page to get the diff that ignores whitespace changes...much easier to read. And yes, this entire commit can be ignored as dead code.

My commits on the 2/24 and 2/26 are more meaningful. I wanted a purge function to delete all keys in a bucket so I wrote that. I didn't write a proper test but I did exercise that code and found it worked.


merging jdm/servo/avoidoom2 = 883ba03b into auto


jdm/servo/avoidoom2 = 883ba03b merged ok, testing candidate = 15edd07e


Fixes #1


Great, thanks! Looking over, will cherry pick commits of interest when done.


Sweet, thanks!


send the PR :-)


Ran in to the same problem with the same fix :+1:


@unclebilly yes, there is some redundancy at the moment. I'll change it to only use the envar.
The concern we had was that we don't make it obvious when things are not supported. I will add a comment in the code that support was added in 1.1, we can then rely on the error messages which are more useful than I thought they'd be.
When you ask for an infoblox version that isn't supported:
`/opt/boxen/rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/infoblox-0.2.17/lib/infoblox/connection.rb:82:in `block in wrap': Error: 400 Version 10 not supported (Infoblox::Error)`

When you ask for an object that doesn't exist in the specified WAPI version:
`/opt/boxen/rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/infoblox-0.2.17/lib/infoblox/connection.rb:82:in `block in wrap': Error: 400 { "Error": "AdmConProtoError: Illegal object type (fixedaddress)",  (Infoblox::Error)`

This is similar for non-existent methods.


I was also hoping radio could get into here too. But I guess that one parameter is a wrench.

I also don't see how you cold pass in field / other as a parameter into here.


Should be translated, not left blank


Just saw the elisp info page for backquote list splicing -- makes sense.


@eyakubovich I am using it in kubelet.

Context:
https://github.com/coreos/rocket/issues/669

kubelet likes to know the state for the containers. We can still change the state in rocket at will. This just provides kubelet a way to synchronize with the upstream.


Made local site work without Keen plugin. Revert if there is an issue with Heroku.


Fixed.


This revision is clean.


Storing the whole task list $id_list in the SESSION???? This looks quite dangerous for memory usage and unnecessary for big installations and for users with several browser tabs and several projects...
We have to find out why it was done, and if currently needed how we can get rid of it without breaking anything.

So we have the $id_list in memory several times. one time in get_task_list, in $tasks, and a bit persistent (n * current users online)  in $_SESSION..?


What does this actually 'fix' the achievements pane is a 2d scape..


Might save a lot of code to just inherit from DisposableObject and then override DisposeResources (and/or DisposeUnmanagedResources if you have unmanaged bits). DisposableObject does all of the underlying disposal logic for you.


This information could be replaced by the following ```help``` in ```add_option()```.


╮(╯_╰)╭
66666666666666666666666666666666 de bu xing


teste

On Tue, Mar 31, 2015 at 9:34 PM Ruis, Thiago <notifications@github.com>
wrote:

>
>
> Porque era importante para o processo de fervura.
>
> Em 31.03.2015 21:27, Mauricio Borges Silva escreveu:
>
> > porque adicionou segundo passo de novo?
> >
> > por sinal, sengundos tá escrito errado
> >
> > --
> > Reply to this email directly or view it on GitHub [1].
>
>
>
> Links:
> ------
> [1]
>
> https://github.com/ThiagoRuis/proto-cookbook/commit/4d7fca572f71db8d90b9f6ed8e2c4650e1960427#commitcomment-10508281
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ThiagoRuis/proto-cookbook/commit/4d7fca572f71db8d90b9f6ed8e2c4650e1960427#commitcomment-10508332>
> .
>


Use space between heading levels and titles, e.g.: `#### Install Dat`.


See notes above about DiposableObject, generally anytime I am implementing IDisposable without inheriting from a real object I always use DiposableObject since it saves quite a lot of boilerplate code


Use conventional [markdown syntax](https://guides.github.com/features/mastering-markdown/#syntax) for ordered lists, e.g.: `1. Alternatively ...`.


I'm not sure if these image paths are correct. Looking at the other pages, I think they should be `releases/images/*.png` since the images are stored at e.g. http://pinta-project.com/releases/images/ubuntu.png


ditto.


I think the second half of this condition can never be true.


Apart from the minor formatting issues indicated above, excellent work on documenting this example!


You mean to say can never be _false_, right? Yeah, I'll remove that.


Lankbank File


What's the process for updating this file?  Internally we maintain a similar list (MSFT aliases to Git Commit E-mail addresses) it would be good if we could share information.


Yes. Sorry.  Thanks!


Hello
I do not found develop branch in github.
Which branch should I git pull from it?

Thanks,

On Tue, Mar 31, 2015 at 5:17 PM, Jiashuo Li <notifications@github.com>
wrote:

> @yunshao04 <https://github.com/yunshao04> SONG_DEF has been totally
> removed from UI.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZijinZheng/iRobotGUI/commit/9646be5c2c06da24677fbff9349beefca6b2f37b#commitcomment-10508197>
> .
>

--
Hanadi Mardah

Master Student
Computer Science - Software Engineering
University of Southern California


Ah, I didn't know about that.
In that case we should share the mapping file.
I was presuming we just update this file as and when the port tool is unable to add TFS user info to checkin comment. It should be a trivial and rare update once we know the missing user info.


returning jsval from a xpcom interface is fine, but using this API from C++ is kind of a pain.


single line? (ok with saying no here :) )


It looks ok to me ...  though I'm not a Docker guy and I haven't tested it.


Did you ever get puma running in the background?? If so, how did you do it?

Thanks.


This is part of what gave me trouble- I wasn't familiar with 'componentsSeparatedByString' - can I read materials that give me a list of this? I feel a little badly that I don't know this


Just added Keen plugin back to local site index.html file ee69314a11c0c4271c158a9b4e140dc56a80c310 Now local site with or without Keen plugin should all work.


You mean typing ! Faq or doing it in the menu?


is it only `"DialogFieldRadioButton"` or `"DialogFieldDropDownList"`? Is it ever something else?
maybe put this into an `else` ? Would it make more sense to have `if field.type == "DialogFieldDropDownList" ... else ...` with no second if?


Thanks Steve. I'll build psl locally.
Do you have these branches slg13 and akbc13?


Fixed typo errors


Looks wrong?


I'm not sure about this one, but looking at all the production .vhost files, they all follow the convention of using

```apacheconf
<VirtualHost *>
```

instead of

```apacheconf
<VirtualHost *:*>
```


@bors: retry

#5207


This doesn't seem right. Are you sure you need to NOT do this ?


is it possible to move this out into static javascript and just call the helper method?
(this may be way too much here, but something to keep in mind for the future)


Apparently, I can't fucking spell.


Need help unblocking sites and getting rid of proxy without letting people know


Missing tab


thanks for not dynamically deriving partial name from `field.type`. Way too hard to change. too brittle


twrp.fstap is not ready at all


would it make sense to have both in here.
and just show/hide the edit regular by setting a class instead of round tripping the server?
(probably a future thought)


From release-TRR, thanks.
On Mar 31, 2015 6:21 PM, "Hanadi O Mardah" <notifications@github.com> wrote:

> Hello
> I do not found develop branch in github.
> Which branch should I git pull from it?
>
> Thanks,
>
>
> On Tue, Mar 31, 2015 at 5:17 PM, Jiashuo Li <notifications@github.com>
> wrote:
>
> > @yunshao04 <https://github.com/yunshao04> SONG_DEF has been totally
> > removed from UI.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/ZijinZheng/iRobotGUI/commit/9646be5c2c06da24677fbff9349beefca6b2f37b#commitcomment-10508197
> >
> > .
> >
>
>
>
> --
> Hanadi Mardah
>
> Master Student
> Computer Science - Software Engineering
> University of Southern California
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZijinZheng/iRobotGUI/commit/9646be5c2c06da24677fbff9349beefca6b2f37b#commitcomment-10508726>
> .
>


Would the comparison not already be done inside the ColorByScalarCombox ?


From release-TRR, thanks.

On Tue, Mar 31, 2015 at 6:31 PM, WuyiQin <notifications@github.com> wrote:

> From release-TRR, thanks.
>
> On Mar 31, 2015 6:21 PM, "Hanadi O Mardah" <notifications@github.com>
> wrote:
>
> > Hello
> > I do not found develop branch in github.
> > Which branch should I git pull from it?
> >
> > Thanks,
> >
> >
> > On Tue, Mar 31, 2015 at 5:17 PM, Jiashuo Li <notifications@github.com>
> > wrote:
> >
> > > @yunshao04 <https://github.com/yunshao04> SONG_DEF has been totally
> > > removed from UI.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/ZijinZheng/iRobotGUI/commit/9646be5c2c06da24677fbff9349beefca6b2f37b#commitcomment-10508197
> > >
> > > .
> > >
> >
> >
> >
> > --
> > Hanadi Mardah
> >
> > Master Student
> > Computer Science - Software Engineering
> > University of Southern California
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/ZijinZheng/iRobotGUI/commit/9646be5c2c06da24677fbff9349beefca6b2f37b#commitcomment-10508726
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZijinZheng/iRobotGUI/commit/9646be5c2c06da24677fbff9349beefca6b2f37b#commitcomment-10508802>
> .
>


[ !faq list ] will get the table local faq = { .. }, and print whatever is in the table

such as:
whuppo: !faq list
(to calling player)
FAQ: Available FAQs:
- whuppo
- faq1
- faq2
- sirrfuchs
- faq3
- list

etc. etc.


```swift
var d = NSDate()

println(d.minute())

println("Minute: \(d.minute())")
println("Hour: \(d.hour())")
println("Day: \(d.day())")
println("Month: \(d.month())")
println("Year: \(d.year())")
```


I guess I was thinking the normal mode of operation would be to get a positive number here, and that shutting down would be the exception.  But, it could just as easily not be very common.  Depends on that app, I guess.

It is less code, and an extra atomic op is not a performance concern here.


alt:
```ruby
@value = if refreshed_values.collect { |value_pair| value_pair[0].to_s }.include?(checked_value)
           checked_value
         else
           default_value
         end
```
Thought we had a rubocop that would complain about not doing this. huh.


Hello World


Running a UI test with a logged-in Dashboard user (which was required to test this feature only available to logged-in users) was too complicated, and ran into issues with the signed cookie generation. Leaving this test reverted for now (manual tests showed it worked fine).


@lefticus I agree this seems like a good thing to do, but do you know of any verified negative effects?  In other words are we getting away with it like I think we are?


Should probably use Bluebird...


Much spelling: `GPLUS_ENDPOINt`.


Instead of spelling error in code, spelling error is now in commit message. Would not really buy again.


Is this change intended as part of this commit? I would have only expected changes related to settings access.


@jbytecode Yes it does. Thanks


88737258-EPW-Ruby-Access (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (2184 of 2205 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.05%25-yellow.svg)


лучше этот код перенести в подсистему auth


Well that was odd. I tried to add a new variation by doing a direct push to the JWildfire main repo from the variation-rosoni branch of my local copy of my JWildfire fork:
         git push upstream variation-rosoni:master
Which did work, but the commit message is a little weird:
         "Merge branch 'master' of https://github.com/thargor6/JWildfire into variation-rosoni"
rather than what I'd expect it to say, which is that I'm merging variation-rosoni into master.
Apparently direct push works but leaves weird commit messages. And I miss having these merges listed in the pull requests.
So I think I'll stick with the approach of pushing my local branch to my github fork, sending a pull request to JWildfire main repo from my github fork, and accepting my own pull request as a contributor to the JWildire main repo.


Я всегда люблю упоминать, что не надо делить имя пользователя на firstName, lastName, middleName – сделайте просто поле, например, formalName.


The numbering of the states gets messed up after state 13.


javadocs that are nested and don't have a corresponding method or data member (such as this one) will not be shown, and I'm pretty sure they won't be listed in the javadoc output either.

I sugest combining this with the javadoc for public EmploymentScreen(Game game) (line 236)


FYI, I copied the restriction from the properties.


Cool, i'll merge it in.


You probably intended to remove moveKeys = moveKeys.randomize(); in this commit?


+* Nome artefato: ThaisRuas.txt
+* Nome do autor: Thais de Sousa Ruas
+* Data de criação: 31/03/2015
+* Hora de criação: 22:50:44


Hey it's your package, I was just tossing out an idea :) It actually started when I was trying to figure out the OrbitGenerator, but decided against that so the station didn't have to be in a specific orbit. I'll remove the minimum on the next passover since I need to redo everything anyway to make it compatible with the LS stuff. And yeah, the timer was NOT working as intended! Lol!


done: insert and show through the ajax call


Thanks for making this a generic message I've started to see empty alerts due to 404 from other causes other than missing item or offer. I think it also makes sense to move this to the ApplicationRoute as I don't see why this should only apply to Controllers that require authentication rather than the entire app.


TeamCity Colore :: Main Build [Build 49](http://tc.sharpblade.net/viewLog.html?buildId=570&buildTypeId=colore_mainbuild) is now running


srsly... i apologize for this...


TeamCity Colore :: Main Build [Build 49](http://tc.sharpblade.net/viewLog.html?buildId=570&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 81 Build time: 0:0:52


Changed the return type of Run() to the sample class. The ParseOutput return value is used as intermediate result (will not be printed), so just keep the original code.


Do we really want "0" to return true?


this is a place to store code that will be used for our Zombie Slayer game


Sorry, I don't. Jay should be able to address those.

On Tue, Mar 31, 2015 at 9:26 PM, hnahak <notifications@github.com> wrote:

> Thanks Steve. I'll build psl locally.
> Do you have these branches slg13 and akbc13?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/linqs/KnowledgeGraphIdentification/commit/c20096dfd073ce052e94c4fbbe1a273fa4f949e4#commitcomment-10508764>
> .
>


[テスト]
文字化け。うん。。


Faux-positif.


sss


The GDS tables have not been removed from MSSQL.

PS.
Why the tables have been removed?
In my old project I have the tables, but I can't find any description of how to use (and fetch) the GDS on newly created project.


I see, but you're making the faulty assumption that the resulting JSON should never contain any ``null`` values. A better solution would be to make ``Writer.write`` a ``PartialFunction`` (in analogy to ``Reader.read``).


@jonarce why the GDS tables have been removed?

The GDS tables have not been removed from MSSQL.

PS.
Why the tables have been removed?
In my old project I have the tables, but I can't find any description of how to use (and fetch) the GDS on newly created project.


Yes, if you have compose keys, the brackets are reversed.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13464/testReport/) for this commit**


Thanks, but unfortunately it didn't change anything. The class path that `findMacroClassLoader` outputs is exactly the same as `global.classPath.asURLs`.


Other DBMS accept `"` char, and MSSQL can also accept that.


Would it be prudent to use something like https://github.com/gbirke/Sanitize.js instead of haxxing with string replacements?


Which branch of your fork I should pull to check this locally?


Shall I merge this branch or do you open a pull request, when you think it's ready for merging?


Yep, the CacheConfiguration class doesn't exist before 10 so the lessons changes won't be backportable.


Concerning Regexes: They are one of a couple of usability concerns that I wanted to talk about with you and Lasse when we meet. They do have neormous advantages, no doubt about that. For example, my find and split methods only work on one specific sequence of characters, especially for split this is weak.

But on the other side, requiring regular expressions as arguments are quite annoying because these arguments go quite a long way. A lot of separators and delimiters in our parsers can be passed as arguments. They will naturally be or contain special symbols. To use StringProcessing effectively, these arguments would have to be passed as regular expressions, too, which bothers me.


I think so. I tried to load games and 8 was used, so I added that (and 9, why not). I was planning to add buffer handling too, but had no time yet to do it.


TeamCity xBIM :: XbimExchange :: Build [Build 176](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1265&buildTypeId=XBIM_XbimExchange_Build) is now running


Nevermind I got it


10/10, would commit again


Never forget, in CodeBlocks: ```Right Click -> Format use AStyle```


to translate it to your language go here
https://github.com/nesbox/emulator/blob/master/src/assets/en.json
download, rename it to your lang (zh.json for example) and translate all
the strings in values section
put zh.json near nesbox.swf and new variable to flashvars
{
...
locale : 'zh'
...
}

On Wed, Apr 1, 2015 at 12:59 PM, Dilshat <notifications@github.com> wrote:

> got it，Thank you for your patience to answer！and how to I translate it to
> my language?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nesbox/emulator/commit/686b5255cd496c077e6aaa13e82e1436db6720f5#commitcomment-10516323>
> .
>

--
Vadim Grigoruk
grigoruk@gmail.com


Thanks for that! :+1:


@kmormysh get used to guava library - it has very nice concepts
https://code.google.com/p/guava-libraries/wiki/GuavaExplained?tm=6

for example:
List<Alarm> alarms = Lists.newArrayList();
- no need to import ArrayList
- no need to specify generics on the right side
(see https://code.google.com/p/guava-libraries/wiki/CollectionUtilitiesExplained#Static_constructors)


I guess this is temporary and we don't plan to have a hardcoded copy of the ir.ui.view.type selection? ;-)


questa riga di codice e' errata, non localizza il service, serve tutti il percorso con i package


@om4james I'm having a look at #7852 right now, will comment there.


Are you sure? Since `unescaped_find` returns -1 if there is no match, I'd imagine this function to yield -1 repetedly if the iteration is not halted


* Day 1: This
* Day 2: That?


@kmormysh  why int but not boolean?


TeamCity xBIM :: XbimExchange :: Build [Build 176](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1265&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:03:10


I removed it acidentally. Fixed: https://github.com/php-fusion/PHP-Fusion/commit/c05ea3052be19900adf2992bec8dcf5d17937cd8


Adding footer


@kmormysh reuse the previous constructor to avoid code duplication:
public Alarm(a,b) {
  this.a=a;
  this.b=b;
}
public Alarm(a,b,c) {
  this(a,b);
  this.c = c;
}


NICE


Hi @rvexiau.

I see you have adding a EMSL basis support, may i recommend you to use the binary
` qp_create_ezfio_from_xyz`  for more simplicity?

You can create with this an EZFIO forlder with all the basis set avalaible in EMSL. (At least is work in the new version ;).

`qp_create_ezfio_from_xyz qp_root/tests/methane.xyz -b cc-pvdz`,

Thomas


I authored this a long time ago.


Doesn't that therefore answer the question of why it's been done that way -
because shading does not work with HPI packaging?

You're right in that I don't actually care particularly how shading *should*
work. Delving into fixing maven's shade interaction with HPI is utterly and
completely non-interesting to me. Having a plugin that doesn't completely
fail when trying to build docker images from dockerfiles and push them to a
central location *is* critical, right now.

Yes, WIP branches will break. But I can't see any PR commit that is
described with "fix shading so that it works correctly with the HPI
packaging" ? If one did, I'd be more than happy to merge it, and even do
the rebasing work if it's based on an earlier commit, since I doubt that'd
be very difficult. And likely jenkins-jclouds would likely welcome a
similar patch.

On Wed, Apr 1, 2015 at 10:52 AM, Kanstantsin Shautsou <
notifications@github.com> wrote:

> @magnayn <https://github.com/magnayn> person that did shading doesn't
> remember what he did and why. I already cleaned some crap of your
> copy-paste in my WIP branch, but your coding style cleanup will broke all
> my work. It looks like you even didn't check what is happening and how
> shading should work. Second shading should relocate guava classes, issue
> happens because shade doesn't work with hpi packaging.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jenkinsci/docker-plugin/commit/bdde16c512c9f72eabc209b7d369f258c987a7af#commitcomment-10515833>
> .
>


@kmormysh dont mix different styles, e.g. keyID vs key_id, stick to "camelCase".
btw - keyID is also incorrect, better "keyId"


`pylint` moans about more than 80 characters (and I do as well, yes). 120 is a strange number; 132 (or 80) is standard, but where does 120 come from?
[pep8](https://pypi.python.org/pypi/pep8) also complains:
`indico/MaKaC/webinterface/mail.py:190:80: E501 line too long (120 > 79 characters)`
On the other hand, it is stupid, when it warns about trailing whitespace in a string. The "-- " sequence for e-mail signatures *must* have a trailing space character in order to be recognised.
Mailers also often have a limit of 80 character, if at all in "raw" text mode.
I was tempted to use the .format() calls, which would also make translation a bit easier and more reliable.
But I did not want to go too far either. I came essentially here, because we had forgotten one long `maildata` line in 2012. Also the many local variables (used only once) would not enter my newly written code, but it is a matter of taste (and convention).

Anyway, what is the bottom line? Do you want me to pick up the file again and implement more changes before merging?


Oh my god !


It works :)


@tarruda Latest version of this commit is on https://github.com/neovim/neovim/pull/2303.
But, since writing here before I've sent you another message saying problem with this commit is fixed (or so I believe).
I still have failing tests in https://github.com/neovim/neovim/pull/2303, which are a bit weird, as they seem to be gcc-only, and kind of flaky.
This is blocking clang issues (and corresponding coverity issues) to be fixed.


Можно вспомнить также и рекомендацию с занятия: разместить весь код внутри функций. Тот код, который сейчас остался снаружи, стоит заключить в функцию `main`.
Это позволит не засорять пространство имён.

Вызов функции `main` можно обернуть стандартной конструкцией:
```python
if __name__ == '__main__':
    main()
```


Garvin, put  'templates/HOWTO' to the $dead_files_rest list in https://github.com/s9y/Serendipity/blob/master/include/functions_upgrader.inc.php#L159, please.


@mb12 yes, we'll eventually refactor this way (to have the Map thread always running), it's just tricky to get right with regard to Android, since they require a very explicit ordering of events.


echo? woaw


````js
var series = this.series
````


I am not proficient with `js`. Do you do I have to do like this

````js
var series = this.series;
series.sort(function (a,b) {
      return a.options.legendIndex - b.options.legendIndex
});
````


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13465/testReport/) for this commit**


Awesome awesome awesome


I don't think it's strictly necessary to repack the exception, but if you do, you might as well include the name of the method where this happened and the name of the problematic parameter, to save the jobtype implementor some guesswork.

Alternatively, we might include a traceback in our error messages.


rewrite html


w niektórych środowiskach graficznych (awesome wm / dwm) jest to problem. JavaFX najpierw oblicza sobie wszystkie rozmiary z plików FXML tworząc okno o określonych rozmiarach, dopiero później zmienia rozmiar okna na rozmiar określony w konstruktorze Scene(). Przez to w środowiskach słabo wspierających Javę, wnętrze okna nie zmienia swojego rozmieszczenia i wygląda to syfnie.


Base64.strict_encode64 doesn't add newline and hence removes need for gsub


Смотри. что ещё можно сделать: в python есть такая концепция, как ContextManager. Здесь его можно аккуратно применить.

Вот [ссылка](http://code.activestate.com/recipes/576620-changedirectory-context-manager/) на его реализацию для смены папок. Самостоятельно не обязательно подробно разбираться, подойди в субботу, я объясню.


Correction of the commit message:
The related commit is b65a647f2efd8cd87795137bee820c4067240563 instead of 9b2c4a6


@tombatossals, now this issue reappears: https://github.com/tombatossals/angular-leaflet-directive/issues/592

It was also mentioned here: https://github.com/tombatossals/angular-leaflet-directive/pull/539

And here is the initial change: https://github.com/tombatossals/angular-leaflet-directive/commit/380b0394b90a0975d242e00258ce5b5c9d398e33

Did I miss some changes that fix the initial problem?

Thanks in advance ...


Thanks Ed, me and Aidan have worked it all out and generating the icons and splash screens is easy super useful!!


We really need tests on web. We need to work them into one of our upcoming sprints.


we 100% certain nil user can not be passed in here (eg: deleted spammers? )


Dear NH-99

Im trying to undestand why you have removed this maxlimits.

As far as i know, ingress-maxfields limits to 50 portals.
Also you generate an excess of queries agianst intel, that may cause you to get banned.

Br
Stefan


@GalaticStryder chet and optipop never implimented graphite modular optimizations.  I've been doing this with SaberMod since KitKat.

@JustArchi not all android code is compatible with graphite flags kind of like strict-aliasing.  You use strict aliasing on some things but not on others.
-fstrict-aliasing and -fno-strict-aliasing
But then you say that having graphite for some modules and not others is not the proper way to do it!?  I don't see where this causes any issues or harm.  If you find any feel free to point them out.


There are quite a number of cases where that cache will need to be invalidated. Off the top of my head:
- updating, deleting, creating views for that model or a parent model (arch, inherit_id, priority, model, ... basically any field of the relevant views)
- updating, deleting, creating ir.values relevant to the model
- updating, deleting, creating any ir.actions relevant to the model
- updating, deleting, creating any ir.translation entry related to that model, a parent model, or any view or action thereof
- updating, delete, creating any ir.model.data binding for an ir.ui.view record
- and probably many more...

Given that `field_view_get` relies on `read_combined` to do the heavy-lifting, and `read_combined` is already cached, couldn't we instead optimize the post-processing that is done afterwards, and save ourselves the headaches of one more tricky cache to invalidate?
(The 6.0 web client had a cache of `fields_view_get` in "prod" mode, and it was quite broken)


Looks wrong indeed /cc @malukenho


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13466/testReport/) for this commit**


Oh good question :) I got it from the github repo, I suppose it'll be released soon ...


@mebster @schaubl
Please review (and update if needed) the tooltips in the `*.edn` files. See above for `diff`of the added text.


please add support for case that device = dev:port and strip port part from it.
for convenience.


Можно ещё выделить функцию `parse_parameters`, которая бы разбирала аргументы командной строки и возвращала бы пару путей, чтобы разбор аргументов не захламлял основную программу.


I have done some manual testing, here are the results:

* `XWiki.ForgotUsername` not broken.
* `XWiki.GoogleAnalyticsCode` to be fixed with @mflorea's suggestion.
* `XWiki.Registration` not broken.
* `XWiki.ResetPassword` not broken.
* `XAppCode.ExportAppCode` not broken.
* `XAppManager.CreateApplication` not broken.
* `AppWithinMinutes.CreateApplication` not broken.
* `Blog.CategoriesCode` not broken (tested through `Blog.ManageCategories`).
* `FAQCode.FAQHomeSheet` not broken.
* `XWiki.XWikiSyntax` not broken.
* `XWiki.OfficeImporterAdmin` seems ok.
* `Release.WebHome` to be fixed (no velocity there).
* `Extension.WebHome` not broken.
* `ExtensionCode.ImportExtension` not broken.
* `Main.SolrSearch` not broken.
* `XWiki.SolrSearchAdmin` to be fixed with @mflorea's suggestion.
* `Main.DatabaseSearch` not broken.
* `XWiki.ClassSheet` not broken.


missing newline before EOF btw


Me aparecen PHP warnings cada vez debido a la constante que no está definida:
<pre>
Warning: constant(): Couldn't find constant ::NEW_COURSE_SUGGESTED_TEACHER in /var/www/html/chamilo19/main/inc/lib/course_request.lib.php on line 155
</pre>

Voy a enviar unas correciones para esas llamadas.


Nice solution here, probably some potential for us to do some recursion inside, but I'm happy with it as is.


Can you change this code to something that makes more sense?
This creates a list and then disposes of it. A for loop would be a better fit and will actually work better for PyPy.


Shading+hpi issue i found only yesterday and i already debugging it. In wip branch i have some other clean-ups for poms.  I don't care about jclouds. If you want develop this plugin in such way "i fixed somehow and it looks to work" and "i copy-pasted some crap and it looks to work", then i gave up. You can continue doing alpha, beta after your every not reviewed merge and ask people to test and infinitely getting bug reports.
How contributors should understand code when even author doesn't know how and whether it works?


@JustArchi what makes these optimizations not placebo more than other optimizations?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13467/testReport/) for this commit**


앗 그러네 곧 수정함


LGTM


위에껀 사실 안해도 되는데 initialize는 해야하는듯


hej det var bra att det ordna sig


was done for having the task search result list for all prev-next links working on details view. Made comments too in my branch commits. Enables browsing the whole result by clicking prev-next from details view.


Good idea. In future please use the square bracket syntax. We prefer square brackets here because it's easier to read when you have something like...
```php
myMethod(10, [
  'x' => 10
]);
```
compare this to...
```php
myMethod(10, array(
  'x' => 10
));
```


:D


@rkoster - I've updated to v0.9.0.rc2 as suggested, but I'm still getting the same error:
```
Installing bosh-workspace 0.9.0.rc2 (was 0.8.4)
Using bundler 1.7.6
Your bundle is complete!
Use `bundle show [gemname]` to see where a bundled gem is installed.
ubuntu@ip-10-10-0-48:~/workspace/deployments/logsearch-boshworkspace$ bosh prepare deployment

Fetching release 'logsearch' to satisfy template references
/home/ubuntu/.rvm/gems/ruby-2.1.5/gems/rugged-0.23.0b1/lib/rugged/repository.rb:37:in `checkout_tree': Expected Rugged::Commit, Rugged::Tag or Rugged::Tree (TypeError)
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/rugged-0.23.0b1/lib/rugged/repository.rb:37:in `checkout'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh-workspace-0.9.0.rc2/lib/bosh/workspace/helpers/git_credentials_helper.rb:19:in `fetch_and_checkout'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh-workspace-0.9.0.rc2/lib/bosh/workspace/helpers/git_credentials_helper.rb:7:in `fetch_or_clone_repo'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh-workspace-0.9.0.rc2/lib/bosh/cli/commands/prepare.rb:31:in `block in prepare_release_repos'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh-workspace-0.9.0.rc2/lib/bosh/cli/commands/prepare.rb:28:in `each'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh-workspace-0.9.0.rc2/lib/bosh/cli/commands/prepare.rb:28:in `prepare_release_repos'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh-workspace-0.9.0.rc2/lib/bosh/cli/commands/prepare.rb:18:in `prepare'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh_cli-1.2905.0/lib/cli/command_handler.rb:57:in `run'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh_cli-1.2905.0/lib/cli/runner.rb:56:in `run'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/gems/bosh_cli-1.2905.0/bin/bosh:16:in `<top (required)>'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/bin/bosh:23:in `load'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/bin/bosh:23:in `<main>'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `eval'
	from /home/ubuntu/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `<main>'
```


J'ai crée une branche pour chaque langage dans lequelle on va certainement vouloir développer le truc. Le master sera en Java (on s'étais mis d'accord là dessus je sais plus ?). Si on est en train d'implémenter du code mais que le l'implémentation n'est pas terminer, je proposer que chacun créer une branche temporaire pour ensuite push le code final dans la branche correspondante (comme ça ça évitera qu'on se retrouve avec du code partiel sur tous nos PC ;)
Si vous n'êtes pas d'accord vous pouvez aller vous faire foutre :D :D (joke)


I tried this with quickstart angular2 code. My quick start worked. I then replaced app.es6 with your code and changed the my-app with survey-builder-app. It does not throw any error on the browser. But displays only 'Loading....'
Can you please help.


action du participant, devrait être en `[IMPORTANT]`, imo


`wheres` hasn't been defined as an empty array before this, I think we should just below line 61.


All Index-Items are displayed, even without type-Attribute.
![items in index](https://cloud.githubusercontent.com/assets/6735556/6939313/b209ca22-d86b-11e4-9169-416f63f53510.png)


FWIW, the logsearch-for-cloudfoundry repo is being git cloned successfully:
```
ubuntu@ip-10-10-0-48:~/workspace/deployments/logsearch-boshworkspace/.releases/logsearch-for-cloudfoundry$ tree -L 2
.
├── bin
│   ├── build
│   ├── install-dependancies
│   └── test
├── docs
│   └── README.md
├── LICENSE
├── logsearch-for-cloudfoundry-boshrelease
│   ├── config
│   ├── jobs
│   ├── LICENSE -> ../LICENSE
│   ├── packages
│   ├── Rakefile
│   ├── README.md
│   ├── releases
│   ├── src
│   └── templates
├── Rakefile
├── README.md
├── src
│   └── logstash-filters
├── target
│   └── logstash-filters-default.conf
├── test
│   └── logstash-filters
└── vendor
    └── logsearch-boshrelease

```


merge


Issue #171


ce n'est pas plutôt " l'ennemi de mon ennemi est mon ami" ?


I think empty lines at the start/end of functions don't deliver much value.


:heart:


Apologies that you had to make a first item here. `orArray` is perfectly fine, I can see that this effected by `EloquentQueryRepository` on line 22.


Change in line 59 (" _backends['eventlet'] = _eventlet.d") is an error when I committed my local code.


Should perhaps change that password.


r+


```System.err.println(ex);``` wird für Errors gebraucht.


Not wild about the leading underscore.  Is that a strong existing convention?


je ne suis pas sûr que l'on peut compiler subject vu qu'il y a dedans le Step2Test.

cf. ma remarque plus bas, dans mes exercices, j'ai mis les tests compite-testing dans `Processor` et demandé dans le README d'activer progressivement les tests U de sorte qu'à la fin de chaque étape, il a toujours des modules qui compilent.


Richtige Formatierung!


comme dit hier soir, je pense que les tests compilte-testing doivent être dans le processor. Après tout, ce sont les tests unitaires du processor.


@lloydwatkin thanks, could you next time comment on the PR?


je ne vois pas l'intérêt de mettre la négation entre parenthèse. Une référence à "Je Suis Charlie" ? pas très appropriée dans ce contexte


Add a reference for where the following gobbledegook comes from?  Or at least, _something_ to start explaining it!


saw approval from Ms2ger
at https://github.com/servo/servo/commit/6bf2c5e77fd6966eafcd53ebab8be08bb94da518


merging servo/servo/script-for-event = 6bf2c5e7 into auto


servo/servo/script-for-event = 6bf2c5e7 merged ok, testing candidate = 9b9c8046


Also, in the commit message, "snipped" should be "snippet"


indentation !!! :(


Sorry, I was wrong; according to the code it's `evolution`, not `evolveopts`:

```python
    result = set(repo.ui.configlist('experimental', 'evolution'))
    if 'all' in result:
        return True
```
(see [mercurial/obsolete.py:1159](http://selenic.com/hg/file/fab9dda0f2a3/mercurial/obsolete.py#l1159))


Why would `focusReq` be set to a string? Do you mean `typeof focusReq === 'undefined'`?


saw approval from Ms2ger
at https://github.com/servo/servo/commit/fdcf9618cbf853920c14045fc8e76a3564416994


merging servo/servo/script-for-event = fdcf9618 into auto


servo/servo/script-for-event = fdcf9618 merged ok, testing candidate = c85f83fd


Next time, open a git issue


develop (macumber) - Win64-Windows-7-VisualStudio-12: OK (2175 of 2196 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


We need to explain deeply what happens, from the message life cycle point
of view under the hood, otherwise for any user understanding what is going
on is problematic.

On Wed, Apr 1, 2015 at 8:20 AM, Andreas Öhlund <notifications@github.com>
wrote:

> IMO this sample can confuse users, it says that uses a UoW but is
> implemented as a behavior, as a user I would start raising questions about
> why is not using the publicly exposed IManageUnitsOfWork instead.
>
> I'm currently working on a proposal to remove the IManageUnitsOfWork stay
> tuned
>
> Also it mentions "Child Containers" why mention it, I don't think it adds
> any benefit to it, if we use IManageUnitsOfWork all the life-cycle of the
> component is handled by that abstraction.
>
> Not following, how are users supposed to share the ISession btw the Uow
> and their handlers without knowing that there is a child container there?
> (Does that even work for eg. Spring?)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Particular/docs.particular.net/commit/fd899996742a1589a03b59e06fa78a54c8c8c913#commitcomment-10511022>
> .
>

--
Mauro Servienti | Solution Architect | Particular Software


/cc @Praburaj @lodejard @HaoK @muratg   Renamed it


I think `focusReq` needs to be passed in the call to `selectTab` in the click handler as well


That looks like cyan to me...


This is adding a hard dependency on SyliusTranslationBundle that should also go into the composer.json (not just in require-dev)


unfortunately `import "github.com/cucumber/gherkin3"` doesn't work yet as the gherkin3 repository doesn't follow a "go-get-able" layout... e.g. the go source is under `./golang/src/github.com/cucumber/gherkin3` insted of `./.


LGTM - do you get these failures basically when the host is overloaded?

I'd have thought that if the inspect fails, doesn't the removeContainer also often fail? Maybe we ought to do a certain number of retries on the inspect / remove. Or even queue the removes somewhere if that fails.

But either way, this looks better than what it's currently doing.


This should be done in the [config](https://github.com/syncthing/syncthing/wiki/Config-File-and-Directory). Currently one would be able to observe the password in plain text via ```ps```.


Yup. Note the already existing `_static` directory. =) It's just how Sphinx does this.


magic oil is not existing.


A deadlock can also occur here.


A deadlock can occur here.


Oh okay :) now i see the point, thought it was just out of the random, ;) thanks luca!


J'ai comité depuis son PC, j'ai simplement oublié de changer l'author.


I prefer to remove any null values from the resulting Json as I don't like them being passed around. I'm actually surprised that uPickle supports the reading (and writing) of null values as Scala avoids null if at all possible - I would expect an exception to be thrown if a null value is read by a non-option Reader


I wonder how such random code was accepted into SF in the first place. I hope your test passes, and we can get rid of this whart.


some tests failed:
exception: http://build.servo.org/builders/gonk/builds/418


oops = object orientated programming sucks


thanks, that makes it much easier :-)


I'd need to read the [SSL guidance](https://www.gov.uk/service-manual/domain-names/https) and the [instructions for operating a service.gov.uk subdomain](https://www.gov.uk/service-manual/operations/operating-servicegovuk-subdomains), but it's not going to happen soon.


@mshabunin, found time to follow up on this. Refactored everything for the new API and it works again. Thank you very much for your suggestions.


Could you remove the trailing empty line?


I think this changes the logic: now no_kill can only ever be true. But if you don't change this line, I think this PR would fix the bug.


Fair point


Love to find the hack that hacked me


OK then, thanks.


we should say "defined contribution"


Wrong year :)


I would have thought focus would always want to be set in the clickHandler so is that neccsary?


I don't get this commit, could you elaborate on why it's necessary?


Unused variable?


Good point, I hadn't thought of that!


@maeda-m here!


How about `errback``?


Reviewed and approved.


Oh, right, so you *don't* have a fix for shade/hpi mismatch.

Of course it's understood how and whether it works; shading isn't exactly a
complex process, therefore I disagree with your characterisation. When the
classref issue arose, it's easy to understand *why* it occurs - so it's
logical to look at other plugins (particularly ones with input from core
devs) to see how they have attacked the same problem. The fact that they
*also* haven't a fix for the shade/hpi mismatch suggests that it may be a
non-trivial fix. Certainly non-trivial compared with what they have
actually done, which is to access classes in shaded packages directly.

Accessing classes by their shaded names is not ideal. But it works - right
now - and 'truth&beauty' solutions can come afterwards. It is, after all,
just a search and replace change.

On Wed, Apr 1, 2015 at 11:29 AM, Kanstantsin Shautsou <
notifications@github.com> wrote:

> Shading+hpi issue i found only yesterday and i already debugging it. In
> wip branch i have some other clean-ups for poms. I don't care about
> jclouds. If you want develop this plugin in such way "i fixed somehow and
> it looks to work" and "i copy-pasted some crap and it looks to work", then
> i gave up. You can continue doing alpha, beta after your every not reviewed
> merge and ask people to test and infinitely getting bug reports.
> How contributors should understand code when even author doesn't know how
> and whether it works?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jenkinsci/docker-plugin/commit/bdde16c512c9f72eabc209b7d369f258c987a7af#commitcomment-10517358>
> .
>


The patch is actually correct as it makes the code uniform. But the code is uniformly incorrect. I will merge this patch and then change all instances to use stdout instead. (When I get home).


Please fix ``lint`` warnings https://travis-ci.org/smartanthill/smartanthill2_0/builds/56702590


I've done my best. Get used to it!!!
On 1 Apr 2015 17:44, "igez" <notifications@github.com> wrote:

> indentation !!! :(
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/igez/fultrac/commit/13f2685f82767198f4257dc2b411520fa70f20d7#commitcomment-10517551>
> .
>


[keypair] 文件名称偷懒没有改呢，下面的也是


应该是 [cinder](cinder/cinder.md)


This will inevitably generate a huge barrage of test failures because Travis doesn't yet include necessary PECL extensions in their PHP 7 build, but yay futureproofing.


Changed in d65544d


@kaelig  Having read through it's a bit confusing so pushing  a refactor to be make focusReq  disableFocus and check for a truthy value.


You are probably right. I do not mind moving it. (You can do it?)


Thanks for the SoC cleanup! I'll adapt the others core.


Sounds good


It will never be true


This line is missing 'a' character in $i18n['devangary], cause a warning


such debug


Well, as implemented here, FORCE_SHADOW is set to false by default, and thus current behaviour is preserved. In my deployments I will be setting it to "yes".


thank you! :) :+1:


It would be nice to pad the segindex with zeros, so that files are listed in order in the shell. That would allow to do `cat something-*.ts`. If you pad to have up to 4 digits, it should be sufficient.


Unused method argument - `user_name`. If it's necessary, use `_` or `_user_name` as an argument name to indicate that it won't be used. You can also write as `initialize(*)` if you want the method to accept any arguments but don't care about them.<br>Unused method argument - `project`. If it's necessary, use `_` or `_project` as an argument name to indicate that it won't be used. You can also write as `initialize(*)` if you want the method to accept any arguments but don't care about them.


Extra empty line detected at method body beginning.


Unused method argument - `user_name`. If it's necessary, use `_` or `_user_name` as an argument name to indicate that it won't be used. You can also write as `initialize(*)` if you want the method to accept any arguments but don't care about them.


Align the parameters of a method call if they span more than one line.


That looks exactly like what I wanted. Should've looked further than Handlebars for whitelisting.


Doc typo: should be y: f.A, NOT Nat. but it is correctly a selection in the code.


Thanks! I'll push a fix for that soon, along with other minor bugfixes. :)


Comment added @ e1c83de490e32f61760bc0bbd97bdd0c077a7392 pointing at this one...


Hi! can you describe  how to build firmware under debian/linux?
which tools you are using for upload and debugging?
Thanks.


type: preserve instead of preserver


flaga ```--save``` jest w tym przypadku kompletnie zbędna.


r+


You are probably aware that if something happens (e.g. user cancellation) during that write, we end up with a partial, partial file, which we won't re-download after.

Should we have a try..except that catches everything? In the except, delete the file and re-raise?


"However, it looks to me like it sets the new file's perms to be the perms on the open file." - I don't follow this comment. If commonio_open is called with O_CREATE option, yet said database does not exist on disk, the database is "opened" but no file is created on disk / no file pointer is created. Then at commonio_close time, the database will be created with desired default permissions. Otherwise, if database does exist, it is opened for real (fp exists) and at close time an atomic update is performed without adjustment of the file permissions.

I do not want to modified the permissions, as e.g. other tools have other default permissions for these files.  E.g. PAM uses 000 for shadow file.


saw approval from Ms2ger
at https://github.com/servo/servo/commit/6288a468b948f6923d0d8e03aac9cd9ce40582d1


merging servo/servo/add-event-handlers = 6288a468 into auto


servo/servo/add-event-handlers = 6288a468 merged ok, testing candidate = d74e6330


imho a good decision.

@mweinelt,
http://pep8.readthedocs.org/en/latest/intro.html says:
PEP8 E113: "unexpected indentation",
PEP8 E501: "line too long (82 > 79 characters)"


Just for future defence on cherry-picking commits.
From the kernel source:
git remote add sm-cm12.0 https://github.com/SaberMod/android_kernel_lge_hammerhead.git
git fetch sm-cm12.0 cm-12.0
git cherry-pick 545480f


Added a new variable to store the count of collection/array variable
Example
count($zones) was replace with
$zonesCount = count($zones) outside the loop and variable
for (; $zonesCount;) so that count() function is not executed for n times


err, why ?


Le nom du model est au singulier, le nom des controller au pluriel


Can you explain why it's need to have such funky exception management? Why not just one level?


That's the word I was looking for, thanks! :) eb48ff941d9fa125e1d109f606f45c35edfb751d


float() is not locale-aware (PEP 331 for details) so it will throw "ValueError: invalid literal for float():" when using csv_decimal_comma=1


tu ne peux pas faire de validation de cette manière, c'est un champ par `validates`


If you do so, then the semantics is ill-defined, because you cannot ensure anymore that ``read(write(data)) == data`` if ``data`` contains a member that is ``null``. I agree with you, that ``null`` should be avoided by all means. I would suggest to look into a more configurable approach, for example having an option like ``NullStrictness``. I can imagine that in some use cases we don't have any control over how our JSON inputs and ADTs look like. In this case, the developer will need the current behaviour. uPickle makes many assumptions, which definitely don't hold true for all use cases. See also https://github.com/lihaoyi/upickle/issues/59.


Jasne, rozumiem. Zmieniłam wartości dla tych dwóch factories.


I like it!


shouldn't tag be on this commit instead of parent?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13468/testReport/) for this commit**


Fixed in 1a17f832b832884023e6c0786019e0f2a0ead2c0


No, that still preserves the original. I suppose you need to copy it like this:
```js
var series = this.series.slice();
```


lorsqu'un champ de BDD dépend d'un Model, il est préférable d'utiliser

`t.references :shop`  documentation [ici](http://edgeguides.rubyonrails.org/active_record_migrations.html)


Same 2 fixes ;)


this commit related to task DMF-129


Why a hard space ?

and

are enough


Я понял, но на будущее: выглядит плохо, что handler что-то знает про SimpleGrizzlyAdapterChain.
Получается 2 сцепленных класса и chain вызывает handler, и handler оповещает chain.


Now, -n is both a top-level param and a param for all three of list, info and fetch. I would think it makes sense to have it only as a top-level. What do you think?


il ne faut JAMAIS modifier manuellement le fichier `schema.rb`. Si tu as une table en trop, c'est que tu as un soucis de migration.


Il serait bien d'ajouter des script `CURL` pour tester plus facilement ce que tu as fait.


Good point. I guess handling overloaded `_1` is the only real problem I can see, which is easily fixed.

But my meta point is that I have seen a lot of bugs in Scala 2 related to comparison of names, rather than symbols, so if you use this approach in a way you claim is safe, document your assumptions in the code.


Any particular reason for not keeping the pagination border in Flamingo?


Orfg Ncevy sbbyf fb sne!


Sais-tu ce que fais cette ligne ?


Может быть после try catch?


Ou est la migration qui créer les Ticket ?


Sais-tu ce que fait cette ligne ?


...will only work if you cherry pick this to 2.0, since that is gona happen with 2.0.2. :)


This import is unused


댓글 삭제시 댓글 수는 안바뀜.
삭제 CSS 미흡


Tables where causing trouble to prosodic annotations.
The new lists are shaped like tables.


Je jamais utilisé directement `params`. Il y a une méthode pour ça.


Больше похоже на "HTTP_HANDLER_REQUEST_SERVICED".


Can you pls separate the white space part of the patch into a separate commit? It really makes
reviewing this patch more difficult than it should be.

Thanks.


Close #377.


On ne test pas avec les seeds. Surtout qu'ici, tu ne tests pas ce qui se passe quand le ticket n'a pas de name, de description etc ....


i think sizeof(uint32_t) should be replaced to sizeof(*coll->distance_mask_recv) for better portability.


This all looks fine, small minor comments from my JS experience.
1. Use [`===` instead of `==`](http://stackoverflow.com/questions/523643/difference-between-and-in-javascript) where possible.
2. Use [forEach](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach) or [map](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map) methods on Arrays instead of loops. Other than that this seems very good.


As-tu tester ce que tu as fais ?

Il serait bien d'ajouter des scripts `CURL` pour tester plus facilement ce que tu as fait.


Additions:
-Tiles were the wrong way round so they were swapped
- Player rotation cause of the mouse position was added
- Bullets moving via a vector was added

Deletions:
-Unnecessary function 'determineDirection' was removed from Player class


А почему DURING_JERSEY_CALL?
У тебя метод void gotIOException объявлен как public. Может быть вызван откуда угодно, в том числе и не из JERSEY.


lgtm


It's just a simplyfication that makes code stay out of the way so scrutinizer is happy :)

Anyway, I if you both support that opinion, I will:
 * remove find, rfind and find all and stay with finditer. One can use `lfind, \*sth, rfind = finditer()`and `findall = list(finditer())`
 * provide a faster position_unescaped
 * adapt to your style for tests for now


Maybe it's because of delay in pull request review, but trimTrailing() is deprecated now.


Good use of chaining :+1:


ah good; those "building block" notes are now not as necessary.


Do not merge. We should get rid of the jars first and probably switch to a Maven project. #7
@JWGmeligMeyling


The rules are in ```../Maekfile.conf```


jeszcze to sprawdziłam i on po prostu zawsze przy enterze puszcza wszystkie
testy. a nie tylko np. jeden, który odwołuje się do zmienionego przeze mnie
pliku.

2015-04-01 9:59 GMT+02:00 Artur <notifications@github.com>:

> Jak najbardziej tak. Teraz jest bardzo fajnie.
>
> Masz skonfigurowanego guarda? Jak nie, to spróbuj go postawić dla tego
> projektu. To jest narzędzie, które masz otwarte w terminalu i przy zmianie
> kodu wykrywa ono automatycznie testy, które powinny się wykonać. Dodatkowo
> jest fajny skrót. Po kliknięciu "enter" wykonuje wszystkie testy. Nie
> trzeba ciągle wpisywsać bundle exec rspec .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moniikag/newsletter/commit/d888b49c35231ea69ab82e869093b855a25e39b5#commitcomment-10513056>
> .
>


The fix splits the names because the Species List page querying relies on matching against a list of the species names that are to be displayed on that page. The original distribution records often had longer names with subspecific epithets, and those records would get overlooked in the querying. So now that the the query can match against just the species portion of the name, all relevant records will be included.

Take a look at gobotany/site/views.py, above, which went from this:

[...].filter(scientific_name__in=sci_names).[...]

(which means "filter on the full scientific names in the Distribution records against the list of species names that will appear on this page")

to this:

[...].filter(species_name__in=sci_names).[...]

(which means "filter on just the species names in the Distribution records against the list of species names that will appear on this page")


Sure, but github is down every 2-3 minutes for me and I cannot push & pull


Do we need this modification at all? I've tried to remove resultWithPrefix and it haven't ruined the tests.


I reckon Makefile has been added by accident here since it is generated by CMake?


The code contains secret dependent branches, making it vulnerable to timing side-channel attacks.

This urgently requires a fix, else early adopters of this function might not get the strong security they expect out of LibSodium. We might even need to file a CVE for this.


funny man.love.


Make sure all variables are defined at the top of the function. They get [hoisted](http://code.tutsplus.com/tutorials/javascript-hoisting-explained--net-15092) up there anyway so it makes more sense.


Oh, right !


Why do you use puts? Is this some debug help?


lgtm


Ты решил имплементировать собственный OutputStream только для того, чтобы перехватывать IOException, оповещать об этом SimpleGrizzlyAdapterChain и кидать их дальше?
Насколько я понимаю, они все равно будут пойманы в методе _service:
```java
_application.handleRequest(cRequest, new Writer(response));
      SimpleGrizzlyAdapterChain.requestServiced();
    } catch (IOException e) {
      throw new RuntimeException(e);
    }
```
Почему нельзя в catch (IOException e) оповестить об этом chain?


ping @Warkot @vforge


good


break the line please :)


I think I'd break this down to multiple lines.
```js
case 'account': combined.account.push(
  intermediateValue.slice(8,intermediateValue.length)
); break;
case 'openId': // ...
```


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13469/testReport/) for this commit**


Yeah they had a large DDoS attack the last days
https://github.com/blog/1981-large-scale-ddos-attack-on-github-com
I thought that was over..


if this code isn't used anymore just remove it, don't leave commented out code in the repo


@Xety In general, do cells output? Should be put an echo here? Even though in this case it just logs?


Yes, we do. The tests currently don't check the insertion behavior (I haven't found any completion tests that do check it)


Use `Object.keys(combined).forEach(...)`. The `in` keyword is very much frowned upon in JS.


I do not find github repo for that project.


done


Yes! Hehe


@Phil-Friderici: Are you sure this syntax is correct? If you look in the man pages on a recent system (RHEL 7) it looks like the default value is "FILE:/tmp/krb5cc_%{uid}". Also, what happens if this is set on a system that does not support it? The option was added quite recently. I'd assume it gets ignored but have you tested it?


Good job.

1) createEll method don't have to be public, let us make it protected
2) run_most_tests should replace both run_tests_by_factory and run_tests. Please remove run_tests_by_factory, run_tests and rename run_most_tests into run_tests.
3) Please do not leave commented code. All commented code (yours and someone else's if you see such) should be deleted.
We have our source code under source control so we can always go back and revert some of changes if needed.
4) Please keep the length of lines under 74 symbols. I can see a lot of places which you change but keep the length unchanged.


TeamCity xBIM :: XbimExchange :: Build [Build 177](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1267&buildTypeId=XBIM_XbimExchange_Build) is now running


rubber stamp..


I'd rather not use `--source-map-map-inline`, because it will bloat the css-files by a fair amount and, unlike with only `--source-map-less-inline` set this extra data will also be transferred to normal page viewers. Dedicated '.map`-files are only loaded when one opens up the developer console.


This all looks good, sorry to be so picky about JS. My issue is that we could potentially use JSHint in the future so the more we avoid the bad parts of JS the less work I'll have in the future if we decide to add JSHint checking.


much better :)


Ok, substitution is needed but current test doesn't show why. I suggest to add another one:

```
/**
 * @r<caret>
 */
fun f(x: Int): Int {
}

// ABSENT: @param
// EXIST: @return
```


Nicely done!


I agree that the spec tests should use serious settings. I was asked to parameterize this option to be able to set this value. @eralbru could you please enlight us ?


TeamCity xBIM :: XbimExchange :: Build [Build 177](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1267&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:02:54


lgtm


По-моему ты потом снова залоггируешь это.


Yeah, the less you put in the quicker the container is to build. I'm not sure what conclusions are best to draw from that, but it might suggest that having a number of containers with different packages or groups of packages might lead to a nicer workflow for package maintainers. However, I don't know much about how your packages are built, maybe some of them rely on each other?


Надо выпустить этот код, посмотреть в логи и по-возможности избавиться от него. Уж очень он взрывает.


Si tu avais lu les conversations Hangout, tu serais que je n'ai rien fait au fichier, j'ai fais un rake db:drop db:create db:migration


Looks good.


You should always specify the base you're parsing to. So `parseInt(value, 10)`. Older browsers have some weird behavior with parseInt (more here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt)
eg. from the link above:
> If the input string begins with "0x" or "0X", radix is 16 (hexadecimal) and the remainder of the string is parsed.


was this pushed to http://education.mozilla-community.org/ ? I will add an issue as I did a video for it and might be good to track it


OK je vais changer


Oops, yes, I'd like to restore the comment to match the upstream code.


Works for me!

:+1:


@KSanthanam seems like the quickstart is based on alpha.14 while this example uses an array of controls which has been added in alpha.16 or alpha.17. What error can you see in the JS console ?


It looks like `linear` no longer builds with 7.4 (https://travis-ci.org/diagrams/diagrams-core/jobs/56693336#L705-L718) so I guess we'll just drop 7.4 support, unless someone want to fix linear.


Hi,
the setting was added to also have a working kinit on SLE12.
I have tested the setting on all platforms and it's working.
Of course I can also test "FILE:/tmp//krb5cc_%{uid}" and if this also working we can use this.
Or we have to specify in the module to only add the special option for SLES12 systems. On other systems it's also working without specifying it.
/Ralf


well a hook api lib coder can do that easily in `pkt[46]_receive` if he/she needs it... i think this is useful but i will defer the decision to the KEA people :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13470/testReport/) for this commit**


Je suppose que si l'user n'est pas autoriser a le faire, ca retourne une erreur.
C'etait dans le code que tu as fourni avant.


lgtm


Ouais, mais pour cela il faut configurer le fichier Ability.rb


Oh, yes, there are two kinds of dependencies: "needed" and "suggested". You may see package dependencies diagram here: http://alexk.host.cs.st-andrews.ac.uk/gap/GAP_Packages.html. I am also not sure yet about intermediate solutions between providing a baseline container with GAP core and GAPDoc package and a container with as many as possible stable packages in a working order.


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


47:13: E731 do not assign a lambda expression, use a def
69: D209 Multi-line docstring closing quotes should be on a separate line
69: D203 1 blank line required before class docstring (found 0)
69: D204 1 blank line required after class docstring (found 0)
69: D400 First line should end with a period (not 'e')
69: D205 1 blank line required between summary line and description (found 0)
73:5: E301 expected 1 blank line, found 0
73: D102 Missing docstring in public method
78:13: E731 do not assign a lambda expression, use a def
85:23: E127 continuation line over-indented for visual indent
92:9: B901 blind except: statement
100: D209 Multi-line docstring closing quotes should be on a separate line
100: D203 1 blank line required before class docstring (found 0)
100: D204 1 blank line required after class docstring (found 0)
100: D400 First line should end with a period (not 'f')
100: D205 1 blank line required between summary line and description (found 0)
104:5: E301 expected 1 blank line, found 0
104: D102 Missing docstring in public method
108:13: E731 do not assign a lambda expression, use a def
116:23: E127 continuation line over-indented for visual indent
123:9: B901 blind except: statement
132:1: B901 blind except: statement
138:10: E126 continuation line over-indented for hanging indent
139:1: B901 blind except: statement
145:10: E126 continuation line over-indented for hanging indent
146:1: B901 blind except: statement
156:1: E302 expected 2 blank lines, found 1
156: D203 1 blank line required before class docstring (found 0)
156: D204 1 blank line required after class docstring (found 0)
159:5: E301 expected 1 blank line, found 0
159: D102 Missing docstring in public method
165:1: E302 expected 2 blank lines, found 1
165: D210 No whitespaces allowed surrounding docstring text
165: None: None
165: D209 Multi-line docstring closing quotes should be on a separate line
165: D203 1 blank line required before class docstring (found 0)
165: D400 First line should end with a period (not 'l')
165: D205 1 blank line required between summary line and description (found 0)
170:20: E126 continuation line over-indented for hanging indent
199:16: E126 continuation line over-indented for hanging indent
201: D102 Missing docstring in public method
238: D102 Missing docstring in public method