Look how it's done in Instamodel : https://github.com/pilotcreative/instamodel/blob/master/app/models/option/token.rb#L27

You don't need two separate methods, it's much cleaner. Please use dedicated method SecureRandom.uuid instead of hex.


Hrm. I can't see any good reason why Template Info!G1 is what it is, as opposed to being =IF(HasTemplate,MAX($G$4:$G$12),0) like all the other columns.


I don't see tests.


Because it is not supported:
https://github.com/apache/cordova-plugin-battery-status#supported-platforms

It used to pass on windows store because we're mocking the battery level, but any request for real battery level will fail.


Yes, https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-0876 links to the same vulnerability as this commit fixes (as described the commit message).


Ah, seems we do that already.


> I think it's cleaner to catch the KeyError exception (...)

Well, it depends on definition of "cleanlinnes" :) Firstly I thought about catching `KeyError` exception, later about using normal `if ... else` scheme and finally decided to stick with ternary in this situation because it just fits in one line :P

Anyway - your repo = your decision. I can just rewrite this commit if you really want it that way.


since the 1.x branch is for plone 4.3.x this is only working if we pin `plone.app.z3c.form>=1.0,<1.1` because 0.7.7 has no `pat-autotoc` class in the form template markup. maybe we should do this in `setup.py` ?


@rbf : I would add `ss-content` instead of `body` because sometime (especially on mobile), when a tooltip is opened and we scroll, the tooltip may go on top of the menubar and the secondary menubar.
I would use `ss-content` for all tooltip except the one which are on the header or on one of the two menubar.


@rbf : :+1:
I didn't manage to find why there was a double margin.


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.175](http://teamcity.monogame.net/viewLog.html?buildId=6086&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


you need to check next commit.


Could `number = qi::double_ >> char_('%');`? This is separate from this PR though, just something I noticed.


Create question
  In order to get answer from community
  As an authenticated user
  I want to be able to ask the question
  Authenticated user create the question (FAILED - 1)
  Non-authenticated user try to create question (FAILED - 2)

Failures:

  1) Create question
  In order to get answer from community
  As an authenticated user
  I want to be able to ask the question
 Authenticated user create the question
     Failure/Error: expect(page).to have_content 'MyTitle'
       expected to find text "MyTitle" in "titlebodyMyBody"
     # ./spec/features/create_question_spec.rb:23:in `block (2 levels) in <top (required)>'

  2) Create question
  In order to get answer from community
  As an authenticated user
  I want to be able to ask the question
 Non-authenticated user try to create question
     Failure/Error: expect(page).to have_content 'You need to sign in or sign up before continuing.'
       expected to find text "You need to sign in or sign up before continuing." in "titlebody"
     # ./spec/features/create_question_spec.rb:31:in `block (2 levels) in <top (required)>'

Finished in 0.53285 seconds (files took 3.22 seconds to load)
2 examples, 2 failures

Failed examples:

rspec ./spec/features/create_question_spec.rb:9 # Create question
  In order to get answer from community
  As an authenticated user
  I want to be able to ask the question
 Authenticated user create the question
rspec ./spec/features/create_question_spec.rb:27 # Create question
  In order to get answer from community
  As an authenticated user
  I want to be able to ask the question
 Non-authenticated user try to create question


Thank you I fixed it.


원격저장소 직접 수정함


Please replace  PY_CurrentThread with GET_CURRENT_THREAD_STATE(). Add parenthesis to show that it may call a function (on Python 3.2 or newer).


comparison (* instead of comparision)


Does Any Group Member  have an idea of what to do in Lab 1?


That's ok to remove now


The `FIXME: remove inline CSS` at the top should have been removed, too.


no...


I would have preferred if this changes had gone in 9ffcd02294dde059e5277e85e9c009589bc7cd5 and  29bf253 respectively.


How did you want to use Module ? I mean you can include it in Currency model but I was thinking about separate Fetcher class in app/services directory or /lib.


This came from the old code, so I didn't think too much about it. However I just surveyed its usage:

 - The server will never invoke it with a `null` argument.
 - Some tests might, but these indicate fixture failures which should trigger test failures.

With this in mind, `null` indicates a programming error, so I'm fine with it throwing an exception instead of silently converting to `Optional.empty()`.


I mean, I have two Settings, one for The default Download and if it fails another one which ist tried in the Second round...


This is wrong.


sdafaf


Yes ;) I thought that it is better to leave this to know what it does, in case of if I would want to use RabbitMQ in other project ;)


Avoid unused parameters such as '$project_id'.


Let's get this integrated into RRD4J, can you submit a PR at https://github.com/rrd4j/rrd4j ? Thanks!


should we find some exist code to change or write by our own ?


I'd love to integrate this too, PR at https://github.com/rrd4j/rrd4j ?


Hey @keflavich, this conversion fails even when I pass equivalencies=u.doppler_radio, should I specify a velocity_convention as well?


Why is `&:focus` overwritten here when it is set just 4 lines above? Also, why is there different styling for `&:focus` and `&:hover`?


dgdsg


We don't follow Numpy convention.


Always better to modify , saves time


It is the end of the sentence "Il reste 8 jours pour appeler vos députés".


We'd welcome a PR at https://github.com/rrd4j/rrd4j!


You could deduplicate code here by increasing ``weeks`` by 1 and popping the last ``dict()`` entry from ``weekly_contribution``. I suggest we tackle this after we merge it.


why is the rtl selector needed? isn't it sufficient to just force debug toolbar direction?

```css
#yii-debug-toolbar {
    direction: ltr;
}
```


Condition inconsistency. Look, in one case you return hash with rates, in other Currency record.


There is a typo: `fileds` -> `fields`


I implemented this as fetch( key, sizeHint ) - can be per-call and in the place where the app knows the size.


see: https://github.com/medizinmedien/cc-medonline-at/commit/976f586a42062a968c822a29c89655b232273d31#diff-c676e4307581fea6998843d9168a3175R160


Doesn't make sense to pass endpoint as a argument if you are sure you won't change it.


sorry to be a pain: but does this mean that  the original PR (#60) was simply accepted in good faith (a.k.a. "looks good to me")?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.175](http://teamcity.monogame.net/viewLog.html?buildId=6086&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 481, ignored: 6 Build time: 00:15:40


Done.


called here: https://github.com/medizinmedien/thumbs-rating/commit/648f6748fa00d1065146f036efced3dc24bed30e#diff-ecceb1d4c668b29c5c32f62c11b462e4R160


html
```html
<input type="checkbox" name="partner_id[]" value="a">
<input type="checkbox" name="partner_id[]" value="b">
<input type="checkbox" name="partner_id[]" value="c">
```

php
```php
print_r(request\sanitize::get('partner_id' , 'array.int', 0));
```

result
```php
Array
(
    [0] => 0,
    [1] => 0,
    [2] => 0
)
```
각 요소를 지칭할 방법이 없는 상태에서
개별 디폴트값을 지정하는것은 결국 잘못된 값일 가능성이 크네요.
sanitize로 풀수없다는 전제를 두어야 하지 않나 싶은데요..

아래와 같이 배열의 키가 지정되는 케이스라야 개선할수 있을것 같습니다.

html
```html
<input type="text" name="extra[data1]" value="">
<input type="text" name="extra[data2]" value="">
```

php
```php
print_r(request\sanitize::get('extra[data1]' , 'raw', 'test'));
print_r(request\sanitize::get('extra[data2]' , 'raw', 'example'));
```

result
```php
test
example
```

정리하자면

php
```php
print_r(request\sanitize::get('partner_id' , 'array.int', []));
```

result
```php
Array
(
)
```
와 같이
array.(int | float | ...)로 타입을 지정할 경우 자료형에 부합되지 않는값은 삭제하고, 전체 부합하지 않는 경우에 default로 대체한다.

로 정리해야할것 같습니다.


You would need to use this.previousPosition and this.previousRotation instead of this.properties.position and this.properties.rotation here.
And update them at the end of the block like you did before.


This is not correct fix, GRASS does not have to be in active mode to create a new mapset. This breaks create new mapset wizard. I am going to revert this in master and 2.8 branch, then I'll fix coverity warning in master .


Don't forget to add tests :)


Yes, but if you look at the form you will see a port input field then the user will suppose that he have to put the port number in this field and not in the host...
I dont think that this port information is pertinent in another place than the db config adapter.
If you dont want to split the port number and the host you will have to remove the port field and maybe show an exemple above the host field like "Ex: 'localhost:1111'.
I dont prefere one solution on another but a choice has to be made.


Currency.last.created_at < 1.hour.ago I guess ? ;)


넵
앞서 논의했던 부분 포함하여 변경된 내용 커밋해주시면 제가 받아서 merge하고
이후 필요한 부분은 재요청 드리도록 하겠습니다!


lol. ahh grasshopper son but as half-elves are a race not a template that logic still works; and besides RAW might say half elves are half-human & half-elf but I'm sure RAI (considering cross-breading) half-elves can be half-elf and half-anything that breeded with an elf. And if the hobbit movies are any indication their could be a half-elf half-dwarf if J.R.R wanted to go down that path. Yes a wizard can make 2+2=fish if said wizard is using wild magic.


It is `scheduler` rather than `schedule`.


I think you can rely on created_at given by Rails. You don't need to reformat date.


We disabled modules . I think you can set it to 0


Talked to @local-girl: Should be `&:active`.


You'll have to reuse this.maybeDownloadSound and store the id in the userData here because we want the sounds to be randomly assigned to lamps, but beyond that be persistent between users and sessions.


넵
해당 pull request는 close할께요.
주신 의견들 모아서 반영할께요~


Device aren't universal ....
Every device have different sensor & titan have different audio
You must add device assert


is there any reason to use  `map` instead of `mapValues`?
the `mapValues` should preserve partitioning, thus likely reduce number of stages needed.


넵 감사합니다!


Ok moved o issues https://github.com/liveservices/LiveSDK-for-iOS/issues/60
Thanks.


I guess this one would be nice for the folder:

[img]http://i.imgur.com/vaNtSpm.png[/img]


I prefer to have the full names instead of `figW`, `figH` for readability.


The dedicated _oauth list of endpoints is a good idea I think.

Something like this?

```javascript
_domain:
{
    api: 'https://api.dailymotion.com',
    // ...
},
_oauth:
{
    logout: 'https://www.dailymotion.com/oauth/logout',
    authorize: 'https://www.dailymotion.com/oauth/authorize'
}
```

Also do you confirm that we can break compat with existing oauthAuthorizeUrl property?


@ns827 PHP는 메서드명의 대소문자를 구분하지 않는 걸로 알아요


Is this fixed in some release? What version?


Credit to @slash1andy


changed only spelling


this is a comment sample


This wont work, i am getting
Running "jasmine_node:specNameMatcher" (jasmine_node) task
Running "jasmine_node:projectRoot" (jasmine_node) task
etc ...


Found BROKEN by quick.
<casadi::MX, std::allocator<casadi::MX> >&, std::vector<casadi::MX, std::allocator<casadi::MX> >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:139:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Horzsplit::evalFwd(const std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&, std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:157:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Horzsplit::evalAdj(const std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&, std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:178:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Diagsplit::evalMX(const std::vector<casadi::MX, std::allocator<casadi::MX> >&, std::vector<casadi::MX, std::allocator<casadi::MX> >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:222:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Diagsplit::evalFwd(const std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&, std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:244:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Diagsplit::evalAdj(const std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&, std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:269:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Vertsplit::evalMX(const std::vector<casadi::MX, std::allocator<casadi::MX> >&, std::vector<casadi::MX, std::allocator<casadi::MX> >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:313:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Vertsplit::evalFwd(const std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&, std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:330:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp: In member function ‘virtual void casadi::Vertsplit::evalAdj(const std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&, std::vector<std::vector<casadi::MX, std::allocator<casadi::MX> >, std::allocator<std::vector<casadi::MX, std::allocator<casadi::MX> > > >&)’:
/home/casadibot/slaves/linuxbot/quick/source/casadi/core/mx/split.cpp:349:9: error: unused variable ‘nx’ [-Werror=unused-variable]
     int nx = offset_.size()-1;
         ^
cc1plus: all warnings being treated as errors
make[2]: *** [casadi/core/CMakeFiles/casadi.dir/mx/split.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [casadi/core/CMakeFiles/casadi.dir/all] Error 2
make: *** [all] Error 2

```


@jfoug I can't find the remaining problem. Somewhere in there, there's still a hard-coded width of 4.


Updated/fixed in https://github.com/dirkx/OpenSC/commit/ccd3e6b847e0775b6c5ac4ae6abe741b1f3ac460.

Thanks!

Dw.


1- two nested if conditions, why?

2- indentation is out of order,

should be:
"def create
  		@landmark = Landmark.new(landmark_params)
       		if @landmark.save
     			redirect_to @landmark
   		else
     			render 'new'
		end
end"


`/Users/janderss/dev/casadi/./casadi/core/function/schemes_metadata.hpp:93: Warning 490: Fragment 'is_null' not found.`


separate every two methods by an empty line.


I agree - let's just specify this as an API change and be done with it. I'll make a note of it.

Doing that kind of code massage without a full C parse is bound to lead to corner cases which we'll have to support and pamper through lateron. I mean with the instcomp-NG based on pycparser we could.. but its just not worth the effort now.

I guess I shouldnt merge this then, right?


margin: шта; будет работать лучше :)


end of code review, 2 notes added.


@ranaelfedawy


How does PHP5.3.3 behave, when you completely remove the abstract function definition, instead of defining it with an empty body?


What exactly won't work?


This isn't used anywhere.


1: M111 unrecognized component name: BibIndex
3: M190 line is too long (73 > 72)


Incosistency Marcin :) Here you use Publisher and few lines above in before hook there is publisher variable. Get rid of it.


Не называй классы с большой буквы, плохой тон - Image, Text, ReadMoreLink


По-моему не будет работать как задумано - mGenerator по прежнему указывает на старый объект


Soo much indention


1: M111 unrecognized component name: BibCirculation


Should probably be a method in EEV (results.alwaysEvaluateToFalse())


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13674/testReport/) for this commit**


1: M111 unrecognized component name: WebSearch


Hi @garyburd

Is there anything that I need to aware of? It seems you are trying to create a single binary that does all the necessary work instead of using several independent binaries. If there is anything that I can do please let me do. I'm currently checking gvt and  reading the code so I can get familiar with it. I'm totally open and eager to help on my side.


@samdark any notes on that?


I didn't touch the original line:
https://github.com/oparoz/core/commit/74bf9806b0fd17c82a5d3048d03a8dc735a2ce04#diff-18fbdb7eabef5315cacf23e5a9dd6970L522

but the whole class will move to an app, so all these changes can be made as part of the move


Thanks. I've opened https://github.com/spring-projects/spring-boot/issues/2788.


Has boolean parameter 'stringify' (BooleanParameter)


Is controlled by argument stringify (ControlParameter)


Has approx 7 statements (TooManyStatements)


Has boolean parameter 'overwrite' (BooleanParameter)


Has approx 6 statements (TooManyStatements)


имхо resetGenerator будет более логично


https://msdn.microsoft.com/en-us/library/ms173163.aspx
Read carefully: Things to Avoid When Throwing Exceptions


Thx much. That looks better. Will correct.


Thanx


Error in implementation. Write Unit tests!


Lecker lecker


I got error on line 449 because var 'ctrl' is not defined.
```
TypeError: Cannot set property '$render' of undefined
    at link (http://localhost:1337/js/dependencies/dynamic-forms.js:449:24)
```
I suggest changing to
```
if (!ctrl) {
          // Doesn't have an ng-model attribute; nothing to do here.
          return;
        }
```


Reviewed


By putting the options outside the 'options' group the task jasmine_node gets broken. It tries to run each option as a sub-task name.

Also in the README file of version 0.3.0 the grunt config options are still declared the old way.
I cannot get the jasmine_task to run by using either the old and new grunt config.


not authorized to send to gmail.com


It's for websites that support both and render `<html dir="rtl"` for RTL version.


shen me gui daima


ni zai shuo yiju shihsi kan


I tried that but the format is not stored inside the map. All embedded images are assumed to be RGBA.


that does not exactly the same thing I think?!


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/10810/testReport/) for this commit**


It would be of great help if you added keyword "COORDSYS".


@da-anda Should I really copy: ```Limit GUI updates when playing video``` above all those entries?


注意說明


This will fail, if there is no "::" in the include path (which is an option, not requirement).
The dirty solution would be to always add a "::" to the include path, but this will cause problems with ``` array_map('xp\path', explode(PATH_SEPARATOR, $inc))``` because $inc is an empty string and xp/path will convert this empty string to the path of the current folder which will be added to the return array.


Yes, I'm still waiting my pullrequest to be merged.. :)
They merged similar one in 24 hours (when mine was ready before the newer one and the newer one has a bug)...
Described it here: https://github.com/driftyco/ng-cordova/issues/721


Long time out


merge


Did you try cloning the source for this task and running the 'grunt' command?
You can look in the Gruntfile.js to compare it to your config, but it should be working.


Implication of exposing SagaMessage is that I now temporarely exposed `SagaMessageHandledBy`. Do you see value in that? Or should we hide it again and for testability reasons only expose isAllowedToStart as bool and make the other property internal get and set?


See https://github.com/Particular/NServiceBus/commit/ef985c1783e3356ccfb2269ba9c4a1e3a530ebfc#commitcomment-10619589


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13675/testReport/) for this commit**


哦!!


It still doesn't work well but I want to pick up development in the next
few days and fix some outstanding issues.
On Apr 8, 2015 12:21 PM, "Omar Gonzalez" <notifications@github.com> wrote:

> Did you try cloning the source for this task and running the 'grunt'
> command?
> You can look in the Gruntfile.js to compare it to your config, but it
> should be working.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jasmine-contrib/grunt-jasmine-node/commit/84f6380d0461b6345ae3125fe671427d6b694690#commitcomment-10619586>
> .
>


@yjkim0 php에서는 대소문자를 가리지 않도록 수정하고 해당 내용을 반영하지는 않겠습니다.


@kangax i was thinking back to this commit.

this commit is still fine if we want to render individual object one by one ( for dirty rect checking for example) but this commit won t allow to render individually an object that is inside a group without rendering the group before it,  because the group transform is not set.

is this fine for you?


Ok, thanks for reply.
Just moved to issues:
https://github.com/liveservices/LiveSDK-for-iOS/issues/60

On 07 Apr 2015, at 19:25, Ace Levenberg <notifications@github.com<mailto:notifications@github.com>> wrote:

Hello and thanks for the input!
We are currently aware of the issue. Could you create an issue here<https://github.com/liveservices/LiveSDK-for-iOS/issues> with the same information so we can track it properly?
Thanks

—
Reply to this email directly or view it on GitHub<https://github.com/liveservices/LiveSDK-for-iOS/commit/c6e913c144b220df2ebfe2c29c126fad97d07e27#commitcomment-10606149>.


Java is Pass-by-Value, why not reusing the class level object ? You current value is copied to the method in numerous case.


or isn't valid jSON


I propose to move this in the SystemUtility class.


Is this a good name?


Ok, missed that. sorry

From: Stefan Eilemann <notifications@github.com<mailto:notifications@github.com>>
Reply-To: biddisco/Lunchbox <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday 8 April 2015 10:49
To: Eyescale/Lunchbox <Lunchbox@noreply.github.com<mailto:Lunchbox@noreply.github.com>>
Cc: cscs <biddisco@cscs.ch<mailto:biddisco@cscs.ch>>
Subject: Re: [Lunchbox] Use a custom user defined space to reserve for async value storage (2fc5d4c)

I implemented this as fetch( key, sizeHint ) - can be per-call and in the place where the app knows the size.

—
Reply to this email directly or view it on GitHub<https://github.com/biddisco/Lunchbox/commit/2fc5d4c8f952e55a9e031eb5330dfba173ff985e#commitcomment-10619041>.


I propose to move this in the SystemUtility, or even make a new class UserSession or something like that.


I had to do this as a separate rule because the netgo check used for the other EXEs was failing (presumably because the signal proxy doesn't import net?) - not sure if this is the best way


Shouldn't it be "Raw message"?


Should we support more than SIGINT?


a bug in line 312, should be
if(1==$options['limit']) return reset($result[$field]);


Instead of adding a newline at the end of PHP source files, it is generally accepted to just leave off the closing "?>" tag - also leaving the file to end with a newline


Should this be inside an infinite `for {}` loop?


@nfeske: add if you want to


Should you set the npm version ?


What is the 'menu-content' class ?


Sounds reasonable to me. I (we) don't use speck install as we've configured our speck install slightly differently. You'll have to ping another developer to commit it. Best bet is to jump into IRC on #speckcommerce and ask someone in there.


add comment directly in the script too about options


nice


Thank you so much!


is this all cosmetics?


Then it means I need to update three files whenever I want to add or modify options... no thanks.


po stronie serwera pojawiła się w drugiej kolumnie informacja - adnotacja o modyfikacji i możliwość Splitowania


You rejected a valid patch anyhow on the grounds that it doesn't solve a wider package management problem. I guess a typo fix wouldn't have qualified any better. And it didn't :(


We can look up declarations by name in O(1) time now instead of O(n).


to było dopisane na localu


![jz3c7e2](https://cloud.githubusercontent.com/assets/11771132/7042534/44d21164-ddeb-11e4-9e6f-cafe35fed824.jpg)

Какой именно? в классе .Text?


Reorder the list


@rpl: I'd rather disable this feature. The 'Packet Details' tab is selected too often (every time the state of the packet list changes), so also, e.g. when the clear button is pressed, when a test packet is sent or summary created.

It's fine to keep 'Send packet'  side bar selected when the selection changes.

Honza


Good catches, thanks! Committing fixes now...


I could install it via `sudo npm install -g npm@2.7.3`, but I have no way to test the bootstrap script. Could you try?


Has approx 11 statements (TooManyStatements)


Has approx 16 statements (TooManyStatements)


Has approx 12 statements (TooManyStatements)


Performs a nil-check. (NilCheck)


Has boolean parameter 'overwrite' (BooleanParameter)


Cyclomatic complexity for insert_all is too high. [7/6]


Assignment Branch Condition size for insert_all is too high. [25.71/20]


Method has too many lines. [18/10]


Method has too many lines. [11/10]


Operator `||=` should be surrounded with a single space.


Cyclomatic complexity for transform is too high. [9/6]


Method has too many lines. [15/10]


Indent `when` as deep as `case`.


cc @edolstra hope this is fine.


Yup, it's him!


for "radial.js.org" the value must be "ckgrafico.github.io/radial"


Why don't we just print the 64-bits int instead of casting everywhere?


```
<section id="videos">
  <category id="videoacceleration">
  <group id="3">
  <setting id="videoplayer.limitguiupdate" type="integer" label="38013" help="38014">
    <level>2</level>
    <default>10</default>
    <constraints>
      <minimum>0</minimum>
      <step>5</step>
      <maximum>25</maximum>
    </constraints>
    <control type="spinner" format="string">
    <formatlabel>38016</formatlabel>
    </control>
   </setting>
</group>
</category>
</section>
```
```
#: Dear Translators - the following formatting is used to indicate the maximum number of fps, the gui is rendered
#: when we are playing a video. This reduces gpu usage on slow systems a lot.
#: system/settings/settings.xml
msgctxt "#38016"
msgid "%d fps"
msgstr ""
```

@Montellese: Do you have an additional hint on how the special case can be integrated?


for "radial.js.org" the value must be "ckgrafico.github.io/radial.js" (without https)


nice!


I don't feel any differnce but i keep further testing. No issues so far.


This doesn't work, at least not with this PR.  `qi::double_` returns a `double`, not a `std::string`.  So there's no way how to encode the additional `%` in this PR, unless `number` becomes a struct containing a double and a "unit", which leads to larger changes in other parts ...


what do you mean fritsch? I doesn't help to repeat the string label as contextual note - the contextual note for regular labels should describe the usecase, something like "label of a setting doing this and that" or "headline of a dialog showing X", "name of a menu item". For settings descriptions otoh it does make sense to mention that it's a description for setting X with label ID Y so that the same phrasing will be used when translating.


Prouf http://www.3dmark.com/3dm/6554154

The performance difference between dx11 and DX12 is really huge.
And again, the drivers for Nvidia DX12 is far from being final release, it is 349.90 and is missing some thing (CUDA) and DX12 which is integrated in Windows 10 does not quite finished, so for likely figure is still evolving.


Ah!!! I should have read that better. Got it:

```
<section id="videos">
  <category id="videoacceleration">
  <group id="3">
  <setting id="videoplayer.limitguiupdate" type="integer" label="38013" help="38014">
    <level>2</level>
    <default>10</default>
    <constraints>
      <minimum label="38015">0</minimum> <!-- Off-->
      <step>5</step>
      <maximum>25</maximum>
    </constraints>
    <control type="spinner" format="string">
    <formatlabel>38016</formatlabel>
    </control>
   </setting>
</group>
</category>
</section>
```
```
#: Dear Translators - the following formatting is used to indicate the maximum number of fps, the gui is rendered
#: when we are playing a video. This reduces gpu usage on slow systems a lot.
#: system/settings/settings.xml
msgctxt "#38016"
msgid "%d fps"
msgstr ""
```


Please cut down on the amount of Scopes you request. I would suggest limiting this to the most basic (which is "openid") and let users request more scopes if they want to.

We get many complaints on the other providers where people feel we request too many scopes by default, so I do not want to get into that situation again


@da-anda: see above? I think I rename the "Off" to "No Limit" then that gets clear.


Test whether we skip the right number of frames


please use sun coding conventions!!!


Move commentary back


You should check out Lapis' style. - https://github.com/LapisBlue/Commons/blob/master/etc/intellij/lapis_intellij_style.xml


Is this working for values between 10 and 19? Doesn't seem to me from reading the code, but maybe I'm missing something.


Well in your Gruntfile.js you still have the 'options' wrapper
```
jasmine_node: {
        options: {
          specFolders:[],
          ...
```
But in jasmine-node-task you refer to the option values like:
```
var projectRoot       = grunt.config("jasmine_node.projectRoot") || ".";
```
Which returns undefined, this should be jasmine_node.options.projectRoot
So the tests run in that case, but all options go to their defaults.

By using the Grunt config described in this commit (outside 'options') i get the first error i mentioned.


Assert the size of structures


I invented this message by myself


Oh, that's truly a mistake, but I think ```bool``` is a better option here, how do you think?


The header inclusion seems mandatory, so anyone compiling against mpfr should need gmp as well.


In what context is it failing?  What is the input?  Which line of test code specifically?  Either this indicates a place where `SpectroscopicAxis` is doing the wrong thing or this is a test that *should* fail.


I used as below. But usually it looks like:
protected static Class<?> PKG = CallEndpointMeta.class;
BaseMessages.getString( PKG, "m_code");


You may want to change 'full stop' to period. From my experience more understand period.


As discussed : This commit is not relevant for this PR. Moreover, please add a functional test case to cover why this change should be done.


@AlwinEsch @AchimTuran @kib

there something quick

![defaultaddonaudiodsp](https://cloud.githubusercontent.com/assets/3521959/7042825/862365aa-dddc-11e4-8f24-424f67166ae7.png)


I think this should read "custom, enterprise-grade Node.js applications" not "customize**d** enterprise-grade Node.js applications".


1: M111 unrecognized component name: BibIndex


Okey dokey!


@johnsimons @SzymonPobiega @andreasohlund what is your thought on this comment I made?


hey


What about "Last n commits"?


Shouldn't I `reject` instead of `requeuing` ? It will return and probably it will not find currency again.


it works ?


What about arguments which are also arguments of echo?

Since we use bash, I would prefer

```bash
"${cmd[@]}" "${@//--no-logger/}"
```
I am not sure if that preserves parameters with spaces as separate parameters, though, but maybe that's not so important for us.

@lloesche, do you agree?


Presumably this is required because: https://github.com/logstash/logstash-logback-encoder/issues/85 means connections are not re-established if dropped.


Тому кто читает этот код - совершенно не очевидно, зачем обновлять сылку. Чтобы исключить возможность подобной ошибки лучше убрать из фрагмента геттер, вместо него прокинуть наружу next() и в активити прикапывать ссылку на фрагмент, а не на генератор.


TeamCity ChameleonForms :: Continuous Integration [Build 232](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3548&buildTypeId=bt20) is now running


有氧运动的时间要连续20分钟以上才有效果。心率太低也证明实际上没有达到运动效果。


Also should free char *  inside nodes.


No

I will look through the changes in the previous commit and add anything on top of that


Why was this removed?


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0-PullRequest113+013](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3548&buildTypeId=bt20) outcome was **FAILURE**
Summary: Tests passed: 2231; compilation error: ChameleonForms.Tests\ChameleonForms.Tests.csproj Build time: 0:0:0


I think using ```self.add_header``` is more in standard with Tornado.
I tried adding this there but it fails tho :

``` python

        self.set_header('Content-Type', 'text/event-stream; charset=utf-8')
        self.set_header('Cache-Control', 'no-cache')
        self.set_header('Connection', 'keep-alive')
        self.set_header('access-control-allow-origin:', '*')
```


extra line


Note:
https://git.gnome.org/browse/libglnx/commit/?id=d59a63e switched libglnx also to glibc's xattr, but the Makefile there https://git.gnome.org/browse/libglnx/tree/Makefile-libglnx.am?id=e72b (current master) has an explicit -lattr
> libglnx_la_LIBADD = $(libglnx_libs) -lattr


@m8rge can you submit a pull request fixing it?


@SubJunk Yeah, I saw this commit and then forgot abut it totally so after I spotted this one I reconsidered that also other commit was linked to replacing MEncoder and not tsMuxeR itself :+1:
Waiting for final implementation to test it :+1:


1: M111 unrecognized component name: unapi


Nice work


Have you tried this selector with IE8?

http://caniuse.com/#feat=css-sel3


1: D100 Missing docstring in public module


LGTM

I only do not understand the last sed and it's AWK END equivalent.

@lloesche what do you think?


TeamCity ChameleonForms :: Continuous Integration [Build 233](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3549&buildTypeId=bt20) is now running


@smarterclayton that method would parse multiple resources like the string above?


It didn't?

Note that I have a hard time tracking where does changes came from in the first place ... As I have a not so old local checkout that looks rather different.


You're right. It accept nil values.


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0-PullRequest113+015](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3549&buildTypeId=bt20) outcome was **FAILURE**
Summary: Tests passed: 2559; compilation error: ChameleonForms.Tests\ChameleonForms.Tests.csproj Build time: 0:0:0


Thanks @uNiversaI, this is nice for me has not seen before that AudioEncoder has used nearly the same icon for it.


be more explicit of what type of trans you need for plotting. It's a bit too cryptic here.


check the from too


`${GCOV_TOOL:-gcov}` (i.e. `$GCOV_TOOL` if set, else `gcov`) should work in the shell used on Travis, and that could then be merged to `jrl-travis` if this solves your problem.


and raise an exception if the trans provided is not the good one.


Are you sure about that? At least I would like to read an explanation here.


넵~


No, it's actually just implemented within our project. It will probably be migrated to the CCRE at some point, but it's not yet stable enough for that.


MarkdownDocs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (617 of 617 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.02%25-green.svg)


It was written this way because we want to get the time as soon as possible. Is this primarily a performance concern?


Oops, wrong copy&paste.

Just reading the code; I have no any Apple devices around.


Fixed. Sorry about that.


@Daniel15's point is a good one, this code should be agnostic to the style of the table. We will have to look at a better way to do these calculations in the future, maybe we can change the box model we use to borders don't increase element dimensions.


For some reason, iTerm is changing the background color to a mid gray:

![screenshot 2015-04-09 01 03 00](https://cloud.githubusercontent.com/assets/297407/7057998/317455be-de54-11e4-8c7f-516e237560a7.png)

You should check out Vundle, I think it's practically superseded Pathogen. That said, in its current state this won't work with Vundle. I believe it expects to find the file in a colors directory.


Definitely keen, what do you have in mind?


:heart:


Is this the only significant code change in this commit (other than the new tests)? It is hard to tell whether there are other parts to this fix with the whitespace changes.


Added database migration file to add a password hash, called a password_digest here, to each user


Yikes; good catch.


Updated version and email location.


I'm not sure where will be the best place to add the mandatory validation. Initially, I was thinking having the removal of SLASH in PropsValues. Yet, for some reason, PropsValues is not usable in the validator. When I import PropsVaues in the class, it gives me errors when I compile. That's why I use PropsUtil to get the property value.

This method `getSpecialChars` is used to get the special characters from portal.properties, and it's the only place where SLASH is removed. This method is called in `getDescription` and `hasInvalidChars`.


That's a good point. These should probably be strings instead.


@zzlei from this commit on, you should be able to run `../run/john -test -form:avx512` for testing just the formats that include the string "AVX512" or "MIC" in the algorithm name.


@weierophinney With this line removed, (in zf-rest 1.0.4) my application is broken. Zend Framework 2.3.5.

Any thoughts? Was the removal intentional? The commit message sounds like the opposite of what the change is.


Class 3 / Lab 1


What is the `cartographer-server` project?


Ok, I found the [`cartographer-server` project](https://github.com/SumAll/haskell-cartographer-server)


Profe @daton seria asi el de buscar todos y guardar o estoy mal


Is i==1 the last response before returning the response ?
If so next should be empty right ? Can we call it something else ?


I don't think a simple boolean dereference matters a lot when getting the time.
It's just good practice to return early when there's an obvious "disable all" big switch turned on. It will also make future refactors of the code easier.
Feel free to drop the suggestion if you don't think it adds any value.


I worded this to preface a procedure, because I re-formatted the following commands as a numbered procedure, because that's what it is.


I'm confused how setting m_lock_owner_state causes cancelling requests and flushing


This is improper use of a code block.


Ah, I see your point. Yeah, having it higher up in the function makes it harder for someone to slip in a change that violates its intent. (The time capture was definitely a minor concern.)


This procedure is proper tech writing style for something that includes multiple steps. Also, we are using the sidebar block for command syntax, as per our Documentation Guidelines for OpenShift.


These don't deserve such prominent headings, nor do they belong in the table of contents for this topic, which is why I was simply making them bold.


should add a descriptor


The SDF specification says that it is set at the pose of the child link, not the parent link.

In general, you miss a lot of the defaults that SDF has. You probably should have a look at http://osrf-distributions.s3.amazonaws.com/sdformat/api/1.5.html


Don't start a sentence with "or". The previous wording is clearer.


Again, this procedure is proper tech writing style for something that includes multiple steps. Also, we are using the sidebar block for command syntax, as per our Documentation Guidelines for OpenShift.


Again, this is improper use of a code block.


Would it not be better to say "This sword is both aesthetically pleasing and practical."


Right - those logging levels are not needed. Felt better to have the implementation commented out, rather than empty. Happy to go the other way if there's a preference.


I'm not sure why you re-worded this. I'd already re-written this for clarity.


Again, these don't deserve such prominent headings, nor do they belong in the table of contents for this topic, which is why I was simply making them bold.


Ok. Replaced with `Neo4jJobScheduler`.


You posted something about binder in my repo hours ago, I was too tired to reply and went sleep.
Seem that the comment has been deleted.
The memory performance is still poor on my SGSA, and seem that binder crash has been disappeared in my dmesg.
Actually, I haven't printed the log and checked it carefully.


This is improper use of a code block. See our Documentation Guidelines ( https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc )

Specifically, look at the part about command syntax. We use the sidebar block for commands, not the code block.


This is improper use of a code block. See our Documentation Guidelines ( https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc )

Specifically, look at the part about command syntax. We use the sidebar block for commands, not the code block


LGTM


You're moving! :dancer:


Um, this breaks hygiene.

    > Language.Hakaru.Simplify.toMaple (dirac (integrate 1 2 (\x -> integrate 3 4 (\y -> unsafeProb (x+y)))))
    "Typed(((x0->Pair(measure, (x1->(x1(x0)))))((proc () local x; x := gensym(`h`);Int((proc () local x; x := gensym(`h`);Int((x+x),x=3..4) end proc)(),x=1..2) end proc)())), Measure(Prob))"
    > Language.Hakaru.Simplify.simplify (dirac (integrate 1 2 (\x -> integrate 3 4 (\y -> unsafeProb x))))
    dirac (7/2)

Please let me know if you want me to fix the hygiene for you (without affecting the rest of your change).


@bryanyork We appreciate the effort, ping us at developers@pagerduty.com so we can send you a shirt or something!


Why would you move the "Testing" heading here? The previous command is related to testing. Also, improper use of a code block, see command syntax guidelines...


Not sure why you re-wrote this. The link isn't really required, and the previous wording was more succinct.


Can you create a release in Cocoapods? Thanks!


improper use of a code block, see command syntax guidelines


typo: should be 'level 11'


This change appears to have sent the AWD skeletal animations haywire, from this at 65d2eb9:

![09042015011749](https://cloud.githubusercontent.com/assets/6105654/7058331/e094f1e0-de57-11e4-8d37-8258ed035715.png)

... to this at db1a911:

![09042015012210](https://cloud.githubusercontent.com/assets/6105654/7058333/e9b1e396-de57-11e4-8028-e8d1a29b0197.png)


improper use of a code block, see command syntax guidelines

also, if it's two commands/steps, it should be a procedure, as it was.

improper use of a code block, see command syntax guidelines

also, if it's two commands/steps, it should be a procedure, as it was.


"const char*" spacing is inconsistent within line, some matching original (space after *) others not (no space between * and name).


I find this comment style slightly disorienting too (probably largely because I'm unaccustomed to it). I think @ptomato prefers it because it saves characters and is generally concerned with the amount of time changing comment styles (and other nits) is eating up in code review. I wonder if it's worth talking through a rule of thumb about when we do/don't change comment styles. One thing we could do is update the C style guide if we have a general preference about this at Endless.


develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2105 of 2197 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.81%25-yellow.svg)


Some inconsistent whitespace.


I worded this to preface a procedure, because I re-formatted the following commands as a numbered procedure, because that's what it is.


@thestandardtoaster Read and learn.


Ah shoot.  Please revert.  And I am going to need help to change quant so that it does not break hygiene.
Our 'using' the fact that Maple has some inkling about higher-order functions seems to be pushing things into a place where the code simply stops working, quite abruptly.  [See previous email]


ah. of course.. my bad.


This is improper use of a code block. Also, this should be a procedure, as it was, since it has multiple commands/steps.


This procedure is proper tech writing style for something that includes multiple steps. Also, we are using the sidebar block for command syntax, as per our Documentation Guidelines for OpenShift.


These don't deserve such prominent headings, nor do they belong in the table of contents for this topic, which is why I was simply making them bold.


Again: this is improper use of a code block. Also, this should be a procedure, as it was, since it has multiple commands/steps.


Don't start a sentence with "or". The previous wording is clearer.


Again, this procedure is proper tech writing style for something that includes multiple steps. Also, we are using the sidebar block for command syntax, as per our Documentation Guidelines for OpenShift.


improper use of a code block


I'm not sure why you re-worded this. I'd already re-written this for clarity.


Yes I was afraid this would happen. I was already expecting to have to fix things. Can you please send me the code you used to load the animation (just the parsing snippet)? Alternatively, add an example to the Examples app. I was going to do it but if you have something already then thats faster.


Thanks for the pull request. Really appreciate :+1:


"cartographer"


The previous sentence was clearer, this current revision contains grammatical errors.


Thanks for the pull request.  I end up using environment variables for this.


I don't want to spend too much time on this either, but other similar comments (e.g. in `record_stop()`) have another style, so since this is new code, we might as well make it consistent.
The C style guide does not mention explicitly comments, but most of the C code we inherit (GNOME platform, freedesktop, etc) uses a consistent style like this:
- no C++ comments
- Multi line comments are like this
```
/* multi line
 * comment
 */
```
- single line comments are like this
```
/* single line comment */
```

This is a good topic to discuss at next architecture meeting perhaps, so for now don't bother changing existing comment style. (Incidentally I don't think going through existing code just to change the comment style is ever worth doing, unless you're already touching most of that existing code).


I felt that the previous "Creating a Container" heading was clearer. Maybe that's a conversation I can have with Bilhar about whether or not we are striving for identical headings between images, for consistency.


Again, these don't deserve such prominent headings, nor do they belong in the table of contents for this topic, which is why I was simply making them bold.


This is improper use of a code block. See our Documentation Guidelines ( https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc )

Specifically, look at the part about command syntax. We use the sidebar block for commands, not the code block.


QBasicAtomicInteger has `operator T() const Q_DECL_NOTHROW { return loadAcquire(); }`
Without the cast, wouldn't `inline void set_unsafe (int v) { ref = v; }` assign `v` to a temporary?


This is improper use of a code block. See our Documentation Guidelines ( https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc )

Specifically, look at the part about command syntax. We use the sidebar block for commands, not the code block.

Also, why'd you remove the sentence that introduced the command?


do you need to do `` sum += value * values.count(value)`` ?


can you add a duplicate element here ?


improper use of a code block.... see command syntax...


This commit broke file upload via SWORD:

```
Caused by: java.lang.NullPointerException
	at edu.harvard.iq.dataverse.DataFile.getLatestFileMetadata(DataFile.java:291)
	at edu.harvard.iq.dataverse.DataFile.getFileMetadata(DataFile.java:282)
	at edu.harvard.iq.dataverse.ingest.IngestServiceBean.createDataFiles(IngestServiceBean.java:420)
```


Holy hell this is beautiful. Why the hell did you remove it?


The name `@thin_interval` is a bit confusing in the sense that it may return an interval which has a non-zero diameter. Maybe a word of caution somewhere should be provided.


improper use of a code block, use the sidebar block for command syntax.


About the "stty -ixon"

Great, it works!
Thanks for that Jonathan


Agree with the change.


why remove this?


This is improper use of a code block. See our Documentation Guidelines ( https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc )

Specifically, look at the part about command syntax. We use the sidebar block for commands, not the code block


Well TBH, it could be `typedef int hb_atomic_int_t; #define hb_atomic_int_add(AI, V) reinterpret_cast<QAtomicInt &>(AI).fetchAndAddOrdered(V)` and I'm thinking about a way to use QAtomicOps directly on the int.


Specifically, agree with the addition.  It's neat that you can edit the file in a browser.  Need to figure out if file can be edited on GitHub (Android) and ioctocat or codehub (ios) as well.


Don't start a sentence with "or".


@voidcase volym borde nog sänkas på proximity sounds, agree?


@smarterclayton Is it correct to assume that a template in `osc new-app` will be a `ComponentReference`? With the same weight as a imageStream? Notice I'm only handling stored templates for now.


That is true. Can you think of a better name? Otherwise I will just add documentation for `@thin_interval` stating that this creates an interval that is "as thin as possible" with representable endpoints.


@msjulie thanks for the help. nice changes.

:paperclip: https://developer.apple.com/swift/blog/?id=25
:paperclip: http://nshipster.com/swift-1.2/

my friend @rflex and i are going to be starting a project at some point that offers a complete swift camera library too, which should be fun, http://github.com/nextlevel/NextLevel


improper use of a code block, see command syntax guidelines

also, if it's two commands/steps, it should be a procedure


seems fine to me


don't start a sentence with "or"


improper use of a  code block, use proper command syntax (sidebar block)


improper use of a code block, use proper command syntax (sidebar block)


Removed the largemodal.php and now load the modal HTML with ```.html()``` and callback with ```.promise().done(function(){ // })```


Used ARM manual from http://simplemachines.it/doc/arm_inst.pdf to determine register set.
Set up array with access to functions to handle Stack Pointer, Link Register, and Program Counter(PC)


Oh, now I think I understand what the previous definition was trying to do: guarantee that the resulting floating point numbers are correctly rounded. However, I don't see how to do this correctly...

```


Conversion instructions are in the juliaopt-notebooks readme :)
But I think there was just a new release of Anaconda? Will need to test out to confirm it comes with IPython 3.


It seems to fit at this point, but start to not make much sense when you get to the point of handling pipelines, etc.


Much stripes


This is the double derp


(I'm not particularly familiar with the ruby ecosystem, this comes from the perspective of a Travis CI user.)

@travisci still uses this version by default, and it is features in its [docs](http://docs.travis-ci.com/user/languages/ruby/).

The Scala project uses a Travis CI build to render our specifiication using Jekyll; this started [failing today](https://travis-ci.org/scala/scala/builds/57737768) with the error:

![image](https://cloud.githubusercontent.com/assets/65551/7058632/196f32c8-dea8-11e4-990b-a27c9c463512.png)

We'll try bumping to a higher Ruby version, but I thought I'd let you know.


just want to make sure that the int 0-255 will not be interpreted as any char command.
Also I think you meant char "p" for pen?


Don't we want to keep the referrer here, if the referrer here was not the root_path?


Sorry guys for the delay. I don't have access rights to push this to RubyGems myself. I only tagged 5.5.1.2 to let you use it in your Gemfiles.
I tried to reach @arthurzurb by email asking him to push it, and also asking for access rights if possible.
Help me in reaching @zurb/owners folks. Looks like the Yeti ate them all :yum:

Here is my email sent the 26/03, if it helps

> Hello Arthur,

> I am sorry to bother you by email. I can’t find a better way :)
>I just tagged a new version for foundation-rails, fixing bas JS loading in Rails. https://github.com/zurb/foundation-rails/releases/tag/v5.5.1.2 (follow up to https://github.com/zurb/foundation-rails/pull/117)
Can you pls push it to RubyGems?

>Speaking of that, I can maybe help you guys with this, by taking care of foundation-rails from end to end.
Mark gave me push access to the repo last year after some work I’ve done triaging issues and some humble contributions.
>I’ve continued since then moderating some of the PRs and pruning the issues as you can see, but we always took too much time to push new releases to the community, as I had to ping you guys on twitter or GitHub issues like for the last one 3 weeks ago or today (https://twitter.com/mehlah/status/496107457006280704, https://twitter.com/mehlah/status/537300292715700225)

>If you think it’s a good idea, I’ll be very happy to be able to push myself releases when needed.
Let me know ;-)

>Have a nice day

>Mehdi


You were the one developed this script? It's pretty solid man!


I'm in favor of the documentation.

I just noticed the following: `@thin_interval(pi)` and `ValidatedNumerics.transf(pi)` yield different things; the first is a zero diameter interval, whereas the second is not (I think the second is correct); the difference lies in `big(a)` in line 34.


Ouch, good catch. I am actually now beginning to think that `@thin_interval` does not need to be a macro. Let me play with that.


Broken's 9/4/2015 update in source format


Crap…


I think it must be a macro (for the same reason as usual: e.g., `big(pi)` must be put *inside* the rounding), but it should never be called by the user, and `@thin_interval(pi)` should thus never occur...


sorry about the delay had lunch.
But do you like created games?


Why the "dangerous for floats" comment? `ValidatedNumerics.transf(2.1)` yields something reasonable...

Incidentally, the interval obtained by `ValidatedNumerics.transf(BigFloat("2.1"))` has diameter zero (and does not contain 2.1).


Ok, so I propose *not* to explicitly export it, as it is currently done... and maybe add somewhere in the documentation a word of caution.


Yes, image streams and templates are equal weight, and users should have to decide which they want via the arg clarifier

> On Apr 8, 2015, at 8:55 PM, Fabiano Franz <notifications@github.com> wrote:
>
> @smarterclayton Is it correct to assume that a template in osc new-app will be a ComponentReference? With the same weight as a imageStream? Notice I'm only handling stored templates for now.
>
> —
> Reply to this email directly or view it on GitHub.
>


(CobaltBlue had an effect during an online quick study of color effects online.)no.na


@johnsimons @danielmarbach from a different perspective, the learning curve always starts with handlers. Later, when a long running process is introduced, saga is presented as a solution with ability to have a state. Perhaps from the implementation point of view they are almost the same, but from adoption point of view it allows a gradual entrance into NSB world.


We probably need to decide whether some templates can be a pipeline input, and whether you are allowed to chain a template.  For instance, a template with a single dc and build probably could be chained.

I would recommend describing in this pull examples where it might make sense and where it shouldn't.  It might be fine to say component references that are templates can't be paired with other images for now (to start).

We have a follow up story @csrwng and I to do name specification (if any name conflicts exist between what you are creating and what exists, you should be prompted to --anyway or --name=prefix/suffix).

> On Apr 8, 2015, at 9:01 PM, Fabiano Franz <notifications@github.com> wrote:
>
> It seems to fit at this point, but start to not make much sense when you get to the point of handling pipelines, etc.
>
> —
> Reply to this email directly or view it on GitHub.
>


+The Working group will coordinate its progress with the ACE, DICE and CoAP
+working groups

Proposed change: change CoAP to CoRE.


I just noticed this. Amazing!


If things like `@thin_interval(pi)` should never occur, why not throw a SomethingError (MethodError, InmoralError, ...)?


> QBasicAtomicInteger has operator T() const Q_DECL_NOTHROW { return loadAcquire(); }
> Without the cast, wouldn't inline void set_unsafe (int v) { ref = v; } assign v to a temporary?

I'm not sure what you are talking about.  Does QAtomicInt implement operator =?

Well, if that doesn't work, then we want atomic_int_impl_set_unsafe / get_unsafe as well.


A simple solution is a good solution :thumbsup:


I was thinking about the following case:
```
julia> ValidatedNumerics.transf(1/9)
[1.1111111111111109e-01, 1.111111111111111e-01] with 53 bits of precision
```
The answer does *not* contain 1/9.

Compare this to
```
julia> @interval(1/9)
[1.111111111111111e-01, 1.1111111111111112e-01] with 53 bits of precision
```
which correctly contains the true 1/9.

For your second comment, again, `ValidatedNumerics.transf` should never be called by the user. The example you give is not surprising, since `transf` is just a function, not a macro, so that `BigFloat("2.1")` is evaluated first, and then the result is passed to `@thin_interval`.

So I agree that none of `@thin_interval`, `transform` and `transf` should be exported. This macro business is really complicated...!


Here we are, I found it in my client RPT.

```
Error in expression <_SaveTime) then {
_dayzMags = if (count dayz_Magazines > 0) then {dayz_Magazines>
  Error position: <dayz_Magazines > 0) then {dayz_Magazines>
  Error Undefined variable in expression: dayz_magazines
File mpmissions\__CUR_MP.Chernarus\overrides\player_spawn_2.sqf, line 209
```


Because inside a macro you don't know the *value* (or even the type) of the macro's argument.
You just have to make sure you call it with something sensible!


in/min units for linear feed-rate


I haven't tested this class yet because I keep getting compile time error when I try to run an individual java class.


Fine. I guess the documentation will have to have many explicit things mentioned that the user shouldn't do


> Does QAtomicInt implement operator =?

Actually that one might not work.  Some compilers don't like types with operator = in POD structures.

I definitely don't like any solution with reinterpret_cast<> since that is just wrong.


I found if remove white guibg, the background of macvim whiten terribly even background is set to dark,
![withougguibg](https://cloud.githubusercontent.com/assets/2748884/7058799/39369a4c-de99-11e4-8227-600df00a0804.png)
And if keep the white guibg as #282828, everything seems to be OK.
![withguibg](https://cloud.githubusercontent.com/assets/2748884/7058813/6924fe4c-de99-11e4-86c9-141607105e0e.png)
@goatslacker should we keep the guibg as black?


a


MarkdownDocs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1129 of 1129 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Found BROKEN by full.
tfunction.py
13. integration.py
14. simulator.py
15. typemaps_futurediv.py
16. matrix.py
17. ocp.py
18. mx.py
19. nlp.py
20. vectortools.py
21. function.py
22. lpsolver.py
23. ad.py
24. socpsolver.py
25. sx.py
26. mx_jacobian_sparsity.py
Ran 26 tests, 0 fails.
python internal/test_py.py python -skipfiles="alltests.py helpers.py complexity.py speed.py" -memcheck -passoptions="--ignore_memory_heavy --run_slow"
Running test in python
01. tools.py
02. qcqpsolver.py
03. linearsolver.py
04. control.py
05. misc.py
06. homotopynlp.py
07. qpsolver.py
08. typemaps.py
09. sparsity.py
10. symbolic.py
11. sdp.py
12. implicitfunction.py
13. integration.py
In python, integration.py failed:
==============================
returncode:  1
Will test these integrators:
cvodes  :  ['ode']
idas  :  ['dae', 'ode']
collocation  :  ['dae', 'ode']
oldcollocation  :  ['dae', 'ode']
rk  :  ['ode']
slow <function test_full at 0x2b39f2151b90>
slow <function test_tools at 0x2b39f2151c80>
<function test_jac at 0x2b39f2151cf8>
<function test_lsolvers at 0x2b39f2151d70>
<function test_X at 0x2b39f2151de8>
Bug that appears when rhs contains repeats
[[  7.06101844e-14   0.00000000e+00   0.00000000e+00]
 [  1.52100554e-14   0.00000000e+00   0.00000000e+00]
 [ -2.65727040e-09   0.00000000e+00   0.00000000e+00]]
collocation points
CVodes integration: evaluation
CVodes integration: evaluation with MXFunction indirection
CVodes integration: evaluation time offset
former glibc error
CVodes integration: hessian to p: Jacobian of integrator.jacobian
CVodes integration: hessian to p: Jacobian of integrator.jacobian indirect
CVodes integration: hessian to p in an MX tree
-54.6937
CVodes integration: hessian to p in an MX tree
hessian
regression test for #535
regression check for issue 92
jac= 2.28317e-07
regression check for issue 92
[2.71829, 1.71829]
regression check for issue 92
[2.71828, 2.71828]
CVodes integration: jacobian to q0
CVodes integration: jacobian to p
Linear ODE
Mathieu ODE
[[ 0.62528701]
 [-0.43405208]]
Nonlinear ODE sys
1.1368
0.607234
[[ 0.          0.02704959]
 [ 0.          0.23082395]]
[[ 0.          0.        ]
 [ 0.          0.19488495]
 [ 0.          0.        ]
 [ 0.          1.1346571 ]]

test_X (__main__.Integrationtests) ... skipped 'Ignoring memory_heavy tests (--ignore_memory_heavy)'
test_bug_repeat (__main__.Integrationtests) ... ok
test_collocationPoints (__main__.Integrationtests) ... ok
test_eval (__main__.Integrationtests) ... ok
test_eval2 (__main__.Integrationtests) ... ok
test_eval_time_offset (__main__.Integrationtests) ... ok
test_full (__main__.Integrationtests) ... ERROR
test_glibcbug (__main__.Integrationtests) ... ok
test_hess3 (__main__.Integrationtests) ... ok
test_hess4 (__main__.Integrationtests) ... ok
test_hess5 (__main__.Integrationtests) ... ok
test_hess6 (__main__.Integrationtests) ... ok
test_hessian2D (__main__.Integrationtests) ... ok
test_issue535 (__main__.Integrationtests) ... ok
test_issue92 (__main__.Integrationtests) ... ok
test_issue92b (__main__.Integrationtests) ... ok
test_issue92c (__main__.Integrationtests) ... ok
test_jac (__main__.Integrationtests) ... skipped 'Ignoring memory_heavy tests (--ignore_memory_heavy)'
test_jac1 (__main__.Integrationtests) ... ok
test_jac2 (__main__.Integrationtests) ... ok
test_linear_system (__main__.Integrationtests) ... ok
test_lsolvers (__main__.Integrationtests) ... skipped 'Ignoring memory_heavy tests (--ignore_memory_heavy)'
test_mathieu_system (__main__.Integrationtests) ... ok
test_nl_system (__main__.Integrationtests) ... ok
test_tools (__main__.Integrationtests) ... ok
test_tools_trivial (__main__.Integrationtests) ... ok

======================================================================
ERROR: test_full (__main__.Integrationtests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "integration.py", line 103, in test_full
    self.checkfunction(integrator,solution,digits=6)
  File "/home/casadibot/slaves/linuxbot/full/source/test/python/helpers.py", line 496, in checkfunction
    adjsens2 = vf.callReverse(inputss2, res2, aseeds2)
  File "/home/casadibot/slaves/linuxbot/full/source/python_install/casadi/casadi.py", line 20663, in callReverse
    return _casadi.Function_callReverse(self, *args)
RuntimeError: The assertion "sparsity().isScalar() || y.isScalar() || sparsity().shape()==y.shape()" on line 482 of file "/home/casadibot/slaves/linuxbot/full/source/casadi/core/mx/mx_node.cpp" failed.
Dimension mismatch.lhs is 0-by-1 (dense), while rhs is 0-by-0 (dense)

----------------------------------------------------------------------
Ran 26 tests in 7.622s

FAILED (errors=1, skipped=3)

==============================
14. simulator.py
15. typemaps_futurediv.py
16. matrix.py
17. ocp.py
18. mx.py
19. nlp.py
20. vectortools.py
21. function.py
22. lpsolver.py
23. ad.py
24. socpsolver.py
25. sx.py
26. mx_jacobian_sparsity.py
Ran 26 tests, 1 fails.
make: *** [unittests_py] Error 1

```


Note, I don't fully understand what `"minifierType="` does. I based it off Nate's original suggestion.

https://github.com/natecavanaugh/liferay-portal/commit/a30e3c0dcd4d413752893c0672849d685aed941c


Done - thanks for checking. It should be much clearer now.


\vspace...my only latex friend!

On Wed, Apr 8, 2015 at 9:22 PM Maxime Rischard <notifications@github.com>
wrote:

> I just noticed this. Amazing!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/huihuifan/Stat232_Preprocessing/commit/c913feeb8fead1a62b35b42906775a367c3bb960#commitcomment-10636723>
> .
>


These are IDA formatters, NOT system ones. Did you actually check that this outputs what you expect?


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


see https://github.com/filcab/patchdiff2/commit/2b1a2a2a4e83b345d1126038a62908016228772e#commitcomment-10636809


QBasicAtomicInt has no any non-atomic accessors. The only way to set/get value non-atomically is to access its _q_value member directly or by casting QBasicAtomicInt to int&.


always add fall-back font, for example font-family: "Helvetica", "Arial", sans-serif;
https://developer.mozilla.org/en-US/docs/Web/CSS/font-family


We can't import `server` at the start of events.py because `server.py`
imports `events`, results in import loop, Py yells at us.

We could put the `import` in `_handle_checker` instead of making
`server.py` push `get_context` into events.py on load (which is a much
nicer solution, I was wary of added overhead but especially if we put it in
`_handle_checker` it's not an issue)

Will fix tonight.

On 9 April 2015 at 09:35, William Pitcock <notifications@github.com> wrote:

> Where does get_context() come from if not from server?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DanielOaks/mammon/commit/3c44f410826095ba2bd8e158d2cde77d67612038#commitcomment-10635727>
> .
>


If you're looking to create a single stereo AAC audio track with no additional tracks, don't use the iOS audio option. Instead just set your audio-codec to AAC and your maxchannels  to 2 and your max bitrate to 128 in autoProcess.ini. No need to modify the code to achieve what you're doing here.

Hope that helps!


good


just one space between "a" and "href" is enough. add "#" to href.


필요없어서 지움.


add comment when closing tag, so you now later. Like this </div><!-- closing .header -->


Yeah, Im keen to just practice and learn how to collaborate online.
You can pick a game, set up the repos and then we can start?


Or did you want to create something original?


Just heard back from the AWD guys, I'll try their suggestion and see if it helps.


새로 근무 시작한 날짜를 추가함


can we uncomment it or delete it?


If Deflate is actually Zlib, shouldn't we keep the `Zlib` function instead of `Deflate`? Apart from that the PR seems perfect


Then please add impl functions for set_unsafe / get_unsafe.


Since hb-coretext has been a constant source of incoming bugs, I'd rather not touch it if not necessary. :)


![the duo prepares to journey into the quiet town](https://cloud.githubusercontent.com/assets/10382483/7059044/e26d4184-de2f-11e4-96f7-3b9756b17193.png)


After looking up other codes, I find the ```enabled``` of ```ACallForwarding``` is also bool typed, so I think bool will do a better job.


LGTM


Nevermind I figured out how to fix this issue in b40b63ddd711aa0071c820b488aa5743b782a995


@emanuele45 looks like $this->_api was removed from the likes controller in 1.1, any ideas on how to adjust for this condition ? (sorry, have not looked enough at the updates to know what to do !)


Why not reinterpreting to int&?

Anyways, let's leave hb_atomic_int_t as it currently is for now.


then it turns into java gg


ur st00pid


nice :) .


This is not the right fix for this problem: we need to find the underlying reason why tab isn't working, not hack it like this. I recommend reverting this change.


尝试


Thanks for the careful critique, but I don't agree with all of these suggestions. This is too big of a pull request, so I'll decline.


> Why not reinterpreting to int&?

Because that assumes that the implementation uses an int, and at the beginning.  Eg, you can't use a larger struct that keeps debugging info, etc; or one that uses a long instead of int.


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-69.42%25-red.svg)


Just added an AWD skeletal animation example to RajawaliExamples with the above model.


uhh, what the hell..


I think these two lines can be expressed in one:

```haskell
import Network.HaskellNet.SMTP.SSL as SMTP
```


I'm not to sure, I am new to this. But at the moment I am on the road... But I'll be home in an hour so we can talk then?


Hi Garrett,
I am a little confused.  I am signing up for my Google Analytics account but it asks for the URL of my website.  How can I find what the url is?


Like the idea. Currently, your version would still have the task pass though, even if budget was exceeded. I think it still makes sense to have the build fail in this case. What do you think?


See also https://git.gnome.org/browse/libglnx/commit/?id=376219a9c276237f21c2c5aa1f0b7875a89586b6 which I added for this.


Has boolean parameter 'stringify' (BooleanParameter)


Is controlled by argument stringify (ControlParameter)


Extra empty line detected at class body beginning.


The point is to write code that is semantically correct, in this case tell compiler that object pointed by `regionPos` can be moved. Whether it does change the binary code and/or it is really useful is another story. Unless this part of code is really performance critical we should really care about internals.


It depends, how we plan to change to gnutls.
eg.: In libgnutls-dev(=2.12.23-12ubuntu2.2) in /usr/include/gnutls/openssl.h we also have SSL_CTX_set_options, and we also have SSL_OP_NO_TLSv1, but no other (not even SSL_OP_NO_SSLv2) option I see.
It seems, that gnutls's openssl wrapping funcionality has some gaps between self and openssl.
eg. I do not se even support for tlsv1.1 and later, etc.:
/* SSL_METHOD functions */

  SSL_METHOD *SSLv23_client_method (void);
  SSL_METHOD *SSLv23_server_method (void);
  SSL_METHOD *SSLv3_client_method (void);
  SSL_METHOD *SSLv3_server_method (void);
  SSL_METHOD *TLSv1_client_method (void);
  SSL_METHOD *TLSv1_server_method (void);

And that's the complete list of methods in gnutls's header file.
(I also checked libgnutls28-dev. The list is the same)

While openssl's ssl.h also contains:
const SSL_METHOD *TLSv1_1_method(void);         /* TLSv1.1 */
const SSL_METHOD *TLSv1_1_server_method(void);  /* TLSv1.1 */
const SSL_METHOD *TLSv1_1_client_method(void);  /* TLSv1.1 */

const SSL_METHOD *TLSv1_2_method(void);         /* TLSv1.2 */
const SSL_METHOD *TLSv1_2_server_method(void);  /* TLSv1.2 */
const SSL_METHOD *TLSv1_2_client_method(void);  /* TLSv1.2 */

const SSL_METHOD *DTLSv1_method(void);          /* DTLSv1.0 */
const SSL_METHOD *DTLSv1_server_method(void);   /* DTLSv1.0 */
const SSL_METHOD *DTLSv1_client_method(void);   /* DTLSv1.0 */

However, using this approach (we have our own flags, which we can transform to ssl library's flags) seems still the reachable best solution (considering circumstances).
At least for me.


No you are right,
It's just for me to better understand the code (and be closer to the
generated bytecode).

2015-04-09 11:53 GMT+02:00 NOUGUIER Olivier <notifications@github.com>:

> AFAIK it has no impact on generated bytecode, as String + will generated
> StringBuilder calls.
> Am I wrong ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wisdom-framework/wisdom/commit/0983289e3acb029722affd378827bda3731b8ea7#commitcomment-10642076>
> .
>


There should be no need to import this (normally)


fail


... ups.


Google translate has a harder time coping with unfinished sentences, it was
easier to leave them in :-)

  _____

From: Js41637 ftw [mailto:notifications@github.com]
Sent: Thursday, 9 April 2015 21:58
To: SchizoDuckie/DuckieTV
Cc: garfield69
Subject: Re: [DuckieTV] translations for
26a6b703e6d96970ef48fca31fedcbc6148488f2 (56ec058)

You could probably have left the numbers out but doesn't matter.  :+1:
<https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png>

-
Reply to this email directly or view
<https://github.com/SchizoDuckie/DuckieTV/commit/56ec058d9527abbbc12294a7bb5
c8c90c984aabb#commitcomment-10642130> it on GitHub.
<https://github.com/notifications/beacon/AGnK-Kqwo5Sl19BAfPlWFO0-p0mKoZS7ks5
n9kSOgaJpZM4D9Ht_.gif>

---
This email has been checked for viruses by Avast antivirus software.
http://www.avast.com


Don't use `jQuery`


Since this chunk of code is used more than once now... do you think it's possible to unify this if-clause with the one in the other constructor?


That spec will pass but it isn't testing what's described by the `it`:

```
it "returns `nil` if the user has favorited another post"
```

To match this description, we want to check that `nil` is returned when `User#favorited(post)` is called on a `User` who has *not* favorited the given `Post`.


29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
36:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_SOLR_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_XAPIAN_ENABLED
36:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 36
36:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 36
36:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 36
36:1: F999 redefinition of unused 'CFG_LOGDIR' from line 36
36:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 36
36:1: F401 'CFG_XAPIAN_ENABLED' imported but unused
36:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
36:1: F401 'CFG_OAI_ID_FIELD' imported but unused
36:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
36:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
36:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
36:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
36:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
36:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
36:1: F401 'CFG_SITE_RECORD' imported but unused
36:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
36:1: F401 'CFG_INSPIRE_SITE' imported but unused
36:1: F401 'CFG_LOGDIR' imported but unused
36:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
36:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
36:1: F401 'CFG_BASE_URL' imported but unused
36:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
36:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
36:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
36:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
36:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
36:1: F401 'CFG_SOLR_URL' imported but unused
36:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
36:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
36:1: E402 module level import not at top of file
37:6: E126 continuation line over-indented for hanging indent
80:1: E402 module level import not at top of file
81:1: F401 'get_most_popular_field_values' imported but unused
81:1: E402 module level import not at top of file
82:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
82:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils
82:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
82:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
82:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
82:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
82:1: E402 module level import not at top of file
83:6: E126 continuation line over-indented for hanging indent
87:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors
87:1: F401 'get_fieldvalues_alephseq_like' imported but unused
87:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
90:1: I201 Missing newline before sections or imports.
90:1: F401 'create_record' imported but unused
90:1: F401 'record_xml_output' imported but unused
90:1: E402 module level import not at top of file
91:1: I101 Imported names are in the wrong order. Should be get_bibrank_methods, is_method_valid, rank_by_citations, rank_records
91:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.record_sorter should be before from invenio.legacy.bibrecord
91:1: F401 'rank_by_citations' imported but unused
91:1: F401 'get_bibrank_methods' imported but unused
91:1: E402 module level import not at top of file
96:1: I101 Imported names are in the wrong order. Should be calculate_reading_similarity_list, register_page_view_event
96:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.downloads_similarity should be before from invenio.legacy.bibrank.record_sorter
96:1: F401 'register_page_view_event' imported but unused
96:1: F401 'calculate_reading_similarity_list' imported but unused
96:1: E402 module level import not at top of file
97:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_stemmer should be before from invenio.legacy.bibrank.downloads_similarity
97:1: F401 'stem' imported but unused
97:1: E402 module level import not at top of file
98:1: F401 'BibIndexDefaultTokenizer' imported but unused
98:1: E402 module level import not at top of file
99:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.modules.indexer.tokenizers.BibIndexDefaultTokenizer
99:1: F401 'author_name_requires_phrase_search' imported but unused
99:1: F401 'get_field_tags' imported but unused
99:1: E402 module level import not at top of file
101:1: I101 Imported names are in the wrong order. Should be lower_index_term, wash_author_name, wash_index_term
101:1: F401 'wash_index_term' imported but unused
101:1: F401 'wash_author_name' imported but unused
101:1: F401 'lower_index_term' imported but unused
101:1: E402 module level import not at top of file
102:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_config should be before from invenio.legacy.bibindex.engine_washer
102:1: F401 'CFG_BIBINDEX_SYNONYM_MATCH_TYPE' imported but unused
102:1: E402 module level import not at top of file
103:1: F401 'create_download_history_graph_and_box' imported but unused
103:1: E402 module level import not at top of file
104:1: F401 'DataCacher' imported but unused
104:1: E402 module level import not at top of file
105:1: I101 Imported names are in the wrong order. Should be perform_external_collection_search, print_external_results_overview
105:1: F401 'perform_external_collection_search' imported but unused
105:1: F401 'print_external_results_overview' imported but unused
105:1: E402 module level import not at top of file
106:1: E402 module level import not at top of file
107:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, VIEWRESTRCOLL
107:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
107:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
107:1: E402 module level import not at top of file
110:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch.adminlib should be before from invenio.modules.access.local_config
110:1: F401 'get_detailed_page_tabs' imported but unused
110:1: F401 'get_detailed_page_tabs_counts' imported but unused
110:1: E402 module level import not at top of file
111:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.legacy.websearch.adminlib
111:1: I201 Missing newline before sections or imports.
111:1: E402 module level import not at top of file
112:1: I101 Imported names are in the wrong order. Should be DatabaseError, InvenioDbQueryWildcardLimitError, deserialize_via_marshal
112:1: I201 Missing newline before sections or imports.
112:1: F401 'deserialize_via_marshal' imported but unused
112:1: F401 'DatabaseError' imported but unused
112:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
112:1: E402 module level import not at top of file
113:1: F401 'acc_authorize_action' imported but unused
113:1: E402 module level import not at top of file
114:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine
114:1: E402 module level import not at top of file
115:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
115:1: F401 'encode_for_xml' imported but unused
115:1: F401 'wash_for_utf8' imported but unused
115:1: F401 'strip_accents' imported but unused
115:1: E402 module level import not at top of file
116:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
116:1: E402 module level import not at top of file
118:1: E402 module level import not at top of file
121:1: I101 Imported names are in the wrong order. Should be calculate_cited_by_list, calculate_co_cited_with_list, get_cited_by_list, get_citedby_hitset, get_citers_log, get_records_with_num_cites, get_refers_to_list, get_refersto_hitset
121:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before import invenio.legacy.template
121:1: F401 'get_citedby_hitset' imported but unused
121:1: F401 'get_records_with_num_cites' imported but unused
121:1: F401 'calculate_cited_by_list' imported but unused
121:1: F401 'get_refersto_hitset' imported but unused
121:1: F401 'get_cited_by_list' imported but unused
121:1: F401 'get_citers_log' imported but unused
121:1: F401 'calculate_co_cited_with_list' imported but unused
121:1: F401 'get_refers_to_list' imported but unused
121:1: E402 module level import not at top of file
126:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_grapher should be before from invenio.legacy.bibrank.citation_searcher
126:1: F401 'create_citation_history_graph_and_box' imported but unused
126:1: E402 module level import not at top of file
127:1: I101 Imported names are in the wrong order. Should be get_self_cited_by, get_self_cited_by_list, get_self_refers_to_list
127:1: F401 'get_self_refers_to_list' imported but unused
127:1: F401 'get_self_cited_by' imported but unused
127:1: F401 'get_self_cited_by_list' imported but unused
127:1: E402 module level import not at top of file
128:55: E126 continuation line over-indented for hanging indent
131:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
131:1: F401 'wash_table_column_name' imported but unused
131:1: F401 'get_table_update_time' imported but unused
131:1: F401 'run_sql_with_limit' imported but unused
131:1: E402 module level import not at top of file
133:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
133:1: F401 'collect_user_info' imported but unused
133:1: E402 module level import not at top of file
134:1: I101 Imported names are in the wrong order. Should be create_error_box, pagefooteronly, pageheaderonly, write_warning
134:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
134:1: F401 'pagefooteronly' imported but unused
134:1: F401 'create_error_box' imported but unused
134:1: F401 'write_warning' imported but unused
134:1: F401 'pageheaderonly' imported but unused
134:1: E402 module level import not at top of file
135:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webpage
135:1: E402 module level import not at top of file
137:1: F401 'apache' imported but unused
137:1: E402 module level import not at top of file
139:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch_external_collections should be before from invenio.utils
139:1: F401 'do_calculate_hosted_collections_results' imported but unused
139:1: F401 'calculate_hosted_collections_results' imported but unused
139:1: E402 module level import not at top of file
140:1: F401 'CFG_EXTERNAL_COLLECTION_MAXRESULTS' imported but unused
140:1: E402 module level import not at top of file
145:22: E203 whitespace before ':'
145:14: E225 missing whitespace around operator
146:24: E203 whitespace before ':'
147:24: E203 whitespace before ':'
148:28: E203 whitespace before ':'
149:30: E203 whitespace before ':'
150:24: E203 whitespace before ':'
151:23: E203 whitespace before ':'
152:29: E203 whitespace before ':'
153:26: E203 whitespace before ':'
154:33: E203 whitespace before ':'
155:30: E203 whitespace before ':'
156:30: E203 whitespace before ':'
157:30: E203 whitespace before ':'
158:30: E203 whitespace before ':'
159:30: E203 whitespace before ':'
160:30: E203 whitespace before ':'
161:41: E703 statement ends with a semicolon
163:1: E402 module level import not at top of file
164:1: F401 'collection_restricted_p' imported but unused
164:1: E402 module level import not at top of file
165:1: F401 'restricted_collection_cache' imported but unused
165:1: E402 module level import not at top of file
166:1: F401 'get_permitted_restricted_collections' imported but unused
166:1: E402 module level import not at top of file
167:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.utils
167:1: F401 'get_all_restricted_recids' imported but unused
167:1: E402 module level import not at top of file
170:1: F401 'check_user_can_view_record' imported but unused
170:1: E402 module level import not at top of file
172:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.records.access
172:1: E402 module level import not at top of file
173:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.collections.cache
173:1: E402 module level import not at top of file
174:1: F401 'get_field_i18nname' imported but unused
174:1: E402 module level import not at top of file
176:1: I100 Imports statements are in the wrong order. from invenio.modules.indexer.models should be before from invenio.modules.search.cache
176:1: E402 module level import not at top of file
182: D401 First line should be in imperative mood ('Create', not 'Creates')
182: D202 No blank lines allowed after function docstring (found 1)
182: D400 First line should end with a period (not 'n')
182: D205 1 blank line required between summary line and description (found 0)
190:33: E261 at least two spaces before inline comment
199:1: F401 'get_synonym_terms' imported but unused
199:1: E402 module level import not at top of file
201:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
201:1: E402 module level import not at top of file
204: D401 First line should be in imperative mood ('Return', not 'Returns')
204: D300 Use """triple double quotes""" (found '-quotes)
225:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers
225:1: F401 'get_collection_allchildren' imported but unused
225:1: E402 module level import not at top of file
228: D401 First line should be in imperative mood ('Return', not 'Returns')
228: D202 No blank lines allowed after function docstring (found 1)
231:5: E266 too many leading '#' for block comment
235:5: E266 too many leading '#' for block comment
236:5: E266 too many leading '#' for block comment
238:34: E261 at least two spaces before inline comment
255:13: B901 blind except: statement
260:9: E266 too many leading '#' for block comment
272:9: E266 too many leading '#' for block comment
277:17: E266 too many leading '#' for block comment
286: D400 First line should end with a period (not 'o')
286: D205 1 blank line required between summary line and description (found 0)
286: D208 Docstring is over-indented
331:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names
331:1: E402 module level import not at top of file
334: D209 Multi-line docstring closing quotes should be on a separate line
334: D400 First line should end with a period (not 'y')
334: D205 1 blank line required between summary line and description (found 0)
334: D208 Docstring is over-indented
347:38: E203 whitespace before ','
378:1: E302 expected 2 blank lines, found 0
378: D209 Multi-line docstring closing quotes should be on a separate line
378: D400 First line should end with a period (not 'g')
378: D205 1 blank line required between summary line and description (found 0)
378: D208 Docstring is over-indented
407: D209 Multi-line docstring closing quotes should be on a separate line
407: D205 1 blank line required between summary line and description (found 0)
419:1: I100 Imports statements are in the wrong order. from invenio.modules.search.models should be before from invenio.modules.search.searchext.engines.native
419:1: E402 module level import not at top of file
424: D210 No whitespaces allowed surrounding docstring text
424: None: None
424: D400 First line should end with a period (not 'h')
424: D205 1 blank line required between summary line and description (found 0)
442: D401 First line should be in imperative mood ('I', not 'Is')
442: D400 First line should end with a period (not '?')
453:1: E302 expected 2 blank lines, found 1
453: D205 1 blank line required between summary line and description (found 0)
453: D208 Docstring is over-indented
460:1: I101 Imported names are in the wrong order. Should be CACHE_SORTED_DATA, SORTING_METHODS
460:1: F401 'CACHE_SORTED_DATA' imported but unused
460:1: E402 module level import not at top of file
463: D205 1 blank line required between summary line and description (found 0)
463: D208 Docstring is over-indented
477:20: E127 continuation line over-indented for visual indent
479:25: E126 continuation line over-indented for hanging indent
530: D103 Missing docstring in public function
540: D401 First line should be in imperative mood ('calculate', not 'calculates')
540: D209 Multi-line docstring closing quotes should be on a separate line
540: D202 No blank lines allowed after function docstring (found 1)
540: D400 First line should end with a period (not 'e')
540: D205 1 blank line required between summary line and description (found 0)
551:20: E261 at least two spaces before inline comment
555:17: E261 at least two spaces before inline comment
598: D210 No whitespaces allowed surrounding docstring text
598: None: None
598: D400 First line should end with a period (not 'n')
604:25: E261 at least two spaces before inline comment
605:13: E222 multiple spaces after operator
628:10: E261 at least two spaces before inline comment
645:1: E266 too many leading '#' for block comment
647: D103 Missing docstring in public function
648:25: E128 continuation line under-indented for visual indent
649:25: E128 continuation line under-indented for visual indent
650:25: E128 continuation line under-indented for visual indent
651:25: E128 continuation line under-indented for visual indent
668: D401 First line should be in imperative mood ('Set', not 'Sets')
668: D202 No blank lines allowed after function docstring (found 1)
668: D400 First line should end with a period (not 'l')
668: D200 One-line docstring should fit on one line with quotes (found 3)
669:23: E128 continuation line under-indented for visual indent
670:23: E128 continuation line under-indented for visual indent
671:23: E128 continuation line under-indented for visual indent
672:23: E128 continuation line under-indented for visual indent
673:23: E128 continuation line under-indented for visual indent
711:9: B901 blind except: statement


I'ts already in packages[], we don't have dependencies here - may be a command line parsing "behavior"


Use es6
```javascript
`Text ${prop}`
``` for strings


```coffeescript
@$container.find('tbody tr').toggleClass 'selected', checked
```
http://api.jquery.com/toggleClass/#toggleClass-className-state


Our previous experience showed that having the latest version displayed in a well-known place is very convenient for the users, and they miss it when it's not there.


This is not the way we'd usually use the `require` statement.

Generally you will use it outside a class, and most often at the top of a class.

Given that we're using Rails though, there's a more common way of including code and that's in `config/application.rb`.

On a line below the other `require`s that are already there, write this:

```ruby
require_relative '../lib/paginate'
```

I used `require_relative` which sets the path relative to the file it is called from. Also notice that we don't need to add the `.rb` extension.


fixes #22


Where does `@page_info` get defined?


*sigh*


When is that raised?


merged in tims pull request which adds the error store and the repository calls moved to the actions


@gavinking I don't think there's any way for a refined implementation to return a result for an **infinite** stream, is there? In that light, I just made the message the same as for several other members in the same class that would never terminate (see `count` and `last`).


parted have this fixed upstream.


Schischn : Sourceforge