Old: only params would be sanitized (or ecaped). New: at first the params, and then the result. This can result into a double escaping.

Perhaps this should add a qualifier to `$translateSanitization.sanitize(string, qualifier)` so the component can decide which one is appropriate?


Ah, that was an unintentional change. Just pushed 1d7d4b9, should be fixed.


Attic uses the remove_surrogates() function when outputting filenames, so that should be safe (non compatible characters will be outputted as question marks).

Since we can't know for sure if the archive contains any incompatible filenames or not I think the current warning message is a good compromise. A lot of backups contain only ascii filenames


yay!


This line gives me this error:

````
TypeError: Cannot read property 'viewId' of undefined
    at Object.IonicModule.factory.goBack (ionic.bundle.js:43079)
    at Scope.IonicModule.factory.run.$rootScope.$ionicGoBack (ionic.bundle.js:43316)
    at $parseFunctionCall (ionic.bundle.js:21031)
    at ionic.bundle.js:53408
    at Scope.$get.Scope.$eval (ionic.bundle.js:23087)
    at Scope.$get.Scope.$apply (ionic.bundle.js:23186)
    at HTMLButtonElement.<anonymous> (ionic.bundle.js:53407)
    at HTMLButtonElement.eventHandler (ionic.bundle.js:11700)
    at triggerMouseEvent (ionic.bundle.js:2863)
    at tapClick (ionic.bundle.js:2852)
````
Using nightly.


This is a breaking change. We could delegate this one, couldn't we? Marked as being deprecated.


I really didn't like the duplication. Let me try something like what you've suggested.

I'll also clean up the stray quote.


Good catch. This will always be None.

The locale is retrieved in the client payload, e.g. https://github.com/mozilla/onyx#v2linksview


Same here.


drop which two?


No, no se puede usar mas de una vez. Por eso se puede hacer de una al principio, porque lo unico que va a necesitar es el orden (si es xml2json o json2xml) y las dos rutas.
Lo que si me parece es que está medio al pedo el for y pasar argv y argc. Ahora lo modifico a ver que les parece


I think that's already being done. This is using the Executor from `HiveClientModule.createHiveClientExecutor`


What about provider.registerStrategy(key, function) allowing custom strategies?


this note can be removed


@sgrif we need to check `supports_foreign_keys?` here (#19794)


KANG


nitpick: `*args`, not `* args`


Eventually:

```js
provider.addStrategy(key, function);
provider.removeStrategy(key);
```


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (340 of 340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@foxsen hmm, yeah might indeed have to separate the receiver thread from the decoder thread especially now that AAC-LD decoding is probably heavier than plain ALAC, I have to read this through with a thought.

@Memphiz I'll just branch the current master to a stable branch and just merge the ntp there. It has some API changes but the API needs rework anyway especially if the mirroring support is added.


Hi Prof K,

Can we meet at 10am tomorrow?

On Apr 21, 2015, at 4:29 PM, Raffi Khatchadourian <notifications@github.com<mailto:notifications@github.com>> wrote:

Sure.

> On Apr 21, 2015, at 16:22, vargasm01 <notifications@github.com<mailto:notifications@github.com>> wrote:
>
> This keeps on happening, can we review tomorrow?
>
> On Apr 21, 2015, at 4:19 PM, Raffi Khatchadourian <notifications@github.com<mailto:notifications@github.com><mailto:notifications@github.com>> wrote:
>
>
> I think you are somehow missing some stuff here.
>
> -
> Reply to this email directly or view it on GitHub<https://github.com/vargasm01/MyFirstApp/commit/f8c5a32e0c120948f10aa2c7d5d486e3ff515915#commitcomment-10833362>.
> —
> Reply to this email directly or view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_vargasm01_MyFirstApp_commit_f8c5a32e0c120948f10aa2c7d5d486e3ff515915-23commitcomment-2D10833454&d=AwMCaQ&c=pRW6ZPn_LDv0DnDIAK65Ad0CA4hBS-2mAmNa2_oHfF0&r=ZWMXxXoMJXDPt1UmtqAbqkaR0taI35-hbHULr4xuoc_rqRVB5VCJXyB9HEfLF8Rw&m=MaJjgtvAlr1cxJgxx4UF7ouSoNSF3kmjvPlFHuEFoOc&s=bFAu0UoMk4SFXHImm-McTEVcbpJCVJ90kD0hhBYD2xg&e=>.
>

—
Reply to this email directly or view it on GitHub<https://github.com/vargasm01/MyFirstApp/commit/f8c5a32e0c120948f10aa2c7d5d486e3ff515915#commitcomment-10833589>.


Other missing types not appearing on type lines:
- Camarid
- Caribou
- Citizen
- Coward
- Deserter
- Germ
- Graveborn
- Orb
- Pentavite
- Pincher
- Prism
- Reflection
- Sand
- Saproling
- Serf
- Splinter
- Survivor
- Tetravite
- Triskelavite

Missing card types from unimplemented creatures:

- Aurochs
- Brushwagg
- Camel
- Ferret
- Flagbearer
- Homarid
- Hyena
- Licid
- Monger
- Oyster
- Sable (Bronze Sable is mislabeled as a Satyr)
- Spawn
- Sponge
- Wolverine
- Wombat

Finally, Forest appears in creature types even though it isn't one. Probably due to Dryad Arbor.


All tests succeed on local machine.


Currently this is done by the `angular.isString(value)` checks inside the strategies.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1136 of 1136 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Makes sense.


What was the issue that caused you to make this change?
Is anyone aware of any performance issues associated with this change?


shouldn't this be `jwerle/progress.c`?


Опечатка в типе?


`jwerle/progress.c` ;)


ha - thanks! couldn't get that figured out :P


Зачем вводить новый тип, если есть `int1`?


I don't think it is what we want, more something nicely human readable.


heh not sure. I'm sure it is supposed to be


woooops


Updating macro to create program path automatically.
Preventing replacing existing program by checking if destination folder already exists


how did you determine the hourly threshold is better than every minute? Is there any reason why might want to check more often?


Ok. I don't hang around IRC much but I can pop in. I'm interested in fixing up the palette related issues, at least in SQ6 to start.

I don't have a great place to do documentation so I just stuffed a text file into my fork. I started digging into the PalCycle call:

https://github.com/sciguy000/scummvm/commit/06b6ff728caad9e953d3f909f6ba49143d1b3ac8


Ah.. yeah I see. Perhaps a little bit too ambitious?

```js
    escape: function(value, mode){
      if(mode === 'text' && angular.isString(value)){
        return htmlEscapeValue(value);
      } else{
        return value;
      }
    },
    escapeParameters: function(value, mode){
      if(mode === 'params' && angular.isString(value)){
          return mapInterpolationParameters(value, htmlEscapeValue);
      } else {
          return value;
      }
    },
```


PEP-8 ограничивает максимальную длину строки до 79 символов
https://www.python.org/dev/peps/pep-0008/#maximum-line-length


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/11274/testReport/) for this commit**


TeamCity MonoGame :: Develop (Win) [Build ???](http://teamcity.monogame.net/viewLog.html?buildId=6270&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependencies failed: 2 Build time: 00:00:00


@jonathanong I published 0.1.2 with a `--include-babel-polyfill` flag. That might fix your troubles.


correct.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (340 of 340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


are we no longer interested in performing a best-effort machined registration like I had patched v215 to do?


Ok, I'll test, but I'm a little bit afraid because some tests are breaking.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14133/testReport/) for this commit**


Humm ok... vou fazer os devidos ajustes, obrigado.


fijate que en realidad para vos no representa `arrayLen`, sino el último índice válido. solo un tema de convención y semántica de los nombres de las variables.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (340 of 340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:disappointed:


:+1: :-1:


@maxbrunsfeld I don't think this line will ever be reached because of line 77. Isn't it??


This docstring could use some expansion -- what do you assume about graph? In what way will it be transformed by this operation?  From the example it looks like it accepts a dictionary and returns a list of sets, but this should be stated explicitly.  The docstring for layer_groups is somewhat inscrutable as well, at least in isolation as in this commit diff.


@senny AFAICS, [queue.rb:50](https://github.com/QueueClassic/queue_classic/blob/45ee42ed2a644da1fe06f7aab815c8ff1a0f3968/lib/queue_classic/queue.rb#L50) + [queue.rb:62](https://github.com/QueueClassic/queue_classic/blob/45ee42ed2a644da1fe06f7aab815c8ff1a0f3968/lib/queue_classic/queue.rb#L62) == integer truncation... 3 seconds becomes 2.99 seconds becomes 2 seconds. :worried:


@redconfetti having the link be the same on hover and focus is actually not accessible. Perhaps mention this to Anne-Sophie. Not a blocker for now.


I added this to avoid making all work in one task. After each five locations(maxtasksperchild is set to 5) we are sure that celery creates new process and memory will be released to OS. When runner runs in one task It consumes a couple GBs of memory (It's caused by fact that python doesn't release memory to OS but to internal memory pool).


ack


ping


Also, can this value be configurable? Does it make sense to make it configurable?


Zone-VS-WSHP-system-sizing-draft (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (1640 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.2%25-yellow.svg)


How do you make the background of items see through? The jewel soup mug and golden mug have white instead of see through.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (340 of 340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I've just added wiki pages with data from this commit.


Try using the eraser in paint or gimp or whatever you use.

    ____       __
   / __ \___  / /____  _____
  / /_/ / _ \/ __/ _ \/ ___/
 / ____/  __/ /_/  __/ /
/_/    \___/\__/\___/_/

Not sent from my iPhone because I don't have one

On Wed, Apr 22, 2015 at 3:21 PM, CircuitLord <notifications@github.com>
wrote:

> How do you make the background of items see through? The jewel soup mug
> and golden mug have white instead of see through.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Kalman98/KalStuff/commit/8eff1f5d72132924f8f5fb13ce2731ab2aa445c2#commitcomment-10855454>
> .
>


How do I reject?
Not the correct Canadian spelling. I have been using S my entire life ;)


Congratz for the release  ;-)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I was talking about using chain function.


Well if you're using paint to draw this you cant make transparent pixels. You can download Gimp at: http://download.gimp.org/pub/gimp/v2.8/windows/gimp-2.8.14-setup-1.exe, which has support for transparency. I can also just turn white pixels into transparent pixels on your images next time i get on eclipse.


Perhaps all related inputs could be part of a single form tag rather than having every input have its own form tag.


TeamCity xBIM :: XbimExchange :: Build [Build 262](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1493&buildTypeId=XBIM_XbimExchange_Build) is now running


Password expiration is an LDAP policy set by corporate LDAP administrators. It is typically only set once, when an LDAP server is initially stood up. In this case, password expiration might be set to, say, every 90 days, and likely won't ever change. The code was checking it every minute, which is expensive in that it's a remote call to LDAP which is already bogged down. To answer your question, I arbitrarily set it to every hour.


Компилятор заругается из-за запятой, но я всё равно собирался сделать это фичей, а не багом.


remove this


Good point.
Fixed all without missing card types from unimplemented creatures.


FixTransitionIssues (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1647 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You're correct. Thanks!


TeamCity xBIM :: XbimExchange :: Build [Build 263](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1494&buildTypeId=XBIM_XbimExchange_Build) is now running


TeamCity xBIM :: XbimExchange :: Build [Build 262](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1493&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:26


All `ul` tags inside of this `nav` tag should be have the same indentation level as the `tags`.


I suppose it could be configurable but this would require a change to Config Manager, the default configuration, and the ESP code that queries it. I think it would be overkill, but if you feel strongly about it i would prefer to open another Jira to address it


Is there an input that belongs inside of this?


TeamCity xBIM :: XbimExchange :: Build [Build 263](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1494&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:53


How I could write "else" with Conditional Properties?

> (isEmpty(left) && isEmpty(right)) ==> isEmpty(union)
> (!isEmpty(left) || !isEmpty(right)) ==> ...


Do you mean `ul`?


keep tag names lower-case.


Can you pull request this usage upstream for filters?

slack_client = plugin.getbot().get_slack_client()

That would be really handy. Thanks.


this should describe the function right? should have what each function does in jsdoc


You can get the table layout thanks to:

```css
.d-bar {
	display:table;
}

.d-bar.d-bar-h > div {
	display: table-cell;
}

.d-bar.d-bar-v > div {
	display: table-row;
}
````


makes sense - i think we still need to remove the `ignore_result=True` though (at least I needed to do this to make it work locally)


So for the above 3 tests it behaves like I'd expect it to:

```
[info] Interpreter
decision → fail
    ENTR
    ---X Boom! => Stop
        ---|
        |---
    |---
|---
[info] - must onError when preStart fails (158 milliseconds)
decision → fail
        ENTR
        ---X Boom! => Stop
            ---X Boom! => Stop
                ---|
                |---
            |---
        |---
    |---
|---
[info] - must onError when preStart fails with stages after (17 milliseconds)
ENTR
---|
finish!
    ---|
postStop failed = Boom!
        ---|
|---
```

When doing a similar scenario but in `FlowStageSpec` I'm getting weird execution trace:

```
[info] FlowStageSpec:
Coroner Thread Count starts at 11 in akka.stream.scaladsl.FlowStageSpec
[info] A Flow with transform operations
decision → fail
    ENTR                 akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
    ---X preStart: Boom! => Stop akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
        ---X preStart: Boom! => Stop akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
        |---             akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
ENTR                     akka://FlowStageSpec/user/$a/flow-1-1-IterableSource-stageFactory
    |---                 akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
---|                     akka://FlowStageSpec/user/$a/flow-1-1-IterableSource-stageFactory
|---                     akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
|---                     akka://FlowStageSpec/user/$a/flow-1-1-IterableSource-stageFactory
 dem 1 (+1)              akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
        ENTR             akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
<-------                 akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
---|                     akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
|---                     akka://FlowStageSpec/user/$a/flow-1-2-stageFactory
        ENTR             akka://FlowStageSpec/user/$a/flow-1-1-IterableSource-stageFactory
        ---|             akka://FlowStageSpec/user/$a/flow-1-1-IterableSource-stageFactory
        |---             akka://FlowStageSpec/user/$a/flow-1-1-IterableSource-stageFactory
[info] - must handle exception thrown in preStart by signalling failure *** FAILED *** (3 seconds, 165 milliseconds)
[info]   Expected exception akka.stream.testkit.StreamTestKit$TE to be thrown, but java.util.concurrent.TimeoutException was thrown. (FlowStageSpec.scala:442)
```

Let's investigate tomorrow


Si bien es correcto, y más allá de que tenga mayor compatibilidad con [ciertos browsers](http://stackoverflow.com/questions/5943726/string-charatx-or-stringx#comment20896134_5943760), creo que `arr[i][j]` es lo que la mayoría atinaría a hacer.


No comments means I agree with you or your change sorry.  I need to get used to GitHub


FixTransitionIssues (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I've put some of my own notes (particularly on some relevant vtables and structs) at https://gist.github.com/wjp/a56456ffce14f4ac614d


with the new chars in the map, the resulting slug isn't consistent to v1.x.x
after bumpup to v1, speakingurl will follow semver
> Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes are introduced to the public API.


I need to evaluate this for the impact on people currently using nc-config without pkg-config on their system, but beyond that the pull request looks good.


pre-existing: histroy => history


I'm seeing a habit of capitalising. You should use lower-case for all html.


There should be no spaces between attributes and their values.


when will this security fix be released?


Okay, I didn't see how to draw with  transparent pixels on paint. Only making ares transparent with a dragging thing that would take a long time to do.


Let's keep it PG-13, huh Monti?


Since this method actually computes the set of collections with associations in order to determine the size, a better API would provide the set as a return value and let users call ".size()" on it. That way users know what is going to happen and won't be surprised when it's slow.

Also, the name is a bit misleading; most people unfamiliar with SMTK would conclude that "a manager's associated items" would return all the items that were associated with the manager, not all of the items associated with at least one model entity.

    std::set<Collection> collectionsWithAssociations() const

(or return a vector if that is preferred, or make the method templated on the returned container type).


und 5 ist immer die schönere Zahl :palm_tree:


ehm -> does it mean, no need for a ``tuple`` in the first place, so just save a ``ndarray`` for ``self.pos``should work? need to try this out, i was just modifying the code , so I am not an expert in it, but glad to fix some stuff as far as I can.
basically implement your suggestion :-)? :+1:


RunAsGroup too (assuming that option is available)


Sí o sí necesito el else?


Use consistent indentation


@jjeaton as far as I can tell it's redundant.
```$id
(integer) (optional) Post ID
Default: Current post ID```
ref: https://codex.wordpress.org/Function_Reference/has_excerpt


This can't actually be deleted, because the client frontend is transpiled from ES6 to ES5 using gulp. The ES5 resulting file would be absent from the build/ dir, would we not run `gulp` at least once at startup.


Looks like a bit of debug logging leaked into the release version


У меня автопроверка этого пункта снята, потому что, имхо, он рассчитан в первую очередь на читаемость на экранах любого разрешения (а мне думается, что сейчас сложно найти экран с разрешением, на котором 79 символов доходят до края)


See inline comment. Other than that, it looks good.


hidden?
Кажется, забыла его реализовать.


Not sure, this is not needed. Some left over I assume.


False, нет?


@kyranstar I *think* that I have figured out the problem. Upon closer inspection, I discovered that we were somehow allocating device context handles (through MonoGame, which called `GetHdc`). I basically just started commenting stuff out and watching the GDI object counts and it appears that the issue was these lines (which we weren't actually using anyway):

```c#
int screenHeight = GraphicsAdapter.DefaultAdapter.CurrentDisplayMode.Height;
int screenWidth = GraphicsAdapter.DefaultAdapter.CurrentDisplayMode.Width;
```

My guess is that the getter for the display settings somehow was allocating a device context every time, and the GC couldn't keep up. Can you try now and see if the slowdown/exception persists for you?


В каком? Hidden?
Проглядела, что int1 уже есть


If you put the except condition here for the index , you will avoid replicate 'set_space' in the add and delete methods.


Looks like you lost a period here.


Actually I think I plotted the upper and lower boundaries incorrectly. I should be calculating the 95% confidence interval instead of using just the bare standard deviation.

@kevjohnson @akmahaja @douglascox


Honestamente no sé qué tan correcto sea, o no hacerlo aquí, ni así como lo voy a poner, pero podrías hacer algo como:
```
params[:link][:linked_note_id].delete('') # remove white element in params # => ['', '1', '3', ... ]
params[:link][:linked_note_id].each do |id|
  @note.links.create(linked_note_id: id)
end
```


The relevant MonoGame source (which helped me find the issue!) is here: https://github.com/mono/MonoGame/blob/2d43afcc304bbcc53d45c2f31471192c8b1daa32/MonoGame.Framework/Graphics/GraphicsAdapter.cs#L93. There might be a good bug report somewhere in this exercise, but I'm not so interested now that it's fixed.


`int 0_1_2 ! sex,`


\o/


Yeah, changing it to "review" is legit. For better or worse it's still called explanation in the database. I just didn't want to reuse the word review to be a table name and also a field in that table, but that probably wasn't a big deal.


@boogerlad @particlebanana hey guys, just FYI- don't forget to change it in both places


Почему не unsigned int?


unsigned int?


This can cause a divide by zero issue.


That would make this a much larger change as every place where the value of `mPreviousMSeconds` is used, `.count` would have to be added. There's no apparent benefit from calling `.count` everywhere a variable is used versus just having the variable store the count in the first place.


.configure -> ./configure


This will fail if the cancellation fails, but what are the cases that could return a failure? Like if the device has already been removed, will this just be a no-op?


Maybe it's problem that si method execute subtask with ignoring result so leave ignore_result in decorator and change si to s will fix problem.


what happened to the language repository? couldn't find an explanation.


Good idea; something that enumerated the lines of both expected and actual would help identify differences more easily, too.


Interesting. I thought using immutable tasks meant you could ignore the
results but I guess not. Thanks for the fix.


this didn't seem necessary (the `|c`) as it's a method


I agree that because the computation behind numberOfAssociatedCollections is fairly slow, returning the actual collections with associations instead is most likely a better approach.

I  think that that I will go with generic templated approach. I should have this updated later today.


That would require putting `.count` everywhere else these variables are used.


sounds good


This AdminClient instance is NOT created per node. Its created per Azkaban job. So we should be okay without the suggested changes.


Там будет TypeError, а он у тебя не ловится.
Функции test_* должны выдавать булево значение при любом входном аргументе.
Вообще, этот «pythonic way» — использовать исключения вместо явных проверок типов — во многих запутывают логику, и приводят к ошибкам.


Please do note that execution may not enter the previous `for`.
It's necessary to use `prev_i` instead of `silence_start_i` here


Twice?


Just split test in two.


Twice here too?


Holdout != progressive. Holdout должен считаться в конце на полностью обученном классификаторе.


I like this change a lot and I think the top cmake file is much clearer now.
This should definitely go in.


yes, my thoughts were it limits potential side effects, since you're using
the $post object directly elsewhere within that function, it keeps it
consistent. No big deal.

On Wed, Apr 22, 2015 at 4:36 PM, Chuck Reynolds <notifications@github.com>
wrote:

> @jjeaton <https://github.com/jjeaton> as far as I can tell it's redundant.
>
> (integer) (optional) Post ID
> Default: Current post ID```
> ref: https://codex.wordpress.org/Function_Reference/has_excerpt
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chuckreynolds/WPFBOGP/commit/25f8fa114de2bc8302338edf07071b092efb991f#commitcomment-10855722>
> .
>


TeamCity xBIM :: XbimExchange :: Build [Build 264](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1495&buildTypeId=XBIM_XbimExchange_Build) is now running


I don't know why it would have reverted back to the old. I did not change that part of the code. Did I make another commit error?


Looks good


végül felment, azt hiszem... :)

tveki <notifications@github.com> ezt írta (2015. április 22., szerda):
> Ír valami hibát?
>
> —
> Reply to this email directly or view it on GitHub.<
https://ci4.googleusercontent.com/proxy/hszjcWbD26lkkmy8Vj5OwBDGAPJpkBrWLzW4Dw2erT8zYJUwYlggFoKCfEj1F1YBzejbodVktQeEBaParGb4pxHjfITw5bOu-gHHYes8ZSGVOgTYncFBrmDqauqVIQp77nHVJHS2mi4T-YExvCEqeeMxxIhydA=s0-d-e1-ft#https://github.com/notifications/beacon/AK8krejudsicea6vQJ5T5MC7T8eNH8EIks5oB4QagaJpZM4EF_j3.gif
>


TeamCity xBIM :: XbimExchange :: Build [Build 264](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1495&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:37


Now I'm going to look into the scale issue.


How about `$PROMPT_CHARACTER`? I think most of the other magic vars are screaming snake case. Let's go with that.


test


I agree, this is cleaner. The __construct does have code to reverse it, but it relies on the username not being numeric. In theory, a username could just be numbers, so it would break in that case.


Там написано, для чего он расчитан :-)
> Limiting the required editor window width makes it possible to have several files open side-by-side, and works well when using code review tools that present the two versions in adjacent columns.

Первым я часто пользуюсь. Второе можно наблюдать прямо здесь: гитхаб не переносит строчку, и я не вижу что происходит после `'chat_title_update'`

Ещё это дисциплинирует не делать излишних уровней вложенности блоков кода и слишком длинных (и, как следствие, непонятных) comprehensions.


Sounds good to me.


1. GetCurrentAcceleration must be lowerCase
2. I think we should mention why we are doing so, like 'For platforms providing special method to retrieve current acceleration we should use it '


Thank you for catching this one @astralbodies!


Great! How did you derive function names - are there interpreter builds out there with symbols? (Where?)

> On Apr 22, 2015, at 1:32 PM, Willem Jan Palenstijn <notifications@github.com> wrote:
>
> I've put some of my own notes (particularly on some relevant vtables and structs) at https://gist.github.com/wjp/a56456ffce14f4ac614d
>
> —
> Reply to this email directly or view it on GitHub.
>


TeamCity xBIM :: XbimExchange :: Build [Build 265](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1496&buildTypeId=XBIM_XbimExchange_Build) is now running


TeamCity xBIM :: XbimExchange :: Build [Build 265](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1496&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:13


I had some failures (on Linux) but turns out they were caused by running in the wrong working directory - got it passing now.

Is there any reason it's a separate cabal project rather than a test suite in the main cabal project? If it's just historical and you're happy to switch I might take a look at doing that.


You can also use Array.push
```javascript
//Set position somehow
var npc_settings = { id: i, position: {x: x_start, y: y_start} };
npcs.push(new npc.npcObj(npc_settings));
```


I'm a little nervous about this because of how much LVM relies on scanning block devices for headers.  I imagine block zeroing is the default because in the case where you create a pool over a drive that was already used before, if chunks of it happen to have headers you can run into issues...

To flip things around, if the thinpool developers recommend it, why isn't it the default there?  `man lvmthin` has an entire section about `Zeroing` that only tells me that "Provisioning of large zeroed chunks impacts performance."


You can write this as `def edit; end`


And down here you would take in a settings variable.
```javascript
function npcObj(settings) {
  this.position = settings.position;
  this.id = settings.id;
}


Thanks! BitHub has sent payment of  $11.45USD for this commit.


you can extract `var options` into, say `config.json` and require it here.


why not babelify or typescriptify gulpfile.js?


Great


Please use `g_autofree` etc.


why not `gulp.task('default', ['compile-typescript', 'compile-sass', 'compile-react']);`


I was just thinking about doing that.
Yesterday was a terrible day, but I'll take care of it soon :wink:


I believe the history is that I received a patch that enabled test coverage tooling and I just accepted it. I have never used it though and would be happy to convert back to a single cabal file. Note that the test-suite generates a few executables: these should be Buildable: False by default if they are back in the main cabal file.


The names are from comparison with the Mac/68k interpreter for Phantasmagoria, which has symbols.


pls, format you code. It's easier to read from up to down rather then from left to right. Use a new line for every `pipe`.


> Do I need to be running an older version of Java?

In general, no. Regarding Java 3D specifically, I am not sure. Personally I have not had time to do much testing with Java 8 + Java 3D. In theory it works. But see also these FAQ entries:
* [How do I launch ImageJ with a different version of Java?](http://imagej.net/FAQ#How_do_I_launch_ImageJ_with_a_different_version_of_Java.3F) – very important; otherwise your ImageJ may start up with Apple's Java 6 even though you installed Java 8.
* [How do I run ImageJ on Yosemite?](http://imagej.net/FAQ#How_do_I_run_ImageJ_on_Yosemite.3F) – may also apply to Mavericks.


better to use gulp 4 though. It's going to have a bit different syntax and you don't want to refactor everything in future.


Click the "issues" tab to view figures


You don't want to create every time you update. You should check if bot is in your list of npcs, and only create a new div if it isn't. Really, until we add spawning the only time you want to create divs is when we first generate the maze.


do you need to prefix every task with `compile`?


This is probably just here for testing, but we won't need to emit anything when we receive an npc_update.


event at node 0.10 you can use `const`.


I think you dropped this: " ".


looks like this is for testing.


@vbatts

If a device is already gone, in that case I think -ENXIO will be returned. I already look for it and if device is not there I return success.

If device is already being removed, then I think we will get -EBUSY and in that case we are retrying. Pretty soon device should go away and we should get -ENXIO and we will return success.

I don't know what other error cases can happen. So anything apart from -ENXIO and -EBUSY is an error and will be returned to higher layers.

I think one more case we could probably optimize. And that is if modify GetInfoWithDeferred() to parse for the case of -ENXIO and return it to caller. If caller sees that device is not present to begin with, then return success. This will
save us one call to  devicemapper.CancelDeferredRemove() in the case when device is already gone at the time of calling this function.

I will play with it and everything works fine, push the changes again.


this is where you loop through the npcs and update their positions.


You probably will want to make sure these positions are hallways. Maybe just always start them at the end for now? (That will require saving the start and end in variables in generate)


When do you intend to release a new version with this fix?


@Dunbaratu Check out this. I don't feel like it's stable enough to merge but I'd like to know your opinion.
You'll probably need this:
```
// kc.ks
switch to 0.
run kerbal_commander.
```
Recommended settings:
1. copy kc.ks to volume 0 and to volume 1
2. optionally set it as your boot.
dependencies:
1. lib_exec
2. lib_raw_user_input
3. lib_ag_list_dialog
P.S. The current implementation requires you to restart kc after every "run".


Why is this necessary? We have `require('React')` and it's currently throwing on that.


TeamCity xBIM :: XbimScripting :: Build [Build 13](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1497&buildTypeId=XBIM_XbimScripting_Build) is now running


TeamCity xBIM :: XbimScripting :: Build [Build 13](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1497&buildTypeId=XBIM_XbimScripting_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:24


Forgot to push the code ?
(For future reference, it would be nice if you can reference the commit which deals with the stuff being discussed by simply copy pasting its SHA inline in your comment)


why is this commented out?


Well that will make this easy then!

> On Apr 22, 2015, at 2:02 PM, Willem Jan Palenstijn <notifications@github.com> wrote:
>
> The names are from comparison with the Mac/68k interpreter for Phantasmagoria, which has symbols.
>
> —
> Reply to this email directly or view it on GitHub.
>


TeamCity xBIM :: XbimExchange :: Build [Build 266](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1498&buildTypeId=XBIM_XbimExchange_Build) is now running


`Model`'s `set` method always returns `this`, so I think this condition will always be false. Am I misunderstanding something?


@Falkirks


@oritwas this is not thread safe, should use atomic64_t instead of uint64_t for max_req_id.


should be static


no particular reason beyond reducing logging noise.


I had to actually go with a non templated version as Manager.h cannot bring in Collection.h or we cause some circular dependencies.


TeamCity xBIM :: XbimExchange :: Build [Build 266](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1498&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:07


I'm pretty sure if you define a "validate" method and the validation fails, then set returns "false"


test


rippled defaults to `true`, however this seems to always get configured to `false`. Not sure what to do.


> I had to actually go with a non templated version as Manager.h cannot bring in Collection.h or we cause some circular dependencies.

That is why I have largely given up on avoiding `.txx` files. But a non-templated version is fine.

	David


@cgwalters

For scanning a thin device, first one will have to activate a device using its thin id. If thin-pool does not think that device is not present in the pool (because its not present in the metadata), then that activation
will fail and no udev rules will run for further scanning.

IOW, I am not aware of LVM doing any scanning of the pool to find thin devices present in the pool. All thin device related data is part of lvm metadata and they should be scanning that to figure out how many thin devices are in pool.

Also docker has been setting up thin pool over loop with skip block zeroing and if there were apparent
issues we would have noticed it by now.

About it being default, I will let thin-pool developers comment on it. I suspect that they went for a safer default keeping in mind that a different device can get a previously freed block with some data on it. I have been told that xfs will not let a container read unprovisoned data. So reading through xfs should be safe. Though concern with "dd" will still remain.


FixTransitionIssues (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (623 of 623 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.16%25-green.svg)


confused by the logic here:
code still handles the case when the txSet is not found, so why are you cancelling all fetches at this time?


This should read:
```yaml
include:
    - python: "3.3"
      env: KRB5_VER="1.12"
    - python: 2.7
      env: KRB5_VER="heimdal"
```


Somewhat a personal preference, I just prefer to favor `==` conditions :smile:


The only return statement I see in [`Backbone.Model.prototype.set`](https://github.com/jashkenas/backbone/blob/master/backbone.js#L499) is `return this`


This is gold !
I was trying to achieve this repeating functionality on the shipping page for 3 days and the code was there... Thank you for your work Maciej ! I have a lot to learn from this commit, some portions are totally nebulous for me.


comment out?


This change makes source_suites==True and source_suites==None behave the same. However source_suites==None is supposed to not copy in sources and raise an error instead (though that's not explicitly documented).


Файлы формата .* исключаются из рассмотрения это минус надо править


Great Job Perkins. What is the story around the picture of the surfer? I suggest changing the picture to something more related to software development.


Wrong version:
https://github.com/jashkenas/backbone/blob/1.0.0/backbone.js#L326


@sebreh I tightened up the language a bit in some places


you should remove the coverage document from the repo and add the folder to `.gitignore`. Also, automated testing?


rax retry tests


@cgwalters

Having said that we did recently run into that issue of udev rules scanning pool and trying to mount it. But that will happen even if block zeroing was enabled (as there could be a valid device in there). So solution for that will be that udev rules skip pool scanning altogether.


Hi Frederik,

This sounds like great generic functionality (adding NLP annotations to HTML), so I don't think it should be a stand-alone task. If you take the extra time to turn it into a core LLaMaPUn module, so that the script is reduced to a bare minimum of calls, that would be really awesome. For example:
 * One call for getting the POS tags
 * One call for annotating the HTML with the POS tags.

Having all the SENNA setup code copied over and over again between tasks is a strong sign we should think of refactoring.

As it stands, the LLaMaPUn tasks are unmaintainable islands of code and the more of them we make, the more work we end up wasting/duplicating. Investing the extra effort into making general-purpose LLaMaPUn libraries is the truly valuable software aspect of the project.


The new item fetcher holds a weak reference to the trackers. Fetches are canceled when the user code releases all its shared_ptr to the tracker, which means that this line cancels all the fetches except the fetch that continues to be held by the `txSetTracker` shared_ptr.


reverted in 530819866f4cf60ab45d36f38956005ab1bb6c31


@robbat2 why not just take a precedence of HTTP_CONTENT_LENGTH over CONTENT_LENGTH?


Also, we shouldn't be inventing new HTML attributes in the long run, rather we should be using RDFa for the annotations.


According to the README this should be defaulted to `full`


This is a temporary global, it can probably be done at setup and then further tests in this class refactored.


Good job, but it may be helpful to provide a comparison between PhoneGap and Titanium. What is the pros and cons of using both?


@KorvinSzanto This is the main change: a filter to decide which methods should be included in the symbols file.


Works for me :+1:


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1136 of 1136 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


keep pointing out those you want back, I'll make a single commit.


I've repeated the use of this group id getter but again it is something that can be moved to setup.


Seems like you need more tests than this.


Should be fixed.


@RobertoUa, changed what was easy to change. I don't think `gulpfile` is the top priority at the moment, but feel free to open a pull request.


I think the ":D" implied that he was joking but I could be wrong. I was tempted to troll and say "This should be for sponge :trollface:"


The current docker zeroing though is only for *loopback* devices and there we can rely on the underlying filesystems all being guaranteed to return zeroed blocks (for security reasons), right?

Anyways, :+1: from me on this given the above, but I'd still like to know the ultimate answer for why it isn't the default.


CAUTION WHEN USING THESE, Length and Results need to be recalculated.. every 2 bytes = 1 length.. Even though it doesn't really matter how long the result is nor the length to an extend.. but check accuracy may be effected by inaccurate results or potential false positives.


Why did you remove this test without adding a test of equal complexity? (Meaning, a real-ish config file.)


I think the idea was to see if `rbenv` is on the `PATH`.  `command command` is probably a typo and there should just be one `command`.


@KorvinSzanto IMHO here we had a bug due to a wrong operators precedence. I simplified it accordingly to my understanding of this `if`


you're welcome :-)


LGTM


I forgot to mention that this issue was found by @DT85!


I switched from `PHP_EOL` to `"\n"` because the php coding style suggests to always use the latter.


Might be worth updating the default comment here as `multi_threaded_message_loop` is hard coded to `true` in our case.


Thanks you!


:shipit:


Mark,
I am trying to turn on zoom via buttons only, but not when clicking on the canvas..
It looks like preventDefaultAction will allow this.  But I cannot figure out how to set preventDefaultAction=true from our code.  Do you have any pointers on who we can set this value from code that uses OSD?

thanks,  Paul


Zone-VS-WSHP-system-sizing-draft (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1647 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.27%25-yellow.svg)


This is not what this option does. The previous text was more correct.


closes #5


sorry - you are right the .travis.yml needs to be modified.
* repo name
* coverity secure token

@jwerle - can you do that - or should i send another PR


What happens if `rippled_ssl_cert` or `rippled_ssl_key` are `false`?


testing


This part, i have covered in the unit tests. the source map correctness is covered by looking at the sourceMap.txt file and the encoding itself is in a unit test. i can do it here as well.. but that does not buy you much.


or just drop the whole .travis.yml file :/


to keep track of availability


Faiza's ball speed engine works, great idea.


nit: typo `iff`


This breaks the ability to compile against a system libev (as in the Fedora package of passenger).  Could some more motivation on the changes to libev be given?  Perhaps we can get libev to accept them upstream?


Add this SQL:
ALTER TABLE `profile` ADD COLUMN `is_show_full_name` TINYINT( 1 ) NOT NULL DEFAULT '0';


Do we even need this?


TeamCity xBIM :: XbimExchange :: Build [Build 267](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1499&buildTypeId=XBIM_XbimExchange_Build) is now running


+ changed dockin() container-entering function to use docker exec instead of nsenter.


Ah shit we do, nvm.


removed person.h a placeholder for faiza.h


awww updated app.iml and another file because I thought it was needed... completely rekt, reverting to previous version :(


TeamCity xBIM :: XbimExchange :: Build [Build 267](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1499&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:03


niiiiiiiiiice :+1:


I changed the order because PHP-CS-Fixer on Travis had some problems with this. From time to time I got single_blank_line_before_namespace or no_empty_lines_after_phpdocs. This was the only option to fix this permanent. Have you encountered this before too?


pretty sure map already gives you the list sorted by slot


About "a lot of backups contain only ascii filenames": I can assure you that on the majority of systems used by normal end users in germany, you will have quite some non-ascii filenames, even if you told them "don't use spaces and äöüß in filenames/pathes".


You need to register the event.


I'm glad you were able to figure out what that was about


Should we also install ntp?
https://github.com/ripple/altnet-ansible/blob/master/tasks/install-ntp.yml


Why are we wrapping the error?


had to rename this because have differently named cpp and h files confuses the the project IDE which manages the Make script based on project files.


Nevermind, I see the check.


(Ok, I think I see why...it'd be nice to change OSTree to have a more useful error here, although I do wonder about whether we really need to have a detailed error code for this right now)


remove bogus comments


How?


Thanks!  This is a good start, but we can make it a bit better as described in the inline comments below.


What is the motivation for a stand-alone genkey application? (Nice to put this info in commit message). I'm curious myself, and depending on I'm wondering if it should be added as a system-install target as well?

I would not include the genkey app in the "all" and "install" targets, since guessing that most users don't need it.


Yeah I think that's fine. Let me deal with it in my own branch, and I'll clean up all instantiations after I rebase.


typo


If the reader has been following along, then they've just quit gdb and are back in a terminal at this point.  But you're assuming they're within a gdb session right now.  So this is confusing.


Welcome..


A tutorial should never just do stuff without motivation.  Why did we create these breakpoints?  Who cares?


I'd actually like to kill the `transaction` file pretty soon, because we no longer need it.  OSTree should support concurrent pulls now that we use the `.commitpartial` files.


This port isn't guaranteed to work with a customized config.


Hmm, this looks a bit awkward...
![ots-homepage](https://cloud.githubusercontent.com/assets/50515/7285940/b68ed0c2-e948-11e4-9e32-c697dee977a1.jpg)


my way of keeping this clean the includes save this one are in faiza.h


TeamCity MonoGame :: Develop (Win) [Build ???](http://teamcity.monogame.net/viewLog.html?buildId=6273&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependencies failed: 2 Build time: 00:00:00


`gs_unref_object` ?


What if I forgot what the breakpoint number is?  How do I find that out?  That's what the `info` command would tell us, so you should discuss `info` before `delete`.


maybe `testAboutHomeControllerIsDisposed`?


You should always show this information before and after a particular command is run, that way I can actually see the effects of the command.


TeamCity xBIM :: XbimExchange :: Build [Build 268](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1500&buildTypeId=XBIM_XbimExchange_Build) is now running


Above you used the convention of one sentence per line.  Please stick to this convention throughout the writeup.


Worth commenting that this is somewhat non-deterministic and we're waiting for nil, which should always happen.


seeding the random number generator each time the function is called produced a small range of numbers


In additional, made small JS optimizations.

1) `new Array()` is slower than `[]`. The `[]` notation is the best practice.
2) Avoid reflows by appending items to the DOM. Add them first e.g. to an array and then to the DOM at once (http://allthingscraig.com/blog/2012/09/28/best-practice-appending-items-to-the-dom-using-jquery/) or use documentFragment for in-memory adding (http://jonraasch.com/blog/10-javascript-performance-boosting-tips-from-nicholas-zakas). In short words: appending all items at once to the DOM is faster because redraws / reflows are minimal.


rax retry tests


This is so fragile.  How hard would it be to filter for a more specific class?  See rnewman's `optFilter` or `filterOpt`.


TeamCity xBIM :: XbimExchange :: Build [Build 269](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1501&buildTypeId=XBIM_XbimExchange_Build) is now running


TeamCity xBIM :: XbimExchange :: Build [Build 268](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1500&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:07


https://make.wordpress.org/themes/2015/04/21/this-weeks-meeting-important-information-regarding-theme-options/

Is there any disadvantage (other than slightly less readable code) into applying the second hack anyway as a pro-active effort, so themes that go out with 2.5.0 don't fail a potentially future version of Theme Check?

https://github.com/Otto42/theme-check/blob/master/checks/admin_menu.php#L32


lines 21 & 40 ?


The rippled default is `256`.


Xu, first thanks for doing this. Now the code looks much cleaner.

But I still believe if you wrap this inside a Class and methods, it will improve the readability of the RebalanceControllerCLI. Let you test the enable and disable quota separately. But I will leave it upto your opinion at this point.


"Web applications should use constructor instead of this if it's available." Looks like we should swap to the new syntax?


What I want you to do is show the `info` command at the end of the already existing gdb session, then use `delete`, then use `info` (and possibly `run`) again in the same gdb session.  Once that's fixed, then I can merge.

And thanks again for doing this!


don't need the char c = '\0' thing anymore our x/y is in argument 1 "v"


TeamCity xBIM :: XbimExchange :: Build [Build 269](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1501&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:56


Hi @pauldevibm ,

To use that flag you need to have access to the event object before the default handler gets called. You can use the OpenSeadragonViewerInputHook plugin (https://github.com/msalsbery/OpenSeadragonViewerInputHook) to insert event handlers ahead of the default handlers and set the flags there.


replace exit() with return 0;


Man, this is fragile: waiting for a weak reference to get reaped...


Sorry to be persnickety, but can you verify that it returns data in JSON format?


Yeah, it breaks quickly when the window gets narrow :( But that was like it before so no regression.


itu yang biodata sama operasi aritmatika kak? ini saya upload satu folder mi, tapi dua dua na (biodata sama operasi aritmatika) saya kasi masuk di satu program mi kak.


everything we need here is in windows.h


Did I mention how fascinating this is?  I have performed a translation by one index, not precisely the inverse but almost, just off by one index.  Now I will try an even number of points and see what happens.


FixTransitionIssues (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1647 of 1647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


もうちょい、かっちょよくしてね。


Are you talking about its entry in the history application's table? That should be removed when the content server's content is destroyed. Is it not?


Scandal Vilhelm! ;)


this was renamed to faiza.cpp


Consumed 'return' here caused problems with default localizations:
![image](https://cloud.githubusercontent.com/assets/6029380/7286014/218d1e60-e949-11e4-8b42-68fba7cc6617.png)


Perhaps `if File.exist? filename_or_file_contents` would be better.  Some banks send files that do not have bai anywhere in the filename in my experience.


Seems like almost all delegates should be `class`, since we almost always want to keep weak references only.  Correct?


Interesting, I was using that as a simple way to monitor when the interfaces need refreshing without having to having to monitor a different file for each deployment/refspec. Will there be be a new way to do that on a sysroot level? Or will this have to each deployment/refspec individually? While possible it probably won't be trivial especially for detecting when new ones are added.


Remove comment


:P if nothing else we can always reset to my bug fix commit. I also
downloaded a copy of it in case github gets severely messed up somehow, but
I can't see that happening. I won't have another chance to work on it
before presentation tomorrow because I work tonight.
On Apr 22, 2015 5:32 PM, "Kloranthy" <notifications@github.com> wrote:

> awww updated app.iml and another file because I thought it was needed...
> completely rekt, reverting to previous version :(
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KayFishandChips/CIS-163-Final-Project/commit/a7004295191c9885a3b0c50a47c5e94489896bbd#commitcomment-10856695>
> .
>


Thanks for the pull request! Do you mind making the change noted for line 35?


Remove comment since it's no longer true


Thanks for the quick response.

Thanks,
Paul Devenport
801-240-1340

From: Mark Salsbery [mailto:notifications@github.com]
Sent: Wednesday, April 22, 2015 3:43 PM
To: openseadragon/openseadragon
Cc: Paul Devenport
Subject: Re: [openseadragon] Added preventDefaultAction flag to MouseTracker (8e325a3)

Hi @pauldevibm<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pauldevibm&d=BQMCaQ&c=z0adcvxXWKG6LAMN6dVEqQ&r=y83MSuHUKL6PRCzCfK41bmAzIXaXuOj2JP4vJP2M17A&m=5ak9aPtrD0Q4m3eFRv4CRzjAVnewaawU7JBbDUdnYcs&s=-RXD8dQu4qF_0gCh_6M0kRbrcfL0IUdXcw-mPP_ro04&e=> ,

To use that flag you need to have access to the event object before the default handler gets called. You can use the OpenSeadragonViewerInputHook plugin (https://github.com/msalsbery/OpenSeadragonViewerInputHook<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_msalsbery_OpenSeadragonViewerInputHook&d=BQMCaQ&c=z0adcvxXWKG6LAMN6dVEqQ&r=y83MSuHUKL6PRCzCfK41bmAzIXaXuOj2JP4vJP2M17A&m=5ak9aPtrD0Q4m3eFRv4CRzjAVnewaawU7JBbDUdnYcs&s=ymku9fZ7-hLGFc7etvMFumD9obKQ5_i8SlRCxPb00Tc&e=>) to insert event handlers ahead of the default handlers and set the flags there.

—
Reply to this email directly or view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openseadragon_openseadragon_commit_8e325a37482bed4c06ffe80b028a76a4bebc1816-23commitcomment-2D10856854&d=BQMCaQ&c=z0adcvxXWKG6LAMN6dVEqQ&r=y83MSuHUKL6PRCzCfK41bmAzIXaXuOj2JP4vJP2M17A&m=5ak9aPtrD0Q4m3eFRv4CRzjAVnewaawU7JBbDUdnYcs&s=Qq4kxWZoF5Li1Tuvcs3VF5uaP05rWPIvL6gR9ttGvYM&e=>.

 NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.


Note https://github.com/GNOME/ostree/commit/a6bbcf2ba7b8c6e8c478bd776e1042bc7990b942


This is there to ensure that the directory is already there. Perhaps we should change the test to do a mkdir if it is missing instead


Glad you've dropped this. The more we can push into framework-specific the better - our toolset should only include things that really are dependencies of everyone, like nginx!


Do we need this still ?


TeamCity MonoGame :: Develop (Win) [Build ???](http://teamcity.monogame.net/viewLog.html?buildId=6276&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependencies failed: 2 Build time: 00:00:00


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (339 of 340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Do we need this ?


Could you [squash all commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html), rebase on latest `develop` and `git push -f`?


Function name shoul be a verb.


Zone-VS-WSHP-system-sizing-draft (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1647 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.27%25-yellow.svg)


missing test for multiple fetch for the same item -> single fetch in underlying system
both cases: (fetch, io_returns_item (invokes cb), fetch (from cache, invokes cb)) and (fetch, fetch, io_returns -> invoke 2 cbs)


Oh.... shet.... hehe c:


Vinicius, por favor, escreva alguns comentários pra nis ajudar a entender como se usa sua classe.


true that.


@zamar This is slightly more complex than the patch you commented on. If it passes STC, do you still think I should use [0, 5] for LTC, or should I just use the standard [0, 6]?


@Gamecrafter please
> :SHIT: <


Should we utilize a `cpanfile` for this too so it's consistent with dancer?


Good point, will update.


fixed


done.


When using mongodb commands, instance is considered as non-valid, ie:
```js
    DeviceSDKRelation.upsert({
      id: 'compositeid1',
      '$set': {
        sdkVersion: '1.0.0',
        enabled: true,
        updatedAt: new Date()
      },
      '$setOnInsert': {
        deviceId: 'deviceid1',
        applicationId: 'appid1',
        createdAt: new Date()
      }
    });
```
deviceId and applicationId are required, and so validation reject the upsert.


This section of code was confusing and repetitive when reading it at first to try and figure out what was going on. I vote this to be a cleaner approach:

```
# If attributes provided, use those, otherwise if rpm-use-file-permissions is false, use rpm defaults.
if !attrs[file].nil?
  return sprintf("%%attr(%s) %s\n", attrs[file], file)
elsif !attributes[:rpm_use_file_permissions?]
  return file
end
```

Then kill line 148 and let it fall through to the rpm-use-file-permissions true case. Since the attribute check is winning in all cases if it's non-nil, there's no reason to be checking it twice. It's precedence is higher in the overall logic regardless of rpm-use-file-permissions being true or not.


Just double-checking, mojo does not depend on nginx?


floatformat filter uses 'number_format' that: "Formats a numeric value using localization settings".

If you have cs_CZ locale in your system then setting the following:

LFS_LOCALE = "cs_CZ.UTF-8"
LANGUAGE_CODE = 'cs'
USE_L10N = True

produces the 3,0 instead 3.0.

I see that using floats makes it possible to have 1/2 star but I don't think it's the real use case for LFS. Personally I'd change SCORE_CHOICES to integers. Other option is to write own 'floatformat' that doesn't localize value.


@wkennington too easy thanks :) btw when I have time I'll try fixing the .la of those libs, so we can remove the propagated build input.


I think this comment is superfluous.


Sounds good. You answered the case I was thinking of.
 On Apr 22, 2015 5:05 PM, "Vivek Goyal" <notifications@github.com> wrote:

> @vbatts <https://github.com/vbatts>
>
> If a device is already gone, in that case I think -ENXIO will be returned.
> I already look for it and if device is not there I return success.
>
> If device is already being removed, then I think we will get -EBUSY and in
> that case we are retrying. Pretty soon device should go away and we should
> get -ENXIO and we will return success.
>
> I don't know what other error cases can happen. So anything apart from
> -ENXIO and -EBUSY is an error and will be returned to higher layers.
>
> I think one more case we could probably optimize. And that is if modify
> GetInfoWithDeferred() to parse for the case of -ENXIO and return it to
> caller. If caller sees that device is not present to begin with, then
> return success. This will
> save us one call to devicemapper.CancelDeferredRemove() in the case when
> device is already gone at the time of calling this function.
>
> I will play with it and everything works fine, push the changes again.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rhvgoyal/docker/commit/ddc8acebecfdc7dbc0357f5c009fb3ee0a2ae906#commitcomment-10856234>
> .
>


This is here :-)
Shoulde be `vim-empty-lines/init-vim-empty-lines-mode`


This commit tweaks and deploys Faiza Harbi's ball speed engine.  Thanks TsukishirOSan


Ah, looks like that `return false` was removed with Backbone 1.1.0


SwifT, could you modify this commit to give me proper attribution? I submitted using the wrong e-mail address.


According to: http://godoc.org/golang.org/x/net/ipv4#ControlMessage
The Src (in the control msg) is only set when sending out (not a receive).  Therefore it won't be set to the destination ip on receive.  I think it will default to the interface ip when sending, which is probably desirable.

Thoughts?


Eventually it will be an `np.float32` `ndarray`, so with that in mind it's probably better to let `numpy` do some checks and such for you


TeamCity MonoGame :: Develop (Win) [Build ???](http://teamcity.monogame.net/viewLog.html?buildId=6279&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:00


This should get merged in later today or early tomorrow, but we opted to go with `com.facebook.buck.moduleBasePath`.  I'll update it so you don't have to worry about it.


Are these covered by the new TestThat tests?


@arunthirupathi  :+1: Has a good point Xu. We need to fix the vector clock issue associated with Quota.


@kkrampa this made my local profiling quite a bit faster - am continuing to explore


Joy!  I've wanted float32 for ages.  Thanks!


also you intentionally exclude everything that has children from this - even if it is part of the hierarchy. confirming that was expected and not an accident?


TeamCity MonoGame :: Develop (Win) [Build ???](http://teamcity.monogame.net/viewLog.html?buildId=6282&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:00


comment?


@hoffmabc
can we revert this?

the purpose of the launcher is not to track the PID in the terminal, the fact that it runs in the background should not make it hard to find the process.

this makes it harder to debug, and defeats the purpose of `openbazaar stop` for proper shutdown.


Somehow these lines now apear again...

This is not working on Windows as `rm` is not available. This was fixed in #56.


and probably a lot of the logic that went on inside node.openbazaar


Any chance to make this customizable via a `timeout` parameter, as the mobile web library counterpart does? https://github.com/alexgibson/shake.js/#setup


Not sure what you mean. `rippled_ssl_verify` defaults to `0` from `defaults/main.yml`.


This is a leak -> there can be created many of timer objects until the device is removed...


@pauldevibm  Forgot to mention, if you want it off always then an easier way is to set viewer.gestureSettingsMouse.clickToZoom = false


@ta2-1 can you explain those comments. Are you saying that this would actually require an update_stores to be run after this migration was executed?


Doesn't shutdown clear out tables for routers? Keyboard interrupt might be preventing that.


hopefully we also have a shutdown hook when the user shutsdown with Ctrl-C, but I'm not sure


Hey Xu, wouldn't it make sense to have a boolean and an integer to differentiate between quota as 0 and quota not set. This code is not very clear and relies on boxing/unboxing null/0 to figure that out.


Given that we have the filename and contents here, maybe we can share logic with `onDetectShinySourceType`?


The first case I just added. The second case is covered by
```
    auto tTwelve = itemFetcher.fetch(twelve, cb);
    itemFetcher.fetch(twelve, cb); // tracker held by tTwelve
```


#4833-Documentation-for-HX-controlling-to-SP (rraustad) - x86_64-MacOS-10.9-clang: OK (1641 of 1641 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TODO? hardcoded cache size seems like a time bomb


menudiskitem.cpp:109:18: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to
      always convert to true [-Wundefined-bool-conversion]
            if (!this || !mDevice.isValid())


`dnn_available` is a function, you would have to call it.


The feature list and Stylistic Set names should only be collected if there was a gsub table. Fixing a bug from a previous commit.


All of them will be deleted from memory. If there are more than one, the last one will set the correct status. Right?


Polished and edited


Good idea!


bbc 1 scotland


define some constant for this one


> Maybe, we need more sensible and accurate update reporting.

this error is only displayed when Piwik runs on an oldcodebase. make sure you update your codebase to run the latest Piwik on all servers


I don't think you should change that, as it could hide errors if the code checking for arguments change in the future.
It is safer to have a structure like:
```
if self.irange is not None:
    self.transformer = ...
elif self.sparse_init is not None:
    self.transformer = ...
else:
    raise ValueError(...)
```


This won't compile with qt < 5.4
```
lxqtmountplugin.cpp:45:5: error: no matching function for call to 'singleShot'
    QTimer::singleShot(0, SIGNAL(realign()));
```


Yes -- when using mod_php, which is also a common setup.


yup :)


Will fix.


This code is scheduled for eradication in the next round.


Hi
Lines 177-182 should have braces, even if they only have a sentence after the if-else if-else.
http://www.oracle.com/technetwork/java/codeconventions-150003.pdf (7.4)

Thanks


sure!


You will need a module-level docstring for the docstring test to pass.


Ok


I find this also occurs when switching branches, going to old Piwik versions to test, etc. Perhaps it can be disabled when Development mode is enabled?


Who will delete them? They are never deleted until the parent is deleted.


The other advantage of writing a separate class for it is that one call that class from any other place in the code. Right now, this code is tied to the hip with the rebalancecontrollercli code.


not a fan of this contract:
cb should be called at most once (when the data becomes available), so there should not be any requirement for idempotency


I think this should be on by default, so that the SRE runbook doesn't have to change and that quotas will be reset automatically.


Right. Will fix.


Now that I think of it, you will also need to skip the test if `dnn_available()` returns False, I think.


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.255](http://teamcity.monogame.net/viewLog.html?buildId=6285&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Maybe better to just write json string to data-output


while there was 2 if's before, now it makes 3 all doing the same assignment.  I prefer looping thru the choices until one is true or it runs out of choices.  There is less chance of editing one or two and missing the others if something changes.  Also it is easier to add another option to the list if a new one comes along.


>Perhaps it can be disabled when Development mode is enabled?

Why not, feel free to create issue or PR


TeamCity xBIM :: XbimExchange :: Build [Build 270](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1502&buildTypeId=XBIM_XbimExchange_Build) is now running


All the delay is not needed... as long the `accessibilityChanged` is delivered correctly


else


`cb` will be called at most once, but it could be once when you'd expect zero, because something else is holding a reference to the tracker via a shared_ptr somewhere. We don't actually do this in this code base, so it's fine. Idempoten isn't the right word. I'll rephrase the comment.


Does this overwrite the value? I think the original code doesn't?


rax retry tests


@orxx Just tested this code in my build today. Didn't seem to work on MSW I'm afraid. :/
Without the hack, I can't type e.g. the numbers 1-6 into the Outfit Studio wxTextCtrls (BodySlide works fine) because of the brush shortcuts.


...and all these update calls are not needed -> there is the signal


TeamCity xBIM :: XbimExchange :: Build [Build 270](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1502&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:44


I was just noting that rippled's default value for `[ssl_verify]` is 1, while we are defaulting to 0.


Known to fix some random crashers in:
Final Fantasy 4
Metroid Fusion
Gunstar Super Heroes
Wario Land 4


> Good catch! I don't like including mastercore_log.h in init.cpp, so let me test of another way, where the flag is defined in util.cpp.

Mind if I ask why?  (Not that I object!)  I went with putting it in ```mastercore_log.cpp/h``` because it minimized the surface of changes to underlying Bitcoin Core code.  Long story short:
* Original method - less Bitcoin changes but inclusion of ```mastercore_log.h```
* Changed method - no inclusion of ```mastercore_log.h``` but more Bitcoin changes
Would you mind helping me understand why the changed method is more appropriate?  (It'll help with my C++ understanding :) )

> diff

Looks fine to me - do you have a commit for it?  Want to push it up to 0.0.10 and I'll pull it in from there?


`fov` -> `for`, and maybe it should say`Modified for vim-tutor-mode by Felipe Morales et al` or `... by Felipe Morales and [your name]`.


nvimrc


There is no way as far as I can tell to catch a Ctrl-C shutdown. If you revert the change in a PR I will review and approve. I agree on this one.


vimrc


You're right. I missed that. Sorry for noise here.


Hello there,
I was wondering why the exception is wrapped into logic exception. It will make native error handling difficult (in case the application is designed to manage exception outside the kernel). It could be wrapped into specific exception class or just throw like it was.
Regards


I didn't see this piece of code to be reusable everywhere, but yes for sure we could create a separate class for it. Will do in the next commit.


Field removal or type changes, primarily, but perhaps we'll rip out visits into a higher-level structure for history records, then have to serialize them back into JSON to make a record for upload.

I'd rather not bake in an assumption of perfect equivalence: `{ $0 }` is so short, and this gives us explicit symmetry.


done.


... or maybe not, I forgot that this was for regular Vim as well (I think so at least).


What update calls?


@samaasallam  @khadijaibrahim


maybe `To proceed to the next tutorial, enter the following command:`


Logging code needs some cleanup, for sure. All I was doing here was getting rid of `println`.


Thanks Xu.


Sure. `bodyTransformer` perhaps.


The verbiage seems inconsistent throughout, perhaps `Press` or `Enter` should be used.


Did you intentionally remove this line?


You got it
https://github.com/OpenBazaar/OpenBazaar/pull/1240


Explicitly unwrapped weak vars still seem really strange and dangerous to me...


Точно так же как и при удалении элемента, можно принимать ссылку или указатель на указатель на элемент:
```void rotate(Bin_Tree_Element *&tree_el, Tree_Output *tree_func)```
Тогда не понадобится ссылка на root и код станет немного проще.


Maybe just `hold down j ...`? It should be obvious what it's doing after the user presses it :D


if it is a common case, shouldn't it be in a lower level ?


@rudigiesler Just letting you know I changed the status field labels from 'Logged' to 'Reported' and 'No data' to 'No action'.


If we are just doing 1 init, that's cool, but looks like you removed the wrong documentation code


No problem. Thanks a lot! 😄


maybe just `text within angle brackets`


All I changed here was to eliminate the redundant single-argument function parens, which makes this a little visually clearer.

The "chained arrows" is something I've seen around in functional Swift, and seems to follow the Haskell/Miranda style — though of course our partial application abilities are much more limited.


Oh, I also added a "Total" row to the bottom of the verbose output


Yeah, I kept doing that myself, and Xcode kept undoing it :(


> Do you think we are going to need more than one logger in the future?

I'm not sure - it's hard to know...

Basically in a nutshell the auditor was getting very spammy when ```--overrideforcedshutdown``` was used and this was really cluttering up the omni log.  I handled that elsewhere but I still found myself needing some creative grepping on the omni log to get at the audit info I wanted.  It was actually your comment on another thread that got me thinking (I was looking into auditing balances) as I realized it was going to be way too much info for the regular omni log.

Sorry, rambling a bit - tl:dr; I didn't know we'd need a separate log until we needed it :)  I can't think of anything that would require another separate log at this stage, but that doesn't mean we won't dream up something in future that could benefit from its own log.


We didn't use that particular old signature, so when a rebase did this, I opted not to argue with fate!


Double semi-colon typo?


TeamCity xBIM :: XbimExchange :: Build [Build 271](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1503&buildTypeId=XBIM_XbimExchange_Build) is now running


(ditto) Double semi-colon typo?


Please add a space after the "}". It should be "} else....".


How did you determine we do not need these packages? (I believe we probably have a few we indeed do not need.) But it seems we have a dependency on `rsync` in [`vbox_update.sh`](https://github.com/bloomberg/chef-bach/blob/c7f0c084feb0e331f2981ba4dcdb70a4f273390d/vbox_update.sh); not that I know of anyone using `vbox_update.sh`.


> Looks fine to me - do you have a commit for it? Want to push it up to 0.0.10 and I'll pull it in from there?

Just saw your PR - all good with me.


@AliaksandrVahura-ScienceSoft could you please do this first thing tomorrow?


yeah shouldn't this just be a map of stuff you are trying to fetch?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.255](http://teamcity.monogame.net/viewLog.html?buildId=6285&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 484, ignored: 6 Build time: 00:14:44


TeamCity xBIM :: XbimExchange :: Build [Build 271](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1503&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:01:14


Yes. The reasoning is as we discussed before: it's not something that really belongs in the state machine scratchpad, which contains immutable things and stuff that advances by creating new scratchpads — that upload timestamp is a side-effect of an upload, so it goes in the mutable prefs of the synchronizer.


`findAll()` - without any params does exactly same job
use also `*.`


why this call to recvTransactions here? it has many side effects and should be called first when we receive a transaction


There's the very practical concern that the clients synchronizer does an upload smack in the middle of a sync, which might be half-way through a tab sync! Not easy to get a new scratchpad out of the middle of that, build a new Ready, and re-run the sync.


We could, but (a) I'm concerned about the (lack of) coupling being hard to discover, and (b) dropping shit on the floor when we don't have an app. At least this way it's explicit when we don't have an app, and we can queue. Do we have a way to have a fallback notification handler?


sorry. fixed this with the next commit. (I should pay more attention to the conventions.)


"fragments" key


This might be a merge error. Will investigate.


Стоит нарисовать схемку что делает функция.
Вроде такой:

   ```void rotate(Bin_Tree_Element *&x)```

   ```x``` – узел, вокруг которого осуществляется поворот (аргумент функции)
   y – его родитель до поворота
   A, B и C – поддеревья, которые переподвешиваются при повороте, но не меняются внутри

```
         y              x
        / \            / \
       A   x    ->    y   C
          / \        / \
         B   C      A   B

          y            x
         / \          / \
        x   C   ->   A   y
       / \              / \
      A   B            B   C
```


Nope, it didn't make 1.2. They're hoping for 1.3.


I might just pass here and leave it to the user to debug the resulting EnvironmentError, but I don't think it's a huge deal either way.


I forgot to take it out after I added the delegate!


@questbeat This calculation leaves margins left and right of each row of assets. Was this intended? (In Photos and the native image picker there are no left and right margins)

Thanks!


Too much copy and paste


what does it mean to return a tracker if it's not in the list?


It's in the original code, here: https://github.com/stellar/stellar-core/blob/master/src/herder/HerderImpl.cpp#L805

It also looks fishy to me, but I elected to keep the behavior the same as it was since this pr already large enough.


Set admin prefix


Err this is unrelated to multi jvm support, but it came up while i was testing, and it may resolve issue #109. When contexts die, the job status actor also dies, and any unpersisted state in "infos" is lost.


Model will be reflected in `device`. But yes, this needs a follow-up bug for being more specific.


Функция в лучшем случае упадёт, если ```tree_el->up() == nullptr```. Если эта ситуация разрешена вызывающему коду, нужно просто выйти. Или, если это предусловие функции, стоит поставить ```assert(tree_el->up());```.


It is a little weird for me to release new major version for every chars added in map, but it makes sense as you mentioned.

Thanks for explanation!


That bit of nonsense is one of the reasons I wrapped this all in an NSOperation and dispatch it to a background thread.


Is it okay to call .create with a topic that's already been created? If so, great. If not, we should catch the error here.


Shouldn't this new line be after `dolist`? Now there is an empty line between each stash entry.


Лучше не завязываться на значение в узле:
```
if (tree_el->up()->up() == root)
```


$data is already initialized

Look at: BaseController
protected $data = array();


just `self.assertTrue(check_topic(self.client, ...`


I don't think reducing it is necessarily the right approach. It's three weeks so that, when you go on vacation for two weeks and want to send tabs to your desktop before the flight home, your desktop still appears in the list!

I agree with uploading more frequently, but the TTL here will always be a bad compromise.


same as above


Yeah, it also seems like Travis does not like my doxygen. So I can move the comment to a more fitting position.


Yes I did. Do you think it's a good idea to keep commented code?


I replied on the PR, but in my vagrant instance this works fine. Will edit now for you though.


Я бы разнёс повороты и перекраску узлов в разные функции.


Функция в лучшем случае упадёт, если ```tree_element->up() == nullptr```. Если эта ситуация разрешена вызывающему коду, нужно просто выйти. Или, если это предусловие функции, стоит поставить ```assert(tree_element->up());```.


Dont use bad words


It used to be a map, it's been upgraded to an `ItemFetcher` which now has a listen-notify interface instead of being coupled directly to Herder. That made it possible to write a unit test of ItemFetcher, to centralize caching, and to serve old tx sets to peers requesting them. It also cleaned up Herder a tad.


Is that to cache per tenant HttpClient instance?


FixTransitionIssues (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1136 of 1136 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.79%25-green.svg)


Better to push this logic up into Metadata business object so that we can keep the UI layer lean and mean.  Plus, having it there makes it easy if we have some other code that might want to use the same logic.


Oh sorry. I had not noticed that it was commented out. You did well to remove it. :)


I can leave a text, but cannot drag and drop here


:+1: LGTM! Beefy commit, took awhile to read through.


Clicking on selecting them display Policy banner


Стоит сделать функцию ```bool check_rbtree(...)```, которая проверяла бы все инварианты красно-чёрного дерева. И вызывать её после каждой операции (в режиме тестирования).


why not keeping tracker an internal helper class and expose the simplest contract to the outside world?
All we need is really:
fetch(itemID, cb)
stopFetching(itemID)

It seems that if you want to keep trackers as a way to isolate use cases, it's not implemented correctly.
Use cases being something like:
module A wants to fetch a bumch of items, module B wants to also fetch a bunch of items
when module A "Cancels all fetches", I don't want it to cancel the fetches that module B has going
(and we share the cache between them and trigger the callbacks on both trackers)


Probaste el código antes de commitearlo? Las comillas estan mal (Romperian la app), y faltan parametros.


Thanks. I had a good chuckle about the comment thread - everyone saying themes should use TGM and then completely disregarding the fact that TGM won't be able to use add_theme_page() anymore either.... *sigh*

Other then that using `call_user_func()` is _slightly_ less performant than calling a function directly (and of course the readability), I see no disadvantage in adding the hack for `add_theme_page()` already as well, though I think we should probably add some inline documentation saying why we're doing this for future contributors.


Why a method for something that can be express in a simple lambda?


Первое условие всегда истинно, если истинно второе и функция ещё не упала. Т.е. первое условие тут не нужно.


Yeah that was a good idea :+1:


This looks very wrong.

If I have distinct ids [1] and match_ids [3,4]. then this looks like I get new distinct_ids [1,3,4] which means that (through make combos) I'll say that these record pairs are distinct. [1,3],[1,4],[3,4].

[3,4] is not distinct. It looks like what you want it itertools product. Am I reading this code wrong?


`nocache:val($.event('nocache')),`
is invalid

should be
`nocache=$.event('nocache'),`


We'll want to handle null release dates higher up in the code, at the UI level, rather than returning junk data.


Glad to hear. I'm going to publish it to the repo then.


Having this logic live here rather than in the JSP makes it easier to unit test and reuse, if any other code might want to get the release year of the metadata.


It means the user code can ask `isItemFound()` and call `get()` on the tracker, and t prevents the item from being ejected from the cache. Herder uses this to make sure the proposed tx set isn't flushed until it is safely externalized.


Условие в этом ```if``` тяжело читать.
Может разбить его, например так.
(Только дать более осмысленные имена подусловиям вместо ```a``` и ```b```.)
```
const bool a =
    tree_element->element() < root->element() and
    tree_element->up()->right() and
    tree_element->up()->right() == tree_element;
const bool b =
    tree_element->element() > root->element() and
    tree_element->up()->left() and
    tree_element->up()->left() == tree_element;
if (a or b)
    ...
```


sdaf


what does isSynthetic means?


del


Better to  have getMetadataQueryResults() return an empty List rather than null, it makes for simpler code in add.jsp since it won't have to do a null check.


You don't need `? true : false`, do you?


this has been fixed in `v1.18.4`, thanks again for catching this!


I think Github strips out images. Could you send the picture directly to my email?

Maybe I'm misunderstanding the goals you're trying to accomplish here... want to do a quick Google Hangout to discuss later this week?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.258](http://teamcity.monogame.net/viewLog.html?buildId=6288&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This is just a stylistic change.  Listing the imports in separate statements is a bit easier to read and typically how we do it in the app.


ИМХО, лучше ```or``` вместо ```||```.


> when module A "Cancels all fetches", I don't want it to cancel the fetches that module B has going

Right. The Tacker class is exposed in order to isolate cancellations. Instead of having a `stopFetching(itemID)` method, which would necessitate extra code to keep track of the different clients, ItemFetcher simply stops fetching an item when all the `shared_ptr`s to the item's tracker have been released.

I also makes it easier to avoid forgetting to call `stopFetching()`.


I would actually add this in NuGet.CommandLine instead. I would prefer to touch absolutely as few repositories as possible to ease syncing with upstream


It's much easier to generate and copy authkeys with the standalone program, rather than using /genkey in the client, it can be automated as well.


Hi Sylvain,

I agree with you. I was calculating normal histograms to analyse the data
and to use into the whole intensity formula of each bin (i):

for angle  histogram(i)

accum_intensity (i) += ( #pixels_in_angle / #pixels_histogram ) * sigmoid
(angle)

end

I optimized the code and now it is not necessary to calculate histogram
anymore.

Atenciosamente,

*Rômulo Guedes Cerqueira*
Doutorando em Mecatrônica | UFBA
Mestre em Engenharia Elétrica | UFBA
Especialista em Engenharia de Redes e Tecnologia da Informação | INATEL
Graduado em Ciência da Computação | UESC

[image: Visualizar meu perfil no LinkedIn]
<http://br.linkedin.com/in/romulogcerqueira>

2015-04-13 13:42 GMT-03:00 Sylvain Joyeux <notifications@github.com>:

> My concern is not necessarily that you use max(), is that you build a
> whole histogram of the normals and *then* process it. I am wondering
> about the necessity of the histogram *at all*, given that the simplest
> model would be to sum all the individual contributions of each pixel in the
> bin (which does not require a histogram building and would make the whole
> function a lot simpler)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Brazilian-Institute-of-Robotics/simulation-gpu_sonar_simulation/commit/3c4565dbeb181e2c8a17b8af95525150ff52b6cc#commitcomment-10696483>
> .
>


@jgm

I got the following error while trying to compile under Windows 8.1 (`img\\multiscripts` vs `img/multiscripts`):
```
Failed to install pandoc-1.14
Last 10 lines of the build log (..\cabal\logs\pandoc-1.14.log ):
"MediaBag did not match:\nExpected: "[("img\\check.gif","image/gif",1340),("img\\check.jpg","image/jpeg",2661),("img\\ch
eck.png","image/png",2815),("img\\multiscripts_and_greek_alphabet.png","image/png",10060)]
Actual: [("img/multiscripts_and_greek_alphabet.png","image/png",10060),("img\\check.gif","image/gif",1340),("img\\check.
jpg","image/jpeg",2661),("img\\check.png","image/png",2815)]

         Properties  Test Cases  Total
 Passed  10          576         586
 Failed  0           1           1
 Total   10          577         587
Test suite test-pandoc: FAIL
Test suite logged to: dist\test\pandoc-1.14-test-pandoc.log
0 of 1 test suites (0 of 1 test cases) passed.
cabal: Error: some packages failed to install:
pandoc-1.14 failed during the tests phase. The exception was:
ExitFailure 1
```


Adding support for .coop domains of the form Expiry Date: 14 Jan 2016 22:40:29 UTC


Yes, Backbone does not do semver. It makes sense as a change since sometimes returning "false" and sometimes returning the instance is confusing.


The list of possible events is included in the GET for the command (the help) from the validation framework. I'll consider that sufficient for now, though it'd be nice in the future to have that be programmable.

I'll merge the list references though, for sure.


/cc @josericardo


this is distro specific and should probably not be included here


[![Embroidered Tablecover](http://api.artsmia.org/images/538/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=538)


[![Blue Wash 1](http://api.artsmia.org/images/119697/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119697)


[![Blue Wash 2](http://api.artsmia.org/images/119698/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119698)


[![Hmong Veteran](http://api.artsmia.org/images/122964/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122964)


[![Hmong Veteran](http://api.artsmia.org/images/122965/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122965)


[![Hmong Veteran](http://api.artsmia.org/images/122966/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122966)


[![Hmong Veteran](http://api.artsmia.org/images/122967/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122967)


[![Hmong Veteran](http://api.artsmia.org/images/122968/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122968)


[![Hmong Veteran](http://api.artsmia.org/images/122969/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122969)


[![Hmong Veteran](http://api.artsmia.org/images/122970/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122970)


[![Hmong Veteran](http://api.artsmia.org/images/122971/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122971)


[![Hmong Veteran](http://api.artsmia.org/images/122972/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122972)


[![Hmong Veteran](http://api.artsmia.org/images/122973/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122973)


[![Portrait of Mlle. Lange as Danae](http://api.artsmia.org/images/1727/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1727)


[![Cassone (chest)](http://api.artsmia.org/images/542/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=542)


[![Cassone (chest)](http://api.artsmia.org/images/1376/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1376)


[![Morning, Noon, Night](http://api.artsmia.org/images/76001/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=76001)


[![Embroidered Tablecover](http://api.artsmia.org/images/538/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=538)


[![Blue Wash 1](http://api.artsmia.org/images/119697/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119697)


[![Blue Wash 2](http://api.artsmia.org/images/119698/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119698)


[![Hmong Veteran](http://api.artsmia.org/images/122964/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122964)


[![Hmong Veteran](http://api.artsmia.org/images/122965/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122965)


[![Hmong Veteran](http://api.artsmia.org/images/122966/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122966)


[![Hmong Veteran](http://api.artsmia.org/images/122967/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122967)


[![Hmong Veteran](http://api.artsmia.org/images/122968/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122968)


[![Hmong Veteran](http://api.artsmia.org/images/122969/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122969)


[![Hmong Veteran](http://api.artsmia.org/images/122970/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122970)


[![Hmong Veteran](http://api.artsmia.org/images/122971/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122971)


[![Hmong Veteran](http://api.artsmia.org/images/122972/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122972)


[![Hmong Veteran](http://api.artsmia.org/images/122973/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122973)


rax retry tests


I have no problem running this line....it is weird.


@ThomasBurleson Woo, thanks!


Starting doing this, but the changes started snowballing to outside SwiftData, then to outside Storage, so this might be better to address in a follow-up. Is the motivation to support `Deferred`s?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.258](http://teamcity.monogame.net/viewLog.html?buildId=6288&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 484, ignored: 6 Build time: 00:14:45


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14137/testReport/) for this commit**


I've been looking for the original issue from travis, but they seem to have removed all issues from other repositories. Other projects reference this as: https://github.com/travis-ci/travis-cookbooks/issues/155 (now missing).

The original can be seen in https://travis-ci.org/jplana/python-etcd/builds/13057817:

```python
Traceback (most recent call last):
  File "/home/travis/build/jplana/python-etcd/src/etcd/tests/integration/test_simple.py", line 273, in test_watch_indexed_generator
    queue = multiprocessing.Queue()
  File "/usr/lib/python2.6/multiprocessing/__init__.py", line 213, in Queue
    return Queue(maxsize)
  File "/usr/lib/python2.6/multiprocessing/queues.py", line 37, in __init__
    self._rlock = Lock()
  File "/usr/lib/python2.6/multiprocessing/synchronize.py", line 117, in __init__
    SemLock.__init__(self, SEMAPHORE, 1, 1)
  File "/usr/lib/python2.6/multiprocessing/synchronize.py", line 49, in __init__
    sl = self._semlock = _multiprocessing.SemLock(kind, value, maxvalue)
OSError: [Errno 13] Permission denied
```

And that seemed to fix it.


Thanks for pointing that out. It's fixed now.


Ah gotcha, no problem.


Ross, do you remember if we did anything other than adding logger errors to this repo?


Ack. Implemented in e48ece5953250ba4aa3cd54243bd7dabb25b2ad5.


This seems to work even when there is no `_site` folder. I think it's because the `build()` function is [one of the first things called in `dynamic_site()`](https://github.com/yihui/servr/blob/2c8fd1e0e110d9b64082665696ce73eac77db131/R/dynamic.R#L161). So `_site` should exist before we [start the server](https://github.com/yihui/servr/blob/2c8fd1e0e110d9b64082665696ce73eac77db131/R/dynamic.R#L213)

(by the way, as far as I can tell, `update` should be a logical vector of length one)


Just pushed it. :)


Can you please use pronouncable variable names? If you don't like `event`, which _isn't_ a keyword, can you at least use `e`?


@nkalvi can you post the entire failing portion of the build log (not just the last 10 lines)?

+++ nkalvi [Apr 22 15 15:50 ]:
>@jgm
>
>I got the following error while trying to compile under Windows 8.1 (`img\\multiscripts` vs `img/multiscripts`):
>```
>Failed to install pandoc-1.14
>Last 10 lines of the build log (..\cabal\logs\pandoc-1.14.log ):
>"MediaBag did not match:\nExpected: "[("img\\check.gif","image/gif",1340),("img\\check.jpg","image/jpeg",2661),("img\\ch
>eck.png","image/png",2815),("img\\multiscripts_and_greek_alphabet.png","image/png",10060)]
>Actual: [("img/multiscripts_and_greek_alphabet.png","image/png",10060),("img\\check.gif","image/gif",1340),("img\\check.
>jpg","image/jpeg",2661),("img\\check.png","image/png",2815)]
>
>         Properties  Test Cases  Total
> Passed  10          576         586
> Failed  0           1           1
> Total   10          577         587
>Test suite test-pandoc: FAIL
>Test suite logged to: dist\test\pandoc-1.14-test-pandoc.log
>0 of 1 test suites (0 of 1 test cases) passed.
>cabal: Error: some packages failed to install:
>pandoc-1.14 failed during the tests phase. The exception was:
>ExitFailure 1
>```
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/jgm/pandoc/commit/56e4ecab20613d86a6660547ed87e7ff4b80d632#commitcomment-10857946


Yes. In all generality, it's a cache of `C` (a.k.a `configurable`) per tenant, that is invalidated when receiving the special tenant key/value events.

In practice, `C` is always an `HttpClient`. The model is very similar to the Ruby one (`C` would be an `ActiveMerchant` instance).


Hi Deyan,

that's a very good suggestion. I'll look into it. What would be a good format for returning the POS tags? Maybe a hashmap that maps word ids to POS tags?


ah sim, eu acho que deve ter em algum lugar, vo perguntar


Having a string default for an integer variable feels wrong, no?


Ah! I'll fix that to reflect what rippled has.


I'd rather keep the old name as TxSet is what we're receiving


Do we need this when running in WildFly?


Just curious, what is this link for?


Is this a typo?  HikaryCP vs HikariCP?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1136 of 1136 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would make sure the authentication is the same.

Are you able to compare with the commit we forked from?
On Apr 22, 2015 6:10 PM, "Brandon Fulk" <notifications@github.com> wrote:

> Ross, do you remember if we did anything other than adding logger errors
> to this repo?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/42dev/spree/commit/c31a45e9bbb6770935b9196f6c9b8c61bd9692b2#commitcomment-10858193>
> .
>


this should probably be a list comprehension instead of a dict