This gets the data available in the Jinni Ratings page (Title, Score, Rating Date, Content Type, Image, URL Name).  It does NOT get Year, Director, Genres, Film ID.  For that we need the film's page for each film, which is slow.


Oi, Professor, muito obrigado pelo feedback.
A melhor forma de terminar bem um projeto é o começando cedo.


dang. I have a want to implement simple locks using just the create API, the base fork doesn't implement this at all properly to do it. Is this on clojars?


Indentation should always be a multiple of 4 spaces. #pylintpolice


+1  Good one, @c3mdigital


toSeq.distinct would be more explicit


Your solution is correct.

Anyhow:
 - please alter comment above your changeset
 - please rename `observation_date` to `observation_date_utc`


@c3mdigital We need to check for any good ones from Django Unchained.


Where is Simon and Jean-Karim solution to VerifyThis by the way?


I know of them, but I think the ones I proposed are a bit different
though and may be more general.

Le 20/04/2015 16:06, Catalin Hritcu a écrit :
> This kind of assumptions keeps coming up, see for instance `forall_intro` in
> https://github.com/FStarLang/FStar/blob/master/lib/classical.fst
> or
> https://github.com/FStarLang/FStar/blob/master/examples/metatheory/norm.fst
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/FStarLang/FStar/commit/25c5cc948b26c703abbbc8fbd5c02d2ac8827607#commitcomment-10803720
>


I'd change this to `"application/json" ++ _` to allow for `encoding=utf-8` to be appended


From other commits I see there is https support which sits on port 443 by default. What is UMS behavior? Any http(s) listener is on 9001 or https exclusively uses 443 by default? I am sure I will find it in code but you know, asking is easier way to get the answer. sorry :+1:
Thx


could u tell me the commands to install all the extra needed modules for this script through python directly


What about arrays? Those will decode as a list, not as a tuple.


Should a fatal error return from this func?  Looks like the code keeps going and can fail in subsequent code.


Not pushed in the repo yet, as far as I know.

Le 20/04/2015 16:10, Catalin Hritcu a écrit :
> Where is Simon and Jean-Karim solution to VerifyThis by the way?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/FStarLang/FStar/commit/25c5cc948b26c703abbbc8fbd5c02d2ac8827607#commitcomment-10803816
>


I don't like your commit message. In my opinion it should be like: "Use response date instead of hardcoded, fix #<ticket_number>".


I confirm it works


so ok :-)


Add meaningful java doc


Made this change based on feedback from @rlskoeser on redirect protocols.


sounds good to me


Oh, sorry. I will be careful.
It was my beginning on inasafe... :)


Explain clearly the meaning of dynamicNotifications


Добавил документацию в 520110bdce5e7bd214e74b87f66d8238b93844f5, указал, что 0 не может быть.


please increase the attempt


Wow c'est cool !


range, not rage


This could be split into it's own PR, it's useful on it's own


goagent build 不过，main.go:67: unknown httpproxy.Handler field 'Transport' in struct literal


What are possible values for `DEFAULT_DUMP_DIRECTORY`? With 640, you end with 750, which is okay, but with 600, you'd get 710, which is too permissive.


The validate part has to happen *before* the move, and the notify after that, so `validate_transform_and_notify` is the wrong abstraction here.


Исправлено в 0ad12130634db368f8ff97c0d8a689930cc214fe


See above.


OK, I like the approach, only some nitpicking inlined above.

I noticed that ```libusb_set_configuration()``` gets called also in ```hackrf_cpld_write()``` so this should be handled too.

However I don't think that setting the configuration and claiming the interface is a job for a ```_write``` function, maybe ```hackrf_open(hackrf_device** device)``` should become ```hackrf_open_configuration(hackrf_device** device, int configuration)``` and there should be two wrappers like:

```C
int ADDCALL hackrf_open(hackrf_device** device)
{
	return hackrf_open_configuration(hackrf_device** device, 1);
}
int ADDCALL hackrf_open_cpld(hackrf_device** device)
{
	return hackrf_open_configuration(hackrf_device** device, 2);
}
```
and then ```hackrf-tools/src/hackrf_cpldjtag.c``` would use ```hackrf_open_cpld()```

Again, I don't have a hackrf device so maybe it's faster if you do the actual change.


Thank you sir!


`Fatalln` ultimately calls `os.Exit(1)`


This could also be split into a separate pr at least for the first 4 files


Yes, it is on clojars. BTW, this fix has just been merged. This fix won't be on clojars until @liebke cuts another release.


Исправлено в 520110bdce5e7bd214e74b87f66d8238b93844f5


lowercase Rx


Thank you for contribution!


'extensive' rather than 'intensive'?


Sure. This commit was here by mistake.


kalau untuk laporan kirim via google drive saja ..
pake account dari google classroomnya kampus


That's correct, it's already the case in the existing `factory()`. If we don't want it we either would need to configure the full classname, or have `getClassChildren()`..


Oh awesome, it got merged. :+1:

On Mon, 20 Apr 2015 at 16:18 Kurt Vangraefschepe <notifications@github.com>
wrote:

> Yes, it is on clojars. BTW, this fix has just been merged. This fix won't
> be on clojars until @liebke <https://github.com/liebke> cuts another
> release.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kvangrae/zookeeper-clj/commit/950ce6298c3bc6439c59d8bf1970163aa58b1605#commitcomment-10803978>
> .
>


maybe it could be changed to something like

    #!/usr/bin/env fontforge -script

?


I'm not sure httpRequest.getUri() is enough. I'm almost sure the getUri() will only retrive the request path. In this case I think it's necessary to include the protocol, the host and port as well. Please validate it with the HTTP transport


static imports


PArray is an interface and I needed something that could wrap a PJsonArray and a PYamlArray


Sorry and what does it mean?

> On Apr 20, 2015, at 10:16 PM, CNMan <notifications@github.com> wrote:
>
> goagent build 不过，main.go:67: unknown httpproxy.Handler field 'Transport' in struct literal
>
> ―
> Reply to this email directly or view it on GitHub.
>


Is it worth mentioning frequent use of custom widgets to keep things reusable and modularised?


The change of \1 to $1 in Vector.pm and in parserOneOf.pl seem correct to me.

The change at line 2002 in macros/PGbasicmacros.pl is not correct.
I'll update the pull request.


We haven't really said when we'd use events over Observables.


Sorry added comment about it, but too late:

> # Re-instantiate plugin to get rid of existing database-connections etc
https://github.com/cargomedia/bipbip/pull/115/files#diff-3ab3b42c7397e3dbeb7a168937e40358R59


Исправлено 520110bdce5e7bd214e74b87f66d8238b93844f5


Do the hierarchy change that we talk about. We also need to think more about the names.


If there is a mapping between traffic light and street edges that should be simple: just increasing the traversal time (decreasing the speed) of the relevant street edges.


I agree that the automatic method would be cleaner and would avoid the second call to detach_kernel_driver(), but there are users with older versions of libusb that we would like to support.

While the code becomes more efficient if we use the automatic method, supporting users with different setups becomes more complex.


Excellent point.


work who cares why :trollface:


Within this catch there's another method that sends a response in case of failures. Validate if, when failing, it's also required to send the notification. If that's the case then you need to add another fireNotificaiton.


I think there's a test case missing for the requester


В данном контексте похоже, что да.


@leahpadgett done with my review. every app in the AppStore that offers web browsing functionality is required to use UIWebView. it's such a seemingly simple class/control as we are using it, but such depth and power is in there. the entire iOS SDK is like that.


Interesting. Your values are very far from the original ones. Did you use the Texel tuning method ? I guess it's not SPSA that gave you those values.


Here is what was submitted at VerifyThis.

I do not know in which part of the repo they belong, incomplete and
unrefined as they are.

2015-04-20 16:13 GMT+02:00 ckeller <notifications@github.com>:

> Not pushed in the repo yet, as far as I know.
>
>
> Le 20/04/2015 16:10, Catalin Hritcu a écrit :
> > Where is Simon and Jean-Karim solution to VerifyThis by the way?
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/FStarLang/FStar/commit/25c5cc948b26c703abbbc8fbd5c02d2ac8827607#commitcomment-10803816
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FStarLang/FStar/commit/25c5cc948b26c703abbbc8fbd5c02d2ac8827607#commitcomment-10803865>
> .
>


Yes, absolutely.


please move deprecated methods to common place and remove this line


That commit message should read revert \1 to $1 in the matching string.


I'm merging so you can work further on it.

Please convert your filter to using a single configuration file that defines what regex matches what hook, rather than having a getopt for each single hook.


te


You'll want to strip off the extra `=np19py34_0` stuff from these so that they still work for pip (and so that they work for conda for versions other than 3.4).


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13993/testReport/) for this commit**


This needs to default 1. If it is only set by the configuration file, we risk that it is not activated on upgrade because of RPM's `.rpmnew` handling.


It's sad when commit have files with changes only in imports.


No need to have in a separate module folder model. Just make sure the controller is nice and clean by refactoring chained methods into single description method names (as per example above)


Ah, for some reason I thought interface numbers didn't have to be sequential.  I can change this to a single loop from 0 to config->bNumInterfaces


I don't understand why the line number changed from 2005 in the previous version of the pull request to 2035 in this one.  I didn't notice any other differences in PGbasicmacros.pl that would cause this.


extract "strategy" to a constant


Download this zip: https://github.com/kennethreitz/requests/zipball/master
extract it, go inside the library and type
python setup.py install


1: M110 missing component name


1: M111 unrecognized component name: docs


1: M111 unrecognized component name: legacy


2: L102 copyright year is outdated, expected 2015 but got 2011
22:1: E402 module level import not at top of file
23:1: E402 module level import not at top of file
24:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.modules.ranker.registry
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
31:13: E221 multiple spaces before operator
40: D401 First line should be in imperative mood ('Map', not 'Maps')
40: D205 1 blank line required between summary line and description (found 0)
40: D208 Docstring is over-indented
61:1: E302 expected 2 blank lines, found 1
61: D205 1 blank line required between summary line and description (found 0)
61: D208 Docstring is over-indented


Can it be tested somehow?


see [here](https://github.com/golang/go/commit/f10e03770c9702b3ee3bcc2ccdb78691f389c1a3)


22:1: E402 module level import not at top of file
23:1: E402 module level import not at top of file
24:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.modules.ranker.registry
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
31:13: E221 multiple spaces before operator
40: D401 First line should be in imperative mood ('Map', not 'Maps')
40: D205 1 blank line required between summary line and description (found 0)
40: D208 Docstring is over-indented
61:1: E302 expected 2 blank lines, found 1
61: D205 1 blank line required between summary line and description (found 0)
61: D208 Docstring is over-indented


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13994/testReport/) for this commit**


/cc @slluis @garuma


@cwebber, why is it preferable to assign str(value) to a variable and then to the \_\_str\_\_ method?  Is this also an XSS concern?  Or is it that we might get "undefined" for str(value) and that's handled better during variable assignment?


@RobertoSanchezHerrera, @rmcmx, could you review my code please?


I think remote-logging fits better in our infrastructure. Maybe allow to define the logger using a separate configfile using one of the mainline logger configuration format (https://docs.python.org/2/library/logging.config.html)


Yeah, okay – I see this as a useful core feature. Tell you what: fix your whitespace (2-space indents, not tabs), add a test and docs for the feature, and it's in.


For the current Kodi Development Build (*-nightly), the pvr-addons are not longer in https://github.com/opdenkamp/xbmc-pvr-addons, so it is obsolete to clone this source for *-nightly builds.
The new (pvr-)addons are included in source tree project/cmake and has to build separately with cmake/make


Doesn't it compile without `new` ?


:ok:


这个应该是点击一下屏幕就会出现吧


コメントを書いてみます


i _have_ to remember to squash commits
(http://stackoverflow.com/a/9254257)


This race is already handled earlier, so this change isn't correct.

Specifically the race is handled here:

                ufsdirhash_hold(dh);
                VI_UNLOCK(vp);

                /* Acquire a shared lock on existing hashes. */
                sx_slock(&dh->dh_lock);

                /* The hash could've been recycled while we were waiting. */
                VI_LOCK(vp);
                if (ip->i_dirhash != dh) {
                        VI_UNLOCK(vp);
                        ufsdirhash_release(dh);
                        ufsdirhash_drop(dh);
                        continue;
                }
                VI_UNLOCK(vp);
                ufsdirhash_drop(dh);

Once dh_lock is slocked, no other thread can remove a reference from dh.  If ip->i_dirhash is still equal to 'dh' after the slock is acquired, then we know that there is at least one additional reference from the inode to the dirhash, and that reference cannot be dropped until after dh_lock is released.  Thus, the reference count is always >= 2 when ufs_dirhashdrop() is called (1 reference for our ufsdirhash_hold() at the start of the block above, and 1 from the inode).

Also, setting dh to NULL inside ufsdirhash_drop() does not affect the 'dh' variable in the functions that call it, so dh will never be NULL and your test would not actually work anyway.  Clang probably removes the entire check as dead code.

What you could do is KASSERT() that the refcount is >= 2 before ufsdirhash_drop().  If that appeases scan-build then that would be useful, but the goal would be to appease static analyzers like coverity or scan-build to avoid a false positive.


@geevee what do you think?


versionCode不需要在开发的时候频繁更新，只需要在发布的时候更新+1就好了，如果你要表示有版本演进，在versionName里表示就好了


new


Thank you for contributing! I'm just curious, why replace it with that one?


How about this code:

```
snake :: String -> String
snake s = case s of
  a : r@(b : _) -> let
    t = snake r
    l = toLower a
    in case (isLower a, isLower b) of
      (True, False) -> a : '_' : t
      (False, True) ->  '_' : l : t
      _ -> l : t
  _ -> s
```

it only adds a "_" if the word starts with an uppercase letter.


este by bolo fajn premenovat cele cviko na Cvicenie 8 :)


This seems like a reasonable thing to do.  I could even #define or enum those configuration numbers so that they mean something.

I'll make these changes and submit a PR.


这个在可以下载versionName里吧


Thanks


Yup - it's [available here](https://github.com/naupaka/Sunday_scripts/blob/master/Final_challenge_solution.Rmd). Teh rendered html is available there as well.


It looks like we have dropped support for Wiziq due to lack of use.  For now, you could restore it by just bringing this code back to `vendor/plugins`, but you are right that we are in the process of upgrading to rails 4, and once that is complete, code in `vendor/plugins` will no longer work.  We have been moving our plugins to `gems/plugins` and converting them to rails engines.  You could look in the `gems/plugins` folders for examples of other plugins that have been converted.  Hope that helps!


android里面不要使用e.printStack()，应该用Log.e(TAG, e.getMessage())，stack里你基本看不出什么信息


@euanh: do you have any particular comments about this bit?


Hi Anuj,

Sure as I was interested by your branch, I used it and took the opportunity to make some changes/fixes. Ping me when you are ready :)


Look at lines 39 and 45. The re to identify a new speaker you have ?(PRESIDENT|SPEAKER|CHAIR(MAN). But the re to add a speaking tag you don't have CHAIR(MAN). That may be creating some of the orphans where The CHAIRMAN is the speaker.


Sem esse ajuste não conseguimos usar o padrão 'Subparcela A00' na tabela Gazetteer, fica tudo 'Subparcela a00'


Just noticed that the previous one looks like square root notation. Maybe that's why? :)


Whoops. Nice catch!


J'aimais bien le terme de "Hall of Fail" pour le contest, ca pourrait être le titre de la future page accueillant tous les fails :)


这句话似乎没有意义，你不setText（）也是一样的


[TOC]

**接口名称**
**接口说明**
**URL**
**HTTP请求方式**
**请求参数**
**请求实例**
**返回数据实例**
**返回数据参数说明**

# 评论系统设计文档
## 1、目标
实现通用的评论管理方案，为各个不同的社交平台提供通用评论接口，实现第三方的评论管理。
- 提升评论概率，提升web、移动断的用户体验
- 解决审核问题，提供稳定、低成本的评论管理功能

## 2、系统设计
评论系统采用B/S结构，提供社交平台接入的API数据接口，支持web、移动客户端。
评论系统包括：评论过滤、评论内容管理、用户管理、评论审计

系统结构示意图：

## 3、实现策略
### 3.1结构体系
B/S 结构
### 3.2数据存储
系统数据存储采用couchbase和redis

## 4、运行环境
centOS、nginx、tornado

## 5、数据模型

评论智能过滤、频率控制、实现方式

老付意见：
时间轴；不同业务线区分开；数据库设计要考虑HA；评论内容要丰富(文本，图片，url);评论盖楼(parent, children)

数据模型：
登陆用户，文章(评论对象)，评论内容，评论方式(盖楼、平铺)，发表评论用户(时间轴追踪)， 评论设置(对评论的各个维度做限制)

* * *
**Platrorm: 接入业务平台**
```
pUuid : 平台uuid
pDomain : 平台域名
pToken : 平台校验token
```
_ _ _
**User: 发表评论用户**
```
userId : 用户id
userName : 用户名称
```

_ _ _
**Content: 评论对象**
```
contentUuid : 评论对象uuid
contentId ：评论对象的id，接入平台传回的参数
type ： 类型，如：话题，动态、图片等等
```
_ _ _
**Comment: 评论**
```
commentUuid : 评论uuid
userId : 发表评论的用户id
cotentUuid : 评论对象uuid
parentId : 父id，用于盖楼，默认值 -1
releaseTime : 评论时间
detail : 评论内容--文本内容，包括文本，图片，链接等
likeCount : 喜欢/赞 计数
```
_ _ _
**Operation: 评论操作**
用户对某条评论的操作，包括：喜欢/赞、评分、举报
```
operateUuid : uuid
commentUuid : 评论uuid
userId ：操作评论的userid
operateType : 操作类型， 如：喜欢/赞，评分，举报
operateContent ：操作的具体内容
```

report:举报
```
reason: 举报理由。 1、色情淫秽 2、骚扰谩骂 3、恶意广告 4、反动言论 5、其他
```

score:评分
```
score: 评分
reason : 评分理由、默认为空。1、很给力！ 2、赞一个！ 3、淡定 4、神马都是浮云 5、山寨、6、自定义
```
_ _ _
**setUp: 评论设置**
针对不同的平台、提供不同的内容设置
```

```

## 6、系统集成架构
平台接入，属于评论列表提供的功能，评论的
### 6.1 评论列表服务
向平台提供评论的展示、操作等服务

####6.1.1 获取文章(评论对象)评论数 接口
**接口名称**
/threads/counts
**接口说明**
获取当前文章的评论数
**URL**
http://comments.qbao.com/threads/counts
**HTTP请求方式**
GET
**请求参数**
==domain==  *string* *not null* 分配给平台的二级域名。
==token==   *string* *not null* 分配给接入平台的token， 用于接入校验
==threads== *string* *not null* 需要获取的文章的id，即评论对象在接入平台中的id，可以传入多个id,用逗号分割，例如：1,2,3(或者4ff160411318693231000006, 4ff160411318693231000007)
**请求示例**
http://comments.qbao.com/threads/counts?domain=microStore&token=TqJyenJSN8T4N4Er41Kei4G2pULzQJSbZVZjXTzF&threads=1

**返回数据实例**
```
{
	"result" : [
    	{
    		"content_id" : '123456',
    		"content_uuid" : '4ff28d95552860f21f000010',
            "comments" : 20,
            "likes" : 0
    	}
    ]
}
```
**返回数据参数说明**


зацикливаний не обнаружено


I think this is correct.


Otherwise, when doing `npm install` we get the following error :
```
npm ERR! install Couldn't read dependencies
npm ERR! Error: Invalid version: "1.20150315"
npm ERR!     at Object.module.exports.fixVersionField (/usr/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/fixer.js:183:13)
npm ERR!     at /usr/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/normalize.js:30:38
npm ERR!     at Array.forEach (native)
npm ERR!     at normalize (/usr/lib/node_modules/npm/node_modules/read-package-json/node_modules/normalize-package-data/lib/normalize.js:29:15)
npm ERR!     at final (/usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:342:33)
npm ERR!     at then (/usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:126:33)
npm ERR!     at /usr/lib/node_modules/npm/node_modules/read-package-json/read-json.js:331:40
npm ERR!     at evalmachine.<anonymous>:272:14
npm ERR!     at /usr/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:102:5
npm ERR!     at Object.oncomplete (evalmachine.<anonymous>:108:15)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! System Linux 3.11.0-26-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! cwd ./
npm ERR! node -v v0.10.37
npm ERR! npm -v 1.4.28
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     ./npm-debug.log
npm ERR! not ok code 0
```


-# filecopy
+# pyco.py
 python file copy tool with pause button.

-So , im an ubuntu user and the file copy tools in nautilus and nemo did'nt seem apt.
+So , i am an ubuntu user and the file copy tools in nautilus and nemo did not seem apt.
 Currently working on a file copy tool using python and Qt.

 ##Features
+###Implemented:
+  - Pause button  indicators: current speed , average speed, estimated time, remaining size, percentage copied
+  - Made it calculate the progress by reading the size of the copied file, not the buffer size like nautilus and nemo
+
+###Not Implemented:
+  - Drag and drop
+  - Copying Directories , and queueing files
+  - saving progress log on pause and quit
+
+Will be implementing them on my free time.(Which I don't have right now.- Exams)
+
+**Thats it!**
+


k


Hah, odd, I have it locally. Must have forgotten to push the change! Thanks!


Support Internet Explorer 6.0 ...or riot!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13996/testReport/) for this commit**


Gracias!


Nice simplification. I hope this pass.


Hardcoded IDs have been removed in a later commit.

Btw: Is there a reason you override files like the compute_resource model instead of extending it? I will try to make it a real plugin without having to override foreman-files after gem installation.


hang on, I've better code.


@brendo Is this because the MySQL queries returns strings ? Should we parse it ourself ?

Automatic type-convertion/coertion is a nasty source of bugs...


Hi !!
I forgot it, you must do the same in this function (bootstrap-table.js).

BootstrapTable.prototype.toggleView = function () {
        this.options.cardView = !this.options.cardView;
        this.initHeader();
        // // Fix #615: remove toolbar when you trigger toggleView function.
        //this.initToolbar();
        this.initBody();
    };


I think this if isn't needed.

See: https://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-6.9.2. We should add the delta to all streams, and if they move from <=0 to positive then we add them to the writable list.


Refactored and reordered CSS for eligibility
Amends to theme colours


We probably need to also change outgoing_window to gpr_int64.


`#include <type_traits>` should probably be there to define `std::is_base_of`


If you want to, you could add `"ensure_newline_at_eof_on_save": true`  to your user settings file in sublime.


upfate


I think there's a constant somewhere that's usable instead of 4.


Remove this line.


call with initial `False` boolean.

```
snake :: Bool -> String -> String
snake w s = case s of
  a : r@(b : _) -> let
    t = snake True r
    l = toLower a
    in case (isLower a, isLower b) of
      (True, False) -> a : '_' : snake False r
      (False, True) | w -> '_' : l : t
      _ -> l : t
  _ -> s
```


Can we make 'build' more universal? We'll want to build other things too, like debian packages, docker images, init scripts etc. `build deploy-repo` would leave the door open for that.


We can replace `init` and `getInstance` with a single `getInstance` method which constructs a new DataManager and returns it.  It looks like this class is mostly a wrapper around a shared preferences instance and it matches the pattern used internally by Android here : https://github.com/android/platform_frameworks_base/blob/master/core/java/android/preference/PreferenceManager.java#L368.

Also we probably want to call getApplicationContext() on the context object so we don't accidentally leak a reference to a service or activity.


what's happened here ?


Not just looks like, it's [U+221A SQUARE ROOT](http://www.fileformat.info/info/unicode/char/221a/index.htm). I replaced it with [U+2713 CHECK MARK](http://www.fileformat.info/info/unicode/char/2713/index.htm), which is meant as the counterpart to [U+2717 BALLOT X](http://www.fileformat.info/info/unicode/char/2717/index.htm). Thanks for merging :)


TeamCity xBIM :: XbimExchange :: Build [Build 241](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1453&buildTypeId=XBIM_XbimExchange_Build) is now running


as with the collectionViews, compositeView will ....


This should just be done in the constructor.


Wouldn't be better to have an ObjectSerializerAware interface that we can reuse?


TeamCity xBIM :: XbimExchange :: Build [Build 241](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1453&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:13


Succah!


success


Why was the dependency to cagt removed?  There's code duplicated between cagt and this repository now.  Was it simply to work around engineers having to track through the abstraction layers?  Is there another benefit?


Some of this logic is copy-pased from AREnum (it seems). You don't even need all of these methods. But since we should follow DRY, moving the method getEnumValues to another location (MUtil maybe? I am not sure) to a more appropriate place.


I think this will need to be signed too - and so probably an int64 also.


public I would say.


Unifying the mm_play_sounds parameter to be truly global.


@jonludlam: No, I've removed that in my concurrently cache working branch.   If the other repositories are remote, there will be a big slow down, but if they are local it should be tolerable.


Why are the fields and their getters and setters not in the same place? That is what we usually do.


obj/SHARED_LIBRARIES/libqdutils_intermediates/cb_utils.o: in function android::Singleton<qdutils::QCCompositionType>::getInstance():frameworks/native/include/utils/Singleton.h:40: error: undefined reference to 'android::Singleton<qdutils::QCCompositionType>::sInstance'


Line 1505 will need to be s->outgoing_window <= 0;


Perfect! :)


Objects.hash


The last letter needs to be turn to a lower letter, too. (`_ -> map toLower s`)


coool, thanks


I think this needs to be slightly different now that `edit.yournextmp.com` is going to be a secondary domain:

```javascript
  ga('create', 'UA-660910-28', 'auto', {'allowLinker': true});
  ga('require', 'linker');
  ga('linker:autoLink', ['edit.yournextmp.com'] );
```

... as suggested here: https://support.google.com/analytics/answer/1034342?hl=en


Not sure if this should be a string, the parameter says callable


Succah!


"Consejo Europeo" is not the Council of the European Union. The correct translation is "Consejo de la Unión Europea"


@cheuschober

i m having " ChessMatch do not have move attribute"

i have debug it and i m still have the same issue even when i use your sample code


We still want that. We don't want to start detail reader threads if we're checking the config.


em geral tá bom, cenários legais, eu só corrigiria um pouco o inglês


алисы - удобно, их нужно посадить по всему движку


@AJSturrock @jHoldroyd Could you check over this and see I haven't made a mistake? I think it might be tidier than what we were doing, and should fail gracefully if theres anymore non standard responses.

I never actually noticed the API returned "errors" and "error"... :suspect:


This fixed #11


It seems the abs should go into the definition of distance.


When I used a regex in my previous review I didn't mean to encourage to use one for the actual solution although I have to admit that it occurred to me. This could be a very elegant solution although it might not work well in practice if it turns out to be inefficient respect to just work with the list of CigarOperations.... I would like some input about this from @lbergelson or @droazen. Is true that we should not fall in premature optimizations but is also true that we should not produce grossly inefficient code (I'm kind of quoting @droazen here). Hopefully the pattern pre-compilation step does a good job in preventing that but we have to make sure...


oh and btw the transcoding code totally comes from : http://stackoverflow.com/a/14133998 :)


двойной класс `article-info-item`?


Moved it to the bottom to appear in one closely related group


This needs to be discussed


Seems to **prop:event.change.branch** and example in http://docs.buildbot.net/latest/full.html#gerritchangefilter
are incompatible in case of `GerritChangeFilter("main", "ref-updated")`

Event "ref-updated" has no attribute "event.change.branch":
```
Properties
Event.refupdate.newrev 	<masked>
Event.refupdate.oldrev 	<masked>
Event.refupdate.project 	<masked>
Event.refupdate.refname 	master
Event.submitter.email 	<masked>
Event.submitter.name 	<masked>
Event.submitter.username 	<masked>
Event.type 	ref-updated
```

So, in my case, this filter can't be used to trigger build after submitting path in gerrit.


:+1: :+1: :+1: :+1: :+1:


Missing some stuff here?

```java
    // Initialize member TextView so we can manipulate it later
    mTextView = (TextView) findViewById(R.id.text_message);

    // Make sure we're running on Honeycomb or higher to use ActionBar APIs
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
        // For the main activity, make sure the app icon in the action bar
        // does not behave as a button
        ActionBar actionBar = getActionBar();
        actionBar.setHomeButtonEnabled(false);
    }
```


Could you please change this too:
```
SUPPORTED_LINUX_3:=10 11 12 13 14 15 16 17 18
SUPPORTED_KERNELS:=$(subst $(space),$(empty),$(foreach v,$(SUPPORTED_LINUX_3),LINUX_3_$(v)||))LINUX_4_0
```

I've tested this locally; and it works.
I'd like to keep supported versions down to Linux 3.10 a bit longer.
There may be users that use some other versions in-between.


Thanks for doing this!


Missing `onDestroy()`?
```java
@Override
public void onDestroy() {
    super.onDestroy();  // Always call the superclass

    // Stop method tracing that the activity started during onCreate()
    android.os.Debug.stopMethodTracing();
}
```


Eh, I like this way more... ;)

```
query = query.filter(cls.project_id == Project.id)\
             .filter(Project.name == project_name)
```

["PEP8 unto thyself!"](https://www.youtube.com/watch?v=wf-BqAjZb8M)


第一个页面算是我写的第一个网页，写的太慢了，起名都词穷了，慢慢来吧，fighting。


Does this mean that SimpleCov uses RuboCop to check its own style... or that RuboCop is incorporated into SimpleCov?


I don't understand why **return 0** is a valid workaround ?


Missing `onPause()`
```java
@Override
public void onPause() {
    super.onPause();  // Always call the superclass method first

    // Release the Camera because we don't need it when paused
    // and other activities might need to use it.
    if (mCamera != null) {
        mCamera.release()
        mCamera = null;
    }
}
```


Also, missing `onResume()`. Am I looking at the right thing?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13997/testReport/) for this commit**


Done! Saved as detail_Yorik.ifc


I reread the section about advance configuration. As you said this is needed to use plugins multiple times so please ignore my earlier comments ;)


Nice, very clear wording.


maybe a better name for this argument would now be `stringOrArray`?


maybe something like this? I don't know if it's worth it but it would use the automatic reattach mechanism on newer systems and still only deatch the minimum necessary on other systems (i.e. without looping on all interface which is needed just before set_configuration, not in all cases):
```C
#if defined(LIBUSB_API_VERSION) && (LIBUSB_API_VERSION >= 0x01000102)
	libusb_set_auto_detach_kernel_driver(usb_device, 1);
#else
	result = libusb_kernel_driver_active(usb_device_handle, 0);
	if( result < 0 )
	{
		libusb_close(usb_device);
		return HACKRF_ERROR_LIBUSB;
	} else if( result == 1 ) {
		result = libusb_detach_kernel_driver(usb_device_handle, 0);
		if( result != 0)
		{
			libusb_close(usb_device);
			return HACKRF_ERROR_LIBUSB;
		}
	}
#endif
```

Just an idea.


Oh, I think

```php
$schema .= $indent . '<table name="' . htmlentities( $table ) . '">' . "\n";
```
 needs to be removed or commented out in favor of the new line above.

I think I just forgot commenting the old line $schema.= $indent out on the pull request.


Sorry, my editor added some autoformat spaces to the function.


Please, insert a comment into the source code. We will forget the reason of it and we can accidentally change the "if" statement again.


ACHO que, a menos que os métodos de Evaluation sejam static, vc nao pode fazer Evaluation.método assim,
teria que criar uma instância (Evaluation ev = new Evaluation()) e depois fazer ev.findByTitle() ou então colocar os métodos estáticos.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13998/testReport/) for this commit**


Requested by Jasmine.


Current http transport is not firing a notification when an error occurs.


Guy implies male, this is sexism and you should be ashamed!

I demand this be changed to 'person_with_gender_of_their_choosing_even_helocopter'


C’est pris en compte, et même ASCII-ARTÉ ;)


Passing $parent instead of e.g. $parent->name to strncmp() here seems to break the APY/DataGridBundle for us. Not sure about the side effects of changing this, so would like feedback before submitting a PR.


Do we need a separate ProfileNotInCacheException?


Get with the times, guy can now be used for any sex!


代码写的如此之渣,居然被挖出来了,羞愧啊


Thanks for feedback, fixed in 57acc915b54aa411337f4d175defff04c89067e3


Yes, however alloc() returns a pointer to memory directly after the balloon.

    Balloon *pick=h.last;
    ...
    return (void*)(pick+1);

Accordingly, free() assumes it is freeing this pointer.

    Balloon *b=(Balloon*)p_ptr;
    b-=1;

but clear() does not give free() the pointer it expects. The suggested change addresses this. A different approach is to create a private free() which assumes its parameter is a balloon.


O próprio groovy disponibilizou este método ao criar o atributo title, então subentendi que estaria correto


Shouldn't it be `.disconnect()`? I don't remember `#hangup` method in iframe phone API.


Good :eyes:


Done.
https://github.com/php-fusion/PHP-Fusion/commit/72e6aa717184464e20ca3cc781f6dcdc63ae7a3e


Thanks mate!


LGTM


Sorry, I misread the diff :-)


What if we want different negative offsets in different streams from the same file ?


Ok, not fully there, but there is progress!

We need to find out what makes Revit decide if an element is editable or not... I thought at first it depended on if the geometry was an IfcExtrudedArea or IfcFacetedBrep, but by now we had a lot of IfcFacetedBrep that were editable... I have the impression that objects composed only of rectangular faces are editable, others not... I'll build a test file with a few cases to see (commit 0fbd8a6 might help too)

In any case, on FreeCAD's side, I think we now reached a stable bottom... The file is coming back identical now.


Don't you need an "Extension" attribute on each method?  Also add systematic tests where you at call each method at least once.


Ah, I didn't realize that it's building a package *or* a deploy repo, depending on an option. Since the builds are mutually exclusive and have different options, I still think that subcommands would be cleaner and easier to document. What do you think?


oh totally forgot, thanks :+1:


/me still isn't fan of the ``\`` (will queue the video to watch later)


@fred3m, would you like to finish this function?


Please open the PR, using $parent->name is better


@ajinabraham  is it only for requests, as i have already installed it


thanks for the helpful comment :+1:


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1132 of 1132 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/13999/testReport/) for this commit**


@lucasart Indeed, but I use static evaluation on about 10M quiet positions, so it's more like the Gaviota tuning method. :-) Unfortunately, without success so far.


Ok.


flag needs to be reset for each column


Spacing looks weird on Github.


Contact us at team@cooliris.com with details, including the embed code you are using, and we'll try to help.

The self-hosted embed wall should work for embed codes using third-party services (api://…) and Media RSS feeds (feed://…), though will [no longer work for centrally-hosted walls](https://github.com/cooliris/embed-wall#centrally-hosted-walls) (z=…).


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14000/testReport/) for this commit**


Bad things happen...


I'm not a person anymore?


Does this method remove the pieces of the selected color?
The method name is ambiguous to this.


Setting up and playing by the rules, I like it.


I initially interpreted this as 'the output of conversion'. Might be better named `mapping` or `conversion_mapping`.


We probably don't need to create the checkpoint flag (file) if LeaveRunning is set.


Does the plugin fail the build if you change the severity to error?


Is the use of "i" javascripty??


In the future the user would specify it in either a config file or arguments used to launch DogeHub.


owlint didn't seem to be happy unless creator was a string or a mailto URI...


The change of argument name here is helpful.


:+1:  :100:


I like this implementation of determining if it made it to the end of the list by using size.


not helicopter!


Look how smart you are! I bet you found this quickly. :+1:


Argh, just noticed this. s/new Date()/Sunset.start_/


That is the only module you need install to run this script.


I haven't used Compat yet and was tracking down how this is done. Is it the case that `@compat` is called in the manner above in every instance there is a syntax conflict?


A note on best practices — this (and all user or system-specific files) should be in a global .gitignore. See https://help.github.com/articles/ignoring-files/#create-a-global-gitignore


Top, kun je me vast af en toe helpen :-)
Op 20 apr. 2015 3:02 PM schreef "JM Versteeg" <notifications@github.com>:

> Ik hou je in de gaten hoor
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RoadXY/Xabber/commit/6a4aeaf39a4ab30b70c3f82309aae0497bf3e8d4#commitcomment-10802485>
> .
>


Unused attribute? can Delete this


I am on Gentoo Linux.


@anpegar it is already fixed! thanks


Concise and easy to read. Crushed it.


I like this:) This is nice and fancy Ruby-ness:)


this is a great test.

However, it's testing quite a lot of stuff, maybe three or four things:

* vanilla cloning a tree of stuff to the same depth in the heirarchy
* cloning a sub-tree to a different depth
* ignoring anything not mentioned in the mappings
* the effect of combining multiple mappings

I think it would be easier to understand the behaviour if we refactored the tests a bit and have separate tests for each of these scenarios.


Delete commented out code


@ajinabraham thanks


Why not include :get on the line above?  Or, if you're breaking for space, perhaps move :push to the second line also?


Unclear as to why these methods were removed.


Test endian


I personally really dislike ABCMeta for defining interfaces.  Zope interfaces can be useful, and abstract classes in Java in C++ as well.  I haven't figured out yet what value ABCMeta adds, so I tend to avoid the clutter.  Feel free to ignore this comment. :)


Good but it could have been a little bit more cleaner.


What is link1_val & link2_val? where are those variables coming from?


obviously this doesn't matter now, but maybe we should put this in a setting


You may want to change the == to a  === so it will only test if they are the same object. Not if they have the same payload.


The first one. Here is the relevant range of commits: https://github.com/colszowka/simplecov/compare/e718d28f886275dc418518324b47ce06213a6cd8...f941713e585aff0043dbba657506cc99c3056bdc.


Good and concise.


what would happen if this hash had an 'updated' key?


The comments are nice.


# HelloWorld
## This is secondary heading

*choice 1
*choice 2


Nice argument error message


Do we need to initialize @first_item and @last_item here?


```php
$filteredDay = filter_var($dayOfTheMonth, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'max_range' => 31]]);
if ($filteredDay === false) {
...
```


Great use of 'or' logic throughout.


Thanks for adding the `alt:`


If this is not the case, https://github.com/typesafehub/config/blob/master/config/build.sbt#L33-L61 might be of help.


ras


get method looks nice and clean. It's easy to read and doesn't have any unnecessary parts. It might be nice to explicitly say "return" on line 38.


Might want to refactor here to reconsider how many instance variables the attr_accessor method really needs.


> We can replace init and getInstance with a single getInstance method which constructs a new DataManager and returns it

I was doing this as you suggested at some point. But then have a problem referencing the Context object in the `CloudProps` class, as it doesn't have a reference to the Context object. So instead of modifying `CloudProps` constructor to pass in the Context object just for the sake of DataManager, I think it's better to init the DataManager once on start to pass in the context, and afterwards no need to reference the Context object any more. Is this a valid reason to have both `init` and `getInstance`?

> Also we probably want to call getApplicationContext() on the context object so we don't accidentally leak a reference to a service or activity.

Yes, good point. Will fix it.


The "def get(index)" method is very clear.  I think I used a counter variable, but looping using index.times makes more sense and is easier to read.


VERY ruby. ie idiomatic. :wink:


Usually. There can be times where commas can confuse the macro parsing, and you can instead do `@compat(Tuple{T,T})` to make explicitly clear where the macro call should end.


Consider the syntax...

raise ___Error if condition

It might make some of the code a little more readable:smile:


this is not available in JDK7, so maybe FQCN in link for now


consider renaming variable argument here to Index instead on nth-item and then refactor the method to use 'Index.times do ...' instead of having a 'count'


Remove comments.


Doesn't need this in build


html bug - </b> is not opened, pls fix, thx


Looks good!


应用场景还蛮多的，以前没觉得 `filehook` 用途这么广。


@andyberry88, can we just make the code recognize both the new and old names, but log a warning if the old name is used?


Perhaps hide this under the Charts flag to avoid the dependency on cassava for building buildsome?


The refactor makes it much easier to understand your thought process.


:+1: Looks nice and clean, well done.


Unnecessary parenthesis


missing space between record and %s?


Everything is clean and readable. Good Job!


You might want to get rid of the comments unless you are using it for reference. It takes up a lot of space and doesn't serve any other purpose.


It's unclear what knowing the payload of the last linked list item gets you here. I'm guessing you might use this later in sorting or an index method, but if not, you should consider cutting it.


Neat! Did not think to use 'sub' here, so helped me learn an alternate (and better) solution.


For Russian Translator: Название в креатив меню не переводить!


the "to_s" method is very readable and concise.  It's cool that you used string interpolation and again, nice use of looping with (@size-1).times


Nice Job!


100% agreed!


Nice use of string interpolation.


Yes, this'd be better deleted


Clear naming convention and logic for both get and push


This violates an mcs constraint:

mlsconstrain process { sigkill sigstop }
    (( h1 dom h2 ) or ( t1 == mcskillall ));

and an mls constraint:

# all the process "write" ops (note the check is equality on the low level)
mlsconstrain process { sigkill sigstop signal setsched setpgid setcap setexec setfscreate setcurrent ptrace share }
    (( l1 eq l2 ) or (( t1 == mlsprocwritetoclr ) and ( h1 dom l2 ) and ( l1 domby l2 )) or ( t1 == mlsprocwrite ));

shutdown.te will need:

ifdef(`enable_mcs',`
  mcs_killall(shutdown_t)
')

ifdef(`enable_mls',`
  mls_process_write_all_levels(shutdown_t)
')


Whoa, this works on Python 2 too?  Awesome!

Any reason for `dict()` instead of `{}`?


This file should be included in the repo as well


Did we really need another dependency? Why couldn't you just require the JSON file and use object notation to get the config?


the second time you use first_item, it should also be @first_item.

```@first_item = @first_item.next_item```


This section also isn't used, but let's leave it here for a while


I saw that in the Travis output as well. I'll update that tonight.


This is a nice method but it seems like it would be a bit inefficient in practice because your looping through your list however many times to push each item from the list into a different data structure???

Think big O as this is probably like O(n) or something rather than 0(1) etc...


Good use of single line if statement


`TextUtils#isEmpty()`使うとnullと空文字のチェックしてくれるで


Interesting.  I know that you're trying to avoid the "remote client altered client timestamp" but I think this approach is likely to mislead more than the other approach.

Could we track the timestamp for the actual tabs record?


Nice :+1:


cute number names. :smile: Consider associating the name with what you are using it to find.


Oh, but that doesn't do better.


Are you missing something here? echaloasuerte_legacy is a folder, right?

Also, what happens if you run twice this command? Or if you run it again when the tables are populated?


Nice refactor.


yesss


You can string these! For instance:

attr_reader :payload, :next_item


Succint


I would have expected `authentication_manager` to be a class, not an instance.


The refactored to_s is a nice solution.  The code you had for it last commit read a little more clearly to me ... but this solution also makes sense.  So I guess just whatever you prefer :)


Sure, that's fair.


Is it safe to publish this password here?


There are two identical checks for ```$name !~ /^end/``` here. Not a bug, just redundant.


当时我写得可认真了，最后 Wenye 也不看代码，好伤心啊… :joy:


Here I am not sure what you are looking for.


Thanks @maltoe! That was a bit sloppy on my part.


Very neat code.  Unsure as to what "word.to_s" is.


@lots0logs : Last version works with UEFI+Gummboot (and UEFI+grub) in automatic installation with none of the options selected. I'll try the with the other options asap.


Yes, but not the last time the other client synced.  Which is, I think, more valuable.  It's less useful to know the tabs are 1 day old (even though the device synced a second ago) than to know the device synced a second ago.


This doesn't handle user "None"


Why are you making up a console_log function!?!?!


那個註解其實可以拿掉啦XDDDD


Probably want to initialize this arr outside of the while loop so it doesn't get reset on each iteration.


This is wrong.


Removed unused line


I'm not this far yet, but the variable here seems somewhat confusing.


@bwilk can you explain why this spec is version specific?


Very clear easy to read and understand.


Hi Guys @yorikvanhavre @dimven

Feel free to edit/modify/etc. this document as we go.

Thanks.


This could be an 'else' instead of 'elsif' because initially you say if index > 0 so else implies index <= 0.


I have a few comments, other than that it looks great! Consider yourself an expert in Ansible!


Второй класс с модификатором


Nice! I think this is much easier to read.


This is a lil confusing to me.. would (num > @ size) work maybe?
I feel that double negatives should be avoided when possible.


I'm assuming @size is getting changed her too somewhere.


this line looks as if it is now redundant...


add message to your Arguement Error "next item cannot equal itself"


sannkusu!!!


Stop trying to console.log! So Javascript.


@smarnach if I'm not mistaking it does basically the same as abstract class in Java/C++, with necessary alterations to reflect python's absense of compilation step - it raises errors when some methods markeds as abstract are not implemented in child classes *at runtime*. Also, again, some IDEs and linters provide warnings/suggestions to implement missing methods.

AS of Zope - it looks like it achieves roughly the same goal, but `abc` is a built-in, while Zope is not. I'm not that familiar with Zope to outline if there are any differences (probably yes) :)


I like that your errors have helpful messages, this is something I have to remember to include in my code while refactoring. :+1:


nil.to_s seems superfluous unless you've redefined nil to be a custom class(?) which seems unlikely.


Err, and it is included! sorry.


This seems to store the LTI parameters for the current request to the DB, overwriting whatever has been there before, right?  How does this mesh with multiple concurrent requests?


Great that you made a change in the other file to your advantage. I definitely implement this in my own code.


You'll get to this in later tests, but you should be comparing the object id's instead of just the whole objects.


Nice looking method, clear and concise.


@kenjones-cisco thank you!

I wonder if this is too large of a default for resource nodes:
```
os_flavor_ram: 16384
os_flavor_include: XLarge
```

@stevendborrelli thoughts?


Why are we setting size to zero and THEN checking if the *new_li is empty?


I like the thought process of the test you are going to write.


This is exactly what I mean:
```
; Define required attributes
core = 7.x
api = 2

; Define required modules
;
; To define a specific module version (eg ctools 1.4) and place it in a
; specific directory use the following notation:
;   projects[ctools][version] = 1.4
;   projects[ctools][subdir] = contrib
;
; Versions can be:
;   - 1.4 for a module with 1.4 version number
;   - 2.0-beta3 for a beta release
;   - 1.x-dev for a development version (be careful as it results in different code each time
;     it runs)
;
; Add patches with the following:
;   projects[ctools][patch][1023606] = "http://drupal.org/files/issues/1023606-qid-to-name-6.patch"

; Contrib modules
projects[ctools][version] = 1.7
projects[date][version] = 2.8
projects[diff][version] = 3.2
projects[entity][version] = 1.6
projects[entityreference][version] = 1.1
projects[features][version] = 2.5
projects[field_group][version] = 1.4
projects[field_validation][version] = 2.4
projects[filefield_sources][version] = 1.9
projects[libraries][version] = 2.2
projects[link][version] = 1.3
projects[migrate][version] = 2.7
projects[pathauto][version] = 1.2
projects[restws][version] = 2.3
projects[shs][version] = 1.6
; Adds a check when updating parent terms. shs does not give warning any more when terms are updated.
projects[shs][patch][1960182] = "http://www.drupal.org/files/issues/checkifparentset-1960182-08-D7.patch"
projects[strongarm][version] = 2.0
projects[taxonomy_access_fix][version] = 2.1
projects[token][version] = 1.6
projects[transliteration][version] = 3.2
projects[view_unpublished][version] = 1.2
projects[views][version] = 3.10

; Contrib modules with non-stable releases
projects[better_formats][version] = 1.0-beta1
projects[cer][version] = 3.0-alpha7
projects[master][version] = 2.0-beta4
projects[paragraphs][version] = 1.0-beta6
projects[table_element][version] = 1.0-beta1
projects[varnish][version] = 1.0-beta3
; The module gave undefined notices after installation in theme_varnish_status().
projects[varnish][patch][2371907] = "http://www.drupal.org/files/issues/varnish-2371907-24.patch"
projects[views_data_export][version] = 3.0-beta8

; Defaults
defaults[projects][subdir] = contrib
```

Note the following:
1) The comment explaining the reason for the patch is next to the patch itself (whether it is before of after I do not mind).
2) We should not include our ticketing references in the *Open Event* make files.
3) I have corrected a couple of spelling mistakes: careful, any more.


Good note on future studies.


While this works, this reads more like a javascript approach trying to use Ruby.  I think if you were able to boil your boolean logic down, you can probably cut your elsif statements in half. I can't say I would have done it differently though right out of the box.


I like using the size instance variable to drive the to_s method. You could probably make some minor refactors to lines 46-50 that would make the first two conditional scenarios unnecessary.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1135 of 1135 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This reads fine but I think we can make it more Ruby by doing
unless @last_item.nil?
  @last_item.payload
end


If @size === 0 is self.payload implicitly nil? Could this conditional be removed?


Just an example, changing to something else is easy enough. Just wanted to differentiate between control and resource.


Good use of string interpolation.


This is the ProhibitNewMethod policy. The presence or absence of make_immutable isn't relevant to the example code.


Thanks for the PR! Before I merge, could you update the commit message format to follow the same convention than the existing ones?


:+1:  .cover is cool.


Yeah, datetime parsing hasn't been touched for a very long time.

-Clayton

On Fri, Apr 17, 2015 at 3:53 PM, Cory Zue <notifications@github.com> wrote:

> cool. and just being super paranoid here, but confirming that we expect
> microseconds to work on ~all old versions in the wild too
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dimagi/commcare-hq/commit/a28dfd6aefd8acfd9d5bbc7f2caba0cd52390c93#commitcomment-10783019>
> .
>


nice - this is clever & easy to read :+1:


This we'll want to turn into a `struct` with the allowed fields from the SchedulerHints schema.


:payload will need to be an attr_accessor as you will ultimately need to assign values to payload, which you can't do with an attr_reader.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1135 of 1135 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good note of the change.


'or' instead of '||' is more idiomatic. :+1:


Apparently for our "Constitutions" she wants us to have a bracket setter method that doesn't directly alter the payload.

Think similar to how delete is re-referencing two nodes ahead of itself. :smile:


Where is this formatting file?


Do we really need this?


@smarnach no, it's an instance. Why would you expect this? Essentially it's a property dependency injection corrected for the fact Django initializes views internally.


What's this???


Add Error message "Item doesn't exist at given index"


I don't understand this addition - it doesn't seem like to_s would ever take an argument, but I'll keep an eye out for how you use this in later commits.


@smarnach this is an outdated commit, it is changed already


It seems that the [av_seek_frame](https://www.ffmpeg.org/doxygen/2.5/group__lavf__decoding.html#gaa23f7619d8d4ea0857065d9979c75ac8) method allows to select the stream on which the seek is done. But the problem still remain, because the _AVFormatContext_ is the same for each stream.
Maybe the best solution is to create a new handler on each _InputFile_ with a different offset into the [Transcoder::addInputFile()](https://github.com/mikrosimage/avTranscoder/blob/develop/src/AvTranscoder/transcoder/Transcoder.cpp#L354) method.


I don't think completely disabling the origin check is a good idea


How about letting the user subclass this class and override authentication_manager?  With the approach in this function, authentication_manager unnecessarily becomes a global variable.  Letting the user override this in a subclass would be the usual Django approach.


It wasn't stable, freezes or black screens or something else. Can't remember properly.
But if madshi says we should use it, let's forward any problems to him.
And I know I'm fast :p


Why are you using .new on IndexError?? I wonder what that is doing different than just using IndexError, "Some message".


@vtjnash, did you investigate whether there was anything nefarious about this change in checksum? In general, if you're going to change the checksum for some external resource, it warrants its own commit and a comment on why the checksum changed. If you do this blindly, then it allows hacked versions of dependencies to sneak in.


nvm, didn't realize this is in the example :)


classy. I like the refactor. This is much more concise, and it's also a bit easier to read.


test comment


It'll also need a `ToServerSchedulerHintsMap` method to go from `struct` to `map[string]interface{}`.


Shouldn't this be closed in a `finally` block?


test comment 2


не заметил


What is oldValue? I don't see it being used elsewhere in the method


We'll want this field to be a type `SchedulerHintsBuilder`. To satisfy `SchedulerHintsBuilder`, a type only has to have a `ToServerSchedulerHintsMap` method.


great while loop easy to following what is going on.


the to_s function refactor is very crisp. And very Ruby.


Simple & concise. Nice!


I added https://rt.cpan.org/Ticket/Display.html?id=103837 to track this bug.


If using error messages consider making them more relevant to the user. It doesn't matter for this exercise but reinforcing the habit could help long term.


Why not `__opts__.get('aptpkg.use_aptfast', False)`?


This line should be also into the if


:heart:


could be unconditional because gorilla already handles the `nil` case


I think you can completely remove the elsif part and get the same end result.


You might be able to leverage your get method for this bracket accessor method instead of writing it from scratch.


General spacing could be improved for clarity.


@string is not an attribute of a LinkedList.


Good use of more specific variable names. X & Y were tough to understand.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I'm guessing this is the refactor where you deleted a 100 lines of code and your tests still ran correctly. :100:


Yep.


Does this need to be closed if it is in the `try` block?


@yorikvanhavre Hmm... the 'L' shade came in uneditable.

https://www.youtube.com/watch?v=emaAo_ty_Ow&feature=youtu.be


good job. this is a really straightforward implementation, and it's easy to understand.


You shouldn't need this else statement as @next_item already equals next_item. Just a suggestion for the sake of being concise.


Seems like a lot of nested if's. Could this be refactored to loop through the list based on how many items are indexed (i.e. index.times do) as opposed to using a counter?


not sure how i feel about chop.chop. Seems like there should be something cleaner.


This logic would be something like:
```go
if opts.SchedulerHints != nil {
    sh, err := opts.SchedulerHints.ToServerSchedulerHintsMap()
    if err != nil {
        return nil, err
    }
    base["os:scheduler_hints"] = sh
}
```


You delay for 1s intervalls and feed the watchdog first after the first 1s interval.
I think: If the watchdog got hungry enough BEFORE the first 1s delay it may bite you WHILE in the first 1s delay.
The 2s I referenced are wrong, you can't estimate how much time was used since the last feed of the watchdog before calling the delay.
Goal is to get through the delay without getting bidden. So we should feed the dog before taking a sleep. ;-)


commit test comment 1


This is awesome and really clean.


commit test in line comment


I did not know you could use "times" like this. Incredible. So this covers multiple iterations that would otherwise make your code messy.


Heavily commented. Try and keep out of commits.


Maybe change "nexting" to something else. Understand what it is doing but there maybe a better name to call it.


We could, I have to wonder if the performance disadvantage of parsing the layers 2x is worth the additional complexity of adding a new method for background layers.  Then what happens if we want to add foreground layers...

It is a good point and I have yet to decide which way to go on this one.


@ddanny the joys of having a bunch of people working on the same branch :)


@AdrieanKhisbe is this required for the plugin to work properly? Should this be on master?


Steven, any progress on this over the weekend?

On Fri, Apr 17, 2015 at 10:28 PM, Steven Jennison <notifications@github.com>
wrote:

> We're almost done zipping it up, should have a link shortly once it
> uploads. Zip compression is a very good thing...
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/qzind/qz-print/commit/165cdb9fdb8e55d5bbb92fae1edaee2f49edb5fc#commitcomment-10786654>
> .
>

--
Robert Casto
*Owner | SellersToolbox*
p: 1-513-847-4942
c: 1-513-886-1550
e: casto.robert@gmail.com
www.sellerstoolbox.com
Tools for Amazon Sellers


Great spacing and clarity.


This code is so Ruby... :100: %


are parenthesis needed here?


You can provide additional keyword parameters that Django passes on to every view by passing them to `.as_view()`.  That would also be an option in this case.


Molly,

"+      current_node.next_item = current_node.next_item.next_item" is a very creative construction.

What happens at the end of the linked list?

David

> On Apr 20, 2015, at 10:44 AM, Molly <notifications@github.com> wrote:
>
> You shouldn't need this else statement as @next_item already equals next_item. Just a suggestion for the sake of being concise.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/pjprogrammer1953/linked_list_cohort_huckleberry/commit/c5c7b957eeffd58a20174e9eb7797d3b80bef163#commitcomment-10806114>.
>


Code looks good to me. I would recommend a few more commits through time though.


"+      current_node.next_item = current_node.next_item.next_item" is a very creative construction. What happens at the end of the linked list?


could you us || and combine your logic from the 11 and 14 blocks?


Great if else very short and clear.


Comments for marking up specific lines and their effectiveness are really nice.


I am also prone to wanting to keep options in my code for reference, however I would choose the method that makes the most sense to you and delete the rest of the code.


Spacing makes code harder to read. Maybe make sure you are setting tabs to spacing tabs in editor?


You should consider two changes here. I think using
```
@first_item = @first_item.next_item
```
might be clearer than using current_node.
Also, I think you probably only want to execute this block if index is equal to 0. If a negative index is passed in, that should probably raise an error, right?


Why are you tracking @last_item_index as an attribute of a LinkedList. Make it a local variable instead.


for readability you could use Ruby's `zero?` method here


Your code is very easy to read, especially in terms of white space.   You've obviously refactored carefully to make the code as dry/concise as possible.  Still not sure about that "human list" variable, but (as I said before) I haven't gotten to that step yet.


@moollaza ok nevermind, I managed to find a solution (see my latest commit). The template looks a bit messier, but it'll adjust for either 2 or 3 lines depending on whether the `starttime` parameter exists or not. (If you search for `church` starttime seems to be blank, but if you search for `service`, it'll return a time... kind of weird API behaviour to account for.


@CraigCasey This loop seems out of place. Should it really be inside the outer loop?


Yeah, I knew that was a mess.  It gets better later.


More like gotta NOT gu fest


That takes places during the Refactoring Phase.  :-)

> On Apr 20, 2015, at 10:47 AM, Molly <notifications@github.com> wrote:
>
> I am also prone to wanting to keep options in my code for reference, however I would choose the method that makes the most sense to you and delete the rest of the code.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/pjprogrammer1953/linked_list_cohort_huckleberry/commit/c5c7b957eeffd58a20174e9eb7797d3b80bef163#commitcomment-10806191>.
>


I believe your attr_reader is taking care of this initialize for you. Could choose to omit.


nit: I'd use the sentence: "Developers using this mock should follow these rules:"


Missing Files/Folders. Problem fixed after quick discussion.


Is this being named nodeToDelete for semantic purposes? I don't see 'nodeToDelete' used elsewhere


Needs a space after the equal sign on line 63.


A general comment: Thanks for having very informative commit messages.  They were very helpful and were great learning examples for me.


You could use ruby's .equal method to improve readability.
http://stackoverflow.com/questions/7156955/whats-the-difference-between-equal-eql-and


Okay, perfect!  I was running into that exact problem with ending the macro.


Good work.


This is interesting. Seems clear, I guess I'd keep it if it works.


I like that this checks on size rather than requiring another method to iterate through items, assuming that is actually the faster method. Seems like it would be faster.


Исправлено 7832d0cc37b6fdd6ddbb521e7320ef3f970e7472


just wondering if the comment should not be closer to the actual cloneInto call?


be consistent with naming things. should be next_item.


This section of code is not part of the linked list project. Perhaps it ended up in here accidentally? I would recommend deleting to avoid confusion. This is a great reason to use git add -p when making a commit, as you always have to review what you are pushing to github and can avoid accidentally pushing something you didn't mean to. :smile:


Hello,

I'm practicing using branching.


Molly,

I have completed my review of your work.

You write nice code.

Shoup

> On Apr 20, 2015, at 10:49 AM, Molly <notifications@github.com> wrote:
>
> I believe your attr_reader is taking care of this initialize for you. Could choose to omit.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/pjprogrammer1953/linked_list_cohort_huckleberry/commit/c5c7b957eeffd58a20174e9eb7797d3b80bef163#commitcomment-10806233>.
>


might want to include negative indexes here. Adding an error message would be icing on the cake
```
raise IndexError if @first_item.nil? || index < 0
````


too many steps here. Combine the two lines:
```@first_item = LinkedListItem.new(arg)```


Yes! Finfint! Jag tar och lägger ut detta NuGet direkt.


Исправлено во всех файлах в 0ad12130634db368f8ff97c0d8a689930cc214fe, 520110bdce5e7bd214e74b87f66d8238b93844f5, 7832d0cc37b6fdd6ddbb521e7320ef3f970e7472


Really like the use of this while loop...maybe able to refactor a little bit but can clearly understand how it is be used.


@yorikvanhavre sweet! polycarbonate panel was editable.


be consistent with naming. should be @last_item


Implemented #5


We should be using smart pointers - here, `unique_ptr` - to manage the memory.


Исправлено во всех файлах в 0ad12130634db368f8ff97c0d8a689930cc214fe, 520110bdce5e7bd214e74b87f66d8238b93844f5


wasn't really ready for review :) Had updated locally to fix that. Still working on this...


Leftover debug info?


OK, this is readable enough now :) you didn't like my goto-like label-based solution :p


awesome!


But likely I just missed MainFrame messages (did only ChildView) and it messed up some madvr indernal logic or direct3d. Your commit should work ok, probably.


rax retry tests


@fpapadopou if you could take a look here I would appreciate it.

Kyle and I worked on this during lab today, And the answer we came up with was that we may have to create a new Silex/WebTestCase  that instead of using the \PHPUnit_Framework_TestCase it uses PHPUnit_Extensions_Selenium2TestCase. The defaule Silex library does not offer anything, and the alternative would be to rely on bhat for unit test as well as functional test.

If there is an easier option or something I am missing please let me know.


next_item is an attribute of a Linked List Item, not a Linked List.


Fair enough.  Was just trying to help since it showed up in my GitHub feed. :smile:


Yep, this looks much better, except you need to put everything in gui/ and remove the widget from machine/


yes, this work with python 2 too :-)
I have no reason to use dict instead of {}, but a think is more readable.


I think an unless statement here would read nicer.
unless 0..@size.include?(index)


Looks good. You could stash your commented out code in a branch to clean up master. Also watch the whitespace on lines 101 - 103 and maybe the spacing of the += on line 54. These are all pretty small things though, so I wouldn't worry about it too much. Good work!


Sweet thanks man!


I blame it on eclipse, it merged nothing !


I see that there seems to be no way to complete the delete function without being long-winded. One side-effect of Linked Lists.


Interesting! My shapes were all exported as IfcFacetedBreps, but Revit was able to "deduce" the extrusion of some objects. This is apparently what determines if an object is editable or not. This is tremendously useful, since until IfcOpenShell implements it, we'll be stuck with IfcFacetedBreps each time we do a roundtrip.

We really need to find out what makes Revit "find" the extrusion or not. Maybe the problem is the concave shape?


It would be nice for you to remove illegal content


What is (puts "two") doing here?


is there a preference among Ruby developers in writing 'n.times {stuff here}' vs. 'n.times do....stuff here.....end'?  Just curious.


@Shauren  ^^ I really appreciate your work my friend, keep going.


Since both if statements nested under ```until node.last?``` are returning false, could you join them with  ```or```?


微信公众号


if you do a last pass refactor on this project, you can consolidate these:
```
attr_accessor :size, :last, :payload
```


```feature
And I should see "Your email address has not yet been verified."
And I should see "Re-send verification email »" in the "a"
```


you could use a map using c++11 initializer lists.


:D Yeah, I was just scared by big red warning at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/label and didn't want to be the first in SMS app who uses labels :)


Where `"a"` is a CSS-selector


@richrd I just run pyflakes via the SublimePythonIDE plugin in st3. I've actually got quite a few more changes locally that Id like to upstream but they involve some semantic changes/re-organization. If you're interested we could touch base on FreeNode or something to discuss? Love the project so far :+1:


Okay, sounds better, thanks!


Line 26 and 27 are redundant. If you want to see the output you can just write "put current_node.payload" on line 26 and omit 27 altogether.


Okay then my concave theory is invalidated :) Anyway, indeed removing curved segments helps a lot...


fix build


Like this method very easy to understand and see what you did!


are you sure? linearProjectileTimeStamp is used for physics


please merge!


#winning


:+1: from @benfalk


I thought the command should be called from machines? Do I simply combine the console module in machines and the one in gui into one module?


J'ai updaté ma remarque


excellent get method


Yes, I checked the code, it's relative to game.serverTime. And if you fire a rocket, call a timeout and alt+tab, with `msec`, the rocket will fly forward a little bit, but with `serverTimeDelta` it will stay in place.


It's actually `thread_unmask_exceptions()` that's supposed to undo what `thread_mask_exceptions()` has done.

But when I look at it like this it looks just as natural. I'm OK with restoring exception state with `thread_set_exceptions()`, but we need to update documentation of the functions and remove `thread_unmask_exceptions()`


Thanks!


This conditional to deal with the last comma is really good.


It would be nice to remove this illegal content


if you've defined that @first_item = new_item, then on line 39 you would probably want to say that @last_item = @first_item.


When/if people implement KB on postgres, the assertion will fail. Other than that :+1:


Suivant la remarque de la ligne 192, ici on devrait utilisé ce vecteur "labeled" plutot que trainingSet car il fautdrait prendre en compte l'ajout de nouveau vecteurs à la class.


This need to be `(vaddr_t)` or we'll get a warning on ARM64.


The default content relies on many of the older versions, see: https://github.com/kaltura/server/blob/Jupiter-10.10.0/deployment/base/scripts/init_data/03.uiConf.ini


:cat: Ici je voulais juste mettre un chat.


@vlmaksime скачал ветку https://github.com/vlmaksime/TorrentMonitor/tree/master залил в тестовую клетку, но при попытке зайти в веб-морду выпадает просто белая страница :(
при запуске из консоли:
```
root@test:/usr/local/www/data # php index.php
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
  <meta charset="utf-8">
  <title>Мониторинг torrent трекеров</title>
  <meta name="description" content="">
  <meta name="keywords" content="">
  <meta name="viewport" content="width=1000">
  <link rel="stylesheet" href="templates/default/css/styles.css">
  <link rel="stylesheet" href="templates/default/css/ohsnap.css">
  <link rel="icon" type="image/png" href="templates/default/img/favicon.png" />

  <!--[if lt IE 9]><script src="js/html5shiv.min.js"></script><![endif]-->
  <script type="text/javascript" src="js/jquery.min.js"></script>
  <script type="text/javascript" src="js/jquery-ui.min.js"></script>
  <script type="text/javascript" src="js/user-func.js"></script>
  <script type="text/javascript" src="js/ohsnap.js"></script>
  <script language="javascript" type="text/javascript">
  window.onload = function(){
      showIndexContent();
  }
  </script>
</head>

<body>
  <div id="ohsnap"></div>

  <div id="index_content"></div>

</body>
</html>
``` т.е. косяк где-то в яве..


@wluyima did you just forget to add the license header to this file?


:beer: et là une bière. Important !


:+1:  match(str)


@andresgutierrez
Oh, it my fail.
Thanks!


I like how you assigned a new item to a clear variable name ```lli```. Helps make sense of what is happening to the item in the method's code


Yay for less code!

Out of curiosity: what is this line for? According to `:h signs`, `:sign place` should not be called twice with the same `sign_id`.


Maybe here you could hook into the same place as [check_font_version](https://github.com/gregorio-project/gregorio/blob/develop/tex/gregoriotex.tex#L1210), and you wouldn't have to open the ttf font, you could just access the lua tables of the font, I think it would be a better design... What do you think?


The widget can call send_command itself.
There should be no mention of widgets in machines/
And everything about widgets should be in gui/

So in short : yes, combine them :)

On Mon, Apr 20, 2015 at 5:59 PM, quillford <notifications@github.com> wrote:

> I thought the command should be called from machines? Do I simply combine
> the console module in machines and the one in gui into one module?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/quillford/Mousse/commit/a2139abc75db9671af8b5bd9bc6f011c3b36d2b2#commitcomment-10806509>
> .
>

--
Courage et bonne humeur.


need*


Will check and ensure its updated. Thanks.

May the source be with you,

Jess Portnoy

-------- Original message --------
From: David Bezemer <notifications@github.com>
Date:
To: kaltura/platform-install-packages <platform-install-packages@noreply.github.com>
Subject: Re: [platform-install-packages] KCW - only bundle latest, no need for 10 older versions. (f932cce)

The default content relies on many of the older versions, see: https://github.com/kaltura/server/blob/Jupiter-10.10.0/deployment/base/scripts/init_data/03.uiConf.ini

-
Reply to this email directly or view it on GitHub<https://github.com/kaltura/platform-install-packages/commit/f932cce731093031e6fac178f2d6fc0bb3f93b94#commitcomment-10806565>.


I think it's important to keep the `File::Spec->join($self->outdir, $suffix)` part.  Otherwise, this will try to remove files in the current working directory instead of the `outdir`.


不在主线程做 shutdownClose() 这样是不是会有问题？


The :cake: is a lie.


This appears to have broken Forge Jenkins. All of the installers built since this change are missing the installer jar...


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1135 of 1135 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


why do we need to define PATH here?


See isValidDockerVersion in pkg/kubelet/kubelet


ping @snoyberg


Why is this normalisation wrong? The function is correct.
There is no norm in data object. https://docs.python.org/2/reference/datamodel.html
What I have written is to override the builtins. If you have a norm function, add it to the file. Define it as norm(self) and not __norm__(self).


Seems like this could loop endlessly if the strings don't match.


@jasondegraw Yes.  It should be.  Line 57 is a function that produces the simulation case for each window group.  Line 63 is saying that if the simulation case is greater than 0, in which case it contains bsdfs in some settings or all settings, make BSDFs true.  The only thing I don't know, is why this is still here when "BSDFs" is never used again within this scope.  I will check and get back to you.


Exactly you are true and also please correct the name from PoundMassPerCubicInchs to PoundPerCubicInchs and units conversion is true


I like my approach better - any objections?


Hm. What would the `our` be good for?
The installprefix is stored in `$bmwqemu::scriptdir` so `$installprefix` is only locally, in this file.  I found the `our` confusing, that's why I changed it.  I also looked up `my` vs `our`, for the fun of learning about it.  To my understanding, both create a lexically scoped name.  `our` links the name to a package global variable of the same name.  So `our $installprefix` creates a `$main::installprefix`.  That is never used again.  `my` creates a variable right here and binds the name to it.  So unless the variable is stored in some other place .oO( like `$bmwqemu::scriptdir` ), it will be lost when the variable goes out of scope.

I'd like to do this change.


tested with my package and it works


@schalkneethling thanks for tips! Seems to work.

Having an odd issue now. I don't get any errors showing the success button message, but I don't actually see the new message on the screen (and the submit button hiding) until I resize my browser window. Happens in both Fx and Chrome.

Investigating here, but wondering if you had any quick ideas.

Thanks


true. good call.


:+1: for readable
Note: I don't think you have to write ```return``` in Ruby unless you are explicitly trying to return something


qwfdqw
@qwerqw
#www


It's arm/pager now. :-)
We have linear mapping so what's physical and virtual can be confusing, here we're working with virtual addresses.


Uhoh
Did I just mess up upload? D:


I think it would be better to specify the full name of the class or check for the existence of such a class, example:
```
if !class_exists(adapter) {
   let adapter = "\\Phalcon\\Session\\Adapter\\" . adapter;
}
```


Exactly you are true and correct This Please


:tada: :birthday: :boom:


You included the secret keys in the commit... I hope these keys don't have very many permissions


I really appreciate you for you pointing out alternatives to detailed aspects of my code. I don't speak Ruby as a first language, so I find that helpful.

This comment, however, sounds like something you'd say to a child while patting its head, in spite of your good intentions. I don't want to assume intent to condescend to me, but that is how I reacted when I first read it, and even after taking a break and coming back to it. I know that's not your intention, and you want to encourage people, so please consider this feedback on just that one comment. Do with it whatever makes you happy. It's not safe to assume that everyone on this challenge is a rank beginner in all things.


I don't see the show view.  Did you commit and push it?


Why :( Board generator contains logic which belongs exactly to this class


a little trick that tells ruby that [] is the same as the get method


Thanks @Bo98


Fix the fields!


Yes I'm agree and also it's unit is "kip/in³"


Missing pspec.


This was a workaround for a bug in parsedown, i'll test locally first.


good


Need to be using pkgconfig deps - and disable static


definitely!


thanks!


@yorikvanhavre i wonder if this will help?...
https://www.youtube.com/watch?v=GtIhaoutj-g&feature=youtu.be


Yes Your True and I'm Agree


What's wrong with making this methods static?


Ok I guess putting the tag between backticks gets around the extra |


you might consider adding conditions to check whether the index is a fixnum and raising an error if it is not


@jacobdlewis that was code that shouldn't have been pushed. Thanks for the heads up.


Thanks for taking a look at this! I vote in favor of keeping the ciphersuites as-is.


Correct cache
https://docs.oracle.com/javase/7/docs/api/java/util/Map.html#put(K,%20V)


Good job !


@jacobdlewis Good point.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14007/testReport/) for this commit**


@kellyrob99 https://github.com/senchalabs/jsduck/wiki/@cfg

```
@cfg {String} format
```


@Upitep проверь права на директорию /usr/local/www/data, что бы вебсервер мог писать туда, имхо директории cache у тебя нету.


Hello Carter!

We removed the dependency since the cagt is going to be transformed into
a template rather than a inheritable component.

Regards,
Stefan

On 20/04/201517 17:50, Hamilton Carter wrote:
>
> Why was the dependency to cagt removed? There's code duplicated
> between cagt and this repository now. Was it simply to work around
> engineers having to track through the abstraction layers? Is there
> another benefit?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/amiq-consulting/amiq_apb/commit/9b8a36fbc41374d5daa353d3d5df1b52b304ad8c#commitcomment-10804724>.
>

--
--------
-- Stefan Birman
-- Verification Services Manager
-- +40 723 508 613
-- office@amiq.com
-- www.amiq.com/consulting
--------


no wey eso no


Last parameter should be on next line


Same


This modification has changed the original behaviour. Originally it got the next image and only assigned it if it fitted into the width & height. This will now return an image that is one size too big. Downscaling images may introduce artifacts into the resized image so it's better to only upscale an image.


Thanks!  One minor thing, it could be made more consistent with the other ports by using this definition style in lpc17xx/type.h:
https://github.com/elua/elua/blob/master/src/platform/stm32f4/type.h


Wrap last


Resolves #17


Hi, I work for Server Density.

In our agent installer -t is used for the API token, and -k is used for the agent key. You only need one or the other. It looks like this change is incorrect so you may want to review this again.

What seems to be the problem?


Spurious change?


Тут, имхо, надо все-таки все куски числа [элементы массива] проверять на то, равны ли они нулю. Если все они нулевые, то и число ноль. А по последнему элементу может ложный результат давать


File renamed without changes


What do you reckon to keeping a reference to the image and only refetching on resizes? Would there be any memory issues to keeping the reference?
Not reloading would reduce the intensity of the redraws.


Because of the way fast forward merges work, it's not really clear what I've done (because we didn't follow proper git flow ;) )

I merged develop into the release branch (v1.0). I then merged the release branch to master and tagged as 1.0. I then merged the release branch back to develop (as you should when using git flow), and then deleted the release branch.

Normally this creates a clear graph that shows what's happened, but because we needed things from develop in the release branch after it had already been created, it was easier, just this time, to merge rather than cherry pick.

We shall know for next time!


@psvmcc как ни странно, есть)) даже спецом chmod -R 777 сделал:
```
root@test:/usr/local/www/data # ll
total 161
-rwxrwxrwx  1 www  www     40 Apr 20 19:48 .htaccess*
-rwxrwxrwx  1 www  www  15199 Apr 20 19:54 action.php*
drwxrwxrwx  2 www  www      3 Apr 20 19:51 cache/
-rwxrwxrwx  1 www  www  19505 Apr 20 19:48 changelog.txt*
drwxrwxrwx  2 www  www     13 Apr 20 19:48 class/
-rwxrwxrwx  1 www  www   1111 Apr 20 19:51 config.php*
drwxrwxrwx  2 www  www      6 Apr 20 19:50 db_schema/
-rwxrwxrwx  1 www  www   5822 Apr 20 19:48 engine.php*
drwxrwxrwx  2 www  www     19 Apr 20 19:48 img/
drwxrwxrwx  2 www  www     14 Apr 20 19:48 include/
-rwxrwxrwx  1 www  www    404 Apr 20 19:48 index.php*
drwxrwxrwx  2 www  www      7 Apr 20 19:48 js/
drwxrwxrwx  2 www  www      5 Apr 20 19:48 notifiers/
-rwxrwxrwx  1 www  www   7080 Apr 20 19:48 readme.md*
drwxrwxrwx  2 www  www      3 Apr 20 19:48 rss/
drwxrwxrwx  3 www  www      3 Apr 20 19:48 templates/
drwxrwxrwx  2 www  www      3 Apr 20 19:48 torrents/
drwxrwxrwx  2 www  www     22 Apr 20 19:48 trackers/
```
Хотя, при апгрейде на версию 1.2.1 (или какая там?) когда еще шаблоны были в репозитории Евгения - все работало как часы.


I have a far shorter version here, rather than hardcoding all the groups: https://github.com/kotarou3/Pokemon-Showdown-Addons/blob/master/authlist.js


Could be reduced to :
if (!scanContext.reattemptFailedDeployments.add(deploymentName)) {
 continue;
}
ROOT_LOGGER.reattemptingFailedDeployment(deploymentName);


Also, when I proposed adding this command to Zarel a while ago, he said main server didn't have a need for it because http://logs.psim.us:8080/auth.php


O.k. It's Not Bad But These Are not famous units like Ton and i think use of them is very low and aren't widely people use, But if There is any request we can Add them and Tell me to Correct it's JSON file


Hi @rsmarshall, I work for Server Density.

In our agent installer -t is used for the API token, and -k is used for the agent key. You only need one or the other. It looks like this change is incorrect so you may want to review this again.

See https://github.com/serverdensity/sd-agent/blob/master/install.sh#L123

What seems to be the problem?


Thanks! I was sure that it returns value which we put.


No, Sorry It was My Fault And We Should Clean This


Ah in that case I am just being a bit thick and using the wrong key it seems.


Your version is just 7 lines shorter, that's not "far" :p And I did hardcode the groups in purpose.
Jasmine asked for this so any server updating commands or merging with master, especially new ones being cloned, show all the auth to keep track of specific banned people to not to register the servers.


No problem :) if you need help email hello@serverdensity.com and we can give a hand.


... I *think* you meant to write ''to the maximum "digit" being used in the `base` field'' ?  Or just ''in use'' ... but ''in the use'' does not make sense to me.


Fixes #8.   La descripción indica incorrectamente que arregla el asunto 7, pero en realidad es el 8.


depending on the url it comes from, github either embeds the branch name or the sha1 hash into the toplevel folder of the path. that affects the sha1 hash of the file, but did not affect the content.


hello


Redundant else


Yes It Should be Correct


`value` should be `ByteCodeExpression`


Yes This IS My Fault And Also THis Part Should Eliminate Or Delete


Static import


Keynote icon is not following design spec.
Removing subscribe now link makes sponsors go too close of ticket prices


le fichier _test.scm_ a été oublié!


The if statements above are setting the values depending on which conditions are met


ahah :) I disagree with the warning, I think using a label was more readable than your previous solution :) (but the new solution is good too :p)


placer ces commentaires dans la documentation!


Either would make sense, yes.


This was the wrong fix: accented names _should_ be allowed, so the correct approach is to fix this in the underlying code, and revert the fix here.


Is the convention for variable names to keep them as whole words? Btw if you leave some comments on the commits I'd be happy to discuss the reasoning / make any required changes in a resubmission.


Yes This IS My Fault And Also This Part Should Eliminate Or Delete


Also the command is better for the regular user in main as well anyway, more convenient.


Excellent And I'm Agree


_foment_ ne supporte pas le symbole non défini dès le chargement du fichier, d'où le _cond-expand_.


What is this doing?


We should filter multiple slashes, so that `/room/foo/bar` is the same as `/room////foo//////bar`.


Yup. :+1: this was changed in a later commit


A user might not want to add a symlink into the /usr/bin folder, a more proper location for this kind of tool is /usr/local/bin IMO


Yes You're True


This change broke Express Handlebars' semver dependency on Handlebars. See: https://github.com/ericf/express-handlebars/issues/125.

The ES6 default argument (`options = {}`) is not semantically the same as this falsy check that was removed. The default argument transpiles to:

```js
var options = arguments[1] === undefined ? {} : arguments[1];
```

Whereas this line which was removed supports `null`, `0`, `false`, etc. Express Handlebars defaults the compiler options to `null`, which then fails the `'data' in options` conditional below.


"apply"


Ok


Yes You're True, (I Didn't Know That How Bring Numbers Up Like You Typed in Top)


the `n` in ''`a + b*n + c*n^2 + ...`'' here does not represent `$n`, but instead represents the value `$ty::MAX + 1`, right?

You might consider using a different letter, since `n` is already connected to `$n`... but whether or not you choose a different letter (e.g. `W`), you probably should add ''... where W = `$ty::MAX` + 1.''


## This is a markdown


Why have two mechanisms?  Just want to understand the distinction.

> On Apr 20, 2015, at 12:06 PM, Andy Goldstein <notifications@github.com> wrote:
>
> I like my approach better - any objections?
>
> —
> Reply to this email directly or view it on GitHub.
>


Thanks! human_list refers to a human-readable list of items to be printed to the console. It's a method that ll.rb uses.


Caraca, não ouvi essa.


Ah, that makes sense.

On Mon, Apr 20, 2015 at 11:30 AM, Kyle McCormick <notifications@github.com>
wrote:

> Thanks! human_list refers to a human-readable list of items to be printed
> to the console. It's a method that ll.rb uses.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kylemcco/linked_list_cohort_huckleberry/commit/904c5fb90669d1c43d216d693377701b32af6936#commitcomment-10807109>
> .
>


A good point. `W` seems a reasonable choice throughout the bignum docs.


We wrote the code in go-dockerclient to add a strongly typed ApiVersion struct to allow parsing and version comparisons. Maybe we could update the Kubelet code to use that?


@fdutton - Just an FYI when you see things that are public that should be private/package-private, it could be because of mocking purposes in the tests.

This is another reason I agree completely with one of your earlier comments on why we need to think of a way to get the test sources out ASAP.


This will make it return -1 instead of 0. Also, AFAIK the EOF flag can be set if the demuxer reaches EOF, even if there's still queued unplayed data between player and demuxer. So I'm not sure if this is right at all?


About the context sensitive thing concern you raised: these `T_STRING` would become an `identifier` and on the scanner you will need to...


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (622 of 622 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.07%25-green.svg)


proposed fix for #238 and #96


@smarnach I'm afraid I can't see how this makes it global variable. It is shared between instances of `LTIView`s, but I don't think it could ever be a problem. Subclassing and overriding is possible as well, but subclassing is harder to test than injection.


The property needs to be added to MPV_EVENT_TICK as well, because it depends on the current playback time.


INFO - [Apr 21 00:28:41] 'https://autoproxy-gfwlist.googlecode.com/svn/trunk/gfwlist.txt' downloaded, try convert it with autoproxy2pac_lite
WARNING - [Apr 21 00:28:41] unsupport gfwlist regex: '^https?:\\/\\/[^\\/]+blogspot\\.(.*)'
WARNING - [Apr 21 00:28:41] unsupport gfwlist regex: '^https?:\\/\\/[^\\/]+google\\.(.*)'
WARNING - [Apr 21 00:28:41] unsupport gfwlist regex: '^http:\\/\\/[^\\/]+line\\.naver\\.jp'
ERROR - [Apr 21 00:28:41] update_pacfile failed: AttributeError("'NoneType' object has no attribute 'lstrip'",)
Traceback (most recent call last):
  File "proxy.py", line 934, in update_pacfile
  File "C:\ProgramFiles\goagent\packages.egg\win32\gevent\threadpool.py", line 225, in apply_e
AttributeError: 'NoneType' object has no attribute 'lstrip'


@djazayeri should we just clear the default patient name regex value? For i cannot think of a general name regex value that fits all implementations. That way, it will be up to each implementation to set their own value, if they need one.


use the `RETURN_TOKEN` macro:

```patch
-return T_ENUM;
+RETURN_TOKEN(T_ENUM);
```


"to see connect to"?


Can you move this software to another repo? I use this too.


Hehe


Collab with @kittenRainbow


enpoint -> endpoint, though this comment is a little redundant


I assume this has been tested.


It looks like this isn't used within the API – is it only needed as a dev dependency?


"Make sure to expose" is redundant. Consider: "10005 is the port that...."


What if there is a timestamp reset? Could it make an effort not to return completely crazy values in this case, but instead e.g. making the property unavailable?


Can you change the department to this as software engineer.


if we want to use `plone.api` consistently i'd change this to `api.portal.get()`


@sad-spirit Thanks, Alexey!


Also, why check for the time being negative?


const ref -> const val: fixed potential problem here. map.erase() doesn't expect that its argument might change.


no eol


Whoa... Did not know you could do this.


The PSM provider can support both  FI_MR_BASIC and FI_MR_SCALABLE, but the patch reduces it to the latter only, and the mode bit is not set in the domain_attr.


Eclipse automatic change; changed Object to Void afterward


Add a comment explaining this


good point - that's quite possibly now - we used to load some mixins from here, but those are now loaded from `web_components` and `polymer_interop`


This was a really smart way to handle this method. No need to reinvent the wheel. I'm stealing this implementation :)


You should rename this repo to "cheers", to make it clear what it is.


Static import


El test 'Uso de Multimetodos definidos en un modulo' no se realiza con exito. Estube viendo como solucionarlo, si se me ocurre alguna forma armo una rama aparte  y la comitteo ahi.


project


You might want to move these into .lang using StatCollector.translateToLocal


Not sure if this helps, but Bukkit plugins, usually had their configs stored inside a directory within the plugins directory.


第二个问题是，对于每个新建的Activity,如果线程泄漏了将永远无法回收。在Java中线程是垃圾回收机制的根源，也就是说，在运行系统中DVM虚拟机总会使硬件持有所有运行状态的进程的引用，结果导致运行状态的线程将永远不会被回收。基于这个原因，你必须为你的后台线程实现销毁逻辑（仅供参考，也许你翻的更合适些）


I think this can be removed in favor of the rizzo bottom-heading-border mixin (used above)


Debug Prints :tada: :tada: :tada:


@jacobdlewis LOL. You're welcome.


Upper-case letters were used in the .feature file for the words "conference" and "articles", hence a match will not happen.


I think you forgot to add:
* In init.qcom.rc, on post-fs-data:

`chown root system /sys/class/timed_output/vibrator/vtg_level`
`chown root system /sys/class/timed_output/vibrator/vtg_max`
`chown root system /sys/class/timed_output/vibrator/vtg_min`
`chmod 0644 /sys/class/timed_output/vibrator/vtg_level`
`chmod 0644 /sys/class/timed_output/vibrator/vtg_max`
`chmod 0644 /sys/class/timed_output/vibrator/vtg_min`

* In sepolicy/file_contexts:

`/sys/devices/virtual/timed_output/vibrator/vtg_level   u:object_r:vibeamp_sysfs:s0`

This last, I don't know if it's: `/sys/class/timed_output/vibrator/vtg_level   u:object_r:vibeamp_sysfs:s0` or the line I put above.


Whoops. Turns out text editors don't like it when you put unicode characters in a file that's declared to be ISO-8859-1 :(


il est beau ce makefile!


Needs reverting


The "See More" link looks a LOT like the button styles, minus the background. Wonder if we can reuse those and just have a modifier to remove the background and invert colors rather than this. Also, thought we weren't using rems anymore? :)


Oh, wait. These are just giving defaults to all of the parameters. That makes sense.