26:1: E402 module level import not at top of file
27:1: F401 'time' imported but unused
27:1: E402 module level import not at top of file
29:1: F401 'iteritems' imported but unused
29:1: E402 module level import not at top of file
31:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_ACCESS_CONTROL_LEVEL_GUESTS, CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_ACCESS_CONTROL_LIMIT_REGISTRATION_TO_DOMAIN, CFG_ACCESS_CONTROL_NOTIFY_ADMIN_ABOUT_NEW_ACCOUNTS, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_ACTIVATION, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_DELETION, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_NEW_ACCOUNT, CFG_SITE_ADMIN_EMAIL, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
31:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. import invenio.modules.access.control should be before import invenio.modules.access.engine
46:1: E402 module level import not at top of file
47:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before import invenio.modules.access.control
47:1: E402 module level import not at top of file
48:1: I101 Imported names are in the wrong order. Should be addadminbox, addcheckboxes, createhiddenform, tupletotable, tupletotable_onlyselected
48:1: E402 module level import not at top of file
49:9: E126 continuation line over-indented for hanging indent
50:1: E402 module level import not at top of file
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.modules.access.firerole
52:1: E402 module level import not at top of file
53:1: I101 Imported names are in the wrong order. Should be OperationalError, run_sql, wash_table_column_name
53:1: E402 module level import not at top of file
54:1: E402 module level import not at top of file
55:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, page_not_authorized
55:1: F401 'collect_user_info' imported but unused
55:1: E402 module level import not at top of file
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.legacy.webuser
56:1: E402 module level import not at top of file
58:1: F401 'wash_url_argument' imported but unused
58:1: E402 module level import not at top of file
59:1: I101 Imported names are in the wrong order. Should be CFG_ACC_EMPTY_ROLE_DEFINITION_SRC, CFG_EXTERNAL_AUTHENTICATION, CFG_EXTERNAL_AUTH_DEFAULT, DELEGATEADDUSERROLE, MAXPAGEUSERS, MAXSELECTUSERS, SUPERADMINROLE, WEBACCESSACTION
59:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils.url
59:1: E402 module level import not at top of file
64:1: I100 Imports statements are in the wrong order. from invenio.modules.access.errors should be before from invenio.modules.access.local_config
64:1: E402 module level import not at top of file
65:1: I100 Imports statements are in the wrong order. from cgi should be before from invenio.modules.access.errors
65:1: I201 Missing newline before sections or imports.
65:1: E402 module level import not at top of file
67:1: E302 expected 2 blank lines, found 1
67: D209 Multi-line docstring closing quotes should be on a separate line
83:13: E122 continuation line missing indentation or outdented
84:13: E122 continuation line missing indentation or outdented
87:13: E122 continuation line missing indentation or outdented
88:13: E122 continuation line missing indentation or outdented
91:13: E122 continuation line missing indentation or outdented
92:13: E122 continuation line missing indentation or outdented
95:13: E122 continuation line missing indentation or outdented
96:13: E122 continuation line missing indentation or outdented
99:13: E122 continuation line missing indentation or outdented
100:13: E122 continuation line missing indentation or outdented
103:13: E122 continuation line missing indentation or outdented
104:13: E122 continuation line missing indentation or outdented
107:13: E122 continuation line missing indentation or outdented
108:13: E122 continuation line missing indentation or outdented
111:13: E122 continuation line missing indentation or outdented
112:13: E122 continuation line missing indentation or outdented
122:27: E701 multiple statements on one line (colon)
131:1: E302 expected 2 blank lines, found 1
131: D202 No blank lines allowed after function docstring (found 1)
139:9: E128 continuation line under-indented for visual indent
141:1: E302 expected 2 blank lines, found 1
141: D210 No whitespaces allowed surrounding docstring text
141: None: None
141: D202 No blank lines allowed after function docstring (found 1)
150:22: E701 multiple statements on one line (colon)
166:17: E128 continuation line under-indented for visual indent
167:17: E128 continuation line under-indented for visual indent
168:17: E128 continuation line under-indented for visual indent
169:17: E128 continuation line under-indented for visual indent
171:1: E302 expected 2 blank lines, found 1
171: D202 No blank lines allowed after function docstring (found 1)
175:22: E701 multiple statements on one line (colon)
178:9: E128 continuation line under-indented for visual indent
186:29: F841 local variable 'err' is assigned to but never used
194:34: E261 at least two spaces before inline comment
194:35: E262 inline comment should start with '# '
196:13: E266 too many leading '#' for block comment
197:13: E266 too many leading '#' for block comment
199:13: E266 too many leading '#' for block comment
200:13: E266 too many leading '#' for block comment
201:13: E266 too many leading '#' for block comment
205:21: E266 too many leading '#' for block comment
206:21: E266 too many leading '#' for block comment
207:21: E266 too many leading '#' for block comment
215:21: E266 too many leading '#' for block comment
216:21: E266 too many leading '#' for block comment
217:21: E266 too many leading '#' for block comment
218:21: E266 too many leading '#' for block comment
219:21: E266 too many leading '#' for block comment
229:17: E266 too many leading '#' for block comment
230:17: E266 too many leading '#' for block comment
246:17: E128 continuation line under-indented for visual indent
251:11: E221 multiple spaces before operator
285:17: E128 continuation line under-indented for visual indent
286:17: E128 continuation line under-indented for visual indent
287:17: E128 continuation line under-indented for visual indent
288:17: E128 continuation line under-indented for visual indent
291: D202 No blank lines allowed after function docstring (found 1)
295:22: E701 multiple statements on one line (colon)
300:29: F841 local variable 'err' is assigned to but never used
310:5: F841 local variable 'roles2' is assigned to but never used
320:21: E266 too many leading '#' for block comment
347:17: E128 continuation line under-indented for visual indent
352:11: E221 multiple spaces before operator
383:17: E128 continuation line under-indented for visual indent
384:17: E128 continuation line under-indented for visual indent
385:17: E128 continuation line under-indented for visual indent
386:17: E128 continuation line under-indented for visual indent
389: D210 No whitespaces allowed surrounding docstring text
389: None: None
389: D202 No blank lines allowed after function docstring (found 1)
393:22: E701 multiple statements on one line (colon)
405:9: E221 multiple spaces before operator
410:29: E128 continuation line under-indented for visual indent
411:29: E128 continuation line under-indented for visual indent
432:25: E128 continuation line under-indented for visual indent
441:17: E128 continuation line under-indented for visual indent
448:17: E128 continuation line under-indented for visual indent
449:17: E128 continuation line under-indented for visual indent
450:17: E128 continuation line under-indented for visual indent
451:17: E128 continuation line under-indented for visual indent
454: D202 No blank lines allowed after function docstring (found 1)
458:22: E701 multiple statements on one line (colon)
471:17: E128 continuation line under-indented for visual indent
472:17: E128 continuation line under-indented for visual indent
473:17: E128 continuation line under-indented for visual indent
474:17: E128 continuation line under-indented for visual indent
477: D209 Multi-line docstring closing quotes should be on a separate line
477: D202 No blank lines allowed after function docstring (found 1)
477: D400 First line should end with a period (not 'e')
477: D205 1 blank line required between summary line and description (found 0)
483:22: E701 multiple statements on one line (colon)
486:31: E701 multiple statements on one line (colon)
490:34: E701 multiple statements on one line (colon)
493:11: E221 multiple spaces before operator
517:5: E303 too many blank lines (2)
529:14: E221 multiple spaces before operator
534:12: E221 multiple spaces before operator
553:17: E128 continuation line under-indented for visual indent
554:17: E128 continuation line under-indented for visual indent
555:17: E128 continuation line under-indented for visual indent
556:17: E128 continuation line under-indented for visual indent
559: D209 Multi-line docstring closing quotes should be on a separate line
559: D202 No blank lines allowed after function docstring (found 1)
559: D205 1 blank line required between summary line and description (found 0)
564:22: E701 multiple statements on one line (colon)
567:31: E701 multiple statements on one line (colon)
571:34: E701 multiple statements on one line (colon)
574:11: E221 multiple spaces before operator
610:14: E221 multiple spaces before operator
615:12: E221 multiple spaces before operator
619:29: E128 continuation line under-indented for visual indent
620:29: E128 continuation line under-indented for visual indent
621:29: E128 continuation line under-indented for visual indent
622:29: E128 continuation line under-indented for visual indent
632:17: E128 continuation line under-indented for visual indent
633:17: E128 continuation line under-indented for visual indent
634:17: E128 continuation line under-indented for visual indent
635:17: E128 continuation line under-indented for visual indent
637:1: E302 expected 2 blank lines, found 1
637: D202 No blank lines allowed after function docstring (found 1)
641:22: E701 multiple statements on one line (colon)
693:17: E128 continuation line under-indented for visual indent
694:17: E128 continuation line under-indented for visual indent
695:17: E128 continuation line under-indented for visual indent
696:17: E128 continuation line under-indented for visual indent
697:17: E128 continuation line under-indented for visual indent
699:1: E302 expected 2 blank lines, found 1
699: D202 No blank lines allowed after function docstring (found 1)
703:22: E701 multiple statements on one line (colon)
748:1: E302 expected 2 blank lines, found 1
748: D202 No blank lines allowed after function docstring (found 1)
752:22: E701 multiple statements on one line (colon)
774:1: E302 expected 2 blank lines, found 1
774: D202 No blank lines allowed after function docstring (found 1)
778:22: E701 multiple statements on one line (colon)
790:33: E127 continuation line over-indented for visual indent
791:33: E127 continuation line over-indented for visual indent
792:33: E127 continuation line over-indented for visual indent
824: D202 No blank lines allowed after function docstring (found 1)
824: D400 First line should end with a period (not 'e')
828:22: E701 multiple statements on one line (colon)
845:13: F841 local variable 'res2' is assigned to but never used
857:1: E302 expected 2 blank lines, found 1
857: D209 Multi-line docstring closing quotes should be on a separate line
857: D202 No blank lines allowed after function docstring (found 1)
857: D205 1 blank line required between summary line and description (found 0)
865:22: E701 multiple statements on one line (colon)
877:17: E128 continuation line under-indented for visual indent
878:17: E128 continuation line under-indented for visual indent
879:17: E128 continuation line under-indented for visual indent
880:17: E128 continuation line under-indented for visual indent
881:17: E128 continuation line under-indented for visual indent
920:17: E128 continuation line under-indented for visual indent
921:17: E128 continuation line under-indented for visual indent
922:17: E128 continuation line under-indented for visual indent
923:17: E128 continuation line under-indented for visual indent
924:17: E128 continuation line under-indented for visual indent
926:1: E302 expected 2 blank lines, found 1
926: D202 No blank lines allowed after function docstring (found 1)
926: D400 First line should end with a period (not 't')
930:22: E701 multiple statements on one line (colon)
949:1: E302 expected 2 blank lines, found 1
949: D202 No blank lines allowed after function docstring (found 1)
949: D400 First line should end with a period (not 't')
953:22: E701 multiple statements on one line (colon)
963:15: E222 multiple spaces after operator
964:15: E222 multiple spaces after operator
972:33: E128 continuation line under-indented for visual indent
973:33: E128 continuation line under-indented for visual indent
974:33: E128 continuation line under-indented for visual indent
975:33: E128 continuation line under-indented for visual indent
1000:1: E302 expected 2 blank lines, found 1
1000: D202 No blank lines allowed after function docstring (found 1)
1000: D400 First line should end with a period (not 't')
1004:22: E701 multiple statements on one line (colon)
1025:9: E303 too many blank lines (2)
1026:33: E128 continuation line under-indented for visual indent
1027:33: E128 continuation line under-indented for visual indent
1028:33: E128 continuation line under-indented for visual indent
1029:33: E128 continuation line under-indented for visual indent
1046:1: E302 expected 2 blank lines, found 1
1046: D202 No blank lines allowed after function docstring (found 1)
1046: D400 First line should end with a period (not 't')
1050:22: E701 multiple statements on one line (colon)
1060:37: E128 continuation line under-indented for visual indent
1061:21: E128 continuation line under-indented for visual indent
1062:37: E128 continuation line under-indented for visual indent
1063:37: E128 continuation line under-indented for visual indent
1066:13: F841 local variable 'res2' is assigned to but never used
1069:17: F841 local variable 'emailsent' is assigned to but never used
1080:1: E302 expected 2 blank lines, found 1
1080:62: E203 whitespace before ','
1080: D202 No blank lines allowed after function docstring (found 1)
1080: D400 First line should end with a period (not 't')
1085:22: E701 multiple statements on one line (colon)
1121:1: E302 expected 2 blank lines, found 1
1121: D202 No blank lines allowed after function docstring (found 1)
1125:22: E701 multiple statements on one line (colon)
1131:9: F841 local variable 'res2' is assigned to but never used
1152:1: E302 expected 2 blank lines, found 1
1152: D202 No blank lines allowed after function docstring (found 1)
1156:22: E701 multiple statements on one line (colon)
1166:5: B901 blind except: statement
1172:5: B901 blind except: statement
1175:9: E221 multiple spaces before operator
1183:36: E225 missing whitespace around operator
1183:76: E225 missing whitespace around operator
1183:120: E225 missing whitespace around operator
1193:35: E225 missing whitespace around operator
1193:71: E225 missing whitespace around operator
1193:107: E225 missing whitespace around operator
1193:144: E225 missing whitespace around operator
1193:181: E225 missing whitespace around operator
1193:218: E225 missing whitespace around operator
1196:29: E128 continuation line under-indented for visual indent
1197:29: E128 continuation line under-indented for visual indent
1223:31: E221 multiple spaces before operator
1225:60: E221 multiple spaces before operator
1226:51: E225 missing whitespace around operator
1227:36: E225 missing whitespace around operator
1228:64: E231 missing whitespace after ','
1239:46: E221 multiple spaces before operator
1259:1: E302 expected 2 blank lines, found 1
1259: D202 No blank lines allowed after function docstring (found 1)
1266:21: E128 continuation line under-indented for visual indent
1267:21: E128 continuation line under-indented for visual indent
1268:21: E128 continuation line under-indented for visual indent
1297:17: E128 continuation line under-indented for visual indent
1298:17: E128 continuation line under-indented for visual indent
1299:17: E128 continuation line under-indented for visual indent
1300:17: E128 continuation line under-indented for visual indent
1301:17: E128 continuation line under-indented for visual indent
1304: D401 First line should be in imperative mood ('let', not 'lets')
1304: D209 Multi-line docstring closing quotes should be on a separate line
1304: D202 No blank lines allowed after function docstring (found 1)
1304: D400 First line should end with a period (not 's')
1304: D208 Docstring is over-indented
1330:29: E128 continuation line under-indented for visual indent
1331:29: E128 continuation line under-indented for visual indent
1332:29: E128 continuation line under-indented for visual indent
1333:29: E128 continuation line under-indented for visual indent
1334:29: E128 continuation line under-indented for visual indent
1355:29: E701 multiple statements on one line (colon)
1371:33: E128 continuation line under-indented for visual indent
1372:33: E128 continuation line under-indented for visual indent
1373:33: E128 continuation line under-indented for visual indent
1374:33: E128 continuation line under-indented for visual indent
1375:33: E128 continuation line under-indented for visual indent
1376:33: E128 continuation line under-indented for visual indent
1389:37: E128 continuation line under-indented for visual indent
1390:37: E128 continuation line under-indented for visual indent
1391:37: E128 continuation line under-indented for visual indent
1392:37: E128 continuation line under-indented for visual indent
1402:49: E128 continuation line under-indented for visual indent
1403:49: E128 continuation line under-indented for visual indent
1404:49: E128 continuation line under-indented for visual indent
1409:21: E701 multiple statements on one line (colon)
1412:8: E701 multiple statements on one line (colon)
1413:21: E701 multiple statements on one line (colon)
1416:17: E128 continuation line under-indented for visual indent
1417:17: E128 continuation line under-indented for visual indent
1418:17: E128 continuation line under-indented for visual indent
1419:17: E128 continuation line under-indented for visual indent
1422: D209 Multi-line docstring closing quotes should be on a separate line
1422: D202 No blank lines allowed after function docstring (found 1)
1467:33: E128 continuation line under-indented for visual indent
1475:17: E221 multiple spaces before operator
1479:37: E128 continuation line under-indented for visual indent
1480:37: E128 continuation line under-indented for visual indent
1481:37: E128 continuation line under-indented for visual indent
1512:53: E701 multiple statements on one line (colon)
1512:71: E231 missing whitespace after ','
1512:77: E231 missing whitespace after ','
1514:54: E231 missing whitespace after ','
1517:45: E128 continuation line under-indented for visual indent
1518:45: E128 continuation line under-indented for visual indent
1519:45: E128 continuation line under-indented for visual indent
1520:45: E128 continuation line under-indented for visual indent
1521:45: E128 continuation line under-indented for visual indent
1522:45: E128 continuation line under-indented for visual indent
1523:45: E128 continuation line under-indented for visual indent
1525:24: E701 multiple statements on one line (colon)
1526:38: E701 multiple statements on one line (colon)
1535:49: E128 continuation line under-indented for visual indent
1536:49: E128 continuation line under-indented for visual indent
1537:49: E128 continuation line under-indented for visual indent
1538:49: E128 continuation line under-indented for visual indent
1539:49: E128 continuation line under-indented for visual indent
1548:39: E221 multiple spaces before operator
1561:17: E128 continuation line under-indented for visual indent
1562:17: E128 continuation line under-indented for visual indent
1563:17: E128 continuation line under-indented for visual indent
1564:17: E128 continuation line under-indented for visual indent
1565:17: E128 continuation line under-indented for visual indent
1568: D209 Multi-line docstring closing quotes should be on a separate line
1568: D202 No blank lines allowed after function docstring (found 1)
1605:9: F841 local variable 'email_out' is assigned to but never used
1618:33: E128 continuation line under-indented for visual indent
1626:37: E128 continuation line under-indented for visual indent
1627:37: E128 continuation line under-indented for visual indent
1628:37: E128 continuation line under-indented for visual indent
1629:37: E128 continuation line under-indented for visual indent
1636:41: E128 continuation line under-indented for visual indent
1637:41: E128 continuation line under-indented for visual indent
1638:41: E128 continuation line under-indented for visual indent
1639:41: E128 continuation line under-indented for visual indent
1640:41: E128 continuation line under-indented for visual indent
1659:17: E128 continuation line under-indented for visual indent
1660:17: E128 continuation line under-indented for visual indent
1661:17: E128 continuation line under-indented for visual indent
1662:17: E128 continuation line under-indented for visual indent
1663:17: E128 continuation line under-indented for visual indent
1665:1: E302 expected 2 blank lines, found 1
1665: D210 No whitespaces allowed surrounding docstring text
1665: None: None
1665: D202 No blank lines allowed after function docstring (found 1)
1669:22: E701 multiple statements on one line (colon)
1697:17: E128 continuation line under-indented for visual indent
1698:17: E128 continuation line under-indented for visual indent
1699:17: E128 continuation line under-indented for visual indent
1700:17: E128 continuation line under-indented for visual indent
1703: D210 No whitespaces allowed surrounding docstring text
1703: None: None
1703: D202 No blank lines allowed after function docstring (found 1)
1713:29: E128 continuation line under-indented for visual indent
1726:29: E128 continuation line under-indented for visual indent
1741: D209 Multi-line docstring closing quotes should be on a separate line
1741: D202 No blank lines allowed after function docstring (found 1)
1741: D400 First line should end with a period (not ':')
1749:22: E701 multiple statements on one line (colon)
1753:10: E225 missing whitespace around operator
1797:37: E128 continuation line under-indented for visual indent
1798:37: E128 continuation line under-indented for visual indent
1799:37: E128 continuation line under-indented for visual indent
1800:37: E128 continuation line under-indented for visual indent
1801:37: E128 continuation line under-indented for visual indent
1805:41: E128 continuation line under-indented for visual indent
1806:41: E128 continuation line under-indented for visual indent
1807:41: E128 continuation line under-indented for visual indent
1816:41: E128 continuation line under-indented for visual indent
1832:8: E701 multiple statements on one line (colon)
1833:21: E701 multiple statements on one line (colon)
1836:17: E128 continuation line under-indented for visual indent
1837:17: E128 continuation line under-indented for visual indent
1838:17: E128 continuation line under-indented for visual indent
1839:17: E128 continuation line under-indented for visual indent
1841:1: E302 expected 2 blank lines, found 1
1841: D202 No blank lines allowed after function docstring (found 1)
1841: D400 First line should end with a period (not ':')
1852:22: E701 multiple statements on one line (colon)
1855:27: E225 missing whitespace around operator
1865:10: E225 missing whitespace around operator
1912:41: E127 continuation line over-indented for visual indent
1913:41: E127 continuation line over-indented for visual indent
1913:48: E251 unexpected spaces around keyword / parameter equals
1913:50: E251 unexpected spaces around keyword / parameter equals
1914:41: E127 continuation line over-indented for visual indent
1915:41: E127 continuation line over-indented for visual indent
1916:41: E127 continuation line over-indented for visual indent
1917:41: E127 continuation line over-indented for visual indent
1918:41: E127 continuation line over-indented for visual indent
1921:45: E128 continuation line under-indented for visual indent
1927:25: E128 continuation line under-indented for visual indent
1928:25: E128 continuation line under-indented for visual indent
1934:5: E303 too many blank lines (2)
1937:21: E127 continuation line over-indented for visual indent
1938:21: E127 continuation line over-indented for visual indent
1939:21: E127 continuation line over-indented for visual indent
1940:21: E127 continuation line over-indented for visual indent
1944:1: E303 too many blank lines (3)
1944: D209 Multi-line docstring closing quotes should be on a separate line
1944: D202 No blank lines allowed after function docstring (found 1)
1944: D400 First line should end with a period (not ',')
1952:22: E701 multiple statements on one line (colon)
1959:29: E128 continuation line under-indented for visual indent
1960:29: E128 continuation line under-indented for visual indent
1961:29: E128 continuation line under-indented for visual indent
1962:29: E128 continuation line under-indented for visual indent
1970:33: E128 continuation line under-indented for visual indent
1971:33: E128 continuation line under-indented for visual indent
1972:33: E128 continuation line under-indented for visual indent
1986:17: E128 continuation line under-indented for visual indent
1987:17: E128 continuation line under-indented for visual indent
1988:17: E128 continuation line under-indented for visual indent
1989:17: E128 continuation line under-indented for visual indent
1992: D202 No blank lines allowed after function docstring (found 1)
1996:22: E701 multiple statements on one line (colon)
1999:29: E128 continuation line under-indented for visual indent
2000:29: E128 continuation line under-indented for visual indent
2001:29: E128 continuation line under-indented for visual indent
2002:29: E128 continuation line under-indented for visual indent
2024:25: E203 whitespace before ':'
2024:48: E203 whitespace before ':'
2032:17: E128 continuation line under-indented for visual indent
2033:17: E128 continuation line under-indented for visual indent
2034:17: E128 continuation line under-indented for visual indent
2035:17: E128 continuation line under-indented for visual indent
2038: D210 No whitespaces allowed surrounding docstring text
2038: None: None
2038: D202 No blank lines allowed after function docstring (found 1)
2065:12: E221 multiple spaces before operator
2069:62: E261 at least two spaces before inline comment
2090:1: E303 too many blank lines (3)
2090: D209 Multi-line docstring closing quotes should be on a separate line
2090: D202 No blank lines allowed after function docstring (found 1)
2090: D208 Docstring is over-indented
2100:22: E701 multiple statements on one line (colon)
2109:29: E128 continuation line under-indented for visual indent
2110:29: E128 continuation line under-indented for visual indent
2111:29: E128 continuation line under-indented for visual indent
2122:13: E221 multiple spaces before operator
2126:33: E128 continuation line under-indented for visual indent
2127:33: E128 continuation line under-indented for visual indent
2128:33: E128 continuation line under-indented for visual indent
2159:54: E701 multiple statements on one line (colon)
2159:77: E231 missing whitespace after ','
2159:83: E231 missing whitespace after ','
2161:55: E231 missing whitespace after ','
2164:41: E128 continuation line under-indented for visual indent
2165:41: E128 continuation line under-indented for visual indent
2166:41: E128 continuation line under-indented for visual indent
2167:41: E128 continuation line under-indented for visual indent
2168:41: E128 continuation line under-indented for visual indent
2169:41: E128 continuation line under-indented for visual indent
2170:41: E128 continuation line under-indented for visual indent
2172:20: E701 multiple statements on one line (colon)
2173:34: E701 multiple statements on one line (colon)
2182:45: E128 continuation line under-indented for visual indent
2183:45: E128 continuation line under-indented for visual indent
2184:45: E128 continuation line under-indented for visual indent
2185:45: E128 continuation line under-indented for visual indent
2186:45: E128 continuation line under-indented for visual indent
2195:35: E221 multiple spaces before operator
2221:17: E128 continuation line under-indented for visual indent
2222:17: E128 continuation line under-indented for visual indent
2223:17: E128 continuation line under-indented for visual indent
2224:17: E128 continuation line under-indented for visual indent
2227: D209 Multi-line docstring closing quotes should be on a separate line
2227: D202 No blank lines allowed after function docstring (found 1)
2235:22: E701 multiple statements on one line (colon)
2249:9: E221 multiple spaces before operator
2253:29: E128 continuation line under-indented for visual indent
2254:29: E128 continuation line under-indented for visual indent
2255:29: E128 continuation line under-indented for visual indent
2265:34: E701 multiple statements on one line (colon)
2276:37: E128 continuation line under-indented for visual indent
2277:37: E128 continuation line under-indented for visual indent
2278:37: E128 continuation line under-indented for visual indent
2279:37: E128 continuation line under-indented for visual indent
2280:37: E128 continuation line under-indented for visual indent
2292:38: E701 multiple statements on one line (colon)
2293:25: E701 multiple statements on one line (colon)
2297:41: E128 continuation line under-indented for visual indent
2298:41: E128 continuation line under-indented for visual indent
2299:41: E128 continuation line under-indented for visual indent
2300:41: E128 continuation line under-indented for visual indent
2301:41: E128 continuation line under-indented for visual indent
2302:41: E128 continuation line under-indented for visual indent
2303:41: E128 continuation line under-indented for visual indent
2304:41: E128 continuation line under-indented for visual indent
2313:45: E128 continuation line under-indented for visual indent
2314:45: E128 continuation line under-indented for visual indent
2315:45: E128 continuation line under-indented for visual indent
2316:45: E128 continuation line under-indented for visual indent
2317:45: E128 continuation line under-indented for visual indent
2325:35: E221 multiple spaces before operator
2344:32: E701 multiple statements on one line (colon)
2353:17: E128 continuation line under-indented for visual indent
2354:17: E128 continuation line under-indented for visual indent
2355:17: E128 continuation line under-indented for visual indent
2356:17: E128 continuation line under-indented for visual indent
2359: D209 Multi-line docstring closing quotes should be on a separate line
2359: D202 No blank lines allowed after function docstring (found 1)
2367:22: E701 multiple statements on one line (colon)
2379:33: E128 continuation line under-indented for visual indent
2380:33: E128 continuation line under-indented for visual indent
2381:33: E128 continuation line under-indented for visual indent
2386:37: E128 continuation line under-indented for visual indent
2387:37: E128 continuation line under-indented for visual indent
2388:37: E128 continuation line under-indented for visual indent
2389:37: E128 continuation line under-indented for visual indent
2404:39: E701 multiple statements on one line (colon)
2409:40: E261 at least two spaces before inline comment
2414:37: E128 continuation line under-indented for visual indent
2415:37: E128 continuation line under-indented for visual indent
2416:37: E128 continuation line under-indented for visual indent
2417:37: E128 continuation line under-indented for visual indent
2426:38: E701 multiple statements on one line (colon)
2429:41: E128 continuation line under-indented for visual indent
2430:41: E128 continuation line under-indented for visual indent
2431:41: E128 continuation line under-indented for visual indent
2432:41: E128 continuation line under-indented for visual indent
2433:41: E128 continuation line under-indented for visual indent
2438:33: E128 continuation line under-indented for visual indent
2439:33: E128 continuation line under-indented for visual indent
2440:33: E128 continuation line under-indented for visual indent
2441:33: E128 continuation line under-indented for visual indent
2442:33: E128 continuation line under-indented for visual indent
2477:13: E701 multiple statements on one line (colon)
2478:9: E701 multiple statements on one line (colon)
2481:17: E128 continuation line under-indented for visual indent
2482:17: E128 continuation line under-indented for visual indent
2483:17: E128 continuation line under-indented for visual indent
2484:17: E128 continuation line under-indented for visual indent
2487: D210 No whitespaces allowed surrounding docstring text
2487: None: None
2487: D202 No blank lines allowed after function docstring (found 1)
2491:22: E701 multiple statements on one line (colon)
2511:17: E128 continuation line under-indented for visual indent
2512:17: E128 continuation line under-indented for visual indent
2513:17: E128 continuation line under-indented for visual indent
2514:17: E128 continuation line under-indented for visual indent
2517: D210 No whitespaces allowed surrounding docstring text
2517: None: None
2517: D202 No blank lines allowed after function docstring (found 1)
2534:16: E221 multiple spaces before operator
2537:16: E221 multiple spaces before operator
2541:1: E302 expected 2 blank lines, found 1
2541: D210 No whitespaces allowed surrounding docstring text
2541: None: None
2541: D209 Multi-line docstring closing quotes should be on a separate line
2541: D202 No blank lines allowed after function docstring (found 1)
2541: D400 First line should end with a period (not ':')
2551:22: E701 multiple statements on one line (colon)
2572:33: E128 continuation line under-indented for visual indent
2573:33: E128 continuation line under-indented for visual indent
2574:33: E128 continuation line under-indented for visual indent
2575:33: E128 continuation line under-indented for visual indent
2583:36: E701 multiple statements on one line (colon)
2585:41: E128 continuation line under-indented for visual indent
2586:41: E128 continuation line under-indented for visual indent
2587:41: E128 continuation line under-indented for visual indent
2588:41: E128 continuation line under-indented for visual indent
2589:41: E128 continuation line under-indented for visual indent
2590:41: E128 continuation line under-indented for visual indent
2607:37: E701 multiple statements on one line (colon)
2609:37: E128 continuation line under-indented for visual indent
2610:37: E128 continuation line under-indented for visual indent
2611:37: E128 continuation line under-indented for visual indent
2612:37: E128 continuation line under-indented for visual indent
2613:37: E128 continuation line under-indented for visual indent
2614:37: E128 continuation line under-indented for visual indent
2639:12: E221 multiple spaces before operator
2681:40: E261 at least two spaces before inline comment
2682:27: E701 multiple statements on one line (colon)
2683:25: E701 multiple statements on one line (colon)
2684:32: E701 multiple statements on one line (colon)
2708:41: E128 continuation line under-indented for visual indent
2709:41: E128 continuation line under-indented for visual indent
2710:41: E128 continuation line under-indented for visual indent
2711:41: E128 continuation line under-indented for visual indent
2712:41: E128 continuation line under-indented for visual indent
2713:41: E128 continuation line under-indented for visual indent
2714:41: E128 continuation line under-indented for visual indent
2728:13: E701 multiple statements on one line (colon)
2731:5: E303 too many blank lines (2)
2735:41: E128 continuation line under-indented for visual indent
2736:41: E128 continuation line under-indented for visual indent
2737:41: E128 continuation line under-indented for visual indent
2741:29: E261 at least two spaces before inline comment
2744:43: E701 multiple statements on one line (colon)
2757:13: E701 multiple statements on one line (colon)
2760:8: E701 multiple statements on one line (colon)
2761:21: E701 multiple statements on one line (colon)
2764:17: E128 continuation line under-indented for visual indent
2764:22: E251 unexpected spaces around keyword / parameter equals
2764:24: E251 unexpected spaces around keyword / parameter equals
2765:17: E128 continuation line under-indented for visual indent
2766:17: E128 continuation line under-indented for visual indent
2767:17: E128 continuation line under-indented for visual indent
2770: D209 Multi-line docstring closing quotes should be on a separate line
2770: D202 No blank lines allowed after function docstring (found 1)
2770: D208 Docstring is over-indented
2781:22: E701 multiple statements on one line (colon)
2789:15: E221 multiple spaces before operator
2790:33: E128 continuation line under-indented for visual indent
2791:33: E128 continuation line under-indented for visual indent
2792:33: E128 continuation line under-indented for visual indent
2793:33: E128 continuation line under-indented for visual indent
2799:41: E128 continuation line under-indented for visual indent
2800:41: E128 continuation line under-indented for visual indent
2801:41: E128 continuation line under-indented for visual indent
2802:41: E128 continuation line under-indented for visual indent
2803:41: E128 continuation line under-indented for visual indent
2804:41: E128 continuation line under-indented for visual indent
2819:37: E128 continuation line under-indented for visual indent
2820:37: E128 continuation line under-indented for visual indent
2821:37: E128 continuation line under-indented for visual indent
2822:37: E128 continuation line under-indented for visual indent
2823:37: E128 continuation line under-indented for visual indent
2824:37: E128 continuation line under-indented for visual indent
2837:37: E128 continuation line under-indented for visual indent
2838:37: E128 continuation line under-indented for visual indent
2839:37: E128 continuation line under-indented for visual indent
2840:37: E128 continuation line under-indented for visual indent
2841:37: E128 continuation line under-indented for visual indent
2856:17: E128 continuation line under-indented for visual indent
2857:17: E128 continuation line under-indented for visual indent
2858:17: E128 continuation line under-indented for visual indent
2859:17: E128 continuation line under-indented for visual indent
2862: D209 Multi-line docstring closing quotes should be on a separate line
2862: D202 No blank lines allowed after function docstring (found 1)
2862: D400 First line should end with a period (not 's')
2862: D205 1 blank line required between summary line and description (found 0)
2880:22: E701 multiple statements on one line (colon)
2887:8: E701 multiple statements on one line (colon)
2888:22: E701 multiple statements on one line (colon)
2913:5: E303 too many blank lines (2)
2918:33: E128 continuation line under-indented for visual indent
2919:33: E128 continuation line under-indented for visual indent
2920:33: E128 continuation line under-indented for visual indent
2921:33: E128 continuation line under-indented for visual indent
2927:41: E128 continuation line under-indented for visual indent
2928:41: E128 continuation line under-indented for visual indent
2929:41: E128 continuation line under-indented for visual indent
2930:41: E128 continuation line under-indented for visual indent
2931:41: E128 continuation line under-indented for visual indent
2937:37: E128 continuation line under-indented for visual indent
2938:37: E128 continuation line under-indented for visual indent
2939:37: E128 continuation line under-indented for visual indent
2940:37: E128 continuation line under-indented for visual indent
2945:37: E128 continuation line under-indented for visual indent
2946:37: E128 continuation line under-indented for visual indent
2947:37: E128 continuation line under-indented for visual indent
2948:37: E128 continuation line under-indented for visual indent
2949:37: E128 continuation line under-indented for visual indent
2951:17: E701 multiple statements on one line (colon)
2955:37: E701 multiple statements on one line (colon)
2968:80: E701 multiple statements on one line (colon)
3014:24: E221 multiple spaces before operator
3045:17: E128 continuation line under-indented for visual indent
3046:17: E128 continuation line under-indented for visual indent
3047:17: E128 continuation line under-indented for visual indent
3048:17: E128 continuation line under-indented for visual indent
3051: D209 Multi-line docstring closing quotes should be on a separate line
3051: D202 No blank lines allowed after function docstring (found 1)
3051: D205 1 blank line required between summary line and description (found 0)
3052:9: E128 continuation line under-indented for visual indent
3076:9: E128 continuation line under-indented for visual indent
3078:11: E221 multiple spaces before operator
3086:5: E303 too many blank lines (2)
3100:11: E221 multiple spaces before operator
3129: D209 Multi-line docstring closing quotes should be on a separate line
3129: D202 No blank lines allowed after function docstring (found 1)
3129: D400 First line should end with a period (not 'f')
3129: D205 1 blank line required between summary line and description (found 0)
3158:13: E128 continuation line under-indented for visual indent
3163: D209 Multi-line docstring closing quotes should be on a separate line
3163: D202 No blank lines allowed after function docstring (found 1)
3163: D400 First line should end with a period (not 't')
3163: D205 1 blank line required between summary line and description (found 0)
3195:1: E303 too many blank lines (3)
3195: D209 Multi-line docstring closing quotes should be on a separate line
3195: D202 No blank lines allowed after function docstring (found 1)
3213:45: E128 continuation line under-indented for visual indent
3214:45: E128 continuation line under-indented for visual indent
3218:1: E302 expected 2 blank lines, found 1
3218: D209 Multi-line docstring closing quotes should be on a separate line
3218: D202 No blank lines allowed after function docstring (found 1)
3240:114: E261 at least two spaces before inline comment
3250: D209 Multi-line docstring closing quotes should be on a separate line
3250: D202 No blank lines allowed after function docstring (found 1)
3250: D208 Docstring is over-indented
3276:118: E261 at least two spaces before inline comment
3289: D202 No blank lines allowed after function docstring (found 1)
3289: D400 First line should end with a period (not 'e')
3323:1: E302 expected 2 blank lines, found 1
3323: D103 Missing docstring in public function
3326:1: E302 expected 2 blank lines, found 1
3326: D209 Multi-line docstring closing quotes should be on a separate line
3326: D202 No blank lines allowed after function docstring (found 1)
3326: D400 First line should end with a period (not 'a')
3326: D205 1 blank line required between summary line and description (found 0)
3337:13: E128 continuation line under-indented for visual indent
3338:13: E128 continuation line under-indented for visual indent
3339:13: E128 continuation line under-indented for visual indent
3341:15: E221 multiple spaces before operator
3348:17: E128 continuation line under-indented for visual indent
3349:17: E128 continuation line under-indented for visual indent
3350:17: E128 continuation line under-indented for visual indent
3351:17: E128 continuation line under-indented for visual indent
3354: D210 No whitespaces allowed surrounding docstring text
3354: None: None
3354: D202 No blank lines allowed after function docstring (found 1)
3368:17: E128 continuation line under-indented for visual indent
3369:15: E221 multiple spaces before operator
3384:17: E128 continuation line under-indented for visual indent
3385:17: E128 continuation line under-indented for visual indent
3386:17: E128 continuation line under-indented for visual indent
3387:17: E128 continuation line under-indented for visual indent
3393:1: E303 too many blank lines (5)
3393: D209 Multi-line docstring closing quotes should be on a separate line
3393: D202 No blank lines allowed after function docstring (found 1)
3393: D400 First line should end with a period (not 's')
3394:17: E128 continuation line under-indented for visual indent
3395:17: E128 continuation line under-indented for visual indent
3417:11: E221 multiple spaces before operator
3462: D202 No blank lines allowed after function docstring (found 1)
3463:9: E128 continuation line under-indented for visual indent
3464:9: E128 continuation line under-indented for visual indent
3468:9: E128 continuation line under-indented for visual indent
3469:9: E128 continuation line under-indented for visual indent
3472: D202 No blank lines allowed after function docstring (found 1)
3473:9: E128 continuation line under-indented for visual indent
3474:9: E128 continuation line under-indented for visual indent
3478:9: E128 continuation line under-indented for visual indent
3479:9: E128 continuation line under-indented for visual indent
3482: D202 No blank lines allowed after function docstring (found 1)
3483:9: E128 continuation line under-indented for visual indent
3484:9: E128 continuation line under-indented for visual indent
3488:9: E128 continuation line under-indented for visual indent
3489:9: E128 continuation line under-indented for visual indent
3492: D209 Multi-line docstring closing quotes should be on a separate line
3492: D202 No blank lines allowed after function docstring (found 1)
3492: D205 1 blank line required between summary line and description (found 0)
3492: D208 Docstring is over-indented
3519: D209 Multi-line docstring closing quotes should be on a separate line
3519: D202 No blank lines allowed after function docstring (found 1)
3519: D205 1 blank line required between summary line and description (found 0)
3533: D209 Multi-line docstring closing quotes should be on a separate line
3533: D202 No blank lines allowed after function docstring (found 1)
3544: D209 Multi-line docstring closing quotes should be on a separate line
3544: D202 No blank lines allowed after function docstring (found 1)
3544: D205 1 blank line required between summary line and description (found 0)
3551:1: E302 expected 2 blank lines, found 1
3551: D209 Multi-line docstring closing quotes should be on a separate line
3551: D400 First line should end with a period (not 'd')
3551: D205 1 blank line required between summary line and description (found 0)
3565:1: E302 expected 2 blank lines, found 1
3565: D209 Multi-line docstring closing quotes should be on a separate line
3565: D400 First line should end with a period (not 't')
3565: D205 1 blank line required between summary line and description (found 0)
3578:1: E302 expected 2 blank lines, found 1
3578: D209 Multi-line docstring closing quotes should be on a separate line
3578: D400 First line should end with a period (not 't')
3578: D205 1 blank line required between summary line and description (found 0)
3591:1: E302 expected 2 blank lines, found 1
3591: D209 Multi-line docstring closing quotes should be on a separate line
3591: D400 First line should end with a period (not 't')
3591: D205 1 blank line required between summary line and description (found 0)


1: D210 No whitespaces allowed surrounding docstring text
1: None: None
25:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
27:1: F401 'config' imported but unused
27:1: E402 module level import not at top of file
142:16: E126 continuation line over-indented for hanging indent
148:58: E203 whitespace before ','
208:15: E126 continuation line over-indented for hanging indent
211:1: E402 module level import not at top of file
244:17: E203 whitespace before ':'
245:22: E203 whitespace before ':'
246:20: E203 whitespace before ':'
247:18: E203 whitespace before ':'
248:24: E203 whitespace before ':'
249:22: E203 whitespace before ':'
250:19: E203 whitespace before ':'
251:20: E203 whitespace before ':'
252:23: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:17: E203 whitespace before ':'
255:19: E203 whitespace before ':'
256:20: E203 whitespace before ':'
257:21: E203 whitespace before ':'
258:19: E203 whitespace before ':'
259:19: E203 whitespace before ':'
260:20: E203 whitespace before ':'
261:17: E203 whitespace before ':'
262:24: E203 whitespace before ':'
263:23: E203 whitespace before ':'
264:21: E203 whitespace before ':'
265:37: E203 whitespace before ':'
279:4: E131 continuation line unaligned for hanging indent
308:1: W391 blank line at end of file


まとめテキスト/概要.txt

複数のコネクションを同時に使いデータを早く
+送る方法
何についての話http/2?


Update needed here


- Manually setting core.autocrlf after cloning a repo.

I was considering adding .gitattributes file to the cs-studio repo, so there would be no need to manually set aore.autocrlf
https://help.github.com/articles/dealing-with-line-endings/


would be good to say 'the OS_USERNAME environment variable is used' rather than 'the environment variable is used'


The name of this function is way too close to `produceAction` above, could it be renamed?


I want to name this func O_RDONLY but then it gets expanded through the macro so don't work.


On line 494, os.join.path (os.path.join(fname[0], name+fname[1]), fname[2])
does not reproduce the behavior of (fname[0]+name+fname[1], fname[2])
since it adds slashes. Can I revert back or was this new format propagated throughout?

Simon


real x64 sha256 is  in fact ```da1ad819ce7b7ec528264f831d88afaa5db34b7955e45422a7e380b1ead6b04d```


まとめテキスト/概要.txt

画像があとから表示されてくるサイトとかあるけど，そういうのを使えばhttp2はいらないんじゃないの？


Actually...now you can :-)

I have added the possibility to use your custom range calculator instead of the default one, see the example:

https://github.com/mcostalba/Stockfish/commit/fancy_example


I'll update them in the update method for now.


Yes.


まとめテキスト/概要.txt

http/0.9より前のバージョンはないの？


Ok, so I managed to push the exact same commit as the previous one.
The only difference between this commit and the previous one is in Orientation.java at line 22


Runtime code must not use exit or directly print to stdout/stderr. Use g_error for this case.


this pul not working, i got error :+1:
ErrorException (E_WARNING)
HELP
rawurldecode() expects parameter 1 to be string, array given

ho to fix it? this is my code:

    'public function addProduct($data)
    {
        $wc_api = $this->_getClient();

        $newProductData = array(
            'title'             => $data['title'],
            'price'             => $data['price'],
        );

        return $wc_api->create_product($newProductData);
    }'


Final: Confirmed


@MacDada poprawiłem te dwie sugestie, a teraz pojawia się:

Fatal error: Access level to PdoUserRepository::createUsers() must be public (as in class UserRepository) in C:\xampp\htdocs\blog\model\PdoUserRepository.php on line 4


We could discuss this on Tuesday, I don't really understand what `InterceptedMethods` is supposed to do (for example, it will translate `null == foo` to `null.equals(foo)` which will result in NPE). In principle, I think it's nicer to keep transforms separate when possible, this phase does `v1 == v2 => v1.underlying == v2.underlying`, `InterceptedMethods` does `a == b => a.equals(b)`, it seems that doing both at once will make the code harder to understand.


まとめテキスト/概要.txt

http/1.0もcern目的？インターネットに広がったのはいつ？


Yes, I agree. If you come up with a simple way of doing it, go ahead.


Validations are message processors or MEL expressions executed in Message Processors. This should be a MessagingException and not a MuleException.


まとめテキスト/概要.txt

速くなってるならhttp/2いらないんじゃないの？
無駄を省く必要あるの？


this file is included twice


please continue the conversation at:
https://github.com/ControlSystemStudio/cs-studio/issues/1055


まとめテキスト/概要.txt

データ圧縮しても一番容量の大きい画像や動画の圧縮率はあまり高くなくて意味があまりなさそう


Thanks. Maybe it's time for me to finally switch to neovim :)


まとめテキスト/概要.txt

フレームというバイナリ形式は他のバイナリ形式とはどういう違いがあるの？バイナリ形式じゃだめなの？


This error needs to be caught and reported earlier, not when generating code.


was having a hard attack why it shows disabled. :+1: thanks mate


@ericnewcomer may have other ideas, but I would put this in the haml in a display:none, then clone it as needed: https://api.jquery.com/clone/

HAML->HTML is all done "compile-time" so you can't use HAML in JS and such and only in files called .haml.


邏輯問題唷～
「如果不是正式環境，就加上Google分析」？

App::environment('production')
是檢查當前環境的.env檔
裡面透過APP_ENV設定的環境是否與參數相同
一般環境主要分為local（本地）與production（正式環境）
這邊寫法就是檢查是否為正式部署的環境...

[Laravel 5 設定 # 環境設定](http://laravel.tw/docs/5.0/configuration#environment-configuration)


Internal subpackage missing. Check all the classes in the project. There are some that are not in the api package or in the internal package.


didn't things that contain `<nixpkgs>` get disabled by @edolstra purposefully recently? see 0e2257966


Oops. Submit a minimal pull request to upstream then.


Is it normal we have the almost same code in Products/CMFPlone/controlpanel/browser/quickinstaller.pt Products/CMFPlone/controlpanel/browser/quickinstaller.py ? Which view is really used?


まとめテキスト/概要.txt

間違を少なくする
前は間違いが多かったの？


Maybe it's safe to update http://wiki.magmi.org/index.php?title=Installing_Magmi under Directory permissions / Magmi upgrade already?


@eg04lt3r avoid compound variable names http://www.yegor256.com/2015/01/12/compound-name-is-code-smell.html
let's use `back`.


まとめテキスト/概要.txt

間違＝＞間違い


@eg04lt3r avoid compound variable names http://www.yegor256.com/2015/01/12/compound-name-is-code-smell.html
let's use `allowed`.


The main thing I'd like to check before this goes in is the effect on the code size of generated parsers.  Could you try it on GHC's parser and see how much bigger it makes the parser? (generated object code, not source code).

The token names come from the %token declarations, and don't necessarily correspond to the actual textual tokens.  Still, I suppose it's better than nothing.

You need some documentation for %errorsig.  I would call it %errorhandlertype (maybe?).


sstest.cpp的缩进太难看了，缩进不仅仅是为了好看，也是为了方便别人阅读你的代码，杂乱无章的代码很容易写错的。。。

美化代码技巧：
在vc里把代码全部选中，点“编辑"菜单-->"高级"-->”设定选定内容的格式"


Vu


The link to the upgrade guide looks broken (or your file is really called `upgrade-guid.md`; missing an **e**)


@eg04lt3r avoid compound variable names http://www.yegor256.com/2015/01/12/compound-name-is-code-smell.html
let's use `real`.


If I rebase this PR now by removing this commit from it, I think that github will lose your comments attached to commits that will get their hash changed (so all commits after this commit in the branch). This PR doesn't need to be merged right now so it's fine if you still have pending issues, we can leave it open and discuss here I think.


Can we move this check before the attributes checks? I don't like that users could still get structural information from files they should not.


First day of working on the google-homepage project.


Thanks!  Could you remove both commits. Then I'll merge the other two.


まとめテキスト/概要.txt

節の始まりに「また」はあまりすきじゃない


Might be simpler to have just have ```get_webhook_headers``` return an empty list, no switches and easier coverage!


まとめテキスト/概要.txt

出来＝＞でき


OK - just the line that Niccolo commented?


Shouldn't this class be the one defined in Mule?


It was an optimization (but the compiler will do it for us so not very important, especially if j is unsigned).

For MMX and SSE2, it worked fine because `(2>>1) == 1` and `(4>>1) == 2` (obviously `j<<1 == j*2` and `j<<2 == j*4`). The problem is that at a "coef" of 8, it stops working. `8>>1` is 4 but to divide or multiply by 4 we need to shift by 3, not 4.


I think we do not want to increment versions when we do not _have_ to; it makes it more difficult for deployers to maintain up-to-date tools.
@nekrut


まとめテキスト/概要.txt

何と何を比較して負担が少なくなったのかわからない


@eg04lt3r this variable can be inlined


I don't think we need an HSTORE here. This isn't anything we are every going to query against, so can just be a string that is read/written to JSON as needed.

HSTORE and such are only really useful when you want to do querying.


Put the extension in a variable to save doing the extraction twice?


Same here, stick to plain varchar. See Org.config or Channel.config for examples.


isNotNull


まとめテキスト/概要.txt

サーバのレスポンス？プラウザのレスポンス？


@MacDada ok nie zauważyłem mojego błędu. W interfejsie oznaczyłem jako public createUsers mimo, że w klasie jest to metoda prywatna.


You have a mix of isXXX and XXX methods. Pick one. To me seems better to use isXXX


Why not just a list of pairs? Or even more naturally just a dictionary?


No need to change it, but this are usually written as:
`if (!isNil QGVAR(windSpeed)) then {`


done.


Put the default addon id into a define or variable to make it easier to replace later.


@eg04lt3r this loop seems too much of a `busy loop`. can we add a very small sleep just to keep the cpu from going crazy? @yegor256 what do you think about this?


まとめテキスト/概要.txt

一度に送信可能なデータ量を抑制したら遅くならないの？


Thank you! :)


Nice job ! I got this bug today... all is good after the update ! :)


exercise 7.29.c
此题改进后有明显区别。
	总结-：测试时对大量数据进行测试，不要拿几百个元素来测试，这样的几百个元素，说明不了问题，有时会误导你，所以测试数据量要大。
	总结二：这题犯了一个很傻的错误，没注意，数组的边界，导致得到的结果总是错误，这样浪费了一段调试时间。


この辺のことは図で説明欲しいかも


I guess maybe this is because of the HSON configuration?

I say just have a field named ```headers``` that is a serialized dict. Then you don't need all this tomfoolery


まとめテキスト/概要.txt

この辺りで図による説明がほしいかも


exercise 7.30.c
	对10000个元素进行下列测试的到结果：
逆序文件：　time：0.2998350
顺序文件：　time：0.2638470
等值文件：  time：0.0026320
随机文件：  time：0.0052920
结论：
	1.等值文件运行时间最少是应为它在，插入排序是，不进行排序。
	2.顺序和逆序文件运行时间比插入排序运行时间少是应为，插入排序不工作。
	3.等值文件和随机文件出现差别是应为，等值文件划分时的二叉树比较平衡。
	4.逆序和顺序耗时最长是应为每次操作：
if(	a[l] <= a[l+1] && a[l+1] <= a[l+2] &&
	a[l+2] <= a[l+3] && a[l+3] <= a[l+4] &&
	a[l+4] <= a[r])要比较完全部的值才能得到结果，这样就浪费了时间。


this is my first comment


まとめテキスト/概要.txt

アプリケーションってブラウザのこと？


Well, merging the two phases you get:

   a == b    =>   a.underlying == b.underlying    if a,b are of value class type
                        a.equals(b)                                otherwise

I think that's nicer than having two transforms with ordering constraints between them.


まとめテキスト/概要.txt

ある程度ってどの程度？


So then this can be something like:

```python
return json.loads(self.webhook_headers) if self.webhook_headers else dict()
```


@eg04lt3r I'd also use a `CountdownLatch` instead of a `join` because we can call `await` with a maximum wait time :) That way we keep this test from running forever in case of an error.


まとめテキスト/概要.txt

HTTP/2に対応していなくてもHTTP/1.1で通信を可能として互換性を保つようにしている。


Keep this a URLField?


removed


Yes, it does fix the issue with stray attributes. It is probably sufficient.


まとめテキスト/概要.txt

「信頼性の高いエラー処理」
エラーしないの？エラーを直せるの？高精度でエラーを検出できるの？


If this line is going to be executed per message then it needs to be improved since the validator is going to be recreated per execution and will impact performance and will not allow the user to hold state in the validator.


No, the word is downsampling.


You mean `a.underlying.equals(b.underlying) otherwise`, this is needed so that if `a` or `b` is a constructor call, it will be removed by `VCInlineCalls`.


На мой взгляд, создание отдельных объекто для записи в ЗУ и считывания из него не совсем соответствует физической модели работы процессора с памятью.
Процессор и читает и пишет в одну и ту же железку, поэтому, возможно, лучше, когда в коде пишутся строки
"memory.write    memory.read", что легче воспринимается человеком при чтении. Но это моё субъективное мнение :)


spell as choose_port


Undown is not a word, but undownsampled is.


Can I just say how much I hate this


sure, i can. i did the easy due to the expected discussion on how to make it customizable..


Remove the todo?


Why dont we just dynamically add the proper number of pic boxes


Good catch. Sorry for my spelling error!


1: M111 unrecognized component name: assets
4: M190 line is too long (73 > 72)


@nicpottier yup exactly. this is tomfoolery around HSTORE, which doesn't support nested key-values.
will refactor to use a serialized dict, which will simplify a lot of this


3: L102 copyright year is outdated, expected 2015 but got 2014


24:1: F401 'warnings' imported but unused
30:1: F401 'RemovedInInvenio21Warning' imported but unused


Andreas is right on this one. You must not assume that the constructor arguments are like these.


Let's call it `lowerValueClasses`, or `lowerVCs` is that it too long.


Ya so keep ```webhook`` as a field, just add a varchar for ```webhook_headers```

Also, just FYI, we'd need a datamigration to move this over if we were going your route, otherwise we'd be blowing away all current webhooks! :(


4: M190 line is too long (73 > 72)


Sounds good, will do.


Oh actually, no, I'm wrong, you were just extra clever with the SQL. :)


まとめテキスト/概要.txt

ヘッダは何単位でつくの？
ページ単位？タグ単位？


まとめテキスト/概要.txt

サーバプッシュによるデータ送信「とは」Webサーバ側からWebブラウザに対して、あらかじめ必要となる
データを送信しておく機能で「である」

じゃない？意味が変わってたらごめん。。。


Alright. I think tricks used like this should've been commented in the first place...


まとめテキスト/概要.txt

ヘッダかヘッダーか統一


я таго ж меркавання


Hi, first of all thank you for providing us with this framework!
This commit is perfect timing for me for use in a current project.
However with the changes to ISObjectUnitOfWork, the SObjectMocks unit of work has to implement the new methods. I can make a pull request if needed.

thanks


I guess it still works in Rails 3? Seeing as you updated it in master, and it's a published gem.


done.


Could you bump the version and make a new gem release?


1: M111 unrecognized component name: assets


Yes, I see. These methods need to be polymorphic, which open another can of worms.


まとめテキスト/概要.txt

もう一文ほしい


Fwiw, 5.11 is the latest 5.x, but that isn't a dealbreaker for the PR :smile_cat:

```
opscode-centos-5.11 (vmware_desktop, 0)
```


Good point. I think this is worth a comment in the code.


まとめテキスト/概要.txt

ブラウザ，アプリケーション，クライアントとかいろいろな呼び方で書いてあるので統一


@dudekm No to spójrz na interface i co tam zadeklarowałeś.


OK, I'll add any later comments to the PR instead.


まとめテキスト/概要.txt

TLSってなに？


Alrighty! I've moved what WAS the new Lyte-Dark theme into Lyte-Monokai and brought back the old Lyte-Dark theme. Sorry for the delay and nuisance!

Anybody interested in using the new theme, change your instance of Lyte-Dark to Lyte-Monokai in your preferences. Anybody who likes things the way they are, they should stay that way!


Yes it does.


まとめテキスト/概要.txt

「Internet Explorer 11」、「Firefox 36」、「Chrome 40」などがある
の主語は？


Is the behaviour of this class something that we want to enforce ALWAYS?


Добавлен код для промежуточного узла (Meteobox == [433 Mhz] ==> Base == [ Ethernet ] ==> API Server).

Критическая проблема - обработка поступающих данных упорота настолько, что не обрабатывает отрицательную температуру.


On Red Hat and Centos 6, this code does not work as expected. In fact, in the /bin/bash the command command -v $time_bin has a return value of 0 (Zero)  even when the variable time_bin is just empty and the time command does not exist on the system.


I think you should check the exit code of Rust binaries when they panic. They should (logically) be set to some number above zero.


Trying to merge so that branch nn is newest and then I can merge nn back into master.  I've had merge conflicts I couldn't fix myself.


Sure I will change it to "undownsampled"


wikipediaは参考文献にならないので注意


In fact I meant `a.underlying == b.underlying` and recursively apply to the resulting equality.


fi


言葉の統一をしよう


當時只有簡單修一下
應該就是 env 的設定問題
因為剛好本地跟主機會相反
所以就先加 not


@Sfolt, very useful :+1:


ラウンドトリップは別の言葉で置き換えたい


Should you have also changed the Readme text back again so that it is back like e72afd6086ec13ba527ef704fb3d2818c5d8089b


It looks like you wanted, but the output is kind of **ugly**

```xml
<?xml version="1.0" ?>
<table https="false" securityLevel="any" xmlns="http://query.yahooapis.com/v1/schema/table.xsd">
        <meta>
                <sampleQuery>SELECT * FROM mytable</sampleQuery>
                <sampleQuery>SELECT name FROM mytable WHERE id=345</sampleQuery>
                <sampleQuery>SELECT * FROM mytable WHERE name='toto'</sampleQuery>
                <apiKey>http://josuebrunel.org/api</apiKey>
                <description/>
                <author>Josue Kouka</author>
                <documentationURL>http://josuebrunel.org/doc.html</documentationURL>
                <name>Test</name>
        </meta>
        <bindings>
                <select itemPath="products.product" pollingFrequencySeconds="30" produces="xml">
                        <urls>
                                <url>http://lol.com/services?artist=$</url>
                                <url>http://lol.com/services/song=$</url>
                        </urls>
                        <inputs>
                                <key id="song" paramType="path" required="true" type="xs:string"/>
                                <key id="artist" paramType="path" required="false" type="xs:string"/>
                        </inputs>
                        <paging model="page">
                                <start default="1" id="ItemPage"/>
                                <total default="10"/>
                                <pageSize id="Count" max="25"/>
                        </paging>
                </select>
        </bindings>
</table>
```

Sorry buddy i don't like it at all


I think self.twd should be initialized in init_qt
other handlers can be written for other GUIs or command line


Have you thought of tuning these parameters instead?


Why is this an string and not a Number?


Yes, I'll add one.


Sorry I was a bit in a hurry, here a less terse comment ;-)

IMHO it should be implemented in a way similar to what we do for tools verbosity:

```
tools.avrdude.bootloader.params.verbose=-v
tools.avrdude.bootloader.params.quiet=-q -q
tools.avrdude.bootloader.pattern="{cmd.path}" "-C{config.path}" {bootloader.verbose} -p{build.mcu} -c{protocol} {program.extra_params} "-Uflash:w:{runtime.platform.path}/bootloaders/{bootloader.file}:i" -Ulock:w:{bootloader.lock_bits}:m
```

in this case `tools.avrdude.bootloader.params` is loaded with the contents of `tools.avrdude.bootloader.params.quite` if the verbosity is off or with the contents of `tools.avrdude.bootloader.params.verbose` if the verbosity is on.

For the "warning level" setting we can do something like:
```
compiler.warning_flags.none=-w
compiler.warning_flags.normal=
compiler.warning_flags.all=-Wall
compiler.warning_flags.extra=-Wall -Wextra

recipe.c.o.pattern="{compiler.path}{compiler.c.cmd}" {compiler.c.flags} {compiler.warning_flags} ............
```


If you change [this line]( https://github.com/ndlib/sipity/blob/a958cb65b35e707e82975db2331bf5dabeb660f2/spec/forms/sipity/forms/work_enrichments/access_policy_form_spec.rb#L124) to have a human_model_name, then I believe the following can replace the 8 lines you have below.

```ruby
its(:human_model_name) { should eq(persisted_object.human_model_name) }
```


Whoops — didn't mean to commit that, and didn't realize there was a local settings file! Will use this from now on.


I named this function badly, too generic. It should be isReportStorageDirEmpty() or something similarly non-ambiguous.


#### KISSS :
* Keep
* It
* Simple
* Stupid


是呀...
網站主機上的APP_ENV居然是local....


Okay. I went through the event handling code myself, and it seems that the code in the repo is indeed faulty. I'm going to merge this, and if there is in the end a problem with it, we can just fix it later.


probably should update comment as well :)


Now that you mention it, errors with the input should set the exit code to 1 (see [driver/error.rs](https://github.com/msiemens/RusTiny/blob/9f9e2c630956df09a91074acefd6f8e31f6adeda/src/driver/error.rs#L52)), but panics should set the exit code to 100 (see [rust: libstd/rt/mod.rs](https://github.com/rust-lang/rust/blob/9539627ac76ca37d617a329dbd79c50c59cf59ee/src/libstd/rt/mod.rs#L50)). Shouldn't be to hard then.


Is this class created per message?


May want to move all of these to `config.js` before someone starts posting to that account on your behalf!


gg


我改成production了
話說沒有.env會怎麼設定?


Yeah, I have a note in IDataStorageManager to just get rid of the method entirely.  We don't have to expose it directly.

https://github.com/crankycoder/MozStumbler/blob/features/1581-idatastoragemanager_refactor/libraries/stumbler/src/main/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/IDataStorageManager.java#L30


I don't think that you wanted to commit changes to the `Gemfile.lock`, did you?


Syntactic error in markup, but this was probably not intended.


Why stil require it?


Gnu time does not support the --quiet option


That has already changed, we're using reflections now (see current develop).


I would use a Triangle Mesh here as an argument


Was about to make the same pull request. Thanks for the change


OK can liao


Ah, ok.  Thanks for the explanation.  I'll propose some renaming suggestions as part of the refactoring work.


"So you like/love Laravel, you probably also know..."
I would change that to:
"If you like/love Laravel, you probably also know..."


The problem is that during shutdown the check is completely invalid as s.Ok() might be false... which will require some serious changes to the rest of the code.


All OK, thanks.


Ah k.


tested and working


Maybe make these DIDs PrismDIDTypeXThing instead of 0x20044?


This looks okay to me.


Pulling the current version, I think this is great.  I might send you a separate pull to switch over the test enums.


Neat. I'll squash it in a few.


q


FIXME? Seems like a user-visible bug?


Need to update and verify this in risk_assessments.js and workflows.js files too.


Except that you don't use opening question marks in English.


@schism by out of circulation you mean deprecated?


Yea, Unix "best practice"? :)


Yeah okay I'll open an issue.


It is recommended to use "equals" and not "==" for the comparison of objects in the following lines of code:
• MajorityRuleStrategy.java, line 41, line 85
• MoreUsedStrategy.java, line 84 and 85
• Play.java, lines 34 and 37
• Register.java, line 20 and 22
• UtilityMatrix.java, lines 67 and 69


MoneyDJ:
http://nbviewer.ipython.org/github/light1735/No3-Project/blob/master/MoneyDJ.ipynb


I'm not too happy about loosing save and loaddf. I understand the rational, but those functions were convenient to save preliminary results. I used them in self-made cache/make mechanism where data frames were only recomputed if the factors that produced them changed.


Truputi pasimeciau su pull r. galimybėmis :-)
Mes aš i savo branchą dar kt failą įdėjau.
On Apr 10, 2015 2:13 PM, "sirex" <notifications@github.com> wrote:

> Ar planuoji šitam pataisymui kurti pull request?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dz0/it-brandos-egzaminai/commit/daaaea4644cd0ddbe562d647f6121ca0a41efe37#commitcomment-10663950>
> .
>


You don't need the `<pre>`:
```
Example:
    [{row:0,column:1}, {row:1, column:null}]
```


nope, it was only committing locally


same


right


Yes, you're right. Good catch. I included `display.ini` in 9339ef.


Hmm, interesting "bug". I agree with the all the issues noted, and this case is exactly the [`InputStream` case which they left in](https://github.com/google/guava/issues/1118#issuecomment-61354584), so it should be safe to use an utility method (I vaguely remember that PFD issue too... and found it #157). Also I'm not saying to replace all closes, just the ones that already ignore the exception, which may also help uncovering potential bugs, like `//TODO: what if this throws?`...

Also `cleanup`'s doc says:
> This method will be called in a finally block

I'm always confused when I'm trying to be a good boy and free all resources in finally, but then freeing can fail, so what's the correct course of action then?

This made me stroll through my usages and I'm mostly using it for inputs, however I found two missing flushes, thanks guys :)


`Illuminate\Foundation\Application`裡面的一段
沒設定的話，自然就不會出現true
預設應該是空字串或null吧

```php
	public function environment()
	{
		if (func_num_args() > 0)
		{
			$patterns = is_array(func_get_arg(0)) ? func_get_arg(0) : func_get_args();

			foreach ($patterns as $pattern)
			{
				if (str_is($pattern, $this['env']))
				{
					return true;
				}
			}

			return false;
		}

		return $this['env'];
	}
```

不過沒有.env應該無法執行程序
部署時一般都要把`.env.example`複製為`.env`並設定完成...


Eh not really, most of these are just stylistic changes. xD


Excellent! Very helpful of you. :angel:


No worries.

As an aside, the `local_settings.py` style is common in Django projects:

https://code.djangoproject.com/wiki/SplitSettings

The standard (I think) Tornado method is to use command-line flags:

http://tornado.readthedocs.org/en/latest/options.html

I prefer the Django approach, but it would be simple enough to support both if there's any interest.


@inpercima this violates the principle of "Defer Controller Logic to Services" -- http request should be moved into the service.

see https://github.com/johnpapa/angular-styleguide#defer-controller-logic-to-services


Then line 65 should be 4 instead of 3.


I would vote for == as its a lot easier to read. I used StringWrapper in
benchpress a lot, but the code is ugly...
On Fri, Apr 10, 2015 at 1:37 AM Victor Berchet <notifications@github.com>
wrote:

> @vsavkin <https://github.com/vsavkin> should we use StringWrapper.equals()
> or == here ? (=== would return false with interned string in Dart)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angular/angular/commit/61cb99ea42ec09d4549de6c5f65e0bd502c4a7d7#commitcomment-10661688>
> .
>


nice commit, reads really well and is clean :)


It's not so great to have this buried deep in the code, I'm not sure how to put it anywhere else in JS though. We can refactor this later....


The code is not consistent with the same type of nomenclature, in the case of the variables make use of "_" to separate words or make use of capitalization arbitrarily. Please choose only one of two ways.


Нельзя удалять.

Функционал не просто так пишут, наверняка его будут доделывать.
Так что необходимо было просто закомментировать.


"So you like/love Laravel, you probably also know..."
I would change that to:
"If you like/love Laravel, you probably also know..."


Fixed.


"Forge ease up" -> "Forge ease**s** up"


Any specific reason we are using malloc/calloc/free here and the Ruby functions in result.c? Comes down to what you said re: current best practice for extensions?


The preferred solution is to use JLD from HDF5.jl to save DataFrames, since unlike `serialize` and `deserialize` it maintains compatibility across Julia and DataFrames versions. You can also call `serialize` and `deserialize` directly in your own code if compatibility is not a concern.


@vitork bd5865b72fd346165041ec288eb28c5569fb8422


composer update -> composer install (from composer.lock file)


It is recommended to use "equals" and not "==" for object comparison


^--- Fixed per https://github.com/qzind/qz-print/commit/9bcf0539b198243e2bddfe2d6775f3d62262dd04


ans -> and


The cost of performing a rescue every time redis is invoked for pre Resque 2.0 is pretty expensive.  I think we should perform a version check when this file is interpreted.  Maybe something like:

```ruby
if Resque::Version =~ /\A2\.\d+/
  def redis
    Resque.backend.store
  end
else
  def redis
    Resque.redis
  end
end
```

I also noticed while cruising the 2.0 branch that `Resque.backend.store` is the safest way to access redis as the project evolves.


One option is to take the removed code and put it into your own external package. Maybe your self-made caching code would go well with that in there.


a interface -> an interface


chamo porque metes el operador en la vista? lol


Reverted the commit in a new ACPICA version, 20150410.

Thanks for catching this quickly.
Bob


I'd drop the comma: "But what happens if ..."


This still misses renaming where the function is used.


Or you could leave as is and not have pointless code churn.


surrigate -> surrogate


Fixed, thanks.


this portion of code is bad


new line code


primarly -> primar**i**ly


Let's simply this expression slightly:

if (ccittFaxDecodeParameters.K >= 0) {
  ...
}
else {
  ...
}


"if I've chosen to use Forge to avoid"
maybe
"if I've chosen to use Forge **it was** to avoid"


For the top-border and bottom-border, I'm sorting the annotation elements by x co-ordinates.


"each of the developer" -> "each of the developer**s**"

end sentence with a dot


- For the equalpoly function it's probably easier to use the clean function in spot. So, if you have two polynomials p1 and p2 you can do:

c = clean(p1-p2,tol), where tol is some tolerance for the differences in coefficients.

c == 0 if and only if p1 and p2 are equal up to tol. This might end up being faster than computing the hessians and has the advantage that it works for non-quadratic polynomials too.

- For choosing a degree for the multiplier L1 you're currently using:

options.degL1 = deg(DV,p_xp);

I think a better choice would be:

options.degL1 = deg(DV,p_xp) - deg(V,p_xp);

This would balance the degrees of the two terms in your sos constraint.

- Looks ok to me apart from that.


des is ne geniale Idee, sehr gut numgesetzt


You're so right dude !
Sorry for the late response.

Well, I was uninspired, but yeah.

And you're also right for the BEM, the thing is, we try to make an other simple methodology with @clementgalidie, inspired by the BEM, and our own css syntax methods.


**lightbox.css**
why is he here, what is his role in?


Thanks. Do you happen to have an example PDF with CCITTFAX3 compression? If so, please attach. It would be nice to have some unit tests for this added functionality.


If


:blush:


Nice!


you should store your `ssh` aliases in your `~/.ssh/config` file

e.g.

```
Host cs
    HostName linux.student.cs.uwaterloo.ca
    User v6lai
```


Skip useless processing.


Yes. That’s what I’m doing for now. I know I need to explore a better option for the long. Thanks.
> On Apr 10, 2015, at 11:41 AM, Tom Short <notifications@github.com> wrote:
>
> One option is to take the removed code and put it into your own external package. Maybe your self-made caching code would go well with that in there.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/JuliaStats/DataFrames.jl/commit/131cdde00dceba4826f1dde94aa33a8ba47a53c4#commitcomment-10668753>.
>


In the case of variables it is recommended to use the naming standard capitalization, starting with lowercase and the second word starting with uppercase.


Hi Charity,
 Sorry if it is confusing, but it's just the way the cohort query builder works: the target table can be specified something outside the cdm schema or the results schema, and in MSSQL world it could even be database.schema.tablename so the @targetSchema in your example wouldn't actually even be a schema, so it is just more straightforward to just put the value of the fully qualified cohort table in the cohort.targetTable property.

As far as the temp tables: that's very bad if the temp table names aren't different between invocations.  It means that 2 threads processing separate cohorts will create the same table names, and you'll get an error when one thread tries to drop he table that the other is executing.

This problem is probably because I'm not calling the sql translate method with the proper oracle-specific params.  Here's what I'm doing in GenerateCohortTasklet:

``````java
      CohortExpression expression = mapper.readValue(this.task.getCohortDefinition().getDetails().getExpression(), CohortExpression.class);
      String expressionSql = expressionQueryBuilder.buildExpressionQuery(expression, this.task.getOptions());
      String translatedSql = SqlTranslate.translateSql(expressionSql, this.task.getSourceDialect(), this.task.getTargetDialect());
      String[] sqlStatements = SqlSplit.splitSql(translatedSql);
      result = GenerateCohortTasklet.this.jdbcTemplate.batchUpdate(sqlStatements);
`````

However, in getRunCohortAnalysisSql, i see this:

```java
        sql = SqlRender.renderSql(sql, params, values);
        sql = SqlTranslate.translateSql(sql, getSourceDialect(), getDialect(), SessionUtils.sessionId(), getOhdsiSchema());
```

I'm never passing the sessionId in, so that's why you are probably seeing the one value being reused.  Do you want to try to add the sessionId call to your local branch and see if you get different temp table ids?  If it works, I can add it to master.  If setting cohort.targetTable property to {schema}.{cohortTable} also works, then we won't need this branch.

I might be able to remove the cohort.taretTable property...i'm looking at the code now. At one point we wanted to be able to specify either the CDM's cohort table to write to, or the Ohdsi_result's cohort table.    But I think doing so adds another complicated layer to the process.  So, if we can say that webAPI always writes cohorts to the same table, i can make it so it builds the name of the table as getOhdsiSchema() + '.cohort'.


This is a contentious topic. To include on not include the packages?!?!

I prescribe to the later thought (not include), especially for open source projects.


done committed


Funny :-) I wrote a blog post on gitattributes just weeks before this draft: https://hannesvdvreken.github.io/2015/01/14/gitattributes/


@BlackNoxis: No, as in it wasn't advertised, registered with the g.o overlay list, etc.  I see someone mentioned it on Pentoo's bug list, which may have precipitated more attention.  It's imperfect, but I was just using it for my own "private" purposes and its imperfections were mine alone. Regardless, it's a dead horse at this point; please just consider checking with developers in the future before presuming they want to be part of a large "community" repo.

I also see the Plaso ebuild was dropped post merge, which is kind of foolish.  Most of this repo these days is centered around enabling Plaso.


@tommy2269 - great idea! :O


pushed 0.7.pre


Very polite


In general attributes, variables and constants statement have no comments for understanding its use.


composants -> components

I would write package names with lower cases only: "symfony/console"


Para cargar archivos estáticos, hay que cargar staticfiles al principio del archivo (linea 1) y aquí importarlo con la función static. P.ej, para acceder a /static/css/mihoja.css tendríamos que escribir…
```
{% static 'css/mihoja.css' %}
```


versionnable -> versionable


awesome @coryvirok


What has been changed here? This line is not mentioned in the commit message.


hey man I'm just wondering what's going on between y'all too


We recommend adding a comment in the header of each class, allowing general understanding of the use thereof.


Great post, although I would have expected more Rocketeer stuff and less .gitattributes options.


Ok. Embere válogatja, ki mikor fogadja el, nekem van 2 és fél hónapos pull requestem is (jan. 24-től vár elfogadásra: https://github.com/kalgasnik/lightdm-another-gtk-greeter/pull/9
Egyébként én is küldtem most egy pr-t a retrovolhoz, csak hogy ne unatkozzon a srác :)


I too can copy and paste Wikipedia. Arguments 1, 2, 4, and 5 in the 'for' section directly above what you pasted.


Does this fix the merge bug?


Should localize validation error messages


hey does she have a facebook


Search&Replace gone bad?


y


Does this make a local git clone into the build64 folder? Maybe is better to make a copy, otherwise we can not run later only the 64bit compilation. It will be always depend on the 32bit git clone/update.


Sobre bootstrap, para no petar el repo suelo incluirlo desde el CDN.
```
<!-- Latest compiled and minified CSS -->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css">

<!-- jQuery over CDN -->
<script src="http://code.jquery.com/jquery-2.1.3.min.js"></script>

<!-- Latest compiled and minified JavaScript -->
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/js/bootstrap.min.js"></script>
```
Incluyendo esas líneas, cargaría las librerías desde internet y no se nos llenaría el repo excesivamente. Cualquier modificación sobre el CSS/JS de Bootstrap la realizo más tarde (quizá en otro archivo CSS cargado después [no antes] del de Bootstrap, redefiniendo el contenido de las clases/ids).

OJO: Esto tiene el inconveniente de que si desarrollas sin internet (en el tren/bus) debes tener el contenido cacheado.


and how do you know each other


code style changes (pep 8 )


ping, bcast, and math.


Could we make these HTML tags lower case. Also the a tag is not closed.


The code is not consistent with the same type of nomenclature in the case of variables, some make use of "_" to separate words or make use of capitalization arbitrarily.


Oh wow, shameful. Thank you Michael, I appreciate it!


Shame at misspelled commit title.


attempt_more_exception_reduction (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I did refactor this in 9325d9079a435ad1850aaaae0e1cab5468ac0cb0


fast-forwarding master to borshop-integration-210-bk-j186-activesupport-cache-readme = 77270dd2


should register and unregister be private methods?


@yorikvanhavre Curious can you import/export this file and commit?

I'd like to see if these material values survive a roundtrip upon import into Revit.

Video workflow, if you need it: https://www.youtube.com/watch?v=YE3BjTPBMJI


The `this` isn't required anymore, as it's a base class method, not an extension method.


See above.


And above.


This is now fixed. The Lexer now gives the parser jtkInt and jtkLong so that Long-Getter doesn't need to guess anymore.


Ah, I checked the history and saw that django-taggit had been an `==` rule ever since we created setup.py, so I figured it had been copied over from a requirements.txt file without thinking. I don't recall any breaking changes in django-taggit...

I think generally we should try to use `>=` rules unless there are breaking changes that we already know about, or expect (e.g. major Django releases). Wagtail's own dependencies should ideally be as permissive as possible, so they don't conflict with the dependencies of other packages that might be part of a Wagtail site (django-oscar, say) - it's then up to the site developer if they want to pin to specific known-good configurations.


__API Blueprint syntax error on line 1__: expected API name, e.g. '# <API Name>' (Autogenerated message from apiary.io)


Why only print the message (sml:...) if not SML_FOUND? The first part is fine "if ENABLE_SML" but why then only in error case? Isn't it quite nice to see which include and library path is used?


Semantics, but I think `from runners import lock_helper` is more readable. :)


changed


I just set it to a made up number. It is used for the stubbing on L11.


should the default dispose method be modified to handle deatching?  I think yes.  What happens if you dispose of a view without detaching it?  The injection site will vanish??


return_value_handling (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-2.98%25-red.svg)


private var _speed:Number = 0;


test


I like the slice idea. I mostly implemented the feature since I wanted to look at rather small plain text files with maybe up to 50 lines.

A size limit sounds good! Also Michael said we could have a http header that prevents caching of the file.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/2e769d81cf90ce648521146f69bb7fd2c77b3c0d/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/2e769d81cf90ce648521146f69bb7fd2c77b3c0d/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/2e769d81cf90ce648521146f69bb7fd2c77b3c0d/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/2e769d81cf90ce648521146f69bb7fd2c77b3c0d/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/2e769d81cf90ce648521146f69bb7fd2c77b3c0d/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


And System.lineSeparator() isn't valid why?

http://docs.oracle.com/javase/7/docs/api/java/lang/System.html#lineSeparator()


Interesting, my config does not make much sense, by default it just watches and then ignores the other commands.

From my personal workflow, 'watch' is what I most frequently want to do, so that is what I have as default. Is that not how it is generally used?


Why not just reapply that patch? ;)


- Ajout du début de l'UserController (sous test non connecté)
- Refonte complète des entités.
- Correction du code.


Nice catch


Consider putting a `^` at the start of the regex just to be safe


Readme please!


Since when do you care about number of lines.

As written `Price.GetAccessToken()` is completely opaque, you call it when you want to use an access token and it will handle expiry and getting a new one behind the scenes for you. You don't have to worry on each use about checking some variables and conditionally taking some action, a single call to `Price.GetAccessToken()`'s got your back.

 When you put access_token and token_expiry in as class variables you're indicating that they should be used outside the class or may be used in more than one Price method. Instead, using the technique above strongly indicates that those variables should only be used inside the one method and nowhere else.


Issue #299


This comment is lying ;-) And it was lying before as well ;-)


@bnoordhuis: do you think we may want to autodetect it on the Makefile level? or should we just assume everyone on IA32 has SSE2 now?


who do you want to reach with "hello all"? Note that this is your repo.
why is this needed?


Is this indent intentional?


Я начала исправлять пока только с использованием функций, без классов.
Попыталась сделать "красивое" поле, чтобы сверху и слева была нумерация ячеек.

Поскольку я не очень понимаю весь алгоритм подсчета/пересчета значений в ячейках поля, вопрос:
Если я проигрываю на первом ходу, поле выглядит так:
Game over!
------------
|11        |
|*1    111 |
|11    1*1 |
|      111 |
|          |
|       111|
|       1*1|
| 111   111|
| 1*1      |
| 111      |
------------

Если я проигрываю на третьем ходу, поле выглядит так:
------------
|31        |
|*1    111 |
|11    1*1 |
|      111 |
|          |
|       111|
|       1*1|
| 111   131|
| 1*1      |
| 111      |
------------

Оформление, конечно, поползло, но суть понятна.

Что происходит вообще? Откуда тройки? (Ладно, это понятно, мы постоянно пересчитываем значения в ячейках) Зачем тройки?

P. S. и не надо мой код на занятии показывать! Синдбада инфаркт хватит от такого...


Ah, guess you copied it.


The asserts I had in mind are:
    assert(accidTop < accidSpace->size());
    assert(accidBot >= 0);
But I can see it should be OK. However, asserts do not cost much as compare to debugging time...

My problem with currentX + ACCID_WIDTH is: you are looping according to a max size of an accidSpace line (currentX < xLength), but then have an access to [currentX + ACCID_WIDTH] in an accidSpace. So in theory, if currentX is the last position (xLength - 1), then you are looking outside it at line 1488 and 1489 and 1497 and 1498. So it seems to me that you are assuming you will never be there because of the _content_ that will before that make you exit the loop (1490 and 1499). This is why I guess you had to add an position in each accidSpace that will always be false and make you exit the loop. Am I misunderstanding something?


Hola mi estimado Josue, apenas vi tu codigo, esta muy bien :D


return_value_handling (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-2.68%25-red.svg)


Hi, I also met a "Permission denied" error when call Debug.startMethodTracing();

Hava you already fix it up? Could you give me some hint?

Thanks.


rofl XD


consider using Python for this instead and referring to the site packages dir symbolically:

```
import site
packages_dir = site.getsitepackages()
# use Python to replace string and write
```

You could do all of that with a `python -c "...."`

That'd make this Dockerfile a little less brittle when upgrading to a new Python version (e.g. 3.5)


@Art1Sec8 with the newest version of meteor-tool (meteor-tool@1.0.44) issue seems to be fixed


Yes, I think you're right.
Something for `v0.0.2`! :)


:rocket:


You may want to revisit this commit as I had changed all this stuff in the latest version.


@zachary-williamson

This is wrong.  It needs to be in a source file "*.cxx" file.  If it is in the .h file then the definition is still placed in every single compilation unit.


shouldn't this acceptance test actually test that the TZ was changed?


let's use stronger language here! ;)

`This document describes ...`


return_value_handling (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-2.98%25-red.svg)


@zachary-williamson Line 162 still needs to be put into a .cxx file so that it only shows up in 1 compilation unit.


@mathiasbynens does bash completion work as before after installing version 2? Mine seems broken...


Maybe `openssl/Configure perl script`?


I've seen these empty placeholders several times. I find them quite ugly. Couldn't they be removed and a default value used in the base class?


@zachary-williamson These all need to be moved to the .cxx source file.  They can not be in the header file.


Too hard to use


@LICEBMI contact table have a json field in order to offer flexibility on the contact fields, I would strongly recommend you use that. This will keep the system more flexible.


I'll fix it.  Most comments are lies.


If we must do dom creation ourselves, it's definitely cleaner to put this markup in the haml as Nic suggests, just use the hide class.

```haml
#templates.hide
  .field.webhook-header-pair
    .field.header-key
      %label{for:'header_XXX_key'}
        -trans "Header Key"
```
...and so on, then something like..

```javascript
var ele = $('#templates > .webhook-header-pair').clone();
ele.find('label').each(function(){
  var label = $this.attr('for');
  $this.attr('for', label.replace(/XXX/g, 1)
})
```


attempt_more_exception_reduction (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (335 of 335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Anti Human


True, I forgot that it won't insert hyphen between prefix and name.


Agreed.


Thanks for review!


le mensonge


We need to remove mesa from DEPENDS or remove the mesa dependency from mhwd... or it falls to install the correct driver in the livecd.


return_value_handling (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (336 of 336 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Btw. since this is a lib, shouldn't there be a patch made for it for reference?


And the ones that are not were written by cpt. Obvious...


@eomuraliev, is this Foo similar to the role of a fixture? If so, what's the best way to manage and use it?


On the other hand, since we guarantee 80 bits of entropy for temporary file, the `err == nil` condition probably won't ever happen.


Why is this here?! Remove in next CSS commit.


still need to line up the last document.write statements.


Yes, you do need both pieces of information.

But we tried to avoid conflating those two types
of information (whether the action is supported
and whether the state of the object/system is good for
this action) for the other aspects of this
project, like, unavailableDependencies, and
it seems like we should be consistant with this.
DeviceAction constructors already check resizable
where appropriate.

- mulhern

----- Original Message -----
> From: "David Lehman" <notifications@github.com>
> To: "mulkieran/blivet" <blivet@noreply.github.com>
> Cc: "mulkieran" <amulhern@redhat.com>
> Sent: Thursday, April 9, 2015 7:05:34 PM
> Subject: Re: [blivet] Add a method to check if resize is supported. (8f85c8d)
>
> Why should they be separate? You can't know whether one can actually perform
> a resize without both pieces of information, no?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mulkieran/blivet/commit/8f85c8df94fe2363a8a2372363aa51afdd90768f#commitcomment-10656869


this is not correct. If the validatorSource specified a classname, then yes, a new instance is created each time since we can't make assumptions on that validation been thread safe. However, the user could have specified a ref in which case the instance is not recreated each time and it can have state


return_value_handling (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-2.98%25-red.svg)


whitespace