Defensive. Would not expect this but I need to access the last element. Better safe than sorry.


`extension-points` instead of `extensionpoints` (hard to read) please?


Yes, how about a PR against the original package?


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I reverted this -- you should be using the 'Lottery 2' file, not the original lottery file.


`self.frameEvent.emit()` ?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.351](http://teamcity.monogame.net/viewLog.html?buildId=6399&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 484, ignored: 6 Build time: 00:15:02


IMO, the "composer create-project ezsystems/ezplatform" should work like a charm.
Maybe to setup soem travis test for this?


instead of `(doall (map ...)` please just `(doseq [extension extensions] (trace ... extension ...))`


@as-cii you cc’ed me on this commit specifically because?


@NathanMalo Je pense que tes codes HTTP sont mauvais


`self.handler.writeErrorEvent.on()` ?


#bug
Why do you need additional typedef?
If you will rename it, will you rename each doubled typedef additionally?


Thanks for the report.
The error occurs in defining default value of `mime-edit-mime-version-field-for-message/partial` in `mime-edit.el`.
Should be fixed at https://github.com/wanderlust/flim/commit/db0f915335b7fa4838497c8292643d9f626e607c.  Please test.


`reset-default-hover-on-active-editor!` called then the result is called again. Normal? it's not used like that some lines above


yes it should, but when we tag relies on dev packages you get this basically, something to improve on for next tag I guess.


You're welcome.  Glad to help.


@mkwork In this case there is no compilation success.


I understand your comment now. It looks like it is the same thing as issue #9. I have not had time to investigate yet.


Looks good! ;-)


Are these required for all scala modules? Can this be put in spark-shell pom instead?


@ericam I'll let you decide whether this warrants a new release.


@tylernappy  Would be easier to wrap that around the URL, saying like "Some actions are not attached to a specific resource, like /contact/managemanycontacts. In thase case...". Thoughts?


`given` not `give` ?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.354](http://teamcity.monogame.net/viewLog.html?buildId=6403&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Bad name, not logically splitted files and subprojects, anyway is there difference between file and directory paths? What are them?
Better soulution is
```cpp
//typedef std::string Path;
typedef boost::filesystem::path Path;
typedef std::vector<Path> Paths;
//or
typedef std::vector<Path> Files;
typedef std::vector<Path> Subprojects;
```


Code smell


Strange. I will have a look soon.


I haven't released this change. How is it that this is breaking stuff?

Do you have stack trace?


remove `the`?


Responded in the PR


Looks good. But, the html and css files need to be at the root of the folder.


Is there a reason why a raw type is being used here? Typically, they should only be used for compatibility reasons.


@drewpts. may be it all because you don't point right scope in function definition signature ?:)


We update the applied index in two places; here and at line 875. This should be extracted into a method to make sure they stay consistent. I think we want to update r.appliedIndex even if the write failed (see #681), though, so we don't actually need any change here.


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


*Get, right?


just write `(map :state-mask (read-descriptors-from-preference!))` instead of `(map #(%1 :state-mask) (read-descriptors-from-preference!))`?


Ideally yes - though, `wp_json_encode()` was only introduced in 4.1.0 so we'd need to bump the minimum core version as well.


EOF is a special signal that means end-of-file.

Since MAc OSX is based on Darwin, which is based on Linux... -EVERYTHING- in the operating system is treated as a file.  Devices, folders, files, inputs, outputs... Linux treats everything like a file.  So, in order to tell a program you have are finished with it, you have to transmit an End-of-file signal, which is Ctrl + D


Не знаю. Так устроен инструмент


This wasn't a deliberate decision; I just habitually pass `&ms` when it is available and nil when it isn't. I guess this should probably not touch the stats.


can you add licence info?


this is a bullshit project. it doesn't need fallbacks. in another environment you are both right. but this project deserves to be as shitty as it can get. and i don't like my code being changed without prior discussion.

sure, this is bullgit and everybody should be able to change everything. but, when creating a project you have an idea in mind, it's like a little shitty baby you give to bullgit. i like "my" projects to be simple stupid and not usable in production at all. i've put **my** in quotation marks because at the very moment that i publish a project to bullgit it's not *mine* anymore, it's **ours**. from that moment on we share *parenthood* for that project. thus i like to discuss what we do to our shitty babys beforehand and not just change them.

i might be exaggerating a little, because this was no big change and no big deal. but this is my point of view and i hope you respect that


I didn't say it was a regression in last release. But witth latest SNAPSHOT I was unable to create a pull request (HTTP error 400, invalid json body or something like that). Just try to run test PullRequestTest#createPullRequest to reproduce. Sorry if I was not clear.


Thanks! It lacks one more thing, but the next minor (0.8.0) release is coming out soon :)


whats the reason transfer item's are fetched differently for receive (through the stock transfer) than update (without a stock transfer)?


86019526_IgNullChoice (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Please make your lines shorter.
Why not just have it be "one of the first videogames".
"The aim of the goal"?
The goal is not to hit the ball. That is the means.
"Pad" not "bat"
The explanation of the games dosen't make sense.
"if and only if" is awkward when you don't need such precision
Suddenly: bot.


for `ns`, you can mix metadata and regular docstring, e.g. have `(ns ^{:author "Bar"} foo "the ns docstring ..." ...)`. If find this clearer: the docstring always where expected, irrelevant of whether there is additional metadata or not


Yes, it should be. At least it's not possible to pass the return value of hrtimefp (double) to hrtime (accepts object).


EDIT: Updated copyright year.


This is uninteresting.


incorrect indentation


Good catch. Insert "forest for the trees" comment here ;-)


instead of `apply hash-map` consider using `(into {} ... (mapcat ...)`


clock cycle?


Add links in this section


And what did you find by doing this?


This sounds nice, until you realize that the drivers are not of good quality.


haha
> 27 Apr 2015 kl. 23:51 skrev Aleksander Wasaznik <notifications@github.com>:
>
> This sounds nice, until you realize that the drivers are not of good quality.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/helliio/Energy-Efficient-Computer-Systems/commit/d19348a96226ce4acaaa23478eeea83b4874fef5#commitcomment-10927408>.
>


No need to declare this as 1 since you are forcing it to be one at line 36 with each declination of maxValue.


or directy a reduce:
```clojure
(reduce #(assoc %1 (keyword %2) (element-attribute element %2)) {} (.getAttributeNames element))
```


Follow the styleguide. https://github.com/jortechve/styleguide/tree/STYL-1#variables.
We would use just one var for all variable declaration


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.354](http://teamcity.monogame.net/viewLog.html?buildId=6403&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 484, ignored: 6 Build time: 00:14:41


don't call `hash-map`, directly use `{ ... }`


should probably be "Title" or "Header." if it's "Read More" i'd expect it to change to "Read Less" or disappear on expand.


That's a typo. Thanks for cathing.


don't call `hash-map` use the literal `{ ... }`


Nice compensation of PEBCAK. :D http://en.wikipedia.org/wiki/User_error


Typo too here. Saw that too late. will fix.


I understand, but I edited this because it did seem like quite a useful thing for the idea I had of the konami code on bullg.it, and because I just did the research for @dervondenbergen's prank on school. I knew this project existed, so I thought "why not make it better". It's not because the idea doesn't have a lot of uses, that it's forbidden to make it more useful.

I understand that you prefer this to be a project with a simple use, but my opinion is "why not improve, even what isn't obviously improvable"


On every commit, you need to give a short summary of what you did.


86019526_IgNullChoice (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Right. Deserves to be there by default.


smaller_make_shared (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


(Peter Yoachim) Maybe leave off the metadata and the </br> to make the layout a little more compact?


Even more than just following Chapter 8 of The Joy of Clojure, this structure is how Clojure handles XML


(Lynne Jones) I'll see what that looks like.


(Lynne Jones) Cleaned up.


(Lynne Jones) Done.


(Lynne Jones) Also changed the order of 'mean' and 'median' in the summary statistics.


Can you think of a way to turn getHeight and getWidth into a single function called captureNonZeroValue?


(Peter Yoachim) Bugfix/OPSIM-578 driver fails if matplotlib exception
close figures when combining histograms


I don't know if it's me but this seem to have broken picons on the channels.


(Lynne Jones) Feature/OPSIM-596 add less than cumulative version
Turns out it was just a change in documentation and small tweak to SSTAR. So skipping review. ....hmmm.

* Change in doc for baseSpatialSlicer histogram.
Pointed out that 'cumulative' value < 1 will make the cumulative include "less than" instead of "more than".
* Update to sstar to make nvisits histograms cumulative the 'less than way'.


(Lynne Jones) Feature/OPSIM-466 move resultssummary info into a
Creating resultsDB summary tables and reorganized sliceMetrics.

* Finished adding resultsDB (sqlite database to track outputs and summary statistics). Updated driver to match. Updated unit tests.
Separated baseSliceMetric into proper base class and RunSliceMetric class. Updated comparisonSliceMetric to use new BaseSliceMetric + is much simpler!
Updated driver to match these changes too.
Found bug in BaseStacker (fixed - was not adding module names to stacker names in registry)
Found small bugs in exampleNewStackers and exampleNewMetrics that are fixed.


(Lynne Jones) Hi Peter - there are two small conflicts with current master, but I think I'll wait until you merge your branch to master and then fix all of them, since there will be more and these aren't making this unreadable. Ok?


(Peter Yoachim) Why not just return a rec array here?  Or maybe a printSummaryStats method and a getSummaryStats method.


(Lynne Jones) Agreed: we'll fix this later.


I get this to work if I do:

```go
checkFindNew([]string{"myfile1"}, repoName, "mycommit1", transid0)
```

Basically `FindNew(repo, commit, transid)` gets you the things that changed between whatever commit you got `transid` from and `commit` if you pass `commit="t0"` and `transid=transid("t0")` you get nothing since nothing changed.

Now that I'm looking at this it seems like the interface is pretty bad, what if we changed to:

```go
FindNew(repo, from, to string)
```

it seems like that would be a much more understandable UI


(Peter Yoachim) Feature/SIM-1040 use webbrowser with showmaf.py
now the maf web page pops open in a new tab.


(Lynne Jones) Cool!


(Lynne Jones) Feature/OPSIM-491 update maf for new opsim schema
* updating to new schema.
* fixing unit tests
* unit tests working.
* added --version to runDriver
* fixed up workshop dir to work with new schema
* fixing driver examples
* fixing the large configs
* fixed binsize bug
* delete old database


(Lynne Jones) Plot can't be made because histRange is None *and* no data exist. (otherwise could create plot).


@bryanmtl hmm, that seemed to fix it for me on sprangular core, is there maybe another issue related to the host app?


(Lynne Jones) If there was no data which was not bad


(Lynne Jones) Might be better to just punt and return None like in histograms


(Lynne Jones) Feature/OPSIM-494 check all scripts work for workshop
* tiny change to fix plot titles
* fixed useNewMetrics.py so it runs now
* fixed unit test
* Updating python script examples and install_initialtest.py and runDriver.py (so it reports total time for run).
* One last tweak to make testRunSliceMetric.py clean up after itself.


(Lynne Jones) Feature/OPSIM-609 move plot metrics button
* Moved the 'plot Metrics' button in metricselect.html
* Moved the button CSS from runselect to master.html


(Simon Krughoff) If you are doing the same thing for all browsers, I think you can just say:
border-radius:2px.  It also seems like the default needs to be first if you want the other overrides to take precedent.

Try editing this code to see how it works in your browser:
http://www.w3schools.com/css/tryit.asp?filename=trycss3_border-image


(Simon Krughoff) blank line.


(Simon Krughoff) It makes it a little easier if cleanup is put in a separate commit.


(Lynne Jones) Done.


(Peter Yoachim) Feature/OPSIM-615 slew stats to sstar config
* updated slicer to include table.
* added things back to sstar
* adding slew stats
* fixing slewstats
* adjusting, I think I have most of them now
* fixed mean slew metric
* updating sstar nvisit
* put in the cumulative nvisit histograms


(Lynne Jones) We're attaching so much extra information to slicer here that it tends to get confusing later on .. for example, table is not part of the actual slicer class (and I don't think it should be) but it's added here because it's the only place to put it.
Perhaps what we need to do is add a 'slicercombo' object (just a dictionary?) to the driver that then has slots like "what is the slicer (value = a class)? what is the table to query (tablename)? what is the query constraint (sqlconstraint)? what are the metrics to run with this combo (metriclist)?" ... I think that might make reading the code below clearer.

That said, I would like this change, but it doesn't necessarily have to happen right now. I would also like the driver to get refactored to be reusable/modular. This kind of change could happen then.

.. Ooh, and the 'slicercombo' should also track the 'stackers' relevant for its particular use (I suspect that the stackers may otherwise not clear themselves out between slicers, if for example you have a configurable stacker).


licence please


WRY SO NO SPACE BETWEEN TEH STARZ!?


why are you removing this lines?


Agreed.


I completely agree with you on all the points.
Only this PR is to fix the broke use of grunticon that is currently part of the skeleton.
I would welcome another PR removing grunticon and replacecing it by something like https://github.com/jkphl/grunt-svg-sprite


(Lynne Jones) Can the stackers not operate properly if the database table is not summary? I'm surprised you have to make this part of the code separate.


(Lynne Jones) Why are these metrics not just 'max/min/count', with some summary statistic "normalization" applied to the result (a la the Nvisits per proposal metrics which report the total number of observations for a proposal but also how many those were compared to the total number of visits)?
Shouldn't the "activity" selection bit be part of the SQL query?
(ie.. the data you get here is already only the slews which have "activity"=activity)


(Lynne Jones) For extra points, figure out how we can query this using the 'execute arbitrary sql' methods on DBObject (and thus inherited by CatalogDBObject) so that you can do the full query in SQL .. I think it would be faster doing
"select count(distinct(SlewHistory_slewID)) from SlewActivities where actDelay>0"  and then just evaluating the result.
I need to do this for total number of visits and total number of fields per proposal as well.


(Lynne Jones) Seeing these right next to each other makes me want to standardize the calls.
"fetchNVisits" could go to "fetchVisitsN" to match, I suppose.


(Lynne Jones) Need to "nice-en up" the slew statistics groupings. For example, there are slew statistics in the Technical section, several different slew sections, and one with a 'group' that is  NULL (not so pretty).
Plus, there are statistics here which are already calculated elsewhere -- why duplicate? (Open Shutter Time and Total N Visits are the first things you see in section 1 of the metrics. I'd actually move "number of nights" to that section and drop it from here).


(Lynne Jones) Arggh, part of that may be differences between versions of the sstar we're running.
Okay, let's deal with this by just merging everything back togehter and then doing a cleanup on the sstar.


(Lynne Jones) From here down to the start of the slicerlist is not needed for these slew statistics tests, I don't think.
Removing the code from this example would be good, because otherwise it's additional code to maintain/make runnable when things like (random example off the top of my head) the call to fetchPropIDs changes.
It also makes people think they'll have to do these calls every time, when they don't. We should keep example configs as lean as possible.


(Peter Yoachim) yeah, I think my plan was to put all the these slew stats together and that for the "contribution" metric it would actually need more things.  Now that I finally got Kem and Fransisco to say what they are trying to compute I'll put that in and clean this up.


(Peter Yoachim) you're right, stackers should work fine.  Fixed.


Check the styleguide. https://github.com/jortechve/styleguide/tree/STYL-1#functions
Don't use function declaration. Use function expresions


(Peter Yoachim) Feature/OPSIM-428 f0 metric and binner
This has the new f0 metric and binner as well as the refactor of the binners to each have their own plotData method.

* I always forget to add new files
* debugging f0
* debugging f0 metrics
* so close, just need to sort out lines on the plot
* Finally got things sorted out
* fiddle with lines
* adding comments
* unit tests passed


(Lynne Jones) So these lines above (filenames / filetypes / figs and the warning) should all go into the baseBinner as a basic plotData method, then these subclasses should call plotData as a super. That way we can avoid duplicating code and it makes the base class demonstration of the API more complete.

Another thing to consider might be to make the plotting methods more indirectly accessed. Rather than iterating through the different plotting methods by hand here, we could make dictionary of 'plot' methods similar to how the (now baseMetric) makes a dictionary of reduce methods. That could wait until later.


Hooray, I have a style!


(Lynne Jones) and then i guess this one would not use the super method, but that'd be okay


(Lynne Jones) Running the tests, they failed because astroprec is no longer in the metrics directory (but was still in the __init__).
I'm also getting a segmentation fault in testMoreMetrics.py (at least occasionally, which doesn't make much sense to me). I think it's from the parallax metric maybe? (division by zero)
Can you check these and update the init in the metrics directory?


(Peter Yoachim) I was getting wacky intermittent seg faults too.  Updating my anaconda seemed to clear it up (but then the palpy install failed, so I had to pull my old compiled palpy install over to my new anaconda).


(Lynne Jones) Make sure this doesn't alter metricValue ..
if zp:
  plotValue = metricValue - zp
if normVal:
   if zp:
     plotValue = plotValue / normVal
  else:
    plotValue = metricValue / normVal
else:
   plotValue  = metricValue


(Lynne Jones) Not sure I understand the if progression here .. the way the metricValue is assigned here, you can only use one of zp or normval. So then why not use if zp :  elif normVal (and maybe add an option to check that only one is set, throwing a warning if both are?).


bye


(Lynne Jones) What else is verbose used for? Why pass it in here?


(Lynne Jones) Feature/OPSIM-696 add nightly dither stacker
This is to add the new example nightly dither stacker for Eric Gawiser, etal.

* Added new nightlyRandomDitherStacker.
Removed old not-used DecOffsetStacker.
* Added unit test.
Also updated unit test asserts.


(Peter Yoachim) Do we want to put this directly in the contrib repo?


(Lynne Jones) I thought about that .. I guess I figure if this works, it's something we'd probably like to include as a standard dither analysis and serve as a 'blessed' example for everyone? (so feel free to hold it to higher standards).


(Lynne Jones) Oh! In doing this, by the way, I did a few speed tests on the nightly looping stuff (for the record).
I found that using match = np.where(data['night'] == night)[0] was almost twice as fast as my previous standard match = (data['night'] == night) ..so, mea culpa for where I may have changed these in the code base in the past and I should do a sweep and replace all of those cases with np.where versions. It's also faster than doing a tortured indexing/sorting thing which was hard to read but did still beat the match=(data['night']==night) version.


(Peter Yoachim) ah, I should have noticed that.  I bet using np.searchsorted is even faster, but if it's not a huge bottleneck I think np.where has higher readability.


(Lynne Jones) Given how hard my tortuous version (which I think would maybe look similar to np.searchsorted?) was to read, I think you're right about the readability.


(Peter Yoachim) Bugfix/OPSIM-447 plotdata fixes have left behind
Fixed problems (fig numbers weren't being returned to baseBinMetric).


Probando!


(Lynne Jones) Feature/OPSIM-416 move database access into single
* Fixed minor bug that meant not all modules got printed.
* Rearranged and consolidated database access, started new 'database' and 'opsimdatabase' classes. Rearranged utils to match.
Have not yet updated examples, tests or driver.
* Reorganization of database & fetching config info.
* Updates to Database/OpsimDatabase and to writing output using outputUtils.printDict. Wrote unit tests for database classes.
* Added a half-hearted attempt to update the driver to use the new opsimdb class .. but I'm not entirely sure how to update driver + config (need to consult with Peter).
* Some updates to db class to change dbTables to make it easier to use. Also updates to unit tests (including some update to the MAF driver) to get unit tests to pass with new database configuration.
* Updated unit tests to use new opsim 1 year database run. Found and fixed error in opsimDB where multiple fieldIDs could be returned when querying using proposal info.
* Got new proposal types with nested subset to work (for counting number of visits and recording subseq info). Also added install_* configuration drivers for workshop.


(Simon Krughoff) I complained about this in a review for Peter as well, and it's only a small complaint, but it seems like there would be a better way to encode a default than to hard code it.


(Simon Krughoff) Probably missed elsewhere too, but line length is a problem here.


(Lynne Jones) Hi Simon, yeah - we're working on this. I agree (and it became especially painful when running a bunch of different sims for Zeljko).
PS - these files (in this driver dir) may be also going to change a bit because it turns out we haven't updated them all yet.
I think the ones in ../workshop should be up to date though.


(Simon Krughoff) Sorry, I'm reviewing too much aren't I?  What files do you want me to look at specifically?


(Simon Krughoff) I like the end quotes at the same indentation as the originals.  It makes it easier to see where the multi-line comment ends.


This is already provided by a match object!


(Simon Krughoff) Why not include this in the docstring?


(Simon Krughoff) This can be done with self.dbTables.update(defaultdbTables).


(Lynne Jones) Ooh, cool. Did not know about that feature.


(Lynne Jones) Good point. (and yes, this is a good file to concentrate on! .. although - do you like or hate the changes to examples/workshop/install_initialtest.py? should let you run from the command line and specify filepath + opsimrun name + output dir at runtime.


(Peter Yoachim) Feature/OPSIM-614 quick merge 3x2 plots into a single
Little script for Kem so he can merge pdfs together in a handy grid.

* merging pdfs works
* pyflakes cleanup


(Lynne Jones) I think either you don't need to set fileBase[0] or you do need to set fileBase[1]. As it is, it's a little confusing.


(Lynne Jones) Cool. Will this work with PNG files as inputs?


(Peter Yoachim) oops, that line should only got partially deleted. Impressive that it still worked...


(Peter Yoachim) Now it works with png's.  It always outputs a pdf, but using the pngs as input keeps the final filesize down.


(Lynne Jones) Feature/OPSIM-490 write an html template for laying
OK, the stuff in the new viz directory is the experimental first steps for the visualization layer, so it will be changing.  Same for things related to "displayDict".

* fixed up the table fraction metric
* upgraded tableFraction unit test
* starting to put in plotGroups
* fixed inf scaling issue
* change warning to only catch the healpy colorbar stuff
* Updated baseMetric to check if plot zero point or normVal were bad values (infinity or zero), discard if true. Updated mafUtils/optimal bin calculation to be more consistent about returning nbinMax.
* fixed warning typo
* Set color bar Min/Max from xMin/max if not set independently.


(Scott Daniel) Were these commented-out lines intentionally left in, or should they be deleted?


(Lynne Jones) They should be deleted. I'll do that.


(Scott Daniel) maybe this is python I don't know, but why are are you asking for the value in metric.displaDict corresponding to an empy key (metric.displaDict[''])

apologies if this actually make sense and my python-fu is out of date


(Lynne Jones) Bad documentation! Remove the returnBin doc line - not a kwarg anymore.


(Scott Daniel) should this still be here?


(Lynne Jones) super picky .. but since people are likely to read the code (I hope) and we'd like to reduce confusion .. 'goodVals' is confusing here, because all of the values are actually good, it's just we want a subset that don't equal 0 or 1 or >1. Something neutral like 'condition' or 'subset' seems more appropriate.


(Scott Daniel) I do not know html, so was unable to review those files.

favicon.ico did not display at all in the 'diff' window


@fnothaft In light of new changes to the spark-submit scripts, I am looking over this again.  What happens if I also specify `--spark-executor-memory` etc.?  Which one will win?  What's the purpose of having the ADAM-specific executor/driver memory options when you can just use the spark ones?


(Scott Daniel) looks like there are two more commented-out lines of code here


(Lynne Jones) This is really hard for me to decipher too.
Peter .. if displayGroups is going to be a characteristic added to a metric, it probably should go into the BaseMetric class so we can trace it back to understand what 'displayDict' is and how it works. Is this currently just as a class attribute in the driver? What about people who write python scripts (like me ... or people who want to do specialized things we can't support with the driver) but still want to display their results in the viz layer and use groupings?
Plus, if it's just in the driver then it's hard to trace back.

Also .. I'm assuming the reason it's actually a dict rather than a single value (containing the displayGroups string) is because of pex_config?? can't we simplify it if displayDict really is just one value? .. I can't find any examples of using this, so I don't actually know if it's supposed to be something other than just a single string of 'displayGroups'.    --- nvm, discussion above about dict vs string.


add line 4


(Scott Daniel) It looks like the viz directory is missing its __init__.py files


Just for test


(Scott Daniel) (stupid auto formatting; there should, of course, be underscores at either side of the 'init')


(Lynne Jones) When the calculated coadded depth is infinite, I think it's because the number of visits is very small (i.e. the log failed because it was essentially 0). The singleVisitDepth doesn't change, after all, by any scalefactor.
So wouldn't it make more sense to return the single visit depth as 'design coadded depth' instead of 0?


(Lynne Jones) Similar for the stretch coadded depth .. just return stretch single visit depth instead?
That way the plot limits (which might be reasonably expected to be small values centered around 0) are likely to be accurate / useful still, and the plot will likely look about as expected.


@stefankarpinski My point is that, if you are going to take the hit of validating strings, why do you not then validate when you convert an integer to a Char?  That just doesn't seem consistent...


... that's super weird, but okay.


remove .idea


(Lynne Jones) If we're saving displayGroup, shouldn't we probably save the plotDict too? Seems like they ought to be on the same level.


(Lynne Jones) We need to be consistent -- probably adding 'Warning' at the start of each warning message is appropriate (i.e. helpful for people grepping through the outputs to look for warning or error messages).


It was my careless mistake.
When I implemented intersectSphere, I forgot to check whether the center of the sphere is in the bounding box. Now it is a simple fix.


(Lynne Jones) If there is only one key, why not make 'displayDict' into 'displayGroup' and make the value be the string that it should be? (default of '' or None)?


(Lynne Jones) It's just an icon to display at the top of the web pages generated by the 'viz' module.


(Lynne Jones) A lot of the viz stuff is new and still work in progress. We wouldn't be merging it to master at all yet, except there are other changes on this branch that we do need. :( Oh well, at least it'll let people get a little taste of what's coming. Hopefully that's not going to bite us in the butt with people saying it's not ready yet (it's not ready yet).


Now the LOD terrain selection looks more reasonable.


(Lynne Jones) work in progress... probably not. Will remove to get the merge into master a little cleaner.


(Lynne Jones) Haha, I realized that I suggested 'displayDict' in the first place (to match plotDict). But if it's really only a string that's needed, let's make it simple and be a string. If we do need other keys to store more than just displayGroup, then keep a dict.


Also I just pushed code to fix this so don't waste time fixing, pulling and dealing with a merge conflict. Just pull and :smile:


Daniel,

Also this kconfig is missing a config for CC_GCC_5_1, like the one for 4_9:
https://github.com/crosstool-ng/crosstool-ng/blob/master/config/cc/gcc.in#L394

Then also bump CC_GCC_Later to CC_GCC_5_1


data = courierNew_10ptBitmaps[c*20+i];


Looks like the problem is in pkcs15_prkey_can_do, that is a new function.
Line 3768 should return CKR_OK  if no algo_refs are specified, assume if none specified,
all are possible.


(Lynne Jones) (I've removed the line).


(Lynne Jones) This is really hard for me to decipher too.
Peter .. if displayGroups is going to be a characteristic added to a metric, it probably should go into the BaseMetric class so we can trace it back to understand what 'displayDict' is and how it works. Is this currently just as a class attribute in the driver? What about people who write python scripts (like me ... or people who want to do specialized things we can't support with the driver) but still want to display their results in the viz layer and use groupings?
Plus, if it's just in the driver then it's hard to trace back.

Also .. I'm assuming the reason it's actually a dict rather than a single value (containing the displayGroups string) is because of pex_config?? can't we simplify it if displayDict really is just one value? .. I can't find any examples of using this, so I don't actually know if it's supposed to be something other than just a single string of 'displayGroups'.    --- nvm, discussion above about dict vs string.


(Lynne Jones) Expanded warnings here, to catch potential summary statistics returning strings, etc. (I don't know who would do that .. but maybe someone would for some reason.)


(Lynne Jones) Curious - why remove this? Do we have a use case to run a summary stat on 'object' data? If we're not catching this here, where are we -- what happens if object data is passed to compute summary stats? (the metric itself will not catch this -- for example "MeanMetric" being computed on a dictionary will only give a numpy error that will be hard to diagnose).


(Lynne Jones) Curious - why do we need the strip here? Removes whitespaces so it's fairly innocuous, but where would they come from?


(Lynne Jones) done.


(Lynne Jones) I fiddled with this a little, under the assumption that the only thing we're actually saving from displayDict is 'displayGroup' a string (since this is the only thing that makes it into or out of the database and the writeData methods seem to be only writing a string).


(Lynne Jones) I fiddled with this a little ... under the assumption that we're only saving/using a string of displayGroup from the dictionary. Added displayGroup to the metric itself, so it's a property that will always be there and be a string. If it needs to be a dictionary we can change it back, but I didn't have an example to test it against.


(Lynne Jones) Added this displayGroup parameter to the other plot* methods.


I can't test Cygwin detection since I don't use it, but I can point out that 094's platform detection will still fail to detect Windows correctly if `uname -a` returns anything that doesn't contain "CYGWIN" or "Windows", as can be (or always is?) the case for mingw/MSYS users, ex.:
```
20:38:53.39 D:\code\bsnes-plus
>uname -a
MINGW32_NT-6.2 DEVIN-PC 1.0.18(0.48/3/2) 2012-11-21 22:34 i686 Msys
```


(Lynne Jones) Approved, but do think that the scaleStretchDesign should be updated (unless I got my assumption wrong on why the values end up being weird?). Also, hope that my guess was right about the displayDict, but we can fix that later too if needed.


(Lynne Jones) Feature/OPSIM-502 create prototype movie slicer
OK, I think this works now.  Highlights are that a squashed the output of a bunch of unused plots and added a unit test.

* Animation Functionality - CM
* Removed extraneous print statements and reinstated default 'pdf' instead of 'png' fig format for runSliceMetric.
* make it possible to skip some output plots from a slicer
* remove the crazy flags I don't understand.
* make things more verbose
* added test for movie slicer--turned off ffmpeg portions by default
* pyflakes clean up
* clean up the formatting a bit


(Lynne Jones) typo in 'generate'


(Lynne Jones) This could be reconfigured to be simpler (for logic/readability anyway) given that we now have the 'plotFuncs' argument. .. I'd suggest
- getting the available plot functions (inspect.getmembers and then strip out the plot options)
- if plotFuncs is *not* 'all', then loop through the items in plotFuncs, check they're valid methods, and add to self.plotFuncs dictionary
- if plotFuncs is 'all', then just add all the plot methods to the self.plotFuncs dictionary.

.. which is totally what you're already doing, but just looped/if/then'ed a little more readably.


(Lynne Jones) The only additional kwarg is the plotFuncs kwarg, yes? Can we just add it to these inits (and supers)?


Changing msg to StockErrorMessage will enhance the readability of the code


(Lynne Jones) One thing to note about the plotFuncs ... the only difference between the HealpixSlicer and the F0Slicer is the plotting, yes? And also the 'complexHealpixSlicer'? So .. maybe worthwhile to consider combining those plotting methods back into the original, making the default 'plotFuncs' for the healpix slicer be the usual ['plotHistogram', 'plotSkyMap', 'plotPowerSpectrum'] and then for an F0 plot, you'd override plotFuncs to be ['plotF0'].


(Lynne Jones) Also .. nvm .. read the example_movie.py plotFuncs wrong.


(Lynne Jones) On the other hand, going this way around means that you're never going to accidentally add 'skymap' to your plotFuncs dictionary instead of plotSkyMap.
Either way (you could make sure this doesn't happen the other way around either).
Consider adding a warning if a method was in plotFuncs which was not an actual plotting function. (so that people don't wonder where their 'skymap' went.)


(Lynne Jones) sweet!


(Peter Yoachim) Feature/OPSIM-610 write instructions for porting
made copy tool


(Lynne Jones) I think you can set this as the default within the add_argument line (just make 'default = False')


(Lynne Jones) For code consistency, can this be cpMaf.py or copyMaf.py?  (i.e. showMaf.py is not showMAF.py).


(Lynne Jones) Feature/OPSIM-669 clean up sstar
* Removed unused slew metrics and added default-captions to the remaining ones.
* Updated 'NOutliersNSigma' metric name (to add "Metric").
* Updated documentation for CountRatioMetric.
* Updated "normalize" metric to make sure that normVal is a float.
* Added filter change metric (NChangesMetric).
* Moved NChanges metric from simpleMetrics to technicalMetrics file.
* Removed "'" from --'s in summary tables.
* Update to metadata combinations.
Make shorter metadata combo when doing things like 'u, g, r, i, z, y band WFD'.
* SSTAR updates.
* Fixes to comparison slice metric and update to technical metric to make 'filter' default column for nFilter.


(Peter Yoachim) hmm, looks like using the new sstarDriver I run out of memory pulling in the slewActivity table. Could be because my desktop is ancient, I'll check on my laptop.


There's no need to construct player as cid is already a player userdata, onSay gives us the player userdata directly.


(Peter Yoachim) Also looks like the master sstar is broken...


Cool! I'll do the merge to resolve conflicts.


(Lynne Jones) Going to merge (let me know if you end up with comments Kem).


(Lynne Jones) Bugfix/OPSIM-437 cleaner crash required if sqlite
Updated Database class so that if sqlite db file is not present, gives more useful error message (rather than lots of 'table doesn't exist' messages). Also updated OpsimDatabase.fetchConfig to let us know if the number of visits can't be calculated (because restartCompleteSequences is true).


(Scott Daniel) One immediate question: when I try to run the unit test, it complains that it cannot import a module 'version.'  This is demanded by __init__.py in /python/lsst/sims/maf/

The copy of sims_maf that was installed by eups distrib install does, indeed, contain a file version.py in that directory.  However, when I cloned the git repository just now, that file is gone (though __init__.py still asks for it).

Did some wires get crossed here?


(Scott Daniel) it looks like line 420 and line 423 are identical.  Can you not have it once, triggered by a statement like 'if not restartComplete or k != 'NumVisits':


(Lynne Jones) Sure. I'll make a change and update.


(Lynne Jones) I'm not entirely sure. version.py is usually created by scons so when you git clone the repo, you have to do 'scons' to create this file. (i.e. git clone, scons and then 'scons tests').


Now that you aren't returning, you will need a conditional around this server initialization.


Same as start_cast


(Scott Daniel) okay.  That worked.  Sorry for the confusion.  I think this okay to merge.


(Peter Yoachim) Feature/OPSIM-440 speed up driver unit test
* that's shorter at least
* add print statements to driver
* added verbose and config flags to config


(Lynne Jones) this (and the running -> querying above) are good changes!


Also changing vairable "i" to a meaningful name will help code flow


(Lynne Jones) Do you think 'getConfig' will lead people to think of the MAF config parameters rather than the opsim config parameters?


(Lynne Jones) Feature/SIM-905 movie horizons
Most of this is modifying plotting.

* Modified metric + stackers to move RGB info for each visit into stacker instead of the metric.
Also added unit test.
* Added support for more than just float type stackers.
* Updated opsimMovie.py to use filter RGB stacker instead of computing RGB in metric.
* Added milky way exclusion zone to baseSpatialSlicer skymap plots.
* Updated opsimMovie.py to generate "better" horizon.
* Added scripts to make it easier to generate and join multiple nights of movies.
* Added previous observations option to movie command.
* Small update in help message.
* Made ecliptic and mwZone fainter.
* Added proper pyephem horizon.


(Michael Reuter) The opsimMovie.py script has a hard dependency on ffmpeg. The script should check to see if this exists first since the movie creation only happens after PNG generation. I'll open another ticket for that.


(Lynne Jones) Good point. We usually just fix things like this within the review, so I'll do that (haven't seen a separate ticket though?).


(Lynne Jones) Sorry - I did update some of the things here, while I was playing with getting better visibility for observations in the movie. I believe I am happy with how it works now. An updated version of the movie is (will be) available at  http://youtu.be/PKNaI3fAST4


Should these `fuzzyProvider` names be changed too?


(Michael Reuter) Is mkOpsMovie.sh actually supposed to run the command or is it just to show you the commands you should run? Currently, it just echos the commands and doesn't run them.


We don't always validate strings – we validate string and character literals, not generally runtime data, e.g.:

```jl
julia> s = open(readline, "/dev/random");

julia> s
"fͼ\x1fM� \U139bc7M��7�6<�ҡxError showing value of type UTF8String:
ERROR: ArgumentError: invalid UTF-8 character index
 in next at ./utf8.jl:69
 in print_escaped at string.jl:874
 in print_quoted at string.jl:891
 in show at string.jl:71
 in anonymous at show.jl:1230
 in with_output_limit at ./show.jl:1207
 in showlimited at show.jl:1229
 in writemime at replutil.jl:2
 in display at REPL.jl:111
 in display at REPL.jl:114
 in display at multimedia.jl:149
 in print_response at REPL.jl:131
 in print_response at REPL.jl:118
 in anonymous at REPL.jl:597
 in run_interface at ./LineEdit.jl:1552
 in run_frontend at ./REPL.jl:841
 in run_repl at ./REPL.jl:164
 in _start at ./client.jl:449
```


(Michael Reuter) joinOpsMovie.sh also has issues. First, it needs the #!/bin/tcsh at the top for ease of use. Next, is blank.mp4 supposed to be an autogenerated file? If not, there aren't any instructions on how to make it. Last, is this script just supposed to echo commands or actually run them?


(Scott Daniel) Why are you doing this transformation?  It looks like you already have the RA, Dec of the horizon (or is that not what you need to output).

Could you add a docstring explaining what this method is supposed to output.


(Scott Daniel) It seems confusing that this method accepts one angle in degrees and the other in radians.  Should horizon_altitude be in radians?


We can do this for now: https://github.com/chjj/blessed/commit/b241e1a4df4b704ce7d95d724bdee7f12ff6e8c0


pip shouldn't be in a requirements file unless a specific version is required. It will be installed as a prerequisite to install the distributions in the requirements file. So I would suggest to remove it.


(Lynne Jones) Duh. Good point. I think they should both be in radians.


(Lynne Jones) I'll add a docstring, as you're right it's a little confusing.
The thing we're actually plotting is the RA corrected by 'raCen', which for the movie is the LST / aka RA at zenith. (and then a little extra transformation to match the aitoff projection coordinates expected by matplotlib).
At this point in the movieSlicer, we do actually know the 'raCen', so I could instead pass that in here instead of calculating the zenith RA. Maybe that would make more sense?


*Created new population change information for counties, districts, and circuits based on percentages
CREATE VIEW population_change_percent AS (SELECT a.county, a.population_2000, b.population_2010, (((population_2010/population_2000)*100)-100) FROM population_2000 a, population_2010 b WHERE a.state = b.state AND a.countya = b.countya);
CREATE VIEW population_change_districts_percent AS (SELECT a.district,  (((b.sum/a.sum)*100)-100) FROM population_districts_2000 a, population_districts_2010 b WHERE a.district = b.district);
CREATE VIEW population_change_circuits_percent AS  (SELECT a.circuit,  (((b.sum/a.sum)*100)-100) FROM population_circuits_2000 a, population_circuits_2010 b WHERE a.circuit = b.circuit);


(Lynne Jones) Hmm, blank.mp4 was supposed to be in the git repo. It looks like I must've missed adding it. I'll do that.
I'll also add the #!/bin/tcsh at the top. I guess I'll make both of these scripts executable.
As for whether the command is run or just echoed ... for this one, I think it would probably be reasonable to just run ffmpeg, as joining the movies doesn't typically take much time.
I do like to be able to go in and edit the tmpMovieList file though (to add more blank.mp4 lines to indicate a big skip in time) and to redirect the output to a different file.
I guess I was thinking of this script and the other as "conveniences" to help you remember and build some of the commands, rather than to actually execute them for you.


(Scott Daniel) Maybe.  Unless there's a use case where you wouldn't already know raCen.


(Lynne Jones) It was supposed to just echo the commands. I guess I was thinking that you might want to tinker with the output commands or split them up and run on different machines or do something different - the actual movie making can be pretty time intensive, so I was a little hesitant to just make this go ahead and run.
I will add some more documentation for how to use this and the joinMovie script. Would that be enough?


(Lynne Jones) Okay, just documented it better.
Turns out (I had forgotten) that it's not the same raCen value as used in the rest of the script, and so should not be called the same thing. The difference is that I did not require the user to specify the longitude of the observatory, just assumed it was 0 .. thus I'm calculating the hour angle by calculating the difference between RA and zenith RA at an arbitrary (but consistent) longitude, rather than ra and zenith ra at the true longitude of the observatory.


(Lynne Jones) Done.


I think we could just delete the Node about them being mutually exclusive, as in some cases different parties may specify one and another may override.  For example PaaS provider setting one and then user overriding.  Saying the are mutually exclusive may confuse the issue and what happens when both are configured is explained below


(Michael Reuter) In the section above, I'd move the opsimName variable to the top and use it in the dbAddress line. That way you only have to edit the name once as you have done nicely before.


(Michael Reuter) Need to remove this line as it only allows for 3 target plottings and overrides the line above.


(Michael Reuter) I'm fine with this script echoing the commands. I was just making sure that was the intention.


(Michael Reuter) Again, I was just verifying that the script was supposed to just echo the commands to run. I think this is a good idea as it lets one tinker with the tmpMovieList file. I'd just make joinOpsMovie.sh go back to just echoing commands. I'll make a comment by the LOC.


I think happened should be happen


Given that `module` and `namespace` create the same AST node we just need a few tests that check they're synonymous. There is definitely no reason to replicate the entire set of internal module tests. For these particular tests, since I had to modify them anyway (because quick info now returns the string "namespace") it seemed meaningful to just update them to use namespace throughout.


(Michael Reuter) I like the idea of the script just echoing the commands so I think this line can be removed.


(Scott Daniel) It looks like a file blank.mp4 has been added to the examples/pythonScripts directory.  It's not a big file, so this probably isn't a huge concern, but it seems like the kind of thing we don't want to track in the repo unless we have to, so I just thought I'd check that this was done intentionally.


(Scott Daniel) testMovieSlicer.py still fails on my machine because I do not have ffmpeg


(Lynne Jones) Yes .. I thought about not including it, but Michael pointed out it was referred to and used by the joinOpsimMovie.sh script (it's a series of blank frames so that the days of the movie can be separated by white space). Maybe I should have put it in the sims_data repo?


(Lynne Jones) Okay. Done.


(Lynne Jones) This is actually me trying out different frames from the movie. I'll add a comment so that people understand what's going on, and remove one of the lines.


(Scott Daniel) putting it in sims_data would be the safest thing to do (assuming that it is straightforward to point joinOpsimMovie.sh to sims_data)


(Lynne Jones) Ah. I did not realize there was a unit test .. looks like the unit test actually duplicates most of what is in opsimMovie or example_movie.py scripts.
I think I will have to rewrite the unit test to just test some of the specific functionality of the movieSlicer.


(Michael Reuter) The new timestamp isn't working properly after the first night (night=0). The next night (night=1) is identified as Year 1 and Day -363.6273. The following night (night=2) is identified as Year 2 Day -727.6272. Night 11 (night=10) is identified as Year 10 Day -3639.6272.


(Lynne Jones) Done! I hope. Build passes on buildbot after rewrite of unit test.


(Michael Reuter) Looks like the order on the dictionary access is opposite to the lines above. It doesn't seem to make a difference in the final answer, but should be changed to match the lines above for consistency.


(Lynne Jones) Done.


(Lynne Jones) Argh, I believe that Zeljko is done with additions now, and I'd like to get it merged before he comes up with more (he's gone Monday to the PST meeting in Tucson, so here's our chance!).


(Michael Reuter) I'm seeing this warning when generating individual movies:

/Users/mareuter/git/lsst/sims_maf/python/lsst/sims/maf/sliceMetrics/runSliceMetric.py:156: RuntimeWarning: invalid value encountered in equal
  self.metricValues[iid].mask = np.where(self.metricValues[iid].data==self.metricObjs[iid].badval,

This is using a command like:

python opsimMovie.py aquila_1000_sqlite.db --sqlConstraint  night=10 --ips 30 --addPreviousObs --outDir aquila_1000_n10

It's not stopping things from working, however. I'm continuing to pass thorough the rest of the checks. So far, so good.


(Lynne Jones) Just made a small change that I think should fix this.


(Lynne Jones) Nope, didn't fix it and honestly, I'm not entirely sure where this error is coming from. Since it doesn't stop execution or seem to have any significant impact, I'd like to address it in a separate ticket.


shouldn't it be EntityRef.NULL?


(Scott Daniel) does this need to say skipComp?


(Scott Daniel) is 'instante' a typo?


(Scott Daniel) should this loop be here, given that mystackers was just created as an empty list?


(Scott Daniel) should setupMovieSlicer and setupHealpixSlicer have docstrings explaining what the arguments are?


(Scott Daniel) should be joinOpsMovieFull.sh


(Scott Daniel) is [opsim name] the same thing as [db name] in the joinOpsMovie.sh?  If so, the documentation should be made uniform.


(Scott Daniel) should this refer to some standard place where we are keeping LSST site information?  There is Site.py in sims_catalogs_generation/db/.  I know there is also somewhere in MAF where we keep that data, as well (we should probably move to storing that information in a single place...)


(Scott Daniel) Again, should lat_telescope point to one place where the data is stored?


I can't remember at the moment if it was only the spark-shell module that needed them or if others did as well.  I believe it had something to do with the spark-1.2 upgrade, part of which made it into master.

Putting them in the shell pom may work.

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message --------

From: Pat Ferrel <notifications@github.com>

Date:04/27/2015  5:36 PM  (GMT-05:00)

To: apache/mahout <mahout@noreply.github.com>

Cc: Andrew Palumbo <ap.dev@outlook.com>

Subject: Re: [mahout] added scala dependencies in math-scala to fix spark-shell (71165a5)

Are these required for all scala modules? Can this be put in spark-shell pom instead?

—
Reply to this email directly or view it on GitHub.


Hmmmm, changing the user containers is a bit weird with our static files container hack. :unamused:


(Scott Daniel) Also: how is the user supposed to change this value if they are making movies for a different telescope (or is that something we are not worrying about, yet?)  I see that runSlices passes this value directly into addHorizon.  Should there instead be a lat_telescope argument for runSlices?


(Scott Daniel) it looks like a lot of this code is duplicated in example_movie.py.  That should be refactored into a third place so it only exists once and is imported here and in example_movie.py.  That can be a different ticket, though.


(Scott Daniel) doesn't the if statement mean that this will always be true, if it is called?


(Scott Daniel) doesn't the if statement mean that this will always be false if it is called?


(Michael Reuter) I've found that the warning isn't always present. In my survey on night 250, the warning doesn't pop up. However, nights 0-2 and 10-12 all generate the warning. I'm fine with another ticket dealing with this issue since it doesn't seem to effect production of the frames and movies.


add more on prediction.
also add a little bit more on what "experiments" we have done, e.g. writing running these test versus the opponents repeated as a proof of concept


(Scott Daniel) do you mean self.assertEqual?


(Scott Daniel) why the extra calls to ephem.degrees().  Doesn't obs.radec_of already return ephem.Angle objects?


(Lynne Jones) I'm absolutely not worrying about people using this to make movies for another telescope yet. There are some other changes or accomodations people would have to make to use this for another telescope -- in particular, the script is using the opsimFieldSlicer, which could be used for another telescope but would require the user to understand how that applies to their pointing history (in particular, they would need to have fieldIDs corresponding to the ra/dec of their fixed field pointings).

That said, we do actually have a TelescopeInfo class that I should be using to get this info. I'll do that instead (but it still won't be something that is easy for someone to modify from the command line, since it just starts being a LOT of parameters to be able to modify, that aren't relevant 99% of the time.)


(Scott Daniel) when I run

python example_movie.py /Users/noldor/physics/lsst_141203/Development/garage/OpSimData/opsimblitz2_1060_sqlite.db --ips 2

I get the following error:

Traceback (most recent call last):
  File "example_movie.py", line 287, in <module>
    stitchMovie(metricList, args)
  File "example_movie.py", line 205, in stitchMovie
    slicenum = plotfiles[0].replace(outfileroot, '').replace('_SkyMap.png', '').replace('_', '')
IndexError: list index out of range

(my copy of opsimblitz2_1060_sqlite.db was downloaded in November, if that might be the problem)


(Michael Reuter) I have to take it back. The night 250 showed the warning. It just took a while to get there.


OK, that's good to know then... it does mean you can't make any assumptions about the contents of a UTF8String, or a Char, when only literals are checked.
Almost makes me want a ValidatedString type, with ValidUTF8, ValidUTF16, and ValidUTF32 concrete types...


(Lynne Jones) Ah. When you 'print' the value r or d, you get the Hours string. I didn't realize that if I just stuffed it into the array, I'd get the radians version automatically. Will remove the unneeded calls.


(Lynne Jones) Yes .. I agree it should be looked at in another ticket.


`Prelude.tail` ?  Shouldn't whatever other `tail` is in scope be the one that gets qualified?


(Scott Daniel) I do get 10 .png files in the output directory (indexed 00-09), so maybe the problem is that there is a for loop that is overstretching itself


This is brilliant!
Quite useful for module development to use hidden APIs as well. Following this implementation and providing APIStubs is a lot easier than using reflection or referencing the whole framework.


(Lynne Jones) Hmm, I don't think it should be related to your copy of the database. I'll come over and try to debug in person.


(Lynne Jones) Yes. Fixed. (still runs).


(Lynne Jones) Yes... I think the point was this should be a test failure, because it shouldn't happen (so assertTrue should). I'll swap it to just raise an exception.


(Lynne Jones) Should be an assertEqual again.


(Michael Reuter) +1 for the refactor in a new ticket.


(Lynne Jones) Found the problem with Scott's help, not-so-edge case of user specifying full path to opsim sqlite file rather than just having the file in the same directory. Will update the args input so that user has to separate db directory path and db filename (like is done with runFlexibleDriver.py). Should remove this problem.


hpwh_residential (nmerket) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


(Lynne Jones) I will say that while some of this is the same (stitchMovie, setupMovieSlicer), a lot of it is different enough that it can't be easily combined. For example, the runSlices method is significantly different, including when/where the metrics are set up.
The getData method is different, because the opsim field slicer needs the field info while the healpix slicer doesn't. The arg parser arguments are not all the same. So while a small part of this could be combined, not all of it could.


(Lynne Jones) Yes .. they should both be opsim name.


(Lynne Jones) Done.


For me test fails :

```
[debug] Responding to client with success: {"status":0,"value":{"platform":"LINUX","browserName":"","platformVersion":"4.1","webSt│
orageEnabled":false,"takesScreenshot":true,"javascriptEnabled":true,"databaseEnabled":false,"networkConnectionEnabled":true,"locationCon│
textEnabled":false,"warnings":{},"desired":{"app":"sample-code/apps/ApiDemos/bin/ApiDemos-debug.apk","device":"Android","browserName":""│
,"platformName":"Android","deviceName":"Android Emulator","launchTimeout":60000},"app":"sample-code/apps/ApiDemos/bin/ApiDemos-debug.apk│
","device":"Android","platformName":"Android","deviceName":"emulator-5554","launchTimeout":60000},"sessionId":"04bcb3f8-2708-4035-9169-7│
6b2ac83b148"}                                                                                │
info: <-- GET /wd/hub/session/04bcb3f8-2708-4035-9169-76b2ac83b148 200 1.510 ms - 644 {"status":0,"value":{"platform":"LINUX","browserNa│
me":"","platformVersion":"4.1","webStorageEnabled":false,"takesScreenshot":true,"javascriptEnabled":true,"databaseEnabled":false,"networ│
kConnectionEnabled":true,"locationContextEnabled":false,"warnings":{},"desired":{"app":"sample-code/apps/ApiDemos/bin/ApiDemos-debug.apk│
","device":"Android","browserName":"","platformName":"Android","deviceName":"Android Emulator","launchTimeout":60000},"app":"sample-code│
/apps/ApiDemos/bin/ApiDemos-debug.apk","device":"Android","platformName":"Android","deviceName":"emulator-5554","launchTimeout":60000},"│
sessionId":"04bcb3f8-2708-4035-9169-76b2ac83b148"}                                                                                │
info: --> DELETE /wd/hub/session/04bcb3f8-2708-4035-9169-76b2ac83b148 {}                                                                │
info: Shutting down appium session                                                                                │
info: [debug] Pressing the HOME button                                                                                │
info: [debug] executing cmd: /Users/moiz/android-sdk-macosx/platform-tools/adb -s emulator-5554 shell "input keyevent 3"                │
info: [debug] Device is at release version 4.4.2
```

because Device is at release version 4.4.2 is set after sending driver object back


(Michael Reuter) I think you're right. I was actually thinking of the overlap between testmovie.py and opsimMovie.py in things like the calls for the time label and stuff surrounding the moon patch.


(Lynne Jones) I wanted to give a point for a user to come in and easily modify the custom stackers.
An example would be, if they want to use the randomDitherStacker, but give a particular random seed.
So they would just instantiate the stacker here, adding it to the list in a manner similar to adding to the metrics list above. Then they wouldn't have to alter any other code, since we're already looping over the (currently empty, but not necessarily empty in another person's versions) mystacker list.

The example_movie.py is a working example .. but it's also useful as a starting point for other people to modify.


(Lynne Jones) Yes, fixed.


stray console.log ?


did you forget to push the update in the ui repo? The reference is invalid.


Unhandled Fundamental Failure


you want weekly/monthly/all time constraints here right?


@mollyfish  All good! Good luck with the future features of this app, so many possibilities for new patterns!


Just pushed, sorry if it caused some problems


Done with all. :)


On a separate note, even after deleting all containers on the proxy host it's getting a name conflict with the nginx container:

```
TASK: [proxy | launch nginx] **************************************************
failed: [tmp20.tmpnb.org] => {"changed": true, "failed": true}
msg: Docker API Error: Conflict. The name "nginx" is already in use by container d506329fff30. You have to delete (or rename) that container to be able to reuse that name.

FATAL: all hosts have already failed -- aborting
```


How will this affect people not using the Solaris colors? I suspect it'll use the right codes from their theme, which would be awesome...


Fixed in latest commit.


How is this not a potential infinite loop?


This method will notify listeners the tab is being removed as well (and updates the selectedTab if it was the removed one).


"Updated sync index to reference Ionic based demo"
... and canvas demo of course...


Fix confirmed. Great hack but I hope it gets fixed upstream.


Encountered the following error output when running `make install` on Debian Wheezy:

```shell
+ make -C /usr/src/disque install
make: Entering directory `/usr/src/disque'
cd src && make install
make[1]: Entering directory `/usr/src/disque/src'

Hint: It's a good idea to run 'make test' ;)

    INSTALL install
    INSTALL install
install: missing destination file operand after `/usr/local/bin'
Try `install --help' for more information.
make[1]: *** [install] Error 1
make[1]: Leaving directory `/usr/src/disque/src'
make: *** [install] Error 2
make: Leaving directory `/usr/src/disque'
2015/04/27 21:31:41 The command [/bin/sh -c buildDeps='gcc libc6-dev make git';    set -x    && apt-get update && apt-get install -y $buildDeps --no-install-recommends    && rm -rf /var/lib/apt/lists/*    && mkdir -p /usr/src    && cd /usr/src    && git clone https://github.com/antirez/disque.git    && cd disque    && make -C /usr/src/disque    && make -C /usr/src/disque install    && rm -rf /usr/src/disque    && apt-get purge -y --auto-remove $buildDeps] returned a non-zero code: 2
```

The `DISQUE_BENCHMARK_NAME` variable is undefined, causing the installation to fail.


This has broken the example clients - which seem to be dependent on an `importer` being present in `TopicSystem`


@pztrick this is now fixed on v1.2.0. Default behavior will be to just copy files over whether they have replacements or not. The new behavior is now controller by a new option `saveUnchanged`.


Since action is repeated creating a method would help flow of code


This got removed when updating save file later. Will get added back in.


Yeah fair point.


thanks. fixed.


find is available in all views, including cells.


I never found it satisfactory


Odd formatting.  Heretofore we have always done:
```
foo('bar'
    .format(...))
```
where the `'` and the `.` line up.


Newline before if.


fixed


Done


Newline before off.


Not sure why we are defining this.  We only ever seem to call it from `write_out`.


Que puchas hizo en el README.me


Test


I'm assuming that the old container was stopped, but not removed. Are you using Ansible to delete the old ones, or doing it by hand?


Could you merge it as is for now? I have another change in the same source directory, and I do not want to sneak the next change into this pull request.


Lo hice bello


Well, I was letting Ansible do the reload. Since I had issues I went in and manually trimmed. Complete with `docker rm -fv`.

When I let Ansible reload them, I'm noticing that volumes are left lying around.

If I login to restart the newly created one by Ansible, I'm stuck with this gunk:

```
root@tmp20:~# docker restart nginx
Error response from daemon: Cannot restart container nginx: file exists at /var/lib/docker/aufs/mnt/fc2f85f5f6ce928c0cf5917f18d974c1cbdc534a0e0810e97d78181d5f4a3a69/etc/nginx/nginx.conf, can't create volume there
FATA[0000] Error: failed to restart one or more containers
```


Hey, @Black, sorry to bother, but... is there any way I could contact you? I've been working on a *big* project called BLACK, and I'd like to know if you'd be willing to hand this account over to me.

Thanks for your attention!


<b>DEBUG LINE DETECTED.</b>


Done in MarPiRK/xournalpp@6d488ba03d0ff277b1a5332823fb90a59b01b463


В самом начале надо сделать проверку - если человек == жопа, то сразу банить и по IP и по всем остальным параметрам.


А эти комменты тока ты видишь или еще и остальные?


hm not sure we'd want the number output in quiet mode. I'd think only the key.


FWIW, I'd link to the HTTP/2 spec directly [1], and drop the "an optimized protocol for the Web that is supported by..." bit. HTTP/2 support is coming to every browser.

[1] http://tools.ietf.org/html/draft-ietf-httpbis-http2/


банс-бананс
муа-ха-ха


Interesting. These are all empty in `/var/lib/docker/aufs/mnt/`:

```
root@tmp20:/var/lib/docker/aufs/mnt# ls *
0065b7ebd21eb7b30209eb9e6d71a542cf0daf8117a2950de7756ed79c343d99:

02a791aafe156afd78978782d7b75af029dbabcd249c0adf02b0e3d231e66224:

02e6a5c6cd795d689f2a4740157f2efb4e8f1661a865c0fe531a3500388a3a92:

04774d1649ca95539d84e297b1c2c6feb9291934bfe72c75539bba6ecc31edb3:

0cd9a1b3d4e06b0b61807357fc7423ba76a527393488565253dfe9e79bea1760:

108fa99b5e02ccf33f7ab02c09b81077a1d67e56092cb6bad4891c76c9f31e52:

134b78e3616c3f6862546bc2741e7fd864380ccbb6aa644d886cd6bbafba4b4b:

19e207419d6ce6c2337ce16d6d4adc5f67e06a2a4dcecf7631c449a98287a2b7:

1fc94bb7cf9c13d3620bbf4ae09be788219ad119fb22480781648986cebe55fe:

21e4345e903502c97d5fe0f02cd71d7fd29e73f171b211ac258290396bc592db:

24384d7e7029a90150bea03c973b1c66d6a37e550e1c4f259c95a50dd0c71f49:

362140cdede3ab8fda7a5103f9ef787339512f070f8458fa2a58212edef8219d:

366f5700c89309e566c8d535be1d22c69db8a4ca41e17dd8ebb0ae6fd8f2a17f:

3a1b732a3c8e26e4bad26146810fe9440cf2053cbde530b97cd0a667107c3b94:

460e77b87e02ef72b4e613e110815f9c009da2c0665ad3ac3b013c04d8a25b08:

53aad9c44c2a64dd1058f58fb2a6b639fccd81258555832ff9ee2c09bc3d9566:

573ebab31251b9917fe0a4d482f4ae4fd40f200f9da15bbc9e7bc2adfe3ae523:

5a08a87f1dbe89685585b949e6bd95e8c5891a177baf81b9822bf27021123a6e:

5f8c7453f17fc99fa4c11c58cd326a50072c92da5ebd4585c951564e6c88b265:

61e9c91c4f08ad320098697a8f36c2afb5521057213931d04d95ee243506fb14:

63482c758e5a3dadf614eb5c2ebff95f93671f4de1a1f2d64c9652cdbf575ff5:

657b717ecd94afe81af175b3e6604d47b2aefe9fbc18cf2884211567ff1c7be9:

69385f4bbbec6d859d844a33dc3f755aa222169b638ce4cbd1fb3ffa89a18dcf:

75078a2092ae883b8d03546ef6d8e2d513d50486c2af215598f2f3c9b25886a0:

7833cff9c0a68a0b8f8dd04de61b10d8b71e9e3a08c072b0874ba5490b5f5536:

7aabc31fea197e1b287b6e4bde934aeacb68f5f7a89cda5ac8392301f7341ae9:

7e7c7537feaee67a20a00779cbbc1012a8cc08fab7de1a61c054a0ef0671f56c:

8f01ad1047abe851ea7c4ee98efbea71514cc684b2119ccdf589df0da78395f0:

95cb3f06ba73f9055beb3e39acc4bad9c01469ff4fb39c9a62eab58c6cbe53b3:

9f71c63f590b2fc95fca3e9008045127ba37e882fbc8d8911770c223a2c99928:

9faf01c9b0ef91bbb17a7e9df1c8717944ae9a4e8fc375da4dcf20ef6ddc9e7c:

9fc02b3a9859514195abc653cf61e7554e6e02d926ed18a7127c08bac734ddac:

9ffb4cc4775b09780605a82a413dcc824505f2ad860e4594db7dd2ff80fb1787:

a040ecd43160755fa99711a5b1cb8c3da81b3b10d50bb49ae4f1948d0f576714:

a134e08de14db9f8dece476b9ccea96ecd134f418d4f19b61a25a46efd0ed25c:

a2595ca0cbf2e45a7bb38a285d3f0b4b1c1a53f7ca370b31edcac2b627eaf648:

ab1e4a337eb47ca5cd1f0539f600bbc1a928cd440bc58d8e87e1cdc3037d8430:

ae111afd989775864d263e683dcacc404f5d2371219b5b319b0cf7279cc64efb:

b326e2254a5ac3a37e1bce12c7493fb453cf99072d9edd42f8fa515ebdbd0a7c:

b3d362b23ec1a7ba1694e6607b44c5e3fb63d68e5ae01f339c6abe8b0c995601:

b9458d3b317ff40fe77bbbee3febc8dbda97c9dd97c91b252a8be7fb017206ce:

ba45606a00082aadc7d1cd3cf1305edb9f9b9e91ab7e5f45a9fd750a8b151e5d:

c684d7090cc2db63e9ae789d177bde58752e0de65bdeaa7eb60638b94f4a2c32:

c8abc3cc5f6a61f974ad1d475ef16f3b2ade205c4cecb1cfb42177f66fb9b255:

ce677cd2b48f547d7f4faf495f27c4a563056f0dc539ccf1a5ccd37fca7e01c2:

cf583e3a4bfcf0522c5783ac047f6f11959ae6189f69977682da27357a053a2b:

d3fce89ee7dbe4e0d9037b912ef3479683b929c2853f7197a97149a24bc6bd5b:

d4d089eaacf1228effdb7fcdc0833a7b03dae1bfc3a2aeaee844c60f2abab87e:

d9f2c0d398eea688899c83f83b6c83cc615598e4d792cb2f10e6a774823763c2:

daebf7f49e1d0bf1a23d3bffcab1d6cd799d614e1575a0cd1e76148726bebde3:

dccd93e76f771296f06a81023556c1bc1f5575f16b4a52a687bf3b6b1f920388:

ddadf33ea7c8fde932db778e24e8e1fc6c984e8c1975563d7954eb45bed24ba6:

dee71a3aab2a2aee21b641df192208349140cb5a74f4e642e89cca664de56bb8:

df1184962421cd4b19f641f61661ce36cfffc178cb65eacb2d1ed241c8fdf96f:

e0ecc4818b45b129db03cb86b7839bc28b090c659a013496dc69d1c2b95bdfc9:

ece290cb06b979b39007ebbe943b0a83e5eb3126e337f351a821919b1b7a231c:

ef53c140b3d85df0b8aabbf9ba15115bb9c87f4b621e54e8494efa83b328cd43:

f3e938f68cd7f9ac74dc509dd85f1eefba3af7e91628f98b6b5172240e695f5b:

faef22f0f65d9980e6b093f200c7f4511c83fd17b2e7f12c04e603272327e23f:

fcdd944c9e71e0e8ed6fd25d91fb8757ada8fd81c77255bf2ee7e9d25ce85eae:

fd276b73980f08831826ba168ac2a95402bb1020de22ad15c98b713657dd6643:

fd5a0a2f5bf553790715d33590e93f8a22eb93c0c34f0d06ca9097dd6d8b75db:

fe862f7c7cfb660703ef8e227f02502f26b9693564efc2d8557c9d2515213afb:

feb040acd6f66ccf3c0360fcabc911ed18002ffc704f0732fcd358af0b407d3b:

feba5e8bf2e92f52f4e559b8c7a2d4742b40389a9905e2aedfddc8ca1586a45a:
```


may need to switch to `--quiet` as #1139 will land soon


sorry I don't want to make this change by myself. Hope this is ok for you Uri.


This isn't actually AlexNet.


Your commit breaks on my side : I cannot set server-session vars on the server side. I had to revert to your commit of April 5th. I am using Meteor 1.1.0.2


I think we should add these tests:

case 9:
// Test command line switch takes precedence over environment variable
args.unshift('--cipher-list=' + env);
if (env) options = {env:{"NODE_LEGACY_CIPHER_LIST": "v0.10.38"}};
break;
case 10:
// Test NODE_LEGACY_CIPHER_LIST overrides NODE_CIPHER_LIST
args.unshift('--enable-legacy-cipher-list=' + env);
if (env) options = {env:{"NODE_LEGACY_CIPHER_LIST": "v0.10.38", "NODE_CIPHER_LIST": "XYZ"}};
break;
case 11:
// Test right-most option takes precedence, multiple of same option
args.unshift('--cipher-list=' + env);
args.unshift('--enable-legacy-cipher-list=v0.10.38');
args.unshift('--cipher-list=' + 'XYZ');
break;

doTest('ABC', 'ABC', 9);
doTest(V1038Ciphers, '', 10);
doTest('YYY', 'YYY', 11);

And also a test to validate that when you specify v0.10.38 that the default list does not apply to the client which can be one of the tests that existed before we made any changes


Interesting, thanks for letting me know. Can you open an issue? I'll have a look at this soon.


i don't quite get that


Generated some documents by creating SQL queries to answer questions about population and caseload variances.


Model BDD créer avec MySQL Workbench + Mise à jour de la structure de la base donnée derniere version connue


Modificación generada


This should be logging.INFO


Great idea. Keep them coming.

Sent from my iPhone
401-523-5780

On Apr 27, 2015, at 4:59 PM, David Thibaudeau <notifications@github.com<mailto:notifications@github.com>> wrote:

Would it be a good idea to move all of the code the has the if ok checks directly into the boost_foreach loop? If you're going to do the code anyways as soon as we find a good value, we can simply put all the code inside the loop and reduce the number of if checks by a factor of 2.

-
Reply to this email directly or view it on GitHub<https://github.com/campreilly/UnderSeaModelingLibrary/commit/af1c7a870374a3dfd60ec33636490a6fec1094f6#commitcomment-10926227>.

The information contained in this message, and any attachments, may contain privileged and/or proprietary information that is intended solely for the person or entity to which it is addressed. Moreover, it may contain export restricted technical data controlled by Export Administration Regulations (EAR) or the International Traffic in Arms Regulations (ITAR). Any review, retransmission, dissemination, or re-export to foreign or domestic entities by anyone other than the intended recipient in accordance with EAR and/or ITAR regulations is prohibited.


Yep. For some reason it works even without if. I am not sure why.

Anyway, bash manual says that "The shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test in an if statement,"

So it is safer to use grep with if. I have changed the patch and pushing patches once more.


It's not meant to be different.  It's meant to be more like a refactor.  (The commit title is outdated.)

Not all `%ENV` variables are configuration.  Some are more like *really* global state, i.e. `GENOME_BUILD_ID` and `GENOME_EXECUTION_ID`.  This is why I am not moving this to be a `Genome::Config::get()`.

I could just leave it as it was, and maybe I should, but to me it seamed better/safer to centeralize the interaction with `%ENV` behind `Genome::Model::Build::get_build_id()` and `Genome::Model::Build::set_build_id()`.


This is rather clunky and indicative of a structural problem with the code (albeit one that you inherited).

Firstly, it is worth noting that in `_write_vtu_header` we're passing a lot of stuff from `self`.  This is a strong clue that the function should be a member function (I am unsure/can not recall why it was not written like this to begin with).

Secondly, we do not appear to be actually using the `s_inf` argument.

With regards to the changes I see the addition of a boolean parameter.  These are often not the best solution.  The resulting function is littered with if statements to special case the parallel and non-parallel cases.  Hence, we're probably better of splitting `_write_vtu_header` up into two member functions: one for the serial case and one for the parallel case.  Sure, there will be a little bit of code duplication but the logic will be a lot clearer.

For the sake of expediency I suggest leaving this as is in the pull request and once merged I'll refactor it.


Test


Fixed in 4e86dfc7998b9c3195891a8045f58295f7d4ec70.


Did you mean to make this change?


Which release does this go out with? Will running `platformio upgrade` get it? I'm currently on 1.4.0.


saw approval from seancribbs
at https://github.com/basho/riak_kv/commit/cd00fc7d944afe0a371f1c3ce49c92067c5598cf


merging basho/riak_kv/bugfix/dr/hashtree_pid-after_handoff_returns_incorrect_result = cd00fc7d into borshop-integration-1106-bugfix/dr/hashtree_pid-after_handoff_returns_incorrect_result


basho/riak_kv/bugfix/dr/hashtree_pid-after_handoff_returns_incorrect_result = cd00fc7d merged ok, testing candidate = 58494b73


Will #1139 break `-type=recursive` as well? If so, I could change both, or defer this change to whenever #1139 is merged (as it'll probably break lots of other tests as well).


:+1: you are doing it right sir


it does not work???


The existing code is very poorly designed for tuning. First, it's a `static const` which you can't tune (because that's one variable per compilation unit...). Second, you have to call `Position::init()` to recalculate the table, and you may need to create a dummy Position object for that, plus the psq really doesn't belong in the anonymous namespace of position.cpp, I wanted psqtab to be a proper module (header and source file) that had a correct structure (a namespace, an init() function and a psq table). And, most importantly, you need to reverse engineer the PST, to find some parametric model that fits it, before you can tune it. All of the above has been a big barrier of entry for many, I'm sure.

Also, from an aesthetic point of view, I like to be able to understand the meaning of the parameters, rather than just have a big array of magic numbers. Fewer parameters (that are actually sensitive) are also easier to tune.

Regarding Center, yes we could tune it, but we must preserve the fixed points where Center = 0. These are left there on purpose, in order to prevent the auto-tuner from allowing a biais in the PST. Any biais should be removed from the PST and be put in material values instead (except for King, where you don't care, because both sides always have exactly one king).


Shouldn't need to remove this fallback.


I think you should revert this change, because now Preferences::isWebUiEnabled() will always return true for nox builds.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This was just in response to @ussuri's previous appeal for us to check for exact values.  If there is a key which is intentionally set to null, we may not want to overwrite it.  I'm not sure.  I'll  change, but let me know your thoughts.


Well, no idea if it would work, someone must test it I guess.


preprocessor directives should start at the beginning with no spaces.


I committed this to Alioth, I hope that's OK.


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.357](http://teamcity.monogame.net/viewLog.html?buildId=6406&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Апдейт 1.2.3.2 выпустили, а версию скрипта поправить забыли... Теперь вечно висит просьба обновиться))


Hey @nieldlr, when you get a chance tomorrow can you push your related changes and the build from the buffer-chrome repo to github, thanks :smile: It may be time to reduce the number of repos all these repos to simplify it all, haha


Other than a few nits in the comments and adding a couple of tests (see inline comments)  it looks good.


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


[![Crematoria, Dachau](http://api.artsmia.org/images/4112/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4112)


[![At a funeral procession for the ashes of 200,000 concentration camp victims of Germany and Austria, to be buried near the Tomb of the Kings, Jerusalem](http://api.artsmia.org/images/5533/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5533)


[![Jael Killing Sisera](http://api.artsmia.org/images/7207/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7207)


[![David Beheading Goliath](http://api.artsmia.org/images/7224/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7224)


[![Judith and Holofernes](http://api.artsmia.org/images/7227/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7227)


[![The Massacre of the Innocents](http://api.artsmia.org/images/7423/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7423)


[![PietÃ ](http://api.artsmia.org/images/7424/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7424)


[![Is this Che Guevera?](http://api.artsmia.org/images/7500/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7500)


[![Hercules Slays Cacus](http://api.artsmia.org/images/7889/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7889)


[![The Martyrdom of Saint Peter](http://api.artsmia.org/images/12945/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=12945)


[![John-John Koersohn, Who Killed His Family in 1948, In His Cell, State Asylum, Chester, Illinois](http://api.artsmia.org/images/21277/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=21277)


[![Jimmy Hilty, Who Killed Three Old Women in Peoria, State Asylum, Chester, Illinois](http://api.artsmia.org/images/21278/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=21278)


[![Wife of the Lynch Victim, Irwinton, Georgia](http://api.artsmia.org/images/21516/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=21516)


[![Hanging Men, New York](http://api.artsmia.org/images/29672/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=29672)


[![PietÃ : the Dead Christ (recto); The Mourning Virgin (verso)](http://api.artsmia.org/images/33400/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33400)


[![Saint John the Baptist Prepared for Decapitation](http://api.artsmia.org/images/33403/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33403)


[![Le pendu](http://api.artsmia.org/images/42912/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=42912)


[![The Maniac Father and the Convict Brother are Gone -- The Poor Girl, Homeless, Friendless, Deserted, Destitute, and Gin Mad, Commits Self Murder](http://api.artsmia.org/images/43505/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=43505)


[![Rue Transnonain, le 15 Avril, 1834](http://api.artsmia.org/images/43877/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=43877)


[![Perseus Beheading Medusa VIII](http://api.artsmia.org/images/44006/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=44006)


[![Birmingham, Alabama.  Dr. Martin Luther King Jr., just before he spoke at the funeral of the four girls murdered in the 16th Street Baptist Church.](http://api.artsmia.org/images/45332/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=45332)


[![Cain Killing Abel](http://api.artsmia.org/images/46065/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46065)


[![Death of Abel](http://api.artsmia.org/images/46067/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46067)


[![The Husband, in a State of Furious Drunkenness, Kills His Wife with the Instrument of All Their Misery.](http://api.artsmia.org/images/46754/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46754)


[![Saint Sebastian](http://api.artsmia.org/images/47994/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=47994)


[![The Death of St. Peter, Martyr](http://api.artsmia.org/images/48584/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=48584)


[![Judith Beheads Holofernes](http://api.artsmia.org/images/48862/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=48862)


[![The Crucifixion](http://api.artsmia.org/images/49911/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=49911)


[![The Martyrdom of St. John the Evangelist](http://api.artsmia.org/images/49919/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=49919)


[![Judith with the Head of Holofernes](http://api.artsmia.org/images/52484/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=52484)


[![Death of Edith Cavell](http://api.artsmia.org/images/53634/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=53634)


[![Untitled (The Vampire)](http://api.artsmia.org/images/53749/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=53749)


[![Christ on the Cross](http://api.artsmia.org/images/54998/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=54998)


[![The Crucifixion of Polycrates of Samos](http://api.artsmia.org/images/55172/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55172)


[![The Stoning of St. Stephen](http://api.artsmia.org/images/55301/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55301)


[![Martydom of Saint Sebastian](http://api.artsmia.org/images/55640/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55640)


[![Beheading of Saint Barbara](http://api.artsmia.org/images/55644/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55644)


[![Frankie and Johnny](http://api.artsmia.org/images/57812/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=57812)


[![That's as fair as I know how to make it](http://api.artsmia.org/images/63564/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63564)


[![Kent State](http://api.artsmia.org/images/65446/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=65446)


[![Christ on the Cross with Mary and Saint John, from the Missale Defunctorum](http://api.artsmia.org/images/66987/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=66987)


[![Photographs of the Shah's Victims in Front of the U.S. Embassy, Teheran](http://api.artsmia.org/images/82403/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=82403)


[![Martyrdom of Saint Lucy](http://api.artsmia.org/images/105873/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=105873)


[![Memory and Landscape: Unveiling the Historic Truths of Chile, 1973-1990](http://api.artsmia.org/images/119696/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119696)


[![Crematoria, Dachau](http://api.artsmia.org/images/4112/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4112)


[![At a funeral procession for the ashes of 200,000 concentration camp victims of Germany and Austria, to be buried near the Tomb of the Kings, Jerusalem](http://api.artsmia.org/images/5533/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5533)


[![Jael Killing Sisera](http://api.artsmia.org/images/7207/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7207)


[![David Beheading Goliath](http://api.artsmia.org/images/7224/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7224)


[![Judith and Holofernes](http://api.artsmia.org/images/7227/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7227)


[![The Massacre of the Innocents](http://api.artsmia.org/images/7423/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7423)


[![PietÃ ](http://api.artsmia.org/images/7424/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7424)


[![Is this Che Guevera?](http://api.artsmia.org/images/7500/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7500)


[![Hercules Slays Cacus](http://api.artsmia.org/images/7889/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=7889)


[![The Martyrdom of Saint Peter](http://api.artsmia.org/images/12945/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=12945)


[![John-John Koersohn, Who Killed His Family in 1948, In His Cell, State Asylum, Chester, Illinois](http://api.artsmia.org/images/21277/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=21277)


[![Jimmy Hilty, Who Killed Three Old Women in Peoria, State Asylum, Chester, Illinois](http://api.artsmia.org/images/21278/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=21278)


[![Wife of the Lynch Victim, Irwinton, Georgia](http://api.artsmia.org/images/21516/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=21516)


[![Hanging Men, New York](http://api.artsmia.org/images/29672/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=29672)


[![Saint John the Baptist Prepared for Decapitation](http://api.artsmia.org/images/33403/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33403)


[![PietÃ : the Dead Christ (recto); The Mourning Virgin (verso)](http://api.artsmia.org/images/33400/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33400)


[![Le pendu](http://api.artsmia.org/images/42912/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=42912)


[![The Maniac Father and the Convict Brother are Gone -- The Poor Girl, Homeless, Friendless, Deserted, Destitute, and Gin Mad, Commits Self Murder](http://api.artsmia.org/images/43505/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=43505)


[![Rue Transnonain, le 15 Avril, 1834](http://api.artsmia.org/images/43877/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=43877)


[![Perseus Beheading Medusa VIII](http://api.artsmia.org/images/44006/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=44006)


[![Birmingham, Alabama.  Dr. Martin Luther King Jr., just before he spoke at the funeral of the four girls murdered in the 16th Street Baptist Church.](http://api.artsmia.org/images/45332/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=45332)


[![Cain Killing Abel](http://api.artsmia.org/images/46065/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46065)


[![Death of Abel](http://api.artsmia.org/images/46067/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46067)


[![The Husband, in a State of Furious Drunkenness, Kills His Wife with the Instrument of All Their Misery.](http://api.artsmia.org/images/46754/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=46754)


[![Saint Sebastian](http://api.artsmia.org/images/47994/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=47994)


[![The Death of St. Peter, Martyr](http://api.artsmia.org/images/48584/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=48584)


[![Judith Beheads Holofernes](http://api.artsmia.org/images/48862/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=48862)


[![The Crucifixion](http://api.artsmia.org/images/49911/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=49911)


[![The Martyrdom of St. John the Evangelist](http://api.artsmia.org/images/49919/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=49919)


[![Judith with the Head of Holofernes](http://api.artsmia.org/images/52484/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=52484)


[![Death of Edith Cavell](http://api.artsmia.org/images/53634/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=53634)


[![Untitled (The Vampire)](http://api.artsmia.org/images/53749/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=53749)


[![Christ on the Cross](http://api.artsmia.org/images/54998/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=54998)


[![The Crucifixion of Polycrates of Samos](http://api.artsmia.org/images/55172/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55172)


[![The Stoning of St. Stephen](http://api.artsmia.org/images/55301/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55301)


[![Martydom of Saint Sebastian](http://api.artsmia.org/images/55640/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55640)


[![Beheading of Saint Barbara](http://api.artsmia.org/images/55644/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=55644)


[![Frankie and Johnny](http://api.artsmia.org/images/57812/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=57812)


[![That's as fair as I know how to make it](http://api.artsmia.org/images/63564/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=63564)


[![Kent State](http://api.artsmia.org/images/65446/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=65446)


[![Christ on the Cross with Mary and Saint John, from the Missale Defunctorum](http://api.artsmia.org/images/66987/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=66987)


[![Photographs of the Shah's Victims in Front of the U.S. Embassy, Teheran](http://api.artsmia.org/images/82403/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=82403)


[![Martyrdom of Saint Lucy](http://api.artsmia.org/images/105873/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=105873)


[![Memory and Landscape: Unveiling the Historic Truths of Chile, 1973-1990](http://api.artsmia.org/images/119696/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119696)


This is a goroutine leak. `sync.Once.Do` waits until the function returns. The one in expirer doesn't.
You can use `sync.Once` for the startup instead:

```go
db.runner.Do(func () { go db.expirer() })
```


Thats because this hasn't been merged into Forge yet. Read the change logs. The loading screen does not work with Optifine. We know this already.
Also use #644 to report issues not this commit.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/aaf80ac8cf99c128bb9f06e6193af0e4ee6d25d1/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/aaf80ac8cf99c128bb9f06e6193af0e4ee6d25d1/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/aaf80ac8cf99c128bb9f06e6193af0e4ee6d25d1/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/aaf80ac8cf99c128bb9f06e6193af0e4ee6d25d1/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/aaf80ac8cf99c128bb9f06e6193af0e4ee6d25d1/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


(Lynne Jones) Fixed.


(Lynne Jones) testmovie and opsimMovie are mostly duplicated .. I had originally not planned on committing testmovie.py (and just using it myself). But I found it so useful, I ended up committing it.
I could pull it back out of the repository with the idea that it's not something other people need anymore. The other option is to add a bit of extra engineering to opsimMovie.py so that runSlices could run on a particular slice of the movieSlicer .. but this would require either extra code in opsimMovie.py which I'm not sure if I want to do.
Perhaps I should just pull testmovie back out.


(Michael Reuter) Everything has functionally worked for me. Scott's done a great job being the code police, so once he's satisfied, I'd call this good to go.


This feature will be released in 1.5.0. I'm going to release it in the next few days.

With best regards, Ivan Kravets
- "Creative comes from talent, and never from knowledge" (c)
_________________________
http://www.ikravets.com

> On 27 квіт. 2015, at 23:49, Jonathan Beri <notifications@github.com> wrote:
>
> Which release does this go out with? Will running platformio upgrade get it? I'm currently on 1.4.0.
>
> —
> Reply to this email directly or view it on GitHub.
>


(Scott Daniel) okay


(Lynne Jones) Added docstrings.


(Scott Daniel) is mkOpsMovie.sh going to have the same problem that I had with example_movie.py (i.e. choking if you give it the absolute path to the opsim run)?  Should it accept a dbDir argument, or do you want to just rely on opsimMovie.py dying in an informative way?


(Lynne Jones) Thanks for bearing with me through this scope-creeping review :)


Thanks for the feedback!


(Peter Yoachim) Feature/OPSIM-28 values for lat lon should match
getting telescope lat,lon,elev from opsim config


#1139 changes `-type` to `--type` i believe.


(Lynne Jones) Bugfix/CATSIM-185 update sed and bandpass to replace
* Updated .gitignore to ignore 'version.py' properly.
* Updated Bandpass for 'is' None (instead of == None).
Also removed extraneous white spaces, moved """ delimiting comments onto their own starting/ending lines.
* Updated Sed for 'is' None instead of == None.
Also removed extraneous white spaces and moved """ delimiting docstrings onto their own lines.


აქ css-ის მისამართი(href) შენი კომპუტერის დირექტორიების(ფოლდერების) მიხედვით გიწერია და თუ დააკვირდები შენი პროექტის ფოლდერის გარეთ გადის. ანუ ფოლდერი, ლოკალურად შენს კომპიუტერში, რომელშიც გიდევს დოკუმენტები (html ფაილი და css ფაილი), ეს ფოლდერი არის ამ შენი ვეგვერდის "სამყარო" და მის გარეთ არ უნდა გადიოდეს (გამონაკლისი შემთხვევების გარდა).
იმისათვის, რომ html-ში მიუთითო თუ საიდან უნდა წამოიღოს css სტილები ანუ სად წაიკითხოს style.css შემდეგნაირად უნდა მოიქცე:
დოკუმენტი რომელზეც მუშაობ (ამ შემთხვევაშ index.html) არის შენი ამომავალი წერტილი თუკი css იგივე ფოლდერში გიდევს მაშინ უბრალოდ უნდა ჩაწერო style.css.
თუ მაგალითად გადაწყვიტე, რომ  style.css-ი გინდა სხვა ფოლდერში ჩადო, მაგალითად შექმენი ფოლდერი სახელად-css და იქ ჩადე style.css მაშინ მიუთითებ შემდეგნაირად: css/style.css, რითაც ეუბნები (იგივე ფოლდერში რომელშიც ვმუშაობ) არის ქვედირექტორია-css  და ამ ქვედირეკტორიაში (/) დევს style.css.

ასეთი პრინციპით, სადაც არ უნდა გადაიტანო შენი პროექტის ფოლდერი, მაგალითად სხვა კომპიუტერში ან თუნდაც სერვერზე ატვირთო ყოველთვის სწორად წამოიღებს მიბმულ ფაილებს.


(Scott Daniel) here is an == None that got missed


(Scott Daniel) should there be spaces on either side of the == for consistency?


(Scott Daniel) Here is an ==None that got missed


Yeah, I had noticed that and squashed it out after making the initial commit. All gone now.


(Scott Daniel) Here are several == None lines that got missed


(Scott Daniel) Here is an == None that got missed


აქაც იგივე პრინციპით უნდა იხელმზღვანელო