I see. I didn't know about the trick and considered it as a bug sorry.
Anyway, I worked mainly to fix memory leaks and failed tests.
Please, re-add the fix properly.

Thanks. Dmitry.

On Tue, Apr 14, 2015 at 9:19 PM, Stanislav Malyshev <
notifications@github.com> wrote:

> I don't think what you did here is right. You essentially undid the whole
> patch, since after your change you can change http_response_header again
> from the outside, since its refcount is not incremented anymore. That was
> the whole point of the patch - to increment the refcount so that change
> would not break response_header var.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/php/php-src/commit/28011fd14f9101adcfa92209039be6b218df5195#commitcomment-10720307>
> .
>


oups, sorry for that.


TeamCity xBIM :: XbimExchange :: Build [Build 217](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1372&buildTypeId=XBIM_XbimExchange_Build) is now running


Thais, estavamos com duvida nisso, mas preferimos colocar o nome por acharmos que "eu" ficaria muito pessoal para a questão. Mas nesse caso, ficaremos de olho nisso nos próximos assuntos.


Eu acabei confundindo, obrigado por levantar esses pontos.


Ok, though a bit painful to have to do!


TeamCity xBIM :: XbimExchange :: Build [Build 217](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1372&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:24


Ok


About error handling, please look into ```AUGMENTEDSZN-237``` issue in Jira


Airbnb suggests opening a module with ! instead of wrapping it in parens.  Is that a different usage, or should we use that instead?


1. It should be `dla Internet Explorera`
2. I belive `Flash player` is incorrect. It should be full name `Adobe Flash Player`.


These images are missing and need to be created.


Ok. Sigh.


Cambiada la funcionalidad de la clase Comando:
- Ahora crea el archivo de comandos si no existe, al igual que el directorio que lo contiene.

Cambiado los campos de la clase ListaComandos para que sean más fáciles de recorrer y con menos código.

Añadido el método LeerArchivo() a la clase ListaComandos para que se metan en memoria todos los comandos y poder recorrerlos de forma aleatoria para los Tests.

Métodos PreguntarCom() y ListarTodo() de la clase ListaComandos lanzan NotImplementedException

Añadido el archivo de nomenclatura de los componentes de la interfaz Gráfica.


Good.


This was the last thing needed: of course we need to unset the wrap for any element, not just Image. The same goes for BlockGrid.


Yep, `duplicate` is the one have here.


@robrbecker I was thinking you could quickly comment and merge the sample PR while I was talking about resolving merge conflicts. That way it would be ready when I get to the slide.


Based on your module example, I put the local variables in an object, but it makes some lines a little less readable later on (i.e. data.date[data.days.getTime()]).  Is it best practice to place them in an object like this?


sory for long time of my answer
i testet it on a RPi with newest resbian
and every thing work perfect
mayby your prndrive has wrong label
by default label is set to "[1GB](https://github.com/vonProteus/RPi-OBABP/blob/master/src/obabp.py#L13)" you can change it if you want


Should this be indented two levels instead of just one?


This line is unnecessary. Should be removed before release.


```jsonList``` is a variable's name that is not descriptive at all. Better option would be ```pois``` or ```pointsOfInterest``` or something that will tell us what is in that variable


@jasondegraw  It is in the same place that oconv is in on my c drive.  This
should find it the same way right?

Thanks,
Craig Casey

Ph.D. Candidate
Architectural Engineering
The Pennsylvania State University

IES 2015 Annual Conference Steering Committee Chair

On Tue, Apr 14, 2015 at 2:14 PM, Jason DeGraw <notifications@github.com>
wrote:

> That sounds like it isn't finding the program. You sure it is in the path?
> On Apr 14, 2015 12:05 PM, "Craig Casey" <notifications@github.com> wrote:
>
> > @jasondegraw <https://github.com/jasondegraw> There seems to be an error
> > here when running rcontrib. The error is "The system cannot find the path
> > specified". Any ideas why this would occur from the STADICprocess side?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Architectural-Lighting-Simulation/STADIC/commit/16ba5e06d15eacc8c4bf19abba459f6a1e1cf49e#commitcomment-10720047
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Architectural-Lighting-Simulation/STADIC/commit/16ba5e06d15eacc8c4bf19abba459f6a1e1cf49e#commitcomment-10720212>
> .
>


@dkayiwa I am saying that Submit should be before Cancel in the tab order.

I would like you to make an informed decision about what should happen when the user keeps pressing tab at the end of the form. (It should be consistent with general good web usability, and it should make sense in the context of the Simple Form UI with multiple sections.)

I don't think that websites typically stop letting you tab on the last element, but rather they go back to the first tabbable element on the page. But I leave it to you to decide on the correct behavior.


This line should be in its own file.


Looks good.


Ok


awsome!


"This is **a** multiplex..."


There's no other Flash Player :p But yeah that is the full name.
On Apr 14, 2015 9:34 PM, "Kacper Michajłow" <notifications@github.com>
wrote:

>
>    1. It should be dla Internet Explorera
>    2. I belive Flash player is incorrect. It should be full name Adobe
>    Flash Player.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Underground78/mpc-hc/commit/a8d5ca44f6f4350a1923776615699a70360a3230#commitcomment-10720637>
> .
>


That's because you comment on the commit and not on the PR :smile:


Zachf I understand.  I was just screwing around one day.  I do have a working cm11 build that I made if you want me to post it on XDA since you lost the last build.


We have two cases in our travis matrix
 - CRAN Rcpp
 - devel Rcpp

So I guess I'll start using this when the macros at least work for CRAN Rcpp and we require high enough version. No big deal


OK.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


O cenário está errado mesmo, como é uma GUI, não deveria dizer que foi criada e sim, que os detalhes da questão de artigo.


As discussed previously no methods should be unnamed. The fact that they are in the reference implementation is a bug in Traceur: https://github.com/google/traceur-compiler/issues/1879


Oh, damn, I see now what happens. There is still a safe way to keep open-uri, by calling `URI(url).open`, if we wanted to keep it.


We may omit `Adobe` part. But `Player` should be uppercase regardless.


xcxxccxcx


Since date is a new Date object by default, setDate isn't required before getDate can be called.  Should date remain undefined instead?


just the part that left the else: indendted, fixed in #10701


Eu esqueci esse dados extras. Mas uma dúvida, no caso, esse "And" sairia e eu aumentaria o "When" com esses novos dados.


As per this commit, on reaching the end, tabbing takes you back to the first field of the first section.


Ok


Is there a reason not to merge `run_server_until_file_changes` and `run` into one function that does both the loop and the worker handling?

Also it occurred to me that we may be able to learn from supervisord re starting a subprocess again once it has ended. I haven't dug into why things aren't working well on my laptop yet but will try to do so on my next flight.


Thanks very much :)


Merged as part of fef18fcf8c6421f92a20bab40b10bbc367a42fdc


This might better be implemented by injecting chunks of arbitrary config from Staticfile into conf/nginx.conf


Assigning 0 to a QByteArray makes little sense to me; the proper thing to do is call clear() on it.

so I suggest in two lines;

log.clear();
 if (svnlog) log = svnlog->data;


Heh, looks like my crystal ball is working after all ;-)
Thanks for letting me know. Looking forward to see this refactored!


Is it ever appropriate to use lenient equality?  At first I wanted to check if returnObject == true in order to allow 1 as a valid argument.


Looks like a good idea to me, definitely!

Thanks for the merge request :)


@yorikvanhavre I'm starting to refine the details. I've started using Revit's materials as well--figure you'll be able to accommodate them in the near future.

![screenhunter_266 apr 14 13 39](https://cloud.githubusercontent.com/assets/507113/7144525/c12755fc-e2ab-11e4-9215-00f7f26aac29.jpg)


Agreed. Using the full name seems the best though.
On Apr 14, 2015 9:41 PM, "Kacper Michajłow" <notifications@github.com>
wrote:

> We may omit Adobe part. But Player should be uppercase regardless.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Underground78/mpc-hc/commit/a8d5ca44f6f4350a1923776615699a70360a3230#commitcomment-10720759>
> .
>


rax retry tests


I didnt actually loose the build, the CM11 builds were too large to put on the phone with a gapps package. If I removed anything else of worth it would kill the build because things like email are needed to compile as pieces of its source are called for other things during the build


Why is this in program and not utilities? I thought functions in utilities could also be exposed in the d.ts


Also fixes #74


What is the purpose of gcRec?


I did as you suggested and unit tests still pass but there is no trace. I
think it has to do with unittest, threads, singletons etc etc . I remember
having same problems with googletest and using the same approach (self.uut)
but I am not sure why this still applies to Python.

El mar., 14 de abr. de 2015 a la(s) 3:28 p. m., Christopher Felton <
notifications@github.com> escribió:

> It is how traceSignals resolves what to trace, when self.uut was used it
> didn't trace any signals.
>
> Why did the tests fail? It should get a new instance of the r22sdf each
> time, it should be a clean and safe way to test. Do the tests rely on
> previous state?
>
> Another option could be to leaeve self.uut and create a local reference
>
> def _test():
>     uut = self.uut
>     ...
>     return uut, ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cfelton/r22sdf/commit/2da18d1cca47176547232c164b6146870803ed0e#commitcomment-10720474>
> .
>


Airbnb says to use parseInt when working with numbers, should I have used that here or is it not necessary?


Yeah, that's how it works/should work


This seems like a fragile way of finding the right version of gcc, but I don't know any better way.


@ehuang3 Do you know if there is a reason the engine forces are applied in this order or could this just be made into a for loop?


This is a side effect of PUT being the generic verb. I could make the call and get the error, but I wanted to encapsulate that checking/backoff.

The only reason I return whether it was created is because the response code is different.

In short, REST has its limitations.


I'm now using ...
```
                                 help=('Set the maximum amount of time (in SECONDS) that '
                                       'tests are allowed to execute. '
                                       'Note that zero means "no timeout". '
                                       'You can also use suffixes, like: '
                                       ' s (seconds), m (minutes), h (hours). '))

```


Most recipes are agnostic to the compiler they use, so I think it would be best to just put these lines in `spams/build.sh`


uncomment the debugs


if the password was changed or reset, we return the hash... it was on the list in https://github.com/coreos/etcd/issues/2384 ("return hashed password when updating password")


uncomment async


Good point, fixed it.


uncomment debugs


remove commented lines


yes. this would be the only one though. fine with me to move it, it just felt more related to program than general.


as written in the commit message, yes. It's tested by `avocado list` as without arguments it uses `.` and `examples/tests` is part of it. Without this patch the same command exits beautifully, try it :smile:

PS: Really credits to Kernel developers for this bug as I noticed it because I was compiling kernel-4.0.0 in `/tmp` while working on avocado and `avocado list /tmp` returned 0 without any messages and with `stty -echo`... So thanks to their ugly code we have better Avocado :smile:


@chrissprague external css please


NOPE! U SHALL NOT PASS!


you probably meant to check track3.exceedsMaximumLength() instead of track2 twice!


nope. otherwise you would also unistall it no?
this allows for example to test different version


@chrissprague why not just extend base.html?


I honestly think that open-uri is just fundamentally broken, and rest-client is tiny, so I don't really mind the extra dependency. I think I feel better about using rest-client here rather than open-uri.


@CraigCasey I think it would be better to use the other constructor here and not use the arg setting method:

    RadPrimitive *black = new PlasticMaterial(0,0,0,0,0);


OK, I thought that too but I wasn't sure if we miss something in this handleError. So thanks for the reassurance.


Recursive include that wasen't actually finding the "AnnPhyisicsEngine". MSVC get along with it but GCC needed that hack


Should userprefs get checked in?  Should it be an a .gitignore for this project?


Using both `test_deadline` and `job_deadline` then `time_deadline` for the next PR.


And, do you think that's the correct behavior?

On Tue, Apr 14, 2015 at 2:42 PM, dkayiwa <notifications@github.com> wrote:

> As per this commit, on reaching the end, tabbing takes you back to the
> first field of the first section.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-uicommons/commit/97618792e7adc5a90ef1a3471e403c451148d1fe#commitcomment-10720774>
> .
>


FWIW this was originally submitted as https://gitorious.org/svn2git/svn2git/merge_requests/23.

There was [a different pull request for the same bug on Gitorious](https://gitorious.org/svn2git/svn2git/merge_requests/19), that I hadn't noticed before attempting to fix this myself.  Maybe it's better?


This could just be returned as this

```php
return (strcasecmp($url, $rel) === 0) || root_relative_url($url) == $rel;
```


This `else` is unnecessary since its the last one.


@ldoktor you can always count on kernel developers writing Python code! Just think of autotest! OK, that was a joke... :smile:


Test page


No need to use `elseif`, it can be replaced with just an `if`.


Can you give instructions I can leave in a comment for enabling GCController in Safari/WebKit/JSC (whichever)? I am planning to leave a note like `// Use --expose_gc for V8 (and io.js)` and want a similar one for Safari/WebKit/JSC.


You whant i change that ?   ;-)


Oh, and sorry for missing that part of the commit log message.


Yes. Though @wluyima seems to suggest otherwise. :)


Why is this one exposed?


Since you're returning more than one individuals, this should be `getIndividualsGivenGene`.

`Given` is not very user friendly... Would it be accurate to call it `getIndividualsWithGene`?

Same for the next method.


O problema não está no uso do AND. Na verdade, ele já está no WHEN. Do jeito que está escrito aí, seu when tem 2 steps (para não repetir o termo when 2x usou-se o AND). O X da questão é que vc precisa reescrever essas duas linhas de when (linhas 37 e 28) conforme comentado...
O objetivo do cenário é cadastrar uma nova questão argumentativa, certo? Então a ação no when deve ser a criação de uma nova questão argumentativa. Toda questão tem um conjunto X de atributos, vc precisa especificar no when quais são os valores desses atributos para a ação se concretizar. Foi isso que tentei dizer no meu comentário.


But i dont whant to see the message too.


I think we need separate recipes for building C++ dependencies with `libc++` and `stdlibc++`.  It sucks, but I think the only "proper" way of supporting both versions at the same time is conda-build ["features"](http://conda.pydata.org/docs/build.html#features).  I haven't experimented with that mechanism yet, so I can't say for sure that it will solve our problem.

If you were assigned to work on the ilastik build system, I'd say go for it.  But I'll understand if figuring this out isn't a top priority for you in the near term.  In that case, I think the best way forward is for you to just maintain a separate fork of ilastik-conda-recipes (or make your own recipe repo altogether).


Weren't these functions already in module ts? Why move them to another declaration?


A latter "I" is missing from the filename


Ah, gotcha. I got confused by "once you get to the the it is pretty easy to figure out. Could we also add the link to the repo's URL?"

I've also added a link to the production app to the GitHub repo page:
![screen shot 2015-04-14 at 12 58 53 pm](https://cloud.githubusercontent.com/assets/994938/7144980/510d4a88-e2a6-11e4-97fa-331fd2fc9376.png)


FacilityTabGridView (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2176 of 2196 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.09%25-yellow.svg)


dfdf


Oh I get it now. The other declaration is marked internal. So any nested internal will have no effect, and to expose it you have to move it to a non-internal declaration


You are deploying with capybara :stuck_out_tongue_winking_eye:


you misunderstood . if rho is defined then it gets the value. if not then it sets the value to the default one in get
i don't think get_optional is the right interface. the code would be heavier


wrong to send body on a **GET** request, of course.  Fine on PUT.


would it make sense to move defaultLibName in here, or is this module implicitly only for text span related stuff?


I'm trying to make some rhyme or reason out of where things are defined


creo deberia ser:
  /* Copyright 2014, 2015 Mariano Cerdeiro
   * Copyright 2015, Esteban Volentini


Will do.

@kasper93: MS really translated Internet Explorer in Polish?


I think something in this commit broke login for me, are you having the same issue?


error


no me encanta comentar codigo, mejor

#if 0

o

#ifndef CIAADRIVERUART_DISABLE_SEM


Drop


Ahh ok. Eu tinha entendido então, é que eu tenho costume de escrever novos dados, no lugar de tudo. Queria dizer se era para inserir os atributos como parametros para os dados, como você comentou. Valeu (;


Nice!


Thank you


That should say '!! Fire Ball'. Apparently bash converts !! to the last command used, even inside quotes.


Is it better to avoid automatic gc? Maybe some users will disagree


"either ..... IS not met" (instead of are)


dos lineas, pero a mi me podes sacar, hice solo el archivo.


I think the usage of 'epoch = 0' that is part of this merge request is better than the gitorious solution.


Isso.


Didn't know that... thanks!


No, it does not, you're right :grinning:


the cmake process will be adapted soon


Tiene en cuenta que es un borrador, lo subí solo para que lo veas.

Ing. Esteban Volentini
www.equiser.com.ar
Dir. Servicio Tecnico
Santa Fe 2037 - T400EOQ
San Miguel de Tucumán

El 14/04/2015, a las 16:05, Mariano Cerdeiro <notifications@github.com> escribió:

> no me encanta comentar codigo, mejor
>
> #if 0
>
> o
>
> #ifndef CIAADRIVERUART_DISABLE_SEM
>
> —
> Reply to this email directly or view it on GitHub.
>


esto tiene que ser con un ifdef o algo asi, asi no se puede mergear nunca :(


@cryptoDK done with my review. checkpoint complete.


Pass the current container's 'ephemeral' value


Yeah sorry that's what I meant.

I can words.


imde tema anterior


Seems to be nice, we're running it every 30sec instead of 1sec if I read well :). Good job! We need sticky sessions and it'll be bullet proof!


looks great! thanks


If I understand you well, you are running your sketch and opening the serial monitor to see the serial port traffic. If you do that, the communication from the Arduino board to the PC is received by the serial monitor and not by the `OAC_CMDGW` script running on the simulator. Actually the Lua script will fail to open the serial port since it is used by another process: the serial monitor of the Arduino IDE.

Try to follow the [user guide](http://openairbuscockpit.org/software/command-gateway/) and do not open the serial monitor. Run your sketch and, if you want to see the activity in Command Gateway, you can open and read the log file as described in the user guide.


This would basically produce an error in case of an equal area grid (in which the difference between two neighboring longitudes varies across the domain). If you do not handle equal area grids then this is fine. Otherwise, you may need to check this (and maybe specify this explicitly in a comment)


fixed


como sabemos que es un bug? esta reportado, si si un link seria bueno :) en forma de comentario en el codigo claro.


Eso esta claro, es un borrador como para que veas los cambios que hay que hacer. Lo que pasa es que no estaba decidido si queda firme o no, entonces use el camino mas corto.


:+1: thanks


I think it is still wrong.
IMO the following considers all possibilities:
```c++
if (!(queue < 0 && queueR < 0)) {
    if (queueL > 0 && queueR > 0)
        return queueL < queueR;
    else if (queueL < 0)
        return false;
    else
        return true;
}

//both seeds so continue to sort by date or hash
```


move LO icons to the main folder cause the icons are not important for kde/plasma


No esta reportado, per los lazos contaban hasta 8 en lugar de hasta la constante definida. Al cambiar la cantidad de entradas me di cuenta. De todas formas si va a quedar definitiva una versión de DIO que sports ambas placas la corrección va a hacerse automáticamente cuando hagamos el marge de esta version con la origina.


is this even needed, since we're doing the compile check of `dm_task_deferred_remove()` in `./hack/make.sh`


I haven't seen any code that makes me believe there is any chance of `src` being something other than a `BufferedImage`. Add an assertion and blindly cast to a BufferedImage (the WMS tests do this internally). Remove the other code. If it turns out otherwise, we will find out during testing.


Давай приведем весь код в одинаковый вид:
для полей класса префикс "my"
для статических приватных полей -- "our"
публичные поля -- большими буквами через подчеркивание


Why haven't you released new binaries on https://teeworlds.com? Is it a deliberate choice?
Also, if not you've forget to add the 0.6.4-release tag.


Is there a cleaner way to do this check?


hi


Why else is bigger then first if step :/ method and class opening symbol must start in new line. There would be nice to see splited selects in new lines :) Good luck


Nice! Early returns tend to be a bit easier to scan than deep-nested if blocks, since most of a function's code is skipped if some conditions aren't met and the function returns early.

In JS you tend to see early returns as the result of validations (so for example checking that the arguments passed to your method are correct or as expected) or, like in this case, when there are errors.


It's not relevant if the code is deployed in a different directory.


Closes issues #5 and #6


CoinWidgetCom.loader.script ({


Fix pensandoodireito/participacao-sitebase#71


wrong


I disagree with both of you. :-)

I would expect that the confirmation screen to behave like a modal popup,
and pressing tab multiple times cycles through only the elements on this
screen.

But I'm open to other perspectives, and I don't think this should delay our
release.

@Dave, quick BA question for you: On the confirmation screen of the
Register Patient app (and other question-per-screen apps), what would you
expect to happen if the user presses tab many times?

-Darius

On Tue, Apr 14, 2015 at 2:57 PM, dkayiwa <notifications@github.com> wrote:

> Yes. Though @wluyima <https://github.com/wluyima> seems to suggest
> otherwise. :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-uicommons/commit/97618792e7adc5a90ef1a3471e403c451148d1fe#commitcomment-10721115>
> .
>


Ah, good catch!


Exactly.  RVIC doesn't support routing on an equal area grid (only regular lat/lon grids).  If the user wants to do routing on an equal area grid, they should use `REMAP==True` to map from the routing grid to their land surface model grid.  In principle you could route on a irregular grid but I doubt the current code supports that, so raising the error here seems ok.


Where will be nive to see
 $eci = 2;
if ($this->request->post['CARDTYPE'] == 'VISA') {
$eci = 7;
}

:) we dont need else. And recomend constants put to class constant


Are you kidding me? :)


> I think it would be best to just put these lines in `spams/build.sh`

If you prefer.

The only reason I put them here is I thought @chaubold might appreciate having them.

> This seems like a fragile way of finding the right version of gcc, but I don't know any better way.

Yeah, it was tricky to find a solution. Other environment variables besides `PATH` weren't respected by `conda`, which I manipulated to get these to work.

I did notice `conda` had their own `gcc` recipes, but I don't know about going that route.


nice


@mekolat I think these emoticons look a little strange when coming from an NPC. What do you think?


Reviewed by Shai


Yeah, probably could combine those. I'm working on a much bigger rewrite of the whole approach, because it turns out this approach is broken in some fundamental ways that aren't revealed by our tests. For one thing, we don't ever reload the serve callable in any way, so although we restart things at the right times, we always restart using the old app, not using the new code. That probably isn't what people want from this :-) I've already got the tests modified locally to verify the new app code is actually loaded and used, working on an approach that fixes it. (And yes, learning from supervisor is very relevant, because I think doing this right is going to require working more at the subprocess / shell command level rather than at the Python level).

Also our current approach doesn't work with gunicorn, because gunicorn does signal-handling stuff that you are only allowed to do in the main thread. So the idea of running the actual server in a thread won't work - the server needs to be in its own subprocess.

So... maybe don't spend too much time worrying about why the current approach isn't working on your laptop, because it doesn't really work in general :-)


This one is checking for kernel capabilities and not libdm capabilities.


No, but it needs declension. http://en.wikibooks.org/wiki/Polish/Masculine_noun_declension It is singular genitive.


One might be running on older kernel with newer libdm. It will cover that case.


Wouldn't it be an `F[B]` in a `G` context?


You are right, fixed.


There is no new line at the end ;)


Couldn't make ELive15, but I have a buddy going. I hear you prefer console. :+1:


Do not cross mount points when copying recursively.


```ceylon
'\{#0000}'.predecessor
```
> ceylon run: -1 is not a Unicode code point
ceylon.language.OverflowException "-1 is not a Unicode code point"
	at ceylon.language.Character.codepoint([Character.java:332](https://github.com/ceylon/ceylon.language/blob/f9ac1489044f29f319d2a2017daf263a1a679726/runtime/ceylon/language/Character.java#L332))
	at ceylon.language.Character.getPredecessor([Character.java:212](https://github.com/ceylon/ceylon.language/blob/f9ac1489044f29f319d2a2017daf263a1a679726/runtime/ceylon/language/Character.java#L212))
	at tmp.run_.run(run.ceylon:2)


Is 0.11 still needed here? Everyone should update to the stable 0.12 anyway and 0.11 is not a monolith, API was broken multiple times between versions so it's testing against 0.11.16 only.


Лучше const T& t
(потому что T вполне может быть большим и сложным)


created


tsk tsk, merge conflicts snuck in :(


+1 Looks good, nice abstraction. I did not test.


It doesn’t even jump gaps:
```ceylon
'\{#085F}'.successor.integer
```
> ceylon.language.OverflowException "2144 is not a Unicode code point"
	at ceylon.language.Character.codepoint(Character.java:332)
	at ceylon.language.Character.getSuccessor(Character.java:222)
	at tmp.run_.run(run.ceylon:2)


Я бы не стал тут хранить результат снова в value. Тут это конечно неважно, но вообще это плохая привычка, мне кажется. Переменная по возможности должна иметь один смысл.


This change could have been me as I might have been logged in under a different UID that is no longer valid.


I would write
```
if (journal.debug) journal.debug <<
    masterKey << " " << comment;
```

Rationale: The `<<` operator offers little value to the reader. Putting it farther to the right puts the other, higher value information farther to the left (the value of a column of text decreases with increasing distance from the left margin).


Интересно, что можно оставить только эту строчку, без if. Она всегда делает то, что надо.


Journal objects are lightweight and copyable, there's not much gained by passing by const ref although there's certainly no harm.


It was a long time since I last C++d for money, but AFAIU
```cpp
QByteArray len;
len = 0;
```
ends up calling [QByteArray.operator=](http://doc.qt.io/qt-4.8/qbytearray.html#operator-eq) with a new `QByteArray(0)`, created using the [QByteArray(const char*)](http://doc.qt.io/qt-4.8/qbytearray.html#QByteArray-2) constructor.  Wasteful, but should work -- if that constructor accepts null strings.  The documentation doesn't say :(

(The sibling [QByteArray(const char * data, int size)](http://doc.qt.io/qt-4.8/qbytearray.html#QByteArray-3) constructor explicitly says that `data` can be `0`.)

`log.clear()` is clearly better, even if less concise.


left


Ah, like in Latin or German but I wouldn't have thought it applies to
English names.


@gwendalaze, well, I can't get it by just looking here :laughing:
I'll test its behaviour in game and we'll see how it's done


Но тут, если я правильно понял вашу мысль, можно передавать и по ссылке.


Why with templates we write `x-deutsch` first and then clients classname? Because markup is inconsistent? But this is not always true. From my experience localization fixes are required not because of inconsistent markup but because of the longer words then default localization has.


Насчет адаптера я думаю, это не совсем верно, адаптер можно реализовать и без указателей. Например ваш шаблон queue - то типичный адаптер для list в интерфейс очереди.


Oh OK sounds good.  I was just glad to get it to build.  It was my first cm build ever and I was excited.  Thanks for your work.


@plusCubed @teslacoil have you guys ever experienced *cannot acce…
…ss first() element from empty list* when generating an APK?


Isn't that quite heavyweight? For a PR commit, I think the current Git section covers the most important points and is not too much text to intimidate contributors.


no need to put it on a new line, you can just put after "the cakes will be delicious..."


Is this going to work with `ciphersuite` being a `map[string]ConnectionCiphersuite` ?


Translations need to be updated.


Тут похоже я непонятно написал условие. В этой задаче надо сортировать не по сумме n последних цифр, а по числу, составленному из этих цифр. (Так же, как мы сортировали на занятии по последним 2 цифрам).


Plz fix this


maybe used list 'collection' to simplify the conf file

example:

#FirewallRuleSet unknown-users
list unknown-users 'allow udp port 53'
list unknown-users 'allow tcp port 53'
list unknown-users 'allow udp port 63'
list unknown-users 'allow tcp port 63'


Probably add the same section in localizations area? `localization.scss` file should also be created there with imported localization scss files from `/localization` folder.


no


Actually, turns out we have a test which verifies that just that thing is possible. See `GafferTest.DispatcherTest.testDispatchIdenticalTasks`. Should I change that test to throw because of cycles then?


Sorry, I should have been more clear.  Purely in the context of this PR, including `VMware` in the family and product values didn't seem right, but this is the same approached used in other fingerprints in Recog and elsewhere.  So, while it may not be correct, consistency is more important.

In other words, what you had originally was OK.


I built and tested this on the same repository mirror mentioned in http://svn.haxx.se/users/archive-2013-02/0160.shtml: no segfault.


But that would break for a lot of people already using the Objective-C version. I'd keep both of them and mark the original one as deprecated (https://guides.cocoapods.org/syntax/podspec.html#deprecated_in_favor_of).

This would also make possible not update to the Swift version now. I know a lot of people who isn't using Swift yet because of the runtime needs to go inside the app's bundle, increasing its size in about 5 to 10MB.


Yup. That is indeed a typo.


Thank you! I was missing this option so much... :)


Выложи, пожалуйста, папку .idea на гитхаб (см https://devnet.jetbrains.com/docs/DOC-1186)
Выкладывать надо всю папку, кроме workspace.xml


Wrong repository! :) This is rubygems-servlets silly goose!


Давай заведем логгер, куда вся полезная информация будет записываться.

Например, private static final Logger LOG = Logger.getInstance(CacheChartsToolWindowFactory.class.getName());


Thanks Jan, would you consider changing the name here to setTrack versus ReplaceTrack?

We have been using setTrack in the ORTC API for nearly a year and now there are at least a few implementations that are well along now that are using it.


see http://wiki.openwrt.org/doc/uci


It is used like that everywhere, it sounds better when reading. Probably more formal form would be `dla przeglądarki Internet Explorer` which means `for Internet Explorer browser`. In this case the name can be left untouched. It might be better to use this instead.


> It sucks, but I think the only "proper" way of supporting both versions at the same time is conda-build ["features"](http://conda.pydata.org/docs/build.html#features).

Interesting, I saw that on first skim, but didn't worry about it initially. Probably, should be using that to track VIGRA and Boost versions that we build against (amongst other things) if I am understanding it correctly. So, this would mean two Boost that were built differently and such?

> If you were assigned to work on the ilastik build system, I'd say go for it. But I'll understand if figuring this out isn't a top priority for you in the near term.... I think the best way forward is for you to just maintain a separate fork of ilastik-conda-recipes (or make your own recipe repo altogether).

No worries. The main intention was to get it up and going so I can be more nimble. I was just hoping that I could aid that shift for ilastik too, but you're right I can't spend too much time on this right now. If you don't mind, let's keep this PR open until either of us or someone else has a chance to look at it and do a proper fix later.

Since you have a clearer idea about the "features" feature, maybe you could add an issue to memorialize this.

In the meantime, I think I will begin work on a separate repo, but will try to clean up what I can to get the rest of the PRs in. An inelegant, but working solution may be to use binaries I generate in.


Wow! Deze is huge!


поле minimumChartWidth может быть static, как и следующее


@DanielRosenwasser  don't know why.  Could have to do with inlining/engine type inference but could also be a subtle change in semantics introduced by the change that led to a parameter difference.

I think it's worth putting this back in a branch and then profiling it.


@carabalb I think snapshots being disabled here is why your new artifact isn't being found.  Any thoughts on why this change was made?  I do remember now that had to have my pom.xml modified while I was doing this work, to enable snapshots on some of these repos.


BufferedImage currentChart = null;
currentChart = getCurrentImage();

Зачем разделять на 2 строки? Значение null все равно никогда не используется


PlayServices aren't free software, therefore any application that uses it (compile time) can't enter F-Droid repo. One solution could be that you create another build recipe specifically for F-Droid (if possible) which wouldn't use PlayServices.


Не обязательно инициализировать null'ом, потому что дальше однозначная инициализация.


Более короткая и читаемая запись:
currentChart = next ? getNextImage() : getPrevImage();


Ah, hello backend difference again :(
> 1114111
> 2144


Never mind. I've pushed the fix to master. 4ba212c


Yes this annoyed me too. I know the test that's failing too.


ahh good catch!


можно сразу возвращать ImageIO.read(new File(myCharts.get(myCurrentImageIndex).getPath()));
потому что переменная currentChart больше никак не используется


Hm, do you really consider that to be a real-world use-case? And beside of that another byte would be necessary per entry in the array and - very, very bad - a misbehaving module may easily delete foreign modules timers if scheduler_delete_timer() is called twice by accident. And if someone really, really wants to use such a construction it may be easily implemented on the called modules side.


file.getExtension() может вернуть null (см аннотацию @Nullable в VirtualFile), соответсвенно выкинется NPE


Wouldn't it be better if this method allows localized messages like ```return isset($this->failedLoginMessage) ? $this->failedLoginMessage : 'These credentials do not match our records.';```?


>So, this would mean two Boost that were built differently and such?

Yes.

>maybe you could add an issue to memorialize this.

Instead of opening a lot of issues, there is a TODO section in the readme.  It already has a TODO item for this.


Chorei.


what happens if pageId is null ? maybe checkThatInternalPageExists should throw exception in that case


@Rarst:

does changing [line 366 of test-class-opengraph.php](https://github.com/Yoast/wordpress-seo/blob/trunk/tests/test-class-opengraph.php#L366) to this:

```php
$expected_output = '<meta property="og:image" content="' . plugin_dir_url( 'wordpress-seo/wp-seo.php' ) . 'tests' . $image . '" />';
```

fix it for you?


Great commit :)


Should it change the demo page automatically?
https://www.mapbox.com/mapbox-gl-styles/#9/40.0000/-74.5000

Fabien


Was in the middle of preparing a pull request for this, when I got pulled away by something else at work :-).

The request is #3280


an NUnit test (which would compile to a .dll you could run) to prove the strings are the same aside from whitespace can be found here:
https://gist.github.com/StellaCannefax/076162ecf1664f8d8255


A good start!


Fred, I'm reviewing the patch re: MathML. Added a question to the bug report if you could review asap.


Looks good


Nit: I think it makes more sense to just move this clause outside the while loop (we can skip the "ugly" `hasattr` call that way), and then otherwise set heartbeat to None:

```python
if self.server.heartbeat:
    now = time.time()
    self.heartbeat = now + self.server.heartbeat
else:
    self.heartbeat = None

while True:
    ...
    if self.heartbeat is not None:
        now = time.time()
        if now > self.heartbeat:
           self.heartbeat = now + self.server.heartbeat
           self.send_ping()
    ...
```


comento.


@khipkin Wouldn't extending `base.html` bring in the navbar + carousel (etc)? I don't want that on the 404 page, because the 404 content explaining that an issue occurred would be lower on the page; you'd have to scroll down to see it.

If not, then yes, I should have just extended base. :gemini:


Имеет смысл записать в лог, что произошло. Потому что иначе невозможно будет обнаружить, где проблема


<p>wtwfwfwf<p>


Is that part of the SymbianGCC tools?

https://github.com/xsacha/SymbianGCC/search?utf8=%E2%9C%93&q=sbs

Not sure where to even find it.

-[Unknown]


IMHO, and I think @ldoktor also mentioned this, just `deadline` is fine (already associated with time).


для этого есть ProjectCoreUtil.DIRECTORY_BASED_PROJECT_DIR


What about also using `deadline` here?


лишний импорт -- чтобы этого избежать в дальнейшем надо включить в настройках Editor->Auto Import->Optimize imports on the fly


şlmşknşkn


cgfhdsvbryjrtdfc


margin вполне может быть локальной переменной


rax retry tests


chartWidth, кажется, нигде не используется


fixed in 167866


This makes expected string look meaningful, but the output it checks against is still broken.


> Instead of opening a lot of issues, there is a TODO section in the readme. It already has a TODO item for this.

Ah ok, sorry, must have missed this.


Dette er en ny test


test


В идейском проекте решили отказаться от сгенерированных комментариев про то, кто создал файл. Потому что эта информация устаревает и занимает место. Гораздо быстрее получается получить информацию про то чей файл проаннотировав его (правый клик на gutter панели)


@Diego-F-Aguirre not much here to look at. did all the files get committed?


Where does the `calitech` come from?


What is the output?

On Tue, Apr 14, 2015 at 9:56 PM, Andrey Savchenko <notifications@github.com>
wrote:

> This makes expected string look meaningful, but the output it checks
> against is still broken.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Yoast/wordpress-seo/commit/1bced05f41f565e968e3f5b190b0e6a4006e93f4#commitcomment-10722239>
> .
>


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.198](http://teamcity.monogame.net/viewLog.html?buildId=6138&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Uma coisa que eu estou fazendo em arquitetura é um sumário com os dias para acessar rapidamente qualquer data, quando tiver mais aulas eu vejo de implementar aqui também


Why did you change this? I thought it was your first book?


There is a `TaskStepController` right, so wouldn't there be a `TaskStep` entity?


teste


I'm well aware of my formatting being an issue, but things that are commented out generally were features I a) was working on,b) a piece I didn't know how to integrate, or c) a way for me to remember my own code and the progress I had made since it started.

I think tossing out the ranking out of object constructor makes some sense. IT was a vestigial part of a feature I have since had to discard due to how much time I had spent on it already, versus how much time remains in the course, and subsequently, how much less time I have to finish future assignments.

Thanks for taking interest in my repo,

Tosi


Fixes #1.


GroundDomainUpdate (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (617 of 617 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.02%25-green.svg)


@Oksisane Thanks for launching this!


Nếu dịch nghĩa gián tiếp thế này thì sao nhỉ?
---

# Biến

Một biến là một thành phần trong chương trình có thể chứa giá trị và được đinh danh bằng một tên cụ thể. Để khai báo một biến, ta sử dụng từ khóa `var` liền trước tên của biến. Ví dụ:

```js
var example;
```

Với ví dụ trên ta đã **khai báo** được một biến tên là `example`, nhưng nó chưa được **định nghĩa** (tức là nó chưa tham chiếu tới một giá trị nào cả).

Để định nghĩa hay gắn giá trị cho nó, ta có thể làm như sau:

```js
var example = 'Chuỗi bất kì';
```

Như vậy, ta có thể sử dụng từ khóa `var` để **khai báo** một biến, và sử dụng dấu `=` để **định nghĩa** hay nói cách khác là gắn với một giá trị bất kì cho nó.

Giờ nhiệm vụ của bạn là hãy tạo một file `variables.js`.

Bên trong file này, hãy khai báo một biến tên là `example`.

**Giờ hãy gắn biến `example` với giá trị bằng `'some string'`.**

Sau đó, sử dụng lệnh `console.log()` để in biến `example` ra giao diện dòng lệnh (console).

Để xác nhận chương trình bạn chạy đúng hay chưa, hãy chạy lệnh:

`javascripting verify variables.js`
---


Very nice!


As we discussed, we will need to switch this to be more specific as to what kind of streaming properties are needed


@pdaian @bmdahmen
Have some problems with this test:
1. when I move the file to unittest folder, it doest not work, seems because Cache().get_collection_with_address keep return None
2. Not sure how to assert the correct value. Currently use self.assertNotEqual(str(curr_value),prev_value). Using assertNotEqual because collection.hashes.first() keep changing every call time update_hash (collection).
Any idea? Thanks! ^^


True, that's better. As a sidenote I'm not sure about the component layout for clients yet, I'll probably start with a god ClientComponent and split stuff from there over time.


Testing app to see if it was possible to edit file! Confirmed!


done


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.198](http://teamcity.monogame.net/viewLog.html?buildId=6138&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 483, ignored: 6 Build time: 00:14:14


For #9 I would assume?


@pkieltyka Take a look at this issue: https://github.com/zenazn/goji/issues/119 — which talks about web.HandlerFunc going missing.


Actually I think 'has' was correct...


check not null on table


Thanks for the note.


Bạn enable issue nữa hay, nhiều lúc trao đổi tiện hơn.

`Project Setting -> Check on Issue`


please no one-line if statements


GHX_Performance_Enhancements (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1639 of 1639 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


So far "Armor" was just supposed to be a catchier way to write "LocationalDamage". I would extend ArmorComponent in the future in case I add new kinds of *part-of-the-game's-fiction* protection (think of damage types or shields). However, god mode (and friendly fire options) I would expect to be either handled here or, in case I go for the DoDamageModifier solution proposed above, inside the ClientComponent or any more specialzed component that deals with per-client cheats and the like.


sadf


All my TODOs mark lines that would disappear. :stuck_out_tongue:


> Stream will print and yield each element and scalar would just print and return.

Any ideas on the names of the options? By default it can print the whole thing, and if they choose, they can enable the "yield and print" version.

> Maybe have a prefix argument so the user can determine which stage of the pipeline as well

That would be cool, but I can't think of how to do that


Good point, I think that's the way to go (though I prefer the prefix "Apply" instead of "Do" for readability). How safe would this be in case we go for multi-threading some day?


Feel free.


https://github.com/pear/Cache_Lite - 9fa08bd625f86946d41a6e7ff66f6f4ea5c0f0bb


Great use of ternary operator! :smile:


Adding a C extension to compile makes the wheel Windows only, so non-Windows users can't install it off PyPi by accident.


Just a style thing -- make the comment start on the same tab/column as the code that it's talking about.


haha probably the best edition.


While the two are mutually exclusive and could be handled by the same function thus, I see your point. For now I'll keep both together. If we split logic as aggressively like this we could end up with hundreds of components, not sure if that's desirable. :wink:


I deployed version 1.1.2, which should be available in update center in a few hours.

http://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/scoverage/


Found BROKEN by linux-clang.
Here's the log file for step 'testbot update':
```
From github.com:casadi/testbot
 * branch            master     -> FETCH_HEAD
There are no candidates for merging among the refs that you just fetched.
Generally this means that you provided a wildcard refspec which had no
matches on the remote end.

```


When I merge this into the latest master this test fails. I updated the buildwrapper to log the InstantiationException like we do with the post-build action which causes an incompatibility with your branch. See: ffa9aa1

Instead of using assertEquals you can do something like this:
`assertThat("Results don't match", buffer.toString(), CoreMatchers.containsString("..."));`
or this:
`assertTrue("Results don't match", buffer.toString().contains("..."));`


On Mon, Apr 13, 2015 at 3:31 PM, Brian E. Granger
<notifications@github.com> wrote:
>
> Thanks!

Thank You for writing it!
SVAKSHA ॥  http://about.me/svaksha  ॥


のうねんじゃないでしょ
まきようこでしょ


Not a big deal, but I always like to use [strict equality](http://stackoverflow.com/questions/359494/does-it-matter-which-equals-operator-vs-i-use-in-javascript-comparisons) (`===` and `!==`).

For example, `"5"` is a string and shouldn't really equal the number `5`, but if you do `"5" == 5` you'll get back `true`.
However, if you do `"5" === 5` you'll get what you expect, which is `false`.

There are some cases for `==` -- like when you don't want to be strict on user input, but most of the time I use `===` just out of good practice.


```python
def stream_debug(fn):
    prefix = fn.__name__
    @wraps(fn)
    def wrapper(*args, **kwargs):
        for item in fn(*args, **kwargs):
            print('%s: %r' % (prefix, item))
            yield item
    return wrapper
```


Great job!


MarkdownDocs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (617 of 617 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.02%25-green.svg)


I'd rather domain routines just take entities as arguments; otherwise...
* we'll end up with many unrelated methods on entities that expose knowledge/awareness of other entities (we'll be back to fat models).
* where will we place the call to a routine that takes two models (which model gets the method that wraps it?)?

I'm maybe ok with entities that do some simple metadata aggregation across subsystems, but with more complex logic handled by direct calls to routines.

Also is a discussion about entities only part of the solution?  Can we still have wrapper models exposed by each SS?  (e.g. `Content::Exercise`, `Content::Page`, `Tasks::Task` etc)?


Thanks for all the feedback!

On Mon, Apr 13, 2015 at 7:33 PM, Parker Lusk <notifications@github.com>
wrote:

> Great job!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ervinkleitz/mean-homework/commit/906774b1f2db59ff6b3a3aaef7af2cc4e704ba5a#commitcomment-10704922>
> .
>

--
Regards,
Ervin


rax retry tests


Weren't we going back to:

```python
def basket_parent_and_lengths(node):
    """
    Given an *etree*, returns an iterable of parent node
    to child nodes text length pairs.
    """
    return node.getparent(), text_length(node)
```

We want to encourage users to create custom hooks, without having to create a decorator themselves


This sounds reasonable.


The commits here have been reverted. Indeed, we first need to have a correct test before thinking about tracking down the allocations in this file


original


What is the fix here?


key_file 这个用 $HOME/.ssh/id_rsa


I am afraid there are many dependencies on this constant - so can we change it back please?
https://github.com/FactomProject/btcd/blob/c56980c0ec83814c0e3f2829a0ea818f2ed79838/wire/message.go#L17
https://github.com/FactomProject/btcd/blob/c56980c0ec83814c0e3f2829a0ea818f2ed79838/wire/message.go#L198
Let's instead shorten the text strings to be within 12 bytes.


paramiko 写道 require文件里？


A webpage that displays multiple video streams game related and videos from "friends"


Thanks for catching this!


Looks beautiful :) We should start considering whether or not we should move these decorators into another module. ``filters.py``, ``pipes.py``, ``cherrypickers.py`` are some that come into mind ;P


I am more in favor of something on the order of what you mentioned above, one entity per controller (one entity per outside access point).  So for the `Tasks` SS, there'd be two entities (for now).


Collisions among entities


On hold


ok


You don't need this method. Currency model should only store uuid and rates, that's all.

CurrencyWorker will pull data from queue and create Currency record. If everything goes well then it should publish back acknowledgement message to ack_worker.


Good use of math shortcuts (i.e., `/=`, `+=`, etc)


Just a style thing, but JavaScript users prefer single quotes (') over double quotes (") for strings!


Just for future reference, please merge migrations into one. The less files you have the more readable it is.


If access policies are made to be role-oriented, they could live in subsystems.  E.g. the `TaskAccessPolicy` could be in the `Tasks` subsystem if the arguments to `action_allowed?` were `(action, requesting_role, task)`, since the `Tasks` subsystem can check against `Tasking`s which are just joins between roles and `Task`s.


没有关系。非常感谢参于。
github 越用越熟的，非常好用。

文字润色的工作，我们最后一起来做。


I think the goal should be for all domain routines to work only with entities and subsystem wrapper classes.


Iterables.getOnlyElement(node.getSources()).accept(this, preferred) => planChild?


ohh bhoo


D'oh, I mixed up "parsing the version of the tool in the release manifest" with "parsing .meteor/release".  I'll fix.


Sounds good.


The title of this commit should read, "box route (profile page)"


呵呵


IMHO leave in formatters as they are formatting utilities.


I thought you said that it's less readable?


This logic should be placed in worker private method.

Look at condition returns, it is inconsistent. Once it returns false, otherwise currency record.


I don't think you need to require it.


only include the FilterNode if the resulting predicate is not equal to TRUE


I've reviewed up to this commit so far.


As well as this. All of these classes should be loaded with Rails env.


CurrencyWorker


Main issue: I tried moving the particle remove in draw_cell() to update() but setting the particle null does nothing in update despite it actually being set null. Game.class ln 27


For retries, please implement this module in app and use it in config sneakers.rb

https://github.com/jondot/sneakers/blob/master/lib/sneakers/handlers/maxretry.rb


Yeah, you're right on moving them there. Will do make changes.

Also, what do you think about having a``prototypes.py`` module where we can throw some of the crazy stuff :P


Missing license


I would still intersect node.getPredicate() with node.getCurrentConstraint().orElse(BooleanLiteral.TRUE_LITERAL) here since that could potentially capture more predicates than reported by node.getPredicate().


This C# code seems just a brand new project without any logic supporting the satellizer? I'm confused. How does it work with satellizer?? I don't see any logic to generate a token


spy ? What does it do ?


mispelling


username至少让用户填写，root为默认值，port也默认为22,让用户填写，后续为了安全可能关闭22端口


Thanks! Done in https://github.com/lencioni/dotfiles/commit/0f116e8d52dac61cf241fe8945c44d53acc9722f


See 0b803b1


You don't self here :)


ok got it, in fact, this whole thing (+ `bad_client = False` before) :

+                  bad_client = True
+                finally:
+                    if bad_client:
+                        if c not in self.bad_clients:
+                            self.bad_clients.append(c)
+                        for idx, val in enumerate(self.clients):
+                            if val == c:
+                                del self.clients[idx]
+                                break
```
can be replaced by / is equivalent to :
```
        if c in self.clients:
             self.clients.remove(c)
             self.bad_clients.append(c)
```
because if c, is then it's in clients and vice-versa.. so if it's not yet in bad_clients then, and only then, you need to add it.. and by then it's obvious that it was part of clients ;)


This method seems to be too long. Can you split it ?


Derek is correct. This code was causing issues as it would set an empty `JAVA_HOME` in each of the *-env.sh files, causing Hadoop to fail to startup. This code shouldn't be needed, at all. The processes should have `JAVA_HOME` set as Derek mentioned.

I could have sworn that the link to the JIRA was in CONTRIBUTING.md, but apparently I was mistaken. It's linked from the Supermarket page on Chef, though.


This is super interesting! Unfortunately, this is actually a bug :smile:.

You are trying to use mathematical notation in your programming -- unfortunately, the only language I know that supports this is Python. In JavaScript, in order to get `0 < x < 5` you have to do `0 < x && x < 5`. Otherwise, you get a tricky bug because of the way that JavaScript interprets `false` and falsey values. (this also gets back to the comment about strict equality `===` I made above)

Try playing with this in your Chrome console:
```
var x = .4;
`0 < x // you should get 'true'
```

Okay, now for a little bit of theory:
So, back in the C programming ages, there was no such things as Boolean values (true or false). Instead, people would just use integers to flag values as true or false. So, it became a standard that `0` means `false` and anything else means `true`. To validate this, try running `false == 0` and `false == 1`. Likewise, run `true == 0` and `true == 1`. (notice that we aren't using strict equality here, because we want JavaScript to interpret this loosely, without comparing types. Strict equality would clearly always return back `false` for the above cases because a Boolean is obviously not a number)

So, let `computerChoice = .4` what's happening in this line of code is:
```
0 < computerChoice // this returns 'true' because 0.4 is greater than 0. true is the same as '1' so, a '1' is used for the next part
(1) < 0.33 // returns false, because 0.33 is not greater than 1. Notice how I replaced (0 < computerChoice with 1, because that's what 0 < computerChoice is evaluated to become)
```

This was a little wordy, but hopefully it makes sense!


Where is the logic to support JWT???


Looks great overall! Consider putting these two homeworks in a 'week01' folder so it's organized as the weeks go on.


removed null checks and immutable copies?


We are talking about this change right?

This...
```python
def children_pairs_of(selector):
    @prunes(selector)
    def func(node):
        return node, count_children(node)
    return func
```

is less readable than this:

```python
@prunes(NODES_WITH_CHILDREN)
def basket_node_and_counter(node):
    return node, count_children(node)
```


Unecessary comma :)


might want to checkArgument that column != null so that we know that we are missing an assignment


LGTM.


需要设置一个timeout参数，比如10秒什么的，不然tools卡死了怎么办


@cyberb Is syncloud-resize-sd.service added twice by mistake?


Закончил перевод


Just a style thing, but JS users prefer single quotes (') over double quotes (") for strings :smile:


Nice use of regex!


Not a big deal, but I always like to use [strict equality](http://stackoverflow.com/questions/359494/does-it-matter-which-equals-operator-vs-i-use-in-javascript-comparisons) (`===` and `!==`).

For example, `"5"` is a string and shouldn't really equal the number `5`, but if you do `"5" == 5` you'll get back `true`.
However, if you do `"5" === 5` you'll get what you expect, which is `false`.

There are some cases for `==` -- like when you don't want to be strict on user input, but most of the time I use `===` just out of good practice.


This reference is talking about the generic type parameter `TKey` of a different type, as opposed to a `TKey` type parameter of the current type (in fact, there is no `TKey` at all in this scope).


But in all seriousness – we're working on a deadline here, and Michele is much faster at getting these things done than I am, so I was hoping he would lead on them.


Maybe add some more comments, just to help future Jerry remember what current Jerry was trying to do :smile: (although, this example is pretty self-explanatory -- good job with meaningful variable names!)


este es el primer commit


Ah, I see, thanks.  I should have read more closely, especially since I think I wrote that comment in the first place ;)


Thank you for your help! I have merged your commit into master branch now.


Fair enough :)

On Mon, Apr 13, 2015, 10:58 PM Andrew Embler <notifications@github.com>
wrote:

> But in all seriousness - we're working on a deadline here, and Michele is
> much faster at getting these things done than I am, so I was hoping he
> would lead on them.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/concrete5/concrete5-5.7.0/commit/97fa71b1a4c3841cf852ca6bd9f1cbbb67ef2670#commitcomment-10705193>
> .
>


yeah here that would be :
```
else:
    if c in self.bad_clients:
        self.bad_clients.remove(c)
        self.clients.append(c)
```


It does. Also, you are not the first to ask this (see DotNetAnalyzers/StyleCopAnalyzers#361). :smile:


имеет смысл заменить на стандартные идейские иконки
AllIcons.Actions.Forward


I forgot to write this in the commit, but this revision also removed all blueprint files.


Without the schema changes (which don't appear to really be relevant changes), seems like this would be something that could be merged upstream...


Nice fix!


@hodeyp Can you confirm that this is still an issue?  I believe my later commit resolved this issue, and I am not able to recreate this in Safari.


.... so I know its been 5 years (woah) and everything, but do you have any idea what the intent of this was? It seems to be causing some long-standing performance issues (#219, #279). I can't imagine why you'd have to clone a reference to the **same** model. :/


~ so fancy ~


This is weird.


Надо добавить файлу plugin.xml разумную начинку.


@kurtmckee Thanks. mmh, as I read the patch does not remove mstyle. The "other" attribute is obsolete in MathML 3 and can be ignored. "encoding" is from the semantics and is important, so yes it should be kept (I think I took the list from https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute where it is not list, although it is in https://developer.mozilla.org/en-US/docs/Web/MathML/Element/semantics#Attributes). Note: if you really want to be exhaustive, you can take a look at http://www.w3.org/Math/RelaxNG/


Looks pretty good, just a comment on excess code:

Lines like  @TargetApi(Build.VERSION_CODES.HONEYCOMB) are basically useless code because of the lack of Honeycomb devices out there. While it's not going to break anything it's just extra stuff to sift through.
https://developer.android.com/about/dashboards/index.html?utm_source=suzunone


Not really.


```
Failed asserting that '<meta property="og:locale" content="nl_NL" />
<meta property="og:locale" content="nl_NL" />
<meta property="og:locale" content="nl_NL" />
<meta property="og:locale" content="nl_NL" />
<meta property="og:locale" content="nl_NL" />
<meta property="og:type" content="article" />
<meta property="og:type" content="article" />
<meta property="og:type" content="article" />
<meta property="og:type" content="article" />
<meta property="og:type" content="article" />
<meta property="og:title" content="Post title 1 - Test Blog" />
<meta property="og:title" content="Post title 1 - Test Blog" />
<meta property="og:title" content="Post title 1 - Test Blog" />
<meta property="og:title" content="Post title 1 - Test Blog" />
<meta property="og:title" content="Post title 1 - Test Blog" />
<meta property="og:description" content="Post excerpt 1" />
<meta property="og:description" content="Post excerpt 1" />
<meta property="og:description" content="Post excerpt 1" />
<meta property="og:description" content="Post excerpt 1" />
<meta property="og:description" content="Post excerpt 1" />
<meta property="og:url" content="http://example.org/?p=13" />
<meta property="og:url" content="http://example.org/?p=13" />
<meta property="og:url" content="http://example.org/?p=13" />
<meta property="og:url" content="http://example.org/?p=13" />
<meta property="og:url" content="http://example.org/?p=13" />
<meta property="og:site_name" content="Test Blog" />
<meta property="og:site_name" content="Test Blog" />
<meta property="og:site_name" content="Test Blog" />
<meta property="og:site_name" content="Test Blog" />
<meta property="og:site_name" content="Test Blog" />
<meta property="article:publisher" content="http://facebook.com/mysite/" />
<meta property="article:section" content="Uncategorized" />
<meta property="article:section" content="Uncategorized" />
<meta property="article:section" content="Uncategorized" />
<meta property="article:section" content="Uncategorized" />
<meta property="article:published_time" content="2015-04-14T19:55:03+00:00" />
<meta property="article:published_time" content="2015-04-14T19:55:03+00:00" />
<meta property="article:published_time" content="2015-04-14T19:55:03+00:00" />
<meta property="article:published_time" content="2015-04-14T19:55:03+00:00" />
<meta property="og:image" content="http://example.org/wp-content/uploads/C:serverwwwdevwp-contentpluginswordpress-seotests/assets/yoast.png" />
<meta property="og:image" content="http://example.org/wp-content/uploads/C:serverwwwdevwp-contentpluginswordpress-seotests/assets/yoast.png" />
<meta property="og:image" content="http://example.org/wp-content/uploads/C:serverwwwdevwp-contentpluginswordpress-seotests/assets/yoast.png" />
<meta property="og:image" content="http://example.org/wp-content/uploads/C:serverwwwdevwp-contentpluginswordpress-seotests/assets/yoast.png" />
<meta property="og:image" content="http://example.org/wp-content/uploads/C:serverwwwdevwp-contentpluginswordpress-seotests/assets/yoast.png" />
' contains "<meta property="og:image" content="http://example.org/wp-content/plugins/wordpress-seo/tests/assets/yoast.png" />".
 C:\server\www\dev\wp-content\plugins\wordpress-seo\tests\test-class-opengraph.php:368
```

On my radar, I'll look properly into in tomorrow. :)


@lucaswerkmeister one issue is that gaps would make other `Enumerable` operations O(n).

Not sure if this makes any sense (at all :)), but would it be possible to allow these Characters, but just treat them as unassigned? This might also help if there is variation in `java.lang.Character.isDefined` for various JVM releases.

I had a problem with `#37F` from the [xml spec](http://www.w3.org/TR/REC-xml/#NT-NameChar), and wound up just using Integers.


actually, I have concerns that this method can be called twice with different parents and thus inherit two different sets of tags. Should the method be private so that the only way of adding a parent is using Builder.childBuilder?


channels should be channel


Great work! :D Does the program check that what the user is uploading is a valid and accepted file type? Some people could upload malware, which is a problem. :/ Virustotal.com has an API that we could use somehow to scan uploads. https://www.virustotal.com/en/documentation/public-api/


if it is not implemented, is their any example for how to generate JWT with c#?


So after much discussion with @mcdonc, we're leaning towards something that doesn't even try to magically inject itself into server sub-processes in any way, because that appears to be fraught with perils if we're trying to be server agnostic - servers do so many different things (e.g. gunicorn fires up its own individual worker processes, so if we interrogate `sys.modules` in the gunicorn master process it might not even give us useful results). Instead we'd define a "protocol" (probably just a file with a list of paths in it?), and our watcher will just watch whatever's in that file (as well as watching that file itself for changes!). Then we can also provide a lib people can import in their server process if they want to really easily fire up a thread that monitors `sys.modules` and writes to the watcher file-list. So we get more explicit behavior and a clearer separation of responsibilities between the monitor and the monitored process, at the expense of requiring a bit more cooperation from the monitored process if it wants magical "monitor everything in sys.modules" behavior.

@davisagli interested in your thoughts on that!


We need to keep this `strfree()` or we'll introduce a leak.


This method needs not be overriden at all. It is a copy of the super method. Unless we are concerned that the super implementation will change in the future. Similar for dec() and ContextAwareMeter.mark().


should this call super()?


@fred-wang You're right re: ``mstyle``, my bad. Though ``other`` is obsolete should it be left in for compatibility? I'm delegating the decision to you. =)


OK


If we add the `tsd_set(key, NULL)` behaviour I've suggested in the spl counterpart we can keep this line and get exactly the effect we need.


Yes but why this commit if it's not completed?


I don't think we want to leave printlns in place


yes use this
http://elvis.rowan.edu/mirrors/portablepython/v2.7/PortablePython_2.7.6.1.exe
it will mak a folder that you can use
are you pianoman?
nick
Not sent from my iPhone because I don't have one

On 4/14/2015 12:08 PM, ploquel wrote:
>
> Do you guys know a link where I can download python to run this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PieCrafter314/python-browser-bar/commit/205dba1a7a3e7e8d2a89ce40a028690a68e0cadd#commitcomment-10718935>.
>


Everything just falls out right here as well and we don't need to add any special case code.  So this patch should just turn in to a one line change which removes `tsd_exit` from the ZFS_EXIT macro.


Does it check the mime type or just the extension? If not, some clever hackers can sneak PHP in image files as long as they have something like a PNG header.


Yup, I caught that error.


It's generally a good idea to stay away from `==` in JS. This stackoverflow question goes into much more detail http://stackoverflow.com/questions/359494/does-it-matter-which-equals-operator-vs-i-use-in-javascript-comparisons, but to make a long story short:

`==` will type convert your two operators, `===` will not. Therefore, `3 == '3'` is true but `3 === '3'` is false.


Also, are we allowing .sprite2 files?


This should be a list data type

domains = ['teramixer.com']


vayne should be like this
else if (Player.BaseSkinName == "Vayne") abilitySequence = new int[] { 1, 3, 2, 1, 1, 4, 1, 2, 1, 2, 4, 2, 2, 3, 3, 4, 3, 3 };


ttttt


Proof this works without need of FTP: http://dev.opensprites.gwiddle.co.uk/uploads/uploaded/1-1.png
We will allow .sprite2 of course @andrewjcole.

Well done you guys, this is quite a big milestone.


hhh


The photoCursor is not getting closed; this block should be in a try/finally with the photoCursor.close() in the finally block.  This is causing a crash in our app for some users


Makes sense.


rax retry tests


{
      key: 'poop',
      quote: '"I think they're selling poop though" - Maro-Kun 2015',
}


What is this all working towards?


LOL - what is this line ?


Yes, i'm pianoman. Long story short: I had to pick another name because GitHub thought i was a robot any time my name was pianoman373. But thanks for the Python link!. Hopefully i'll start learning python too.


Ejemplo de Comentario


:o:


wait one min and i will send you a PDF soon
nick Not sent from my iPhone because I don't have one

On 4/14/2015 3:16 PM, ploquel wrote:
>
> Yes, i'm pianoman. Long story short: I had to pick another name
> because GitHub thought i was a robot any time my name was pianoman373.
> But thanks for the Python link!. Hopefully i'll start learning python too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PieCrafter314/python-browser-bar/commit/205dba1a7a3e7e8d2a89ce40a028690a68e0cadd#commitcomment-10723294>.
>


About to take off so can't analyze in detail but +1 on this approach. I was also wondering about servers that use process pools.

David Glick
(mobile)

> On Apr 14, 2015, at 4:08 PM, Carl Meyer <notifications@github.com> wrote:
>
> So after much discussion with @mcdonc, we're leaning towards something that doesn't even try to magically inject itself into server sub-processes in any way, because that appears to be fraught with perils if we're trying to be server agnostic - servers do so many different things (e.g. gunicorn fires up its own individual worker processes, so if we interrogate sys.modules in the gunicorn master process it might not even give us useful results). Instead we'd define a "protocol" (probably just a file with a list of paths in it?), and our watcher will just watch whatever's in that file (as well as watching that file itself for changes!). Then we can also provide a lib people can import in their server process if they want to really easily fire up a thread that monitors sys.modules and writes to the watcher file-list. So we get more explicit behavior and a clearer separation of responsibilit ies betw een the monitor and the monitored process, at the expense of requiring a bit more cooperation from the monitored process if it wants magical "monitor everything in sys.modules" behavior.
>
> @davisagli interested in your thoughts on that!
>
> —
> Reply to this email directly or view it on GitHub.
>


I expect a working prototype by the time I land in 6.5 hours ;-)

David Glick
(mobile)

> On Apr 14, 2015, at 4:08 PM, Carl Meyer <notifications@github.com> wrote:
>
> So after much discussion with @mcdonc, we're leaning towards something that doesn't even try to magically inject itself into server sub-processes in any way, because that appears to be fraught with perils if we're trying to be server agnostic - servers do so many different things (e.g. gunicorn fires up its own individual worker processes, so if we interrogate sys.modules in the gunicorn master process it might not even give us useful results). Instead we'd define a "protocol" (probably just a file with a list of paths in it?), and our watcher will just watch whatever's in that file (as well as watching that file itself for changes!). Then we can also provide a lib people can import in their server process if they want to really easily fire up a thread that monitors sys.modules and writes to the watcher file-list. So we get more explicit behavior and a clearer separation of responsibilit ies betw een the monitor and the monitored process, at the expense of requiring a bit more cooperation from the monitored process if it wants magical "monitor everything in sys.modules" behavior.
>
> @davisagli interested in your thoughts on that!
>
> —
> Reply to this email directly or view it on GitHub.
>


Yes, you are right.


We can use this http://blog.vogella.com/2010/10/25/android-windowsoftinputmode/ to allow text input on Android, but for me this is a wishlist feature...


LGTM


No, AFAIK "other" was an old attribute from the 1999 MathML spec that was only here to let authors define non-standard features: http://www.w3.org/1999/07/REC-MathML-19990707/chapter7.html#sec7.2.3 So no need to keep it :-)


timeslice.totalDuration handles precisionSeconds as parameter (https://github.com/dime-timetracker/dime-frontend/blob/58ff9eecbc71d2e850de4e6058e151663cb6e214/public/js/core/model/Timeslice.js#L16)


This was for #5131


The `other` attribute was/is used in the `maction` element. The MathML3 Rec replaces it with [a custom attribute in a new namespace](http://www.w3.org/TR/MathML3/chapter3.html#presm.enliven).

I would suggest keeping the `other` attribute for backwards compatibility; the new recommendation is not going to work well with any sort of whitelist sanitizer.


:+1: <3


committed


is it worth briefly documenting what each check does?


Perhaps this (and also `test/functional/job/tty-test.c`) should live in `test/fixtures/.


No. You should just override the method to customise it.


Thanks!


@abhidixit you should squash this commit


:exclamation:


i used this you can use the other python with it to
https://drive.google.com/file/d/0ByyTUrVVYOSEVWVuczA0dkJsTjA/view?usp=sharing
nick
Not sent from my iPhone because I don't have one


We should use magazine groups for this; maybe even for vanilla magzines


Excellent... Yes, full materials support in freecad will be there soon.


Hah the copy-pasta monster strikes again! ... thanks!


In keeping with the style of the project, please make the commit message:

"BUG: Rule XXX failed silently."

The condition on line 85 (now 87) could never be true,
so this rule either passed or failed silently."

where XXX is the rule.


That should be enough, but clearly not. Have you tried setting up a
standard error file to see if anything shows up there? Another idea would
be to temporarily put in the full path to rcontrib to see what that does.
On Apr 14, 2015 12:37 PM, "Craig Casey" <notifications@github.com> wrote:

> @jasondegraw It is in the same place that oconv is in on my c drive. This
> should find it the same way right?
>
> Thanks,
> Craig Casey
>
> Ph.D. Candidate
> Architectural Engineering
> The Pennsylvania State University
>
> IES 2015 Annual Conference Steering Committee Chair
>
> On Tue, Apr 14, 2015 at 2:14 PM, Jason DeGraw <notifications@github.com>
> wrote:
>
> > That sounds like it isn't finding the program. You sure it is in the
> path?
> > On Apr 14, 2015 12:05 PM, "Craig Casey" <notifications@github.com>
> wrote:
> >
> > > @jasondegraw <https://github.com/jasondegraw> There seems to be an
> error
> > > here when running rcontrib. The error is "The system cannot find the
> path
> > > specified". Any ideas why this would occur from the STADICprocess side?
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/Architectural-Lighting-Simulation/STADIC/commit/16ba5e06d15eacc8c4bf19abba459f6a1e1cf49e#commitcomment-10720047
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Architectural-Lighting-Simulation/STADIC/commit/16ba5e06d15eacc8c4bf19abba459f6a1e1cf49e#commitcomment-10720212
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Architectural-Lighting-Simulation/STADIC/commit/16ba5e06d15eacc8c4bf19abba459f6a1e1cf49e#commitcomment-10720683>
> .
>


@abhidixit missing Signed-off-by tag for the commit. Also, I don't see why we need to have different request ids for S3 and Swift, should just use the swift one for both. Also, instead of calculating the request id here like this, should do it on initialization, and put it on the req_state structure.


Shouldn't this be one function? Like `setPalette(string pal, Uint8 def, Element *elem)`?
I can refactor this if you want.


This looks like an unpaired close tag.


The only real difference is the small class ExpandableQueryIncludeExtension having the method Include.
(And .vs for ignore VS2015 stuff.)


@stackus - sorry that i'm late to the party here, but curious what you meant by this comment?

Sensu won't have visibility into project and staff ids, so I wasn't sure how to populate those attributes from this endpoint.

Are you just suggesting that I avoid putting those attributes into `params` or something larger?


Wow awesome, Thanks!


Login system first version


This should be broken up into multiple checks. Failing health indicates which health check failed and the message from `Result.unhealthy(...)`. Comments could be added, but the error message should be clear.

Usually health checks are for things that can go in/out of being healthy, like a connection to something external. If this is a sanity check for configuration, the service should fail to startup on bad configuration.


content close tag is indented too far.


Should probably give a common "namespace" prefix to the defines to prevent clashes. E.g QUANTRACKER_SWDIO_DEBUG etc.  Will try to document that!


This change causes the build on Win7 64 bit to fail with the following error (even after a sucessfull cabal update):
```
Preprocessing executable 'pandoc' for pandoc-1.14...
Linking dist\build\pandoc\pandoc.exe ...
D:\Develop\git\pandoc\dist\build/libHSpandoc-1.14.a(MIME.o):fake:(.text+0x12761): undefined reference to `texmathzm0zi8zi0zi2_TextziTeXMathziReadersziMathMLziEntityMap_zdsfromList_info'
D:\Develop\git\pandoc\dist\build/libHSpandoc-1.14.a(MIME.o):fake:(.text+0x128c1): undefined reference to `texmathzm0zi8zi0zi2_TextziTeXMathziReadersziMathMLziEntityMap_zdsfromList_info'
c:/program files/haskell platform/2014.2.0.0/mingw/bin/../lib/gcc/x86_64-w64-mingw32/4.6.3/../../../../x86_64-w64-mingw32/bin/ld.exe: D:\Develop\git\pandoc\dist\build/libHSpandoc-1.14.a(MIME.o): bad reloc address 0x0 in section `.data'
c:/program files/haskell platform/2014.2.0.0/mingw/bin/../lib/gcc/x86_64-w64-mingw32/4.6.3/../../../../x86_64-w64-mingw32/bin/ld.exe: final link failed: Invalid operation
collect2: ld returned 1 exit status
Failed to install pandoc-1.14
cabal: Error: some packages failed to install:
pandoc-1.14 failed during the building phase. The exception was:
ExitFailure 1
```


No, unless there is no default constructor in the super class.


Nice.


Even more returns between elements would be great for making this array more readable.


lets change this to a div tag instead


Add description :)


#define BASE 1000000000
#define BASE_DIGITS 9


Cool :)


automatically :-)  two L's


@calebthompson or @masonforest - just curious, what was the motivation for changing this from `permit` to `slice`?

Isn't this a check to verify that `params` only contains approved attributes?


I have lost first place in alphabetical order!

![Vader no](http://www.nooooooooooooooo.com/vader.jpg)


Thanks for added this.


Please provide some instructions on how / where to download this bost_1_xx_y from.


This change has Parul's code changes including optimizations.


It'd be more idiomatic to use a Gemfile and call `bundle`, and the `lint` rule will be slightly simpler since you'd avoid the path fiddling.


huh... i hadn't even thought of that.


Stub out tests since they don't even matter here.


MarkdownDocs (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1633 of 1633 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@ronie Header label seems to be broken (again). No dialog title with Confluence and latest Kodi master (@April 11).  Any ideas?


We want to keep the merge command, right?


Avoid putting them into params. You'll be able to refactor this method and the other params methods if you're not altering params on a per case basis.


Awesome :)


Unless I'm mistaken, you aren't really testing highlight attributes, so you can skip all this.

Just remove the `{1: }` from the test `expect()`s and I believe the attribute validator will be skipped. @bfredl


I don't think that's expected behavior, because, as you point out in the help for the option, --attributes default value is supposed to be `name`. I think `--attr` is good.


You have tested with datastream with many whitespaces at the end?


I wonder what you think about a utility (called `phyber`, perhaps) that exposes Bio::Phylo's functionality on the command line with sensible subcommands, e.g. `phyber convert` for file format conversions and mappings, `phyber simulate` for various tree, data and other simulations, `phyber transform` for data transformations, e.g. rarify, bootstrap, jackknife, branch length and tree transformations, `phyber stats` for various tree topology and alignment statistics, and so on. I think releasing that in a convenient form (Docker, wrapped inside .app?) would be pretty useful.


Totally legit


From a best practices perspective, what's wrong with modifying the `param` var?


oops!


`:html_safe` will still allow for “unsafe” injection of content e.g. `<script>` tags.

To make sure the HTML content is not malicious it will have to be passed through a sanitizer. See the [rich text conversion](https://github.com/ndlib/sipity/blob/master/app/conversions/sipity/conversions/convert_to_rich_text.rb#L32) which uses the [sanitize gem](https://rubygems.org/gems/sanitize). The sanitized HTML will still need to be flagged as `:html_safe` in order to be rendered on the page.


The behavior of `--attributes name multiplex` seems fine, I like it a lot.


Care to help me out on that? I'm really not well at home with Ruby so I'm trying to make do. It does look horrible.


To have a test version for the translators.


Can I do it? Or you want refactor it?


Thanks!


package com.javarush.test.level19.lesson05.task01;


Hrm, I assumed the demo loaded `index.js`, but it actually relies on the prebuilt `index.json` which is a compilation of everything in `index.js`.

So there are additional steps:

1. `npm run build`
2. Upload the new `index.json`


I can’t find the beginning of this thread but I think I get the question.

Ideally, I would like the user to remain on the confirm page.  I don’t think the user would intentionally hit tab to go back to the beginning of the fields.  Maybe they would, but it’s far more likely that they did this by mistake and then would be annoyed at having to go through the fields again.

If they wanted to go to a previous question without using the mouse, they could use shift-tab.

It seems fine that hitting tab on the confirm page would cycle through the elements on that page.

Just my opinion.

Thanks,
Dave

From: djazayeri@gmail.com [mailto:djazayeri@gmail.com] On Behalf Of Darius Jazayeri
Sent: Tuesday, April 14, 2015 3:16 PM
To: openmrs/openmrs-module-uicommons; David DeSimone
Subject: Re: [openmrs-module-uicommons] Returning to the first field after reaching the end of tab order - (9761879)

I disagree with both of you. :-)

I would expect that the confirmation screen to behave like a modal popup, and pressing tab multiple times cycles through only the elements on this screen.

But I'm open to other perspectives, and I don't think this should delay our release.

@Dave, quick BA question for you: On the confirmation screen of the Register Patient app (and other question-per-screen apps), what would you expect to happen if the user presses tab many times?

-Darius

On Tue, Apr 14, 2015 at 2:57 PM, dkayiwa <notifications@github.com<mailto:notifications@github.com>> wrote:

Yes. Though @wluyima<https://github.com/wluyima> seems to suggest otherwise. :)

—
Reply to this email directly or view it on GitHub<https://github.com/openmrs/openmrs-module-uicommons/commit/97618792e7adc5a90ef1a3471e403c451148d1fe#commitcomment-10721115>.


Fix hostname?


Isn't this essentially a duplicate of static function GetAll($templateid){


Oh I see. Okay.


@weinerschnitzel I'm somewhat conflicted on what should be done. This "fix" is really just a workaround for audio plugins that have issues with these games. Although, it kind of doesn't make sense to save the value of the status register, when certain other information is not saved into the save state (afaik).

It affects games like Turok, MusyX games, Tony Hawk (i hear), etc.

As to why it's an option, it's because there may be potential side effects.

>Did this problem exist in pre-2.0 versions of PJ64? 1.4/1.6 set AI_STATUS_REG to 0

That probably explains why this problem didn't seem to exist in 1.6.


you goof


@ostera it feels like we're getting a strange mixture between Ruby and other tools like Make. Since we're tending towards Ruby anyway, do you think a Rakefile is a better solution? What I've got not works perfectly and it'd be sad to throw it away, but we've got the future to consider.


> The current version of the script filters out some private methods for example that I only want to test through the pulbic interfaces.

Mutant has the same logic for killing mutations. Private methods are supposed to be covered via public methods.

> It would be great if mutant could do something with these.

I think mutant could just run the current selector, and report all the subjects that do not have tests explicitly. I'm thinking about mutant modes. One would be `kill` (the default and current behavior). Another would be `discover` that will just print the subjects expressions on CLI will select, and one could be `missing-tests` that does what we discuss here.

> The main issue I have is that some methods, because they don't have tests explicitly for them, match a ridiculous amount of test cases.

This will be fixed via tracing, if I ever have the OSS time to finish it.

> and it makes mutant's output useless (just pages and pages of test case descriptions scrolling by really fast).

I need an HTML report module to fix that. I have some private code I need to OSS some day. Time issue again.


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


The params hash represents the request. Various middleware will use the data within it. Getting into the habit of modifying it can lead to unexpected errors.


@robertmesserle - I'm afraid it is still an issue. All works beautifully on Chrome but safari is actually looking worse than before.

I have recorded an example using the material web site on the latest build (v0.8.3 - SHA 375d4fc)

https://drive.google.com/file/d/0B-OD4l6gS9OGRmUtSU1qMEh4YzA/view?usp=sharing


clicking the yelp button takes input of the address bar and sends it to searchYelp() function which is described in application.js. This function sends a post request to welcome#search with the search term which is stored in params[:term]. Fails in the search action render line with "uninitialized constant WelcomeController::Yelp". However, I do pre-initialize the Yelp client in yelp.rb under config>initializers. ROR doesn't like something I'm doing here.


comment


eh, go ahead, i'm sure it'll end up the same either way. i was gonna remove all the palette entries from interfaces.rul due to default values, and include default TFTDMode values as well. (both of which could then be overridden by defining a color)


@nicolas-grekas Small curiosity: why 5.5**.9** ? What is the significance of **.9** ? Why not 5.5.1 or 5.5.7 or 5.5.12 ?


i'm probably missing the point but why not? i try to get gpu mining working with eth.


Is it correct to set `tc_current_error_count` to 1, or should it be incremented instead? I haven't looked into it.


I added the documentation on top and added the pytest.fail call. BUT, with the current models setup the test will fail early because some of the models don't have a class named MODELNAME_model.


https://docs.python.org/2/reference/datamodel.html#object.__add__

Notice, the docs specify theese methods should **return** `NotImplemented` not raise an exception. It's an error to do otherwise.


Isn't this going to implicitly call `c.toString()`?  I think you need to explicitly call `c.name()`


this seems like it's taking the extracting constants to an extreme.  I wouldn't bother with this, but maybe others would disagree with me.


GetAll returns a multidimensional array, which I saw no value in, but if
you were using it I didn't want to create a problem in your code.  I needed
a simple array of all slots being returned.

On Tue, Apr 14, 2015 at 4:42 PM, Wilbur Longwisch <notifications@github.com>
wrote:

> Isn't this essentially a duplicate of static function GetAll($templateid){
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/samilliken/openDCIM/commit/43fbae5b3815638bb522a89a185db7d23274f1a6#commitcomment-10723744>
> .
>


yeah, broken by https://github.com/xbmc/xbmc/pull/6807

i'll fix it in a minute


You can reduce 8-26 to like 5 lines. If you start with the array of filepaths, you can then just set up a forEach on that array that pushes a new Kitty obj to kittyArray for each path in filepath array.

var filepaths = [path1, path2, pathN]
filepaths.forEach(function(path) {
  kittyArray.push(new Kitty(path, color);
}


It is now sucka's!


Sim, esse cenario foi movido nas correções


cometing 2123


@tolot47 can you try `cabal clean` and then reinstall?


Restarted rails server and it seems to accept my client initialization offering. Need to fix yelp api key.


Так получилось, что там 2 проекта внутри одного. Один - питоновский, другой - джава, поэтому и не top-level.


Might be clearer to just

```
return "Possible values: { TRUE, FALSE }"
```


you can actually combine the final string join into the `collect`

```
.collect(Collectors.joining(delimiter, prefix, suffix)
```


mkmm


Oups! yeah you are very right.


@RobinOlofsson: Hahaha xD


@marcysutton - oops this change broke the build! There is an e2e test that was finding this element by `linkText` but since this is now a button it couldn't find it. We need to change the test to use `buttonText` instead.

You can see that this fails when running `grunt test`, which you should definitely do before merging a commit into master ;-)


We'll want to copy the reference snapshot_old_sha storage and extraction, and test by going to 1.56, then going to 1.57.


You're right. If we're going the Bundle way, a Rakefile would be a bit more appropriate, but then we have a bunch more dependencies than before.

It'd be easy enough to switch to a Gemfile/Bundle if we see we need more gems down the way. Right now this is more than appropriate. I guess I just got a bit scared at the lint command path fiddling haha, maybe just doing `find pages -exec ./.gem/bin/mdl {}` would make it a bit more clear?

Also remember to add `--no-rdoc --no-ri` as flags to the `gem install` command so it doesn't download the docs for the gem.


Since I bothered already, does it need to be reversed?


canola


Wow, I am sure under right circumstances this algorithm could pass as military grade encryption. And I continue to be amazed by its simplicity and effectiveness. There are a few issues with your implementation though. Assume a user enters '104' in line 17, 'h' in line 22 and 'h' again in line 32. There are (at least three) problems with that. Please find and fix them for the good of all mankind. Also imagine the nightmare you would have maintaining the code in case English alphabet suddenly were to gain another letter in front of 'A' (and the ASA would update ASCII to compensate for that).


unnecessary join, can be combined into the Collector


move callbacks to the options object


who-a?...

On Tue, Apr 14, 2015 at 1:55 AM, Stevo Slavić <notifications@github.com>
wrote:

> directory names of submodules do not match artifactId, e.g. they do not
> have mahout prefix
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/mahout/commit/f7b69fabf1253b5e735e269c9410459d91816cdd#commitcomment-10708902>
> .
>


:+1: found a bug when try to add a rating with portal user. 403 page is shown. Maybe also good to limit the comments per user.

Good job


Я бы их сложила в один. Просто пусть для питонского будет свой модуль в проекте.


Since they're typically locked in step, it's not a good idea to bump dfvfs before its libyal dependencies.  Holding on this bump until I have the opportunity to build/test the dozen or so packages that entails.


this.init must be called with .apply(this, arguments)


I added the test to ArithmeticQueryIT.java, but it wasn't clear if there was a better test or not (or if I should create a new class) to test this.


execute onServerStop and callback from options


@vruano Other than the `.name()`, just some very minor comments.  Thanks for updating this code.


I think it's fine.


Bruno, are you sure this is right? This excludes 200 OK from passing the check.


Naasen,

Understood and I agree that receiving email notifications of half a conversation are pretty useless, which is why I raised the question. What I don’t understand is why I’m not receiving email notifications of the other half, is it something I can/ should fix or is there something in the group settings that is causing me to only see half a conversation?

I think that adjusting my email filters will not fix this problem as all they can do is react to the email I receive when surely the problem lies in the intent of the sender and my notification settings.  Thanks for the links to notification types. I took a look at these and it appears that from others in the team I am only receiving “Participating notifications” but from you I’m receiving “Watching notifications”.  Am I interpreting it correctly? Certainly I didn’t knowingly set it up this way. Surely I, or any individual in the team, should be receiving entire conversations or none? Where should I look in github to fix this, assuming that this is something under my control.

Thanks for your advice.

Tony

From: Nesan Waran [mailto:notifications@github.com]
Sent: Tuesday, April 14, 2015 11:05 AM
To: Gilroy-Morgan-Hill-Devs/stats-tracker
Cc: tonybabb
Subject: Re: [stats-tracker] fixed homepage rendering bug, created skeleton games app (94d1f74)

These emails are exposing my comments on a Pull Request <https://help.github.com/articles/using-pull-requests/> . Github will send comments to your email address based on your notifications <https://help.github.com/articles/about-notifications/> .

You should see a link "view it on GitHub", which will take you to the comment, in context. In my opinion, these emails are generally useless without clicking on the link to view in context. Adjust your notifications, or email filters accordingly.

—
Reply to this email directly or view it on GitHub <https://github.com/Gilroy-Morgan-Hill-Devs/stats-tracker/commit/94d1f74fcbd1c45928d86affdac467962aeda37e#commitcomment-10720022> .  <https://github.com/notifications/beacon/ADt2-tLOyEynjT0SAJzh9ngPrd71uATRks5n_U48gaJpZM4D_jmE.gif>


I don't understand this line at all, as $1 is ``/nix/store/some-path``.


@kmsquire, I'm not sure it's worth tagging a new version right now since the tests still doesn't pass in julia 0.4


Хорошо, сделаю. Спасибо за замечания, а то я бы мог долго думать, что у меня все хорошо :-)


Sounds good.  I've been experimenting with adding a health check for jooq when we get those changes merged to replace JDBI: https://github.com/square/keywhiz/commit/a2f01c8c17d86ff5ed9b83053c552b3f53a5968c

This is more of a sanity check on the configuration, so I'm looking into more fitting validation methods.


MySQL


resolves #2


Ahhhh! I was unaware of the e2e test, and had only run the unit tests and ci-checks. My apologies. I'll work on a fix!


@thegeman can you please review this?


To change: helper function types need to be the types of the variables.