If using ```has_key``` there's no point in specifying zero as the default value for missing keys. You don't want a zero for missing keys, you want a new empty array. So...
```
skill_reviews = Has.new {Array.new}
```
then instead of using ```has_key```
```
skill_reviews[skill_review.skill.skill_name] <<= skill_review.skill_level
```
will add the key-value pair <skill_name, [skill_level]> if the key is missing, or append skill level to the array if it's present.


Why grab the data separately here? The websocket sends this data when it first connects.


I already said that it was better to use LTC to tune values...Lucas came to inveigh against me. Now you are realizing what I said.
https://groups.google.com/forum/?fromgroups=#!searchin/fishcooking/tuning/fishcooking/_IvCddTSgGQ/AWkz2asaQFAJ


Here's what I got:
```Please enter the animal of your choice
DoggIe
You entered DoggIe
What sound does the animal make?
woOF
You entered woof
How many times does the animal say it?
6
6
The doggie goes woof woof woof woof woof woof ```


Oh ok then, I'm glad it worked :)


What is the documentation is incorrect?

*points at util.isObject*


This line is unnecessarily showing what number the user entered. Not wrong, just unnecessary. :smile:


Maybe we should note that Minors also inherit what can be in a patch release?

I assume that's generally known, but you never know.


Hi @jclancy93
Excellent job on the homework. You got the `.downcase` and the `.to_i` methods rockin!! I definitely think you could have done the bonuses, no problem! Keep up the good work!
Bita
@thebucknerlife


Why? The old theme looked nicer in my opinion.


@autopsychorhythmia


Here, you don't need the varaiable `animal2` you can just change line 2 to
`animal = gets.chomp.strip.downcase`
the `gets` call is by default always a string, so no need for `.to_s`

It's just a little cleaner this way, but your answer works! :+1:


See above comment! :smile:


查了一下, B.oldhamii貌似是白绿竹...


Cmon. Tend to your Indentation.


Awesome!  Thanks for the information.  I'll try it out this week.


When you do use the `.to_i` method, you don't need the `.chomp` here because `.to_i` gets rid of spaces and returns. It's not doing any harm here though. :smile:


Very nice interpolated sentence!


I think this is a mistake **char** is a datatype instead of a structure. Assign it to KEYWORD1.


As much as it sucks for people stuck with IE 8 like @ascot21 and myself, I think it's better for the Ember community as a whole to drop support for IE 8.


Thanks Bita!

forgot the last bonus! just pushed it to github now :)

Jack
> On Apr 3, 2015, at 9:27 PM, Bita Djaghouri <notifications@github.com> wrote:
>
> Hi @jclancy93 <https://github.com/jclancy93>
> Excellent job on the homework. You got the .downcase and the .to_i methods rockin!! I definitely think you could have done the bonuses, no problem! Keep up the good work!
> Bita
> @thebucknerlife <https://github.com/thebucknerlife>
> —
> Reply to this email directly or view it on GitHub <https://github.com/jclancy93/bewd-homework/commit/6dbe447787a5cfe675a6ea68bf07df5ed446b059#commitcomment-10571577>.
>


This is a monstrous view.
http://i.kinja-img.com/gawker-media/image/upload/s---m02eKy8--/18xbeunlnz3z9png.png


This change breaks usb mce remote support via ir-keytable (like imon-mce uses). I've yet to debug in depth and lsusb still shows the receiver. I'll let you know when I find the issue here, but wanted to mention it.


When you use the `.to_i` method below, you don't need the `.chomp` here because `.to_i` gets rid of spaces and returns. It's not doing any harm here though. :smile:


Indentation?


When you use the `.to_i` method, you don't need the `.chomp` here because `.to_i` gets rid of spaces and returns. It's not doing any harm here though. :smile:


Please change your compiler man, seriously we should try to use C++11


html
	font-family 'Open Sans', sans-serif
	-ms-text-size-adjust 100%
	-webkit-text-size-adjust 100%
	font-size 16px
body
	margin 0
article
aside
details
figcaption
figure
footer
header
hgroup
main
nav
section
summary
	display block
audio
canvas
progress
video
	display inline-block
	vertical-align baseline
audio:not([controls])
	display none
	height 0
[hidden]
template
	display none
a
	background transparent
a:active
a:hover
	outline 0
abbr[title]
	border-bottom 1px dotted
b
strong
	font-weight bold
dfn
	font-style italic
h1
	font-size 2em
	margin 0.67em 0
mark
	background #ff0
	color #000
small
	font-size 80%
sub
sup
	font-size 75%
	line-height 0
	position relative
	vertical-align baseline
sup
	top -0.5em
sub
	bottom -0.25em
img
	border 0
svg:not(:root)
	overflow hidden
figure
	margin 1em 40px
hr
	-moz-box-sizing content-box
	box-sizing content-box
	height 0
pre
	overflow auto
code
kbd
pre
samp
	font-family monospace
	font-size 1em
button
input
optgroup
select
textarea
	color inherit
	font inherit
	margin 0
button
	overflow visible
button
select
	text-transform none
button
html input[type="button"]
input[type="reset"]
input[type="submit"]
	-webkit-appearance button
	cursor pointer
button[disabled]
html input[disabled]
	cursor default
button::-moz-focus-inner
input::-moz-focus-inner
	border 0
	padding 0
input
	line-height normal
input[type="checkbox"]
input[type="radio"]
	box-sizing border-box
	padding 0
input[type="number"]::-webkit-inner-spin-button
input[type="number"]::-webkit-outer-spin-button
	height auto
input[type="search"]
	-webkit-appearance textfield
	-moz-box-sinzing content-box
	-webkit-box-sizing content-box
	box-sizing content-box
input[type="search"]::-webkit-search-cancel-button
input[type="search"]::-webkit-search-decoration
	-webkit-appearance none
fieldset
	border 1px solid #c0c0c0
	margin 0 2px
	padding 0.35em 0.625em 0.75em
legend
	border 0
	padding 0
textarea
	overflow auto
optgroup
	font-weight bold
table
	border-collapse collapse
	border-spacing 0
td
th
	padding 0


The tip issue was resolved here. The corresponding issue ( #5 ) will be marked as resolved, except for the fact that a dollar sign is still needed.


yi...


Hey I was just messing around in git and wanted to try to fork something.  These changes are minimal because we aren't translating much and currently it is a short tower site.


又查了下 https://zh.wikipedia.org/wiki/%E7%BB%BF%E7%AB%B9#cite_note-orhn99-
好像Dendrocalamopsis是错误
但是在中国植物物种信息数据库http://db.kib.ac.cn/eflora/view/search/Chs_contents.aspx?CPNI=CPNI-233-02989 上还是Dendrocalamopsis
可能需要专业人士帮助
还是先别动算了


Please comment the unnecessary part...


Lol, I can't believe I forgot that. Thought I tested this!


@rynkwn This is useful code which accomplishes what you're trying to do. I never merged it. Do you mind merging it? The nature of the request will have to change. For instance, instead of expecting a JSONObject, it will actually receive a JSONArray. See `test/integration/tickets_test.rb` in the Rails repo for more info on how "batch ticket purchase" works.


I have everything working fine, but I just don't understand how the mapping is to `/v2/api-docs`.  Can you explain more?

I'm expecting to set this:

```xml
          <webAppConfig>
            <contextPath>/</contextPath>
          </webAppConfig>
```

And configure the swagger listing somehow, programmatically to `api-docs` or `swagger.json`.


Displaying search results as the user might not select a movie from the list of suggestions in the search textbox.


Does this work? (impressed with rails cleverness if it does because a user has many assignments and an assignment has one review, which is a slightly different pair of connecting relationships to, say, the way a user ```has_many skills through current skills).


The wording seems to suggest that the submitter of the PR counts as one of the two sign-offs; which is to say that it's the same rule that we have now in io.js – one PR needs one non-author LGTM to be merged.


I like this idea, but there's a huge flaw in the implementation:
"If a command is blocked, its subcommands aren't blocked."
This means that a user can just send any argument after a command that's not expecting arguments, and this will bypass admin, for example "/quit test" will let anybody quit.
I suppose the command should check whether it's expecting any arguments, and if not, then it should refuse to run if any arguments are given. But there's still kind of a conceptual problem with subcommands vs. arguments.


I have worked on analyzing the survival rate of the RMS Titanic, which is an ongoing challenge on Kaggle (http://www.kaggle.com/c/titanic-gettingStarted).


Update entered from phone. Not tested yet.


@chrisdickinson not quite; this also applies to patches not submitted by a collaborator.

in io.js we have reviewed-by, and sign-off (where the sign-off is you commiting it), however, a collaborator who submits a PR may not review it, but only sign off as the commiter once reviewed.

However, in io.js we are allowed to both review+sign off (commit) commits we have not authored.


So, in general I like the idea of getting two sign-offs, though it does require a pressure-release for small or time-senstive commits. Perhaps we could ask folks that are circumventing the two sign-off rule to label the PR with "expedited" so that release tooling can pick it up for further scrutiny?


cc @rvagg

I just want to double check that this won't mess up `tools/release.sh`.


"The workflow for security fixes is not subject to the recommendations of this document, and will be defined separately by the TSC, who may devolve that responsibility to a security working group."


This is for PR #120


Looks good! Do you think we might want to generalize this class of use in other scenes? As it currently stands, I can't think of any scenes that need a custom class for it, but I guess it's possible.


Nice use of interpolation! :+1:


Nit: performance changes should include a benchmark, not a test case.


This works. You can also get rid of line 5 and change line 3 to
`animal = gets.chomp.downcase`
It's a little bit clearer and has one less step. Both work!

If you want to go a step further and get rid of pesky white space, you can change line 3 to:
`animal = gets.chomp.downcase.strip`


@sageexplorer Good Work!
Try out the bonuses next time. They're not THAT bad :stuck_out_tongue_winking_eye:
Bita
@thebucknerlife


Do we have feedback on how folks are consuming these tags at present? For my part, I tend to just read all of the new issues as they come in / are updated.


You can also add the `.strip` method at the end of line 28 so that the animal name doesn't have spaces ether. :smile:


good


HAHA.


Are pull requests landed to master, or the oldest supported LTS branch?


Maybe? But honestly I don't really see the point - even if we have another input handling class, 99% of the code is going to be specific to what it does with the input. Haha, but if it makes you feel more comfortable, go for it :wink:


When you use the `.to_i` method, you don't need the `.chomp` here because `.to_i` gets rid of spaces and returns. It's not doing any harm here though. :smile:


Think about a way to possibly get rid of that last comma. This is what I got when I ran your app
```
Enter an animal that makes a sound?
DoggiE
doggie    is a great animal
What sound does doggie    make?
WooF
woof is an interesting sound
How many times does a doggie    make a woof
5
The doggie    woof, woof, woof, woof, woof,
```


@Tedhadji
Great job! Good work on getting to all the bonuses!! Keep up the good work!
Bita
@thebucknerlife


Anything that requires downstream users to change their code is a major version bump. Fixing the docs to match current behavior would be a patch, but changing the source code to work like the docs would be a major.


We might note that any existing collaborator can propose a release in an issue, and that we expect that to follow the same lazy consensus as other issues.


Probably don't need this.


only includes problem 10.6


Shouldn't you really be calling AddHs() before embedding? Seems like there will be torsions you miss because of the missing Hs.


No, I don't really care... just don't want to get ourselves stuck in a position where we have to re-write code later on. It doesn't seem like it will be a problem though.


std::vector<bool> is, IMO, kind of ugly. You can use an explicit_bitset<> for this.


Why is this test here?


We have the [request mapping](https://github.com/springfox/springfox/blob/master/springfox-swagger2/src/main/java/springfox/documentation/swagger2/web/Swagger2Controller.java#L50) that serves up the api-docs set up with a property and a default value.

To override just add a property file to the class path and override the property (```springfox.documentation.swagger.v2.path```) in the property file. I updated my fork and this is [the relevant commit](https://github.com/dilipkrish/springfox-sample/commit/c8867f92d867ea17b94266346b16d4ed94a23a49)


Opened an issue about this [here](https://github.com/jasnell/dev-policy/issues/9).


In line 5, `.gsub(/\s+/, " ")` isn't doing anything. `.strip` is sufficient to get rid of trailing and leading white space. What `.gsub(/\s+/, " ")` is doing here is going through, finding spaces and replacing them with spaces. :smile:


See above. :smile:


and updated


You call the method `.to_i` on line 15
When you use the `.to_i` method, you don't need the `.chomp` or `.downcase` here because `.to_i` gets rid of spaces and returns. It's not doing any harm here though. :smile:


This answer works. Consider, for the sake of brevity, changing like 3 above to:
`animal_var = gets.chomp.downcase.strip`

That way, line 5 will read a little more cleanly:
`puts "You said " + animal_var + ". What sound does a " + " animal_var + " make?"`
This is just easier to read.

Both are correct though! Always consider readability. :+1:


@truetrev
This looks great! Good job on looking up creative solutions and getting to all the bonuses! Keep up the good work! :+1:
Bita
@thebucknerlife


This appears confused. I think you'll find this line can be simplified to:
```
ratings = Hash.new {RatingsData.new}
```


This should not be at hangupsbot.py, which is more for low-level functions. Plugins that need the option of passing in either a conv_id or a user_id should apply the split at a plugin level.


r+


I had interpreted the `allowData` member as an action to be performed. That is, if I hit a URL that matched `path`, but had data, we'd do something (block the request/strip the query parameter/whatever). I now have a different understanding of the model, where requests are untouched if they match a rule, and subject to the behaviors defined in the policy otherwise.

Is that accurate?


Hi @riahbuchanan
It's still rejecting your first input but good try with `rescue`. It's kind of impossible to manually account for every potential user error, but there are ways to do this with loops and we will go over them soon!


@riahbuchanan Awesome job getting to all the bonuses. Keep up the good work! :+1:
Bita
@thebucknerlife


saw approval from Manishearth
at https://github.com/utkarshkukreti/servo/commit/f31d06e59b3f5fe15ab0c86586271d63b2b04b04


merging utkarshkukreti/servo/use-quasiquote-for-attributes = f31d06e5 into auto


You can disable the XML warnings by unchecking "Build -> XML documentation file" in the project properties if you want to.


We need `frameType` (or a "navigational" boolean? but there didn't seem to be a reason not to expose the detail if we need a separate thing anyway) to distinguish between navigational and subresource requests. Navigational requests will have a frame type of "top-level", "auxiliary" (`window.open`), or "nested" (`<iframe>`). Subresource requests have "none".

This brings up an interesting point, though: do you consider `<iframe>` a navigational or a subresource request?


The higher level container makes sense, if only for `reportURL`. It's not clear to me what the value of an empty ruleset would be, but if you think there's a use case, then it doesn't hurt to support it.


merging utkarshkukreti/servo/use-quasiquote-for-attributes = f31d06e5 into auto failed


When you use the `.to_i` method, you don't need the `.chomp` here because `.to_i` gets rid of spaces and returns. It's not doing any harm here though. :smile:


If `allowData` is `false`, right?


I like this line :)


Good work! This answer works. Consider, for the sake of brevity, changing lines 3 and 7 above to:
`animal = gets.chomp.downcase.strip` and
`sound = gets.chomp.downcase.strip`

That way, line 13 will read a little more cleanly:
`"The " + animal + " goes " + (sound + " ") * times`

Both are correct though! Always consider readability. :+1:


Just a sidenote. `times` is a ruby reserved word. Try to avoid using it as a variable name. :smile:


@sneakykate
Great Job!
Bita
@thebucknerlife


열심히하넹 보빈이 :) ㅋㅋ


there are code areas where not a lot of people are confident signing off. requiring two collaborators to sign off in those areas could unnecessarily derail small PRs in those areas.

we still have the time threshold, if in 48 hours one person has signed off and nobody else has left any review comments that need to be addressed we're pretty confident the change should land. I don't see a compelling reason to raise the sign-off bar even farther.


oh ya, i forgot that we have teams for every WG :)


r+


we've adopted the security policy @evilpacket wrote in io.js (although I don't know if we've had the chance to use it yet).


wow, do you really need that? Those are not standalone scripts being executed on their own... I don't understand why you need them for the Mac package, but if it's really necessary, please change the permissions when you copy them in the build directory, not in the repository.


all non-LTS pull request should be against master, which I believe is what we want to move to in io.js based on my last read of the issue you were working for the next major release.


P.S. the greg-book.engine can be executable in the repository if needed, but not the others


saw approval from Manishearth
at https://github.com/servo/servo/commit/299257e23a84cd863b5a77430bff728370929c86


merging servo/servo/rollup = 299257e2 into auto


The OpenSSL 1.0.2a PR and the Worker Thread PR are both using this and I think it's useful as it denoted the state of the PR as not ready for a deep formal review.


merging servo/servo/rollup = 299257e2 into auto failed


maybe we should just add labels for any wg that will get this kind of stuff escalated, something like `stream-wg-agenda`? or we could ping the team and put `wg-agenda` and leave it up to the wg to make sure they bring it to their next meeting.


This is covered implicitly in the release process details.


This could even be `gregorio-pkginstall`, in order to avoid possible conflicts (but these seem unlikely)


Yes.
Each rule defines one entry point into the app.  If EPR does not apply to the request generally (eg: a same-origin request the policy does not apply) then the request is exempt from EPR.  Otherwise, EPR evaluates rules until there is a match.  If all the conditions for a rule apply then there is a match and the navigation or resource request can proceed.  "allowData" is one of those conditions.  If set to true then the URL can contain querystring / hash / POST data and still match the rule.  Otherwise, if there is querystring / hash / POST data then the rule won't match and the next rule will be evaluated.  If there's no match at the end of rule processing then default policy applies.


Why did you change to ugly 200px? It's so friggin narrow. Pic should be in landscape orientation, not portrait.


@olefb

You may need to revert this if you are building for amami/honami, as those have a flash, togari doesn't.


If you really need `gregoriotex.lua` (and others) to be executable, you can use `chmod +x $BUILDDIR/tmp/gregorio/x/y/z/gregoriotex.lua` here.


Another small thing. Now for tuning the code is ok, but for testing and eventually final version I suggest to use power of 2 divisor that compiler translates in a shift. So for instance if result is 33, you can rewrite the code as:

    m.value =  history[pos.moved_piece(m)][to_sq(m)]
                   + cmh[pos.moved_piece(m)][to_sq(m)] * 33 / 16;

It is a slightly approzimation that has no ELO impact but avoids some operations.


Thanks, it's getting better and better!


Now think like an object oriented programmer. These two lines of code always need to happen together. In fact incrementing ```times_rated``` is always the same code regardless of the rating. Feels like an object of class ```RatingsData``` should take care of this internal detail for us. We'd like it to have a method to which we can pass the new rating. Semantically, we are appending a new rating so we might consider the operator ```<<``` as a reasonable candidate to implement on ```RatingsData```
```
class RatingsData
    def initialize
      @ratings_sum = @times_rated = 0
    end
    def average_rating
      @times_rated == 0 ? 0 : (@ratings_sum.to_f / @times_rated).round(1)
    end
    def <<(new_rating)
      @ratings_sum += new_rating
      @times_rated += 1
      return self
    end
end
```
Now the two lines where you index ```ratings``` can be replaced with one line
```
ratings[review.skill.name] <<= review.rating
```
and your ```map``` call simplifies to
```
avg_ratings = ratings.map {|name, data| [name, data.average_rating]}
```


This gets remembered 'cause closure what we need is for it to actually run this each interval


new


Great, fixed it.  Thanks and i've deployed it to the editor.swagger.io.

Question for you--do you think I should rename it to "spring-mvc" instead of "springfox"?  Might get more momentum initially.  Clearly springfox is under the hood.  Let me konw what you think, I plan to release 2.1.0-M2 tomorrow, with your templates included.


Why you add the minified script into the main file ?


Oh, definitely.


Just call it `Info` like we do on all other traits.


@bitadj
Thank you so much for the all of the advise and kind words, really appreciate it. Have a great night and see you in class tomorrow.


I think this regression test needs its own regression test.

![trololololo](http://www.gifbin.com/bin/042010/1270751973_trololo-guy.gif)


Hi @quassy

Good points! How about: "Ambient sound player that integrates into the media player indicator"?


I'm a dumbass... Good thing I can't push new releases without all the tests passing.


In the prototype the context is all that's necessary to distinguish between navigational and subresource requests.  The contexts in the prototype today are:
"navigation", "image", "script", "stylesheet", "xhr", "other"
These correspond to values passed in the "type" parameter of chrome.webRequest.onHeadersReceived.
"navigation" corresponds to both "main_frame" and "sub_frame"
So the "navigation" context corresponds to navigational requests, and everything else corresponds to subresource requests.

Yes, <iframe>'s are navigation.  The important distinction for the purposes of EPR is that navigations can trigger both XSS and CSRF, whereas resource requests can at best trigger only CSRF.

You may see that the context as it is understood internally to Chrome is insufficient to determine if something should be considered a navigation.  If that's the case then I'd argue that the frameType should be used internally to determine which policy to apply (defaultNavBehavior vs. defaultResBehavior), but doesn't need to be exposed in the manifest to the developer.

My goal here is to keep the manifest as clean & simple as possible.  If I'm a developer with an entry point to specify in a rule, I shouldn't have to rack my brain considering various possibilities that aren't ultimately going to be relevant.


激起你的兴趣


I like cake , dance and dogs.


We're both dumbasses. Amazing that other people trust our code.

![IHAVENOIDEAWHATIMDOING](http://weknowgifs.com/wp-content/uploads/2013/11/i-have-no-idea-what-im-doing-dog-gif.gif)


I feel like that every day...


Might be simple just to make `getMove` add flags?

Wasn't that originally planned anyway?


#1
#Hello 2015 04 04


Good work! This answer works. Consider, for the sake of brevity, changing line 3 above to:
`name = gets.chomp.downcase.strip` (adding the strip method you use later on sound).

That way, line 4 will read a little more cleanly:
`puts "You entered " + name + "."`

Both are correct though! Always consider readability. :+1:


I'll show you on tuesday ;)


eh enable just for parser.js, not disable :D


I think the comment should read "This is only useful for a tunnel initiator..". Isn't it?


See above.


You're missing the `.strip` method here when you call `.sound.downcase`. All the more reason to change line 7.


@jomgom Great work! Just a few syntactical things. Awesome job hitting all the bonuses!
Bita
@thebucknerlife


nice 👍


Change class name, from "two-buttons" to "apply-or-cancel"


Change classfrom "buttons" to "apply-or-cancel"


Don't think this is necessary since there's only one release.


Change class from "top-block" to "job-top-line"


Having a little thought, the test after all are correct. The confusion was caused by a method by which detection of the left recursion which has wrong implementation. Explanations in [my comment](https://github.com/pegjs/pegjs/pull/307#issuecomment-89512575).


Also class names should be changed in scss to, of course.


Nope.. haven't checked that..


Rename Logo4.png into logo.png. Don't use Uppercase in image names next time. :)
P.S. Command for rename file in git below.
git mv src/assets/images/Logo4.png src/assets/images/logo.png


i will today
will add the menu with actual districts

On Fri, Apr 3, 2015 at 6:24 PM, Skipper <notifications@github.com> wrote:

> You didn't commit anything kiddo
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Skipper-116/House/commit/4d5b2293c11bc7863990920d527a9d01ed8f3d9f#commitcomment-10565350>
> .
>


改正错别字。


Yea apparently he has unlocked the rest of what only Faux's Paid app could do. But its been heavily modified for his own use with STweaks. I would love to see what you can do with it ;)


Yeah I think we do need a higher level container.  A site could reasonably serve an empty ruleset and it would be very much expected in that case for EPR to operate as advertised, as opposed to "fail open."


doh!  yes


yeah I am reverting this sorry about that


For more information and reading visit -
Single Page Application with Angular.js, Node.js and CouchDB (Cradle Module) – (Updated for Express 4)


Should have been stripped as part of #195, my bad. Fixed it


Can't reproduce this error message.


We discussed this one on the message board


He simply added controls to stweaks.. we had this controls present in synapse long back.
I don't see anything else.

PA gain control is not needed by me since both hammerhead and shamu sets it dynamically.


Looks like repetitive code to me. Refactor.


Changed initial if statement to check that bucket is not null. This allowed the removal of the else statement. Changed the standard for loop to a for each loop and modified nested if statement accordingly. Removed redundant "return false;" statement.


This fix will prevent to load plugin when use vim to create a new c/c++ file.


my_requests.html.erb
http://i.kinja-img.com/gawker-media/image/upload/s---m02eKy8--/18xbeunlnz3z9png.png


Ok I see, I must have misunderstood. Thanks for looking!


back


I have sadly not used an eyefi card in a while but it used to not work. It was a red card not an orange one.. maybe that is a difference?


Why not hook it into Git? Users can set their Github pages repo and directory then it will commit & push to Github.

And uploading is currently disabled on paste html.


> we still have the time threshold, if in 48 hours one person has signed off and nobody else has left any review comments that need to be addressed we're pretty confident the change should land. I don't see a compelling reason to raise the sign-off bar even farther.

Yeah, I might be trying to put too much process around this. It does slow things down a lot.

> there are code areas where not a lot of people are confident signing off. requiring two collaborators to sign off in those areas could unnecessarily derail small PRs in those areas.

Small PRs and commits need an escape hatch from whatever we put in place – even the "single LGTM + 48 hours" rule – and we should recognize that in this document, somehow. I'm not sure how we should phrase that, though.


I also think that this should be a toggleable feature. I'll work on this in a PR.


Awesome, +1. Was checking since joyent/node has a different approach.


Why is this change needed? (not the particular code line, the entire addition of class + type...)


I wonder if we can drop `Fixes`, since that metadata should ideally be contained at the PR-URL point (is it worth caching that data locally in git history?)


This is not the place to  commit the scripts, se should commit them in separate repository. This place is only for documentation


Needs updated


Code should not have any comments. That's what VCS are meant to be to track the changes and reverting things back to previous state.


Should match Other Rust Ext dir structure.


I think `touch` should be here (if we set flags to `IN_MODIFY` first and then add `IN_ATTRIB` with `IN_MASK_ADD`)


I added  guard from multiple include for old compilers.
That's why I send a message with "..improve..".
Hope You will understand me.


Never do such a huge commit do commits such as that an actual development is going on and a person following the commits can understand what's going on


The commit message should explain about functionality not about the client for whoom we are working


Awesome thanks for this, should i be worried about the Travis failure?


TeamCity xBIM :: Xbim Essentials :: Release [Build 43](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1292&buildTypeId=XBIM_XbimEssentials_Release) is now running


If you want this to work for both http and https change this to a protocol relative url like:

```
<script src="//connect.soundcloud.com/sdk.js"></script>
```


1. If you're looking for simplicity, do we need `image`, `script`, and so on? Could we just have `navigation` and `subresource` (and maybe `connect` for `XMLHttpRequest` and `fetch()` (and websockets (and eventsource)))? Is there really a case where you'd want to distinguish between `image, `script`, and `style` subresource requests? The risk seems similar, and the granularity not particularly useful.

2. The types associated with Chrome's Web Request API reflect Chrome internals, and not the way things are actually specified in Fetch. If we expose something granular, we should be consistent with that document, not with Chrome.


TeamCity xBIM :: Xbim Essentials :: Release [Build 43](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1292&buildTypeId=XBIM_XbimEssentials_Release) outcome was **SUCCESS**
Summary: Running Build time: 00:00:54


I think we actually need to drop this entirely, and move it up into the `matching` algorithm. I'll do that this weekend.


Got it, thanks.


My use of these parameters is senseless, and hue is not implemented. It does work, though, if you pick your them carefully.


修复三个bug
[1]
重现：刷新，点两下空格，再用鼠标选中一个ball，使其变成'selected'(但是没放入lucky-balls)，此时再点一下空格
现象：运动故障
原因：当hit()函数递归调用未停止却被外部再次调用时，会产生问题。所以每次给this.timer赋值前要clearTimeout
[2]
重现：当ball在运动时点击lucky-balls中的ball
现象：运动故障
原因：当ball在运动时，点击lucky-balls中的ball时不应调用hit()
[3]
重现：刷新，按一下空格，在ball快速运动的过程中点中一个ball，使其变成'selected'(但是没放入lucky-balls)，此时再点一下空格
现象：同时出现两个'selected'的ball
原因：当ball在运动时，若有ball被点中则需要更改按钮此时的状态


Is there possibly some built jar files for this version of Vault or maybe a Jenkins CI instance available?


@deadalnix I don't know what `left _shit_` is.


1> it's not necessary to include source files in smessage.cpp
2>for walletdb.cpp, I couldn't get the daemon to compile without changing the wallet version check to FEATURE_LATEST (bitcoin expects CLIENT_VERSION to be greater than or equal to FEATURE_LATEST, but it's not so for bitcredit)


Hi Rascov,
Congratulations for your great contribution.
Besides your article, and files on github here, there is no other more explicit material OpenNet?
I need to simulate a WLAN in MiniNet.
OMNIUI throws me a WLAN simulated statistics with OpenNet?
Thank You


test


The findFreeID() change I get, but why use /dev/mysensorsUSB as default serial port? It's just as good/bad as defaulting to /dev/ttyUSB2, right?


The subject and message for this commit should be probably rewritten ("Adding support for tags"), and possibly the commit should be even split into two, to not mix adding support for tags and changing the Loggly URL? I'd also add a link to corresponding Loggly documentation for both.


Yes, it is just something I did locally to get the same USB device name
each time I plug it in. At the same time I changed the name to make it
easier to differentiate from my other devices. You can disregard it if you
wish.
On Apr 4, 2015 9:26 AM, "Embedded Innovation" <notifications@github.com>
wrote:

> The findFreeID() change I get, but why use /dev/mysensorsUSB as default
> serial port? It's just as good/bad as defaulting to /dev/ttyUSB2, right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kolaf/MySensors_MQTTGateway/commit/140e8ef54306ea947f8e80d9f1ba7b338120561e#commitcomment-10571932>
> .
>


Added heeee line :)


hey you


LOL! What was I thinking! Reverted


No. The only numbers to disallow are negative and fractions.


No need for the `else` because of the `return` in the previous block.


```cpp
m_control != NULL
```
for consistency.


```cpp
m_control == NULL
```
for consistency.


Hahahaha :) Let me make this disapear XD


Hi gedp,

I am afraid we don't have other material of OpenNet for now.
We are moving forward to a distributed version that will provide more scalability in large scale simulation. We will see if we can provide more details and documents in the upcoming release.

For OmniUI, the current version can only shows the information and statistic of OpenFlow-enabled devices. We do have a plan to support wireless devices such as AP in OmniUI. In a near future you will be able to manage simulated APs through OmniUI.

Best,
Charles


@j-selby So? Keep things as simple as possible. Look at all the popular PHP projects. They have either an installation page which creates the configuration file, or a plain configuration template floating around in their source code. You were that guy who was so worried about the 'standards', right?


Shouldn't this be conditional upon a visible skill level?


This view is scary big.
http://i.kinja-img.com/gawker-media/image/upload/s---m02eKy8--/18xbeunlnz3z9png.png


See https://github.com/libgdx/libgdx/issues/2612 which was where I had
reached in December.

I think with these changes - the destination-out part has no effect since
it is immediately overwritten by the source.
i.e. if blending = none, it behaves exactly like blending = source-over now.

So effectively, we only have one blending mode of source-over now for GWT.
This is causing my code to break.

In normal pixmaps, blending makes the colors blend - not sure what the
equivalent in HTML would be - maybe the mode of "lighter"?

On Fri, Apr 3, 2015 at 6:04 PM, Justin Shapcott <notifications@github.com>
wrote:

> The original problem being fixed was that when blending mode was set to
> none, the entirety of the existing image would be cleared. That was not
> consistent with the other backends. Now, only those pixels which will be
> overwritten by the new content are cleared (by doing two passes - one to
> clear the existing pixels, the second to draw the new content).
> On Apr 3, 2015 5:14 AM, "sridharsundaram" <notifications@github.com>
> wrote:
>
> > still having problems.
> > Use-case for which I sent sample code works correctly but in a different
> > place I am now having problems with both chrome and firefox.
> >
> > To create a useful use-case I need a little more background.
> >
> > Can you please explain the motivation behind the original change?
> > I am not very familiar with canvas (my understanding is from here:
> > http://www.w3schools.com/tags/canvas_globalcompositeoperation.asp
> > What I had understood from earlier code was that -
> >
> > - blending = none was same as canvas with global composite operation
> > of copy
> > - blending = source-over was same as canvas with global composite
> > operation of source-over.
> >
> > Now the semantics are not clear to me.
> > Is blending = none now same as canvas with global composite operation of
> > source-over?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/libgdx/libgdx/commit/87848dda26660e7e3c091dba2d3693bcf1ec4863#commitcomment-10562212
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/libgdx/libgdx/commit/87848dda26660e7e3c091dba2d3693bcf1ec4863#commitcomment-10562428>
> .
>


Hmm. Curiously all three of you have pretty much the same code here. I'm guessing only one of you wrote it. Forrest has a long code review comment on this. Please ask him to share it with you and Travis.


hi @Cl3Kener

I build arm-eabi-4.9 with your scripts but add "--enable-plugins",  I use this to build my kernel but it get error:

```sh
/tmp/ccbIqRwF.ltrans28.ltrans.o: In function `perf_output_copy':
<artificial>:(.text+0x2c77c): undefined reference to `memcpy'
/tmp/ccbIqRwF.ltrans28.ltrans.o: In function `file_read_actor':
<artificial>:(.text+0x306bc): undefined reference to `__copy_to_user'
<artificial>:(.text+0x307e4): undefined reference to `__copy_to_user'
/tmp/ccbIqRwF.ltrans28.ltrans.o: In function `iov_iter_copy_from_user_atomic':
<artificial>:(.text+0x32e8c): undefined reference to `__copy_from_user'
<artificial>:(.text+0x32f10): undefined reference to `__copy_from_user'
/tmp/ccbIqRwF.ltrans28.ltrans.o: In function `shmem_symlink.lto_priv.16969':
```

and I build with this:

```sh
cd binutils/binutils-uber
git branch -a
* (detached from uu/linaro-2.24)
  remotes/m/master -> uu/2.25
  remotes/uu/2.25
  remotes/uu/linaro-2.24
  remotes/uu/linaro-2.25
```


enum class 型指定できるんか！つかおｗｗ


I believe the original thinking was around memegen potentially wanting to expose a path they know to be just images.  Then a cross-origin script reference would be blocked, which seems good.  Though that doesn't necessarily help achieve our goals w.r.t. mitigating specific types of XSS & xsrf.  So if you think it's better not to differentiate between resource types then that's OK with me.

--- Original Message ---

From: "Mike West" <notifications@github.com>
Sent: April 4, 2015 12:08 AM
To: "mikewest/webappsec" <webappsec@noreply.github.com>
Cc: "David Ross" <dross@pobox.com>
Subject: Re: [webappsec] Update to comment on issues, add content (556a0b5)

1. If you're looking for simplicity, do we need `image`, `script`, and so on? Could we just have `navigation` and `subresource` (and maybe `connect` for `XMLHttpRequest` and `fetch()` (and websockets (and eventsource)))? Is there really a case where you'd want to distinguish between `image, `script`, and `style` subresource requests? The risk seems similar, and the granularity not particularly useful.

2. The types associated with Chrome's Web Request API reflect Chrome internals, and not the way things are actually specified in Fetch. If we expose something granular, we should be consistent with that document, not with Chrome.

---
Reply to this email directly or view it on GitHub:
https://github.com/mikewest/webappsec/commit/556a0b5a478dbc952a082d7111e3c8a4f5aa4ea7#commitcomment-10571904


@kanaka
I've fixed readline issue and self-hosting test could run.
But it can't pass step3 in self-hosting test.
Is there some hints to debug self-hosting?


It's clear from the site you made that it's just a front with no substance.

---
R.I.Pienaar

> On 4 Apr 2015, at 00:45, Alireza Savand <notifications@github.com> wrote:
>
> @ripienaar How come this one is spam?
>
> —
> Reply to this email directly or view it on GitHub.
>


Added


Misnamed.


Thanks Charles for responding.
I hope to use my Masters thesis OpenNet,
even though I am not clear that I experience to bring something new,
if I want to work with SDN in WLAN.
Of course you will mention in the literature.
I hope that this doubt me, you can I clarify the.
Thank You


This doesn't solve the issue. In the INVOICE module the customers still can see other customers in the select box and cand generate reports for other customers. The select box should contain only records for the authentificated customer. Only the administrator should have the option to generate reports for all the customers.


@Turini my fault here. need to go back and fix it asap :( sorry


It's confusing to read ```@user.selected_employees```. Either your variable name or your method name is poorly chosen because a user doesn't have selected employees, but a project request does.


@Turini  the problem now is that the current jar file (in a branch on gnarus) loads with a weld exception that i dont understand. when I get back I can take a look with you?


yeah I know its disable, it is now using twiz's site.
Also for pushing to git their repo would need to have GitHub pages set up and they would have to enter a user name and password. The configuration would not be worth it


Does charge only mode work ?
Anyway you should apply patches with authorship


Well, seems there're debug printer in *.mal, nice!
I think the problem is the env search didn't go to higher level so that it can't find "+" function. Seems the implementation of env is very different than mine.
I'm trying to figure it out...


We can take it out then. There must have been something there because the build was failing in the animal sniffer.


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.135](http://teamcity.monogame.net/viewLog.html?buildId=5998&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Issue #322 might induce that the condition In case of Threads.size() == 2 does not fill all necessary preconditions to avoid the assert:in
actual line 1669: assert(Threads.size() > 2);
maybe some other changes together from Pull request #260 are responsible for this where this assert has been added as the last change
to avoid this maybe add the deleted line again ?
line 1591 from above: if (Threads.size() > 2)
I cannot test this as I have only 32bit 1Core


Why are you checking ```response.selected_employee``` twice?


This change causes exceptions for us. We are using PostgreSQL and passing String values for JSON fields as Types.OTHER using JdbcTemplate.
IMHO JdbcTemplate should not be too smart - if I pass String as OTHER - it should reach the driver as is. OTHER is documented as
*indicates that the SQL type is database-specific and gets mapped to a Java object that can be accessed via the methods getObject and setObject*
So, probably some other place using OTHER is just not doing that correctly?


Could you please create an issue in our tracker? Thanks!


Das Problem bei der impliziten Indexierung ist, dass an einer account entität keine änderung mehr passiert, sobald sie einmal custom ist?


This doesn’t look like a no-op…

The current whitespace formatting of the sources in the repo is kept consistent through use of a set of Eclipse formatter settings. There’s a file with those Eclipse formatter settings in https://github.com/validator/validator/blob/master/resources/eclipse-formatter-profile.xml and https://github.com/validator/validator/commit/3689b23e6e9ab69aab3c8a8ef86a3a4b36d358af has links to details about how to use Eclipse formatter settings with NetBeans, Maven, and IntelliJ.


zgodnie z konwencja pisania w Pythonie, metoda powinny byc nazywane z podkreslnikami. np. get_start_time


to samo co wyzej


im sorry for inconvenient friends...


@norine-badr


w django jest cos takiego jak funkcja get_object_or_404, ktora obsluza juz to czy obiekt istnieje


well, i didn't answer because i'm man and i need some sleep. "Team culture"? when i was asking and publishing just simple suggestions to irc which could improve performance and etc, you instantly called me as noob which knows zero, right? newer c++ standarts adds some more performance and better code style.
 DankoDJ, maybe i'll need to ask but as I said, i will not include copyrights. When i will parse whole new source scripts from your project, then i will add marks, now i just will include authors in commit and its message. I just like to read and i know what these licenses allows me to do but you still decline it :) code exchange and similar - its only users comments, not original source to use it if you looked info about differences here :)
I'm not living in dream world but simply i like that game, i like programming and i would like to have good core and i have different ideas than ascemu, overwise i may go into one project.

I was student in university where i had programming, administration, multimedia courses in 3 years and i learned well how to fully optimize code and make it well readible.

about changes, i'm finishing three new features - creature_difficulty_stats system, random bg and dependencies update in cmake (some of binaries will taken directly from preinstalled libs and it also will get updated mysql dependencies).


@theadamparker this is a pretty handy tool: http://ezgif.com/optimize/
But i haven't been able to get the gifs below ~2.5 MB. still better than 5. Let me know if I should replace the files or if you want to try it


where is your documentation? @mohamed-mehany


add a space between the # and +, so they can be distinguished easily


Hi @Ufos92, I'm not quite following. What does this commit have to do with Sympy floats?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.135](http://teamcity.monogame.net/viewLog.html?buildId=5998&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 470, ignored: 6 Build time: 00:14:25


![screen shot 2015-04-04 at 10 07 42 am](https://cloud.githubusercontent.com/assets/10825648/6991954/e563d9fc-daba-11e4-9e80-8b703f567007.png)
 try to follow this please, and be more descriptive and add your signature 'aka' your name @mohamed-mehany


Why! ;)


知らんかったんか！
雑魚め！！！！！！

うそですごめんなさい


Sure, filed https://jira.spring.io/browse/SPR-12890


add
![screen shot 2015-04-04 at 10 07 42 am](https://cloud.githubusercontent.com/assets/10825648/6991970/b0a364d4-dabb-11e4-9fd0-11db5c8458f2.png)
your signature like this and you are good to go, and your success/failures on each method
like this


this ```puts params``` looks like debugging code that should not survive


You accept the Terms of Use (you registered on our forum) read it ;-)


It works only with property initializers, it's another ES7 proposal.


![screen shot 2015-04-04 at 10 15 17 am](https://cloud.githubusercontent.com/assets/10825648/6991974/ecb0131e-dabb-11e4-8567-206232bda22a.png)
checked your controller as you mentioned but could not find docs @ebramsherif


Oops, the event I modified is LoR.20 not 21


why just one?


Resolves #30


Thanks for submitting this PR @ecdfernandes. Why would you want to checkout and existing remote branch with a different name? The purpose of a remote branch is that more than one person can work on the same branch at the same time.

I do think its nice to add the -t command though :)

What do you think?

Thanks a lot!


add your signature at the top like this and you are good to go @narimanhesham
![screen shot 2015-04-04 at 10 07 42 am](https://cloud.githubusercontent.com/assets/10825648/6991986/437f330a-dabc-11e4-92f2-19cbe047f0f7.png)


its changeable feature on forums :)


Just saying, read it.


@Tommy-Geenexus

Ah, yes, thanks! :-)


Why is this necessary? I don't think we do something like this elsewhere and I'd just fix the caller instead of having this...


お詫びとしてレモンジーナ買ってきてｗｗｗ


@norine-badr


土の味の何がいいのかｗｗｗｗ
気になってたしコンビニいってこよｗｗ


Actually the commit message is incorrect. Here, I am removing haskell-mode from the list of enforced packages because use-package already is ensuring that it's installed. I'm also commenting out the lines that use my own copy of haskell-mode (that was for when I was fixing a bug in the syntax-highlighting of literate Haskell). Currently, I am using the haskell-mode provided by melpa.


`:` is just a command which ignores its arguments.

I just copied what the other ocaml tool probes do.  It would probably be better if they all defaulted to something like `$MISSING camlp4", etc, but I really know zilch about ocaml and SWIG's support for it, so making sweeping changes to the configure machinery for it seems a bad idea.


I think the coverage badge is incorrectly linked - I was wondering why this was showing unknown. Would you fix that while you are here?


For `argparse`-based commands (that is all Django built-in commands), `verbosity` is already converted to an integer, so I don't see how it breaks on Python 3. If you have some legacy command which still uses `optparse`, then you should keep the `int()` casting. Apparently, this is currently under discussion in https://code.djangoproject.com/ticket/24518.


@Mailaender: `AttackPlane` already has an `Info` field, inherited from `UpgradeableTrait`, iirc, so I had to call it something else.


Please don't do this type of formatting, I don't think it helps readability, and my pep-8 linter (PyCharm) says to not have spaces in this case.


seemed good and very clean


Rebase errors aren't meant to be fixed with an extra commit -- they're meant to be fixed during the rebase :)


:cry:


Are you sure a post's creator wouldn't be curious? Sometimes if you want something done properly you have to do it yourself. But you're probably right most of the time on this.


If we're going to have a comment here, it should be a comment that describes the whole method; e.g.,:

```java
    /* *
     * Constructs a <code>SimpleDocumentValidator</code>.
     *
     * @param initializeLog4j <code>true</code> to initialize log4j,
     * <code>false</code> to not initialize log4j. Use this parameter to prevent
     * <code>SimpleDocumentValidator</code> from overwriting an existing log4j
     * configuration when calling <code>SimpleDocumentValidator</code> from an
     * application that already has log4j configured.
     */
```


`inputDecorator` -> `InputDecorator`


No, that is a webhosting, although a new one.

Look at the their page:
http://facebook.com/savand.bros

To be honest I have no I idea how it can be a front page with substance.
Just create a account and try it by yourself.
 On Apr 4, 2015 11:47 AM, "R.I.Pienaar" <notifications@github.com> wrote:

> It's clear from the site you made that it's just a front with no
> substance.
>
> ---
> R.I.Pienaar
>
> > On 4 Apr 2015, at 00:45, Alireza Savand <notifications@github.com>
> wrote:
> >
> > @ripienaar How come this one is spam?
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ripienaar/free-for-dev/commit/11773bfab125e18dc91bac62c76a856cfdf4b96d#commitcomment-10571972>
> .
>


I don't think this is particularly useful.

We should instead have it dump the entire message if the 'debug' key is present.


This effectively disables the exception raising. Why?


It would also be good to add
```
@windows_only @test readlink(dirlink) == subdir * "\\"
```
if we can't figure out what causes the discrepancy, we should at least have a test that it works at all on Windows, despite the slightly different result


your project just changed it now :D funny boys


Yeah, it was just a bit easier for me, I proof-read the config before merging, and it was confusing me.


Thanks much for this—I hadn’t yet considered myself the case where somebody would want to call the validator from another application that already had a log4j configuration of its own. This change looks great and I can go ahead and merge it as soon as you make the changes in the comments I made for the other commits in https://github.com/validator/validator/pull/86


deja repondu


yes and it is valid from now including all commits. This commit was merged before we updated it, so everything is okay :-)


Sorry, the above would fail on XP I think. So maybe modify the line as you have it to instead be
```
@non_windowsxp_only @test readlink(dirlink) == subdir * @windows? "\\" : ""
```


done (I think)


I think you should run the engine against itself, not against master.


we will have the same issue when persisting Namespace as an entity. It too does not have a namespace property.


kk


look, this is a simple affiliate based business reselling others services via clickbank, you know it since you work on it, i know it since I can read code.

it's not appropriate for this list, I've had complaints via email about its inclusion, why dont you just accept it with some grace?


@andresgutierrez how about self dynamic call?
```zep
public static function $fetch() -> <Di>
    {
        return self::_di;
    }
```

```zep
let this->_di = Di::$fetch(),
    request = this->_di->{"getRequest"}();
```

> RuntimeException[0]: Call to undefined method Ice\Di::getrequest()


After seeing the commit message in the CM changelog I was curious enough to actually look up this diff to see what changed...

I must say I'm a bit disapointed ;-)


Oh I see.


From an XSRF perspective, there's no difference between `<img src="/vulnerable-endpoint/">` and any other type of request, right? If that's the goal here, then the extra granularity doesn't seem valuable.

Why don't we start out by dropping the distinctions down to `navigation`, `subresource`, and `connection`, and see where we end up? Adding things is simpler than taking them away. :)

Relatedly: where does prefetch fall here? Prerendering?


Yep that's exactly what it means.

However this is python, so nothing is really protected and we are allowed to use these fields anyway. This refactor simply made this error glaringly obvious (GameConnection should not be messing with Game internals) -- but this is not the only offense, and getting rid of them is a slow process.

Overall this archictecture (` GameConnection` and `Game`) is a bit of a mess. I would prefer if we had `GameConnection` talk to some form of `Lobby` class, which would by itself spawn a `Game` when it is launched.

This would seperate the concerns a bit more cleanly.


I was thinking of it, but then I figured it does not matter as long as I know how many torsions to expect. I mean now I expect 1 torsion to be found, and if I would have the Hs added, I would expect 3 torsions, but the tests I do will be similar, no?


#25 @maikany


That's what I was thinking. Some games can be bought in as many as eight different app stores. Their websites usually do a great job listing the purchase options.


sss


ddddddd


True, I forgot to take this out.


I wonder what the translation would be useful for. Being an abbreviation the globally recognized one is most appropriate. I would hate if a German translator decides to put ZVS instead of LF (for "Zeilenvorschub"). We properly don't translate the abbreviations Document->Set Line Endings either (for German, cant tell for other languages).


The whole point of this pull request is to not show `(amnesiac)` for every single player in the `random` game mode.


Ok, I will replace it.


No problem! :)

By the way, I was doing some more work during the week:
- Throttle and debounce to the scroll and resize events.
- Automatic padding to the parent element to avoid weird jumps when the element goes out of the flow by setting its position to "fixed".

Those are changes a bit specific to my needs but I think they could be useful for everyone else. You can check it out on my dev branch (https://github.com/4lejandrito/react-sticky/tree/dev) and if you're happy with it I could submit another pull request.


added separator


Because you found that Schärfer's patterns do not discriminate between non-cyclic single or double bonds although the torsions only make sense for single bonds, so I check that I really get single bonds (except for the new pattern for double bonds of course). Would you leave this test out?


#18 @maikany


hum. no, actually, I didn't.
I can't seem to get the admin "console" on coveralls.io either (I probably don't have enough karma for that)

can we merge this PR and deal with the coveralls badge in another one?


Fine by me.


I intended to test that `IN_MODIFY` flag has hot been cleared. So its better to add my first sentence as comment to the test case and leave `echo` here. A `touch` test can be done as separate step.


I can change the setting ;)


Wait, what? This makes no sense...


Could you change this to:

            ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                               "postgres: IPv6 literals require nginx-1.3.1+");

otherwise it's hard for users to figure out which version they need to upgrade to in order to fix the error.


Have you ever rebase a 5 month old branch?
I did not force push, to have a stable commit hash ;)
and I am sure you will never merge this, because it need reviewing :D


I don't think _IPV6 in the name is needed here, it's still a host variable and whether it's IPv6 or not, depends on the value.


**ಠ_ಠ**

Seriously? Either keep the comment single-line or put both lines **above** the thing you're commenting on. (Not to mention that the second line is misaligned.)


Style: extra space, not aligned.


Style: two spaces before `max=`, please.


Style: extra empty line.


干番茄


ok


I'm not sure whether there is value in keeping this around, but if you want to keep it, then I'd prefer if this was before the check, not after.


Is it working? I've never managed to make it work on my computer (last try was a long time ago, though).


Nope,
the git diff is only confusing ;)
Their are lines between :D

https://github.com/IDragonfire/lobby/blob/f6a2ec0c9432f9c284d1d6f5f82b01a311ed0949/src/client/_clientwindow.py#L1756


infact, we might add somethinge like
,\n CONDITION_SOURCE_MAX in the enum, and
static_assert(count_of(conditionSourceToStr) == CONDITION_SOURCE_MAX

(Or rather use such a concept as generic policy when creating similar helper-arrays)


I think the first comma is wrong here.


And LANGAUGE should be LANGUAGE.


@FadyKesbra  please fix the problems I have mentioned to you in person.


Great work!


URLDecoder use in RESTServer.java: This method is strictly meant for query strings; It *must not* be used on path components of a URI, as paths and queries command different encodings, eg. space may be encoded as "%20" or "+" respectively. As the Plus sign is allowed to appear literally in a path component, it is *wrong* to turn it into a blank: The URLDecoder must go away here.


its not working on vbox, im about to try it on my system. I'l let you know.

On Sat, Apr 4, 2015 at 4:13 AM karasu <notifications@github.com> wrote:

> Is it working? I've never managed to make it work on my computer (last try
> was a long time ago, though).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Antergos/antergos-iso/commit/29ff61067600713a81bcd11717b4a225889a2c54#commitcomment-10572218>
> .
>


Nice job Hien, good to see most of the stuff moved in classes. :+1:


Unfortunately this does not fix it --- probably perl's own setlocale() call was done too early (while initilaizing the interpreter). The only fix seems an explicit call to POSIX::setlocale. See https://github.com/seveas/Linux-Prctl/pull/1


(the Buffer node.js document?) I am not really new in buffer stuff whether in node or typed arrays (https://github.com/Ayms/node-typedarray), I will clean the code now that I know how this works, currently this is mapping the c++ implementation and indeed can be improved, the confusion came from the boost implementation and the fact that most of crc32c examples (sse4_crc32c) are talking about processing strings, probably this is trivial for you but can be confusing for someone that does not know well crc32c,  maybe you could add some examples and explain the binary/utf8 possible issue, thanks for your advises.


Cleaning Code


rootURL= 'https://api.mobileminerapp.com'


This made the main mesa output depend on clang through libMesaOpenCL.so, which is a terrible bloat.


:thumbsup:


You know.. Some would say 8 spaces are the way to go. Just saying.

https://www.kernel.org/doc/Documentation/CodingStyle


Why ``n.get('type', None)``?
Are there nodes in graph without `type` attribute?

If not, then better fail early on broken graphs.


Перенастрой свою студию что бы табуляция была из 4х пробелов а не один таб (попробуй выделить и поймешь)


лучше написать border-radius: 0px 3px 3px 0px;


Snuck this in here. It shouldn't have been here.


No License Header, copy from other .py files.


This configuration is using variables that were not declared. Is this plugin still useful? Why alpha is better than final?


Убери все классы moduleMPlayerListTrackPositionX
А если у нас будет 100 композиций?

Убери у них  position:absolute; и они сами будут подряд


position: absolute; нужно бы уже вынести в отдельный класс
#moduleMusicPlayer > .moduleMPlayerHead > div{
    position: absolute;
}


I don't really know which one of the commit corrected my download, but now it works fine (all the history is downloaded, which was not the case before).
Thanks.


Перенеси второй закрывающий тег </div></div> на новую строку


A consideration not mentioned is the ability for users to upgrade.  If you're on XP or Vista SP1 or lower you will have to upgrade your OS.  Microsoft has officially dropped support for XP.  I'm unsure about earlier versions of Vista, but a SP upgrade is less significant.  If your OS is no longer supported, I don't think there's a reasonable expectation of third party vendors to continue support either.

+1 for accessors and classes


Забыл закрывающий див, поглотил все последующий модули.


Is #"string" a file number?


와우 ㅋㅋ


#Wow


Этот фон будет только у третьей композиции?


Почему у 10й композиции нет обводки внизу?


Tu fais un push que je mette à jour de mon côté aussi ? Merci


The information to allow that will be prepared in https://github.com/FreshRSS/FreshRSS/issues/798
In both cases, we need the information about when an entry was last seen (to avoid purging entries that are still in the RSS feed, and to avoid removing entries that have recently been updated).


moduleMPlayerHeadRedButtom
Ата кнопка сейчас Red а завтра она станет зеленой, и вместо того что бы поменять только цвет, мне нужно будет поменять еще и название класса в 2х местах (минимум)


I found a typo in testcase failure message: ""receive notifications on __touch__ after watch with IN_MODIFY flag " should be "receive notifications on __echo__ after watch with IN_MODIFY flag "


Thankyou! I've pondered more than once how to tackle this.


Break `no_delete` outside massive assignment.


Такие длинные конструкции плохо читаются, разбивай их на более мелкие


Is this change needed? If not, just let me know and I'll revert it on the commit (Dr. Arnab has already had this reverted by Rod since it breaks the pdf output; don't want to break it again).


Debian has an older version of mingw-w64. I will try to sort the patch out so that it works with the recent version as well as the older ones.


@chids Is the url supposed to reference start time other than beginning?


you should make it private until the day you find a legitimate reason requiring it to be protected. Otherwise, it will make your maintenance work more complex (protected stuff are part of the BC surface area, making changes harder if you want to keep BC)


Сделай вот такую конструкцию

. moduleMPlayerHeadTimeLine{
    position:absolute;
    top: 10px; /*пример*/
    left: 10px; /*пример*/
    width: 10px; /*пример*/
    height: 100px; /*пример*/
}
. moduleMPlayerHeadTimeLine > div{
    position:absolute;
    top: 0px;
    left: 0px;
    height:100%;
}

Программисту в будущем не нужно будет знать какой длинный эти линия, он просто укажет процент


frameworks/base/packages/SystemUI/res/layout/msim_status_bar.xml:102: error: Error parsing XML: mismatched tag

looks like line 102 and 103 may not even be needed now?


frameworks/base/packages/SystemUI/res/layout/status_bar.xml:101: error: Error parsing XML: mismatched tag

line 101 looks like it is probably not even needed


Noted, will do so in the future.

On Sunday, April 5, 2015, Xuerian <notifications@github.com> wrote:

> It is usually beneficial to at least separate unrelated changes into
> different commits, with your wheat additions and DRAK fix.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Dwargkiller/EnderIO/commit/16e4294e5053d10e48aa23a9bd31e6885fb2a7a9#commitcomment-10575103>
> .
>


For cross-compiler CRT compatibility you should point towards compat headers here (it works better in case something changes than defining it here):
https://github.com/bkaradzic/bx/tree/master/include/compat


Sadly, this commit breaks OpenPGP support as shown by test case no. 14. I haven't been able to find the exact reason yet, but I have verified that the priorities set in `mgs_select_virtual_server_cb` (post client hello function) correctly allow both X.509 and OpenPGP certificates. However, when the certificate retrieve function `cert_retrieve_fn` checks the sessions certificate type, the result is `GNUTLS_CRT_X509`. Since the client in the test case is configured for OpenPGP only, the handshake fails. Do you have an idea where the problem might be, or maybe even a fix?

[Branch `new-gnutls-api`](https://github.com/airtower-luna/mod_gnutls/tree/new-gnutls-api) in my repository contains your patch merged with my test suite improvements (and unrelated bug fixes), which should make running tests a lot easier if you want. 😉


Yeah sure, will do


You are absolutely right. I discovered the real origin of the issue - an older version of django-configurations was adding an option to the BaseCommand.option_list, which was causing it to use optparse for all management commands rather than argparse. None of the add_arguments() methods were being called at all. I updated django-configurations, and the problem is now solved. Sorry for the trouble!


Si j'ai bien lu la doc, il nous faut rajouter le code pour l'ajout du tableau, pour chaque "groupe"


Thank you for getting rid of the old ProgressMonitor code! Swing does provide a ProgressMonitor with most of these features. https://docs.oracle.com/javase/8/docs/api/javax/swing/ProgressMonitor.html


test commit


#this is my first python project


Found BROKEN by full.
s (--ignore_memory_light)'
test_jacobian_tools (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_kron (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_matrix_expand (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_mul (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_mul_sparsity (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_mul_zero_wrong (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_mxnull (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_mxnullop (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_mxnulloutput (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_null (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_printLimiting (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_regression491 (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_repmat (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_reshape (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_reshape_sp (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_scalarMX (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_setSparse (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_singularcat (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_sparsity_indexing (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_subsass (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_symbolcheck (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_ticket (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_trans (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_transpose_bug (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_tril2symm (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_truth (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_unite (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_veccats (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_vertcat (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_vertcat_empty (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_vertcat_simp (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_vertsplit (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_vertsplit_derivative (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'
test_vertsplit_simp (__main__.MXtests) ... skipped 'Ignoring memory_light tests (--ignore_memory_light)'

======================================================================
ERROR: test_MXConstant (__main__.MXtests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "mx.py", line 2014, in test_MXConstant
    self.checkarray(f.getOutput(),numpyop([x1_,x2_]),str([sp,sp2,v1,v2,name]))
  File "mx.py", line 132, in <lambda>
    self.matrixbinarypool.append(lambda a: mul(a[0],a[1].T),lambda a: dot(a[0],a[1].T),"mul(Matrix,Matrix.T)")
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

======================================================================
ERROR: test_MX_shapes (__main__.MXtests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "mx.py", line 1955, in test_MX_shapes
    self.checkarray(f.getOutput(),numpyop([x1_,x2_]),str([sp,sp2,v1,v2,x1_,x2_,name]))
  File "mx.py", line 132, in <lambda>
    self.matrixbinarypool.append(lambda a: mul(a[0],a[1].T),lambda a: dot(a[0],a[1].T),"mul(Matrix,Matrix.T)")
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

----------------------------------------------------------------------
Ran 102 tests in 21.498s

FAILED (errors=2, skipped=100)

==============================
19. nlp.py
20. vectortools.py
21. function.py
22. lpsolver.py
23. ad.py
24. socpsolver.py
25. sx.py
26. mx_jacobian_sparsity.py
Ran 26 tests, 2 fails.
make: *** [unittests_py] Error 1

```


Do you think this is the reason my custom datatype doesn't register as sniffable? mdshw5/sra-tools-galaxy#1


nice


@bors: retry


Make them public because we put TreeNode in different package.


saw approval from jdm
at https://github.com/mbrubeck/servo/commit/791fa3757dd11b53c9ef7ef112f460675eddea17


merging mbrubeck/servo/focus = 791fa375 into auto


mbrubeck/servo/focus = 791fa375 merged ok, testing candidate = a7f5cb78


Diffs found in 1 browser(s): Chrome

Chrome

![http://visualdiff.ngrok.com/api/diff/undefined/undefined/Chrome/elements.700px.png](http://visualdiff.ngrok.com/api/diff/undefined/undefined/Chrome/elements.700px.png)
![http://visualdiff.ngrok.com/api/diff/undefined/undefined/Chrome/elements.button.700px.baseline.png](http://visualdiff.ngrok.com/api/diff/undefined/undefined/Chrome/elements.button.700px.baseline.png)


mbrubeck/servo/focus = 791fa375 merged ok, testing candidate = b63fb0c0


test


Yes, those are the built-in functions I'm referring to. It's obviously not a drop-in replacement, so the issue that I filed is that someone just needs to spend an hour (or four) cleaning it all up.


I am fixing the hashing problem


Il ne faut pas penser "globalité" dans les taux de loot, mais "group" (puisque deux sont choisit aléatoirement)


Commit passed on AppVeyor
https://ci.appveyor.com/project/Ahsome/guards-of-aetheria/build/1.0.24


Put this declaration in amqp_private.h


DO NOT PICK THIS


Ok, I have deduced that these must be Mobility, PawnStructure, PassedPawns, Space, and KingSafety because of the values. I don't really understand.  I will have to look at that guide again.


oh oops my bad :) cheers!


**added** is correct not add


Is there a problem with my branch?


**landing** is correct no **laning**


赞，很佩服有细心，耐心和能力翻译完这篇文章。


Not to smile at your pain Kevin, but I find the commit name hilarious.

I'll see if I can update the Volley library and have it up in the next half hour.


Perhaps this should take an optional `int priority` to avoid conflicts with things like InterfaceGl? For example, in the NormalMapping sample if you connect the MayaCamUI before creating the InterfaceGl then the tweak bar won't ever receive events.  Arguably, InterfaceGl should also take an optional int priority.


Why? I have sen this commited so many times. Also thanks for all your hard work! I was working to get charge level control ported over to OPO til i seen you did it already. All your work is appreciated!


Possibly. I'm not sure.


que bonito!


Excellent organization of my initial mess of code, thanks for that! This will help me when attempting the new dimensions to make everything more explicit and helpful to the reader.

I'll give this code a test when I get home, especially to see the color property in action. Everything looks good from my phone, go ahead and merge when you're ready.


That UI update handler was a liability. Instead of holding a reference to parent, I moved it to a static class that receives the parent as a parameter and handles its lifecycle internally.


Was this intentional? I kept this on because it copies the settings file from the project into the bin directory.


Aww, yes, moved it down there without adapting...


A more reliable way of merging defaults would be to eliminate this `if` statement and instead just do:
```php
$settings += system_menu_default_config();
```

That will set all defaults if the array is empty, or if the array only *partially* exists, it will fill in all the missing keys. If we add new options in the future, that will save us from needing an update hook to merge in the new additional defaults.


It should return NULL here (return type is a pointer)


Just curious, why do you call the kernel flags MODFLAGS? Many devs use the term MODFLAGS for "module flags". It might/could prevent mix ups later on


I'm not sure about this fake $form_state and form callback. It seems like this could cause confusion in the future when a developer is modifying `system_menu_configure_form()` and expecting $form_state to work as it would normally, but instead is being given this imitation of $form_state instead. I think it would be preferable to just pass $settings directly and document that `system_menu_configure_form()` returns a form fragment, not the entire form.


`.RData` in `.Rhistory` tudi ne sodita na repozitorij, tako da ju pobrišite in dajte ustrezni vrstici v `.gitignore` (glejte #2).


may try block this in case of an error.


Iraqi Dinar Revaluation will officially take place in the second quarter of 2016 as was announced by cbi and Iraqi Cabinet october 2014. The denominations will be half IQD, 1 IQD, 5 IQD, 10 IQD, 25 IQD, 50 IQD and 100 IQD. the 50 Dinar was deleted by CBI last March.
For more information and news updates about Iraqi Dinar rv and New Denominations, visit
www.buynewdinar.com


Îf it should stay uppercase a underscore is required I think.
I kinda liked the old style more, but it should be unified as there were some storages not starting with a capital letter etc.


After some Googling (wikipedia)
the flag is : Robert'); DROP TABLE students;--


Yeah :/


Cursor position?


How/why does this fix anything? The NTP clock values in the RTCP packets should be completely irrelevant as long as they are consistent. And without this property it's always going to use the system time, which should be consistent for a single sender.

It feels like this only hides the actual problem :smile:

Is the system clock completely inaccurate on iOS, or jumping around instead of being monotonous? System clock as retrieved by gettimeofday() that is.

The us case for this property is to be able to select that actual clock that is used for the NTP times, which allows you to sync multiple streams from different senders together on a receiver (if they all use the same clock).

I think this will also *break* multi-stream sync currently if e.g. the audio part of the pipeline uses the audio capture clock and the video part uses the system clock (not much of a problem anymore once https://github.com/EricssonResearch/openwebrtc/issues/240 is implemented, then all pipelines will unconditionally use the system clock)


Thanks @Cl3Kener, I will try upgrade my ubuntu to test your build.


Is more smooth. :p it seems that the tests went on opinion and gave Hehe.


this was only reverted on the master, not your `pussy_feature` branch.


The only thing that this property does is that it will send GstRTPPacketLost events downstream from the jitterbuffer, so that downstream elements can be notified about lost packets.

Currently the only thing that would happen here is that rtpbasedepayload will convert those events into GAP events. And theoradepay for some reason is requesting new keyframes.

What are the GAP events fixing? It's of course a good idea to have them there, but OTOH it shouldn't make any difference for everything that Owr does.


What IRC? Can I join?


a review execution


Leftover debug output


Why is this line indicated as a change?  Might need to check these changes were made against the latest?


Why do you only store the latest pair? The request-pt-map can in theory be called at any time, maybe asking for a different session id. Might be better to just allocate some memory for this, and use g_signal_connect_data() to be able to provide something to free it again later.


just since I am not that familiar with flexget codebase yet. The only line that could fail here in my eyes is line 52, would it be appropriate for the try to only be around this one line, that way entry is usable even if it fails?


Hmm.... I think it's just ImgData*
That's ok.
When it crashes I'll figure out which one to use. :P


Apart from that this is definitely a good idea :smile:

What happened to get into problems with this? And why was the request-pt-map handler on rtpbin not enough?


Soga. Hai hai. :D


Wait what? Where?


Não deveria ser "register", ao invez de "cadastre"?


No "gestor cadastre" e "gestor cadastre with CNPJ already in use", no passo "Then", acho que você precisa especificar o CNPJ que se deseja verificar se foi guardado no sistema, para ser específico e testável (Nos slides, um exemplo de guardar uma duplicata especifica o nome do arquivo). Caso contrário poderia ser qualquer conta.


посмотри как ведёт себя логотип на ipad3/4 в эмуляторе в Хроме


I realize my original example used these names, but name that conform to the existing style should be used, maybe `sigs2dlist` for the module (its similar to `processlist`)


Same thing, use a name that matches the name style used, maybe `verify2dlist`.


No "gestor cadastre with CNPJ already in use", o "Then" indica que não há conta no sistema, mas no "Given" do cenário, você especifica que já existia uma conta. Têm que dizer que não há duas contas com o mesmo CNPJ, não que não há nenhuma conta com o CNPJ.


``` <div class="app-download__appeal">Взгляните<br class="app-download__appeal--no-mobile"> на жизнь<br> иначе!</div>```
as_04.04 Бр на спан, что-бы работало в Хроме. Класс оставь, просто поеняй свойство (margin).


Again, similar name.  Maybe `test_sigsIn2DList`


O "Given" do "gestor cadastre with Phone number field not containing only numbers" não deveria ser um estado? Achava que intuito e objetivo ficava só no Feature só para indicar o que o conjunto de cenarios deveria fazer.


ok


Without these changes, Scaloid will have errors.


remove this line, the specific error, if needed can be added later.


Well, I agree it might become confusing, but as it was just a test I let it be a bit untidy.


Cenários como o "Some of the registration data fields are not filled correctly or are blank" precisam ter especificações do que foi escrito errado, por que assim mais tarde pode ser testado automaticamente pelo programa. Isso vale mesmo se o cenário for GUI. Alguns dos outros cenarios tem o mesmo problema.


lol SINK&DIE
Yes. Power on and power off are to power the sub on and off.
There is a set_target_speed() function also, so I supposed Controller could just call set_target_speed(0) if we want to stop moving forward?


Me too man :)


No cenario "The registration data changes results in an existing residue generator", acredito que não precisa especificar que o programa roda um algoritmo pra checar se há duplicata. Você deveria avisar, no "Given", que existe um gerador com os atributos especificados, e então indicar que você iria modificar um novo para ter os mesmos atributos no "When".


No "Residue generator registration data edit fail", não acho que se usa ações que não fazem nada, como o "the system should not change screens". Simplesmente por "I am at the 'residue generator data edit' screen", que indica que você não vai mudar de tela.


It is a pain, but I think I nearly have it up. It should be good in ~ 10 minutes


wasn't part of the changes, should add `from __future__ import print_function` since `print` is used in this module.


@stephywells, do you think this makes scale fields look better? I definitely prefer how scale fields look with this commit, but let me know if you have any complaints about it.


I think the way around this is to use composer/autoload in a more correct fashion, but this is the first way I could get the tests to pass on travis, and also how I was getting them to pass locally, so it seemed correct enough.


MarkdownDocs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1173 of 1173 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.82%25-green.svg)


you likely want to maintain the original authors whitespace preference.


Also, on that note, are your star fields cut off at all?


all tests pass:
success: http://build.servo.org/builders/linux1/builds/1290
success: http://build.servo.org/builders/linux2/builds/1288
success: http://build.servo.org/builders/android/builds/1323
success: http://build.servo.org/builders/mac1/builds/1503
success: http://build.servo.org/builders/mac2/builds/1506
success: http://build.servo.org/builders/gonk/builds/468


also you should prefer non prototype extension in addons

`function() { }.property` -> `Ember.comptued(..., function() {})`


fast-forwarding master to auto = b63fb0c0


you'll need to call super

```
this._super.apply(this, arguments);
```


```
this._super.apply(this, arguments);
```


> bypass coupling and no cohesion after implementing this.

could you elaborate?


This commit is wrong, I wonder why we are even using RGB.control() - this should be a system LED color. (RGB.control is user-space setting of the LED.)


Я бы так не стал писать. Это известный фокус для целых чисел, но никакой практической пользы в нем, мне кажется, нет.


Les match 1vs1 et les match 2vs1 sont pas autorisés ?


Can you link me to the commit please? :-)


:cake:


You say you're using the 4.5 MSET expoit but that's just the arm11 user entry point. Might I ask which arm9 exploit scenario you are using?
examples:
p3ds (VerifyRsaSha256) https://github.com/Relys/3DS_Multi_Decryptor/tree/master/src
bootstrap (firmlaunchHax) https://github.com/shinyquagsire23/bootstrap/tree/arm9-kernel
or something else?
Thanks!


add some words


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.154](http://teamcity.monogame.net/viewLog.html?buildId=6039&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 474, ignored: 6 Build time: 00:11:52
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.Visual.GraphicsDeviceTest.VertexTextureVisualTest: <no details avaliable>

```


Deadlocks? That sounds like a bug.
Can you elaborate or provide a small test case?
Thanks


Засчитано, но это не совсем то, что имелось в виду. Тут лучше написать не отдельный шаблон для list, отдельный для vector а один шаблон для всех контейнеров. Если напишете такой, пришлите пожалуйста. Это на самом деле будет даже проще, чем писать шаблон для конкретного контейнера.


ah ouais, putain j'avais les yeux en face des trous.


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/3595/console to remedy the problem.


I can confirm this happens.


Doesn't that remove the SIGHUP signal that is supposed to reload the daemon?

I like the -c -l short args.

You removed the usage=%prog and %default in help. The proper way to have a message with argparse is to use %(prog)s and %(default)s.


Hehe


C'est pas forcément les mêmes règles, a voir comment on édit ça du coup ?
Le dim. 5 avr. 2015 à 12:03, Loïc Goyet <notifications@github.com> a écrit :

> Les match 1vs1 et les match 2vs1 sont pas autorisés ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AppVentus/foosball/commit/39024f0c5ef450ba86b4877bdfb90ad7a09f9662#commitcomment-10576606>
> .
>


You should actually to `"AR".length()`. The compiler will probably optimize that into `2`.


Good catch for the loglevel variable name typo.


This method is missing `public` at the start of the line.


This breaks the manual here. I mean with man. See the README about how to generate it.


Sorry for that,

the whole docmaker part was first designed to be an individual plugin which would be installed over npm install, so it wouldn't have been part of the source anyway.
I decided to put it into the gruntfile right before we ended friday. For the future I'll make sure to properly name my variables and comment difficult parts.


For this method to be overrideable you need it to be `protected` or `public` right?


I cannot find this hack in the "Enable HW hack" configuration menu and neither in the gsdx.ini...where is it? (Windows 8.1)


A utility method of this kind should be `public` not private. Private is not reachable for overriding in sub classes right?


Gosh everyting is `private`!
TO MUCH PRIVATE!!!!!


@AJDev77 Aw, yeah. Travis builds


You could also use `Collections.singletonList("1")`.


The ConfigParser simplification will prevent to reload the configuration files without killing the daemon.
Please try to avoid renaming function next time. Or at least use names close to existing ones.
For example, you renamed EyeFiConfig.get into get_key, while there is a getboolean without _.
Also, there is a space/tabulation mixup which is really bad in python.


Should be private now


Why isn't this exception propagated to the calller? .. now, if something goes wrong, the caller will have no idea ..


I only added a menu item for linux :) You can edit gsdx.ini file manualy to add it


Same comment as earlier, if an error condition happens, an exception must be thrown out. Check in all places similar! ..


What is the exact text that I have to add?


wtf


These comments look outdated.


Change to `protected`.


This can be done with "SimpleDateFormat" class in the JDK, no need to have custom code.


somewhere in your recent updates you have broken ``-DselfMode``.
```
Exception from controller.runGame: magic.model.player.HumanPlayer cannot be cast to magic.model.player.AiPlayer
java.lang.ClassCastException: magic.model.player.HumanPlayer cannot be cast to magic.model.player.AiPlayer
	at magic.model.MagicPlayer.getAiProfile(MagicPlayer.java:811)
	at magic.ui.SwingGameController.getArtificialNextEventChoiceResults(SwingGameController.java:590)
	at magic.ui.SwingGameController.executeNextEventWithChoices(SwingGameController.java:610)
	at magic.ui.SwingGameController.executeNextEvent(SwingGameController.java:740)
	at magic.ui.SwingGameController.executeNextEventOrPhase(SwingGameController.java:728)
	at magic.ui.SwingGameController.runGame(SwingGameController.java:672)
	at magic.ui.duel.DuelPanel$2$1.run(DuelPanel.java:131)
```


since there is a naming strategy, I will probably revert it in 2.4.1 and update the documentation, to warn about 2.4.0..


I was also thinking that this method /could/ be calling a similar static utility method that takes a List<String> and a String as parameters and then returns a list keeping only the elements starting with ignore case.


Not sure if your fix is appropriate though, compiled your branch and reproduced the test. Here's what i get:
```
(ErleRobotics)root@localhost:/home/ubuntu# ps -Leo class,rtprio,wchan,comm | grep ArduCopter
FF      12 -      ArduCopter.elf
```

@lucasdemarchi thoughts?


Тут я бы написал auto v = ...


I meant "add gps libs".. Sorry.


I suggest that you avoid raw arrays. You should use `Arrays.asList` for this purpose.


Same thing here. Use `Arrays.asList`.


Space missing after `for`.


Also to much arrays. Use `Arrays.asList` please :smile_cat:


Раз уж вы пишете шаблоны, немного лучше, видимо, шаблон с 2 параметрами

    template <class T, class Func>
     void ForEach(Tree<T> *t, Func f);

   Во первых немного эффективнее, и , во вторых, тогда можно вызвать и для любых функторов (обьектов с определенным оператором () ). НУ и в треьих короче писать)


> just for polygons right now: does that seem okay?

Not sure about this. Can we safely assume that there can be no real-world triangle polygons in the data? Probably not, so it may prune valid features. Triangles can also be used in real-world datasets, e.g. trizilla weather stuff.


That's clever.


comments for testing


Вот тут неправильно. Правильно
  template <typename T1>
  friend void ForEach(Tree<T1> * t и т.д.

Иначе С++ не понимает, что речь идет о внешнем шаблоне (как именно он понимает то, что у вас написано, я честно говоря затрудняюсь сказать :( ) Наверное, как специализацию шаблона. Но точно неправильно (


Тут еще нужен пример - увеличение числа в k раз (где k вводится). Допишите, пожалуйста.


Do you know why I don't get the longpress option switch if I try to add this? I had the same issue on 5.0 and then it randomly started working out of nowhere. There has to be a reason tho and now on 5.1 I can't get that back. I noticed it calls actionlistview for the fragment, my pie second layer button also isn't showing up but all my utils, actions etc are the same. ANY input would be greatly appreciated as it's driving me crazy


And bump README version to 1.6.6 for next Ransack release.


经过测试，该方法正确


This won't work.


Why did you do those renamings rather than include the right ChibiOS header file if some macro was defined, as is done for Linux STDC versions?


I edited it all "8" to "7" for it to read

200004102555

Barcode: 41
Price 2.55


Ты намеренно не сохраняешь параметры расчёта (лимит итераций, точности)?


Thank you!


Wouldn't it be better with a full javascript solution?


Well caught!
Actually, this line here is also a buffer-overflow before your changes.  As it looks now  this line gets chopped off.  You need to make the buffer to: buf[60]


r+


Thanks for catching this. Looking into it.

On 18:19, Sun, 5 Apr 2015 lodici <notifications@github.com> wrote:

> somewhere in your recent updates you have broken -DselfMode.
>
> Exception from controller.runGame: magic.model.player.HumanPlayer cannot be cast to magic.model.player.AiPlayer
> java.lang.ClassCastException: magic.model.player.HumanPlayer cannot be cast to magic.model.player.AiPlayer
>     at magic.model.MagicPlayer.getAiProfile(MagicPlayer.java:811)
>     at magic.ui.SwingGameController.getArtificialNextEventChoiceResults(SwingGameController.java:590)
>     at magic.ui.SwingGameController.executeNextEventWithChoices(SwingGameController.java:610)
>     at magic.ui.SwingGameController.executeNextEvent(SwingGameController.java:740)
>     at magic.ui.SwingGameController.executeNextEventOrPhase(SwingGameController.java:728)
>     at magic.ui.SwingGameController.runGame(SwingGameController.java:672)
>     at magic.ui.duel.DuelPanel$2$1.run(DuelPanel.java:131)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/magarena/magarena/commit/149cafbda7c3ab076088c3394012d659212696dd#commitcomment-10576654>
> .
>


@MennaDarwish Use single quotations instead of double quotations


saw approval from saneyuki
at https://github.com/nmzaheer/servo/commit/c37a34234a840d5118146f64d6ed644ddcc97329


merging nmzaheer/servo/updateSpecLinks = c37a3423 into auto


nmzaheer/servo/updateSpecLinks = c37a3423 merged ok, testing candidate = 425b2be0


Will be nice to have a dynamic Core count - 1


this commit will for 99,9% break the build, I will upload a fix soon.


The last item missing "RECENTS_CLEAR_ALL_DISMISS_ALL" as follows:-

https://github.com/temasek/android_frameworks_base/commit/fb36cc5075f9bb876859dd7d9476536e26c839ae


@MennaDarwish Whenever declaring variables, use lowerCamelCase. Kindly change lines 13 and 14.


can't sleep n00bs will own me


Contains quite a few sane default jQuery UI styles (like for the autocomplete widget). Will these be put back or what is the plan?


Thanks :)


Духовные искания Пьера Безухова :)


**[!]** That commit cause a crash near the signs_lib : http://pastie.org/10074694


@MennaDarwish Method chaining should be done in one method per line, while indenting said methods. Kindly change lines 7, 8 and 58. No trailing white space, delete all the white space e.g line 55. Also, there should only be no more than 80 characters per line, kindly change line 61.


That's a nice library you're using there.


Knight.

This looks perfect and makes thints more efficient and the right thing to do.

I've got some major things to sort out at home at the moment so will try this and continue on the same lines with things when there sorted.


In cm-12.1, there isn't "taskBarEnterAnimDuration" defined anymore. As such this commit will fail. I will have to temp remove this animation.

"taskBarEnterAnimDuration" is supposed to be defined in packages/SystemUI/src/com/android/systemui/recents/RecentsConfiguration.java


@joergoster Just starting by implementing MB's idea as-is. Otherwise when it doesn't pass, the originator can say "well you didn't try /my/ idea…" :)


@salmamali Use single quotations instead of double quotations. Kindly change line 3 in clicks.js.


@maikany :*


basic code


@MohamedMarwan There should be no trailing white space as in lines 2 and 3.


@dpgeorge , FYI. I actually had this running for a while on my NAS to show HDD activity, finally pushed to lib.


@MohamedMarwan Each line should be no more than 80 characters, e.g line 21. Kindly chain these methods.


Foi intencional sim, porque no código atual essa string não é usada como regex, então não tem problema o hífen.


@MohamedMarwan Whenever declaring a variable, use lowerCamelCase, kindly change line 6.


I'm not entirely sure what happened. I was working on this extension yesterday, and noticed that if I used the meta api first, then produced a couple of messages without calling rd_kafka_destroy inbetween produce calls, the script would hang. I did not debug this properly, but for now, setting the timeout to a couple of ms seemed to work. I'll examine this issue further when I'm not hung over, though, it's probably a mistake in my code.

Either way, I'll let you know if I know more. Thanks for taking an interest, hope I can contribute something substantial to librdkafka in due time


@MohamedMarwan No trailing white space, e.g line 2.


I agree.. if it fails then re-test as simplification. If it fails yellow you could probably justify going straight to LTC as simplification.


no matter how u smart once i will catch you


first comment


@MohamedMarwan Use single quotations instead of double quotations, kindly change line 3.


@MohamedMarwan Use single quotations instead of double quotations, kindly change line 4.


@MohamedMarwan Use single quotations instead of double quotations.


test comment


---Start---
this part is required
---


@bors: retry


---
this part is required
---End---


Could you not add the license after the version?


FWIW, `undisclosed-recipients:;` is not a bad email address, it's a *group* address as defined by the specifications (see rfc822).


This is a comment


Starting with this commit, I am unable to use nixpkgs for installing any packages. The error:

    error: attribute ‘interpreterName’ missing, at "nixpkgs/pkgs/development/web/nodejs/build-node-package.nix":7:16


Да, могу их тоже сохранять, если надо. Просто я подумал, что параметры солвера особой ценности не представляют.


Where is this used? Consider using css to truncate the texts because it is more of an artistic decision (skin) than part of every schulcms installation.


Merge dev and Master


You're missing initial font-size setup on `html` element. From http://snook.ca/archives/html_and_css/font-size-with-rem:

    html { font-size: 62.5%; }
    body { font-size: 1.4rem; } /* =14px */
    h1   { font-size: 2.4rem; } /* =24px */

In this case, it's easier to convert px to rem since 10px = 1rem


Accidental copy+paste fail


> Somewhat belatedly sorry, but this is now committed in bzr -r642, complete with a unit-test

thanks

Any hints on how [this one](https://bugs.launchpad.net/libvterm/+bug/1438311) can be fixed? I'd like to give it a shot but its not clear to me whats the best path to take. My first idea was to push/pop scrollback lines from/to the main screen buffer when the alternate screen is resized.


a class “truncate with “ellipsis”? overflow hidden, text-overflow ellipsis and a max-height?
and use this class for “appointment” too?


I can maintain for hammerhead


You set `this.extent` from the return of `checkNotNull` but didn't for `this.position`


Did the testing and commit on a new machine ....


UserHacks_stretch_sprite = 1


А это не то же самое, что и clear()?


:+1:
The second call to current_branch is not really needed, is it?