Ha ennyire fontos neked egy ilyen fájl, miért nem töltöd le, s teszed be a test resources-ba.
Ez egy olyan tesztet eredményez mely külső tényezőktől függ. Mi van ha a szerverről eltűnik a log...


I was wondering about this. For example, if it's an image, will this include copyright information? Photographer or artist info?


I think he's already okay to share the source with us as he posted it on paulscode.com, anyway I'll ask him then.


why not pass a timeout argument to d.Shutdown() ?


I considered not making it public but since everything else was public I followed the trend... maybe we should also rename it to `mono_error_assert` since it's shorter.


Test DB


We don't use curlies for single line if's and it's introducing unneeded changes.


Try:
```javascript
$scope.init = do ->
  DataFetcher.getCurrentUser()
```


bad variable name, this is not a timeout, this is just a wait-channel. I'd use `wait` or the generic `ch` whatever :)


This is not needed.


What flavour of Make is recommended for building on Win7 32 bit ?
Thanks.


Do we need this check given the one below?


can we make this behaviour optional like for example when a specific env var is set?
i deliberately made the dhclient wrapper react immediately unlike some distros where you have to wait ca 1 minute when you run dhclient and the dhcpserver has a problem

for example MODE=SLOW dhclient eth0


We don't need a cleanup call if no error happened.


Does making this part of the "Global Options" group prevent reuse of settings under "Application Options"?


I agree `rand(Char)` should only give valid code points.

@ScottPJones performance. For example utf-8 decoding needs to do integer arithmetic, and then cast the result to Char. Those Chars are valid by construction, so you don't want an extra check at that point. Yes we could have separate checked and unchecked conversions, but it just felt like a hassle.


Can mono_metadata_parse_type_internal return NULL and not set MonoError?


Can mono_metadata_parse_generic_inst return NULL and not set an error?


Can mono_metadata_parse_type_internal return NULL and not set an error?


Nice, we have all links to see company details


TeamCity DPCFLib :: BuildAndTest [Build 2](http://46.101.150.79:8111/viewLog.html?buildId=8&buildTypeId=DPCFLib_BuildAndTest&guest=1) is now running


Why this assert at all? All code paths should check for errors right after the call that could set it.


TeamCity DPCFLib :: BuildAndTest [Build 2](http://46.101.150.79:8111/viewLog.html?buildId=8&buildTypeId=DPCFLib_BuildAndTest&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner; NUnit runner failure (new) Build time: 00:00:17


Prefer the C-style comment, please revert.


Nu e acelasi. Stiu ca nu trebuie sa fac economie de litere dar uitat sa modific. Am adaugat indexul de la inceput dupa asta.


We had to change it from first to last as the companies are now sorted in descending order


This assert should be in the callee.


Again revert, this leaves easy room for expansion.


No need to cleanup in the success path.


Looks good :+1:


this seems a bit ugly, and doesnt solve the problem:
wpa_client blocks on execution of the connect_action script.
imo the right thing to do is to launch a wpa_connect_dhcp script detached
```sh
wpa_connect_action_dhcp.sh &
```
that script can then enter a sleep/dhclient loop until dhclient succeeds


FYI, thought you might like to know that I've added the ability to set the default font. Details here: https://github.com/richie5um/TextBar-Recipes#preferences


> objects objects


TeamCity DPCFLib :: BuildAndTest [Build 3](http://46.101.150.79:8111/viewLog.html?buildId=10&buildTypeId=DPCFLib_BuildAndTest&guest=1) is now running


@romuloctba Tem um meio de contato (skype se possível) para conversarmos?


I was about to fork to add this.  I see you've also put in a pull request.


TeamCity DPCFLib :: BuildAndTest [Build 3](http://46.101.150.79:8111/viewLog.html?buildId=10&buildTypeId=DPCFLib_BuildAndTest&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner; NUnit runner failure Build time: 00:00:15


would use `team.addMember("Melanie")` instead.


Podmień na link do gita :D


Great definition for a re-usable object


Is this a debug that needs to be removed?


This function was not converted correctly, there are a lot of return NULL paths that don't set the error.


This looks like duplication - but there is not much else we can do here because this is just test data. Normally we might get our data from an API. So good work


This looks wrong.


e derutant dacă ai un parametru care se cheamă la fel ca un field din clasă, e bine să eviți. Oricum, field-ul `index` nu mi se pare bine numit.


@secrettriangle, everything seems to be fixed now, but, as I suspected, the combining character is still an issue. It could be that there is no font with that glyph, so it can't combine/overlap, but in that case it shouldn't display a glyph at all since it is giving a 0-width character a width of 1.

![osx-screen-2](https://cloud.githubusercontent.com/assets/470564/7355586/b80f4502-ecd7-11e4-8c3f-0361fabe6e9d.png)


przydałoby się zrobić pakiet "org.kudlaty9102.converters"


Thanks!  It's good to be all caught up.


Great use of jquery throughout your code. Nice and clean


Good organization


yup like this


The majority of the mono-error API live in mono-error-internals.h. ;)


TeamCity DPCFLib :: BuildAndTest [Build 4](http://46.101.150.79:8111/viewLog.html?buildId=12&buildTypeId=DPCFLib_BuildAndTest&guest=1) is now running


thank you Lane! Glad to hear write works!!


@JeffBezanson I'm all for performance, but not necessarily at getting the semantics inconsistent.
'\U1fffff' -> '\U1fffff', but "\U1fffff" gives: ERROR: syntax: invalid escape sequence.
I'd really like some randomization function that could actually use some sort of table of probabilities, based on language, type of text, whatever... (i.e. first run something over a corpus of text that you want to match,
and generate a table, and then have a rand(Char,table) that would give out valid codepoints in frequencies similar to the table...)  Probably something you numbers guys do rather easily!


Madem yorum arasına alacaksın dosyadan sil, dosyan temiz görünsün.


mono-error.h is the subset required by consumers to deal with functions that set it.


Fonksiyon parametre almıyorsa `void` yazıyoruz parantez içine!


Ma gandeam sa fie ceva de genul index curent pentru care adaug elemente si pe care il returnez sa-mi dea nr de elemente. Acum mi-am dat seama ca ar fi trebuit la Count sa returnez index+1


Buraları da silip göndersen daha iyi.


TeamCity DPCFLib :: BuildAndTest [Build 4](http://46.101.150.79:8111/viewLog.html?buildId=12&buildTypeId=DPCFLib_BuildAndTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 27, ignored: 1 Build time: 00:01:21


Soccommit!!! :+1:


You know, I'm getting so bogged down in design matters that I think I'm going to scrap TapeDeck and just implement a Forth system in VB6 (I don't think it's been done before). It's simple, it's easy to make fast and it's easy to adapt.


TeamCity DPCFLib :: BuildAndTest [Build 5](http://46.101.150.79:8111/viewLog.html?buildId=15&buildTypeId=DPCFLib_BuildAndTest&guest=1) is now running


xstatus öylesine bir değişken. İçine bilinçli olarak bir değer de vermemişsin, çöp değer var. Ekrana yazdırınca ne gibi bir bilgi ediniyoruz?


this looks OK.


<!DOCTYPE html>
<html>
<head>
	<meta charset=utf-8 />
	<title></title>
	<link rel="stylesheet" type="text/css" media="screen" href=".css" />
	<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js"></script>
	<!--[if IE]>
		<script src="http://xx.proffac.js"></script>
	<![endif]-->
</head>
<body>

</body>
</html>


Önce `WIFEXITED()` sonra `WEXITSTATUS()`. Ayrıca pointer alıyor, adresini vermezsen `xstatus` değişkenini nasıl değiştirsin??


remove extra whitespace


zamiast void można zwracac obiekt zawierający liczbę i jednostkę na przyklad:

```javascript
{
  unit: FAHRENHEIT, //to jedna z wartości enuma -> CELSIUS, FAHRENHEIT
  value: 103.4
}
```


TeamCity DPCFLib :: BuildAndTest [Build 5](http://46.101.150.79:8111/viewLog.html?buildId=15&buildTypeId=DPCFLib_BuildAndTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 27, ignored: 1 Build time: 00:01:10


Hey @raykamp , here's the relevant [documentation](http://nodered.org/docs/creating-nodes/node-html.html):

> The type is also used as the label for the node in the palette. If the type ends with “ in” or “ out” this is stripped off label. For example, the “mqtt in” and “mqtt out” nodes are both labelled as “mqtt”, with the display of the input and output ports providing the “in” or “out” context.

Note that the documentation specifies the suffixes [`<space>in`](https://github.com/node-red/node-red/blob/master/nodes/core/io/10-mqtt.html#L39) and [`<space>out`](https://github.com/node-red/node-red/blob/master/nodes/core/io/10-mqtt.html#L96), however a number of examples I've seen use [`-input`](https://github.com/node-red/node-red-nodes/blob/master/social/irc/91-irc.html#L90) and [`-output`](https://github.com/node-red/node-red-nodes/blob/master/social/irc/91-irc.html#L155) instead.

While it looks like both conventions are supported, I'll change it to `<space>in` and `<space>out` to match the documentation.


Sout w tym miejscu raczej nie pasuje. Metoda licząca coś od razu przywodzi na myśl, że zwraca wartość liczbową.


nice!


ay ay ay, tekrar `waitpid()` çağırıyorsun!


This change seems outside of the scope of this PR?


I get an error for `'\U1fffff'`.


?? Madem boş, niye else var?


This change seems outside of the scope of this PR


Почему не создаётся PR в мастер?


@keul can you take a look at it?


e' una pagina web, che commit t'aspetti


Haha :D template z Mavena :D:D


Hmm
The Idea is good, but the implementation can be better.
With bash command
```
git config --get remote.origin.url
```
we can get the URL of the repository, you can go to this URL and github redirects to the right page.
With
```
git rev-parse --abbrev-ref HEAD
```
you can get the current branch.

Can you implement this or should I open a ticket?


@nieltg have u got hangouts? if yes give me your email
I have two logs to show you


`waitpid()` kullanımı yanlış, `WIFEXITED()` yanlış.


Huh? De ce?


Çocuk `x` ile çıkmalıydı.


Love the retro graphics. My favorite! Good work changing things around


@N-Pex Delegate methods generally should also include a reference to the sender:

```obj-c
@protocol SCRMediaFetcherDelegate <NSObject>
@optional
- (void) mediaFetcher:(SCRMediaFetcher*)mediaFetcher downloadStarted:(SCRMediaItem *)mediaItem;
- (void) mediaFetcher:(SCRMediaFetcher*)mediaFetcher downloadProgress:(SCRMediaItem *)mediaItem downloaded:(NSUInteger)bytes ofTotal:(NSUInteger)total;
- (void) mediaFetcher:(SCRMediaFetcher*)mediaFetcher downloadCompleted:(SCRMediaItem *)mediaItem withError:(NSError *)error;
@end
```


Nu cumva compilatorul dă un warning că parametrul se cheamă ca field-ul?


Yeah that's fine - we have one or two other special cases like this. As long as they're well documented like this one.


smaller_make_shared (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Ah, RPN.  Brings me back to my university days and HP graphing calculators.  ;)

In a funny twist, Postscript (whose fonts are implemented by OpenType) also uses RPN and a stack system.  So on the great map of programming tasks, we'll be in the same neighborhood.


Changed code to re-prompt whenever the player types an invalid response to a prompt.


I like having a second array for alreadyChosenPokemon. This means that we don't have to delete items from our data model (which is a good practice)


Good use of switch statement which we never covered in class


Added #449 to fix this. This bug should also affect other cards. Please re-test.


@N-Pex The delegate methods should be called on a completionQueue. Probably best to rename it to callbackQueue for clarity.


Çocuk sürecin `WIFEXITED()` ile normal şekilde kendi isteğiyle kapanıp kapanmadığını baksan daha iyi, çünkü belki de `sleep(3)` esnasında başka bir süreç öldürdü ve `exit(random)` yapamadı bile. O durumda `WEXITSTATUS()` ile öğrendiğin sayı 0-9 arasında bir şey olmamış olacak.


Bugger, there is actually a bug. Something which was already there, but I only noticed it now that you moved the code. We cannot reset the value handler in this code. The initialized validator is cached. This code is only executed the first time around, successive calls will look up the initialized validator from the cache.

I need to think about this for a bit...


high-leve=high-level


I am using 4 Languages now on my Webid page. Without this fix the language goes back to the default language once a link is clicked. This fix keeps it in the Language selected. Others have tried this fix and said it worked for them too.


`waitpid()` için ilgili başlık dosyasını include etmemişsin.


What's this do exactly?


`case`'lerin hemen altında değişken tanımlanamıyor C'de.


The first field is generic metadata type.  That they can name and a value to.  The second one determines how all the metadata are categorized and displayed.  See http://v820dw.axshare.com/#p=item_details_3  the description and transcription links on the left of the metadata section.


It's probably because it registers the loss of contact from the previous groundtile. This can be solved by declaring a variable that keeps track of the number of simultaneous contacts between the feet sensor and the groundtiles. Let's call it 'feetContacts' with a value of 0. So when the feet sensor collides with the first groundtile, set feetContacts to feetContacts + 1, i.e. 1. Then when the character moves slightly to the right and makes contact with yet another groundtile, add another 1 to feetContacts, which will now equal to 2, representing the character standing with each foot on a different tile. Finally, when the character moves a bit more to the right, as to lose contact with the first groundtile, subtract 1 from feetContacts which will now equal to 1 again. The setGrounded boolean should be set to true when feetContacts > 0, and false otherwise.


`\n` koy, TR karakter kullanma.


Jak dla mnie ok!


`srand()` nerede? Böyle mi üretiyorduk rasgele sayıları??


Nothing for sure maybe a link to google maps.  But I want to make sure we are collecting it if it is available because we can  do so much with it.


test

**hello**


I don't mind RPN at all, since OZ80 will be the high-level language and can worry about friendliness. I just need the simplest possible (ergo, fastest for VB6) virtual machine and Forth is about as simple and flexible as you get. I'm finding that -- having so little sleep and no solid time in which to tackle programming -- I'm getting bogged down going in circles over language design instead of making forward progress. OZ80 is 50% able to assemble Sonic 1 and I want to push through to that 100% as soon as possible before I go mad! :)


Note: `value` should really be `config`


thanks @zephiK


You'll notice gnome-terminal and urxvt have the combining glyph overlap on the S, which is the direction they're supposed to go. iTerm2 looks like it's going to the right _and_ taking up a cell.


i think strict comparison(i mean <=) would be more correct


Ödevin sadece kaynak dosyasını gönderin dediğim hâlde, Eclipse projesini ZIP'leyip, o ZIP'i de bir daha ZIP'leyerek gönderdiğin için 10 puanı baştan kırıyorum.


Exactly what it says, clean up to make the code nicer and more readable. No real functional changes.


Please keep pep8 changes outside of the feature pr.


Create a new file, using the iOS\Source\Objective-C File template. Call the file Bridging-Header, and click Create. You will then be asked whether you would like to configure an Objective-C bridging header. Choose Yes. Two new files will be added to your project:
MonkeyPinch-Bridging-Header.h
Bridging-Header.m


`curses` kitaplığına ihtiyaç yok burada.


Justin: are you sure that the assert needs 4instead of 12?
I am not sure... the K stiffness matrix for a tetahedron is 12x12 (yes, 4 nodes, but each with xyz, so 4x3..)
Alessandron


ping vypísať do súboru


Yes, I started with returning Key, but later I saw that some implementations in master already have `int[] getKeys()` and decided to switch.

Do You think that it should returns `Key[]`?


@alexsomeoddpilot should these be `$white` and `$black`? where could default colors be defined for this library?


here here here to that!!!


Eline sağlık Halil, sadece istenenleri yapmamış araştırmış, diğer özellikleri öğrenmiş, onları da kullanmışsın. Bu merakını ve ilgini diğer arkadaşlarına da aşılaman dileğiyle :)


Please release this - confirmed issue in Safari 8.04 in OS X 10.10.2


I think it is important here to have a comment with spec-suitable language that describes the behavior that is implemented, and also include that same text in a specification (compiler spec or C# language spec), perhaps with examples.


hayır, hayır, hayır! `waitpid()`nin olduğu başlığı include edeceksin yahu neden tekrar buraya yazıyorsun?


I'll talk to Pam about it, so it hopefully will get through to the official build in the next version :smile:  I'm already got ru_RU.lang through but I'm still updating it here since there are no official repository for Harvestcraft localization.


Good placement/organization of 'properties'. Too many 'web' developers write nasty javascript. This is cleaner and more in alignment with good programming practices.


Doğrudan `&status_val` diyebilirsin, 2. değişkene hiç gerek yok.


yukarı yazdığın kodu direk if'in içine yaz, `wifexited` değişkenine gerek yok.


merci


```LEFT JOIN "1".project_totals pt ON pt.project_id = p.id```


1. Thanks, I have found how I can use ``TLSSocket`` now.
2. Will you fix fifth argument of ``createSecurePair`` ?


ACID part:
http://paste2.org/BnhzdB47


I like that this is in JSON - this is how it would come down from an API. Also makes for good Unit tests when doing JSON tests (using test data)


Yeah, i know, i think I have at least 4 post on her MCF asking her to add the localization since settember, still no response


Beat you to it ;) hehe


Çocuk sürecin `WIFEXITED()` ile normal şekilde kendi isteğiyle kapanıp kapanmadığını baksan daha iyi, çünkü belki de `sleep(3)` esnasında başka bir süreç öldürdü ve `exit(random)` yapamadı bile. O durumda `WEXITSTATUS()` ile öğrendiğin sayı 0-9 arasında bir şey olmamış olacak.


The issue I was describing above, with `.jscsrc` always needing to be present, was just fixed by @westonruter in https://github.com/xwp/wp-dev-lib/commit/ae5d3c699d723ac8a64725e840fb17c9b2e45289. Tested and confirmed.


Issue does not show up with IsoApplet, but it is PKCS#15. Maybe the mentioned algo_refs are set by OpenSC automatically for cards without PKCS#15 emulation.


`waitpid()` için gerekli başlığı include etmiyorsun.


I'd say return Key[] or even List<Key> (immutable to prevent corruption)


This commit fixed the problem I was describing in https://github.com/xwp/wp-dev-lib/commit/d5426d43b8d66a092eafd6c425cbe529bfb0506c#commitcomment-10746833.


What you think about move the lunch service to journalactivity.py?
We have there the services to start the ObjectChooser, then we don't need start another service.


This assert appears in the else clause of its negated condition; please remove it.


what's the replacement for this script ?


`\n` koysan da düzgünce görsek çıktıyı.


`.flex-direction(column);`


but descr gets dereferenced in the next step, which is ```descr = &(*cp)->browseDescription;```, so in case cp is freed here (https://github.com/acplt/open62541/blob/7ed0e0436e37f428115c629b5c940355f86d57cb/src/server/ua_services_view.c#L243), there is a problem


Why do you return a bool here? You may be using the return value somewhere, but the function name 'score' is not very telling of why it should return something.


what's the rationale behind the filename changes ?


ah I see it just looks like things are different in terms of the code, but you say everything should be no different than what it is at the moment on my server? I haven't even installed your first update from yesterday afraid it might break things

FYI if you ever wanted to look into the possibility of changing the ban system identifiers they're to be done mostly in gs database and gs utils and obviously the admin page for a visual change.


Fix this reference to Linux too?


what's the replacement for this ?


@nathandunn  Good catch but the gwtc also implicitly calls copy-resources


@Podshot why was this done? why not put it into a directory like the schematic directory?


i see … you log in as you, then edit anybody’s files ???
or just add a comment???
---------------
> On Apr 27, 2015, at 11:07 AM, mi3kie <notifications@github.com> wrote:
>
> you have to be logged in to leave comments. i just left a comment. no pushing, no shoving.


sorry, hope this helps.
https://github.com/oe-alliance/enigma2-plugins/commit/62c90a485f9cc35abd30f0909a2dce19b6d3e4f3


Can you test move this?


This is a strange thing to say in a test without reference to a spec for what it is (or should be) actually doing. (We shouldn't be testing that we do things wrong)


Yea, @sankarravi makes a good point. Most dev shops are polyglot anyways, and since BB.js is really just a utility to turn CCDs into JSON, using with other environments is pretty simple.


I think that calling copy-resources should be fine.  I should be part of the build dependencies (instead of in a bash script).   I just don't want it calling it twice.

I realize that there are likely other bugs in here associated with #315, as well, but wanted to get the build fixed first.


Strange, I got fast response through PM and still have a good contact with her. I'll talk to her when she'll feel better. (She's caught a cold according to her twitter)


@JeffBezanson Oops, I meant Char(0x1fffff) gives '\U1fffff`, while typing `\U1fffff` gives the error


Ar fi trebuit sa setez items[count - 1] default(T) pentru el este ultimul
element din lista

On Mon, Apr 27, 2015 at 10:07 PM, Victor Grigoriu <notifications@github.com>
wrote:

> Oare? Care e ultimul element din listă? Dacă am, de exemplu, trei elemente
> în listă, cît va fi count și care vor fi indecșii elementelor?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/adrianaene/MyList/commit/1418e663e535d52852db395b11a2d00881fe0248#commitcomment-10923638>
> .
>


Added a unittest that breaks it in the latest commit.

https://stackoverflow.com/questions/4352244/python-implementing-ne-operator-based-on-eq

Noticed the problem here while testing: https://github.com/letsencrypt/lets-encrypt-preview/commit/95ba2730f1652d02d8a7c2ea4198cd16c3859d96#diff-031d03411f44cd3607f6eb409e67c05eR267


Încă nu e prea tîrziu :-)


`waitpid()` için gerekli başlığı include etmiyorsun.


Nit: add some context to this log statement?


Yeah, i read that too


Bu neyin nesi???


From the python documentation: https://docs.python.org/2/reference/datamodel.html#object.__ne__


l


It's displayed in the registry container. Not sure much else is needed. Right now it will say something like version=2.0.0


These were deleted because they were used for testing and to my knowledge, there are no licenses for these that allow us to re-distribute them, if these were created by someone other that the original BO2/BO3 creator


LGTM :+1:


If something breaks you can always fix it or roll back to a known good revision, you know.

And again, don't write stuff like suggestions in commit comments, it'll just get lost here. Put them in the relevant Issues. Also, I urge you to write a bit more proper if you can. It's sometimes hard to understand what information you're actually trying to convey.


FAAAAGGGGG


I think it would be good to have some comments explaining the difference between pull by ID and tags


I'd just use `return true;` here. If the GUI is disabled, there are no other ways to control qBittorrent.


this release hasn't been published on https://github.com/RangerMauve/jsonp-promise/releases yet


(Lynne Jones) If you look at the rest of the examples, they all plot their data at this point. So, it's not strictly necessary, but it's intended to remind the user why *this* example, in the midst of the others, does not call the plotting methods.


(Lynne Jones) Agreed.


I trust that what you've implemented is the intended behavior.


(Lynne Jones) Okay, this one I actually would prefer to keep or I want you(?) someone(?) to tell me how to run unit tests using the unittest.main with a higher level of verbosity. When I run the unit tests using the line above, I can see the feedback from each individual test, see what is running and how long it takes, see the doc string, see what's happening in what order, and finally, easily see which tests passed/failed. It doesn't seem like I see that much info when just running unittest.main(), which seems like what you have to do in order to use 'scons tests'.
I've been flipping back and forth if I need to debug something more precisely than just running the whole unit test set (plus, with the above, I can actually just run a subset of the unit tests).


(Lynne Jones) Yeah, I think I agree.


(Lynne Jones) It's okay -- we could just fix things here.


If we modify `isWebUiEnabled()` as I said in the other comment, this if can be removed.


Small note:
For npc 29000 I think you are missing some texts.
See here: http://www.wowhead.com/npc=29000/scarlet-commander-rodrick


@joshnuss I'm afraid the issue is still present. The `loadNextPage` method is triggered until the last page is loaded, regardless of the current scroll position.


Rewriting the extra compatibility check in runtime based on feedback from @Emgarten

I am following the logic here: https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Framework.Runtime/NuGet/Utility/VersionUtility.cs#L889

@davidfowl @anurse , please help to review


Why ?
IIRC, I initially wrote those statements on multi-line, but I then reformatted it as single line to improve readability.
This as nothing to do with SLOC, it is only about readability.
But now that you point at this code, I can't remember why I initially needed the breaks, but they are now useless !


Change Int to String in the docstring


https://github.com/chjj/blessed/commit/cb9ffee1e33a2641067203fac087c00b4d356f9b

should fix everything accept the combining char on iTerm2.


Just FYI, these comments don't show up in godoc.  You'd have to use different const blocks (but then iota won't work, without adding the previous constant).


@vr2262 Ok — there are two maps remaining in the mockups that I didn't finish implementing yet, one corresponding to the survey-specific submissions list and one on the survey data page for location questions. I'll work on them tomorrow.


(Lynne Jones) Feature/OPSIM-640 commit conversion tool and gen output
* updated sql commands to reflect new column names  in summary table.
(filtSkyBright -> filtSkyBrightness and five sigma -> fiveSigmaDepth).
* Updated 'output' to 'summary' in prep_opsim.py.
* Fixed table name.
* Fixed problems with exportSession related to summary table.
* Removed 'vertex' from data added to summary table.
Now hex dither pattern just adds ditheredRA/ditheredDec to summary table, rather than hexdithRA/hexdithDec/vertex.
* Moved v3_0-sqlite.sql into schema_tools.
* Commented out step to move modifySchema.sh ops* created outputs into a directory ../output.
Now the outputs of modifySchema.sh remain where the script was run from.
* Fixed prep_opsim.py query that was left incorrect in 'vertex' removal.
* Pointed createSQLite at proper version of v3_0.sqlite schema.
Also Cleanup empty lines.
* Replaced 'move' of output files  to ../output.


(Michael Reuter) This looks fine to me.


(Kem Cook) Feature/OPSIM-569 commit new default config files
* Updated config files.
* Adding more config files


(Michael Reuter) Feature/OPSIM-651 update version tag in main.py
Updated OPSIM_VERSION to 3.2


(Srinivasan Chandrasekharan) Bugfix/OPSIM-328 fix ra limit
OPSIM-328
Fixed RA absolute limits behavior for WeakLensing.


Great!


(Michael Reuter) Feature/SIM-908 write script for opsim documentation
* Adding first cut at script.
* Changing sync mechanism.


(Michael Reuter) Bugfix/SIM-1061 fix bug in getting rottelpos in
Reversing index lookup.


(Scott Daniel) good catch


(Michael Reuter) Bugfix/OPSIM-642 fix visitTime visitExpTime
Fixing the DB write and conversion tools.


(Lynne Jones) Please add comment why these lines are commented out  ... or just delete the extra code (maybe this is preferably after eups update and permanent fix of visitTime/visitExptime?)


(Michael Reuter) Bugfix/OPSIM-670 put hostname and username back
Adding code for getting hostname and username.


@oliverpool : Je ne comprends pas vraiment l'utilité de ce commit ; tu peux m'éclairer ? Ma remarque est peut-être prématurée : c'est peut-être du travail en cours…

- La variable `papersize` est [toujours définie](https://github.com/patacrep/patadata/commit/3586b3a974862e016df27e37a351f2f5751bcc1a#diff-98308f909596d6bcafff75a2c41c1da8L41), mais [ne sert plus à rien](https://github.com/patacrep/patadata/commit/3586b3a974862e016df27e37a351f2f5751bcc1a#diff-98308f909596d6bcafff75a2c41c1da8L99). Pourquoi l'avoir laissée ?
- Quel est le but de ces nouvelles variables ? Comptes-tu les utiliser dans patacrep, patanet, patagui, ou autre ? J'ai l'impression qu'il commence à y avoir beaucoup de variables, que pour définir du a4, on est obligé de définir toutes les dimensions du papier, au lieu de définir simplement `papersize=a4`. Est-ce qu'un nouveau template, propre à patacrep, patanet, patagui, (quel que soit le projet dans lequel tu comptes utiliser cela) ne serait pas plus pratique ?
- Enfin, principale question : Quel est le but de cette branche ?

-- Louis


missing space toccw-combined-prefs


Get rid of the id in the body tag. ;-)


LGTM.


Hrm, well, I can't get kread to work, and I think it's because of a bug in kwrite. So don't count the chickens yet.


Nevermind all the above.  Ran into (I think insurmountable) issues trying to redirect to a promotion page from the update page because we get there with an AJAX call.  I'm going to go for @johnellison's original thought of a front-end pop-up modal to select a queen.


The FITS standard for times says the should be in isot format:  YYYY-MM-DDTHH:MM:SS   if you use that time then some standard codes can get the time easier.   Likely you should use the keyword 'DATE' here instead of 'CREATED'.

from https://archive.stsci.edu/fits/fits_standard/node40.html#SECTION00942110000000000000


I'm getting following error after this commit: The service "culturefeed_udb3.event_export.uitpas_event_info" has a dependency on a non-existent service "culturefeed.uitpas"


A rather useless artificial difference between 2.3 and 3.0 and a senseless package splitting:

**packagegroup-base-smbfs**
can **only** handle **manually** created mounts, as it lacks smbclient, it's not even able to browse shares using the NetworkBrowser.

**packagegroup-base-smbfs-client**
is the **minimum** required to mount CIFS shares also via menu (network browser uses smbclient).

**packagegroup-base-smbfs-server**
can manually mount CIFS shares, but not even browse shares (smbclient missing).
The server is limited to the default "open for everybody and his grandma" config, you can't even add user accounts and set passwords (smbpasswd missing).

**packagegroup-base-smbfs-utils**
contains the tools missing for orderly browsing the network neighbourhood as a client and those missing in sambaserver for even the slightest user addition, but for a pure client it's still unneccessarily large.

A totally useless commit :-1:  just made to piss me off.
Any good distro will still add
packagegroup-base-smbfs-client+packagegroup-base-smbfs-server and packagegroup-base-smbfs-utils and thus not win a single byte.

Instead you could have split "samba" into server-utils (smbcontrol, smbstatus, testparm, eventlogadm, tdb* and pdb*) and client-utils (nmblookup, smbtree, ...).
For a proper rewrite of a network browser to work, nmblookup and smbtree are required even for simple clients.

This commit only doubles the work to maintain the useful changes in both 2.3 and 3.0.

Thanks!


Seems like the closure is not optional in the code, and cannot also be set to nil. Maybe change the docstring to remove the `if any` mention?


step | pass?
--- | ---
canary site online |  :white_check_mark:
authenticated with GitHub | :white_check_mark:
no carry over reviews |  ::white_check_mark:
created request |  :white_check_mark:
Uploaded pdf |  :fire:
Found issues in GitHub |  :fire:


I haven't tested it yet, but http://gnuwin32.sourceforge.net/packages/make.htm sounds like it'll be my first attempt.

I don't know if Érik or any of the ithers have tried sth. else.

Anyhow, if you run this succesfully or experience problems, we'd like to hear what you tried.


(Lynne Jones) I'd prefer this to be OPSIM_HOST and then add the following to the sims_operations.table file .. but we discussed this elsewhere and it's a change that'll happen after eups distrib branch gets done.


@N-Pex If download status was something stored in the database, we wouldn't need to update this in the background / store it in the appDelegate. It would also allow for the downloads view to show past downloads as well.


(Michael Reuter) Feature/OPSIM-673 update release notes
Updating release notes.
Changing release date.


(Michael Reuter) Feature/OPSIM-672 change version number
Changing version numbers.


(Michael Reuter) Feature/OPSIM-671 use opsim hostname env variable
Adding hostname override mechanism.


(Michael Reuter) Bugfix/OPSIM-674 conversion tool db connection fix
Reducing DB connections.
Removing try/except blocks for seeing real errors.


(Michael Reuter) This shouldn't change any conversion functionality except for reducing the number of DB connections.


@vr2262 Yeah, let's talk about this... is this method being used? My preference would be to remove this post method altogether, since it seems like it's GETting data, not POSTing.


(Lynne Jones) Okay - I know you don't want to double up changes, but instead of doing the 'except',  could you just let this fail with the actual error from the cursor? (i.e. remove the try/except).


(Lynne Jones) Same comment about the try/except.


instead of the name `closure`, I would rather see just `f` which is more usual. You could also please explain what the signature of `f` should be (e.g. `f` must be a zero-arity function, presumably with side-effects)


(Michael Reuter) Sure, I can remove the try/excepts.


i cant see any more... if u know tchem pls add'em ;) ... BTW .. pls add ..one above also :P


(Michael Reuter) Feature/OPSIM-636 capture git repo tag into config
Getting version from generated module.
Expanded size for version column in Session table for a bit of safety.


(Lynne Jones) So .. maybe this isn't an issue, but I see that if I'm running from a git version of maf, that '__version__' is 'unknown' .. 'fingerprint' on the other hand keeps the sha1 of the commit.
So maybe this could be import __version__ and import __fingerprint__ , then if __version__ is 'unknown', it uses the __fingerprint__?  (for people running from git).


In my opinion should be placed links for two states (received and pending). I guess it's important to access them independently.
The user's contacts should not be visible until space owner accepts driver booking, so we should restrict access to them. In this case, the two states would not be redundant.


(Michael Reuter) You see the unknown for the version since maf has no tags in git and that is what git describe --tags works off of. That's the command the version file generator runs.


this broke [component.json](https://github.com/then/promise/blob/079c8b985f89c43df97944f65ccdc5d0d0d8d5f7/component.json) because of the move from `./lib` to `./src`


(Michael Reuter) Bugfix/OPSIM-675 fix eups and local installations
* Relying on prefix envvar to handle installation path.
* Adjusting documentation for new mode.
* Revert "Relying on prefix envvar to handle installation path."
* Fixing the real problem. The targets should have been on the install only.
* Splitting up target.
* Updating documentation.


(Michael Reuter) This should hopefully fix the configuration issue for the EUPS installation. Local installations will need to be careful when running scons.


(Simon Krughoff) I must admit that I don't fully understand the fix.  It looks like there were several iterations and the final diff is very short.  I don't see any problems with the diff.  Feel free to merge as far as I'm concerned.


(Michael Reuter) Bugfix/OPSIM-676 fix config default in usage statement
Making usage default config match code.


(Michael Reuter) Bugfix/OPSIM-677 fix documentation for existing
Fixing documentation.
Fixing conflict.


(Michael Reuter) Bugfix/OPSIM-708 remove envset from eups table
Removing envSet as this causes issues when $HOST isn't set.
Fixing docs.
Fixing conflict.


accessDate should actually be ISO 8601 for API v3.


Array.py should be array.py


Please the next time FULLY CHECK your commits on every distro and box before you commit.

Sorry, but I simply COULD NOT resist.


Goodbye, Rachel. I'm so sorry I couldn't talk to you more. RIP.


(Michael Reuter) rebuild passes now


(Simon Krughoff) Looks good.  Sorry it took so long for me to have a look.


(Michael Reuter) Bugfix/OPSIM-711 fix path override for eups build
* Trapping path override.
* Bit of debugging.
* Trying to fix test builds.
* Removing debugging and tweaking comment.


(Michael Reuter) Bugfix/OPSIM-709 docs fail to build on eups build
* Making documentation build on first try.
Since the documentation configuration file depends on the generated version file, the SConscript execution kept failing. Had to move to doing something in the top-level SConstruct.


Still missing the doctype and head tag.


(Michael Reuter) Bugfix/OPSIM-713 fix path trap condition
Fixing path trap logic.


(Michael Reuter) Bugfix/OPSIM-715 modifyschema fails when summary
Adding exception handling for summary table creation.
Making table exists error message nicer.
Pushing Lynne's changes. This looks a lot nicer.


(Michael Reuter) Looks like we introduced a small bug in gen_output.py when removing the exception handling for the DB calls. I didn't catch this since I was testing against tables that already existed. I found this out when I accidentally blew away my DB and was running a new simulation and trying to run modifySchema.


(Lynne Jones) Hmm. Interesting .. I wonder if the desired behavior shouldn't actually be -- drop the table, then create it (rather than checking if the columns exist, and then creating it if they don't).
I'm not sure what would happen if gen_output.py is called on a summary table that already exists, especially with the sql being an insert (not something like update). Would we end up with double rows?


I'll try to work on that


(Lynne Jones) Actually, the more I think about this the more confused I am. The summary table *shouldn't* exist for a new run until gen_output is run, so I'm not sure why this wasn't failing all along?  .... oh, but actually, now I remember, this is where the very confusing error message came from.

I think the proper behavior probably ought to be - if the table exists, quit with an error message & ask the user to delete the table by hand and then re-run modifySchema (this happens right at the start so shouldn't be a big investment of user time either, to just restart).


What happened in my environment was this:

     [echo] fileName: c:\java\lp7\liferay-plugins\portlets\sample-service-builder-portlet/docroot/WEB-INF/src/com/liferay/sampleservicebuilder/service/persistence/impl/FooPersistenceImpl.java
     [echo] _implDir: c:\java\lp7\liferay-plugins\portlets\sample-service-builder-portlet/docroot/WEB-INF/src
     [echo] fullyQualifiedClassName: liferay.sampleservicebuilder.service.persistence.impl.FooPersistenceImpl

We replaced BACK_SLASH with SLASH before comparing with _implDir, and _implsDir was not found as a substring. After that, we calculate pos = _apiDir.length() + 1; which automatically eat "com." prefix; and remaining FQCN is not prefixed with "com.". Reqult is fake class, and NullPointerException:

     [echo] Exception in thread "main" java.lang.NullPointerException
     [echo]     at com.liferay.portal.tools.service.builder.ServiceBuilder._getMethods(ServiceBuilder.java:4523)
     [echo]     at com.liferay.portal.tools.service.builder.ServiceBuilder._getMethods(ServiceBuilder.java:4517)
     [echo]     at com.liferay.portal.tools.service.builder.ServiceBuilder._createModelClp(ServiceBuilder.java:2624)
     [echo]     at com.liferay.portal.tools.service.builder.ServiceBuilder.<init>(ServiceBuilder.java:923)
     [echo]     at com.liferay.portal.tools.service.builder.ServiceBuilder.main(ServiceBuilder.java:308)

Fixed.


(Michael Reuter) If the summary table exists, gen_output.py fails with the following error:

[gen_output.py]
Traceback (most recent call last):
  File "schema_tools/gen_output.py", line 163, in <module>
    create_output_table(hname, database, cursor, int(sessionID));
  File "schema_tools/gen_output.py", line 62, in create_output_table
    ret = getDbData(cursor, sql)
  File "schema_tools/gen_output.py", line 26, in getDbData
    n = cursor.execute(sql)
  File "build/bdist.macosx-10.5-x86_64/egg/MySQLdb/cursors.py", line 174, in execute
  File "build/bdist.macosx-10.5-x86_64/egg/MySQLdb/connections.py", line 36, in defaulterrorhandler
_mysql_exceptions.OperationalError: (1050, "Table 'summary_aquila_1000' already exists")

So the summary table is not created again. Now, if we want make it drop the current table and recreate, we can do that, but that's not what this ticket addresses.


see `readRDS` for serializing a single object


see `cor(x,y,method='spearman')`


Just FYI - this comes from the `semigroups` package, which I'm pretty sure purescript already depends on transitively.


Don't worry, as I said before, I have seen your whole code. And I can clearly see that it will not make another bug, and the old bug are really gone with your new code. The other thing was, your new code, for example settings json will make developer easier to setting up their apps, rather than open up  lib/applications/meteoris/configs/config.js which may be harder to find. And settings.json was the correct way to set the apps like recommendation at docs.meteor.com. But I think this change need clear documentation before it can be published.


see `xtable` package


done


Sorry for my careless.

@pipu
Could you please use `isAnimationInfoExists` instead?


呵呵 add conment


I need @amilev to clarify


`sprintf("%02X", 14)` would be the traditional/C style way


This "RUN cron" isn't working for me for some reason. When I get into the container I don't see cron running when I do "ps aux".

What does work for me is "CMD /root/duckdns/duck.sh && cron && sleep infinity". This forces the duck.sh script to be run immediately on container startup, then every */5 minutes afterward.


You should invalidate this token if you haven't already


See also `rgb`


This is not going to work. You're using a passed-in mqttc parameter to connect, whereas all other keywords like publish and subscribe use a class variable `_mqttc`. So if you try to publish or subscribe expecting this client to be used, it's going to throw errors because the class variable wouldn't be initialized at that point. (Side but very important note: *make sure to add tests to publish/subscribe with secure connections that you're adding*)

I believe the right way would be to just use the `Connect` keyword and remove this because the only difference is that you're initializing the client beforehand so you can use `Set TLS` and `Set Username and Password` keywords. So in `Connect`, just check (for now) if `_mqttc` has been initialized. In next version, we can make it cleaner by removing the constructor from `Connect` and expecting it to be done in `Initialize` keyword. I'm open to working on that with you, so let me know.


just a test


TeamCity Demo Green :: Master Build [Build 2.1.0-1](http:/24.246.71.137:8111/viewLog.html?buildId=120&buildTypeId=DemoGreen_MasterBuild) is now running


TeamCity Demo Green :: Master Build [Build 2.1.0-1](http:/24.246.71.137:8111/viewLog.html?buildId=120&buildTypeId=DemoGreen_MasterBuild) outcome was **SUCCESS**
Summary: Running Build time: 00:00:14


see also `texi2pdf`


これはどういう意味ですか?


いいですね。


Can we remove the `get_` prefix?


Would love to.  Do you know how?  I can't figure out how to generate a new one.  CodeClimate seems to have a very "relaxed" attitude about it:

> By design, this token only allows someone to send Code Climate coverage data for your repository. It doesn't grant any other access or permissions. Nonetheless, it's your preference as to whether or not the token should be kept secret. If you prefer to keep it secret, most CIs allow you to define environment variables outside of a publicly visible configuration file. For example, Travis CI allows you to define environment variables within a repository's Settings menu, where you can choose to keep them secret. Other CIs offer similar options. Alternatively, if you choose to commit your token publicly, this works as well. Code Climate works in either scenario.

http://docs.codeclimate.com/article/276-should-i-keep-my-test-coverage-token-secret


Is there any possibility of sending hide choices to server?
If so, this checking should not be removed.


FYI, on lines like this you do not need "te != null && te instanceof IInventory". If te==null, then te is never an instanceof anything.

In these cases it is safe to just do the "te instanceof xxx" without checking for null first, since if it is null, the instanceof will return false.


I don't see any red flags. this looks like it will allow only one set of ST/SE. Have you been successful in testing with a clearing house?


Can you add these to API mock (ApiConnectorMock.java)  library as well..


This is incorrect, we should rebuild on the child not 0


Done.


rax retry tests


Con esto nos dan permisos de publicar en nombre de ellos algo como "Estoy probando la red académica --- Academics... Que esperas para probarla también!!"


this will fail on objects created with `Object.create(null)` which I use a lot for baggage-less objects. Use `typeof !== 'objec'` instead


Use backtick instead of `'` for url:

```
`url`
```


Buffer.isBuffer instead


@khipkin I agree all the extra files sitting around kind of sucks, though, unfortunately, this appears to be the only way to force a certain directory structure to exist within the repository without actually having any content within those directories. In other words, if I could just add the directories with nothing inside of them, that's what I would do - but I can't.


I think this will cause all existing Essentia Coils to lose all their links!


I apologize for not checking through the pull requests. Glad to see that it should be addressed soon. Thanks!


We now include both a text and textarea and then show/enable the appropriate one based on the dropdown selection.


改成这样啦。


This was left out of the original code. Not sure if was my mistake or a design decision, because I'm still not sure what EMAILCOPY is for.


4.2より前の段階で発生していた模様...
とは言えつい最近まで正常に動作していたので4.1.xからなのかも。


@Ionic: urgh... Why this??? In shell scripts, we should have tabs as indentations, similar to other languages where indentation is not syntax-relevant. Shouldn't we?


*Had to drop original population views and recreate them by joining county tables in order to use the 'geom' column to accurately join and compare population information with district and circuits tables.
* The following sql statements I used to create a view combining population 2000 and 2010 tables with 2000 and 2010 ga county boundaries.
CREATE VIEW population_2000_3 AS (SELECT a.county, a.population_2000, b.geom FROM population_2000 a, ga_counties_2000 b WHERE a.gisjoin = b.gisjoin)
CREATE VIEW population_2010_3 AS (SELECT a.county, a.population_2010, b.geom FROM population_2010 a, ga_counties_2010 b WHERE a.gisjoin = b.gisjoin)
*The following sql statement I used to create a view for population change based on geometry rather than county since county data caused errors when attempting to join with circuits and districts. There is still a view that I created earlier for population change based on county names in case it is needed for other portions of the project.
CREATE VIEW population_change_geom AS (SELECT a.geom, a.population_2000, b.population_2010, population_2010/population_2000 FROM population_2000_3 a, population_2010_3 b WHERE a.geom = b.geom)

*Using the following sql statement I can population change for circuits that have equal geometries as counties (i.e circuits that only have 1 county). There are 11 results, but there are 49 total. I have been attempting to write sql statements using natural joins, as well as  attempted to us the ST_Union and ST_Intersection functions to try and merge the county geometries with their corresponding circuits and districts but keep getting errors.
SELECT * FROM population_change_geom NATURAL JOIN circuits


I do not know. I see emailCopy in both database and constants. This exists before I started coding this app


$this->db->where('year ', $year);


I checked in Lucy and here are the possible call sites that could conceivably be affected by a change to shallow semantics for Clone:

    core/Lucy/Index/PolyLexicon.c:            ivars->term = Obj_Clone(candidate);
    core/Lucy/Index/PolyLexicon.c:        ivars->term = least_term ? Obj_Clone(least_term) : NULL;
    core/Lucy/Index/SegLexicon.c:    Obj *lex_index_term = Obj_Clone(LexIndex_Get_Term(lex_index));
    core/Lucy/Index/SortFieldWriter.c:    SFWriterElem *elem = S_SFWriterElem_create(Obj_Clone(value), doc_id);
    core/Lucy/Search/RangeQuery.c:    ivars->lower_term     = lower_term ? Obj_Clone(lower_term) : NULL;
    core/Lucy/Search/RangeQuery.c:    ivars->upper_term     = upper_term ? Obj_Clone(upper_term) : NULL;
    core/Lucy/Search/TermQuery.c:    ivars->term   = Obj_Clone(term);
    core/Lucy/Util/Freezer.c:        return Obj_Clone(obj);
    core/LucyX/Search/ProximityQuery.c:    return S_do_init(self, Str_Clone(field), VA_Clone(terms), 1.0f, within);

I believe all of them are OK.

I couldn't find any call sites in Clownfish where the semantic might matter.

+1 for this commit.


Добавь ещё `-moz-box-sizing` для старых мозилл, как в других местах.


Maybe email them?


untuk running ini tolong composer update
@uchuy77 , @budi7


Issue #17


Ignore  packets that have nulls ;)  that should cover invalid game states


How you do that?
On Apr 26, 2015 10:41 PM, "TechStack" <notifications@github.com> wrote:

> Ignore packets that have nulls ;) that should cover invalid game states
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trayer3/DeathCube/commit/525be395fc1eee0c1b7a038e075bb99f9fb9d6ed#commitcomment-10908591>
> .
>


thx ^_^


Where did you get this wheel circumference from?


Pra ficar mais dinâmico, pode capturar o ano assim:

```php
// techparty.faccat.br/certificado/2015
$year = $this->uri->segment(2);
```


Daí pode usar o ano dinâmico aqui.


I personally am in favor of tabs over spaces.
For example, [tabs decouple the code’s presentation from its logic](http://lea.verou.me/2012/01/why-tabs-are-clearly-superior/)


E consequentemente, o método 2014 pode cair fora.


Crikey, you'r right. Fixed the code to use a generic mouse hid until the new force one is available


Closes Issue #2


It was using a mix of tabs and spaces before, with spaces seemingly more favorited. Thus I changed to spaces.


Debug code?


change


My personal preference is spaces everywhere... especially as you will end up mixing tabs and spaces at some point, if intendation is not a multiple of your personal tab width.

Additionally, this "personal tab width" isn't exactly a non-problem, either...


Oops. Yeah. Was testing that the functions actually worked.


dá uma olhada ai @lucasloami, movi a URL pra um arquivo config.js que não foi commitado.


Testing is in progress.   It has passed the FirstPass tests.  I have not
found any evidence that more than one ST/SE is ever needed

Tony McCormick
www.mi-squared.com
On Apr 26, 2015 7:20 PM, "teryhill" <notifications@github.com> wrote:

> I don't see any red flags. this looks like it will allow only one set of
> ST/SE. Have you been successful in testing with a clearing house?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tmccormi/openemr/commit/7b2ce25b9644b86c92a692d968699a90dc2f75d9#commitcomment-10908469>
> .
>

--
Please be aware that e-mail communication can be intercepted in
transmission or misdirected. Please consider communicating any sensitive
information by telephone.  The information contained in this message may be
privileged and confidential. If you are NOT the intended recipient, please
notify the sender immediately with a copy to hipaa-security@mrsb-ltd.com and
destroy this message.


:smile_cat: :cat: :joy_cat: :smirk_cat:


B revert A


你也不小了，该谈了~


Looks good.


呵呵，偶像慢慢来啊


TODO @rosechildja :squirrel:


(Lynne Jones) Ah, great. I don't think we want to automatically drop the table. Making the error a little clearer would be nice, but this is okay.


(Lynne Jones) Hey Michael, have you tested this? I'm trying to run it on my new opsim run, and it gen_output.py doens't seem to populate the summary table with any data. Maybe I'm misunderstanding what's supposed to happen?


(Lynne Jones) Nope, I see it doesn't work for me. I'm going to see if I can figure out what's going on & make a fix as I'd like to extract the results of my new opsim run.


(Lynne Jones) Well, works now .. I think it was a space / tab issue. Took me a while to figure that out, so in the process I did a bit of simplification on the rest of the code. I know that's not what you're trying to do, so if you don't want to accept those changes, you could reset this commit and just untabify the previous version. The changes work for me though.


(Lynne Jones) I think they'll make it easier to maintain this bit of code too.


as it's written now, `Hash.new('')` won't be any different from `{}`, will it? That is, no key will get the default value `''` because we're looping through bills that the legislator supported (`bills` here is an association, different from `Bill.all`. Perhaps the association should be renamed for clarity?)

I wrote it to just return supported bills because I thought that would speed things up. That way we only had to fetch *all* bills once, then only relevant bills for each legislator


(Lynne Jones) Okay, maybe I'm not allowed to push to this repo? I can't push my changes.


(Michael Reuter) Feature/SIM-386 create a switch to enable disable
Adding run tracking switch.


(Cathy Petry) I prefer that the default state be --track=yes since any Opsim Team and project simulations will need to be "tracked".  It's the community that won't want/need to use this feature.  Could we make it a parameter in the configuration files instead? or is there another way to implement it to make "--track=yes" default behavior or "settable" so it doesn't have to be "set" every time a run is started?


(Michael Reuter) I thought the idea was we wanted users to just be able to run the code and not have to think about remembering to turn off tracking every time they run. My experience with supporting user facing software showed me that you want them typing as little as possible at the command-line. Expert users can handle setting extra options when necessary. I also don't like putting anything into the configuration files for this as I find them to be clunky for this type of operation. Since we tend to operate in a mode of publishing a bunch of runs over a short period of time and then have a long hiatus between, I think remembering to set a flag shouldn't be to onerous on us since we are the expert users. To be safe, it can be documented as part of the production procedure. Besides, if we do forget to track a run, we can always write a little script to pull the necessary information out of the DB and stick it into Mantis.


(Cathy Petry) My understanding is the idea was for OpSim users to have the runs consistently tracked and for community users not to see this part because they won't use or need it.  OpSim (experts) can handle setting this when necessary, but my point is that it is *always* necessary to track the runs, and there are so many other details to remember and verify this adds a needless extra detail.  It's not a matter of documentation, it's a matter of streamlining the workflow - and not having to go back and "fix" things.  I'm happy to discuss it at an OpSim meeting and see if there is a consensus one way or the other.


(Michael Reuter) Feature/OPSIM-624 make opsim a distributable eups
* Adding a gitignore
* Moving main.py to bin.
* Moving module files.
* Holding on to old stuff for now.
* Moving test directory.
* Adds boilerplate files
Eups and SCons need some boilerplate to function properly.
The adds the ups directory, SConstruct, and a standard .gitignore.
* Adding module files.
* Adding to gitignore.
* Getting setup and module to import.
* Changing to modules.
* Changing paths for config files.
* Added requirement for lsst package.
* Move install out of the way
The build framework doesn't like a directory call install.
* Adds mysql as dependency
* Renaming top-level script.
* Updating gitignore.
* Initial work on DB setup.
* Automating creation and loading of OpsimDB.
* Fixes to get opsim code to run in EUPS mode.
* Making fixes to the other config files.
* Changing documentation to reflect EUPS setup.
Ran into a couple of weird sphinx formatting issues that
required laying out some of the documentation in a stange
manner to get things to work nicely.
* Getting OpSim code into EUPS install.
Using the new SConstruct for the config part lost the actual OpSim
code getting into the EUPS package. This should correct that.
* Changing installation instructions.
This modification is to handle changing the database
passwords in a configuration file before running the
configuration command.
* Updating source code instructions.
* Fixing conflict between installations.
scons install and eupspkg -e install are not playing nicely together.
This is a fix to correct that problem.
* Making files PEP8 compliant.
* More pep8 work.
* Cleaning out unneeded files.
* Adding dependency setup to source code section.
* Setting config file back to old state. I'm done testing.
* Adding missing acknowledgement.
* Making the conversion tools handle EUPS packaging.
The changes here are to make the scripts look at the MYSQL configuration
to get the connection right. The opsim driver was modified slightly to
put a username and hostname into the DB.
* Removing one last env variable.
* Existing DB instructions.
* This gets unit testing and the verions.py file back.
It also gets rid of some directories an merges others. The functionality of the
package did not change.
  Going back to basic scons setup.
  Moving the setup python code around.
  Moving directories around.
  Adding SConscript for docs.
  Fixing link location.
  Got scons into a better state.
  Fixing setup config and runner.
  Final cleanup.
  Minor mod to docs.
* Making requested change to get host name.
* Clarifying documentation about installation directory.
* Removing dependence on twisted.
* Fix order of operations in install docs.
* Slight doc format tweak.
* Move statement to correct indentation.


(Simon Krughoff) When sims_operations is eups distrib installable, we shouldn't have to do the above.  It should be sufficient to just do:
$> eups distrib install sims_operations -t sims


(Simon Krughoff) Similarly, it should be sufficient just to do:
$> setup sims_operations


(Simon Krughoff) Are we worried about the license of this code?


(Lynne Jones) Hi Michael,
Can you look at the python and mysql usage in the 'tools' section (see tools/schemaTools/* and tools/modifySchema.py) to see what might need to change there with the eups distributable version? I think you could probably simplify everything so that instead of hard-coding the paths to python and mysql, you let eups find the proper path (or trust that eups has set the appropriate environment variables, which might be better).


(Simon Krughoff) I don't know how to attach a comment to a file, so I'm putting it here.  There is a set of scons utilities in the lsst stack:
https://github.com/LSST/sconsUtils/tree/master/python/lsst/sconsUtils

If you find yourself needing more, it may be better to add them there rather than on a package by package basis.


(Simon Krughoff) Looks very good to me.


(Michael Reuter) I wrote this since we haven't gotten sims_operations into the EUPS universe. Once we do, I can go back and fix the documentation to conform to the new reality.


(Michael Reuter) Ditto from below. A bit worried that setup won't actually put some of the files in the right home. Might still need to do a scone install before when working with the repo.


had to remove more glue for ipfw/dummynet from the module. quite the collection of custom code there was... :/


Looks good, but put the most recent stuff on top the next time please ;)


comment?


(Michael Reuter) Thanks for the pointer to the utilities. I just used what the qserv guys had in their package. Some of them look useful. Maybe we should get them to fold them back into the LSST stack scons utilities.


(Michael Reuter) The scripts have been changed to look at the MYSQL configuration in the setup now. The commands in the scripts are assumed to be at the right locations since EUPS should be doing its job.


@dvyukov, that's not what the [docs say](https://golang.org/pkg/runtime/#GOROOT): "GOROOT returns the root of the Go tree. **It uses the GOROOT environment variable, if set,** or else the root used during the Go build."
I.e., it should be what `go env GOROOT` would show (which if you still don't want to use `runtime.GOROOT` would be a *much* better command to try than `which`).


thanks for the ping, fixed this in `usec` branch


I would have called it `with-private-vars`. And then renamed `fns` to `vs` or `vars` or `private-vars`


Oh hey thanks! I'm going to switch to that.


errrrrr... i'm not too sure where this is from actually >.<


(Simon Krughoff) That's a good idea.  I didn't take the time to compare in detail, but my suspicion is that they are similar.


(Srinivasan Chandrasekharan) Feature/OPSIM-328 ra limit
* OPSIM-328
create ra limit parameter
* OPSIM-328
create RA absolute limits parameters
* New absolute RA limits parameters.
* New absolute RA limits parameters.


(Srinivasan Chandrasekharan) Feature/OPSIM-388 nRun
OPSIM-388
Now the simulation aborts if nRun parameter is not present in the LSST.conf configuration file.


(Srinivasan Chandrasekharan) Bugfix/OPSIM-328 create ra limit
OPSIM-328
Fixed reopened JIRA


(Michael Reuter) Feature/SIM-960 remove execution page from documentation
Moving configuration text to installation page and removing execution page.


There is a error:
```
  File "/home/fix/.local/lib/python3.4/site-packages/redlock/__init__.py", line 38, in __init__
    self.quorum = (len(self.connection_list) // 2) + 1
AttributeError: 'Redlock' object has no attribute 'connection_list'
```

Looks like ```self.connection_list``` should be ```connection_list```


(Cathy Petry) Feature/SIM-972 change sciencetype tag in default
Removed spaces from the value for ScienceType


(Michael Reuter) Looks like you need to remove the accent character at the end of the line.


You could check https://github.com/Hywan/sabre-katana/blob/cs/.gitignore and https://github.com/Hywan/sabre-katana/blob/cs/.travis.yml#L32.


neden 3 ile çarpıyorsun?


I can live with that. One relates to a certain input syntax, the other is an integer-to-character conversion. I agree it would be better to give an error if it were free, but I don't think it's all that important.


Is this from DreamWeaver?


(Srinivasan Chandrasekharan) Feature/OPSIM-151 slalib to palpy
slalib dependency removed, palpy first commit.


(Scott Daniel) This isn't anything that needs to be changed, just a heads-up:
It looks like you are passing the same mjd to rdplan here that you passed to gmst at line 213.  gmst requests the MJD represent the UT1 time.  rdplan requests that the time be in TDB and explicitly states that UT time will not work for the moon.  You might want to put a comment in the code here nothing this distinction just in case a future effort is made to precisely represent all of the available time systems in OpSim (I just put similar flags in the astrometry code in CatSim, which is why this stands out to me).


(Scott Daniel) the API for cldj changes in PAL.  The error is not returned.  Only the MJD.  If something goes wrong, pal.cldj will raise a ValueError exception.  All of which is to say, this line should be
mjd = pal.cldj(year, month, day)


(Scott Daniel) it looks like there is an indentation error here


(Scott Daniel) Is this another indentation error?


mm kread does not call write.. so would that be because kwrite is writing out of place?


(Scott Daniel) There are just two indentation errors and one API change that need to be addressed.  Do what you will with my comment about time systems.  Other than that, this is ready to merge.


(Srinivasan Chandrasekharan) I took care of the indentation errors (didn't see them in vi though). API change also fixed. As for the time systems I will ask Francisco to take a look at it.


(Srinivasan Chandrasekharan) Bugfix/OPSIM-504 transient subsequence proposals
OPSIM-504
Fixed IDLE state handling of a sequence, for the case of
interruption during the very first deep-drilling event
of a multi-subsequence sequence.


(Michael Reuter) Feature/SIM-989 expand size of paramvalue in config
Increasing varchar size to 128.


(Michael Reuter) Feature/SIM-918 include rottelpos in opsim summary
Putting rotTelPos back into the Summary table.


(Michael Reuter) It's baaack! You can test this out yourselves or I can pass along a short survey that I've run through this.


(Scott Daniel) I've never actually run OpSim.  Is there a tutorial somewhere that can guide me through the process.  I am also willing to just take your word for it on this.


(Francisco Delgado) Bugfix/OPSIM-404 simulator dies no active proposals
OPSIM-404 - Fix for simulator dies when no active proposals. Changed ObsScheduler.py


main'i böyle yazmıyoruz artık:
`int main(int argc, char *argv[])`


Builds all seem fixed now https://travis-ci.org/GMOD/Apollo/builds i'll continue comments on #315


"moBs", not "moDs", of course...


Looks good. ;-)


So it turns out that at file.h:70, the directory entry's name is passed as a pointer, so the actual name wasn't being saved to disk (just a defunct pointer to it).


Just noticed this. What is the intent of this line?


I would not have been shoked if you had specified `with-private-vars` with a signature implying repetition of ns in front of the different vars. It's more work to write, but not necessarily more work to read, and also more open, e.g. to reference private vars from several namespaces without needing to nest `with-private-vars` calls or to make `with-private-vars` implementation more complex (and its signature)


This data is supposed to simulate user input. You can see toJSON output in test/tests/data/itemJSON.js As you note, the date is output incorrectly. Will fix


thanks, tested it, and it works great.


I use 1000000 baud, a genuine FTDI adapter, and am on Windows 7.
Before this change, uploading worked reliably (almost) every time, but failes now due to this change about 50% of the time.


(Lynne Jones) If you want to give comments on the registry stuff, you can do that too. I think I've probably included most of what you were thinking, from our discussions, but it's always different to see the code.
One nice thing that the metaclass provides is a way to list all the available metrics along with their docstrings, which ought to be available eventually via sphinx for the lsst.sims.maf.metrics set, but the list would also include any imported metrics. I'm not sure how valuable that will end up being, seeing as you have to do it from the python shell, but who knows. I thought it was kind of nice.


(Andrew Connolly) It is difficult to isolate the changes for this pull request from the changes for the other open pull request. How are you branching these features (are they all directly from master?)


(Andrew Connolly) Are we in general using print statements or logging the output when writing to the console?


@alexsomeoddpilot should this include `nib` or `sop-style` mixins like `backface-visibility(hidden)`?

if so, dependancies need to be edited for testing


Forgot to note that this relates to https://github.com/DataTables/DataTables/issues/543 . Thanks to @MuellerMatthew for picking this up.


causes server side crash :

java.lang.NoSuchFieldError: gameTimeStart_client
        at com.projectreddog.deathcube.DeathCube.<clinit>(DeathCube.java:72) ~[DeathCube.class:?]

I assume it is because gameTimeStart_client is defined as client only yet the code is trying to access the variable on the server (!worldobj.isremote)


Je crois que c'est en lien avec https://github.com/patacrep/patanet/issues/130


Ah, that's me. It's to add export and prevent select from changing suggestions.


`defn` & al are special and should not be embedded inside other `def*` (as in `deftest`) as a general rule.

So either you move `build-test-descriptor-fn` up, outside the `deftest` definition, or you remove the `defn` and use `letfn` instead, IMHO


step | pass?
--- | ---
canary site online |  :white_check_mark:
authenticated with GitHub | :white_check_mark:
no carry over reviews |  ::white_check_mark:
created request |  :white_check_mark:
Uploaded pdf |  :fire:
Found issues in GitHub |  :fire:


@sayedihashimi So you can specify null instead of "All" and it will work across multiple versions?


rax retry tests


(Andrew Connolly) Remove commented lines


Same remark as above wrt `defs`


No. Most of it is from a template I initially wrote in WEB 120, and have
been altering and rewriting since. I'm in the middle of consolidating it
now. I haven't used Dreamweaver since WEB 110.

Chris

On Mon, Apr 27, 2015 at 1:04 PM, Mike Sinkula <notifications@github.com>
wrote:

> Is this from DreamWeaver?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Adiqshen/321templates/commit/b7b2b53e7a70f5b50ded16931512a80e4db5dcae#commitcomment-10924851>
> .
>


@asmeurer what's the motivation here?  This change breaks the conda-env build which lists `activate` and `deactivate` in both their regular bash and batch format.


It's actually `blaze_source.py`

https://travis-ci.org/bokeh/bokeh/jobs/60268120#L1840


(Andrew Connolly) If you are using sets isn't colSet and dbSet always unique? Do you need these functions?


What is the call to `lazy-seq` for?


I don't think we need this. We already have ``Zotero.getTempDirectory()``.


(Andrew Connolly) missing doc string


(Andrew Connolly) space required between first line and remaining paragraph in doc string. Paragraph should make declarative statements and no "perhaps"


Where is keys intended to be defined?


OK, I'll move it.


(Andrew Connolly) Should this be sliceMetric and slice plotting...


(Lynne Jones) In general we would branch from master. However, the last change (binner -> slicer) was pretty big and while we were waiting for a review we needed to make these changes (which involved a lot  of the same classes).  It didn't make sense to branch from master, and Simon agreed we could branch from the previous branch.
The problem is that Stash doesn't let you look at changes between this branch and a different branch, only this one and master.


(Lynne Jones) In general, for warnings or messages like this, we're using print. For outputs which are related to metric generation, we're writing to files.
I don't think this particular message would be useful for anything but interactive use (it's intended to be used to see what the available metrics are, which I'm not sure would be useful except interactively).


(Lynne Jones) The colRegistry is intended to be used from the driver or from a python script to get the columns needed from the database or the complete list of columns. We certainly could have the user at the other end just access this info directly instead of through these methods.


(Lynne Jones) I think we'll go with your suggestion below and just remove these methods entirely.


(Andrew Connolly) you use these functions in your unit test so you should update that as well


(Lynne Jones) Done.


(Lynne Jones) Yes, we joined setupKwargs and kwargs together (to make things less confusing for the user). Spaces added.


(Lynne Jones) I'll check with Peter to make sure. It's basically just added to the plot titles, so in a way it's personal preference. We should standardize for our provided drivers though -- I prefer the full opsim run name, rather than abbreviating 'opsimblitz' to 'ob'.


(Lynne Jones) Changed to slicerList.


(Lynne Jones) Swapped to slicepoint.


Unless you need an empty directory for exporting and comparing the output?


(Lynne Jones) swapped to slicepoints.


(Lynne Jones) swapped to slice metric.


(Lynne Jones) done.


I'll look now, but do you know where the server would be trying to access
this variable.  Line 72 is just the declaration.

On Mon, Apr 27, 2015 at 4:08 PM, TechStack <notifications@github.com> wrote:

> causes server side crash :
>
> java.lang.NoSuchFieldError: gameTimeStart_client
> at com.projectreddog.deathcube.DeathCube.(DeathCube.java:72)
> ~[DeathCube.class:?]
>
> I assume it is because gameTimeStart_client is defined as client only yet
> the code is trying to access the variable on the server (!worldobj.isremote)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trayer3/DeathCube/commit/d1cdec6a68eb9ed574933447a00060f4fe95efcf#commitcomment-10924944>
> .
>


(Lynne Jones) Ah -- now I'm editing the docs in this method, I see what you mean. Currently there's no way to turn it on/off except by setting it in the healpix slicer.
We need to do a better job of handling control of the caching -- either every slicer can use it and it should be a kwarg, or only healpix slicers can and we make it less visible at this level.


(Lynne Jones) Removed.


`waitpid()` için gerekli başlığı include etmiyorsun.


same remark for all `def`s and `defn`s which should probably be `let`s and `letfn`s respectively


(Lynne Jones) Updated.


(Lynne Jones) That was slightly painful to reformat.


(Lynne Jones) Done here.


(Lynne Jones) I think I'm just unclear on what scons needs and wants. It seems like scons needs something different than the usual straight-up python requirements. For example: scons needs unittest.main() OR (apparently) what is in testBaseSliceMetric). But in general python unit tests can run without the unittest.main (but with the unittest.TextTestRunner line). Any feedback on what LSST best practice is and why this is different than general python unit testing?


(Lynne Jones) From the sliceMetric, we always pass the slicePoint metadata because we don't know what a particular metric needs (most don't actually need the slicePoint metadata). I'll switch the slicePoint to be kwargs so that it's easier to use from other avenues (such as the unit tests).


same general remarks wrt nested `defs` and `defns` inside other `def*`


(Lynne Jones) Done.


Unfortunatley we were not able to find out, how to do it in the patria wagon. We have tried it but the methods were not called, so there was no output.


(Lynne Jones) Outstanding questions:
- the run method at the end of unit tests. What is the best practice for LSST here? (unittest.main()? something involving testsuites? I've seen both in other LSST code).
- using print versus better logging. I don't think we want to address this here necessarily, but is there something we should be doing differently? What about in cases where we think the message is mostly/only useful for interactive work with MAF?
- do we need the oneDSlicer when we have the NDSlicer? I like having both because the OneDSlicer is super easy to read and understand to modify if you're doing something similar but not quite the same, but it's true all the functionality of the OneDSlicer can be recreated by the NDSlicer.
- in the BaseStacker class, the _addNewColumns takes simData as an argument and returns it as a return value as well. I did this to make sure it was clear to the user writing a new Stacker class that simData was being modified, but it's not really necessary to return simData (or shouldn't be). Should I change this?
- are we okay with leaving the testDB in git for now and figuring out how to remove it and replace with a smaller db later? We will go through our tests and figure out where we're using what, and make sure we're not using the testDB if we should direct a user to download a DB instead (in case we swap to a smaller DB later, we wouldn't want users making plots with the test db and saying "what heck? i don't understand what's going on .. because it's only a monht's worth of data).

I'll also work with Peter to determine what's the best thing to do about the cache size. I agree the current setup is not ideal.


(Simon Krughoff) - I think DM usually uses testsuites because the unit tests usually add a standard memory test to the suite.  I don't think that's necessary if there is no C++, so maybe unittest.main() is good enough.
- The LSST stack has logging utilities, but maybe standard python logging (https://docs.python.org/2/library/logging.html) would be easier.
- On the question of oneDSlicer/NDSlicer question.  I always fall on the side of eliminating code duplication.  Can OneDSlicer be a minimal subclass of NDSlicer?
- Returning reference to mutable argument -- This sheds some light on the issue (http://stackoverflow.com/questions/575196/in-python-why-can-a-function-modify-some-arguments-as-perceived-by-the-caller).  I think the fact that simData is mutable means that you shouldn't return the reference to it since it makes it look like Python is copying it (and could perpetuate Python misconceptions for python novices).
- The test database.  This is the perfect case for git-fat.  Unfortunately, we don't have it.  Also unfortunately, if you take this out later, it gets more painful to purge the longer you leave it in.  This doesn't give you a solution, obviously, but I do think it takes a while to clone.


(Lynne Jones) OneDSlicer vs NDSlicer: it's already essentially a minimal subclass of NDSlicer .. they don't actually have any code in common besides what they both inherit from BaseSlicer. The differences include subbing simple lists for lists of lists, and some other aspects that make it easier to edit /modify the oneDslicer. If it makes it any better, I can imagine the OneDSlicer being subclassed and then used for things like making movies or slicing based on seasons (where 'season' is identified by gap in observing).


out of curiosity, what is `java.data` used for?


this is a test comment to send myself.


(Peter Yoachim) Feature/OPSIM-461 spie paper for maf
* Committing SPIE paper changes (will be moved to a new branch).
* some minor edits
* Fixed typo Steve noticed and added color to the code blocks.
* Update to finished paper.
* Fixed Andy Connolly's name in author list.
* Updates to stacker classes to test new BaseStacker setup. Works! Also, new testdriver2.py works with new slicers and metrics configurations.
* Oops, had to fix quickRevisit metric run method to have appropriate # of args after update to sliceMetric.
* Added new workshop stuff (update to baseStacker, new metrics, new stackers, new examples of using these.)


(Peter Yoachim) Feature/OPSIM-482 updates for workshop release
Got rid of the simpleMetric base class since it wasn't adding much.

Split the script that runs driver config files so we can have two different kinds.

* Removed SimpleScalarMetric base class. Updated metrics, sliceMetric and unit tests to reflect this. Note small API change to configureMetric from driver! (args['colname'] ->  kwargs={'col':'colname'}.
Have not yet updated driver scripts in examples.
* Removed unused items (args) from mafConfig and mafDriver, removed **kwargs from BaseMetric init. These things were unused and unnecessary with our new plan for writing metrics. Removing them let me find errors in our test driver config scripts! (this is good because it means users won't be surprised when they try to do something - the wrong way - and it doesn't work. they'll get a proper error instead).
* Continue cleaning up **kwargs in inits, updated sstarDriver to work with new args instead of kwargs, fixed problems in fOslicer when calculating summary stats with col=None.
* Added runFlexibleDriver.py (so now runDriver.py runs only one-offs, the runFlexibleDriver.py runs flexible configs). Updated cadenceDriver.py with args->kwargs change  and tested it. Made install_initialtest.py a one-off and added a flexible version of this too.
Removed fODrive.py since it seemed unnecessary (copied in sstarDriver.py).
Updated examples/driverConfigs/README.txt
Updated maf_example_web.py and allSlicerConfig.py
* Updated driver config in SPIE paper dir.
* Updated python script examples slightly (Bin -> Slice). Updated example new metrics to match what I think we're going to use and cleaned up script to use new metrics and new dither patterns.
* fixed args to kwargs
* put fO in allSlicers driver


The more I use boost::path, the more I think that it wasn't the best idea at all.
Anyways Xournal++ is gtk/glib based, so for better multiplatform support it's possible that reverting all file operations to use glib(mm) is more reasonable than moving everything to non-URI boost::path.


TeamCity Nuget Packages :: Solink.AddIn.Helpers [Build 6](http://mufasa/viewLog.html?buildId=3207&buildTypeId=NugetPackages_SolinkAddInHelpers) outcome was **SUCCESS**
Summary: Tests passed: 17 Build time: 00:00:38


It might be helpful to define some common variables like those.


This line breaks pixie integration, since pixie has no -m option.


91958608DOASEffectOnZoneSizing (wfbuhl) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Burada döngü sıkıntılı olmuş çünkü `do {}` bloğunda status'u değiştiren bir kod yok, o yüzden koşul sağlandığı sürece sonsuz döngüden çıkmaz kod.


Does `tools.logging` have a valid use case for CCW, where we are already using Eclise specific log & tracing features?


Yes, both should be included.


(Scott Daniel) When I try to run this example, it complains about 'params' being here.  Based on what I've seen elsewhere, should expMJD be moved into the kwargs dict?


(Peter Yoachim) Yup. Fixed.


(Lynne Jones) Sorry - I thought I caught all of these. and Yes! looks like the new pattern is obvious.


The advantage of using Zotero.getTempDirectory(), at least as the base in the function above, is that it will get cleaned up automatically by the run script. Not sure if that's true for the system temp dir (at least until a system restart).


Unhandled Fundamental Failure


It's the first time I encounter `additional.bundles` inside `build.properties`. How is it used?


(Lynne Jones) Bugfix/OPSIM-542 showmaf.py dies if no display info
* Removed irrelevant comment.
* Addressing bug.
Synchronized writing displays and metric data. Removed 'captionAll' option and just automatically caption each plot as it's created (to update displays appropriately). Updated resultsDB class so that it will update displays lines (so we can write displays multiple times -- when we first write a metric to disk and then when we create plots).
* Added user-selectable port capability to showMaf.py
When running showMaf as well as ipython notebook, they were both running on 8888. So I made 8888 the default port, but let showMaf.py use other ports if requested.
* Fixed Calibration unit test failure.
For some reason the calibration test was failing (even though I didn't touch any of this code).
Updated the asserts to match what the expected behavior should be. This fixed the unit test.


(Simon Krughoff) In general, we should document every parameter in the method.


(Simon Krughoff) The word add makes me think this is a concatenation method.  Maybe call it updateDisplay instead?


I overlooked `Zotero.getTempDirectory`, but I do end up checking the contents of the temp directory to make sure files are copied there. Will take a look if we can avoid this.


(Simon Krughoff) Same as above, is this really updatePlot?


(Simon Krughoff) Trailing whitespace.


Cocuk süreçten WIFEXITED ve WIFSIGNALED'in hiçbir işi yok.


(Lynne Jones) Removed this and all the other trailing whitespace.


(Lynne Jones) It's adding a row to the database. I guess in SQL that's called update, although when it isn't in the table at all 'update' seems the wrong word to me. I can change it.


(Lynne Jones) Feature/OPSIM-350
Name change complete and unit tests pass.


(Peter Yoachim) OK


(Peter Yoachim) Feature/OPSIM-329
Driver can be configured to merge histograms.
Date and version number are being saved
Driver unit tests updated


Aynı şekilde `waitpid()`nin de..


(Peter Yoachim) I'll be bad and merge myself since Lynne is on vacation.


(Lynne Jones) Maybe while I'm gone (if it's a feature that needs relatively quick resolution) you can get Simon or AndyC to review? (just make them reviewers and then maybe check in in person).


(Lynne Jones) That said, I did just now have a look at this and it's all good. One thing though is that you snuck in another change unrelated to the merge histograms -- a change to how the summaryMetrics are computed (now you have to pass an instantiated summaryMetric object, not a class object pointer .. which makes sense from the driver, but is a separate change to the merge histograms point). Do the examples_*binner.py still work with this change to computeSummaryMetrics? (I think they probably don't, although I haven't checked. Can you please check and update if necessary?)


(Peter Yoachim) Your right, that change broke one of the examples.  But I already snuck the fix in on the next unrelated merge.


(Peter Yoachim) Feature/OPSIM-279 write unit tests for db access
* add a dbLogin file for testing
* testing the getData functions
* fixed summary stat change in example


(Peter Yoachim) fixed oneDbinner plotting bug
turns out color=None is a bad default.  Also updated the driver unit test to make sure all png files get created.


(Lynne Jones) Looks good. One suggestion: in the maf_example_web.py, line +96 in the diff, it might be clearer to make filter_colors a dictionary (keyed by filter name) instead of a list. That way you only have to loop over f in filters and can look up the color using the dictionary (while also making it really easy to see what color corresponds to what filter when looking at filter_colors).


I want to trigger all components with this example.  We have 4 components / modes for file staging: UMGR staging in, agent staging in, agent staging out, umgr staging out.  The one above should trigger the first one (which is currently implemented in controller/input_file_transfer_worker.py).  I that assumption correct?


(Lynne Jones) Also sorry, I have such crappy internet here (especially tonight) that I couldn't quite take a look at the other files in this branch .. did this bug also affect the baseBinner histogram (and other binners which use the same histogram code)? If so, I might suggest fixing this here too (and maybe just changing the branch description to match .. looks like you can do that using hte 'edit' button on this page), as it's really the same bug. {yeah, I know this kind of goes against the bundling more than one fix .. but it's really the same fix, just in different places.}


Using `subject` does not seem to work in this case:
Failure/Error: expect(subject).to eq('http://searchworks.stanford.edu/view/123.mobile?covers=false')
     ArgumentError:
       wrong number of arguments (0 for 1)


Still playing here? A startup message is meant for the service startup, which should happen only one time.


I don't think this is the right thing to do. We're still supporting the old syntax, so we should create new tests for namespaces, not modify existing ones.

If we do this, we lose coverage when using the `module` keyword, which is important given that we may be renaming/moving a lot around in the codebase related to modules/namespaces.


Thanks for the changes. I merged the branch to develop and fixed some other (unrelated) bugs.


Is there any preference regarding the sequence of includes?


(Peter Yoachim) Huh, looks like it only hit the oneD binner because it's using plt.plot.  All the other histograms are using plt.hist, and I guess that doesn't care if color=None.  I'll make them all consistent for good measure.


(Peter Yoachim) Feature/OPSIM-359 debug maf grabbing data from mssql
Get rid of Invalid DISPLAY problems with driver


(Peter Yoachim) Feature/OPSIM-360 fix color bars on opsimfieldbinner
Lots of minor fixes to the default plotting behavior.  Added in percentile labels for histograms.

* updated the old starDriver.py
* make the ylog behave if there is percentile clipping
* add percentiles to the oneDbinner historgam labels
* add percentiles to spatial binner histograms
* percentile fix
* easy toggle on driver example
* fix cases where the metricValues are uniform
* fix for hourglass case
* tweak the default hist range


(Lynne Jones) Hi Peter

I'm not sure I'm super happy about the percentiles calculation. It seems like this should be treated as a summary statistic, rather than as a property of the binner. Can you explain why you went with making it so integral to the binner instead of a summary statistic (one which is 'special' in that it gets printed onto the plot as a legend label?)


(Lynne Jones) This might mean though we have to calculate summary statistics - or at least special summary statistics which are going to be put into the plot labels - earlier.
How do you currently indicate to include the percentiles (and what values for the percentiles) on the plot? You could imagine making a pParams['percentiles'] parameter, then using that to trigger calculating the percentiles when generating the legend labels, and when triggered, using the 'computeSummaryStatistics' method ... as an example.


(Peter Yoachim) It would make more sense as a summary stat, but that doesn't work for the oneDbinner because the metric values are the bin heights. So you can't compute the percentiles (exactly) after the count metric has been run, you have to do it at the binner setup stage when the binner has all the data. That's why it has to be part of the binner, you can't re-compute it if you restore the metricValues, so if you want to use those values later (like in a combined histogram), you have to save it with the binner. Most of the time, what one would intuitively think of as a oneDbinner summary stat actually has to be done as a uniBinner+metric.

yup, I added a 'plotPercentiles' boolean kwarg so pParams can toggle the labels on and off.

Maybe we could have as part of the binner init a labelMetric, then you could pass in an arbitrary summary stat that gets computed and saved as the label.


this commit change the BridgePart index to be 0 in all 3 rows


(Lynne Jones) Ah, right that makes sense. In a way, the percentile values then are actually a comparison/merge plot, where the percentile data was calculated with the unibinner. Wonder if we should instead make that more specific. I realize it's a lot more overhead, but perhaps it's worthwhile for the added flexibility?? Are the percentile values only being added to merged histograms anyway?


it's a public repository after all


(Lynne Jones) After much discussion, the percentiles addition to the oneDBinner and spatial binner being so different seems too awkward for future maintenance and building of the code. It's a nice feature, but probably needs to be implemented in a 'comparison' / 'merge' plots stage (using the percentile information as a label for the plot legend .. grabbing the information to go into the plot label from the summary statistics of the spatial binners and from a unibinner run with the same metadata for the oneDbinner).


(Lynne Jones) Bugfix/OPSIM-587 update openshuttertime metrics
Updated OpenShutterTime and OpenShutterFrac metric.
Updates to conform to new opsim visitExpTime and visitTime column definitions.


(Peter Yoachim) Should we just toss this metric since now it could be done with a simple sumMetric?


(Lynne Jones) Good point. I'll remove it.


(Lynne Jones) Bugfix/OPSIM-586 combo histogram overwriting previous
* Updated comparisonSliceMetric to include metadata in output histograms.
By adding metadata to output histogram names, the output files for SSTAR should remain unique. Makes long filenames, so should clean up further in future.
* White space removals.


(Lynne Jones) Thanks for fixing the unit test - I realized after I submitted the PR that it was problematic, but didn't have time to fix. So thanks! :)


@pbeeler Yes, but GCC is an acronym for GNU Compiler Collection, and thus should be all caps when used as a title.


(Peter Yoachim) Bugfix/OPSIM-576 nvisitratio combination histograms
I just dropped in a new metric to deal with this.  I think that's the best solution.


(Lynne Jones) Good check.


(Lynne Jones) For these metrics where we're passing keyword arguments and making them a part of the metric (i.e. normVal becomes a crucial part of the metric, like when we're doing FracAbove ...) we should try to capture that kwarg value into the default metric name.

Obviously it doesn't matter in the sstar driver use case we're using here, but in general, it is useful and since our code serves as examples for others as well, it's probably a good thing/habit/example.

I'd propose something like replacing the default metric name of 'CountRatio col' with 'CountRatio col/normVal' (with normVal being some small number of sig digs or maybe even an integer).

Examples in the NoutliersNSigma metric or FracAbove Metric or Percentile Metric.


(Lynne Jones) Bugfix/OPSIM-577 bug in summary stats tables for
Knocked out a couple of JIRA items here, as a few were related to the summary stats tables.

* Updated summary stat macro.
Removed the option for a single summary stat table to have metadata across the top (one source of 'flip-flopping tables' I think, which Kem & Cathy did not like).
Updated multi-summary stat tables so that they would be more likely to be forced to have metadata on the left also (another source of flip-flopping tables).
Fixed bug which caused 'ones' in summary stat tables!
* White space change.
* updated sstar driver to have bigger jump in 'propOrder'.
I believe this will cause sorting in summary tables to be correct (it does).
* Removed debugging print statements in macro.
* Fixed stupid bug I introduced in previous combo histogram bugfix.
* Changed percentile metric name.
* Updated driver unit test to match filename outputs.
Maybe the driver doesn't care what the exact names are, just how many files are created?


(Peter Yoachim) Feature/OPSIM-334 supernova metrics
Added some metrics for the cadence workshop including a complex supernova metric and a few ways to look at early seeing statistics.

* make sure metric badvals are respected
* making plots
* added fraction above/below metrics for looking at seeing cut-offs
* updated unit tests
* revert example to default
* fix errors found when writing unit test
* added TemplateExistsMetric
* fixed up the TemplateExistsMetric
* cleaning up


(Simon Krughoff) Is there any reason to have this default hard coded?  It seems like this could be a command line option, or something.


(Simon Krughoff) Why is this file new?  It has more than just supernova metric stuff in it.  Try to use git commands to move things around to preserve history.


(Simon Krughoff) This line is way too long.  Lines should be 120 characters at most.  I see other lines that are similarly long (or longer).  These should be cleaned up.  It makes the code hard to read.


(Simon Krughoff) Since I can't comment earlier in the file...

I *strongly* discourage using `from blah import *`.  It's a recipe for name collisions.  It also makes it really hard to follow the code if there is more than one import line since you can't tell where things are defined.


(Simon Krughoff) Line length


I don't know how well this will work, but what if you defined all of the methods on the module that are defined in the context (minus the defaults)?  Something like:

```ruby
available = ContextClass.instance_methods - Class.new.instance_methods
available.each {|m| define_method(m) { @_context.send(m) } }
```

I'm interested to see how well that will perform.


(Simon Krughoff) I typically don't like to see commented code.  If you don't need it, get rid of it (it's always saved in the git history if you need it again).


(Simon Krughoff) This looks like you are setting all metricValues to the badval.  Is that what's meant, and if so is it necessary?


(Simon Krughoff) Is there a better default for this (nan or None?)?  Magic numbers always break somewhere.


(Simon Krughoff) If turning on verbosity is for debugging, could it be controlled from the command lineinstead of having to change it by hand?


(Simon Krughoff) This needs to be a relative import (.cadenceMetrics).


grrr.. not only. There are also tests that are failing.. I'll check if I can get remove those dependencies on test. In the worst case I'll fix it tomorrow morning if it gets too late here.


(Simon Krughoff) Line length.


(Simon Krughoff) There should be spaces between parameters (or not, but be consistent).


(Simon Krughoff) is there a rason not to use `for index, lside, rside in zip(ind, left, right)`?  It is a little clearer and saves a few characters.


(Simon Krughoff) commented code


Thanks for pointing that out. I've read recently about smart pointers. What do you think about them? Hence C++11 is used there already maybe it'd be good idea?


Thanks, I was able to completely remove this line.


closes #67


This silently breaks the profiler binary api by changing the signature of an api function. C apis can be evolved without breaking binary compatibility by adding more functions instead of changing old ones. So the api version number will only protect against changes in the behaviour of existing functions.


What's the reason to put all the logic to .h file and just include in it .c file? Very messy...


Make sure you also remove the `znode->z_link_node` member.  That will save us 16 bytes per znode which is a nice win.