@scopatz From the former failure it looks like it was set to 5 and not 7. I tried the above anyway and it still isn't working:
```
======================================================================
FAIL: __main__.test_fco_swu
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "tests/test_metrics.py", line 236, in test_fco_swu
    assert_frame_equal(exp, obs, check_less_precise=True)
  File "/usr/lib/python2.7/dist-packages/pandas/util/testing.py", line 648, in assert_frame_equal
    check_exact=check_exact)
  File "/usr/lib/python2.7/dist-packages/pandas/util/testing.py", line 595, in assert_series_equal
    assert_almost_equal(left.values, right.values, check_less_precise)
  File "testing.pyx", line 58, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2552)
  File "testing.pyx", line 93, in pandas._testing.assert_almost_equal (pandas/src/testing.c:1875)
  File "testing.pyx", line 136, in pandas._testing.assert_almost_equal (pandas/src/testing.c:2384)
AssertionError: expected 0.00241 but got 0.00241, with decimal 3

----------------------------------------------------------------------
Ran 7 tests in 0.236s

FAILED (failures=1)
```


why am i afraid doing that is going to open a can of worms?  let me take a look.


nice catch


Silly me - also added the info-box styling for CTAs.


Maybe exp and obs have different types.


I see a note the QA person left. Will fix it shortly or we can revert this also.


You beat me to it!  I was just about to go through and change all the "spectra" to "spectrum"!


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


C'est surtout que l'anglais que tu as écris ne veut pas dire grand-chose (ou du moins, je ne le comprends pas). Je changerais pour quelque chose de beaucoup plus simple si tu veux vraiment écrire un commentaire :

> Don't send the e-mail if the user is already notified.


Иван, я скачала из репозитория 9 лабу на другой комп, все компилируется. Возможно, дело в том, что у меня каждый класс находится в отдельном пакете.


Unfortunately it is not enough. The build still even after it is installed - it is due to the missing TFS assembly.


Lista înlănțuită nu-ți oferă acces în O(1) la orice element. Mai gîndește-te, cum poți face dimensiunea variabilă. Care să fie ce problemă cu T this?


Yes, but not all are using gitextensions for the initial clone.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This my commit that you didn't manage to merge/debase?


Wrong place


Ok, thanks.

On 28 April 2015 at 22:34, Oğuzhan Yiğit <notifications@github.com> wrote:

> Testing it for 8 hours and initial feedbacks are positive. Device is more
> responsive now and multitasking is better
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arco/android_device_samsung_ancora/commit/0f48d523d12b7e452bdd0494a0cced48f00f4f79#commitcomment-10950799>
> .
>


rax retry tests


Correction needed:

```js
Greeting[Symbol.hasInstance] = ..
```

won't actually work. The `@@hasInstance` property on `Function.prototype` is `writable: false`. So, this must be:

```js
Object.defineProperty( Greeting, Symbol.hasInstance, { value: .. } )
```

Sorry for the mistake.


Update Issue #6


When I update to the latest snapshot I see tests failing with the following error:-

java.lang.RuntimeException: java.nio.file.FileAlreadyExistsException: /<some_build_path>/tmp/android-tmp-robolectric5846755880819917089/Download
	at org.robolectric.shadows.ShadowEnvironment.getExternalStoragePublicDirectory(ShadowEnvironment.java:52)
	at android.os.Environment.getExternalStoragePublicDirectory(Environment.java)


this should be `...` not `self.TYPE.void`


Great Work @ohler55 , Thanks


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This doesn't work because enum values cannot have spaces.


Fixed, thanks Kyle :)

On Wed, Apr 29, 2015 at 9:17 PM, Kyle Simpson <notifications@github.com>
wrote:

> Correction needed:
> ```js
> Greeting[Symbol.hasInstance] = ..
> ```
> won't actually work. The `@@hasInstance` property on `Function.prototype` is `writable: false`. So, this must be:
> ```js
> Object.defineProperty( Greeting, Symbol.hasInstance, { value: .. } )
> ```
> Sorry for the mistake.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/babel/babel/commit/2952d94e60a942aad198a1596d883a1008fc0498#commitcomment-10971985


Andrii looked at it and decided it wasn't a good fit in this specific case. We can revisit later. The current focus is getting it out of the door.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


For Problem3.rb, while you hare access to the Prime file... this is the problem solved in 1 line:

puts Prime.prime_division(600851475143).to_a.max.first


Yes, the perm-gen issue should go away when switching to the docker paradigm.


Would you terribly mind making it more of a self-contained commit message? I would really love to see what the commit is about, without having to click a link (which I sometimes cannot do because I often work offline). Thanks!


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Aici ma refer. Nu imi dau seama care e bug-ul.


indeed


@JanaVPetrova :)


Contexts should be real, one expectation per test.

    context 'duplicate email'
        it 'does not create the user'
        it 'provides an error message'
        it 'renders the new template'


Story now moved to
https://github.com/openlayers/ol3/issues/3648

On Wed, Apr 29, 2015 at 7:33 PM, Marc Jansen <notifications@github.com>
wrote:

> Hey @bill-chadwick <https://github.com/bill-chadwick>, would you mind
> taking this discussion, and your findings, to a new issue?
>
> There is a chance that we may eventually fully support windows, we
> actually want to, it's just that the absolute majority of the ol3 devs
> aren't working on windows. If you can gather all changes needed and create
> a PR, we'll definitely review and possibly merge it.
>
> Thanks for your patience.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openlayers/ol3/commit/5522f053335f1b7d4cfc2c16e4b3f1a1163fd4e5#commitcomment-10969863>
> .
>


nice!


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


As I said on the thread, I don't think we should specify how invalid inputs are parsed, feel free to comment out these


See #3.


I don't know how to repro this yet! I can however work on this sometime, and add more information with repro steps/fix. But I can say that my app is working with vertica_python upto version 0.2.3 and when I did an upgrade to 0.4.1, it broke totally. And in all instances, it is either NoticeResponse or CommandComplete.


Yeah interesting. We could probably just get rid of the reload configuration and document that you can call updateConfiguration with the same configuration to reload. This feels a little more explicit, but also a lot more code and tests.


I don't think that returning constant from function is a good idea.


Actually, on further thought — the blocker to using updateConfiguration as reload is that updateConfiguration attempts to be smart and only re-layout the components, not regenerate them, if the component provider and context are the same. Reload explicitly wants to override that behavior. So i'd like to keep them separate for now.


Yeah I'll wait until it's in serious use before optimizing.


analysing=analyzing?


Fixed locally.


Excellent!


Yup. I feel the right way to is to import setup from setuptools, because the requires filed is useless while the setupttols provide a install_requires that just does the work. But that implies a deeper change of setup.py and I am no a big fan of changing this before a stable minor release. The requirements.txt looks enough to me, or am I wrong?


Right now logic is next: look for the first installed ntp server and try to start it.
Nit: In case if several ntp servers are installed, but only one of them is used,  script may try to start wrong server.
I saw it while was testing this fix in #3363.
It can be treated as user fault: having several ntp servers installed does not have real practial use as I see.
But if you want to handle this case too, I would suggest to modify logic to check at first if any of $ntp_servers is running.
if yes we are done.
If not we can fallback to current logic.


There's really no need for visuals, collisions and mass for the thrusters. They are embedded in FlatFish's body, and you can look at the link's frame in both Rock and Gazebo if you want to visualize the thruster positions. As for the mass and inertial properties, we'll embed them in flat fish's body as well for the time being. If you really want all of these, then *yes* you should create a separate model and \<include> it.

Removing them helped me understand what was wrong: you never set the link's pose ! No wonder that it always thrusts in X direction. You seem to set them for the visual and collision tags, but not for the main link tag ! You needed to do the opposite !

```
<pose>-.5 0 0 0 0 1.58</pose>
```

in the definition of the Z thrusters and it should be fine.

Finally, the joints need no pose. You might even be allowed to remove the xyz tag in the axis.


თუკი რაიმე სტილის არ გინდა გამოიყენი, მაგრამ დოკუმენტიდანაც არ გინდა ამოშალო. გინდა გეწეროს მაგრამ ბროუზერმა არ წაიკითხოს და ვიზუალურად არ გამოსახოს, ანუ კომენტარის სახით იყოს იყენებ არა // არამედ /* აქ კომენტარია, და წებგვერდზე არ ჩანს*/
![screen shot 2015-04-30 at 00 29 00](https://cloud.githubusercontent.com/assets/1939548/7400720/fd61559c-eecf-11e4-9dda-1a91f0da8eb3.png)


Yep sgtm just thought I'd mention it in case it hasn't been evaluated

On Wed, Apr 29, 2015, 13:21 M-A <notifications@github.com> wrote:

> Andrii looked at it and decided it wasn't a good fit in this specific
> case. We can revisit later. The current focus is getting it out of the door.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/luci/luci-go/commit/d834578e42ee5ff8669c325d88315acba5a35575#commitcomment-10972059>
> .
>


No more preferences and no more framerate limitation :cry:


@eregon @nirvdrum @bjfish

This merge updates us to the 0.7 version of the Truffle API. There are some significant changes, especially in the guard syntax and node copy constructors so you may want to browse and learn about them. There are some new features we aren't really using yet but will start to experiment with.

You may want to via the raw diff at https://github.com/jruby/jruby/commit/ad4ba4b4f8c5b54af2409314e8c8e6d582dfce40.diff rather than the GitHub UI, as it's so large.

I'm going to start a few days of big refactorings, now that we are merged and we no longer have branches with large diffs between them.


or maybe I should just try to port to setuptools...


Podemos agora criar o Branch desenvolvimento. Manter o master estável e trabalhar com um fork do desenvolvimento. Esse negócio do gitignore vamos melhorando


I like that a lot better - THX :+1:


By all means sir. ^^


@roland-d @Erftralle Can you check/advise if this change is B/C compatible?


TYPE


Thank you!! Well done  :)


@andreturket ask @ShevT for some question. i dont know very much :)


In fact, it looks like many of these comments should be updated.  It's clear they assume that upstart or systemd is going to be part of the init process somehow.  Since currently this config file is just for the init scripts that's clearly not going to be the case.


On my machine (Ubuntu and Windows), FPS capped at 60Hz

Preferences don't work under Windows since Java8, not my fault.


Yes. The zfs-common takes this into account. But that file isn't installed automatically.


rename it to update_castling_rights


It's meant to be replaced with a valid type i believe, hence why it's caps as are the types.


Looks good- merging initial migration.


Is this an auto translation? ;)


This commit has changed every member variable to have a underscore as a prefix. Do you have R# set up differently?


Just checking... is `$.hide(..)` creating a `writable:false, configurable:false, enumerable:false` descriptor here?


Hooray.  I should be able to finally move my JRuby src dir back to my encrypted home directory.


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It just looked a little better (more 'compact') this way, but I've changed this. Didn't turn out to bad.


Sensible defaults


Why? If this is Eclipse autoformat, either IntelliJ users or Eclipse users must change this conflicting behaviour.


blank


LGTM Merging


Why does this LOCKDIR differ from that in the defaults file?


You may actually add that spring/ directory to the .gitignore file, so it's not part of your commits. It's something used by cloud9 that's not useful to the Rails app itself.


Well that would make sense if that was any kind of standard. But it's not, and there's nothing mentioning it in the meta here


@FadyKesbra  Approved


Why two whitelines? For the remainder of this file.


I think the idea is/was that the systemd scripts should use this file as well for some of it's information. Don't know if that's actually the case, but maybe they should?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.3](http://teamcity.monogame.net/viewLog.html?buildId=6538&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


You could switch this one to SVG too, or just use shields.io for consistent badges.


yeah let me work on the doc for the schema too -- lots of places where code and doc are out of sync.


Whitelines :D


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


@Flet broke up some text according to your suggestions 364667cf94a37e75c63a46414080863b3dcd4be0


> returns the damage by a given damage type
Is that not clear to most folks?


Misstake probably..


Why is this check needed?


Init


remove this line


I know about `writable:false, configurable:false`, currently it's `true`, it's test version, if you wanna - I will fix it now.


as a drop-in replacement, this doesn't appear backwards compatible. I am getting some unresolved roots.

Quick example app: https://github.com/stefanpenner/watchproject-test

I'll open a formal issue later this afternoon/tomorrow morning


as copy_modules will copy the module itself (for correct $MODVER

just correct typo -> dm-mod (not dm_mod)


As putea sa pun in loc de campul T[] list sa pun List<T> ?


Can we keep this early return? I worry that this will break if for some weird reason the root node gets added as a candidate.


<.< I'd assume not. That was just nonsense to me


@jongerrish Seems to be a bug in ShadowEnvironment.getExternalStoragePublicDirectory(String) were we try to create it each time. Revert now if you have too otherwise I'll fix tomorrow.


Can't remember, but there was some issue we (you and I I think) talked about a year or so ago… But looking at it again, it doesn't make much sense. I'll remove it.


Ah no way - the null vs Option is quite a refactor. Just learning now about Option types in Scala and it's really cool !


`urlparse` exposes a `urlunparse()` function that should do most of this work for you. N.B. that it moved from `urlparse` to `urllib.parse` in Python 3 so you'll have to do import try/except trickery.


LGTM


@jo-me Resolved this issue this morning, thanks for calling it out.


@robclewley , this is rollback of commit 1e907081e2aa807. are you sure?


I mean outputs for custom config


I propose to make something like this `RDFSource#humanize`


nice


isn't  this while useless and can even prevent exiting if exit code = 0  as never sem will be posted again


Oh, now I remember! It was when I had problem with my pool, and I wanted to boot the system, but NOT have it import the pool or load the module. I wanted manual control over it to not 'stress' it unnecessarily.


@ketch This is awesome. I must get back to work and contribute to this project.


/!\ Do not modify delegates, it is readonly /!\

Create a new temporary delegate


pidof() does not work here. We need to find an instance of rpcbind running in namespace $nsname


Some changes were made at @a287f3717ae369ea62572ee2e2daa430092cce91


おほー勉強になります


@z2v thanks - I was trying to do too many things at once today. I'll fix this in a minute.


Fixed typos in to-ruby-from-perl


Add comment "it should never happend"


@lexs Thanks for the quick response, I'll wait for your fix tomorrow, I still have a bunch of failing tests due to the Scheduler behaviour change.


@space-is-hard I'm going to do a code review of this lib.
1) The name of function (`LAZcalc`) is not specified in the documentation file


Good point.  One moment.


Hey, bitte die Methode in kleiner Untermethoden unterteilen.


For Sphinx to pick this up, the document must have a title it turns out. You can add one by adding:
```
=============================
Requirements for Installation
=============================

```
at the top of the file.


Oh, I see.  This is one of many checks which were brought in from the Fedora init scripts.  Unless this is functionality is needed on Debian for some reason I'd be strongly included to drop all of this.  Since Fedora moved to systemd many releases ago this code has been unused for a long time.  I would say that all that is strictly needed can be found in the existing zfs.redhat.in script.


This hunk should definitely be dropped.  ZFS has been added to the default SELinux policies and works just fine.


For this to be properly picked up, you'll need to add this below `:maxdepth:`, right above `api/index`. Also, instead of the plain phrase, this should be the filename without the `.rst` extension. In this case, `RequirementsForInstall`.


I have found the 3.0.1 source release in the github downloads, but it looks like there is no binary release for this version on http://osxfuse.github.io. Would it be possible to publish one? It looks like version 3.x might fix several open issues: #119, #130, #139 (already marked duplicate of #119, but not yet closed), #155 (including a $100 bounty), and #200.


this should be moved into the lang file


I added the /spring directory to .gitignore and it ran in c9.

It displayed correctly in heroku but I couldn't sign up or sign in

on sign in it couldn't find my email

on sign up it displayed the same error.

When I tried to signup on c9

I used the same email and it displayed a message saying I need to use another email just as it should.

When I did, it displayed the following:

Showing /home/ubuntu/workspace/code/new_options/app/views/devise/mailer/confirmation_instructions.html.erb where line #5 raised:

Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true

Interesting

Dan Williams, SIQ Agile Coach
CSM, CSP, PMP
Cell: 425-877-6333
________________________________
From: Jean-Denis Vauguet <notifications@github.com>
Sent: Wednesday, April 29, 2015 1:40 PM
To: danielwilliams12/new_options
Cc: Dan Williams
Subject: Re: [new_options] updated pid file (f430247)

You may actually add that spring/ directory to the .gitignore file, so it's not part of your commits. It's something used by cloud9 that's not useful to the Rails app itself.

-
Reply to this email directly or view it on GitHub<https://github.com/danielwilliams12/new_options/commit/f430247456e1d2c43de760f0bfdd04b9347de5b5#commitcomment-10972433>.


Why sleep?  Is this is ensure the /dev/zfs has been created?  If so that's worth a comment.


Can you think of any situations where someone would want `force=False`?


I think the option is valid. There IS a use-case for not 'enabling' ZFS at boot. And checking that all the needed components is there and working, seems to be a valid job to do...


Gîndește-te la posibilele calori ale lui `index`.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.3](http://teamcity.monogame.net/viewLog.html?buildId=6538&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 485, ignored: 6 Build time: 00:15:13


`curl -O` would save you from the redirect


@maikhoepfel: agreed regarding pytest


Ok, good.


This hunk would be good to drop unless you need to to support some specific supported configuration.


ah! good then.


Is that a super commit?
And are you making all processing on UI thread also written on the same file.


2) It's not mentioned that the target orbit altitude is measured in kilometers. Someone might think it's in meters.


FWIW I'd recommend using `0.9.0.9000` for the dev version, and dropping the date field.


I wonder, were there too many of these warnings so that you had to disable them instead of fixing them?


you are welcome. also arco how about rebasing kernel to LA.AF 1.1.1 it contains various memory fixes and other improvements for L also we are using updated media/display/audio HALs so ı think we should use new branch kernel for matching kernel and HALs

ım planning to do that but ım not sure what is your suggestions and plans?

thanx


Ai putea, dar ar însemna să „trișezi”. tocmai asta e ideea exercițiului, să vă gîndiți cum e implementat `List<T>`.


Unsure honestly -- If they overrode it somehow it'd still work; only the default value has changed.
Right now I'm trashing the deployed repo each deploy is prohibitive as I have to shell in, delete dir, re-run, wait for all gems, etc.


arg, luaL_setfuncs does not exist in lua 5.1!


Yeah, udevd (which is what I'm used to, don't know about any other) is sometimes a little … "slow". But I'm adding a comment about this. Don't know if one sec is 'enough' in all circumstances, but I haven't had any complaints so...


Ok. I was thinking maybe we could expose an option for it, but it sounds like perhaps we should just stick to `yes` and if it's a feature we need later we can add it.


Asa ma gandeam si eu :)


A merged pull request is always closed. Now I'm thinking of it, we could add an additional query that filters merged prs instead of closed prs. Then we do not have to filter the results. (And save some DB bandwith as well)


il faut laisser `data_init=""`, c'est un paramètre optionnel.

Comme ça on n'est pas obligé de donner en paramètre les données à initialiser (par initialiser, j'entends créer le fichier de sauvegarde et mettre les données à zéro) à chaque fois. Quand on a déjà des données de jeu sauvegardées, on va uniquement loader le fichier `gamedata.txt`, et s'il n'existe pas il sera créé et initialisé. J'ai mis ce paramètre optionel pour nous faciliter le développement en fait, comme ça on peut simplement tester les différentes combinaisons en donnant les données à initialiser sans devoir ouvrir le fichier et modifier les données ;-)


Is this array limited to 10 elements?  If so it is it possible to overflow?


Sounds good, and thank you for the consideration (and push to galaxy :))


after this line we need to add:

@post.topic = @topic


This change was exactly what I was looking for.  However, it seems to have broken md-Selects.  Are you seeing similar behavior?


solid start


@michaelscarabelli qui puoi trovare alcune modfiche fatte al codice.


This was the right action. See <https://forums.meteor.com/t/should-i-commit-a-generated-versions-file/3634>.


I think that part comes directly from 'someone else' (some other script or functionality and it looked good and safe to have there - there HAVE been reports of "some" distribution not having <code>/etc/mtab</code> as a symlink).

Since it's only run _if need be_, I think it should be safe as well as supporting dists that isn't … "modern" :)


This function looks to be unused.  Which is probably good because I'm not sure what the `mountinfo` command is or does.


Do you need to check context.getClientVersion(); before making this call?


lidl, just kidding, e_rect wouldn't be a nice thing to read in a source code


Not a hard requirement, but I'd feel more comfortable if there were a simple unit test to test this parsing code, rather than indirectly testing this through other code.


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


To the variable name or the actual metric name?


I think it should stay like this before the release to be sure we will not have errors anymore.
Lancelot said to me that we just need to change : `from distutils import setup` by `from setuptools import setup` and everything works. I hope it is true!!


ty!


Fixed.


Please add a tag. `git tag v0.1.8 bd70fba6230d9d7b5b915a73860ca3b411431e6d && git push --tags`


It's #define'd in luaT.h for lua 5.1. It's a little hacky since it ignores nup, which is currently always zero. An alternative is to do something like: https://github.com/colesbury/cutorch/blob/master/torch/utils.h#L23-L39


yay a good job :)


A possiblu unused function if you determine that you can drop the /etc/mtab hunk above.


**Authentication


lets remove all this whitespace from the bottom


rax retry tests


also the following change can be possible workaround for display on problem while in off mode charging
https://github.com/OpenDesireProject/android_system_core/commit/35493c4c327406a46c32a219db4be30cad5a0256


Are you assured that "factory" can never be NULL ?


This modification changes behavior and breaks previously working API. Before the function accepted `str` and `bytes` now it only accepts `bytes` with Python 3. Is this an intentional API change?


Remember, the whole point of this PR is to have _ONE_ script for everyone/everything so we don't have to write special script for special cases/distribution and end up with 'a bunch' to support. Eventually, yes, maybe this will grow out of control, but we can cross that bridge if/when it happens :). If it's not "in the way", I'd like to keep it. Unless we find out this will NEVER happen...


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


same thing here remove all this whitespace


Do you need to check *clusterName here (not an empty string)?


No. Whenever a request has the Wuid, we should handle it.


Agreed. No idea where that came from Possibly from Gentoo. @ryao, is mountinfo something you recognize?


Review complete, just a few questions


Makes total sense, I didn't see it in the PR...my bad. :)


Do we have a systematic way to catch this? I've seen small patches in a few different places that make this change. Is there a way to pre-emptively catch all such instances?


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


No overflow. So far, we only have 5 at most.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.4](http://teamcity.monogame.net/viewLog.html?buildId=6542&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I suppose (upcoming) should be removed


looks good - go ahead and merge


pay attention on the -e nature of running hooks

non existent CMakeCache.txt will cause STOP on whole script (and $xbiangit run).
so either keep the negative approach
[ ! -e CMakeCache.txt ] || rm -f CMakeCache.txt

or just put || : at the end of line
if it is not error in practice


@hadley Thanks


For status, use `git status --porcelain` (list of files added/deleted/modifed/untracked) and assert the output is empty.  Also make sure the output of `git branch --no-merged origin/master` (local branches not merged to remote master) and `git stash list` (stashes) are both empty.  We could still lose data in submodules (branches/stashes) or ignored files (mostly build products, I would guess), but I'm not very concerned about that.


same here


The problem is that if this filed is copied into `/etc/nixos`, then the reference to `amazon-image.nix` which is under the `nixos` directory does not refer to any valid path.  The only way to find a valid path is to refer to `<nixos/…/amazon-image.nix>`.


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Shouldn't the condition be
```C#
if ( item.ShouldFormatOnCommit ||
   ( commitChar != null && formattingService != null && formattingService.SupportsFormattingOnTypedCharacter(document, commitChar.GetValueOrDefault())))
```


From my experience in other languages: It's often better to throw an exception (`print "your error message". set x to 1/0.` for instance). "Errors should never pass silently" (from Zen of Python). If something throws an exception the user knows that he had done something wrong. If it just substitutes insane values with sane but quite possibly undesired alternatives it will give a wrong result and it may take the user quite some time to figure out why it isn't working the way it's supposed to.


I get that it gets copied, but don't get why it leads to infinite recursion instead of just complaining that the file isn't there.


Hey Jim, for the S3 functions, should I put @param and @return information for both the initial function and the specific function or no?


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I haven't seen any place in our code where we check the "factory". I assume that it is never NULL.


Yes, i think i prefer this way. Our packages use right now luaT, so you could also define luaT_setfuncs which calls the 5.2 one, if using 5.2 and emulates it, if using 5.1.

If we get rid of luaT later, that would be a problem though.


I think you're missing a bit; watch-project will tell you a relative path that you should use to offset your subscriptions and responses.

the example here shows how you might use this:
https://github.com/facebook/watchman/tree/master/node


humanize() doesn't print a string, it just returns it.


@xiazek Done, just released `v3.0.7` which contains this fix.


develop (totalgee) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


+1 for pytest too. It's literally my favourite python library of all time.


I prefer `local ... is ...` because it looks more like a complete english fraze. But It's just me. You may use any notation you like.


man l
looks good !

I will try v15 imx as soon as I finish migration rpi into rpi2 native package on jessie debian.


why backticks? don’t apostrophes/quotation marks work?

also we should use a common coding style: R usually does spaces around every `=`, and assignments are done with `<-`, not `=`.


it's a typical Emacs thing :)


It should be better if I check the *clusterName here. I will fix it.


Currently we do this:

var url = require('url'),
       connection;

i.e. full definitions first, then empty definitions later, usually one to a line - it's easier to pick out the variables that way.


Can we add a comment along the lines of:

> Don't return any tokens, because returning tokens after expiring the net creates new Redis keys that won't expire.


It's nothing major, just a code style thing.
[JSHint](http://jshint.com/docs/options/#sub) and [JSCS](http://jscs.info/rules.html) default behaviour is to favor dot notation over brackets notation.
Three less characters, slightly easier to read and it's consistent with the rest of the code.
Feel free to revert it, if you prefer.


This is where there could be a potential bug in the subtract of spectra. for example with obsid=268439129.

we should replace with:

    try:
       # he - ce
       ds_temp_cal = ds_he -  ds_ce
       # hf - cf
       ds_line_cal = ds_hf  - ds_cf
       ds_res = ds_line_cal - ds_temp_cal
    except:
       print "Bug that spectra can be subtracted but can be added : %d" % (obsid)
       # he - ce
       ds_temp_cal = ds_he + (-1.0*ds_ce)
       # hf - cf
       ds_line_cal = ds_hf + (-1.0*ds_cf)
       ds_res = ds_line_cal+(-1.0*ds_temp_cal)


Empty String as value field doesn't produce any result, but also doesn't throw an error in current version, so I guess it's okay if we leave it.


The only thing I'm worried about is that somebody will try to use it to launch directly east from stock KSC by inputting 0 degree desired inclination, but since KSC doesn't lie exactly on the equator, it would throw an exception. This would require the user to know and input the exact latitude of their launch site if they want as close to an equatorial orbit as they can get.

Any ideas? I could put in a check to see if the desired inclination is within a certain 'fudge factor' percentage if the user is trying to launch to a lower-than-possible inclination, and set it to ship:latitude if so.


I haven't figured out a good way to fix these warnings. We have case labels that have computed values, like:
    case NodeTypeForItemKind(DataImage::ITEM_MODULE):
which gets expanded into
    case ((ZapNodeType)(ZapNodeType_StoredStructure + DataImage::ITEM_MODULE)):
The result is an enum value that doesn't have a corresponding enum constant, and the compiler issues a warning for that. I haven't been able to find a way to silent this warning.


Definitely, good catch thanks.


double `link_to`'s


ya, caught that.


@rift137 this doesn't work apparently. I am getting this error.

```
Mongoid::Errors::AmbiguousRelationship at /articles

Problem:
  Ambiguous relations :authored_articles, :authored_external_articles, :articles defined on Person.
Summary:
  When Mongoid attempts to set an inverse document of a relation in memory, it needs to know which relation it belongs to. When setting :people, Mongoid looked on the class Article for a matching relation, but multiples were found that could potentially match: :authored_articles, :authored_external_articles, :articles.
Resolution:
  On the :people relation on Article you must add an :inverse_of option to specify the exact relationship on Person that is the opposite of :people.
```


No, it has not been released yet (well 1.6-alpha-1 has).


Bieeen!


Thanks @j-white!


does the generator created also in case who we trancode the stream ?
Because before/after stream, it may necessary to access to it also.


BTW prefer to get inline notes via the PR rather than via the commit—GitHub handles it better.


Should we replace `#ifdef ENABLE_VDSO_CHECK` with `#if defined(__i386__)` instead?


Anyone have success on compiling it on Ubuntu 14.04 and Indigo?

I always get errors related to vector or feature2D:
~~~
In file included from /usr/local/include/opencv2/nonfree/nonfree.hpp:46:0,
                 from /home/qiang/rgbdslam_catkin_ws/src/rgbdslam_v2/src/misc.cpp:45:
/usr/local/include/opencv2/nonfree/features2d.hpp:73:21: error: ‘vector’ has not been declared
                     vector<KeyPoint>& keypoints) const;
                     ^
/usr/local/include/opencv2/nonfree/features2d.hpp:73:27: error: expected ‘,’ or ‘...’ before ‘<’ token
                     vector<KeyPoint>& keypoints) const;

/usr/local/include/opencv2/nonfree/features2d.hpp:76:10: error: ‘void cv::SIFT::operator()(cv::InputArray, cv::InputArray, int) const’ cannot be overloaded
     void operator()(InputArray img, InputArray mask,
          ^
/usr/local/include/opencv2/nonfree/features2d.hpp:72:10: error: with ‘void cv::SIFT::operator()(cv::InputArray, cv::InputArray, int) const’
     void operator()(InputArray img, InputArray mask,
          ^
/usr/local/include/opencv2/nonfree/features2d.hpp:81:5: error: ‘AlgorithmInfo’ does not name a type
     AlgorithmInfo* info() const;
~~~
I even tried to add #include <vector> to those cpp files.

Thanks!


After init commit: $ rake test performed: pass


Oh, so they do. I'd seen backticks somewhere, and just assumed that was the way to do keyword arguments in R. Are quotes preferred?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.4](http://teamcity.monogame.net/viewLog.html?buildId=6542&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 485, ignored: 6 Build time: 00:15:30


The prior work I did on the requirement for current ledger on RPCs removes the condition.


`glob` was removed in latest Ember-CLI.


Have you considered splitting this in to `zfs-import` and `zfs-mount` scripts.  This would allow the pool import and mount to be performed at different times during the boot.  One case where this is would be useful are legacy mount points as described in issue #3300.  This would allow the pool to be imported before /etc/fstab is processed.  Then slightly latter in the boot zfs-mount could be run to add the remaining zfs managed mounts.


Tamén mellorei o sistema de creación de bloques mentras se xoga.
Segue sen ser moita cousa, pero mellorou bastante.


I think the latest Ember-QUnit now uses `beforeEach/afterEach` over `setup/teardown`.


Hmm... you mean the numpy det method isn't well optimized enough?


I think it's still a good question as even I didn't know why anymore. I'll try to add a useful comment.


I don't have this in my configuration.  I have the approach merged from https://github.com/GoogleCloudPlatform/kubernetes/pull/6890

Doesn't that supercede this?
-------- Original message --------
From: António Meireles <notifications@github.com>
Date:29/04/2015 16:23 (GMT-05:00)
To: AntonioMeireles/kubernetes <kubernetes@noreply.github.com>
Cc: "Hobbs, Timothy" <Timothy.Hobbs@ca.com>
Subject: [kubernetes] explicitly name etcd nodes. (313e2e5)

explicitly name etcd nodes.

addresses issue catched by @hobti01 in ongoing review

Signed-off-by: António Meireles <antonio.meireles@reformi.st>

---
Reply to this email directly or view it on GitHub:
https://github.com/AntonioMeireles/kubernetes/commit/313e2e51dce21533027f53fd4be0de96d715f392


Typo on line 199:

+  Core.Persistence.setConfig(configuration.persi:0
+      stence);


Add "starting from zero"


Remove


Этот импорт необходим


@seandst: This tempts me to smuggle

```python
def __nonzero__(self):
    return self.rc == 0
```

into the SSH client's return value to make it directly usable in the logical expressions, but that would require replacing `namedtuple` with proper class ...


Another good reason to have a `.lsb` and `.redhat` version of these scripts is that it's entirely possible, maybe even likely, that we'd want these scripts to run at slightly different times during the boot.


Правила не нужны


Change link to http://www.apache.org/licenses/LICENSE-2.0


shouldn't this be in test/driver-null.js, or something?


This is corrected. You should review the PR diff: https://github.com/zendesk/radar/pull/133/files


Now `38`


may be intersting to switch following methods to insert with the same way each property.
What do you think about that ?


Было б неплохо добавить комментарии, что обрабатывают эти исключения


Don't bother with this please, I've already changed the patch locally, I'm just waiting to check if it works for the nightly builds before pushing it out.


10/10 super, would codereview again


@celopez1990 podes hacer deploy a heroku, te di acceso.


We normally don't set this because Maven (and IDEA?) use this name in places where you really want the module


:beers:


We should also print the errno on failure.


Тройные кавычки используются для докстрингов


Haha uh, doesn't this do the *opposite* of what you want?


You should also follow redirects


I would a comment here to detail why we assume that the status is COMPILING when there is not SubmissionResult (i.e., because it is created during the compilation, I think).


Or set it to `parameternames`


Should I leave this here, or simply refer to the doc?


make public


This is presumably used in the additional initrd patches?


I don't think this one is necessary


This is a handy bit of functionality.


Ok, maybe that is not really necessary, but my personal philosophy is to add comments every time you are relying on some behavior that is not obvious from the code there around.


This isn't in airbase yet


Complex to mention where we need to place it ... :-P


Added luaT_setfuncs

On Wed, Apr 29, 2015 at 5:12 PM, Ronan Collobert <notifications@github.com>
wrote:

> Yes, i think i prefer this way. Our packages use right now luaT, so you
> could also define luaT_setfuncs which calls the 5.2 one, if using 5.2 and
> emulates it, if using 5.1.
>
> If we get rid of luaT later, that would be a problem though.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/colesbury/torch7/commit/1c23e04bd9801b59abd9fb9fed80f9897fa7a362#commitcomment-10973120>
> .
>


I thought this was originally my/bookmarks/liked, or my/liked. Now that I see what you are trying to do, I get what needs to be done. You can remove these routes (the liked and added), and you can remove the get 'users/show' as well as it is taken care of by the user resource below.


Put on previous line


What's going on here?

I don't like the idea of code that isn't being compiled.  Why check it in?


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Looks like you forgot to remove a few debug prints :)


1) Всё ещё осталась логика одиночной игры
2) Слишком длинные, на мой взгляд, названия переменных\функций. Можно, например, multiplayer записать просто как mp


That should be {0x40} instead of {0x400}.


develop (totalgee) - x86_64-MacOS-10.9-clang: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is a great step forward! I suppose that changing border widths will be more difficult but I love the idea of starting with border, background colors for now. Unfortunately the way our css modules work, we need to have any css class referenced outside of the local files to be "public" (prefaced with "public/". Can you make these changes and update the callsites that reference them?


Wouldn't this fstab problem just solve itself by splitting the init script as described above?


Missing period


Are we sure that it'll never go below -360 or over 720?


"Note that"


Also it's good to associate the actual interface/class name with those enum values, and override `toString()` to return the names instead of the all-capital value names.


Interesting, you should also look at:
https://github.com/stawel/cheali-charger/blob/master/src/hardware/nuvoton-M0517/cpu/CMSIS/Device/Nuvoton/M051Series/Include/system_M051Series.h#L39-L40

originally it was set to 12MHz, now need something more generic.

unfortunately the pull request will have to wait a while (about 2 months), I'm currently quite busy
and don't have the time for testing.

ps.
If you need some help with the P1.2 pin we can try to solve it together over skype,
but I must worn you, I don't speak English ;)


If your going to add that please consider linking to the Git website under the windows section or using sourcetree. github for windows is horrible.


```
% go test
```

:8ball:


This is another good reason I hadn't thought of for splitting the script.


Could you use the API to serialize the current state of the Optimize context to an SMT string before the problematic calls? The API is called Z3_optimize_to_string. It would help with a couple of such benchmarks that I can integrate in a regression suite.


this mesa feature should get more attention:

https://springrts.com/phpbb/viewtopic.php?f=12&t=33437&p=569260


Inline


To the variable names.


Hi @jeroenbreen, I fixed this also just now with a pull #554. Think it is slightly more elegant because it allows for greater precision during manual input and has various amounts of decimal points. Also rounding won't add zeros. :)


Good point @rohgarg. We also need to do mtcp_memcpy *after* checking the return value of mtcp_sys_mmap or else we'll segfault without seeing the error message.


why is 'extended' an argument here? the format string doesn't display it.


saw approval from fadushin
at https://github.com/basho/yokozuna/commit/9203f45a40c89c953063ca58721dd27fdbf4bc87


It's right to do that.
Initially it was planed to have the possibility to get a FileProperty, to edit it and to give it to the OutputFile.
But I don't think it make sense now...


merging basho/yokozuna/perf/zl/use-mochiglobal-for-extrator-map = 9203f45a into borshop-integration-483-perf/zl/use-mochiglobal-for-extrator-map


basho/yokozuna/perf/zl/use-mochiglobal-for-extrator-map = 9203f45a merged ok, testing candidate = 84af6170


I reverted a change you made in [this commit](https://github.com/lutris/lutris/commit/261f8103ab2f1a272794523d01fa8ff591bd35d9) which made runners' installation fail. But it also made the dialog modal again, freezing all other windows until the download is finished, which isn't cool.

How to make it block the installation process but not freeze the main window, that, I do not know.


Is this really neccessary? Since the `ruby21` package provides `ruby=2.1` it should be fine, shouldn't it? Are there other reasons to maintain two rubies on one machine? Personally I build my own ruby (in version 2.1) package on my server and I'm fine with that.


1. If the desired **altitude** is negative something is definitely wrong.
2. If you think that it's better to correct the inclination if it's too small / too big this behaviour should be documented.
3. However it than probably should correct too big inclination to the different value (180 - SHIP:LATITUDE). Am I missing something?


Unfortunately `etree.tostring` seems to return bytes in Python3 so there is no way around.


...Yes, yes it does.  TEST COVERAGE< WE HAVE IT


Should the help text be re-phrased to be something alone these lines: ?
 "Policy Targets created for the LB Pool Members should  not include this
 tag in their description"


@jamierocks As we discussed in the PR #176, it isn't for us or anyone to decide on which program to recommend. People are very capable of finding their own client they wish to use from the git website just fine.


This is documented as being able to return null


Should this be `mtcp_sys_mmap(vdsoStart, ...)`?


Read this too late. Anyway the change doesn't even show up here, though I expected it would automatically since it was done on the same branch.


Does the stream duration is every time filled by FFMpeg ?


This was actually necessary. I discovered that when I included my fork in my Python 3 project and ran my test-suite. My project uses Vagrant and inside the container I used Python 3.4.0 wheras I used Python 3.4.3 when I converted `readability-lxml` to Python 3. I have no idea way they suddenly decided to re-allow the old `raise` syntax in 3.4.3 but so be it. As a benefit this now also works on Python 3.3.


Byte at a time


VSync support is actually *driver dependent* from your video card. For instance, on my NVidia high end card on my deskop, the driver was set to vsync on by default. On my laptop with my intel internal graphics, I had to setup this manually (with the driver). I don't if there's a way to force this otherwise...


`etc/init.d/default` should be added to the EXTRA_DIST and the Makefile update so it's installed in the correct location.


After thinking about this a bit more, I'm not sure returning a `Promise` here is right.

That would make this the only async method that is promise-based which is a bit confusing considering all the other async methods take a callback.

I'd like to make this be callback-based as well for consistency.


Seems that 64bit binaries are overwritten by 32bit ones.
Is there someone who knows how "emul32" works?


Is it possible to add an enum to do that ?
It's very FFMpeg dependent code ....


Fixed.


<!DOCTYPE>


If the mmap above fails, this will result in a crash. I think we should move the memcpy below the if clause.


n and v the wrong way round, should be "dnvm list" :-)


Add a static method too


Also add a test for an abstract class and interface


This was also discovered when I ran my test-suite. This will now fail if someone calls `get_encoding` with unicode data, but the code inside `readability-lxml` doesn'T do that. And I think that if you merge the "UnicodeDammit"-PR this code will actually be removed.


@rohgarg: you are so right! Thanks for catching this. Looks like I did a poor job at reviewing this code :-).


This does not account for months before June of the current year. If it is February of 2015 the script should not display 2015 as a graduation date (because no one graduated in 2015 yet). Reverting in next commit.


is it possible to store the offset (or leaving frame to be processed), and don't call every time the compute of the stream duration ?


Even though the assertion from line 669 guarantees that the two will be equal, but I feel that using `vdsoStart` makes the intent clear to the reader.


Hey, did you do this becuase of rubyzip error "failed to allocate memory"?


Ahh good point.  Although at the moment that's definitely not true and I can see it causing confusion.  Perhaps it makes sense to keep this file sysv specific until/if the systemd bits use it.


Fixed in https://github.com/tes/bosco/commit/dabb7a48ea79e90a1436ecd7774f65f8a7d98bb0


Thanks, don't know how I missed this was messed up.


ok, but check also my latest commit at #515, repairing the blur.


develop (totalgee) - i386-Windows-8.1-VisualStudio-14: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1102


Then the question I guess is that something we still want to support / file useful.  I'm OK either way as long as we leave a little comment.


Looks good, but you should do `memo && !err && !stdout`.


It's not just about being clearer. The current one is wrong. The address rinfo->vdsoStart points to the pre-ckpt vdso, but we want to mmap the "post-restart" vdso (vdsoStart) instead. Similarly, the memcopy below should be copying from "rinfo-vdsoStart" into "vdsoStart".


Changed the bioData directory to be written to the root directory of the project, not the computer's root directory.


Little typo in this commit's message.


if we have an enum it's better here to make a switch :-)


That sounds reasonable. I'll see what I can do about that.


Documentation in the comments is ok as long as:
1. It is up to date
2. Everything is explained clear enough
In fact it's welcome because some users might download only the library. But it doesn't mean you may write a bad doc file because some users might just try to use your lib without looking into it's code.


I would _think_ but haven't verified that a `udevadm settle` after the modprobe would ensure we always wait long enough, but not longer.  Alternately, you could borrow the `wait_udev` function from `scripts/common.sh` and change this too `wait_udev /dev/zfs`.  That's a little better than just a sleep.

```
wait_udev() {
        local DEVICE=$1
        local DELAY=$2
        local COUNT=0

        udev_trigger
        while [ ! -e ${DEVICE} ]; do
                if [ ${COUNT} -gt ${DELAY} ]; then
                        return 1
                fi

                let COUNT=${COUNT}+1
                sleep 1
        done

        return 0
}
```


Is there no `delete $1;` required?


prefer default, we will update to 4.2 when ready

On Wed, Apr 29, 2015 at 7:09 PM, darix <notifications@github.com> wrote:

> for a packager, does that mean i should prefer rails 4.2 or still stay
> with 4.1 for now?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/discourse/discourse/commit/fd7c34cfa7dde2d3f7adc7e9773044cb193c9628#commitcomment-10959423>
> .
>


And then we're back to having multiple scripts to maintain… Which is the whole purpose of this.


Yes.


And I think it will be nicer in the future to
• integrate the step as a parameter property (line 4), so that is more flexibel when we add more parameters
• do the validating and rounding etc. via a function. Now we are using operator.low, but when we will be working with ranges there also is a operator.high. (At the moment the architecture isnt optimal...)


@SeanFelipe good for you, man! I just thought of a little more refactoring, like using match / case.
```scala
  /*
  *  return a random ship of the desired type that's in range
  *  0 = Fighter 1 = Bomber 2 = Frigate 3 = Factory
  */
  def getTypeInRange(source: Ship, shipType: Int, range: Float) : Option[Ship] = {
    val gameInstance = GameInstance.getInstance
    val shipsOption = shipType match {
      case 0 => Some(gameInstance.fighters)
      case 3 => Some(gameInstance.factorys)
      case 1 => Some(gameInstance.bombers)
      case 2 => Some(gameInstance.frigates)
      case _ => None
    }
    shipsOption.flatMap.{ships => getTypeInRange(source, ships, range)}
  }
```


1920x1080 can be replace by HD ?


Thanks


develop (totalgee) - Win64-Windows-8.1-VisualStudio-14: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Test


for DNxHD it will may non sense


same remarks as previous commit.


gnosygnu tried to add dvdnav_jump_to_sector_by_time (if it's not exported correctly, I'd report that to the libdvdnav mailing list).  Anyway I've used it and it actually seeks using the headers and to the right timestamps (at least typically) for me.


Yes, it is arguably useless now, however it cannot prevent exiting since
sem_post() is only called in request_exit(), which is never given a
non-zero value to assign to do_exit. The while loop was probably there to
handle spurious wakeups from pthread_cond_wait().

Regards,
Chris

On Wed, Apr 29, 2015 at 1:49 PM, michel <notifications@github.com> wrote:

> isn't this while useless and can even prevent exiting if exit code = 0 as
> never sem will be posted again
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/libusb/libusb/commit/a1c9895543b6aa3deb6e42e7be83121b28f298ce#commitcomment-10972712>
> .
>


No, because they solve two slightly different problems. That first part is for mounting zvols (with any FS) and the second is for ZFS filesystems/datasets. I guess one could/should combine them, but regexp have never been my strong suite..


2\. I think the way I'm going to do it will be like this (pseudo-code):

    if targetInclination < latitude and <= 90 {
      set targetInclination to latitude
      print "Target inclination impossible from current latitude"
      print "Setting target inclination to latitude for eastward launch"
    } else if 180 - target inclination < latitude and > 90 {
      set targetInclination to 180 - latitude
      print "Target inclination impossible from current latitude"
      print "Setting target inclination to latitude for westward launch"
    }

And I'll put it in the docs too. Sound good?


This will change the assembly name.  Will have to modify chef cookbook and jenkin build.  Do we really want to re-name?


I've created a test in PR #539 that would have caught this.


It will also require modifying the `query-coordinator` job in Jenkins (though, it would allow removing some special case code from `sbt-build`.)


AVDictionary** options = NULL
It will not break the API compatibility :-)


Fixed code format using eclipse built in formatter.


Added my name.


@alexjikim Your release cut didn't include this change.


But that would make this whole endeavor completely pointless…. Having ONE set of scripts, with different purpose. Not "a whole bunch" which is only slightly different. As one for each distribution. And not everyone have gone all-in on systemd! There's still a few bastions for freedom out there! :)


Could be also implemented using defaultValue, but this way I was able to demonstrate how to work different HTTP verbs.


It may make better sense to add our sample ad-hoc group to the "Quickstart" area of the data/, rather than the Default.


Doesn't seem like a good use of time doing that busy work unless there is a very compelling reason...


How do you mean?


I think that the issue was this: https://github.com/uber/vertica-python/commit/2e19d4924a43ea684760447320fe2558082029fd

The release cut didn't include that fix.


Specifying '/' as a context path still works but catalina's StandardContext converts it to an empty string and prints the warning. So existing app configs should still work.

Fixing that would be an ugly hack indeed because we'd have to subclass StandardContext: https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/core/StandardContext.java#L1948


I literally lol'ed at this.


Yah, OK, we can do that, unless there are multiple lines with null ID's :)

On Tue, Apr 28, 2015 at 6:48 PM, jiwu14 <notifications@github.com> wrote:

> If the ID in Providers.tsv is unique, then we can probably just toss out
> SourceID's auto_increment and have it accept the ID in the file as the
> value.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mikehas/MDM/commit/d0b104a7d7a57bbb843136037e984cb951a26c36#commitcomment-10955157>
> .
>

--
Michael Haskell
Telephone: 805.234.3743
Alternate Email: mikehaskell@gmail.com
San Luis Obispo, CA


nice catch.


I believe this was originally added to handle certain configurations where ZFS was used as the root filesystem on Fedora.  However, this script hasn't been used for that in a long time now so I've no idea if it will work as intended.  How about we drop it for now to keep things simple.  We can always add it back trivially if we discover a need for it.  It will be on the git commit history forever.


Yes, AFAIK the PR is good enough for #552 (I updated it). But #515 needs that extra bit.


Simpler to write (and understand perhaps), yes. But not to maintain. The five (!!) scripts that's there now started out as "slightly different" but are now quite (!) different. So whoever is adding support for THEIR distribution, isn't keeping 'the others' up to date on their changes. SOMEONE is lagging behind (considering the functionality of MY scripts, I'd say all five of them do :).


ya esta, es el mismo del grupo de lian, en la carpeta db


this could have an impact on performance (no idea how much though)


is it necessary to create a variable ?


Do we care about keeping the original error logging?


aaa


armorBase is an average of the Light and Heavy versions.


No, I checked (which is the reason I added the sleep). udevadm returns immediately and does not wait for success. And there's no way to tell it to wait for response from the daemon… There is an issue somewhere in the tracker about this.


Glad to see you (apparently) have your editor set to 4 spaces / tab (rather than actual tab characters).  I can't imagine we remembered to hit on those stylistic things while you were here.  We actually have a [uPortal Code Style & Conventions](https://wiki.jasig.org/display/UPC/Code+Style+and+Conventions) doc.


develop (totalgee) - i386-Windows-8.1-VisualStudio-12: OK (344 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.42%25-yellow.svg)


Sounds good.

Benito J. Gonzalez - Unicon
bgonzalez@unicon.net <mailto:bgonzalez@unicon.net>
480.558.2360

> On Apr 29, 2015, at 3:01 PM, Drew Wills <notifications@github.com> wrote:
>
> It may make better sense to add our sample ad-hoc group to the "Quickstart" area of the data/, rather than the Default.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/bjagg/uPortal/commit/43c830d9e4174b0136c78fb82e02fb401dd06451#commitcomment-10974049>.
>


Sounds good


https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/241 will eventually handle this - I've just not gotten around to doing this yet. TGMPA might make a good project to develop it against.


Compris :P. J'te laisserai finaliser pour la save donc si jamais, j'vais m'occuper du niveau 1 pour le petit gars et du 3 ensuite =).


Definitely my preference. Yes, I need to run through that doc here shortly. I just want to get some working code ASAP.

Benito J. Gonzalez - Unicon
bgonzalez@unicon.net <mailto:bgonzalez@unicon.net>
480.558.2360

> On Apr 29, 2015, at 3:05 PM, Drew Wills <notifications@github.com> wrote:
>
> Glad to see you (apparently) have your editor set to 4 spaces / tab (rather than actual tab characters). I can't imagine we remembered to hit on those stylistic things while you were here. We actually have a uPortal Code Style & Conventions <https://wiki.jasig.org/display/UPC/Code+Style+and+Conventions> doc.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/bjagg/uPortal/commit/43c830d9e4174b0136c78fb82e02fb401dd06451#commitcomment-10974109>.
>


Nice work picking up on the current preferences for logging, rather than (what I imagine are) the legacy logging in use within the rest of the groups code.


who cmake will update the version of python ?
I don't understand ...


Didn't know about this is preferred.  Should we start a new line on the 1st param too?


whoops, left over from debugging. will remove.


PAGS (stands for Person Attributes Group Store).


I looked at what it would take to change this to `system "make", "install"`. It would require a number of patches to the makefile in order to do the same thing. The existing definition feels like the more sane thing to do.


TeamCity Ember :: Build [Build 1](http://52.17.206.69:8111/viewLog.html?buildId=2&buildTypeId=Ember_Build) is now running


We don't do these $Revision$ things anymore (though you will see loads of examples "in the wild").


Maybe AdHocGroupTester?


Oh, interesting, I should've read the docs first. Strange that my testing didn't show any problems though.


What's the difference between `env` and `.servicetests_env`?  Is there something special about using `env` as a variable name?


I also changed icons T_T


But using wait_udev() is a good idea.


https://github.com/docker/docker/issues/8521
:(


Drat, that was supposed to say "Introduce `mkConnectionString`." Oh well.


pomogło ;)


For me it doesn't look like so, unless I am missing something obvious.

I have opened an issue with repro: https://github.com/uber/vertica-python/issues/55

Please take a look. I don't understand the vertica protocol yet to figure out a fix for this!
Hope it helps.


For my money, I'd make go with a `final` class and make all the members private (though you will find active community members who disagree).  I subscribe to the inheritance philosophy outlined in in Effective Java:  design specifically for inheritance (meaning your class is almost certainly abstract) or not at all (meaning your class is almost certainly final).


Really appreciate you fixing this. Even after officially no longer supporting OSS EPM.

Migrating to the commercial EPM for the deployment in question would have been a lot of work. Because of this fix we won't have to.

Thank you!


rax retry tests


Hahaha "//TODO implement this shit" :laughing:


already did in 018bc6b


There is no OpenSans font in the font/ directory so this is erroring out on all reports.


LGTM


Do we need [this]?


TeamCity Ember :: Build [Build 1](http://52.17.206.69:8111/viewLog.html?buildId=2&buildTypeId=Ember_Build) outcome was **FAILURE**
Summary: Will fail Build time: 00:05:35


TeamCity Ember :: Build [Build 2](http://52.17.206.69:8111/viewLog.html?buildId=3&buildTypeId=Ember_Build) is now running


Thanks. I think I screwed some other things up in this script too.  Still working to fix it, sorry.


codacy recommends this is the narrowest scope possible.


TeamCity Ember :: Build [Build 2](http://52.17.206.69:8111/viewLog.html?buildId=3&buildTypeId=Ember_Build) outcome was **FAILURE**
Summary: Will fail Build time: 00:01:09


There is no DejaVuSans-Oblique.php  but there is a DejaVuSans-BoldOblique.php


Excellent! Love this detailed information. Whereas the Regex Test class is extended for specific cases, we do not expect this class to be extended at all.

Oh, what is the preferred way to take a name like “Students” and get the group object?

Thanks again!

Benito J. Gonzalez - Unicon
bgonzalez@unicon.net <mailto:bgonzalez@unicon.net>
480.558.2360

> On Apr 29, 2015, at 3:12 PM, Drew Wills <notifications@github.com> wrote:
>
> For my money, I'd make go with a final class and make all the members private (though you will find active community members who disagree). I subscribe to the inheritance philosophy outlined in in Effective Java: design specifically for inheritance (meaning your class is almost certainly abstract) or not at all (meaning your class is almost certainly final).
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/bjagg/uPortal/commit/43c830d9e4174b0136c78fb82e02fb401dd06451#commitcomment-10974234>.
>


sweet - let's collaborate. Pull request me :+1:


@OscarSwanros You should submit a pull request to the main repo for this. I was looking for it.


Yes, you are right. I misread it. mremap won't make the two equal. I wonder how it worked though.

The memcpy below has the right source and destination.


The jar name doesn't match the project name anymore, after we split qc into two pieces.
In most places
`OVERRIDE_JAR_BASENAME=query-coordinator-assembly`


The script isn't really about simplicity. It's about portability.


That'd be a good idea :P


Don't hesitate to create a PR for such a new branch, right away after you pushed it. Makes it easier to discuss the changes and gain some feedback.


`return if data.tokens.length < 2` ?


I confirm it works


ah... here's another guide thing - the 'convention' is to break up the imports list into three empty-line-delimited segments (each alphabetically sorted, which gofmt does for you). Top section should be basic Go packages from the golang.org repo. Next section should be 3rd party packages, if any. Third section should be current project packages. In this case all that needs to be done is to move github.com/hblanks/pixel to the bottom of the list preceded by a blank line... no middle section because no 3rd party packages are imported.


could use a break somewhere


Really, can't this be in one line?


It will be quite easy to add it but when this string will be print to the user? With the ` --help` option or when the exception `argparse.ArgumentError` is raised?


Agree.

I have a few more go improvements I'll probably post tomorrow (syntax highlighting for raw strings and some tags parser improvements)


rax retry tests


<script src="https://gist.github.com/snwight/5f495c25933d11fb4b44.js"></script>


**Tl;dr>** fixed in c5ef1e7

The jar name doesn't match the project name anymore, after we split qc into two pieces.
In Cloudbees Jenkins the assembly used to be referenced something like `*/target/*-assembly-*.jar`
Then in Aws Jenkins the manual parameter `OVERRIDE_JAR_BASENAME=query-coordinator-assembly`
Then in Sea1 Jenkins the script included `
ASSEMBLY_BASE="query-coordinator-http/target/scala-2.10/query-coordinator-assembly"`


TeamCity Ember :: Build [Build 3](http://52.17.206.69:8111/viewLog.html?buildId=5&buildTypeId=Ember_Build) is now running


@sleepdeprivation can you take a look at this when you get a chance? setTimeout isn't working, even though it should, and the callback gets executed immediately, resulting the server using up its allotment of connection attempts ([if this cap wasn't there, it would keep running until it ran out of memory](http://serenity-valley.ddns.net/~derek/hermes-loop.png)).


@techee That would be great! Feel free to close my PR if you'll be including the tab change along with your other changes.


@usr110 impressively fast implementation - I've replicated it with` git checkout 30c3648` (still learning git!) as shown. My feeling is that it's too brutal - adds rather than removes complexity and could cause confusion based on the image below - so agree with @nikolai-b's revert. I think a popup triggered by lines saying that you can set zones to transparent if needs be would be better. Would it be possible to reduce zone fill opacity when lines are activated? Either solution would work.
![selection_189](https://cloud.githubusercontent.com/assets/1825120/7402786/5c7ac97c-eec7-11e4-8b4d-e146d4ce349d.png)


It's not the ideal, but it's probably more practical and maintainable.  Particularly if we limit this two just the two variants proposed.  If they were combined I'd always be worried about accidentally breaking something unless it was tested on both platforms.  Plus this allows for:

* Different default start/kill levels which could easily differs between Debian and Redhat.
* Avoids the use of complicated logging wrappers.
* Distribution specific customization can live in one place, the zfs-common script.

That said, if you really don't like this plan we can try working through this with them all in the same script and see how ugly it gets.  :)


develop (totalgee) - x86_64-MacOS-10.9-clang-Debug: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I don't believe we have anything that will send more than one value for the same key at the moment, but it's legal to do so in the spec. Is there a reason you added this check?


Tests, :trollface: ?


i think you have bug in this line   db = client.testdb
instate of u need to use db=client.iphonetweets


is it lat, lon or lon, lat? I thought we switched to have longitude first and latitude after.. These comments don't look right

```left,bottom,right,top``` indicate ```lon,lat,lon,lat```
```min lat, min lon, max lat, max lon``` indicate ```lat,lon,lat,lon```

They should be consistent.


Isn't this already in @Project Tako?


This should read:
```ruby
args = [command(:yum), 'check-update', '-d', '0', '-e', '0']
```
As it stands, `check_updates` will catch a bunch of debug and error info that `parse_updates` isn't equipped to handle.


The refactor/move of existing stuff looks good. A couple minor points on the middleware, and it needs to be reformatted to match PEP8 (4-space indents), but this looks like a good addition. Thanks for the work!


Right neither the `default` script nor any of the init scripts get added to the `make dist` tarball.  Adding all of the `.in` files to EXTRA_DIST will make sure they're included.


PDFDocs (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1641 of 1641 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi

Tnx I thought I fixed that already.

On Wed, Apr 29, 2015 at 3:29 PM, solankikrunal <notifications@github.com>
wrote:

> i think you have bug in this line db = client.testdb
> instate of u need to use db=client.iphonetweets
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/rraymondd/TwitterSentimentAnalysis/commit/407e4cfd045d5fe3c2f2248fd5109399fb95ef86#commitcomment-10974485>
> .
>

--

*Raymond Jamali* | I.T. Assistant

*[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
the future*

6505 Gayhart Street | Commerce | California | 90040

Tel: 800.686.6672 x172 | Fax: 800.500.9955
raymond@noralighting.com | www.noralighting.com

<https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>


Ah, ok.


ok !


Iphonetweets is actually the name of the collection. It's not a bug.

On Wed, Apr 29, 2015 at 3:30 PM, Ramtin Jamali <ramtinj1986@gmail.com>
wrote:

> Hi
>
> Tnx I thought I fixed that already.
>
>
> On Wed, Apr 29, 2015 at 3:29 PM, solankikrunal <notifications@github.com>
> wrote:
>
>> i think you have bug in this line db = client.testdb
>> instate of u need to use db=client.iphonetweets
>>
>> --
>> Reply to this email directly or view it on GitHub
>> <https://github.com/rraymondd/TwitterSentimentAnalysis/commit/407e4cfd045d5fe3c2f2248fd5109399fb95ef86#commitcomment-10974485>
>> .
>>
>
>
>
> --
>
> *Raymond Jamali* | I.T. Assistant
>
> *[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
> the future*
>
> 6505 Gayhart Street | Commerce | California | 90040
>
> Tel: 800.686.6672 x172 | Fax: 800.500.9955
> raymond@noralighting.com | www.noralighting.com
>
> <https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>
>

--

*Raymond Jamali* | I.T. Assistant

*[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
the future*

6505 Gayhart Street | Commerce | California | 90040

Tel: 800.686.6672 x172 | Fax: 800.500.9955
raymond@noralighting.com | www.noralighting.com

<https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>


backticks are for variable names mainly. e.g.

```r
`some.setter<-` <- function(x, value) { ... }
```

or

```r
some.data.frame$`name with spaces`
```

but i think here both are OK. i was just wondering why you used them here as i’ve never seen them in that place :laughing:


@DieterBuysAI, your right! I was mistaken, sorry.


I'm using mongoDB with is NOSQL.

On Wed, Apr 29, 2015 at 3:31 PM, Ramtin Jamali <ramtinj1986@gmail.com>
wrote:

> Iphonetweets is actually the name of the collection. It's not a bug.
>
> On Wed, Apr 29, 2015 at 3:30 PM, Ramtin Jamali <ramtinj1986@gmail.com>
> wrote:
>
>> Hi
>>
>> Tnx I thought I fixed that already.
>>
>>
>> On Wed, Apr 29, 2015 at 3:29 PM, solankikrunal <notifications@github.com>
>> wrote:
>>
>>> i think you have bug in this line db = client.testdb
>>> instate of u need to use db=client.iphonetweets
>>>
>>> --
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/rraymondd/TwitterSentimentAnalysis/commit/407e4cfd045d5fe3c2f2248fd5109399fb95ef86#commitcomment-10974485>
>>> .
>>>
>>
>>
>>
>> --
>>
>> *Raymond Jamali* | I.T. Assistant
>>
>> *[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
>> the future*
>>
>> 6505 Gayhart Street | Commerce | California | 90040
>>
>> Tel: 800.686.6672 x172 | Fax: 800.500.9955
>> raymond@noralighting.com | www.noralighting.com
>>
>> <https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>
>>
>
>
>
> --
>
> *Raymond Jamali* | I.T. Assistant
>
> *[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
> the future*
>
> 6505 Gayhart Street | Commerce | California | 90040
>
> Tel: 800.686.6672 x172 | Fax: 800.500.9955
> raymond@noralighting.com | www.noralighting.com
>
> <https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>
>

--

*Raymond Jamali* | I.T. Assistant

*[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
the future*

6505 Gayhart Street | Commerce | California | 90040

Tel: 800.686.6672 x172 | Fax: 800.500.9955
raymond@noralighting.com | www.noralighting.com

<https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>


Alrighty, but most likely tomorrow :)


Yep. I think its rmProg4 in Tests/Roundtrip

On Wed, Apr 29, 2015 at 3:08 PM, Jacques Carette <notifications@github.com>
wrote:

> It is in that direction, yes. Have you made that error into a test? What
> number is it?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/cdc47fa3d4d3127856a4f9141f07098b48336b1e#commitcomment-10970571>
> .
>


Não entendi esse pedaço – pq a gente coloca o valor da variável em um comentário, mas atribui `null`?


I just happened to notice this when looking for `local $@`.


but when i try show dbs

there are  not showing Iphonetweets database


Will the armor skill modifier be the average of your light and heavy armor skill?


May be first character can be upper case.


@iliat this is a good fix, can you merge it to googlegenomics/gatk-tools-java ?


Portability is good.  But what exactly are we trying to be portable with?  On the Fedora/Redhat side of things I can almost guarantee this would be dead code.  Fedora is all in on systemd, that ship has sailed.  RHEL6 and earlier and will need these init scripts for years to come, but the current scripts don't do this and it's never come up as an issue.


@aclark4life this was the trick


Does this mean compatibility with Android Studio 1.2 and its built-in unit testing support? Yay!


TeamCity Ember :: Build [Build 3](http://52.17.206.69:8111/viewLog.html?buildId=5&buildTypeId=Ember_Build) outcome was **FAILURE**
Summary: Will fail Build time: 00:07:56


The code will create a collection. try to run this:

use testdb
    db.iphonetweets.count()
    db.iphonetweets.findOne({})

On Wed, Apr 29, 2015 at 3:33 PM, solankikrunal <notifications@github.com>
wrote:

> but when i try show dbs
>
> there are not showing Iphonetweets database
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/rraymondd/TwitterSentimentAnalysis/commit/407e4cfd045d5fe3c2f2248fd5109399fb95ef86#commitcomment-10974561>
> .
>

--

*Raymond Jamali* | I.T. Assistant

*[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
the future*

6505 Gayhart Street | Commerce | California | 90040

Tel: 800.686.6672 x172 | Fax: 800.500.9955
raymond@noralighting.com | www.noralighting.com

<https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>


@KarimTaha please review


1. If I understand it right you'll have to put it after this:
```
IF desiredInc < 0 {
		SET launchNode TO "D".
		SET desiredInc TO ABS(desiredInc).
	}.
```
BTW is there any specific reason why you are typing a dot after each closing brace? `}.` It works fine without dots after braces.


It _may_ be unavoidable.  To my knowledge the distributions don't have to agree at all about when something should run.


ok thanks :)


yw.

On Wed, Apr 29, 2015 at 3:36 PM, solankikrunal <notifications@github.com>
wrote:

> ok thanks :)
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/rraymondd/TwitterSentimentAnalysis/commit/407e4cfd045d5fe3c2f2248fd5109399fb95ef86#commitcomment-10974593>
> .
>

--

*Raymond Jamali* | I.T. Assistant

*[image: cid:image001.jpg@01CB439D.45C25040]*NORA LIGHTING | *Illuminating
the future*

6505 Gayhart Street | Commerce | California | 90040

Tel: 800.686.6672 x172 | Fax: 800.500.9955
raymond@noralighting.com | www.noralighting.com

<https://www.linkedin.com/pub/ramtin-jamali/b8/270/b02>


Did you ever improve on this? My thoughts is that really signalR should be using (and binding into) DependancyResolver.Current this would mean when you plug in a 3rd party resolver all the SignalR bindings would also get bound into that container.


Obrigado professor, eu tinha visto que tinha deixado com erro, todavia testei o sistema para ver se esses atrapalhariam os colegas, visto que não havia problema eu commitei...


it will be the one attached to the item in the esp
the armor will still display as heavy or light.


I'll come back to this Friday, can't get it right now.


What's this? Is it an attempt to make a .ks to .ksm compiler?


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Yeah, that is conventional; but elsewhere in the project it was like this. Think I should change it throughout?
```
   private val qpRowCount = "rowCount"
   private val qpCopy = "copy"
   private val qpRollupName = "rollupName"
```


**Edit**: I lied, apparently it handles that by stripping off everything before the first blank line.  The problem is that if you have obsoleted packages, `parse_updates` will fail.


develop (macumber) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@3nids I think it's on the right track, but I don't like how it behaves as a toolbar (eg, how it extends below the browser/layer panel in the default configuration). The widgets just get lost way to the right of were I'd expect them to be. I think instead it should use the same approach as the messagebar, but just always display at the bottom of the canvas. This would also avoid some oddness like how "user input tool bar" shows in the panels list but can't be activated.

What do you think?


yScale?


> Portability is good. But what exactly are we trying to be portable with?
>
There are A LOT of distributions out there…

If you're not interested in portability and having a unified script, then the discussion is really moot, isn't there? This PR is exactly that. Sure, I could start splitting them up into lsb and redhat versions, but then we would just be back to EXACTLY what we already have - scripts that no one is interested in maintaining and that will start diverging at almost the same moment it's accepted...


just wanted to confirm, i have a hard time still learning to read these

so what i should be left with is this right?

get 'users/show'
     get 'my/bookmarks', as: :my_bookmarks, to: 'users#show'
get 'users/show'
+    get 'my/bookmarks', as: :liked_bookmarks, to: 'users#liked'
get 'users/show'
+    get 'my/bookmarks', as: :added_bookmarks, to: 'users#added'


What's this supposed to fix?
Do you have a unit test for it? ;-)


But if the pool is already imported much earlier in the boot, possibly in the initramfs, then we shouldn't need any special handling for this.  A normal Linux `mount -a` command would be able to mount any non-zfs filesystems on zvols or legacy-style zfs datasets.


It will still have 1 vanilla keyword, either ArmorLight or ArmorHeavy, but will have 2 PerMa keywords xMAArmorLightXX and xMAArmorHeavyXX.
The skill is based on what's in the Armor Type part of the esp and can only be Clothing, Light or Heavy, it will also determine how the armor appears in the inventory list


Nope. I wrote this 2 or 3 months ago, when there was no support for functions, and when I was pissed there are no local variables available. So I wrote a Python script that changed all variables to __STACK[index_here] and incremented the index with every function call (or rather RUN command). Since it's so short, there were limitations, such as having to prepend every variable with prefix "var_" or having the return value of a script available in retVal variable. See forum post here: http://forum.kerbalspaceprogram.com/threads/68089-0-90-kOS-Scriptable-Autopilot-System-v0-17-0-2015-4-18?p=1710892#post1710892


#include<stdio.h>
#include<stdlib.h>
#include<string.h>

#define SIZEOFEXPRESSION 80

//------------------//
//----Egor-Pats-----//
//-----lab-3.7------//
//------------------//

struct stack{
	char inf;
	struct stack *next;
};

char *inExpression, *outExpression;

//-----------------------------ALL-FUNCTION---------------------------------------------------------
struct stack *push(struct stack*, char);
char Pop(struct stack **);
int Priority(char);
void ValidateExpression(char* pExpression);
void ValidateExpressionWithOutGOTO(char* pExpression);

void Clear(void)
{
	int ch;
	do{
		ch = getchar();
	} while (ch != '\n' && ch != EOF);
}

//----------------------------------Memory----------------------------------------------------------
int MemoryAllocation()
{
	inExpression = (char*)malloc(sizeof(char) * SIZEOFEXPRESSION);
	if (inExpression == NULL){
		printf("Memory allocation error.\n");
		return -1;
	}
	outExpression = (char*)malloc(sizeof(char) * SIZEOFEXPRESSION);
	if (outExpression == NULL){
		free(inExpression);
		printf("Memory allocation error.\n");
		return -1;
	}
	return 0;
}

int MemoryCleaning()
{
	free(inExpression);
	free(outExpression);
	return 0;
}

//---------------------------------------MAIN-------------------------------------------------------
int main()
{
	puts("You shoud input expression. You must use only '+', '-' ,'*' ,'/' and '()'.\n");
	puts("This is not a calculator!!! Use letters instread of numders. ");
	struct stack *head = NULL;
	do{
		int k = 0, m = 0;
		char c;
		MemoryAllocation();
		puts("\nInput expression:");
		ValidateExpressionWithOutGOTO(inExpression);
		while (inExpression[k] != '\n' && inExpression[k] != '='){
			if (inExpression[k] == ')'){
				while ((head->inf) != '(') {
					outExpression[m++] = Pop(&head);
				}
				Pop(&head);
			}
			if ((inExpression[k] >= 'a' && inExpression[k] <= 'z') ||
				(inExpression[k] >= 'A' && inExpression[k] <= 'Z')){
				outExpression[m++] = inExpression[k];
			}
			if (inExpression[k] == '('){
				head = push(head, '(');
			}
			if (inExpression[k] == '+' || inExpression[k] == '-' ||
				inExpression[k] == '*' || inExpression[k] == '/'){
				while ((head != NULL) && (Priority(head->inf) >= Priority(inExpression[k]))){
					outExpression[m++] = Pop(&head);
				}
				head = push(head, inExpression[k]);
			}
			k++;
		}
		while (head) outExpression[m++] = Pop(&head);
		outExpression[m] = '\0';
		printf("\n%s\n", outExpression);
		MemoryCleaning();
		printf("\nStart over(Y/N)? ");
		do{
			fflush(stdin);//Clear();
			scanf_s("%c", &c);
			if (c == 'Y' || c == 'y' || c == 'N' || c == 'n'){
				break;
			} else{
				printf("Input error. Try again: ");
				continue;
			}
		} while (1);
		if (c == 'Y' || c == 'y'){
			continue;
		} else{
			break;
		}
	} while (1);
	return 0;
}
//----------------------------------FUNCTION--------------------------------------------------------

struct stack *push(struct stack *head, char a)
{
	struct stack *pointer;
	if (!(pointer = (struct stack*)malloc(sizeof(struct stack)))){
		puts("error");
		exit(-1);
	}
	pointer->inf = a;
	pointer->next = head;
	return pointer;
	free(pointer);
}

char Pop(struct stack **head)
{
	struct stack *pointer;
	char a;
	if (!(*head)) return '\0';
	pointer = *head;
	a = pointer->inf;
	*head = pointer->next;
	free(pointer);
	return a;
}

int Priority(char a)
{
	switch (a){
	case'*':case'/': return 3;
	case'-':case'+': return 2;
	case'(': return 1;
	}
	return 0;
}
/*
void ValidateExpression(char* pExpression)
{
	int j = 0;
enter:
	int  meter = 0, counter = 0;
	fflush(stdin);//Clear();
	fgets(pExpression,SIZEOFEXPRESSION,stdin);
	for (j = 0; j < strlen(pExpression) - 1; j++)
	{
		if ((pExpression[j] >= 'a' && pExpression[j] <= 'z') ||
			(pExpression[j] >= 'A' && pExpression[j] <= 'Z') ||
		    pExpression[j] == '/' || pExpression[j] == '*' ||
			pExpression[j] == '+' || pExpression[j] == '-' ||
			pExpression[j] == ')' || pExpression[j]  == '('){
			puts("ok");
		} else{
			printf("Error! Something isn't introduced: ");
			goto enter;
		}
		if (pExpression[j] == pExpression[j +1] && (pExpression[j] != '(' && pExpression[j] != ')')){
			printf("Error! Elements can't be repeated: ");
			goto enter;
		}
		if ((pExpression[j] == '+' || pExpression[j] == '-' || pExpression[j] == '*' ||
			pExpression[j] =='/') && (pExpression[j + 1] == '\0' || pExpression[j + 1] == '+' ||
			pExpression[j + 1] == ')' || pExpression[j + 1] == '-' || pExpression[j + 1] == '/' ||
			pExpression[j + 1] == '*'))
		{
			printf("Error! Invalid expression: ");
			goto enter;
		}
		if (pExpression[j + 2] != '\0'){
			if ((pExpression[j] >= 'a' && pExpression[j] <= 'z') ||
				(pExpression[j] >= 'A' && pExpression[j] <= 'Z') ||
				pExpression[j] == ')'){
				if (pExpression[j + 1] != '/' && pExpression[j + 1] != '*' &&
					pExpression[j + 1] != '+' && pExpression[j + 1] != '-' &&
					pExpression[j + 1] != '\0' && pExpression[j + 1] != ')'){
					printf("Error! Enter the correct expression: ");
					goto enter;
				}
			}
		}
		if (pExpression[j] == '(') counter++;
		if (pExpression[j] == ')') meter++;
	}
	if (counter != meter){
		printf("Error! Problems with brackets: ");
		goto enter;
	}
}
*/
void ValidateExpressionWithOutGOTO(char* pExpression)
{
	int j = 0, trick = 0;
	do{
		int  meter = 0, counter = 0;
		if (trick != 0){
			printf("Retype: ");
		}
		trick = 0;
		fflush(stdin);//Clear();
		fgets(pExpression, SIZEOFEXPRESSION, stdin);
		for (j = 0; j < strlen(pExpression) - 1; j++)
		{
			if ((pExpression[j] >= 'a' && pExpression[j] <= 'z') ||
				(pExpression[j] >= 'A' && pExpression[j] <= 'Z') ||
				pExpression[j] == '/' || pExpression[j] == '*' ||
				pExpression[j] == '+' || pExpression[j] == '-' ||
				pExpression[j] == ')' || pExpression[j] == '('){
				//puts("ok");
			}
			else{
				printf("Error! Something isn't introduced!\n");
				trick++;
			}
			if (pExpression[j] == pExpression[j + 1] && (pExpression[j] != '(' && pExpression[j] != ')')){
				printf("Error! Elements can't be repeated!\n");
				trick++;
			}
			if ((pExpression[j] == '+' || pExpression[j] == '-' || pExpression[j] == '*' ||
				pExpression[j] == '/') && (pExpression[j + 1] == '\0' || pExpression[j + 1] == '+' ||
				pExpression[j + 1] == ')' || pExpression[j + 1] == '-' || pExpression[j + 1] == '/' ||
				pExpression[j + 1] == '*' || pExpression[j + 1] == '\n'))
			{
				printf("Error! Invalid expression!\n");
				trick++;
			}
			if (pExpression[j + 2] != '\0'){
				if ((pExpression[j] >= 'a' && pExpression[j] <= 'z') ||
					(pExpression[j] >= 'A' && pExpression[j] <= 'Z') ||
					pExpression[j] == ')'){
					if (pExpression[j + 1] != '/' && pExpression[j + 1] != '*' &&
						pExpression[j + 1] != '+' && pExpression[j + 1] != '-' &&
						pExpression[j + 1] != '\0' && pExpression[j + 1] != ')'){
						printf("Error! Enter the correct expression!\n");
						trick++;
					}
				}
			}
			if (pExpression[j] == '(') counter++;
			if (pExpression[j] == ')') meter++;
		}
		if (counter != meter){
			printf("Error! Problems with brackets!\n");
			trick++;
		}
	} while (trick != 0);
}


TeamCity Ember :: Build [Build 4](http://52.17.206.69:8111/viewLog.html?buildId=7&buildTypeId=Ember_Build) is now running


Looks great, nice job!


@glenn-1990 I think this is really cool now. Thanks for suggesting it.


Fair point.  Clearly 5 are too many.  But perhaps 2 are a more reasonable number.


no rush, i just tought i'd put it in there. I'll also have more time in 2 months.

Intresting, my board has a 12Mhz crystal so i definetly have to change that too, maybe the whole definition should be moved to a board specific file.

I solved the P1.2 issue by setting the P1->PMD register to zero at startup, for some reason having the other unused adc pins at that weak pullup mode also influences the P1.2 pin. I'm still nor sure what exactly is happening there and i believe the current gpio handling isn't faulty.
I have to get the rest working first anyway. I believe there may still be a feq quirks. The current(amperage) calibration didn't quite work out on the first try.


I'd prefer `autoconnect`. This isn't implemented in java or js. Do we really need this?


After reading the [Backward Compatibility Policy](http://developer.joomla.org/cms/development-strategy.html#backward_compatibility) it is not easy for me to judge whether there is a violation of backward compatibility.

As far as I can see no PHP library code is concerned but it is not clear to me whether the changed JavaScript, which is directly related to the modal form fields, is allowed to be changed.

It might be possible, that third party extensions use the form field e.g. ```JFormFieldModal_Contact``` as base class for their modal form field and rely on the old element id when using some extra JavaScript. Some other third party extensions might have copied the code in ```getInput()``` to build up their own modal form field and rely on the original code in **administrator/components/com_menus/views/item/tmpl/edit.php** to display validation errors.
I don't know exactly if these cases violate B/C.


The medium will also have all the pros and cons of heavy and light (for perma effects) such as the movement speed, spell cost, etc. so it's kinda ugly like that without skill/perks in both heavy and light.


TeamCity Ember :: Build [Build 4](http://52.17.206.69:8111/viewLog.html?buildId=7&buildTypeId=Ember_Build) outcome was **FAILURE**
Summary: Will fail Build time: 00:02:06


thank u for code


Why not move this up to `prettyPrintSingleError`?


The field is not editable; it usually displays Assigned To: "Nobody; OK to take it and work on it", clicking the value reveals a pop-up with Profile, Activity and Mail, all for user named nobody@mozilla.org. I tried before to assign myself to bugs, but without success. Most other fields are editable.


Perhaps. But if that is what you want, then there is little to no point in this PR. It adds only one or two additional features and those can easily be ported to those two.


Same problem here (during filing, a reduced form with little fields is displayed, after filing it's the same as in the comment above.


@garvank - this patch includes changes to marisa-binding.cc that should add all the assertions that we talked about.


You would need a case for `PositionedError` and other wrappers if you do move the `suggestions` call up.


Thanks for this commit; it is an appealing idea.  But it runs into a potential problem: one special case of representing dates is to represent years, which are of course numbers.  It seems problematic for the dateformatter to receive a number like 2015 and turn it into the year 1972.  How do we avoid this kind of confusion?


TeamCity Ember :: Build [Build 5](http://52.17.206.69:8111/viewLog.html?buildId=8&buildTypeId=Ember_Build) is now running


Being used to Python, I treat keyword arguments as similar syntax to variable assignment.


@elyscape pull requests have already been merged and closed are usually gaping voids that swallow further comments; if you're having issues with a PR your best bet is to file an issue on JIRA so it'll be tracked with other onging work.


Merge


nvm i figured it out 2e1c8c41ed8ba4389ec83c5706ea5f61b56abc95

Something to do with the callback function having an argument. Encasing it in an anon function with no argument fixed it. Javascript is dumb.


Actually since I use ABS() pretty much everywhere before that instead of changing all of the values to positive, It doesn't make a difference.

I always use periods after braces simply because it bugs me if they're not there. I'm not sure why they're not needed after braces anyways, since we need them everywhere else.


Fixed up the style


BTW why `get_process_from_name`? I know it's temporary but why not `make_process_from_name`?


TeamCity Ember :: Build [Build 6](http://52.17.206.69:8111/viewLog.html?buildId=9&buildTypeId=Ember_Build) is now running


TeamCity Ember :: Build [Build 5](http://52.17.206.69:8111/viewLog.html?buildId=8&buildTypeId=Ember_Build) outcome was **FAILURE**
Summary: Will fail Build time: 00:02:04


This needs to happen on the main thread. You "mostly" get away with it, but it's not threadsafe.


Making it so


This breaks if filename is a Pathname. Why not use File.basename()?


If the arg doesn't exist it should default to the old behavior.


No idea. I will change it now.


oyg


А 15 строка на что?


Нужны, проверка же на мне


TeamCity Ember :: Build [Build 6](http://52.17.206.69:8111/viewLog.html?buildId=9&buildTypeId=Ember_Build) outcome was **FAILURE**
Summary: Will fail Build time: 00:02:04


> There are A LOT of distributions out there…

Yes there are!  And to some degree it's a fools errand to even try to be portable with all of them.  Unless we're actively testing the scripts on those platforms there's little reason to expect they're going to work.  Distributions can be far too different.

In guess in part I view these scripts as a reasonable starting point for end distribution maintainers to use.  And the two major families of init scripts are either Debian-style of Redhat-style.  I somewhat expect they'll get modified a little downstream, at least until those changes can be integrated.


This solved the issue during hardware testing. :sunglasses:


Idea: `kill_process` might be a bit more obvious. What do you think?


Знаю, я просто так отметил места, где я вызываю твои функции. в самом конце уже изменю


აქ მითითებული გაქვს, რომ სტილი, ანუ შენი style.css ფაილი დევს css ფოლდერში, მაგრამ რეალურად repository-ში ანუ იგივე შენი პროექტის ფოლდერში გიდევს პირდაპირ და ასეთი ფოლდერი css არსად არ გაქვს


ეს ფაილი საერთოდ არ გაქვს


ეს ფაილიც არ გაქვს


Instead of `end_process`? Sure.


Thanks; this could be useful.  Can you create a small exhibit that demonstrates use of the new capability and place it in (a subdirectory of) the demos directory, and add that as part of this pull request?  This serves as a kind of "unit test" for the new functionality.


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2107 of 2196 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.95%25-yellow.svg)


1) Нет её тут
2) Так понятнее
3) С нуля


[![Leaf from a Gandavyuha Manuscript](http://api.artsmia.org/images/4868/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4868)


[![Phil / Fingerprint](http://api.artsmia.org/images/116570/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116570)


:D


Can I ask why you did this? It seems to be related to not being able to build [gjstest](https://github.com/google/gjstest) using homebrew's version of re2; executing the binary results in:

```
dyld: Library not loaded: /usr/local/opt/re2/lib/libre2.so.0
  Referenced from: /Users/jacobsa/clients/gjstest/gjstest/internal/cpp/gjstest.bin
  Reason: image not found
```