https://github.com/WedyDQ10/android_kernel_sony_msm8974ac/commits/lollipop?author=kholk

Just need to cherry-pick these? no need to add anything to defconfigs? thanks


oh~ ho...


gatDay?)


Ну и названия коммитов бы более осмысленными)


Will remove this in the next commit


As you can see, we can easily override default descriptions in the plugin code.


I'll take a look.

On Mon, Apr 27, 2015, 4:21 PM gitars <notifications@github.com> wrote:

> @mark-friedman <https://github.com/mark-friedman> Also, I was wondering
> if you could help me out some, I'm having just as much trouble with making
> the generic event block working as I did with the multi-generic block (and
> I don't have much more time. I'm working on App Inventor through Open
> Academy / an academic class, and my term is ending at the end of the week.
> Regardless of that, I do want to finish this feature).
>
> Basically, what it seems to me is that top level blocks handled using
> define-syntax blocks (such as define-event). However, it seems that non top
> level blocks are handled with normal define functions (get-property,
> set-and-coerce-property!, etc). For this reason, I decided to create this
> function that should basically call the define-event-helper and register
> the event. I think this all I will need to do (besides unregister the old
> event). However, as in the past, I really can't figure out syntax to make
> this work. Could you take a look a this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gitars/appinventor-sources/commit/b0862416de645c1e1f8d0e37bc9e18cd2c634d27#commitcomment-10929087>
> .
>


Nick pointed out that it was pointless to show this dropdown for MAGStock since it doesn't have anything extra beyond what's in the badge choices at the top of the page.


develop (lefticus) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.29%25-red.svg)


Understood. I'll make some amendments to the init.pp and do some testing.


gestion des points


https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind

The bind() function creates a new function (a bound function) with the same function body (internal call property in ECMAScript 5 terms) as the function it is being called on (the bound function's target function) with the this value bound to the first argument of bind(), which cannot be overridden. bind() also accepts leading default arguments to provide to the target function when the bound function is called. A bound function may also be constructed using the new operator: doing so acts as though the target function had instead been constructed. The provided this value is ignored, while prepended arguments are provided to the emulated function.


Readability: my (obviously subjective) opinion was that the combination of changes Darik and I made were stretching the clause a bit and that inverting the two made the result a little easier to read. Of course if we are not trying to honor the PEP8 79 character limit then we could put them back the other way without having to have an awkward split. (Incidentally, I love that Raymond Hettinger's suggested length from his talk this year was “90-ish” ;)


To fix the memory issue the code had to change from this:

          this.raf_id = requestAnimationFrame(this.updateScene.bind(this));

To this:
            obj.raf_id = requestAnimationFrame(
                function(){
                    obj.updateScene(obj);
                }
           );


Yes. Me too think that would be good. I will do it. How should I name the base class?


ㄷㄷ갓현욱번개같네

chrono쓰면 win32 폴더 박으로 뺴도 됨


@talsraviv either is fine -- I think my initial thinking was to address all the possible properties things that could be added to the `Spice.add()` call here -- it is only related to using certain templates though, so moving it elsewhere should be fine.


I know this driver is making it's own determinations on suspend/resume essentially. I know the msm pm stuff off lines cores too, but I had instances of cores never coming online with mp decision off - which is why I made this to ensure they all come on.


Ignore the title -_- wrong project


Oops sorry. Will change those.


The patch is updated now.


Add a test to show it off?


Ok I will initialize it to 1 at the beginning.


I merged this from you. It produces an error:

Uncaught SyntaxError: Unexpected token ) on line 28 of NotificationFunctionality.js

removing the extra ')' on that line fixes the error


Why are these three functions capitalized?  Should be `nextClicked` etc.


Thanks!


ES6ify the functions like `getInitialState: function()` into `getInitialState()`


I guess VI and CI was badly understood when Rice was originally written.


move this line into the above of script.


ditto


ㅇㅋ


nit: only implemented for gce and gke


I haven't finished it yet

On April 27, 2015 8:31:06 PM CDT, Serguei Fedorov <notifications@github.com> wrote:
>I merged this from you. It produces an error:
>
>Uncaught SyntaxError: Unexpected token ) on line 28 of
>NotificationFunctionality.js
>
>removing the extra ')' on that line fixes the error
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/computerfr33k/rateMyPaul/commit/4e1626cc8b55ee56d63b0d54c0d6c39d4c07dd92#commitcomment-10930892

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


이거 아직 구현 안 된 기능 코드 보고 내가 대충 만들어봐도 댐? repeat 머 이런거는 아직 없드만


@snrism I just haven't finalized it yet. Will do it shortly.


Cool, just making sure! Once I put the fix in, the popup worked as it was supposed to


ここは単純に

```vim
let s:cache_module_path[key] = path
return path
```

で良さそうです


アンダースコアの意味はなんでしょうか？何かのおまじない？ ping @osyo-manga


These should remain spaces, not tabs :)
 see https://github.com/aaronjorbin/wordpress-test/blob/master/.editorconfig#L16


@alastair I don't know if It's necessary to check also for user group's recordings. As in carnatic Artist.recordings method.


sd


In function move_tag, what would happen if I move current tag to 8th when there's only 5 tags ?


Good thinking, but you might like this better:
```
this.setState({
  keyword_array: this.state.keyword_array.concat([keyword])
})
```
Array.prototype.concat returns a new array by merging this with the array passed in.  Then you don't have to do the two steps of (1) modifying the state (try to avoid that where possible) and (2) setting state.  This way, you just setState with the new value.  A little cleaner.


Better to be `keywordArray` than `keyword_array`.  In fact, why not `keywords`?


safi kheddam


Nope, you meant "canola"


Looks like these new `refit` modifications are still not getting through Travis.  I think it's much better than it was though.  Will have another look tomorrow morning.


I still get same exception. Query string is: /admin/shipping-option-outcome/create?subclass=conditions

Error: Cannot initialize abstract class: ..\Model\Condition


ㅇㅇㅇㅇㅇㅇ


Great job using props and state to communicate between these components!

Although in this case, its probably more clear to just integrate `ShowList` and `AddKeyword` into this component.  This makes sense as one component that operates on keywords.


What is that for?


`AddKeyword`?


Same as the Keywords component.


don't mix `something()` with `something: function()` ... choose just one (the first one).


a:name が空の文字列の場合があるので suffix として着けてます（空の文字列を辞書のキーにすることはできないので


Bien reçu chef ;)


Naughty Naughty mixing snake_case and camelCase ... simultaneously offending JavaScript developers and Ruby developers! hahahahaha

In JavaScript **always** choose `camelCase`.


ConfigPluginsWidget is a friend class of LxQtPanel (See [this line](https://github.com/lxde/lxqt-panel/commit/bd70b70b524610d6f06f39989f13b70af55de4e4#diff-71df648bd6f51bfec5a179eb416c4de7L59)), so we don't need this public method. Let's just do `panel->mPlugins.data()` here and remove the public method.


たしかにそのとおりですね。直します。


What is that one for as well? Something you have in mind?


なるほど


fdgdfg


これはやっておきます。


mixing `navigation-stripe__section` with `navigation__stripe__links`???


I'm not sure I like this `!0` business: `true` should be used here.


@zzak Is "requestion" supposed to be "requesting"?


Look how easy [momentjs](http://momentjs.com/) makes this. I'm in love.


smaller_make_shared (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Super awesome!!!


Look how easy [momentjs](http://momentjs.com/) makes the changes in this commit. I'm in love.


Lets remove this CDN call and instead use an NPM module and bundle it in our webpack build: https://www.npmjs.com/package/react-d3

Run `npm install --save react-d3` in the client directory and then the package will be available in node_modules without the CDN.


scrypt has a memory component, which makes it harder to make ASICs for and helps slow things down.

The safe play is not to use either, it's to use PBKDF2.


Comments below to be removed. Placeholders to implement tests.


Since these Reports are already their own components, why don't we put them in their own files under `client/components/reports/[name-of-chart].js` and import them in?


ignore this, python has the GIL


1 import に1 call なのでok。


Do you have a plugin that's called Legendlore?


@Losses 拧螺丝喵！


lol, I'm still not getting any query results.


That's for the specific case a plugin doesn't load, right? So the plugin is still in the config file?


Sometimes, one must break the mould to open new doors. The fun part was to replace it. I see that you really enjoy this ! Who cares if it works or not ?
Sure it will eventually work, but "there shall be weeping and gnashing of teeth" as they say in the bible.


Every other option has a default value specified and it means it's easy to see what options you can use and configure when using the plugin rather than digging through the code. No?


Mean glade rom


Any idea why this has changed?


{Object}formValues -> {Object} formValues


Having a look [here](https://github.com/bbatsov/clojure-style-guide#dont-flag-constants) it looks like it is not needed.
But here there is an old SO [question](https://stackoverflow.com/questions/9162558/how-does-clojure-const-work). I have never actually seen it either so ofter, I will remove it.


No, on multilingual installations we usually don't have only one currency. It would be nice to have everything working in an ideal way, but until then, what's the big advantage of using a variable instead of keeping the string-translation for the currency symbol? It can break existing installations, which in my opinion should be taken into consideration.


Two newlines.


It seems part of this commit should be merged in the previous commit.


@cristianoteles why do we need `$response` here?


There seems to be some scope collision I don't really understand. Anyway, ``lib.tests`` won't work here, despite ``lib-tests`` or ``foo.bar`` working fine. Due to this evaluation problem, we've had no nixkpgs channel update since this commit, as noticed in https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/logic/coq/default.nix#L50.


tnx!


I replaced this line with:
```ruby
      if buff.size < 8192
	Chef::Log.info("BUFFSIZE: #{buff.size}")
        break
      end
```

and saw this output:
`[2015-04-28T01:36:25-07:00] INFO: BUFFSIZE: 8166`

This was while running Docker 1.6 native on Debian 7.


No, I probably messed up the merge


The failing unit test is unrelated

```GamestarApiWrapperTest.testgetDataFromValidHtmlResponse```


:+1: :+1:


так вот, например


Done. There's a second commit in the pull request now.


could you please check that branch https://github.com/kofemann/oncrpc4j/tree/async-client-v2 has expected behavior.

To use as fire-and-forget:

 Future<RpcReply> r = call.call(0, XdrVoid.XDR_VOID);
or  simply
call.call(0, XdrVoid.XDR_VOID);

for call back:

        CompletionHandler<RpcReply, XdrTransport> callback = new CompletionHandler<RpcReply, XdrTransport>() {

            @Override
            public void completed(RpcReply reply, XdrTransport attachment) {

            }

            @Override
            public void failed(Throwable exc, XdrTransport attachment) {

            }
        };

call.call(0, , XdrVoid.XDR_VOID, callback);

The call back will be executed in the selector thread. E.q, for heavy-duti work you may want to use submit processing into a thread pool.


Valid point, but randomising the fallback hosts would fix this. `rest.ably.io` would always be first, making it clear that it has a special meaning.

I could split host and fallback hosts, but if we want to keep the rotation, I need to add a few extra class members for that. And I don't like that too much, because it adds complexity to the code. But in the end, it's up to you :)


leaflet 0.7.3 is the newest version


Good question. Basically in Eclipse hover can be selected using ```content-type``` and ```state-mask``` (per content type btw). At the moment CCW does not define content types and therefore we do not select hovers using that parameter. It is there though, as we will probably need it in the future. I can specify this in the docstring.


ahahah spammiamo anche su github allora!


hmm, this dep can be removed, for we use the CDN...


без синхронизации в этом методе может возникнуть ошибка - ArrayList не потоко-безопасный


Нет синхронизации, и пожалуйста, хватит копировать код из папки в папку - это ужасно неудобно читать.


non vedo il tasto "like" ne' "+1", mi sa che l'equivalente su GitHub e' dare una stellina


Other issues:
* remove `StampHelpers::IsStampNeeded` (one overload);
* measure performance (our performance tests and analysis of those tests using VS profiler).


Woop! Sorry about that @djfarrelly :) All pushed up now


Heres what this will look like now @rotev
![screen shot 2015-04-28 at 12 09 20](https://cloud.githubusercontent.com/assets/2601332/7367426/a583edb6-ed9f-11e4-8f4f-881e3d43e6a3.png)


#60 , #61 Documentation Reviewing Done


It definitely is awkward.


#warning 预加载、清除防止内存过大等操作暂时不做了~~神，这个还是做了吧，跪求。


Ciao,
dai un'occhiata alla v1.4.3. Ho risolto il refuso sul tag <title>.

@cghellere


It is better, but what are the ```%``` am I missing some syntax? I guess you mean ```(partial ...)```...not sure though.


`protected`?


@XhmikosR Yup, found the problem: https://github.com/twbs/gruntworker/issues/6


Shouldn't these go for cli sub-package?  And https://github.com/ClusterLabs/pacemaker/commit/39d20f701c651c18d2e1dc35f5a90867a155aa68?


Je comprends mieux l'utilité, mais le problème avec cette proposition, c'est qu'on est forcé de *tout* définir. Ce que je trouverais mieux, c'est :
- pouvoir utiliser une taille de papier « générique » (a4paper, a5paper, etc.), et laisser LaTeX faire le reste ;
- pouvoir donner plus de précisions si nécessaire.

Que pensez vous de remplacer les options `papersize` et `orientation` par une unique option `geometry`, et passer cette option directement en option à l'appel LaTeX ``\usepackage[((geometry))]{geometry}``. Comme ça :
- (patacrep) les configurations simples sont lisibles par l'utilisateur (``a4paper``, ``portray, a4paper``) ;
- (patacrep) les configurations compliquées sont un peu plus complexes à écrire, mais ça reste compréhensible ;
- (patanet) vous enregistrez les informations que vous voulez dans la base de donnée, et vous traduisez ça en une unique variable ``geometry`` qui est passée à patacrep.

Ça me parait à la fois simple et riche. Qu'en pensez-vous ?


Ah, I think I see. The part of ``(mapTestOn ((packagePlatforms pkgs)`` contains ``lib`` attribute which is an empty attrset (probably), so that one overrides whatever ``lib`` we define before.


The dev-master version on 2015.03 was a mistake.

The next release (very soon) will have "strict" version numbers, and won't update to master like this. I'll also take care of including a composer.lock file.

Do you see anything else that should be done there ?


Namespace name should reflect to directory. Use RefactorPractice.Entity


> I could split host and fallback hosts, but if we want to keep the rotation, I need to add a few extra class members for that. And I don't like that too much, because it adds complexity to the code. But in the end, it's up to you :)

I don't know why you think that would be more complex. It would be more code and a bit of reorganisation, but it would be more explicit too. Conveying intention is important I think, and an array is a flat data structure. The first element is not more important than the last one or the third.


>Will programs composed from several source files be pickled?

Yes, `inline` \ `macros` will do this.
Linker would also prefer to do some conservative early inlining, as it speeds up further analisys and compilation.


Но у меня версия 1.2.3.1 после первого обновления от вас


Can you explain why you don't use variants for such a use case?

In my understanding:
- Variants are applicable when the products are different
- Properties are applicable when there are two ways to build the *same* product

In this case, the apple pie and the apricot pie clearly are different products.


@lunaryorn yes, you're right of course, it is a matter of taste. And now you made me curious about ```display-buffer-alist``` :)


I can test the whole thing (not before Thursday...) if you want me to...


It's a bit late, because this PR has been merged, but I'm not a big fan of this approach. Changing the current directory to fix a script behavior seems a bit hacky at best. If you really want to keep this approach, I would at least set back the current directory to its original value:

current_dir=$(pwd)
cd "$JBOSS_HOME"
...
cd "$current_dir"


The method only returns the text until the first white space.


i am not able to get the pdf file for the r programming lecture, please assist.


Effectivement le clear sert à rien dans ce cas, le warmup suffit


May also be removed?


Ok. Don't revert his change.


General refactors
* Remove RPA_ prefix from classnames
* Move all class to its own dedicated file


No it does not, but ```merge-from-preference``` contains a function which has side-effects ```read-descriptors-from-preference!```, do I need to add ```!``` to it? My gut feeling is yes.


Nerozumím, proč si to vyčlenil do nové migrace? Navíc si změnil starou, takže si tím migrace rozbil všem a nepůjde to deploynout.

A prosím, dávej to těch souborů newline na konec! Nebo ti to rebasnu ;)


With a short overview, this looks good to me.


I've applied a change to my version of the jquery.event.ue.js plugin used in the demo page: http://grantm.github.io/jquery-udraggable/examples/options.html

The modified file is:  http://grantm.github.io/jquery-udraggable/jquery.event.ue.js

Can you confirm whether this fixes your problem and whether it introduces any other problem?


Yeah I will do, though this commit needs some serious tidy up - was rushed to get something up and running!


**Aha sry už vidim že to je fix z předtim**


Už som zapínal editor =D


ну вот. ты старалался, а он просто так поставил


Tohle je hodně odvážné, fb garantuje jenom že je to `numeric string` (https://developers.facebook.com/docs/graph-api/reference/user), doporučoval bych použít spíš něco většího. Možná není vhodný `text`, protože se v tom vyhledává, ale větší varchar určitě.


Can you fix or shall I?


That would be great!


It is a data structure in ```org.eclipse...databinding``` and it is used inside ```HoverPreferencePage``` to show the hovers.
This ```ObservableList``` implementation does exactly what you said, it can be observed by clients that want to change according to it and it is thread-safe by itself (this is why is not inside an atom).
It is injected at startup time (you will see it in ```CCWPlugin```) and then observed by the preference page.
I used this in order to interact with the Eclipse world and I had quick results in designing a "reactive" page (which, btw is a better and improved version of jdt's, you can double check that).


Mikrooptimalizace, ale 255 je vhodnější http://stackoverflow.com/a/2340662/326257


This is a good way of including both.


Hi, first of all let me say that this is a great set of changes which I would love to see merged into the trunk.
I looked through it and found that I have some comments — and it's better to write them down here so I don't forget anything by the time this will be merged. Kindly consider my following comments. Thanks!

First one, and I post it here because github doesn't let me comment on a binary file, build/macosx/esptool-0.4.2-osx.zip needs to be removed from git — it should be downloaded automatically by ant build.


@Haroenv i think i found a solution that works for both of us. i added your changes to the new [compatible branch](https://github.com/bullgit/comic-sans-it/tree/compatible). this way both versions can exist side by side


引継ぎの際に、まずは分岐なしで下記の内容にて確認をお願いいたします。
※if文が不完全で処理が反映されないため。

if(window.navigator.userAgent.toLowerCase().indexOf('android 2') != -1){
       var wrapper=dojo.byId("wrapper");
      // wrapper非表示はhiddenではなくdisplay:none;で
      // dojo.style(wrapper, "visibility", "hidden");
       dojo.style(wrapper, "display", "none");
       var myModal=dojo.byId("modalDialog");
       dojo.style(myModal, "top", "0px");
       dojo.style(myModal, "margin", "0");
}


:+1: :smile:


@Fsu0413 @zyun7799 不知道你俩谁写的JSP赵云的代码，怎么那个杀当闪，闪当杀，变成武器当闪，闪当不了杀了呢？没写好吧？


You didn't build new version for releases dir?


Please notice that I didn't deploy the snapshot yet. I'll do it on this evening or tomorrow.


Tohle podle mě nedělá to co chceš http://3v4l.org/LOCn1 (ani http://3v4l.org/ZT8AQ)


Please bear in mind that we now have two options for F_CPU selectable from the Tools > CPU Frequency menu.
Perhaps these comments should give two values (@F_CPU=80MHz and @F_CPU=160MHz).
Totally not critical though, just something to remember.


I'm not sure on this, as I would like to test that it's actually iterable as well as doing the iteration.


Noted.


Noted. Will have those as SHOULDs


This will cause `FATAL ERROR: JS Allocation failed - process out of memory`

So it looks like the recursion needs to be better implemented https://github.com/sphereio/underscore-mixins/blob/master/src/coffee/mixins.coffee#L100-L107


Good!


Agreed, reset() should be protected.


О! :heart::hamburger:


/cc @yanns @hajoeichler


Sure thing :) I was thinking of adding it to the gitignore, but then I had issues with the download failing for some reason and since it's not the official repository, I opted to keep it there :)

Hristo Gochkov
hristo.gochkov@bitsbg.com

> On 28.04.2015 г., at 13:30, Ivan Grokhotkov <notifications@github.com> wrote:
>
> Hi, first of all let me say that this is a great set of changes which I would love to see merged into the trunk.
> I looked through it and found that I have some comments — and it's better to write them down here so I don't forget anything by the time this will be merged. Kindly consider my following comments. Thanks!
>
> First one, and I post it here because github doesn't let me comment on a binary file, build/macosx/esptool-0.4.2-osx.zip needs to be removed from git — it should be downloaded automatically by ant build.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ficeto/Arduino/commit/5c941e7149b9dc6e6cd4ae894a8bafbb2d843c2c#commitcomment-10937609>.
>


Looks good to me.


This commit breaks symlink on Windows. Will you fix or revert it?

Correct command:
```
mklink /D "D:\www\public\composertest\htdocs/app/code/community/TM/Core" "D:\www\public\composertest\vendor\tm\core\app\code\community\TM\Core"
```

Wrong command:

```
mklink" /D" ""D:\www\public\composertest\htdocs/app/code/community/TM/Core"" ""D:\www\public\composertest\vendor\tm\core\app\code\community\TM\Core""
```


I used ```partial``` below and it was easier I guess to write its own fn...


Source files should have a license header — and you are welcome to change attribution for files which were rewritten. This applies to the newly added files as well.
I can merge and then add license headers myself, if you prefer.


Yes I agree.


tohle je nějaké divné, buď chceš použít js login nebo oauth, proč je teď v appce oboje?


Hi Nico, sorry for the delay. I don't really have any need in terms of documentation, I just thought it would be nice to use ipynb files to show the `ijavascript` capabilities.

Maybe we could use `nbconvert` to make a users documentation with a custom template adding in the navbar links for api-doc, and maybe other things like github repo npm package...
Each page of the user doc may be listed in the landing page, and we could also add links in the nav bar using a node script during doc build.

The api-doc could be the default one, without tutorials as it is in the master branch.


Shouldn't it be ``.project``, instead ``/.project`` ?


I already have those and other things fixed. I went on and got the SD library working as well, but have not pushed the changes yet.
I am a bit unsure for the SPI library and a couple of other things but will test that out today probably and push all fixes to my fork.
So do not pull those yet :)

Hristo Gochkov
hristo.gochkov@bitsbg.com

> On 28.04.2015 г., at 13:33, Ivan Grokhotkov <notifications@github.com> wrote:
>
> Please bear in mind that we now have two options for F_CPU selectable from the Tools > CPU Frequency menu.
> Perhaps these comments should give two values (@F_CPU=80MHz and @F_CPU=160MHz).
> Totally not critical though, just something to remember.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ficeto/Arduino/commit/5c941e7149b9dc6e6cd4ae894a8bafbb2d843c2c#commitcomment-10937657>.
>


Is there any particular reason to change the public APIs (i.e. rename ADC pin from 0 to 17)?


I see the point.

By default (meaning, with no openspending.mapping object), we do need an `id` and an `amount`. I think it is good to make that clear. I tried to show that it could also be some *alias* that stands in for id or amount, provided that the mapping object is configured to use that alias.

A diagram would help, but I'd also like to get as far as I can with words. Not sure how else to word it now... I'll think about it. If you have any suggestions they'd be welcome :).


oja, het was voor integers dat die functie er niet was.... meh whatever.


Looks like this conditional branch will never be taken.


I really do not mind what is on the header. If I have removed any, it's on files I changed a lot. And the actual reason is that my source files do not have headers, so imagine Ctrl+A -> Ctrl+V :)
Hristo Gochkov
hristo.gochkov@bitsbg.com

> On 28.04.2015 г., at 13:36, Ivan Grokhotkov <notifications@github.com> wrote:
>
> Source files should have a license header — and you are welcome to change attribution for files which were rewritten. This applies to the newly added files as well.
> I can merge and then add license headers myself, if you prefer.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ficeto/Arduino/commit/5c941e7149b9dc6e6cd4ae894a8bafbb2d843c2c#commitcomment-10937705>.
>


:bangbang:  Tohle není dobře a rozbije to crawler


No, it hasn't moved out of the hash. This section is showing would would be expected in the schema (which obviously represents the data, and which can be referenced in the openspending.mapping hash).

So, I guess the problem is just one of clarity when reading. I'll have a go at making that clearer.


Jo aha, nastalo nedorozumenie :)


I was thinking about the comment we saw on the mailing list, i.e, don't include stuff that aren't used. Therefore it's maybe better to remove it now and then add it later on when we're actually going to use it?


Not sure if `sideEffect` is the clearest name for the passed in function. Maybe name it something to indicate it is in fact a function?


I don't think you should remove copyright. You can instead add your modification copyrights below original one. Same goes here- https://github.com/merkmod/build/commit/10b09d8cd0469a71e3b7b66604d132e812dbb8c6#diff-8cd204220665e76c9cf7051f76cd12d8R4


Well why is the analog port 0 at all? you do have GPIO0. And what public APIs are you talking about?
Makes much more sense to be 17/A0 just like the Arduino has A0/14 and so on, even though the analog pin has no other GPIO function.

Hristo Gochkov
hristo.gochkov@bitsbg.com

> On 28.04.2015 г., at 13:37, Ivan Grokhotkov <notifications@github.com> wrote:
>
> Is there any particular reason to change the public APIs (i.e. rename ADC pin from 0 to 17)?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ficeto/Arduino/commit/5c941e7149b9dc6e6cd4ae894a8bafbb2d843c2c#commitcomment-10937730>.
>


V pohodě proto to píšu, je nutné oddělit práva pro crawler a pro oauth login uživatelů


good. will you push this in all travis files?


I'm not seing something maybe?


Je pensais que les `{"default":"18"}` permettaient de donner un valeur par défaut (sans devoir tout redéfinir).

Effectivement, on peut regrouper la majorité dans une unique variable `geometry` (et on laisse le soin à chaque interface de l'écrire selon ses besoins.

Le problème de l'ajustement des colonnes subsiste... Peut être ajouter une variable dédiée `column_adjustment` qui prenne les valeurs `none`, `one_more`, `only_one` ?


@ksooo
I also tested this and I must say I'm impressed.
I'm not actually getting the point of root timers, are that the timer schedules instead of the actual timers?


Should it be interrupt_handler instead of isr_handlers?


Ok. So, I'm happy to revert back to what you originally proposed, and I expected discussion this...

The rationale was that it is more DRY like this (**providing that we do expect all spend data resources in the package to use the same field names**).

eg:

this:

```
...
spend_resources: ["my-budget-1", "my-budget-2", "my-budget-3"]
mapping: {
"id": "pk",
"amount": "total"
}
```

instead of this:

```
...
mapping: {
"id": ["my-budget-1/pk", "my-budget-2/pk", "my-budget-3/pk"],
"amount": ["my-budget-1/total", "my-budget-2/total", "my-budget-3/total"]
}
...
```


:tada:


I wanted to denote with that name that `each` does not have any result apart of doing a `side effect`. You're right, `side effect` is something done in the function, not the function itself. :+1:


Caliburn-Micro License file


Noted.


Yeah, that's better.


```
if (mode == 0) {
  // mode is 0
 if (mode == 4) { ... }
}
```


Yes. Noted.


you do have GPIO0, it only makes sense A0 to not be equal to 0. Same is on the Arduino AVR platform


Better to use F_CPU here


For example: when we run the *ORKTest*'s *Mini Form* sample, if you go to the long form test, and tap the Blood Type field, it goes as follows:

    sV.cI.b: 0.00000000000000000e+00  bI: 2.16000000000000000e+02
      -> go inside

    sV.cI.b: 2.16000000000000000e+02  bl: 2.16000000000000000e+02
      -> don't go insde

And all works as expected. But then, if you immediately tap the Date of Birth field, this happens:

    sV.cI.b: 2.16000001770019935e+02  bl: 2.16000000000000000e+02
      -> go inside

    sV.cI.b: 2.16000000000000000e+02  bl: 2.16000000000000000e+02
      -> don't go insde

In the first function call after the second tap, shouldn't the check fail and thus not perform the contentInset updating? (As 2.16000001770019935e+02 looks like a CGFloat artifact).  [1]

The problem with `ABS(f1 - f2) > CGFLOAT_MIN` is that, given

       CGFloat a = 2.16000001770019935e+02, b = 2.16000000000000000e+02;

even though `b + CGFLOAT_MIN = a`; `ABS(f1 - f2)` seems to be `1.77001993506564759e-06` which is bigger than both `CGFLOAT_MIN = 2.22507385850720138e-308;` and `DBL_EPSILON = 2.22044604925031308e-16`.

With all this, in practice the `ABS(f1 - f2) > CGFLOAT_MIN` is worthless for numbers of these magnitudes, and we might as well go with a direct comparison (as it effectively produces the same result in the examples above).

Or, we can improve the float test as [explained here](http://stackoverflow.com/a/10335601/269753) but we'd then have to provide a developer defined comparison magnitude for floats (`K`).

More floating point comparison background info and heated discussions [here](http://stackoverflow.com/questions/17333/most-effective-way-for-float-and-double-comparison).

---

[1] Weird thing is that after this first artifact, `sV.cI.b` stabilizes and is always `2.16000000000000000e+02`, even if you tap back and forward between these two fields. I'm not sure why.

All this was tested on an *iPhone 6*.


This is dangerous when the duration is a bit longer, even a minute..
not setting it = any


Here it would be an incompatible interface change. By checking that this is zero now, we're make it possible to add input flags in the future.

What I understood from the mailing list was that unused functions should be removed.


yeah... :D stupid typo


That's the reason. And yes, we should not exaggerate in the use of friends :+1:


I second that. Perhaps test with a fair sized path length for the root
folder.
On 28 Apr 2015 11:28, "Éric Lemoine" <notifications@github.com> wrote:

> That would be great!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openlayers/ol3/commit/5522f053335f1b7d4cfc2c16e4b3f1a1163fd4e5#commitcomment-10937572>
> .
>


it's how I had it before, but it really does not matter what it is. Again, I just copy/pasted what I had previously worked on.


done, but not pushed


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14307/testReport/) for this commit**


Patch to fix code and respect PSR-2 conventions.


elegant!


Set this bit to assert DTR


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14308/testReport/) for this commit**


why are you not using the `:host` parameter directly? that's a much more flexible approach and allows for better testability. if you want to stick with this, i'd recommend calling it `locale` instead, that's what is used in the developer documentation: http://docs.aws.amazon.com/AWSECommerceService/latest/DG/AnatomyOfaRESTRequest.html


the branch you linked looks cool. just one small question - you implemented Future<?> call, but then you used a countdown latch for the sync call() instead of Future.get(timeout). why ?


А сейчас должна стать 1.2.3.2. В репозитарии я пока оставляю версию 1.2.3, чтоб после обновления из репозитария у них отработали запросы все скрипты.

Я вот думаю, может стоит хранить 2 версии, версию ТМ в модуле System.class и версию информационной базы в настройках ТМ. При  запуске/обновлении сравнивать эти версии и если они не совпадают, то предлагать обновить БД.
Благодаря этому можно будет смело накидывать версию из репозитария, а при запуске будет предложено обновление информационной базы.
Но во всей этой схеме есть уйма нюансов, которые надо будет продумать.


In my thought, this part of code just handles built-in window functions only.
And if a user wants to implement window function with frame support,
he or she can implement it by just defining as an aggregation function
because all the aggregation functions can be used as window functions and have window frame support also.


@ecdsa It's now implemented. I've kept the non-https running and added a second one on port 9090. See 4bed294ddd8fd4e95ebc19ca56731ed536ed8826.

It's self-signed for now, I am planning on buying a wildcard soon which will allow me to use a fully certificated one.


It is not possible to build rpm. You have to add hicolor_apps_symbolic_gnome-abrt-symbolic.svg instead of hicolor_apps_symbolic_gnome-abrt-symbolic.svg


Note that this by itself isn't enough. Since we have non-null file actions, glibc will still use fork.


Changing into the directory to make the paths relative solves additional problems related to special characters in the path.

A cd back up is not required.


На гихабе вроде бы есть механизм релизов? Я бы не рисковал всех сразу с репозитория обновлять - это все-таки код для тестирования и отладки в первую очередь.


desacer todo esto


I wish it was possible to "Like" commits on GitHub :)


I think the best thing to do here is to overwrite stdio before the posix_spawn call and restore them afterward. That's not thread-safe, but nix evaluation is single-threaded anyway.


No, it won't

```
  /* Generate the new process.  */
  if ((flags & POSIX_SPAWN_USEVFORK) != 0
      /* If no major work is done, allow using vfork.  Note that we
	 might perform the path searching.  But this would be done by
	 a call to execvp(), too, and such a call must be OK according
	 to POSIX.  */
      || ((flags & (POSIX_SPAWN_SETSIGMASK | POSIX_SPAWN_SETSIGDEF
		    | POSIX_SPAWN_SETSCHEDPARAM | POSIX_SPAWN_SETSCHEDULER
		    | POSIX_SPAWN_SETPGROUP | POSIX_SPAWN_RESETIDS)) == 0
	  && file_actions == NULL))
```


Maybe? It's just a list of potential components a project may have.


Yeah seems like somewhere it get re-fixed. I guess I missed that commit.


Ah, read the `||` as `&&`. So really instead we just get undefined behavior :grin:


Yes, it is. The relevant part is:

> It seems to be enough for European Portuguese keyboard characters such as ã (~ + a) but it might not be enough for other languages.

I made this some time ago, but if I remember correctly, the TextInput event failed for the following use case:

Usually, in order to type the character `ã`, I press the `~` key and immediately afterwards press the key `a`. It seems to work pretty much everywhere, but it didn't for XWT. I don't remember exactly what happened, but it wasn't the correct thing (maybe it would inserted `a` or it incorrectly inserted `~a`?).


Divné? Špecifikuj... Pri prihlásení ti Facebook strčí do ruky short term accessToken usera a zároveň v tejto chvíli musím overiť, či sa user loguje prvýkrát alebo už bol lognutý a má záznam v databáze, pretože user si kedykoľvek môže zmyslieť, že cez Facebook zmaže prístup k aplikácii.

Chcel som použiť Kdyby/Facebook mal som ale nejaký zvláštny problém s access tokenmi (pri volaní api "/me" Kdyby vracalo aplikačný token namiesto userovho access tokena a to potom zlyhalo na OAuthException (2500).  Pritom som sa riadil oficiálnou dokumentáciou, tak som si povedal, že dokedy to nebude nejako fixnuté, použijem Facebookovský JavaScript SDK.


Архив для обновлений у меня лежит на отдельном ресурсе. Я воспользовался возможностью создания персональных страниц на GitHub'e, залил все файлы тута. На выходных хотел разобраться с системой создания блогов на движке GitHub'a, но не удалось под это все выделить время.


Hi Benjamin,

On 28/04/15 11:36, Benjamin ABEL wrote:
> Hi Nico, sorry for the delay. I don't really have any need in terms of documentation, I just thought it would be nice to use ipynb files to show the |ijavascript| capabilities.

I like very much that idea.

> Maybe we could use |nbconvert| to make a users documentation with a custom template adding in the navbar links for api-doc, and maybe other things like github repo npm package...

That sounds good to me.

> Each page of the user doc may be listed in the landing page, and we could also add links in the nav bar using a node script during doc build.

I'm not sure I understand. Do you mean to write a node script that generates the landing page? That also sounds good to me.

I wonder if we could do something like JSDoc does and generate HTML from MD. Then, we could use the root README.md in github and a template to generate the landing page. This would ensure both github and landing page are kept in sync.

Nico

PS: Today I can't spend much time on IJavascript (I'm working on another project), but I'd like to explore the idea of using README.md and some template to generate the landing page.


Bro, if you check again this already happened? I caught that?


`side_effect` has the wrong convention: it should be `sideEffect`.


it's actually useful to keep these twi_* functions for compatibility — some libraries use them instead of Wire class.


std::abs is voor int, std::fabs is voor double/float
http://en.cppreference.com/w/cpp/numeric/math/abs
http://en.cppreference.com/w/cpp/numeric/math/fabs


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: collections


1: M100 needs more reviewers
1: M101 signature is missing


1: D100 Missing docstring in public module
3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing
22:1: I100 Imports statements are in the wrong order. from invenio.ext.mixer should be before from six
23:1: F401 'CollectionFormat' imported but unused
29: D101 Missing docstring in public class
33: D101 Missing docstring in public class
37: D101 Missing docstring in public class
42: D101 Missing docstring in public class
46: D101 Missing docstring in public class
55: D101 Missing docstring in public class
59: D101 Missing docstring in public class
63: D101 Missing docstring in public class


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
18:1: E266 too many leading '#' for block comment
20: L101 copyright is missing


3:1: E266 too many leading '#' for block comment
4:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
9:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
14:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
19:1: E266 too many leading '#' for block comment
20:1: E266 too many leading '#' for block comment
21:1: E266 too many leading '#' for block comment
23: L101 copyright is missing
28:1: I201 Missing newline before sections or imports.
29:1: I100 Imports statements are in the wrong order. import sys should be before import pkg_resources
29:1: I201 Missing newline before sections or imports.


1:1: E266 too many leading '#' for block comment
1: D205 1 blank line required between summary line and description (found 0)
3:1: E266 too many leading '#' for block comment
5:1: E266 too many leading '#' for block comment
6:1: E266 too many leading '#' for block comment
7:1: E266 too many leading '#' for block comment
8:1: E266 too many leading '#' for block comment
10:1: E266 too many leading '#' for block comment
11:1: E266 too many leading '#' for block comment
12:1: E266 too many leading '#' for block comment
13:1: E266 too many leading '#' for block comment
15:1: E266 too many leading '#' for block comment
16:1: E266 too many leading '#' for block comment
17:1: E266 too many leading '#' for block comment
19: L101 copyright is missing
27:1: I101 Imported names are in the wrong order. Should be find_packages, setup
28:1: I100 Imports statements are in the wrong order. import os should be before from setuptools
28:1: I201 Missing newline before sections or imports.
54:22: E231 missing whitespace after ':'


ok


Putting all those statements into one line supposedly tells the compiler that you want this function really-really optimized :)


We do not uses SidebarManager::NotifyStateChanges in browserAction CL.
This method is added in API CL. So if we need this change in browserAction, we need to re-organize patches.


4: L102 copyright year is outdated, expected 2015 but got 2014


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. from invenio.base.scripts.demosite should be before from .receivers
23:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.base.bundles should be before from invenio.ext.assets


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
23: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
24: D101 Missing docstring in public class
41: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
23: D101 Missing docstring in public class
68: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
25: D101 Missing docstring in public class
58: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
24: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
24: D101 Missing docstring in public class
31: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
22:1: I201 Missing newline before sections or imports.
23:1: I101 Imported names are in the wrong order. Should be CFG_WEBSESSION_GROUP_JOIN_POLICY, CFG_WEBSESSION_USERGROUP_STATUS
27: D101 Missing docstring in public class
85: D101 Missing docstring in public class
100: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
24: D101 Missing docstring in public class
31: D101 Missing docstring in public class
39: D101 Missing docstring in public class
91: D101 Missing docstring in public class
129: D101 Missing docstring in public class
186: D101 Missing docstring in public class
1477: D101 Missing docstring in public class
2015:356: B901 blind except: statement
2032:352: B901 blind except: statement
2066:594: B901 blind except: statement
2185:544: B901 blind except: statement
3035:260: B901 blind except: statement
3095: D101 Missing docstring in public class
4211: D101 Missing docstring in public class
4439: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
22:1: I100 Imports statements are in the wrong order. from invenio.ext.mixer should be before from six
23:1: F401 'CollectionFormat' imported but unused
29: D101 Missing docstring in public class
33: D101 Missing docstring in public class
37: D101 Missing docstring in public class
42: D101 Missing docstring in public class
46: D101 Missing docstring in public class
55: D101 Missing docstring in public class
59: D101 Missing docstring in public class
63: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
22:1: I100 Imports statements are in the wrong order. from invenio.ext.mixer should be before from six
23:1: I101 Imported names are in the wrong order. Should be Field, FieldTag, Tag
26: D101 Missing docstring in public class
30: D101 Missing docstring in public class
34: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
22:1: I100 Imports statements are in the wrong order. from invenio.ext.mixer should be before from six
23:1: I101 Imported names are in the wrong order. Should be IdxINDEX, IdxINDEXField, IdxINDEXIdxINDEX, IdxINDEXNAME
25:1: I101 Imported names are in the wrong order. Should be Field, FieldTag, Tag
25:1: F401 'Tag' imported but unused
25:1: F401 'FieldTag' imported but unused
25:1: F401 'Field' imported but unused
28: D101 Missing docstring in public class
32: D101 Missing docstring in public class
36: D101 Missing docstring in public class
40: D101 Missing docstring in public class


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
21:1: I201 Missing newline before sections or imports.
27: D401 First line should be in imperative mood ('Load', not 'Loads')
27: D202 No blank lines allowed after function docstring (found 1)
55:5: E303 too many blank lines (2)
310:5: E303 too many blank lines (2)
409:5: E303 too many blank lines (2)
457:5: E303 too many blank lines (2)
504:5: E303 too many blank lines (2)
525:1: W391 blank line at end of file


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
20:1: E302 expected 2 blank lines, found 1
20: D401 First line should be in imperative mood ('Retrieve', not 'Retrieves')
20: D400 First line should end with a period (not 'd')


should it be ```WIFI_OFF = 0```?


Nice! I haven't gotten around to fixing all of that yet, thank you :-)


Jde o to že u oauth nepotřebuješ to js a js nechceš použít, protože to není tak elegantní jako samotný oauth.

Kdyžtak ukázka jak použit kdyby/facebook https://github.com/KhanovaSkola/khanovaskola-v3/blob/master/app/presenters/Auth.php#L173-L208 a pak jenom dáš odkaz na přihlášení do šablony takhle: https://github.com/Kdyby/Facebook/commit/df08a11a3cd21022b0f057e251d574c527df78f9#diff-667f9d26765ce490d1b7242d4f3d39c5R174

Token ti to dá v pohodě, js není řešení.


That code is equivalent in its functionality... you've just made it longer for no reason.


Ah, good point; done.


@chokribr you should probably store number of unsuccessful attempts in database per IP. If you just pass it through POST arguments it can be easily modified - or the form can be reseted.


no, I think I had it in #define and just moved it over... I hate ugly code anyway :)


No in general.


"static" means that the variable is statically allocated.. i.e. not on the stack.  It sticks around in the heap.  This isn't really good for one-off initialization code


yeah...


Since you have rewritten the SPI library this code may be removed I suppose. I doesn't make sense to have two SPI libraries, right?


That would probably be better, since it preserves the user's format preferences.


no, it is not:

> the behavior is undefined if the process created by vfork() either modifies any data other than a variable of type pid_t

All we do in a fork: dup and close


Greetings shantu,  yep I am going to implement this on the raspberry pi, your code argument is well explained in your tutorial. I have searched so many source they are so complicated  +_+,  btw is there anyway to create a value/counter for each rectangle that has been created based on detecting faces. for example   we create and define int rectcount that will be accounted  according to the total rectangle that has been detected. I mean how the simplest way to define this code do I need to create new .py file called rect counter and  import the cv2, import sys and  your import  webcam.py or can I just put them all together ?  thank you very much shantu,

Sent from Windows Mail

From: Shantnu Tiwari
Sent: Monday, April 27, 2015 6:22 PM
To: goldenbucks/Webcam-Face-Detect
Cc: Josh Alexander

I haven't done this on the RPI, but it should be possible. You need to get OpenCV compiling on the RPI, which I heard isn't easy, but maybe somebody has a good tutorial.

After that, the code should just work, provided the webcam is easily accessible. I don't have a webcam for my RPI, so I don't know how it works. Assuming it's the same for any default Linux box, then you should be able to just use it.

Let me know how it goes.

—
Reply to this email directly or view it on GitHub.


I have it just until i check mine. It's redundant :)


I think it's still the same code. Does it pass the tests on your machine?


... indeed. We should get back to being more cautious about minor edits. I feel we're sometimes too trigger happy about "cleanup" changes that may seem justified but in fact generate a lot of commit noise. Let's please try to be better again at identifying real cleanup issues und sucht that aren't a good deal.


F_CPU again


There is no particular reason to use rand() over std::random.
Feel free to replace rand() by C++11 std::random.


Je n'en ai aucune idée... A priori, ce bout de code est censé faire la même chose que la fonction qu'il remplace.


> or calls any other function before successfully calling _exit()

But I might be wrong. Anyway, it works on linux. and linux guys thing posix_spawn as a syscall is bullshit and rely on vfork


You cut off the quote:

> the behavior is undefined if the process created by vfork()
> either modifies any data other than a variable of type  pid_t  used  to
> store  the  return  value from vfork(), or returns from the function in
> which vfork() was called, or calls any other function  before  success‐
> fully calling _exit(2) or one of the exec(3) family of functions.

Note the "calls any other function" bit


Need to find better way to implement this ... now the insert must match C_controller exacly


*Error


And btw if the return value from dup is checked that counts as modifying data.


Thanks. I agree.


Done exactly like this.


It also doesn't make a difference for me - simple `curl http://www.linuxfromscratch.org/patches/blfs/svn/pycairo-1.10.0-waf_unpack-1.patch` works.


How do you think I should tackle those? they are actually dividers. Maybe check the F_CPU and have them with different defines? When I wrote it, there was only 80MHz :) Or at least I had no clue how to bump it.


It seems to me that @teonlamont's commit is right in line with the pedantic nature of this repository, which in my opinion is ultimately a good thing.  I don't think we can have it both ways ... my two cents.


Then maybe we should use an #ifdef linux? glibc is used on other platforms.


The variables in the 2 lines below are actually used in the `sed` commands. At this time `$dbc_dbpass` is already empty, so the sed command is useless anyway. I think removing the 2 `sed` commands that change the database connection parameters is valid too, isn't it?


Having an issue with passing the id ..
mybe leave it for what is is and find better way to 'clean' rt_alarm


Why did you remove this?


`ivar` initialization has to be wrapped in synchronize block


stop_event read is not protected by synchronize block


Those that are SPI_CLOCK_DIVxM are okay, but SPI_CLICK_DIVx should depend on F_CPU.
I think two sets of definitions based on F_CPU should do the trick, at least for now.
Even keeping this is totally okay in my book, I just wrote the comment so I can find it when I need it :)


@adykstra you need to know when to be pedantic and when not ;) This is only one example, @teonlamont is not to blame for that, rather our collective practice. I think we should pace down a bit and post-pone merging until enough people have seen it. Many things are matter of debate and review. I feel the 2 reviewers +1 rule is not enough anymore for a repository of this size with so many active contributors.
We loose track of changes and this in turn generates unnecessary additional work.


I have to add the extended synchronization primitives to `Synchronization::Object` soon to be able to avoid this.


style changes in the middle of a new feature branch pollute the diff. If
@teonlamont had opened a new PR on style why not but here it multiplies
review time by 3 and creates more work than it should.


Not critical, this may be fixed later, but still, here we need to check if we got a NACK and return an error code as described in http://www.arduino.cc/en/Reference/WireEndTransmission
Same for si2c_read.


You love those "So's" :)


Btw, there is still a bug with parsing special chars like å, ø, æ, etc.


Function name should tell us what does the function do.
You've moved it outside luascript.cpp, so now it could be hard to tell how the function works without checking its definition.


else


Yes it should


JavaScript nie je *pekné* ani *elegantné* riešenie ale *je* to riešenie môjho problému, že som hodiny brúzdal a lamentoval nad tým, prečo Kdyby/Facebook pchá aplikačný access token, kam nemá. $fb->getUser() mi furt vracalo nulu a takýmto štýlom by som sa k ničomu nedopracoval.

Ostatne OAuth autorizáciu by som chcel vrátiť, ale dokedy nemám šajnu, prečo mi to nefugovalo, bude dobré keď sa uchýlim k nie tak peknému ale *funkčnému* riešeniu. Ak ale máš nejakú vedomosť, prečo Kdyby/Facebook pchalo aplikačný token namiesto user access tokenu, tak sem s tým =)


true that. btw I renamed all functions and I think I covered most of your remarks. will push now so you can see if I missed something (other than file headers)


I must have deleted it accidentally, I'll add them again later.


is this supposed to be commented out?


I've reused the same array modifying the length property. I haven't used *makeArrays* because the length here could be arbitrary, so we could end up creating a lot of arrays.


Could please remove this white space.


Just published the article and updated the Wiki as you suggested, thanks again!


co


Still finding it very unelegant (to compare would accept a PR on Java code with explict calls to the finalizer ? ), but if you are dead set on it, I'm no one to argue :)


Travis is now passing, but I needed to turn down a tolerance by two orders of magnitude so this test may be worth checking.  However, an old GLMM refit is now passing so that's progress.


Could you open PR for better discussion? I'll also try to pull it and help with some of the parts. The timet_set does not feel right I would like to have a closer look.


This is a bit scary. Is this one specified with type `timedelta` meanwhile the others ones are with type `int`???


Could you please make sure that line length isn't longer than 80 chars


All that work finally beginning to show in end product. Visibility switching should be snappier. Some slight rectangle glitches. More to come.


You can avoid `\` by wrapping in `()` :)


Orz


Onde tem código ou documentação para `has_legs`?


Why?!


ouais ouais ^^ en fait le `cache:clear` crée la structure, mais un `cache:warmup` serait plus judicieux


@Glenn-1990 Thanks. It's all based on the good work you've done before I jumped in.

I also do not like the term "root timers", still seeking for better wording. Root timers are all timers the user has configured, either timer schedules or one shot timers, but not the actual one shot timers automatically generated by the timer schedules. There was a request in the forum for the feature to be able to switch the timer view.


Timing function and loop may need improving, looked a bit clunky perhaps because the script isn't efficient enough. Found a hacky solution which was dividing the timing by 1.1 for the next animations and by 8 for prev animations - weird that they needed different timing but these divisions got the smoothest results in both cases.


Are you sure that you want to loose the optional parameter QWidget* parent = 0 behaviour which allows us to not write the last parameter MainWindow(settings);? In c++, we can't do : MainWindow(QWidget *parent = 0, QSettings settings);


& it was fun :D :+1:


If you can come up with a PR that copes with the following: -

  A path containing no spaces.
  A path with a folder name containing a single space.
  A path with a folder name containing a double space.
  A path with a folder name containing a ':'

Where the script can be called from within the bin folder and from a different location and in all cases successfully establish a JMX connection to a running server.

Then the PR will be more than welcome.

So far you have called this hacky and unelegant - I think you have set yourself a challenge ;-)

I am not dead set on anything - I await your PR with anticipation ;-)  My test environment is still set up so I am all set to verify.

IMO the script would look better if we could skip calling the jconsole binary and instead call java to execute the jconsole class directly, that we we could properly escape all special characters in the path but that has the big problem that we would call a class in the sun.* package so subject to change without notice.


Since this is a protected variable, do we really need to check the type, or would `if ( $has_forced_activated )` be sufficient and read slightly easier?


I also noticed the rest of the code for Cmdline_gl_finish missing, see 335b05c82a3a3e22ae6e905e5f4a9871469a11d6 for the original commit.  I'm not if its still required given that there's no remaining call to SDL_GL_SwapBuffers().  Anyway, if not needed then maybe the entire commit can be removed?


With a clear linespace below, the WPCS checks will say that attempted alignment here has actually got the wrong number of space.


Nit: It would be better to declare x_ret within this scope, instead of the outer scope. Same for y_ret in the scope below.


pushed :)


This looks obsolete as well


`@constructor`?


Hvorfor ikke bare have denne liste i `app_list(_)`?


Typo -__- ... Its should be "the different methods that can be used"


Ahh.. nevermind, så gør det det grimt at kalde den fra `:dev`.


Så der der bare denne ^^


apart from those few comments, the changes look fine.  Runs fine in a couple of test missions as well.


Another possibility can be to be able to switch between timers and timerschedules or show both.

i.e
timerschedule ("Cold Case" every day at 18:00)


Rozmýšľam, či urobiť nový súbor alebo opraviť tento. Názor?


You can embed it.


You forget to return function after if condition.


There might be a misunderstanding, this is the **style** in Step #3 from the instructions: https://github.com/abouffard/military-features-data/blame/v.next/data/mil2525d/utilities/style-utilities/manage-2525d-styles/README.md#L74 "you will need to use the desktop tools to import the style" (which I believe the user needs to manually do? - therefore the recommendation)


tohle bylo potřeba?


Fixes #3


Note: Although I initially made a change like this in my local copy of the code so that it would work with BoringSSL, which requires Z_is_one to be set, I believe that the BoringSSL code is wrong and I believe it is bad to set r->Z_is_one here. In particular, notice that nistp256.c and other files do not mention Z_is_one at all!

Further, I did some performance measurements (on BoringSSL), and found that Z_is_one has no performance impact at all. So, the best solution is to completely remove Z_is_one from the code.


jj v pistonu se iteruje Enum


That would cause a circular dependency on native:tz, as you need native:util/zic to build tzdata.

I see this is a simple and rather clean way to come around that problem.


Как логиниться, если нельзя регистрироваться? :-1:


We store the startTime & attachTime info on a local database as a django.DateTimeField


Calling @jonmeredith, legacy gossip strikes back...


Instead of a separate array, could you not sort on `$plugin['name']` directly?


What does that mean?


I'd rather be sure than be caught out by a custom implementation (as the class can be extended now).


IsNumeric will always be true, nothing in here is changing it.


❤ ♡ ❤ unicode ❤ ♡ ❤


Actually, the point is not fork/vfork, but posix_spawn. It sucks on linux, yes :-)

And tbh, undefined means "undefined in POSIX", in linux it is:

> the calling thread is suspended until the child terminates (either normally, by calling _exit(2), or abnormally, after delivery of a fatal signal), or it makes a call to execve(2).


Yes. Issue is CEP-1101. Sorry abt that. +1 for the idea to discuss with IS team and see if this can be fixed. Will start a mail thread...


Fixed


Ideally yes, but as we do not have direct access to this information at recipe parse time, we would probably need to add a USE flag for this, requiring developers to set this to the right value (and obviously setting it wrongly occasionally).

But if you look at the configure script, it does not do anything different for 2.6.x and newer, so you wouldn't actually gain anything by doing the right thing, other than troubling the developers.


We could use the very same variables to use TryParse with different data type, or you could use a regularexpression simply to identify whether the input number is numeric or not.


We tried this now, but we needed to duplicate three methods in the call chain with this pattern and the amount of duplicated code was a bit much. So we reverted to the current implementation.


hi problem wart 1.7.3.0    old _version  plizzzzz  updat


Specs should flow with the `it`, eg `it "tokenizes regular expressions that have explicit count modifiers"`


No you can't as the plugins array (which we'll be sorting) is a multi-dimensional array.


This is pretty much lifted from the OpenMM docs, so I still have to re-write it.


done


Same for Solaris ;-)


I suppose we could use something like `wp_list_pluck()` to generate the second array, but my current implementation is more efficient.


I'm a Sphinx noob, so I'm not sure how to get `load_rosetta` (which is just an alias for `chemistry.rosetta.RosettaPose.load`) to link to the module docs.


This is all just a rough outline of the example


Challenge accepted ;) - especially with such a details list, it should be easy to build a test script, and validate the proper behavior of the script.

But, before I jump into doing that, I also agree with you, firing a more simple Java class seems like a better idea. However, the sun.* packages are indeed kind of a blocker here (or are they ?)


I think that you can do "pkt->rxe = net_info_item->rxe" and remove from above "struct rxe_dev *rxe = net_info_item->rxe;"


FYI. I'm used to just run pybot against docs to get the reports, but that might require to register a few dummy directives to fix coupe with the differences between default docutils and Sphinx.

E.g.

    from docutils.parsers.rst.directives import register_directive
    from docutils.parsers.rst.roles import register_local_role
    dummy_directive = lambda *args: []
    options = ('maxdepth', 'creates', 'numbered', 'hidden')
    setattr(dummy_directive, 'content', True)
    setattr(dummy_directive, 'options', dict([(opt, str) for opt in options]))
    register_directive('toctree', dummy_directive)
    register_directive('robotframework', dummy_directive)
    register_local_role('ref', dummy_directive)


@ThetPaing


I think it would make sense to differentiate between "methods that are implemented/overridden as part of `SearchStrategy`" vs "methods internal to `BinaryTreeStrategy`'s implementation", perhaps via underscore prefixes?


MessageActionCreator now handles all action success / failure / undo, so its easier if they have a key of the same form
`type action ko/ok`


The repo now resolves to wordpress.org/plugins/... - therefore the `extend/` bit should be `(extend/)?` to make that optional.


Great, thanks! I'm going to make a small patch after I merge this. So have a look at that.


That would be an invalid record.


Seems like a mistake


Sure, good idea.
I wonder if this macro doesn't already exist, but anyway, it's written, it does the job, so it's perfect


esta be


I have no this repo. Can you fix it after accepting pull request?


Another possibility can be to be able to switch between timers and timerschedules or show both.

i.e A timer-schedule contains multiple single (normal) timers.
timer-schedule ("Cold Case" every day at 18:00)
      -> "Cold Case" monday at 18:00
      -> "Cold Case" tuesday at 18:00
      -> "Cold Case" wednesday at 18:00
      -> etc...

Maybe it's better to split up schedules and timers then, PVR_TIMER and PVR_TIMERSCHEDULE?
In this way every timer is a single one but can be created by a more advanced PVR_TIMERSCHEDULE.

iTimerType, bFullTextEpgSearch, bNewEpisodesOnly, firstDay, firstDay and strEpgSearchString will be members of a PVR_TIMERSCHEDULE instead of a PVR_TIMER then.

So strictly speaking timerecs and autorecs in tvh are timerschedules and dvrentries are regular timers.


no problem, not a big deal anyway. Let's give it some more uses and then we can conclude


If we're going to rename this maybe `PrintHouseUploader` would be more succinct?


ok thanks


ok, thanks


Melt


OK. Let's drop the parent arg for this case, there's no reason in keeping it in this case.


Why Different images not getting uploaded only  given banana image is uploaded
response is getting null


I haven't dived in yet to analyze, but this seems to break running upgrades:
```
2015-04-28 11:57:40,453 16509 INFO hsd openerp.modules.loading: loading 85 modules...
2015-04-28 11:57:40,463 16509 CRITICAL hsd openerp.modules.module: Couldn't load module auth_crypt
2015-04-28 11:57:40,464 16509 CRITICAL hsd openerp.modules.module: 'module' object has no attribute 'base'
2015-04-28 11:57:40,464 16509 ERROR hsd openerp: Failed to initialize database `hsd`.
Traceback (most recent call last):
  File "/media/data/src/odoo/7.0/server/openerp/cli/server.py", line 97, in preload_registry
    db, registry = openerp.pooler.get_db_and_pool(dbname,update_module=update_module)
  File "/media/data/src/odoo/7.0/server/openerp/pooler.py", line 33, in get_db_and_pool
    registry = RegistryManager.get(db_name, force_demo, status, update_module)
  File "/media/data/src/odoo/7.0/server/openerp/modules/registry.py", line 203, in get
    update_module)
  File "/media/data/src/odoo/7.0/server/openerp/modules/registry.py", line 233, in new
    openerp.modules.load_modules(registry.db, force_demo, status, update_module)
  File "/media/data/src/odoo/7.0/server/openerp/modules/loading.py", line 351, in load_modules
    force, status, report, loaded_modules, update_module)
  File "/media/data/src/odoo/7.0/server/openerp/modules/loading.py", line 256, in load_marked_modules
    loaded, processed = load_module_graph(cr, graph, progressdict, report=report, skip_modules=loaded_modules, perform_checks=perform_checks)
  File "/media/data/src/odoo/7.0/server/openerp/modules/loading.py", line 159, in load_module_graph
    load_openerp_module(package.name)
  File "/media/data/src/odoo/7.0/server/openerp/modules/module.py", line 405, in load_openerp_module
    __import__('openerp.addons.' + module_name)
  File "/media/data/src/odoo/7.0/server/openerp/modules/module.py", line 133, in load_module
    mod = imp.load_module('openerp.addons.' + module_part, f, path, descr)
  File "/media/data/src/odoo/7.0/server/addons/auth_crypt/__init__.py", line 21, in <module>
    import auth_crypt
  File "/media/data/src/odoo/7.0/server/addons/auth_crypt/auth_crypt.py", line 26, in <module>
    openerp.addons.base.res.res_users.USER_PRIVATE_FIELDS.append('password_crypt')
AttributeError: 'module' object has no attribute 'base'
```


This is not really useful, as the standard java mail API implementation is much too permissive, according to RFC822 so we end up with emails like "invalidEmail" being considered valid. See http://stackoverflow.com/questions/624581/what-is-the-best-java-email-address-validation-method

We need a better way to validate the emails that are entered by users in the more useful format (name@server.domain).


It's not terribly important to set it but it is important to clear it if it was set for |r| previously, otherwise your struct is in an inconsistent state. You did hit a bug. The BoringSSL code isn't wrong, it's just redundant and happens to trip on the inconsistent state.

ecp_nistp256.c don't appear to mention Z_is_one because they set coordinates through the higher-level EC_POINT API - EC_POINT_set_Jprojective_coordinates_GFp which handles it for them.

Pretty sure using BN_is_one() would have no noticeable regression but I didn't want to mix a bugfix with a refactor.


Yes it was handy before Rich introduced `some->` to clojure core. Actually, I was the one to add them to `clojure.core.incubator` :-)


@martygkaubitz That list supports List.set().


Seems like the latest build failed because the bandler couldn't handle circular dependencies.
Nothing wrong with the submodule.


The aesthetic I prefer when constructing service objects is to pass all dependencies, including parameters which are arguably dependencies, into the initialiser and then having a single method call which triggers everything


Weird, this is my code:

50900ff5511941488bdbe9be15f73cc9badcc9e7


as implementation with countdown was the first one. I will update it to use
the Future.
Did it work for you?

-kofemann
/** caffeinated mutations of the core personality */

On Tue, Apr 28, 2015 at 12:54 PM, Radai Rosenblatt <notifications@github.com
> wrote:

> the branch you linked looks cool. just one small question - you
> implemented Future<?> call, but then you used a countdown latch for the
> sync call() instead of Future.get(timeout). why ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kofemann/oncrpc4j/commit/b12889fc408b65b7be13c51bb70c07a6d742d46b#commitcomment-10937987>
> .
>


Good catch.


agree it's better that it's consistent. we should stick to seconds as floating point numbers here


Looks that you already fix it :+1:


This fixes a visual bug where the line would appear all blue.


Hey @s-e-g what is this file supposed to do?
Just curious


I am still having trouble with the dependencies. I will update that ticket if you don't mind looking at that.


Any reason for the explicit cast to array?


Thanks so much for pointing this out!
I also prefer pybot against my current solution. But because of my limit experience of sphinx and docutils, I haven't figure out how to do it.

Your solution is fantastic!


Thanks for the catch. I agree with you, it should be checking for type(sequence). Mea culpa.  I think more people are served by a fix than those who need to unwind a later hack. Let me know if you'd like me to to this patch, if you won't be.


![diagram encja-zwiazek](https://cloud.githubusercontent.com/assets/12049136/7369144/8bb97d6e-edaf-11e4-907f-67852a0a2e48.png)


Interesting, I was having this same issue here:

https://github.com/msanders/autopy/issues/32

I'll try this later.


I did not know, great!


Good idea. Will do that.


This is a no-op actually, because in both casdes an `int64_t` is casted to `int128_t`, but I found it was more expressive and consistent with the two lines below.


you want us to begin testing this before you merge this to oncrpc4j/master ?


I changed to allows for more descriptive tests. e.g. `expect(foo).to have_received(:call).with(argument)`makes it clear that we specifically care about `argument` in this call. If its passed in on a constructor then that expectation ends up hidden in code which is otherwise just test setup.

Take a look at what this test class ends up as for an example of what I mean. I actually made this change with that commit originally, but reordered the commits to put "staging" type work before actual functional change.


Two problems with this commit.

* The loss of the interface to endpoint mapping is going to impact logging; we cannot log the endpoint ID.
* Suppose an interface is owned by one endpoint, and it then gets owned by another (i.e. the same interface ID is transferred from one interface to another). Then the behaviour has changed.

I actually think the second is outlandish, and the first isn't all that strong (we used to always log the endpoint ID we were working on, but that is no longer the case). Hence this is "comments for consideration" rather than real disagreement.


6637 and 6658


Good commits :+1:


But thanks! :D


Why are you checking for `ftp://` then?


obecne novej, ale jak to jeste neni deployunute a stavis na tom ted jenom ty, takze to zmenit muzes…


ack


Hmm, yeah perhaps, I was trying to make it very clearly distinct from "UploadToPrintHouse".


There is always a risk with this that it starts to become a large task.  I think there are a few options but more ideas also welcome.

1 We do write a script that calls it directly buy maybe support using either an argument or an environment variable to override it.

2 We write out own class that calls it using reflection, if additional names are supported in the future that class can be updated to know them all - also the class can take an argument or system property to specify additional names.

3 We actually go with something like 2 but integrate with the CLI maybe add a -jconsole argument so the CLI makes the call, the CLI also supports a config file where we could override the default name.  For backwards compatibility our jconsole script can then just call our cli script with the appropriate argument.

Either way I think there are options - but we are certainly entering territory where you will find differing opinions.

My main consideration here is if we do do something that depends on a non-public class name have we left enough options to overcome that if it does change.  Also we need to be able to justify why but in this case it is to bypass the intermediary binary executable that is making proper escaping of paths problematic.


@rgrp @tryggvib

Note here that the following from Budget Data Package...

are `MUST`:

* currency
* granularity
* fiscalYear
* status

and `MAY`:

* `location`
* `type`

Only granularity and currency are in the POC CLI I did. I added the rest while doing the OSEP.

I actually think they are all `MUST`, with the possible exception of location. WDYT?


Thank you Emre, your handbook is very detailed!
Best regards
Jacky


Nice result :alarm_clock:


The whatsapp server checks a hash of the image, and if it already finds one copy, it doesn’t ask for a new one. This is why the (already existing) banana works

As for why others don’t, I don’t yet know (but it’s a bug most likely)

/Kim
> On 28 Apr 2015, at 14:57, anaghpatil <notifications@github.com> wrote:
>
> Why Different images not getting uploaded only given banana image is uploaded
> response is getting null
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/sumppen/WhatsApi4J/commit/a5cbcb6c5dc35d0fffeecead2146d879a0880094#commitcomment-10939100>.
>


See https://github.com/jakubpawlowicz/clean-css/issues/551#issuecomment-96868866 for details


Its not actually a case, its a coercion. It lets us handle non-array and nil cases nicely, i.e.:
```ruby
Array(job) == [job]
Array([job]) == [job]
Array([job_one, job_two]) == [job_one, job_two]
Array(nil) == []
```


Maybe use a block here rather than 2 separate inline `before`s?

Also, I prefer a gap between `let`s and `before`s.


You can also use `to throw` with an error instance, which is then compared using `to satisfy` semantics:

```js
expect(function () {
    expect.promise([]);
}, 'to throw', new TypeError('A function argument must be supplied'));
```


The problem I see here is that we're removing the GFDL from the doc, but do not provide another license instead :-(

While I'm not attached to the GFDL, I think we need to include a license in the Doc. Typically a CC-4.0 today would be a good choice IMO. As I own most of the IP of the original doc anyway, let's decide to move to that no ?

Could you amend you patch to add a ref to the CC-4.0 by SA http://creativecommons.org/licenses/by-sa/4.0/
HTML Code generated at https://creativecommons.org/choose/ is:

The HP-HOWTO de (c) Bruno Cornec and numerous other contributors est mis à disposition selon les termes de la licence Creative Commons Attribution -  Partage dans les Mêmes Conditions 4.0 International.
Fondé(e) sur une œuvre à https://github.com/bcornec/HP-HOWTO.


> uchýlim k nie tak peknému ale funkčnému riešeniu
nope :smiley:

Ne vážně, ta libka je použitá všude, určitě funguje.

```php
$fb->getAccessToken()
```
vs
```php
$fb-> getUserAccessToken()
```
https://github.com/Kdyby/Facebook/blob/master/src/Kdyby/Facebook/Facebook.php#L317-L326


ah ah, I knew you would react on this one :D :dancer:


I didn't see the `before` block a few lines up... Put these in there?


We should make that depending on the arch of the distro. Can be seen later on.


This branch doesn't compile on gcc 4.8.2, it seems that rvalue references need c++11 support?  I'll have to get my cpp11 branch merged to sort that out :)


Yeah good point, this test has a lot of setup because of the event wrangling so I was trying to group themes, but a before do end with a line will be clearer.


Yeah :D


Will this not prevent updates if one installs a dev version?

0.4 < 0.4.0.9000?


I mean specifically the `USE_VFORK` flag should be protected by an ifdef. On Linux it's not inherently undefined to call another function, but you have to ensure you don't corrupt anything on the stack, which generally brings in complications like "not modifying data in the parent process depended on knowing which variables were held in a register." The glibc implementation of file_actions doesn't necessarily do that properly, unless you've audited it? :grin:


I don't recommend to use update_attribute because it doesn't trigger validations and callbacks.


jednoduche prehodenie PaintTitle na toto miesto (namiesto riadku 4453) a PaintFunctions sa vola az po PaintHighlightBin


There's no other `tail` in scope.


What if it throws exception ? Then we should reject! this job. For now we reject only if currency is false.


IPv6 address will trigger the following status(I add some alert statements to show the variables):

PAC-alert: IP: 2001:da8:215:4078:250:56ff:fe97:654d
PAC-alert: atom: 2001:da8:215:4078:250:56ff:fe97:654d
PAC-alert: code: 0
PAC-alert: hash: 2001:da8:215:4078:250:56ff:fe97:654d
PAC-alert: codeHash: undefined
PAC-alert: maskHash: undefined

Use indexOf(":") >= 0 to recognize IPv6 address.


did you mean to remove this?


@LizaTretyakova Whaaaaaat?!

Oh, it works! Okay, but for the future: section as environment makes no sense, use `\section{}` instead.


The new URL could IMO be computed from the date:

http://news.netcraft.com/wp-content/uploads/2015/04/wpid-wss-share1.png


Yes, SO answer is too old. It was before dynamic vars had to be explicitly declared through the `:dynamic` metadata. It's assumed to be constant by default.


Too much happening in this `it` block? Perhaps break the doubles into `let`s and the `allow`s into a `before` block?

My preference is for the `it` to only have the assertion and perhaps the triggering action, ie `service.call(..)`


Yes, or maybe rename `_` to `content-type` or `_content-type` => then we do not lose the meaning of the argument


Erm – I wonder if this is a github bug?  The line isn't removed.  See the local output of `git show`:

```
diff --git a/_scripts/get_cv.sh b/_scripts/get_cv.sh
index b72bfff..8464b49 100755
--- a/_scripts/get_cv.sh
+++ b/_scripts/get_cv.sh
@@ -1 +1 @@
-curl "http://cv.democracyclub.org.uk/cvs.json" -o _downloads/cv.export.json
+curl "http://cv.democracyclub.org.uk/cvs.json" -fsS -o _downloads/cv.export.json
diff --git a/_scripts/get_el.sh b/_scripts/get_el.sh
index 882a9c5..a85b27a 100755
--- a/_scripts/get_el.sh
+++ b/_scripts/get_el.sh
@@ -1 +1 @@
-curl "https://electionleaflets.org/api/latest_by_constituency?format=json" -o _downloads/el.export.json
+curl "https://electionleaflets.org/api/latest_by_constituency?format=json" -fsS -o _downloads/el.export.json
diff --git a/_scripts/get_em.sh b/_scripts/get_em.sh
index 52ecaba..7cffc22 100755
--- a/_scripts/get_em.sh
+++ b/_scripts/get_em.sh
@@ -1 +1 @@
-curl "https://www.electionmentions.com/export.json" -o _downloads/electionmentions.export.json
+curl "https://www.electionmentions.com/export.json" -fsS -o _downloads/electionmentions.export.json
diff --git a/_scripts/get_meet.sh b/_scripts/get_meet.sh
index 51beced..0501d41 100755
--- a/_scripts/get_meet.sh
+++ b/_scripts/get_meet.sh
@@ -1 +1 @@
-curl "http://meetyournextmp.com/datadump/ynmpread.json" -o _downloads/meet.export.json
+curl "http://meetyournextmp.com/datadump/ynmpread.json" -fsS -o _downloads/meet.export.json
diff --git a/_scripts/get_ynmp.sh b/_scripts/get_ynmp.sh
index 137ded1..f71df96 100755
--- a/_scripts/get_ynmp.sh
+++ b/_scripts/get_ynmp.sh
@@ -1,2 +1,2 @@
-curl "https://yournextmp.popit.mysociety.org/api/v0.1/export.json" -o _downloads/ynmp.popit.mysociety.org.export.json
+curl "https://yournextmp.popit.mysociety.org/api/v0.1/export.json" -fsS -o _downloads/ynmp.popit.mysociety.org.export.json

diff --git a/_scripts/get_ynmp_numbers.sh b/_scripts/get_ynmp_numbers.sh
index 42d5e54..6169f77 100755
--- a/_scripts/get_ynmp_numbers.sh
+++ b/_scripts/get_ynmp_numbers.sh
@@ -1,2 +1,2 @@
-curl "https://edit.yournextmp.com/numbers/?format=json" -o - | python -m json.tool > _data/ynmp_numbers.json
-curl "https://edit.yournextmp.com/numbers/?format=json" -o - | python -m json.tool > _data_small/ynmp_numbers.json
\ No newline at end of file
+curl "https://edit.yournextmp.com/numbers/?format=json" -fsS -o - | python -m json.tool > _data/ynmp_numbers.json
+curl "https://edit.yournextmp.com/numbers/?format=json" -fsS -o - | python -m json.tool > _data_small/ynmp_numbers.json
\ No newline at end of file
```


Do we know why `observeData` and `closeObserver`have been commented out? We still reference them in https://github.com/PolymerElements/firebase-element/commit/4c51acd76fd090cc865b3d759629b33e27f05b83#diff-5191c63b6d1dae1e7108cdb4d32a52e2L383 and https://github.com/PolymerElements/firebase-element/commit/4c51acd76fd090cc865b3d759629b33e27f05b83#diff-5191c63b6d1dae1e7108cdb4d32a52e2L381 so curious :)


![Ghostbusters logo](http://upload.wikimedia.org/wikipedia/en/thumb/e/ee/Ghostbusters_logo.svg/512px-Ghostbusters_logo.svg.png)


I'd prefer this in a `let`


The first % should have readt `#`. The second is an even shorter shortcut than %1 if you expect an anonymous fn to be called with a single argument


Once this is finalized, please push it as seperate PR (or part of another one), but decoupled from the UI branch, so we can get it in early.


I'd prefer these in a `before`


This API call should not access the session, because flask-sessions depend on cookies being available, which might not be the case (and is not recommended for a RESTful API).
This API method was originally designed to start the knowrob/hydro-knowrob-daemon user container, so it should be hardcoded to that. For a more general approach, another API method could be introduced where the client can choose the application himself (e.g. /api/v1.0/start_container/<string:token>/<string:application>). The retrieval of available applications could be done by another API method (e.g. /api/v1.0/get_applications/<string:token>/).


Aha. My 2am google-fu was weak. Of course this was a thing that existed.


See previous concerns about `it` contents


And here


indeed


ok


`it`


![3v4ag8yrq wxr 74k5k zq](https://cloud.githubusercontent.com/assets/12136650/7369344/ebe97b1a-ede3-11e4-9d67-08953bea7492.png)
![Uploading 20150428_202244.png . . .]()
![20150428_202254](https://cloud.githubusercontent.com/assets/12136650/7369432/92c71014-ede4-11e4-9ed1-c3e318a2c210.png)
![Uploading 20150428_202303.png . . .]()
![Uploading 20150428_202312.png . . .]()
![Uploading 20150428_202324.png . . .]()
![Uploading 20150428_202212.png . . .]()
![Uploading 20150428_202222.png . . .]()
![Uploading 20150428_202236.png . . .]()


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/88fd61f62c9d0dcd1a022331a23b43e4e94b32d6


merging basho/riak_cs/feature/block-audit = 88fd61f6 into borshop-integration-1133-feature/block-audit


basho/riak_cs/feature/block-audit = 88fd61f6 merged ok, testing candidate = 06be1814


Omylem jsem to dal rovnou bez pull requestu. Da se to tu nejak odrolovat? Sry


Je sais pas si c'est quatre lignes sont utile.


Why a static `IEclipseContext`. I would not have expected those to be shareable across threads, which it will probably end up being used as?


TeamCity Nuget Packages :: Solink.AddIn.Helpers [Build 7](http://mufasa/viewLog.html?buildId=3227&buildTypeId=NugetPackages_SolinkAddInHelpers) outcome was **SUCCESS**
Summary: Tests passed: 17 Build time: 00:01:17


beware using clojure invokers inside plugin start. I think we have already talked about it, so maybe it is fixed in a later commit?


thx!!


La c'est moche, au début, je voulais partir sur un return self.create(request, *args, **kwargs) dans ma vue mais j'arrivais pas à accéder à l'id du topic depuis la fonction save dans le serializateur.


Je sais pas si c'est deux lignes sont vraiment utile.


Please remove this comment.
maybe implement it like here: https://github.com/Catrobat/Catroid/blob/feature/lego_nxt/catroidTest/src/org/catrobat/catroid/test/devices/mindstorms/nxt/SensorTests.java#L80


This will enable to sort tables by pressing the thead atttibutes in the table.

Required Layout
<table>
 <thead>
  ...
 </thead>
 <tbody>
  ...
 <tbody>
</table>


That parameter is a TimeDeltaParameter in scheduler.py, and that parses the the value and  converts it to a timedelta. Isn't it more intuitive to understand the string "16 hours" instead of 64800, for example?


Now we can assume e4 is used.


J'ai séparé la fonction en deux, j'ai pas changé la signature de la fonction.


Updated


@Sanne : can this be moved to org.hibernate.search.cfg.spi ?


Yes, this absolutely should work. (That's what I get for committing without testing.) Would you like to propose a PR to enable that behavior?


right, makes you wonder why that check is there at all. With the "it would be nice to lower maintenance effort going forward"-hat on, I would say we should make a patch allowing you to set the kernel version through configure, with fallback to 'uname -r'. That should be possible to get upstream right?


![Uploading 20150428_202236.png . . .]()
![Uploading 20150428_202244.png . . .]()
![Uploading 20150428_202254.png . . .]()
![Uploading 20150428_202303.png . . .]()
![Uploading 20150428_202312.png . . .]()
![Uploading 20150428_202324.png . . .]()
![Uploading 20150428_202212.png . . .]()
![Uploading 20150428_202222.png . . .]()


Security regression: The volumes of user containers should be all read only, user_data should not be mounted at all:
```
ENV DOCKER_VOLUMES knowrob_data:ro mesh_data:ro summary_data
```
summary_data can be read-write until we figured out a way to prevent users from deleting/changing other users' summaries without limiting the ability to share summaries with others.


Dans l'ancien code, ces lignes permettait de tester si les participants avait lu le dernier message. C'était utile pour ne pas leur renvoyer 15 emails si ils pas eu le temps de lire la dernier message.


I don't like this approach. What if you ever want to grep it by "ack_" etc. Almost impossible. Create helper method that will take column name as a argument and return proper glyphicons.


Faudrait que je pense à faire un retour à la ligne


> The loss of the interface to endpoint mapping is going to impact logging; we cannot log the endpoint ID.

It's not clear to me that we have to: there's a good static mapping of endpoint ID to tap interface in etcd, and so in practice this shouldn't be hard to find. It certainly doesn't seem like logging that information should be the responsibility of this class, though I could see wanting to do that.

It's also worth noting that this statement:

> we used to always log the endpoint ID we were working on, but that is no longer the case

is not true anyway. I've changed the log in two places: whenever you printed the `DispatchChain` object itself, and in `on_endpoint_added`. In `on_endpoint_removed` and `apply_snapshot` we did not previously log out endpoint IDs. I therefore find this argument substantially less than compelling :wink:.

> Suppose an interface is owned by one endpoint, and it then gets owned by another (i.e. the same interface ID is transferred from one interface to another). Then the behaviour has changed.

The behaviour *has* changed, for the better. Previously the system would regenerate the chain for no reason, as it would render out identically: the rewrite avoids this problem.


Is this required for interop with eclipse databinding? If you have a good resource to help me understand in a nutshell how eclipse databinding works (for at least the way it is used in CCW), that would be helpful to me.


`"rcmd"` appears to be a copy-paste typo. According to the code below this probably should read `HTTP`.


You got all, except for 1 from that other issue, on line 14:
> 'think at Redis' should be 'think of Redis'.


This should be `It("parses it into a set of known parameters", func() {`


`It("returns an error", func() {`


can you refresh my memory, how is it automagically injected?


Hi Zack,

I think this change is responsible for the `next.offset` positioning feature not working properly any more.
Because this change moves the definition of next.page.bottom into a conditional (it now is only defined for absolutely or relatively positioned body/html elements). As a consequence, the second condition in line 436 (see https://github.com/HubSpot/tether/blob/master/coffee/tether.coffee#L436) will always be false (next.page.bottom >= offsetPosition.bottom).
Maybe I'm misinterpreting the how and when positioning through `next.offset` should happen or I don't fully understand the intentions of your commit ... could you maybe elaborate a little bit more about why you made this change?

Regards,
Nicolas


此处单位是miliseconds


yeah, the stats is a per-pg state shared among the peers.


Wouldn't `sanitize_key()`, or `sanitize_title_with_dashes()` be better for the plugin slug?


This function is not supposed to be used externally; you should use rtp_profile_new().
If you look at the usage of av_profile_init() you will see that it is used for initializing the default RTP profile, which is a static variable that is never freed.
(cheers from Grenoble)


Will a user understand what a `no-modifier` is? (what is it, btw :-p )


Putting things in lets and befores that aren't shared between specs does nothing but hurt readability.


Define as constant


this does fix the "5/4" in the statistics.


As mentioned before, negative eigenvalues are not a bug, they are clearly a nuisance and an issue needing to be addressed. Currently we address these during the tensor estimation process, as dtiestim has 2 options  (--shiftNeg and --shiftNegCoeff) for that purpose. Also ResampleDTI and ResampleDTILogEuclidean has a way to deal with it, as tensor interpolation can create such incorrect tensors (--correction <zero|none|abs|nearest>, which either sets bad tensors to 0, or uses the absolute values of the eigenvalues or maps it to the nearest valid tensor).

You see there is not one single correct/expected way to deal with this, but rather multiple possibilities. Using SVD is just another such possibility.

Re ordering, not sure why there is an option to not order the eigenvalues. I can't think where that would be needed, eigenvalues should always be ordered for diffusion imaging (highest to lowest).


Is this change in behaviour really intended? The change is now skipping all sockets that start with `unix:`, `tcp:` or `fd:`. Previously those prefixes where only stripped. With this change I'm wondering which socket types remain that would actually result in a `ListenStream` directive.


What's `foaf:facebook`, `foaf:github`? Can you point me at their full URI where I can read their definitions?


It is working properly, just use the system files I uploaded and delete this directory /data/misc/wifi/


Make sure that this RDF Turtle validates!


Do we simply not need this?


The dependencies are a set, while the updates are a list (i.e. I think you have got assertEqual and assertItemsEqual the wrong way round).


this one can be squashed with its parent


`<"blue">` doesn't seem valid to me.


@dsego Regarding your last comments on styling


Co sa tyka access tokenu, tak v dokumentacii sa bohuzial nepise o jeho dlzke a jeho dlzka sa moze menit. Rozmyslam o zvacseni tokenu.


Cn


`interests` is missing a prefix declaration.


yes it's fine with you. We have internal review as well before I can push
into master.

-kofemann
/** caffeinated mutations of the core personality */

On Tue, Apr 28, 2015 at 2:07 PM, Radai Rosenblatt <notifications@github.com>
wrote:

> you want us to begin testing this before you merge this to oncrpc4j/master
> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kofemann/oncrpc4j/commit/b12889fc408b65b7be13c51bb70c07a6d742d46b#commitcomment-10939228>
> .
>


@m-stein: can you review it as soon as practicable? I really do not like to rebase it once again, if possible. It does not touch functionality at all, but moves code around.


Nice @rafaelstz !


fine commit


Yeah, its one of those cases where Factories would actually make the specs much terser. Wouldn't need all of the explicit instance variables. Don't want to go down that road though...


What does `http://example.org/friend/1.0/` relate?

What's `http://adrianzysset.wordpress.com/`? Is it a document (e.g., `foaf:Document`) or person (e.g., `foaf:Person`)?


http://stackoverflow.com/a/16365828/326257
> We did give guidance in one place about it being 255 characters. I've updated the blog post that had that information and updated our new access token docs to include a note about sizes:


Hello,
I don't think it's a good thing to return a boolean, because if we use native functionality of redis. We could delete many keys in same time. So the return would be an integer.
CF PR #3214
Unfortunately this PR was closed without any reason.
Thanks


this one can be squashed as well


you’re right – does appear to be a github bug


There is an Asciidoc notation for menu entries. If I remember well it's `Preferences:[Clojure > Editor]`. There are probably some examples in this file.


I maybe disagree with myself now after looking at your comment on the other commit.

Is it not clear what is setup, what is under test, and what is expected behaviour? If not then I'll definitely refactor this.