 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/fa16bcd08e970e903b1bb64b5a6a154843f0ae8b/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/fa16bcd08e970e903b1bb64b5a6a154843f0ae8b/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/fa16bcd08e970e903b1bb64b5a6a154843f0ae8b/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/fa16bcd08e970e903b1bb64b5a6a154843f0ae8b/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/fa16bcd08e970e903b1bb64b5a6a154843f0ae8b/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Условия и действия в этом цикле выглядят запутанными. Стоит добавить комментарий и (или) разбить на функции.


The attached file is a basic GUI currency converter written in Python, using Tkinter

The section of the code that implements YQL and JSON to access Yahoofinance.com was taken from a tutorial on the following website
http://www.idiotinside.com/2015/01/28/create-a-currency-converter-in-php-python-javascript-and-jquery-using-yahoo-currency-api/
and then adapted slightly for my needs
NOTE: This code was not my original work, (I appreciate the work of the original author, thanks)
All other code was my own, please feel free to use it if, and however you like..

Any improvements/suggestions or criticisms would be very much appreciated

Thanks

fljdev


Функцию стоит назвать просто `main`


Is there a preferred way of handling comments in a template?


rax retry tests


No, the while is just for efficient.  if the end arg is.small, I dont want to list the full collection and then pop out a lot at the end of vector<ghobject_t> ls. Instead I try to do that in small batch, only read get_ideal_list_max number of object each time.


/play yeah


Suggestions for itemdisplayname: Create a VM with Empty Data Disk


Just a heads up that this should now be fixed in the latest release. Cheers :)


Suggestion for itemdisplayname: Create a VM from User Image


I had mistakenly thought that this indicated the end of the list in a reading of another area of the code where we had an iterator. Upon review, I realize that this was incorrect.


Reference: http://stackoverflow.com/questions/5323478/how-to-use-extension-and-typeof-in-a-minified-example-in-c


This file is meant to either exist or not exist, and currently the `qubes-whonix` `/usr/lib/qubes-whonix/init/init` set the files to search for.

This was meant to have it more generic so another package could also use it.  If we created such a directory, protected-files.d, then it would add to the complexity where we would need to  search within that directory? Or would you suggest a grep 'filename' `/var/lib/qubes/protected-files.d/*`.

I do like the idea of the `protected-files.d` directory better though.

What other location would you suggest to place these files?


The software that trolls the git log looking for contributors will try to match whatever++ against the things in U: and N: entries and then output the N: entry.  So, set the N: line to be how you'd like to be credited and add a U: line for eli-se (there can be multiple U: lines per entry).


Money and number have the same sql type, you can just do an identify call like formatCall("%s").  There is another place further down that does the same thing.  Create a function and share between them.


Agreed.


That's something we don't have currently. The ARM team is thinking about ways to mitigate it


r+


Add one more test that compares numeric field and money field using <>.


How would you like me to handle it for this pull request?  I can remove it if I have to.


same as in PIXI.Text. Im not sure why, but at least the behavior of bitmaptext and text is now the same


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nice catch. Thanks!


saw approval from gmarceau
at https://github.com/MonsieurNicolas/stellar-core/commit/a0e66eb1eddcfcda6e3b78b25ca9fd69297a9f5d


merging MonsieurNicolas/stellar-core/testNetFixes = a0e66eb1 into auto


MonsieurNicolas/stellar-core/testNetFixes = a0e66eb1 merged ok, testing candidate = 4b0fbd86


Здесь всё неплохо, есть лишь мелкие замечания: стоит добавлять пустые строки между блоками кода, например, после условий с `continue`, это немного разобъёт код.

Также про комментарии: стоит выдерживать тот же отступ, что и у кода, а также часто добавляют пробел после `#`, чтобы символы не сливались.
```python
# comment
for x in range(10):
    # comment
    if value in stop_list:
        # comment
        process(value)

        # comment
        output(value)
        continue

    # comment
    # comment
    make_solution()
```

Сильно увлекаться комментариями не стоит, лучше выделять код, который требует комментария, в функцию с хорошим именем (к которой можно написать docstring).


Oh, I see.  Why not just let the index->collection_list_partial do that
loop and put things directly in the final vector?


Done, and thanks.


The code seems fine if this is the feature that has been requested. But it seems a little weird to me that width and height of the view would be set as a side effect of setting window. I would think it would define a region of the image to display inside of the view at the existing size. Then you could apply the stretches attribute as usual for the image, just pretending like the image was the size of the defined window.


Ya let's remove it. Currently the Azure CLI will error out while trying to deploy templates with comments


Создание переменной с таким именем должно сопровождаться комментарием о том, что предполагается для хранения в ней, чтобы читающему не приходилось выяснять это из кода самостоятельно


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This recursive call causes a `CONNECTION_LOSS[-4]` exception to be thrown after closing the `HighLevelConsumer`.

I think a `Zookeeper.prototype.close` method that stops the loop is necessary to close cleanly.


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Not sure which is "best" `if (name == string.Empty)` or `if (name.Length == 0)`?


For the min arg, actually other than Filestore,  keyvalue/mem doesn't handle the value at all..
I remove it  because I am not sure if any caller really need the min. In what case the caller will be unhappy if min < max but everytime they get max number of objects?


Oh, wait, that is what's happening... I'm confused because the BitmapSprite sets the width and height of the view


@roderik is there a way to override setting the TZ here? Wouldn't letting the OS default prevail be the best for most users?


It would be awesome if ceph-osd-prestart.sh could call out to a small binary that only has CAP_CHOWN. That would allow us to run the entire service under the unprivileged UID, right?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The problem was both network-manager and NetworkManager were being started, cause of an issue in Wheezy.  There was some wheezy bug it seems that kept the `/etc/rc3.d` as active and would still start even if `NetworkManager` was disabled.  It was really strange behaviour.  This not not happen in Jessie.

`NetworkManager` gets reenabled within the `reenableNetworkManager` function which gets called in the trigger section.  The `configure` section initially calls triggers to prevent duplication of code (this is still the original behaviour)


Excellent! Thanks for letting me know!


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


se tem hiv


On Fri, 24 Apr 2015, Xiaoxi Chen wrote:
> For the min arg, actually other than Filestore, keyvalue/mem doesn't handle the value at all..
> I remove it because I am not sure if any caller really need the min. In what case the caller will be unhappy if min < max but everytime they get
> max number of objects?

Yeah... you're probably right that we can just drop it.

The original idea is that the caller can ask for 50 - 100 records, or
something, and implementation can return some number that is more
efficient for restarting the iteration.  It (theoretically) makes a
difference with filestore because we want to stop iterating on a directory
boundary, but in practice it looks like we forgot to override the
get_ideal_list_min/max() functions in FileStore.h anyway.  :/


LOL !!!!


Line 11 also has a comment referencing this.


Can be removed, too.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


MP = MP + player:getMaxHP()/2;


@only-a-ptr Thank you, build is working now. Shall I post the pull request with changes?


Should update that docs to say `slick-theme.css` should be included when including necessary files for slick to work. Without it, the arrows lose all their styling, amongst other things.


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


> This was meant to have it more generic so another package could also use it. If we created such a directory, protected-files.d, then it would add to the complexity where we would need to search within that directory? Or would you suggest a grep 'filename' /var/lib/qubes/protected-files.d/*.

The later one - grep all the files there. It's probably easier to use `grep -r`, which will nicely handle empty directory.

> What other location would you suggest to place these files?

/etc/qubes/protected-files.d? Or /etc/qubes-protected-files.d.


@FlorianPalm @jpfr is it correct?


Perhaps this needs reevaluated?  In my rails 4.1.6 app this is causing it to look first for index.jrxml which fails (quietly) because not all of my index actions have reports.  But this causes a slowness in my application.


@FlorianPalm @jpfr is it correct? 3 orders of magnitude bug?


This swaps the ordering, so /classes is appended at the end of classPathArgs rather than going in front. Does the ordering matter?


You don't need to repeat this command since you just showed it in the previous paragraph.


I think it is first come first serve.


Ok, I've missed that triggerTriggers call.


It's right there, like line 6


The lack of web standards strikes again.

What about pages that don't allow inline scripts? ('unsafe-inline') https://developer.mozilla.org/en-US/docs/Web/Security/CSP/CSP_policy_directives


adsada


You're repeating a command again, so remove it.


Why is error code `422` in `response_parser.rb` but `400` in the `app_required.rb`.

Shouldn't they be the same?


In any case, as you know, there are lots of getGameMap()->isServerGameMap() in the code. If you want to go for adding the server/client origin to entities, you don't have to do it everywhere. You can just start where you need and let the remaining for later (but if you do that, please open an issue so that we can remind that this needs to be done).


Meant on this site: http://kenwheeler.github.io/slick/

Towards the bottom it doesn't mention it and without including http://cdn.jsdelivr.net/jquery.slick/1.5.0/slick-theme.css the arrow stylings were lost.


`UseMatroxHal` still defined in:
  - `nx-X11/config/cf/xfree86.cf`
  - `nx-X11/config/cf/xf86site.def`
  - `nx-X11/config/cf/xorgsite.def`

Should also be removed.


I don't *care* much about it, but find it entertaining to *muse* on the subject - so thanks for the input. And on a similar note; you might have noticed, that I like to experiment with punctuation too :-). (That's probably all a result of my journey towards my own personal lisp style sense...) And once more the rules for the English language could be summed up as "the opposite of what the Germans would do". It was a happy surprise, when I recently learned that "Oxford style" is a thing, and that it is not universally considered to be *the* way to do it in English. Strangely, I am sticking to it.

Anyway, I'm gonna (I like that one, just like "ain't") use "data loss" then. For someone who isn't a native speaker it's not always easy to know when to write the compounds together and when not. English ain't particularly consistent in this regard (or in general). It's probably the same with German (I find it very strange to capitalize that since not all nouns are capitalized. It kinda implies that one's nationality is more defining characteristic than, say, one's gender). (The placement of the period after a fragment in parentheses also is a fun one => ). (Or when a smiley is involved :-). Does that face have a pimple on its chin?

Anyways (do English speakers sometimes use the incorrect plural for emphasis too?) (While I usually place the period outside the parenthesis, I never do that for question marks). *Anyways* (as in a-more-emphasised-anyway) where was I? I like hypertext - no that's not it.. lack of consistency!: snapshot.

(Regarding "anyways" and such: The hardest part about using a foreign language is that one never knows when an intentional departure from "the rules" would be considered a *mistake* or be recognized as such (I mean, not only poets should be allowed to do it, even foreigners might have a thing for it). A native speaker would - or so I expect - usually classify it a mistake, due to the fact that there *are* "unintentional mistakes" to be found in the surrounding text).

(One thing that I like about programming languages, is that I can grow and follow my own rules. And while other people might have different opinions on the matter, there are no native speakers to decide on what is correct).

Why "snapshot" but not "dataloss"? - you never know. And it seems my spellchecker spell checker spell-checker doesn't either. When I were to type "spellchecker" (which I would not, it looks ugly (it seems that when in doubt I use prettiness as guidance)) it suggests "spell checker" *and* "spell-checker". It I were to type randomwords, then it would even suggest "random-words". (And as much as the Lisper (take that) in me would like that the Swiss (German) in me would find "spell-checker" distasteful).  So, unfortunately, I cannot rely on my spell checker here. While the rest of this post is mostly for my own amusement, here's a serious question: is "compound-compound" *ever* correct? Examples?


You should intersperse these explanations so that it goes more like:

---

We delete all the breakpoints with the `delete` command in gdb:
```
(gdb) delete
Delete all breakpoints? (y or n) y
```
Now let's verify that they're deleted:
```
(gdb) info b
No breakpoints or watchpoints.
```

---
Interleaving the explanation more makes it clear what goes with what, and let's you remove a lot of your text.


Oh I see, `422` is response from broker and `400` is response to client? If that's it the cool, ignore comment above.


The content is now good, but I still want you to make some style changes before I merge.  I'll up the extra credit to +25 pts total.


`HaveMatroxHal` still defined in:
  - `nx-X11/config/cf/xfree86.cf`
  - `nx-X11/config/cf/xf86site.def`
  - `nx-X11/config/cf/xorgsite.def`

Should also be removed.


@ImALuckyGuy PM me on tf forums or something, we needa talk


There is a `aptUpgrade` and `aptDistUpgrade` function in `distrubution.sh`.  Both functions were calling the same `dist-upgrade` when `aptUpgrade` should be calling `upgrade` as that would be the expected behaviour.

The real difference between `upgrade` and `dist-upgrade` is that `dist-upgrade` will install additional packages that are not already installed on the system currently and `upgrade` would never allow an additional package, only updates to existing packages.


Never use `this` as a noun.  Better is `the output tells us...`


Same for `BuildMatroxHal`.


>Oh, I see.  Why not just let the index->collection_list_partial do that
>loop and put things directly in the final vector?

Yeah, that should be the right approach... we can do that naturally in HashIndex::list_by_hash. I just a bit lazy yesterday since there are some *Index around at the first glance, so I left it as to-do in commit log,  but actully only HashIndex implemented this.... yeah, will make it done today:)

Same story in KeyValueStore, we could put that into GenericObjectMap/DBObjectMap....


This sentence is too long and needs to be separated into multiple sentences.


This sentence is too long.  You can delete the phrase `useful information about your breakpoints such as` without losing any content.


Err, badly named commit message.  Was supposed to be "Optimization to clipping."


In general, your writing has a lot of superfluous words like this that should be removed.


`BuildDBElib` also defined/used in:
  - `nx-X11/config/cf/X11.tmpl`
  - `nx-X11/config/cf/xfree86.cf`
  - `nx-X11/programs/Xserver/Imakefile`

Should also be removed there.


Sentence is too long.


It would be syntactically nice if we appended ";" at end of lines where applicable.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/59951578


Why does it have to be "after several runs through the file"?  What does a "run" even mean?  Delete this phrase.


Comma at the end of 103


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (345 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


You need to interleave this text with the example above.  See my more detailed comment below.


What is this patch for? Is it to fix a try/catch functionality issue when executing ExtendScript code that has try/catch block with Extendables imported/included? Or is this for something else I'm not aware of?


[![Grand Canal from Palazzo Flangini to Palazzo Bembo](http://api.artsmia.org/images/1673/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1673)


You should never say "continuing with our previous example".  You're ALWAYS continuing your previous example in a good writeup.


Forgot to mention! I also added some graphics for unimplemented items, and the aliceBlock, which looks quite pretty. All graphics(tm)(c)(r) by me.


s/feel that you//


Luckily that's ok in javascript (but not JSON). Will remove anyways.


I would suggest `/etc/qubes/protected-files.d` to be able to group future qubes configurations into one directory?


Actually, this whole sentence can be shortened considerably.


Since an HTTP redirect response has no body, we can just return right here and not render any of the HTML on the rest of the JSP.


Ohh, and the which vs. that thing...


@skybon: Yup, create a pull request. Thanks


I like this. Less lines than the alternative and still easy enough to understand.


If a user lands on the edit page after an add, then saves a change, they'll still be shown the "Successfully added..." info box.  We'll need to tell the form not to automatically keep sending that parameter.


fast-forwarding master to auto = 4b0fbd86


Still mentioned in `nx-X11/config/cf/README`, should also be removed there.


well done on all the work been trying hard to get discovery and discovery use also history,hard links to grab


Not sure I support this change. It is redundant, but 6 months from now I'm not going to remember that or which access modifier is the default. I would prefer to keep all access modifiers explicit even when not strictly required.


I know you disagree, but we really should be deleting the other RC first. We want to create a validation check to prevent overlapping RCs, and we'll likely have annotations and tools that expect just one RC at a time. Overlapping RCs is almost always an error, and the RC controller isn't going to do anything sane in this case. A small window with no RC is not much different from a small window where the controller manager is down.


@only-a-ptr There's no way to have two open pull requests by the same person. Could you please merge or close the one with MyGUI fixes?


@desandro So just to confirm: jQuery plugins would be `globals` under this categorization scheme?


Please check wether rec is null and throw a IAE if so.


This feels like the wrong place to do this.  I'm open to alternatives


saw approval from MonsieurNicolas
at https://github.com/gmarceau/stellar-core/commit/8ae2bf4774bd9eea7f231aa678549e4495e1674b


merging gmarceau/stellar-core/item-fetching-cleanup = 8ae2bf47 into auto


merging gmarceau/stellar-core/item-fetching-cleanup = 8ae2bf47 into auto failed


I would personally like to add a small exception where we allow overlapping replication controllers as long as the desired replica count is the same.

I'm worried about the "update and walk away" case, which leaves a user without a replication controller for a long period of time.


Also a some checks are missing here like ```if (read == null) throw new IAE()``` or whether cigarStartIndex and cigarEndIndex are correct... again may be should be addressed in that separated issue/pull-request.


On Fri, Apr 24, 2015 at 03:57:11PM -0700, nrgaway wrote:
> I would suggest `/etc/qubes/protected-files.d` to be able to group future qubes configurations into one directory?

Ok.

--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?


If this fails, we should abort: it means we have keys locally but the server doesn't.


If this fails, we should abort: it means we have keys but the server has newer keys, and we're not prepared to handle that.


Too much abstraction. Will provide a simple byId() and byName()...


`XCURSORLIBDIR` is gone, can be removed here.


I have single quotes burned too far into muscle memory, so I'll just make one pass with the script when I'm finished.


String interpolation is preferred over string concatenation in this case. You can do string interpolation in ruby using `#{}`.  This also automatically converts the object to a string for you (so you don't have to explicitly call `#to_s`)

```ruby
"#{searchworks_uri}/view/#{@item_id}.mobile?covers=false"
```


Add here:

enum Ironaya
{
SAY_AGGRO   = 0
}


`BuildLBX` still used/defined in:
  - `nx-X11/config/cf/host.def`
  - `nx-X11/config/cf/README`
  - `nx-X11/config/cf/X11.tmpl`
  - `nx-X11/include/extensions/Imakefile`
  - `nx-X11/lib/Imakefile`
  - `nx-X11/programs/Xserver/os/Imakefile`

Can also be removed there.


WTB PCH


I believe all of the methods above should be private.  I don't imagine that we'll be calling `#searchworks_has_response_tag?` etc from outside the class.  Realistically, at this point, the only public method should probably be the one that returns the title.


use `var`


return default css code if absolutizeUrl() failed


This is also needed for Debian; it's been patched in several places already; merging this would make porting RT extensions much easier!


@nguyentruongtho We currently do not have a Kinesis sample.  However, http://docs.aws.amazon.com/mobile/sdkforandroid/developerguide/kinesis.html should have the information you are looking for in it.  If it doesn't, just post on our forums https://forums.aws.amazon.com/forum.jspa?forumID=88 and we'll try and help out.


Can you change `theta` to `t` (or change all references from `t` to `theta`)?


I know this isn't a new change, but I don't quite understand this.


I might memoize this and leave the title memoization out for `#searchworks_title`.  I think the http request and the conversion of XML to a ruby hash could probably be sufficient and then let all the hash lookups consistently run every time (they should not be expensive).


Change to `array-like or None` for consistency


Make elems final.


Make elems final


deleted


Make elem final.


Good catch!


Can we get this in the next version of atom?


The `searchworks_` prefix in all these method names is a little redundant.  This will end up having the resulting interaction when dealing w/ this metadata from the request object.

```ruby
@request.searchworks_item.searchworks_title
```

At the point that we're dealing w/ a `SearchworksItem` object we know that the title is the SearchWorks title, so it would be preferable to be able to do

```ruby
@request.searchworks_item.title
```


... then `return;`?


YO BRO


### The Extensible Web

Web Components allow us sharing capabilities across applications that reinforce a common component model. Whether you use 'this library' or 'that framework' , Web Components should just work. All you need to know is your basic HTML, CSS, and JavaScript. Build your own HTML elements and optionally, reuse pieces of them with templates, shield them from outside elements with Shadow DOM ,  and distribute them with HTML Imports. Master builders....assemble!


Can you change `theta` to `t` here also?


Simply add "import DICOMLib".

For reference, see
https://github.com/fedorov/Reporting/issues/48#issuecomment-92440781

Hth
Jc

On Fri, Apr 24, 2015 at 5:46 PM, Andrey Fedorov <notifications@github.com>
wrote:

> @pieper <https://github.com/pieper> maybe you could also take a glance
> what's going on here ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fedorov/MultiVolumeImporter/commit/c0760e48cb767a57a868b46cafce8a875a4222e3#commitcomment-10897436>
> .
>

--
+1 919 869 8849


Shouldn't this be 1, not 2?


best commit


@johnsonhj : Please review


Good idea


That docstring is wrong ;)
Also, since there's already a relationship on User pointing here, this should be defined as a backref here: https://github.com/indico/indico/blob/wip/new-auth-users/indico/modules/users/models/users.py#L112


Hm... I even checked for those, weird


I'm not at a computer right now so I can't test for sure, but the import line is `from time import time` in the file above?


...should it?


This is because now scripted module are import as module.
See here for more details:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24155

Jc

On Fri, Apr 24, 2015 at 5:53 PM, Andrey Fedorov <notifications@github.com>
wrote:

> @jcfr <https://github.com/jcfr> do you know why explicit import is needed
> now?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fedorov/MultiVolumeImporter/commit/00a76127244fa998f695608ec1dceacb49fc4dde#commitcomment-10897493>
> .
>

--
+1 919 869 8849


I'd vote try it.


I feel like the TTL should be saved as a unix timestamp using [System.currentTimeMillis()](https://docs.oracle.com/javase/7/docs/api/java/lang/System.html#currentTimeMillis())


rax retry tests


So this is wrong. You need to change the underlying state, not the public API.


`deb-src` shouldn't be necessary :+1:


Should this have a `^` too?


`securityi` ? :smile:


Try replacing this `before` block by changing the `let` on line 4 to be

```ruby
let(:item) { SearchworksItem.new('123') }
```

Then in your tests, you can make assertions agains `item` instead of `@item`.


Change `tuple` to `array-like` here also


I think hash is for packets, not packet types.


Yea sorry i already see the current file i was working with an outdated
version on controller.py :)

On Fri, Apr 24, 2015, 6:21 PM Jakob Borg <notifications@github.com> wrote:

> I'm not at a computer right now so I can't test for sure, but the import
> line is from time import time in the file above?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/calmh/unifi-api/commit/b62a0ce5d8fbc3e28b6bff2d62112480bf276047#commitcomment-10898395>
> .
>


`User.query.join(...)`, or using our convenience methods:

    User.find_one(User.is_pending, UserEmail.email == verified_email, _join=UserEmail)

Also, you can query `User.email` instead of going to the relationship explicitly:

    In [1]: User.find_one(email='adrian.moennich@cern.ch')
    Out[1]: <User(42604, Aedrian, Moennich, adrian.moennich@cern.ch)>


Hey Jesse,

Are you gonna be at Spotify tomorrow?


it hurts a little to do that, doesn't it?


are used to


Really? Wouldn't it be much nicer to use `first()` and flash if `... is not None`


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (346 of 346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The syntax that you're trying to achieve here is something along the lines of

```ruby
expect(@item).to receive_messages(searchworks_xml: standard_searchworks_response)
```

You'll also need to define `standard_searchworks_response` via `let(:standard_searchworks_response) { ... }` or something like that.


I'd say get rid of the last line (have fun) and add the above section before the more section


Thanks for the PR @lametaweb

I'll just make sure that @anthonny doesn't see any issues with it (I'm just "The Docs Guy" after all) and we'll get it into the next release.

The fact that it worked for you suggests that this PR will be merged. :+1:


shown in the following figure.


$mkdir ~test-repo


This method name seems miss-leading.  Perhaps it should be something like `response_success?` or simply `success?`


Need to merge.


Oh noes that's tomorrow?!
I have a friend coming into town and he wants to hang out tomorrow, so i
may have to skip. I'd totally go though!

On Fri, Apr 24, 2015 at 7:26 PM, uniaquinas <notifications@github.com>
wrote:

> Hey Jesse,
>
> Are you gonna be at Spotify tomorrow?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mienaikoe/lupur/commit/ea610e76109f40b440a3c287a0136ecde357d1a7#commitcomment-10898442>
> .
>


If you need to join the user, better use this query:

   User.find_all(~User.is_deleted, ~User.is_pending, User.all_emails.contains(field.data))

(if you wanted to query for multiple emails you'd use `User.all_emails.contains(db.func.any([...]))` btw)


Oh, yes if you have time :)


The matching fields is simliar to ACL match fields with limited types.

->

The matching fields are similar to ACL matching fields with limited types.


I understand your concern, but don't agree that it warrants this solution, which will impact all other systems and tools trying to reason about what's going on in the system, in addition to adding complexity to the RC controller.

The pattern of delete and then re-create is going to be necessary in a number of situations, where the update the user wants to make can't be made to the existing object via PUT (e.g., changing PortalIP of a Service).


Could you please also help fix the code change?


Thanks a lot  :)


This is all a bit strange. I don't see any errors building with g++-4.9 on my Ubuntu 14.10 laptop.


Uses `Longs.compare()`.


Ditto.


If you end up dropping the `searchworks_` method name prefix you can re-write these tests using rspecs dynamic matchers.

```ruby
expect(@item).to have_title?
```
is equivalent to
```ruby
expect(@item.has_title?).to be true
```


What does this say exactly?


Neither of those classes should (or need to) be accessed directly. You can access them directly via the relationships (or even better, the association proxies) on `User`.


I'm not sure about adding a new section like this, specially because its title brings so many concepts and definitions along with it [1]. Any thoughts @addyosmani?

I was thinking more into adding a conclusion paragraph before `### More?` to explain why are those characteristics important since beginners may not realize it at first.

[1] https://extensiblewebmanifesto.org/


Also, you may want to use `subject` instead of `item`. This can make some of the tests more portable and more easily refactorable.


-Fixed Issue with variable
-Fixed one line of missing code


This errors our in iOS simulator:

246   468715   error    Error: Attempted to assign to readonly property.
kill@http://192.168.1.110:8100/cordovaBundle.js:8423:26
http://192.168.1.110:8100/cordovaBundle.js:54186:22
$broadcast@http://192.168.1.110:8100/cordovaBundle.js:23356:35
$destroy@http://192.168.1.110:8100/cordovaBundle.js:22976:26
destroyViewEle@http://192.168.1.110:8100/cordovaBundle.js:46673:29
cleanup@http://192.168.1.110:8100/cordovaBundle.js:46520:29
transitionComplete@http://192.168.1.110:8100/cordovaBundle.js:46461:33
completeOnTransitionEnd@http://192.168.1.110:8100/cordovaBundle.js:46440:33
eventHandler@http://192.168.1.110:8100/cordovaBundle.js:11650:27


周末搞定


Why not use wildcard-less lowercase match here? That's most likely faster, since LIKE at least needs to check if there are any wildcards in the string.

    return db.func.lower(column) == value.lower()


Should be `+=`?


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.294](http://teamcity.monogame.net/viewLog.html?buildId=6332&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


User.query


You can use `User.affiliation` directly without joining `UserAffiliation` manually


same thing here, but using `User.all_emails.contains()`


Typo Enhanncement -> Enhancement.


emails are already guaranteed to be lowercase (check constraint)


it's in `indico.core.auth` now and that one should be safe to import at the top of this file


Need to check whether locatable is null and throw an IAE in that case. Now it would result in a NPE which is against best practices. Unfortunately you will need to delegate on the other constructor.


Why not `**original_criteria`?


@skybon : OK, closing, I want to keep compatibility with our dependencies package.


`set(found_emails.viewvalues())` might be cheaper (even though the difference is clearly negligible)


Not sure I support this change. It is redundant, but 6 months from now I'm not going to remember that or which access modifier is the default. I would prefer to keep all access modifiers explicit even when not strictly required.


s/iinfo/identity_info/? i first thought it's a typo


This is interesting... so Locatable will be allowed to have length 0 or inconsistent stat, end indexes? More a question than a review.


To a point. This'll get cleaned up when we do Bug 1157306.


No, we'll be flipping lastFetched to zero whenever we decide to start over, or if we've unlinked and relinked, so this clears the DB before adding zero-onwards, which is everything.


do we really want only the first character of both first and last name?


are those `[0]` correct?


`or isinstance(id_, int)` so we don't fail if the id is actually passed as a number?


`indico.core.auth`


thanks


Consider using `#ifdef RIPPLE_ENABLE_CLEAR_LAST_ROTATED` or some other variable that made it clear what was happening?


:+1: No one is relying on this now, can't break anything.


Yeah, I don't think this buys us much. If extensions can trigger a sync or access clients — the latter is already true! — then they'll need access to the account, almost every database, file access, prefs, etc. etc., or they'll just dump stuff on disk and avoid any access to the profile at all.

So splitting the profile probably doesn't make sense at this stage.


Why can't this be a `boost::optional`?


It's not clear what the threading model for this is.


I think it is reasonable to backport, it is a security issue

On Sat, Apr 25, 2015 at 1:04 AM, Robin Ward <notifications@github.com>
wrote:

> Should this be backported to stable and betas?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/discourse/discourse/commit/80b2935e11ed12f2f2889f737ab98b1f43abdf27#commitcomment-10890662>
> .
>


It seems like there's a much more efficient way to do this, right? `DELETE FROM tabs WHERE guid IS NULL`.


TeamCity MonoGame :: Develop (Win) [Build 3.4.0.294](http://teamcity.monogame.net/viewLog.html?buildId=6332&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 484, ignored: 6 Build time: 00:14:19


> Anyways (do English speakers sometimes use the incorrect (I believe) plural for emphasis too?)

I think it's "officially" incorrect, though it doesn't "sound wrong" to me. It doesn't imply emphasis to me though.

> Why "snapshot" but not "dataloss"? - you never know. And it seems my spellchecker spell checker spell-checker doesn't either.

[Language Log: Level(-)headedness](http://languagelog.ldc.upenn.edu/nll/?p=2153)

> See [Plethoric Pundigrions](http://hotscot.blogspot.ca/2010/02/microsoft-word-fail.html) for screen shots showing a version of Microsoft Word (I don't know which one) that for levelheaded suggests correcting it to level-headed and for level-headed suggests correcting it to levelheaded.
>
> [...]
>
> (1) The longer a compound has been in use, the more likely it is to have started being written without a hyphen. (2) American English is a bit less likely to favor hyphenating than British English is. Apart from those two rules of thumb, you are out there working with no net...

---

> here's a serious question: is "noun-noun" ever correct? Examples?

I can't think of any off hand. [This page](https://www.englishclub.com/grammar/nouns-compound.htm) claims "fire-fly" is correct but it looks weird to me (I would write "firefly").


Can we please avoid this sort of thing? Use `std::numeric_limits` instead to get the max value. Or, better yet, use `boost::optional` t begin with.


I don't think it makes sense to mix DB and non-DB ops inside a transaction, and again this is something we can do in fewer operations, rather than doubling up the logic inside `addTab`.


How about allowing users to do `$tok` on single tokens as well as on multiple tokens?


Isn't `Number.MAX_SAFE_INTEGER || Infinity == Number.MAX_SAFE_INTEGER` ? Why the `||`?


:D


I think a better approach here would be to create parallel test to the existing 'badIntervals' and 'testGoodItervals' (which consume a number of possible intervals from the corresponding dataProviders) that would use the alternative constructor.

You can mock the Locatable using a anonymous inner class that would use the test parameters as the return for getContig, getStart and getEnd.

This way we are as exhaustive testing the new constructor as we are with classic three parameter one.

Also add a test for when we pass a null locatable (resulting in a IAE.)


"hack-uired", hahaha!


Why ?


`boost::optional` introduces thread safety issues. This implementation is the current one.


Yeah, the big example is that read can have a null contig.  Locatable
defines 1 based indexing, but not the length or non null guarantee.
On Apr 24, 2015 7:44 PM, "Valentin Ruano Rubio" <notifications@github.com>
wrote:

> This is interesting... so Locatable will be allowed to have length 0 or
> inconsistent stat, end indexes? More a question than a review.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/broadinstitute/hellbender/commit/51a3c4dd89950c4c1e9ee6641d21367fc327d830#commitcomment-10898581>
> .
>


How would you synchronize? Putting an optional into the engaged state is not atomic.


data쪽 java 파일은 인코딩을 ANSI로 저장하셔야 한글이 정상적으로 출력됩니다.


Is there an example of this happening? Does it occur in Firefox?


Can we use a special `Unquote` token to represent the unquotee instead of having a placeholder? Having synthetic placeholders led to major problems in the scala.reflect's implementation of AST quasiquotes.


Yes, I verified, Firefox + ABP the page was blank.


With thanks to @dexX7 for suggested methodology


i was just looking at the implementation of rspamd_lua_setclass. i feel that for `settable(L,-3)` to work, isn't one `lua_pop(L,1)` also needed after this line to remove the userdata from the stack, if i want to return the table finally?


or i can use `lua_settable(L,3)` here and then finally move the table to the top and return. Please see to it. Thanks.


No rush, good luck in your exams!


How about opening ~/.conkyrc, which should be symlinked to wherever the default file is located? That way the menu entry will work even for a user who has reverted to a single standard conky?


由衷的倡导大家积极的支持开源事业


这句话的意思翻译反了。应该是“在Xcode中调试view从未如此简单”


-e argument necessary (-T is just the title.)


I think it's more correct to call it a "normalized name" here.


If we use `mkdir -p $SCROTSDIR` then the if test is unnecessary - no error if the directory exists.


个人见解：dependencies在此处翻译为“依赖库”或者直接翻译为“依赖”比较好


@smcgregor http://stackoverflow.com/questions/13987380/how-to-to-initialize-keyboard-event-with-given-char-keycode-in-a-chrome-extensio    Luckily it works :-) Add the script to the host page is feasible at present.


rax retry tests


这里 _id 和 id 的效果一样么？


I don't think it matters currently since I only called this once in nodeCtrl.ino and there I was only checking for the return code to be 1 or not. We can replace this -1 w/ whichever value we want for failures.


The purpose of this tweak is for there to be a little extra movement of the "show comments" button when there are no comments. The button will go down a couple of lines and it indicates to the user that there are no comments to show.

I'd like to have a message display when there are no comments, but that'll have to wait.


A lot of indenting changes. I haven't touched most of these files, but anyway perhaps it would be good to agree on a tab size: four spaces, or two, or...?


@wykhuh Why'd you have to make this change? If lambdas weren't working, this gem should never have been working, as `recipient_email` is existing functionality.. right?


Excellent! Minimalism is the way to go!


Glyphicons change from "expand" to "collapse" when clicked.


i should check that it's a timeout and if not re-raise ..


And yeah, ha — no tests, indeed.. this was originally a quick weekend project I whipped together that we're looking to flesh out a bit. Retroactively adding tests is on the todo list.

:+1: for using off `master` for now. Once we get everything in better shape (w/ tests), we can make a release


Good point


Why not just add a option to hide the Search tab like the rest of the tabs already have? Also for users with 25+ shared/owned/remote servers this is nice ;)


I don't think this is a fix. An indexing notation is not a computedProperty. It should be highlighted as array accessing like below.

![screen shot 2015-04-24 at 11 13 58](https://cloud.githubusercontent.com/assets/2883231/7311753/0aa5de82-ea73-11e4-8380-e41899252e47.png)


nondescriptive name alert?


Merged the PR https://github.com/edubart/otclient/pull/633 into this new branch 'mobile_port'


I noticed the tabs when comparing different files in geany with whitespace enabled. I hadn't realised there was a mixture in the files I wrote. I decided to make them all consistent by changing tabs to spaces (indent= 4 spaces).


Oops, I meant you could use it on the `request` object:
```js
function setDefaults (options) {
  const defaults = {
    request: {
      host: 'api.sphere.io',
      headers: {},
      timeout: 20000
  }
  Object.assign(defaults.request, options.request)
  return defaults
}
```
Then you pass in `{ request: { host: 'foo.com' } }`, and it should work.


I could make it `NeuralynxNCS` if that seems better. It seems like we have a decent number of non-descriptive short acronym packages...


that's good.


Thank you for this


EnergyPlusDir (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


new branch:test


哈哈开始写C了?


Yes, the second option is better.
Yes, it would be better to keep the differentiation as other file systems would require specific libraries to be built; and the current library supports FAT FS operations. Though it would be rare to come across any other FS requirements for SD cards. :)


EnergyPlusDir (macumber) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


EnergyPlusDir (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


你感觉会不会C繁琐点,连print都要打这么多


@potsmodern i have issues with this commit


EnergyPlusDir (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@niko118 acá tenía un par de dudas sobre como hacerlo. En el metodo del constructor a mi me parecía que tenía que pasarle como parámetro una fecha que no sea de la clase LocalDate ya que es la inicialización digamos. Recién acabo de modificar que ese parámetro sea sólo un string. No creía que era muy apropiado que reciba un LocalDate ya que al crear una venta vos pondrías venta1.new(....,"2015-01-01"). Después lo que tendría que modificar es que internamente los metodos reciban sí como parametro un LocalDate y no la fecha por separado.

Está bien como lo pensé o todos los métodos tendrían que recibir como parámetro un LocalDate? Espero no haber mareado con la redacción jaja


Seems this 'tooltip' is not displaying, not sure why...


@zhiyuanshi Move Loop to repl/ will make the Z3 flag unset when running `make smt`. Any ideas of how to resolve this? Otherwise, maybe we should revert this commit.


media和display最近几次cm10.1分支的修改cm11可以直接用吗？@BambooIV


EnergyPlusDir (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


The problem is, it's not possible to tell it is an array index or an object property when encounter a `[`.
And there is no array index in yajs.
I use compute property for all 3 cases:
* array index
* object property accessor use `[]`
* computed property in object notation

Their contents are all the same(expression inside `[`, `]`).
And have similar meaning.


uploader.py 里，命令行帮助也有一个地方


Do you really think that the function of "generate_password_hash" is at all ambiguous?
You should also read pep 8...


OK, I saw that the commit changed the return type to uint8_t, but the error return code stayed at -1. Sounds like it doesn't matter though.


That looks to risky to add to 3.0 at this point in time and the VKB false mode isn't a high priority.
The extra repaint after screenSizeChanged should be redundant (size changed should cause repaint already).


会啊，不过感觉还是得学

发自我的 Windows Phone
________________________________
发件人: xiechengen<mailto:notifications@github.com>
发送时间: 2015/4/24 11:31
收件人: spencerpomme/coconuts-on-fire<mailto:coconuts-on-fire@noreply.github.com>
抄送: Spencer Zhang<mailto:spencerpomme@live.com>
主题: Re: [coconuts-on-fire] First C program: Hello C world! (3b1cf75)

你感觉会不会C繁琐点,连print都要打这么多

---
Reply to this email directly or view it on GitHub:
https://github.com/spencerpomme/coconuts-on-fire/commit/3b1cf7575e30e9811d52113d3e9bb8992a7ececb#commitcomment-10881293


是啊😁

发自我的 Windows Phone
________________________________
发件人: xiechengen<mailto:notifications@github.com>
发送时间: 2015/4/24 11:30
收件人: spencerpomme/coconuts-on-fire<mailto:coconuts-on-fire@noreply.github.com>
抄送: Spencer Zhang<mailto:spencerpomme@live.com>
主题: Re: [coconuts-on-fire] example on C primer plus (c211a6a)

哈哈开始写C了?

---
Reply to this email directly or view it on GitHub:
https://github.com/spencerpomme/coconuts-on-fire/commit/c211a6af71508ab06c98bc65bd0831f5cc65b91c#commitcomment-10881285


good


按习惯，python函数的默认参数，=两边是没有空格的。
  估计是为了节约空间，本来函数名就长。
  另一个好处，也是作为另一个标示，和普通赋值不同。
  你可以看看系统的库函数，都是这么处理的。


用透视法观察这个3D模型的最自然和最通用的方法是从左侧来看。


- -以前在其他语言都习惯加空格 感觉更清晰一点的样子 毕竟没玩过Python 我去看看- -


edit_gae_py 这个函数名，建议改为 update_rc4_password


Not sure if I got it. Are you working on it? This is a blocker in merging the code and successful run of application. Also client team also changed their locations to OpenSRP-API location so it is urgent and can not be reverted anyway.


can't we use `this`?


No idea. I haven't got a repo of this inside a service worker either so I don't know how it should look


@halfcrazy 前面要改成 id。
然后就是有点问题，如果 user 表中没数据的话， id 就不能传数字，得是 object-id。


@mnapoli FYI The png is a `404 page not found` and not valid PNG - it fails the build eg. https://travis-ci.org/piwik/piwik/jobs/59821254


To be consistent with your version.


tested and working


Comentários adicionados e JAVADOC gerado


GPIO_SHDN doesn't exist in TinyScreen.h


你的索引有在8点之前创建，说明这个修改是有生效的，


@jgm

It looks like the test failed because:
1. Image paths, except the cover image's, are normalized (in EPUB reader).
2. Normalized paths won't match the expected path under Windows.

I noticed that normalizing cover image's path causes another test to fail.

https://github.com/jgm/pandoc/commit/095b05e4f97301355e20d81135dfb20142eb767f
>EPUB tests: don't use joinPath, which varies across platforms.
>Instead, use a forward-slash to join paths, regardless of the
>platform. This matches the way MediaBag now works.

Would it be better to store the paths as 'splitDirectories' and convert as needed?


Can we just inline the `IDToPoint` type?


Ótima observação, vou consertar.

Em qui, 23 de abr de 2015 21:19, Rafael Ponte <notifications@github.com>
escreveu:

> @asouza <https://github.com/asouza> o producer FacesContextProducer
> produz um FacesContext com escopo @Dependent, isso pode ser um problema,
> já que instância de FacesContext está sempre associada a uma requisição
> Web. Por exemplo, no caso do MessagesHelper o escopo do FacesContext
> injetado será de aplicação, nas requisições seguintes o objeto estará num
> estado inválido.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/asouza/casadocodigojavaee/commit/4d7463b3aceaa079f1c95b86e41421ad792bd0ff#commitcomment-10879780>
> .
>


Can we just inline the `IDToPoint` type in the few places where it appears?


indentation? use space instead of tab


maybe add a new line here, this line is too long


This logic has been removed in the new version


finally を使って、Exception 発生時にも確実にリソースの解放が行われるような実装にしましょう。
また、例えば、以下のように BufferedOutputStream を活用したほうがより効率的に配信できます。

 out = new BufferedOutputStream(response.getOutputStream());

      byte[] buf = new byte[1024];
      int length;
      while ((length = in.read(buf)) > 0) {
        out.write(buf, 0, length);
      }


This  not a test case  this only  has @BeforeTest and a @AfterTest method to change the configuration


internaly --> internally


i'd remove extra empty line here and below


How do you odex and don't break double tap for bacon? Thanks


@daenney this breaks the apt module in Puppet 3. `defined('$var')` returns false even though the facts have values. My guess is that this is because `defined()` only returns true if a variable has been assigned a value and since these are facts, they have not been explicitly assigned to. I would open a pull request for this issue but I'm not really sure the implications of this and why `xfacts` exists.


reftex source code is missing. It should go in a `extensions` directory.


You can remove this file if it is not used.


This also fixes a couple of tests that should have been failing.


@gaohailiang

把复用代码装进了 filter 里 ，

可以用到 $filter date 的地方，换为用了这个服务


Adrian, it's the updatedata.h/.cpp/.ui. Use those.


so here is what I will be sleeping on. new patient tracker file with these fields, ID,pid,encnum,provider. records are only added to this database when an appointment is marked as "arrived" or "Arrived Late" in the calendar.

patient_tracker_elements will have the following fields : ID , grouping, key,value. ID will be the link back to the patient tracker main file. grouping will be incremented for each status change with in an ID.Key will be status,date,starttime,endtime and user. value will hold the information. this is by no means etched in stone or even sand for that mater.

Terry


arg order is wrong!


tested and works

![image](https://cloud.githubusercontent.com/assets/942819/7312284/6dc32d4c-ea16-11e4-8f27-f2417f9a009a.png)


例外を返すのは`save`ではなくて`save!`メソッドの方では？
普通の`save`が返すのはbooleanだったはずです。


This is redundant. It should be `if (val % 2 == 0) {`


这个IP 这么加进去？新手啊


Yeah, I agree... in this case the code was written all at once and was clearly intended to be surrounded by curlies, no idea how I got this oops


Wow.


I'm confused: was Heroku using the .rvmrc file or did it serve some other purpose?


The sizeChanged only does a repaint if the width and height changes.  If
the orientation is locked we have situations where the width and height
stay the same despit an orientation change.   This probably should have
been a separate fix.  I was running into "black screen" on some orientation
changes until I put that repaint in.

Agreed this is risky.  That orientation stuff was really thorny... I
attempted several other strategies at fixing this issue before finally
arriving at something that worked for all settings of supported
orientations on both iOS 7 and 8.

On Thursday, April 23, 2015, codenameone <notifications@github.com> wrote:

> That looks to risky to add to 3.0 at this point in time and the VKB false
> mode isn't a high priority.
> The extra repaint after screenSizeChanged should be redundant (size
> changed should cause repaint already).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/codenameone/CodenameOne/commit/d5d11486dbb5e4d6a4e93fefe8332d00e10c411d#commitcomment-10881331>
> .
>

--
Steve Hannah
Web Lite Solutions Corp.


OK, so we'll leave it out of 3.0 but the change looks good otherwise.


I am inclined to put this in the "not worth the work to test" basket -  as we can't use regular cms fixture loading and simply loading your snippets during the spec didn't seem to work for some reason. Only admin ever clicks this so its tested in practise anyway, and probably not worth another hour or two of work.


Этот пример не работает - в ajax ответе пользователи есть, но визуально они не показываются


hi i tried u r example absolutly fantastic one .. u given wat i need but modification can do for me ??
u have to insert the State Id while in to database while selecting if u selected India->tamilnadu  if india Country Id is 1 and State Of Tamil Nadu ID is 1 means u have to save in different Table Can Do That one i was trying my best but i can't my mail id is sivagirintp@gmail.com ..can u send u r mail id


An optimistic thought is that Smarty isn't involved here also :)


如果你想查看这个app是如何构建的，这个图把view的层级用透视法展现了出来。


There are too many failed caused by comparing between bytes and string in Python3, and bytes and int as well


良い変更だと思います。

ActiveRecordのentityと、データを扱うクラスはそれぞれ別のモジュールを切って入れた方が分かりやすくなりそうです。

また、ActiveRecordの初期化は`Departments.new( name: 'daiki' )`のように出来たはずなので試してみても良いかとおもいます。


This involves a trick of creating a sqlBindingArray and then adding the elements to it.


$res = sqlStatement( $query, $sqlBindingArray );


Merging with master


sqlBindingArray = array();


Merging with upstream


Needed to be able to determine the currently selected displayer subtype. Not using ID here, as there are mutliple "selected" images in the DOM and I don't want to clutter code by generating unique IDs here.


$sqlBindingArray = array_push();


$sqlBindingArray = array_push($sqlBindingArray,$from_date, $to_date,$from_date,$to_date);


Learn to use `git pull --rebase origin master` from your branch next time before pushing. :)


@wxzh `Loop` is not in fcore.cabal. Try adding that to a correct section in fcore.cabal and see if this will solve your problem. I can't test on my machine since I don't know what's the desired outcome.


check out email I just sent


It’s unnecessary to redeclare `-initWithFrame:` here, because the superclass, `UIView`, already declares `-initWithFrame:`.


@jaadds if the scope's length is greater than 60 it uses the class "tokenTextarea" for formatting which automatically expands with the text length allowing longer texts to be displayed on scope area.


i think it was just left here - and my machine tried using it when cd-ing into the repo. Can't really see a way to be used in non-development context.


Please improve your indentation.


That's really odd.  It builds just fine here using the plain old Debug and Release builds.

But, I've gone ahead and added an include that should fix whatever issue there might be.

I'd be really interested if it fails for you again.


Only this patch is meaningful to me since I would only accept fixes rather than functional improvements. You have to create a new GIT branch and send pull request again.,


Some resource links for this commit:

https://github.com/muratguzel/letsrate

http://guides.railsgirls.com/touristic-autism_resource-rating/

http://wbotelhos.com/raty

https://github.com/kartik-v/bootstrap-star-rating


ALEipUtils.getMessageList
により自動改行・自動リンク対応がされるようになります。


 portlets/test/src/main/webapp/WEB-INF/templates/vm/portlets/html/ja/ajax-test-detail.vm
のファイルを修正してそれをhtml直下のテンプレートにコピーする感じですね。


getResultDataDetailは詳細画面を表示するときに呼ばれます。


Este archivo es necesario para evitar que se suba basura al repo, ya sea la de las clases compiladas, los plugins que descarga Grails durante la ejecución o los archivos de configuración del IDE.


マージコンフリクトが起きているので、このへんの行は一旦削除してしまいましょう。おそらくmvn installが通らなくなります。


可以


Wieso nicht einfach

   "^ircs?://.*"

oder lesbarer

   "^irc(s)?://.*"

?


キーワード検索するときにタイトル、内容に加えてURLでもヒットさせることができるようになりますね。


ALEipUtils.getMessageList
は自動改行・自動リンクがされるメソッドになります。画面に表示されたhtmlのソースを見てみるとわかりやすいかと思います。


这是什么意思 ?


できるだけ大文字・小文字を揃えてお供養に注意しておくと、思わぬところでハマってしまうとかを避ける事ができますよ。


@FILWAndroid 这篇译文没有保留原文，没法校对。另外句子很多不通顺，请自己再认真过一遍，然后修改一些句式，谢啦。 :）


formタグの中に含まれるinputの要素がPOSTされるようになっています。


Redundant curly braces around a hash parameter.


Pass `&:keys` as an argument to `map` instead of a block.


Space inside { missing.


The plural of parenthesis is parentheses


getTemplateで呼ぶテンプレートをアカウントのCSVエクスポート用のスクリーンに変えてみるといいかと思います。
addQueryDataは今回の場合つけても付けなくてもOKです。


@purecaptain 可能你需要自己认真过一遍，修改句子啥的。我看了第一段，似乎句子都读不通，如果句式复杂，可以意译。谢啦 :)


Not a blocker, instead of passing the networkNamespace, can we just pass path ?
It's a utility function and does only need the path and gw information.

I am asking for this because if we look at (n *networkNamespace) setGateway() for example, it looks weird this method calls a utility and has to pass the networkNamespace pointer. Then it makes you ask why isn't setGatewayIP a method receiver of networkNamespace itself then.


This comma prevents the app from loading the webpage.


do you mean 'algebraic data type'?


aipo.eventlog.downloadCvnが見つかりませんみたいなJavascriptエラーが出るようであれば
aipo.eventlog.downloadCvnのJavascriptのメソッドをaipo. account.downloadCvnに移植してみましょう。


it isn't a method then, it's a function.

yes i am aware this is quibbling


See this issue for detail: https://github.com/fasterthanlime/rock/issues/874


lgtm


ここの処理は変えなくても動くかも？もしくはJavascriptの中の処理の方を変えたほうがベターかと思います。


This is minor.

We have setGatewayIP, setGateway, setGatewayIPv6...

Can we rename the utility setGatewayIP() to programGateway() and setGateway() to setGatewayIPv4() so we recognize right away it is on the same level of setGatewayIPv6()?


ここの表示は変えなくていいかなと思います。


fixed


Using DeckPanel seems to me to be better fit in this case. It doesn't add additional DOM table for each displayer subtype and we can express showing selected/unselected image directly using the panel instead of hiding/undiding images themselves.


I only have minor comments, which I can take care of myself later on if we need this patch in as soonest.
Therefore, LGTM


Hi @lokenx

I like Tabular Table package, but one annoying issue is the sort is only related to columns you load, I went through all the docs and there is no way that I can find to have the default collections order be displayed.

It was nice to see requested movies in the order they were requested, but now it defaults to alpha order.

As a note filter-collections it allowed for search and it usually defaults to table html makeup, I changed it to divs since they are a bit easier and cleaner to response for mobile over tables.


Ah I wonder what happened here, I'll fixed it thanks


Oops. This comment is wrong.


Tener cuidado con esto, hay que ver la última versión estable en https://www.ruby-lang.org sobre todo por los parches.


@tabro Nice, but the index to put the read model in not depend on the read model itself


What happened to the neon makfile only krait was removed?


This one I will not consider important and it was not part of this diff i.e I did not introduce these funcs as part of this commit so if we want to cleanup we can do it as a later commit :-)


肯呢过 -> 可能


May be more user-friendly if the app re-directs to the list of blog entries or to the Show page. It currently re-directs to the home page, which is under construction.


Guides shouldn't be written for a specific version of $distribution.


Re-used the console command and the screenshot was corrupted again. I downloaded manually now it's fine: https://github.com/piwik/plugin-SecurityInfo/commit/bdd8ff9a0a735ace4ef2ecf22a1395fdfce833e4


Remove 14.04 LTS here, see first comment.


Thanks for reporting this problem and for providing the solution. I commited your fix.


操纵 -> 操作


Description is vague, at best. And you're not using Unix sockets in this guide at all. I'd reword this to say something more like, "Configure Apache using mod_proxy_fcgi and PHP FPM in Ubuntu/Debian"


Насколько я понимаю вы ищете работу начинающим java разработчиком. http://hh.kz/employer/104387 возможно мы заинтересуем друг-друга


拖曳 -> 拖拽


If I move `Loop` back from `repl/` to `lib/`, problem will be solved. It seems that setting FLAG will only affect files in `lib/` . I don't know why.


introduced or detected? :-)


// Place following code after FB.init call.

function onLogin(response) {
  if (response.status == 'connected') {
    FB.api('/me?fields=first_name', function(data) {
      var welcomeBlock = document.getElementById('fb-welcome');
      welcomeBlock.innerHTML = 'Hello, ' + data.first_name + '!';
    });
  }
}

FB.getLoginStatus(function(response) {
  // Check login status on load, and if the user is
  // already logged in, go directly to the welcome message.
  if (response.status == 'connected') {
    onLogin(response);
  } else {
    // Otherwise, show Login dialog first.
    FB.login(function(response) {
      onLogin(response);
    }, {scope: 'user_friends, email'});
  }
});


This headline though... Introduction should be here as well, each guide should have an introduction. And that headline is way too big. The "title" is going to be the thing that's displayed on the top of the page, so you should change this to Introduction and make an introduction.


Ok, so I think that this will be connected to the `lunch.id` that's generated as a primary key through the model, instead of a foreign key. From what I was reading, the rails way is more that your model handles the relationships, but looking for some feedback.

I was thinking the view to add items would automatically populate that, but I'm not fully sure how the implementation would work. Might be worth talking about in person. I know how I'd do this in ASP.NET MVC C#, but I don't really know how to do things in Rails :P


You're not using Unix Sockets in this guide, so you may want to consider just using the Ubuntu repository. I believe mod_proxy_fcgi existed in 2.2 as well as 2.4.


Write all guides assuming root access for consistency. There will be a notice at the top of each page that states something along the lines of "All guides are written assuming root access, append with sudo ..."


Hm?

```
jb@syno:~ $ python
Python 2.7.6 (default, Sep  9 2014, 15:04:36)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from time import time
>>> time()
1429852569.459297
>>> time.time()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'builtin_function_or_method' object has no attribute 'time'
>>>
```


This is causing errors. Your post.rb model file specifies that one Post has many Categories. So this line of code should take that into account.

@category.title means that there is only one category, and you want to display its title.


Did you write SymptomsSummaryActivity?


"Apache is the world's most popular web server software" -- Reference? Is this an actual statistic somewhere? I know Apache and IIS were super close in 2014, so I'm not sure if that's changed since.

Also, again, you're not using Unix Sockets.


yeah


Ya "from time import time" works but in controller.py its only import time so you need time.time() :)


but we are adding propertybag here not property.


Why write actual file?


I do not have any local changes.


This is causing errors. Perhaps there is no method called .present


I have made changes , u can look here : https://github.com/Microsoft/vso-agent-tasks/pull/58/files


for HelpMarkDown and Label text I asked Prateek to signoff , i'll discuss this with him


hehe yep, that's clang for ya!


`instancetype` is better (more specific) than `id` here.


This commit's for @nickgravelyn, @SeanColombo and @elisee.

Unlike other options such as DISABLE_FAUXBACKBUFFER this option doesn't have any real effect on things like performance, system requirements, etc. Additionally, there's no serious code difference between the enabled/disabled modes, like DISABLE_THREADS. So there's no real reason to lock this away at build time.

Now, all you have to do is add this line somewhere before you initialize your Game:

`Environment.SetEnvironmentVariable("FNA_WORKAROUND_WINDOW_RESIZABLE", "1");`

And that's it! We still don't have a method of changing this at runtime, but after fighting with Min/Max size manipulation I think this is the best we're going to get without doing _really_ ugly stuff (or just doing it the right way in SDL2).


Oh, great work!

I was giving Tuyen a chance to do it before I jumped in.

@Tuyenho
Please help me compare functionality as specified in project requirements & Jaguar SRS document with our current build. Ensure we have a list of pending changes. We can use GitHub Issues Tracker for this, that way we have it all in one checklist.


thanks a lot for that bug fix dude.


Yes, this works. Thanks!


is it really root user?


What's with all the extra spacers? :p


should "cpus" and "mem" made constants - they are used in multiple places


Why do we push twice the number `sum` on the stack?


I'll add in the next update ;)


@DjAntaki No problem, glad I could help! :)


Is it correct?


I would just add  that 4.x.x is incompatible with 3.x.x, thanks!


Right now I'm working on getting the list of symptoms to only display records for the user currently logged in (right now it show's all users' submissions). After that I'll probably move on to PatientSummaryActivity, dequeue functionality for doctors, and doctor comment functionality. We're starting to run low on time, so I'm just going to finish as much as I can regardless of who it was assigned to


特征 -> 特性 这样措辞可能更好点


Great!


## This is a markdown file


Variable name should start with small letter.


Have you checked how this looks with Haddock? (with the use of quotes, slashes, etc.).

In particular, I think you might need to do `tree\/forest`.


Haddock says it can't find a link destination for `fixNodes`.


Sorry for my misunderstanding before.

And I wonder rather the new struct "task_c_b" (defined in line 55 above) should be involved as part of the pull request?

I will send another pull request as soon as possible.


| spaces replaced by ಠ_ಠ

wat.


Main program is incomplete. Please check the question again.


I'd rather use a for construct like the following

    for (TarEntry te = t.getNextEntry(); te != null; te = t.getNextEntry()) { ...

in this case to avoid checking the result of a variable assignment and to reduce the scope of the iterator.


Okay, for clarity.


Names of Map and Set are the same for some reason


why not ? It's handy to just copy paste files when there is a huge change.
FYI i personnally plan to stop using files in favor of es6  template strings soon.


we have put visibleRule there which will handle that condition


I think it might be easier to read if it's something like this (haven't checked whether the blank lines are all needed):

```.haskell
--   1. An optional direction parameter specifying which nodes to visit next.
--
--      [@x@] user-defined
--
--      [@u@] unidirectional
--
--      [@r@] reversed
```


It's a question of tape log readability.


Sure will submit a pull request for th same and states/boto_elb_test.py also.


You should be able to achieve that with something like:

ParseQuery query = ParseQuery.getQuery("Symptoms");
        query.whereEqualTo("user", ParseUser.getCurrentUser());
        query.findInBackground(new FindCallback<ParseObject>() {
            public void done(List<ParseObject> returnList, com.parse.ParseException e) {
                if (e == null) {
                    Log.d("Results", "Retrieved " + returnList.size() + " results");
                } else {
                    Log.d("Results", "Error: " + e.getMessage());
                }
            }
        });


Minor note - You may want to remove the exclamation mark. This will give you more flexibility to the string that is stored in :notice or :alert. Otherwise, all :notice and :alert will appear with an exclamation mark. Sometimes you may not want it.

Also, best to use CSS to make this bold because in the future, you might want to style it differently, or style it exactly like some other piece of content.


adsf


Could you explain why all those 4 collections are concurrent?


I already updated PR #119.  If you need the fix before it is pulled, you can check that out and try it.

Thanks,


the value is stored into the output field of the module, but also returned by the function.
one could have done lua_pushvalue as well.


tip: if you rename it to .tsv (tab-separated values), it will show up nicely as a table in github


make it same for inplace. inplace thing can be handled from the wrapper. allocate the result there (if not inplace) and pass it to this struct. Instantiating two templates for the same job is bad.


Omit the "Ubuntu 14.04" part.


I appreciate you honesty. Also, try to use the argument names as mentioned in the question.

Keep up your good work.


If we care for concurrency here schedulerNodes may have had offer.getHostname() at the moment of checking, but not anymore. Do you care if offer is overwritten here, or you need to use putIfAbscent instead of put?


just pipe with your favorite reporter https://github.com/substack/tape#pretty-reporters


Same as above


Suggest to add requireSemicolons


okl


Wow you actually paid for this bucket??


If you actually just swap this section, you'll be using Unix sockets... Not sure if that's what you intended or not.


OK, fine with me.


nope. They are just useless. Please if you want to improve this plugin, just fit the existing convention.


You have changed 'list_len' to 'no'. The second one is shorter but it lost meaning. I would suggest either something like 'count' or using previous name.


Do not use space with :: operator.

 Point ::  print() ---->  Point::print()


As it stands, I'm not sure how the formatting for our guides will be for notes... Open discussion on this one.


As it stands, I'm not sure how our formatting will be for file excerpts. Open discussion on this one.


Aaaannnnddd that worked perfectly. Adding:
query.whereEqualTo("user", ParseUser.getCurrentUser());
is exactly what I needed.


Okay. But this code has less clarity with this convention.


也可以使用 html5 语义化标签，<header>, <nav> 等等，渐进增强


Cool!


It looks like this requires that any published point must be no older than the step size. With the setup I'm working on I could see that being a little hard to meet if performance took a big dive. Maybe not yet, I'll experiment and find out.

Basically the app collects its own metrics, then exposes those as a json blob over http (see [sample](https://gist.github.com/matschaffer/462b5ebdcfc359312ce1#file-metrics-json) here) that as far as I can tell is basically a collection of tagged gauges.

My plan was to poll this every 1s from hekad, then every 60s have hekda ship to influxdb.

While I think this should work, is there any hope of allowing slightly delayed metrics to come into the system?

Or are their architectural assumptions that require all data to be at least as new as the step size?

Thanks!


Can offer be null here?


You can move this outside of "if" since even if there is no entry for "host" "remove" won't do anything


logo 不可以点击么？


Hi, I think this should be reverted? Even if we don't use the contents from these directories for auto-completion, valid files could still be there people might wants to see / edit them.
The go tool ignores their content from compilation but we do a bit more then that.
Also, maybe completion while editing these files should still work from them.
What do you think?


`static ReturnType compute(Operand operand, ReturnType result)`


this doesn't seem to belong here. I thought this is simply about upgrading babelify


use putIfAbsent here. If return value is null it is first "put" otherwise return value will be previous "put"


`static ReturnType compute(Operand operand, ReturnType result, UnaryOp unary_op)`


Since return type is known here, there is no point of delaying the allocation to impl level.


不建议给每个元素都添加一个 class，可以使用 css 层级，子选择器啊 等等的


You did what? o.O

You're either using a Unix socket or you're not. You can't use both. Figure out which you want to use, then edit this line.


c


清除浮动也有一种不用添加 dom 元素的方法


If is_type_in_list(ventcrawl_machinery)

Hardcoding is bad.


这里为什么直接写行内样式了？


Can you elaborate on this? DataWrapper have a different constructor and doesn't accept callback


But again, there's no reason for this to be two lines of code: `return sum(1 for x in nonisomorphic_trees(order))`


Yikes. Get out of here with that recursive.


me and @magsout desagree ;)


Maybe two wrappers not required as well.


@wxzh Okay. Please go ahead.


You may want to check that that's actually the default. Have them check sites-enabled or apache2ctl.


Add a `bool in_place` in the param.


已经设置了 float: left，不需要再设置 display: block 了，float: left 会触发 bfc


@Justineo possible to add arrow function support as well?

For example,

```javascript
var single = [1, 2, 3, 4, 5];
var double = single.map((n) => arg * 2);
```


Same here. Fix please!


line-height 不需要 px 单位


According to LSB (Linux Standard Base), you should be using `/srv/` for site-specific data which is served by the system. You should change `/var/` to `/srv/` for convention. Granted, in Debian-like systems, they tend to use `/var/`, but eh. Debian isn't always right :)


是想用 line-height 来撑高容器？这种方式好吗？


I'm almost tempted to suggest moving this into its own documentation in ../databases/mysql... Comments?


Do you care if an info was already inserted before or may be it can not happen?


shouldn't this set partitioned true?


hard issue. It's a point of view. but I prefer without semicolon.


Just my opinion ;)


can rmNode be null? if yes it will cause NPE on the next lines


this would be more readable if you added `{}`s to the lamda


Yo! Igentligen så är det enkelt, när en video (som inte syns) har börjar att ladda sätter vi upp två canvas:ar, och sen så har vi två funktioner som får köra när videon startas. Notera att det är *två* funktioner så att det inte blir nån minimal förskjutning (hoppas jag). Funktionerna startar och gör igentligen båda samma sak med var och sin canvas: de kollar om videon spelar (varför gjöra nåt annars) och sen kopierar de den nuvarande framen från videon till canvas:en. Sen så körs en [`requestAnimationFrame`](https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame) som fixar updateringen med max 60fps eller så snabbt som möjligt. Annars så är det bara en massa kod med [jQuery](http://jquery.com) och co för att fixa resizing och dragability.

/Daniel

BTW: Testa' du det? ;)


If you really want to patch this, then a lot of things need `nextgroup` updated. In fact, the problem is `objectLable` or `objectComputedProperty` should not come in arbitrary place. As fixed in https://github.com/HerringtonDarkholme/yats.vim/commit/12dd40c88e22935aeaead2613b74f3421db92aed
![Uploading Screen Shot 2015-04-24 at 14.09.46.png . . .]()


shouldn't coordinatorOnly below this line, set partitioned false and clear the hashing info


on behalf of Prateek, helpmarkdown for this  : "These credentials are used by some of the deployment and test tasks. The username and password should be same for all the VMs."


Line 270 introduced bug #3


No one uses it?  What about https://github.com/s-mage/rush/issues/10

Isn't this the basis for Rush::Box remote stuff?  What about https://github.com/s-mage/rush/blob/master/lib/rush/box.rb#L118


put this under a different namespace. Maybe a different file.


# This R script does the following:

# 1. Merges the training and the test sets to create one data set.

tmp1 <- read.table("train/X_train.txt")
tmp2 <- read.table("test/X_test.txt")
X <- rbind(tmp1, tmp2)

tmp1 <- read.table("train/subject_train.txt")
tmp2 <- read.table("test/subject_test.txt")
S <- rbind(tmp1, tmp2)

tmp1 <- read.table("train/y_train.txt")
tmp2 <- read.table("test/y_test.txt")
Y <- rbind(tmp1, tmp2)

# 2. Extracts only the measurements on the mean and standard deviation for each measurement.

features <- read.table("features.txt")
indices_of_good_features <- grep("-mean\\(\\)|-std\\(\\)", features[, 2])
X <- X[, indices_of_good_features]
names(X) <- features[indices_of_good_features, 2]
names(X) <- gsub("\\(|\\)", "", names(X))
names(X) <- tolower(names(X))

# 3. Uses descriptive activity names to name the activities in the data set.

activities <- read.table("activity_labels.txt")
activities[, 2] = gsub("_", "", tolower(as.character(activities[, 2])))
Y[,1] = activities[Y[,1], 2]
names(Y) <- "activity"

# 4. Appropriately labels the data set with descriptive activity names.

names(S) <- "subject"
cleaned <- cbind(S, Y, X)
write.table(cleaned, "merged_clean_data.txt")

# 5. Creates a 2nd, independent tidy data set with the average of each variable for each activity and each subject.

uniqueSubjects = unique(S)[,1]
numSubjects = length(unique(S)[,1])
numActivities = length(activities[,1])
numCols = dim(cleaned)[2]
result = cleaned[1:(numSubjects*numActivities), ]

row = 1
for (s in 1:numSubjects) {
  for (a in 1:numActivities) {
    result[row, 1] = uniqueSubjects[s]
    result[row, 2] = activities[a, 2]
    tmp <- cleaned[cleaned$subject==s & cleaned$activity==activities[a, 2], ]
    result[row, 3:numCols] <- colMeans(tmp[, 3:numCols])
    row = row+1
  }
}
write.table(result, "data_set_with_the_averages.txt")


yeah yeah I know. It's a big debate about code convention ;)


I have updated the CMake variables accordingly. Let me know if they are okay.


Useless information


L30:  storage.metadata


What? How did you get here? When you install MySQL, it asks for you to create/confirm your root password, but it doesn't bring you to the MySQL prompt.


These guides aren't Linode-specific. You should write this for any server, not just Linode's infrastructure.


I totally agree but it was done like that before because the percent is used in the CGUIInfoManager and somewhere else. I'll do a deeper look to get rid of this.


I'd get rid of the "no obligation" bit.


model.loadJson didn't work though


This behavior is not obvious given the name of the function


推荐使用 href="#" 然后 event.preventDefault()


那就好，话说这些commit都是在哪里找到的？


Oh I see you yourself opened #10    Still, I was looking forward to using this feature.  How did you determine no one uses it?


There's an extra 'i' (and corresponding '~') here.


Sections 2 - 5 should definitely be a different guide. Installing MySQL, I can understand... I think this should be a different guide in ../databases/mysql anyways, because then you can expand on it a bit.


Mark this commit. How I work around mathjax + md


Почекаю - отпишу


Also see next commit of my notes: https://github.com/hupili/blog/commit/0ead770dcedd53807f814c05ceb40e29b670b51b


Use bullet points that are actually structured for/by git.

- See
- Like
- This


This line needs fixing. That extra leading space will break in Python.


See the formatting guide for information on how to properly include external resources and the restrictions therein.


Doesn't it conflict with the audio config from sony binaries? They are copied to the same path


能否不添加额外标签来清除浮动？http://www.iyunlu.com/view/css-xhtml/55.html


I'm doubtful of the fact that it breaks on Puppet 3. We have tests running on both Puppet 3 and 4 and they report no such thing. I haven't been able to reproduce this in production either.

The reason `xfacts` exists is because of our need to be compatible with strict variables. This creates a lookup hash where we check for if the fact is defined and if so assign it the value, if not assign it undef. If we don't we need to continuously wrap an `if defined` check around our usage of that fact every time we need it in any manifest. That gets ugly real quick, this is a nicer way to solve it.

You can see the full discussion wrt this workaround in: https://tickets.puppetlabs.com/browse/PUP-4066


先不要合并，貌似还是不行。扒 display-caf/cm-10.1


菜单这里没有实现设计图的效果，没有展现出当前激活的是哪个tab


System/etc/audio_effects.conf is override by AOSP own audio_effects.conf

But tell me more about Sony binaries


Good point, too. :+1:


Does this commit mean that generic members of class should be defined with __heap__?


你实现的tab中，两个tab之间的分割线（中间的分割线有2px），可以用负外边距处理下


new binaries have it removed
Config files should be in device git


避免使用行内样式


这个很好，少了一个进程，启动会快不少。

问题1：
launcher/1.4.0/web_control.py: 248
                    data = '{"res":"fail, php_enable:%s"}' % auto_start
  应为：
                    data = '{"res":"fail, php_enable:%s"}' % php_enable
意思是把错误的参数反馈回去。

问题2：
  php模块没有启动，但原来的web_ui没有隐藏，会导致去配置php时失败，又没有提示，造成困惑。
  可以从web_ui上把php模块隐藏；
  或者在php页面上提示。
  感觉隐藏好一些。最好隐藏和打开后，提示用户要重启、刷新页面。


Okay fine


The WKB format uses "8 byte float", so it must use double to be valid. See http://en.wikipedia.org/wiki/Well-known_text#Well-known_binary

I guess it should be removed.


瀑布流布局这里，将左侧两行设置padding-top的方式灵活性很差，如果第一张图片移动到别的地方，布局会有很大的变化，建议再学习一下瀑布流常用的布局方法


Right, it's a left-over.


Does not seem to be used here.


搜索框未完成设计稿的要求


This could potentially be a bug or changed behavior of the `defined` function in Puppet over time that we're hitting. Could you get me:
* OS version
* puppet version
* facter version
* facter -p output
* What you did for the error to show up
* What you find during investigating it that gives you cause to think it's related to `xfacts`


There's no way in hell I'd ever author this.
https://github.com/SaberMod/XeHD_packages_apps_Settings/commit/3dc806cbb035c9e6a0e985efc696f23dbfcad4c8
Stop changing commit messages that say I'm authoring changes for Bobtipop.


good points. let me work them out in the next hours


aaaaa


Yea, the magic comes from declaring the struct with (weak) delegates in the .vapi
public delegate void Init(Plugin p);
	public struct PluginHooks
	{
		public weak Init init;
	}

Delegates receive the context pointer as last parameter. This is because a delegate isn't automatically a member function, and they are used for signal handlers (historically). And btw, by saying "xx.func = Class.func" (instead of member.func), it prevents vala from assuming there are func_target and func_target_destroy fields in the xx struct.


Why don't you just call it BobtiTC?


oops, sorry


toolbar这样的专有名词我觉得还是不要翻译出来为好


commit new


工具条条目 -> toolbar item  这样的专有控件名词翻译出来让人不是很明白


给同一个节点设置不同颜色的border，再拐角的地方会有一个角度，建议放大看一下（比如如果都是5px的border设置不同颜色会比较明显），所以这里的实现是不符合实际稿要求的


The changes about `SYSTICK_LOAD` should be decoupled from newly-added task control block.


Hi Ondrej, thanks for the patch. I see you have most or all of the parent methods redefined, this is not necessary as they are inherited.  Anyway I don't think this plugin will be useful outside of red hat so I think it does not make sense to push it to github.


silent  -> 那四个按钮
做起 -> 左起
设备 -> 真机


@hira-pa-  猿公害ですね。もう。　OKです！


Good idea, will do. FWIW, this was done because plugindata.h still has the line:
 #define geany			geany_data	/**< Simple macro for @c geany_data that reduces typing. */

Actually, plugin->geany would also work because of this :)


lol


Yes, you are right.
I am keep looking where I miss to define the nextgroup.
And current it have a `contained` declaration.
So it will only show at where I have `contains` or `nextgroup` to say it will be there.

The backward looking pattern hurts performance.
If I can use nextgroup to fix an issue.
I will use nextgroup first.
The only place I use backward looking


1. lto1 spams about arch/cpu conflicts
2. I see no difference with performance
3. I use Your toolchain with flags optimized for cortex-a15


All Java methods should have names starting with a lower case letter. Also, I personally don't understand the name.


块级元素设置为行内元素，在ie7下需要进行兼容性处理


The way I'm dealing with it until SDL supports toggling resizability is by using a min/max hack like you mentioned. It works fairly well: https://bitbucket.org/sparklinlabs/nuclearwinter/commits/87dc973fd1a8c8768a55b1c3ed0899789eabcf76?at=default#LFNA/src/SDL2/SDL2_GameWindow.csF10

The only terrible thing I had to do was setting the maximum to (100000, 100000) since you can't set it back to 0: https://bitbucket.org/sparklinlabs/nuclearwinter/commits/87dc973fd1a8c8768a55b1c3ed0899789eabcf76?at=default#LFNA/src/SDL2/SDL2_GameWindow.csT283 ¯\_(ツ)_/¯


cm


I don't see a problem with PluginCallback (other than it's not called GeanyPluginCallback, bad for g-ir-scanner :) ). The callbacks are statically defined (for convinience of the plugin authors, and many plugins use it in g-p) so the data needs to be set like this.

I like the idea of passing the plugin as user data by default, though, so that one can usually omit this line.


有没有更符合go语言特性的语法来操作数组？


The coffeescript convention for an argument-less function is just `->`, no need for `() ->`


@Unknwon, could you confirm this?


多余的注释不要出现在patch中


Yea, err, what?

Will remove


I don't think performance will be a big issue for a syntax highlighting aiming at precision, since source lines will not be too long in practice. And users can always switching to simpler plugins.

As the complexity grows, I usually wonder whether a simple lexical keyword highlighting is enough for terminal user and meanwhile reduces maintenance burden on plugin author.


居中应该设置margin-left: -5px


`@confirmArgument` on lines 92, 94 should be `@cancelArgument`, no?


aaaaa


Plz Add comments


LGTM


No image is required. I will update the usage message to be more clear and non ambiguous.


@shuji-mwed 確認OKです


Sorry for the version bump - I had to update the version number because otherwise, bower only lets me pull the upstream repository, not my forked version (?).


woaw `:help vnew`


Okay. I will update this


you can view latest changes here : https://github.com/Microsoft/vso-agent-tasks/pull/58/files


Why the negation of the test? I think the exclamation mark should be removed. Proof of it is that the Debian package dependencies of the `swaddle` package itself didn't end up in the `control` file.


时间轴这里建议用列表标签，列表内容依次为‘name’，‘联系方式’， ‘教育经历’， ‘实习经历’等等，保持良好的语义化


I tried it out on one of my production machines:
* Puppet: 3.7.3
* Facter: 2.3.0
* lsb-release: installed

The test I did:
```puppet
$xfacts = {
  'lsbdistcodename' => defined('$lsbdistcodename') ? {
    true    => $::lsbdistcodename,
    default => undef,
  }
}

notify { $xfacts['lsbdistcodename']: }
notice($xfacts['lsbdistcodename'])
```

```
daenney@awseu3-apttest-a1:/tmp$ puppet apply test.pp
Notice: Scope(Class[main]): trusty
Notice: Compiled catalog for apt-daenney in environment production in 0.03 seconds
Notice: trusty
Notice: /Stage[main]/Main/Notify[trusty]/message: defined 'message' as 'trusty'
Notice: Finished catalog run in 0.02 seconds
```


@chebee7i Thanks


주석 넣어주세요


This plugin did not use PLUGIN_SET_TRANSLATABLE_INFO, but just PLUGIN_SET_INFO, therefore I didn't add this.

Perhaps a comment like this would be better guidance?
/* If you have a separate gettext package, do the following before accessing
translated strings by setting plugin->info:
main_locale_init(localedir, your_package);
plugin->info->name = _("Awesome plugin");
*/

Will remove the separate function.


Performs a nil-check. (NilCheck)


Has boolean parameter 'stringify' (BooleanParameter)


Is controlled by argument stringify (ControlParameter)


Cyclomatic complexity for cast is too high. [8/6]


Thanks Manne, I agree, but IterableObjects is a name of Jira class and so I decided to leave it in upper case.


Hi @noisebleed we are working for this update here #398.. :)


Nice update!


It doesn't explain why Chrome didn't have such compile error on the same release branch.


Will remove. Probably a mistake happened during rebase


@ziafazal FYI, just updated the hash for SOL-423


Let's create a SeekTimeRelative method for player. That is what we actually want to do. CGuiInfoManager should not be used for any calculations, neither relative nor absolute.


Excellent. This looks quite reasonable.


Thanks for fixing my typo ^^


My fault. I should replace default-jre-headless with openjdk-7-jre-headless. See PR #206


번역하면 안녕~~~ ㅎㅎ


约束的item mutiplier constant 还有  priority还是不要翻译出来了把，特别是mutiplier和constant用中文表述不太清楚。
改为，此时可以看到约束的item,mutiplier,constant 和priority 属性。


Yes, but I wanted to exit from fold, I had to catch it inside method to return scalacheck value.

Is it possible somehow to stop fold or map execution without exceptions?


Hi,

After having been notified of the API change, I've fixed the issue in angular-pan-zoom.
Ref: https://github.com/mvindahl/angular-pan-zoom/issues/35


I see. My panels are in a different wrapper from the tabs, which works fine. But I see how this fails, when the HTML structure is in a single wrapper. I changed this because it allows for greater freedom in the tab HTML, so that tabs don't need to be direct children of the main wrapper.


I can try it in my Mavericks, but I wonder, did you install GCC by hand? I use brew and it seems it hasn't been updated yet.


The line is again later in this file. I added the first one (as a duplicate) in 0547b37c. I decided to remove duplicate it in this commit instead of of modifying 0547b37c8 because I was a bit lazy.

I can totally fix up 0547b37c instead. I am myself generally in favor of rebasing and inline-fixup to bring all commits into good shape before merging.


化身 -> 头像


Yea, but the line gets quite long then so I'd rather liked it this way (before this commit it would have been even longer which is why I split the if up like this initially).

But now it short enough to be accceptable as a single line that's right.


ke heula aing can ngarti euyyyy


Thank you!


The time it'll take for a test to finish is approximately:

50k games - 2 days
100k games - 4 days
150k games - 6 days
200k games - 8 days

Better way than pushing with priority = 1, is to increase the throughput, e.g. by 30%...


의미를 알 수 있는 이름으로 변경하는것이 좋겠습니다.


There is a huge performance impact about javascript lib syntax before.
It's caused by backward looking.
After that, I try not use it if possible.

In this case I think nextgroup can also solve this issue.
And it don't have impact on performance(but cost more memory).
Another reason I prefer nextgroup is because lexer is always look forward.
Not look backward.

If you can give an example that can't use nextgroup to solve.
I will agree to change the fix.

I agree with you that current Vim simple lexical highlight system is not enough.
`=>` takes me several day to figure out how to highlight correct in most cases.
And there is still an issue on comment, ex:

    function /*comment*/ fn() {}


"exmaple" should be "example" ;)


-- hier muss für Windows/Dos unterschieden werden
-- "\" für Windwos?


Hi,
I'm using socialauth version 4.8 which includes FB version 2.2. Still I can see v1.0 in my FB Login, Let me know if I have to some other changes.
My current FB url(after upgrading), while login, is.
https://www.facebook.com/login.php?skip_api_login=1&api_key=457312010959458&signed_next=1&next=https%3A%2F%2Fwww.facebook.com%2Fv1.0%2Fdialog%2Foauth%3Fredirect_uri%3Dhttps%253A%252F%252Fwww.homeshop18.com%252Fsocialauth%26scope%3Demail%252C%2Buser_birthday%26response_type%3Dcode%26client_id%3D457312010959458%26ret%3Dlogin&cancel_uri=https%3A%2F%2Fwww.homeshop18.com%2Fsocialauth%3Ferror%3Daccess_denied%26error_code%3D200%26error_description%3DPermissions%2Berror%26error_reason%3Duser_denied%23_%3D_&display=page

Please let me know the solution ASAP this is really urgent.

Thanks & Regards,
Atul Bhatia


출력문구 수정이 필요해 보입니다.


It's stated in a readme that you should not use CN Camera as a game camera. It's should remain stationary throughout the game
*The overhead of the second camera is far less than of recalculating the position of controls every frame*


I would make the code slightly different: tee_entry() to call plat_common_tee_entry(). Then I guess that plat_common_tee_entry() would be part of tee_entry.c (we may also change the name plat_common_tee_entry). This way, you do not have to modify optee_design.md,


@skeptical I will test it for you and post the results


These tweaks has broken Samba for many OE-A Team images, SAMBA server appears to be working fine, but SAMBA client is broken.

I've spent hours testing, OpenViX, OpenXTA, only ATV is able to mount Receiver HDD to Receiver HDD using SAMBA. Other teams images are now broken, prior to these changes all working fine.

This either needs fixing so its working for all OE-A teams or reverting.

These changes have been made with more or less no consideration for other teams. Changes like this should have been tested by other teams prior to committing to OE-A.


If we do a null-check here, we should probably do something in the case of `data == null`.

I'd actually consider doing a null-check in the constructor, and throw `NullPointerException` or `IllegalArgumentException` if it is null. We could really do the same thing with `clock` as well.


-- Bei mir hat die Option "-c 10" die vollen Dateien abgespielt.
-- die Option "-d" funktioniert unter windows scheinbar nicht.
-- der Aufruf vom ".\contrib\sox\sox <infile> -c 10 -t waveaudio -q" wäre dann ohne Ausgabe
-- und Abspielen der vollen Länge der Eingabedatei


@mymai91 shouldn't this line be comparing `updated_user.updated_at` against `user.updated_at`?


@testingbydev

Please do a git pull to retrieve the latest updates.


please notify me when you release this as I'll need to merge and carefully check that works at the new public map branch


_scrollOffset could be either margin or padding on both <html> or <body> element and needs to be calculated any time a scroll offset is calculated, because it could change at runtime (when a static header without body offset changeds into a fixed header with body offset).


空链接？


This map might as well be `Map<Id, ProfilingInformation>`, no?


파일로그로 출력했으면 합니다.


수정하도록 하겠습니다.


의미를 알 수 있는 변수 이름으로 변경하는 것이 좋겠습니다.


expression 뒤에 콜론(:)과 공백 하나를 추가하는 것이 어떨까요?


This code throws Exception unexpectedly when new_usec is Rational object and the value is between 999999 and 1000000. e.g) Rational(999999999, 1000).
You should use "if new_usec <= 1000000" instead of "if new_usec > 999999".


Nitpick: Please add braces here


here as well


do we really need to turn on -pedantic?


This doesn't work. The point of having the conditional is to have a 'safe' string to use. At this point I suggest to introduce a new tag **spring_release** and use this
```
  {% if l10n_has_tag('spring_release') %}
    {{_('Built for those who build the Web. The only browser made for developers like you.')}}
  {%- else -%}
    {{ _('Introducing the only browser made for developers like you.') }}
  {% endif %}
```


Functions tee_entry_get_api_xxx() are already defined as **weak** in entry.c. So they should not be redefined somewhere else in common code.

It is worth to fix the weak functions as all current platforms share the same tee_entry_get_api_xxx() implementation.


force static?

try to use BUILD_SHARED_LIBS=ON so that user can control shared/static


Why are you changing this? This is the fallback if the new string is not localized and the file is missing the ```share_cta``` tag.


this could be enabled only if BUILD_TESTING /BUILD_EXAMPLES is enabled


end_of_day() sets Rational(999999999, 1000).
So, the error occurs when you call end_of_day() for the time object which is not utc and not set zone.


Glad I could help.


do we really need last two lines?

Also enable_testing can be called if BUILD_TESTING or similar cmake variable is set


you could send a pull request to muparserx upstream.

This commit is worth it. Thanks for the work


ステップ3まで実装


运行合并


add 함수에 인자값을 추가하는 건 어떠할까요?


Builds fine now thanks.  (am also following and up-to-date-with emails on audacity-devel).


> The /dev/$vgname directory only exists when one or more of the LVs are active.

I know, I just thought one can have an active VG with no active LVs which is not the case. This check is correct then.


Practice2/methods/Thumbs.db --- AAAAAAAAAAAAAAAAAAAAAAAA!!!


It is not working for service worker too.

Sounds like a test is needed for this branch. I can try to create a test to
create a service worker and see if it add record to indexeddb.  What do you
think?
On Apr 24, 2015 11:47 AM, "Aaron Powell" <notifications@github.com> wrote:

> No idea. I haven't got a repo of this inside a service worker either so I
> don't know how it should look
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/paulcbetts/db.js/commit/8688ac867f75490ea9363e4761d1dba9ebe714df#commitcomment-10881381>
> .
>


All the strings from this point on needs to be behind a tag (as suggested above, I'd use ```spring_release```).