Yay - as the author of `flycheck-package`, this commit makes me happy. :-)


Hey, I'm on there! Pretty cool. Minor contribution though, but appreciated.


what about filetype files in no groups?  ok, probably shouldn't happen in the syspath, but still.  a better test could probably be `if ft->id != GEANY_FILETYPE_NONE`


Can you add a comment saying the order is important in this with statement, and why?


maybe both ValueError and IndexError?


Because I don't know much about firewalls, I assume there is a way to configure them so that when the browser tries to access some URL the (404) response is sent right away. Am I wrong? If that's possible then the user will not wait 7 seconds.


Create new payment method


Style form with bootstrap .form-horizontal


Because I can.


Without it there is a risk of a `O(n^2)` loop, where each `add` traverses a `O(n)` list of slots. Code elsewhere does assume that the number of slots is small, but it is unnecessary to make that assumption here since the quadratic can be avoided with just a few lines.


Thanks


Hätt ich selbst nicht besser machen können  (y)


Well, but you took the time to improve something and create a pull request :) That's appreciated.


reverted


+1 Wow, nicely done and formatted. Gonna pull this from your remote and check it out while we wait for a second and third +1.


Replace with regular button with type 'submit' and style it with bootstrap .btn-primary class  http://getbootstrap.com/css/#buttons-options


@ozra i concur. Readability is one of the most important aspects of code.. yet the JS community is big on 2 spaces. I think they are trying to hide their callback hells.


You can use `test_files` like:
`t.test_files = allocator.node_tests`


maybe just
```c

	foreach_slist(node, filetypes_by_title)
	{
		GeanyFiletype *ft = node->data;
		GtkMenu *parent = (ft->group != GEANY_FILETYPE_GROUP_NONE) ? group_menus[ft->group] : menu;

		if (config && ft->id == GEANY_FILETYPE_NONE)
			continue;

		if (config)
			ui_add_config_file_menu_item(filetypes_get_filename(ft, TRUE), NULL, GTK_CONTAINER(parent));
		else
			create_radio_menu_item(parent, ft);
	}
```
would work?


yes, I tËsted it. Should I move the encoding to the return?


missing translation `_()`


From a programming perspective, in situations like these where there is an if/else conditional, you want to try to avoid negative condition checks because they can be more difficult to reason about at first glance.


Feels cleaner, especially since you are doing stuff with unicode in the next line


really, how so?


So in the case where:

internalfeed (contains Moq)
globalnuget (contains Moq)

Moq is added to the first feed (I guess that can also be converted to a test)


Я ж писал про плейсхолдеры, а не про лейблы)


This is linked to issue #19 but for the case of already running job:

Fix the case of running inner jobs which appears before their container in the scheduler initialization: inner jobs must be kept back and handled afterward, otherwise the container gantt wont be filled with the inner job (only the default gantt) which implies a wrong scheduling for the new inner job in that same contrainer job.
However, even with this fix, we still have have a potential issue is the container job is a queue that is of lowest priority than the one of the inner job... That case should then be prevented in an admission rule.


He cool :)
i will test all.


关键在这里啦


This can still be only a minor change to the original code -- define ``default`` before the for cycle as ``None`` and then select it only if it ``is not None``. That still looks to me more elegant than throwing away the iterators as we get them from ``append()`` and then iterating over the whole store again to get the iterator.


Labelling rebroadcast differently makes them grepable. The `localNodeId` column shows up as `<test>` when running the in-process simulation with many nodes, so without the `@nodeid`s the simulations are impossible to debug.


isn't that a bit odd?
well, as this seem to actually only be used in the config menu, I guess it's ok.


Why would you use `0` though?


curious what others are doing after this change when using bower files to add resources like fonts and sprite images to their distribution?

This removed the `select2.png` `select2x2.png` and `select2-spinner.gif` from the `main` and I plan on using an override in my own bower to fix it but is there a better way? was that thought through at bower when they moved to having the `main` only point to the main entry point files?


OK, thanks for the clarification.


этот инпут не нужен, раз мы их заменили ссылками. Хотя у ссылок – обязательный атрибут `href` – куда он  будет вести?


Sounds nice, but I would think it would be even better to have an item to open the current document's filetype file without having to search for it in the list :)
like "Open current filetype configuration"


BTW recently I tried define task like that but using Knapsack::Adapters::MinitestAdapter before executing rake task will remember report because Knapsack::Report is a Singleton so you won't be able to use multiple rake tasks for different adapters at the same time.

I had to use ENV to avoid the problem
https://github.com/ArturT/knapsack/commit/a18a50ade444b0797b6c314e7d56b74b811dd292

If you will encounter similar problem this might be helpful.


Use FactoryGirl attributes_for instead of params plain hash (and move it to let method call).


а, всё ок!)


I actually have 2 more changes committed to my branch: I first added django migrations (as opposed to South migrations) and also made it Python 3 compatible (with backward compatibility to python 2), using django upgrade path prescriptions found here: https://docs.djangoproject.com/en/1.8/topics/python3/

However, I'm not sure I did it in the right order, in case you don't like the django migrations but would like to have the python 3 compatibility. It does mean you'd need at least django 1.4.2. Do you want that?


Did you mean "return" rather than "raise"?


@malex984
@fieker

> new libraries deflation.lib maxlike.lib recover.lib :

commit again without tests??

#*$^~


I'm not sure if it's just me, but In the book url: https://book.discovermeteor.com/chapter/comments

you have these lines in the /client/templates/comments/comment_submit.js file:
Template.postEdit.onCreated(function() {
  Session.set('postEditErrors', {});
});

instead of:

Template.commentSubmit.onCreated(function() {
    Session.set('commentSubmitErrors', {});
});

Thanks,
keep up the great work :+1:


I have made some more progress on this but am currently stuck. I have some info here: https://github.com/doadin/deluge/issues/3 .
Latest updates can still be downloaded here: https://github.com/doadin/deluge/tree/develop-pygi . If you maybe have a free moment.
@bendikro @cas-- @aresch @rmmh just adding a few names because i know a couple of you have contributed to deluge fairly recently. If you dont want to/cant help its fine just kinda of a big task for just me looking to maybe get some help.


Merged to develop.


My bad! Still time to release 0.4.0 or best to do nothing?


fiz outro comentario


we have a test for this.


56:1: I201 Missing newline before sections or imports.
57:1: I201 Missing newline before sections or imports.
60:1: I100 Imports statements are in the wrong order. from invenio.base.decorators should be before from werkzeug.local
215:5: B901 blind except: statement
283:9: E731 do not assign a lambda expression, use a def


I've always wanted this! :smile: Thanks @ef4!


This results in only one call to 'add_config'.


Rob, as we discussed yesterday, you need to normalize the distribution on lines 67 through 70 (but not 66).


This will overwrite whatever you pass for class_name.


a final detail: `gregorio -sS` should be replaced by `gregorio -s -o ..tmpname` (adapting the quotes)


Hey! @smallsun11, you're welcome, I didn't think someone would use it hahaha.

This is related to bug #14 https://github.com/arielj/evette/issues/14, I might fix it today since it looks pretty simple (just the wrong method called on the wrong object).

Thanks for helping reporting bugs! Please use the Issues section so I can follow them better.


I'm on my phone, but are you referring to the fact that we'd be testing
against nested tuples? I've tried it, it actually works.


Ok. How do you want to instantiate it?


I don't think this is necessary, since it's declared in dataXfer.h line 55, and #included by dataXferWrap.cpp.


It was a reason to not sending 'error' event with UnauthorizedError instance?


If you add the `DASSERT` above, you probably will need to re-order the tests here.


Good catch. I thought i had done that the other way round.


Copy paste error:
BATTERY_CHECK: 'onlineCheck',
Should be
BATTERY_CHECK: 'batteryCheck',


@CalienteRaymond no I've meant the fact that `0` renders as `Pending` and that `Pending` might also have to be translated. I'm asking about what tools Angular gives you to move this "rendering" logic into the view, in a reusable way (eg: so you can use it every time you render a task state)


I'm still seeing some build errors with this version of nan.


Since we have this test https://github.com/bladeSk/ably-php/blob/ef642e0c611351dadc0b5e6621fc7500b7c5b032/tests/InitTest.php#L74-L90 I doubt we need to cover any more for this particular scenario.


I think it grew this way for a couple reasons:
1. I'm wary of having the javascript make decisions regarding permissions, so that necessitated all the `if` blocks for the various links. (I'm pretty sure we do a good job of verifying permissions for all the actions, so my concern is probably a bit unwarranted...)
2. At that point, I might as well start specifying link-specific things, like the link text, too.
3. At which point, if I specify a few other things, the React component can become a very generic wrapper around links and doesn't need to know anything about what the links actually are.

Not to say that that's correct to do it this way -- just that it was that iterative process that created this.

So one difficult thing in regards to moving everything into the React components is translation. Have you encountered anything for supporting i18n or l10n in React? Because the components are pre-compiled, we can't rely on Rails' support to do it, and would need to have a client-side library and client-side definitions.


A thought -- more of a preference or philosophy than correctness: I avoid semaphores/mutexes whenever possible, instead relying on signals/slots (message-passing), which avoids almost all livelock/deadlock conditions. Here, I'd probably assert that we're running in whatever thread does the serial I/O, rather than use a mutex.

...but this is also caused by my (lazy) implementation of dataXfer, where I only support a single, static dataXfer instance. It was easier than passing a pointer to a dataXfer "object" around....


The bug fix is this big:
```
+    auto toDelete = mBallotValidationTimers[ballot];
+    mBallotValidationTimers.erase(ballot);
+    toDelete.clear()
```
It's definitely a bug. I can demo it if you would like.


:heart:


Thanks! I think I got the stragglers in https://github.com/brigade/overcommit/commit/4eeb0c42dbe5a2f4f54bb1ee889dcde61a0e5a18

Let us know if you notice anything else we missed.


Use url_helpers go get url.


Are you suggesting that these comments be included in MIL-STD-2525D "Comments" section?  Or are you simply suggesting these comments be considered for use in the xml script by implementers?  Or perhpas both?  (from Bill McGrane, SSMC chair)


just ; is it really necessary to convert the set back to a list here ?


No big reason except I like the symetry. `HerderImpl::validateBallot start` followed by either `done directly`, `done by timer`, or `done by v-blocking`


rax retry tests


Also "goto out" to return the error


这个要放在最前面判断


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14588/testReport/) for this commit**


I think that was already there. I'm not sure why though.


using iterators here would greatly speed up the update. Furthermore currentPoint and nextPoint could be swapped at the end of the loop and getSpatialResolution called outside of the loop.

double v is a bit weird here because you will always get an int back


Not sure I agree with this one.


do these inherit and merge?


nit: maybe put `/* pageURI */` besides this ?


@tim, Deine Arbeiten sind eventuell unnötig. Schau mal in den Branch von Dennis. Der macht das alles swipeable und hat schon einiges korrigiert... Schau mal lieber nach den notification, die brauchen wir noch dringender.


Can we file a bug to add this in a shared place, and put the bug # in a comment before this function ?


You need to update the javadoc to say execute() needs to be called first for these methods.


The line203 (osc describe) didn't get resources from Kubernetes. I updated `DescribableResources()`. Thanks.


Are you looking at an outdated version? This (stupid) error has been fixed in https://github.com/ev-br/scipy/commit/cbc8a25940b8666532ef47d336051776e96c94fb


Unless you want to put it in a shared place now -- but I don't think this should block us.


calling resize(lastBeam.beam.size()) would remove unneeded copies during fill


@gregsochanik I'm not sure, but @jvandertil had another solution in #27 that seems more elegant if it works:
```csharp
return requestStartupTypes.Select(container.GetInstance).Cast<IRequestStartup>();
```


Make this an `else` for clarity


Echt jetzt?. Das ist nicht dein Ernst oder?


If there are several results, they will be overridden here, I think and thus only one book displayed in the result list.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14589/testReport/) for this commit**


Yes


Is much better return the stream directly instead of bytes.

I'm curently reimplementing this method just for return the stream.

```
stream.seek(0)
return stream
```

would be awesome!


Hi


I think it's better to return `null` instead


doch, hat kingjan bei mir auch gemacht xD


add .sublime-syntax?


Done


2 spaces. TWO SPACES!?!?


This line and the next one should be executed after the request comes back


Shouldn't QT5WEBKIT_DEPENDENCIES be updated to include dxdrm in qt5webkit.mk?


Wie unnötig und provozieren xD!!


Eventually. Not sure if right now though.

In that case we should also add `.tmSnippet` to the snippet entry.


This looks intentional, if it's 0 it should just default to normal size, rather being non-existent.


what about line 142?  Or is that intentional?


@FlashJunior Here's an explanation of why this change could break elements inside off-canvas: [link](https://github.com/zurb/foundation/issues/5819#issuecomment-55919197)

And here's verification that it did exactly that: #6519

The method we switched to might be a [slightly better best practice](https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/), but developers using Foundation have already been developing around the old way for years now, so a better time to make this change is in Foundation 6.


`brew upgrade formula` will upgrade formula regardless the pin.


1.linux编程
  1.1多进程与多线程
  1.2网络编程
  1.3数据库编程
  1.4进程通信
  1.5文件,日期
2.c深入
  2.1数据结构实现
    2.1.1letcode
    2.1.2剑指offer

  2.2算法实现
  2.3c开源项目
3.linux操作系统
  3.1linux汇编
  3.2linux内核分析
     3.2.1网易云课堂课程及实验楼实验
  3.3ucos
    实验楼实验
4.嵌入式基础
  4.1学习课件
  4.2实验完成


Could someone describe more in details what is being done here?


As I said earlier this commit address an issue that affects the `[simulation][long][hide]` that run with dozen of simulated nodes. Under the heavy messaging load that these tests create, `VirtualTimer` events are starved for minutes at a time. This means that (1) timeouts don't trigger, though this doesn't really cause any problems directly since when the tests are running well there are no timeouts. And (2) the callbacks controlling the tests only trigger after a minute of delay, which slows them down needlessly and skews the performance numbers.

These tests are not critical now. Let's fix the testnet first, then I'll try to find better solution to the starvation problem.


Just do `console.log(err || res);`?


Thanks for your remark - I'll further inquire this.


Won't this not protect `childList`, etc, from being renamed?  In my externs, I've had to do something like

```javascript
/**
 * @typedef {{
 *   childList: (boolean|undefined),
 *   attributes: (boolean|undefined),
 *   characterData: (boolean|undefined),
 *   subtree: (boolean|undefined),
 *   attributeOldValue: (boolean|undefined),
 *   characterDataOldValue: (boolean|undefined),
 *   attributeFilter: (!Array<string>|undefined)
 * }}
 */
var MutationObserverInit;
MutationObserverInit.childList;
MutationObserverInit.attributes;
MutationObserverInit.characterData;
   .
   .
   .
```
to keep the members from getting renamed.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14590/testReport/) for this commit**


Can we get away with this and let user enter the password when you need to install some packages ? I dont see any special needs for it otherwise.


It's ok to introduce "Shipped Packages", but I think this is too much info for users/package devs. The should not alter the Shipped Packages in any way, so it's pointless to explain how Shipped Packages are organized.


This will need my update again following #169 (removal of `ogit/Set`).


Perhaps you can move https://github.com/01org/ozone-wayland/wiki/Build-Wayland-&-Weston-using-jhbuild this to README file.


Please describe a problem in maillist and lets discuss it there, please also take a look at our github chatroom we need to use it for some small conversations


You could shorten the above as follows:
```python
def __init__(self, dict_file):
      self.dict_file = dict_file
      self.LETTERS_AND_SPACE = string.ascii_letters + string.whitespace
      with open(dict_file, 'r') as file:
          content = ''.join(file.readlines())
      self.ENGLISH_WORDS = set(content.upper().split())
```


Ah of course :no_mouth:. Thanks.


It's needed because line 54 in this file would otherwise declare it with C++ linkage.


```
For simplicity we will, on occasions,
For simplicity, we will occasionally
```


Gestko ;-)


refer to all these directories as :file:`{Packages}`


The input is for debugging purposes if a `ParseException` is thrown. It's not meant to be a valid playlist. And yes, m3u8 can use either `\n` or `\r\n`, both are valid.


This looks like an interesting feature. Any chance on a pull request over to the main repo? I think it might be a good way to solve some of the feature requests I've had.


substantially hardened


by => as


You're welcome. :)


Minor edits so far, haven't got beyond end of §2 yet… more tomorrow...


Then I think that should raise an exception, shouldn't it?


> Here we disagree.

Yeah, I think we can agree to disagree here :wink:

> we cannot detect whether the intent is to support MSys2-backed terminal emulators

That's the crux where we differ, I guess. Why would someone *intentionally* want to disable this feature? If we have the *capability* to detect MSys2 terminals, we should.


I think we can drop "by default". There is only one ST distro.


1 - 06/05


@hadley I think I had this here to ensure **plyr** gets loaded before **dplyr**, but maybe it's better to do that in `render-tex`?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14592/testReport/) for this commit**


I hate GIT ....


Swap the two sentences for better comprehension.


you are welcome :sparkle:


Hm. We just said Shipped Packages aren't technically required. This needs revising.


I believe the function should be instead:
```julia
function rand(r::AbstractRNG, ::Type{Char})
   v = rand(0x00000000:0x0010f7ff)
   (v < 0xd800) ? Char(v) : Char(v+0x800)
end
```
Much simpler, and your code misses one valid code point... 0x10ffff.


That's a good point, I didn't think about how the caller detects that there are no more playlists left. Each call to `parse` is supposed to parse exactly 1 playlist and no more, so I think the break here is okay. Either we should return null if `parse` is called again and no more data is available, or we should have something like `boolean available()` to see if there are anymore playlists to parse.


These are packages... (at the beginning).


Может, тут сделать просто `header__menu-btn`, а при открытии – будем добавлять модификатор: `header__menu-btn header__menu-btn--opened` – что скажешь?) И ещё один момент, я именую классы для кнопок, что бы btn было сначала, а потом продолжаю из специфицировать. И мне всегда видно, что если начинается с btn, то это кнопка: `menu-btn` чуть хуже может читаться в больших проектах чем `btn-menu`.


Ok, if you wish to move that rendering logic into the view I think a good tool is ng-pluralize, which lead to i18n angularjs function as well.

Best regards,

Alexandre Damiron
Caliente Raymond SAS
alexandre.damiron@caliente-raymond.com
(+33) 06 26 33 38 41

> Le 6 mai 2015 à 17:43, Mauro Asprea <notifications@github.com> a écrit :
>
> @CalienteRaymond <https://github.com/CalienteRaymond> no I've meant the fact that 0 renders as Pending and that Pending might also have to be translated. I'm asking about what tools Angular gives you to move this "rendering" logic into the view, in a reusable way (eg: so you can use it every time you render a task state)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/CalienteRaymond/VrRecruit/commit/dce3cc06756aa2f4b3cb76042bc456f3d9b7214d#commitcomment-11068329>.
>


This is confusing. Needs revising.


I'm not sure if this is related to my changes or not. The etag that was set here was persistent and caused the following test to fail (expected the call to get_activities_response to have etag=None but it didn't)


OK, no problem. Thanks for explaining it all :-)


give them the key so they can disable the source later if need be


empty newline


открытка


This is version `0.1.0` of PIConGPU, a *pre-beta* version.


I think it's pretty clear from the code that if the end of the list has been reached, we stop parsing. If you see this as a pain point, then we should consider how to make this more clear in the code itself rather than using a comment.


I would delete (new).


After years of 2 spaces, I found that I would still sometimes have a hard time visually discerning different indentation levels. 4 is the right amount. With back calls, yield, and other features, it shouldn't be a problem


This commit breaks most of the tests.


I think in ST3 the folder is created by the app on first run even if it's empty (which it normally should be). So we can delete this part.


You're right, we don't allow `:iimage_url` - this is the first I've heard of it. I guess it must have been added to the attachment specification relatively recently. Thanks for the PR to add it.


Makes sense, I'll remove.


Rename this to "Special Rules" or something like that.


you are correct. It needs the Altmel driver.

Kind Regards,
Zachariah Kennedy

On Wed, May 6, 2015 at 5:10 AM, Shivam Desai <notifications@github.com>
wrote:

> Falcon is using different touchscreen driver. I think i can't get this to
> work on falcon
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RenderBroken/msm8974_motox2014_render_kernel/commit/7224f226489f32ae654166e9533e7d18f30af0eb#commitcomment-11062779>
> .
>


It's hard to believe you can't achieve the same by using something else that is not gulp related, but whatever.


Fix sphinx markup for file paths?


This is particularly wonky; the DeleteHandler expects a module with a class called StartHandler, so I used a class as a substitute for a separate module.


Sphinx markup?


Re 1. Obviously links masking and client-side role checking it's the same level of insecurity unless we check permissions in given actions (let's hope we do it). Although, I agree that links generation and server-side roles checking is just handy and simplifies a few things in React. It doesn't hurt for sure if we include them (and mask when can't be seen). We can always provide alternative way and export links somewhere + provide info about user, these approaches won't be conflicting.

BTW, I would need to get some info about user client-side anyway. I was thinking about exporting `currentUser` info.  We could add it for upcoming Portal API, e.g.:
```
Portal.currentUser.isAnonymous();
Portal.currentUser.isTeacher();
Portal.assignInvestigationToClass(<invId>);
Portal.assignActivityToCollection(<actId>);
// etc.
```

Re 2, 3 - Sure, I see your motivation. Although long-term I would lean towards changing it and moving view-logic to React.

Re translation - I don't think we need to use React at all. We can use the same approach as LARA:
https://github.com/concord-consortium/lara/blob/master/app/assets/javascripts/image_question_drawing_tool.js.coffee#L144
There is globally available function `t()`. It works the same as in Rails views and it's using the same lang definitions. So, it's really simple and works quite well. I guess it's some gem or even part of Rails, not sure at the moment.


validate this, and change this to ajax submit in deliverable 2


What is this supposed to be doing? Is  Coverity's just flagged it up as useless. If its meant to clear the open list then the easiest way of doing it is `m_OpenList = std::priority_queue<cPathCell *,  std::vector<cPathCell *>,  compareHeuristics>{};` Yes its nasty but there isn't an easy way to clear a queue.


Perhaps make a note that packages often have bad interactions with each other and lead to instability of the app.


Well, [imagemin](https://github.com/imagemin/imagemin) is making use of vinyl files which is the underlying file system for gulp.


Left a few comments!


I don't know if this was related to my changes or not (probably has to do with adding FakeAuthEntitys to the sources). The etag set here was persistent and was causing calls to get_activities_response to mismatch the expected call slightly.


There is no package available for pdftables


@snarfed the functional code changes here were pretty minimal but the machinations for testing could use a once-over if you don't mind :)


Then maybe add a TODO in the file. Minor thing, though.


I believe that was true in older versions of the compiler but I think we changed it to not renaming properties from record types in the externs a while back.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/fc4b7398397146360980c1c1078b2e26a4fa1195/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/fc4b7398397146360980c1c1078b2e26a4fa1195/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/fc4b7398397146360980c1c1078b2e26a4fa1195/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/fc4b7398397146360980c1c1078b2e26a4fa1195/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/fc4b7398397146360980c1c1078b2e26a4fa1195/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


You're right, this was avoiding the previously-fixed IMT cache bug. I had a few changes like this that I rebased out. I think I'd assumed this commit was fixing something else. I'm removing this commit.


Diana - I just fixed in.


Minor, but if ` isFunction(obj.hasOwnProperty)` doesn't have any performance implications, I find it more readable :)


@MatrixFrog We did. Many of the interfaces in the externs could now actually be record types.


This should be in `styles/mixins.less` and @darrenmason uses the same thing in the learning guide.


Minor again, but if ` isObject(value)` doesn't have any performance implications, I find it more readable :)


Load (and also Save) needs doxygen documentation.

Also, it seems useful to merge both commits to me


Nice


test


@wmcgrane The comments are already in the MIL-STD-2525D PDF document. I added them because they were missing in the JMSML XML instance files.


I think it should literally be `p:write(gabccode)` since `gabccode` already has the headers in it.


lovely


@smallsun11 just commited the fix for this, the problem is that the new client is a possible duplicate of another user and the dialog alerting that was not being shown. I guess now everything works fix


@abenzzine done with my review. nice work. press on!


Yes, it's meant to clear the open list, but it should *not* free the objects the open list points to, because they were already freed in the for loop.
In other words, everything in the open list is also in the m_Map, and once we clear m_Map, openList will have stale pointers, and it's simply emptied.

Is there anything wrong with that?


As a CTF game platform, ```POST``` with UUID is very good point!


Core functionality != technically required

Sublime Text should still work without the Default package, but quite some functionality will be missing. Not sure about the theme though :/ Will need to think of a better definition because I think that core packages are a worthwhile term to define.


ENV.sh → `ENV.sh`


Agree, nobody should do anything in that folder. We can remove this information.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14596/testReport/) for this commit**


try to line up the comment with the previous line


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1135 of 1135 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Konponketa, hau baino, https://github.com/euskalbar/euskalbar/blob/e0d82a0ed68092de0730eec5dc159dcddf842949/src/chrome/content/dicts.js#L116 lerroko deia aldatzea da.


I fixed this in a later commit as I was going to rewrite these parts anyway.


Instead of computing it in this way, I'd rather see us use a build-tools dep as described at http://maven-java-formatter-plugin.googlecode.com/svn/site/0.3.1/examples.html#Multimodule_Configuration


addresses @smirolo's comment in djaodjin/djaodjin-saas#24.


That's sensible. The problem is that what its actually doing is asking the list __if__ it is empty, and then throwing away the result.


Verbesserung:
statt `idealsEqual( intersect(ma2[1],ma2[2] ), std(radical(I)) );` (=0)
lieber `idealsEqual( intersect(ma2[1],ma2[2], ma2[3]), std(radical(I)) );` (=1)
testen , am besten mit ASSUME


sounds a tad too formal

better:

should be considered read-only containers...


similarly:

and should never be...


Does this false match on any lines with trailing white space after an asterisk? What if I have a line wrap after a multiplication?


@jhoblitt I wanted to `if validate_string($source) { .. }` however `Puppet::Error: validate_string' does not return a value` - how should it be used?


replaced => updated


Is brad eating spheros now?


Does this need to be specific to the give page? Shouldn't it be global for all input-group-addon?


@hadley do you want `ggplot()` instead of `ggplot`, above?


link to data folder is broken, same with features


@tmat It looks better. Thanks!


Suggestion:

If you want to customize files included in .sublime-packages,


Should we change this to utilize variable $state-danger-bg?


Yep!


When Two Packages Have the Same Name...

or somethin like that

The current title is a bit cryptic.


@erxleben `<citation>` needs to be a child of  `<citations>`. This means something like that:

```
  <citations>
        <citation type="doi">10.1093/bioinformatics/btt509</citation>
        <citation type="bibtex">
            @ARTICLE{bgruening_galaxytools,
                Author = {Björn Grüning, Cameron Smith, Torsten Houwaart, Nicola Soranzo, Eric Rasche},
                keywords = {bioinformatics, ngs, galaxy, cheminformatics, rna},
                title = {{Galaxy Tools - A collection of bioinformatics and cheminformatics tools for the Galaxy environment}},
                url = {https://github.com/bgruening/galaxytools}
            }
        </citation>
   </citations>
```


This is turning into a debacle.  Apologies for my git slop.  This was supposed to be submitted as "WDI New York City 2015-05-18 :: Ian Cramer"

I think.


@ssumpf: should fix your issue, please try out - @nfeske, @chelmuth: please review


Do you want to say `group_by()` & `do()` instead of `ddply()`?


Me gusta tu OCD :package:


I recall this didn't actually force the meteriliaztion when doing only localSubtract, safer to use count


`z->pos()` instead of explicitly building a tripoint.


Awesome, thanks for the tips and amazing tool :smile:


If two packages by the same name exist...


Is there any possibility that things other than Storage files are stored in the caches directory, and shouldn't be deleted?  I guess since it's for "Caches" deleting it should be okay.


oopsy, thx


Cool, yeah we weren't sure about that either -- it was a little confusing because count is getting called below (which I suspect explains why this task was going so fast (since it wasn't doing anything)


any files in the :file:`{Packages}` ~~package~~


If we have the capability to detect MSys2 terminals, it still makes sense to restrict it to the platforms where it actually makes sense.

No, seriously, just like in commit messages, where you do not want to bore the reader to death with implementation details and rather paint the bigger picture with a large brush, you want to use names that explain best *what* you want to do, not *how*.

Anyhow, that is the way I want the code to be that I maintain.


Should this rather be Installed Packages?


attribute avatarURL

wasn’t there an URL entity containing the long and short URL?
if so, instead of having avatarURL for an entity, a connection to the URL entity should be made; otherwise, for the suggested attribute make attribute and it’s description more general, since attributes should be reused in several entities, e.g.: attribute URL and description: “URL for any page.”

attribute username

check description “memebr”

attribute Banner
description: “part of carousel”? (sorry just didn’t get this)

entity Post
attribute title -couldn’t we have it optional instead of mandatory since in the universe of forums this situation could exist?

entity Profile
attribute avatarURL - couldn’t we have it optional instead of mandatory since in the universe of forums this situation could exist?

entity Settings
just an idea, not sure wether it makes sense for this situation; since all entities are used in singular form, could we have a number of “setting” entities or does it not make sense?

entity ShortLink
is a shortLink like a short URL? Could we have an entity URL having the complete url and the short one?
attribute function - what is it for in this entity? could we have it as optional?

entity Tag
attribute key optional?

entity Topic
attribute accessControl optional?

Verbs Guideline: “Passive verb forms should be avoided, e.g. _causes_ and not _causedBy_ .”

verb isWinnerOf
rename to wins

entity Collection
(this was the result from a recent discussion with OGIT Board):
We should not have an entity which is too general, like ogit/Set for grouping.
The possibility for an entity which could also have grouping purposes could be allowed for more specific situations.

E.g.: a Service Catalog/Portfolio with Service Offerings in it:

ogit/ITService/Catalog: https://graphit.co/docs/group__httpwwwpurlorgogitITServiceCatalog.html
ogit/ITService/Offering: https://graphit.co/docs/group__httpwwwpurlorgogitITServiceOffering.html

-> so consider creating a more specific entity for grouping if you really need one

verb createdBy
please rename to “ogit/creates” instead
description for this new verb: Indicates if one entity creates another one.
(after the ogit cleanup createdBy will disappear and creates will be it’s equivalent)

verb isRelatedTo
please rename to “ogit/relates” instead
description for this new verb: General relationship indicating that one entity is related to another one.
(after the ogit cleanup isRelatedTo will disappear and relates will be it’s equivalent)

usage of verbs with prepositions:
I’m waiting for feedback from OGIT Board, wether we should avoid this or not
could influence name of respondsTo, subscribesTo


Why no boomering? Without boomering, it will be useless during the day.
In fact, it could have a stronger boomering effect that would require goggles with more environmental protection (the third argument of `add_env_effect` determines difficulty of protecting self from the effect).


@JobV The changelog needs to be adapted.


:moyai:


{#sec:broom}, not (#sec:broom)


I think the last bit above is obvious.


i'm a naughty copy and paste dev it seems


Let's talk about this one. Feels like a philosophical discussion about what the default access level should be for class attributes.


PR would have fired notifications, please remember next time :blush:  I just saw this will test it


I don't get this line. By us?


I think you might have wanted to keep `+ entity.getEyeHeight();` here.


Doesn't read well. Better:

loaded or unloaded


please check feedback here: https://github.com/thechriswalker/OGIT/commit/c95cb20fd2fae117a7f0f624bd2ccc39e6125923
and https://github.com/arago/OGIT/issues/174


This is a minor quibble, but I'd suggest changing your "jollypod" references to something that would represent a common and widely known 3rd party audio aggregator, like "stitcher", "spotify" or "itunes". A new developer reading this test will have a better idea of what `consumer` is used for if we use a popular service as a test value.


~~Firstly~~ if you installed a package with a package manager,


it is safest to first `disable <#disabling-packages>`_ the package


`blog-btn btn btn--active` по бэму то будет так: `btn blog-content__btn blog-content__btn--active`.

Эта же кнопка – элемент блока `.blog-content`?


An alternative to this statement would be:

result = counter[['datetime', 'result']].to_dict()


and then delete it from the disk


This gave me a segmentation fault error :) Compile commands and errors with messages are way longer than 1024 characters, it should be something like `50000` if not more


The steps aren't in order:

- disable
- close st
- delete


Tiny style note I picked up not too long ago: Putting a comma at the end of the last item in a hash like this means that next time we add something, you won't get a diff like the podcast one, where the only change is the comma. These days I try to be good about adding that trailing comma whenever I'm making updates.


I think using `ggplot()` instead of `qplot()` would make it more clear that `fullrange` is an argument to `stat_smooth()`


why would you want to enable a non-existing package?


This is mostly a move-around and trying to follow best practices w/ const.

I'm not hot and bothered about the type.


Usually,


Got it!


If you


Thanks! Changed the tabs to spaces.


Nice catch!


It's more for checked-mode sanity checking. Since this array is assigned to, it's nice to have the reified type to get runtime errors.


I would actually recommend just replacing these lifecycle methods with a simple method like this

```
module.exports {
  getRouteParams: function () {
      return JSON.parse(this.android.getRouteParams());
   }
}
```


Yup. Worth a bug.


@springmeyer why is that? is the default likely to change?


Copyright should be 2015, which is the creation date


@jlucerond that's a big number! what happens if the user's search is `what do people think of bloc.io`?


Needs semi-colon at the end of this line, and then the next two.


`resize` – нам ни о чём толком не говорит. Лучше что-нибудь типа `inner-page` (для внутренних страниц). Ну или хотя бы что-нибудь типа `make-smaller`. А то сама же запутаешься потом)


@jlucerond done with my review. nice. press on!


@hadley do you want ggplot2 instead of `ggplot`?


Thanks for this. Besides the missing sem-colons, awesome job!


Maybe less authoritative and more informative:

Shipped Packages will be reinstated on every Sublime Text update.
If you want' to disable any of them, put them in in the ignored_packages
list instead of deleting them.

Or something like that.


raju chang it


atomic -> read-only


While you share such include path  between several subdirs, it can be moved to the root CMake file.


I double checked this to make sure, but it works fine. The idea is that as long as there is no spaces and at least 1 dot, do a normal URL Search. If there is 1 space or no dots, then it creates a google search.


the actual archive file?


I vaguely remember the reason for the change being around the change we made to the filter on envelopes we made earlier, in `Herder`. Without the `return`, the assert crashes during the boot sequence like this:
```
	stellar-core.exe!stellar::Slot::bumpToBallot(const stellar::SCPBallot & ballot) Line 235	C++
 	stellar-core.exe!stellar::Slot::prepareValue(const xdr::xvector<unsigned char,4294967292> & value, bool forceBump) Line 224	C++
 	stellar-core.exe!stellar::SCP::prepareValue(const unsigned __int64 & slotIndex, const xdr::xvector<unsigned char,4294967292> & value, bool forceBump) Line 43	C++
 	stellar-core.exe!stellar::HerderImpl::triggerNextLedger(unsigned int ledgerSeqToTrigger) Line 1098	C++
 	stellar-core.exe!stellar::HerderImpl::bootstrap() Line 152	C++
 	stellar-core.exe!stellar::ApplicationImpl::start::__l2::<lambda>(const std::error_code & ec) Line 219	C++
 	[External Code]
 	stellar-core.exe!stellar::LedgerManagerImpl::loadLastKnownLedger::__l7::<lambda>(const std::error_code & ec) Line 208	C++
 	stellar-core.exe!stellar::LedgerManagerImpl::loadLastKnownLedger(std::function<void __cdecl(std::error_code const &)> handler) Line 222	C++
 	stellar-core.exe!stellar::ApplicationImpl::start() Line 224	C++
 	stellar-core.exe!____C_A_T_C_H____T_E_S_T____473() Line 509	C++
```

I am not positive that that `return` is the proper fix though.


Did you mean `m_OpenList = std::priority_queue<cPathCell *, std::vector<cPathCell *>, compareHeuristics>()`


while *src* is common include path for several directories, it can be moved to root path.


repeated word intended?


тоже самое с vary: что меняется – непонятно)


over any identically named file


@mkwork
I'm on the way. Thx


Well, http://www.unicode.org/faq/private_use.html says that ``0x0010f7ff`` and ``0x0010f7fd`` are not characters, so should not be generated as random characters. Maybe there are more traps.


@jlucerond it's those 'the user typed what?' things that we usually don't expect and never tested for. thanks for proving it works. good good.


https://github.com/crowbar/barclamp-crowbar/pull/1251#discussion_r29236328 and https://github.com/crowbar/barclamp-crowbar/pull/1251#discussion_r29236357


other modules => submodules?


make these a list?


:+1:   looks good!  thanks for making it easy to follow


not sure I get this. are we talking about submodules in override packages?


@madhuracj It was removed because we didn't wanted browser's native validation for `min` and `max` attributes to get triggered and instead have our validations done because different browsers had different ways of highlighting those errors and we wanted to be consistent with giving feedback to user. (https://sourceforge.net/p/phpmyadmin/mailman/message/32661680/)


...a published...


Since you are always overriding entire files,


:heart:


oi Victor

O conteúdo de graphic_objects veio errado. Quando puder poderiam corrigir?

Obrigado


e .g. => for example,


Makes sense. I was careful to make the default a very specialized thing and all other instances to go to a search result. But that took me a while to figure out and had to write it down to be sure.


Resolved itself, I'd prefer not to remove http2 support in curl.


OK, I think I'm done now! Thanks!


mezizgebi am commitis gamo


Sure. I pretty much subscribe to this: http://c2.com/cgi/wiki?AccessorsAreEvil  but don't necessarily go as far as this: http://www.yegor256.com/2014/09/16/getters-and-setters-are-evil.html


uh, right, then I don't know


А разве кнопка-это не всегда просто блок? Отдельный.


nit: indentation


boolean flags are generally poor code style, especially in this case where having both false or both true are error conditions.  Also, in java variable names start with a lowercase letter.


@hadley here you use `**broom**`, but that doesn't appear to be consistent with your references to ggplot2 (no bolding)...


Плохо у меня с глаголами для описания состояния


@wkennington sure, as long as the sources are fetchable :) Perhaps it should be added to nixos.org tarballs. @edolstra ?


Merging the new code


No, it says they are perfectly valid code points... so Char() should allow them.  There are 66 characters that are considered “non character” code points.

It just needs to disallow 0xd800-0xdfff, and >0x10ffff.

>Q: Are noncharacters invalid in Unicode strings and UTFs?
>
>A: Absolutely not. Noncharacters do not cause a Unicode string to be ill-formed in any UTF. This can be seen explicitly in the table above, where every noncharacter code point has a well-formed representation in UTF-32, in UTF-16, and in UTF-8. An implementation which converts noncharacter code points between one UTF representation and another must preserve these values correctly. The fact that they are called "noncharacters" and are not intended for open interchange does not mean that they are somehow illegal or invalid code points which make strings containing them invalid.


Ночью поправлю


depends. do they have a lot of protein?  :muscle: :meat_on_bone:


this should be replaced with ```instanceof```


Why can't we set the storage here ? Before we launch the app ?


good catch.
i've create a bug to remind myself: https://github.com/kritzikratzi/runtimeCPPDraw/issues/1


these hard-coded values shouldn't be in here


True, but from the POV of a user, if ST starts up but it's crippled and in an unusable state, it's effectively broken, so the core packages are required to be present for any practical use of ST. I do like the term for what it describes, though.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14599/testReport/) for this commit**


The cookie is already encrypted with the secret, which can be changed via an environment variable. express-session explicitly says MemoryStore leaks memory and is not supposed to be use in a production environment.


I still don't get why `list(range())` is preferred over `range()` for python3 compatibility. As of I know, both works and with `%%timeit` ipython magic for over skeleton iterations, I got
```python
In [1]: %%timeit
   ...: for i in list(range(100)):
   ...:         pass

100000 loops, best of 3: 2.22 µs per loop

In [2]: %%timeit
   ...: for i in range(100):
   ...:         pass

1000000 loops, best of 3: 1.41 µs per loop
```


xmlGuardar deberia usar rutaXml... yo no hice el cargar asi que ni lo habia visto.

Porqué está comentado EscribirArchivo_Apertura?


new lines/tabs perhaps?


+# ZTE-V5s


style consistency. please group cfssl packages and standard packages in separate blocks


WTF? ventas.js | VentasController.java ... Le cambian el nombre a mis funciones javascript !!


@chebee7i Comments?
I recall https://github.com/networkx/networkx/issues/1479#issuecomment-95956760


Hey friends, I noticed my Google Cloud logs are all default severity and I think this commit might fix it — do you happen to know when this will be available in the default google-fluentd-install.sh install?


You told me before you were keeping removal of callback separate from other changes to help with merging - I would expect the removal commit to only delete unused code.


Re add msenderfaction.


I did not say that they are not codepoints. Anyway, what to choose depends entirely on if you want random codepoints or random characters. For example ``nan`` is not a number, and is a completely valid contents of a Float64 and still not a reasonable return value for a function giving random floating point numbers.


this doesn't appear to be used.


For some reason nginx went and choked on the backend storage not being available for a couple minutes. Otherwise it should be pretty reliable and then will be mirrored to nixos.org once a build is pushed. But yeah, I see no reason why this couldn't be added to tarballs. It would be nice if there was an interface to do so.


this is a premature optimization - I don't know if this is the only thing we'd need to do if we have a lot of slots


I blame obamacare


I forgot to mention, the biggest problem in this instance is that we can't do https so pulling from github and the likes won't work for this fetchurl. Otherwise this would just pull from the github release.


The `travis encrypt` command is responsible for the unrelated changes.


Didn't we discuss adding a `pretty=TRUE` argument to colorBin? Did you decide against that or was it an oversight? (Or am I misremembering)


Sorry i did not think about all these complex scenarios while making the change....for me i wanted to see the snapshot of my last attack  to my cellphone and this achieved by making this change....since i m not able to upload jpeg in this message i m not able to share with u now....as long as u can help me achieve this meeting all the above mentioned scenarios i m more than happy to incorporate ur change....hope this clarifies PS: i m a beginner in autoit taking my baby steps so pls bear with me if u see any mistakes in following the standards.....


True not false


Unfortunately this completely breaks my WIP branch which upgrades mongodb to its latest version. Also are the scores already stored on the server transferred?


nodeID: then let's fix the actual problem instead of scattering the code with this: this bloats production logs.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.85](http://teamcity.monogame.net/viewLog.html?buildId=7023&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Also, let's keep this PR focused on prefetching - any change done outside is just more conflicts to resolve at this point and I don't want to discuss them now anyways


huh interesting indeed. did it fail without your changes? i wonder if this is related to #387.


Index must be explicit


The cookie only stores an encrypted session id which the server uses to find the session.

Something like https://github.com/expressjs/cookie-session is what we want here.


At least on indigo, gazebo_ros_p3d does not like using /world either:

[ERROR] [1430931765.988674393, 0.740000000]: gazebo_ros_p3d plugin: frameName: /world does not exist, will not publish pose


yay naming conventions \o/


I think I got the point. `list(range())` is used in case a list is needed immediately. `range()` does not generate a list in python 3.


I didn't spot it. Its the Coverity static analyzer. Theres a link in the readme.


However, the documentation of the code itself says the following: >valid Char codepoint range.
According to the Unicode standard, Julia's implementation of is_valid_char is itself incorrect.
I'll have to create an issue for that...


Public for reasons? Misleading/Overcomplicated name, setFrame would do, wouldn't it?


This is true.
On 6 May 2015 11:39, "Chung-chieh Shan" <notifications@github.com> wrote:

> Rob, as we discussed yesterday, you need to normalize the distribution on
> lines 67 through 70 (but not 66).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/c682523f40a09c06269d83cd372f07b048614f07#commitcomment-11068246>
> .
>


This seems like it should be in pkg/conversion or a sub package of it, not in util.


Re


Just a minor issue, commit description is wrong, of course.
PSQT data is file-symmetric, and not rank-symmetric.
SQ_A4 != SQ_A5 but SQ_A4 == SQ_H4.


This is looking at form parameters as well?


looks like the only way parts could not be a dict is if we gave `encode_state_parameter` a list or other non-dict object originally, right? and i think we never do, right? should we maybe assert it's a dict in `encode/decode` and drop this check?


Why did you move `Join the chat` part?


True not false


Yes, it would be better to fix the function in `utf8proc` which is called by `is_valid_char`.


nit: why `str`?


I agree. It makes the name of the function ``is_valid_char`` a bit unfortunate though.


this should probably be a private method, and it might behave strange if we give it the same name as the User.accepted_terms attribute, so maybe something like check_if_accepted_terms or whatever.


I see an `extern "C" {` on line 40 of dataXfer.h, which should apply to this function. Am I missing something?


That was quick.

Thanks a lot!!

Cheers
Michael

> On 06.05.2015, at 15:24, Anthony Sterling <notifications@github.com> wrote:
>
> Fix incorrect sha256 for Komodo Edit
>
> Correct hash is '39dc064cead52b3de0cab8f499867d26e1e8feeeca91488c00cd72ceb9d31089', not `a5b6960c4d6d791cfa72e9dfc9e94aa53f326a808bd012c6e16ec23b15356545` -- thanks @teacher4711.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/anthonysterling/homebrew-cask/commit/94115abc78e91e023af1bb99cbc4e29279cc138d


Isso de acordo com o manual para geração de boletos para o banco Bradesco, documento de versão 8 pag.21. segue link para o acompanhamento:
http://www.bradesco.com.br/portal/PDF/pessoajuridica/solucoes-integradas/outros/layout-de-arquivo/cobranca/4008-524-0121-08-layout-cobranca-versao-portugues.pdf


extra end


yes


@jakebolewski No, actually it would be better to do it the real Julian way, and just do it in Julia (as I've learned recently!) ;-)


ok


I'm sincerely sorry! But I do believe this is the right choice. LevelDB is simple (it's a plain key value store with a clean API, and its being embedded means there's one less dependency to install and keep running) and solid (more so than MongoDB).

Existing scores haven't been moved yet, but it should be easy to do when the time comes.


Did you move the images from /assets/images to /public/images or were they duplicated?


What gives this update?


maybe make this the entire delete URL?


ok, switched back to re.search


Эта часть общая для обоих кейсов, стоит ее вынести наружу.

В идеале стоит вообще работать с `List<String>`, а не `String[]` до самого последнего момента, т.е. примерно до [этого](https://github.com/LeKaitoW/rdo-xtext/commit/fcff847e537afd48fa3e462b2093ab136df7b46d#diff-a1b0a117c9cc7db7c639c33d51c7b29aR98). Тогда будет минимум повторяющихся проверок на `null`.


Отличная идея, переписал с использованием виртуального атрибута


nice, thanks! overall this structure lgtm, only nits. i'll look at the test parts soon.


Does unless start a block?


While I haven't tried this yet, it looks pretty solid.


Make index explicit


written**n**umber
typo?


not used to this syntax... what is it really doing there with the :default?


1) I guess I don't understand: map.erase is supposed to first remove the element from the map and then delete it. So this should not make any difference.
2) keep the fix surgical regardless - no refactoring or extra logging as part of this PR (same reason I gave earlier)


可以试一下取消对该 repo 的 watch。

repo:
https://github.com/goagent/goagent/commit/98eca96b72bad5bc130c52aa8ef360651b429221#commitcomment-11066917 <https://github.com/goagent/goagent/commit/98eca96b72bad5bc130c52aa8ef360651b429221#commitcomment-11066917>

在这个 repo: 上点击 Unwatch

应该就不会再收到邮件了。

> On May 6, 2015, at 22:37, biweijie751107089 <notifications@github.com> wrote:
>
> 垃圾邮件
>
>
>
>
>
> 发件人: mrhsuyen [mailto:notifications@github.com]
> 发送时间: 2015年5月6日 22:35
> 收件人: goagent/goagent
> 主题: Re: [goagent] bugfix (98eca96)
>
>
>
> 请问，如何屏蔽你们的邮件
>
> 发自我的 iPhone
>
> > 在 2015年5月6日，08:41，sparksustc <notifications@github.com <mailto:notifications@github.com> > 写道：
> >
> > 用新的 proxylib.py 替换旧版本的，运行goagent提示：syntax error。
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
>
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/goagent/goagent/commit/98eca96b72bad5bc130c52aa8ef360651b429221#commitcomment-11066823> . <https://github.com/notifications/beacon/AKMseqQXKl105bOBO0GcZHW6dq2W69Yxks5oGh4SgaJpZM4EQ0jJ.gif>
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/goagent/goagent/commit/98eca96b72bad5bc130c52aa8ef360651b429221#commitcomment-11066917>.
>


(I can help merge this update into your WIP branch if you'd like.)


Oh sorry, the indenting is just off. I didn't realize that was ending the unless. Actually I would probably change it from unless !current_user.accepted_terms to if current_user.accepted_terms just to avoid double negatives.


@andy-armstrong The len(download_links) == 1 confuses me-- I thought you wanted to be robust to multiple reports being present.

I'm also confused about this assertion in general. Does it have to be within an if? Can you first assert the length of download_links, then assert that report_name is in  download_links.attrs('href')[0]? I don't understand the comparison between [download_links.attrs('href')[0]] and download_links.attrs('href').


import * vindt checkstyle niet leuk


final


We should use .apply directly in the string. e.g., func = 'someFunction.apply(this, element)';


@Diego-F-Aguirre self.images is an `NSArray` - `removeObjectAtIndex:` is not a valid for that object type. You'll need to go to the DataSource class and modify the mediaItems - make it `NSMutableArray` then you can remove the item from `[DataSource sharedInstance].mediaItems` on line 119.


Waarom een nieuwe File aanmaken? Kan je niet net zo goed this returnen?


so for readability:

def check_terms
  if current_user.accepted_terms
    redirect_to root_path
  end

end


Можно. Для этого просто запусти `self.put_snake(...)`


Probably want to lose this `print` statement. (obviously, I suppose)


remove useless enter


spelling error to fix here


In the Position class, there is no way to get a Position without giving X -Y coordinates. Is there a way to pass a ChessPiece object to a Position method that returns that piece's location?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1135 of 1135 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Это значит лишь то, что их нужно правильно передать тем, кому требуется)


But dataXfer.h isn't included in this file, so the compiler will generate a C++-linked `outChar`, which the linker then complains about.


hash rocket - change it into new syntax so:
notice: 'Signed up!'


Explicit index


remove it (and stop using scaffold)


please use kapi.NamespaceNone so its easier to search for in future.


old hash rocket syntax


Not sure what you mean by form parameters... this is a GET request that will be upgraded. But in any case, any params that were already added to the request object by calling code are preserved.


kapi.NamespaceNone


change html.erb files into haml files


This was an accident, I think.  Remove this from the commit.


another file generated by scaffold that you don't need


Ah, I see. Thanks!


This is the only way to manually serialize that works that I found.


1640-AddHVACPart1 (kbenne) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


oo, much cleaner than mines


Why this empty space?


From your _.depend_ file it's rather clear you did not do your homework


This should be: Allow to customize web services jQuery ajax calls : new “ajax-args” js filter


Я имел в виду, что если змея -- это набор точек, то можно узнавать её длину через длину этого списка.

А создание переменной съеденных яблок - тоже правильный способ. Но не нужно завязываться на то, что длина змеи это яблоки + 1, иначе код не будет достаточно гибким для изменения


kapi.NamespaceNone

any reason why you can't just pass a kapi.NewContext() directly.


yet again, _.depend_ file says it all


Makes sense... wasn't really sure where to put it. Will move it.


Yes, I'm going to add assertions here that will make it clear.


No. This a utility class. It does not doing anything logic related.


kapi.NamespaceNone || just pass kapi.NewContext()


Maybe in `crowbar_framework/lib/`?  Not sure it is associated to any existing class.


Oops, I think there is something wrong here.


This can now be an int


good idea to expose them like this :+1:


just kapi.NewContext()


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.85](http://teamcity.monogame.net/viewLog.html?buildId=7023&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:19:07


So if you have a list of pieces, there is no way to get location of the piece? That sounds silly.


Something's wrong here too I guess (check the display: https://github.com/uncatcrea/wp-appkit/blob/f6e1e5be16eabe7711f4953caa75856b597ee244/CHANGELOG.md).


@fotinakis  - I am planning to do a full release this week, but in the interim I just pushed a new gem version [0.2.3](https://rubygems.org/gems/fluent-plugin-google-cloud) [(release notes)](https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/releases/tag/v0.2.3); if you'd like to give that a try you can run (as root):

/opt/google-fluentd/embedded/bin/gem update fluent-plugin-google-cloud
service google-fluentd restart


NOTE2: I commented out code for LCA1 - feel free to uncomment for further testing


1. XYplorer.tmLanguage:
	- String scope is too greedy, "$Var" will not recognize the $Var as variable. Pls consider revert back to: <string>["';]</string> OR maybe this can be a solution http://www.sublimetext.com/docs/3/syntax.html (actually, I prefer YAML for easier reading).
	- meta.class.scriptcaption.xys: Remove this pls because
		- Greedy string (see above)
		- "meta.class" is a special scope, which auto-add to symbol list
	- comment.line.xys: URL detection is necessary for such script: goto http://www.xyplorer.com
	- Everything with "command" nature should have the same color, therefore,
		- Pls revert back constant.CommandID.xys → entity.name.function.CommandID.xys
		- Change UDF.xys → entity.name.function.UDF.xys
2. contextual_help_xys.py
	- My plan would head for less obstrusiveness, i.e: popup a tooltip http://www.sublimetext.com/forum/viewtopic.php?f=2&t=17610 (or 1-line statusbar info) on function syntax with hyperlink chm help file. But that's still idea.
3. XYplorer.sublime-settings
	- "extensions":["xys","xyi","inc"],  //Add "inc", else .inc will be defaulted to HTML and symbols **will NOT be indexed**
	- "default_encoding": I chose "UTF-16 LE with BOM" because
		- No more "UTF-8 with vs without BOM" hassle (Try move to a new computer with only Notepad available to edit .xys → it will save to UTF-8 with BOM → unreadable to XYplorer)
		- 16-LE BOM is defaulted by writefile(), much easier for a script to edit itself/other .xys files.
4. feselitems.sublime-snippet
	- You removed this? Uhm, my most-used snippet.
5. XYplorer.sublime-completions
	- Line 196 (enumshellfolderitems) lack ending comma, corrupting the whole file
	- // Native Variables: You deleted raw triggers such as "<cc_item>" this make typing <cc not poping out suggestions.
6. Symbols_Hide.tmPreferences: No need for this file because:
	- Only scopes with "meta.class" (or scopes specified as indexed symbol in .tmPreferences) are indexed. If you remove meta.class.scriptcaption.xys as in comment 1 above, you already have to garbage in IndexedSymbolList
	- Symbol are always scanned for upon file opeing, showInSymbolList=0 just hide them from Ctrl+G, it does not speedup file opening at all.
7. README.md
	- Should mention that it activate for .inc files (see comment 3 above)


:+1:  ;)


Why are you working with the list?
What are you trying to do?


这是一个测试项目，谢谢！


Thank you


I'm glad I've been helpful :wink:


why use MetaFake here?  MetaNamespaceIndexFunc works well even if object has no namespace.


@hadley I see you used `knitr::kable()` above...do you want to stick with **xtable** for cases where we need to reference the table? Or maybe a combination of `knitr::kable()` and **captioner**?


yep


> not used to this syntax... what is it really doing there with the :default?

`PolicyBinding.Name` = `Policy.Namespace:Policy.Name`.  When you're referencing a `ClusterPolicy`, the namespace is empty.


Woops


Thinking about it, do we want that a sequence of random unicode chars from this function form valid unicode? Then we should exclude combining characters.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14601/testReport/) for this commit**


rax retry tests


can't guarantee that it will be trivially inlined, so I prefer this approach --- it's more explicit


In the GameLogic class, in order to get strength, you need to get the pieces. The logical way(at least I think so) is to use the board's method of getListOfPieces(), since GameLogic shouldn't be dealing the array that belongs to board. All it cares about it getting all the pieces on the board. How it is stored doesn't matter to GameLogic.


just so that I know: is `message.text` always `cp-message-received` with this message type ?


> any reason why you can't just pass a kapi.NewContext() directly.

Less clarity of intent.  I don't think that missing namespace should be the same as empty namespace.  Sort of like null and "" are different.


MIN_VERSION_base is a macro generated by Cabal.   If you run ghci against this modular, it will fail because ghci cannot see this macro. I put the reason in the commit comment.


You may have to refactor that method now that we are splitting up the implementation from the logic.
Also, you can add to Board class if you need to.


It was cleaned up in a late change.


just a comment that you use calledWithMatch instead of calledWith now -- calledWithMatch is a little less precise (for objects it merely checks whether the specified properties are present and equals, but doesn't check extra properties). Is it what you want here?


On the other hand, LevelDB seems to be young (< 90 commits), and there has been no commits since last year. It does look fast, and I understand that it's made in Googleplex, but I'm not sure if that is the best choice long-term.

Also, back to the session store issue, before this commit sessions are stored in disk, but after this commit the sessions are stored in memory and do not persist over restarts.


same for other changes below of course.


@mr-salty Perfect, I'll give it a try—thanks!


@ensirius https://gradle.org/docs/current/release-notes


It seems Norman still want to be on the list.


Here's what I was trying to do, which turned out to be tricky. :-) I wanted to have a single diff failure if there was any problem found. However, if I asserted on the length of the list then it would fail saying 2 != 1 with no details. Similarly, I wanted to include the report name, but I didn't have the full name, so I couldn't do a diff as is. So I did the two tests, and if either one failed, I used assertEquals on two arrays, so that we'd get a clean diff of the failure.

I probably should add a comment to describe what I was trying to do here. However, let me know if you think I should implement it in a different way.


Would a for 1..10 be more acceptable? It normally does only one iteration.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14602/testReport/) for this commit**


I see you haven't changed this either -- do you think it does not belong to this patch? (I'm fine with it as this is not the goal, just tell me :) ). Previous comment was: you can simply assert in the handler and finish the promise chain with `.then(done, done)`. For example:

```javascript
test('test', function(done) {
  doSomething().then(() => {
    // assert stuff
  }).then(done, done);
});
```

If the assertion fails, an exception will be thrown, the promise will be rejected, and "done" will be called with the error.


I like this style because the indentation is smaller.


Nu e corect ce scrie în mesaj.


Hi wlbragg,

I've modified the files with the
> - /fdm/jsbsim/wing-damage/left-wing = (0 to 1, double)
- /fdm/jsbsim/wing-damage/right-wing = (0 to 1, double)

Functionning (physics.nas):
- v > 158 kt and flight asymmetry ==> one wing damaged
- v > 180 kt and flight asymmetry ==> one wing broken
- v > 200 kt ==> both wings broken
- g > 4.4 ==> one wing damaged
- g > 5.5 ==> one wing broken
- g > 6.6 ==> both wings broken.

Only implemented with the c172p-fdm-dany93.xml FDM.

I've done this by deleting no lines from your physics.nas file (by conditions on the FDM, or a few commented lines). Your current FDM should still work with these new files (of course with the previous functionning). I must admit that I have not tested this.
The physics.nas is in an experimental version, a bit messy. We (I) will have to clean it if you are fine with this, if you accept it.
Of course, this version is a proposal for the principles, it can (has to be) improved and the values fiddled.

Three files are involved:
- c172p-detailed-set.xml,
- c172p-fdm-dany93.xml
- physics.nas

I do not know the best way to make them available for you. My current problem is that I'm stuck with git because of my pending merge request https://github.com/Juanvvc/c172p-detailed/pull/143
(I think onox will unlock this soon).
Anyway, even with github, I would not know how to do this without "polluting" my branch with files that I'm not sure they will be used (open a new branch under dany93 on which you could download ?).

The easier is that I upload these three files on a webserver.
C172p-damage-dany-20150506.7z
http://www.mediafire.com/download/x54cj4zzqtzkpeg/C172p-damage-dany-20150506.7z


so a cluster policy binding can reference a non cluster policy?  would have thought that use case went away.


Thanks. I will try adding to the Board class.


I don't like hardcoding assembly names. This is asking for trouble.


Thank you.

-----Original Message-----
From: Kjell Magne Fauske [mailto:notifications@github.com]
Sent: Wednesday, May 06, 2015 12:18 PM
To: Esri/joint-military-symbology-xml
Cc: McGrane, William M CIV DISA BDC (US)
Subject: Re: [joint-military-symbology-xml] Add OWN_SHIP and FUSED_TRACK remarks (dadb421)

@wmcgrane <https://github.com/wmcgrane>  The comments are already in the MIL-STD-2525D PDF document. I added them because they were missing in the JMSML XML instance files.

—
Reply to this email directly or view it on GitHub <https://github.com/Esri/joint-military-symbology-xml/commit/dadb4216d940f7f3d1db61696dc70f676961fb2a#commitcomment-11069085> . <https://github.com/notifications/beacon/AI5TbWgRTUFN7rlmzFG7Bn2Pfjk6tO81ks5oGjYkgaJpZM4ERYqi.gif>


@Ported
If only you can fill the issue with json example then I can take a look and check if we can refactor this max-width to something more flexible


ce faci dacă `item` e `null`?


#3 Resuelto en este commit


You could avoid the cast by using `collect` here.


It seems there is a special versioning requirement for Hoopl. I'm still digesting it.


Note that this only works when you use the $cache_dir parameter. The wget command does not offer a facility to set the mode on its target file. The puppet module already includes a file {} resource to facilitate copying the file from the cache_dir to the final destination, so this simple change allows that mechanism to supply the file mode.


Several parameters are missing documentation here (e.g. readLengths)


V-am arătat cum s-ar implementa un enumerator ca să știți ce se întîmplă, dar în viața de zi cu zi se folosește `yield`.


@bpolster Trying to figure out why the blCustomPersistenceHandlers collection was removed from bl-admin-applicationContext.xml. This seems to make those persistence handler never be registered (and in the end break client implementations that may have overridden any of them with custom functionality). Was this a mistake?


Hmm, that was perfectly well documented and I wrote it in the first place. Must've been a Friday. Will revert.


'DEFAULT' is misspelled here.


synchronizeClusterPolicies


sorry, that was not my proposal and I think this change is not equivalent (I don't know why no test is failing with this change...).

My proposal was to replace:
```javascript
  return {
    then: function(resolve) {
      return Promise.resolve({
        addEventListener: (type, cb) => self.mEvents[type] = cb
      });
    }
  };
```
With
```
  return Promise.resolve({
    addEventListener: (type, cb) => self.mEvents[type] = cb
  });
```

I think this is equivalent to the previous code unless I miss something.


Ah, sorry, I think you mentioned that but I forgot it. I'll add `pretty = TRUE` in a minute.


Nu e eficient să mărești doar cu cîte un element. Folosește ideea din implementarea inițială,, unde array-ul se dubla de fiecare dată.


>I'll write more about why just a 20MB increase and no increase-over-time in a blog post. In short, it is impossible to predict the future, and the fear is that increases in network bandwidth to the home and/or cpu power increases may plateau sometime in the next couple of years.

Why not increase over time depending on the average blocksize? Say current size limit is maximum(previous limit, average of last N blocks*(1+X)) for reasonable values of N and X. That would make the size only increase when close to utilization. (It seems simpler to actually only retarget every group of blocks, perhaps similar to the difficulty changes.) Set it up that the maximum possible increase if every block is full is capped at the values you expect bandwidth to be able to handle, and if bandwidth doesn't increase fast enough, less larger blocks will propagate and the blocksize will increase slower.


It won't work. There is no way to distinguish between one black pawn and other black pawn


synchronizeClusterPolicy...


> so a cluster policy binding can reference a non cluster policy?

Removing the selector for it.  The validation could be tighter I guess.


Saving signature is a large object is a little silly. Gzipping a small string probably makes it larger, and needing 2 statements to retrieve it is just wrong. But I guess I was trying to keep it in the same paradigm as the search directory itself.


Nu există restricția asta, dacă vreau să pun `null` sau 0 în listă nu trebuie să mă oprești.


hello


I would prefer we eliminate the concept of "master" altogether in favor of just clusterBindingResourceVersion and clusterPolicyResourceVersion since 12 mos from now no one will remember there was a master namespace.


but you changed only the body of the "then" function, which I think changes how the original code behaved.


Handle `Seq[TreeNode]` in treenode parameters.


Din punct de vedere al complexității, 5 sau 20 e tot aia. Dacă crești cu o cantitate constantă, e liniar, dacă dublezi dimensiunea de fiecare dată e logaritmic.


Any progress on permament fix?


clusterPolicies, err := ac.clusterPolicy...


clusterPolicyBindings, err :=


Hi Shailesh,

Please contact me. I need the document that I sent to all of you, as my system crashed and I did not have any backup of it.
mail id: divya_bhushan@hotmail.com

Thanks,.
Divya Bhushan ( Git Trainer )


this change unhid a function.   gSplice is needed to use postorder_dfs with "Graph n C C", which is the typical graph shape of a function. postorder_dfs was exposed, but gSplice was not.  Without gSplice, nobody can use postorder_dfs unless you explicitly split a "Graph n C C" to "Graph n C O" and "Graph n O C".   I'm till experimenting what is the best way to use Graph.hs.


Let's try to do test coverage in a more meaningful way.
First, grab/modify a config from config/config_test.go

var validMinimalLocalConfig = `
{
	"signing": {
		"default": {
			"usages": ["digital signature", "email protection"],
			"expiry": "1h"
		}
	}
}`

And load that string into a valid config.Config, you can find out how to do that by reading config/config_test.go

Next, get a valid root config
h: = map[string]string{
"key-file" : "testdata/ca.key"
"cert-file" : "testdata/ca.pem"
}
r := &Root {
Config: h,
ForceRemote: false
}

Now, prepare the ca cert and key files, create them under "signer/universal/testdata/", you can grab those files in bundler/testdata/

Finally, use the Root instance and config.Config instance to start a universal signer.

That should give you a decent code coverage of this package. And you can explore more to enable "ForceRemote"


Păi și dacă vreau să răspund la întrebarea dacă lista conține `null`?


Maybe this could need some more information:

(1) Python wheels can be built with 'python setup.py bdist_wheel'

(2) When installing the Python wheel (using 'sudo pip install <wheelfile>'), all additional data (documentation, examples and tools) will be copied into the following folder: {sys.prefix}/share/expyriment/
On Debian this is /usr/share/expyriment. On Windows, this is C:Python27/share/expyriment, on OS X this is /System/Library/Frameworks/Python/Version/2.7/share/expyriment.


Ba ar trebui să se poată :-)


Do you need the type here?


your _.depend_ file points me to mr. @SIonut (see his paths / dependency files)
Care to explain?


You may want to update the documentation directory when updating the SDK version number. The content in the 'basespace-python-sdk/doc' directory can be auto-generated using the sphinx tool. See 'basespace-python-sdk/doc/_update_doc/README.txt'.


Not sure it works but added code should let it read and play chords


Login Cloudy UP :)


> I would prefer we eliminate the concept of "master" altogether in favor of just clusterBindingResourceVersion and clusterPolicyResourceVersion since 12 mos from now no one will remember there was a master namespace.

You said it once before and I already did it. :)


One simple reason - we don't have frame to set into. Since app is not launched, scripts are not injected so no TestStorage yet.


I do not understand this part...

name should never be the empty string, since this is used to find out a review result for an individual namespace.  if name is emptry string, what am i really revewing and where am i doing that in code today since that seems like a bug.


@zamith I'm not a big fan of assuming you can just delete things you think should be deleted...


Any progress on permament fix?


@ryneeverett ahh! thanks for pointing out. Will fix it.


Смотри. Сейчас у тебя такая ситуация, что есть класс поля, который управляет всем подряд. Заведи класс змеи, который бы хранил в себе всё, что с ней связано. Для начала можно даже не кладывать в него методов, кроме `__init__`. Не забудь сохранить объект этого класса у себя в `Field` в виде поля класса.


newDefaultClusterPolicyBinding??


The comparison between [download_links.attrs('href')[0]]  and download_links.attrs('href') is going to be confusing... I still don't understand what it means (how do you know the 0th report is the one you wanted, for instance)?

I would prefer 2 explicit assertions that make it clear what you are testing. You can include whatever additional information you want in the message.


Typo:
qunatity => quantity


authorizationapi.ClusterPolicyBindingName??? or is Master different here?


ah I see -- is there any risk of race here ?


Sure, I'll make it only display once. Can you paste the error message here so I can also see what's causing it?


LevelDB is developed outside of GitHub; those 89 commits are just releases. It's based on a decade-old Google project. LevelDB deserves a lot of confidence (more than MongoDB I'd wager). Besides that, its properties fit the project's needs better.

You're right about `MemoryStore`, it won't do for production use. Better than keeping session state in memory, and even better (I'd suggest) than persisting it to a database or elsewhere on disk, I'd like to keep all session state (not just a session id) in a cookie (encrypted or signed). The downside is that the client has to send all session state to the server with each request, but we're storing so little state that the overhead is negligible. Keep the `MemoryStore` here for now, and I'll switch to https://github.com/expressjs/cookie-session once we're on Express 4.


The auth cache calls this based on the namespace of the reviewRequest.  The reviewRequest for ClusterPolicy and ClusterPolicyBinding changes has a namespace of "".


I deleted the comment, that @naps62 added as part of a copy paste, and was wrong. Not sure what you mean here.


@stv Regarding the {account_name}; bit:

Our account name is Stanford Online but our platform name is Lagunita. It would probably be clearer to participants if this line read, "Activate Your Lagunita Account", but I think it is technically supposed to read, "Activate Your Stanford Online Account". ...So... not sure, but I think this means that variable needs to remain {account_name};.


I think no, ""Injected" scripts will be presented and loaded before all other scripts loaded by normal content. Currently there is no way to remove a script from the marionette context after exposing it." [1].

Or what race do you mean?

[1] https://www.npmjs.com/package/marionette-content-script


Going back through from the beginning ...


I really don't believe that our Phone can have so many processes like a Server !
For me still working like a charm ... 1000 is perfect .. running it also on my laptop since some weeks ! ;-)


No luck unfortunately, I see log lines with things like `[FATAL]` and `[INFO]` in them so I'm relatively certain they're being logged to syslog with the right severity, but all app logs show as default severity in the logs viewer (except GCE event logs, those are correctly "info"). This happens for both a Rails app logging to syslog and for a pure nginx server logging to an access log file. Any pointers? Understand this may not be the right forum, I should probably move this over to StackOverflow.


Thank you so much, this resolved a couple big issues for me.


:+1: thanks for making those changes.


Ref: #11171

IIRC the original intention of this function was to sample things that can be turned into Unicode strings. In which case the thing we want is actually Unicode scalar values, not characters, and not code points.


Swapped x-coordinate with y-coordinate


if anyone could help me solve the queen/bishop mistake I would very much appreciate it


Do you think we need marionette-apps bug or you want it to be in gaia?


これでwiki編集した時にURL張られるようになった


catch exception


It wasn't added by him, at least in an authoring perspective. The comment has meaning, it's supposed to tell what's the actual line-height in pixels. I see that it was wrong (outdated), but simply deleting it is not nice, at least for me.


Nice. It would be cool if we had a function composition function.


I don't remember right now...
 I believe I've most experienced it when while being on slow or unstable networks connections, wakatime errors rates starts fluctuating, possibly combined with alot of async python processes that waits for tcp timeouts..


I meant this :)
Thanks then this clears this up !


> LevelDB is developed outside of GitHub; those 89 commits are just releases. It's based on a decade-old Google project. LevelDB deserves a lot of confidence (more than MongoDB I'd wager). Besides that, its properties fit the project's needs better.

That's cool.

> Keep the `MemoryStore` here for now, and I'll switch to https://github.com/expressjs/cookie-session once we're on Express 4.

Sounds good, but #25 might be an alternative to all these server-side stuff.


```list(APPEND VTK_LIBRARIES "vtkIOMPIParallel")```
fixed the  issues  we discussed below.


I think we need a bug in bugzilla :)


A simple ```list(APPEND VTK_LIBRARIES "vtkIOMPIParallel")``` as an additional lib to link against fixes the issues.


comment webhook test


:D Okay, will start with marionette-apps and Testing->JSMarionette bugzilla component, they can forward to gaia testing if they want  :)


Needs update


Yes, good call.


This is great, thanks! Could we perhaps move this into a subdirectory, e.g., `design/ui-mocks` or somesuch?


Fixed in commit b1fd36a


We couldn't figure out how this was done. Should it be 20px / 10px?


I can't use the word "function" because this error will also be used for methods, which do not have the function keyword


my bad. :/


roflcon i am testing comments


Good find, that's way better.


@jiahao Ok, thank you. Please correct: That means that a single combining character is a scalar and a wellformed sequence can have a combining character as first letter.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14603/testReport/) for this commit**


update: the error is in the diagonal checking between pieces method. returns true when it should return false. please advise.


For filesystems / volumes only `dsl_dir_rename()` is called, I do not see `dmu_objset_find()` in that branch.  And what would be a recursive rename in that case anyway?


I am curious. Why did you elect to go for the alternate-class-prototypes here? I'm sure you have your reasons, I'm just not sure what they are. Why not just have GameData store lists of plain old Items and Creatures and have factories that clone those prototypes, instead of having sort of abstract templates (CreaturePreset/ItemBlueprint) from which the creatures/items are created?

P.S. Why not CreatureBlueprint instead of CreaturePreset? Just for consistency, seems like it would look nicer.

P.P.S. The only reason I can think of for having templates from which they're created just struck me--right now it's no different, but in the future, the templates can be full of randomization/procedural generation stuff, which you wouldn't really want the actual creature to carry. Like for Orcs, some percentage chance of an Orcish Sword but alternately, an Orcish Axe, Orcish Bow, etc.


Fix broken images


Extraneous comma after `call`


comment test


@maxgalbu I fixed description for more correct :)


thanks!


This line is not in use by the SBT plugin code path, so things should work fine. This function is called by our property testing. We should have a way to customize the path to protoc for it there too, but this can be solved separately.


However with ItemBlueprints I'm not entirely confident on how to proceed on dynamically generated body parts. Perhaps some ItemBlueprint variant that stores a definition of a body part and then applies/attaches specific data (i.e. the blueprint is just "Corpse", the attached data is "Wolf" and whatever the Weight would be, maybe also NO_MEAT if that's relevant) to produce the item?


I love all these changes you're adding :+1:


@ryao  I meant that that was not clear from the documentation. But indeed, it probably does not make sense to document something while it is not clear how that actually works or is supposed to work :smiley:


Maybe we need an ItemFactory instead of the Item(ItemBlueprint) constructor.


Nu e eficient pentru ca pierde mult timp la fiecare alocare sau mai exista un motiv mai profund?


It's OK for importing but not exporting?  My concern with the incremental progress is that it could easily exceed the 60 character limit for status.  What about just `Exporting ZFS pools` and no incremental status?


@mschauer that is my understanding also. There is no requirement that a valid Unicode string must be correctly decodable into a sequence of characters, only that it must be decodable into a sequence of Unicode scalar values.  Otherwise you couldn't concatenate two Unicode strings like "a" and "¨" (combining umlaut) to produce "ä".


I don't think you wanted to add the `F` as well?


@esoergel can you tell me how you had this error? can_edit is an observable so it should be read with can_edit()

This change makes it possible to change a location to have ancestory that you don't control


comment test 2


having looked at the code it doesn't seem to be the case.


There is also a `cWorld` version of `FindAndDoWithPlayer`.


you need:

`${localPaths.filterNot{ p => new java.io.File(p).exists }}`

here. Sorry, I might not have written that in my comment. Without, only the `localPaths` will be converted to a string, but you want to run that whole block inside to get the actual missing paths.


Thanks:)


No `-r` option, that is old.  OK, well then if you want to keep it will need to be moved to a library function much like `unload_modules()` in scripts/common.sh.in.  Unloading just the zfs.ko module won't be sufficient for allow for a new version to be loaded.  You must remove the entire stack zfs, zcommon, znvpair, spl, zavl, zunicode.


It might be better to break this out as:

```ruby
b = branches.shift
l = leaf[b]
l = (leaf[b] = Hash.new) unless l
leaf = l
```


Oh sorry. My mistake. I googled around and still made this mistake :/


Given that lzc API already has calls for destroying bookmarks and snapshots I would limit the new method to datasets (filesystems / volumes) only,


and the bug isn't that I forgot to add 1, I fixed that and got the same error.


No I guess not... I want to use top-level, private `define`s as much as possible, but if the loops got to be inside the body (and it's the last thing in the body) idk.


so fancy it feels like Iggy Azalea  should have created it :O


<@wook> i am an awesome guy


Keyword! Yes


Not a fan of enlarging the scope of checking the journal stream, I'd rather see it repeated on each individual log lines.


Nope, fixing.


Thanks.


I don't know if I like the solid while background, but it'll do for now.

On Wed, May 6, 2015 at 2:11 PM, TechStack <notifications@github.com> wrote:

> so fancy it feels like Iggy Azalea should have created it :O
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trayer3/DeathCube/commit/bac29a20c94a52e39cf665fc816a70b7cd178d33#commitcomment-11071327>
> .
>


This is null (sometimes) because your javascript is loading before the DOM is ready, sometimes.  Use `$(document).ready(){ ... }`.


Your only failure is in pypy3.
Let's not allow-fail pypy in that case, to prevent regression.

Also, your only failure is due to the fact that:

```python
$ ~/prefices/py32/bin/python3.2
Python 3.2.6 (default, May  6 2015, 11:05:15)
>>> range(0,5) == range(0,5)
False
```

If we blacklist that singular test for 3 < python < 3.3, we can remove pypy3 from allow-fail as well, and I believe it's a good idea.


yeah agree. just tested & they will completely disappear for a bit too


@hlysig Ég er að vinna í testinu test_dimension_many_tags. Af hverju er tag = None hérna, en samt er tag.value = 'People'?  Skil ekki hvernig þetta virkar?  Einn voða vitlaus!


It sounds like this might be fairly distribution specific then.  I tried this exact same test under CentOS6 and it was clear that non-root filesystems were always mounted after the import so it just worked.  Is this not the case under Debian?

What if we just keep the updated code but make this functionality optional with a setting in the config file.  We can leave it disabled by default until those use cases surface.


I'm so sorry for this newbie mistake :( Forgive me Father, for I have sinned.. They have caught me using Windows :cry:


Why pass in the `Connection` struct if we just want the `ssl` member? Same question about `readn_raw` when we just want the `fd`. If we're going to establish a pattern here, it seems like less complexity to give each function access to only the member it needs so like:
```
foo_any(Connection* conn, ...) { ... }
foo_ssl(SSL* ssl, ...) { ... }
foo_raw(int fd, ...) { ... }
```


No, I think it's ugly for both. I could always just output a dot for each pool imported/exported. And no 'using [cache|/dev/...]' etc.

That information isn't really _required_. I think all of that could, potentially be important (at one point or another), but maybe only if interactive (as in, not started through init or whatever - calling zfs-{import,mount} manually from the shell). But then, that doesn't help those that have their system on ZFS/ZoL..

I honestly don't know. I just know I don't like one line per pool importted/exported. That is really ugly.


`startCounter` is called each interval.  What do we want to do every second?  Update the display and decrement the counter.


"Some cases" turned out to be when logged into wp-admin - removing this code caused wp-admin to render zero styles, so I reverted.


We should probably rename this to `countdown`, since it is called each time interval.


Make this a bit briefer, put the anchor around "selection bias" and drop the text in parentheses


After reading http://unicode.org/faq/char_combmark.html I think one can even stronger say that COMBINING DIAERESIS has a grapheme ``¨``. The combination ``"a"*"¨"`` has ``ä`` as grapheme. So that combining sequences only changes the *graphemes*.


Right, once merge to master the links will work.


I've rewritten this a little in the new push. Now this is only run if we're not exporting a root pool. And all modules, in the right order, is called.


small typo - should be `NAVIGATE_SUCCESS`


it's the actual line-height (the one the designer wants) divided by the font-size, so if the line-height is 26px and font-size is 10px, then ```// 26px / 10px```.
From the value used, i assume the line-height is 16.25px


Should this be 1.7?


This "reset to startNumber" should occur where you say `// start counting down when clicked`.


Even in their own function, I think more explicit names would be clearer here: `ssl_error_file`, `ssl_error_line`, `ssl_error_number`


Good job, you got very close.  See inline comments above.  With some minor changes, it works.


I cannot comment about it at this time, but could you communicate with us the issues you are having with the Jaco2, preferably at ros@kinovarobotics.com or in a new issue on GitHub? Alternatively, you could look at the "fferland-newapi" branch, but I must warn you that it's also a work-in-progress.


Bro what the hell man. I put serious work into that read me.


Can you explain why you either get ElementTypeFromIterable or from Interator?


- Can you also replace "arch*" with "Any Firefox build",
- Also replace the options "x86" & "x86-64" with "32-bit Firefox" and "64-bit Firefox"


All credit for this idea goes to Stefano80 and Rocky640.


Local testing suggested that 1 was in fact a better coefficient than any of the others I ended up trying. My local testing is not statistically significant, though, so I'll give others a try if this fails.


You could use a Map here if IE supported it :(
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map


@rodrigopavezi I think `authenticate` needs to go back to the top. It belongs in the User section. Thanks.


I think you mean ``` /*errorNode*/ ``` instead of ```/*expressionForError*/```


unfortunately not; doing so generates _two_ separate security group rules on AWSs side , not one.


Exact, se pierde timp la alocare și tu faci o alocare la fiecare adăugare & ștergere. Dacă dublezi dimensiunea cînd e cazul, în loc de `n` alocări faci `log n` alocări.


it'd be very nice to pull this "!has_errors || !references_error" logic into a helper fn called something like `should_report_error_for_predicate(tcx, predicate)`. This should include a comment with the example you gave me on IRC, and explain that unifying the result of the projection with error can cause error to occur inside the predicate itself, which would then lead to an error report being suppressed.

Obviously it'd be nice if we could somehow refine this condition to detect the cyclic condition, without having to check whether errors have been reported or not. IOW, it's nice if the presence of ty-err indicates an error has been signaled (or is guaranteed to be signaled). Obviously your change preserves that invariant in a simple and robust way, so that's appealing, but of course it feels a little less direct.


Compiler warning here.


I don't see how this makes a difference? When I set up the test using valid
root config and valid policy, I get the same test coverage as before.

On Wed, May 6, 2015 at 1:38 PM, Zi Lin <notifications@github.com> wrote:

> Let's try to do test coverage in a more meaningful way.
> First, grab/modify a config from config/config_test.go
>
> var validMinimalLocalConfig =
> {
> "signing": {
> "default": {
> "usages": ["digital signature", "email protection"],
> "expiry": "1h"
> }
> }
> }
>
> And load that string into a valid config.Config, you can find out how to
> do that by reading config/config_test.go
>
> Next, get a valid root config
> h: = map[string]string{
> "key-file" : "testdata/ca.key"
> "cert-file" : "testdata/ca.pem"
> }
> r := &Root {
> Config: h,
> ForceRemote: false
> }
>
> Now, prepare the ca cert and key files, create them under
> "signer/universal/testdata/", you can grab those files in bundler/testdata/
>
> Finally, use the Root instance and config.Config instance to start a
> universal signer.
>
> That should give you a decent code coverage of this package. And you can
> explore more to enable "ForceRemote"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/timestruck/cfssl/commit/1d285f3a0d41b7f57e2e2f2dcb993d28396230b7#commitcomment-11070650>
> .
>

--
Alice Xia
Cornell University '16


@mschauer you're addressing the concept of a grapheme cluster, which is also treated in Chapter 3 of the standard. It's very absorbing reading; I highly recommend it.


TL;DR this is clever but subtle, so let's make sure the reasoning is written out so we can remember


Your changing the mergeConfig() method signature.  This will break every use of the method.  If you want to add another param to the signature, it will have to go at the end and be optional.


@zommerfelds @paullepoulpe did you expect to display the features directly in the result page ?


I just tried to make it identical to the colorschemes and templates code below but can change it as you suggest.


rebase onto MITRECND/master


@jiahao That is somehow the funniest statement I heard today, and you are right. :-)


Uh, this doesn't seem right for Laravel 4!


I could get on board with something like this, where there's a dot per pool.  This could optionally be extended to one line per-pool for debugging when `VERBOSE_IMPORT=on is set`.

```
Importing ZFS pools...                           [OK]
Exporting ZFS pools...                           [OK]
```


this should also be changed to:
if( err ) return doUnlock();


results:
-10% in spring binary
-15% in spring_headless