lgtm, but I left a comment on the original commit


how l could be nil here?


In general, I'm against abbreviations. Better explicit than implicit.


you can't split the own name


Sounds better to me.


Looks good


You are going to want to add a DICTIONARY and THEASAURUS.jpeg to your head.


In other places that have this parameter we also have an `int` overload:

https://github.com/elastic/elasticsearch-net/blob/develop/src/Nest/DSL/Query/BoolQueryDescriptor.cs#L118-L122

Mind adding that in before we merge this PR?


I think this surrender to platform-dependent behavior is premature. Some bits of behavior (like pausing when a session is interrupted) can almost certainly be made interoperable. I think we should carve out allowances for variation only where we know that it's impossible to get the same behavior on two or more popular platforms.


Because it's copy/pasted :)


bundled as


I'll broaden the paragraph on the shipped packages to include both core and bonus packages. I don't think we need a term for the shipped - core set however.


Hi Vladimirek,
I have done the same work 2 years ago on B&R for my own in structured text and combined with the asHttp. It is working for one year in my home automation 100% based on B&R.

Cool to see that there more coders with the same idea, cool in other words. Possible we can learn from each other.

Greets, Mike
B&R Eng.


Pardon my quick typing

On Wednesday, May 6, 2015, King-INF3RN0 <notifications@github.com> wrote:

> You are going to want to add a DICTIONARY and THEASAURUS.jpeg to your head.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DynaLogic/MiscPlus/commit/46704285fdf6b2bbe8d3fa9a48ce0ab92dcf0591#commitcomment-11073939>
> .
>

--
-Logan


> Well, I could add that but only as an additional option to this menu (and I'm not sure we need two ways to open the config files). The thing is if the "open current filetype configuration" was the only option, this would require that you have the given filetype open which doesn't have to be the case. Forcing users to open (or create dummy) file with the given filetype just to edit the configuration is a bit silly...

Yeah I thought having an additional item, but maybe it's not required and not used often enough to warrant it.
Though, I'm don't totally agree with your remarks, OK changing a filetype could happen while not using it, but it's way more likely someone want to tune it because he sees a problem with it and want to fix it right away.

> […]
>
> One of the things I'd like to do is to add combo boxes with filetype lists for the filetype-specific parts of the dialog so users can change all the filetype-specific commands in one go.

Yep, sounds good :)

(OT) I also wanted to try a similar UI for the Plugins pref dialog because it currently becomes hardly usable when there are like 5+ plugins.


Staying consistent would be good. Feel free to roll this back in case ios, android support does not build on this.


Yeah, travis fucked up on one of the installation commands, for some reason


Exactly why I got that fixed. It was in response to the JIRA issue about pokemon :P

Note: always use UTF-8, it's the safest, especially since we want translations later...


What these commands go through are some of the default settings that vagrant requires (and as a user of a vagrant box, I know I can rely on).

http://docs.vagrantup.com/v2/boxes/base.html

So, this means that if I create my own username/password and forget what it is, I can always log onto the box as the vagrant user and change my password

sudo passwd <username>


the ampersand in this commit breaks the import into PublicPlatform.


I am trying to push this to fix users


Asim...!!


I would then split the sentences and say something along these lines:

In this guide, override packages are not considered stand-alone packages.

But to my knowledge, we only mention them here, so it may be confusing, because there isn't a use case for that warning?


this is not accurate.. the name is not enough to make this decision..


There wasn’t too much that changed, but I can do this in the morning.

Do you want me to create the commits on a new branch?

From: Warren Buckley [mailto:notifications@github.com]
Sent: 06 May 2015 21:03
To: craigacronin/Umbraco-Validation-Attributes
Cc: Craig Cronin
Subject: Re: [Umbraco-Validation-Attributes] Fixed bug with attributes not switching values on language change (88e89a5)

Eeeek massive commit @craigacronin <https://github.com/craigacronin>  it's a little hard for me to see what was changed & review. Would it be possible to do a new PR with more granular commits please instead?

—
Reply to this email directly or view it on GitHub <https://github.com/craigacronin/Umbraco-Validation-Attributes/commit/88e89a5a0e0c366ed318581cd079ba45f5add467#commitcomment-11073704> .


Thanks for the pull request, there is some issue with the formating (spaces instead of tabulations) but nothing major.

I have to test it because the System.exit on GuiSwing and the this.gui.stop() on Client are "dangerous".

There is also an issue with the position of the stop button but it will be easy fixed by moving the 3 buttons to the left.
![screenshot - 060515 - 21 05 37](https://cloud.githubusercontent.com/assets/9846442/7502631/3b622848-f435-11e4-80eb-0aa5f62bf7a0.png)


So I'm not clear on how this was done. Can you document that or make the audience go through the process of doing it themselves?


@jl2012 : no, 1MB extra is actually a lot bigger than necessary, overhead for a block message is on the order of 10 bytes.


Prolly newlines, even though I didn't do that willingly.


I suggest "but it is only used in the media session invocation algorithm," mostly to get rid of "platform" which I can only interpret as the platform (OS) on which the browser is running.


Here's a list of valid encoding:

http://www.degraeve.com/reference/urlencoding.php

Not sure how comprehensive it is.


You are right. A recursive rename wouldn't make sense because the children are implicitly renamed when the parent is renamed. I'll revise this to be more appropriate for its actual function.


It looks like your idea with stripping any %XX encoding and then do a compare with it's encoded counterpart might work, as long as you make sure to strip all valid encoding.

Can we either add a test or modify the encodedUrl value and 200/201 tests to have encoding for chars such as ! (%21), @ (%40), # (%23), - (%2D), = (%3D), _ (%5F) etc, and make sure that they pass (is valid ... return 200 and 201)?


this commit does a whole lot of seemingly unrelated things and has a rather poor commit message. please use git gui to split it up, and describe the atomic changes adequately.


Good point. Might be better to synchronize on both here.


To be fair, I only extracted the code from capistrano after it was removed by @leehambley I don't have any credit in the code itself. But thanks :heart:


@NathanMalo Scandale


Also, this bit ought to be about the content attribute, that's how it would work in an implementation as the IDL attribute is merely reflecting the content attribute and can change by other paths like setAttribute().


I've fetched it to my copy, not to the main repo (you can still do that, thus it's clear that it's your contribution)


Thanks.
- There are more places in the codebase were we do this, can you fix those too?
- Can you redirect stderr to /dev/null?
- hostname might be missing too, so perhaps hostname -f 2>/dev/null || hostname 2>/dev/null || echo localhost


@craigacronin Yes please. Just as this one contains over 2k changes and the GitHub site can't even show them all to me. I understand most of it is an Umbraco upgrade to test site, but if you can do that in a separate commit so the stuff thats really important like your changes is easy for me to understand what was changed & for me to learn from it.

A new branch sounds good to me, just do a new PR that compares against your new branch I believe.


Ah perfect, that makes a lot of sense. Thanks for the info!


@maikhoepfel @codeinthehole Is there a reason this setting is not defined in the oscar default settings? Same for the order pipeline etc.


Merged with upstream.


Not required IMO. Just wanted to stress the order.


change to prev_version_id


Full version:

*.[oa]
*~
*o.cmd
*.lo
*.obj
*o.cmd
*.ko
*.swp
*.in
*.la
.libs
.dirstamp
stamp-h1
/configure
/config.guess
/config.h
/config.h.in
/config.sub
/config.log
/config.status
/depcomp
/install-sh
/ltmain.sh
/missing
/Makefile
/libndpi.pc
/libtool
/src/lib/Makefile
/src/include/Makefile
/example/ndpiReader
/example/Makefile
/aclocal.m4
/m4/libtool.m4
/m4/ltoptions.m4
/m4/ltsugar.m4
/m4/ltversion.m4
/m4/lt~obsolete.m4


RET is unused


make sure this is working in the browser. @danquirk would know why we did not use JSON.parse in the first place..


style - should be tabs not spaces


:D :+1:


Yes no problem,

I’m just finishing off some urgent bits and pieces so will do first thing tomorrow morning.

Craig

From: Warren Buckley [mailto:notifications@github.com]
Sent: 06 May 2015 21:22
To: craigacronin/Umbraco-Validation-Attributes
Cc: Craig Cronin
Subject: Re: [Umbraco-Validation-Attributes] Fixed bug with attributes not switching values on language change (88e89a5)

@craigacronin <https://github.com/craigacronin>  Yes please. Just as this one contains over 2k changes and the GitHub site can't even show them all to me. I understand most of it is an Umbraco upgrade to test site, but if you can do that in a separate commit so the stuff thats really important like your changes is easy for me to understand what was changed & for me to learn from it.

A new branch sounds good to me, just do a new PR that compares against your new branch I believe.

—
Reply to this email directly or view it on GitHub <https://github.com/craigacronin/Umbraco-Validation-Attributes/commit/88e89a5a0e0c366ed318581cd079ba45f5add467#commitcomment-11074071> .


Regarding to the position of the buttons, I would like (if you allow me) to use some layout manager for the placement of all elements instead of being hardcoded... It would also allows the resize of the elements when the window is resized...


What kind of development is needed for submission with chain_id submission?
My guess that the mcm_cr would be a list of single chain_request which id
is passed. Now if we pass request_id it will submit all chains containing
this request_id (with certain conditions). Still from my point of view: why
wee need to keep the submission by chain_id code if it's API is never
triggered?

It acquires non-blocking lock.
fix:
https://github.com/cms-PdmV/cmsPdmV/commit/43cbbe68b86dfdab4251411d12587f823ea5300a
I do not see a reason why would run() was used instead of internal_run(),
although in RequestSubmitter internal_run() was used. And the Chain
submission code is more or less a copy of RequestInjector...


maybe it's obvious to others, but from my perspective the commit message is lacking on the "why?" front.


Ref #31


Default value for fields which have non-primitive type is null, so this initialization is excess.


$ZPOOL and $ZFS below should be quoted for safety.


ahh i see,thank you for the reply!! gonna be forking and seeing if i can get anything going


haha :+1:


I'm not completely sure why, I think the PR where those tests were introduced were started before those modes were added to DownSampleFactorMax.


This way if a download gets interrupted by pressing ESC, download_curl raises an error:

```
> curl_download(url, tmp)
Error in curl_download(url, tmp) :
  Failed writing received data to disk/application
```

It would be nice to stick with the same behavior as `download.file` which is just to silently stop downloading.


You are right. I thought it would be better to restructure the signature. Otherwise I fix it thus the params option (which is already optional) becomes last.


does not matter anyway because this is not supposed to serve an interface. you really need some object with its own thread.


Change to prev_version_id


I don't think both parts are needed, since `nullptr == 0`


Great add - thanks!


same here :-)


The subordinate clause here is long enough to warrant a comma IMO.

But I think I would try to rewrite the whole paragraph to make the causal clause come after the main clause:

If the original...,
overriden files will not be...
because...


you shouldn't need the `if`, see [here](http://stackoverflow.com/a/4190737/1737909


WSHP_SHR_GreaterThan_1 (Nigusse) - x86_64-MacOS-10.9-clang: OK (1637 of 1644 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.57%25-yellow.svg)


We've got a `load_module()` moving this to `unload_module()` would be appropriate.


Yes, "in this guide" is kind of misleading since this is and likely will be the only place where they are mentioned.


Rename to corLibrary "mscorlib" is confusing.


Okay I've got some exciting housework to do and then I'll jump on that.


Updated. Please review.


这个最好放package级别，大家共用


所有的Set都要做参数校验，并定义相应的Exception


I'm not sure what you mean by git gui... I know of a couple, but none that seem to do anything useful as far as splitting commits.


OK.


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/61521037


that's a cute way to abuse bit fields :o)!


Looks good.

I agree that having uniqe_ptr would be great.  I really want to be able to use smart pointers in STL containers.

I see that you moved the junit test from TestFunctionsSuite to TestFunctionsForVoltDBSuite?  I think the former location is better.  TestFunctionsForVoltDBSuite is for the VoltDB-only functions defined in src/hsqldb19b3/org/hsqldb_voltpatches/FunctionForVoltDB.java.  It would be good to keep all the REPEAT-related junit tests in the same place.

Note that most RegressionSuite tests run both against VoltDB and the HSQL backend, so if you want to lock down VoltDB-specific behavior (like your new error message), you can just `if (isHSQL()) return;` to avoid HSQL failures.


(same here)


> (OT) I also wanted to try a similar UI for the Plugins pref dialog because it currently becomes hardly usable when there are like 5+ plugins.

Yeah, makes sense.

Alright, while offto-picking, is the Tools->Configuration Files a good location for it? Shouldn't it rather be together with Preferences under the Edit menu? It's just preferences in the text form. It makes sense to have build commands under the Build menu and project properties under Project but the config files under Tools doesn't make much sense to me.


The name of the column is the keyword in many databases. MySQL permits this keyword to be used as unquoted identifier. Probably Hibernate can successfully handle this even with other databases, but I would change it to something different:)


great, have at it! I'd been rebasing like crazy, but I'll keep the commits this branch stable so collaboration will be easier.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7217/testReport/) for this commit**


Please don't reference an Issue if it has nothing to do with the issue!

Using a #<number> is used to represent an issue affected by that commit


Agreed.


Hm. We'd still miss who says that. I think I like this better:

Override packages should be seen as user customizations and not as stand-alone packages.

 Which to me conveys the idea that we pull that out of thin air, but it's clearer that it's our idea.

But I still fail to see why we need this piece of info. What are we trying to warn against?


@bcow aren't those library statements supposed to be inside the function?


两个Message可以抽象个基类或者定义接口和Implementation


I wonder if something like: "Best Practice Patterns" might be better: "Standards" is quite strong.


@daniel-beck
You could also use major rfe


Ditto to previous comment.


I don't fully understand. Is this an issue with basic writing operations performed by one single peer?


public class Quadtree {

  private int MAX_OBJECTS = 10;
  private int MAX_LEVELS = 5;

  private int level;
  private List objects;
  private Rectangle bounds;
  private Quadtree[] nodes;

 /*
  * Constructor
  */
  public Quadtree(int pLevel, Rectangle pBounds) {
   level = pLevel;
   objects = new ArrayList();
   bounds = pBounds;
   nodes = new Quadtree[4];
  }
}


where is this file used?


The Patch domain object should also include the following fields:
* Description (can be null)
* Redactor (the person who made changes)


I would leave out numbering as it will mess with the anchor links i.e. just "Data Package Name"


extra empty line


invalid syntax!!!


@julen This change looks like is in the wrong commit.


MAX_OBJECTS defines how many objects a node can hold before it splits and MAX_LEVELS defines the deepest level subnode. Level is the current node level (0 being the topmost node), bounds represents the 2D space that the node occupies, and nodes are the four subnodes.


Technically you just just do `fnames = []string{"-"}` which *should* save testing fnames to see if the string literal can be appended without regrowing the underlying array.


> and can be in `<arg>` form or `ARG` form

IMHO better: "and can be declared as `<arg>` or `ARG`."

Then it's more clear, that it's about the "usage source code" rather than the the application.


public class Quadtree {

private int MAX_OBJECTS = 10;
private int MAX_LEVELS = 5;

private int level;
private List objects;
private Rectangle bounds;
private Quadtree[] nodes;

/*

Constructor */ public Quadtree(int pLevel, Rectangle pBounds) { level = pLevel; objects = new ArrayList(); bounds = pBounds; nodes = new Quadtree[4]; } }


please remove runnerServer.ts


Hi there, we've implemented a new target pattern for letter sized paper and changed the way some of the margins are calculated such that relative lengths may be compared upon printing to determine the proper scale of a target. There was also some cleanup for member variable naming convention.


Good suggestion. I think we do want just `contributors` field plus maybe author as per guidance in https://github.com/dataprotocols/dataprotocols/issues/130 - we probably need to make clear that author is about author of the data package not necessarily original creator of the data.


Yo hablo español.
Me da error la compilación.
La parte del código para activar large pages no compila como lo tienes tu.Pero con los cambios que propongo logro compilarlo correctamente y parece funcionar correctamente.
Saludos
I speak Spanish.
 I get error when compiling.The part of the code to enable large pages not compile as you have.
 But with the changes I propose achievement compile correctly and seems to function properly.
 regards

     El Miércoles 6 de Mayo de 2015 21:03, Marco Zerbinati <notifications@github.com> escribió:

 do not use linux ..
tried to compile?
give error?
Enable large pages in the operating system?

2015-05-06 17:20 GMT+02:00 snino64 <notifications@github.com>:

> I can not compile deepfishz in linux.
> I made some corrections and now if I can compile.
> Are changes correct?
>
> /*
> Stockfish, a UCI chess playing engine derived from Glaurung 2.1
> Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
> Copyright (C) 2008-2015 Marco Costalba, Joona Kiiski, Tord Romstad
>
> Stockfish is free software: you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation, either version 3 of the License, or
> (at your option) any later version.
>
> Stockfish is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> GNU General Public License for more details.
>
> You should have received a copy of the GNU General Public License
> along with this program. If not, see http://www.gnu.org/licenses/.
> */
> #include
> #include //<-----
>
> #include "thread.h"
> #include "tt.h"
>
> using namespace std;
>
> #define TRUE 1
> #define FALSE 0
>
> int large_use;
>
> #ifndef _WIN32 // Linux
> #include
> #include
>
> static int num;
>
> #define MEMALIGN(a, b, c) posix_memalign ((void**) &(a), b, c) //<--------
> #define ALIGNED_FREE(x) free (x); //<--------
>
> void SETUP_PRIVILEGES(){} //<--------
>
> void CREATE_MEM(void** A,int align,uint64_t size)
> {
> large_use=FALSE;
>
> num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
> if(num==-1)
> {
>
> // printf("info string LargePages FAILED %llu Mb\n",size>>20);
> std::cout << "info string LargePages FAILED %llu Mb\n" << (size >> 20) <<
> std::endl;
> MEMALIGN((
>
>
>
> *A),align,size); } else { (*A)=shmat(num,NULL,0x0);
> large_use=TRUE;
> // printf("info string LargePages OK %llu Mb\n",size>>20);
> std::cout << "info string LargePages OK %llu Mb\n" << (size >> 20) <<
> std::endl;
> std::cout<<"info string HUGELTB "<<(size>>20)<<std::endl;
> }
> }
>
> void CREATE_MEM2(void** A,uint64_t size)
> {
> large_use=FALSE;
> num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
> if(num!=-1)
> {
> (*A)=shmat(num,NULL,0x0);
> large_use=TRUE;
> // printf("info string %llu Mb LargePages\n",size>>20);
> std::cout << "info string %llu Mb LargePages\n" << (size >> 20) <<
> std::endl;
> }
> }
>
> void FREE_MEM(void* A)
> {
> if(!A)
> return;
> if(!large_use)
> {
> ALIGNED_FREE(A);
> return;
> }
> shmdt(A);
> shmctl(num,IPC_RMID,NULL);
> large_use=FALSE;
> }
>
> #else
>
> Thanks
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Zerbinati/DeepFishMZ/commit/30f2afc3e63eb03b2a5c2a30b972fa55372f2f71#commitcomment-11067845>
> .
>
—
Reply to this email directly or view it on GitHub.


I actually didn't move the Repeat test to TestFunctionsForVoltDBSuite.  I
added  a new junit test
there for the one bit of behavior I was testing.  I agree that it would be
better in TestFunctionsSuite.java,
though, and I'll probably move it back to there, now that I know about
isHSQL().

On Wed, May 6, 2015 at 4:30 PM, Christopher M. Wolff <
notifications@github.com> wrote:

> Looks good.
>
> I agree that having uniqe_ptr would be great. I really want to be able to
> use smart pointers in STL containers.
>
> I see that you moved the junit test from TestFunctionsSuite to
> TestFunctionsForVoltDBSuite? I think the former location is better.
> TestFunctionsForVoltDBSuite is for the VoltDB-only functions defined in
> src/hsqldb19b3/org/hsqldb_voltpatches/FunctionForVoltDB.java. It would be
> good to keep all the REPEAT-related junit tests in the same place.
>
> Note that most RegressionSuite tests run both against VoltDB and the HSQL
> backend, so if you want to lock down VoltDB-specific behavior (like your
> new error message), you can just if (isHSQL()) return; to avoid HSQL
> failures.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VoltDB/voltdb/commit/bc0adbe1d40631b8bbc777314d2179a62fa852d4#commitcomment-11074226>
> .
>


AIDE did not complain about incorrect AndroidManifest, but AndStu on windows barfed.


Is there any way to change this message without closing the pull request and opening a new one?  (My git-foo is very weak)


:trollface: Why am I not listed ??11?!11? ;-)


I just noticed this too, after my build picked up the latest gulp-minify-css and my site broke.  I filed a bug on that module.  But this is probably a good defensive measure in any case.


The problem is I am looking for how to use it, and cannot find the clarification anywhere....


Implementation of #136


Will do.


that problem repeats all over the place, so fixing this one instance isn't too helpful ...


This is hack. Use bool.


rax retry tests


(There is a dot missing before "The same constructor is used...")

For me, the second sentence sounds very technical and is hard to understand without the "e.g.".
What about:

> The argument of an option `--option=<arg>` is accessed by `longOption "option"`, not `argument "<arg>"`.

(For the case I am not the only one trying to access it with `argument "<arg>"` ;) )


It seems reasonable to me to throw an error in that situation


ok


Thanks for pointing these out ^^


will do, wasn't sure which one you preferred.


Well, putting the filetype files along with the other conffiles makes sense.  But I myself must agree that having *Configuration Files* (and *Reload configuration*) under *Tools* doesn't make so much sense and indeed may be better next to *Preferences* in the *Edit* menu.


@julen `jsonify` is no longer necessary here.


why did this change with changing the order of the lib file in the list?


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/ef92b6619e51d8e0f155207bb86b541f11ff16c6/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/ef92b6619e51d8e0f155207bb86b541f11ff16c6/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/ef92b6619e51d8e0f155207bb86b541f11ff16c6/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/ef92b6619e51d8e0f155207bb86b541f11ff16c6/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/ef92b6619e51d8e0f155207bb86b541f11ff16c6/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Thanks for the feedback! As far as testing, I've just been running a local instance of the bot and running through a list of commands with variations of permissions and rooms. If there's a better way to do that I'm all ears.


I APPROVE


I think the lock file should always be touched to make this more resilient.  Just because one of potentially several pools couldn't be imported doesn't mean we shouldn't mount and share the others.

```
do_import
touch "$LOCKDIR/$servicename"


@dorgan ignoreProperties is like `allExcept: "properties"`. It just skips checking of them. Not sure how to write it more clearly.


We need some coverage for this.. can you add a project test instead.


Lol i'm just dumb haha


@julen `HttpResponse` is not necessary either.


Creating the new sql columns was my recommendation. I did consider placing
this information in the notes column with separators. However, the query to
collect the most recent checkin and checkout(this function/query does not
yet exist but will) will be much faster with this in a separate column (via
a JOIN). The only other option is migrating it to another separate table
(like the Code Types table), but that would be much more work. I
rationalized that there will likely be custom lists in the future that may
want to take advantage of these columns. Still definitely up for
discussion, but wouldn't make any decision on this yet. Once feature is
worked out, then can migrate it if community deems it necessary before
committing it.

On Wed, May 6, 2015 at 12:09 PM, mdsupport <notifications@github.com> wrote:

> Since lists is a extremely generic feature, isn't it too drastic to add
> columns like 'toggle_setting_1' and 'toggle_setting_2' for use by a single
> list which is likely to contain so few entries?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/teryhill/openemr/commit/fcfb2372adac7eaf8774d14f4cf1c19cead9d35c#commitcomment-11072629>
> .
>


i would leave that.. as this is the 1.0 lib.


:smile:


aah that is the one.. this should not be going in teh same path.. does it..


`== Known` makes it clearer


option name is now changed.
npm test doesn't like my var style.
Biggest FIXME concerns test for option.searchDefaultTokenKeys = false and option.headers = []

Some minor googling for myself concerning the correct placements for WHY's in createApp().
- obtain correct order of app.something
  - check that the app.something is really needed
    - ie. the testing app should contain the minimum necessary, or else one starts testing the testing app...


@kjellm One note here.  From an accessibility standpoint this needs to work better with screenreaders.  You can accomplish this by either turning this `div` into an actual `button`, or giving it a `role="button"`.  I'd prefer conversion to a button rather than the role just because it's a bit more semantic.  Also perhaps we could change the wording when it is actually done to say "Done".


true, fixed on master


what you're fixing here is a symptom of a bug (IMHO) introduced in a82b014, where the command alias is left in the arguments array. I think we should fix the cause, rather than the issue, and remove the first element (the alias) from the arguments array


@dorgan btw, there is an issue about that: #1303. Feel free to left there a feedback


@kjellm Just one note this time around.  It looks really good and with that one concern fixed up, it should pass internal code review and can then move on to our QA engineers for the manual QA process.


@madrob  this comment on the commit will be lost (from the PR) if the branch is rebased.   If you comment on the files changed section of the PR instead of commits, then the comments will still be  visible on the PR after a rebase.


But then we won't do a full type check on the file.


merged everything


It looked like a nice project! I randomly stumbled upon from a Taiga issue. I'm not much a C++ developer, but I'll definitely read some comments from time to time :-).


dfbsdbff


This would nicely turn in to a one liner.

```
zfs_action $"Sharing ZFS filesystems" "$ZFS" share -a
```


Sorry, I will attend a match of teaching, too busy this week. It seems "CREATE GRAPH" is creating vertexes and edges at the time. It is better to keep same to OrientDB, more same more easier to code Meteor-OrientDB package. Do we still have "CREATE VERTEX"?


# me
https://docs.google.com/file/d/0B5Eq8DOWi0J1UkdMSUV3UkNZbUE/edit?usp=docslist_api


Yeah i do agree, the hardcoding of positions was not really a smart move but it's was originally a proof of concept BUT it should be an another patch.


Not bad!! Познакомился с потоками)


Here the from and to parts are probably not the best options. I would expect something like this for the Ordered scaladoc: `Ordering[A] to Ordered[A]` instead of
![Ordered[A] to Ordered[Ordered[A]]](https://cloud.githubusercontent.com/assets/153506/7503298/5317a398-f442-11e4-903b-88e7c45f2ea0.png)


Sorry, but I don't like this huge commits that changes license and everything in one go.

Also you completely broke the plugin by adding html escapes, as now all tags inside the <header> are displayed with htmlentities. See e.g. koodikerho.fi. Please revert.


AWww yis. Love it. :+1:


Yes, of course! That was I was planning to do...


Oh I had no idea, I just wanted to make sure you had done something. SGTM


@kevinchen93 Got it! =D =D =D


Nice! :tada:


@IstuntmanI: Have you tested the Streamer_SetRadiusMultiplier with this fix?  It still doesn't work.

@samp-incognito: I'm still crashing (along with EVERYONE in the server) when using the following command (ex.):

	YCMD:streamradi(playerid, params[], help)
	{
		if(help)
		{
			SendClientMessage(playerid, COLOR_HELP, "[Command] Help: /StreamRadi <Float: Radius Multiplier>");
			SendClientMessage(playerid, COLOR_MESG, ".");
		}
		else
		{
			new Float:rad;
			if(sscanf(params, "f", rad))
				return SendClientMessage(playerid, COLOR_ERROR, "[Command] Error: /StreamRadi <Float: Radius Multiplier>");

			Streamer_SetRadiusMultiplier(STREAMER_TYPE_OBJECT, rad, playerid);
			SendClientMessage(playerid, COLOR_MESG, sprintf("You have set your stream radius multiplier to %0.1f.", rad));
		}
		return 1;
	}


Awesome_page approved


Loop vast bij names.txt, weet niet waar dit bestand te plaatsen


"Media is used ... to play ... media" could use less media :)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


Please notice that the LICENSE and the plugin header had a unified layout in all Seravo plugins, you should not break the pattern for no reason:

```
$ head wp-spam-question-filter.git/wp-spam-question-filter.php
<?php
/**
 * Plugin Name: WP Spam Question Filter
 * Plugin URI: https://github.com/Seravo/wp-spam-question-filter
 * Description: This plugin fights comment and registration spam on your website. Original plugin at http://www.compdigitec.com/apps/wpnobot forked by Seravo
 * Version: 0.2.5
 * Author: Seravo Oy
 * Author URI: http://seravo.fi
 * License: 3-clause BSD
 * Text Domain: wp_spam_question_filter

$ head wp-pdf-templates.git/wp-pdf-templates.php
<?php
/**
 * Plugin Name: Wordpress PDF Templates
 * Plugin URI: https://github.com/Seravo/wp-pdf-templates
 * Description: This plugin utilises the DOMPDF Library to provide a URL endpoint e.g. /my-post/pdf/ that generates a downloadable PDF file.
 * Version: 1.3.8
 * Author: Seravo Oy
 * Author URI: http://seravo.fi
 * License: GPLv3
*/

$ head wp-custom-bulk-actions.git/custom-bulk-actions.php
<?php
/**
 * Plugin Name: Custom Bulk Actions
 * Plugin URI: https://github.com/Seravo/wp-custom-bulk-actions
 * Description: Custom bulk actions for any type of post
 * Author: Seravo Oy
 * Author URI: http://seravo.fi
 * Version: 0.1.1
 * License: GPLv3
*/
```


> Well, putting the filetype files along with the other conffiles makes sense.

Just to clarify - I meant the whole Configuration Files menu location (filetype config files should be definitely inside it).


i don't know for now...
if we try to use seesaw lib, maybe better to investigate what the lib offers in this case.


run instead of internal_run : the code was in ChainedRequestActions before, and was not under other lock AFAIR.

fix: glad if that helps moving forward.

non-blocking lock : I think there is something fishy in the way I used it and how Igor implemented it.

If you want to take out the submission by chain-id (which although not triggered by a button, has the api for it, which just need to be wired to the chained_request.html), in the submission by root-id, you would need to put the right logic to select only the request spawning from a root request, within a given chain. point at which you're better off passing the chain_id in the first place. There are implications in TaskChainDict


How to use variable in AlaSQL?
 e.g
```javascript
variable = "input";
alasql('CREATE GRAPH #John, variable');
```


"When playing media ... for playing media" could also use less media.


1) es para que leamos un xml y guardemos otro xml
2) :-1:
3) bueno, estaba buscando donde fallaba y me lo debo haber olvidado comentado :innocent:


I'm not sure this is `right` but I think it's better.  This way it runs after DKMS which might be needed on a kernel upgrade.

```
# chkconfig:    2345 06 99
```


@julen The import for `HttpResponse` in this file can also be dropped.


I'm not sure this is `right` but I think it's better.  This way it runs after DKMS which might be needed on a kernel upgrade.

```
# chkconfig:    2345 05 99
```


":=" or "=" ?


It's nothing compared to Taiga but at least AniList is getting some love :+1:


Class Heartbeat does not have a Docblock comment.


@julen The import for `HttpResponse` can also be removed in this file.


Reverted the escapes.

Sorry about the escape issue. esc_html_e did something different than I thought.

I didn't change the header or the license knowingly. I pulled and edited straight from the wordpress.org svn repository. Apparently they were on different commits.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/11752/testReport/) for this commit**


Yep -- just looked into it in the source files... this DTD is only used by the legacy PAGS approach.  We don't need to update it.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Yes because we now have the extra SIM id property but it's harmless since we don't use it. I don't think that it made sense to explicitly check for that since it's unused.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


Looking forward to this one !


why? so there will be no more alt+tab and other background hotkeys support on linex :/ and shift+tab won't work with steam anyway.


@julen The imports for `HttpResponse`, `HttpResponseNotFound` and `HttpResponseBadRequest` can be removed from this file.


why call the function "process_event" when is specific for a ReceiverTip ? is process_receivertip ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14609/testReport/) for this commit**


This is one of the kind of changes that I would expect for the sake of introducing testing.

BTW, something is weird here, as I didn't receive any notification of this commit. Should we perhaps (via git hooks?) inform all the members of the project?

As far as I remember, Eclipse's pydev (which, BTW, is packaged in Debian, if you use that) is able to offer some limited automated refactoring for Python.


Hey! Did it work? I could merge that to the main branch.


Don't worry, it's not a big deal.

> Still time to release 0.4.0 or best to do nothing?

Well, good question!
I would probably release 0.4.0 without touching 0.3.3, with a small mention of what happened, there is no shame in that...


I think it's same like v5 kitkat needs.
Edited Bootclasspath, Seapp_context, ini.miui.rc, ro.adb ~~~ something like that
We should edited 5 or 6 files on kernel.
I will tell you later what files exactly needed to edit, bcause i'm not on my computer right now.


PHPCS: Expected 1 space after closing parenthesis; found "\n        "


PHPCS: Whitespace found at end of line


Class StoreHeartbeatRequest does not have a Docblock comment.


Method HeartbeatController::ping does not have a Docblock comment.


Class Heartbeat does not have a Docblock comment.


@yulka where does `theme.less` come from?


This is now going to be forge.puppetlabs.com/puppetlabs/dsc


Yes, absolutely, it's a mistake on my part. Ironically I've run our entire gaia test-suite with this and nothing fails. Go figure.


--credentials-file=CREDENTIALS_FILE maybe?


@ace2nutzer please give me your email I have to ask u some things on hangouts


Looks good, I guess.


Using version codes instead of version numbers per @iambmelt recommendation.


RadianceRefactor (macumber) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Not related to this PR but consider the following:
* Call configureAuthSettings from the `AndroidSnippetsApplication.onCreate` method instead of the `OperationLIstActivity.onCreate`. It is a better place to initialize app-level settings like this.
* It doesn't look like the activity parameter is being used, consider removing it.


For clarity, include time units: '...time: %s ms'.


Okay, fine.


If it is presented in a useful and beautiful way (like maybe an optional "extra information" or "...") then yeah.


No, can't think of one.

That order status stuff is tricky. It makes sense for some shops but is probably totally inappropriate for others. It's never really been 100% integrated into the core.


If you set a `MCefRefPtr` to `NULL` it will call the release on the ref counting. I guess out of habit I'd been setting them to `NULL` explicitly, though it sounds like you've confirmed that they're being released automagically which is nice.


This should have been put in a pull request


time units again


Under what circumstances would this file be generated? You can also use Powershell arguments.


:+1: et je suis d'accord avec @lionelB, la pres de @divarvel vaut le coup d'être mentionnée


Why did you take out at the end

```
free(body.buf);
free(headers.buf);
```

Shouldn't we free the buffer after copying it into a rawvec?


I'm not actually an AniList user "yet" because everyone I know uses MAL (and because it "works well enough"... hehe). It's good to have many open source projects though :-).


you miss a space after the comma
ForeignKey('classifier.id', ondelete='cascade')),


Ow sry you already fixed that in the next commit.


I no longer think "potentially playing" is going to be helpful. The place in the media element processing where we should try to activate a media session is when readyState reached `HAVE_FUTURE_DATA` or greater. This is where "The user agent must queue a task to fire a simple event named canplay at the element" and "If the element's paused attribute is false, the user agent must queue a task to fire a simple event named playing at the element."

The way I see it is first the canplay event is queued, then we try to activate the media session. Only if that succeeds does playback actually being and the playing event is queued. We should ask for changes to HTML, but while we're figuring everything out just monkey-patch it.

Also on this line, I think the definition of the algorithm should be separate from where it is invoked. The algorithms ought to be fairly generic and part of the media session processing, while the hooks that actually invoke the algorithms is what constitutes the extensions to media elements.


Alternatively I would suggest to implement a new scheduler function called "warning" which is not causing an idle or exit and just ensures an output on every port available and/or syslog entry.


s/if if/if/


Nevermind should have restarted my salt-master and salt-minion for this to work..oops.


ditto


contact me pls on xda .. i can give u mail for hangouts another day.. because i'm mostly offline .. due to some tests with CPU / GPU Governors etc ... ;-)


g


there is a choice between "unified" and "parallel", will alasql be a new sql dialect or different old sql for different dada? As I understand, alasql1 is unified, alsql2 will be parallel.


Putting this in `env:SYSTEMDRIVE` isn't particularly friendly. You could probably use `env:TEMP`. @ferventcoder have a better suggestion?


What made you think that XI2 got anything to do with alt+tab and hotkeys


Added https://github.com/Yara-Rules/rules/blob/master/malware/FlyingKitten.yar

Thank you @nyx0


Ah... Their most recent change of April 1st. I thought that it were an April Fool's prank, but apparently not. :)

Obviously OK.


This file is generated on the Razor server when a node completes the provisioning process using a Windows installer. This file is downloaded and executed via the rendered version of https://github.com/smcclellan/razor-server/blob/master/tasks/windows.task/SetupComplete.cmd.erb, which is run on startup.


Not sure what this is doing, a callback to the server? Would it be valuable to post back to it?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


Wrong docstring and wrong filename

Migration script must have the name of the next release.
It should be migr_1_2_3.py
And you should bump the version number and add a note in the CHANGES.rst


Sydney.


Have you test it on sqlite mysql and postgresql ?


Is this valid markdown?


Yes, see https://github.com/ros-simulation/gazebo_ros_pkgs/pull/324.


![9st near macdonaldmanhole-fire_](https://cloud.githubusercontent.com/assets/734319/7503902/8ad0a050-f40b-11e4-8689-67fec2232a38.jpg)


@jwrage Where is SIFNAxPressCommonTypes.xsd *supposed to* live now? In `/Entity` or `/Composite`?


this seems to be showing "this is an example of a warning message" in many places.... also leaves a dangling ','


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/fd2539145affddb2577c75a4bf1a17601bc28368/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


These should be `attr_reader`, because otherwise we could do this:

```ruby
barracks = Barracks.new
barracks.health_points = 0
```

The `damage` method is responsible for modifying the health points. We do not want to modify the health points directly.


Ah, OK.


You'd still need the `if len(fnames) == 0` check in order to preserve the behavior:

```
// if there's no args, read from stdin
```

This is a _really_ minor style decision, but I agree `fnames = []string{"-"}` seems slightly more readable.


Doing a GET on the URL generated in this function results in a log message on the server. Since the URL is rendered in the ERB, it's tough to get the true error message passed to the server. This error would inform the user to log into the machine to re-run the installer.


@andresgutierrez So what do you think about this?


thank you :)


The user may need to run the installer again. Will `env:TEMP` persist?


dunno but mb this https://github.com/Warsow/qfusion/commit/1e2d16305276c6c9bfe4efcbd7019fe674ec8e0f


This is a bit unnecessary

```
C:\Users\Administrator> $Error.Count
5
C:\Users\Administrator> if ($Error.Count) { 'ya' } else { 'nah' }
ya
C:\Users\Administrator> $Error.Clear()
C:\Users\Administrator> $Error.Count
0
C:\Users\Administrator> if ($Error.Count) { 'ya' } else { 'nah' }
nah
```


I am not sure this work on MySQL, did you test it ?


Syntax tip: you could rewrite this as `@health_points -= amount`


Typo - missing word(s)


Look into using the `is_a?` method to check the type of an object.


Ok, yeah that looks cleaner. I'll update the commit once reviews are in.


best commit!


I _really_ doubt that alt+tab didn't work prior to this XI2-specific commit


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


I'm pretty sure Windows doesn't automatically clean up `env:TEMP`. Running `Disk Cleanup` is the normal way to do that.


@dorgan perhaps you could explain what you wanted to do and we will try to help you do it?


Yup, `${ENV:TEMP}\puppet.msi` is probably the location you want to use, as long as the user writing the file, and the one running it are the same.  Otherwise, the temp directories will be different.


didn't notice you fixed this. thanks.


newbee


Change is on dragons3d_master (PubNub, squashed), dragons3d_master (pgengine), master (dragons3d).


PHPCS: Expected 1 space after closing parenthesis; found "\n        "


This could be moved into it's own method, say `die!`.


hi all


Hi,
things went well:
* Reactive got fixed
* My XML (enabling for inline Julia code in XML) went faster than expected, with much help from **JuliaParser**

So I am interested to access a coherent set of GLAbstraction/Romeo/GLxxx... working with the new Tuples. (In order to get my XML integrated, I have loaded several of your newer branches, but there are still issues like the following
```
ERROR: LoadError: LoadError: LoadError: MethodError: `normalize` has no method matching normalize(::GeometryTypes.Vector3{Float32})
 in lookat at /home/alain/.julia/v0.4/GLAbstraction/src/GLMatrixMath.jl:144
 in call at /home/alain/.julia/v0.4/GLAbstraction/src/GLCamera.jl:335
 in call at /home/alain/.julia/v0.4/GLAbstraction/src/GLCamera.jl:235
 in createwindow at /home/alain/.julia/v0.4/GLWindow/src/reactglfw.jl:405
 in include at ./boot.jl:250
 in include_from_node1 at loading.jl:129
 in include_all at /home/alain/.julia/v0.4/Romeo/src/utils.jl:4
 in include at ./boot.jl:250
 in include_from_node1 at ./loading.jl:129
 in reload_path at ./loading.jl:153
 in _require at ./loading.jl:68
 in require at ./loading.jl:51
 in include at ./boot.jl:250
 in include_from_node1 at loading.jl:129
 in process_options at ./client.jl:308
 in _start at ./client.jl:407
while loading /home/alain/.julia/v0.4/Romeo/src/display/renderloop.jl, in expression starting on line 31
while loading /home/alain/.julia/v0.4/Romeo/src/Romeo.jl, in expression starting on line 45
while loading /home/alain/src/Julia/Romeo.jl/test/RomeoVolume.jl, in expression starting on line 3
```
)

Best
Alain


Was able to implement the functionality such that whenever the script run it deletes the previous day’s tar files and downloads the new ones between yesterday and today… currently only working for L8 but it will be easy enough to add L7


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


Yeah, `_browser` is auto disposed by C++/CLI in `~CefSharpBrowserWrapper`. _browserAdapter won't be though, since it isn't IDisposable (on purpose of course). So I set it to NULL in order to allow the GC to collect it if possible.


Great, I'll use `${ENV:TEMP}` instead.


Or you could try calculating the value based on the data and get the correct expected output.


I had it that way, it actually failed the rspec test.


This change breaks "make small_integration_test" for me:

AssertionError: Unexpected table count on test_nj-0000062352 (not 2): (('vt_select_test0',),)

=> only table "vt_select_test0" is seen.

I have the latest master. Do I need to do anything else than "make build"?


New syntax moment! L is the lower bound of whatever is in HList ???


You can get away without using mocks here.

```ruby
  enemy = Barracks.new
  @footman.attack!(enemy)
  expect(enemy.health_points).to eql 995
```

The advantage of doing things this way, is that your test no longer depends on the damage method. This makes the test less brittle (less likely to break as you make changes to your code).


Как-то некорректно получается. Вывод будет напрямую зависеть от величины, которую мы здесь напишем. Можем ли мы жить с inf?


L'orientation est choisie plus tard (lors du Layout).
Si on indique un format paysage (dans les valeurs), alors sélectionner "paysage" lors de la création du layout va créer une page en portrait!

Je suis d'accord que corriger silencieusement n'est pas forcément top, mais si j'indique l'erreur, l'*unique correction* consiste à échanger les valeurs de `width` et de `height` à la main (sachant que c'est la seule correction possible, je la corrige sans l'indiquer à l'utilisateur).
> "mais pourquoi j'arrive pas à créer un carnet en paysage !!!"
La sélection de l'orientation intervient lors du Layout (et non du papersize).


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


Great to hear =)
I transferred most of my packages to the newest Julia master.
The difficulty will be, to make Romeo work with it, as I only made
GLVisualize work with them.
In GLAbstraction, GLWindow, GLFW this should be in the Julia04 branch. The
rest should work with the master branch.
Are you using any edit functions yet? If not, it should actually be quite
easy to integrate GLVisualize into Romeo, as this is the last thing that is
missing.
I might give it a try tomorrow.

Best,
Simon

2015-05-06 23:27 GMT+02:00 AlainLich <notifications@github.com>:

> Hi,
> things went well:
>
>    - Reactive got fixed
>    - My XML (enabling for inline Julia code in XML) went faster than
>    expected, with much help from *JuliaParser*
>
> So I am interested to access a coherent set of
> GLAbstraction/Romeo/GLxxx... working with the new Tuples. (In order to get
> my XML integrated, I have loaded several of your newer branches, but there
> are still issues like the following
>
> ERROR: LoadError: LoadError: LoadError: MethodError: `normalize` has no method matching normalize(::GeometryTypes.Vector3{Float32})
>  in lookat at /home/alain/.julia/v0.4/GLAbstraction/src/GLMatrixMath.jl:144
>  in call at /home/alain/.julia/v0.4/GLAbstraction/src/GLCamera.jl:335
>  in call at /home/alain/.julia/v0.4/GLAbstraction/src/GLCamera.jl:235
>  in createwindow at /home/alain/.julia/v0.4/GLWindow/src/reactglfw.jl:405
>  in include at ./boot.jl:250
>  in include_from_node1 at loading.jl:129
>  in include_all at /home/alain/.julia/v0.4/Romeo/src/utils.jl:4
>  in include at ./boot.jl:250
>  in include_from_node1 at ./loading.jl:129
>  in reload_path at ./loading.jl:153
>  in _require at ./loading.jl:68
>  in require at ./loading.jl:51
>  in include at ./boot.jl:250
>  in include_from_node1 at loading.jl:129
>  in process_options at ./client.jl:308
>  in _start at ./client.jl:407
> while loading /home/alain/.julia/v0.4/Romeo/src/display/renderloop.jl, in expression starting on line 31
> while loading /home/alain/.julia/v0.4/Romeo/src/Romeo.jl, in expression starting on line 45
> while loading /home/alain/src/Julia/Romeo.jl/test/RomeoVolume.jl, in expression starting on line 3
>
> )
>
> Best
> Alain
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SimonDanisch/Romeo.jl/commit/1096656709a90fb5fcdb422e5dde558321467592#commitcomment-11075387>
> .
>


Please remove "^" and exchange it with the url encoded value of "%5E".


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Update "about" page #61


Great use of a mock!


send my opt.cpp correct for linux please

2015-05-06 22:38 GMT+02:00 snino64 <notifications@github.com>:

> Yo hablo español.
> Me da error la compilación.
> La parte del código para activar large pages no compila como lo tienes
> tu.Pero con los cambios que propongo logro compilarlo correctamente y
> parece funcionar correctamente.
> Saludos
> I speak Spanish.
> I get error when compiling.The part of the code to enable large pages not
> compile as you have.
> But with the changes I propose achievement compile correctly and seems to
> function properly.
> regards
>
>
>
>
> El Miércoles 6 de Mayo de 2015 21:03, Marco Zerbinati <
> notifications@github.com> escribió:
>
>
> do not use linux ..
> tried to compile?
> give error?
> Enable large pages in the operating system?
>
> 2015-05-06 17:20 GMT+02:00 snino64 <notifications@github.com>:
>
> > I can not compile deepfishz in linux.
> > I made some corrections and now if I can compile.
> > Are changes correct?
> >
> > /*
> > Stockfish, a UCI chess playing engine derived from Glaurung 2.1
> > Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
> > Copyright (C) 2008-2015 Marco Costalba, Joona Kiiski, Tord Romstad
> >
> > Stockfish is free software: you can redistribute it and/or modify
> > it under the terms of the GNU General Public License as published by
> > the Free Software Foundation, either version 3 of the License, or
> > (at your option) any later version.
> >
> > Stockfish is distributed in the hope that it will be useful,
> > but WITHOUT ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > GNU General Public License for more details.
> >
> > You should have received a copy of the GNU General Public License
> > along with this program. If not, see http://www.gnu.org/licenses/.
> > */
> > #include
> > #include //<-----
> >
> > #include "thread.h"
> > #include "tt.h"
> >
> > using namespace std;
> >
> > #define TRUE 1
> > #define FALSE 0
> >
> > int large_use;
> >
> > #ifndef _WIN32 // Linux
> > #include
> > #include
> >
> > static int num;
> >
> > #define MEMALIGN(a, b, c) posix_memalign ((void**) &(a), b, c)
> //<--------
> > #define ALIGNED_FREE(x) free (x); //<--------
> >
> > void SETUP_PRIVILEGES(){} //<--------
> >
> > void CREATE_MEM(void** A,int align,uint64_t size)
> > {
> > large_use=FALSE;
> >
> > num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
> > if(num==-1)
> > {
> >
> > // printf("info string LargePages FAILED %llu Mb\n",size>>20);
> > std::cout << "info string LargePages FAILED %llu Mb\n" << (size >> 20) <<
> > std::endl;
> > MEMALIGN((
> >
> >
> >
> > *A),align,size); } else { (*A)=shmat(num,NULL,0x0);
>
> > large_use=TRUE;
> > // printf("info string LargePages OK %llu Mb\n",size>>20);
> > std::cout << "info string LargePages OK %llu Mb\n" << (size >> 20) <<
> > std::endl;
> > std::cout<<"info string HUGELTB "<<(size>>20)<<std::endl;
> > }
> > }
> >
> > void CREATE_MEM2(void** A,uint64_t size)
> > {
> > large_use=FALSE;
> > num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
> > if(num!=-1)
> > {
> > (*A)=shmat(num,NULL,0x0);
> > large_use=TRUE;
> > // printf("info string %llu Mb LargePages\n",size>>20);
> > std::cout << "info string %llu Mb LargePages\n" << (size >> 20) <<
> > std::endl;
> > }
> > }
> >
> > void FREE_MEM(void* A)
> > {
> > if(!A)
> > return;
> > if(!large_use)
> > {
> > ALIGNED_FREE(A);
> > return;
> > }
> > shmdt(A);
> > shmctl(num,IPC_RMID,NULL);
> > large_use=FALSE;
> > }
> >
> > #else
> >
> > Thanks
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Zerbinati/DeepFishMZ/commit/30f2afc3e63eb03b2a5c2a30b972fa55372f2f71#commitcomment-11067845
> >
>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Zerbinati/DeepFishMZ/commit/30f2afc3e63eb03b2a5c2a30b972fa55372f2f71#commitcomment-11074393>
> .
>


Pour les marges, pourquoi pas (voir ce que font les éditeurs de texte par défaut).
Pour `width` et `height`, je vois pas trop ce qu'on pourrait mettre comme valeur par défaut pertinente


It's a public repository. Don't do commit with message like this one.


The `log_url` evaluates to `/svc/log/:node_id`, which has historically been a GET. The render time being long before the script is executed makes it a bit tricky to put dynamic arguments in there.


I've updated this for perl > 5.6.0

I forked from gitpan/File-Download


Actually, it looks like this gives something like "time: 00:00:14.5678". That's fine just the way it is then.


I copied this from the [PathMatchers](https://github.com/spray/spray/blob/c76b75370f231f151df2283d300a9bcfdc6f2a9c/spray-routing/src/main/scala/spray/routing/PathMatcher.scala).

I suspect the generics syntax I'm looking for to concatenate two routes may exist in that file, but didn't manage to get it right yet. Need to move on for now though to get some versioning in vault endpoints.


master (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Does this happen if we return to main menu? What if main menu doesn't have music file attached? Will map mussic continue playing? Just asking if nothing is changed in game behavior by this change.


nit: "invalid image information from rkt images" more context when this error occurs


每个Exception在哪里建立，我昨天就想知道这个问题。是在那个DePaul.StockExchange下面吗？


Refactor these to use `let` to keep things consistent. Ex: `let(:gold) { barracks.gold }`.  Personally, I think it's more readable to just call `barracks.gold` instead of setting these variables.


Why are we resetting `id` to 0 here?


Move this function into `rkt_linux.go` Keeping the whole implementation in one file makes it easy to stub with build labels


Could you try reverting this one line in the changes back to your 66.66.66.10 network and see if that helps. This is the only change that I think could be causing the problem of a hang when trying to mount NFS.
Also, make sure you have done 'sudo nfsd enable' to enable your local NFS daemon. If your problem is the last point, then the IP address will not matter.


this makes all images use the asset token from the background_browser.gif, which fails to work.


这个如何实现？是单独新建一个class下么？求大哥明示


master (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Consider not using a mock here. Same reason as in previous comment. Makes the test case more brittle.


This was made, such that if the radar is changed (new file is open), the window update to show the elevations of the new radar.


这个函数如何override？我不太会写。


This could get very expensive, fine for now but something to keep in mind.


It doesn't look like this was auto-formatted - this lines is long, and the K&R template puts the `{` on the end of the previous line, not on a line of its own.

(Much as I personally prefer having the braces line up, consistent formatting helps keep the code legible.)


That'll be tough based on the data we get from the RTM (real-time-messaging api) - messages in channel don't show a @username, or even <username> - just the internal user ID:

```
{ type: 'message',
  channel: 'C024KETLD',
  user: 'U04HGB2L1',
  text: 'damn str8',
  ts: '1430948048.000203',
  team: 'T024KETL7' }
```

I do have better karma regex in now though: https://github.com/Lullabot/lubot/commit/7616e0ad9a8924880860a3c90b965f041ca22adc


This looks wrong `setShouldpresentloadingviews`


If a file is in the process of being written, another peer should not interfere. Imagine a scenario in which a peer writes a huge file and another peer opens the half-written file and tries to write his own context even though the other peer is not done yet. Causes trouble (not to mistaken with vDHT scenarios).
There is already a newer commit which addresses this issue.
We'll discuss it tomorrow, anyway.


88737258-EPW-Ruby-Access (jasondegraw) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


It's currently breaking the CMF, would like to see if 1.x really isn't supported anymore


Funny... it doesn't look like this file is used anywhere at all.  It still refers to a top-level <Group-Store> element.  Our existing entity XML files would not validate against the existing version of this file.


Good. I was hopping doing the same.


那借口的名字是不是咱们自己起名？我看老师描述里没有具体说明。


能放在implementation里么？


You might want to consider updating this to use `https://golang.org/pkg/net/#JoinHostPort`.


This camera and camera rig code is just unnecessary overhead when using the `loadModel()` API.


Syntax highlighting should indeed work - using GFM fenced code blocks. (The liquid-based highlighting does not work).


Don't pull from WordPress.org SVN - our canonical repos are always in git. You should only push to SVN, otherwise all previous development done in git master is lost.

Also a good tip is to run 'git diff' before commits so you see what you are actually commiting. Can you please clean this up and rebase your changes on the git master that was there before? Thanks


Hi,

I will check tomorrow whether I am in the right branches as you indicate.
I have not tried **edit** for a while, so I had rather move straight to the new version.


```
$ mocha test/support.js test/API-loopback-token-searchTokenKeys.js
  API:Middleware:loopback.token(options)
    options = {} --- DEMO --- DEMO ---
      V Test header=authorization and expect 200
    options.searchDefaultTokenKeys: [true|false]
      V Test header=authorization searchDefaultTokenKeys=false and expect 200
      V Test header=authorization searchDefaultTokenKeys=undefined and expect 200
  3 passing (64ms)
```


could you configure your IDE not to put in wildcard imports? (except for static imports, wildcard static imports are OK)


test cases?


Added https://github.com/Yara-Rules/rules/blob/master/malware/Havex.yar

Thank you @nyx0


1. Should not recommend changing things under the checkout, as that will foul the workspace on upgrade later.
1. Recommending step 3 as you have it then step 2 from your diff with amendments:
  - fix paths so changes are not made in the workspace
  - maybe add a sub-item under "prepare the os-a-d configuration" to replace the example inventory provided for AIOs with an appropriate inventory file to be explicit about that step and provide guidance.


Also a note - you can give yourself karma, as right now there is no easy way to tie the message.user to a username coming over the rtm api (silly)


I didn't realize we had to code in any other requirements apart from the rspec ones. Most of this code is not my best work, I could have refactored the hell out of this. Because of time constraints I figured I just had to make it pass the tests.


I would probably be a bit more defensive here with the call to `DownloadString`, to make sure that `Exit 1` is always hit.  The default PowerShell preference is to `Continue` after exceptions are thrown, but that default can be changed in the shell, or you might later add it to a script or the user's profile, in which case the behavior here will change.

This is controlled by `$ErrorActionPreference` and is described at https://technet.microsoft.com/en-us/library/hh847796.aspx

To illustrate, see the following function

```powershell
function DoIt
{
  (New-Object Net.WebClient).DownloadString('http://foo')
  Write-Host 'Can I Hit This Line?'
}
```

Test 1, using default of `Continue`

```
C:\Users\Administrator> $ErrorActionPreference
Continue
C:\Users\Administrator> DoIt
Exception calling "DownloadString" with "1" argument(s): "The remote name could not be resolved: 'foo'"
At line:3 char:1
+ (New-Object Net.WebClient).DownloadString('http://foo')
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : WebException

Can I Hit This Line?
```

Test, using `$ErrorActionPreference` of `Stop`

```
C:\Users\Administrator> $ErrorActionPreference = 'Stop'
C:\Users\Administrator> DoIt
Exception calling "DownloadString" with "1" argument(s): "The remote name could not be resolved: 'foo'"
At line:3 char:1
+ (New-Object Net.WebClient).DownloadString('http://foo')
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : WebException
```


Good catch.


this assumes always x64?


I made the change and the tests pass. What error are you getting?


This is probably fine ... though I _had_ planned to add a `quality` parameter before auto-generating mipmaps.


Ok,Thanks

     El Miércoles 6 de Mayo de 2015 22:37, Marco Zerbinati <notifications@github.com> escribió:

 send my opt.cpp correct for linux please

2015-05-06 22:38 GMT+02:00 snino64 <notifications@github.com>:

> Yo hablo español.
> Me da error la compilación.
> La parte del código para activar large pages no compila como lo tienes
> tu.Pero con los cambios que propongo logro compilarlo correctamente y
> parece funcionar correctamente.
> Saludos
> I speak Spanish.
> I get error when compiling.The part of the code to enable large pages not
> compile as you have.
> But with the changes I propose achievement compile correctly and seems to
> function properly.
> regards
>
>
>
>
> El Miércoles 6 de Mayo de 2015 21:03, Marco Zerbinati <
> notifications@github.com> escribió:
>
>
> do not use linux ..
> tried to compile?
> give error?
> Enable large pages in the operating system?
>
> 2015-05-06 17:20 GMT+02:00 snino64 <notifications@github.com>:
>
> > I can not compile deepfishz in linux.
> > I made some corrections and now if I can compile.
> > Are changes correct?
> >
> > /*
> > Stockfish, a UCI chess playing engine derived from Glaurung 2.1
> > Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
> > Copyright (C) 2008-2015 Marco Costalba, Joona Kiiski, Tord Romstad
> >
> > Stockfish is free software: you can redistribute it and/or modify
> > it under the terms of the GNU General Public License as published by
> > the Free Software Foundation, either version 3 of the License, or
> > (at your option) any later version.
> >
> > Stockfish is distributed in the hope that it will be useful,
> > but WITHOUT ANY WARRANTY; without even the implied warranty of
> > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > GNU General Public License for more details.
> >
> > You should have received a copy of the GNU General Public License
> > along with this program. If not, see http://www.gnu.org/licenses/.
> > */
> > #include
> > #include //<-----
> >
> > #include "thread.h"
> > #include "tt.h"
> >
> > using namespace std;
> >
> > #define TRUE 1
> > #define FALSE 0
> >
> > int large_use;
> >
> > #ifndef _WIN32 // Linux
> > #include
> > #include
> >
> > static int num;
> >
> > #define MEMALIGN(a, b, c) posix_memalign ((void**) &(a), b, c)
> //<--------
> > #define ALIGNED_FREE(x) free (x); //<--------
> >
> > void SETUP_PRIVILEGES(){} //<--------
> >
> > void CREATE_MEM(void** A,int align,uint64_t size)
> > {
> > large_use=FALSE;
> >
> > num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
> > if(num==-1)
> > {
> >
> > // printf("info string LargePages FAILED %llu Mb\n",size>>20);
> > std::cout << "info string LargePages FAILED %llu Mb\n" << (size >> 20) <<
> > std::endl;
> > MEMALIGN((
> >
> >
> >
> > *A),align,size); } else { (*A)=shmat(num,NULL,0x0);
>
> > large_use=TRUE;
> > // printf("info string LargePages OK %llu Mb\n",size>>20);
> > std::cout << "info string LargePages OK %llu Mb\n" << (size >> 20) <<
> > std::endl;
> > std::cout<<"info string HUGELTB "<<(size>>20)<<std::endl;
> > }
> > }
> >
> > void CREATE_MEM2(void** A,uint64_t size)
> > {
> > large_use=FALSE;
> > num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
> > if(num!=-1)
> > {
> > (*A)=shmat(num,NULL,0x0);
> > large_use=TRUE;
> > // printf("info string %llu Mb LargePages\n",size>>20);
> > std::cout << "info string %llu Mb LargePages\n" << (size >> 20) <<
> > std::endl;
> > }
> > }
> >
> > void FREE_MEM(void* A)
> > {
> > if(!A)
> > return;
> > if(!large_use)
> > {
> > ALIGNED_FREE(A);
> > return;
> > }
> > shmdt(A);
> > shmctl(num,IPC_RMID,NULL);
> > large_use=FALSE;
> > }
> >
> > #else
> >
> > Thanks
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Zerbinati/DeepFishMZ/commit/30f2afc3e63eb03b2a5c2a30b972fa55372f2f71#commitcomment-11067845
> >
>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Zerbinati/DeepFishMZ/commit/30f2afc3e63eb03b2a5c2a30b972fa55372f2f71#commitcomment-11074393>
> .
>
—
Reply to this email directly or view it on GitHub.


Hmmm... I'd love to see this xsd fixed and referenced in the entity XML files.  It would make code completion and validation by IDEs easier.


When does the provisioner run? I'm a little concerned that `$env:TEMP` will not yet exist.


Already fixed here: https://github.com/Seravo/wp-simple-header-footer-html/commit/04efd56fc7ef6542238062505af347feacf92cd6


So this took me a bit to unwrap... Please move my_addr[] to options.c instead, that's where it belongs. Ensure that it is visible from server.c, and do the same string copy to assign it. Rename my_addr[] to something more appropriate, so people don't have to grep for it to figure out what it means.

If you do those things, this should be mergeable.


" is the best choices" s/b "is the best choice"


Oh, the rebase. Right.


It's generally easier to work with ports as strings in Go, maybe converting once from an `int` user input (as opposed to many scattered `Itoa` calls).


Use | to join the two Ex commands @gurdiga


Please wrap `open` calls in a with statement.


testign comments


Quit copying me.


@Iristyle I think you need to fix your side by side view... ;)


I will probably change this from
```
foo = {k: v for k, v in zip(bar1, bar2)}
```
to
```
foo = dict(zip(bar1, bar2))
```
seems incrementally more clear since I don't have to double check the order isn't being swapped or something


Instead of taking a `jobId` what about using the `JobId` already available on `Job`?

```go
func (j *Job) Details() (jobDetails *JobDetails, err error) {
  redis.Args{}.Add(j.JobId)
}

job := d.Fetch()
job.Details()
```


dfhdfg


Good point. I'll add `$ErrorActionPreference = Continue` to the top of the script to guarantee that the error reporting occurs.


I'm guessing that there is no proxy issue with any of this? If so you may consider using something a little more bulletproof surrounding the webclient.


Don't worry about it, I wouldn't expect your code to be perfect. You are here to learn and that's what code reviews are for.

Just as a heads up, we do dock marks during the test for improper use of attr_reader and for style, etc, so it is good to get into the habit of following best practices.


@Ricalo agreed


Good suggestions.

It is worth being explicit that /etc/openstack_deployment/openstack_user_config.yml (which dynamic_inventory.py uses to create the inventory) is *NOT* provided at all - that must be made per install.


@gurdiga  Join these in a single set:
```
set shiftwidth=2
set tabstop=2
```


This should be a `GVRAndroidResource`, not a filename.

* `GVRAndroidResource` supports arbitrary paths, such as you might use when downloading models to the app cache directory.
* `GVRAndroidResource` supports `R.raw` identifiers, which is the Android-standard way of putting files in the `res` directory.
* All the other new APIs use `GVRAndroidResource` as the way to avoid overload fan-out.


I don't get why it is necessary, while we already have HAVE_AMT in lib/upipe-amt/Makefile.am ?


Added KeyBoy rules: https://github.com/Yara-Rules/rules/blob/master/malware/KeyBoy.yar

Thank you @nyx0


@shurcooL is right: if there's no arguments, it reads from stdin, same as running `ccat -`. But I like `fnames = []string{"-"}` better and fixed it in https://github.com/jingweno/ccat/commit/4915d9303cf14b863b9accbec4fa920c29dab625


Sample code in the commit message aaaand I forget about the `setCaret` event. Woops.

```javascript
						// Reset FancyInput on these typeahead.js events to keep up with the typeahead appearance
						var update_fi = function(e, obj) {
							jQuery(this).trigger({ type: 'fi.fillText', text: obj.value });
						};
						jQuery.each(['autocomplete', 'cursorchange', 'select'],
							function(index, event_name) {
								jQuery('.tt-input').on('typeahead:'+event_name, function(){
									console.log('typeahead:'+event_name+': ', arguments);
									update_fi.apply(this, arguments);
								});
							}
						);
						// Reset the cursor position (tends to go to the beginning if a suggestion is selected by the mouse)
						jQuery('.tt-input').on('typeahead:close', function(e) { jQuery(this).trigger('setCaret'); });
```


master (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The change to line 60 of package.json breaks my ability to build this


This seems to give around a three times speed up on some of my examples. I wonder if it is just the true and false that is hitting, or if other more complex path conditions are being checked more than once. Perhaps the two different versions often have the same path conditions, so each one may be checked twice.


public void mostrar(){
System.out.println("RUT"+rut);
}


dsfsfsd


Atualiza com projeto original


370-371 got left behind in the chop


Added this rule to: https://github.com/Yara-Rules/rules/blob/master/malicious_document.yar

Thank you @nyx0


Good feature. Why a single "enable" for both Depth and Confidence?
I would separate it into two enables


(깃허브 답글이없는듯해서 여기에올립니다)
메모리값이 다르다고하는데요 컴파일에도문제가없고 멀티롬도멀쩡히작동합니다 이러면굳이수정할필요가없는건가요


master (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is there a way to dynamically determine architecture for this? Do we do that anywhere?


@paltman don't worry, this is still work in progress, this file will be removed but it is helpful for getting the layout the way I want. This CSS file is a part of a design resource.


This will run after the OS install completes, from inside a SetupComplete.cmd file.


Fixing and pushing.


Use ShortMessage.NOTE_ON and don't forget to deal with the note-off case too.


[GitHub won't let me add comments on lines 324 and 330.]

* [Line 324] You should probably at least cache a `SoftReference` to this default `Bitmap` and/or allow the user to supply their own default `Bitmap`; this code (is synchronous and) does not close its stream.
* [Line 330] On top of all my other doubts about loading a whole scene (as opposed to a scene object) this seems like the wrong semantics: the method should return a `GVRScene` that the user can pass to `setMainScene()` at the right time.


master (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Take your version to 0.4.10, .9 includes the updated shorter calls to quote. https://github.com/gregwinn/ystock/commit/b9c7482d0b21c14585ede45838765a6ddd2f4a34


I don't understand why this particular tool needs to read from HML.

In keeping with the unix tradition of one tool per task, why not just use ```ngs-extract-expected-glstring``` or ```ngs-extract-expected-haploids``` as necessary and pipe the output into this tool?


master (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Same comments as for `loadScene()` plus (as I've already noted) this is sort of inefficient, creating cameras, camera rigs, and transforms ... that are never used.


Think could be resolve when we are able to do `rkt image cat-file` or so on.
https://github.com/coreos/rkt/pull/649

Will add a todo here.


What about KIR?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.86](http://teamcity.monogame.net/viewLog.html?buildId=7037&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


It looks like the previous version of the broker did not need to choose an architecture.


code for this match service url argument exists but I don't see any calls to the service being made


master (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


what about HLA-DQA1?  DRB345?


Probably because we didn't have a choice with Windows.


Added https://github.com/Yara-Rules/rules/blob/master/malware/Miancha.yar

Thank you @nyx0


The example inventory (openstack_user_variables.yml.example) won't be executable. The deployer will have to provide their own.

Currently, we have a tool for generating these for RAX data center deploys, but for customer data centers, it's manually writing the file as far as I know.


That's a slippery slope, since it should *probably* be user configurable.

You can get the process width with `[IntPtr]::Size`.  If it's `8` the process is `64-bit`, otherwise `32-bit`.

You can get the OS with WMI by `Get-WmiObject -Class Win32_OperatingSystem | Select-Object -ExpandProperty OSArchitecture` which will return something like `64-bit`


got you


asdsad


Ah, this is cleaner than the previous situation. I would have thought that it would be better to have this as a separate commit, since first we "brute-forced" the download of the English subtitles and now we only download those that are declared, but that's and I merged that.

This kind of change in behavior/algorithm would be best factored out in a separate commit to make things easier to find bugs via `git bisect`.


Since the fix to this is not obvious and the first-run experience is currently really poor, I'm going to revert this for now.


Если inf будет происходить в случае, когда метод не сходится, то можем и даже, пожалуй, хотим.
Если же мы небезуспешно учимся, то хотелось бы, чтобы loss усреднялся. В случае же таких вылетов average loss получается inf и не усредняется.
* стоит отметить, что сейчас это происходит только на нулевом запуске, когда веса все нулевые. Можно для него банально не вычислять loss, но нельзя исключать, что это может появиться где-нибудь ещё (если все фичи категориальные, то такое запросто может произойти несколько раз).
* btw, если мы оптимизируем logloss, то предсказывать вероятность 0 или 1 -- не очень хорошая идея независимо от нашей уверенности.


test cases are in a later commit


If you're using PowerShell 3 (which has .NET 4), then you can also rely on `[Environment]::Is64BitOperatingSystem` which returns a boolean and is faster / simpler than the WMI approach above


Then you should be fine. I know with choco - folks using packer were reporting stuff wasn't available yet. https://github.com/chocolatey/chocolatey/commit/9c630d3cc46f5e86b18cd2b2b4150215f105a956


there's also -ms-flexbox :grin:


This will not work. The OS X regex return an array with Vendor/Product ID.


Variable Unification I meant..


Fulfills specification


Or you can try catch :)


Added https://github.com/Yara-Rules/rules/blob/master/malware/APT_Mirage.yar

Thank you @nyx0


@vmarmol Actually I found since we removed rkt.store, now we should not have dependency on linux specific stuff. We don't need to do the labels now I think.


Nit: when I ran locally there were two locations that didn't get filled in, presumably because they didn't map to anything. That's OK. I'd just put a test for that case here (404, presumably) and console.log here as well so you knew that it tried to look up something and didn't find it.


I suggest to rollback to the old method for OS X


```
$ mocha test/support.js test/API-loopback-token-searchDefaultTokenKeys.js

  API:Middleware:loopback.token(options)
    options = {} --- DEMO --- DEMO ---
      V Test header=authorization and expect 200
    options.searchDefaultTokenKeys: [true|false]
      V Test header=authorization searchDefaultTokenKeys=false and expect 200 (4
6ms)
      V Test header=authorization searchDefaultTokenKeys=true and expect 200
      V Test header=authorization searchDefaultTokenKeys=undefined and expect 200

  4 passing (78ms)
```


lets purge this last item since it really is covered above.


Ok.


FindMethod?


Thanks!


Thanks :D


as I remember, the startup file wasn't for free advertising.


would drop the line about renaming it "if you want to use it" since it won't be correct for anyone ever.  That line would work pretty well for mention of the yml.aio though.


@shurcooL that's true. I guess it was just a little 'code smell' which is why it looked a bit odd :-)


should name where the logstash block is (user_extra_variables)


Added to https://github.com/Yara-Rules/rules/blob/master/malware/Miscelanea_Linux.yar

Thank you @nyx0


LGTM


:+1:

Please ticket out to re-enable them at some point once this lands.


Merged.


@mekolat I updated the tiled npc to be a bit simpler.
rotation does direction
Area of object does trigger size
Any multiple generic function NPC should be specific (Bank, Soul Menhirs, Shops, etc.) More will most likely be added to the list.


throwOnError doesn't mean the API doens't throw :(


Ok it is then.


ditto Ok it is then.


asdsad


Added to https://github.com/Yara-Rules/rules/blob/master/malware/Miscelanea.yar

Thank you @nyx0


Thanks for the help @graemian, it should be fixed now with the patch `3.0.3_1`.

Cheers,
Luca


Should this be com.google.inject.Inject? There seems to be some inconsistency in the project (ServiceResource vs ReplicatedDynamicStore, for example), and neither seems to be explicitly declared in any of the poms.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.86](http://teamcity.monogame.net/viewLog.html?buildId=7037&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:19:33


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.87](http://teamcity.monogame.net/viewLog.html?buildId=7041&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Ok.


sdfdsf


I believe the idea is to use `javax.inject.Inject` in new code where possible. The google one is needed for optional injections, though.


I use dispatch_once for that. Is that an atomic call?


:+1: works for me.


Hi Thomas, I see you changed the way the buffer is cleaned. Did you find any bug? or why did you perform the change?
 In case there is something wrong I'd like to fix It in my code as well. Thanks!


Merci pour le lien.

J'ai cherché les logs, impossible à trouver... et j'suis tombé sur un forum en anglais aussi où un gars dit qu'il ne trouve pas les logs non plus... donc j'ai abandonné.

j'ai passé le user qui sert à lancer sickbeard dans le groupe admin... j'ai fait un premier test non concluant... j'ai tout relancé (sans être persuadé que ça change qq chose)...  j'ai recommencé... et là mes 2 dl sont "en attente"... j'en ai marre d'attendre il est tard, je verrai demain ce que ça donne.


@tdhock maybe `remDr$getCurrentUrl()` would be more robust?


fixed.


need error checking


Возможно, если инициализировать веса нулями вместо единиц, то проблемы не станет, а возможно и станет. Проверю. (но такая зависимость от начальной точки -- это в любом случае печально, особенно если все поля категориальные)
И, как бы то ни было, хотелось бы иметь свойство усредняемости average loss. Которое пропадает, если мы допускаем inf.


We don't need this property


Ok, added a log message for that.


wtf, i will fix this, standby


You need to remove the two lines that try setting this property as well. They're not needed. I forgot to delete them when I was messing around


That's not very nice.


This seems to be unused now.


Couldn't find 1/3, do you remember it's location?


Why this width?


Capitalize 'override'


No behavior was changed.

We stop the map music here: https://github.com/clintbellanger/flare-engine/blob/8bf9b22386c30a1004e14387ff95d23c99d7b5dd/src/GameStatePlay.cpp#L356

Only GameStatePlay has the `hasMusic` flag set to true, so the following block is used to load the default music when we return to GameStateTitle: https://github.com/clintbellanger/flare-engine/blob/8bf9b22386c30a1004e14387ff95d23c99d7b5dd/src/GameSwitcher.cpp#L112


contional -> conditional


Shouldn't that be "in our own settings directory" or something like that. "our how directory" sounds just plain weird.


Have you looked at a blame before you made that comment?


Why this line width?


Maybe the commit message can help?


navigtaion -> navigation


I'm not sure about proxy issues here, @ferventcoder. What is the alternative to System.Net.WebClient if we take those into account?


Ok, hopefully the last commit (at least for a bit).

Very significant changes, as mentioned in the commit msg.


Yes - I was not thinking earlier.


Typo


Sounds good, I still find it being in one file to be easier overall, but it could just be me :D


@dkranz @eggmaster @queria
This should be also pushed to master, otherwise might get lost in the next release, also Delorean builds will miss it.


Why not calculate the answer to this question at this point instead of parsing the string in verify_answer?
Something like:

```ruby
def random_number(up_to=20)
  1 + Random.rand(up_to)
end

def random_operation
  ["+", "-", "*"].sample # Google array#sample to learn more
end

def generate_question
  num1, num2 = random_number, random_number
  operation = random_operation
  @quesiton = "#{num1} #{operation} #{num2}"
  @answer = num1.send(operation, num2)
end

def verify_answer(guess)
  guessed = @answer == guess.to_i
  if guessed
    winner_message #method
  else
    loser_message #method
  end
  guessed
end
```


Nice :)


rax retry tests


Does it do the same?

`object && Object.getPrototypeOf(object)`;

?


Notice that this could have been a `Game` class that would control the flow of the game.


I noticed a typo in 'build-config.js' on line #28; extra comma. I doubt it will break anything and it's easy to fix so I won't reject the commit.


This @class declaration needs to go above the comment.


Great work!


I'm 99,5% sure `com.anddoes.launcher` mustn't be here as it's ApexLauncher and not Sony
0,5% doubts cause my comment on that was ignore on upstream :)

Works currently cause Apex is before Sony in the list BADGE...


The hyphen is unnecessary, the original string should be just fine in the case of the english language.


This needs to explain what a trigger step is.


"You" usually means the developer. Instead I'd say "the participant" or "the user"? Rather than "about to leave", I'd say "continuing forward from" perhaps?


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/11753/testReport/) for this commit**


Why are you using an array of objects instead of creating an Ext.Button like [other tools](https://github.com/geosolutions-it/MapStore/blob/master/mapcomposer/app/static/externals/mapmanager/src/mxp/plugins/TemplateManager.js#L49) ?
This way the resulting [removeActions()](https://github.com/geosolutions-it/MapStore/blob/master/mapcomposer/app/static/externals/mapmanager/src/mxp/plugins/Tool.js#L476) method fails to remove it.


It seems that all processors will have the same m_load_prefix, because m_load_prefix is broadcasted when dmrginp is broadcasted.


Yes my bad, I broke it. Will have a fix shortly.

On Wed, May 6, 2015 at 2:30 PM, Michael Berlin <notifications@github.com>
wrote:

> This change breaks "make small_integration_test" for me:
>
> AssertionError: Unexpected table count on test_nj-0000062352 (not 2):
> (('vt_select_test0',),)
>
> => only table "vt_select_test0" is seen.
>
> I have the latest master. Do I need to do anything else than "make build"?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/youtube/vitess/commit/2e819961fe2613466d06b2d97ec19d2e6a4bc8d4#commitcomment-11075450>
> .
>


Overall not sure of the naming of "triggerStep", since the step is not really the trigger; the step is just the step to which the rule is bound. But I think we'll take care of this in API review once your PR is up.


Do you mean how to set it up in the `.jscsrc` config file?

```js
{
  // from
  "requireCamelCaseOrUpperCaseIdentifiers": true
  // to
  "requireCamelCaseOrUpperCaseIdentifiers": "ignoreProperties"
}
```


Authoritative source for referential BofM materials.


Since this is just for namespacing, perhaps mark `init` unavailable?


I'd like us to start conforming to the Wordpress coding standards in our work:

https://make.wordpress.org/core/handbook/coding-standards/css/#selectors

Please see the section on "Selectors." It suggests avoiding underscores in selector names. Will that be ok? After a quick review I think that's the only change I'll want to make that affects the rest of the work you're doing - everything else seems to be spacing changes.


wtf


Again, move these above the comment.


cooncrete -> concrete


A simple way to jump directly to search form is calling the function '$.generate_static_form(tag, storage_id) `
For example:
```javascript
$.generate_static_form('mcpd:SAMPSTAT', '675dc7e1718c48e8ec81607aa62188ea');
```


use FileTest's delete method here once rebased


Cool.


I think we'll need one of these two. The above is what we had. The below is what edX had. If we delete both, we're no longer asserting the contents of the response.

I _think_ we want theirs.


The username was previously used in GiveItem() to produce the error message; but now that's done in Handle(), so I don't see the use in getting it within GiveItem(): I think the line can be safely deleted.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.87](http://teamcity.monogame.net/viewLog.html?buildId=7041&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:20:56


Q: would it be possible take a screenshot only of the selector itself and not the whole page? so the test would only fail when the selector itself is broken


NULLABLE is not a keyword. Simply omit it.


fusion3.mk GPS lines are removed because I had moved their building in msm8960.mk


Change to a TINYINT UNSIGNED, so we can store 0 for false and 1 for true.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7218/testReport/) for this commit**


That's correct, assuming you have that wrapped in the `wp_enqueue_scripts` action hook.


Instead of FLOAT, use DECIMAL.


My apologies if I pointed this out in a confusing way: I'm still getting used to communication via GItHub. I welcome your suggestions.


It seems like the most robust way to deal with this is via something like:
```
if ((Get-WmiObject -Class Win32_OperatingSystem | Select-Object -ExpandProperty OSArchitecture) -eq '64-bit') {
    $arch = 'x64'
} else {
    $arch = 'x86'
}
```


A bit pedantic, but the doctype should be first.


I don't know if you've tried compiling it yourself or if you're still using v2.7.5.2, but I've not released a compiled version with this fix yet.


Missing the "/" to close the em tag.


Make all primary/foreign keys INT UNSIGNED.


no good reason, this should be fine


Omit UNIQUE. Later in the CREATE TABLE statement, put:
UNIQUE(email)


@rwjblue thanks :)


center is not a valid property of float. You can follow these instructions to learn how to center content:
https://css-tricks.com/centering-css-complete-guide/
(It's a lot harder than it should be, right?)


I'd use `ork_initWithResultPredicates` to follow the pattern elsewhere, instead..


For all your weak entities (such as here in productOrder), add both key fields as a primary key:
PRIMARY KEY(orderId, productId)


Ah, ok, maybe just double check it does fail in the way you expect if you mistype a tag


yeah!


Andimal: I don't agree with this. If there is a conditional that applies to a block that is 4 lines long, it should be stated before reading through the whole block.


¿No hay que usar migrations de Doctrine para hacer la actualización?


Could this be the cause of https://github.com/minetest/minetest/issues/2678 ?


Heh indeed. I think i'll decomission the zip releases with the next release. Thoughts?


There's no comma here.  @matthewp Did you verify this runs?


Every single line of this commit is broken.


1. I'm not sure I can see the need for this blocking API aside from its use in your code: while, yes, it does use `GVRAsynchronousResourceLoader.decodeStream()` so it won't crash on large bitmaps,  there generally isn't much need to load bitmaps as bitmaps. We already have a blocking `loadTexture(GVRAndroidResource)` method, and we have `loadTexture(TextureCallback, GVRAndroidResource)` and `loadFutureTexture(GVRAndroidResource)` which asynchronously load either bitmaps or compressed textures.
2. If we really do need this as an API method, it really should be `loadBitmap(GVRAndroidResource)`. This would be more compatible with the rest of the GVRF API, and is also more flexible.


Need to close h4 tag.


Please don't use abbreviations.


Need to close this nav tag.


* Not auto-formatted.
* Should only call `indexOf()` once.


Values of 0 don't need units.


We generally use lowercase names for folders, so "css" rather than "CSS".


If I try to select just the selector, it will capture the 25, but not the popup.


this spell has the same name as the one above it


this does not make it bounce, this just makes it hit multiple enemies at once.


[![Lintel with Vishnus and Celestial Musicians](http://api.artsmia.org/images/5110/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5110)


[![Palanquin Hooks](http://api.artsmia.org/images/3675/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=3675)


[![Ritual Conch Shell with a Dancing Hevajra](http://api.artsmia.org/images/4225/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4225)


[![Torso of a Dancing Faun](http://api.artsmia.org/images/1801/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1801)


[![Mnemonic Headress](http://api.artsmia.org/images/122905/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122905)


[![Landscape with Figures under Pollarded Trees](http://api.artsmia.org/images/29292/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=29292)


[![Plan of the Garden and Views of the Dwellings at Chiswick](http://api.artsmia.org/images/54735/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=54735)


[![Venus figure](http://api.artsmia.org/images/11949/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11949)


[![St. Jerome](http://api.artsmia.org/images/11955/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11955)


[![Saint Francis of Assisi Receiving the Stigmata](http://api.artsmia.org/images/115628/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115628)


[![Anatomical Man (EcorchÃ©)](http://api.artsmia.org/images/1404/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1404)


[![Florence or Venus](http://api.artsmia.org/images/11947/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11947)


[![Fully-articulated human skeleton: #Z81:21:1](http://api.artsmia.org/images/122944/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122944)


[![Human skull: EDU:Skull 1](http://api.artsmia.org/images/122945/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122945)