1: D100 Missing docstring in public module
23:1: I101 Imported names are in the wrong order. Should be cPickle, calendar, cgi, commands, datetime, os, random, time
23:16: E401 multiple imports on one line
23:1: E402 module level import not at top of file
24:1: E402 module level import not at top of file
25:1: I101 Imported names are in the wrong order. Should be CFG_BIBCIRCULATION_ILL_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CLAIMED, CFG_BIBCIRCULATION_ITEM_STATUS_IN_PROCESS, CFG_BIBCIRCULATION_ITEM_STATUS_NOT_ARRIVED, CFG_BIBCIRCULATION_ITEM_STATUS_ON_LOAN, CFG_BIBCIRCULATION_ITEM_STATUS_ON_ORDER, CFG_BIBCIRCULATION_ITEM_STATUS_ON_SHELF, CFG_BIBCIRCULATION_ITEM_STATUS_OPTIONAL, CFG_BIBCIRCULATION_REQUEST_STATUS_DONE, CFG_BINDIR, CFG_CERN_SITE, CFG_SITE_NAME, CFG_SITE_URL, CFG_TMPDIR
25:1: I201 Missing newline before sections or imports.
25:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: I101 Imported names are in the wrong order. Should be get_collection_reclist, get_most_popular_field_values, perform_request_search, search_pattern
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.utils.url
42:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: I101 Imported names are in the wrong order. Should be book_information_from_MARC, book_title_from_MARC
50:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.utils should be before from invenio.legacy.websubmit.admin_dblayer
50:1: E402 module level import not at top of file
52:1: I101 Imported names are in the wrong order. Should be get_borrower_data, get_id_bibrec
52:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.db_layer should be before from invenio.legacy.bibcirculation.utils
52:1: E402 module level import not at top of file
55:1: I101 Imported names are in the wrong order. Should be convert_datestruct_to_dategui, convert_datetext_to_datestruct
55:1: E402 module level import not at top of file
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.date
56:1: E402 module level import not at top of file
59:38: E261 at least two spaces before inline comment
64:1: E302 expected 2 blank lines, found 1
64: D401 First line should be in imperative mood ('Return', not 'Returns')
64: D400 First line should end with a period (not 'r')
64: D205 1 blank line required between summary line and description (found 0)
88:25: E128 continuation line under-indented for visual indent
92:29: E128 continuation line under-indented for visual indent
92:61: E251 unexpected spaces around keyword / parameter equals
93:29: E128 continuation line under-indented for visual indent
94:29: E128 continuation line under-indented for visual indent
105:27: E128 continuation line under-indented for visual indent
108: D401 First line should be in imperative mood ('Return', not 'Returns')
108: D202 No blank lines allowed after function docstring (found 1)
130:29: E128 continuation line under-indented for visual indent
131:29: E128 continuation line under-indented for visual indent
145: D210 No whitespaces allowed surrounding docstring text
145: D209 Multi-line docstring closing quotes should be on a separate line
145: D400 First line should end with a period (not 's')
145: D205 1 blank line required between summary line and description (found 0)
154:29: E128 continuation line under-indented for visual indent
155:29: E126 continuation line over-indented for hanging indent
161:27: E128 continuation line under-indented for visual indent
164: D401 First line should be in imperative mood ('Return', not 'Returns')
164: D202 No blank lines allowed after function docstring (found 1)
164: D400 First line should end with a period (not 't')
164: D205 1 blank line required between summary line and description (found 0)
183:17: E128 continuation line under-indented for visual indent
184:29: E128 continuation line under-indented for visual indent
187: D401 First line should be in imperative mood ('Return', not 'Returns')
187: D400 First line should end with a period (not 't')
187: D205 1 blank line required between summary line and description (found 0)
209:13: E128 continuation line under-indented for visual indent
212:13: E128 continuation line under-indented for visual indent
212:44: E251 unexpected spaces around keyword / parameter equals
213:13: E128 continuation line under-indented for visual indent
217: D401 First line should be in imperative mood ('Return', not 'Returns')
217: D400 First line should end with a period (not 'n')
217: D205 1 blank line required between summary line and description (found 0)
237:21: E128 continuation line under-indented for visual indent
238:21: E128 continuation line under-indented for visual indent
242:21: E128 continuation line under-indented for visual indent
243:21: E128 continuation line under-indented for visual indent
247:25: E128 continuation line under-indented for visual indent
249:25: E128 continuation line under-indented for visual indent
258: D401 First line should be in imperative mood ('Return', not 'Returns')
258: D400 First line should end with a period (not 't')
258: D205 1 blank line required between summary line and description (found 0)
281:17: E128 continuation line under-indented for visual indent
301:27: E128 continuation line under-indented for visual indent
304: D401 First line should be in imperative mood ('Return', not 'Returns')
304: D400 First line should end with a period (not 't')
304: D205 1 blank line required between summary line and description (found 0)
322:13: E128 continuation line under-indented for visual indent
325: D401 First line should be in imperative mood ('Return', not 'Returns')
325: D400 First line should end with a period (not 'r')
325: D205 1 blank line required between summary line and description (found 0)
347:17: E128 continuation line under-indented for visual indent
351:17: E128 continuation line under-indented for visual indent
358: D400 First line should end with a period (not ':')
358: D205 1 blank line required between summary line and description (found 0)
429:37: E126 continuation line over-indented for hanging indent
430:10: E261 at least two spaces before inline comment
467: D400 First line should end with a period (not ':')
467: D205 1 blank line required between summary line and description (found 0)
576:62: E502 the backslash is redundant between brackets
577:23: E128 continuation line under-indented for visual indent
588:13: E128 continuation line under-indented for visual indent
589:13: E128 continuation line under-indented for visual indent
590:13: E128 continuation line under-indented for visual indent
591:13: E128 continuation line under-indented for visual indent
597:13: E128 continuation line under-indented for visual indent
598:13: E128 continuation line under-indented for visual indent
599:13: E128 continuation line under-indented for visual indent
600:13: E128 continuation line under-indented for visual indent
601:13: E128 continuation line under-indented for visual indent
606: D400 First line should end with a period (not ':')
606: D205 1 blank line required between summary line and description (found 0)
674: D400 First line should end with a period (not ':')
674: D205 1 blank line required between summary line and description (found 0)
700: D401 First line should be in imperative mood ('Return', not 'Returns')
700: D400 First line should end with a period (not 's')
718:17: E128 continuation line under-indented for visual indent
720:17: E128 continuation line under-indented for visual indent
724:17: E128 continuation line under-indented for visual indent
725:17: E128 continuation line under-indented for visual indent
729:25: E128 continuation line under-indented for visual indent
731:25: E128 continuation line under-indented for visual indent
740: D400 First line should end with a period (not ':')
740: D205 1 blank line required between summary line and description (found 0)
838: D400 First line should end with a period (not ':')
838: D205 1 blank line required between summary line and description (found 0)
867:21: E127 continuation line over-indented for visual indent
898: D401 First line should be in imperative mood ('Return', not 'Returns')
898: D400 First line should end with a period (not 't')
898: D205 1 blank line required between summary line and description (found 0)
944:19: E128 continuation line under-indented for visual indent
949:19: E128 continuation line under-indented for visual indent
949:66: E225 missing whitespace around operator
953:25: E128 continuation line under-indented for visual indent
955:25: E128 continuation line under-indented for visual indent
964: D400 First line should end with a period (not ':')
964: D205 1 blank line required between summary line and description (found 0)
1015: D202 No blank lines allowed after function docstring (found 1)
1015: D400 First line should end with a period (not ':')
1015: D205 1 blank line required between summary line and description (found 0)
1080: D400 First line should end with a period (not ':')
1080: D205 1 blank line required between summary line and description (found 0)
1123:57: E128 continuation line under-indented for visual indent
1138:9: E128 continuation line under-indented for visual indent
1141: D400 First line should end with a period (not ':')
1141: D205 1 blank line required between summary line and description (found 0)
1200: D400 First line should end with a period (not ':')
1200: D205 1 blank line required between summary line and description (found 0)
1236: D400 First line should end with a period (not ':')
1236: D205 1 blank line required between summary line and description (found 0)
1282:1: E302 expected 2 blank lines, found 1
1343: D400 First line should end with a period (not 'n')
1343: D205 1 blank line required between summary line and description (found 0)
1355:10: E261 at least two spaces before inline comment
1355:11: E262 inline comment should start with '# '
1377:83: E502 the backslash is redundant between brackets
1377:82: E211 whitespace before '('
1378:21: E128 continuation line under-indented for visual indent
1380:82: E502 the backslash is redundant between brackets
1380:81: E211 whitespace before '('
1381:21: E128 continuation line under-indented for visual indent
1383:82: E502 the backslash is redundant between brackets
1383:81: E211 whitespace before '('
1384:21: E128 continuation line under-indented for visual indent
1387:82: E502 the backslash is redundant between brackets
1387:81: E211 whitespace before '('
1388:21: E128 continuation line under-indented for visual indent
1395:1: E302 expected 2 blank lines, found 1
1395: D401 First line should be in imperative mood ('Build', not 'Builds')
1395: D400 First line should end with a period (not 'r')
1395: D205 1 blank line required between summary line and description (found 0)
1447:1: E302 expected 2 blank lines, found 1
1447: D205 1 blank line required between summary line and description (found 0)
1457:13: E127 continuation line over-indented for visual indent
1460:1: E302 expected 2 blank lines, found 1
1460: D401 First line should be in imperative mood ('Fetche', not 'Fetches')
1460: D400 First line should end with a period (not 't')
1460: D205 1 blank line required between summary line and description (found 0)
1472:15: E711 comparison to None should be 'if cond is None:'
1472:15: E225 missing whitespace around operator
1472:32: E225 missing whitespace around operator
1476:5: B901 blind except: statement
1494:1: E302 expected 2 blank lines, found 1
1494: D401 First line should be in imperative mood ('Return', not 'Returns')
1494: D205 1 blank line required between summary line and description (found 0)
1511:77: E502 the backslash is redundant between brackets
1512:25: E127 continuation line over-indented for visual indent
1516:81: E502 the backslash is redundant between brackets
1517:25: E127 continuation line over-indented for visual indent
1527:1: E302 expected 2 blank lines, found 1
1527: D401 First line should be in imperative mood ('Return', not 'Returns')
1527: D400 First line should end with a period (not 'n')
1527: D205 1 blank line required between summary line and description (found 0)
1561:33: E128 continuation line under-indented for visual indent
1562:28: E211 whitespace before '('
1568:33: E128 continuation line under-indented for visual indent
1569:28: E211 whitespace before '('
1577:28: E211 whitespace before '('
1586:33: E128 continuation line under-indented for visual indent
1591:77: E502 the backslash is redundant between brackets
1591:76: E211 whitespace before '('
1592:21: E128 continuation line under-indented for visual indent
1594:1: E302 expected 2 blank lines, found 1
1594: D400 First line should end with a period (not 't')
1594: D205 1 blank line required between summary line and description (found 0)
1607:13: E127 continuation line over-indented for visual indent
1609:1: E302 expected 2 blank lines, found 1
1609:33: E211 whitespace before '('
1609: D401 First line should be in imperative mood ('Return', not 'Returns')
1609: D205 1 blank line required between summary line and description (found 0)
1618:73: E502 the backslash is redundant between brackets
1618:72: E211 whitespace before '('
1619:21: E128 continuation line under-indented for visual indent
1622:1: E302 expected 2 blank lines, found 1
1622: D401 First line should be in imperative mood ('Return', not 'Returns')
1622: D400 First line should end with a period (not 'r')
1622: D205 1 blank line required between summary line and description (found 0)
1636:1: E303 too many blank lines (3)
1638:1: E302 expected 2 blank lines, found 3
1638: D401 First line should be in imperative mood ('Create', not 'Creates')
1638: D400 First line should end with a period (not 's')
1643: D210 No whitespaces allowed surrounding docstring text
1643: D401 First line should be in imperative mood ('Return', not 'Returns')
1643: D400 First line should end with a period (not 'g')
1648: D401 First line should be in imperative mood ('Return', not 'Returns')
1648: D400 First line should end with a period (not ')')
1653: D401 First line should be in imperative mood ('Return', not 'Returns')
1659: D210 No whitespaces allowed surrounding docstring text
1659: D401 First line should be in imperative mood ('Return', not 'Returns')
1659: D400 First line should end with a period (not 'g')
1665:1: E302 expected 2 blank lines, found 1
1665: D401 First line should be in imperative mood ('Return', not 'Returns')
1665: D400 First line should end with a period (not 'n')
1665: D205 1 blank line required between summary line and description (found 0)
1698:12: E713 test for membership should be 'not in'
1705:34: E127 continuation line over-indented for visual indent
1708:34: E127 continuation line over-indented for visual indent
1711:34: E127 continuation line over-indented for visual indent
1724: D400 First line should end with a period (not 'y')
1724: D205 1 blank line required between summary line and description (found 0)
1757:26: E127 continuation line over-indented for visual indent
1762:114: E261 at least two spaces before inline comment
1766:16: E713 test for membership should be 'not in'
1770:49: E502 the backslash is redundant between brackets
1771:42: E127 continuation line over-indented for visual indent
1773:48: E502 the backslash is redundant between brackets
1774:42: E127 continuation line over-indented for visual indent
1776:53: E502 the backslash is redundant between brackets
1777:42: E127 continuation line over-indented for visual indent
1791:21: E126 continuation line over-indented for hanging indent
1810: D400 First line should end with a period (not 'g')
1810: D205 1 blank line required between summary line and description (found 0)
1824: D400 First line should end with a period (not 'g')
1824: D205 1 blank line required between summary line and description (found 0)
1841:1: E302 expected 2 blank lines, found 1
1841: D401 First line should be in imperative mood ('Return', not 'Returns')
1841: D202 No blank lines allowed after function docstring (found 1)
1841: D400 First line should end with a period (not 'r')
1884: D401 First line should be in imperative mood ('Create', not 'Creates')
1884: D400 First line should end with a period (not 'd')
1884: D205 1 blank line required between summary line and description (found 0)
1898:5: B901 blind except: statement
1951:1: E302 expected 2 blank lines, found 1
1951: D401 First line should be in imperative mood ('Create', not 'Creates')
1979: D401 First line should be in imperative mood ('Create', not 'Creates')
1979: D400 First line should end with a period (not 't')
1990:21: E128 continuation line under-indented for visual indent
1998:21: E126 continuation line over-indented for hanging indent
2037:37: E128 continuation line under-indented for visual indent
2046: D401 First line should be in imperative mood ('Create', not 'Creates')
2046: D400 First line should end with a period (not 'y')
2094:35: E127 continuation line over-indented for visual indent
2118: D401 First line should be in imperative mood ('Create', not 'Creates')
2118: D400 First line should end with a period (not 'y')
2144:25: E128 continuation line under-indented for visual indent
2169:21: E128 continuation line under-indented for visual indent
2169:60: E225 missing whitespace around operator
2170:21: E126 continuation line over-indented for hanging indent
2208:18: E222 multiple spaces after operator
2226:9: E116 unexpected indentation (comment)
2244:9: E116 unexpected indentation (comment)
2308:62: E203 whitespace before ':'
2312: D210 No whitespaces allowed surrounding docstring text
2312: D401 First line should be in imperative mood ('Return', not 'Returns')
2312: D400 First line should end with a period (not 'a')
2327: D401 First line should be in imperative mood ('Create', not 'Creates')
2364: D401 First line should be in imperative mood ('Create', not 'Creates')
2387:46: E502 the backslash is redundant between brackets
2388:21: E128 continuation line under-indented for visual indent
2414:1: E302 expected 2 blank lines, found 1
2414: D401 First line should be in imperative mood ('Return', not 'Returns')
2414: D400 First line should end with a period (not 'y')
2420: D401 First line should be in imperative mood ('Return', not 'Returns')
2420: D400 First line should end with a period (not 'y')
2432: D401 First line should be in imperative mood ('Return', not 'Returns')
2432: D400 First line should end with a period (not 'y')
2440:14: E128 continuation line under-indented for visual indent
2445: D401 First line should be in imperative mood ('Return', not 'Returns')
2445: D400 First line should end with a period (not 'y')
2450: D401 First line should be in imperative mood ('Return', not 'Returns')
2450: D400 First line should end with a period (not 'y')
2455: D401 First line should be in imperative mood ('Return', not 'Returns')
2455: D400 First line should end with a period (not 'y')
2460: D401 First line should be in imperative mood ('Return', not 'Returns')
2460: D400 First line should end with a period (not 'y')
2467: D401 First line should be in imperative mood ('Return', not 'Returns')
2467: D400 First line should end with a period (not 'y')
2475: D401 First line should be in imperative mood ('Return', not 'Returns')
2475: D400 First line should end with a period (not 'y')
2483: D401 First line should be in imperative mood ('Return', not 'Returns')
2483: D400 First line should end with a period (not 'y')
2491: D401 First line should be in imperative mood ('Return', not 'Returns')
2491: D400 First line should end with a period (not 's')
2495:10: E128 continuation line under-indented for visual indent
2499:1: E302 expected 2 blank lines, found 1
2499: D401 First line should be in imperative mood ('Export', not 'Exports')
2512: D401 First line should be in imperative mood ('Export', not 'Exports')
2522:66: E502 the backslash is redundant between brackets
2523:18: E128 continuation line under-indented for visual indent
2527: D401 First line should be in imperative mood ('Export', not 'Exports')
2547:68: E502 the backslash is redundant between brackets
2557:1: E302 expected 2 blank lines, found 1
2557: D400 First line should end with a period (not 'a')
2557: D205 1 blank line required between summary line and description (found 0)
2566:64: E502 the backslash is redundant between brackets
2567:25: E127 continuation line over-indented for visual indent
2570: D400 First line should end with a period (not ',')
2570: D205 1 blank line required between summary line and description (found 0)
2625:13: E128 continuation line under-indented for visual indent
2626:13: E128 continuation line under-indented for visual indent
2627:13: E128 continuation line under-indented for visual indent
2628:13: E128 continuation line under-indented for visual indent
2629:13: E128 continuation line under-indented for visual indent
2630:13: E124 closing bracket does not match visual indentation
2630:13: E125 continuation line with same indent as next logical line
2646:13: E125 continuation line with same indent as next logical line
2652: D401 First line should be in imperative mood ('Return', not 'Returns')
2678:27: E128 continuation line under-indented for visual indent
2681: D401 First line should be in imperative mood ('Return', not 'Returns')
2681: D400 First line should end with a period (not ',')
2681: D205 1 blank line required between summary line and description (found 0)
2725:1: E302 expected 2 blank lines, found 1
2725: D401 First line should be in imperative mood ('Transform', not 'Transforms')
2725: D400 First line should end with a period (not 'e')
2725: D200 One-line docstring should fit on one line with quotes (found 3)
2732: D401 First line should be in imperative mood ('Run', not 'Runs')
2732: D400 First line should end with a period (not 's')
2732: D205 1 blank line required between summary line and description (found 0)
2746: D401 First line should be in imperative mood ('Return', not 'Returns')
2746: D400 First line should end with a period (not 'n')
2754: D401 First line should be in imperative mood ('Return', not 'Returns')
2754: D400 First line should end with a period (not 'm')
2763:13: E127 continuation line over-indented for visual indent
2766: D401 First line should be in imperative mood ('Return', not 'Returns')
2766: D400 First line should end with a period (not 'm')
2770:9: E125 continuation line with same indent as next logical line
2775: D401 First line should be in imperative mood ('Return', not 'Returns')
2775: D400 First line should end with a period (not 't')
2783: D401 First line should be in imperative mood ('Return', not 'Returns')
2783: D400 First line should end with a period (not 's')
2787:33: E713 test for membership should be 'not in'
2787:54: E261 at least two spaces before inline comment
2792: D401 First line should be in imperative mood ('Return', not 'Returns')
2792: D400 First line should end with a period (not 'm')
2800: D400 First line should end with a period (not 'e')
2800: D200 One-line docstring should fit on one line with quotes (found 3)
2812:1: E302 expected 2 blank lines, found 1
2818:1: E302 expected 2 blank lines, found 1
2823:1: E302 expected 2 blank lines, found 1
2830:1: E302 expected 2 blank lines, found 1
2836:1: E302 expected 2 blank lines, found 1
2849:1: E302 expected 2 blank lines, found 1
2854:37: E128 continuation line under-indented for visual indent
2856:10: E128 continuation line under-indented for visual indent
2857:10: E128 continuation line under-indented for visual indent
2858:10: E128 continuation line under-indented for visual indent
2859:10: E128 continuation line under-indented for visual indent
2860:10: E128 continuation line under-indented for visual indent
2861:10: E128 continuation line under-indented for visual indent


Je ne suis pas fan, je préfère avoir une erreur plutôt qu'une modif silencieuse qui nous explosera à la figure plus tard ("mais pourquoi j'arrive pas à créer un carnet en paysage !!!") D'ailleurs, pourquoi interdire le paysage ?


@nguyen-viet-thanh-trung Is it related to the TS capture I provided?


Exactly, thanks!


Il ne vaudrait pas mieux mettre une valeur par défaut pour tous ces champs ?


I figured but lacked the insight to appropriately do so myself. Feel free to close whenever it makes sense for you.
PS: I'm hoping I wasn't keeping you up (I'm on CET).


Can you add an issue id or something like that to the subject in order to distinguish different emails?
Otherwise users might receive a lot of emails with exactly the same subject.


So that on systems running python 2.6 we get the unittest 2 methods such as assertDictEqual


How about this @stoeffel?


This is called after we've replaced any `<%= var_name %>` with real content right?

This could be less brittle if you strip any lines that match lodash templating syntax, with something like this regex:
`^\s*<%.+%>\s*$`.

It will leave the `ST_AsGeoJSON(block.geom) AS geojson,` in place, but that's OK.


v. minor: can only happen as result of prev. condition [if (lenb+inlen>inmax)], so test could be there.


this is wrong, the loop should only exit if the test is true.  right now it will only report whether the first legacy plugin has a configure or not, not whether *any* has it.


The piece of code below, is more or less identical to the one above. Given that it's not just a couple of lines, you should abstract it away in a function that takes the different inputs as reference arguments.


How is this going to work - publishing user and password publicly?


lacked vocabulary there. Altough "Platzhalter" could have given me a clue.


Thanks! I've just tested a new patch.

No worries. I'm on Pacific Time, BTW. I just got up insanely early to do this. :)


1: M111 unrecognized component name: format


@vcostin cool. this is probably in the wrong place, since it's generic functionality. I'd suggest we add it to `app/assets/stylesheets/open_project_global/_mixins.sass` or even better `app/assets/stylesheets/open_project_global/_functions.sass`.


FYI, Lucas has taken care of this:
https://github.com/lucasart/Stockfish/commit/e9e42dda079f3743516609470cb30aa3201d60c4
and he opened a pull request too.


Where is "GENERIC_DATA" defined ?


just a thought - to avoid this being an invitation for spam, perhaps it's possible to do this with github usernames and then extract the emails from there without hardcoding them here?


Yes, of course - was just doing copy/paste from the `@xtrf|@xtrc` right above it. I'll fix both.


1: M111 unrecognized component name: legacy


51:1: I201 Missing newline before sections or imports.
52:1: I201 Missing newline before sections or imports.
54:1: I100 Imports statements are in the wrong order. import invenio.legacy.bibformat.dblayer should be before from werkzeug.utils
55:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before import invenio.legacy.bibformat.dblayer
58:1: F401 'CFG_BIBFORMAT_CACHED_FORMATS' imported but unused
58:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
76:1: F401 'CFG_BIBFORMAT_FORMAT_OUTPUT_EXTENSION' imported but unused
76:1: F401 'CFG_BIBFORMAT_TEMPLATES_DIR' imported but unused
76:1: F401 'CFG_BIBFORMAT_OUTPUTS_PATH' imported but unused
87:27: E261 at least two spaces before inline comment
88:28: E114 indentation is not a multiple of four (comment)
88:28: E116 unexpected indentation (comment)
89:28: E114 indentation is not a multiple of four (comment)
89:28: E116 unexpected indentation (comment)
90:28: E114 indentation is not a multiple of four (comment)
90:28: E116 unexpected indentation (comment)
93:28: E114 indentation is not a multiple of four (comment)
93:28: E116 unexpected indentation (comment)
107:33: E225 missing whitespace around operator
192:1: E731 do not assign a lambda expression, use a def
197:1: E303 too many blank lines (4)
197: D203 1 blank line required before class docstring (found 0)
201: D401 First line should be in imperative mood ('Return', not 'Returns')
201: D400 First line should end with a period (not 's')
213: D401 First line should be in imperative mood ('Return', not 'Returns')
238: D102 Missing docstring in public method
282: D103 Missing docstring in public function
288: D401 First line should be in imperative mood ('Format', not 'Formats')
288: D400 First line should end with a period (not 'f')
288: D205 1 blank line required between summary line and description (found 0)
335:45: W503 line break before binary operator
335:45: E127 continuation line over-indented for visual indent
351:8: W503 line break before binary operator
478:27: E225 missing whitespace around operator
481:5: E303 too many blank lines (2)
499:82: E225 missing whitespace around operator
520: D103 Missing docstring in public function
536: D401 First line should be in imperative mood ('Return', not 'Returns')
536: D202 No blank lines allowed after function docstring (found 1)
536: D400 First line should end with a period (not 'g')
536: D205 1 blank line required between summary line and description (found 0)
557:64: E261 at least two spaces before inline comment
557:65: E262 inline comment should start with '# '
564:38: E261 at least two spaces before inline comment
564:39: E262 inline comment should start with '# '
565:48: E261 at least two spaces before inline comment
565:49: E262 inline comment should start with '# '
568:24: E127 continuation line over-indented for visual indent
577: D103 Missing docstring in public function
580: D400 First line should end with a period (not 's')
580: D200 One-line docstring should fit on one line with quotes (found 3)
593: D210 No whitespaces allowed surrounding docstring text
593: D400 First line should end with a period (not 'a')
593: D205 1 blank line required between summary line and description (found 0)
630:57: E126 continuation line over-indented for hanging indent
637:5: E303 too many blank lines (2)
698: D401 First line should be in imperative mood ('Evalute', not 'Evalutes')
718: D401 First line should be in imperative mood ('Analyse', not 'Analyses')
718: D202 No blank lines allowed after function docstring (found 1)
787: D401 First line should be in imperative mood ('Return', not 'Returns')
787: D400 First line should end with a period (not 't')
787: D205 1 blank line required between summary line and description (found 0)
886:13: B901 blind except: statement
917:78: E225 missing whitespace around operator
918:54: E225 missing whitespace around operator
950:47: E261 at least two spaces before inline comment
965:27: E225 missing whitespace around operator
1025: D401 First line should be in imperative mood ('Filter', not 'Filters')
1035: D401 First line should be in imperative mood ('Searche', not 'Searches')
1035: D400 First line should end with a period (not 's')
1035: D205 1 blank line required between summary line and description (found 0)
1061:9: E303 too many blank lines (2)
1075:5: E303 too many blank lines (2)
1078:1: E302 expected 2 blank lines, found 1
1078: D401 First line should be in imperative mood ('Return', not 'Returns')
1092:5: F841 local variable '_' is assigned to but never used
1095:12: E127 continuation line over-indented for visual indent
1104:16: E126 continuation line over-indented for hanging indent
1126:5: B901 blind except: statement
1138: D401 First line should be in imperative mood ('Return', not 'Returns')
1138: D400 First line should end with a period (not 's')
1158:16: E126 continuation line over-indented for hanging indent
1165:1: E302 expected 2 blank lines, found 1
1165: D401 First line should be in imperative mood ('Return', not 'Returns')
1165: D400 First line should end with a period (not 'e')
1197:13: E303 too many blank lines (2)
1211: D401 First line should be in imperative mood ('Return', not 'Returns')
1245:16: E127 continuation line over-indented for visual indent
1255:31: E126 continuation line over-indented for hanging indent
1282:9: B901 blind except: statement
1294:17: E126 continuation line over-indented for hanging indent
1301:1: E302 expected 2 blank lines, found 1
1301: D401 First line should be in imperative mood ('Return', not 'Returns')
1301: D400 First line should end with a period (not 'e')
1345:1: E302 expected 2 blank lines, found 1
1345: D401 First line should be in imperative mood ('Return', not 'Returns')
1345: D202 No blank lines allowed after function docstring (found 1)
1472:1: E302 expected 2 blank lines, found 1
1472: D401 First line should be in imperative mood ('Return', not 'Returns')
1472: D202 No blank lines allowed after function docstring (found 1)
1499:17: E225 missing whitespace around operator
1578:28: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
1582: D401 First line should be in imperative mood ('Return', not 'Returns')
1582: D202 No blank lines allowed after function docstring (found 1)
1582: D400 First line should end with a period (not '}')
1599:56: E225 missing whitespace around operator
1635:1: E302 expected 2 blank lines, found 1
1635: D203 1 blank line required before class docstring (found 0)
1635: D204 1 blank line required after class docstring (found 0)
1635: D400 First line should end with a period (not 'n')
1635: D205 1 blank line required between summary line and description (found 0)
1666:15: E261 at least two spaces before inline comment
1668: D401 First line should be in imperative mood ('Create', not 'Creates')
1700:31: E261 at least two spaces before inline comment
1725: D401 First line should be in imperative mood ('Return', not 'Returns')
1725: D400 First line should end with a period (not 'e')
1740: D401 First line should be in imperative mood ('Return', not 'Returns')
1740: D400 First line should end with a period (not 'd')
1763: D401 First line should be in imperative mood ('Return', not 'Returns')
1763: D400 First line should end with a period (not 'e')
1763: D205 1 blank line required between summary line and description (found 0)
1801: D401 First line should be in imperative mood ('Return', not 'Returns')
1801: D202 No blank lines allowed after function docstring (found 1)
1910:36: E127 continuation line over-indented for visual indent
1913: D401 First line should be in imperative mood ('Return', not 'Returns')
1970:33: E127 continuation line over-indented for visual indent
1981:60: E251 unexpected spaces around keyword / parameter equals
1983:54: E251 unexpected spaces around keyword / parameter equals
1993:37: E127 continuation line over-indented for visual indent
2004:64: E251 unexpected spaces around keyword / parameter equals
2006:58: E251 unexpected spaces around keyword / parameter equals


22:1: E402 module level import not at top of file
23:1: I100 Imports statements are in the wrong order. import os should be before import re
23:1: E402 module level import not at top of file
24:1: I100 Imports statements are in the wrong order. import cgi should be before import os
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. import tempfile should be before import urllib
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. import datetime should be before import tempfile
27:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: I101 Imported names are in the wrong order. Should be CFG_BINDIR, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_URL, CFG_TMPDIR
30:1: I201 Missing newline before sections or imports.
30:1: E402 module level import not at top of file
36:1: E402 module level import not at top of file
37:1: I101 Imported names are in the wrong order. Should be addadminbox, write_outcome
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.adminlib should be before from invenio.legacy.oaiharvest.config
37:1: E402 module level import not at top of file
40:1: I101 Imported names are in the wrong order. Should be delete_holdingpen_entry, get_day_logs_size, get_entry_history, get_entry_logs_size, get_history_entries_for_day, get_holdingpen_day_fragment, get_holdingpen_entry_details, get_holdingpen_month, get_holdingpen_year, get_holdingpen_years, get_month_logs_size
40:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
48:1: E402 module level import not at top of file
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord.xmlmarc2textmarc should be before import invenio.legacy.template
49:1: E402 module level import not at top of file
51:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.bibrecord.xmlmarc2textmarc
51:1: E402 module level import not at top of file
52:1: E402 module level import not at top of file
53:1: I101 Imported names are in the wrong order. Should be task_log_path, task_low_level_submission
53:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.url
53:1: E402 module level import not at top of file
55:1: I101 Imported names are in the wrong order. Should be get_email, get_user_info
55:1: E402 module level import not at top of file
57:1: E402 module level import not at top of file
61:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.serializers
61:1: E402 module level import not at top of file
437: D401 First line should be in imperative mood ('create', not 'creates')
437: D400 First line should end with a period (not 'e')
437: D200 One-line docstring should fit on one line with quotes (found 2)
494: D400 First line should end with a period (not 'e')
521:13: W503 line break before binary operator
522:13: W503 line break before binary operator
527:13: W503 line break before binary operator
528:13: W503 line break before binary operator
541:5: E266 too many leading '#' for block comment
627:5: E266 too many leading '#' for block comment
634:9: F841 local variable 'sets_names' is assigned to but never used
664: D401 First line should be in imperative mood ('return', not 'returns')
664: D400 First line should end with a period (not 'e')
664: D208 Docstring is over-indented
664: D200 One-line docstring should fit on one line with quotes (found 3)
675: D401 First line should be in imperative mood ('return', not 'returns')
675: D400 First line should end with a period (not 'e')
675: D208 Docstring is over-indented
675: D200 One-line docstring should fit on one line with quotes (found 3)
686: D103 Missing docstring in public function
722:1: E266 too many leading '#' for block comment
725: D103 Missing docstring in public function
791: D103 Missing docstring in public function
804: D210 No whitespaces allowed surrounding docstring text
804: D400 First line should end with a period (not 'a')
804: D205 1 blank line required between summary line and description (found 0)
804: D208 Docstring is over-indented
844: D103 Missing docstring in public function
949:59: W503 line break before binary operator
966: D400 First line should end with a period (not 'd')
1017:1: E266 too many leading '#' for block comment
1021: D401 First line should be in imperative mood ('Harvest', not 'Harvests')
1021: D400 First line should end with a period (not 't')
1021: D208 Docstring is over-indented
1021: D200 One-line docstring should fit on one line with quotes (found 3)
1033: D103 Missing docstring in public function
1045: D401 First line should be in imperative mood ('Format', not 'Formats')
1045: D205 1 blank line required between summary line and description (found 0)
1072: D400 First line should end with a period (not 't')
1082:15: E711 comparison to None should be 'if cond is None:'
1086:19: E711 comparison to None should be 'if cond is None:'
1102: D401 First line should be in imperative mood ('Launche', not 'Launches')
1102: D200 One-line docstring should fit on one line with quotes (found 3)
1123: D400 First line should end with a period (not 'd')
1143: D400 First line should end with a period (not 'w')
1153: D103 Missing docstring in public function
1157:1: E266 too many leading '#' for block comment
1161: D103 Missing docstring in public function
1184: D210 No whitespaces allowed surrounding docstring text
1184: D400 First line should end with a period (not 'd')
1248:1: E266 too many leading '#' for block comment
1250: D103 Missing docstring in public function
1294: D103 Missing docstring in public function
1300:5: B901 blind except: statement
1311:5: B901 blind except: statement
1321:5: B901 blind except: statement
1345: D103 Missing docstring in public function
1351: D103 Missing docstring in public function
1360: D103 Missing docstring in public function
1379: D103 Missing docstring in public function
1388: D103 Missing docstring in public function
1399: D103 Missing docstring in public function
1410: D103 Missing docstring in public function
1417: D103 Missing docstring in public function
1421: D103 Missing docstring in public function
1427: D208 Docstring is over-indented
1473: D202 No blank lines allowed after function docstring (found 1)
1552: D401 First line should be in imperative mood ('Find', not 'Finds')


@andresgutierrez
I think the `true | false` is better than `1 | 0 | true | false`.
If you disagree, why?


while not very important as in theory those probably can't be called if the function doesn't exist,  but the previous code did check whether the function did exist


这个地方每个开发人员要用自己的，或者统一都放在同一个盘符内的同一个地方。


put const infront of GenericNode


Corrected the indentation in this file.


This class could just be a couple of module-level functions.


It's absolutely better, but this value can come from an external resource and just the internal conversion to false or true is fine for us, why do we need to force people to pass exactly true or false there? what is the benefit there?


Superb.


Yes, I agree that we should not use `rb_funcall` for this since that requires an extra trip back and forth from ruby code.  This might be tricky, though, since I don't think that `effective_dim` will actually be visible in the header.

Also, is there a reason that it needs to be a preprocessor macro rather than a function?  (Or needed to be in the original NVector version?)  In my opinion we should be using functions rather than macros when there's no namespace-fixing required (as in the original NVector one); an optimizing compiler should be able to inline the function call if necessary (at least within nmatrix), so I doubt the macro is a performance optimization.

My personal preference if we do want this in the API is to declare a function that does it in `nmatrix.h`, and then add a file, `nmatrix_c_api.c` that implements the function.  But this presupposes that we want to expose more than a minimal API for C libraries; I think that we probably should do this, but it's worth thinking more about what we want in it, and how we're going to avoid duplication with the ruby API that's mostly in `ruby_nmatrix.c`


This sentence was accidentally truncated.


If you are going to leave this as a class for namespacing, then you'd be better off making it a `@classmethod` and then using the `cls` argument passed in to the method, rather than `FeatureManager` here.


test


Ok, maybe not obvious with the trivial formatting changes (moving from Eclipse to Netbeans).

Basically, in adding missing children, we compute the mrca of sister taxa that are already are in the tree, and the taxonomic mrca (taxmrca) to get the relevant descendants. However, the taxmrca involved only the sampled tips, when it should include the sampled tips + the tip to be added. The former method worked if that sampled taxa had the same taxmrca as the full set, but not if it was shallower (say, a sister clade).


It's not defined anywhere :-). This is part of the package doc and looks like I forgot to update. I will update it push.


This doesn't appear to ever be used. What's its purpose?


@vtjnash Why is necessary with a separate file for OpenBLAS instead of using Versions.make?


See the most recent commit (it's fixed there)


https://github.com/coffeedoc/codo Seems to be the best pick


:+1: Thanks for the feedback. Fixed in https://github.com/jingweno/ccat/commit/66dfb5f9964ee6629dcec657bb47a4613c7990b8


Actually, n/m.  Moment.


This fix seems to get rid of both invalid named nodes and unsupported nodes.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14567/testReport/) for this commit**


Did you verify the inertial values and COGs in Gazebo using View->Center of Mass/Inertia?

They seem very odd to me. E.g. using the equation to compute inertia of a cylinder, I think Ixx for link2 should be 1/12*m*(3*r^2 + h^2) = 1/12*1.011*(3*0.04^2 + 0.48^2) = 0.02... However in the model you put 0.3...

I tried to display the inertias in Gazebo, and when I set your inertial elements to 1/10 of what is here, I got what is depicted further. You may notice wrongly rotated inertial boxes AND wrongly positioned COGs.

![clipboard01](https://cloud.githubusercontent.com/assets/182533/7494709/9a8068ac-f409-11e4-9e7c-7387deb38c2e.jpg)

You might find my older tutorial useful: http://gazebosim.org/tutorials?tut=inertia&cat=build_robot . There's also a hint on how to debug these elements - set temporarily the mass to 1, and then the inertial boxes should more or less be the bounding boxes of the links.


should probably be rather named hook_data_destroy or something equally clear on what it is supposed to do


The number can be increased by regular means. example:
```
$a = 25;
echo ++$a; // 26
```

If you disagree, why?


LGTM


oops


(I missed this commit earlier this morning, so you can ignore my earlier comment about this. thanks for the comment / docstring as well.)


It is detached in line 521.


Is the page size https://github.com/sakaiproject/sakai/blob/master/roster2/src/java/org/sakaiproject/roster/tool/entityprovider/RosterSiteEntityProvider.java#L140


Yes IE 11.


@nirvdrum Specs started working too , not sure why but that's good.


while it make sense, this change has nothing to do here, does it


used this command to remove from git index, but keep in local file system:
git rm -r --cached JAP_EN/


Have you checked the webhooks/github events?
There is an event on "labeled" for issues and PRs, and if it can be used from miq_bot (I haven't checked), then the whole emailing part is not necessary here, and it can go through github notification mechanism.
https://developer.github.com/changes/2014-07-28-assignee-and-label-actions-for-issue-events/


Не знаю, как это сделать по-другому. Длина змеи == число съеденных яблок + 1. Значит, нужна переменная, в которой считаем яблоки


Тогда питон пишет при запуске, что не находит APPLE и SNAKE


I'm also a little concerned about `Feature` as a general concept. It doesn't do anything around defining what extension points the feature plugs in to (and doesn't take into account the possibility that different extension points might need different types of managers). It seems to me that it would make more sense to provide a set of extension points to the platform, each of which can be plugged into independently.


"must be geany_plugin" doesn't make so much sense now it's not a supposed to be a global anymore.


Nit: adding teams should happen in commit about teams.


These should be added for all apps in the django installed apps, not just those that extend edx plugin points.


Hi,

Ah OK. Then will not put any effort in creating this fix, at least for v8.

Thank you for taking time to respond

Cheers,
Andrius


mention that this refers to the report


Generally, prefer `@classmethod` to `@staticmethod`, so that you have access to class attributes.


Can you open a new issue and paste an example of the tests you're doing that fail (in addition to the error message mentioned above) please? It's not likely this is going to be reverted because it fixed a couple of showstopper bugs that resulted in production outages, but we do need to make chefspec work.


Sure! I've seen you have gone ahead, so cool.
El dia 05/05/2015 5:14 p. m., "Lazaridis" <notifications@github.com> va
escriure:

> I was very afraid of this chunk of work, great that you've done it. Are
> you interested in getting those changes back to the original repo? It seems
> you would just have to change the version back to 1.1.0.BUILD-SNAPSHOT
> and then send a PR (there's even a spring-data-rest-2.3.0 branch on the
> repo, which was for this upgrade that you've done). If you're to busy, then
> I'll see to it that your changes go in (in some way).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bfcapell/light-admin/commit/23d3a18e4404bc4ac986ba54d653cd68f99e664a#commitcomment-11046619>
> .
>


I saw that, but it wasn't clear from the diff whether checkScroll was being repeatedly called while 521 was just called on a state switch, ie: a click.


use auto


Why are you forcing to install the pip version for debian? Both backports and saltstack repos have requests 2.0.0 and release notes do not mention a specific version.


Be careful with using empty() here in this way. Because older PHP versions don't allow return values in the empty() function. You probably need something like this:

```php
$value = parent::value();
return empty($value) ? site()->user()->username() : $value;
```


yeah; good to know it's zeroed by default.


Stick a note on there, then. It just looks a bit magic at the moment.


yes, like the /usr/include/oce


What does it mean for a tab to be "persistent"?


Relevant bit is [here](https://github.com/OpenTreeOfLife/treemachine/blob/3cba417a8f97f86de5224ad16b8c2bcad527acb9/src/main/java/opentree/GraphExplorer.java#L1968-1975).


Unfortunately we did not have time to validate them thoroughly. Keep in mind that it's still a work in progress. The values were automatically exported from the Solidworks model, but there probably has been a conversion error somewhere in the chain. Thanks for pointing these out, they should be fixed by the time we officially release the new URDF models.


That'll do nicely.


Why change the indentation of the code?


if you move this and `defaultEqualRenders` outside of `ImmutableThunk` (i.e. move them down a few lines in this file) it will avoid creating these functions every time you create a thunk.  these functions don't reference anything by closure so it's more efficient not to create a new copy of them for every thunk.


@rkorytkowski how did you make it work without this line? :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14571/testReport/) for this commit**


Thanks a ton Lucas!
I will study your code to learn more about C++.

Again, I want to remind everyone that my code may seem "hackish".
It's not because I am lazy...it's because of my limited knowledge of C++ and SF's code.  I am sure that I will improve as time goes on...


same here... move it outside this function so that you don't create it every time the function is called.


Why not just add metadata to the datepicker close event? It seems silly to have an event dedicated to a close without change. `$(self).trigger('datepicker-close', {changed: justClose})`


let's call this StructureChangeFlag


Ok, I'll wait for them :)


yes, that should work. Bear in mind that all nodes need to declare their
permitted next node in order for the graph to be visualisable. See:

https://github.com/alphagov/smart-answers/blob/9de5f6e7d6aa454888cda5aa80a48e4e22c80f2e/lib/graph_presenter.rb#L26-L30

On 6 May 2015 at 14:30, Chris Roos <notifications@github.com> wrote:

> Great, thanks! In that case, should adding permitted_next_nodes to a
> question that uses the old style next_node with a block syntax mean that
> the question shows up correctly in the "/visualise" view? I just tried this
> in question 1 of the additional-commodity-code Smart Answer but it didn't
> seem to have any effect on the graph output.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alphagov/smart-answers/commit/98c598287955ec56238d1729537ed29099cc1067#commitcomment-11065374>
> .
>

--
Developer
GOV.UK <https://www.gov.uk>
Government Digital Service
Cabinet Office


Same here! empty() will throw an error in 5.3 and probably even in 5.4.


Oh i see! This must be a hibernate4 improvement. :)

On Wed, May 6, 2015 at 3:54 PM, Rafal Korytkowski <notifications@github.com>
wrote:

> It looks hacky. I removed this line and tests are still passing. Maybe
> Hibernate 4.x does a better job and is not being so eager when flushing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-core/commit/c5cc6bd8d75114f3f2306d702c40f0659db15af6#commitcomment-11064708>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


- Nice work so with the Events
- Good Spacing


[`G_STRFUNC`](https://developer.gnome.org/glib/unstable/glib-Miscellaneous-Macros.html#G-STRFUNC:CAPS) provides a potentially nicer, and surely more portable version of `__func__`.
OK, less useful since we now depend on C99, but still.


Yah - looks like a test build somehow overwrote the files. I blame @KoffeinFlummi  make.py


Wasn't aware of this, will avoid this in the future.


ducktype is actually a different package on pypi. At the moment, the right package name is duck, though I've been meaning to change it to mallard-ducktype.


Building the package I get the warning:
dpkg-shlibdeps: warning: symbol _Z35vtkIOMPIParallel_AutoInit_Constructv used by debian/statismo-core/usr/lib/libstatismo_VTK.so.0.10.2 found in none of the libraries
dpkg-shlibdeps: warning: symbol _Z34vtkIOMPIParallel_AutoInit_Destructv used by debian/statismo-core/usr/lib/libstatismo_VTK.so.0.10.2 found in none of the libraries

the symbol seems to be in vtkIOMPIParallel. Is there a list somewhere of all available modules?


is it worth mentioning the change to conf/application.conf here too?


while it doesn't seem very useful, why specifically disallow it?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14572/testReport/) for this commit**


At what point?


There's a ton of spurious whitespace changes in this commit


successful


@V3n3RiX have a nice play


Can we just rename above line to
usage example (using default methods of connecting to the network):


1)curl.exe is not the best idea i think (i could be wrong)
2) _PushFile($FileName, "loots", "image/jpeg", "Last Raid", $FileName)
 dirloots exists in global variables, do not send it statically, for example smb creating function for log rotation and dirs could change in a future

3)what is the aim to set Global $FileName = "" if you send it directly to a function as argument?
4)  function declared as
Func _PushFile($File, $Folder, $FileType, $title, $body)
used
as _PushFile($FileName, "loots", "image/jpeg", "Last Raid", $FileName)
why do you send $body parameter which is the same as $File?
5) you are using first $oHTTP = ObjCreate("WinHTTP.WinHTTPRequest.5.1")
and then external curl.exe - WHY 2 different methods for the same aim - making post requests???


Meh, you didn't break it. Ignore me.


hmm which package do you use for ITK? are there any link in between ITK and VTK?


if homepage can really only be a URL, maybe plugin WebService should be updated accordingly, WDYT?


great!


Yeah, I have resisted the urge to do a "full edit" of these docs :)


However, interaction with the OS is still possible for a short while so I will recommend:

`killall loginwindow && halt -q`


:smile:


Best solution
```
exports.destroy = _.compose(function() {
    Ti.Gesture.removeEventListener('orientationchange', onOrientationChange);
     args.tabs && $.tabsCtrl && $.tabsCtrl.off();
     args.tabs && $.tabsCtrl && $.tabsCtrl.off();
}, exports.destroy);
```


this feedback deserves a dedicated rule, if it does not exist yet.


Can we just rename above line to
usage example (using explicit list of peer endpoints and overriding default methods to connect to the network):


Reject message if couldn't be saved.


This one should be applied to the master branch too.


The code from line 282 to 302 belong to the model not to the controller. Because between those line, one need the knowledge or how the table is structured. I would rather this code in a function ```$model->export(fileName); ```


trivial: whitespace


(df54e00) The title of the commit doesn't respect guideline ("type(scope): title (refs #<number>[, ...])")


sucessful


s/was/were/


typo: name of the name. also in the other methods.

and maybe: "during program *runtime*"? "During the program" sounds wrong imo.


44:1: I201 Missing newline before sections or imports.
45:1: I201 Missing newline before sections or imports.


1: M111 unrecognized component name: babel


43:1: I201 Missing newline before sections or imports.
44:1: I201 Missing newline before sections or imports.


1: M111 unrecognized component name: legacy


24:1: I100 Imports statements are in the wrong order. from flask should be before import msgpack
25:1: I100 Imports statements are in the wrong order. from functools should be before from flask
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from invenio.base.helpers should be before from six


46:1: I201 Missing newline before sections or imports.
47:1: I201 Missing newline before sections or imports.


True. I'll try it out later.


CheckScroll is called at the end of renderMembers and could launch "scroll.roster" trigger if needed, this trigger calls renderMembers and checkScroll again. This loop ends when checkScroll determines that you have scroll bar (and you are able to get more pages scrolling down) or there are no more pages available.


Can you make sure that the parent refers to version 0.2-SNAPSHOT in master?


For instance:

```php
$nextId = Text::increment($someModel->id); // just string coercion
````

```php
$nextId = Text::increment((string) $someModel->id); // to avoid an exception
````


No hay de qué. Me alegro que hayas podido.

Saludos.


useless extra `;` spotted !


Sehr, sehr nett!


It is the system default package libinsighttoolkit4.6 but I do not think that this is linked, as the missing symbol can be found in libvtkIOMPIParallel-6.0.so see:
```readelf -Ws /usr/lib/x86_64-linux-gnu/libvtkIOMPIParallel-6.0.so | grep Z34vtkIOMPI```


keeping `is_active` first would probably be a bit nicer


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14575/testReport/) for this commit**


What exception is this? Can we provide a better one? E.g., Value/Type Error?


do we have to apply patches for packages manually, or do they normally come down as updates?


You are introducing `DEVICEx_TYPE` (which is good) but you are not using them in `generic_core_bootcfg.c`?


I stand corrected andisite dorite etc... share the same id as stone not cobble.

However cobble is not dropping :(


Todo ok


Nice :+1:


This is like *the* thing regarding stopping playlist parsing due to ENDLIST, right?
I'd like to see a mention of that here or at least a comment on the endOfList property to explain why/where this property is comming/filled from.


This added some weird looking ||- after most search results (See attached image) I reverted back to the old `let g:ag_prg="ag --column"` and it seems to be back to normal.

![image](https://cloud.githubusercontent.com/assets/2367456/7495196/0380e4a0-f43f-11e4-92d1-53a99c670e4f.png)


originally the test case `if (p->configure)`, but was changed in your first commit to easily support both legacy and new callbacks -- but it slightly changed the semantic as a `plugin_configure()` returning NULL would now lead to calling `plugin_configure_single()`.
Now it's unified, reverting to teh original check might make sense (and be slightly simpler).


Add test for precedence of operators. Eg.
```
 (~x & y) == And(Not(x), y)
```


IMHO duplicates what is in the issue tracker. Shouldn't that be tracked in the issue tracker itself? Just a thought...


Add tests from symbol to symbol.


nice RESTful route


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Please don't kill me, i tried my best


Please restart the Travis job https://travis-ci.org/agda/agda/jobs/61423761.


<!doctype html>

    <meta charset="UTF-8">


I am asking cause if the package for itk is linked to vtk (some itk modules actually do) and if they do not specify the required list of modules, it will need all vtk modules... It has only been fixed in latest release of ITK...


Don't store css in view file :)


actually it was dropped intentionally, as this is just an informational error message and the list is incomplete anyway.


Please restart the Travis job https://travis-ci.org/agda/agda/jobs/61424011.


- Awesome
- Write test for saving user into the database


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14578/testReport/) for this commit**


Don't store css in view file


 请问，如何屏蔽你们的邮件

发自我的 iPhone

> 在 2015年5月6日，08:41，sparksustc <notifications@github.com> 写道：
>
> 用新的 proxylib.py 替换旧版本的，运行goagent提示：syntax error。
>
> —
> Reply to this email directly or view it on GitHub.
>


def format(data:)


fyi - the convention for naming your controller files (especially when we get to rails) - is "model-name-pluralized_controller". so for tags, entries, and users.. we would have: `tags_controller.rb`, `entries_controller.rb`, and `users_controller.rb`


Good question. Didn't realize that was defined in `fmt`.


You should probably make this 4 spaces instead of a tab


this looks good!


Constant?
Also what are the thoughts regarding `\n` vs. `\r\n`? Don't we need to care?
I thought I read somewhere that both are valid in m3u8 but can't find the paragraph in the spec.


won't $_GET overwrite keys from $params now?


Ah, OK, I will test if this affects usage.


Please, keep it alphabetically sorted


this probably not work unless we specify the foreign_key as `author_id`. (unless you've changed this in your database and now it's user - i haven't looked yet)


Hi Dr. Brown,

On my computer I had named the Object-Oriented Markov.py file that's in my
repository "contmarkov.py" because it was easier to type out. I changed the
name in the repository so that it was easier to recognize when I went back.
I don't have my computer with me now, but I'll check later today to make
sure that the Object-Oriented Markov.py file in my repository has
everything that the contmarkov.py file on my computer has.

Sorry for the confusion!

Cody

On Tue, May 5, 2015 at 4:39 PM, Jeremy Brown <notifications@github.com>
wrote:

> Cody, I can't find a file called "contmarkov.py" in your repo. Where is
> this code coming from?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/csteely/Computational-Phylogenetics/commit/8cd3ea7586c3285cbf63d864a1e2a30e0b8f94b9#commitcomment-11054493>
> .
>


nice validations!


Modest parantheses here: 4 spaces is pretty much the optimum for visual discernability and clarity in my humble investigations. Two spaces is crazy! Crazy I tell you! Good switch ;)


`def initialize(data:, formatter: Formatter::Default.new)`


No.


instead of bothering adding a comment, I'd rather just use the return value even if it will always be TRUE.  it would simplify reading the thing a little and be just the same.


This change appears to be responsible for the following error messages:


Тимофей, можно ли сослаться на метод класса, находясь в классе.
Например, я хочу, чтобы __init__ рисовал змею, то есть, чтобы в нём выполнялся put_snake. Или нужно писать класс Snake, а потом ссылаться на него?


These definitions are no longer needed.
Check pyflakes.


Are there already any estimates on when the new package will be released?
Our two Jaco 2 are currently just not usable.

2015-05-06 16:14 GMT+02:00 François Ferland <notifications@github.com>:

> Unfortunately we did not have time to validate them thoroughly. Keep in
> mind that it's still a work in progress. The values were automatically
> exported from the Solidworks model, but there probably has been a
> conversion error somewhere in the chain. Thanks for pointing these out,
> they should be fixed by the time we officially release the new URDF models.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/Kinovarobotics/jaco-ros/commit/7abb41ecf6716ff1577f2752c389eb2f46c4d621#commitcomment-11066329>
> .
>


@cjdelisle I suppose http://requirejs.org/docs/api.html#config-waitSeconds kicks in.


They reason why we do this is that every line in the Dockerfile creates a layer.  So, that means that everytime you issue a "yum install / update / anything", we need to clean the cache out of that layer.  So, one option is to string all your package install lines into one line / layer and issue one "yum clean all", or keep them in different lines / layers and issue a "yum clean all" on each line / layer where that happened.  It is not sufficient to have several lines of yum install and then only do a "yum clean all" on the last line.  That will only clean the cache on that layer.


Values from `$_GET` will be added to `$params` only if thier keys are not set at `$params`.


垃圾邮件

发件人: mrhsuyen [mailto:notifications@github.com]
发送时间: 2015年5月6日 22:35
收件人: goagent/goagent
主题: Re: [goagent] bugfix (98eca96)

请问，如何屏蔽你们的邮件

发自我的 iPhone

> 在 2015年5月6日，08:41，sparksustc <notifications@github.com <mailto:notifications@github.com> > 写道：
>
> 用新的 proxylib.py 替换旧版本的，运行goagent提示：syntax error。
>
> —
> Reply to this email directly or view it on GitHub.
>

—
Reply to this email directly or view it on GitHub <https://github.com/goagent/goagent/commit/98eca96b72bad5bc130c52aa8ef360651b429221#commitcomment-11066823> .  <https://github.com/notifications/beacon/AKMseqQXKl105bOBO0GcZHW6dq2W69Yxks5oGh4SgaJpZM4EQ0jJ.gif>


I think it's better to distinguish these methods as you may want to call `cleanup` without freeing model-view binding (generally speaking).


You can remove the ambiguity warning by defining:
```
*{B<:OrthonormalBasis}(dm1::DualMatrix{B}, dm2::DualMatrix{B}) = (dm2.qarr*dm1.qarr)'
```
But the relation we're defining here *is* more general than just the orthonormal case, so we should have the original defined as well.


yeah I know, but we shouldn't rely on that, it's ugly :)


Looks good to me.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14580/testReport/) for this commit**


see

https://github.com/Kitware/ITK/commit/d76af420c77ec78898c25cacbfac3e18a9e1fffa
https://github.com/Kitware/ITK/commit/9b68a4ae5c159e7461163434dcd0cc4425c656e6


mail sent, wait & see


I see, was not aware of this. http://3v4l.org/UdYeM


> This plugin did not use PLUGIN_SET_TRANSLATABLE_INFO, but just PLUGIN_SET_INFO, therefore I didn't add this.

OK I see

> Perhaps a comment like this would be better guidance?
> […]

Well, I'd rather just make the demoplugin do everything right and not assume it works because it's part of Geany -- so add the mail_locale_init() call.


So what kernel changes v6 really needs?


That's like a silent stop right? As long as this is really the end of the file, I think that's fine.

But what if there is something 'beyond' the ENDLIST?
 * in STRICT shouldn't that throw an exception or at least give some feedback to the caller. System.err for sure is the worst idea - but some listener? Maybe as a future enhancement?
 * in LENIENT mode maybe something comparable to `unkownTags` like `linesBeyondEnd`?

I see the problem to judge between "there is something at the end of the stream that doesn't belong there" and "there is a second playlist comming which might be consumed by a subsequent `parse` call".

First thought: Anything that is not blank lines or `#EXTM3U` is considered wrong (and handled accordingly to the parsing mode)?
If `#EXTM3U` is found, the `parse` call doesn't consume it so it is available for a subsequent call.


51:1: I201 Missing newline before sections or imports.
52:1: I201 Missing newline before sections or imports.
54:1: I100 Imports statements are in the wrong order. import invenio.legacy.bibformat.dblayer should be before from werkzeug.utils
55:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before import invenio.legacy.bibformat.dblayer
58:1: F401 'CFG_BIBFORMAT_CACHED_FORMATS' imported but unused
58:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
76:1: F401 'CFG_BIBFORMAT_FORMAT_OUTPUT_EXTENSION' imported but unused
76:1: F401 'CFG_BIBFORMAT_TEMPLATES_DIR' imported but unused
76:1: F401 'CFG_BIBFORMAT_OUTPUTS_PATH' imported but unused
87:27: E261 at least two spaces before inline comment
88:28: E114 indentation is not a multiple of four (comment)
88:28: E116 unexpected indentation (comment)
89:28: E114 indentation is not a multiple of four (comment)
89:28: E116 unexpected indentation (comment)
90:28: E114 indentation is not a multiple of four (comment)
90:28: E116 unexpected indentation (comment)
93:28: E114 indentation is not a multiple of four (comment)
93:28: E116 unexpected indentation (comment)
107:33: E225 missing whitespace around operator
192:1: E731 do not assign a lambda expression, use a def
197:1: E303 too many blank lines (4)
197: D203 1 blank line required before class docstring (found 0)
201: D401 First line should be in imperative mood ('Return', not 'Returns')
201: D400 First line should end with a period (not 's')
213: D401 First line should be in imperative mood ('Return', not 'Returns')
238: D102 Missing docstring in public method
282: D103 Missing docstring in public function
288: D401 First line should be in imperative mood ('Format', not 'Formats')
288: D400 First line should end with a period (not 'f')
288: D205 1 blank line required between summary line and description (found 0)
335:45: W503 line break before binary operator
335:45: E127 continuation line over-indented for visual indent
351:8: W503 line break before binary operator
478:27: E225 missing whitespace around operator
481:5: E303 too many blank lines (2)
499:82: E225 missing whitespace around operator
520: D103 Missing docstring in public function
536: D401 First line should be in imperative mood ('Return', not 'Returns')
536: D202 No blank lines allowed after function docstring (found 1)
536: D400 First line should end with a period (not 'g')
536: D205 1 blank line required between summary line and description (found 0)
557:64: E261 at least two spaces before inline comment
557:65: E262 inline comment should start with '# '
564:38: E261 at least two spaces before inline comment
564:39: E262 inline comment should start with '# '
565:48: E261 at least two spaces before inline comment
565:49: E262 inline comment should start with '# '
568:24: E127 continuation line over-indented for visual indent
577: D103 Missing docstring in public function
580: D400 First line should end with a period (not 's')
580: D200 One-line docstring should fit on one line with quotes (found 3)
593: D210 No whitespaces allowed surrounding docstring text
593: D400 First line should end with a period (not 'a')
593: D205 1 blank line required between summary line and description (found 0)
630:57: E126 continuation line over-indented for hanging indent
637:5: E303 too many blank lines (2)
698: D401 First line should be in imperative mood ('Evalute', not 'Evalutes')
718: D401 First line should be in imperative mood ('Analyse', not 'Analyses')
718: D202 No blank lines allowed after function docstring (found 1)
787: D401 First line should be in imperative mood ('Return', not 'Returns')
787: D400 First line should end with a period (not 't')
787: D205 1 blank line required between summary line and description (found 0)
886:13: B901 blind except: statement
917:78: E225 missing whitespace around operator
918:54: E225 missing whitespace around operator
950:47: E261 at least two spaces before inline comment
965:27: E225 missing whitespace around operator
1025: D401 First line should be in imperative mood ('Filter', not 'Filters')
1035: D401 First line should be in imperative mood ('Searche', not 'Searches')
1035: D400 First line should end with a period (not 's')
1035: D205 1 blank line required between summary line and description (found 0)
1061:9: E303 too many blank lines (2)
1075:5: E303 too many blank lines (2)
1078:1: E302 expected 2 blank lines, found 1
1078: D401 First line should be in imperative mood ('Return', not 'Returns')
1092:5: F841 local variable '_' is assigned to but never used
1095:12: E127 continuation line over-indented for visual indent
1104:16: E126 continuation line over-indented for hanging indent
1126:5: B901 blind except: statement
1138: D401 First line should be in imperative mood ('Return', not 'Returns')
1138: D400 First line should end with a period (not 's')
1158:16: E126 continuation line over-indented for hanging indent
1165:1: E302 expected 2 blank lines, found 1
1165: D401 First line should be in imperative mood ('Return', not 'Returns')
1165: D400 First line should end with a period (not 'e')
1197:13: E303 too many blank lines (2)
1211: D401 First line should be in imperative mood ('Return', not 'Returns')
1245:16: E127 continuation line over-indented for visual indent
1255:31: E126 continuation line over-indented for hanging indent
1282:9: B901 blind except: statement
1294:17: E126 continuation line over-indented for hanging indent
1301:1: E302 expected 2 blank lines, found 1
1301: D401 First line should be in imperative mood ('Return', not 'Returns')
1301: D400 First line should end with a period (not 'e')
1345:1: E302 expected 2 blank lines, found 1
1345: D401 First line should be in imperative mood ('Return', not 'Returns')
1345: D202 No blank lines allowed after function docstring (found 1)
1472:1: E302 expected 2 blank lines, found 1
1472: D401 First line should be in imperative mood ('Return', not 'Returns')
1472: D202 No blank lines allowed after function docstring (found 1)
1499:17: E225 missing whitespace around operator
1578:28: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
1582: D401 First line should be in imperative mood ('Return', not 'Returns')
1582: D202 No blank lines allowed after function docstring (found 1)
1582: D400 First line should end with a period (not '}')
1599:56: E225 missing whitespace around operator
1635:1: E302 expected 2 blank lines, found 1
1635: D203 1 blank line required before class docstring (found 0)
1635: D204 1 blank line required after class docstring (found 0)
1635: D400 First line should end with a period (not 'n')
1635: D205 1 blank line required between summary line and description (found 0)
1666:15: E261 at least two spaces before inline comment
1668: D401 First line should be in imperative mood ('Create', not 'Creates')
1700:31: E261 at least two spaces before inline comment
1725: D401 First line should be in imperative mood ('Return', not 'Returns')
1725: D400 First line should end with a period (not 'e')
1740: D401 First line should be in imperative mood ('Return', not 'Returns')
1740: D400 First line should end with a period (not 'd')
1763: D401 First line should be in imperative mood ('Return', not 'Returns')
1763: D400 First line should end with a period (not 'e')
1763: D205 1 blank line required between summary line and description (found 0)
1801: D401 First line should be in imperative mood ('Return', not 'Returns')
1801: D202 No blank lines allowed after function docstring (found 1)
1910:36: E127 continuation line over-indented for visual indent
1913: D401 First line should be in imperative mood ('Return', not 'Returns')
1970:33: E127 continuation line over-indented for visual indent
1981:60: E251 unexpected spaces around keyword / parameter equals
1983:54: E251 unexpected spaces around keyword / parameter equals
1993:37: E127 continuation line over-indented for visual indent
2004:64: E251 unexpected spaces around keyword / parameter equals
2006:58: E251 unexpected spaces around keyword / parameter equals


Nice bravo!
J'avais prevu de faire un truc sale pour ça mais j'aime ce que vous faites!


@mrhsuyen Github界面上，对本项目 Unwatch。


I just tested it and I cannot build my RvtkStatismo, and it fails with that exact error, so this is not an option for me at the moment.


oui oui je m'en occupe sur la 47

Lucas Bettarel

2015-05-06 21:09 GMT+08:00 Remi Pichon <notifications@github.com>:

> tu peux revert juste ce bout de code ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/24HeuresINSA/24h-android-app/commit/25c157d752e063b3c558a24f57e67da7e678d8e8#commitcomment-11064946>
> .
>


wrong indentation


My thinking behind logging by default was that inadvertently precaching an excessively large set of resources was a (Very?) Bad Thing from the perspective of your site's users, and I wanted the total precache size to be clearly logged as part of the build process to give developers full transparency as to how much their users will be downloading the first time they visit their sites.

I would like to keep the total precache size logged by default when users run the code. A `--verbose` option that controls whether or not the size of each individual resource is logged sounds reasonable to me. (Tracked at https://github.com/GoogleChrome/sw-precache/issues/25)

Re: consistency with logging used elsewhere in WSK, using [`gulp-util.log`](https://github.com/gulpjs/gulp-util#logmsg) as the logging function in the config options should help with that. I need to be agnostic about which logging function to use in the module itself, since it's meant to work in either `gulp` or `Grunt`.


Really nice, compact fix. It is working great on SSL now too on the browsers I tested!


@mrhsuyen https://github.com/settings/notifications


aka Meteor.startup() is working


Wow, thanks!


> By the way, from time to time I find G_LIKELY and friends in the code and I kind of can't stand those guys - I have never seen any performance improvements using these (I can imagine it could happen in some tightmost loop where you are just adding integers or something similar) and IMO  just add noise to the code. Would it be OK to remove these (when I have time for that)?

I don't know if searching the code to remove those makes much sense, but yeah, we came back from that and prefer not to have them now.  I think we might even have a short ML thread about that.


Or is there a way to additionally link against the library to avoid that error?


You're welcome! It was a tough problem. Luckily I could reproduce it locally. Otherwise I wouldn't be able to find it.


I recommend controlling where it installs things, by doing:  https://github.com/Project-OSRM/node-osrm/blob/sudo-false/.travis.yml#L61. Then put the final path on PYTHONPATH like: https://github.com/Project-OSRM/node-osrm/blob/sudo-false/.travis.yml#L52-L54


Remove this include line. There will be general instructions for including and working with the Pattern Library that will include these types of instructions.

Installing Bower and adding the language line should be good enough for now


player/decoder want to know MaxBuffers, Optimal is not known at this stage because we don't know the format. The current behaviour is correct, I think I messed the function names up when I did search/replace on this.


awesome. That is way better. This patch is pulled from upstream though. Is there any downside to carrying a different patch here then upstream? (upstream being enovance/hardware)


wait a minute, I am still wondering why this library? I have ran this script from vtk master...
Can you check with the source corresponding to the release version of vtk you use, please?


missing: "Do not bump the existing session."


WoW! Devils in the details！


Sorry to be a pain but I'm still a little confused. I've got two simple Smart Answers in this [gist][]:

* [Smart Answer 1][sa1] using `next_node_if`.
* [Smart Answer 2][sa2] using `next_node` and `permitted_next_nodes`.

The visualisation of Smart Answer 1 shows a [connected graph][sa1-graph] (as expected) while the visualisation of Smart Answer 2 shows a [disconnected graph][sa2-graph]. Would you expected Smart Answer 2 to show a connected graph in this case?

[gist]: https://gist.github.com/chrisroos/1c28a23826004e942977
[sa1]: https://gist.github.com/chrisroos/1c28a23826004e942977#file-example-flow-with-next-node-if-rb
[sa2]: https://gist.github.com/chrisroos/1c28a23826004e942977#file-example-flow-with-next-node-and-permitted-next-nodes-rb
[sa1-graph]: https://gist.github.com/chrisroos/1c28a23826004e942977#file-example-flow-with-next-node-if-png
[sa2-graph]: https://gist.github.com/chrisroos/1c28a23826004e942977#file-example-flow-with-next-node-and-permitted-next-nodes-png


In trusty it is vtk-6.0.0 and in vivid it is 6.1.0 same errors in both (and debian experimental with 6.2.0)


Patch this to use only static memory


Why the big version gap? To match RAML version 0.8?


I am using 'switch on stings' in my project which is a Java 8 feature. You should get 8 working so we don't have to limit ourselves


Thanks for great efforts in improving this great software:).
I have encountered a problem here. When I enter a new client info and click the save button, the animal column on the right still appeared grey out. I can't add the info of the animal. Weirdly, this problem just occurs sometimes with some particular clients.
Here I attach the terminal traceback.

Traceback (most recent call last):
  File "/usr/local/lib/evette/clientmethods.py", line 684, in SaveClient
    self.clientdata = CheckForExistingClient(self, self.clientdata, notebook).clientdata
  File "/usr/local/lib/evette/clientmethods.py", line 2413, in __init__
    if miscmethods.ConfirmMessage(self.t("possibleduplicateownermessage"), self.parent):
  File "/usr/local/lib/evette/clientmethods.py", line 2387, in t
    return miscmethods.t(label, self.localsettings)
AttributeError: 'module' object has no attribute 't'

Will be grateful if somebody can solve my problem. Thank you very much.


Now I can finally upgrade to BC7 :P


@jlucerond if you can give more descriptive commit names that will help - it's ideal use of the opportunity to describe what changed to yourself and others.

done with my review. very good work. press on!


Spelled "Subverse" wrong


Does that mean that right now people that don't have access to cloudflare ends up waiting 7s everytime they load a tree ?


Move this to a separate file in this package please (since it's pretty long)


No, it's related to the explicit PCR discontinuity  in some HLS streams


bashCompletionFunc for the constant name


ok


@jlucerond adding some features is very simple. just takes a bit of discovery. nice.


Is this technically true? You can still `unpin` a formulae and then do `brew upgrade formula` rather than `brew upgrade --all` ?


@jlucerond done with my review. good work.


I think we need to include the upstream resources as well - our map should be Kube base + OpenShift overrides.  @fabianofranz can you review the rest of this?


In this case shouldn't you also rename the function?


Perfect, thanks ;)


7 seconds is quite a long time...
Do you know how long it takes to download jstree on a "typical" connection ?
If we imagine it adds an *entire* second to the page load time then this would only make sense if we had 7 times as many public website visitors with the cdnjs file in cache as we have intranet users with restrictive firewalls...
Given the relative obscurity of jstree (less github stars than cjdns), I suspect even with this enormous estimate, as long as one intranet with 100+ users has a restrictive firewall, your optimization is still, on average, costing page load time.


- Good job so far


Issue #32


please remove FIXME.

and add some documentation along the lines of `UserName` is the only metadata for now, but that will change in the future`.


Why did you import this?


> Makefile settings are almost exclusively named after the platform capabilities rather than application features...and IMO this is how it should be.

Here we disagree. It is much easier to work with source code whose naming reflects the intent rather than the implementation details.

When it comes to something like `HAVE_LIBPCRE`, it gets a bit murky because, yes, you need to guard that code that works only with LIBPCRE.

But in the case of `HAVE_NTDLL`, this should probably be detected at compile time, whereas we cannot detect whether the intent is to support MSys2-backed terminal emulators, that setting we have to specify via the `Makefile`.


Hmm, I thought [this testing function](https://github.com/lifthrasiir/rust/commit/3d34e177dd19bfbc6885b03eac0632adc9c621b2#diff-9047455993978e2707540f960e9fe934R110) exactly does that (the function essentially acts as a test generator). There are some existing test cases triggering this code: for example, `minf64` test in `f64_exact_sanity_test` will trigger this case when rounded at the second-to-last digit.


Je sais pas si ça vient d'ici, mais j'ai eu ça à l'ouverture:

 Process: com.insalyon.les24heures, PID: 14244
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Iterator java.util.ArrayList.iterator()' on a null object reference
            at com.insalyon.les24heures.service.impl.ScheduleServiceImpl.fromDTO(ScheduleServiceImpl.java:143)
            at com.insalyon.les24heures.service.impl.ResourceServiceImpl.fromDTO(ResourceServiceImpl.java:51)
            at com.insalyon.les24heures.service.impl.ResourceServiceImpl.fromDTO(ResourceServiceImpl.java:94)
            at com.insalyon.les24heures.service.impl.DataBackendServiceImpl$1.success(DataBackendServiceImpl.java:89)
            at com.insalyon.les24heures.service.impl.DataBackendServiceImpl$1.success(DataBackendServiceImpl.java:66)
            at retrofit.CallbackRunnable$1.run(CallbackRunnable.java:45)
            at android.os.Handler.handleCallback(Handler.java:739)
            at android.os.Handler.dispatchMessage(Handler.java:95)
            at android.os.Looper.loop(Looper.java:135)
            at android.app.ActivityThread.main(ActivityThread.java:5254)
            at java.lang.reflect.Method.invoke(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:372)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)


Exactly. It supports now the whole RAML 0.8 spec.

> Am 06.05.2015 um 16:52 schrieb David Dossot <notifications@github.com>:
>
> Why the big version gap? To match RAML version 0.8?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/nidi3/raml-tester/commit/094fd99b0f85d7c91605c9592cc7afaf20b3eadf#commitcomment-11067219>.
>


Why not babel?


@TheJulianJES - experiments


Same here, this optimisation seems to have more cons than pros to me.


Sorry, MSVC autoformatted it.


Fixes https://github.com/StackStorm/st2express/issues/49


@asiekierka Okay :)


why not just alter the original `bld.install_files` like that?
```python
bld.install_files('${DATADIR}/%s/filedefes' % data_dir, start_dir.ant_glob('filedefs/filetype*'), cwd=start_dir)
```
but maybe it doesn't work, in which case ok, looks alright


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14583/testReport/) for this commit**


You might have not gotten an updated maven snapshot.  If you don't force it with `-U`, I find it's rather random about when to check for snapshot updates.


fixed, thanks


Thanks ! You saved me a lot of research
: ]


thanks !


Ok. What about this:
```
exports.destroy = _.compose(exports.cleanup, exports.destroy);
```


I don't want while(1) in my test. There must be a better way to test this.


Oh ok. I provided @jeanlf also with a PCR loop that was causing issues. I can provide it to you if you're interested in testing :)


ok


ok i will try (without use google translate \m/)

well, i use this because draw things directly on 'content pane' (? i don't know all writable object that support bufferStrategy...) the things get much slow, so we need to use BufferStrategy to create a buffer when using a Graphics2D... ( poor explanation )

i'm not a official game developer but we need to create a bufferStrategy with double or triple buffer to get a 'real' playable game without pauses ( sprites and scenario with lags/delays )


Not really. can't we just add an index?


I added an issue


yeah


@doudou i created this subcommand (needs cleanup before merge but should work)

i generated this new buildconf:
https://github.com/goldhoorn/buildconf-play-rc.git

unforutnalty the file
https://github.com/goldhoorn/buildconf-play-rc/blob/rock-rc/overrides.d/25-release.yml

got updated with the right PR from shoppel but it does not include all drivers or orhter ones anymore, can you give me a hint?


注释错误修正


Here you import logging from six, but in other files it's left alone.  Why is that?


Heh, that's cool. Performance is so hard to intuitively reason about.


like a LOG api to System.out.println
or
A Buffer for bytes
this is for Graphics API , well I understand this way..


yes, I would have expected smart answer 2 to show a graph as well. Hmm. Maybe it never did work that way. Sorry, I'm stumped. Even when I [first added the visualisation code](https://github.com/alphagov/smart-answers/blob/a5c4e14dad70d225bab318c8f8815992fc94e09f/lib/graph_presenter.rb) it looks as though `permitted_next_node` was not taken into account. Maybe I had been intending to do that but found that it was just as easy to actually do the conversion to the `next_node_if` type syntax.


adding a comment at the top of `ItemFetcher.h`


Yeah, working towards that separation sounds good. We don't need a tracking issue either, I'm sure it will come up again :)


I don't see where filetypes.common is handled below?


yeah it's hidden pretty well :D


"nästa två delarna" känns fel, kanske borde vara "kommande två delar", "de två följande delarna" eller "nästkommande två delar"


@bnoordhuis there's a few linter warnings introduced here:

````
src/node.h:51:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
src/node.h:59:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
````


This seems to change the command line compared to the python implementation?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14586/testReport/) for this commit**


granskad


here `document_relaod_config()` should only be done once at the end, or the filetype loop should `break` once found.  Actually `break` would make sense as saving a file can only match one path.


this is nice, but can't this get a bit slow for no reason when saving all files?


That one can't work since integer_types is a tuple.


tuple here too.


I'm a bit brain-dead already, so cannot really understand the change you made. What concerns me is the unit test name.

Are there any assumptions on the order of feeds in the file?
I think we are safe to assume that Paket should process the sources as they appear in the dependencies file:

internalfeed
globalnuget (contains Moq)

so that if we changed the order of the sources to:

globalnuget (contains Moq)
internalfeed

Then the installation should succeed as well. Which means that the package is added to the first feed on the list which has the package, not to the last one.

If the code already does what I said, then I think the test should be renamed. And there's should be probably a second one that tests the reversed order.


and here.


56:1: I201 Missing newline before sections or imports.
57:1: I201 Missing newline before sections or imports.
60:1: I100 Imports statements are in the wrong order. from invenio.base.decorators should be before from werkzeug.local
212:5: B901 blind except: statement
280:9: E731 do not assign a lambda expression, use a def


I don't think we really need to remove the group here. It will not be added by build-init, and if the user manually added it we should respect that.


this allows to use World_New several times (as needed by internal server)
If not World_Cleanup would deinitialize plugins for ever... and crash


And I do not see a situation where you can call a cleanup and then somehow to use widget.


It is also possible to remove the entry from the Tracker's destructors. Either works. I can code the destructor version if you would find it more readable; it won't change the behavior in any substantial manner.


I think the utf-8 encoding should be done right before returning. Did you test it with an input string containing non-ascii data?


And if Ettercap is running on a big-endian machine? Seems this function is always called regardless of endianness.


We should probably report an error if there is no "=" in the argument


You're absolutely right.
I will correct it


Woo hoo! :+1:


Onay


I think this is clean and git-happy now. Ultimately if we get refguide_check working more reliably someone will presumably have a massive PR that fills in anything still missing.


So I'd rather see this be a positive conditional rather than a negative. Something like this maybe?

```
deliv_version = version == 'latest'? client.artifact_latest_version(...) : version
```


I can not compile deepfishz in linux.
I made some corrections and now if I can compile.
Are changes correct?

/*
  Stockfish, a UCI chess playing engine derived from Glaurung 2.1
  Copyright (C) 2004-2008 Tord Romstad (Glaurung author)
  Copyright (C) 2008-2015 Marco Costalba, Joona Kiiski, Tord Romstad

  Stockfish is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  Stockfish is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  You should have received a copy of the GNU General Public License
  along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/
#include <stdio.h>
#include <iostream> //<-----

#include "thread.h"
#include "tt.h"

using namespace std;

#define TRUE 1
#define FALSE 0

int large_use;

#ifndef _WIN32 // Linux
#include <sys/ipc.h>
#include <sys/shm.h>

static int num;

#define MEMALIGN(a, b, c) posix_memalign ((void**) &(a), b, c) //<--------
#define ALIGNED_FREE(x) free (x); //<--------

void SETUP_PRIVILEGES(){} //<--------

void CREATE_MEM(void** A,int align,uint64_t size)
{
	large_use=FALSE;

	num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
	if(num==-1)
	{
//		printf("info string LargePages FAILED %llu Mb\n",size>>20);
		std::cout << "info string LargePages FAILED %llu Mb\n" << (size >> 20) << std::endl;
		MEMALIGN((*A),align,size);
	}
	else
	{
		(*A)=shmat(num,NULL,0x0);
		large_use=TRUE;
//		printf("info string LargePages OK %llu Mb\n",size>>20);
		std::cout << "info string LargePages OK %llu Mb\n" << (size >> 20) << std::endl;
		std::cout<<"info string HUGELTB "<<(size>>20)<<std::endl;
	}
}

void CREATE_MEM2(void** A,uint64_t size)
{
	large_use=FALSE;
	num=shmget(IPC_PRIVATE,size,IPC_CREAT|SHM_R|SHM_W|SHM_HUGETLB);
	if(num!=-1)
	{
		(*A)=shmat(num,NULL,0x0);
		large_use=TRUE;
//		printf("info string %llu Mb LargePages\n",size>>20);
		std::cout << "info string %llu Mb LargePages\n" << (size >> 20) << std::endl;
	}
}

void FREE_MEM(void* A)
{
	if(!A)
		return;
	if(!large_use)
	{
		ALIGNED_FREE(A);
		return;
	}
	shmdt(A);
	shmctl(num,IPC_RMID,NULL);
	large_use=FALSE;
}

#else

Thanks


O nome correto do método é cadastraTurma


Why?

On Wednesday, May 6, 2015, Tom Duffield <notifications@github.com> wrote:

> So I'd rather see this be a positive conditional rather than a negative.
> Something like this maybe?
>
> deliv_version = version == 'latest'? client.artifact_latest_version(...) : version
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opscode-cookbooks/delivery-cluster/commit/eddf7b1e4c07894b889e5da1200eccf266c152db#commitcomment-11067843>
> .
>

--

*Salim Afiune* — Solutions Engineer

917.716.0448 – afiune@chef.io – *my: *Linkedin
<http://www.linkedin.com/in/afiune>  Twitter <http://www.twitter.com/afiune>

CHEF

      CHEF.IO <http://www.chef.io/>

TM

*chef.io <http://www.chef.io/>*   Blog <http://www.chef.io/blog/>   Facebook
<https://www.facebook.com/getchefdotcom>   Twitter
<https://twitter.com/chef>   Youtube <https://www.youtube.com/getchef>


This way if `opts.scale` is `0`, it will fall back to `1`. If that's the the behaviour want, we should at least document that.


You need to either always set error on failure, or not have one. And if you do, you should have a gboolean return too to make the error optional. However, in this case we can imho just ignore the errors, they would be internal errors in the app/runtime metadata anyway.


Please, remove as per general agreement that we have


You are storing the python value in the property lock, rather than the json value.  If two python values do not compare equal, but do have the same json representation, then this would be problematic.


Here, you are comparing the json value with the property lock value (which above is the python value).


Please use strong_parameters instead of plain params hash.


Can you add something like:
```
$types = node_type_get_types();
if (!isset($types[‘organization’])) {
  drupal_set_message(t("Organization content type not detected. MigrateCkanOrganizationBase is using Group content type instead."));
  $this->destination = new MigrateDestinationNode(‘group');
  }
else {
  $this->destination = new MigrateDestinationNode('organization');
  }```


Well, ain't that annoying.  https://github.com/iojs/io.js/pull/1640


this line needs to be inside an if block to retail backwards compatibility with current configurator.
```if (currentPort->dataSize >= 11) {//allow for yaw expo
currentControlRateProfile->rcYawExpo8 = read8();
}
```


Redirect to :show action instead and use url_helpers.


I think we should explicitly g_unsetenv() if var->value is "", because then code that checks if the env var is set at all (getenv() != NULL) will work, and I can't think of any code failing if some environment variable is not set.