Added packages for dev and test.

Dev:
Promises: Bluebird, best impl around.
Nicer HTTP client: SuperAgent, and a Bluebird Promises adaptor therefor
Logging: Bunyan, which can persist via DTrace
Linting: JSHint

Test:
Framework: Mocha, the one and only
Assertions: Must b/c Chai is an unprofessional Ruby-ism
HTTP test doubling: Sinon and Nock, the gold standards


please remove syso


could use stamp_dir = os.path.dirname(stamp), avoid invoke os.path.dirname twice.


Nice catch. Will fix this.


typo ;-)


dict中這一行有tab，我轉換時失敗了。
```python
yaml.scanner.ScannerError: while scanning for the next token
found character '\t' that cannot start any token
  in "<unicode string>", line 12, column 15:
    version: "1.2"	#2013.11.17
```


Yes. you are right. I will modify that line
thank you


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430891645400
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430891653277
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


This is the Voidcon Group Management System


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430891683283
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430891698246
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Esa es una cosa para el futuro, todavía no hago el commit de la tienda.
Pd. En ninguna parte dije que servía, de hecho lo principal es el
constructor que añadí.
El may. 5, 2015 6:26 PM, "Jesús Alejandro Lara" <notifications@github.com>
escribió:

> No sirve ._.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ppoo14152/BigFishing/commit/f0107704a5ad610a5545f2a84b0777c975137b31#commitcomment-11056190>
> .
>


Please find a better name or i will call you bornByParent ;-)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430891816575
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


I think this comment is redundant with the message() below.


Because that we have to prepare out tests for two situation (1. with a clean db, 2. run not with a clean db) I would like to discuss strategies for handling database cleanups before a test starts. IMO a test should care about its setup and never reuse a test setup from another test.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430892053286
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Typo: dependencies


Yes on linux we don't have any touch input handling logic. If you have a touchscreen attached to a raspberry pi running raspbian it will most likely detect your touches like a mouse and not like a touchscreen device.


Yes, at least let's try to see because users from my community can't use gestures typing


thx. i agree we need to focus on the classes.


Parenthesis should be on end of line, not on its own line


yeah did not bother moding it yet..
But it is def usable.

On Tue, May 5, 2015 at 11:27 PM, buildersbrewery <notifications@github.com>
wrote:

> This looks good for a start. The test file needs some work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dimentox/linden-scripting-language/commit/19a7b16a77741437a224f59618e604a478d5458e#commitcomment-11058802>
> .
>

--
-------------------------------------------------------------------------------------------------------------------------------
This email is a private and confidential communication. Any use of email
may be subject to the laws and regulations of the United States. You may
not Repost, Distribute nor reproduce any content of this message.
-------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------


Use a common template for this and UNIX_CFGCMD above?


Test was never modified


woah!!! Only for mysql? Why not creating then another test task specific to this instead of slowdown others. Or running tests against mysql with different DBs instead of all against the same DB. We would avoid the cleanup and could run tests in parallel. Please lets discuss.


Could be set to ${MAKE_PRG} to build before installing


i need to double check the BNF for this.


See comment below


These are left over from c++  i need to grab the BNF and get it modified... its a work in progress  =)


That actually throws an error on one of the other linters..


Add courses


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430892493197
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


The description of the commit should have had the below in it, to auto close (and link)

> Closes/Adds #1


This is not true. Also in case of h2-memory the db is not cleaned.


LGTM


Remove class


add Array.isArray and Array.filter function for old IE browsers, so that directorjs can used in old IE browsers without any other polyfill  libraries


Так как переменная вне цикла нигде не используется, то лучше объявлять ее внутри и сразу инициализировать как `entriesNumbers.get(i)`. Еще стоит, наверное, переименовать ее в `currentEntryNumber`, чтобы было единообразно с именем массива (`entriesNumbers`).


Why is it not enabled for all dbs?


Это надо вынести из цикла (в `parsePattern()` так и сделано).


User passed to searchByCriteria could be Optional.fromNullable(user): for non authorized users will be Optianal.absent()...


Thanks for all the stuff. But you missed to describe all your changes in the commit message which would be good to understand your commit. It would also be nice to separate commits in chunks that belong together makes reviewing them easy but sure the chance is higher that I fall at sleep in the middle of reviewing and then with my head on the key to approve the commit ... Point for you ;-)


"Able to start monitor mode".. using aircrack v1.2 rc2 :)


"This is a private paste."


Could you explain please why this change is necessary?


To all: how about separating properties by empty lines? For me this is not very good readable.


if (!user.isPresent()) {
 // Non authorized users can found only "public" monuments by location
  // pseudo code
  searchCriteria.category = Category.PLACE_MONUMENT
...
}


Can you just raise a ValdiationError here and have `_backend_error_handling` take care of the logging? You'll loose the entire result from that backend, but that's just punishment for giving us bloated results.


Thank you for bringing it back. ;-) But I still would like to discuss the change.


Wonder if `array_keys` would be faster on the outer one.

Just benchmarked it and found *no* difference.


Test Branch comment


The advantage of using iterators is that it works with anything that can become iterable. For example, ```validBST('123') # A string argument``` is valid. Also, it iterates over every value exactly once. *How* it iterates is a complicated dance of nested iterators, with a lot of throwing StopIteration exceptions at the end, but that’s no real worry.


This is _exactly_ the same as before, conceptually you leave to set
position the decision if the game is new or not. But there is nothing for
which we should assume this is true in all the cases.

I don't understand why you don't rely on ucinewgame that, as the name
implies, it _is_ the documented way to tell if a game is new or not.

On Wed, May 6, 2015 at 12:01 AM, VoyagerOne <notifications@github.com>
wrote:

> @mcostalba <https://github.com/mcostalba>
> Ok what about this:
> We will have a bool in Position file called isNewGame
> This will be set to True during position::set...than False at position
> make move.
>
> Then all we need to do is reference that bool in the Search file.
> if (isNewGame) clearStats
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VoyagerOne/Stockfish/commit/1a695bbdcb7b00495c324ac62ad60d2ba4008c39#commitcomment-11054926>
> .
>


Performed a review, proposing to accept this pull request.


Is this always a string? Could it be other types, such as integer, etc.?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1430893344853
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Would be nice, yeah


Create some formatting rules for code  - preventing useless change like this


repeat


I tested it. It works but I can tell the difference between the media player (VLC) and in game.

I created my own sound effect to try out, it seems the mod/game plays it at 0.5 of the normal speed. I know some entities can "slow down" or "speed up" the playback rate of a sound (e.g. zombies vs. baby zombies), wouldn't this be the problem?


This API can reuse the GetServerDefinedTypeName(type).


No need to cast.


Agree with Marco. Clearing stats (if at all) should be done on ucinewgame. I would add that Clear Hash should clear stats as well: makes sense for consistency sake.


haha, funny mistake :D good to merge


@ryanhiebert Yeah, I really the idea of `d2to1`'s use of the `setup.cfg` but as long as it's not adopted by a larger audience (or "blessed" in some way by Python core) I'm afraid of betting on the wrong horse. I know `pbr` is basically a fork of `d2to1` and adds a few more features, but that's about it. I know it's the de facto standard for Python packages that come out of the OpenStack community. That's about it, really.


Instead of passing the map into function, it can be class internal property or attribute and have functions directly use it.


@pierreinglebert: so, is `parseInt` needed here? For `bin/zopfli` you check about it a few lines below.


Database có chưa vậy nhóm Back-end.......


评论？


I take it you're using Python 2.x to run this, because when I run this with Python 3.x, this commit fails, I get a TypeError for not specifying the encoding I want to use. I feel it'll be better moving forward if we stick to Python 3 for the library. With that in mind, I'll merge this pull request and then over write the commit with one that replaces this commit. This is because I honestly do not know how to do partial merges, yet.


Not exactly a big fan of hard-code map here. Since it's processing mysql specific statements, the better way to do it probably defines the proper keywords and have the parser correctly identify keyword tokens and non-keyword tokens. I'm fine with the current implementation considering the amount of changes that need to be made, but we definitely need to come back and improve/refactor this implementation.


why we need this bool? can we directly check whether edmStructuredSchemaElements is null?


From the commit message:

```
In particular when upgrading from a 32-bit to a 64-bit version of Git
for Windows, we really need to remove the files from the previous
version first (because there will otherwise be left-over files in
`C:\Program Files (x86)\Git` that will never get deleted).

The "system-wide" Git config (previously in `/etc/gitconfig`) needs
special care: as agreed with the libgit2 project, we share the
Windows-wide Git configuration in `%PROGRAMDATA%\Git\config` now.
```

I.e. the previously installed Git for Windows version will be uninstalled, and if no Windows-wide Git config exists yet, the  one from the previous version will be copied into place.

No files added by the user will be deleted -- same as a regular uninstall.


Yes.


This will never be touched. if no such row, the `var row = ...` will throw exception. or it will not be null.


  Александра, ты уж укажи тогда - Николай I или Николай II.
  ;-)


To make sure some had really review to the code :)

Actually this particular one demonstrate the reason why I had to switch to the browser microtask queue. As the code used to schedule microtasks within zone.js `run()` and the code (l 7-11) is not wrapped into a `zone.run()`, when the next macrotask executes (the `setTimeout()`), the microtask would not have been executed - and would only execute at the end of the next macrotask.

This is describe in the comment and the linked issues.

I need to unxit other tests as part of the cleaning before the merge.


ok


same as before


Are you mean this can change after mount?


Александра, пожалуйста, уточни что за мелочи ?


s/`"scalaz"`/`"scalaz-core"`


Hi, I add this in functions.php . Is this correct?

/* Add Foundation JS */
wp_enqueue_script( 'foundation-fastclick-js', get_template_directory_uri() . '/foundation/js/vendor/fastclick.js', array( 'jquery' ), '1', true );


I don't think we need add a new usecase for XwalkActivity, since all usecase are updated to based on XWalkActivity in PR#2802


We won't forget, we have integration tests :-)


thanks! e687d13bb8ce36ce2d21642b5a2196d3d051c3d9


Related to #60


I can't see the LittleEndian class here but should we be using the unsigned version of the setter if they exist?  Just looks a little unusual to see the unsigned versions for the getters and not the setters.


Ouch.. perhaps we should do a code search for this sort of pattern and explicitly comment the lines where it is acceptable, as this is a common error.


Remove. We shouldn't change public API. "public" monuments shoud be returned in places collection.


Hmmm, I did this in a hurry.
I don't know which one is the best for int coercion, this one is leaner and the other specify the radix...


what the fuck?


The camelcasing in --permitEnv seems a bit weird --permit-env is more in line with how options normally look


For node, it shouldn't matter specifying the radix, but I'd say make this consistent like the other file.


We are in java. No underscore in names, please. :)


ah, you're right. that's more elegant, actually. will change.


ExoPlayer will not support [MediaExtractor](http://developer.android.com/reference/android/media/MediaExtractor.html) anymore ?


Remove.


This function can be simplified to
```
has_value = attribute_name_to_has_value_map.get(token_value)
if has_value:
    return self._generate_attribute_token(token_value)
if has_value == False:
    return None
return token
```


Same here, the other keys look like "permitted-env-vars"


@Godin That is the product website for SonarQube C# Code Analysis. The code analysis is a separate product from the C# plugin, so it makes sense to have a dedicated site.


Yeah this wouldn't have anything to do with actual knot theory I think.
Sounds good though.

On Tue, 5 May 2015 21:16 Geraint Palmer <notifications@github.com> wrote:

> Yes in the definitions section. Its not the same as from Knot Theory
> (don't really know what that is), but a specific thing for directed graphs.
> For 2 nodes like we've been looking at it is totally equivalent, but not
> for more than 2 nodes, so had to change it.
> The knot detection thing is mentioned in deadlock detection, so I think
> its a standard thing, but hasn't been used in queueing theory as far as I
> can see. So not very 'original'.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geraintpalmer/DetectingDeadlockInQingNetworkSimulation/commit/501cf2b3a4689acf1404c5895fd6c2a50df4c9e9#commitcomment-11052824>
> .
>


These executors remain alive/running after test, you should shutdown them.


this should never change after mount. i meant `if (!m_filestore_splice)` is an optimisation which could be misleading for readers: that we can call this method multiple times after loading the FileStore. but yeah, it does not hurt. just my 2 cents.


Are you sure this is a quick test? Maybe you should convert this to a stress test of its own.


Hi Francois,

could you please add a small example script, which is
demonstrates this feature?

Thanks


g_autofree just calls free, but you need to free the whole strv. You can use glnx_strfreev here.


We should go for subcategory of place:
- remove this
- add subcategory "monument" (enum SubCategory {MONUMENT} )
- add subcategory attribute to Poi


Thanks. I will fix that.


ghg


In general in glib code we check the return code (permitted == NULL) rather than the error, because it is allowed to pass in a NULL for the error to ignore error details.


You have a typographical error here


1. Should be: curl -v "http://localhost:8000/q?lg=53.43&lt=14.55&radius=1000 (no user = category=PLACE, subcat = monument)
2. And how to add some places without owners?


To match glib style this should return a boolean as well as return the error out.


@perploug  I'm hoping one day you'll learn the correct naming conventions! :P Can you please change to ProperCase. ALL c# methods and properties are ProperCase. Here's the gist again:

* Methods/Properties (get/set) = ProperCase
* private fields = _underscoreCamelCase
* variables = camelCase

Better yet, please use resharper so we can all keep things consistent.


Thanks @B--B
My fellow contributor already used your source update to create new look that you made,
+ few special options for my kernel, and colors that i like.
if you want to check it out,
https://github.com/dorimanx/LG-G2-D802-Ramdisk/blob/kitkat-ramdisk/ROOT-RAMDISK/res/misc/payload/STweaks.apk?raw=true

i dont have the source... but i am sure i can ask to publish it, if that is needed.
Any way, BIG thanks for your work. :)


Remove


@halfcrazy @dongweiming 我还发现了这样查找的问题, id是通过设置property来实现属性了, 这样查询会存在问题吗? 有测试了吗, 感觉性能会有问题


Optional<User> user


Why case insensitive comparison here?


Sorry! horrible habits die hard :)


Optional\<User\> user


Now fixed.


FIx user


1000 is too much as it causes lags(it even can cause hang) when there are too many apps that consumes CPU.


Nice!


Remove class


Thanks, this is much more clear and to the point.  Looking forward to your update on your page break CSS :)


I know it's super early days so let's keep these model 'parts' named with 'Display' but I have a feeling once these are all being used to persist data and validate, that these new PropertyType and PropertyGroup models might be quite specific to the content type editors in which case we should rename them to be ContentTypePropertyType and ContentTypePropertyGroup (like we have with content). Anyways, we'll see how it goes.


Congrats!

I came up with a variation of this idea. Since there is some overlap between history and countermovehistory, and because CMH takes longer to max out, maybe there is some benefit in removing history completely, and not clearing the CMH? Right now, I don't have time to do the changes myself...


To be simple, how about using 64k?


maybe let conn support String() function may be better, so we can use %s directly in format.


> if u're building on Build-Server then -j5 is OK .. but if u're building on your Laptop with Single Core then don't use -j ...

lol, did you seriously thought I use -j5 on laptop with single core??


> Can we can bool skip_sloppyscrc(default value is false) in _do_copy_range to avoid this method?

that also works. and we need to restore it after changing it, because this setting can be changed at runtime, as FileStore is a subclass of `md_config_obs_t`.

but the idea of changing a config value in order to tweak the control flow is difficult for readers. this change is neat, but personally, i'd think that extracting `_crc_update_clone_range()` out of `_do_copy_range()` might be a better compromise. and to address your, we can document `_do_copy_range()` with some notes about its connection with `_crc_update_clone_range()`. what do you think?


for the different levels of damaging, you should change the color of the swords (red for highest level)


better to add 'copy:json' task in 'build' dependecies


Just making a note that this won't be necessary here, validation for all of this will most likely be done with model attributes.


would be nice to get this commit in a release, this took a while to research for CocoaDocs


Yeah, the reason its there is just display what validation settings the property type has, it is probably more correct to have a seperate PropertyTypeValidationDisplay class for this?


зачем это?


maby better to create special folder for **data.json** like **data** and put there this mocking stuf.


*versions*, not *functions*.


this is bad idea to write extensions in route


два конструктора -- избыточно


getStringException должен возвращать StringException


почему реализация не по месту объявления?


This was actually a sloppy commit that didn't handle the PATH correctly. I fixed that at later commit.

Great point on the license.  Bats uses MIT-style license, so there's no big issue.  Moreover, we're not modifying Bats or "linking" it with our code, so there hardly can be an issue.  Think of this analogy: Bash is GPL but all sorts of proprietary software include Bash scripts to perform installations, start/stop, etc., and that has nothing to do with Bash's license. :)


Please add the progress indicator instead of activity indicator


Copying the text I sent you via PM, the idea being to be able to detect microtasks scheduling in the outer zone:

```

That's a very good question. I'll try to give a short and mostly correct answer, we can discuss the details during the review:

1. Assume that all the code run either in the inner (VmTurnZone.run()) or outer zone (VmTurnZone.runOutsideAngular())
2. A macrotask  is executed in the inner zone and enqueue a microtask in in outer zone (promise.then(fn), with promise created in the outer zone)
3. At the end of the macrotask if we are not able to detect that a microtask has been enqueued, we will run the change detection
4. Now the microtask executes and enqueue more microtasks in the inner zone
5. We will run the change detection again after those microtasks have been executed, it would have been executed twice in a single turn.

Without overriding scheduleMicrotask (= without outer zone), we would execute the CD twice due to 3.

Note: es6-promise do not capture the zone when a Promise is instantiated then in JS the outer zone might be superfluous.
OTOH I kind of like like that JS & Dart implemntations of VmTurnZone are mostly similar, it will help with maintenance.
```


Ah right, yeah that will work too. Neither of those are 'required' so we don't need to add attributes to that model. All good! :)


как это теперь ревьювать: добавление и удаление строк отображается

лучше удалить старый проект, и добавить новый, тогда код будет целостным


This file is missing the prior items:
https://github.com/openemr/openemr/blob/master/sql/4_2_0-to-4_2_1_upgrade.sql#L64-L94


hpp означает, что не будет cpp


You can also use a test factory, that takes the index as an arg, and creates a test


Place these two above in the #IfMissingColumn list_options toggle_setting_1


Place all the rest in the #IfMissingColumn list_options toggle_setting_2


I didn't describe correctly.
FileStore::_do_copy_range(int from, int to, uint64_t srcoff, uint64_t len, uint64_t dstoff, bool skip_sloppycrc=false)
>>if (r >= 0 && !skip_sloppycrc && m_filestore_sloppy_crc) {
>>    int rc = backend->_crc_update_clone_range(from, to, srcoff, len, dstoff);
>>    assert(rc >= 0);
 >> }

In _do_sparse_copy_range, we still do _crc_update_clone_range.


Place this table above in alphabetical order and follow the formatting of the other tables.


Nice!


Straight-forward :)


需要替代你的app id


Don't update the settings. Instead modify them at their source above.


@fehmicansaglam
Why raw query cannot work with client.execute()?


уберите этот конструктор, пожалуйста


Or something like `rfcTests.forEach(function(test, ix) { it('bla' + ix, ...); });`


Looks awesome in game :-D


Thanks so much for seeing and testing this, I'm very grateful.  Are you on PC or Mac?  It seems how this sounds plays may depend on your platform, because I can't hear anything on 2 PCs ...

Some of the other GC sounds are stereo I think, but I should try mono here.  I'm wondering if there is metadata in the .ogg file which is affecting playback speed.  I'm a bit of an Ogg newbie as you can see :)

There's also an issue where this sound is not positioned at the Astro Miner but seems to be "everywhere" currently, which isn't intended.  It should be positioned like a rocket sound.


Nechybí u té Gentoo šablony jedna špičatá závorka? Takhle to přemaže celý inittab, což asi není úplně dobře. :)


I could actually see this throwing people off.


You should be able to collect the parameters for this function from the calendar entry(with the pceid).


The purpose of the `_process_attribute_name_token` function is a little strange here. This loop can be simplified as
```
attribute_name = None
expect_value = None
...
while (...):
...
    if attribute_name is None:
        expect_value = attribute_name_to_has_value_map.get(token.value.lower())
        if expect_value is None:
            attributes.append(token)
            continue
        attribute_name = token.value
    else:
        token_value = token.value if expect_value else None
        attr_token = self._generate_attribute_token(attribute_name, token_value)
        attributes.append(attr_token)
        attribute_name = None
        expect_value = None
```
Also in the end of `while` loop, it needs to check if there is one more token left so that it's not missed:
```
if attribute_name:
    token_value = token.value if expect_value else None
    attr_token = self._generate_attribute_token(attribute_name, token_value)
    attributes.append(attr_token)

```


Possibly an error like "Overload signatures cannot be declared with 'function *'; use 'function' instead." would be helpful


It should. @sksamuel any idea?


эти методы правильно, что не константные?


good for me. better off

- using `16 * CEPH_PAGE_SIZE` instead of a magic number which might be obvious to some developers, but might not.
- and accompanying it with some comments explaining why we are using 64K here.
- passing `SPLICE_F_NONBLOCK` as the flags for `safe_splice()`, and handle `EAGAIN` just in case some user changes the pipe size to a smaller number. although not likely, but just in case.


They look like the correct fixtures from page 32/33 of the spec. Do these tests actually pass?

We actually patch over `c256` with `k256` [elsewhere](https://github.com/ripple/ripple-lib/blob/10e11d0b41a9f417b1864f4e367ee5dbe36b8101/src/js/sjcl-custom/sjcl-secp256k1.js#L71-76)
```
// DEPRECATED:
// previously the c256 curve was overridden with the secp256k1 curve
// since then, sjcl has been updated to support k256
// this override exist to keep supporting the old c256 with k256 behavior
// this will be removed in future release
sjcl.ecc.curves.c256 = sjcl.ecc.curves.k256;
```


its not required to use array dependency declaration syntax, just write :
``` JavaScript
/**
* @ngInject
* */
module.exports = function ($scope) {
    // todo your stuf here
}
```
we use [browserify-ngannotate] (https://github.com/omsmith/browserify-ngannotate) transform in browserify bundler, which declare dependencies for us.
https://github.com/olov/ng-annotate

P.S. code after transform will look like this:
``` JavaScript
/**
* @ngInject
* */
module.exports = function ($scope) {
    // todo your stuf here
}
module.exports.$inject = ["$scope"];
```


I think you need to append this with:
DEFAULT ''


Don't modify tables or entries. Instead, change them above at their source.


Rename this to `genericGlobalType`


You should use the version `1.0.1`


two spaces before `#` is the usual convention, I'll correct that while pushing


ack


why we are py unit type ?


En teoría se la bajan compilada. Se puede hacer un entremedio: la normal viene con las flags esas, pero en el .pro incluyes (si existe) el commons justo despues de las flags. Así el user se  puede bajar el source y añadir o quitar flags, o usar la version del paquete


might want to `lseek(fd, 0, SEEK_SET)` before calling `splice()`. there is chance that a kernel without hole support is able to handle `splice()`. splice was introduced in 2.6.17 but SEEK_DATA was not supported until linux 3.1.


I'll modify commit message on the fly, this commit is about closing unclosed objects, windows compatability is just one subjective reason to do it thus doesnt describe the change very well


It never happened to me... is this with the fixtures data?


commit message... ack with modificcations


It seems the way to use this parser now is users have to specify the rules in order to parse statements of specific dialect. The more desired approach will be hiding these rules inside the parser and users only need to specify specific dialect to the parser if they'd like to. This also makes more sense because users shouldn't have to worry about which rules/filters/groupings they need to use in order to parse specific sql dialect statements.


I think there's a difference between the data format that the original scraper generates to the one that we use as an export from data.obudget.org.

We should probably support both of these formats - i.e. if '-' in datestr then ... elif '/' in datestr then ...


den här meningen känns konstig, borde kanske vara "har utgått" eller "utgår" istället för "slutas säljas"


samma kommentar här som ovan


Yes


this was reverted as we need to support constraints rather than calculating frames and overriding ```layoutsubviews```


I just fixed that. For mysql and h2-memory every test will have a clean db now!


"allesammans" är en benämning för personer. Borde skrivas om till kanske "allting", "alltihop" eller "alla delar"


granskad


Can we add a jscs rule to enforce this?


qwe


`requireSpacesInAnonymousFunctionExpression`


Its true, again. Test it ;)
Also flyway is just setup for mysql.

Thing when adding the h2 console view Sebastian added a property to the connection which changed the behaviour and keeping the database alive across connections.
I removed that for h2 memory but kept it for h2 file.


reack


@francoispluchino
Ah. Thanks for noticing me.
I am a newbie and I found the a comment from you mentioned the dev version yesterday and I tried.
I will try version 1.0.1
And Sorry. I am not good at English:(


1: M111 unrecognized component name: oauthclient


23:1: I101 Imported names are in the wrong order. Should be session, url_for
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
30:1: I201 Missing newline before sections or imports.
35:9: E731 do not assign a lambda expression, use a def
252:5: E303 too many blank lines (2)


why is this changed?


[*] FO: PSCSX-5495 Fixes input label and input title


What about the css used in index.html? Should it have the same comments?


"lägga" -> "lägga till"?


Hi @vlimant is there a difference in the submitted taskChain if self.prepid is set as request.prepid or chain_request.prepid? Because if its a request prepid - it can create dead-locks in the system.
Also, it would be nice  if you could explain to me and @franzoni why this "2 ways to inject chain" was implemented.


No problem. It's always better to use a stable version, and use a dev version, only if there is no choice.


actually we have `com.gooddata.report.ReportExportFormat` already


Should "A" and "U" be lowercase?


I don't like this change because it opens a whole bunch of new security issues.  (I know that having rsync in the list renders all other restrictions moot, but the plan is to get rid of rsync there soon)


"När man först kommer in" står redan i förra meningen, blir upprepning. kanske bättre att skriva bara "först laddas..." eller "till en början..."


Line 22
// Include Gulp & tools we'll use
"Gulp" should be "gulp"?
https://github.com/gulpjs/gulp/blob/master/docs/FAQ.md#is-it-gulp-or-gulp


Well, it is the 'apply' button so the name *login* is pretty random. I'll have a look at re-use $name though


Can you provide some input on why the the number here changed?


use armeabi_v7a instead of armeabi-v7a, see comments above.


Thanks @purcell
By the way, I have a question.
Is "*.el" the default value for files?


Hi. Is there a way to override this max-width style? In our reports its not possible to see the detail of what happenened anymore as the screenshots are too small now. Or should I just wait for the Lighbox feature to get releases?


Existing label key which was anyway used has been reused. Label keys are not displayed at the user interface, but label values.
Term "Imprint" is used for other mpdl sites for english translation of "Impressum".


No.


gjhghjg


Александра, пожалуйста, уточни, что под мелочами ты имеешь ввиду ?


# memo
* ApacheのconfファイルでAllowOverride All を設定。
* htaccess の権限は604にする。所有者はapache起動ユーザでなくてもよい。


0.2.1 is now available on rubygems.


done, check hangouts.
deveshnegi.3105.dn@gmail.com


set global persistent is obsolete, its always persistent, pls remove


a


:star: thanks buddy


hm somehow useless to restart here because settings will remain anyways through node settings. after above reset you already validate that value is back to node settings


It's just a warning, so I think (until we've had extensive testing on 32bit) leaving it is warranted.


If you can't accept negative comments, why did you ask on forum?


@christinatruong If you can think of a GIF or fun image on the theme of computers doing our bidding or 'going bigger' I'm totally up for it. I'm just blanking at the moment.


iface ConcurrentMap would be enough... but minor thing ;)


You can leave out the "struct" keyword in front of the type name.


Hm... This will rise silent exception without explanation what went wrong...


And what errors you meant?


The patch contains several instances of this pattern.


If you're behind a firewall, how long do you fire SYN packets into the abyss before you determine that it is indeed not available?


super duper - it was annoying


I assume this was a mistake?


at start:

Warning: runtime assertion ( src/userlist.cpp:63 ): UserList::GetUser("[AG]abma"): no such user
Warning: 09:57:10: Warning: runtime assertion ( src/userlist.cpp:63 ): UserList::GetUser("[AG]abma"): no such user
Warning: runtime assertion ( src/userlist.cpp:63 ): UserList::GetUser("[AG]abma"): no such user
Warning: 09:57:10: Warning: runtime assertion ( src/userlist.cpp:63 ): UserList::GetUser("[AG]abma"): no such user

this is due the context menu is created at start. it should be created only when needed.


href navigates to http://localhost:9000/keystone/www.lennyboyatzis.com as opposed to www.lennyboyatzis.com


Merging from dev to stage


as workarround it could be checked first if user exists and then call GetUser


вместо container выстави null и верни все как на уроке


Ideally, i'd like to iterate through all the image url's and provide links for them


If additions may be well understood, are numerous case conditions (such as see below) yet to be developed, or in each of these cases execution must "break" indeed?  Maybe more reasonable condition can be provided?

+			break;
+		case latitude:
+			break;
+		case license:
+			break;
+		case longitude:
+			break;
+		case md:
+			break;
+		case mds:
+			break;
+		case number:
+			break;
+		case person:
+			break;
+		case person_family:
+			break;
+		case person_given:
+			break;
+		case person_id:
+			break;
+		case person_name:
+			break;
+		case person_org:
+			break;
+		case person_org_city:
+			break;
+		case person_org_country:
+			break;
+		case person_org_description:
+			break;
+		case person_org_id:
+			break;
+		case person_org_title:
+			break;
+		case person_role:
+			break;"


yeah, that's a good way also.


are removed or will be removed? :)


quel navigateur??? depuis le NAS? pour info mon NAS passe par un VPN, il n'utilise pas les mêmes routes que les PCs de mon LAN.

Je comprends pas ou tu veux m'amener là. Mon NAS atteint bien t411. Si j'ajoute manuellement des torrent ça marche impeccable. Et je suis bien connecté au tracker, je seed toute la journée, bref le lien est bon :)


There's a big comment right above explaining why it's marked deprecated. I'm not sure what the question is beyond that?


# memo
* ApacheのconfファイルでAllowOverride All を設定。
* htaccess の権限は604にする。所有者はapache起動ユーザでなくてもよい。


I like to have atomic commits. Please remove `config:` from here and add it to the `--config` commit.

Git tip: you can use `git rebase -i` and `git commit --amend`


Actually I was staring at this part and wondered if something like it would be possible, after the merge though. But I came to the wrong conclusion .

In other words: thanks for catching this !


Should have used `condp`!


We don't need this change because we `exit` anyway


should be property="${env.ANDROID_HOME}"?


Should we make the log silent? In my terminal
```sh
[17:52:45] Finished 'images' after 2.06 s
[17:52:45] Starting 'generate-service-worker'...
Caching static resource 'dist/fonts/RobotoCondensed-Bold.woff' (20.96 kB)
Caching static resource 'dist/fonts/RobotoCondensed-BoldItalic.woff' (17.14 kB)
Caching static resource 'dist/fonts/RobotoCondensed-Italic.woff' (17.08 kB)
Caching static resource 'dist/fonts/RobotoCondensed-Light.woff' (20.79 kB)
Caching static resource 'dist/fonts/RobotoCondensed-LightItalic.woff' (17.14 kB)
Caching static resource 'dist/fonts/RobotoCondensed-Regular.woff' (20.87 kB)
Caching static resource 'dist/images/hamburger.svg' (114 B)
Caching static resource 'dist/images/icons/icons-hinted.ttf' (0 B)
Caching static resource 'dist/images/icons/icons.eot' (3.53 kB)
Caching static resource 'dist/images/icons/icons.svg' (41 B)
Caching static resource 'dist/images/icons/icons.ttf' (3.36 kB)
Caching static resource 'dist/images/icons/icons.woff' (2.29 kB)
Caching static resource 'dist/images/icons/icons.woff2' (1.57 kB)
Caching static resource 'dist/images/icons/placeholder--medium.png' (122 B)
Caching static resource 'dist/images/icons/placeholder--small.png' (102 B)
Caching static resource 'dist/images/icons/placeholder--wide.png' (140 B)
Caching static resource 'dist/images/touch/apple-touch-icon.png' (2.41 kB)
Caching static resource 'dist/images/touch/chrome-touch-icon-192x192.png' (1.67 kB)
Caching static resource 'dist/images/touch/icon-128x128.png' (2.11 kB)
Caching static resource 'dist/images/touch/ms-touch-icon-144x144-precomposed.png' (1.09 kB)
Caching static resource 'dist/scripts/main.min.js' (1.78 kB)
Caching static resource 'dist/styles/components/components.css' (171.86 kB)
Caching static resource 'dist/styles/main.css' (209.47 kB)
Caching static resource 'dist/basic.html' (1.17 kB)
Caching static resource 'dist/index.html' (2.19 kB)
Caching static resource 'dist/manifest.json' (520 B)
Caching static resource 'dist/styleguide.html' (39.72 kB)
Caching dynamic URL './' with dependencies on ["dist/index.html"]
Total precache size is about 561.44 kB for 28 resources.
[17:52:45] Finished 'generate-service-worker' after 26 ms
[17:52:45] Finished 'default' after 6.75 s
```
it looks very noisy.


Remove `NO_TERM_OPTS` from here


We don't need this two lines. With `umask` at the beginning it will give `rw` for the user only.


This won't work with a filename with .py extension and/or not in default Python sys.path list, leading to a "Import by filename is not supported." error.

A possible workaround:
```c
PyObject* sysPath = PySys_GetObject((char*)"path");
PyList_Append(sysPath, PyString_FromString(dirname(file));
// remove .py extension from file, if any
char* dot = strrchr(file, '.');
if (dot && strcmp(dot, ".py") == 0)
    *dot = 0;
pModule = PyImport_Import(PyString_FromString(file));
if (pModule == NULL) {
  PyErr_Print();
  return;
}
```


@Grincheux41 laisse tomber, tu comprends pas... T411 depuis ton nas ou autre c'est le même site tu peux essayer depuis ton ordi


This one no longer applies with the new cmake_parse_arguments changes.


[이 링크](http://www.newmediacampaigns.com/blog/browser-rest-http-accept-headers)를 보고 고민을 좀 한 결과 이게 더 맞을 것 같아서 바꿨습니다.
* 바꾸려던 이유
  * 우선 request의 헤더에서, Accept는 response로 받을 type을, Content-type은 request 자신의 body type을 알려주는 것이므로 의미상 Accept가 더 적합해 보입니다.
  * ajax에서 get요청은 content-type이 json이 아닙니다. body가 아무것도 없고 content-type은 plain text입니다. 지금처럼 컨트롤러 전체가 content-type=json이고 메서드에서 각각 요청방식(get/post)을 나눈다면, get요청은 이 컨트롤러에 잡히지 않습니다.
* 문제
  * 하지만 accept 에 */*가 있어서 controller를 나눠서 붙여줄지 고민이었는데요. http spec에 따르면 네트워크 통신을 최대한 줄이는 게 핵심 목표 중 하나이므로, 헤더 중 accept에는 마지막에 */*를 붙는 게 합당해보입니다.
  * 대신 브라우저에서는 q-value를 이용해서 html,xml 등을 더 선호한다고 알려줍니다. (chrome for example : "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8")
  * 우리가 사용하는 angular에서는 "application/json, text/plain, */*"로 q-value를 지정하지 않았긴 하지만ㅜㅠ.. 그래도 json 을 accept함은 얘기하고 있네요.
* 결론
  * 그래서 브라우저가 보낸 요청을 낚아채려는, 즉 jsp를 보내 줄 divController에게는 accept=html을, 나머지 ajax 요청을 받으려는, 즉 json 형식을 응답해줄 나머지 컨트롤러에는 accept=json을 할당해주었습니다.


Maybe it is better to return nullptr if user does not exists?


Hello,

I have been learning this excellent paper and want to use it in my research. However, I meet a problem that the ConvolutionSKLayer<Dtype>::Backward_cpu/cu are not implemented yet in the published version. Would you kindly tell me how I can use this convolution_sk layer? or there is another newer version of project?

Thanks


Hm, I guess I'll better review on the overall diff instead of each individual commit. I'll try to have a look later.


Actually, some devices has build 3rd party extractor in MediaExtractor (e.q wmv, rm).

ExoPlayer does not support these.


You can use `WIFI_IFACE`, `INTERNET_IFACE`, `SSID` and `PASSPHRASE` instead of this.


Move this message and the above to another commit


It looks like these two methods could be static


I don't understand why this changes the way the default is selected in the combobox. I find the previous code for it more elegant.


Yeah, it was 5 in the last merged commit, but I have some extra junk in my local database so I mistakenly changed it back to 15.


Thanks! I definitely need to move this to being generated rather than hand-rolled RSN…


I still don't understand the question. The comment says you can keep using it, but that it's marked deprecated because there are known issues with it. What is the question?


go concurrency is so nice.


Likewise for this one, the common templates is already used in two cases, just not in this one - I'm pushing fixes for the other comments in a sec.


`--help` and `--version` are called in the switch because they just print. This is not the case of `--list`, actually `list_running` is using `mutex_lock`, so if we call it from here we will have race-conditions. Please revert this two lines.


single quotes?


Yes


Hi @ChanJoe11 , I am also trying this code. Would you mind telling me your process? did you successfully run it and how? Thanks a lot for your help.


Its better to encapsulate the redirect to #user path into your submit handler


1: M111 unrecognized component name: docker


1: M111 unrecognized component name: oauthclient


23:1: I101 Imported names are in the wrong order. Should be session, url_for
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
30:1: I201 Missing newline before sections or imports.
35:9: E731 do not assign a lambda expression, use a def
252:5: E303 too many blank lines (2)


Why not ``str or NoneType`` as that's what we expect?


right?! the task of 'make all these things happen concurrently' is trivial


I notice some have two new lines after a task but some have one. Should we make them consistent? a jscs rule can help.


It looks like this newline gets eaten so the generated `latexiraj.bat` is missing a newline, so we get:

     cd nalogepdflatex FrancHorvat.tex
     pdflatex MihaNovak.tex


Looks good to me.


Two things here:
* the file is not closed anywhere (can be addressed by using ``with open() as f:``
* the ``readlines()`` call is not needed (the file object is an iterable producing lines)


That's just horrible! I much prefer a single "Exporting ZFS pool …" with progress entry for each pool being exported.


semicolon?


how about add comment in this block and remove the one in line 82?


我测了一下，下面这几行依赖得加到 cron 之前（或者把 cron 里面的 require 去掉，不过应该加上依赖比较好）：

    package { 'crontabs':
      ensure => latest,
    }

    service { 'crond':
      ensure => running,
      enable => true,
    }


A comment with an example line would make the split and comparisons way clearer (I know the original version of this code didn't have it either).


Can we have a default version and description, something like

    #ifndef TA_VERSION
    #define TA_VERSION "Undefined version"
    #endif

In that case, the update on the test is minimized.


我在CustomDictionary.java的147行加入了 对自定义词典 #号注释的排除:                if (param[0].length() == 0 || param[0].trim().charAt(0) == '#') continue;   // 排除空行 和 #注释

请博主考虑是否采纳哈


This was intended for people NOT running a root pool and wanted to do "something" (upgrade or whatever) and wanted to make sure that everything was unshared, unmounted, exported and unloaded…. It wasn't JUST intended to be run at system shutdown/reboot...


Benutzt am besten alle einfach eine grafische Oberfläche, sodass ihr euch mit solchen Dingen nicht auseinandersetzen müsst.


that would be a huge code change & also it would require to add a lot of checks if return value != NULL


@readevalprint - could you add any setup info required for RapidPro?


Please do this change in the `--mkconfig` commit


For the description, be careful that it is an **Optional** description of the Trusted Application.


please use "if let" to unwrap optional. what is there is no viewController found (unexpected, but still...)


Oh, got it, thanks!


I don't understand why you put this one


thanks a lot for the comments.
these are partially solved in a7a29ca9bd352f621d3ce140b8770aba4f88737f


Yes, "FrameworkSampleSource" is keep, but "DefaultRendererBuilder" is gone.

It would be better to keep "DefaultRendererBuilder" to let developer known how to integrate MediaExtractor in there code.


thanks for update . i was stuck with updating note to display on customer.
thanks


Move this and the above message in a different commit. Put them in the same commit that you will put the other two messages you have in the `--mkconfig` commit.


Everything is fine. Our CI system was just having a hiccup.


Setting `display_name` to `None` should be handled. Right now, two cms unit tests are failing because this case (name being None) is not covered in the `mock_search_engine` in `edx-search`.


Looks like a hack... Is there a config in `useref` so that it does not to touch JavaScript operations but only replace the path?


OK, thanks.
The previous build worked though.


I'm not sure that not having an editor should be an option. If the public body is changed, I think we probably want a good audit trail.


thank you, did not read that part carefully


Actually, I've extended zfs_installed() to check if the command is executable:

```
zfs_installed()
{
        local RET

        if [ ! -x $ZPOOL ]; then
            return 1
        else
            # Test if it works (will catch missing/broken libs etc)
            "$ZPOOL" -? > /dev/null 2>&1
            return $?
        fi

        if [ ! -x $ZFS ]; then
            return 2
        else
            # Test if it works (will catch missing/broken libs etc)
            "$ZFS" -? > /dev/null 2>&1
            return $?
        fi

        return 0
}
```

That way we can catch problems in the installation. And if we don't log this clearly, user won't know why it didn't import anything…

And I'm only doing this ONCE now - in zfs-import (where it matters and which the other depend on the success of).


Instead of running `adb logcat` manually you may want to use ready-to-use `<project>/platfroms/android/cordova/log` script. It uses `adb logcat` internally and also does some stuff like filtering unwanted lines, etc... See https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/log

Also `log`/`log.bat` is available for all main platforms, so probably there is no need for platform specific logic above. Only exception here is ios, where `log` is a shell script.


Next release will be in a couple of weeks - you can't change the CSS / HTML as they are templates inside the hpi - you could change it after it gets generated obviously but you'd have to do that yourself with some kind of script

Sent from my iPhone

> On 6 May 2015, at 08:47, Greg <notifications@github.com> wrote:
>
> Hi. Is there a way to override this max-width style? In our reports its not possible to see the detail of what happenened anymore as the screenshots are too small now. Or should I just wait for the Lighbox feature to get releases?
>
> —
> Reply to this email directly or view it on GitHub.
>


Alex, are you around today? Would like to chat to you on IRC?


Why are you storing a pointer to this struct? The value itself if only 8 machine words long. I don't think this is worth an allocation without a benchmark to show benefit.


I see, But then how do we remove it? I guess I should save that function in a var. I'll give it a go.


Should be with capital "J"


> new Collection(new Model) should give a collection that contains one Model.

No `new Collection ([new Model])` should, how it behaves currently makes sense to me


Just a nitpick, perhaps `arch_mem_reserved()` would be a better name?


I feel more strongly about this one - I don't think it should be optional, it opens up the possibility of the calling code omitting to do the reindexing itself without any corresponding benefit at the moment (we don't have use cases). If we keep it as an option, I think it would be preferable for the default to be true, so that the calling code has to explicitly ask for indexing to be skipped if that's what's desired.


Middle statement could just be `public_body` ?


执行空的block会崩溃


Just had a minor code style question? (see above)
Other than that it looks good.


I don't know. But as you said, by splitting the import and the mount into two, where the import is/can be run VERY early, this shouldn't be needed. Mind if I keep the code, but comment out the whole block (so it doesn't get lost in the rebase) and we can test it out (and I'll try to dig up the issues - there where one or two at least - and I'll see if I can convince the issuer to test these new scripts - with this commented out)?


В методе [`run()`](https://github.com/LeKaitoW/rdo-xtext/commit/9f883956ebf96235e87d635ac74e782ded7573fc#diff-2388d026ceaf9cc80d3bc71c53944bafR242) таймертаска в проверку включен метод `readyForInput()`.
Этот метод касается только окошка с деревом, из которого строятся графики и он вернет `false`, если окошко закрыть. Однако графики все равно должны продолжить обновляться.

Поэтому проверку `readyForInput()` из `run()` таймертаска надо просто убрать, а в `run()` апдейтера обновлять графики нужно независимо от нее.


j'adore quand on me parle comme à un débile. Je comprends pas ou tu veux en venir! T'as qu'à m'expliquer! Evidemment que j'accède à t411 depuis mon PC!!! depuis le début je te dis que j'arrive à ajouter des torrents manuellement à dowloadstation!


add a space after mDownloadManager


thanks: https://www.changetip.com/tipsters/bydorian


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


1: M111 unrecognized component name: legacy


Hi bạn, mình vừa commit 1 bản database + 1 bản backend.php
Trong quá trình làm dựa vào database, bạn ko rõ chỗ nào thì mail mình biết
nha, file backend chứa những hàm cần thiết cho các bạn trong quá trình gọi
user, rao sản phẩm...

2015-05-06 13:30 GMT+07:00 51104446 <notifications@github.com>:

> Database có chưa vậy nhóm Back-end.......
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/51103061/2015_De09/commit/e30c538ab894608d50762fca1264c7d12976913f#commitcomment-11059661>
> .
>

--
Đào Ngọc Duy Tân
Student at Computer Science and Engineering, University of Technology
Phone number: 0933455662


23:1: I101 Imported names are in the wrong order. Should be session, url_for
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
30:1: I201 Missing newline before sections or imports.
35:9: E731 do not assign a lambda expression, use a def
252:5: E303 too many blank lines (2)


1: D100 Missing docstring in public module
28:1: I100 Imports statements are in the wrong order. import re should be before import time
29:1: I100 Imports statements are in the wrong order. import datetime should be before import re
31:1: I100 Imports statements are in the wrong order. import getopt should be before import marshal
35:1: I100 Imports statements are in the wrong order. import signal should be before from subprocess
37:1: I101 Imported names are in the wrong order. Should be CFG_BIBTASK_FIXEDTIMETASKS, CFG_BIBTASK_MONOTASKS, CFG_BIBTASK_VALID_TASKS
41:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_GC_TASKS_OLDER_THAN, CFG_BIBSCHED_GC_TASKS_TO_ARCHIVE, CFG_BIBSCHED_GC_TASKS_TO_REMOVE, CFG_BIBSCHED_INCOMPATIBLE_TASKS, CFG_BIBSCHED_MAX_NUMBER_CONCURRENT_TASKS, CFG_BIBSCHED_NEVER_STOPS, CFG_BIBSCHED_NODE_TASKS, CFG_BIBSCHED_NON_CONCURRENT_TASKS, CFG_BIBSCHED_REFRESHTIME, CFG_BINDIR, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_PREFIX, CFG_RUNDIR, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_VERSION
41:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibsched.bibtask_config
41:1: F401 'CFG_INSPIRE_SITE' imported but unused
59:1: I101 Imported names are in the wrong order. Should be real_escape_string, run_sql
60:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.dbquery
76: D400 First line should end with a period (not 'h')
76: D205 1 blank line required between summary line and description (found 0)
97: D400 First line should end with a period (not 'm')
97: D205 1 blank line required between summary line and description (found 0)
132: D200 One-line docstring should fit on one line with quotes (found 3)
138:9: F821 undefined name 'cfg'
147: D200 One-line docstring should fit on one line with quotes (found 3)
153:9: F821 undefined name 'CFG_BIBSCHED_EDITOR'
164: D101 Missing docstring in public class
168: D401 First line should be in imperative mood ('Return', not 'Returns')
168: D209 Multi-line docstring closing quotes should be on a separate line
168: D205 1 blank line required between summary line and description (found 0)
168: D208 Docstring is over-indented
190: D103 Missing docstring in public function
203: D400 First line should end with a period (not 'd')
218:1: E302 expected 2 blank lines, found 1
222:1: E302 expected 2 blank lines, found 1
222: D400 First line should end with a period (not ')')
229: D401 First line should be in imperative mood ('Return', not 'Returns')
238: D401 First line should be in imperative mood ('Return', not 'Returns')
247:68: E261 at least two spaces before inline comment
267:45: E127 continuation line over-indented for visual indent
278:45: E127 continuation line over-indented for visual indent
281: D400 First line should end with a period (not 't')
281: D205 1 blank line required between summary line and description (found 0)
297: D400 First line should end with a period (not 'k')
335:1: E302 expected 2 blank lines, found 1
339:1: E302 expected 2 blank lines, found 1
363: D103 Missing docstring in public function
367:1: E302 expected 2 blank lines, found 1
367: D103 Missing docstring in public function
372: D103 Missing docstring in public function
377: D103 Missing docstring in public function
388: D101 Missing docstring in public class
389: D102 Missing docstring in public method
399: D102 Missing docstring in public method
402: D102 Missing docstring in public method
405: D102 Missing docstring in public method
408: D102 Missing docstring in public method
414: D102 Missing docstring in public method
417: D102 Missing docstring in public method
421: D101 Missing docstring in public class
422: D102 Missing docstring in public method
427:9: E266 too many leading '#' for block comment
432:9: E266 too many leading '#' for block comment
440: D401 First line should be in imperative mood ('Set', not 'Sets')
440: D400 First line should end with a period (not 't')
440: D205 1 blank line required between summary line and description (found 0)
447:45: E127 continuation line over-indented for visual indent
450: D210 No whitespaces allowed surrounding docstring text
450: D401 First line should be in imperative mood ('Remove', not 'Removes')
450: D202 No blank lines allowed after function docstring (found 1)
450: D400 First line should end with a period (not 'e')
450: D200 One-line docstring should fit on one line with quotes (found 2)
466: D209 Multi-line docstring closing quotes should be on a separate line
466: D400 First line should end with a period (not 'n')
466: D205 1 blank line required between summary line and description (found 0)
481: D102 Missing docstring in public method
484:41: W503 line break before binary operator
484:41: E127 continuation line over-indented for visual indent
486:41: W503 line break before binary operator
486:41: E127 continuation line over-indented for visual indent
490: D400 First line should end with a period (not 't')
490: D205 1 blank line required between summary line and description (found 0)
497:13: E266 too many leading '#' for block comment
500:22: E126 continuation line over-indented for hanging indent
523:9: E303 too many blank lines (2)
533: D209 Multi-line docstring closing quotes should be on a separate line
533: D400 First line should end with a period (not 'd')
533: D205 1 blank line required between summary line and description (found 0)
547: D209 Multi-line docstring closing quotes should be on a separate line
547: D205 1 blank line required between summary line and description (found 0)
591:21: E266 too many leading '#' for block comment
592:21: E266 too many leading '#' for block comment
593:21: E266 too many leading '#' for block comment
594:21: E266 too many leading '#' for block comment
595:21: E266 too many leading '#' for block comment
600:17: E266 too many leading '#' for block comment
601:17: E266 too many leading '#' for block comment
616:21: E266 too many leading '#' for block comment
619:17: E266 too many leading '#' for block comment
620:17: E266 too many leading '#' for block comment
633:21: E266 too many leading '#' for block comment
641:25: E266 too many leading '#' for block comment
645:17: E266 too many leading '#' for block comment
649:13: E266 too many leading '#' for block comment
655:13: E266 too many leading '#' for block comment
656:13: E266 too many leading '#' for block comment
662:17: E266 too many leading '#' for block comment
663:17: E266 too many leading '#' for block comment
695:21: E266 too many leading '#' for block comment
697:25: E266 too many leading '#' for block comment
698:25: E266 too many leading '#' for block comment
712:21: E266 too many leading '#' for block comment
715:21: E266 too many leading '#' for block comment
718:25: E266 too many leading '#' for block comment
724:29: E266 too many leading '#' for block comment
725:29: E266 too many leading '#' for block comment
736:17: E266 too many leading '#' for block comment
737:17: E266 too many leading '#' for block comment
738:17: E266 too many leading '#' for block comment
757: D102 Missing docstring in public method
817:9: E266 too many leading '#' for block comment
835:13: E128 continuation line under-indented for visual indent
836:57: E126 continuation line over-indented for hanging indent
837:9: E266 too many leading '#' for block comment
847: D400 First line should end with a period (not 'e')
873: D102 Missing docstring in public method
881:34: E127 continuation line over-indented for visual indent
884: D102 Missing docstring in public method
893: D102 Missing docstring in public method
906:58: E127 continuation line over-indented for visual indent
920:21: E266 too many leading '#' for block comment
921:21: E266 too many leading '#' for block comment
923:25: E266 too many leading '#' for block comment
926:21: E266 too many leading '#' for block comment
931: D102 Missing docstring in public method
932:9: E266 too many leading '#' for block comment
933:9: E266 too many leading '#' for block comment
948:29: E266 too many leading '#' for block comment
949:29: E266 too many leading '#' for block comment
951:33: E266 too many leading '#' for block comment
954:29: E266 too many leading '#' for block comment
968: D103 Missing docstring in public function
978: D401 First line should be in imperative mood ('Thi', not 'This')
978: D300 Use """triple double quotes""" (found '-quotes)
987: D103 Missing docstring in public function
992: D401 First line should be in imperative mood ('Print', not 'Prints')
1035: D103 Missing docstring in public function
1040: D103 Missing docstring in public function
1044: D103 Missing docstring in public function
1062:12: E713 test for membership should be 'not in'
1069: D103 Missing docstring in public function
1073: D210 No whitespaces allowed surrounding docstring text
1073: D209 Multi-line docstring closing quotes should be on a separate line
1073: D202 No blank lines allowed after function docstring (found 1)
1073: D400 First line should end with a period (not 'g')
1073: D205 1 blank line required between summary line and description (found 0)
1127:49: E261 at least two spaces before inline comment
1127: D103 Missing docstring in public function
1148:48: E261 at least two spaces before inline comment
1148: D209 Multi-line docstring closing quotes should be on a separate line
1148: D205 1 blank line required between summary line and description (found 0)
1156:17: E128 continuation line under-indented for visual indent
1166:76: E261 at least two spaces before inline comment
1166: D202 No blank lines allowed after function docstring (found 1)
1166: D200 One-line docstring should fit on one line with quotes (found 3)
1171: D200 One-line docstring should fit on one line with quotes (found 3)
1193:29: E126 continuation line over-indented for hanging indent
1194:42: E203 whitespace before ':'
1195:21: E128 continuation line under-indented for visual indent
1226: D103 Missing docstring in public function
1231: D400 First line should end with a period (not 'd')
1231: D205 1 blank line required between summary line and description (found 0)
1275: D103 Missing docstring in public function
1326:22: E203 whitespace before ':'
1327:15: E127 continuation line over-indented for visual indent
1327:22: E203 whitespace before ':'
1330:13: E128 continuation line under-indented for visual indent
1331:13: E128 continuation line under-indented for visual indent
1332:13: E128 continuation line under-indented for visual indent
1333:13: E128 continuation line under-indented for visual indent


1: D400 First line should end with a period (not 't')
24:1: I100 Imports statements are in the wrong order. import marshal should be before import time
26:1: I100 Imports statements are in the wrong order. from datetime should be before from socket
28:1: I100 Imports statements are in the wrong order. import signal should be before from itertools
31:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_LOGDIR, CFG_BIBTASK_VALID_TASKS
31:1: F401 'CFG_BIBSCHED_LOGDIR' imported but unused
34:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_EDITOR, CFG_BIBSCHED_GC_TASKS_OLDER_THAN, CFG_BIBSCHED_GC_TASKS_TO_ARCHIVE, CFG_BIBSCHED_GC_TASKS_TO_REMOVE, CFG_BIBSCHED_LOG_PAGER, CFG_BIBSCHED_MAX_ARCHIVED_ROWS_DISPLAY, CFG_BIBSCHED_NODE_TASKS, CFG_BIBSCHED_REFRESHTIME, CFG_BINDIR, CFG_LOGDIR, CFG_TMPSHAREDDIR
34:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibsched.bibtask_config
35:6: E126 continuation line over-indented for hanging indent
48:1: I101 Imported names are in the wrong order. Should be Log, bibsched_get_status, bibsched_send_signal, bibsched_set_host, bibsched_set_name, bibsched_set_priority, bibsched_set_progress, bibsched_set_runtime, bibsched_set_sleeptime, bibsched_set_status, fetch_debug_mode, gc_tasks, get_task_pid, redirect_stdout_and_stderr, restore_stdout_and_stderr, server_pid, spawn_task
48:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.cli should be before from invenio.utils.text
49:30: E126 continuation line over-indented for hanging indent
65:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.legacy.bibsched.cli
66:30: E128 continuation line under-indented for visual indent
67:30: E128 continuation line under-indented for visual indent
73: D103 Missing docstring in public function
77: D103 Missing docstring in public function
84: D200 One-line docstring should fit on one line with quotes (found 3)
99: D200 One-line docstring should fit on one line with quotes (found 3)
116: D101 Missing docstring in public class
117: D102 Missing docstring in public method
121: D102 Missing docstring in public method
125: D103 Missing docstring in public function
139: D101 Missing docstring in public class
140: D102 Missing docstring in public method
183: D102 Missing docstring in public method
187:44: E128 continuation line under-indented for visual indent
188:44: E128 continuation line under-indented for visual indent
189:44: E128 continuation line under-indented for visual indent
190:44: E128 continuation line under-indented for visual indent
191:44: E128 continuation line under-indented for visual indent
192:44: E128 continuation line under-indented for visual indent
193:44: E128 continuation line under-indented for visual indent
194:44: E128 continuation line under-indented for visual indent
195:44: E128 continuation line under-indented for visual indent
196:44: E128 continuation line under-indented for visual indent
197:44: E128 continuation line under-indented for visual indent
211:41: E128 continuation line under-indented for visual indent
215:41: E128 continuation line under-indented for visual indent
313: D102 Missing docstring in public method
346: D102 Missing docstring in public method
361: D102 Missing docstring in public method
369: D102 Missing docstring in public method
373: D209 Multi-line docstring closing quotes should be on a separate line
373: D400 First line should end with a period (not 'e')
373: D205 1 blank line required between summary line and description (found 0)
476: D102 Missing docstring in public method
480: D102 Missing docstring in public method
501: D102 Missing docstring in public method
514: D102 Missing docstring in public method
518:54: E127 continuation line over-indented for visual indent
527: D102 Missing docstring in public method
535:57: E127 continuation line over-indented for visual indent
536:57: E127 continuation line over-indented for visual indent
549: D102 Missing docstring in public method
557:13: E116 unexpected indentation (comment)
758: D102 Missing docstring in public method
776:21: E266 too many leading '#' for block comment
783: D102 Missing docstring in public method
796: D102 Missing docstring in public method
801: D102 Missing docstring in public method
812: D102 Missing docstring in public method
826: D102 Missing docstring in public method
851: D102 Missing docstring in public method
865: D102 Missing docstring in public method
878: D102 Missing docstring in public method
891: D102 Missing docstring in public method
897: D102 Missing docstring in public method
927: D102 Missing docstring in public method
942:5: E303 too many blank lines (3)
942: D102 Missing docstring in public method
943:9: E266 too many leading '#' for block comment
944:9: E266 too many leading '#' for block comment
945:19: E203 whitespace before ','
971:9: E266 too many leading '#' for block comment
972:9: E266 too many leading '#' for block comment
973:9: E266 too many leading '#' for block comment
975:15: E128 continuation line under-indented for visual indent
986:13: E266 too many leading '#' for block comment
998:14: E114 indentation is not a multiple of four (comment)
998:14: E266 too many leading '#' for block comment
999:14: E114 indentation is not a multiple of four (comment)
999:14: E266 too many leading '#' for block comment
1016: D102 Missing docstring in public method
1030: D102 Missing docstring in public method
1039: D102 Missing docstring in public method
1084: D102 Missing docstring in public method
1138: D102 Missing docstring in public method
1194:40: E261 at least two spaces before inline comment
1194: D103 Missing docstring in public function


I'd like too look into this crash a little bit further - Can you try and find the exact record that causes the failure? I'd like to compare it to the original record, and spot the difference that's causing the crash.


Because it is passed as a query parameter, so doesn't need to be escaped.


trim once


Hm, why is the name of this function provided by server?
I guess we could just call `get_Assign_To_Class_Popup()` with appropriate arguments (provided by this API).

I would say the same about some other properties provided here, e.g. `text`, `target`, `className`, `expandedText` or `options` (pulldown above). I feel it's all view concern. So, ideally I would only return URLs (or not, if user doesn't have appropriate role). Even that is probably unnecessary, as we could expose URLs somehow and then check roles client side (I'm assuming that actions that are pointed by this URLs also check roles themselves, as otherwise it's a but anyway). However, returning ready URL and checking role server-side is more convenient probably.

Sorry if I'm missing something, I haven't taken a closer look at the react component itself.


https://github.com/springlobby/springlobby/commit/4799f819d5992fa1d872f804e27ab3cb8210706f

very likely there are still some calls to GetUser which fails... i will add assert(false); in this function and try to test/fix remaining errors


combine lines 462 and 463 into one.


Thanks for spotting this issue! I've merged and cleaned up the fix (there has to be error handling for serving on thisAddr).


too bad this change of comments in package-info files is not done in a separate commit. It has nothing to do with the subject of the PR, isn't it? (that's easy to fix though)


Added a sorted() just to make sure people will not mess up in the future when inserting the numbers and destroy some thoughtful order someone has done in the stringtable.


This shouldn't be necessary. Using `center` sets the bounding box to false: https://github.com/CartoDB/cartodb.js/blob/develop/src/vis/image.js#L457


A la place de Datasource, utiliser DataSourceUtils.getConnection(), pour l'inclure dans le context spring


too bad this wildcard import has not be removed since you modified imports in this file


you're definitely right...
As we say usually, "sorry for the inconvenience"


Without these two lines, the dialog window doesn't get centered on the screen.
It looks like the initial position of the Dialog is calculated using these values (or some small default window size, if they're not given) and I couldn't find a way to manually adjust its position on the screen later. So using these values (as a guess) may not always be completely centered, but leaving them out, places the Dialog window a little bit too far on the right, and way too far on the bottom of the screen. (At least on Linux)


We don't want to encourage it's use due to the issues mentioned. You can still use it, but we're not going to actively encourage its use by using it in our own demo app.


Wont this http://review.cyanogenmod.org/#/c/96384/ be needed before.

PS I think auto B is a kernel bug.


good thing this useless `plugin != null` has been removed but shouldn't you have added a `@Nonnull` annotation`pluginRepository#getPlugin`


Actually, leave this in in the future even if we don't need to clear out the DOM. Without it, I can't see that scheduled messages for the day ever get reloaded (we must previously have been relying on the overnight reboot). That would explain why Jason A was seeing travel news alerts on Sunday evenings.


Yeah, that's silly.


I think the `override_bbox` part is not true. Using `bbox` should be enough. We should also point out somewhere that, by default, images are generated using the bounding box of the map. So just using `bbox` or not using it at all should generate the same image.


@Grincheux41  c'est ce que je dis tu comprends pas.  Un code 200 veux dire ok c'est bon mais tu sais pas ce qu'il y a au bout, le site t411 va systématiquement te faire une redirection et donc un code 200 si t'es pas identifié sur le site, ce qui arrivera systématiquement avec wget. Si tu n'arrive pas à faire la manip avec ton navigateur alors wget n'y arrivera pas non plus. J'arrête cette conversation pour ma part. A la limite si tu comprends rien prends un autre provider.


@jamalex yeah I think the mresponsibility of this management command is to do some "setup" but a check about file access should be in some installer / updater.


if you do update prima you will need this https://github.com/updateing/android_device_sony_blue-common/commit/f3e59d8645ae37849ede6f7d4f29c2a93d31edff


why not nowdoc?


I'm on PC Win7.

In case you want to try my sound effect: [download](https://drive.google.com/file/d/0B9q2p6mb-7ngMF9DUTc3MUtBOTA/view?usp=sharing)


I'm not sure if I can cherry-pick that without conflits :/ Will do it now.

Yes probably, but I have no idea where since device logs don't show anything about kernel.


Thank you


this we dont need


i kernel logs are visible with last kmsg which is not available in the kernel maybe this https://gerrit.omnirom.org/#/c/13579/ might fix that.

also check out dmesg.


@mcostalba, @lucasart
Please understand, I simply don't know how.  I am new to both C++ and SF's code.


Looks good John, and addresses my concern raised in #156.


sentence missing a "only" here, right?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.83](http://teamcity.monogame.net/viewLog.html?buildId=7015&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@lijiajia, Pls help to modify the web testing service pack script ,
rename index.wts.html to index.html before pack.


Looks good to me.


I can confirm that this resolves the issue that I had reported to you yesterday on IRC. Thaks José!


Fixed
![MRW someone says my jokes are too morbid](http://i.imgur.com/5K8rl09.gif)


Wheezy doesn't have the <code>-r</code> option. And that isn't even "ancient" (just old :).


show this to Singapore Prime Minister


I concur. Can we change the rules in rubucop so that they allow for the intended DSL?


I bet that SonarQube will raise an issue here ! all.isEmpty() is preferred.


`Splitter.on(",").trimResults().omitEmptyStrings()` could be static to save useless instantiation of threadsafe object each time `propertyValues` is called (which is multiple time each time the Predicate is used)


コメントを書いたらどうなるんだろう？


hello everyone,this is my first time to use github to manage my program.


这个类为什么要放在util包下？


I believe this is standard but it is worth mentioning that the browser should not call any user-overridden definition of a method or attribute. This section is included verbatim from https://dom.spec.whatwg.org/#conformance.


コメントを書いたらコメントが投稿されるのね。


Something went wrong here @jaynus


OK, so lets add them back. But I think they were slightly too large, resulting in a white border right and bottom of the dialog in the English version (due to its terseness compared to the German translation)


the kernel might need updating for prima. the latest caf kernel for msm8960 is LA.AF.1.1.1-13500-8064.0 check more out here https://www.codeaurora.org/xwiki/bin/QAEP/WebHome

source is at 5.0.1 so if this works we can use adreno and mpdecision from mako LRX22C and get rid of legacy mmap


Why? It would seem more consistent if this would remember the values the application set last. Otherwise e.g. disabling video and then switching to the next track would suddenly show videos again... without the application having a way to know that this actually happens.


duplication of `tab-pane` class. Fixed in f4dbabf


Maybe it'd be better to use a version for Internal_1 that is different from log4net's. I guess it shouldn't make a difference except for removing potential confusion from the reader of the code.


This as the standard string comparison but probably worth stating in the spec.


いろんなサービスは無料で記憶領域を提供してくれるけど、それに見合った利益はきちんとあるのかな？


Merged.


Maybe split this commit into separate commits. I would merged everything except for the cover art already then :)


This RuleFinder must definitely be removed soon. DefaultRuleFinder returns the first item and does not raise any exception...


Fixed in https://github.com/whatwg/mediasession/commit/95c2ea83565b30c8089a81dc65dd9530e46b713f.


Actually that test was not important. It required no application change. It was only the first thing I checked.


Denne kan fjernast, sidan det berre er logging og ingen funksjonalitet. :)


a coverity scan is started when a commit is made to the coverity_scan branch.

output is there: https://scan.coverity.com/projects/1060

sadly it seems a registration is required to view results :-|

number of scans is limited:
https://scan.coverity.com/faq#frequency

so we can't merge/push this often to the coverity_scan branch.


This should be static


Yeah, that would be better. A less good, but possible thing would be to mark stuff as to be ignored by Rubocop in comments.
--
Paul Wilson
Cultivate | cultivatehq.com
Skype: merecomplexities
Phone: +44 7855 841103

> On 6 May 2015, at 09:54, Alan Gardner <notifications@github.com> wrote:
>
> I concur. Can we change the rules in rubucop so that they allow for the intended DSL?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/moneyadviceservice/webfeeds/commit/d733590fc6cfd7625487c0f8c3c2684ac5124d20#commitcomment-11061581>.
>


Sound like a great idea so my :+1: :smiley_cat: However, I don't see us doing it in the near future - @MisinformedDNA could you perhaps work on turning it into a plugin? I'd be happy to reference your work as an extension of this repo!


Hiya. Right then. I have since got a message from Jeremy to put me right on where i was going wrong. I know I didnt need J as a value, I was just flummoxed on not being able to access the var I thought I was assigning.. I understand (nearly) from the result James gave us.. I want to review inline and umm the other way of calling a function with ya please.. 5 mins.


The audio/video/subtitle_tracks functions are almost the same. Can you unify them?


Where is this input stream closed?


Same here ...


not very happy with this test method name. What should happen (or not happen) when both inclusions and exclusions are used?


I agree your point. FrameworkDatasource is not a good example. We can't fix those issues caused by MediaExtractor.


c'est un dialogue de sourd, je dis et répète que t411 marche très bien avec mon navigateur... je suis connecté, je lance des recherches, je télécharge des fichier ".torrent" sur mon bureau, ensuite je les upload dans dowloadstation.... ça répond pas à ta question ça?


Hmm, isn't this information in the gst_sample_get_info() GstStructure?


GitHubは公開されるという制限さえ我慢すれば無料だし、Herokuはデータベースまで使わせてくれる。まあGitHubをビジネスで使うとなると、公開するわけにもいかないから有料にならざるを得ないし、Herokuもビジネスで使うとなるとお金を払うことになるんだろうな。個人に比べて会社というのはお金を豪快に使うからそれを利用して稼いでるんだろうな。


same thing here. What should happen or not in this test?


Ok. Will change that and update the PR


I think you may wanna change your gmail password. :+1:


Thanks for clarification something like this in the commit message would be nice.


Do you agree that we should document this _magic_ value?


same thing here.
I expect to understand what's expected from the class under test reading the test method names. Here I fail to do that and have to read the code of the test method to get the information


Tried it but i get this:

```
error [pimatic]: Error loading device woonkamer-plafond-dim: Property 'getBattery' of object #<HomeduinoRFDimmer> is not a function
11:02:19error [pimatic]: Error loading device woonkamer-wandkast: Property 'getBattery' of object #<HomeduinoRFDimmer> is not a function
11:02:17error [pimatic]: Error loading device mood-B: Property 'getBattery' of object #<MySensorsDimmer> is not a function
11:02:17error [pimatic]: Error loading device mood-G: Property 'getBattery' of object #<MySensorsDimmer> is not a function
11:02:16error [pimatic]: Error loading device mood-R: Property 'getBattery' of object #<MySensorsDimmer> is not a function
```


Yes, the defaults include `*.el`:

```el
(defconst package-build-default-files-spec
  '("*.el" "*.el.in" "dir"
    "*.info" "*.texi" "*.texinfo"
    "doc/dir" "doc/*.info" "doc/*.texi" "doc/*.texinfo"
    (:exclude ".dir-locals.el" "test.el" "tests.el" "*-test.el" "*-tests.el"))
  "Default value for :files attribute in recipes.")
```


Is it a bak or temporary file?


@mstembera
My plan next is to have a reset counter.  As the search characteristic can be dramatically different if a long series of quiet moves have been played.

I also want to make sure stats are clear when there is a promotion.

mbooster read my mind...I want to experiment of only clearing the history stats at each new search.  As this table populates extremely quickly compared to cmh.

Another idea is to decrease stats from prior search ( say by dividing by 2) before starting a new search.

I also think we should tune the Max Bonus limit.  History, CMH, and Gains will each have their own Max that we can tune.

Than I want to apply my Monkfish idea and re-tune the cmh/h weights in move picker.


cool so we can write now our tests like for a clean db, right?


OK. But I will continue to use ASSERT_EXCEPTION macro with wxLogError function because Windows does not show me console output of SL. A lot of warning messages are passing me by((


Now check `$limit >= 0` is lost. It may break some existing functionality.
For example in the migration we set limit = `-1` to disable limit.


giving error when i try to use
$client->orders->get( array( 'status' => 'completed' ) )


much more efficient implementation of the white/black lists


You're right, the dialog window won't be made smaller later (only bigger)... Hm, I think I used the values my system returned for mainRow.childrenRect, but they might be different on other systems of course. So using this remains somehow a dirty hack...


pourquoi as tu supprimé le code du facilities button ?


does running this from cmd.exe print sth. to console?

springlobby.exe -cl |more


still need confirmation on the gfx fix. :P I thought more about your argument of finishing small defenses faster, and I reworked the cost function quite a bit. Now it allows for 2 workers per small defense, and tends to build them before anything else. Mexes also get slightly higher priority (although less than small porc), and small energy slightly less, to ensure that workers cap mexes earlyish when expanding, as opposed to say building 2 solars first. Let me know what you think.


Pourquoi initialiser les arguments de la commande ?


No


你Y倒是给我留个联系方式啊。。。各种404页面，怎么找到你~~~回我邮件！ysfllxcn@live.com


This paragraph does not provide a testable assertion. Let's remove MUST or SHOULD here.


Et bien non tu ne lis pas correctement ce que je t'écris !!!!!!!!
Es-ce que tu y arrive avec ton navigateur en étant pas connecté ? (C'est a dire sans être authentifié) ou autrement dis sans avoir tappé ton login et mot de passe.
Je sais plus comment m'exprimer , c'est fou ces gens qui ne lisent pas


By the way, I noticed that assert operator does nothing. Maybe this has same origin with no output to console? Is there any flag in gcc enabling/disabling it?


Marking up media elements with a media category is up to web developers. There is nothing we can enforce with a 'must' here.


Désolé de t'avoir imposé ce merge pénible... C'était l'urgence hier soir


안녕?


assert() is only enabled in debug builds...


Looks good to me.


done, added back with slightly smaller values


I can't locate code using these enums.


Oh, I thought it enabled by default in gcc...


Would it be an idea to encapsulate these constants into a `Retirement` concern? That way, they can be name spaced more meaningfully eg `Retirement::EN_ACTION_IDS`?


Je revert ca, ca a fonctionné avec le code existant, je vais voir ce qui est cassé


I assume this to be a debugging artifact, right?


springlobby.exe -cl |more works for me on windows xp... weird


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.83](http://teamcity.monogame.net/viewLog.html?buildId=7015&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 485, ignored: 6 Build time: 00:18:59


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.84](http://teamcity.monogame.net/viewLog.html?buildId=7019&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Can u see this?
https://github.com/yeasy/openstack_code_Heat


does it worth it ? This method is executed 4 times during the life of analysis.


Fix: https://github.com/DheerajKhajuria/pimatic-mysensors/pull/17


30411/Alungei C. Paula Carla/Graphs101 - complete take 2/graphAlgorithms.c

but keep in mind, the parent of the parent of `minEdge.source` could actually be the parent of `minEdge.destination`. What then?
These cases should have been treated


Maybe this happens because I used mingw-w64 to compile springlobby under Windows.


BellmanFord also returns whether or not we have a negative-weight cycle in our graph


2次循环 pos.x的值应该是0，0； 但实际上是0，3


ok


Just to double check... Now we have: `number_of_irqs = hip->sel_gsi + 1`, right?


@danelowe This search is recursive. What happens at L10 is only to ensure that the given argument will be a Hash.
If the key is `"address.street"` we want to be sure that if a Hash param or an object are passed to the constructor, we're able to retrieve that value.

### Case 1 (params)

```ruby
values = Values.new({}, { address: { street: "Mass Ave" } })
values.get('address.street') # => "Mass Ave"

# It delegates to @params.get at L15
```

### Case 2 (object)

```ruby
address = OpenStruct.new(street: "Mass Ave")
values = Values.new({address: address}, {})
values.get('address.street') # => "Mass Ave"

# It delegates to #_get_from_values at L15
```

At L30, we want to make sure that `address` respond to `#street` before to sending that message.


new line at EOF


I usually put ` @CheckForNull` on properties as well as on getters.
Two benefits:
* issue can be raised on internal code too
* generating getters with IDEA from properties which have `@CheckForNull` will add the ` @CheckForNull` on the getter as well


`right` and `left` are the two parts of the `&&` here, if they are not binary expressions themselves, then we have nothing to do here. For example `true && f >= 3.146`.


public empty constructor are implicit. Any specific reason to have it here? otherwise it's useless and can be removed


what happens if the parent of the parent of `minEdge.source` is actually the parent of `minEdge.destination`?
These cases should have been treated!


thanks!!!!


Yes it should work, I'll take a proper look tonight and write a unit test to make sure / for documentation.


Bellman Ford should also tell whether or not we have a negative-weight cycle in the graph


Ok, I add a comment to the Intel spec for the local APIC


30414/Dolineanu A. Vlad Ionut/Assignment 6/graphAlgorithms.c

Bellman Ford should also tell whether or not there is a negative-weight cycle in the graph


![screenshot](https://cloud.githubusercontent.com/assets/301564/7490488/3ca4893e-f3e1-11e4-9140-3f14684ae8e4.png)

idk, maybe log-level is to low.


Thanks. Removed.


30414/Tatar I. Mara/assignment 6/graphAlgorithms.c

Bellman Ford should also tell whether or not there is a negative-weight cycle in the graph.


Godo job with everything else


Tackar! Bra kommentarer!
![dlrt3tn](https://cloud.githubusercontent.com/assets/442870/7490497/5a3de634-f3e1-11e4-84dc-f730fe65891c.jpg)


Yes, removed.


Good Luck. And thanks.


Update: U can select the folder at startup, whatever ur frostbite 3 game is installed in.


Lovely work


instead of having required field only documented in JavaDoc, what about exposing a static method with all the required fields as parameters and declaring constructor as private. Static method could in addition use `Preconditions.checkNotNull` to provide fail fast in case of null values.

This way, required fields are programmatically declared and enforced at runtime


30414/Nistor A. Rares Constantin/assignment6/graphAlgorithms.c


Everything else looks good


Pour ne pas que pylint crache des erreurs du type "attribut non initialisé dans __init__". C'est une bonne pratique en fait.


Since this is a *universal* use case, wouldn't be `*read_input[]` be more apropiate?


Great work


`Joiner.on(" / ").skipNulls()` should be static to avoid multiple instance of a threadsafe object.
Who knowns how many times a `toString` method can be called?


> This is now the first mention of HTMLMediaElement in the spec. I guess this "Return values for HTMLMediaElement.kind" can be removed with no ill effect.

Let's remove the caption from this table then.

> My model has been that media elements would have an attribute, which would determine the initial configuration of the media session that is created and activated when playing. Otherwise the category could change mid-playback, and I think that's harder to implement.

Right now in the 'media session activation algorithm' the attribute on a media element is read once when media begins playback. If the attribute value changes mid-session then it does not have any effect. Pausing and playing the element again does allow the attribute to be re-read and the category to be changed.

> In other words, I'm thinking either a media session should have a category (just like media element) or some more low-level behavior-oriented flags that are determined by the media category. Probably the latter would be a cleaner separation and would allow us to not put labels on some combinations of flags where the use cases are not so obvious.

The spec currently uses the former. A 'media session' is currently implicitly keyed on a specific media category (so each tab could potentially have up to X media session objects - where X is the number of available media categories which is currently 3).

Having said that, what you are suggesting would provide a cleaner logical separation of media session state and media element state. I think that would be a good thing and the spec would benefit from that.

So no specific updates will be made to the spec on this right now but we should be looking for a better logical layout for the spec in general in the future?


30414/Kari Z. Tamas Zsolt/Graphs101 - complete/graphAlgorithms.c

Bellman Ford should also tell whether or not we have a non-negative weight cycle in the graph


new line at EOF


No. The second operand of add_range is a size argument and the -1 is wrong in this case.


missing space after dash


Would there be any problem if MAX_PROTOCOL_MESSAGE_LENGTH is too close to MaxBlockSize? Now it is 2,097,152 vs 1,000,000 and you propose 20,971,520 vs 20,000,000


30414/Curea D. Sergiu - Dan/Assignment6/graphAlgorithms.c

terribly wrong. this has to be done a lot simpler


Why not use `uni` and `getParent` functions


Hum, I think `arch_reserved_mem()` is the more natural to read and is more in line with the rest of the MM API (e.g., `arch_init_mm()` instead of `arch_mm_init()`, `unmap_frames()` instead of `frames_unmap()`). Your suggestion probably follows a different naming scheme which would also require changing `mm_total_pages()` to `mm_pages_total()`, or `mm_free_pages()` to `mm_pages_free()`. What do you think?


no.. but i said -j ... what it means also -j1 -- even -j1 will make compiling time longer .. shortest compiling time with single core is without -j :-)


Why?  Is this a bad idea?


I have got the same question. How can I reach George/Ron?


Right. We need a better logical abstract model for 'media session'. Let's continue working on that. Thanks for the pointers to similar problem areas.


I've introduced an `attr_accessor` later on already :)


remove `test` folder


30414/Popescu P. Diana Gabriela/assignment6.1/graphAlgorithms.c

Bellman Ford should also tell whether or not we have a negative-weight cycle in the graph


Would not it be added the same options as in `jsdoc/file-readers/jsdoc.js` file ?


Fixed in https://github.com/whatwg/mediasession/commit/9545e24cc77d394e471f5ebf23e2fcf14bce1e0e.


Thanks for the commit, I must have missed the pull request mail :)


Your old aunt wants docs :)


в методе бо шло обращение к ownerform без проверки, что она существует. случайно заметила.


Hm. Then the problem in my build configuration. I will investigate it later...


Afaik, this is the closest we can get to enabling that whilst still using `useref`. We had an option to switch over to a different task for achieving this, but decided to not fully break support for legacy users that are used to using useref.


30414/Palko A. Lorand Arpad/AssignmentSearch/graphAlgorithms.c

what happens if the "tag" (or parent) of the parent of `minEdge.source` is actually the parent of `minEdge.destination`?
These cases should have been treated


favor having a static method returning a `Function<File, PluginInfo>` instead of exposing an inner enum/class directly. It is way more refactoring friendly as it hide implementation details (think about the case if for any reason you have to change from a singleton enum to a class) and more readable where its is used (no ugly `INSTANCE` in code) and its static import friendly


Need to also handle the case where you're moving it from an EIR only public body to one that isn't


Returns of methods are always considered as not nullable. They have to be explicitly annotated with @CheckForNull when return is nullable.


pin. variables uniquement utilisées dans handle() : self.override_all(OVERRIDDEN_TEMPLATES, options['fun_repo']
, reverse=options["reverse"])  enlève  deux lignes.


cc @jeffposnick as this is valid feedback. Is it worth us making this less noisy?


Yes! We should. If you have time to PR it in, please feel free to otherwise we'll get around to it before the next release.


check your IDEA settings, you have the default "put javax imports" which is not much compatible with Eclipse's import management. I removed it after I had several of this stupid changes in a row


Thanks!


Yes, I am refactoring this right now to pull the parser out into its own injectable service that we can configure application wide.


no, why ?
The point is that classloaders can lock JAR files, so these JAR files must not move once loaded -> that's the reason why extensions/plugins/*.jar are not directly loaded by classloaders and are copied to another temp location.


found this interface is not necessary.


Hi, Is there a semantic reason why you moved the Atom match down or is it done to increase performance?


Are you sure we want to pollute global space with all these words? I bet that most of them nobody knows anyway. And if we really want names for colors, having them in some block, from which could be all listed easily would be more practical.


User defines his mapreduce configuration below


User build a new mapreduce bootstrap, and start with his own configuration


I assumed so because I didn't otherwise understand the "For this reason" that follows next

I fear I don't understand the description of the "unzip" method at all, in fact


`switch (address)`


the comments is wrong, i will change immediately


This is a problem because WIFI_IFACE etc. are set depending on analysing different switches. By the time these are analysed, I feel we would have executed a lot of unnecessary code, for just storing configs.

I can instead maybe store something like
ARG1=wlan0
ARG2=eth0
ARG3=hotspot_name
ARG4=password


Implement a mapreduce task builder


you know what the Hao Tian (updateing) has maintained his caf sources updated you can just do a diff and merge it into our kernel driver and all.


Can we really mark this as non-normative? For example it does include a number of spec definitions even if those are just logical concepts that tie the spec together.


Wurde diese Instanzierung bereits getestet?


Does the GCC version have to be hardcoded here?


sorry kernel at https://github.com/updateing/kernel-msm


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.84](http://teamcity.monogame.net/viewLog.html?buildId=7019&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 485, ignored: 6 Build time: 00:21:46


Love the "foo: bar" tests. Missing a 42 somewhere!

I'm not content with the `Map<String, Object> additionalInformation` declaration in the domain class.
It is technically correct of course, but data is stored in this table:

```
access_token_additional_information (
    additional_information bigint,
    additional_information_idx varchar(255),
    additional_information_elt varchar(255) not null
);
```

No indexes, for one, and a wasteful design IMHO. I suspect the objects are serialized to the `additional_information_elt` field.

In my own project I'm using strings to flatten the various sets and Maps before I persist them, using Groovy methods such as `inspect()` and `join()`.
Below is an example you can run in groovyconsole.

```
Map map = [foo: 'bar', number: 1234]
String serializedMap = map.inspect()
println serializedMap // prints ['foo':'bar', 'number':1234]
Map deserializedMap = Eval.me(serializedMap)
deserializedMap.each { k, v ->
    println "${k} = ${v}"
}
```

It can't store everything of course; Eval.me() trips on parsing certain data types (such as `Date`). But if you take care in what you put in, I think it's a fairly efficient way to store this kind of data.

Another example is the set of scopes; we know it's a list of strings; the tough part is getting the size of the field right.

```
accessToken.scope = token.scope?.join(',')
...
token.scope = accessToken.scope?.split(',') as Set<String>
```


favor using a static `Pattern` instead of `String#matches` to save on the repetitive cost of compiling the regexp each time the parse method is called


descriptive variable names


Run controller/task node could be changed to run a node by any way(like terminal, kubernetes)


https://github.com/sue445/jenkins-backup-script/pull/20 で取り込んでおきました


pong


Pong


Nice :+1:


what about adding a link to the class responsible of enforcing compatibility?
I believe it is useful documentation here


Should be called something more descriptive