This will help out @asitang @sujen1412 and hopefully the rest of us to
break down the barriers to better understanding Fetcher in trunk codebase.
Great work folks.

On Thu, May 7, 2015 at 9:49 PM, Chris Mattmann <notifications@github.com>
wrote:

> Bewm @asitang <https://github.com/asitang> @sujen1412
> <https://github.com/sujen1412>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/nutch/commit/2c230ddf1a0084273613f5d4a3e247784383273c#commitcomment-11100896>
> .
>

--
*Lewis*


Just to point out that here, you left the Ogre::StringConverter while using the helper elsewhere.
Maybe we should open an issue about fixing all occurrences at once?


jvshou


It's possible I missed something, will take another look.

On Thu, May 7, 2015 at 9:49 PM, Clayton Coleman <notifications@github.com>
wrote:

> Pushed all the comments except the heisenbugs it's either too late for me
> to see or which are not actually bugs. The testallocatesmall test logs in
> -v and I can't see what you're referring to - the allocated object is
> inclusive so the strategy doesn't need to know about offsets (unless I
> again don't understand mod). Because the base is always the first valid
> address, and base+max is the index of the last valid address, and max is 2
> less than the cidr range (so we omit base and broadcast).
>
> > On May 8, 2015, at 12:38 AM, Tim Hockin <notifications@github.com>
> wrote:
> >
> > Because I unwisely made comments on the commit, please fix as a new
> commit,
> > so I can remember the bugs I found. :)
> >
> > On Thu, May 7, 2015 at 9:35 PM, Clayton Coleman <
> notifications@github.com>
> > wrote:
> >
> > > We already solved naming and distributed cache invalidation so I
> wanted to
> > > get the hat trick.
> > >
> > > > On May 8, 2015, at 12:33 AM, Tim Hockin <notifications@github.com>
> > > wrote:
> > > >
> > > > Then you have to fix all the off-by-one errors. Wrap this check up
> as
> > > Range.Contains() and get rid of the other Contains() calls.
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub.
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/smarterclayton/kubernetes/commit/a1c23457d52f24217f4eab0fcf31fbf46886aaad#commitcomment-11100797>
>
> > > .
> > >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/smarterclayton/kubernetes/commit/a1c23457d52f24217f4eab0fcf31fbf46886aaad#commitcomment-11100890>
> .
>


前端的工作在我自己的不算深的理解中，应该分为几个方向，第一，处理网页在浏览器中的渲染和视效，架构网页的dom结构；第二，处理与后端的数据交换，将数据转换成view中的一部分或者作为model的一部分；第三，现在前端也可以用js渗透到后端，比如node.js和io.js之类的；现在很多意义上的前端做的大概是前端，前端后端连接这样的事情。


You may have fixed something here, right?


본 프로젝트는 비디오에 대해서 자바스크립트를 이용, 제어가 필요할때 사용하기 매우 유용합니다.


此地方有 cart_item 的檔案位置問題，因為刪除 cart 商品是屬於 cart controller 做的事情，所以我把 delete_one controller 寫在在 cart controller 中，導致引用的 jsr 必須要從 products/cart_item 中取得，所以我覺得這 cart_item 的 html 檔案應該要移動到 comment/cart 之類的分類去，才不會導致 products/add_to_cart_item.js.erb 用 cart_item 但 carts/delete_one.js.erb 要用 products/cart_item 的 view 檔案，變成分類怪怪的～～～～


This looks useful. Maybe canisters, barrels and even crates could be made respawnable by default (customParams)?
I'm not sure the CheckMoved could be used in all cases though, this would cause problems with crates that you'd want to place on plates. This in particular seems problematic:
-- (1) its position is not equal to where it started and it hasn't moved for 30 secs
, while this could be used for the current map, although might not be applicable in general:
-- (2) its position is above its original height by more than 20 elmos, and it hasn't moved for 10 seconds

In general if CheckMoved is used it might confuse the player to see items moving to different positions.

The problem with Respawn is that it should essentially copy all the unit properties the initial unit had. This is actually not trivial (https://github.com/gajop/Scenario-Editor-Core/blob/master/scen_edit/model/unit_manager.lua#L98-L155) so it might be better to rely on Scened for this. I really want to make this a standalone lib as it's useful for many different projects and purposes include save/load, copy/paste, checkpoints, etc, but I haven't had the time yet.
What you could do is invoke something like this:
-- initially
local originalUnit = SCEN_EDIT.model.unitManager:serializeUnit(unitID)
watched[unitID] = originalUnit

-- respawn time
local originalUnit = watched[unitID]
SCEN_EDIT.model.unitManager:loadUnit(originalUnit)

(I might need to export SCEN_EDIT to GG, not sure, but that should be a one-liner)
This still wouldn't work for plates-gates (as they're not linked in the unit rules), but I don't think those will ever be respawned.


原来是这样。。


Nice cleanup! :) Even if that's code being moved in the manager, it's IMHO a very good thing.


Your great template deserves at least a `.. hint:` box IMO :) Do you want to add one? Otherwise I'm happy to merge. Thanks for the PR.


@livecodesebastien here pTarget is Simulator 8.3 etc so you just want to put the last word of pTarget into tSuffix. LC 7.0.5 rc 2 fails to find simulator builds because it's looking for `ExternalSimulator-Simulator 8_3` rather than just `ExternalSimulator-8_3`


I wonder if the move to 24.4 might be an issue for Ubuntu users? The repositories still seem to carry 24.3.


See - https://github.com/EFForg/https-everywhere/pull/1639#issuecomment-100027743 ; this is accidental  :palm_tree:


상관 없습니다. 처음에 eclipse가 없으면 제대로 실행이 안되기 때문에 넣은 것이었어요.


New commits removed this requirement. It's now a suggested package for installation.


Probably because it came into C# in version 3 and making it keyword would break backward compatibility of source code :(


Trying to figure out what ```>>=``` does I came across this comment: "Awesome. I was looking for a better way to write more perl in my java projects." :smile:


Admidio Version should Not be shown in Page because of Security reasons. If we have a Problem with one Version than People should Not Scan the Internet for this Version.


That's a good point. I was thinking that we wouldn't allow it to be overridden. I'm not sure which is more correct.


This formatting is strange. Is this like a design practice for syntax?


"is_" は不要。xxxx?がその意味となる。


Heh. I meant to come back for that, but I thought it was interesting that no one has ever noticed! Android actually splits up filter into a list of strings. We should file something to do that. I'll do it.


前端的目前生态环境是比较混乱的，但是可以从各个社区 里看出前端圈中的人非常活跃，热爱造各种轮子，设计各种框架，不遗余力的去拓展前端领域。这样一个充满热情的领域值得一个热爱程序的人去热爱它。而且前端入门门槛低，但是要做好，却需要极大的热枕和努力，既然入坑就要好好去做的。


Ok gentlemen, my SOLR dump is loaded here:

http://macleod.vbi.vt.edu:8983/solr/#/

Sam and Mike, can you guys look over this load using the web interface and make sure things look okay?
Once we give a thumbs up, Maulik and the PATRIC guys will make a data API for us to use and write our services against, so the sooner we get this checked the better.

Don�t worry about specifics on the compounds and reactions loaded. Just make sure the representation and data content looks okay (e.g. do we have the right tables, the right queries, and the right type of data loaded).

Chris

On May 7, 2015, at 11:43 PM, samseaver <notifications@github.com> wrote:

> In this set of modifications, I updated any supposed empty formula to be "null" and adopted the plantdefault formula where the difference was restricted to protons only. There was probably only one compound that is problematic with respect to protons:
>
> cpd04097 (Lead):
> KEGG: InChI=1S/Pb.2H
> MetaCyc: InChI=1S/Pb/q+2
>
> Evidently this is supposed to be Pb2+ and I don't know what happened to the KEGG InChI string but this is something I will modify.
>
> �
> Reply to this email directly or view it on GitHub.
>


You should not need this check at all since the below is just a stricter form of the same, no?


Hi Chris,

I see, you just extend the list which results ind te increase of binary size even if subscriptions are disabled.
Please collect additional elements in a new, deficated list and concatrnate it depending on the cmake option (you can pass it to this script).


What is this ^ supposed to do :)


check that found is length 2 and holds 192.168.1.241 and .242


StringSet


做过的最复杂的一个项目的是制作一个2048小游戏，当时做的时候，没有参考其他的代码，自己写逻辑控制，最后代码的模块和架构层次很混乱。demo在后来加轮子时，出现了很多问题，接下来，我在很多的网站上去看别人的代码，分析别人的思路，重新整理自己写法，规划逻辑控制器，较为清晰的规划出自己的代码。


maybe loop until AllocateNext() fails or 2*Free() - to be pedantically sure that it allocates exactly 2 and no more and exactly the ones  it should


For my own culture, I must say I'm still wondering what kind of design pattern(s) is/are used here.
Looks like a registry using templates but I'm not sure. Anyway, it looks fine as for me. :)


is_target_data? は target_data?でいい


修正します


Damn, I was wrong.  What a waste of energy.  I missed that allocated[0]
represents IP base+1

On Thu, May 7, 2015 at 9:52 PM, Tim Hockin <thockin@google.com> wrote:

> It's possible I missed something, will take another look.
>
> On Thu, May 7, 2015 at 9:49 PM, Clayton Coleman <notifications@github.com>
> wrote:
>
>> Pushed all the comments except the heisenbugs it's either too late for me
>> to see or which are not actually bugs. The testallocatesmall test logs in
>> -v and I can't see what you're referring to - the allocated object is
>> inclusive so the strategy doesn't need to know about offsets (unless I
>> again don't understand mod). Because the base is always the first valid
>> address, and base+max is the index of the last valid address, and max is 2
>> less than the cidr range (so we omit base and broadcast).
>>
>> > On May 8, 2015, at 12:38 AM, Tim Hockin <notifications@github.com>
>> wrote:
>> >
>> > Because I unwisely made comments on the commit, please fix as a new
>> commit,
>> > so I can remember the bugs I found. :)
>> >
>> > On Thu, May 7, 2015 at 9:35 PM, Clayton Coleman <
>> notifications@github.com>
>> > wrote:
>> >
>> > > We already solved naming and distributed cache invalidation so I
>> wanted to
>> > > get the hat trick.
>> > >
>> > > > On May 8, 2015, at 12:33 AM, Tim Hockin <notifications@github.com>
>> > > wrote:
>> > > >
>> > > > Then you have to fix all the off-by-one errors. Wrap this check up
>> as
>> > > Range.Contains() and get rid of the other Contains() calls.
>> > > >
>> > > > —
>> > > > Reply to this email directly or view it on GitHub.
>> > > >
>> > >
>> > > —
>> > > Reply to this email directly or view it on GitHub
>> > > <
>> https://github.com/smarterclayton/kubernetes/commit/a1c23457d52f24217f4eab0fcf31fbf46886aaad#commitcomment-11100797>
>>
>> > > .
>> > >
>> > —
>> > Reply to this email directly or view it on GitHub.
>> >
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/smarterclayton/kubernetes/commit/a1c23457d52f24217f4eab0fcf31fbf46886aaad#commitcomment-11100890>
>> .
>>
>
>


Fix #1


```ruby
def set_data(data)
  if is_target_data?(data)
  @data = data.to_json
end
```


Eh eh. Teasing the next commit? ;)


This assignment is already done in basehandler


熟悉HTML，css，js，会用简单的css3和html5；会用jQuery框架，能用php做简单的博客和留言板之类的小应用，但实际项目做得不是很多。造了不少小轮子，比如轮播图，雪花动态图，抽奖系统之类的。对js原生的面向对象比较感兴趣。


y esto?


should be use fully-qualified name like `new kits.Generic` not `new Generic`


I'm really not a fan of having everything in one namespace. But let's wait until it bites us ;-)


No assert/expect ?


the same comment


:+1: Thanks a lot, @chenxsan


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (626 of 626 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.23%25-green.svg)


All of the scripts here are meant for educational purposes only. The materials here are only posted after assignments are due and are not intended to allow any plagiarism. The scripts may have errors and are a result of the assignments for spring 2015.


リード準備、リード、リード後処理に分割して、無駄なオープン、クローズを減らすべき。


Nice!


@sgillies this line is still needed for the dynamic loading below.  I'm getting an error without it.


@RobLoach My first time maintaining such a thing, if something's wrong, please tell me.


jiji


To get RIL working on every device I should start some repositories from CAF like CM, SlimRoms etc do. Anyway actually I'm focusing on other things so I don't have time to do this...


We can remove this _save() line right because we've checked on the line above that it's already true?


thecatshidog


they're both binary, you mean bitwise :)


Copy this to C:\Windows (just like where notepad.exe is) so it can be run from Win+r.


https://gist.github.com/ilyubin/bcbb5f01d8c83dc0f488
https://gist.github.com/ilyubin/f7995f18a9adc1b0590b


OK, seems we won't need passing the environment. I just patched your diff, and think more correct solution to exclude `Object.prototype` would be the condition:

```javascript
do {
  Object.getOwnPropertyNames(object).forEach(collectProp);
  object = Object.getPrototypeOf(object);
} while (object && Object.getPrototypeOf(object) !== null);
```

I.e. next prototype is `null`, it's very likely we deal with `Object.prototype`, and the condition will stop.

Also, what about excluding mocking of `constructor` property, etc as you mentioned? Should we filter them out?


agreed-- i think this should be a default namesys that only fetches local records. (i.e. later  on `Namesys` should not be `nil`)


Such merge, much review, wow


Makes me wonder if there are other language constructs that can be F'ed up in the same way.


Важная правка? :)


Could probably be 2 look ups,  `if (key in TRANSITION_OUTS) {` and `if (key in TRANSITION_INS) {`


Не надо комменты слева. Лучше сверху.


I will rename PARTITION to DATA


И лучше по русски, понятно что его не ты писал, но или переведи, или убери.
Лучше переведи.


Хорошая идея не проверять токен?
Плохая..


=> меняем на ":"


请更新至最新版本。

Semigod King
2015年5月6日 下午9:06于 "qiuzi" <notifications@github.com>写道：

> @LazyZhu <https://github.com/LazyZhu>
> 我按照教程在openwrt里配置
>
> ip rule add fwmark 1 lookup 255
> ip route add local 0.0.0.0/0 dev lo table 255
>
> iptables -t mangle -A PREROUTING -p udp --dport 53 -j TPROXY --on-port
> 12345 --tproxy-mark 1
>
> 这样不行
>
> 请教怎么配置
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/semigodking/redsocks/commit/de412cca5026421e803ea551c9aa4509027ea60e#commitcomment-11064908>
> .
>


Надо бы комменты оставить ко всем путям, их уже дохрена и можно запутаться.


Не надо хелперы переводить на HTML.
Придумай метод, чтобы работало без этого.


:+1:  for print debugging :D


@chenxsan You did a great job.... Looks like it's just missing the tag. `git tag 2.1.4 && git push origin 2.1.4`


FYI, the build is broken

http://dotnet-ci.cloudapp.net/job/dotnet_roslyn_windows/930/consoleFull#923032420a82fefab-f698-416f-8fca-58544c94cd4e

> Implementation\Interop\WrapperPolicy.cs(22,43): error CS0246: The type or namespace name 'IComWrapperFactory' could not be found (are you missing a using directive or an assembly reference?) [d:\j\workspace\dotnet_roslyn_windows\Src\VisualStudio\Core\Def\ServicesVisualStudio.csproj]


Is this a symlink? I don't think this will work on Windows.


They are in two different functions, bgsave and bgsaveto


Pardon? Is bgSaveSem not clean or inner struct?


ta bueno


A great mod


dsdsd


@bueler This is perfect. Thanks!


还在用SQL？


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1139 of 1139 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


hhh


入力のdataはHashでto_jsonすることで別オブジェクト（String）にして保持するようにしている
なので、今回はcloneせず、このままとする


Expadv2 is dynamically typed too, but it is a lot more restrictive about it.


@RobLoach Done, thanks :)


Did you missed the router ?


// i mean this, Handler with an inner counters struct
type Handler struct {
          counters struct {
 		bgsave          atomic2.Int64
                ...
           }
}


Looks good to me!


LGTM. Nice work!


yeah, i got it:)


test


Би трябвало да е качено вече ?


No longer need this fix


Hmm, I think I did not get your problem right. You are indeed focusing on collections, not on sequences. The former case is simpler to me because applying a change on a collection is less costly than applying a change on a sequence. If you really want to study incrementalization of collection combinators, the very first step is to use an appropriate datastructure that has efficient insertion, deleting, union and restriction operations. What about an HashSet for instance?


It's the old code and I think inner struct is ok sometimes, here we can define a stat struct later, but now let it here. :-)


whoops.  thanks!


Oh my !


Initial commit


@harikt thank you for your attention ;)


the improved method of handling imgURL in endpoints/cinema/index.js is returning "http://kvikmyndir.isnull" for every poster.


ok, got it:)


LGTM.


You're planning to fix this broken patch, right? Looks like just creating an IMP.atom.BrownianDynamics object now takes up to 60 seconds, far longer than the simulation itself (see for example http://integrativemodeling.org/nightly/results/?comp=21&plat=4 ; same with atom tests, atom examples, and rmf examples, all of which use BD) and in the process overwrites something somewhere in memory causing random problems (in that case, particle attributes get randomly erased). If not, I can revert it until you figure out what the problem is.


Shouldn't you also refactor line 17?
The js task does not exist anymore, or does it?


Thank you for these fixes! :)


It doesn't seem like this code should belong here, maybe resourceloader? Should I be requiring cssom in resource-loader, or should I add code in level2/style.js? Or I could move all this code to utils and require it?


What is a short hand for a dereference operation of `Ref`? There is only `getindex` method available. It looks ugly with suffix brackets.


copied from the blink repo


For some reason I get the following error when running the tests:
```
FAILURES: Undone tests (or their setups/teardowns):
- getComputedStyleFromDefaultStylesheet
```

it doesn't happen when the test fails. Ideas?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14695/testReport/) for this commit**


... 数据库信息写在配置文件里，不要 hard code 进去


I changed the directory of my toolchains here. The makefile~ was only a result of a action with the toolchains


I found that using `click_link` failed as Capybara/Selenium/poltergeist can't find items in`::before` elements.  (https://github.com/teampoltergeist/poltergeist/issues/281).  I'm using the workaround suggested in that issue because it works.


On clicking on button.
it redirects to safari not to lyft app.
What is the issue then?


cat vs. dog


One more question:-
How to enter address ?


It feels a bit strange that the begin and end year are under the name object. These are after all the begin and end years for the whole school, not just this specific name.


Since a fully automated test, is IMHO too hard to maintain and a too big effort compared for the benefit, what about a half automated one.

I am thinking about a button in a the developer menu that dumps all COs and their current vale. This along with sample runs as golden samples will be helpful in many ways. We may also add a button to calls meld if installed to make the usage threshold even lower.
So if one touches something CO related, he can allays compare two process states easily.
It is also possible to dump a state, make an action and dump again, to see if there where changes in unrelated COs. Doing it this way requires some knowledge which the tester should already have, but which is the hard part to include in a automated test. A fully automated test will finally only test one abstract model of Mixxx, which is close, but not the same as a real run.

The current regression would have been detectable independent from OS and uses skin.

If we cover this with an inner automated test, that assures that all kind of CO parameters and code paths works es desired the test coverage is sufficient for me.


What happened here? Why is this set above the Feraligatr line?


You could also specify what attributes should be inside the name object. In this case at least the official_name if you move the begin and end years to somewhere else.


why comma rather than semi-colon here?


###高手
。。。


Good improvement, but I think you should add some unittests of the Utils class.


Is the latest name always the first in school.names array?


I agree. I only used List because the "right" type, Bag, is a bit inconvenient to use, while Set does annoying duplicate elimination.


I don't know, but it doesn't really matter.

(Please don't comment in the first commit of a repository D:)


are you f*cking serious? using the KEYS command for a monitoring service?
the KEYS command is not really meant to be used in production, let alone monitoring.
this will block ALL of your redis commands for several seconds if you have many keys
see http://redis.io/commands/keys

consider using SCAN (or scan_iter when using the excellent redis.py package)


20150508new branch


I'm not done with this idea yet, still going to try coefficients more like the original 200.

The sign of psq differs from white to black, so that would have to be taken into account to make the use of psq viable. Still an interesting idea, but I wonder how well it would scale to the endgame, where psqt values can differ from their midgame values a lot more significantly than piece values do.


again new branch


Not sure where the right place to initialize this - no sense in doing it more than once. Maybe inside the Window function?


bu


But feel free to start by using HashSet :-)


This probably isn't the right place to do this - ideas on the right place to put this code? some combination of resource-loader and level2/style.js? or utils where I can require it?


bowerr already has all you need:
https://github.com/kof/animation-frame
http://bower.io/search/?q=requestAnimationFrame


copied from the blink repo


Wonder why you need aura/web. Looking at the code I am not seeing any usage of it. Did I missed ?


Very nice!


may be you mean require-dev ?


Did you mean "all" rather than "either"?


I don't like that this defines the return values in terms of a negative. Shouldn't it roughly say "return unclosed insertion points"?


why not just the width of PunctumSmall? Would seem the best solution here...


No, I meant *one or more* by "either*.


Sweet!!! Thanks... It looks good!


What exactly is this medium tag? Would it make more sense to use the HTML5 time tag with the years?


lua only has floats, so it doesn't have a real zero, and random tiny displacement can occur sometimes


`if` & `unless` are not the only modifier expressions you should account for. There are also `while`, `unless` & `rescue`. Not a big issue in practice, as few people use them, but we have to be thorough.


> copy all the unit properties the initial unit had
Copying all properties is impossible, for example there is no way to list rules params. But maybe a piecewise approach would be enough.

WIthout seeing how scene ed works I can't really guess what the best conditions for being stuck would be. Feel free to modify the gadget to suit both cases.


기본값이 나왔군요
좋은 업뎃이라 생각합니다


I think it would be better to specify these the other way around.
Base color would be a specific value. Then the navbar colors would be specified with the base-color variable.


intiial


Would this weird thing be due to https://github.com/gregorio-project/gregorio/commit/fcfeeffd233e6c941de27ef27afa04a8b7e5d601 ?


Either is one or the other. Since there's three, you need to use a different word.


增加readme


You can list rules params by:
https://github.com/gajop/Scenario-Editor-Core/blob/master/scen_edit/model/unit_manager.lua#L125-L127
and I eventually save it by:
https://github.com/gajop/Scenario-Editor-Core/blob/master/scen_edit/model/unit_manager.lua#L219-L225

I'll see if I can do some modifications now or consider separating this in a library used by both projects.


hmm I'm not sure I get that myself - I will check out if something is
different in my repository

On Thu, May 7, 2015 at 11:06 PM, Ben Webb <notifications@github.com> wrote:

> You're planning to fix this broken patch, right? Looks like just creating
> an IMP.atom.BrownianDynamics object now takes up to 60 seconds, far longer
> than the simulation itself (see for example
> http://integrativemodeling.org/nightly/results/?comp=21&plat=4 ; same
> with atom tests, atom examples, and rmf examples, all of which use BD) and
> in the process overwrites something somewhere in memory causing random
> problems (in that case, particle attributes get randomly erased). If not, I
> can revert it until you figure out what the problem is.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/salilab/imp/commit/8d77b01ec2ec5ce2dad618db0cfd0f13db65ee9d#commitcomment-11101408>
> .
>

--
Barak


@petterroea Why did you commit this to the master branch? Thougth we agreed on using the development branch until everything was stable enough for release?...


Ok - but there is still nbo way to transfer _every_ proprty.


yes - i am mentally prepared to adapt for different api in the next airtunes attack :) (current attack was just about impementing all features of libshairplay which are and well understood atm like dacp and the progress)


mmmmmm goooood :+1:


Here you could specify which attributes need to be inside the building object (See: https://facebook.github.io/react/docs/reusable-components.html). In this case at least the photo attribute.


both are correct. you are super !


:smile:


edits


Schema locations should use the public sources, and not refer to a service instance.


Would it be better to just use img instead of a background image?


Make sense to me now :)


Currently the method doesn't return anything, right? So it wouldn't be a problem to make it return the path now.


There are some minor properties such as AlwaysVisible for which there is no Get method and thus not possible to get the current state, but most should be transferable.
The point is I think this whole save/load unit functionality should ideally be done separately.

This implementation will work in most cases (although needs rotation and unit rules for invulnerability copied as well), but I'd prefer a general solution that we don't have to maintain in Gravitas.


If the _id type is not ObjectId you have to manually set it before inserting


Is the main building always the first one in the buildings array?


2.0 stable version 了啊，看这个star的速度，有没有想过弄个QQ群了？


Thanks. Travis fails with a weired error, though.


Good idea, given the changes coming :D


Agree. However "unclosed" can't be used in standalone because it's relationship between two nodes.

Do you have any idea to simplify this?
Does "unclosed insertion points of the context object in the destination points of the context object" sound good?


could be factorized with evaluateConditionToFalse, since the only difference lies in the state


这他么是干嘛用的草


Got it. I can fix it later. Thanks!


ako date i time sa text moje li da se sortirva po tqx pri zaqvka?


Proposing changing returned id to Integer.


1) Add access modifiers to classes.
2) Using overrided equals to compare objects of different classes.


Instead of checking preconditions with ifs in two places I was thinking to get rid of this "force reinit" code here, and completely bypass service creation if they already exist. Would be cleaner I think. Thoughts ?


replace "Vienne" with "Vienna" ;)


@Anandaely 我先记下，后面看看怎么搞。


this is how I activate the use of gateway, only if we actually need uuids. i reuse the gateway param...


1) Add access modifiers to classes.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/operations.lib.php


replace with this -> "Laura, Anika and me got to meet up and even managed to smuggle in some RGSoC work, which we tackled together, as well as participate in the Hackathon."

(added a comma and removed some extra spaces)


This is a lot of XML, and not nice to read in a PDF or even being printed. For the document, we should stick to current version and add a link to the full response in the comment.


Careful here, this will change the behavior (standalone /app_manager/* -> /myrobot/*) , but the turtlesim concert is an example where we have an expected namespace (robotname) while not having uuid, so we need the naming strategy to be the same with gateway when we dont use uuids, and no gateway. Will that cause a problem ?


We need a sleep now, since we wont be always looking for services. 10Hz ok ?


Traits have a very specific use case. You shouldn't just use them because you can which is why I feel like a trait should never belong to a general namespace for general purposes. The ones you created are meant to be used in event classes. BTW: `GetBufferTrait` feels strange as well for a method providing both, getter and setter :)


I already removed it ;-)


I said that, not Lucas. And I realized shortly after saying it that the sorting isn't in fact stable after all.


接受


Could be more descriptive in what the prefix is used for.


Yeah, that seems better. Or maybe we should have "light tree", "shadow tree", "composed tree", and "unclosed tree" and then each time we just specify the tree we're talking about. And for a given tree we can then use the definitions that DOM already defines, such as parent/child/ancestor etc.


Could be a bit more descriptive in what the artist wants to say here.


I'm not sure what you mean - the output variable "err" is defined in the method signature, and a naked return will therefore return it from the local scope.


Since it seems at least one person has been misled by my previous comment: I was wrong. The sorting is not stable.


Maybe proper handling if one of both is not set; e.g. by providing a warning (potential for a -v/--verbose switch)


@tvsonar this bits do not seem to be covered by the unit test


this is strange. I assume https://github.com/fsprojects/FSharp.Atom/blob/develop/build.fsx#L160 is not working correctly for you


```
background: url(http://www.syoujyoskip.com/imgs/img-navitop1.gif);
```
は
```
background: url("/assets/images/img-navitop1.gif") no-repeat 0 0;
```
backgroundプロパティは背景に関する値をまとめて書くときに使うもの

```
-.navitop2 {
+.navitop1 a:hover,
+.navitop1-on a {
+background: url(http://www.syoujyoskip.com/imgs/img-navitop1-on.gif);
+}
```
こっちで背景画像を上書きしてるのだから、ここは
```
background-image: url("/assets/images/img-navitop1.gif");
```


I'll just assume that this part "does the right thing"(tm)


Was this change made by intention and does it match the DONLON data?


It is used [here](https://github.com/shedskin/shedskin/blob/b54fa10d27f69e13b90d1f4c68713fa466571b18/shedskin/makefile.py#L79). You can override the flags on the command line, or with  a `FLAGS` file. Maybe we should just use some reasonable default, if there are no environment variables set and stick with environment variables if there are some.


- Added 404 page
- Added 403 page
- Added 'Details' page
- Added restricted access to pages 'Upload' and 'Admin'


XSS if hostname in repository malformed.


maybe try to revert to https://github.com/fsprojects/Paket.Atom/commit/b6e650da3018d9d248f84354636bf0e1b1136aa6


how about this function use space


:rice: ポイポイ


Similar XSS to the one above for Bird.


なんかインデント？タブ？が・・・


What would happen on conflicts.  As a Customer I would want to setup a preference, probably in the order that I added them.    But if from the User point of view the same thing happens, I get the Best Match, I am fine with it.


What name do you suggest?


s/datastructures/data structures/g


Shouldn't this be the job of the respective sub classes?


Question (I had the doubt while translating the related strings): shouldn't the function be called "Gadgetbridge messages" instead of "Pebble message?
Personally speaking I am interested in getting the miband to notify me on conversations messages.


Perhaps the regex in get_pylint_version() would also need to be updated?


The go-sqlite3 package has a specific unit test for exactly this locking mode, so I suspect the answer is "yes" :)
https://github.com/mattn/go-sqlite3/blob/master/sqlite3_test.go#L641

For what it's worth, the PRAGMA queries are passed directly to the sqlite3 library as buffers.

As far as I could tell, the previous method of passing pragmas to the database doesn't work (I have not found any supporting documentation at least). The pragma name was also wrong ("txlock" is not in https://www.sqlite.org/pragma.html ) but as documented, wrong pragmas don't error out by design, they simply do nothing.


@s7design: FYI. This is ok because dismiss/accept_alert() will die if no modal dialog is open.


Isn't this option missing? Or am I missing its spec above?


Similar with missing exclude/include support for communities...


@dejan Hej, hvala na pomenu :beers:


俺なら後々のこと考えて
各LIのクラスをnavitop●って名前にしないでval == 'top'に合わせるかなぁ
li.top
li.news
・・・
li.contact


关注我啊。。


Ahhh, here they are :)


* `Contao\CoreBundle\Event\Traits\RowAwareTrait` or `Contao\CoreBundle\Event\RowAwareTrait`
* `Contao\CoreBundle\Event\Traits\BufferAwareTrait` or `Contao\CoreBundle\Event\BufferAwareTrait`


This tests the JDBCLoader functionality


Looks kinda sane for a first commit ...


public class Card implements Comparable<Card>

	{
	private int face;
	private int suit;
	private String faces[] = { "Deuce", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Jack", "Queen", "King" ,"Ace"};
	private String suits[] = { "Hearts", "Diamonds", "Clubs", "Spades" };
	public Card( int cardFace, int cardSuit )
	{
		face = cardFace;
		suit = cardSuit;
	}
	public String toString()
	{
		return faces[face] + " of " + suits[suit];
	}
	public int getFace()
	{
		return face;
	}
	public int getSuit()
	{
		return suit;
	}
	public int compareTo(Card compareCard)
	{
		int compareFace = ((Card) compareCard).getFace();
		return compareFace - this.face;
	}
}

----------------------------------------------------------
import java.util.Random;
import java.util.Scanner;

 public class Deck {

	 private Card[] deck;
	 private int currentCard = 0;
	 private final int NUMBER_OF_CARDS = 52;
	 private Random randomNumbers = new Random();
	 private Hand handPlayer = new Hand();
	 private static final int ROYAL_FLUSH = 8;
	 private static final int FOUR_OF_A_KIND = 7;
	 private static final int FULL_HOUSE = 6;
	 private static final int FLUSH = 5;
	 private static final int STRAIGHT = 4;
	 private static final int THREE_OF_A_KIND = 3;
	 private static final int TWO_PAIRS = 2;
	 private static final int ONE_PAIR = 1;
	 private static final int NO_PAIR = 0;
	 private static String[] CardOrder = {"NO Pair","One Pair","Two Pair","Three Of a Kind", "Straight","Flush","Full House","Four Of A Kind","Royal Flush"};

	 public Deck()	 {

		 deck = new Card[ NUMBER_OF_CARDS ];

		 for ( int count = 0; count < deck.length; count++ ) {

			 	deck[ count ] = new Card( count%13, count / 13 );
		 	}
	 }

	 public void shuffle() {

		 for(int first = 0; first < deck.length; first++) {

			 int second = randomNumbers.nextInt(NUMBER_OF_CARDS);

			 Card temp = deck[first]; deck[first] = deck[second];

			 deck[second] = temp;
			 }
	 	}

	 public void dealHand() {
		 for(int i = 0;i<5;i++) {

			 handPlayer.setHand(i,deck[currentCard++]);
		 	}
	 	}

	 public void playPoker() {
		 	shuffle();
		 	dealHand();
		System.out.println("Your hand is:");
				handPlayer.printHand();
		Scanner input = new Scanner(System.in);
		System.out.println("Specify number of cards you want to change");
			int choice = input.nextInt();
				if(choice == 5) {
					for(int i=0;i<5;i++) {
						changeHand(i);
						}
					}
				else if(choice != 0) {
					for(int i=choice; i>0;i--) {

						System.out.println("Enter the position of card you want change");
						changeHand(input.nextInt());
						}
					}
				System.out.printf("Your Result is : %s",CardOrder[handPlayer.score()]);
				System.out.println();
				System.out.println("Your hand is:");
				handPlayer.printHand();
				}
	 public void changeHand(int cardIndex) {
		 handPlayer.setHand(cardIndex,deck[currentCard++]);
		 }
	 }

-------------------------------------------
import java.util.Arrays;

public class Hand {

    private Card[] hand = new Card[5];
    private int count = 0;
    private static final int ROYAL_FLUSH = 8;
    private static final int FOUR_OF_A_KIND = 7;
    private static final int FULL_HOUSE = 6;
    private static final int FLUSH = 5;
    private static final int STRAIGHT = 4;
    private static final int THREE_OF_A_KIND = 3;
    private static final int TWO_PAIRS = 2;
    private static final int ONE_PAIR = 1;
    private static final int NO_PAIR = 0;
    public void setHand(int number,Card dealtCard) {

     hand[number] = dealtCard;

     count++;
        }
      public Card getCard(int number)
      	{
       return hand[number];
                }
       public void sortHand()
       {
           Arrays.sort(hand);
                }
                public void printHand()
                {
                                for(int i=0;i<5;i++)
                                {
                                                System.out.printf("%d.%s\n",i+1,hand[i]);
                                }
                }
                public int score()
                {
                                sortHand();
                                if(royalFlush())
                                                return ROYAL_FLUSH;
                                else if(fourOfaKind())
                                                return FOUR_OF_A_KIND;
                                else if(fullHouse())
                                                return FULL_HOUSE;
                                else if(flush())
                                                return FLUSH;
                                else if(straight())
                                                return STRAIGHT;
                                else if(threeOfaKind())
                                                return THREE_OF_A_KIND;
                                else if(twoPairs())
                                                return TWO_PAIRS;
                                else if(onePair())
                                                return ONE_PAIR;
                                else
                                                return NO_PAIR;
                }
                public boolean royalFlush()
                {
                                if(straight() && flush())
                                                return true;
                                else
                                                return false;
                }
                public boolean fullHouse()
                {
                                if(threeOfaKind())
                                {
                                                if(hand[3].getFace() == hand[4].getFace())
                                                                return true;
                                }
                                return false;
                }
                public boolean straight()
                {
                                for(int i=0;i<4;i++)
                                {
                                                if(!(hand[i].getFace() == hand[i+1].getFace() - 1));
                                                                return false;
                                }
                                return true;
                }
                public boolean flush()
                {
                                for(int i=0;i<4;i++)
                                {
                                                if(!(hand[i].getSuit() == hand[i+1].getSuit()))
                                                                return false;
                                }
                                return true;
                }
                public boolean fourOfaKind()
                {
                                if(threeOfaKind())
                                {
                                                if(hand[2].getFace() == hand[3].getFace())
                                                                return true;
                                                else if(hand[2].getFace() == hand[4].getFace())
                                                                {
                                                                                Card temp = hand[3];
                                                                                hand[3] = hand[4];
                                                                                hand[4] = temp;
                                                                                return true;
                                                                }
                                }
                                return false;
                }
                public boolean threeOfaKind()
                {
                                for(int i=0;i<3;i++)
                                {
                                                if(hand[i].getFace() == hand[i+2].getFace())
                                                {
                                                                for(int j=0;j<i;j++)
                                                                {
                                                                                Card temp = hand[j];
                                                                                hand[j] = hand[j+3];
                                                                                hand[j+3] = temp;
                                                                }
                                                                return true;
                                                }
                                }
                                return false;
                }
                public boolean twoPairs()
                {
                                int[] pair = {5,5};
                                int count = 0;
                                for(int i=0;i<4;i++)
                                {
                                                if(hand[i].getFace() == hand[i+1].getFace())
                                                {
                                                                pair[count] = i;
                                                                count++;
                                                }
                                }
                                if(count == 2)
                                {
                                                if(!(pair[0] == 0))
                                                {
                                                                Card temp = hand[0];
                                                                hand[0] = hand[2];
                                                                hand[2] = hand[4];
                                                                hand[4] = temp;
                                                }
                                                else
                                                {
                                                                if(!(pair[1] == 2))
                                                                {
                                                                                Card temp = hand[2];
                                                                                hand[2] = hand[4];
                                                                                hand[4] = temp;
                                                                }
                                                }
                                                return true;
                                }
                                return false;
                }
                public boolean onePair()
                {
                                for(int i=0;i<4;i++)
                                {
                                                if(hand[i].getFace() == hand[i+1].getFace())
                                                {
                                                                Card temp = hand[0];
                                                                hand[0] = hand[i];
                                                                hand[i] = temp;
                                                                temp = hand[1];
                                                                hand[1] = hand[i+1];
                                                                hand[i+1] = temp;
                                                                Arrays.sort(hand,2,4);
                                                                return true;
                                                }
                                }
                                return false;
                }
}

----------------------------------------

 public class Poker {
	 public static void main(String[] args) {
		 Deck myDeck = new Deck();
		 myDeck.playPoker();
	 }
 }


Ah, it seems the "txlock" parameter to the opening URL is actually a go-sqlite3 feature (https://github.com/mattn/go-sqlite3/blob/master/sqlite3_test.go#L64). My bad. I can revert to using the URL thing if you prefer it, but it should make no functional difference.


aaa


example


I thought we could just use String.compareTo and String.equals methods since what we want is comparing String speciesName and String class already implemented these methods.


Should be more verbose on issues here; possibly combined with a -v/--verbose switch


This should work in 73 but please do not propagate it to 74 and later: I now moved away from creating all possible maps in the cfg as done in autoMagneticFieldProducer_cfi (which is still there but I'd like to deprecate and eventually remove).
PS: also note that autoMagneticFieldProducer only handles run I maps. It is technically not possible to have it working with run 2 maps (which is the reason of the changes I pushed in 74 and 75). However, given the difference is minimal, I don't think this is a problem for the data being taken now with 73.


Nit: Please remove this newline.


Надо придумать, куда тебе его выкладывать..


https://jsfiddle.net/ можно сюда


Indentation error. Missing one whitespace.


@sergeyklay Thanks!
I will `rebase`


Auto-Generation notes/comments should include date/time they were created.


Should be more verbose on -v/--verbose switch


You could introduce an additional variable to denote the triangle's bottom side (its width). bottomWidth = fieldSize/2
You could introduce a variable to denote the padding = (fieldSize - bottomWidth)/2
You could also introduce a variable for the offset = plotRegion_.x() + index * fieldSize
Then you can work with these and the code becomes:
QPointF midPoint = {offset + fieldSize / 2, ...};
QPointF leftPoint = {offset + padding, ...};
QPointF rightPoint = {offset+padding+bottomWidth, ...};

And that's super easy to read. Also, any decent compiler will generate identical code even though you introduced a bunch of extra variables. Readability is more important. You may also consider naming stuff in the height properly.

Having done all of this, it might even make sense to have a local lambda that does this. A good compiler will still optimize it away:
auto triangle = [] (QPoint offset, int baseWidth, int height) { ... return PolyGonF(...) }
and then just call it directly in painter->drawPolygon(triangle(offset, fieldSize/2, height));


строит норм, но выделение что-то не сработало


Why this duplication of code up to here? Could be generalized to super-class.


Thanks!


navitop1 a〜navitop7 aの
height
text-indent
display
は共通なので、この書き方だと勿体ない

```
.navitop1 a, .navitop2 a, .navitop3 a, .navitop4 a, .navitop5 a, .navitop6 a, .navitop7 a{
  display: block;
  height: 112px;
  text-indent: -9999px;
}
.navitop1 a {
  width: 40px;
  background: url("assets/images/img-navitop1.gif") no-repeat 0 0;
}
・・・
.navitop7 a {
  width: 61px;
  background: url("assets/images/img-navitop7.gif") no-repeat 0 0;
}
```
って感じかな


We listen to Intents intended to be send to the official Pebble App, that is why I call this "Pebble Messages".
Conversations does this, so we can intercept these and forward them to our devices (including Mi Band), so you should get them.
I know the explanation is bad, maybe you have a better idea?

And - I plan to report to report this to Conversations as a security hazard. We and everybody else can intercept all incoming chat messages without even requesting any permissions.
If they react I have to scrap this feature anyway and switch back to intercepting generic notifications for Conversations.
They could also restrict the Intent to the official Pebble App and resend it for Gadgetbridge, I doubt they will do, but lets see.


cname for sun-moon.xyz


Might be advantageous to provide the unfortunate reviewer with some /documentation/ of the stuff to expect in the buffer afterwards. Makes the job easier.


Do we want this one here?


Hi @tpietzsch

I rewrote the code little bit in order to support headless mode. The problem is which parameters should necessarily given by users and which are not.

That is why the method name is still ```defaultProcess()``` (with minimal parameters).
Could you guide me little bit more to get the most useful user given parameter sets?
Then, I will make the command option handlers like what you did in BigDataServer.

Thanks,
HongKee


全体的に書き方を統一しましょう。
例えば
color: #F00;
コロンの後に必ず半角スペースを入れる


For the next time I suggest to use plone.api show_message helper, see:
 - http://docs.plone.org/external/plone.api/docs/api/portal.html#plone.api.portal.show_message

In any case your work is really good!


Ouch this was really badly implemented, it should be an enum! Would you change it to avoid further mistakes? Thanks!


Possible XSS using malformed TLD in community files.


Suggestion : Collections.shuffle(list); this will shuffle the card~


TeamCity Selenium POM :: CI [Build 5](http://server:8111/viewLog.html?buildId=66&buildTypeId=SeleniumPom_Ci) is now running


I think you forgot to add Game<Card>.


TeamCity Selenium POM :: CI [Build 5](http://server:8111/viewLog.html?buildId=66&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:00:34


TeamCity Selenium POM :: CI [Build 6](http://server:8111/viewLog.html?buildId=67&buildTypeId=SeleniumPom_Ci) is now running


Looks kinda sane. Notes attached above. Possible XSS using malformed IP addresses in community data files.


it's better to use `Hash.fetch(arg)` instead of `Hash[arg]`, general practice :)


TeamCity Selenium POM :: CI [Build 6](http://server:8111/viewLog.html?buildId=67&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:00:34


Except for the schema location of AIXM 5.1, it looks ok. However, it did not check if the feature is complete, I trust you here (and we won't change the PDF anyway for brevity's sake).


Just to say it again, there **must not** be a subfolder for traits. You would not create a subfolder for interfaces or abstract classes.


Your game is amazing!!!!


Could you point me to the line?


This feature might be useful, but you have now removed the possibility to check whether this Mson itself explicityly has bold set. According to Java development standards getters and setters usually refer to the field in the object itself. If you want to calculate using inheritance you should create sepparate getters and setters for that.

```Java
setBold(boolean bold)
isBold()
isBoldInherited()
```


```
 margin-left:25px;
 color:#FFF;
 margin-bottom:5px;
```
↓
```
 color:#FFF;
 margin: 0 0 5px 25px;
```


Thanks @ale-rt, I'll do that from now on, I wasn't aware that plone.api has an API for showing status messages.


TeamCity Selenium POM :: CI [Build 7](https://teamcity.sponte.uk/viewLog.html?buildId=68&buildTypeId=SeleniumPom_Ci) is now running


Will do when I can verify that your suggested .click works.


The previous version is way better...

In case this happens again I suggest those three alternatives, which IMHO look better

1. put a # noqa at the end

2. split the line in two:
```python
msg = _("Your changes have been saved")
IStatusMessage(self.request).add(msg)
```

3. another solution with three lines:
```python
IStatusMessage(self.request).add(
    _("Your changes have been saved")
)
```

Just my 2c.


TeamCity Selenium POM :: CI [Build 7](https://teamcity.sponte.uk/viewLog.html?buildId=68&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:00:33


TeamCity Selenium POM :: CI [Build 8](https://teamcity.sponte.uk/viewLog.html?buildId=69&buildTypeId=SeleniumPom_Ci) is now running


You are welcome!


编译原理，词法分析程序


I would recommend having this function return false for both scenarios:
1. The tracker item does not exist
2. If the tracker item does exist, but the encounter has not been set


TeamCity Selenium POM :: CI [Build 8](https://teamcity.sponte.uk/viewLog.html?buildId=69&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:00:33


The setters of primitives should probably be primitives just like the getters.
```java
public Mson setBold(boolean bold) { this.bold = (bold != null && bold == true ? true : null); }
```


@Furrydaus it's ok for huashan ?


Missing a space after ;


The changes in jboss client dependencies seem to be causing arquillian to hang when waiting for jboss to shutdown (in surefirebooter):

    "main" prio=10 tid=0x00007f3478009000 nid=0x653e in Object.wait() [0x00007f348023a000]
       java.lang.Thread.State: WAITING (on object monitor)
        at java.lang.Object.wait(Native Method)
        at java.lang.Object.wait(Object.java:503)
        at org.jboss.remoting3.spi.AbstractHandleableCloseable.close(AbstractHandleableCloseable.java:177)
        - locked <0x00000000c2a787a0> (a java.lang.Object)


TeamCity Selenium POM :: CI [Build 9](https://teamcity.sponte.uk/viewLog.html?buildId=70&buildTypeId=SeleniumPom_Ci) is now running


TeamCity Selenium POM :: CI [Build 9](https://teamcity.sponte.uk/viewLog.html?buildId=70&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:00:34


TeamCity Selenium POM :: CI [Build 10](https://teamcity.sponte.uk/viewLog.html?buildId=71&buildTypeId=SeleniumPom_Ci) is now running


If there is no space above the while loop you should probably not have space under it for the sake of indent style symmetry.


TeamCity Selenium POM :: CI [Build 10](https://teamcity.sponte.uk/viewLog.html?buildId=71&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 34 Build time: 00:00:32


@jfarcand maybe we should start to encourage the user upgrade the JDK version. In a case like that we could log the exception in DEBUG or even INFO level, what do you think?


You could also create a new method called `getExtraCreative` which creates the list if it not exists before returning.


It is line 2560, the only other "-L" in the file.


@duncanpMS it is better to rebase before pushing, to keep a linear history on GitHub and have a linear history.


As an alternative to doing it this way, could we not create a new parent and return that one? I would like the possibillity to add siblings to a root Mson in which case a new root would be created.


getParentCreative?


After that there is no needs to that IF btw.
(two block are equals).

And btw push patchs to wordpress trac svn. This is just a compy of svn.


This one should be public.


This one should also be public :smile_cat:


:+1: zasluženo


To avoid bugs, collect the entry from openemr_postcalendar_event via the eid and then use the information for all the parameters.


Au clic sur la notification, on ouvre l'activity des animations en journée, @remipichon vois-tu comment ouvrir une animation en particulier ?
Idem pour les concerts ?


Je voudrais meirjé les deux branches gh-pages mais je n'y arrive pas...


@gsouvik

Look at these to logs debug stuff:

\Library\Core\Utility\Logger::PrintOutLogs($var_array);
\Library\Utility\DebugHelper::LogAsHtmlComment($var_string);

Or consider using NetBeans to be able to use Xdebug debugger which will be more handy than logging vars. Let me know if you need help.


TeamCity Selenium POM :: CI [Build 11](https://teamcity.sponte.uk/viewLog.html?buildId=72&buildTypeId=SeleniumPom_Ci) is now running


Yeah! This should work! :+1:


TeamCity Selenium POM :: CI [Build 11](https://teamcity.sponte.uk/viewLog.html?buildId=72&buildTypeId=SeleniumPom_Ci) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 33 Build time: 00:00:40
### Failed tests
```
uk.sponte.automation.seleniumpom.tests.ui.PageTest.timesOutWhileWaitingForElementToBecomeVisible: <no details avaliable>

```


I think I had that at certain point (`__pathify` calling `__escape`), but it broke certain APIs and values... I know it looks a bit silly e.g. in the code you point to, but I like the explicitness somehow...


Could you update this section with a few extra examples, please?


Wo ich das grade sehe - evtl. bei beiden Fassungen "Vorherbestimmt" anstatt "vorgegeben"? Irgendwie klingt das nach "Plansoll erfüllen".


have for huashan :P ?


Just don't use this fucked function in your fucked production. It's not require.
Not sure that SCAN will be faster then KEYS in this case.


I think we will have to mimic a few String functions and make them work with Mson. There are some methods we commonly use such as "split" and "replace" and "format". We will have to recreate Mson compatible versions of those! Maybe you could start creating some of those?


https://www.sqlite.org/lang_datefunc.html -> има функции за тях, която би трябвало да работят. Даже май можем да ги сортираме по стринг. Доста мислих по ?са, но смятам, че в стринг засега ще ни е добре


just FYI, this is also possible in ruby ;-)
```
when 'Group', 'InstitutionalGroup'
  Presenters::Groups::GroupIndex.new(value)
```


Hi, @tpietzch

If you want Fiji to handle *.bdv file by clicking the file, we need to put this code in fiji/IO.
How do you think?
Currently, bdv file contains "http://*" convention. You can extend whatever we decide.

Have a look on it and decide.

Cheers,
HongKee

p.s) After this change, we have to configure in MacOSX with the snippet which I sent you before.


Wrong commit message...Should have been 'Fixed a menu bug'.


You can see that it is in the source code of the master branch:

https://github.com/mautic/mautic-wordpress/blob/master/wpmautic.php#L56

I'm not a CSS expert, but `display: flex;` does not hide an element from web page if I understand documentation correctly https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Flexible_boxes

1. Could you check it is also in the source code of plugin you are using?
2. Could you send me the link to web page where the pixel makes the problem?


ошибка


a thousand apologies

Best
Steve

____________________
*Steven Bernard*
Interactive Design Editor
Interactive

+44 (0) - *207 873 4536*
Number One Southwark Bridge, London, SE1 9HL

<https://www.facebook.com/financialtimes> <https://twitter.com/FT>
<http://www.linkedin.com/company/financial-times>
<https://plus.google.com/+FinancialTimes/posts>
<http://www.youtube.com/user/FinancialTimesVideos>

On 8 May 2015 at 08:36, Luke Kavanagh <notifications@github.com> wrote:

> Lint!!!
>
> /cc @sdbernard lint your code!!!
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ft-interactive/ge15/commit/3b371d154855fac4a443d2d8522387429f882277
>

--

------------------------------
This email was sent by a company owned by Pearson plc, registered office at
80 Strand, London WC2R 0RL.  Registered in England and Wales with company
number 53723.


hello @dhague! I like what you proposed. I recently contributed as well to fog to support authentication v3 on network and compute. I think your code make more sense than what it was.

My focus was to support domain for user and project. I'm wondering if your code keep that logic: support those 2 differents domains?
this is the context of our current openstack implementation.

I was not able to read your code to confirm that. could you clarify how you take care of that in your code?


Interesting.


first update


The following should work and would be more rubyish
```
    case value.class
        when Person
```


Ja ja ja :)


Excellent, thanks!


@jfarcand I think you want to use && instead of || in that condition :-)


To keep backwards compatibility, we could also add a version check and for use the old find_package(VTK) for vtk5 and the component selection for VTK_MAJOR_VERSION GREATER 5.
See 852591d3aa1542baf247d464638ed68734c81f23


I'm curious to know if this could be related into https://github.com/kikonen/ngannotate-rails/issues/21


@tvsonar We shouldn't update rule parameter keys (see Fabrice's email "Changing rule parameters should be avoided")


Módulo que implementa la segunda de las funcionalidades pedidas en este TP 1 de Base de datos. Ya fue testeado con varios datos de prueba.


/evap/templates/base.html can't be found. when not being logged in, the page throws an ```TemplateDoesNotExist``` error. please have a look.


step by step


I would change the setting to ```Support 8 channel DTS HD audio``` to ```Enable 8 channel DTS HD audio (CPU) decoding``` this way, we can also easily enable it for platforms that support DTS-HD but have issues with other things (e.g. maintaining a video clock) like IMX hardware.

Then it also should get a dependecy vs. DTS-HD option in Audio -> System -> Settings

What do you think?


It is a new hack. Actually it is a very old hack that was always on, it is a bad idea because it breaks some gmes (hack help god of war).


Yes I think that makes sense.


test


this is a test


Would be nice, but does not work in this case. I don't know why...


which is good


so nice tool


From my understanding data flow analysis is really about analysis between assignments and read accesses to variables in a control flow agnostic way.

What we are doing is ControlFlow + DataFlow, so Symbolic Execution is currently the only accurate name that comes to my mind.


@zarquon42b @marcelluethi It looks good to me, but we should test for vtk5, vtk 6.0, vtk 6.1, vtk 6.2 and vtk master :-/
It would be great if dev test at least on their systems and report first any trouble with this change


好的，确实好轻量，其他的百度，jiathis等一大坨太烦了，自定义起来也没你这个方便


Oops this is definitely a bug. It comes about because we use btrfs' lineage information when we do replication. Fortunately this bug shouldn't be exposed to users right now because we haven't exposed deleting intermediate commits. Nice catch, I'll open an issue for it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14696/testReport/) for this commit**


/*
psudocode: http://www.cs.rmit.edu.au/online/blackboard/chapter/05/documents/contribute/chapter/05/linear-probing.html
Calculate the hash code for the given target key
Access the hash element
If the hash element is empty, the deletion has immediately failed.
Otherwise, check for a match between the target and data key
	If there is a match, delete the hash element (and set the flag)
	If there is no match, probe the table until either:
	An match is found between the target key and the data's key; the data can be deleted, and the deleted flag set.
	A completely empty hash element is found
*/


Just for future reference: we prefer to store patches locally to avoid the internet problems :)


May I know why delete the promise chan ?


@tvsonar Rule key parameters shouldn't be changed


Extra line?


(No - fine)


The forum link http://www.yiiframework.com/forum/index.php/forum/42-design-discussions-for-yii-20/ does not exist.
Redirects to http://www.yiiframework.com/forum/index.php/forum/42-general-discussions-for-yii-20/


Stream not closed


a konstruktor megváltozott, mivel az engine-nek is van egy kötelező paramétere
`<addr>`function Car(brand, model, performance)
-re


Stream never closed.


logar in spanish means : alquilar http://buscon.rae.es/drae/srv/search?val=logar


Loggers must be static


Corrected index in for loop, "X509Store.cs" line 128 from always zero to "i".


Removal of the line does fail the test, as there is no test case. If executed this should definitely happen before the update.

Also if you omit break/return/throw you know the condition is false when leaving the loop.


todo adding fiile in transifex and ctransifex for lang package
i will do it on monday
(new field and new module)


The 60 seconds thing only affects debug builds - it is because I created a
pool of random numbers, which is super fast on non-debug runs but slows
down debug runs. I will check in a fix shortly that makes the pool
extremely small in non-cuda runs.

I don't see a bug with the functionality itself, a reason for memory
overflow etc. - not denying that there is one just not seeing it - will
check it out tomorrow again.

On Thu, May 7, 2015 at 11:33 PM, Barak Raveh <barak.raveh@gmail.com> wrote:

> hmm I'm not sure I get that myself - I will check out if something is
> different in my repository
>
> On Thu, May 7, 2015 at 11:06 PM, Ben Webb <notifications@github.com>
> wrote:
>
>> You're planning to fix this broken patch, right? Looks like just creating
>> an IMP.atom.BrownianDynamics object now takes up to 60 seconds, far longer
>> than the simulation itself (see for example
>> http://integrativemodeling.org/nightly/results/?comp=21&plat=4 ; same
>> with atom tests, atom examples, and rmf examples, all of which use BD) and
>> in the process overwrites something somewhere in memory causing random
>> problems (in that case, particle attributes get randomly erased). If not, I
>> can revert it until you figure out what the problem is.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/salilab/imp/commit/8d77b01ec2ec5ce2dad618db0cfd0f13db65ee9d#commitcomment-11101408>
>> .
>>
>
>
>
> --
> Barak
>

--
Barak


The SPARQL update will be updated in the development branch, which will be merged into the master branch yes.


Got it...I pointed out it actually, but I didn't change 12 by mistake - It's still a bit confusing that bits for different types are on different positions, so I took 12 as a maximum possible =)
I will delete it


Oh yeah duhh, otherwise it sets the max size to 1. That's interesting...


There's been a recent push to get rid of capitalized first letters in strings, so could you change this to "Search guide for:"


Will add


s/Guide/guide/


s/Title/title/


s/Time/time/


Same here


rip linux


@JackTheHack, thank you for reporting the issue and sending the PR.

In order to be sure that the suggested change fixes the issue and does not break any other functionality it should be 'reinforced' by a [test](https://github.com/sergeyshushlyapin/Sitecore.FakeDb/issues/48). Could you please create one?


Personally, I can't think of any.


Could https://github.com/ksooo/xbmc/commit/14605f2a0605401c6559f9e807d9ab31b2b12312#diff-1662af1d5461440bf3871a2e8d053e10R3388 be reused somehow?


delete centos.bin , so it big.


s/Add-ons/add-ons/


it probably doesn't make a lot of sense to test this, as functionality was removed and not added. otherwise you could probably expect more things to not happen to the json.


![qq 20150508161625](https://cloud.githubusercontent.com/assets/11162054/7532794/ba9c21ae-f59d-11e4-99fc-afb7b5b5a035.png)


Ah! I actually updated this, but forgot to commit it. Wonderful...


Kinda of identificator? =) What is the more appropriate word for it?


I know that there are plenty of RAF libs out there :D but I did not find one that would return the actual methods yet. But the one from kof seams cool. Lets use that one, until I'm done with mine ;)


I suppose this should really be `const PVR_TIMER_TYPES *GetTimerTypes(void) const`.


I think you forgot to add something :-)


Why Write such a comment?


How about `fill_array_error`


Just Like That.


Good point.


Yep.


How about trying `np.add()`, `np.multiply()`, `np.subtract()` instead of `+`, `*` and `-`?  That might be quicker?


I don't like the "aware" thing. What about simply `BufferTrait`?


How about trying `np.add()`, `np.multiply()`, `np.subtract()` instead of `+`, `*` and `-`? That might be quicker?


That would work too. But it's `ContainerAware` because the container is known to the class…


What is this for?


I used the same flags for global tags as for the workspace ones - I don't quite understand why they were different.


I mean the RML job: doesn't this introduce a new dependency on Java + the RML processor?


@tvsonar Can the paramter list be null?


>...Az autó és a motor brand adattagja vegye fel ugyanazokat az értékeket
```javascript
function Engine(brand, performance)
```
mert a brand se lehet más mint az autógyártó
>...Az Engine **összes adattagja legyen kitöltve**, a számértékekhez használhatod a korábban megírt randInt >függvényemet.
nem is ebbe akartam belekötni hanem:
Carban:
```javascript
this.engine = new Engine(this.brand, performance);
``` és így szépen megkapja a brandet. Amúgy ez faszság, egyes kocsikba nem brand gyárt hanem motorgyártó cég, me sok márka ugyanabból a szaros cégből kapja a mocit

Motor:
```javascript
...
if (isFinite(performance) == false || performance < 1) {
       throw new performanceException(performance);
...
```
és az exception:
```javascript
function performanceException(perf) {
    this.perf = perf;
    this.message = " :ez nem felel meg a nem szám és nem negatív szabálynak";
    this.toString = function() {
        return this.perf + this.message;
    };
}
```
Hosszú komment miatt itt egy kacsatár:
![alt text](http://vignette2.wikia.nocookie.net/spsot/images/6/68/Ic_unlock_cpm_fatdactyl.png/revision/latest?cb=20150112020503 " Kacsatár")


I fear we are now starting to marry ourselves to the Bash semantics of `read`... http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html does not list the `-s` option as required by the POSIX standard.

For background, I wanted to run tests with the `dash` instead of `bash` to see whether it is faster (which I expect it to be). Now, we *might* be able to patch in support for the `-s` option (according to my dash documentation, it only supports `-r` and `-p <prompt` options for the `read` command), but it is still a concern.

Don't get me wrong, I will accept this commit, in particular because I kinda don't want to break compatibility with MSys1 until it becomes too much of a burden, but I would like to ask you to include the information about `-s` not being part of the POSIX standard and `dash` indeed not supporting it into the commit message. This is really important information.


It seems you are right, because there is also a [ContainerAwareTrait](https://github.com/symfony/DependencyInjection/blob/master/ContainerAwareTrait.php) in Symfony. However, it only adds the setter and not a getter?


@tvsonar can the type parameter list be null?


@tvsonar Can this condition ever be true?


no_definitions is always FALSE so we can skip this part (the "no_definitions" name doesn't make sense to me - it's basically used to restrict the searches to a single file).


Learned how to use devices, and plot using R. Was quite fun!


Looks good.


Hmm, if you're strict on managing changes, then yes, avoid it. Perhaps this commit was to fix a typo in the README :)


the closest thing I can find is this: https://github.com/MinecraftForge/FML/blob/master/src/main/java/net/minecraftforge/fml/relauncher/ReflectionHelper.java#L167 ..is this what you are talking about? please just send me in the right direction..the method you speak of would be perfect for what I'm trying to do and thx for pointing this out


I just used TM_PARSER_JAVA at appropriate places, hope it's alright.


I used background image because it allows an easier control of the image position. I don't know what's going to be the size of the picture and the properties img properties max-width and max-height are not enough to get the picture vertically in the center as well.


Even the [PSR logger](https://github.com/php-fig/log/blob/master/Psr/Log/LoggerAwareTrait.php) only contains a setter method. Is it uncommon to have a getter method as well?


This is the part I'm referring to in the commit message - if more than 1 tags are found, the function returns which is wrong.


not good for people who do standalone cross builds. CMAKE_INSTALL_PREFIX should never be used in includedirs.  CMAKE_STAGING_PREFIX or something else should be used instead.


I think this just reversed one of the pull requests you merged. :)


Removal of this line does not fail the test.

I wonder why it is required for else state but not for then state. Same question applies for visitIf, since this is probably based on the implementation of the latter.


Meg is szoptam, `betrow`-olt


This isn't necessary now because the loop is guaranteed to terminate.


      First all started installation intellij idea, configure java, and junit programs in test I just put dependency
  on case files and I have wrote test with java program and I have install  on webdriver. Nil test file. I use
  firefox as a webdriver. To find with firefox navigate I have done with get command. To adding and deleting on favorites bar I have done with findelement command. To make find action on findelement I have done with Xpath command. To making waiting time between  and when Irun the program. It's was working and I succeeded.


törölve az összes!


We still test for this "xterm" part of `TERM`. And for a reason: I really want to *limit* our dependence on a shell. Granted, with MinTTY we have no other choice. But some developers might be comfortable with skipping all functionality provided by Perl/Shell scripts in Git and come up with a minimal Git distribution that essentially has only the binaries. I know we are a *long* way from there, but that is where I would like to be eventually, and the direction this patch is going is the other direction...

Don't get me wrong, I will accept this Pull Request, but I would be more comfortable keeping the xterm-specific stuff separate from the pure Win32 API solution we have in `compat/terminal.c`, and I would really like to make a point of clarifying that the shelling-out is an undesirable if necessary workaround.


Why?


@bagder @captain-caveman2k Is anybody explain to me if argc == 1, but we check not from 0, but non existing pointer, what it will be? Is it normal?
Now on windows I've got exception if I run curl without arguments, because in call helpf(config->errors, NULL) function with both arguments called, while config->errors should point to FILE handle
![image](https://cloud.githubusercontent.com/assets/142123/7532918/14fccdd4-f575-11e4-9ca9-6f36bad6f7ea.png)


I use always copy so I could eliminate this.


Performance lag. We need to save small image previews after POST using https://cloud.google.com/appengine/docs/python/images/


@tvsonar I don't see this as being a very elegant (nor very efficient) way of finding all references to the type parameter `T` across partial classes - Can you fire an email to the Roslyn team regarding this?


Good point. Will change this


Sorry, we cannot do that. As you can see [here](https://github.com/git-for-windows/git/blob/438f3e75d1f372aa683a7febbdb4c92ac5c743b2/config.mak.uname#L36), Git for Windows is not the only user of `compat/terminal.c`. Please back this commit out of the Pull Request.


Used also in scoped search now so factored out as a separate function.


a conténerbe
```javascript
throw new notCarException(arguments[i]);
```
EKSZCEPTÍÓN
```javascript
function notCarException(obj) {
    this.obj = obj;
    this.message = " :ez nem Vehicle típusú ojjektum";
    this.toString = function() {
        return this.obj.constructor.name + this.message;
    };
}
```


iotAgent.cpp - Windows char endings - urgh! Not sure what git client you're using but git cli should know better!


just add a zhushi


Okay. I would have preferred this change in a separate Pull Request, though, because this is all of a sudden about the Git wrapper, while we previously were exclusively concerned with `compat/terminal.c`...


No. The trailing colon there is essential, as it is a label for a setting in timer settings dialog.


@montegoulding : thanks for spotting this. Fixed in https://github.com/runrev/livecode/pull/2260


I think there are no getters because it does not make sense in this case (getting container from a class would be wrong). But it's totally fine for me, and there are examples if you google a bit (e.g. https://laracasts.com/discuss/channels/general-discussion/getter-setter-trait-package-proposal-not-laravel-specific).

There are also examples in Symfony (e.g. https://github.com/symfony/symfony/blob/7c026bb33e8ca96b285402f7fe7ae27a04a74ea9/src/Symfony/Bundle/FrameworkBundle/Command/ContainerAwareCommand.php, https://github.com/symfony/symfony/blob/d94d837e9ea75d76eeb0a43e0535a5e7a7a01542/src/Symfony/Component/Translation/MetadataAwareInterface.php).

They also use *Aware* if a class knows about and does something about another class (e.g. https://github.com/symfony/symfony/blob/b009902f906b35f81fe4ea17b708b26d5b6463fc/src/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.php)


Sure, I'll do that.


2 Relationships added


TeamCity .NET :: NET - Redis4Net :: Continuous integration build [Build 0.5.0-DEV9](https://teamcity.coolblue.eu/teamcity/viewLog.html?buildId=233015&buildTypeId=Net_NetRedis4Net_BuildAndPublishPackage) is now running


TeamCity .NET :: NET - Redis4Net :: Continuous integration build [Build 0.5.0-DEV9](https://teamcity.coolblue.eu/teamcity/viewLog.html?buildId=233015&buildTypeId=Net_NetRedis4Net_BuildAndPublishPackage) outcome was **FAILURE**
Summary: Compilation error: src\redis4net\redis4net.csproj Build time: 0:0:51


Yes. sometimes, they failed to hit not moving enemies ^^


Changed in a669a1962118ca4d06118c8fa4fc1fba6bf36355 then.


Plugin java is already applied - see top of gradle file..


I use this gem in a Rails4 app deployed to sub-uri. I found `image_path` cannot generate correct asset path, but `asset_path` can. So in current workaround, I have to override default `swfPath` with `<%= asset_path 'ZeroClipboard.swf' %>` when using ZeroClipboard.


噢噢噢


yep. I think we should use helper as much as we can. An dprobably add something to display vector in the helper as well


> I pushed a commit that adds the include, this builds without issues
here.

I builds for me now as well. I don't know what happened before.


comment on commit


We should stop using null in top-level like that, see this discussion for a similar event: https://github.com/NixOS/nixpkgs/commit/4933a342797c8a18e2794eac28917842987ad71d reverted in 6cd99a4eb266d3857f3b7506df28d7859a2c2f6c . Null just breaks things unexpectedly. Use platforms, make it optional in the package needing it or whatever else.


You refer to issue #47 in your commit message, but it is actually actually the issue #41.

We will have to modify your branch before it can be integrated.


In general, np.

Not sure about "Guide" as I thought this is a proper noun/ proper name. ???


Yep. That's a good decoupling IMHO


try latest code


WTF


You are correct, I removed that.


first commit sort test


Build fail here: https://travis-ci.org/YOURLS/YOURLS-unit-tests/jobs/61542872#L117


Like


i guess thie bump from here:

https://github.com/wsnipex/xbmc/commit/d6f0143cb7a8dd293e0a1f87eff8b971a034b657

needs to be reflected in the cmake buildsys too for making the addons build trigger work wirght? ^^


Actually, I removed that in one of the following commits.


Not really. When a building is built, the tile is automatically claimed. But it is nicer to claim it here from the start


shouldnt this kind of thing be in the AAF deployment repo?


Juste par curiosité, quel est le but de ces fonctions ?


Proxyeinstellungen einbauen, damit er auch in speziell abgesicherten Netzwerken den DFN aufrufen kann.


Turns out this change wasn't even necessary, it was caused by me not understanding the settings test setup. Now that the blacklist uses the proper index (`government_test`) this line also works. Amended commit with a comment and a explanatory variable.


хорошо


I don't remember the name but there is a condition that does this. I think it's `stalenessOf`.


Doesn't change the numbers though


Should only every be `.one()`, no?


That looks like a factory design pattern. Actually, it is heavily inspired from OD code in the old AI factory.
I've not called it factory because it makes a bit more than just creating objects. But it is very close...


補充
主要 commit 內容為
新增 購物車訂單搜尋


Hm, I'm honestly not sure! I've been deploying to AWS with Capistrano. The `NoMethodError` looks very similar to the one that I was working around, however; would you like me to submit a pull request?


Wow, it looks good. Thanks for the optimizations, I'm actually learning some things. I didn't think about using 'if ' ' in...', nice reminder! I'll finish looking over everything in the morning.


Fixed in https://github.com/mysociety/alaveteli/commit/d4471a4258575100f1318657cfb3feea4cb609f2


On a second thought the checks should be agnostic of the Syntax Tree, so this shouldn't be based on a BaseTreeVisitor.

At some point we need to define an API as part of the factorization effort.


This link is dead btw


Thanks for deleting my ticket, but then how fixing my mentioned bug. How about pull down your ego a little?


Why ecryptfs-utils is removed?


You don't need to convert the entire result to JSON here, just take the 'success' value:
```js
return item.result && !item.result.get( 'success' );
```


Same as above


yeah, but it redirects so it is not really a problem :)


I had missed Rooms::getRoomTypeFromRoomName so I had to change that afterwards. And seems like I took something not wanted ^^


- add a full stop (.) after the first "support"
- I would replace the second "support" with something like "help" or another word, so as not to repeat the same word twice :)


There's a discussion around that topic upstream, see
https://github.com/GoogleCloudPlatform/kubernetes/issues/4789.
I've created a PR with @pmorie's help to address that, see
https://github.com/GoogleCloudPlatform/kubernetes/issues/7908.
Generally the idea is that secrets should be visible only for the user
actually using them, from security point of view.
That's why I'd vote for leaving this as is and we'll can address further
issues with this down the road.

On Thu, May 7, 2015 at 7:31 PM, Clayton Coleman <notifications@github.com>
wrote:

> This is only due to ssh and git behavior. I'm not sure that by default
> other secret types have this issue, or necessarily we will want containers
> to run with 0600 for most of their secrets. The build code specifically is
> probably going to have to explicitly make this check for SSH/Git always.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/soltysh/origin/commit/fef3709e49d737c2b8bb6f76592d4fbc8457c478#commitcomment-11092289>
> .
>


Because initially, before implementing the Weather API, I was tweeting random contents, and this was my random content generator. As I left on the note, after implementing the weather API, it became useless.


@merciesa this is way over the current goal and scope of this implementation. As such this should probably not be part of this review.


@WebDevJL
Cool idea, but as I understand that makes it run for every controller/action possibility, immaterial of the fact if we need ellipsis feature or not for that action. This means for every action  PHP has to parse the entire file "tooltipandpopupstrings.en.xml" to get the settings for that action. I'm not sure how extensively we would be using ellipsis feature throughout the project and it was this thought due to which I kept it isolated for each action.


ActiveSupport added because we'll want convert `OrderCreated` string to `order_created`


The fun thing is that I wake up this morning and realize that my last commit was not pushed. It is exactly this  :D

Thanks for fixing my derp


question though, why are the sponsors of the rgsoc linked to, and not the rossconf sponsors? ;)
this is the right link -> http://www.rossconf.io/#sponsors
also if possible, replace "the space" with "sektor5" and add this link -> http://www.sektor5.at


Ideally we would instead use the contents of https://html.spec.whatwg.org/multipage/rendering.html#the-css-user-agent-style-sheet-and-presentational-hints.

However, I am a little worried about how different the spec seems to be from Blink. In general the spec has a lot of stuff that Blink doesn't... and a lot of the spec stuff looks crazy-complicated. So, maybe we should just go with Blink for now... But we should add a comment. Also we'll need a link to the source repo so people can update it later.


fixed. beff332


@morph3d А что с ним не так? у меня html работает нормально, в отличии от json'a который подключивает...


remove this sentence completely if possible, as it seems a little out of place


Love this bit, hihi *all the secrets*


ok i don't think about this. i will remove the version printing on the page footer


Great, thanks ! :)


I tried to check if the twitter instance had any mentions? or some similar method to check if the type of the tweet was mention, but i couldnt find one.
The user stream will also have the tweets one sends, so if I don't check for the existence of the twitter handler for a mention, it would create a loop of tweets.


Windows
Cygwin
固有名詞は適切に


system/extras/ext4_utils/make_ext4fs.c:76:17: fatal error: lz4.h: No such file or directory
 #include <lz4.h>
                 ^
compilation terminated.

And I didn't find any lz4.h file in my sources...


SQL


Hello, this fix is working only if at line 106, i have,
```
regstring = "([\\S]+(?:" + extensions + "))(?::([\\d]+)(?::([\\d]+))?)"
```

Otherwise linter is not showing error in header file.
![screen shot 2015-05-08 at 09 51 03](https://cloud.githubusercontent.com/assets/9337413/7533329/68dd0336-f568-11e4-98fb-5a7e5c83c797.png)

If I apply above fix have,
![screen shot 2015-05-08 at 09 53 33](https://cloud.githubusercontent.com/assets/9337413/7533324/5faa099e-f568-11e4-90a2-4a5c35b9b4d4.png)

The second is exactly what it should be. I imagine that you have tested this with gcc and PC and is working. I believe in my case is something work with breaking compiler output on lines.


This seems unnecessarily slow... creating a new empty list, copying the other one into it?

Instead, I'd suggest factoring out the `function (sheet) {` on line 259 into a separate function, then doing something like `thatFunction(defaultStyleSheet)`; `forEach.call(node._ownerDocument._styleSheets, thatFunction)`.


XAMPP


@gsouvik

Ideally, the file should be read once at application start and then the data store into an array where you would look up directly to the ellipsis data.

```
$fileContent = ReadContent();
$ellipsisData = $fileContent["tooltip_ellipsis"];
```

We do that for the routes. Only when the files is edited, we read the file again.


$server->first    = (count($output) === 0); // FIXME: Let backbone.js take care of this


Can you file a bug on cn-cbor with details, please?


Nah, here seems fine. However, we need to be able to work with any CWD, not just in the root jsdom one. Also, I prefer explicitness for the second parameter. So:

```js
fs.readFileSync(path.resolve(__dirname, "html.css"), { encoding: "utf-8" })
```


عربي


I know the rest of the tests in this file use jsdom.env, but you can just use jsdom.jsdom instead for a simpler test.


Yep, you are right. For both consistency's and functionality's sake I've added `-L` by default as well.


@tvsonar this complex logic is already contained in `IsArgumentMatchingAlgorithmName()` : It would probably be better to have a `bool TryGetAlgorithmName(ArgumentList args)` method


Can you add a couple tests specifically covering ttps://github.com/tmpvar/jsdom/issues/994? Both the OP and @Sebmaster's simplified one in https://github.com/tmpvar/jsdom/issues/994#issuecomment-69322867 ?


Please make a clean indentation.


@gsouvik

To add to the previous comment, we would have this also for the other data type:

```
$fileContent = ReadContent();
$toolTip["tooltip_ellipsis"] = $fileContent["tooltip_ellipsis"];
$toolTip["tooltip"] = $fileContent["tooltip"];
$toolTip["confirm"] = $fileContent["confirm"];
$toolTip["alert"] = $fileContent["alert"];
$toolTip["prompt"] = $fileContent["prompt"];
```


ok


I need ActiveSupport for 1 method...


Here seems fine. Definitely not inside Window; we can't do sync IO every time someone creates a Window.


I know it's just the test project, but should the company attribute still be `NOKIA`?


# noqa is evil. -1


Just wow :+1:


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14697/testReport/) for this commit**


Don't use 'using namespace' in header files. See C++ Coding Standards item 59. (and https://github.com/MP2P/MP2P/wiki/Coding-style)


Is this really a dispatcher? The session should be aware of calling a function, and not really care whether it's just a handler or a dispatcher.


This is definitely NOT a dispatcher.


about failed tests - everything works perfectly fine on piri but not on
int64a (fresh copies of repo). Will try to dig in for what the problem
might be, erratic nature doesn't make it easy.

On Thu, May 7, 2015 at 11:06 PM, Ben Webb <notifications@github.com> wrote:

> You're planning to fix this broken patch, right? Looks like just creating
> an IMP.atom.BrownianDynamics object now takes up to 60 seconds, far longer
> than the simulation itself (see for example
> http://integrativemodeling.org/nightly/results/?comp=21&plat=4 ; same
> with atom tests, atom examples, and rmf examples, all of which use BD) and
> in the process overwrites something somewhere in memory causing random
> problems (in that case, particle attributes get randomly erased). If not, I
> can revert it until you figure out what the problem is.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/salilab/imp/commit/8d77b01ec2ec5ce2dad618db0cfd0f13db65ee9d#commitcomment-11101408>
> .
>

--
Barak


@tvsonar having both a `FirstOrDefault()` and an `IndexOf()` seems quite complicated here - my feeling is that it should be possible to achieve the same just with the while loop.


Я решил сделать через символ и поэтому решил не создавать переменную, дабы не использовать ее только один раз.


OK, thanks for clarification!


I think this paragraph still needs a bit of work, can help out with this in the afternoon maybe. Anyway, I have just checked, and according to Katrina's email, there were 28 PRs from 9 different people at ROSSConf on Saturday, and 2 more PRs on Sunday. :)


Updated as per review comments.


:sparkles: great work @sareg0!


Yes it does, that's why I don't think this will get merged any time soon, maybe a fork is more relevant here?


OK, clearly cloning to a new directory and making sure the build works should be part of my workflow.


Or just always keep it in a separate branch which syncs with master? I don't like this approach too much, but the dependency is big for someone who's never going to use it. Right?


Если принт еще нужен, добавь комментарий `TODO: remove print`, ну или `FIXME: remove print`.


Стоит поудалять эти пустые строчки, мне кажется.


ok


I can't copy-paste your example in my terminal because you forgot the trailing \


It seems that even these solutions do not cover all cases.
```
In [1]: e = [Eq(diff(f(x), x), 2*f(x)),
   ...:      Eq(diff(g(x), x), f(x) + g(x))]

In [2]: s = dsolve(e)

In [3]: print(s)
[Eq(f(x), C2*exp(2*x)), Eq(g(x), C2*exp(2*x))]
```
I believe that three cases would be needed. For example, ``if b != 0: ... elif c != 0: ... else: ...``.


Ignore this. I changed the toolchains path


sorry, but I do believe I have been falsely tagged.  Although I would
love to take credit for OpenBSD patches.  Keep up the great work in any
case!

On 08.05.2015 09:07, Sebastian wrote:
> - opmsg: cherry-picked OpenBSD patches provided by @mikeburns
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/stealth/opmsg/commit/07641f2415c14fc924f3b60356be6252059da5b6


先ほど、↑の部分を修正し、コミットしました。
commit : f34eb673831f92ee614da8f712b9111cbbcadbaa


Are you sure, that this fix doesn't break existent wiki pages containing links like
[[http://www.bla|]] ?

I have lots of links like this in my wikies.


Make it read only if wants to prevent user from deleting link by mistake. Happens when they edit
link by mistake like pressing enter key , then only page reload can bring original permalink back.
This is what i did to handle that :
``` php
'message' => '<textarea readonly ...
```


Yeah, deleting the report but fixing the bug.


@lejoe nice catch :+1:


Thanks a lot.. Appreciate your valuable feedback.  This helped me a lot..

Regards,
Dev

On Thu, May 7, 2015 at 9:09 PM, jms30 <notifications@github.com> wrote:

> Hi debashis,
>
> You can just run any of the firewall applications (for example:
> inefficient_stateless_firewall.py) by passing the file as an argument to
> ryu-manager command.!!
>
> Write me back if you have any problem with the code.
>
> Regards,
> Jay
>
> On 7 May 2015 at 17:19, debashish216 <notifications@github.com> wrote:
>
> > Hello,
> > I am learning SDN and trying out the application features related to it.
> > I am able to understand this code. Could you please let me know how to
> run
> > this code. I have already ryu installed in my system and functional. Need
> > your help to know the steps for running this particular stateful
> firewall.
> >
> > Thank You !! Happy Learning !!
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/jms30/SDN_Firewall/commit/a7d09dc3e466c58fa1e9139bef368861f8bb24a1#commitcomment-11089523
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jms30/SDN_Firewall/commit/a7d09dc3e466c58fa1e9139bef368861f8bb24a1#commitcomment-11090045>
> .
>


Ok I will remove possibility to configure this option and just leave it as always enabled part of server


good


Have you looked at `#collection_select`?

http://apidock.com/rails/ActionView/Helpers/FormOptionsHelper/collection_select


yes. it has nothing to do with your existing links. this is a fix on the link wizard


I changed it in https://github.com/ginetta/Skeleton/commit/ddfb0d88932957e9ad69d2599af5aac9883375d0


I agree on this, it's better. But have you checked if the _originalFile is always set?

Maybe it should not, in case its the same as _file because of mem consumption considerations?


After further investigation: the functionality differs in a subtle way actually: the _txlock parameter will make all transactions be "BEGIN <mode> TRANSACTION", when the pragma will make the *connection* get an exclusive lock instead.

So the tradeoff is: the txlock parameter grabs and releases exclusive locks more often (every transaction), therefore the pragma is slightly faster, but it locks database-wide for longer (pretty much, for all of the daemon's life). Since I don't think it makes sense for other processes/threads to access the database directly in this particular case, I'd still vote for the PRAGMA option, but I'm happy to revert it to the txlock approach instead (this doesn't impact the functionality introduced in this branch).


If we drop zconf.h from git repository, win32/Makefile.msc will recreate it automatically... It won't break as long as nothing in zconf.h.in depends on configure.
zconf.h.cmakein is something that has to be dealt in completely different way... I need to read the cmake manuals if there is clean way to automatically create it from zconf.h.in like configure does...


dsada


что в максовом, что в твоем, выдает ошибку
https://github.com/Maxx53/SCMBot/issues/265
в его бинарнике такой проблемы нет.
джсон отлетает, если сканить больше 1 вкладки, это да


@hundasupa Yup, but since kvikmyndir.is has asked us nicely to stop scraping their site we've deprecated this endpoint. We are open for pull requests to scrape other sources of movie data and feel free to open up a issue! :dog:


nice flexbox snippet


omg I'm such a dork, I was a bit tired last night, and was just thinking RGSoC sponsors. I'll make sure to change that.


Aha, and how I should get that information? The school doesn't have it's whole life span. It could get calculated from the school  names  for example, but I'm not sure all those names have correct info.


Better leave everything as lowercase to be consistent:
```
"вы подключены к dropbox под именем / ящиком "
# or
"вы подключены к dropbox под именем "
```
Also, notice the trailing space.


Extraneous println.


I guess this is mainly the former `main.go` code. Would be easier to review if it was in its own "move code" commit.


It is removed in next commit.


@claydiffrient Here is what I did to prevent the button from showing up for teachers.


Will do once I figure out to send arguments to cmake to turn on optimalization.. (cmake newbee problems..)


_originalFile is always set (very early in SyncEngine::treewalkFile).

Setting _originalFile or not should not matter because the string data is shared: the member will always consume the size of a pointer regardless. We could possibly remove it, but I'd not do that for 1.8.2.


aa to mane samjanu nai.


e.g. `add_definitions ( -O )`


Gehört noch zu Beep bei Autopause


IMO, this should be shouldnt this be http://mirrors.xbmc.org/build-deps/sources/platform-1.0.6.tar.gz