First let me apologize for not getting to this sooner. I have written up some
general comments about the package as a whole, however I unfortunately do not
have the time to do a more detailed inspection right now.  I would suggest
fixing the below issues and then I can try to take another look.  These are also generally things which will need to be fixed if you were to submit your package to Bioconductor or CRAN, so they are definitely worth doing.

## Code Style

See http://www.bioconductor.org/developers/how-to/coding-style/ for
Bioconductor style recommendations.  Also another good resource is [Hadley
Wickham's Style Guide](http://r-pkgs.had.co.nz/style.html).

Regardless of what style you use I would recommend the following things to improve readability.

* Use spaces rather than tabs for indentation.  How many spaces is up to you, I
  prefer 2 for personal projects, Bioconductor's style recommendation is 4.
  That way you can ensure the indentation is consistent regardless of the
  tabwidth specified by the user.  Most editors have a setting which will
  automatically enter the number of spaces you specify when you hit tab.  I
  would also recommend enabling visible whitespace in your editor, there is an
  option to do so in every editor I am aware of (Including RStudio).
* I would recommend you always put spaces around all binary operators, failing
  to do so is like writingasentencewithoutputtingspacesbetweenwords.  You can
  read it, but it takes more effort.  I would also recommend always using
  whitespace after a comma for the same reason.
* It is often more readable to put each function argument on a new line when
  you have a large number of arguments.
* When you use anonymous functions you tend to put all the expressions on one
  line (separated by semicolons).  This makes is more difficult to read these
  often important steps.  I would treat these functions like you do any other
  function and put each expression on it's own line.
* There are a number of places you have old code commented out.  Unless these
  comments has an illustrative purpose they should be removed so they don't
  confuse the issue.

## Code Issues
* There is no need to qualify internal function calls with `:::`, just use the
  function name directly.
* Rather than using mclapply consider using BiocParallel which provides a
  common interface for multiple parallel backends (including multicore).
* I would not recommend using `rm()` and an explicit `gc()` call within a
  function.  Unless you are running very close to memory limits this will only
  serve to slow your code down.
* There are a number of errors from running R CMD check, many of which look
  like missing imports.  If you are using Rstudio you can run checks with
  `Build->Check Package`, with `devtools::check()` or run them on the command
  line with `R CMD check .`.  See <http://r-pkgs.had.co.nz/check.html> for a
  description of the checks and likely causes for the checks which fail.
* I would also install the BiocCheck package and run `R CMD BiocCheck` as well,
  which runs some additional checks for Bioconductor packages.  There are a
  fair number of warnings found using this is well.
* I would recommend writing some tests for your functions.  In this way
  you can ensure they are producing the proper output, as well as protect
  against regressions later on.  I recommend using the testthat package to do
  so, there is a good guide to using testthat and unit tests in general at
  <http://r-pkgs.had.co.nz/tests.html>.


why?


@IvanUkhov , the later has the prior. For example, if your box equips with gfortran and ifort, OpenBLAS will choose ifort by f_check.


Bisogna fare binary[i] = (byte) getNumericValue(binaryString[i])


Done.


6 instead of 2, even:

     disableSubmitButton();
+    disableFavoriteSpaceButton();
+    disableShareSpaceButton();


Если выше явно прописали rebuildCache(); в createContact, то здесь обнулять кэш не нужно.


Woops! Watch out for typos in your response. No biggie, just forgot a "d" in "rounds."


This looks awesome! :+1:


Please use "real" names from actual uses cases -- see http://data.unhcr.org/jordan/services-advisor/ or http://digitalhumanitarians.com/content/unhcr-app-syrian-refugees for an application that is built using this API (though they proxy the results through a server to workaround this bug)


Здесь можно сразу писать return условия, и не писать конструкции с if


If we have precedent, i think it is appropriate to add test for it


J'adooooore !


You don't have to pass in 'null' in Javascript. If the parameter is not set, it will be set to undefined.


If this can only be a single value then we should probably make it 'stream_path_si'.  This might avoid the need to call #first on it in StreamToken#validate_token.


Prefer `Optional<UserAccount>` to `@Nullable UserAccount`


That sounds like a reasonable enhancement - filed ticket https://github.com/couchbase/sync_gateway/issues/871 to track.  Thanks!


A busca está funcionando


Since j2objc-gradle is not yet bound to any particular j2objc version, would it be better to use master?
https://github.com/google/j2objc/blob/master/translator/src/main/resources/com/google/devtools/j2objc/J2ObjC.properties


A test for what? We already had tests failing because of this mistake of mine.


Restaurants?


This was Rubocop autocorrect by the way :-)


Perhaps `destroyCoins` should take `STAmount` (and in the future `NativeAmount` or `Amount`)


@PatrickJS damn, I was going to submit the exact same PR (except I missed the whole Dart thing :)

As a side note, you have an unused import `isBlank` in `json_pipe.ts` and I was a bit stricter on the types (latestValue could be a string instead of any ?). Nice job!


Looks good! Thanks for getting this done!


Hi Salonee. Overall, this looks great! I'm just adding a few suggestions.


Depends on when they were merged. Stable branch was created on 15th of this month so everything merged after that that is not a regression fix will be in the next release.


This wording will be a little awkward if there is a tie. It will say "Winner is: Tie". Maybe add a special 'if' statement and console.log a different result if there's a tie.


please avoid committing .idea changes :laughing:
it messes with other people's project configs in studio


I merged this but now realize that this is a different naming convention than the `assertReceivedOnNext` that it is a cover method for. I understand that it's a shorter name, but now we have two names for the same thing and that hinders discoverability and understanding. The obvious question will then always be "what's the difference?".

I suggest we keep the existing naming as we can't remove `assertReceivedOnNext`.


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2176 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.91%25-yellow.svg)


Yeah, sounds about right.


I am uncertain of correct syntax for the @property definition


You should indent these curly braces so they are in line with you if statement. It will make you code more readable.


I don't think an `STAmount` dependency is a bad thing. Anyway `getReserve` shouldn't be in `Ledger`, as we discussed (it accesses the cached fee members). Having `std::uint64_t` as yet another representation for amounts is something we want to do away with in the future. Perhaps not in this set of changes.


Don't delete the old migrations.


lmao can you guys stop saying backend. It sounds like you are a butt hacker.


We might flatten down all the migrations at some point because there's a lot of them and they're mostly not that interesting (also don't run from 0), but for now we should keep them for "history"


It's Go not golang


@sklum both getPos() and getNeg() should be completely removed at some point in the future


He'll -> he will


we have to handle code 204 and throw this specific exception right? all other exceptions like 4**, 5** anyway SDK will throw. Please correct if i misunderstood this


Simply restart from current master and use

History[depth > 10 * ONE_PLY] instead of History

In all History occurances in search.cpp, don't need to modify MovePicker and other files.


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1658 of 1658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


For now I'm just setting email = username if !email. Looking forward to a proper fix.
Thanks!


Should this throw an exception instead of returning 0? What will happen if the row being rewritten is an array/map?


Don't include this line.  I think only some versions of postgres need it and until we're sure which version we'll be using in prod we shouldn't include it, just in case.  (I have the same problem with my version of pg).


This is good, but in the future you may want to think about special cases where the user makes an error. What happens if they capitalize 'ROCK' or if they enter a number? You may want to define what you are looking for and keep asking for input if the user doesn't give you a valid format.

```js

if(typeof(move) === String){
        move.trim();
        move.toLowerCase();
    }

    if((move=="rock")||(move=="paper")||(move=="scissors")){
        return move;
    }
    else{
        console.log("Make a valid move.");
        move = getInput();
        //recursively call getPlayerMove to get a valid move.
        move = getPlayerMove(move);
    }
    return move;
 }

```


Please remove this.


@spilist ㅋㅋ 스스로 답을 낸 것 같지만..
퍼포먼스를 생각한 건 아니고 (겨우 그거 하는데 느려봐야 얼마나 느리고 빨라봐야 얼마나 빠르겠어) 어쨌든 다른 종류의 resource니까 URL이 따로 있어야 한다 + 앵커는 같은 페이지의 특정 위치를 지정하는데에 사용한다는 근본 가정부터 출발해서, URL이 따로 있어야 링크 걸기(= 공유)나 SEO에도 좋고 `.active` 붙이기 따위의 굳이 안 해도 될 노력을 아낄 수 있다는 점도 있고.. 탭바를 사용하더라도, 각 탭들이 페이지 이동하는 링크처럼 동작해도 됨. 이렇게 만든 다음에 ajax + history.js 같은 걸 사용해서 페이지 로딩 아끼는 걸 나중에 더할 수 있고.

더 큰 그림에서 보자면, 페이지 이동 없는 탭바는 mode (http://en.wikipedia.org/wiki/Mode_(computer_interface)) 라고 생각하는데, 유저에게도 헷갈리고 (뒤로가기가 직관적으로 동작하지 않음) 개발자에게도 어려움 (pagination 같은 거 붙이고 한 페이지 내에서 동시에 여러 뭐시기를 관리해야 하니까)


I'm guess factories are there for tests. If that's the case then I think this should be somewhere else


Closes #109. Also allows saving household members without DOB and income sources without amount (defaults to 0).


Branch has been updated.


Maybe have factories within tests?


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1664 of 1664 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This fixes a crash in widows when you select the cancel arrow.  The captureFileAsync() return an undefined file object which was calling the moveAsync on that object.


Yes, that was my concern. But running `rails destroy model ...` remove old migration :(. I thought that might be wrong. Will resort them of course.


dfsdf


So @bekvon  you are back? How nice!


c'était à prendre au second degrés, j'en veux à personne


Oh I am sorry but I didn't change anything, so why did this change?


here the debugger says it is ok , but the program crashes ...


@witzigs : schaut ok aus, halt mühsam wegen der SFX-Links. Aber da können wir nichts machen.


Commit message? :)


Shouldn't this be an exception?


We're always "around" 😊


`git pull --rebase` yapalim beyler :)


Hey, are these finished?  If I leave unfinished code I will do this idiom

```haskell
writeAPUTriangleCounterLoad :: Word8 -> Operation ()
writeAPUTriangleCounterLoad v = error "@TODO writeAPUTriangleCounterLoad"
```


It has been merged 20 hours ago, so it’s needed to fix the changelog.

btw This is one of the reasons why changelog IMHO should be updated by core devs, not contributors as stated in the [contributing guide](https://github.com/gitlabhq/gitlabhq/blob/master/CONTRIBUTING.md). The second reason are unnecessary merge conflicts. /cc @jvanbaarsen


Hmm. Maybe we can chat about it tomorrow when we're in the office?


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Oh.  I've never run ``rails destroy`` before.  I guess it's supposed to be like the inverse of ``rails generate`` for when you're starting out and got the generate wrong?


Hey @uberllama. Just curious about your comment. Are you doing anything special to cleanup your task or did you literally get all of this goodness by just adding this single line to your init file?

I have a long (5+ hours) running task that gets left in a _dirty_ state, would I just need to add this one line to have it mark the DelayedJob record as failed, quit the worker and restart the worker properly?

Thanks.


@xianyi, in your example, I don’t see how `ifort` will be chosen over `gfortran`. `gfortran` is the second in `@lists` while `ifort` is the very last one, and the list is traversed starting from the first element. It seems to me that `g95` has the highest priority, then `gfortran`, then `frt`, and so on up to `ifort`. Can you please clarify what I’m missing? Thanks!


Dogrusun, ben de az once farkettim surekli merge'e dustugumu :)

On 19 May 2015 at 19:40, Levent <notifications@github.com> wrote:

> git pull --rebase yapalim beyler :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/oveo/mt-craft-web/commit/6657b6e31fd04c47cbf094013b0da853ba76b8af#commitcomment-11265928>
> .
>


Use `auto` for `uReserve`?


Good to see the plugin is taken care of :)
Might I ask, to how extent are offline (cracked) servers supported? I am running Residence over two years and have a large database, so this is important.


Yes.


Studio does it. Because it is set up for everyone on different ways, and
also depends on which OS you are on etc. Best, I'll just add .idea to
gitignore :)
Because otherwise we will keep trampling on each others idea configs on
every commit :P

On 19 May 2015 at 22:08, Manan Wason <notifications@github.com> wrote:

> Oh I am sorry but I didn't change anything, so why did this change?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fossasia/open-event-android/commit/23c233b092ede6b98d52e42ecc9748a8063e50b6#commitcomment-11265897>
> .
>


Use proper docblocks with method descriptions


We could. The tests stub out the network request and return sample JSON + RSS content captured from the feeds we've been working with. You can consider them to be more functional than unit tests.

I don't think the code is complex enough to warrant another abstraction just so we can unit test an object returns a string object from a url using a standard library. And a separate test to verify that an arbitrary string of the shape the other thing provides works.

I'm open to being persuaded otherwise.

> On 19 May 2015, at 17:21, Dan Munckton <notifications@github.com> wrote:
>
> If I'm reading this right, we're stubbing quite a low level API here in order to make open(url).read return what we want. Could the document fetching behaviour be factored out into an object in our own code maybe?
>
> —
> Reply to this email directly or view it on GitHub.
>


Why? I'm using django 1.7. What will I need to change?


Yes it's a little bit annoying. Good to know I'm not the only one:). Removing then.


Why not just `canEnrypt`? etc. see below


@jirutka Then it will go to the next one yes.
We also tried the workflow where we update the changelog but things got missed and it was unbelievably time consuming.


All these echoes need escaping


I understand. Looks very promising :smile:.


You should use more expressive type parameter names here.


Very nice!


Tasklets are some kind of kernel tasks which are used for continual jobs. Rather you use them for one-shot task and this isn't the case for them. This is simpler way than the way which you begun in previous patch to make some SS routines work from user context, but it's wrong. Please revert the change and continue that way.


Use WP_Query. See WP_Query performance stuff in Best Practices.


Yeah that would be good. Cheers :smile:


What is the `dup` defending against here?


added some hashFunctions and completed the table.


Personally I haven't had the time to do anything Minecraft but typically cracked servers were never really supported but that doesn't mean there should be issues with it. It makes it easier to support a regular version of a server product as you can better troubleshoot issues vs trying to figure out changes someone made to the product that could be the root cause of an issue in the first place.


Thank you, this was quite an annoying bug.


It should also be noted: rockColumn_json is already a sparse array. It leaves out all the grid cell indices that are not populated by RockColumn objects.

I'm guessing you want to make a sparse array where defaults are left out? If so, we need to distinguish between grid cells that are empty, grid cells populated by ocean defaults, and grid cells populated by land defaults. The first category is always going to be the largest of the three categories, so that ought to be the category we leave out of the sparse array.

As for the other categories: if ever we want to save space using a UInt16Array, we'll be working with a very rigid data structure. I suggest setting up separate lists expressing the indices of grid cells that are populated by default values for land/ocean, e.g. `rockColumns_json.land = [1234, 2345, 4321, ... ]`. These can be later converted to their own UInt16Arrays for additional space savings.


Have you given any thought to using/supporting Ansible for this too?


I like this.


I'm not a fan of having one Query function that includes the reduce and map: it doesn't make it clear that indexing and reducing are two separate operations that won't happen at the same time. I prefer to have on call to grab an index (that only takes a map and sort), and then call reduce on that.


Check out the WP `selected()` function


Leading _ marks the meta field as private. Is this intentional?


@lieuwex WAT DE FUQ


je sais ^^


I actually like the explicit type because it sticks out and makes me want to fix `getReserve`


Use escape l18n functions such as `esc_html_e`


I don't follow. Why not do what? If you mean check mBaseFee, we do. Look at the beginning of the function.


Need to check current users capabilities before saving.


I'm wondering if we can do anything to prevent closures from breaking that.


Nice removal of duplicated logic.  Fwiw I have also done the side-by-side review and see nothing amiss.  Full testing also revealed no problems.


@lieuwex Nee, daar is emplace voor.


See JS standards for code formatting


why are you checking is a player's team is null, you want to make sure their team is not null so it won't throw an NPE


The max/min spread seems narrow, and all the default values seem low. I guess there's more spread to hot water loop temps than typical chilled water loop temps.  82C or 82.2C with a delta of 11C or 11.1C is common throughout the example files, but there are some 60s and some 5deltaCs.  I would lean towards Max supply=82, Min supply =  77 (keeping the 5C spread that the ChW version has) , and Constant return temp value 71.  But it's all a bit arbitrary.


"looks like"


wp_head is not the right action for this. Probably want wp_print_styles


Yes.. it's actually removing it all (all the things!)


@bernardobrezende
hahah como tu tinha pensado?


In theory, this code runs only when a job has finished. We just have to ensure that the `done` files are not created until the job is done with *everything*.

We should add a little check here to see whether the thread is still alive after the `join()`. If so, then somebody has written their job poorly, so we can explain that.


Thank you. I do make a backups so if any issues occur during the transition I will post an issue.


@asvetlov Renamed `expect_fingerprint` to `fingerprint` and changed to accept only `bytes`. Good suggestions.


All the other rule methods return new string objects. This keeps that behaviour consistent.

Sent from my iPhone

> On 19 May 2015, at 17:47, Dan Munckton <notifications@github.com> wrote:
>
> What is the dup defending against here?
>
> —
> Reply to this email directly or view it on GitHub.
>


Yeah. I had changed this. I think my push didn't make it up for some reason (probably forgot the -f). That said, with this there is the increased possibility that we can't connect to the DB. We'll fail then. Hopefully we detect that early and then throw the db away and start over, but I had to add some increased safety in case it happens.


Your tests are wrong -- they won't (ever) fail.
In Pester you have to **throw** an terminating error / exception in order to fail.
You should be using the MUST command (or the Pester built-in Should).


gtfs:startDate and gtfs:endDate startTime is for something different (mind that gtfs:startDate doesn't exist yet, but I'm going to add it to the spec)


Nice!


Ah ok it's `webmock`. If there's no other reason to justify the refactor, then I don't feel it's necessary. All good.


Switched from checking `req.ssl` to `transport.get_extra_info('sslcontext')` as suggested. The extra `transport.get_extra_info` call required changing some tests which assumed it would not be called (see below).


Oh, gosh. Sorry. But now you've re-introduced the warning. We need the parentheses around the whole `&&` clause.


I still see the definitions for these in STAmount.cpp.  I double checked that your patch will compile if the definitions are removed.


you were supposed to be comparing these two guys against each other, not checking them against preset values


Much prefer only dealing with binary digests in TCPConnector, thanks again for the good suggestion.


Hmm... We have to be careful here. Its possible that db.transaction doesn't even work (i.e. if you have the wrong encryption key, you can't even get a connection now). This callback should only be doing db work with the connection. Do we sometimes use it to post to the main thread?


Might want to move the contents of line 39 up to line 34. :cake:


1836664-ReturnWaterTempReset (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1664 of 1664 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Rewrote the example usage docs to hopefully be more digestible. (/me ducks)


r=jedmccaleb


For closing channels (operations that could not fail) you use Stop, e.g. https://golang.org/pkg/time/#Ticker.Stop.


lkjkd jakldsfj laskdfj


@JordanCheney Agreed.  This change was to facilitate some modifications to the script structure.


curious how this is working out for you.. ive been wanting to make this better, just want to know how people are using it and what they want out of it


Why not `tf::Vector3`?


@tomsmeding rustig


@asvetlov Rather than add helpers for this to aiohttp and increase API surface + maintenance burden (tests, docs, etc), how about we leave it up to users to convert from hex to binary? It's so simple that maybe just providing an example as in the docs above is enough.


@IvanUkhov , you are right. I will change gfortran to the first.


On second thought, `BodyGenerator` might be salvageable by using an `AsyncContentProvider` to prevent Jetty from blocking for new chunks and using a separate pool for `BodyGenerator` calls so that there are always threads available to progress the Jetty side of things.


Hi dbongs,

I have created the sample code to retrieve the list of all airports. I will upload the code shortly. Our provisioning team needs your complete credentials to check on the provisioning. Could you please send me your credentials to me over mail. My mail id is Vivek.pramanik@travelport.com. Thanks.

Thanks & Regards
Vivekjyoti Pramanik


Or `tf::Quaternion`.


Shouldn't this be `return False`?
E.g. It **has** a location and it's **not** that `DEFAULT_PRERECORDED_LOCATION` one.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/5676ee93814b1599838b9ba680a12a944ecff488


merging MonsieurNicolas/stellar-core/loadFrames = 5676ee93 into auto


MonsieurNicolas/stellar-core/loadFrames = 5676ee93 merged ok, testing candidate = 21935550


Thanks GW, this should be resolved by the latest commit.


@MartiUK revert this, too. It's not worth all the extra trouble and it's generally bad to change the defaults for users.


we can finally put those scrap electronics to good use ;-)

On Tuesday, May 19, 2015, Smurf <notifications@github.com> wrote:

> [image: :+1:] exciting.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DayZMod/DayZ/commit/ba31a8b01d5e544116f8a50225affbe40d21039b#commitcomment-11264046>
> .
>


@CaptainElliott Is it causing any problem or should I mantain it or remove it or what?


adding `transport.get_extra_info('sslcontext')` call required change (1 of 2)


adding `transport.get_extra_info('sslcontext')` call required change (2 of 2)


все дело в том, что json-ом пользуются они оба - и рантайм, и IDE. поэтому вариантов кроме как включать в состав либы нет особых. а пакеты я менял чтобы не было конфликтов имен. а тут это надо только рантайму, и отсюда все проблемы. поэтому это либо заставлять пользователя самому подключать jar (ручками или через какие то глобальный настройки), либо притащить к себе. оба варианта так себе, пожтому решили выбрать второй


Change to one tab. Also maybe use C-style init (if it work):
```cpp
array = {
    [MAV_SENSOR_ROTATION_YAW_45] = {X, Y, Z},
};
```


You have, like 5 `[SUBMIT]` commits :laughing:. You were intended to make one.

We'll be considering the first one as a production version, though. Just making it clear. The rest of your improvements will also be evaluated.


Oops. Pushed another update. Sadly I left the initial one at home on a
laptop I can't get to remotely.

Thanks

Anders

On Tue, May 19, 2015 at 7:17 AM, Benjamin Bannier <notifications@github.com>
wrote:

> Please also push this rct revision.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Andersbakken/rtags/commit/1dea57231ed86e912bebd6455a27884ce6d21316#commitcomment-11262748>
> .
>


for any reason in special. Is it better or worse? doesn't `std::array` allocate less space in mem?


This sounds wrong... unless PulseAudio explicitly documents such a behavior.


This is is bad. It put too much stuff in the condition.


Fine to me


hmm, may try it!


I don't think I understand that `and not event.is_upcoming()` aspect.
If an event was created from an upload, it most likely can never be upcoming because the start_time is always just set (automatically) to `now()`.

I think you can simplify the if-statement to just
```
if event.is_prerecorded()
    Uploaded: ...
else
    Start time: ...
```


convention we use in the code is
```
X const&
```
not
```
const X&
```


Also why MAX XYZ = 315? Why not ROLL_315_PITCH_315_YAW_315? MAX should be 39.


ok.. Let me fix it in a moment.


Probably, going to try to fix the DNS.


Not really correct. You can still adjust the timing, even if other subtitle events are still missing. Although there's a chance the delay is high enough that future subtitles will not display soon enough due to insufficient buffering ahead.


Also a comment on what those are here for, given that herder.h is where we define the contract


we probably want
```
SCPEnvelope const & envelope
```


stupid idiot


Also i think it should be in radians, so for initialization constexpr function is very useful.


Uh what?


@kouno Done.


And what would be MAX in that case? {359, 359, 359}? Cause we are considering 45 degrees rotations, and that's why 315 in the three euler angles can be considered max, which means summing 45 to them would get to 0 again, which is rotation none.


For synchronous transaction submissions, this thread has to wait for the transaction to be applied anyway, so you might as well apply it in this thread. It doesn't make sense to ask a thread to do some work and then wait for a thread to get scheduled, all the while tying up a thread from the same pool.

The ideal solution for synchronous transaction application would be this:
1) You put the transaction in the queue.
2) If the queue is already running, you just wait.
3) Otherwise, you do one pass through the queue yourself, guaranteeing your synchronous transaction is done.
4) If there are more transactions in the queue, you dispatch a thread to do the rest of them, but you don't have to wait for it.
5) You move on knowing your transaction was done.
You know you have a sub-optimal design if it fails if there's only one thread in the pool, and this does.


#fix 21


Found your code in the bugtracker, @grawity. I am not able to test this code out though.


test01 did not pass gate, trying with test02


When you insert a transaction into the queue, note whether the queue was empty. if the queue was not empty, you know there's nothing you need to do because whoever put that other transaction on the queue must have dispatched.


No, opengl is preferred here. Maybe the vo_vdpau line should be changed, though vo_vdpau is also much better than vo_vaapi. vo_vaapi basically uses an extremely bad API not even Intel seems to care about anymore.


No matter, const. Also why do you think that std::array ma be smaller than `3*sizeof(double)`?


Line 6 `<meta name="viewport" content="width=device-width, initial-scale=1">` adds mobile scaling.


should that just be an assert as it's not supposed to happen? (ie, there is a bug in the pending envelope thing)


I search a solution, but it is difficult to do a fix which works with all widgets, with all browsers. Currently, there are many bugs with scroller widget and fixed columns, and it is not usable thus...


This will fail if the source class inherits a class with `reload` method.


The game runs (in my VM, wine-1.7.41), with **terrible lag** to the point it makes the game unusable. I'm not sure what ROBLOX falls back to when directx11 is disabled (studio still says Automatic), but I have suspicions that it's not the OpenGL that we want...


The URL from the commit message is no longer valid.


I'm just seeing this should use ``:`` instead of ``,``.


FWIW, Sqitch uses Path::Class. So it should already be around.

Sqitch also uses Moo instead of Moose now. *Much* better performance.


The standard I've settled on for this sort of thing is to have a `project` variable under `core`, and that's the lowest-level default.


should be valid counter


`*_MAX` usually used to define array size or limiting high limit, so it has not valid number.


We already support that case, but we need to know the number of dimensions in advance, either by knowing the length of `reps`, or by setting `ndim`.


You may shorten this down to
>if(m_apPlayers[i])
>    SendVoteStatus(...);
(leave out the curly brackets)


This could be an event.


Removes variables defines, as they are not used further in this file. We only have to make sure that ```ConfigPaths``` and ```Globals``` gets loaded before Main.js; and the configuration still remains the same.


and here.


I just tried it and when the plugin starts none of my layers are loaded


I've left install from git-master as a handy alternative for those restricted environments (although it's redundant when you have the code checked out anyway).


okay to do in future PR or file and issue or make me do it.


Adding it to the scoreboard alias might be beneficial


`DeleteRecord` and `DeleteRecordsFor` could be reimplemented in terms of `DeleteRecords`, or we could remove those methods altogether and refactor clients to use `DeleteRecords` directly. Thoughts @inercia?


this introduces a bug where you can't have color when jest is running in a subshell, and it's output is captured by a parent, and, after some processing, displays on TTY.


It is not a question of "not currently supported", it is that the user provided inconsistent values.


In the interest of DRY, I believe that the following comparison operators might be better implemented as inlines in the header rather than in the source, with no loss of efficiency:
````
inline
bool
operator!= (STAmount const& lhs, STAmount const& rhs)
{
    return !(lhs == rhs);
}

inline
bool
operator> (STAmount const& lhs, STAmount const& rhs)
{
    return rhs < lhs;
}

inline
bool
operator<= (STAmount const& lhs, STAmount const& rhs)
{
    return !(rhs < lhs);
}

inline
bool
operator>= (STAmount const& lhs, STAmount const& rhs)
{
    return !(lhs < rhs);
}
````
Then the logic of the static `compare` function in STAmount.cpp can be moved into the one remaining place it is used (again without any loss of efficiency):
````
bool
operator< (STAmount const& lhs, STAmount const& rhs)
{
    // Compares the value of a to the value of this STAmount, amounts must be comparable
    if (lhs.negative() != rhs.negative())
        return lhs.negative();
    if (lhs.mantissa() == 0)
    {
        if (rhs.negative())
            return false;
        return rhs.mantissa() != 0;
    }
    if (rhs.mantissa() == 0) return false;  // Known that !lhs.negative()
    if (lhs.exponent() > rhs.exponent()) return lhs.negative();
    if (lhs.exponent() < rhs.exponent()) return !lhs.negative();
    if (lhs.mantissa() > rhs.mantissa()) return lhs.negative();
    if (lhs.mantissa() < rhs.mantissa()) return !lhs.negative();
    return false;
}
````


An alternative signature for this function would be to just accept a predicate function directly, which might be more flexible...


Update Similar Text


Where does ``output`` get assigned here?

It's funny -- the test passes, but this is stealing the CSRF token from a code block somewhere above.  :lock: :key:


I tested it with 3.2 – well, I _think_ I tested it – but the entire m_sasl is a port from Charybdis anyway, which has had an identical patch.

Anope 2.x also sends SASL M messages; does it have Unreal 3.4 support?


bug rerere


se ha agregado mas info para el informe


Sorry about this! Can't see a way around it without the `-nocache` flag to `weaveDNS`


We should probably wrap this in PSCmdlet.ThrowTerminatingError to control the error category etc.


TeamCity NEventStore :: Core :: Build [Build 62](http://build.prxm.it:8811/viewLog.html?buildId=2662&buildTypeId=NEventStore_CI) is now running


OK, I don't think this is this commt, but the dialog tweaks one which followed it. Can you try reverting that one, and confirm that everything comes back to life? I have, and it did. Just want to double-check before reverting in master.


[Deployment available online](https://s.brightspace.com/lib/superagent-d2l-cors-proxy/0.1.0/index.html)


Yes, it is supported, as alloc will add the necessary dimensions.
The things that would not make sense is for `len(reps) > ndim` or `x.ndim > ndim`, if `ndim` is not None, and this is what you should check here.


Fixed!


Do you mind adding a check to see if the file is not present in the CWD, and falling back to this if its not? I'd like to keep compatibility with current pipelines that symlink in poa-blosum80.mat. Thanks


I was able to compile miniupnpd with ipv6 support for the rt-n66u a while ago (see https://github.com/pinwing/asuswrt-merlin/commits/ipv6), but then gave up, because it caused some applications to stop working.
In particular, I have found software that seems to look for "WANIPConnection:1" instead of "WANIPConnection:", which does not match against "WANIPConnection:2" when --igd2 is used and then no port forwarding is set up...


TeamCity NEventStore :: Core :: Build [Build 62](http://build.prxm.it:8811/viewLog.html?buildId=2662&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 588 Build time: 00:02:11


Close #1025


To clarify - I think this is the commit which has caused @edboesiii's issue. Can you confirm?


no trailing parens, should be )))


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1658 of 1658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What type of file was used to create the mcmod.info text? I used json and regular text and neither worked for me.


Thanks. Merged to staging.


Python-habits :p


There is some common structure between this an `put_dns_fqdn`, but I think the loss of clarity in pulling it out outweighs the slight duplication


Is the vcc actually attached to the adc pin ? Cause readvdd33() return the vcc. It also can't be used while in station mode as it crash the chip. It's an SDK problem.


best to leave this decision to the person who can be bothered to implement it.

aye, until we move to a real scheduler, mem usage is kinda important and lmplz grabs way too much. Running some of the WMT experiments with 10+ LMs which are then interpolated causes a few problems.

Most of the time lmplz finishes before word alignment, not to mention phrase extraction so we can balance it a bit better


This does not look right.
If `ndim` is specified, then `reps` should be padded by ones until its length is `ndim`, not `x.ndim`.


good catch - will spell check next time


I'll file an issue and let you do it since it'll probably take you 10 seconds and I'll have to poke around for a bit to try and figure out how to fire an event.


I like it but I can no longer merge.


I shall ask them tomorrow. Thanks :)


we need to increment counter for each iteration below right?


I'm reading this as "raise an error unless we're on windows, and using negotiate, and using ssl or platinext"

* Since we're in base, what about `knife windows bootstrap ssh`?
* Why not allow validatorless bootstrap over winrm+basic+ssl?
* "Validatorless" should be one word
* It'd be nice to have a method or two here that make this conditional more readable like Chef::Knife::WinrmCommandSharedFunctions.negotiate_auth?


I see that you changed your answer here. The one you had before was better since the prompt asks you to only call getInput() only if move is not already specified.


No vpn gateway connections found


qqq typo?


Same issue here.


One space after "else if"


Yes, you are right. I mixed something up. Sorry for interrupt.


TeamCity NEventStore :: Core :: Build [Build 63](http://build.prxm.it:8811/viewLog.html?buildId=2664&buildTypeId=NEventStore_CI) is now running


shouldn't this be call.apply.apply? ;)


TeamCity NEventStore :: Core :: Build [Build 63](http://build.prxm.it:8811/viewLog.html?buildId=2664&buildTypeId=NEventStore_CI) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:00:08


I have yet to see this alignment issue are you sure it's not your html/css that is at fault?

is there an alignment issue here? http://jsfiddle.net/856bzzeL/265/


Riiight!


Ok, thanks for the heads up.  I will probably end up disabling it then (I hadn't had the chance to do any real testing yet beside with the upnpc client, so this was still very experimental).

Ideally, miniupnpd would need a runtime option to allow disabling/enabling igd2 support, so users would be able to manually enable it from the router's webui.  Maybe something to pitch at @miniupnp , assuming it wouldn't require too many code changes all over miniupnpd?


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/63204627


1836664-ReturnWaterTempReset (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1664 of 1664 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@GLolol I mainly just want the game to actually run. I have advised users time and time again to use OpenGL, but that is up to the end user. By disabling DirectX 11, the crashing issues are no longer present, and I feel that's about as good as it gets.


This uses a KeyLocator object. But the EncryptedContent TLV spec only has a Name (inside a TLV with a KeyLocator tag). http://redmine.named-data.net/issues/2750 .  What happens if the application sets m_keyLocator to a KeyDigest? Should EncryptedContent have a Name instead of a KeyLocator?


You are right. The code as commited does not free the right pages :)


@HowardHinnant Uh...at the risk of sounding ignorant about about `operator==`?


TeamCity NEventStore :: Core :: Build [Build 64](http://build.prxm.it:8811/viewLog.html?buildId=2666&buildTypeId=NEventStore_CI) is now running


:boom: nice catch!


It is fine as it is in STAmount.cpp.  No change recommended for that.


If this is normal flow, we should avoid having a path with an exception


Hi @Mierdin  - I think you should add an emoji related to breaking things in line 3.


Actually it doesn't matter, because in latter lines you can see that `$configVars` gets value of `$configVars['variables']` so during the array merge with `$_ENV` it will return exactly what `$_ENV` had before.


:+1: Those warnings were bugging me but I figured I had enough things in the restructuring diff already, so I put them off.


I just want to check that the 'visible' option the only one that needs handling in ``update_handles``? Are all the other style options handles correctly then?


i'm confused by passing this in as an arg, did you mean to dump it in the logs or something?


same here: normal flow -> don't use exceptions


TeamCity NEventStore :: Core :: Build [Build 64](http://build.prxm.it:8811/viewLog.html?buildId=2666&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 351 Build time: 00:01:51


гуд


@mwatts15 if this is removed from the Travis-CI config, shouldn't we also delete runtests.sh and remove the reference to running it in Install.md? cc: @travs


will update


remove this change as it seems it's only reformatting noise on an external dependency


Visible is the only style option that can potentially be overridden from the outside (update_frame does it to blank artists out when there it can't find a particular frame).


err := wrk.Run(ctx)?


Same here, mcmod.info does not work...

On Tue, May 19, 2015 at 1:28 PM, shadowclone69 <notifications@github.com>
wrote:

> What type of file was used to create the mcmod.info text? I used json and
> regular text and neither worked for me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pahimar/LetsModReboot/commit/c9f97c9c9e5f404951eec4f7119c21f3bbb65a4d#commitcomment-11266861>
> .
>

--
Jon


I'd name it by it's full name here.


Ha. Sure. I bet that would work. Thankfully this is compiled via coffeescript and I don't have to write that kind of silliness


тут и ниже размазана логика.
предлагаю выделить в отдельные функции


Have a look at https://github.com/analogdevicesinc/colorimeter/blob/master/device.py#L32L47 maybe we can adopt a similar scheme here. The base numbers are unfortunately not stable and can and probably will change again in future kernel releases.


Woah what's going on here? Chaining ternary statements is clever, but makes your code very unreadable. Some programmers debate whether they should be used at all. In general, you want to keep ternary statements short and sweet. I would refactor this so it's more clear to anyone reviewing your code.

Also, if the result is neither 'player,' nor 'computer,' you are returning 'tie,' but not doing anything with it. Maybe you want to print something to the console to let the user know it's a tie?


To update existing DBs for this change, we will need to run something like the following:
    `db.collections.update_many({},{'$rename':{'curator_id':'curator'}}); `

@gsfr please confirm.


+1 for not breaking apps.


Could you please not do that again without a PR?


+javadoc for why this exists and how it should be used


why do we need the fullVersion instance field? can't that logic just go in a method and toString() calls that method? also it probably makes sense when constructing the version string to call the shortGitHash() method vs. the same substring() in both places.


TeamCity NEventStore :: Core :: Build [Build 65](http://build.prxm.it:8811/viewLog.html?buildId=2668&buildTypeId=NEventStore_CI) is now running


yup, def messed that up

On Tue, May 19, 2015 at 12:57 PM, Max Blaushild <notifications@github.com>
wrote:

> you were supposed to be comparing these two guys against each other, not
> checking them against preset values
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alinaw89/wdi_4_ruby_fundamentals_quiz/commit/a1465209b148ae4e3e8405bd43b94b0f9e126068#commitcomment-11266272>
> .
>


Lol, thought it's brand new! haha. Never-mind my previous comment.


Har gjort ett nytt projekt och skrotade mitt gamla samt drog hem den senaste pushen. Det ska alltså vara säkert att dra hem det utan några headproblem eller annat skit. Men jag tar inget ansvar om det skiter sig ändå...


TeamCity NEventStore :: Core :: Build [Build 65](http://build.prxm.it:8811/viewLog.html?buildId=2668&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 60 Build time: 00:00:43


~~`SearchSoure`~~ `SearchSource`


remove completely


Функция ``` create ```
В ней много логики и различных действий.
Такие функции лучше разбить на несколько.


It's an orig file that was accidentally added it looks like.


Looks good!


Good job, but don't get too crazy with the ternary statements. You want to balance the 'readability' of your code with how compact it is. Don't sacrifice readability to save a few lines of typing.

Pretty clever though :+1:


Installation details added.


why the bitshift ?


гуд


я хотел что бы текст передавался в ```config```


@racerxdl GIBE MONI PLOX


Thanks for the notification, it is fixed in https://github.com/eclipse/buildship/commit/8da468d


why do we need to disable those tests? SCP changes are not going to help with them.


because normally we return 10 bit value


Hm, this is no longer checking for interruptions now. It can also return errors for context DeadlineExceeded.

(in current practice, that's not likely, since you're passing in a Background context and using that to check interruptions. that might change in the future though)


Maybe, but i still don't know the structure of NOVA code enough.
Just watching the commits to see this thing rise


@jessespears the point of requirements.txt is to freeze library versions for testing. With this requirements.txt it is not clear what versions of libraries we will be testing against.


TeamCity NEventStore :: Core :: Build [Build 66](http://build.prxm.it:8811/viewLog.html?buildId=2670&buildTypeId=NEventStore_CI) is now running


~~`to the store its tied`~~ `to the supplied Store`? `to the Store`?


pavel/ Home task on 16.03.2015 #14 /script.js

зачем записывать в переменную?

``` if(checkAnswer(question, answer, hiddenWord)) ```
так кажется лучше


What makes the removal temporary?


No problem! I was having trouble deciding which to choose next :smile:

I'm still having a problem with book titles being integers (Orwell's 1984 gave me fits) and haven't sat down and solved it yet.

P.S. I hope you don't mind that I "un-forked" your repo.


TeamCity NEventStore :: Core :: Build [Build 66](http://build.prxm.it:8811/viewLog.html?buildId=2670&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 60 Build time: 00:00:43


Seems these should go down under the next section.


Even though there isn't really any difference right now, I think the heading is a placeholder for future work.


Yes,. But the integration may be more difficult because most of ansible modules DO things and does not expose the current state. But at least the connection module (and configuration), the "setup" module and the check mode may be convenient to write testinfra based tests.

Do you known if puppet or chef have an API (at least CLI based), to get the actual state of servers ? Any integration with infrastructure tools is good to have :)


Good idea. I changed it to `buildpack-run.sh`. Thanks for using the buildpack!


TeamCity NEventStore :: Core :: Build [Build 67](http://build.prxm.it:8811/viewLog.html?buildId=2672&buildTypeId=NEventStore_CI) is now running


pavel/ Home task on 09.03.2015 #13 /script.js

некоторые такую запись могут не понять.
предлагаю написать комментарий


Ok that makes sense.


Oooh, didn't even notice the '32' sneaking in there, thanks!


hm, would `'reload' in this.style.sources[i]` be a more robust technique?


TeamCity NEventStore :: Core :: Build [Build 67](http://build.prxm.it:8811/viewLog.html?buildId=2672&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 60 Build time: 00:00:45


you can't have a variable name that's the same with the function's name. in line 56, average should be another name.


Thanks, will freeze.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15103/testReport/) for this commit**


не кажеться что сильно большая логика тут?
Ее тяжело править и поддерживать?

Как вариант исспользовать массив с данными.


@CamiCanali,

Sim, só não vai esquecer da tag "<img>" ali dentro do `append`.

Se o código começar a ficar muito grande é quase sempre melhor colocar em arquivos separados.


What is the purpose of this logic?

Is it because when using MIGs on GCP, there is no easy way to trigger a DELETE /api/v1/nodes/$NODE upon instance deletion?

Two things I sort of dislike about this approach:
  - It seems better if the thing that creates an object is also the thing that deletes (kubelet allocates a node resource, so it should delete it, as part of its clean shutdown procedure.)  Maybe this is just c++ programmer bias.
  - It seems like a fault in the cloud provider instance listing code or in the cloud provider API server itself, which caused an empty list of instances to be returned, would result in catastrophic node deletion.  We should prefer to get this information from the node if possible, since it knows its own state.

What about the following approach.  Add a [shutdown script](https://cloud.google.com/compute/docs/shutdownscript) to every node which does:
```sh
/etc/init.d/kubelet stop
/usr/local/bin/kubelet --deregister`
```
When run with the deregister option, the kubelet does a `DELETE /api/v1/nodes/$MYNODE`.

If the
If the node has not done a heartbeat recently, then we will mark it as unready.
Seems like there is no harm in having some


гуд


Do we not want to cancel the worker after the first error? This is a change in behavior, previously if a single executeFetchLoop failed (for example), the worker would fail-fast. Now, it'll keep trying to make progress, and probably return a partial success.


I personally don't understand this change, the log message is not consistent with the comparison statements.


since searchTerms is a list, i think you could use:
for term in searchTerms:
    cmd = "...." + str( term )


No, no, no. This is wrong! See the comment above.


Ok, I thought factories are more like models in angular.js, to interface between controller and databases or data services. But I would like to have a sample to see what exactlty you mean, or we chat it out later.


Needs to be more Pythonic!


Great work


i get this error after restarting the server ...

POSTGREY_OPTS=--inet=127.0.0.1:10023: not found


Globs don't expand if you quote the argument.


Where is this used? This doesn't belong in cache.


(I'm new to GitLab as well as to forking & pull requests)

Of course I can change this, but I can't easily test it anymore, due to the lack of hardware right now.
Is it preferable that I do that change instead of you're doing it? (This is not meant as a rhetorical question!) Is it better for traceability or some kind of development workflow - or do you ask me to change it as I could be in the position to re-test it?)


readme seems to be out of date with server.js? It's still using app directory and port 5000.


is this why I get the error below after a rebase of my fork recently?

    joakim@joakim-K52JT:~/work/mame$ make TARGET=mess
    make: *** No rule to make target `scripts/target/mess/mess.lua', needed by `build/projects/sdl/mess/gmake-linux/Makefile'.  Stop.

Or is `make clean`enough afterwards?


the [number of] occurrences? also occurances should be occurrences


Ha, actually `hasOwnProperty` will fail all the time because `reload` methods are defined in prototypes.
`'reload' in this.style.sources[i]` or `this.style.sources[i].reload` or `typeof this.style.sources[i].reload === 'function'` will all work.


Should we rename CacheEntryOptions to MemoryCacheEntryOptions for consistancy? Or is that just too long and painful?


Me too, me too


ha ha ha, kind of messed up there a little bit, almost thought i was working on the restaurant project, but I fixed it. :)


Having the same issue here.


good


I bothered to implement it in 6b1c74371


TeamCity NEventStore :: Core :: Build [Build 68](http://build.prxm.it:8811/viewLog.html?buildId=2674&buildTypeId=NEventStore_CI) is now running


I tried using this commit. I had trouble figuring out how to download the commit branch but thats another story.  My layers loaded correctly and the resulting Leaflet map did have my coordinate system but the geojson file containing my vector layer had another coordinate system.


you can also use either str.lower or str.upper in these cases


I'm going to open a PR to re-add this test in a JDK-6-compatible way.


TeamCity NEventStore :: Core :: Build [Build 68](http://build.prxm.it:8811/viewLog.html?buildId=2674&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 60 Build time: 00:00:57


+1 for what @hoffoo stated. There needs to be better versioning (maybe gopkg.in ?) to begin with. Also, making breaking changes to core functionality without any surrounding documentation is an issue. It broke nearly all of the tests in our Go codebase where we check interface values and I spent a lot of time trying to figure out the culprit, finally figuring out it was this change.

Opened a PR (https://github.com/stretchr/testify/pull/168) to get this added back so we don't have to maintain a separate fork of Testify.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1432058209962
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


"family": "csa1adi"


The type signatures help.


TeamCity NEventStore :: Core :: Build [Build 69](http://build.prxm.it:8811/viewLog.html?buildId=2676&buildTypeId=NEventStore_CI) is now running


This is being used in [Session](https://github.com/aspnet/Session/blob/7d52b3f76eb5434e2081951cf44eab078e3dfc51/src/Microsoft.AspNet.Session/DistributedSession.cs#L168)...this extension was earlier present here, so kept it as it is...but yeah, it could have been present in Session itself...


maybe return count to allow the testcase to pass/fail on the results?


a


Having `%{config}` files in `%{_libdir}` feels wrong to me.  Note with systemd, all of the unit files in `/usr/lib/systemd/system` are *not* marked as `%config`, and OSTree enforces this by making `/usr` a read-only bind mount.


@Alfalik It is causing a problem, otherwise @CaptainElliott wouldn't have pointed it out.


:relaxed:


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1432058301064
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


## this is a markdown file


The dependency on SCPEnvelope seems odd to me: itemFetcher is supposed to be an overlay construct to download things. I would expect some of the downloads to not be related to SCPMessages. How does that work?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1432058322060
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Fixed in f566f5a557755ae533eb8b0f34bb80234abf3b22


> Is it because when using MIGs on GCP, there is no easy way to trigger a DELETE /api/v1/nodes/$NODE upon instance deletion?

Yes. We have no hooks to know when a VM is gone (e.g. the MIG was reduced in size by 1). So if a node isn't reporting, we reach out to the cloud provider to see if it still exists, and if not delete it from here.

> kubelet allocates a node resource, so it should delete it, as part of its clean shutdown procedure.

The kubelet can't reliably delete itself (what if the VM crashes or is deleted by a user out of band)?

> It seems like a fault in the cloud provider instance listing code or in the cloud provider API server itself, which caused an empty list of instances to be returned, would result in catastrophic node deletion.

Since this is only called when nodes are not reporting status, then it would be both a problem where nodes stopped updating and the cloud provider returned no results.

> Add a shutdown script to every node

That seems reasonable, but I think we need to leave this code in as well for cases where the node doesn't shut down gracefully. One problem I see with this is that when you do a rolling update, with this code you won't delete all pods from a node. MIGs replace VMs with new VMs with the same name, so everything will end up running in the same place in your cluster when you update nodes. With your proposal, when you update a node, the node will unregister itself, causing all pods to be shuffled onto different nodes in the cluster, and then those nodes will be updated (causing pods to be shuffled again).


TeamCity NEventStore :: Core :: Build [Build 69](http://build.prxm.it:8811/viewLog.html?buildId=2676&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 60 Build time: 00:01:15


### this is a test


You need to use `make SUBTARGET=mess` now.


MemoryCacheEntryOptions for consistency :+1:


So I was just about to remove the enable sorting checkbox, because it's annoying, why exactly was it added?
This commit doesn't really make anything clear at all


Can we stop doing this please? It doesn't look good. It doesn't line up with anything, and there's no clear way to extend the comment to multiple lines.


`independenetes`, acho que seria `independentes`


Did you mean "data" instead of "metadata" above. We seem to be describing dm.datadev option here.


ugh, indentation is weird.  Also, does `if let x, let y` do the tests differently than `if let x, y`?


I think clients should never be abled to trigger a log message in errorstream.


TeamCity NEventStore :: Core :: Build [Build 70](http://build.prxm.it:8811/viewLog.html?buildId=2678&buildTypeId=NEventStore_CI) is now running


If I understand this, this is an attempt to try my suggestion.  This particular one was directed at middlegame...I should have said that.  Is the S(x,y), (middlegame, endgame)?  If so, other values should be better.  Maybe (30,2).  But that is just a wild guess.


Typo.


Replace draw_er with render_er in readmes.


actually maybe this can happen if for some reason the LRUCache decides to kick out data that is actively used by SCP - how do we deal with this situation?


It's "caret", not "carot".


TeamCity NEventStore :: Core :: Build [Build 70](http://build.prxm.it:8811/viewLog.html?buildId=2678&buildTypeId=NEventStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 60 Build time: 00:01:12


Agree, definitely we should do something similar.


This moves towards the direction of workers sharing more code, which is awesome (it's really annoying to go and fix things in ~6 places every time you want to fix something). This also makes it easier for new workers to implement status updates.

However, I'm not sure this actually helps with the case of workers that don't want/need to display status.

(regardless, this still leaves the code in better shape than it was, so I'm happy)


Hmm, I tested this in the console and it seems to work. Were you getting an error?


 <addr>
#AddMom&Sisters


When you uncommented this in your merge, you broke the build. :-1:


Singular of "indices" is "index" (yes this is confusing, which is why I just say "indexes" instead of "indices").


It created for holding database session management.


@jirutka I fully agree with @maxlazio that its not doable for the core team to maintain the Changelog. If you want to contribute, thats great, but there are some guidelines and play rules you need to stick to. One of them is the Changelog. The fact that those two changelog items have been overlooked, well that's a shame and trust me, I'll look closer next time.

@maxlazio Shall I move those two changelog items out of 7.11 and into 7.12?


NullPointer


Mea culpa.


This is correct and works well. However, can you think of times a user does not give you the the write input. For example, what if a user tried to type in "table" or "ROCK". How could you deal with this?


Perfect!


Maybe not a good idea


This should use `setting-get('input border width')` instead of 3px


Thanks - went live this morning.


Since 'playerWins' and 'computerWins' are just returning numbers, you should specify in your string which score is which. Labeled scores will be easier for the user to understand. For instance...

```js
console.log('The score is currently\nPlayer Wins:' + playerWins + '\nComputer Wins: ' + computerWins + '\n');
```


@brilacerda pra tu poder usar esse construtor nos outros arquivos, tu tem que por ele junto dos outros na primeira linha.


So an if statement will only run the code once. Here, were asked to run the code over and over again until the the conditions are met. You would need to use a loop. Specifically, you could use a 'while' loop. Try replacing the if statement with a while statement using the same conditions (playerWins < 5 && computerWins < 5).


I realize this precedes your changes, but we shouldn't keep a mutable object passed to the constructor as an instance variable; the array should be copied (and "final" doesn't mean "immutable").


See above.


changed


Shouldn't that be 2.1.3 as 2.1.2 is already tagged https://github.com/WoltLab/com.woltlab.wcf.exporter/tree/2.1.2


aws, juju, libvirt-coreos, rackspace, ubuntu, vagrant, and vsphere all set the --hostname_override flag.
Should this also be the External ID, in at least some of the cases?  --hostname_override gets put in kl.hostname.

Also, ExternalID is unimplemented for Rackspace, so it won't be able to auto-register.  Maybe file a bug telling them to implement that.  They need to decide whether to use their private_ip or public_ip or something else for the ExternalID.


This change was made in master. Evil.


eu coloquei... mas onde exatamente tu tas falando?


@mythmon If I write like this, I cant pick each revision later and get separate comment of them. like `r1.comment`
So I think creating 7 revisions with separate variable will good enough to test with.
What do you think?


I believe, it should be ioBridgeHook  instead of inetAddrHookMultipleResult (for both hooks)


missed a space :)


Why not delete this code and just return false after breaking out of the switch as you would for equality?


Na primeira linha desse arquivo, onde tem assim:

```haskell
 module LispVal (LispVal(Atom, List, DottedList, Number, String, Bool, Error, Native)) where
```
é pra ser assim:
```haskell
 module LispVal (LispVal(Atom, List, DottedList, Number, String, Bool, Error, Native, NonNative)) where
```
Mas na verdade não precisa desse NonNative.


@borshop: retry


Can you copy paste here the output of your /etc/default/postgrey please.

Btw my postgrey instance works great with this change:
```
postgrey 13321  0.0  0.4  71496 16492 ?        Ss   19:39   0:00 /usr/sbin/postgrey --pidfile=/var/run/postgrey.pid --daemonize --inet=127.0.0.1:10023 --delay=180
```


Good job. Let me know what error you were getting for your 'if' statement and we can try to figure out what went wrong.


não tinha visto esse module...


I reverted the commit, so current master should no longer have the problem. What you observe is correct. Vectors are still transformed to 4326 when written to JSON. However, the Leaflet map itself is in your projection, and Leaflet should reproject the JSON correctly. So, the test is: are your features in the right place in the webmap?


@pydanny
Wow, I did not know my attempt with oauth was being referenced here... that project was shameful .... :-P sorry


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15107/testReport/) for this commit**


woopsies. How bout...

if ((move == "rock")||(move == "paper")||(move == "scissors")){
     move === move;
}
else {
getInput();
};

P.S. ^ are the conditions case sensitive? Are my trequals and double equals
in the right spots?

Thanks!
-A

On Tue, May 19, 2015 at 2:08 PM, Alex Deschamps <notifications@github.com>
wrote:

> This is correct and works well. However, can you think of times a user
> does not give you the the write input. For example, what if a user tried to
> type in "table" or "ROCK". How could you deal with this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AaratiAkkapeddi/wdi-fundamentals-rps/commit/513966d581bcebf19c934443d8467d8d546d3298#commitcomment-11267692>
> .
>

--
.:°·ˇ*‡°˙∆¬˚˜˙…ˆ¨•\¬¨ˆˇ‡°∆˙°‡*ˇ·°:.


make test is reporting a linting error on the spacing...
```
/Users/james/Node/node-fresh/lib/path.js:395:(New Error 0006) Wrong indentation: expected any of {8, 18, 22, 24} but got 6
/Users/james/Node/node-fresh/lib/path.js:592:(New Error 0006) Wrong indentation: expected any of {8, 18, 22, 24} but got 6

Found 2 errors, including 2 new errors, in 1 files (49 files OK).
```


"switespaces" :smile:


Your only objective objection is false -- there's a very clear way to extend the comment to multiple lines.


function playToFive(playerMove, computerMove) {
    console.log("Let's play Rock, Paper, Scissors");
    var playerWins = 0;
    var computerWins = 0;
    while (playerWins < 5 && computerWins < 5){
      console.log('Player chose ' + playerMove + ' while Computer chose ' +
computerMove);
      console.log('The score is currently ' + playerWins + ' to ' +
computerWins + '\n');
      getInput();
      randomPlay();
    }
    // Write code that plays 'Rock, Paper, Scissors' until either the
player or the computer has won five times.
    /* YOUR CODE HERE */
    console.log('game over');
    return [playerWins, computerWins];
}

On Tue, May 19, 2015 at 2:18 PM, aarati akkapeddi <
aarati.akkapeddi@gmail.com> wrote:

> woopsies. How bout...
>
> if ((move == "rock")||(move == "paper")||(move == "scissors")){
>      move === move;
> }
> else {
> getInput();
> };
>
>
> P.S. ^ are the conditions case sensitive? Are my trequals and double
> equals in the right spots?
>
> Thanks!
> -A
>
>
> On Tue, May 19, 2015 at 2:08 PM, Alex Deschamps <notifications@github.com>
> wrote:
>
>> This is correct and works well. However, can you think of times a user
>> does not give you the the write input. For example, what if a user tried to
>> type in "table" or "ROCK". How could you deal with this?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/AaratiAkkapeddi/wdi-fundamentals-rps/commit/513966d581bcebf19c934443d8467d8d546d3298#commitcomment-11267692>
>> .
>>
>
>
>
> --
> .:°·ˇ*‡°˙∆¬˚˜˙…ˆ¨•\¬¨ˆˇ‡°∆˙°‡*ˇ·°:.
>

--
.:°·ˇ*‡°˙∆¬˚˜˙…ˆ¨•\¬¨ˆˇ‡°∆˙°‡*ˇ·°:.


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1658 of 1658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is good, but in the future you may want to think about special cases where the user makes an error. What happens if they capitalize 'ROCK' or if they enter a number? You may want to define exactly what you are looking for and keep asking for input if the user doesn't give you a valid format.

```js

if(typeof(move) === String){
        move.trim();
        move.toLowerCase();
    }

    if((move=="rock")||(move=="paper")||(move=="scissors")){
        return move;
    }
    else{
        console.log("Make a valid move.");
        move = getInput();
        //recursively call getPlayerMove to get a valid move.
        move = getPlayerMove(move);
    }
    return move;
 }

```


Not that I have a problem with the decision, but I am curious as the specs in this repo are pretty dull. Why was this deleted?


Yeah I know. tried that. But still it was looking ugly. Both generates the
same pseudo code so I am not that concerned.

On Mon, May 18, 2015 at 9:57 PM, Yinan Li <notifications@github.com> wrote:

> You can always wrap a line if it is too long. Anyway, it's just a matter
> of style.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/suvodeep-pyne/gobblin/commit/64ada7e4380d22a15d6699ea297f1b41c7e5377a#commitcomment-11254292>
> .
>


Both the getInput() and the randomPlay() function return something. Right now, their return values are doing nothing. You need to actually do something with them. In this case, you would want to send the inputs into the getWinner() function. That function will take the players input and the computers choice and figure out who won. Then, that function will return a string of who won. You would want to take who won and increase the playerWins or computerWins variables by one. Heres a good solution:
``` javascript
  var playerChoice = getPlayerMove();
  var computerChoice = getComputerMove();
  var winner = getWinner( playerChoice, computerChoice );
  if(winner === 'computer'){
     computerWins += 1;
  } else {
    playerWins += 1;
  }
```
Notice how I am not calling the getInput or randomPlay functions at all, as the getPlayerMove and getComputerMove functions do that for you.


Not that I have a problem with the decision, but I am curious (the specs in general in this repo are lacking). Why was this deleted?


Right now, your program is just a bunch of function definitions. You need to actually call the playToFive function in order for it to start running.

``` javascript
  playToFive()
```


yeah, def youtube version


This version has built in break handling.


@dentmaged So, it should be ```TeamUtils.getTeamByPlayer((Player) sender) != null```?


Why do you call `[self.tableView reloadData];` every time the user has selected a new category?


Also update json/image url calls to use curl.


More javadoc cleanup needed


I don't think we actually need to change this to a different key any more.

Specifically, `url` will be what is clicked for all clients, and `displayUrl` can optionally be used for aesthetic reasons for clients that opt to do so.

If we started from scratch, we may make `url` a different name, but the migration overhead is not worth the change.


1836664-ReturnWaterTempReset (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1664 of 1664 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


saw approval from jonmeredith, jonmeredith
at https://github.com/basho/riak_kv/commit/e973af0f3ecd12c94574d79bb967c557e02f40e5


merging basho/riak_kv/rdb/bug/gh-kv-1103 = e973af0f into borshop-integration-1115-rdb/bug/gh-kv-1103


basho/riak_kv/rdb/bug/gh-kv-1103 = e973af0f merged ok, testing candidate = 32cd690e


You ignored all `.yml` config files hm, I would recommend going for the exact file.


For Lenovo Thinkpad T430s with WiFi, webcam, SD card reader enabled.


Still want this? Give me some guidelines and point me to the file that I'll manage to do it soon (I believe). I don't have a UNIX environment anywhere, so I hope that you don't require me to build this project to test my changes, OK?


не могу понять зачем?


The category_id is hardcoded. It should reference the category you created on line 10 or earlier. Save category on line 10 to a local variable and use it elsewhere.


TIL. Thanks


You've missed a tonne of line delimiters (the \ signifying a line break) in three files that are core to this project. Thanks for the help but I get the feeling you didn't read the output of your formatting utility, and you definitely didn't test those cases.


Also these 4 lines 14 - 17 are wrongly indented.


Shouldnt it be typed `callable`?


я думал для каждого клика создавать вы будете экземпляр


This example is wrongly indented.


Reason for transforming GeoJSON to 4326:

https://github.com/geojson/draft-geojson/pull/6


Why revert these change ?
I need to know if something goes wrond because I use it in the yunohost package.
Thanks


I didn't realize that this check is only done when nodes are not reporting status.  So, that makes me okay with this as is.


:+1: seems to work


It's unclear from the name whether this is a row or column index (I understand after reading the code that it's a row).


This describe block is not using RSpecs convention in labelling methods. `.` is for class_methods and `#` is for instance_methods. Read more [here](http://www.betterspecs.org/#describe)


I just made sure the `data` keyword will be a list. So you can just replace content with data and remove the data argument.


How would you format the price for different currencies?


Any Comments Welcome


This could be a bit simpler.

```go
m := map[int]struct{}
for _, p := range n.Partitions {
    if _, exists := m[p.Number]; exists {
        return true
    }
    m[p.Number] = struct{}{}
}
return false
```


Just take this one ;)


Wrong error message?


Bohužel jsem si toho všimnul až teď ale ten název by měl být `YYYY-mm-dd`…


Nice! Please also see this effort here: https://github.com/bgruening/galaxytools/tree/master/tools/biopython/converters


Prueba


This shouldn't be accessing `d.aggConfigResult`. If you need another formatter to accomplish this it should be passed in via config.


Please make it clear from the names which indexes represent rows and which represent columns (and source and destination as well). I shouldn't have to look up the signature of `MutableTupleBuffer.replace()` to figure this out.


In the test that passed STC/LTC, I see an additional change given below(thats not part of the pull request):
- RookValueMg = 1270, RookValueEg = 1278,
+ RookValueMg = 1270, RookValueEg = 1281,

Although it makes no major difference, was wondering if it was an oversight while merging or intentionally left out.


Potřebuju ještě v roce 2015 udělat jinou migraci která se musí provést po téhle, takže ti to rebasnu na `2015-04-28`


Carregamento dos selects de clientes e produtos


Could you update this description to accurately reflect what this does?


Since winner already retains these commented out things, could you remove all this commented stuff for brevity?


This is an alphabetical list.


The commit message is a bit of a mess; it has typos and I believe two sentences smashed together.


Nice!  You beat me to it.


Hey Alex,

we need to populate updatedAt too and we also need to select deleted posts because they can still be viewed by everyone that has an registered account (in the future at least) please checkout the changes I've made in this commit.

https://github.com/NubCoda/MEAN-Board/commit/73f5adb1b14bf5f8628f49a5bd4bde12f1910c53


This looks like a great start. The fundamentals are there, it just needs a little work on the details. Let me or Remina know if you'd like to go over some of the corrections I've made. A lot of the more difficult concepts, like the while loop, we will be going over in class either tomorrow (Wednesday) or Thursday.


"An email address of an account associated with the API key"
--> Does this work with every email added under "Team"? Or does this have to be the main account holder?

--> Why did you delete:
"An email to this address will be sent after the testrun has been successfully executed"


For each 'playerMove,' consider using ternary statements to refactor your code. With all the spacing, it's getting a little unreadable. You want to be careful when using ternary operators, because they can complicate your code, but for simple 'either/or' one-liners they are very apt! Here's a link to a guide on using them :)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator


On second thought I am not sure what the projection in of the resulting leaflet map.  The url leads me to believe the resulting map is epsg 4326 but the coordinate system defined in index.html = epsg 2272.  I tried using firebug to find the projection but couldn't find it.


Why have you use  `- (void)willRotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration`?

The application has been created for iOS 8 and above, but [the documentation](https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/index.html#//apple_ref/occ/instm/UIViewController/willRotateToInterfaceOrientation:duration:) mentions this method is deprecated.


@JaviLorbada checkmark is adding to cell only in cellForRowAtIndexPath, so I need to reload tableView to add it. I understand why you are asking, not a good solution, would be better to do this without tableView reloading by adding checkmark directly to cell.


I question the general design decision to make constructor params arrays rather than lists. Surely it's no more work to type `ImmutableList.of(0)` than to type `new int[] {0}` . Using mutable arrays forces us to copy all the arrays in the constructor for safety. Overhead is certainly not an issue when we're just constructing the operator graph!


Great catch; thank you!


would you like to submit a PR for these or should I just update them? @jfsiii


No project is shameful if we learn things from the effort. Sometimes we have to play around with things and abandon them. Everything is good. :smile:


Sometimes `op` is a function and sometimes a string.  Prefer `method` when it's a string.


good :eyes: thanks!


`Timestamp()`


@Alfalik Yep!


I think the latest lodash (after https://github.com/lodash/lodash/commit/c6ff845ecb3891089afe8b8696f7586a19452f07) fixes this and makes your old code work again.


+1.  Thank you for the feedback.  All of it makes sense.


This isn't applying styling.


Why does this work?  What guarantee is there that a newline character doesn't appear in the JSON?


Bad markup at EOL.


I'm pretty tied to base64 images.


Good job! Try using ternary operators if you want to refactor. :+1:


im not sure what you mean?


It was failing on a test. I just moved them to a local branch I have so I
could see if it was something I broke or needed to take a look at.  The new
stuff still retains all specs and such that have been added.

On Tue, May 19, 2015 at 2:21 PM, Shai Rosenfeld <notifications@github.com>
wrote:

> Not that I have a problem with the decision, but I am curious (the specs
> in general in this repo are lacking). Why was this deleted?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sensu/sensu-community-plugins/commit/af719c4a11a088ad5f601520a95ff1dd09ea31d9#commitcomment-11267960>
> .
>


OK will rename it to checkDone which is more appropriate to what it does.


Why does the base table view have header of 44 height?

When reusing this tableView there's a gap on top of the table view as seen in the following screenshot.

![tableviewheader](https://cloud.githubusercontent.com/assets/1939155/7710888/34ba5d12-fe67-11e4-8706-62b3bc0280bf.png)


This is good, but in the future you may want to think about special cases where the user makes an error. What happens if they capitalize 'ROCK' or if they enter a number? You may want to define what you are looking for and keep asking for input if the user doesn't give you a valid format.


You all fell for it :P


You can easily pick the individual versions like `revs[0].comment`. That's how lists and list comprehensions work.


> Buttons can be styled via the button widget for by adding the classes yourself

In which case you're not actually using the button widget, just the button CSS.

"for by" -> "by"

> to avoid the javascript overhead

JavaScript

> if you dont need any of the methods provided by the button widget

don't

Missing period at the end of the sentence.


Afaics, `WorldBuilder.addPlugins()` is still checking `CoreRegistry` for plugins, so I guess that needs to be changed as well.


s/pswd/absolutely anything else/.


css -> CSS

"done using the button widget" sounds odd.

Missing period at the end of the sentence.


Agreed. Although I was concerned that it was a sign of an incorrect/incomplete merge conflict resolution.


Great work  :+1:


This broke everything on my side, good job! :D
No, seriously, how is this file supposed to be here? Is it provided by libhybris? I don't have it with the latest version..


Worth doing in Tabs and Clients, if you're feeling energetic.


Usando Spring? Eita.


Yes, I'm aware of the license -- I prefer the MIT license myself.

I just always consider it polite to at least let others know about the usage / butchering of their code before I start working on it. Anyway, I _do_ intend to start working on this at some point in the future -- I already see a number of things that I would change or optimize in some way.


Apparently packetbuf_copyfrom does not copy the structs data of the structs inside the LIST_STRUCT.
Or did I do something wrong?


Why do you need a new ViewController, and not reuse the [SSASearchProductsTableViewController](https://github.com/heach/iOSAssessment/blob/master/iOSAssessment/Controllers/SearchProducts/SSASearchProductsTableViewController.m)? They are very similar.


I'm not sure how I feel about 2/3 of the markup in this demo being for CSS only buttons.


Good catch forgot to fix this in my refactor, commit coming up.


Alphabetize and remove duplicate keys.


PLEASE WELCOME THE GENERIC HELL! :fire:


Most of the comments I made on your changes to KeepMinValue.java apply here as well (which points to massively duplicated code that should be refactored at some point).


Tu tas dizendo aqui que lt recebe uma lista de haskell (`[ ]`), que contém uma lista de scheme (`List`), que contém outra lista de haskell (`( : )`) que contém dois `LispVal` do tipo `Number`, e ainda contém mais elementos (`ls`). Tu percebe? Era pra ser assim:
```haskell
lt ((Number a) : (Number b) : []) = Bool (a < b)
```
Ou seja, uma lista de haskell (`( : )`) contendo **apenas** dois elementos `LispVal`, do tipo `Number`.


Extremely important to explain what happens in the end conditions.  And tests for all helpers!


rax retry tests


This while loop looks great and works well. You could refactor the code a bit. Try condensing some of the console.logs, as a lot of them are saying very similar things to the user. This is more of a user experience thing, and it can reduce the clutter of the code to make it a bit more readable.


i.e., what does `chunk([1, 2], 0)` do?  What does `chunk([1, 2, 3], 2)` do?  What does `chunk([1, 2, 3], 5)` do?


Why do you use inheritance from [SSASearchResultDataSource](https://github.com/heach/iOSAssessment/blob/master/iOSAssessment/TableView%20Accessories/DataSource/SearchResultDataSource/SSASearchResultDataSource.h)?

Is there any other way you could accomplish the same goal?


bad spacing


Yeah, the situation is shaky. From one side the fbdev structure is described in it, from another side nobody knows from where this file is shipped. On one boards it's included with one package, on another boards in another package, and somewhere it is just there. True also that somewhere it's not there at all. So there is no clue for now to what to hook up to make it working.
But without fbdev structure and one define from the header this is not going to work anyway at all. So the define either need to be taken from fbdev_window.h or defined inside, which doesn't make much sense (to define it, and then to check is it defined and if yes - proceed).


Looks perfect!


I am going to try some values, then suggest those.


I have not found currency field in bestBuy documentation, so I assumed, that it is in dollars.
But answering your question I would use NSNumberFormatter with NSNumberFormatterCurrencyStyle.


Entendi completamente :(
Obrigada


No way to get rid of the IOAuthAuthentication generic I suppose?  Guess that's the notification type


This is the general form with `start = succeed()`, and `f: (T, U) -> Success = f(T)`, right?  Is this expression optimized in some way?


I'm not sure what was done here, but the tests above were changed from `deepEqual()` to `strictEqual()` and had the parameter order fixed (both good), but spacing wasn't changed. These tests had their spacing fixed (good), but didn't change the assertion or the parameter order.

I'm all for cleaning things up, but the cleanup should be consistent.


Can you think of a way to only use 1 console.log for whoever is winning, with the same message?


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/2035


May use .map to avoid rows.push invoking


:+1: :-)


Why was `.ui-button` changed to `:ui-button`?


Since this is a class check, why doesn't it use class assertions?


Yeah thats my bad i will fix everything here.


Cool!


I feel like some of these are not sufficiently common to warrant abstraction.  I.e., this is similar to adding `map : D<R<[T]>>` and `D<R<[T]>>.reduce`.


Explicit destroys shouldn't be necessary. Rather than fix spacing, just delete.


new lines, please.


This commit needs references to any associated tickets. Especially important for any deprecations.


What's the purpose of this `NS_ENUM`?

Is there any other case than `SSALoadingCellStateLoading` being called?


The code is great, and its logic is sound. The only room I can see for improvement would be to limit the amount of logging to the console you do. Some of the above console.log statements could be refactored into fewer. Let me or Remina know if you would like to go over some of the code together.


Why not class assertions?


Some dedication with the indentation there!


explicit destroy


@jasnell no, it doesn't to my knowledge


I am fine with you continuing work on this project. I am unable to contribute to it any further.

You should be aware however that not all the code is mine. As mentioned in the README, much of it came from a post by Howard Jeng ("SiCrane"), resulting in the grand majority of what's in lib/ now. He never responded to my requests for comment on the project, and since his code is MIT licensed, I have to assume he is fine with the code being used for this. But just FYI.

If you would like, I can transfer ownership of this repository to you, that way the users don't have to follow forks to figure out who is the new maintainer. And since I can't contribute any more, there's no reason for it to stay on my account anyway. (And I have backups of the repo if we should ever need them.) I can also transfer ownership of the [rubygem for rvpacker](https://rubygems.org/gems/rvpacker/versions/1.2.0) to you, as well, since I won't be publishing any new builds.


you also reverted plugins/cck_storage_location/joomla_article/joomla_article.php
 change that fixes notices


@jborg Would you mind adding a few more comments here explaining the changes? Just from the looks of it the major change is that instead of opening an hash index and keeping it open for read/write you now perform read and write operations atomically without keeping the hash index open. But I might be completely wrong here. ;-)


Are those included in Galaxy anywhere? If not I may make a PR with those as datatype converters if that'd be OK.


Why does `SSASearchProductsTableViewController` implement `<UISearchBarDelegate>`? Instead of abstracting this delegate as a new class same way as UITableViewDelegate and DataSource?


Addressed in 8dfc0f39236f23d1dce4ce7540e47262dab3c41e and ba06d5de8fc317e9656e7ec52b322266361c0817


Extraneous space after the colon.


Addressed in d77bcffee9acb5ddcb57bfd805c2470f0de7fca7


Was the state intentionally changed?


Thanks.

This sort of structure is needed by multiple functions (like the default value in [zeros](https://github.com/josdejong/mathjs/blob/v2/lib/function/matrix/zeros.js), ones, diag, etc.), maybe in the future we can put this in some shared utilty function `createValue(x: number)` which returns either a `number`, `BigNumber`, or `Fraction` depending on the config.


Done 8d0c4cc


Thanks :).


Can we get a support comment on this?


Remove this since the styles changed.


@iamvdo do you agree?


This comment is very odd now that there's no width above. Does the following rule even do anything at this point?


you can save yourself a lot of heartache and processing power by switching up this order


Yes, this is an attemp to try your suggestion, thanks for it!

Re: suggesting values -> maybe you could consider compiling stockfish yourself (it is not so hard) and testing the values in fishnet? Then you would know how to do it for other patches and could try your other improvement ideas too :-)


missing space


Ooh, tricky. Good thinking.


Cool, wird gleich getetstet ;-)


Why using new document array LMAO


It's worth noting that changing this function requires to refresh stats.

By the way @ta2-1, I see `refresh_stats_rq` doesn't contain `--calculate-wordcount` or `--calculate-checks`. Is that temporal or what's the state? Currently it's confusing to see two commands that do the same but one is lacking flags.


Are these still needed? Can we get support comments on them?


Are these part of the public API?


Looking good! I guess :smile:


I had a simple `<-grid>` which was initialized using the light DOM with two rows. Without the changes, the grid height was set to the default height of 10 rows. After adding the first `grid.then()` call, the height was set correctly to two rows in about 5 times out of 6. Adding a second `grid.then()` call improved the odds.

There seems to be a huge amount of timers being fired during initialisation phase that `grid.then()` doesn't behave as you would expect.


In that case then, I'd prefer something like:
```
if (process.env.VCAP_APP_HOST)
  app.set('host', process.env.VCAP_APP_HOST);
```
To make it clear.


Remove commented out div?


So in my prototype, I kept empty named classes still to prevent the generic hell a bit...

So you have  friendly alias like FacebookAuthenticationNotifications which is just an empty derived class which hides the generic hell :)


:+1: for namespacing


You can update them. I just wanted to point them out.


this would havebeen a working solution for question 5 if you had set `newHash = {}` and had returned `newHash` after your enumeration


Pure refactoring to use Polymers `toggleClass()` method instead of `classList`


Checkout this commit and load the demo. There are no styles applied to the elements.


What the background of this change? Google did not bring up reasonable results


there is the same string name two times. This currently breaks the build of the app.


Merge branch 'master' of https://github.com/Diotima/codingKatas


I think the "especially in the shortlog" is very much redundant now.


youre still returning the original array here


Looks good otherwise.


Without taking a position on the comment indentation/positioning, I'd suggest that the comment should be updated to explain the purpose of the comparison to `'r'` a little better (namely, that wallet addresses start with `r`).


Nice edits here.

This is good, but in the future you may want to think about special cases where the user makes an error. What happens if they capitalize 'ROCK' or if they enter a number? You may want to define exactly what you are looking for and keep asking for input if the user doesn't give you a valid format.

```js

if(typeof(move) === String){
        move.trim();
        move.toLowerCase();
    }

    if((move=="rock")||(move=="paper")||(move=="scissors")){
        return move;
    }
    else{
        console.log("Make a valid move.");
        move = getInput();
        //recursively call getPlayerMove to get a valid move.
        move = getPlayerMove(move);
    }
    return move;
 }

```


here is the file


Excluded any code that used get_cpu_idle_time (due compiling error)


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 10](https://teamcity.labkey.org/viewLog.html?buildId=250859&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **SUCCESS**
Summary: Tests passed: 26 Build time: 00:44:55


I came to it all by myself :P

`VARBINARY` is to `BLOB` what `VARCHAR` is to `TEXT`.

What we are storing in the case of uris, identifiers, email addresses is not a UTF-8 (or otherwise) text string. We are effectively _just_ storing a series of bytes.

These series of bytes are never collated based on locale, they are never converted to a different encoding. They must always be 100% retained.

For those types of strings `VARBINARY` is simply the most efficient storage mechanism. It's "one byte per byte" instead of the default "3 bytes per byte" for `VARCHAR`, it has no unwanted side effects and it's in theory the fastest.


For each 'playerMove,' consider using ternary statements to refactor your code. With all the spacing, it's getting a little unreadable.

For example, you could refactor your first 'else if' statement to be

```js
else if (playerMove === "rock") {
     computerMove === "scissors" ? 'player' : 'computer';
};
```
You want to be careful when using ternary operators, because they can complicate your code, but for simple 'either/or' one-liners they are very apt! Here's a link to a guide on using them :)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator


Why not gsub!(/^Started/, "\nStarted") instead?


Pacman?! That's an arch package manager.  If you are referring to the git repo try rebasing or doing a git pull.  Make sure you aren't on a wrong branch?


I'm currently proposing that we get rid of `mmap_array` so that this isn't possible, but it would probably still be good to handle this case on Windows. Maybe @vtjnash knows the C magic to handle this for windows?

```julia
f = open(file, "r")
m = mmap_array(UInt8, (10,), f)
m[5] = 5
# segfault that mentions EXCEPTION_ACCESS_VIOLATION
```


Is this a working copy? Just tried it without any luck, but that might be on my end?


Line 364 : Excluded any code that used get_cpu_idle_time (due compiling error)


hey cool ist jetzt wirklich besser ^_^


Because there are multiple columns. We need to check column 2 even if `t1 == t2` for column 1. We can only return `false` when all the columns are equal. (same below)


Line 535 and 536 : Excluded any code that used get_cpu_idle_time (due compiling error)


And OTOH, given `assert("" !is null);` passes, I would feel very surprised, as an user, to have the generator returns something when my string `is null`. Checking for non-empty string when there's a possibility for it doesn't sounds like a burden to me.

> Having optional `out` parameters will be, I think, a relatively rare case.

And returning an empty string from an `out` parameter will be even more rare.


Updated by syamala


Text will always be true: line is always defined


Should this be changed to use `refresh(false);` ?


Thanks! (I use "indexes" as the plural for database "index", so... indices here)


How would you do that? The original plan was to include them in Galaxy but biopython is not a dependency of Galaxy, so we postponed this ...


ok


Put fast condition first?    fast || slow  instead of slow || fast


Thanks @martincik, I see someone was faster than me to notify you. I am glad you liked it.


what happens to found_meth and found_ctrl if there was no match? They keep their values from previosu cycle?


Everything looks pretty great. I actually can't leave comments on any line because of the way commits work. The only thing I would say that could be improved is checking the user input to make sure its valid, even not caring whether or not they capitalize a letter(s). That wasn't part of the assignment, but it might be a good exercise if you wanted to go back to this. I like the playTo function as well. Good job.


Since 'playerWins' and 'computerWins' are just returning numbers, you should specify in your string which score is which. Labeled scores will be easier for the user to understand. For instance...

```js
console.log('The score is currently\nPlayer Wins:' + playerWins + '\nComputer Wins: ' + computerWins + '\n');
```


HI!,

Having a little trouble compiling this.  SUBTARGET=arcade works, but SUBTARGET=mess and plain make does not.  drivlist is complaining about undefined reference to `driver_funrlgr'.

I think there is a typo in src\mame\mess.lst, line 2142.  Changed "funrlgr" to "funlrgl" (locally only, made no attempt to fork)

That let SUBTARGET=mess compile, but plain make still not working.

Deleted build\generated\mame\mame\drivlist.c, plain make works again.

Just a FYI for anyone with compiling issues.


@akesterson - That would be great, thank you -- I actually just forked it moments ago, so shall I go ahead and remove the fork?


This was almost 6 months ago, so I can't remember all the details around this removal, but it was breaking stuff. Please open a new issue detailing your use and the breakage and we'll investigate solutions.


This store method by now only is useful for adding new documents not for updating them isn't it? It always call _dataContext.Add(document). Don't you think IContentStore should offer two separate methods? An Add(document) ann an SaveChangesAsync method =


Looks good! :+1: I added some suggestions for refactoring and a couple of usability considerations.


1) Po co ci parametry coordinate, title i subtitle, skoro ich nie uzywasz w konstruktorze? wywal to zupelnie.
2) coordinate, title i subtite zamiast mogly by byc "computed property", by bylo ladniej.


Yeah, this solution for propogating packages is a bit of a hack (I'm duplicating code that already exists), but in the scope of the MultiColumn/Row feature, I decided to stick with this solution.


d


Thank you for contribution!


Is this still true?


Missed that, thank you for pointing. This method should be replaced with `viewWillTransitionToSize:withTransitionCoordinator:`.
But problem, that I was trying to solve is caused by parallax library, that is not supporting landscape orientation. I took solution from this pull request: https://github.com/apping/APParallaxHeader/pull/26, but forgot about deprecation.


V poriadku.


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1658 of 1658 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


![image of mothefucker](http://ultimatepoker.com/wp-content/uploads/2014/02/we-have-a-badass-over-here.png)


Hello Dusan, did you base your branch on rel-4_0? It should be based on master.


I'm not an `as!` fan -- consider wrapping everything in an `if let` block.