Is this the right place for this function?  I'd expect the function to be named `toString`, declared in `AnyPublicKey.h`, and defined in `AnyPublicKey.cpp`.  Located in this file it's less likely to be found for reuse if someone needs it.


The above if/else blocks can be consolidated as follows:
* Declare a variable for holding the find query such as {"State": state};
* Use your if/else blocks only to formulate the proper query
* And use only one call the mongodb using the variable you set in the first two steps to keep your code [DRY](http://en.wikipedia.org/wiki/Don%27t_repeat_yourself)
```
var locationQuery;
req.db.collection('markets').find(locationQuery).toArray(function(err, items) {
   ....
});


It looks as if `extlib` is only required because it's a dependency of `google-api-client` and its dependencies. If we end up removing `google-api-client` (see https://github.com/alphagov/smart-answers/commit/c0e66ce2f0faa4b113f1fb028185ad4ed9b98661#commitcomment-11285386), we could almost certainly remove the explicit dependency on `extlib` added in this commit.


Was fixed in subsequent change.


Same.


This is a nit, but shouldn't this be a setter method named `setUserError(Boolean)`?


Everything else looks good. I will go ahead and merged this in and you can address the comments with the next pull request.


Do we have to use the ng prefix now? Shame if so.


please name methods with small letter at the beggining


/stylesheet-without-issues.css:22:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:27:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:33:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:39:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:45:5: Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)
/stylesheet-without-issues.css:48:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:52:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:68:5: Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)
/stylesheet-without-issues.css:73:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:77:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:90:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:93:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:96:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:100:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:103:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:107:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:108:5: CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)
/stylesheet-without-issues.css:110:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:111:5: CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)
/stylesheet-without-issues.css:113:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:141:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:144:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:147:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:182:5: CSS outline not supported by: Opera Mini (5.0-8.0)
/stylesheet-without-issues.css:184:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:200:1: CSS3 selectors not supported by: IE (8)


/stylesheet-with-issues.css:44:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
/stylesheet-with-issues.css:45:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
/stylesheet-with-issues.css:46:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
/stylesheet-with-issues.css:53:5: CSS outline not supported by: Opera Mini (5.0-8.0)


Can't figure out how to clone this branch to test it out. Sorry for all the hand holding you have to do with me.


closes #11
closes #6
closes #3


removed


please name methods with action, do not use Continuous for this


Please use ".ct" for counting tables, '.kh' is no more :-)


Скорее стоит назвать его `io_tools` или что-то подобное с `io`


Nice catch, thanks!


Use assertThat methods on *Test level. From *Steps level return all needed information and perform all check there.

What returns method getSignedUpassert() - its not clear from the name


Можно сделать так: завести функцию `all_tests`, в которой сделать вызовы всех этих методов, поместить её в начало файла. В конце файла вставить стандартное условие `if __name__ == '__main__'` с вызовом этой функции. Тогда сразу будет видно все запускаемые тесты


Send report to the GitHub guys, lets see, maybe it is a bug. Have a nice day and sorry for been bothered by me :)


CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
CSS outline not supported by: Opera Mini (5.0-8.0)


CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS Generated content for pseudo-elements not supported by: IE (8)
Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)
CSS Generated content for pseudo-elements not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 selectors not supported by: IE (8)
CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)
CSS3 selectors not supported by: IE (8)
CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)
CSS3 selectors not supported by: IE (8)
CSS Generated content for pseudo-elements not supported by: IE (8)
CSS Generated content for pseudo-elements not supported by: IE (8)
CSS Generated content for pseudo-elements not supported by: IE (8)
CSS outline not supported by: Opera Mini (5.0-8.0)
CSS Generated content for pseudo-elements not supported by: IE (8)
CSS3 selectors not supported by: IE (8)


@tststs
I haven't worked on this for a while. If there's a bug related to this please point me to it


@rec if `RippleServer` raises, then you'd get a use before set error in the finally block.


Числа, если их значение не сразу понятно, стоит передавать в виде именованного параметра, чтобы читающему было проще понять их назначение


Version Two - car images embedded, color, text font...etc.
Available for downloading


Might put together a launcher to build a private server? since I'm looking for that , if you succeed I could host it . and we would become $$$$ . If you need help, I can help you I have some knowledge of C ++ and .NET


@brew If everything went right (which it should) `config` and the db should have the same value, as both are set when updating a config option and on startup. Also this check is always true isn't it? You've already check that `key` is in `schema`.


You're very welcome! Sorry for the mistake. I [pinged them](https://twitter.com/mgechev/status/601038240511086592) as well.


Смотрела библиотеку `unittest`?


Version 1
Only textlabels


@wbond commenting here to inform you that this file is still referenced in the channel (and not https://packagecontrol.io/packages_3.json)


yeahhh


Yes, see: https://github.com/angular/angular/commit/d310a9c0b466407ddce0babdf36d7e4c2476cae3


Show message "Loading..." while "Authorizing.." is not translated


OOPS! removing this now.


não sei pq não funcionava o de cima, mas meu amigo me ensinou assim:

`eqv ((List a):(List b):[]) = Bool (eqvList a b)
eqvList :: [LispVal] -> [LispVal] -> Bool`
eqvList [] [] = True
eqvList _ _ = False


Oh, HipChat zeigt auch die comments zu commits an. Hallo!


:scream:


Ah, cool, I didn't know that. Thanks! Updated.


@brew We want to check which config options can be edited to decide which ones to show, so I wouldn't create a dedicated show schema, as it will be confusing. Also we should now use `ckan.logic.schema.update_config_schema`, which will incorporate changes from extensions.


哈哈哈


Ok so making the assumption you are on a checkout of your fork.

```
git remote add upstream https://github.com/pithos/pithos.git
git fetch upstream
git checkout upstream/wip/headerbar
```


this commit changes the standard select image to "selectedblue.png"


Got it. Looks A LOT different.


I tried that at first before connecting the expander to actual memory; didn't work.
I tried exporting it to toplevel.vhd(no connections) that didn't work either :disappointed: .
Okay, in the mean time if I find something, I will let you know.
I will incorporate these changes while integrating review comments from Josef! :thought_balloon: .
Thanks.


kkkkkkl;


This was needed for #59 .


Thank you for your effort!


This is interesting. Did you stumble upon this and include it for 'fun', or was this a requirement that you had?


Aha, good catch! Sorry I hadn't seen that.


Очень даже. Хотя отсутствие хотя бы намёка на вторую ногу озадачивает.


An accidental syntax error: "gcnew" should be "new"


Ubuntu mutilates it I'm sure...
![screenshot from 2015-05-20 10 06 58](https://cloud.githubusercontent.com/assets/6667703/7729033/2b3563e2-fed8-11e4-8696-b68888c3c4f4.png)


@skalk: A minor issue. In the short term, I would remove ´´base()´´ as it does the same as ´´addr()´´. In the long term, I would replace ´´public: buf[]´´ by a ´´private: _base[]´´ and make it accessible via a conform accessor ´´base()´´.


TeamCity Ybackend :: synteny/ybackend [Build 26](http://192.168.30.225:8111/viewLog.html?buildId=1243&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


That doesn't look correct.  Shouldn't vec be set once per page, not per byte?

Also, one could argue that especially on Xen where zero pages are faulted in the trivial implementation is not entirely correct -- and even on baremetal we know if an address is mapped or rubbish -- but I can't think of a huge downside to lying like that (as long as the implementation doesn't stomp memory ;)


Yeah it might be nice. If you don't might I can figure out how to add
this there and provide PR for docs then.?

On Tue, May 19, 2015 at 2:22 PM, Tomaz Muraus
<notifications@github.com> wrote:
> This document is nice and useful, but I don't think it belongs into
> this pack.
>
> It looks like something which should live in the StackStorm
> documentation (e.g. here -
> http://docs.stackstorm.com/history.html?highlight=logstash#logstash).
>
> —
> Reply to this email directly or view it on GitHub.
>


Sure does... Normally the icons are bigger and the close buttons are on the right.


Since webjar action blocks until XWiki instance is initialized this change make the display of the loading screen block until XWiki is loaded and make it totally useless...


There seems to be a lot going on here.

Source is an ActiveRecord object, it also has all the responsibility to perform the rake task.

Between
Source has_many :source_items
and the instance level fetch!, which updates or creates SourceItem but doesn't add them to the client instance of the Source object. I get confused.

I'd suggest lifting fetch_all out into a Task object, rather than confusing the Source model and adding those source items created to the source instance.


What does it look like on GNOME proper?


Hmmm.  `logAction` is a function at namespace scope, right?  There isn't anything in the parameters that constrains `logAction` to only operating on `Manifest`s.  But it's clearly intended only for `Manifest`s, since "Manifest" is the first text it streams.  Given that, I'd suggest renaming `logAction` to `logManifestAction`.


Ne pas commiter ce fichier.
Il est propre à chaque machine.


Will have to look into that :)


!  Interesting recommendation but someone's been thinking too hard.

    class CheckoutPort(object):
         def __init__(self):
             self.rpc = 5005
             self.peer = 5125
             self.wss = 6006

        def increment(self):
             self.rpc += 1
             self.peer += 1
             self.wss += 1

    CHECKOUT_PORT = CheckoutPort()

Less code, no decorator - and no adding attributes onto a function, which is unexpected...

In particular, the fact that you pack everything into an anonymous tuple at the end is unaesthetic...


I find this sort of inline documentation referencing other documentation to be helpful.


![pithos gnome](https://i.imgur.com/FTsvY7X.png)


You should have uECC_compute_public_key() return an int (true or false), and return 0 in the following cases:
 * If the private key is all zeros (vli_isZero() returns true).
 * If the private key is larger than curve_n.
 * If the resulting private key is zero.

Basically do the same checks as uECC_make_key() does, but just return 0 if any check fails. Return 1 if all the checks pass.

You can then refactor uECC_make_key() to use uECC_compute_public_key().


Lovely and simple, no room for it to go wrong and making all of the work testable.


Ma nel multiplayer la readsequence sarebbe uguale a quella del single!
Anche le altre funzioni cambierebbe solo la loadserver response e
bisognerebbe aggiungere uno o due switch alla dotherightthing.

Comunque ufficialmente inizio il multiplayer.
Il single è a posto tutto, pupi giusto modificare gli stili etc. Ma l html
e gli script sono a posto
Il 20/Mag/2015 16:37, "ghia16" <notifications@github.com> ha scritto:

> Igor considerato che dobbiamo aggiungere il multiplayer non ci conviene
> isolare le funzioni di lettura delle sequenze in un un altro script?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/igorravasi/Memo/commit/8b80b88852814989004f465b8ed136f100442268#commitcomment-11285334>
> .
>


develop (lefticus) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.86%25-red.svg)


Much better. Still don't know about the button for stations though?


Consider that icon just a test :P


The hash strategy could be used outside of JDBC. Would be nice to move it outside of the JDBC package


Please make sure we have an issue to go with the bug description


In the log - you mean the rippled log, yes?  So we parse the freeform rippled log and extract these numbers out of it?

So these aren't really "ID"s then, are they - they're actually error codes?

Shouldn't they be strings, then?  We have access to both sides of the code - communicating through an integer code is obscure and prone to error.


Ok, new version is up, now that I've discovered the `-f` flag and the difference between pushing and committing.

I don't _actually_ want to work on the bad captcha issue, partly because I don't think anyone would ever use an image link, and partly because "bad captcha" is actually pretty descriptive-- it'll lead you to thousands of discussion pages on why you'd get a captcha on Reddit. I just didn't want to seem amateurish by ignoring it =p


a small comment to explain that there is no need to visit expression.


jQuery has `$('#chatArea').toggle()` for this exact purpose.


Still wondering about this.  How does this program fit into the entire Ripple infrastructure?  Is there a publicly-facing document on this?


ok no problem not making the int const.


issi ho visto che funziona tutto, intendevo dire di separarli giusto per una questione di ordine. comunque se inizi la parte server cosa possiamo fare nel frattempo? a parte gli style ci sarà da creare uno script che gestisca la partita multi no?


With the upcoming unification of the API across the various kernels, we will revisit the message-buffer interface anyway.


bianchi fabrizio
monticelli d'ongina (PC) Emilia Romagna Italia


:wave: :earth_americas:


The icon it's self is not the problem. Can you turn the station name into a dropdown?


I would like we remove it one day....


>It's not wstring!

Oops sorry. QtCreator via 'Follow Symbol Under Cursor" dropped me to the wstring signature.


Why we need that?


TeamCity Ybackend :: synteny/ybackend [Build 26](http://192.168.30.225:8111/viewLog.html?buildId=1243&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:08:53


If the icon was changed back to the current layout of a station name drop down it is just far too wide. It is possible to do some fancy things where clicking on the title turns into the drop down, but I feel that is a hidden feature while space efficient.


я бы "намекнул", но тогда свинья не будет в равновесии. а животное слишком массивное для балансов. передняя правая нога просто закрыта рылом.


:+1: I like. I'll take a look at the tests


It's fine now: https://ci.appveyor.com/project/ionelmc/cookiecutter-pylibrary/build/master-112


See epiphany for an example of what i mean, or I can do a mock up.


I'm wondering if `isValid` might be a better name than `verify` for this method.  I'm just thinking about how the text will read at the call site.  Your call.


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.29%25-red.svg)


IMO you can't use the same code to check for role and permissions. the reason is that when you check that a user has a specific role, you can do role.equals(anotherRole).
However when you check that a User has a permission you can't do this. => Lets say I am an admin, I've got one permission '*'meaning I can do anything I want.
If you check that I've got the permission to create users ('users:create') it should return true, it's not a strict equality. the fact that you got '*' implies that you've got the permission 'users:create'.


博客地址：http://www.cnblogs.com/nalixueblog/


> So I'd like to jump through the hoops of calling subprocess.check_output rather than calling the python code directly.

But you are testing a part _that isn't involved_ in normal operation of the code!  I mean, what are you expecting to catch with this that would actually affect the user?

> "what's the point of the command line arguments?"

You're calling argparse, which parses the command line arguments that are passed to this file.  But it appears to be a Python unittest file, because it starts with `test_`.  Unittest files are generally called _en masse_ from `python -m unittest discover` so you don't get to set a command line argument.

I'm actually believing that this isn't, in fact, a Python unit test (if nothing else, you aren't importing `unittest` so `discover` won't find any of your code).  If so, you should rename this file to not start with `test_`


But is it programmatically equivalent? I think most users when thinking "NULL terminated string" they're thinking `'\0'` not zero. I could be wrong.


throws an error if the vm does not already exist. Should add 'boot2docker init' if this is a fresh boot2docker install


And similar issues inside bittorrent, http, net and utils fixed too.


Ok I am all set. You may proceed with your squash


Quello che dicevo è che quando faccio il multiplayer si divide in 2 parti
lo script del single: 1 con tutte le funzioni di gioco e 1 con http get e
load server response. La prima parte sarà la stessa anche del multiplayer
(la seconda cambierà), perché comunque per l utente multiplayer o singole
Player non cambia a livello di visualizzare e inserire la sequenza.  Ci
saranno solo più tipi di messaggi e quindi viene cambiato lo switch ma sarà
lo stesso anche per il single (che semplicemente non riceverà messaggi del
tipo "l altro utente sta giocando" e dunque non ci sarebbe differenza ).

Per il resto la cosa più importante è sistemare gli stili e gli script
togliendo bootstrap
Il 20/Mag/2015 17:15, "ghia16" <notifications@github.com> ha scritto:

> issi ho visto che funziona tutto, intendevo dire di separarli giusto per
> una questione di ordine. comunque se inizi la parte server cosa possiamo
> fare nel frattempo? a parte gli style ci sarà da creare uno script che
> gestisca la partita multi no?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/igorravasi/Memo/commit/8b80b88852814989004f465b8ed136f100442268#commitcomment-11286271>
> .
>


What about "Simulate 3 non-existing processes."?


:ok:


Great :dancer:


Thanks Nate,
I copied what you did on Ben's dog and pony show, except for the part where I forgot to ignore uploading the keys.js to github. Arg! I thought your solution was interesting by creating a new function object.


Me too.


Well spotted, fixed in 5b67bc5 I hope...


I was more thinmking aboiut something like `_process_queues will only use len(...) to determine number of processes`


в принципе, уже теперь вижу, что можно слегка угол копытца вывести из рыла внизу -- оно МОЖЕТ быть видно. в этом нет ничего сложного, я подумаю еще над этим.
оно ведь как бывает: смотришь до отправки на сканер -- вроде все нормально. иногда только после сканирования видны некоторые моменты, а иногда и после отправки в ресурс и сторонней критики. для этого же и выкладываю.


Let's see a mockup. Here's a quick and dirty version of what I was talking about. But really the station name could be the button.
![quick and dirty](https://cloud.githubusercontent.com/assets/6667703/7729432/53356f7a-feda-11e4-932a-6b57d18cb03c.png)


ok allora inizio ad alleggerire un po' il progetto eliminando la roba di troppo negli stili


Perhaps you could elaborate on this?

It seems to me you are referring to wildcard permissions or some kind of hierarchy of permissions?


You currently require the before() method to be located in the same class as the method being called.
Was wondering if it wouldn't be better to also offer an option to specify a different object?
So one can assign an external class to handle authentication.


Ah, got it, now I see you're building a huge list of filenames of all types.

You should still use `os.path` to join file path parts. https://docs.python.org/2/library/os.path.html#os.path.join  Yes, Python is often smart enough to handle the wrong sorts of slashes, but `os.path` handles all sorts of cases like drive letters than you will never have to think about if you consistently use it.


@skalk: Minor issue. I would name ``cap_rcv_window(size_t cnt)`` and ``cap_rcv_window()`` according to the accessed variable as they are mere accessors.


Bravo, anche i launchbotton css visto che non servono più mi pare.

Ah l altra cosa è magari di posizionare il bottone start in un posto più
carino, magari nella barra menu, a destra
Il 20/Mag/2015 17:24, "ghia16" <notifications@github.com> ha scritto:

> ok allora inizio ad alleggerire un po' il progetto eliminando la roba di
> troppo negli stili
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/igorravasi/Memo/commit/8b80b88852814989004f465b8ed136f100442268#commitcomment-11286519>
> .
>


unused import ?


if ($project->servers->count() > 0) { // FIXME: This should filter to deployable servers


Looks like this return got erroneously chomped off in the merge.


and will add cap fill additionally to close


howdy can fix this? accidentally got merged into master.


As discussed


Here's the error:
http://upaste.me/070119313767738b0


Side note: We can copy/paste the code of the class WildcardPermission from Shiro to do the job.

Thinking about this more and IMO, a specific implementation of the interface User should be able to extend a base class that provides a base implementation for hasRole(..), hasPermissions(..) don't you think?


this is the only place it's used..
https://github.com/dorimanx/DORIMANX_LG_STOCK_LP_KERNEL/commit/da1b7464b3d498f95c65d4533b8cd3bba6ba277d

and i not sure that it's all the needed.... we should also register it and unregister...
i dont really understand the logic of this driver...
https://github.com/dorimanx/DORIMANX_LG_STOCK_LP_KERNEL/commit/dc2ce26f7c1c7477cc7e552cb29c954c6dd21f01

I it's should help with quick suspend... not wakeup. and allow to wakeup (screen off) do tasks, and drop to suspend fast as possible...

but i am not sure that it's working at all...


@skalk: Addition. Minor issue. In general I collect accessors under a
```
/*
 * Accessors
 */
```
mark at the end of a class without dedicated documentation.


Actually there is a bug in here... (maybe that is what you are referring to?).

We should have a roles_permissions table not a user_permissions table as the association is between roles and permissions not users and roles.


magen wuna weradda mokadda
why all fo these sudden changes
i wanna know
why aren't you beleve me
whats the wrong with you
whats on your mind
please tell me
why are you try to leave out me

sorry for late I didn't try to get revenge
but my internet connection is very slow


Protótipo Funcional do Aplicativo


Can you remind me who tested the NAG compiler? Should we add this to the top of the README.md where it lists intel ifort and gfortran as the only working compilers? Also update to say that it works with gfortran >= 4.9.2?


This commit removed our previous comments on that line !


mmm per il tasto start cerco qualcosa, in alto a destra mi sembra un po' fuori scena ma vedo cosa si può fare


OBS: la guarda del while da siempre true porque no hay ningún i++.


Since `expect` is part of testing, it should be added to [this](https://github.com/School-Improvement-Network/coding-conventions/blob/master/.eslintrc-test) file.

Why does angular need to be global? What problems are you running into?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1432135803108
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


might make sense to have an object.display_name or object.list_name for the kinds of objects that appear there, and then call that from format() and from search, since it feels weird to return an unformatted string from the format method


@JasonLG1979 ^


and thanks for the quick fix on this!


Looks good, thanks.


oops, might be


/lole,kd,scoqlp


*だいぶすっきりしますね！カラムの型については、その気になればisinstance()関数を使って自動的に設定することも出来るのでしょうが、冗長になりますね。

*%sについてですが、str()をかませるのは、pythonコード上で文字列であるクエリ文に挿入するためであって、そこから発生するMySQL上のクエリ文中においてVALUES()の中身が文字列であるためには、シングルクオートが必要なのではと思ったのですが、どうなんでしょう。

例えば、
`
for row in reader:
    QUERY = "INSERT INTO rating_final (userID, placeID, rating, food_rating, service_rating) VALUES('%s', %s, %s, %s, %s)" % tuple(row)
    print QUERY
`

の実行結果はpythonがMySQLに送り出すクエリ文を表示しますが、

>INSERT INTO rating_final (userID, placeID, rating, food_rating, service_rating) VALUES('U1077', >135038, 2, 2, 1)

となります。これがMySQL上で実行されるクエリ文ですが、VALUESの中身のうち、１つ目の'U1077'のみ文字列で、それ以外は整数とされていることがわかります。

と、ここまで書いて気が付きましたが、MySQLでは文字列の挿入の際クオートをつける必要はなく、カラムのデータ型に応じて勝手に解釈してくれるみたいですね。つまり、s%演算子の性質というよりは、MySQLの性質から、シングルクオートは取り除いても問題ない、ということみたいです。

ただ、そもそも僕が''を付けた理由は以下のサイトを見たからですが、''によってエラーがなくなることもあるようです。よくわかりませんが、いつか役立つかもしれません。
http://otiai10.hatenablog.com/entry/2012/01/09/061142


Last issue to solve: http://stackoverflow.com/questions/30303071/neo4j-pessimistic-locking-with-jdbc-driver.
Without it, there is still a short time window during which several locks can be inserted.


Typo here: LIBFREENECT2_WITH_OPEN**G**L_SUPPORT


I'm not able to reproduce that behavior. All the arguments after the script name should be ignored by the interpreter and passed to the script. `groovy somescript.groovy -v`, for example, does not trigger groovy's version output. The puppet_helper script itself does no argument parsing (everything is positional).


cool! If you can PR this I'll merge it in :)


made the code so that once the calculate TextView shows "ERROR" any button that is pressed after that will clear the textview.

also made the textView have a max Length so numbers won't continue to make TextView larger.


Actually, I don't know if we should continue with UoW, considering the specific CMS scenario. I think that deserves its own discussion, not just a discussion in the middle of a commit...


rax retry tests


No final's please


[Yes they did](https://github.com/monarch-initiative/monarch-app/blob/master/lib/monarch/api.js#L3911-3991) - I'll implement this functionality as well.


Even with the changes in https://github.com/zendframework/zf1/commit/7d8e6c6cf59ea0b5004960b8402a39f89a9e512a this still appears to be an issue.  Will test some more and file an issue soon.


You treat the error before the norminal case. It's a little harder to understand in this order.
By the way, can we do something on the 'null' return into 'preconditionExecutor.executePrecondition()' method ?
The implementation of method will become more easy.


Oh, nice catch! Thanks for the fix


You don't need the parens around the description...


I think it's ok to pass the emitting root as an argument, the method is only used for this exact purpose. I know I mentioned an Emitter metadata key, but that was instead of the Owner. I think this will be ok for now:

    e.Meta[DomainEvent.MetadataKeys.Owner] = _typeNameMapper.GetName(aggregateRoot.GetType());

And then no Emitter meta data yet, but maybe owner can be rename one day :)


Why is this test empty?


`$this->getInnerIterator()->getArrayCopy()` doesn't work?


The Choreographer here, jeje

The boring answer is that this way you get info in the log from which module you sent a message - quite handy when the time comes to debug


Ok for me after my two comments


We need to use nectar to do this. If there are auth configs, proxy settings, etc, this connection needs to use them.


I'm surprised that Not doesn't still have to be nested.


...or parens around the help... and this continues.


That can be improved to use optionally another object. Don't hesitate to send a pull-request if you need that.


你叫鸡子改改


I wonder if making string like "Event Send Event to Pending Queue" class constants would be better.  what if they change?


:-1: Must verify that it resolves.


@cmherd DWMR (done with my review). Looks good. Press on!


Yeah but will it change the structure of anything


Interesting... -v would cause the same behaviour in my platform though ("-v" is not a valid option). I'm wondering if it's something platform related - what platform are you using? I'm on bash 4.1.2, centOS 6.6...


As far back as 23.2, yeah https://github.com/magit/magit/blob/master/README.md


I think I'm missing something. Motors is not exposed to the user (nor is ESCs, or Servos) so how would the docs change?


I wonder if this test could be cleaner if we had a toArray() method on TalkSubmission and then the test becomes one assertEquals($submission, $talk->toArray())


I'm not sure the last two constructors are useful. At least, they are unlikely to be useful to a physicist or chemist. The user has to know that `m` and `T` are to be specified in SI units, which are rarely (if ever) used in actual physics or chemistry simulations for reasons of numerical stability. There is also not a sense in which there is a "standard" Maxwell-Boltzmann distribution, so that the scale parameter = 1.0 makes sense as a default.


I've never been satisfied with the impl on this part, I'll have a better look with the methods you mention.


@cmherd DWMR. Having fun yet? Press on!


No.


@rec The python program is a test script for developers. It is meant to be run stand alone and is not part of a larger test suite. I wanted to test validator manifests by actually creating servers and sending out manifests. It's different from most of our tests in that it spins up several rippled servers on a machine, mucks with config settings, and restarts servers. I'll extend the documentation at the top of the script to make this clear. A whole document on just this script seems like overkill.


also added more comments in the main loop


I know there is an issue to rip out Sentry and rewrite it to use the Silex / Symfony (I forget which one and are too lazy to look it up) component because Sentry is no longer supported


Made a typo


Thank you!


TeamCity TelQ :: Pull Requests [Build 0.0.12](http://buildserver/viewLog.html?buildId=12306&buildTypeId=TelQ_PullRequests) is now running


instead of object in node?
or what for?


This commit was made because I misunderstood what the problem you were describing was. I soon reverted it after I realized that.


Type of ```0``` constant is **int**. Type of ```'\0'``` constant is **char**. So, in this case, they're both not quite correct - it should be L'\0' for **wchar_t**.
But ```0``` safely converted to any integer type. As, however, and ```'\0'```.
If you want, I'll change it.


I'd prefer you squash this commit with the previous one.


Another place you could use constants


Ugh -- NOT PSR-2 FRIENDLY, remove those extra spaces!

if (!$this->isCfpOpen(strtotime('now'))) {


You may be looking at an old commit. Check out latest.

![image](https://cloud.githubusercontent.com/assets/2453394/7729925/515712fc-fee5-11e4-8d14-18b592778608.png)


What is going on here?  Isn't this redundant?


It should not.


TeamCity TelQ :: Pull Requests [Build 0.0.12](http://buildserver/viewLog.html?buildId=12306&buildTypeId=TelQ_PullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:01:54


[LogJam](https://weakdh.org/) shows that this value was a bad idea...


@cmherd It will be very easy to skip adding the text for alt="". That is, however, the key that drives accessibility for those that need it. A good habit is to treat as very important.


I'd prefer using ```'%s' % source[:-4]``` for consistency with the rest of the code :)


So again I'm a little confused.  Is there a design document I missed?  Is this the rippled log?


@woongy `stories`, `stories_of`의 라우트를 `users` 리소스에 붙인다고 할 때, URL은 `HOST/hwidong/stories`와 `HOST/hwidong/stories_of`가 될텐데 전자는 이름이 직관적이지만 후자는 직관적이지 않네. 이름을 어떻게 하는게 좋을까?


@cmherd DWMR. Keep leaning into this!


Oh, yes that should be posted


either uncomment, or explain what it's there for in the comment.


This whole controller is gone in latest. Was in-progress work to try having controllers as services AND use the default Silex controller resolver. Re: PSR-2, can I run a formatter at the end to fix all whitespace? There are quite a few issues, actually.


can you change this to
```from urllib import request, parse, errror```


Yeah, that's definitely a good idea.


Ok the second option avoid subprocess : I will do that.


Что-то это не похоже на mergesort...


same here


Prefer copy to add:
https://docs.docker.com/articles/dockerfile_best-practices/ => ADD or COPY


Shouldn't this be a hidden file i.e. `.aws_credentials` and not have a `.sh` extension?


There were interoperability problems at this time, iirc.


fixed it


`final` keyword is removed in latest for reasons you'd expect... can't mock it :) I'll go through and clean any others up. Picked up this habit recently; wishing I hadn't


Agreed.
And I think we can add for sequences, the size of the smaller image and the size of the bigger image. What do you think?


Yes, cleaning up whitespace would be good


Ah, no, we're using remi's RPM repo, which is still at 1.12.12.


@cmherd DWMR here. Press on.


If you don't need these handler, then just leave them out.


Instead of installing git, if curl or wget are available on this base image you could just do: wget https://github.com/wellstorm/wmls/archive/master.zip


TeamCity TelQ :: Pull Requests [Build 0.0.13](http://buildserver/viewLog.html?buildId=12308&buildTypeId=TelQ_PullRequests) is now running


Can you explain what you mean by "don't support status code mutation?"


if the ECL was, say, INTEGER5 then maxLen would be 5, which is the original problem


@lbasavap , why do you need count metrics ?


    for field in line.split(';'):
        if field:
            key, value = field.split(':')
            result[key.strip()] = value.strip()

The multiple assignment has the effect of ensuring that there are exactly the right number of fields or you get an exception!


Does this mean that you have two possible results with the same priority?


Hi @lbasavap you have included after every out.printf() a logger.debug() but you are rebuilding the output string t

```
out.printf("%s %f %s%n", node, value/n, SDF.parse(sample.getTimestamp()).getTime() / 1000);
String str = new String(String.format("%s %f %s%n", node, value/n, SDF.parse(sample.getTimestamp()).getTime() / 1000));
logger.debug("Graphite Output Average: " + str);
```
Perhaps could be faster if we build the output string only once, somethin like that.

```
String str = new String(String.format("%s %f %s%n", node, value/n, SDF.parse(sample.getTimestamp()).getTime() / 1000));
   logger.debug("Graphite Output Average: " + str);
 out.print(str);
```
What do you think about that?


Hi , @lbasavap  , I'm reviewing your great work in order to upgrade my instalation and fix https://github.com/SYNAXON/GraphiteReceiver/issues/13 .

I suggest change "disconnection_graphite_after" by a more suiteble property name like "graphite_force_reconnect_timeout" , since you are not disconnecting you are rather force a reconnect , isn't it?

I have doubts on what exactly means 600000 . ¿ Seconds , miliseconds?


This is all kind of a mess to read. I gave up. Can you make this is any clearer? I'd rather see you break out to the python renderer or something than to have try to figure out what that's doing.


To ligado, estou refazendo essa parte do projeto, quando um modulo chegar ele vai receber um evento de boas vindas... Jaja mando um commit da nova estrutura.


Even if the user indicates 2 elements?
For example: one folder which raises this error, and a sequence which we can delete immediately.


TeamCity TelQ :: Pull Requests [Build 0.0.13](http://buildserver/viewLog.html?buildId=12308&buildTypeId=TelQ_PullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:01:56


@spilist 직관적이지 않지 않음. https://www.facebook.com/hwidong.bae/photos_of 참고 ^^


I am just going through the commits one by one, so if there is a newer
version I'm sure I will see it.

On Wed, May 20, 2015, at 11:42 AM, Dustin Wheeler wrote:
> You may be looking at an old commit. Check out latest.

> image

> — Reply to this email directly or view it on GitHub[1].

>

Links:

  1. https://github.com/mdwheele/opencfp/commit/7f01b06633f426afe97645ec80a69597641d47ca#commitcomment-11286966


Yup, the reason was that some servers do use 512 bit DH groups.

As of this morning, that reason is totally invalid. :smile:


I just wanted to comment on my experience with F77 vs F90 and C interoperability.
 - I think the versions that json-fortran requires is answered on [the project’s README.md](https://github.com/jacobwillias/json-fortran) and in this document above. The compilers that will compile this are ifort >= 13.1.0 (although I would encourage at least a 14.x release since there were a lot of compiler bug fixes) gfortran >= 4.9.2 and I’m told NAG 6.0 The library uses features from the Fortran 2003/2008 standard, but…
- C interop issues can be handled by either:
  - using the Fortran 2003 ISO_C_BINDINGS intrinsic module for Fortran >= 90 procedure that you need a C interface for. This should be more portable and future proof than the assumptions required to call Fortran <= 77 from C.
  - Just calling the modern fortran routines from Fortran 77 routines, which can still be called from C, or making an F77 style wrapper for the Modern Fortran routines.

Any way, I’m sure @bruceravel has all this stuff covered, and knows what he’s doing much better than I do, but felt like adding my thoughts on the matter, since, this is the internet after all…


My fault... I misspelled "dev"

> On May 20, 2015, at 7:29 AM, Márk Sági-Kazár <notifications@github.com> wrote:
>
> Ah, I am sorry, I read the diff the wrong way. Also, the commit message confused me. :)
>
> —
> Reply to this email directly or view it on GitHub.
>


Yes I don't want to be based on the exception message to know what to do...
sequenceParser could return different types of exception in this case.


Can we put theses files in the tcpdump tests/ directory?


TeamCity TelQ :: Pull Requests [Build 0.0.14](http://buildserver/viewLog.html?buildId=12310&buildTypeId=TelQ_PullRequests) is now running


Yes, you're right I don't need the key check there. I think I still need to get the `default_value` from the config in cases where this value isn't in the `system_info` table.


This resolves #1


I did not think of this use case with two inputs and one output.
I will fix it.


@richardkchapman PLease merge and close


Yes, I plan to, I just need some time to refactor and cleanup the code. :)
On May 19, 2015 16:38, "poxyran" <notifications@github.com> wrote:

> If you think this can be useful for others just make a pull request! great
> work!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/snemes/pype32/commit/89bb5a258b5c769d9793beb020b158d397a15337#commitcomment-11263234>
> .
>


TeamCity TelQ :: Pull Requests [Build 0.0.14](http://buildserver/viewLog.html?buildId=12310&buildTypeId=TelQ_PullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:01:26


Amazing!


oh and btw this is the command being executed: /usr/bin/java -jar /usr/lib/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 groovy /usr/lib/jenkins/puppet_helper.groovy create_or_update_credentials testuser '' 'Managed by Puppet' "-----BEGIN"


Or just return it from the config, and skip getting it from the table altogether?


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2126 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.64%25-yellow.svg)


ne pas commiter ce fichier.


Yeah, that was the thought behind the abstraction. I knew that if I wanted to have the API and web controllers use the same service, there needed to be a common abstraction for providing identity retrieval services. Authentication, in general, could be handled similarly. We just write another implementation and plug it into the service container.

Can go two directions:

1. Go ahead and immediately focus on Sentry replacement as the "next big OpenCFP" thing.
2. Focus on continued fleshing of service layer; implementing usage of that layer in web controllers such that when we **do** make the switch, it's only done in one place (the container).

Making the change now with the current controller will require duplicate work that we'd have to do as part of the service layer integration in that we will be registering a new service and make that change in usage in every single controller. Considering coverage isn't *the greatest* on controllers (or rather, there's a lot of "arranging" going on) I'm not completely comfortable falling back on current tests for such a refactor. Just two cents here, we can discuss more later on trade-offs


Can you avoid translating from strings to enums? `if() {} else if() {} ... else {}` does exactly the same thing as a switch.

```cpp
if(arg == "cpu" && !pipeline)
  pipeline = new libfreenect2::CpuPacketPipeline();
#ifdef LIBFREENECT2_WITH_OPENGL_SUPPORT
else if(arg == "gl" && !pipeline)
  pipeline = new libfreenect2::OpenGLPacketPipeline();
#endif
#ifdef LIBFREENECT2_WITH_OPENCL_SUPPORT
else if(arg == "cl" && !pipeline)
  pipeline = new libfreenect2::OpenCLPacketPipeline();
#endif
else if(arg.find...)
  serial = arg;
```


TeamCity TelQ :: Pull Requests [Build 0.0.15](http://buildserver/viewLog.html?buildId=12312&buildTypeId=TelQ_PullRequests) is now running


Ah, no, parentheses are very pricy in the Haskell world. :) I do not like searching for the matching closing parenthesis.

And I did not mean to remove all superfluous do-s.  Only if you can save extra indentation, it makes sense to remove a superfluous do.


The javadoc indicates -1 is returned for unknown messages, however the implementation appears to return 0. Which is correct?


All right!  I tested this and it works...

    def get_ripple_exe():
        """Find the rippled executable"""
        prefix = [RIPPLE_HOME, 'build']
        for path in [['clang.debug'], ['gcc.debug'], ['msvc.debug'], []]:
            for exe in ['rippled', 'RippleD.exe']:
                filename = os.path.join(*(prefix + path + [exe]))
                if os.path.isfile(filename):
                    return filename
        raise ValueError('No rippled executable file found.')

I'm not doing this just because I like the sight of my own code (not _just_ :-) )but:

1. the fact that trailing `/` in strings are significant is a serious codesmell/risk.  I have literally been up at 2 in the morning because, it turned out, occasionally the data didn't have a closing `/`.

2. It wasn't obvious to me that there were executables at two different levels until I redid the code.  But now the `[]` makes that very obvious.  And it isn't a special case any more...

In general, there's a Pythonic mindset you want to get into when preparing file paths - which is to prepare them as lists of strings representing directory entries, and then join them with `os.path.join` at the very last step.


I agree with your response. I suggest you can append it to the top commit above.
```
config.web_console.development_only = false

Or move web-console to development group of your Gemfile.
  * gem 'web-console', group: :development
```


@lbasavap , if you do that you are ignoring all metrics from any entity not belonging to any cluster, isn't it?

Also you are assuming that the entityName is always a host or vm , isn't it?. What happens with other resources? Perhaps could be good to add a property like "enable_cluster_map" to activate/deactivate the cluster mapping


Regarding "picorer" / "picorage", wouldn't "grapille"r / ("grapillage" ? "grapillement" ?) be better suited ? After all, we are apes, not poultry… I would even be tempted to recommend "sélectionner" / "sélection"… what do you think ?


Quibble:  why not call it `set_config_file` because that's what it does?


TeamCity TelQ :: Pull Requests [Build 0.0.15](http://buildserver/viewLog.html?buildId=12312&buildTypeId=TelQ_PullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:01:48


Yep.


This is the new way of injecting the default ModelMapperAssembler. I can change the qualifier to an annotation (`@ModelMapper`). What do you prefer ?


If we make MAGIC_NUMBER final, then we can't change it later in the code!


My bad, I removed email from which I committed. Now it fixed.


no, the try segment would be shorter:

    server = RippledServer(RIPPLE_EXE, config_file, server_out)
    try:
        server.startup()
        yield server
    finally:
        server.shutdown()

So if the creation of the server fails, you never even make it to the try block...


> match the number of DECLARE PARAMETERs

It assumes that we only throw this exception if the *user* function's parameters number didn't match the number of parameters passed. But we are actually throwing it from `PopValueAssert` and `AssertArgBottomAndConsume`. There is no `DECLARE PARAMETER` operator in C#.


If the `response.setStatus()` is called as in `ServletResultHandler()`, then a later call to `response.getStatus()` will not return the value set but the default (i.e. 0).


_"Never mind!"_


I was just explaining why the defaults were being overridden, but I'll yank them.


Spaces around operators!


Nit: `Entity is returned as-is`.


I think we should start refactoring this code by looking at this method, animals(), and trying to determine what it actually does. By doing that, maybe we can rename some more variables like you already have, we can refactor some code, and clean it up a bit. I see that you've renamed boolean seed, but just looking at your code, I have NO IDEA what this "magical algorithm" is supposed to do.


I'd bring this up as a constant in CAPS to the very start of the file...


'certain issue'


@brentvatne why is this removed?  I'd ideally like to include some external js within the doc itself to enhance it, like using jquery to do dom scraping.


That's no problem, how about ".ivy2" / ".spark-packages-credentials"


Nice touch changing to a block style comment, but this isn't *quite* best practice. A best practice for a block comment would start with typing /**, and then pressing enter. Your IDE *should* create a block style comment, which, going back to your question a few days ago about Javadocs, will actually be part of those Javadocs, should you choose to create them with the IDE or on the Command Line. So, the content of the comment is good, but try typing /** and press Enter and see what happens.


It'd be great to get the layout of what a line looks like - an example line, say, with these fields marked out.

All these magic field numbers make me nervous.  If we're interchanging data between two ripple products, why are we dancing around this way?  Why don't we just write JSON, which everyone understands?


@scottschurr Wow, good eyes! That will be a problem for non-unity builds.


With a script named `test.groovy` containing one line:

```
println(args)
```

I just ran `groovy test.groovy -v` on:

* MacOS Yosemite (bash 3.2.57, groovy 2.4.3 on Oracle JVM 1.8.0_25)
* Ubuntu Trusty (bash 4.3.11, groovy 1.8.6 on OpenJDK 1.7.0_79)
* CentOS 6.6 (bash 4.1.2, groovy 2.4.3 on OpenJDK 1.8.0_45)

I got the same result on all three:

```
$ groovy test.groovy -v
[-v]
```

For comparison:

```
$ groovy -v test.groovy
Groovy Version: 2.4.3 JVM: 1.8.0_25 Vendor: Oracle Corporation OS: Mac OS X
```


I had the same issue and upgrading npm to the latest version (2.10.0) fixed it.


@lbasavap  Perhaps ."cache_refresh_interval".is not a good property name  IMHO the  property should be more explicit .. something like "cluster_map_refresh_interval" or "cluster_map_refresh_timeout"

what exactly means 3600 ? "seconds" ?.


`[NOT_FOUND] * len(log_files)`


It's good that you noticed that this code needed to be indented according to its bracing depth, but can you explain to me what this code is actually doing? Perhaps there's some more room for refactoring the code here.


spaces around operators!


@lafernando  this was fixed in later commits


indentation!


You don't need an `else` after a return - and the code is already indented quite far...


Sorry about that! Will be removed shortly


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It can render Imran Nazar's Opus5 demo just fine, at least the background (intro to Tetris too). Not much else works, likely due to lack of timer support.


`propagate`


@lafernando This was fixed in later commits


We might get to this block for all kinds of reasons that don't have to do with a mirror that isn't working. It would be much better to catch the specific exceptions that indicate a bad mirror, and only try the next mirror in that case.


You can't create a ped using a random number, the ped id is assigned by the game.


again, why use two lines (and two levels of indentation) where one will do?

    in_validator_keys = False
    for line in open(config_file):


This method is used heavily by the application. This style of coding is used throughout the application (longer expanded if statements). This method and many more could be collapsed much simpler, but it would come at the sacrifice the application logic.

I will add a new commit to specify the return type of the method. I'll talk to you when you come in to get feedback on the commit message.


Ah of course... it's not groovy directly but through the Jenkins API. Can you show the entire error you get?


Possible, but I think not necessary.


If possible I like to have a commit more than having one less :)


Yeah, I was not sure about the best way. If I mark it fuzzy, then they are not written into .mo, but having previous translation is better than nothing. I guess, I can adjust .po with 'fuzzy' now, after .mo is already updated?


Не надо разбивать массив на два --- это очень неэффективно, так как приходиться их копировать в памяти.


Okay, will do :)


here you go:
```
/usr/bin/java -jar /usr/lib/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 groovy /usr/lib/jenkins/puppet_helper.groovy create_or_update_credentials testuser '' 'Managed by Puppet' '-----BEGIN'
"-----BEGIN" is not a valid option
java -jar jenkins-cli.jar groovy [SCRIPT] [ARGUMENTS ...]
Executes the specified Groovy script.
 SCRIPT    : Script to be executed. File, URL or '=' to represent stdin.
 ARGUMENTS : Command line arguments to pass into script.
```


На каждом вызове создавать новый массив --- также неэффективно.


Remember that the program origin is a filename, so unless it's a /dev or /proc path, then it has to be either a regular file or a FIFO, and there's no need to treat either of those specially, but if it's a /dev or /proc path then there is.  But how can we portably determine the difference between /dev or /proc on the one hand and everything else on the other?  (Answer: bah, just look for paths that start with /dev/ and /proc/ on platforms other than Win32.)  Of course, `-` we can and should treat specially.


IMO those two belong rather together but if you want keep it as it is


IIRC yes, we intended for jq_realpath() applied to "." to be a sort of getcwd().


Hi, jasdel,

Thanks for refactoring the errors!

It is nice to have function return awserr.Error to save type cast. But this would prevent us from reusing the error variable, for example, the following snippet won't work,

output, err := s3manage.Upload(svc, input, opts)
_, err = io.Copy(dst, src) // * we cannot do this *

because the type of err is awserr.Error, while io.Copy returns error.

Does it make sense to change the returning error type to the generic error, which might be more idiomatic? Thanks,


accentuate the positive!  :-P  Also, you can simplify the logic slightly that way...

    if in_validator_keys:
        if sl.startswith('['):
            raise ValueError('ThisServer validator key not found')
        if sl.startswith('#'):
            continue
        s = sl.split()
        if len(s) == 2 and s[1] == 'ThisServer':
            return s[0]
    elif sl == '[validator_keys]':
        in_validator_keys = True

You see that you lose one comparison and two lines from the code - just a little less for the next person to read...


Oh, you were copying the existing comment.


`os.path.join`!


More idiomatic (and one less line): `master_secret_file = master_secret_file or server.master_secret_file`


oh ok ..


Curious that the Manifest is a `struct` and the data members are public.  As `Manifest`s gain more functionality you may want to revisit this decision.  Just for your consideration.


How do you think about [the applicability of the parameter "VERBATIM"](http://www.cmake.org/cmake/help/v3.2/command/add_custom_target.html "Reuse of VERBATIM?")?


`import org.cru.redegg.recording.impl.DefaultWebErrorRecorder;`
`import org.cru.redegg.recording.impl.DefaultErrorRecorder;`

are already a part of this package.


You can glue all three of these together and lose two lines one whole variable...

    master_secret = open(master_secret_file or server.master_secret_file).read()


Added try catch around GetRequestStream() while getting ready to send metrics to server


This hanging comma causes script errors in IE 7 and below.


dangling </p> fails checkstyle build


Cleanup and return here, then you don't need the else and you don't need to indent everything in the else compound.


Thanks Toni for the comments / suggestions. I will be happy to make changes per your suggestions.

Regards

Lava

Sent from my iPhone

> On May 20, 2015, at 9:03 AM, Toni Moreno <notifications@github.com> wrote:
>
> @lbasavap Perhaps ."cache_refresh_interval".is not a good property name IMHO the property should be more explicit .. something like "cluster_map_refresh_interval" or "cluster_map_refresh_timeout"
>
> what exactly means 3600 ? "seconds" ?.
>
> —
> Reply to this email directly or view it on GitHub.
>


Does the errno actually matter here?


If stat() failed for any reason other than ENOENT then st is uninitalized here.


This clobbers the ret set above where stat() fails.


Strange if statement. Is it ok?


Mauvaise idée de commiter son dossier de build ;-)
build-SelectionPlan-Desktop-Debug


Looks good. Go ahead and commit.


Attempt to fix this rarely failing unit test.   Allowing 1ms margin of error should do the trick, but I'm worried this could make us susceptible to an 'off by 1 bug'.   Alternatively we could just retry some number of times to see if the correct value is returned (5 times should be enough).


Later in the same commit, you'll see "set update = formulas_git_opt(env, 'update')|load_yaml" where update is a boolean... so no your assumption does not hold.


@WestLangley Actually, this change makes it impossible to do things like Quake. Where they combine a tiled texture and on top of that they apply static illumination with AOmap with the second uv set.


@jonboulle In Linux the arch name is arm64, so it would seem linux/arm64 would be better OS/arch combo.  I think having aarch64 would lead to conversions aarch64->arm64.


There's no need to avoid having multiple path separators together.


I admittedly don't quite understand the details of how the RedEggServletListener works, but is there no need to register the `entitySanitizer`as you do the `parameterSanitizer`?


Can you try adding two dashes between the command name and script name, or between the script name and the arguments? e.g:

```
/usr/bin/java -jar /usr/lib/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 groovy -- \
    /usr/lib/jenkins/puppet_helper.groovy [...]
```

or

```
/usr/bin/java -jar /usr/lib/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 groovy \
    /usr/lib/jenkins/puppet_helper.groovy -- [...]
```

That's common notation for _abandon all argument parsing ye who enter here_


I think you tagged the wrong arvind :)

On Wednesday, May 20, 2015, Mohammed Arshad Ansari <notifications@github.com>
wrote:

> @Arvind fixed the not able to save content issue, take a look at this
> commit
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/arshadansari27/fitranginew/commit/ec30a805224ddc3274f7172490adae5910da83ce
>

--
-Arvind
-----
Arvind Satyanarayan <http://arvindsatya.com/>


It seems like when you use `desktop.el` and the buffers are recalled on startup, `switch-to-buffer` is still called on every buffer. There is a lot of parsing going on and CPU usage is high


test


I have changed the interface of IUnitOfWork and this seems to be ok.

     void AddEmittedEvent<TAggregateRoot>(AggregateRoot aggregateRoot, DomainEvent<TAggregateRoot> e) where TAggregateRoot : AggregateRoot;

The problem in the test harness still persists. Now with the removed Emitter could we pass emitting root as an argument to the TestContext?

     public CommandProcessingResultWithEvents Save<TAggregateRoot>(AggregateRoot aggregateRoot, DomainEvent<TAggregateRoot> domainEvent) where TAggregateRoot : AggregateRoot


sorry abt that... :)

On Wed, May 20, 2015, 9:48 PM Arvind Satyanarayan <notifications@github.com>
wrote:

> I think you tagged the wrong arvind :)
>
> On Wednesday, May 20, 2015, Mohammed Arshad Ansari <
> notifications@github.com>
> wrote:
>
> > @Arvind fixed the not able to save content issue, take a look at this
> > commit
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
> https://github.com/arshadansari27/fitranginew/commit/ec30a805224ddc3274f7172490adae5910da83ce
> >
>
>
> --
> -Arvind
> -----
> Arvind Satyanarayan <http://arvindsatya.com/>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arshadansari27/fitranginew/commit/ec30a805224ddc3274f7172490adae5910da83ce#commitcomment-11287885>
> .
>


Missing space around `=`


Same here


@jonludlam A new solution proposed, please see the updated pull req.


Looks great :+1:


changed it to ```actual.getTextValue().equals(placeholders.resolveName(expected))```
https://github.com/bedatadriven/activityinfo/commit/8405d27be2a71fdca24df40a3521d8604f61f65e


What do you want to get rid of? The `-x` option? Why don't we need it anymore?


> BTW, I guess that the file extension should be 'py' instead of '.pdf', which is a little misleading.

@JorjMcKie, how about renaming `PDF_display.pdf` to something similar to `display-pdf.py`?


What are you trying to do with this method?


By the way, nice refactoring to get these checks into a central location.


Indeed it was one of the things I already tried and here's the funny result:
```
/usr/bin/java -jar /usr/lib/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 groovy -- /usr/lib/jenkins/puppet_helper.groovy create_or_update_credentials testuser '' 'Managed by Puppet' '-----BEGIN'
"--" is not a valid option
java -jar jenkins-cli.jar groovy [SCRIPT] [ARGUMENTS ...]
Executes the specified Groovy script.
 SCRIPT    : Script to be executed. File, URL or '=' to represent stdin.
 ARGUMENTS : Command line arguments to pass into script.
```
and
```
/usr/bin/java -jar /usr/lib/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 groovy /usr/lib/jenkins/puppet_helper.groovy -- create_or_update_credentials testuser '' 'Managed by Puppet' '-----BEGIN'
"--" is not a valid option
java -jar jenkins-cli.jar groovy [SCRIPT] [ARGUMENTS ...]
Executes the specified Groovy script.
 SCRIPT    : Script to be executed. File, URL or '=' to represent stdin.
 ARGUMENTS : Command line arguments to pass into script.
```


Wait, what did you do here?? This was a transformation matrix and now it's a data frame? I'm very confused and this appears to break the test case.


`bak` sounds better than `back` to me - its instantly obvious that "bak" means backup. `back` could be the last element of a container.


Space around `=`.


The render function simply uses jQuery to append the string 'sharks!' to the $el object, which is a jQuery object.
Created an object that inherits from the SharkTank and hooked it up to an HTML page.
The el attribute of your view is the DOM node your view attaches to
The $el attribute of your view is a jQuery version of your el.
This is created for you by Backbone.


The new link is broken, needs to have .html instead of .md


Hmmm. Perhaps we need a way to check if the buffer is visible. Or some hook
which runs after initialization (if that's even a defined state).

On 18:19, Wed, May 20, 2015 Peter Vasil <notifications@github.com> wrote:

> It seems like when you use desktop.el and the buffers are recalled on
> startup, switch-to-buffer is still called on every buffer. There is a lot
> of parsing going on and CPU usage is high
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abingham/emacs-ycmd/commit/4440494f031acc3902fcfed0e0e568472e1d4d2a#commitcomment-11287899>
> .
>


My pleasure - thanks for a great project - makes my life so much easier! :)


aria-labelledby references element IDs, so this should be <title id="title">. Otherwise, looks good!


Why is this rejected only on Android?


This shows why `elisp` is not a good LISP. A true language does not discriminate, nor prevaricate, UPPERCASE.


Why do I get suddenly comments on a commit that is already merged ?

I will happily answer your questions if you want to improve this part of the code but I'm afraid I don't have the time to rewrite it in some other way right now.

The above simply outputs proper "file_roots" settings combining the value from the normal pillar (coming in via the argument) and the file roots required for the enabled formulas (obtained via formula_roots). It does in two passes, first dealing with environments that have a file_root configured in normal pillar data and then dealing with environments that are only referenced in formulas.


log_metadata is meant to be marshalled, a case where nil does not make sense (since it can't be marshalled natively in quite a few representations). On the API level, a nil name really says that there is no name. empty? is a lot harder to check.

Of course, we could move the nil-to-empty code to the person that marshals log_metadata, just thought it would make more sense here.


Ok line 74, apparently my coffee hasn't kicked in yet.


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1659 of 1659 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Это такое принятое название? Ок, спасибо. А какое-нибудь соглашение по поводу краткого названия существует (ну, как np для numpy)?


We can try to use an Image with a tiling fillMode or simply go back to a black, ~50% opacity Rectangle.


Remove these brackets.


This causes a compile error over in nsqlquery.cpp:
```
In file included from sql/nsqlquery.h:32:0,
                 from sql/nsqlquery.cpp:21:
./sql/databaseconnection.h: In destructor ‘NSqlQuery::~NSqlQuery()’:
./sql/databaseconnection.h:62:16: error: ‘DatabaseConnection::LockMethod DatabaseConnection::dbLocked’ is private
     LockMethod dbLocked;
                ^
sql/nsqlquery.cpp:50:13: error: within this context
     if (db->dbLocked) {
             ^
Makefile.Debug:5883: recipe for target 'build/debug/nsqlquery.o' failed
```


For Group shutdown implementation can't we use the same Spawner shutdown implementation @ digitalextremist ???


Can you help me understand when `defaultSanitizer.isUnsatisfied()` might be either true or false? This is an `Instance<...>` question, I believe.


Fixed. Thanks for the input!

2015-05-20 18:14 GMT+02:00 Fred Bricon <notifications@github.com>:

> dangling
> fails checkstyle build
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eclipse/buildship/commit/dbe82db3ad9aecd113c6131e14ff5028a29b722d#commitcomment-11287758>
> .
>


Why the hell is this line dublicated?


This is already added in the Other section.


There is a [ScalaVersion](https://github.com/scala/scala/blob/2.11.x/src/compiler/scala/tools/nsc/settings/ScalaVersion.scala) implementation in the Scala compiler, but I'm not sure if it's available in 2.10 or not.


Your previous throw: ...`format is '<key> <comment>'` suggests the comment is not optional.  However your data handling allows for the comment to be optional.  I suggest less flexibility is possibly better.  If you insist on the comment then a) they must provide at least a little documentation and b) you get rid of a conditional.


This is already added in the Storage and Workflow section.


Кэш браузера говорит, что страницу с документацией я посещала 9 раз.
Если честно, я не очень поняла. То есть примеры на этой странице понятны, но не хватает чуть более близкого к моему случаю примера, наверное...


It's better to just sort all tabs alphabetically and put them in one group "// Tabs."


All I did was change the hi hi hi thing


That's not a big deal. I can merge it now (since it fixes a bug), and then improve the code myself later.


@AndreeaDora please change this to use `$angular.forEach()` instead.


I think I will try to do the servo things though


If you're adding Android stuff, I would rather put all of it in a new Android section.


Special note: looks like OpenVR is doing some position math off the GPU here:

https://github.com/ValveSoftware/openvr/blob/master/samples/hellovr_opengl/hellovr_opengl_main.cpp#L1344

So don't make this line redundant:

https://github.com/phr00t/jmonkeyengine-virtual-reality/commit/d1df93025b8b0b99e80d7074e008ea8366d8bd41#diff-7e5219f64693e3e755f8313504cbccf1R12


Yes, it is in 2.10: https://github.com/scala/scala/blob/2.10.x/src/compiler/scala/tools/nsc/settings/ScalaVersion.scala


Weird that that wasn't found when I changed that it.  That file should have been automatically re-compiled & found when I modified the DatabaseConnection class.  I'm doing a full build to make sure it this doesn't appear anywhere else.  It should be ready shortly.


Ай ой нафиг такое!


`if NOT_FOUND in ck:`


Always? According to http://www.paciellogroup.com/blog/2013/12/using-aria-enhance-svg-accessibility/ this looks okay.

Gotta be mindful when `id`ing elements in reusable components. We don't want to make it possible to use the same ID twice.


Can `$fasta` really be `None`?


@AndreeaDora the fact that you are using `\\` to specify the path to the `history.json` might cause some issues in linux environments. Could you please verify this?


master (lefticus) - x86_64-MacOS-10.9-clang: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Very cool!


@AndreeaDora I think it would be beneficial to create some tests for the `HistoryCleanerJob` class. Are there any tests for other classes that implement the `Job` interface?


Should we merge that into `master`?


All links should only be added in one section. I know deciding where to put them is sometimes hard, but you'll need to decide where each tool fits best.


You might want the local function `logfile = lambda f: os.path.join(os.path.dirname(f), 'log.txt')`


Why are we replacing `=` for `:`?


w


Why 3.1f? Should be any float is supported, right?


What if I want to use amber99sb-ildn (my current preference)?


Make a private server has never my projects, just create tool for help forum community, but since my projects has started, people don't care and my mate gone.

I finish some functionality and left the repo, if players decide to continue they can fork and continue.


I think you want, "water model .itp file to check for/be included in topology file", rather than what you currently have. An .itp file is not quite the same as a topology file.


LGTM.


Do you have any custom code? From the error, it looks like you're missing some lines (specifically, the `BEGIN_ZEROED_BLOCK;` and `END_ZEROED_BLOCK;`) in pc.h, inside `struct map_session_data`.


This usage suggests that `Manifest::verify()` might be better named `isValid()`.


Add this: postToChat(Welcome!)


Please use English variable names


Spaces around operators!

Hmm, isn't there a PEP-8-detector somewhere??

Tortured line 625 should benefit from the logfile function above...


Have you tested this? I think it should be os.stat( gro_solv_filename ).st_size==0, not os.stat(gro_solv_filename) = 0.


apiバージョン毎のテスト時の2重定義の為エラー抑制処理を追加


Why are you getting all the semesters? Why not all the semesters that the course is present.


$ is a convenience attribute of a backbone view.
It contains a reference to jQuery scoped to the current view.
If you call this.$('p') it will get all the paragraphs in the current el
this.$el - is by contrast is the current el attribute packaged as a jQuery object.
Same as $el.find('p')


@Myoldmopar neat


General comment - hope you aren't getting down by all the comments!

We're early days in Ripple's Python code yet and I want to establish a good clean precedent - at the very least PEP-8 but hopefully lots of clean and sleek code... :-)


bianchi fabrizio
monticelli d'ongina (PC) Emilia Romagna Italia


the_semester == semesters. I am not sure why this loop is even here.


Should be fixed.  Sorry about that.


didn't work!


Yeah, always. From Léonie's article: "Using aria-labelledby referencing the id values of the title and desc elements". I think her example is a bit confusing because she uses title[id="title"] and desc[id="desc"] in her markup.

Good point about reusing the component. Can we generate unique ids?


- Nice


@lefticus Did you see the conversation on the PR itself showing the improvements?


Why are you quering for another Enrollment, isn't student == enrollment_instance?


200 OKを追加


So wait.  You start up a server for each config file, and then you are now interested in each log except the first one?  (Spaces around operators please...)


- Please explain what codes in line 65 - 79 does


Can this be implemented like a function call expression by pushing the compare function on the stateStack so we can avoid the tight step() loop inside what appears to be a single call to step() from outside the interpreter?


Enrollment class has the propriety student, please use that.


fixed in https://github.com/SeleniumHQ/selenium/pull/557


This optimization LGTM.


このAPIは無くても動作しますが、一応v1から引き継いでいます。


Why so many lists? Just parse a list of enrolled to the template, no need for list 'grade' and list 'students'.


@borzamircea will this run as is? There is no path specified.


Does `_s` mean "seconds"? All times in Python are in seconds unless otherwise noted...


SD Card INIT failed


I do now. It's worth it. I similarly went through all of my chaiscript stuff to make sure the CI is now taking 600s at most per build.


You can make state 'editTask' nested: 'tasks.editTask'. Great solution to practice nested states and implement inline edit adding ui-sref="tasks.editTask({id : task.id})" inside ng-repeat div with list of tasks.


Why is THIS UPPER CASE? :P


`[1]` => `[1]_`


Ah, I missed those IDs. Yeah, if we do `@titleID ?= 'logo_' + Math.random()` or something at the start of the render function it'll be unique per instance and persist across renders.


good !


`[2]` => `[2]_`


See comment below.


Maybe rename `KEY1/KEY2` to `ROW/COL`? To show that this method is specially defined to be used with matrix.


This is aleady handled by [.halcyon/extra-data-files](https://github.com/puffnfresh/tryidris/blob/master/.halcyon/extra-data-files).  See the [Halcyon reference](https://halcyon.sh/reference/#halcyon_extra_data_files) for details.


I thought this https://github.com/angular-ui/ui-router/blob/0.2.15/release/angular-ui-router.js#L10 accomplished the same thing without having to have an extra file and a different main in package.json and bower.json


Make sense, it should never use cache here.


Please format the references so that they get linked to the rest above. See for example here the top-level docstring here: https://github.com/nipy/dipy/blob/master/dipy/reconst/sfm.py#L2 for the syntax.


You must validate if course_id and semester_id is really present in the form.


@jahammo2 next time do it 100% test driven


@borzamircea why do you use `//`` instead of `/`?


:cool:


:D


Because you can use -f "%c - %u" instead


Why do you have to return a value when calling `Close()`? I think it's just a question of meaning here. `sub2` here behave like a go channel and I expect it to be close-able. `Stop` kind of make sense since it will stop receiving data, but it eventually comes down to closing channels when we look at the method definition.

Also, it's the only thing that we return that uses `Stop`. Weird.


I had another thought. How about using `aria-label='Zooniverse'` on the svg element? Avoids having to set an id and might be read by VoiceOver. I guess that has text in two places, which isn't ideal either.


nice.


I think it's better to use ng-init for author and assignee.


P.S. The date that must be written is not the Edit Date, but the EVENT DATE or the PRODUCT DATE.
For Example: If i'm revising amd.html, i will probably write the date of fundation of AMD!
Again, If i'm editing the "amiga1000.html" i will probably use as date the "born date" of the amiga 1000 or the arrive on the markets of the amiga 1000!
Hope i clarified.


Thanks for all this documentation!  As I keep saying, we can automatically make sure our external documentation and code are always in sync and I hope to do this shortly... :-)


Why run it on `:80`?


@mietek this is necesary for Nix, which I also use for deploying.


Thanks for code review :+1:


$scope.description and assignee should be refreshed after task added.


So we are not doing a precise analysis of what casts actually matter un unchecked context and bail on all of them?
I thought we have a mechanism to query the compiler if code with the cast removed has exactly the same semantics as before, no?


This also fixes the javascript event listener error that we were getting.


Erro ao usar o login na biblioteca do curso.


I don't think that's a very good message. It is suggesting two opposite things as if they are interchangeable.


@oveddan - I'm not sure why jsdom-little removed it originally, I just went with it because it was the easiest to port and worked for my use case. You could include a library like jQuery that runs in JavaScript Core to manipulate the document, just as how I do with d3 in [this example](https://github.com/brentvatne/react-native-svg/blob/master/D3Chart.js)


Is it used anywhere?


This class was there to read data from the harddrive and format that to json.
Are we sure we want to delete that?


해놓고 생각해보니 거의 tab과 다를바없이 작동하게 만들었네.. 내일 좀 더 수정해야겠다


newrelic_agent.log shouldn't be here. Please add .log to .gitignore


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1664 of 1664 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


IntelliJ seems to think that `org.cru.redegg.JaxwsRecordingIntegrationTest$FruitServiceImpl` is not assignable to javax.servlet.Servlet. I presume it is if the tests runs successfully.


love the commit message :-)


We should not be mucking with this. Doing a write on casper's internal state is not good.


develop (mbadams5) - x86_64-MacOS-10.9-clang: OK (1142 of 1142 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think this will break stuff. For example if resolve is function with attributes


the output of the codes is specified by the format argument to Codes::CodesRunner.download() which is now more generic and can have more data.

If I run:

    codes download -X -a com.wewanttoknow.DragonBoxPlus -u xxxx@wewanttoknow.com

I now get something like

    6TJ9P6JXXXXXX,ios,522069155,com.wewanttoknow.DragonBoxPlus,'DragonBox Algebra 5+',https://buy.itunes.apple.com/WebObjects/MZFinance.woa/wa/redeemLandingPage?code=6TJ9P6JXXXXXX

The "%c - %u" allows to keep backward compatibility with how the --urls argument was handled inside lib/codes/itunes_connect.rb. I would remove the --urls argument support and let user use --format "%c - %u" instead.


@borzamircea Since you are referring to the `VG_HOME` environment variable of the system in which you run these tests, it then makes the **fixtures** that you are using to run such tests variable since you could point to a different `config.properties` on different runs. Unless you have this *hard-coded* in a `config.properties` that you use for your tests, then you won't have reproducible tests. I think we should invest in making tests self-contained and reproducible.


It should handle other case as well


thinking about it, I probably also want the generation date.


Please do not remove this blank line.


@eddiemonge Wow, great catch! This is not in ui-bootstrap, ui-layout and it is not in any other projects I've seen so when I saw the "missing" index.js I added it and updated package.json and created the PR. But I just tested it without the merged PR and it works!


@chancancode are you okay with the current message? It would be lovely if we can improve it a bit. Do you think the example for the development group would be beneficial?


Excellent!


@mrdoob An ambient-occlusion map occludes ambient light. But `MeshBasicMaterial` does not respond to any light sources. For that reason, the `AOmap` was removed from the material.

However, let's think about this differently...

Essentially, `MeshBasicMaterial` has a constant ambient light source hardwired -- `0xffffff`. In pseudo-code,

    finalColor = material.color * 0xffffff

With that viewpoint in mind, we can add `AOmaps` back in. In the shader, it would be the equivalent of:

    totalAmbientLight = vec3( 1.0 );
    totalAmbientLight *= ( texture2D( aoMap, vUv2 ).r - 1.0 ) * aoMapIntensity + 1.0;
    outgoingLight += diffuseColor.rgb * totalAmbientLight;

We could add light maps back in too, but it would require a bit of thought.

The other solution is to tell users to use `MeshPhongMaterial`.

/ping @bhouston


I believe this will trigger nearly every static-analyzer out there.


Turns out that the "value not in range" problem is a different issue. (bug 963).


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I can't understand the use case here, if it shoot a die and os-autoinst found you have the fatal flag, it will stopping VM, in that case above, set the result to ok actually doesn't matter here, that is what you looking for?


There is no need for this `else` since the previous branch has a `return`.


fixed


single-quotes :)


The indentation here seems pretty screwed up. We use 2 spaces.


is_show_hourが指定されている場合で60分を超える場合はmmm:ssの形式で表示しないと表示時刻がおかしくなっています。


Same thing here. Indentation.


What's the deal with this?


/cc @pires


`function () {`


Does it make sense to execute this moved block if `bResult` is false? The code removed from `CGUIWindowMusicSongs` is only executed if `GetDirectory()` was successful.


if there are more devices than test cases, then groups are empty and pass to the command, this will make whole test suite run


Yes, and it shouldn't have any side effects even though it's code :)


Good job on externalizing strings.


1836664-ReturnWaterTempReset (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1665 of 1665 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I am okay with putting AOMaps back into MeshBasicMaterial.  @WestLangley's formulation appears to be correct.


@tom71 yes, after I committed this I started having some second thoughts because we're now effectively always masking the ENOENT case.  This is going to require some more careful testing.


**Chapeau l'artiste !**


form_for [@category, @product]


Só faz merda


1. It is possible to features with empty elements. this happens when scenarios are filtered by the given tags. should check the elements are not nil
2. If it is scenarios out line and it can have different examples with specific tag. So it should take only Examples line number to run those specific test cases


should take multiple feature files / feature folders


Shouldn't there also be a check for `!item->IsVideoDb()` like in the handlers for `CONTEXT_BUTTON_RENAME` and `CONTEXT_BUTTON_DELETE`?


@eparejatobes please, take a look, besides this everything seems to work fine


Quotes are now missing around the 'eval' string. :-)


The JIRA reference in commit message is incorrect. Should be [DROOLS-537](https://issues.jboss.org/browse/DROOLS-537)


delete old versions KD files


so resolveToParents resolves to HaxeClass instance?

Are you sure that
```java
(resolve instanceof HaxeComponentName || b) &&
                resolve.getParent() instanceof HaxeClass;
```
Can be dropped?


I think we should leave the old one in place as well and mark deprecated since this could break code for people who update.


It only affects classes because all class types derive from HaxeClass.  That, plus we don't even call it unless we're being asked to return a file.


Retirando domínio antigo


Thanks. I have merged it.


Um  - true.
At least this is blocked during software installation on the Pebble.
So it should not be too critical.


@iggy I've fixed this in #23983.


Fixed in 3d0fc45, https://github.com/KnowSheet/Sherlock/pull/38.

Good eye :+1:


Do we need backwards compatibility logic here that also covers `iWindowID == WINDOW_MUSIC_FILES` (similar to the same logic for video windows)?


This doesn't belong here - and is' probably not something we need to do now.  What's the use case?


Rather than doing this - which makes it a bit unreadable - I suggest you use a weighted pick list of ids.
Something like

    event_id = pick(2;"hallucination", 1;"clumsiness", 2;"stutter", 1;"vomit")
        switch(event_id)
            if("hallucination")
            etc.


Agree. Eventually it will though -- I'm thinking of two names, one for `Accessor`, which is immutable, and one is the true `Transaction`, which can be rolled back.


What is the reason for moving the scala source out of this git repo?


Generally auto negotiation would be done when you set the client, after defaults would be set (if we did it)


In file included from /sources/src/server/game/DungeonFinding/LFGQueue.cpp:22:0:
/sources/src/server/game/Groups/Group.h:178:5: error: ‘WorldLocation’ does not name a type
     WorldLocation Location;
     ^
/sources/src/server/game/Groups/Group.h: In constructor ‘RaidMarker::RaidMarker(uint32, float, float, float, ObjectGuid)’:
/sources/src/server/game/Groups/Group.h:183:9: error: ‘Location’ was not declared in this scope
         Location.WorldRelocate(mapId, positionX, positionY, positionZ);

gcc 4.8.1

Added Object.h in Group.h


I think it's not bad, but anything can be improved :P I'm not sure if example has too much value in and of itself, but I guess a code block is more visually catchy so having the "right" thing to copy will help (so that people don't automatically copy the config without reading):

```
Web Console is activated in #{ environment }, which is usually a mistake. To ensure
it's only activated in development mode, move it to the development group of your
Gemfile:

   gem 'web-console', group: :development

If you ...

   config.web_console.development_only = false

```

Something like that?


Done, renamed to Close.

> Why do you have to return a value when calling Close()?

If we decide to go with Closer then the method must implement io.Closer interface.


Thought of it -- now it's just for the matrix, but later, as we add more types, the `ROW/COL` notation will likely become off.


Nice :)


@bhouston What about light maps? They are a source of ambient light. (I won't bias you by telling you what I think. :) )


if(..() == 1)
The parent returns -1 if it fails, but that's still a non-zero value.


how does this work if a user configures a job when only the default is available and then later someone add another docker tool installation?
With this change the Job initially won't be configured to use the default, so on reconfig could it end up surprising users?

IMHO "Default" here should be banned - it was a bad thing resulting in a huge issue for JDK.  If you want ease of use create a default installer which doesn't use an absolute path for docker.

Granted this has nothing to do with this code change but....


So this should not be in `SetOpenShiftDefaults` and thus `SetOpenShiftDefaults` should not touch `config.Version`?


Of course ! Thank you !


Ok, then. Approved


And why not tell users to use `MeshPhongMaterial`, instead of adding `AOmap`s back in?


installign -> installing


why not move to some lib/docker folder, like credentials plugin does https://github.com/jenkinsci/credentials-plugin/tree/master/src/main/resources/lib/credentials


This call: https://github.com/openshift/origin/blob/master/pkg/client/client.go#L221 will fail if the `config.Version` is not set, so `SetOpenShiftDefaults` is doing it at the last possible moment.


Yes, I'm positive that it can be dropped.  resolve() always resolves to the component -- the parent of the component name that the old code was looking for.  So, line 567 already deals with the 'resolve.getParent()' problem.

That's why I re-wrote isReferenceTo() in the first place: to deal with the fact that isReferenceTo() is called with a COMPONENT_NAME from some code, and with an element in other cases.  We had to detect what was being asked for and get the right element to test against.  That's why the resolveToComponentName was added as well.  Because I kept tweaking resolve back and forth depending upon the scenario and I couldn't get everything to work.  When I rewrote this if test, though, I didn't think through what was happening with the name; I just copied the logic and created a bug.  8P


<!DOCTYPE html>

  <meta charset="utf-8">
  <title>Daniel Stanford | Instructional Technology Consultant > Fun Facts</title>
  <meta name="description" content="Daniel Stanford is an educational technology expert with over a decade of experience designing distance, hybrid, and web-enhanced courses.">
  <meta name="author" content="Daniel Stanford">

  <link type="text/css" rel="stylesheet" href="css/style.css">

Daniel Stanford

Home
 |

Experience
 |

Fun Facts

My Favorite Things

I love analyzing thing, organizing, and taking notes.

Fun Facts

I live in chicago.

rthyyjngnghjtujmymoo,

ij6ujiukkesyhw4y5u6ruj)

My Bucket List

Here are a few things I'd love to do in the future:

Hike the trail to Machu Picchu.

Meet "vulnerability guru" Brenée Brown.

Own a home overlooking the ocean.

Feel free to contact me at Email me!.


Configure your editor to use 2 spaces instead of a tab for indenting Ruby code.


I have created an issue for discussing this topic


@b6g an easy solution to your issue would be to add `var err error` above the initial line:

```go
var err error
output, err = s3manage.Upload(svc, input, opts)
_, err = io.Copy(dst, src) // * we cannot do this *
```

We are looking at changing the return type back to make this a little simpler.
Let's continue this discussion in #238 since this diff is quite large and my browser doesn't seem to enjoy having this page loaded.


Надеюсь, что пойму для чего все это нужно


Thanks for the example, this shows how jquery can be added after the fact.
It makes sense that it was left that way as it was a port, but it would have been better ported as a fork so we could see the commit history.


Shouldn't this be sizeof(*tlv) * count?


Same here


HI, what did you mean with "SD Card INIT Fail"


How does it matter sir ?


I'm not sure what the difference between the implementation in `CGUIWindowMusicBase` and `CGUIWindowMusicNav` is? You should only be able to use the "Scan" and "Stop scanning" context menu item on music sources AFAIK.


~ idea files ~ ~


Replace with Split


should remove this change!


Method no longer exists


null value do resolve to default : https://github.com/jenkinsci/docker-commons-plugin/blob/master/src/main/java/org/jenkinsci/plugins/docker/commons/tools/DockerTool.java#L99

I also dislike "Default", but most tool installation do use it. I'd prefer it would be labelled "System", and/or have "Default" select some ToolInstallation that has a special unique flag to be selected by admin as the default one. But as you said, this is a larger discussion, so I didn't changed this


Indeen line 567 already deals with it, thanks for explanation.


fixes #2


sfsdfsdfsdfsdf


@mattben  Is this supposed to be on this branch?


On looking closer, I see that there's more to their scoring algorithm, most notably the calculation of an average based on individual scores for each category. I'll hold on this detail until we get a chance to discuss the details of the scoring algorithm.


@raprasad Can you please let me know if I chose the right version when merging master into 4.0.1?


> If we decide to go with Closer then the method must implement io.Closer interface.

Ahah, it reminds me of these discussion about accidentally implementing an interface in Go :). I think it's fine if we don't implement it as long as we don't have a proper use case for it. Also if someone actually needs it someday, changing it to include an error will be trivial and shouldn't affect others who don't use it.


#fix 32


no I'm working on an assignment for @sterlingbaldwin to replace all ajax calls to use this function so we can separate js logic and service calls.


It is super cheap to include things in materials or not as the heavy lift only occurs if there is an aoMap actually defined -- so I am easy going as to whether or not to include it.  I think lightMaps + AO maps on BasicMaterial are fine and not having them are fine.  But I guess they should be specified together, either both or neither.


What is the purpose of the paragraph tags here? Is it for adding extra space at the end of the form?


Indeed, this is also a violation of the JS Interpreter's promise of handling infinite loops.  Ecampver said he'd fix this, but it has been a few months.  Later this week I'll be doing a quick refresh of this project and will remove the ability to pass in a comparator function if it is still like this.

I believe the only proper solution is to implement sort from scratch, JS's native sort cannot call an interpreted function in step-by-step mode.


There are a couple of concerns.  One, if you have a preferred API version, we should use it (saves round tripping).  The login flow is one place where negotiation is probably required (because you're talking to many servers), however, once you've talked to a server negotiation isn't likely to be needed.  So it's probably better to create the config and the client, then try to hit something, and if you get a server 404 you probably need to negotiate a different version.  That's more of a test flow than anything else, and shouldn't be part of regular client behavior.

Negotiate should be a method that takes a config and returns a config or error.

----- Original Message -----
> This call:
> https://github.com/openshift/origin/blob/master/pkg/client/client.go#L221
> will fail if the `config.Version` is not set, so `SetOpenShiftDefaults` is
> doing it at the last possible moment.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/deads2k/origin/commit/33784317c5726a2c36f64faa7670191c0927a109#commitcomment-11289107


Ich habs mit tg besprochen und wir haben uns auf diese einfache Variante entschieden. Die Browserweiche hätte ich gemacht und alles war bereit, doch tg fand, dass wir das nur allzu intensiv unterhalten müssten. Doch wir können es gerne nachholen, wenns was bringt. (no priority)


This is such a great tip -- thanks! When I went back and looked back at this project, I sorta cringed with the repetition I had, and I *almost* went back and changed up all the elsif statements below, probably by using an array like you suggest below. I think we had covered arrays when we did this project, but my mind was still being blown so I stayed away :)


Lack authenticate with twitter


`# Only the first 2 args are used` comment here again probably.


Cool; you can take a look at what I've been working with for service calls [here](https://github.com/mattben/acme-web-fe/blob/adff4db77910f3f795893422d367c55f8b47c7d4/templates/issues/issue.html#L109-L137) if you're interested...


Ignore commit prefix; it shouldn't be there


good. Fixed in eb5c70a


Related to #77


Ja aber da steht Mac egal welche Plattform ich habe. Sollte da nicht eher ein generischer Text stehen. Ich will auch keine Browserweiche.
Sowas wie: öffnen Sie das Kontext-Menü über dem Link.

> On 20.05.2015, at 19:23, Jürg Messmer <notifications@github.com> wrote:
>
> Ich habs mit tg besprochen und wir haben uns auf diese einfache Variante entschieden. Die Browserweiche hätte ich gemacht und alles war bereit, doch tg fand, dass wir das nur allzu intensiv unterhalten müssten. Doch wir können es gerne nachholen, wenns was bringt. (no priority)
>
> —
> Reply to this email directly or view it on GitHub.
>


Also that function totally won't work as-is; you're returning "{result:'', data:''}" every time


master (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks for all of your feedback, Kat! I appreciate the clarification of best practices with using if/elsif/else statements -- I am definitely still getting the hang of this whole logic thing. I will make a couple of small updates based on your suggestions, and then re-commit.


Pour le faire sur le dictionnaire français, on n'a qu'à sélectionner les mots qui font la même taille que les mots de départ et d'arrivée, ça réduit déjà la taille du graphe


<3 @rallytime