1: D100 Missing docstring in public module
55:1: I100 Imports statements are in the wrong order. import datetime should be before import time
57:1: I100 Imports statements are in the wrong order. import logging should be before import traceback
62:1: I201 Missing newline before sections or imports.
63:1: I100 Imports statements are in the wrong order. from socket should be before from intbitset
63:1: I201 Missing newline before sections or imports.
65:1: I101 Imported names are in the wrong order. Should be _db_login, run_sql
67:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.accounts.models
68:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_FLUSH_LOGS, CFG_BIBSCHED_PROCESS_USER, CFG_BINDIR, CFG_PREFIX, CFG_SITE_NAME, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_TMPDIR, CFG_VERSION
68:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.access.engine
68:1: F401 'CFG_PREFIX' imported but unused
81:1: I101 Imported names are in the wrong order. Should be CFG_EXTERNAL_AUTHENTICATION, CFG_EXTERNAL_AUTH_USING_SSO
82:49: E126 continuation line over-indented for hanging indent
83:1: I101 Imported names are in the wrong order. Should be get_email, get_email_from_username, get_user_preferences
83:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.modules.access.local_config
84:1: I101 Imported names are in the wrong order. Should be CFG_BIBSCHED_LOGDIR, CFG_BIBTASK_DEFAULT_GLOBAL_TASK_SETTINGS, CFG_BIBTASK_DEFAULT_TASK_SETTINGS, CFG_BIBTASK_FIXEDTIMETASKS, CFG_BIBTASK_LOG_FORMAT, CFG_BIBTASK_VALID_TASKS
84:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask_config should be before from invenio.legacy.webuser
94:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.utils.shell
95:1: I101 Imported names are in the wrong order. Should be bibsched_get_host, bibsched_set_host
96:41: E126 continuation line over-indented for hanging indent
110: D101 Missing docstring in public class
113:1: E302 expected 2 blank lines, found 1
113: D101 Missing docstring in public class
114: D102 Missing docstring in public method
118:1: E302 expected 2 blank lines, found 1
118: D400 First line should end with a period (not 't')
118: D205 1 blank line required between summary line and description (found 0)
141:13: E266 too many leading '#' for block comment
157: D205 1 blank line required between summary line and description (found 0)
184:17: E266 too many leading '#' for block comment
207:17: E266 too many leading '#' for block comment
227:17: E266 too many leading '#' for block comment
250:17: E266 too many leading '#' for block comment
273:17: E266 too many leading '#' for block comment
290:12: E713 test for membership should be 'not in'
310:86: F812 list comprehension redefines 'arg' from line 296
312:9: E266 too many leading '#' for block comment
316:13: E128 continuation line under-indented for visual indent
327: D401 First line should be in imperative mood ('Return', not 'Returns')
353: D401 First line should be in imperative mood ('Return', not 'Returns')
353: D400 First line should end with a period (not 'k')
366: D401 First line should be in imperative mood ('Return', not 'Returns')
366: D400 First line should end with a period (not 'k')
385: D400 First line should end with a period (not 's')
410: D400 First line should end with a period (not 'r')
430: D401 First line should be in imperative mood ('Set', not 'Sets')
458: D210 No whitespaces allowed surrounding docstring text
458: D205 1 blank line required between summary line and description (found 0)
488:18: E203 whitespace before ':'
489:31: E203 whitespace before ':'
490:20: E203 whitespace before ':'
491:29: E203 whitespace before ':'
492:15: E203 whitespace before ':'
493:18: E203 whitespace before ':'
494:20: E203 whitespace before ':'
495:18: E203 whitespace before ':'
496:19: E203 whitespace before ':'
497:24: E203 whitespace before ':'
498:18: E203 whitespace before ':'
534:33: E128 continuation line under-indented for visual indent
535:33: E128 continuation line under-indented for visual indent
536:33: E128 continuation line under-indented for visual indent
567:5: E303 too many blank lines (2)
643:1: E302 expected 2 blank lines, found 1
643: D210 No whitespaces allowed surrounding docstring text
643: D205 1 blank line required between summary line and description (found 0)
665:13: E128 continuation line under-indented for visual indent
701:41: E261 at least two spaces before inline comment
744:1: E302 expected 2 blank lines, found 1
744: D400 First line should end with a period (not 'k')
750:24: E203 whitespace before ':'
752:1: E302 expected 2 blank lines, found 1
752: D401 First line should be in imperative mood ('Return', not 'Returns')
752: D400 First line should end with a period (not 'k')
762:1: E302 expected 2 blank lines, found 1
762: D400 First line should end with a period (not 'S')
769:1: E302 expected 2 blank lines, found 1
769: D401 First line should be in imperative mood ('Return', not 'Returns')
769: D400 First line should end with a period (not 'm')
779:1: E302 expected 2 blank lines, found 1
779: D400 First line should end with a period (not 'm')
785:28: E203 whitespace before ':'
787:1: E302 expected 2 blank lines, found 1
787: D401 First line should be in imperative mood ('Update', not 'Updates')
792:13: E128 continuation line under-indented for visual indent
794:1: E302 expected 2 blank lines, found 1
794: D401 First line should be in imperative mood ('Update', not 'Updates')
799:13: E128 continuation line under-indented for visual indent
801:1: E302 expected 2 blank lines, found 1
804:9: E128 continuation line under-indented for visual indent
811:1: E302 expected 2 blank lines, found 1
811: D400 First line should end with a period (not 'e')
818:1: E302 expected 2 blank lines, found 1
818: D205 1 blank line required between summary line and description (found 0)
844:1: E302 expected 2 blank lines, found 0
844: D401 First line should be in imperative mood ('Return', not 'Returns')
844: D209 Multi-line docstring closing quotes should be on a separate line
844: D205 1 blank line required between summary line and description (found 0)
844: D208 Docstring is over-indented
866: D401 First line should be in imperative mood ('Thi', not 'This')
866: D400 First line should end with a period (not ',')
866: D205 1 blank line required between summary line and description (found 0)
904:1: E302 expected 2 blank lines, found 1
904: D400 First line should end with a period (not 'n')
904: D205 1 blank line required between summary line and description (found 0)
915:1: E302 expected 2 blank lines, found 1
915: D202 No blank lines allowed after function docstring (found 1)
915: D205 1 blank line required between summary line and description (found 0)
944:5: E266 too many leading '#' for block comment
975:68: F821 undefined name 'Tru'
986:13: E266 too many leading '#' for block comment
993:1: E302 expected 2 blank lines, found 1
993: D401 First line should be in imperative mood ('Submit', not 'Submits')
993: D209 Multi-line docstring closing quotes should be on a separate line
993: D202 No blank lines allowed after function docstring (found 1)
993: D400 First line should end with a period (not 'l')
993: D205 1 blank line required between summary line and description (found 0)
993: D208 Docstring is over-indented
997:5: E266 too many leading '#' for block comment
1000:5: E266 too many leading '#' for block comment
1002:5: E266 too many leading '#' for block comment
1005:5: E266 too many leading '#' for block comment
1015:9: E128 continuation line under-indented for visual indent
1020:5: E266 too many leading '#' for block comment
1025: D401 First line should be in imperative mood ('Return', not 'Returns')
1025: D209 Multi-line docstring closing quotes should be on a separate line
1025: D400 First line should end with a period (not 'k')
1025: D205 1 blank line required between summary line and description (found 0)
1030:9: E128 continuation line under-indented for visual indent
1035:13: E128 continuation line under-indented for visual indent
1089: D400 First line should end with a period (not 'n')
1095:25: E127 continuation line over-indented for visual indent
1103: D400 First line should end with a period (not 'n')
1109: D401 First line should be in imperative mood ('Run', not 'Runs')
1109: D209 Multi-line docstring closing quotes should be on a separate line
1109: D202 No blank lines allowed after function docstring (found 1)
1109: D205 1 blank line required between summary line and description (found 0)
1119:5: E266 too many leading '#' for block comment
1126:13: E128 continuation line under-indented for visual indent
1135:5: E266 too many leading '#' for block comment
1139:13: E128 continuation line under-indented for visual indent
1162:17: E266 too many leading '#' for block comment
1163:211: E261 at least two spaces before inline comment
1164:199: E261 at least two spaces before inline comment
1174:13: E128 continuation line under-indented for visual indent
1179:5: E266 too many leading '#' for block comment
1186:5: E266 too many leading '#' for block comment
1189:5: E266 too many leading '#' for block comment
1211:13: E266 too many leading '#' for block comment
1213:17: E266 too many leading '#' for block comment
1220:17: E266 too many leading '#' for block comment
1230:13: E266 too many leading '#' for block comment
1232:9: E266 too many leading '#' for block comment
1253: D401 First line should be in imperative mood ('Print', not 'Prints')
1263:9: E128 continuation line under-indented for visual indent
1265:9: E128 continuation line under-indented for visual indent
1267:9: E128 continuation line under-indented for visual indent
1268:9: E128 continuation line under-indented for visual indent
1272:9: E128 continuation line under-indented for visual indent
1273:9: E128 continuation line under-indented for visual indent
1274:9: E128 continuation line under-indented for visual indent
1281:9: E128 continuation line under-indented for visual indent
1294:1: E302 expected 2 blank lines, found 1
1298:13: E128 continuation line under-indented for visual indent
1303:1: E302 expected 2 blank lines, found 1
1306:13: E128 continuation line under-indented for visual indent
1308:25: E261 at least two spaces before inline comment
1311:1: E302 expected 2 blank lines, found 1
1314:13: E128 continuation line under-indented for visual indent
1322:1: E302 expected 2 blank lines, found 1
1322: D209 Multi-line docstring closing quotes should be on a separate line
1328:13: E128 continuation line under-indented for visual indent
1332:1: E302 expected 2 blank lines, found 1
1337:1: E302 expected 2 blank lines, found 0
1354:1: E302 expected 2 blank lines, found 1
1354: D205 1 blank line required between summary line and description (found 0)
1369:1: E302 expected 2 blank lines, found 1
1369: D400 First line should end with a period (not 'r')
1369: D205 1 blank line required between summary line and description (found 0)
1386:63: E502 the backslash is redundant between brackets
1387:13: E128 continuation line under-indented for visual indent
1389:57: E261 at least two spaces before inline comment
1396:63: E502 the backslash is redundant between brackets
1397:9: E128 continuation line under-indented for visual indent


1: D400 First line should end with a period (not ']')
54:1: E402 module level import not at top of file
55:1: I100 Imports statements are in the wrong order. import optparse should be before import sys
55:1: E402 module level import not at top of file
56:1: I201 Missing newline before sections or imports.
56:1: E402 module level import not at top of file
57:1: I100 Imports statements are in the wrong order. import time should be before import pkg_resources
57:1: I201 Missing newline before sections or imports.
57:1: E402 module level import not at top of file
58:1: I100 Imports statements are in the wrong order. import ConfigParser should be before import time
58:1: E402 module level import not at top of file
59:1: I201 Missing newline before sections or imports.
59:1: E402 module level import not at top of file
60:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from invenio.utils.date
60:1: E402 module level import not at top of file
61:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.legacy.dbquery
61:1: E402 module level import not at top of file
62:1: E402 module level import not at top of file
63:1: I101 Imported names are in the wrong order. Should be run_bibsort_rebalance, run_bibsort_update
63:1: E402 module level import not at top of file
64:29: E126 continuation line over-indented for hanging indent
65:1: I101 Imported names are in the wrong order. Should be task_get_option, task_init, task_set_option, write_message
65:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.legacy.bibsort.engine
65:1: E402 module level import not at top of file
68:1: E402 module level import not at top of file
71: D401 First line should be in imperative mood ('Load', not 'Loads')
71: D400 First line should end with a period (not 'e')
81:60: E502 the backslash is redundant between brackets
82:24: E225 missing whitespace around operator
93:41: E225 missing whitespace around operator
102:74: E502 the backslash is redundant between brackets
103:24: E225 missing whitespace around operator
107: D401 First line should be in imperative mood ('Create', not 'Creates')
107: D400 First line should end with a period (not 's')
113:61: E225 missing whitespace around operator
125:28: E127 continuation line over-indented for visual indent
126:53: E225 missing whitespace around operator
132:80: E502 the backslash is redundant between brackets
133:28: E225 missing whitespace around operator
141: D401 First line should be in imperative mood ('Run', not 'Runs')
141: D209 Multi-line docstring closing quotes should be on a separate line
141: D400 First line should end with a period (not 's')
141: D205 1 blank line required between summary line and description (found 0)
162:59: E225 missing whitespace around operator
169: D401 First line should be in imperative mood ('Run', not 'Runs')
169: D209 Multi-line docstring closing quotes should be on a separate line
169: D400 First line should end with a period (not 'r')
169: D205 1 blank line required between summary line and description (found 0)
178: D401 First line should be in imperative mood ('Output', not 'Outputs')
178: D400 First line should end with a period (not 'B')
184:57: E225 missing whitespace around operator
191:42: E225 missing whitespace around operator
199: D401 First line should be in imperative mood ('Run', not 'Runs')
199: D400 First line should end with a period (not 's')
202:74: E502 the backslash is redundant between brackets
203:9: E128 continuation line under-indented for visual indent
204:74: E502 the backslash is redundant between brackets
205:9: E128 continuation line under-indented for visual indent
207:9: E128 continuation line under-indented for visual indent
207:30: E502 the backslash is redundant between brackets
208:9: E128 continuation line under-indented for visual indent
209:72: E502 the backslash is redundant between brackets
210:9: E128 continuation line under-indented for visual indent
211:77: E502 the backslash is redundant between brackets
212:9: E128 continuation line under-indented for visual indent
213:75: E502 the backslash is redundant between brackets
214:9: E128 continuation line under-indented for visual indent
214:28: E502 the backslash is redundant between brackets
215:9: E128 continuation line under-indented for visual indent
216:69: E502 the backslash is redundant between brackets
217:9: E128 continuation line under-indented for visual indent
217:27: E502 the backslash is redundant between brackets
218:9: E128 continuation line under-indented for visual indent
226:9: E125 continuation line with same indent as next logical line
243: D400 First line should end with a period (not 'k')
247:26: E251 unexpected spaces around keyword / parameter equals
247:28: E251 unexpected spaces around keyword / parameter equals
287: D209 Multi-line docstring closing quotes should be on a separate line
287: D202 No blank lines allowed after function docstring (found 1)
287: D400 First line should end with a period (not 'e')
287: D205 1 blank line required between summary line and description (found 0)
331: D400 First line should end with a period (not 'k')
338:74: E502 the backslash is redundant between brackets


1: D400 First line should end with a period (not 'e')
23:1: I100 Imports statements are in the wrong order. import sys should be before import six
23:1: I201 Missing newline before sections or imports.
29:1: I101 Imported names are in the wrong order. Should be deserialize_via_marshal, serialize_via_marshal
31:1: I101 Imported names are in the wrong order. Should be task_sleep_now_if_required, task_update_progress, write_message
31:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.serializers
39:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from sqlalchemy.exc
46:44: E251 unexpected spaces around keyword / parameter equals
46:46: E251 unexpected spaces around keyword / parameter equals
46: D401 First line should be in imperative mood ('Return', not 'Returns')
46: D209 Multi-line docstring closing quotes should be on a separate line
46: D205 1 blank line required between summary line and description (found 0)
57:75: E502 the backslash is redundant between brackets
58:65: E502 the backslash is redundant between brackets
59:28: E225 missing whitespace around operator
70:78: E502 the backslash is redundant between brackets
71:83: E502 the backslash is redundant between brackets
72:32: E225 missing whitespace around operator
85:44: E261 at least two spaces before inline comment
85:44: E262 inline comment should start with '# '
85: D401 First line should be in imperative mood ('Return', not 'Returns')
85: D400 First line should end with a period (not 'm')
91:30: E261 at least two spaces before inline comment
100: D401 First line should be in imperative mood ('Return', not 'Returns')
100: D209 Multi-line docstring closing quotes should be on a separate line
100: D400 First line should end with a period (not 'n')
100: D205 1 blank line required between summary line and description (found 0)
109: D401 First line should be in imperative mood ('Find', not 'Finds')
109: D400 First line should end with a period (not 'g')
109: D300 Use """triple double quotes""" (found '''-quotes)
118:66: E502 the backslash is redundant between brackets
119:46: E225 missing whitespace around operator
137:8: E114 indentation is not a multiple of four (comment)
151: D209 Multi-line docstring closing quotes should be on a separate line
151: D400 First line should end with a period (not 'y')
151: D205 1 blank line required between summary line and description (found 0)
151: D300 Use """triple double quotes""" (found '''-quotes)
162:68: E502 the backslash is redundant between brackets
163:24: E225 missing whitespace around operator
174: D401 First line should be in imperative mood ('Return', not 'Returns')
174: D400 First line should end with a period (not 'd')
174: D300 Use """triple double quotes""" (found '''-quotes)
182:91: E502 the backslash is redundant between brackets
183:28: E225 missing whitespace around operator
186:72: E502 the backslash is redundant between brackets
187:60: E502 the backslash is redundant between brackets
188:24: E225 missing whitespace around operator
192: D209 Multi-line docstring closing quotes should be on a separate line
192: D400 First line should end with a period (not 'y')
192: D205 1 blank line required between summary line and description (found 0)
192: D300 Use """triple double quotes""" (found '''-quotes)
197:73: E225 missing whitespace around operator
198:96: E502 the backslash is redundant between brackets
198:56: E231 missing whitespace after ','
198:76: E231 missing whitespace after ','
199:56: E231 missing whitespace after ','
204: D401 First line should be in imperative mood ('Return', not 'Returns')
204: D205 1 blank line required between summary line and description (found 0)
214:63: E502 the backslash is redundant between brackets
215:28: E225 missing whitespace around operator
217:76: E502 the backslash is redundant between brackets
217:70: E225 missing whitespace around operator
224:58: E502 the backslash is redundant between brackets
225:28: E225 missing whitespace around operator
227:65: E225 missing whitespace around operator
238:80: E502 the backslash is redundant between brackets
239:24: E225 missing whitespace around operator
243: D400 First line should end with a period (not 'n')
243: D300 Use """triple double quotes""" (found '''-quotes)
249:34: E261 at least two spaces before inline comment
249:34: E262 inline comment should start with '# '
252:50: E225 missing whitespace around operator
258:60: E502 the backslash is redundant between brackets
259:24: E225 missing whitespace around operator
261:1: E302 expected 2 blank lines, found 1
261: D401 First line should be in imperative mood ('Identifie', not 'Identifies')
261: D400 First line should end with a period (not 't')
268:1: E302 expected 2 blank lines, found 1
268: D401 First line should be in imperative mood ('Doe', not 'Does')
268: D209 Multi-line docstring closing quotes should be on a separate line
268: D400 First line should end with a period (not 'e')
268: D205 1 blank line required between summary line and description (found 0)
276:80: E502 the backslash is redundant between brackets
277:24: E225 missing whitespace around operator
283:17: E127 continuation line over-indented for visual indent
284:76: E502 the backslash is redundant between brackets
292:81: E502 the backslash is redundant between brackets
297:86: E502 the backslash is redundant between brackets
304: D400 First line should end with a period (not 'A')
316:17: E261 at least two spaces before inline comment
317:65: E502 the backslash is redundant between brackets
318:60: E225 missing whitespace around operator
325:43: E502 the backslash is redundant between brackets
326:13: E128 continuation line under-indented for visual indent
326:77: E502 the backslash is redundant between brackets
329:80: E502 the backslash is redundant between brackets
330:50: E225 missing whitespace around operator
332:75: E502 the backslash is redundant between brackets
337: D400 First line should end with a period (not 'S')
339:64: E502 the backslash is redundant between brackets
340:50: E502 the backslash is redundant between brackets
341:20: E225 missing whitespace around operator
342:60: E225 missing whitespace around operator
347:119: E502 the backslash is redundant between brackets
350:17: E261 at least two spaces before inline comment
354:62: E502 the backslash is redundant between brackets
359:43: E502 the backslash is redundant between brackets
360:13: E128 continuation line under-indented for visual indent
362:81: E502 the backslash is redundant between brackets
363:58: E225 missing whitespace around operator
365:57: E502 the backslash is redundant between brackets
366:50: E225 missing whitespace around operator
370: D209 Multi-line docstring closing quotes should be on a separate line
370: D205 1 blank line required between summary line and description (found 0)
374:66: E502 the backslash is redundant between brackets
375:20: E225 missing whitespace around operator
383:42: E225 missing whitespace around operator
387:38: E225 missing whitespace around operator
392: D209 Multi-line docstring closing quotes should be on a separate line
392: D400 First line should end with a period (not 's')
392: D205 1 blank line required between summary line and description (found 0)
397:54: E502 the backslash is redundant between brackets
432: D401 First line should be in imperative mood ('Return', not 'Returns')
432: D209 Multi-line docstring closing quotes should be on a separate line
432: D202 No blank lines allowed after function docstring (found 1)
432: D400 First line should end with a period (not 'r')
432: D205 1 blank line required between summary line and description (found 0)
438:24: E261 at least two spaces before inline comment
438:25: E262 inline comment should start with '# '
447:73: E502 the backslash is redundant between brackets
448:51: E225 missing whitespace around operator
457:63: E502 the backslash is redundant between brackets
458:49: E225 missing whitespace around operator
463: D401 First line should be in imperative mood ('Return', not 'Returns')
463: D400 First line should end with a period (not 's')
465:53: E502 the backslash is redundant between brackets
469: D401 First line should be in imperative mood ('Return', not 'Returns')
469: D209 Multi-line docstring closing quotes should be on a separate line
469: D400 First line should end with a period (not ':')
469: D205 1 blank line required between summary line and description (found 0)
478:13: F841 local variable 'dummy' is assigned to but never used
483:27: E261 at least two spaces before inline comment
483:28: E262 inline comment should start with '# '
488: D401 First line should be in imperative mood ('Return', not 'Returns')
488: D209 Multi-line docstring closing quotes should be on a separate line
488: D400 First line should end with a period (not ',')
488: D205 1 blank line required between summary line and description (found 0)
500:75: E502 the backslash is redundant between brackets
501:23: E128 continuation line under-indented for visual indent
501:24: E225 missing whitespace around operator
515:72: E502 the backslash is redundant between brackets
516:69: E225 missing whitespace around operator
518:83: E502 the backslash is redundant between brackets
519:23: E128 continuation line under-indented for visual indent
519:24: E225 missing whitespace around operator
526: D401 First line should be in imperative mood ('Thi', not 'This')
526: D209 Multi-line docstring closing quotes should be on a separate line
526: D400 First line should end with a period (not 'd')
526: D205 1 blank line required between summary line and description (found 0)
533:5: B901 blind except: statement
537:1: E302 expected 2 blank lines, found 1
537: D401 First line should be in imperative mood ('Thi', not 'This')
537: D209 Multi-line docstring closing quotes should be on a separate line
537: D400 First line should end with a period (not 'd')
537: D205 1 blank line required between summary line and description (found 0)
552:20: E261 at least two spaces before inline comment
556:1: E302 expected 2 blank lines, found 1
556: D401 First line should be in imperative mood ('Thi', not 'This')
556: D209 Multi-line docstring closing quotes should be on a separate line
556: D400 First line should end with a period (not 'e')
556: D205 1 blank line required between summary line and description (found 0)
566:1: E302 expected 2 blank lines, found 1
566:59: E251 unexpected spaces around keyword / parameter equals
566:61: E251 unexpected spaces around keyword / parameter equals
566: D401 First line should be in imperative mood ('Update', not 'Updates')
566: D209 Multi-line docstring closing quotes should be on a separate line
566: D202 No blank lines allowed after function docstring (found 1)
566: D400 First line should end with a period (not 'd')
566: D205 1 blank line required between summary line and description (found 0)
577:69: E502 the backslash is redundant between brackets
578:46: E225 missing whitespace around operator
587:75: E502 the backslash is redundant between brackets
588:24: E225 missing whitespace around operator
589:21: E261 at least two spaces before inline comment
589:22: E262 inline comment should start with '# '
593:83: E502 the backslash is redundant between brackets
594:24: E225 missing whitespace around operator
608:14: E261 at least two spaces before inline comment
622:60: E502 the backslash is redundant between brackets
623:28: E225 missing whitespace around operator
626:69: E502 the backslash is redundant between brackets
627:33: E128 continuation line under-indented for visual indent
629:60: E502 the backslash is redundant between brackets
630:28: E225 missing whitespace around operator
632:69: E502 the backslash is redundant between brackets
633:33: E128 continuation line under-indented for visual indent
635:59: E502 the backslash is redundant between brackets
636:28: E225 missing whitespace around operator
646:68: E502 the backslash is redundant between brackets
647:42: E128 continuation line under-indented for visual indent
655:85: E502 the backslash is redundant between brackets
656:28: E225 missing whitespace around operator
661:117: E251 unexpected spaces around keyword / parameter equals
661:119: E251 unexpected spaces around keyword / parameter equals
661: D401 First line should be in imperative mood ('Update', not 'Updates')
661: D400 First line should end with a period (not 's')
665:62: E225 missing whitespace around operator
670:64: E502 the backslash is redundant between brackets
671:24: E225 missing whitespace around operator
692:17: E125 continuation line with same indent as next logical line
708:72: E502 the backslash is redundant between brackets
720:66: E502 the backslash is redundant between brackets
721:21: E128 continuation line under-indented for visual indent
725:66: E502 the backslash is redundant between brackets
726:21: E128 continuation line under-indented for visual indent
727:64: E225 missing whitespace around operator
730: D401 First line should be in imperative mood ('Modifie', not 'Modifies')
730: D209 Multi-line docstring closing quotes should be on a separate line
730: D400 First line should end with a period (not 'n')
730: D205 1 blank line required between summary line and description (found 0)
739: D401 First line should be in imperative mood ('Insert', not 'Inserts')
739: D400 First line should end with a period (not 's')
748:50: E261 at least two spaces before inline comment
748:50: E262 inline comment should start with '# '
754:34: E261 at least two spaces before inline comment
754:35: E262 inline comment should start with '# '
761:23: E261 at least two spaces before inline comment
761:24: E262 inline comment should start with '# '
768:38: E225 missing whitespace around operator
772: D400 First line should end with a period (not 's')
780:38: E225 missing whitespace around operator
784: D209 Multi-line docstring closing quotes should be on a separate line
784: D400 First line should end with a period (not 'w')
784: D205 1 blank line required between summary line and description (found 0)
794: D400 First line should end with a period (not ')')
811: D401 First line should be in imperative mood ('Update', not 'Updates')
811: D209 Multi-line docstring closing quotes should be on a separate line
811: D202 No blank lines allowed after function docstring (found 1)
811: D400 First line should end with a period (not 't')
811: D205 1 blank line required between summary line and description (found 0)
821:66: E502 the backslash is redundant between brackets
822:59: E502 the backslash is redundant between brackets
823:20: E225 missing whitespace around operator
849:27: E261 at least two spaces before inline comment
856:61: E225 missing whitespace around operator
857:71: E225 missing whitespace around operator
860:82: E502 the backslash is redundant between brackets
861:28: E225 missing whitespace around operator
866:32: E261 at least two spaces before inline comment
870:28: E261 at least two spaces before inline comment
870:29: E262 inline comment should start with '# '
873:82: E502 the backslash is redundant between brackets
874:27: E128 continuation line under-indented for visual indent
876:84: E502 the backslash is redundant between brackets
877:19: E128 continuation line under-indented for visual indent
877:20: E225 missing whitespace around operator
882:56: E225 missing whitespace around operator
883:58: E225 missing whitespace around operator
886:87: E502 the backslash is redundant between brackets
887:27: E128 continuation line under-indented for visual indent
887:28: E225 missing whitespace around operator
892:38: E251 unexpected spaces around keyword / parameter equals
892:40: E251 unexpected spaces around keyword / parameter equals
892: D401 First line should be in imperative mood ('Rebalance', not 'Rebalances')
892: D400 First line should end with a period (not 't')
904:58: E225 missing whitespace around operator
906:23: E261 at least two spaces before inline comment
908:62: E502 the backslash is redundant between brackets
909:24: E225 missing whitespace around operator
915:56: E225 missing whitespace around operator
916:70: E502 the backslash is redundant between brackets
917:27: E127 continuation line over-indented for visual indent
917:28: E225 missing whitespace around operator
919:33: E128 continuation line under-indented for visual indent
920:33: E128 continuation line under-indented for visual indent
921:33: E128 continuation line under-indented for visual indent
923:72: E502 the backslash is redundant between brackets
924:28: E225 missing whitespace around operator
932: D401 First line should be in imperative mood ('test', not 'tests')
932: D400 First line should end with a period (not 's')


46:1: I100 Imports statements are in the wrong order. from thread should be before from invenio.utils.datastructures
277:13: F821 undefined name 'OperationalError'
277:31: F821 undefined name 'InterfaceError'
289:17: F821 undefined name 'OperationalError'
289:35: F821 undefined name 'InterfaceError'
363:17: F821 undefined name 'OperationalError'
363:35: F821 undefined name 'InterfaceError'
370:21: F821 undefined name 'OperationalError'
370:39: F821 undefined name 'InterfaceError'


1: D100 Missing docstring in public module
83:1: E402 module level import not at top of file
84:1: I101 Imported names are in the wrong order. Should be IndentedHelpFormatter, Option, OptionError, OptionGroup, OptionParser
84:1: E402 module level import not at top of file
86:1: I100 Imports statements are in the wrong order. import os should be before from optparse
86:1: E402 module level import not at top of file
87:1: I201 Missing newline before sections or imports.
87:1: E402 module level import not at top of file
88:1: I100 Imports statements are in the wrong order. import random should be before import pkg_resources
88:1: I201 Missing newline before sections or imports.
88:1: F401 'random' imported but unused
88:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: E402 module level import not at top of file
91:1: E402 module level import not at top of file
92:1: F401 'string' imported but unused
92:1: E402 module level import not at top of file
93:1: E402 module level import not at top of file
94:1: E402 module level import not at top of file
95:1: I201 Missing newline before sections or imports.
95:1: E402 module level import not at top of file
96:1: I100 Imports statements are in the wrong order. from warnings should be before from six
96:1: I201 Missing newline before sections or imports.
96:1: E402 module level import not at top of file
97:1: I201 Missing newline before sections or imports.
97:1: E402 module level import not at top of file
105: D210 No whitespaces allowed surrounding docstring text
105: D400 First line should end with a period (not 'o')
116: D202 No blank lines allowed after function docstring (found 1)
116: D400 First line should end with a period (not 'g')
116: D205 1 blank line required between summary line and description (found 0)
122:5: E266 too many leading '#' for block comment
125:5: E266 too many leading '#' for block comment
137:5: E266 too many leading '#' for block comment
153:5: E266 too many leading '#' for block comment
158:5: E266 too many leading '#' for block comment
164:5: E266 too many leading '#' for block comment
168:5: E266 too many leading '#' for block comment
219:5: E266 too many leading '#' for block comment
226:5: E266 too many leading '#' for block comment
267:5: E266 too many leading '#' for block comment
272:5: E266 too many leading '#' for block comment
277:5: E266 too many leading '#' for block comment
285:5: E266 too many leading '#' for block comment
289:5: E266 too many leading '#' for block comment
311:5: E266 too many leading '#' for block comment
315: D103 Missing docstring in public function
321: D400 First line should end with a period (not 's')
321: D205 1 blank line required between summary line and description (found 0)
337: D205 1 blank line required between summary line and description (found 0)
344:5: E266 too many leading '#' for block comment
346:21: E127 continuation line over-indented for visual indent
347:5: E266 too many leading '#' for block comment
351:50: E502 the backslash is redundant between brackets
352:25: E127 continuation line over-indented for visual indent
352:66: E502 the backslash is redundant between brackets
353:25: E127 continuation line over-indented for visual indent
364: D205 1 blank line required between summary line and description (found 0)
371:5: E266 too many leading '#' for block comment
373:21: E127 continuation line over-indented for visual indent
374:5: E266 too many leading '#' for block comment
377:5: E266 too many leading '#' for block comment
393: D400 First line should end with a period (not '6')
393: D205 1 blank line required between summary line and description (found 0)
410: D400 First line should end with a period (not 'r')
410: D205 1 blank line required between summary line and description (found 0)
418:5: E266 too many leading '#' for block comment
420:14: E127 continuation line over-indented for visual indent
421:5: E266 too many leading '#' for block comment
424:16: E126 continuation line over-indented for hanging indent
425:13: E266 too many leading '#' for block comment
439:45: E128 continuation line under-indented for visual indent
440:45: E128 continuation line under-indented for visual indent
449: D400 First line should end with a period (not 'd')
449: D205 1 blank line required between summary line and description (found 0)
477: D209 Multi-line docstring closing quotes should be on a separate line
477: D400 First line should end with a period (not 'n')
477: D205 1 blank line required between summary line and description (found 0)
504:32: F841 local variable 'err' is assigned to but never used
524: D209 Multi-line docstring closing quotes should be on a separate line
524: D400 First line should end with a period (not 'n')
524: D205 1 blank line required between summary line and description (found 0)
538: D200 One-line docstring should fit on one line with quotes (found 3)
543:5: F401 'run_sql' imported but unused
557: D400 First line should end with a period (not 'N')
557: D205 1 blank line required between summary line and description (found 0)
567:5: E266 too many leading '#' for block comment
569:5: E266 too many leading '#' for block comment
571:5: E266 too many leading '#' for block comment
574:9: E266 too many leading '#' for block comment
575:9: E266 too many leading '#' for block comment
591:9: E266 too many leading '#' for block comment
597:49: E128 continuation line under-indented for visual indent
602:9: E266 too many leading '#' for block comment
608:82: E231 missing whitespace after ','
623: D400 First line should end with a period (not 's')
623: D205 1 blank line required between summary line and description (found 0)
642: D209 Multi-line docstring closing quotes should be on a separate line
642: D205 1 blank line required between summary line and description (found 0)
667: D103 Missing docstring in public function
677: D103 Missing docstring in public function
712:72: E502 the backslash is redundant between brackets
713:20: E127 continuation line over-indented for visual indent
713:44: E231 missing whitespace after ','
717:35: E261 at least two spaces before inline comment
736:21: E128 continuation line under-indented for visual indent
736:93: E231 missing whitespace after ','
754:50: E231 missing whitespace after ','
774:48: E231 missing whitespace after ','
827: D400 First line should end with a period (not 'e')
827: D205 1 blank line required between summary line and description (found 0)
849: D400 First line should end with a period (not 's')
849: D205 1 blank line required between summary line and description (found 0)
864: D400 First line should end with a period (not 'r')
864: D205 1 blank line required between summary line and description (found 0)
874:10: E122 continuation line missing indentation or outdented
887: D200 One-line docstring should fit on one line with quotes (found 3)
902: D400 First line should end with a period (not 'y')
902: D205 1 blank line required between summary line and description (found 0)
921: D400 First line should end with a period (not 'L')
921: D205 1 blank line required between summary line and description (found 0)
936: D400 First line should end with a period (not 's')
936: D200 One-line docstring should fit on one line with quotes (found 3)
950: D400 First line should end with a period (not 's')
950: D200 One-line docstring should fit on one line with quotes (found 3)
964: D400 First line should end with a period (not 'd')
964: D200 One-line docstring should fit on one line with quotes (found 3)
978: D200 One-line docstring should fit on one line with quotes (found 3)
992: D202 No blank lines allowed after function docstring (found 1)
995: D203 1 blank line required before class docstring (found 0)
995: D204 1 blank line required after class docstring (found 0)
995: D400 First line should end with a period (not 'l')
1111: D210 No whitespaces allowed surrounding docstring text
1111: D400 First line should end with a period (not 's')
1150:9: E266 too many leading '#' for block comment
1206:21: B901 blind except: statement


22:1: E402 module level import not at top of file
23:1: I100 Imports statements are in the wrong order. import os should be before import re
23:1: E402 module level import not at top of file
24:1: I100 Imports statements are in the wrong order. import cgi should be before import os
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. import tempfile should be before import urllib
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. import datetime should be before import tempfile
27:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
30:1: I101 Imported names are in the wrong order. Should be CFG_BINDIR, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_URL, CFG_TMPDIR
30:1: I201 Missing newline before sections or imports.
30:1: E402 module level import not at top of file
36:1: E402 module level import not at top of file
37:1: I101 Imported names are in the wrong order. Should be addadminbox, write_outcome
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.adminlib should be before from invenio.legacy.oaiharvest.config
37:1: E402 module level import not at top of file
40:1: I101 Imported names are in the wrong order. Should be delete_holdingpen_entry, get_day_logs_size, get_entry_history, get_entry_logs_size, get_history_entries_for_day, get_holdingpen_day_fragment, get_holdingpen_entry_details, get_holdingpen_month, get_holdingpen_year, get_holdingpen_years, get_month_logs_size
40:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
48:1: E402 module level import not at top of file
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord.xmlmarc2textmarc should be before import invenio.legacy.template
49:1: E402 module level import not at top of file
51:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.bibrecord.xmlmarc2textmarc
51:1: E402 module level import not at top of file
52:1: E402 module level import not at top of file
53:1: I101 Imported names are in the wrong order. Should be task_log_path, task_low_level_submission
53:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.url
53:1: E402 module level import not at top of file
55:1: I101 Imported names are in the wrong order. Should be get_email, get_user_info
55:1: E402 module level import not at top of file
57:1: E402 module level import not at top of file
61:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.serializers
61:1: E402 module level import not at top of file
437: D401 First line should be in imperative mood ('create', not 'creates')
437: D400 First line should end with a period (not 'e')
437: D200 One-line docstring should fit on one line with quotes (found 2)
494: D400 First line should end with a period (not 'e')
521:13: W503 line break before binary operator
522:13: W503 line break before binary operator
527:13: W503 line break before binary operator
528:13: W503 line break before binary operator
541:5: E266 too many leading '#' for block comment
627:5: E266 too many leading '#' for block comment
634:9: F841 local variable 'sets_names' is assigned to but never used
664: D401 First line should be in imperative mood ('return', not 'returns')
664: D400 First line should end with a period (not 'e')
664: D208 Docstring is over-indented
664: D200 One-line docstring should fit on one line with quotes (found 3)
675: D401 First line should be in imperative mood ('return', not 'returns')
675: D400 First line should end with a period (not 'e')
675: D208 Docstring is over-indented
675: D200 One-line docstring should fit on one line with quotes (found 3)
686: D103 Missing docstring in public function
722:1: E266 too many leading '#' for block comment
725: D103 Missing docstring in public function
791: D103 Missing docstring in public function
804: D210 No whitespaces allowed surrounding docstring text
804: D400 First line should end with a period (not 'a')
804: D205 1 blank line required between summary line and description (found 0)
804: D208 Docstring is over-indented
844: D103 Missing docstring in public function
949:59: W503 line break before binary operator
966: D400 First line should end with a period (not 'd')
1017:1: E266 too many leading '#' for block comment
1021: D401 First line should be in imperative mood ('Harvest', not 'Harvests')
1021: D400 First line should end with a period (not 't')
1021: D208 Docstring is over-indented
1021: D200 One-line docstring should fit on one line with quotes (found 3)
1033: D103 Missing docstring in public function
1045: D401 First line should be in imperative mood ('Format', not 'Formats')
1045: D205 1 blank line required between summary line and description (found 0)
1072: D400 First line should end with a period (not 't')
1082:15: E711 comparison to None should be 'if cond is None:'
1086:19: E711 comparison to None should be 'if cond is None:'
1102: D401 First line should be in imperative mood ('Launche', not 'Launches')
1102: D200 One-line docstring should fit on one line with quotes (found 3)
1123: D400 First line should end with a period (not 'd')
1143: D400 First line should end with a period (not 'w')
1153: D103 Missing docstring in public function
1157:1: E266 too many leading '#' for block comment
1161: D103 Missing docstring in public function
1184: D210 No whitespaces allowed surrounding docstring text
1184: D400 First line should end with a period (not 'd')
1248:1: E266 too many leading '#' for block comment
1250: D103 Missing docstring in public function
1294: D103 Missing docstring in public function
1300:5: B901 blind except: statement
1311:5: B901 blind except: statement
1321:5: B901 blind except: statement
1345: D103 Missing docstring in public function
1351: D103 Missing docstring in public function
1360: D103 Missing docstring in public function
1379: D103 Missing docstring in public function
1388: D103 Missing docstring in public function
1399: D103 Missing docstring in public function
1410: D103 Missing docstring in public function
1417: D103 Missing docstring in public function
1421: D103 Missing docstring in public function
1427: D208 Docstring is over-indented
1473: D202 No blank lines allowed after function docstring (found 1)
1552: D401 First line should be in imperative mood ('Find', not 'Finds')


24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.utils.json
29:1: E402 module level import not at top of file
30:1: I101 Imported names are in the wrong order. Should be CFG_SITE_LANG, CFG_SITE_URL
30:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.webpage
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.adminlib should be before from invenio.legacy.webuser
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.oaiharvest.config should be before from invenio.legacy.oaiharvest.dblayer
34:1: E402 module level import not at top of file
35:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.oaiharvest.config
35:1: E402 module level import not at top of file
37:1: E402 module level import not at top of file
39:1: E302 expected 2 blank lines, found 1
39: D400 First line should end with a period (not 'e')
67: D103 Missing docstring in public function
145:1: E302 expected 2 blank lines, found 1
145: D103 Missing docstring in public function
146:78: E502 the backslash is redundant between brackets
147:24: E127 continuation line over-indented for visual indent
147:63: E502 the backslash is redundant between brackets
148:24: E127 continuation line over-indented for visual indent
177:21: E711 comparison to None should be 'if cond is None:'
179:21: E711 comparison to None should be 'if cond is None:'
225: D103 Missing docstring in public function
235:29: E251 unexpected spaces around keyword / parameter equals
235:31: E251 unexpected spaces around keyword / parameter equals
239:26: E231 missing whitespace after ','
243:53: E128 continuation line under-indented for visual indent
244:53: E128 continuation line under-indented for visual indent
248:29: E251 unexpected spaces around keyword / parameter equals
248:31: E251 unexpected spaces around keyword / parameter equals
254: D103 Missing docstring in public function
264:29: E251 unexpected spaces around keyword / parameter equals
264:31: E251 unexpected spaces around keyword / parameter equals
267:26: E231 missing whitespace after ','
276:29: E251 unexpected spaces around keyword / parameter equals
276:31: E251 unexpected spaces around keyword / parameter equals
282:58: E251 unexpected spaces around keyword / parameter equals
282:60: E251 unexpected spaces around keyword / parameter equals
282:72: E251 unexpected spaces around keyword / parameter equals
282:74: E251 unexpected spaces around keyword / parameter equals
282: D103 Missing docstring in public function
285:13: E711 comparison to None should be 'if cond is None:'
287:14: E711 comparison to None should be 'if cond is None:'
296:29: E251 unexpected spaces around keyword / parameter equals
296:31: E251 unexpected spaces around keyword / parameter equals
299:26: E231 missing whitespace after ','
303:53: E128 continuation line under-indented for visual indent
304:53: E128 continuation line under-indented for visual indent
305:53: E128 continuation line under-indented for visual indent
309:29: E251 unexpected spaces around keyword / parameter equals
309:31: E251 unexpected spaces around keyword / parameter equals
314:1: E302 expected 2 blank lines, found 1
314: D103 Missing docstring in public function
317:13: E711 comparison to None should be 'if cond is None:'
319:14: E711 comparison to None should be 'if cond is None:'
321:12: E711 comparison to None should be 'if cond is None:'
330:29: E251 unexpected spaces around keyword / parameter equals
330:31: E251 unexpected spaces around keyword / parameter equals
333:26: E231 missing whitespace after ','
337:53: E128 continuation line under-indented for visual indent
338:53: E128 continuation line under-indented for visual indent
339:53: E128 continuation line under-indented for visual indent
340:53: E128 continuation line under-indented for visual indent
341:53: E128 continuation line under-indented for visual indent
345:29: E251 unexpected spaces around keyword / parameter equals
345:31: E251 unexpected spaces around keyword / parameter equals
350:1: E302 expected 2 blank lines, found 1
350:60: E251 unexpected spaces around keyword / parameter equals
350:62: E251 unexpected spaces around keyword / parameter equals
350: D103 Missing docstring in public function
362:26: E231 missing whitespace after ','
366:53: E128 continuation line under-indented for visual indent
367:53: E128 continuation line under-indented for visual indent
376:1: E302 expected 2 blank lines, found 1
376: D103 Missing docstring in public function
403:1: E302 expected 2 blank lines, found 1
403: D103 Missing docstring in public function
415:26: E231 missing whitespace after ','
428:1: E302 expected 2 blank lines, found 1
428:54: E251 unexpected spaces around keyword / parameter equals
428:56: E251 unexpected spaces around keyword / parameter equals
428: D103 Missing docstring in public function
437:29: E251 unexpected spaces around keyword / parameter equals
437:31: E251 unexpected spaces around keyword / parameter equals
440:26: E231 missing whitespace after ','
443:34: E251 unexpected spaces around keyword / parameter equals
443:36: E251 unexpected spaces around keyword / parameter equals
444:72: E251 unexpected spaces around keyword / parameter equals
444:74: E251 unexpected spaces around keyword / parameter equals
448:29: E251 unexpected spaces around keyword / parameter equals
448:31: E251 unexpected spaces around keyword / parameter equals
454: D103 Missing docstring in public function
463:29: E251 unexpected spaces around keyword / parameter equals
463:31: E251 unexpected spaces around keyword / parameter equals
466:26: E231 missing whitespace after ','
470:61: E127 continuation line over-indented for visual indent
474:29: E251 unexpected spaces around keyword / parameter equals
474:31: E251 unexpected spaces around keyword / parameter equals
480: D103 Missing docstring in public function
489:29: E251 unexpected spaces around keyword / parameter equals
489:31: E251 unexpected spaces around keyword / parameter equals
492:26: E231 missing whitespace after ','
496:53: E128 continuation line under-indented for visual indent
496:70: E251 unexpected spaces around keyword / parameter equals
496:72: E251 unexpected spaces around keyword / parameter equals
500:29: E251 unexpected spaces around keyword / parameter equals
500:31: E251 unexpected spaces around keyword / parameter equals
505:1: E302 expected 2 blank lines, found 1
505: D103 Missing docstring in public function
509:16: E126 continuation line over-indented for hanging indent
517:160: E502 the backslash is redundant between brackets
545: D103 Missing docstring in public function
554:29: E251 unexpected spaces around keyword / parameter equals
554:31: E251 unexpected spaces around keyword / parameter equals
557:26: E231 missing whitespace after ','
559:23: E711 comparison to None should be 'if cond is None:'
560:44: E703 statement ends with a semicolon
569: D103 Missing docstring in public function
578:29: E251 unexpected spaces around keyword / parameter equals
578:31: E251 unexpected spaces around keyword / parameter equals
581:26: E231 missing whitespace after ','
583:23: E711 comparison to None should be 'if cond is None:'
584:44: E703 statement ends with a semicolon
596:1: E302 expected 2 blank lines, found 1
596: D103 Missing docstring in public function
638:1: E302 expected 2 blank lines, found 1
638: D210 No whitespaces allowed surrounding docstring text
638: D400 First line should end with a period (not 't')
644:5: F841 local variable 'result' is assigned to but never used
644:15: E201 whitespace after '{'
646:9: E124 closing bracket does not match visual indentation
649:110: F821 undefined name 'filter_key'
653:1: E302 expected 2 blank lines, found 1
653:35: E251 unexpected spaces around keyword / parameter equals
653:37: E251 unexpected spaces around keyword / parameter equals
653: D103 Missing docstring in public function


nice!


Thanks


Applied as commit 887007265dc622483bde29279a8a1ebd2ddb80af


the range of unicode characters allowed in domains. It's magic
![Giphy](http://media2.giphy.com/media/720g7C1jz13wI/giphy.gif)


@bwspenc I set this parameter in the action and the userobject picks it up, but yeah it's a little surprising that it works despite the fact that there's no parameter with that name defined in the userobject.


We have enough identifiers that start with "Ledger".


The code looks good, especially the tests, but I'm not sure we want this. For one thing, it could break anyone who depends on the failure. For another, if you are storing floats/ints as strings, it might be because you need more than 64-bits, so you would use a custom BigInt or BigFloat. And if you're not encoding your numbers, why use JSON at all?

If we do add this functionality -- even if only as an available wrapper -- I'd want to use the same number-decoder as we use in parsing. We want C++11-specific and compiler-specific code in just one place, to minimize the maintenance burden. And note that the `0.y.z` branch lacks C++-11. We would not want a difference in behavior between branches, so we would need a non-C++11 version as well.

Ideas?


Good point. Thanks for commenting :+1:


I bet @Guite forgot the changelog entry :ghost: :boat:


I'm :-1: on changing libtess2 and clipper; it'll make updating slightly harder.


`member` has been changed here to `event`.

1. `event` is not defined.
1. `member` has those properties.


The reason to have implicit separators is that label is an **optional** field.  And you would want to give the same separator treatment even if you are using the fieldname as a label.


ok


чтобы не было лишних merge коммитов -- можно делать git pull с флагом rebase вместо merge (https://www.atlassian.com/git/tutorials/merging-vs-rebasing/)


`ot-fs-utils.[ch]` might be a better spot for this.


navigator

![product1](https://cloud.githubusercontent.com/assets/10444345/7478864/3d094718-f37b-11e4-9f63-19c82cd88433.PNG)

design this before 3rd june


I did not! Thanks for catching that.


Here is a problem: the schema for any component is:
```javascript
{
  type: "string",
  config: object
}
```
In a component, however, you are only concerned with what is under `config`.


@neurolytic What to do? Should we write how much each creature can carry or agree that a certain amount of items and a certain weight limit is OK for all of them?


Why?
I found it necessary to have the build in debug mode for several reasons:
- Enables assertions
- Builds the parts of the code that only get enabled at debug
- Enables continuous integration of external projects (like HPXCL), where it is necessary to have the option to test in debug mode, which is not possible with a release built image.

The only obvious advantage of release mode:
- performance

Therefore, imo, we should have the :dev images build in debug, and :latest and the releases in release mode.


I don't know if we have access to Underscore.js in Dashboard but if/when we do there's `_.debounce`.


...but then you can't include it with `<mbgl/ios/MGLMapView_Private.h>` anymore?


maybe synthesize a `self.emitEvent(DELETE_EVENT, relativePath, self.root);` here?


Why did you do this?


I think I need a reference here right?


If there are legitimately no metric report plugins, this will try to load them repeatedly. (Since some of these will be included in the apps, it's not a big deal, but anyway.)


"added by an application"


Yeah, that's what I want.


rtrttrtr


I think `columns` should be `React.PropTypes.arrayOf(React.PropTypes.object)`


there will always be, the usage stats plugin... but yes, if someone disables it, then there will be none.


See comment above about component schema.


Alright, I've never met him before :grimacing:


First time to write this.


I think we should add something like DebugLog that will be compiled only for debug builds.


Blacklight adds the colons for you and this was resulting in a duplicate colon in the label. In my mind having labels like `Creator:: Name of Creator` doesn't look correct.  But you can add them back if you would like.

You'll notice that Blacklight also does not implicitly add the separators in the [generated config](https://github.com/projectblacklight/blacklight/blob/master/lib/generators/blacklight/templates/catalog_controller.rb#L81-L106) yet it results in the [correct display](http://demo.projectblacklight.org/?f%5Bformat%5D%5B%5D=Book).


@husterknupp is das geil so?


you will need to point to the configured value of `this.props.fieldValueChangeAction`, not a constant value.


This isn't doing anything. You can remove it.


@labkode is trying to solve the same problem in another way: https://github.com/cernbox/smashbox/pull/11/files#r29692814

Does it ever make sense in a testing environment to verify_certs=True? Besides of course testing this functionality as such.


The DELETE_EVENT is not the problem. We'll probably get the delete event before after this. The problem is the missing  ADD_EVENT. From the client's perspective a delete happened of a non-existent file.


since we have https://github.com/enova/landable/pull/61, I think we should remove this?


this doesnt allow for a user to configure the FIELD_VALUE_CHANGE action *name*. Please see comment above.


please remove `-table-` from the className. Referencing a specific DOM node in your class here is brittle.


I've been doing some testing, and so far WiFi seems to work but I'm having trouble with sockets.

My code is something like:

```python
import esp

def printer(*args, **kwargs): print(args, kwargs)

esp.connect('xxx', 'xxx')

h = ('110.216.58.216', 80) # esp.getaddrinfo() gives little endian it seems?

s = esp.socket()
s.connect(h)

s.send(b"GET / HTTP/1.0\n\n") # freezes here
s.recv(1000, printer)
```

I'm not sure how `esp.socket.onconnect`, `esp.socket.recv`, etc. work?


I think this looks good. I will work on integrating it this afternoon.


lets roll


closes #229


I am fully aware this problem. But as you see, method was added with this signature in 2.1, and unfortunately changing the signature at this point would break binary compatibility. So anyone using the method and upgrading Jackson would get a really nasty surprise.

So basically: yes, it should have been `ObjectNode`, but unfortunately changing that now is very difficult.
(note: it is also not possible to add separate overload -- Java does not support such co-variance).


Ok, we should use a new, private callback then. This callback is designed for MapKit parity, for the frequent case of needing to know when a map is fully rendered so that it can be snapshotted or presented to the user.


Hmmm, what is the value of jumpingOnTheBed? I tested it and I got different answers…


I believe that is identical?


You got me, will fix it when valgrind test passes and delete this unit test here.


Why are these cast to int?


Someone remover the side front


let's go to gitter


Meow, no blinking there :smile_cat:


By the way: This branch is already merged, create another PR if that line should be removed.


I think it'd be acceptable if it replaced the old `NM_IsNVector` macro, since as you point out, that's deprecated.

However, it requires a bit more work. For one thing, I think `#vector?` is written in Ruby right now, which would slow this macro down a lot. I think you actually need to test the data structure using C instead of relying on the Ruby function. @cjfuller, would you agree?


@Bitti09 oh okay :dash:


WSHP_SHR_GreaterThan_1 (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1648 of 1650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


WSHP_SHR_GreaterThan_1 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1648 of 1650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Just added so cops can heal cops if desired ...


This seems like a big change as the multiplication is completely gone.  Did the units get changed?


By hand :(


La création de la carte prend 1s sur ma machine. Je sais pas comment tu as ce temps sur la tienne. Mais j'ai un SSD, et ça joue beaucoup là-dessus ;)


Hmm, without the leading / in the `<frameName>` parameter the `ground_truth/state` topic will be published with a header frame_if of `tf_prefix/world` because of the `tf_prefix` parameter being set in the launch file and [gazebo_ros_p3d.cpp:143](https://github.com/ros-simulation/gazebo_ros_pkgs/blob/42061adea4f55ed295256055503bff7d4293a02d/gazebo_plugins/src/gazebo_ros_p3d.cpp#L143).

So the only way to fully support tf2 and to follow the tf2 migration guide would be to remove the tf_prefix ROS parameter (not necessarily the launch file argument) and pass the prefixed frame_ids to the Gazebo plugins via the new `base_link_frame` xacro parameters only. I have to check which other nodes (hector_pose_estimation etc.) currently depend on the `tf_prefix` parameter setting...


Ah, crap, I think I am going color-blind.  I read this diff reversed, which is why I objected.  Also was confused because the colons (being removed, not added) are explicit not implicit.  Nevermind though!


Does this need some more thought?

If an authenticator plugin has login-use-username true then doesn't make sense to yield it if we have an email but no username?


Bump @etiennebatise


It's good to know that our work is appreciated, this will encourage me to contribute more.


Hmm, if we make Lunchbox (zerconf) optional, how is this supposed to work with ANNOUNCE_ALL? Doing a strict translation of the current code, it means throwing, but I'm not sure that's very desirable as the default behaviour, is it?


"DELETE /api/todos/6 HTTP/1.1" 405
issue again


WSHP_SHR_GreaterThan_1 (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


> esp.getaddrinfo() gives little endian it seems?

Oops, I broke that by 04ee598, will fix ASAP
>  freezes here

Does it crash (reboot to bootloader)? You can apply following patch to get debug output on UART0 (I guess that could be an option in mpconfigport.h)
```
diff --git a/esp8266/uart.c b/esp8266/uart.c
index 6087668..5846d22 100644
--- a/esp8266/uart.c
+++ b/esp8266/uart.c
@@ -114,11 +114,11 @@ void uart_tx_one_char(uint8 uart, uint8 TxChar) {
 static void ICACHE_FLASH_ATTR
 uart1_write_char(char c) {
     if (c == '\n') {
-        uart_tx_one_char(UART1, '\r');
-        uart_tx_one_char(UART1, '\n');
+        uart_tx_one_char(UART0, '\r');
+        uart_tx_one_char(UART0, '\n');
     } else if (c == '\r') {
     } else {
-        uart_tx_one_char(UART1, c);
+        uart_tx_one_char(UART0, c);
     }
 }
```

To fetch an HTTP site, the following should work:

```
import esp

s = esp.socket()
s.onrecv(lambda x, d: print(d))
s.connect(("192.168.1.1", 80))
s.send("GET / HTTP/1.0\r\n\r\n")
```


Am I in?


Two things:

- In exception I usually prefer having FQCNs because you don't have to examine the source code to know what causes the problem
- It might be a personal preference, but I like when exceptions are in passive or imperative:

Don't pass the files array with a Psr\Http\Message\StreamInterface
A data instance of ...StreamInterface and $files parameters should not be passed together

Something like these...


Isn't MPlayer basically the only app that does that?


I thought you meant to assert that getSplit(rw.left()) != null && getSplit(rw.right()) != null, but I don't mind not having an assert because those cases should be eventually handled with a proper error message, if they are possible at all.


Remove unnecessary classes.


Zudem hieß es in den Folien, dass wir das Paket ausdrücklich nicht umbenennen sollen.


Like this?

```
* include `prism.js` in Bower folder - Install [Prism](http://prismjs.com/) from Bower
```


I'd like to see the this repeating line extracted into a private helper method. If the spec explains the purpose of these calculations, the helper name should reflect that.

Especially given that your translation from the less.js version has variable names that differ in length -- the calculations don't line up, so it's a bit harder than it should be to make sure that we're doing the same thing to each of the color values.


This if should probably be after the for loop.


Looks good! Passes some basic tests! `namedtuple` is definitely an option. I had in mind `counter`, which has some nice features for this use case.

Think about writing a function to add up the value of the myChange object you get back from this function. This will make it easy to write a lot of tests. For example, I wrote these two functions (you'll have to fill in `sum_coins()` yourself):
```
def sum_coins(wallet):
    # your code here!

def test_sanity(max_price):
    '''
    Test that the total value of coins returned is equal to the difference between 100 cents and the cost.
    '''
    for amount in range(max_change):
        wallet = calc_change(100, amount)
        assert sum_coins(wallet) == (100 - amount)
```

Some pedantic comments:
 - `patch-1` is too vague a name for a branch. Try to be more descriptive. Maybe `amy-solution`
 - you forgot the `.py` extension for the file!


The `vector?` method uses a function called `effective_dim` which runs a C loop to figure the effective dimension.

Should I just write a macro which will execute this loop? Or do you prefer a new function in the API?


![Uploading yes-pickard.jpg…]()


There is a constant for this in `util.js`. Just for consistency, please use it here. Android is a bit of a redundant case, but Blackberry has real potential for bugs, when some folks use "blackberry10", and some use "blackberry".


If it's not too much trouble, could you perhaps add an XML doc comment on the property that contains a link to the W3 spec?


@loganlinn 了解


LGTM. You can probably add iOS very easily in a related PR: it involved just `cat`ing its log files.


Ignore this this is an error


Nice work Brant!


Please also add this to the three Windows steps, even though we currently can't get Windows logs.


After pulling in this commit, the run command didn't work anymore, but failed to a syntax error in run.js. I believe it is because this line adds an opening parenthesis, but the closing one wasn't added.


..works great, but should somehow address the need to long press for edits within the text entered. So if a user is already typing in the text area or input then wants to long press to insert or remove text from a portion within that text field, they still need focus to shift during that operation . otherwise they have to click elsewhere to remove focus from input, and then long press within input to begin edit.


lgtm


Please add a `default` case, and print a warning when an unknown platform is passed.


Funny, I thought the double spelling error in the name of this spell would have been noticed earlier. Would this line have worked if it had been spelled correctly, "SPELL_SUMMON_RED_DRAGON_BUDDY" instead of the (now removed) "summoM" and "budYy"? (spelling mistakes in uppercase)


With changes in https://github.com/pocketgems/PubNub/commit/7adecca09d3034162e3f432fe1c68bf9dc6e060b it lgtm


WSHP_SHR_GreaterThan_1 (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1648 of 1650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Removed these from props.


thanks for the feedback. i should not push sth. without testing ^^


Removed type and config outer object from props.


Ok, if the parser doesn't remove the Bubbles while adding the parsed version then I suppose this is a reasonable place to do it.


Updated.


typo: as well as


Sorry about breaking the writer :(

The changes I made here are indeed part of the effort to recursively process units for assigning OPB properties. What I'm doing here is breaking down non-standard CellML units into standard CellML units and storing those instead. I ended up changing whether a UnitOfMeasurement was fundamental or not, so that it would be set as fundamental if it was a standard CellML unit.

I was trying to decide where would be a good place to do this, and the other potential place would be in SemSimLibrary.java, where OPB properties are assigned. But there, only individual DataStructures are processed, where as CellMLReader.java pulls in all the units in the model and it made more sense to me to recursively process units there. Also, this recursive processing of base units only applies to CellML units at the moment, so it made more sense to me to process it when reading in CellML models.

I have meetings/classes coming up, but I'll take a closer look later today at which unit factors aren't being stored properly.


@rgrp yes they are, i updated the file


This should be the `copy` module, not the `file` module.


This was reverted because it made the build fail (https://circleci.com/gh/STEllAR-GROUP/hpx/260). Please do this kind of changes on a branch instead.


merge error


Yay! :sparkles:


It actually locks up and I need to reset the power. Haven't tried your sample code yet (should I reverse the byte order?), but this seems to be enough to lock it up:

```python
import esp

s = esp.socket()
s.onconnect(lambda x: x)
```

I don't have a build environment setup (someone gave me a binary), but I'll see if I can get one working.


I'm not very satisfied with this change: it's not fully compatible with the portable behavior of Cmder.
* It changes variable `$env:PSModulePath` globally on the computer
* Without `global:PsGetDestinationModulePath`, PsGet don't install new module in the Cmder directory

I'm sure modules loading is improvable, but... :smiley:
What do you think?


typo (callde)


Paycon-qt does not build with this commit, error "uic: Error in line 401, column 143 : Expected ';', but got '='.
File 'src/qt/forms/chatwindow.ui' is not valid
Makefile:1433: recipe for target 'build/ui_chatwindow.h' failed
make: *** [build/ui_chatwindow.h] Error 1"

Previous commit works.


Ah, yeah, that commit message is no good. Sorry about that.


Can you fix the test name? Seems the same phrase twice


Uh I see. I'll do that then.


Ah, I see I didn't actually understand what it was doing, and was somehow thinking of a symmetric set difference. The functionality is fine, maybe addDefaultCells would be a clearer name?


tão obivo q n percebi


I can provide tests for this functionality but I'm not able to extend SampleService - sorry.


What's the default configuration for PostgreSQL? Master/Slave db router? pg_bouncer?


wow :P this is gonna be tough to do!


j'ai rajouté ceci à la ligne 41 : self.opener.addheaders.append(('Referer', 'http://www.t411.io'))

mais sans effet.

Le wget donne bien un code 200 (mais en fait c'est logique je pense sinon j'arriverai pas à ajouter des torrent manuellement)


It was an oversite since they were not set in the default constructor.


93906584_FluidCoolersTwoSpeed (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1139 of 1139 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


No lugar de "private Event event;" coloca um "private List<Event> event;".

Tem que fazer o import "java.util.List".


Perhaps say something about the handling of default values?


Please point torch installs to this page:
http://torch.ch/docs/getting-started.html#_

The ezinstall is depreceated for a variety of reasons (one of them being that it does a global install, but does not have a good uninstall mechanism).


I was getting a syntax error at this line.


Alright, cool. It should be fine then. :+1:

Personally I'm moving propTypes to Flow checks at constructor. You can see this approach in action [at my upcoming book](https://github.com/survivejs/webpack_react). It's ok if we stick to vanilla React here, though.


I don't think we should commit to this, so perhaps say something about how the format is subject to change.


y = image.decompressJPG(x, msg.channels, 'byte'):float()

That will avoid line 207 of multiplying by 255


This command is going to use **--system-site-packages** by default. It would be nice to add a comment about it.


y = x:view(msg.channels,msg.height,msg.width)

that will make it zero memcpy, and much more efficient.


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: doc/Makefile


Typo here **webbrowser**


same suggestions as above.


Agreed


ok


We can add a simple intro. line: *Servers configuration*


I believe the Makefile requires the use of tabs here, so the bot can probably be ignored here.


you missed a bracket over here :) `(gh-2218)`


There was a case where v was None which crashed the app engine.
It should happen but I put the code here for robustness


You shouldn't be able to remove this DOM section entirely; DOM is properly in Shepherd now, so auto-linking will work for you.  I just confirmed that, for example, "baseURI" is showing up in the DB, except it's an attribute on Node, so just writing `<a>baseURI</a>` won't work; you need `{{Node/baseURI}}` (or if you really like doing it manually,  `<a attribute for=Node>baseURI</a>`).

"attribute value" is a "dfn" type definition, so you can use a plain `<a>`, but it's a common word that appears in several specs, so specifying `<a for=Attr>value</a>` will ensure you get the right one.  Similarly, "document" is a dfn-type, but it shows up in several specs; using `<a spec=dom>document</a>` will hit the right one, or a `<pre class=link-defaults>text: document; type: dfn; spec: dom</pre>` will ensure the right one gets chosen by default so you can just write `<a>document</a>`.  (You can also use this for "value" if you're absolutely sure you'll only be referring to that particular "value", but I wouldn't risk it.)

Encoding isn't in Shepherd yet, because its definitions aren't Bikeshedded.  Once it is, you can do the same with its block (WebIDL too - it's on my list of conversions to do).  HTML is gonna need a different approach entirely, as it's too big to go through and Bikeshed. :/


To avoid confusion, you can make this:
model:add(nn.SpatialConvolution(1,20,5,5,1,1,0))

The MM can be dropped.


The `: ToxCoreImpl` here is not necessary. I suggest leaving it implicit when possible for private members. You already know the type, because you have it on the right hand side in `new ToxCoreImpl`.


@tarobomb Correct, I'm using it as a module.

I think you are correct about more fine-grained checking of what kind of object `body` is in `purifyBody()` so that `Buffer`s don't get stringified.  I'll make that change in my fork, although I can't submit a PR to @mrak yet since it will be dependent on your PR.  I think after this change, that should take care of all the cases where a binary filename is specified as the value for the `file` key.

However, I'm concerned about specifying UTF-8 for the encoding of the new buffer in `found()` in `endpoints.js`:
```
var response = endpoint.response[this.sightings[endpoint.id]++ % endpoint.response.length];
response.body = new Buffer((_ref = response.body) != null ? _ref : 0, 'utf8');
```
I don't think this is the right way to create a `Buffer` object that will hold potentially either a text or binary file.  Per the Node docs I think that this is forcing the Buffer constructor `Buffer(str[, encoding])` ([docs link](https://nodejs.org/api/buffer.html#buffer_new_buffer_str_encoding)) to be called regardless of whether the value for `body` is a string or buffer, when what we actually want for the latter is `Buffer(buffer)` ([docs link](https://nodejs.org/api/buffer.html#buffer_new_buffer_buffer).  Since `utf8` is the default for the first version of the constructor call, the second line of the code above could be changed to
```
response.body = new Buffer((_ref = response.body) != null ? _ref : 0);
```
Alternatively, we could explicitly check for `body instanceof Buffer` here as well and then call the appropriate constructor.  What do you think?


Same here, no need for `: Thread`.


@KunalKene1797  won't it have to be in a <PreferenceScreen>...</PreferenceScreen> tag, instead of <dashboard-tile>


`override def run {`


you might want to remove this comment. it is not correct, for what you are doing below.


Hmm; I'm having trouble making that add up.  If I look at the Tk GUI output in http://ioam.github.io/topographica/Tutorials/gcal.html, both activity and weights plots seem to be using the same plotting options:

- In step 8, the activity is using
  H=OrientationPreference, S=OrientationSelectivity, and V=Activity.

- In step 9, the weights plot is using
  H=OrientationPreference, S=OrientationSelectivity, and V=Weights.

I don't see any reason to treat the two cases differently.


`while (true)` add a space before `(`.


Thank you for the report.  For now, please use a previous revision. As
mentioned, I'm spending time unraveling repo merge issues and hope to have
them solved today or tomorrow.

Nathan

On Tue, May 5, 2015 at 2:17 PM, Teppei Sato <notifications@github.com>
wrote:

> merge error
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/closure-library/commit/3c0a1340d20f538efc67df12758cf591e09eb7f5#commitcomment-11050539>
> .
>


Unnecessary parentheses `()`. You can do `onCreate { ... }`.


Could also say that it can't be null (use clearField instead) or a repeated field (use get + .add instead).


createuser sport24 && createdb sport24


Also, `new Thread {` instead of `Thread()`. The same for `new ToxOptions()` above.


88737258-EPW-Ruby-Access (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (2179 of 2204 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.87%25-yellow.svg)


How to test your PostgreSQL connection:

$ psql sport24 -U sport24


Applied as commit f548be901a9b77c3681b3fc79d2546c82fd6fadf


Also, `neverEndindThread` has a typo in it, it should be `neverEndingThread`.


`connectionStatus: ToxConnection`, no space before `:`.


This is tsv, not csv


Applied as commit f16fbaecf990d84aea79d4aea9514501e33b7023


I ran into problems with this when using both the gzip_page and etag decorators. The etag decorator uses a user-defined function that calculates the etag (check here https://github.com/django/django/blob/72f6513ebaa7a3fd43c26300e9a8c430dc07cdb5/django/views/decorators/http.py#L124) that always will return the etag without the trailing ";gzip". The comparison (made here https://github.com/django/django/blob/72f6513ebaa7a3fd43c26300e9a8c430dc07cdb5/django/views/decorators/http.py#L134) will never match because of this. Is this intended behavior? How do I make the gzip and etag decorators work together?


Space after `"status",`.


@mjwitte The unit test has passed in my local and CI machine. The regression results show that two test files with results ZoneHVAC:WaterToAirHeatPump objects show diffs. This is expected diffs. The diffs observed in the EIO file of HospitalLowEnergy.idf are in the sensible and total capacity. The total cooling capacity of a WSHP unit increased by only 3.0% while the sensible capacity was reduced by about 0.017%. As the result the SHR reduced from about 1.042  to about 1.010.

The second test file PipingSystem_Underground_FHX.idf is the defect file and is expected to show large diffs as observed in the previous analysis (issue #4567).  For this test file he SHR reduced from about 1.72  to about 0.52. The method does resolve the SHR greater than 1.0 issue but a times it may only bring the SHR to about 1.0, as the capacity correction curves modify the total and sensible capacities either way depending on the capacity modifier curves, hence the SHR can be slightly off from 1.0 in either direction. @mjwitte Please let me know if you have any concerns about these results.


That is the date format that is returned by data.obudget.org


Static import


How to list current *Fabric* commands:

$ fab --list


Space before and after `+`.


Name this `holder`


Add a newline at the end of this file.


Space before `{`.


Commented on a few possible improvements. I'd also be okay with submitting as-is.


Space after `:`, not before.


Space after comma.


What’s the syntax error? I’m not getting anything there.
> On May 5, 2015, at 2:24 PM, suwarna07 <notifications@github.com> wrote:
>
> I was getting a syntax error at this line.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ECE4574-5574/Devices/commit/5e6d7a4d5334caea1803ce93c4800312bca9696f#commitcomment-11050675>.
>


Remove ().


I hate to be picky, but don't remove blanks and things like that, we follow the pep8 stuff.


Incorrect indentation.


Remove `: StringBuilder`.


The other collections are concurrent, but this one is not


@Alucard24
can it be possible that i have ondemandplus gov crashing kernel, user fail to resume device if ondemandplus is used on all cores, started with build 10.4 and maybe connected to this commit...
i will try to revert it and give beta for testing.


sp: defined


How about to include another section for Ubuntu?


Add space around `+`.


@kiwiupover minor nitpick here, but is there a way to save the isSelected state on something other than the model itself?


Space before {.


It's not needed, as lists are cleared on delete.


Should this be wrapped in `synchronizedListMultimap()`?


93906584_FluidCoolersTwoSpeed (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1650 of 1650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why? Just interested.


Static import


Got it!


This is not correct, since the returned list is not guaranteed to be mutable. Add `.sorted()` to the above chain.


One thing I do see is that the Tk GUI uses the S=OrientationSelectivity even for plots of the orientation map alone (see step 7 in that tutorial), while I don't think HoloViews/FeatureMapper is doing that.

The Tk GUI (well, topo.plotting, to be more precise) does that so that it (and the users trying to interpret the plots) can treat all the cases the same -- H=OrientationPreference always, S=OrientationSelectivity always, and then V=1.0 (for map plots) or V=Activity (for colorized activities) or V=Weights (for colorized weights).

Maybe HoloViews/FeatureMapper is trying to do H=OrientationPreference, S=1.0, and V=OrientationSelectivity, which won't work well once activity or weights are thrown in?  If so, the problem this class addresses is not to do with weights, but also with activities, or any other colorization one might want to do.

It seems to me that this class could go a way if the HoloViews/FeatureMapper default were changed to use H for the preference and S for the selectivity, leaving V=1.0 by default or else whatever one wanted to colorize.


OK, let's see what Travis says.


This can be a single chain with above


Name this `metadata`


This should be

```dart
class X {
  String foo;
  X(this.bar, [this.foo = "hello"]);
}


#This is a comment


Copy Pasta


Yes, you are right


WSHP_SHR_GreaterThan_1 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (626 of 626 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.28%25-green.svg)


We cannot a static page server anymore since we're moving to [hapi](https://github.com/customelements/www/commit/7d4c4045555123b8b2166e7c8793bdc48792f130).


# This is a comment


The "(and working)" comment worries me because the code in mono_class_interface_offset_with_variance starts with a call to mono_class_interface_offset.

It's not clear what the issue that this addresses. To make it worse, it doesn't come with a test or an explanation of the scenario it fixes.


Thanks Graham.

As far as flagging the units as fundamental, doesn't the code in lines 149-160 already do that?

The way things have been set up is that in the CellMLreader, we just capture the info that's in the CellML model. If unit A has factor B, and in another statement unit B has factor C, we just want to assert the same thing in the SemSim model, not assert that A has factor C, which is what I think you're trying to do with your recursive processing code.  If we did it the latter way during CellML export, then we'd be writing out different unit declarations, that, while they might be correct, don't reflect the arrangements and statements in the original model.  I think moving this recursive processing to SemSimLibrary would be better. Couldn't you just have a routine that, prior to running through the DataStructures and assigning an OPB term, creates a hashtable that maps each unit to their *fundamental* (i.e. recursively processed) unit factors? Then, for each DataStructure you can get it's assigned unit and then look up the fundamental unit factors for that unit in the table?

A separate, major point is that some unit factors are being missed by the code in 182-199. I think this is because in some cases you end up trying to look up the unit factors for units whose factors haven't yet been assigned. For example, if parentuom in line 192 doesn't yet have its unit factors assigned, then the recursion ends prematurely. I can send you an example CellML file where this happens if you need it.


What does this code do or what is it supposed to do? I see you're trying to format the output or something but the resulting information in weatherState is blank ("<br>")


Looks good to me.


+1! - I was just writing up an issue for this and finally found this commit when digging into the code

Note: http://textangular.com/ does not have this commit deployed yet!

Plus - before this was fixed it was also a repro for #219 - focus and blur the editor and an img onload event triggers again. (which also might mean that #219 is fixed with this commit)


Add a comment on why the safe part matters and its purpose.


Not too bad at all! What's your assessment of regression risk here? (just wanting to figure out if we need extensive field testing before we release rmarkdown to CRAN)


nit: `it`


@hakobera  - I had a bug report from a tester that we see an exception on line 115: `attributes_string = fetch_metadata('instance/attributes/')`.  This was handled properly in your earlier patch where you had patched fetch_metadata.

I will send a PR to fix this, I think all we need to do is: `attributes_string = @fetch_gce_metadata ? fetch_metadata('instance/attributes/') : ''`


Line damage.


Wrong!!! Try again!


the chrome provider distinguishes between "we closed it" and "the other side" closed (`SUCCESS` and `CONNECTION_CLOSED`, respectively). I wonder can we do that here, too?


Makes sense. Should have missed that commit, sorry. Awesome, by the way!


OK, we can use float to define index in numpy. good to know.


I don't see a need to apply this change


it doesn't really make sense to keep maintaining a `description`, `version` and `name` if you're keeping the package private.


I think that revert this can't help you to solve ondemandplus gov crashing kernel.
get_online_cpus() locks cores hotplugging on/off while is executing cpufreq_update_policy fn that restores policy limits for the target cpu only if they have been changed by thermal control(ex).
Then, that function doesn't take in considering all offline cpus, then their limits are automatically restored when they become online.
So if cpus are online and limit have been changed, function works perfectly and we don't need to lock hotplugging.... in other cases policy limits will be restore when offline cpus become online.


Por que foi utilizado o List ? Por que teve que importa o List ?


hehe no problem ;)


Scala doc for the top level traits please.


I concur with @p2: watermarking should be a compile time option and not a runtime one.


:+1: :sparkles:


Is this completely stable?


Did this work?


Commit message looks good. Fix not so much.

The fix should be to have a single icall in the slow path that has both the type test and cache update.

Take mono_marshal_get_castclass_with_cache, for example. Add an icall named mono_object_isinst_with_cache that takes the cache as the last argument and does the update.

This will simplify the generate IL and significantly speed up the slow path by having a single icall.

This means adding 2 news icalls instead of one, which is fine.


Not a big fan of changing all Module mentions from links to inline code + links. Example : [BCECriterion]() -> [`BCECriterion`]() . This change would affect lots of doc. I am also doubtful it will work well with readthedocs (I might be wrong). In the end, I just don't like the aesthetics of this particular change. My 2 cents.


Ok, understood, I'll just rip your code now before reaching to 1.2.11 when it's out. I have to always tip my hat to an engineer who decides the younger version of himself wrote some "useless" code (it's not useless if someones using it). Pointless is a better description :)


This is a really good change! :+1:


Oops, I was still logged in as a wrong user. Pardon, Olivier!


@tinspin : code up a switch-by-height implementation, and you'll see why by-timestamp is much better.

There is no danger of confusion, the block timestamp is in the block header and is part of what is hashed. Either it is before the switchover time or after, and if you're checking the block you have the timestamp to check against right there in the block's data. Your node's notion of local time is irrelevant (if your time is too far off the network's idea of the current time you'll reject the block, but that is true today and independent of the max block size check).


what is this here


@Icewater1337 Muss ich abklären. Eventl. ist auch gewünscht, dass immer eine fixe Anzahl von Spalten für Rollen ''reserviert'' werden oder, dass wir die Rollen an den Schluss des exports verschieben wo es keine allzugrosse Rolle mehr spielt. Ich bin ziemlich sicher, dass die Rollen in den Exports heute so Verwendung finden wie sie als separate Felder gerendert werden.


Applied as commit 8b2cae0224244734ea333e68550584ef8d6b4f8e


@btajuddin-sfdc - I think you should stick with Semantic Versioning convention (http://semver.org/) and use major.minor.patch. Your change from the old numbering format to just 34.0 broke scripts that were using ivy/gradle/maven and were just expecting to be able to just flip the version from 33.0.0 to 34.0.0.

Could you make this change and push it to mavenCentral again?


Indeed.


Thanks for this fix, nice to have it working again!
It might be worthwhile mentioning adding something like this to sudoers:
%admin ALL=(ALL) NOPASSWD: /sbin/pfctl

Otherwise once the timestamp_timeout fires any new session attempt will cause a traceback in Python.


Not sure, but shouldn't the input name be 'login' instead of 'apply'? Also, the $name value is never used in this refactored method.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


@csrwng i'm not so sure...  what happens when an enterprise is running their own internal git system that does have a web frontend?  they'll never get links because the hostname doesn't match...

I think we're better off linking and sometimes having that link not really be useful, than never providing links except for github.com.  But I agree it's a tradeoff.  What do you think?


Would this ever not contain `URXQuery` s?


@fmzhen, please retrieve in bridge.go the list of TransportPort from the list of PortBindings, instead of adding a new config parameter in EndpointConfiguration.


suing time is bad idea there is no realtime in simulation rather limit with amount of reads


Because I am going to restructure the way pieces move. I will put the test back once I finish that,


$ python3 -c 'from email.Utils import formatdate'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named 'email.Utils'


The clearest, which also avoids unconditional assignment, is `if (!options) { options = {}; }`.


if $text holds text encoded as UTF-8, we need to use /u pattern modifier.

$text = "公"; // "\xe5\x85\xac"
$text = preg_replace('/\s+/', ' ', $text);
$text will become \xe5\x20\xac

but, in constructor, we don't know the text's encoding.


Old version - takes only one video


You can improve on the collecting by using the 2-argument version of groupingBy along with Collectors.mapping to get the K out of the items, rather than restreaming:

    Map<Sort, List<K>> multiMap = children.stream().flatMap(e -> getSplit(e).entrySet().stream()).collect(
        Collectors.groupingBy(Map.Entry::getKey,
            Collectors.mapping(Map.Entry::getValue, Collectors.toList())));

It might help to represent multimaps with Guava's Multimaps:

    ListMultimap<Sort, K> multiMap = children.stream().reduce(ArrayListMultimap.create(),
      (m,v) -> {m.putAll(Multimaps.forMap(getSplit(v)));return m;},
      (m1,m2) -> {m1.putAll(m2); return m1;});


that does the trick
```
DXX-Archive.3: checking for explicitly deleted functions with named parameters...no
DXX-Archive.3: checking for explicitly deleted functions with anonymous parameters...yes
DXX-Archive.3: checking for explicitly deleted functions with named parameters and -Wno-unused-parameter...yes
```


I'd say changes like should go throw pr first