37:1: I201 Missing newline before sections or imports.
145: D102 Missing docstring in public method
154: D400 First line should end with a period (not 'n')
154: D205 1 blank line required between summary line and description (found 0)
243: D102 Missing docstring in public method
283: D400 First line should end with a period (not 'w')
283: D205 1 blank line required between summary line and description (found 0)
296: D400 First line should end with a period (not 'e')
296: D205 1 blank line required between summary line and description (found 0)
311: D400 First line should end with a period (not 'e')
311: D205 1 blank line required between summary line and description (found 0)
319: D400 First line should end with a period (not 'e')
319: D205 1 blank line required between summary line and description (found 0)
330: D400 First line should end with a period (not 'd')
330: D205 1 blank line required between summary line and description (found 0)
352: D102 Missing docstring in public method
356: D102 Missing docstring in public method
368: D400 First line should end with a period (not 'd')
391: D400 First line should end with a period (not 'n')
391: D200 One-line docstring should fit on one line with quotes (found 3)
398: D400 First line should end with a period (not 't')
398: D200 One-line docstring should fit on one line with quotes (found 3)
405: D400 First line should end with a period (not 'e')
405: D200 One-line docstring should fit on one line with quotes (found 3)
412: D102 Missing docstring in public method
434: D102 Missing docstring in public method
442: D102 Missing docstring in public method
446: D210 No whitespaces allowed surrounding docstring text
446: D400 First line should end with a period (not ')')
451: D210 No whitespaces allowed surrounding docstring text
451: D400 First line should end with a period (not 'd')
458: D210 No whitespaces allowed surrounding docstring text
458: D400 First line should end with a period (not 't')
474:17: W503 line break before binary operator
488: D102 Missing docstring in public method
502: D102 Missing docstring in public method
523: D210 No whitespaces allowed surrounding docstring text
523: D400 First line should end with a period (not 's')
529: D102 Missing docstring in public method
536: D210 No whitespaces allowed surrounding docstring text
536: D400 First line should end with a period (not 's')
541: D210 No whitespaces allowed surrounding docstring text
541: D400 First line should end with a period (not 's')
546: D210 No whitespaces allowed surrounding docstring text
546: D400 First line should end with a period (not 's')
551: D210 No whitespaces allowed surrounding docstring text
551: D400 First line should end with a period (not 's')
556: D400 First line should end with a period (not 'r')
556: D205 1 blank line required between summary line and description (found 0)
569: D400 First line should end with a period (not 'e')
614: D102 Missing docstring in public method
619: D102 Missing docstring in public method
630: D102 Missing docstring in public method
637: D102 Missing docstring in public method
643: D102 Missing docstring in public method
649: D102 Missing docstring in public method
654: D102 Missing docstring in public method
661: D210 No whitespaces allowed surrounding docstring text
661: D400 First line should end with a period (not 'e')
665: D210 No whitespaces allowed surrounding docstring text
665: D400 First line should end with a period (not 'e')
669: D210 No whitespaces allowed surrounding docstring text
669: D400 First line should end with a period (not 'e')
673: D210 No whitespaces allowed surrounding docstring text
673: D400 First line should end with a period (not 'e')
678: D203 1 blank line required before class docstring (found 0)
678: D204 1 blank line required after class docstring (found 0)
678: D400 First line should end with a period (not 'r')
678: D205 1 blank line required between summary line and description (found 0)
684: D102 Missing docstring in public method
689: D200 One-line docstring should fit on one line with quotes (found 3)
705: D102 Missing docstring in public method
710: D210 No whitespaces allowed surrounding docstring text
710: D400 First line should end with a period (not 'n')
718: D210 No whitespaces allowed surrounding docstring text
718: D400 First line should end with a period (not 'n')
722: D210 No whitespaces allowed surrounding docstring text
722: D400 First line should end with a period (not 'n')
728: D200 One-line docstring should fit on one line with quotes (found 3)
734: D400 First line should end with a period (not 's')
734: D200 One-line docstring should fit on one line with quotes (found 3)
747: D203 1 blank line required before class docstring (found 0)
747: D204 1 blank line required after class docstring (found 0)
747: D400 First line should end with a period (not 'm')
747: D200 One-line docstring should fit on one line with quotes (found 3)
751: D102 Missing docstring in public method
762: D102 Missing docstring in public method
770: D102 Missing docstring in public method
781: D102 Missing docstring in public method
784: D102 Missing docstring in public method
787: D102 Missing docstring in public method
794: D200 One-line docstring should fit on one line with quotes (found 3)
800: D200 One-line docstring should fit on one line with quotes (found 3)
810: D200 One-line docstring should fit on one line with quotes (found 3)
873:13: W503 line break before binary operator
943: D400 First line should end with a period (not 's')
951:9: E731 do not assign a lambda expression, use a def
966: D203 1 blank line required before class docstring (found 0)
966: D204 1 blank line required after class docstring (found 0)
966: D400 First line should end with a period (not 't')
973: D102 Missing docstring in public method
995: D102 Missing docstring in public method
999: D102 Missing docstring in public method
1003: D102 Missing docstring in public method
1008: D102 Missing docstring in public method
1012: D102 Missing docstring in public method
1016: D102 Missing docstring in public method
1023: D400 First line should end with a period (not 'd')
1043: D400 First line should end with a period (not 't')
1043: D200 One-line docstring should fit on one line with quotes (found 3)
1066: D400 First line should end with a period (not 't')
1066: D200 One-line docstring should fit on one line with quotes (found 3)
1093: D200 One-line docstring should fit on one line with quotes (found 3)
1107: D400 First line should end with a period (not 't')
1107: D200 One-line docstring should fit on one line with quotes (found 3)
1124: D400 First line should end with a period (not 'n')
1124: D200 One-line docstring should fit on one line with quotes (found 3)
1147: D400 First line should end with a period (not 'w')
1175: D400 First line should end with a period (not ')')
1175: D200 One-line docstring should fit on one line with quotes (found 3)
1188: D200 One-line docstring should fit on one line with quotes (found 3)
1201: D400 First line should end with a period (not 'e')
1201: D205 1 blank line required between summary line and description (found 0)
1208: D400 First line should end with a period (not 'p')
1208: D200 One-line docstring should fit on one line with quotes (found 3)
1215: D400 First line should end with a period (not 'r')
1215: D200 One-line docstring should fit on one line with quotes (found 3)
1232: D400 First line should end with a period (not 't')
1232: D200 One-line docstring should fit on one line with quotes (found 3)
1240: D400 First line should end with a period (not 'd')
1240: D200 One-line docstring should fit on one line with quotes (found 3)
1258: D200 One-line docstring should fit on one line with quotes (found 3)
1267: D400 First line should end with a period (not 'e')
1284: D400 First line should end with a period (not 'm')
1284: D205 1 blank line required between summary line and description (found 0)
1300: D200 One-line docstring should fit on one line with quotes (found 3)
1311: D102 Missing docstring in public method
1317: D102 Missing docstring in public method
1323: D102 Missing docstring in public method
1337: D102 Missing docstring in public method
1350: D200 One-line docstring should fit on one line with quotes (found 3)
1377: D102 Missing docstring in public method
1436: D102 Missing docstring in public method
1481: D102 Missing docstring in public method
1489: D102 Missing docstring in public method
1499: D102 Missing docstring in public method
1508: D102 Missing docstring in public method
1511: D102 Missing docstring in public method
1515: D102 Missing docstring in public method
1519: D102 Missing docstring in public method
1539: D102 Missing docstring in public method
1547: D102 Missing docstring in public method
1555: D102 Missing docstring in public method
1561: D102 Missing docstring in public method


DOF was rendered about 3 times slower even than single thread version. Rendering image previews also worked terribly slow (this I had observed first and pushed me to investigate it). Under Linux it works perfect because pthread is native.


Ok!


it's cherry picked from master


hm, i did not find issues boatd...

i have a problem:
```sh
wget -qO- 'https://raw.githubusercontent.com/tubia/debian/master/build-image.sh' | sh

Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package docker.io
E: Couldn't find any package by regex 'docker.io'
sh: 16: debootstrap: not found
sh: 19: cannot create /var/chroot/wheezy/etc/apt/sources.list: Directory nonexistent
chroot: cannot change root directory to /var/chroot/wheezy: No such file or directory
chroot: cannot change root directory to /var/chroot/wheezy: No such file or directory
chroot: cannot change root directory to /var/chroot/wheezy: No such file or directory
tar: /var/chroot/wheezy: Cannot chdir: No such file or directory
tar: Error is not recoverable: exiting now
sh: 34: docker: not found
```

can you help me?


This is the proto definitions file. It is just constructed from the .proto file. This is a reference to the API


@dmilliken @evidens I probably should have added this note to this commit but thought about it after :)  I have notes/questions in various slides inside of [[ ]] so if you want to take a look at this commit as well or we can go through it in our meeting.


Will show tomorrow if time no rush as pTS is fine for now
On 4 May 2015 9:23 pm, "Adam Brown" <notifications@github.com> wrote:

> what're the woes?
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/ataulm/wutson/commit/c621b78e4ddf83aaaedf232b0f158d384dc79157#commitcomment-11032752>
> .
>


> That could in general help attract people to try this port.

How is that supposed to work? People try it and find out that "some methods do simply fail or force a WDT reset on my board. Especially the connect() method does so all the time.". What happens next? We need people to move the port forward, and the first step on that path is building it themselves.

> Best solution would be if @dpgeorge could be so kind and put recent ones onto his official website?

That arguably violates Espressif license (they require complete source to be provided, and that's not possible, because they don't provide it themselves). Until they change the license, I'd recommend everyone to stay away from the binaries and deal with source.


But why we need these silly hacks for torch? Sysfs toggle is working good. we just need sysfs toggling support for torch_service or don't we?


I might not have 634c9acdbd6b093769afd21ffcef6105d2799eaa applied locally, will rebuild again


This statement isn't quite fair. Most new assessments types are added within capa_problem. ORA is an exception. In addition, problem/capa_problem are the terms used in the platform. These are based on LON-CAPA, but they are not LON-CAPA. The nuance there is a little verbose to explain, and a little tangential to events, so I'd consider just saying capa_problem or problem or similar.

I would propose:

These events were designed for the problem types implemented by capa_problem. Other XBlocks, including graded ones such as :ref:`open response assessments<ora2>`, are instrumented with other events.


Not POSIX. Why was this even replaced?


Is anything preventing us from using `Minitest.run` here as well?


In the general Primo translator we shouldn't use anything which might only be applicable for BEIC catalogue. Moreover, I don't think it is useful to note information in the source code which are not used anywhere. There might be other places to make notes.


KNOWN BUG: The Fuel Block's Collider is still on the old scale and only takes collisions in the top left corner. This bug is already fixed and will be rolled out in the next commit/update.


Did you find this to be a measurable performance optimization? If so, we should revise the TreeToIndex.file_to_index() contract so it can return None, benefitting all plugins.


Throw exceptions when the database returns them instead of returning a normal response


there's a mix of properties and identifiers here..


view files


```tools/emscripten/*.sh``` also contains lua code that should be removed


Thanks! I also fixed my wrapper function snippet in my earlier comment; I was using `call-interactively` instead of `funcall` and so was passing on the wrapper fn args to the sub functions unintentionally.


Not sure which one is better, creating a new object or clearing and adding every time. Consider this ... if we follow the current approach, we will create the hashset with right size because we know the number of entries. But if we use clear and add, the size may have to be resized. If you think its better to avoid object creation, I will change it.


I'll mention that this is actually pretty important. capa_problem is incredibly rich. The phrasing here would mislead people into believing it is used for simple/basic problem types.


This should be folded in to `RPM_DEFINE_UTIL` like the other `--define` arguments which are passed.  This way everythings in one place and there's no need to add `RPM_DEFINE_INITCONFDIR` to the `rpm.am` file.


Ah, yes! I didn't end up using this change, which is why I didn't make a PR yet.


I don't think this method fits here. It doesn't really follow the pattern of the other methods in this class and also its semantics are very specific to user names while this class is very generic.


Typo: "hightlight" -> "highlight"


Yeah I guess. `provide/contract`.


Was it only formal renaming from `includes` to `actualIncludes`?


Benjamin Maréchal helped with sharing and getting at nngraph modules/parameters
https://groups.google.com/forum/#!topic/torch7/4f_wMQ6G2io
https://groups.google.com/forum/#!topic/torch7/KheG-Rlfa9k

gModules = {}
for indexNode, node in ipairs(gmod.forwardnodes) do
  if node.data.module then
     print(node.data.module)
     gModules[#gModules+1] = node.data.module
  end
end
gModules[1].bias
gModules[1].weight
p, gradP = gModules[1]:getParameters()


If we are creating a new exception we should use the new pattern of passing objects and not a message. Please talk to Pei-Jung to find the best solution together.


I hate comments.


Pls take it back and pass `getTest()` intohe singleton list.


Are you bringing in all of Underscore just for the escape? If so, consider just in-lining the function (should be a ~6 line fn).


that is too bad, i did not expect it to be even slower than single core.
Which gcc version did you use to compile?
Though there is probably not a lot to gain, by tweaking the build chain...
Have you tried osx yet?


I'm a little undecided on "the protobuf file is the spec". It's the current situation but clearly rethinkdb wants to move away from protobuf and that's why they recommend building clients in JSON.

I will agree that having a mapping of the reql values to atoms is useful. Will have to think about how we tie these in.

Regardless, I'm not crazy about matching on both the atom and the number.


 +                            "returncd": "0102",

That's better.


These should be one-time bound. `{{::format}}`


Would it be more clear if we use `DefaultEncoding.Encoding` that way we know that we always use the default content type & its encoding.


Whoops, overlooked that :smile:


This is good. Thanks! I think I left this out of my 1.0.0 milestones I put together yesterday.


This is something that we need to document since we are removing a configuration option that some existing installations might be using. For now please explain it in BREAKING_CHANGES


This name is a bit awkward but is forced by the macros in maximal_cliques_template.h.


This name is a bit awkward but is forced by the macros in maximal_cliques_template.h


@pfalcon whenever you mention the port people tend to ask for a binary. Let them play with dirty stuff to get them into it and maybe working those dirt off this port!. As long you tell it is in an early state it will not hurt anyone!
That license issue is a strange situation i haven't been fully aware off. Anyways, lets go ahead...


I don't see much value in having this and the file above. Also, see comments on the file above re "the proto is the spec".


nit you do not need else if you just do
`encoding = contentTypeHeader.Encoding;` outside the if.


I do something like that manually while debugging, but actually it'd be
cool to have a simplistic query mechanism, analogous to simple CSS
selectors where you can select based on type name and query annotations. NN
containers already have a find method that searches by type or something.
On May 4, 2015 9:46 PM, "mszlazak" <notifications@github.com> wrote:

> Benjamin Maréchal helped with sharing and getting at nngraph
> modules/parameters
> https://groups.google.com/forum/#!topic/torch7/4f_wMQ6G2io
> https://groups.google.com/forum/#!topic/torch7/KheG-Rlfa9k
>
> gModules = {}
> for indexNode, node in ipairs(gmod.forwardnodes) do
> if node.data.module then
> print(node.data.module)
> gModules[#gModules+1] = node.data.module
> end
> end
> gModules[1].bias
> gModules[1].weight
> p, gradP = gModules[1]:getParameters()
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/oxford-cs-ml-2015/practical6/commit/96749c8d9bc93f864c94c048a3c8cd73f59f733b#commitcomment-11033195>
> .
>


similar comments as the `ContentResult` class.


Actually , Elixir doesn't let u  match on the Map or anything implementing the Access protocal for that matter . So the tuple seemed the only way to do it.


Nope, still don't get it.


This should probably be handled in the service index resource, so that all parsing happens in one spot to avoid issues like this.


Actually, why not just string concat here? Then you can avoid the compile entirely.


Ok; 02e678b45db84283b4a1766212292d1085d4d967 should take care of it. I didn't think this was something that had changed since some very old RW versions.


W dniu 04.05.2015 o 22:24, donahue95 pisze:
>
> The firegl_public.c change has a proprietary to gpl/proprietary license change for kernel version 3.19.0 and later. A great idea, may I ask how it came about?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/kolasa/fglrx-core-15.200/commit/66a25e76c538f7844568a20243bfe015ee0315a1#commitcomment-11032782>.
>
source kernel change EXPORT_SYMBOL to EXPORT_SYMBOL_GPL for some functions

to install the driver you have to use the GPL\0 trick

http://en.wikipedia.org/wiki/Loadable_kernel_module#Linuxant_controversy

it is not a permanent change, only for testing, unless AMD in the future something will change,
at this time you need to write functions in the driver fglrx that are already in the kernel (version GPL)
again to meet the license conditions propietrary

Krzysztof


+1 for binaries. There are tons of potential testers out there who are unable/unwilling to compile everything from scratch.

NodeMCU also distributes binaries, though I'm not sure if they have the same potential license issue.


Err sorry I responded to this as comments in the PR.

The notion of wanting (really the value of ec2.associatePublicIpAddress) is different from using the private ip address (which you always have). It is typical that you'd want a public ip address associated and also use the private
ip for ssh.

Though really there is no good reason to call the var wants_public_ip_address, it should just be associate_public_ip_address (which it what its mirror in the defn world is named)

I updated the pr


And that's true, I feel the difference also running lollipop. Great job guys. Anyway I asked just for information


Much as they are moving from  protocal buffers to the JSON  protocal, they are still mantaining the proto file . Refer http://rethinkdb.com/docs/writing-drivers/


Ok it's fixed

On Mon, May 4, 2015 at 6:59 PM, Jeremy Grossmann <notifications@github.com>
wrote:

> Good point, actually that may be a problem with remote server that have
> Chinese characters. Try 义勇军进行曲 for instance.
>
> I think regexp does support Unicode, you have to use re.UNICODE if I
> remember correctly.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GNS3/gns3-gui/commit/a6653a3419d9f56825b132306ee5888481ca11d1#commitcomment-11029049>
> .
>

--

*JULIEN DUPONCHELLE*
Software Engineer

E: julien@gns3.com
LinkedIn <http://linkedin.com/in/julienduponchelle/>

<http://www.linkedin.com/in/stephenguppy>288, 200 – Rivercrest Drive SE
Calgary, AB, T2T 2X5
Twitter <http://www.twitter.com/gns3_official> | Facebook
<https://www.facebook.com/gns3official> | LinkedIn
<http://www.linkedin.com/company/gns3-net> | Google+
<https://plus.google.com/+Gns3Net/posts> | CrunchBase
<http://www.crunchbase.com/organization/gns3>


Isn't the first heading usually a single #? Any particular reason to start with a lower headging?


This was intentional as the getter of the `Encoding` property on `MediaTypeHeaderValue` does not preserve the same instance that we supply it.


In deed, that was made to show the name that the "issuer" requested... but it's okey xD (The same for the previous commit)


@graphicore, I'd appreciate if you could take a look at this work-in-progress.


+1 from me


vffef


Looks good


As the specs are in English we should also use the decimal point used the most, and that would be `.` – even if that's not 100% what the old specs contains.


@anthonyshort thanks, just noticed that I committed wrong namespace here :/


@anthonyshort :+1:


Same as in https://github.com/aspnet/Mvc/commit/29b8c3de9c230c33802df86f422e3bce75593ce7#commitcomment-11033339


What is this backslash for?


Haha yeah no problem. I just fixed that up


com.ibm.sbt.proxy.web was missing a version for the maven war plugin


Uhoh! Is this wise? : D


Thanks. I will clean these up.


![mobile assistant_20150502082000842](https://cloud.githubusercontent.com/assets/12101557/7462337/561cc81e-f2b9-11e4-8eb4-4611fc644dc9.png)


93441412-HVACTemplateMissingSetpoint-4328 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1136 of 1136 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.79%25-green.svg)


I based this off the ones in build deb but we can change at anytime


Ben - is this still the file that IMP used to scan the src folders for .cpp files and create Files.cmake? Can I add cuda files scanning to this file, or should I add it somewhere else?


Thanks @bgruening! :)


most of these are taken from http://pkgs.fedoraproject.org/cgit/docker.git/tree/docker.spec


got this from http://pkgs.fedoraproject.org/cgit/docker.git/tree/docker.spec


Thanks for correcting '_x', I was going to put a context, then changed mind, and forgot to change _x() back to __(). As to multiple %s, I guess we can leave it as is, since Some other languages already translated it too. My idea was that with '%sVisit%s %s' it will be clearer for translators to  understand that there is additional untranslated proper noun. Oppositely, I did not treat 'Startup Guide' as proper noun, and I thought that it would be better to translate it as any other word combination. When it is opened at website, people will still understand that it is a "Startup Guide" in English. It is not the same with "qTranslate-X explained", since it is rather a proper noun, which is normally does not get translated.
Does it make sense?


got it from http://pkgs.fedoraproject.org/cgit/docker.git/tree/docker.spec


No reason, this is just how it came out of pandoc, which converted the html to md. I think the html originally had this as <h3>.


IRC I had provided an example last time you asked this question on another PR,

Do you mean this question https://github.com/zotero/translators/pull/822#discussion_r22402250 from @aurimasv  ?


That's not a performance optimization, it just made more sense to me:
* There's a single location (`file_to_index`) with all the filters
* The filter in `file_to_index` better matches `post_build` (the filters are still not identical, but I didn't care to look into that)
* The logging I needed in `FileToIndex.__init__` becomes less noisy

The dxr core


Yeah, I thought about that. But that would mean putting this stuff in a different place (because RPM_DEFINE_UTIL is set higher up in ZFS_AC_RPM func define). I thought it was better here… ?

It's better to have the check for the 'init config dir' together with the 'init dir' check…

Is RPM_DEFINE_UTIL available here, so I could just append the _initconfdir define to it?


Ah, I see


nice repo bro


:)

On Mon, May 4, 2015, 22:52 Kim Lindberg Schwaner <notifications@github.com>
wrote:

> Ok; 02e678b
> <https://github.com/RoVi2/ROS/commit/02e678b45db84283b4a1766212292d1085d4d967>
> should take care of it. I didn't think this was something that had changed
> since some very old RW versions.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RoVi2/ROS/commit/80c2f519eec1b7d1987d3fc99c8071d4ef08580f#commitcomment-11033294>
> .
>


Oh just read about this. Bloody Alex Barber.


I suggest we get a release in the ebml-spec repo that represents the same content as the old instance of the spec and then we make deviations like this one off of that.


Thanks for the feedback, will fix.


oops


> NodeMCU also distributes binaries, though I'm not sure if they have the same potential license issue.

And there're cracks distributed on the internet, and crack distributed on the streets. How all that relates to Open Source? If Espressif is interested in support for their products, they should get their licensing right. If you're interested in Espressif products, you should let them know that they should get their licensing right. Like other people do: http://www.cnx-software.com/2015/04/24/wipy-wi-fi-board-for-iot-runs-micropython-on-texas-instruments-cc3200-crowdfunding/#comments


that patch is not correct (https://msdn.microsoft.com/en-us/library/6ewkz86d.aspx). but also not relevant here


oh yea now i remember. :+1:


Updated per your recommendation. Thank you


I think we're going to have to be a little more cautious here. `window` won't be defined in node.


"<aside>


Okay, (window && window.XMLHttpRequest) || node-xhr?


"is no longer supported"


Sorry about the delay. Yes I did, and the answer was "probably not, but its hard to tell because p2g is a pile of spaghetti."

I want to clean up p2g's side of this equation before we start dropping more stuff in PDAL, since at this point I can't even be sure what "correct behavior" even means for p2g. There's a lot of arbitrary stuff in p2g that I hope to go through and clean up (see CRREL/points2grid#6 for a representative example). However, I don't have a ton of bandwidth ATM, though I will free up this summer.

I'll de-assign myself from the issue in case someone else wants to pick it up.


That won't work either. Just using an undefined variable will be an error. It's going to have to be something like this:

```js
module.exports = typeof window !== 'undefined' && window.XMLHttpRequest || require('xmlhttprequest').XMLHttpRequest;
```


this was reported as the cause for non-91 compatibility


Ok no worries...    will keep it in my branch ;) . It seems having hard
coded  values everywhere works for you. It doesn't for me. I need a
constants definition file in one place.  It also makes upgrading to later
retthinkdb versions more sane for me.

On Mon, May 4, 2015 at 11:50 PM, Peter Hamilton <notifications@github.com>
wrote:

> I don't see much value in having this and the file above. Also, see
> comments on the file above re "the proto is the spec".
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/mossplix/exrethinkdb/commit/417b6d4da6a6ba2fb00abf8193f6ff196281d581#commitcomment-11033255>
> .
>


Thats good, we can likely work without rooms for now


Thanks for thorough information and good work on the update.


should this be clusterPolicyBindingResourceVersion?


@moollaza I want to make sure this last part to the sentence is correct - I believe you explained that to me once but want to make sure.


Sure - I didn't change anything in your code. The next commit (that pulls in RMF changes) gets the exact same code from the RMF repository.

BTW, you noticed that all your BD-random-number stuff breaks on the cluster, right?


clusterPolicyResourceVersion?

making a note to see if this even makes sense to do anymore as I review the PR


I've replaced `On`/`Off` with `Yes`/`No` in `cupsd.conf`. I've also added the `defaultShare`, `browsing` and `webInterface` configuration option.


Lets get back to topic and conclude that we will not distribute binaries until Espressif opens up their part of the toolchain with an appropriate license. We are all aware of the variations, meanings and reasons for opensource licenses.


That was an elegant fix.  i thought you'd have to make all the processors have a copy of a "global" cache.


May I suggest a PR?


Nobody noticed this mistake, even though it's here for 3 days already... :disappointed:


crash when loading with segmentation disabled


What I mean is why have this file and `lib/exrethinkdb/ql2.ex` Is there a difference I'm not seeing?

I can see how it would be useful while implementing, but it seems the two file are the same now.


"Forever" = until the next server restart?


You know I merged this to mainline 1.7.10 right?


You haven't properly fixed the formatting Lapis uses spaces - no tabs


That works. Commited and squashed.


##Milestone 2 Feedback
Great job Ella. This is a beautifully concise and clear overview, and your code looks great. Your Milestone #2 passes at Tier IV. Looking forward to seeing your game featured!


Hmm, I looked at x86 generated by CLR JIT and these two options seem to be at best a wash. In fact, the new code seems to have one more branch (jmp). Maybe some other JIT you have in mind generates better code?


Cute. I suppose it happened after a load?


Your example is good, but it describes an engine which is not mature.

This SF is like the Earth. It is old, and heavy.
If I throw a small rock on it, by Newton's Law, both the Earth and the rock will move.
But the Earth...not much.

This test is like a very small rock that we are throwing on SF.
Currently it wins one more game every 356 games, at STC.

With such a low impact, the tuning signal will be quite low.

Also, if we tune everything else that relates, how can we prove that the benefit came from the new change ? It may have come simply from the tuning, and the change might be simple noise...

So we first need to demonstrate  the strength of this change by itself and possibly find ways to make it a little better.

Of course, if our parameter competes with another one, we would have to think about exceptions to mitigate the competition.

Let's see if it passes STC.
Then, it might prove better at LTC, who knows.

+2, -1, +2.3, -1, +2.4, -1...zzzzzzzzzzzzz


You need to capture all the parameters in Strings.
E.g.: { String author, String article1, String article2, .... ->
Conferencia.findByTitle(conference1)
...
}


Yes, for me it is obvious. I translated Startup Guide, within the site where it is installed and someone chooses Dutch language as admin there will be no confusion about.


Heh, was about to complain about this, but yes, it's a really annoying dependency to have.


> That was an elegant fix. i thought you'd have to make all the processors have a copy of a "global" cache.

I thought about doing this to try and avoid the communication, but I think there would still be some communication required to maintain the off-processor data cache...  Hopefully communicating a single value is faster than running an unnecessary `PointLocator` lookup on almost every processor!


I agree, using $args as the third param would make sense.


where does the jl_task_t get allocated in the first place?


I'm not sure I understand the limitation in matching. What I'm saying is why not just have a file with:

```elixir
defmodule Version do
  @type t :: %{__struct__: atom}
  defstruct [
    V0_1: 1063369270,
    V0_2: 1915781601,
    V0_3: 1601562686,
    V0_4: 1074539808]
end
```

why not have

```elixir
def version do
  %{
    V0_1: 1063369270,
    V0_2: 1915781601,
    V0_3: 1601562686,
    V0_4: 1074539808
  }
end
```

and do lookups that way.

In other words, the output of the proto compilation is a fine starting point, but we shouldn't build the APIs (even internal APIs) around a format that we are not actually using. Let's structure our table of constants around how we will use it, rather than structure our code around an arbitrary form of the table of constants.


I will leave it as is. I find the current code easier to read.


share


Jey, thanks for taking care! :+1:


Fixed.


it IS universal, you have to configure the ramdisk to support the app


`sudo` should not be necessary here.
`pip install -r requirements.txt` is enough


Delete this .idea folder please! :O


Good point. Leave it as is.

Santosh

On Mon, May 4, 2015 at 1:42 PM, Kannan Rajah <notifications@github.com>
wrote:

> Not sure which one is better, creating a new object or clearing and adding
> every time. Consider this ... if we follow the current approach, we will
> create the hashset with right size because we know the number of entries.
> But if we use clear and add, the size may have to be resized. If you think
> its better to avoid object creation, I will change it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rkannan82/myriad/commit/c10a75dbbe70a3612107d818a38ebfe86cce3b51#commitcomment-11033129>
> .
>


Fixed issue #1


You can download, unpack, patch and compile Python in any directory. It doesn't have to be /opt/tracemalloc.


Yes i know thats not what i mean man ;)


93441412-HVACTemplateMissingSetpoint-4328 (mjwitte) - x86_64-MacOS-10.9-clang: OK (1640 of 1641 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


107:9: B901 blind except: statement
113:9: B901 blind except: statement


Não sabe o que fez? putz...


@davidfowl

> I would love to understand why this is needed.

Because `Add` gets called after WriteBreadcrumbs which runs on a background thread

@Eilon

> Do we know what caused this failure to begin with?

Yes, it is caused by [this](https://github.com/aspnet/dnx/blob/be5bb7b77550bc2297b1827687206341c3fb0ec2/src/Microsoft.Framework.Runtime/ExportProviders/ProjectLibraryExportProvider.cs#L102). During the dependency walk, we write the breadcrumbs. Before, walk was called only once. Now, it is called from the highlighted code too. Since writing happens on a background thread, it can happen that adding and writing run at the same time.


@thabach Hum...I kind of agree, this should only happens when we are doing the handshake. WIll take a look...


good idea. I will refactor this.


1640-AddHVACPart1 (kbenne) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Fixed the `SCRIPT_DEBUG`; see https://github.com/wplib/wplib/issues/2 for `.min` issue.


Would it be possible to re-enable this option?

I find it very helpful. Reason being, the way my directory structure is setup the output of the module ids would end up mostly correct except for the root js file, I would have a duplicate name:

define('name/name', ...)

Which in itself is not terrible, but I prefer to include my package elsewhere as:

require('name') or import Something from 'name';

rather than

require('name/name') or import Something from 'name/name';

I had overridden getModuleName by hacking into the prototoype:

```javascript
var base = babel.transform.moduleFormatters.amdStrict.prototype;
var getModuleName = base.getModuleName;

base.getModuleName = function() {
  var name = getModuleName.apply(this, arguments);
  return name === 'name/name' ? 'name' : name;
};
```

But recent versions of babel killed this, moduleFormatters is no longer there.

Having the getModuleName as a callback would be very flexible and helpful.


We could add our own logic for optimizing the logic based on the WP `nopaging` param.


I see what you mean about the logging; that would get noisy otherwise. OTOH, I'm not in love with the logging as a permanent fixture, since it noises up the test (`make test`) output. I'll see if I can pass --logging-level=WARN or something into nose.


I guess, I will keep Puss in Boots off for now, until we figure out a better format.
Pedro, you will see Puss in Boots if you apply "Reset admin notices" checkbox. Try pressing "Thank me again ..." button. Do you think it would be annoying?


Maybe you mean the 1.7.2 version in the clean-app branch...? ;-)


You need to capture all the parameters in Strings.
E.g.: { String conf1, String conf2, .... ->
...
}


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.68](http://teamcity.monogame.net/viewLog.html?buildId=6891&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:00


Ok


no good reason I can think of in this case. Should probably flip it back.


does this depend on where pip is installing things? They go to `/Library/Python/2.7/site-packages` when using system's python and then sudo seems to be required. When using brew's python, not using sudo works fine


My bad, I mixed things with the old line break option.


Conferece => Conference


I changed these. Thanks.


i take exception with black and white. bootstrap would agree


Done at https://github.com/google/instant-hangouts/commit/63cff143f44d85e366ee281bea2aeab1fd6ab397; PTAL.


What about (Maybe.withDefault [] (List.tail xs)) ?


Ah, that make sense. Thanks for the explanation!


yeah, sure. but this is one particular instance, and may not apply to other instances. hence why inline styling is appropriate.


##Milestone 2 Feedback
Great job James. This provides a strong foundation to further define the development of your site going forward. Looking forward to seeing this take shape. Your Milestone #2 passes at Tier IV. As I mentioned before, let's think about streamlining the home page "call to action" interaction.

###Suggestions
Rename your CSS file to something more meaningful, such as: milestone-2.css, etc. Be DRY regarding your CSS rules. We can apply the same rules to both images by using a class, combining both IDs in the selector, or by simply using the <img> tag as a selector. More coverage on CSS going forward though! Again, great job.


Yeah :)


Now you made a laughingstock of yourself ...


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/11626/testReport/) for this commit**


ok - so my guess is that autotools on Linux is setting HAVE_CXX11 as part running the various configure macros, whereas clang on OSX / Xcode probably doesn't do that.

Regardless, the fix looks fine to me.


OTOH, would it not be simpler to move the logging out of `__init__` and into the [first] method that does the actual analysis?


Literally released 5.2.11 a few minutes ago that adds a `getModuleId` option so nice timing :smile:. Can't recall why this option was removed since I can't even remember it existing...


Test depends on public folder. We can create a fake uriList instead


Coucou Pau,
Since pythonpath is set to /usr/local/..., I guess the install instructions expect the python binary to be the one from homebrew (doesn't opencv depend on homebrew's python?)
Fred

Le 4 mai 2015 23:28:23 GMT+02:00, Pau Gargallo <notifications@github.com> a écrit :
>does this depend on where pip is installing things? They go to
>`/Library/Python/2.7/site-packages` when using system's python and then
>sudo seems to be required. When using brew's python, not using sudo
>works fine
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/mapillary/OpenSfM/commit/de9e8f4cc36d44c0fcaa9d87669268c0e9b7a3e1#commitcomment-11033876

--
Envoyé de mon appareil Android avec K-9 Mail. Veuillez excuser ma brièveté.


Clearly this is doing more than cleaning up, it also adds delegate methods to each map and watches there for coordinate changes.


Recently I've actually been toying with per-user restrictions on access to the metadata service. Just because user-data is not secret, that doesn't mean that you want all logged-in users to be able to harvest IAM credentials from 169.254.169.254, so I still think there's value in providing an option to restrict it. I might just craft up a NixOS option to restrict access by user, if that sounds reasonable to you, and then replace the blackhole with more granular access (possibly defaulting to no users to replicate current behavior).


So was this actively wrong, or just unnecessary?


So, this is changes the semantics of discard() -- if a query is cancelled, none of the cleanup below happens and discard() anymore -- presumably we are now waiting for object deletion to do this.

If object deletion is sufficient to do this cleanup, do we need discard() at all anymore?  It would be best if cleanup always occured in the same place rather than having two different control paths for it?


Don't you generally mention what package you updated in the commit message (not that you updated the manifest...)?


Laravel 5 artisan does not appear to support the artisan config:publish command anymore. I’m not sure what the new command for this is; hoping that manually writing a config/push-notification.php file will work, but anyway the new README should address this.


Alright the graphics issues should be fixed in the latest version one way or the other, along with some other nasty bugs. I also added more comments to CostOfJob and rewrote parts to make it easier to understand. Since we're working on the same file git probably isn't the best way to go about it. It would be easier just to copy the CostOfJob function, give it a new name and edit it, then post the result on pastebin. I can easily add in the stuff needed for the extra user option.


There has to be a jmp either way. The only time jmp can be avoided is when the method is not inlined but it appears that you want this method to be inlined.

Here's what I see in assembly (x64 - RyuJIT):

2 cast version:
```
cmp         edx,0Ah
jl          00007FF7F20045D9
add         edx,37h
movzx       r8d,dx  ; cast 1
jmp         00007FF7F20045E4
lea         r8d,[rdx+30h]
and         r8d,0FFFFh  ; cast 2
```

1 cast version:
```
cmp         edx,0Ah
jl          00007FF7F2004796
lea         r8d,[rdx+37h]
jmp         00007FF7F200479A
lea         r8d,[rdx+30h]
movzx       edx,r8w  ; single cast
```

It's also possible to get rid of the jmp and jl but the code looks messy and I don't see a significant improvement in performance.


I would expect flash[:error] to be present if the url is invalid in this case.  Changing :notice to :error causes this test to pass


Ok e da imas metod sto ke se vika na primer getMenuIcon sto ke prima samo context i iconValue :)


Did you determine a zfs_action() function unworkable?  I see you mention it here but it's not implemented.


Ha, that's awesome. Right after I posted this I took a look at the latest commits and found the option, works like a charm, many thanks!!!


Uh, what is this actually going to do if you don't implement it? I don't think it will have the correct semantics (it copies the handle to the PETSc vector, not the vector itself).


(The alternative is to add a setup.cfg to the project's top level with a `[nosetests]` section that turns down logging. That quiets `make test`, but manual invocations of `nosetests` (which are the usual for devs) still make a lot of noise unless you remember to manually say `--logging-level`. Longer term, I'd like to improve the status-reporting story for plugins.)


No it's not :(. But changing the order of which ZFS_AC_DEFAULT_PACKAGE and ZFS_AC_RPM is generated seems to have worked:

```
--- a/config/zfs-build.m4
+++ b/config/zfs-build.m4
@@ -322,19 +322,19 @@ AC_DEFUN([ZFS_AC_DEFAULT_PACKAGE], [
                debian)     DEFAULT_INITCONF_DIR=/etc/default   ;;
                *)          DEFAULT_INITCONF_DIR=/etc/default   ;;
        esac
-       RPM_DEFINE_INITCONFDIR='--define "_initconfdir $(DEFAULT_INITCONF_DIR)"'
+       RPM_DEFINE_UTIL="$RPM_DEFINE_UTIL"' --define "_initconfdir $(DEFAULT_INITCONF_DIR)"'

        AC_MSG_RESULT([$DEFAULT_INITCONF_DIR])
        AC_SUBST(DEFAULT_INITCONF_DIR)
-       AC_SUBST(RPM_DEFINE_INITCONFDIR)
+       AC_SUBST(RPM_DEFINE_UTIL)
 ])

 dnl #
 dnl # Default ZFS package configuration
 dnl #
 AC_DEFUN([ZFS_AC_PACKAGE], [
-       ZFS_AC_DEFAULT_PACKAGE
        ZFS_AC_RPM
+       ZFS_AC_DEFAULT_PACKAGE
        ZFS_AC_DPKG
        ZFS_AC_ALIEN
 ])
```
That way, there's no need to change config/rpm.am. Are you ok with that?


Awesome! I accidently pushed 5.2.10 that used the option name `getModuleName` but quickly pushed 5.2.11 that renames it to `getModuleId` so it's inline with the other options and terminology.


This seems wrong. If you move the object `v`, you need to copy its state as well. Or do I misunderstand what you're trying to do? This doesn't "look" like a move constructor.


Yes, getting tired and not following protocol.


Why is this necessary? It doesn't hurt, but it shouldn't help either.


same as for the petsc object: this doesn't actually move any data.


That shouldn't be a problem.  Take a look at ZFS_AC_PACKAGE and you'll see that ZFS_AC_DEFAULT_PACKAGE is called before ZFS_AC_RPM.  So anything defined in ZFS_AC_DEFAULT_PACKAGE will be available when ZFS_AC_RPM runs.  You should be able to literally append `--define "_initconfdir $(DEFAULT_INITCONF_DIR)"` to RPM_DEFINE_UTIL and it will be passed correctly.


@ohnnyj sounds like your project might benefit from the new `getModuleId` as well https://github.com/babel/babel/pull/1386


Feel free to use for your kernel if you like it!! as i said previously, now i'm working on another project  and i don' t know when i will update again the app, but this version is stable and works fine! :)


Doesn't sound very good to have a test that non-deterministically fails. I've disabled it, also https://github.com/NixOS/nixpkgs/commit/bb1081abbd0779b42ecf0bc82c71785e4b047640


Does `BlockVectorBase` have a move constructor? If so, one should call it here.


shouldn't that be "immediately cast" instead of "casted"?


@gpambrozio to review


Wasn't sure if I should amend.  Installing as-is now.


changed.


@tmat On further thought, I agree with you about keeping the namespace string handling as-is.

Thanks for fixing the other things.

This looks good to me.


Thanks mate! :)


salut Fred!
Yes, we should improve instructions. I've used brew's opencv with system's python in the past, but i'm using a manually compiled one right now. I should check if that is still possible.


You're cheating with your comments there... ;)


My patch had not been extended for XO-1.  The string constant that mentions mv8686 should also mention usb8388.  e.g. "mv8686 usb8388, IEEE 802.11g 2.4GHz".


Null check here?


Tiny nitpick: `assert name not in state["eval_env"].namespace` would be cleaner (more directly states what we want + avoids the slight chance of a false positive if some variable is present with the value `None`)


yeah. fixed.


Undoing Commit


Same nitpick here.


I think at least this patch is worth upstreaming. Have you tried to do so?


|=, surely


haha :)


LGTM.


psr-2 creeping in already, lol


This init script still needs to be updatde to be Redhat friendly.  With the current version I see the following failure on boot.

```
Starting ZFS Event Daemon/etc/rc3.d/S50zfs-zed: line 35: start-stop-daemon: command not found
```


Do not be discouraged, no one can simply watched.


All this is fixed.


Oh I didn't cause things broke to me earlier due to an issue with this file - I'll fix it.

BTW can we add a CUDA build test system? If need a machine with GPU I can volunteer two cores or so on piri - I can send you the appropriate cmake line.

ב-4 במאי 2015, בשעה 14:07, Ben Webb <notifications@github.com> כתב/ה:

> Sure - I didn't change anything in your code. The next commit (that pulls in RMF changes) gets the exact same code from the RMF repository.
>
> BTW, you noticed that all your BD-random-number stuff breaks on the cluster, right?
>
> —
> Reply to this email directly or view it on GitHub.
>


Now that's a nice flowchart


species instead of spicies. You use the variable species later on.


I will refactor.


You'll need a file at `build/travis/phpenv/apc-7.0.ini` for the APC config.


Yes. In two cases we need (wanted) to have the output of the dir being tested (log_progress_msg()).

```
for pool in $available_pools; do
    log_begin_msg "Importing ZFS pool $pool using:"        # Basically a echo -n "…"
    for dir in /dev/disk/by-vdev /dev/disk/by-* /dev; do
        log_progress_msg "$dir "                           # Basically a echo -n "…"
        "$ZPOOL" import -d $dir -N $pool 2>/dev/null
        if [ "$?" -eq 0 ]; then
            POOL_IMPORTED=1
            log_end_msg $RET                               # Basically a echo "…"
            continue 2
        fi
    done
done
```

I couldn't figure out a way to do this with only one function (without making it super complex, since it both did the first echo AND executed the command)… But I'll modify the mention of zfs_action().


Yes, a CUDA test system makes a lot of sense. I'll set that up.


Hi Kurt--yes, I plan to add fixes for two more issues (https://github.com/EronHennessey/db2rst/issues) before declaring this phase of work complete. At that point, it'll be in a good condition to merge in.

Thanks much, I use this quite a bit, as I'm often transferring content between DocBook & reStructuredText, so I'm happy to contribute. :)


You don't necessarily need a default empty constructor. Also this would be dead-ish code.


This is not strictly needed in this installation method. If you skip it you are assuming python 2.7 on the host. Which is save, because Galaxy needs python 2.6 or 2.7.


lol at the name of this commit... oops.


I would expect SCRIPT_DEBUG to work on staging, live, etc... should we need it to.


I feel like I've done my good deed for today.


This looks ok, but I wonder how it runs in IntelliJ.


`PATH_NUMPY` and `PATHONPATH_NUMPY` is already being set by `set_environment_for_install` so no need to do it, but it will also not hurt.


What are the differences between what you shared in slack and here?


testing the internals of Globalize in a controller :(


Maksymalna liczba swapów miała zależeć od miary Hamminga, a nie arbitralnie ustawiona. Co jeśli w ogóle będą 4 joby?


Better to call super constructor


Ah, right. "the other way around"… Doh :).


Closed by commit (how to I markup the relevant one?)


Good point. Change made.


This should be sufficient with the current ordering.  Although I haven't verified it.

```diff
diff --git a/config/zfs-build.m4 b/config/zfs-build.m4
index dd4c605..eff92c2 100644
--- a/config/zfs-build.m4
+++ b/config/zfs-build.m4
@@ -139,7 +139,7 @@ AC_DEFUN([ZFS_AC_RPM], [
        ])

        RPM_DEFINE_COMMON='--define "$(DEBUG_ZFS) 1" --define "$(DEBUG_DMU_TX) 1"'
-       RPM_DEFINE_UTIL='--define "_dracutdir $(dracutdir)" --define "_udevdir $(udevdir)" --define "_udevruledir $(udevruledir)"'
+       RPM_DEFINE_UTIL='--define "_dracutdir $(dracutdir)" --define "_udevdir $(udevdir)" --define "_udevruledir $(udevruledir)" --define "_initconfdir $(DEFAULT_INITCONF_DIR)"'
        RPM_DEFINE_KMOD='--define "kernels $(LINUX_VERSION)" --define "require_spldir $(SPL)" --define "require_splobj $(SPL_OBJ)" --define "ksrc $(LINUX)" --define "kobj $(LINUX_OBJ)"'
        RPM_DEFINE_DKMS=

@@ -322,11 +322,9 @@ AC_DEFUN([ZFS_AC_DEFAULT_PACKAGE], [
                debian)     DEFAULT_INITCONF_DIR=/etc/default   ;;
                *)          DEFAULT_INITCONF_DIR=/etc/default   ;;
        esac
-       RPM_DEFINE_INITCONFDIR='--define "_initconfdir $(DEFAULT_INITCONF_DIR)"'

        AC_MSG_RESULT([$DEFAULT_INITCONF_DIR])
        AC_SUBST(DEFAULT_INITCONF_DIR)
-       AC_SUBST(RPM_DEFINE_INITCONFDIR)
 ])

 dnl #
```


Applied too.


https://github.com/CyanideL/android_frameworks_base/commit/ed2625a0882325f815392be32543ebb8d9099583

Fix your authorship issue.........


The only problem is ... Minecraft does not like my .ogg file ```astrominer.ogg```.

Using any other .ogg file there - for example simply copying ```bossliving.org``` to ```astrominer.ogg``` at ```assets\galacticraftcore\sounds\entity``` - will work, and the Astro Miner will make that sound, so the actual Java code is definitely working here.  (The .ogg file can be changed just by opening up GalacticraftCore.jar and changing the .ogg files inside the folder I mentioned - or maybe by a resource pack of course.)

Can anyone help with this?  We just need an .ogg file which works here.  The ```astrominer.ogg``` sounds OK in a sound editor like Audacity, but it sounds like 19 seconds of nothing - or actually a very high-pitched whine - in-game...


Trying


If we're going to treat this as library functions then they should behave as such and not generate output.  Just a return value to be checked by the caller.


This works fine. You only need to export RobWork_DIR="/path/to/trunk/RobWork/cmake" and RobWorkStudio_DIR similarly. Quote from their cmake script: "automatic finding will be used based on RobWork_DIR".


Let's check if SCRIPT_DEBUG is set in development mode and, if not, set to true.  Otherwise, just use the value of SCRIPT_DEBUG.


Good Job!


Hi there


Que color es Bittersweet?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14485/testReport/) for this commit**


Well I don't care unless you want to include it in the debian repository and that is a whole other ballgame. I have not the time or inclination to be the maintainer for the debian repository. I only did this so that it would be easier to install on Raspbian.


Yeah, I understood what you mean :). But thanx...


LGTM.


We should do something here. Unfortunately MSG_NOSIGNAL isn't quite standard, and we'll need to do something different for Mac:

http://lists.apple.com/archives/macnetworkprog/2002/Dec/msg00091.html

I'll open up an issue.


try it, its not my repo ;)


Yeah I might even remove emscripten all together. It's way too incomplete, way too buggy and very very slow as well.


I probably also need to add the APC PECL extension in the case for PHP 7


Again, logging a message is a bit out of scope for a library function.  But setting say a `zfs_error=message` string for use by the caller during failure would be reasonable.


Ok, got it. I imagined that but think that we need to define every requirement packages here.
Thank you


What do you mean?


There doesn't seem to be a sitemap.xml file in the [built files](https://github.com/jsoxford/jsoxford.github.com/tree/c9a5939b49d8f38b1ebd8f6d752b65743ddad355) - did this need more configuration or something?


I think it works because we're not using anything captured/bound to the function after we nix it, but the address sanitizer flagged it.


When issues are resolved by a commit, there is a link to the commit, identified by some global ID, how do I link it here.


alright. May be then I can delete the above two lines.. which will reduce the number of lines!


No, but we can remove the code above this from the other function where it is duplicate. I will rearrange the code to avoid duplicates.


BTW, I made a mistake. This commit should be merged with the next one (I created a new commit instead of updating the current one).


(Jacek: I think you had some refactoring suggestions for a downstream issue?  If so, we could defer any further change here until then?)


The `reregistering` code and additional `mount` doesn't really belong in a checksystem() function which is called by zfs-import, zfs-mount, and zfs-share.  This function, as described by the comment, should just run sanity checks to determine if an import is safe.  As it is now this function comes with serious side effects.


@Glowbal. I guess you want to track which ai units have devices to display them on the bft, right? Some quick comment about take/put eh for that:
- Both of those trigger every time a unit reloads (by far the most common ocurrence), thus doubling the cost of the function.
- I think neither of those trigger if you add the item through scripting (e.g., postinit box of the editor). That could be problematic for editors.


It was a pleasure, mate! ;)


You can link link issues with # and commit using their sha value. You can fix issues from commit using e.g. »fixed #…«.


Maybe a word or two about 'append_parent_contexts'? Just to inform about this new config option.


thanks - just need to add

 -DIMP_CUDA=kernel

On Mon, May 4, 2015 at 2:49 PM, Ben Webb <notifications@github.com> wrote:

> Yes, a CUDA test system makes a lot of sense. I'll set that up.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/salilab/imp/commit/8f6aa125103429219fe7c8cb543129ad152657a4#commitcomment-11034238>
> .
>

--
Barak


...used by zfs-import, zfs-mount, zfs-share, zfs-zed.


The iOS app does not like this, since it (wrongly) assume that the id of a lang is a valid ISO language identifier. But how can one hold a talk in more then one language anyway?


Any idea why my latest commit isn't listed? I got an error about some refs rejected during commit, but now these files no longer appear as "modified".


@townsen Hi Nick, could you take a look at issue https://github.com/capistrano/capistrano/issues/1427? I disagree with this change, and propose to revert it. A host is more than just hostname, I believe a host identity should include user and port. /cc @leehambley


Looks good.


Committed but not pushed because you didn’t pull.


Always crying about something.


Not a big problem IMHO. Thanks also to the 'changes' tab from github.


Looking at the other entries in the software section, I think the version what should go in parenthesis, not the driver.


Will that one work?


Too bad, I really thought that would result in more concise and understandable code in the assorted `zfs-*` scripts.  If I find myself with a little time I might toy around with the idea some more but if we have to have use the various `log_*` messages so be it.


Agreed.


I'll admit I don't get why the six version is no longer suitable in python 3.  Maybe we need a different semantic so we should implement a function with a different name?


Muy buen trabajo.


If we're not testing on Gentoo I'd suggest not adding code to try and support Gentoo.  They're almost certainly going to do their own thing.


Curious, why? It's not a big deal, just weird to have an exception for no reason. Using the hex doesn't even save any typing ;)


If you make me unclean these dishes I may go insane. Let's keep it as the "right" way since it is, after all, the right way to do it. I at first didn't have it like that but is_zero() was used by a few functions already such as vector3 so I wanted to ensure there was no confusion


If we're not using INIT_STYLE for anything, we might as well drop it.


Indeed this language is for extension developers, but you... we must keep in mind that lot of translator are not developers.
So, translate this kind of lang keys is not really easy. especially when there are technical terms.


@chikamichi I made a number of you suggested edits but for the life of me and google search cannot figure out how to test length of json response


Oops, glanced over that one. Will add it.


I think that I want to somehow merge this idea with the Pundit-Devise Rails base app before we get too far along. [Rails-Devise-Pundit]

[Rails-Devise-Pundit]: https://github.com/RailsApps/rails-devise-pundit


Remove


yeah pretty nasty, eh?

On Mon, May 4, 2015 at 5:37 AM, Randy Mackay <notifications@github.com>
wrote:

> We were not-ing a float! that's terrible. better now!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Airphrame/ardupilot/commit/46bdb47c6dcbb3503e9a17e271537588899b0703#commitcomment-11024514>
> .
>


The point of this test is to make sure that python2 longs actually work.  So we should still have something to that effect here.


Jesse wants me to prove that this scheme work by doing this on cloudbees-workflow-docker-plugin. So that's my next step.


Same here.


I change that.


As it says in the test class name, this is also testing python2 longs.


Great! I think this can serve as the system description for the write-up (just need to copy it to the relevant place in README).
Unfortunately, it overlays with the controls for the justice view (and the justice names in the header are still cut a bit).
![screenshot from 2015-05-04 15 13 22](https://cloud.githubusercontent.com/assets/6108821/7463663/2b228d0e-f270-11e4-8eae-47e3d992b3a7.png)


develop (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1135 of 1135 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


LGTM


This should be ViewController, not UIViewController


I don't see your changes to make the app work in landscape mode or to align properly on an iPad.


we could do is_zerof() and is_zerof(), or zero_int and zero_float and then use them in the code in the right places.


Isn't this taken care of by Mage_Catalog_Block_Seo_Sitemap_Tree_Category::getTreeCollection() calling addIsActiveFilter() on the collection?


Nit: New lines for if statement body


Agreed. Besides, it doesn't need to be done three times: Once in zfs-import, in zfs-mount AND in zfs-share. It's enough to do it in zfs-import so I'm moving that part there.


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


107:9: B901 blind except: statement
113:9: B901 blind except: statement


I know. I haven't even started with that yet :). I'm not even sure how to do it cleanly… I'll get to it once it's ok to push again.


Merged: https://github.com/google/instant-hangouts/pull/14


this means that metadata and coverart are not freed in raop_rtp_destroy ... if no callback is set this is a memory leak if i got it right. If the callback is set the implementer of the callback needs to free metadata and coverart. Is this correct?


Oh yes I'm not sure why the two lines were deleted, it was an accident. But they were readded in the latest commit.


It was not about saving bytes.
I don't like to repeat code because I know I won't repeat updates / fixes - but it's a matter of personal pref in the end, I'm fine with this version.


This is also testing python 2 longs.


Eh, I can't think of a place where I'd call inline styling appropriate. Long-term, the convenience doesn't outweigh the benefits of drawing clear boundaries between content and style. But with this being the static site and not likely to need much maintenence, don't think it's a big deal.


Here too.


s/`top.bottom.left.right`/`edges`/

I thought you could just do `.insets(imagePadding)` -- does that not work?


side note: should `allocobj` probably be named `jl_allocobj`, considering it's exported?

It looks like it's the removal of the `realign16` element from the `jl_taggedvalue_t` struct that causes the issue, and either this alignment of `region_t` is really critical or there's some other compiler-dependent alignment behavior that this change is relying on.


Cool (I wanted to take this one, eh eh).
I don't this part is done, though:
> The spells and rooms overlay texts shouldn't show a 0 cost when unspawnable/uncastable, just the text in red.


Thankfully, I don't think these void `return`s are necessary anymore.


Replaced onclick for more unobtrusive javascript using jQuery event.


I haven't figured out what $k is here - is there a guarantee that the id is already in segments?  The usage at line 31 makes it look like this should add ids if they're not present.


Please have a look at the final diff - the PETSc variants are completely removed


s/`top.bottom.left.right`/edges/


Right :). Started out with only those two… :)


Typo: "priorites" -> "priorities"


float vs double question is addressed here as option 2. sucks, but double is the only way to go.
https://groups.google.com/forum/#!searchin/drones-discuss/compiler/drones-discuss/9dKCuNFYXs0/XJRQdcNNYRcJ


Calling reinit with ```reinit(0, 0, false)``` triggers an assertion.


Yeah, I kinda warmed to the idea with one wrapper func to. But the problem is that the LSB functions (nor the Gentoo functions) doesn't do any executing, only logging. Only RH/Fedora is …, well mixing the two functionalities… :(


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


The ```swap``` does... but you need a somehow valid object for ```swap```.


This _could_ be updated to use the `zpool export -a` functionality you wrote and I've just merged.


mhh sorry i see its freed after the callback is fired ... nevermind


hh


added a space

On Mon, May 4, 2015 at 6:16 AM, Randy Mackay <notifications@github.com>
wrote:

> need a little space there between the && and AP_Math::
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Airphrame/ardupilot/commit/635ee57197d057715b901911eaf8fc46383a10cf#commitcomment-11025015>
> .
>


Yeah, but I wanted the if type log_failure_msg check there to make sure we could document that. And I couldn't have an 'empty' if so I filled it with something we MIGHT (?) be able to use. Eventually. Maybe...


ache -> cache


No, it doesn't.


I HAVE tested it on Gentoo. Or at least an older version of this. So it _should_ work without to much trouble. It would be nice if @ryao or anyone using Gentoo could chip in here, but if not I'll test it there once we're getting close to something that we're both happy with. I still have that test VM available (haven't booted it in a while, so I'm not sure it still boots/works though :).


Including Resources as well in the pod


This was accidentally added to the wrong branch. undoing...


sdasd


Sure. We're not logging each export (should we, should be 'prettier' ?) anyway...


Your commit comment says this was useful for layout changes -- maybe add some tests that use this, so it has a purpose? I think we should avoid adding code that's not actually used anywhere; it unnecessarily increases maintenance and complexity. We can always add it later if we do need it.


sadsa


> I don't this part is done, though:

You are right, I had not seen


Moving discussion from https://github.com/nickolay/dxr/commit/a635e7302f3ae3c2ab7f15d53bc23ca0952f5834#commitcomment-11033100

> I'm not in love with the logging as a permanent fixture, since it noises up the test (make test) output. I'll see if I can pass --logging-level=WARN or something into nose.
> (The alternative is to add a setup.cfg to the project's top level with a [nosetests] section that turns down logging. That quiets make test, but manual invocations of nosetests (which are the usual for devs) still make a lot of noise unless you remember to manually say --logging-level. Longer term, I'd like to improve the status-reporting story for plugins.)

Actually this doesn't print any debug() logs for me:

    cd ~/dxr/dxr/plugins/python/tests/test_imports
    nosetests -v

I don't know why `make test` enables debug logging - it doesn't make sense to enable it by default, then not use it in code because it's enabled by default.

It's a pain to add and remove `print`s each time you want to change the code or figure out why a particular case is not indexed correctly, `logging` exists to solve that very problem!


Nope it is not (for Unicode characters) ;)


This is somewhat personal taste, but what about just using `zpool status -x` here and return the error code to the caller.  This would allow `zfs-import status` callers to programatically determine pool health since with the `-x` option unhealthy pools will return non-zero.

```
$ sudo zpool status -x
all pools are healthy
```


OK. I just went through the individual patches for easier reading. Thanks for pointing it out.


> OTOH, would it not be simpler to move the logging out of __init__ and into the [first] method that does the actual analysis?

There's no "first" method in the FileToIndex contract, as far as I can see: https://github.com/mozilla/dxr/blob/d8eae1a29d51cc0238251fda1704915a1869389c/dxr/build.py#L466

If I failed to convince you that splitting the checks between `is_interesting` and `file_to_index` looks weird, I can simply undo this change, I don't think it matters much.

As for your comments about logging, I replied in the commit that adds logging: https://github.com/nickolay/dxr/commit/634f9fa732286931f1ab0ef54c7525e1072868cc


> You are right, I had not seen. I will fix that tomorrow

Np, no rush. :)


I'm not sure how this came back. It didn't show up as a conflict when rebasing


What's with this API change?


This has not much to do with the datastore interface, does it?


- json 으로 응답하려면 필수!
- 이거만 붙이면 return type 에 대해서는 꽤 관용적이었다.


Ah, excellent point. I'm going to merge -- can you add a comment on occasion about this?

Or, alternatively, couldn't you just move the content of `vector` and `last_action` in the member initializer list via
```
  Vector::Vector (Vector &&v)
    :
    last_action (std::move(v.last_action)),
    vector (std::move (v.vector))
  {}
```


Thanks, @mxamin. This looks good.

Now we would need a few more test cases for this code. Can you grab the HTML corresponding to one of such courses so that we don't break things while refactoring/updating unrelated things?

That would be great.


OK, I just assumed you hadn't because it wasn't in the tested section of the README.  And actually feedback from @ryao would be good to at a minimum to determine if these scripts are something he would consider using.


Apparently I committed the updates to github w/o updating the git release tag. I'm also neglected to update the version number on individual labs.

I am correcting both defects now. See v.1.5.5


이거때문에 엄청 고생 ㅜㅠㅠ
action이 'specified'(명시?)돼있으면 'submit'에 대해서 preventDefault 가 되지 않는다.


I kind'a wanted the full status here. I could add a verify (or check option to the script that does just that.


I have all of the collectionView cells draw using a random color so that I could see exactly where they were. We could write some tests that did that perhaps and did pixel analysis, but it would be easier to write tests that just exercised the CollectionView classes.

Its a pain to add and remove any time I need to change this stuff, and I don't really agree (with many people) about keeping unused debugging code in a tree, but I can keep this commit alive somewhere else if it bothers people.


If the default changed from 5.4 to 5.6 shouldn't lan/php5 now be 5.6?


Yeah. Vinnie and I are looking at a better fix. This won't quite work anyway, since `setFullLedger` will get called from the advance logic, which will pollute the ledger cache anyway. Maybe it's time to majorly clean up the history fetching code and fix this at the same time.


Nit: I noticed you always add a space before the colon for subclassing, but I'm not sure where you got this convention. Our [style guide](https://github.com/raywenderlich/swift-style-guide#example-definition) doesn't do this.


:disappointed:


Muito obrigada!!

On 05/04/2015 07:00 PM, Eduardo Alves wrote:
>
> Disponibilizado: 374909f
> <https://github.com/ealves/sistema-reservas/commit/374909f4fb55dfb46f0e0471d80fb51538ca525f>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ealves/sistema-reservas/commit/b57d06e5fc9b814f6b4dbcebb2ca5ddc714b410e#commitcomment-11032326>.
>

--

*Cumpirmentos,*

Yannick Nascimento


My fault apparently. Blame the GitHub application :smile: :+1:


Heh. I just realized that moz_getImageFromCache wasn't independent of the thumbnail code. It was partially independent (i.e. you passed in a cache to use) but still knew about the thumbnail keys. I just wanted to pull that bit out.


this column is needed to store a reference to the uploaded item's picture. is the update failing for you?


The subscript already returns a `Site`, so I think this cast is unnecessary.


Problem is though, that if there IS an error in the pool, zpool status -x outputs the whole status part but does NOT exit with 1!


That being said, I am currently unable to test this, but I am going to merge it, as it looks sane.


You did some nasty rebase things here didn't you :wink:  My original commit looked more like f6281e18651f30f20a4b028e8dfb173ce7ca75d5 but OK :smiley:


Test


```
celia# (zpool status -x 2>&1; echo res=$?) | egrep 'res|state:'
 state: DEGRADED
res=0
```


6:41 5/4


Awesome! I'll check it out after work tonight.


I go back on forth on what's prettier.  Part of me just wants see __four__ lines of output, period.  One per script.

```
Starting ZFS Event Daemon  [OK]
Importing ZFS pools        [OK]
Mounting ZFS filesystems   [OK]
Sharing ZFS filesystems    [OK]
```

Another part of me thinks it would be cool to get a line per-import and perhaps even per-filesystem.  One possible way to go about that would be to have the VERBOSE_MOUNT, and a new VERBOSE_IMPORT option enable additional logging of each import/mount.  The same logic could be applied to the unmount/export.


This is screaming [EnumMap](http://stackoverflow.com/questions/10445274/enummap-or-hashmap-if-lookup-key-is-a-string) to me. Or, since the String is essentially an attribute of the enum value, maybe move this method inside the enum.


There is a vagrant file you can spin up which has ubuntu

    vagrant up ubuntu


Empty now, could remove.


The could be changed to `zfs_log_begin_msg` and then mapped to `log_begin_msg` for LSB.  Then it wouldn't be an empty block and it would be our own interface.


Well, I think per-filesystem is out of the question! I have 760+ filesystems, so… Besides, that's what we have VERBOSE_MOUNT in the defaults file for...


@csfrancis I'm building this one can I ask you to confirm I'm not doing something dumb?


I'm sure you're aware there are several other library function which log messages which will need to be updated.  Please get them all.  :)


Don't forget to remove the AppLog imports ;)


Commenting out code?


But you still get only ONE line per import. It's just that it will look something like:

```
Importing ZFS pools /dev/disk/by-vdev /dev/disk/by-id [etc]        [OK]
```

The [etc] only if it fails with the previous one. In this case, it always tests /dev/disk/by-vdev first and if you don't have setup a vdev_id.conf it should 'fail' on that, but not log it as a fail but instead continue with the next dir. Which is /dev/disk/by-id which should "always" (?) succeed...


Nope. Derp.


This kind of comment worries me a bit because if we're keeping this functionality it should work on systems which don't  use bash by default.  I know Redhat and Gentoo do but I'm not at all sure about Debian.  Also if we're depending on bash functionality that inherently makes all of this less portable.


Yeah, I actually beat you to that with about a week. I just hoped you wouldn't mention it so I didn't have to change ALL of the scripts in ALL the places!! :D


Everyone (?) have bash. It's just not always the "default" (it's not if I remember correctly on Debian GNU/Linux - it's "dash" or something). But bash is always there… That's why I specified that in the hashbang.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.69](http://teamcity.monogame.net/viewLog.html?buildId=6895&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Drat, the way things are it sounds like it's not something we should encourage people to rely on.  I'm OK with leaving things as they are for now.


s/NO/false/


@jorisvandenbossche and @jreback this are the tweaks you suggested.  Going to squash immediately.


I'm curious why you picked v8::Number::New instead of e.g. v8::Int32::New().  I suppose it doesn't really matter but the provider is always a small integer, isn't it?


Maybe it's just me but I find this kind of construct hard to read when it splits line.  If you're already wrapping lines I figure you might as well make it a full `if-then-fi` block to make it more readable.


Oh well, no need to spam builds, mainline push for this can wait for the next feature stuffs.


This is true but there might be other non-root pools imported which need to be cleanly exported.


If you use `env->SetMethod(...)` here, you can use `Environment::GetCurrent(args)` in the API functions.  It's a little faster than the version that takes an isolate and it's not susceptible to context confusion.


will this work when navigating between pages?


I think the "four very clean lines" you proposed/showed is a little TO clean :). But on the other hand, no-one should really be interested in where it found the devices in the boot up. It will be apparent as soon as you run zpool status. And it really doesn't matter. As long as the pool is imported correctly, all is well (even if it finds the devices in the "wrong" place).

Granted, I've encoded my vdev_id.conf in such a way that I know exactly where in the machine each disk is located physically so I'd be somewhat annoyed if it found it in /dev. But I don't look at the boot up anyway, so...


I'd drop the 'FC standards' bit, I don't think it adds anything and makes the script feel more distro specific.


[![Morning Girl Reading a Letter](http://api.artsmia.org/images/120730/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120730)


[![Lintel Arch with Multiple Vishnus and Celestial Musicians](http://api.artsmia.org/images/5110/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5110)


[![Red Totem I](http://api.artsmia.org/images/6326/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=6326)


[![Dear America: My Country Tis of Thee](http://api.artsmia.org/images/122906/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122906)


[![Dear America: Sweet Land of Liberty](http://api.artsmia.org/images/122907/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122907)


[![Dear America: Of Thee I Sing](http://api.artsmia.org/images/122908/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122908)


[![Dear America: Our Father's God to Thee](http://api.artsmia.org/images/122909/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122909)


[![Dear America: Author of Liberty](http://api.artsmia.org/images/122910/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122910)


[![Dear America: With Freedom's Holy Light](http://api.artsmia.org/images/122911/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122911)


[![Story of a Woman](http://api.artsmia.org/images/122916/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122916)


[![Family Portrait](http://api.artsmia.org/images/122975/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122975)


[![Way to Emmaus](http://api.artsmia.org/images/2488/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=2488)


That would be great!  Yes, the netbook resolution is really unfortunate,
even a lot of apps that come with Linux Mint 17 aren't usable with it.
Resizable sounds like the way to go.

On 04/05/2015 3:55 PM, Germanunkol wrote:
> Hm, I'm not so happy with the new resolution. It's currently unplayable
> on a normal PC, since the bottom of the window is cut off.
> Maybe a resizable window is the solution here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KevinField/Wiki-Based-RPG/commit/66d03db596628a7b648e3a9f94909d49aaf6ee07#commitcomment-11032249>.
>


Sir, I tried my best but not working.. Would you like to share your email
address with me I will send you my code.. Check where is error..
On 5 May 2015 3:36 am, "jekkos" <notifications@github.com> wrote:

> this column is needed to store a reference to the uploaded item's picture.
> is the update failing for you?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jekkos/opensourcepos/commit/7efb1428f50fd928f241ee7f0fa50a13dc94168c#commitcomment-11034986>
> .
>


This would make a useful library function.


Yes, you are correct. Ideally I would like to also track this for AI. At the moment I cannot think of any other solution besides constant monitoring of all units, which I rather not do.

The editor part could possibly be solved by having the initial parse run a second after init. Still doesn't work for adding the items through scripting for AI (works for players of course).


Oups, sorry about that, I'll install EditorConfig next time! :stuck_out_tongue_closed_eyes:


Ok. I've started to prefer this way of doing it, but it's more … "unixy" to do full blocks...


matchingTw is still contained in the linked list `server->timedWork`.
don't delete it!


@godiard, you've added a newline here, after version.  I see that now.


how does it work when you have a passphrase then? that command is also used to remove the passphrase.


Hi!  I am using your code here to serve small JPG files for testing an image-manipulating service using stubby since the main branch does not handle binary files correctly.  However, with your patch here, it only seems to work correctly if I pass a `file` key as part of the `response` object and give the filename as a string, then let stubby handle the upload.

Is it possible to preload the binary file into a buffer using `fs.readFileAsync` and then pass the buffer variable name as the value for the `body` key under `response` just as I would pass in the name of a variable containing a JSON object or other value to be passed to the caller as text in the response body?  I would like to avoid the overhead of fs.readFileSync which stubby uses to load in files named using the `file` key.


see above. only add matchingTw to `server->timedWork` if it is newly created.
i'll get to this tomorrow.


Syt::class error in form of categories... Please check it...
On 5 May 2015 3:57 am, "Asad Javed" <asadjaved63@gmail.com> wrote:

> Sir, I tried my best but not working.. Would you like to share your email
> address with me I will send you my code.. Check where is error..
> On 5 May 2015 3:36 am, "jekkos" <notifications@github.com> wrote:
>
>> this column is needed to store a reference to the uploaded item's
>> picture. is the update failing for you?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/jekkos/opensourcepos/commit/7efb1428f50fd928f241ee7f0fa50a13dc94168c#commitcomment-11034986>
>> .
>>
>


Thanks. Done.


Great idea!


develop (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1138 of 1138 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It seems to say that it can't find the config file. However, I can't get it to work either way.


This line caused an error in windows:
>python jenni
Traceback (most recent call last):
  File "jenni", line 24, in <module>
    if os.geteuid() == 0:
AttributeError: 'module' object has no attribute 'geteuid'

Googling suggests windows does not have geteuid


True. I just remembered that inheritance is `Int32 -> Integer -> Number`, so I'd just gotten used to using just `Number. Though I agree that using `Int32` is more explicit as to the expected type. Changing.


:clap:


sorry @Fishrock123, I just saw this comment -- I marked the original v8 4.2 PR as semver-major and then stripped it manually off the other 2 commits that came with that PR so it now shows up with V8 being SEMVER-MAJOR as well as the NODE_MODULE_VERSION bump which I did just to highlight the ABI breakage.


fast_atan2() has been nuked!


breaks for new installs; need to import sys
Line 16:
import imp, os

> python jenni
Traceback (most recent call last):
  File "jenni", line 238, in <module>
    main()
  File "jenni", line 235, in main
    initialize_configs(opts.config)
  File "jenni", line 200, in initialize_configs
    config_helper.load_modules(config_modules)
  File "C:\Users\AByrum\jenni\configs.py", line 46, in load_modules
    print >> sys.stderr, error
NameError: global name 'sys' is not defined


I have move the driverPath to GlobalUtils and create 'PATH_DELIMINATOR'
temporary in GlobalUtils.
In Windows 'PATH_DELIMINATOR' also is  "/".  I have tested before.

2015-05-04 8:13 GMT-03:00 Peidong Hu <notifications@github.com>:

> Here the "/" better to be reaplced by a constant, named for example,
> 'PATH_DELIMINATOR' and Windows should be "\"
>
> 2) This constant should be in testing environment configuration module too
> in the future.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bigtester/automation-test-engine/commit/679abbdd53a78ef4f2f3916195f576025474ba06#commitcomment-11023613>
> .
>


LGTM


lgtm


This isn't doing to do what you want, at least on Redhat.  It will log 'failure' and 'success' which will be confusing.  And just looking at it I'm not sure what the return code will be.


que esta linea? que deberia hacer? no entiendoo


Let me try :)


I don't know really ... there are a couple of PRs in the log that I'm unsure of:

![image](https://cloud.githubusercontent.com/assets/4303686/7464337/58da08c4-f290-11e4-9120-e043aca7dc3f.png)

IMO you should go back to 2.1.5 and merge the ruby/ruby upstream's 2.1.6 tag into our 2.1 branch.


che que onda esta linea? no entiendo


A PHP Error was encountered

Severity: Notice

Message: Undefined property: stdClass::$category

Filename: items/form.php

Line Number: 38


Teste de Edição


That's not quite how it works: Basically, OpenVR is a very general API
which describes a HMD, a couple inputs, a compositor, and a couple other
features. Essentially you implement this as a library, which lets you have
total control of how it works in your implementation (if you are a headset
maker). The only existing implementation is just a wrapper that points to
SteamVR, however for Oculus it would be a wrapper that points to ovrd.
Essentially, the headset manufacturer has complete control of how
everything ends up getting passed to the device, so they could implement
timewarp and any other goodies they like, with the only caveat being that
they would have to create a couple properties in their OpenVR
implementation to let devs turn them on/off (if they exist for the current
implementation of OpenVR). But it is really the ideal case. If Oculus
implements it and is keeping track, then there's pretty much zero chance it
would be behind their API since that would hurt no one but them.

The cool thing about it is, you can implement it for *any* headset. I'm
halfway tempted to make it work for the semi-ancient VR920 I have in my
closet (made in 2004, and immensely hilariously bad)

On Mon, May 4, 2015 at 10:15 AM, StellaArtois <notifications@github.com>
wrote:

> Yes, sounds plausible, although I expect the Oculus proprietary API to be
> ahead of OpenVR by some margin until that point. Worth support for a while
> yet - but at that point, I agree - drop JRift.
>
>
>
> > On 4 May 2015, at 16:06, Zach Jaggi <notifications@github.com> wrote:
> >
> > Awesome. Ideally, Oculus will chip in and support their own
> implementation
> > of an OpenVR runtime (with working timewarp, vignette, etc) and we can
> drop
> > JRift entirely (at some point).
> >
> > On Mon, May 4, 2015 at 10:02 AM, StellaArtois <notifications@github.com>
> > wrote:
> >
> > > Hell, go for it. I'm going to look at that very soon as well once I get
> > > this next build out (within the next week hopefully).
> > >
> > > Was thinking of going for a 'JOpenVR' lib, and then ensuring our
> providers
> > > are JRift / JOpenVR agnostic.
> > >
> > > > On 4 May 2015, at 14:51, Zach Jaggi <notifications@github.com>
> wrote:
> > > >
> > > > Alright, thanks! While I'm at it, I might try to shoehorn in OpenVR
> in a
> > > > JRift-compatible way, or get it working in some other way so that the
> > > Vive
> > > > will have compatibility when it comes out.
> > > >
> > > > On Mon, May 4, 2015 at 8:37 AM, StellaArtois <
> notifications@github.com>
> > > > wrote:
> > > >
> > > > > I need to check a load of stuff in myself over the next couple of
> > > days, so
> > > > > I'll send one over as soon as I have something up-to-date Zach...
> > > > >
> > > > > > On 4 May 2015, at 13:42, Zach Jaggi <notifications@github.com>
> > > wrote:
> > > > > >
> > > > > > Any chance you could give me a minecrift installer current to the
> > > repo,
> > > > > so that I can test if JRift 0.5.* works with Linux? I tried against
> > > PRE2
> > > > > but there was API changes.
> > > > >
> > > > > >
> > > > > > --
> > > > > > Reply to this email directly or view it on GitHub.
> > > > > >
> > > > >
> > > > > --
> > > > > Reply to this email directly or view it on GitHub
> > > > > <
> > >
> https://github.com/mabrowning/JRift/commit/00ce1d66db6fd7a89db011f792c3a86413ae2523#commitcomment-11025338
> > > >
> > >
> > > > > .
> > > > >
> > > > --
> > > > Reply to this email directly or view it on GitHub.
> > > >
> > >
> > > --
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/mabrowning/JRift/commit/00ce1d66db6fd7a89db011f792c3a86413ae2523#commitcomment-11026875
> >
> > > .
> > >
> > --
> > Reply to this email directly or view it on GitHub <
> https://github.com/mabrowning/JRift/commit/00ce1d66db6fd7a89db011f792c3a86413ae2523#commitcomment-11026941
> >.
> >
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/mabrowning/JRift/commit/00ce1d66db6fd7a89db011f792c3a86413ae2523#commitcomment-11027100>
> .
>


@joshleecreates cool to see you doing something with this. Is there anything you're trying to fix in particular?

Why did you remove the endpoints? To me it they should be there permanently and in my case I called them staging and production

Even though Bedrock is great it's a bit of a pain with WPEngine and this script and looks to me like you're not using it anyway.


Ok, I understand your explanation about the proper noun @johnclause. I though it was missed.
About the Puss in Boots, it really doesn't look pretty :)
The behaviour of the "Thank me again" button is not good. It opens the site in the same window, might be better to open it in a new window/tab.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.69](http://teamcity.monogame.net/viewLog.html?buildId=6895&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 485, ignored: 6 Build time: 00:15:51


NC='\033[0m' # No Color

should be added along with adding it to all files


Intenta el malloc,  si es null devuelve error (creo)


Thanks @sublimecoder I just deleted this file.


Hi Aidan,

I have updated it, please check.

thanks.

> On 4 May 2015, at 2:53 pm, Aidan Lane <notifications@github.com> wrote:
>
> Hi @johnliman <https://github.com/johnliman>, for the JS reporting code, I don't think that you need the function_exists('curl_version') check, only needed for PHP reporting code, right?
> Also, I'd put the rg4wp_isIgnoredDomain check on it's own line - either the first or last of the 3 checks- just a code style thing (which they abuse, but I really don't like :))
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/johnliman/raygun4wordpress/commit/cc330fe705632f09f195a6ad243acb7eea51e2d8#commitcomment-11020261>.
>


get rid of this property altogether.  its deprecated


This will be the "problem" that we need to solve for this kind of repository to be supported I guess.


It would be nice to leverage some library functions to condense the above two blocks in to something like. but maybe not exactly, this.  Those variables could perhaps even be merged in to `zfs_log_failure` as the defaults unless overridden.

```
zfs_installed || zfs_log_failure "$zfs log_msg" "$zfs_log_errno"
zfs_modules_loaded || zfs_log_failure "$zfs log_msg" "$zfs_log_errno"
```


There should be a `status` command here if we're supporting it for `zfs-import`.  Perhaps it just running `zfs list`.


I reverted those merges so technically I was back at 2.1.5


Re download the ospos version. A database script was changed or you can try the newest version at  https://github.com/jekkos/opensourcepos


note: the reason for these changes were some comments from players new to the game on too much "eye candy" where it's necessary to aim. that and the default radar vars were not as useful as they could be to those just beginning.

since this commit the crosshair was restored to 0.06 (little too large)


@gmr, what's the point of accessing `self.socket.socket` for the shutdown call? Thanks, just curious.


If `gx` is not contiguous in memory, this will give unexpected results.
There is an option to DebugMode [[1](http://www.deeplearning.net/software/theano/library/config.html#config.config.DebugMode.check_preallocated_output)] to check with non-contiguous output memory, I think this would fail.
An option would be to force reallocating memory if the previous segment is not contiguous.
Another option would be to explicitly write a loop zeroing the array in that case.


Also run this sql:
ALTER TABLE `email_queue` ADD COLUMN `body` VARCHAR( 8000 ) CHARACTER SET latin1 COLLATE latin1_swedish_ci NULL;
ALTER TABLE `email_queue` ADD COLUMN `send_copy` TINYINT( 1 ) NULL;
ALTER TABLE `email_queue` ADD COLUMN `subject` VARCHAR( 255 ) CHARACTER SET latin1 COLLATE latin1_swedish_ci NULL;
ALTER TABLE `email_queue` ADD COLUMN `to_user_id` INT( 11 ) NULL;


See #11.


Yeah


Hi @johnliman, better, but I said:
>Also, I'd put the rg4wp_isIgnoredDomain check **on it's own line** - either the first or last of the 3 checks- just a code style thing (which they abuse, but I really don't like :))

...not the same line... This the 3 checks will be on 3 separate lines... with us just adding a single line of code. Sorry to be so fussy, but we really need to be when creating pull requests on other peoples ' code :)


Igor coricati che è tardi ahah comunque ti ho scritto su fb controlla


@plredmond Let's push better commit messages


Ahah infatti ora mi sono messo a dormire, avevo mal di gola forte e quindi
non potevo che star sveglio.
Ho visto ma non avevo voglia di rispondere ahah
Il 05/Mag/2015 01:15, "ghia16" <notifications@github.com> ha scritto:

> Igor coricati che è tardi ahah comunque ti ho scritto su fb controlla
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/igorravasi/Memo/commit/707f670ffe1658c79911c1668efc9ef1c48574dc#commitcomment-11035504>
> .
>


`dispatch_once` is a good idea!


Not sure when I'll get the time to do this

> On 5/05/2015, at 8:15 am, rembo10 <notifications@github.com> wrote:
>
> Yeah, I think it's long overdue. That's the reason I was checking the diff
> anyway. You wanna do it or should i?
> On May 4, 2015 12:38 PM, "AdeHub" <notifications@github.com> wrote:
>
> > That makes sense, never was any good at maths! Time to push this to master?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/rembo10/headphones/commit/1889ab4825dfefc5533d31c9ad3898244a9cc72a#commitcomment-11031941>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>


Buena dai, la beta è buona e c'è per domani, domattina faccio quelle cose grafiche e presentiamo, poi partiamo con tutti i cambiamenti per fare il sito dinamico


Did you forget to commit the `KVRowsReaderFactory`?


How does `HttpFileSystemBasedFindPackageByIdResourceProvider`?


a typo here and also in the block below: ``__detattr__`` should be ``__delattr__``


I suspect that particular unique constraint came from me a few months back during the getting-TvC-to-work days. Indeed, I do not believe that constraint should ever be violated. They were definitely unique based on all the crazy read/writes I did to the official servers, afaict'd.


yep i already downloaded... but facing problem with pic, cetagories submit
button not working as well as... may i send you code??

On 5 May 2015 at 04:10, odiea <notifications@github.com> wrote:

> Re download the ospos version. A database script was changed or you can
> try the newest version at https://github.com/jekkos/opensourcepos
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jekkos/opensourcepos/commit/7efb1428f50fd928f241ee7f0fa50a13dc94168c#commitcomment-11035448>
> .
>


From my point of view that's the point of a VERBOSE_MOUNT / VERBOSE_IMPORT option.  By default, the output is short and concise because honestly normally you shouldn't care.  When you do care you probably want to set one of these options.

As for the exact wording of the message I don't care too much.  Including where/how the pool was imported is OK as long as the total message length stays under 60 characters.

I'd also suggest that ZED be started early .  This way when it's configured it will immediately start consuming events and posting them to syslog which would help with boot time debugging.  It is safe to start it before the import.  Longer term it's likely to be critical that it be running so the `zfs share` command works.