/stylesheet-without-issues.css:22:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:27:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:33:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:39:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:45:5: Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)
/stylesheet-without-issues.css:48:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:52:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:68:5: Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)
/stylesheet-without-issues.css:73:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:77:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:90:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:93:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:96:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:100:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:103:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:107:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:108:5: CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)
/stylesheet-without-issues.css:110:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:111:5: CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)
/stylesheet-without-issues.css:113:1: CSS3 selectors not supported by: IE (8)
/stylesheet-without-issues.css:141:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:144:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:147:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:182:5: CSS outline not supported by: Opera Mini (5.0-8.0)
/stylesheet-without-issues.css:184:1: CSS Generated content for pseudo-elements not supported by: IE (8)
/stylesheet-without-issues.css:200:1: CSS3 selectors not supported by: IE (8)


positons is a typo. Sorry to nitpick on great work


If this one comes second in your markup, I think you need to use rewind_posts(); before it. But, it looks like it is still working for you, yes?


Done. This issue should be closed.

@zeecoder, please address your feature requests to @solistra. Good luck.


Compensatory change for https://github.com/OpenTreeOfLife/ot-base/commit/7da7b4ad53d89b48fb78c223df7baf50811016e8


Maybe you should remove the sender.close(successCb);

Since the sending is an async and closing will cancel all messages still in queue it might not send them and cancel all callbacks. Can you try that?


They're provided by the same package so it _very_ likely, although there's no harm in being extra careful.  We could consider drop this hunk entirely since the tools have been unified in to udevadm for quite some time now.


Slashes in file directories are bad practice!  Probably use `os.path.join(RIPPLE_HOME, 'bin', 'python', 'Manifest.py')`.


Hola!!!! @nahuelsotelo necesito tu ayuda, cuando le pongo el Doctype al comienzo del documento me peta todo!!! Me lo podrás ver a ver que pasa?!! Graciasss buena semana!!!!!!


fixed #6


is this used?


I will, and thanks again for the good work. :)


Great point. Fixed. Thanks!


Thanks

I will read through the material again

Dan Williams, SIQ Agile Coach
CSM, CSP, PMP
Cell: 425-877-6333
________________________________
From: Jean-Denis Vauguet <notifications@github.com>
Sent: Tuesday, May 19, 2015 1:40 PM
To: danielwilliams12/new_options
Cc: Dan Williams
Subject: Re: [new_options] topics and posts assignment (9ff7759)

Nice :) To sum it up, in that assignment, you used the singular resource notation<http://guides.rubyonrails.org/routing.html#singular-resources> to generate some routes matching the one-to-one association between a Post and its Summary, an association you set up using has_one<http://guides.rubyonrails.org/association_basics.html#the-has-one-association> / belongs_to<http://guides.rubyonrails.org/association_basics.html#the-belongs-to-association> (see also the full documentation about has_one<http://guides.rubyonrails.org/association_basics.html#has-one-association-reference>).

-
Reply to this email directly or view it on GitHub<https://github.com/danielwilliams12/new_options/commit/9ff775976d060dcd06eddc34d0350b3aeb183a5e#commitcomment-11270802>.


Fixed. Thanks!


Yep, that works (I tested and changed it). Thanks.


Mike was here. ;-)


Thanks for the catch @harrisj! I warmly welcome a copy edit nitpick.


This shows how one bad decision (a proprietary format for config files instead of JSON or something universal) leads to work in the future for everyone...


Pool names can contain whitespace.  It's rare but should be handled.


I have tapped dupes (`brew tap homebrew/dupes`), so I only used `brew install tidy-html5`. I don't know if it is in the main formula repository or in the dupes.


Report the key please!


`'...but got %d keys instead (%s)' % (len(result), result))`


Documented here: https://www.phing.info/docs/guide/trunk/conditions.html


Yes we do, as app.js doesn't get executed in the tests. OAE sticks it in oae-util/lib/oae.js which is potentially too late. It's recommended to put it before anything else (`new Date()` really) can be executed.


The more careful the review the better!  Keep it  up @dun!


Wait, why don't you just import the Python code from Manifest instead of running it as a subprocess...??


@paul150792 mvn clean install is just fine.

The produced jar only contains RCaller's compiled code. How about external dependencies? Can we embed these dependencies in our jar? Are the size or the license problem?


Same as above.   You should be importing the Python directly, not calling it as a subprocess!


If I understand correctly how contexts work, you don't need to be checking context.Done all the time in your high level code. After the context gets canceled, the next time you do something significant with it (like an RPC) your call will return an error saying it was canceled. So, the only place you may have to look at ctx.Done is your lowest level code.


It is in the main repository now, according to this: http://brewformulas.org/TidyHtml5


Do we have to upgrade honeysql as part of this PR?


> a list of the expected arguments

Really? I thought it is a list of possible argument counts.


Thanx Tom!

Yes, I know it seems pretty messy... Well I have to put a lot of "investigation", testing and Googlin' to make my ideas come alive. Sometimes what would probably be small problems for others turn out into hours of work for me :/   I'm not professional programmer, only do this in free time and learn by tryin' :)

Anyway, feel free to include anything from my fork into Yours and possibly re-make it in code-wise prettier manner where appropriate. (btw. some of "changes" are only consequences of simple indent-reformating :)

Agree on that one - anyone's work on this project benifits all of us!
Keep up the good work and thanx for StravistiX!

Regards,
Dejan, sLOVEnia


Well, my thinking here was that we'd want to run the `build` target first, test things to make sure everything looks good, then run the `release` build. However, I don't see any harm in depending on the `build` target--I specifically avoided doing so because it would've added a lot of time to my testing of the `release` target, but once we're happy with the `release` target, having it run through the `build` target first makes a lot of sense.


I concur wholeheartedly :(


Got it, I missed the embedding in a for loop that compared all value columns in order.


Thanks much.


This code seems like it'll work badly everywhere!  It won't work on *nix where we have no .exe files but the wrong slashes will make it work badly in Windows...


My pleasure.


Any ideas what that [indecipherable] word is? https://youtu.be/09bUpNbRzzc?t=1h26m53s


This should put the object into the cache right?


Perhaps Dan will know how to explain it.  I'm not really an expert to type
lookup.  My hunch was that for fst namespace functions the fst namespace
will be consulted first to see if the types referred are available.
Y.
On May 19, 2015 11:13 PM, "Kirill Katsnelson" <notifications@github.com>
wrote:

> I do not know how to distribute a patched openfst on windows. There is a
> port available from their site and, for later versions, on Github. There is
> a lot of changes compared to the original version. Perhaps we can add it to
> the latest version, or maintain a fork under kaldi-asr. Patching before
> build is not the best option to me.
>
> I tested your workaround, it works. Very smart. I do not understand why
> the error happens, and why is the problem patched by this. fst::int64
> somehow preferred to an alias int64 = kaldi::int64, but in the absence of
> fst::int64, the latter is ambiguous. Can't explain.
>
> Also, do you think it will do if we simply #include it into kaldi tools,
> possibly gated by #ifdef _MSC_VER or like?
>
> mingw32 (which you definitely have when using git),
>
> I am using cygwin's git (it is version 2.x) with Tortoise, but I am
> adventurous. :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/f0f9e7a0c239d97660979fc13e8938a5757a66d2#commitcomment-11271471>
> .
>


Mike was here. ;-)


No idea what this line is doing - the nested for statements are often counterindicated.


OK, then we still need to copy all array params in the constructor.


It would be pretty nice if you replaced all the 60*time.Second with time.Minute.


Thank you!


@peterabbott any plan to convert #44 into a pull request?


Why just not return (actually returning `None` and then let the caller decide whether to test the result?


Good point, I will add a test to see if running under bash. However, the point becomes rather moot in this case, since pipes are not going to be even used in native Windows library decoder.

The path tinkering is harmless. Windows paths are transparently supported.


You are ignoring the error returned by the worker here. Are you doing that on purpose?


I'm not sure this is the best default time to live, though I'm not sure what a better value would be?


Ok, see 0a30cab for fixes.


There's no huge advantage to `@property` if you aren't creating a setter - but it's a matter of taste.


Hi @TheSin-

The alignment issue appears when header contains multiple rows and when inputs is not contained in first row :

Demo with alignment issue : http://jsfiddle.net/856bzzeL/291/

![capture](https://cloud.githubusercontent.com/assets/3995851/7714247/7b78eeba-fe7d-11e4-9a26-8efa832a16f6.png)

Demo without alignement issue : http://jsfiddle.net/856bzzeL/290/

![capture2](https://cloud.githubusercontent.com/assets/3995851/7714307/e4324d34-fe7d-11e4-8689-423f42ec3150.png)


Is this notation correct? Casey reads it out [here](https://youtu.be/09bUpNbRzzc?t=1h27m45s).


ditto


maybe return false instead of null?


Why yield?


The reason I'm running it as a subprocess is I'm trying to test the process a user goes through to create a manifest. I could import it, as you suggest, but I felt this was a more accurate test.


Yeah :D


Why not just remove 290, and then put the `try` statement after 291 - then you can also delete the `if` statement on 295?


.. actually, in this case connection['dbms'].startswith('postgres') is enough, it covers both cases


Mike was here. ;-)


Since move might not have been defined yet, call getPlayerMove() and getComputerMove() without a parameter. The parameter will automatically be set to undefined until the player or computer sets their input.

Try this:
```js
var playerMove = getPlayerMove();
var computerMove = getComputerMove();
```


I'm really not getting this `contextmanager`/`yield` idiom...?


This doccomment is a bit tautological.

"StatusWorkerState represents the StatusWorker's state."


Ooops :smile: You are correct. SSH service can be run as `--service /:SSH:example.org` so it should say something like this:

> ... on local (or \<host\>) system  ...

Is this OK?


You are trying to pass in the playerMove and computerMove variables before they have been defined. You can delete this line.


Why not do this to the individual strings after parsing it?  Seems more robust to me.


ahh the issue is in your inputs, the are pushing out the width.

This is extreme, but you can see when I shrink the inputs it's fine. http://jsfiddle.net/856bzzeL/292/


Another idea, is that we could create a separate build file for releases. I'm not sure if I like that or not yet, but it does seem like it would make the code easier to work on; i.e., two separate files instead of everything in one. I can see the release-related targets becoming length over time as we enhance them.

Note that we could create a `.build-release.xml` file and call the `build` target in `.build.xml` from that second file. See: https://www.phing.info/docs/stable/hlhtml/index.html#PhingTask


Does go have something like type aliases?  It'd be nice to call map[string]SecretSpec something like 'Secrets' or whatever.


Fixed in 1e4f4c0


Actually, as a note: this expects the YUI library to be present which you seem to have removed as part of the make process.


I find that it is often helpful to break the things you are going to interpolate out into external `val`s, so you can use the lighter-weight `$variable` syntax instead of `${variable.foo.bar}`. YMMV


also this isn't my new code.  You reverted it back, I was asking about the new code.


This is a bit fishy and I feel like it's a landmine waiting to explode, but I don't know how to fix it. @vouillon, how does ocsigen did previously ?


Hi Sylvain, thanks for the precious help. removing sender.close(successCb); was of no help but for some reason setting the callcbacks to null like this:

sender.send('/message', data, null, null);

worked, I heve no idea why. I hope this info helps you and if you find out what’s wrong with my callback functions I would like to know becaus it would be nice to use them, regards:

Axel

> Em 19,mai 2015, à(s) 18:15, sy1vain <notifications@github.com> escreveu:
>
> Maybe you should remove the sender.close(successCb);
>
> Since the sending is an async and closing will cancel all messages still in queue it might not send them and cancel all callbacks. Can you try that?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/sy1vain/cordova-osc-plugin/commit/7e48be6b37a4abf5706e9ff712abd1336bc29858#commitcomment-11271509>.
>


Leaving Mu exported is a bit confusing. Why would I use it instead of having my own mutex? Also, State being exported is a invitation for racy code.


We don't want json to be navigational, I have reverted this in #177


See my other comment about contexts and checkInterrupted.


Version 2


None stated right now. fyi, this document doesn't talk about C++11 much since it's evolved from long before that was available to us. In fact, we still can't use (real) STL in the JIT due to build tools issues!

IMO, scoped enums are good and fine, as long as they don't reduce "grep-ability".


Mike was here. ;-)


using 100% works in both old and new code. http://jsfiddle.net/856bzzeL/293/

Honestly this seems more like a design/css issue then a js issue.


Thank you so much.
I appreciate this.


Have you tested these changes? 1024 bytes seems to be awfully short, deflate has sliding window of up to 32 768 bytes. While I am not too famimiar with the internal workings of zlib, I think there might be some cases where this would cause AntiZ to miss an otherwise acceptable set of deflate parameters. And slow mode is meant to be thorough, and not cut corners that hurt recompression. So I would increase this to at least 32KB.
Otherwise it is a very nice idea!


Edit made in ede470.


Thank you, it works better now. Though it still shows replies (SIP 200 OK) to OPTIONS packet. Is it possible to filter out OPTIONS/NOTIFY transactions completely?


I dunno, that's just what the list I copied from did: https://chromium.googlesource.com/chromium/src/base/+/master/strings/string_util_constants.cc

I can switch if that feels more readable.


This kind of thing makes me quite uneasy; You _really_ shouldn't be writing your own logic to compute companions by `String` matching (or doing this general type of thing). You should be leaning on some sort of reflection-type API to do this. Otherwise, it's a slippery slope to re-implementing a huge chunk of reflection. Maybe it's fine for a prototype, though...


good catch. There was a problem with conversion from Word here. Not that there was any content here anyway :-)


This logo rules. ;-)


@aaijazi is right, context cancelation should give us this for free.


Good job, but you definitely need to rearrange your if/else statements to make sure that all cases of a 'tie' can be handled. Right now the program is only registering 'rock' vs 'rock' ties.


Yes but I have the need to have taller input in table, and I have more 50 columns... and ultimately, a column disappears...

I use the new table sorter release. Why use old version?


No need for the Q here.


That's a good start.


ah, in that case for sure it was folded in in Xenomai 3, I think I remember reading about it somewhere.


There is no need to include jquery or any of these other scripts. they aren't used anywhere.


If you are going to use Booleans (which I'm not really happy to see.... like ever), you should at least name the parameters for your arguments. As it stands, I have a very hard time seeing what each `true` or `false` means.


Ok you fix the bug by set .tablesorter-header input {
    width: 100%;
}

But if we want taller input, I can't...


the code I posted is newer then release, and I wanted you to use it so I know if it's good.

either way simple css can fix it.


can you refactor this a bit. Maybe something like
```python
ok_statuses = (
    Event.STATUS_SCHEDULED,
    ...
)
if event.status not in ok_statuses:
    ...
```


I see in your code you pass errCb but named it errorCB.

Does moving the call to send to below the definition of the functions help?


likewise, there are no elements that have the ID's specified by most of these CSS tags.


Looks like VoxelMap needs to be returned as IMyVoxelBase for use in the API from now on.


thanks


I think this function can be more clearly re-written as: (not tested)

```
void SplitStringAlongWhitespace(const std::string& str, std::vector<std::string>& result) {
    auto it = str.begin();

    do {
        auto first = std::partition_point(it, str.end(), [](char c) {
            return kWhitespaceASCII.find(c) == std::string::npos
        })
        auto last = std::partition_point(first, str.end(), [](char c) {
            return kWhitespaceASCII.find(c) != std::string::npos;
        })
        if( first != last )
            result.push_back(std::string(first, last));

        it = last;
    } while( it != str.end() );
}
```


by taller I assume you mean wider, yes you can by setting width on the col it's self I do it in my tables all the time.  Just use css to fix this issue.  This is not a TS issue.


We decided last week that we were going to make the bubbles big enough to enclose the names of each node. this is a hacky way that doesn't look as good IMO


Fixed that. It appears to be linking properly now


should we flat-out exit when this happens? I think it's likely that, if the user has such a customization, they'll have some other piece of config or custom infrastructure that depends upon it.


I would take `output` by non-const ref.


mmmm, clojure 1.7 goodness :yum:


We use Win32 exceptions in a very specific way. But yes, using C++ exceptions or letting them propagate would be bad. Instead of a blanket ban, I think we'll let code reviewers "do the right thing" if someone proposes using them.


There are a few others in other documents but nothing that a simple find-all-and-replace can't fix. Keep up the great job.

> On May 19, 2015, at 5:16 PM, Elaine Kamlley <notifications@github.com> wrote:
>
> Thanks for the catch @harrisj! I warmly welcome a copy edit nitpick.
>
> —
> Reply to this email directly or view it on GitHub.
>


It's generally good coding style to look through the diff before committing and avoid adding in random extra lines.


can we warn / puke if they *do* try to configure them?


Yes i will do that manually ;)

Thanks !


Actually you'll need to catch `InterruptedException` separately now (or test for its type with `instanceof`), since we still need to throw an exception to the caller, and we don't want to be spuriously interrupting the thread for an `ExecutionException`. I take back what I said about wrapping `InterruptedException`: I think if you reset interrupted status then it should be OK (it would still be interesting information in a stack trace).


Anything libasync related could probably go directly to master. The rest would best be targeted against http2-botan-cleanup. server.d and http2.d should also be more or less done in the branch, so that rebasing should later be possible without conflicts (client.d isn't ready yet).


As a general comment, I'm not sure that I like seeing everything getting upcast to DocElement everywhere. I am a proponent of specifying that a method takes an exact parameter type and of keeping multiple, exactly-typed lists of children (or at least virtually doing so via exactly-typed def members which perform a `collect`) when it makes sense.


\o/


How about I write the wiki article first, test the process, repeat a few times! Then I can include an estimate to help you and others. @justinclift what do you think? Who can point me in the right direction?


We didn't originally talk about this pan and zoom functionality - we'll discuss it at the meeting today. It seems unnecessary to me and more likely to confuse the user. The bubbles already naturally lay out on the screen in a pretty optimal way.

At the very least, we need to limit the amount the can zoom/pan because right now you can zoom infinitely far out and lose the graph.


The model is the only place that has our JavaScript? I did not know this. Great Job! :+1:


This doesn't seem to be your latest version of your code, no?


I'd change the %, ^2, and < to actual words: mod, power of 2, less than. Other than that it's verbatim what he's saying.


let's make these anonymous functions


so... this factors out the dashboard into its own service as well? or was it always like this and just moved? In any case, this deserves a mention in the commit message.


we should put this near where it's used - unclear what it does without searching


? weird. what do you need this for? Activity shoud inject itself in oncreate


It is unchecked…

> On May 19, 2015, at 1:50 PM, dothework <notifications@github.com> wrote:
>
> In your Instagram app settings - is Disable implicit OAuth checked or unchecked? Must be unchecked.
>  <https://cloud.githubusercontent.com/assets/9028552/7713608/e697392c-fe46-11e4-8544-01d958df71fd.png>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Notsosof1/Blocstagram/commit/ce935dc5cf897499f4d4c1f7daeaa2eb88e8c75c#commitcomment-11271029>.
>


Ahh I see now colgroup is added by ts, let me see if I can fix it, one sec.


This might be better as a `isDataCached($row)` method that returns a bool. That can help the DB mediator figure out if it should perform an update or an insert. As things stand now, the Mediator has no way to figure that out. Either the mediator acts from the root's perspective and the row data mappers figure it out, which I'm not a fan of, or the mediator needs a way to ask the row data mappers if the row data already exists or not.


please set your editor to use the same indentation as everyone else in the future - it looks bad to have random mixed spaces throughout the project


Why not use `std::chrono::high_resolution_clock`?

http://en.cppreference.com/w/cpp/chrono/high_resolution_clock


DONE

Copy&paste error :(


@robertmesserle, this makes perfect sense, in which case I would suggest:

1. Document it (so people don't get their templates unexpectedly broken).
2. Make sure the element only contains text before starting to interpolate etc; e.g. with something like:

        ```js
        function MdHighlightCtrl ($scope, $element, $interpolate) {
          $element.text($element.text());
          var term = $element.attr('md-highlight-text'),
                text = $interpolate($element.text())($scope),   // notice: no `html()`
          ...

WDYT ?


>> Having optional out parameters will be, I think, a relatively rare case.

> And returning an empty string from an out parameter will be even more rare.

Just that in the former case we are talking about some minor additional typing (`Nullable!`) and in the latter case about a bug that may be hard to find due to its rarity.


You're making a lot of similar console.log statements within your getWinner function. Try to group your statements so you only console.log once for each unique result. You should only have console.log('player wins!'), console.log("computer wins!"), etc. appear once in your code (DRY - don't repeat yourself). Instead of immediately returning 'player' or 'computer', you could make a variable called 'winner' at the beginning of the function and set the winner for each case. Then you can make an if statement that checks to see who the winner is and logs out a winner based on that variable.

Sorry if this is confusing :/ Comment back if you have a question.


This is very very old change, I didn't check but I think this was changed to an one line profile using ```addProfile()```
And I think you added the fallbacks, I may have made a mistake when manually merged, but they still should be there.


Should I put Instagram.com <http://instagram.com/> as the website URL???

This is what I entered…

Basic
 <https://instagram.com/developer/clients/eeb5d2b7dea143d088e51a47b7035aee/edit/#basic>Security
 <https://instagram.com/developer/clients/eeb5d2b7dea143d088e51a47b7035aee/edit/#security>
Application Name
Do not use Instagram, IG, insta or gram in your app name. Make sure to adhere to the API Terms of Use <http://instagram.com/about/legal/terms/api/> and Brand Guidelines <https://www.instagram-brand.com/> .

Description

Website URL

Redirect URI(s)

http://google.com× <https://instagram.com/developer/clients/eeb5d2b7dea143d088e51a47b7035aee/edit/#>
The redirect_uri specifies where we redirect users after they have chosen whether or not to authenticate your application.

> On May 19, 2015, at 1:50 PM, dothework <notifications@github.com> wrote:
>
> In your Instagram app settings - is Disable implicit OAuth checked or unchecked? Must be unchecked.
>  <https://cloud.githubusercontent.com/assets/9028552/7713608/e697392c-fe46-11e4-8544-01d958df71fd.png>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Notsosof1/Blocstagram/commit/ce935dc5cf897499f4d4c1f7daeaa2eb88e8c75c#commitcomment-11271029>.
>


Тут должен быть квадратный корень, потому что для 9 состояний финт с делением на 2 уже не сработает.


Good description of MVC! :+1:


okay I wait :-)


why are we calling this function when the page is being created?


Aha! Here would be a good place to console.log the winner!


another example of why it's important to look through the commit - this was not actually changed but the indentation was. it makes it hard to look and figure out what you actually changed.


Good job! Try to refactor and minimize the times you're using console.log.


Overall I think this looks very good. A couple of notes:

1. These changes appear to be made against the latest version on CPAN rather than the development version that is currently on github. I assume you copied and pasted your modified Client.pm into a fresh clone of the repository. That nukes some changes I made in development; if you don't mind, please reapply your changes surgically to the latest revision. Thanks!

2. Please add a test case or two to ensure that this code works as expected and handles expected errors gracefully.

Submit another pull request once those changes have been made and we can work them into the next version release.

Again, thanks for your contribution! I look forward to seeing the next ;)


Oops...  YES to using docker exec, NO to using mongo port


<html>
<body><b>This is my First Page.<b></body>
</html>


I think it's structure, because that's where BytesPerPixel was if I recall correctly


Case 1: will be added soon.


@groutr typo: scripts -> script


GPS works now, needs a few fixes but it works.


why is this necessary? doesn't change the behavior of the page substantially, the nodes pretty much avoid each other already. especially with the drag-and-hold behavior this seems like it doesn't do much


So, basically only scheduled events can be `is_live` or `is_upcoming` right?
If an event's status is Scheduled it won't be Processing so that boolean expression looks odd.
It's like says:
`if gender == male and not gender == female ...`  (assuming `gender` is only `male` or `female`).
Basically, if `gender == male` then it won't continue into that boolean expression so there's no more point on doing if statements on the gender. Right?


we should discuss if fisheye is something we want before we continue implementing it


This is true for all method with the $exclude_ids argument:

If I'm the DbMediator, how do I know which Id's to exclude? For non auto incrementing keys, I'd have to check each one by hand. This seems like work the caching mapper should be able to do.


Looks good to me. I went over the integration changes and just glanced at the analytics UI code.


So, we still want the user.admin? to be here. What you can do is create a specific admin user that you log in as to create topics. You can do this in your seeds file, OR you can make your user account an admin.


That's the first field in the settings dialog: Options -> Edit settings


Just made it look better.


What situation will give you a collision?


I don't think bitwise or `|` is what you are intending here? `||` is logical or.


The `yield` in the context manager is bound to the `as` clause in the `with` statement. i.e. `with rippled_server(cf) as server: server.foo()`


Cheers for the suggestion, @effect0r. [#82]


dont see anything here


These functions should all be located nearer to where they are used.

Also, I don't think this is the functionality we talked about for mouseover - we mentioned potentially doing this on click along with the tooltip but it was not something we talked about doing this week.


case 1 already working.
Working on case 2 & 3.
Testing some examples then adding it to the master.


The whole class needs indentation due to the namespace.


I  have notice today if we remove border: none; from

```
          ' table.' + tscss.table + ' thead * { line-height: 0; height: 0; border: none; background-image: none; padding-top: 0;' +

```

there is no alignment issue in chrome and firefox, but it persists in internet explorer


all arguments `const &` (maybe not the bools)


I don't think so. I'll take a good look in a couple of hours.
Can you send me a link to the github commit that I should be testing?
Sent from Outlook for iOS

On Tue, May 19, 2015 at 2:46 PM -0700, "Cynthia Whitlatch" <notifications@github.com> wrote:

Should I put Instagram.com <http://instagram.com/> as the website URL???

This is what I entered…

Basic

 <https://instagram.com/developer/clients/eeb5d2b7dea143d088e51a47b7035aee/edit/#basic>Security

 <https://instagram.com/developer/clients/eeb5d2b7dea143d088e51a47b7035aee/edit/#security>

Application Name

Do not use Instagram, IG, insta or gram in your app name. Make sure to adhere to the API Terms of Use <http://instagram.com/about/legal/terms/api/> and Brand Guidelines <https://www.instagram-brand.com/> .

Description

Website URL

Redirect URI(s)

http://google.com× <https://instagram.com/developer/clients/eeb5d2b7dea143d088e51a47b7035aee/edit/#>

The redirect_uri specifies where we redirect users after they have chosen whether or not to authenticate your application.

> On May 19, 2015, at 1:50 PM, dothework <notifications@github.com> wrote:

>

> In your Instagram app settings - is Disable implicit OAuth checked or unchecked? Must be unchecked.

>  <https://cloud.githubusercontent.com/assets/9028552/7713608/e697392c-fe46-11e4-8544-01d958df71fd.png>

> —

> Reply to this email directly or view it on GitHub <https://github.com/Notsosof1/Blocstagram/commit/ce935dc5cf897499f4d4c1f7daeaa2eb88e8c75c#commitcomment-11271029>.

>

—
Reply to this email directly or view it on GitHub.


It's not really `JSON()`'s fault. Because of its coupling to `NSJSONSerialization` and `NSDictionary`, JSON values are `AnyObject` (and keys are `String`s).

`Int64` and `UInt64` aren't `AnyObject`. Same problem we have with prefs.


Cool!
But I think you now need to explain thinking with a comment. It might be confusing for someone in a year what this reasoning is. Especially for someone who doesn't get that some events go from live to transcoding to archived and that some go straight from transcoding to archived.


Fazendo assim como vai funcionar o serviço executar as funções se o mapeamento não é feito?


yep, by the module for validating the master's connection with puppetdb


const.
maybe by reference too?
also const function?


I don't see a sidebar.php file?


100% based on database state, yes. :trophy:


changed it back


you can `String::toStdString(fsutils::toNativePath(m_inputPath))`. The wstring signature is deprecated (look the libtorrent header comment).


does this situation occur?


This is a bit of nitpick but I would, personally, indent the code thusly:

    Stream& logAction(
        Stream& s,
        std::string const& action,
        AnyPublicKey const& pk,
        std::uint32_t seq,
        std::uint32_t oldSeq)
    {
        ....
    }

Don't feel like you have to change this; just a general comment.


LGTM


toStdString() (wstring deprecated)


that's a good point, I'm not sure what we should do there, how do we test for this if we system/exit?


@agudian , looks fine to me.. One question only. Perhaps add some comments at that line.


ClangModernize (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2121 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.41%25-yellow.svg)


rax retry tests


I corrected the name of the function and it worked just fine, no need to move the call below the functions, thanks a lot, great work!!
> Em 19,mai 2015, à(s) 18:37, sy1vain <notifications@github.com> escreveu:
>
> I see in your code you pass errCb but named it errorCB.
>
> Does moving the call to send to below the definition of the functions help?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/sy1vain/cordova-osc-plugin/commit/7e48be6b37a4abf5706e9ff712abd1336bc29858#commitcomment-11271885>.
>


@bakaxyf @UUUii @IamAchang Would y'all like to translate this... XD


yeah that's a good idea, i just recently changed this to override a user config.


good point, it was moved to its own service so that it doesn't get server at `/pdb/query/dashboard/index.html` and instead just `/pdb/dashboard/index.html`


You allow lfds to be more than 1 but you only use one. Unless you implement more than one asserting `lfds == 1` is probably best. Also a better error message than `LISTEN_FDS < 1` would be good considering from the name it isn't obvious whether LISTEN_FDS is a number of file descriptors (which it is) or a list of file descriptors (which is what I would have guessed).


Should this be added to `public static boolean isExceptionSupported(int errno)` below?


ValueError as e


I like this, but people do seem to want to have the default config as a file so they can start editing it immediately.


Why `0` and not `'\0``? Is it the same for strings?


Exception as e


doesnt this make double timestamps in journal unless you modify log pkg options?


Okay I will test all this tomorrow...

I still have two major problems : https://github.com/Mottie/tablesorter/issues/906

Issue 4 and 2.

Thanks.


Allen, I'm not seeing your loop here?


Looks like this is missing a comma creating invalid JSON.


This broke backwards compatibility. While I welcome the change per se, it's a dangerous one. You're promoting the composer dependency with ``1.*`` on the landing page.


fix logic.


Ohhh so something like this,

_contentIndexProvider.Query(map, sort) which returns the index, and then pass that to reduce?

removing the reduce from the IndexProvider? but leaving it at the Manager level?


Thanks, much clearer!


@glawrence Yep, it's a very, very good idea.

For the translation side of things, there's a utility that comes with Qt called "Linguist".  That's what people commonly use, and it should do most of the grunt work.

Side note - I don't actually know how to use it as I only know English.  @pinotree might have some pointers though. :smile:


@hlindberg would a hiera.yaml.example be sufficient in conjunction with this?


Not sure why you are referring the method name here?


This completes issue #82.


this can be moved to a finally block.


Or just use array_map instead of array_walk :P


Why not have the Handler itself self-describe?


My fault for trusting shellcheck too much


This looks good but should be moved after the flood control prevention code (directly beneath it here). Flood control should help mitigate dictionary attacks to determine legitimate user names.


Can you escape this character out so the file is still ASCII?


This is probably a leftover from other code, but the reference isn't required.


Wrong filename


Filename


How would I do that? By asking devteam nicely :) https://botbot.me/freenode/galaxyproject/2015-05-19/?msg=39619219&page=1


this is how it's done with css, so I was right, css issue not TS

http://jsfiddle.net/856bzzeL/302/  That gives you wider inputs.


Thank you. This was driving me nuts.


Maybe use and CONFIG['MOZ_WIDGET_TOOLKIT'] != 'qt'? This should at least keep android and desktop firefox builds functional.


ClangModernize (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


OK, maybe we should update to the latest version then (~1.9.2), since we'll want to test everything on the new version anyway.


I think the "block" part of the function name should be removed.


(^(OPTIONS|NOTIFY)|CSeq: (\d) (OPTIONS|NOTIFY))

With mobile regards,
Alexandr
On May 19, 2015 23:33, "jazzl0ver" <notifications@github.com> wrote:

> Thank you, it works better now. Though it still shows replies (SIP 200 OK)
> to OPTIONS packet. Is it possible to filter out OPTIONS/NOTIFY transactions
> completely?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sipcapture/sipgrep/commit/608c72594335ac820a99ff613eb282811e2f9529#commitcomment-11271818>
> .
>


What is the goal for these changes? How does it relate to priority?

> you are very likely to get WRONGTYPE exceptions if you drop this commit into production directly.

Not very likely, I'm sure *every user* will get this exception.


yes, that would work, it would not clash with anything. We could even have one that is more sane than the default/default one.


This condition could be changed to `if (!empty($form_state['account_found'])) {` to prevent PHP notices.


The internal vs. external distinction seems a little cumbersome the way it's coded. Would we be losing any real flexibility by simply allowing managers to check off "Exclude this block from the public interface" or something similar?


This code may be useful to contribute to the dhcp library if you have time to do so.


Are these in the right order?

I'd assume that we would want to check for the existence of 'ido-completing-read before checking ido-mode (which might not exist).

(That said, I'm not an elisp expert, so I might be wrong here?)


Looks like this <properties> tag is not in the correct location: https://travis-ci.org/codice/ddf-parent/jobs/63249455


Actually if the "hide element until rendered" works well, there's no reason to use invisible UTF.  Since they aren't shown, we could just as well go back to MATH/MATH_BLOCK tags


BTW, @robertmesserle, this does **not** fix the problem (I am afraid I kind of mislead you; I seem to be doing this a lot to people lately).

The problem _could_ be caused by an effective `$element.html($element.text())`, but it's not :D

The real problem comes from `text = $interpolate($element.whatever())($scope),`. Basically, since `$element` most probably contains some interpolated text, `text` comes from some property's value on `$scope`. Thus, it has not passed through any "filtering" (either by Angular or the browser itself) and can be anything (including `<script>...`).

--
So, by using `$element.html(text)`, you are "light-heartedly" putting an arbitrary string from `$scope` directly as the element's HTML. So, you should first make the original `text` safe (i.e. encode HTML entities) and then insert `<span class="md-highlight">...</span>` and pass it to `$element.html()`.

A quick fix that comes into mind would be:

```js
function MdHighlightCtrl ($scope, $element, $interpolate) {
  var term = $element.attr('md-highlight-text'),
        unsafeText = $interpolate($element.text())($scope),
        safeText = $element.text(unsafeText).html(),
        flags = $element.attr('md-highlight-flags') || '',
        watcher = $scope.$watch(term, function (term) {
          var regex = getRegExp(term, flags),
          html = safeText.replace(regex, '<span class="highlight">$&</span>');
          $element.html(html);
       });
  $element.on('$destroy', function () { watcher(); });

  function sanitize (term) {...}

  function getRegExp (text, flags) {...}
}
```

(I wouldn't be surprised if there was a better solution though :wink:)


In #318 added all necessary files for translation.
Just open src/translation/sqlb_pt_BR.ts in Linguist and make translation.
http://doc.qt.io/qt-5/linguist-translators.html


I'm thinking of this one specifically: https://github.com/puppetlabs/hiera/blob/f288efd359c29b955afd701023f7c6762376bfab/ext/hiera.yaml

Then a user could drop the example suffix and start from a base config. T


@bion what would be a good difference threshold? how many figures does your system round floats to?


I don't think array_map would work, the initial reason to use array_walk_recursive was to handle scenarios where people embed queries in array properties or other nested structures.


See https://github.com/rurseekatze/OpenRailwayMap/pull/200.


Mike was here. ;-)


The validation should be done in the frontend. The second email should not be passed into the backend at all.


Why was this one changed to null?


Make sure that you upload the new front-page.php file.


Este serviço está mapeado por meio da annotation ```@Service```.

```java
@Service
public class StudentService extends AbstractCrudService<Student> {
   ....
```

Eu removi a keyword ```abstract``` pois outro objeto (```StudentFacade```), precisava de uma instancia de ```StudentService```.
Isso acontece pois a classe ```StudentFacade``` tem no seu construtor uma annotation ```@Autowired``` comp abaixo.

```java
public class StudentFacade extends AbstractCrudFacade<Student> {

	@Autowired
	public StudentFacade(StudentService studentService) {
		super(studentService);
	}
   ....
```

Toda vez q você tiver uma classe, que ao ser instanciada (StudentFacade), possuir por dependência um bean (StudentService) que não existe no container, como no cenário acima, você vai se deparar com uma mensagem de erro. A linha de raciocínio é mais ou menos está o/

Qlqer coisa só perguntar :)


> Just that in the former case we are talking about some minor additional typing (Nullable!) and in the latter case about a bug that may be hard to find due to its rarity.

That's a supposition. It's more likely that someone that don't get the expected header back will check what the returned value is. I'll also make sure to mention it in the documentation.
That being said... It can be useful to have this exposed on the interface. Would you be okay if I introduce `Optional` in `vibe.web.common` ? Pretty much the same thing as `Nullable` but with a proper name ?


Thanks.


I am using Corelib helper class static method for closing inputstream.


I can move to finally block, but the Input stream is initialized within the try block. If I move Input stream initialization outside try block,  need to add throws clause to the method.


what is thjis


Thanks man!


HAUHAHAUHAUAHUAUAUAHAHUHAHAUHAUAHUAHUA

Epic FAIL!


Awesome job man, everything looks great. Its hard to put any comments up there. I love that your accounting for errors in user input, although the computer should technically always give you one of the three (although its not taxing on the system at all to do make sure). Other than that, the only thing I can give advice on is the indentation on the code. It makes it a lot harder to read when the code isn't indented and the brackets are not un-indented  (is that a word?). Great job!


 Display a PDF in a scrollable window

This depends on wxPython as the display manager.
It has been tested under Python 2.7.9 on a Win7.
Functionality is quite barebones:
* At program start, an (ugly) empty page is show (better would be page 1 of document)
* filename is taken from sys.argv[1] - better would be a file select dialog

The rendering speed, however, can be fully experienced: amazing!

Further optimization options for a more "productive" case:
* copy each page already rendered in a PNG temporary file and let the dialog manager (re-) display this picture - instead of re-rendering,when the user visits the page again. Could be a gain on weak processor machines.
* prevent any processing, when the user requests the same page repeatedly (e.g. "prev" button while already showing page 1).

Final remark:
Occasionally, with some pages in some files, an empty page shows up, though it obviously has been correctly rendered. I'll keep looking into that.


close #40


Ah, here it is. Added a call to (boundp 'ido-mode) instead, since it's theoretically possible that ido-mode doesn't exist and ido-completing-read does.


@jjallaire we might want to backport this -- it fixes and issue where the cursor becomes invisible when within an R Markdown chunk when using the `ambiance` theme.


The executable's name has also changed (to `tidy5`). I guess you invoke `tidy` internally, which I think needs to be changed.


That endpoint isn't supported as far as I can tell:
```
error:
type: "invalid_request_error"
message: "Unrecognized request URL (GET: /v1/application_fees/fee_XXXXXX/refund). Please see https://stripe.com/docs or we can help at https://support.stripe.com/."
```

I'll can submit a PR, we separated it into two methods in our own fork: https://github.com/getbread/stripe-go/pull/7/files


This would be best. I think I've already started it the right way. Checkout my branch of you want to.

Still waiting for the wiki article to check if I did it correctly.

Will check that tool ASAP.


Small syntax error—for both "if" and "elsif", there should typically be a condition that it's checking to see if it should execute that code block. Possibly you meant "else" here? Else is the catch-all, where you don't have to specify a condition since anything that didn't meet the earlier conditions will end up there. It still works, but else would be the better way to structure this.


You can refer the method directly like this StreamUtils.closeStreamSilently, Only classes/types should be there in the import.


Why write an error every time we create a cave? For the bright red color?


Okay, I logged a bug to consider backporting (I certainly wouldn't do this
now but perhaps as part of a future patch release).

On Tue, May 19, 2015 at 6:25 PM, Kevin Ushey <notifications@github.com>
wrote:

> @jjallaire <https://github.com/jjallaire> we might want to backport this
> -- it fixes and issue where the cursor becomes invisible when within an R
> Markdown chunk when using the ambiance theme.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstudio/rstudio/commit/63772f16bbc6008c1934ba9391c84f76ed65f532#commitcomment-11272754>
> .
>


@robertmesserle, POC that the proposed fix above fixes the issue: http://codepen.io/ExpertSystem/pen/KpMLYv?editors=001

(If you remove the overwriting `MdHighlightCtrl`, you'll noticed we get pwned.)


Nice tests!


Haha, oh. That was meant to be a debugging thing. I can change that to a better error message.


Hm, using pointers for output parameters is in keeping with the existing Google style. I'd rather leave it unless we drop the use of output parameters entirely. Hm...


oops.  Thanks.


Yeah I think that makes sense. I'll gladly take a PR for that, thanks!


A classe StudentService, também depende de objetos, para acessar a camada de acesso a dados. Como isto ainda não está configurado, eu comentei a anotação ```@Inject``` e removi o argumento StudentRepository, chamando o construtor do supertipo com um argumento ```nulll```.

Qdo configurar o **Spring-Data**, altere aqui, senão, ao efetuar chamadas a este objeto, você receberá ```NullPointerException```por causa do argumento ```null```.


What is this other command???  This is not something that should be left in a commit.


Probably better to just panic here since Register seems to only be called during Init().


You could just end with `.run()`.  This last `.then()` is unnecessary because you call `.then()` in the controller.


 Display a PDF in a scrollable window

This depends on wxPython as the display manager.
It has been tested under Python 2.7.9 on a Win7.
Functionality is quite barebones:
* At program start, an (ugly) empty page is show (better would be page 1 of document)
* filename is taken from sys.argv[1] - better would be a file select dialog

The rendering speed, however, can be fully experienced: amazing!

Further optimization options for a more "productive" case:
* copy each page already rendered in a PNG temporary file and let the dialog manager (re-) display this picture - instead of re-rendering,when the user visits the page again. Could be a gain on weak processor machines.
* prevent any processing, when the user requests the same page repeatedly (e.g. "prev" button while already showing page 1).

Final remark:
Occasionally, with some pages in some files, an empty page shows up, though it obviously has been correctly rendered. I'll keep looking into that.


If the `this.state.type === 'fundraiser'` then you are setting state twice. No bueno!


Isn't it wrong to have a multi-valued `motor_vehicle` key?
Per http://wiki.openstreetmap.org/wiki/Key:access `motor_vehicle` means any motorized vehicle.

Taking a look at http://taginfo.openstreetmap.org/keys/motor_vehicle#values I see some `motor_vehicle=agricultural;forestry` for example, but from what I see, they actually should be split into `agricultural=yes` + `motor_vehicle=forestry` (with possibles `some_other_vehicles=no`)

The same for `motor_vehicle=agricultural;destination` → `motor_vehicle=destination` + `agricultural=yes` (with possibles `some_other_vehicles=no` too)

Or I am misunderstanding something?


The idea here is to return move if it does not have a value, and getInput() if it does. getInput() is a function (in a variable) and move is a variable. To return the getInput() function or move, you can't have quotes around them.Otherwise, your returning a string with the name of the function or variable in it.

Returning the function getInput() is done because if move does not have anything in it, the getInput() function will prompt the user to enter in their choice. Its a measure to make sure we have the input.

Using an if statement, we could do it like this:
``` javascript
  if ( move ) {
    return move;
  } else {
    return getInput()
  }
```
 You had the basic idea, you just need ti fix up its implementation.


Good find. However I am not sure how we would get the bash script to
dynamically work unless we build it in python then ask for sudo privileges
or root to install it
On 20/05/2015 9:26 am, "Rob van der Linde" <notifications@github.com> wrote:

> .. actually, in this case connection['dbms'].startswith('postgres') is
> enough, it covers both cases
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/robvdl/pyramidcms/commit/b46475bd2df85e01f6a20814ed84d4975dd5e114#commitcomment-11271693>
> .
>


Why do you need to move the initialization outside the try block? You just have move the closeStreamSilently(in) to finally block.


The above comment applies here above, except randomPlay() instead of getInput().


Hello Thomas,

How are you?

I am researching the mws as my capstone project.

I have some questions, do you know how to update the product price through
mws api?

Also I am trying to php curl to simulate login in amazon, but not
successful, do you have any experience about this?

Thanks,
Joseph

On Fri, Apr 17, 2015 at 1:40 PM, Thomas Hernandez <notifications@github.com>
wrote:

> This is the kind of SOAP request that the library deals with behind the
> scenes. Specifically, this one is requesting a "
> *GET_MERCHANT_LISTINGS_DATA*" report.
>
> I am not very familiar with all of the reports, but it may be possible to
> find a report that does what you're looking for.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/boostsup/phpAmazonMWS/commit/2d7627ab25cabcd5c7ae5a6ddd2a2b684ff2c42b#commitcomment-10783900>
> .
>

--
God bless you!
Joseph


This looks great. Perfect use of the 'and' operator!


Yes it's the same npm uses. Makes of lot of comparisons easier.


don't leave `console.log` statements in the code.


See https://github.com/Preston-Crary/liferay-portal/blob/master/portal-service/src/com/liferay/portal/service/ServiceContext.java#L521.  We may not need to create a date, if we do and pass null we'll create only if needed.


if you aren't extending the object, you can just return `this.getStoreState()`


Looks good.


Wow....I'm sorry, I created a pull request but GitHub said that it failed and then it commited automatically....shall I revert it?


I should have probably made a separate commit for this though...


play_wav_file just felt very QT specific which is why I put it in qt.rb but I assume you moved to top_level for access?


We should have a user type here (manager/member) to easily handle permissions/functionality


this is only an inofficial mirror. how did you even find that?


Hey Mike, My sidebar is showing now: https://github.com/madstash/all41.

Also, just wanted to let you know that I had a family emergency, which is
why I wasn't in class yesterday and won't be there tomorrow.

My dad has been in the hospital since Sunday night, so I drove down to
Northern California to be here in case anything happens. He seems to be
doing much better, but hasn't been released by the hospital as of yet.

Thank god for video lectures... it's a lifesaver right now.

~Maddy

On Tue, May 19, 2015 at 2:58 PM, Mike Sinkula <notifications@github.com>
wrote:

> I don't see a sidebar.php file?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/madstash/all41/commit/c03dd01cf2ec306c27b9377905cea40ebb642745#commitcomment-11272313>
> .
>


Thanks for updating all these. This was the whole reason I created the data_path method in the first place!


The idea behind a IContentStore, is that you don't know if there is an ORM - it could just be a bunch of stored procs.

We could do NoTracking, though I like how the current model doesnt require you to call update on an entity, though... not sure how that model will work if you have multiple content stores.


This is consistent with the way other RPC calls do it. But I agree that it makes more sense your way.


Much better name


This definitely ups the challenge of this project, good hustle :+1:


EPIC EPIC EPIC!!!


The current behavior is consistent with other commands. I agree that your way would make more sense. But I don't want one RPC command to provide different error returns than other commands that also have you specify a ledger and account.


If I move closeStreamSilently(in) to finally block, I was getting variable "in" not have been initialized error.


rax retry tests


@gabrielgarciagava :D


I'd thought that was it ;) I assumed it was just so that it was easy to see. You can leave it in there (it could be helpful in the future) but you should probably change it to be a bit more informative and use an info prompt instead.


Nice catch!


Moved to top_level so that it would always be available from script.


[TODO] :54にcontinue追加


@mafagafogigante sqlb_br.ts will be Breton - FRANCE (br_FR) locale.
Right locale is 'pt_BR', and name for file sqlb_pt_BR.ts
See change log of my pull request


Its a great start. Your outputting appropriate responses based on choice. A loft of this code, however, you have already written above. To get who wins, you could use the getWinner function you wrote above, passing it the computers choice and the players choice. It would looke something like this
``` javascript
  var playerMove = getPlayerMove();
  var computerMove() = getComputerMove();
  var winner = getWinner(playerMove, computerMove();
```
Then you can test who the winner is (using if statements) and update either playerWins or computerWins.


ok, that helps! Confirming fix works for me, thanks


This is already in master and changed in your later commit.


Minor nitpick: please add `override` after `const`


What did you do to layout?


Looks good ;)


@sam-github the delay before connecting the control channel is what I had to add to get this working on my Ubuntu VM. It seems the connect can succeed but result in a totally useless socket, so I'm thinking there's some docker/netfilter magic screwing things up with the port forwarding.


Can you add a comment here to show where the `22` comes from?


looks great, thank you @jwpeterson

a


You should make `args` into a global named `ARGS` because it's a unique consequence of global `sys.argv` which you will never change.  It makes all the rest of the code easy.


Where does `29` come from?


Same as above


When the renderer disconnects for whatever unexpected reason, we would like to reconnect. This did not work because the Client websocket can only by used once.


What is `3`?


Same as above, where does the `6` come from?


The `global` statement is nearly always a code smell...


Thanks! I :cupid: that photo - I love the emoji cheat sheet.


Kyle and Adam are you alright?


None of this should exist!  :-D

This value should be the default value for `ARGS.ripple_home` and you should just use that variable, not this global.


Looks good. :shipit:


`2` should be the default for `args.num_validators`.


while i change that, should I add a password field?


`'test_output'` should be the default for `ARGS.out`.


Ideally, this check would be moved up to happen immediately after the user inputs their operation, rather than having them complete the entire calculator program before they find out the operation they entered at the beginning is invalid. One way to do that might be having an array containing the acceptable operator terms and checking to see if the user's input is present.


Paul mr


This did not do a very good job at tracking changes. I did not change all this code only removed default serialization, and updated message boxes to be plain/info/warning depending on the nature of their implementation.


Just pointing out the algorithmic change: previously every peer with the range had an equal probability of being selected. Now, each peer is assigned a pseudo-random score, and the peer with the highest score is selected.


These two variables should just vanish, being replaced by `ARGS.quiet` and `ARGS.verbose`.

(And what's the difference between "not quiet" and "verbose"?  :-))


I agree but this is how the lru tells us


I think so, but there seems to be differing opinions on whether or not it's really necessary. We'll discuss it as a team after class


OK, big thanks. Will look into this as soon as I get home.


Why you dont use display suit extras to do this? Is not a little hardcoded?


they are all related to SCPMessages


If you're saving one string concatenation, why not all of them?

`{}/validator_{}/rippled.cfg'.format(config_root, i)`


I was waiting on a solid answer on what we were doing with that. I'll change it right away after we've decided collectively


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15142/testReport/) for this commit**


jjj


Why no comment?


This implicitly calls `+[MGLMapboxEvents sharedManager]`, so you no longer need the line above (but make sure the comments continue to point out the important side effect).


thanks


Close #552 #546 #545 #542 #523 Fixes.


Ahh, thx!


Don't use `xrange()` unless you n is going to be quite large.  It's going away in Python 3 (`range()` will return an iterator) and for this sort of thing it's too tiny an optimization!


spaces around operators!


Does this enforce unique pairings? (A member can't be in the same member list twice). Same question is applicable to some other tables


@supermarin no, nothing happened with CMD+Shift+9 either. but @kattrali, I added that UUID to the Info.plist and restarted Xcode and now it works :) Thanks!


Bring this up to the very top as a named constant please - like `DELAY_WHILE_PROCESS_STARTS_UP` or some such.


It’s not so much a user count (because this app only knows about one user at a time) as it is a turn of a turnstile.


Could some please revert to include the `; echo ok`? This is making the container restart forever.

> 23:51 < treed> ppires: Yes, fixed by adding "&& echo ok" to the liveness probe
> 23:51 < treed> there's a change coming in 0.18 apparently, and the dns stuff was updated for it prematurely
>23:53 < yjhong> ppires: previously, liveness check relied on the output of the command to be "ok". Now it checks the exit code.
>23:54 < treed> yjhong: Except 0.17 doesn't check the exit code.
>23:54 < treed> The version that does isn't out yet. :-/


## 9599f643b974b1afc04e44799e7a88bf78f55a1e


Using example from:
https://developer.mozilla.org/en-US/docs/Web/API/DeviceStorage/enumerate


I'm still using Emacs 24.3 on one of my machines and 24.3 doesn't have buffer-stale--default-function defined.  Well...  Can't you please make this work with 24.3 too?


Makes sense.


1. Use `'` to be consistent.
2. Is this really right?  If you want to use NuDB and you aren't on Windows, what do you do?
3. Accen-tu-ate the pos-it-ive!  :-D  `node_db_type = 'NuDB' if is_windows() else 'RocksDB'
4. Why not `node_db_filename = node_db_type.lower()`?


BRAZIL RLZ HUEHEHUEEEU


You repeat exactly this code above...


you'll need to do an update scala/scala here as well, the jobs run in isolation


Just an FYI:

Traceback (most recent call last):
  File "/usr/lib64/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib64/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python2.7/site-packages/salt/cloud/__init__.py", line 1250, in create
    client = salt.client.get_local_client(mopts=self.opts)
  File "/usr/lib/python2.7/site-packages/salt/client/__init__.py", line 90, in get_local_client
    return LocalClient(mopts=opts, skip_perm_errors=skip_perm_errors)
  File "/usr/lib/python2.7/site-packages/salt/client/__init__.py", line 137, in __init__
    self.functions = salt.loader.minion_mods(self.opts)
  File "/usr/lib/python2.7/site-packages/salt/loader.py", line 167, in minion_mods
    funcs = raw_mod(opts, providers[mod], ret.items())
  File "/usr/lib/python2.7/site-packages/salt/loader.py", line 197, in raw_mod
    if name not in loader.file_mapping:
TypeError: unhashable type: 'dict'


ah wait nevermind, you don't need scala/scala of course


Not quite sure what's going on, perhaps introducing a few local variables would document what 535  is?


you shouldn't be mix-and-matchin code from a release with code from head.  Or am I misunderstanding?


How can I send coins to pay-to-script-hash addresses using pycoin? I had been searching and can't find an example.


OpenCL changes are probably copyrightable, but that code has been deleted.
Audio code is whitespace changes only.


btw, why is scala/scala needed here? note that it will be checked out into the scala/ subdir, with lampepfl/dotty being in the CWD


Not sure how to do that within SQL, unless we do it within code itself when inserting into the database? If anyone has any ideas please share


See next commit. Desugar&parser&scanner are tested on whole scala/scala/src


To DRY your code as much as possible, watch for places where it feels like you're essentially retyping things you've already written. You used a really similar if/else to convert first_num to a float or integer above. I would recommend deleting the if/else above, and replacing this second if/else with this:
if num_type == "float"
       first_num = first_num.to_f
	second_num = second_num.to_f
else
        first_num = first_num.to_i
	second_num = second_num.to_i
end


1. You mostly use `'` but occasionally use `"` - stick with the first.
2. `/` isn't good for cross-platform use, use `os.path.join`
3. spaces around operators please!


Didn't work for me. If this is finding the "partition point" how could this scheme handle both strings that start with whitespace and strings that start without? (not sure if that's related to the error though)


Not Copyrightable


Not copyrightable.


I see, thanks.


A reference to the PR, #1673, would be more helpful in the commit message than repeating the issue ID.


This is cool. How would you describe the size of each object, though?


No, you're probably not. I probably screwed it because I trusted the time-window between 0.17.0 being released and that commit hitting the tree.


OK, accepted.


A while loop is definitely what you need to check the players and the computers wins, so great job there. While going through a while loop, youll want to make sure that there is some piece of code that is updating the conditions (in this case the amount of wins for the computer or player), otherwise you'll have a loop that is going on forever. The comment above had code to ask for user input, then test the user input, and finally update who won. This would be a great place to put that code, so that the program keeps looping through the while loop and playing the game until either one of those conditions would go false.

Moving the code below, the if/else statment about who won, would need to go below the while loop. That way, when the while loop ends (one of the players gets to 5 wins), the program outputs who won.


`n`?  (skim back...)  ah, what I'd call `ARGS.num_validators`.

Is `n == 0` actually possible?  If not, I'd eliminate it earlier in `parse_args`.

Is `n < 0`?  My guess is not, so you can check for that in `parse_args` and here, simply say `if n`.


Formatting/spelling changes only. Not Copyrightable


`bak`?  We can use that extra "c".  :-D


Thank you!


Strings that don't start with whitespace are strings that start with zero-sized whitespace. I'll test and update the comment above.


SQLite supports multiple column Primary keys, which SHOULD force the column pair to be unique as opposed to each column having individual unique values. Works that way in both MySQL and MS SQL. I expect this to work no differently


Don't think Github Pages does anything with .htaccess, but it doesn't hurt to have around either


only changes to ReportView where to remove warnings of unused imports


@Rashed97 So let's see if I got it, although we don't have the v30 flashable firmware update for D802 yet it still can boot properly using KK bootloader + KK baseband with JB aboot? Or I'm wrong and the stacks needed must be from v30? My D801 tester got it working :confused:


Let's not be explicitly able-ist: `assertTimestampIsReasonable` or similar.


Yeah I wasn't sure how Github handles .manifest files, but it seems to work anyway.


Almost: Query returns an Index object, that can then have a Reduce method.

One more thing: oftentimes, reducing is one too many concepts, and you just want a paginated view of the index, so I'd also put a method on there, besides Reduce, that gives you a slice of the index.


Patch from xsacha who we have permission from.


Oops, this wasn't intentional. This morning I was working on [writing tests](https://github.com/chrisvogt/cakephp-wysiwyg/tree/write-tests) for this project and merged the readme into my `master` branch forgetting that there was still an open PR pointing to that branch.

I'm going to keep working on writing these tests today, and will correct this (above) when I submit a PR with the test cases.


Where do these ID numbers come from?


Gah!  I knew I was going to see this delegate again.


i interpret the following block to imply that "the employee review due status _does not become overdue_ after due date". i assume the logic for expiration is handled below.

the behavior of this method would be clearer if the multiple if/return blocks were combined somehow. looking at the code gives little assurance that all cases are handled appropriately.

i looked at the javadoc to better understand this method but the return value is unspecified.


It's a great start, and a lot of core concepts are there. You effectively used if/else statements so that the program knows what to do when it reaches that code. You also identified that a while loop was appropriate to so that it would loop until one of the players got to 5 wins. The problem I noticed is putting all of the concepts together into a working program. I would focus on refactoring this code which some of my suggestions and playing around with it until you understand the code I'm suggesting you change around. One of the most difficult parts of learning programming for someone who has never done it before is thinking in a very computer-esque way. Try to follow your program from start to finish to try to understand what it is doing. I guarantee this is one of the hardest humps to get over, so keep pushing!


Won't all those characters cause more whitespace?


I'm not following how this safely handles npos.


yes, but it standardizes the output. We should fix the log format as well.


the above line is indented inconsistently with the rest of this method


$.fancybox.showLoading() does't work, now !


Still not clear what this is...?


Thanks, we'll need to add it then!


This file exists already


Use `items()`.  Same comment as `xrange()` - it's going away in Python 3, and the efficiency gain is tiny.


Works great, thanks for the fix.


This file already exists


Here's the place to inject documentation of this interface.


I thought so too and then I got this error when trying to use multiple primary keys in one table:

[SQLITE_ERROR] SQL error or missing database (table "project" has more than one primary key)


First and last if use a valid NPC ID, since we have that as a constant, as such it needs to be `>=`. Third if uses an arbitrary `400` value, so I left it alone until we clean up the holes that the npc_viewdb currently has (which wasn't part of this commit). This commit only fixes an issue with the MAX_NPC_CLASS2_START constant being off by one (there is no NPC ID 10000 as far as I'm aware, and a '_START' constant should usually refer to the first entry, not to whatever comes before


Referenciando o Caso de Uso #9


Woo, issue resolved!


Nevermind, fixed it ;)


This seems dodgy here.  Why are you attaching attributes to a _function_?


What's the difference between the input and the output timestamp?


Referenciando Caso de Uso #9


Hail hydra!


a role should always have an agent, but a role isn't always part of a relationship. i'm not sure why the pair's agent would be null.


This flow of instructions will not actually delete grade from gradebook when deleting selected reservation requests.
First, delete_records() in lines 98 and 99 are called too early - because get_field() in line 101 will not fetch deleted record.
Second, and more importantly, grade should be set to -1 before calling reservation_update_grades() - only then grade is removed from gradebook.

So instead of:
```
                                $request = $DB->get_record('reservation_request', array('id' => $requestid));
                                $requestnote = $DB->get_record('reservation_note', array('request' => $requestid));
                                $requestnote = $requestnote?$requestnode:new stdClass();
                                $DB->delete_records('reservation_request', array('id' => $requestid));  // <-- should be called after reservation_update_grades()
                                $DB->delete_records('reservation_note', array('request' => $requestid));  // <-- should be called after reservation_update_grades()

                                $userid = $DB->get_field('reservation_request', 'userid', array('id' => $requestid));
                                reservation_update_grades($reservation, $userid);
```

It should be:
```
                                $request = $DB->get_record('reservation_request', array('id' => $requestid));
                                $requestnote = $DB->get_record('reservation_note', array('request' => $requestid));
                                $requestnote = $requestnote?$requestnode:new stdClass();

                                $DB->set_field('reservation_request', 'grade', -1, array('id' => $requestid));
                                $userid = $DB->get_field('reservation_request', 'userid', array('id' => $requestid));
                                reservation_update_grades($reservation, $userid);

                                $DB->delete_records('reservation_request', array('id' => $requestid));
                                $DB->delete_records('reservation_note', array('request' => $requestid));
```

The proposed version has been tested and works, you've got my word :)


Just for your edification, you can guard an `if let` to combine these two lines.  I wouldn't do so here, but worth using when appropriate.


Yes they would.  Ok then I guess we should still use the invisible chars and escape them.

Nathan

On Tue, May 19, 2015 at 4:11 PM -0700, "Philip Schatz" <notifications@github.com> wrote:

Won't all those characters cause more whitespace?

—
Reply to this email directly or view it on GitHub.


There is copyrightable code here in the dx11 backend, but it no-longer exists in master, replaced by texture conversion shaders.


**Overall, this looks totally solid!** :)

### PROJECT LEARNING GOALS

| Rating | Content           | Description
|--------|-------------------|-----------------------------------------------------------
|     1   | Variables                | Variables names are logical, clear, and in snake case. Variables are not needlessly assigned or reassigned ([variable examples](#variables)).
|     1   | Loops                    | While loops control the flow of the code, keeping the user on track, and continuing the program until an appropriate end point.
|    1    | Data Types               | Hashes, arrays, strings, symbols, numbers, and booleans used appropriately. ([data type examples](#data-types))
|    1    | Conditionals & Operators | Logical and mathematical operators guide program flow efficiently and properly deal with edge cases (Gold) ([operator/conditional examples](#conditionals--operators)).


sorry uh i just meant that one line? the body of the class should be indented one level more than the line with the `class` keyword...


Don't want this


Nothing Copyrightable here.


Not Copyrightable


Why wouldn't this be `LocalPlace` all the time?  Is it worth separating the local and remote cases?  (This may be clear later.)


FYI the "remember" API is pretty nice for avoiding some of the extra cache-miss logic:

```php
$instagrams = Cache::remember('instagrams', function() use ($url) {
  return json_decode(file_get_contents($url), true);
});
```


Are backticks causing problems only with delete statements ?


Great. I was just looking into it and you may want to add NOT NULL to your primary keys while you're at it. I don't think it's strictly necessary but it's not enforced by SQLite and is common practice. Your call


And now you're incrementing members of the very function being called!

Just have a simple class and return that!  Or even a list... :-)

---

Overall, I hate this idea that all our IP addresses are scattered seemingly random, and when we make a new instance we increment each IP number individually.

Not your fault, but there's everything wrong with it.

1. It makes updating your config to run on a new set of ports a slightly tricky task that it's possible to fail on.  I have failed on this more than once, and I've seen this happen many times on the team.
2. It's usually much easier to open a range of IP ports on your router than a collection of random ports.

We should do what every other application does, and have a base port number, and everything else offset from that, so you only have to change one number.


Code cleanup only


This needs to be changed in `example.tt` if we want it to stick.


Visits are unordered?  I feel like this will produce or mask at least one bug.


匿名类型本来就可以吧？


Exactly. I was getting that error because I used PRIMARY KEY on each field. Instead I did PRIMARY KEY (field1, field2) and added NOT NULL to each field separately


I avoided using `npm start` because I wanted to control the `NODE_ENV` from the context of our container and not which `npm` script we used to start the application. So we default to `development` and for a production deployment we can just override that with `-e`

Like:  `docker run -d -e "NODE_ENV=production" -e "GOOGLE_PLACES_API_KEY=secretsquirrel" codeforhuntsville/frontier:latest`

I also think it's cleaner to explicitly use an `ENTRYPOINT` in our Dockerfile since you'd need to have a greater understand of how Docker works to just glance at this file .. and then know how, what, and why it's executing `CMD` from that base image.

Another cool thing about `ENTRYPOINT` is at run-time the `CMD` you pass in will be turned into args passed to our `ENTRYPOINT` .. We do some pretty cool things with this + `commander`

Like: `docker run -d -e "NODE_ENV=production" -e "GOOGLE_PLACES_API_KEY=secretsquirrel" codeforhuntsville/frontier:latest --logging-level=all --dont-resolve --foo --bar`

Doing that with `npm start` is a `PITA`

Does this make sense? Sorry if this is too verbose.


I'll update this.


I meant version ;-; Its early....


But a user doesn't actually run a new subprocess - Python runs in your process.   None of the subprocess module code is used if the user just runs the Manifest.py.

----

So this is all one test?!  So what's the point of the command line arguments?  Nearly all the time, people will just run all the tests and not get to set any command line arguments specific to any one...


StringFromFormat has be re-written.
DX9 backend has been removed.


Yeah, no.


This is incorrect -- never remove `${shlibs:Depends}` from Arch:any binary packages although you can correct Architecture as well (where needed).


not copyrightable.


Dica: compare strings com `equals` ao invés de `==`


urg.  /me slaps side of head.  Yes, quite, I wasn't thinking.  _never mind!_


you don't need the static_cast


Could this test use mocks instead of persisting the expensive objects?

```ruby
it "should move a generic file from one work to another" do
  workA = double
  workB = double
  file1 = double
  expect(AddGenericFileToGenericWork).to receive(:call).with(workA, file1)
  expect(RemoveGenericFileFromGenericWork).to receive(:call).with(workB, file1)
  Hydra::Works::MoveGenericFileToGenericWork.call(workA, workB, file1)
end
```


Muito boa a tua implementação! Daria para fazer o método retornar o próprio map (sem converter para String), mas a lógica utilizada foi perfeita!


Muito bom Eshi!


if/else syntax is maybe not the best setup here for how you've currently designed it. It's a red flag when you write an if statement, but there's no code to execute when those conditions are met, as is the case here. Since what you're ultimately checking here (I believe) is whether the input is valid, and if not, run this while loop, perhaps change the if condition to just immediately check if it's invalid, rather than if it's valid. For instance:
if second_num.to_i.to_s != second_num || second_num.to_f.to_s != second_num
	while second_num.to_i.to_s != second_num
		puts "Looks like you didn't enter a number. Number, please!"
		second_num = $stdin.gets.chomp
	end
end


Done.


@SubJunk much nicer after @valib cleaned it up in f1378f7 :-).

Btw imo we should revert the 'extra logging' added in 73dedd0.


Hi! Thank you! ;) I did not know Odin, but I will read about. We are still working on mininet-wifi to provide new features and I am always grateful for questions/suggestions. :)


We never actually need the modified time of LocalPlace. And I'm killing RemotePlace — we'll just pass the timestamp straight in to `insertOrUpdatePlace` as we do with `markAsSynchronized`.


should be testing the return value of Init() and return nullptr in case of error. Playback will abort.


:joy: :joy: codewars feelings


These classes are really just around for `MockSyncableHistory`, which is much less important now.


I don't understand why you return some unmodified portion of an input.  `place.guid` is constant in this function; if you need to return anything, why not return `place` itself?


Nice try!


can you const a nsRefPtr?? the ref value will be increase/decreased during the lifetime of the RefPtr


@mafagafogigante, just fetch last update from our repository and edit 'src/translations/sqlb_pt_BR.ts' file in Linguist.


wrong algo was used. Here's a working one:

```
void SplitStringAlongWhitespace(const std::string& str, std::vector<std::string>& result) {
    for( auto it = str.begin(); it != str.end(); ) {
        auto first = std::find_if(it, str.end(), [](char c) {
            return kWhitespaceASCII.find(c) == std::string::npos;
        });
        auto last = std::find_if(first, str.end(), [](char c) {
            return kWhitespaceASCII.find(c) != std::string::npos;
        });
        if( first != last )
            result.push_back(std::string(first, last));

        it = last;
    }
}
```


Since this is so short, might as well keep structured and say:

    if f:
        v = f.split(':')

Is this even right?  Are two `;;` in a row legal (this code allows it)?  What about this sequence: `; ;` (the code as it is asserts on this...)


Did you mean to add this file? :)


I


It's fine. Was a little odd to see hex codes.


@thomassittig: Doing some cleanup here and noticed that this is a global. Should it be a global or is that an error?


$params->getDate() pulls in the ?d parameter from the URL query string. I think we can keep using this, unless you wanted to make this page completely dynamic.


@crscardellino @MaicoLeberle  Cristian, está joya el mecanismo de tests!. Pregunta: puedo abstraer el cuerpo del main en un procedimiento aparte, con un nombre que describa el tipo de test que queremos hacer, y así hacer con los demás test que queremos agregar?. Entonces, el main ahora pasaría a llamar a los procedimientos que encapsulan cada test. Por cierto, alguien está actualmente metiendo mano en node.h y test.cpp?. Aparte de agregar tests, quería definir nodos que faltan del ast, bajo el criterio de "un nodo para representar cada pieza de código que requiera de una definición particular del método codeGen".


`modified` is always set from the server clock, right?  (Which we assume is monotonic increasing.)


More idiomatic: `for line in open(log_file):`
It replaces these two lines with one.  The default mode for `open()` is well-known to be `'r'`.  And the file will be closed right after you finish the loop.


There're no restrictions on charset/length of contID or netName so you could theoretically have two different sets that concatenate to the same thing.


returning an empty TimeIntervals() will prevent it from working with MediaSource later. While it's fine for playing plain mp4, we need to have a proper TimeIntervals returned.


what the hell is canola?


Yeah, that looks sane.


Seems like you are passing -s twice here?


So this isn't really a "unit test" - or at least, it's not a Python unit test.

This is... a utility to test...?  How does this get run?


Thanks @vlj .It can be compiled okay now.


Overall this is solid Lila!


This code is customly done! Version 1.0!


If we ever see a record that fails to apply persistently, it will stop the synchronizer from making progress forever.  Right?  We should track making that not the case.


Version 1.0START


The MediaFormatReader won't call this as it's audio only. But a comment explaining it would be better.

Maybe I just should change MediaTrackDemuxer::SkipToNextRandomAccessPoint no be a pure virtual for those cases (audio-only)


Sorry 'bout that.  Should I do something more intelligent with it, since Xeno-3 isn't yet integrated?


out of curiosity, how come the jruby service examples follow a java-like folder structure?


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7312/testReport/) for this commit**


should this be checked in?


Yeah, I think so. Copied from MSBuild targets- I'll update it.


Nice word Madhura!


Why did the imports change, I don't see any code changes that correspond to this.


a function with override is implicitly virtual. There are new static analyzers rules that will soon choke on this.
You'll need to remove the virtual keyword


Adding in the win condition output in here certainly works. In general, its easier to maintain code when all of the functional parts are in one place. This is why functions and modularity are so important. You can easily write this, and the win condition output for the computer, right after the while loop is over. This would put all of the win condition stuff in the same place. This is more of a style though, so what you did was perfectly fine.


That makes more sense. :) Added in 4a6139d, only change is to stick with the current pattern of using a pointer for the out parameter.


No, that's not how you do it, and I don't want doorbells to have hitboxes, it doesn't make any sense.


So, because of the way github manages commits, I can't comment on some lines. I'll do that here:

line 24-26: This is good and definitely what we were looking for, but in the future you may want to think about special cases where the user makes an error. What happens if they capitalize 'ROCK' or if they enter a number? You may want to define what you are looking for and keep asking for input if the user doesn't give you a valid format.

line 32-62 (getWinner) : This looks great. The logic is sound and its very readable. There are other ways to do this as well. If you have one if/else statement (no else if) it could be helpful to use ternary operators. This is what they look like
``` javascript
  winner = computerMove === 'scissors' ? 'player' : 'computer';
```
This make look a bit weird, buts its a more compact way to do it. Some people do, however, use it way to much and their code becomes unreadable, so be careful. We'll discuss ternary operators in a future class. The only other things is that it is not recommended to not use brackets with if/else/else if statements. I know its less to write, but it makes code harder to read and harder to add to later.

line 70: Awesome job identifying and using the while loop correctly.

Great job! Most of my comments were on the style of code writing more than anything else. Keep pushing!


Could you mention the subtlety around the version handling (requiring the version to increment if the hash differs), which is driving the hashing scheme?


This signature seems a little off.  Is there a reason to provide `places` rather than get them from `storage`?


Not Copyrightable


I honestly don't know off the top of my head. To know that it it's basically doing the right thing you could give it a pretty big threshold though... like +- 1%


not Copyrightable.


The MediaDataDemuxer needs to be able to handle partial init segment. This is what MediaDataDemuxer::Init() is for ; check if it has enough data to proceed, and if not return WAITING_FOR_DATA.
It's fine for plain MP3, but integrated within MediaSource, the MediaResource is buffered based.

This needs to be handled here rather than in the MP3TrackDemuxer::Init()


Formatting only.


Yea, I'm not really sure why there using strict mode.


MediaTrackDemuxer is already ref-counted, you don't need this macro.


You improvised a bit here. But your code works and you used a while loop to detect user errors, which is awesome! Great job!


you don't need to override those two if you don't implement the feature. There are default implementations already


does something extend and then set this.project for the outer class?


Great idea to test for what move is, but not entirely necessary.


A hitbox is just the selectable area, not the solid part


is this no longer needed? if so, should we just remove the line?


this is something that ultimately, will have to be implemented in order to be usable in MediaSource.


It would be impossible to break without hitboxes :(


have you considered JAR_TASK as a constructor parameter instead of a static string? does the framework do the instantiating of this class and require a particular constructor signature? rhetorical questions mostly.


I'm having a bit of trouble keeping your timestamps straight.  This one is passed around and only used as the base case in a fold operation, as far as I can tell.  Can we cull it?


Yup, makes sense.


cool !

Using media::TimeUnit in place of int64_t for microseconds would be nicer. Trying to get away from non-strict type as it has caused several bugs in the past.


Logic looks great. One of the aspects of coding you'll start to battle is the ever raging battle between efficient writing (shortest possible thing to write and as compact as possible) and readability (how well and quickly someone can understand your intentions). These lines aren't unreadable, but there on the edge. This is more of a coding style, so take my comments how you want them, but stretching out these statements can help its readability.


Great job recognizing that the while statement was needed here and utilizing it correctly.


pythoner.cn???


date???


Should we try to preg_replace MyISAM to InnoDB ? just to make sure extensions that still specifies MyISAM will create InnoDB tables ?


Great job! Most of my comments were on coding style more than anything else. It's awesome that you thought about user input error's. Keep is strong and keep pushing!


is this the versions of gradle that the gradle test plugin will test against? definitely it makes sense to have more than one even if it seems not worth testing against just to be sure that the capability of testing across multiple gradle versions works in general?


This is not completely necessary as you can put this at the top of the loop. That way a user can see that the score is 0-0 right off the bat, and it is printed everytime the loop persists in running.


i am guessing you need to do your own custom string replacement and that is why using %% notation as a placeholder?


yay.


You should rebase, not merge master.


remove from source control?


Hello


tested and working


Pelo amor de Deus, `String.format`!


Suggest mentioning that changing the grouping for the web_console gem in Gemfile will fix this message too. That's how I fixed it for my Rails 5 repo.


Hello How are you?


It always raises exception beacause there is self inside locals().
Perhaps we can just delete this checking for now.


Great job recognizing and using the while loop correctly!


Referenciando #9


Referenciando Caso de Uso #9


I wonder if it will be better to pass player instead of goal_type.


Awesome that you put this in one place. This may be a small project, but getting that habit of putting something that you might use multiple places in one place in a variable so that its easy to change is a great idea.


Module is no active and I didn't want to activate it only for this.


just by the way ... this comment doesn't make much sense; I accidentally left it in from a previous version that had a ref_seq argument (which was the element to put new_seq after)


Are you thinking that we'd add a flag to the mirror store saying whether they are to be included in joins?  How would you distinguish "partially downloaded due to buffering" and "server has not yet seen a complete upload"?

I guess this is what we talked about for bookmarks, where we can eagerly recognize consistent subtrees and apply them.

What would be the benefit of two-stage application for history?  I suppose reducing stream processing marginally decreases the likelihood of a connection dropping.


In case we do not want this option to be customisable, but just to use start muted always as it was before by setting it in the config, should we just skip this commit?


This is interesting.  I still wonder how it was downing the server before.  Was it in cheerio.load()?


LGTM


Was this it?


tested and working


This is `(local = nil, mirror = nil)` and then `remote` arrives.  I imagine you'll flesh this out, but I'd like to see the other cases too: `(value, nil)`, `(nil, value)`, `(value, value)`.


Logic looks perfect. To clean up the code a bit without making it too unreadable, you could try using the ternary operator on the nests if statements. For example, on lines 70-74 you could write:
``` javascript
  winner = computerMove == "rock" ? 'player' : 'computer';
```
Ternary operators are great to make it look a bit cleaner, but overusing can be a problem so be careful.


Indeed! ;)


Starting to use Github with the basics.


Referenciando Casos de Uso #9 e #14


I see.  Thanks for the update!


Referenciando Caso de Uso #9


I think if Outfit and Joker are a Card, we need to pull attributes out of Card.

I was thinking of doing that already, throw them into mixins. Things like Goods optionally having bullet bonuses, influence, or control makes me want to do mixins.


Just curious, what's wrong with ENTRYPOINT?


"para" tem o mesmo sentido e geraria uma instrução menor


"para"


@Byron Thanks for your review. I will update my examples/docs to use `unwrap`.

Actually, `register_template_string` might throw some error when the template string is invalid. I just use `ok()` here in the example because I know the template is correct for sure. I agree that we need a solid example that shows error cases.

I will update the example later today.


"retorne" é bem mais simples


"Prepare para retornar em" poupa alguns milésimos de segundo :)


"mantenha à direita" poupa alguns milésimos de segundo :)


Fixed in v0.1.5 (already published on npm)


"excedendo a velocidade" pois quem excede, excede algum limite. redundância.


"Prepare para entrar na rotatória após" poupa alguns milésimos de segundo :)


Alright just curious as to if it was still around or not.


"Prepare para entrar na rotatória" poupa alguns milésimos de segundo :)


Yeah, I think my KPP regression test specifies CVmix_kpp_params_user for all the different cases... but POP uses CVmix_kpp_params_saved so params_user isn't present. Issue #14 will basically be "compute diffusivities based on the first step of a WSwPSBF test" and I'll make sure it uses the module parameters - that should avoid reintroducing this issue.


Este é um teste


Of course we can. But I'd prefer not to let mock object depend on external module.


Você habilitou o plugin `OsmAnd development` para verificar a pronuncia atual?
"para" fica estranho.


function


Sounds fine to me. In that case, feel free to remove package-noclean if you prefer. :)


@cheerfulstoic ruby has `nonzero?` already.


Sweet! Thank you!


The browser does not support `auto` value.


Obviously you should add ".gitignore" to your .gitignore


What if you leave it sudo-less and simply have people add it when needed. I feel that linux users know what they are doing (and when to use sudo) more than OS X users (like me)


sim, usei o plugin para testar. inclusive uso uma versão do tts que eu editei com essas alterações que sugeri aqui.

eu acho "em direção a" estranho :D. além de a instrução ficar muito comprida. sugeri o "para" porque mantém o sentido. eu, na verdade, na minha versão, uso o "na" (vire à direita na rua..."). porém, tenho ciência que o "na" não oferece concordância para todos os casos ("acesso", p.ex.), por isso sugeri o "para".


Probably not


Server should probably be changed to be passed in as a variable rather than hard-coded here.


Hay all,

How do I choose a serial port?  I have misplaced my brain.

Cheers


Agreed. Logging might be a nice basic thing to hook up next?


are you getting these build errors too?
[image: Inline image 1]

-- Paul Hawk

On Mon, May 18, 2015 at 7:41 PM, Nick Groos <notifications@github.com>
wrote:

> Sweet
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/groos/dbPlay/commit/79a0d9079e723912693fb36248a422bf76bc2825#commitcomment-11252294>
> .
>


Go check system/core commit.


Maybe change CIC, USA to TODO


I just realized I didn't move those methods into the moon class very well when trying to simulate inheritance. I wasn't sure if I should commit the change, so please be aware that the end statement on line 101 should be on line 122. Sorry! :(


I would have thought these changes should be sufficient to allow editing a particle's properties. The values appear to not be read at the scripting level, but I don't currently understand why.


Ugh, just found this. Please don't remove working code because you don't find it convenient or to your liking. This makes a mess for me to have to come back and sort it out. I wouldn't have accepted this patch had I noticed this before.


The :placeholder-shown and ::placeholder not the same selector
See also:
* http://trac.webkit.org/changeset/172826
* http://dev.w3.org/csswg/css-pseudo/?c=M%3BO%3DD#placeholder-pseudo


Tá usando o TTS do Google?


Thanks for the heads up, maybe we should also assert
```ruby
assert_operator @pool.size - @pool.connections.size, :>=, 2
```


是，虽然项目里面没有装fis，但是不知道为什么release后的www文件夹里面安装了fis。clean后重新release就可以scrat server start


Both v1 and v2 of the AWS Ruby SDK accept the string literal `AES256`, no need to differentiate.

    @s3_server_side_encryption = "AES256"