hmm damn... apparently verit also changes the order of equalities in the input formula. Your proved sequent becomes:
f(x_0, y_0) = f(y_0, x_0), not( x_0 = f(x_0, y_0) -> (y_0 = f(y_0, x_0) -> x_0 = y_0) ) : -

But we disregard this part and replace it by the original sequent (because we don't want the negated part). That's why the deep formula is invalid. Since we don't know which direction is the original one when parsing, I will add both directions for the input formulas... (the symmetry instances are generated during parsing, at this moment, we have no access to the original end-sequent, only the prover knows about it). Do you have a better idea?


I have to check this


А, да. Это я уже сделала, будет в следующем коммите.


Code changed to wrap legends for graphs


seems like this should be covered by a unit test


Looks like I deleted part of this line by mistake


I'm following the existing pattern for the lib


Ещё есть мысль, что можно сделать это генератором, возвращая список через `yield`. При желании можно будет просто создать список на результате вызова функций, но при этом с большими файлами будет возможность работать построчно


triggers a click every `data-push-interval` ms


Do we need to throw an error in this situation? You could just invoke ```getUsers()``` and then parse out the relevant line, no?


Looks like you are also removing the line-breaks here.


V9 again


I don't want to break existing implementations when they upgrade to this version of the lib.


In my opinion if it needs to be manually set there shouldn't be a default that is broken for deployments. If we know all of the datacenters maybe just default it to datacenter[0]?


Typo: setPassord


Newnick shouldn't have any "garbage" attached. Is there anything in particular that didn't work?


or a unique one, as the ones coming from the browser


Crap, sorry, I should've caught that.


I cannot sure range based loop because we are looping over two arrays at the same time. I thought about changing the `at` which we basically never use but I changed my mind. I guess I will change it after all.


There are some times where we don't want to do this. I suspect that it is because influx v9 is not finalized yet.


I could guess, will end up with a never ending duplicate of + 10 DC weapons or something? haha


Nit: missing space after if -- then again this will ultimately go into "their" code and not ours.


You can get these files in src too, it all depends on what you navigate to on the Mac when browsing the directory tree.


I ended up taking a different approach, in https://github.com/smartinez87/exception_notification/commit/d13c366d6a36d85a2800ae470e15e8eb3e7b7abb


ack


I really hate one-line if statements that don't have curly braces.  goto fail, anyone?


Interesting - I did try something like this locally but didn't confine it to backward pawns on a half-open file ( just looked for all backward pawns)


Changing filenames is safer, and allows more aggressive caching. Servers can aggressively cache files, and sometimes not update them when the names don't change. We were having issues with this on Heroku on Rails projects. By changing filenames, this is never an issue. If the file changes, you're ensured the new file will be served. This is how Rails and some other frameworks have handled it.


Since this is a client lib I don't think that we should do that. but I could if you think I should


How must be a result SQL query to set headers ?
Somthing like this doesn't work
SELECT * from amqp.publish(1, 'psql', '', 'message',  '{{"delivery_mode", 2}}'::varchar[][2], null)


bind only on `click` events, the *push* module will handle the loop


Why is this needed?


Add an option to customize the superuser flag name.


nit: missing space


This duplicates the title, i suggest this:
```
<field name="journal_type" position="attributes">
    <attribute name="invisible">1</attribute>
</field>
<field name="journal_type" position="after">
    <field name="wizard_title" />
</field>
```


possibly faster would be to hang onto the bit board at line 277 (b = ourPawns & file_bb(f);) and then you can avoid the call to make_square?


There is either a superfluous comma or a "Sweden" missing.


"by dint" ?

Can you help me understand why this section is needed?


One of the "The end result" clauses should be removed, probably the first.


Add yourself! :-)


There you go with the hate speech :-)

I'll go ad-hominem, by saying that the sentence you proposed is very you.

I would rather be a bit more vague. How about this?

On Tue, May 26, 2015 at 9:14 AM, Matthew Brett <notifications@github.com>
wrote:

> Thanks for the changes. I find 'our community will experience great
> successes' a bit - er - Norteamericano.
>
> How about 'We welcome these differences because they are the engine of
> debate, and it is through debate and discussion that we will make our best
> decisions'.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arokem/nipy.github.com/commit/f961bb73645a7ab83a9027708c377282748d6b12#commitcomment-11367840>
> .
>


This switch from `%{defined suse_version}` to `0%{?opensuse} || %{defined suse_version}` seems like a separate change that should be broken out into its own commit


I don't yet grasp the difference between `search_synonyms` and `index_synonyms`. For the `foo, bar, baz` example, could we use those at index time? That would save in complexity here.


Sqoop Comands


I guess we don't need this for now?


This conditional for `0%{?debian}` seems like a separate change that should be broken out into its own commit


JavaScript gets stylized with a capital 'S'.


2) Yes, I decided to go that route after looking at this more closely. The other option was to look for certain socket errors and fail the streams, and for the other errors we'd need to call _dispatch, which would cause a new session(s) to be created and TCP connection attempt to be made. Doing nothing, like the code here did previously, leads to stranded requests. I certainly don't think stranded requests is desirable, and I don't think multiple TCP connection attempts are desirable either. It's not something the HTTP stack would do, and the app can always recognize the error itself and retry a request. Hiding it from the app doesn't have any benefits that I can see.


Did you happen to checkout through xcodes repository support?  in general we should need to exclude stuff in shared dirs, so you must have done something to set this up on the workspace.


I understand that we do that when adding elements because it's easier to see what was just added and because the user might want to play those items right away. However if MPC-HC automatically selects the first element when opening a playlist, it forces us to start playback from this point which is not always what we want (cf. shuffle).


@meanbunny supported to save tr's attributes in v1.8.0.


Speak for yourself!


Interesting to see Blue-Shadow's comment be from Oct 2014, and remains unaddressed.


Yes, that would be good to find out what it is for, and remove it otherwise :)


Yes, that's fine :)


Already done in https://github.com/christopho/solarus/commit/8c1e5468eea621053541031d777f3013dd07a7cf
but not enough (you also have to do this in sources actually).

I guess I'll split changes from this commit into smaller ones when I'll found what's wrong with the OSX_fix branch, I've just pushed it in case someone also want to try to fix in the meantime


temporary patch until better place for initialization is provided


Can we somehow differentiate between the `all_searchable_text` `field` and `type`? Naming them differently would better communicate the intent and improve greppability.


Any reason why there is no space between any of the tests (```it``` statements)?


Comments within.


Some places use `0%{?suse_version} || 0%{?opensuse}`, and other places use `0%{?opensuse} || 0%{?suse_version}`. Mind standardizing on one or the other?


wow that escalated quickly!


<!DOCTYPE html>

What Can JavaScript Do?

JavaScript can change HTML content.

<button type="button"
onclick="document.getElementById('demo').innerHTML = 'hello SIMONE!'">
Click Me!</button>


I think that the "not acceptable" is trying to be along the lines of this:
http://blog.izs.me/post/30036893703/policy-on-trolling

That is, we not only work hard, but just don't tolerate certain behaviors.
Can we reword this to be less super-ego-ish, but still convey this message?

On Tue, May 26, 2015 at 9:16 AM, Matthew Brett <notifications@github.com>
wrote:

> Is there any way to avoid the rather maternal phrase : 'are not
> acceptable' ? The passive tense implies some super-ego who cannot be
> questioned. How about 'We will work hard to make sure we do not bully
> people or exclude them from the conversation'?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arokem/nipy.github.com/commit/f961bb73645a7ab83a9027708c377282748d6b12#commitcomment-11367880>
> .
>


Можно в конце добавить: "Аналогично для недокументированных параметров запросов к API"


Does Doxygen care if you start the comment on the line with `/**`?  We usually start the comment on the next line (scroll down to the Documentation" section [here](http://mooseframework.com/wiki/CodeStandards/).


:+1: `TextQuery` is a better name than `CoreQuery`


This is the wrong place to report bugs. No wonder it was overlooked.


Looks great! I'm glad we had time to go over some of the layout concepts during office hours. Let me know if you have any follow up questions this week.


Agreed, avoid posting bug notes in github. Put them on the forums instead.


Ah! That's 'cos it sets it to something for you.  Perhaps we could either make it ask for the password, or just put the username / password into the readme (it's already in the rake task, but that's not super-clear).


"ключи и параметры" - ок


To avoid the "hidden" dependency on the default `base_uint` constructor zeroing the number out.


Given the number of items with no known predicates, and the MIX predicates with no official ontology, maybe it makes more sense to create a new ontology for these predicates?  We could link to the existing terms (e.g., with skos:closeMatch or skos:relatedMatch).


This is perfectly readable, but I think you can just say ```Assert.That(wordList.ContainsKey("linea")``` and it would be just as readable, and you save yourself a bit of typing


Oops, that should read "this calculation."


Using GNU make instead of (presumably) BSD make on OpenBSD seems to get past this error -- pkg_add gmake


This is not the right solution. You'll break everyone's ability to build. This package needs to be added to Godeps.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/development.md#godep-and-dependency-management


Will the tree build without the UI, or is hack/ui/build-www.sh going to be a mandatory part of the build process?


#为了防止生疏，只是一些基本的练手而已


I think it should be sufficient to use the same style for all boundary layers.  Let's make this generic and reuse it for all boundary tile requests.


Извини, не очень поняла про поэлементное сравнение записей...
Тут особенность в том, что в любом из файлов могут быть "лишние" по отношению к другому строки, поэтому я не смогла придумать ничего лучше сдвига позиции и islice.
Я пыталась сделать множества из вот этих уникальных "концов" строк и сравнить их, но потом очень сложно перейти обратно к полным строкам, получается ещё хуже.
Впрочем, можно сделать множества полных строк и сравнивать "концы" от этих строк, а "лишние" возвращать. Ты это имел в виду? Там небольшая проблема с тем, чтобы точно обрезать начало строки, поскольку число символов может быть разное, придётся делать регулярное выражение на нужное число Tab'ов...


I'm not too sure about the name for this interface. Normally, interfaces have nouns as names. For example, if objects that implement the interface are supposed to break lines into words, I would probably name the interface ```WordSplitter``` or something similar. And then the method might be named ```SplitIntoWords``` or ```BreakIntoWords```


ack


Question - in updating the message id with a guid - I noticed that the spam assassin server was receiving the same message id every time. Looking into this further I realized what was happening.

Firstly, the headers variable and others are declared in the global scope. Due to the nature of node caching modules upon require, the _headers variable is only instantiated once. Later in the javascript you'll see the following:

```javascript
_headers += 'Message-ID: <4F452339.1040102@'+ _host +'>\r\n';
```

This causes the headers to continually append. Obviously, one could change the += to an = for the first line and this would solve the issue in most scenarios - however I was concerned with what could happen in a possible race condition. This led me to rewrite the file to restructure it and move the variables into what I thought would be their proper scopes. I kept the same concepts, method names, etc., but I changed quite a bit. I'll post it in a few and you can take a look. If it's not something you want to pull in I can just maintain the fork.


Hi Zac,

These columns are not supported in the CSV import, and all the event columns (which likely came from the actor table) are in fact duplicates of data found in the creators, creationDates, creationDatesStart, etc columns. Because that duplication could cause problems, and because we want the data to be able to roundtrip properly (so the output can be used for a CSV import without modification), we're removing them.

Have you had a chance to do some testing with this work yet? Found anything of note?


Hmm... is it possible for `p - axis_proj == (0,0,0)`?


1640-AddHVACPart1 (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


typo `same`


Maybe we could improve readability by expanding the method names (`compose_dis_max_query`, `compose_match_query`)?


Is `minimum_should_match` parameter used?


No and it should be changed. I considered changing it - may still do it.


Looks great! Nice use of comments in your code as well.


The name of the table is baked into the name of the style.  I did not see an example in nyc-trees of how to do this dynamically.


@NoelMacwan I wanted to maintain this rom for sprout, can I?


Hmm! I will look at that.


ah yes, sure do :)


We might be able to do the `dis_max` wrapping here, instead of in the `field_boosts_words, field_boosts_phrase, field_boosts_all_terms` methods?


Yep will add support later.


reack


is the format that the lib has been using


reac


Well I don't want public inheritance because not all CAtlList functions are supported. I don't see the problem with `using` here, as far as I know it's a perfectly legit way to make some inherited functions visible.

If you really are against protected inheritance I see two solutions:
1. I re-implement all functions even those we don't need (yet) for safety.
2. I switch to composition instead of inheritance.


Cast -1 to unsigned sizet then compare to int? seriously?


I cannot reproduce the crash. Was it here because of hvalue_ == -1?


Yes, in the hash at line 125


You could use fixed buffer size. But fine if you want to go deeper just to operate on CStrings.


I thought about the same thing but I didn't want to completely remove the return value just in case someone would need it later which is silly since it can always be added back.

I'll remove it.


public GameObject X1,X2,X3,X4,X5,X6,X7,X8,X9;
	public GameObject O1,O2,O3,O4,O5,O6,O7,O8,O9;
	public GameObject player1,player2;
	public int numero;
	public bool contador1,contador2,contador3,contador4,contador5,contador6,contador7,contador8,contador9;
	public bool contador21,contador22,contador23,contador24,contador25,contador26,contador27,contador28,contador29;
	public AudioClip clik;


Should there be consistency in the "function(){" vs "function() {" as well?


That wouldn't be the same thing - we're summing the weights from the dis_max queries here, rather than dis_maxing them.


@vlag Can you push now on master whatever improves the situation? See also http://forum.solarus-games.org/index.php/topic,257.0.html
Because I can only do blind fixes.
Thanks in advance


Dan,

I haven't personally used the event columns to create events other than
*creation*, but I had conceived that could be possible.

I've just started looking at export. I'll have comments tomorrow I reckon.

Thanks,

-Zac
On May 26, 2015 1:33 PM, "Dan Gillean" <notifications@github.com> wrote:

> Hi Zac,
>
> These columns are not supported in the CSV import, and all the event
> columns (which likely came from the actor table) are in fact duplicates of
> data found in the creators, creationDates, creationDatesStart, etc columns.
> Because that duplication could cause problems, and because we want the data
> to be able to roundtrip properly (so the output can be used for a CSV
> import without modification), we're removing them.
>
> Have you had a chance to do some testing with this work yet? Found
> anything of note?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/artefactual/atom/commit/34ae45fc8efaaff1af77747bb160458303bddfdf#commitcomment-11368191>
> .
>


What about original problem that led to commit?
I think the best way would be adding setting of whether to use getmypid or not.
That would solve the problem.


There must be something very strange going on with this test if it needs an `nl_abs_tol` this loose...


I would be keen to see a TZC400 header file that would contain the TZC400 registers & definitions instead of magic values in the source code.
For instance ArmPlatformPkg/Include/Drivers/Tzc400AddressSpace.h or ArmPlatformPkg/Include/Drivers/Tzc400Trustzone.h

About coding style, do not forget the space between the function names and '('


:+1: will fix!


I'm not sure what is a reasonable fixed buffer size for those strings. I mean it depends of the translations.


> If there are 3-5 terms, allow one to be missing; 6-7 terms, allow two to
be missing, 8 more more terms, require 75% present (rounded down).

:+1: This commit message finally made me understand `MINIMUM_SHOULD_MATCH`. Can we add it to the comments?


The code is in the repo, but the published version of the gem doesn't include it.
It only helps with backwards compatibility, for versions >1.9 it is not needed.
Unfortunately it is not possible to point to git in a .gemspec, so we have to include this here until they publish a version of the gem with the gzip middleware


LGTM.


TODO: do not hard code the start date. Use something like currentutcTime - 1hr


unfortunately, we only know the current DC. This was the least broken idea I came up with for handling it. Setting it to the first datacenter would be ideal, though.


Perfect. I'll add the pword / uname to the README


Yes I think ```return``` is necessary here, otherwise the action will render the ```unsubscribe.html.erb``` template as well.


Might be nicer just to do if [ ! -f "/usr/bin/pep8" ]


Thanks @mikejolley


Note that commit message says `sortable_searchable_text ` instead of [`searchable_sortable_text`](https://github.com/alphagov/rummager/blob/cc07e91ece209b6ffd025652e38ad92fe48bcc5b/config/schema/field_types.json#L84).


I guess it depends how maby people were affected, probably not that many have a Logitech Keyboard with LCD so you're probably right.


f


no need to have a separate commit for this, squash it into the other one


Could you use marcrel:fac or does facsimile imply a traditional print facsimile of a manuscript?


Поэлементно -- я имел в виду элементы списка, являющегося строкой исходного файла.

Просто сейчас мы получаем строку, разбиваем её по табам, собираем снова в строку (правда, только часть) и сравниваем строки. Я предлагаю сравнивать списки, полученные от разбиения строки по табам.


Hey @richardkmiller  i added a cache buster string option to the new dev-master or v3.0.0 can you try it and let me know if it does resolve the issue your modiffication is about.
Note: plz try on a fresh install as the new api is different.
Thanks


Looks great! Glad we had time to go over some of the layout and styling concepts during office hours. Let me know if you have any follow-up questions this week.


It crossed my mind but I decided to go with :rocket:'s because I wanted to be consitstent (and was too lazy to refactor the whole file to use the new syntax :/ )


go-dockerclient also has a ParseRepositoryTag function... no need for the docker prereq:
https://github.com/fsouza/go-dockerclient/blob/master/misc.go#L50


I think the instructions for building the package should be moved onto this page now we have it


How to check available upgrade, then how to upgrades to the latest version


Fixed, this was because test "ipfs init output looks good" uses the out-exp ordering, so it didn't occur to me.


I mean if `match` is ever going to be called with a different `minimum_should_match`, or can we lose the argument and just say:

```ruby
...
query: query,
minimum_should_match: MINIMUM_SHOULD_MATCH,
operator: operator,
```


this should be `Where(item => item.IdentifierName == member.ComponentName...`; the `target` is not located in the interface module in that branch of code.


@jthelin It was a valid point, I fixed it. It looks like in the process I lost your comment, perhaps it was due to rebasing or that the diff got out of date (or something GitHub related).


Hm. My reading of the documentation indicates that setFastestInterval is not required - an application can always receive updates from other requests. In particular, note from:
https://developer.android.com/reference/com/google/android/gms/location/LocationRequest.html
that:

> At the other extreme, if you want negligible power impact, but to still receive location updates when available, then create a location request with setPriority(int) set to PRIORITY_NO_POWER. With this request your application will not trigger (and therefore will not receive any power blame) any location updates, but will receive locations triggered by other applications.

I am going to skip this change for now, but will add an issue to investigate setting this along with the duty cycling of the location detection.


If we plan to use DefaultTag elsewhere, maybe it shouldn't include the ":" at the beginning since that's not part of the tag name.


Agreed – really a library abstracting all of the TZC-400 access would be far better.  Apparently the old A9 platforms had something like this already.  I considered this but became confused trying to reconcile FVP Base from FVP Versatile Express (please advise how we should handle these – should we just create a second platform for FVP Base?).

From: Olivier Martin [mailto:notifications@github.com]
Sent: Tuesday, May 26, 2015 10:40 AM
To: eugenecohen/edk2
Cc: Cohen, Eugene
Subject: Re: [edk2] configure TZC-400 in EL3 SEC so DRAM is writable by non-secure code (e1aa3c1)

I would be keen to see a TZC400 header file that would contain the TZC400 registers & definitions instead of magic values in the source code.
For instance ArmPlatformPkg/Include/Drivers/Tzc400AddressSpace.h or ArmPlatformPkg/Include/Drivers/Tzc400Trustzone.h

About coding style, do not forget the space between the function names and '('

—
Reply to this email directly or view it on GitHub<https://github.com/eugenecohen/edk2/commit/e1aa3c127aa1fb0f466522ff39170ce168b5e032#commitcomment-11368331>.


I guess that is a more accurate name because the primary key is a set of two IDs, but at first I thought it would get multiple events.  I wonder if the name can still be improved?


ack


Yes.

Some style guides even call for a space between `function` and `()`.


Something I overlooked. It should use contains instead.


Good to go.


@dharmamike the replace with substring call only does one replacement, so I guess you could use the regex / /g to replace all spaces.


It feels weird to me that nothing is selected after dropping new items.


I know there is a default style per geometry type.  Maybe @maurizi can point you in the right direction?


I'd supposed it to be rather `true` or `false`. Consider renaming it. Something like `errorsAllowedOnSubmit` would be much more descriptive.


Well it needed to change because of the magic of the RecordList, when it is iterating, calls getByID and does so on the primary key of the table, the record ID. So this method would override the magic method call there (maybe have been different capitalization actually but regardless, it's confusing). A better way might be for a magic method that allowed getByTwoFields or something like that.


ack from me, @AbdealiJK ?


Ops, mudei uma parte errada... huehue. Agora não sei voltar...


Why did you remove this line? The intent is to point the developer to the place where they can find all of the automated set up commands, in case they're not familiar with this new rails convention and they're curious what it takes to prepare the application.


I meant something like `queries = queries.map { |query_set| dis_max(query_set) }`, so it's obvious _all_ query lists (`field_boosts_words, field_boosts_phrase, field_boosts_all_terms, field_boosts_synonyms `) are being `dis_max`'ed.


4.2/skip-asc-keys solves this in a more general way, as many clients send keys simply as `application/octet-stream`


ack from me too


There is some codes that we should copy over the new profiler before
deleting them.

On Sat, May 23, 2015 at 11:15 AM, abergeron <notifications@github.com>
wrote:

> No, because it doesn't pass flake8 since the "if False:" section is full
> of errors about undeclared variables and such that I didn't want to fix.
>
> If we can delete that section then it would pass and could be taken off
> the whitelist.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abergeron/Theano/commit/d5ff2b4819b5bd314b041968a25ddcba3f394e6e#commitcomment-11339673>
> .
>


Thanks, @jules32!

On Tue, May 26, 2015 at 9:24 AM, Julia Lowndes <notifications@github.com>
wrote:

> some edits for @omalik
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/OHI-Science/ohimanual/commit/8eb5e965860f8a32ddeceac0074178a20b33376f
>

--
Omar Malik
Asst. Project Scientist, Ocean Health Index
National Center for Ecological Analysis and Synthesis
email: malik@nceas.ucsb.edu | skype: omarmalik_skype


Filed issue #26


"iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABbklEQVR4Xo2SP0sDQRDF3+ydlztQjqCNRSB+AUux0y5dWls/gJWF6fwCksImkMJCsBKS0tLGLqVYBUJImuBBGk84cv9GZopwqNzdwvJYdt5v3wxLzIw6azAYcBiG6PV6VDQY1Fx5nmMymfwB28XDcDjsM/M5ER0COACwQ0RqbrfbsG27HBDH8XWn00Gj0dgWZ1kmWyGWZZUCtMj3fZyMmvDsHFFOABh7ToLH08/KBFKgr5HFuDkj2IYhiP67ja84rwYYY5AkCcgwHEnLDAMoEIxaCbQNsoDbN4AJIBKCsLJKgAxJAc/HH6LSzlZ9y/8XYP4DjMInvKQjTKdTPe/fP4CZ5b5egq57oZodZarB1SWaQHmC4gxms5nqfD7Xl5fL5TZhVQti0F8HQFRBrVYLqJPAGKOG1WoFx3EQBAFc18V6vRaw3JfPgIi+oyjaLSYgIlH9H2EYcilgsVjcjcfj7mazEWMRjDRN4Xne62/AD0JoucFQHqebAAAAAElFTkSuQmCC",
            "encoding": "base64"
          },


http://id.loc.gov/vocabulary/preservation/rightsBasis/cop for copyright_basis?

@escowles, @anarchivist: would we want to align these three rights properties with the Rights Metadata Work or should these stand separately with their role in the tech metadata? I tend to want to align, but as I'm less familiar with FITS, I'm not sure which of these three is the actual statement or if there is one here.


It works due to the pointer conversion operator and is equivalent to ``if (_connectionValidator.data())``


The generator does not generate a move that steps over the current player's pieces. I will remove this additional check. I don't know if chess rules allow this, I couldn't find an answer.


> So what is the difference between shuffle and randomize?

Randomize modifies the playlist. Honestly I'm not sure why people would need that but I guess there might be some needs for this.

> Except that on next loop it will shuffle again.

The shuffle order won't change unless you add new items, disable and re-enable it or restart MPC-HC.

Note that the shuffle behavior obtained by fixing those tickets mimics what other players do (e.g. Foobar2k). If there are requests for a pure random mode (the only rule is not to repeat the currently playing file) I can add it but we will need to define what is the end of playback in such case.  I can also add an hidden option to reshuffle on repeat if people think it's useful.


I have visual glitch. ![playlist](https://cloud.githubusercontent.com/assets/1126053/7817795/bf6f2440-03d7-11e5-83ee-ab4ed9db353b.png)

Press space on few items to reproduce. Looks like redraw is missing somewhere. Because it we trigger it by for example resizing playlist window red text is gone.


I had edited this line in a previous commit, this should just be the reversion back to the original.


**Attention** space/tab indent


The default value for these settings in appleseed is infinite (it uses russian roulette to terminate paths when their contribution is too low).

I thought about adding extra infinite yes/no checkboxes in the appleseed options node in Gaffer,
but I'm not convinced infinite is an useful default value. Most users will want to set the max number of bounces because it has a direct effect on render times.

I think I prefer to keep things simpler and use a fixed default value in Cortex and Gaffer.


Yes, that was the intended meaning. I will change the name and comment to getOccupiedPositions.


What I could do is selecting the first played item if none previously was, would it that be ok? It would also have the advantage to make the behavior consistent with the case when MPC-HC is opened with items already in the playlist (no items are selected in this case currently).


@jamesmcclain The name of the table *is* baked in to the CartoCSS, but you select multiple tables at once: https://github.com/azavea/nyc-trees/blob/develop/src/tiler/style/progress.mss#L32


Nope. Also Samuel sometimes leaves unused imports, although the warning seems to be configured as active.


Right, I will fix it right away.


reack


rax retry tests


ALSO! There's no photo uploaded for this. I had to compare with the printed Garland book.


If pep8 has been installed using pip, then it may cause some issues, installing the deb package as well.


Wouldn't it be easier to use Phar::running(false) as in manual example:

    $a = Phar::running(); // $a is "phar:///path/to/my.phar"
    $b = Phar::running(false); // $b is "/path/to/my.phar"

Btw great project :+1:


SGTM
+2


То есть лучше сравнивать списки? Хорошо, сделаю.


We can also, I believe, declare the style in the http request.  This may allow us to not have to modify the cartocss when adding new tables.


cubicle/Src/CUB_event.o
OUPSSS use git add -p


The LDC case here works like charm. Seems like the hypre and boomeramg was causing a floating point exception. Not completely sure though


@maurizi okay, I'm okay with that.  I had just left a note in the file as a reminder that this has to be done (reminding you which files need to be kept in sync).


> Randomize modifies the playlist. Honestly I'm not sure why people would need that but I guess there might be some needs for this.

So the only difference is that one directly modify the playlist and the other do it internally. I wonder if we need both ;p

> If there are requests for a pure random mode (the only rule is not to repeat the currently playing file) I can add it but we will need to define what is the end of playback in such case.

In random mode there is no end of playback. It just pick random element form the list and play it. I don't think we need a mode for that specifically. Though we might add a hotkey to pick a random file from the current playlist. Foobar has a play button with question mark which does that.


I like the idea of 'replaceable' and wonder if it derives from some design pattern? I haven't used it before, but it seems it is handy when the replaceable object in question has already been delivered to some number of handlers and you don't have an easy way to update those handlers directly. Would that be correct?


hmmmm


will the property set elsewhere? or is it not required?


> The HashiCorp product line for managing infrastructure

The paragraphs here read disjointed to me. I feel like we should have the first paragraph as is, then the following

- a paragraph how TF is one of the tools to solve these problems, but is ran locally with limits
- a paragraph how Atlas is one of the tools to solve these problems, but is isolated (or something)
- a third on how we're announcing this thing that links/combines/addresses the shortcomings


I noticed this as well. Seems to happen on City of Vilcabamba too!


should be `min`, and also this need to compare v1 and v2 length before doing the compare.


Actually, it is undocumented, but [looking at the parser code for CartoCSS, it looks like you can use `*` to select anything](https://github.com/mapbox/carto/blob/master/lib/carto/parser.js#L500-L505)


Good to know, I didn't know the answer to this question. I made an assumption that the current player could pass the opposing color. I added this assumption as a comment in line 44.  Will correct it.


hmm... I see your point and went with this, until #641 might resolve the underlying issue for good. Setting `extraCleanfigureOptions` inside `ACID.m` is already pretty awkward and a developer has to have a good understanding of the testing process. Nonetheless I agree that this line obfuscates the process and makes understanding it more difficult for others.

How should we proceed? Remove this now and makes tests unreliable, merge global state mocking first (otherwise not necessary for 1.0), keep as is and add yet another `FIXME` note to (hopefully) remove after #641?


so the action responsebody now can have an xml attribute code (or status?) Why merge the two actions?


This is a beautifully deep test.  Will need to ensure this works (without too much of a penalty) on Pypy, as Pypy has some optimizations around not accessing frames directly.


should be `rChar i` I think. same bug in the `show` code of `Bytes`


@catsby Agreed that's great feedback.  cc/ @sethvargo author!


@maurizi Thank you for that, I'll definitely give that a shot.


Note: Suggestion by azoundria.


Could you introduce a new macro (eg: ARM_FVP_NO_ARM_TRUSTED_FIRMWARE) that would enable the different code paths (with and without ARM Trusted Firmware).

If you do want to introduce the macro (I am also fine with that), you will need to change ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c to support the sparse memory on FVP.


Oh, I had introduced "internal" with the lower case a while ago with
Vtr::StackBuffer and again in Far::PatchBasis -- I hadn't seen the
uppercase.  I prefer lower case because it further distinguishes it from
the public, capitalized Far, Osd, etc., i.e. lowercase implies protected.

- barry

On Mon, May 25, 2015 at 11:49 PM, George ElKoura <notifications@github.com>
wrote:

> Thanks Barry! In Far, I see that we use "Internal" with capital "I", do we
> want to change the Far ones to lowercase, or these ones to uppercase?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/barfowl/OpenSubdiv/commit/85b65bd2efdb61a1f9d9c66c3a99a33264898a2a#commitcomment-11357769>
> .
>


As [noted here](https://github.com/eternicode/bootstrap-datepicker/issues/1145#issuecomment-94485898), this is hiding datepicker if I click wherever else on the page. Please revert or provide an alternative fix with tests, please.


why is the else removed here?


It's weird that it doesn't work on your repository. It autocompletes in mine. Maybe ask support?

The patches look good to me as far as I can tell.


@kestlund This is one of those cases where from looking at the FITS code base I don't see strong evidence that `copyrightBasis` or `rightsBasis` are even generated. `copyrightNote` seems to only generated based on Exiftool output for PDFs, despite the existence of an EXIF metadata header for copyright holder information.


Yes, if you look at the file in master that was fixed 2 weeks ago: https://github.com/cloudera/hue/blob/master/desktop/libs/hadoop/src/hadoop/fs/webhdfs.py#L868


if needed, let's call is status too.


> The GitHub + Atlas integration is powered by Terraform.

This doesn't make sense to me at all.


This function should check bounds and that the parameters are within bound (maybe adding a 'unsafeView' later for doing wacky thing, although, we don't need it now)


Does it make sense to put this in bin or sbin?


ok


The comment "// TZC-400 Address Space Controller" does not match the lines anymore.


LGTM.


:tada:


This was left in by mistake. Please disregard.


> +1 on having it done by in the Dockerfile

Going to look at building a new branch a la github pages which just has the dist files + a Dockerfile in it.


thanks for updating. The empty lines were put in explicity for readability....


When I remove nulls, I can't create Address object. Is there a way to create this object without those nulls?


CSS3 Box-sizing not supported by: IE (10,11), Chrome (41,42), Safari (8,7.1), Opera (26,27), iOS Safari (8,8.1-8.3), IE Mobile (10,11)


> So the only difference is that one directly modify the playlist and the other do it internally. I wonder if we need both ;p

I guess some people may whine if we remove it ("but I want to randomize my playlist once and for all!" blablabla)


:scream:


Is it possible to configure via a setup.cfg file as per http://pep8.readthedocs.org/en/1.4.6/intro.html#configuration ?


@nviennot what do you mean by "[...] they don't seem so useful" ? I'm using them to build my indexes.


Why do we need to enable the reference counter so early?


The entire section on Terraform reads like bullet points from a presentation instead of paragraph, start-stop-ish if you know what I mean


Oh :)

So they are useful to you?


ok, better


Yes, that's the idea exactly.
I don't know if it comes from a design pattern. If so, I've forgotten it. I'm sure others have done this sort of thing before.


Let me add: I also didn't like `cleanfigure` being always called at first. But this is what actually made us aware of some corner cases of the new algorithm that would not have been spotted otherwise.


А есть какой-нибудь хороший способ в списке списков обрезать каждый список? Иначе здесь теряется смысл islice и приходится разбираться с этим списком поэлементно.


That makes sense.


Yep, especially as I'm still quite new to RethinkDB


wrap this line please


oops... going to be fix in a minute.


Why are you setting the git repository instead of a rubygems versions? Like 0.6.7.


Please stick to the standart and use semicolons + var on each line. Accidentaly using a semicolon there could lead to the creation of a global.


> Atlas uses OAuth to authenticate and link with GitHub. Simply visit your settings page and click on the "Connections" tab.

"settings page" in GitHub, or Atlas?


Nice!


@josevalim I think including the `msgid_plural` for plural translations is a good idea, even if it may be long and it's not the last thing in the error message like in a regular translation. Let me know if you have a better idea :)


Otherwise LGTM.


Should this be in QgsGeometryData so it gets detached as well?


After `bundle install` your `Gemfile.lock` probably was modified. Don't forget about adding it to the commit :)


I don't fully understand that.


Kirill,
Are you working on a modified patch?
Dan

On Fri, May 22, 2015 at 1:30 PM, Kirill Katsnelson <notifications@github.com
> wrote:

> I think this is the best approach. Another argument for it is that you do
> not want to compile in extra code when targeting Windows w/o Cygwin. And
> guessing based on environment variables at run time would perhaps be too
> complicated and violate the Least Surprise Principle.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-11332176>
> .
>


Anyway if you guys agree with the new shuffle behavior, I say we go with it and see what feedback we get. I can always adjust the behavior in next stable if we have requests for it but it's hard to know beforehand what people need exactly.


> Atlas uses OAuth to authenticate and link with GitHub. Simply visit your settings page and click on the "Connections" tab.
>
>GitHub will ask you to verify the request, including the permissions Atlas requires.

What request? I just visited the settings page, now GitHub is verifying .. what?


In my opinion, it's better to look at the overall query time, and take action only when it goes past, say, >1s.
Because when the data set is small, it's not necessarily a problem to not have an index.
Also, even with using an index, a query can be slow and needs to be worked out.

I remove these performance warning as I though they were a red herring.
Now if you feel strongly about this, I can put them back.


I needed the cast because it a narrowing conversion. I wanted to simply and reduce the code. Any suggestions?


make this "COMMAND [options]"


About coding style again, you are still missing the space between the function names and the '('.

I am potentially happy with this code.


lgtm


You sir, are comparing the given password to itself. I hope nobody is actually using this code!!


Нет, не стоит обрезать списки на этом уровне. Функция, которая умеет сравнивать две строки, будет гораздо нагляднее, хоть и придётся отказаться от простого условия `x not in islice`.


We have a few modals now (`deleteresource`, `deleteresources`, `deletecomment`, `leavegroup`) where we set the `margin-bottom` on the alert to 0. It might be better to add a rule to `oae.base` that does something like this:

```
.modal .modal-body .alert:last-child {
  margin-bottom: 0;
}
```

That should allow us to get rid of some widget-specific CSS.


@luisdelgado Isso aqui deve ser dividido em duas parte: Given e And.
Porém, esse dois códigos já existem, logo não é necessário você criar outros passos que fazem a mesma coisa, porém usa palavras diferentes.
Você deve analizar o código já existente e se enquadra, pois isso num projeto grande causaria um imenso retrabalho.
Vide /test/cucumber/steps/BookSteps.groovy (ORIGINAL) Linha 31 para o seu And e Linha 79 para o seu Given. Faça pequenas adaptações que serão necessárias e prossiga feliz para sempre :P


The thing is, it wasn't overlooked. It was actually addressed in 31611c17d572e2aab109099d047e157fd51682cc.


The only thing I'm hazy about it why we aren't using parseV9Callback in some of the calls.


> so we can ingress your configurations

I'm not sure this reads as what we are trying to convey...? Ingress is the correct term for the config coming into Atlas, but it's worded as us going to get them...

Let's re-word this and drop the term ingress


...Thanks kryps.


6 is the number of characters per line. "a1 a2" is 5 characters plus new line.


Otherwise LGTM.


Why `/etc/modprobe.d/i2c.conf` and nor `/boot/config.txt`


Indeed, I was worried that I was generating too many files for project. Separating them will make it cleaner.


LGTM.


TeamCity xBIM :: Xbim Geometry :: Release [Build 70](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1744&buildTypeId=XBIM_XbimGeometry_Release) outcome was **SUCCESS**
Summary: Tests passed: 70 Build time: 04:01:04


TeamCity xBIM :: Xbim Geometry :: Release [Build 71](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1745&buildTypeId=XBIM_XbimGeometry_Release) is now running


To make that clearer, new behavior would be:
 - start MPC-HC with items already in the playlists or add items while the playlist is empty --> nothing is selected.
 - start playback when no items is selected --> first item to play gets selected (might not be the first one if shuffle is enabled).
 - add items in the playlist when some items are already here --> the first added item will get selected.


Nice find! The only question is the performance hit vs. an animated gif — especially on mobile devices. Haven't done a benchmark yet, but this should hopefully be faster. Would be very cool to reuse it for any loading screens as well as the loading icon/spinner. Thanks for the find man! x


This files are no longer need it.


static import


1640-AddHVACPart1 (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2133 of 2211 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.47%25-yellow.svg)


OK. It makes sense but what do you think to put it in a gist? Because it is a bit like commented code : noise that won't help newcomers like me :)


To me it's nice to have them as it's warning me and so I have to have a look at them.

In the other hand ... for ActiveRecord there is the famous gem [bullet](https://rubygems.org/gems/bullet) which adds warnings in the logs in order to tell where something should be loading which looks like the same as the performance warnings.

So in my opinion either a new gem needs to be created (where maybe a little more logic could be implemented in order to not warn when an index does not make sense, but could it done?) or you keep your performance warnings in your gem.


> Your GitHub authentication information is encrypted securely by
> [Vault](https://vaultproject.io) using Vault's
> [transit backend](https://www.vaultproject.io/docs/secrets/transit/index.html) (AES-GCM-256).
> The Rails application and data store are never privy to the encryption key,
> so even if an attacker could gain access to the stored encrypted values, they
> would also need to compromise Vault to get the decryption key. We will be
> publishing a more detailed blog post on how we integrated Vault into Atlas
> shortly.

"authentication information is encrypted securely by Vault, using it's secure Transit backend, which uses AES-GCM-256 encryption" or whatever, "encryption" might not be correct.

The mention of there being a Rails app seems unnecessary as well, should just be "Atlas".

> Atlas and the data store are never privy to the encryption key. And then something on "We will be publishing a more detailed blog post on how we integrated Vault into Atlas shortly.", don't bother with the story on compromising, it's an implementation detail IMO


I...uhh...typo? Fixing now, good catch, thanks.


We should use [reverse](https://docs.djangoproject.com/en/1.7/topics/http/urls/#reversing-namespaced-urls) to generate the URL; as written, we are still specifying the format of the URL in more than one place: once in django_irods, and again in hs_core.  The URL format should only be specified once, in django_irods.urls.


Hello. Please, return HDPI sources.


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 17](https://teamcity.labkey.org/viewLog.html?buildId=251920&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 24 Build time: 00:33:12
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


I was banging my head for some time trying to understand why my change doesn't get applied before I finally realised it overwrites the sources inside src/* because it's actually not sources...
o_O


This pull request looks good to me.


"Offline-Vorschläge werden online eingereicht" - verstehe ich nicht


> Combined with [the GitHub Flow](https://help.github.com/articles/github-flow-in-the-browser/),
> it is possible to control and manage entire infrastructure without ever installing
> Terraform.

Seems like we could use another sentence explaining how/what this means. I realize there's a link, but if they're unfamiliar with what exactly that is, we've just sent them off-site to understand what we're saying


Sorry, this was meant to be a push to my repo so I could make a a pull request.


I can warn if the query is slow (say >500ms).
In addition, I could suggest to build an index if there's something obvious to speed things up.


Sorry this was meant to be a push to my repo so I could make a pull request.


@catsby Awesome feedback, I agree with all of this. Going to send you a docs link so you can help just make these changes if you don't mind!


What's so hard about looking for the commit where a known file was deleted?

```
git rm build.xml
git commit -m "Remove build.xml"
git log --stat -- build.xml
```

Source control *works*; there's no reason to leave dead code lying around just in case.


@sdodson PTAL - largely borrowed from openshift.spec :smile:


True. But it wasn't introduced here.


will do.


> Over the next few weeks, we will be releasing GitHub integration across the various
> components of Atlas including applications and Packer build configurations.

is "applications" an existing component of Atlas? Or an upcoming feature/concept? If so, should it be capitalized? I don't know what it is in this concept


@mrunalp PTAL. I'm not sure if it's safe to use `binary.Write/Read` or if there's a better way. I tested it locally and it appears to work.


What's the idea behind `PathRequestMatcher` being private? That is, why not make it public and add constructors `PathRequestMatcher(Iterable<String> pathExpressions)` and `PathRequestMatcher(String... pathExpressions)`?


That would be great !


Looks reasonable to me.

In the future I'd put copying and modifying files in separate commits so it's easier to see what changed.

Another suggestion would be to refactor the common iDRAC bits into a superclass. Also would be nice to use a different HTTP library that handles the decompression.


XD let me update


@erjohnso Can I get a quick review?


I wanted the newest version. But the rubygems version is the same of the github repository, isn't? Ok, I'll modify it. Sorry. :smile:


test


@nbolton
I will look into that. I think it is something to do with the release build.


@kestlund: I agree that aligning with the rights metadata recommendations would be good.  So that would tend towards using dces:rights for the copyrightNote.

Though I'm not even really sure how the copyrightBasis and rightsBasis fields would be used.  I think rightsBasis/cop looks like it would be used to say the basis of the rights asserted is copyright, rather than recording why the copyright determination was made.  But I don't know which of those (or something else) would actually be used, if indeed it's being used at all.


May be not directly relevant to what you do, but I would like to point out that having the pathway data from MetaCyc and/or KEGG mapped to modelSEED reactions and integrated to our biochemistry object is extremely important.  These traditional pathways that biologists are familiar by their names (e.g reductive TCA cycle) defines the metabolic capability of the organisms for those experts.  Not to forget this data could be extremely useful on model/genome analysis, derive organism profiles and on pathway based gapfilling efforts.
Since the data is being reorganized, I would suggest adding these data into the biochemistry object with a pathway identifier and the human readable name for both KEGG and MetaCyc derived pathways.  I would imagine, for a given reaction minimally, pathway data could be included as

pathway_types : MetaCyc or KEGG

for MetaCyc :
MetaCyc_pathway_1_name : pathway_1 identifier
MetaCyc_pathway_2_name : pathway_2 identifier

for KEGG:

KEGG pathway_1_name : pathway_1 identifier
KEGG pathway_2_name : pathway_2 identifier

In addition, If you have the data for which step the certain reaction belong in the pathway (e.g MetaCyc_pathway_1_name : pathway_1 identifier : step 3
)  OR the other connecting reactions for the particular pathway would be nice, but one could generate the whole linear pathway if the above information is provided.


Fixed in 87d39e800c4bf7dbeb24f50e33a9c6a0f575609e


Just a test class. Will be deleted on official PR.


I'd rather not do it this way.  `-fPIC` may not work with all C compilers, so we lose portability.  The correct way to do it seems to be demonstrated here:
https://github.com/Scorpiour/glfw/commit/d7c2c95d4730537b45e5265369ef286923fb9bba
Unfortunately, using the `POSITION_INDEPENDENT_CODE` feature requires cmake 2.8.9.  That's also bad for portability, because debian stable doesn't yet have that version.  (Right now we only require 2.8 or higher.)  You may be able to deal with this in your own project by setting CMAKE_C_FLAGS when you call cmake.


Okie dokie! I didn't know if it was a good practice or not.


1640-AddHVACPart1 (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Nathan,

I feel really bad about this because I know you worked so hard on this, but I'm gonna have to revert this commit and the last one. The reason is because the point of the library is so that it isn't tied to any particular  implementation, which unfortunately your is. So for example this library should be able to be used regardless of how the developer wants to build the UI or what frameworks they want to use.

I'm not saying that there isn't salvageable work here, but it needs to not be tied to an implementation. I will say that I'm very impressed that you managed to learn all this and get it working, I'm sure this knowledge will benefit you going forward on this project.

Please feel free to call me about this so we can talk about it in more detail,
Ruben


The bug is in the standard OpenJDK XML parser (it's `com.sun.org.apache.xerces` this is derived from an older Xerces (2.7?) and has been modified to added some StAX support; current Apache Xerces does not have the bug). [JDK-8029437](https://bugs.openjdk.java.net/browse/JDK-8029437) - it is the present of `<variable name=.../>` that triggers this.

See [JENA-942](https://issues.apache.org/jira/browse/JENA-942) for workarounds.

C# are reporting issues due to lack of XML 1.1 support.


+1 squash commit and good message!


Ok, my bad. If we talk about base class it is fine.


Is platform 4.0.0+ now an absolute requirement of using the Facebook module in our apps now?


Item*Screen is Just a test class. Will be deleted on official PR.


It's too bad `getFullPath` is not already a method on an `HttpServletRequest`.


This causes the tabs to still be visible when clicking delete. The tab should no longer be visible when the confirmation dialog is showing.


Dirty


This should have a "px" suffix, otherwise it gets handled as "pt" AFAICS.

I'm not sure if there is a good reason for using `dpi`/`compute_fontsize` here, if `pt` could be used (which should take into account the `dpi` setting).


Will add to bom.


Reminder to put the urls in the setting.py file


Therefore, you want 1 container div that contains the tabs + the content of all tabs and you want 1 container (form) that contains the confirmation dialog content and footer.


This could be simplified to:
```python
self._output_layer = getattr(self, '_output_layer', None) or self.initialize_layers()
```
the second assignment of `out` is unneeded.


This is the client API.

new UberfireDock( UberfireDockPosition.SOUTH, new DefaultPlaceRequest( "Item1Screen" )  -> register a dock without an associated perspective. this just put the dock in the avaliable docks menu

 uberfireDocks.register( new UberfireDock( UberfireDockPosition.SOUTH, new DefaultPlaceRequest( "Item2Screen" ), "Home" ) -> Associate a dock in the perspective


Another test class.


So to give an example of what were looking for:

A developer calls:

FFOSBR.opitions();

and it returns a dictionary of the current settings of FFOSBR.

A developer calls:

FFOSBR.opitions({photos: true});

And it sets the internal state of FFOSBR so that photos will now be backed up. It also returns a dictionary of the new current settings of FFOSBR.

So with an implementation like this, the developer can link up switches like in your example to call:

FFOSBR.opitions({photos: true});

or whatever else.

(Feel free to change the names of these things, this is just a use case example.)

Sorry if you were confusing on what was being asked of you,
Ruben


The markdown preview remains the same. I just noticed there were a few line breaks that seemed to be unnecessary. I can revert and recommit if you like.


Pieces of Uberfire uses LayoutSelection Singleton and another parts uses @Inject. I've changed to everything use LayoutSelection singleton


here


Adding both directions for the input formula can be quite harmful complexity-wise because in most of the veriT-files, the input formula is huge (and does not need any symmetry-instances).

I am still convinced the best solution is the following: have an object addSymmetry in expansionTrees.algorithms which gets an expansion sequent E as input s.t. Deep(E) is a tautology modulo symmetry (without checking this of course) and return an expansion sequent E' s.t. Deep(E') is a tautology. The algorithm is simply the following:

for all s=t s.t. both s=t and t=s occur in E {
  if s=t occurs negatively in E and t=s occurs positively in E add s=t -> t=s
  if s=t occurs positively in E and t=s occurs negatively in E add t=s -> s=t
}

Then do not generate _any_ symmetry-instance in the veriT-importer but just apply addSymmetry as a post-processing. This will generate a set of symmetry-instances which is (sometimes considerably) smaller than anything we have generated so far. This should be doable efficiently (note that an atom occurs positively in E iff it occurs positively in Deep(E)).

The set of symmetry-instances thus generated is not guaranteed to be minimal in a semantic sense but for any further optimization (which comes to my mind) one would have to make tautology-checks or look at the propostional resolution proof.


`updated or deleted` ?


You're the best! :)


This is a new JIRA. Alternatives Layouts doesn't work on UF.


Thus far I don't think we put any v3 components in sbin but it seems fine in either location. Is it only useful to privileged users / processes?


sszdf


Thanks David. Could you send me a pull request?


You can just do `*` instead of `button` here (cfr. other widgets)


move this method to WorkbenchLayoutImpl


Shouldn't this list be in the reverse order?

$breakpoints: (
	phone-portrait: 22.5em, // 360px
	phone: 30em, // 480px
	phone-landscape: 40em, // 640px
	tablet-portrait: 48em, // 768px
	tablet-landscape: 64em, // 1024px
	desktop: 85.375em, // 1366px
	large-desktop: 105em // 1680px
);

I notice it matters when I start to add my front-end display of the breakpoint. Not sure if anyone else has noticed any conflicts in this ordering or not.

Also, the last comma isn't necessary. Just an extra character :)


make this change in order to encapsulate it.


Oh, I missed that those are two arrays.


BTW, it would be better to store this in the `l2tp_context`, as the use of global state should really be minimized. This enables one to have multiple context bound to different interfaces within the same application (not needed at the moment, but it makes for a nicer API).


Should add `// Return false to avoid default form submit behavior` for completeness


Why not push this entire check into `initialize_layers`? It looks like `_output_layer` isn't even read.


Okay, es sind zwei Änderungen, die getrennt betrachtet werden können:
Erste Änderung soll ermöglichen, dass Aktionen ohne Parameter genutzt werden können. Das ging aber vorher auch schon :) Du hast das jetzt mit pop in zwei statt drei Zeilen gelöst. Finde ich nicht schlecht.

Der zweite Teil ist, zuerst zu schauen, ob es in der Ziel-Funktion überhaupt genügend Parameter gibt. Das verstehe ich für Funktionen wie pjsip_handle_events, wo gar keine Parameter übergeben werden.
Dann sollte man Deine Änderungen als ersten Schritt ansehen und alle Aktionen darauf hin anpassen, dass bereits gesplittete Argumente ankommen. Die Definition der out-Aktion wäre dann z.B. nicht
def get(parameters):
sondern:
def get(pin, start_value, end_value, duration, stop_pin):
Das führt aber zum nächsten Problem, dass es die out-Aktion gibt (verarbeitet die ersten drei Parameter) und eine fallback_out die alle fünf Parameter verarbeitet.
Das Splitten des Parameter-Strings wollte ich den Aktionen überlassen, da es innerhalb der Aktion Sonderheiten geben könnte.
Könnte man aber auch "auslagern" in die SingleAction Klasse und geordnet der Aktion übergeben. Macht das Problemmieren der Aktionen für aussenstehende eventuell schwerer, aber die Programmierung insgesamt sauberer und nachvollziehbarer.

Weißt Du was ich meine?


Major Uberfire change. The old version has a simple panel inside the header panel. In order to create the docks, i've change it for a dock layout panel.


Thanks @Homebrew/owners, Appreciate the opportunity & trust.


rootContainer is the DockLayout Panel that has in the center the drag boundary panel.


using dpkg command?


Nice job Brittain.  Thanks for this.  Feel free to add other services such as gunicorn/etc... as you think of them.


This only add the south, west and east docks if the docks project is on the classpath.


the workbench.java refactoring.


if(contador1==true && contador4==true && contador7==true){
			Application.LoadLevel("Velha");

		} if(contador2==true && contador5==true && contador8==true){
			Application.LoadLevel("Velha");

		} if(contador3==true && contador6==true && contador9==true){
			Application.LoadLevel("Velha");

		} if(contador21==true && contador24==true && contador27==true){
			Application.LoadLevel("Velha2");

		} if(contador22==true && contador25==true && contador28==true){
			Application.LoadLevel("Velha2");

		} if(contador23==true && contador26==true && contador29==true){
			Application.LoadLevel("Velha2");

		}


old method from workbench.java


TODO: we have to write the conding rules somewhere under docs/*.rst.


Uberfire new class in order to avoid the uberfire-docks project dependency in workbench client.


ADD URL FOR REPOSITORY.


Sabe CDI problem of WorkbenchLayout interface. Needs to use only one mechanism.


Some notes I saw from the macports

```
  php53 has the following notes:
    PHP 5.3 has reached end-of-life. Please upgrade to PHP 5.4 or newer. The newest stable version is 5.6.

    To learn how to update your code, please read the following guides:

        http://php.net/manual/en/migration53.php
        http://php.net/manual/en/migration54.php
        http://php.net/manual/en/migration55.php
        http://php.net/manual/en/migration56.php
```


I gather Peti's point was we have no binaries for stdenv on master now (considering the fast "static" cache).


I agree. People should be happy about the changes, unless someone uses weird workflow. There is always someone...


How did you decide to treat an empty select list as a select all?


With High DPI, this change causes the column header row to render too short and cut off part of the text. Setting it back to AutoSize renders the header properly.


This applies for all help pages: Links for related pages will need to be inserted when we get the URLs settled. Links to GJ pages will need to be updated to wttf pages.


This could be a little brittle. It's worth running this by Jeff/Mark (can't find their github id's) so they know you're taking a dependency on their version formatting.


I think this intro is a good set up for the quest.


test comment


I think that you can remove the "to begin."


does this flag get set if the "SELECT FROM" case is encountered?


Oh. It worked for me both ways. What's the backtick supposed to do?
I'll change it back and submit another pull soon. Thanks for this project, btw. Helped me get my app going fairly quickly with all the features I was looking for. I'll have to look into webpack - does it have "archetypes" or starter-templates of some sort?


Well that's like the after playback feature, it took some adjusting but I think most people are happy with it now.


Error Prone doesn't run on jre 1.6 anymore. (It still supports -source 6 -target 6, though.)

Did the discussion in #5 resolve this?


Not sure if the semver module supports this, but I could see iterating over each element from the first line and trying to match on a version, otherwise throwing an error of some sort.

but otherwise, lgtm


does case matter here?


I'm concerned about performance implications of this change.
The point of this code is to deal with the rare case where the input doesn't end with a newline.  Your change here will make `cmark_strbuf_truncate` get called on every line that DOES end with a newline (and that's most lines).  I prefer the original approach, just checking to see if the line ends with a newline and adding one if it doesn't.  Only we should check to see that it ends in a CR or NL, instead of just checking for NL.


I think maybe the present tense would be better here - want  instead of wanted.


if(contador1==true && contador4==true && contador7==true){
			Application.LoadLevel("Velha");

		} if(contador2==true && contador5==true && contador8==true){
			Application.LoadLevel("Velha");

		} if(contador3==true && contador6==true && contador9==true){
			Application.LoadLevel("Velha");

		} if(contador21==true && contador24==true && contador27==true){
			Application.LoadLevel("Velha2");

		} if(contador22==true && contador25==true && contador28==true){
			Application.LoadLevel("Velha2");

		} if(contador23==true && contador26==true && contador29==true){
			Application.LoadLevel("Velha2");

		}


remove "will" ...


If I understand correctly, this change means that we'll ONLY be testing CRLF input.
Really we should test all the line ending variants, shouldn't we?


btw the `len(line) < 3` can be also tricky, for example `up` is a valid key which you might want to remove...


Make sense, I guess. I noticed that even if nothing is selected by clicking space bar it will select item so, it should be fine for people who use keyboard to navigate.


Seems like a reasonable solution. PR? :)


That's progress, but I think stdin and TTY should also be connected (so that interactive usage is possible). Also Cauldron should just forward the exit status of the child, otherwise it's hard to use it in scripts. We should instead report our own error codes starting at 128+ to prevent clobbering.


Olá @MarceloGouveia77. É quase isso. São só dois detalhes: 1) em vez de retornar OK, que tal retornar o resultado da função ````inserir````? Assim, caso ela retorne algum erro, isso será repassado para quem chamou a função ````inserirNoFim````; e 2) para inserir no fim, eu tenho que passar ````lista->tam````, pois ````lista->tam-1```` irá adicionar na penúltima posição.


I would, but Swift doesn't have a proper numeric tower, so this would start accruing casts!


> All of that could be removed if we can just add all "overloads" directly to their container.

Well this is the correct thing to do.


Я совсем запуталась...
> предлагаю сравнивать списки, полученные от разбиения строки по табам.

Таким образом, берём список списков и по каждому значению одного из списков гоняем весь второй? Неэффективно.

> Функция, которая умеет сравнивать две строки, будет гораздо нагляднее, хоть и придётся отказаться от простого условия x not in islice.

В какой момент создаются две строки?


I actually prefer the `-= 1` style, myself!


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 18](https://teamcity.labkey.org/viewLog.html?buildId=251928&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 2 (1 new), passed: 24 Build time: 00:31:33
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

```


Probably would put this down the bottom


Probably would put this at bottom of file, it's a bit prominent at present when you view in raw mode


Released 1ec142a


> But I have no idea in how many places we would then have to change `getDirectMember()` to `getDirectMemberForBackend()`.

Well the thing is that if you use the overloading stuff the way it is intended to be used, the lookup algorithm will always return the "abstraction".


Nope, I just learned all notes, it's more like memory training, and I need some time to be more comfortable playing any of these in one take.


need a comma after Debian


Beim Git-Overlay braucht es eigentlich kein Digest mehr für das Ebuild selbst, da die Integritätskontrolle von Git selbst gemacht wird. Wenn man `ebuild ... digest` auf ein Ebuild im Repo selbst ausführt, sollte dieser eigentlich auch nicht generiert werden. Ich würde mich daher fragen, woher die Ebuilds kommen ("give credit where credit is due?").


php 2 good


My mistake. I didn't notice, you are creating our Address here. Let it be. I didn't use to pass null.


@ignatov is there a way to detect if these are present at compile time and error out if not? For people who might "miss" the readme :)


When will you be back?


ganz sicher bezüglich diesen Keywords? ;-)


> php 2 good

true


Is this test depending on the change to `_meta['root_url']` in `test_cache_key_method` above? Just for portability, I'd have this test pass root_url twice and assert that the class changes properly each time.


abgesehen davon, dass php-4 schon lange nicht mehr unterstützt wird, erledigt die `php-pear-r1` eclass dies selbst


In future, plugins will be able to NOT handle events, and more than 1 plugin will be able to register for the same event ( for now, we handle just 1 plugin )


omg lewd


Yes, it should be escape (according to the spec), and unrecognized $subst should be either an error or empty (not sure). Added a story for this: https://www.pivotaltracker.com/story/show/95453300


> Also would be nice to use a different HTTP library that handles the decompression.

Here be dragons. More dependencies (and packaging in some environments), or a lot of testing to completely switch, which moob can't really afford IMHO.

Some OOBM devices are... peculiar, when it comes to their implementation of HTTP.


* [1022]


I don't think this is sufficient to guarantee a consistent view of the query. For example, suppose the query is RUNNING when this line executes. Another thread could call `finished()` and then the QueryInfo you return will say state=RUNNING, but the endTime will be non-null.


microphone


nitpick: parenthesis around the `debug` calls.


static import


There's no reason to check that gain is less than 1. Gain > 1 should be acceptable as well in case the user wants to amplify the signal.


The intent of the block was to make sure everything related to any given transformation is self contained in its own scope, and therefore freed before moving on to the next one. So in this case, without the block, "pSelect" would unnecessarily remain around until the method exited.


Netty automaticly uses the either the host-less redirect form (/foo) or takes the value of the 'Host' header in the redirect. This is what most webcontainers do and adheres to the HTTP standards


Grund wieso dass man keine Digest für die Ebuilds mehr möchte: sie machen das Mergen sehr mühsamen


Hi @sschaef, it seems this broke scala/scala's IDE validation: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/967/console

cc @adriaanm @retronym


This introduced a bug. The song_exists column is not in any of the tables in this SQL statement.


Good question!  I looked at the logfiles from Tableau and saw it in the query that it generated and passed on to the Progress runtime


[Deployment available online](https://s.brightspace.com/lib/vui/dev/83d7b2f1e1dc9aac0d17e01a618699947b77c12b/valenceui.css)


You might want to rename these parameters. I know, copy/paste strikes again! :-)


Fixed!


Please, return HDPI sources. We need them.........................


I have extracted out this part, and the returned value is initialized with an Response.ok, so it never is null.


yes - I agree - I'll do that.


@mpc-hc/developers: I have repushed with changes based on @kasper93's comments (I hope I haven't forgotten any): https://github.com/mpc-hc/mpc-hc/compare/develop...Underground78:da7baed.


[Deployment available online](https://s.brightspace.com/lib/vui/dev/cd466e822e9e934a3eeffe2ab869fec810b2b891/valenceui.css)


This is does not calculate the inverse of the matrix "data", however, it calculates the identity matrix.


Hi Anders,

All updates seems great, but are you sure that in this one the ASCII isn't required for this particular codec?


yes, it was in the documentation, so it is matched with the documentation (docs are always telling the truth ;))


@Kasper93: In fact it was an old bug.


Add a new line in between


Works for me, and I don't know what you're building. Try make clean, if it doesn't help make sure your manifest is up-to-date. If you're building something else, sorry, I can't help you.


Oops, no


Fix the indentation.


@Kasper93: Ok with this?


I have some free time, I'll do it now.


Is this the type of thing you meant, as far as DRYing?


@nbolton
Not sure what you are asking?

Is "_NXArgv" only defined in 10.8 and above?


Ля ля ля :)


2 в конфиг


@kasper93: On a side note, I'm not getting any autocomplete for @ anymore on my repo so I'm not sure if it got broken or if my mind made it up.


I have never seen lower/mixed case SQL from progress, but you are correct that its a good practice to ignore case


Never commit keys.


Thank you for your kind response, I'll try to add more details to my next commits.
As for your question about item 2978:
>Made with love under a warm light. His strength is cozy and warm.
>MHP + 500, Each 10 seconds recovery 300 HP


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 19](https://teamcity.labkey.org/viewLog.html?buildId=251930&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 25 Build time: 00:33:04
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


[Deployment available online](https://s.brightspace.com/lib/vui/dev/2c6dd7e65a47e8fa1666b76e74bbf79569cdf841/valenceui.css)


Ok. Assuming that is all of the V9 callbacks I think it's fine.


[Deployment available online](https://s.brightspace.com/lib/vui/v0.10.5/valenceui.css)


Same here on L74 and L75, Don't commit the keys and access tokens of the demo applications here. It's best to refactor this to a seperate file and take the values of the strings from there.


This logic doesn't quite work, in my testing `skip` get's set and never cleared.  A think a simpler, more readable, way to do would be to just add an `else-if` block for this special case.  Or perhaps calculate `skip` each time through the loop and drop the hunk which clears it.

```
boolean_t skip = (omit_since_boot && cb.cb_iteration == 0);
```


The page impayees.php has been renamed into mergepdf.php because it now works for all invoices whatever is status of invoice.


30 выносим в конфиг с настройками


Последний return можно не писать


Right. I tested on older build with different configuration and it was working (something else triggered invalidation), that's why I though it is new.


*rain


Good Morning, Toni,
Agreed. Sorry for the late response. There's a family emergency & 2 of
weeks of PTO; I couldn't work for the past 3 weeks. I can definitely make
these recommended changes but needs couple of days. I need to wrap-up other
work and work on it.

Thanks

Lava

On Tue, May 26, 2015 at 3:07 AM, Toni Moreno <notifications@github.com>
wrote:

> Hi, @lbasavap <https://github.com/lbasavap> , about enable/disable map
> perhaps you are rigth.
>
> I think we are agree that we can do 4 improvements.
> Attribute Naming
>
>    - disconnection_graphite_after => graphite_force_reconnect_timeout
>    - cache_refresh_interval => cluster_map_refresh_timeout
>
> Performance
>
> String str = new String(String.format("%s %f %s%n", node, value/n, SDF.parse(sample.getTimestamp()).getTime() / 1000));
>    logger.debug("Graphite Output Average: " + str);
>  out.print(str);
>
> Cluster map improvements
>
> Add other entity to the cluster map , at least DataStore and ResourcePool ?
>
> When could you have ready a new PR with this 4 changes? I could also do it
> if you prefer.
>
> Thanks a lot !!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SYNAXON/GraphiteReceiver/commit/6020b67bfba48f74675cda40e4b9c38089c5d4b2#commitcomment-11360830>
> .
>


I am building this: http://forum.xda-developers.com/galaxy-s3/development/5-1-x-cyanogenmod-12-1-t3066864
I also first thought the problem would be on my side, so I re-setup my build environment completely from scratch (and I still get the error): I created a completely new virtual machine, downloaded the complete sourcecode, the manifest file, etc. Everything by following the guideline, I did no custom stuff.


Куски этого метода совпадают с кодом из предыдущего метода. Это можно было б переиспользовать.


rax retry tests


Will check tonight


@millerdev oops, sorry that's really annoying! I guess this is why it's worth looking over your commit carefully and discarding irrelevant changes like whitespace!


added doc


95077770-HVACTemplateLoadManage-4493 (mjwitte) - x86_64-MacOS-10.9-clang: OK (1650 of 1651 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


what I am saying is that people keep "trackers" around yet they can call dangerous APIs that don't work, like "listen", or mess with mWaitingEnvelopes. Clarification on "don't work": if for some reason a callback decides to call one of those APIs from within "recvSCPEnvelope", then we mutate mWaitingEnvelopes even though they won't be used.

It's basically more bugs waiting to happen. I'd vote for not exposing those outside of ItemFetcher (and force people to go through ItemFetcher all the time), we may find other things broken in the process.

Also, instead of making a copy of the mWaitingEnvelopes vector, we should just make mWaitingEnvelopes a "unique_ptr" (therefore causing code paths that try to mutate it at the wrong time just crash)


keep our doc


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 212](http://ci.infinispan.org/viewLog.html?buildId=26959&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 7c512eefd8f786958257bf453d97be4cbf7773b2
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:06:19


Cool, thanks for clarifying - not used GraveyardActivation before.


Do the same thing in all engines with ENEE.


Is this right? Was receiving an error for my_name, so I changed it.


"elements and nodes" doesn't make much sense since Elements are a kind of Node. Is it supposed to be all Nodes, or just some subset?


maxNodeWidth


That is weird. I'll have a look immediately.


will be removed when finished.


is it possible to have a terminating ";" in the original sql statement?


Don't we need a named constant value?
Should it be rather called DEFAULT or RESET or UNSET?


95077770-HVACTemplateLoadManage-4493 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1656 of 1657 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Would also call it `exitFunc` here


Hi César,

In all honesty, I am not 100% sure. However, UTF8 can be considered a superset of ASCII. Therefore, the biggest risk with this switch is that `Encoding.UTF8` could interpret bytes av valid (UTF8) characters that would be considered invalid by `Encoding.ASCII`. Could this be an issue, you think?


Edit was made here


review completed


LGTM.

> On a side note, I'm not getting any autocomplete for @ anymore on my repo so I'm not sure if it got broken or if my mind made it up.

If only I could explain how this thing work. On this page I get only you in the autocomplete box. Though if I go here https://github.com/mpc-hc/mpc-hc/commit/7e1b5d8f0bdd7df69f80055fb33c5a8014f3dea1 I get more people and even "/developers" one.

Note that this is the same commit, but different context. It is little bit weird to me, because the same commit can have multiple different discussion attached to it.


Is it really return code 0 in case of log.Exit?


Replicated that in master of PI


LGTM.


95077770-HVACTemplateLoadManage-4493 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


this breaks compilation


1640-AddHVACPart1 (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


hi fujiy,
you have been faster :)
maybe you can also fix Append(object) - same prob
THX


Fixes #83


@dolfelt fixed by #3.


Hello Toni,
Thanks for asking me the question. To begin with, I should have provided
more comments; sorry for that.

Integer disconnectAfter =
Integer.parseInt(this.props.getProperty("disconnection_graphite_after"));

The disconnectAfter is just an Integer counter and tracks number of
graphite messages being sent to Graphite Server port. After each message
sent, we increment "this.disconnectCounter" local variable. once this value
reaches disconnectAfter (configurable) value, we reset Graphite Server
connection.

            if((this.disconnectAfter > 0) && (++this.disconnectCounter >=
this.disconnectAfter)){

                logger.debug("sendMetricsSummation - PerfMetric Counter
Value: " + this.disconnectCounter);

                this.resetGraphiteConnection();

            }

Why we reset connection: In the backend we have multiple Graphite Server
Nodes and load is being distributed via AWS Elastic Load Balancer (ELB). If
we don't reset Graphite Server connection, by default, ELB always route
Graphite messages to a particular node. As a result, we have noticed severe
performance issues. If you wish not to reset server connection, either
remove disconnect_graphite_after attribute from graphite.xml file or set
this value to "-1".

Please let me know if you have suggestions.

Thanks

Lava

On Tue, May 26, 2015 at 3:28 AM, Toni Moreno <notifications@github.com>
wrote:

> Hi @lbasavap <https://github.com/lbasavap> . I'm still confused about how
> are you computing the reconnect time.
>
> What exactly means disconnection_graphite_after= 600000 ? ( seconds ? , ms
> ?)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SYNAXON/GraphiteReceiver/commit/6020b67bfba48f74675cda40e4b9c38089c5d4b2#commitcomment-11361181>
> .
>


yes, good idea


Better to keep it consistent within the same file. We'll do a mass refactor to fix everything, then ban the old one.


Thanks, I think I shot myself in the foot with this one.


Suggestion applied. Thank you ;)


Small typo so that all search engines share the same interface


oh nice- I'll need to make the same change here:  https://github.com/jdanyow/aurelia-breeze/blob/master/src/promise-adapter.js


ok.
but in general - the kernel driver vc4 functional ready or no? i'm trying load linux from my building kernel - but only have black screen - or system stuck while loading..


Please change publication time to 6/2


Madhura,
since this commit, testing with Chrome 43 on Windows 7, with PHP 5.6.3, on the login panel I only see a checkbox "I'm not a robot". Before this commit, I get a series of letters to retype as a challenge. Is this expected behavior?


No. Not ready.


It looks like the check is `if($delayWhileIdle != '')` rather than `is_null()`


@erjohnso Thanks.  See 3a2d96decaa5eff9aa10457df812ccf22637f0d6.


Let's keep the delSpan here, because there is only one revision rather than two. I'll try to figure out why it's not rendering correctly.


No this is not the code being used. Please see the commit message.


Cleaned Up.


:(
thank.


@selimnairb Just pushed my updated code to the branch. Now django_irods is regarded as the point of truth for URL so bag_url context variable is constructed from django_irods. Note that reverse is not used to generate the URL, though, due to the fact that the customized IrodsStorage class (a child class of Django Storage class) needs to return the URL where the contents of the file referenced by name can be accessed. This url(name) API function defined in IrodsStorage class is the only place this URL is defined, so I think it should be good now. Let me know what you think.


Replace trailig `.` with `);`


Is the bytecode always compiled at this point?


Oh, of course :). Thanks @gr2m!


Why not maxSizeofInstructions = max(maxSizeOfInstructions, numInstructions)?


@watsonbox This is just a reminder that the problem has been fixed properly, and that your solution above had its own problems. You will definitely want to grab the new master and re-export all your histories. I suggest that you delete your entire fork and re-fork the project from the latest master, as described in the final messages here: https://github.com/Temptin/SkypeExport/pull/1


lgtm - ship it!!


I don't think it makes sense to define this in this way. I would say that:

    Every DOM Element has an associated <dfn>WebElement id</dfn>, which is a unique UUID string.

    A Javascript Object <dfn>represents a web element</dfn> if it has a single own property with key element-6066-11e4-a52e-4f735466cecf and value corresponding to that key which is a web element id, if the DOM Element represented by that id is not null and is in the current document.

    The DOM Element <dfn>represented by</dfn> an <var>id</var> is the Element that has WebElement id of <var>id</var> or null if no such element exists.

    When required to <dfn>serialize a WebElement [...]


I don't want to be pushy or such, but a lot of these problems come from the
key property of Q-digest that values must be easily arranged in a tree.
That is the source of the compactness of the Q-digest and the inherent
problem when you want to look at anything but positive integers.

Obviously, you can use offset coding to deal with the problem of negative
numbers, but if you really want to solve the problem, Q-digest is really
hard to extend.

Consider t-digest in such cases.  By starting with clustering as a core
concept, it avoids the entire question of interpretation of values as
bit-strings that have the trivial binary metric and allows you to use any
values that are (a) ordered, (b) have a useful metric and (c) can have an
incrementally computed mean (i.e. like real numbers).

The added benefit is that you get controllable accuracy so that you get
roughly constant relative accuracy (in quantiles) near the tails.

On Tue, May 26, 2015 at 9:13 AM, scorreia <notifications@github.com> wrote:

> Hi.
> thanks for the answer.
> If it comes out that we have time and find a solution, it'll be shared
> with pleasure.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/addthis/stream-lib/commit/34932a7ead83ef56ed8be36f4b6dfd280d404acd#commitcomment-11367824>
> .
>


it should, because the recalc method is only called if glyf table is loaded and recalcBBoxes is True. When recalcBBoxes is true, the glyf data is decompiled. https://github.com/anthrotype/fonttools/blob/afceb153cf315c561ab99919f64494e7c1fa6443/Lib/fontTools/ttLib/tables/_m_a_x_p.py#L44


Looks like this commit has some changes from the previous commit.


It's impossible, they are 2 different systems!


Jason, this is awesome :)

Congrats to you and the team!

-Katherine


ok, if you fancy that!


You can define your options also on circle web pannel.


#ÑOOOOOOO
![screen shot 2015-05-26 at 2 33 45 pm](https://cloud.githubusercontent.com/assets/163977/7820133/4f6576ea-03b4-11e5-9c8f-82981941e08d.png)
!


I blame the GitHub GUI client. I'll rewrite this history in a bit.


Suggest changing the name to "cloner" or changing the comment to be clear that this is not about copying type A to type B.


Yes but the webhooks are conflicting for some reason, it was the same problem with travis-ci i think there a fix but i'm working on SWI really fast so i'll look into it later.


tu iedes?


Actually assignment for week 7...


You have the main layout elements in place and it looks great overall. If you wanted, you could look closely at the template and make some minor sizing/styling changes to get even closer to the design. Nice work!


Now that `$delayWhileIdle` defaults to false, I think it may be best to remove the `if($delayWhileIdle != '')` check.


Hello,

Yes. I can confirm that even with PR #3, everything compiles with java 1.7 even with -source 1.6 -target 1.6


Look good to me.


@selimnairb This specific code review page does not seem to reflect the latest change I made. In case you have issues seeing the latest code change from this page, you can refer to my changes either from https://github.com/hydroshare/hydroshare/commit/87679c0aeb81244afeed5f630b0cc62611b8293c or from https://github.com/hydroshare/hydroshare/commit/87679c0aeb81244afeed5f630b0cc62611b8293c


@svanharmelen the double call seems like a good solution. Having the ability to get a VM by name and project is a nice to have, but not needed. Maybe a different PR?


https://github.com/iansltx/php-gcm/blob/master/src/PHP_GCM/Sender.php#L105

vs.

https://github.com/iansltx/php-gcm/blob/master/src/PHP_GCM/Sender.php#L263

I'll add a commit to standardize on the null (vs. '') handling to this PR.


Done!


The `baserepo` is just `http://pkg.jenkins-ci.org/redhat/`. You'll also want to explicitly enable it as well as activate key checking:
```puppet
  yumrepo {
    'jenkins':
      baseurl  => 'http://pkg.jenkins-ci.org/redhat/',
      gpgkey   => 'http://pkg.jenkins-ci.org/redhat/jenkins-ci.org.key',
      gpgcheck => 1,
      enabled  => 1
  }
}
```


Why don't you use iface?


Looks like I've got half a commit here. will fix.


So I would have to specify root as the context directory for each repo if I wanted to set the last one?


This should be an error.


Tenta assim:

```
SSInterpreter.exe "(command 'aqui)"
SSInterpreter.exe "(comment \"gabriela testando\")"
```


The code just above where you are touching is just like that, so it made more sense.


The way I'm thinking is null -> don't include the param at all, but the default is to include it and set to false. But it has to be an explicit null because the default changed in 4.2.2.


I think you can omit this - we may want to summarize later.


There was a small regression in `jt test mri ruby/test_time.rb`

```
  1) Error:
TestTime#test_big_minus:
TypeError: Truffle doesn't have a case for the org.jruby.truffle.nodes.rubinius.TimePrimitiveNodesFactory$TimeSSpecificPrimitiveNodeFactory$TimeSSpecificPrimitiveNodeGen node with values of type  java.lang.Long=1152921504606846976 java.lang.Integer=0 java.lang.Boolean=false NilClass(org.jruby.truffle.runtime.core.RubyBasicObject)
    core:/core/rubinius/bootstrap/time.rb:38:in `specific': Truffle doesn't have a case for the org.jruby.truffle.nodes.rubinius.TimePrimitiveNodesFactory$TimeSSpecificPrimitiveNodeFactory$TimeSSpecificPrimitiveNodeGen node with values of type  java.lang.Long=1152921504606846976 java.lang.Integer=0 java.lang.Boolean=false NilClass(org.jruby.truffle.runtime.core.RubyBasicObject) (TypeError)
    	from core:/core/rubinius/common/time.rb:40:in `at'
    	from /Users/brandonfish/Documents/jruby/test/mri/ruby/test_time.rb:139:in `test_big_minus'
    	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:888:in `run_test'
```


But we might need to compile the program?  Ie, call getBytecode() instead of accessing bytecode directly.


@SzymonPobiega I've come to the conclusion that we needed this to be explicit. It also seems like `TimeToBeReceived` needs to be separate since it doesn't apply to all transport ops (not relevant for defer). Thoughts?

Is TTBR a DeliveryGuarantee?


various NPE from ui stuff


like this one: https://github.com/ignatov/intellij-erlang/issues/596#issuecomment-105612466


Is the default message good enough?


"implement" not "impliment".


Thanks for the correction. I think for scripting named constants are generally not as useful as with statically typed languages but it may make sense if there would be a *general* "DEFAULT" value. Currently there is none - it's -1 here and maybe null elsewhere. Perhaps at other places there exists no "DEFAULT" value at all. I think the only "natural" choice would be null but all style methods should be investigated how they behave before declaring any constant.


@kyleabeauchamp @mrshirts @jchodera - There is a problem with whether or not `mbar.getFreeEnergyDifferences` returns theta, which seems to have originated with this specific commit from @kyleabeauchamp which "eliminates variable length returns". Specifically, this commit changed the *behavior* of the function (so that theta is always returned) without changing the doc string.

I'm not entirely sure of the history here, but this particular change (which was merged back in January) seems to mean that the doc string of `mbar.getFreeEnergyDifferences` is no longer correct, AND that you changed the API for this function from 2.1.0b0 (the current conda-installable version from pymbar) relative to what's available in 3.0.0, even though the documentation is still the same. Here's the doc string:

```
"""Get the dimensionless free energy differences and uncertainties among all thermodynamic states.

        Parameters
        ----------
        compute_uncertainty : bool, optional
            If False, the uncertainties will not be computed (default: True)
        uncertainty_method : string, optional
            Choice of method used to compute asymptotic covariance method,
            or None to use default.  See help for computeAsymptoticCovarianceMatrix()
            for more information on various methods. (default: svd)
        warning_cutoff : float, optional
            Warn if squared-uncertainty is negative and larger in magnitude
            than this number (default: 1.0e-10)
        return_theta : bool, optional
            Whether or not to return the theta matrix.  Can be useful for complicated differences.

        Returns
        -------
        Deltaf_ij : np.ndarray, float, shape=(K, K)
            Deltaf_ij[i,j] is the estimated free energy difference
        dDeltaf_ij : np.ndarray, float, shape=(K, K)
            If compute_uncertainty==True,
            dDeltaf_ij[i,j] is the estimated statistical uncertainty
            (one standard deviation) in Deltaf_ij[i,j].  Otherwise None.
        Theta_ij : np.ndarray, float, shape=(K, K)
            The theta_matrix if return_theta==True, otherwise None.
```

But here's the return statement in the older version:
```
returns = []
returns.append(np.array(Deltaf_ij))
returns.append(np.array(dDeltaf_ij))
if (return_theta):
     returns.append(np.array(Theta_ij))
```
versus now:
`return Deltaf_ij, dDeltaf_ij, Theta_ij`

This has resulted in some crashes for alchemical-analysis, since users who install via conda by default end up with a function which returns three variables, whereas users who install directly via github end up with a function which returns two variables. (https://github.com/MobleyLab/alchemical-analysis/issues/20)

I'll fix our issue in another way (by explicitly specifying `return_theta = True` so I get the same behavior from both versions), but I'd suggest that you guys resolve this by either:
a) fixing the doc string AND more prominently announcing the API change, or
b) make the function behavior consistent with the doc string

I've only checked this specific function, since it's the one we're using, but you might want to check your other functions and see if the elimination of variable-length returns made doc strings correct for any of the others.


> I'm trying to separate SASS and other precompiling stuff to another package. It also can solve your issue here.

That sounds useful.

> ... not supporting SunOS currently.

What platforms your project decides on is up to you but OpenSolaris is out there... so just a thought. Our project is in the works of going to IA since *node-sass* just can't keep up with the times for all platforms... I'm trying my best to keep this package/project in ours as I do like it's simplicity and feature set.

> Do you have some recommendations?

Not at this time because I'm dealing with platform migration issues at the moment.


Can i ask what this means? :-)


Yeah I noticed that too, it's indeed a bit weird.


Here you can just use '*' to designate all of the attributes


This is #3


I also have this issue. Please release a fix now.


I think the new docstring is consistent with what's happening.  The output is now *always* a tuple of length 3.  It's just that the second and third values might simply be `None`.  E.g., you could end up the following:

```
(x, None, None)
```


shoot... see, i typically don't use this damn built-in editor.. it just removed my first commit.. gah. hang on.


Score: 5/5

Great job. Just remember the star comment and you're all set to go


Why not to use `rstrip()` here?
```python
>>> '/foo/bar/baz'.rstrip('/')
'/foo/bar/baz'
>>> '/foo/bar/baz/'.rstrip('/')
'/foo/bar/baz'
>>>
```


OK.


Think we need a pre-req of COLL-02_Using-issues?


Done in 2b135fceef34feb66693846c89e4ea1e9b7b9790


Hey @crichid could you help out by suggesting a better learning objective?


@hyi This is fine from the point of view of hs_core, however the definition of the URL in django_irods.storage.url duplicates some of the URL prototype as defined in hydroshare.urls and django_irods.urls.  I'm not sure why django_irods.storage.url cannot call reverse to generate the URL as described [here](https://docs.djangoproject.com/en/1.7/topics/http/urls/#reversing-namespaced-urls).


We have a separate gem to assist with the OAuth handshake: https://github.com/coinbase/omniauth-coinbase

Maybe we should link to it here?


ship it.


`that she shell` should probably be `that the shell`


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: db_printview.php, js/db_structure.js


@jef-n should this fix be backported? The original commit which triggered this was backported to 2.8 so that branch also suffers this bug


Thank you for your kind response, to answer your question about why I used Item Name instead of Item ID:
Currently those items (Armor of Gray, Gray Helmet and Boots of Gray) is not available on our /db/re/item_db.txt, so I put a pair of slashes in front of the combo item, so it won't be processed.
But if someone found the Item ID for those items, please submit a Pull Request, or make a additional comment on this line.
Thank you.