Yes, once a variable from `$args` has been assigned a place in the parameter list it is removed from the `$args` array using `array_splice` which needs the index number. Without doing this, it causes a bug in situations where the argument could match more than one parameter e.g.

```php
class X {
    public function __construct(Y $y1, Y $y2) {
    }
}

$dice->create('X, [new Y('One'), new Y('Two')]);
````

In this instance, without removing it from the initial $args array, the same instance of `Y` would get passed incorrectly to both parameters.

Where it causes more problems is line 76:

```php
else if ($args) $parameters[] = $this->expand(array_shift($args));
```

This also removes the next available argument from the array. Without the array_splice before, this:

```php
class X {
    public function __construct(Y $y1, $bar) {
    }
}

$dice->create('X', [new Y, 'baz']);
```

Would also pass the Y instance as both parameters.


I kind of like having the dumped flat files so they can be checked and examined for bugs prior to load (rather than loading directly).
I think having a single script to dump all the SOLR files makes sense - 1 script for 1 specific set of files and purpose. Also, these files are mildly linked to support some simple joins (e.g. complex IDs in the template reactions and complex roles table). So I think it makes sense to print them all together.

It may make sense *not* to put the SOLR dump files into git, as these are merely reformatted data automatically generated by scripts.

On May 11, 2015, at 5:19 PM, Mike Mundy <notifications@github.com> wrote:

> This is the first step in getting to a common set of source files for building typed objects and SOLR tables. I think there should be a Print_XXX script that extracts the data from existing objects. Instead of one large script that does everything (DumpSOLRTables.pl) there will be separate scripts. That was the path we originally started down with the Print_Compounds.pl, Print_Reactions.pl, etc. scripts. The generated files are formatted so they can be imported by SOLR and stored just once in the Biochemistry folder. The SOLRDump folder can then go away. We can then add scripts to parse the generated files to construct typed objects.
>
> Does that make sense?
>
> �
> Reply to this email directly or view it on GitHub.
>


I didn't use this pull request but I believe the timezone issues have been resolved; if they haven't, let me know.  Have a fresh master up now.


Can we move this discussion to mail or open a new issue on github ?


This is a little confusing. rad rad rad but do different things.


Hi,

did not find out how to attach a file, so I sent you an e-mail with the KIWI config file.

I ran the KIWI via OBS, by putting the KIWI file to the package I sent you via e-mail.

Do .ova have to have a <machine> section ? I just changed format="vmdk" to "ova".

Best, Martin


@nfeske, @chelmuth : may you please rename this commit to "pci: ..." instead of "usb: ..."


What the hell is happening!@!@! i don't understand this!!!!!


Lets move to e-mail.

Best, Martin


Commit + push worked fine. Beer time..


It's normalized at insertAtDepth:

https://github.com/mozilla/shumway/blob/master/src/avm1/lib/AVM1MovieClip.ts#L179


Better to handle the missing poster URL case up in the JSP level, rather than hard code the default image URL down in the java code.  This makes changing the default image trivial and easily accessible to the designer working on the page.


Hi Jonathan,
as requested here my comments:

Looking on code the package should work.
What I miss in Makefile are the following parameters:
PKG_VERSION, PKG_RELEASE, PKG_LICENSE, PKG_MAINTAINER
This parameters are supported since new LuCI directory structure.

I also miss minimum the po/template/*.pot file so everybody can help to translate the app.
If you are non English speaker directly provide the *.po file for your mother language.

I think it's not a good idea, to use 2 configuration files, Keep it simple!
Various existing OpenWrt daemons supporting/expecting UCI configuration.
Why provide a LuCI app, if configuration via this app is disabled ?

@jow any other suggestions

Christian


Dont forget to break the initilization lists. And then
```c++
{
}

// NOT
{}
```


Command `autoreconf -i` creates these files, so it I think it is safe to ignore them.

Maybe we should also remove them from git tracking. The same goes for `aclocal.m4`, `Makefile.in`, `ltmain.sh` and `install.sh`. What do you think @a-detiste?


I love to geek out


@tadast: Thanks. Fixed in dab17bf4a3214dcacde8db43cd32bc0b1dd1409b.


Better to keep the movie poster URL data null if we don't have it.  This gives us more flexibility in how to handle this case on the JSP side.  For example, perhaps the designer will choose to not display any image in this case or might want to change the empty image URL to a different value at some point in the future.


Quantità mettiamolo in RigaOrdine tanto non serve in altre situazioni


It's probably not ideal. GLM used to have a half type implemented as a class so it wasn't a POD like any other types that tvec* could take. This caused a lot of troubles with GLM swizzle operator implementations...


I changed the commit.


Done in commit 90e7e64.


`AppQuery.cs` should have

```
- public AppQuery Model (string column)
+ public AppQuery Model (string column = null)
```


Vãi quên :+1:  :]]]


Could you explain, perhaps in the docstrings, what it does if strict=False and why you would want to do so? This could easily get confusing for future developers trying to reuse (or debug or extend) these functions. Thanks


Why limit it?


suggest => Suggest


:ok:


To the top.


Okay it displays the architecture... not wrong to have that in the build log^^


We want to avoid referencing UI-specific elements down in the business logic tier.  What we choose to display as a default image for those movies without a poster would be considered a UI level decision.


But even though `foreach` operates on a copy of the array, you can still remove elements from `$args` if you grab the array index as well.
```php
                foreach ($args as $i => $val) {
                    if ($class && $val instanceof $class || ($val === null && $allowsNull)) {
                        $parameters[] = \array_splice($args, $i, 1)[0];
                        continue 2;
                    }
                }
```
That would remove the need for the `count()` call. And if $args is always an array, you could add an array typehint to the param... so the `if` test really is redundant, because if it's an empty array, the loop will just fall through.


Can we add another test for when index name is set explicitly? (.i.e `.Index("someindex")`)


Hi! It seems like this changed made the sdcard read-only to all apps again. Is this the intended behavior? I don't see the same change on my Nexus 7.


done https://github.com/ResurrectionRemix/android_device_lge_g2-common/commit/931a81b83ebc49601a57adf096499ccebf27b816


Its only for devices that actually support the feature???
Or can be added to any?
On May 12, 2015 22:11, "Varun Date" <notifications@github.com> wrote:

> done 931a81b
> <https://github.com/ResurrectionRemix/android_device_lge_g2-common/commit/931a81b83ebc49601a57adf096499ccebf27b816>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ResurrectionRemix/android_device_lge_g2-common/commit/7aa218d6995c01c3ee229d41ec2bb2af6d7a7be2#commitcomment-11159017>
> .
>


Lun, I agree with nick that the only condition you want to check is "samples.isEmpty() && stats.isEmpty()". Also, please go ahead and remove all the checks against null and update the unit tests accordingly.


Standards are to preface references member variables with "this.".   (I don't think that's spelled out in the old Sun doc, but that's what we're using as convention.)


of course any


Talibà! ;)


OK thanks I'll add to my device tree too
Builds for it will start tomorrow :P
On May 12, 2015 22:13, "Altan KRK" <notifications@github.com> wrote:

> of course any
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ResurrectionRemix/android_device_lge_g2-common/commit/7aa218d6995c01c3ee229d41ec2bb2af6d7a7be2#commitcomment-11159047>
> .
>


Great pull request! ;)


Aw, thanks.  :)


QStringList can be forward declared.


stderr is not a variable and should not be used in shared(...). this also unbreaks compilation against musl-libc.


Hi,
I'm having some issues because of this change. I'm using assemble (0.4.42) which has a dependency on this module. Assemble automatically pulls the latest bugfix release from npm because of the way it is specified in the package.json (^0.2.3). To me this looks like a major change for just a bugfix release ... But I'm relatively new to assemble so I might be missing something ...

I was  wondering if you could create a new release 2.0.7 with Handlebars 3.0.x in it. If that's not possible maybe a new release of assemble should be made which has a dependency on assemble-handlebars v0.3.0 ...

Let me know if there's something I can do to help!


r+


@Diego-F-Aguirre DWMR (done with my review). looks good. press on!


Fair point! Well spotted, I'll update it.

The if statement was a bit of an optimisation. Not really necessary, but in cases where the array is more than likely empty then

```php
if ($array) foreach ($array)
```

Is actually faster than just running the array, I'll make the change and see


This isn't your code. but i wonder if we should move to a std interface amoung these drivers. Instead of ipaddress and public_ipaddress. ssh_host/ssh_ip and host/ip then component fqdn can always use the same interface of host/ip. In the ssh driver ssh_ip simply calls ip. in the aws case we put the check for weather to use the private ip in the ssh_ip function.

Aws
```
def component_fqdn(component, component_node = nil)
   component_node = component_node ? component_node : component_node(component)
   node['delivery-cluster'][component]['fqdn'] ||
   node['delivery-cluster'][component]['host'] ||
   ipaddress(node)
end

def ssh_ipaddress
  @use_private_ip_for_ssh ? node['ec2']['local_ipv4'] : ipaddress(node)
end

def ipaddress
  node['ec2']['public_ipv4'] ? node['ec2']['public_ipv4'] : node['ec2']['local_ipv4']
end
```

There would be some additional plumbing doing things this way but I think it could lead to a cleaner interface. And fewer switch attributes.


@wkennington Can we revert this until you have something working on darwin? As of now it's just broken.


Please submit these changes.


This will help newcomers a great deal.  Thanks for adding it!


This "from" is what cause the confusion.

With GLM/GLSL radians and degrees are defined as such:
float degrees(float radians) and float radians(float degrees) so the function name shows the action applied

The idea to call is "angle" of maybe "toAngle" is to show that you are created a angle typed object from the input.

This is actually consistent with your other overload.


Since this is part of our dstu2 documentation, link to the dstu2 ballot documentation.  http://hl7.org/fhir/2015May/search.html#reference


No problem. :) (You must be getting flooded with these notifications, lol.)


Compile error here:
```
gulp-notify: [Compile Error] /Users/Hai/GitHub/material-ui/src/text-field.jsx: Parse Error: Line 312: Unexpected token [ while parsing file: /Users/Hai/GitHub/material-ui/src/text-field.jsx
```


Ah, very interesting. Didn't realize that.


Try to avoid methods with multiple return paths.  Generally speaking, methods should return a single value at the end of the method.
There are a few exceptions to this rule, however.  If you end up with many nested if blocks, it might be simpler and more clear to break those out into the same level and return inside each, for example.


Volies dir "metòdic", oi? ;-)


Hmm, nevermind. It's not so easy to chain them all, since when we chain, we need a chain of trues as oppposed to falses.


Yes. Also, Joim and I discussed it and this was the result. Some points: CC is not very popular, Hackmons CC is becoming more and more popular, there are too many random type ladders that are too similar so adding Hackmons CC is not something I'd want. This change makes CC something much different than Randoms which should attract more users to it and eliminate the issue of too similar formats.


Why have you removed all the "!" "." ?


saw approval from jedmccaleb
at https://github.com/jedmccaleb/stellar-core/commit/265615ef0f5981baf79f974dca375ab22e11f92f


merging jedmccaleb/stellar-core/master = 265615ef into auto


jedmccaleb/stellar-core/master = 265615ef merged ok, testing candidate = 4f3f4053


But first it caller has to have VaultPermission.LOAD_EXTERNAL_STORAGE_PASSWORD check passed (line 67).


I am pretty sure this is broken not sure what exactly is the problem.
(Vector is out of range or something of that effect.)


Since we're pushing the empty poster logic up, we want to only return null values in case the posterURL value is an empty string.  This makes life easier for callers of this method since they only have to do a single check for null.


Please fix indent.


Pretty sure that would break linux. It should be pretty simple to fix given
5 minutes and assuming I understand osx see now.

On Tue, May 12, 2015, 09:46 Shea Levy <notifications@github.com> wrote:

> @wkennington <https://github.com/wkennington> Can we revert this until
> you have something working on darwin? As of now it's just broken.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159098>
> .
>


Same


Was curl broken before?


We should use a more standardized format for our dates.  As a bonus, Elasticsearch recognizes this format as a date/time.


Looks like I applied the load class to the wrong element which broke it. I
pushed latest changes. There's still a bug thats applying the buttons to
the theme grid.

On Tue, May 12, 2015 at 9:04 AM, Matt Cromwell <notifications@github.com>
wrote:

> Ya, I downloaded the Zip from the theme branch, I'll work at it again
> today so I can do my committs from this merge (as soon as Devin merge's it).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WordImpress/WP-Rollback/commit/5e329e3682d3c5918b7173b303f6796ed60f800e#commitcomment-11158312>
> .
>


change javascript canvas variable from getElementbyID to querySelector


Avoiding multiple return paths.


Sure ;)


Already pushed f168973bfd65f64580a06376e4ef7b3731d4cb75. Testing now if this breaks on Linux, in which case I'll revert.


Just to show some numbers, with `if ($args) foreach ($args as $i => $arg) {` using my benchmarks, test 3, gives 0.206 using 10000 on test3. Without the if statement `foreach ($args as $i => $arg) {` it's 0.2205, which isn't a trivial difference (Ok in the grand scheme of things it is, but as a % is quite high for just having that extra if in there).


Better to declare these constant values as static final variables.


I'm not positive, but I think the checks being made in this.state should be moved to the render function. You can declare all of the variables you need within render, and check if any of them are null to return a loader div while the stores load. There might also be some weirdness with having the kind of cached state variable separate from the actual state, but again I'm not positive.


As a convention, static methods should be grouped together (apart from non-static member methods) at the top of the class code.


Hi Marc, what step are you on?


I did this by hand & tried to make the lines about equal. The Racket preferred style is whatever DrRacket does, because that's "standard".


The timeline object is getting removed and destroyed.


curl works fine with the revert.


I vote for `sqr`, but won't be upset if we re-export.


I'll try and fix it before revert

On Tue, May 12, 2015, 09:52 Shea Levy <notifications@github.com> wrote:

> Already pushed f168973
> <https://github.com/NixOS/nixpkgs/commit/f168973bfd65f64580a06376e4ef7b3731d4cb75>.
> Testing now if this breaks on Linux, in which case I'll revert.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159213>
> .
>


I am currently testing UberTC in my Mako build.
So far everything seems to be good :)


Help


@eertugrul --- please see issue #95.


We should always be aware that clients can and will post garbage parameters to our web pages.  In this case we want to gracefully handle a) when "metadataID" is missing/null, b) when "metadataID" is not a number, and c) when the metadata ID doesn't actually point to a valid TheMovieDB movie ID.


Yay! Just an update, my company has been using this in production for about a month now and haven't encountered any issues since python-intercom 2.0.beta. Thanks for all the work you're doing!


Try "ant clean dist". It was fixed locally in this way.


Sorry, in some plugins I need to extract and process true and false parts without parsing them. Could you please add a third parameter $parse=true to parse_else() and return parse_else($thing, $x, false); as EvalElse($thing, $x) replacement?


Yes, being able to ask a package is exactly what we're looking for, any
implementation would be fine. I still think meta should be able to be
evaluated on unsupported platforms though.

On Tue, May 12, 2015, 07:33 Vladimír Čunát <notifications@github.com> wrote:

> Hmm, maybe we should make meta evaluable even on unsupported platforms?
> Anyway, I'm unsure about this idiom. Perhaps we might make stdenv
> automatically add an attribute meta.isSupported instead or something
> (moving that code from release-lib).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/ee78173b213059e6c885dc0c4d3bf4da7d3cb229#commitcomment-11156071>
> .
>


What about things linking to libcurl which is what this patch fixes.

On Tue, May 12, 2015, 09:55 Shea Levy <notifications@github.com> wrote:

> curl works fine with the revert.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159265>
> .
>


What about this comment?


We rant into similar issue, which is what I was trying to fix with this change, but even though we didn't have the 'Main Campus' and it's guid, we still had a campus with id = 1. I've updated the migration to handle the case when you don't... https://github.com/SparkDevNetwork/Rock/commit/756ac98455b9dc270f0090477e70dabd3af354a9


I see now


event.cancelHoldPulse() doesn't exist (since ENYO-485 #939) and, as far as I can tell, there is no public API to stop the hold pulse before the end event occurs. You could call `gesture.endHold()` but it's currently marked private so I'm hesitant to suggest we add it here. @graynorton - any thoughts on that API since you worked on ENYO-485?


This redirect would be considered a "side-effect" of this method, which is a pattern to avoid.  Methods should be simple and only do what their name implies.  Callers of this method probably would expect this method to simply save the movie and not expect a redirect to be set at this point, so we should move that logic elsewhere.  In this case, the calling JSP would be more appropriate.


You need to clear your local cache, @renatomefidf :)


Oh, I think the real fix then is to add those optional packages to propagatedBuildInputs, no?


Oups, i only completed the one i used.
Did you plan to integrate the patches? If it's the case i can make a pass on that.


Yeah, I had already fixed it, but it looks like it didnt get into the commit. Fixed in dff6083 and at f14301b0 (in a single commit)


I can't check it now, but it seems like the buffer will be freed even when the function succeeds.


Since this page has only one action, and the logic for rendering the page is the same whether or not that action is called, we can really simplify this page by pulling out the handleAction() method entirely.


Use `grunt-assemble@0.3.0` (latest). Since you're using `assemble@0.4.42`, you'll need to update your dependency in your `package.json` and your `Gruntfile.js` to include `grunt-assemble` instead of `assemble`. Everything else is the same, sorry for the confusion.


Well, that was the old way of handling those issues. The problem is that
propagated build inputs makes it really hard for dependant packages go
understand their own dependencies and causes a whole mess.

On Tue, May 12, 2015, 10:01 Shea Levy <notifications@github.com> wrote:

> Oh, I think the real fix then is to add those optional packages to
> propagatedBuildInputs, no?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159365>
> .
>


Both showAll() and search() effectively do the same thing, so we only need one.


Fixed more thoroughly in parent, revert.


these changes lgtm


Can you be more specific? Propagating stuff like `-L` is exactly what propagatedBuildInputs is for, what problems does that cause?


Right, I will revert it soon. Thanks.


add a print statement here at line 36 to see what is being extracted from the fakeData
print e[:,month_index]


In particular, I don't see how patching the pkgconfig file makes it any easier for dependent packages to understand their own dependencies.


This seems to break compatibility with older version


I would expect it to be an unneeded overhead as well. Why not a PR though?


Awesome, thanks!


r+


This change was done to deal with "dupes" error that appeared when iterating over duplicate records - characters in this case.


yml :(

There is need to clear cache at staging too!


Thanks Sugan for the pull.

Only one change here. DEFAULT_ANIMATION is not aligning with other `=`s.


Oh, my bad, this is a different branch.


It seems from [JENKINS-28294](https://issues.jenkins-ci.org/browse/JENKINS-28294) that this message needs to be updated for JDK 7.

Also, the reporter objects to this magic fallback mechanism. I wonder why this was added in the first place.


The problem with the above is that every upstream project needs to
understand what platforms are supported by their optional dependencies. It
would make more sense if the optional dependencies carried their supported
platforms so that you dont have to make these assumptions everywhere.

On Tue, May 12, 2015, 07:30 Shea Levy <notifications@github.com> wrote:

> cc @wkennington <https://github.com/wkennington> who introduced
> shouldUsePkg in ee78173
> <https://github.com/NixOS/nixpkgs/commit/ee78173b213059e6c885dc0c4d3bf4da7d3cb229>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/82ba13111c72937b792edd40bcbebbda1d395c7c#commitcomment-11156013>
> .
>


We know initialize() will always be called at the top of the JSP page, so we can set our query value at this point and be guaranteed that "this.query" will be properly set at any other point on the page.

For our View pattern, the initialize() method acts much like a constructor would.  Unfortunately, the way "jsp:useBean" works precludes us from from using a constructor with request/response parameters, so this pattern is kind of a hacky workaround.


See #7826


I was trying to pipe the output of ceph-objectstore-tool to ceph-dencoder.  So when stdin is actually a pipe, the large read just hangs because the pipe will never hold that much data all at once.


"query" implies the method will query the database.  "getQuery" implies it will simply return the query value.


to be clear about my intent: I want us to be able to type "please test this" and have that perform a full build using packages created from that pull request.

Can you be clear why this will break the jenkins workflow? Maybe it makes more sense for you to make inline comments about your concerns with specific lines of code.


Great ;-) I've tried combinations from h*** and back and was just about to deep dive into core ...


The problem is that those propagated build inputs become secret
dependencies of Dependant packages that are hard to understand by looking
at the build file. Pkgconfig does not propagate them and only uses them for
linking when needed. Please dont add propagatedbuildinputs back as it just
causes weird upstream problems.

On Tue, May 12, 2015, 10:05 Shea Levy <notifications@github.com> wrote:

> In particular, I don't see how patching the pkgconfig file makes it any
> easier for dependent packages to understand their own dependencies.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159431>
> .
>


All the functions with commented GLM_CONSTEXPR call other std/glm functions which are not constexpr, otherwise it is applied where possible.


Нет, сейчас не критично. Я под новый вариант output скрипт быстро перепишу.
Проблема в том, что в новой версии вроде как изменен сам алгоритм предсказания структуры. Таким образом, предыдущая версия выдает не совсем точные предсказания. Так что лучше, конечно, как-то решить эту проблему...


I can have a look at that, doesn't autobuild depend on repoconf to install the things that it needs to build? it seems weird to have autobuild drive the process when it doesn't have enough information to perform the build.


Can you please point to a specific problem? And how is patching pkgconfig not a secret dependency? I can't tell that pulling in curl also pulls in, say, ldap, no matter whether I use a patched pkgconfig file or propagatedBuildInputs


No problem. I wish gtk would get it together. There is no reason for the behavior. It just started happening out of no where. What makes no sense to me is that the widest child widget of the GtkWindow is 800 something but it says the window is 900 something. Wtf? :unamused:


@dimitrinicolas Tu pourras faire le front ?


Indeed, that was my point about not merging yet. I'll update the PR

What I need help is how to append tiles from new documents. And you can't guarantee time order of the files (I.e. The files are in random time order)


Yeah, I would say it is worth posting. Good to know.


Why don't flush and close have tracking?


If it's in the package config file it doesn't become a nix dependency. It
won't be detected by a configure script and it won't be added in an
incorrect way to other pkgconfig files.

On Tue, May 12, 2015, 10:11 Shea Levy <notifications@github.com> wrote:

> Can you please point to a specific problem? And how is patching pkgconfig
> not a secret dependency? I can't tell that pulling in curl also pulls in,
> say, ldap, no matter whether I use a patched pkgconfig file or
> propagatedBuildInputs
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159521>
> .
>


@Memphiz What makes you think it's a deinterlacer error?
I don't think the "VTDecompressionSessionDecodeFrame returned(-12911)" can be related...


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.120](http://teamcity.monogame.net/viewLog.html?buildId=7233&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@LK4D4 WIth the latest commit I believe I took care of it.


So I think I have managed it at this point.  Using the BIS_fnc_MP, coupled with a new AH exception.
fdde656e2e6448eb2b53cabd117a1baefb0d9df0


Kill this last line?


Why do you increase the shuffle records written for spilled data?


Has this ever caused a problem? Note that not every package uses pkgconfig, so we can't just get rid of propagatedBuildInputs generally this way, so if there's a problem with the model (which I'm not at all convinced of), we need a better solution.


... and then line 72 *could* use `$arg` in place of `$args[$i]` ;)


I was modeling this after DiskBlockObjectWriter's TimeTrackingOutputStream, which doesn't track time there:

```scala
  /** Intercepts write calls and tracks total time spent writing. Not thread safe. */
  private class TimeTrackingOutputStream(out: OutputStream) extends OutputStream {
    override def write(i: Int): Unit = callWithTiming(out.write(i))
    override def write(b: Array[Byte]): Unit = callWithTiming(out.write(b))
    override def write(b: Array[Byte], off: Int, len: Int): Unit = {
      callWithTiming(out.write(b, off, len))
    }
    override def close(): Unit = out.close()
    override def flush(): Unit = out.flush()
  }
```


I forget to remove it.


That's because I have neither. I'm fine with just my nick.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/62267339


Could you reproduce the error?


Is this code applied on all platform?
Will this be fixed 1.1 stable version?


Now looks good :)


attribute name does not have quote.


Hey Christine
These are GREAT edits. i can't believe i missed so much :) THANK YOU. Can you please change a few things before i accept them

1. it will render the comments so please remove comments to me in the md page. instead, when you submit the PR, just add comments of things you want me to look at, are confusing, etc.
2. to make something code, please use `code here ` if it's inline code. If it's not inline code, you just need to indent it :)
3. the @crs piece is right. the $crs gives you the attributes of the raster. If you do DEM@crs you just get the coordinate reference string. so that is the only change that we need to change back.

if you can do those things, i'll accept it!
THANK YOU AGAIN - this is so great.

um - per the brick - i would think plotRGB might work BUT i can't tell you for sure as i have'nt played with the bricks yet much :) i dont fully understand why they're useful yet.


Also, while I'm morally opposed to all forms of autodetection, a priori I'd guess that it'd be *better* to autodetect some package if it is used by a library we're going to link to, to provide a more consistent picture. But we don't have to guess a priori, propagatedBuildInputs has been around forever and works fine (unless you can point to a problem?)


If you debug through the original code, you'll find that the loop just below here removes those chars from the list anyway, and so this change doesn't have the intended effect.


I would prefer to leave this as JavaAppPackaging. In particular, the Docker plugin takes the approach of running the service once (rather than using an init-style restarter), and leaves it to the parent to restart the container if/when it dies. So JavaServerAppPackaging is irrelevant to it.


You want to select the lowest version necessary for the project to build (the default 3.6 seems okay here).


I should add it back.


*couple


I don't think that is valid, comma separeted means separated by one comma...


I would trim all the auto-generated cruft. Spending time modifying auto-regerated
files is a common mistake (I lost 5 minutes editing `shellinaboxd.1` today)

Somme projects keep those around to make life of people building
manually "easier", so they don't have to track build-depedencies
but is more a source of problem.

> Maybe we should also remove them from git tracking.

Well, I should have do that before adding those to .gitignore :sweat:

I see in Makefile.in that the files under demo/*.css are also dynamically generated
I don't quite grasp the added value of this, why not just set simple symlinks in demo/ and push them in Git ?
```
${top_srcdir}/demo/usercss-0.css: ${top_srcdir}/shellinabox/white-on-black.css
        @rm -f "$@"
        ln "$?" "$@"
```

![diff](https://cloud.githubusercontent.com/assets/7994192/7593585/7b7e407e-f8db-11e4-9264-e393f21925bf.png)


:clap:


i moved this into the init function as it's not needed here


@Neverlord awesome, that was on my todo list as well. :white_check_mark:


how can autobuild work without repoconf? I see that that patch adds a build version, but I'm not entirely understanding what the plan is once you have that version. Where will it be uploaded to, what will fire off a deployment build, what is going to test that repoconf is working correctly? How will be the build number be passed to puppet-rjil, and what will puppet-rjil do with that information.

Maybe it will help if I provide you the full set of things that I am working on:

This patch to puppet-rjil adds a way to download a package repo locally for testing and also a way to build packages based off a remote/branch of repoconf.
    https://github.com/JioCloud/puppet-rjil/pull/569

This jenkins job uses this patch to build a package repo from scratch then fire off a deploy.sh job (although it's not quite done yet)
    http://jiocloud.rustedhalo.com:8080/job/pkg_test_build/

I'm happy if this work is throw-away work, but I'm blocked atm by tempest tests not running which are blocked by the ability to test these patches (which don't even seem to work atm). So, I went ahead and started work on making a way to test the patches from repoconf and autobuild required for getting tempest to work. I think it's probably 2-3 days work, so I don't mind doing it.


Wouldn't this error be in public Server ?


this behaviour isn't going to work when we want to move back from running state to menu and back again, there needs to be a way of only making a new instance once. we will have to think about this a bit more, because this doesnt look like it will work nice later


> 07:17:47 T:188542976  NOTICE: Open - bailing with bogus hints, width(0),
height(0)

Backend sends bogus data and hw decoder does not want to open. Fallback to
swdecoding is done and multithreaded ffmpeg is opened.

>07:17:47 T:188542976  NOTICE: CDVDVideoCodecFFmpeg::Open() Using codec:
H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10
>07:17:47 T:188542976   DEBUG: CDVDVideoCodecFFmpeg - open frame threaded
with 2 threads
>07:17:47 T:188542976   DEBUG: FactoryCodec - Video: ff-h264 - Opened

But it seems VTB is not really dead?

2015-05-12 19:13 GMT+02:00 Chris Browet <notifications@github.com>:

> @Memphiz <https://github.com/Memphiz> What makes you think it's a
> deinterlacer error?
> I don't think the "VTDecompressionSessionDecodeFrame returned(-12911)" can
> be related...
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/xbmc/xbmc/commit/e4e9f7a74b0f7e5ebf7ccced65778710be8bbd7d#commitcomment-11159541>
> .
>

--
                   Key-ID:     0x1A995A9B
                   keyserver: pgp.mit.edu
==============================================================
Fingerprint: 4606 DA19 EC2E 9A0B 0157  C81B DA07 CF63 1A99 5A9B


fast-forwarding master to auto = 4f3f4053


hmm - is this temporary ? our release channel will not release jruby-truffle with this in place.


Nice


Yeah temporary. Forgot to get around to it though - thanks for the reminder.


sometimes you have unnessecary includes in your cpp files, ideally you have all the includes in the .h file and they filter down to the cpp. for example, game state isn't neede here, as it's in the LoadingState.h file


:smile:


This nests the category attribute topic into the posts creation the proper way, using `accepts_nested_attributes_for :category`


It's kinda funny that Mac has the longest instructions. I would have thought it was all click-click-click. :)


This needs more work at the time being so it will be disabled, and it's one
of the first things that will be worked on in 1.2

On Tue, May 12, 2015 at 2:15 PM, volzhs <notifications@github.com> wrote:

> Is this code applied on all platform?
> Will this be fixed 1.1 stable version?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/okamstudio/godot/commit/b312df05616d18b0b8723f91fe7f71f9b831f004#commitcomment-11159582>
> .
>


This fixes ./gradlew clean copyInstall -xtest -xjavadoc  and ./gradlew clean build.  I'm getting an error running:
./gradlew dist

````
       /Users/dturanski/s2build/spring-xd/spring-xd-dirt/src/main/java/org/springframework/xd/dirt/integration /json/NewJsonPathUtils.java:35: warning - Tag @link: reference not found:  org.springframework.integration.json.JsonPathUtils
          javadoc: error - Error while reading file src/api/overview.html
         1 error
         10 warnings
        :api FAILED
````


:punch: :clap:


I think it does not work for statements unless we make some changes. I feel keep it this way it fine. It follow the previous logic.


I  highly suspect that this is actually worse.

You're creating a thread for each path, that's a LOT.

Also, the whole idea of a step function was to **spread the calculation over several steps** to ease the load, you did the exact opposite, might as well get rid of the step function and calculate the entire path upon construction.

I understand your drive here, you want path calculations FAST, almost instantaneous, but I don't think that's the way to go. I'm against just throwing more calcs per tick and hoping for the best, that is just more CPU load.

The way to go is optimizing the pathfinder and improving path-recalculation in such a way that path recalculation SLOW but intelligent to not be noticeable (double buffering, perhaps.). They key point here is SLOW, it's BETTER to spread calculations over ticks, it's much better for performance, and this ain't a micro-optimization. I am planning to do something about recalc once the base features are in place.

I think that the way to go is internal optimizations, not threading.
I'll work pretty hard on those once everything is in place.

I've read the code real quick, If I made the wrong assumptions about it, feel free to correct me.
Also, there's always the unexpected, it might surprise me and turn out to be faster, I doubt that though.


For example chromium, when pulseaudio used to propagate lz4 / lzo I dont
remember but a compression library. None of the chromium maintainers even
knew it had a real dependency on said compression library because they
always built it with pulse support. Turns out non-pulse chromium would have
never built. It's cases like this where propagated build inputs is really
frustrating, especially if you had many packages propagating like pulse.
Also, on Darwin you have dylibs which basically do the job of the PC file
in terms of specifying absolute linking paths to libraries. I'm working on
a global patch to fix all .PC and .LA files, probably in a somewhat similar
manner.

On Tue, May 12, 2015, 10:16 Shea Levy <notifications@github.com> wrote:

> Also, while I'm morally opposed to all forms of autodetection, a priori
> I'd guess that it'd be *better* to autodetect some package if it is used
> by a library we're going to link to, to provide a more consistent picture.
> But we don't have to guess a priori, propagatedBuildInputs has been around
> forever and works fine (unless you can point to a problem?)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159588>
> .
>


Yea, I didn't reset the seed on the Campus table when I deleted it.  Thanks so much!


@PeterPablo I have some (unverified) ideas:
- `Position` might be set using e.g. `set(0, 'DefaultFigurePosition')`
- the DPI might be different between both installs

At the moment, I would first focus on #542 (and related things) rather than figuring out those differences. Once we get such mocking in place, we can start to make all environments uniform.


Unneeded overhead? The pathfinder shall be able to calculate complex paths without delay! The CALCSPERSEC * MaxSteps limit per tick is what shall be rendered unneeded!

!!!1!!

!!

On 12 May 2015, at 18:05, "Safwat Halaby" <notifications@github.com> wrote:

> I would expect it to be an unneeded overhead as well. Why not a PR though?
>
> —
> Reply to this email directly or view it on GitHub.
>


I think we can refactor it later on if needed.


Hey @JorgeFerrer, it looks like removing this method ends up duplicating the required names that are properly included in fieldNames.  I just tested it to make sure, and now the English form has two first-names and two last-names.  I think we're going to need to keep this.


sounds good.


saw approval from jedmccaleb
at https://github.com/gmarceau/stellar-core/commit/6a4a92876908d08aa649670c13ef0c0ce003c930


merging gmarceau/stellar-core/prefetch-scp-items-2 = 6a4a9287 into auto


gmarceau/stellar-core/prefetch-scp-items-2 = 6a4a9287 merged ok, testing candidate = 8f65b0cf


Ah ok good point -- I was mis-remembering and thinking those close / flush calls got timed at some point. I wonder if we should just time these, to be safe?  It seems like it won't add any significant overhead, because they each only get called once.  FileOutputStream.flush() does nothing, but close() does manipulate the file descriptor.


I made an oopsy thanks for the fix.


Probably cleaner since it's using foreach now. I'll also add the type hints to closures you suggested


This repo stores the conceptual visual components and data management files for the application.


Cool! Works for me on one of my machines.  I'll close #319 when I go home and check on the machine from which I reported the bug.


But I WANT DELAY (I explained why above). I just don't want the user to notice it.


"non-pulse chromium would have never built" Did any user ever hit this?


I have a CEGUI error on MultiSelect property. Seems like it is not a Combobox property


…indicates…


The example doesn't matter, it is the point of the side effects it causes.


This is already done in defunct, so there's no need doing it again here.


Why does the spill's write update shuffleBytesWritten? Is this for consistency with current behavior? (this seems hacky)


cool


first commit


Thanks, now it's works. Please, add an example of this command in the documentation for the utility.


Does it make sense for TimeTrackingFileOutputStream to just take writeMetrics and outputFile as constructor parameters, and construct the FileOutputStream itself?


Yes, I was able to reproduce, much to my dismay.  I have no idea why the bug didn't crop up until that code was moved lower.  It SHOULD have errored.  As near as I can tell, there is no argument call in fn_savePlayerData, and the server doesn't compile the function, so the server should have full-derped when it was called.

Anyhow, everything else seems OK at this point.  Hopefully the bloomin' chopper will continually drop for people.


The example *does* matter, because a) patching .pc files can still lead to this kind of problem in principle and b) by necessity nixpkgs is full of heuristics that work most of the time that could be theoretically subverted, but in practice aren't.


can you release a new revision with this commit?
thanks


I think this is missing an "int" :)


import ordering


In a perfect world tangle would be a basic type and part of the common vocabulary, however due to compatibility with GLSL this sadly isn't possibly. In my code bases you see things like `rotate(degrees(1.345), vec3(1, 0, 0))` but never `rotate(1.345, vec3(1, 0, 0))` (which wouldn't compile) as it isn't explicitly stating what unit the value has. If you already have an angle instance use it directly `rotate(alpha, vec3(1, 0, 0))` and let the rotate function do its dirty conversion work.

Once the entire codebase switched to using the angle class consistently most radians() and degrees() calls just evaporated as they were no longer needed. At some point it just became natural that degrees() and radians() didn't simply convert a number, they created typed values that had semantic restrictions. There was never again a bug due to rad/deg mismatch and it even uncovered bugs where angle values were used incorrectly in computations.

With an angle() method taking an arbitrary number, you basically go back to square one. Sure, the correct way to do it then would be `alpha = angle(radians(x))` but it doesn't prevent errors from dropping the extra call: `alpha = angle(x)` would still be possible and potentially very wrong.

With `alpha = deg(1.234)` it is very explicit. It says "give me a number that is in degrees and I give you an angle with the equivalent representation".


Allright will implement it :)


Also important to note, if a package doesn't use the .LA or .PC files it
has no way of knowing to link against the build time dependencies as those
files are the only place they live. So if you patch both you would never
need to propagate because ld can't magically know the libs to link against.

On Tue, May 12, 2015, 10:27 Cody Opel <notifications@github.com> wrote:

> The example doesn't matter, it is the point of the side effects it causes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159767>
> .
>


alas this means there is now no way of exiting the loop (which you could do before by throwing exception).
the eventCallback.isReceiving() is called after the jp.getNextToken() which sits until the server actually sends the next event :-(


True. Maybe it would be more readable with the radians() and degrees() extractors being member functions or tangle?


Is there a reason not to just do "assert(taskMetrics.disBytesSpilled() > 0L)", which seems more consistent with what we do elsewhere? I'm just not sure this seems worth adding another dependency to the (already bloated) build.


why without variables as the method accepts map of variables :)


Should be text instead of 'content', sorry about that.


Done!


Was writing just after you posted, sorry for confusion.

Delay without user noticing? What sorcery. It is evident that performing the path calculation all at once (which is what I've done here, by getting Step to call StepOnce until MaxSteps is reached, or it returns) is faster that performing it a few times every 1/20th of a second, no matter the optimisations.

For example, Prison Architect, a game with potentially hundreds of prisoners Pathfinding, reported a dramatic improvement in speed when making the pathfinder multithreaded.

Depending on the implementation of async, for example in VS, a thread pool may be used to reduce overhead, I think. Please correct me if I'm wrong.

On 12 May 2015, at 18:25, "Safwat Halaby" <notifications@github.com> wrote:

> But I WANT DELAY (I explained why above). I just don't want the user to notice it.
>
> —
> Reply to this email directly or view it on GitHub.
>


Thanks! That helped cut out about 1000 violations, and I just finished the rest in 9525462045a3a80d313ca64038b56a1021c99ff6


I tried a similar thing previously, but for some reason whenever the session changed, I needed to refresh the page  in in order to get the new targets; which is why I separated it into 2 functions.


I see.
Thanks for your great works.


Affirmative.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.120](http://teamcity.monogame.net/viewLog.html?buildId=7233&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:19:10


on a second thought, let's check for contexts.isEmpty() too.


»…by the ID of the element« is a bit unclear regarding which element it refers to (as the same sentence mentions the element list), IMHO. Maybe instead of those two sentences (»The end of…« and »When an element…«) we could shrink it to a single one, something like:

»The end of the element list is signalled by the arrival of the first element that isn't a sub-element of the element with unknown size.«


Known Issue
1. Play speed issue on Avisynth encoding with MPEG-TS+H.264 video


Definitely does clean up the code, and makes it easier to understand.
--
Chike
On May 12, 2015 11:12 AM, Dominik Charousset <notifications@github.com> wrote:@outro56 FYI, I added fixtures to the unit test framework. Makes working with them much easier. :)

—Reply to this email directly or view it on GitHub.


updated via rebase to the original PR commit


Would a ChunkStay work?

On 12 May 2015, at 08:41, "Mattes D" <notifications@github.com> wrote:

> You can't - the a_Chunk can get invalid after the parent function exits, which will crash the server.
>
> —
> Reply to this email directly or view it on GitHub.
>


That's not true. It sucks, but the dominant paradigm is a) install all libraries/headers into global locations and b) search those locations at configure time to find deps. So if libfoo has an optional dependency on libbar, then the configure for my program can check for libfoo and then for libbar and use the result of those checks to decide whether to do -lfoo and -lbar, all without any .pc files. It would be very nice if that kind of automagic didn't happen, but as long as it does we need something like propagatedBuildInputs.


Do we need to consider adding UI for adjusting the language.properties in a similar way?


That's not the problem we are solving

On Tue, May 12, 2015, 10:35 Shea Levy <notifications@github.com> wrote:

> That's not true. It sucks, but the dominant paradigm is a) install all
> libraries/headers into global locations and b) search those locations at
> configure time to find deps. So if libfoo has an optional dependency on
> libbar, then the configure for my program can check for libfoo and then for
> libbar and use the result of those checks to decide whether to do -lfoo and
> -lbar, all without any .pc files. It would be very nice if that kind of
> automagic didn't happen, but as long as it does we need something like
> propagatedBuildInputs.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159935>
> .
>


»another value can be set by setting another value…« sounds a bit awkward, IMHO. Maybe something like »Another maximum width value can be set by assigning that value to EBMLMaxIDLength in the EBML header.«


My point is that we can't get rid of propagatedBuildInputs. So if there is a problem with propagating, this isn't the solution.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14815/testReport/) for this commit**


done in https://github.com/MediaArea/ebml-specification/commit/86246805df95852111f034c75e51d0daf9b30c92


Fair enough, will remove!


Great to know. Keep up your workflow. I like it ...


This broken build doesn't justify propagating dependencies. It would make
more sense to patch that configure script.

On Tue, May 12, 2015, 10:36 Shea Levy <notifications@github.com> wrote:

> My point is that we can't get rid of propagatedBuildInputs. So if there is
> a problem with propagating, this isn't the solution.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/26c37ded73ce084275d748be26887cf4023c91d6#commitcomment-11159955>
> .
>


Fair points


Anyway, if there's no actually-hit problem with propagatedBuildInputs, I'd much much much prefer we stick with it than switch to something new and untested (and, IMO, more ad-hoc). This change *actually broke stuff* (as did your 'modernization' of ncurses, by the way).


If you want to patch every configure script, feel free. In the mean time, propagating dependencies was added because it solved a real problem and solved it decently, and people continue to use it for that reason. Unless you're willing to trace down every reverse dep of every package that propagates and fix it, we're stuck with propagation.


fix in https://github.com/MediaArea/ebml-specification/commit/7befc9efed5557db0b275bcb83289f62c13f7a2e


To be honest I have no idea why 127 is mentioned as a special case. The other cases with all bits of the Element Data Size set to 1 are no different. I'd vote for removing that sentence.


We're using "fast" in two different ways.
If by "fast" you mean the speed of finding the path: The new code definitely finds paths faster.
if by "fast" you mean less burden on the cpu: The old code is probably much more CPU efficient.


Refactor AMQP_VERSION to use AMQP_VERSION_CODE.


Am I missing something here? Isn't the whole point of this to count historical ledger fetches per minute?


Also, Xoft mentioned mentioned about threads n' locks that made him suspect threading will not help that much in our case (I'll find the post).


I mean drop dlopen to gain portable support...


True, this was in the RFC draft but not in the spec. However I think by 127, if you store in a 1 byte variable integer you have 0b11111111 which indicates that the element size is unknown, thus 127 should be stored as 0x407f.


my English is ugly and cruel, just placed it to troubleshootings, will rewrite now


I guess it is an example. We can change "Note that" by "As an example, "?


rax retry tests


There you go:

>The pathfinder cannot be split into a separate thread, because in order for it to work, it still needs access to the chunk which means it would lock other threads out anyway. You'll have multiple threads, but they won't be able to execute in parallel.


What version of glibc is this deprecated in?


That's still a generic need (removing duplicates). We should not need a
unique method just for that.

--
Jorge Ferrer
Sent from my phone
El 12/5/2015 7:24 p. m., "Drew Brokke" <notifications@github.com> escribió:

> Hey @JorgeFerrer <https://github.com/JorgeFerrer>, it looks like removing
> this method ends up duplicating the required names that are properly
> included in fieldNames. I just tested it to make sure, and now the English
> form has two first-names and two last-names. I think we're going to need to
> keep this.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JorgeFerrer/liferay-portal/commit/0c1e275ad6acdb2f0312f4566e0f05fdaebaaf86#commitcomment-11159729>
> .
>


I had the DefaultFigureSize set by means of my other PR. This didn't help.
Unfortunately I seem to be unable to set DPI in octave. Do you also get an
error? See my mocking PR for code.
Yeah, I also want to get this in. That's why I spent quite some time today
on getting this into a mergeable state.


It might be possible if we made the cChunk lock a little more fine grained. But thats a different project.


I don't think so. We just need to document the change properly. Maybe even
involve Dave to look out for customers who might be using it to ensure the
new way covers their use case.

--
Jorge Ferrer
Sent from my phone
El 12/5/2015 7:35 p. m., "Drew Brokke" <notifications@github.com> escribió:

> Do we need to consider adding UI for adjusting the language.properties in
> a similar way?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/drewbrokke/liferay-portal/commit/406f1ac7429d69ae59a81e04f6d90e2d76b0efbd#commitcomment-11159938>
> .
>


OK, the idea here is to avoid repeating the GitHub url? Can you tell me what commands you'd run to achieve what you're describing? Do you want me to add a submodule that points at this data branch? This was a while ago, I don't remember if I tried that.


What is the benefit of this package over the previous one?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.121](http://teamcity.monogame.net/viewLog.html?buildId=7237&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@diorcety We are merging all pending stuff to release tonight. You better be quick, only a couple of hours left.


Nice! I didn't consider the need to pass the factory to the ListBuilder


Actually, looking at the grammar, I don't think any binary expression (except assignment operators) allow a yield expression on the left hand side or the right. So I think for binary expressions, you only need to loop while the parent is an assignment expression. For any other binary expression, you need to parenthesize immediately, like `a * await b`.


You're welcome! Let me know if it works for you... you also need:
https://github.com/ManiacDC/TypingAid/commit/8c8e5abcf856570a8a25559fdbf8beccc312554d


Btw, this is still unsafe because its not guaranteed that the hash indicates true equality, remember, a String can be hundreds of characters and the tiny integer only contains 32 bits of information. But not my problem...


I prefer applyTo :tongue:  you know `materialize` is a word, when someone goes through a star trek transporter then materialize on the other side. Is this your transporter?


Lists and Maps are mutable, I thought you were a security fetishist?


That's great to hear Grant. I'll get Aquire support in for 2.1.

> On 12 May 2015, at 17:56, Grant McConnaughey <notifications@github.com> wrote:
>
> Yay! Just an update, my company has been using this in production for about a month now and haven't encountered any issues since python-intercom 2.0.beta. Thanks for all the work you're doing!
>
> —
> Reply to this email directly or view it on GitHub.
>


"canola" oil?


This is great, Rob. I like what you've done. Let's go with this design.


Generally this is a lot faster because it simply encapsulates it instead of performing a deep copy.


This is the most useful method of the planet.


yep


Also, you will need to parenthesize inside a string template.


The problem is that we're using JUnit here and its `assert` doesn't have the same rich error reporting that ScalaTest's does; Hamcrest gives us nicer error messages when this assertion fails.  When adding the Hamcrest dependency (which is test-only), I was careful to _not_ add `hamcrest-all`, which transitively pulls in `hamcrest-integrations` and some mocking stuff.  AFAIK, the two Hamcrest artifacts that I added include no transitive dependencies, so I think this should be safe.

I'm going to be writing a lot more Java tests as part of Project Tungsten, so I think we'll see a payoff from using a nicer assertions library.


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/62272519


Well… the issue is that this is extremely unclear. The single octet 0x7f isn't even a valid encoding of an EBML VINT, neither ID nor size. The first bit is not set meaning that there are two bytes and not one.

One possible encoding of the value 127 = 0x7f would actually be `0x80 | 0x7f = 0xff`, which is reserved. 0x7f isn't reserved, it's just invalid.

So the sentence is not only mentioning a special case that isn't that special (there are two more cases like this for two octets → three octets and three octets → four octets), but it's also wrong.

If we want to include something as an example (as @JeromeMartinez has proposed) then it could be something like this: »As an example, the value 127 has to be encoded as 0x407f instead of 0xff as the latter has all its data bits set to 1 and is therefore reserved.«


Anyway, for now I've merged #7826 since that was the only setup where nothing was broken. I really think you shouldn't reintroduce this stuff at all, but if you do please do test it on darwin first.


I actually don't know under what circumstances you'd need to force a hold to stop pulsing before it "natually" stops.

I suspect that the old cancelHoldPulse() was implemented as a kludgy fix for a race condition of some kind.

If we're not aware of any specific cases where functionality is currently broken because a hold can't forced to stop, then I think we should simply move on. :-)


@lucasart : if you want, I will test at STC if it passes LTC. I thought that ELO 2.0 +- 3.1 is enough to go for LTC.
@mcostalba : this time I cannot follow you. The patch reduces code lines, number of paths, use of external functions, number of assignments and operators. But since it has the same number of sums, you claim that is not a simplification.

Send me your feedback, in the meanwhile, I reset prio to 0.


J'ai trouvé le problème, je push demain, j'ai des problemes avec git


Added it: https://github.com/SparkDevNetwork/Rock/commit/b1f5496b44c8651f80b980691c626b265809bf10


## This is a markdown file


I just tested this scenario in ffmpeg with
```
ffmpeg -f lavfi -i testsrc -metadata title="This title is 127 bytes long in order to check if this muxer is intentionally using 0x407f as an element size rather than 0xff." -t 0.1 elementsizetest.mkv
```
and indeed the 127 size is expressed as 0x407f. :)


From a dependency-injection standpoint, I don't think that it makes sense to pass `outputFile` into `TimeTrackingOutputStream`'s constructor when it really only needs a `FileOutputStream` to accomplish its work (the only use of `outputFile` would be to pass it downstream into another constructor, which seems a little odd).


Import ordering is my nemesis :(


Is it possible to use a blockarea? We copy the content of a chunk into the blockarea. The blockarea stays valid for lets say 20 ticks, and there is no need to check if the chunk is valid. I suspect that this will be slow as well because of all the copying, but I thought I'd throw it in the discussion.


typo.


what about *file:* ?


I'm definitely glad that ffmpeg doesn't produce invalid files :) I'd also be very surprised if it did get this wrong.


> One possible encoding of the value 127 = 0x7f would actually be 0x80 | 0x7f = 0xff, which is reserved. 0x7f isn't reserved, it's just invalid.

oops... I read 0xff instead of written 0x7f.

> »As an example, the value 127 has to be encoded as 0x407f instead of 0xff as the latter has all its data bits set to 1 and is therefore reserved.«

an example is good to have from my point of view. Just replace "has to be" by "shall" (RFC wording)


I'm expecting a NoneType to map to a NoneType.

For example, when querying for an object from a database using sqlalchemy, a NoneType could be returned if it doesn't exist. In this case, instead of having to check for NoneType for every query before mapping it, I'm expecting object-mapper to be able to handle it by simply returning a NoneType.  And then I can just check for None on the mapped object if/when needed.  In my case, I am not usually checking for None on the mapped object and so I just let it pass through to the caller as a valid result.

Thank you.


This looks fine, @psoloway  . Go ahead and PR.


Maybe instead of checking for existence, we need to check for some property; size, or modify date, or something.


This has been slowly coming in since 2013:
https://sourceware.org/git/?p=glibc.git&a=search&h=HEAD&st=commit&s=BSD_SOURCE

This last patch triggers the warning on Fedora 22 with glibc 2.21:
https://sourceware.org/git/?p=glibc.git;a=commit;h=ade40b10ff5fa59a318cf55b9d8414b758e8df78

On Tue, May 12, 2015 at 7:44 PM, Alan Antonuk <notifications@github.com>
wrote:

> What version of glibc is this deprecated in?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bboozzoo/rabbitmq-c/commit/f4e6c7c09d75b314bdfaafd8d0f8f7d3258e40b4#commitcomment-11160120>
> .
>

--
Maciek Borzecki


ok


»As an example, the value 127 shall be encoded as 0x407f instead of 0xff as the latter has all its data bits set to 1 and is therefore reserved.«


OK


Also needs updating: https://github.com/rstudio/rsconnect/blob/master/R/lint-framework.R#L108-L112


Having an example is fine with me if it is a) correct and b) labeled as an example and not some special case.


LGTM


I note that `lebesgue_sum` is unused.  Do we have plans to use it?


Indeed, it makes sense to do this change. I'll update the pull request.

On Tue, May 12, 2015 at 7:40 PM, Alan Antonuk <notifications@github.com>
wrote:

> Refactor AMQP_VERSION to use AMQP_VERSION_CODE.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bboozzoo/rabbitmq-c/commit/ccf6f5a6afb50b6cf2dd49ffde60c9a02313c1fd#commitcomment-11160030>
> .
>

--
Maciek Borzecki


Enuns de Modelos e Montadoras adicionados, mudei os getters e setters a fim de implementarem os enuns.
O método loja contem erros agora, pois ele tratava modelo e montadora
como String.


Let's do it


The original rationale had something to do with metrics reporting for in-progress tasks, but I think there's a cleaner way to handle this that avoids this confusing line; let me go ahead and refactor this.  I was trying to avoid some edge-cases in DiskBlockObjectWriter's own incrementing of this counter for certain writes, but I don't think that this will actually happen here (I have a more detailed explanation of the problem I was trying to avoid, but I think it's moot to go into the details if I can just fix it more cleanly elsewhere).


Pequena correção que fiz do último commit :)


Why don't we generalize this to, let's say, ObjectQuery and use the assoc id and type concept? It will avoid storing duplicated info on this object table, like revisions, submission id, etc, and we are ready for things like creating queries for the metadata discussion...


As this is not needed by Socket.io 1.X (I'm extrapolating from your commit message), it shouldn't be in the `AbstractSocketIO`


Great tests! I am noticing one issue here. If you have something like
```ts
new func(...args)()
```
This is a call expression whose target is a new expression. But it looks like you will emit it as
```js
new (func.bind.apply(func, [void 0].concat(args)))()
```
And the final parentheses are consumed by the new expression, so it never gets called. I guess the two options are:
1. Append a pair of parentheses to the end of the emitted new expression
2. Parenthesize the new expression in such cases.


Why `source.Spellbook.GetSpell(SpellSlot.R).Level` when you have the level right there in the lambda


I had a reason to do that, but I can't remember it though. Could you do it in another PR, as this is not the same scope ? Thanks


Cool sounds good!


Autre exemple :
{code}
<reference name="right">
    <action method="unsetChild">
        <name>catalog.compare.sidebar</name>
    </action>
</reference>
{code}


@arvalarva

There are some brief guidelines in the forms section about field widths based on the expected/max length of content, but it also states that that's not always the right solution for all layouts/situations. Depending on the complexity of the layout or form and the types of fields/content, consistent alignment might improve usability _more_ than hints of expected content length.

In a responsive/mobile layout, you wouldn't want the input width to ever exceed the width of the parent container, but that's generally true for any component.

Did you want to improve these guidelines further?

http://uspto.github.io/designpatterns/1.x/docs/components/forms.html#field-widths


@koying nope i already changed my mind in the forum thread - but still that shader doesn't work might bite ios asses in other situations - right?
@fritsch read further in the log - you catched thumbnailextraction or so - the failing tv channel is indeed successfully opened with vtb but vtb bails during decode (most likely interlaced content)


Not sure how I feel about the verbosity issue as I would rather see the
complete list. As for esound, the idea would be to build against it if it
was ever added. Same with coreaudio which would be detected to be Darwin
only by shouldUsePkg, assuming it works.

On Tue, May 12, 2015, 08:11 Eelco Dolstra <notifications@github.com> wrote:

> I don't think this kind of configurability is necessarily a good thing,
> because we have no way to test all combinations of options.
>
> And what's the point of lines like:
>
>     (mkEnable false                   "waveout"                    null)         # Windows Only
>     (mkEnable false                   "xen"                        null)
>     (mkEnable false                   "gcov"                       null)
>     (mkWith   true                    "system-user"                "pulseaudio")
>
> Since these options are not exposed to the user, it just makes the Nix
> expression unnecessarily verbose. I don't want Nix expressions to end up
> like ebuilds, which are typically way more verbose than the corresponding
> Nix expressions.
>
> Or take the configurability of database. Are we going to test all
> different database backends? Why not just pick the one that works the best?
>
> Or this line:
>
> +    (mkEnable (optEsound != null)     "esound"                     null)
>
> It's not apparent from the source that there is no esound package in
> Nixpkgs! But if there were, I almost certainly wouldn't want Pulseaudio to
> suddenly depend on it. But callPackage will pass it automatically, so you
> have to careful to list everything you *don't* want in all-packages.nix,
> making that file more verbose.
>
> Or this line:
>
> +    (mkEnable (optCoreaudio != null)  "coreaudio-output"           null)
>
> You would have to look at the coreaudio package to see that this
> dependency is Darwin-specific (except that we don't have a coreaudio
> package...). Whereas in the past we would just say:
>
> buildInputs = [ ... ] ++ optional isDarwin coreaudio;
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/a2a35082ccd64b4d00d88778d9633fe18c0bb215#commitcomment-11157014>
> .
>


(Assuming a "blockarea" is a copy of the chunk that isn't locked by other threads, please correct me if I'm wrong)

That would resolve the locking issue mentioned by Xoft, but not the other issues.


added HelloWorld.rm from local repository


Podzieliłem logikę w taki sposób. Wszystkie akcje będą odbywały się w pliku "server.js". Waszym zdaniem taka struktura jest logiczna? Co warto zmienić? Jakieś pomysły?


ici c'est correct
Mais il serait plus pertinent de faire un handle générique et de l'inclure dans category 10 et 14


Add margin to the right of the clear all button now that it's not on its own line.


remove apostrophe from `its'`


This is a little hacky.  When closing an UnsafeShuffleExternalSorter that has already spilled once but has buffered in-memory records, we write out the in-memory records to an on-disk file but do not count that final write as bytes spilled (instead, it's accounted as shuffle write).  The final merge needs to be counted as shuffle write, but this will lead to double-counting of the final SpillInfo's bytes (I'm in the process of renaming SpillInfo to clarify that it is also used for non-spill cases (maybe ChunkInfo or PartitionedFileInfo or something)).

In the case where we've never spilled, we go through the non-merge `if` branch above, which doesn't perform any metrics updates because those writes would have already been recorded in `UnsafeExternalShuffleSorter.close()`.

This is a little convoluted since I've been trying to balance the competing goals of having the metrics update logic consolidated in one place vs. getting good incremental metrics updates for in-progress tasks.  I'll see if I can find a good way to clean this up or add better comments.


А зачем вообще сохранять список плагинов в БД? Да еще и в jsonе :(

Ну, мы при старте импортим плагины - вот и есть список.


bcz skill E use R level not E Level


Since the word "accessor" means something specific in typescript, perhaps we should call this memberName or something like that


Consistent spacing between the 'x' in the Clear all button and other filter values.


I haven't sent the pull request for the structure section yet, but perhaps we should clarify "all data bits" to mean either VINT or VINT_DATA. If "all data bits" is VINT_DATA then "0b 1111 1111" is reserved. as well as "0b 0111 1111 1111 1111", but if "all data bits" is the whole VINT (VINT_WIDTH + VINT_MARKER + VINT_DATA) then only 0b 1111 1111 would be reserved. (hoping I have this right)


Agreed, I'll tinker with that a bit once I've got some basic clean-up done.


in*


Wrong commit (not important).


Sounds reasonable.  I'll also update `TimeTrackingOutputStream` to do the same thing.


This style assumes that the filters appear to the right of the input on larger browser sizes, which is not always true. It causes set values to jump when you resize the browser window.


Not an empty object, more like undefined I think


very nice


Just removed the accept_obj parameter completely as you suggested above.


Wszystkie biny i pliki w katalogu ".gradle" jak i ".inteliji" powinny chyba być dodane do wykluczeń w .gitignore


@SafwatHalaby That's a correct enough assumption, only a blockarea doesn't have to match chunk boundaries.


Initialize blog


Hello im Skipps, very interesting project.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.121](http://teamcity.monogame.net/viewLog.html?buildId=7237&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:21:55


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.122](http://teamcity.monogame.net/viewLog.html?buildId=7241&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Can we try and squash unnecessarily individual commits prior to merging? :heart:, It's making the commit tree hard to keep tabs on :/.


Great ! I was about to make a PR, and to ask if you were thinking about CPAN ! I see this is the case and that's a good thing.

Thanks for keeping me updated about your work ! I'll test my code against the official version asap and switch to this version when ready.


I think we can use the notes structure that's already in place to handle the queries messages...


Надо по честному завести many-to-many relation и помнить свзязь, что для такого-то курса есть такие-то плагины. Вся эта сериализация в json выглядит как костыль и непонятно зачем. Мы потом с ней намучаемся.


Ok, I removed all autogenerated build and *.css demo files with commit 371f061279278e05b4b325b4b64c224c5e0e0fad.

I think that demo files served for demo application on Google Code hosting. We don't need them any more but for now, I would let them be :)


TODO update this doc when tests pass


TODO remove this monstrosity of a line


Or, since `$custom_dir` is already set to an empty string, this:

    if ( ! empty( $template_dir ) && file_exists( $template_dir ) ) {
        $custom_dir = $template_dir;
    }


XxmomexX


Ok


Ой. Все-все issue перебирать, а потом еще и в памяти делать какую-то структуру - это очень ресурсоемко.

А самое главное, а что будет, когда появится новый issue.

Вообще, включать плагины для конкретных issue - это какая-то странная идея. Типа для issue 253 я хочу плагин, а для 632 - нет.

Мы обсуждали, что у нас плагины будут включаться-выключаться для каждого курса в отельности. А если у нас плагин, который делает что-то в issue, то он работает для тех issue, которые относятся к курсу для которых он включен.


Sorry to be dense, but I am confused about something. It seems like whenever you have a property access or an element access, you assign to a temp, and then emit the temp as the first argument to apply. So when would you ever emit the dot with the member name here, or the brackets with the member name below?

I wonder if it makes more sense to just emit the whole expression when you emit the target the first time, and not do the special casing for emitCallTarget. Seems like you do not care about the target for a new expression.


Thanx


Derniere version qui fonctionne - Ajoute de la date, modification des couleurs


This breaks the semantics of connect(). I sometimes do want to use connect() in its capacity to filter out any other peer than the one I'm talking to. That feature is suddenly lost with this change (thus, this is an API breaking change!)


Funny...I was just starting to chase this issue. Yea for collaboration!


I'm pretty sure that VINT_DATA is meant – meaning "0b 0111 1111 1111 1111" is reserved, as are the similar ones with three and four octets. @roBux4 have I got this right?


Windows builds have been failing since this commit, appveyor has been throwing false positives (I'm betting an error code isn't coming out right somehow) >.<


vbccbv


В course_plugins искать issue ?


Nice feature!


... именно поэтому не нужно ловить все-все исключения, а нужно ловить какие-то конкртеные с которыми вы знаете как бороться. Тут видимо подразумевается KeyError. Но можно было бы и просто .get с дефолтным параметром использовать.


Is this change needed for the notification support or why is it done?


Please help me. Inquiry Number:
11990 80080
Date: 5-12-2015
Time: 2:17
Please e-mail to fireflyboy998@gmail.com


Утята тебе благодарны!


Вообще интересно как это работает? Если с return self.course_plugins[issue] все пошло хорошо, то как тогда он еще раз return в finally сделает? %)


А этот метод зачем?


Add safe delete ptr for pages soon.


А это зачем?


Это плохой критерий. Если уж хочется по префиксу, то anytask_plugin.


Don't you have to emit a call to resolve?


La Catégorie "Cercle" fonctionne mais pas les autres (??)
"é" et "è" non reconnu


Normally this is for when i'm deploying any WP plugins I create, and you can actually see one of the open source ones that I just started working on again:

https://github.com/tripflex/wp-login-flow

Specifically you can see in the Gruntfile.js the since replace:

https://github.com/tripflex/wp-login-flow/blob/master/Gruntfile.js#L271


Why do you need to pass arguments here? It is an arrow function, so arguments will just be inherited from outside, as they should be.


Can you help me understand what's going on here?  FWIW, MSDN doesn't doc this method as throwing SLE?


Если уж apps глобальная переменная, то пусть бы оно и называлось INSTALLED_APPS


Don't you need to take a rest arg here for the arguments?


matchMedia should include a polyfill...


Oh I guess you are capturing the arguments


Oops


Neat trick.


And capturing this


@mpodlodowski this is what I meant.


I can restructure this to make it more clear, or add a comment.  It's not the Enter* methods that are throwing SynchronizationLockException, but RWLS' Dispose method.  If you Dispose of a ReaderWriterLockSlim while it's held, it'll throw an SLE.


I think this was the only issue. Can you confirm?


Rebased. Ready for merge!


meow


Ahh!  Gotcha.


Hi friend, can you separate this code into 2 files. Example: RainTPLEventsHandler.php and RainTPL4Plugin.php.
I think, it is better for php reader and standard.


The response you are getting is cached response, try confirmed it using dev tools. You can avoid getting a cached reply to the ajax call. This method of updating a target array is redundant and will block the server everytime something is updated


Suggestion:
Make the factory functions a bit more explicit
- `tangle<T> fromRadians(T)`
- `tangle<T> fromDegrees(T)`

And the extractors member functions:
- `T tangle<T>::radians() const`
- `T tangle<T>::degrees() const`


I read below:
Class B: 2^14-2^7
So that means that "0b 0111 1111 1111 1111" is not reserved ("0b 0100 0000 0000 0000" - "0100 0000 0111 1111" so 2^7 values are reserved).

That said, I am for having  "0b 0111 1111 1111 1111" reserved, for more coherency between Element ID and Data Size (let's use the same RFC formula)


settings_common - это специальная обертка в AnyTask, чтобы можно было делать settings_production.

А за settings нужно ходить стандартным в Django способом:
from django.conf import settings


A couple reasons I like to have the @since is one for any developers that build off my plugin with another plugin, theme, etc, and this way I know whenever i'm refactoring, updating, or changing things, what version those methods were implemented in.  Because I also build off the core of WordPress there are many methods that depend on specific versions of WordPress.

With that in mind whenever I make updates and end up raising the min WordPress version I can go back and look at the last time I raised the min WordPress version, and then check those specific methods that were introduced in that version to hopefully prevent any conflicts or issues, or even make them backwards compatible


Nvm, I see awaiter calls it


@nthaniel I see the changes you made now.  Not sure why a panel 17 and panel 18 would both be made to point to the same page but that discrepancy may have been a mistake on my part.  Going through the test with these changes seems to work well and do the same thing as before, so +1 to your changes to my test.  Not sure if I should merge them or you.  I'll leave that to you.

Thanks!


If anyone can do it, it's you.


I don't understand which element IDs are forbidden.
I understand that Element IDs 0 to 2^7-2 are authorized, so 2^7-1 element IDs. Which other one in the range 0 to 2^7-2 is not authorized?


This is really great work, fits nicely with the current architecture.


:+1: :dash:


Is there a way you could add-in a option to allow constant re-spawning, so you don't have to click on the play button every time the bot dies?, it just automagically re-spawn and keeps going.  Also maybe a max mass reached per session? like your would have your normal "Score" then a "Session Score" basically a score that wouldn't reset after you die, so you can see what the best score the bot has reached.. sorry these are just some thoughts I have =)


Fixed it


Actually I see what you are doing. You are relying on the implicit resolution of arguments inside the generator, and passing in the arguments of the surrounding function, which is the correct arguments.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.122](http://teamcity.monogame.net/viewLog.html?buildId=7241&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:22:18


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.123](http://teamcity.monogame.net/viewLog.html?buildId=7245&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Pour info j'ai regardé les logs et j'ai effectivement le même soucis, ils
ont du changer quelque chose.

Je regarderai à mon retour.

On Sun, May 10, 2015 at 10:15 PM, Maxcore <notifications@github.com> wrote:

> Super merci @cyberben <https://github.com/cyberben>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cyberden/CouchPotatoServer/commit/68e842d686cb32943a0a1aaf92b878f5bd00308f#commitcomment-11124717>
> .
>


Maybe this should conflict with prohibited packages like `telnet-server`


 just install the package shinyjs and it will be fine.  or you can remove it from the server file boss, i think i already push it to github.
please go to web browser firefox: to the server
http://codes.bio/fpop/
right click --> inspect element --> console
in the console, you will see the root of the error. feeling that there is no package called shinyjs package(picture attached). Boss, there is two options, you can remove load library(shinyjs) from the server.R file or install the shinyjs package from CRAN for the digital ocean server. Whats funny is that the guy who write a shinnyjs is also the guy who write about using digital ocean to deploy shinny server. I want to give it a try. lol
http://deanattali.com/2015/05/09/setup-rstudio-shiny-server-digital-ocean/

Date: Tue, 12 May 2015 03:38:54 -0700
From: notifications@github.com
To: OliFP@noreply.github.com
CC: doe_doe207@hotmail.com
Subject: Re: [OliFP] Update Server.R (d3b8b0a)

There was a pop-up that says:

The application unexpectedly exited.

Diagnostic information has been dumped to the Javascript error console.

Then the whole page turned grey (then nothing works).

On Tue, May 12, 2015 at 5:35 PM, Saw Simeon <notifications@github.com>

wrote:

> Boss, what was the error message boss, I can't see the attached file.

> please help me.

>

> —

> Reply to this email directly or view it on GitHub

> <https://github.com/chaninn/OliFP/commit/d3b8b0a97c32990361aa6c9351d04d8108edd9c6#commitcomment-11152018>

> .

>

--

Associate Professor Chanin Nantasenamat, Ph.D.

Head, Center of Data Mining and Biomedical Informatics

Faculty of Medical Technology, Mahidol University

999 Phutthamonthon 4 Road, Salaya, Nakhon Pathom 73170

Tel. 02 441 4371 ext 2715

Fax 02 441 4380

—
Reply to this email directly or view it on GitHub.


That's true. But, this does not throw an error even if module is a pointer.


Thanks for the quick fix! Newer versions of IE 11 return Uint8ClampedArray, like other browsers, so the IE-only code was untested.


This line makes my local test suite fail. The test suite passes if I comment it out.


conventionally called 'push'


conventionally called 'pop'


oh, I missed that.  but the Vala ones are also in the vala commit which is before this one


```C
stack[SP] = stack[SP+1] < stack[SP];
```


cayenne does not currently understand previousId -- you'll need changes there.


@ajturner cool. I'm actually re-structuring cublet to be a node modular and CLI tool built on top of that (probably ine for geojson and one for csv first). The appending will get built in as I think about it...


`covar_pop` seems to be missing


Any url with `https://`. You know it is a hubiC thing...


1.
django же один раз уже поимпортировал плагин. Зачем-то мы делаем еще раз?

2.
А как предполагается, я должен писать плагин? Вот допустим, я сделал свой app, сделал класс, который наследуется от BasicPlugin, а дальше что? Как plugin_manager найдет мой класс? Просто заиспортить app и запомнить - мало.

Я предлагаю убрать всю эту историю с импортом и сделать просто метод register_plugin или register_visual_plugin (это ведь плагин, который показывает что-то в issue?). И обязать автора плагина звать этот метод и передавать инстанс своего плагина - в этот момент мы о нем и узнаем.


ditto.


Why create files in a post install scriptlet?? These symlinks should be created in the %install section. If there is a good reason it there should at least be a comment explaining so.


rax retry tests


This check is unnecessary. `mkdir -p` does it for you.


Needs `@wip` to pass CI.


BTW, I find it a bit weird to over-use C99 features while it would actually be a little shorter (and simpler, no assignation via compound literals to a dereferenced pointer) not to and simply repeat the `plugin->hooks->` part.

Also, and while it doesn't change much, it means the plugin basically allocates a struct on the stack and then copies it -- including potential padding.  I doubt it won't ever have any kind of incidence anywhere though.


@mkristian This commit removes the lafo repository and uses Maven Central/Sonatype, so that's all good, right?


What happens when the friend disconnects while the call is ongoing? Will the state go to FINISHED? Is there any guarantee for the order in which events are invoked? I.e. does the friend-disconnected event happen before or after the call-state-finished event happens? Whichever way it is, please document it (even if an order is not guaranteed).


Please don't use the number of possible valid IDs as a basis for any kind of argument. Those numbers come from the RFC and have never been properly verified.

We must do it the other way around: first agree on which kinds of ID are invalid and (re-)calculate the number of valid IDs from that understanding.

Just for completeness's sake: libEBML considers "0b 1111 1111", "0b 0111 1111 1111 1111", "0b0011 1111 1111 1111 1111 1111" and "0b0001 1111 1111 1111 1111 1111 1111 1111" invalid (well, it doesn't write but does not actually check for those values when reading IDs, if I read this correctly). So yes, the original intention was what @dericed called the VINT_DATA case.


Try not to use unnecessary parentheses. For example:

```javascript
((max_negative != nil) and (g < max_negative))
```

can be:

```javascript
(max_negative != nil and g < max_negative)
```

If the expression involves many `and` and `or` keywords, then I recommend you *do* use parentheses. This is because there is ambiguity depending on how the complete boolean expression is evaluated. For example:

`False and (False or True)` evaluates to `False`

`(False and False) or True` evaluates to `True`.

If there are no parentheses, like when you have `False and False or True`, then there's ambiguity, it's up to the compiler or interpreter how to evaluate it.


Ahh yes.


Is the new call state guaranteed to be different from the previous call state?


We can simplify this a bit

When we have a template-haskell package dependency we get

```
defined(MIN_VERSION_template_haskell)
```

so we can drop the TEMPLATE_HASKELL flag.


Should this instead catch a specific exception


Please take it to the issues board. Deep in the guts of the 1.8 update commit is **not** the place for a debate.


Wouldn't it be clearer in the clause that handles missing entry, to do
```
$show='none';
@preformatted=($key);
```


> Please don't use the number of possible valid IDs as a basis for any kind of argument.

OK. I was wanting to be sure we are in sync, and the numbers below must be modified.


В этом классе не хвает способа узнавать названия полей, которые этот класс умеет делать.

А вообще, может быть сделать один плагин - одно поле. Если я захочу 5 полей, то я могу же сделать 5 таких классов в одном app-е.


Let's have this discussion in the other line comment, please. Like I said the number of elements are not authoritative; we have to verify them.

But in order to answer your question: both 0xff (0b 1111 1111) and 0x80 (0b 1000 0000) are invalid. The former has all data bits set to 1, the latter has them all set to 0.


@Memphiz Well, I haven't implemented it blind for ios, obviously, but the option shouldn't show, either, nor the shader loaded.
Does it?


This error and the one before are essentially the same: invalid transition. The invalid transition error would also happen if you (un)mute something that is already (un)muted. Toggle avoids this particular error, but see above for rationale for not having toggles.


'platform_android.GNU' includes 'platform_linux_common.GNU' but when 'getconf' is called it's the OS of the build-host which is being asked if it supports large files. It should be Android which is asked...
When I compile Android on Mac OS X "Unknown" ends up as a build-flag for the compiler.


This line seems to have extra whitespace.


I worry about making this the default.


I remember what this is for now, it stops a infinite loop in the flusher where we have a VB yet keep returning RETRY forever.


Please add just two more features...
1. Best answer selection
2. Check for similar answers

These two features are not in many forum cms so these also makes the difference... :-)


This was a refactor to make the listView use the bundle instead of the hard coded values or the injection via constructor. The original test still covers this since the behavior is the same.


"Enter any url starting with https" is not a prompt any S3QL user is ever going to see (at least as long as I'm maintaining it). It is unclear, irritating and indicates a fundamentally broken design.


> Just for completeness's sake: libEBML considers "0b 1111 1111", "0b 0111 1111 1111 1111", "0b0011 1111 1111 1111 1111 1111" and "0b0001 1111 1111 1111 1111 1111 1111 1111" invalid

good.
Is it the same for "0b 0100 0000 0000 0000", "0b0010 0000 0000 0000 0000 0000" and "0b0001 0000 0000 0000 0000 0000 0000 0000"?


This should be configurable


@kolasa Yes for driver from AMD site. Catalyst 14.12 Omega is in run file and is available on amd site. Catalyst 15.3 (fglrx 15.20) is only in ubuntu repos and I don't get it in .run file.

So, thanks for solution. Im trying it now.


@winklerm I'll talk about this with the jbpm guys and let you know.


Since this change has been out in releases for quite some time, could you please open a Bugzilla item to describe the problem? If you have a patch, please enter a new pull request (preferred) or attach it to your Bugzilla report.


I was under the assumption that cChunk::GetBlock and GetNeighbourChunk, which cPath uses, don't use locks since they only read from arrays/variables.


A better solution would be to default to the original values, but allow a user to customize them if desired.


Seems like this has broke the nav bar to appear on the locked screen.. Once I lock my device and try to access the app again, it goes to enter password but no nav bar is appearing.


2015-05-11 Done with this to-do-list.


The registry won't get GC'd since it's an instance variable of the Transport eigenclass (the @ prefix ensures this).


We were just testing this change in the latest version of Titanium Studio and it is breaking now. Removing line 3626 and replacing androidConfig with "this" is a change that completely breaks the functionality of dexAgent. Please back out this commit. Thank you!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.123](http://teamcity.monogame.net/viewLog.html?buildId=7245&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:22:13


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.124](http://teamcity.monogame.net/viewLog.html?buildId=7249&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


> Enter your hubiC Redirection URL:


If it is to you, then I will refactor. I just wasn't sure what ```@preformatted``` was for in the first place.


Because it has to be set at application registration.


reverting back


it's for when the bibref already has contents so we're not going to fill it in.... it's only slightly a stretch to apply it here.  But cleaner than reading the class attribute.


Actually, one thing that is confusing is what is global and what local - it seems both ```show``` and ```preformated``` are global for the make_bibcite call, while my solution is local to every individual ```datum``` entry. I am afraid not to mess something up by mixing the two types of scopes.


Is there an update of this script for installing on Yosemite?

I want to install a WordpressMU site with sub-domains on Mac-Mini-Vault.


this seems very dangerous to do, if there is any parsing mistake it shouldn't silently pick a different configuration?


The entire fix was nicely contained within the `__findMultiEntry` method. Thanks @BigstickCarpet for the original suggestion to split out the multi entry logic!


Cool, good stuff! (Finally checking github from Buenos Aires)


Why aren't we using http://docs.oracle.com/javase/7/docs/api/java/util/zip/package-summary.html ?


Oh, you mean
`` 07:17:04 T:134299648   ERROR: ERROR: 0:21: '' :  extension 'GL_OES_EGL_image_external' is not supported``` ?

It's harmless because not used, but indeed, shouldn't be compiled. Will fix.


it looks a bit weird... but it works :)


Cool man! No worries :)


platform_android.GNU is at this moment only tested/used for cross compilation using a linux host, probably another platform_android_macosx.GNU has to be added to cross compile Android on MacOSX


oh.. yeah... good point. .....  I guess that means that preformatted is actually wrong (wlll get duplicated if there are several keys?).  I guess I should go with your original patch, weird tho it may be :>


@pinnamur ^^


I assume this just gets magically called? I see the middleware registered in engine.rb, but nothing explicitly calls this. Is it the case that any method not marked 'private' gets called with the outgoing doc?


@galderz it looks like the patch is doing something very different than the JIRA description seems to imply.
Could you clarify the intent?


Okay, I understand a little better now.  Thanks.


+1 for having one features file with the supported stuff + another one with examples.


I suggest:
Don't set the WeightsPerVertex here. This implies that we know what the correct value is. Instead write
```C#
output.Write(value.WeightsPerVertex.GetValueOrDefault(4));
```
in the SkinnedEffectWriter.


This option is starting to look more attractive to me


This one too.


Wrap these?


Maybe drop 'beta 3' :P?


Does this need a minimum size?


It looks like this broke the examples.  I'll put together a CL that fixes them.


Changes to the "Loops" checkpoint assignment.


Thanks!


Have you considered using the overload of SendAsync that does not buffer the response? Then you can copy directly from the network to disk.


Nice improvement!  I think you're right this is a case which was almost certainly not considered.  Just a few comments.

We can do better than a while loop here, even if the list is almost certainly small.  Rather than counting the number of metaslab groups this could be stored in the metaslab_class_t.  There is already a `mc.mc_alloc_groups` which tracks the number of allocable groups, I'd suggest adding a `mc.mc_total_groups`.  This value can be easily updated in `metaslab_group_activate` and `metaslab_group_passivate` and then used directly in `metaslab_alloc_dva`.

In fact, I wonder if it might not be better to just to use the existing `mc.mc_alloc_groups` in the calculation.  This way non-allocable groups wouldn't be part of the calculation.  What do you think?


No they don't use locks because they assume you hold the chunkmap lock whilst calling them.


libEBML doesn't verify the ID that is written. Sorry for being unclear. The ID itself is simply written out byte after byte, but the number of bytes to write is calculated simply like this:

- If ID to write is < 127 then use one byte.
- If ID to write is < 16383 then use two bytes.

etc.

So if a semantic layer above libEBML decides to create an EBML ID of 0x80 then libEBML would most likely write such an ID without any complaint. If you used 0x00 7f (the first value for which the condition above nets two bytes as the length) as an ID then libEBML would even write that value – but couldn't read it back, obviously.

libEBML has a lot more places like this where data is not really validated.

My point was that libEBML doesn't write "0b 1111 1111" nor "0b 0111 1111 1111 1111" etc.


This is with 4.6. I took another look and it doesn't look like the problems with 4.6 are all that bad. it worked fine late last year.


Or could suggest `cabal fetch`, which just downloads things.


What overload is that? @ChengTian that sounds like something we should use here.


It seems to be because you saved it as a semicolon delimited filed!


The examples are great, it makes the algorithm here much more understandable.


Caching metadata can cause data loss if a column is added. Add a TODO here.


This should have expiration, say 10 minutes


@gautric This is for the light sensor? Right?


but will 'getconf' on all Linux dists always return the same as 'getconf' on Android?


OK!I cloned the repo, mvn install worked just fine.Now, to get started as fast as possible, is there somewhere in the code what I need to start as described here: https://gautric.github.io/blog/2015/04/03/apache-camel-raspberrypi-integration.html ?I was not able to find the CamelMain.java (com.github.camellabs.component.raspberrypi.CamelMain)...
Thank you,- Olivier
      From: Greg. A. <notifications@github.com>
 To: camel-labs/camel-labs <camel-labs@noreply.github.com>
Cc: Olivier LeDiouris <olivier@lediouris.net>
 Sent: Tuesday, May 12, 2015 11:41 AM
 Subject: [camel-labs] TSL2561 thx @OlivierLD (45ca996)

TSL2561 thx @OlivierLD

---
Reply to this email directly or view it on GitHub:
https://github.com/camel-labs/camel-labs/commit/45ca9961356ca890aaa3d13d2c3cae51877bfd91


@dan-f the commit message has nothing to do with the change


`DESTDIR` rather than `INSTROOT` is the convention used for this purpose. See `rpm --eval %make_install`


`if (discoveryStarted.getAndSet(true))`


https://msdn.microsoft.com/en-us/library/hh193601(v=vs.118).aspx with HttpCompletionOption.ResponseHeadersRead.


Архитектуры кода нет, и не будет. Игра не стоит свеч в 5 минутном проекте =)


Ah yes. @ChengTian please make that change and test it.


did you mean :fire:?