There are probably a few bugs that were not merged prior to the RC...
they'll be in 3.1.15 if so.

Damian Mooyman | Senior Platform Developer
SilverStripe
http://silverstripe.com/

Phone: +64 9 281 3498
Skype: tractorcow

On 29 May 2015 at 05:48, Jono Menz <notifications@github.com> wrote:

> There are a few bugs missing from May. Not that I checked for my name on
> this list or anything vein like that [image: :blush:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/silverstripe/silverstripe-framework/commit/04b803dfc6dc60f2e6a38fa74f957156230b54be#commitcomment-11412270>
> .
>


Use rest and destructuring for arguments:
```javascript
triggerEvent(eventType, ...args) {
//...
listener(...args);
```


can we remove this catch block if this has no version we are in deep shit anyway


you are bad at this


@elyscape e41d42d912 removed the unnecessary File.open and the whitespaces


self is not necessary if you use arrow function (https://github.com/lukehoban/es6features#arrows).
Same for arguments as above, use rest parameter: https://github.com/lukehoban/es6features#default--rest--spread


OK, I see, it is really checking that the `ASCIIString` is made of an array of `UInt8`...
Really need `ASCIIChar` type, whose range is `0..0x7f`, then it could completely optimize that away...
(and a `Latin1Char` type, `0..0xff`, and a `UCS2Char` type, `0..0xd7ff,0xe000..0xffff` [for a string type that is DirectIndexString, that doesn't contain any characters > `0xffff`)


Perhaps we can give it the same header as the forum? Simply `background: linear-gradient(white, gray)` should do it. Or maybe as the same theme as the webadmin, where we have more blue colors instead of grey.


Ha, yes, that's a result of a mindless re-edits. :)


I don't think this test is written correctly. You're expecting the IllegalArgumentException to be thrown and caught, right? But in the case that no exception is thrown, the test will still pass.


Why don't you just exit here?


I do not think this change is necessary.  Other calls use the original `add_flash(bang)` logic.  @h-kataria ?


Great! A few requests, though:
`such as, search (see below)` shouldn't have that comma there. `such as search (see below)` is more correct grammatically.

`section in discogs webpage.` should be `section on the Discogs website.`

Also, maybe replace that user_token with something like: `user_token="my_user_token"`


might need to do `{and: [{or: [{pid: target}, {workerId: target}]}, {stopReason: ''}]}`. In my experience LB doesnt seem to always do the implicit AND


Does anything free this?


Should be `leningrad`


Good stuff!


so this is now commited, I changed a bit my mind and instead of using JsonObject, I added a VertxMetricsFactory#newOptions that the Dropwizard overrides to return a DropwizardMetricsOptions instance.

So bottom line, a simple property on DropwizardMetricsOptions will do the job like in the other case.


What do you think about `on` syntax ? I love it !
```javascript
object.on("start", () => console.log("started"));
```
is more sexy than
```javascript
object.addEventListener("start", () => console.log("started"));
```


These will end up leaked; see comment in other commit about these not being floating refs.


how about `copyRegion`


It's set as the `key` on `<UserProfilePage>` - without a key change, react won't update the dom.


This will need to be changed if the signature of the method is adjusted to remove the boolean


-> https://github.com/pyllyukko/user.js/issues/9#issuecomment-100468785


What is that ???
Use a logging library/framework !


Sometimes this get() is throwing `MultipleObjectsReturned`. I think this is my fault since I haven't deployed #90 yet. Ignoring for now.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1157 of 1157 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fast-forwarding 2.1 to borshop-integration-1136-bugfix/jrd/blocking-vnode-teardown = 26169756


Optional: it's good practice to use `g_new0()` instead of `g_new()`


I don't think this change does what you think it does. The issue is that stable_sort takes the Comparator by value, not by reference; see http://www.cplusplus.com/reference/algorithm/stable_sort/. What needs to change is that HeuristicLitOrder object itself should not hold extensive data, either by changing the vector "counts" to a vector reference or by wrapping the HeuristicLitOrder in another light-weight object that references it to pass to stable_sort.


This MUST be a class attribute !
If you have multiple EventServices invoked you will get in trouble !
If you use inheritance too.


Hola mi estimado Josu'e, si mira, ya tengo al solucion., checa  la solucion completa la pagina de inicio en mibar.jsp y ya viene la logica, checa el proyecto y me dices tus dudas :)


Is it really usefull ?
JS is monothreaded...


Oops! I must have had some other double-unref in my code that I subsequently fixed and mistakenly blamed the crash on these innocent bystanders. Thanks for catching this.


Yeah, but we can put that back in then :)
I agree with Hleb, it's kinda confusing now ("backwards compatibility with what?").


rax retry tests


@DinhNguyenCat : I think you want to squash this with the prev commit. If not (i.e. if there's a good reason to have this separate) reflect that in the committext


```javascript
events.forEach(event => this.addEventListener(event, callback))
```


Ja dort fehlen noch die Bilder.
Da will ich zeigen, wie eine Suchvorgang technisch aussieht.


since you called `assureLoaded` you can just return a plain old `FixedWidthBlock`... same comment for above


Ja werde ich noch übersetzen. Ist mir erlich gesagt noch garnicht aufgefallen ... :smile:


Fixed issue #2


Should we use relative path?


You should use Sinon or another mock framework to test that callback is correclty called...


This fixes the sparc, and the non-sse x86 builds.  Only the first password was being tested.


Resolve #2


Okay ich werde mich mal an den beiden seiten Orientieren...
Falls ihr selber noch vorgaben habt, könnte ihr ja eine der anderen Seiten so stylen wie ihr das für richtig haltet, sodass ich das mit aufnehmen kann.


You should use Sinon or another mock framework to test that callback is correclty called, with right args.


@bfcoder Great, thanks! There also seems to be a problem with the routes adding an extra / to the URL

`POST http://localhost:8888//sessions/ 404 (Not Found)`


Your project and request models repeat this logic. Can you find a way to extract methods both models can use.


Would you please do this for the German translation as well? Or shall I just removed those myself?


Ich finde die Content Klasse etwas klein. Im vergleich zu der Jumbobox ist der Inhalt fast winzig. Ich würde bei den panels die Farbe und die ecken noch anpassen, allerdings die Schrift größe gerne so belassen. Was meint ihr dazu?


Resolved #2


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


1640-AddHVACPart1 (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


@ssfrr this made it really hard to see the link to the eventbrite page (actually, made it invisible). Is it really needed?


@daton creo q ya se como profe se ocupa lo de setAttribute y getAttribute en el servlet


Ah just realized why this is here - I had it on the schedule subpage, right?


`IdentityHashMap`


Good job !!


Make a utility method for this


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


 RTB:
 Add support for logging different events to a small uncached
 region. This is designed to aid in debugging reset cases where the
caches may not be flushed before the target resets.


I'm not hot on installing plugin's headers as public. Do we install it if they don't have the prerequisites for the plugin in the first place? Is it conditionally included? We've been trying really hard to pare down the public API exposure, and this is swimming upstream against that. Maybe that you want this publicly might mean the Rialto stuff should be encapsulated in its own little library.


Don't use `count`, use `length`.


My understanding of what's going on here is that we want to make sure that the event ID variant doesn't get leaked. We could do the ref sink and unref in each of `emer_daemon_record_singular_event`, `emer_daemon_record_aggregate_event`, and `emer_daemon_record_event_sequence` or consolidate that here. I see it as a tradeoff between duplication and keeping the reference counting at the more "correct" layer of abstraction.

In general, please feel free to comment on pre-existing issues for me. I usually prefer just fixing stuff while it's loaded into my brain to tracking it and coming back to it once I've forgotten what was going on (or leaving stuff messy and potentially tripping on it once I've forgotten what was going on).


"Github" should be "GitHub", yes?


Fair enough.


we must provide the python2 lib for backward compatibility


@panshul007 please make sure to implement this


There is a race between the RetainCallback incrementing the count and this code.


This library is a standard JCE provider. There are tests in this repo, you can use as examples. However, the primary interface is the Java cryptographic extension. How to use the JCE is explained by oracle and others around the web.


I ran some of the other existing tests relying on this function and the only difference I spot is the assertion count. Continuing from the [pull request comment](https://github.com/Automattic/vip-scanner/pull/282#issuecomment-106224865), I am not sure why this assertion was there in the first place besides preventing a positive test case from going through.


La idea de esta Koan está en solucionarla sin tocar ClassUnderTest ni ExplosiveCollaborator. Vas bien con la idea de crear una clase que no falle.


We'll push the next large chunk of code probably some time in July. =)


Good, thanks.


Thanks :) I much prefer this too. I was following the [doc here](https://github.com/Automattic/vip-scanner/blob/master/CONTRIBUTING.md) initially. Perhaps the doc could benefit from similar changes too?


Will do. My bad
On May 28, 2015 1:26 PM, "Ryan Hansberry" <notifications@github.com> wrote:

> plz remove
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CS130-BitBoard/BitBoard/commit/2ef4a1ec5e70ac6620cfba782ce534372062b746#commitcomment-11415280>
> .
>


A parte de eso, la idea es que en este branch, en el que pones la nueva Koan, no resuelvas ninguna otra. El proyecto se quedaría preparado para clonarlo y que alguien pueda hacer todas las koans.


I would rather say: "Local snapshots can remain on the local node [...]" and "With all these storage types it is [...]"

Last sentence: "In my opinion the cleanest solution is to offer a backup service [...]"


bonjorno ne s'ecrit pas de cette manière


Note the full link mentioned in commit didn't type out. Can be found here: https://github.com/RolifyCommunity/rolify/wiki/Devise---CanCanCan---rolify-Tutorial


My point is more that this function does not need to ref and unref the variant in order to do what it does - callers like `emer_daemon_record_singular_event()` also just pass a variant to the function that is received from their calller, but I guess that's fine because they're supposed to consume floating refs they're passed.

You can leave this as-is; I just don't like too much the fact that side effects are buried quite deep into an innocent-looking function :-)


Pokud to budeš v IE 7 testovat, revertnu.


Should be committed against #215


[`swap_bytes_if_big_endian`](https://github.com/endlessm/eos-event-recorder-daemon/blob/sdk/3168/shared/metrics-util.c#L152-L171) calls [`g_variant_byteswap`](https://github.com/GNOME/glib/blob/master/glib/gvariant.c#L5756-L5812) under the hood. For consistency with `g_variant_byteswap`, `swap_bytes_if_big_endian` calls `g_variant_ref_sink` on the variant it returns, which may or may not be the same variant it was given. Calling `g_variant_ref_sink` on the floating variant passed to `swap_bytes_if_big_endian` before the call to `swap_bytes_if_big_endian` and `g_variant_unref` afterwards ensures that this variant is not leaked if a new variant was returned and that it isn't released if the same variant was returned. I think this is the way `g_variant_byteswap` is intended to be used and that it's just very optimized for performance, not convenience. Maybe there is a cleaner approach I haven't figured out though.


I will delete the commented-out line.


Thanks for renaming song to video. :)


Great!


OK.


Line 237's synchronization block is removed because I decided to make entire while loop block to be synchronized.


if you add font through the @font-face you need to upload them together with your project


 A factor of 10 is used in the numerator to make the CIDErD
scores numerically similar to the other metrics.


The helper function I'm referring to in the commit message is `append_variant_to_string`. Do you have any thoughts on how to word this less confusingly?


voila la modification


It's good to have all this `insert(std::make_pair(` nonsense gone for good. :+1:


That's looking simple and fits our purpose now, so we don't need to depend on another module (django-cors-headers).


Yeah, that is one bit of code that I have changed and not committed yet. In `index.js` line 66 `apiPath` need to remove that forward slash.


Doh. I thought I fixed this. Does the resulting branch show this?


Yeah, where the heck did Portaljoe even come from? Who's joe, and why was his name there? lol.


Below for the input you will rewrite this rule, so is better to write all rules for the input separate from the body


Truncated the history of my days of not knowing how to git. The project will proceed from this point with proper version control.


this is the default value - no need to write it in the css


Is that a technical term? :P


Crap. Someone should legislate against using spaces for indentation.


First off I want to say that I love this feature addition, really cool stuff! :100:

As it turns out, since this change puts the complexity analysis info **before** the long query in the response, the Python [redis-py](https://github.com/andymccurdy/redis-py) library (and potentially other libraries) doesn't actually parse `SLOWLOG GET` responses properly anymore.

But fear not! I've submitted a pull request that should handle the changes without breaking anything: https://github.com/andymccurdy/redis-py/pull/622

Hopefully they'll accept it, feel free to comment over there to generate some enthusiasm. :8ball:


Property "position" can't have value "center". See here http://htmlbook.ru/css/position


Correct. Check the resulting branch.


KKK. Ds heel moontlik omdat jy die Ming compiler het en ek gebruik die MSVC. Sal merge


I had to change this to get it to work; on line 123, I had to remove the exclamation mark from the if statement.

Code that works:
```
if ( $invalid_page ) {
    _e( 'Cheatin’ uh?' );
    return;
}
```

Just a typo?  Or is there something else going on? @thomaslhotta


If you use not web-safe font add other font-families for proper degradation.
Example:
font-family: Nautilus, Arial, sans-serif;


La koan que hagas tiene que fallar, pensando en que alguien que haga todos los koans haga el tuyo también. Un ejercicio interesante podría ser que, una vez hecha, la resuelvas tú mismo en otro branch


vaInitialize here overshadows the vaInitialize at https://github.com/xuguangxin/libyami/blob/reoslution_changed/vaapi/vaapidisplay.cpp#L61 and breaks the intended functionality at https://github.com/xuguangxin/libyami/blob/reoslution_changed/decoder/vaapidecoder_base.cpp#L345.


I would like to kill the single dash options that consist of more than one character in the next version that I will released, but that's OK for the moment.

In fact, my plan is to release a new version and put a conspicuous message of their use being deprecated and, in a subsequent major version, having them removed.

Frequently used options that consist of only a *single* letter would still be kept.


Please change


I think it's better to use "section" tag for this node. Check when is better to use "article" tag here - http://html5doctor.com/the-article-element/


Default value - no need to overwrite it


Aren't gradients generally considered unsuitable from a design perspective nowadays?


TeamCity NEventStore :: Core :: Build [Build 85](http://build.prxm.it:8811/viewLog.html?buildId=2837&buildTypeId=NEventStore_CI&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 279; exit code 1 (new)) Build time: 00:01:40


LGTM


ah, cheers - thought I had updated it everywhere :)


Are those wanted in production?!


Why do you need SIG_COUNT as both enum and #define?


you can concatenate both rules in way like
a:hover,
a:visited  {
color: black;
}


TeamCity NEventStore :: Core :: Build [Build 86](http://build.prxm.it:8811/viewLog.html?buildId=2839&buildTypeId=NEventStore_CI&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 279 Build time: 00:01:14


Yeah this was due to the ridiculous conflicts I encountered and fixing things in the wrong order during the rebase. I had no intention of any of this merging being done "right" since the right way is to put up each change set for a review one by one. I will be more than happy to fix absolutely anything pointed out once we make a decision about where satori will go and pick a (new?) workflow when the changes are submitted in cohesive patches with good commit discipline.


You know what I miss (not exactly me, but for my aged father)? I would like to grab subtitles for *all* languages... Given his difficulties hearing even Portuguese, I guess that they would be great.

(Yes, I installed coursera-dl for him, of course).


The code is definitely easier to read with nullptr in there. Re: backwards compatibility couldn't we just do a configure-like check for nullptr working and else:
```C
#define nullptr 0
```
?
(but not worthwhile if we are going to drop gcc4.4)


1640-AddHVACPart1 (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2133 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.38%25-yellow.svg)


dodać usuwanie w przypadku gdy przedmiotu nie będzie na półce


It's so technical that you may have a stroke if you look at too long :P


you can write "padding" in the shorthands like
padding: 5px 5px 0 5px;
So the padding-bottom wouldn't be overwritten


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I see the difference.
`p.then(handleSuccess, handleFailure)`
or
```javascript
p.then(handleSuccess)
p.catch(handleFailure)
```
is an either/or case where only one of them will run, whereas
`p.then(handleSuccess).catch(handleFailure)`
will first run the `handleSuccess` and if there are any errors it will also run `handleFailure`


I know that this has been added here because it is available in all the other parts but I think we should not support adding of maximum length setting for a password.


Accidentally added the circle stuff I've been playing with... Oh well.


I don't think you can ever beat O(#tasks) if you don't have a worker to tasks mapping. No?


Would it be possible to have the Category and Mod drop-downs auto-size on longest contained string? It feels awkward when the app is maximized and the drop-downs are half-screen wide.


I'd prefer calling this via loop->cans->cb than directly. Is there any problem with this?


That won't quite do it - as my later amend to this commit indicates, you can't use `0` everywhere you can use `nullptr` - in particular it doesn't work when initializing smart pointers.


How did you learn about this `subtitleLanguagesCsv`? By inspection or by reading some documentation?


Oh, I am assuming the right-click context menu will be added once the toolstrip buttons do something?


No; I was tricked by the github UI and didn't realize that you're touching `append_variant_to_string()` in the first hunk. Looks good.


It's just me being more used to java.

If I remember right, `return list.add(thing)` would add the thing to the list then return the list in java.


`can be taken into use` -> `used`


Why do we need this code ?


That could be done easily since coursera makes the list of available subs public via its API. Would you rather a different option (--subtitles-all or something like that) or a special case of -sl (such as "all")?


You really don't need to worry about the enum values so much. The only time I've ever seen a situation where it matters was when we were interopping with some existing c++ code and the enums represented well known option values for the c++.


Move this file to macan/src/klee.h


@chrisseaton @eregon Please let me know if I've butchered this.  I don't like the idea of searching up parent frame descriptors twice, but short of passing the `depth` around, I didn't see a good way around it.  Regardless of whether the fix is correct, this seems like the sort of thing that ought to be covered by a RubySpec as well.


`If the above YAML file would be imported, it would create exactly same` -> `If the above YAML file is imported, it will create exactly the same`


commented out line


That's strange. If it's Java, I would expect it to return a `ListAddAndExpanderObjectFactoryFactory` object.
:fire:

;)


woops, I was going for an array of arrays to show the value of map right away... will fix after the kids go to bed


It is on Coursera API documentation:

https://tech.coursera.org/app-platform/catalog/


`demonstrated` -> `demonstrates`


Bots NOW benefit from those.. the message was a typo


`layout()` is a view helper.
`content` is a `$content` variable.
>>By default, the $content variable is populated for you from the application view script rendered. Otherwise, anything you'd normally do in a view script is perfectly valid -- call any helpers or view methods you desire.


What about adding -fsanitize=integer?


rax retry tests


Ouch.


@cpaof thanks for pointing it! :+1:


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (644 of 644 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.32%25-green.svg)


Move -lkleeRuntest to OMK_LDFLAGS.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's better to make it in the ul-li tags, as here you provide the list(!) of the checkboxes


@alex-deaconu I wonder, wouldn't be better to move this authentication to a service so it can be reused and tested? cheers


should that be

```
assert.equal(schema.fields.get('value').types.get('String').values.length, 3);
```
?


A stylistic matter: don't feel too constrained about the column limits: all those backslashes actually make the code less readable than if everything were in a single (but longer) line.

For everyone's enlightenment, I would recommend watching this video:

https://www.youtube.com/watch?v=wf-BqAjZb8M

In short, do not worry so much about the line lengths. :)


Ah yes, https://github.com/xuguangxin/libyami/blob/reoslution_changed/decoder/vaapidecoder_base.cpp#L345 assumes https://github.com/xuguangxin/libyami/blob/reoslution_changed/vaapi/vaapidisplay.cpp#L312 will call https://github.com/xuguangxin/libyami/blob/reoslution_changed/vaapi/vaapidisplay.cpp#L57. But it won't because nativeDisplay.type is always NATIVE_DISPLAY_VA now.  Hence, the user requested "wrapper" driver will never get loaded.


try to avoid direct js in the html, this functionality can be transferred to javascript


Hi I am newbie in BOS and I would I like to know how can I acceed to code source of bonita in order to extend some functionalities ?
Thank you


Ok i do przetestowania tego testowego zasobu - potrzebujemy typ pola kategoria i typ pola podkategoria.

Najszybciej jest stworzyć dwa pliki pola, moim zdaniem mniej więcej plik pola dla kategorii powinien wyglądać tak, to jest prawdopodobnie kompletne rozwiązanie więc możesz od ręki przetestować czy działa i akceptuje określone wartości wprowadzone do pól.

```javascript
var Promise = require("bluebird");

module.exports = function(field_type_category) {

    field_type_category.prototype.isProperValue = function(category) {
        return new Promise(function(resolve, reject) {

            var arr = ["gastro", "sport", "shops"];

                if (arr.indexOf(category) === -1) {
                    reject("Value `"+category+"`" + " is not right category.");
                } else {
                    resolve();
                }
        })
    }

    field_type_category.prototype.encode = function(category) {
        return new Promise(function(resolve, reject) {
            var category_in_string = category.toString();
            resolve(category_in_string);
        })
    }
}
```

Jak przetestować?

1. Trzeba stworzyć dwa pliki `field_type.category.js` oraz `field_type.subcategory.js`.
2. Dopisać do konfiguracji te dwie, nowe deklaracje w pliku `placetag-app/node_modules/sealious-base-chips/sealious-module.json` w obiekcie `defines`.
3. W `main.js` trzeba dopisać do konkretnego zasobu w konkretną krotkę - `type: "category"`
4. Po starcie apki, odpalasz Postmana i wysyłasz POSTa na ten swój nowy zasób.


1640-AddHVACPart1 (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Good.


noticed href should be class


оо, паблик-поле?


OK.


See https://github.com/endlessm/eos-event-recorder-daemon/commit/16bc2be129de4f48e99a178ac569400928f7d930#commitcomment-11415977.


Nitpick: you create the `response_promise` in actor A, but fulfill it in actor B. Since you forward the message, you can just call `auto rp = self->make_response_promise();` in the spawned actor.

> Have you thought about abstracting this pattern behind an easier-to-digest interface?

I'm definitely open for suggestions here. This has the potential to easily break things all too easy by accidentally referring to state in the original actor. I work with a map in the `middleman_actor_impl` to match delegated tasks to the original promise: https://github.com/actor-framework/actor-framework/blob/d6fc83ded888fa8bd26018d9e4af5cae9056810d/libcaf_io/src/middleman.cpp#L150. That's not pretty either. Maybe we should brainstorm a bit in the near future how to come up with a good API or idiom/best practice for delegating tasks.


re-organized all headings to have headings first then specific headings. (moved .home h1 below h3)


You dont want all your p tags to be italic.


G::I::AR::Bwasw.pm also gets that duplicated method "prepare_reference_sequence_index" that can be cleaned up by ReliesOnBwa and "bwa_version". That code would look better with the change even though this change could be out of scope of this PR.


Took off this padding, added it to the header instead. (makes it more even, and easier to line up appropriately with other content.)


$(document).ready is the same as $
So you can write
$(function(){


Please reformat documenting input parameters (@ paramName: description) here and below.


warum? ist doch eine url...


Same as .logo


This was added from above (Because its home specific)


j is not used (mentioned only in code that is commented out)


made this a little more specific.


Better to use syntax like
$("#tab_name2").on('click', function(){


made all p tags in the event div italic.


are there good reasons to keep the lines that are commented out?


Sure, will remove.


added a little bit of padding to align better.


minor edit, should be "Databases you create will **be** listed on the screen"


max-width works better responsively.


width not needed


Its not floating... overflow hidden works better.


Combined padding into one


@gmcculloug i think in most of the places in UI, we use bang.message to display in flash message


its not floating :)


> Nitpick: you create the response_promise in actor A, but fulfill it in actor B. Since you forward the message, you can just call auto rp = self->make_response_promise(); in the spawned actor.

Ah, good point.

> Maybe we should brainstorm a bit in the near future how to come up with a good API or idiom/best practice for delegating tasks.

:+1:

Actually, I use the term "task" already as a proxy actor where actors can register themselves and send a DONE atom once they've completed their part: https://github.com/mavam/vast/blob/master/src/vast/actor/task.h


@selimnairb I have not got a chance to test it out since I am trying to get it work with icommand 4.1, but looking at the code changes you made here, I think it will cause problems with resource file downloading since the bagit_path will be simply wrong for a resource file path. Note that this url API function is used by both bag download and by the resource file download managed automatically by IrodsStorage class (a subclass of Storage which is used in FileField definition for ResourceFile model). Have you tested out resource file downloading after you make this change? I think we should not put any bag-specific logic into this command url API function, otherwise, it will break resource file downloading.


Yeah...
I have been using joe and bob as my usernames, and I must have started an instance, accidentally typed it in, then saved it without noticing and committed. Oops.


I made the change in commit 7e556b2.


Better to move all needed selectors like here "#tab_name2" to separate object in the begging of the function. Like

var SELECTORS = {
TAB2: "#tab_name2",
TAB1: "#tab_name1"
}


Thanks :)


Heheh hopefully we'll have it tested/fixed for rc3


use pipe way syntax for this
$(this).removeClass("passive_tab").addClass("active_tab");


I think this commit is no longer relevant, given that 1.0 is already out/


Prefers 7 lettered words when tied. if tied words arent 7 letters, then it returns the shortest word. It passes the rspecs, but is there another way to do this aside from using a ternary?


maybe add a comment in DM-2537 so that we don't miss it, and mention the DM-2537 on this todo line (and below too)


We should be ignoring these in `~/.gitignore_global` IMHO


ty


Why did you remove the break here? We always break the type if it gets too long:
```
way_too_much_characters_for_a_result_type
some_function_with_yet_another_long_name(int arg0, int arg1, ...)
```

 Especially if the type itself is multiple lines long...


This file completes Breakfast. It passes the tests for the all edge cases under the METHOD, self.highest_score_from(array_of_words).


So, some stats. 2,740 reactions found in the model templates, of which 2,477 (90%) had an unchanged status.

There's 71 reactions that were previously unbalanced, but were re-balanced to be OK, and 121 reactions that were previously OK, but now are unbalanced, the majority of which (83; 69%) are now charge-imbalanced.

This gives me a focus for editing compounds, and trying to figure them out, but balancing charge is tricky work.


PHPCS: Whitespace found at end of line


PHPCS: Opening brace should be on a new line


No need for separate class to show/hide elements. Use instead jQuery method .show()/.hide()
For checking display use jQuery method .css()
$(this).css("display") === "none"


#!/usr/bin/env python


wofür wird ![feature(collections)] benötigt?


This was my initial pull request, but please ignore this one. I pushed my updated project


Thinking that this commit should dry the code up greatly! At this point I think it should be good to merge?


Most importantly you should never hardcode broken urls but use the url template tag.
https://docs.djangoproject.com/en/1.8/ref/templates/builtins/#url


are you sure qt5-svg isn't needed?


No need for the selector with taq and id. Id is more than enough for this purpose


I guess not, I'm always forgetting the sorting step.


Better use event listener syntax like
.on("keyup", function(e){


:+1: Did you read my mind?


Oops sorry that was the wrong repository. You can remove it


Good find. The old unit test framework auto-magically converted string literals to `std::string`. Using `strcmp` is of course the right thing to do.


fj


WTF ? This clang-format is...weird...


why dont you just load all needed datas in memory and do it from there? less lag :/


Avoid use of the variables without declaration
var correct =  0;
var incorrect = 0;
var all = 0;


Decoders isolate either temporal or total rate information. Updated 2015_05_28


I love you @orian :two_hearts::two_hearts::two_hearts:


that's the old (wrong) behaviour....


this is bad.


@epchris I got a "Malformed version number" error when running bundle install on a fresh machine. Ref 42a17db160a9c47bc835cf0a03d7e303dff4d74e installed without problems. It seems that the dash threw it off.


Move event listener to other event listeners, for better readability of the code, it better to keep them all together


it's better always use strict equality "===" instead of the "=="


Мне больно от своей невнимательности.


This feels a bit redundant with the sentence above.


Perhaps it would be nicer to keep consistency with what we have for `nn.Linear(%d -> %d)`, so `nn.SpatialConvolution(%d -> %d, kW...)`?


If you use the jQuery in the project use it in all project. There are no benefits for using document.getElementsByTagName() instead of $() if you already connected jQuery library to your project.
So it's better to use $('input')


servers **MUST NOT** include any additional members is redundant with this from the document structure section:
> Unless otherwise noted, objects defined by this specification MUST NOT contain any additional members.


/s


Use jQuery here instead of document.getElementsById


Hello,

For the help you have provided, I have decided to return the favour, providing minor changes that improve the usability of the scripts.

There are three general things to note:

1) Your metadata was not properly aligned. This has been fixed.
2) I have provided an improvement to the URL 'include' by using the more strict and safe match patterns. It also cleans up the addressing, as it was more convoluted than it needed to be.
3) Be careful with the bracing. While it is OK to use inline bracing within Javascript inner functions, it is a general bad coding practice. Also, it improves code legibility tenfold if braces are used, even in one-line condition statements.


vim links?


You can move this string out of the condition check, as you are doing this in the if{] and in the else{}


There are no need to re-write this field as it wasn't changed


Remove this line before merging.


Oh I didn't think about falling through the try-catch. Added a throw right after the call to maService so that we don't fall through and pass the test.


You can move this string out of the condition as the "all" variable would be changed anyway


I think the actual vendored files may be missing from this commit.


s/verson/version


I do not know, it seems that you ask the client to give information that was previously automatically calculated.


before this line add `if (finishing) return;`


:see_no_evil::hear_no_evil::speak_no_evil:


Is there an obvious reason I'm missing for why this needs to be a function pointer?


hfd


ghfd


[`g_variant_get_normal_form`](https://github.com/GNOME/glib/blob/master/glib/gvariant.c#L5717-L5754) behaves very similarly to `g_variant_byteswap`. It either calls `g_variant_ref` on the variant given to it and returns that or it creates a new variant, calls `g_variant_ref_sink` on it, and then returns that. I realized while looking through this again that I can get rid of the `g_variant_ref_sink (normalized_variant)` call below since `g_variant_get_normal_form` never calls `g_variant_ref_sink` on the variant given to it. Not sure if there's a simpler way to deal with the reference counting.


@tonydaly Thanks! :blush:


Thinking of performance, I'm wondering if there's any way to avoid the second call to BOService?


description of this commit says "fix comments", so I am a bit confused where are the changes in this file (and in some other files) coming from. It doesn't look these are related to oneof.


this is a more useful name than `standardizedSearchText`

you could do the same with the other two (`trimmedSearchText`, etc)


this assumes that user is on the host.


Thank you! Is the rotation angle around the spin axis is determined as in Plus (x axis is parallel with the sensor's x axis, unless that axis is almost parallel to the spin axis; then the sensor's y axis is aligned with the x axis). It's useful for reproducible calibration of asymmetric tools, such as a cautery, which has a top/bottom/left/right side.


are we sure `searchText` can't be `null` or `undefined`?


This is the initial class header


Style point but I would move the new String() into the fromJson function (i.e. it takes a byte array not a String). Also it's good practice to always specify the encoding when creating a new String from a ByteArray - new String(byteArray, "UTF-8").


Typo


but doesn't the `escapedSearchText` suggests `escapes` in it? While in the other cases, they're not related to `escapes`.


`accrue` is a new one.  Why not `accumulate`?  Or something much, much more descriptive, like `allInSerialBeforeFailure`.  I just don't think anybody will read `accrue` and get that this is ... delicate.


Well,  maybe we can revisit this request now that I'm making UTF8 encoding an explicit assumption that `postgresql-simple` makes.


Such indexing.


See in particular a188a1178d4acd9c6414394040e8c6c3b5c74c46


Moved the Job styles up to the Job styles section. :)


Added some organization to the members styles


just an extra space


...or if we were in C++14 land then `"foo"s` with an earlier `using std::string_literals` ;)


Instead of padding-top, since you're already position absolute anyway, might as well just use the top property.


took away right and left padding, added a width instead. (Better responsively) and added margin for the spaces.


That timeout is intended for ´self.send_command´ (I think only waitForReadyRead needs it), which waits until the other instance finishes, so it needs to be long. The latex examples may take a few minutes to run. But I agree we should use a shorter timeout for establishing connections.


I accepted the pull request from Daniel so the extra / should be fixed.

On Thu, May 28, 2015 at 2:07 PM, James Carbine <notifications@github.com>
wrote:

> Yeah, that is one bit of code that I have changed and not committed yet.
> In index.js line 66 apiPath need to remove that forward slash.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jbasdf/react-kindling/commit/1c1ca08a0e5f8fe39ae109c3c032044df9d70be3#commitcomment-11416030>
> .
>


took away margin right on every 3rd field.


`.reasonToNotSync`?  Starting "should" strongly suggests a boolean result.


Added styles for textarea, added the placeholder text styling. (You had the placeholders hiding and the labels absolutely positioned above the fields. This would work visually, but if you would try to go enter information, you couldnt because the labels would be blocking the form fields.)


+1, ```nn.SpatialConvolution(3 -> 96, 11x11, 3,3, 1,1)``` would be much better


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.55%25-red.svg)


Side note on why it was reverted:

This change is technically a breaking change if you were relying on the previous buggy and unintended behavior. It'll be included in 0.17.0.

What the fix is supposed to do:

bootstrap, recycle, and flush replace state rather than merge state.


Same explanation as the input placeholders + added some styling for IE only. (These will only be display block in IE) - we'll set it up later.


_chuckles to self_


r+


Having a max width doesnt matter in this case because the parent has a max width. instead, width of 100% would be good. :)


Pretty sure I had a reason for not enabling it globally, but I can't remember what it was. I'll need to check that.


Moved all job styles to the job section in the CSS


I'd prefer to reflect m/g's real semantic, which isn't "disabled" but "not enabled".


Thank you @VanessaE ! :)


rax retry tests


I was going to complain about success not being success, but I'm not sure I care.  I think `SyncResult` *might* be better.


Thanks, changed to `26:26` to match the expected "guest" ownership.


See prior comment on "UTF-8"


Very meta.  I like it.  s/ready/implemented/, since "not implemented" appears in many language's Error hierarchy.


ping @gpbl ! :smile:


git blame Peter for revealing my top secret password to the whole world


Nice.


Mm, taking a closer look at this with more brainpower, I still need nested loops because I have a map whose values are arrays of Sfx objects. But you're right that the `keys()` call is unnecessary. It can be simplified to this:

```haxe
		for(sfxByType in _typePlaying)
		{
			for (sfx in sfxByType)
```


Render the `_sidebar.phtml` view script from within the `preDispatch()` method.
This way follows a more proper separation of concerns (leaving view-related logic and functionality within a view script).


You weren't supposed to find this :scream:


Hella Dope yo


Sorry, it is generated from generate_protos.sh. I should run it after merge from master (someone has changed the .proto file I guess)


hhhh


It would be great if you could be available so we can contact you maksis :)


86139842-AddAutoSizing (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1652 of 1668 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


Will do; yeah, that is definitely the downside.


There's something about the positional outcomes that seems wrong to me.  I agree we want ordering, so a list; but I really want to make it easy for consumers to map steps to outcomes, so perhaps a tuple `(identiifer, outcome)`?  You have strings like "tabs and clients" elsewhere; elevate their status?


Is this the proper template name? Generally the template names have followed the pattern used in the other node config in this PR where the middle element is the ubuntu version number, like 1504.


grad is the first derivative which should be just `alpha * 2 * f`   Note there is a 2 for the square (or a 1/2 in func)

the expression here looks fine for the second derivative `*2` and I guess a transpose missing

When I wrote my part, I needed to switch things around because of missing transpose. and confusion about when I only look at the diagonal and when at the entire matrix.


`sidebar` is the name of the view below:
```
application/views/scripts/guestbook/_sidebar.phtml
```


Y u no retain authorship?


How about this instead:

```python
members = len(pc.get_members())
```

or if `len` doesn't work with `get_members`, it looks like it returns a `github.PaginatedList.PaginatedList`, which has a `totalCount` property:

```python
members = pc.get_members().totalCount
```


@ablwr what possible reason could you have for looking through this code


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


This object **MAY** also... ?


type!=VOLUME and prop_valid_for_type(CANMOUNT) seem like they are essentially checking the same thing (is this a filesystem).  It would be better to make that check once.  e.g.:

if (prop_valid_for_type(CANMOUNT)) {
  if (prop_get_init(CANMOUNT) == ON)) {
    zfs_mount()
  }
}


Wouldn't Config::Perl::V be appropriate in this case?


No that's not the proper name, it's very wrong. I'm sorry.


This means "render the `_sidebar.phtml` and then append the string *Hola* below it.


Haha I was trying to figure out if the "Flatiron profiles" are indexed by google but this came up instead.


it's happening


Both. Uploaded files are stored in your "dataroot", the directory that you specify in $cfg->dataroot in your config.php file. Then we store the filesystem path of each uploaded file, in a table in the database. When you access download.php?id=xxx, Mahara looks in that database table, finds the filesystem location of the file, and serves that file up to you (assuming you have permission to view that file).

This is for security purposes. First, to preserve the privacy of uploaded files. Second, to prevent an attacker from directly uploading a file into the web root, where it might be executable by the web server. (The dataroot directory is meant to be outside your web root.)


By the way, you can also ask questions on the Mahara developer forums: https://mahara.org/interaction/forum/view.php?id=48


Do you mean that we should consult `g_network_monitor_can_reach` and refuse to attempt an upload when the user explicitly requests an upload while offline? Or do you mean that we should keep what is currently done in this pull request (namely not consult `g_network_monitor_can_reach` when the user explicitly requests an upload, meaning their data will be lost if they run the `eos-upload-metrics` script while offline)?


@jbarnett-r7 hey look. The bug I thought would've got hit actually wouldn't have with the one liner. If you wanted to go ahead with the as_xml change only go for it. The `unless ret.nil?` should protect against it just make sure to test creating new and updating as well.


`jQuery.event.preDispatch` is a kind-of-public API though. I'm not sure we can remove it, and it is symmetrical with `.postDispatch` which we still use.


This didn't seem to work, but there probably is a way to make it do so.

M.


Sure! If you want to PR that works for me.


I meant consulting the network monitor. I realized after I wrote that comment that it is not how the current code has been written.
Your call, but if it's not too big of a hassle I would move the network monitor check to the common code path.


thanks :+1:


The intention was to avoid revisiting sources and destinations outside the bound.
However, as is, this turns all graphs into trees, because it doesn't add edges to visited destinations.
I think this line should be "when not (bounded bound (Block.addr blk))" or better, reuse skip with
"let empty = Vis.create ()" somewhere at the top and "| `Block (dst,_) when skip bound empty dst -> gr"


it is necessary so that the user always starts on the schedule page, regardless of how much of the form s/he has completed


Not sure that primaryKeyMap.toString() is useful information for the end user in an error message?


done


This should be a PanicAlert or, better, cleanly abort emulation.


Removed the wrapper - its unnecessary. We can add a margin and width on the button instead.


added styles from the wrapper to the button.


Oops. No, but I forgot that non-construct only properties can be set from outside this class at any point. Will add a `g_free` call above the assignment. I don't know of a clean way of making this property construct only since we are supposed to pick up changes to the environment without a reboot.


Edited the header styles so that the headline and the logo would line up better


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Hmm.  I looked at the Gruntfile I see the code already there. I'll try it and see if I can pick up on the issue.


Makes sense to me.


I thought the goal was to mirror updateUI() and consolidate all calls with the same purpose to the same function?


Does this work?  I've been meaning to build in retry support, but haven't gotten around to it.  If this works you should open a Pull Request, we'd definitely merge it!


Ripping off HAC, as usual.


Changed the width a little bit on the option prev to make it work for "jobs available"


Sorry I said sensu_handlers::install, I think it makes more sense to keep this in the jira handler, that way it is only installed if it is deployed.


Wow. That was easy :)


Chagened margin right to a percent so its freaking awesome responsively.


Took off margin on every 2nd child.


The more link was floating left.


On the things to do page, I think you can handle the phone and address icons.


Any thoughts on how to properly wait for the soup session to abort? My intent here was mainly to make sure that calls to `emer_daemon_upload_events` always receive a call to their callback. Without this while loop, we don't report failure when the daemon is finalized before the upload completes.


I'm confused why this commit seems to not reflect the previous commit's change to this.


Can you give me the use case for this?  This looks pretty straightforward, but trying to understand the need.


OK, makes sense


See https://github.com/endlessm/eos-event-recorder-daemon/commit/cd562466b950d9c3bebe92d50002920f980a9f0b#commitcomment-11417358.


What do you think of a rename to getAllSearchHistory?


@lynnetye Read my comment again. Reading comprehension!


Fix for neelance/ffi_gen#35


Sound good; it shouldn't be a problem.


How about renaming the above to getAllSearchHistory?


No; here I mean `G_PARAM_CONSTRUCT`, not `G_PARAM_CONSTRUCT_ONLY`. That implies that the setter will be called with the default value at construction, if no other value was provided by the calller.
That means that you could move this code into the setter.


The above should be getSearchHistoryByUuid


with `when not (bounded bound (Block.addr blk))` we will go into infinite loop. But I got the idea. I think, that the following should work correctly:
```ocaml
  let to_graph ?bound entry =
    let vis = Vis.create () in
    let rec build gr (src : Block.t) =
      if skip bound vis src then gr
      else Seq.fold (Block.dests src)
          ~init:(G.add_vertex gr src)
          ~f:(fun gr dest ->
              Hash_set.add vis (Block.addr src);
              match dest with
              | `Unresolved _ -> gr
              | `Block (dst,kind) ->
                let edge = Cfg.E.create src kind dst in
                let gr = G.add_edge_e gr edge in
                if skip bound vis dst then gr
                else build gr dst) in
    entry, build (G.empty ()) entry
```
can you test it?


Why not just int instead of int(11) for these two?


This method `save_smt_options()` along with `initOptions()` (which handle the saving and loading of the options) do work as implemented with this pull request, but I think we can improve the code and make it more future-proof.

### Current issue

The two operations use different logic to read/write data to different places, but I would expect that if I save an option and then load it again it should read/write to the same place. Does that make sense?

The logic for **initOptions** checks:

- If the plugin is network activated
- If options are allowed to be overwritten

The logic for **save_smt_options** checks:

- If the action is taking place on the network admin page or not

### Potential improvement

Can we consolidate the logic to a helper function? For example, a function like `get_settings_save_mode` that checks the following:

- If settings should be loaded/saved to the network or jus the single site
- If settings should be merged (override allowed) or if just the network settings should be used

And then each function, `initOptions()` and `save_smt_options()` can reference that to determine if it should use things like `update_option` or `update_site_option` - that way the logic is consolidated and the save/load functions will always behave the same way because they are using the same logic.

Does that make sense? Again, it does work as implemented right now but I think this change might make the code a little bit easier to read and more maintainable.


Because the build needs to be repeatable. I should have confidence that the CI service is building exactly the code that I specified when I committed. If the codebase needs to be tested against a newer version of some dependency then that's something that should be done by someone locally before committing their changes to the Gemfiles.

James Harton
Professional Tinkerer, Resistor
http://resistor.io | @jamesotron | +64226803869

> On 28/05/2015, at 21:29, Matthew Rudy Jacobs <notifications@github.com> wrote:
>
> @jamesotron interesting. Why do you think it's dumb?
>
> Surely it's good for getting travis to install the latest gems that match your dependencies, and hence break when your dependencies are too loose.
>
> —
> Reply to this email directly or view it on GitHub.
>


Looks ok to me.


@tigerw :+1:


I don't think you should ensure that. DBus will already error out the IPC call if the daemon exits while a method call is pending.


@zhon I got registration working, though we may want to make a few tweaks to it. Currently when you click on the register link, it is sending the entire course rather than just the course id. I thought about making it be just the id and then look up the course from the `CourseRepository`, but that just felt like a lot of chained async calls that I didn't want to nest right now. Plus with how easy it was to return the whole course in React, it made me wonder if that might be how people would probably do it.

We can change it to use course id if you prefer to keep that aspect of the angular kata, or maybe we don't worry about it because the refactoring will add in other complications?


While I don't have a problem with you using this yourself, as a mod it's really useful to get the thread moved links, and if they weren't available, people would get confused as to where their thread has gone (which is why we leave them in the first place).


It is more like `jQuery.event.special.<event>.preDispatch`, as far as i know, this structure was never documented, although there is some code that used it - https://github.com/search?l=javascript&q=special.preDispatch&ref=searchresults&type=Code&utf8=%E2%9C%93.

It seems we have the right to remove it, it is nice concept though, so i'm cool with whatever.


You still don't let anyone know why it failed....


Thanks @dkayiwa  for the review, i will be addressing these issues soon, logically there's is no need of using int(11).


if (! type.getMultipleFlag() )


Ie, your swallowing the exception. Please either log it as I suggested, or include the exception message with the test failure message.


fixed b0c2af0afb34ad920e416d5a0a00b65300f1517a

thanks


*is* a spherical shell


fixed b0c2af0afb34ad920e416d5a0a00b65300f1517a thanks


Which "previous commit" are you referring to?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.186](http://teamcity.monogame.net/viewLog.html?buildId=7728&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


First commit


Am I missing something here? Where are the definitions for LineMatch1, LineMatch2, LineMatch3?


That cool.
I like it.


the doc was not change...


The formatting looks much better in notepad++


'*provides* cross-platform HTML/JS tools' sounds better?


TeamCity YaccConstructor :: YC.Core General Build [Build 403](http://teamcity.codebetter.com/viewLog.html?buildId=192240&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


TeamCity YaccConstructor :: YC.Core General Build [Build 404](http://teamcity.codebetter.com/viewLog.html?buildId=192241&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


ブランチっていうのが分からなくて消えたのかと思ったｗｗ
ほとんど完成じゃね！？
結構ガッツリ遊んじゃったよ


I think you mean > rather than < here


Style here, you should have a space between the 0 and the ?


players -> players'


I need help with adding this to shrinkwrap; following the readme still errors.


It looks like this line is now redundant with the new line below it.


@cgrayson, LGTY?


Yes, you're right. I thought we had documented it but the [only docs we've published](http://learn.jquery.com/events/event-extensions/) don't mention it. So maybe it would be okay.


for god's sake: ack


you might not need the `FINISHED_PAGE_SOURCE` anymore


what about an exercise using a mixin strategy

```js
function Animal(name){
    this.getName = function(){
        return name;
    };
}
function Dog(name){
    Animal.call(this, name);
    this.legs = 4;
}

```

I think it is important to illustrate that the private state in Animal makes it not an option for prototypal inheritance

```js
function Dog(){
}

Dog.prototype = new Animal('I don't know the name yet');
```

And also that you can do multiple inheritance with the mixin strategy.

That said... I'd prefer it be less prescriptive... so something like.

Exercise: ?5?
1. Create an Animal constructor with some private state (experiment with some instances)
2. Create a Dog constructor that inherits from Animal (experiment with some instances)
3. ...

just thinking out loud... as-is there is plenty for a mentor to get off the ground


mkdir -p "...". I don't expect GOOGLE_STORM_LIB_DIR to contain special characters or spaces, but you never know.


Sorry, I just thought it was strange.


* Selector, not setter. Geez.


Doesn't look TOO bad (actually I've expected something ugly).

Why did you move that code for static assets from tasks/__init__.py? Won't it solve your problem with ugly hack with circular imports if you put that code back?

And a general note — can you add a comment to the code that explains in greater detail what's going on with storage/pluginwrapper?


There's a helper normalize_boolean that might be useful (allows true/false as values).
Example: https://github.com/GoogleCloudPlatform/bdutil/blob/e09d7ab2d2f7584c69f36b36fb2cdc55e8c5ed3c/platforms/hdp/ambari_manual_env.sh#L59


This is the fix for issue #3


small nit, payloadLength is only used when customPayload is defined so no need to define outside of scope.


El valor tiene que ser string. Si lo pones como 0 puede causar error si el moso SQL_STRICT está configurado en MySQL. Tienes que usar '0'


This step seems a little vague.please check


Es bastante contra-intuitivo que '0' quiera decir 'Yes' y '1' 'No'


TeamCity YaccConstructor :: YC.Core General Build [Build 403](http://teamcity.codebetter.com/viewLog.html?buildId=192240&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 116 Build time: 00:12:24


Aquí es al revés de dentro de data.sql. Ojo.


TeamCity YaccConstructor :: YC.Core General Build [Build 404](http://teamcity.codebetter.com/viewLog.html?buildId=192241&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 116 Build time: 00:12:41


[![Architectural model](http://api.artsmia.org/images/175/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=175)


[![Architectural model](http://api.artsmia.org/images/5419/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5419)


[![The Immaculate Conception with Saints Francis of Assisi and Anthony of Padua](http://api.artsmia.org/images/1613/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1613)


[![Dressing table](http://api.artsmia.org/images/425/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=425)


First upload


I'd bump the ALPN remote to the top level. It's simply unused if bigtable isn't enabled.


kk


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.186](http://teamcity.monogame.net/viewLog.html?buildId=7728&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:22:09


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.187](http://teamcity.monogame.net/viewLog.html?buildId=7732&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@noelpaz we have problems:

1) As I said in our meetings, it is expected to have a single sofware. If we have command line argument, then no screen is shown... they can run as invisible or simply not instantiated.
2) The firmware updater tool, will have two purposes: the first is to be part of the installer, which besides to install it might use the same software to update the galileo SPI.
3) Two different sofwares, means two licenses, a new PDT session and more process involved to publish the tool.

My question is.. I know you talked last Monday about a new JIRA because you were not able to do it in a single software.. but I did not receive any communication why it was not possible. I would like to explore a little bit better the problems you faced and how I can help you with that.
Last Friday, I receive an email with an UI with a problem showing "proporties not set properly" and in my mind we were ok keeping everything in the same software.
With this push I am assuming we are not ok yet.


This highlights one of the problems with the treatment of exceptions - on line 1447 we need a `try` block and on line 1465 we don't? This is madness.


@tmatsuo Made changes to docstrings according to your suggestions.


I definitely understand why you don't want to be responsible for receiving reports, but perhaps if you enable issues for this project, other people can/will pick things up?


is behaves -> behaves


You must bump the corlib version since you changed the interface between it and the runtime.


Isn't last_search_date clearer?


You should be able to simplify this a lot by using "translate_id_to_symbol_name" to get the symbolic name of the boundary id and just test if it is "top"/"outer" or "bottom"/"inner". Then you don't need all of these different cases.
(It's a bit unfortunate that they do not have the same names as in the spherical shell geometry, @bangerth and @tjhei, what do you think?)


Yes, but I'd prefer to avoid adding prerequisites to this module, even if they are in core now.  If the workaround was more complex then it would probably be justified, but I think the ccflags test is reasonable for this case.


I also saw `tuple` in french C# and Python courses. As I said, I am pretty sure that its common to use the english term. If we want to be "strict", uple is the way to go. I prefer to use tuple, but I thought It was worth commenting it.


I have a feeling there's going to be a sequel.


Great, files are all on my machine but completely erased here.


Is this revert simply to avoid using std::sort() on pgi?  Given that we want to get rid of Vec<> uses anyway, can we not use std::vector with qsort?  (IIRC, there's some way to get a pointer out of std::vector?)


same here


shown in english (irregular verb)


Can you move the || to a new line so that it's easier to read?


Great! I don't think this matters. With  the new upcoming ``GraphQL`` and ``Relay`` this whole problem will be solved.

The components will specify the data they need. All the requests will be combined (with duplicates removed) and sent to one ``store`` which will request the data. The data will be sent out to the top level components and filtered down.


Can you add the chunk to the respective comment in the spherical constant compositional initial condition?


Why is model and entity changed to ModelBiped and EntityPlayer?


We could, but I'm worried that the problem is with my current use of the vector itself rather than how I passed it to the sort function.  As you can see, the code changed is fairly small so it won't be much of a hassle to redo it


This will turn on true type fonts, set the background black with white text, and enable a scroll-bar for xterm.


@banjaxbanjo can you do this as well for the menu where SMS shall be deleted?


The issues were enabled a long time ago but people attached binaries. Most of the binaries were copyrighted by someone other than the poster and I had to delete files all the time.


OK.  Would it make sense to narrow down the source of the error by trying to use std::vector with qsort()?  If it works, that suggests that the issue is with std::sort() (or our invocation of it?)


Interesting. I'll add that to my reading list tonight. :smile:

Also, I noticed that if you register for the same course twice, React sees two items with the same `key` and doesn't show the duplicates. The duplication is still there in data, so that "extra credit" assignment could still apply, it just isn't as visible as before. Or we could drop the `key` or ensure that the key is unique with a counter or something...


the if condition should be if(!connection.isConnected())


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1658 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


For each of your gifs, you need a sentence or two before hand explaining to the reader what the gif is doing.


smth is not right here:
after update i have found ... collision with another npc_text..
I'll update this as soon as ill find whats wrong...
Sory for problem


Whenever you present text examples like this, it should be above the relevant gif.


should your first gif above be in this section?


Can you call this chunk_geometry_model?


Dropping the ``key`` will result in warnings in the ``console.log`` (it also runs slower).


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


"type out" is the wrong verb because it's not descriptive.  Better is to say "enter the colon commands `:tabn`..."


s/commands/normal mode commands/


Can you do the Assert() as the first thing in this if() statement?


Thank you. Commands `apt-file search` or `dlocate` can be of help. :)


Neat. Just checked out the gui(I didn't test the functionality, though). The only issue I noted on testing is only showing the Name when selecting, which will make it difficult for some (especially if have same ACO names in different sections). To clarify could consider placing the section Title (translated) in front of it or do what I did in Administration ACL where have the section Title there, but not allowed to select it.

Review is complete.


This is not unique to the `gT` commands.  Any normal mode command can be repeated by typing a number in front of it.  This is good special case to point out, but you should mention that it is a special case.


`tabm` is a colon command.  I don't care whether you say `:tabm` or `tabm`, but you must be consistent throughout the article, and you must always say it's a colon command.


reword

> is a number in order to move the tab to that position.


You should put this in a table where the left column is the command and the right column is the effect.


Delete these sentences and put this in the table.


The depth/color write buffer is sent when an application ask a synchronisation with the RSX.

I'm assuming that Cell/RSX combinaison is similar to CPU/GPU on PC : the GPU is always several commands behind the CPU, in rpcs3 it means the command buffer "get" pointer is "behind" the command buffer "put".
This means that Cell can't modify data like vertex buffer or textures that the RSX has not finished using otherwise it will result in undefined behavior. It also means that Cell can't use data being written by the RSX like the depth buffer and the 4 render target until RSX has finished writting them.
PGRAPH backend semaphore release is the way for RSX to tell the Cell that it has finished rendering operation.

Of course this is a quite strong assumption I'm doing here, since that PS3 being fixed hardware it might be possible to use strict timing between RSX and Cell to avoid explicit synchronisation between them. But I think this is very rare (clock rate may slightly vary between 2 retail units) so I will probably add an option to always write depth/color buffer if a game is broken. But in the meantime it works well with the samples I use.


The remove/reinsert model is relatively simple, but it is not without drawbacks:
* We lose the guarantee that network payloads contain data that is contiguous in time, which will make it harder to analyze.
* We lose the guarantee that ascending network send numbers should correspond to events increasing in time.
* If we are allowed to stuff events back in the persistent cache, it results in more disk I/O, which Roddy has expressed considerable concern about for the eMMC devices.
* The write to disk may fail in the case where we're putting data back in the persistent cache.
* The persistent cache and/or RAM buffers may fill up while the request is on the wire.

I don't have strong sentiments about the locking except that we should either support threading throughout the class or not support threading in this class at all ([karate yes/karate no](https://www.youtube.com/watch?v=Y3lQSxNdr3c)). Philip recommended using `GAsyncQueue` even though as you point out we only use one thread today. I think the advantage of dealing with the locking now is that support for multiple threads can be a big pain to add after the fact. (Also, we support multiple threads prior to this pull request, so I would want to remove that support if we're not going to continue to do so.) Of course, the threading support is a bit of extra work and isn't tested.


You are a gent! Thanks.


parental merge


How about "Add new content" or something more generic for the title, since technically this could be a paper from arxiv?


why?


GroundDomainUpdate (sushobhit) - x86_64-MacOS-10.9-clang: OK (1607 of 1633 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.41%25-yellow.svg)


You should reword your explanations so that they explicitly tie into the animated gifs.  For example, say something like: "I the next gif, notice how I use the `:tabn` and `:tabp` colon commands to move between tabs.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.188](http://teamcity.monogame.net/viewLog.html?buildId=7736&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.187](http://teamcity.monogame.net/viewLog.html?buildId=7732&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:23:12


Because otherwise GCC with no flags complains that:
```
Test3.c:256:5: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
```

I assume the only reason you don't see the problem is that gcc is symlinked to clang on OSX.


I didn't know about this command.  If you call `:tabe path` where `path` is a directory name instead of a file, you get the same effect.  I frequently use `:tabe .`, which seems to be the same as `:Explore`.  You should mention this.


Ok, this make a lot of sense.


Dead code.  This'll never get invoked since initVA is only ever called from setDrmFd().


Same here, move the || to its own line.


Yeah, you're right.

Maybe this shouldn't even be wrapped in a try\except, py.test seems to do the right thing. It will raise a FixtureLookupError with a formatted message:

  def http_server(request, io_loop, _unused_port):
        fixture 'app' not found
        available fixtures: pytestconfig, app1, cov, recwarn, base_url, http_port, monkeypatch, http_server, http_client, _unused_port, io_loop, capfd, capsys, tmpdir
        use 'py.test --fixtures [testpath]' for help on them.


Your example below compiles and runs a program, but it does not bind it to a key like the text says.


@ntoff Interesting concept. Discussing the idea at #2184


86139842-AddAutoSizing (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1658 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


This is a special case of the features provided by `:source`.  The command runs whatever vim script is in the file mentioned. The `mksession` colon command just happens to create a vimscript that recreates your session.  But you could run it on any vimscript.

Make sure to point this out.


This is great! :+1:


You're missing a 'T'.


This line sucks :100:


We should only skip if `braintree_customer_id` exists **and** an exchange route corresponding to `braintree-cc` exists. All participants who've viewed the credit card form have a `braintree_customer_id`, only those who've added a card have the `braintree-cc` exchange route.


This function will never get invoked... see comment below.


It's fine to have a conclusion, but your's doesn't really add anything, so it should be removed.


Lol, how did you find that? Will fix, thanks!


Okay, I was wondering about that. Thanks.


Why are empty POST requests allowed?


#2 fixed


Shouldn't all the xml views all be in default, not local ?


About the "Corpus" comment and question... James texts are just one type of "corpus". I think we need to move to an architecture where this is reflected. But lets approach this after we get the wiki-decompression script plugged in and can see that working.


Correct you are. Reverted in https://github.com/feross/instant.io/commit/3fc9e682b428b2e37456d16af87baff1434779a2.


Directories are still supported in Chrome via drag-and-drop.


does this have to be added to the document?


I would move this to an `init` function and have the map signature as `map[string]func()Policy`, such that looking up the policy would look like -
```go
if policyCreateFunc, ok := supportedPolicies[c.Val()]; ok {
    policy = policyCreateFunc()
} else {
    return upstreams, c.ArgErr()
}
```

and `RegisterPolicy` looks like (now that I think about it, you don't actually need `Name` on policy my bad).
```go
RegisterPolicy("random", func()Policy{return &Random{}})
```

The problem with the current implementation, is lets say you have a custom round robin policy and multiple proxy backends. In your `custom_policy.go`, outside of Caddy, you would expect to do something like

```go
import "github.com/caddy/middleware/proxy"
func init() {
  proxy.RegisterPolicy(&MyRoundRobinCustomPolicy{})
}
```

The issue here, is that there is only **1** Custom RR policy, shared among all backends. This means for every request, the internal RoundRobin counter will be roundrobbing, different hosts and incrementing its counter every time. (Simple: you lose the ability to have one policy instance per backend).


Can you add a comment that says what the test does?


Also, note that gacl has it's own function for collecting all ACO in addition to functions to get other stuff( http://phpgacl.sourceforge.net/phpdoc/phpGACL/gacl_api.html#get_objects ):
``````
$list_aco_objects = $gacl->get_objects(NULL, 0, 'ACO');


Don't set `balanced_customer_href` to `NULL` right now, we need it for payouts. Let's delete the column when we're sure that it's of no use.


Oh, and where is the test output? Did I miss that?


Which `braintree_customer_id` should we use for users who have already viewed the credit card form?


This is completely incorrect. What happens if other themes are added to the color_themes.yml as well? You could do this:
```ruby
before do
  [...]
  @available_color_themes = AVAILABLE_COLOR_THEMES
  [...]
end

after do
  [...]
  AVAILABLE_COLOR_THEMES = @available_color_themes
  [...]
end
```


Same as above.


Yay!


@GrahamCampbell lol


Clever name!!


No, it does not.


Just skimming through latest changes. Thank you for the great library!


"the class" is the daemon itself, so it does not make sense IMO to think about it abstractly. Since I don't see the daemon gaining new requirements about operating on data from multiple threads concurrently (and we can fully control it in any case, as again the daemon is not a library), I would not put the mutex in place and use GQueue.
I am fine adopting your behavior of queueing requests for now but we don't need locking for that.


implements changes per issues:
* #5 Add U/V/W crews
* #6 Allow for Afternoon Shifts


LGTM


I panicked as the site went down for about 30 seconds and my torrent stopped. Not a big deal, since I just restarted it, but couldn't all these updates to the site mess up seeding?


Sorry, line 277 should be
bounds = current_resolution.Bounds
I don't know how to edit the proposal.


Overall, this is excellent.  If you make the changes above and the changes below, you'll get 120/100.

More changes:

* It's annoying that your gifs are different sizes.  Let's standardize them all to be 800px wide and 600 px tall.  If you don't think that's enough space, let me know and we'll pick a different size.

* You frequently use normal mode commands in the gifs, but it's impossible to tell from watching what the commands actually are.  It would be nice to put a popup in the bottom right displaying `gT` for example when you switch to a different tab.

* The main writing point that needs fixing is better integration with the gifs.  Otherwise, your writing style is perfect.

Any questions?


https://www.youtube.com/watch?v=JIOCc0tfoqA :smiley_cat:


See https://github.com/endlessm/eos-event-recorder-daemon/commit/cd562466b950d9c3bebe92d50002920f980a9f0b#commitcomment-11418069.


Is all this nesting really necessary?


:clap: :clap:


below we are accessing 'routeTable.routeTable' when 'routeTable' can be null. You might want to just return null from here


I see your point!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.188](http://teamcity.monogame.net/viewLog.html?buildId=7736&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:21:40


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.189](http://teamcity.monogame.net/viewLog.html?buildId=7740&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


please remove this console.log


I meant dst not blk in the comment (typo). I don't see the infinite loop.
Just by looking at the new proposal, it seems that it will revert to the undesired behavior with edges outside the current function (add_edge not guarded by skip) if dst falls outside.
I can try to test it anyway, but I have some difficulties installing from master (I'll contact you on slack).
Meantime, this is what I was trying:
........
  let to_graph ?bound entry =
    let empty_vis = Vis.create () in
    let vis = Vis.create () in
    let rec build gr (src : Block.t) =
      if skip bound vis src then gr
      else Seq.fold (Block.dests src)
          ~init:(G.add_vertex gr src)
          ~f:(fun gr dest ->
              Hash_set.add vis (Block.addr src);
              match dest with
              | `Unresolved _ -> gr
              | `Block (dst,_) when skip bound empty_vis dst -> gr
              | `Block (dst,kind) ->
                let edge = Cfg.E.create src kind dst in
                let gr = G.add_edge_e gr edge in
                build gr dst) in
    entry, build (G.empty ()) entry
........


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (644 of 644 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.33%25-green.svg)


just confirming, does this "%s print the array constants.route.nextHopType correctly?


Whenever new commits happen on this repo, https://instant.io goes down for about two minutes in order to redeploy the latest code. This shouldn't affect people who are already seeding. It just means that new people who try to visit https://instant.io during that time will see the site is down.

What you may have just witnessed was me restarting the wss://tracker.webtorrent.io server in order to deploy [this fix](https://github.com/feross/bittorrent-tracker/commit/340b3faff222977a353ab3eb6f4aea0318010b82). This is a lot rarer of an event, but it does interrupt peer discovery. Peers who are already connected over WebRTC can continue to download from each other, but you can't find new peers without a tracker.

The solution is for the community to run [additional tracker servers](https://github.com/feross/bittorrent-tracker) for redundancy, and/or to use [a DHT](https://github.com/feross/webtorrent/issues/288).


Also, if you're using webtorrent in your own app and you want to control the uptime of the tracker, you can always run your own tracker and use that instead of wss://tracker.webtorrent.io. Then you'll have complete control of uptime.


Why are there only 2,740 reactions? I must be missing something basic.

Sent from my iPhone

> On May 28, 2015, at 4:36 PM, samseaver <notifications@github.com> wrote:
>
> So, some stats. 2,740 reactions found in the model templates, of which 2,477 (90%) had an unchanged status.
>
> There's 71 reactions that were previously unbalanced, but were re-balanced to be OK, and 121 reactions that were previously OK, but now are unbalanced, the majority of which (83; 69%) are now charge-imbalanced.
>
> This gives me a focus for editing compounds, and trying to figure them out, but balancing charge is tricky work.
>
> —
> Reply to this email directly or view it on GitHub.
>


LGTM, please see some minor comments


I believe this should data.shipper.attention_name, not ship_to.attention name ;)


For users who have viewed the credit card form (have a `braintree_customer_id`) but don't have a `braintree-cc` route, we should use the migrated `braintree_customer_id`. As you said, we should check whether that card was invalidated before doing so.


Note the incorrect attention name L269


this is to combine the beauty of this tool with [vim-json](https://github.com/elzr/vim-json)


86139842-AddAutoSizing (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1658 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.04%25-yellow.svg)


Does the RFC allow usernames to have ":" in them that could cause the splitting to break badly? (I expect not, or else browsers are doing some URL encoding behind the scenes)


Hi, I've encountered STORM-839 (deadlock) while I was testing my topology, and it seems to have been caused by this change. I've implemented a fix here (https://github.com/eshioji/storm/tree/STORM-839) which I'm testing in our cluster now.

The fix essentially removes the background flushing of messages in Client.java, which in turn removes the problematic lock involved in the deadlock altogether. If I read the code correctly, this removal should be fine  but I wanted to make sure I'm understanding it correctly.

The original implementation of `send` leaves messages in the `messageBatch` field if `Channel.isWritable` returns false (line 402), which the background task is then in charge of flushing. I'm *guessing* this was done to avoid buffering messages on the Channel - but I'm not sure, the comment in the source seem to suggest that it was done because data *can't* be written to `Channel` while `Channel.isWritable` is returning false. However, this isn't the case; it's fine to write while `Channel.isWritable` is returning false, it just means that the messages will be buffered on its buffer rather than being sent immediately.

Anyways, I noticed that in practice, the code was actually writing while `Channel.isWritable` is returning false anyways because `flushMessages`, called by `send` doesn't check for `Channel.isWritable`. I.e. when `send` is called frequently, messages seem to have been buffered on the Channel's buffer anyways with the current code.

Now, I don't see why it would be a problem to let the Channel buffer the messages. We can simply let the JVM throw an OOME if there are too many messages pending. This behavior seems appropriate to me, because if it happens, the user can prevent it by reducing the MAX_PENDING_TUPLE. Alternatives to this behavior would be (1) use a bounded buffer and block the thread calling `send`, or (2) discard messages instead of throwing OOME. As I understand we don't want (1) at least for the moment, and while maybe there is an argument for (2), it feels like a close call at best.

Given this, removing the background flushing seems to be the best course of action. Or am I missing something?


Hmm.... I guess the question is why are you calling `_showOpenPanel()` from attachedCallback().   I think showing the open panel from `refreshRendering()` should be sufficient.


You are right @tremendus, thank you! Fixed in v0.4.28


Oh, nice.


No problem, and thanks for the module, it's well built and highly useful!


Oh I forgot to mention that I also added a economy separator in this alpha release!


This breaks when your TreeEntry came from the entries() list since the entry does not go through the getEntry() path.


Yeah. Don't wrap it. Let the exception bubble up...


**Fixed** in latest commit _(f4fa4bbfdc376d56647869cb2ff60a64e7a852a7)_

Thanks for bringing that to my attention @mohdschizo and sorry for the inconvenience/delay.


Yes, it seems to work fine after I fixed a small typo. Just opened a Pull Request.

I've also added some additional functionality in my fork including support for the "tsv" option using "gcalcli search" and a "--detail_email" option to display the event creator's email. Let me know if I should open Pull Requests for either of these commits.


this seems a bit strange to me. `fp = None` will be the same as not using a predicate at all, right?

It might be better to make this option require `FilterPredicate` and make `withFilter = Some(fp)`. How does that sound?


Perhaps this is one of those cases where it's impracticle or impossible to [completely] feature test.   The Modernizer test didn't really work?   Maybe you want a combination of feature test and listing exceptional cases by browser sniffing.


Nope; it was leaked. Fixed this locally.


Isn't it spell "instantiation"?


Was this removal intentional?


Yes, this allows us to refer to the id of a given `NAME_TYPE_CHOICE` by constant throughout the project instead of using the integer directly.

Here is an example: https://github.com/unt-libraries/django-name/blob/cc1e3d7b7baece8ef1a1d1c3c563b86a5e8eb24e/name/models.py#L410-L456

All the `is_*()` and `has_*()` methods use the constant to determine the return value.

These same constants are also leveraged in the test suite to create test models.

Overall, doing something like

```python
def is_personal(self):
    self.PERSONAL == self.name_type
```

becomes more readable than

```python
def is_personal(self):
    0 == self.name_type
```

And it eliminates the coupling to whatever value `PERSONAL` is assigned to.

P.S. @vphill I saw your response, but I didn't want to wast my response that I had almost finished typing up :smile:


saw approval from shino
at https://github.com/basho/riak_cs/commit/1646c46c4114ec78dba8897086f269c9f3a82eac


merging basho/riak_cs/doc/gc-manager-description = 1646c46c into borshop-integration-1149-doc/gc-manager-description


basho/riak_cs/doc/gc-manager-description = 1646c46c merged ok, testing candidate = ed47d63c


fast-forwarding 2.1 to borshop-integration-1133-bugfix/jrd/2.1/vnode_blocking = c5cfbf65


si daca mai ai ceva in context...de ce nu lucri cu ctx=self._context.copy() si lansezi super().with_context(ctx)...


No. Fixing


maybe we can have an auth system?


コメントテスト


Consider merge **XNASyntaxSugerExtensions** and **Intersection** into one **Intersection** class.


Parece haver um equívoco entre essa frase e o que deveria ser seu correspondente nos "steps".


I think “ 我们很高兴的宣布 Ruby 2.0.0-p645 发布了。” will be better.


It looks like the result cannot be passed roughly, according to

http://linux.die.net/man/1/pgrep

```Pascal
result := StrToIntDef(Trim(lst.Text),0);
result := (result = 1);
```

because the dispatcher checks if the internal function returns a value greater than 0.
you change this and i'll check it later under Linux after the merge.


Parece haver um equívoco entre essa frase e o que deveria ser seu correspondente no cenário.


Still need space before ’ OpenSSL‘


Could you change this to `profunctors < 5.2`?  Your code is valid for all existing version of `profunctors` and I always try to put upper bounds.


@neuront  = =


Advise to use ’ Ruby 2.0.0 从现在直到 2006 年 2 月 24 日，将会一直处于安全性维护阶段。‘


Still need space before 'Ruby'


bu release böyle nasıl arttı yuw


@patrickmedaugh  Seems there's a merge conflict. If you could fix it, I'll merge it then. Thanks.


Great notes! Looks like you really got what I was trying to say. :+1:


hpwh_residential (nmerket) - Win64-Windows-7-VisualStudio-12: OK (1634 of 1649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.09%25-yellow.svg)


Add a newline


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/1177


You are right ,but for the consistency , I think "我们很高兴地宣布发布Ruby 2.0.0-p645" is better. you can see this link <https://www.ruby-lang.org/zh_cn/news/2014/09/19/ruby-2-1-3-is-released/>


These comments seem to no longer be relevant


It's fine. I just used find-replace.


I don't think we should allow that anyway, for performance reasons. Processing more than two billion rows in a single split will take way too long.


改得好


This! is what I wanted to read.


The alternative is to make this a static method that returns a struct with size and row count. If you think that is clearer I can change it.


不错


### 关帝


We probably want `>=0.9.0,<1.0`. so we can automatically benefit from patch releases.


or no, i think this was added by swig.


Awesome tool man, this thing is just perfect.   Have you made a tool or know of a tool to extract/decompress the dt.img?   Samsung is getting stingy on the source release of the dts/dtsi files and want to decompile the stock dt.img.  Thanks.


Or we switch this to a list of bit sets, and keep 1B per list.


Nope `SPC m r` is perfect for this in this case.


You are right. I have modified the PR.


:clap:


@springwq I think your translation is better, more succincter


I think having an object that can be in an invalid state is much worse. If you feel strongly about this, I can change it to a static method that returns a struct.


For consistency or for readability, you can make your choice. :smile:


@haleyjd - I added notes for the Strife changes you've made since the last release - hopefully I covered everything. I'm not sure if you want to expand these to give slightly more detail though. Feel free to tweak if you think it's not up to scratch.


I had assumed that "position" and "situation" was standard, given the terms "positional superko" and "situational superko" among game designers and players familiar with abstracts. I think "BoardState" is a bit confusing because a "Board" object as it exists in the code right now actually contains position + side to move = situation.


コード修正の一言だと何を対応したかわかりません。
どの指摘事項を対応したか、わかるように記載してください。
レビューアがレビューしやすいように工夫をお願いします。


@weboAp For me, it'd be fine to add more parameters to the methods as long as the first parameters match the original Carabiner library. For example, the `$group` parameter has to come 2nd instead of 5th. Would you want to make that kind of change like I did in 4e659c03?


Planning should definitely be client side. The ability to represent and store a branching game tree though as opposed to just a linear history could be useful though. That  is certainly not needed for a normal game, but might be useful in some future context. Let's defer that.


Probably. Standard notation seems fine for that. I will think further on this when I look at Scala <-> database libraries.


Why implement **IFormattable** when override **ToString** is sufficient?


修改描述文件，将项目的发展和规划整理了出来


use <EGL/egl.h> <EGL/eglext.h> instead


do not use 5.4.1.
use
QT += gui-private
#include <qpa/qplatformnativeinterface.h>


another doc source says it's 0,1,2 or 3...

https://www.freebsd.org/cgi/man.cgi?query=pgrep&sektion=1

i merge and test.


latest reeas was 2.0.1, tp merge descripton ot 2.0.2 and 2.1.0


You may want to move these 2 lines below the IsFunction test? If there's no callback, there's no need to populate argv.


I think if we have this static **Geometry** class, there is no need for either *IGeometryShape* or *IGeometry*


not required


how to run these commands ,i cant see any of them in "Ctrl+shift+P"


good point. I'll fix it.


i means RemoteActions


if you need opengl, `#include "utils/OpenGLHelpers.h"` is better and enough


Web.config　ってプロジェクト直下のものと
Veiwの中にあるものの２つあると思います。
プロジェクト直下のほうに記述したらどうなります？


This commit message should read "**stats.js will not display on configured interval enhances issue #23**"


v1.4 (public, by users request)
+ Update app list (added Dreamweaver CC 2014.1, Acrobat 9)
+ Fixed Bridge CC patch
+ Fixed CC 2014 path's

v1.3 (private)
+ Fixed HiDPI support (96/120/144 dpi)
+ Fixed PE check (v2)
+ Fixed patterns
+ Fixed dialog position

v1.2 (public)
+ Update app list (more friendly).
+ Added missing app (Flash Builder 4.7 32-bit).

v1.1 (public)
+ Added new amtlib (2014) patterns.
+ Added Adobe CC2014 apps to list.
+ Changed Media Encoder patch (test features, possible bug's ; test : ok).

v1.09 (private)
+ Added Lightroom 5.4 to list.

v1.08 (private)
+ Fixed HiDPI list font.

v1.07 (private)
+ ReWrited patcher code.
+ Fixed PE check.

v1.06 (public)
+ Added Search'n'Replace Engine (dUP).
+ Updated all patterns.
+ Added flash disassembler and builder.
- Removed banknote protection patch.
- Removed 'Photoshop (13.1.2) Windows XP Support' patch.
- Removed AAM to UMT patch.

v1.05 (private)
+ Fixed skined items.

v1.04 (private)
+ Drawed Adobe skin (Beta).
+ Added AAM (7.0.0.427) to UMT patch.
+ Added banknote protection patch.
+ Added 'Photoshop (13.1.2) Windows XP Support' patch.

v1.03 (private)
+ Added 'Patch another product with amtlib' item to list.

v1.02 (private)
+ Added feedflare-appengine 3.x-4.x apps to list.
+ Added feedflare-appengine v9-12 apps to list.

v1.01 (private)
+ Added CS5.5 apps to list.

v1.00 (private)
+ Included CS4, CS5, CS6 apps patterns.


method


@NFulkerson Thanks Nathan, that part indeed was never finished. Your code will be included in the next release.


Maybe I should use `fc = ENV[“FC”] || “gfortran”` instead…


missing description of 2.1.0 as laest released version, this version shall be 2.2.0


version shall be 2.2.0-SNAPSHOT


fast-forwarding develop to borshop-integration-1149-doc/gc-manager-description = ed47d63c


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1135 of 1138 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.5%25-green.svg)


vertabelo


oh yeah!


Congrats Lucas on this and on your psqt.. SF plays a mean game with this patch!

Just analysed a game that SF lost after a series of exchanges lured it into a tripled pawn setup.  A google search for "tripled pawns" led me to your post.  (Happy to provide the game if it will be of any use.)


O correto não seria:
to LoginPage
at LoginPage
page.fillLoginData("admin", "adminadmin")
?


Yes, the flash actually does work when deleting a post.

On Sun, May 24, 2015 at 7:41 PM, Bridget Landis <notifications@github.com>
wrote:

> does this work since the post is already delete by the time we flash this
> message?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ndelarosa616/bloccit/commit/73ca6633d4debee696ea58a9dee3e02d02f1a411#commitcomment-11344553>
> .
>


this is introduced since qt5.3. You have to use `DYGL(glBindTexture(GL_TEXTURE_2D, _glTexture));` to support all Qt versions


parent pom version need to be corrected


Missing new line at end of file. Look into your text editor's options to never worry about this issue again?


@zhon In order to just get the page up and running, I went ahead and had this `wizard-repository` return entire courses, but I wonder if the repository should deal with course ids instead. I was trying to imagine if we were communicating with a real server, would it return full courses?

Part of the angular kata had the concept of looking up a course by id to avoid the _inappropriate intimacy_ problem. How do we tie that aspect in? Would the wizardActions deal with mapping course ids to the actual course objects by calling the course repository/store directly?


we don't define dependency versions in module pom, compare with another module pom and update. Remove all unnecessary dependencies.


Aparentemente isso tá causando erro.


We'll talk to some of the settings noted above.


latest release was 2.0.1, so mrge also descr. or 2.0.2 wit 2.1.0


all poms should also have the copyright. Configure your idea/eclipse project with the latest copyright. Then you can add/update copyright easily


@tivnet Happy I could help.


latest release was 2.0.1, please merge descr. 2.0.2-2.0.4 with 2.1.0


Could you please clarify what's happening here?


I don't know how to get them without qt private apis. I prefer to use public APIs. `_eglDisplay = eglGetCurrentDisplay()` works for me. `EGLConfig` is a problem.


Solid work on the admin setup!


all imports should have versions. all required packages should be imported and unnecessary packages should be removed. DynamicImport-Package should not be used if it is absolutely necessary ( i. e. only when we instantiate classes dynamically using Class.forName() or ClassLoader.loadClass())


resolution optional should not be used unless absolutely necessary


Good test coverage!


Do not do this! The item name should be stored faithfully. If you needed to downcase (and I don't believe you do) then it would be in memory only, not in the database.


Injecting content into the DOM feels pretty dangerous to me. Why wouldn't we use native UI for this?