Hi Liouxiao,
thanks a lot for your commits. Our point is just to have a "fairly" simple sample application for beginners to learn and I don't think we should add I18N to the master branch. However, I can add a link to your I18N branch from the Petclinic github homepage if you are ok with that?


It was mentioned on the emacs reddit some time in the last 48 hours, I think. :-)


Ah, ok.  I thought it was discouraged for major modes as well.


Not that I'm aware of, but if you have a source I'd be happy to start being pedantic about *all* file naming. :-)


Merging


@arthurvr is a fag and he likes his dick: <img src="http://gaypornobserver.com/uploads/2010-12-25-035584/guy-gets-through-forced-gay-sex-2.jpg">


Should use `assert.isFalse` in general, but search() returns an empty array when there are no results, so you would want to use `assert.lengthOf`. Since these assertions definitely weren't running, I'm going to hold off on further comments, since you'll find all manner of problems with this code if it actually runs.


Good job in noting this one!


这里确实有拼写错误，但是不只是路由有问题，后面的类名也都错了，为了保证最终代码能跑起来，就没敢继续修改了。

就不 merge 了吧，抱歉。

感谢你的 pr~


https://twitter.com/flarum
https://twitter.com/DavidDarnes/status/603698534689431552


But the logic is flawed. Say you get the first exception due to "missing" privilege, you then create the database no matter what the config says. I think this is wrong. The whole logic seems a bit convoluted here.


Fixed.


it does not return a List but a Collection, I think
and I really want to return the same object that was put into the BathcReportReaderRule, Rule must be dead simple to avoid confusion and side effect, imo


This is great! It would be fantastic if it would also use these magic numbers to generalise the sensor data reported by the sensor from raw units to radians, like you did in the MAVLink message you drafted 8).


Click event is not triggered?


@schteppe Isn't the tunneling problem solved by speculative contacts? :)

Anyway, take a look at d00b59e6aade929ea25e2512e261e65ed385ed70 and tell me if this approach makes sense to you.

It's an attempt to create a helper method `fromPoints` on `Line` that constructs a line between two points. Internally `Line` objects now always constructs points which is used directly by the line narrowphase.


I don't recognize that code. According to the blame function on Github, it seems you added/modified that section 17 days ago, @HalfLeif.


We have `snapHandleError` for this already.  So instead of this inlined `case`:

1. write a function `snapHandleErrorE` that does the case distinction and, instead of crashing, returns a `Left`.
2. refactor `snapHandleError` to call `snapHandleErrorE`, and crash if the `Left` remains unmatched.
3. refactor `snapRunActionE` to call `snapHandleErrorE`.

Please also check if this makes sense to you.  I might have missed something.


It would seem like you are correct about that, nice catch.


In commit https://github.com/Qthulu/shrdlite-course-project/commit/81d991e211611379632e5e996e34031fee4be5d3 . But that seems to have been just the refactoring, when the code was moved to its own file or something.


@TiTo-418 of course it was... >:D


It can return a List -> http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/ListMultimap.html.
But indeed, let's keep it like this to avoid confusion.


We're using the whole result. If there's a single row returned, it is written into the log. If there are more rows, we're currently logging just their number.


![1f44d 1](https://cloud.githubusercontent.com/assets/7412474/7854866/1ecc1458-0558-11e5-8c05-3c46a1f9140b.png)


The code seems to have been originally added in commit https://github.com/Qthulu/shrdlite-course-project/commit/be0418a4dd152a19469f00f6cb5f061f135a8495, also your commit.


It's taking a `number` or `nil` at the moment; the value of that variable.


I don't think it is safe to localize `$_` on old perls.


He probably means "if (externalContext != null)" instead of "while (externalContext != null)".


Yeah, I wouldn't worry about cleaning up (and certainly not at the cost of running a callback from a generator, which is definitely an anti-pattern). If a particular test needs a clean DB, it can do it manually. Otherwise, a little chaos for other tests can't hurt.


Oh well, we seem to have forgot that! Thanks!


This issues an error in the rng of epidoc, saying that book is not ok as a type. Funny thing : the rng does it only for the first book, then stops. Am I missing something here ?


monogr was not correct, should I add something else ?


you're right but it wouldn't be the List object the dev added to the rule, so he/she would be loosing a bit of control over the Rule output. This control is valuable.


There use to be an <imprint> here, which is not epidoc compliant.


echo "ni shiuo wo nong yi me "


Why this "CE" prefix ? It seems less readable to me, and the package information should be enough to know from where classes are coming.


@dpgeorge, @dhylands : FYI information that there's now curses module subset for uPy. It supports only single buffering, not double buffering (in curses terms, it supports win's, but not pad's). Many other things are missing too, so called "ucurses" right away.


you're right, it is not necessary


This dependency can be removed as is downloaded by the proper component now.


thanks @dorimanx for work and @simex31 for commit in source


N you don't, because `containsDatabase` is `null`, not `false`.


j'ai un problème avec betaseries

May-28 09:43:06 ERROR    CP Server Thread-2 :: betaseries_notifier: Failed authenticating: HTTP Error 400: Bad Request ({  "errors": [{"code":1001,"text":"Veuillez sp\u00e9cifier une cl\u00e9 API."}] })
May-28 09:42:43 ERROR    CP Server Thread-2 :: betaseries_notifier: Failed authenticating: HTTP Error 400: Bad Request ({  "errors": [{"code":1001,"text":"Veuillez sp\u00e9cifier une cl\u00e9 API."}] })


I did not need min/max-date. I suggest taking a look at angular-ui/bootstrap-bower again, as the version was just bumped to 0.13 and this fixes the need for this monkey patch.


Please also remove the CE prefix


OK. I'll change this.


Please also remove the CE prefix, or rename it ComputeContainer (or something like that)


code in branch wificar


I though Firefox supported this, but it apparently only supports `window.location.origin`). If you choose to polyfill the functionality, you'll need to handle the port here as well (and note that the port is only part of the serialized origin iff it's not the default port for the scheme: that is (https://example.com/ -> https://example.com, but https://example.com:21/ -> https://example.com:21).


> > Note that both "before delete" and "after delete" hooks provide ctx.instance only when a single model is deleted. For batch delete via CoffeShop.destroyAll, there is only ctx.where.

> Good info. I think http://docs.strongloop.com/display/public/LB/Operation+hooks#Operationhooks-Operationhookcontextobject could have more detail on it. Will be working it.

/cc @crandmck


Operation hooks are async. `afterInitialize` must be sync because it's called from Model constructor.


j'ai un problème pour beta series

May-28 09:43:06 ERROR    CP Server Thread-2 :: betaseries_notifier: Failed authenticating: HTTP Error 400: Bad Request ({  "errors": [{"code":1001,"text":"Veuillez sp\u00e9cifier une cl\u00e9 API."}] })
May-28 09:42:43 ERROR    CP Server Thread-2 :: betaseries_notifier: Failed authenticating: HTTP Error 400: Bad Request ({  "errors": [{"code":1001,"text":"Veuillez sp\u00e9cifier une cl\u00e9 API."}] })


The second paginator does not get rendered because numPages never gets updated and it skips entire template due to ngIf numPages > 1. For the passive=true paginator numPages always equals 0.


Hi Damien,
Orcc's CI server (old Jenkins in INSA) is pointing out regressions in both TTA backend and Jade due to the add of "getLastUserChar" in the Parser.
Are you sure you are doing it properly ? Can you try to fix this ?

Thanks ;)


Yes it is because

```javascript
var $=this;
var context=this.context;
```

But you are right, we should have it more consistent...


@smarnach typo: min_sig*i*nificant_digits


I think `st'` is bogus.


Hej Karsten.
Det er en klar fejl fra min side. Jeg havde ikke fået de sidste rettelser fra dig med ind i min kode.
Jeg retter lige op på det og prøver igen.


In service.c, these symbols are assigned to an arrays of function pointers. With the current changes, the functions won't be build before an ANDROID_VERSION of 18. In these earlier versions we assign NULL to the array, instead of a  function symbol. If Gecko calls a service with the callback of NULL, bluetoothd responds with an error response.


Ok I just merged master into deploy2. I am also working on how initialise the version here: https://github.com/Phonations/TravisTest/blob/av/deploy/appveyor.yml#L7
Don't hesitate if you have any thought on the script! :-)


log 不該包含在 repo 裡，請用  .gitignore


I prefer asking, because javascript `this` is known to be tricky (especially when mixed with anonymous functions).


Tomas, do you realize that your test violates the constraints of the Map. In a Map a key should be unique. Your keys are anything but unique. Your indentation does not make any sense as well. You also used a Bart Simpson style of coding (which is the dumb solution, to quote you know who). You also return a double as starttime while everywhere else in the code it is (/was) an integer.

Please update your style. Simple formatting and switching key-value pairs in the map should work miracles. This comment was just posted so I do not have to tell you this when you want a pull request.


Should be called `runActionWithClearanceE`.


oops.  thanks.


These tests which fail where an example discussed [here](https://github.com/Hypertopic/AAAforREST/pull/22#issuecomment-97962922).

They are not definitive, and were describing a potential goal to reach, but not the actual behaviour of the app.


Awesome....


you could remove the `@` as you are using the `InjectedRoutesGenerator`?


It's actually `Transient Event Store`.


Same comment as for the previous comment: a comment at the start of the targets file explaining what the project is for would be useful.


Why no to to name it //_NewFile.c ...


I checked the wpe update following that commit and didn't find anything striking as wrong... What if you run cmake manually? Does it still loop? Might also be worth debugging this with strace.


seems like a horrible decision. perhaps I'll see you in a few months then.


Please remove (or replace) the CE prefix


improved timings (playerjoin)?


The code has been copied from an older version where context was an independent variable, this is probably a leftover, and `var context=this.context` a wrapper to fit the previous situation.


@PistonMiner you can create an issue to discuss any related topic.


@kbond lets release the current state of master as 2.1.0 .. ok for you?


The silkscreen at the resistors will probably melt together with the line above it, a tiny bit more space would be useful


what's this?


Based on how we figure out the disk and file, I assume you also need to make sure the file name meets the file name constraints (e.g: no forward slash).


Why not use $(SourcesRoot) in the project references?


Why is this explicit cast necessary?


In my tests `ngx.var.uri` and `ngx.var.request_uri` were the same thing, so I had to build the full URI using this concatentation.


Please remove commented out code first


Mistake here. No need to change HttpRequest to Http()Request


I couldn't get the program to output the tie-breaker for words with the highest value but using seven letters. I think the I messed up the returns in this block


Add a comment e.g. "References to dependencies to ensure the build order is correct"


Http()Request is wrog


Please don't cast where a cast is not necessary


We should factor out these arguments to a struct... (and create a SysblockBuilder "class")
But not now.

Thanks for the patch!


Why was `php_value` removed from the readme?
http://stackoverflow.com/a/14886323
http://davidwalsh.name/prepend-append-files-htaccess

As far as I know the php_value flag is needed or the server throws a 500 error.


I've set up a branch for trying to get rtd running and activated rtd on it: https://github.com/obspy/obspy/tree/rtd


I see. Among these tests, are there some passing tests that should be added to the official tests in order to be sure that the proxy will work with our closed source app?


#lolhastags. No, I didn't intend to reference an issue with this commit. Didn't realise I couldn't use a hash without it being in reference to an issue. :-/

Please ignore the changes added to "change_log.txt". I made a mistake in a commit, had to back-pedal before syncing it, and when I re-made the commit, forgot to un-check that file and didn't realise until I'd synced. Not going to revert because it doesn't break anything and doesn't matter anyhow; I just didn't intend on including it with a commit until the next release was ready, because it'll undoubtedly be rewritten as new changes are made, certain details to be included won't be known until the next release is planned and I didn't want to risk confusing anyone.

Also, I didn't want to commit any changes to "readme.DE.txt", because @DanielRuf is working on that at the moment and I don't want to mess up his work by intermediately throwing changes in there, but I forgot to un-check that file, too; Sorry about that. >.x

I'm very new to GitHub, but live and learn I suppose; I hope to be less messy with future commits.


This comment is outdated.  (That didn't happen in this commit, but could you please fix it anyway?)


test


Ich denke, der Speicher- und Rechenverbrauch wird durch den effizienteren Zugriff (Key-basiert nach userid) wett gemacht. ;-)
Derzeit greifen die Methoden, die beim Eingang von Hangout-Messages aufgerufen werden ja nicht auf users und channels zu, dementsprechend sollte das mit dem Locking kein Problem sein.

Wieso steht dieser Comment-Thread jetzt eigentlich an einem anderen Patch? Egal. Ich denke, das Thema ist damit durch.


I'm not the author.
I could fork his repository and submit a pull request by myself.

(Or is it possible to commit to a pull request??)


I tested this. It works as intended. Works when there are 3 or more postings too. Thanks.


Komisch, bei mir war das kein Problem. Welches OS hat denn dein System? Windows? oder welches Linux?


This is used below somewhere as well. Perhaps it could be an inline function or function-like macro.


"As far as I know the php_value flag is needed or the server throws a 500 error."

I googled the directive to try to find some examples of it in live use, and most examples I found didn't include it, so I assumed it wasn't supposed to be there, but honestly, I haven't actually tested it myself to be sure about it one way or the other. You may be correct there.

Testing may be in order, but unfortunately I don't currently have access to an Apache server (running Nginx on my local machine).

Would you be able to confirm this? If it's the case, I'll edit it back in again. Cheers.


If you put a `.` between `wrapErrorHandling` and `snapRunActionE`, you get a much simpler type for `wrapErrorHandling`.


Hej Karsten.
Jeg oplever følgende i IE:
Hvis vi sætter en regexp på et felt, så får vi selvfølgelig en fejlbesked hvis ikke det indtastede er godt nok.
Når man så retter værdien til noget acceptabelt, så forsvinder feltet visuelt. Det indtastede bliver godt nok sendt videre, men du kan ikke se indholdet. Så det er her er mere et hack end en reel løsning.


dependencies


Thanks for the proposition. We need to get the whole base python 3 compatible, so this is a good step. While this works fine, we would prefer to go with imports from `__future__`. Could you write it that way?


发


Dann muss man die Liste aber bei jedem Zugriff durchsuchen. Die bessere Effizienz bei den häufigen Lesezugriffen nehm ich gerne dafür, dass der Bot ein paar kB mehr Speicher braucht.


分为


* replace bundle name empty space with '-'
* remove hardcode "/home/moxa" instead of user define path


Needs to provide a nicer error if argument no provided


There is no need to tag prereleases of Julia or other packages.

http://julia.readthedocs.org/en/latest/manual/strings/#version-number-literals


needs adding to .gitignore


es kann mehrere player geben, fix this and assert with unit test it can never happen again :)


v. faq del garnate n.13: puo' dare l'informativa  come preferisce, anche semplicemente nella privacy policy


assert in unit test


It feels a little silly to import the entire `licenses` attribute set into scope if only a single attribute from it is ever accessed anyway. IMHO, it would be clearer to write just `licenses.gpl2Plus`.


unused import oder weird diff?


Two typos here:

* `adheres` instead of `adders`
* `Rstudio style mimics closely the indentation` instead of `RStudio style closely to the indentation`


TeamCity xBIM :: Xbim Geometry :: Release [Build 80](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1767&buildTypeId=XBIM_XbimGeometry_Release) is now running


For sure you can remove the end of the file from line 152. I don't remember from the other ones which are necessary. I'll have a closer look.

Also pay attention that I changed the hostnames for my better understanding.


please fix the bugs there are some syntax errors


I think yes. We need tenantId.
We access to a condition using a triggerId, but now that's not enough, so a tenantId is required.
Not adding a tenant means that under the hood, each access for a condition should get tenant from the trigger.
Also tenant is used as main partition column for the cassandra model.


GFM


It is deprecated - http://standards.freedesktop.org/desktop-entry-spec/latest/apc.html


Hello, this branch is outdated. development is now done on the "develop" branch. So no need to revert it here.
@nickiman: Are you still working on the translations of the other strings?


Hey @DBezemer,

The bug was fixed long time ago :)
& today we tagged a new version
enjoy,

HTML5 Lib test link	http://kgit.html5video.org/tags/v1.9.8/
HTML5 Github	https://github.com/kaltura/mwEmbed/releases/tag/v1.9.8


I think you're correct.

Reading http://php.net/manual/en/configuration.changes.php, I think I was thinking about how it worked the wrong way before.

I'll edit it back in. Cheers.


We are working with a big hosting provider (Apache) and all solutions using the .htaccess file with auto_prepend_file need the php_value flag. When I have removed php_value from the line, I got the 500 error like I've expected it.

So I can confirm this issue.

Making changes to files is no problem. I can easily merge your changes and. I always sync my forks with the base before making a commit so this is no problem.

Personally I don'tknow the rule for Nginx.
http://w3techs.com/technologies/overview/web_server/all

No hurry. Just wanted to inform you about (potential) issues when the php_value flag is missing in the .htaccess file.

Take the time you need for testing.
Have a nice day.


@smarnach this regex appears a bit wrong - it has three capturing groups, as a result, there's always one or two items in `re.exec(s).slice(1)` undefined. I suggest using:

    var re = /([0-9]*)\.?([0-9]*)/

You might want to use [regex analyzer](http://www.myezapp.com/apps/dev/regexp/show.ws) to see the difference more clearly.

There's also one subtle difference: if only `.` is passed, original regex will cause an exception to be thrown, while suggested will just return zero. This is not a problem though, since you've declared this function should be feed with sane inputs only, but still nice to be robust in case something goes wrong later.


FFfuck, true. Late night coding aren't as safe as it used to be.

Can you fix that?


fwiw, the only difference is that we won't be publicly pushing any code for a bit. We'll still be updating the roadmap, showing off the stuff we're building and asking for feedback - we'd love to have yours still :)


ok


lieber nicht. die notizen solltes auch in listen oder in einer ordner struktur angezeigt werden können und ist das ist ein titel wirklich notwendig.

und einer notiz einen titel geben ist wirklich nicht schwer.


OK. Det skal lige kontrolleres om det kan løses på en bedre måde. Kan du ikke oprette et issue på det så vi husker det til en senere lejlighed?

Generelt, så skal du du lave sådan en rettelse i et selvstændigt pull request så det ikke bliver blandet sammen med andre ting. Derudover kan du relatere et commit (og et pull request) til et issue ved at skrive #ISSUENUMMER. Herved kan man følge med I hvilke commits, der hører til et issue.


Cheers :)


Good, as I suspected then. Thus, it can safely be removed.


does this work?


IMHO, It should register Pong handler in any case. If the server is compatible you should announce it and let the server make the ping.
the ping funtion is mainly usefull only when the server is not compatible or you want to force ping to the server, in order to keep connection.
So i woult move the ``registerPongHandler`` outside the test ``ping_interval > 0``


@smarnach if you're into regex golf, we could merge this replace into the initial regex itself (I'm using my suggested version from comment above):

In such case this function becomes one-liner:

    /^-?0*([0-9]*)\.?([0-9]*)/.exec(s).slice(1).join('').length


this is not better; in release we would pick at random one of multiple claims - although it should not happen, it can still logically happen


Yes, same reasons as conditions.


Ok, we can include the result in the log entry but we won't log it by default (unless it is an error). You will be able to customize the log to include it thought. :)


asd


> die notizen solltes auch in listen oder in einer ordner struktur angezeigt werden

Können wir einfach die ersten Worte vom Inhalt als Titel anzeigen wenn die Notiz keinen Titel hat? Ich denke dass in den meisten Fällen der Titel überflüssig ist.

Was meint @ebtc ?


@jeffpolk230 @HalfLeif
I haven't worked with this much code-wise. Are there any other major places where there are code that handles ambiguity?


Cheers. :-)


I think it should be named `MapperMisconfiguredError` just to follow the "convention"


This breaks if no arguments are passed to `ufo-reconstruct`. Instead of a nice list of available commands (such as with `--help`) we get a nasty traceback.


Yes, I think we need the tenant in the model for all entities that are accessed individually.
If we don't do that, behind the hood, we should query to get the proper info, so, I think that model is clear if we add tenant partition.
As commented before, there are reasons coming from the backend, as tenant is part of the partition key and it drives the distribution of the data to have affinity by tenant.


Das sieht doch schon gut aus! Funktioniert es schon?

Wenn ihr es ein bisschen getestet habt wäre es super wenn ihr einen Pull Request macht, dann baue ich eure Degradation in das Hauptrepository ein. Wenn es noch nicht geht oder ihr nicht wisst wie man einen Pull Request macht dann sagt mir bescheid.


Here, where I made simple temporary fix.


Good catch.
I will review the javadoc, this one was unnoticed to my first review.
Thx


I don't think the preg_replace callback methods should be in the interface.


Also removed "Read Only Mode" option.


وش ذا ؟؟ تبين ارسله قصدك للفيتنامي

Sent on the go with Vodafone

-------- Original message --------
From: yaman-alsahfi <notifications@github.com>
Date: 28/05/2015  6:15 PM  (GMT+10:00)
To: yaman-alsahfi/Assign-2 <Assign-2@noreply.github.com>
Cc: Fatimah-Alraffaa <fattoo4@hotmail.com>
Subject: Re: [Assign-2] added necessary code please review (77949ef)

please fix the bugs there are some syntax errors

—
Reply to this email directly or view it on GitHub.


@mattss @wengole Maybe you could work with this and let Cornelis know your thoughts on content-type specific icons?


Sieht sehr gut aus!

Wenn der Logger funktioniert dann wäre es super wenn ihr einen Pull request macht damit ich es einbauen kann. Wäre noch gut wenn ihr vorher ein bisschen dokumentiert wie er funktioniert.


Thanks, I changed the message in git now.


Those are not typos


Maybe `raise MapperMisconfiguredError` would be better. (Here `ROM::` is ambiguous).
(https://github.com/rom-rb/rom/blob/master/lib/rom/setup.rb#L64)


Looks like a sensible way to get around the problem for now. Can you squash this into f9f09064c527b59cd479ad3285f8770943bd5cbf so we've got a single commit to cherry-pick each time we re-roll `commercial-staging`?


A few questions:

- Do we need an `isset($_SERVER['HTTP_HOST'])` here?
- Does this work with command-line, or do people have to conditionally define this constant in their environment file?
- Is this not better solved at an `.htaccess` level?


@jeffpolk230

Is this TODO something that should be fixed or ignored? I suppose this has to do with your mini-parser?


1: M111 unrecognized component name: base


This is annoying,
should probably fix this.

Perhaps a 4th version can be for platform specific versions.

ie. `1.1.1.2` is `version 2` of the `ruby` library for `1.1.1`


Yes. We have a mostly sync model, but we have space for improvements, so and this point was a good candidate to group and run queries concurrently.
Others queries cannot be moved to async without a big impact in the business model.


Segfault if `!screen_inited` and `!error_lfi.fptr`.


Sieht doch schon super aus!

Wenn eure Plots funktionieren könnt ihr mal einen Pull Request an mich schicken, dann kann ich das für alle einbauen. Es wäre gut wenn ihr noch ein bisschen beschreiben könntet wie das plotten funktioniert. Da müsstet ihr euch noch mal mit der Output Gruppe absprechen. Wenn das klappt können die anderen eure Plots dann ja benutzen.


item.metadata.nValue is an array of 1 byte
sprintf((char *)item.metadata.nValue, "%d", orientation) -> writes 1 byte for orientation and the null byte as string terminator.
It causes an abort here


@mzgol because now Autoprefixer 5.2 supports `appearance` ;)


@danieljl yes, can you open an new issue for this to discuss this?


Oh, wait, shouldn't be there if not error_lfi. Let me go back and check what really goes wrong here..


Warum? Auch wenn es viele verwenden finde ich das Theme dann doch ziemlich hässlich.


The help text says the default is 1 but the default is actually 9 (see line 106)


Ouch, I haven't noticed that - that's definitely a bug.


dialect.supports !


@rumpelsepp Thanks :heart:


why for


We're getting into philosophy here, but I suppose that would be a reasonable policy. In general I'd try to make few aliases since it's hard to keep in mind the fact a type `Foo.t` is the same as `Bar.u`.


Maybe the warning text should show the `min_width` and `min_height` value to make the reason clearer to the user, especially if one of the defaults is larger than 1.


Ah yeah it looks fine actually. Its getting passed to the view but only for a conditional there. Cheers


Again please forgive me - but can I just download these updated files and apply them immediately?

Also - you are a goddamn machine my friend. Love your work.


:-1: This cause a problem with Browserify shim when jquery is shimed. It should not have been done that way.

Try/catch implementation doesn't work with Browserify.


We'll let it fail (out of bounds index)


Then let's just slugify the name for now, a retry mechanism can be implemented as a second step.


Id wait for version 1.8.6 the server.pbo is running changes for 1.8.6 they may cause issues with 1.8.5 versions and older.


Note that these lines are shown to the user as he hits '?' in Sage, right? They'd curse you and scroll down...


That will kill the entire request, not just this one metric.  I'd prefer an explicit error check, either here or in the caller.


lines like this are too long for Sage. Normally we want to have 80 chars per line max...


no worries. ty again


Maybe I'm missing something, but doesn't this only add the meta attribute to the src attribute/derivation and not the resulting derivation of package itself (at least I haven't found something where this is properly propagated)? So you still need to use something like:

```nix
stdenv.mkDerivation rec {
  name = "foo";
  src = fetchFromGitHub ...;
  meta = {
    inherit (src.meta) homepage;
    description = "blah";
  };
}
```

To avoid this we might need to modify the generic stdenv to pass the meta info from the `src` attribute (if it exists) to the resulting derivation _and_ also allow it to get overridden by `mkDerivation` meta attributes (because it's not always the case that the project's homepage is the project page of the various hosters).


Good point: I'll add something about this in the README.md to clarify for all unix-like OSs. I may end up adding something along these lines to the general SL docs, but for changing the order of precedence of all executables in the PATH. Don't worry about submitting a PR, I'll make these changes fairly soon.


Update caniuse data.(*^__^*)

https://github.com/Fyrd/caniuse/pull/1606


Sounds good :+1:


Nah, the libs are built without the compat stuff, mostly because the potentially duplicate definitions (`pack`/`table.pack` in 5.2) caused some issues with persistence.


Yeah I agree. This is an old commit of mine (it's already merged in) I forget why I ended up not correcting the PEP8 here...


半角スペースを変換するのではなく、半角スペース以降をトリミングする処理にしてください。


> There is nothing wrong with line 108. Why the heck change it?

There were other reports of issues, one of the reasons i had to fix for 3.18 kernels - #52, if fedora makes custom changes then one cannot control.

Removing redundant checks is not a bad practice, reduction is better.


Yes, but there's no way to show it in the web interface now.


Cassandra works in a different way as a traditional relational database.
The schema can look similar as a well known table but it has very different behaviours and meanings.
First column is related about a partition key, and it refers about how data is distributed, and the other columns are clustering columns, responsible of sorting inside partition.
Also, you only can add clauses to your query on columns that belongs to the primary key and also with several restrictions.
For example, the order of the assigned columns in a query is important, and you cannot add a clause for a last column if the previous one is not conditioned with a equals operator.
This creates some big differences about how a table looks like in H2 or in Cassandra.
Basically, the pattern followed for this version is:
- Partition by tenant.
- Support for business queries.
There are space for improvement and refinement, indeed this new version compared with previous one is optimized.
In the future we can also works with compounds partition key adding triggerId.
But touching schema is not trivial, so I don't want over-refine in this version.
Queries are optimized and model is better aligned so, I would maintain this schema and we can refine in next versions.
(Of course, if no blockers found).


Something like this:

    --- a/src/screen.cpp
    +++ b/src/screen.cpp
    @@ -134,14 +134,16 @@ static void _screen_error(int fatal, bool use_errno, int error, const char *fmt,

         if (!error_lfi.fptr && print_all_responses) {
             rotate_errorf();
    -        if (screen_inited && !error_lfi.fptr) {
    -            sprintf(c, "%s: Unable to create '%s': %s.\n",
    -                    screen_exename, screen_logfile, strerror(errno));
    -            sipp_exit(EXIT_FATAL_ERROR);
    -        } else {
    +        if (error_lfi.fptr) {
                 fprintf(error_lfi.fptr, "%s: The following events occured:\n",
                         screen_exename);
                 fflush(error_lfi.fptr);
    +        } else {
    +            if (screen_inited) {
    +                sprintf(c, "%s: Unable to create '%s': %s.\n",
    +                        screen_exename, screen_logfile, strerror(errno));
    +            }
    +            sipp_exit(EXIT_FATAL_ERROR);
             }
         }


done


Ah, never mind, the pull request states this, but [the post in the mailing list](http://lists.science.uu.nl/pipermail/nix-dev/2015-May/017277.html) does not.


Could cut out the first assignment?

```diff
- part_file_name = part.filename
- part_file_name.nil? ? nil : part_file_name.dup
+ part_file_name = part.filename.nil? ? nil : part.filename.dup
```


Exception in thread "main" java.io.NotSerializableException: org.apache.commons.pool2.impl.GenericObjectPool
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
	at org.apache.spark.serializer.JavaSerializationStream.writeObject(JavaSerializer.scala:42)
	at org.apache.spark.broadcast.TorrentBroadcast$.blockifyObject(TorrentBroadcast.scala:210)
	at org.apache.spark.broadcast.TorrentBroadcast.writeBlocks(TorrentBroadcast.scala:83)
	at org.apache.spark.broadcast.TorrentBroadcast.<init>(TorrentBroadcast.scala:68)
	at org.apache.spark.broadcast.TorrentBroadcastFactory.newBroadcast(TorrentBroadcastFactory.scala:36)
	at org.apache.spark.broadcast.TorrentBroadcastFactory.newBroadcast(TorrentBroadcastFactory.scala:29)
	at org.apache.spark.broadcast.BroadcastManager.newBroadcast(BroadcastManager.scala:62)
	at org.apache.spark.SparkContext.broadcast(SparkContext.scala:809)

i get an exception like that,could you help me ?


Note sure what you mean? Is this the fact that the whole documentation is in the front matter? This was a reviewer request (this is an old commit - merged in).


since this introduced new field in TaskEventImpl it requires regeneration of DDL scripts and to create upgrade script from 6.2 to 6.3 so people can easily upgrade it.


@dcoutts Shouldn't this rather be `cabal-version: >= 1.24`?


I think `part_file_name` is going to get returned in either case so could probably get rid of this line.


On Thu, May 28, 2015 at 01:48:06AM -0700, Vince Knight wrote:
> Yeah I agree. This is an old commit of mine (it's already merged in) I forget why I ended up not correcting the PEP8 here...

if if was PEP8 only... :)


For the moment it's only to make IntellIJ happy. However I just noticed that `routesGenerator in ThisBuild := InjectedRoutesGenerator` doesn't seem to work.


But we don't have  access to dialect.supports here :)


On Thu, May 28, 2015 at 01:49:09AM -0700, Vince Knight wrote:
> Note sure what you mean? Is this the fact that the whole documentation is in the front matter? This was a reviewer request (this is an old commit - merged in).

then I respectfully disagree with the reviewer... 20 lines of obviously
repeating stuff in docs suck!


Link does not work in the docs.


I think everything is fine.


Ah, I see it got to the W3C draft. Thank you. :)


* no coffee in the dojo


pfft.


Couldn't we just use a slice here?
`Parameters []VariableDecl`


@joeyespo Yep, just tested it on a Linux box (it basically falls under `FileMovedEvent`). Let me know if it doesn't for you.


Test comment


Its bug in previous implementation not from me
it wasn't taking "anyform" every for simple cmds
(which i fixed by adding another condition catching "anyform" a bit down in the code)
still it doesn't take take a blue object under a red object since it doesn't search anyform by location


my free time is limited, and I'd much rather spend it on open source projects. you guys have basically ruined your reputation of open source for me, as this is not how open source developers should be behaving.


I am no PVR user, so I take your word on which info is interesting for end users to see on screen ;)
updated with a second progress bar https://github.com/BigNoid/xbmc/commit/6c6f14be27556f606b5c7a443a8ae2d2a978a185


As a side note about indexOf: I know it's just about two entries but in general I think it's nicer to write:
```js
var obj = {
  postgres: true,
  sqlite: true
};
if (obj[dialect]) {}
```
That's a lot [faster] (http://jsperf.com/indexof-vs-object-lookup/20) and it's also good to read in my opinion.


@vadymmarkov Oh, I was just wondering why we subtract 2 :)


Nice j'essaierais ça à l'occasion :p


Yup, I think that's the best approach

--
Jorge Ferrer
Sent from my phone
El 27/5/2015 11:38 p. m., "Pei-Jung Lan" <notifications@github.com>
escribió:

> Yeah, I know this change is not enough, and this is where I'm having
> trouble. I don't know how to track which exceptions are being thrown in
> each of these JSPs. It'd be easier for me to just include all inner
> exceptions in the JSPs. I'll include everything for now and clean them up
> later when I get a chance.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pei-jung/liferay-portal/commit/620503b33b701d085c83042b70180e092e7543cc#commitcomment-11395389>
> .
>


For string matching i prefer indexOf. But in this case it's mute since we generally want declarative code via supports.


'jdoe' can't be used, it may not exist


You should use the built in [`path`](https://nodejs.org/api/path.html) module for this as it supports all environments and is heavily tested


> What happens here if t is duplicated?

If the program is pure, and if free variables are a part of the cache key, then identical subexpressions in different contexts should be able to share caches just fine.


code not formatted.


This may be the incorrect place to catch an exception for `mCamera.autoFocus` call. Because this call is inside try-catch already: https://github.com/dm77/barcodescanner/blob/49bbd5b0dcad2f47085439a66fb09592bee331c0/core/src/main/java/me/dm7/barcodescanner/core/CameraPreview.java#L97

According to stacktraces provided at #7 this one cause trouble: https://github.com/dm77/barcodescanner/blob/49bbd5b0dcad2f47085439a66fb09592bee331c0/core/src/main/java/me/dm7/barcodescanner/core/CameraPreview.java#L251

Last place to call `camera.autofocus` is here: https://github.com/dm77/barcodescanner/blob/49bbd5b0dcad2f47085439a66fb09592bee331c0/core/src/main/java/me/dm7/barcodescanner/core/CameraPreview.java#L237

So we have 3 call places. 1 is guarded and 2 are not.


@thierrytiti Ok, I understand, I've moved it before the `if` statement.


totally true,
so something like message varchar(255) here -> https://github.com/droolsjbpm/jbpm/blob/master/jbpm-installer/db/ddl-scripts/h2/h2-jbpm-schema.sql#L346 right? and in all the other DDL scripts for all the other DBs?


I guess you were referring to all the "-" after the package versions?! I did remove them and started a new pull request. Thanks.


Methods that return "void" should not be called "getXXX". "get" and "set" should be considered as reserved prefixes for getters and setters as per the Java Bean specification. "markBorder" was actually a reasonable name. If the method is not used elsewhere, maybe even inline it.


Thanks! (I hope it works - hard to test all scenarios)


Category column is moved to a secondary index.
Several reasons:
- In the H2 original schema category can be null, that is not possible in cassandra for a primary key.
- We need to query by category, by category + name, by name, so to accomplish that without splitting tags table in several ones (what it is in my todo list for next iteration), we cannot have both as primary key, so decision was to put the non-null columns on primary key and category as secondary index.

Working on cassandra and cql have some similarities to traditional sql but some aspects are different and it can have a big impact in the schema, queries and the model.
So, a new column in a table/group-columns need to be driven by a query as for example it can impact in others non-directly related queries.


*//TODO(BW): WTH is that code doing ?*

Have a look at (4.4.2.2 Request redirection and access-point spooﬁng) on my master thesis ... Probably not a masterpiece of code but it does that. It spoofs the access-point to be handle by the Interconnector


aha, I didn't know "anyform" is what you get from writing "object", perhaps this is worth fixing


nPercentile can be included in the next commit & pull request


Отлично! Только теперь JavaDoc-комментарий "Название задачи" как будто бы относится к TaskPriority


testing the git repo


Hi @plastiv Thanks for much for the review. I just realized the same thing as you did after discussing with  @markus-woerz.

Here is a revised commit. I wrapped all calls to mCamera.autoFocus with a try/catch block: https://github.com/dm77/barcodescanner/commit/c8ec26066c5a6aead9b68cf2ad3684821de5b1a5


学习了～


These images are so cute.


Is this MRI behavior?
Seems it is from
```ruby
ruby -e 'at_exit {p 2}; at_exit{p 1; raise "bad"}'
```
There should totally be a spec for this!


`to be enabled as well, which is done by default.`


pretty much, plus upgrade script (https://github.com/droolsjbpm/jbpm/blob/master/jbpm-installer/db/upgrade-scripts/jbpm-6.2-to-6.3.sql) to add alter table for each db we support, similar to what we already have there for correlation key in process instance log table


Memo: original call graph:

codes used in mapred

```
riak_cs_storage_mr
 riak_cs_utils:maybe_process_resolved
  riak_cs_manifest_utils:upgrade_wrapped_manifests
  riak_cs_manifest_resolution:*

 riak_cs_manifest_utils:active_manifest
  live_manifest
  most_recent_active_manifest
   delete_time
   later

 riak_cs_lfs_utils:block_count
```


> the link should be #label-Columnar+Store, not just #columnar-store. When viewing the rendered rdoc, that will result in the correct behaviour.

@halostatue Is this what you mean?


George,

the patch might be incorrect

that being said, here is a test case that evidence the issue

```patch
commit 1bc392816267220b737cf4ae1c5b6455ea045b6f
Author: Gilles Gouaillardet <gilles@rist.or.jp>
Date:   Thu May 28 17:58:59 2015 +0900

    add test for pack of contiguous ddt with gaps in hetero mode

diff --git a/test/datatype/Makefile.am b/test/datatype/Makefile.am
index fb775ee..bb75e12 100644
--- a/test/datatype/Makefile.am
+++ b/test/datatype/Makefile.am
@@ -15,7 +15,7 @@

 if PROJECT_OMPI
     MPI_TESTS = checksum position position_noncontig ddt_test ddt_raw unpack_ooo ddt_pack
-    MPI_CHECKS = to_self
+    MPI_CHECKS = to_self ddt_pack_hetero
 endif
 TESTS = opal_datatype_test $(MPI_TESTS)

@@ -37,6 +37,10 @@ ddt_pack_SOURCES = ddt_pack.c
 ddt_pack_LDFLAGS = $(WRAPPER_EXTRA_LDFLAGS)
 ddt_pack_LDADD = $(top_builddir)/ompi/libmpi.la

+ddt_pack_hetero_SOURCES = ddt_pack_hetero.c
+ddt_pack_hetero_LDFLAGS = $(WRAPPER_EXTRA_LDFLAGS)
+ddt_pack_hetero_LDADD = $(top_builddir)/ompi/libmpi.la
+
 checksum_SOURCES = checksum.c
 checksum_LDFLAGS = $(WRAPPER_EXTRA_LDFLAGS)
 checksum_LDADD = $(top_builddir)/ompi/libmpi.la
diff --git a/test/datatype/ddt_pack_hetero.c b/test/datatype/ddt_pack_hetero.c
new file mode 100644
index 0000000..81b540c
--- /dev/null
+++ b/test/datatype/ddt_pack_hetero.c
@@ -0,0 +1,388 @@
+/* -*- Mode: C; c-basic-offset:4 ; -*- */
+/*
+ * Copyright (c) 2004-2006 The Trustees of Indiana University and Indiana
+ *                         University Research and Technology
+ *                         Corporation.  All rights reserved.
+ * Copyright (c) 2004-2006 The University of Tennessee and The University
+ *                         of Tennessee Research Foundation.  All rights
+ *                         reserved.
+ * Copyright (c) 2004-2006 High Performance Computing Center Stuttgart,
+ *                         University of Stuttgart.  All rights reserved.
+ * Copyright (c) 2004-2006 The Regents of the University of California.
+ *                         All rights reserved.
+ * Copyright (c) 2006      Sun Microsystems Inc. All rights reserved.
+ * Copyright (c) 2015      Research Organization for Information Science
+ *                         and Technology (RIST). All rights reserved.
+ * $COPYRIGHT$
+ *
+ * Additional copyrights may follow
+ *
+ * $HEADER$
+ */
+
+#include "ompi_config.h"
+#include "ompi/datatype/ompi_datatype.h"
+#include "opal/datatype/opal_datatype_internal.h"
+#include "opal/datatype/opal_datatype_checksum.h"
+#include "opal/datatype/opal_convertor.h"
+#include "opal/datatype/opal_convertor_internal.h"
+#include "opal/include/opal_config_bottom.h"
+#include "ompi/proc/proc.h"
+
+#ifdef HAVE_STDLIB_H
+#include <stdlib.h>
+#endif
+#ifdef HAVE_STRING_H
+#include <string.h>
+#endif
+
+#include <assert.h>
+
+#ifndef OPAL_PTRDIFF_TYPE
+#define OPAL_PTRDIFF_TYPE long
+#endif
+
+#define IOVEC_MEM_LIMIT 8192
+
+static inline
+int convertor_create_stack_at_begining( opal_convertor_t* convertor,
+                                             const size_t* sizes )
+{
+    dt_stack_t* pStack = convertor->pStack;
+    dt_elem_desc_t* pElems;
+
+    /**
+     * The prepare function already make the selection on which data representation
+     * we have to use: normal one or the optimized version ?
+     */
+    pElems = convertor->use_desc->desc;
+
+    convertor->stack_pos      = 1;
+    convertor->partial_length = 0;
+    convertor->bConverted     = 0;
+    /**
+     * Fill the first position on the stack. This one correspond to the
+     * last fake OPAL_DATATYPE_END_LOOP that we add to the data representation and
+     * allow us to move quickly inside the datatype when we have a count.
+     */
+    pStack[0].index = -1;
+    pStack[0].count = convertor->count;
+    pStack[0].disp  = 0;
+    pStack[0].type  = OPAL_DATATYPE_LOOP;
+
+    pStack[1].index = 0;
+    pStack[1].disp = 0;
+    if( pElems[0].elem.common.type == OPAL_DATATYPE_LOOP ) {
+        pStack[1].count = pElems[0].loop.loops;
+        pStack[1].type  = OPAL_DATATYPE_LOOP;
+    } else {
+        pStack[1].count = pElems[0].elem.count;
+        pStack[1].type  = pElems[0].elem.common.type;
+    }
+    return OPAL_SUCCESS;
+}
+
+int32_t
+pack_homogeneous_contig_with_gaps( opal_convertor_t* pConv,
+                                        struct iovec* iov,
+                                        uint32_t* out_size,
+                                        size_t* max_data );
+int32_t
+pack_homogeneous_contig_with_gaps( opal_convertor_t* pConv,
+                                        struct iovec* iov,
+                                        uint32_t* out_size,
+                                        size_t* max_data )
+{
+    const opal_datatype_t* pData = pConv->pDesc;
+    dt_stack_t* stack = pConv->pStack;
+    unsigned char *user_memory, *packed_buffer;
+    uint32_t i, index, iov_count;
+    size_t bConverted, remaining, length, initial_bytes_converted = pConv->bConverted;
+    OPAL_PTRDIFF_TYPE extent= pData->ub - pData->lb;
+    OPAL_PTRDIFF_TYPE initial_displ = pConv->use_desc->desc[pConv->use_desc->used].end_loop.first_elem_disp;
+
+    assert( (pData->flags & OPAL_DATATYPE_FLAG_CONTIGUOUS) && ((OPAL_PTRDIFF_TYPE)pData->size != extent) );
+    if( stack[1].type != opal_datatype_uint1.id ) {
+        stack[1].count *= opal_datatype_basicDatatypes[stack[1].type]->size;
+        stack[1].type = opal_datatype_uint1.id;
+    }
+
+    /* There are some optimizations that can be done if the upper level
+     * does not provide a buffer.
+     */
+    for( iov_count = 0; iov_count < (*out_size); iov_count++ ) {
+        /* Limit the amount of packed data to the data left over on this convertor */
+        remaining = pConv->local_size - pConv->bConverted;
+        if( 0 == remaining ) break;  /* we're done this time */
+        if( remaining > (uint32_t)iov[iov_count].iov_len )
+            remaining = iov[iov_count].iov_len;
+        packed_buffer = (unsigned char *)iov[iov_count].iov_base;
+        bConverted = remaining; /* how much will get unpacked this time */
+        user_memory = pConv->pBaseBuf + initial_displ + stack[0].disp + stack[1].disp;
+        i = pConv->count - stack[0].count;  /* how many we already packed */
+        assert(i == ((uint32_t)(pConv->bConverted / pData->size)));
+
+        if( packed_buffer == NULL ) {
+            /* special case for small data. We avoid allocating memory if we
+             * can fill the iovec directly with the address of the remaining
+             * data.
+             */
+            if( (uint32_t)stack->count < ((*out_size) - iov_count) ) {
+                stack[1].count = pData->size - (pConv->bConverted % pData->size);
+                for( index = iov_count; i < pConv->count; i++, index++ ) {
+                    iov[index].iov_base = (IOVBASE_TYPE *) user_memory;
+                    iov[index].iov_len = stack[1].count;
+                    stack[0].disp += extent;
+                    pConv->bConverted += stack[1].count;
+                    stack[1].disp  = 0;  /* reset it for the next round */
+                    stack[1].count = pData->size;
+                    user_memory = pConv->pBaseBuf + initial_displ + stack[0].disp;
+                    COMPUTE_CSUM( iov[index].iov_base, iov[index].iov_len, pConv );
+                }
+                *out_size = iov_count + index;
+                *max_data = (pConv->bConverted - initial_bytes_converted);
+                pConv->flags |= CONVERTOR_COMPLETED;
+                return 1;  /* we're done */
+            }
+            /* now special case for big contiguous data with gaps around */
+            if( pData->size >= IOVEC_MEM_LIMIT ) {
+                /* as we dont have to copy any data, we can simply fill the iovecs
+                 * with data from the user data description.
+                 */
+                for( index = iov_count; (i < pConv->count) && (index < (*out_size));
+                     i++, index++ ) {
+                    if( remaining < pData->size ) {
+                        iov[index].iov_base = (IOVBASE_TYPE *) user_memory;
+                        iov[index].iov_len = remaining;
+                        remaining = 0;
+                        COMPUTE_CSUM( iov[index].iov_base, iov[index].iov_len, pConv );
+                        break;
+                    } else {
+                        iov[index].iov_base = (IOVBASE_TYPE *) user_memory;
+                        iov[index].iov_len = pData->size;
+                        user_memory += extent;
+                        COMPUTE_CSUM( iov[index].iov_base, (size_t)iov[index].iov_len, pConv );
+                    }
+                    remaining -= iov[index].iov_len;
+                    pConv->bConverted += iov[index].iov_len;
+                }
+                *out_size = index;
+                *max_data = (pConv->bConverted - initial_bytes_converted);
+                if( pConv->bConverted == pConv->local_size ) {
+                    pConv->flags |= CONVERTOR_COMPLETED;
+                    return 1;
+                }
+                return 0;
+            }
+        }
+
+        {
+
+            length = (0 == pConv->stack_pos ? 0 : stack[1].count);  /* left over from the last pack */
+            /* data left from last round and enough space in the buffer */
+            if( (0 != length) && (length <= remaining)) {
+                /* copy the partial left-over from the previous round */
+                OPAL_DATATYPE_SAFEGUARD_POINTER( user_memory, length, pConv->pBaseBuf,
+                                                 pData, pConv->count );
+                MEMCPY_CSUM( packed_buffer, user_memory, length, pConv );
+                packed_buffer  += length;
+                user_memory    += (extent - pData->size + length);
+                remaining      -= length;
+                stack[1].count -= length;
+                if( 0 == stack[1].count) { /* one completed element */
+                    stack[0].count--;
+                    stack[0].disp += extent;
+                    if( 0 != stack[0].count ) {  /* not yet done */
+                        stack[1].count = pData->size;
+                        stack[1].disp = 0;
+                    }
+                }
+            }
+            for( i = 0;  pData->size <= remaining; i++ ) {
+                OPAL_DATATYPE_SAFEGUARD_POINTER( user_memory, pData->size, pConv->pBaseBuf,
+                                                 pData, pConv->count );
+                MEMCPY_CSUM( packed_buffer, user_memory, pData->size, pConv );
+                packed_buffer += pData->size;
+                user_memory   += extent;
+                remaining   -= pData->size;
+            }
+            stack[0].count -= i;  /* the filled up and the entire types */
+            stack[0].disp  += (i * extent);
+            stack[1].disp  += remaining;
+            /* Copy the last bits */
+            if( 0 != remaining ) {
+                OPAL_DATATYPE_SAFEGUARD_POINTER( user_memory, remaining, pConv->pBaseBuf,
+                                                 pData, pConv->count );
+                MEMCPY_CSUM( packed_buffer, user_memory, remaining, pConv );
+                user_memory += remaining;
+                stack[1].count -= remaining;
+            }
+            if( 0 == stack[1].count ) {  /* prepare for the next element */
+                stack[1].count = pData->size;
+                stack[1].disp  = 0;
+            }
+        }
+        pConv->bConverted += bConverted;
+    }
+    *out_size = iov_count;
+    *max_data = (pConv->bConverted - initial_bytes_converted);
+    if( pConv->bConverted == pConv->local_size ) {
+        pConv->flags |= CONVERTOR_COMPLETED;
+        return 1;
+    }
+    return 0;
+}
+int32_t convertor_prepare_for_send( opal_convertor_t* convertor,
+                                    const struct opal_datatype_t* datatype,
+                                    int32_t count,
+                                    const void* pUserBuf );
+
+int32_t convertor_prepare_for_send( opal_convertor_t* convertor,
+                                    const struct opal_datatype_t* datatype,
+                                    int32_t count,
+                                    const void* pUserBuf )
+{
+    convertor->flags |= CONVERTOR_SEND;
+
+    {
+#if 0
+        uint32_t bdt_mask;
+#endif
+
+        /* If the data is empty we just mark the convertor as
+         * completed. With this flag set the pack and unpack functions
+         * will not do anything.
+         */                                                             \
+        if( OPAL_UNLIKELY((0 == count) || (0 == datatype->size)) ) {
+            convertor->flags |= OPAL_DATATYPE_FLAG_NO_GAPS | CONVERTOR_COMPLETED;
+            convertor->local_size = convertor->remote_size = 0;
+            return OPAL_SUCCESS;
+        }
+        /* Compute the local in advance */
+        convertor->local_size = count * datatype->size;
+        convertor->pBaseBuf   = (unsigned char*)pUserBuf;
+        convertor->count      = count;
+
+        /* Grab the datatype part of the flags */
+        convertor->flags     &= CONVERTOR_TYPE_MASK;
+        convertor->flags     |= (CONVERTOR_DATATYPE_MASK & datatype->flags);
+        convertor->flags     |= (CONVERTOR_NO_OP | CONVERTOR_HOMOGENEOUS);
+        convertor->pDesc      = (opal_datatype_t*)datatype;
+        convertor->bConverted = 0;
+        /* By default consider the optimized description */
+        convertor->use_desc = &(datatype->opt_desc);
+
+        convertor->remote_size = convertor->local_size;
+        if( OPAL_LIKELY(convertor->remoteArch == opal_local_arch) ) {
+            if( (convertor->flags & (CONVERTOR_WITH_CHECKSUM | OPAL_DATATYPE_FLAG_NO_GAPS)) == OPAL_DATATYPE_FLAG_NO_GAPS ) {
+                return OPAL_SUCCESS;
+            }
+            if( ((convertor->flags & (CONVERTOR_WITH_CHECKSUM | OPAL_DATATYPE_FLAG_CONTIGUOUS))
+                 == OPAL_DATATYPE_FLAG_CONTIGUOUS) && (1 == count) ) {
+                return OPAL_SUCCESS;
+            }
+        }
+
+#if 0
+        bdt_mask = datatype->bdt_used & convertor->master->hetero_mask;
+        OPAL_CONVERTOR_COMPUTE_REMOTE_SIZE( convertor, datatype,
+                                            bdt_mask );
+#elif 1
+        // FIXME
+        convertor->use_desc = &(datatype->desc);
+#endif
+        assert( NULL != convertor->use_desc->desc );
+        /* For predefined datatypes (contiguous) do nothing more */
+        /* if checksum is enabled then always continue */
+        if( ((convertor->flags & (CONVERTOR_WITH_CHECKSUM | OPAL_DATATYPE_FLAG_NO_GAPS))
+             == OPAL_DATATYPE_FLAG_NO_GAPS) &&
+            (convertor->flags & (CONVERTOR_SEND | CONVERTOR_HOMOGENEOUS)) ) {
+            return OPAL_SUCCESS;
+        }
+        convertor->flags &= ~CONVERTOR_NO_OP;
+        {
+            uint32_t required_stack_length = datatype->btypes[OPAL_DATATYPE_LOOP] + 1;
+
+            if( required_stack_length > convertor->stack_size ) {
+                assert(convertor->pStack == convertor->static_stack);
+                convertor->stack_size = required_stack_length;
+                convertor->pStack     = (dt_stack_t*)malloc(sizeof(dt_stack_t) *
+                                                            convertor->stack_size );
+            }
+        }
+        convertor_create_stack_at_begining( convertor, opal_datatype_local_sizes );
+    }
+
+    convertor->fAdvance = pack_homogeneous_contig_with_gaps;
+    return OPAL_SUCCESS;
+}
+
+static void opal_convertor_construct( opal_convertor_t* convertor );
+
+static void opal_convertor_construct( opal_convertor_t* convertor )
+{
+    convertor->pStack         = convertor->static_stack;
+    convertor->stack_size     = DT_STATIC_STACK_SIZE;
+    convertor->partial_length = 0;
+    convertor->remoteArch     = opal_local_arch;
+    convertor->flags          = OPAL_DATATYPE_FLAG_NO_GAPS | CONVERTOR_COMPLETED;
+#if OPAL_CUDA_SUPPORT
+    convertor->cbmemcpy       = &opal_cuda_memcpy;
+#endif
+}
+
+int
+main(int argc, char* argv[])
+{
+    int ret;
+    typedef struct {
+        long l;
+        int i;
+        int p;
+    } li_t;
+    li_t li[2] = { { 1, 2, -1}, {3, 4, -1} };
+    char buf[32];
+    char *p;
+
+    ompi_datatype_t *type;
+    int blens[2] = { 1, 1};
+    MPI_Aint displs[2] = {0, 8};
+    ompi_datatype_t *types[2] = { &ompi_mpi_long.dt, &ompi_mpi_int.dt };
+
+    opal_convertor_t convertor;
+    struct iovec iov = { buf, 24 };
+    uint32_t out_size = 1;
+    size_t max_data = 24;
+
+    ret = ompi_datatype_init();
+    if (0 != ret) return ret;
+
+    ret = ompi_datatype_create_struct( 2, blens, displs, types, &type );
+    if (0 != ret) goto cleanup;
+    ret = ompi_datatype_commit( &type );
+    if (0 != ret) goto cleanup;
+
+    memset(&convertor, 0, sizeof(opal_convertor_t));
+    opal_convertor_construct( &convertor );
+
+    ret = convertor_prepare_for_send( &convertor,
+                                      &type->super,
+                                      2,
+                                      li );
+
+    ret = opal_convertor_pack ( &convertor, &iov, &out_size, &max_data );
+
+    p = buf;
+    assert(1 == *(long *)p);
+    p += sizeof(long);
+    assert(2 == *(int *)p);
+    p += sizeof(int);
+    assert(3 == *(long *)p);
+    p += sizeof(long);
+    assert(4 == *(int *)p);
+
+ cleanup:
+    ompi_datatype_finalize();
+
+    return ret;
+}
```

i hetero mode, convertor->use_desc is the normal description
if you replace #elif 1 with #elif 0, this "emulates" my patch and fixes the test.

fwiw, my previous patch implementation was an overkill, i should have used convertor->flags & CONVERTOR_SEND instead of adding an extra macro parameter


I don't know what plans are in the offing, but citeproc-js should be happy with any unique string or number that identifies an item. URIs are fine as well, but the processor will not cope with an array of them, and there is no means of substituting IDs on the fly within a processor instance.


Please rename the formatation parameter. Not sure if that's a word in any language. French maybe?


pushed -f fix for this


If you prefer the same arguments for removing sections can be directly applied with objcopy command. The command will take the full elf and generate the .bin with removed sections.


и вынеси уже эти 2 функции из html кода в отдельный файл чтоб кашу не делать


I think we should create a separate response for Ping. Like SolrPingResponse struct.


十二月


Isn't `cacheMap` and `cacheList` an attribute of the expression being transformed/derived?

It seems `cacheMap` and `cacheList` are global variables just so that `transform` and `memoizedDerive` can communicate with each other about the mapping between terms and caches. How about fusing these 2 traversals into an monadic fold?

    def memoDerive(t: Term): MemoDeriveResult
    case class MemoDeriveResult(
      transformedTermReader: CacheMap => Term
      memoizedDerivativeReader: CacheMap => Term
      cacheMap: CacheMap)

The transformed term and memoized derivatives are saved inside a reader monad so that we can combine cache maps from subterms without worrying about conflicting entries.


You can did that because the "X" player played on middle square :)


Lelövöm a poént.

Amire én gondoltam `domReady`-implementációként, az ez lett volna:

```javascript

function domReady() {
    // Save arguments.
    var callbackQueue = arguments;

    // Watch document ready state.
    document.addEventListener("readystatechange", function(e){
        // In "interactive" state, the DOM can be safely manipulated.
        // "complete" state equals to the DOMContentLoaded event.
        if(e.target.readyState == "interactive") {
            // Check each argument
            for(var i = 0; i < callbackQueue.length; ++i) {
                // If the argument is callable, execute it!
                if(callbackQueue[i] instanceof Function) {
                    callbackQueue[i]();
                }
            }
        }
    });
}

```

Ezek után pedig akárhol a kódban:

```javascript

function recolorLinks() {
    // Do something with link elements on the page.
    // DOM elements can be accessed here only if this
    // function is provided to domReady as a callback
    // parameter.
}

domReady(
    recolorLinks,
    "I will not be called because I am not a function",
    ["neither", "this", "will", "be", "executed"],
    function() {
        console.log("DOM ready events successfully ran.");
    }
);
```


Yes, this could be tweaked a bit, and I think it's bound to break some backwards compatibility.

I don't think `[directories] [--] [<args>...]` is quite going to work though, e.g.:
```sh
$ ptw foo bar
```
Is `foo` here a directory or a first argument to pass to `py.test`?


Those maps are just a representation of how the map should look like after the contentfilter is being used. The key values will be between -1, 0 and 1.


I think that's a wrong move. In contradicts with the openness. and conveys that non-gratipay clients are not welcome to read this blog.


I don't know the reason, but in qsys, it is recommended not to copy the hex, instead to add .qip to quartus and compile; makes it complex though :)


Also, the phrase "collection of people" sounds like a softer version "a pool of human resources". =) Why do you need to join people into collections?


I have some doubts about this commit.

> Centralizing it here allows us to see what is happening with every part that needs to open a connection. If we need more we can raise the pool limit or investigate why it is consuming more, this will not be possible if every instance have its own pool.

HTTPClient will be used by several different independent modules of leap. I don't think will be more interesting to rise the pool limit for a global pool than for the pool of the module you are testing. If changing this limit could be useful I think it will make more sense to have it as optional parameter of the `__init__`.

> Also, we will be able to call _pool.closeCachedConnections on shutdowns and be sure that no connection is left.

The shutdown of one module might be completely independent of the shutdown of another, if they share the pool that means that they can not do your proposed `_pool.closeCachedConnections` as the pool will have connections for many different modules.


[#95303030][#95302992][#95303018][#95303000]


Sure.


Yes, you are right. I did it also this way, but failed. Thus I used the strip command to get an elf and check with nios2-elf-readelf if the sections are really removed.

I will try it without strip command...


You're right. Fixed.


Huh? Return?


Localization is already supported. On this line - english values are only defaults. You can define your own labels in calendar instance constructor.

In index.html example I've localized labels to Czech language.

See:

```javascript
uiCalendarAuto('.datepicker3', {
	fromSelector: '.date-from',
	//....
	//Localized labels:
	dayLabels: ["Ne", "Po", "Út", "St", "Čt", "Pá", "So"],
	monthLabels: ["Leden", "Únor", "Březen", "Duben", "Květen", "Červen", 						  "Červenec", "Srpen", "Září", "Říjen", "Listopad", "Prosinec"]
})
```


Great! Just forget to bump the version in `bower.json`


That's what I had initially (`--ignore`), I wouldn't mind changing it to that, it looks more intuitive.

Re: recursive directories and ignoring them -- watchdog indeed support pattern matching event handlers, regex matching handlers etc but that's not quite the same as preventing watchdog to descend into those in the first place, hence the need to do it manually. Maybe I'm missing something from watchdog documentation.

Another idea I had was reading `norecursedirs` from `pytest.conf`/`setup.cfg`/`tox.ini` and trying to infer a base value of `--ignore` from there (this requires two more things though: parsing the pytest arguments to see if `-c someconfig.ini` was passed in, and implementing pattern matches for folder exclusion).


I checked the auto-builds and all native libs are missing from the apk so I guess the ndk-build failed at some point. Also that's why it's crashing, obviously ;-)
I made a fresh git clone of this commit, rebuild everything and launched the emulator with no issues.
@paulscode could you check the auto-builds to see what's happening during the ndk-build?
I'm using ndk-r10d BTW.


I tried it with the qip, but then update-mif failed to update the sof correctly. So basically this is another workaround making us all valuable :)


Do you mind removing this commit from this pull-req and do a pull-req for it. It's unrelated to HTTPClient, and there is better people than me to review it.


感谢。


okay, that's good to know! I made it an issue, and fill fix it.


The parentheses around the `scalar @_ > 200` are unnecessary, because the `>` operator has a higher precedence than the `&&` operator.


You can use advantage of shorthand routes `video` instead of `video_path(video)`.


No need for `dup()` before `dot()` as it doesn't modify the vector.


Agreed, but as mentioned in the commit message ("we have impure expressions"), programs aren't really pure, because we have generative functors (AbelianGroup instances). But now I know how to desugar that to pure constructs (from Dreyer's F-ing modules), so maybe restoring purity is a better fix.


помнишь мы говорили о том что функция должна делать какую-то ОДНУ задачу по идее эта функция должна получая массив маршрутов просто отрисовать(отрендерить еще говорят) их в хтмле. Это называется Принципом Единственной Ответственности (Single Responsibility Principle - SRP) Первый из принципов [SOLID](https://ru.wikipedia.org/wiki/SOLID_%28%D0%BE%D0%B1%D1%8A%D0%B5%D0%BA%D1%82%D0%BD%D0%BE-%D0%BE%D1%80%D0%B8%D0%B5%D0%BD%D1%82%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D0%BD%D0%BD%D0%BE%D0%B5_%D0%BF%D1%80%D0%BE%D0%B3%D1%80%D0%B0%D0%BC%D0%BC%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D0%BD%D0%B8%D0%B5%29) а тут получается что ты еще к каждому элементу прикручиваешь маршрут и обработчик клика.


You could use `= image_tag video.small_cover_url` here :)


get_document() seems like a better name for this.


I don't understand what "to one another" means.

The explanation at http://www.thefreedictionary.com/one+another make me cry:

"Used to indicate a reciprocal relationship or reciprocal actions among the members of the set referred to by the antecedent"


Thanks for catching that, it is fixed and tested now.


for the test， so....


:) The steps I mentioned here and in the previous are the ones that I did differently and mine does not work. So may be your choices were correct here :8ball:


Hm, looks good, the binary file size is ok. Maybe it was too late yesterday :)


*received


Thanks.


True and it is no longer in the configure.ac we clearly forgot to remove this conditional as well. Removing it now.


Not sure, the library is full of both form, don't know what's the best


don't forget to add this to the wiki if you want this to be included upstream :)


How certain can we be at this point that there *is* a `--` parameter? In other words, does `@myArgs` contain a `--` element here even when I call:

```sh
git add -p -v my-subdirectory/
```


Does this `%h3 #{@video.title}` work as well for you?


The main side effect is that docopt runs something like `shlex.split` and returns us a ready-to-use list of positional arguments to pass to pytest. If we use `shell=True`, we now have to join all those strings back together and pass them as a string to `subprocess.call` so the shell can parse it again which is a bit of a waste... Now imagine what happens when one of the arguments contains spaces (and gets dequoted for you by docopt)?

Also, if you do something like
```sh
ptw -- test*.py
```
Your shell will expand it anyway *before* it even reaches docopt, so I don't see any point in using `shell=True`.


k? @victorsolis


One more thing, are you getting the warnings about the data width exceeding the address width while updating mif?


кстати по поводу клика это не совсем технически верно - более правильно использовать onchange а не onclick событие


This commented area should be deleted. The templates can be found under ui directory anyway.


lol k


Copy of method in Adviezen/Beheersplannen. But I renamed it in pyoes now.


BTW you can find out by adding a debug print statement here:

```perl
print STDERR "myArgs: [ " . join(', ', @myArgs) . "]\n";
```


还可也通过调用类里面的start 和 stop 方法实现自动滚动效果！


Could you explain how to avoid the error that this changes introduces:

```
Catchable Fatal Error: Argument 2 passed to Symfony\Bundle\TwigBundle\Controller\ExceptionController::showAction() must be an instance of Symfony\Component\HttpKernel\Exception\FlattenException, instance of Symfony\Component\Debug\Exception\FlattenException given
```

mentioned in comments on http://symfony.com/blog/new-in-symfony-2-6-error-page-previews

Sorry, I don't have the skills to dig out the problem.


We can also try it again for the 2.2.1 to use the qip, since it is the recommended way. But for 2.2.0 it is enough that it works...


This is redundant. `install_requires` is implicit for `tests_require`. This also means that `install_requires` can keep being a tuple.


This sample file can stay there. You didnt have to delete it. It is meant to be a mirror or an example/sample of what you have in your gitignored `database.yml` - obviously without confidential details :)


test comment


lesson/lesson 5 - document object model/www/js/def.js

Ehhez miért kell lezártat (*closure*) használni?


ok


I think we need to `close($fhargs);` here.


hello


Nice, I would add just that its better to use `.create!` <--- bang version. Because it pops an exception if validations have not passed, while you seed. As it is now, errors are silently ignored.


Regarding splitting query the code in two: the second part relating to meta-data doesn't sound like code.  Is the second part just meta-data or is there any code aspects to this?


Is the binary running?


This is now `reset_all()` by 28f45ad right?


Looks a lot cleaner. Couple of points:
- In check_mode the tempdir is not deleted.
- The distribution checking and downloading could use a comment describing what's going on and why.
- too many fors in "# Remove rpms downloaded for for EL5 via url"


@5ource , hello


Yes, I get those warnings, but it looks like that this is no issue since
it boots and operates correctly. Nevertheless I will check the M10K
content with the debugger, just to be sure!


Yes, otherwise, Matlab R2015a complains:
Warning: Function reset has the same name as a MATLAB builtin. We suggest you rename the
function to avoid a potential name conflict.


Nem felejtettél el valamit, mielőtt hozzáadtad a klónt a dokumentumhoz?

Tégy ide egy breakpoint-ot a dev tools-ban, és figyeld meg a HTML struktúrát! Remélem feltűnik, mi lesz itt a gond


Ugh, yeah, not sure what I was thinking there.


Please write a proper docstring (shouldn't mention anything about adviezen and have some information on the expected parameters).

Also, write a unit test for this, in stead of ignoring coverage


Well, `.sort_by` is a bit slower, because its just pure ruby. You should user `.order`.


since there is an existing function called `parent()` I agree.
Btw it looks like all functions that return something with a bigger size ( structs etc ) are called `get_foo()` while functions that return ints or pointers are just `foo() ( first impression )


Kódformázás! A behúzások stimmeljenek mindenhol!


This should be just `%h3= link_to category.name, category`.


@RealMattMurdoch please proof-read


We only need this `tempfile` inside the `if` clause below, right? How about opening it only in that case?


-> running, install


I have amended and pushed a new commit


Will do the refactoring that the commit messge suggests we need during the work we do for https://www.pivotaltracker.com/story/show/94783872


You are right!


Is the wiki mergeable in a PR?


More love more fun.


Line 21 mentions that workunit "only" contains .. meta data.  So, is the dll created from the query, not part of a workunit?


Hi @samstav. I don't think you should catch anything more than `ValueError` here. The tiny "interface" (if you can call it that) I made here was that the loaders would throw a `ValueError` if they cannot deal with the input and want to let another load try.

If they know the input is malformed and no loader can work (e.g., if they can parse the input as XML, but detect that the structure is invalid), they should raise something else, which will abort the entire function.


+ A `temp` változó mint string, szükségtelen.
+ A hátultesztelő ciklust lehet egyszerűsíteni (három helyen is szerepel benne a `null` egyszer pedig stringként! Ne feledd: a null is objektum!)


hii


@jamesotron interesting. Why do you think it's dumb?

Surely it's good for getting travis to install the latest gems that match your dependencies, and hence break when your dependencies are too loose.


```javascript
return objTemp;
```


Для сборки проекта в корне имеется bat file для maven'a


@matsvandecavey I also wanted the user to be able to set the chart type using `options=dict(chart=dict(type='area))` but maybe this is not necessary and setting the type with the `type` argument is sufficient?


DLL is really Microsoft implementation of Shared Libraries.  Consider replacing all references to DLL with the generic name "Shared Library".


Do we know that this change is compatible with PowerShell version 2 and 3? The old code has been tested with both versions.


Tu peux faire plus propre que ca en définissant une value dans les select


When you pass block to `link_to` the first argument is path then. Therefor `= link_to video, nil do` should be well too.


addObserverForName возвращает объект на который добавляется эта подписка, соответственно если ему нужно делать removeObserver. В документации есть по этому поводу пример.


<option value="true">Oui</option>
<option value="false">Non</option>


@matsvandecavey Nice one!


Interestingly, the meaning of "sharing caches for identical subexpressions" depends on the actual names used. If we wanted to do that after ensuring purity (which isn't clear in the end, but would be the obvious thing to do), we'd probably want to treat `x + y` and `y + z` as identical subexpressions, which isn't quite alpha-equivalence as usually defined. (A roundabout way of defining the right equivalence is constructing `𝜆 x y. x + x` `𝜆 y z. y + y` and comparing those by alpha-equivalence, though this will miss expressions which are equal if one permutes variables; unification where unifiers are restricted to substitute only variables for other variables would do the trick).


I'm very uncomfortable with random waits like this in the code. No matter what threshold you pick, it's bound to be too large in some (most?) cases and bound to fail in others. We need something like retries with an exponential backoff instead.


lgtm


Yes! Okay I will skip the stirp command..


We need a `typeId` here!


That's due to the generated hex file. It won't be a problem. But it can be avoided by appending an argument to the elf2hex commands run in mem_init_generate.
Normally there will be an argument for the elf2hex as --width=8 in the Makefile. You can add another argument as --record=4.

The warning is there because the hex file places 8 words(intel's default) of data in each line while incrementing the address by 4. I think quartus automatically wraps it to correct sizes, but just to be sure.


A lot of garbage files from generators.


I missed those messages. Is there a way to force yum to error in such situations instead of just printing a warning?


Kipróbálhatod majd a `classList` adattag módosítását is! Ez egy tömb-szerű objektum, tehát ugyanúgy lehet class-okat hozzáadni és elvenni egy elemről, mint tömbelemeket `push`-olni és `pop`-olni.

[MDN](https://developer.mozilla.org/en-US/docs/Web/API/Element/classList)


Following on from previous comment regarding Line 21: it sounds like here workunit is also a shared object consisting, which implies that it contains more than just meta data - it must contain some query execution logic as well?


I'd just write `If you want the parameter order ... you should...` as the reader is the one for whom the message is. Just for future reference.


ack


This does not look like it will convert anything to Unicode. In Python 2 it won't do anything, and in Python 3 it will decode `output` using the default encoding, which is UTF-8 as far as I remember.

I think the implicit nature of this is dangerous and confusing. Instead, please use `output.decode(<pick an encoding>)` to make it explicit.


Anyway, if it works.. happy :)


Conflicting entries appear in the same program. I'll do this change anyway to avoid interference among different programs, but that's not enough.
In fact, the correct semantics (as long as expressions can be impure) is:
- label nodes of the AST through a visit, without reusing labels;
- map the labels to cache names injectively.


Or just plain and simple `To preserve the order, use OrderedDict.` Shorter.


this doesn't fix #477 yet


maybe use `See <bug Url>` instead


I don't see `smb` being used in the changes below.


Consider setting `config.force_ssl` to true in all production environments, especially if they require a user to enter a password or other sensitive information. Heroku always provides a working TLS/SSL environment to subdomains of `*.herokuapp.com`.


From commit message:

```
The show_bears method takes a dictionary as input with bears as keys
and a list of sections as values and processes it to present it in a
stylized manner.
```

That info should rather go into a doc comment in the previous commit!


I'd put that `\n` into the line above so the indentation reads more realistic here


OK, thx for the info!


within the string I mean


- @Suspended
Sorry, I forgot to add it on the PR notes. Motivation was that @Suspended annotation is costly and our API and model is not async, so it doesnt make so much sense to add it (at this point). Also I looked into inventory and they don't use @Suspended now, so I thought it could be interesting to maintain a standard REST endpoints now and we can add perf improvements in next iterations.
- About 204/404.
To be honest, I'm still having doubts. I've read several articles and also look into accounts/inventory to try to be consistent in the meaning of the codes.
This is rule I tried to follow:
a) for a non parameter REST end point, i.e. /alerts, it should be 204 when no content is found (empty list).
b) for a parameter REST endpoint /trigger/my-code/conditions, if my-code doesnt exist it should return a 404 as the resource is not found.
c) I'm still having doubts with PUT/DELETE operations, but I tried to follow same pattern as well, as some codes were using with different meaning.
Anyway, to change the code is just trivial, but I agree these one can vary once all REST endpoints use same meaning.
I will review them to see if perhaps in the review I change some of them incorrectly.
- IDE Formating:
+1
I'm agree which whatever format, but I have the IDE to not modify layout existing layout, just align new one.
Is it possible you have configured Eclipse to automatically change the layout ?


How do you want to proceed with this patch at LTC? Submit as a simplification maybe?


no need to translate `Some Description` as you don't mark it translatable above


also it is a test string so we don't want that translated


¡Ostras alguien que se llama igual que yo!


@JohnDeGitt  Thank you very much, I'll check it as soon as I can. I wonder, because of my limited knowledge, if your solution is backwards-compatible or not, but I'll try to check for it as well.

All the best

Jorge


I guess this was here to document the API of this mixin class? Should it not have been left there (with the docstring) so the API remains documented? Perhaps change `pass` to `raise NotImplemented` if all subclasses must implement this.


Can I ask what is the performance now!!


This needs to be undone, we have our whitelists in the whitelists folder. Make it so the ugc config points to there instead.


I don't know, will check it tomorrow...


maybe split some of those "paragraphs" into an own method? I.e. `test_show_bears_empty` and so on so that from the test name each corner case is better visible and they can fail individually giving better debug information?


Will do


missing newline before EOF


오늘부터 머신러닝 파이썬 코드 연재할게요~

간단한 차원축소방법인 PCA 부터 시작하겠습니다.

이걸 실행하려면 파이썬 Scikit-Learn이 깔려있어야 합니다.


I do mark the description of the bear for translation. `_(metadata.desc)`


Cc @oxij


Commit message:

```
show_bears.py contains process_bears which extracts all the bears from
a section and compiles them in a dictionary. Then show_bears method
calls this for every section which is enabled or is present in the
targets and calls the interactor to print out the information.
```

You tend to put your documentation comments into the commit message. Some general advise: a programmer will look at the documentation comment when he wants to know how to use a method. The programmer will want to know why you wrote the method as it is when a problem occurs, this is when he uses git blame and this is when the commit message matters, so it is better for reasoning and background information that help on problems and possible bugs introduced by your commit.


Ist ein Linux, macht aber mit Python aus irgendeinem Grund encoding-Probleme


there willl be exception here, not null


`process_bears` is a pretty generic name, no better idea?


Thanks. See 8c18e0a.


I'm not sure how that can be a good idea. Is the expectation that the characters we cannot decode are in some cruft outside of the real data? If so, we should cut off this cruft while the string remains a binary string, and then decode the data. That will avoid hiding real problems in case the data isn't encoded correctly.

Also, please never use `unicode(<some object>)` since it does an implicit decoding using Python's default encoding. That encoding has changes between Python 2 and 3: it was ASCII in Python 2 and is UTF-8 in Python 3. So this kind of code is bound to give different results between the versions and will generally confuse people.


Ja, war auch mein Gedanke. Sonst hätte ich das gleich so implementiert.


True, fixed.


Sphere api aangemaakt bezig met het doorgeven van verschillende raw photosphere afbeeldingen naar deze activity


I would call it UserGroupsWsModule


Done.


Oh, it seems you fixed the API here compared to an earlier commit. Nice -- could you move the change back to the earlier commit so I don't get confused in the future? :-)


Yeah but thanks for the hint, I'll keep improving it when I have more time.


DefaultArgParser is seperated from CliParser, testing an argument in the CliParserTest is wrong IMO, one could write a test for the DefaultArgParser, it is however questionable if this makes sense as the object rather describes some state than some functionality.


if you made full information in rst than it is beta now. Or is it not full?


mmm, nope, tests don't agree with us - we should not navigate to any panel if  user doesn't want to discard draft  - ```draftDiscardPromise``` (top-level promise that you meant?) is rejected in that case.


space after foreach statement.


just use the pretty syntax `"show_bears" in sections["default"]`


allTurnHistory is for computing highest score by a player, it does not get emptied when a player wins a leg.
turnHistory is for computing the averages of every turn when a player scores. It does get empitied when a player wins a leg.


If you build Hugo from source, you can do it even simpler ...


Travis is complaining because you've got two entries for the same plugins:

```
masterlist.yaml#0: INVALID
  - [/plugins/1268/name] 'Fran Armor Add-on.esp': is already used at '/plugins/249/name'.
  - [/plugins/1273/name] 'Francesco's Optional Leveled Guards.esp': is already used at '/plugins/245/name'.
  - [/plugins/4745/name] 'Happyhannah's Wines.esp': is already used at '/plugins/503/name'.
  - [/plugins/4748/name] 'icearmor.esp': is already used at '/plugins/924/name'.
  - [/plugins/4765/name] 'Better Bell Sounds.esp': is already used at '/plugins/359/name'.
  - [/plugins/4775/name] 'Morrowind_ob - Conversation.esp': is already used at '/plugins/1733/name'.
```

I don't know why you commented out those old C.Water tag removals, either keep them or remove them, don't waste space commenting them out. I don't see the point in removing them though, they're doing no harm.

Also, you've moved a couple of plugins around in the list: please don't do that. It's completely unnecessary and makes changes to those plugins more difficult to track.


you added {{ .IsHome }}?


It would be nice to have the hex sequence with SchemaRaw spelled out - what information is there after searchname.


@marksamman
Check this: http://tibia.wikia.com/wiki/Mounts
All have speed + 10 now


Ich habe den commit wieder in eine leere vm ausgecheckt. Der commit enthält immer nocht Fehler. windows und mainWin ist immer nil. Der close handler ist also nicht funktionsfähig.


OrionMySQLSink instead of OrionCKANSink


you can't mark a variable for translation!


Hello,
In yours querys you put two sets
When you create a update query only put one 'SET', for example UPDATE example set field1="Example", field2 = 666 where things = things;


as I said we don't want this test description to be translated anyway


Is there any significant differences between Thor and Roxie workunits?


it should be "boxes"


間違い


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15550/testReport/) for this commit**


Do not add `Content-Type: text/html` in the e-mail headers unless sure file name properly escaped for html tags!


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL6 [Build 215](http://ci.infinispan.org/viewLog.html?buildId=26961&buildTypeId=HotRodCpp_PullRequestsMonitorRhel6&guest=1) for 7c512eefd8f786958257bf453d97be4cbf7773b2
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:01:27


Yep.


typo - `additiona(l)`


Looks legit!


this is bad idea. common.sh is provision common to all images not only docker. plus, this already done in prepare_nightly.sh


When I tried to compile ROM with GCC-5.1 I had error (/out/target/product/X/obj/STATIC_LIBRARIES/libcutils_intermediates/strdup8to16.o - something with char16_t). I switched back to GCC-4.8 and it's compiled without warnings and errors.


TeamCity xBIM :: Xbim Geometry :: Release [Build 80](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1767&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Compilation error: Xbim.Geometry.Engine\Xbim.Geometry.Engine.vcxproj (new) Build time: 01:44:23


I think the above lines are equivalent to ```stringValueAttributes.DefaultIfEmpty(new StringValueAttribute(value.ToString());``` (actually, your way saves an object allocation, but I don't think that's too important).


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


28:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
153:58: E203 whitespace before ','
213:15: E126 continuation line over-indented for hanging indent
216:1: E402 module level import not at top of file
250:17: E203 whitespace before ':'
251:22: E203 whitespace before ':'
252:20: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:24: E203 whitespace before ':'
255:22: E203 whitespace before ':'
256:19: E203 whitespace before ':'
257:20: E203 whitespace before ':'
258:23: E203 whitespace before ':'
259:18: E203 whitespace before ':'
260:17: E203 whitespace before ':'
261:19: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:21: E203 whitespace before ':'
264:19: E203 whitespace before ':'
265:19: E203 whitespace before ':'
266:20: E203 whitespace before ':'
267:17: E203 whitespace before ':'
268:24: E203 whitespace before ':'
269:23: E203 whitespace before ':'
270:21: E203 whitespace before ':'
271:37: E203 whitespace before ':'
285:4: E131 continuation line unaligned for hanging indent
314:1: W391 blank line at end of file