I know I can define a err variable. But if we need to retrieve the awserr
information, we need to do a type cast, which defeat the purpose of
returning aweerr.Error in the first place. Also we have to keep in mind to
define an error variable if we are going to call any aws function.

On Wed, May 20, 2015 at 10:15 AM, Loren Segal <notifications@github.com>
wrote:

> @b6g <https://github.com/b6g> an easy solution to your issue would be to
> add var err error above the initial line:
>
> var err error
> output, err = s3manage.Upload(svc, input, opts)
> _, err = io.Copy(dst, src) // * we cannot do this *
>
> We are looking at changing the return type back to make this a little
> simpler.
> Let's continue this discussion in #238
> <https://github.com/awslabs/aws-sdk-go/issues/238> since this diff is
> quite large and my browser doesn't seem to enjoy having this page loaded.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/awslabs/aws-sdk-go/commit/3c259c9586a4a82d6f00e7c01a69263f798e8ffe#commitcomment-11289121>
> .
>


You are missing the signature, purpose statements and tests. Please follow the design recipe


Thank you!


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (634 of 634 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.3%25-green.svg)


Yes. Without the extra spaces there is not a lot of separation between the
submit button and page footer.

On Wed, May 20, 2015 at 10:22 AM, Ali Haugh <notifications@github.com>
wrote:

> What is the purpose of the paragraph tags here? Is it for adding extra
> space at the end of the form?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abztrakt/WP-UWConnect/commit/635e92fcb1e80b847e638566c1e81f40ab72934f#commitcomment-11289258>
> .
>

--
Peter White
UW-IT: Applications Engineering
University of Washington
email: pewhite@uw.edu
phone: (206) 221-1054


accessing the UI when job has null value set, non `<option>` will be selected, just like for a fresh new job, and as a result will show "Default" (first option) as selected.


Is it OK? I thought it would return same thing, but didn't try running the code. So could easily have screwed up.


Hmm. In our implementation we pass a filename instead. I thought the command-line option was tested but now I doubt that.


i made this comment because [line 1042](https://github.com/osu-mist/evals/blob/315bd74ed0c57397c474c0b85746152134b4718a/docroot/WEB-INF/src/edu/osu/cws/evals/models/Appraisal.java#L1042) does not align with other indented if statements in this method, e.g., [line 1047](https://github.com/osu-mist/evals/blob/315bd74ed0c57397c474c0b85746152134b4718a/docroot/WEB-INF/src/edu/osu/cws/evals/models/Appraisal.java#L1047).


r+


Ok, besprechen wir das. Das Mac Postfix ist schon lange entfernt, nur noch nicht gepusht (jetzt habe ich es gemacht)


have truncated them to a single packet per file and added them ... -
please check;

On 5/20/15 17:50, fxlb wrote:
> Can we put theses files in the tcpdump tests/ directory?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/the-tcpdump-group/tcpdump/commit/be03cc0b4ae9370ea0483d1504f4a950b22625d3#commitcomment-11287200>.
>


So if a request fails on a 404, then the Client would looks to see if it was originally created with an explicit version.  If so, it fails.  If not, the Client will attempt to negotiate the api version and reattempt the call?

That flow can't work because of the object serialization required.  So it would be the responsibility of every caller to negotiate on failures?


the first paragraph of the above comment is the one i wanted to emphasize. i would recommend rewording the comment because lines 1041-1042 imply that status "does not become overdue", not that it "becomes expired instead of overdue". the current wording suggests that the logic is combined somehow.


1836664-ReturnWaterTempReset (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1665 of 1665 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Not sure how it's related, but after this commit, the (C#) pattern matching output changed.
Code:
```haxe
class Main {
    static function main() {
        switch (Type.typeof("hello")) {
            case TClass(c):
                if (c == String)
                    Sys.println("s");
                else if (c == Array)
                    Sys.println("a");
                else
                    Sys.println("o");
            default:
        }
    }
}
```
Was (good because `(global::System.Type) (_g.@params[0])` is executed only once and then stored in a var).
```cs
global::ValueType _g = global::Type.@typeof("hello");
switch (_g.index) {
	case 6:
	{
		global::System.Type c = ((global::System.Type) (_g.@params[0]) );
		if (global::haxe.lang.Runtime.refEq(c, typeof(string))) {
			global::Sys.println("s");
		}
		else if (global::haxe.lang.Runtime.refEq(c, typeof(global::Array<object>))) {
			global::Sys.println("a");
		}
		else {
			global::Sys.println("o");
		}

		break;
	}

	default:
	{
		break;
	}

}
```
Now (bad because `(global::System.Type) (_g.@params[0])` repeated everywhere):
```cs
global::ValueType _g = global::Type.@typeof("hello");
switch (_g.index) {
	case 6:
	{
		if (global::haxe.lang.Runtime.refEq(((global::System.Type) (_g.@params[0]) ), typeof(string))) {
			global::Sys.println("s");
		}
		else if (global::haxe.lang.Runtime.refEq(((global::System.Type) (_g.@params[0]) ), typeof(global::Array<object>))) {
			global::Sys.println("a");
		}
		else {
			global::Sys.println("o");
		}

		break;
	}

	default:
	{
		break;
	}

}
```


http://www.eecs.harvard.edu/margo/writing.html :P


Sounds good!

Antonio

On Wed, May 20, 2015 at 7:04 PM, Ali Servet Donmez
<notifications@github.com> wrote:

> Remove board description from board page
> @as-cii: let's not go there right now, alright? An overall :art: will definitely follow sooner than later on that page.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/catchup/catchup-web/commit/0647131420631ffe3a0dda290d718095c0921a99


It's looking for a specific needle (a mouse cursor in the middle of the screen) and if it's there, kill the test

Otherwise, everything is good


LGTM.


Are you sure you bisected that correctly?


Sorry about leaving this so badly implemented for such a long time, I've been really busy with school, but I have only about one more month to go!! So, I'll be working on this again by the end of June. Regards.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/c1e36f17437c8fca272291ceb2f9b48ea197bfd3


merging MonsieurNicolas/stellar-core/operationFixups = c1e36f17 into auto


MonsieurNicolas/stellar-core/operationFixups = c1e36f17 merged ok, testing candidate = 0553effc


Yeah, first git bisected to here, but then I actually first compiled second example on latest `development`, then reverted this particular commit and compiled the first example.


Dmitry, it it used in views/edit.html, line 6. When you define directive named with camel case, you should use it with "-" in name.
tdDescription -> td-description


Ooops, correct! If we get there there we don't know the simulation context at all.


s


yea


Shouldn't it be "Enable" instead of "Enables" by the way?


asdfasdfasdf


var hitMap = ...


----- Original Message -----
> So if a request fails on a 404, then the Client would looks to see if it was
> originally created with an explicit version.  If so, it fails.  If not, the
> Client will attempt to negotiate the api version and reattempt the call?
>
> That flow can't work because of the object serialization required.  So it
> would be the responsibility of every caller to negotiate on failures?

Clients aren't responsible for negotiating, higher level code like osc login or the api server is.  So Negotiate should not be in the Config or Client paths, but layered once you get a client.  The happy path is that everything provided works.  If you want to opt into the expensive non-happy path (make one additional API call to the server to verify the endpoint is alive), you should do so consciously, not incur it in every place anywhere the client is used.

Example:

1. osc login # selects v1beta3
2. osc get pods # should not have to check whether v1beta3 is valid
#  ... much later, v1beta3 is dropped from the server
3. osc get pods # ERROR: Not found, are you sure you are running the latest?
4. osc login # renegotiates

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/deads2k/origin/commit/33784317c5726a2c36f64faa7670191c0927a109#commitcomment-11289422


According to [2015 Technical Requirements](https://sites.google.com/a/google.com/youtube-leanback-partners/specifications/2015-technical-requirements) :

```
5.7.1 The target device MUST properly implement Encrypted Media Extensions Working Draft version 16 August 2012 or newer, including support for the following key system:
org.w3.clearkey
and including support for at least one of the following key systems:
com.widevine.alpha
com.youtube.playready
```

So for targets supporting only playready, this test will fail on call to `canPlayType` and will not return the expected invalid key error.
The test should defaut to clearkey since its support is mandatory.


> The previous one were more magic. :) Here the if form would be longer as I'd have to write

What is the diff in byte-size?

> A test for what?

For exactly this issue, tests are failed but without concrete problem, this was logic issue, but it could have been an env problem, if we would have a test which tests only first issue we immediately would know what has failed.


it was a quick skeleton stub, @sterlingbaldwin will fix it up nicely.


    [core]
    	engine = pg
        project = flipr
    [project "flipr"]
    	path = /home/user/sqitch/flipr
    [project "widgets"]
    	path = /home/user/sqitch/widgets


Thanks for the feedback and encouragement, Nate.  I would have loved to had
more time to complete the rest of the backend functionality, but we got
notice at the beginning of this month that we had three weeks to move out
of our rental home of the past five years so the owners can list it for
sale.  It's been pretty crazy since.

I just pushed the corrected CSS for the cart page to git.  See you later on
today and, again, thanks for everything.

On Tue, May 19, 2015 at 11:03 PM, Nathan White <notifications@github.com>
wrote:

> I'm a fan of this code [image: :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WebDevBootcamp/hatsallfolks/commit/02c1fb9654552635fef43a2248b314abf96901cf#commitcomment-11276493>
> .
>

--

Brad Ayers
303-588-6397 cell
Brad@AyersKin.com


Ah, yes - you're so right! Good spotting! Thanks!

2015-05-20 13:32 GMT+02:00 Ivan Grokhotkov <notifications@github.com>:

> Should it be & SPIFFS_CACHE_FLAG_WRTHRU instead?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pellepl/spiffs/commit/0221229b80c286e95200ab6d7472fe2a1771540d#commitcomment-11281469>
> .
>


That sounds like argument for always including it inside of a kubeconfig file and then having an "upgrade api-version" option on kubectl config.  How do you feel about that?


Мне понравилась идея разграничить само хранение данных и изменения с ними. Так xml с сообщениями будет расти только при добавлении новых сообщений, а хранение id тех, кто изменялся, менее затратно.


This should be strlcpy(), which is sane...


See `Spawner`'s definition: `class Spawner < Group` ... this is already going on. The failure only happens if a shutdown is not defined by the type of `Group` subclass.


It should be handled in the .success or .error of the get method.


I think we're just using `result` as the object var elsewhere.


Да, 304 Not Modified я уже просто не делала.


Why ignore case?


@bhouston @mrdoob

And if we add them back to `Basic`, we should add them back to `Lambert`, correct?

> But I guess they should be specified together, either both or neither.

Also, if we add them back to `Basic`, where `ambientLight`is _hardwired_, we need ambient light hardwired to `0xffffff` for `AOmap`s, but hardwired to `0x000000` for lightmaps.

This is a mess.


Mmk; I posted an updated version in the PR [here](https://github.com/ACME-OUI/acme-web-fe/issues/56#issuecomment-103971035)


Seems that each of these tests could be more succinct:

```
Assert.Equal(
    @"D:\Alpha\Beta\Gamma\Doc.txt",
    FilePathUtilities.GetRelativePath(@"C:\Alpha\Beta\Gamma", @"D:\Alpha\Beta\Gamma\Doc.txt"));
```


@glevand hrm, the guidance we received from ARM engineers on this was to use the machine name (i.e. `uname -m`) which should always be aarch64


Any reason why ``SGD`` is imported by default in the master init list ?


Is it right time to uncomment it? :)


这个没写用例


`into` doesn't appear to be documented.


i do not know the lake crawlers middle name LOL


Worth making this an `} else if {` while you're at it.


This caused a build failure with GHC 7.8; until we decide to switch over completely to 7.10, could you add CPP to conditionally import `Control.Applicative`?


You were not missing something, I was ;)

I made that discovery earlier and pushed an update: https://github.com/rwaldron/johnny-five/commit/5a0a4ef6204b5b54965597ca74265099f8fc883c#diff-9b5ca4ffbc69f86a37637c0fad57247c


replacement f(hanning)


Let's also kill the `k.length` here:
`int end = int.parse(k.substring(splitPos + 1));`


> What is the diff in byte-size?

+1 byte. :-)

> For exactly this issue, tests are failed but without concrete problem

We already have a test - we send the PATCH request in IE8 & check if it worked; it won't work with the native XHR. This test didn't run because the POST one hung the whole suite so it didn't have a chance to reach it. But the test is there.


To run you need to upload the data in "GIA data"


Nevermind, I forgot the context.


Se salía de rango.


We're having this problem as well.


This looks like a weird API. Wouldn't some sort of getError or getStatus exported API be more typical.


While you're here, can you add a comment above the map:
// Map of source file to map of line to hit count for that line.


Not really - I don't want to oversolve the problem prior to us having a clear story for how people register and manage API endpoints with Kube.  I'd much prefer to do the limited thing in osc login and expand later.

----- Original Message -----
> That sounds like argument for always including it inside of a kubeconfig file
> and then having an "upgrade api-version" option on kubectl config.  How do
> you feel about that?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/deads2k/origin/commit/33784317c5726a2c36f64faa7670191c0927a109#commitcomment-11289569


What do you think about `sourceHitMap` here and `globalHitMap` to replace `hits`?


Negotiating in osc login doesn't help unless we persist the discovered api-version into the kubeconfig file.  Otherwise `osc login` followed by `osc get pods` will fail on a 404.


Is not S_IRWXU enough for giving root access?


This should be `"\n\\\\\n"`.


You can ask the game to flip the Y-axis for you.
See my comment to Miblo - https://forums.handmadehero.org/index.php/forum?view=topic&catid=4&id=563#3499


@scottschurr It mirrors `ripple::verify`. They should both have the same name.


That's what I was implying - persisting the preferred api version in kubeconfig.  A single server can point to both openshift and kube, or could point to openshift OR kube.  API version though is reasonably tied to a server.

----- Original Message -----
> Negotiating in osc login doesn't help unless we persist the discovered
> api-version into the kubeconfig file.  Otherwise `osc login` followed by
> `osc get pods` will fail on a 404.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/deads2k/origin/commit/33784317c5726a2c36f64faa7670191c0927a109#commitcomment-11289783


*let's* in this context is a contraction for "let us": let us be paranoid.

https://www.englishforums.com/English/LetsVsLets/gnbh/post.htm


Should be ``self.dataset``


No mostraba el último objeto.


Yo should error if multiple resources are selected.


@oveddan - check it out here: https://github.com/dorny/jsdom-little

You're right, I could have done this as a fork. The history would have been a bit tough to follow as I really gutted the entire thing and replaced all dependencies with libraries that would work on JavaScriptCore


oh, it may not even be used, should check that. If  it is not used I would prefer to remove it.


add_warnings (lefticus) - x86_64-MacOS-10.9-clang: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


'the second (one)' is a bit irritating but okay.


to clone the raspbian to SD card
`diskutil unmountDisk /dev/disk2\`
`sudo dd bs=1m if=2015-05-05-raspbian-wheezy.img of=/dev/disk2`

to go to desktop GUI
`startx`

to shutdown\
`sudo shutdown -h now`


nit: can you make the 6-node layout look more like a circle? (move the L one to the left, and its partner one to the right)


Why does a UDP port block the service?  Which ports is the router going to use?  If the service has both TCP and UDP ports I don't see why you wouldn't be able to create a route?


ah, it is used, by Test::Stream::Event, so it should be documented.


Is this inspection can be found in IDE without explicit call to "Code cleanup..." action?

There also should be a description file to avoid "Can't find inspection description" message in settings.


add read.me


grappiller, c'est récupérer les restes de raisin sur les vignes, ou chercher des petits avantages plus ou moins licites. Ça ne correspond pas vraiment à l'idée de "sélectionner" individuellement des commits.

J'ai un problème avec sélectionner qui est trop général. Cherry-pick est déjà traduit en picorage dans d'autres domaines, au côté de cueillette.


That is true - but it would be nice to see the gutting/changes as a single commit to see what changed from jscore-jslittle. It would also allow this to be more easily updated with changes from that lib.


test


done


Update to reflect current folder structure.


sure


Why split the array on all examples? `Dataset.__len__` is set to return the number of examples.


-actually that was a typo I meant  market


Idk why that keeps happening. Fixing it again.


Either way, thanks for your work on this, I've found it useful in my project.


Make it an `} else {` with a type assert – since we don't expect anything else


roomX -> roomNumberX, for translators (assuming X is always a number)


Ввод-вывод можно сокращать до io, помня, что есть такая стандартная библиотека


This whole block should go under the `strongSelf` check below – especially because you’re reaching into `_eventQueue`, which may be unsafe if `self` goes away – and this line should call the instance method `[self flush]` instead of the class method, because we’re already in an instance method.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/63364985


The canonical loss function would receive a batch number, not the inputs.


Maybe it's better to use a set and implement isCleanup() with 'in' operator. Just to avoid repeated "this == " part :)


what's this for a syntax? have never seen it :O


Looks like you misspelled "canola"!


nit: should probably be called `previousForceState`


Maybe not here, probably we can describe what each condition means.


90210372-ChillerElectricEIR-still-delivering-chilled-water-#4453 (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1650 of 1651 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


> +1 byte. :-)

It is longer then, could we sacrifice it for the readability?

> We already have a test - we send the PATCH request in IE8 & check if it worked; it won't work with the native XHR. This test didn't run because the POST one hung the whole suite so it didn't have a chance to reach it. But the test is there.

Yes, i got the idea, this was logic issue not the env one, but we could have added test for the logic too, so if logic test fails then we know exactly what is wrong, whereas with the env test we need to investigate


fast-forwarding master to auto = 0553effc


jj


Is this a valid functioning key pair? If so, I suggest altering it in some way to invalidate it (as simple as removing a single character from the middle of each. It's silly, but I can envision a ...competency-challenged administrator blindly copying and pasting this into a config file, and causing all kinds of headaches. Not likely, but removing a couple of characters is so trivially easy, why not?


arb rendering also didn’t work anymore


thanks for pointing out.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Same suggestion as above: Is this a valid functioning key pair? If so, I suggest altering it in some way to invalidate it (as simple as removing a single character from the middle of each. It's silly, but I can envision a ...competency-challenged administrator blindly copying and pasting this into a config file, and causing all kinds of headaches. Not likely, but removing a couple of characters is so trivially easy, why not?


I would prefer a strict list of fixes choosen for clean up. I'm afraid that we can break the cleanup action by accident by adding some new fixes for approved errors.


@jonboulle Well,I get x86_64 for `uname -m` on my PC, but it seems the spec says amd64.


Ah, I see. Sorry.


If pipes on Windows were similar to pipes on UNIX, I would agree with this,
but I don't think this is the case.
Anyone building a real application on Windows won't want to make it a DOS
application, they'll want to make it a Windows application, and I think the
pipes supported in Windows proper are quite different from UNIX pipes.. it
supports named pipes, and I think the mechanism of use is different from
standard UNIX pipes.  My feeling is that the way they are invoked is
sufficiently different from how pipes work on UNIX that there is no point
trying to share the code.
Of course if there are minor fixes or #ifdefs to existing code it's fine,
but I'd rather not make it more than that.
Dan

On Wed, May 20, 2015 at 3:51 AM, jtrmal <notifications@github.com> wrote:

> That might not be completely true -- pipes might be used even during
> decoding (for example as audio sources). Also, pipe functionality is an
> official part of the Kaldi I/O, so we should strive for having it working
> under windows as well
> y.
>
>
> On Tue, May 19, 2015 at 11:22 PM, Kirill Katsnelson <
> notifications@github.com> wrote:
>
> > Good point, I will add a test to see if running under bash. However, the
> > point becomes rather moot in this case, since pipes are not going to be
> > even used in native Windows library decoder.
> >
> > The path tinkering is harmless. Windows paths are transparently
> supported.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-11271654
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-11277933>
> .
>


It does not, but that is expected here. This resolver is only used to resolve references to `project.json`-based projects. In those projects, it is by-design that the immediate parent directory of `project.json` is the unique identifier for the project.

In the case of referencing MSBuild projects, that would come through the 'External Project' resolver which does consider full paths.


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Where is this initialization being done now?

# RailsAdmin::Config::Fields.register_factory do |parent, properties, fields|
#   if properties[:name] == :translations
#     fields << RailsAdmin::Config::Fields::Types::GlobalizeTabs.new(parent, properties[:name], properties)
#     true
#   else
#     false
#   end
# end


As this is an all-up fixup, can you please update the code coverage shield to this image:
https://img.shields.io/badge/wcf-code_coverage-blue.svg
![https://img.shields.io/badge/wcf-code_coverage-blue.svg](https://img.shields.io/badge/wcf-code_coverage-blue.svg)

We will use a similar badge in corefx too until Coveralls meets our needs and reports data correctly.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes! Thank you, this was the error.


maybe log.warn?


Where is this initialization being done now?


What is `gradients`? It looks like it is an array : array dict ?


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7323/testReport/) for this commit**


Hello world


log.error?


@ximinez Great catch! And absolutely agree.


if we want the user to know what each condition means we'd have to do that here. However this parameter is intended to be optional if I figure out the best settings.


`param` -> `gparam`?


```
else
  // explicitly empty `to`
```


so right now clone detection is rather a developer playground but if it grows mature there is no need to consult the user for such a weird thing like counting conditions


The !important tag was necessary to override the CSS coming from WP core.


there is an extra space here


log.error is better?

On Wed, May 20, 2015 at 2:10 PM, Jon Hall <notifications@github.com> wrote:

> log.error?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opennetworkinglab/ONLabTest/commit/f0594d7d19abff807ede9513cd5f11780f4d4555#commitcomment-11290163>
> .
>


If you enable AssertResultHandler and use assertResultFailed you should be able to make assertions based on the status code. Or you can look at the error result directly.  A valid result will always return a 200.


I see what you're doing, but the comment is confusing -- maybe, "send to the first recipient, and then recurse on the remaining recipients on success"


What do you mean by PR it?


Thanks!


log.debug?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1142 of 1142 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We should talk about linking the server to the list of servers. It might make more sense to link to the server page for the server that was clicked on.


Accepted


it work now?


ah yes, very important addition


That makes sense now that you pointed it out. I assumed that it should have been final because it is a capitalized variable with an underscore.


CLIs[ i ] ?


Cool. I see there is already a test on an array of arrays (forgot about that). I'll still test IK chains as a collection of servos tonight, but we should be good. Volunteering myself to update the wiki and egs for servo and motor.


You can also get rid of the ```firstCall = false;``` which is later in this block of code. The reason is the value will be set to false by  the first successful ```compare_exchange_strong``` call.


Great refactor into an until block!


log.error?


Nathan, yes this is Awesome! I really appreciated the notes, so I could follow along!


It's just a temporary thing. In order for the build process to work, @pranavkm wanted a simple self-contained way to distribute the new NuGet Command line to the CI and dev machines. This is not something that will ever be published. I suggested `dnu commands` but that requires DNX, which is not currently required by NuGet.PackageManagement. Instead, this is a `dnu publish --runtime ... --no-source` output bundled up in a NuPkg to allow it to be `nuget install`ed


```bash
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10862    1.374    0.000   48.908    0.005 pyhacrf.py:124(predict_proba)
    10862    0.339    0.000   37.073    0.003 pyhacrf.py:326(__init__)
    10862   26.558    0.002   36.734    0.003 pyhacrf.py:385(_build_lattice)
    10861    0.066    0.000   10.323    0.001 pyhacrf.py:356(predict)
    10861    0.199    0.000    9.780    0.001 pyhacrf.py:362(_forward_probabilities)
    10861    0.012    0.000    9.575    0.001 pyhacrf.py:376(_forward)
    10861    9.563    0.001    9.563    0.001 {pyhacrf.algorithms.forward}
    10862    0.008    0.000    6.339    0.001 pyhacrf.py:275(fit_transform)
    10862    0.013    0.000    6.332    0.001 pyhacrf.py:291(transform)
    10862    4.772    0.000    6.318    0.001 pyhacrf.py:307(_extract_features)
    10968    4.964    0.000    4.964    0.000 {method 'sort' of 'list' objects}
 31886136    1.978    0.000    1.978    0.000 {method 'append' of 'list' objects}
 15887472    1.865    0.000    1.865    0.000 {method 'add' of 'set' objects}
13909833/13909373    0.876    0.000    0.876    0.000 {len}
  2127461    0.610    0.000    0.763    0.000 pyhacrf.py:265(<lambda>)
  2127461    0.423    0.000    0.423    0.000 pyhacrf.py:264(<lambda>)
```


We have to replace this writer not the other one?!


Line 17 checks to see if MAGIC_NUMBER is greater than 18, if so, the while loop executes until MAGIC_NUMBER is less than 0.


wieso isch das wieder entfernt worde???


Upsss, sorry StreamRecordWriter extends QosReportingRecordWriter. Everthing nice :)


wieso isch das wieder uf false gsetzt worde???


This is breaking the build. Fix comming


You're right. I can make that change.


`ssl_server_ctx` should be `ssl_client_ctx` here.


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


move the print statement into the if and use the logger?

Also, I think you want 'if intentsRemaining:'


Little qiuqiu, you are so cool.


今天过得还不错吧


@anatb please review


You're pulling out `opt_sig`, and checking it for null, but not doing anything else with it here.


When I used the `AssertResultHandler`, it prevented the messages from actually being logged by the SLF4J/Log4J mechanisms. Since logging to a named appender is part of the `ApiCoverageHandler` that needs to be tested, I moved from using `assertResultFailed` to comparing `ErrorResult.code` in the test.


double license?


Yeah, you're right - I was tossing up between making this drop-in by setting it to isomorphic (node&browser) or leaving it empty and having the project set it. I'm happy to go with the latter.

That's great that you can extend configs! That didn't use to be the case. Do you think we have:

```
.eslintrc-common <- common rules
.eslintrc <- extends common, basically empty, used in js projects
.eslintrc-[meteor|react|etc...] <- extends common for the specific environment
```

In terms of workflow, if you were working on a pure js project, you'd have to drop in `.eslintrc-common` and `.eslintrc`. If you were working on a Meteor project, you'd drop in `.eslintrc-common` and `.eslintrc-meteor` renamed to `.eslintrc`.

Is that how you see it playing out?


wieso CMD weg??


If `projectionMatrix` is big this could get *very* slow. Have you tested under realistically-sized conditions?


Good point. Refactoring would make it look prettier than it is.


/test2.css:44:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
/test2.css:45:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
/test2.css:46:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)
/test2.css:53:5: CSS outline not supported by: Opera Mini (5.0-8.0)


A stream vertex without constraints does not have a qos coordinator!


I am not sure I agree with this completely. I am not sure how this helps!


Let's convert it.

>


Thank you and I will.


@jregehr if you can use snapshots, it's available now.


The log level should reflect the severity of what is being logged. In this instance, you are saying that one of your checks is failing, which I think should be at least level WARN or ERROR in my opinion, WARN if it means something may be wrong and ERROR if something is definitely wrong. In my opinion, INFO should be for describing what is happening in the test and DEBUG should be used for dumping raw values or for temporary logging while testing code.

This all just helps when we need to go back through the logs.


What if I want other gradients?
Should be separate methods.


Nice use of this `animate.css` file.


Está correcto


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Cnxarchive and accounts profile are pointing to the virtual machine. Those changes should not be checked in.


I think *The Windows Communication Foundation Story* is a great addition to the README, and clarifies a lot.of the differences between this set of WCF Client Libraries and the full framework-based WCF.

Maybe it's worth pointing out that "WCF services should continue to be developed in the full .NET Framework" to avoid any doubt?

NIT: There are some weird double spaces in the markdown - don't think it'll render any differently, just bugs me a little :grin:


This change caused the splashscreen to not fade at all.  I reverted back to the previous code and it worked fine.


@kartikthapar previously, if you did not implement any of the `ATLAvatarItem` protocol items xcode would not give you any warnings.  For any conversation with > 2 participants, `shouldDisplayAvatarItem` is set to `YES`.  We then check each of the 3 protocol properties, which crashes the app if they aren't implemented.  This way, the developer will get a warning before compiling their app.


I'd suggest "Test Results" rather than "Test Run Page" for the button here.


is this library standard or did you have to specifically install it? If you did, can you add it to the README file


I guess bugs are always a possibility :)

Care to guide me through an example of how that can happen?


Can you use the `{{#link-to}}` helper here?


Closed #1371


Yes, it would be coded into the exception handler


this tag may conflict with a tag that already exists here: https://github.com/dimagi/commcarehq-ansible/commit/9c244a2a24b660224313b930455bdb6785a6fc4c
don't know how ansible handles that


Define previous code? Version and/or sha hash


This is working but I don't know about `BasicController.prototype.getState` which still might need some attention for the thumbs up/down and favorite.


I think not necessary to define these up here (I think it would have worked the way they were before), but no need to change.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Great idea adding a docstring. Might want to also document the `hasAdvancedEditor` option. Something like
```
hasAdvancedEditor - enable advanced data source editor if true
```


Very cool font choice! Way to get out there and grab some nice assets.


NVM, I realized this is from rebasing with Ping Ping's changes and it does seem to be standard


cleaning the splits is not done to improve locality. I comes from this issue:
https://issues.apache.org/jira/browse/MAPREDUCE-5186


You're right, description should be refreshed, but refreshing for assignee is not necessary to my mind.


@kmahal True. I realize that. I also think it's a minor change but this is something that should not be too stressed. Developers using custom views might not even use any of these APIs so returning nil in all of these is jus t weird (is all I am saying). I am not sure what the right way though is.


Fixed #1372


I have not see this one before, @CameronFranke  or @andrewonlab perhaps?


THANK YOU! I'm always shocked people don't change this more.


cool to know


Why not keep only a scalar? Building a vector is unnecessarily costly.


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (348 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Oh okay


It did work, but it just felt wrong. Although this does as well.


@michaelcahill, I wanted to call out this code to see if there was anything nicer that can be done, and whether this code is even safe?  The cursor has its own local copy of the value, correct?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Me too.


unneeded


Maybe another name fits better, like `shall_exclude_function`. Imo `exclude_function` performs its task, so it directly excludes the function from analysis and doesn't only indicate it^^


Hi tjdecke, sorry for making a comment here, but I don't know how else to contact you. I really like your Day/Hour heatmap at http://bl.ocks.org/tjdecke/5558084 - what is the license?


hmm, possibly worth just removing the tags I added then. I don't think its
really necessary to split the postgresql and pgbouncer tasks


Good idea. Maybe I will realize this.


Thanks, I just realized I missed this


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/515ee711ce7d210bdee5aec608bf0d9d657e3b46/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/515ee711ce7d210bdee5aec608bf0d9d657e3b46/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/515ee711ce7d210bdee5aec608bf0d9d657e3b46/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/515ee711ce7d210bdee5aec608bf0d9d657e3b46/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/515ee711ce7d210bdee5aec608bf0d9d657e3b46/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


I remember I added this code originally for RHEL5 systems with 2.6.18 kernels.  Since RHEL5 is still support by RedHat and you _can_ install a 2.6.32 kernel on it I suppose we should keep it.  It's probably a stretch to think there are many systems out there like this, but it's possible.


How is it the "FirstSelectedRow" if you can access any index?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


        private int GetFirstSelectedRowIndex()
        {
            return MethodParametersGrid.SelectedRows[0].Index;
        }


so you know a better name? `shall_exclude_function` feels bad :(


Universal truth (that we all violate): if you find yourself writing "also add..." in a commit message it should probably be two commits. ;)
We don't need perfect atomic commits here, but we **should** move these converters to [imagej-common](https://github.com/imagej/imagej-common) since there is nothing ops-centric to them.


What do you mean @ostinru?


@mrdoob

> Where they combine a tiled texture and on top of that they apply static illumination with AOmap with the second uv set.

Static illumination with a 2nd UV set is consistent with a lightmap, not an AOmap.

I wonder which one we are talking about, here?...


You shouldn't be creating the object here, it should be created in the build() method.
For the events, rather than a bus I would recommend using the same kind of handler as onGestureTap -- see e.g. input.dart's onChange, or MenuItem's onGestureTap logic.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Something here doesn't work. If I click on the plus sign nothing changes, then if I click on the minus sign the value increments by 1


This commit broke compilation with GHC 7.8.4:
`
src/HERMIT/Monad.hs:97:5:
    Could not deduce (Applicative m) arising from a use of ‘when’
`

I'm assuming this is an upstream issues with transformers-compat.


@ximinez It's checking that all string contains everything we expect in a manifest. Even though we don't pass `opt_sig` to the constructor, we still want to verify it's there (the string *is* passed to the constructor so we can verify the signature).


Also, please avoid using tabs. Use spaces instead - it's just the standard in this project :)


call this.qosCoordinator.prepareQosReporting(inputHandler, outputHandler) here and setup the listener.


Good use of domain classes.


to commit to ekane o giorgos gt etsi gousterne


I agree. Actually there could be an entire "converter" package in IJ-commons. I'm working on more right at the moment. Should I file a PR in imagej-common then, which will be merged first, then you release and then I can use them here and merge this commit?

Does imagej-common allow code-generation? I will maybe make use of this ops-feature.


Another standards issue - always surround blocks with { curly braces }, even if it's just one line


Needs at least some form of documentation what this is needed for. I had to search through the whole PR to find where it's used.


Good use of packages.


lol


@palichis mal el dominio


It's interesting to me that we're adding the `masterKey` to `map_` with a `boost::none` for the associated manifest.  It would be nice if the comment explained why adding the key is separated from adding the manifest itself.


this is a little confusing, can you change the name to `MyDecMixin` or something like that?


As of 2d4cc9374165d4f503244ab703c997811f264ffe, there's no longer an exception on these, though we don't emit coverage for them in the formatter.

I'd definitely prefer we don't maintain a list of fixes for URIs returned by the SDK here.


![image](https://cloud.githubusercontent.com/assets/1615761/7733502/480cb4fa-fee4-11e4-96df-0ac7089ab97c.png)
Why not both?

I've taken your suggestion for updating the inline comment, and corrected a spelling error in the function-level comment.


sorry I deleted your requirements.txt,, I will put it back in next commit


Looks great! (minor: use tabs instead of spaces as mentioned in the other commit)

I wonder, why did you use an object called `data` instead of just having a scope-level variable called `visible` (or `isVisible`)


Can you give an example? For example with LoginRequiredMixin and some other mixin.


May want to place this with the other test class.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15206/testReport/) for this commit**


I would prefer not have double negations.
Like
```
def install(self, prefix, update_mimedb=True):
```
then
```
+        if update_mimedb:
+            self.config.bundle.install_mime_type(self.config.source_dir)
```
or at least
```
+        if not disable_update_mimedb:
+            self.config.bundle.install_mime_type(self.config.source_dir)
```


You can name this `public class User`.


Hey, this read good, thanks. :-) Let me create a PR and we can discuss it further more.


remove "other" -- technically a fake wire is not an entity, right?


I am not sure, but I expect

b.$splice || **o**.$splice


I think running with `--tags=postgres` will run all of the steps (including pgbouncer) because tags get applied to all tasks within a role, good catch Ben.


`public class TestLogin`. Also should be in the test package.


what


Can't have a list of parameters? Should let zip iterate naturally on the sequence.


Perhaps we could have a list of all the decorator mixins available.


Pour "sélectionner" ok, c'est vrai qu'il manque quelque chose, on sélectionne un commit mais on ne sait pas trop ce qu'on va en faire.

Sur [cette page](http://www.linternaute.com/dictionnaire/fr/definition/grappiller/), le premier sens proposé pour grapiller n'est pas celui que tu décris, mais "cueillir ici et là", c'est ce qui m'a conforté dans cet idée et m'a poussé à proposer ça, d'autant plus que je n'avais jamais rencontré "picorage" dans la nature auparavant (mais en cherchant sur le net je tombe sur picorer des cerises, alors…).

Sur [linguee](http://www.linguee.fr/francais-anglais/search?source=auto&query=cherry+pick) on ne trouve ni l'un ni l'autre, ce qui montre bien le problème : il n'y a pas vraiment de traduction en un seul mot pour ça, le mot qui se rapproche le plus du sens selon moi n'est pas un verbe : je veux parler du mot "sélectif", et on ne peut pas vraiment traduire "cherry-pick" par quelque chose de long comme "faire-une-fusion-sélective".

Je comprendrai si tu ne souhaites pas passer de quelque chose de pas terrible à quelque chose de pas tellement mieux non plus, mais au moins, le débat est lancé et peut-être, qui sait, quelqu'un passant par là aura-t-il un jour une meilleure idée ?


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (348 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Seriously, Acmlmboard 1.A3? AB1.92.08 is much more secure than AB1.A3. At least, put a warning in a README. :P


I created 4 lists to centralize definitions of profiles and actions so that we don't have to edit various places when adding actions or profile types.


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/3738/console to remedy the problem.


> Should I file a PR in imagej-common then, which will be merged first, then you release

yes please!

>Does imagej-common allow code-generation? I will maybe make use of this ops-feature.

@ctrueden would know; it looks like "not right now," but if we can generalize the auto-generation and move it upstream that seems like a win to me.


state is already checked for != nil, so we can remove this loop


Woudn`t it be better to place the "star" behind the question title?


Good


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1150 of 1150 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


PR means pull request. Creating a pull request is the way you can contribute your changes back to the source repository https://help.github.com/articles/creating-a-pull-request/


Sure, but it shouldn't throw ;-) If it's not necessary anymore, just close it. I was curious this package works, this is the reason I tried to fix this issue I run into and published it because I thought it might be useful for others as well.
Currently the package seems to have other problems anyway, I assume completely out of your control. AFAIK it can't be used with the new `test` package yet :-(


Why not just take a `User` object reference as a parameter? Also, you may want to have a look at some [ORMs](http://hibernate.org/orm/what-is-an-orm/).


Note that this also add a key "arch", I think it was missing but I might be mistaken.


Could you please elaborate on what kind of structure you would expect a multi-page app to have?

Detailed questions behind this:

- If we were to create all page objects inside the app build, that would imply a lookup table that maps some sort of literal (like a URL?) to the page object which you lookup in app build(). Is that what you recommend for now?
- I found the shared bus necessary here since stock row is not visible at app level (hidden in stock list). How do you propose to expose a onTap() logic and have the app change its state? IOW, what's the path from StockRow to StockApp?


This commit.  I replaced the latest version of code in my CDVSplashScreen.m file - it was up-to-date and contained the changes you made in this commit - with the previous version of this section of code. After a lot of forum searches, I haven't encountered anyone else experiencing the same issue as me - but thought letting you know replacing this commit with the previous code solved my problem might be beneficial.  The application is deploying for iOS 7.1 < and my test device is an iPad 3.


@jrosadohp  Do a search on the `README.md` file to ensure that these changes are changed in the entire document.


> Does imagej-common allow code-generation? I will maybe make use of this ops-feature.

Not yet. But I was considering generalizing the imagej-ops template logic to pom-scijava, so that all SciJava-based projects could use it. What do you think? Do you need it now?


not:
*"[...] object with variable names as key and content as value"*?


That should be either in `Optimizer` or in the `Trainer`.


Ok. I will avoid code generation for now and write all the converters in the imagej-common world. also the RAI2II etc? So: All Converters?


@jrosadohp same as above.


@palichis error en dominio


Should externalize strings here (look them up in res/strings.xml).


Same thing here : move it out of SGD.


@dietzc Certainly all image-based converters—e.g., ones that use ImgLib2 data structures. Ones that are not image-specific could live in scijava-common itself.


Externalize string here.


Ah, thanks :)


Just noticed I forgot the "mix-in" key, I will replace this line by the following in the next commit:

```python
if action not in valid_actions + [ "mix-in" ]:
```


no need to log here since agent i believe will print out which action it runs before running it.


I belive it's important to assert something about the content of the `InvalidOperationException` so we know it's the right exception (it might theoretically have been thrown anywhere in the code being tested and not necessarily within Pomona) and that it contains something a human can make sense of (i.e. is intuitive and helps debugging)?


Ah, yes I see it now :). There is indeed a problem here.


Same thing here, move it out of SGD.


Should remove comments prior to submission.


doh! I forgot the `-y`. damn


looks like you made it!


uhm, need to rewrite that comment... confusing


A felhasználó csak a saját history-kat láthatja. A system események nem szerkeszthetőek.


typically we use 'var _ =' e.g. https://github.com/cloudfoundry/bosh-agent/blob/master/agent/action/fetch_logs_test.go#L16


Removed this comment as I think it was just a forgotten temporary comment.


This is good but I think adding another library to do basic jQuery stuff won't give us enough control. Its probably time to start adding JavaScript instead, what are your thoughts on aacd3c8eb22a8774af5def02d8bd0f4a4d11349f ?


I would think that things like `Post` and `User` would be in a model package, whereas things like `PostActivity` would be in a control package, though, activities do have UI associated with them.


lower case 'when'


Thanks for the inspiration. I'd been wondering if hooking up travis was worthwhile. It seems it is.

We don't need sudo access; 'make distcheck' will configure and install into a local subpath.

I pushed a minimal script. See https://travis-ci.org/xiph/ogg/


@jrosadohp For changes from L85-87 Do a search on the `README.md` file to ensure that these changes are changed in the entire document.


can you logTag e.g. https://github.com/cloudfoundry/bosh-agent/blob/master/platform/udevdevice/concrete_udev_device.go#L22


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


New-Features-8-3 (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


You'd need to compose or concatenate the updates, not switch them entirely.


Fixes: [seccomp] Fixed building and running i386


this is time.Second


This is still a problem when folderTimePattern has non-time pattern elements. Either this substitution needs to be more careful, or we need to make it very clear that this compactor will fail with certain directory patterns.


I get the following error when trying to run this test within IntelliJ:

java.lang.RuntimeException: Could not create new instance of class org.jboss.arquillian.test.impl.EventTestRunnerAdaptor
Caused by: java.lang.reflect.InvocationTargetException
Caused by: org.jboss.arquillian.container.impl.ContainerCreationException: Could not create Container default
Caused by: java.lang.IllegalArgumentException: DeployableContainer must be specified


Why thuogh


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


mangler "use" i "that do not use StatePrinter"


Would have liked to see more strings here.


Could be. Good catch.


You probably put the ApiCoverageHandler before the assert handler.


Good point,  what does happen now?


>> +1 byte. :-)
>
> It is longer then, could we sacrifice it for the readability?

It's more readable now than it was the expression is contained in the last check but I don't have a definite opinion here.

> we could have added test for the logic too

What exactly would you want to test? If a specific condition triggers the ActiveX XHR in IE8 and others the native one? This seems wrong as we'd be testing our implementation and not the end result. One day we may decide that we want to change the logic while preserving the tests and then we'd have to modify the logic test.

In any way, if I saw that PATCH is not working in IE8 then `ajax/xhr.js` would be the first place to look as the code for deciding which request type to use is there. So I don't feel that I'd gain more clarity if we had test asserting our logic for the XHR fallback chain.


The response status recorded on a client soap fault shouldn't be `500` should it?


should probably be on the Manager. otherwise they are package global.


ok


Perhaps combine quantity and score by letter, and put in a CSV or something?


system imports should be grouped with fmt.


`AlarmReceiver`


var _ =


newline above.


EOF Remove new line..don't need it.


Is there a reason you're adding the key to `map_` before checking its validity?


"historical manifest" -> "Historical manifests" ?
"forward" -> "forwarded" ?


indent.


Should remove these prior to submission.


Should externalize string here in res/values/strings.xml.


combine into a single var ( ... )


Please remove comments like these prior to submission.


Compose or concatenate : don't destroy.


checking for exitStatus is not necessary since err will be returned above: https://github.com/cloudfoundry/bosh-utils/blob/master/system/exec_cmd_runner_test.go#L201-L202


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


What about https://github.com/whitequark/parser?


Oh, and thanks for the explanation.  It helps.


Better parameter names here.


ack


Nope, I had to add:
![image](https://cloud.githubusercontent.com/assets/13041/7733890/15f07f94-fee7-11e4-9abb-af8660b041a4.png)


I like that idea, but instead of making it for them, I might just add a note or hint in the reqs that having a way to easily maintain/update external data would be helpful.


For me it is compiling fine now but mapserver is crashing.


ack ...


Thank you! This commit fixed the build. It was broken since http://ci.cgeo.org/job/c-geo/3738/


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


should use WrapError(err, "... some high level description ...")


Destructive update.


Isn't it in our code rules to have spaces between a binary operator?


use logger.Debug: https://github.com/cloudfoundry/bosh-utils/blob/master/logger/logger.go#L67. DebugWithDetails is useful for printing out chunky output.


also logger.Debug


Loads of destructive updates. Unless each updates are on different parameters, they'll destroy each other.


@tchx84, I am talking about the parameter in the install method, not the command line parameter.

You can move the negation to
```
+    install_parser.add_argument(
+        "--disable-update-mimedb", dest="update_mimedb",
+        action="store_false", default=False,
+        help="Do not run update-mime-database")
```
If you don't like it, we have the second option I proposed in the previous command.


Agreed. However, this has since been rewritten in Scala, so I'll either make a separate PR for that, or do it in the last PR that touches this file (up to you).


add_warnings (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


uhm largely... :P e.g. you can do `x*x + x/x` so thats a bit difficult... but you're right, I should reformat this one


Really an idea: for this statement we could echo before *Platform* so the log reader directly knows what this value means...


ideally we would use fs here so that we have a log of which files are deleted. i wonder if using fs.Glob would be useful here.


for x => x+1 the schedule.length == 1


It's OK, thank you.


Minor point. Please don't call it 1_electro, that's a bit confusing. Can you call it 1_electrostatics? The whole lab is electrodynamics, so just electro isn't specific and may be confused with other chapters like electron dynamics, electromagnetic induction etc.


Do it in the last PR. That way, our backlog doesn't get even bigger :)


maybe file a bug, I want this merged :P


CassandraConfs -> tableConf


oh yes true ! Forgot to do that ! Gonna update the code later, otherwise tomorrow !


This was due to me incorporating functions from `base-compat` with wild abandon—`when` from `base-compat` only requires an `Applicative` context, but it's used with functions that require a `Monad` context, which won't work on GHC 7.8.

My intention was to ensure that functions exported by `base-compat` wouldn't clash with old `base` functions on GHC 7.8, but I forgot about the whole AMP thing.

In any case, it should be fixed now.


Suggested rename to defaultProp


But windows would wrap it and there's no simple way to have a non-EOL-return echo. We just keep it as it is^^


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/2129c5318bcf1fd933726ca22ce43f78d1098d68/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/2129c5318bcf1fd933726ca22ce43f78d1098d68/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/2129c5318bcf1fd933726ca22ce43f78d1098d68/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/2129c5318bcf1fd933726ca22ce43f78d1098d68/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/2129c5318bcf1fd933726ca22ce43f78d1098d68/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


As a matter of fact it is. I posted an error on the main PR page.


ack :)


So this installs files with absolute names to `include/whereever_invoked` but relative files to `include/whereever_invoked/rel`? That seems easy to unintentionally misuse. I would rather either
+ make the target directory explicit (`smtk_public_headers(DESTINATION "smtk/model" ${headerList})`) or
+ eliminate the portion of the path that matches ${CMAKE_CURRENT_BINARY_DIR} and make  the remainder the suffix (or if nothing matches, only then make the suffix empty).

That way
```cmake
smtk_public_headers(
  model/Foo.h
  ${CMAKE_CURRENT_BINARY_DIR}/model/Bar.h
  ${CMAKE_CURRENT_BINARY_DIR}/Baz.h
```
could possibly work.


You are welcome. CI is always nice.


Hi Nicolas,

Here I am again, your most meticulous observer. :-)

Shouldn't the package actualy addFile the **updated-at.html** and **updated-at.js**? Seems to be a copy of the **created-at** stuff right now.

Regards,
J*


Since 'playerWins' and 'computerWins' are just returning numbers, you should specify in your string which score is which. Labeled scores will be easier for the user to understand. For instance...

```js
console.log('The score is currently\nPlayer Wins:' + playerWins + '\nComputer Wins: ' + computerWins + '\n');
```


Compilation should be moved out of `SGD`.


Is it possible to replace the -1 with a meaningful name of what the -1 represents?. Like private static final String NO_TX_ISOLATION_CONFIG = -1 ?


@laurent-dinh seems it is equals to 1 with single precision.


You should call these above and set them equal to the playerMove and computerMove parameters that you are passing into getWinner.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Some could argue that the batch size is universal and should be placed in `Optimizer`. This one is up for debate, though.


Oh sorry! haha


Sam send me the model, cross section and path today, is like to

Sent from my iPhone

> On May 20, 2015, at 1:02 AM, mem1b <notifications@github.com> wrote:
>
> Hello, we would like to ask you why you have removed lightmap from basic and lambert?
> I'm asking because we want add light via baking (also for existing scenes) and now it's not supported anymore for this type of mesh.
>
> —
> Reply to this email directly or view it on GitHub.
>


This is considered a Hibernate API and definitely cannot be changed in 4.x because it would break backward-compatibility for applications that provide their own implementation.


static imports


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


use it for main dataset


Very nice! I like the changes from using assoc name to assoc entity when defining associated data!


ici : http://www.linguee.fr/anglais-francais/traduction/cherry+picking.html il y a picorage...

Traduire, c'est trahir, et encore plus pour une expression idiomatique.


I think the link to Spring issue should still be 2014-04.pdf.


This is also considered a Hibernate API and definitely cannot be changed in 4.x because it would break backward-compatibility for applications that provide their own implementation.


The learning rate is never decreased as the shared variable is never read.


I'm wondering if the comment on line 651 would be better in here.  I think it explains why we call `applyManifest` and collect its `result` before we do the `history` check and `continue` from inside that check.  Just wondering, not insisting.


Can you replace -10 with a meaningful constant?


You should declare these variables inside your playToFive function. See note below.


ack, thats better indeed


reack


.isEmpty() is easier to read.


@barakmich

How about this? We actually log the per member error information at the caller side (line 129).
I added per endpoint error message.


done


The following shows how backward-compatibility would be broken by adding the method to an API.


What about unsupervised learning?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is the github version of being an ahole :+1:


@ovnicraft se corrigio el dominio, pero aplicación sentry no esta corriendo.


@rouault none of the tests in test_gdalinfo.py touch this if branch. Where can i find a sample dataset for testing this?


I didnt get the TODO part.


Does it make sense to use a guava cache?. What would happen with a Database that is not used anymore?. Will continue to be in the cache forever?


Not sure. Let me look. I'm still trying to catch up. It had been a nightmare. I can do it. I'm not giving up.

Janelle Henderson

> On May 19, 2015, at 2:42 PM, Mike Sinkula <notifications@github.com> wrote:
>
> This doesn't seem to be your latest version of your code, no?
>
> —
> Reply to this email directly or view it on GitHub.
>


Good catch.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


add one comment


Add underscores to property names.


I'm just gonna try and mess around with it. I'm new to this.
Should I leave it on your name and create a pull request later?


@ximinez I agree. I will add it to the map only after it is verified.

Quick note: These are keys we are loading from a our local database and have already been checked. They should be trustworthy and should never fail a verify (hence the `throw`). Good find.


You forgot the version number increment. But the ads are differently more important!


L'énoncé du TP ne spécifiait pas que seules les réponses «oui» et «non» étaient acceptables ? J'avais ajouter «n» et «o» hier, avant de me rendre compte de ça... :P (Oui, le message d'erreur porte à confusion.. )


Initialize the shared version.


ok


should this be change to DEBUG level so they don't always appear in the test logs?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What is the purpose of the history field? Could you add a comment?


Oh effectivement, je n'avais pas vu. Mes excuses, c'était donc probablement le meilleur choix.


- funzt nicht giebt BS


Maybe we need a more complex test here, but that should be placed in a separate commit, I guess to test the exact messages is difficult^^


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yep. Apparently (1 - 3e-8) is smaller than one but (1 - 2e-8) is not.

Maybe there should be a check in the constructor that decay_factor is less than 1, and probably that the other constants are greater than 0...

@dpkingma Does your implementation contain this bug as well? You might want to update the paper on arXiv with a warning about naive implementations in single-precision making this error (also you have a dangling sentence at the top of page 5).


Thanks much. It is now working for me


Atom removed trailing spaces from everything, and I added a few lines here and there. Also, apparently some implementations of markdown don't support the equal sign thing because it doesn't show up right in Atom's markdown renderer. O well. Whatever. Anyway, the keyboard on this Dell XPS 13 isn't half bad. I'm trying it out and it sounds and looks like typing on a pair of thumbscrews, but it feels fine and is plenty effective.


Do not merge it. Still need to change some things.


If you want, you can include _gfycat_-converted gifs by using an iframe like so:

```html
<iframe src="http://gfycat.com/ifr/MerryAbleAmazonparrot" frameborder="0" scrolling="no" width="1280" height="720" style="-webkit-backface-visibility: hidden;-webkit-transform: scale(1);" ></iframe>
```


Oui, tu as bien raison, je vais le remettre comme avant, par contre je vais
modifier le message.

Merci

Le 20 mai 2015 15:10, Jonathan <notifications@github.com> a écrit :

> L'énoncé du TP ne spécifiait pas que seules les réponses «oui» et «non»
> étaient acceptables ? J'avais ajouter «n» et «o» hier, avant de me rendre
> compte de ça... :P (Oui, le message d'erreur porte à confusion.. )
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cybermtl/G3-Iteration1/commit/25b885ca3b9389cac03239f8096c1968e503b27e#commitcomment-11291351>
> .
>


Declare your computerMove, playerMove and winner variables here and set them equal to the functions getPlayerMove, getComputerMove, and getWinner. getPlayerMove and getComputerMove, will invoke getInput and randomPlay, respectively. You can then pass the platerMove and computerMove variables into the getWinner function as parameters.

```js
var playerMove = getPlayerMove();
var computerMove = getComputerMove();
var winner = getWinner(playerMove, computerMove);
```

By declaring the variables here within the while loop playToFive function you reset them each time the loop is run. You need to have new moves and a new winner for each round of the game.


This works for me when enter a date in french format (dd/MM/yyyy) in an input text :+1:


Test cases may need to be added to verify that db configs are destroyed correctly.


Hey @awatson1978

It would probably be useful to mention that for static sites `spiderable` is necessary for crawling


Can we use a color variable here?


PRs are always welcome, that is why most people use github :) And even if you are just trying some stuff, you shouldn't rename libs. You don't even have to rename a composer package, just use your fork as source.


are 8 spaces indentation wanted?


I think you should remove `// TODO change to SessionNotFoundError`


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (348 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


Cool.  Thanks for the :eyes:.


We could just use an incrementor here I think


@ximinez When a peer first connects to anther peer, the manifests that peer sends are marked as `history`, meaning "these are not new and other peers already know about them so don't forward them". Will add a comment.


90210372-ChillerElectricEIR-still-delivering-chilled-water-#4453 (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1656 of 1657 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


ack


How can i use composer if the name is the same in composer.json? (You see, I'm new to this)
This wasn't meant to be an ahole, sorry.
I really like your Bundle, great job. I've got some 'complex' associations and messing around with it.
Reverting last commit ;)


I think it's important to mention *how* (as in order of) files are loaded (ex: lib files first, main files last, etc)


а зачем нам `img/icon-food.jpg` ?


Hi, I'm experiencing some issues after this particular change in this very line.
I'm having a character (FreeCam) positioned on a sloping Plane (at a minumum, approx. 2 degrees).
Prior to this commit the the FreeCam had no gravity velocity on that planar slope, but has now.
Mathematically it looks correct, however I would like to avoid my camera creeping slowly "down" that slope...
Thanks in advance for any hint or how to circumvent that or intercept that behaviour.


Please have another look at this.


а на css – слабо?)


No problem at all :) You can use a fork like this: https://getcomposer.org/doc/05-repositories.md#vcs


it miss the check "if v.ndim > len(sh):" from Alloc.make_node. Or move it in validate_shape.


These are questions we haven't really figured out yet.

You would only create the page object for the page you wanted to show. See e.g. the way we pick which toolbar to show (the main one or the search one). How this works with URLs is not yet determined.

To plumb messages from the row to the app you'd need to also add some logic to the stock list.


Non ho capito come mai l'hai tolto il display control false (li nasconde) . Ti dava problemi?


Tab/space mismatch here. Looks like 62-64 uses a tab, and the new 65 uses spaces.


Ottimo.


Lots of DMG games boot now (no sprites, no window though).


Curve25519 support is now part of ECDH, this is no longer required.


I don't think this is needed here? It will only grab "-dirty"


I suggest to reconsider quoting of variables which can contain [a CMake list](http://www.cmake.org/cmake/help/v3.2/manual/cmake-language.7.html#lists "List data structure").


This adds some steps to how a Scribe file is converted to a Mapfile. First, it replaces every string between 'quotes' or "double quotes" by a temporary string. Then, it removes the //comments within the Scribe file, exactly as before. Afterwards, it restores the strings that were replaced earlier.

This is to fix [an issue in ScribeUI](https://github.com/mapgears/scribeui/issues/113) where some links such as http://www... are interpreted as comments and cut in half.


We should write a simple test for this case^^
Just like we did with `SectionExecutor` we hack in a class that exposes the protected member and tests it with one or two invalid calls.


Might be a good idea to check `CL_DEVICE_LOCAL_MEM_TYPE` and continue only if the value is `CL_LOCAL`.


why is this not written in english!?


shape is size_t, but you cast to dtype_*, you must cast to size_t after that. This cause compilation crash.


*Token* --> *token*


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why are you using keyfind instead of proplists:get_value? Is ther a benefit to that?


Yes, that's right.


issue #589


uhm thats not 8 spaces but a tab. Thats not wanted. Its just there :) but it doesn't really matter for anything does it?


Py3 unfriendly : `xrange`


yeah its inconsistent


does the special character work on all platforms?

On Wed, May 20, 2015 at 3:05 PM, Iceman <notifications@github.com> wrote:

> ADD: @marshmellow42 latest fixes,
> CHG: change name to fancey "NTAG I²C 1K"
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/iceman1001/proxmark3/commit/1fa96198bb40e84754fc8496c49437c4fc254b49


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (348 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.71%25-yellow.svg)


`AnyPublicKeySlice` does not appear to have a move assignment operator defined. Should it have one, or is the copy operation desired?


This is pretty good. It seems like you're getting a little tripped up over the flow of the program - spend more time thinking about how the different functions and variables relate to one another and when each one needs to be called.

Try to think of it as a step by step process. First the program needs to gather information about the player and the computer moves (getPlayerMove and getComputerMove, which call getInput and randomPlay, respectively), secondly it needs to record them (setting them equal to variables), and then it needs to compare them (feeding those variables into the getWinner function as parameters). Finally, you need to repeat the entire process until either the player or the computer has reached 5 wins.


testing exact messages isn't that useful IMO. The test as it is is very well maintainable and checks the most important function of the bear so its sufficient IMO.


Hello, this is a read-only mirror of CRAN, so maybe you can ask the original package authors.


This rollback seems a bit to broad. What if that policy is added for other document definitions later? Perhaps we should add a more specific where clause to include the doc type id?


Il me semblait avoir modifier le message pourtant... (Quand on regarde mes commits.. )


Do you introduce logic operators sometimes? Just asking :)


rax retry tests


in pratica se avviavi una partita, facevi finire il tempo e quando dovevi inserire schiacciavi riparti, ti ripartiva una nuova sequenza ma rimaneva già il form e la tastiera della partita precedente. così se cliché riparti in quella situazione lo mette a posto


give me a few days, I will translate it :)


Maybe it would be a good to check whether tidy5 is present on the system, and based on that, use either `tidy` or `tidy5`.


no since we need to check if the function is already in there, a function may well be in several duplication situations


excellent :) :+1:


Oh yeah here you cold place an invalid invocation to test for the above non-covered statement.


New-Features-8-3 (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2123 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.5%25-yellow.svg)


Yes I agree. We decided to simplify computation by pre-adding the gravity. This implies reducing the gravity strength to get similar results now


@NPadrutt what do you think of it? (code and usefulness) I'm not very experienced with C# and Windows Phone development as I primarily develop for Android. So a little feedback would be nice. If it's good I'll make pull request.


that doesn't make sense, the None happens in some unforeseen situations we don't want it at all, that would be like a test assuring that a bug occurs


Do you actually test for this C-file?


That did the trick.


uhm are they missing? :/


Because you just check in the asserts that something is returned or not.


Heya Bruno,
Yeah, I set the check_sf module to flag unneeded parenthesis, since most of the time it isn't making the logic any clearer (and I've found quite a lot of places where there were just a ridiculous amount of nested parenthesis).
Of course, we'll still use it for cases where we need to change the order of operations, such as `x * (y + z)` or `(x || y) && z`.


yes. I check that for all files in the non_clones directory no results are returned i.e. the bear doesn't find anything.


@mk273 just comment this line, that worked for me.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1145 of 1145 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Got it!


@ximinez `AnyPublicKeySlice` is similar to a `std::tuple<void*,size_t>`. Copy assignment and move assignment would do the same thing.


Looks good!


nice job!


Yes this is very slow. My implementation of this always has been, takes about 10-20 minutes to calculate the transfer matrix. I'm open to suggestions to speed it up.


`self.updates`


party time


Yes this is very slow. My implementation of this always has been, takes about 10-20 minutes to calculate the transfer matrix for the test case in sampleData. I'm open to suggestions to speed it up.


The above line might be simpler like this:

```
if len(argDefs) > 0 && stdin != nil {
```

And I wonder if we may ever have a command that accepts no arguments but input from stdin. Though if it is probably a problem for another day.


rate shoud be upcase => Rate()


Much better, looks good.


скрипты подключаем перед закрывающимся `</body>`


This problem might not be of too much consequence since at least two public implementations of AdaM effectively use this decay factor equal to 1, [here](https://gist.github.com/Newmu/acb738767acb4788bac3) and [here](https://github.com/dpkingma/nips14-ssl/blob/master/gpulearn_z_x.py#L412-L456).


This is really embarrassing ...


why this? Can you put a comment to explain? The old back-end support it. If it is possible, just not implemented, add a todo in the code.


Thanks! BitHub has sent payment of  $9.26USD for this commit.


Isn't the trailing $ part of the problem?


What is the logic behind defining `X_MAX_POS` and `Y_MAX_POS` as larger than they actually are? This can cause the machine to crash, even motors don't skip any steps.


I used '!!' as the return value for errors (because of the reprap wiki). However a few lines lower down it gets the error message with _errorValue = line[6:] which seems to still assume 'Error:'?


Py3 unfriendly


how do i do this without using that, do i attempt to redefine L as a human after checking?


@fazam check again since autotest/gcore/data/byte.tif for example does display
```
Upper Left  (  440720.000, 3751320.000) (117d38'28.21"W, 33d54' 8.47"N)
Lower Left  (  440720.000, 3750120.000) (117d38'27.92"W, 33d53'29.51"N)
Upper Right (  441920.000, 3751320.000) (117d37'41.48"W, 33d54' 8.71"N)
Lower Right (  441920.000, 3750120.000) (117d37'41.20"W, 33d53'29.75"N)
Center      (  441320.000, 3750720.000) (117d38' 4.70"W, 33d53'49.11"N)
```


It's symmetrical now between local-address and remote-addreee


This was the fix for the tilting print bug


You can load the translation via the Translation class.
Translation.GetTranslation([ResourceName]).


need basic test as the one in cuda.


Looks good.

Do we need to import controls.buttons.xaml in App.xaml? Can't see it used anywhere and seems ok removing it.

Small bug that if you have a filter active when you do an uninstall, the text stays in the box but the refreshed installed items aren't re-filtered.
I guess either clear the filter text or re-filter the Items. (My vote would be to re-filter).


This isn't a Brackets extension, it shouldn't go here.  These are just for the upstream ones.  Can we put it in `extensions/extra`?


Не понимаю этих коммитов (уже не первый), ты меняешь перенос строки? Или что-то ещё/что-то другое? Из описания коммита "Fix blog.html" – непонятно ничего))


looks pretty good. Both in usefulness and code. I made you some notes. But that are really just details =)


Merge


Its ascii char..  Should work on all platforms.   both the ² and ™  ...


reack


New-Features-8-3 (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I can understand returning an Index Object, but, why call reduce on that?

I kind of feel that we should pass the reduce() through to the GetMany method on the IContentStore and let the store take care of the reducing?

The Pagination stuff will totally come along, just haven't needed it just yet!


все кроме icon-ha.png и icon-date.png – можно просто и быстро сделать через css)


Looks good overall- you definitely have all the main pieces/concepts in place. Some suggestions for taking it further:

-check back to original design file and tweak font size/weight/color to better match design
-add border-radius to your buttons
-make small adjustments to padding/heights of things to better emulate design.

Nice work!


@bnorthan @dietzc @DanielSeebacher
It has been my personal experience that `protected` and `package` scope create barriers to extensibility.

We have [guidelines](http://imagej.net/Coding_style#Private_over_protected_fields_and_methods) that talk about why we typically avoid these scopes.

Anyway, it's not a big deal right now.. especially in individual ops like this.. and we can merge this as-is. We will want to do a review for this type of stuff before 1.0.0; but mostly I just wanted to make sure you were all aware of our general preferences.


Thanks for following my comments. But the error handling is still not clean: you are leaking memory because there are mallocs above your allocation for the string. These need to be freed, too, before leaving the function with return NULL.
A simple call to `modbus_free(ctx)` should do the trick...


`relative_update` vs `current_update`


As páginas ainda não fazem acesso ao banco de dados


It might be reasonable to just "die" if $crypt_return is *0 or *1.  A fatal error seems reasonable and will make sure that things get fixed.  User won't even make it past installation with broken hashes.


/test2.css:45:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


/test2.css:44:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


/test2.css:53:5: CSS outline not supported by: Opera Mini (5.0-8.0)


/test2.css:46:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


perhaps this should have been sidebar-left?


das war ich nicht. das hat wohl jspm automatisch gemacht?


That may be confusing, as one would likely expect the linter utilised to remain the same if installing tidy5 subsequently to this linter plugin; the behaviour would definitely be most weird. I believe that some flags were removed in tidy5, so this would result in errors. Although I would expect for someone to want to utilise tidy5 if available, I cannot count on it. A possible solution to this would be to create a `SublimeLinter-html5-tidy` repo, and to split this between the two. However, I would advise instead to create a symbolic link to `tidy5` somewhere in your path named `tidy` (`ln -s $(which tidy5) /usr/local/bin/tidy` or something similar), or to simply rename `tidy5` to `tidy` (`mv $(which tidy5) /usr/local/bin/tidy` or something similar) - although this could cause problems with other program dependencies. SymLinking is the best solution, IMHO.


também foi criado o controller do desconto


Ah ho letto sbagliato il commit. Credevo avessi cancellato non aggiunto
quella riga.
Hai fatto bene, l avevo messa ma poi tornando a un altra versione per altri
problemi l ho persa.
Bravo
Il 20/Mag/2015 21:24, "ghia16" <notifications@github.com> ha scritto:

> in pratica se avviavi una partita, facevi finire il tempo e quando dovevi
> inserire schiacciavi riparti, ti ripartiva una nuova sequenza ma rimaneva
> già il form e la tastiera della partita precedente. così se cliché riparti
> in quella situazione lo mette a posto
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/igorravasi/Memo/commit/fe79070fb1cf85b75b5b29f03fbc2a7fa30d1d4d#commitcomment-11291628>
> .
>


wow … wie denn das?

Thomas Hochstetter
EBTC Berlin, Zürich

 <http://www.ebtc-online.org/>

Havelländer Ring 40 | 12629, Berlin
tel +49 (30) 60 988 61-16 | mobile +49 (151) 275 393 07
fax +49 (30) 60 988 61-19

website <http://www.ebtc-online.org/>  |  blog <http://ebtc-online.org/blog/>  |  vCard <http://ebtc-online.org/efiles/vcards/ThomasHochstetter.vcf>  |  map <https://maps.google.de/maps?q=EBTC+Europ%C3%A4isches+Bibel+Trainings+Centrum,+Berlin&hl=en&ie=UTF8&ll=52.548383,13.595581&spn=0.253448,0.565796&sll=52.506844,13.424732&sspn=0.507371,1.131592&oq=EBTC+&t=h&hq=EBTC+Europ%C3%A4isches+Bibel+Trainings+Centrum,&hnear=Berlin&z=11&iwloc=A>  |  email <mailto:th@ebtc-online.org>  |  tmai.org <http://www.tmai.org/ebtc/>

 <https://twitter.com/EBTCOnline>  <http://ebtc-online.org/blog/>  <https://www.facebook.com/ebtc.online>

> Am 20.05.2015 um 21:38 schrieb Paul Walger <notifications@github.com>:
>
> das war ich nicht. das hat wohl jspm automatisch gemacht?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/digitaldeacon/memberhive/commit/fa8765e839bf4923a97faa9aa3c56ff3181eab09#commitcomment-11291894>.
>


Currently there is check if device is a cpu ```serial_find_extreme``` is used (see [`find_extrema line 40`](https://github.com/haahh/compute/blob/328507c1149e28e956e4c2ef4cf399479c2e05c4/include/boost/compute/algorithm/detail/find_extrema.hpp#L40)), but indeed checking `CL_DEVICE_LOCAL_MEM_TYPE`  may be a better solution as it covers the case when device is not cpu, but still has no local memory. Thanks!


Would need an `execute_before` and an `execute_after`.


Thx for your quick response. Reducing scene gravity solved that, now I'm using
```scene.gravity = new BABYLON.Vector3(0, -0.01, 0);```


"out" -> "our"


How does that fix tilting? It would seem if the print is tilting, there is a cumulative lateral positioning error.


В таких селекторах следует значение писать в кавычках: `input[type="text"]` – это больше вопросы безопасности


The client class current provides a content-type header for JSON.  See row.py :805.


No idea why it fixed the tilting. We should probably confirm that we are
still getting the tilting after the Great Rebase

On Wed, May 20, 2015 at 3:41 PM, Richard Rininger <notifications@github.com>
wrote:

> How does that fix tilting? It would seem if the print is tilting, there is
> a cumulative lateral positioning error.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Voxel8/Marlin/commit/2297ce804173bbfe0588f3e885fc899dcf535874#commitcomment-11291936>
> .
>

--
Jack Minardi
jack.minardi.org
jack@minardi.org


These lines are simply redundant. They don't do anything.
Also I believe you will need to keep the GLEW/OpenGL ones linked.


The motivation / background for why this approach is presently taken needs to be properly documented in case anyone wants to challenge it later.


Your experience, things you're convinced in, etc... You think this is something important. :) It's not. Believe it or not, I don't care.


How about `ActiveRecord::ActiveRecordError` here?


Ideally the type of this column would be "time interval", but gorp doesn't support that mapping. I would express this in terms of a concrete unit, like "retention_days".


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1664 of 1665 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Also: what about situations like we have [here](https://github.com/tablexi/gsp-portal/pull/306/files#r30720965) where the exception is a `PG::NotNullViolation`?


Argh... Stupid oversight. Could you create a PR? A simple "if line.startswith(...) else ..." would prolly be enough but I don't trust myself at the moment, still out of commission...


(y)


die klass müssti glaub abstract si?


Oh, looks like you might need to rename it to README.md to get this image to show up. I'm not sure if there's another way to write the image in there so that it shows up without renaming the file.


The variable `${FORGE_LIBRARIES}` is taking care of all Forge dependencies. I have checked this on Linux and it is working fine.


Recursive use of `__getitem__`, won't work.


Thanks! BitHub has sent payment of  $9.08USD for this commit.


Long overdue!
(The sins of the past, I recognize thy ugly face...)


hassanmassafer


My only question about this is are we OK with the fact that `xi + realToFrac 1 *~ one * (xf - xi)` = `xi + (xf - xi)` might not equal `xf`.


Yes, in practice I do not use this exponential decay of beta1, and we had
good results without it. The default decay factor of (1 - 2e-8) used in the
paper is virtually negligible anyway.

The exponential decay of beta1 was added for theoretic reasons: it is
required for the proofs in section 4 of the paper. Leave it in if this
matters for you; for deep nets though, it's probably of little practical
significance.

On Wed, May 20, 2015 at 9:32 PM, Laurent Dinh <notifications@github.com>
wrote:

> This problem might not be of too much consequence since at least two
> public implementations of AdaM effectively use this decay factor equal to
> 1, here <https://gist.github.com/Newmu/acb738767acb4788bac3> and here
> <https://github.com/dpkingma/nips14-ssl/blob/master/gpulearn_z_x.py#L412-L456>
> .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mila-udem/blocks/commit/4f4aedb98cc3ac3e3b4bf2f6dc6323367f546476#commitcomment-11291780>
> .
>


нам нужен блочный элемент?


Chasch da en message schmeisse womer au verstaht wennmer dlogs liest? Z.b. user not found in database


and the commit message needs to be "add" and not "end", just FYI


Good point. No, we are not.

On Wed, May 20, 2015 at 9:47 PM, Douglas McClean <notifications@github.com>
wrote:

> My only question about this is are we OK with the fact that `xi + realToFrac 1 *~ one * (xf - xi)` = `xi + (xf - xi)` might not equal `xf`.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bjornbm/dimensional-dk/commit/5aa2403df7e6c82f90d645e65fbed4a4c1db0322#commitcomment-11292028


Did you test it with the external build?
The USE_SYSTEM_FORGE one will be fine. Using it as an external project won't work.


buildersbrewery/linden-scripting-language#13


But my solution to this, using `(++)` was probably terrible from a performance perspective.

What if we "turned it around" so that the result was `xi : fmap f [1..n]` and `f` was the moral equivalent of `xf - something * (xi - xf)`.


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nullpointer exception dörfed permconvention ned abgfange werde. Es verschleieret wo en nullpointer uftrete isch. Mach i dem fall en null check (== null)


`recurrent_option` should be explicit, and before `*variables`.


Because you reduce the index. Index.Reduce. Reduce the index. the store is entirely out of the picture at this point. Querying and storage are entirely different and separated concerns. You are crossing the beams.


Won't having this `if` before the next one cause stuff like this:
```html
<svg>
   <line x1.bind="x1" y1.bind="y1" x2.bind="x2" y2.bind="y2" style="stroke:red;stroke-width:${width}"/></line>
</svg>
```

to not work, or am I missing something?


Okay. I made one.


Maybe adding a "friction" parameter (like the physics -engine have) would solve such problems, even when gravity is the usual -9.8. The "raw" calculation is correct, standing on a 2 degrees slope (of ice :-) ) would cause the camera to move. Adding friction will solve that. @deltakosh , what do you say? Would make the collision system a bit complex, but nothing JS can't handle!


D id isch rein datebank stuff und setti ned exposed werde oder irgendwoin java brucht werde. Mer hend für di eidütig erkennig d uid. D id isch nur fürs datebankmapping


Redirection functionality shouldn't be done on the template level, it should be done in a controller level, this case being in the FlowRouter.route.


Recurrent, per-epoch task.


The main problem here is the contact check and safe checks.

If a Bc4 is already giving check on Kg8
there will be Bb3 and Ba2 which will be considered as an additional safe checks,
and thus overscore them

Must find a way to properly score the checking piece, and only once.


Seems to be running fine, it was being included twice(Once by ArrayFire CMakeLists.txt and then by FindForge.cmake). I think i just removed the duplicate.


Wieso kei camelcase? Und bruch d uid


Can you check for existence first, in case the user loses connection.


I like :+1:


Isn't `Status.training_time` used for this case?


I think this commit only work for ES6?


Looks good! :+1: :sake:


what?


Yeah.
Just do

    if(ishuman(L))
        var/mob/living/carbon/human/H = L
        H.vomit()


What?


This is probably the best path forward until you decide what you want to do with it. Is looking good even to my simple C++ brain.


If you pull this repo and pull jsdom-little, then copy and paste this repo into there, then run `git diff` you can see the full diff :smile:


Shouldn't be mixed in the `PrintEpochDuration` task.


Ich glaub du hesch na bitz müeh mitm verständnis vo de DB id und de UID. Ich chas der sus gern namal erchläre :)


~/.vagrant.d/Vagrantfile

```
VAGRANTFILE_API_VERSION = "2"

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
    config.vm.provider :virtualbox do |vb|

         # Use VBoxManage to customize the VM. For example to change memory:
         vb.customize ["modifyvm", :id, "--memory", "8192"]
         vb.customize ["modifyvm", :id, "--cpus", "4"]
     end
end
```


i like these.


I really don't see why those are not explicit : easier to go through with an IDE.


This commit is too large to merge.


authentication should be also possible without setting a host and a port. It seems it is not the case here (in the else).


This is related to: https://github.com/Robdel12/DropKick/issues/293