do you need that?


What's the point of `@:generic`? It works fine for me in general without it.

That haxe issue obv didn't solve the problem, though it sounded like the same kind of issue.


@tadast: Good point. You've convinced me to go with my less pretty multiple test solution.


> All these enums are to mirror the ones in 1622.2 in order to encourage compatibility.

I've only been suggesting definitions here, not that the enum values should change.  I think the enum values are good enough with the right definitions.


Qt5 problems:
```
CMake Error at CMakeLists.txt:29 (find_package):
  By not providing "FindQt5LinguistTools.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "Qt5LinguistTools", but CMake did not find one.

  Could not find a package configuration file provided by "Qt5LinguistTools"
  with any of the following names:

    Qt5LinguistToolsConfig.cmake
    qt5linguisttools-config.cmake

  Add the installation prefix of "Qt5LinguistTools" to CMAKE_PREFIX_PATH or
  set "Qt5LinguistTools_DIR" to a directory containing one of the above
  files.  If "Qt5LinguistTools" provides a separate development package or
  SDK, be sure it has been installed.
```

I have a package named "qttools5-dev-tools" which is stated to include the linguist tool, but still am given the error.


Er, what exactly should it be ?


Sweet!


Would be nice to have toolbar update as a separate method to show what is going on.


Sqlite query strings added to MVSC code. Other minor modifications include creating a put_header function and modifying gps boundary times to create partitions for all_injections trigger set.


Ah. I thought so.


Works for me.


Try ``nimble update`` again, or download the packages.json file manually.


oh boy, [0], [1], [0], [1], we need to add an indentation here


Never mind me, @michael-n-cooper.  I'm just slowly working up through history, and just saw:
https://github.com/w3c/aria/commit/353b8fb70e6f57846bbad329e4bd245a53bd5c3f


This commit probably is a BC breaking change. I have code that relies on the fact that changing the "required" flag also affects the "allowEmpty" flag. Updating from 2.2.10 to 2.4.2 breaks my form validation unexpectedly.


Ok


1.5 million in reward, that is quite a lot.
http://www.wolframalpha.com/input/?i=75000000+*+1000000+*+20180075228+%2F+1000000000000000000


This one looks like its trying to assign a `Boolean` rather than just a truthy value. I'm assuming `params[:update_status]` will contain a `String` from the form submission.


`display:inline-block` breaks the UI when one link text is longer than the other. See below snapshot:

![screen shot 2015-05-27 at 8 49 14 pm](https://cloud.githubusercontent.com/assets/2862724/7839790/eb5955c8-04b1-11e5-8b2c-0bbbb16df87b.png)


I hate to second guess, but validator/validation are practically the same word (visually, at least). I am concerned that users and documentation will get even more confused.


Reviewed and forwarded your branch. https://github.com/brianchandotcom/liferay-portal/pull/26832


Sometimes I wonder, do people even use Checkstyle... because we've all been running into these issues and we only find other context projects having the same issues :wink:


strcasestr is not a compatible function:

http://www.gnu.org/software/gnulib/manual/html_node/strcasestr.html


@aStonedPenguin that was kinda sad.


Fair enough, that makes sense.

I guess it would be pretty easy to add another derive struct that uses `operator+` and `0`, perhaps through your suggested `Add` abstraction or similar. Feel free to make a pull request for such a thing if you like :)


Comment ça tu me remove :)


if you use  this authority, the sync with mirakel will be impossible.
You need to check if dmfs or mirakel is installed.


It's just an optimization, so everything should work the same without it.

Basically, for each unique `T`, a separate class is created, similar to c++ templates. You can see that when you search for `FlxPool` on http://api.haxeflixel.com/ (though obviously those versions of the class  shouldn't show up in the docs).


OK, I'll change how these are formatted.


"explained in a moment" -> "explained below".

The document is physical, not temporal.


I agree that it should always be visible. It seems like it would be frustrating to a user if they knew they didn't know their password, and didn't bother trying entering a wrong one.


Yes.  I'll guard against that case.


Doraemon,see you Saturday


```
has_attached_file :image, url: '/spree/looks/:attachment/:id/:style/:filename'
validates_attachment_content_type :image, :content_type => /\Aimage\/.*\Z/
```

I have something like this in my paperclip config. Do you need to have the url set?


a


Thank you Jim, you will always be around. Here...


@kkrampa This creates a pretty horrible query. Is there any way we can optimize it?
```sql
SELECT products_sqlproduct.* FROM products_sqlproduct
WHERE
    products_sqlproduct.id IN
    (
        SELECT U3.sqlproduct_id FROM locations_sqllocation U0
        LEFT OUTER JOIN locations_sqllocation U1 ON ( U0.parent_id = U1.id )
        INNER JOIN locations_locationtype U2 ON ( U0.location_type_id = U2.id )
        LEFT OUTER JOIN locations_sqllocation__products U3 ON ( U0.id = U3.sqllocation_id )
        WHERE
        (
            (
                (U0.is_archived = false AND U1.location_id = 'xxx' )
                OR
                (U0.domain = 'zzz' AND U2.name = 'yyy' )
            )
            AND NOT U0.supply_point_id IS NULL
        )
    )
    AND NOT products_sqlproduct.is_archived = true
```
cc @benrudolph


I tagged 0.10 just before running out yesterday, so haven't had the time to push the announcement on the website or do the Ubuntu package update yet.

That'll happen later today.


"master_secret" -> "validator_secret". (Right?)


Also, are you still having this issue? I'm actually not sure what Haxe version I was on when I experienced this, as I'm often switching between 3.2.0 and 3.1.3.


This originally had two spaces, and Sphinx seems to cope. https://dxr.readthedocs.org/en/es/development.html#coding-convention
(however, I'll fix this)


Yay thanks


looks like this should be:
`params.require(:user).permit(:name, :firstname, :email, :password, :password_confirmation, :avatar)`


Oh, yes, I was surprised. I don't understand how it happened.


Be carefull with this, older IE's don't trigger events when form is submitted, they only process the ones that are directly bound to the form.


Looks like this variable is not used.


published


No, something like this:

```
@lua_property(name='...')
@command(...)
def func(...):
    # ...
```


Good call. How about "Only when they have a meaning different from what the original name suggests"?


I am trying to understand what is the criteria for placing a constant in this file. The commit message does not provide this information. The SMP bit in the CPUECTLR_EL1 is common to A53, and A57. However, the other bits in this register are different. So placing the SMP bit in this file and others in the CPU specific files will not aid readability.

Also, CPUECTLR_EL1, L2CTLR_ELX etc are imp. def. registers which the architecture does not know about. They are completely CPU specific. They need not be common to all Cortex A class CPUs. So they should not count either.

That leaves us with the imp. def. registers which are known to the architecture i.e. ACTLR_ELx, AFSR0_ELx etc. One could safely assume that each Cortex-A class CPU that implements these registers would have the same implementation at least for big.LITTLE compatibility. If this header is meant to cater for such registers then this should be made clearer in the commit message and in comments in this file.

Does that make sense?


How do mean that?

To create the element from a atring you can use jQuery: `$('<div myTemplayer>')[0]` and you can use `[0]` to get the DOM-Element (instead of the jQuery) element.

You can store that reference to the DOM node in the closure that you are creating here:
```js
var templayerElement = $(template)[0];
```
You can attach it to your body:
```js
$(document.body).append(templayerElement);
// or without jQuery
document.body.appendChild(templayerElement);
```
Later you can use it like this:
```js
d3.select(templayerElement)...
```

However, just looking at your code and how much DOM creation you do there mixed into the business logiv etc. Perhaps we should take us the time and try to restructure the whole thing to more sane approach. I think that could be helpful for you.

I'd do that after the function is located within the directive.


Yes definitely


Looks very nice man!


I'm dropping the ajax_ prefix, but is it useful to check that the request `is_ajax`?


According to @butenkor if we do not do this, a product update without slugs will delete the slugs from existing product, which we do not want.
Or is it somehow handled by the ProductSync module?


yes because it's followed by a letter

    `Persister` but ``Persister``s


It's already in there :)


I'd rather leave it since all the other footer submit buttons have it. I think semantically it is correct that it is a `btn-primary`, even if none of it's associated styles take effect.


I fear that this one might come abck and bit us so I left the comment and the commented option


如果對手指定陷阱怪獸的話就無法辨別


I'm asking about it because it could make wrapper code more straightforward - you won't have to expose lua_properties as methods yourselves (so it is more DRY), and for new properties you can avoid exposing them as methods - we only need those methods for backwards compatibility.


It looks like you deleted the option.


debería, pero por ahora no es parte del update porque no hay conesecuencias cuando te agarra. Por ahora se está cargando desde la escena, pero hay que pulir todo eso.


yes PDF anre the slowest to render and you can start reviewing doc changes from the HTML.
About the xslt change, it's a small leak from the next commit. Let that one go :)


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1152 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.82%25-green.svg)


ok, thanks I was just a bit puzzled.


Yes I had to dig back the hibernate-jdocbook-style project. So I did it in two steps, move to the new press gang, then move to the new hibernate-jdocbook-style.


In all likelihood, given their 'true' names, these compounds will likely match and merge with other compounds in the database, but I will tackle that as a separate issue for now.


Define a `serialVersionUID` for this and all other classes that implement `Serializable` to avoid warnings. `1L` is fine as the value.


As for uploading the packages, you can continue to upload them to the website.  I don't know about ppas, as Debian doesn't use them, but the repository is named apt because the structure is that of an apt repository, accessible to both Debian and Ubuntu users.

I think that the only package you need for an apt repository is dpkg (I tried to trick GitHub Pages into hosting my repo, but I think it was missing that).  If you want to set up an apt repository, I can help you with that.

If you have any other questions, I'll be happy to answer them.


Myślę że liczba kolumn będzie sztywno ustalona, natomiast szerokość kolumny w px będzie wyliczana


no I put it back in.


Make this class final.


Updated the ReST apis to the new standard


Yes, this is a major change. What's the justification for moving from lambda_g to expected coverage?


I think you mean RepoTags, sure I'll use it.


Wieso hast du das weg genommen? Es sollte eigentlich auf jeder Seite einen jumbotron geben


Eh, I'm not sure about *each* service.. For example I don't know of a pubsub test double... I know Datastore has one, Storage has a quasi-one, but only works if you use the XML API, etc. So this is ... tricky.


SGTM


shareable? Probably there will be always single subscription, but if not we might have race conditions since there is single snapshot atomic reference.


Java will implicitly call the no-arg superclass constructor for you -- no need to do so explicitly.


This should be initialized to 1.


Like https://github.com/jpmckinney/alaveteli/commit/ef97ebe2b9b12f5c44a9382b7a81cfca765c1696#commitcomment-11388078, this looks like it should be assigning a `Boolean` rather than a `String`.


Der Inhalt der Seiten sollte in einzelnen section Elementen mit der Klasse content dargestellt werden. Wieso hast du deine eigenen div's stattdessen verwendet?


Not unless you're doing different behavior based on it.  I think in the previous discussion, there were two view functions handling either case and they were merged into one with a conditional on that property.  In your case, I think there's just one path anyway, so doesn't sound like you need it.


If `r->size` is casted to double below, then it should be done here as well.


I saw it. I was then wondering why this even exists.


fails tidy


Perhaps instead of `elasticsearch`, something arbitrary?

```
`bin/plugin list namefragment` Will list all plugins containing `namefragment`.
```


At the top of each file you have the call to `define` in here like this:
```js
define([], function() {
... your code here...
})
```

This is doing two things:

1. it defines your code as a module that can be loaded using requireJS
2. it defines the **dependencies** of this module and loads them. Think about how useful this is!

To load jQuery into this file do:

```js
define(['jQuery'], function($) {
// you can use $ now
... your code here...
})
```

added `d3` and formatted it a bit

```js
define([
    'jQuery
  , 'd3'
'], function(
    $
  , d3
) {
// you can use $ and d3 now
... your code here...
})
```


Yeah I'm getting it on 3.2.

I don't remember if I got it on 3.1.3, but I was on an ~October dev 3.2 when I made the initial issue.


Actually this one is okay – I thought it was getting used later as an attribute.


Looks great. We might add the functionality to parse directly the JSON DCU files if intelMQ cannot directly get access to Azure.


space after =


We [avoid the use of `!!`](https://github.com/bbatsov/ruby-style-guide#no-bang-bang).


neat


I like that actionIds are now qualified with actionPlugin.  It's maybe slightly odd that actionId is now not a unique Id but that is probably not worth changing.


Nem pensar em py3x ainda, né?


Não deveria marcar Django>1.x aqui também? Ao menos igual ao que tá descrito no tox.


`phpdoc_params` fixer didn't like the indenting;

```php
    /**
     * @dataProvider provideIsArray
     * @requires PHP 5.4
     *
     * @param string $source   PHP code
     * @param array  $expected [0] Token index to use,
     *                         [1] bool[] 2 elements:
     *                              [0] is multiline array
     *                              [1] is short array
     */
```


Just for your information: https://github.com/taka-no-me/android-cmake/pull/52


lgtm :)


Zum desgin der Seiten an sich:
 - so wenig reinen Text wie möglich
 - nach Möglichkeit Bilder/Grafiken verwenden
 - vieleicht andere JavaScript/Html5 annimationen (karusel..)


Yes, potentially.
I know I wanted to do this for JRuby's `date` library but it was not really feasible to have it both as a an easy field to access from Java and a ruby ivar.


fix https://github.com/dart-lang/eclipse3/issues/2


hm, why there's no dot between package and simple class name. I guess simplicity is the winner, thus a unique format in both test case/suite like fully qualified class. I can distinguish between them if TC_ appears I see test case.


Wire isn't needed.


Der footer sollte eigentlich auf jeder seite zu sehen sein. Wieso hast du ihn rausgenommen?


You can use WIDTH and HEIGHT defined by the API>


hmm, forgot I had this PR out: https://github.com/dart-lang/eclipse3/pull/3


According to Rx documentation:
```
Returns an {@code Observable} that stays connected to this {@code ConnectableObservable} as long as there
is at least one subscription to this {@code ConnectableObservable}.
```
There are no direct subscriptions to the underlying ```ConnectableObservable```...


Wieso das padding?


Yeah, they do, they just say they use it and let it crash ;)


Start method names with a lowercase letter in accordance with standard Java convention:  `GetRecalibrationTables()` -> `getRecalibrationTables()`


Would you pls split in two lines?
Thx


Ok, I'll hcange it, you're right!


This is a really good update to the documentation!


The youtube color should be: #e52d27

http://www.youtube.com/yt/brand/color.html


You don't actually use `download_path` in this recipe.  This like can be removed.


Já mudei heheh. Depois de comentar q não sabia como voltar, eu achei e consertei. Agora a master já ta certa ^^


you already have an event_response called response;


Um - why does that imply log prob gaps does nothing? It also controls for getting a small fraction of the gene with high coverage, versus all of the gene at low coverage


That was the idea behind this. I'll change it to initBehavior().


thx


I had it happen with an earlier version of the ringbuffer example. I tired looking around in the jack code but there's no hints on why it would do this.


Remove commented-out line


Or maybe we should build write server without override? As registration sources are composeable we can do that.


yur phone suk


Uh do you mean it is there twice?


Firstly, the old model wasn't working. If you gave it a GI with and expected 450x coverage and observed median coverage of 2x it said that R was more likely than r and S.

This model is based from the intuition that coverage of the gene should be poisson distributed around an expected value of the expected coverage so the prob of observing the coverage given a model (r or R) is given by the poisson prob with lambda = expected coverage.


Looks good.

Is there a reason this needs to be in `ihaskell` proper, rather than a separate package?


I'm not sure we need this level of detail here.


That's just due to the scaling of the test. I think the initial residual is 1e+8 or something.  I can just delete the nl_abs_tol lines on these.


In the jack code jack_midi_event_get returns ENOBUF if event_count is 0, if i actually repeat a call to jack_midi_get_event_count I'll get 0 back too.

I'm just assuming this error is the same as stop iteration (suddenly it realized it had less elements that it thought it had).

I don't actually know if we're dropping any real events because of this (or if we can even do anything about it).

I can post a commit with the old example again for more exploration.


TeamCity YaccConstructor :: YC.Core General Build [Build 394](http://teamcity.codebetter.com/viewLog.html?buildId=192110&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


Aha, sounds great. Enjoy!

Fingers crossed then! *pulls merge*


How does this work?

Can we have assertions in the teardown method of the context?


I haven't thoroughly tested this though so I'm not suggesting merging


Sure, I thought you were going to change the "!" back to a “»”?


nit: please add a bug #


Are you fucking kidding me, these two data members differ by just one letter?


Yes if I remove the private methods.  I would literally have a extras.cacheAsBitmap Interface with a single cacheAsBitmap member on the interface. In this case yeah, an interface can only have public signatures.  (Note in the mixin sample, how weird it is to have classes be used as interfaces).  I cannot get that to work in a definition file at all.

So yeah! But then you have these "_cacheAsBitmap" and "_renderCachedWebGL" functions lost to the system.  Either, you need to find everything that implements extras.cacheAsBitmap and then implement all of those private things inline.... Which is awkward personally.  OR you just get rid of private variables.

I am not sold on private variables by the way. I actually have not used them in definitions before until now. http://stackoverflow.com/questions/26885085/do-private-properties-and-methods-belong-inside-a-typescript-definition-file


Thanks!!


@livemixlove Paul -- I changed the gtfs_api_baseurl to Ed's new API endpoint. Checked in the changes here, but it looks as though this repo is missing recent changes?


We generally discourage wildcard imports as per https://wiki.openmrs.org/display/docs/Coding+Conventions


Hmm good point. Have to look into it, leave it like this for now


This check (`BRAC.readArguments.readFilesNames.size()<1`) will be done for you by the arg-parsing system, now that you've made this a required argument. So only the check below that `BRAC.readArguments.readFilesNames.size()>1` is needed here.


Can you add a comment that tell why we continue to use dot22scalar? Just to be sure we don,t do the same error again.


Should be a `UserException`


If the premise is that indexed access may be slow, shouldn't this be rewritten without indexed access? (i.e. skip & iteration instead of `getFromFirst`)


Thanks @aaronlidman! Was literally just opening my machine to do this. :+1:


@DasNerdherder you should submit this as a PR :+1:


这里可以写成`puts "Chicken: #{chickens}"`，这样是 Ruby 里最常见的写法


looks good, so in our event handler we'd have to check if the element has an attribute like <image src=".." onmousedown="" /> and execute the required code?

Will also be easily extendable for key events, so I approve.


Seems we should never have passed that test since the date is outside Joda-Time range.
I will fix and tag.


- `toggle_auto_reload_runs_table` などで auto reload をtoggleしていたのは、テーブルの中にテーブルがあるとreloadした瞬間に中のテーブルの表示が消えてしまうからです。modalにしたので、toggleする必要がないのでは？


safsda


nit: return threadPromise here, and add another .then on the "toplevel" promise chain


ack


What if instead of just hitting "break" you might send the response "<command> is an unsupported command in Marlin" so at least there's some acknowledgement the command was processed but simply doesn't do anything?


So now the cookbook won't pass if we pass pull-server-side-config = true and do not supply tokens (which aren't needed)


super commit!


You probably don't want duplicates here, so we should probably be using `ImmutableSortedSet` here.  With that said, @andrewjcg made a good point to me that all of our prebuilt rules wrap one entity and this is a bit odd wrapping more than one.  Could you make it so it only wraps one for consistency?


Btw it should for each platform have some valid default font, for example on MacOSX it defaults to .Al-Bayan something which produces squares.


- `.attr("state", "open")` のようにstateをattributeとして保持しておく必要がもう無いと思います。toggleの時に使われていただけ？確認してください。


It's in there one time already.


![captura de tela 2015-05-27 as 11 51 34](https://cloud.githubusercontent.com/assets/5906175/7840771/f2e5eaea-0466-11e5-92f4-985854f6c9d9.png)


Use a logger, not `System.out.println()`


Should it be `line.order.removeOrderline(line)` here?


Hi, I did the following in trunk related to render scale:
https://github.com/olear/openfx-arena/commit/1f2db22845fea7c7cdbb487a302310476f3756e5
https://github.com/olear/openfx-arena/commit/8be62696ba394fcd2278f88ec0fa36dbbb724678
https://github.com/olear/openfx-arena/commit/f490b287bbe796561b2185ab07eff605352f5186

Should I just add std::floor and + 0.5?


it's not clear what the workaround is -- the fact that you first declare and immediately after define the template? That fact would be worth stating.


@Chhaya-rai - any specific reason for naming it `os-windows`?


Brush and core js files for syntax highlighting are already stored in js folder.


spurious change that I think violates PEP8


Uh yeah this is the commit that added it https://github.com/matteocrippa/awesome-swift/pull/141 :smile:


Should be just `SimpleInterval(f)` (since `SimpleInterval` has a constructor that takes a `Locatable` directly, and a `Feature` is `Locatable`)


it will round to the nearest integer instead of truncating it


try add bullet like `*` on nested level


The premise is that size is slow because it will iterate the *entire* list on several implementations.


See docs for `i_suck_and_my_tests_are_order_dependent!` - http://ruby-doc.com/stdlib-2.0/libdoc/minitest/unit/rdoc/MiniTest/Unit/TestCase.html#method-c-i_suck_and_my_tests_are_order_dependent-21. Essentially it means that tests are consistently run in alphabetical order. By using the "zzz" string, this should guarantee that this test runs last after all the other tests in this test case.

Putting the assertions in the context teardown won't work, because the teardown method is called after **every** test and not after **all** the tests.


hm, is this really necessary to have a side effect to the return statement? I don't find this obvious to read...


Pretty clean! :smile:

But there is an issue: (screenrecord) https://www.dropbox.com/s/2uf39fjg4bkx0r4/Telecine_2015-05-27-17-50-33.mp4?dl=0


reack


What are these changes for?  Can we move them to `PexStep` so that we don't have to modify this upstream code?


I see, will adjust in trunk.


@Chhaya-rai - again why is the `win` for windows making it into variable names or ids? what is the significance?


PERCENT isn't supported. I do believe there is an offset keyword supported and it looks like it would be handled around here.


`override`.


On a hex editing binge, eh? :smile:


This method (`ingestInputs()`) seems overly long -- would you mind refactoring it into two methods, one to load the reads and another to load the known sites/skip intervals?


Whoops, haha! Sorry about that!


it's not clear to me what ensures that the LIIMT X is being placed at the correct spot in the query, but if this has been tested, then I suppose it is correct


What's a sane default font on Mac? On Windows Arial should do? And on Linux maybe Cursor or Dejavu-Sans?


Use try-with-resources for this stream


Yeah, working on a Haskell implementation of [Cap'n Proto](https://capnproto.org) - trying to find a hex editor that doesn't suck :smile:


@ximinez I have the same thought. I'm mirroring the sections in the config file. Suggestions for terms?


Example:
```Smalltalk
{[DateAndTime now] -> {#notifier -> [ViTimedNotifier every: 500]}} openScript.
```


I'm sorry, I should have been more clear.  I think it should read something like:

"and check if subscription-manager successfully attached existing pools"


"__DO_TOP" is not very descriptive. Change to __SUPPORT_SQL_TOP or something similar.


I use it ton of times for own forks and snapshots. Yeah, awesome


I'm still leaning towards the original:

> In my ever-so-humble opinion, the ”!!” idiom is an abomination: it’s far too clever for its own good. First of all, you rarely ever need a real boolean value, and for those times you do, it is better to be explicit in the conversion, by using a ternary operator or full-blown if statement, for instance.
>
> _– http://www.therailsway.com/2007/8/1/dangers-of-cargo-culting_

`!!` certainly makes me think more than reading `value ? true : false`


Fun! We need a `meta.sucks` attribute


Arial is on Mac too, on Nuke they use Utopia but it's not a system font, they bundle it. It really does not matter, the goal is just so that there is text displayed and not ugly squares


Same problem here. This should also be initialized to 1.


a couple of minor comments added


Commit includes

1. Details Fragment


I thought zzzzzzz implies sleeping :)) Thanks for the explanation, now it makes more sense why you attempted the alternative implementation :) :+1:


Sure, but `getFromFirst(index+i)` does that multiple times for large values of `index`, right?


TeamCity YaccConstructor :: YC.Core General Build [Build 394](http://teamcity.codebetter.com/viewLog.html?buildId=192110&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: error: pathspec 'src\FsYacc\YC.Tools.nuspec' did not match any file(s) known to git.   at Fake.Git.CommandHelper.gitCommand(String repositoryDir, String command)   at FSI_0002.Core.commonConfig@164-3.Invoke(Unit _arg1) in Z:\Builds\... Build time: 00:11:51


lgtm; wanna merge master first?


Ok, will use Arial on Mac/Win and Cursor/Sans on Linux.


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Ok thanks xylographe ;)


I corrected the initial position of the camera in the main menu and in the
game (looked at 1). Also corrected the cinematics rotation and position.
Now everything is moving as it should. I do not understand just how to play
one another Cinematic.

There is a slight error in the construction of the map. The coordinates of
all objects must be moved at 0.5f on X and 0.5f on Z.

P.S. I lay out the changes in my Fork soon.

2015-05-27 10:26 GMT+03:00 Toni Helenius <notifications@github.com>:

> I tried the first level also, I run it with the 2 camera sweeps it had
> (dungeon heart & good lord intro) in sequence and they were spot on. Just
> missed the little guy pacing there :) The starting coordinates are still
> something that need to be tweaked on, you can see it from the start menu.
> But we are right on track :) Thanks to ArchDemon.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tonihele/OpenKeeper/commit/cfa998e6808f6c550a49a934c7d44ae24c5a1ba3#commitcomment-11379499>
> .
>


Compaction can create files with more than 2B lines if configured that way. Which means, that deletion from these compacted files will always fail.


Fixed in 6c0982f739aeb07259ea64b24cefe60fd8d0e715, seems we pass the test as we "correctly" raise a `RangeError` now.


+1, tenants should not change and should be used in equality.


Also here the cast to double is missing.


I meant that I would have to go through all 300+ entries to repopulate the matrix, but I wrote a script for that yesterday and now just waiting for the results.


For really long method calls like this, I prefer to see the call done outside of the if:

```
  err := m.multiNode.ProposeConfChange(...)
  if err != nil {
    ...
  }
```


Thanks for watching as always :smile:


I think it is best practice to do `clearMockModules` in `afterEach`, if someone wants to add something to all tests he should do it in `beforeEach` like we did here and so he doesn't care that he gets cleared after each test.

That said, I don't mind removing those modules in `afterEach` as you suggest. Please send PR.


Fixed. I added a lot of `override` keywords, but it's a safe bet I missed more than this one.


Can we poll "basket look-up user" here just like we poll restmail?


Are we sure we need tenants on Conditions?  I would expect it would be accessed via the triggers and would get an "umbrella" tenant.  Or. do we actually have direct access to conditions?  And if we do, should we?


No worries! I love the product, and I'll continue to contribute. I just wanted to pout a little. :D


:)

If you're going with semantic versios, then remove attribute and just use 'version' below... I only kept this so that you have a way to still keep your custom version...
I don't recall if the build is using this parameter (I don't think it is).

Also, Don't recall if semantic version readers understand "double zeros"...


typo in `getBasicUserParameters`? Same for the restore listener


@jvasileff is right I think. This simply isn't going to ever work efficiently for sublists that wrap strings or linked lists. Perhaps we need to consider optimizing `sublist()` for this cases.


The fallback mechanism is gone from master as of today.


StringUtils.isEmpty()


:+1: Might also want to give this another update when React Router 1.0 is released.


No worries


Personally I think we should run far, far away from these definitions as soon as we can, but in this case "we" means "both VIP and 1622.2" and I realize that'll need to happen later. :)


I would, but it's not passing the tests atm. I will try to fix those first.


I foresee a change in the build that will "auto-magically" populate this from the package.json... so that you don't have to manage it in multiple places :)


Ahhhh yep, I had no idea what the c++ lambda syntax looks like, I'll give the those docs a look.

One more question on this: in the [`boost::adaptors::reversed`](http://www.boost.org/doc/libs/1_52_0/libs/range/doc/html/range/reference/adaptors/reference/reversed.html) docs I see example usage that includes the operator| being used as it is here, but operator| does not (appear?) to be overloaded on vectors. Where is the behavior for operator| in this context defineD?


Two general problems with the multithreaded-requests loader, I've only noticed so far:
1. The "downloads" container itself is not thread-safe.
2. Logic built on it isn't safe either. For example, in this commit - if the download is completed
between line 653 and 654 then 654 dereferences an interator to an unordered_map item
(I guess "first" is the key and "second" is the value) which has already been erased.
Same goes to lines 657-658.


Same comment as for Condition.  Dampening is only relevant under a trigger.  Do we need to explicitly have tenantId on Dampening?


Catch the checked `IOException` and `FileNotFoundException` within this method, and throw a `UserException` if they occur. In general we try to wrap checked exceptions within the unchecked `UserException` or `GATKException` as early as possible to reduce the burden on client code.


Здесь лучше использовать `find_by`, тогда не нужно будет писать `first`


и здесь и ниже тоже find_by


@ximinez The `manifest` script is calling this `master_secret`. I'll try to think of good terms for all these things and then change the scripts/config sections/docs. Maybe `Validator Master Keys` and `Validator Ephemeral Keys`.


Added to autoconf, so no longer an issue.  If the compiler does not have this function, then there will be one defined within jumbo.c


Use standard javadoc syntax for documentation of public methods (with `@argument`, `@return`, etc.)


Здесь нам нужны только айдишники? Если да, то лучше использовать `pluck`, если это возможно


What's the point of this block of code? setAuth doesn't seem to be used after being set...


I'll suggest changing "(master keys)" and "(ephemeral keys)" to "(permanent)" and "(replaceable)" respectively.


It should be on the one below this. Chosen doesn't use inlineEditPost. The admin scripts js does


Tip for finding where to put `override`:  Mark the underlying (often pure) virtual in the base class as `final`.  Compile.  The compiler will point out each declaration that overrides the virtual.  Manually inspect each one for `override` and add if necessary.  Remove `final` from the base virtual.


No clue. Probably was just test code or something, again I'd ignore it.


Just looked at the build script (Gruntfile) and its already setup to process a token named '@VERSION' and replace it with the value from the package.json...
SO here, just replace 2.00.00 (inside the single quotes) with @VERSION... Run a build and it "should" work. :)


ddfa


### ADDENDUM
1. For data types A without bottom or top element, you might want to define min and max on the subtype `Cons[A]` only:
   `def max[A](as: Cons[A])(order: A => A => Boolean) = ???`
2. In my comment above it would have been better to mention indiscrete orders instead of bad-founded.


Do we need the printStackTrace? :)


Also, the use of a `true` return value to indicate "saved to GCS" and a `false` return value to indicate "saved to local disk" is bad practice. One would expect a method like this to return `true` if the file was successfully serialized, and `false` if there was some error. Could you refactor?


I'm not really fond of this function -- you're doing 2 different things depending on whether there is a "panel" parameter or not. This looks like 2 different functions to me.


I totally missed that creationDatesType means this field group is generalizable to other types of events.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.182](http://teamcity.monogame.net/viewLog.html?buildId=7702&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


		@@ -1,3 +1,9 @@
+sudo: false
 language: node_js
 node_js:
+  - iojs
+  - '0.12'
   - '0.10'
+matrix:
+  allow_failures:
+    - node_js: iojs


Any specific reason to use array instead of concatenation?
And tbh, I think using lines longer than 120 characters is bad idea...


I'd keep "isCurrentConversation" with current behavior and add a "isConversationPanel" for the new behavior.


I just wish we could get these features without having to use the CLI


Good tip!


 language: node_js
 node_js:
   - '0.10'
-before_install:
-  - gem install sass


Should we clear the pluginfactdest after this run? Teardown doesn't happen until the end of the testcase.


Aaaand KBase maintenance has started...


<!DOCTYPE html>

             <title>Hello World</title>

Hello World


You seem to have taken out the 'loop' from here, so at the very least the function description should be adapted.


All test classes should ultimately extend from `BaseTest`


Low-level: why not make `Statement.status` public?

High-level: why are we hitting a conflict here anyway? What's wrong with `INSERT OR IGNORE` or otherwise solving this problem correctly?

Hitting SQL errors and needing to scan for strings is a pretty big sign that you're doing something wrong.


OK.


Are you sure subarray don't introduce memcpy here?


The course id is extracted from a string (URL) and then used to construct another string, so at the moment it's never an integer.  Should I convert it back and forth from string to integer instead?


Read's weird and doesn't show what's wrong.

What is the config output from rootNode.getNode("config", "blockCheats", "enabled"); ?


Would it be clearer if I switched this line for:
```ruby
  depends_on “cmake” => [:build, :run] # :run only because cmake needed by testbot in `brew test json-fortran`
```


@basarat I'm unable to access the `$cookies` module with `ng.cookies` as described [here](https://github.com/borisyankov/DefinitelyTyped/tree/b7b20944a68d86ea8704675506e7ed839f889c79/angularjs#definitions-modularized). However `angular.cookies` works.


Please don't leave commented code hanging around


Dat klopt, het is louter ter informatie dat één van die twee verschillende gedragsclusters dominant naar voren komt. Het is niet fout om dit te geven als extra info.


Hi,

I did this on GameState (loaded level 1), it mimics what the actual
triggers do on the level1 (when you open it in the editor you can see
these):

         // Do cinematic transition
         Cinematic c = new Cinematic(assetManager, app.getCamera(), new
Point(14, 28), "EnginePath1", rootNode);
         c.addListener(new CinematicEventListener() {
             @Override
             public void onPlay(CinematicEvent cinematic) {
             }

             @Override
             public void onPause(CinematicEvent cinematic) {
             }

             @Override
             public void onStop(CinematicEvent cinematic) {
                 // Do cinematic transition
                 Cinematic c = new Cinematic(assetManager,
app.getCamera(), new Point(15, 10), "EnginePath201", rootNode);
                 c.addListener(new CinematicEventListener() {
                     @Override
                     public void onPlay(CinematicEvent cinematic) {
                     }

                     @Override
                     public void onPause(CinematicEvent cinematic) {
                     }

                     @Override
                     public void onStop(CinematicEvent cinematic) {
                     }
                 });
                 stateManager.attach(c);
                 c.play();
             }
         });
         stateManager.attach(c);
         c.play();

On 27.5.2015 19:01, ArchDemons wrote:
> I corrected the initial position of the camera in the main menu and in the
> game (looked at 1). Also corrected the cinematics rotation and position.
> Now everything is moving as it should. I do not understand just how to
> play
> one another Cinematic.
>
> There is a slight error in the construction of the map. The coordinates of
> all objects must be moved at 0.5f on X and 0.5f on Z.
>
> P.S. I lay out the changes in my Fork soon.
>
> 2015-05-27 10:26 GMT+03:00 Toni Helenius <notifications@github.com>:
>
> > I tried the first level also, I run it with the 2 camera sweeps it had
> > (dungeon heart & good lord intro) in sequence and they were spot on.
> Just
> > missed the little guy pacing there :) The starting coordinates are still
> > something that need to be tweaked on, you can see it from the start
> menu.
> > But we are right on track :) Thanks to ArchDemon.
> >
> > —
> > Reply to this email directly or view it on GitHub
> >
> <https://github.com/tonihele/OpenKeeper/commit/cfa998e6808f6c550a49a934c7d44ae24c5a1ba3#commitcomment-11379499>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tonihele/OpenKeeper/commit/cfa998e6808f6c550a49a934c7d44ae24c5a1ba3#commitcomment-11389031>.
>

--

Yours Toni Helenius, ToniArts
http://personal.inet.fi/business/toniarts


On Android we simply use

```
Page already in your Reading List
```

for the UI string. Probably best to match here.


Should add a case that confirms different behavior one external_facts? returns false.


No specific reason. Just a person preference of using splitting the components with a "," instead of a "+". Having a plus everywhere  seems to kind of steal the focus from the shader code, but that's just how I see things.

And yes, it is a bad idea, you can split it.


Same: s/webpage/page


This seems to explain the reason why up-to-date checking didn't detect changes: https://github.com/gradle/gradle/blob/091db23/subprojects/core/src/main/groovy/org/gradle/api/internal/changedetection/state/CachingFileSnapshotter.java#L42-42
File's lastModified gets updated when the file is closed. The problem must have been caused by a missing quiet period in file watching.


Not sure why this is needed, but if you're moving it, wouldn't a constant go before a global variable?
Also, // is not correct comment for a constant at top-level.


@bmorris3 This may not be of interest to the casual user, but how will date information be stored in object `day` ? JD + timezone?


space after function!


bind_engine is the one design to handle any kind of authentication, bind_server was there for old compatibility


Perhaps, "The validation secret key, in contrast to the validator secret key, must be present in the config file."

I am noticing that I'm stumbling over the distinction "validator key" and "validation key".  You've done a good job of describing the difference.  But the two terms are hard to distinguish visually when I read the text.  Unfortunately I don't have a great suggestion for terms that look and sound more distinct.  So it may have to stay the way it is.  But I'll let you think about it.

Nice paragraph, by the way.


Shouldn't the route also be called `/sign-in`?


@michaelcahill suggested that, once #1943 is merged, we can use the background sync mechanism instead of forcing the sync here and waiting for it.  That is a great idea I will implement when all these pieces are merged.


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.59%25-red.svg)


"would be that" instead of "to be that" ? Missing ")" after "pressure component"


'missing_sprite_check' is always 'false' as you deleted the loop.


Ok, thanks.


71693606-CompilerWarnings1 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1666 of 1666 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


argv.rv is not allowed, main key should be single letter. I think V or R will do.


Yes, I'll make that clearer.


I mean poor. :D


Display looks like this in FML mod list now:

![](http://www.eq2.co.uk/screenshots/2015-05-27_17-22-08.png)


We should not shortcut Authentication by Authent or i would prefer Auth : more used


This is a Thorsten comment, I will add a new comment and credit him on the changelog.

I know what this is for its so we can create tmp files on suse platform I will make this suse specific.


'Value: '


justo


Hahaha.  delete-delete-delete.  Thanks for catching!


Try to always use the most appropriate type when passing collections to a method. In this case, if you're only going to iterate through the list of directories, use ```IEnumerable<string>```. If you actually needed to access each element by index or add elements to the list, then using ```IList<string>``` would be justified. But in this case, the input list is supposed to be read-only, so ```IEnumerable<string>``` is the right thing to use.


Probably a bug in my cherry-picking then.  I'll make sure I get it right when I do the final rebase and merge.


Needs doxygen comment


Checkout the master branch @naumanjkhan


Consider "validator key" -> "validator public key".


exemplo para o link não ficar dando erro!


@missedone Ah yes, good point. Fixed.


This code has been funded by Tuscany Region (Italy) - SITA (CIG: 6002233F59) and commissioned to Gis3W s.a.s.


71693606-CompilerWarnings1 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Probably a bug in my cherry-picking then. I'll make sure I get it right when I do the final rebase and merge.


Will be fixed in next push.


> It's a bit tricky to figure out when to mark an allocation as conservative vs
conservative-python; the approach in this commit is to mark all capi-originated
allocations as conservative, and then when we call PyObject_Init or PyObject_InitVar,
switch them from conservative to conservative-python.  I think this is more expensive
but safer than assuming that certain apis will always/never be used as object
memory.

is there any way tell if people miss the call to PyObject_Init/PyObject_InitVar, other than potentially adding asserts checking the allocation's type at every possible PyObject_* entry point?  Are extension modules likely to handcraft instances?


A similar comment as above applies here: use ```IList<Match>``` in the return type. That way, if you ever change your mind about the specific type of list that you use to implement this, you will have to change just the internals of this method and not all other places where the dictionary gets used.


agreed


 # jQuery Shorten

+### [Demo](http://web5.me/jquery/plugins/shorten/shorten.doc.html)
+
 This jQuery plugin automatically shortens single-line text to fit in a block or pre-set width while you can configure how the text ends. The default is an ellipsis  ("…", &hellip;, Unicode: 2026) but you can use anything you want, including markup.

 This is achieved using either of two methods: First the the text width of the 'selected' element (eg. span or div) is measured using Canvas or by placing it inside a temporary table cell. If it's too big to big to fit in the element's parent block it is shortened and measured again until it (and the appended ellipsis or text) fits inside the block. A tooltip on the 'selected' element displays the full original text.


Rewrote explination


I'm not a big fan of splitting this out this way. i.e. clearing the CacheClearable may no longer actually clear the cache.


Garbage


Good point, will change that


I think double underscore means "private", so I placed two


Would be good to have a change log entry as well.


You're using `file_put_contents()` though. It should just create a new file if one does not exist. It's a bad practice to have an empty pid file.


А я б зрабищ прыватнай и структуру таксама


you mean the normal `search_in_between()`? Yes I do test it, because there nested constructs aren't handled I uses in nearly all tests the same start and end.


`.where` returns an array-like object that does not have a `.destroy` method. try using `.find_by` instead


I guess this is the same again. Do we need tenant if it's already on the the Trigger?  Of course there may be some reason just from the cassandra perspective, it would be good to get jsanda's input.


71693606-CompilerWarnings1 (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1666 of 1666 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Don't forget to follow C# conventions (i.e. capitalize method names) in tests too


i mean the nested thing


Please add more assertions to your test to make it stronger


Garbage:   <a href="


For clarity's sake, you probably shouldn't create a local variable named the same thing as one of the function's parameters.. I would suggest renaming the local variable, as timestamp usually refers to a Unix stamptam


This is not the NES :p


@viomac You're doing a great job! Keep up the good work!


Same deal as the previous comment


Which defconfig are you using?


As you suggested it can interfere with special meanings when using two underscores. Will change...


Gabage:   target"_blank"


I test that also, `test_nested_search_in_between_same_pattern`, line 1252


It seems to me that that `updateNotification()` should never be run if it cannot actually update the notification.  Instead of silently failing, chatsecure should probably cache the change until it can update the notification.  Otherwise, display bugs are likely since the notification could get out of sync with the state.

It might also make the code clearer to just fold the code in `updateNotification()` into `networkStateChanged()`, since `updateNotification()` is only called once.  Then it'll be easier to see the whole process in a single view.


This introduces the bug reported at: http://synergy-project.org/forum/viewtopic.php?f=9&t=350&p=1053&hilit=package+type#p1053

I could work around it by running: `ln -s /bin/false /bin/dpkg` so synergy could run the dpkg command.


Consider "ThisServer" -> "ThisServersName".  Does the comment in the config need to be in quotes?


`downloads` is always only accessed from exactly one thread.
The only Knossos code running in a different thread than `Loader::Worker` operations is `decompressCube`.


Garbage: <p> is closed twice...


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Hmm.. I don't think they should be inside `export defaults`, that seems like a misuse of default exports.
Each one needs to be exported individually.

If you put `{ "stage": 0 }` into `.babelrc` file in the project root, you can just write this:

```js
export Renderer from './Renderer';
```

etc.


@xuantain ah i see! yes, if you add a new library to bower.json , you need to add it to the karma.conf.js
 good job!


цікавы спосаб, але я б кінуў выключэнне (падрабязна праходзіць іх можна і потым, а тут кінуць проста std::exception)


This and EndDate should be DateTimes as that's how they're used throughout.


TODO for me: figure out whether this behavior is good, and if so why.


Consider "This" -> "The master secret key"


No, that shouldn't be necessary


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.182](http://teamcity.monogame.net/viewLog.html?buildId=7702&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:19:17


Using American date format throws when not using a machine with that system culture set up.


validator/validation was a terrible choice. It needs to change. Unfortunately, doing this right touches the python test scripts, python signing/key gen code, as well as the C++ code so it's a non-trivial change. But I think it's worth doing. I'm leaning toward `Validator Master Key` and `Validator Ephemeral Key` as other documents refer to these.


splitting out `refreshSessionPresence()` makes it hard to follow the flow here.  Its only two lines of code, and not reused anywhere.


ah. The fact that you have those kind of line numbers is bad. Can we split up StringProcessing maybe?


<!DOCTYPE html>
<html lang="en">
<head>
       <meta charset="UTF-8">
       <title>SVG Gradients</title>
</head>
<body>
<svg id="mysvg" xmlns="http://www.w3.org/2000/svg" version="1.1" width="800" height="800" >
<defs>
     <linearGradient id="linear-test"
                         x1="1" y1="0" x2="0" y2="0">
	<stop offset="5%" stop-color="black"  />
	<stop offset="55%" stop-color="white" />
	<stop offset="95%" stop-color="black" />
     </linearGradient>
     <radialGradient id="radial-test"
                              cx="0" cy="0" r="1" fx="0" fy="0">
	 <stop offset="5%"   stop-color="black" />
	 <stop offset="55%" stop-color="white" />
	 <stop offset="95%" stop-color="black" />
     </radialGradient>
     </defs>
     <rect x="0" y="50" width="375" height="375" fill="url(#linear-test)" />
     <rect x="400" y="50" width="375" height="375" fill="url(#radial-test)" />
     </svg>
</body>
</html>


Right, not sure why I moved that since it is only used in MainLoop().


Open a bug, I wouldn't do this in this PR^^


There's always one I miss...Thanks.


1 byte = 8 bits = 0-255, not 0-511. Does this affect precision in a significant way?

A more complex but memory-efficient encoding scheme might be as follows:
* First, store the temperature in full precision (16 bits, whatever).
* For future samples, store only the difference between the previous reading and the current reading, as a single byte.
   * If the change in temperature is too large to represent in a single byte, write 0xFF (255) followed by the full-precision temperature.

In most situations, the temperature change will be small over a short period of time, so this scheme should allow better precision with lower data rate, assuming the temperature doesn't change quickly. If the temperature does change rapidly, it becomes less efficient than the other encoding scheme.


`.map(neighbour::getRight)` :wink:


This is all a bit magic.

Other code changes 'next_mode', here you detect the change, and call the object, giving it its own data as parameter! Inside 'SwitchMode', the 'next_mode' is reset.
Please make up your mind who owns 'next_mode', and let the owner set, reset, and check the value.


This should be public, as should the interfaces and implementations to keep as standard


There should only be 1 action method here, which is the get with the filter applied


I think the goals is to store all times as `astropy.time.Time` objects always, and the comment on line 103 makes it sound like the argument will be interpreted as input to an `astropy.time.Time` object. Maybe @ejeschke intends to take that date as local time input into an `astropy.time.Time` object, then use `pytz` to convert to UTC?


Good point. I'll have to move this into the 'game' loop in some form.


You're right. I will remove it.


Given the amount of _game accesses, it looks like this loop belongs inside _game?


Minor typo. repro = repo and then it's perfect.


Could those new dynamic_casts be replaced by static_casts? Everything compiles for me also with static_cast with MSVC12. Unfortunately they break boost::future when used in a project with RTTI turned off, which worked fine in Boost 1.57.


+1 same here

```ruby
Cart.create token: SecureRandom.uuid
```

results in
```
ERR Error running script (call to f_d84093efbb10df1c5995c6b0e7340520973b306d):
@user_script:34: user_script:34: Bad data format in input.
```

thanks @slowernet, you saved me a lot of time debugging


saw approval from cmeiklejohn
at https://github.com/basho/riak_kv/commit/19e8ff31163ea3fe63a5053629978a1f4ad7ce6d


merging basho/riak_kv/bugfix/jrd/backend-test = 19e8ff31 into borshop-integration-1127-bugfix/jrd/backend-test


basho/riak_kv/bugfix/jrd/backend-test = 19e8ff31 merged ok, testing candidate = 992388c0


What guarantees QNetworkReply::finished of cube N not be preempted by the startDownload of cube N+1?


Don't results into the query object, use ViewData for this.


Is this something we should do everywhere (including in conditionally-set background images?)


This line doesn't seem to do anything with "changing mode"


why?


Don't ignore the error here.


the callbacks are not immediate and not from another thread
they are dispatched by the event loop


An alternative style is based on the same rationale as dangling parenthesis:
if you have a one liner:
```scala
/** This just does it. */
def doIt()
```
You then want to add more:
```scala
/** This just does it.
 *
 *  Really, no need to think!
 */
def doIt()
```
see - you just add, don't change what is there


More or less. If you look at Index there's a declaration at the top
extends layout
block content

and on Layout.jade there's a section that says content. When served the two
are combined. So things that belong on every page should be in the layout.
Other specific sections should be in their own jade sections.

On Wed, May 27, 2015 at 11:06 AM Couch3ater <notifications@github.com>
wrote:

> Had some time before a meeting / lunch -- question on how you're breaking
> up the Jade nonsense. Is this how you're breaking up the files? Just wanna
> clarify for moving forward.
>
> Index -> page elements, text, etcetera
> Layout -> JS, references, head, etcetera
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Dragonegger2/fileFu/commit/43cb619619ce6bb4ddfc6bb67eea6c1264d71dac#commitcomment-11387731>
> .
>


Refer to [ATMO-831].


Comparing floats for equality seems dangerous


Yes, @MickCrozier.  I have made the changes as requested. I am travelling
and will be able to push changes in another 8-10 hours! Thanks for the
review!


The message states that there's a bug, but doesn't say what the bug is. Mind elaborating @cferris1000 ?


The build of that Dockerfile says:
```
No package qt3-devel.x86_64 available.
No package mpfr-devel.x86_64 available.
```


Unless there's a specific reason not to, always use [Post/Redirect/Get](http://en.wikipedia.org/wiki/Post/Redirect/Get) when building out admin functions. In this case though as you're not modifying anything on the server, you'd be using a GET form in the UI and getting rid of this method.


@hjmjohnson I believe that this is the last of the modules that needed to be marked as a shared library


This should be in a JS file and referenced in the view.


Awesome - thanks :).


We we also need to call the ValidateUtil.setDisableValidation(prevVal) above? It will be called on line 157 below.


#14 update title


That's actually the kind of reasoning I am looking for. Will apply.


TeamCity xBIM :: Xbim Geometry :: Release [Build 75](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1756&buildTypeId=XBIM_XbimGeometry_Release) outcome was **UNKNOWN**
Summary: Canceled (Compilation error: Xbim.Geometry.Engine\Xbim.Geometry.Engine.vcxproj (new); Updating D:\TeamCity\buildAgent\work\62169855e3f99413) Build time: 02:05:09


TeamCity xBIM :: Xbim Geometry :: Release [Build 76](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1762&buildTypeId=XBIM_XbimGeometry_Release) is now running


https://github.com/olear/openfx-arena/commit/809e7afe3925d5b77c350045e94cd4b4827a8bb1

Ok?


Do we need the two lines above fail?


make this `except Exception as ex:` and then print the exception so we know what went wrong


You're right, the new nick is preceded by a colon. Curiously, that's only the case on Freenode, the standard doesn't include a colon. However, the host is still not mentioned (again), so that the first split will always return the complete `newnick`.


It's not true that you don't change anything on the first line @InTheNow .
You removed the trailing `*/`, so that the line will no longer be blameable to the original author.
As a result I don't think it's worth the ugliness of the initial line.


Check if string ends with 'percentile'?


TeamCity xBIM :: Xbim Essentials :: Release [Build 52](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1757&buildTypeId=XBIM_XbimEssentials_Release) is now running


TeamCity xBIM :: Xbim Geometry :: Release [Build 76](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1762&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:24


meaning, even though the qnam downloads are running in separate threads, the finished signal is connected to a (lambda) slot in the worker, where emissions are queued and blocking, right?


71693606-CompilerWarnings1 (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1666 of 1666 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi @jef-n,
I am not sure whether it is a problem with my machine, but I am getting an error on building the master version and it seems to be related to this changes:

```
[  1%] Building CXX object src/core/CMakeFiles/qgis_core.dir/qgsslconnect.cpp.o
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp: In static member function ‘static int QgsSLConnect::sqlite3_open(const char*, sqlite3**)’:
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp:28:44: error: ‘spatialite_alloc_connection’ was not declared in this scope
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp:38:40: error: ‘spatialite_init_ex’ was not declared in this scope
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp: In static member function ‘static int QgsSLConnect::sqlite3_close(sqlite3*)’:
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp:52:48: error: ‘spatialite_cleanup_ex’ was not declared in this scope
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp: In static member function ‘static int QgsSLConnect::sqlite3_open_v2(const char*, sqlite3**, int, const char*)’:
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp:61:44: error: ‘spatialite_alloc_connection’ was not declared in this scope
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp:71:40: error: ‘spatialite_init_ex’ was not declared in this scope
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp: In static member function ‘static int QgsSLConnect::sqlite3_close_v2(sqlite3*)’:
/home/sam/pacchetti_gis/QGIS/src/core/qgsslconnect.cpp:85:48: error: ‘spatialite_cleanup_ex’ was not declared in this scope
make[2]: *** [src/core/CMakeFiles/qgis_core.dir/qgsslconnect.cpp.o] Error 1
make[1]: *** [src/core/CMakeFiles/qgis_core.dir/all] Error 2
make: *** [all] Error 2
```

This is happening on Debian Wheezy.with SL4.0.0.
Thanks.


one question. to use this properly do we have to have anthing intalled on pc? Thanks


It looks like the implemented version of [`get_date` in obsplan](https://github.com/ejeschke/obsplan/blob/master/obsplan/entity.py#L233) by @ejeschke is parsed directly to a `datetime` object, then manipulated for time zones. I'd imagine we'll do something similar with the equivalent `astropy` tools.


Cool.

On Wed, May 27, 2015 at 6:46 PM, Rainer Gerhards <notifications@github.com>
wrote:

> 2015-05-27 15:16 GMT+02:00 Janmejay Singh <notifications@github.com>:
>
> > Ok, I'll shorten it. :-)
> >
> >
> It's already merged. And as I wrote, this one seems to be short enough...
> So no need to do anything.
>
> Rainer
>
>
>
> > --
> > Regards,
> > Janmejay
> >
> > PS: Please blame the typos in this mail on my phone's uncivilized soft
> > keyboard sporting it's not-so-smart-assist technology.
> >
> > On May 27, 2015 5:45 PM, "Rainer Gerhards" <notifications@github.com>
> > wrote:
> >
> > > I've seen that comment as well and also ignored it. But when I made
> "make
> > > distcheck" work last week, this was one reason for failure. So while I
> > > don't know why, it looks like the 99 char limit is vital for "make
> > > distcheck".
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/janmejay/rsyslog/commit/9441bbd67f000625b8b4b9e7c697f1d7a70cf3d7#commitcomment-11384242
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/janmejay/rsyslog/commit/9441bbd67f000625b8b4b9e7c697f1d7a70cf3d7#commitcomment-11385301
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/janmejay/rsyslog/commit/9441bbd67f000625b8b4b9e7c697f1d7a70cf3d7#commitcomment-11385318>
> .
>

--
Regards,
Janmejay
http://codehunk.wordpress.com


Since you can pass arbitrary floats, maybe try 99.9 here too.


To solve the chicken and egg problem where the python wrapper isn't created in the correct sequence.


May be I'll add a test to ensure every file in codebase can be refereed to
in less than 99 chars.

On Wed, May 27, 2015 at 10:14 PM, singh.janmejay <singh.janmejay@gmail.com>
wrote:

> Cool.
>
> On Wed, May 27, 2015 at 6:46 PM, Rainer Gerhards <notifications@github.com
> > wrote:
>
>> 2015-05-27 15:16 GMT+02:00 Janmejay Singh <notifications@github.com>:
>>
>> > Ok, I'll shorten it. :-)
>> >
>> >
>> It's already merged. And as I wrote, this one seems to be short enough...
>> So no need to do anything.
>>
>> Rainer
>>
>>
>>
>> > --
>> > Regards,
>> > Janmejay
>> >
>> > PS: Please blame the typos in this mail on my phone's uncivilized soft
>> > keyboard sporting it's not-so-smart-assist technology.
>> >
>> > On May 27, 2015 5:45 PM, "Rainer Gerhards" <notifications@github.com>
>> > wrote:
>> >
>> > > I've seen that comment as well and also ignored it. But when I made
>> "make
>> > > distcheck" work last week, this was one reason for failure. So while I
>> > > don't know why, it looks like the 99 char limit is vital for "make
>> > > distcheck".
>> > >
>> > > —
>> > > Reply to this email directly or view it on GitHub
>> > > <
>> >
>> https://github.com/janmejay/rsyslog/commit/9441bbd67f000625b8b4b9e7c697f1d7a70cf3d7#commitcomment-11384242
>> > >
>> >
>> > > .
>> > >
>> >
>> > —
>> > Reply to this email directly or view it on GitHub
>> > <
>> https://github.com/janmejay/rsyslog/commit/9441bbd67f000625b8b4b9e7c697f1d7a70cf3d7#commitcomment-11385301
>> >
>>
>> > .
>> >
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/janmejay/rsyslog/commit/9441bbd67f000625b8b4b9e7c697f1d7a70cf3d7#commitcomment-11385318>
>> .
>>
>
>
>
> --
> Regards,
> Janmejay
> http://codehunk.wordpress.com
>

--
Regards,
Janmejay
http://codehunk.wordpress.com


Seems like correct URL to packaging artifacts should be `/docs/packaging-artifacts`? Thanks!


For the release plugin *ALL* jdoc annotations must have some sort of description.  @param, @returns, @throws...  For example: We need something like @throws Exception any problem.


TeamCity xBIM :: Xbim Essentials :: Release [Build 52](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1757&buildTypeId=XBIM_XbimEssentials_Release) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:35


TeamCity xBIM :: Xbim Geometry :: Release [Build 77](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1758&buildTypeId=XBIM_XbimGeometry_Release) is now running


What's the behaviour if percent falls outside 0..100?


Seems like no need space before period.


Prior to that(,)


Looks good.  Definitely an improvement.  I left some comments only for your consideration.  What you have would be good enough.

:+1:


Percentile and Median should be lowercase here. We're not exporting these routines anywhere.


That issue should be easy to fix, thanks for noting it.


All righty - pull request #402 is now merged into the Unified branch.  The changes I made were in module references (to reflect the new structure of Unified) and the addition of .mli signatures.

However, because the katnetic command-line has been removed in this branch, there's currently nothing calling the new code.


TeamCity xBIM :: Xbim Geometry :: Release [Build 77](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1758&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:29


TeamCity xBIM :: Xbim Geometry :: Release [Build 78](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1759&buildTypeId=XBIM_XbimGeometry_Release) is now running


<!DOCTYPE html>
<html>
<head>
         <title>Audio</title>
</head>
 <body>
           <audio controls>
         <source src="vincent.mp3" type="audio/mpeg"/>
         <source src="vincent.ogg" type="audio/ogg"/>
       <object type="application/x-shockwave-flash"   data="media/OriginalMusicPlayer.swf" width="225"
                 height="86">
   <param name="movie" value="media/OriginalMusicPlayer.swf"/>
   <param name="FlashVars" value="mediaPath=vincent.mp3" />
  </object>
  </audio>
</body>
</html>


+1
I am in favor of decomposing this work. I will not have a chance to submit my work on MCO until early next week.


Need space betwell Chinase character and English words for  readability.


There is the general rule of indentation of two spaces, but it is common to have 4 if line breaking. So this would become:

```scala
class Foo3[Rdf <: RDF](
    foo: String,
    bar: String,
    baz: String
)(implicit
    ops: RDFOps[Rdf]
) {
  def doit:Int

  def doit():Unit
}
```

By adding some methods, the spacing makes the distinction clearer


We're currently testing the return value with the FAILED() macro, but this particular error code doesn't work with it since it's positive.


Can you rename all of these to IGNORE (or the tox ones that are named IGNORE to EMPTY)?


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2065


TeamCity xBIM :: Xbim Geometry :: Release [Build 78](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1759&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:50


TeamCity xBIM :: XbimWebUI :: Build [Build 55](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1760&buildTypeId=XBIM_XbimWebUI_Build) is now running


Seems like no need space before period.


Wrong:
&lthtml:br
needs to be
<html:br


"Mode" bothers me somewhat, it expresses a passive concept to me, you are in a mode, and you can stay in it without necessarily doing anything. The values of the enum however express actions, things that are being done.
"Switch" is also something active to me.

I would name it something more active, eg "HighLevelAction", or "HighLevelGameAction". There are probably better names though


Don't check compiler. Instead using `needs :openmp`


Awesome! :)


Can you please pull and run make V=1 wpe-reconfigure ? Please paste the output in a gist or pastebin.


Should we expose this as https://graphite.readthedocs.org/en/0.9.13-pre1/functions.html#graphite.render.functions.nPercentile too?


Should be faster to copy as a dense instead, since you're immediately turning it into an array. I think there's a function for that.


TeamCity xBIM :: XbimWebUI :: Build [Build 55](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1760&buildTypeId=XBIM_XbimWebUI_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:41


TeamCity xBIM :: XbimExchange :: Build [Build 348](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1761&buildTypeId=XBIM_XbimExchange_Build) is now running


Maybe escape `@` with backticks?


Typo: callees


Nice I approve.


Needs Doxygen

"Game" seems too generic, the entire 50K lines is 'game'.  In line with above, 'HighLevelControl'?  GameControl is also feasible


fixed and commited


IIUC, your analysis show that a "change" action removes the symlink and the proposed solution is to execute the rule on all actions.

I don't know much about how udev works, but could this solution race in case a device mapper entry is being removed and another one added (with the same minor) immediately after?

Meaning, the old dm goes away and triggers the rule (since 'action' is no longer limited it to 'add'). Then a new dm comes in reusing the minor. When the first rule executes, could it recreate the symlink for the wrong block device?

You also have a few typos on the commit message (e.g "check a corresponding m-* device is created").


No, it says "doing it the old ways won't hurt much".

On Thu, May 28, 2015 at 1:41 AM, Joe Maples <notifications@github.com>
wrote:

> The message states that there's a bug, but doesn't say what the bug is.
> Mind elaborating @cferris1000 <https://github.com/cferris1000> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android_libcore/commit/4d46de25bdb6d3b8150612a49849e251dcfcb035#commitcomment-11389875>
> .
>


Needs Doxygen


@aldeed why do we need a separate lint file per package? Can we just have one in the root?


@Mumfrey

Sometimes its the small things that count. Nice job :).


I think I prefer the 2 char indent. The 4 char indent seems a bit lost. One feels like it should rather be indented with the class name.

If one has to have a compromise I am always surprised that nobody thinks of 3. It is more visible than 2, and consumes less space than 3. This is what it would look like:

```scala
class Foo3[Rdf <: RDF](
   foo: String,
   bar: String,
   baz: String
)(implicit
   ops: RDFOps[Rdf]
) {
   def doit:Int
}
```
But looking at it I prefer 2 in this case. ( In lisp 3 makes more sense )


Since turning off validation is generally discouraged,
How about not doing these three lines. And instead, let the bulk data import module be the one to disable validation as it starts running, then enable it afterwards. Or do you have a use case where the user interface needs to turn off validation?


<audio controls>
  <source src="vincent.mp3" type="audio/mpeg"/>
  <source src="vincent.ogg" type="audio/ogg"/>
  <object type="application/x-shockwave-flash" data="media/OriginalMusicPlayer.swf" width="225" height="86">
   <param name="movie" value="media/OriginalMusicPlayer.swf"/>
   <param name="FlashVars" value="mediaPath=vincent.mp3" />
  </object>
  Download this lovely song and wish you all the best!
</audio>


If I have little slivers of spare time when I can't usefully achieve anything more useful I try to fill it with things like this, it's nice to add polish wherever possible.


I think that the important distinction is that we are assigning specific semantics to the appearance of the header field in requests.


TeamCity xBIM :: XbimExchange :: Build [Build 348](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1761&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:03:38


If this class is the owner, add an inspect, and 'set' method?

Having code change this from all over the place is probably a bad idea. eg something sets it to 'quit' and another to 'load sgame' or so?


<audio id="player" src="vincent.mp3"></audio>
<div>
<button onclick="document.getElementById('player').play()">Play</button>
<button onclick="document.getElementById('player').pause()">Pause</button>
<button onclick="document.getElementById('player').volume += 0.1">Vol+ </button>
<button onclick="document.getElementById('player').volume -= 0.1">Vol- </button>
</div>


Nice work. I'll watch you tomorrow :)


@kristopolous You should check the added sentence.


The ugliness is a subjective notion. The decision process should be the following:

1. does the pattern respect consistency?
2. does it make things easier to read/understand?
3. is it widely used? --> please provide references
4. last resort is the status quo i.e. latest code I pushed

Also @bblfish has a point re: the trailing slash gets removed after the change.


make this a nice accessor, also passing the filename?


Is the space between '(' and '{' important? Here is what it looks like without the space.

```scala
class Foo3[Rdf <: RDF](
  foo: String,
  bar: String,
  baz: String
)(implicit
  ops: RDFOps[Rdf]
){
  def doit:Int
}
```


As above


it’s not even specified that qnam does it
the reply object is also owned by the `Loader::Worker` thread and the connect therefore also ensures the execution to be in this thread
emissions are not always queued (i.e. abort runs the finished signal connected slots immediately), but since it runs in the same thread it’s blocking


Will need a second test for general input: `NormalFormGame([A, B])`.


No harm in adding a 3 by 3 test also.


Hi, thanks for the commit. I was just about to post this. I'm having a problem in:
@Html.RenderRequireJsSetup

Cannot convert instance argument type 'System.Web.Mvc.HtmlHelper<dynamic>' to System.Web.Mvc.HtmlHelper.

Any ideias on what's about?


@bitglue I noticed this and the corresponding `manage_own_credentials` policy. Nice work there.

One follow-up suggestion I have is that perhaps it would be prudent to keep extending the policy generator approach in `services-tools` so that we have one authoritative source of truth and a simple way to install policies.

I am also guilty of adding 'Developers-PassRole' in a similar manner. This looks like it will get out of hand quickly.


Class arguments, methods, and val/vars, all have the same weight here. There is no good reason to use sometimes 4, sometimes 2. Because 2 is common, we should stick to 2.


Done: 9adc6243e552cc92193699743ff4128bd356c762


but if immediate execution "steals" the CPU when it's already modifying/relies-on- a container, then it doesn't really matter that technically the thread ID is the same. The operations must be atomic (as in the slot emission level) otherwise the problems I wrote above still holds.


All of those are subjective.
What consistency criteria do you want to select?
It is widely used in all of Java land, and this is a Java notation.
And a quick look at Scala just reveals this: https://github.com/japgolly/scalajs-react/blob/master/monocle/src/main/scala/japgolly/scalajs/react/MonocleReact.scala#L34

Last resort should be what we have in the repository.


This should be `$mysql::server::package_name`


71693606-CompilerWarnings1 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (636 of 636 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.32%25-green.svg)


that’s just not possible


@MarceloGouveia77, agora caiu no problema de você retornar um inteiro, por exemplo, ````ESTRUTURA_NAO_INICIALIZADA```` enquanto a função espera um int*. Duas alternativas: (i) recebe o código de erro via parâmetro; ou (ii) retorna NULL em todos os casos de erro. Abaixo, implementei a solução (ii):
````c
int* obterVetor(ListaEnc* lista) {
    if (lista == NULL)
        return NULL;
    if (estahVazia(lista))
        return NULL;
    int *v = malloc(sizeof(*v) * lista->tam);
    if (v == NULL)
        return NULL;
    No *aux = lista->inicio;
    int i = 0;
    while(aux != NULL) {
        v[i] = aux->item;
        aux = aux->prox;
        i++;
    }
    return v;
}
````


I'm not sure whether using the end event to get the current track would be reliable. The `"fm:player:play"` event is fired when a track starts playing, so perhaps we should get the current track then and just clear the current track on `"fm:player:end"`?


Nitpicking: this could be split to two commits and the commit message could be more descriptive (what did you refactor?) :sos:  (No action needed)


No, this compound key works nicely, since queries always use the pt_tracker_id and seq together(ie. never do a query with the seq alone). Some may argue it could even be a primary key, but I wouldn't go that far.


This should be tested, what happens if 'lp-' is called for a non zero sum game? An exception should be raised...


I believe it's about consistency. We always have a space before `{`, whether it is a `(` or a word or something else.


R=CC[a11, a12, a13, a21, a22, a32]


Add documentation for how it differs from ``getTotalRowCount`` and ``getPosition``


fast-forwarding develop to borshop-integration-1127-bugfix/jrd/backend-test = 992388c0


Oh this answers my comment on the other commit!


Done


I'd probably just take an iterator pair, rather than taking the whole vector by value.  As it is, I'm not actually sure what happens when this gets called recursively.  Technically the vector end you're comparing with isn't related to the original vector


<video controls width="480" height="288" >
  <source src="media/html5iscool.mp4" type='video/mp4; codecs="avc1.42E01E, mp4a.40.2"' />
  <source src="media/html5iscool.ogv" type='video/ogg; codecs="theora, vorbis"' />
  <source src="media/html5iscool.webm" type='video/webm; codecs="vp8, vorbis"'/>
</video>


By "consistency" I meant "the style applies with as few exceptions as possible".


HI Eiden - First of all I would like to apologies that since I'm not able to find any help doc for setting up Jersey Source Code in my local machine; I'm asking you question in here.

I have been trying to import the Jersey Source code in my local machine. I have done a clone from GIT and forked the same. I get compilation errors related to LocalizationMessages class import.

NOTE: Cloned the master branch and trying to import the project as Maven-Project. Looking for the latest version of Jersey Source code.

Any kind of help is truly appreciated and please help and advise. Thanks.

Thanks,
Ved Jha


When you pull the package into /packages folder to work on it or to use an unpublished version, it might use different jshint rules and cause errors. (Which is what happened to me, causing me to do this.) :)


not sure if this is a copy paste from before, but shouldn't this check for all negative values?


update simpleregression


good point!


What does `this` refer to?  `rule`?


Here you go https://gist.github.com/flyandi/3100bc99c83c9ff039ed

I cut the process after repeating over 10 times the cmake process.


LGTM.


we should use the data_view primitives here, rather than memcpy


Where does/will this get used?


I think it's ok because the directories are independent, and we either use one or the other in this block (so we're not going to leak state from line 92 to line 96 for example.


No big deal ;-)

On 27 May 2015 at 08:23, Martijn Bastiaan <notifications@github.com> wrote:

> @wva <https://github.com/wva> Oh haha, yes, I meant @vanatteveldt
> <https://github.com/vanatteveldt>. Sorry!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/amcat/amcat/commit/4d30ad1462f99dfa9d9a050e4374430188699b66#commitcomment-11378756>
> .
>


Good info. I think http://docs.strongloop.com/display/public/LB/Operation+hooks#Operationhooks-Operationhookcontextobject could have more detail on it. Will be working it.


Makes sense, I'll add that.


yes, but here there was a claim of consistency across notations.

> ... is based on the same rationale as dangling parenthesis...

But a comment is not a dangling parenthesis. A parenthesis is 1 char long, and a comment start is 3 chars long. A parenthesis is not repeated on every line, a comment has a `*` on every line.  So I don't think there is much point trying to try to be consistent between such radically different constructs.


@popcornmix not quiet there yet ... :+1:

http://pastebin.com/MA8XJQHM

this is on wetek play - doesn't seem to like the shader - what is stupid about it is that i can't select any other presets (settings dialog just comes up empty). Not sure if the latter is related to the shader compile error or due to something else though.


That looks OK


no c style casts


<video controls width="320" height="240">
<source src="media/html5iscool.mp4" type='video/mp4; codecs="avc1.42E01E, mp4a.40.2"' />
<source src="media/html5iscool.ogv" type='video/ogg; codecs="theora, vorbis"' />
<source src="media/html5iscool.webm" type='video/webm; codecs="vp8, vorbis"'/>
<object width="320" height="240" type="application/x-shockwave-flash" data="media/flowplayer-3.2.5.swf">
   <param name="movie" value="media/flowplayer-3.2.5.swf" />
   <param name="allowfullscreen" value="false" />
   <param name="flashvars"
value='config={"clip": {"url": "html5iscool.mp4", "autoPlay":false, "autoBuffering":true}}' />
</object>
</video>


You either didn't pull buildroot git master or didn't use the V=1 option.


removed https://github.com/sphereio/sphere-product-sync/commit/cf4379456dd06f8d142b4ee36d4e768217eef569


OK, we can do this for now, but I think it would be good to find a way to avoid having so many copies of this in the future.


updated https://github.com/sphereio/sphere-product-sync/commit/cf4379456dd06f8d142b4ee36d4e768217eef569


`CompilerSelectionError` and  `ResourceMissingError`


why do we do this?


ah yes, I should have jumped to this after the 3rd try. 👍


Hello, can you give me a snippet of the code that's not working?


Let me repull the entire thing again..


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


setting a watcher is a more robust way to handle things. 👍


> yes, but here there was a claim of consistency across notations.

Sorry. I didn't mean "across notations" but "given one item" e.g. one-line comment **or** multi-line comment **or** multi-line collection **or** etc.


DataRange has a read<BSONObj>() specialization now.  Worth switching over to


Filter all merged branches from all remotes by target's remote.  Do not remove target itself.


doh. I'd neglected this bit.


please double-check nginx settings.  I have no idea how to set these.


also can this be correct?

http://pastebin.com/8My8Awip

shouldn't there be a linkage to something like an gles lib?


Not so nice, forgot to remove a couple of lines from logNullStash(). Recommited.


Oops.. will fix this.


Seems like actions are called by the [act function](https://github.com/Hypertopic/AAAforREST/blob/6579a57059804b0b2095654b9839162abc77391a/app/proxy.js#L28) which creates a `scope` object to be used as `this`. This call simply transfer this same `scope` to `handleSesionRequest` function, but give `site.sessionHndler` as second parameter.

Maybe is there a shorter way to do that ?


Yes, I found the decision to remove it after I ran into the issue of
broken links to it. If you want to keep the decision, you can change
"value" with just "value" to complete the cleanup.

Michael

On 27/05/2015 11:20 AM, Joseph Scheuhammer wrote:
>
> Never mind me, @michael-n-cooper
> <https://github.com/michael-n-cooper>. I'm just slowly working up
> through history, and just saw:
> 353b8fb
> <https://github.com/w3c/aria/commit/353b8fb70e6f57846bbad329e4bd245a53bd5c3f>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/w3c/aria/commit/9bdc7c326b1ddd1ffcdc6e3e49749ae452529044#commitcomment-11388052>.
>


this was probably unnecessary, I just did it.


This line can be simplified to `if (form_change || spellData.SpellCharges < 0)`


And I agree (without really checking carefully) that most projects seem to align with @bblfish's remark re: multi-line comments.


cmd's a const rvalue ref.  This std::move is just keeping it there.  You'll need to take CommandData by value, or non-const && if you want to move from it


Added:
- [auto-rename package](https://github.com/clemos/haxe-sublime-bundle/wiki/Refactoring#auto-rename-typepackage)
- [rename/move module/package](https://github.com/clemos/haxe-sublime-bundle/wiki/Refactoring#renamemove-modulepackage)


mhhh

-- checking for module 'glesv2'
--   package 'glesv2' not found

i wonder how this even linked then? *wonders*


@jcansdale do please open an issue so we can move forward on this ASAP.  The stack makes it pretty clear where the failure is, however I'm still not clear on how/why this fails.  Can you point us to a repro solution, and exact steps to cause the crash?

@enricosada adding some exception handling might be the right fix but I'd like to understand the root cause better first


Оказывается всё будет отлично!


Might as well merge the bool assignment and the if


AddressSpace is a collection object not a primitive type, I guess the column shows [Array]/[Object] in this case


The order we call super doesn't really matter. log is always called after the query.


DONOT BREAK THE LICENS AGAIN!!  WELL GEt SHUTEN DOWN


This also fixes issue when `ssh_config` is filled in with `sshd` options, making ssh client fail


I see. Thx.


Not sure if the copy is what you want


It may be exactly simple for you, however,  no however. It is high time to let those who lauth at me shut up.This is my style.


std::move is doing anything again


s/an/and/ ?


It's copy pasta from the existing message port, it's entirely possible this isn't correct


"on SUSE platforms the service_del_preun macro would do  this anyway" ... I'd prefer that this be conditionalized behind an "`%else`" in that case.


From all branches from all remotes select branches with remote equal to target's remote.  Do not delete target itself.


Changed this logic. I have no strong opinion here.


@minggo @hugohuang1111 @ricardoquesada This pull request corrupts the checked out git repo. Since tools/framework-compile already exists, copying external/framework-compile to tools/framework-compile causes a change in git status since the tools/framework-compile files are changed. Why are we copying these files? Do we need to delete the files in  the existing tools/framework-compile folder from the repo?

How to reproduce

git clone https://github.com/cocos2d/cocos2d-x.git
cd cocos2d-x
git checkout v3
git status (everything is fine)
python download-deps.py (version 56)
git status

	modified:   tools/framework-compile/bin-templates/cpp-template-default/Classes/AppDelegate.cpp
	modified:   tools/framework-compile/bin-templates/cpp-template-default/Classes/HelloWorldScene.cpp
	modified:   tools/framework-compile/bin-templates/cpp-template-default/Classes/HelloWorldScene.h
	modified:   tools/framework-compile/bin-templates/cpp-template-default/cocos-project-template.json
	modified:   tools/framework-compile/bin-templates/cpp-template-default/proj.android/jni/Android.mk
	modified:   tools/framework-compile/bin-templates/cpp-template-default/proj.win32/HelloCpp.sln
	modified:   tools/framework-compile/bin-templates/cpp-template-default/proj.win32/main.cpp
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-landscape/HelloCpp.ccs
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-landscape/HelloCpp.cfg
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-landscape/HelloCpp.udf
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-landscape/cocosstudio/MainScene.csd
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-portrait/HelloCpp.ccs
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-portrait/HelloCpp.cfg
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-portrait/HelloCpp.udf
	modified:   tools/framework-compile/bin-templates/cpp-template-default/res-portrait/cocosstudio/MainScene.csd
	modified:   tools/framework-compile/bin-templates/js-template-runtime/.project
	modified:   tools/framework-compile/bin-templates/js-template-runtime/cocos-project-template.json
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.android/build-cfg.json
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.android/jni/Android.mk
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.win32/HelloJavascript.sln
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.win32/build-cfg.json
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.win32/main.cpp
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.win32/stdafx.cpp
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.win32/stdafx.h
	modified:   tools/framework-compile/bin-templates/js-template-runtime/frameworks/runtime-src/proj.win32/targetver.h
	modified:   tools/framework-compile/bin-templates/js-template-runtime/index.html
	modified:   tools/framework-compile/bin-templates/js-template-runtime/main.js
	modified:   tools/framework-compile/bin-templates/js-template-runtime/project.json
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-landscape/HelloJavascript.ccs
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-landscape/HelloJavascript.cfg
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-landscape/HelloJavascript.udf
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-landscape/cocosstudio/MainScene.csd
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-landscape/res/MainScene.json
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-portrait/HelloJavascript.ccs
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-portrait/HelloJavascript.udf
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-portrait/cocosstudio/MainScene.csd
	modified:   tools/framework-compile/bin-templates/js-template-runtime/res-portrait/res/MainScene.json
	modified:   tools/framework-compile/bin-templates/js-template-runtime/src/app.js
	modified:   tools/framework-compile/bin-templates/js-template-runtime/src/resource.js
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/cocos-project-template.json
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/frameworks/runtime-src/proj.android/jni/Android.mk
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/frameworks/runtime-src/proj.win32/HelloLua.sln
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/frameworks/runtime-src/proj.win32/main.cpp
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-landscape/HelloLua.ccs
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-landscape/HelloLua.cfg
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-landscape/HelloLua.udf
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-landscape/cocosstudio/MainScene.csd
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-portrait/HelloLua.ccs
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-portrait/HelloLua.udf
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/res-portrait/cocosstudio/MainScene.csd
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/src/app/MyApp.lua
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/src/app/views/MainScene.lua
	modified:   tools/framework-compile/bin-templates/lua-template-runtime/src/config.lua
	deleted:    tools/framework-compile/gen_cocos_libs.sh
	modified:   tools/framework-compile/x-modified/cocos/audio/android/prebuilt-mk/Android.mk
	modified:   tools/framework-compile/x-modified/cocos/prebuilt-mk/Android.mk
	modified:   tools/framework-compile/x-modified/cocos/scripting/js-bindings/proj.android/prebuilt-mk/Android.mk
	modified:   tools/framework-compile/x-modified/cocos/scripting/lua-bindings/proj.android/prebuilt-mk/Android.mk


Applied as https://github.com/ruslo/polly/commit/190469f8f11b169d26755141eb5efaa8e8b4b506


it was a crutch, I forgot to remove it


Using bcond_without cephfs_java instead.


```
May 27 19:03:58 wetek kodi.sh[9750]: 0:2: P0004: High precision not supported, instead compiling high precision as medium precision
May 27 19:03:58 wetek kodi.sh[9750]: 0:4: P0007: Extension directive must occur before any non-preprocessor tokens
May 27 19:03:58 wetek kodi.sh[9750]: 0:21: L0002: No matching function for call to 'mainImage'
```
is clearly coming from gles library, so I don't think that is your issue.
The problem is related to the presets. Your shader only contains the boilerplate code - nothing from *.frag.glsl (presumably due to preset failing).


Yeah can do, which screen are we talking about?


new files 2015


Thanks. That's videofullscreen.xml


Removed :)


is it typical in SUSE to "echo stop" here? Normally we wouldn't do that on RHEL/Fedora.


Thanks!


Purposely added a semicolon, why?


:ok:


Any particular reason for this change?


in case there are more than one items in the address space, we might want to give a clue to user (any way we cannot show the list) for example

10.0.1.34,... when there are more than one item.
10.0.1.34     when there is only one.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1152 of 1152 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The refCount is there only because we need to do a replay(1), and the replay converts the Ob to a ConnectedObservable.


nit: please put indentation to the left (like previous one)


![alt tag](![alt tag](http://url/to/img.png))


'default' is technically a javascript reserved keyword (used in switch statements). May want to use something else.


Where is this method defined ?


rename it to e.g. client, and you could add an `attr_accessor :client` to use just `client` instead of `@client` in other methods.


WC API have PUT, POST and DELETE.

My solution...

```
def _do_request(self, endpoint, params = {}, method = 'GET', data = None):
...
request = Request(self.StoreURL + endpoint + parameter_string, data = data)
if method != 'GET':
    request.add_header('Content-Type', 'application/json')
    request.get_method = lambda: method
```


This looks good.  Thank you for the pull request!


What if they just removed it during the anomaly? Or are you expecting a new botguard?


this is really bad code


haters gonna hate


Fix spelling: Emptry


rax retry tests


`create_row` is a bad method for our integration.

try something like `send_order`


setAuth is a reference to an object inside Map<String,Object[]> which gets updated with the value retrieved from the httponly cookie :)
It gets changed inside the array and reused later on in the calls you see further down to the params variable ;)


also, you can probably pass `payload[:order]` instead of the whole `payload`


We seem to be missing an example of `//` comment use.
I tend to use those for

* commenting out some code that may somehow still be useful
* todos `// todo: issue 35 ...`
* programmer notes - pointers to algorithms, etc, or explanation of why something was done that way that
  does not really belong into the interface.


change the attribute name to `order`