Thanks Durk (though as far as I can see you suggest (1 - 1e-8, not 1 - 2e-8, no?).

At any rate, @laurent-dinh, no matter what we should do one of two things:

a) Add a decay actually less than 1
b) Set it to 1.0 explicitly (rather than this obfuscated way of writing 1.0) and add a note in the docstring expressing that a decay of less than one is required for convergence guarantees but of little consequence in practice (maybe also mentioning that naively writing 1- 1e-8, as suggested in the paper, will be non-representable and equal to 1 in single-precision floating point.


:O was isch denn das? Kenni gar ned


Connect -> Connected


It could be good to mark these as deprecated either in the source or in release notes for the next version.


I would like to think that GHC could optimize the ++ and not perform an extra traversal of the list. But either way it would only be O(n) and certainly less expensive than the rest of the work.

Turning it around could work. I'm not at my computer now and don't have time to play with it. Otherwise I think

    nFromTo xi xf n = fmap f [0..n] ++ [xf]

is acceptable.


From now on until Alpha version is released every change to the code will be made to test.lua.
Changes will be applied to simplified_enigma.lua just before releasing the Aplha.


Explicit rec_opt?


Please wrap this line to within 80 chars.
My preference would be:
```
lst = [Comment.newFromAPI(i, self.sheet) for i in
                response['comments'] if i['id'] not in idlist]
```


Learning the Gumbo code


Au das kenni ned, musch mer mal verzelle :)


this should be:
`headers, response = self.client.GET(path)`


I'm concerned about continuing the relative links.
This commit is too large to not be more of a direct/simple split. It seems more changes were done than just the split.


"Database name is required. Set it in the variable 'dbName'."


Unfortunately the approach you did with d3, does not work with jquery, as we cannot require jQuery in a react-native environment:
https://github.com/facebook/react-native/issues/1149

What I tried to do was:

var html = 'This is the text'

var $ = require('jQuery'),
 jsdom = require('jsdom-jscore');

jsdom.env(
    html,
    function (errors, window) {
      $(window);
    }
  );

But the line requiring jquery breaks in both the chrome and safari debugger for react-native.


Yes，you are right.
Change the getBits() method, we can get 'bits' from '__state' array.
Code will be clearer.


Refs #19


Yes, the TomTom cadence implementation is poor, and I think only there as an accident for the purposes of lap average and run average cadence, not ever instantaneous cadence. The exponential moving average is the first thing I stumbled on that made my cadence graph look similar to what I expected compared with the graphs I got from my Motoactv and other watches, but it may not work well for runs other than the types I do (3+ miles, outdoors, no stops).

It's really a problem of making up data where none exist. I'll take a look at your code and let you know how it works for my runs. I've been abusing Garmin Connect by uploading the same runs over and over after editing the activity ID so it doesn't detect a duplicate, so I could put up a few runs with all three strategies (old ttwatch, @onedayfishsale strategy, @dlenski strategy).


you can add the log_index_prefix directly to buf in the snprintf, rather than using the string + operator


Looks good. Wish we don't have to use magic number.


#16 -> I've found when it was entered.


Just wanted to say that linking to diffs like this as part of aa ongoing tutorial series is a great idea!


return -EIO


#16 -> found when it was removed. Creating a pull request for removing and fixing #16.


ah, actually -EINVAL, right.


too high of a log level, move it to 15 or 20


bug


Hey @jonklo, I don't think I will have time to update the code for both Py2 and Py3 compatibility at the moment, but I can add you as a project committer if you are interested in maintaining it!


Oops, this is wrong.


`glGenTextures` generates a `GLuint`, which could be `-1` when cast to an `int`


Tested out the code. Everything works fine.


I think "筆者" can be translated as "I" here.


pulled this from temasek


Thanks, would be very interesting to see how much useful cadence information you can squeeze out of this thing...

Pretty much no matter how fast or slow I run, and regardless of terrain, my Runner gets stuck to a moving average of ~170±5 steps per minute. Even when I've tried intentionally to vary the cadence wildly over periods of a minute or two.


Everywhere this a new UndoHelper() in this file is a memory leak, and there can be many commands in a session. It is not deleted in a destructor and neither is it a QObject parented to the QUndoCommand. The class should be declared in a separate header, implemented in a separate file, and added as a value member to each of the QUndoCommands.


I think @simon816 has a point, I mean is a sheep a cow? You can ask a lot of useless questions, what's the advantage to permitting the role be unknown?

If there's a potential usage case where the Sponge API might not know what platform type it's on, that might be better handled by a dynamic system, rather than enum.


credits to temasek


credit to temasek


Thanks


We prefer C++ //-style comments.


I suppose the main thing which makes me nervous about this approach is the need for a data migration to replace existing CurrentSubscriptions with the new Subscriptions. It was working for me in my tests, but then again I don't have a large production database to test with. Anyway, I will have a go at updating this to work with the current master, and see how it looks.


@@ダブルアット


GithubのViewで見るとズレちゃってますね！


It looks like `0` is reserved for default textures, so it might be ok to use as a null value.  We seem to use `int`s for texture names in general, which is also a problem (though presumably not the cause of any actual errors since the size is the same).


Yep it works better now though some other samples still crash.


We already enforce harmony run in the main runner, probably can can omit this check here.


What does the `@package` mean here? @dsanders11


Did you add Waypoint.png or Edit.png to the commit?


I think you're overcomplicating this. A Location is just a wrapper for a pointer in an extent and the said extent. I removed the contains() method because the pointer has multiple data types and I preferred having validity checks for each type. If we ever add a new bounded data type in Extent, we just need to add a new method in Location to check the validity. I also prefer using an equals check for inExtent() to simplify the logic. There is some discussion of nested extents, but right now nothing has been implemented. So I consider extents as separate entities with no relationship.


Is it possible to run this check in the first loop above?


title needs config?


Using 'mapping' test is an issue on distros where jinja 2.6+ is not yet available (like centos <7). I would suggest trying something like: "if value is not string", instead.


Nice find - sorry about the slip up there.


@TMogi
修正よろしくおねがいします！
![寿司ゆき:sparkles](https://d1zd1v0cxnbx2w.cloudfront.net/images/sets/sushiyuki/31.png)


Thanks.  I created `@neovim.command`, but it does not work...


Whoops, how did I miss this? I tested a few SA-1 games when I made that change and none of them crashed... I guess none of them used any SA1-side MMIO registers.

The correct fix is c134d411cc856a7e3764ddc9a373eebd35cd24a1

(As of yesterday bsnes-classic upstream has moved to GitHub from Google Code, which is shutting down in a couple months)


So is it really a uint32?


Mlt::Tractor::track() returns a Mlt::Producer() that is leaked here. It is advisable to use QScopedPointer. MLT uses reference-counting. When track() creates a Producer, it has a reference count of 1 representing the caller's reference. When that producer pointer is passed to the Mlt::Playlist constructor, it adds another reference (ref count = 2 now). When the playlist goes out of scope, the playlist reference is released, but the ref count on the producer is still 1 and not deleted.


This Mlt::Producer is leaked since clip is never deleted. Better to use QScopedPointer.


Thanks, I cherry-picked this to 3.6.x.


I get it.  rplugin/python works.  But rplugin/python3 does not work...


Only in the mock. But I don't recall any ordering constraint on any platform.


the pause shoud be renamed to getApplicationReport

And the Thread.sleep(1000) should not called here. Instead, that should be called the while loop after the case match.


My concern about this code, is that `ObjectExpression` will be triggered for any object declaration. If I have a very large object with 100 properties, this function will have O(2n) = 200 iterations. Maybe instead of using `some` twice, you should just use for loop once? Something like this:
```js
var currentObject = {};
for(var i=0; l=node.properties.length; i<l; i++) {
  if (node.properties[i].kind === 'init') {
      currentObject[node.properties[i].key.name] = true;
  }
  if (currentObject['set'] && currentObject['get']) {
    break;
  }
}
```


         |
    pN▒g▒p▒g▒▒g▒ge
   ▒▒▒▒▒▒▒▓▓▒▓▒▓▒
 _0▒▓▒▓▒▓▓▒▒▒▒▒▒▒!
 4▒▒▒▒▒▓▓▓▒▓▓▒▒▒▒▒Y
 |` ~~#00▓▓0▒MMM"M|
       `gM▓M7
|       00Q0       |
#▒____g▒0▓▓P______0
#▒0g_p#▓▓04▒▒&,__M#
0▒▒▒▒▒00   ]0▒▒▒▒00
 |\j▒▒0'   `0▒▒▒4M'
  |\#▒▒&▒▒gg▒▒0& |
 " ▒▒00▒▒▒▒00▒▒'d
 %  ¼▒  ~P▒¼▒▒|¼¼|
 M▒9▒,▒▒ ]▒] *▒j,g
 l▒g▒▒] @▒9
  ~▒0▒▒▒p ▒g▒
    @▓▒▒▒▒▒  ▒▒▓
     M0▓▓  ▓▓^
  >watch_dogs sucked.


Conveniently, this tuple is exactly the definition of an [origin](https://tools.ietf.org/html/rfc6454) (which is the web's main security isolation boundary, so I refer to it all the time at work)! :-D


@clockfly Corrected per suggestion.


The tagline was updated


rax retry tests


Your patch is still wrong, because if the parent node did a null search, `evaluate()` is not called, hence attack info not computed.

Can you please test your code locally before scheduling tests? Testing bogous code like that can only waste resources, because the bugs will have to be fixed and the patch retested (whether the bogous test passed or not).


Nice. Just glanced at the RFE, I suppose "scheme" would be a better variable name here, but this is all getting cleaned up literally right now as I port this to rails =)


This only happens in navigation back call path, maybe it will be better to move to `_onNavigatingBack` resolver with proper flag return in back method because even close the activity doesn't need to show banner. wdyt?


hasUnresolvedEntityInsertActions() should be used instead of !(unresolvedInsertions == null || unresolvedInsertions.isEmpty()).


The commit comment appears to be wrong.
"It was working on windows but not on linux"
I tested extensively on Linux prior to this commit (Ubuntu 14.10 release build and Debian 8 debug build) and it was working fine. Gale confirmed that it was working http://bugzilla.audacityteam.org/show_bug.cgi?id=930#c18

I've no objection to this commit per se, and it may be a more elegant fix, but has it been rigorously tested on all platforms?


Are you going to create new issue for that?


@methyl Wondering why you are embedding the js? To optimize the initial request? It won't be cached this way for subsequent requests and will have to load each time.


Correct.


We don't completely fail to make progress. We will apply every successful record that we download… but we will redownload everything each time, and then we won't try to upload.

Will file.


@azazar Technically, it's terminated on line 21, so this shouldn't cause any errors. It should be fixed though, so I'm patching it now.


wwwwwwwwwwwwwwww


@jv110 @byteandahalf  So What you did was take away the hitbox on the Doorbell? If You Did, Just Use The "Use" void, because i realy hated floating in the air when i was standing onn it, and i know we will a little because on the AABB Sizes.


Basically that would inline this method into the one below, making it another ten lines longer. And in theory these two things are separate: for example, we might pass in here a set of records that we already have to hand, such as a bunch of records we just deleted.


Sorry?


@Guite Why not just remove the code, instead of commenting it out, if it breaks browser support?


On top of that it's obvious that you're using uninitialized variable. I bet the compiler issued a warning, and you discarded it and scheduled a test anyway.

fishtest is not a substitute for testing and debugging.


Fix #43


There are a few reasons. It's not super important, as it is for bookmarks, which is why I didn't implement it yet, but similar principles:

1. Quicker to stream records down to disk in our limited processing time. If you have 30 seconds to sync, it's better to get all the records down, perhaps in chunks, and apply them later than to repeatedly fail to apply the first chunk.

2. Less memory usage if we design this to batch. Right now we grab everything and apply it in chunks to the DB. I want the former to be more efficient.

3. Less risk of bizarre inconsistencies: e.g., if we're half-way through downloading history and the user does a Clear History on the device, the end result will be half of your history disappearing when it finally does finish syncing.


rax retry tests


Thanks Bulkan, sure but how to request/make PR??


None whatsoever. If they pass on yours, I guess that's fine. Unless you want to set up a CI server?


It would be good to take the `40px` limit and move it to a variable and then apply it to both width and height.


Looks great, good first draft


god -> good


I'm fine to cherry-pick this one.


Won't this make the Discussion objects `_comments` array just get longer and longer?  I think we need to be replacing it with `lst`.


Button style for uninstall and cancel raised  warnings about thier styles
not being found and they went away when I imported that, not sure if it's
related. I thought uninstalling something might cause an issue with
filtering but today was too busy and I forgot to fix it and forgot that I
forgot to fix it and committed it, sorry about that.

On Wed, 20 May 2015 22:34 Taran <notifications@github.com> wrote:

> Looks good.
>
> Do we need to import controls.buttons.xaml in App.xaml? Can't see it used
> anywhere and seems ok removing it.
>
> Small bug that if you have a filter active when you do an uninstall, the
> text stays in the box but the refreshed installed items aren't re-filtered.
> I guess either clear the filter text or re-filter the Items. (My vote
> would be to re-filter).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/needo2/Total-Uninstaller/commit/8fc848a5f2a2b183c557afad64d0a26674898558#commitcomment-11291820>
> .
>


I don't understand this change.


added lionheart gov and added earlysuspend.h


Should be able to skip this if you use `client.json_headers`


This needs to be combined with the patch that moves the references as well.


Ah. GLEW_INCLUDE_DIR is present later in the File as an include dir.
Next commit, just remove these 2 lines too. They dont do anything.
```
SET(FORGE_INCLUDE_DIRECTORIES ${FORGE_INCLUDE_DIRECTORIES})
SET(FORGE_LIBRARIES ${FORGE_LIBRARIES})
```


@Xharze why is that needed?


hmm, is express-session not something that should be in the http strategy ?


Weeeeeee.


line 258 and 259. Excluded get_cpu_idle_time to fix compile error


Um...


Which file are you talking about ?


line 324. Excluded get_cpu_idle_time to fix compile error


Thanks


Updates duplication possible?
Might be worth it to make an object which would register the updates that needs to be done. This way, we make sure each update is managed only by the class which ask it and that there won't be duplicate / forgotten updates.


line 450 and 451. Excluded get_cpu_idle_time to fix compile error


I think it is not normal that the collection already exist here. It means the migration has already been done probably.
I think we should check the existence of the 4 new collections before doing any migration, and if at least one of them exist it should fail with the message "The collection xxx already exists. It probably means that your database has already been migrated.".


Because this sits in /var/lib/cloud9, having so many folders in the root directory is not desired. People opening that folder can get confused easily. I also feel many of these files are extraneous.


Nit: Could you provide a comment referencing [hdfs-default.xml](https://hadoop.apache.org/docs/r2.6.0/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml#dfs.datanode.balance.bandwidthPerSec)'s section on `dfs.datanode.balance.bandwidthPerSec` so we can remember what units are expected?


K!


Solid!


It's possible, but it'll require a possibly very lengthy refactor, with tons of conditionals. My big doubt is whether spending time on the refactor is worth it for the 1st stage of this work.


you can remove rx from package.json now.


You can replace the if and else by : return (collections.length > 0)


Well, the statistical assumption is ... statistical ;-)  So it was always a given that, in all the zillions of PRs that get auto-tested, we'd find some seeds that would result in a violation of the inequality here.

i.e. on average sample point 99 should occur with probability 5/100, but statistical variance means that this will never be an exact quantity and it may in rare circumstances take on a more extreme value.

In principle we could do a calculation to work out the relationship between the number of samples generated and the expected value of `count99` and the resulting probability of a violation of the inequality, but it seems better to say: this test (and the 2 above it) may occasionally randomly fail; and just recognize that possibility.


ok, will remove it.


I've spent time isolating the virt-testing options using the `vt_` prefix. That was some work... :)


que merda foi essa :P


Should be a parameter. If doing batch optim, I wouldn't get any output unless I do >1000 epochs.


The `addAttachment()` method should be dropped now that the Comment class uses the AttachmentPoint mixin.


Nit: Could the `CATALINA_`'s be sorted together and the `HADOOP_`'s be ordered by component?


Yes, I'll change that, it's a good idea. Today I spent a long time with isolating the vt options with `vt_`, I'll try to get back to this today, but it's more likely that I'll continue tomorrow.


IIRC some of the Intel GPUs do not have local memory. It might improve the performance in such cases.


`$formFieldOptions` is overriden below for `collection` field types.
Can't we set options for collections ?


Nit: Could `JSVC_HOME` be not in the middle of the `HADOOP_` parameters?


These changes will mean you can't build AVX2 (or better) with VC. Maybe you couldn't anyway?


I've removed the bootstrap related options in the compat plugin, so at least we got this going.


Hmm... wouldn't it be clear to have the constant be `OLD_DATA_MS_THRESHOLD` or something semantic? Or else have `10 * MS_IN_MIN`. Really nitpicky though.


I strongly suggest that you create a new class that represents the index you're modeling here.

If I were to look at this without context, it'd be pretty hard to understand what this complex data structure means or how it's supposed to work.

Start by creating an interface where you model only the operations you actually need for this data structure to accomplish its purpose.


I think this may cause an error in Ubuntu when people use cmake 2.8


This should be `strongSelf`, not `self`.


good catch


You don't want to be like the cool kids? ;-)

```ruby
respository.tags.lo.collect(&:value)
```


Also, I figured that bootstrap is unnecessary since the user can use virt-test directly to do it. @adereis mentioned that it's probably best to leave the boostrap to virt-test, while the compat layer only concerns itself with running the virt-tests.


Merge artifact?


Fix for issue #783


this placeholder link has been updated and is no longer a relative link.
the link is "http://www.ssa.gov/OACT/quickcalc/faqs.html"
the page_title is "Quick Calculator FAQs"

we can amend this after the pull, or would it be best to add it and change the 'relative_url' reference?


This needs to be updated to pass through eventOptions as Backbone does
Additionally, we need the default eventOptions value set


Yes (1-1e-8), and thanks for pointing out the dangling sentence, David.

On Wed, May 20, 2015 at 9:57 PM, David Warde-Farley <
notifications@github.com> wrote:

> Thanks Durk (though as far as I can see you suggest (1 - 1e-8, not 1 -
> 2e-8, no?).
>
> At any rate, @laurent-dinh <https://github.com/laurent-dinh>, no matter
> what we should do one of two things:
>
> a) Add a decay actually less than 1
> b) Set it to 1.0 explicitly (rather than this obfuscated way of writing
> 1.0) and add a note in the docstring expressing that a decay of less than
> one is required for convergence guarantees but of little consequence in
> practice (maybe also mentioning that naively writing 1- 1e-8, as suggested
> in the paper, will be non-representable and equal to 1 in single-precision
> floating point.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mila-udem/blocks/commit/4f4aedb98cc3ac3e3b4bf2f6dc6323367f546476#commitcomment-11292192>
> .
>


Rome, really?


Pretty similar to the day before but still a good read :+1:


```wordEntry``` seems like a more appropriate name for this variable


fork


Thanks Chris,
I would like, however, to find another solution for this. lcms2.h have 3 and only 3 includes, and making it to work with just there 3 includes toke lots of effort, and it has been proven to be good in order to reduce dependencies to absolute minimum. So, adding an extra include, no matter protected by code guards, is not very appealing to me.
Some folks contacted me time ago about same issue. The mess on __powerpc__,  __ppc__ and TARGET_CPU_PPC is from them. I really don't like this part and now I am tempted to just remove all that and let the source caller to include the endian.h before lcms2.h or just to define WORDS_BIGENDIAN which is the "recommended" way to set big endian in exotic platforms. Otherwise, I don't like to tie lcms source code with autotools, just because many people are not using autoconf at all. In all lcms2 code there is no HAVE_* dependencies and I would like to preserve this as a desirable feature.

What do you think? It is really a must for you to include the endian.h file? Could you include the endian.h before lcms2.h?

Regards
Marti


out of curiosity does this fix the travis error? (what was going on?)


It's a uint64, little endian


`self.data = [dataset.inputs_shared, dataset.targets_shared] if dataset.targets_shared is not None else [dataset.inputs_shared]`


No yeah that's a good point, agreed :+1:. I was just going with the same style as the other static MS counters I had.
I do like the idea, because the other MS constants are also just used in one specific place. Like the 2 weeks one is the old-data-threshold for the list of dining halls.


Could you please post the error?

On Wed, May 20, 2015, 2:10 PM luma <notifications@github.com> wrote:

> I think this may cause an error in Ubuntu when people use cmake 2.8
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arpg/Pangolin/commit/3577c010fef09bc0f08d8ac04ebb504a983b381f#commitcomment-11292420>
> .
>


If you come up with a good name for them please PR it :DDD


Meh, I included full release note... Only first change is related to this commit.


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (348 of 348 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I thought a bit more; this makes sense. Cheers.


lambda_type_resolution (lefticus) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Or better, make a `Dataset` property for this. It'd support unsupervised datasets.


lambda_type_resolution (lefticus) - x86_64-MacOS-10.9-clang-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


move this line in to the scope of  if (currentScopeIndex !== -1) {

Between line 84 - 85


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (635 of 635 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.31%25-green.svg)


Added README


This syntax is not valid for all the SQL databases.

On SQLite booleans are mapped as chars 't' and 'f' for example.


/test2.css:44:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


/test2.css:46:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


/test2.css:45:5: CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


/test2.css:53:5: CSS outline not supported by: Opera Mini (5.0-8.0)


The second c.Name.Equals(id) is unnecessary.


Call me superstitious : wouldn't 1024 be more aligned ?


Shouldn't this use `version`?


`reading_groups` is not a valid method and breaks the acceptance tests.

The correct still is `reading_group_options`


Bugfix is related to #11


You do var self = this; here, but opt to use just 'this' in other places, is there a reason why?


Should we use your fork until they merge this?


Is there any reason that you're using integers? Or that you're assigning statements to variables? It looks like c and d should be functions, not values.


yeeeeep


Sounds good. I'll make that change.


Оксана молодець я тебе докинув у список


Hi,

With this change :
 ...{% if **android_api** >= 13 %}|screenSize{% endif %}"
...{% if args.**min_sdk_version** >= 13 %}|screenSize{% endif %}"

I must turn min api version to 13 if i want my app working with screen rotate, this should be :

{% if args.**sdk_version** >= 13 %}|screenSize{% endif %}"


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1145 of 1145 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this seems odd to me, but it might be my understanding of JS. I would have thought

for (var serviceName in this.services) {

was looping around service and wherefore why do you need to do this.services[serviceName]? and therefore why would you ever need to check if (!serviceClasses) continue;?


My bad, the new changes will not cause any error.


Hi Mark -- Looking over the ops I've written it seems I'm particularly guilty of this.  I'll see if I can clean some of it up in the near future.


Why don't you just add an installation rule to your Makefile?

https://github.com/stephencelis/dotfiles/blob/master/Makefile#L107-L112

And then you can remove the **vim** dot directory from this repo. And then you can stop these update commits.


This method doesn't add the newly created Discussion object to the Sheet._discussions list.


@isbm, if you have a better solution that is python 2.6 compatible, that is fine with me.


но, тем не менее, обилие 500 ошибок в логе web-инспектора - это признак, что что-то не так.
если вы решите развивать в сторону веб-программирования и дальше, то запомните, что такие вещи нельзя пропускать ;)


Nope. I'll take it back out in my next commit.


This should raise NotImplementedError() instead of pass.


Good point, thanks.


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2123 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.5%25-yellow.svg)


Even though it is redundant, and makes the code slightly slower, I like to make paths start with '/'.


You are right. I've just updated this code to respect the options set by the user


s/doesNotExists/doesNotExist/


I recommend the following pattern for defining your variables.

```javascript
var config           = require('./config)
   , apiKey           = config.get('mailgun:api_key')
   , mailgunFrom = ...
```


Is this intentionally still `camelCase`?


Solution is usually to check if that policy is available before trying to
set it.  http://www.cmake.org/cmake/help/v3.0/manual/cmake-policies.7.html
Could you please post the error?

On Wed, May 20, 2015, 2:10 PM luma <notifications@github.com> wrote:

> I think this may cause an error in Ubuntu when people use cmake 2.8
>
> —
> Reply to this email directly or view it on GitHub
> <
https://github.com/arpg/Pangolin/commit/3577c010fef09bc0f08d8ac04ebb504a983b381f#commitcomment-11292420
>
> .
>

—
Reply to this email directly or view it on GitHub
<https://github.com/arpg/Pangolin/commit/3577c010fef09bc0f08d8ac04ebb504a983b381f#commitcomment-11292516>
.


`self.assertTrue(len(sheet.discussions) == 1)`


I'll pass :)


I like that much better.

For your viewing displeasure the mangled Ubuntu version...
![screenshot from 2015-05-20 15 20 20](https://cloud.githubusercontent.com/assets/6667703/7735629/10362258-ff04-11e4-9fb2-20002fcbcf18.png)

You've mentioned a way to use slightly different UI's based on OS/DE? This might be a good case for that. Now I know why you wanted to hold off on the headerbar.


lst only contains comments who's IDs aren't in idlist


Should fix this error: https://travis-ci.org/openstax/tutor-server/builds/63250393
The filename has a date and... dates change.


Need to do JSON encoding of request body in some places.


Thank you. will fix it.


A better appropriate might be to turn path into a property, in which case you can just use a docstring. Docstrings are accessible from Python's built-in help.


libFilePath


`build_learning_function` is not an `Optimizer` abstract method.


Why should this operation fail?
The prologue mentions "op succeeds" after stopping and restarting the node...


I'm not sure I understand what the NewId<T>(id) call is for?


Could you please explain the essence of the change and why have you decided to create pull request against my repository and not https://github.com/sstephenson/prototype ?


Test comment...


Given the desire to keep includes to a minimum, my suggestion would be to remove all the checks in lcms2.h and just rely on the setting from the configure script (AC_C_BIGENDIAN), or set explicitly on the compiler command line. So, "common" Unix-like systems work with configure, and obscure systems can specify via the compiler command line.

The problem with relying on the caller to include endian.h before lcms.h is that it doesn't resolve the issue at LCMS2 library build time.

Chris


Of course! for some reason I had a mind blank and thought bytes were 4 bits when multiplying it out...


@jlucerond DWMR. This code worked perfectly. The error you got was that the network connection was lost.  I think is probably why you had a problem. No need to fix that at this point - but losing a network connection is a common scenario - one that must be addressed in a production app.


@twhid Yea.


@vcunat What is the point of this change?  It breaks Darwin because the glob is empty, but why do you need shared libraries to be executable?


Dejé la clase "current" en el li y no es necesario el span para la animación, lo reemplacé por un after


What's this syntax?


No need to have the `body` variable since we can use the `data` argument.


Does `refreshComments()` get all of the current Comments for the Discussion?  If so, then only extending the list can result in `Discussion._comments` containing deleted comments.  When refreshing the list of Comments, the existing ones should be discarded and the new ones put in their place.

If we don't do that, then any ones that no longer exist on the server should be discarded, new ones added, and existing ones updated in place.  Discarding all of the ones currently on the Discussion object is the easiest approach.  It's not ideal for the user of the library (who might be holding on to a reference to a now-discarded comment).  But, I think we can figure out a way to make recovering from that not horrible, eventually.


@rcarton I love that you added this. I was struggling with the same thing. However, I had to move this block of code to the very end (right before `$.verbose.ok('Task options');`) so that the options defined in the config files would overwrite anything that was previously set. Do you see issues with that?

For example, my grunt config was:
```
nightwatch: {
            options: {
                src_folders: ['tests'],
                selenium: {
                    port: 12344
                }
            },
            remote: {
                config_path: __dirname + '/_tests/ui/nightwatch.remote.default.json'
            },
            default: {
                launch_url: " ... ",
                standalone: false,
                start_process: false,
                selenium_port: 12344,
                selenium_host: "127.0.0.1"
            }
        }
```
File nightwatch.remote.default.json:
```
{
    "launch_url": " ... ",
    "selenium_port"  : 80,
    "selenium_host"  : "ondemand.saucelabs.com",
    "silent": true,
    "username": "${SAUCE_USERNAME}",
    "access_key": "${SAUCE_ACCESS_KEY}"
}
```

The way that your code was written, the default setting for `selenium_host` from my grunt config was overwriting the one in my config file, and I think it should be the other way around.


Does Go have a way to create those characters using escape codes? It be good to not have to assume editors are unicode-aware just for this test case.


forgot a space here.


suit => suite


should be 2015.5.2 (2015.5.1 was tagged internally today, so this kwarg won't be in a release until 2015.5.2)


awesome job!


You should not use `Strings` because you depend on `nette/di` but not on `nette/utils`.


This may replace the string in multiple places, `substr` is better here.


En este fichero se le indica a git que no suba estos ficheros al repo


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


why did you change this? isn't the point of your commit that regular strings are now also fast?


Aren't stopping criteria Tasks? This way, we could add per update stopping criteria.


@Khelek тут наверное дело в том, что удобнее верстать. Потому что так придётся постоянно впихивать теги ```<a>```, когда нужны ссылки. А если оставить всё как есть, то в роли ссылок могут быть любые элементы (ну или почти любые).


Evita el import *, es mejor importar solo lo que necesites


Should be registered in `Status` ?


You're intro will still needs a lot of work.


A test that can fail is a test that should either be fixed or removed.  It shouldn't be 'ok' to fail.. it adds negative value.


Leete el PEP-8


Put anything that gets typed in the terminal in backticks.  e.g. `-r`, `-nc`, and `--domains`.


En Django-1.8 no se puede crear un ModelForm sin fields ni exclude: lo que dice es que no excluya a nada


Dont mind him #HubStalker


Reordenando los imports


It was overridden by `src/conf/MANIFEST.MF`, but I've changed it here for clarity. thanks


This has an unnecessary O(n) complexity. This should be changed to `isset($this->attachedServices[$name])`.


Eliminando espacios en blanco


This should be fixed ASAP


`$this->attachedServices[$name] = TRUE`.


what does it mean to "go into" a file?


why are you `touch`ing the file?


why not just open it in vim?


90210372-ChillerElectricEIR-still-delivering-chilled-water-#4453 (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1656 of 1657 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Not sure if it was intentional or not, but I see that implementing my security changes reverted the changes that Vorspire made.
So it's now using If statements again instead of the switch cases that he rewrote it to work with.


Oh, okay. I'll fix that.


`nb_updates_per_epoch` undefined in `Optimizer`.


all of these commands need proper markdown formatting


The assert will get stripped out in a production build, but it will throw properly in our debug builds.  This seems like it should be in a testcase so that we can exercise the assertion frequently.


I have a Jenkins job that automatically runs the tests on Windows. I also have one for Linux and OS X, but the OS X build node is currently broken and I'm on the other side of the planet, so I can't really fix it. Let me know if you would like to get emails on failures.

http://build.oxygene.sk/job/taglib-win-msvc/
http://build.oxygene.sk/job/taglib-linux/
http://build.oxygene.sk/job/taglib-osx/


A bit weird that the code supports multiple `preferred-versions` files. We could require it to be unique and get rid of the map.


Same comment re: assertions in production code


Este es el fichero donde se declaran que paquetes necesita tu proyecto para funcionar, revisa que son los python-virtualenvs y entenderás la importancia, cuando lo hagas estas dependencias se instalan con pip install -r requirements.txt


Oh I overlooked this comment. I saw your commit, I think it's the best way to go for now. I'm considering to not use the TestContext for the TestHarness in the future, but until then :)


>We will be using a food site to show how to get specific recipes from the site.

You've finally explained what your example is.  This should be in the first sentence of the writeup.


This change is the fix for the issue you had reported where style/css binding didn't work on SVG elements.

Previously the SVG specific logic would take over, even in situations where the style/css logic should have been handling the property.

With this change the style/css logic gets a chance to handle the property before checking whether it's something that should be handled with the general-purpose SVG property logic (which is not well suited for dealing with style/css attributes).

Just did a quick integration test- added the following lines to welcome.js:

```
  x1=0;
  y1=0;
  x2=100;
  y2=50;
  width=10;

  constructor() {
    setInterval(() => this.width+=10, 1000);
  }
```

and welcome.html:
```
<svg>
  <line x1.bind="x1" y1.bind="y1" x2.bind="x2" y2.bind="y2" style="stroke:red;stroke-width:${width}"/></line>
</svg>
```

It worked- the stroke width animated, etc.

I'll add a unit test for this scenario as well, basically this test using an svg element:  https://github.com/aurelia/binding/blob/master/test/element-observation.spec.js#L142


why are you doing this in a script file and not just running one command after another in the terminal?


If I understand you correctly, this benchmark change is the right thing to do. The intention is to be able to use native `string` types in the fast path, if the user wants to. The `[]byte(...)` call before was a way of setting up the fast path, which always caused an alloc before entering the loop. Does that make sense / do you agree?


You used the `ceil` function to compute the `nb_updates_per_epoch` in `sgd`.
Adding one, will result in starting index of the dataset to be out of bound.


Hey Klas,
This change is now back on the master.
Thank you


Thanks! You can simplify it more just by using Torch's built in clone() function. Maybe insignificantly slower but its' simpler. I just placed it all in setup:

         print("Creating a RNN LSTM network.")
         local coreModule = core(opt);
         param, gradParam = coreModule:getParameters()
         local p, gradP   = coreModule:parameters()
         rnn.cores = {}
         for i = 1, opt.seqLength do
            local clone = coreModule:clone()
            local cloneP, cloneGradP = clone:parameters()
            -- All clones set to same view.
            for i = 1, #p do
               cloneP[i]:set(p[i])
               cloneGradP[i]:set(gradP[i])
            end
            rnn.cores[#rnn.cores + 1] = clone
            collectgarbage()


Oh, the Windows one actually doesn't run tests, just builds TagLib. Nevermind them. I might add the tests though.


good


Those image paths in the example don't need to be wrapped in their own tuple, the outer tuple is enough. In fact, it would be even better to make it a Python list, like so:
```
SIDEBAR_IMAGES = ["/path/to/image1.png", "/path/to/image2.pgn"]


aici vrei sa deschida un fragment nou cu toate locatiile de pe harta ale acelui holder cumva?


you'll probably need more than 1 picture


We need to use `logger.error` to log errors and also we should add some meta information to the message.

```javascript
logger.error('Error encountered while sending email', err)
```


Nitpicking here, but ALLCAPS is only used for constants, and `IMAGE` here is a variable, so it should be:
```
{% for image in SIDEBAR_IMAGES %}


LGTM :+1:


We need to add some meta information to the log.


Never leave comments in code that you contribute ;)


Don't list all the options like this.  Just talk about them as you use them in the examples.


I think testcasing the assertion would be odd. This assertion is an internal precondition to catch errors during development, and make it clear to the reader the expected state.


Why did you switch examples from recipes to reddit right here?  Pick one and use that everywhere.


This seems awkward to me.  getFinalizedReportBatch() and mInMemoryFinalizedJSONRowsObject are the same thing.  Can we clarify this by just invoking `getFinalizedReportBatch()` for both cases instead of checking the state using the attribute and then fetching the state from the method?


Fixed.


It is not related to the inheritance. It is needed  for events with explicitly provided ids.


You're job is to just explain how to download all the recipes.  Nothing else.  Don't get distracted.


these lists must be part of the `config.json` file. This way a user of your tool does all the configuration in `config.json`.


Все отлично! Молодец! :)


Same comment as https://github.com/garvankeeley/MozStumbler/commit/b95c8314b2420152a36ab0c30973c40dc8f6efbb#commitcomment-11293057


Do you have a small condensed test case Mike would like for this LuaJIT bug?

If so, makes sense to send it to the mailing list.


Again, only use examples directly related to the recipes.  Skip all this basic stuff.


Let's put it in `beforeAll`.


here as well - two different access methods for the same state just like : https://github.com/garvankeeley/MozStumbler/commit/b95c8314b2420152a36ab0c30973c40dc8f6efbb#commitcomment-11293057


Instead of nesting `if` statements we can combine the conditions.

```
if (errFound && !allowed) {
  // send email
}
```


This is a good start, but you're final writeup will need a lot more focus.  I don't want to see any examples that don't directly relate to downloading the recipes.

Any questions?


in the future it might be nice to use an approach like this
https://github.com/samccone/rework-suffix

vs regex :package:


ditto previous


In hindsight, the air vents look really crappy with the mediocre-res diffuse and bump maps - I'll need to redo them using mesh cutouts for the grilles.


Thanks for the catch! I have merged the same to the master


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Because the cycle body is very should, it would be better to reverse to condition and avoid the `continue`, i.e

~~~php
if (!isset($this->attachedServices[$name])) {
    $this->attach($this->container->getService($name));
    $this->attachedServices[$name] = TRUE;
}
~~~

The comments could be avoided as well because the code is pretty self-explanatory. Or maybe simple `// avoids calling onEvent() multiple time` could be added.


maybe move up into the previous commit since they are related and just put the rational in the commit message :)


The format of both games should be exactly the same.  I like the idea of adding a note about which level you're on.  But you should do that to both games.


Could be extracted as a `RecurrentTask`.


Oops, yeah, awkward.


Looks like you intended to check another entries, not the same for three times :)


>We will also implement a list of commands per level that the user should know, or should have learned from previous levels.

Great!  Make sure to provide links as well.  And you'll need to update the original game too.


I don't understand what these comments mean. :(


10pm coding I don't useful commit messages


you may want to consider using the typed array port: https://github.com/jnordberg/gif.js/blob/master/src/TypedNeuQuant.js


Well, I'm not sure that there is any way to 100% avoid tests of statistical behaviour very rarely failing.  I don't accept that this makes them overall negative, but if you want to strip out lines 2485-2487, go ahead.  It's not the most elegant test and there are probably better ways of implementing a reliable test in a dedicated set of tests-of-randomness.


These need parens around the parameters, and would probably be better off in `macros.h` IMO.


Ah I see. I think it's better to just push a TypedId directly to the Id collection. What the code doesn't say is that argument array on NewId<T>(params string[] args) is meant for a typed id feature, that is just not finished yet :)
I'll see, if I can get that pushed tomorrow though.


Need to be clearer here. Do they press the Home button, or double-tap Home to kill the app?


`const`?


If at all possible, avoid forcing people to run code.  Lots of people don't like running random code off the internet because there's no telling what it could do to their computer.

How is `git clean` necessary to advance to the next level?  It seems like if I never run it I could still advance.


How is it necessary for me to run `git stash` to advance to the next level?  What if I never run it?


This issue lies here. The output of `Query.take` after directembedding is this:

```scala
ch.epfl.lamp.slick.direct.Config.compile({
  import ch.epfl.directembedding.transformers.RewireEmbeddedControls._;
  {
    import ch.epfl.lamp.slick.direct.`package`.Config._;
    SlickReification.take(ch.epfl.lamp.slick.direct.Config.lift(users), ch.epfl.lamp.slick.direct.Config.lift(1))
  }
})```
and the signature for lift is `lift[T](e: T): Rep[T]`.


- We don't call it a "tone." Please keep all client facing copy on-brand and consistent with the rest of our documentation.
- Typo: "closed re-opened"
- Last sentence is unnecessary and can be removed.


haha I believe I influenced the addition of this function at this time :D


What if they use `git checkout` instead of `git reset`?  How are you going to force them to use `git reset`?


Usually it's good to leave a blank line between the block that defines variables and the next code. It makes your code more readable.


Also, I suggest not saying "mid-way." Perhaps say "20-40 seconds."


I don't see how `rebase`ing is necessary in this level.


@dixonlo `<main>` or `<section>` ?


You missed the `var` keyword.


That wouldn't be enough to resume optimization.
At least, it'd need to save the `param_modifiers` dict.


@dixonlo DWMR. Review the checkpoint and see if the `<main>` tag is correct. Press on!


Could be clearer this way...

            if (!ids.Any(d=>d.ToString() == id))
                NewId<T>(id);

            var emitterType = typeof(T);
            var tid = ids.FirstOrDefault(i => i.ToString() == Latest<T>());

            if (tid != null)
                emitterType = tid.GetEmitterType();


compiled `loss_fct` ?
Then again, that should be provided by the model. Unless you treat it as the distance function used on the output of the model?


Sorry about the ambiguous "they."  Toggle menus have the background now, so it's actually unrelated to the previous commit


Again, this doesn't require the use of `cherry-pick` at all.  I can just run `git checkout HEAD~1` to avoid all the work.


Why not use a `absint`?


bah should be requires: https://github.com/linuxmint/cinnamon-desktop/commit/59f010882d72e8934bd709474ab866af25ac5755


That is correct (both points)


> You've mentioned a way to use slightly different UI's based on OS/DE? This might be a good case for that.

Sure what were you thinking? We can show the play buttons on the right side when the close buttons are on the left.

I am really not digging the fact the ubuntu theme is drawing a border around the title... Adwaita properly respects that setting.


>Note: The bug that will be detected by git bisect is caused by level 9.

This is nice!


Absolutely! :) Hope some of it will be helpful down the line! Especially given that this was one of the first projects, it seems like you're doing great.


Or I can just send a pull request, if you like.


I don't see how `filter-branch` is required here to proceed to the next level.


> Essentially, `MeshBasicMaterial` has a constant ambient light source hardwired

Sounds good!

> And why not tell users to use `MeshPhongMaterial`, instead of adding `AOmap`s back in?

It's good to have simpler materials with less parameters. They're less intimidating.

> I wonder which one we are talking about, here?...

Sorry, I meant lightMap. So, basically...

```javascript
finalColor = material.color * material.map * material.lightMap;
```


@gedads Fix your git setup to not convert line the ends (and use an editor that doesn't change them) !


Thank you to @russell_knockout. Good catch!


Ok, will wait with this until tomorrow.


The commands you selected all look fine.  There's a problem though in that most of the levels don't seem to require that the player actually use the commands to advance to subsequent levels.  It's not enough to just tell the user to use the commands.  You have to figure out a way to *force* them to use the commands.


Great


I'm busy until Tuesday but if it hasn't been fixed by then I'll take a look at it.


Any questions?


Don't define things at the beginning.  Define them as you use them.


Yes, I think that's a lot clearer :)


The how sections should be before the why sections


Seems like a good start.  The examples you select will be the most important part of the assignment.  So please show me once you've selected them.


Please don't leave commented code hanging around


Something went wrong with this comment :)


Makes sense. Changed!


Good idea.

So I would remove entirely this part:

#if defined(__powerpc__) || defined(__ppc__) || defined(TARGET_CPU_PPC)
#  if __powerpc__ || __ppc__ || TARGET_CPU_PPC
#   define CMS_USE_BIG_ENDIAN   1
#   if defined (__GNUC__) && defined(__BYTE_ORDER__) && defined(__ORDER_LITTLE_ENDIAN__)
#       if __BYTE_ORDER__  == __ORDER_LITTLE_ENDIAN__
                // Don't use big endian for PowerPC little endian mode
#                undef CMS_USE_BIG_ENDIAN
#       endif
#     endif
#   endif
#endif

and only keep the few "historical" checks on sparc, sgi and macintosh. Probably I should remove those as well, but they come from the old days of lcms1 and nobody has complained.

Would that work for Artifex?
Regards
Marti


on peut utiliser fakeSMTP pour l'envoie mail test c'est très pratique gratuit et sans installation (app java)
http://machiavel.fr/images/mail/h1Email.png


You need to find examples that people will actually care about.  For example, finding all the previous uses of `g++`.


I tried the example but got confused on the way, to me it's not clear which changes go into which file, assuming not everything goes into the **show-properties.ts** file mentioned at the beginning. Can the instructions be more specific?

In my opinion it would be great to have a repo with the working examples. And I would love to see a 5th document in the **Step By Step Guide** to show how to use services to communicate with a REST API.


Revert debug change


Why did you remove this test case?  Same question for the others.


If this works and solves the problem you have at hand, I have no problems with the solution. I can just merge my new features in afterwards.


You're probably gonna need to restructure these tests once you create a class to represent your index as a first class concept in the application


These section titles seem off to me.  The focus should be on examples.  Pick a few examples and explain how they work.  Don't explain any features that don't relate back to your examples.


да, курсач


Please use Pascal case (i.e. first letter of the method in upper case)


GitHub has wiki support (in settings)


agreed


Try to find more descriptive names for your tests.


These commands look fine.  If anything, there's too many of them.

But your format looks like you're trying to create a reference.  That already exists, so don't do that.  Pick a few examples where you have some formatting tasks.  Then show how to accomplish them using the commands.  The focus should be on solving the real world problems, and as a by product the reader learns about the commands.


Non FAANG members can't email the faang mailing lists, not sure that is a good idea


whoops actually yr right - carry on then.

On Tue, May 19, 2015 at 2:56 AM, Adrien Jarthon <notifications@github.com>
wrote:

> Why not, but the readme already says SGIZMO_DEBUG=true so it's not like
> we're fooling anyone ;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RipTheJacker/survey-gizmo-ruby/commit/fa52baad57b22356bf1523f68c4d7bd31e835170#commitcomment-11258072>
> .
>


Hi @troutowicz ! According to the documentation, you should just use `13` rather than `'13px'`. ;)

https://facebook.github.io/react/tips/style-props-value-px.html


What does it look like in GNOME proper? It's also might be a good idea to see what it looks like in other common themes. But my 2 cents worth is that you/we(mostly you,lol!!!) should refine it and worry about more how it looks in the default GNOME theme before we worry about how it looks in other themes since that's pretty much the "reference." Especially Ubuntu, they screw everything up,lol!!!


You can use ```Is.False``` instead of ```Is.EqualTo(false)``` here.


I thought we talked about you adding on to the existing gdb cheatsheet at https://github.com/mikeizbicki/ucr-cs100/blob/2015spring/cheatsheets/gdb-cheatsheet.md

It looks like you're trying to create a new cheatsheet from scratch though.  Is there a reason you don't want to add on to the existing one?


Basically right now use your new layout for GNOME and the old layout for EVERYTHING else.


You could just use `style={styles.icon.paper}` rather than `styles={styles.icon.paper}` when there is only 1 style, nop? More readable?


Please make sure to be consistent in your code formatting here and elsewhere (e.g. leave always a space after a comma)


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I think we need leading spaces on the `# sequence number: 1` comment.  It's not looking right on the formatted markdown.  But, yeah, this is a good approach.  Well thought.


This is not a test. You're not asserting anything here.


This is basically what's happening, some of those arrows could safely be skipped to prevent the casting. The compiler will complain if the types don't match after the embedding. The casting in step 2 will only fail during runtime.

![directembedding](https://cloud.githubusercontent.com/assets/1408093/7736522/a1489790-ff44-11e4-9771-626ea3a16931.png)


All of the above should be removed.  The first sentence of the writeup is the most important and needs to explain exactly what the writeup is about.  The existing first sentence could maybe be improved, but it's better than what you've added.


Actually I think the better solution is to make this test support both playready and widevine.


That's what the conditional does currently, I believe.


Allows to update password without confirming it.


let sleeping dogs lie.
:speak_no_evil:


As a beginner, why do I care about this?  You're trying to create a reference document.  We need to get to the examples as quickly as possible.


Yes, the only thing I'd want to add in is the protecting those remaining checks so if the endianness is already set on the compiler command line, there's no chance of those checks in lcms2.h overriding it.

So, removing the checks you list above, pulling the setting from configure, and protecting the remaining checks in lcms2.h would work nicely for us.

If you want, I'll pull all that together, and put up a proposed commit tomorrow (it's getting late here).


test from web


just checking


I'll revert this back to silent.


So, from now on if the server had 500 errors the log file won't reflect them.

This is clearly a change of behaviour compared to the master branch.


I don't see how it didn't work for you.

These cmake files work fine for me, as with this toy CMakeLists.txt:
```
CMAKE_MINIMUM_REQUIRED(VERSION 2.6)
PROJECT(test)
find_package(glfw)
```
And then `cmake .. -G "Visual Studio 12 2013 Win64" -Dglfw_DIR=%cd%\...\depends\glfw\lib\cmake\glfw`. Just point `glfw_DIR` to a certain installation directory.


jck Flexible Box Layout Module not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)


jck CSS3 selectors not supported by: IE (8)


jck CSS Generated content for pseudo-elements not supported by: IE (8)


jck CSS3 Box-sizing not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


jck CSS outline not supported by: Opera Mini (5.0-8.0)


jck CSS3 Border-radius (rounded corners) not supported by: IE (8), Opera Mini (5.0-8.0)


thanks @arthurvr ;)
Fixed in b1d956b0d07fbdaaa59be64bb91c8a529c7114ba


Last word FIN not translated to END


Again, all this is way too much introduction.  You're writeup has over 50 lines of stuff before I even get to see what tokenizing does and if it's going to be useful for me.  We need to get to the examples as quickly as possible.

The material below is all fine, but you shouldn't explain it here.  You should modify the locations in the existing tutorial so that it discusses this information only when it becomes relevant to the example.  No sooner.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why?


Тут OUTPUT_SIZE_512 кажется должно быть?


Nice docs.  Thanks.


This line isn't in any method. You need to add a test to ensure that a record is actually deleted when you do this.


Thanks!


These are different from the form and the database. Perhaps a mapping is best instead of an array here?


You'll want to use a single example throughout the whole document, just adding new features to the example as you go.  These new features is how you would introduce the new concepts.


No need to set @last_name twice


new line


Will this work for translating characters to unicode that aren't letters? e.g. Caps lock is toggled and holding down shift, pressing 1-9 should print symbols


Break this into two calls. You shouldn't need to use a `\n` here


This fixes #10.


FYI, placing a move at [tt] to signal a pass is part of the SGF standard, and not just a quirk of IGS. In fact, this was the only way to signal a pass for SGF FF[3] and earlier, and it is kept in the standard for FF[4] to maintain compatibility with older versions.

See http://www.red-bean.com/sgf/go.html
"A pass move is shown as '[]' or alternatively as '[tt]' (only for boards <= 19x19), i.e. applications should be able to deal with both representations. '[tt]' is kept for compatibility with FF[3]."


Alvin added his bogus method, and called it in onFailure; this should introduce conflicts when we try to merge with the master


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nice idea but is git2r stable enough yet?  It doesn't seem to work as nicely in Windows with proxies and authentication which your original CLI approach did.


Remember when I said to use `print` instead of `puts`? That will allow you to format the screen like the screenshots I sent you initially.


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Superb!


@d4nyll what do you think?


No need to map, I will just update the names in the form.


>Basically right now use your new layout for GNOME and the old layout for EVERYTHING else.

I'd rather go all or nothing. Maintaining two interfaces is just bad for everyone, more to maintain, more to support, more for users to understand. It looks like Ubuntu can get to looking decent. Others like XFCE and Cinnamon seem to follow what gnome has. The question marks are the old school WMs and KDE. You still have a KDE install sitting around, preferably plasma 5?


why need this ?


The `@input` is a concern of `DeleteScreen`. `DeleteScreen` deals with user input, the `Delete` class deals with the actual operation.


There were so many problems derived from this approach, since it was taking a decision about the result of 500 exception (launching and logging an error), even if you decide to catch the exception from your application to treat it.

If we want to mantain this feature on "default sifo apps" we can add the trigger_error to the controller in sifo-common-app that manages the errors and uncontrolled exceptions.


It's really more general than this.  It works with any program.  For example, it works with `ls` as well.

The key difference between it and something like galah is that it supports grading much more complex programs.


Is this script only used for our CI? We might not want this to run on any machine simply compiling docker or running its tests.


No. That ID is from a type defined in Oracle, if there is a constant for it it will be in Oracle's jar and we can't reference it here


Chris, that would be great. Thanks!
Best regards
Marti


downgrade! :)


I don't think this is the right way to do this, I think you should be doing `ContactsDisplay::DUMMY_CONTACTS.delete(@id)` or something like that.


The final version will be within the gitlearn repo, so the instructions will be different.

Your tutorial should just be about using, not installation, so I'd even delete this whole section.


Wait, I forgot to flip the order of the embedding and lifting stages. In this case the users will not be lifted. I'm gonna see how that changes things.


Adicionei um arquivo em C para testar a resenha!


Again, this needs to be more general than just for shells.


See comment above, your test of the "Y" should be in here and not in `Delete`


It's not a game


I am curious, what is the use case?


If you want to put in a separate line, just use `@output.puts` with no parameter


wrong log factory


We should probably make it so that it doesn't default to `bin/rshell`.  There's no need to tie the program specifically to our class.  We want universities everywhere to be able to run it.


Newline again


When you start working with external dependencies and components, lots of them depend on being able to collect info from those variables.

Add to this, the behavior was so inconsistent: the variables were only removed when you instantiated those filtering classes. So, you call the variable on one point of the app: it works. You call the variable on other part: it doesn't. Weird, don't you think?


1836664-ReturnWaterTempReset (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1151 of 1151 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Note that this commited titled with "adjustment for avrdude" hides also subtle changes relating to autobed leveling. Auto bed leveling was reenabled with 4 instead of 7 grid points.


I think we should remove `force` from the rc example, it's there as a command line option, not something you'd want to set as a default config. Other than that, ship it.


The example should come first.  All the explanations above should be incorporated into the example.


@nikolai-b sounds reasonable - really like this:
![selection_204](https://cloud.githubusercontent.com/assets/1825120/7736818/69a875d6-ff3e-11e4-864c-7ebea6e3bd92.png)


if the machine is not a remote host (aka not windows) & has apparmor
enabled it will run

On Wed, May 20, 2015 at 2:16 PM, Eric Windisch <notifications@github.com>
wrote:

> Is this script only used for our CI? We might not want this to run on any
> machine simply compiling docker or running its tests.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jfrazelle/docker/commit/6f75dd85c5adbced787a2e15aa7e9ccd71289749#commitcomment-11293670>
> .
>

--

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>


WOOT!


The problem was that VC uses a pragma to do the alignment, so when it was a macro that was ANYTHING other than a pure number, the compile fails.  I thought that cpp would have processed out the macros prior to that, but I guess not.


Why are we modifying the content of an external library that is bound to a version. With this change the library Smarty is no longer the version Smarty-3.1.4


line 347 and 348 - excluded any active lines using get_cpu_idle_time


but this is apparmor _in_ the container of course, i dont think it can do
harm

On Wed, May 20, 2015 at 2:20 PM, Jessica Frazelle <me@jessfraz.com> wrote:

> if the machine is not a remote host (aka not windows) & has apparmor
> enabled it will run
>
> On Wed, May 20, 2015 at 2:16 PM, Eric Windisch <notifications@github.com>
> wrote:
>
>> Is this script only used for our CI? We might not want this to run on any
>> machine simply compiling docker or running its tests.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/jfrazelle/docker/commit/6f75dd85c5adbced787a2e15aa7e9ccd71289749#commitcomment-11293670>
>> .
>>
>
>
>
> --
>
>
> Jessie Frazelle
> 4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
> pgp.mit.edu
> <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>
>

--

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>


line 483 - excluded any active lines using get_cpu_idle_time


doesnt effect the one on the host

On Wed, May 20, 2015 at 2:21 PM, Jessica Frazelle <me@jessfraz.com> wrote:

> but this is apparmor _in_ the container of course, i dont think it can do
> harm
>
> On Wed, May 20, 2015 at 2:20 PM, Jessica Frazelle <me@jessfraz.com> wrote:
>
>> if the machine is not a remote host (aka not windows) & has apparmor
>> enabled it will run
>>
>> On Wed, May 20, 2015 at 2:16 PM, Eric Windisch <notifications@github.com>
>> wrote:
>>
>>> Is this script only used for our CI? We might not want this to run on
>>> any machine simply compiling docker or running its tests.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/jfrazelle/docker/commit/6f75dd85c5adbced787a2e15aa7e9ccd71289749#commitcomment-11293670>
>>> .
>>>
>>
>>
>>
>> --
>>
>>
>> Jessie Frazelle
>> 4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
>> pgp.mit.edu
>> <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>
>>
>
>
>
> --
>
>
> Jessie Frazelle
> 4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
> pgp.mit.edu
> <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>
>

--

Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>


should have a screenshot here


line 712 and 713 - excluded any active lines using get_cpu_idle_time


You need to make it clear that these grades can be checked off as the test cases are being run.


I know - static buffer bites but I'm sticking with the upstream style


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We discussed about this some time ago in the context of extension API.
A cache implies that items in the cache can disappear without the user having control of it. In this particular case, configs can participate of transactions, so a config can't be removed until the transaction has finished.
Adding that logic adds complexity that could be not required as there is no going to be too many configs in real applications.
Anyway, if you think is needed, I would ask to do it in a different JIRA


:+1: Thanks!


BTW. I have not changed the order of the embedding and the lifting in DETransformer. The input into the embedding will therefore be

```scala
{
  import ch.epfl.directembedding.transformers.RewireEmbeddedControls._;
  {
    import ch.epfl.lamp.slick.direct.`package`.Config._;
    ch.epfl.lamp.slick.direct.Config.lift(users).take(ch.epfl.lamp.slick.direct.Config.lift(1))
  }
}
```
because users is a captured variable. This will break the embedding since `lift(users).take` will not bind to the `Query.take` method. I think we need another round of brainstorming.


This commit causes this failure for me on OS X:

```
    JULIA test/cmdlineargs
     * cmdlineargs         exception on 1: ERROR: LoadError: test failed: ("/private/var/folders/4g/b8p546px3nd550b3k288mhp80000gp/T/juliaeZCsLA" == "/var/folders/4g/b8p546px3nd550b3k288mhp80000gp/T/juliaeZCsLA")
 in expression: readchomp(@cmd "\$exename --machinefile \$fname -e \"println(bytestring(Base.JLOptions().machinefile))\"") == fname
 in error at error.jl:21
 in default_handler at test.jl:29
 in do_test at test.jl:52
 in anonymous at no file:79
 in include at ./boot.jl:252
 in runtests at /Users/stefan/projects/julia/test/testdefs.jl:197
 in anonymous at multi.jl:628
 in run_work_thunk at multi.jl:589
 in remotecall_fetch at multi.jl:662
 in remotecall_fetch at multi.jl:677
 in anonymous at task.jl:1392
while loading /Users/stefan/projects/julia/test/cmdlineargs.jl, in expression starting on line 3
ERROR: LoadError: LoadError: test failed: ("/private/var/folders/4g/b8p546px3nd550b3k288mhp80000gp/T/juliaeZCsLA" == "/var/folders/4g/b8p546px3nd550b3k288mhp80000gp/T/juliaeZCsLA")
 in expression: readchomp(@cmd "\$exename --machinefile \$fname -e \"println(bytestring(Base.JLOptions().machinefile))\"") == fname
 in error at error.jl:21
 in default_handler at test.jl:29
 in do_test at test.jl:52
 in anonymous at no file:79
 in include at ./boot.jl:252
 in runtests at /Users/stefan/projects/julia/test/testdefs.jl:197
 in anonymous at multi.jl:628
 in run_work_thunk at multi.jl:589
 in remotecall_fetch at multi.jl:662
 in remotecall_fetch at multi.jl:677
 in anonymous at task.jl:1392
while loading /Users/stefan/projects/julia/test/cmdlineargs.jl, in expression starting on line 3
while loading /Users/stefan/projects/julia/test/runtests.jl, in expression starting on line 5

make[1]: *** [cmdlineargs] Error 1
make: *** [test-cmdlineargs] Error 2
```


I don't understand what's going on in this section.


Flexible Box Layout Module jck is not supported by: IE (8,9,10), Android Browser (4.2-4.3), IE Mobile (10), UC Browser for Android (9.9)


CSS3 selectors jck is not supported by: IE (8)


CSS Generated content for pseudo-elements jck is not supported by: IE (8)


CSS outline jck is not supported by: Opera Mini (5.0-8.0)


CSS3 Box-sizing jck is not supported by: IE (8,9,10,11), Chrome (37,41,42), Safari (8,7.1), Opera (26,27,12.1), iOS Safari (8,7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), IE Mobile (10,11), UC Browser for Android (9.9)


CSS3 Border-radius (rounded corners) jck is not supported by: IE (8), Opera Mini (5.0-8.0)


@Roldak, this needs not be copied, I forgot to remove it :-1:


Waarom container?


I forgot to remove it after the test passed :)


Instead of doing if == "\n", do this:
`first_name = @input.gets.chomp   # chomp removes the newline at the end
first_name = old_name if first_name.blank?
Note also that you don't need to use string interpolation for old_name, `"#{old_name}"` is exactly the same as `old_name` on its own
`


What about all the other fields? ;)


@pabloros can give you the exact example that took us to this change. Fish memory, you know. 😅


Can you please file a bug with problems? It's unlikely to get stable without wide usage.


What about all the other fields?


Please use triple-equals in javascript. See: http://stackoverflow.com/questions/359494/does-it-matter-which-equals-operator-vs-i-use-in-javascript-comparisons/359509#359509


`ListField` can't be optional, because it ignores validations errors of list items. It happens for both list of primitives and list of subdocuments. See added test cases.


Although this works, it's not very idiomatic. Do the Update on one line, and save the result in a variable. Then call @output.puts.
Actually, Update.update probably shouldn't be producing output text--the screen should be doing that


This code doesn't make any sense. If there's a dead letter queue then there's no flow failure and the file must be consumed.

This component should be agnostic of PostProcessAction


And seriously descr for 'description'?  What are we writing in assembly?


Same comment about interpolation, you only need to say `@output.puts display`


would have been nice to update the CLI tests as well ;)


This is the line which broke span positioning. Changing `htmlentities` back to `htmlspecialchars` fixes the spans, as explained in https://github.com/prismicio/php-kit/pull/106 -- but I should have written it to make the textNodes manually (which automatically escapes) rather than using the `createElement` shortcut anyway.


You need another to test to actually test that the user gets deleted


Overall very nice.  Once the images are added in, I think it'll be pretty easy for people to follow,

You also need to make the following changes:

1. Make it clear that both students and TAs can run this program.

1. Make it clear where the grades file comes from and goes after the testing is done.

1. Make it clear what the format of the grades file is that `runtests` is expecting.  This should be done in a separate file.  All of the information in this document that isn't directly related to the tutorial should be in this separate file.

Any questions?


does this work if they click on the ad, then load another one, then click again?


@rumpelsepp In addition to your great suggestions I just want to add, that it would be a really great advantage to include a commit reference to a `CHANGELOG` entry.

E.g. A `CHANGELOG` entry mentions: "Added improvements for commit calender". Then I found a bug in the commit calender (regression). A reference to the commit makes it a lot easier to find the commit then :)


OK. Now `serial_find_extreme` is used when device is a cpu, `find_extreme_reduce` is used when device is not a cpu and has dedicated local memory (`CL_LOCAL`), otherwise `find_extrema` uses `find_extrema_with_atomics` (mentioned GPUs without local memory).


Should this cost gold to do?


Yep, I see you. Now I'll update the contributors' list again.


One SpotXInterstitial instance per ad -- guaranteed by the MoPub docs.

On Wed, May 20, 2015 at 3:28 PM, Scott Julian <notifications@github.com>
wrote:

> does this work if they click on the ad, then load another one, then click
> again?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/spotxmobile/spotx-mopub-ios/commit/8a1dcd74e8bb2816a0c759f7212d4b9274eb6d6b#commitcomment-11293920>
> .
>


If tested field is a subdocument, `field.errors` is a dictionary. And original code was checking dictionary keys as strings and returning true.


Redundant if


What is the purpose of exporting an object instead of the function directly; i.e., instead of

```js
var request = require('o-he-xhr');
request.xhr({...});
```

just import the function:

```js
var xhr = require('o-he-xhr');
xhr({...});
```


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/37b73f0e3c85935e1ab2b7212dec72c20dd52a76/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/37b73f0e3c85935e1ab2b7212dec72c20dd52a76/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/37b73f0e3c85935e1ab2b7212dec72c20dd52a76/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/37b73f0e3c85935e1ab2b7212dec72c20dd52a76/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/37b73f0e3c85935e1ab2b7212dec72c20dd52a76/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Rendering validation errors for invalid items in list


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (349 of 349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would add it in the latter stage of the bootstrap instead, so any non captured 500 exception is reflected in the logfile.


Sorry, forgot to update it.


This concludes the removal of trash files from the initial commit :)

.gitignore should now take care of them for possible future commits.


Maybe we can take a look to later versions of Smarty 3.1 to see if this incompatibility problems with PHP >= 5.4 has been resolved. https://code.google.com/p/smarty-php/source/browse/trunk/distribution/libs/plugins/modifier.capitalize.php?r=4756

If it's possible to resolve this maintaining compatibility with 5.3, using official Smarty releases, what about moving this library as composer dependency?


don't worry, I changed them ;)


Testing validation for sub-document in list


Yeah, including 'px' is optional, but I do like the shorthand... feel free to submit a PR  :)


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.45%25-red.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


`getTimeTakenMillisIfKnown()` can return null too, so I think we need to check both


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Hello,

could You help me out to use it in cutomCell ? It shows me always percentage 0%.

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
    static NSString *simpleTableIdentifier = @"MyCell";

    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:simpleTableIdentifier];

    // Display recipe in the table cell
    StbEntry *recipe = (_channels)[indexPath.row];

    UILabel *recipeNameLabel = (UILabel *)[cell viewWithTag:103];
    recipeNameLabel.text = recipe.stb_name;

    UILabel *recipeDetailLabel = (UILabel *)[cell viewWithTag:104];
    recipeDetailLabel.text = recipe.stb_ip;

    MCPercentageDoughnutView *test = (MCPercentageDoughnutView *)[cell viewWithTag:200];
    test.dataSource = self;
    test.linePercentage = 0.02;
    test.percentage = 1.0;
    test.animatesBegining = YES;

    return cell;
}


Yes, but dep(x + 1).contains(x). I've added negative examples as well: https://github.com/scalan/scalan-ce/blob/279b4b42647c793af2f25f8953582b123d162245/core/src/test/scala/scalan/primitives/FunctionTests.scala#L58


I would keep this kind of error logging out of framework-related components: let the app decide how to treat errors, don't you think?


Probably... Not quite sure though. I'm just trying to get the core infrastructure implemented and then we can add these little things -- modifications like costing gold could even be done on judgment day, in a worst-case scenario.

I'll have to look through the spec to make sure that things like this aren't left untouched so that we don't end up discovering things like this last-minute.


Other than the inline comments, here are a couple more:

1. `ViewScreen`, `UpdateScreen` and `DeleteScreen` all require the user to choose a contact before performing the operation. You should extract a class from `ViewScreen` that can then be used in all three classes, so that they share code. Call this class `ContactChooser`. It should display a list of contacts and take input from the user, and return the index of the contact chosen.  When the three `Screen` `perform_action` methods are called, they should delegate to this class:

````
contact = ContactChooser.new.ask_choice
```

2. There's definitely some code in here which wasn't test-driven. We need to do some katas in order to improve your discipline here.


The model doesn't provide any interface to get to the prediction of the model. The loss function is thus not computable, especially from outside the model.


Yes, I would like to extract one. Not so easy though, it depends on the traces so it does not always happen.


Rename this field `maxAttempts`


ListField can't be optional, because it ignores validations errors of list items. It happens for both list of primitives and list of subdocuments. See added test cases.


This is probably a comment for another time and place.  The arguments for `parse_amount` and `amountFromString` are in opposite orders.  It might be good to harmonize them at some point in the future.  In the mean time there's probably not much risk for a bug, since the arguments are different types (hurrah!).  I'm not expecting you to change either of these signatures, Nik.


If tested field is a subdocument, field.errors is a dictionary. And original code was checking dictionary keys as strings and returning true.


Redundant if


Rendering validation errors for invalid items in list


Testing validation for sub-document in list


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-ThreadSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


General comments :
- We need to address the update mechanism : it's a bit convoluted as it is and I predict headaches about it down the road.
- We also need to better specify the Optimizer to unload most of the responsibilities from the individual optimization algorithm.
- Last problem to address is the supervised vs unsupervised learning dataset definition.
  Ideas : preprocessing to remove targets, targets included in the dataset and specified with an attribute, specific checks when building the function.


Please pull this rename into a separate commit "Fix attempts field name in RetryDriver"


There's also https://mf4.xiph.org/jenkins/job/libogg/ btw.


If tested field is a subdocument, `field.errors` is a dictionary. And original code was checking dictionary keys as strings and returning true.


I think that in the very beginning the Filter class was always included so the behaviour was consistent in all executions. With the lazy loading and other changes now the Filter is not invoked by default, so yes, strange things might happen.

Emptying the variables was for security reasons. We'll leave that responsibility to the developer, I am not against it.


No, Plasma 5 pretty much sucks, in Kubuntu 15.04 at least . Right now I'm only using Ubuntu 15.04 because I'm waiting for Fedora 22 to come out to see if Plasma's any better in it. If not I'll probably use Fedora 22 GNOME. I appreciate the general purity of Fedora(as far as not hacking to pieces upstream stuff) When I use Ubuntu it always feels like a hack,lol!!!

I can fire up a VM or run it off a LiveUSB although in Kubuntu 15.04 I still get an error that it can't find the love/ban icons.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why this move ALL node, not just the one with inputs on the GPU?


These should pass `retryCounter` rather than clearing it, allowing these setters to be called in any order


From what I see in JIT compiled trace for the following example:

```
require("jit.dump").on('A', 'jit.dump')
local ffi = require("ffi")
local bit = require("bit")
local rshift = bit.rshift

local n = 0x87654321
local orig_n = n
local a = ffi.new("int[5]")
ffi.fill(a, ffi.sizeof(a))
assert(orig_n == n)
for i=1,1e9 do
        local x = tonumber(a[0])
        assert(0 == x)
        n = bit.rshift(n, x)
end
assert(orig_n == n)
```

LuaJIT will be using the following code for the loop:

```
->LOOP:
0bceffe0  shr ebp, cl
0bceffe2  add ebx, +0x01
0bceffe5  cmp ebx, 0x3b9aca00
0bceffeb  jle 0x0bceffe0        ->LOOP
0bceffed  jmp 0x0bce0024        ->5
```

`shr` is noop when used with zero argument (tested with separate C case compilation with gcc), but it seems not the case with BitOp:

```
LuaJIT 2.0.2 -- Copyright (C) 2005-2013 Mike Pall. http://luajit.org/
JIT: ON CMOV SSE2 SSE3 SSE4.1 fold cse dce fwd dse narrow loop abc sink fuse
> bit=require("bit")
> =bit.rshift(0x87654321,0)
-2023406815
> =0x87654321
2271560481
```

I would assume that `rshift(X, 0)` should always return `X`, but I'm not a bit hacker, so I might be missing something here.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sorry, forgot, but the tests should really not make assumptions like this.

Use https://github.com/npm/read-package-json so you get a normalized package.json ;)


:+1: thanks @ericorruption


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@seelabs Sounds good.


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I think this should go above the `try` block. Only counting on exception means that a retry will not be counted if it succeeds.


Merge pull request from master


Could be done as an init task?

All we'd need is an abstract method in the model definition that initializes the model.


Should we not organize it in "public/javascripts" ?


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


This is the same code that is in GpuAlloc before and it never crashed.  Why would it start now?


Please squash this commit into the first one.


@kevinburleigh75, @Dantemss isn't cool.  FYI.


Have a fix – will push shortly.


hehe


We actually started with "oh, we'll just write to /dev/stdout, problem solved", only to discover that, on Heroku, /dev/fd/* and /dev/std* are not writable (permissions, not functionality). We haven't followed up with Runtime to investigate why; we'd _also_ like to get rid of this sidecar process approach, since the degree of Unix involved is worryingly high.

I'm 95% convinced there are ways out of the boot script that leave one or the other child running.


u r so smrt


@hastalafiesta- , this is needed for libwvm.so
https://github.com/CarbonROM/android_frameworks_av/commit/c9823b03aca40eb0a21525d37ceb168cf80f1fab


.map() ist returning an [] of just the truthy actor matches


Should return the XMLHttpRequest instance to the caller.


Oh—I scrapped this PR—didn't feel confident about the direction I was going.

I'm not sure who put express-session in the app—but that was prior to these changes. The current API allows us to put a session store of our choosing into it—but it's limited by the requirements around the store API.

For example, the current problem I'm working on—how can I get a koa session store in there—

But yeah, this is an old/closed PR.


@vinniefalco I added code to OverlayImpl to add the manifest to the db when it is added to the manifestCache.


We should also change the filename


Nice switch to gets


Isn't `end` measures in bytes?


The nervana kernels are not the same as the old back-end.  I don't see why anybody would expect that.

Also, no, it's not possible and it won't work with fortran-contiguous C.


Should I activate these changes?  I can roll back if it breaks too many things.


I should rephrase: the `for` loop and `if` statement don't seem to affect the logic of the application. Calling `.map()` alone works just fine.


This would be a lot clearer if we separated the post and the get routes

http://stackoverflow.com/a/17730089/98080


Omg thnks!!! Ill check on it right now when i get home .. Ill let you know how it goes!!


@scottschurr @ximinez @vinniefalco I believe the latest push addresses all your comments except for Scott's suggestion on a docs terminology.


Wrong name, probably. Should be something like "Keycloak Model Invalidation Cache Parent".


This could be specified directly in Smartpy. It'd need an abstract model `fprop` methods.


Ditto here about the `start` being measured in bytes, not runes.


possibly here?


Because I assume that if you get to the optimizer, it will be the case.

But I could use op_lifter instead, yes.


I think, in the INI file is right to use '=' sign instead of ':':
...
mario-game=MARIO GAME
peach-game=PEACH GAME
...


I'm thinking this should be a `Runnable` rather than coupling it to a `CounterStat`:
```java
.onRetry(STATS::newGetMetadataRetry);


It does. It can send both the raw inputs, as well as the translated/calculated output.


Reviewed PR and good with changes.


:metal:


Move these above after the other `@Manged` methods


Probably worth extracting this method from the `Model`


Yes, that's your understanding of JavaScript that's at fault: for..in enumerates properties. Still, this is not great style nowadays, and I should enumerate own properties here.


Theres 3 main properties a wallet should have:
 - balance
 - unique id (Address)
 - private key that can verify the unique id (BTC uses the public key as the unique ID)
This wallet comes with little bit more overhead because you’re adding functionality to communicate with the network.

This implementation lacks a core aspect of the bitcoin protocol: ownership. The blockchain stores all valid transactions, which are verified through a chain of ownership i.e.

Bob gifted 10 coins -> Gives 5 to Alice -> Gives 2 to Carl

Carl cannot give away 3 coins because he has no way to prove that he owns 3 coins, he can only trace back ownership of 2. Let me explain a little bit more about how that trace works in BTC.

Each transaction has an `ins` & an `outs` associated with it. The ins point to previous transactions, outs to destinations. So when Alice gives 5 to Carl, shes really saying:
“Here, I was given 10 coins, see?”
*points to record of bob giving her 10*
“And I’m going to give 5 to Carl and the remaining 5 back to myself"
```
var transaction = new Transaction();
var reference = /* reference to previous transaction from Bob
                (think of it as a key in the giant blockchain hash †)
                      † the blockchain is not actually a hashmap  */
transaction.ins.push(reference);
var outsToCarl = /* raw transaction giving Carl 5 coins */
var outsToMe = /* raw transaction giving me the remaining 5 coins */
transaction.outs.push(outsToCarl, outsToMe);
```
Then you sign all the outs, and broadcast the transaction (which people then verify and add to their own blockchain, or reject if verification fails). This [link on transactions](https://en.bitcoin.it/wiki/Transaction#Explanation) may make more sense.

There’s an opportunity for [double spending](https://en.bitcoin.it/wiki/Double-spending) but bitcoin don’t play that hommie.

Also, see https://bitcoin.org/bitcoin.pdf


Isn't this a dupkicate of the functionality of `Xwt.ComboBox`?


@danpovey, @jtrmal: The pipes in windows are normal pipes for all practical purposes. There is a _popen() in the CRT that tries to hide differences (and there is actually very little; the mechanism is called anonymous pipes, q. v.). The problem is not how pipes work from the C program standpoint, but rather with the command line that kaldi passes to `popen()`. The command line is interpreted by `cmd.exe` in Windows, and the syntax is generally incompatible with bash. Pipes like `"gunzip -c  | sox |"` will work provided you have a port of lame and sox, which are widely available. Pipes like `"cat * |"` will work provided you have a port of cat(1), and this practically means you need cygwin, or, at the least, I am unaware of a standalone port of cat. Absent unix-style shell, who needs it. To sum up, I think the best approach with pipes would be as follows:
* Run the command line to `popen()` through `bash` if the calling process is launched by `[ba]sh`;
* Do not use `bash` if launched as a native process, use the default `cmd`
* Be able to override both of the above default behaviors.
A little bit complex set of rules, but the user should think of the first two options as "always using the default launching shell to interpret pipe command lines." This looks like a reasonable default to me.


I don't agree. Adding in the latest execution point a simple control to log uncatched 500 errors can save you the day. The application would still be able to capture them and act as desired. But if we don't log any errors we are assuming that the application should be prepared in any controller workflow and for any service interaction to be able to treat them.

In your scenario if any service is down (or any other 500 reason), the application should anticipate that this kind of error could happen and act accordingly, because the framework wouldn't do anything with it. Are you aware that if you don't explicitly code the error treatment you won't be aware in production that Smarty doesn't have write permissions, that a Mysql slave is down, or that Redis is not listening in the port to name a few?

I am definitely for logging critical errors, is the most important thing to find out problems in the application.


Will wallets be able to communicate with each other if you set the new socket to the specific wallet? Maybe have a central blockchain all wallets communicate w/? Otherwise you’d have to separate wallets & network nodes. There’s probably a 3rd option


Sure. I think npm install -g git+ssh://git@github.com:prestifidibs/sinopia.git should work


Took out signup button at end that was linked directly to the web app.


We don't use `final` on local variables (or parameters) unless necessary


90210372-ChillerElectricEIR-still-delivering-chilled-water-#4453 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1656 of 1657 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Added mailchimp form.


Yes: the closure where self is used, inside the map, would have this pointing to the function it's in, instead of the scope. Where there's no such problem with closures, this can be safely used. I could have limited the use of self to the inside of the closure, but once I have self, I find it less confusing to use it exclusively instead of this.


ARE YOU BLIND?


Not sure why this isn't showing as my commit....!


Good showcase of the SmartPy lib.


Oh. Looks like a much superior setup. Now I'm not sure why you need travis at all...


you can just npm install -g prestifidibs/sinopia too :-)

--
Tim Whidden | VP, Engineering
(e) tim@1stdibs.com
(p) 212.627.3927 (ext. 178)

On Wed, May 20, 2015 at 5:54 PM, prestifidibs <notifications@github.com>
wrote:

> Sure. I think npm install -g git+ssh://git@github.com:prestifidibs/sinopia.git
> should work
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/prestifidibs/sinopia/commit/2f684ca52a9945200239f5d0949ac76b90ade1d3#commitcomment-11294398>
> .
>


Everyone on windows should be using check out as windows and commit as Unix


Ah, I forgot platform differences. Will it work on darwin without that line? IIRC the non-executability of the library was causing problems on linux.


That would be a great improvement.


![Uploading trello_addcard.png…]()