Am 17. Mai 2015 12:59:43 MESZ, schrieb SebastianS90 <notifications@github.com>:
>@mmalte Did you try gluon on an Archer? I have an Archer c7 v2 with
>openWRT as my primary router and think about flashing v2015.1 to it.

Gluon does is no supposed to be used as dsl uplink per default. It is quite a bit of work to add that and make it work with all the Freifunk bridge devices.

>If I understood you guys right I could use 2,4GHz for mesh + freifunk
>AP + private wifi AP and 5GHz for freifunk AP + private wifi AP.

Yep, exactly the way it is.
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.


... here can be removed, this is code that is already in the `js/mail-generator.js` file.


This looks really promising. I think if we implement a DataFX Flow window for configuration and integrate it with this, mixed with a new way to display uploads by providers, this'll be ready.


I know that it should work. :smile:  Unfortunately, I could not figure out which part of code needs to be changed.
However, the more I learn about it, the more I am able to do - we will see in a couple of days...


Fix commnet text, should be: Get V_CONST if variable is constant


I know this is autogenerated by EF, but should we be setting a consistent name for the foreign keys, rather than using the sql generated ones?
Should this FK also be a cascading delete?


When the connection is dropped, then the proc is called again and will be reconnected. What do you think is a better behaviour? Within Rails the connection is on Class-Level and not on Instance-Level. Would this be better? With a `establish_connection` method?


Cool


please man... align this... OCD!


:beers:


No rush, take your time


Falsches alignment übergeben. Hier muss geprüft werden, ob das Feld, auf das gezogen wird, vom Gegner bedroht ist!


:+1: for more flexibility


Hello

Sorry for my late reply. I actually do not really have a deep understanding
of ZotFile. As I currently have no time at all, I cannot help you at the
moment, sorry. I keep you're issue in mind. If I ever find time to code on
ZotFile, I would get back to you and your issue.

Greets and I hope somebody will find the time to help you.

2015-05-01 23:04 GMT+02:00 Andrei Beliankou <notifications@github.com>:

> Hi, @Kowalevskaja <https://github.com/Kowalevskaja> !
> You seem to have a better understanding how ZotFile works.
> Could you please help me with that issue if you have bit time?
> #166 <https://github.com/jlegewie/zotfile/issues/166>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Kowalevskaja/zotfile/commit/0091e279d8e40eb358c148ca148f05db20b8b0f5#commitcomment-11007816>
> .
>


Should we reset other flags here? like `isFlushed`


Maybe that sortnet uses two contexts. Anyways, the code documents it.


Updated.


Can merge the strings


Нельзя сравнивать дескриминант с нулем. Лучше использовать переменную в пределах ошибки вычислений. Например ДЕЛЬТА < 10e-15


No, fine. Keep it! :+1:


will fix this together with later review comments


On Sun, 2015-05-17 at 20:40 -0700, Siti Nurafifah wrote:
> Hi, how do i select number of times each person is the committer and
> the number of times each person
> is the author

In case you are referring to "regular" identities (eg, before merging
the potentially many identifiers that a single person can use), you need
author_id and/or committer_id fields in scmlog. For example, for
authors:

```
SELECT count(scmlog.id), people.name, people.email FROM scmlog
JOIN people ON scmlog.author_id = people.id
GROUP BY scmlog.author_id;
```

Please, let me know if you need some more info.

	Jesus.

--
http://twitter.com/jgbarah          http://gsyc.es/~jgb


We shouldn't update this until we know it works.


ну `MainCtrl`, но никак не posts


I see this pattern here and there, which is essentially a workaround for `Environment` not having a `dict`-like `get` method, where you can specify a default value. The omission of `get` on `Environment`, however,  was intentional, because that duplicates what the default top-level environment should do. So instead of try-except KeyError, I suggest you to feed in dict(write=False, loop_nest=[]) as the top-level environment when you first call the visitor from outside.


Strings can be merged


Nice one! I consider this a critical issue. Applied patch and everything working as expected.


Nice!


@isaquedias o link do Meetup da Bahia precisa do `http://` na frente.
Seria bacana colocar também o Meetup de São Paulo http://www.meetup.com/Aplicativos-Hibridos-Meetup/
Remover o `?fref=ts` do link do grupo no Facebook.

Go go go \o/


Changed names of some APs to be more dynamic to room name changes


You mean the caller of the visitor? *If* so, that sounds like exposing the visitor implementation details to the caller


:+1:  5e33290


`.filter(…).shorterThan(1)`? That’s lazy and aborts as soon as the first element is found.


Yes it should.


Минимальная реализация. Адрес храниться в тексте "кнопки" для больших путей это не хорошо.


TeamCity xBIM :: XbimExchange :: Build [Build 286](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1633&buildTypeId=XBIM_XbimExchange_Build) is now running


bra commit!


Ser bra ut. Det är bara io såvitt jag vet, och inget annat än ?


Really? I'm using only phpStorm and it normalizes idention.


@stof I opened the issue https://github.com/symfony/symfony/issues/14679


Nit: please use a new line between define and "use strict"

Honza


TeamCity xBIM :: XbimExchange :: Build [Build 286](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1633&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:02:48


Should choose one "layout" format for matrices.
Think the one below is better as it maps the data visually better?


Fixed [here](https://github.com/marmelab/ng-admin/commit/6f6f2071520bb3381575c6fb0a6c8706e0c6313a)


So if you're worried about that, I think the best thing to do is to wrap the `MyVisitorClass().visit(tree, env=dict(...))` call with a utility function `my_visit(tree)` which would be the only place where the top-level default environment `dict(...)` is specified, and use the utility function for *external* callers.


All UI strings should be localized using Locale.$STR() API

Btw. the "Options" button needs localization too (can be done as a follow up).

Honza


nope, no space here --- see the rendered man page (e2 is no longer a documented param, it's the param description)


Maybe add a default value ``request.POST.get('js_submit_for_moderation', 'no')`` so it fails silently if, for whatever reason, this field gets omitted.


I would still split on the "or".


the same here


you see that here :)


Thank you for your comment, however I am going to push the version not migrating FALSE.

Any other comments from the ABRT team members?


More precisely :
- I install my project and all its modules
- I edit my composer.json to add a patch for one of the modules
- "composer update" does nothing
- "composer install" does the remove/redownload/repatch stuff


What's wrong with `Iterable.any()`.


I'm just doing a quick browse and this line popped out at me. The whole `NaN` issue versus *should* be resolved when we go `v0.4` and `Nullable{T}` becomes available. At which point there will be a significant update to many of these quant-related packages.


@hmeng-19, please use the value of the variable CCTOOLS_VERSION.


Perhaps edit this. Not a "bug" in the way we think, more user land mistake.


It might be enough with raising an error. when problems like this would occur it is probably an architecture issue. connections should not be closed or finished while application is running right?

What about http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/ConnectionPool.html ActiveRecord::Base.connection_pool.with_connection(&block) ? Is that something that could be used?


I would suggest not to test the private flag.


Same as previous


No, we shouldn't, it is used only once inside [ResponseTransform](https://github.com/catberry/catberry/blob/5.1.1/lib/streams/ResponseTransform.js#L116).


Even better


The default value for `request.POST.get` is None, so it will fail silently if the field is omitted.


The default value for request.POST.get is None, so it will fail silently if the field is omitted.


That way your top-level environment is clearly defined at one place, instead being scattered in various `visit_Foo` functions, which can even contain contradicting defaults. (For example, `visit_Foo` might consider `write` to be `False` if not set, but `visit_Bar` can assume it's `True` in the same case.)


Didn't know that! Cheers! This looks good to me. I'll push live


Faltou apenas o import do tipo "List"


Fair. We should ignore the file again, and either rotate the secret or require an environment variable which contains it to boot the app.


Faltou o import do tipo "List" também :D


I think we should use standard Open/Save file dialog (nsIFilePicker) to have better user experience - you can see PixelPerfect for an 'open' example. This means that the implementation should be done in inspector-window.js (chrome scope). There is already a communication channel between content and chrome (see InspectorWindow.onContentMessage)

Honza


This could fail if the extension is localized.

Honza


Unpersonal "you" and "your" should always been written with capital letters! Also I've always been a friend of the Oxford comma.


Was it really necessary to *remove* the MIDI code? You could've just added a blank MIDI wrapper class that returns true and doesn't do anything.


Just like above, we shouldn't use titles, rather some kind of ID.

Honza


What is the purpose of this change? I don't think it is necessary.


`when bubbling down animation ends`


合并


Is there any way to move `SchedulerResolution` dependency from `ScheduleInstant` to `RecurringJobScheduler`?


I think `temp = (nums[i], nums[left], nums[right])` should work here.


Unused Variable should be deleted


See above, just make a blank class and implement it later.


- Os nomes dos atributos devem iniciar com minusculas.
- Tem que por o relacionamento com a classe Sport e RelUserEstablishment apenas, só declarar como estes outros tipos.


Ah, it didn't work here, but maybe I didn't have gtest installed or something like that, I didn't investigate further.


Hmm, I'm not 100% with the augments. The blurred outlines around the inner items/blocks are a bit intrusive with the background. The background is okay (frame wise) but the backing and the items on top I think could do with more work, or maybe a change of how it works. I've been hindering on what to create for them as being a mildly complex texture as you're working with multiple layers of texture. I dunno I think those textures need to be discussed more to work out something. Which works better. CC: @goldbattle, @Shoeboxam


I've also renamed the includeProperties to includeOnlyProperties and the mixed test with an exclusion overrule is done. It was already done in fact.


I'd go for typewriter font, as it's a Python tuple!


Minor issue: testing app by multiple downloading the same file.
    Thread name is added to avoid getting equal file names on ThreadPool
    execution when System.currentTimeMillis() easilly returns the same time.


Hum yes, sorry about that, in fact I did not want to commit this, I had also some problem building this (which then turned out to be network problems, so totally unrelated). I probably shouldn't have done that so late in the night…


`pass` should be size of `64`. I had a problem where no user in my application could login, then I tried with an old download I've did last year and it worked perfectly. So I looked and found this problem. After I changed to `255` it worked.


`while not queue:` would be considered (by someone) more pythonic.


May be worth using Canonical JSON here so this isn't tied to Python's json library.


Comments acknowledged, we'll work on that today.


I commented out that section from the product pom to get the build working again.

From: Richard Fearn [mailto:notifications@github.com]
Sent: Monday, May 18, 2015 4:32 AM
To: ControlSystemStudio/org.csstudio.product
Subject: Re: [org.csstudio.product] cs-studio.target: Remove, it's been replaced by target in cs-studio (e6b0af0)

...and the build fails with "Invalid base target definition file". Reverting this commit allows the build to succeed.

—
Reply to this email directly or view it on GitHub<https://github.com/ControlSystemStudio/org.csstudio.product/commit/e6b0af0634d13aaf811159812f843061211155ab#commitcomment-11235755>.


Just curious, is it possible to use `evt` directly?


What's going on here?


Problem plugins and mod configuration appear in the commits: https://github.com/yump/KOS/compare/copy-dlls...abenkovskii:this_happens
Proposal: ignore plugins directory: https://github.com/yump/KOS/pull/1


@tvsonar At the end of this file, the method `FilesAreEqual()` should be simplified to something like `File.ReadAllBytes(...) == File.ReadAllBytes(...)`. The streaming comparison looks like premature optimization: The whole models (XML & OMSTAR) for all issues are loaded at once in memory, so memory usage can't justify such a complex function ;)


We also have to rename them in the firmware itself. I just did that.


Please if possible, configure your code editor to not generate an extra new-line character at the end of Red files automatically.


The minimal XDG spec validation occurs in the "checkValidity()" function below (since it is a lot more complex than just the "name" field existing). This structure creation function should only return false for major issues preventing the creation of the data structure from the given file (such as invalid permissions or file format).


Note that all files which contain tests should probably end with `Test`


oops gotta vvrong datetime setup:(


this is a bad idea. You don't provide newer versions of the implementation


You could use `numerator *  denominator < 0`. This might be less efficient, but requires less typing. :wink:


@acmeid
回复的时候已经发布了，如果你安装不到，一般是npm的缓存问题，可以直接指定版本：

```
npm install -g scrat@0.4.8
```


Vaughan suggested that too on audacity-quality, so I will make that change later on today.


zatem to jest tylko początek. teraz chciałabym połaczyc tą część z klasą w której dodaje się studentów no ale nie wiem. Będę kombinować.


powodzenia! :)


This sounds like related to #23.


I don't think there are other cases here... `else` should be enough.


Powodzenia


That sounds about right :+1:


Some times it happens that a connection get lost. For instance a DB-Server is restarted, a router has a hickup and so on. Because of this Rails and database driver offer a possible automatic reconnect. Within your app you are not able to handle this Exception. Rails can still execute queries because of the automatic reconnect, but you aren't able to access the Backend-Object with an easy method and reconnect.

`with_connection` looks nice, but do you realy want to depend on Rails? Refile works also with none Rails apps, right?


This commit files issue #58


Dzięki :)


Maybe shall we open an issue so we don't forget ? I guess 64x64 is a good size


why wrap it? I don't see the wrapper class doing anything except delegating the calls of `d`.


Add default value for new option. This default value make same behaviour like without this option.


Documentation for new option


Note that with such a straightforward return value (just a hash), you can skip creating a local variable and just return the hash value itself:

``` js
return {
  title: courseTitle,
  duration: courseDuration,
  students: courseStudents
}
```


oh nvm, it's a factory


Well, why not...


Не обязательно использовать this. Обращения автоматически разрешается в объект к которому относится метод.


Oh hello! :) Wasn't expecting a reply!
Thanks for taking a peek though. This is in *noway* finished or anything; I was just getting rid of everything that stopped OS X Yosemite building, so I could get *something* up on screen. We most definitely need MIDI and indeed, the sound textures for the live coding session we are running;  we'd like to go both Windows and OS X.
Im working on this port as and when time permits but it will be this week for sure. I'll use these changes you've sent! Cheers!


Commit https://github.com/Euphoria-OS/kernel_motorola_shamu/commit/451cbde9849668eef190028e72be125bb6a8241d has a dependencie here. Just add right on line 4:
    #disable zen decision
    write /sys/kernel/zen_decision/enabled 0


I see we took similar approaches - only you seem to have embedded colours directly into the terminal info, while I added `attr_ex` structure for this.

My patch is available at https://github.com/rr-/mintty/commit/9bfac3353a093c904fcdb4a14f12aae483bf83c5 .


This is very close to a Romanesco spec. I think the main difference is that Romanesco calls them `inputs` and `outputs` instead of `input_ports` and `output_ports`. I have thought of a `function` mode for Romanesco which this seems to implement.


Can you please explain? I don't understand...


This breaks compilation when USE_NGHTTP2 is not defined.  Should we move the initialization to Curl_http2_setup_conn()?
```
http.c: In function 'Curl_http_setup_conn':
http.c:171:22: error: 'NGHTTP2_NO_ERROR' undeclared (first use in this function)
   http->error_code = NGHTTP2_NO_ERROR;
                      ^
```


There's a class called `Counter` in python `collections` which you can use. See: https://docs.python.org/2/library/collections.html#collections.Counter

A simple example demonstrating what it can do:

    >>> from collections import Counter
    >>> c = Counter()
    >>> c[1] += 1
    >>> c
    Counter({1: 1})


Can we change it to only send emails on new failures?
That said, I'll fix the PSR-2 stuff tonight.


right, some shit got damaged due to es6 rewrite :D


Nice implementations.


@weierophinney saying you provide ``psr/http-message-implementation: ^0.11`` means you provide *future* versions of the implementation. This cannot be true, given you don't know how future versions will look like


![its_all_you](https://cloud.githubusercontent.com/assets/163977/7680373/f6e36fda-fd33-11e4-920f-3ae441d838cf.png)

Monstruo, monstruo.


Maybe getPageSettingsGroup() ? But showGroup() works also.


I think this has to be `size_t`, like `i`.


Le lundi 18 mai 2015 à 04:42:07, Nenad Rakocevic a écrit :
> Please if possible, configure your code editor to not generate an extra new-line character at the end of Red files automatically.

Ok, I will check that.

--
Stéphane Aulery


Was recently doing a clean install. Came across this, remembered you asked for a PR, but this is perfect^^ thanks.


hmm, not a fan of constant aliases.
either define them twice, or just use a single one.


Is this still true?


just to determine if gapps are already installed (this is the same way tkruzze performed this check, i borrowed this part from him)


On Mon, 18 May 2015, Kamil Dudka wrote:

> This breaks compilation when USE_NGHTTP2 is not defined.  Should we move the initialization to Curl_http2_setup_conn()?
> ```
> http.c: In function 'Curl_http_setup_conn':
> http.c:171:22: error: 'NGHTTP2_NO_ERROR' undeclared (first use in this function)
>   http->error_code = NGHTTP2_NO_ERROR;
>                      ^
> ```

I noticed some further errors when built without HTTP/2 enabled. Fix coming.
Thanks!

--

  / daniel.haxx.se


i removed this part in favor of a smarter method of friday. see this commit:  https://github.com/dankoman30/slimlp_gapps/commit/5761365c42ace44d9cdd108117b051aa9b691547


Если хочешь иметь уникальный Id для ноды, то можно сделать фабрику, которая будет учитывать номера уже созданных нод. Вроде такой
``` c#
    public class cNode
    {
        public readonly int id;

        public cNode(int id, int gender)
        {
            this.id = id;
            this.gender = 0;
            age = 0;
        }

        public int age { get; set; }
        public int gender { get; set; }
    }

    class NodeFabric
    {
        private int _lastUsedNodeId = 0;

        public cNode GetNewNodeId()
        {
            return new cNode(id: _lastUsedNodeId++, gender: 0 );
        }
    }
```


The problem @gubatron is that I believe it's set to be identical in the white paper yet configurable. Kind of one of the weird quirks of the original Kademlia design. I suggest we make the replicate interval a bit longer.


I can see a build break due to the fact that for some reason, the entry is 64 bit and so negative numbers are printed as 64 bit constants:
```/mnt/j/workspace/dotnet_coreclr_linux_debug_prtest/bin/obj/Linux.x64.Debug/src/dlls/mscorrc/full/mscorrc.debug.
cpp:2599:6: error: implicit conversion from 'unsigned long' to 'unsigned int' changes value from 18446744071562526722 to 2147942402 [-Werror,-Wconstant-conversion]
    {0xffffffff80070002, "File or assembly name '%1', or one of its dependencies, was not found."},
```
 This is strange since in the processrc.awk, I had to convert values >= 0x80000000 to negative values, otherwise they would not be printed correctly.
Since I guess you've tested it locally, I wonder if this is somehow awk version specific and the awk on our test server handles the numbers printing differently.
An experiment on my Ubuntu shows that my awk still stores the numbers in their full size, but printf clips them when using the %x, %d or %u format:
```sh
awk 'BEGIN { v = 64424509440; printf "%d\n", v;}'
2147483647
```
```sh
awk 'BEGIN { v = 64424509440; printf "%.0f\n", v;}'
64424509440
```


it's replaced during build by the actual size of the uncompressed files.  for example, here's where it's replaced for zero build: https://github.com/dankoman30/slimlp_gapps/blob/master/build.xml#L126


Looked at the tests and i think you should also include tests for FoamMesh and FoamFiles classes (more or less the same tests as in the IO wrapper side)


支持的哪些node版本？
0.12.2 node 下 出现：
$ scrat server start
npm WARN prefer global fis@1.9.11 should be installed with -g
 ➜ server is running


Erro ortográfico
Quando for criar um construtor a primeira letra será maiuscula.


O nome dos atributos devem iniciar com letra minuscula.


Corrected and fix committed


fis@1.9.11 已经安装了


@tvsonar Why not add this little test method to the other test class?


I bet the name 'num' here refers to the way python handles numbers (I believe it implements integers as other languages would implement BigIntegers or BigNumbers, which is using a bit-array and implementing all the basic operations using bit arithmetic)

If you converted a 160bit (20 bytes) number to `int` in any other language, you'd get a max range error, hell, you couldn't even convert to long (64bit / 8 bytes)

So I guess the name is good. I'd leave as is, `guid_to_int` actually would make it confusing.


@tvsonar Ignored test methods is like commented out code, and it should not be checked-in.


Can we add a remark like `// TODO: We are loosing input if the free space in input_buffer is too small`?


Ok, this is now fixed.


I have no ideas of more interesting (and better) hashFunctions. I only have 2, and completed the table with those. I'll think/look for better hashFunctions after finishing Open Addressing.. (There I can use the double and quadratic hashing.)


Yes, would love a patch pushed up to npm.


We can certainly put it back.

> On May 18, 2015, at 3:32 AM, Sandro Santilli <notifications@github.com> wrote:
>
> I know for sure (used) that the patch size set by the filters.chipper is properly recognized/used by pointcloud plugin (results in patches of the size set via filters.chipper).
>
> —
> Reply to this email directly or view it on GitHub.
>


test


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Where the params for the request ?


This line kinda gives the impression that "add" takes an unbounded list of arguments instead of just a pair, and that by proxy `export` may also. Add also has no error handling for the case where there are erroneously too many arguments.

This makes it look from the code side like `export` and `exports` call basically the same logic, hiding the true internals.

This needs to just be made more clear from the code side.

I would suggest something obvious like

```perl
$meta->add(0, $_[0], $_[1] );
```
To make it clear that $_[2] and >2 are not handled by `add`


Мега яко!!! :balloon: :tada: :dancers:


You can find the bot stuff in this Repo: https://github.com/CreaturePhil/Showdown-Boilerplate
The data folder needs updating massively, but thought I'd point you towards it so you can have a look at how the bot works.
If you want a good testing environment, try koding.com.
Here is a guide to pull files from a github repo: http://learn.koding.com/guides/using-github/
Don't use it for actually hosting servers otherwise you can get banned, but it's good for testing stuff :)


If true I'm fine with that.


Testing from Jenkins.


@tvsonar commented code shouldn't be checked-in


Nice fix thank ! you save my day !


Of which type?


This is going to be used, but in a different way,


Yeah sure, it was just getting annoying today!


i'm still in scala puberty period :)

2015-05-18 12:32 GMT+02:00 Iulian Dragos <notifications@github.com>:

> If what you need is a Boolean, there's nothing wrong with just using a
> Boolean. Let's be pragmatic.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wpopielarski/scala-ide/commit/52ef6ea6ec4b624fe18d8fd840e4d04d9ff056e2#commitcomment-11237812>
> .
>


Isso mesmo meu caro, acho que podemos remover o "String comentario" e alterar outros itens, como por exemplo ao invés de "professor" usar "nomeProfessor" assim condiz melhor com o atributo.


Nicely done. Here, you have the basic layout for most functions you'll write or cross:

1. Default values/assignments. Maybe doing something with the input (`inputArray` here), but not necessarily.
2. Computations (most likely using the input), and/or side-effects (`console.log`, editing the input's value(s), etc.)
3. Returned value (if any)


Damn, missed that one. Again. Thanks!


Ah, you means warnings or errors


哈哈


You could have implemented this using a loop and what's called a *buffer*, that is, looping over the `inString`, one character at a time, registering characters in the same buffer variable until you reach a comma character `,`; when you do so, append/flush the buffer to another array, empty the buffer, and continue with the looping; eventually return the array of registered buffers, all lowercased. As an exercise, you may want to try to do it.

But the way you did it is better: more straightforward, reuses built-in, efficient functions. Good job!


My issue has to do with the fact that I started using this branch within a month of my last migrations. When I made a new migration, it ended up being placed chronologically before any migrations in the last month. Thats because there's no longer a +1 being added to the month. I simply modified the name of the new migration to be a second after the existing ones and things started working as expected again.


I really like that implementation. Using `i++` like that is very smart.


@alexblair1 you've implemented a solution that I never saw coming! I was expecting something like; `return characterDictionary[@"favorite drink"];`


@alexblair1 DWMR. Press on!


cc @thedarkone


Yes. It makes sense to reconnect. What about whenever this lambda/proc is called it also checks if returned object is a usable PG::Connection?


From what I can see from the code, passing `None` will not check the warnings at all (their presence or absence).


How about not calling `test_messages` if expected is `None`? (line 125)


I haven't read the whole program but I think it's a bit complicated. Here's my solution for reference:

    class Solution:
        def comp(self, num1, num2):
            num1, num2 = num1 + num2, num2 + num1
            if num1 > num2:
                return 1
            elif num1 == num2:
                return 0
            else:
                return -1

        # @param {integer[]} nums
        # @return {string}
        def largestNumber(self, nums):
            res = ''.join(sorted(map(str, nums), cmp=self.comp, reverse=True))
            return res[:-1].lstrip('0') + res[-1] if len(res) > 0 else '0'


@fenix008 Having eh, what are you talking about?
This branch is absolutely not made for Windows 7, it is made to be compiled with Visual Studio 2015 on Windows 10.
Visual Studio 2015 is made for Windows 10 and not for antiquity as Windows 7, Windows 8 and even 8.1 are not made for.
Direct X12 is compatible only with Windows 10, and you must have the Nvidia 352.84 WHQL drivers.


Running the Phing script would have prevented this :stuck_out_tongue:


I've noticed this change has caused tests to be turned off for Travis CI too, at the very least they should be turned back on for that? On a related topic, Quoine had some failing tests when I ran "mvn test" at the weekend, presumably going unoticed because skipTests=true.


Instead of adding :authority using predefined constant, it would be simpler to copy :authority from request headers.  See my comment below.


As I commented ealier, we can copy incoming :authority (or host) here, like so: `{<<":authority">>, A}`


this seems to work for me :+1:


It should work as view caching is totaly disabled on searches and forms. Perhaps you missed that you need to remove search method from controller?


@jlucerond Nice touch on the random image.


Yes - I believe it does (https://github.com/galaxyproject/planemo/commit/f463cf34a81c67e747e79c6774644e53693de5f1) - thanks!


Hmm, right after posting the note, I've found that it seems to be a known issue of the mawk and that's the one that is installed on my Ubuntu by default.
http://www.unix.com/unix-for-advanced-and-expert-users/242924-mawk-printf-d-maxes-out-2147483647-a.html

The awk on OSX behaves the same way as mawk, with the only difference that it prints zero if the value is over the max int:
```sh
awk 'BEGIN { v = 64424509440; printf "%x\n", v;}'
0
awk 'BEGIN { v = 64424509440; printf "%.0f\n", v;}'
64424509440
```
But here we can use the "l" modifier of the %x and then it prints the long integer. That doesn't have any effect on the mawk.

It seems that a way to fix the issue and have it working on all versions of awk would be using sprintf and using only last 8 digits of the result.

Something like this:
```awk
hexId = sprintf("%08x", entry)
hexId = substr(hexId, length(hexId - 8))
printf "    {0x%s,%s},\n", hexId, resourceEntriesArray[entry]
```


This isn't a cast issue as it can be fixed by removing the L. However the intent of the code is unclear as the @ character is not a space.


Would not it be better to put #define MAX_OVERSHOOT_PID_AUTOTUNE in the configuration section temperatures pid?


@jlucerond DWMR. This was well done. Press ahead.


How about patching our SLE-11 memcached to always use -d, so we never need it in the params?


oh oh OH! Does this mean I can use `ceylonGrammar` to parse any node type?


ok, yeah... the getUTCMonth is really a stupid function that adds +1 only while daylight saving time. From this point of view it makes sense to announce this as a "behavior anomaly" and outline this for the release notes, as it is not a breaking change it fixed something that was broken under certain conditions (the dst in this case).


I'm pretty lazy to compile .Anyone can share the binary ?


a


For the "warning" when a registration is made public, the original opening paragraph is no longer needed.  The same points are covered in the revised, single paragraph.


So just to give you a quick brief @ZiMMy (why is there spaarmann displayed when you write @?).
I'm going to revert the commit, since I had planned to make a big configuration and for every part its own class. But that would be over the top and way too much for just a modloader.
So, I'm going to start from @spaar 's approach and try to make everything a bit cleaner.
When I'm done(probably in 2 hours or so, I'm going to eat first since I haven't eaten today(2:30 pm), yet) I'll make a push request for it.
I also offered @spaar a method for work. Everyone could be contributor, but for larger changes(e.g. this one, that should've been a push request) you have to make a push request and 2/3 (currently) of the contributors have to agree that the change is useful. It might take a bit longer, but it's definitely a first step to real team work^^


Right bow it's good, but if the string gets properly written as per it's name then it won't be. I just used that one as it says what I wanted it to say.


The question is still relevant. It seems to me that in the process of wrapping, getSupportedCipherSuites and getDefaultCipherSuites return the lists in different orders.


Space correction.....light le ;)


That's clever. Will do. I didn't realize that the "A" is actually the authority I need.


@gubatron Gracias a ti también! :)


@ww3456 `skipTests=true` is correct. It's actually for integration tests, not the unit tests. For running them do: `mvn clean verify -DskipTests=false`. It should probably be renamed to `skipIntegrationTests`.


@tvsonar Test file names should end with `Test`


a bit cryptic, but {_M, _S, _A, _P} is {:method, :scheme, :authority, :path}.


Hi, @glennsarti. I think you need to explicitly _exclude_ the `.ps1` files from the Unix packages. (I'm not certain about this, but I see the `.bat` files excluded there.


rest of it looks good.


Will remove that real quick.


It could also be written `set(props.items()).issubset(set(message.items())`, not sure it's more readable.


@glennsarti Does this mean that you can reinstate the licence check from the previous two "Fudged..." commits, or is there something else here that's getting in your way?


не нужно расписывать структуру XML

	private static void saveGroupsToXmlFile(List<GroupData> groups, File file) throws IOException {
		XStream xstream = new XStream();
		xstream.alias("group", GroupData.class);
		String xml = xstream.toXML(groups);
		FileWriter writer = new FileWriter(file);
		writer.write(xml);
		writer.close();
	}


@rodfersou I think this is wrong; you get the real context using ``aq_inner(self.context)``


I think they are better then what we have right now. Personally, I think they fit the gui style. Caches look 1000% better now.


@MagoKimbra Eventually, I think so. But this is kind of an obscure setting, and I'm feeling queasy about adding yet another obscure setting. But then, Tom Sanladerer points it out in a video to which I recently linked, so maybe it's not so obscure. In his case it had to be changed because of a very very slow heating hotend.


Because the API doesn't return the fleet id after a resource update, a second update without a page refresh gave a error.


Looks good to me.

One nit: "horn" could be a trigger word for some people, perhaps leave it out.


@rodfersou I think we can name this one ``tooltip_is_enabled``


But why would you do that?


this is the last thing needing implementation.

When a user asks for a standup report for a given number of days they will have the option of the full report, or asking for "my standup report" or "standup report for <user>". These last two options will require filtering by user and removal of the repeated printing of the same user name in the String() method (since each day is from the same user, no need to print their name for each day).

I'll see if I can finish that off today - otherwise it might be later this week.


Also the convo + standup feature is yet untested. On the list.


@yjun2 remove this test so that the pinching movement is smooth and provides constant visual feedback - just like in the photos app.


"Det er 7 menn som har Væinø som første fornavn". I følge ssb.no. De hadde ikke noen lister som var lette å gjøre regex søk i.


@yjun2 DWMR (done with my review). Press on.


You should add a line break according to the test and `standard`.

Try run `npm test` :)


Yup, because ~root is converted to /root/ in bash.


can you do the `_id` sorting like https://github.com/zoepage/pouchdb-hoodie-sync/commit/f54557a17dd4dbeda686c3d9ea749d95d3357c9a#diff-fefa3db9fdfaff796289f717712b7a58R60 here aswell?


You have not worked with those I have worked with then ;)


Add an issue? :)


Wooah dunno how that happened, thanks :)


@VladUreche I found a new report type in the upload that I have not seen before. I'll add it to our parser and ping you back. Thank you!

```json
{"total":87,"fileReports":[{"filename":"src/miniboxing/plugin/transform/tweake...
```


@nfeske: release notes for multi touch and nova


Surely this could be made into some staticpage helper function.  The code is exactly the same (and confusing) for each of the three cases


Revert to 3482e68b46c136a338a93af0e92385d97a6ecec3 and apply my pull request https://github.com/spaar/besiege-modloader/pull/12 and everything will be really clear and work well.
No need to reinvent the wheel.


Thank you, I will fix that in my next push.


You forgot to bump busybox ... doesn't get rolled out ...


@vpavlin We don't do anything with a stop label.  If you want to execute a stop command you will have to add that patch as well.


Don't think that would work.  EF tracks if it's already initialized the db statically by the (non-generic) type of the DbContext.  Once it's initialized that type, it won't initialize again.  There is no cleanup code to execute that can reset that.


I agree this could be moved to a separate function or helper. But since it would involve dealing with cookies, that further refactoring was left out intentionally.


Shouldn't this be folded into ln 90?


Comment - QWERTY


Great intro to ansible, love it! This bit about idempotency doesn't seem quiiiiiiite right to me -- at least it doesn't fully match my experience. Idempotency in ansible is not automatic, it merely gives you the tools to write your provisioning specifications idempotently (big plus over some other tools, but not what's advertised). I wouldn't describe the tool itself as idempotent, because -- unlike with Puppet, say -- the bulk of the responsibility seems to be with the playbook or role author, rather than the framework. It's very easy to write your tasks in a way that lead to module execution even if the desired state is already achieved. This is especially the case with all the AWS modules. The lack of a "planning" stage, separate from execution, can occasionally also lead to the kinds of "what happens when I run this" nail-biting situations you don't want. (I know there's the `--check` option, but not all modules support it.)

Still, to me, Ansible's mix of procedural execution and declarative style while allowing you to write idempotent roles/tasks make it so flexible and powerful.


move this path to a variable, and add to customModals


I agree with ZiMMy, but I can't revert right now, I'll either do it later today or @L3tum can do it.
Btw, no idea why spaarmann is suggested, but I get the same thing...


Added


un residu?


Why is directionality hardcoded? What if the text is actually Arabic?


j'ai laissé ça sinon il ne prend que si la couleur est définie..
il y a surement un moyen plus propre


I would rather have the exact version, because (one patch over v1) != (v1). => remove --abbrev=0
It would also be good to know if the tree is dirty. => add --dirty

~~~
  git describe --tags --dirty
~~~


Should we have this multitude of if statements.  Can't we loop through the various announcements?


ok, je regarderai ca a tete reposee

2015-05-18 14:52 GMT+02:00 pacomski <notifications@github.com>:

> j'ai laissé ça sinon il ne prend que si la couleur est définie..
> il y a surement un moyen plus propre
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/atelier-cartographique/waend/commit/ff98307ebed330fb0a7bafc35ee5b9ee1bcd3531#commitcomment-11239961>
> .
>

--
Pierre Marchand
+32 484 184 435
http://www.oep-h.com


Nice commit!


Right now we only deal with announcement times for project announcements, so this was not folded into ln 90 on purpose.


A slightly more convenient way to do this is to configure the inventory to use the local Vagrant key. Using your example:

```
[server]
127.0.0.1

[all:vars]
ansible_ssh_port=2222
ansible_ssh_private_key_file=~/.vagrant.d/insecure_private_key
```


That Was one Quick Fix!


So the Indexable and CCGData changes are representative of my current direction (attempt #3 or so...).
I've got to come back around to this Importer Spec, try to generalize it so it works for all of the importers.


This proposed change is not correct.  ZM_VERSION is defined here as a Perl constant (rather than a value retrieved from the dB), defined in Base.pm, which makes the unmodified line correct.


% set str foo<config>baz
foo<config>baz
% set asdf bar
bar
% string map [list "<config>" $asdf] $str
foobarbaz


@raven02  No, it is useless now, I would share it later, and beware, the DX12 mode only works on Windows 10 obviously.


@yjun2  DWMR. Press on.


could possibly leave the `test` section commented out in the sample file, and skip the tests if the `test` key is missing

might also be an idea to use `unittest.skipIf` to mark the tests as skipped as opposed to passing in the output


This is unnecessary


Does not work if the wrap around is between `ESC` and `NUL`. Could be done with `rbuffer_peek()` to check for `NUL`.


Thanks!


[Jive] Test User wrote: 123456789


@yjun2 DWMR. Press on.


@michaeldejong
I have disabled this rule quickly because the log was overloaded with exceptions. Now it seems that no mail is sending at all. Maybe we're currently blacklisted by the `smtp.tudelft.nl` server (or they switched to authorised / secure smtp only?)

```
javax.mail.MessagingException: Could not connect to SMTP host: smtp.tudelft.nl, port: 25
	at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:1961) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:654) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at javax.mail.Service.connect(Service.java:295) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at javax.mail.Service.connect(Service.java:176) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at javax.mail.Service.connect(Service.java:125) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at javax.mail.Transport.send0(Transport.java:253) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at javax.mail.Transport.send(Transport.java:124) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at nl.tudelft.ewi.devhub.server.backend.mail.MailBackendImpl$Mailer.sendMail(MailBackendImpl.java:123) ~[devhub-server.jar:na]
	at nl.tudelft.ewi.devhub.server.backend.mail.MailBackendImpl$Mailer.run(MailBackendImpl.java:85) ~[devhub-server.jar:na]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_40]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_40]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_40]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_40]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
Caused by: java.net.ConnectException: Connection refused
	at java.net.PlainSocketImpl.socketConnect(Native Method) ~[na:1.8.0_40]
	at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345) ~[na:1.8.0_40]
	at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) ~[na:1.8.0_40]
	at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) ~[na:1.8.0_40]
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) ~[na:1.8.0_40]
	at java.net.Socket.connect(Socket.java:589) ~[na:1.8.0_40]
	at java.net.Socket.connect(Socket.java:538) ~[na:1.8.0_40]
	at com.sun.mail.util.SocketFetcher.createSocket(SocketFetcher.java:299) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at com.sun.mail.util.SocketFetcher.getSocket(SocketFetcher.java:234) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:1927) ~[mail-1.5.0-b01.jar:1.5.0-b01]
	... 13 common frames omitted
```


Where would you store this parameter?  I wouldn't distribute a module that required people to know the picky spelling and camel casing this sort of thing requires.  A ridiculous majority of x509 certificates are for server end-points.  tls_ca has a cert_type parameter on pretty much every function.  Since extensions have been broken and an issue opened, I merged changes relevant to making them work so the core folks could work on other things.  I went the replacement route. I have no idea if there are many valid use-cases for zero-extension certificates, but they don't work with any software systems I use regularly.  That being said, I didn't want to introduce interface-breaking modifications to tls.

It wouldn't be difficult to fold a 'cert-type' kwarg into the existing tls module; however, I think parameterizing it on the function signature is just asking for future trouble.


:+1: that will make it much easier on olympia's side


yeah, that was an alternative, but I wanted to make the DigitalOcean and the VM processes exactly the same, where both use the user_accounts.yml playbook


this is test of comment


But you haven't actually imported any functions from it? It seems likely to be a user error


s/atleast/at least/


OK


@tdreyno This new step in aruba might be interesting for you.


There are no cookie involved in this code, what did I miss?


If I read this correctly, it loads only the requested roster.

A class could have one large roster divided into sections. The daily signon ritual workflow could be to start at the class page with roster and new assignments, select a link to the section breakout page with one week of peer activity, then explore other's work before starting on their own.

In a giant world-wide class there could be timezone related rosters, europe, asia, americas, that are then queried for sections based on academic interests, literature, science, business. The two page workflow structured-roster=>selective-activity would support this well and still allow anyone to explore anyone else's neighborhood in an intuitive way.


Things being as they are now, we'll need to ensure that any SQL in the tests provides expected results for BOTH MySQL and PostgreSQL environments. Test developers can either write SQL that is compatible with both platforms or branch on the adapter/driver type as may be necessary for use cases specific to MySQL or PostgreSQL.

While the project realizes some benefit from having tests run by Dewdrop-powered application developers, our continuous integration system should test the parts that interact with the database for all supported database vendors. To that end, and to support application architectures that use more than one database, we may wish to provide some multiple database support native to Dewdrop.

There may be some room for improvement relating to decoupling Dewdrop from its database dependency in some places (e.g., CLI).

It may also be reasonably possible to rely more on already tested libraries for database interactivity, so that we can confidently mock away more of the database interactions while testing Dewdrop proper.


fix bug
undirected graph weight


I would rather have an option, default to on than disable the feature if the dependency is not met. => explicit build requirements.
 - add REQUIRE to the find package
 - do not test DOXYGEN(_DOT)?_FOUND


The proposed change to *ps -o comm="" -p 1* appears to work just fine on Linux and FreeBSD, so let's remove the conditional and just change it for everyone.


it shouldn't be there :(


using the find_path in graph.c


See previous comment


Why the quotes here?


that's a `fix` commit, not a `feat`, as it is correcting the existing implementation, but not adding a new feature


Impressive, yet I would have used a different parameter index for the render patch.


Is that dead code that should be removed?


that's a fix commit, not a feat, as it is correcting the existing implementation, but not adding a new feature


@gabrielgarciagava Tenta executar isso onde vc compilou o openssl pra arm?
Aqui ele fica dizendo que não achou o -lcrypto mas o libcrypto.a tá lá... A compilação foi com sucesso mesmo?

$ make
~/workspace/buildroot/buildroot-2015.02/output/host/usr/bin/arm-linux-gcc -c main.c -I ~/workspace/ECCtests/opensslArm/include -g -static -L~/workspace/ECCtests/opensslArm/include -lcrypto -ldl

~/workspace/buildroot/buildroot-2015.02/output/host/usr/bin/arm-linux-gcc main.o -o main -I ~/workspace/ECCtests/opensslArm/include -L~/workspace/ECCtests/opensslArm/include -lcrypto -ldl -g -static

/home/piovezan/workspace/buildroot/buildroot-2015.02/output/host/usr/lib/gcc/arm-buildroot-linux-uclibcgnueabi/4.9.2/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: cannot find -lcrypto

collect2: error: ld returned 1 exit status

make: *** [all] Error 1


What does this do, as a default? It looks empty.


I just noticed this bug, noticed an update to uBlock, and downloaded it.

Thanks for the fix! :)


Flash messages are missing


:+1: for parameter names


@yjun2 DWMR. Press on.


What do these empty defaults do?


Move common code into private method and access using before_action


Hey, sorry, only just found this. I'm a github noob. I see you've added this anyway, great!


@nfeske my fair share of release notes.


I can't see `node_right` used anywhere?


What do you mean is it isn't added?
what is 'this'

i need the record to populate the report, so i need the context.
or am i not understanding what you mean


fred@fred-Aspire-5750G:~$ opam config env
CAML_LD_LIBRARY_PATH="/home/fred/.opam/system/lib/stublibs:/usr/lib/ocaml/stublibs"; export CAML_LD_LIBRARY_PATH;
PERL5LIB="/home/fred/.opam/system/lib/perl5"; export PERL5LIB;
OCAML_TOPLEVEL_PATH="/home/fred/.opam/system/lib/toplevel"; export OCAML_TOPLEVEL_PATH;
MANPATH="/home/fred/.opam/system/man:"; export MANPATH;
PATH="/home/fred/.opam/system/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games"; export PATH;

fred@fred-Aspire-5750G:~$ opam install ocamlfind base-bytes pcre
[NOTE] Package pcre is already installed (current version is 7.1.3).
[NOTE] Package ocamlfind is already installed (current version is 1.5.5).
[NOTE] Package base-bytes is already installed (current version is legacy).

fred@fred-Aspire-5750G:~$ ocamlfind query bytes
ocamlfind: Package `bytes' not found


Why does the phing script for building a package not run this automatically? (As a dependency)


Yes, I would have to test it out just to be sure but even if it wasn't a no-op, I don't see a reason to flush after the headers on any protocol version


I can't see `right` used either


Interesting that we are hard coding these paths rather than using Make macros.
It looks like this occurs in many places:
```
./zmvideo.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmdc.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./ZoneMinder/lib/ZoneMinder/Memory.pm.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmtrigger.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmcamtool.pl.in:$ENV{PATH}  = '/bin:/usr/bin:/usr/local/bin';
./zmx10.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmfilter.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmaudit.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmpkg.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmcontrol.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmupdate.pl.in:$ENV{PATH}  = '/bin:/usr/bin:/usr/local/bin';
./zmtrack.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
./zmwatch.pl.in:$ENV{PATH}  = '/bin:/usr/bin';
```
Sure we should just change it one place?


which variable ?
'logged_in_as' could be request.user.
is that what you mean?


would be better to say it's a segment of the rings, even better is to rename the class to SunburstRingSegment


as we discussed. better to have more views/ urls. OK got it. will do


This is a use case if all functions from that package are accessed via explicit qualification:

```
#' @importFrom dplyr
function() {
  data %>%
    dplyr::filter(...)
}
```

I think you still need to load the package for this to work (and to satisfy `R CMD check`). An `importFrom(dplyr)` entry in the `NAMESPACE` takes care of this, but there seems to be no way to generate such an entry using roxygen.

I agree that in many cases this indicates a user error, but a harmless one which would be caught by `R CMD check` anyway.


horn removed


@nfeske my fair share of release notes — please ignore the first one.


any other little tips like this? an article or something?


You shouldn't need to escape the "`_`" characters here.


ah, I hadn't appreciated that it was only supposed to be applied to integration tests. However, it appears to be turning off all tests, e.g. a `mvn install` from the command line does not run *any* tests. I need to use the `-DskipTests=false` argument to force the unit tests to run.

Renaming the skipTests property in the pom should fix it - see the "Skipping by Default" section of http://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-test.html


This should be anchored to "`/.*\n^__CUT__/`" or similar, to avoid removing any extra times that the `__CUT__` marker appeared - unlikely as that might be.


use '-----' for what?  instead of line 37?


Definitely not right.  This needs to stay.


Creating a context dictionary


Wouldn't hurt to include `__CUT__` in the body twice to prove it is only removed from the start of the line(s).


Move javascript code into separate file


where might i do that? which is a large identifier?


Prefer `"` for link-attributes.


lol


In that scenario you don't needany import directive - `R CMD check` looks both in the NAMESPACE and for use with `::`


You also need to make sure each variable is in the post. Right now, `request.POST` may raise a `KeyError`


Be consistent with spaces. This should either be `array.length - 1` or `array.length-1`.


Superfluous comment


Beats me, I didn't write it


@VERSION@ comes directly from AC_INIT in configure.ac.
If this isn't getting defined during the build process then we need to figure that part out, rather than hack around it.


The intended behavior is that it should always run unit tests, but only integration tests if explicitly told to. I'll take a closer look soon.


javascript all the things! Or maybe not, :+1:


Blank (yes on line 34)


Superfluous comment, please delete


This lambda/proc is in best case called only once. But during the live time of the backend object the connection can be lost. When this happens `@connection.finished?`returns `false` and the lambda/proc is executed a second time.

At the moment I have no glue how to use another approach. Can you please provide an example what you have in mind?


For this I think I'd rather see an explicit loop.

Something like this:

      foreach my $key ( qw! truncatedbody body !)
      {
            $data->{$key} = Text::Markdown::markdown( $data->{$key} ) if ( $data->{$key} );
      }


Absolutely not.  Removing ZM_VERSION from zm.conf was a design decision.


Try to make your code really simple and straight forward. If it is tough to explain it is usually harder to read. Easy simple code.


OK, fixed )


Why is that arrow offset?
Does it need to be?


As per the inline comments, some comments don't add info, please delete them.


Use URL arguments: Read through the Django tutorial https://docs.djangoproject.com/en/1.8/intro/tutorial03/


I was previously testing my builds on a Windows agent.  But as I now have an Ubuntu agent, I can probably revert those changes


but i use the same return render(request, template_to_use, context)
at the end of the function, so it needs to know which template to use.
not necessarily in this function, but in the others, so i was following a convention of ending each function with the same line.
is it better to just look at each function and determine which way to write it - as a variable or just put it directly as text


invoice_number should be integer or string?


i need to add error checking everywhere. didn't do any of that yet.
or is it better practice to put in the error checking right away as I make that function?

( i wanted to see it work before i got to the more tedious task of error checking)


It's not called `t` anymore \o/
Also, I can't see `right` or `node_right` used here


You are constructing an array with one element: a number (which is the length of the input array) and you compare that array with number 1. If you just wanted to compare length of an array with 1, then do `array.length > 1`.

However, this function doesn't need to work with short arrays, so you don't need to code that condition at all.


Remove this as it's not used?


render(request, "path/to/my/template.html", one=1, two=2) looks a lot
better because all of the information is right there.

On Mon, May 18, 2015 at 9:13 AM, Devora Krasnianski <
notifications@github.com> wrote:

> but i use the same return render(request, template_to_use, context)
> at the end of the function, so it needs to know which template to use.
> not necessarily in this function, but in the others, so i was following a
> convention of ending each function with the same line.
> is it better to just look at each function and determine which way to
> write it - as a variable or just put it directly as text
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DeeKras/LendingCircle/commit/a0fc85baa808e3a3c44ac4dfc5a1708467e7b9aa#commitcomment-11240374>
> .
>


ok will do


You removed the useless parens above, could you remove those too?


No need to create a variable and return it. You can apply the refactoring of removing the variable and return the whole expression instead.


Ah sorry, I see it's a tuple, I take it back ;)


Good catch! Thanks!


Make use of Django form validation for 99% of your error checking.

On Mon, May 18, 2015 at 9:14 AM, Devora Krasnianski <
notifications@github.com> wrote:

> i need to add error checking everywhere. didn't do any of that yet.
> or is it better practice to put in the error checking right away as I make
> that function?
>
> ( i wanted to see it work before i got to the more tedious task of error
> checking)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DeeKras/LendingCircle/commit/a0fc85baa808e3a3c44ac4dfc5a1708467e7b9aa#commitcomment-11240390>
> .
>


@yjun2 This is the most elegant solution any student of mine has produced. Very well done.


Hello @reneeb,

the IsCacheable flag is interesting, but I believe it would only help in rare cases as the template may not contain any dynamic (e. g. ticket based) data.

Regarding the regexes, my numbers were completely without any regexes, neither pre or post. It should not matter if a regex is in pre or post, unless it has to be extremely expensive. The main problem is that Template::Toolkit always has to *parse* and *compile* the template if it is not cacheable, which would be much worse.


@yjun2 DWMR. Well done. :+1: Press on.


Please, bump version! I spend a lot of time to find, where is a problem and why rubocop is not starting.


Is there any reason to drop the documentation?


@lencioni thanks for the fix!
@sds Please, bump version! I spend a lot of time to find, where is a problem and why rubocop is not starting.


> Benchmarks shows 50x speed improvement in FF, and 140x improvement in Safari

Again you're missing context.

> That's the way how you keep it fast, right? :)

No. The way to keep it fast isn't chasing micro-optimizations as they have little effect on real world code and won't get any users of Underscore to switch. Go for the bigger performance wins.


@ZiMMy  I'll do that, however, I plan to change it, There's no reinvent, I just want to work a bit on it.
Are you probably spaarmann? ;) Maybe it's the "owner" of github or something...


populate_values means? Please follow proper naming conventions. Method and variable name should have meaningful name according to uses.


Thanks Adam. I will review over the coming week.


Change this to `gabc/gabc-score-determination-l.c: gabc/gabc-score-determination.l gabc/gabc-score-determination-y.h`

Make doesn't know about the dependency and might try to compile `gabc/gabc-score-determiantion-l.c` before `gabc/gabc-score-determination.y.h` has been created.  I suppose this is not exactly correct, since the .o is what really depends on the .h, but I haven't been able to figure out the correct automake rule to make that work.


Jeg fikk noen lister av SSB for noen år siden, som jeg bruker sammen med noen scrapede "baby navn" lister. 'Væinø' står dog ikke i min liste (og kategoriseres med denne algoritmen feilaktig som kvinne).
Det som ligger i dette repoet er kun løse tråder som jeg hadde planer om å samle til én fil, for enkelhets skyld, og senere bruke til å sammenlikne andre framgangsmåter til dette lille 'problemet'.
.. det er mulig jeg bør ta en ny runde med SSB for å få noen mer fullstendige lister (event finne noen bedre features som kan skille mann/kvinne algoritmisk). Har du noen ideer der? Eller helt andre løsningsforslag?
Navne-data er ikke med i SSBs API, og jeg vil nødig scrape SSB for hvert navn (selv om det selvsagt er en mulighet).


What is `iter.remove`? Does it work? IIRC you had trouble because iterators coming from Scala collections didn't have a working `remove()` method.


Change this to gabc/gabc-score-determination-l.c: gabc/gabc-score-determination.l gabc/gabc-score-determination-y.h

Make doesn't know about the dependency and might try to compile gabc/gabc-score-determiantion-l.c before gabc/gabc-score-determination.y.h has been created. I suppose this is not exactly correct, since the .o is what really depends on the .h, but I haven't been able to figure out the correct automake rule to make that work.


so if not a long 'context' or the template is straight forward, put it in directly into the render.
only use variables if necessary

but in the other case, where each if statement has a different template/ context, then have to create variables?
or is there another way to write the code altogether?


Hi Johannes @xijo,
was the above spec inferred from markdown requirements or own enhancement?


Line 3 and line 7 are duplicates - you return the array in both cases, so you can instead just use one line (`return array`) **after** the condition.


There's something strange going on with character encodings. ping @aapris


1) Change method name to "date_formatter"


Line duplication is here :
https://github.com/Treeofsavior/EnglishTranslation/blob/master/ITEM_en.tsv#L643

thanks ! :smiley:


It gives me an error that there are conflicts within my folder so it's unable to revert the change.. It has to do something with the keySettings class, although I don't know what...


@dereksmart What do you think about nitpicking in merge PRs? Should we fix this to adhere to standards and merge it back to wpcom later?


With hex encoding, put fails:
Amazon.S3.AmazonS3Exception: The Content-MD5 you specified was invalid.


It may be better to specify links in form? `jQuery('form a', field_dialog_{{ id }}).on('click', field_dialog_form_list_link_{{ id }});` because the top filters can not be opened on click


I've changed my mind and decided to restore the `RBUFFER_UNTIL_{FULL,EMPTY}` semantics since the worst that can happen is an infinite loop. This one could result in invalid read/writes.


Use TemplateView
https://docs.djangoproject.com/en/1.8/ref/class-based-views/base/#django.views.generic.base.TemplateView

On Mon, May 18, 2015 at 9:20 AM, Devora Krasnianski <
notifications@github.com> wrote:

> so if not a long 'context' or the template is straight forward, put it in
> directly into the render.
> only use variables if necessary
>
> but in the other case, where each if statement has a different template/
> context, then have to create variables?
> or is there another way to write the code altogether?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DeeKras/LendingCircle/commit/a0fc85baa808e3a3c44ac4dfc5a1708467e7b9aa#commitcomment-11240516>
> .
>


invoice_number field is taken for sequence generation for invoice no. field. We will merge this value with alphabets if needed on view side. but rails side it should be integer so this field is taken as integer


I think you may be right.  I'll work on making sure they're excluded.  Looks easy enough to do.


Just forgot to wrap `"-c"` again


No need to use "if else" condition. Please refactor this.


This is not a proper solution because it creates a dependency on Users Admin and the problem will appear again as soon as that portlet is converted to PortletMVC as well.

@juliocamarero @ealonso The User Groups admin portlet needs to manage the pages associated to a User Group. How can it invoke the Layouts Admin portlet properly?


test for github


That's fine, but I'd rather have the fix done by the original author as to not confuse the blame


You can do `-Dlicensing.skip` to get a build on Windows.

On 18 May 2015 at 14:12, Glenn <notifications@github.com> wrote:

> I was previously testing my builds on a Windows agent. But as I now have
> an Ubuntu agent, I can probably revert those changes
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/glennsarti/neo4j/commit/08af5d24ca90feff6371b4b14103f3ce5f1af14d#commitcomment-11240366>
> .
>


Looks Good


Yes, I think it's trivial.

On 18 May 2015 at 14:24, Glenn <notifications@github.com> wrote:

> I think you may be right. I'll work on making sure they're excluded. Looks
> easy enough to do.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/glennsarti/neo4j/commit/637e2439fdae80e2d0d780697c967eb32928e971#commitcomment-11240584>
> .
>


Move this logic into separate method with proper naming convention.


Ok, I can confirm, but the workaround seems a bit tricky for the final UX... I mean: I cannot find my source code in the resource tree with my original file name (you add a .map before extension)... I'm trying to try to hack the renaming on top of your changes to preserve the source names (mapped). I've also found that the front-end re-loads the sourcemap even if it's inline, I've already fixed that preventing useless requests (I'll push and pr towards your fix-sourcemaps branch...


@AndersLowenborg du behöver inte, längre, hålla till i branchen gh-pages.

Jag har flyttat denna uppdatering till master.


Tried that.  'clean install -Dlicense.skip -Dlicensing.skip -Dskiptests' is what I'm currently using.  But even then it still failed.


hey @kashif , do you mind reverting this and rebasing on master ? We now have tests running in travis-ci


It works properly in that commit, that's for sure. Try deleting folder on your PC completely and cloning it again.


I merged this into the `nfv` branch for the extra debug printouts. The schema mismatch should be resolved by #488. (That depends on a change to the `mysqldump` command line to store the table definitions and that has not quite landed yet.)


I have set up a test repo. [Build 2](https://travis-ci.org/krlmlr/import.roxygen.test/builds/63014773) shows the results of using `::` without importing (note that it's not even required to declare the dependency in `DESCRIPTION`), and [build 3](https://travis-ci.org/krlmlr/import.roxygen.test/builds/63015117) shows the empty `importFrom` (which gives [a `NOTE`](https://travis-ci.org/krlmlr/import.roxygen.test/builds/63015117#L899) with `R CMD check`...).


sure will do


fixes #2


not in this case.. this view is called by CSS and JS registration, and the normal context is not the one we want.


please think, before you submit things like this. it can be quite easily abused. And believe it or not i would permaban any person, that will create weapon with infinite ammo on server.


Muy bien, por el uso de la promesa!!!


Thanks a lot. I will merge this branch as soon as the CI is complete


\o/ !!!!!


OK.

Har du en länk?
Jag har lagt upp länk i Trello för nyanställda...
: )

Den 18 maj 2015 15:28 skrev Marcus Hammarberg <notifications@github.com>:

> @AndersLowenborg <https://github.com/AndersLowenborg> du behöver inte,
> längre, hålla till i branchen gh-pages.
>
> Jag har flyttat denna uppdatering till master.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/aptitud/aptitud.github.io/commit/415501f0eda0a3bec1c4e3d8f2c300d3b84a1c79#commitcomment-11240660>
> .
>


Are you sure? https://github.com/projectatomic/atomic/blob/master/Atomic/atomic.py#L347


use errno.ENOENT instead of magical constant 2


Well it's not used for anything but I just did what the base GUI had. Looks fine in game anyway, lol


Good change


Looks good! :+1:


That would be nice. Are you just thinking of calling ```setsebool disable_networking``` or something like that?


Should put it inline with the middle of the single slot, if you ever get back to that.
Just might look a bit better.


so this way you lose encryption for sure...
need to find a way to use fstab.g2
but thanks for tip...


Looks good!


Label values should be static it will change according to client selection from clients' dropdown. Please add logic here for displaying client's address.


ok


Hi @eregon , There may have been a regression in an MRI test at this commit. I'm not sure if the following is a regression or something that was erroneously passing before. I'm not sure how Queue gets that method. Should I just exclude this test for now?
```
$ jt test thread/test_queue.rb
/Users/brandonfish/Documents/jruby/test/mri/thread/test_queue.rb:262:in `remove_method': method `marshal_dump' not defined in TestQueue::DumpableQueue (NameError)
	from /Users/brandonfish/Documents/jruby/test/mri/thread/test_queue.rb:262:in `block in TestQueue'
	from /Users/brandonfish/Documents/jruby/test/mri/thread/test_queue.rb:262:in `TestQueue'
	from /Users/brandonfish/Documents/jruby/test/mri/thread/test_queue.rb:7:in `<main>'
	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:257:in `block in non_options'
	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:251:in `non_options'
	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:62:in `process_args'
	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:851:in `process_args'
	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:856:in `run'
	from /Users/brandonfish/Documents/jruby/test/mri/lib/test/unit.rb:863:in `run'
	from test/mri/runner.rb:41:in `<main>'
```
Also, shown here:
https://travis-ci.org/jruby/jruby/jobs/62933084


Protection against electionId changing types?


That is a side-benefit. I started with ObjectId?, but can't use a value type as a volatile field. So I went with this and I like it better anyways.


@ibelieve


OK


True


Ok, I'll change it


Ok


Move strftime("%d/%m/%Y") into helper method


I'll try to change the way this is passed


scrat内置了一个fis，不要在当前项目目录下安装fis，也不要在package.json里写fis依赖。fis只是构建工具，并不是项目代码依赖


It was because the "Select music" panel was being hidden when the SoundView was on top since any event produced by an interaction wasn't a descendant of the currentModal, so it got hidden.


Hello all,
to make working with the post filters easier, I implemented a new possibility to ask for generation of html comment hooks for generated TT blocks today (https://github.com/OTRS/otrs/commit/335db1a726a3641d75bce146f5dd8de71a6d5408).

You can add in your module config XML like:
```
    <ConfigItem Name="Frontend::Template::GenerateBlockHooks###100-OTRSBusiness-ContactWithData" Required="1" Valid="1">
        <Description Translatable="1">Generate HTML comment hooks for the specified blocks so that filters can use them.</Description>
        <Group>OTRSBusiness</Group>
        <SubGroup>Core</SubGroup>
        <Setting>
            <Hash>
                <Item Key="AgentTicketZoom">
                    <Array>
                        <Item>CustomerTable</Item>
                    </Array>
                </Item>
            </Hash>
        </Setting>
    </ConfigItem>
```

This will cause the block "CustomerTable" in AgentTicketZoom.tt to be wrapped in HTML comments each time it is rendered:
```
<!--HookStartCustomerTable-->
...
<!--HookEndCustomerTable-->
```

With this mechanism every package can request just the block hooks it needs, and they are consistently rendered. No need to add them manually / up-front, no regexes used.

I would be glad to hear your feedback on this.

Regards, mg


The first version of sample output looks far preferable.

It looks like some name mangling will be needed for prefix/start-end as used in XMFA and Stockholm, so that at least we can read/write between these two.

Ideally this means a standardised way to store these in the ``SeqRecord`` such a way that slicing the record does the right thing with the start and end values (and failing that, drops the now invalid entries), and that the long version gets picked up as the default identifier in other settings. I *fear* this is a can of worms - the ``SeqRecord`` attribute ``.id`` is heavily used in the indexing code etc, so turning it into a property function could be slow... see #486 discussion.


OK I've created a new menu for the footer and removed the hard coding. I doubt we would need to edit it much but it does give us some options & flexibility this way


I won't change that AttributeError


Hi,

Does it mean that existing apps which are using this SDK will break sooner or later? I assume it won't break but want to confirm.
If answer to above query is NO and I don't want to add any new feature to my app for a while, then can I keep dependency in my app to this SDK as it is?

Regards,
bharatpallod


When alpha if 0 to 255 it as 45. Multiply alpha could be very legitimate at over 1.0, the problem is we should rename opacity variable


Remove inline javascript. It should be handle within "$(function(){ }" or "$( document ).ready()" from separate javascript file. Please read below links for reference.

http://learn.jquery.com/using-jquery-core/document-ready/
https://api.jquery.com/blur/


@artdude543 Well I have the outer glow there to keep with the original texture (as each icon has a glow.)
I mean If you want to make a change that's fine I honestly am mostly uncomfortable about the ones for the dynamos as using that coil wasn't what I had in mind just couldn't think of what to use.
I can toss a PSD in your direction if you want to edit some stuff and see how it goes


done


Hi


from obi-wan:

"passing" means, that the output from prior steps is used and simple
passed through,
such as a lowercasing step may be passed while the output of a prior
tokenization step
is used.

"ignore" cuts off the path upstream.


Change this permission  if needed


This method intentionally used a hash of the app name to generate a delay instead of a random number.  Previously with multi-app connectivity, when we used a random number as the delay, we frequently ran in to the issue where apps would generate random numbers that conflicted with each other.  This would prevent both apps from registering.  As a stop-gap until multiplexing is introduced, this implementation was used to spread out the registrations across the 10 second window as much as possible.

Also, if you use dispatch_once, if there is a conflict between apps with the random numbers they generate, the problem will persist.

Since this method is only called once during connections and it's sole purpose is to create a delay, I don't really see much purpose in trying to speed it up?


ATTENTION suggest wanted


Change this permission if needed


I've done some looking into the code for the holdingForward. Everything in the code for that is based on constants, with 1 exception, which is getting the document Number from the form. If either the form or the document number are null by the time it gets to either of these methods, there are serious issues with the system not related to these methods, and should have triggered NPEs before this point, so there shouldn't need to be a secondary test on this

On making a helper method: there are 3 lines of code that are duplicated for only 2 methods, and one of them must be done in each of those methods (the return). At what point would it be considered code for code's sake?


We will want to include the updated vendor files here


This is due to the fact that `robotMotorGui` has been superseded by `yarpmotorgui`.


Hi Olivier,

I've just added you as a committer to the project. We have pretty open commit policy right now. We basically add people when we believe they won't break stuff :) .

Feel free to commit into master. Just be sure that the things you commit are polished and the CI build [1] is always green :) .

Regarding Gradle - I personally like it, but not everybody involved into Camel are so enthusiastic about it. Also we will need some plugins which are not available for Gradle yet. So we have stick to the Maven :) .

Great to have you on beard :) .

Cheers!

[1] https://travis-ci.org/camel-labs/camel-labs


lager


wrong file name


Veel lege ruimte he (test)


Tutaj dla pewności powinniśmy sprawdzić czy 100.01 da się zapisać czy nie - zawęża nam to test do dokładnie takich danych jakie chcemy czyli (0, 100>


Nice!


ok


Please use PeriodicTriggerMixin


correcting file name


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.149](http://teamcity.monogame.net/viewLog.html?buildId=7460&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This is strange it is working here:
```
$ ocamlfind query bytes
/home/smimram/.opam/4.02.1/lib/bytes
```
What is the output of the following on your machine?
```
$ which ocamlfind
/home/smimram/.opam/4.02.1/bin/ocamlfind
```


Which one would be the best option on your opinion?


Welcome Olivier.


Even kijken of ik comment kan geven in je code(lijkt me wel handig)


see my comment above. `defaultValue` never needed if a getter is exposed


For now, the best solution would be to have a link to the LAYOUTS_ADMIN portlet. Once the layouts Admin is extracted, we would use the PortletProvider to obtain a url to a portlet that can "EDIT" "LAYOUTS".


caramel


This is the first update of Readme file.


Mythbusters gibt's schon: https://github.com/Kleingeldprinz/sb_tvdb_scene_exceptions/blob/gh-pages/exceptions.txt#L174


Multiplying alpha by some arbitrary number to increase it doesn't feel right to me. I'll be ready to accept this behaviour if you can point me to any other packages/libs allowing it?  It seems more logical to have two methods:

`set_opacity( opacity ) // opacity 0...1`
`multiply_alpha( opacity) // opacity 0...1`


Ten test nie jest poprawny. Jeżeli model się nie zapisał poprawnie to nie będzie się dało go usunąć - test przejdzie ale nie sprawdzi tego co chcemy. Poprawny test powinien wyglądać o tak:
```ruby
test "it should be possible to remove a product" do
  @product.save
  assert_difference("Product.count", -1) do
    @product.delete
  end
end
```


Getter are implicitly a direct access.
`std::vector::at` and not `std::vector::atOrDie`.


Thanks I'll take a look - note that this is just a "polished" version of this PR: https://github.com/spring-projects/spring-xd-modules/pull/14


utilizing prompts for raw user input is not necessarily a new idea, however within a programming scheme that relies on a state mechanism to transfer  or switch on processing of data, all within a recurringly repeating timed format from cron, is when this prompt is over a network requiring user validation by keystroke or mouse-click, to fill out a form or perform another otherwise off-system task and confirming programmatically, the user is an essential component of a process where object-data and object methods can be accessed at large, via privilege or priority alongside state machines that can switch or request input designed like a flowchart scheme that can be "compiled" or translated into objects where temporal indicators can indicate execution


Nit: step-naming is different on this one. Bike-shed: Maybe it's just me who think time when I read "first" and "second". This probably follows some pattern, but there's always gAlice and gBob.


I like this step though technically it doesn't do anything.


I don't know anything about Puppet, so I can't make a comparison, but
you're right about idempotency being half-hearted in Ansible. As far
as I can see, it's also a matter of the underlying platform (the way
Unix is organized) forcing a certain way of working, and Ansible
cannot do much better than offer a leaky abstraction. I haven't worked
with AWS modules either; might be that they are worse than the
built-in ones?


Use `collections.Counter`.


Okay, sorry about that. Pierre tells me you fixed it so I'll just check to make sure I didn't make the same mistake elsewhere.


hey dude.. what's happen in the line 19 ? please see #5


what are the difference between people merged and people? What if i want to know the ones after merging? How do i find number of times each person is the committer and the number of times each person is the author?


Whitespace?   sb.append(" purgeable");


(Odd my earlier comment didn't take, retyping:) Why cache `offerSdp` and `answerSdp` when they're available as `gFirstConnection.localDescription` and `gSecondConnection.localDescription`?


This also needs to enumerate self.runner.failures to get the real unittest failures.


Select a reason from the list.


Can we avoid abbreviating the file name, please? The first time I looked at it I thought NI = national insurance :)


I don't understand what it is for here.


Enter a valid UK postcode. If the respondent lives abroad, enter a SW55 9QT


Invoice Add/Edit form - boostrap-datepicker CSS issue.

![selection_033](https://cloud.githubusercontent.com/assets/5477412/7682351/1f0fe43c-fd95-11e4-92fd-6e8be93f524f.png)


Pamiętaj żeby czyścić kod przed wrzucenie go na repozytorium.


merge from origin


Enter a valid UK postcode. If you live abroad enter SW55 9QT


Pull request would be welcome :)


Provide your Acas early conciliation number. Select ‘ I don't have an Acas number’ if you don't have one


You have said that you don’t have an Acas early conciliation number. Select a reason from the list


Where was this defaulted before?


Enter a valid UK postcode. If you live abroad, enter SW55 9QT


LGTM


One test where NI rates are different would be helpful to be sure we're picking up correct rates.


Enter a valid UK postcode. If the claimant lives abroad, enter SW55 9QT


Because while is 0, continue here has the same effect as break, was that the intent?


Enter a valid postcode. If your representative lives abroad, enter SW55 9Q


Great comment, thanks for taking the time Aaron. I didn't realize the purpose for the specific version of the code that was introduced.
I guess I would just ask a few questions in turn,
1. I'm not sure that an md5 hash is going to necessarily spread out the numbers any more than a random number would. It will certainly make sure they are different, but it seems that there would be just as many "nearby" collisions. Do you know for sure that this is not the case?
2. What happens if there is a conflict and the app / apps are prevented from registering. It seems there's no retry strategy in this PR. If there isn't, is the theoretical strategy to just wait another delay and try again?
3. The dispatch_once isn't a problem, the code contained within it should only be called once within the program to seed the `drand48()` call. `drand48()` can then be called multiple times and it will work as expected.
4. You're right, if this is only being called once before a connection, speed isn't a big deal. Code readability would seem to be helped by the alternate implementation though

I'm not married to the alternate implementation here, and it seems you guys have good reason for your current implementation. If you think that's still the way to go, then I can definitely revert the change.


This is my repository for the Code Louisville project


@dgibbs64 will also add some credits at the install process and subpage :)


Written codes are displayed here from some lectures during master studies


Why is this not nested with the `if` as in the others? Couldn't you end up with two `checked="checked"` attributes?


Thanks Julio. I tried but it didn't work. I don't remember the exact error but I think it was related to the fact that LAYOUTS_ADMIN cannot be invoked within the Control Panel since it's not part of it.


@alesdrobysh your code will produce unnecessary wrapping div


Ok, this is basically a refactor. Looks good.


Ubuntu does not have curl installed by default


ok


@Bitti09 waiting your report


Why this? Why not adding a warning?


@holms I started fresh from the upstream veewee template: https://github.com/jedi4ever/veewee/tree/master/templates/Debian-8.0.0

If you like you can either incorporate the above changes or you can use this version and remove adsy.sh (which install packages we need)


This one looks good: https://plugins.jetbrains.com/plugin/7272?pr=idea


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.149](http://teamcity.monogame.net/viewLog.html?buildId=7460&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:20:14


This change cannot be made upstream.  We must include FPHSA from next to the module or it can be broken by projects that provide their own incompatible FPHSA module.  In general upstream modules are not intended to be relocatable without at least a few small edits like this.


@OwnDroid  please can you add me
and should I delete this then github.com/OwnROM-Legacy


oh, that totally could be it. good catch!


If it's in there for a reason, it's fine. Just making sure it wasn't leftover from some dropped feature.

Being new to the here means I help by questioning things that appear to only exist for the sake of tradition. No better time for that than while a major release is being drafted, right?


This could potentially crash on upgrades if the user has modified the config file, causing `$CHUNKSIZE` to be unset.

We need to either:

 - Have an "internal default", i.e. `CHUNKSIZE=${CHUNKSIZE:-64k}`
 - Only pass the `-c` option if `CHUNKSIZE` is set


The hard-coded paths on Windows are somewhat of a hack.  We shouldn't need this on unix systems.  Instead the `PATH_SUFFIXES` option should be given all the `postgresql/${suffix}` values with version number substituted.  That way it will work under any `$prefix/include`.


Use `_lldpctl_alloc_in_atom()` instead of malloc.


Could have used `ClaText::ProcessPlainBB()`


is this really used/needed?


Correction done.


`oui_info_len` needs to be an int.


I just added a pull request here.  I was looking at older version

https://github.com/projectatomic/atomic/pull/56

If this fixes the problem, I will merge it and you can close this pull request.


Can we also change this to `params` while we're at it?


removed by https://github.com/pbenas/tmpcleaner/commit/9215b470ec748b811780560b4868a78b4094b10b


Would like feedback on this.

Is this an acceptable validity check? Is it ever concealable we'll have negative time values?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.150](http://teamcity.monogame.net/viewLog.html?buildId=7464&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


What were you thinking?


Why the name change to SSL? Because it confuses?


No, I was thinking of using a variable similar to `distro_redhat` and just ifdefing the policy. I'm not really sure how this will play out just yet. I'm going to have to investigate. I'll open a ticket and set the target to RHEL_7-Beta to buy myself some time.


Tutaj sprawdzasz czy przekierowało Cie do strony z wszystkimi produktami. Jeżeli chciała byś sprawdzić czy przekierowało Cie do strony produktu (a z komentarza wnioskuje że miałaś z tym problem) to powinnaś sprawdzić
```ruby
assert_redirected_to product_path(assigns(:product))
```
Pamiętaj że w hashu assigns masz wszystkie zmienne które stworzyłaś w kontrolerze (te z @).


"doesn't contain"


ok


@holms And probably change the mirror


Yes, absolutely! :+1:


This solution is longer than mine, but I think it is a better approach. Do you know why is so important to keep the tags as an array? My solution is working nicely also.


1) Yeah .. VM has about 7.6GB available in memory. It's just a debian distro that has the minimum to build the buildroot env.

2) Using rasp2_wpe_defconfig

Btw using it must has to do something with the new wpe version. Because I can build the previous version without any issues. I get the bad alloc even when I just rebuild the wpe package and the weird thing is that the peak memory is only 4GB - so plenty of memory available.


next time split to two commints (refactoring one and LOG_LOCAL5); ok


Again, too big issue. I suppose one of them should be removed, but this is not the moment.


this fixes, #1205


@PonteIneptique the problem is a misunderstanding of the use of "params" here.  This is not for the params from the original url, but for additional parameters to send to the resource. In the normal course of things, the constructor for the snapdrgn retriever is just getting the callback passed and so at this point params is a function, not an object.  Back on line 236 where you instantiate the resource from the configurator, it already has the query params configured for it, and you are just overriding them here then.  The problem was in not clearing out params to be an empty object before calling resource.get() -- you properly set callback to params, but you then have to clear out params so that it's no longer a function and is just an empty object. i.e. see https://github.com/latin-language-toolkit/arethusa/blob/master/app/js/arethusa/treebank_retriever.js#L222
If you change this line then to params = {} you will get the desired behavior, of the resource obeying the doc parameter. But see also note on line 255


To retain line breaks?


`pspec->flags & G_PARAM_WRITABLE` already evaluates to a boolean expression, so no need for the ternary operator. Combining that with the if statement above it all boils down to `writable = pspec->flags & G_PARAM_WRITABLE & (~ G_PARAM_CONSTRUCT_ONLY)`.


Good point !

I was wondering if we need the enclosing Try. It may be a good idea to fail the stream if we do not manage to close the InputStream ?


What is this commit doing?


You can skip these comments.


Why NSLog and not ArtLog?


Why did you remove this? It's much fancier as the code isn't there if the mod isn't loaded! ;_;


we could do optimistic, but then we'd have to expose `@Version Long version;` in the `PushMessageInformation`


组员：
13121220 杜炎 duyanduyan
13121232 戴源丰 shenrenshige
13121255 胡耀夫 huyaofu
组长：
13121265 zhaoyajun Luomohe


Tutaj chodziło o to żeby do flasha wrzucić informację o błędzie (będzie można potem wyświetlić ją na stronie) a w teście sprawdzić czy zadziałało.


Should this not be a comment as opposed to a NSLog?


LOLOLOLOLOL


I think here you need not to use params.doc but instead the key for the document itself.  E.g. see https://github.com/latin-language-toolkit/arethusa/blob/master/app/js/arethusa/treebank_retriever.js#L205 and then you need to have this defined in your configuration file as a parameter on the retriever, e.g. see https://github.com/latin-language-toolkit/arethusa/blob/master/app/static/configs/perseids.json#L7

This defines the key used for the documentstore, (on line 243 here)


Znowu przyczepie się do zostawiania śmieci na repo.


Doc string update for course_key.


wird später ersetzt durch eine Wertebereichprüfung


This is creating issues for package python-django-openstack-auth. Delorean is trying to clone git://.../python-django_openstack_auth, since the project name is django_openstack_auth. If this is a one-off, I think we could just make this package not use the "lib" conf, but specify the repos directly. What do you think?


`scope.is_resource_owner_scope` can only be valid on edit mode.
`unless edit`, can only be valid in non-edit mode.

so no way to have two `checked="checked"` attributes.

having a nested `if scope.is_resource_owner_scope` inside an `if edit` would be redundant, and we would still need the `unless edit` clause.

but please correct me if i'm wrong


@atamborrino good question.
We can first try without the `Try` and add this if needed.


course_key update in doc


Ok, mas ainda não entendi nesse caso se eu mudo o nome do atributo de professor pra nomeProfessor como é que o sistema identifica que esse atributo é da classe ProfessorCurso? Ou não é pra ser? Ou vai ser tratado individualmente depois? E a questão do import?

> Em 18/05/2015, às 09:16, Altieres de Matos <notifications@github.com> escreveu:
>
> Isso mesmo meu caro, acho que podemos remover o "String comentario" e alterar outros itens, como por exemplo ao invés de "professor" usar "nomeProfessor" assim condiz melhor com o atributo.
>
> —
> Reply to this email directly or view it on GitHub.
>


Ternary operator was used previously, so I just kept it for consistency and readability. I like the one-liner, though. Will change it.


Given this `if` / `else` does not do anything, shouldn't you just remove it?


Should we report the resolution here so the user knows how to adjust their timeout value?


To samo co w zadaniu 7


Should we not simply use comments instead of NSLog?


```if ' ' in text:```


bad languahe


what a mad man!!!


ok, I'll fix the spelling


Ok, can you make the change please?


Glad to see taking my comments into account.
Should I post more issues for this code?


.get is missing ;)


Why leave this commented?


NSLog well then?


Looks good!


@Zangetsu38 hhm, okay...so bad
I think,Therefore i've got that error...
http://puu.sh/hRND4/f6ea241e70.png
http://puu.sh/hRNLY/12604191f8.png

Syntax error: identifier "DXGI_COLOR_SPACE_TYPE"


Good catch. It's fixed


It definitely should not be io-thread-num.


No sure this is the best to do here because a vm_id must be present in topologies, shouldn't we display an error instead? (this is part of the JSON validation we want to do for 1.4).


@dscho I have rewritten the commit.
Shall we meet on this Wednesday for making this test work?


I am not sure I follow why we pass a callback to a client library initialiser given it does not need to do any blocking activity at this point.


@d33pcode, we will investigate around it together, so.
Where did you get that code part?


I think if you save it just before we contact the remote server we have no id


Тестовый проект.
Проверка работы с GitHub.


Hi barronh,

Thank you for this awesome tool! I am wondering if there is a setup.py to install the geos2cmaq module? Since when I was trying to use this, my python keeps showing error message of missing module of geos2cmaq.

Thanks!


Why would this assert OK when the key is bad?


The ./configure is correctly executed after doing
export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig

all is good now :)

wich command result:
/home/fred/.opam/system/bin/ocamlfind


In glium I try both and allow failure for nightly: https://github.com/tomaka/glium/blob/master/.travis.yml#L3-L9

This can detect potential breakages.


Fixed in d8ac3670bf6d263844ffaa081965ae22fd2f78a2


:+1: haha


93653272-SizingTable (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Shouldn't it be the other way around? Sorry if there is a thread discussing this, if so please provide the link. Thanks.


Not to SSL, but to TLS. I switched to TLS, because SSL 3.0 is no longer supported. What Hiawatha supports is TLS/1.0, TLS/1.1 and TLS/1.2. So, why use the name of a protocol that is no longer supported? SSL is dead, long live TLS.


Don't you think it's recommendable to wrap the FileInputStream with a BufferedInputStream?


Failure reported by [travis](https://travis-ci.org/casadi/casadi/jobs/63026273) in 3f8798e0f802...79719a68b93c --


you should add more sepolicy :) . from my repo . i define and fix denials


Ten test nie przechodzi (ale sama o tym wiesz). Błąd jest następujący:
@product to zmienna która w setupie nastawiasz na produkt wczytany z fixtury, potem zmieniasz jego wartość w bazie danych ale nie w tej zmiennej. Czyli musisz tą zmienną jeszcze raz wczytać z bazy danych. Jeżeli test będzie wyglądał na przykład tak:
```
test "should update an existing product" do
  patch :update, id: @product.id, product: {title: 'New title', price: 5.45, description: 'This is my description' }
  @product = Product.find(@product.id)
  assert_equal 'New title', @product.title
end
```
to będzie już wszystko ok.


I think we just need to check the two Booleans from the worldprovider, `hasSky` and `isHellWorld`. if both of them are false then generate, no matter the actual dimension id. If you do like using actual dimension id, the ore will never be generated properly in the mineral world.


I am not sure I follow how this is testing the init by publishing a message with status OK?


good catch


It shouldn't be max height. It's 16.


Dlaczego wywaliłaś testy z fiksturami? Trzeba było je zostawić.


You're doing a helluva job Ingo, thank you and looking forward to more of your magic in the future!


Did this change give a big runtime improvement?  I'd imagine it did.  I was trying to think of some way to remove the atomic here, but this looks like the right solution.


Can you please fix this "of of" while you are at it?


Previously, `after_commit`/`after_rollback` was wrapped in a rescue that just logged errors. They don't rescue any more. This method is only called by after_commit, so we need to rescue and log here to retain original behaviour.


Your work is looking good- just a couple of notes here to help you take it further.

- Go through your HTML and check your opening and closing tags and nesting- I noticed a couple of issues, for example your <header> element's closing tag is outside its parent element, where it should be inside.

- You have a couple of closing tags with extra text in them: lines 25 (</div button>) and 67 (</div container>) ... you don't need to mention classes or IDs when closing, and if you're commenting, do so outside of the closing tag.

- You could put the testimonial text into a div and give it margin left/right auto to center it on the page.

Let me know if you have any questions!


also maybe a space after the colon?


This one should be max height but not 16. Actually we need to change it in config... That's way better.


These are some really big changes, please test them. It is very important.


No but, I said what the ..., one can not compiled via Visual Studio 2013 is on Windows 7, you must be running Windows 10 with Visual Studio 2015 must be the forgotten Windows 7, it is completely exceeded.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.150](http://teamcity.monogame.net/viewLog.html?buildId=7464&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:20:04