there are some cases where this could be a problem security wise, yes.

localhost would get filtered, but we can move that into a special case.


Think you can do a poll to check the model building status in the DB,  and exit only if all the models are completed. (i.e iff status == completed/failed).


@illogicalextend `-address` can be specified for most commands. I would recommend checking the output of `vault -help` or `vault <subcommand> -help` for comprehensive documentation. `-address` should show up in the "General Options" section.


Here the whitespace after negation is redundant.


Nose doesn't run tests with exec bit set, unless you specify each test separately. That means you can't just run "nosetests" in the top-level directory to run all tests :/ I don't know any better way to run all tests in one go...


Thank you for spotting. Fixed.


@xana68 je reprend point par point :

>    les hovers sont pas super en gris,

Pas de soucis, si t'as une meilleure idée vas-y

>    les pointier des form ne font plus 100%

Ouais ça aère un peu, ça fait du bien je trouve.
Les pointillés en 100% ça ne donne pas de flexibilité là dessus.

>    le form fixed en bas recouvre en parti le dernier input

C'est une erreur de calcul à fix


Thank you, fixed in cba23ec.


The content scripts don't use jquery...


Will be fixed.


I don't have a problem. I'm just saying it could be confusing for other users to get a message telling them to append "-address" when that could not work for the command they are using.


This actually saved the bug of less than 9000 being sent due to mispadding of the data


Your PR took care of this?


@simov Thanks for letting me know! :)


great ! move on


TeamCity NEventStore :: Raven :: Build [Build 15](http://build.prxm.it:8811/viewLog.html?buildId=2629&buildTypeId=NEventStore_Raven_Build) is now running


assuming the responses always return json?


parts here is a list of

newPacket = payload, station, timestamp, tagblock, origline

so p[4] is origline

I think it would be usefull to replace this tuple with a dictionary. But that means changing more code. I've tried to change as little of your NOAADATA code as possible. Maybe that's not the right way to go thou :)


TeamCity NEventStore :: Raven :: Build [Build 15](http://build.prxm.it:8811/viewLog.html?buildId=2629&buildTypeId=NEventStore_Raven_Build) outcome was **SUCCESS**
Summary: Tests passed: 61 Build time: 00:00:56


@illogicalextend got it. If you've found a specific command that doesn't accept the option and claims to, then please file an issues as that would definitely be a bug.


I completed this through the lunch level. I attempted one feature on dinner which handles an unexpected operator input.


to my knowledge yes


another commit


could you give some hits about message priority usage here.


Looks much cleaner.


This change is conflicting with one we have internally


`rails-assets-jquery`


`signIn` -> `signInModal`


>Single shot

Will be fixed.
>Also this file and the header don't have a copyright notice.

It was like that... I don't know who created it. I can insert the usual copyright with Christophe Dumez name.


зачем импортить сюда, а не подключить в манифесте?


Added postgresql library and set up server and database on localhost
pulled files before editing but ended up having to merge a brand with the origin/master folder


Could you explain why remove rem in favor of px ?


пробелы после запятых


OK, I thin you mean judge message whether is urgent depends on message priority in ReplicatedPG::wait_for_unreadable_object.

But it looks like depending on a config value isn't a good idea. Maybe we explicitly a new field to indicate the message is waiting?


`$auth,notify` -> `$auth, notify`


This is the same Calculator (lunch) file but with the Colorize gem.

I completed this through the lunch level. I attempted one feature on dinner which handles an unexpected operator input.


зачем тебе локальная переменная юзера?


Thanks a lot.

hotmess() is using "*" which will consume the whole generator before calling izip, so it won't work on infinite interables.

I'm really surprised about the decent perfs of the documentation solution, since they are recreating a 3 tuples every time.

For your solution, the lost of speed is not enormous, but yet significant. The deque version is still the fastest one allowing to process infinite streams.

But we are in Python, and speed is not everything. I suggest we make the slow but safe behaviour a default, then allow to opt out of it explicitly, stating the risks in the docstring:

    # current implementation
    def minibelt(it, size=2, cast=tuple):
        it = iter(it)
        w = deque(islice(it, size), size)
        if cast:
            yield cast(w)
            for i in it:
                w.append(i)
                yield cast(w)
        else:
            yield w
            for i in it:
                w.append(i)
                yield w


redis is too simple for this, need something complexer (like a relational db) to simplify some stuff
I also disliked what I did with the webapp (I'll end adding it back in later)


It occurs in my earlier example. Run "vault token-create" without the env variable set and the message above will tell you to either disable tls on the server or  "run the client with -address set to an address" aka "vault <command> -address http://<address>". So when it says <command>, it means "init" and whatever other commands happen to work because "vault token-create -address http://<address>" is not accepted.

This isn't a major thing. The only reason I am looking into this at all is because the current binary release (github branch has fix) tells the user to use "-addr" instead of "-address", which was an invalid command.


What will happen if if one of the messages result in this `null` in case of `multi()`? Will the request be successful? If it is successful, will StatsD server understand it properly such that it ignores this message and processes the rest properly?


лучше показать несколько ошибок, чем одну с большим количеством теста


Apparently it's better than I thought, I'll be adding it to the XML appfilter.


Thank you :-)

I am a front end developer an I think not have the knowledge necessary to implement this functionality :-(


Good. :)


Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 14
VisualStudioVersion = 14.0.22823.1
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FlyingBird_Android", "Platforms/Android/FlyingBird_Android.csproj", "{BA2ED780-DFF5-4BF5-B597-09128E44BED7}"
EndProject
Global
	GlobalSection(SolutionConfigurationPlatforms) = preSolution
		Debug|Any CPU = Debug|Any CPU
		Release|Any CPU = Release|Any CPU
	EndGlobalSection
	GlobalSection(ProjectConfigurationPlatforms) = postSolution
		{BA2ED780-DFF5-4BF5-B597-09128E44BED7}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
		{BA2ED780-DFF5-4BF5-B597-09128E44BED7}.Debug|Any CPU.Build.0 = Debug|Any CPU
		{BA2ED780-DFF5-4BF5-B597-09128E44BED7}.Debug|Any CPU.Deploy.0 = Debug|Any CPU
		{BA2ED780-DFF5-4BF5-B597-09128E44BED7}.Release|Any CPU.ActiveCfg = Release|Any CPU
		{BA2ED780-DFF5-4BF5-B597-09128E44BED7}.Release|Any CPU.Build.0 = Release|Any CPU
		{BA2ED780-DFF5-4BF5-B597-09128E44BED7}.Release|Any CPU.Deploy.0 = Release|Any CPU
	EndGlobalSection
	GlobalSection(SolutionProperties) = preSolution
		HideSolutionNode = FALSE
	EndGlobalSection
EndGlobal


AFAIK this is true.

This is just a c&p of a line further down. It is just now inside the retry loop.


Will be fixed.


You are right. Maybe need save led's status.


fix `joins`


redundant


`PostsCtrl` -> `AppCtrl`


We normally put subroutines BEFORE the main run subroutine


need empty string


test again 20150518


нужно добавлять пустую строку в конец файла


Why the two variables for SLES and SLED? Why not have a single NCC_CODE Variable which we attach to either the SLES or SLED product?


Is there any reason we shouldn't use `javax.faces.bean.ViewScoped`, as supported by DeltaSpike? (Not sure if it was available when you wrote this?)  http://deltaspike.apache.org/documentation/jsf.html#@ViewScoped


I don't see any handling for add-on products here - what if I wanted to test NCC registration with HA or GEO?


These are required by Cortex-A53 as well. So seemed like a better place. Do you think we should move the macros to some other common place?


Why not leave it as a normal parameter? Then we can define `extendedKeyUsage` is `serverAuth` or `clientAuth`, something like this:

```
    - extensions:
        basicConstraints: 'CA:FALSE'
        keyUsage: 'Digital Signature'
        extendedKeyUsage: 'clientAuth'
```


Wow this is nice...


Could this test be changed to work from a TTY console instead of GNOME Terminal? that way we could run it even on MinimalX or Textmode installations


非常感谢🙏


radius was too small all along! if you change to 150000, the new circles are easily visible


Yes, only these 2 are transmitted immediately.
And other changes need to be pushed by configuring the custom TLV per port.
The way this works can be viewed in` src/client/conf-lldp.c`


No. I will create one.

----- Original Message -----

> From: "Sean Flanigan" <notifications@github.com>
> To: "huangp/react-profile" <react-profile@noreply.github.com>
> Cc: "Patrick Huang" <pahuang@redhat.com>
> Sent: Monday, May 18, 2015 4:13:12 PM
> Subject: Re: [react-profile] rhbz1222358 - fix dropdown not working in
> firefox (a007807)

> I meant, is there a bz for this tech-debt work (ie migrating the code into
> zanata's repo)?

> On 18 May 2015 at 14:59, Patrick Huang <notifications@github.com> wrote:

> > Yes. I haven't got the time to migrate it to zanata repo and setup a build
> > process yet.
> >
> > Patrick Huang
> > Senior Software Engineer
> > Engineering - Internationalisation
> > Red Hat
> >
> > ----- Original Message -----
> >
> > > From: "Sean Flanigan" <notifications@github.com>
> > > To: "huangp/react-profile" <react-profile@noreply.github.com>
> > > Cc: "Patrick Huang" <pahuang@redhat.com>
> > > Sent: Monday, May 18, 2015 2:53:37 PM
> > > Subject: Re: [react-profile] rhbz1222358 - fix dropdown not working in
> > > firefox (a007807)
> >
> > > Is this code still living outside Zanata's code base?
> >
> > > —
> > > Reply to this email directly or view it on GitHub .
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/huangp/react-profile/commit/a007807558aa1f4ac1807ee24d56670696ce33c8#commitcomment-11233634>
> > .
> >

> —
> Reply to this email directly or view it on GitHub .


Did I miss it?   Sorry, has been done.


extra space


@nbougalis you're right about hijacking the thread--for synchronous transaction submisstions, this could mean eternal waits. Fix pending.


I presume this works properly on the vote page when user ~~option~~ choice adding is enabled?


- Added more spacing on User Gallery page
- Decreased the offset on user submitted images. Limit was reset to 6 per page
- Added a limit to Start Date and End Date submitted by Admin(Must be YYYY/MM/DD with no added values)


order items by `id`


Will be fixed.


Not me.
But will be fixed.


That is OK now. Thank you !


Here the issue number should be #23


颜色渐变btn ， 可以快速集成


Maybe it is better to use bash shell here (while the script uses pushd which is not found in sh for example)


Simple and efficient ^^


you must be using prebuilt hal then


Thanks for having done that in a dedicated commit


Ths would be better to change
- foam_controlwrapper --  wrapper class and tests for OpenFOAM using IO wrapping


Will be fixed. And other similar too.


- Removed unnecessary PHP file from 'controllers'


Hm, historical reasons :( Fixing.


@smcgregor jQuery is just used to initialize test cases :-)


I think we should define a wanted size here and use same icon size at least for same kind of buttons (gui buttons - rooms/traps/spells/creatures/tile types, ...).
And once it is done, update your how to to make it clear ^^


SF


@smcgregor
```js
var nodes = $('.test-new p').contents().filter(function() { return this.nodeType === 3});
```
the line above would be replace to use TreeWalker or XPath to generate target nodes. I just want to highlight the real problem part (the regexp and the process) so I simplified this process.


@product，單數


`maxWaitTime` is not used. Remnant or should this be used instead of `iSleepTime`?


Makes sense. Audit is pretty well documented.


strong params 不是放這邊


30414/Pop I. Andrei/Hash Tables/Hash Tables - Chaining/hashTable.c

Why not just
`int poz = hashFunction3(element);`


I think it would be good to extend this to check `config.number`: when `'number'`, return `0`, when `'bignumber'` return `new type.BigNumber(0)`, when `'fraction'`, return `new type.Fraction(0)`. Similar to how for example the function `zeros` should adjust the type of zeros it returns based on the config.


Acabo de eliminar estos cambios con:

8ea5ad996996052e78fcad211a2b24404c82ba5b


I think the discussion on dev-ml is enough, I don't personally once again see the need (the comments say something like using curl, but then with curl it's just: curl -H 'Hawkular-Tenant: default' http://.., so just as simple - I really have my doubts on anyone using web browser to do these and each web browser has extensions to assist on these REST-calls). The implementation itself looks fine to me.


Please reject the pr and apply the modification you want. I am not yet at the office.


應該是 `<%= form_for @product do |f| %>` ？


Wel done !


What if input is nil here? Handle the rror?


Seems good.


Is it possible to use internal wrapper here ? If not then this should be removed from the package (and the needed foam files under poiseuille directory).


This is not my code. All the code here is not mine. But I'll fix it.
>The eMule DAT branch should also check if it ends in .dat

In my opinion, we mean that any other files we interpret as eMule format.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/14965/testReport/) for this commit**


缩进好像不太对。


Hm, it's not guaranteed to be the same one. I think you should check if it has changed.


indent comment


Remove these two comment lines (maybe the same on io wrapper side)


Oops, sorry, I didn't notice that you replied. >.<

About the bot, why not? I could try learning how to code one, if I get time. xD

And things on Sora are going well, I guess. It's definitely more active than Ygg was, but Ygg was the most fun league imo. No competition. :3


Put the step after the task.


What is the meaning with this line ?


Why doesn't the #if HAVE_LOCALCHARSET_H check work on freebsd ?


Image capture task specific identifiers.


Comment indent  (same on io side)


Remove these comment lines


This commit has nothing to do with your issue. Please open a new issue and tell me how you usually set quiets on that ircd, thanks :)


Well done @aaronpk ! The magic of open protocols is that it's just a matter of changing the value of a `<link>` element to switch from implementation to another :)


To complete this case description: (1) is all memory available within the VM or are other processes like a desktop environment also require significant amount of memory, i.e. what is the amount of 'free' before you start the build? (2) Which defconfig do you use?


I'm not sure what you're trying to fix with this checkin - the references to .unband are valid?


Tippfehler (applications) ;)


@katesheleh adding :)


There are scripts in lib?


You shouldn't need to be so specific, here… I bet just `.department-logos` is enough!


The base class description is to return anything from run method.
The last time step should be saved to mesh attribute _time.
On IO side the last time step is returned, which should also changed to saving the time to FoamMesh attribute _time. This return value is used also in examples, which should be changed. Could you do these changes as well ?


I believe this is so that the `text_extensions` in the _nanoc.yaml_ file generated by `create-site` is sorted. We could indeed pre-sort this here, I suppose.


I am not sure about that.

On Mon, May 18, 2015 at 5:14 PM, Zoltan Varga <notifications@github.com>
wrote:

> Why doesn't the #if HAVE_LOCALCHARSET_H check work on freebsd ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ajensenwaud/mono/commit/af2390c0cbb7c940112287386f57dc59d14ddfa8#commitcomment-11234698>
> .
>


云胡不喜


Remove commented code lines


If you're filtering on every GetEnumertor() call, wouldn't it be more efficient to simply filter out invalid points on Add()?


Unless there is a good reason to move to an explicit member variable, I prefer to stick with standard C# Property constructs.


Remove commented lines


yeah, agree, should we hardcode for now, or will you want this to be configurable?


Thank you! Special thanks to @kevva for reviews and @julien-f for stream mode :heart:


It's small enough a matter in return for making it function properly. Doubt anyone will care, I did ask around when I was making this. Far more concerned about taking the logic out of unit.lua for performance reasons.


Remove these commented lines (maybe the same on IO side)


indent


True...


This is wrong !
for add space i think you must add a padding-left for fa-map-marker


hello


Nice construct - can we split the class out into its own file?


You could also do

```ruby
alias_method :after_update_path_for, :user_path
```


Got this error:

	[ 89%] Building CXX object test/CMakeFiles/testeth.dir/libethereum/genesis.cpp.o
	[ 89%] Building CXX object test/CMakeFiles/testeth.dir/libethereum/state.cpp.o
	[ 90%] Building CXX object test/CMakeFiles/testeth.dir/libethereum/transaction.cpp.o
	[ 90%] Building CXX object test/CMakeFiles/testeth.dir/libethereum/stateOriginal.cpp.o
	/root/cpp-ethereum/test/libethereum/stateOriginal.cpp:28:30: fatal error: libethereum/Farm.h: No such file or directory
	#include <libethereum/Farm.h>


Not a fan of commented out code - I'd prefer to remove it from the build if they no longer apply, or delete them outright (they can always be brought back).


This looks like a mess because of the generated code by NetBeans... :p


This is probably the best commit on github.


This example of struct, which contain data and pointer to previous same struct.


Nice change


Fixed!


Hi Grigory,

We can also do
ACTION_SHORTCUT.equals(intent.getAction()) without a need for an explicit null check


I think this is fixed too!


ben ringan mas . . aku aboten nek mbukak libreoffice


Hey looks good to me and very lisible. Just one thing I can't understand. You call run_app with 2 parameters, line 46(self and check_persist_is_created) but it is prototyped to have 3 parameters, line 12. Is that a mechanism I don't know?


I read "you can no longer have roles" and was like… ಠ_ಠ


Consider the `%w` array literal

```ruby
%w(telephone street_address mailing_address landlord other_people other_problems
   asked_for_repairs repairs_made further_information offered_rent_before_deadline
   offered_rent_date offered_rent_amount offered_rent_method)
```


Screenshots of examples are added. Naming is following the already existing pattern (for Gallery of Examples).


Yes, you're right, thank you.
But it always look very strange to me, to compare constant first )


Is this needed at all in internal wrapper ?


还是报错：
$ scrat server start
npm WARN prefer global fis@1.9.11 should be installed with -g
 ➜ server is running
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: spawn c:\Users\Administrator\AppData\Roaming\npm\node_modules\scrat\node_
modules\scrat-command-server\node_modules\.bin\node-dev ENOENT
    at exports._errnoException (util.js:746:11)
    at Process.ChildProcess._handle.onexit (child_process.js:1053:32)
    at child_process.js:1144:20
    at process._tickCallback (node.js:355:11)

求解？


Actually this doesn't work as is, because `terms.category` is the `slug`, not the `_id`. So we need to add `var categoryId = Categories.findOne({slug: terms.category})._id;` in here.


Great, then let's shut this PR down. How to?


really neat - i like it!

One minor detail i stumbled upon is the reversed scroll wheel direction between 3D plater and 3D preview vs. 2D preview - maybe these should be aligned?


I think that thous should not be needed.


group ID eu.comsode.plugins


PR #1954 submitted


ditto


uv-t-t-skWhoisToCsv -> uv-t-skWhoisToCsv


eu.comsode.unifiedviews.plugins.transformer.skwhoistocsv;


Yes I forgot it and added it in the next commit


Fixed!


I think there could be a better name for `@connection_factory`. Maybe just leave it `@connection_or_proc`?


s/discretionarily/arbitrarily/


Haven't jumped forward to later commits yet, but if this hasn't been removed then it should be ;-)


Are these source files found from the OF ? IF so then we should get those directly from the package.


asdfasdf


:+1: I'll note to revert it once we branch 5.2.


oh, yes


@chrisprice - do you think *all* properties should be functors? I'm not so sure it makes sense in this case.


In scenario you described in https://github.com/krists/refile-postgres/issues/2 this would silently discard closed connection but I don't this that is the best behaviour.
Delayed connection evaluation is good but it still should happen only once.


Hm. Wonder if NaN would be better?


Here should be added standard information comments on derived work of OF package


You don't need to copy the parent constructor. `$name` is an optional parameter and as @aschempp said, it's `@api` :) I'm in favor of constructor injection as well.


Loads all children files*


Great work indeed!


:+1: Thanks @senorcarbone


커밋 메세지가 잘못 올라 갔음
- Fragment 예제 NullPointerException 수정


test


If you get error,
/bin/sh: 1: lz4c: not found

use : sudo apt-get install liblz4-tool


It's weird that you pass an UI icon in a control action, can these be set by the widget directly?


Seems good. Note for later, it could be interesting to have some base class "CeguiSubscriber" that would handle this...


This actually undoes a "bug fix" I committed previously: be0feadafe37375fc9c06b63f0c58098b2937623

I guess it comes down to the desired behaviour when using `:force`:
- Option A: when force is on, then commit whatever is dirty in the repo and set the appropriate version bump commit message
- Option B: when force is on, then commit the files which are associated with a version increment and set the appropriate version bump commit message

I was going for A, but come to think about it, option B is probably better according to "the principle of least surprise" seeing as the name of the action is `commit_version_bump`.

So I'd leave it as you changed it.


I think this is outdated.


If you get error:
/bin/sh: 1: lz4c: not found

Use:
sudo apt-get install liblz4-tool


I agree and return to nextTick.


oops, it should be used instead of the entire std::max expression below.
I will pr a fix


We should remove these lines of code while not implemented yet.


Probably better to use controller.getAplicationAssets() here instead of Gdx.files.


@chrisvxd @k0nG talked about this with @nwhite89. It's a pain to strip the namespace from the class with the generator. At some point might just start namespacing CSS component classes so they match the Angular namespacing, but would still need to tweak the generator to match SUIT naming conventions: https://github.com/suitcss/suit/blob/master/doc/naming-conventions.md#namespace-optional


Here also add info on derivative work of OF


I understand why you need the drawable here, but wouldn't be better just to pass a null and then make the gallery process that null? This can be useful for other things.


@jimdowling I agree it is my personal preference, it is more convenient for me personally and I feel wide tab size is unnecessary when code is long and we have several indention levels.


Vypadá to dobře.
Jen smaž řádek 33 a  `$code[]` ... `return implode('', $code)` nahraď `$code` ... `return $code`.


Le 18/05/2015 09:03, Michael Burman a écrit :
> I think the discussion on dev-ml is enough, I don't personally once
> again see the need (the comments say something like using curl, but then
> with curl it's just: curl -H 'Hawkular-Tenant: default' http://.., so
> just as simple - I really have my doubts on anyone using web browser to
> do these and each web browser has extensions to assist on these
> REST-calls). The implementation itself looks fine to me.

Well the browser support argument might not be my best one ever ;)

But as you bring the pretty-print question here, I still think that if
you just have curl and no python/ruby, then a query param is useful. It
could be a header param as well.


If this is a problem on how addToModalsContainer works it should be fixed there.


Sorry, it was supposed to be fixed the tab size to 2 as he mentioned. I just realised that I might not have had the same configuration in my intellij in windows and linux. I switched to windows, and probably there I missed the tab size. Will fix it and also add @senorcarbone recommendation


The fact that you duplicated this code tells me that the problem is somewhere else.


Still referenced in the POM, though: https://github.com/ControlSystemStudio/org.csstudio.product/blob/master/repository/pom.xml#L40


https://github.com/ideals/Ideal-CMS/issues/281 - описание задачи


I haven't had time to make the docs better. But in short: yes you make objects.

`var listener = new OSCListener(port);` will create a listener
`listener.startListening(successCb, errorCb);` will start listening
`listener.stopListening(successCb);` stop listening
`listener.close(successCb);` remove listener completely
`listener.on('/message', function(argumentsList){});` will catch messages (in this case `/message`)

`var sender = new OSCSender(host, port);` create a sender
`sender.close(successCb);` removes sender
`sender.send('/message', data, successCb, errCb);` to send. Data can be a single item or an array with items, it will always be passes as a list to a listener


Ještě mě napadlo, místo logování `$url` bude lepší logovat `$link`.
A vlastně bych rád znal i `$baseUrl` (vyskytuje se automaticky v templatě).


It wasn't supported when I wrote it. I also see that they added "test control" to deltaspike, which could potentially replace our cdi-unit plan.


I thought you had implemented this to hide the "Select music" panel that appears for the scene. However, if the panel appears and I press outside the dialog (semitransparent black area), the dialog does not go away.


No problem, if you manually reformat it in this task then we apply the automatic formatting in the master branch in the entire code that everyone will be synced together.. We have another task for it..


Hey, I agree there's no SEO value. However I'd say we still have benefit of not hard-coding the routes in JavaScript and JSP templates, but rather getting them in some dynamic way. This way we get one source of truth when it comes to routing, as opposed to having it all over the place.

If you do decide for not doing it dynamically I would at least urge you to exclude it from the route file. I have my route file localized and I'm localizing every new route that comes in. If this is used only by the controller but not by templates, localizing a route breaks functionality.


Probably not, I think it's from a time when we thought everything should be massively configurable. I can change it?


Ok, thanks for the review - I'll merge this in then!
Yeah, as you noticed, the QApplication parameter in the run_app method is used by the @patch mock decorator - so we don't have to pass that when we call the function.


Created a PR just now: https://github.com/privly/privly-chrome/pull/122


I think this sentence should start with, "The currently released version".
But perhaps, it might be better to state the actual version, i.e. `To address this, starting with NServiceBus.RabbitMQ version 2.1.3, the approach is to set the a "Current Minor" range i.e. ...`
Thoughts?


nice google :D :D :D :+1:


Prior to the fix, the demo never got a chance to check the return value, because DOSBox got stuck waiting for the time to count down. The demo masked IRQ 2 for some reason, so IRQ 8 never got to trigger and the time value used to countdown never changed. Once IRQ 2 & 8 are forcibly unmasked in this fix, the timeout works like it should.


nem is


@joelteon: Next time, please say in the commit message why the commit was reverted.


i like both


No Worries.

When I get the chance, I will make a repo of this on my test environment, add the bot and see what needs to be changed to have it working (may still need a few tweaks). Also you may need to do some pull requests from Zeral's to make sure we have the most up to date data folder files (battle-engine, tools, scripts, etc).

Ygg is the most fun league I ever came across :P Glad things on Sora are going well :)


I'm not sure if that patch is correct. See those threades:
http://forum.freecadweb.org/viewtopic.php?t=10920
http://forum.freecadweb.org/viewtopic.php?f=10&t=5258


Shouldn't getParentCreative take care of this?


Probably you need to use fabs. Please check those 2 threads:
http://forum.freecadweb.org/viewtopic.php?t=10920
http://forum.freecadweb.org/viewtopic.php?t=10920


fffffffffff


Ok, seem I've misread the original code as well. You are converting `'true'` & `'false'` strings to their Boolean values `true` & `false` respectively. Serves me right for scanning over it while tired. :smile:

But I still don't see the need for doing that. Here's a little test script:

```javascript
function reviver(key, value) {
	console.log('--- reviver() ---')
	console.log('key');
	console.dir(key);
	console.log('value');
	console.dir(value);
	if (value === 'true' || value === 'false') return value === 'true';
	return value;
}

function check(desc, input) {
	console.log('=============== check(' + desc + ') ===============')
	console.log('input');
	console.dir(input);

	var json = JSON.stringify(input);
	console.log('json=' + json);

	var outputNative = JSON.parse(json);
	var outputWithReviver = JSON.parse(json, reviver);

	console.log('---')
	console.log('output (native)');
	console.dir(outputNative);
	console.log('output (with reviver)');
	console.dir(outputWithReviver);
}

check('null value', null);
check('true value', true);
check('false value', false);

check('null string', 'null');
check('true string', 'true');
check('false string', 'false');

check('null value in property', {x: null});
check('true value in property', {x: true});
check('false value in property', {x: false});

check('null string in property', {x: 'null'});
check('true string in property', {x: 'true'});
check('false string in property', {x: 'false'});
```

and here's related output when run using node.js:

```
>node aaa.js
=============== check(null value) ===============
input
null
json=null
--- reviver() ---
key
''
value
null
---
output (native)
null
output (with reviver)
null
=============== check(true value) ===============
input
true
json=true
--- reviver() ---
key
''
value
true
---
output (native)
true
output (with reviver)
true
=============== check(false value) ===============
input
false
json=false
--- reviver() ---
key
''
value
false
---
output (native)
false
output (with reviver)
false
=============== check(null string) ===============
input
'null'
json="null"
--- reviver() ---
key
''
value
'null'
---
output (native)
'null'
output (with reviver)
'null'
=============== check(true string) ===============
input
'true'
json="true"
--- reviver() ---
key
''
value
'true'
---
output (native)
'true'
output (with reviver)
true
=============== check(false string) ===============
input
'false'
json="false"
--- reviver() ---
key
''
value
'false'
---
output (native)
'false'
output (with reviver)
false
=============== check(null value in property) ===============
input
{ x: null }
json={"x":null}
--- reviver() ---
key
'x'
value
null
--- reviver() ---
key
''
value
{ x: null }
---
output (native)
{ x: null }
output (with reviver)
{ x: null }
=============== check(true value in property) ===============
input
{ x: true }
json={"x":true}
--- reviver() ---
key
'x'
value
true
--- reviver() ---
key
''
value
{ x: true }
---
output (native)
{ x: true }
output (with reviver)
{ x: true }
=============== check(false value in property) ===============
input
{ x: false }
json={"x":false}
--- reviver() ---
key
'x'
value
false
--- reviver() ---
key
''
value
{ x: false }
---
output (native)
{ x: false }
output (with reviver)
{ x: false }
=============== check(null string in property) ===============
input
{ x: 'null' }
json={"x":"null"}
--- reviver() ---
key
'x'
value
'null'
--- reviver() ---
key
''
value
{ x: 'null' }
---
output (native)
{ x: 'null' }
output (with reviver)
{ x: 'null' }
=============== check(true string in property) ===============
input
{ x: 'true' }
json={"x":"true"}
--- reviver() ---
key
'x'
value
'true'
--- reviver() ---
key
''
value
{ x: true }
---
output (native)
{ x: 'true' }
output (with reviver)
{ x: true }
=============== check(false string in property) ===============
input
{ x: 'false' }
json={"x":"false"}
--- reviver() ---
key
'x'
value
'false'
--- reviver() ---
key
''
value
{ x: false }
---
output (native)
{ x: 'false' }
output (with reviver)
{ x: false }
```

or to summarize:

input JSON          | native (no reviver)  | with reviver
--------------------|----------------------|------------------------
'null'              | null                 | null
'true'              | true                 | true
'false'             | false                | false
'"null"'            | 'null'               | 'null'
'"true"'            | 'true'               | **true** :boom:
'"false"'           | 'false'              | **false** :boom:
'{"x": null}'       | {x: null}            | {x: null}
'{"x": true}'       | {x: true}            | {x: true}
'{"x": false}'      | {x: false}           | {x: false}
'{"x": "null"}'     | {x: 'null'}          | {x: 'null'}
'{"x": "true"}'     | {x: 'true'}          | {x: **true**} :boom:
'{"x": "false"}'    | {x: 'false'}         | {x: **false**} :boom:

As you can see from the script results, the native `JSON.parse()` method converts the given input JSON to its expected object representation without the need for any extra transformation. On the other hand, I've marked in the summary the exact places where the custom `reviver()` function causes the constructed object representation to be incorrect.

I don't even see the need for any special top-level `null` value handling as the native `JSON.parse()` method handles those correctly as well.

Perhaps there's a difference in how those `JSON.parse()` & `JSON.stringify()` functions work in `node.js` & different browsers? Other than that, I don't see any reason why we would want to use anything else except them directly.

Hope this helps.

Best regards,
  Jurko Gospodnetić


`List a gist's comments` or `List gist comments` maybe? (not really important but seems better to me)


But, this commit puts the logic *in*.
See the tip of 3641 for me taking it out again.


I'm not sure this method gets the job done. Am I right in assuming it does not handle text with multiple "formats"? Did you know that text can be bold,underline and italic at the same time?


or maybe nevermind :)


Hi guys.

My `param_fetcher_listener: force` config is breaking after this commit due to expecting an array input and looking for changes in the documentation didn't find any thing until I reach this.

Maybe a change in the documentation for param fetcher is missing, explaining the new structure and how to reproduce the `force` behaviour.

Thanks


trailing whitespace


Trailing whitespace


Either way, I just noticed Test-Control and CDI-Unit are both designed for JUnit, not TestNG...


Does this mean that it relies on a specific panel?


System.out.println("hello world");


Should this module really be dependant of the ting_covers_plus module?


Has to state it's the single player editor. It does not work in the MP editor.


[**@S0lll0s**](https://github.com/S0lll0s) commented on [May 18, 2015, 2:09 AM GMT+2](https://github.com/97-109-107/themer/commit/3f16ec0a4306e10fa6a1c3946a53dd347bc745d9#commitcomment-11232437 "2015-05-18T00:09:55Z - Replied by Github Comment Enhancer"):
> are you sure this works for you? the return seems to be indented to the wrong width.

I tested it again just now, works fine.


Why would the text default to null?


Sorry, I should have fixed it right away. Pushed [bd0237](https://github.com/CiscoCloud/docker-logstash/commit/bd02373920282fd462dd39c0183ae4c75dad98c1)


let's just use MPI_COMM_WORLD


:cool:


done


Yes, an amend + force push will automagically update the pull request!


The large memory allocation introduced by this commit can be fixed if you do `defaultScope = mkScope self` and use this defaultScope in line 50. The reason this happens is probably because this way, `defaultScope` is shared for all invocations of callPackage, while in the way it's currently written, `mkScope self` is reevaluated for each invocation of callPackage.


Ok ... without the include on solaris i don't have compilation issues, and my testes seems to be OK.
So i guess we can comment this line.


@elinortl  please check the html files


Any suggestion for a better name for this?


Waiting for your PR :wink:


I think if you're going as far as making a gem, it makes sense to allow for `.has_no_valid_syntax ` in it's API.


The `getAsdfCreative` pattern should set the field like you did in `getParentCreative`. Also this method looks messed up. getExtra would return null if it is not set. Thus hasExtra is a redundant call. The method should look like this:
```java
List<Mson> ret = this.getExtra();
if (ret == null)
{
    ret = new MassiveList<Mson>();
    this.setExtra(ret);
}
return ret;
```


Let's make a doc comment for `CheckEmptyName`:
> @return hwname, or if it is empty, a translated generic name based on devtype

(Documenting SLE11 is nitpicking, but I checked that it is not documented in master either)


Used to add images to Action Link, can be used with bootstrap glyiphicons. On begin is used to hide a div if a value is provided. (. and # need to be included in string).


-cards.push.send(pushToken, ticker, payload, function(err, shouldDeleteToken) {
+cards.push.send(pushToken, ticker, payload, function (err, shouldDeleteToken) {


LGTM


zZzzzzzzzzzzzzz


Ich bin heute wieder mehrere Stunden mit der Bahn unterwegs und werde dann mal etwas "spielen" und AppProgrammierung lernen.
Hast du dir den "Autopilot" mal auf einem Tablet oder zumindest Win8 anschauen können? Die linke Leiste sieht da echt nicht chic aus.
Eine Datenbankdatei würde ich auch gern einfügen. Dann kann man besser mit GridViews etc. spielen. Aber wo? Ordner "Autopilot.Shared" oder "Autopilot.Windows"?


right, amended the commit ... now it's https://github.com/kares/killbill-platform/commit/438926eb263a4c934977480e9501c2d7967e656b thanks


@adrianq Great news!
It looks like I can't publish those images because I am not the owner of the document (see attached image *).

I thought it was related to premium vs freemium since I realized once the trial was over but it was a coincidence (I also move from my own documents to yours).

I can turn the embeded images into hot links If you give me permissions over the docs or simply give me the links for me to update.

(*) My menus:
![publish_feature](https://cloud.githubusercontent.com/assets/4146319/7676872/ba618be6-fd47-11e4-8e3b-34d616c329c7.png)


And just as the comment above this method does not set the parent. NullPointerException evasion is not the purpose of the getAsdfCreative pattern. Creating a new object just to avoid NPE is too expensive. We should rather check for null elsewhere. No... the purpose of getAsdfCreative is to set the actual field to a default value and then returning it.


> \# true = long, no abbreviation


sort usings


I think we should make things configurable where it makes sense, in this case I don;t think it does. I'll change as part of #364


So this line should not be here. Rather the setting should be done in getExtraCreative.


xxxxxxx


It could throw errors before, this just increases the set of circumstances under which it might happen.


Also what is the point of this method? Couldn't we just use the message as is?


Do you know up to which PDAL version was the "capacity" parameter supported/needed for the pointcloud plugin ?


is now *split*


Hi,

You missed the config setup for froala here. Something like:
```js
orion.config.add('FROALA_ACTIVATION_KEY', 'froala', {secret: false})
orion.config.add('FROALA_EDITOR_HEIGHT', 'froala', {type: Number})
```
Cheers,
J*


Actor `ask` instantly produces a future that can be used to complete response right away, there's no need to nest futures


...and the build fails with "Invalid base target definition file". Reverting this commit allows the build to succeed.


C


testtesttest


*cast was broken* or *casts were broken*


Why is this check event made? What's the purpose?


I know for sure (used) that the patch size set by the filters.chipper is properly recognized/used by pointcloud plugin (results in patches of the size set via filters.chipper).


I dont know what the correct thing is? Is it typewriter font or normal font?


*and might have had an effect on methods of ...*


Cool, ta


Strings are immutable. How about the much cleaner:
```java
String text = this.getText();
text = text.replace(oldChar, newChar);
this.setText(text);
```


Wasting CPU power with this redundant line.


again.


mon premier commit


~~did hang~~ --> *hung*


Forgive my stupidity, but why would we hardcode the Audacity version number (and thereby not mention -alpha) when it is such? In particular, some distros (e.g. Ubuntu 15.04) currently have Audacity 2.0.6 built with wx3 as their packaged version of Audacity.


*hung*


Merge build and install rule with

    build install:
        python setup.py $@

and use `all: install` to setup default goal.


cool


increasing file *size* (?)


Any way we can make these public and integrate images in the rendering?


move to bottom as it mess more important targets


Returning this early? We didn't process the "extra" yet.


ah, nice :)


why did you remove the function?


Need to get rid of the stylish haskell changes! But for an email with only html,text and inline images this generates an email with a multipart/related at the top and skips the mixed. With an attachment it pushes it a level down and has a mixed at the top level. Looks great! :)


why there is * in `tmpcleaner*.tar.gz` when dependency `sources` always creates file `tmpcleaner.tar.gz`?


Hi @ivanarrizabalaga I've made you owner. Can you confirm that you can now publish it?


ヘルパの中で設定する方がコントローラーで入れ忘れるリスクを軽減出来ますね。


@slapperwan I can't find the source of this update GitHub API, maybe you forgot to push to https://github.com/slapperwan/egit-github ?


My好屌


Maybe you can add	Tools::displayAsDeprecated(); in the beginning of the method ? :)


Don't print here StackTrace. Print to the console, that such file is not found. And ask user to create one, with following instructions.


Windas好屌


Should be `"postinstall": "bower install && brunch build --production"`.


Don't use absolute path. It will not work on other machines. Use relative path.


lib" : "1.0.0"


this should be `tmpcleaner.tar.gz` target more than `sources` (with possible alias `sources: tmpcleaner.tar.gz`)


rp


@aelmahmoudy It's here: https://github.com/maniac103/egit-github/commit/746ef8c843e4dfbd8505f72b6a2dbb23559f4ca6 ... It's mentioned in the README that my repo is used for the bindings.


I would prefer `tmpcleaner.tar.gz` as dependency.


@ifoche Thanks! Now  I can publish the images.


:+1:  Looks nice, please also add tests for the Polygon utils.


Google Nexus 4, 5, 6 boot animation.


+See https://atom.io/releases


niet logischer/beter om de methods `getModuleSetting`, `deleteModuleSetting`en `setModuleSetting`als deprecated te markeren?


@Zangetsu38 How do you compiled it? I just can't because d3d12.h not found in directory. Maybe i not correctly understand you?


en al overal in de core te vervangen


I'm a bit curious, is this an unmodified copy of the official 'assimp-3.1.1_no_test_models.zip'?


Oh you are right. I put this aside as I wanted to wait till I have the patterns finished to reflect this here. But I forgot it then. Will do this later.


Does this handle inheritance anymore?


Jup, da was ik nog van plan, ik wou eerst eens feedback op de code en tests :)


Yes, this works!


明毅好帅


done


++    "find-and-replace": "0.165.0",


This is a good change. The commit message should be enhanced, though, because other readers might not be as lucky as I am to know *why* this change was made. A good rule of thumb is to include information into the commit message that is not immediately obvious from the diff, but pretty important to keep in mind nevertheless. In this particular case, I would advise to mention that this is needed for cross compilation.

Also, please keep in mind that we have to ask for a [sign off](https://github.com/git/git/blob/v2.3.5/Documentation/SubmittingPatches#L234-L286) so that we can push changes upstream after vetting them in the Git for Windows project.


行神好棒


I would suggest using `ReflectionUtil.makeAccessible` here instead.


... though I guess that one does not throw exceptions? unsure.


So next if there a good way to deploy this while still including the dependantcys.
Iv tried to deploy using macdeploy tool but i think I need to add the dependanctcys in some where.


Zeker niet nuttig voor nu, maar maybe Symfony\Component\HttpFoundation\ParameterBag implementeren/extenden?


wot, this still going on ???


great work!

:D i still prefer `@branch` which is the same syntax as composer. does that work too? (--> picky person) XD


That's a good tip! Thanks!


zou ik hernoemen naar `getAllSettingsFromDatabase`, of `allFromDatabase`


Goh, ik had da gedacht, maar door de nested structuur van de modulesettings ($settings[$module][$action]) lijkt me dat niet echt van toepassing hier.


zie feedback op Backend/Core/Engine/Model


This is also what I have to make my habit!


raspberian -> raspbian


Since the copy is not an actual copy, but rather some sort of shallow copy you might get issues from this. The extra could be the same object in many different Msons, resulting in unwanted behavior.


好啪


Yep!


why `//` comments instead of `/**/`?


Duh, good catch! Thank you very much.


niet beter om zoals bij symfony met `.` te werken? vb: `fork.settings`?


好说可以这么搞为毛要用reviewboard啊？


, -> new line


Because a parent without a text field throws exceptions when invoking the ChatSerialiazer in minecraft, which can be avoided by setting it to "".


probably better if you make it `"-c=" + "some_bad_filename"`


I think you should rather implement the Cloneable interface and make a proper clone implementation. The clickEvent, hoberEvent and extra are all mutable and must thus be cloned as well.


Zou dit niet de php.ini van uw cli moeten gebruiken? Want in mijn wereld moet die ook correct staan.


Painted a new Wallpaper:
![Background](http://i70.fastpic.ru/big/2015/0518/77/a17f0af8268bd66ebe14e47994ac8077.png)


Ok I will revert this commit and go back to using ones and zeros.


lgtm


You could use [TestInitialize()] and [TestCleanUp()] to use only one class as described in [Anatomy of a Unit Test](https://msdn.microsoft.com/en-us/library/ms182517%28v=vs.100%29.aspx).


```
# Generate username. But only if it is not set and the serializer is not
# called in a patch-context.
```


ok


@tvdstorm any particular reason you got

    (!left.mayHaveKeywordParameters() && !right.mayHaveKeywordParameters())

rather than

    (!left.mayHaveKeywordParameters() || !right.mayHaveKeywordParameters())

I'm getting exceptions ("can not add keyword parameters to a node which already has annotations") when comparing values where one, but not both are annotated constructors, and hence can't have keyword parameters.

Changing *and* to *or* fixes the problem, but I thought I'd ask before committing anything, since I'm not totally familiar with the keyword argument stuff yet.


@chelmuth: please add to staging


The point of this method is, that we can use our old ways to create colored messages, but are able to apply other formating/colors afterwards. Example: An mson gets the text from a msender.describeTo() method, which applies the correct color. Now, we would like to make the whole message bold. This is not possible, since the color overrides the format when it is applied in the text rather in the mson.


@supranove : https://github.com/spMohanty/geotagx-theme/commit/7f3dd29d96b0dba483b62cf70ec0031d6aca2fbe adds and loads the analytics helper script in the geotagx-theme itself. So you can simply use it out of the box if it exists. Just add a check to see if it has indeed loaded properly.


@eccegordo
Shouldn't this be Transform?
btw, Nice PR. The dropdown on the test result page is much nicer now :smile:


I think we should not use the serializer in another place than a view *and* add `view` to the context but not as view class. So when adding something as `view` to the context we can assume that it is a Django REST framework style view class. Maybe add a warning instead of just silently catching the error.


Please visit his codeplex for more details. Its a zip class that can be used in .net 2.0 with no dependent parts.


Agreed this was wrong, but in latest commit `record_iter_next` returns a `struct record *`


Might as well hard code for now since its only the wdtk theme – won't cause a problem for anyone else.


Ich hab das schon als Windows 8 App gesehen. Mir ging es bisher darum eine Arbeitsbasis zu schaffen, deshalb auch die Commits in den master.

Grundsätzlich sollten möglichst viele Codeteile im Shared Projekt landen, weil dort der gemeinsame Code für alle Plattformen liegt. Ich muss mich da aber auch noch tiefer mit befassen. Damit werd ich heute abend anfangen


Our coding style is to use lower-case names, in this case `status`.


dalao，快发布dll吧，我拿你这个代码编译之后使用会报错啊，errolog里面说“保存设置文件时出现异常”o(>_<)o ~~


最大的作用是防止污染repo


Hm. I like using reverse. We can discuss later and changed nothing here for now.


@flippmoke -  can you explain what do you mean by `starting alpha 45` ?  My understanding is `opacity` (alpha) should always be normalised 0...1.0 value.


> > Being super picky but the social icons don't look like they're cropped with equal spacing around the edge. Likely to be annoying in the future.
> Do you mean the way I've situated the logos inside the coloured squares, or where they are in relation the the links?

> If it's the former, that's by design, due to the portrait orientation of the Facebook logo, if it was equally space around the edges the Facebook logo is tiny.

Ah sorry wasn't clear there – I actually mean the transparent edge around the image:

![screen shot 2015-05-18 at 10 01 38](https://cloud.githubusercontent.com/assets/282788/7677579/1d4c20b6-fd45-11e4-96bc-7d5040d1d5a3.png)


:+1:  looks good, I will test it ASAP


`compact` seems to be causing table columns to be omitted when a value is `nil`. For example, in the table below, "Household" does not have a `capacity` but has a `demand` set to 3388.

![screen shot 2015-05-18 at 09 57 55](https://cloud.githubusercontent.com/assets/4383/7677489/669f511c-fd44-11e4-8491-25414bef66a3.png)

Why not reuse [InstalledTechnology::EDITABLES](https://github.com/quintel/etloader/blob/5e659167fae7d2f7e317b8c2f51f7fd9ba1749e9/app/models/installed_technology.rb#L15)?


As before, please enhance the commit message to give enough background to understand the motivation for this change (and why it is needed for mingw/linux, which is still unclear to me).

While at the subject of the commit message: please use "safe" instead of "save" and speeel `swpintf` correctly ;-)

I also wonder if you want to test the return value of `swprintf()`, to make it truly safe...

And... Please sign off of your work.


my你污染repo了


no text needed, but a placeholder is necessary for a left column behaviour, similar to network fronts


#build


Screenshot of the mobile calculator :
![screenshot_2015-05-18-11-47-08](https://cloud.githubusercontent.com/assets/10980285/7677469/e8ca05a4-fd69-11e4-9df1-0e5540ea8032.png)

Screenshot of the calculator on the webpage :
![screenshot 30](https://cloud.githubusercontent.com/assets/10980285/7677481/092d79de-fd6a-11e4-8053-90b61111f923.png)

(I have added proper comments alongside the code for proper understanding)


没事，反正我们不用reviewboard


The `net_resources.h` isn't shipped in `libchromiumcontent`. For using constant `IDR_DIR_HEADER_HTML`, you may do a hack here, define this constant in this file.


Humm to me `key_len == record_size - sizeof(record_size)` is a perfectly valid key_len.
It does just mean that the record is an empty one (which happens when you use `fs_remove()`)


Merge Galya and Marto code


It does. ToPlain appends toPlainSimple on one part and then proceeds by calling toPlain on its extra and so it handles inheritance properly.


不愧是老大


This change undoes a previous change (at least partially). We try to avoid that in the Git for Windows project: why not change it to the correct (safe) one in the first place?

Also, the commit message really needs to be enhanced to quote (with a link) to the MSDN documentation about `_swprintf_c()`. From reading this commit alone, it is really unclear to me whether this function is supported in all the platforms we target, what the ramifications are of using `_swprintf_c()` vs `swprintf()` and why it is safer. A reader not have to guess or to hunt down that information, it is really the duty of the commit message to provide that information to begin with.

And... sign off, please.


Die moet daarin idd ook goed staan, maar het probleem is dat er hardcoded timestamps in de tests zitten. De analytics resultaten worden per dag gegroepeerd met als array_key een timestamp. Om die te kunnen testen moet ik dus zeker weten dat het Europe/Brussels is. Anders krijg ik op Travis UTC timestamps die dus de tests laten falen.


> Why not reuse InstalledTechnology::EDITABLES?

:+1:


k


I still think `_names` helps readability. `AttributesDeclaration.plain` vs `AttributesDeclaration.plain_names` (or `.positional_names`). But it's not a big deal – leave it like this if you prefer it :)


I *guess* that the purpose of this commit is to document how to cross-compile.

A much better place for that is the `README.md` file, in my opinion. The commit message should describe the motivation for the diff to the reader, in plain, clear English ;-)

Oh, and: sign-off, please!


Hi @3y3, is this a try to fix #628? I can work now for a couple of hours on it...


阳老大~


`!= 0 ?`


学爹老大~


the generated `dir_header.html` isnt currently shipped with libchromiumcontent, this PR will fix that https://github.com/atom/libchromiumcontent/pull/119 and as a side effect `net_resources.h` will be available.


If I set the max len in `strnlen()` to be something valid like `record_size - sizeof(record_size)`
Then I cannot detect if the `key_len` was valid or if it is corrupted any longer (see next test).
I've put `record_size` as max len to put a "higher bound" so that `strnlen()` does not go too far away in memory until it reaches some hypothetical \0.
But maybe I can do:
`key_len = strnlen(&is->buffer[is->seek + sizeof(record_size)], record_size - sizeof(record_size)) + 1;`
`if (is->buffer[is->seek + sizeof(record_size) + key_len - 1] != '\0') {`
`    /* error */`
`}`
?


You don't need to store count.


Sorry, this is confusing to me. The (scarce) commit message seems to purport that this change *allows* GDI, yet the diff looks like it *forces* GDI. Please provide a better explanation, in the commit message.

Oh, and sign-off on this commit, please.


Commit messages should be a bit more informative... predicates for "this commit or change"


Unmodified of the full one I think. Ill have to check.

I run it from my own server due to issues I've had in the past with the sourceforge mirror system


This is not a very good example to point people to: the plugin builds on top of JavaScript stuff, which is closed-source and undocumented. The Struts 2 plugin would be a better example,


It might make sense to document precisely where your win32 API headers come from, and which version you use.

In any case, a Pull Request should not introduce anything that it reverts right afterwards.


Whoops, I selected "Commit to Master" rather than "Branch and submit pull request"....was that incorrect?


> I'm not arguing an alternative solution. I'm saying this PR should be rejected because it's a micro-opt with no real gains.
> The benchmarks have served their purpose by showing that there is no real gain here beyond a micro-optimization.

Benchmarks shows 50x speed improvement in FF, and 140x improvement in Safari.

And yes, it's fun to hear such a bullshit from the maintainer of lodash. :)


The TeamCity plugin is not open-source, so it's difficult to refer to it as an example for plugin development.


我可以删评论的哦~


Can you elaborate ?


Why do you use global variables even though you didn't initialise them ?

I prefer 'let' flow.


This link goes to a different plugin, not Background Image.


By setting the default parameter to 0 we thus only evaluate whether ```propertyIdForSale != my_it->first``` in the case that ```propertyIdForSale``` was specified.

In a nutshell, if you don't specify ```propertyIdForSale``` we'll loop through the properties map for every property ID in the metadex map looking for the txid, however if you do specify ```propertyIdForSale``` we'll only check that specific property map.  Allows for a little bit of optimization in an otherwise ugly method!

Hope that makes sense :)


Hi, thank you for the fix.
however i now seem to get a different error.

000002 INVALID INPUT

please assist urgently.


It could be worth trying, then we'll see whether the author thinks it's the right solution for this issue.


Lazyness.


The `${name}` variable in this line refers to "oracle-instantclient-12.1.0.2.0-1" instead of "oracle-instantclient12.1-basic-12.1.0.2.0-1.x86_64.rpm", because the attribute set passed to `requireFile` is not recursive. I guess that's not what you intended?


web.config is require for i18n?


could be:
```php
if ($index && strpos($index, getcwd()) === 0)
```


Maybe you should define a local helper function `requireOracleFile` that takes the name of the file as an argument and constructs the whole stuff with proper message, etc.? This would reduce the amount of redundancy in this file.


I used `:` because of the "famous" `git fetch <remote> <branch>:<branch>` syntax xD but `@` is okay too...


> this is version which works in win32

This makes it sound as if the current source code does not work on Windows. I have the *proof* here that it does, at least on three machines, though.

Therefore, I daresay that this commit message is incorrect. Please fix it.

There is also the issue that it modifies an earlier change of the same Pull Request, i.e. the earlier commit was apparently incorrect. Let's not do that, it makes for a bad story to read (and review!). Let's rewrite the Pull Request instead, so that it introduces support for cross-compiling (for which `mingw/linux` is probably not the best indicator, BTW) as clearly as possible. That will not only make for a nice read, but also for a more pleasant review, even by the author of the patch series himself. ;-)

Oh, and Sign-off on it, please.


Es wird also immer nur der Nutzer geändert, weil ich an verschiedenen Rechnern arbeite?


btw I put my comments here by mistake, see on the contki-os github for more ;)


You have a separate topic for setting up a plugin project. Why are you repeating this here?


Why don't you mention the actual hash `1v90kb5kmiwsljdigsyig2k9rplnysqrm4zxa2wi1wn3ghj1xrgh` here?


sorry my bad, its actually shipped. will fix it.


I would build up the argument list here. Something like:
```
args = ["clone", "--quiet"]
if 'depth' ...
    args.extend(['--depth', self.source['depth'])
args.extend([url ...])
```


... forgot to mention that `phpbrew install next` is still working too.


Hey, out of curiosity... do you have any source on why, for example, `'from' in Array` would be preferred over `Array.from`?


You probably meant `WinGDI`, not `windgi`, right?

It might also make more sense to fix `fast-export.c` instead. It seems to be the only user. We can easily write `ERR` instead of `ERROR` in that file.


I would replace 'deepness' with 'history size'.


#  gulp-next
## 安装
npm install --save-dev gulp-next
## 参数
callback: 接受一个回调函数作为参数
## 例子
`var gulp = require('gulp');`
`var next= require('gulp-next');`

`gulp.task('test', function () {`
  `gulp.src('images/*.png')`
      `.pipe(gulp.dest('path/output/'))`
      `.pipe(next(function(){`
          `console.log('success...');`
      `}));`
`});`


You can remove the documentation for this option. In practice, only the first and third layouts are used.


Wouldn't it be better to use the empty string instead of 'false'?


Travis now runs about twice as fast (from commit to tests complete)


Thanks!


Why don't you use `patchelf --set-rpath` to configure the appropriate library search paths for these programs instead of generating a wrapper script?


Cela m'embête car ça impacte potentiellement tout ce qui existe déjà (souscriptions, abonnements) qui utilisent leur propre table de liens.
Ma philosophie était que le plugin n'amène qu'une table minimale.
Je vais y réfléchir, mais le cas échéant ce ne serait pas dans cette version du plugin, mais seulement sur la nouvelle branche en préparation.


This intro paragraph doesn't make sense in the context of this site.


excess view.


> Seems good. Note for later, it could be interesting to have some base class "CeguiSubscriber" that would handle this...

I must say I really don't know the best way yet. Now the modes are loaded one at a time, we could simply ask CEGUI to clear up its subscribe list when deactivating?


Same story as above. Do not assign count to variable. Use 'change' matcher.


`price + units.map(_.price).sum`


@lucasart
i see you have accidently sumitted the reference point test with tc 15+0.05 instead 10+0.1 like the verif test.


I didn't test it, but it looks OK on a quick inspection. There are a few new .sld files that could use a newline at the end (i.e. the file doesn't have one on the very last line), and the positioning of the || operator isn't consistent in `src/web/wms/src/main/java/org/geoserver/wms/web/data/StylePage.java `, but those are obviously trivial.


Please follow surrounding indentation (use tabs), also delete the console.log.


I'm not sure where this variable is used? Did I miss anything?


The solution does not work .. We have to append to the array field names in the search form..
For example:
```$safeurlparams = array('catid' => 'INT', 'task' => 'CMD', 'type' => 'STRING', 'search' => 'STRING', 'boxchecked' => 'INT', 'lang' => 'CMD', 'Itemid' => 'INT', 'Name_field' => 'STRING', 'Name_firld' => 'INT' etc.);```
How to fix it?


Maybe you can guard that behind more appropriate guards, e.g. something like `#if _WIN32_WINNT >= 0x0600 ... #endif`, judging from http://sourceforge.net/p/mingw-w64/mingw-w64/ci/cf6afc57179a5910621215f8f4037d406892072c/#diff-190 (sorry, this is a *huge* commit, it will take a while to load).


Top-level paths in $out should be restricted to stuff like bin, lib, share, etc. Maybe it's best to put the demo folder in something like `$out/share/${name}/demo` instead?


@tgxworld in response to your proposal about adding another example. Hope this communicates better that `add_references` is the place to look for option documentation. (#20184)


You're right. While @akien-mga used a 64x64 grid for bigger icons (and IMHO he was right doing so), he took the time to place the icon to fit a 60x60 location.
I do think every icons should be centered on 64x64 and the imageset adapted accordingly.
Here I must say I only did some glitch quick-fix. But I'll keep that in mind for later.


This doesn't explain what components are and when they should be used. This information is essential to include here.


@maniac103 thanks


Ah thanks, it's clear now. :)


No no no. Put it in 'let' statements.


I'd keep the description short, i.e.:

    description = "Oracle instant client libraries for connecting to Oracle databases";

For additional detail, there's `meta.longDescription`.


Why was this line replaced?
https://github.com/movabletype/movabletype/commit/6b7a77f
Is _close_sth later, OK?


This sample plugin no longer exists; please remove its mention here or replace it with something that actually exists.


@hwoarangmy After rebasing, I'll add the tentacle erm, I mean the door.


It depends on how your actors produce failure. And how about root exception handler? Isn't it doing the same thing?


I'd just stick to the default behaviour of `__setitem__`. It will always output the result of the function anyway.


Ah bé il me semblait que ça n'impactait rien puisque les autres plugins continuent de fonctionner pareil qu'avant, ça ne leur enlève pas leur table perso et la manière dont ils l'utilisent pour l'instant.

Et si ensuite cette table existe, alors les auteur⋅e⋅s de tel ou tel plugin (souscription ou autre) peuvent décider de se mettre à jour et de déplacer leur liaison ici. Mais s'illes ne le veulent pas illes peuvent continuer comme avant normalement, quelque soit la version.


Ah yes, I see, looks like Sketch doing something weird, I'll fix that


Indeed, an improvement is needed.


Will fix it.


This is not a clear description of when 'interface' versus 'beanClass' is used.


@senny :+1: thank you!!! This makes it a lot clearer


Looks like there are test cases for the other branches, but not for this one. Possibly worth adding.


hello


this is wrong. pls redo


Shouldn't this be optional ? I.e. only for those needing WatchKit support ?


I do not have handy tools to build complex features from code (like the SimpleFeatureBuilder), nor much experience to build complex features by code (other than a memory that's a nightmare to do), that's why I did not cover this branch.
If anyone can build one for this one, it would be appreciated.


If this plugin actually exists somewhere, please link to its code on GitHub. If it doesn't, please remove its mention.


PicoSAT requires MiniSat to be FOUND?


qwerty


This intro paragraph doesn't work in the context of this site.


Please rename atom-shell to electron, since it's the actual name of this runtime, and I'll accept this as a PR. I'm gonna open up a credits section in the readme, and add you into it for sure. ;)


All makes sense. I'll fix the points you mentioned.


So why does this topic sit here in the middle of everything, and not under Getting Started?


@CHERTS should be fixed now in d335209.


`$@` and `"$@"` are not equivalent:
````
awh@terraqueous:~/workspace/weave/test$ cat quoting.sh
#!/bin/bash

print_args() {
	while [ $# -gt 0 ]; do
		echo $1
		shift
	done
}

print_with_quotes() {
	print_args "$@"
}

print_without_quotes() {
	print_args $@
}

print_with_quotes "print with quotes"
print_without_quotes "print without quotes"
awh@terraqueous:~/workspace/weave/test$ /bin/sh quoting.sh
print with quotes
print
without
quotes
````
To preserve the callers intent, we should actually be using `"$@"` everywhere...


I think "possibly not worth adding" then :-)


The link here is broken: you've got a space between ] and (


Sorry for not creating a PR but I just did this quickly to make RSATom/WebChimera.js build. :) Will do.


Btw, a ComplexFeatureBuilder just landed a few days ago, what's still missing is a simple way to build a complex feature type without having to parse one from a XSD


Empty?


Those sample plugins no longer exist at that location. Please remove or replace.


we might want to recommend this in the REAME to avoid confusion: `phpbrew install next as php-7.0.0`


> `// TODO this`

beautiful


ajuste del boton en la altura


@fenix008 I think you need to install the windows SDK toolkit for windows 10 .


This sample plugin no longer exists; please remove or replace.


Yes, after discussion with @kaplun


@Fiona @Frimkron Can you glance over this, please? Thanks!

* Ensure that Texture derived Images aren't added to the Kivy Cache.
* Ensure that no attempt is made to remove Texture derived Images from the Kivy Cache.


I know that quotes are meaningful. Why do you think we need them here?


This link does not work.


This link does not work either.


This fixes #183


Ok :+1:


fixed in 66a7f2b


Yes, but are we sure that this is how we want to implement it?


Those flags are still valid.


fixed in f6cf11c (great idea :+1:)


-.rb


> Where does the name ORACLES come from?

From \me thinking not to long about it. I've already heard from marvin the same, but I didn't receive any suggestion(s) for a better name yet.

> I also think package private is just a typo and it should be private?

Unit testing purposes.

> Is there a reason to use a magic priority?

Yes, I do think using a priority makes sense, because we abort once we have a result (see other comment).


That's what I mean, probably this forced unmasking is done by every BIOS, otherwise the demo couldn't run on real hardware, and there also wouldn't be a reason for the BIOS to return the IRQ mask in ```al```.
My question was more along the lines "why make this an option instead of default behavior with proper return value and all" ;-)


No need to cat Makefile, and you can do this with one line anyway:

    make -C src timedated.h


It should be "Nix expression" and "Nix store".


权限狗//其实我也可以~哼唧


@nikolai-b That's a splendid work. Well done!


testing zap


Catch ActiveRecord::RecordNotFound in global sinatra scope and return 404 with proper message.


Thanks...I opened a new one 5 days ago..
https://github.com/jruby/jruby/issues/2937


Feel free to create a pull request with this addition to the main repo :)


This can be used as sub-task in Rakefile.


You mean I don't need to put the read size in the message since there is already a message len field at buffer_out[4] ?
Then I can just get the length from `_read_header()` (host side).


You could have just bumped the version and sum in my PKGBUILD instead of overwriting it with the current AUR package, that one contains errors, and it's probably not the latest version anyway.

Updated mine to version 1.10 from google fonts.


let!


ниодного слова ссылка нету, зато полно слов урл, урлов, урлам %)


I know why it is bad (static return value), but try to include such info in the commit message, it's not always apparent when going back in history.


Merhaba


That is the intention, because e.g once we have gotten the IPs from a "good" source (e.g. Android API 21 methods to determine the nameservers, or using reflection), there is no need to "waste" further time querying the other oracles for results. At least that's the motivation behind it. Happy to discuss. I've a weak tendency to abort once we got a result. Otherwise we must also filter duplicates, e.g. because some oracles may return the same values (e.g. AndroidUsingExec and AndroidUsingReflection). Note that I did not introduce this behavior, this was also the previously so.


I will improve it


We should also start testing those generators :)


@lacostej yes, it should, the pull request has been submitted a while back: https://github.com/nomad/shenzhen/pull/264

In the mean-time you can use [krausefx-shenzhen](https://rubygems.org/gems/krausefx-shenzhen)


> Is there another implementation / intended implementation?

Yep, the idea is that a `UnitTestDnsClient` also subclasses this, which get's a "DNSWorldState" object at construction time.


That's just \me being lazy. I can sleep with just one Logger used also by subclasses, but have not objections changing that.


A 404 template could be missing.
```php
add_action( 'template_redirect', array( $this, 'wp_404' ) );
// and in the function
        if ( ! is_404() )
            return;
```


@tvsonar MemoryStream implements IDisposable and therefore should be disposed


Well, it's e.g. ForwarderLookup methods. Or DNSServerSearchers or s.th. like that.

I dislike "for unit testing" if it means weakening the API.

Priority is more than ordering. Do you just need an ordering (list with elements) or do you really need a priority where elements get reshuffled based on priority (status quo)?
This specifically means you have to know all priorities to add a custom implementation, which looks wired (I'd rather allow prepending the list).


Yeah, I replaced the paragraph by one stating that two question results can have the same identifier provided they belong to different tasks. :)


For the sake of clarity, please rename method and param name, as it is no longer just the URI scheme, but the _full_ URI. E.g. `openMountWithWebdavUri(String webdavUri)`. I'd still prefer passing URI over String (stricter validation), but thats ok.


@tvsonar useless level of indirection (You aren't gonna need it)


same as above: e.g. `DAV_URI`


Yeah, looks like there is no behavior change, and noone complained so far, you are right.


忘记说了，中文格式的标点符号会被吃掉


This is done.


If I understand your question, you are asking about the behavior of setuptools and pip? This isn't really specific to the pyrpc library.

If I remember correctly, pip install will check if the install location already has the latest or requested version. And python setup install will always reinstall

That is what I remember.


Thank you Nakata-kun!


Actually read the commit next time please.


@tvsonar For consistency with LITS, it is better to use "Actual" here instead of "GeneratedOutput"


Voici ce que cela donne :
![exemple](http://i.imgur.com/KeRR6y5.png)


I'd like to see how that looks.

There are a few alternatives....
Extracting just an interface?
If methods aren't too highly coupled we could use a mocking toolkit that generates a noop version, thus removing the need to split

Given that such a second implementation is not yet available could this be stashed / put into another commit and be reapplied once an unit test is in the making? I think that would simplify the discussion as it's quite hypothetical right now.


Hehe, it's the one I care least. So feel free to keep it ;-)


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/12122/testReport/) for this commit**


Title: withed -> whited


why did you remove that function?


That is a very wrong way to override a method. You do realize that python supports inheritance and overriding, right?


This commit seems to break my code. Stylesheets and javascript files are getting an internal server error at random.


we don't need for it.


Are all these pre-declarations necessary? Why are they necessary?  Testing shows 'export' itself is not required, and the rest need to be predeclared because they're called without parameters later.

A comment to that effect would be useful. But I feel the code would be more sane if the later methods were simply called with parentheses.


frameworks/av/services/audioflinger/AudioResampler.h:55:18: error: 'CONSTEXPR' does not name a type
     static const CONSTEXPR float UNITY_GAIN_FLOAT = 1.0f;
                  ^
frameworks/av/services/audioflinger/AudioResampler.h: In member function 'float android::AudioResampler::clampFloatVol(float)':
frameworks/av/services/audioflinger/AudioResampler.h:153:22: error: 'UNITY_GAIN_FLOAT' was not declared in this scope
         if (volume > UNITY_GAIN_FLOAT) {
                      ^
build/core/binary.mk:872: recipe for target '/home/android/liquid/out/target/product/bacon/obj/SHARED_LIBRARIES/libaudioresampler_intermediates/AudioResamplerCubic.o' failed
make: *** [/home/android/liquid/out/target/product/bacon/obj/SHARED_LIBRARIES/libaudioresampler_intermediates/AudioResamplerCubic.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from frameworks/av/services/audioflinger/AudioResampler.cpp:26:0:
frameworks/av/services/audioflinger/AudioResampler.h:55:18: error: 'CONSTEXPR' does not name a type
     static const CONSTEXPR float UNITY_GAIN_FLOAT = 1.0f;
                  ^
frameworks/av/services/audioflinger/AudioResampler.h: In member function 'float android::AudioResampler::clampFloatVol(float)':
frameworks/av/services/audioflinger/AudioResampler.h:153:22: error: 'UNITY_GAIN_FLOAT' was not declared in this scope
         if (volume > UNITY_GAIN_FLOAT) {

getting this error when using gcc5.1.
Any solutions?
Thanks


This appears to break backward compatibility and doesn't offer any solutions, nor is it obvious that this stops the build from even happening. The `README.md` doesn't mention any "common base directory" or anything at all to set to fix this up. If we're hitting this, how is it meant to get fixed?


You make a good point. I'll change this to an `int`.


Static import


Like I said, IDK what happened because make's being a bitch but whatever


The only question is whether we want to cause the caller to fail immediately instead of letting it iterate over all the pending chunks before finding the exception marker.


rockColumn_json starts out as an empty associative array. That thing isn't getting anything from the prototype chain.

Try `for(var foo in {}) { console.log(foo); }`. Prints out nothing.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7299/testReport/) for this commit**


Pull #267 addresses this without relying on interruption.

There's still the problem that the `JettyIOPool` can deadlock if there are more concurrent requests using non-static `BodyGenerator` than half the number of pool threads.


We don't need the \enum tag if the enum immediately follows the comment. It's only use for "out of scope" doxy-comments (http://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdenum)


Many thanks!


Perhaps not. It just seems a bit odd given it's already been written.


That's great to hear. I wish I could be of more help.

I'm working on some products that makes heavy use of react-dnd, that I will begin porting to 1.0 soon. Will look for ways to contribute in any way I can.


94639630-HVACTemplateScheduleType-4860 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1651 of 1651 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Beautiful!


We're dropping a lot of tests here!


83811490-Fault_DirtyAirFilter (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (1660 of 1660 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This also combines **some** of the ``addGlobalStyles()`` that were unnessesarily separated. I have created issue #46 for implementing this elsewhere through the code.


83811490-Fault_DirtyAirFilter (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1660 of 1660 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


> Ideally the worker should be completely unaware of the load balancing. If the flow controller intercepts all messages of the workers, it can simply estimate the current load for each worker based on the messages it has seen. This can be a simple token algorithm (each worker has 10 "free tokens") or rate based. A simple way to hide the workers but don't break sync messaging is to work with promises.

I think I am starting to understand how you envision the design of a flow-controller. Let me rephrase it to see whether I got it: you propose a transparent flow-controller interposing between two actors. As soon this "dumb relay" notices a certain amount of message per unit-time, it flags an overload condition. Is that correct?

In my approach, the flow-controller is an explicit actor which only gets messages when an overload condition occurs. This is a active approach, where the overloaded nodes initiate the signaling. If I understand it correctly, you favor a passive approach based on monitoring.

I have two of questions:

1. How would you implement this generically without knowing the "number of tokens"?
2. Isn't the message forwarding from the flow-controller expensive because the flow-controller consumes a lot of slots in the scheduler, thereby pessimizing the common case of no overload?

> A global flow controller might end up bottlenecking your system, though. Or did you mean one flow controller for all workers in a group?

I was thinking of a single, global flow-controller. Because it will be only targeted in emergency/overload conditions and quickly tells the responsible sources to throttle their sending rate, I don't think it will become a bottleneck (assuming it can handle oscillations well).

How would you do it decentralized? One flow-controller per link between two actors?


After much fun, I found the difference isn't correct. I think there's a bug in this logic somewhere because the difference is a trailing `/` - must be appearing from somewhere.


Each size between growthThreshold and  MAX_CAPACITY will always call `growAndRehash`. Could you avoid it?


It should be noted: for...in loops are the slowest form of iteration in javascript ((source)[https://jsperf.com/fastest-array-loops-in-javascript/24]). This really does matter when traversing a list of rock columns.


Storing the method elsewhere is a great idea! I will try that out tomorrow.


Hmm.. I didn't realize your other PR addressed this exact issue. I vaguely remembered the discussion about changing the content source API, so I didn't look into it further.

I'll take a look and will probably abandon this one.


This is a masterpiece


That looks cool. So now one can just define a global template helper `first` and `@first` will resolve to that? Or it should define a global template helper `@first`? But how would you be able to access data from `@index` there? So that it would be cheap to compute it?


Looks like a good start sir. I'm struggling with bulldogging myself so the part about playing with your son hit home. I need to find something similar. Looking forward to the completed entry :+1:


Note that Members require "Add folder" permissions to create WebDAV collections.


Does this fix the problem of the UMD being loaded from the shim and initializing twice, (once from the UMD code and again in the shim?)


Thanks for the feedback. I know I heard you talking about playing guitar, hit that up as your respite.

Sent from my T-Mobile 4G LTE Device-------- Original message --------
From: Sean Joyal <notifications@github.com>
Date: 05/18/2015  8:13 PM  (GMT-05:00)
To: "jorgehjr84/jorgehjr84.github.io" <jorgehjr84.github.io@noreply.github.com>
Cc: Jorge Hernandez <jorge_l_hernandez@yahoo.com>
Subject: Re: [jorgehjr84.github.io] Update journal-of-awesomeness-pt2
  (29f4d66)

Looks like a good start sir. I'm struggling with bulldogging myself so the part about playing with your son hit home. I need to find something similar. Looking forward to the completed entry

—
Reply to this email directly or view it on GitHub.


The issue was indeed that I referenced Query inside the annotation.


Well, really have no idea why this is not working. As the script works fine only with GTK 3.14 or a newer version?
![capture du 2015-05-19 02 16 45](https://cloud.githubusercontent.com/assets/7660997/7693136/20a92758-fdcd-11e4-9b37-8f348054db21.png)


ah oops. I'm sorry about that. That was a sloppy / dumb mistake on my part.


Plays for me on stable . strange


The plots can be found in the md file.

On Sun, May 17, 2015 at 11:50 PM, Chung Cher Tee <notifications@github.com>
wrote:

> where are the plots?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gabbyzhou/RepData_PeerAssessment1/commit/827553edef8996732fb9087fa722960a6adf5833#commitcomment-11233348>
> .
>


private set can be removed


Just delete this commented out code


90210372-ChillerElectricEIR-still-delivering-chilled-water-#4453 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1149 of 1149 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.64%25-green.svg)


Hi have a nice day 😊


Try changing 14 to 15 in the second statement and you'll what I'm talking about.


This should not be related. Please open a new issue for this.


It would be great if you could add the translation for "Single" and "Average" table headers. In portuguese, ("Singular" and "Média") Thanks.


If I find the time, I'll check that tomorrow and try to fix it soon if I'm able to reproduce the issue


All right, thank for the fix.


iteration (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2124 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.55%25-yellow.svg)


this one is better


@leahpadgett The problem is on this line - or rather what is missing just before it. We need to call `setMediaItem` to add the image to cell. When that's done the math comes out correctly.

`[layoutCell setMediaItem:mediaItem];`

The exception stack had a keyword that led me to this. `finite` It's saying that some value must be finite - which also means that the value it had to work with was infinite. Infinite values are the result of division by zero. So I searched for constraints that had a division calculation. Found it!


1640-AddHVACPart1-tertiaryLoops (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2127 of 2209 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.29%25-yellow.svg)


This isn't doing anything btw. The second part of the watch/require statement should be a state ID (not an actual file). So it should probably be `- file: /etc/kubernetes/manifests/etcd.yaml`

I'm pretty sure 2015.5+ will warn about this.


@SchizoDuckie  check that Chrome stable version number. If it is on the same system as where that has the canary, odd's are good the stable is cheating and using the canary engine.


basically i hope this is just travis but for some reason serializers don't load in travis.


@leahpadgett DWMR. :+1:


We can't store it by value because it's polymorphic, need to store a pointer to base. Similarly, the copying mechanism also has to be polymorphic, which is where Clone() comes in.  It also removes doubts about ownership (what if the user passes the same pointer to make two different OrValidators? Doesn't matter, gets copied).
I don't think using smart pointers makes the code more complicated... it removes the need to add delete statements elsewhere in the code and communicates more info about the pointer (it's non-copyable so the OrValidator definitely owns it, use Clone() and get a separate instance if you want a copy).


@Zangetsu38 . yep i think unless the texture implemented.


I know you hate GunGame Clear, nice try :P


This looks safe. I sign off


Hey that looks quite familiar :)

We would certainly appreciate a link back to our source of this, thanks! http://developers.pyramidacceptors.com/coding/2014/08/26/RS-232-Diagram.html


The query runs now, although with wrong results. Will fix logic tomorrow, I'm happy for tonight ^_^


If input comes back as nil, then  `if ([_captureSession canAddInput:input]` will return false, and it will fall into the else and handle the error as no permissions (which is the only time i've seen input come back as nil).


Ahh no it's not. This should be ``string[]``.. that makes more sense :P


83811490-Fault_DirtyAirFilter (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (634 of 634 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.29%25-green.svg)


You're the best, thanks.

Sent from my iPhone

> On May 18, 2015, at 8:26 PM, dothework <notifications@github.com> wrote:
>
> @leahpadgett The problem is on this line - or rather what is missing just before it. We need to call setMediaItem to add the image to cell. When that's done the math comes out correctly.
>
> [layoutCell setMediaItem:mediaItem];
>
> The exception stack had a keyword that led me to this. finite It's saying that some value must be finite - which also means that the value it had to work with was infinite. Infinite values are the result of division by zero. So I searched for constraints that had a division calculation. Found it!
>
> —
> Reply to this email directly or view it on GitHub.
>


:shipit:


Yeah, this is my C/C++ background sneaking in.  Trying to break my habit of wanting to explicitly describe both sides of the boolean relationship.


iteration (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


@leahpadgett Here's the solution to the orange comment > https://gist.github.com/dothework/76f702a5ea166e48fdd3


@leahpadgett DWMR. Press on!


Using a `,` in a jQuery selector let's you select both?! :hushed: Learn something new every day. Thanks for your help with getting this merged.


Very cool syntax use!


1640-AddHVACPart1 (kbenne) - i386-Windows-7-VisualStudio-12: OK (2184 of 2209 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.87%25-yellow.svg)


@raven02  they are now.


Done.


Sweet


`List<T>` would be fine here, the reasons are -
  * `List<ConnectorModel>` is not an internal member of other thing, it is the *return value* of this function, so the caller is safe to do whatever modification.
  *  Because of reason 1, `List<T>` provides more operations than `IEnumerable`. :-)


>>> not []
True

So an empty list is basically equivalent to "False" when used in an if statement or boolean comparison?  Looks like the same is true for an empty dict {}, and for None as well, correct?


I really don't know actually. I'll see tomorrow


need even healthier oil


make it so


Nu är ju detta inget viktigt förutom för min ro i själen
_jag_ tycker kommentraren är överflödiga i sådana här tester om de inte tillför något specifikt angående metoden
, att bara ha namnet blir lite för överflödigt tycker jag då man ändå ser vilken Klass som testas samt funktion.
såhär ser det ut i en CI-server om vi använder det senare.
```
he below summarizes the result of the test "Get name" in build 2 of monaden - automatabuild - Default Job. View test case history

Description
    Get name
Test class
    automatabuilder.StateTest
Method
    testGetName

Duration
    < 1 sec
Status
    Successful
```


@Zangetsu38  how's the GCM sample rendering ?


@rodrigoalvesvieira e @KaoozFreitas, por favor, testem esta função porque eu não estou conseguindo compilar o SSInterpreter.hs em minha máquina.


Successfully connected database with android app per the TA's suggestions.
When the app is ran, the first screen we should see is a 1 which is set up to show that the database was successfully connected with the android app. Unfortunately, the login screen is gone because of the way the test is set up to determine connectivity. I will work on getting the database to store the login information from log in page of each user who registers


Ok, fixed.


Yeah, done.


We need to remove the RecordBatch from this method as well. This interface changed a few versions back to avoid exposing too much to query state to functions.


Thanks for pointing this out!


Guesswork ! xD


--watch


Please use `//` to start this comment line.


@willzeng the command line lib I used (shelljs) just hangs with the older coffee.  If you want to keep 1.2.0 I can work around it with a different library.


You can combine the two lines like what you do above.


Please put this at the top of the import list.


Done.


Add changelog to correspond with the release


@kkirsche BTW, you should add your alternate email address to your GitHub profile; see the tooltip on the question mark next to your name at the top of this commit page.


I like it when you move judgement_draw up, but put judgement_win and judgement_lose for rows and cols in 2 loops will make draw results misjudged as win.

Another improvement inspired by you is: instead of using for loop to judge diagonals, we can consider `diagnoal[0] === 3 || diagnal[1] === 3` as a win (same logic for lose), this will improve the code readability of this part.


Right now the client is very directly ported from the Go version. I think when the time is right, we could benefit from stepping back and thinking whether there is a more "Node-like" way of doing things.

Here is an example of what my database code currently looks like (using roachjs and [rowler](https://github.com/justmoon/rowler)):

``` js
yield db.transaction(function *(txn) {
  // get sender and recipient balance in parallel
  let [senderBalance, recipientBalance] = yield [
    db.get(['account', sender, 'balance']),
    db.get(['account', recipient, 'balance'])
  ]

  if (typeof senderBalance === 'undefined') {
    throw new Error('Sender does not exist')
  }

  if (typeof recipientBalance === 'undefined') {
    throw new Error('Recipient does not exist')
  }

  if (senderBalance < amount) {
    throw new Error('Insufficient funds')
  }

  senderBalance -= amount
  recipientBalance += amount

  db.put(['account', sender, 'balance'], senderBalance)
  db.put(['account', recipient, 'balance'], recipientBalance)
})
```

Note that there is no commit/abort. Commit happens when execution reaches the end of the function. Abort happens if any error is thrown. I personally like that a lot, but I'm not sure it fits everybody's use case. It could maybe be augmented by a `txn.abort()` method.

It uses ES6 generators/yield for simpler syntax and implicit error handling. Uses yield[] to execute the first two queries in parallel. Etc.

What I would want to happen in the background is that `db` should be smart enough to submit the two `Get`s together in one batch request, then flush. Then submit the two `Put`s and an `EndTransaction` in a second batch.

The way you'd achieve that behavior I think is to always default to prepare and then schedule an implicit/automatic flush on process.nextTick. I *think* that would be a pretty efficient way of doing it for most cases. For the few remaining cases, you could set a flag `autoflush = false` and flush explicitly when you need to.

What I haven't quite figured out is how to degrade that interface for people not using ES6 yet. You could use functions (as today) or promises.


@mikepetersonccv I'm seeing something odd in the totaling behavior since this change... can you confirm.  If I enter 20 in an account field, the total only shows 2.00 but if I enter 20.00 it correctly shows 20.00.
![5-18-2015 5-52-29 pm](https://cloud.githubusercontent.com/assets/383807/7693486/cb72eb98-fd86-11e4-84e2-0a8e87c74a9c.png)


@spicyj: Can you provide an example input for which you are seeing this error? I tried with

```js
var React = require('React');
var Component = React.createClass({
  render: function() {
    var node = this.refs.something.getDOMNode();
  }
});
```

which works fine.


@mikepetersonccv  PS. Heads up! I just committed a different change to this block so you may want to pull first.


Thanks Dan. Will fix the review comments and push another patch.

On Mon, May 18, 2015, 11:35 PM danh-arm <notifications@github.com> wrote:

> These arrays could be const, which would reduce the size of your .data
> section.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vwadekar/arm-trusted-firmware/commit/3344ee97e416af9b9f777f8ceb51ef9f18497fae#commitcomment-11246415>
> .
>


updated.


All the code in RDMPDU except for PrependHeader wasn't actually used anywhere.


I recently reorganized some of the contents of the project so that we separate libraries from our own CSS, javascript, etc. If these are just files as they were downloaded from the intro.js website, then I would put both the css and javascript (and any other intro.js related files that are just a part of the library) in /libraries/intro/.

Any custom CSS or other code that extends the library or modifies styling should probably be integrated with our existing css/javascript, etc. Let me know if you have any questions or I'm not making any sense :)


Test


I really wish Golang had something like atexit(), so I could register an atexit() function in this package's init() which releases these occupier goroutines.  Then z_last_test.go wouldn't be failing.


Yeah, I guess it is a bit of overkill.  I'll give the std::set a chance and push it here once it's working.


@cvrebert it's there and it actually shows for me as an avatar. No clue why Github isn't respecting that I have a valid image / avatar.

![screen shot 2015-05-18 at 8 58 34 pm](https://cloud.githubusercontent.com/assets/947110/7693529/ac8ad21c-fda0-11e4-805a-1d91ee4990c3.png)


\>but remove butt...

Always remove butts.


doesn't fit in the 120 character limit. Hence, splitted the 2.


Thanks for merging my changes! Please publish this version to NPM!


Yep look upside :)


@KellyD813 nice work. U might want to consider [namespacing this js and encapsulating within an  IIFE](http://addyosmani.com/blog/essential-js-namespacing/).

:+1:


Looks like `migrations_with_octopus` was changed to be a class method. ActiveRecord::Migrator has both a [class method](https://github.com/rails/rails/blob/master/activerecord/lib/active_record/migration.rb#L864) and an [instance method](https://github.com/rails/rails/blob/master/activerecord/lib/active_record/migration.rb#L959) named `migrations`, but the class method takes an argument `paths`.


そう、困ってたのありがとう！


If you refresh / clear cache does it fix it? If not let me know and I'll mess around trying to fix it unless you have some ideas what's happening


Renamed the Title Property of the Document class to Name for increased consistency.


Thanks, I thought I had published it.


Cleaned up.


Refactored


WarSimulator initial commit


This seems to fail for me:

```
var React = require('React');
var NavigatorTransitionerIOS = React.createClass({
  render: function() {
    var node = this.getDOMNode();
  }
});
```

though seemingly also fails if `getDOMNode` is any other identifier? I'm running `jscodeshift -c 1 -d -v 2 -t ~/code/react/npm-react-codemod/build/findDOMNode.js`.


Reduced code duplication by refactoring slightly


Simplified this unnecessarily complicating method by removing artificial asynchrony.