37:1: I201 Missing newline before sections or imports.
145: D102 Missing docstring in public method
154: D400 First line should end with a period (not 'n')
154: D205 1 blank line required between summary line and description (found 0)
243: D102 Missing docstring in public method
283: D400 First line should end with a period (not 'w')
283: D205 1 blank line required between summary line and description (found 0)
296: D400 First line should end with a period (not 'e')
296: D205 1 blank line required between summary line and description (found 0)
311: D400 First line should end with a period (not 'e')
311: D205 1 blank line required between summary line and description (found 0)
319: D400 First line should end with a period (not 'e')
319: D205 1 blank line required between summary line and description (found 0)
330: D400 First line should end with a period (not 'd')
330: D205 1 blank line required between summary line and description (found 0)
352: D102 Missing docstring in public method
356: D102 Missing docstring in public method
368: D400 First line should end with a period (not 'd')
391: D400 First line should end with a period (not 'n')
391: D200 One-line docstring should fit on one line with quotes (found 3)
398: D400 First line should end with a period (not 't')
398: D200 One-line docstring should fit on one line with quotes (found 3)
405: D400 First line should end with a period (not 'e')
405: D200 One-line docstring should fit on one line with quotes (found 3)
412: D102 Missing docstring in public method
434: D102 Missing docstring in public method
442: D102 Missing docstring in public method
446: D210 No whitespaces allowed surrounding docstring text
446: D400 First line should end with a period (not ')')
451: D210 No whitespaces allowed surrounding docstring text
451: D400 First line should end with a period (not 'd')
458: D210 No whitespaces allowed surrounding docstring text
458: D400 First line should end with a period (not 't')
474:17: W503 line break before binary operator
488: D102 Missing docstring in public method
502: D102 Missing docstring in public method
523: D210 No whitespaces allowed surrounding docstring text
523: D400 First line should end with a period (not 's')
529: D102 Missing docstring in public method
536: D210 No whitespaces allowed surrounding docstring text
536: D400 First line should end with a period (not 's')
541: D210 No whitespaces allowed surrounding docstring text
541: D400 First line should end with a period (not 's')
546: D210 No whitespaces allowed surrounding docstring text
546: D400 First line should end with a period (not 's')
551: D210 No whitespaces allowed surrounding docstring text
551: D400 First line should end with a period (not 's')
556: D400 First line should end with a period (not 'r')
556: D205 1 blank line required between summary line and description (found 0)
569: D400 First line should end with a period (not 'e')
614: D102 Missing docstring in public method
619: D102 Missing docstring in public method
630: D102 Missing docstring in public method
637: D102 Missing docstring in public method
643: D102 Missing docstring in public method
649: D102 Missing docstring in public method
654: D102 Missing docstring in public method
661: D210 No whitespaces allowed surrounding docstring text
661: D400 First line should end with a period (not 'e')
665: D210 No whitespaces allowed surrounding docstring text
665: D400 First line should end with a period (not 'e')
669: D210 No whitespaces allowed surrounding docstring text
669: D400 First line should end with a period (not 'e')
673: D210 No whitespaces allowed surrounding docstring text
673: D400 First line should end with a period (not 'e')
678: D203 1 blank line required before class docstring (found 0)
678: D204 1 blank line required after class docstring (found 0)
678: D400 First line should end with a period (not 'r')
678: D205 1 blank line required between summary line and description (found 0)
684: D102 Missing docstring in public method
689: D200 One-line docstring should fit on one line with quotes (found 3)
705: D102 Missing docstring in public method
710: D210 No whitespaces allowed surrounding docstring text
710: D400 First line should end with a period (not 'n')
718: D210 No whitespaces allowed surrounding docstring text
718: D400 First line should end with a period (not 'n')
722: D210 No whitespaces allowed surrounding docstring text
722: D400 First line should end with a period (not 'n')
728: D200 One-line docstring should fit on one line with quotes (found 3)
734: D400 First line should end with a period (not 's')
734: D200 One-line docstring should fit on one line with quotes (found 3)
747: D203 1 blank line required before class docstring (found 0)
747: D204 1 blank line required after class docstring (found 0)
747: D400 First line should end with a period (not 'm')
747: D200 One-line docstring should fit on one line with quotes (found 3)
751: D102 Missing docstring in public method
762: D102 Missing docstring in public method
770: D102 Missing docstring in public method
781: D102 Missing docstring in public method
784: D102 Missing docstring in public method
787: D102 Missing docstring in public method
794: D200 One-line docstring should fit on one line with quotes (found 3)
800: D200 One-line docstring should fit on one line with quotes (found 3)
810: D200 One-line docstring should fit on one line with quotes (found 3)
873:13: W503 line break before binary operator
943: D400 First line should end with a period (not 's')
951:9: E731 do not assign a lambda expression, use a def
966: D203 1 blank line required before class docstring (found 0)
966: D204 1 blank line required after class docstring (found 0)
966: D400 First line should end with a period (not 't')
973: D102 Missing docstring in public method
995: D102 Missing docstring in public method
999: D102 Missing docstring in public method
1003: D102 Missing docstring in public method
1008: D102 Missing docstring in public method
1012: D102 Missing docstring in public method
1016: D102 Missing docstring in public method
1023: D400 First line should end with a period (not 'd')
1043: D400 First line should end with a period (not 't')
1043: D200 One-line docstring should fit on one line with quotes (found 3)
1066: D400 First line should end with a period (not 't')
1066: D200 One-line docstring should fit on one line with quotes (found 3)
1093: D200 One-line docstring should fit on one line with quotes (found 3)
1107: D400 First line should end with a period (not 't')
1107: D200 One-line docstring should fit on one line with quotes (found 3)
1124: D400 First line should end with a period (not 'n')
1124: D200 One-line docstring should fit on one line with quotes (found 3)
1147: D400 First line should end with a period (not 'w')
1175: D400 First line should end with a period (not ')')
1175: D200 One-line docstring should fit on one line with quotes (found 3)
1188: D200 One-line docstring should fit on one line with quotes (found 3)
1201: D400 First line should end with a period (not 'e')
1201: D205 1 blank line required between summary line and description (found 0)
1208: D400 First line should end with a period (not 'p')
1208: D200 One-line docstring should fit on one line with quotes (found 3)
1215: D400 First line should end with a period (not 'r')
1215: D200 One-line docstring should fit on one line with quotes (found 3)
1232: D400 First line should end with a period (not 't')
1232: D200 One-line docstring should fit on one line with quotes (found 3)
1240: D400 First line should end with a period (not 'd')
1240: D200 One-line docstring should fit on one line with quotes (found 3)
1258: D200 One-line docstring should fit on one line with quotes (found 3)
1267: D400 First line should end with a period (not 'e')
1284: D400 First line should end with a period (not 'm')
1284: D205 1 blank line required between summary line and description (found 0)
1300: D200 One-line docstring should fit on one line with quotes (found 3)
1311: D102 Missing docstring in public method
1317: D102 Missing docstring in public method
1323: D102 Missing docstring in public method
1337: D102 Missing docstring in public method
1350: D200 One-line docstring should fit on one line with quotes (found 3)
1377: D102 Missing docstring in public method
1436: D102 Missing docstring in public method
1481: D102 Missing docstring in public method
1489: D102 Missing docstring in public method
1499: D102 Missing docstring in public method
1508: D102 Missing docstring in public method
1511: D102 Missing docstring in public method
1515: D102 Missing docstring in public method
1519: D102 Missing docstring in public method
1539: D102 Missing docstring in public method
1547: D102 Missing docstring in public method
1555: D102 Missing docstring in public method
1561: D102 Missing docstring in public method


25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be error_codes, require_api_auth, require_header, require_oauth_scopes
30:1: I100 Imports statements are in the wrong order. from invenio.ext.restful should be before from werkzeug.utils
32:1: F401 'acc_authorize_action' imported but unused
33:1: I101 Imported names are in the wrong order. Should be Deposition, DepositionDoesNotExists, DepositionError, DepositionFile, DepositionNotDeletable, DraftDoesNotExists, FileDoesNotExists, FilenameAlreadyExists, ForbiddenAction, FormDoesNotExists, InvalidApiAction, InvalidDepositionType
271: D102 Missing docstring in public method
274: D102 Missing docstring in public method
277: D102 Missing docstring in public method
280: D102 Missing docstring in public method
283: D102 Missing docstring in public method
297: D102 Missing docstring in public method
317: D102 Missing docstring in public method
320: D102 Missing docstring in public method
323: D102 Missing docstring in public method
338: D102 Missing docstring in public method
341: D102 Missing docstring in public method
344: D102 Missing docstring in public method
347: D102 Missing docstring in public method
350: D102 Missing docstring in public method
353: D102 Missing docstring in public method
369: D102 Missing docstring in public method
381: D102 Missing docstring in public method
384: D102 Missing docstring in public method
387: D102 Missing docstring in public method
390: D102 Missing docstring in public method
403: D102 Missing docstring in public method
412: D102 Missing docstring in public method
415: D102 Missing docstring in public method
418: D102 Missing docstring in public method
421: D102 Missing docstring in public method
424: D102 Missing docstring in public method
506: D102 Missing docstring in public method
509: D102 Missing docstring in public method
512: D102 Missing docstring in public method
515: D102 Missing docstring in public method
546: D102 Missing docstring in public method
588: D102 Missing docstring in public method
591: D102 Missing docstring in public method
594: D102 Missing docstring in public method
601: D103 Missing docstring in public function


Would it make sense to make the things more explicit and say e.g.:

```python
from publicapi.settings import MONGO_DBNAME
...
...
PUBLICAPI_DBNAME = MONGO_DBNAME
```
This way we can get rid of the #noqa and @UnusedImport type comments, as they are not appealing and should be used sparsely. :)


Good idea, I'll look into that.


yep


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.192](http://teamcity.monogame.net/viewLog.html?buildId=7752&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:23:07


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.193](http://teamcity.monogame.net/viewLog.html?buildId=7756&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Yeah I am not quite happy with this, the issue is that mixed in with creating the dynamic repo there are normalise calls mixed in. If I remove them and just have one after tests fail.

I threw it all in a single class so we can figure it out properly and make the whole gitpreparer cleaner


为什么要私自交流呢？ 让更多的人看到不是更好吗？更多的人看到解决方法，更
多的人帮你解决？

On 2015-3-31 17:44, Armink wrote:
>
> @AllenBird <https://github.com/AllenBird> 383016632@qq.com
> <mailto:383016632@qq.com>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/armink/EasyFlash/commit/3a31e0e9b0584f601386b4c7785ccbeac1b88a94#commitcomment-10487317>.
>


How about something like before this change but assigning to new variables..
```python
seed_dip = -np.deg2rad(dip)
seed_azimuth = -np.deg2rad(azimuth)
...
return np.array([np.sin(seed_dip),
                 -np.cos(seed_azimuth) * np.cos(seed_dip),
                 -np.sin(seed_azimuth) * np.cos(seed_dip)])
```

That points out that SEED convention is used.. ?


hello


Given this, does this patch seem sensible to you?


you really don't want to use try-with-resource :)


Why just suppress these exceptions?


I don't want this entry to be set (even with None value) in the dictionary if there was no value.


RuntimeException is too generic - may be lllegalArgumentException is better? Or IllegalStateException.


javadoc?


Don't like it


Doesn't affect anything in the scope but I'll change it :)


You are right. Just added it


I'd rather initialize this property in the declaration


Good suggestion, will do


True, it doesn't, but it's a good practice. :)


just a nit: in the future, if you are not changing the surrounding code, having a lone whitespace change in some other portion of the code (other than the patch is addressing) is ugly and somewhat confusing.


why not having `validateBranch` return the branch and avoid testing both reportMetadata.hasBranch and the branch variable inside the method `validateBranch`?


This is actually edemo feature, and yes, it is necessary to check it, because we do not want to allow create PUBLIC_RW pipelines to anybody without this special permission; So the real purpose of this permission is to prevent eDemo roles from creating PUBLIC_RW pipelines or even editing if they existed.

But as you say, this does not affect admin and user roles in any way as they have the permission


Oh, OK then.


I do not see an advantage from a warning.


xlt()


@ eshioji Many thanks for reporting back.  Would you mind sending a separate pull request with comments (in case you haven't) for this so that what you wrote above is not buried under this old PR for STORM-329?  This will make it easier to solicit feedback about the bug report and your PR.

Again, many thanks!


No, why?


28:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
153:58: E203 whitespace before ','
213:15: E126 continuation line over-indented for hanging indent
216:1: E402 module level import not at top of file
250:17: E203 whitespace before ':'
251:22: E203 whitespace before ':'
252:20: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:24: E203 whitespace before ':'
255:22: E203 whitespace before ':'
256:19: E203 whitespace before ':'
257:20: E203 whitespace before ':'
258:23: E203 whitespace before ':'
259:18: E203 whitespace before ':'
260:17: E203 whitespace before ':'
261:19: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:21: E203 whitespace before ':'
264:19: E203 whitespace before ':'
265:19: E203 whitespace before ':'
266:20: E203 whitespace before ':'
267:17: E203 whitespace before ':'
268:24: E203 whitespace before ':'
269:23: E203 whitespace before ':'
270:21: E203 whitespace before ':'
271:37: E203 whitespace before ':'
285:4: E131 continuation line unaligned for hanging indent
314:1: W391 blank line at end of file


37:1: I201 Missing newline before sections or imports.
145: D102 Missing docstring in public method
154: D400 First line should end with a period (not 'n')
154: D205 1 blank line required between summary line and description (found 0)
243: D102 Missing docstring in public method
283: D400 First line should end with a period (not 'w')
283: D205 1 blank line required between summary line and description (found 0)
296: D400 First line should end with a period (not 'e')
296: D205 1 blank line required between summary line and description (found 0)
311: D400 First line should end with a period (not 'e')
311: D205 1 blank line required between summary line and description (found 0)
319: D400 First line should end with a period (not 'e')
319: D205 1 blank line required between summary line and description (found 0)
330: D400 First line should end with a period (not 'd')
330: D205 1 blank line required between summary line and description (found 0)
352: D102 Missing docstring in public method
356: D102 Missing docstring in public method
368: D400 First line should end with a period (not 'd')
391: D400 First line should end with a period (not 'n')
391: D200 One-line docstring should fit on one line with quotes (found 3)
398: D400 First line should end with a period (not 't')
398: D200 One-line docstring should fit on one line with quotes (found 3)
405: D400 First line should end with a period (not 'e')
405: D200 One-line docstring should fit on one line with quotes (found 3)
412: D102 Missing docstring in public method
434: D102 Missing docstring in public method
442: D102 Missing docstring in public method
446: D210 No whitespaces allowed surrounding docstring text
446: D400 First line should end with a period (not ')')
451: D210 No whitespaces allowed surrounding docstring text
451: D400 First line should end with a period (not 'd')
458: D210 No whitespaces allowed surrounding docstring text
458: D400 First line should end with a period (not 't')
474:17: W503 line break before binary operator
488: D102 Missing docstring in public method
502: D102 Missing docstring in public method
523: D210 No whitespaces allowed surrounding docstring text
523: D400 First line should end with a period (not 's')
529: D102 Missing docstring in public method
536: D210 No whitespaces allowed surrounding docstring text
536: D400 First line should end with a period (not 's')
541: D210 No whitespaces allowed surrounding docstring text
541: D400 First line should end with a period (not 's')
546: D210 No whitespaces allowed surrounding docstring text
546: D400 First line should end with a period (not 's')
551: D210 No whitespaces allowed surrounding docstring text
551: D400 First line should end with a period (not 's')
556: D400 First line should end with a period (not 'r')
556: D205 1 blank line required between summary line and description (found 0)
569: D400 First line should end with a period (not 'e')
614: D102 Missing docstring in public method
619: D102 Missing docstring in public method
630: D102 Missing docstring in public method
637: D102 Missing docstring in public method
643: D102 Missing docstring in public method
649: D102 Missing docstring in public method
654: D102 Missing docstring in public method
661: D210 No whitespaces allowed surrounding docstring text
661: D400 First line should end with a period (not 'e')
665: D210 No whitespaces allowed surrounding docstring text
665: D400 First line should end with a period (not 'e')
669: D210 No whitespaces allowed surrounding docstring text
669: D400 First line should end with a period (not 'e')
673: D210 No whitespaces allowed surrounding docstring text
673: D400 First line should end with a period (not 'e')
678: D203 1 blank line required before class docstring (found 0)
678: D204 1 blank line required after class docstring (found 0)
678: D400 First line should end with a period (not 'r')
678: D205 1 blank line required between summary line and description (found 0)
684: D102 Missing docstring in public method
689: D200 One-line docstring should fit on one line with quotes (found 3)
705: D102 Missing docstring in public method
710: D210 No whitespaces allowed surrounding docstring text
710: D400 First line should end with a period (not 'n')
718: D210 No whitespaces allowed surrounding docstring text
718: D400 First line should end with a period (not 'n')
722: D210 No whitespaces allowed surrounding docstring text
722: D400 First line should end with a period (not 'n')
728: D200 One-line docstring should fit on one line with quotes (found 3)
734: D400 First line should end with a period (not 's')
734: D200 One-line docstring should fit on one line with quotes (found 3)
747: D203 1 blank line required before class docstring (found 0)
747: D204 1 blank line required after class docstring (found 0)
747: D400 First line should end with a period (not 'm')
747: D200 One-line docstring should fit on one line with quotes (found 3)
751: D102 Missing docstring in public method
762: D102 Missing docstring in public method
770: D102 Missing docstring in public method
781: D102 Missing docstring in public method
784: D102 Missing docstring in public method
787: D102 Missing docstring in public method
794: D200 One-line docstring should fit on one line with quotes (found 3)
800: D200 One-line docstring should fit on one line with quotes (found 3)
810: D200 One-line docstring should fit on one line with quotes (found 3)
873:13: W503 line break before binary operator
943: D400 First line should end with a period (not 's')
951:9: E731 do not assign a lambda expression, use a def
966: D203 1 blank line required before class docstring (found 0)
966: D204 1 blank line required after class docstring (found 0)
966: D400 First line should end with a period (not 't')
973: D102 Missing docstring in public method
995: D102 Missing docstring in public method
999: D102 Missing docstring in public method
1003: D102 Missing docstring in public method
1008: D102 Missing docstring in public method
1012: D102 Missing docstring in public method
1016: D102 Missing docstring in public method
1023: D400 First line should end with a period (not 'd')
1043: D400 First line should end with a period (not 't')
1043: D200 One-line docstring should fit on one line with quotes (found 3)
1066: D400 First line should end with a period (not 't')
1066: D200 One-line docstring should fit on one line with quotes (found 3)
1093: D200 One-line docstring should fit on one line with quotes (found 3)
1107: D400 First line should end with a period (not 't')
1107: D200 One-line docstring should fit on one line with quotes (found 3)
1124: D400 First line should end with a period (not 'n')
1124: D200 One-line docstring should fit on one line with quotes (found 3)
1147: D400 First line should end with a period (not 'w')
1175: D400 First line should end with a period (not ')')
1175: D200 One-line docstring should fit on one line with quotes (found 3)
1188: D200 One-line docstring should fit on one line with quotes (found 3)
1201: D400 First line should end with a period (not 'e')
1201: D205 1 blank line required between summary line and description (found 0)
1208: D400 First line should end with a period (not 'p')
1208: D200 One-line docstring should fit on one line with quotes (found 3)
1215: D400 First line should end with a period (not 'r')
1215: D200 One-line docstring should fit on one line with quotes (found 3)
1232: D400 First line should end with a period (not 't')
1232: D200 One-line docstring should fit on one line with quotes (found 3)
1240: D400 First line should end with a period (not 'd')
1240: D200 One-line docstring should fit on one line with quotes (found 3)
1258: D200 One-line docstring should fit on one line with quotes (found 3)
1267: D400 First line should end with a period (not 'e')
1284: D400 First line should end with a period (not 'm')
1284: D205 1 blank line required between summary line and description (found 0)
1300: D200 One-line docstring should fit on one line with quotes (found 3)
1311: D102 Missing docstring in public method
1317: D102 Missing docstring in public method
1323: D102 Missing docstring in public method
1337: D102 Missing docstring in public method
1350: D200 One-line docstring should fit on one line with quotes (found 3)
1377: D102 Missing docstring in public method
1436: D102 Missing docstring in public method
1481: D102 Missing docstring in public method
1489: D102 Missing docstring in public method
1499: D102 Missing docstring in public method
1508: D102 Missing docstring in public method
1511: D102 Missing docstring in public method
1515: D102 Missing docstring in public method
1519: D102 Missing docstring in public method
1539: D102 Missing docstring in public method
1547: D102 Missing docstring in public method
1555: D102 Missing docstring in public method
1561: D102 Missing docstring in public method


25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be error_codes, require_api_auth, require_header, require_oauth_scopes
30:1: I100 Imports statements are in the wrong order. from invenio.ext.restful should be before from werkzeug.utils
32:1: F401 'acc_authorize_action' imported but unused
33:1: I101 Imported names are in the wrong order. Should be Deposition, DepositionDoesNotExists, DepositionError, DepositionFile, DepositionNotDeletable, DraftDoesNotExists, FileDoesNotExists, FilenameAlreadyExists, ForbiddenAction, FormDoesNotExists, InvalidApiAction, InvalidDepositionType
273: D102 Missing docstring in public method
276: D102 Missing docstring in public method
279: D102 Missing docstring in public method
282: D102 Missing docstring in public method
285: D102 Missing docstring in public method
299: D102 Missing docstring in public method
319: D102 Missing docstring in public method
322: D102 Missing docstring in public method
325: D102 Missing docstring in public method
340: D102 Missing docstring in public method
343: D102 Missing docstring in public method
346: D102 Missing docstring in public method
349: D102 Missing docstring in public method
352: D102 Missing docstring in public method
355: D102 Missing docstring in public method
371: D102 Missing docstring in public method
383: D102 Missing docstring in public method
386: D102 Missing docstring in public method
389: D102 Missing docstring in public method
392: D102 Missing docstring in public method
405: D102 Missing docstring in public method
414: D102 Missing docstring in public method
417: D102 Missing docstring in public method
420: D102 Missing docstring in public method
423: D102 Missing docstring in public method
426: D102 Missing docstring in public method
508: D102 Missing docstring in public method
511: D102 Missing docstring in public method
514: D102 Missing docstring in public method
517: D102 Missing docstring in public method
548: D102 Missing docstring in public method
590: D102 Missing docstring in public method
593: D102 Missing docstring in public method
596: D102 Missing docstring in public method
603: D103 Missing docstring in public function


extra comma, remove todo


Netty' write buffer have high water mark.default is 64k.if reached it.channel will change Interest.So check isWritable is useful


Explicitly ping @eshioji just in case GitHub didn't send a notification [for my edited comment above](https://github.com/miguno/storm/commit/205eaf4ebe28ab5550a842ea9aabd23b41678743#commitcomment-11422380).


No, because there's a bug in Jacoco, and the coverage will be badly computed


Don't translate this. Use text()
You will instead translate these with xl() where the errors are created.


Yup ! :+1:
I got confused by the Ubuntu version.

I've squashed the commits together to reduce the diff and make it more readable.
https://github.com/a-detiste/lsb/commit/6074c3e6baaec9d72bb7d1b869966a63286c7f21

```
-override_dh_python2:
-	dh_python2
-	dh_python2 /usr/lib/lsb
+override_dh_python3:
+	dh_python3
+	dh_python3 /usr/lib/lsb
```


It may be obvious to you already, but I thought it would be a good time to highlight the fact that, in JavaScript, a function (like `createSongRow`) is actually an object, that is, a "box" you can attach data to. Instead of using the `function` keyword to declare a new function, you could also use a different syntax, `new Function`, which makes it more obvious that there is a `Function` "class", or "factory", you can use to generate new function "objects" from.

Because a function is actually an object (a "box"), you are free to add any kind of data inside the scope of that function. In the example above, we declare a `createSongRow` function, and inside its body, we actually add others functions (`onHover`, `offHover`, etc.) so that `createSongRow` has everything it needs to run, neatly organized as building blocks you eventually use at the end of its body (`$row.hover(onHover, offHover)`, etc.)

This is a very important concept in JavaScript, and yet many people don't use it. Try to remember that functions are objects, and can be used as a "scope" to carry a bunch of other functions and variables around.


good


> If we want to be able to unload 'events' server

Is it something you agreed with Vivien? IMHO you can't unload the 'event' iframe, because you still want your app to react to airplane mode and antennaavailable events for example. Anyway, I guess this change does not harm.


Some documentation about that concept: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function


Luego dices de títulos largos xD


you could set the `root` property inside the `visitProject` method. You'd save on a constructor parameter and make sure your visitor behave consistently (here, one could set any root, you can't know it's the project from the visitor's point of view)


why not


Sorry, I was very inattentive. Now I see.


So here, you are also unregistering the 'event' iframe. You won't be able to have information about airplane mode being enabled/disabled or antenna being plugged/unplugged while the app is in background. Is it really want you want?


indeed


only use xl() here since this code is not outputting it to html at this point.

You will escape them with text() or attr() when you echo it to html.


xl()


I'd invert the test and return immediatly to save on branch depth


Can I write a code


That's a good method :) :+1:


``````
attr($form_date)


Ez >:panhustlerflow


That's a good point. That make this variable statefull but we don't care as ValidateProjectsVisitor is created at each execution.


Thankyou


attr()


wouldn't it be appropriate to have trace or debug logs here? If ever we want to know what's going on


Joiner could be a constant, it's threadsafe


keep these as xl()

you will html escape them below

it is important to only escape things that are sent to html


then
+test_lazy_prereq UNTRACKED_CACHE '
+	{ git update-index --untracked-cache; ret=$?; } &&
+	test $ret -ne 1
+'
+
+if ! test_have_prereq UNTRACKED_CACHE; then
 	skip_all='This system does not support untracked cache'
 	test_done
![ge_suggested_photo](https://cloud.githubusercontent.com/assets/12400210/7878889/1a5f8628-05b9-11e5-9361-5ad2b0255f45.jpg)
![image](https://cloud.githubusercontent.com/assets/12400210/7878890/1a694b86-05b9-11e5-8e2d-1ca0f97d65de.jpg)


it's not clear for me what it does after multiple reads. The WS returns the members of a group. What does this parameter does ? How could a user be a member of a group and be deselected ?


attr($key)


28:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
153:58: E203 whitespace before ','
213:15: E126 continuation line over-indented for hanging indent
216:1: E402 module level import not at top of file
250:17: E203 whitespace before ':'
251:22: E203 whitespace before ':'
252:20: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:24: E203 whitespace before ':'
255:22: E203 whitespace before ':'
256:19: E203 whitespace before ':'
257:20: E203 whitespace before ':'
258:23: E203 whitespace before ':'
259:18: E203 whitespace before ':'
260:17: E203 whitespace before ':'
261:19: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:21: E203 whitespace before ':'
264:19: E203 whitespace before ':'
265:19: E203 whitespace before ':'
266:20: E203 whitespace before ':'
267:17: E203 whitespace before ':'
268:24: E203 whitespace before ':'
269:23: E203 whitespace before ':'
270:21: E203 whitespace before ':'
271:37: E203 whitespace before ':'
285:4: E131 continuation line unaligned for hanging indent
314:1: W391 blank line at end of file


37:1: I201 Missing newline before sections or imports.
145: D102 Missing docstring in public method
154: D400 First line should end with a period (not 'n')
154: D205 1 blank line required between summary line and description (found 0)
243: D102 Missing docstring in public method
283: D400 First line should end with a period (not 'w')
283: D205 1 blank line required between summary line and description (found 0)
296: D400 First line should end with a period (not 'e')
296: D205 1 blank line required between summary line and description (found 0)
311: D400 First line should end with a period (not 'e')
311: D205 1 blank line required between summary line and description (found 0)
319: D400 First line should end with a period (not 'e')
319: D205 1 blank line required between summary line and description (found 0)
330: D400 First line should end with a period (not 'd')
330: D205 1 blank line required between summary line and description (found 0)
352: D102 Missing docstring in public method
356: D102 Missing docstring in public method
368: D400 First line should end with a period (not 'd')
391: D400 First line should end with a period (not 'n')
391: D200 One-line docstring should fit on one line with quotes (found 3)
398: D400 First line should end with a period (not 't')
398: D200 One-line docstring should fit on one line with quotes (found 3)
405: D400 First line should end with a period (not 'e')
405: D200 One-line docstring should fit on one line with quotes (found 3)
412: D102 Missing docstring in public method
434: D102 Missing docstring in public method
442: D102 Missing docstring in public method
446: D210 No whitespaces allowed surrounding docstring text
446: D400 First line should end with a period (not ')')
451: D210 No whitespaces allowed surrounding docstring text
451: D400 First line should end with a period (not 'd')
458: D210 No whitespaces allowed surrounding docstring text
458: D400 First line should end with a period (not 't')
474:17: W503 line break before binary operator
488: D102 Missing docstring in public method
502: D102 Missing docstring in public method
523: D210 No whitespaces allowed surrounding docstring text
523: D400 First line should end with a period (not 's')
529: D102 Missing docstring in public method
536: D210 No whitespaces allowed surrounding docstring text
536: D400 First line should end with a period (not 's')
541: D210 No whitespaces allowed surrounding docstring text
541: D400 First line should end with a period (not 's')
546: D210 No whitespaces allowed surrounding docstring text
546: D400 First line should end with a period (not 's')
551: D210 No whitespaces allowed surrounding docstring text
551: D400 First line should end with a period (not 's')
556: D400 First line should end with a period (not 'r')
556: D205 1 blank line required between summary line and description (found 0)
569: D400 First line should end with a period (not 'e')
614: D102 Missing docstring in public method
619: D102 Missing docstring in public method
630: D102 Missing docstring in public method
637: D102 Missing docstring in public method
643: D102 Missing docstring in public method
649: D102 Missing docstring in public method
654: D102 Missing docstring in public method
661: D210 No whitespaces allowed surrounding docstring text
661: D400 First line should end with a period (not 'e')
665: D210 No whitespaces allowed surrounding docstring text
665: D400 First line should end with a period (not 'e')
669: D210 No whitespaces allowed surrounding docstring text
669: D400 First line should end with a period (not 'e')
673: D210 No whitespaces allowed surrounding docstring text
673: D400 First line should end with a period (not 'e')
678: D203 1 blank line required before class docstring (found 0)
678: D204 1 blank line required after class docstring (found 0)
678: D400 First line should end with a period (not 'r')
678: D205 1 blank line required between summary line and description (found 0)
684: D102 Missing docstring in public method
689: D200 One-line docstring should fit on one line with quotes (found 3)
705: D102 Missing docstring in public method
710: D210 No whitespaces allowed surrounding docstring text
710: D400 First line should end with a period (not 'n')
718: D210 No whitespaces allowed surrounding docstring text
718: D400 First line should end with a period (not 'n')
722: D210 No whitespaces allowed surrounding docstring text
722: D400 First line should end with a period (not 'n')
728: D200 One-line docstring should fit on one line with quotes (found 3)
734: D400 First line should end with a period (not 's')
734: D200 One-line docstring should fit on one line with quotes (found 3)
747: D203 1 blank line required before class docstring (found 0)
747: D204 1 blank line required after class docstring (found 0)
747: D400 First line should end with a period (not 'm')
747: D200 One-line docstring should fit on one line with quotes (found 3)
751: D102 Missing docstring in public method
762: D102 Missing docstring in public method
770: D102 Missing docstring in public method
781: D102 Missing docstring in public method
784: D102 Missing docstring in public method
787: D102 Missing docstring in public method
794: D200 One-line docstring should fit on one line with quotes (found 3)
800: D200 One-line docstring should fit on one line with quotes (found 3)
810: D200 One-line docstring should fit on one line with quotes (found 3)
873:13: W503 line break before binary operator
943: D400 First line should end with a period (not 's')
951:9: E731 do not assign a lambda expression, use a def
966: D203 1 blank line required before class docstring (found 0)
966: D204 1 blank line required after class docstring (found 0)
966: D400 First line should end with a period (not 't')
973: D102 Missing docstring in public method
995: D102 Missing docstring in public method
999: D102 Missing docstring in public method
1003: D102 Missing docstring in public method
1008: D102 Missing docstring in public method
1012: D102 Missing docstring in public method
1016: D102 Missing docstring in public method
1023: D400 First line should end with a period (not 'd')
1043: D400 First line should end with a period (not 't')
1043: D200 One-line docstring should fit on one line with quotes (found 3)
1066: D400 First line should end with a period (not 't')
1066: D200 One-line docstring should fit on one line with quotes (found 3)
1093: D200 One-line docstring should fit on one line with quotes (found 3)
1107: D400 First line should end with a period (not 't')
1107: D200 One-line docstring should fit on one line with quotes (found 3)
1124: D400 First line should end with a period (not 'n')
1124: D200 One-line docstring should fit on one line with quotes (found 3)
1147: D400 First line should end with a period (not 'w')
1175: D400 First line should end with a period (not ')')
1175: D200 One-line docstring should fit on one line with quotes (found 3)
1188: D200 One-line docstring should fit on one line with quotes (found 3)
1201: D400 First line should end with a period (not 'e')
1201: D205 1 blank line required between summary line and description (found 0)
1208: D400 First line should end with a period (not 'p')
1208: D200 One-line docstring should fit on one line with quotes (found 3)
1215: D400 First line should end with a period (not 'r')
1215: D200 One-line docstring should fit on one line with quotes (found 3)
1232: D400 First line should end with a period (not 't')
1232: D200 One-line docstring should fit on one line with quotes (found 3)
1240: D400 First line should end with a period (not 'd')
1240: D200 One-line docstring should fit on one line with quotes (found 3)
1258: D200 One-line docstring should fit on one line with quotes (found 3)
1267: D400 First line should end with a period (not 'e')
1284: D400 First line should end with a period (not 'm')
1284: D205 1 blank line required between summary line and description (found 0)
1300: D200 One-line docstring should fit on one line with quotes (found 3)
1311: D102 Missing docstring in public method
1317: D102 Missing docstring in public method
1323: D102 Missing docstring in public method
1337: D102 Missing docstring in public method
1350: D200 One-line docstring should fit on one line with quotes (found 3)
1377: D102 Missing docstring in public method
1436: D102 Missing docstring in public method
1481: D102 Missing docstring in public method
1489: D102 Missing docstring in public method
1499: D102 Missing docstring in public method
1508: D102 Missing docstring in public method
1511: D102 Missing docstring in public method
1515: D102 Missing docstring in public method
1519: D102 Missing docstring in public method
1539: D102 Missing docstring in public method
1547: D102 Missing docstring in public method
1555: D102 Missing docstring in public method
1561: D102 Missing docstring in public method


25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be error_codes, require_api_auth, require_header, require_oauth_scopes
30:1: I100 Imports statements are in the wrong order. from invenio.ext.restful should be before from werkzeug.utils
32:1: F401 'acc_authorize_action' imported but unused
33:1: I101 Imported names are in the wrong order. Should be Deposition, DepositionDoesNotExists, DepositionError, DepositionFile, DepositionNotDeletable, DraftDoesNotExists, FileDoesNotExists, FilenameAlreadyExists, ForbiddenAction, FormDoesNotExists, InvalidApiAction, InvalidDepositionType
273: D102 Missing docstring in public method
276: D102 Missing docstring in public method
279: D102 Missing docstring in public method
282: D102 Missing docstring in public method
285: D102 Missing docstring in public method
299: D102 Missing docstring in public method
319: D102 Missing docstring in public method
322: D102 Missing docstring in public method
325: D102 Missing docstring in public method
340: D102 Missing docstring in public method
343: D102 Missing docstring in public method
346: D102 Missing docstring in public method
349: D102 Missing docstring in public method
352: D102 Missing docstring in public method
355: D102 Missing docstring in public method
371: D102 Missing docstring in public method
383: D102 Missing docstring in public method
386: D102 Missing docstring in public method
389: D102 Missing docstring in public method
392: D102 Missing docstring in public method
405: D102 Missing docstring in public method
414: D102 Missing docstring in public method
417: D102 Missing docstring in public method
420: D102 Missing docstring in public method
423: D102 Missing docstring in public method
426: D102 Missing docstring in public method
508: D102 Missing docstring in public method
511: D102 Missing docstring in public method
514: D102 Missing docstring in public method
517: D102 Missing docstring in public method
548: D102 Missing docstring in public method
590: D102 Missing docstring in public method
593: D102 Missing docstring in public method
596: D102 Missing docstring in public method
603: D103 Missing docstring in public function


text($value)


Hey Can u tell me what is apiKey here. I am't able to get the notification


Raise 'java.lang.NullPointerException' on Mac OS X Yosemite.


No matter what, we need this chain.

"Sync_wq" never wake up, sync freq also never implemented.

bfs is currently still missing some features. For example: https: //github.com/bbedward/ZenKernel_Shamu/commit/3f7fe9e85073a6eb0246c5b527357a77a3a6700e

Sorry, I did not mean to offend.

sync freq remains a key influence performance. We may try to use non-delay queue instead of it.


text()


good


That's a lot of CSS. Was everything clear?


Breaks UI check for Voron on 32bit


I already tried "~", but it dose not work as expected. Actually it dose not assign anything to variable and only spits stdout. Maybe its related to my php version or something :?

I adopted file_put_contents thou. :+1:

```
file_put_contents($file, $string, FILE_APPEND);
```


ok.
It looks like you have the hang of it. Make recommended changes and then try to convert the rest of your code(feel free to ask any question along the way). When done, then rebase it into 1 commit and submit it for review again. Thanks!!
-brady


You can name these functions by doing: `addClientSecret: function addClientSecret(req, res, next) {`


Copyright © Gerard Braad!


What do you mean ?


同じような操作をしているように見えるけど、jQueryで記述した方(上)だと始めに読み込んだ時に10度回転しない。L70のhandlerの引数の`event`の使い方が間違ってる臭い？


@gbraad


thfd


for (var i = opData.length -1; i > = 0 && opData[i] === undefined && !opData.pop(); i--);


I would write:

```java
if (moduleDto = null) {
  return;
}
if (moduleDto.projectUuid().equals(moduleDto.uuid())) {
          // module is actually a project
          validationMessages.add(String.format("The project \"%s\" is already defined in SonarQube but not as a module of project \"%s\". "
            + "If you really want to stop directly analysing project \"%s\", please first delete it from SonarQube and then relaunch the analysis of project \"%s\".",
            moduleKey, projectKey, moduleKey, projectKey));
        } else if (!moduleDto.projectUuid().equals(root.getUuid())) {
          ComponentDto projectModule = componentDao.selectByUuid(session, moduleDto.projectUuid());
          validationMessages.add(String.format("Module \"%s\" is already part of project \"%s\"", moduleKey, projectModule.key()));
        }
```


Missing new line :wink:


@alexliu68
Why is this `c_table` and not just `table`, but  we have `keyspace` and not `c_keyspace` as well as `c_cluster`?
Inconsistent and hard to remember. We don't need this "c_" prefix, for we already know we're doing this in the context of Cassandra.


Commit message:

- Add a blank line between paragraphs
- "thanks to" -> "through"
- "who need" -> "because it needs"
- "whose specializes" -> "who specializes"
- ".." -> "."
- "any more" -> "anymore"


//zhangzhen


aaa


:open_mouth: OMG you are completely right! I just added them as dimensions: https://github.com/pixable/pixalytics/commit/6198e63c7f89daaf5cdd03c1eb4a30b77aa494d6


Hast du alle Logos/Bilder verkleinert? Hab mal das logo.png genommen und konnte es nochmals um 70% von 36kb auf 10kb verkleiner


Can I use `clusterName:keyspaceName:tableName/propertyName ?


It's the same as all "select-list" related WS:
* ``selected=all`` (default) lists all users, telling if they are members or not
* ``selected=selected`` only lists members
* ``selected=deselected`` only lists non-members


@njam @tomaszdurka What is the best way to call `smarty_block_ratioKeeper` here ? It requires `Smarty_Internal_Template $template`. How to pass this template to `CM_Usertext_Markdown`? What are your thoughts? Thanks you.


Is it possible to have only partially programmatic ways of creating DataFrames? If not, then remove "most".


I will make this beautiful next week


please check code


Ok I understand. I do not like it very much to return nothing in a void method but indeed it reduce the number of branch.


Turns out this is a word pair where the new confusion rule works well, so I've added it there: https://github.com/languagetool-org/languagetool/commit/b143e0a46d45b0f93ed1f8476b78ef40cd512e0b

BTW, you don't need to add the correct sentence anymore if it's the same as the incorrect one with the correction applied.


oh whoops, I meant:

```php
function l($msg)
{
    if ( !Kint::enabled() ) return;

    ~$output = Kint::dump($msg);
    file_put_contents('log.txt',$output, FILE_APPEND);
}
```

I'll have to document this.


There is no support of "Hidden" property in my version of SPMeta2.I think, I have to sync my sources with spmeta2 root.


Underlines? I thought the option key was "spark.cassandra.input.page.row.size", but maybe I missed some translation happening here.


LGTM!


Isn't this guy scripted in SD2?


moreover, the description implies that you return a subset if the parameter is specified. Which is not true if you provide the SELECTION_ALL value. Have I missed something ?


I wouldn't create a mixin that's only one line (`line-height: $height`). You could achieve the same result just by assigning your variable to the CSS rule:

``` css
.album-header-information {
  h3 {
    line-heigth: $line-height-header-info;
  }
}
```


:+1: thanks


@t3hnar Is this here because you can set the payload type of PersistentRepr instead of PersistentRepr type?


@jamesotron I guess I'm thinking it the other way.

So you specify
``` ruby
s.add_dependency "faye", ["~> 1.1.1"]
```
But I know that `faye (1.1.1)` has a bug

If a `1.1.2` was released and also broke `faye-rails`
then anyone using `faye-rails` running a `bundle update` would end up with `faye (1.1.2)`

But your `travis` would only ever run against `1.1.1`.

Ideally I'd say `travis should re-run whenever new versions of your dependencies are released` and track against them.

But in reality that doesn't happen.


After `fopen` the file position should be at just the beginning. `fseek` may cause some time, especially for `f_lseek` from FATFS. I don't know if such call could be removed.
For `fread` this time you would read in 4 bytes, and your buffer is indeed `30 30 30 00` in hex. Since you only used two chars - or even would use just one byte (2 bits), i don't know if we really need such a buffer. Fortunately only a few chars would not cause significant time difference. So you can forget this, yep.
BTW please think about `char buffer[4];` since you don't need its initialized value, and gcc should fill the buffer with all 0s iirc.


It fact this use case can happen when :
- First analysis -> OK
- component key is used in another project -> That's the goal of following methods to fail with a proper message


Fixed install trouble and update version.


layout :100:
title : 바디 챌린저 !


Ok


As far as I can see, everything looks pretty good.

You have a lot of spots where you've renamed files something like:  `textbook/tools/make/example2/main.c → ...ok/Chapter-1/Section-1.3/make/example5/src/main.c`.  The folder names `Chapter-1` and `Section-1.3` need to be improved.  In particular:

* files should never be capitalized in this repo

* start numbering at zero

* remove the dash; you also don't need the `1.` in the section name because it's already within chapter 1

* you need to include a short description of the section in the pathname

So in the example above, the filename should be something like: `.../chapter0-creating-a-project/section3-make/...`

---

It looks like you've modified a bunch of files to obey the 1 sentence per line rule.  You don't have to go through every file and update it this way.

---

Those are the only comments I have right now.  But I remember you wanted to ask some questions, so maybe we can talk after class Friday.


Now that you practiced loops you may find it interesting that there's an easier way to do this exercise. You can lowercase the whole string first, split it by comma and return. One line solution! :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.193](http://teamcity.monogame.net/viewLog.html?buildId=7756&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 496, ignored: 6 Build time: 00:29:42


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.194](http://teamcity.monogame.net/viewLog.html?buildId=7760&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


28:1: I100 Imports statements are in the wrong order. from invenio.ext.cache should be before from werkzeug.datastructures


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
153:58: E203 whitespace before ','
213:15: E126 continuation line over-indented for hanging indent
216:1: E402 module level import not at top of file
250:17: E203 whitespace before ':'
251:22: E203 whitespace before ':'
252:20: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:24: E203 whitespace before ':'
255:22: E203 whitespace before ':'
256:19: E203 whitespace before ':'
257:20: E203 whitespace before ':'
258:23: E203 whitespace before ':'
259:18: E203 whitespace before ':'
260:17: E203 whitespace before ':'
261:19: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:21: E203 whitespace before ':'
264:19: E203 whitespace before ':'
265:19: E203 whitespace before ':'
266:20: E203 whitespace before ':'
267:17: E203 whitespace before ':'
268:24: E203 whitespace before ':'
269:23: E203 whitespace before ':'
270:21: E203 whitespace before ':'
271:37: E203 whitespace before ':'
285:4: E131 continuation line unaligned for hanging indent
314:1: W391 blank line at end of file


37:1: I201 Missing newline before sections or imports.
145: D102 Missing docstring in public method
154: D400 First line should end with a period (not 'n')
154: D205 1 blank line required between summary line and description (found 0)
243: D102 Missing docstring in public method
283: D400 First line should end with a period (not 'w')
283: D205 1 blank line required between summary line and description (found 0)
296: D400 First line should end with a period (not 'e')
296: D205 1 blank line required between summary line and description (found 0)
311: D400 First line should end with a period (not 'e')
311: D205 1 blank line required between summary line and description (found 0)
319: D400 First line should end with a period (not 'e')
319: D205 1 blank line required between summary line and description (found 0)
330: D400 First line should end with a period (not 'd')
330: D205 1 blank line required between summary line and description (found 0)
352: D102 Missing docstring in public method
356: D102 Missing docstring in public method
368: D400 First line should end with a period (not 'd')
391: D400 First line should end with a period (not 'n')
391: D200 One-line docstring should fit on one line with quotes (found 3)
398: D400 First line should end with a period (not 't')
398: D200 One-line docstring should fit on one line with quotes (found 3)
405: D400 First line should end with a period (not 'e')
405: D200 One-line docstring should fit on one line with quotes (found 3)
412: D102 Missing docstring in public method
434: D102 Missing docstring in public method
442: D102 Missing docstring in public method
446: D210 No whitespaces allowed surrounding docstring text
446: D400 First line should end with a period (not ')')
451: D210 No whitespaces allowed surrounding docstring text
451: D400 First line should end with a period (not 'd')
458: D210 No whitespaces allowed surrounding docstring text
458: D400 First line should end with a period (not 't')
474:17: W503 line break before binary operator
488: D102 Missing docstring in public method
502: D102 Missing docstring in public method
523: D210 No whitespaces allowed surrounding docstring text
523: D400 First line should end with a period (not 's')
529: D102 Missing docstring in public method
536: D210 No whitespaces allowed surrounding docstring text
536: D400 First line should end with a period (not 's')
541: D210 No whitespaces allowed surrounding docstring text
541: D400 First line should end with a period (not 's')
546: D210 No whitespaces allowed surrounding docstring text
546: D400 First line should end with a period (not 's')
551: D210 No whitespaces allowed surrounding docstring text
551: D400 First line should end with a period (not 's')
556: D400 First line should end with a period (not 'r')
556: D205 1 blank line required between summary line and description (found 0)
569: D400 First line should end with a period (not 'e')
614: D102 Missing docstring in public method
619: D102 Missing docstring in public method
630: D102 Missing docstring in public method
637: D102 Missing docstring in public method
643: D102 Missing docstring in public method
649: D102 Missing docstring in public method
654: D102 Missing docstring in public method
661: D210 No whitespaces allowed surrounding docstring text
661: D400 First line should end with a period (not 'e')
665: D210 No whitespaces allowed surrounding docstring text
665: D400 First line should end with a period (not 'e')
669: D210 No whitespaces allowed surrounding docstring text
669: D400 First line should end with a period (not 'e')
673: D210 No whitespaces allowed surrounding docstring text
673: D400 First line should end with a period (not 'e')
678: D203 1 blank line required before class docstring (found 0)
678: D204 1 blank line required after class docstring (found 0)
678: D400 First line should end with a period (not 'r')
678: D205 1 blank line required between summary line and description (found 0)
684: D102 Missing docstring in public method
689: D200 One-line docstring should fit on one line with quotes (found 3)
705: D102 Missing docstring in public method
710: D210 No whitespaces allowed surrounding docstring text
710: D400 First line should end with a period (not 'n')
718: D210 No whitespaces allowed surrounding docstring text
718: D400 First line should end with a period (not 'n')
722: D210 No whitespaces allowed surrounding docstring text
722: D400 First line should end with a period (not 'n')
728: D200 One-line docstring should fit on one line with quotes (found 3)
734: D400 First line should end with a period (not 's')
734: D200 One-line docstring should fit on one line with quotes (found 3)
747: D203 1 blank line required before class docstring (found 0)
747: D204 1 blank line required after class docstring (found 0)
747: D400 First line should end with a period (not 'm')
747: D200 One-line docstring should fit on one line with quotes (found 3)
751: D102 Missing docstring in public method
762: D102 Missing docstring in public method
770: D102 Missing docstring in public method
781: D102 Missing docstring in public method
784: D102 Missing docstring in public method
787: D102 Missing docstring in public method
794: D200 One-line docstring should fit on one line with quotes (found 3)
800: D200 One-line docstring should fit on one line with quotes (found 3)
810: D200 One-line docstring should fit on one line with quotes (found 3)
873:13: W503 line break before binary operator
943: D400 First line should end with a period (not 's')
951:9: E731 do not assign a lambda expression, use a def
966: D203 1 blank line required before class docstring (found 0)
966: D204 1 blank line required after class docstring (found 0)
966: D400 First line should end with a period (not 't')
973: D102 Missing docstring in public method
995: D102 Missing docstring in public method
999: D102 Missing docstring in public method
1003: D102 Missing docstring in public method
1008: D102 Missing docstring in public method
1012: D102 Missing docstring in public method
1016: D102 Missing docstring in public method
1023: D400 First line should end with a period (not 'd')
1043: D400 First line should end with a period (not 't')
1043: D200 One-line docstring should fit on one line with quotes (found 3)
1066: D400 First line should end with a period (not 't')
1066: D200 One-line docstring should fit on one line with quotes (found 3)
1093: D200 One-line docstring should fit on one line with quotes (found 3)
1107: D400 First line should end with a period (not 't')
1107: D200 One-line docstring should fit on one line with quotes (found 3)
1124: D400 First line should end with a period (not 'n')
1124: D200 One-line docstring should fit on one line with quotes (found 3)
1147: D400 First line should end with a period (not 'w')
1175: D400 First line should end with a period (not ')')
1175: D200 One-line docstring should fit on one line with quotes (found 3)
1188: D200 One-line docstring should fit on one line with quotes (found 3)
1201: D400 First line should end with a period (not 'e')
1201: D205 1 blank line required between summary line and description (found 0)
1208: D400 First line should end with a period (not 'p')
1208: D200 One-line docstring should fit on one line with quotes (found 3)
1215: D400 First line should end with a period (not 'r')
1215: D200 One-line docstring should fit on one line with quotes (found 3)
1232: D400 First line should end with a period (not 't')
1232: D200 One-line docstring should fit on one line with quotes (found 3)
1240: D400 First line should end with a period (not 'd')
1240: D200 One-line docstring should fit on one line with quotes (found 3)
1258: D200 One-line docstring should fit on one line with quotes (found 3)
1267: D400 First line should end with a period (not 'e')
1284: D400 First line should end with a period (not 'm')
1284: D205 1 blank line required between summary line and description (found 0)
1300: D200 One-line docstring should fit on one line with quotes (found 3)
1311: D102 Missing docstring in public method
1317: D102 Missing docstring in public method
1323: D102 Missing docstring in public method
1337: D102 Missing docstring in public method
1350: D200 One-line docstring should fit on one line with quotes (found 3)
1377: D102 Missing docstring in public method
1436: D102 Missing docstring in public method
1481: D102 Missing docstring in public method
1489: D102 Missing docstring in public method
1499: D102 Missing docstring in public method
1508: D102 Missing docstring in public method
1511: D102 Missing docstring in public method
1515: D102 Missing docstring in public method
1519: D102 Missing docstring in public method
1539: D102 Missing docstring in public method
1547: D102 Missing docstring in public method
1555: D102 Missing docstring in public method
1561: D102 Missing docstring in public method


25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be error_codes, require_api_auth, require_header, require_oauth_scopes
30:1: I100 Imports statements are in the wrong order. from invenio.ext.restful should be before from werkzeug.utils
32:1: F401 'acc_authorize_action' imported but unused
33:1: I101 Imported names are in the wrong order. Should be Deposition, DepositionDoesNotExists, DepositionError, DepositionFile, DepositionNotDeletable, DraftDoesNotExists, FileDoesNotExists, FilenameAlreadyExists, ForbiddenAction, FormDoesNotExists, InvalidApiAction, InvalidDepositionType
273: D102 Missing docstring in public method
276: D102 Missing docstring in public method
279: D102 Missing docstring in public method
282: D102 Missing docstring in public method
285: D102 Missing docstring in public method
299: D102 Missing docstring in public method
319: D102 Missing docstring in public method
322: D102 Missing docstring in public method
325: D102 Missing docstring in public method
340: D102 Missing docstring in public method
343: D102 Missing docstring in public method
346: D102 Missing docstring in public method
349: D102 Missing docstring in public method
352: D102 Missing docstring in public method
355: D102 Missing docstring in public method
371: D102 Missing docstring in public method
383: D102 Missing docstring in public method
386: D102 Missing docstring in public method
389: D102 Missing docstring in public method
392: D102 Missing docstring in public method
405: D102 Missing docstring in public method
414: D102 Missing docstring in public method
417: D102 Missing docstring in public method
420: D102 Missing docstring in public method
423: D102 Missing docstring in public method
426: D102 Missing docstring in public method
508: D102 Missing docstring in public method
511: D102 Missing docstring in public method
514: D102 Missing docstring in public method
517: D102 Missing docstring in public method
548: D102 Missing docstring in public method
590: D102 Missing docstring in public method
593: D102 Missing docstring in public method
596: D102 Missing docstring in public method
603: D103 Missing docstring in public function


Nice usage of nesting and Sass in general :+1:

Beware of a trap though: [deep nesting](http://thesassway.com/beginner/the-inception-rule).


Better :)


按比例显示很好，但如果我想移动self.player.view.frame的原点，比如视频源是4:3(16:12)的，iPhone5s是16:9，我按比例显示，但是这样高度就不能充满屏幕。如果我想高度适应整个屏幕高度，保持比列，宽度一部分不显示，那要如何做呢？


Copy that.


This was not tested then.... please report it as an issue.


Thanks for the change. I pulled it and tried again. Unfortunately, while `vagrant provision`:

    TASK: [php-fpm | Check php-fpm syntax of configuration files] *****************
    failed: [default] => {"changed": true, "cmd": "php5-fpm -t", "delta": "0:00:00.026774", "end": "2015-05-29 10:28:29.089172", "rc": 78, "start": "2015-05-29 10:28:29.062398", "stdout_lines": [], "warnings": []}
    stderr: [29-May-2015 10:28:29] ERROR: [/etc/php5/fpm/php-fpm.conf:4] unknown entry 'request_terminate_timeout'
    [29-May-2015 10:28:29] ERROR: failed to load configuration file '/etc/php5/fpm/php-fpm.conf'
    [29-May-2015 10:28:29] ERROR: FPM initialization failed

    FATAL: all hosts have already failed -- aborting

    PLAY RECAP ********************************************************************
               to retry, use: --limit @/Users/andreas/site.retry

    default                    : ok=42   changed=13   unreachable=0    failed=1

    Ansible failed to complete successfully. Any error output should be
    visible above. Please fix these errors and try again.


Sorry, it dose not work.
```
~$output = Kint::dump($msg);
var_dump($output); die();

$ php /var/www/index.php
10:30:04, literal = string (3) "abc"
Called from .../index.php:22
string(0) ""
```

Any idea what could be wrong?

```
php -v
PHP 5.5.9-1ubuntu4.9 (cli) (built: Apr 17 2015 11:44:57)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.3, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.3, Copyright (c) 2002-2013, by Derick Rethans
```


"we" --> "that" ?


"A designed for all fonts" --> "A designed for all font" (minus the "s"), I guess...


Thanks Leaena, this is so helpful!


this description is misleading. WDYTO "List the members with membership information for one group." I'm not convinced, but it's still clearer.


--dns
--snr
The choice only have true and false, and default is false. How about make the option without argument. If user set --snr without argument, processor will enable snr.


ffffffffff


tttt


same change here.


no need to check HAVE_LIBCL here. for long term, ISP may have this option if possible.


I suggest you use the generic addSearchQuery method


nope, that's for snapshots to see it's payload rather then internal envelope.


коммит под названием `js` на 40 измененных файлов с кучей лишнего - очень плохая практика. Делай больше коммитов, разделенных по конкретным задачам. "Исправила Grunt" "добавила новый блок", "стилизовала что-то"


функция зачет, но половина кода в ней - лишняя


多行字符串用三个引号


do you recommend the Query pattern for this simple cases ?


I don't follow what causes this to be null after a call to connection.close()

I suspect I'm missing something; feel free to tell me if I'm being an idiot.


I think a more pythonic way to do this would be
for row in reader[1:]:
This way you don't need to row_number variable since it seems like thats in place to skip the first row element.


please use the common pattern at the dao level: selectNullableById and selectById


need for PBCosString


Instead, you can use NotificationHelper, which handles l10n for you and you don't need formatValue then - https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Notification_API :)


有没有感觉这个0好熟悉。。。


I think the correct thing here is to initialize a boolean to false at method scope, set it true here, and then call notifyCloseListeners() outside the synchronized block if it's been set. That will have an equivalent effect.


@fandrei - before returning the local path here; could you just check that the current process can access it (ie, has read permissions).  if not; then just fall back to the original UNC path


removed


CSharp plugins are currently designed to be implemented in the `Oxide.Plugins` namespace. The API requires access to this namespace, and since plugins are limited to single files, there is very little advantage to using a separate namespace.

I know that there is a need for decreased overhead of inter-plugin communication as well as clean implementation of compartmentalized plugins. Options are currently rather limited but there will be more available in the future. Until then plugins will just have to live with using the `Oxide.Plugins` namespace.

Various things are going to change in the future, as more options for large scale plugins are made available to developers. There is a lot of room for improvement in this department and there are multiple possible directions which can be taken, some of which are already currently in the early stages of being prototyped and benchmarked.


这里可以稍微加点注释，可以把网站地址的格式稍微说明一下


Great, thanks for that


thank you, updated


"secured with"


please indent


yes, of course


Just stumbled on this problem and I think this line should be added to additional libraries for Win (line 40), but someone who uses Win should test this.


"... by following [ ..."


Kalista assemblies use to not cast E even if it could kill the target, doesn't this make it worse ?


testing


i need to back this out and bring over just the java files changed.


Copy that.

A tough checkpoint though, with nested callback functions. Anything blocking you can remember of, or maybe something that wasn't clear prior to our first meetings, but is now better understood?


都用单引号吧


MyBatis.closeQuietly(session)


Its actually the other way around. The input is the SEED convention but then we would have to change the the function interface as well.


rename session in dbSession


Why?


Should work for the commands, but can't an error happen in the events too ?


No <i> and <em> tags


Why was this removed?
That's what the Boost guys use, they probably know what they're doing.
http://www.boost.org/doc/libs/1_45_0/boost/smart_ptr/detail/yield_k.hpp
(also a version for GCC in that link)


I've observed a NPE in my logs, so I simply added the guard. I assume I ran into a concurrency issue, where two actions that both lead to a 'close' interfere with each other.


feels weird to use the paging.offset and the pageSize variable. I would use the paging methods only. Same for code before in the method


Wieso generierst du die Sinuswerte jedes Sample neu? Das kann man noch optimieren glaub ich ;)


Here `list` is not needed.


在逗号、分号、冒号前面不要加空格。逗号、分号、冒号后面必须加空格，除非那是行尾。


TeamCity xBIM :: XbimWebUI :: Build [Build 56](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1769&buildTypeId=XBIM_XbimWebUI_Build) is now running


Much better now! :+1:


Suggestion: "Most endpoints can only be accessed with a proper authorization."


"... a client ..."


"... a user ..."


You may have fixed that later on, just reporting it right now: try to be consistent with the indentation, in between files of the same kind (.scss, .js). A good habit to make.


That's not true.
http://i.imgur.com/HnK1VEL.png


TeamCity xBIM :: XbimWebUI :: Build [Build 56](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1769&buildTypeId=XBIM_XbimWebUI_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:52


please use the WebService.Param constants


you REALLY prefer a blank line between each field declaration ? ^^


add @Category(DbTests.class)


Really? Does that really work? :)


创个子文件夹吧  spider


How do you do this during school? :P


Hecho, simplemente es al constructor que hay pasarle mi clase, no habia visto ese constructor.


I don't think I'm catching your drift. I'm not seeing how this will prevent a second invocation of notifyCloseListeners() when deliverRawText() invokes close() itself. Wouldn't that invocation have its own value for that boolean that you suggest?


IIRC LiveSplit handles the events on its own... and it doesn't use try-catches. I'll add exception handling to the events ASAP or after school (during school will be problematic with a phone, without flatrate, at a public event).


This is so that the ExampleTheme has colors for the UI test (else it doesn't customize anything and we can't test anything).


Add space between ; and text and between two {} like
```.spacer5 { height: 5px; width: 100%; }```


There's no javadoc for any method in this class :(


FYI it's a blueish background, so that it's obvious wether the theme works or not ;)


At least it should not be here :-)


This is a copy-paste from `loadModules` method.


Again, this is copy paste from existing method in this class.


It was (spent so much time for this single line -_-), since it's a "general" UI test (and not a plugin UI test) I guess the ExampleTheme has no reason to be activated.


Ick, bad typo. Bad!


czemu


do you mind renaming it ws or wsTester ?


what is ``@i`` ? why you use ```to_s``` ?


there, I added this into documentation:

https://github.com/raveren/kint#tips--tricks

```php
		$msg = 'ads';
		~$output = Kint::dump($msg);
		ddd($output);
```
everything works perfectly.


Apparently this was needed for Travis CI, since now Travis CI gives green lights.

WireMock tried to verify the auth request while it's still in process.


这个统一一下吧，那个google里面好像没有定义这个，就写成# coding: utf-8吧  可以少写几个字母


I'm not sure I undestand this … which put this controller ?


I copy-pasted a lot of code from existing methods, so your comments (like use of exceptions, lack of javadoc etc.) could also be applied to existing code too. Should I fix existing code too?


attr()


http://developer.android.com/reference/android/media/AudioTrack.html#setLoopPoints(int, int, int)


Just SSHing to my server and work further in vim XD


attr() then text()


bo temu


I couldn't merge this one into the AC3.3 branch I think because the acceleration limiting patch isn't there.  So I think we need to make a decision about whether you want that in AC3.3 or not.


why not use the one in rubygems.org?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.194](http://teamcity.monogame.net/viewLog.html?buildId=7760&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 496, ignored: 6 Build time: 00:29:33


extract method newRequest() { return tester.newGetRequest("api/usergroups", "users" } or whatever the name


Ok, the name of the role is then a bit misleading, as I would expect to check hasRole("pipeline.canEditPipelinesWithPublicRwVisibility") instead of hasRole("pipeline.setVisibilityPublicRw"), becase the latter checkes whether the user can switch pipeline from private to public rw, which is a bit different from being able to edit public rw pipeline. But this is just a suggestion to be considered. Thanks for the expl.


Opps! But it's not a problem for me.
Rather, it provides full memory barrier, so we can remove ```MemoryBarrierEx()```.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms683560(v=vs.85).aspx


ok


i love this approach even if it fails miserably :+1:


It's not necessary to have a second form for uploading images.

The only reason why you have two forms on the users page is because email and password are special attributes that you want to change more securely. They go through devise's controllers and changing email or setting new password requires a password confirmation. Other attributes are not as critical, so they don't require that and thus can be handled through your own controller with no additional checking.

In case of a post there's nothing security related, so it can be just a single form.


czemu akurat życie?


Il manque le muxC dans cette image. Il faut donc la changer à nouveau.


That's an ugly markup. Always start an HTML tag in a separate line.


That's a change, plus it's inconsistent with `tries = 2;` below.


Besides, according to Bootstrap documentation `row` should be a parent of any `col-md-` divs. See examples here: http://getbootstrap.com/css/#grid-example-basic


@i is incrementing variable and it is integer , so i have done .to_s


were -> was


lgtm


Sorry I have not seen the implementation in dstore. I made this function in response to a unit test which just use an exact match. I will look at that if I got time.


That should be `media-heading`. See the docs at http://getbootstrap.com/components/#media and then compare the layout in the docs with your own. If it doesn't look the same it means there's an error somewhere.


Oh, I see. Well, it's stated in the docstring seems like, so.. yeah, should be OK I guess. On the other hand it's a private function, so I guess it would be no big deal to change the argument names and use the `deprecated` decorator to auto-map the args. But, yeah, maybe too much hassle since it's documented alright.


This image is a perfect candidate to use `media-left` and `media-object`. See the docs on how to do that: http://getbootstrap.com/components/#media


also maybe "could cause decompression failures" instead of "is illegal"?


shit, there is a typo here! s/wheezy/jessie/


Personally I would have rewritten the Writers to accept a list of ContentListeners, but this approach works too.


Please remember to merge this branch into master before continuing.


So, the dmg of the smg2 fragments went from 6 to 8 to 4?
> enormous effect

Why? When firing in a very confined space, maybe, or does it matter for direct hits?

A very different thing i tested quickly: Making the fragments guided. That looks cool and can be combined nicely with the primary, but it seems difficult to balance (would need significant nerfs on both fire modes to compensate for those many simultaneous hits)


Remove name and version fields from opam file and updated version.


Use the new `listeners` variable in these constructors.


I reverted this change (https://github.com/ayende/ravendb/pull/2264) because no item was added to this property.


![Uploading u=3058773169,318752405&fm=90&gp=0.jpg…]()


we don't pass options at all here, so we can simplify they whole thing with this one line. Does it make sense?


Oh, it seems I am the culprit wrt to the spaces/tab issue here. Apologize!


back to your old habit ;)


also, I renamed `addEvents` to `pullEvents` / `pushEvents` respectively, as that makes more sense here I'd say


Lijkt me goed


什么开源了 不要吓我

2015-05-29 15:10 GMT+08:00 Daniel Qiu <notifications@github.com>:

> 你们把项目开源了...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TJSoftwareReuse/DeliverComponents/commit/d5039910d07fd45b754797765803f7ad0bba5695#commitcomment-11421706>
> .
>


What is this ?


If I decide to use PostgreSQL with non-CAS settings, then these foreign keys are valid. So to be 100% correct, there should be standard postgresql/schema.sql and then postgresql/schema.sql with CAS. Or at least please comment this and write that it should be uncommented for non-CAS use.


This event is needed if the user wants to load more data when all the data in this.store has been displayed.
You can see an example in `samples/list/PageableList-ObservableArray.html` in the deliteful PR.
I chose the name myself, it may not be suited for that.


merge 5/29


ooops sorry that test is actually great! I'll add it back :)


np. :smile: btw do you have any interest in a xxl set of patches that gets this [shellcheck](github.com/koalaman/shellcheck) 'friendly' ?


Please reuse same IDC as linux
	IDC_ACCURATE_BLEND,
	IDC_ACCURATE_DATE,
	IDC_ACCURATE_COLCLIP


Peter don't we have double ```createConnection``` here?
There is one more in ```fetch(url)```.


Honestly, I think that this function is a "just in case" measure and we don't need to be so elaborate.


:thumbsup:


I preffer to write br in XHTML style: `<br />`


I usually format ternaries like

```                = allExistingContent != 0 ?
                     (validContentUris.size() / (float) allExistingContent) * 100 :
                     0;```

So it looks more like a question.


It fails on 2.2.2p95 on Darwin at least: https://travis-ci.org/ruby/rubyspec/jobs/64418177
But http://rubyci.org/ would seem to indicate it's fixed in more recent versions?


Also `allExistingContent > 0`


Actually this needs to be translated, so use xla()


R.I.P.


c pour faire quoi ?


Ahh I see, I didn't think of the test for `Initialise`. But when you apply the first listing of the above comment there shouldn't be any problems as it's essentially the same (but a bit cleaner because it calls `NormalizeGitDirectory` only once).


Use ```each_with_index``` to print index number.
http://apidock.com/ruby/Enumerable/each_with_index


@jmacmahon thank you for the PR :smile: ! Would it be possible here to add something like

``` python
bot = filter(
    lambda bot: bot in user_agent,
    CFG_ELASTICSEARCH_BOT_AGENT_STRINGS
)
if bot:
    log_event['bot'] = True
```

WDYT :trollface: :trollface: ?


Ahhh right, I read this paragraph as "if you don't import the file in theme.less, it won't work" (which was wrong). I will remove it!


Maybe we could get rid of the .mli file.
That would be nice.
I guess it would involve first class modules.


de API is nog steeds niet helemaal duidelijk, ik maak het simpeler zodra ik met ruby update klaar ben


Some habits die hard ;)


Hi Sven

if I replace that method as you suggested:

	private boolean isPrimitiveBoolean(JvmTypeReference typeRef) {
		if (InferredTypeIndicator.isInferred(typeRef)) {
			return false;
		}

		if (typeRef instanceof JvmParameterizedTypeReference) {
			Object type = typeRef
					.eGet(TypesPackage.Literals.JVM_PARAMETERIZED_TYPE_REFERENCE__TYPE,
							false);
			if (type instanceof JvmType && !((JvmType) type).eIsProxy()) {
				return "boolean".equals(((JvmType) type).getIdentifier());
			}
		}
		return false;
	}

Then, in case of a boolean type, the getter will be "getXXX" instead of "isXXX", because at that stage it is still a proxy (and I wouldn't want to resolve proxies at this stage).

I was using the node model because I wanted to know whether to generate an "is" method or a "get" method *without* triggering proxy resolution.

The case for no node available is when the type reference is not part of a program but created synthetically.


try to avoid nesting promises. It usually is not needed.


won't this break if no encounter is used?


does that make sense to you?


Ok. Made it work with tilde in new branch c6b60254fb5ceb9b084e9841597f2e73c5b46e3b

But now "Called from" is wrong, because he finds ```~$output = Kint::dump($msg);```  within Kint.class.php

```
11:10:01, $msg = string (3) "asd"
Called from .../Kint.class.php:862

# expected
# Called from .../index.php:22
```

Probably because I needed to remove line https://github.com/andrejsstepanovs/kint/commit/c6b60254fb5ceb9b084e9841597f2e73c5b46e3b#diff-831b64e6a2f31153d251d17799642f03L407

This makes tilde work, but at the same time breaks called from functionality for me.

Will try to do something about it later on today..


Branches are also possible...


It *should* be the same, but the test fails.. I got no idea why :p

That can be future Jakes problem


In cases like this where number of parametes is unknown, i usually build an array $sqlParameters and push the parameters into it as build the query.


Well, this makes it handle the type, but neither Ruby ffi nor Java JNA have support for flexible arrays.


`if opts.op_system != 'W' or opts.op_system != 'L'`

![http://www.roto2.com/superroto2.png](http://www.roto2.com/superroto2.png)


rename insertGroup()


Typo: "Choose"


add session.commit() in the insertGroup() method


add commit


"GitHub" is the correct notation.


Are you still filtering by filename somewhere else? The filename-based pre-filter was introduced not only to reduce CPU load, but also because FreeImage is quite prone to crashing when exposed to malformed "images" (mostly non-image files that FreeImage mistakenly believes to be images).


Format as note.


There is only two options in css that cause me sometimes trouble ```position: ``` ```absolute``` or ```relative``` and the ```display```. For each I'm not sure what option to choose, so I try until I find the right one.
For the rest in css, the hardest part is figuring what we want to do.


Typo: "changes"


feel free to criticize me about nqueen as test-data. On the other hand, it is very handy for some tests.


Typo "vith".


"Git" is the correct notation.


This commit breaks a test see https://travis-ci.org/FredrikNoren/ungit/jobs/64505806#L617-L620
Why did you changed it? I just tried it without this commit and everything works fine. (Open a diff in staging and discarded it.)


Can't "HAL" be solved with environments? Only the `Accept` header differs.


就比如某一个特定的名词，肯定要翻译的，一条一条改很麻烦，用word查找然后全部高亮，然后替换替换就好了啊


Review done and looks nice on testing. Just address above minor issues and it should be ready for commit on next revision.


You're right. I should remove this one.
But that was for the exercices of making and using mixins.


not covered by tests


I do not know, if there was a performance issue I think it has been there before, because I have just moved the function from List.js to delite/Store.js and added a condition :

```
getIdentity: function (item) {
			return this.store.getIdentity(item);
},
```
```
getIdentity: function (item) {
	if (Array.isArray(this.store) === false) {
		return this.store.getIdentity(item);
	} else {
		return item.id;
	}
 }
```
I did not notice anything.


1: M111 unrecognized component name: template


24:1: I100 Imports statements are in the wrong order. from flask_registry should be before import sqlalchemy


is it needed in non api code ?


Oh, seems that I figured it out myself :)


shouldn't it be in a utility method, logic that seems used in several places. WDYT ?


Move file to `collections/default.json` to allow for other collections in the future.


What I think is interesting is the payload event type when considering built-in projections in the eventstore. Don't you agree?


good


Hm that's curious, I just replaced the implementation of Initialise to be the following and all tests passed:

```
if (!string.IsNullOrWhiteSpace(targetUrl))
{
    var targetPath = CalculateTemporaryRepositoryPath(targetUrl, dynamicRepositoryLocation);
    DynamicGitRepositoryPath = CreateDynamicRepository(targetPath, authentication, targetUrl, targetBranch, noFetch);
}
if (normaliseGitDirectory)
{
    GitHelper.NormalizeGitDirectory(GetDotGitDirectory(), authentication, noFetch);
}
```


Ups, will remove!


rename ALL_MEMBERSHIPS or AVAILABLE_MEMBERSHIPS ?


huge security no no here. Is there a way to avoid doing this?


j'ai validé.

je n'avais encore rien changé car je voulais garder la possibiliter de cross-compiler


Just use `Louis Widmer Inside API` as description.


could use method firstNonNull as a one liner


But ok, it doesn't really matter, it's not a bug.


static import


I was hoping to see a useful diff


:) :rose:


Chutiye bc. Authorship ya credit dhang se daal. bhenchod.


Niiiceee


I didn't really have issues with callback function before (as long as I understood when they are called).
That was until the checkpoint we review together with a function explicitly named ```callback``` and where it was not clear (for me) when it was called.
But now it's good.


is the ESCAPE '/' needed ? what's the point of it ? I haven't used it in my WSs


I totally agree, that's why you should extends `EventStoreSerializer` and get a full control for `eventType`.
But why would you need to use `eventType` of snapshots which will go to the different `stream` ?


The extract of POST is a red flag. Otherwise this code is a bit above my head. Let's see if can get Rod's opinion : @sunsetsystems


khkk


Yes, `isgfx()` is still being always called before `readbitmap()` or `gendimensionsputfa()`.
The problem was that `readbitmap()` is sometimes called with the path of a temp file (to restore missing thumbnails after downloads). In that case, the extension is not valid and attributes weren't restored.

`isgfx()` was already called with the destination file name before calling `gendimensionsputfa()` so it isn't needed to call it there too.

I have checked all calls to `readbitmap()` (and functions calling it) and in all cases `isgfx()` is called before, so this change shouldn't cause any problem.


Bump to version v0.4.2 -> Bump version to v0.4.2


I would suggest to write in this way:

    def findRepeatedDnaSequences(self, s):
        n = len(s)
        c = Counter()
        for i in range(n - 9):
            c[s[i:i+10]] += 1
        return filter(lambda x: c[x] > 1, c)

Of course, it's not an interview-oriented solution... :smile:


Does it make more sense to place the jquery include near top of script to avoid others adding duplicate jquery's?


Czemu to ma służyć?


why the try catch session.close() ? put it in setUp tearDown methods


Field text_255 sudah dihapus, jika masih ada cache di lokal jangan digunakan.


These foreign keys are valid both with CAS and non-CAS application setup; Actually this file should not be part of this commit, rather it should have been done in this commit https://github.com/UnifiedViews/Core/commit/67e529bb781f4e2c7d92953f38ce7c1bf7c01a66. I don't really know how this happened.
But important thing that we need only one SQL schema for both PostgreSQL and MySQL for CAS and non-CAS configuration. The only difference is that when using CAS, user roles are not persisted but rather come from CAS an are stored in session.
And the only change in this commit should have been the change in CasAuthenticationUserDetailsService.java file.


Happy Birthday! :)


I guess this line is redundant.


@miguno Thanks for getting back, I'll do that now.


#1 btw: need to publish local first


Yeah, lazyness (`git add -p` can't split such blocks). I could fix that if you want?


подрезал


no test ? ;) maybe you could reuse part of the test I added to gaia ?


The existing code has:

public void close() {
  synchronised(this) {
    ...
  }
  notifyCloseListeners();
}

This means that notifyCloseListeners() can be called multiple times; but when it is called it doesn't cause a deadlock.

You currently have:

public synchronized void close() {
  ...
  notifyCloseListeners();
}

So notifyCloseListeners() is only called once, but may cause a deadlock.

I'm suggesting:

public void close() {
  boolean notifyClose = false;
  synchronised(this) {
    ...
    // notifyCloseListeners(); // Replace this with setting the boolean
   notifyClose = true;
  }
  if (notifyClose) {
    notifyCloseListeners();
  }
}

I think that gets equivalent behaviour to your code - calling notifyCloseListeners() only once - but does so without it causing a deadlock.


you get fired a lot :p


I think it's done, also reviewed other patches, sorry for the inconvenience!


mit welchem tool hast du sie verkleinert?
ich hab das hier verwendet: https://www.npmjs.com/package/gulp-imagemin
hiermit wird verlustlos komprimiert.


Will be corrected later on.


ここどうなってるのー？


Looking good!
You need to add this to deploy.sh too


TEST:直しました。


now the plugin will throw error when compile any program which has string literls.
https://github.com/at15/scala/issues/1


You can use `for token in tokens:` in this case, so you can write `if token == '+':` instead of `if tokens[i] == '+':`, saving several keystrokes and reducing a bit overhead.


the description will probably have to be reviewed (but let's do so when/if this is merged with the "file" widget type


There's no sense in artificially limiting password length thus making it weaker and lowering number of possible combinations to brute force significantly.


Belated Happy B'day!! :D


:facepunch: great


Tested every combination of Window focus settings and it all works correctly for me.
Are you saying when you have the "Raise on mouse over" option unchecked, it still raises windows?


:heart::heart::heart:


the handler class should not be needed anymore thanks to NXP-17153


Using `collections.deque` should be faster.  https://docs.python.org/2/library/collections.html#collections.deque

> Deques are a generalization of stacks and queues (the name is pronounced “deck” and is short for “double-ended queue”). Deques support thread-safe, memory efficient appends and pops from either side of the deque with approximately the same O(1) performance in either direction.


this should be replaced by helper functions like nxl:isLikeViewMode(widget.mode) or nxl:isBoundToEdtMode(widget.mode)


Hi Jmk ... Fedora  monitoring noticed that your page changed to version 2.2, but the tar is not referenced there. I guess you wanted to point the download site here right?
https://bugzilla.redhat.com/show_bug.cgi?id=1226087


I'll wait for @CryZe to confirm that before pulling the commit


shouldn't it be renamed group_id. We're ading a user to a group, it is not obvious which id it is.


Even if the verb is called "ban" its still "You are banned from the server." and "Banned user tried to connect.

^^


same here with userLogin ?


Loos like the link will be rendered even if blob is null (?)


Was there a reason to eliminate the MSVC and GCC 4.2 version and only keep the Borland and GCC 3 version?

Unfortunately this broke compatibility with boost::pheonix::bind on all compilers without constexpr, visible in Pheonix's bind_interoperation_test:
http://www.boost.org/development/tests/develop/developer/output/teeks99-08f-win2012R2-64on64-boost-bin-v2-libs-phoenix-test-bind_interoperation_test-test-msvc-14-0-dbg-adrs-mdl-64-thrd-mlt.html


mandatoryParam


Nah, @Gyoo did it correctly. We use Log.Error everywhere where we want to log exceptions.


Habs mit dem hier gemacht, ist aber lossy. https://tinypng.com/
Darum mit dem hier gegengecheckt: https://compressor.io/ Dort angeblich lossless. Auch bei lossless bin ich bei logo.png auf ~10kb

Ist es wichtig ob lossy oder lossledd kompremiert wurde? Unterschiede sehe ich nämlich keine.


Best wishes to the newborn baby and the lucky parents


Belated happy birthday again!


@mhugent thanks!


(refinement) maybe allow setting this via a property (like the document) if/when this helps handling the subwidget use case


please use the selectNullable pattern and here selectActive which throws NotFoundException in the DAO


@bulk88 That was my proposal in Corion/parent#3


Snapshots are not interesting with regards to event type, sorry for misunderstanding :)

I intend to use your serializer and my use case is:

Envelope(metadata, domain type) -> Protobuf translation of domain type -> Envelope(metadata, protobuf type) -> store protobuf type and metadata plus use pb type as eventtype in EventData.

Is that doable?


Bhosdike ab kang karna band kar


is used once, why not rename it userIsNotAlreadyMemberOf(...)


You may want to try this:

    def isPalindrome(self, s):
        return s == s[::-1]

But your code might be a little bit more efficient in some case. I honestly don't know. (I'm just lazy.)


installation point will cause an error when compiling


As far as I can tell, it is an evolutionary artifact. Some other defines/enums are redundant as well, will fix those.


Can you rename this method since it's not strictly selecting the filters anymore? Just to avoid confusion in future.


still referencing blob holder here


Thanks for teaching me how to setup synstastic to work with android.

In the latest version of the vim-android plugin I now set the g:syntastic_java_javac_classpath variable with the list of jars used for the specific file being edited.


Does that work for you? I couldn't get it to work when passing sanitize option properly, so I ended up hardcoding it in the wllvm driver. If it is just some building error on my end, I can change it.


Okie! I guess that is fine for the time being. I was happy with `cortex_a_common.h` as it is. It was the commit message with needed to have more information. We can pick this up when you rebase your code on top of work done in phase 1 of tf-issues/304


@ahjohannessen have you checked https://github.com/pawelkaczor/EventStore.Akka.Persistence ?


only because I'm on :fire: ;)


Well yeah I was about to say, I didn't do anything on this code XD


I think the `lib/` in the path is unnecessary, because `lib` is on the LOAD_PATH. I doubt this is having any bad effects, but it is inconsistent with the corresponding `require` statement at the top of this file.


TeamCity xBIM :: XbimWebUI :: Build [Build 57](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1770&buildTypeId=XBIM_XbimWebUI_Build) is now running