Can you explicitly set dtype.encode(ASCII)?


In English, plural of acronyms are without '


For such long constructors it would pay off if you used to the parametric notation.
new Answer(myVariable1=-1, myVariable2="", myVariable3=new Date().getTime, ...)
The reason is that your code will be more readable


It populates 4 files, not only routes


Thanks for confirming. Sorry, I was forgetting that the signature is different depending on whether it's called as a context manager or not.


Awesome. Do you have an example on how to use Salt and a use case in which it makes sense?


More than one word please :-) Maybe something like "current value of the valve"?


set_functions and FUNC_RESIZE don't exist.


This doesn't work with Python < 3, since `bytes` is an alias for `str` and it only takes one argument. Maybe add an additional check for `six.PY3`?


Should be idented.


Dies this clip the icons to be round? I don't think we want that, it will crop square icons and make them look bad.


Data in `Votes.Option_Id` and `Polls.OptionAdding` isn't migrated.


please remove all unused imports


Data in `Polls.ChoiceAdding` and `Votes.Choice_Id` isn't migrated.


I don't know what happens if you call zoomToExtent without anything. A better fall back would be to zoom to the map's maxExtent.


only thing I see that is fishy is this test:

```js
test("#handleFind failure with andFail method", function (assert) {
  Ember.run(function () {
    var done = assert.async();
    TestHelper.handleFind('profile', 1).andFail();
    store.find('profile', 1).then(
      function (response) {
        ok(false);
        done();
      },
      function (error) {
        ok(true);
        done();
      }
    );
  });
});
```

 should be like this:

```js

test("#handleFind failure with andFail method", function (assert) {
  Ember.run(function () {
    var done = assert.async();
    TestHelper.handleFind('profile', 1).andFail();
    store.find('profile', 1).then(
      function (response) {
      },
      function (error) {
        ok(true);
        done();
      }
    );
  });
});
```

other than that .. things look ok


We don't look at JSON-tmLanguage files, but we do look at `grammars/*.json` files (for Atom compatibility), and this repo has a `grammars/handlebars.json` file that is a symlink to the JSON-tmLanguage file.

I have a fix for this here: https://github.com/github/linguist/pull/2405


CS :)


Yes, but source port is being set once connection is being performed and we don't know it earlier. And the requirement was to easy track all traffic on specific stream knowing its destination port. Would it be then more reasonable to make this feature optional and disabled by default (so all streams will use one destination port) ?


Just a suggestion - if you did the loop above always 8 times no matter whether the quotient got to zero or not, you would not have to do the adjustment by adding the zeros below.


Why call `mantissa`?


please remove all unused imports!


Shouldn't this logic be in `preCheck`?


peut être + simplement  options.singletile = ($(this).find("Extension  > singleTile").text().toLowerCase()==="true")


please rename to updateThingHandlerStatus


This is missing licence header.


updateThingHandlersStatus


What's the benefit to knowing before connection time? As to making it optional and disabled by default, that makes it even worse, because it adds even more complexity, and adds a little-used/little-tested codepath to the codebase.


BTW, the same goes for the proxy handling. Currently it's integrated into the `connectHTTP` logic, but it could be layered on top just fine. That would definitely help to make the code easier to understand. But I'll not touch that part before the HTTP/2 review is done to avoid additional disturbances.


Right, you're going to start over. I was curious how this would look when you started testing output from the game is all.


:+1:

I only just realised that the website's source is on GitHub - I could've just made a PR! :)


@marcotuts -- here's the spot where I think we broke the show/hide details function -- can you confirm that we need to remove the link/toggle here?


typo: Vitotronic
add a space between handler and {}


I added #223 for further discussion.
I think this is also ongoing work, I have to adjust during the students oasp4mobile project. I am on it.


@d10 has my back :) Thank you!


"will be done by"


Best practice is to have some randomization set by default (e.g. 5 or 6 minutes). It helps spread network load when hundreds of computers start at the same time (e.g. after power failure in datacentre).
So I'd vote to set default to 300 or 360.


In fact, the awk doc says that array indices are always strings and if you use numbers, they get converted to strings first. So I guess using numbers makes us subject to the same issue we had with printf. That means the comment is slightly incorrect saying that it is due to the iteration over the array.


Does it make sense to have the same mechanism in case of "no-enc"?


typo: Received


This line looks in the request for the current locale in `RequestLocaleProvider` - which breaks in the CLI context.
Somehow I don't think Doctrine's postLoad should be concerned with the request at all.

Maybe I'm doing something wrong?


I think we don't need `bits` to save the state, because we already got `__state`, which saves brightness for each LED (can be interpreted as ON and OFF as well)


Thanks. I should have done this.


True! Thanks for noticing this!


> The thing is that `null` is a valid empty string and that it could be the result of a normal string operation, so that an intendedly empty string could be detected as an omitted parameter instead.

Someone hasn't been following the latest `if (arr)` discutions ;)

````
void main() {
    string str = "vibe.d";
    assert(str !is null);
    assert(str[$..$] !is null);
    assert("" !is null);
}
````
=> All asserts succeed.
First one is obvious. Second one succeed because `is null` checks for the **pointer**, which, for an empty slice (as the result of a string operation, is non-null. Last one is (probably) implemented this way to tell empty strings and null apparts.
So returning empty strings will work, even if an operation sets it to empty.


Layering it on top would be a little less obvious. I feel like people are used to flipping a settings option for this kind of thing. I have no preference really, if it's documented .. anything that works is fine


actually correct form is `its` :)


I agree but that will break the general pattern in this class.


@changetip tip one internet_high_five


Hi @gmertk, @ericnakagawa sent you a Bitcoin tip worth one internet_high_five (4,251 bits/$1.00), and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/844592)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


please move it up, we don't like inline assignment in conditionals :) Could we have that rule in rubocop?


@solnic `it is` == `it's` :smile:


The ID still has "mixable" in it: https://mediasession.spec.whatwg.org/#transient-mixable-media-state


The menu item is not being created for me, at Xcode 6.3.2. Tried re-installing Alactraz, but to no avail. Xcode prompts me to load the bundle, which I accepted to.


It's kind of odd to declare (in python terms) `POPULAR_WORDS` a constant when it is used in this way.


Hi Aaron,

using separate ports for every stream was an explicit requirement from the end user. This is why it would be great to leave these functionality as-is when merging into master. Regarding additional code complexity, I am sure we can put additional effort to test all the edge cases properly.

Regards,
  Jakub.


Yes, remove those secure lines and replace with travis encrypted:

   | Variable Name              | Value         |
   | -------------------------- | ------------- |
   | `ORACLE_LOGIN_ssousername` | your username |
   | `ORACLE_LOGIN_password`    | your password |


Damn it, thanks


ideals#281 - описание задачи


It seems like you're not doing anything with data and just use the content variable to fulfil that function. Can you explain this a bit? What I think you want is that you don't have to wrap the content in a list. Is this correct? If so, I think that would be good to have, but I think it should be library wide. For now could you just use data and if you can you could change BaseLaTeXContainer to check if data is not wrapped in a list and do that when necessary. This would be best in a separate pull request.


Hi, I have tried using "ktype", but get the following error message:

pi@raspberrypi ~/Downloads/stratasys-master $ sudo python stratasys-cli.py eeprom -t ktype -e 2d0000017c4e9223 -i random_file.bin
usage: stratasys-cli.py eeprom [-h] -t
                               {fox,fox2,prodigy,quantum,uprint,uprintse} -e
                               EEPROM_UID [-i INPUT_FILE] [-r]
                               [-o OUTPUT_FILE] [-m MATERIAL_NAME]
                               [-l MANUFACTURING_LOT] [-d MANUFACTURING_DATE]
                               [-u USE_DATE] [-n INITIAL_MATERIAL_QUANTITY]
                               [-c CURRENT_MATERIAL_QUANTITY]
                               [-k KEY_FRAGMENT] [-s SERIAL_NUMBER]
                               [-v VERSION] [-g SIGNATURE]
stratasys-cli.py eeprom: error: argument -t/--machine-type: invalid choice: 'ktype' (choose from 'fox', 'fox2', 'prodigy', 'quantum', 'uprint', 'uprintse')
pi@raspberrypi ~/Downloads/stratasys-master $

Any ideas what i'm doing wrong?

Regards, R


`blank?` is too broad. A zero-character string and an empty array return true for `blank?` but in those cases we do want the node to appear


any reason this class isn't just `remove-topic`?


Fixed in dbeb04c


I think you'll see that I reverted this to mattn after testing it under jonlawlor in the current master:

https://github.com/jonlawlor/go-oci8/blob/master/more_test.go


That's beside my point, I'm well aware about how arrays/strings/slices and null checks work. When I was talking about string operations, I didn't just mean slicing. Any string processing function could choose to return `null` (or an implicit `T[].init`) instead of `""` and there would be nothing wrong about it (and such code exists in many places). The simple fact is that `null` for arrays/slices is very different from every other `null` in the sense that it's valid to "dereference" it, so there is no reason for people to care for the difference when constructing an empty slice.


Can `Ledger::getReserve` return `STAmount`, and do away with `uReserve` here?


It's too late now, it does not break anything and I'm probably guilty of this as well in a few migrations, but let's try to avoid generic names in constraints - FK constraints in MySQL are global, so you can't have another one use the name `website_id_ref`


`clipboard = Gtk.clipboard_get(Gdk.SELECTION_CLIPBOARD)`


I guess this extra file doesn't actually break anything.


This should already be fixed by #62


Can `Ledger::getReserve` return `STAmount`?


Awesome!


How I do this?


Please consolidate the comments


This seems to cause an NPE for me:
```
java.lang.NullPointerException
	at org.eclipse.buildship.core.util.progress.ToolingApiWorkspaceJob.collectCausesRecursively(ToolingApiWorkspaceJob.java:162)
	at org.eclipse.buildship.core.util.progress.ToolingApiWorkspaceJob.collectErrorMessages(ToolingApiWorkspaceJob.java:156)
	at org.eclipse.buildship.core.util.progress.ToolingApiWorkspaceJob.handleUnknownFailed(ToolingApiWorkspaceJob.java:148)
	at org.eclipse.buildship.core.util.progress.ToolingApiWorkspaceJob.runInWorkspace(ToolingApiWorkspaceJob.java:82)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
```


k


This should use the time from the Time Store.


Are you *absolutely certain* this change preserves behavior?


`getReserve` could return `STAmount`


Not sure where this is used, but should the string be translatable?


couldn't we just set the `show_intro` config value to `false` in the .scummvmrc to do this ...


Oh sure, good point!


Fixed in https://github.com/whatwg/mediasession/commit/aa7af7a5e21846fd1cff26652c97e11c0b497de6 :)


I agree with @PascalPrecht

Or maybe simply `injector`?


We'll have to rewrite this commit message, and it currently doesn't make any sense. Should this be:

`ASYLUM: Encounters script size didn't match original` ?


Almost right:
- FilterExtensions should be a put in depends
- CommunityTechTree  should be put in suggests


useless copy paste?


Never mind, it seems this was a bug here as well. I think the table class needs a bit of a rewrite to get up to date with the newer classes.


What's that comment?


Ah, I see.


ok, i'll do it in next time. great thanks.


Can you get some reasoning from the customer themselves? Added code complexity is a maintenance thing, not just a one time "make sure it works", and doing so with the reasoning of "the customer wants it" isn't good reasoning from an NDT project perspective. This all needs to be thought of in the greater NDT context, not just a one-off to get something working for a customer. In that regard, how does this functionality get exposed by the server and used by the client in the protocol so that any client could request one port-per-stream?


Wow! Thank you Dave!


```ruby
num % i == 0 ? max_division3( num / i ) : max_division3( num ,  i )
```
=>
```ruby
num % i == 0 ? max_division3( num / i, i ) : max_division3( num ,  i )
```

이차이 아닐까요. 그런데 신기한게 숫자가 커야 문제가 재현되네요.


I think for a broadcast (channel == 0) to work the event must be subscribed in the client, ie `vim.subscribe('completion_begin')` in `__init__`. As an alternative, you could use `@neovim.function('FunctionName')` (or `command`) to automatically define a wrapping vimscript function.


Thanks for his fix. :-)


Right, so it does!  I'll shut up now ;)


{} please


pollFastBoot isn't specific to this device, it looks like a workaround to put it there,
unless it starts to be device specific and instead, only try to fetch the FastbootDevice instance relating to this particular ADB device. But I'm not sure that's what you want to end up with!
I think you have the same issue than ADB has. We shouldn't be scanning ADB devices unless WebIDE (or something else) cares about devices. Same thing applies to fastboot, and it may be separated from caring about ADB or Fastboot.

You may have to go through the Scanner abstraction.
jryans may have a better input as he introduced it.


Hmm, now the nav bar masks the auth include; you can see it, but can't click on it. But I'll fix that with a follow-up commit after merging.


:warning:


`this.stauts >= 200` (typo in status)


/me learns something new :thought_balloon:


Please avoid abbreviations where the works are barely longer.


Unused var anyway?


你可以 fork  出来自己改.


no no


Do you really want to keep two separate command-line parsing implementations around, even if this one is trivial?


Why `final` this?


Mauvaise manip' a la con . . .


it may be better to use a `type: "fastboot|adb"` field then such booleans attributes.


Isn't there a 'which' missing ? like 'name under which the image will be accessible'


Is there a specific reason you chose to associate this class with Map objects?


Done, thanks! https://github.com/munificent/wren/commit/3be0a396c451366b7dad2afb77864cb8629c84dc


test


Gtk.WindowEdge.SOUTH_EAST, SOUTH_WEST


`@deprecated` then?


Hey,

How do I change the favicon for my website? I've tried replacing the original 'P' favicon with the one I want. The changes do not seems to reflect. What am I doing wrong?


@yjmade OK，我会记住的


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15086/testReport/) for this commit**


Is JSON automatically being decoded by the Browser?


TeamCity Nuget Packages :: Solink.AddIn.Helpers [Build 15](http://mufasa/viewLog.html?buildId=3660&buildTypeId=NugetPackages_SolinkAddInHelpers) outcome was **SUCCESS**
Summary: Tests passed: 23 Build time: 00:00:39


The order of Gtk.Menu.popup args changed. See xl_pygtkcompat.


Just a stylistic thing - typically, people put all the scripts after the commands.


renaming dist/presentz-1.2.2.js to presentz.js messed everyting up


I think that adding the EPEL repo and installing the Python modules should go somewhere to the `common` role. We might reuse these pieces of code in other roles as well.


Why not `rbuffer_cmp(input->read_buffer, "\x1b", 2)`, like above?


Ups, this troublemaker sneaked through slippy review. Restored in 1ed81ca400666baf3577af7483d135cdb5d70292


30411/Ghemes M. Horatiu - Mihai/hash tables/Hash Tables - Open Addressing/hashTable.c

why do you have 2 returns here? only one will work


@vlj .I think similar thing need to be done for GetCond() below as well ?


Wow !! These files are uploading , serve to create a private server of Eternal Eden ?


@zarquon42b Do you still need this branch?


This is never set.


Hi Jacob,

I just added two tests as requested; one is for my fix, another is for a bug I discovered and I am unsure how to fix it. For the latter, at least we have a test case now that someone can execute to.

Please review.

Bob


Is this same theme that hod-ws currently uses?


thanks!


Oh, someone actually uses them. I can fix them.


You don't get the right result with this definition, due to limited precision. For instance, ```truncate (10. ** 30.)``` is ```0``` when you want ```1073741824```


Looks good.
and it also fixes CA-116506 (Instructed to shutdown and restart already halted HVM guest when adding CD)


@loshkovskyi well, i find that reasonable too, so i'll commit those changes together with converted README.


@devTristan wouldn't it be more semantic to leave it "null"? cause otherwise a statement timeout of zero means "no statement ever is short enough for me" just wondering.


Looks good.  Thanks for adding this!


ff


Use Wikipedia SSL link, not particular company's unless Heroku uses Comodo's solution.

http://en.wikipedia.org/wiki/SSL


sd


Nice to see this functionality coming back ! I will test with 868MHz modules I have in my toolbox...


yes very annoying timeout issue


OK, I will try to reach the customer. The tricky part is that these changes were implemented in September 2014. I found the requirement, but without information why the customer needs exactly this behaviour.

I should get back to you by the next day or two.


should this be `params[:login]` in case the login fails it keeps the value around?

both `:email` or `:membership_number` will be blank right?


das


Oh, good catch


df


Probably a minor thing, but this will keep people from being able to run multiple crab commands in parallel


geez of course, I didn't read the whole sentence, sorry about that, gonna shut up now :)


That's what I wanted to do in the first place.  But don't know how...
https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/2F9l1RLvKV8


Gdk.CursorType....


You committed two backups of the initial data file with this commit. Please remove them


Looks good.


Filing a ticket! thanks.


we could even go so far as something like this:

```sql
			INNER JOIN ResourcePermission ON
				(ResourcePermission.companyId = [$COMPANY_ID$]) AND
				(ResourcePermission.name = '[$CLASS_NAME$]') AND
				(ResourcePermission.scope = 4) AND
				(ResourcePermission.view = 1) AND
				[$ROLE_IDS_OR_OWNER_ID$] AND
 				[$PRIM_KEYS$]
```


Son repasos sanos


30411/Alb V. Corina Bianca/7.1/Assignment 7.1 Hash Tables - Open Addressing/hashTable.c

your problem is here. for some reason, your `size` variable ends up being `0` and your `%size` operation then gives an error.
Fix this and then see what else is wrong


@jbrooksuk Lol no problem!


ok this has been integrated but not via the pull request.
Please update


good!


You got enough time today


Layered on top of the internal basic HTTP logic, not on the existing public API (the `HTTPClientSettings.proxyURL` would work as before). But I'll have to dig deeper into the source code before being able to make a final judgment (after the HTTP/2 part).


should we ask the user to confirm his old password again when updating the email or password? For safety reasons.


Please also push this rct revision.


I was not happy about that either. But when I wrote this piece of code I had not refactored the "command line parsing code". I think now it's easier to reuse what we exactly have in the client. We need to write a new python script though.

I'll see if I can do this before merging the pull.


No, that is called "bizstyle". Sphinx v1.3.1 complained the "default" theme was deprecated with "classic".


Remove unnecessary line


Thanks. LGTM.


Give me a second to finish my commit. It reuses all the existing code and keeps it all from being duplicated.


"Existing users should continue to see the old behavior over upgrade."

That depends on the semantics of the packaging.  We're using `%config(noreplace) %{_sysconfdir}/sysconfig/docker-storage-setup.conf` in the current Fedora RPM, which means that if the admin has *not* modified the file, they'll get the *new* version.  Google led me to this handy table: http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html

OSTree uses the equivalent of `%config(noreplace)` for all of `/etc` consistently.

And I expect a lot of users are using the default and haven't modified the d-s-s.conf.


Not sure I understand, CRAB3_BOOTSTRAP_DIR is a temporary directory and each command will have its own.


Thanks to @neysimoes! :smile:


$index => $expectedError would be more verbose unless we have burning need to shorten the names


aha, thats how it works! :)


Sorry, I misread the code


For `labels`, should we use `New password:` and `New password confirmation:` ?


Can we use "bizstyle" as well? I always look for consistency in among products.


Somehow the commit message got lost here. Original message was something like:

Fixed THE BUG. GLL Text now updates correctly from model change and vice versus.

Fixed data flow issues and other bugs in EditorModel.
Passed reason to text and model updates. Reason is read in event listeners to prevent loops (eg text -> model -> text…)

Modified Attribute to merge `opts` passed to `set` into the EventFacade as is done in YUI.Attribute.


I moved the location string into the `HTTPClientRequest.writeHeaders` method hoping to override the original.
https://github.com/etcimon/vibe.d/commit/73c5447517df9c73bd4920dfc2f26c3d6fdb97a6#diff-c026034f390bed8de0b6d7b4cd35d4b3R982

I'm about to merge the HTTP/2 fixes into http2-cleanup branch. HTTP/2 over cleartext using the protocol upgrade mechanism is completely working and reverse proxy is tested, with and without gzip, for large and small files. I still have a problem with `firefox <-- h2 --> vibe.d reverse proxy <-- h2 --> vibe.d fileserver` to fix right now


More readable (to me) version: `self._hack_osx_control_mask = bool(e.state & Gdk.ModifierType.CONTROL_MASK)`


хороший тамада и конкурсы интересные


that won't work; it s not a subject analysis, so you have to save across subjects in a different dir.


I have already removed the redirection code (not pushed yet). I really want to layer that part on top. The request/response logic has gotten far to complex already. Let's just defer that for now and not complicate things further (the HTTP/2 merge process).


No, I have no error compile


The encoding process is actually half completed.
Characters "A", "O", "X", and "Z" are badly encoded, the resulting value doesn't match the paper Enigma result.


@aderuwe Related to https://github.com/Sylius/Sylius/issues/2652


TeamCity Jarvis Framework :: CI [Build 45](http://build.prxm.it:8811/viewLog.html?buildId=2653&buildTypeId=CqrsFramework_Ci) is now running


1: M101 signature is missing


This revision is clean.


Could we use constants instead of magic numbers?


TeamCity Jarvis Framework :: CI [Build 45](http://build.prxm.it:8811/viewLog.html?buildId=2653&buildTypeId=CqrsFramework_Ci) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 104 Build time: 00:00:52
### Failed tests
```
Jarvis.Framework.Tests.dll: Jarvis.Framework.Tests.EngineTests.BsonIdentitySerializationTests.serialize_to_bson: <no details avaliable>

```


These two lines need to be uncommented! I forgot to do it before removing some test code.


@blakeembrey A fix was released in v2.7.5. Also I've implemented another fix such that the common base directory will be calculated properly by TypeScript and I've removed this error message, since it isn't needed any more.


oh lol, can you spot the (inconsequential) bug?


Yeah, only this is needed:

```php
#define ZEPHIR_CALL_ZVAL_FUNCTION(return_value_ptr, func_name, cache, cache_slot, ...) \
	do { \
		zval *params_[] = {ZEPHIR_FETCH_VA_ARGS __VA_ARGS__}; \
		ZEPHIR_OBSERVE_OR_NULLIFY_PPZV(return_value_ptr); \
		ZEPHIR_LAST_CALL_STATUS = zephir_call_zval_func_aparams(return_value_ptr, func_name, cache, cache_slot, ZEPHIR_CALL_NUM_PARAMS(params_), ZEPHIR_PASS_CALL_PARAMS(params_) TSRMLS_CC); \
	} while (0)
```


Почему нельзя добавить third-party как библиотеку ?


@Koffeinflummi will merge your stuff automatically if you say that the `j` was a consequence of using `vim` :P


Ah yes this is confusing, the comment still does not help much:

"modLeft" is the new sample time between two samples of the original stream.
If delayLeftSourceFrame is 11.3, modeLeft is 0.3
We daw a line between sample 11 and sample 12. Let them be 5 and 7.
The calculation below becomes
5 * (1 - 0.3) = 3.5
3.5 + 7 * 0.3 = 5.6
The new sample is above 5 but still closer to 5 than to 7.
Looks right on my box paper. ;-)

We may rename "modLeft" to "timeBetweenFullSamplesLeft" or better.


I no longer believe it had anything to do with numerical stability in the matrix. This problem was all down to floating point error.


> Let's just defer that for now and not complicate things further (the HTTP/2 merge process).

Yes, I have a lot of fixes to push into the http2.d file, some in libasync, some in server.d. Can I make a commit on top of HEAD or should I checkout the specific commit ID and submit a pull request on that?


@solnic Oops, right! Old habbit, thanks for heads-up :)


uuhm what did i do


please replace ramping with "linear interpolation"


@clelland did you change itShouldReject to itShouldAccept intentionally?


Its fine, if you've made local changes you have to 'merge' the changes that you have made with the changes on the server


TeamCity Nuget Packages :: Solink.AddIn.Helpers [Build 16](http://mufasa/viewLog.html?buildId=3661&buildTypeId=NugetPackages_SolinkAddInHelpers) outcome was **SUCCESS**
Summary: Tests passed: 23 Build time: 00:00:38


I think dialogs sometimes hang when called from within another loop, I don't recall the circumstances


There is a typo in line 71 that essentially removes a column with reservation from gradebook, after reservation settings are changed.

Instead of:
```
if (!empty($resernation->maxgrade)) {   // <-- note the '$reserNation' here
```

it should be:
```
if (!empty($reservation->maxgrade)) {
```


It seems pretty confusing to have version 1.2 here and version 1.0.0 in the PostgreSQL extension metada.


few i thought i really fucked up :P


Cool stuff man!


Yeah I issued the command and got: ahjo-output-20-clean-test.csv: text/plain; charset=unknown-8bit
Note that ahjo-output-20-clean-test.csv is not a direct output from a python program but edited manually with excel and saved from excel.


FWIW, I think the reason these <li>'s were in there is a holdover from the way the navs were set up with bootstrap 1/2 vs how bootstrap 3 does things.


Why not make this user-agent the most nonsense user-agent string in the known universe by including something from every browser?


like you probably noticed i am a complete noob


Thanks for your suggestion.
As you can see, I'm new here. Actually I knew mfoc&libnfc two week ago and tried building them together  under windows + Mingw environment. this is my first time coding without IDE. Now I'm learning to be familiar with linux environment .I'll keep my eyes on this project.


I think the ipython stuff we should address separately, as I think we got the files externally. I'll revert them.


no comment ;)


Oops, this was copy and paste from existing tests before I changed the way I tested it. The abbreviation is used in the existing tests, but I shouldn't have committed those lines anyway. Removed in ddb3128.


Al final ja ho he solucionat! :)


@solnic Mh, assignment in conditionals is actually allowed in [.rubocop.yml](https://github.com/rom-rb/rom/blob/715b22f03de9b8ec42edf39792182e8a317de680/.rubocop.yml#L9-L11)

```
# It’s quite readable when we know what we are doing
```

(Wasn't me :))


Oh! Yes! Since I used the old version of the telegram-git, it doesn't expand the url. I upgrade it just now and reproduce this phenomenon on my laptop.


awesome!!


Removed the readme file in this remote because didn't need it.


`ng-show="!isAuth"` -> ng-hide="isAuth"


Just a question as I'm not familiar with the FPGA stuff. The directories under boards are all named according to the board. Is altera-c5soc the name of the evaluation board used for the Altera C5 SOC?


:dancers:


Day 7


Only because as it's the expected URI string we've set up, it's the expected result and we don't want it to be changed before it's evaluated. Not essential to have it `final` especially as it's only used a couple of lines away, but I don't see it's a problem either. I can remove `final` if you want.


I believe we had it at 2 before.


If you think this can be useful for others just make a pull request! great work!


Nope


Can you create an AHC github issue and put a reference to it here?


Yes: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest#xmlhttprequest-response


Thank a lot.
I've just fixed the typo.


add if (logger.isDebugEnabled())


Yep, we did. I initially put it back to 2, but I do kind of like it at 1, since the typeahead immediately starts showing some results for featured locations after the first character is entered. If you think it works better at 2 I can change it.


This block introduced [JENKINS-28130](https://issues.jenkins-ci.org/browse/JENKINS-28130), as it assumes that `getClangexcludedpaths()` always returns a non-`null` value.

By default, if you save a job configured with this plugin, the `clangexcludedpaths` value will indeed be stored as an empty string, which is fine.

But for people who upgrade to this version of the plugin, their job configs don't yet have a `clangexcludedpaths` value, and so this field will be `null` when an instance of this class is created.


:+1: @jadercorrea


sequenceNumber hard-coded to 1? That doesn't seem right.


94895030-BasementFileRunTime (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Pitch is right joystick. Left joystick vertical is thrust.


Please no dependency to YouTube-DL the overhead is to much...you get the stream url of the stream via the implemented YouTube-Client.


Only to save reimplementing the concept of a key/value pair as it is a mapping from key to value. Obviously it would be trivial to implement it myself rather than inheriting from `AbstractMap.SimpleEntry`.


Fixes #4


Ouch. So this was this broken all along ?

Can you add a unit test to confirm/enforce this ?
Thanks.


Links plz!


No havia vist aixó! Les notificacions de comentaris a GitHub no m'arriben al correu :sob:

Lo de ```var esteElemento = $(this)``` no et funcionava perque ho estaves declarant a fora del event click, i aleshores no feia referencia al li clickat, sino al document. Ja veig que ho has solucionat, ben fet! :)


94895030-BasementFileRunTime (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1649 of 1650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Async.map is my new friend.


Not that it matters, I created this patch several times to silence #344, never submitted it ... Why?
Because no matter what I did I could not get TagLib to fail as it was.
I even renamed taglib directories with spaces!

It does fail with CMake special characters like the semi-colon, Quoting the string won't help that!

My problem was ... Where do you draw the line!

The other CMakeLists files have unquoted path strings / variables as well ...
For example, taglib/taglib/CMakeLists.txt ... The `include_directories`, the Zlib paths, etc, ...

My finding is/was that as long as the spacy name was already in a cmake variable cmake handled them correctly. It is only an issue when adding to a variable ...

-Enjoy


94895030-BasementFileRunTime (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1655 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


@szilardhuber, can you also just mention that Test requires libzmq >= 4 "compiled with libsodium"?


I will do as much work as I can. Currently i am having trouble getting time considering school exams coming up soon.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15090/testReport/) for this commit**


Currently when adding to the chest with the shortcut, items are not automatically merged.


I don't think this is a show stopper, as it could probably be fixed by using the dual way of defining sdcs, which looks at the left-hand side declarations. Moving on to narrowing for the moment...


Ну, так как она используется рантаймом, то это оказывается нетривиальной задачей.
Думаю, Кирилл сможет пояснить подробнее, т.к. он с этим сталкивался когда добавлял использование джейсона.

@k-alexandrovsky
Кирилл, читай выше.


"I noticed that logging was globally costing 15%", don't know how you did your test but 15% is huge and we are very very far from it right now: according to Yourkit the total time spent in logback logger when displaying the home page without UI is something like 0.1%  of the request for about log 6000 calls (to mostly variants of debug() and isDebugEnabled()). And even to obtain this 0.1% I have to make everything slow as hell (7s to display the home page without UI instead of 200ms usually for me) or else Yourkit does not even list it because it's too fast.

As for the progress notifications those are not only about debug mode. The idea is to reuse them for other things like progress of a task that happen to call some code that produce progress notification or progress of the asynchronous execution of a document for example. Now of course when you don't enable debug mode there is not much happening in practice since nobody is using those notifications right now (a progress listener is only created when debug=true). Right now the 60 calls (same use case than for the log metrics I indicated) to job process manager are unnoticeable in Yourkit (about 0.01% of the request).

As you can see from these numbers we are not at a scale that really have much impact from XWiki request point of view.


Ah, yeah, there was an open issue and it didn't seem like an especially bad idea, so I just did it.  Probably not hurting anything.


Not in scope for this PR.


The mode is mavCustomMode as defined [there] (https://github.com/diydrones/ardupilot/blob/387f3276cb0a04f36255c6128371fc572f0aaaee/ArduCopter/defines.h#L88)


Fixa anche uno spam di errori sull'audio listener


Pensamos em colocar os documentos como uma lista, mas ficamos na dúvida de ficar muito mais complexo..


the name for the board is "Altera Cyclone 5 SoC development board". As per the convention used by us for board directory name we use `vendor-boardname`, thus we chose `altera-c5soc`.


Why is this needed?


Yes, thanks. Should be 12 off course


It was a D802 tester. How do they update the firmware?


A Phase for some reason I can't view the page when I click the link at the top of the repo. (Forwarding problem maybe?)


Unneeded. There can only be two possible roles, client or server.


I thought the same. (the hostname should be used and not the domain)
But RFC3920 states very clear that it should be done the other way (before the patch).
Read on: http://xmpp.org/rfcs/rfc3920.html#tls Rule 8.

The solution for merijn is to use SAN certs like from go daddy who allways include Hostname + Domainname as SAN.


This actually fixes #433, which was caused by #420. The commit description is wrong.


The folder is named 1.7.39-i386, it won't be found if looking for -i686


Thanks @mgruner that comes in pretty handy. Kudos! We wrote a Sublime Text plugin to auto generate such a XML config from a .tt file with a keyboard shortcut. Anyone interested in this can check it out here: https://github.com/znuny/Znuny4OTRS-Sublime

![generateblockhooks](https://cloud.githubusercontent.com/assets/3873515/7705818/db4f3510-fe46-11e4-90b9-09093b063ac0.gif)

Currently manual installation is required. We are waiting to get our repository confirmed for the awesome Sublime Text Package Control. After that you can install it straight from your Sublime Text Package Control via searching for "Znuny4OTRS".


Unused channels should be set to 0.


It's not a question of what the role is, it's a question of whether the role is known or not.


why not protected ?


Could you please fix the indentation


That's not valid C. Declare vars in the beginning of a block


should be SYSID_MYGCS instead of FDDroneControlManagerMavLinkDefaultSystemId


Pls ditch this line


We should address this in a separate task


rename to `HITS`.


Nice that your change alleviates the need for this hook. But your patch makes me wonder how the Linux-specific mechanism works now? Or was this dead code anyway?


`int i, ret;` - on the same line please


I would name this one methodTree for sake of clarity.


Link to a description of the algorithm and provide more detailed information what it does.


That's fine.


Please consider adapting the new base-sel4 repository (which is on staging) to this interface change.


Should be `Arma 3` not `ArmA`.


Looks good.


Consegui arrumar =)

Outro problema agora: vc compilou o openssl de modo static? Pq os progamas que são simulados no gem5 precisam ser static, e a daí quando tento compilar o teste do openssl usando as libs que vc gerou..

/home/piovezan/workspace/ECCtests/opensslArm/lib/libcrypto.a(dso_dlfcn.o): In function `dlfcn_globallookup':
dso_dlfcn.c:(.text+0x10): warning: Using 'dlopen' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

Ele mostra esse warning. E, de fato, o gem5 não consegue realizar a simulação.


Confirmed.


Good catch, thanks! A better fix is to either make them `#define`s or have only a declaration in the header and definition in the implementation file. I’ll do the latter.


Please append INCLUDE in front of the include guard (see util/string.h for an example)


These `default_media_x` functions don't seem to be called anywnere


hi课后ih


Graph displayed 5 SECONDS longer than before I meant.


The only person that should be able to login is the admin. The general public does not require login.


khanande mansor


mozik


Should double-check that this allows for querying in the form:

```python
Task.objects(callable=somefunc)
```


Very nice!


wanna soo much


No complaint from my side. @m-stein?


追加予定有り


Good catch!


Third try.


:disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)


:disappointed: Line is too long. [144/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Line is too long. [111/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Space missing after comma.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceAfterComma)


:disappointed: Space missing to the left of {.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceBeforeBlockBraces)


:disappointed: Rename `has_required_arguments?` to `required_arguments?`.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/PredicateName)


:disappointed: Line is too long. [91/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Avoid parameter lists longer than 5 parameters.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/ParameterLists)


:warning: Unused method argument - `github`. If it's necessary, use `_` or `_github` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)


:warning: Unused method argument - `repo`. If it's necessary, use `_` or `_repo` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)


:warning: Unused method argument - `sha`. If it's necessary, use `_` or `_sha` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)


:warning: Unused method argument - `file`. If it's necessary, use `_` or `_file` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)


:warning: Unused method argument - `line`. If it's necessary, use `_` or `_line` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)


:disappointed: Missing space after #.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LeadingCommentSpace)


:disappointed: Line is too long. [121/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Use def with parentheses when there are parameters.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/MethodDefParentheses)


:disappointed: Line is too long. [113/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Space found before comma.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceBeforeComma)


:warning: Useless assignment to variable - `github_username`.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UselessAssignment)


:disappointed: Line is too long. [94/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)


:disappointed: Line is too long. [86/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)


:disappointed: Extra empty line detected at block body end.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLinesAroundBlockBody)


:disappointed: 1 trailing blank lines detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/TrailingBlankLines)


@skateman Give #24 a shot.  A `rake test` should work with one failure ("blank-slate").  You can also run directly now with `rspec spec/*spec.rb` which is nice if you want to use different report formats or just run some specific tests: e.g. `rspec -e 'blank' -e 'tables' spec/compare_spec.rb`


Caracas, eu preciso voltar pra escola. :)
Valeu @aureliojargas :+1:


Problems with lib/style_check.rbLine: 5 :disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)
Line: 6 :disappointed: Line is too long. [144/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 9 :disappointed: Line is too long. [111/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 9 :disappointed: Space missing after comma.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceAfterComma)
Line: 9 :disappointed: Space missing after comma.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceAfterComma)
Line: 10 :disappointed: Space missing to the left of {.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceBeforeBlockBraces)
Line: 14 :disappointed: Rename `has_required_arguments?` to `required_arguments?`.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/PredicateName)
Line: 28 :disappointed: Line is too long. [91/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 34 :disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)
Line: 35 :disappointed: Avoid parameter lists longer than 5 parameters.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/ParameterLists)
Line: 35 :warning: Unused method argument - `github`. If it's necessary, use `_` or `_github` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `repo`. If it's necessary, use `_` or `_repo` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `sha`. If it's necessary, use `_` or `_sha` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `file`. If it's necessary, use `_` or `_file` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `line`. If it's necessary, use `_` or `_line` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 37 :disappointed: Missing space after #.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LeadingCommentSpace)
Line: 37 :disappointed: Line is too long. [121/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 40 :disappointed: Use def with parentheses when there are parameters.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/MethodDefParentheses)
Line: 41 :disappointed: Line is too long. [101/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 47 :warning: Useless assignment to variable - `github_username`.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UselessAssignment)
Line: 49 :disappointed: Missing space after #.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LeadingCommentSpace)
Line: 49 :disappointed: Line is too long. [94/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 51 :disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)
Line: 64 :disappointed: 1 trailing blank lines detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/TrailingBlankLines)


In fact this change breaks building with the workspace, with undefined symbols — something must be relying on them being external, which it is because there are *two* subtly different `EllipticLicense.h` headers in there.  Sigh, so much cleanup still to do...


typeof config.host === 'string'


hanya mencoba


.wav ska det vara, inte .mp3.


Good point.


Problems with lib/style_check2.rbLine: 5 :disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)
Line: 6 :disappointed: Line is too long. [144/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 9 :disappointed: Line is too long. [111/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 9 :disappointed: Space missing after comma.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceAfterComma)
Line: 9 :disappointed: Space missing after comma.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceAfterComma)
Line: 10 :disappointed: Space missing to the left of {.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceBeforeBlockBraces)
Line: 14 :disappointed: Rename `has_required_arguments?` to `required_arguments?`.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/PredicateName)
Line: 28 :disappointed: Line is too long. [91/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 34 :disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)
Line: 35 :disappointed: Avoid parameter lists longer than 5 parameters.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/ParameterLists)
Line: 35 :warning: Unused method argument - `github`. If it's necessary, use `_` or `_github` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `repo`. If it's necessary, use `_` or `_repo` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `sha`. If it's necessary, use `_` or `_sha` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `file`. If it's necessary, use `_` or `_file` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 35 :warning: Unused method argument - `line`. If it's necessary, use `_` or `_line` as an argument name to indicate that it won't be used.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UnusedMethodArgument)
Line: 37 :disappointed: Missing space after #.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LeadingCommentSpace)
Line: 37 :disappointed: Line is too long. [121/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 40 :disappointed: Use def with parentheses when there are parameters.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/MethodDefParentheses)
Line: 41 :disappointed: Line is too long. [101/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 47 :warning: Useless assignment to variable - `github_username`.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/UselessAssignment)
Line: 49 :disappointed: Missing space after #.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LeadingCommentSpace)
Line: 49 :disappointed: Line is too long. [94/80]
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Metrics/LineLength)
Line: 51 :disappointed: Extra blank line detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/EmptyLines)
Line: 64 :disappointed: 1 trailing blank lines detected.
[More information about this rule](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/TrailingBlankLines)


TeamCity Jarvis Framework :: CI [Build 46](http://build.prxm.it:8811/viewLog.html?buildId=2655&buildTypeId=CqrsFramework_Ci) is now running


Will wait for Travis to finish the tests and will test it against XenServer 6.2 and KVM.

Thanks!


Oh, sure, that haven't crossed my mind actually :)


TeamCity Jarvis Framework :: CI [Build 46](http://build.prxm.it:8811/viewLog.html?buildId=2655&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 105 Build time: 00:00:55


Can people test this, by checking the new "Match project CRS" field in the main dialog box? Let me know whether it works.


TeamCity Azmq :: Build (Linux) [Build 94](https://78.46.71.115/viewLog.html?buildId=481&buildTypeId=Azmq_BuildLinux&guest=1) is now running


Good point


TeamCity Azmq :: Build (Windows) [Build 124](https://78.46.71.115/viewLog.html?buildId=482&buildTypeId=Azmq_Build&guest=1) is now running


TeamCity Azmq :: Build (OSX) [Build 78](https://78.46.71.115/viewLog.html?buildId=483&buildTypeId=Azmq_BuildOsx&guest=1) is now running


:+1: exciting.


please create only one if statement separated with ||
and remove else:
```
if (...) {
 return $specialprice
}
return null;
```


Can I get some feedback on the approach I took here? Is there perhaps a better way to get a path with and answer replaced?

See the usage below.

The reason why I need this is explained in the commit message.


Port 443  (not 43)


Esto por que aparecio aca?


tada!


can u explain this a little bit?XD


TeamCity Azmq :: Build (OSX) [Build 78](https://78.46.71.115/viewLog.html?buildId=483&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:02:28


TeamCity Azmq :: Build (Linux) [Build 94](https://78.46.71.115/viewLog.html?buildId=481&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:02:42


TeamCity Azmq :: Build (Windows) [Build 124](https://78.46.71.115/viewLog.html?buildId=482&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:02:43


Have you tried to find RIL class in source code alps wet kk 82?

http://pan.baidu.com/s/1c0jdCQ0


Look like you have some misspelled


Hmm, I haven't necessarily tested it on the N4 as I don't have the device but... on shamu I have this same commit and ambient display remains to be on by default. I don't think it works, unfortunately.


Hummmm
Não foi static não
Mas deve ser só por a flag
Em 19/05/2015 11:59, "Felipe de Azevedo Piovezan" <notifications@github.com>
escreveu:

> Consegui arrumar =)
>
> Outro problema agora: vc compilou o openssl de modo static? Pq os progamas
> que são simulados no gem5 precisam ser static, e a daí quando tento
> compilar o teste do openssl usando as libs que vc gerou..
>
> /home/piovezan/workspace/ECCtests/opensslArm/lib/libcrypto.a(dso_dlfcn.o):
> In function `dlfcn_globallookup':
> dso_dlfcn.c:(.text+0x10): warning: Using 'dlopen' in statically linked
> applications requires at runtime the shared libraries from the glibc
> version used for linking
>
> Ele mostra esse warning. E, de fato, o gem5 não consegue realizar a
> simulação.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/felipepiovezan/ECCtests/commit/91e892e937d82a7552cdf5bc55189fb3768a0f3e#commitcomment-11263733>
> .
>


Great, thanks :+1:


RIP :hankey:


I have tested against Xen but not KVM yet.  Just firing up a hypervisor!

On 19 May 2015 at 17:10, Wilder Rodrigues <notifications@github.com> wrote:

> Will wait for Travis to finish the tests and will test it against
> XenServer 6.2 and KVM.
>
> Thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/isoutham/cloudstack/commit/ab915b6c921452fa7999c1f882add4ea3a82419a#commitcomment-11264016>
> .
>


Do we want to disallow future timestamps as well? If a server has a very slow clock, then nothing will fail but it will be vulnerable to replays.


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


No, they apparently aren't as I already moved them to where they should be and this commit broke client again.


94895030-BasementFileRunTime (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1655 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


94895030-BasementFileRunTime (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (632 of 632 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.29%25-green.svg)


@jirutka please be as kind as possible in comments, see https://github.com/thoughtbot/guides/tree/master/code-review


@ahmetalpbalkan I must admit I find this to be a poor way to design the API of this SDK. Especially in terms of usability. How can a user of this SDK now know what the required parameters are? Which values in the struct are required and which are optional?

If you are going to make all functions work like this, it would mean users of the package need to constantly check the docs to see what they need to provide. I would opt for having the required parameters as function parameters and the option once in an additional param struct.

What do you think?


You can use the relref shortcode for this.


Motion to make the Moses executable use all cores by default.


Use Dictionary?


@Zidane I didn't move the place where the event fired in order to be nice to mods. If the event is fired earlier, some fields in the player object may be null/empty which a mod may not be anticipating. I guess the only way to see if this is the case is to try it and see what happens with mods loaded.


TODO: remove for-loop, work with _.each


functionnal

uwy vs english


TODO: Implement Dictionary


Wouldn't this still be a useful test?  Are threshold users supposed to be able to take down petitions?


`preCheck` is `virtual` and can be overriden, and I wanted to make sure this is always called. A subset of this check was present in `payFee` but I decided to move it here, before we do any more work.


The old behaviour is not necessarily broken, it's just encryption which has a problem with it for some reason


@modwizcode can you check whether this resolves your issue with the static injector


`Ledger` didn't have a depedendency on `STAmount` and I wanted to avoid introducing one, but I can see the advantages.


I totally forgot we were using our own fork of StreamingKit and we could remove these warnings ourselves :laughing: Thanks for this!


`destroyCoins` accepts a `std::uint64_t` which is the number of drops to destroy.


that won't work as we use a variety of repos (gotham/helix/isengard) and not all addons are in the newest one.


Why? You are setting the news like status no NO. Even if it's YES.


Done.


I was under the impression that they can take them down, and that only difference between sysadmins and admins is the ability to manage users?


I am 99.95% certain, and am hopeful that my careful and thorough reviewers will bolster my confidence to 100%.


Should be changed IMO. I think this style makes harder to read code.

On Tue, May 19, 2015 at 4:35 PM Peter Suschlik <notifications@github.com>
wrote:

> @solnic <https://github.com/solnic> Mh, assignment in conditionals is
> actually allowed in .rubocop.yml
> <https://github.com/rom-rb/rom/blob/715b22f03de9b8ec42edf39792182e8a317de680/.rubocop.yml#L9-L11>
>
> # It’s quite readable when we know what we are doing
>
> (Wasn't me :))
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rom-rb/rom/commit/1b9b94912d574e8f5287566cf01e3c40f6aba760#commitcomment-11263162>
> .
>


All cores -1 sounds more reasonable. Just in case, somethings needs to be attended urgently while moses is decoding.


`parseInt('something that is not a number') === NaN`

I just coalesce in a zero because that way `timeout` is always the same type. Zero is for no timeout. That's how Postgres does it. Leaving it, or switching it to null, wouldn't actually make the code behave any differently.


Dont't know why, but a docker run error is coming first than the expected error, @nuxlli.


Jenkins test this


Hi, the salt integration is a work in progress (no docs yet).
The salt backend allow testinfra to use salt communication channel to run commands on remote hosts (minions). This have to be run from the salt master, for example:

    testinfra --connection=salt --hosts=minion1,minion2 test_file.py

Next I'm planning a Salt fixture (and maybe a SaltGrains too) that expose all the salt modules in testinfra, the syntax of the test file will be something like:

  assert Salt("pkg.version", "nginx") == "1.6.2-5"

Under the hood testinfra will call the salt api (or run salt-call if not running under the salt backend).

The idea of salt integration in testinfra is that it is the most convenient way to write tests for salt based deployments and salt has a full and better os support than testinfra will never have :)


Sounds good. I will move these over.


In that case I think we should fix the clock synching, or pull the node out of rotation, since it seems like that could cause a lot of other problems.  I don't know of any actual vulnerability involving replay attacks that is stopped by this timestamp.  We already prevent the `code` being re-used in the access token endpoint.


Sure, I agree 100%. I need to clean up that and remove the bootstrap functionality.


Ok, got it. So if users are using out of box setup and there is no docker-storage-setup.conf to begin with, then new file will disable the growpart behavior over upgrade.

So experience for different users will be different based on setup. If we disable it by default, then experience will be consistent but there might be surprises over upgrade. Not sure how many people will care though as there is an easy way to enable it.


Well, they should know what parameters are required. :-) This is an API and it has comprehensive docs. Even though you're using Python or .NET SDK you still need to know what each parameter means.

The library is not really designed to be super usable because it's meant to bu just a shim over the API and if we add certain required checks then it no loger becomes just a shim but starts having client side logic.

Also taking struct args makes the method signature extensible without breaking the backwards compatibility.


lol, I just changed this to double check things were getting updated. Didn't mean to remove you @cburgdorf! :-)


Testing comment


this is the line that raise error before the expected


In my thinking, an objective should always be an outcome, or else it gets pretty confusing.  In the metrics example, "measuring baseline metrics" is the action we would take to get to the outcome of "understanding current usage of our product"


it looks like issue with ffmpeg, ffmpeg currently doesnt work with VS 2015. Bitpet__ disabled it afaik


崩溃代码
2015-05-19 22:57:12.278 d-IOS-L8-Homepwner[46900:3638924] *** Assertion failure in -[UITableView dequeueReusableCellWithIdentifier:forIndexPath:], /SourceCache/UIKit_Sim/UIKit-3347.44/UITableView.m:6245
2015-05-19 22:57:12.283 d-IOS-L8-Homepwner[46900:3638924] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'unable to dequeue a cell with identifier UITableViewCell - must register a nib or a class for the identifier or connect a prototype cell in a storyboard'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010f015c65 __exceptionPreprocess + 165
	1   libobjc.A.dylib                     0x000000010ecaebb7 objc_exception_throw + 45
	2   CoreFoundation                      0x000000010f015aca +[NSException raise:format:arguments:] + 106
	3   Foundation                          0x000000010e8c398f -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 195
	4   UIKit                               0x000000010f5022a4 -[UITableView dequeueReusableCellWithIdentifier:forIndexPath:] + 153
	5   d-IOS-L8-Homepwner                  0x000000010e779881 -[YKItemsTableViewController tableView:cellForRowAtIndexPath:] + 113
	6   UIKit                               0x000000010f50fa28 -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] + 508
	7   UIKit                               0x000000010f4ee248 -[UITableView _updateVisibleCellsNow:isRecursive:] + 2853
	8   UIKit                               0x000000010f5048a9 -[UITableView layoutSubviews] + 210
	9   UIKit                               0x000000010f48ea2b -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 536
	10  QuartzCore                          0x0000000112c67ec2 -[CALayer layoutSublayers] + 146
	11  QuartzCore                          0x0000000112c5c6d6 _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 380
	12  QuartzCore                          0x0000000112c5c546 _ZN2CA5Layer28layout_and_display_if_neededEPNS_11TransactionE + 24
	13  QuartzCore                          0x0000000112bc8886 _ZN2CA7Context18commit_transactionEPNS_11TransactionE + 242
	14  QuartzCore                          0x0000000112bc9a3a _ZN2CA11Transaction6commitEv + 462
	15  UIKit                               0x000000010f40ca2d -[UIApplication _reportMainSceneUpdateFinished:] + 44
	16  UIKit                               0x000000010f40d6f1 -[UIApplication _runWithMainScene:transitionContext:completion:] + 2648
	17  UIKit                               0x000000010f40c0d5 -[UIApplication workspaceDidEndTransaction:] + 179
	18  FrontBoardServices                  0x0000000111be25e5 __31-[FBSSerialQueue performAsync:]_block_invoke_2 + 21
	19  CoreFoundation                      0x000000010ef4941c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
	20  CoreFoundation                      0x000000010ef3f165 __CFRunLoopDoBlocks + 341
	21  CoreFoundation                      0x000000010ef3ef25 __CFRunLoopRun + 2389
	22  CoreFoundation                      0x000000010ef3e366 CFRunLoopRunSpecific + 470
	23  UIKit                               0x000000010f40bb42 -[UIApplication _run] + 413
	24  UIKit                               0x000000010f40e900 UIApplicationMain + 1282
	25  d-IOS-L8-Homepwner                  0x000000010e77a29f main + 111
	26  libdyld.dylib                       0x00000001115cd145 start + 1
	27  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)


Ok. Thanks


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: templates/designer/aggregate_query_panel.php, templates/designer/database_tables.php, templates/designer/having_query_panel.php, templates/designer/options_panel.php, templates/designer/query_details.php, templates/designer/side_menu.php, templates/designer/where_query_panel.php


please add a docstring that says this returns True only if the site is up and being served


I like it!


음.. 전혀 감이 안 오네.. 포토샵으로 먼저 해보자 그럼


```run.sh``` is likely to clash with an existing script - how about expecting ```.buildpack-run.sh``` or something similar?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15095/testReport/) for this commit**


This was a Java 8 methode. Just redid it myself. (aka Copy/Paste)


Crazy! Thanks for all the help @Craga89 :D :D :D


Invalid number


Never say never, but a deprecation warning or something would be nice :)


freizeile zu viel :P


This is great! Thanks for the fix.


Oh, I guess it's unclear because we had an "admins can't" scenario but no "threshold can" or "threshold can't" scenario to make it clear.  Perhaps one for @yahoopete to clarify?


Note that `esc_sql()` is unnecessary here, `intval()` provides all of the escaping needed. In addition, this is actually the wrong context for using `esc_sql()`, and it would provide no protection. See https://developer.wordpress.org/reference/functions/esc_sql/#comment-253

I just thought I'd leave a note. It is safe right now, but if someone refactors things in the future and doesn't realize that `esc_sql()` is being misused, it could cause a vulnerability to be reintroduced.


Nennen wir die sonst nicht immer JoystickMutex etc.? SensorMutex?


True, strange it got cut-off. But I forgot the engine prefix though.


Done


Benennung, siehe oben.


Schreibfaul


No just tools for Aeria Games, i only work for the eden eternal part because since some week i have no time for this, so when the code and ui rework has finish i can work fully free time on others projects.

Functions supported by my tool:
- Themes market ( actually host on my dropbox, but you can modifiy the themes list file for custom host)
- Enhanced Settings ( acually not very usefull but if i have a time i upgrade this part of tool)
- DxDiag Pastebin ( You can obtain a pastebin link with your full dxdiag in 2 clicks )
- NLS Checker ( On some repack windows this cause a "OpenFile Error For Load DB" )

Note : The NLS Checker will probably upgraded for automatic fix ``Registry entry`` & ``NLS File``


then really make it private. see http://stackoverflow.com/questions/1567400/how-to-make-the-class-constructor-private-in-ruby


Hier bitte auch richtig beneennen


@sarina - OK - I resubmitted.  Let me know if the current submission is ok.


That's perfect, makes totally sense. I wasn't aware of that flag.
It seems I need get use to what we have now.
Thanks for the tip and for looking after my commits ;)


i don't change them - visual studio formats it like that automatically when i fiddle or cut/paste the line


ein "e" zu viel


Give me a bit to package a firmware update for it. I have them ready for D800 and D801, just not D802 right now.


I think that should depend on the decoding algorithm. Plain phrase-based
decoding --- agreed. Chart decoding with sparse features might bring the
machine to its knees. Ideally, moses should monitor its resource use (or
available resources) and adjust the number of active threads accordingly.
Especially when the machine starts swapping, moses should reduce the number
of translations it runs in parallel.

- Uli

On Tue, May 19, 2015 at 4:30 PM, alvations <notifications@github.com> wrote:

> All cores -1 sounds more reasonable. Just in case, somethings needs to be
> attended urgently while moses is decoding.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moses-smt/mosesdecoder/commit/59071bf16c4fcbf536baf58b514a52956b955e7e#commitcomment-11264467>
> .
>

--
Ulrich Germann
Senior Researcher
School of Informatics
University of Edinburgh


For me I have no problem with ffmpeg and branch d3d12 on VS 2015, it compiles perfectly.


Yep!


`information`이라는 단어는 안 쓰는 게 좋음. 있으나 없으나 의미에 차이가 없고 비 객체 지향적인 구조를 허용하는 경향이 있어서..


Deveria ser @trecenti na mensagem de commit. Oops! :)


Cloning the view variables should work.


fix on 27020)


This is one sick grammar!


Haha, no worries :)  Great you discovered our little boilerplate.


fix is ok.
thanks for your help.
best regards...


@emfuller this is really beautiful! so so nice! i really dig the miles/yr calculations. one question - the slide with boxplot figure showing # communities on y and 65minus and 65plus... what is # communities here?


Não é criação de interface gráfica amigável coisa nenhuma, eu errei, é alteração no modo como envia os emails


Wow.


I don't know a better way. It feels as if a more general kind of abstraction of the path should already exist in the app, but if it does, I can't see it.


It isn't a typo:P I wanted to stay true to the commit message and everything:)


Perhaps then just loop over the whole thing?
```python
self.repos = map(lambda repo: repo if isinstance(repo, Repo) else Repo(repo), self.repos)
```


This commit fixes #292 and #278


how about going with Liling's idea and see how it goes? Anyone want to code it?

ken - is it better to be conservative and reduce lmplz default memory usage to ~2%? In a multi-LM/interpolated LM config, using 20% causes training to smack into a brick wall


You'd just have to code it in at server level then pass to the client like "MapDarkLight".


Aaron,

I confirmed that we can modify the code and merge the version with a single server side port. Please let me know in case of any other questions/suggestions.

Regards,
  Jakub.


I would remove the , before the or


for the same?


Sorry guys, added a note to the [Readme](https://github.com/keighl/mandrill/blob/master/README.md#upgrading-to-10) about it. But it was a little whack with 2 error responses.


94895030-BasementFileRunTime (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1655 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


That is much simpler. I like it


Ah. great catch! That's actually supposed to be latitude, not number of
communities. doh. I'll fix that.

On Tue, May 19, 2015 at 11:42 AM, mikprov <notifications@github.com> wrote:

> @emfuller <https://github.com/emfuller> this is really beautiful! so so
> nice! i really dig the miles/yr calculations. one question - the slide with
> boxplot figure showing # communities on y and 65minus and 65plus... what is
> # communities here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaycole/fish_shift/commit/612e125d279f3bac5dac1aa6d3908d418ee85cc0#commitcomment-11264740>
> .
>


I'm a bit nervous of a URL path created like this. I wonder whether there's some escaping which might be missed. I'm not exactly sure how to do it in the context of this code, but I think it would be better to construct the URL path using the appropriate Rails helper method based on a Hash like [this one](https://github.com/alphagov/smart-answers/blob/master/app/controllers/smart_answers_controller.rb#L94-L100).


I believe the phobia comes from a squashed CMake bug.
CMake used to parse and split unquoted variables passed to CMake commands as arguments, that bug has been squashed!

BTW, Dig the *`wishlist`* and *`needmorinfo`* flags on Issues... They are Awesome!
Can that be done to Pull Requests as well!

The Issue and Pull Request lists look awesome all trimmed up!

__*Thank you for doing what you do!*__

-Enjoy


now using the same algorithm as int_math_int64_pow_stub


@kevva Yeah, done. For some reason I had troubles with connecting to npm yesterday and I forgot about this. Thanks for the heads up!


It's probably just me, but I really fail to see your point and think you are not improving (to say the least) the SDK this way...


ile


aaaaa


It's so good! Thank you for making it.


뒤에 오는 숫자가 다 똑같으면 `.sm-` 하나 쓰는 거랑 effectively 똑같지 않나?


Remove the white space line here


It looks like this will "float" on master. Might it not be a better (or safer) idea to point to a tag?


TeamCity Azmq :: Build (Windows) [Build 125](https://78.46.71.115/viewLog.html?buildId=485&buildTypeId=Azmq_Build&guest=1) is now running


TeamCity Azmq :: Build (OSX) [Build 79](https://78.46.71.115/viewLog.html?buildId=486&buildTypeId=Azmq_BuildOsx&guest=1) is now running


TeamCity Azmq :: Build (Linux) [Build 95](https://78.46.71.115/viewLog.html?buildId=484&buildTypeId=Azmq_BuildLinux&guest=1) is now running


@mgruner +1 for your changes.

Regarding regexes: In some of my pre-filters it would be very hard to write regexes for post-filters while it is easy to write a regex for a pre-filter. Imagine several (nested) divs in a block where no div has a special class or id and you want to change the one of the divs... So it would matter if you write the regex for a post-filter or a pre-filter.

But with your change it's easy for post-filters, too ;-)


I was a bit torn on the issue. AFAICT most global variables are made all caps, but indeed, this isn't a global constant as well.


TeamCity Azmq :: Build (Linux) [Build 95](https://78.46.71.115/viewLog.html?buildId=484&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:10


TeamCity Azmq :: Build (OSX) [Build 79](https://78.46.71.115/viewLog.html?buildId=486&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:14


TeamCity Azmq :: Build (Windows) [Build 125](https://78.46.71.115/viewLog.html?buildId=485&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:17


I couldn't find one either. I was thinking about
```
([flow_name, 'y'] + responses).join("/").gsub("third_country", "ceremony_country")
```
in the two lines where I need it. It's tested by an integration test. But it doesn't feel good either.


Can we use a more descriptive key name for this? Like `sqlcipher.key.browser.db`?


Why make a separate struct for this? Why not just do `type ListOSImagesResponse []OSImage` if you really want a specific type for this? Using the returned value now means you always have to select the field `OSImages` and it also shows `XMLName`?

![screen shot 2015-05-19 at 17 50 42](https://cloud.githubusercontent.com/assets/4171547/7707354/98482084-fe4f-11e4-83df-493254ad7b9b.png)


아 정말 생각해보니 이게 min-width media query라서 -sm- 하나 쓰는 것과 같군!


Don't get the point of cores - 1.  People run make with twice the number of cores.  Using a thread per CPU doesn't make the machine come to a grinding halt, as demonstrated by the frequent Edinburgh occurrence of two people running on the same machine.  Memory pressure makes machines halt.

Hieu, I am coming round to lowering the lmplz memory below the current 80% default.  Maybe 50%?  But if you're running jobs in parallel through EMS, either this converges to a half-baked job scheduler in perl or a real resource manager like slurm.


für die präferenzen deiner sprites bin ich nicht verantwortlich xD


ah - this tweak wasn't meant to be in this PR.. oh well!


@bouthilx


SysAdmin can manage users.

All other things can be done by the other role.

On Tue, May 19, 2015 at 4:36 PM, Murray Steele <notifications@github.com>
wrote:

> Oh, I guess it's unclear because we had an "admins can't" scenario but no
> "threshold can" or "threshold can't" scenario to make it clear. Perhaps one
> for @yahoopete <https://github.com/yahoopete> to clarify?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alphagov/e-petitions/commit/86a9ebb6c224cdeb6b63e4bcb4ab29bfad4bffa8#commitcomment-11264601>
> .
>


Nooooooooooo ! :(


`Bytes.generateRandomBytes(Length).base64EncodedString`


I just pulled this update, and noticed that I get a linker error because of this line of code.  GLKQuaternionIdentity doesn't seem to be declared anywhere.


`stories`랑 `stories_of`에 해당하는 url이 따로 있었으면 좋겠음 (앵커말고) ajaxy하게 해보는 방법이 있지 않을까?


음 그러면 그냥 `user` 클래스를 쓰는 건가? 그건 너무 generic해서 별로일거같은데. user-container로 할까


I guess these things happens all because of these magic `&&` and `||`


broken link


looks good, dont forget to update godeps.


rax retry tests


I don't think we want this to be optional; we're not functional without it.


# i've been wondering

what is life? what is the purpose? why do we exist?
where are we? what is the universe? is it real?
is there life beyond what we know? do we know what we think we know?


따로 있을때의 장점이 뭐지?


Typo.


@cmherd DWMR (done with my review). Looks good. Press on!


The pattern actually must be "%d %%". Please also correct the following occurrences.


`user`는 완전 안 generic하지 (swindler 서비스 내에서 어떤 객체를 가리키는 건지 specific 한 의미를 가지고 있으므로)


@cmherd DWMR.


errrmm.. yea.


This kind of optional change silently results in the callback not being called, which will hang the background queue. Best not to do so.


Declare includes first - https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md#declarationorder


You can use .\SQLEXPRESS wich always points to your local machine ;)


`user`의 어떤 한 측면을 나타내는 visual element라고 생각하면, 그걸 어떤 단어로 표현할 수 있을지 생각해보면 좋음 (예를 들면 `profile`?)


뭐 story/hoyoon, story/of/hoyoon 이런식으로 가져온다는건가?


Typo: 'Unknwon'


Two other small fixes are probably obvious and not worth a comment, but this one is interesting. Rest of the code definitely tries to handle ordering, but I couldn't easily decrypt how. Maybe this sorting should be applied elsewhere.
@rklancer, do you have a quick idea? If not, just ignore this, this seems to work and probably doesn't hurt anyway.


It works on Community. But it's still missing on Subscription :-)
@baptistemesta Can you report this fix on bonita-web-sp please? Thanks.


If key is nil on creation, does that mean the DB is in cleartext?


Usage

CGPoint point;
UIView* anyView = UIViewController.view;

Dynamically  create UIView with drawing & touch delegate blocks
UIView* protoView = [UIView withCGBlock:^(UIView* view, CGContextRef context) {
        CGContextSetFillColorWithColor(context, [UIColor blackColor].CGColor);
        CGContextFillRect(context, view.frame);
        CGContextSetFillColorWithColor(context, [UIColor redColor].CGColor);
        CGContextFillEllipseInRect(context, CGRectMake(point.x-10, point.y-10, 20, 20));
 } touchDelegate:^(UIView* protoview, NSSet* touches, UIEvent* event) {
        point = [[touches anyObject] locationInView:protoview];
        [protoview setNeedsDisplay];
 } frame: anyView.frame];
 [anyView addSubview:protoView];

Dynamically inject touch delegate block into any UIView:
[UIView view: anyView addTouchesDelegate:^(UIView *view, NSSet *touches, UIEvent *event) {
        UITouch *touch = [touches anyObject];
        switch (touch.phase) {
            case UITouchPhaseBegan:
                NSLog(@"UITouchPhaseBegan");
                break;
            default:
                break;
        }
        NSLog(@"%@", NSStringFromCGPoint([touch locationInView: view]));
    }];


Since this was written (on the whole) by someone else, please add the source link https://eager.io/blog/smarter-link-underlines/ as a credit in the comments


@spilist 반대로 같이 있을 때의 장점은 뭐라고 생각함?
@CarsomyrJ 여기가 이미 `users#show`라서 그렇게 생긴 라우트는 아마 아니겠지만..


id and label talk about "miles" only - having it both in the pattern is not nice. I'd suggest to either only use "miles" for the moment in the pattern as well or to remove the unit from the pattern completely. Same for the following occurrences.


I had to force-push this because my git client removed the submodule for some reason when I tried to update it normally.


Can you confirm that it is always a decimal value (%d) and not a floating point (%f)?


:+1: was about to submit the same PR


음.. `user` 클래스가 객체 `user`를 표현할 때만 쓰이는 건 맞을텐데, Story의 일부로서 user 정보를 표현할 때도 `user` 객체를 쓰잖아. 그래서 단순히 user 클래스를 쓰는것보다 user-profile이라든가 하면 좋겠는데


아 이미 profile 얘기를 했군 ㅋㅋ


@adbrebs Can you move to sandbox.blocksparse? There is a duplicate right now.


## This is a markdown file


Nice one!


94895030-BasementFileRunTime (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1145 of 1145 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


@maxlazio 7.11.0 is not released yet, so it should be under that, shouldn’t be?


You need to use git submodule sync and git submodule update too


False is the default, so you do not need this line. Same for the other occurrences.


@Taitalus

Make sure for reporting, manual runs are taken care as well.


No, `copilot_connect_pilot` and `copilot_disconnect_pilot` still need to be implemented, but I became a bit bored with it. Also, I haven't verified yet that all the encoders and decoders transmit the required data and transmit it correctly. I'll merge `master` into this branch though, so it will be easier for other people to start working on it.


gdhgfhfd


What?


Problems with lib/style_check.rbLine: 5 :disappointed: Line is too long. [144/80]
Line: 13 :disappointed: Rename `has_required_arguments?` to `required_arguments?`.
Line: 33 :disappointed: Line is too long. [121/80]
Line: 46 :disappointed: Line is too long. [116/80]
Line: 56 :disappointed: Use `next` to skip iteration.


@jirutka it is not released yet but the release is underway with the stable branches created and RCs out. Only regressions are now added to the stable branch.


Any risk `pdf` could become valid?


@bmneely DWMR. Press on.


When on a 32 bit device , such as the iPhone 4 (or anything earlier than iPhone 5S), this issue arises at 13! not 21!.

Would it be possible to add some check like this ?

if (round([firstValue doubleValue]) == [firstValue doubleValue] && [firstValue doubleValue] > 0 && [firstValue doubleValue] < ((sizeof(void*) == 4) ? 13 : 21)) {


Nice, I didn't know about the `-P` option.  This will definitely come in handy in my own recipes.


with this, the viewport buttons work on mac now too


Might this be an expensive operation that you should not do on every call again? Better use a field.


@hakubo Do you think this should be removed or leave as-is?


This is not a valid detail for OFFLINE. Better simply chose NONE and maybe provide some message text.


looks like this line can be removed, and we need some space before the next function def below.


Sure.


I'm a strong believer in the [Oxford comma](http://en.wikipedia.org/wiki/Serial_comma). :)


@xenolinguist Well y'all don't currently tag releases of delivery-cli. :smile:

If we do choose to pin to a specific tag that is also usually done in the project definition:
https://github.com/chef/omnibus-chef/blob/master/config/projects/chefdk.rb#L37-L87


같이 있을 때는 처음 로딩에서 다 불러오니까 처음 로딩은 더 느리고 해당 탭을 눌렀을 때는 바로 반응하겠군.
그렇다면 실시간으로는 반영이 안될건데, 밑으로 스크롤했을 때 paginate를 쓰지 않고 ajax로 과거 컨텐츠를 더 불러온다고 하면 처음부터 ajax로 하는게 더 편할수도 있겠네.
다른 사람에게 공유하기.. 를 생각해보면 anchor 형태로 해도 URL 뒤에 `#`붙이면 되니까 괜찮겠다 생각했는데 이게 단순히 `#` 붙여서 되는게 아니라 해당 엘리먼트가 `active` 클래스가 붙어야 보이는 거니까..

뭐야 따로 하는게 훨씬 좋잖아?


Ok


This commit is a bit difficult to review as the diffs got lost through the refactoring. So I trust you that you did the right thing :-)


@nairdo ok, it's fixed now :)


You forgot the .gitignore.


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2125 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.59%25-yellow.svg)


and hope no one was using Util.unwrapElement ?


why ?


@Omicron7 my name is Harro. I'm an iOS developer from Cru. I was looking at using your theKey login view controller. I was trying to build this to see it in action and noticed that pod install wasn't working because cocopods now requires source statements at the top of your Podfile. Could you add these lines to the top of your Podfile please?
```
source 'https://github.com/GlobalTechnology/cocoapods-specs.git'
source 'https://github.com/CocoaPods/Specs.git'
```


and the comment below too :-) the function call should be enough


@bmneely DWMR. Looks good. Press on!


CONSTANT_VARIABLES: https://www.python.org/dev/peps/pep-0008/#id39

global_variables: https://www.python.org/dev/peps/pep-0008/#global-variable-names


You're right, I'll add a call to `unwrap` with a deprecated note


I don't have enough context to know for sure, but are there two many responsibilities on this one line? Fetch a doc from the network and parse it as JSON?


What is the purpose of DatabaseService ?


Hi @infil00p I think there is no 4.0.2 release in May, the release is 4.0.1 in May and it contains the Intent Functionality.
The bug about version downgrade I think it's in 4.0.0 release in April


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


The previous one were more magic. :) Here the `if` form would be longer as I'd have to write:
```js
if ( /^(get|post|head|put|delete|options)$/i.test( this.type ) ) {
	return createStandardXHR() || createActiveXHR();
}
return createActiveXHR();
```
Not sure how UglifyJS handles this.


Если выше есть rebuildCash(); то здесь обнулять кэш уже не нужно.


j'ai mis les marges gauche droite a 10 au lieu de 20 parce que les proportions sur les maquettes sont off cest pour ca ton 3x au lieu de 2x.  jai mis les marges a 15 pour tablette et 20 pour desktop.

jai laissé l'espace blanc entre les posts a 20 parce que ça a l'air moins pire.


I sign off on this PR.


I can't imagine anyone as mas would start generating data feeds that are PDFs. If they did, we would have to write a parser and that process would make the test fail

> On 19 May 2015, at 17:04, Dan Munckton <notifications@github.com> wrote:
>
> Any risk pdf could become valid?
>
> —
> Reply to this email directly or view it on GitHub.
>


It is for extensibility. What if the xml returns an extra piece of info in the future? The only way to return that's back to the user without breaking the backwards compatibility is this. This is a pattern that we apply in our .net sdk as well.


That clears that up then.  How about duplicating the scenario to show that it's not just sysadmins that can do this?


LGTM


I'm not sure how we've done role X can do Y and role Z can't / can stuff in the past, but this would make it explicit (and give us a test to change if we decided to change the permissions rules).


@bernardobrezende Oi, ficaria assim então?

var a = $('.tamanhoAlbuns');
	         $.each(albuns, function(i, album){
			          a.append($('<img/>', {src: album.images[1].url}));

Eu devo fazer a parte de css, js e jquery separadas por arquivo ou posso continuar fazendo no mesmo?


The moving around is to avoid ease overriding CSS for announcements in sidebar in the following commit. The announcements styling can be moved to another CSS file as long as it is parsed before the CSS for the sidebar, but that might also require moving that styling to another file, unless we set a `announcements.css`, `style.css`, `sidebar.css` order in `pootle_app/assets.py` (actually the order can be different as long as announcements is parsed before sidebar styling). I prefer to keep splitting to separate CSS files for a possible future PR.


done


Thanks @azturner!  That works great.


:+1: I will do that.


So the onMouseDown is fired before the blur ?
That's fortunate but might not be the case on each browsers.
The previous implementation has the ability to not car how the browser manage its events.


Add a test that covers the case when `getPosition() != getFilePosition()`


nit: can we consolidate the code style for cpuShares and memory here?


in this scenario you have to click on the timer before the stop event is triggered


Was there a reason to make this 4 functions instead of 2?


Well, what about the last two items in the 7.11.0 section:
```
  - Update Asciidoctor gem to version 1.5.2. (Jakub Jirutka)
  - Fix resolving of relative links to repository files in AsciiDoc documents. (Jakub Jirutka)
```

…is it gonna be in 7.11.0, or 7.12.0?


how will this work with content editable? or ajax which width changes?

This is not a great solution when you bare everything in mind sadly.


Если выше в createContact явно прописали rebuildCache();, то здесь обнулять кэш не нужно.


Esta es la manera old school de hacerla, esta bien, pero a mi tambien en lo personal me gusta mas la nueva:

```ruby
has_many :users, through: :categorization
```


Ok lets say this has been:

Func createhostedservice(requiredParams)

Try adding optionalParams into this w/o breaking the back compat. Or:

Func createhostedservice(requiredParams, optionalParams)

Try making optionalParams.Foo a required param without breaking back compat... Our SDKs autogenerated like .net, js, java document these params because they have the API spec. Since we are manually developing this,  we can't copy the API docs here because they will easily go out of sync from whats on MSDN.

 I'm not sure I get your point,  please feel free to open an issue.


We could use this to chain conditions, cool!


Aqui seria:

```ruby
has_many :categories, through: :categorization
```


If I'm reading this right, we're stubbing quite a low level API here in order to make `open(url).read` return what we want. Could the document fetching behaviour be factored out into an object in our own code maybe?


XXX in a comment means "this is a bug, be careful".
I don't think that is your meaning here.


[gulpfile.js/tasks/rev/rev-assets.js] - @greypants @solomonhawk


Yes, beautiful!


Здесь можно сразу пистаь return

return driver.getCurrentUrl().contains("/edit.php") && driver.findElements(By.xpath("//input[@value='Enter']")).size() > 0


@akbertram would you please review changes to JsonChecker? I'm not sure I followed your logic for alias (~)/id ($). Main thing is that fieldName can be placeholder as well, please check site-api.feature file for yaml stuff. Feedback is welcome.


I reviewed the two code paths side-by-side and it seems to me as well that they should produce the same results.


Did you mean to restore the delete method?  I had removed it the previous commit.


0x1C in this case stands for WC_FINANCES. And you should probably invalidate the whole class with `window_invalidate_by_class(WC_FINANCES);`


LGTM


No, why are you modifying every rule in the dag?  Don't do this!

The whole *point* of the wrapper feature is that `makeflow_submit_dag` will apply the wrapper script
to every rule automatically as it is run.  That way, we *avoid* making changes to the dag.

You can accomplish everything that you want to do with a single call to `makeflow_wrapper_add_command`.  Figure it out.


note:
on line 97, we did (line *2) +1 to account for the spaces between the letters.

I would like feedback on how we could have made our code simpler and less complicated. I think we made it more complex than necessary for the code block on line 95 and possibly line 124.

Thank you


It's not clear what this does -- can you refactor `actual.getTextValue().startsWith( placeholders.parseName(expected.asText()) + "_")` into a seperate method with a descriptive name so it's obvious what its being tested / why?


El modelo `user` tiene las llamadas del `before_create` y `has_many` etc sin mucho orden, lo que sugiero es que se agrupen por ejemplo:

```ruby
#validaciones
validates :email, presence: true
.
.
.
#Asociaciones
has_many :categories
.
.
.
#callbacks
before_create :generate_token!
```


Looks great!


Если в createContact явно прописали rebuildCache(); то здесь обнулять кэш не нужно.
А так у вас дважды идет перестройка кэша.


We strongly believe in the test driven development as well as building on top of previous work. Thus all the new code in this project should be 100% tested. Also other people have wisdom in style as well:
```
The Zen of Python
    Beautiful is better than ugly.
    Explicit is better than implicit.
    Simple is better than complex.
    Complex is better than complicated.
    Flat is better than nested.
    Sparse is better than dense.
    Readability counts.
    Errors should never pass silently.
```


Hi! Thanks for the pull request, and sorry for the slow response!

I have checked the code, but I am not able to see any difference to the report. The exception is the full report, where whitelisted rules gets tagged with both with [WHITELIST] and [IGNORED]. (This is not a wanted behavior, though.)

Perhaps I am missing something; could you please explain the scenario you are targeting?


There is a chance that https://github.com/nonsequitur/git-gutter-plus/pull/21 solves this problem as well, could you please give it a try?


здесь сразу можно return условия писать без if


:tada: